From xen-devel-bounces@lists.xenproject.org Wed Sep 01 01:46:19 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Sep 2021 01:46:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.176016.320410 (Exim 4.92) (envelope-from ) id 1mLFK9-0004Hw-VL; Wed, 01 Sep 2021 01:45:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 176016.320410; Wed, 01 Sep 2021 01:45:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLFK9-0004Hp-Rp; Wed, 01 Sep 2021 01:45:57 +0000 Received: by outflank-mailman (input) for mailman id 176016; Wed, 01 Sep 2021 01:45:55 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLFK7-0004He-Sa; Wed, 01 Sep 2021 01:45:55 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLFK6-0001Qh-4R; Wed, 01 Sep 2021 01:45:54 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLFK5-00038J-OF; Wed, 01 Sep 2021 01:45:53 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mLFK5-00037H-Nk; Wed, 01 Sep 2021 01:45:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=jTxFEIE/vbYKWqwn6R+xp/VWJmkfz42sx0L1t9O7P/w=; b=1R7fjffL51nYLsJJAzWqptgaZk mQ1W72i4DZPK/ciOK3fyE0HvUKnhLwZIji2SP0a+pfySkFVu1YZNUrKx9gvYVRVLyG/RBXEsSTp4M u4JSKniKLaJBEkoTxma+theWMriADxWw/ImWgypE49x1rqkPfYe3qnduQWqfzewhcyg0=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 164677: regressions - FAIL X-Osstest-Failures: libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=dea67b1de03dd0544b8d05322f4300abd44221bd X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Wed, 01 Sep 2021 01:45:53 +0000 flight 164677 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/164677/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a version targeted for testing: libvirt dea67b1de03dd0544b8d05322f4300abd44221bd baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 417 days Failing since 151818 2020-07-11 04:18:52 Z 416 days 407 attempts Testing same since 164677 2021-08-31 06:51:17 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Andika Triwidada Andrea Bolognani Balázs Meskó Barrett Schonefeld Bastian Germann Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Bjoern Walk Boris Fiuczynski Brian Turek Bruno Haible Chris Mayo Christian Ehrhardt Christian Kirbach Christian Schoenebeck Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé Didik Supriadi Dmytro Linkin Eiichi Tsukata Eric Farman Erik Skultety Fabian Affolter Fabian Freyer Fabiano Fidêncio Fangge Jin Farhan Ali Fedora Weblate Translation gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Hela Basa Helmut Grohne Ian Wienand Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen Jean-Baptiste Holcroft Jia Zhou Jianan Gao Jim Fehlig Jin Yan Jinsheng Zhang Jiri Denemark John Ferlan Jonathan Watt Jonathon Jongsma Julio Faracco Justin Gatzen Ján Tomko Kashyap Chamarthy Kevin Locke Kristina Hanicova Laine Stump Laszlo Ersek Lee Yarwood Liao Pingfang Lin Ma Lin Ma Lin Ma Liu Yiding Luke Yue Luyao Zhong Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Markus Schade Martin Kletzander Masayoshi Mizuma Matej Cepl Matt Coleman Matt Coleman Mauro Matteo Cascella Meina Li Michal Privoznik Michał Smyk Milo Casagrande Moshe Levi Muha Aliss Nathan Neal Gompa Nick Shyrokovskiy Nickys Music Group Nico Pache Nikolay Shirokovskiy Olaf Hering Olesya Gerasimenko Orion Poplawski Pany Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Richard W.M. Jones Ricky Tigg Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Shambarger Sebastian Mitterle SeongHyun Jo Shalini Chellathurai Saroja Shaojun Yang Shi Lei simmon Simon Chopin Simon Gaiser Simon Rowe Stefan Bader Stefan Berger Stefan Berger Stefan Hajnoczi Szymon Scholz Thomas Huth Tim Wiederhake Tomáš Golembiovský Tomáš Janoušek Tuguoyi Ville Skyttä Vinayak Kale Wang Xin WangJian Weblate Wei Liu Wei Liu William Douglas Yalei Li <274268859@qq.com> Yalei Li Yang Fei Yang Hang Yanqiu Zhang Yaroslav Kargin Yi Li Yi Wang Yuri Chornoivan Zbigniew Jędrzejewski-Szmek zhangjl02 Zheng Chuan zhenwei pi Zhenyu Ye Zhenyu Zheng Zhenzhong Duan jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 71401 lines long.) From xen-devel-bounces@lists.xenproject.org Wed Sep 01 03:02:14 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Sep 2021 03:02:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.176029.320424 (Exim 4.92) (envelope-from ) id 1mLGVi-0004Ja-S0; Wed, 01 Sep 2021 03:01:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 176029.320424; Wed, 01 Sep 2021 03:01:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLGVi-0004JT-P0; Wed, 01 Sep 2021 03:01:58 +0000 Received: by outflank-mailman (input) for mailman id 176029; Wed, 01 Sep 2021 03:01:57 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLGVh-0004JJ-4j; Wed, 01 Sep 2021 03:01:57 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLGVg-0007rS-Q4; Wed, 01 Sep 2021 03:01:56 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLGVg-0005wc-Ec; Wed, 01 Sep 2021 03:01:56 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mLGVg-00054f-E8; Wed, 01 Sep 2021 03:01:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=8XobyDTf2lcU9muUOeEgU4L9AZs5529FnQYkcyxysuM=; b=PYihxzdfiY+wI3VTce7ppsF7a9 vv6SuHrCXIO6JoZE8kDDgDWccJXh0luobnspQWPRz465EuZPuqv586J8V1vcyoT84Z277CQ5XIv5P 8XdScBPNdlEl4ABI+h859rhQd/AwCY1MoNE0G1DLBmfSsHwPv/yUsg5eGbK0jZZAUvLk=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 164674: all pass - PUSHED X-Osstest-Versions-This: ovmf=cae735f61328d64e2e8991036707b9e78c0f5f63 X-Osstest-Versions-That: ovmf=77d5fa80246e8784f89e109ff9dadfeb7089ff85 From: osstest service owner Date: Wed, 01 Sep 2021 03:01:56 +0000 flight 164674 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/164674/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf cae735f61328d64e2e8991036707b9e78c0f5f63 baseline version: ovmf 77d5fa80246e8784f89e109ff9dadfeb7089ff85 Last test of basis 164630 2021-08-30 01:10:45 Z 2 days Testing same since 164674 2021-08-31 02:56:52 Z 1 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Cheng Zhou Grzegorz Bernacki Hao A Wu Marvin H?user zhoucheng jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 77d5fa8024..cae735f613 cae735f61328d64e2e8991036707b9e78c0f5f63 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Wed Sep 01 03:42:26 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Sep 2021 03:42:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.176039.320438 (Exim 4.92) (envelope-from ) id 1mLH8m-0000VV-0Z; Wed, 01 Sep 2021 03:42:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 176039.320438; Wed, 01 Sep 2021 03:42:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLH8l-0000VO-Tc; Wed, 01 Sep 2021 03:42:19 +0000 Received: by outflank-mailman (input) for mailman id 176039; Wed, 01 Sep 2021 03:42:18 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLH8k-0000VB-Ay; Wed, 01 Sep 2021 03:42:18 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLH8k-0008V5-61; Wed, 01 Sep 2021 03:42:18 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLH8j-0007Fw-RX; Wed, 01 Sep 2021 03:42:17 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mLH8j-0002zx-R5; Wed, 01 Sep 2021 03:42:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=3cRJIUgaV9rvsdo7JA4CClURwVqpLPVUdy9w7ieAcig=; b=wtul7LEUaaGdu5/nX2p+REDfYG O41OgS0YWmA8LtbRvDOYAIGHoqq9BTLcgZkRZWkw/7ITQzeco35IlFVuJHECvf69Z6vEcpI/KKmk4 cNOhbLgwhIVZwDN/D1w2SfMxaM8iZgqca+LeqJEdlKeLnjo9bJPNYZsdsrN3kBrjio/Q=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 164667: regressions - FAIL X-Osstest-Failures: xen-unstable:test-amd64-amd64-dom0pvh-xl-amd:xen-boot:fail:regression xen-unstable:test-amd64-amd64-dom0pvh-xl-intel:xen-boot:fail:regression xen-unstable:test-amd64-amd64-examine:memdisk-try-append:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=daaf007eb3467f900a2e20fadbc4c6f3bfcaa356 X-Osstest-Versions-That: xen=a931e8e64af07bd333a31f3b71a3f8f3e7910857 From: osstest service owner Date: Wed, 01 Sep 2021 03:42:17 +0000 flight 164667 xen-unstable real [real] flight 164685 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/164667/ http://logs.test-lab.xenproject.org/osstest/logs/164685/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-dom0pvh-xl-amd 8 xen-boot fail REGR. vs. 164477 test-amd64-amd64-dom0pvh-xl-intel 8 xen-boot fail REGR. vs. 164477 Tests which are failing intermittently (not blocking): test-amd64-amd64-examine 4 memdisk-try-append fail pass in 164685-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 164477 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 164477 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 164477 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 164477 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 164477 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 164477 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 164477 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 164477 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 164477 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 164477 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 164477 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen daaf007eb3467f900a2e20fadbc4c6f3bfcaa356 baseline version: xen a931e8e64af07bd333a31f3b71a3f8f3e7910857 Last test of basis 164477 2021-08-25 09:09:48 Z 6 days Failing since 164499 2021-08-26 10:21:51 Z 5 days 4 attempts Testing same since 164667 2021-08-30 22:13:35 Z 1 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Jan Beulich Julien Grall Julien Grall Stefano Stabellini jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd fail test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel fail test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 518 lines long.) From xen-devel-bounces@lists.xenproject.org Wed Sep 01 04:18:21 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Sep 2021 04:18:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.176048.320452 (Exim 4.92) (envelope-from ) id 1mLHhN-0004GI-PL; Wed, 01 Sep 2021 04:18:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 176048.320452; Wed, 01 Sep 2021 04:18:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLHhN-0004GB-Lr; Wed, 01 Sep 2021 04:18:05 +0000 Received: by outflank-mailman (input) for mailman id 176048; Wed, 01 Sep 2021 04:18:05 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLHhN-0004G2-Cl; Wed, 01 Sep 2021 04:18:05 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLHhN-0000jw-0P; Wed, 01 Sep 2021 04:18:05 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLHhM-0000HV-MY; Wed, 01 Sep 2021 04:18:04 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mLHhM-0001g2-Lu; Wed, 01 Sep 2021 04:18:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=HlPBMqJT5Hy667227W42ZoYKc8DgyCKANZT0u7RdrhY=; b=FTOVzXIi8HGa7kY8q2vCArwiOD qu+bQHq/EvbWagU+dqzYG5t//ntA6CospY6wMzjtDSoCnb2U21fb6nPdO/wEFajPfaxgOtu554EOe HkadZFX4lNpFD+XQjDTrtpRv0pUOG9hVqRdY7/whopxFn22FvQ/07rfvANF50Gr5BZ/4=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 164673: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-i386-qemut-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-xl-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-examine:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-xl:xen-install:fail:regression linux-linus:test-amd64-coresched-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-i386-xl-raw:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-pvshim:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-i386:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ovmf-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/dst_host:fail:regression linux-linus:test-arm64-arm64-xl-credit1:debian-fixup:fail:regression linux-linus:test-arm64-arm64-xl-thunderx:debian-fixup:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:debian-fixup:fail:regression linux-linus:test-arm64-arm64-xl-credit2:debian-fixup:fail:regression linux-linus:test-arm64-arm64-xl:debian-fixup:fail:regression linux-linus:test-arm64-arm64-xl-xsm:debian-fixup:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=8596e589b787732c8346f0482919e83cc9362db1 X-Osstest-Versions-That: linux=deacdb3e3979979016fcd0ffd518c320a62ad166 From: osstest service owner Date: Wed, 01 Sep 2021 04:18:04 +0000 flight 164673 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/164673/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-qemut-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-examine 6 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-coresched-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-i386-xl-raw 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-pvshim 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-i386 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ovmf-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-arm64-arm64-xl-credit1 13 debian-fixup fail REGR. vs. 152332 test-arm64-arm64-xl-thunderx 13 debian-fixup fail REGR. vs. 152332 test-arm64-arm64-libvirt-xsm 13 debian-fixup fail REGR. vs. 152332 test-arm64-arm64-xl-credit2 13 debian-fixup fail REGR. vs. 152332 test-arm64-arm64-xl 13 debian-fixup fail REGR. vs. 152332 test-arm64-arm64-xl-xsm 13 debian-fixup fail REGR. vs. 152332 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 152332 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 152332 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152332 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152332 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 152332 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152332 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152332 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux 8596e589b787732c8346f0482919e83cc9362db1 baseline version: linux deacdb3e3979979016fcd0ffd518c320a62ad166 Last test of basis 152332 2020-07-31 19:41:23 Z 396 days Failing since 152366 2020-08-01 20:49:34 Z 395 days 683 attempts Testing same since 164673 2021-08-30 23:59:57 Z 1 days 1 attempts ------------------------------------------------------------ 6859 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl fail test-armhf-armhf-xl pass test-amd64-i386-xl fail test-amd64-coresched-i386-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm fail test-amd64-i386-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm fail test-amd64-i386-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine fail test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel fail test-amd64-i386-qemuu-rhel6hvm-intel fail test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair fail test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow fail test-arm64-arm64-xl-thunderx fail test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2036695 lines long.) From xen-devel-bounces@lists.xenproject.org Wed Sep 01 04:50:42 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Sep 2021 04:50:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.176057.320466 (Exim 4.92) (envelope-from ) id 1mLICr-0000wt-Ft; Wed, 01 Sep 2021 04:50:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 176057.320466; Wed, 01 Sep 2021 04:50:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLICr-0000wm-CZ; Wed, 01 Sep 2021 04:50:37 +0000 Received: by outflank-mailman (input) for mailman id 176057; Wed, 01 Sep 2021 04:50:35 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLICp-0000wf-KL for xen-devel@lists.xenproject.org; Wed, 01 Sep 2021 04:50:35 +0000 Received: from mail-lj1-x22d.google.com (unknown [2a00:1450:4864:20::22d]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 7942cd84-54e6-4fb6-86b6-aad24475e815; Wed, 01 Sep 2021 04:50:34 +0000 (UTC) Received: by mail-lj1-x22d.google.com with SMTP id s3so2618941ljp.11 for ; Tue, 31 Aug 2021 21:50:34 -0700 (PDT) Received: from [192.168.10.179] ([185.199.97.5]) by smtp.gmail.com with ESMTPSA id e15sm2383177ljn.25.2021.08.31.21.50.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 31 Aug 2021 21:50:32 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7942cd84-54e6-4fb6-86b6-aad24475e815 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=fp+l23ni8nD//u350996azMCPKCUo56T7jjZIzLPNDY=; b=LTZvKfPGCOt6z6sq51v4QCbm+YcdSuPPrXAbAWO9F0OjfFVFoXJOhtldbXUEgy/xMX ccC/gEbZPAr3+yTuyVGxI6bT16BGcGY22OPmd7ue3vWOZfA1ybc2/7kpcebA5gPn1bfA pAlKMp26Z6jeJ8JkwnV7oq7G0kplYcbb6e/BVn+CdXgx0y5jWT6La6uDAkjKpqycdgk2 EZygunRC8ILxteP56YbI/Lt5m7VadKcj2HGnbkp/Pw/0wRSGJNhvNQUA8F/qfaCXEiaD sMUsEe6cFYQj5Ddz0dJ/D0gpc4e+uU9BmRSwlYvQvW2DLBFLp+4rw6+wnR+NaJQyrlA6 w18w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=fp+l23ni8nD//u350996azMCPKCUo56T7jjZIzLPNDY=; b=CUhjZNBYH0K/9VZjTzOrzAI9/hRAGYDQ79GYmI2rO+IcoGuW+SP9Nbg4lD8bgnE4A5 xmJ5ejTnGJStvJYjlOmT/YsW6Zi3TU4Nd3WVtGkOTx2yaOHI5ucNe52sxdz6XQe6XzXj NitLm+VUcVxTYF6ls6rrqDbLRDYCe7h2tvfqhHwyyCVOmgRwP1YpH8vfAmiC6guZd67R UsCMG7ms3xhe89zlcbz7WrH+H8CB63VZzZs7//6UhdUZBtSUZA1ejmFbGJFRy7Pzc1UZ xF1rLqbLpNsH/Bu+9x9K+27dXgPEM+lUKTzxhZjuX91CJ03VfeLxPJ99HD5Iv1KekLaR ziJg== X-Gm-Message-State: AOAM531ZCJDEOKk7QugCyn7KpTvY5+lrhJ8RzVqcy5Aq/50U3mhHiILX 1pNeIFZgweobp4aX70ZJ+m94B41Zodw4Xw== X-Google-Smtp-Source: ABdhPJy+09EttPJHJkf6WstYZk8w+26229ZqHGUmytKZbcF+xhAAFrwoPcd32nxOFA0MKVR4+xFrDw== X-Received: by 2002:a05:651c:200e:: with SMTP id s14mr28530367ljo.306.1630471832844; Tue, 31 Aug 2021 21:50:32 -0700 (PDT) Subject: Re: [PATCH RFC] vPCI: account for hidden devices in modify_bars() To: Jan Beulich Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , "xen-devel@lists.xenproject.org" References: <6285981f-683f-a043-7025-993613eaea7c@suse.com> <3a6ca3ac-8771-2a80-285e-701c5c1b8343@gmail.com> <956dd02c-553e-6aa2-eedf-28703a6ded32@suse.com> <13eb638e-c3c5-6794-c828-04c66bb2bd2f@gmail.com> <8295cd88-4e4e-4189-cf27-ce83823357df@suse.com> <1f571749-5d41-7c4d-8ca0-afc91d2f83fe@gmail.com> <2f81bc05-69e0-f3e7-4a50-67b40352efa6@suse.com> From: Oleksandr Andrushchenko Message-ID: <052efde6-bccd-b34c-ccbb-c2cc9f513f56@gmail.com> Date: Wed, 1 Sep 2021 07:50:30 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <2f81bc05-69e0-f3e7-4a50-67b40352efa6@suse.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US On 31.08.21 11:35, Jan Beulich wrote: > On 31.08.2021 10:14, Oleksandr Andrushchenko wrote: >> On 31.08.21 11:05, Jan Beulich wrote: >>> On 31.08.2021 09:56, Oleksandr Andrushchenko wrote: >>>> On 31.08.21 10:47, Jan Beulich wrote: >>>>> On 31.08.2021 09:06, Oleksandr Andrushchenko wrote: >>>>>> On 31.08.21 09:51, Jan Beulich wrote: >>>>>>> On 31.08.2021 07:35, Oleksandr Andrushchenko wrote: >>>>>>>> On 30.08.21 16:04, Jan Beulich wrote: >>>>>>>>> @@ -265,7 +266,8 @@ static int modify_bars(const struct pci_ >>>>>>>>> * Check for overlaps with other BARs. Note that only BARs that are >>>>>>>>> * currently mapped (enabled) are checked for overlaps. >>>>>>>>> */ >>>>>>>>> - for_each_pdev ( pdev->domain, tmp ) >>>>>>>>> +for ( d = pdev->domain; ; d = dom_xen ) {//todo >>>>>>>> I am not quite sure this will be correct for the cases where pdev->domain != dom0, >>>>>>>> e.g. in the series for PCI passthrough for Arm this can be any guest. For such cases >>>>>>>> we'll force running the loop for dom_xen which I am not sure is desirable. >>>>>>> It is surely not desirable, but it also doesn't happen - see the >>>>>>> is_hardware_domain() check further down (keeping context below). >>>>>> Right >>>>>>>> Another question is why such a hidden device has its pdev->domain not set correctly, >>>>>>>> so we need to work this around? >>>>>>> Please see _setup_hwdom_pci_devices() and commit e46ea4d44dc0 >>>>>>> ("PCI: don't allow guest assignment of devices used by Xen") >>>>>>> introducing that temporary override. To permit limited >>>>>>> visibility to Dom0, these devices still need setting up in the >>>>>>> IOMMU for Dom0. Consequently BAR overlap detection also needs >>>>>>> to take these into account (i.e. the goal here is not just to >>>>>>> prevent triggering the ASSERT() in question). >>>>>> So, why don't we set pdev->domain = dom_xen for such devices and call >>>>>> modify_bars or something from pci_hide_device for instance (I didn't get too >>>>>> much into implementation details though)? If pci_hide_device already handles >>>>>> such exceptions, so it should also take care of the correct BAR overlaps etc. >>>>> How would it? It runs long before Dom0 gets created, let alone when >>>>> Dom0 may make adjustments to the BAR arrangement. >>>> So, why don't we call "yet another hide function" while creating Dom0 for that >>>> exactly reason, e.g. BAR overlap handling? E.g. make it 2-stage hide for special >>>> devices such as console etc. >>> This might be an option, but is imo going to result not only in more >>> code churn, but also in redundant code. After all what modify_bars() >>> needs is the union of BARs from Dom0's and DomXEN's devices. >> To me DomXEN here is yet another workaround as strictly speaking >> vpci code didn't need and doesn't(?) need it at the moment. Yes, at least on Arm. >> So, I do understand why you want it there, but this then does need a very >> good description of what is happening and why... >> >>>>> The temporary overriding of pdev->domain is because other IOMMU code >>>>> takes the domain to act upon from that field. >>>> So, you mean pdev->domain in that case is pointing to what? >>> Did you look at the function I've pointed you at? DomXEN there gets >>> temporarily overridden to Dom0. >> This looks like yet another workaround to me which is not cute. >> So, the overall solution is spread over multiple subsystems, each >> introducing something which is hard to follow > If you have any better suggestions, I'm all ears. Or feel free to send > patches. Unfortunately I don't have any. But, could you please at least document a bit more what is happening here with DomXEN: either in the commit message or in the code itself, so it is easier to understand why vpci has this code at all... Thank you, Oleksandr > > Jan > From xen-devel-bounces@lists.xenproject.org Wed Sep 01 06:59:40 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Sep 2021 06:59:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.176064.320476 (Exim 4.92) (envelope-from ) id 1mLKDB-0006QW-NW; Wed, 01 Sep 2021 06:59:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 176064.320476; Wed, 01 Sep 2021 06:59:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLKDB-0006QP-KW; Wed, 01 Sep 2021 06:59:05 +0000 Received: by outflank-mailman (input) for mailman id 176064; Wed, 01 Sep 2021 06:59:03 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLKD9-0006QJ-Kj for xen-devel@lists.xenproject.org; Wed, 01 Sep 2021 06:59:03 +0000 Received: from smtp-out1.suse.de (unknown [195.135.220.28]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id c1e57438-37fa-409d-9e25-070c2e6561ae; Wed, 01 Sep 2021 06:59:02 +0000 (UTC) Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 97205224CB; Wed, 1 Sep 2021 06:59:01 +0000 (UTC) Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap1.suse-dmz.suse.de (Postfix) with ESMTPS id 62F5A13A1F; Wed, 1 Sep 2021 06:59:01 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap1.suse-dmz.suse.de with ESMTPSA id ZA3wFbUkL2HAcwAAGKfGzw (envelope-from ); Wed, 01 Sep 2021 06:59:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c1e57438-37fa-409d-9e25-070c2e6561ae DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1630479541; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dQEcCvQxlYcDyTgM3abdo+HELlzPwv5DmTjSLpwwCp8=; b=J5K5h0fWCcbU5znY17gvu3jIq9XGMSOEqgRfdujdPvWar8cF2r02uv3WQ1vXe5IOl4EUA1 p5wfzv3NtLvuyjh6pd5OYFU6xJ1Gb8QaQB/TGIil4sYnLScb6E32Rd2R5CHxHElybZnc6u SpWUq8AicsFlKqBRKha+VysN9apDjzs= To: Ian Jackson , Andrew Cooper Cc: Julien Grall , xen-devel@lists.xenproject.org, Wei Liu References: <20210730122643.2043-1-jgross@suse.com> <20210730122643.2043-3-jgross@suse.com> <24836.28.655841.510063@mariner.uk.xensource.com> <81a39ab5-5588-65ad-f1a1-7bfe0379b394@xen.org> <6ced9858-d425-887c-0045-1aad8521b826@suse.com> <9352f82a-1b43-4bf6-8b0a-5916627b7537@citrix.com> <24878.15168.981558.748531@mariner.uk.xensource.com> From: Juergen Gross Subject: Re: [PATCH v3 2/2] tools/xenstore: set open file descriptor limit for xenstored Message-ID: Date: Wed, 1 Sep 2021 08:59:00 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <24878.15168.981558.748531@mariner.uk.xensource.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="577crmY70HNGhRZXW3JEPSJJJKYN1HDBl" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --577crmY70HNGhRZXW3JEPSJJJKYN1HDBl Content-Type: multipart/mixed; boundary="ywNSWkD3TBAB3AsiWAojb1IzUR6xZNn5l"; protected-headers="v1" From: Juergen Gross To: Ian Jackson , Andrew Cooper Cc: Julien Grall , xen-devel@lists.xenproject.org, Wei Liu Message-ID: Subject: Re: [PATCH v3 2/2] tools/xenstore: set open file descriptor limit for xenstored References: <20210730122643.2043-1-jgross@suse.com> <20210730122643.2043-3-jgross@suse.com> <24836.28.655841.510063@mariner.uk.xensource.com> <81a39ab5-5588-65ad-f1a1-7bfe0379b394@xen.org> <6ced9858-d425-887c-0045-1aad8521b826@suse.com> <9352f82a-1b43-4bf6-8b0a-5916627b7537@citrix.com> <24878.15168.981558.748531@mariner.uk.xensource.com> In-Reply-To: <24878.15168.981558.748531@mariner.uk.xensource.com> --ywNSWkD3TBAB3AsiWAojb1IzUR6xZNn5l Content-Type: multipart/mixed; boundary="------------2FA5F4FC3F8FB8D34C158FAB" Content-Language: en-US This is a multi-part message in MIME format. --------------2FA5F4FC3F8FB8D34C158FAB Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 31.08.21 16:22, Ian Jackson wrote: > Andrew Cooper writes ("Re: [PATCH v3 2/2] tools/xenstore: set open file= descriptor limit for xenstored"): >> xenstored is TCB.=C2=A0 It needs a large number of FDs, and can be tru= sted >> with unlimited. >=20 > I baseically agree with this. >=20 >> Also, like xenconsoled, we can calculate an upper bound, which is >> derived from the ABI limit of 32k domids. >=20 > IMO the default should support at leaat this much. >=20 > However, I don't think you are right, because xenstored offers console > connections to (possibly arbitrarily many) local socket connections. >=20 >> All you're haggling over is the error semantics in the case of: >> 1) the upper bound calculation is wrong, or >> 2) there is an fd leak >> >> Personally, I think a fixed calculation is right, so fd leaks can be >> spotted more obviously. >> >> An admin knob is not helpful - higher than the upper bound is just >> wasteful, while lower will cause malfunctions. >=20 > I don't agree. Firstly, on a technical level, your statement is true > only if the admin does not know they will be running a much smaller > number of domains. Secondly, we have had several people saying they > want this to be configurable. I think if several people say they want > something to be configurable, we should respect that, even if we think > the use cases for it are marginal. If there are hazards in bad > settings of such a know, that can be dealt with in the docs. >=20 > Julien's point about not having the limit set by xenstored itself is > very well taken. >=20 > ISTM that the following scheme is in the intersection of everyone's > requirements: >=20 > * The limit will be adjusted/imposed in the startup script. > * An /etc/{default,sysconfig} parameter will be provided to > adjust the setting. > * The default should be `unlimtied` since we cannot calculate > a safe upper bound for all configurations. > * Systems like Citrix Hypervisor (XenServer) which can calculate > a safe upper bound can do so, and adjust the default, enabling > them to spot fd leaks. Makes sense for me. So this would mean: - the sysconfig parameter will no longer be "number of domains", but the fd limit of the Xenstore daemon - default should be "unlimited" - the comment should mention the current number of fds needed per domain (5 for HVM, 2 for PV/PVH) plus some headroom in dom0 (without any guest running on my test system 21 fds are active, so I guess a value of 50 seems appropriate) Is this okay? Juergen --------------2FA5F4FC3F8FB8D34C158FAB Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Transfer-Encoding: quoted-printable Content-Description: OpenPGP public key Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy= cWx w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O= f8Z d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y= 9bf IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq= G7/ 377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR= 3Jv c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA= QIe AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT= hpw dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0= MbD 1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv= oPH Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v= 5QL +qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ= 2Vu IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC= QoL BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr= Wf0 teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC= /nu AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh= ITT d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm= XBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz= 80h SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC= AcD AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn= FOX gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1= jnD kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0= N51 N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l= otu fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1= tqS EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA= hsD BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3= g3O ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5= dM7 wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5= D+j LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm= V2x AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N= Eaw QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW= nHI s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR= wgn BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV= bVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk= pEd IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA= QAB wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw= Tbe 8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1= vJz Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8= VGi wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW= svi uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX= zXs ZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------2FA5F4FC3F8FB8D34C158FAB-- --ywNSWkD3TBAB3AsiWAojb1IzUR6xZNn5l-- --577crmY70HNGhRZXW3JEPSJJJKYN1HDBl Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmEvJLQFAwAAAAAACgkQsN6d1ii/Ey/m LAf/augriOmlOWBkKyHqCAop9REFqosu6ecM2bTY+wMEDH1eViKcztGSHMRS5bMWh7B9vhJNrZGR JAyQ4TZCDniurFuESay4A6up1MAgzomB9ha8LoubESK34kjoias1CO86XQz95+1+2KyRquf7qgaE dIAuGCHhlobBhHyzFqZ3p5VYJZJGdrtluZpKHy94r/588EJQtSkZh2S9ewFoRtE4bdLB8C5FwmSB YWCWvqV0fKUDF1wE+asz/zK0yyZckk3vIXwhj5LSWDrC7EC/Odtq1foUakyzxwEDNu0wX+rqiURy KHOR6jqqXYS9d915P5B6BjZi7qgVJC/9+QjplC6/Bg== =YC3z -----END PGP SIGNATURE----- --577crmY70HNGhRZXW3JEPSJJJKYN1HDBl-- From xen-devel-bounces@lists.xenproject.org Wed Sep 01 08:09:23 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Sep 2021 08:09:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.176075.320488 (Exim 4.92) (envelope-from ) id 1mLLIk-0006SQ-BL; Wed, 01 Sep 2021 08:08:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 176075.320488; Wed, 01 Sep 2021 08:08:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLLIk-0006SJ-8P; Wed, 01 Sep 2021 08:08:54 +0000 Received: by outflank-mailman (input) for mailman id 176075; Wed, 01 Sep 2021 08:08:52 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLLIi-0006SD-Gd for xen-devel@lists.xenproject.org; Wed, 01 Sep 2021 08:08:52 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id d6da4e3e-0afb-11ec-adb6-12813bfff9fa; Wed, 01 Sep 2021 08:08:50 +0000 (UTC) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01lp2054.outbound.protection.outlook.com [104.47.2.54]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-19-1ZAPm3CeNW-nITZxRMk4-A-1; Wed, 01 Sep 2021 10:08:48 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR04MB7149.eurprd04.prod.outlook.com (2603:10a6:800:12e::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19; Wed, 1 Sep 2021 08:08:47 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4478.019; Wed, 1 Sep 2021 08:08:47 +0000 Received: from [10.156.60.236] (37.24.206.209) by AM0P190CA0019.EURP190.PROD.OUTLOOK.COM (2603:10a6:208:190::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.17 via Frontend Transport; Wed, 1 Sep 2021 08:08:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d6da4e3e-0afb-11ec-adb6-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1630483729; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Br8yhggrtkI50zpoT8ExDWcF1KSQhL1o7JlLr+hMIpo=; b=DGttOVKjp+4XjuuNSpPjOTAQxrvA+KmbR3umxmOdD1UuMPKuMzY6SSuYoqYVW/7WYojkVt iRM2EWJf4a//bUT7jyFfAA0nliIaomYoQSbY3IIgy/2N4KVjGTFEEIpRjKNbccUx11lPdG SO1SQp0wGbKN+PfXcFQvUoaWaHN0zRc= X-MC-Unique: 1ZAPm3CeNW-nITZxRMk4-A-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XK0kMNcnc8IIDbFp4NSqXfEuVXtBJbqr/l3V38eAN/6vjabGZfaA9x/ag1T1ffaYMp0oy6FZdsCU6tBFrURqL4pBAy/6AUimlcx8QGRpNCNwID2xgOLb4eDaExFETZsMRD6AzUa0wgbTeByrzmZAHlFGZrignhoYoXCjcKtYH8lOVkMpUkw9gEgxdfi4u3sCos84cJw3hc8N30ABhI3RhQso+t6X3Qg1eK2Ob1UrmymdPahs+vmvv+NweA13sz5Y/K7E/k8vwZIc/LqSG/OiukZiutaXRPt/n60HeNLevVwU7B3s0kvrfIqTFpTo5vPzZThRM68wnUtdu/wbpoIr/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=Br8yhggrtkI50zpoT8ExDWcF1KSQhL1o7JlLr+hMIpo=; b=PmhZhWD3JJ7+0BKLmeRO0TmzNX6ZRSbgKvQWMhMoe39WeH93upKIRYG7BMdccfF6kLYEj822vqtAZ/5r/SLzgLUvWcLGaFpymfKcoiUf3Hj3K6MLmvfqfjTy3TJEK2XwKtqis3U1TNs3Mb4qNetzvvPuh5MgbdcbHNqoGj/hyM+mkvyeGDSK9lFMsfsotZLalkT0jvmurKg/pJWRglGLIVgcKlNG7p+OybW1QA9xqYX4VQrh9WXiAmXs030nCK5XhqPLD0yhqqZXlhnL6ODtASPSW8yqmY/7oR+ibRxjmSOl98i2TWcuRKuD706f2IDyImfvjxVTBd5828ti8j0oug== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com; Subject: Re: [PATCH 2/4] x86/P2M: relax guarding of MMIO entries From: Jan Beulich To: Andrew Cooper Cc: Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , "xen-devel@lists.xenproject.org" References: <93ecc397-1293-69b1-e70d-3c5f9317229a@suse.com> <7f56c625-eee6-31c4-2d6f-bd7334867d83@citrix.com> <5d69d4c0-7a04-c3da-f971-616363c6d63d@suse.com> Message-ID: Date: Wed, 1 Sep 2021 10:08:44 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: <5d69d4c0-7a04-c3da-f971-616363c6d63d@suse.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM0P190CA0019.EURP190.PROD.OUTLOOK.COM (2603:10a6:208:190::29) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 88028a76-1fa9-4d90-1d36-08d96d1fb945 X-MS-TrafficTypeDiagnostic: VI1PR04MB7149: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: JlH//v+JTrd3af7F/8tMwKHhQacrJPN3kOQTbRdlylOu55HDqpqysai6Ybzaa6lf5Vv8hjFuW9XoSf26lVEv0O2Osrwt5QxyLuRRflMwR7GG2ZTxSo37cBHOjKTkaEbpfzsX94jzjt2+MeqkNgqYXRqHZuJBF+TpPrDAi7OaFrKvYTC3xjK2BeOJ+Qy4sPP3i7iDoOEJHIxzNIuk1plsrXypDHMwtJQNdAsqfOjsY2e1FVRFCksKbEdHMIbPl4tz5shnA58gwcUUSbH/I5dcp6HZBNTUfg2BMzuzmbdKmwx+w8l/jPaaQu0eah8gkbRriLs8qUWyvcjlaKJ1UnQcQKKP+d0hQbTAweSwJnbFxqjii/w1L4Bp9ZpAo16gPtH631/NtX5P2j/24Ll4QyrjTqjC8ExqhrfM/qh680s4OyMXsWkQ61PN2Aavfz3guhCKkIau3Uog5YASwuzREWLRj4nyPgJmlrA4gb8ntwSr8qC1FTGGbgp5CJkmDQ0VFGeYDYFGXnfOt2urC6SwBGGKMXNv5p1CtY1X7vactlE5L0nRsqRJ7WkaEjD8re+4Nb/3N9gP+uJqZjefbfhXy9MIWNjf13jEbl8MikzJSqlMbquU8mNh9qsUwPR+k9siA3vyH3J9P/PUxZP7+ylx+GRcyCXm/e+wbtB1QKniMFG3X10EvwjQoXneC7QbiM236uJTVPiabvnfPb88ujeFV5NtUZcdsYTfmup1XVCgkBdB5c8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(66556008)(66476007)(83380400001)(8936002)(66946007)(26005)(186003)(53546011)(316002)(16576012)(508600001)(6916009)(4326008)(2906002)(5660300002)(36756003)(2616005)(956004)(86362001)(6486002)(54906003)(31696002)(31686004)(8676002)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K0xIU0k3WDNUdU1ETi92bW40U2hJZFduKy9Zc2R6QVk1ajd4UmQyWFV0UEhK?= =?utf-8?B?MnZGVWRLblRjMUM3bGxuMUlYeU53SFllbnMwWFVsNjI2NjR1bmsveFp3b3Mv?= =?utf-8?B?bS9MYzlUS2krZzFuVlJGZlJybC81bHBTWHBtS01weVNOLzdvMDlJNWMramFW?= =?utf-8?B?OFFWR0FrZ0o0b1lqZWNWK1M4OVRCa0VzYWxFV0ZCQ0pNRjF4L1pPZGoxWnY0?= =?utf-8?B?VGNNSlFwYUJVTThKN0NtVzNDeUZZa2RRN3pFK3MwNis1aGovYnlFcjJVMGZS?= =?utf-8?B?YS96bHBqUlRGV0dnNlpFMm9vVEVmMDZhaWYxb0VadTFydmN6a0t6VVN5N1Vi?= =?utf-8?B?ZDRvaEM2bmt1RU9OclhMb2JTWkFsUGxLN0JtTittNTZ4WEF2dE5YWlBoQUpR?= =?utf-8?B?bTVzUWZBNVViWXZUTmQzb2xoMUN6b1IwNzVVeUR4aHkvMTd2N2RRVTZXYlhI?= =?utf-8?B?MzJjbmlINkd6Z2FhOWVEbkZSKzhxRW85YTBkM3ZTYzF1cDFteFd2aFlQaGxE?= =?utf-8?B?K1l0eGp2aEowMllVbVZzMDZjMkVKNkFnSjdrUGV1aEdaaTVNNFJHVGxZOE00?= =?utf-8?B?dWtQWDgxNzNMSjh2UTN6K2srdG9ZUFFEK1NRUU1zcWJ3TjNXa1gzeVlMV0g0?= =?utf-8?B?S3VRSm90RWlSU0swRGQxdTJBZGtzb01odjk1WTFKRWZETnUrNVBydUhhKzNH?= =?utf-8?B?VEZVMzk3NzV6ZktIQlBIWDhFMVdVV3BiOEhyNGV5WGpzbURTN0RJQU80Y3NF?= =?utf-8?B?MHRuMVhybEpNLzNZUlBPbzRYMmdSWnpOUmJ3UUZMdTMvK0NDZ013RW4wVHV6?= =?utf-8?B?SnUxSnZGeTZMQmtSVnhYS2pnTTkxaEg5SEJaRzU3b3hLR0RRampZTW5GUWZj?= =?utf-8?B?SXFwR2VrbDhRaERiazJuSGdMUjNrR1JDQmRjTG9PWFkwdVhuWnBSRmd0b0Ru?= =?utf-8?B?Qnh5akJNMEhLQTRBdkRla1RFL05IMUcwM0Y1ZEg1cUxnN0ZFVHQ3ZnMwMmhR?= =?utf-8?B?VEFRbHAyeUdHTzlERTVMMmJHaTJyZGE5Tk1YTmhlNTFQajlJNVpWaGhWUjJ4?= =?utf-8?B?QWxGbnd2Z292N0xVWG9qeEZ3Z0dicWNCaTZkZy9Wa01pcmw0NStoVERTSVlC?= =?utf-8?B?c3d6UGgvYmw2cjZ4MFZzWTkzc2V6clVuRlJZdmNPR2ovaGxwdzdlejZzQW4r?= =?utf-8?B?aDFEdXZUNWZvaitZZU5KcFNTRGFmZnNNU1hETTNnaTRjTmM5VHdqRFpJdnNY?= =?utf-8?B?WmNYZTQwY0dTL2Mzb1NSa2lHUTdwUUhJcFNFY3M1VkZTczcrTDllWlMzNTJF?= =?utf-8?B?Nko5SjJmYm51VVZPTm5mRUVuUkU5WnAxSFEra01MeGVYYkJsU0hkNnVQZ1FW?= =?utf-8?B?K05oc3pkZUkvMWRCK3RHNDZIOXQ5ZWh6cEhlalpXdTE2amJmOXBrbThDSTdw?= =?utf-8?B?aEVIaFdwZDB4SG9ZRm9LQkh5SUxRNWdaTWZVV3NsRVlqOVNFWW1hVnU5VE1I?= =?utf-8?B?YW9sM2hIakZBc2dMdnNEYmxiVkNCS25yUEc0cTR1cStMa2ZKbE1MNldxeXpG?= =?utf-8?B?a1lwODRnOVN6aUZTZEZSaCtXcXFTUm5IbXc2MnBlMExIYnd2NmdyT1A3cmlR?= =?utf-8?B?QXBPdVpXZmV4QSt5Sldxdm0yRzR1TTA2L3VVQWRQdDZQRWRiYURNSW9RYzJS?= =?utf-8?B?UzlBdXRyUlN3N24xNHRLQVNoaE1EU0Vhd1VTYXVUZWI0ME8yMTM0Y01wYzdr?= =?utf-8?Q?d6vt6pny/6sHE7GH6ytvCtHIofq/vrN9mPT2M4x?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 88028a76-1fa9-4d90-1d36-08d96d1fb945 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Sep 2021 08:08:47.1462 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: H07kQ+VnfEDTR9YzU6avt6aMhjdjt8l2aBaze/323buka/D6ZHbk3v/s4sdqad2cXJih/Z32rQxVLZdyghRR5Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7149 On 31.08.2021 17:38, Jan Beulich wrote: > On 31.08.2021 17:25, Andrew Cooper wrote: >> On 31/08/2021 14:26, Jan Beulich wrote: >>> On 31.08.2021 15:16, Andrew Cooper wrote: >>>> On 30/08/2021 14:02, Jan Beulich wrote: >>>>> Further permit "access" to differ in the "executable" attribute. While >>>>> ideally only ROM regions would get mapped with X set, getting there is >>>>> quite a bit of work. Therefore, as a temporary measure, permit X to >>>>> vary. For Dom0 the more permissive of the types will be used, while for >>>>> DomU it'll be the more restrictive one. >>>> Split behaviour between dom0 and domU based on types alone cannot >>>> possibly be correct. >>> True, but what do you do. >>> >>>> DomU's need to execute ROMs too, and this looks like will malfunction if >>>> a ROM ends up in the region that HVMLoader relocated RAM from. >>>> >>>> As this is a temporary bodge emergency bugfix, don't try to be clever - >>>> just take the latest access. >>> And how do we know that that's what is going to work? >> >> Because it's the pre-existing behaviour. > > Valid point. But for the DomU case there simply has not been any > pre-existing behavior. Hence my desire to be restrictive initially > there. Further to this: Using the last-value-set approach also puts us at risk of running into a similar issue again when the ordering of some operations changes elsewhere. Jan From xen-devel-bounces@lists.xenproject.org Wed Sep 01 08:20:47 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Sep 2021 08:20:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.176082.320499 (Exim 4.92) (envelope-from ) id 1mLLTx-0000SK-IK; Wed, 01 Sep 2021 08:20:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 176082.320499; Wed, 01 Sep 2021 08:20:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLLTx-0000SD-EB; Wed, 01 Sep 2021 08:20:29 +0000 Received: by outflank-mailman (input) for mailman id 176082; Wed, 01 Sep 2021 08:20:28 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLLTw-0000S7-0h for xen-devel@lists.xenproject.org; Wed, 01 Sep 2021 08:20:28 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 5b44084a-c6c9-4fc4-8545-5cb7d020362e; Wed, 01 Sep 2021 08:20:26 +0000 (UTC) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01lp2053.outbound.protection.outlook.com [104.47.0.53]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-3-qajYLHVMMY2npYd-QBHA5Q-1; Wed, 01 Sep 2021 10:20:24 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR04MB4943.eurprd04.prod.outlook.com (2603:10a6:803:51::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.23; Wed, 1 Sep 2021 08:20:22 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4478.019; Wed, 1 Sep 2021 08:20:22 +0000 Received: from [10.156.60.236] (37.24.206.209) by PR3P189CA0060.EURP189.PROD.OUTLOOK.COM (2603:10a6:102:53::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.20 via Frontend Transport; Wed, 1 Sep 2021 08:20:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5b44084a-c6c9-4fc4-8545-5cb7d020362e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1630484425; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nOlixGbmhdbdoOvOwStsrHan61/add9PscjBGtXzO5k=; b=fBOn3XossWF618Z/A3eI6iXX9GTIzaqsLg8Ld/xKY9DtfI/1zHnbgBHRmEpTPaTgdGPr3e LhD4dEIh2Hpqsx2SLC3QwFaBEId1v3MfSYhJpEFXavuYG9OUQHapMbkB1y41XAAPvBDsTG HE6LZs0e1iNCVWBf55ou28egVO3jYhk= X-MC-Unique: qajYLHVMMY2npYd-QBHA5Q-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FugZK8BywBKbAYT5Q3bZ5Ri8iaQirK+8uQe3t8N3VNOeFOqtADjqoXBH+M9WiQTumFS1TIBX4aBKbe5FkqYtEC5E/qHQxIqC5eEjihPMqxxWKz3u1h5KncnbL7OJ2uEOplpqbJGCOkO7EimS4dl87E0Enpes9h0RUNtCotPfaNnREXsEPRvHDIZD5dCtaq0Sp/C/1Y5B/rPCq16sdhPzS7P2km1tehtemNYGLZnLQtH8lncvH0zWsSGf3shufHB8QAFbSIUJwgfRY21MwiFV0ZhHlLBhpey7gIvja60ar/hSunzW4ozyfaQ4aj5XTjNt3rYp2k51tVNevwqEta+XUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nOlixGbmhdbdoOvOwStsrHan61/add9PscjBGtXzO5k=; b=dNTQ3HSHpNyXRfHWrOWk0pbjrUHC+fKOKsnSjYug/vvm3aHYxf/EmHhjT6jk5YWNAPWxLcqzTvos3XpDJ0qyjhpl94L1FyKH1d0y8D5Hqq9kQiF/jcGTtae/7ZV0efvXHm6ggT7e7AmMzrAFnT6fQYehZsSx2QHQNIE3KfgathEbyNmwpRygoUqFyp3CmF/pDRKwuYVVEImeEA2TA/cBZzsOBe4LVcNptZ14/WeAgnteiZaNV+VwZZ4XqEsb0YIeNjTSBK31oYg6uSoRKzRoDhyxROxHPP+dONLCozd736lxMnEfmZ2UdRBQAH8S+BWFS6VROshlSNWZEOvkr7OYqg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com; Subject: Re: [PATCH RFC] vPCI: account for hidden devices in modify_bars() To: Oleksandr Andrushchenko Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , "xen-devel@lists.xenproject.org" References: <6285981f-683f-a043-7025-993613eaea7c@suse.com> <3a6ca3ac-8771-2a80-285e-701c5c1b8343@gmail.com> <956dd02c-553e-6aa2-eedf-28703a6ded32@suse.com> <13eb638e-c3c5-6794-c828-04c66bb2bd2f@gmail.com> <8295cd88-4e4e-4189-cf27-ce83823357df@suse.com> <1f571749-5d41-7c4d-8ca0-afc91d2f83fe@gmail.com> <2f81bc05-69e0-f3e7-4a50-67b40352efa6@suse.com> <052efde6-bccd-b34c-ccbb-c2cc9f513f56@gmail.com> From: Jan Beulich Message-ID: Date: Wed, 1 Sep 2021 10:20:20 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: <052efde6-bccd-b34c-ccbb-c2cc9f513f56@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PR3P189CA0060.EURP189.PROD.OUTLOOK.COM (2603:10a6:102:53::35) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5eb9d599-0ed8-420a-5456-08d96d2157c1 X-MS-TrafficTypeDiagnostic: VI1PR04MB4943: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7hd4cg9hRXEaJJabae8cOR8zgdh5QaVO5snykEusDtvbnpqohPy9UVDWpPk7/AF+U6axjFAc7ix9gpy9xaxZHRL7hWKxVWGoVTfsAI456yLSnCSiEWjxxL5crTkLW6yZWlzj/yfgOmDz/gdF8//R7EDRFn0s5rfWSIxTf4UlKbXAAyHieTFihRT67QVahyOXlHUojCknkZu53rogwPNOWwvpexH5ue6Dhw/yLoJq1vB7Sk35MrHpYD+GC9zBTRWDtdiNsXbYrW2sXHoMhUwCwEeTFO2W8maHGoowMCQQVI/yAeQuVoCUItOiu8w770DBGu6zHpqXzuAd0v//Cs7XcFQSZNexdLU/WggtHgVMzV5Qtk4nH6EMQEmhwAF7j1FXoqBAR3fBR4/1QMRmOVqERU5YRC+tkd+mZFXXZY6hhTzuP/XgxqyqQl6aDdwKyKmtnwBcp/KpeKU7AHMpl9GI1JorGGXqloHuOsXiOBRvD6YQLEmJE+5gLr/5a7SazJcbhbIt4kt8hvr/errsZOdNZSYDdtp23ha1KQSFt5VhT+MLDVwJFBI1GEppk8gwuCsfDKSrnsUghPKyiz9WHkrwbNWvsG1PttHtWPxq7+7/ObRVss1cL8GrchcojHPj++p0m2ACdYGpmdQtFdo1CuLuU2J5MgO2G7rMSBD/uYIEJgg7gK2fVlIBk5acjogl+kM32WTwzDjppvtrUgzQYSHRodZ1qHvmjI8WQPKwXgqLEi4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(39860400002)(396003)(136003)(346002)(376002)(366004)(31686004)(53546011)(66556008)(8676002)(2906002)(16576012)(86362001)(66476007)(4326008)(2616005)(31696002)(36756003)(38100700002)(26005)(956004)(66946007)(5660300002)(8936002)(478600001)(186003)(316002)(15650500001)(54906003)(6916009)(6486002)(83380400001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RUJ6SEhJcXhHK0VKOUFteHBLa3ZlSTNpZHh2Q05nVlZ4NkZ1VkplMkt6UWtu?= =?utf-8?B?bUQ2V3J0eklnSGxsMm55eFRBREVxZWQvdVpUbGYyMkVWd1lnMVZ0ZjVocnBV?= =?utf-8?B?Z0drcTkrcFZDbld4dlRScEQ0MXdhUHZRYTNyblI3S2FxR1d1VDFoU2RwT3Av?= =?utf-8?B?QjBvazlNMnVIUzc1TFhvd0hPZVlSZVdDTm1UUlFkU0JIbkZMcHQybHBZcHh1?= =?utf-8?B?OW12bE1xZWNlV21Yb1hYUVNvdG1XK0NPZGR2TnE5RCtsbHAyNHoyYi84M0o5?= =?utf-8?B?VU1HSTdVRFNJdjJQTUZ1Y1F1VE5wN1RJU2ZDc1IxblhWRTJidSthYllQcHB6?= =?utf-8?B?Nk9WNTZjbmxSTlBGS0RNc2JINzFjSUs5TGFQMk5vVDZmb3ZwVWRyMmkyNmNQ?= =?utf-8?B?TjNtbE11T3J2VEo0azlULzEvUC9QNjlVM0g2TTJ0V01qNGRNT20vUlBFd0JY?= =?utf-8?B?VkdJd1JhMzlpM1VRNnBhdGpkYVREcTNMQ21VOFBxTFZ5eitoRGFNWTZxSDJU?= =?utf-8?B?UkI5VTRBb3hiSkVXUldQS0hIOTEwZitWQVZPR0RWNFN2dVk2R0UvdENJRTR6?= =?utf-8?B?MkRVb0NqWEp1OVQrNE9LalJGWTFtRFVBOWJxMUcySG9IMHk2WWRpMk9EdUwv?= =?utf-8?B?eXlwU2FQR01TWU0ySjhYK3Fmd2tiNVd3YVBPSFlIN0VleklQdVZFWHlRa09O?= =?utf-8?B?VUgyZ3d1V2U4SzMycnVZM2U0N3dobW9kb3k3M2h4OElLTUMzQ2hudVF6Njdn?= =?utf-8?B?eWlUem5ZN05sNTBmdHBUcGdsYjRFMWxoeXpndXFueVlSQTJtMzBWR01sMmlF?= =?utf-8?B?OXNNSnVDSVdTYXBCaTJsdkwrNlJ2M2ZtUG1XVEpxbG4yQUdubi9HUS96RFIy?= =?utf-8?B?c3NoWXJPMDJjbGFiN2xIS2UxanpPc3k5NU84enR6dEZyRjBsSWw2Z25ySmY0?= =?utf-8?B?eWk3YVcrQWVaUVZ5T2ZwOXFnZnRhakdBd0xKcDhXbDdjcWJDT2VzT29qZkJE?= =?utf-8?B?cTdXcHBRVHhydGNZelNLb09zY0hYa09sQS9reWJRdWhkZ1BBWmZXcjgzZjhW?= =?utf-8?B?Q0NPZ3M1UVB0N2FLYWY5T3RRVjZqQ1J0bjhXVHZMYytOTm03ZXkrK0FRcmQr?= =?utf-8?B?NkF6YXJ4bE81aXhlQjBhOFJoS1ZVUTIxSENRZHEyT0FyQzFZVzlVVzZDMS80?= =?utf-8?B?MmphdTJYUkx5NW91N1cyTmg5M3VYeVJGMUY1MjZVQlZBcVQ3SzRsbFVsSzBE?= =?utf-8?B?d2FmSEd2QW9lRHF3Y3FGUGkzZDc0L2tnV2ZYSzZkajA5SlZMMk05MWFEVk91?= =?utf-8?B?YWVsYWZaMGRSVDg4UzdxeUxHN2lvUHhsSUduakhkSTNvYXdZL0oxYnVCdmhT?= =?utf-8?B?bUNYWm1ramlWMU1LcXJjZENoTFNvRWV1UVIyTmRXK2VSREZ6alJnT1IvRitS?= =?utf-8?B?MmludHJRV01wRS92bThHTElFSkZqUEhNYzBISnllUzgyb3NkYUpXbkYxbUM1?= =?utf-8?B?dzNxbE9paXlHa2Z3aG85b0U5dFdaMjFha21obGJaU2tCUHhiUVdGeFhrNm9R?= =?utf-8?B?dG9hSUV1Yzlta2FDTk45emtYbmtsVTNrOEZZM0hqc3FyaGFzT3ZSM0dUMHJ3?= =?utf-8?B?QnJseWNRdlpTZXlFV0hublczaWEvQWYxd09MWjNPRmtPVHVBRmJYQTJqalBI?= =?utf-8?B?TUxJOHlRR0dYSkV6eFRmWnRPSnZ2dEFkZTNXbmNja2d1NlBVN1N5S0loUkN6?= =?utf-8?Q?gzAGWXiqfGyiCz+Xj4xgPpXxgW/PpRt9tawvNc5?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5eb9d599-0ed8-420a-5456-08d96d2157c1 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Sep 2021 08:20:22.4111 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: r+/ghNczzfkfYIn82ugKg8uRStfxs23bm7Nc8WfHqbqYWD2lkQ5jwZJFoI6V5NgwP4mZP604IexPctRsDmyL/Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4943 On 01.09.2021 06:50, Oleksandr Andrushchenko wrote: > On 31.08.21 11:35, Jan Beulich wrote: >> On 31.08.2021 10:14, Oleksandr Andrushchenko wrote: >>> On 31.08.21 11:05, Jan Beulich wrote: >>>> On 31.08.2021 09:56, Oleksandr Andrushchenko wrote: >>>>> On 31.08.21 10:47, Jan Beulich wrote: >>>>>> On 31.08.2021 09:06, Oleksandr Andrushchenko wrote: >>>>>>> On 31.08.21 09:51, Jan Beulich wrote: >>>>>>>> On 31.08.2021 07:35, Oleksandr Andrushchenko wrote: >>>>>>>>> On 30.08.21 16:04, Jan Beulich wrote: >>>>>>>>>> @@ -265,7 +266,8 @@ static int modify_bars(const struct pci_ >>>>>>>>>> * Check for overlaps with other BARs. Note that only BARs that are >>>>>>>>>> * currently mapped (enabled) are checked for overlaps. >>>>>>>>>> */ >>>>>>>>>> - for_each_pdev ( pdev->domain, tmp ) >>>>>>>>>> +for ( d = pdev->domain; ; d = dom_xen ) {//todo >>>>>>>>> I am not quite sure this will be correct for the cases where pdev->domain != dom0, >>>>>>>>> e.g. in the series for PCI passthrough for Arm this can be any guest. For such cases >>>>>>>>> we'll force running the loop for dom_xen which I am not sure is desirable. >>>>>>>> It is surely not desirable, but it also doesn't happen - see the >>>>>>>> is_hardware_domain() check further down (keeping context below). >>>>>>> Right >>>>>>>>> Another question is why such a hidden device has its pdev->domain not set correctly, >>>>>>>>> so we need to work this around? >>>>>>>> Please see _setup_hwdom_pci_devices() and commit e46ea4d44dc0 >>>>>>>> ("PCI: don't allow guest assignment of devices used by Xen") >>>>>>>> introducing that temporary override. To permit limited >>>>>>>> visibility to Dom0, these devices still need setting up in the >>>>>>>> IOMMU for Dom0. Consequently BAR overlap detection also needs >>>>>>>> to take these into account (i.e. the goal here is not just to >>>>>>>> prevent triggering the ASSERT() in question). >>>>>>> So, why don't we set pdev->domain = dom_xen for such devices and call >>>>>>> modify_bars or something from pci_hide_device for instance (I didn't get too >>>>>>> much into implementation details though)? If pci_hide_device already handles >>>>>>> such exceptions, so it should also take care of the correct BAR overlaps etc. >>>>>> How would it? It runs long before Dom0 gets created, let alone when >>>>>> Dom0 may make adjustments to the BAR arrangement. >>>>> So, why don't we call "yet another hide function" while creating Dom0 for that >>>>> exactly reason, e.g. BAR overlap handling? E.g. make it 2-stage hide for special >>>>> devices such as console etc. >>>> This might be an option, but is imo going to result not only in more >>>> code churn, but also in redundant code. After all what modify_bars() >>>> needs is the union of BARs from Dom0's and DomXEN's devices. >>> To me DomXEN here is yet another workaround as strictly speaking >>> vpci code didn't need and doesn't(?) need it at the moment. Yes, at least on Arm. >>> So, I do understand why you want it there, but this then does need a very >>> good description of what is happening and why... >>> >>>>>> The temporary overriding of pdev->domain is because other IOMMU code >>>>>> takes the domain to act upon from that field. >>>>> So, you mean pdev->domain in that case is pointing to what? >>>> Did you look at the function I've pointed you at? DomXEN there gets >>>> temporarily overridden to Dom0. >>> This looks like yet another workaround to me which is not cute. >>> So, the overall solution is spread over multiple subsystems, each >>> introducing something which is hard to follow >> If you have any better suggestions, I'm all ears. Or feel free to send >> patches. > > Unfortunately I don't have any. But, could you please at least document a bit > more what is happening here with DomXEN: either in the commit message or > in the code itself, so it is easier to understand why vpci has this code at all... Well, the commit message imo already says what needs saying. I'll extend the pre-existing code comment, though. But of course the primary purpose of this RFC is to potentially have a better approach pointed out in the first place, which I guess will mean to wait with v1 until Roger's return. Jan From xen-devel-bounces@lists.xenproject.org Wed Sep 01 08:41:57 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Sep 2021 08:41:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.176090.320521 (Exim 4.92) (envelope-from ) id 1mLLoZ-0003gf-IB; Wed, 01 Sep 2021 08:41:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 176090.320521; Wed, 01 Sep 2021 08:41:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLLoZ-0003gW-Ex; Wed, 01 Sep 2021 08:41:47 +0000 Received: by outflank-mailman (input) for mailman id 176090; Wed, 01 Sep 2021 08:41:46 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLLoY-0003g8-Jl for xen-devel@lists.xenproject.org; Wed, 01 Sep 2021 08:41:46 +0000 Received: from smtp-out1.suse.de (unknown [195.135.220.28]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 6bfb126c-8bcb-45d2-88e5-aa0d8f88f6bf; Wed, 01 Sep 2021 08:41:45 +0000 (UTC) Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 9331A224EE; Wed, 1 Sep 2021 08:41:44 +0000 (UTC) Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap1.suse-dmz.suse.de (Postfix) with ESMTPS id 3C9CE13A1F; Wed, 1 Sep 2021 08:41:44 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap1.suse-dmz.suse.de with ESMTPSA id 1DRsDMg8L2E2DwAAGKfGzw (envelope-from ); Wed, 01 Sep 2021 08:41:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6bfb126c-8bcb-45d2-88e5-aa0d8f88f6bf DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1630485704; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=lY6W7YdH9RogZrDmgUL66tDU5fn1ekzHXvABU8NVPCk=; b=FDvA7u95dunxZ++Z2dqjc3UgCCiUDbMy7tOEsomdNbINdaVwegn64JBqyHT11g+CFg3gVG oHujdck7oVzYsAogsO2QZ/jC15Qq0r5ThseVCcDRwPx8/ofTetsvSz2daz6p14JUC1VDk4 2Fd8IAjVnClzuh5EMG/n71Ard5twfI8= Subject: Re: [PATCH v2] xen/pcifront: Removed unnecessary __ref annotation To: =?UTF-8?Q?Sergio_Migu=c3=a9ns_Iglesias?= , konrad.wilk@oracle.com Cc: boris.ostrovsky@oracle.com, sstabellini@kernel.org, bhelgaas@google.com, xen-devel@lists.xenproject.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, =?UTF-8?Q?Sergio_Migu=c3=a9ns_Iglesias?= References: <20210830175305.13370-1-sergio@lony.xyz> From: Juergen Gross Message-ID: Date: Wed, 1 Sep 2021 10:41:43 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210830175305.13370-1-sergio@lony.xyz> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="EIBqyqtMK8vKu3EwJk8AW3qWpsEnLpuIY" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --EIBqyqtMK8vKu3EwJk8AW3qWpsEnLpuIY Content-Type: multipart/mixed; boundary="q5YoPOE5vfxmkzIPMs0UKHG5VMG0bWMJ2"; protected-headers="v1" From: Juergen Gross To: =?UTF-8?Q?Sergio_Migu=c3=a9ns_Iglesias?= , konrad.wilk@oracle.com Cc: boris.ostrovsky@oracle.com, sstabellini@kernel.org, bhelgaas@google.com, xen-devel@lists.xenproject.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, =?UTF-8?Q?Sergio_Migu=c3=a9ns_Iglesias?= Message-ID: Subject: Re: [PATCH v2] xen/pcifront: Removed unnecessary __ref annotation References: <20210830175305.13370-1-sergio@lony.xyz> In-Reply-To: <20210830175305.13370-1-sergio@lony.xyz> --q5YoPOE5vfxmkzIPMs0UKHG5VMG0bWMJ2 Content-Type: multipart/mixed; boundary="------------20098A477538115561BD46D1" Content-Language: en-US This is a multi-part message in MIME format. --------------20098A477538115561BD46D1 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 30.08.21 19:53, Sergio Migu=C3=A9ns Iglesias wrote: > An unnecessary "__ref" annotation was removed from the > "drivers/pci/xen_pcifront.c" file. The function where the annotation > was used was "pcifront_backend_changed()", which does not call any > functions annotated as "__*init" nor "__*exit". This makes "__ref" > unnecessary since this annotation is used to make the compiler ignore > section miss-matches when they are not happening here in the first > place. >=20 > In addition to the aforementioned change, some code style issues were > fixed in the same file. >=20 > Signed-off-by: Sergio Migu=C3=A9ns Iglesias Pushed to xen/tip.git for-linus-5.15 Juergen --------------20098A477538115561BD46D1 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Transfer-Encoding: quoted-printable Content-Description: OpenPGP public key Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy= cWx w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O= f8Z d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y= 9bf IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq= G7/ 377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR= 3Jv c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA= QIe AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT= hpw dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0= MbD 1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv= oPH Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v= 5QL +qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ= 2Vu IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC= QoL BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr= Wf0 teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC= /nu AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh= ITT d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm= XBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz= 80h SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC= AcD AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn= FOX gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1= jnD kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0= N51 N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l= otu fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1= tqS EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA= hsD BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3= g3O ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5= dM7 wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5= D+j LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm= V2x AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N= Eaw QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW= nHI s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR= wgn BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV= bVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk= pEd IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA= QAB wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw= Tbe 8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1= vJz Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8= VGi wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW= svi uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX= zXs ZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------20098A477538115561BD46D1-- --q5YoPOE5vfxmkzIPMs0UKHG5VMG0bWMJ2-- --EIBqyqtMK8vKu3EwJk8AW3qWpsEnLpuIY Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmEvPMcFAwAAAAAACgkQsN6d1ii/Ey9B VQf9GD3+Dkl5gJyccur897+nZfeZsmoMHpvOmfVtaPU0CBegYsJwiGQvBxzxV7p1zx6dHvFPXltS jD55+SnSAAaLUG8UvaHCERGaKlv+RQBjbJTFnxVbBad3nYanzLfGSyGbNxpJnBJeYWNIpY4Fnxv4 gRZUtpqO6zjYx6O0d3ma9ENVNfG8YOdcGBniQ2HebwrNLc73BZs9sdfD70R/ODxikHd/RpTxqgQA 80P/rein9eYq54aJzTyifGagTyznwZ/cbNr+BNYpAyKEZ28M3D1abgFqYayp6jndrG1JtVEan8Mc cOU04sAiPy1ErjzFkSZppII+YOmvLdDwHxTeDAoNNA== =3NDJ -----END PGP SIGNATURE----- --EIBqyqtMK8vKu3EwJk8AW3qWpsEnLpuIY-- From xen-devel-bounces@lists.xenproject.org Wed Sep 01 08:41:57 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Sep 2021 08:41:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.176089.320509 (Exim 4.92) (envelope-from ) id 1mLLoK-0003Lz-92; Wed, 01 Sep 2021 08:41:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 176089.320509; Wed, 01 Sep 2021 08:41:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLLoK-0003Ls-64; Wed, 01 Sep 2021 08:41:32 +0000 Received: by outflank-mailman (input) for mailman id 176089; Wed, 01 Sep 2021 08:41:31 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLLoI-0003Lm-TE for xen-devel@lists.xenproject.org; Wed, 01 Sep 2021 08:41:31 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 66a61580-0b00-11ec-adb9-12813bfff9fa; Wed, 01 Sep 2021 08:41:29 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 66a61580-0b00-11ec-adb9-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1630485688; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=4JfLTFLOD28S5qrWhN3Gp2Z5R1EyEGIHqAO0UFHt04k=; b=gwm9To9WUxzREtbV40yqZnSLS2kdxBfSncz7sM2U/p/d9Fr6fKBDmbIC izyvwcaUwivUwca+hMV2YqPq5GB0CynkkgQ0e3Sbb8X8IkwEcRBXhGKB0 azNV/UGe1PxxNTM1H404Ygbh0Ux1CQeTMh2uYUHA2/erxO7z3jBazYnWT w=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: w8v8xFC/VqwLgk6a+nwW7EkKIIa4lKvOrNPcoipjKTx7NGZDsV7H4j/0aBjbpYX3JstoM8G0an ypX4iTeNKuwpu5MGQqzHjzV3kjW2m65//ahbrIOSJdB2950OkDq/3re3qX5sloO8rzKvFlwRby taZY2otOjjBYatG1q3CDWy6yUfLLflfLTuCzZ2GNoXcroJqIz64Zz2J/HZJ1zzqgGSCxRI20YM 5RcSFq457qkUtv1nyAKrjMGwTqMaoCkC/C0DPdIL3LtrA1Ak8U2rxUrhbFzSMTqbzKYw4u0YiY dcQrtYL1L2n2xCSmm02lVZwX X-SBRS: 5.1 X-MesageID: 51745175 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:ZpVxIamoCnYJap/jxnElZ0sjSmfpDfLW3DAbv31ZSRFFG/Fw9/ rCoB3U73/JYVcqKRUdcLW7UpVoLkmyyXcY2+cs1NSZLWzbUQmTXeJfBOLZqlWNJ8SXzIVgPM xbAspD4bPLbGSTjazBkXSF+9RL+qj6zEh/792usEuETmtRGt9dBx8SMHf9LqXvLjM2fqbQEv Cnl6x6jgvlQ1s7ROKhCEIIWuDSzue77q4PMXY9dmcaABDlt0LR1ILH X-IronPort-AV: E=Sophos;i="5.84,368,1620705600"; d="scan'208";a="51745175" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NyRfmk6HC3OBebgm7qUPt6LtwhalpKQe73E2e1erW4oqmh9p+x8C3+Wg6b17ZIV5z7OgUs4vG9U/YBemKQgk5OSgDgK/P/+Pn+eCybF1gnUm3WLwEqQUM3J/VqIdA+yr6YJZ5YkR6AyhhPfmXKV3kWa80HX+TNjlW/ROnzTQ5x5Nf+D1ZsBRE0bVGErc30nTd4lYzo5iLhcx1CWWGP1H0Cy3ogwtYowt79VV2/etPaxSVILamVAu6HU0/NeGkafJ806ZxcGTwJppOVVDC+ulKw2T3TEk9B6cbxxqKLEs1Eb5ZDCbvhJi9RZPybZJK8lOpRIaFs8Bpga04CtJsfkgIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HTMmjGYrRe680AdAYN8pAzhWSq3wfk6ltNwSmWH6CGc=; b=cBKl8tmsheOhZ6k90EizphfhYZKoIy96QmAgxnex2devo6Gi612xcbLzX5N+ePFDh3T/5YFdTxqBXPOSkolQLp1mFJCSXvUSy/6dNCkYWBJekjr24ln+/RMNWdGuMz8nScWPCnDR9J6VQO1w65B/XDCTOVlR9o+vZS4Z1hpyYnE5E8Nss7TzM5ezduI1/VuQkHTYse270w8XwAq8FLrvYoyKpXpSxz+ZQ2mtzP2vW+RhlwuQCjKCvqCc2qg1gYiNkHEXYVs4wQCxqBKMkwfb4NKAXgfnKrVJ6/tIBzCqfBDT43GZViDav4oQGdqpi6Ji0RN0ga5GjZ3hVt3XP5iLGw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HTMmjGYrRe680AdAYN8pAzhWSq3wfk6ltNwSmWH6CGc=; b=t1N7a0gnFrUqa1hKDEKk/iFh48P+yJ6424FdtOKzkmHdjxtS50sbcn2G88Guii5dn9ZbX9mNeyD3zEVahB9KkJQbqWCVoyZx1/3opWLThC9LORnXZe4bVhAh9tVg7ni2OhWlVGOgpBYf5LeSp4bUunaa36+/D0HipMl12K4TFuE= Date: Wed, 1 Sep 2021 10:41:19 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich CC: Andrew Cooper , Wei Liu , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH 1/4] x86/PVH: de-duplicate mappings for first Mb of Dom0 memory Message-ID: References: <013c49f5-7a14-9d9e-4d25-75934bf6349f@suse.com> <9cfc122f-dc4e-9dc0-0b57-48abf941025a@citrix.com> <866a3677-1f1a-e0e5-7ab0-10c210e25610@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <866a3677-1f1a-e0e5-7ab0-10c210e25610@suse.com> X-ClientProxiedBy: MR2P264CA0120.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500:33::36) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 63312824-9005-437c-dcec-08d96d2448cc X-MS-TrafficTypeDiagnostic: DM6PR03MB4140: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: oFfjqbKFZGyFWg8oofuPY4L3tYXGAa+cnyIkF0iQjTSe1ijqXDIWW5jwjaKd7KRkXP4Su3bJZIq9X7ngKz3kz4BOEt7BCQuejHsbVcFMpHK1Ubvrp8hC5oWRQ6yYfN+tb5R/8hD9m/sx8UgBwebDsT14rpWQ++BvSIAKJH8plpRInun9SLYM2SSaE92BiRts0heJMctMSnjvAWDqVGHjvUU3KmlFjWayAdSKCtXXLD8dxPg8njmztEbtj8e30G/0rH8HunMyvZZLHvF8OWyPrZdrMYQYLKAGQ9l3m+j80rHRABUJL14vmx54GEsxXZjRsmbMqlj8mb8Jz6jog+o8W1vr06w6RmqK0CJ2hhMCpEhUmtjBBSEepxsF9Yzsma8zPeP7ape0PL1fwYlvTJ/yr1iS0lgiJrBykQNkpZ+nm65KXlIGbf6EdKtRXy5HwYQT0yXqykKbMNXd6rgRandSAJtA932lNtuCCdKept4M2AJTQVR9cfnkx67jnpgCbbiD2oufG84om2B2kvyDgQyJ6VXqsvaB0ODFTzQGZaTwdhbVx6DaSfGjb8ZBY0jLKzHYmGO1wR6Shh5QtMWnI3mUz9qIlAImfDzUxQp0vR9svhfVopUf/sbElr890KnpJGI4fiAGkWUZIUdH4YXcocbPfg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(7916004)(346002)(396003)(376002)(136003)(366004)(39860400002)(54906003)(6496006)(53546011)(66946007)(956004)(86362001)(66476007)(5660300002)(316002)(2906002)(4326008)(8936002)(66556008)(8676002)(33716001)(478600001)(9686003)(85182001)(6666004)(6916009)(38100700002)(186003)(26005)(6486002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aEJMS0YvSWxhbUo2RVlvSytIZGd1U1d4d29LMzRFQ2xsNE1QNTFTdXI0MFhN?= =?utf-8?B?MUMvak10ZWhxdktGR004VlFuY2UvYWlvS04xb1loYW5wWFhaMkRyd3I0U3Z0?= =?utf-8?B?NW84VVZsZFdESGR2ZlpPZDZmWFdrLzBPK3ZqNDl3alJCbWVrblp2SHJvb0dV?= =?utf-8?B?ZmtNZUwrV2pDSzFvN04rU2oxTjJDUDNKb3FDLys4YkE4bExQcmwwRURONVBX?= =?utf-8?B?TlQ1aUI5NDVGcUU3UGNVT0g3ZjFiUTlLQ1gwR2FHR1BNQ2pqbVdaRVl3dEF5?= =?utf-8?B?UU9ETjljUWpwZTAwM2llUWVpbnBDRG9hVDhUVk5oUjA4RjRwRHorTHlRMVAy?= =?utf-8?B?MzVPUXg4SVNEMHBjNWEyNUpmT1lDckhBdEMxQzZLVGpWN1hwak9GZzZlSWRm?= =?utf-8?B?TzNVUXdJL0xhTUg2R2h3a1VWODFydHI0NGVYcnZSV1Z5ak5rbWpORFJUeHd5?= =?utf-8?B?L2lpa2NmMjFzb1dqc2kvVUtuT0V4QXNuYisrZVkrVG92dnlzZ09XOTdXMkxP?= =?utf-8?B?aVNYejY2eWk3UGpydXBYL2NMOG5tUzEvZlhsUE9jQS96OWRBRzhlNDB6OXkv?= =?utf-8?B?RE81Zm9HdVc5TDgxMVZGQnl1aXl0L09Cb0pRWUxYZFYxVkNyMDRCYUZ6MW9r?= =?utf-8?B?OWMrZmxSbDVSM1ZNVC9KaDRjNVBmL3hpUWtuWVFXdU9YWDJjT2JRTUtPY2g2?= =?utf-8?B?R1dVZ0o2MkhmZ2djRThKZzkxYTJCWWFiWlpkekRYUFFoYmNpKzRjLzZUdUdU?= =?utf-8?B?ZnAvcSttSUpaeHB0L2x0SGlOelpmK1RHTTZnOVNFVy94dm0rSnBjZHdwSjRz?= =?utf-8?B?eU85LzJJRzFyOGNNYWdtS2paTWxBVWNyaEZSZDF1M0FyZWtiK09LZmc2OXA5?= =?utf-8?B?eUdvZHZodXhXdlA2dmEyMUppU1F5dmo5TU9TT1d4TytDSy9mamhzVmtBek5C?= =?utf-8?B?bW1GZkZTNDduSHdRMjg4cnVnNnErR1dFbFpIdnJsOENZb090OEZvaXVEWWFv?= =?utf-8?B?c3BCaFNKUjNPL3czSDBZMWhyenhWRkdrcEYrbUlya2U1ZlhOdVJUOGFqMzJL?= =?utf-8?B?R0xYeVk0SE1xWk1QZEcyNjVZVit2NjhRNmxPUVVPUnJ2S2lYajlQazhBV01v?= =?utf-8?B?S3ZTdHc2MnlHL2NYeGQvTXF4RmR2SmhPSGdvMHBLbTc4M3ZtSGpQcEQyaVcw?= =?utf-8?B?RUxVdmJWbHFtR25UZVhjdFQ2bGplRXZmemFmV2ZiOGZ6UExZRXNuSStiQ0FH?= =?utf-8?B?Z1V6enR0ZWJ4M1MrN1g4ck8wRVN4Q3l3eXpHaDM4c3N4Q0FEOWRzTW50TnlT?= =?utf-8?B?ejB0YkFqaEc1M01idTBlb3VUS0pTdGN2WnIzNG93ZDh0a0ltR1JTRzYwd3NZ?= =?utf-8?B?ZjF2SHc3S1NUSk1leWRGaEoxSkErNEREWnpKZnI0VWZLUnArTW9vcmk5RFNp?= =?utf-8?B?SDl3MysySDRCblF4bENjTVdoYnh3cHc0eGVZempTRUZCOU5ENkxNMUQwNnVT?= =?utf-8?B?QnYvdTdkR2srd2lVOHZoQ29yOGFwTlRHVzhnTUhMc0NmczJOdXFiZk8vZllE?= =?utf-8?B?Z1hLN0QyTUJ5STJONGhBV2xIYmZuR1lQMDU0ODBsMFlJM3pqOUVwdGRMTlgx?= =?utf-8?B?SmVnUFF5ZXQ3R1Y3NjRJWStZRDkvc2pYbDRkcXFPNHBqb3VEbURxOVN4Q0FV?= =?utf-8?B?SURlVExHTGRmWXp2cE1iQzM4SkdCUDhiTjNTK2VtOHVISzlNZWVkUXJuVkdt?= =?utf-8?Q?OIgU4KQuYmmDgcQtFARgC+Gj0os0XuoYkk0OYtj?= X-MS-Exchange-CrossTenant-Network-Message-Id: 63312824-9005-437c-dcec-08d96d2448cc X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Sep 2021 08:41:25.8983 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: oox+/mumLfWMOabDQxXyBsGi01HD9fSazdkDdhSAPgrZNKIpwTssb8c2SdFaMOnp5vFrw/nWMbs9X8aVf+wzpQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4140 X-OriginatorOrg: citrix.com On Tue, Aug 31, 2021 at 03:14:06PM +0200, Jan Beulich wrote: Sorry for the delay, and likely not being of much help right now. > On 31.08.2021 15:02, Andrew Cooper wrote: > > On 30/08/2021 14:02, Jan Beulich wrote: > >> One of the changes comprising the fixes for XSA-378 disallows replacing > >> MMIO mappings by unintended (for this purpose) code paths. > > > > I'd drop the brackets.  All it does is confuse the sentence. > > > >> This means we > >> need to be more careful about the mappings put in place in this range - > >> mappings should be created exactly once: > >> - iommu_hwdom_init() comes first; it should avoid the first Mb, > >> - pvh_populate_p2m() should insert identity mappings only into ranges > >> not populated as RAM, > >> - pvh_setup_acpi() should again avoid the first Mb, which was already > >> dealt with at that point. > > > > This really is a mess.  It also seems very fragile. > > So it seems to me. > > > Why is iommu_hwdom_init() separate in the first place?  It only does > > mappings up to 4G in the first place, and with this change, it is now > > [1M-4G) > > I guess we'll want to wait for Roger to return to shed some light on > this. iommu_hwdom_init should cover from [0, max_pdx], or 4G if max_pdx is below that. IIRC first PVH dom0 implementations used to have a behavior more similar to PV in iommu_hwdom_init, as they would get almost everything below 4GB that's not RAM identity mapped in the (IOMMU) page tables. PVH dom0 has since diverged, and now iommu_hwdom_init just identity maps reserved regions. We could likely move this somewhere else, but given it's still shared with PV dom0 (by using the same command line option, dom0-iommu=map-reserved) I think it would just make option handling more confusing. One way to simplify things would be to rely on the hardware provided memory map to correctly have the regions in the low 1M marked as reserved, so that iommu_hwdom_init would identity map them. Then we would just need a bit of special handling to duplicate the data in RAM regions for the low 1M but we could avoid a lot of complexity. This however requires trusting the hardware is not missing required regions in the low 1M. Another option might be to slightly modify hwdom_iommu_map so that for PVH it returns true for all non-RAM regions in the low 1M. That would avoid having to add another loop in pvh_populate_p2m to map those. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Wed Sep 01 08:45:58 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Sep 2021 08:45:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.176102.320531 (Exim 4.92) (envelope-from ) id 1mLLsc-0004gJ-90; Wed, 01 Sep 2021 08:45:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 176102.320531; Wed, 01 Sep 2021 08:45:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLLsc-0004gC-61; Wed, 01 Sep 2021 08:45:58 +0000 Received: by outflank-mailman (input) for mailman id 176102; Wed, 01 Sep 2021 08:45:56 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLLsa-0004g6-FQ for xen-devel@lists.xenproject.org; Wed, 01 Sep 2021 08:45:56 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 2a0caba4-5607-436f-8de1-f43c1278489b; Wed, 01 Sep 2021 08:45:55 +0000 (UTC) Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-db5eur03lp2053.outbound.protection.outlook.com [104.47.10.53]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-25-pVaYxaYpOIaZRfTz3Kv-Cw-1; Wed, 01 Sep 2021 10:45:53 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR04MB3119.eurprd04.prod.outlook.com (2603:10a6:802:10::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.23; Wed, 1 Sep 2021 08:45:50 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4478.019; Wed, 1 Sep 2021 08:45:50 +0000 Received: from [10.156.60.236] (37.24.206.209) by FR3P281CA0032.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1c::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.9 via Frontend Transport; Wed, 1 Sep 2021 08:45:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2a0caba4-5607-436f-8de1-f43c1278489b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1630485954; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=QwTgqcw3zlA2T/dEROtSixpo30ORvGtc6P2RdjY0Gjg=; b=PzS2P6efoymwx83ilyV/+Epmw81JJwTLmMQTfspyeq4HmQiGVNlXYE5Js2YdYOUZ7dd9n1 5l7PPWkwEAd2tFFUpaMwpY0Xc9QX9W3z0hKZQnxi+ORluMpRiUM47xJJgwnRy0xs+Ltfv+ 0RiTuhW+nyVL1rZPd0WjdUsoFQgliDY= X-MC-Unique: pVaYxaYpOIaZRfTz3Kv-Cw-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ggASe3nILsQkMY9u+7NaaCb+8aZEHa5QFf3rlrn7kH32vM90qDD0Y6p+2j1IJAc7IiwdfRmRInYqgRMJuPMzxba5/caNkQp3YuNQjpLsKLDPJ1rfN3VxrewYZ+21esPSoGLiK6Sbpy8YtgRw+fM2g3tsKmfPEQg1jp/c6Ni9l+iC/0w1VDrDoHmk4jSPshwcm1BvT91qfedp+PSB6OTqRtXHfUQmgrGj+C2NlDJF3/pan6IK2zxZdDUsyNrf5Ttnp9YSfDh1t2ZzxalCJMwmsHpyOtv0iZrRVR7RPaAiVj3fFuhdzDiKwew4/xnWy8xjtayd/RWREsgf4KblS26ujQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QwTgqcw3zlA2T/dEROtSixpo30ORvGtc6P2RdjY0Gjg=; b=GW7w5QtN03F9yx6157WuZMzBZSZlC8Z3lySQ3EIjkeG6X4zVF/dT8OSnAHZN05If8O+3Hpc0gw3unDYZ/tVqzMZhC3OxjdV+nUc1zbD+YrzPDzOlhCmaQEJ4mowLHVwJa2REVwZ7/Rq55SGEBY1hcSBX/hkMv7si49Uo/oRbjaJrmXAE989DMXZAPW4sddwjy505S5YLVDbopCkkrzOMHHiGUMDtwtRZ6Tf3UT3GsTbncweUogGbAHkn+12L6qWXyjKOTCEeallF2/+NmL4kZst7Ahc8A/d1xFP+ALqunECcGzvMdkFgaRQSLP2BQ9jbbob2/2iL9tA6Wc895tFsqQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=suse.com; To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu From: Jan Beulich Subject: [PATCH] domain: try to address Coverity pointing out a missing "break" in domain_teardown() Message-ID: <20e28e4b-c794-7435-5f5c-332e9a6c0433@suse.com> Date: Wed, 1 Sep 2021 10:45:48 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0032.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1c::13) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d2feab3b-1a44-42cf-c086-08d96d24e6c4 X-MS-TrafficTypeDiagnostic: VI1PR04MB3119: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +rXZ7I3qL+OTk6CJBtJ6Cnw9BeFlt13zggOo+cMurxkLReMmhcoZkHzsaiMPN/knPx5g/ZogSCP8jgliDS/Rs+GcBP7/4QhJllUb/Bvo7MCoG7dLNcDFwCgHgTfZ4RoIE4or7Pk6+gCxQ6O/1LEvhoi1znuZHJAHS+VlxfkD8PJjBOHV9asgE1h5PmrJmSqj+anEBk8FdQp5F6UQXDrpsEK37Muge2bNt9B4WUehuBz52Hj1ujGUHEti98SllaH7URR5qu3ZQ8YQnUA95rr0Mkele25T8iMXmn7il6fvzsz4UF5gA4OxrdOSCxRRZjD7m+L/kOY41xHuK17/2eD015W3CER0iFf1JhBNyS6QG4V2YxyeKHis/slYk2sEFJAoZsHgcFFEGSunxZjsEUC2o2p5YEGAP4zioc2g2BayermqOv1JcBGDqUzYh1Rr8Fqk6DRMOrfIyqTotrAoXwHKmKgbdsYeTeLjGK2RyR0rJjHHEXuaV8l3GVzySQqIvr+nQ5IUfZObeiqEaC0LyBKSS62zp5ec5h0JI+E2lJ0ypp4Wm5CKUmp6+DRvUtM39Jh34k9EItVEPNafANwSYJnxlEbRBNCohCqr5f9Gc4hho7qLHXvmuCHuRc+sjWU785G862eR+2his+XWjnRaIGtdcfMCIJ105j3E/+L0jRWGxR+kBtDSFLIUrxAeXxRtC+xKh1eK/lCBKOCTASpeuctAd3tFE29pGFmLgFI14IyUWxQ= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(38100700002)(8936002)(6486002)(31686004)(31696002)(66556008)(508600001)(26005)(6916009)(66946007)(8676002)(54906003)(66476007)(16576012)(5660300002)(86362001)(956004)(2906002)(316002)(36756003)(4326008)(2616005)(186003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VHZiVUsvdXczUmVrdjRaOTJBSFhDck9ITDBOMnYvelA5ejlqVVRzdFgzYno5?= =?utf-8?B?d2JUeVA0cWhnekR0S3YvRys0SWxUQmZUSnMzYldzbFJTaFhlZzd1RDJaOHQr?= =?utf-8?B?MmxrMzdtL243N2dyeW1TNTduSm1jUERnVmRJYlI0QjhZTWN2V0pQNDJYTUoz?= =?utf-8?B?bGRQaTNRRE5kYVBrSHp5MHdUU1ZFcUU1UUVzVjFnMW1UeGQ0QzgzUGcweVZj?= =?utf-8?B?QzVTY1RKcFRrQVcvNFpMbHRHbm1rYjBpTjIxbGMzdU1RTFN1STA3N3p2NGZW?= =?utf-8?B?eG1lUjJVQWZvRkVsSllNRTRzbVF4SjlXQ1RxeVhmdW9pbmZ1VGlJZDVuWnhr?= =?utf-8?B?WDFxQzR5VDNObjRVTUJNb29UUVpNOXNsYTlZMnQyS21MR3dMMUtpUkpHc1Nz?= =?utf-8?B?UENBdHlVN3J2SWFNZjFmd0ZHdDdqUFNCM1pBamJSV1dmRkQ0TkZNYVJQcUxI?= =?utf-8?B?dTNLNzZnSGcyTTY1K1l5ekFEaTQ4RzFxV0RoaE9uN3VFMHdKNWJKRkU3b05R?= =?utf-8?B?U3hGWHdtV0xVc0cxOHhyc0R4RktIYWhnNnZjbmRGcHljdnhoNUFVL1BUbHZU?= =?utf-8?B?eWE1OHZhVnoxZjJLREdOaFpHWHVTdWVTSVpoLzVnazRjQVhLV1NRT2RpajlE?= =?utf-8?B?R2ZhcnpQV21KT2tVTGovSWt6THk1aG1peE9JUzZCUUFzcDhyMlBKck9TbU9j?= =?utf-8?B?K2VSMXRocU9ITVVXa0JuZXBWOWZxN0UwNnJpQXVRYjNMRTh4SFRTWjlEOStu?= =?utf-8?B?VHB5Mk5iaFVmaDRMR2ZPN2tOeXh2cmhieEVYOHRNMjFHR3piclJKb0c1MnBy?= =?utf-8?B?c2dVbXNpZ2o1a3M0MjZrVTM4RHk3dExtZVI3V1JhUFpxOWtRSkdpUldTWHEx?= =?utf-8?B?MzRNMlVXcExrTWFSZFNReld1SDJVVkRoa09EdllRb2FxZzh5cnIyR1JIUzhh?= =?utf-8?B?ODBET3FGb3NTc21Qc0x5SUVVcEtGeE10cVpTWTdKMU9TS3FyN2Y2ZElmRUZp?= =?utf-8?B?NlFPVFZEbjBGWlZXQUNwRWxIZEhpa0Juc1NMNVB5U0M1OWtQd2hadldPNzh6?= =?utf-8?B?OU9vOFlHcWJFT014WndUL05nTnp4WTNPWEdwdnZsKytJdWdReXRNcHl5VTc1?= =?utf-8?B?U0tBSWtnQ1lremNxeEd1d09CaFg4R0x4elBXMXgxRzd0MFVlVHFIK0N4TGdy?= =?utf-8?B?WlliWlhCcXpOQmRwWWphZ20zM050TDVkQUp3eXIxeWJpUUd4VGlURlM2TWVY?= =?utf-8?B?cGFiQ01wWDNYblhkTzRpTWN5WFdsUEZlb2dhY0JNZXJ6TEZERXAyTzluczJU?= =?utf-8?B?d1QzVEZOcklSbjZlWU1SdVFQL0cvdk9Uejh0WjN5VFhmYXkxS1J5a1RFdmxt?= =?utf-8?B?NmRBcjE0bTlxQ1RwYWh5YTNkTjZEOUV5UG04ZmltUXFuWXhqMzhLNldQYmtJ?= =?utf-8?B?T2xhQktnMG04bG5YZG1tdnpsZHlTUWwvZFhpSklqbEo4dDlaa1NQWnhpVjVC?= =?utf-8?B?NHAyMzJ3bjQyZDhObDhsMjZ5UXd4dFlWOUFQbEhJSkZSVmVCa2t1dzFLRFQ0?= =?utf-8?B?RXViRTFESDRNTjZaZm5kV20xbk11aWFBVUNnQnNVZ0JPS2hJdUlnUFlTeWo4?= =?utf-8?B?Smo5di9mWTdmYjJiT2kwOUlkdmpoTDlZMTRTYUZiZHlCL0lpRGR3THE1M1JM?= =?utf-8?B?MHhwWXhXakNmWjMxd2taQWFmNW9Mc3NmTTdKanpTOTZPQlFDQi8yV0phWjE5?= =?utf-8?Q?1C0X3G6QJ3P/9qCQooSNmyb+ysDCgfQvoG5elug?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: d2feab3b-1a44-42cf-c086-08d96d24e6c4 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Sep 2021 08:45:50.8159 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: eALn/01KGz0exzbybadfJfYcoNwucimaFylaUHc6OYDshdrzUvnB933eze2yzSBIaZ/rNX0blXKT59Pp1oye5w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB3119 Commit 806448806264 ("xen/domain: Fix label position in domain_teardown()" has caused Coverity to report a _new_ supposedly un-annotated fall-through in a switch(). I find this (once again) puzzling; I'm having an increasingly hard time figuring what patterns the tool is actually after. I would have expected that the tool would either have spotted an issue also before this change, or not at all. Yet if it had spotted one before, the statistics report should have included an eliminated instance alongside the new one (because then the issue would simply have moved by a few lines). Hence the only thing I could guess is that the treatment of comments in macro expansions might be subtly different. Therefore try whether switching the comments to the still relatively new "fallthrough" pseudo keyword actually helps. Coverity-ID: 1490865 Signed-off-by: Jan Beulich --- If this doesn't help, I'm afraid I'm lost as to what Coverity means us to do to silence the reporting. --- a/xen/common/domain.c +++ b/xen/common/domain.c @@ -401,13 +401,13 @@ static int domain_teardown(struct domain */ #define PROGRESS(x) \ d->teardown.val = PROG_ ## x; \ - /* Fallthrough */ \ + fallthrough; \ case PROG_ ## x #define PROGRESS_VCPU(x) \ d->teardown.val = PROG_vcpu_ ## x; \ d->teardown.vcpu = v; \ - /* Fallthrough */ \ + fallthrough; \ case PROG_vcpu_ ## x: \ v = d->teardown.vcpu From xen-devel-bounces@lists.xenproject.org Wed Sep 01 08:50:15 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Sep 2021 08:50:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.176108.320543 (Exim 4.92) (envelope-from ) id 1mLLwc-0005z6-Tf; Wed, 01 Sep 2021 08:50:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 176108.320543; Wed, 01 Sep 2021 08:50:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLLwc-0005yz-Nu; Wed, 01 Sep 2021 08:50:06 +0000 Received: by outflank-mailman (input) for mailman id 176108; Wed, 01 Sep 2021 08:50:06 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLLwb-0005uz-Uu for xen-devel@lists.xenproject.org; Wed, 01 Sep 2021 08:50:06 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (unknown [40.107.6.89]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id ae6bfd60-37f2-42fa-bcb7-403ad9f67df0; Wed, 01 Sep 2021 08:50:04 +0000 (UTC) Received: from AM5PR0601CA0032.eurprd06.prod.outlook.com (2603:10a6:203:68::18) by HE1PR0801MB1771.eurprd08.prod.outlook.com (2603:10a6:3:88::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.23; Wed, 1 Sep 2021 08:49:54 +0000 Received: from VE1EUR03FT026.eop-EUR03.prod.protection.outlook.com (2603:10a6:203:68:cafe::bd) by AM5PR0601CA0032.outlook.office365.com (2603:10a6:203:68::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Wed, 1 Sep 2021 08:49:54 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT026.mail.protection.outlook.com (10.152.18.148) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.17 via Frontend Transport; Wed, 1 Sep 2021 08:49:53 +0000 Received: ("Tessian outbound 1a0c40aa17d8:v103"); Wed, 01 Sep 2021 08:49:53 +0000 Received: from b9d613c93ab0.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id F7A21BAA-F4EF-4BC6-BE80-62232048294C.1; Wed, 01 Sep 2021 08:49:47 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id b9d613c93ab0.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 01 Sep 2021 08:49:47 +0000 Received: from PAXPR08MB6446.eurprd08.prod.outlook.com (2603:10a6:102:12d::10) by PAXPR08MB6511.eurprd08.prod.outlook.com (2603:10a6:102:12d::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19; Wed, 1 Sep 2021 08:49:46 +0000 Received: from PAXPR08MB6446.eurprd08.prod.outlook.com ([fe80::c029:ed0:82e7:3c2f]) by PAXPR08MB6446.eurprd08.prod.outlook.com ([fe80::c029:ed0:82e7:3c2f%6]) with mapi id 15.20.4457.024; Wed, 1 Sep 2021 08:49:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ae6bfd60-37f2-42fa-bcb7-403ad9f67df0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KRa8tMlNf0zznQ/c905c3juUaUd51nNqBn86dcAqfd8=; b=DPP1P4YyBTHLVgVytNxvUkFov7hexMFHLg3TJBl8SMQOfKgPrKC1hegVm17uwKpeWKXohrQixPsIKlqXFuwSWHva1t5JgNf+nAAMTDCmTlT5TqpMUyxm/vDATB/vy5gvGgujSSPbJpuVfNmRYRxMm+a3z+vk9briRkb5U79wGlk= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: e90d8ecbde44be80 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UI71hRW21G8Kqg8yAMeV8uXNMAAjl1KN3uP68UVFSsFuvbuHHvDvvYlHFxRmkdMckTa0KD7DdLLoSErd+psF/HAulUtcEwkuPtChbWwS5rTrCUDidwQPXRf8qxdmAf4jL3IW1opwedCHRpnq5021KW7rRhkuYi0rkCcZzyBnGmJ0ma46AcOCQb+JFbZG0caP0Ipnu49NmWQByGjsuWswnRyvbvQjaaknAD9QqepEwXOi1K2TS1PSiMBvIIPQVUefjuXdc+tzc+yQRokccyrYbE/d8QAl0o2HpzCe4GNVLxpQGJtZd6eOJg8tfSZqyYVyvjuDS5cdAac0K+XQsGkz7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=KRa8tMlNf0zznQ/c905c3juUaUd51nNqBn86dcAqfd8=; b=LT+wNyMLWe5lqo1LDTP3O3LWLhmj0zbDh4HVUyxhNTrYWDIEapZ6GHW3CB9TGjbVPdPU5n9fglpUCb+XnQWFG3D0/5CgHj9mgxjA7TRwCTCfyTX+TkLXF6OfA4qx5R+hnXQ/Nf4lKBVseMGRWfAq81AZbeD9K29BURTOor/RKTvMaANRj+4bCoUdrde+kMXt0giOC2zSBptYWnfAFq+9/atdWLr138wy0K40eIq+iGu/7lwLP7sSN+oqJ9i8inTRinwhHiUsvS2kfFBJufMdV4ZAwCIsEFp+bHy42Fk/lJYbeh2RvjNbvDREu+S/NRrvOFaTZ3xfLLLiaBL+h6x0ZA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KRa8tMlNf0zznQ/c905c3juUaUd51nNqBn86dcAqfd8=; b=DPP1P4YyBTHLVgVytNxvUkFov7hexMFHLg3TJBl8SMQOfKgPrKC1hegVm17uwKpeWKXohrQixPsIKlqXFuwSWHva1t5JgNf+nAAMTDCmTlT5TqpMUyxm/vDATB/vy5gvGgujSSPbJpuVfNmRYRxMm+a3z+vk9briRkb5U79wGlk= From: Bertrand Marquis To: Jan Beulich CC: "xen-devel@lists.xenproject.org" , Andrew Cooper , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu Subject: Re: [PATCH] domain: try to address Coverity pointing out a missing "break" in domain_teardown() Thread-Topic: [PATCH] domain: try to address Coverity pointing out a missing "break" in domain_teardown() Thread-Index: AQHXnw3T6W43IPECMEKENcWB9l+Su6uO3oGA Date: Wed, 1 Sep 2021 08:49:46 +0000 Message-ID: <9FDBB4B2-9025-4F75-BDFC-0BECBBBEB7E2@arm.com> References: <20e28e4b-c794-7435-5f5c-332e9a6c0433@suse.com> In-Reply-To: <20e28e4b-c794-7435-5f5c-332e9a6c0433@suse.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3654.120.0.1.13) Authentication-Results-Original: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=arm.com; x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: c405c1a3-d6a5-4398-774e-08d96d2577ac x-ms-traffictypediagnostic: PAXPR08MB6511:|HE1PR0801MB1771: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:9508;OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: a4liixixZHgl5BOPISpQc2TNxHRoEJbnwKzmC5FsbOvYr8TiusfqlknFbWcphTCmTejuAgzYwkAx9gqPq8swO99EIJdzBJ89XzHFnGWn3OM3BBCk0/Ibu/epsCha3EPlm3du0drDQvpugyZMsq6GkBDOSezJmFXC+3Dyws9u7QvEFllhvROAhEMSp+d3743zkyBhKQfgqxGXBLOEm+ZwQMNcpa/b6bpqQFS3NZb7A3bsmS+NHInigQXrybjn119BuDzVMAByRcUh0QtVF/ynpXJD+Y7uGRKCNGfT3Wuk6lh8hyK7n7j7NN6ABFuihdDEc/ZvTkZciBxsMVQcOiLiW9Yv5UFQxxHOLXlUbJhl8+m+hrHnq75/YrJNFrPNvFHOJk1pd2kfc1Ubs/REJKwSexJc5dw62cv7bRvEOBgLJCtcxiFs2EE/1qVSDbxAhwladLQXEomvpyJ5DyF39KyBQi4fPFoNpj35MZLG6bt+ysOXY60Psd7jvFVnitKSQCnLDsf2hrm6GHitftoJ0ECaRZ6jn3wKOzqIMTYnlQSXKb5PK8ncZc8Y7ymlHGeuH3e+RGDgOwehxgilN/3WpKMoYd4A59WssObKfXJ3ZC8m+UudLGBr8FxaAJvvsM/tmPq42PuzgP6tH8pN1zkzA9TVJ4+B4q/VGXrJwqxe88GFbRMrvxRpr1eWiiCLHQXSdneeA5BIpW9go50LsBCSdKUpsslRIeoyMjjoQ5rMc5Gk/R8= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB6446.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(39860400002)(136003)(396003)(346002)(366004)(376002)(38100700002)(6916009)(4326008)(38070700005)(8936002)(2616005)(91956017)(76116006)(66946007)(5660300002)(36756003)(54906003)(33656002)(6486002)(316002)(8676002)(66446008)(64756008)(66556008)(66476007)(71200400001)(122000001)(86362001)(2906002)(6506007)(478600001)(53546011)(26005)(186003)(6512007)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?or1y6CDxGOMF4EGSwNPO0ruz04HAJVBSM9AoECLyeB7hLql9bPavIYzv6nN1?= =?us-ascii?Q?nQ4zohg2XAlFnwR9bPNdVb8HjAaKW3AamnATGi9NIB1MApU0IzQqpLtoXqiW?= =?us-ascii?Q?1Lq5jjooK5gt6MaXHtEX2QYysOOYVmTmMgERGzPQG95y8BtG5hw3WtNbfLsQ?= =?us-ascii?Q?MffdZM6nBgL1lT0VeTzKK09CPZ3QwFbLaqD/Cyu+XQgh0cLskrzjh8nS61me?= =?us-ascii?Q?69Qdvl8uj4+pNaaOTnrbFa8YEUSdRsyJCU0ar6TnBnf3Lwpm3Ek7U+Tu/UdV?= =?us-ascii?Q?4CxwShO0SWtIeoRIEok3V/ou9l26Tc9L2HvrtsdZfO6Da0/qxfeM6LtuheZK?= =?us-ascii?Q?OcaaWukik+g2/EmP/9pgNTgfx0fT0oTxBQuS98edLY+ySlS6nR5FILDxuKKs?= =?us-ascii?Q?cY2z0r9Ael0YJjLW4W3DECkYk+BTH9dcbApbFuyOC87zY6WxucnLZ30TprVP?= =?us-ascii?Q?hMsOTcWxe5oDKpAle6zE24SXf60LNyQc1avpvvBIB5e3Gko+TzBuJOcayLkg?= =?us-ascii?Q?xGJQon33d1tWcywQ4QGLB/lB29oM330IP1h1n7Xx9kT6vjhA8u+EL3+oOD+q?= =?us-ascii?Q?PZeGGMRImBMF2KtCN2IXiG7NYxpHLGP+1+MzpDpkoRUCWrOFtWymfb3ZOT+Z?= =?us-ascii?Q?vzmZZgohTuV94GcFxWfKsiinhfyKZ5ZzIucmBx9wRfbO1xadrP9whFZPjMeE?= =?us-ascii?Q?AVwg1bBR35pMw9wBcBqcIVbn12Mk8j79ihJKrKVYWYIVpRUf3iWvaBMG6YnS?= =?us-ascii?Q?6DeYUMKIZuMCviD4MeTRig78zX/oI8sfQFgIcBIj+Oldd2XkEWnf9GoROMzH?= =?us-ascii?Q?kvwc7XkX3Y7VTlwbc6lCCQGPvmjIco25OFN5Uu09mIEMbz2+Ejcr92HKR+/J?= =?us-ascii?Q?aKLkrm8qSxQ9O2yKdPUwae8PHQt4ckQOie2ECqUQrACANAUmhMPgsrljnWnv?= =?us-ascii?Q?IFPkRYoLuxQ2t8UoxAiFpcUjWI6UN3jWwwYIh+1j5DJZkZU+/W1wnGobALuT?= =?us-ascii?Q?8BYkJrwUg3alqg7Wjuqm70WeqE8S8ri3Uy0QK8q4/f/+sMJ3AWHkisikrvLS?= =?us-ascii?Q?yRa4rtA4Y/nPRtIqLuhufEJLiML9stljW3JYtGCjfqdyUBLSl/JyKypB9AMm?= =?us-ascii?Q?KRO+I+Gh5N9MS3l4lLqUxmIfEXN7hNnwYuj8ShREljeb/j9eNMDpBRTPRcSH?= =?us-ascii?Q?ox7wIiJMBWu+rrVIPkqZMgsaAwDiUzeskbV+5hJdiYnkGSehWxT9iogus/r5?= =?us-ascii?Q?DdNPB23UM48uMb8IF9RJji6ekdfl+FqHSitMgoQHIsjDbSWYkMLrnSjm90cL?= =?us-ascii?Q?ajqlHVsbg+OzQkd2S+P4uWcP?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-ID: <6569E7965F64A44099542E5F69489ABE@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6511 Original-Authentication-Results: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT026.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 7289598b-091f-4deb-48d0-08d96d257341 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VR2y68/b0zRLJYufOzKYD2vExvgRVyu9FRvHAHeENBMlKr6DdBjK0tltknXT+eJDwwJnRSnj3wOUsdhUqzzQWnmQi4a27OtzKSZ/5lquCgo0J2kkmdVby9bYGFd62SBOIxjJI7XU/7QjjovOOpvBtp+onozMUkUZN7HesyHTsAB51F59QLxzYR7JVkRBdmSILN8LA8CC4RdaHZ/4nTGcb9T06VmSkkTYInkYNEbGRZQXqxOAkcl/QGmhpi5x+0YSepvSndFhTDVxz01Xxx51tVQhaOLEzLuMZRfP/uKG9pgjNgiTYTxtOJcDc+kqN3w23+790E/ML/LNwXJMSBziBf7TzhIJNWnPzetYoWS6Btn6liUbUG5EpiCJFr9QkDLPc8BJAC8ieCqh2DMG6XvltuXOJvrRdfPAWgdUR2gAVL4DauKRB/kvpK6MikxBidjwJApyCIeci9vG70n/6u74BRyap0+gREW2nD/isT4gyGV9FCCc2uZv2oGMZ32zETAcohF0lbqNflqDPs4jbV2VjuqT2HdRY2tulEYM+IJ9zHItXYiUr4PC5PILC2EakPt3in97JIZJfjam+/QqKSrOrhzZvC9T3LXA40nV99cV9fakXdS4yMcVneEcVON/pkt/gup3xy5dGEZV/Sr6+DY4FbbmUnqb1dVPnhMXchFZsg0V3Szf0p93tn4AMHZuKz+B6UlFKgoM2s6N+wgf96abxA== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(39860400002)(346002)(396003)(136003)(376002)(46966006)(36840700001)(8676002)(70586007)(36860700001)(2906002)(70206006)(6506007)(86362001)(8936002)(4326008)(6512007)(356005)(36756003)(26005)(2616005)(53546011)(336012)(6862004)(316002)(82310400003)(478600001)(186003)(5660300002)(33656002)(47076005)(54906003)(82740400003)(81166007)(6486002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Sep 2021 08:49:53.7601 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c405c1a3-d6a5-4398-774e-08d96d2577ac X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT026.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0801MB1771 Hi Jan, > On 1 Sep 2021, at 09:45, Jan Beulich wrote: >=20 > Commit 806448806264 ("xen/domain: Fix label position in > domain_teardown()" has caused Coverity to report a _new_ supposedly > un-annotated fall-through in a switch(). I find this (once again) > puzzling; I'm having an increasingly hard time figuring what patterns > the tool is actually after. I would have expected that the tool would > either have spotted an issue also before this change, or not at all. Yet > if it had spotted one before, the statistics report should have included > an eliminated instance alongside the new one (because then the issue > would simply have moved by a few lines). >=20 > Hence the only thing I could guess is that the treatment of comments in > macro expansions might be subtly different. Therefore try whether > switching the comments to the still relatively new "fallthrough" pseudo > keyword actually helps. >=20 > Coverity-ID: 1490865 > Signed-off-by: Jan Beulich A grep inside Xen code show that we have occurence of: /* fallthrough */ /* Fallthrough */ falltrough Should we actually fix all of them ? Anyway this can be in an other patch. Reviewed-by: Bertrand Marquis Cheers Bertrand > --- > If this doesn't help, I'm afraid I'm lost as to what Coverity means us > to do to silence the reporting. >=20 > --- a/xen/common/domain.c > +++ b/xen/common/domain.c > @@ -401,13 +401,13 @@ static int domain_teardown(struct domain > */ > #define PROGRESS(x) \ > d->teardown.val =3D PROG_ ## x; \ > - /* Fallthrough */ \ > + fallthrough; \ > case PROG_ ## x >=20 > #define PROGRESS_VCPU(x) \ > d->teardown.val =3D PROG_vcpu_ ## x; \ > d->teardown.vcpu =3D v; \ > - /* Fallthrough */ \ > + fallthrough; \ > case PROG_vcpu_ ## x: \ > v =3D d->teardown.vcpu >=20 >=20 >=20 From xen-devel-bounces@lists.xenproject.org Wed Sep 01 08:51:07 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Sep 2021 08:51:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.176114.320554 (Exim 4.92) (envelope-from ) id 1mLLxb-0006n7-5X; Wed, 01 Sep 2021 08:51:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 176114.320554; Wed, 01 Sep 2021 08:51:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLLxb-0006n0-2A; Wed, 01 Sep 2021 08:51:07 +0000 Received: by outflank-mailman (input) for mailman id 176114; Wed, 01 Sep 2021 08:51:06 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLLxa-0006ms-Ba for xen-devel@lists.xenproject.org; Wed, 01 Sep 2021 08:51:06 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id bdaf1fd8-0b01-11ec-adba-12813bfff9fa; Wed, 01 Sep 2021 08:51:05 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bdaf1fd8-0b01-11ec-adba-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1630486265; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=c5BPbbgDzXeGsbVpJsVVbJNoVdDurBT7ZZTxaMMGzIc=; b=L7kO4sILxYSXL55X0OiPDgnBiFC1HRH7AORZgeg3Ldi5Tql+Y12QUQ2p ToKulxVnmVOzp7kzSDMV58Lv9usBvqeoB/cHfLAFio1Apuj6RQuIVb3rT Rbx/oVuOva6OzcUTME1eQAwFlGSZWakuBDmF4lPj9oc6R/eGsryCeB/Xz U=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: lgfB78udmYi6OtbUqX306EOhJxFENfODhTtu2W5RrgqhwIDVpIkwcZ5i0F9BhawhweG2BQ9ER5 fTCoqURUoT9+APor9ZoeVdOS1hh+bzAUWIaomuleZgwbbQsj4Tx2Hy/rNafYGbRTVD3tOjN1n4 /1FBLOOk2g439cJfPN55RHnz7kRgMt4VSazqR5/ZAA/0wVFu8VIKMdxrOHkmPsPYOLQnJRSFPK jYsiWniuTbOKGrFxr9KReIknXXbNMuqOVuT1ZvBCVhT1zOOI2ylZo7+7chAr7QR3cOwr0Vo4P4 JE505lO4P5szXlesGlih4fMQ X-SBRS: 5.1 X-MesageID: 51745793 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:08NuUKD+Jn1i6JflHemV55DYdb4zR+YMi2TDtnoBMCC9F/bzqy nApoV/6faZskdyZJhko6HiBEDiexLhHPxOkO0s1N6ZNWGMhILrFuFfBODZslrd8kPFh4hgPG RbH5SWyuecMbG3t6nHCcCDfeod/A== X-IronPort-AV: E=Sophos;i="5.84,368,1620705600"; d="scan'208";a="51745793" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QgXrF9bGjjjNkBdYvOBcL7jyF58lasdR/IR/CWctvywq8YtpkdNGUpJHRDqBaZ+fuc8u2PvEOgm6OoyLGdPGA6UALRGwWi3pdT329954L/weVkLqGelvGoFa2yqgsQz5IO+rqwpC/sq+wlHgN4u76SSeasjC17TegLo1utt8RmA7mQoXbXWwi4CE6V1uww+gGIp1qvfuIiLfhGJ6SOd0Rr3YJHdRb5znZa8H3oQBeCoxTL/s1hbM76GD8nlUpjCJbSwZ5rKm1xbuiKZzRLnESWXVT0PjgTULyLHHZv6hAPN3MTxMvmhxt9faXdP4jHY6PHd6zkXs6ee5ApLUxVYc2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=e4RLCQgFsrNS291skH1nHoOEX+XScfAtKaNRaZxFwoU=; b=PyKHCnG0INawMV6wHy37ClZw6lei8xXJGZV/8Bt6HfUJIeeqjgPh+IGMIxBTnNfhsYicgXe6NgDXMRMvb0hcLvTButqlBYVSD6AbsJFAlJq4/4/zWCs5raEPEzsvFwrFXAGv9mWoKkWzrADqTDkG135OvmQ47p8JVcBNfYbmScv4BtjdTWu+TDwkhi36kv59GAqfAz2Q/05kWIKqrtUBNzYnBUwSzjLCt09E+QB8zG9ush0EhcGk04e/e8uB8s71VeaI+rsZbQcrEbYZcHFugK2vZYBSr723/Bxllx2TVtChUUfxqtL9hizFfm9l2iNo1EJdmG/N5iwswjAI6vLhxA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=e4RLCQgFsrNS291skH1nHoOEX+XScfAtKaNRaZxFwoU=; b=wUy4beXJniV/LrimrjE7RQfJMclVhlrN1zNMmT9ebFcqPcrorCcDhVXMdEAzDHOJv1RGIW7XX45d/IdC5IVUeAwvBnNquIRYs4dJuSVsfbMZOhrScjgdHeMWvlPjtYSRXYmjd30bc+eoNQLdRNeYVKgycdGNRDbzUks6th/09T4= Date: Wed, 1 Sep 2021 10:50:55 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich CC: Andrew Cooper , Wei Liu , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH 2/4] x86/P2M: relax guarding of MMIO entries Message-ID: References: <93ecc397-1293-69b1-e70d-3c5f9317229a@suse.com> <7f56c625-eee6-31c4-2d6f-bd7334867d83@citrix.com> <5d69d4c0-7a04-c3da-f971-616363c6d63d@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <5d69d4c0-7a04-c3da-f971-616363c6d63d@suse.com> X-ClientProxiedBy: MR1P264CA0004.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501:2e::9) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0e507f84-7da4-4c92-8d50-08d96d259f47 X-MS-TrafficTypeDiagnostic: DM6PR03MB5340: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1Xi1t4ey2SfWP5qDX/83sCaQBR0uWj5q+08rnJZLTDj9kRl1f+SZ4f/mytSD2kwvXGKbU35LM75c3MQHC+/a7OFdBrvl6uV5uZoCgY6LlMqvG58M4TbE49FwJfhh7sCnaR+C8X+V+iCFZWIABIBTRaWZldDytZ9YPuesYW2Wj6JhvAE6ofd0Y5JLHGqDsm/oeLot0+tdCXG/V7QvuCp+TMPDp6qWHVNueniwtVfJt1Zm2YaKaVZuGEeLOaT4MgooGiaq1RtVTGswikKqt9Zgn3lb3eoQVWWPmbKa/tfdYypfFP5jxK8KEMkvRU9+ItqqgGzi7WfHMyXe4Z2SDtEpj9loH7E0OyXc6H7TKwcm7jLWw8HTMYjn2A7gM/TXhMZsV3O1EWWiX3PwjPAYhDWHPDOZcCW+3Vf9rDpBcTnZZ8yODj9sjtpKVLvzxAzU444f90IR5bNom1xiSpE7i9n1hdbJVHcDoVr/tvuEImORqtjKa8T8H2hPdD8ffcjqYcRJlgWK/XWROM5ol6NbwTKtxVGgH4An7i3Ob06PVbHXzLvcmQbSxVCrKZd1sB0Z70E94JTyplf1TMhP4K4cQR+7X/pUuGYgFhkYZNwRmpi1tnAQIhivXqzy+iptHimkkmBWLlbagFC5mNEAuZ4R1MMgDt8KuRAdJde8QZx0NcmyWNrdV3ATW9lpJaKg+x+gN+NWEg5lc5yRMW0mtD8403ACmA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(7916004)(4636009)(366004)(136003)(376002)(39860400002)(346002)(396003)(26005)(54906003)(66476007)(66946007)(66556008)(85182001)(5660300002)(316002)(9686003)(186003)(83380400001)(6666004)(6496006)(38100700002)(53546011)(8676002)(33716001)(956004)(2906002)(478600001)(8936002)(6486002)(86362001)(4326008)(6916009)(67856001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SE81eTZYTSszcHozazRGcSt2cjhRbmRjVFloeUhEUjNZVUZ0TnlvbWlVcDVU?= =?utf-8?B?SG0xNXhIbGJtYzBzTmJyNmJld0E4YzNqeUdBeVg2ejJkZ2Z6TWpIdFY3Z2kr?= =?utf-8?B?bjlBclRWK1R3Tm1Jc1FOeEtzV05ySWptQWY2Mkd4U3g5c01PdUtKTEJVak9o?= =?utf-8?B?eVhYZmdLUllvaG9rZERaSlVSb3lpQWVMcGV5RUcvNG1ORGRCV29PTGpiU2ty?= =?utf-8?B?VitKTFZuUnVadHFoZWlubFRWV05tb0ZTVXBzQ0tETEVqQ3B5eTRlMWFoc2M0?= =?utf-8?B?R1pvQjJWOHlDWFlLSjVHcFFwOW40NEgrYS9aU1ZmZFBFUXEvSzg0ai9OeVZu?= =?utf-8?B?OWMwUEJBeEtGT2lheXR3RU5zYXVYYnlBSnBBYnk3WGlyb3l3T2xGY1ZNK1BX?= =?utf-8?B?YVFBTlY1L2V3dnJNWmVFazZ2bUlxUmRpeGlneCtlRFdVV2xWYXg5TnFyeEQ1?= =?utf-8?B?OURVRXpCbVo3aE5YREZ6blhoV3RXeWdQMXk1bm9GYUpoSW13VmRBMmt3b2RV?= =?utf-8?B?czA4d0xqUmlDdUFtMXoyYlJ0QWtZMkg3NWF3aFZLUFhreEUzaTdCZUtqUlhX?= =?utf-8?B?N01EOGxtamcvdzlEaENCaGxuK28wemJzOUhFMnJLYUNZVHFkZ0tYV1lKaFNp?= =?utf-8?B?bUFVdnpPN0M1Sk9vQ0ZJV3hzUnVBQkREeXRQUW4xQkJJeUU1MW5wdWxMS2xO?= =?utf-8?B?SG1jUWFhbWE3ZXFFYVN4a3hzNG0zYVVNalBDSlhiTHJ3cmJHbXhIU1lTZ2No?= =?utf-8?B?K2MvRjEvYWZTR0NrMXFGVFNmNEtSMk5QMnQ5eGtBRTV6Z2dsbUdLNUZDQVhH?= =?utf-8?B?NWdhUnpGZXMxRk12cFdFOUtYK25sR2JVZkVGOGkvWHJENG1FNU9qMDdMck5K?= =?utf-8?B?OVRKOSsrOVMySVNvS1BKODNZL0pzUWhLb0NObXhWNDNCK29QSGdjbGQ3dFp5?= =?utf-8?B?WEVmYUw0WFNlNnZzaWlGb3hHb3hyaDJldFNzcW5OckxsQkpFbzBrYmc3cDZw?= =?utf-8?B?a3Arb29lZGZiZG9KV2ZXSnJWRHdabnEyWTVQdHg0VGg0YWlXNWU4Zy9vWk8v?= =?utf-8?B?Y0IvbkdWVlVFYTcxU00wM2VXNGhGZWxmdmhRZmhxMERnMWtEQzBCTm1XYkFR?= =?utf-8?B?YjJFY2Z4VHF4OS9lNmdnRGhNTTZ1eU1LTmFHVlJyellGQ0pwdFBEa3NqRTdj?= =?utf-8?B?eUJ1V21uYThhdXJrME1CR0h4SFA0b21yTU0yNGFxWWE5b0ZtVG5WOTZ2RUVw?= =?utf-8?B?TzlDZG40cDdBU3llTzFlUkFFUzRpZWRaV3VDODFpQk9nZWg3TzhLQnVtQ1da?= =?utf-8?B?QmJXZi83c1p5ZllxVU9jQzd6NFpmZDFHRGM5Rjd0VVBhU3VKLzViUk11S3lB?= =?utf-8?B?bUpvUU5LalJNL3huN0cwNkVpbG9mQnoxbXcveEVVcjlSUG5iNFZqVXl5TVFv?= =?utf-8?B?bm9NNnA2TXhhc0NVeFBaZW9vY2JyRTBOUE8yQWsvVzd1V2tHQTVDVVRkY0hG?= =?utf-8?B?Ym5mNDBjSVFVZFBTR0NUaFA1V2ppWm5PbEM0alN0L1ZreVN0MHp4RmVZTUNo?= =?utf-8?B?QVNYWTJIVVFTVlRWTGxGdG80aWh1Uk91TVEwd3dtZ21pTTdQWmZ0RXN5VWZW?= =?utf-8?B?VDIwV3RwZEtkY3h1QVV6dmsxQzAvNGd5cGllUXpFQ1B4MUVDTllxb0JMM01J?= =?utf-8?B?SVFsTWpVSHVZK3JpbUUxYnJCWlgrRWUrOVVxVnVDZnczT3ByYm5MSGk5MWsw?= =?utf-8?Q?UOJDg1V5OnEB1MU5/ODUtFR+Lf3X5AYflEGqNA+?= X-MS-Exchange-CrossTenant-Network-Message-Id: 0e507f84-7da4-4c92-8d50-08d96d259f47 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Sep 2021 08:51:00.4752 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: T45VGRtlXO/btqlM1/amhcL/yWWc5kq5OpllMPih6nAjE7mKAq+HeQwJIkxXRuKW6bIl4AssSoo9pJQ10mqXWA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB5340 X-OriginatorOrg: citrix.com On Tue, Aug 31, 2021 at 05:38:49PM +0200, Jan Beulich wrote: > On 31.08.2021 17:25, Andrew Cooper wrote: > > On 31/08/2021 14:26, Jan Beulich wrote: > >> On 31.08.2021 15:16, Andrew Cooper wrote: > >>> On 30/08/2021 14:02, Jan Beulich wrote: > >>>> Further permit "access" to differ in the "executable" attribute. While > >>>> ideally only ROM regions would get mapped with X set, getting there is > >>>> quite a bit of work. Therefore, as a temporary measure, permit X to > >>>> vary. For Dom0 the more permissive of the types will be used, while for > >>>> DomU it'll be the more restrictive one. > >>> Split behaviour between dom0 and domU based on types alone cannot > >>> possibly be correct. > >> True, but what do you do. > >> > >>> DomU's need to execute ROMs too, and this looks like will malfunction if > >>> a ROM ends up in the region that HVMLoader relocated RAM from. > >>> > >>> As this is a temporary bodge emergency bugfix, don't try to be clever - > >>> just take the latest access. > >> And how do we know that that's what is going to work? > > > > Because it's the pre-existing behaviour. > > Valid point. But for the DomU case there simply has not been any > pre-existing behavior. Hence my desire to be restrictive initially > there. > > >> We should > >> strictly accumulate for Dom0. And what we do for DomU is moot for > >> the moment, until PCI passthrough becomes a thing for PVH. Hence > >> I've opted to be restrictive there - I'd rather see things break > >> (and getting adjusted) when this future work actually gets carried > >> out, than leave things permissive for no-one to notice that it's > >> too permissive, leading to an XSA. > > > > Restricting execute permissions is something unique to virt.  It doesn't > > exist in a non-virtualised system, as I and D side reads are > > indistinguishable outside of the core. > > > > Furthermore, it is inexpressible on some systems/configurations. > > > > Introspection is the only technology which should be restricting execute > > permissions in the p2m, and only when it takes responsibility for > > dealing with the fallout. > > IOW are you saying that the calls to set_identity_p2m_entry() > (pre-dating XSA-378) were wrong to use p2m_access_rw? Because that's > what's getting the way here. I did wonder this before, because I saw some messages on a couple of systems about mappings override, and I'm not sure why we need to use p2m_access_rw. My first thought was to suggest to switch to use the default access type for the domain, like set_mmio_p2m_entry does. I have to admit I'm not sure I see the point of preventing execution, but it's possible I'm missing something. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Wed Sep 01 08:53:52 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Sep 2021 08:53:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.176121.320565 (Exim 4.92) (envelope-from ) id 1mLM0E-0007XM-Mi; Wed, 01 Sep 2021 08:53:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 176121.320565; Wed, 01 Sep 2021 08:53:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLM0E-0007XF-JL; Wed, 01 Sep 2021 08:53:50 +0000 Received: by outflank-mailman (input) for mailman id 176121; Wed, 01 Sep 2021 08:53:49 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLM0D-0007X7-4U for xen-devel@lists.xenproject.org; Wed, 01 Sep 2021 08:53:49 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 2dc88f39-720a-4c56-b075-d83fc9c3a439; Wed, 01 Sep 2021 08:53:48 +0000 (UTC) Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-ve1eur02lp2058.outbound.protection.outlook.com [104.47.6.58]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-5-39mDbc8ZN2C-TWNKzoD8Lg-1; Wed, 01 Sep 2021 10:53:46 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR04MB4607.eurprd04.prod.outlook.com (2603:10a6:803:71::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.23; Wed, 1 Sep 2021 08:53:44 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4478.019; Wed, 1 Sep 2021 08:53:44 +0000 Received: from [10.156.60.236] (37.24.206.209) by PR1P264CA0013.FRAP264.PROD.OUTLOOK.COM (2603:10a6:102:19e::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Wed, 1 Sep 2021 08:53:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2dc88f39-720a-4c56-b075-d83fc9c3a439 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1630486427; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HQb3lb36j6E87dv80nGPY//1dizzbRcvuL1J6kgjH38=; b=ex3eMQDxbRNo8vHqSXxuYGJrsyLvj1Mmh/7rGu7y8Y4hoAvcu6tNUJtI1ygKG44F+IrwG8 l0rG5kPxlLdse9sLk7XWeyT4fSiWsYqvcX0jNBJuWlrAsSRoCy4wsYGjgOrd/Y56lrlBoz yAbFb2kMx8sIxpSQF6b5e1OwiogCuKE= X-MC-Unique: 39mDbc8ZN2C-TWNKzoD8Lg-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=b4dzlHzFyys8qyCTkFUK+XwBQUjgKRHIuqIzhW0K852SqRbf3m6ZSLyUMMzMyDmdfHTa29FKOAG+n9kcnuYfFp4Tqq6o9r9eABKducresqVyOQ29egu4tnzh2NmltVRY+FRhFlL+aFkYPhhBWC1Z17mdeLic7yBpeNXGVZJaAyckg/4aG/H5cLAcixNLtOe5vvgShxcqyzjSvIe2vSpEA5hdjKVBmCIrBvnrVkoxUAL6BlPDyMaSqh4gT/SKQYyYOXApRu22EaD6sg+0OYdVA9yjsOgxoxhcduUjC/jmRKxidFbq5rjPibfY2OqhiCIZhDRO5t4TSc8w3L4mH2YyDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HQb3lb36j6E87dv80nGPY//1dizzbRcvuL1J6kgjH38=; b=iLXVU6OnweTr+7K1JVNjH7p0ti4CoxZhkMYzaKVB175QQqURLT+/Vy7DQTsF3MKFSFMSgRHp6ApMkeJG6/M4/j33J5FGf8ykaDw8gwlbqO/wL5zUDmj4+5QXdF2ZUMvRKLVBlHrhTBEtobJ8Ralcu30OHWzDOIVy2V3hJeaGOqagZn2Vl7hIPdKLvopxISIvNMq7FQbjbBdGJitFlPWd3i9HBMiOjm+aT30tts5Ipq9Y0yn0+EBV3lxwGuPkHe94BjyiJBm5ECjZ2r1wHwSxJqHSAE/+X5phJoWFk/l59rFs3wvcInwHjT/oxRNMqAuzDzMCZ8l2isNy2Inx2ZujJw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=suse.com; Subject: Re: [PATCH] domain: try to address Coverity pointing out a missing "break" in domain_teardown() To: Bertrand Marquis Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu References: <20e28e4b-c794-7435-5f5c-332e9a6c0433@suse.com> <9FDBB4B2-9025-4F75-BDFC-0BECBBBEB7E2@arm.com> From: Jan Beulich Message-ID: <175ce359-6ec5-6847-ed76-9aeb51705fe7@suse.com> Date: Wed, 1 Sep 2021 10:53:42 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: <9FDBB4B2-9025-4F75-BDFC-0BECBBBEB7E2@arm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PR1P264CA0013.FRAP264.PROD.OUTLOOK.COM (2603:10a6:102:19e::18) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: abe0983b-96a9-4a1f-b57e-08d96d260140 X-MS-TrafficTypeDiagnostic: VI1PR04MB4607: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: iLrw0glNYC6MoVr7R7vA/7Qj7zjZmcMGQDOfqEZlsrrneW8Dzbm4eFqvndLAC9HDQKT1uSJEWtWqjFE78oOfEnicnhjxL10ZgFq/aJteUNhkfYLgqPXBP9jjbHKKIDFDMW7zIYzQ9npRXz1ByvmszOrnml4lPTErP0bPK3Kwkx6ojSzF6SYSnVcJBouSb3nLTF2Wiksdkd+kwJ378QqJBSAsqbGTa519rKup8V0ln+PyICLnCXkfJEr68TvM/VJ9asUU9DZLiCrr2HA4uqjVxnhqzOnkX5Q6sc8V3MUDKqDHm3AwUOcfgxw1KqAFGRnyRUVofeDaxmNvvP8KdBusMBYtdJ1m8ekLfiyN+IAbaBKPN1PYn+RkzR48V0TFHYGxvlYVv83Ihr0nSbjQXbVU2Uu5n8FszFYywM67mRTfeYgsakgf3h+jqX1/XTW9WmSVh4AiBtoDxKw0mFeJu6TqzbRrED7h/NdFdSUyiywVwd3ARpTQGuvKFeoFL9Jp9SUJOkMtUoCXAld1olY1KZLxx9e7Zf0fV14uDo7XupKjI6RzdFuMnYxF0JcTRwh/jQhXcFcItBCa4Q7ZZTEuS85zahvvYDXxlR6bWYfzMoyq6OSc9Vw3GKJsaWZ7S0ttGZgZ8eUxfolY8AHkZbJtz7/P1zhicHCV+JRV1+W4+xMaqDBe06FWFCNZ9lRJINbOr+r73U0pM9r8WDGx11gEqRCMukemZVDoO8cANs8t0XRnk8M= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(39860400002)(376002)(346002)(366004)(396003)(136003)(5660300002)(4326008)(2616005)(478600001)(86362001)(38100700002)(6916009)(186003)(31696002)(26005)(53546011)(36756003)(16576012)(956004)(66556008)(8936002)(54906003)(6486002)(2906002)(8676002)(66476007)(31686004)(66946007)(83380400001)(316002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aTRwNVVJOGdBSGp1Ykczd2NzZ2d5OFd2cG5TTzFVQ3Blbnlrc3NNbHY4dzM2?= =?utf-8?B?R2hwR2orWVk3ZWJzc3pkVFN1MWswU2hvc2ZXaGc3dEVPVXNxMS9GTVNuQ3ll?= =?utf-8?B?NVNlY2tONEduWFloWFBEcHprL1pFTUtQaFA4bTBSbFFYRjZ5UDJEM05nOWRN?= =?utf-8?B?SFJuNnI5WXlqek1jSXVkOXNBNS9ZYm5UMjNWZ1h1dTRKTVJQelFGMEhVT3RL?= =?utf-8?B?ZGZkN294RXhyQWtQTjJpc3EwRUZNVFNPSnNoSksxaFhoMFBrTm1XaUJYeGFh?= =?utf-8?B?MElBTnRYaFU5SEZNUml0ZUswZWNlTEwzVTZta1EzOTJkWXhxRDVHYjNxTUV3?= =?utf-8?B?UXE1NEFrYVdFQ3hGV2UxTzJSb3o3RllGeEl6MW0zSGliTjA1OEdOOEdmSVRU?= =?utf-8?B?eDZHYSt5SU5UVm5QTXZGZG56K2JQQ1ZWZEdWWGlYUUlKZzJGSDZ5MTlreEc3?= =?utf-8?B?eGZuWFR2ZXUwZytWMHFTL0Yxc1JiakNxOE9ubEZSN2lnMzVrRVFMOTQrK3Jk?= =?utf-8?B?WGc5Tm5hTGFmL24xMXQ3eHRmSWY3eGMzSVVhcDBZMXNpMmpBblNxUUE2clV5?= =?utf-8?B?QzNRRjZUZnJNSWZkeGZFVEZnRkxXa0RTTVhOMVBSQnNwNklNWjJGSnNHV3Vu?= =?utf-8?B?bnp1R1hXTkVwR1drV0ZTZzA1OW44enBSeGdTU0sxYXptbDBZeEplVjZ4L09x?= =?utf-8?B?M0hkRkNHUlV3TG93aGNCVnk2T1Ntdk1sd1ljS2N5eFZvNkFHN0hqZ1lVOUFC?= =?utf-8?B?OWd0MTBKYXJGMjFib05XY2ViUWkvbXFnbjJWK0VIeWlVVXJnYmJrN0RTQVRO?= =?utf-8?B?WXN2ZG1rVWxGODBlOGhzNXBJME5SZFIzY2FUMHdsS3h3LzNydWVhVjlpY3Jo?= =?utf-8?B?SFlOcm90ekFKVUl2Z25EYjNxUFlUaTIwM1ZnakF3WUFNbFNaUzJhNnBBV09R?= =?utf-8?B?cy9rVE05VVM4bmYrU2VZWUVWdFFiZk1kVGhvZ2RQb3FMNzJrdGhNejBqQUxs?= =?utf-8?B?OHRlT3BTaitNSm9IZGIzOHcrVGM3ais5Z0pWWVFjQXFtM09TTDU0cUsvMUlT?= =?utf-8?B?WEhwU1NtdWNCVXJnS05uaEsxOUZtRXZaa1ZWV1BLaU9na3g5dnJGMElwa2o0?= =?utf-8?B?S01Ucm5KKzNSNE9TQ0hBb2dWSUJpamt4UExSMlNWV2VDdHFhTERacnFRZ2Z3?= =?utf-8?B?ZEsvMmZaclljZVFyU3FsN0ZQREwwdEI2SHNVUXdVTXNmOUdwaGt4VmY3Mk1H?= =?utf-8?B?OFhpVzJENWxFTW04QU0rL2RCNXJraExyZVFsZmRPcmVua0t6REhsb1VPTjhC?= =?utf-8?B?aFZGZnZUL2VsS1BMTjRDTDlTcElYM01EdWd6N1FDV3FSQ3pzalc5NHBlSEJC?= =?utf-8?B?NGxDUFlyZGxMM3hPU2wvSTBsYXhZdE5zUGhLTEYxTmQzYlcwNU5kdnpqLzlQ?= =?utf-8?B?TXhteWRadVdsTDJlcVlrSytRRXlTWWd2aXdxdENRMTVVRDJTMmZhZ3JtZUZW?= =?utf-8?B?TldEU1VRVDU2bG1aUnBybXptVWlNMndBeFQyNnhZelhrR2Z4c3hkNWg0enVS?= =?utf-8?B?TC8yc2k2NFRUTk5UbVRZdnJkWkNCRXlyMEVOWURZZ3pySzh1WXZGREhraU50?= =?utf-8?B?QWJmclBVMW1FWFFWNFloa2RGTERER1JTUFdrVit5bFV5cFczME1vZ0pyQ2oz?= =?utf-8?B?dStobkRNY3JoRFFSQVprM2FPOVFoTXNiRHN2N0llTHNzUndCUXlDZExhMnRS?= =?utf-8?Q?LbqmOieTHixu83akT8+a1Cot7mk9OKB0BnxFZV0?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: abe0983b-96a9-4a1f-b57e-08d96d260140 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Sep 2021 08:53:44.7858 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: oeuqzVBo50/U2wtXHBykS4FMQYqwkm/6/2bd+2n9czGAu1XP1bFMp17HO4JxvzQctOHwcb4QbOePFuRNQEEPwQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4607 On 01.09.2021 10:49, Bertrand Marquis wrote: >> On 1 Sep 2021, at 09:45, Jan Beulich wrote: >> Commit 806448806264 ("xen/domain: Fix label position in >> domain_teardown()" has caused Coverity to report a _new_ supposedly >> un-annotated fall-through in a switch(). I find this (once again) >> puzzling; I'm having an increasingly hard time figuring what patterns >> the tool is actually after. I would have expected that the tool would >> either have spotted an issue also before this change, or not at all. Yet >> if it had spotted one before, the statistics report should have included >> an eliminated instance alongside the new one (because then the issue >> would simply have moved by a few lines). >> >> Hence the only thing I could guess is that the treatment of comments in >> macro expansions might be subtly different. Therefore try whether >> switching the comments to the still relatively new "fallthrough" pseudo >> keyword actually helps. >> >> Coverity-ID: 1490865 >> Signed-off-by: Jan Beulich > > A grep inside Xen code show that we have occurence of: > /* fallthrough */ > /* Fallthrough */ > falltrough > > Should we actually fix all of them ? I don't think so, or at least don't view this as urgent. As described what I'm suspecting here is an issue with such comments living inside macros. I don't think we have too many instances of such. In case my guess is right (and hence in case the patch actually helps), we may want to change all in this much smaller set, but as you say ... > Anyway this can be in an other patch. ... in a separate patch (not the least because we still need to see whether the change helps in the first place). > Reviewed-by: Bertrand Marquis Thanks. Jan From xen-devel-bounces@lists.xenproject.org Wed Sep 01 08:57:17 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Sep 2021 08:57:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.176127.320576 (Exim 4.92) (envelope-from ) id 1mLM3S-0008C0-57; Wed, 01 Sep 2021 08:57:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 176127.320576; Wed, 01 Sep 2021 08:57:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLM3S-0008Bs-1x; Wed, 01 Sep 2021 08:57:10 +0000 Received: by outflank-mailman (input) for mailman id 176127; Wed, 01 Sep 2021 08:57:08 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLM3Q-0008B1-Qz for xen-devel@lists.xenproject.org; Wed, 01 Sep 2021 08:57:08 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLM3Q-0006Nv-JV; Wed, 01 Sep 2021 08:57:08 +0000 Received: from [54.239.6.187] (helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1mLM3Q-0002oP-Dk; Wed, 01 Sep 2021 08:57:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=2woEMNGAqbi5v4Yljw72/vRg6uMvPADMrGXsyYLrLmw=; b=J9cM7gqPONS5y8YD0FxhRvcIPi g0BV1hy5ajvTmAV8hx3an+GHQCZ+6De3d2cnAvR3axjZeZwxGWyvMaXWvN9a7zpUs5VwXJscYUC63 6S+nSyUe76tBDSXtlEgEVitWQnWZnK7rTRExmZrjtTlMZNQzxvusI/cKumZRDSlYHNns=; Subject: Re: [PATCH v5 1/7] xen/arm: introduce new helper device_tree_get_meminfo To: Penny Zheng , xen-devel@lists.xenproject.org, sstabellini@kernel.org Cc: Bertrand.Marquis@arm.com, Wei.Chen@arm.com, nd@arm.com References: <20210824095045.2281500-1-penny.zheng@arm.com> <20210824095045.2281500-2-penny.zheng@arm.com> From: Julien Grall Message-ID: <06395a17-24fb-35d5-8332-a6ca42dbc183@xen.org> Date: Wed, 1 Sep 2021 09:57:06 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210824095045.2281500-2-penny.zheng@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Hi Penny, On 24/08/2021 10:50, Penny Zheng wrote: > A few functions iterate over the device tree property to get memory info, > like "reg" or the later "xen,static-mem", so this commit creates a new helper > device_tree_get_meminfo to extract the common codes. The commit message needs to be updated as the patch has been reshuffled. > Signed-off-by: Penny Zheng > --- > xen/arch/arm/bootfdt.c | 68 ++++++++++++++++++++++++------------------ > 1 file changed, 39 insertions(+), 29 deletions(-) > > diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c > index 476e32e0f5..8c81be3379 100644 > --- a/xen/arch/arm/bootfdt.c > +++ b/xen/arch/arm/bootfdt.c > @@ -63,6 +63,44 @@ void __init device_tree_get_reg(const __be32 **cell, u32 address_cells, > *size = dt_next_cell(size_cells, cell); > } > > +static int __init device_tree_get_meminfo(const void *fdt, int node, > + const char *prop_name, > + u32 address_cells, u32 size_cells, > + void *data) > +{ > + const struct fdt_property *prop; > + unsigned int i, banks; > + const __be32 *cell; > + u32 reg_cells = address_cells + size_cells; > + paddr_t start, size; > + struct meminfo *mem = data; > + > + prop = fdt_get_property(fdt, node, prop_name, NULL); > + if ( !prop ) > + return -ENOENT; > + > + cell = (const __be32 *)prop->data; > + banks = fdt32_to_cpu(prop->len) / (reg_cells * sizeof (u32)); > + > + for ( i = 0; i < banks && mem->nr_banks < NR_MEM_BANKS; i++ ) > + { > + device_tree_get_reg(&cell, address_cells, size_cells, &start, &size); > + /* Some DT may describe empty bank, ignore them */ > + if ( !size ) > + continue; > + mem->bank[mem->nr_banks].start = start; > + mem->bank[mem->nr_banks].size = size; > + mem->nr_banks++; > + } > + > + if ( i < banks ) > + { > + printk("Warning: Max number of supported memory regions reached.\n"); > + return -ENOSPC; > + } > + return 0; > +} > + > u32 __init device_tree_get_u32(const void *fdt, int node, > const char *prop_name, u32 dflt) > { > @@ -139,14 +177,6 @@ static int __init process_memory_node(const void *fdt, int node, > u32 address_cells, u32 size_cells, > void *data) > { > - const struct fdt_property *prop; > - int i; > - int banks; > - const __be32 *cell; > - paddr_t start, size; > - u32 reg_cells = address_cells + size_cells; > - struct meminfo *mem = data; > - > if ( address_cells < 1 || size_cells < 1 ) This check will be the same for "xen,static-mem". So can it be moved to device_tree_get_meminfo()? > { > printk("fdt: node `%s': invalid #address-cells or #size-cells", > @@ -154,27 +184,7 @@ static int __init process_memory_node(const void *fdt, int node, > return -EINVAL; > } > > - prop = fdt_get_property(fdt, node, "reg", NULL); > - if ( !prop ) > - return -ENOENT; > - > - cell = (const __be32 *)prop->data; > - banks = fdt32_to_cpu(prop->len) / (reg_cells * sizeof (u32)); > - > - for ( i = 0; i < banks && mem->nr_banks < NR_MEM_BANKS; i++ ) > - { > - device_tree_get_reg(&cell, address_cells, size_cells, &start, &size); > - /* Some DT may describe empty bank, ignore them */ > - if ( !size ) > - continue; > - mem->bank[mem->nr_banks].start = start; > - mem->bank[mem->nr_banks].size = size; > - mem->nr_banks++; > - } > - > - if ( i < banks ) > - return -ENOSPC; > - return 0; > + return device_tree_get_meminfo(fdt, node, "reg", address_cells, size_cells, data); > } > > static int __init process_reserved_memory_node(const void *fdt, int node, > Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Sep 01 08:59:33 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Sep 2021 08:59:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.176134.320592 (Exim 4.92) (envelope-from ) id 1mLM5k-0000Ps-Qg; Wed, 01 Sep 2021 08:59:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 176134.320592; Wed, 01 Sep 2021 08:59:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLM5k-0000PM-MP; Wed, 01 Sep 2021 08:59:32 +0000 Received: by outflank-mailman (input) for mailman id 176134; Wed, 01 Sep 2021 08:59:31 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLM5j-0000NG-21 for xen-devel@lists.xen.org; Wed, 01 Sep 2021 08:59:31 +0000 Received: from mail-wm1-x32c.google.com (unknown [2a00:1450:4864:20::32c]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 7b077ebb-3606-4097-8e86-7a9547631e3e; Wed, 01 Sep 2021 08:59:29 +0000 (UTC) Received: by mail-wm1-x32c.google.com with SMTP id o39-20020a05600c512700b002e74638b567so1387676wms.2 for ; Wed, 01 Sep 2021 01:59:29 -0700 (PDT) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id q11sm4990687wmc.41.2021.09.01.01.59.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Sep 2021 01:59:27 -0700 (PDT) Received: from zen (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id E26A91FF96; Wed, 1 Sep 2021 09:59:26 +0100 (BST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7b077ebb-3606-4097-8e86-7a9547631e3e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=references:user-agent:from:to:cc:subject:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=4vx7Zbm8CuixWNdewxmOaS8u+QseNO7OTa6aQNrm0kI=; b=Dn56lMmrX0vlpkgbNgHhqRiO345nhCfgtmp3bXAdFY+1uszjRzJj3wC+21HEB3EUDi CbcMUWUe3+SjAPdtvjLenZP/vubL3FhqjPm5Dvcs01tds9PIkDgTal7dX5qrLBPnfoPA bh45l88MiLik/bdk8Fk6pEI2Xn1GqsV8X88IFUxQiiumqrwhDwpAO9fuBmPKmejsy8UU 3i4UdlvkfACw/gz3uEvM8Ipw+vYnbMMkM3IM/oCTYU3YTtOijHfCgJe0LvunsEVeUchE cE2yp4J+6JAg4F6pN4F7APMOL7eBwaV5A/58njHTalQSj5MFZEdP5revZmdYmHRouKhk MPLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject:date :in-reply-to:message-id:mime-version:content-transfer-encoding; bh=4vx7Zbm8CuixWNdewxmOaS8u+QseNO7OTa6aQNrm0kI=; b=pNsKGl4JniibPg/b/waWhwLB99M8HFtFiCk9Lc6MANvsn14QpZFhcvVXykbc82av1l LRrhjvkKEmiYBZAeUIu9UACeyOOvXhJOoSJ0xDFX4snL1wyY3p2fC1k1+oVUBAXNRf0K AWAuPQ98nIRJJMB8my19bdjH/dRfdTZqpRBzGx8yHF2xAVqRBnEkZ745e5HilnxJglX4 KGbT7vX1lJraSb7tqUyc2MTpkw56B/DNjBWiSC/g5pQtAlmfFho3ss0t/NHA8CEdrHmF FOd1nwl5Cw4RdQ7nRnB9JOPsptN2z2WllZ2NN58AOKVrFAhogl3r3M0nRkeUDmvBsU9/ Fwug== X-Gm-Message-State: AOAM533DxL1lWXtu0vLFN0NXx/sBVwhMm8iwhpI17ry54C5iyazSdWes 28iBpIvwGvUqdA6cuKsMXjbTFw== X-Google-Smtp-Source: ABdhPJy1JDP7j3J1vzC7astXeHHHohtbMvmxOm+XGvKbN37GI/QmPrNdycwQml/nktVwrMmQ0N4VcA== X-Received: by 2002:a1c:f314:: with SMTP id q20mr8677397wmq.154.1630486768626; Wed, 01 Sep 2021 01:59:28 -0700 (PDT) References: <87v94ldrqq.fsf@linaro.org> <0100017b33e585a5-06d4248e-b1a7-485e-800c-7ead89e5f916-000000@email.amazonses.com> <20210813051038.GA77540@laputa> User-agent: mu4e 1.7.0; emacs 28.0.50 From: Alex =?utf-8?Q?Benn=C3=A9e?= To: AKASHI Takahiro Cc: Fran??ois Ozog , Stefano Stabellini , paul@xen.org, Stratos Mailing List , virtio-dev@lists.oasis-open.org, Jan Kiszka , Arnd Bergmann , jgross@suse.com, julien@xen.org, Carl van Schaik , Bertrand.Marquis@arm.com, stefanha@redhat.com, Artem_Mygaiev@epam.com, xen-devel@lists.xen.org, olekstysh@gmail.com, Oleksandr_Tyshchenko@epam.com, xen-devel@lists.xenproject.org Subject: Re: [Stratos-dev] Enabling hypervisor agnosticism for VirtIO backends Date: Wed, 01 Sep 2021 09:57:45 +0100 In-reply-to: <20210813051038.GA77540@laputa> Message-ID: <87eea8hdsh.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable AKASHI Takahiro writes: > Hi Fran=C3=A7ois, > > On Thu, Aug 12, 2021 at 09:55:52AM +0200, Fran??ois Ozog wrote: >> I top post as I find it difficult to identify where to make the comments. > > Thank you for the posting.=20 > I think that we should first discuss more about the goal/requirements/ > practical use cases for the framework. > >> 1) BE acceleration >> Network and storage backends may actually be executed in SmartNICs. As >> virtio 1.1 is hardware friendly, there may be SmartNICs with virtio 1.1 = PCI >> VFs. Is it a valid use case for the generic BE framework to be used in t= his >> context? >> DPDK is used in some BE to significantly accelerate switching. DPDK is a= lso >> used sometimes in guests. In that case, there are no event injection but >> just high performance memory scheme. Is this considered as a use case? > > I'm not quite familiar with DPDK but it seems to be heavily reliant > on not only virtqueues but also kvm/linux features/functionality, say, > according to [1]. > I'm afraid that DPDK is not suitable for primary (at least, initial) > target use. > # In my proposal, virtio-proxy, I have in mind the assumption that we wou= ld > # create BE VM as a baremetal application on RTOS (and/or unikernel.) > > But as far as virtqueue is concerned, I think we can discuss in general > technical details as Alex suggested, including: > - sharing or mapping memory regions for data payload > - efficient notification mechanism > > [1] https://www.redhat.com/en/blog/journey-vhost-users-realm > >> 2) Virtio as OS HAL >> Panasonic CTO has been calling for a virtio based HAL and based on the >> teachings of Google GKI, an internal HAL seem inevitable in the long ter= m. >> Virtio is then a contender to Google promoted Android HAL. Could the >> framework be used in that context? > > In this case, where will the implementation of "HAL" reside? > I don't think the portability of "HAL" code (as a set of virtio BEs) > is a requirement here. When I hear people referring to VirtIO HALs I'm thinking mainly of VirtIO FE's living in a Linux kernel. There are certainly more devices that can get added but the commonality on the guest side I think is pretty much a solved problem (modulo Linux-ism's creeping into the virtio spec). --=20 Alex Benn=C3=A9e From xen-devel-bounces@lists.xenproject.org Wed Sep 01 08:59:33 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Sep 2021 08:59:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.176133.320586 (Exim 4.92) (envelope-from ) id 1mLM5k-0000Nc-IA; Wed, 01 Sep 2021 08:59:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 176133.320586; Wed, 01 Sep 2021 08:59:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLM5k-0000NV-FD; Wed, 01 Sep 2021 08:59:32 +0000 Received: by outflank-mailman (input) for mailman id 176133; Wed, 01 Sep 2021 08:59:30 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLM5i-0000NG-KF for xen-devel@lists.xenproject.org; Wed, 01 Sep 2021 08:59:30 +0000 Received: from mail-wm1-x32c.google.com (unknown [2a00:1450:4864:20::32c]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 4befbfe0-02cf-4f58-ae92-cc2125c322fc; Wed, 01 Sep 2021 08:59:29 +0000 (UTC) Received: by mail-wm1-x32c.google.com with SMTP id u15-20020a05600c19cf00b002f6445b8f55so1012152wmq.0 for ; Wed, 01 Sep 2021 01:59:29 -0700 (PDT) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id q11sm4990687wmc.41.2021.09.01.01.59.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Sep 2021 01:59:27 -0700 (PDT) Received: from zen (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id E26A91FF96; Wed, 1 Sep 2021 09:59:26 +0100 (BST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4befbfe0-02cf-4f58-ae92-cc2125c322fc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=references:user-agent:from:to:cc:subject:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=4vx7Zbm8CuixWNdewxmOaS8u+QseNO7OTa6aQNrm0kI=; b=Dn56lMmrX0vlpkgbNgHhqRiO345nhCfgtmp3bXAdFY+1uszjRzJj3wC+21HEB3EUDi CbcMUWUe3+SjAPdtvjLenZP/vubL3FhqjPm5Dvcs01tds9PIkDgTal7dX5qrLBPnfoPA bh45l88MiLik/bdk8Fk6pEI2Xn1GqsV8X88IFUxQiiumqrwhDwpAO9fuBmPKmejsy8UU 3i4UdlvkfACw/gz3uEvM8Ipw+vYnbMMkM3IM/oCTYU3YTtOijHfCgJe0LvunsEVeUchE cE2yp4J+6JAg4F6pN4F7APMOL7eBwaV5A/58njHTalQSj5MFZEdP5revZmdYmHRouKhk MPLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject:date :in-reply-to:message-id:mime-version:content-transfer-encoding; bh=4vx7Zbm8CuixWNdewxmOaS8u+QseNO7OTa6aQNrm0kI=; b=NPbvgMkRZmSNcVhbh6p/H/Wq+LvA6KjOWSu+8UGtp0tQM0beWpslObKmYG83SqZm3n /vHB4ZGgn3LS4RKp5isa2eIhgpcvXlgvlWsJqfHP4ppSyIMGqRzieSSxKPdqrcpCcWAX B3k0Xr1vGnZZOMhlN1jG8txj2V8KWfgzrqmPYy4TR62mb8+fuebzoCFmZ+jNHnyai59H G+4isKQPFGBPjBm7jyxLNugJAAniu2u1Ey+v7nIxGpWQLUNy4VC40bylgYN7q6+Z/0Pa NsnwUhpNmjsg+kEbWFJgCnydeE0rECikRxdSnLoKLa3XzcCMDKdT/nhUsDz81w6X7SOT pcZw== X-Gm-Message-State: AOAM530MIKCoA1GJm5Af54q6AsB/n2pluN9zXrm6Febakv7v0+n1C4Y2 0YeYrmXgTEQHrw/Y31VzpAhuiw== X-Google-Smtp-Source: ABdhPJy1JDP7j3J1vzC7astXeHHHohtbMvmxOm+XGvKbN37GI/QmPrNdycwQml/nktVwrMmQ0N4VcA== X-Received: by 2002:a1c:f314:: with SMTP id q20mr8677397wmq.154.1630486768626; Wed, 01 Sep 2021 01:59:28 -0700 (PDT) References: <87v94ldrqq.fsf@linaro.org> <0100017b33e585a5-06d4248e-b1a7-485e-800c-7ead89e5f916-000000@email.amazonses.com> <20210813051038.GA77540@laputa> User-agent: mu4e 1.7.0; emacs 28.0.50 From: Alex =?utf-8?Q?Benn=C3=A9e?= To: AKASHI Takahiro Cc: Fran??ois Ozog , Stefano Stabellini , paul@xen.org, Stratos Mailing List , virtio-dev@lists.oasis-open.org, Jan Kiszka , Arnd Bergmann , jgross@suse.com, julien@xen.org, Carl van Schaik , Bertrand.Marquis@arm.com, stefanha@redhat.com, Artem_Mygaiev@epam.com, xen-devel@lists.xen.org, olekstysh@gmail.com, Oleksandr_Tyshchenko@epam.com, xen-devel@lists.xenproject.org Subject: Re: [Stratos-dev] Enabling hypervisor agnosticism for VirtIO backends Date: Wed, 01 Sep 2021 09:57:45 +0100 In-reply-to: <20210813051038.GA77540@laputa> Message-ID: <87eea8hdsh.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable AKASHI Takahiro writes: > Hi Fran=C3=A7ois, > > On Thu, Aug 12, 2021 at 09:55:52AM +0200, Fran??ois Ozog wrote: >> I top post as I find it difficult to identify where to make the comments. > > Thank you for the posting.=20 > I think that we should first discuss more about the goal/requirements/ > practical use cases for the framework. > >> 1) BE acceleration >> Network and storage backends may actually be executed in SmartNICs. As >> virtio 1.1 is hardware friendly, there may be SmartNICs with virtio 1.1 = PCI >> VFs. Is it a valid use case for the generic BE framework to be used in t= his >> context? >> DPDK is used in some BE to significantly accelerate switching. DPDK is a= lso >> used sometimes in guests. In that case, there are no event injection but >> just high performance memory scheme. Is this considered as a use case? > > I'm not quite familiar with DPDK but it seems to be heavily reliant > on not only virtqueues but also kvm/linux features/functionality, say, > according to [1]. > I'm afraid that DPDK is not suitable for primary (at least, initial) > target use. > # In my proposal, virtio-proxy, I have in mind the assumption that we wou= ld > # create BE VM as a baremetal application on RTOS (and/or unikernel.) > > But as far as virtqueue is concerned, I think we can discuss in general > technical details as Alex suggested, including: > - sharing or mapping memory regions for data payload > - efficient notification mechanism > > [1] https://www.redhat.com/en/blog/journey-vhost-users-realm > >> 2) Virtio as OS HAL >> Panasonic CTO has been calling for a virtio based HAL and based on the >> teachings of Google GKI, an internal HAL seem inevitable in the long ter= m. >> Virtio is then a contender to Google promoted Android HAL. Could the >> framework be used in that context? > > In this case, where will the implementation of "HAL" reside? > I don't think the portability of "HAL" code (as a set of virtio BEs) > is a requirement here. When I hear people referring to VirtIO HALs I'm thinking mainly of VirtIO FE's living in a Linux kernel. There are certainly more devices that can get added but the commonality on the guest side I think is pretty much a solved problem (modulo Linux-ism's creeping into the virtio spec). --=20 Alex Benn=C3=A9e From xen-devel-bounces@lists.xenproject.org Wed Sep 01 09:00:10 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Sep 2021 09:00:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.176146.320609 (Exim 4.92) (envelope-from ) id 1mLM6M-0002Hi-6L; Wed, 01 Sep 2021 09:00:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 176146.320609; Wed, 01 Sep 2021 09:00:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLM6M-0002Hb-2y; Wed, 01 Sep 2021 09:00:10 +0000 Received: by outflank-mailman (input) for mailman id 176146; Wed, 01 Sep 2021 09:00:08 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLM6K-0001Ea-KM for xen-devel@lists.xenproject.org; Wed, 01 Sep 2021 09:00:08 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id a8bd7362-c5c4-44d9-b891-ff5aaeec671b; Wed, 01 Sep 2021 09:00:03 +0000 (UTC) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04lp2054.outbound.protection.outlook.com [104.47.14.54]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-1-kl2wIvanN7-Qe8fHEPjJFw-1; Wed, 01 Sep 2021 11:00:01 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR04MB5166.eurprd04.prod.outlook.com (2603:10a6:803:53::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.23; Wed, 1 Sep 2021 08:59:59 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4478.019; Wed, 1 Sep 2021 08:59:59 +0000 Received: from [10.156.60.236] (37.24.206.209) by PR2P264CA0011.FRAP264.PROD.OUTLOOK.COM (2603:10a6:101::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.17 via Frontend Transport; Wed, 1 Sep 2021 08:59:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a8bd7362-c5c4-44d9-b891-ff5aaeec671b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1630486802; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Hcz99EKLAguPUtj+MYXe/atzn888fi5RnKG/mjRKRuY=; b=XjtR/Kd4JgoOXi/Sz5c/oMKlQgNd/0Pzxdugf9rsQ3gjE7jZDFZdGQ7cPqmh4WIsbLsqbN Zwq44B8rXV4oXbUsOImcGKicpd9RA2LR+r2AHDNWnQkKPmRqk7COOJxKqLZp3S4AeMKxtb 1gTsCOJ4DrQieH2nMz8p3DqSf18bWVA= X-MC-Unique: kl2wIvanN7-Qe8fHEPjJFw-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cPjrxb9HzE2Dsm5BmMFpNIRmxHkHsXYXlVeL8Snxo2jpbBMsSnMJdacIBEXROAcR/mjvYb2KPW1En7spXwuVOIm367uFo80JnPbvpOrZcMyTTSnXwhfFaTTSGTT2bZiUsj39uLacoFbAKPUk4yABl87hSxsE3u8S/NeyOw7dctrcCTlmMhmWa51d5ZaLgnTeQ1m72XAaT1Vyg1ffd8Ad+4KxL2hWiyLlcjP0lNVz+TwQ+EZvb6+T+Eka4govxznIudsMfu5lyODm2Tx9fjr3NueCfx8n0U3eow3HVW0EtBlTta4Xg42rAD7ABBXsN5B7bg6FQRkD25bSP1FKaqpwiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Hcz99EKLAguPUtj+MYXe/atzn888fi5RnKG/mjRKRuY=; b=WD1fgt6DL936HyV3rO/vpO/9YRxGSGe4ACQaJm0qtQK3x/XtlR9a0fLl6dRMwC7MhU3BFKdcdcdCbOcrAtH+jLjDpLTc5JbUHKtX1Qn07eGXDY0FbOC7A7rL0+SJUoEVsJNmNzGTCPPrgDHQehYDGTE3MswuMKUc45gtCd1YTZn492moxHz2TNEtuKV7wBVcGeGvCBydI1MlfL+0RI2NHprsAKjY/S/EGK4jpvhnlHX7i9BeR0CZEmp/H6Mngtj92Q6bpIT3OZJnCqatg0+SueckndkAStzgMVkz62qoGnPu9krNhcv3/Ee5/eIgn5z6Atpz1RjVZ974mrs7IOe/JA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com; Subject: Re: [PATCH] Config: use Mini-OS master for xen-unstable To: Juergen Gross , Wei Liu Cc: Andrew Cooper , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , xen-devel@lists.xenproject.org References: <20210831073039.7101-1-jgross@suse.com> From: Jan Beulich Message-ID: <6837d551-6473-e34d-c0ae-043fcaa9482b@suse.com> Date: Wed, 1 Sep 2021 10:59:57 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: <20210831073039.7101-1-jgross@suse.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PR2P264CA0011.FRAP264.PROD.OUTLOOK.COM (2603:10a6:101::23) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 52089834-26b8-43ea-c279-08d96d26e0bf X-MS-TrafficTypeDiagnostic: VI1PR04MB5166: X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: n5aI0wSi3lX2/9ONxciXPCNdhDDz5hbNZQtf6UjymPToUHsD0WtB1sZdN04jintrqhZUdTYrEz7+4ptFmVF9razZkyLRW/ed+GoJJAOTfdU44YtmWuSblsdCSIygKvDo9tnHVzZboKdXwdb2BVXXZqDveX5PfxFHOgTbGi5zxTXZcTLqjqXCWr3zOBfhXjG5FO2fnHfG/W84njpdX1esXurnl7/g7y6Iu07e2pfVcXpPWDzuv78yoCstVv2qmCiyB7e9P90JL8XMV7UtwI5q4eI84vlC2apjddXDQuG1LlDHu4Mxgp66ZlT8MWLWgk4ixdRhHZ5zEMp2taGOjJksD4SSVGeITYbpZtwcLRdxhfYv8iAj9As6URERpNvn0mylkL3ftCH8NrPMIpcSNS90ZvVhoKQKCNbwKyz+0ZA9xZzi/vl7RBvVUjWdO+Wua+9wgrkQZ5hYRuVL96muZuf2HtdYChph7gRHURHDQxE0bFq4+DUkpSt+VJH2SQjj03xWhvsGsnOwTO9+2K4iTaY5K4/qg9fBF+3rerchw6rxRMhvt7J+d8sQ3WxqCm4PHQsq2Ed01tsgRFbSeZTTgUxDZpnxnonlkxsML9vwfX5g3jSWdUi3mGkI7H7Te2bFYJ1KzEWTqjrR07G0qdU0Qruz/GDh2BzJTtmf9zX0bVYlREYnEBe17xM6MZNCcOlCVINfAPNIQmnVCjsUaQLMnl85MfRJOpVe9X3sqLHSNQAVYhQ= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(396003)(346002)(376002)(366004)(136003)(39860400002)(5660300002)(66946007)(54906003)(86362001)(2616005)(8936002)(66476007)(38100700002)(16576012)(31696002)(26005)(36756003)(4326008)(66556008)(53546011)(186003)(6486002)(956004)(31686004)(478600001)(83380400001)(2906002)(110136005)(316002)(8676002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VDB2em12OFFpdVNWYkVLek55MEFUWXBiY0phaHVOSUpjQXY0aEFJbXZuR3o3?= =?utf-8?B?dkptb2t5TDAzM2V4em9rWkQwY1dxN3FwZGVnNGV2VXZ4MFVxcDI3TG9NWmxj?= =?utf-8?B?eU1Ka2ZFcFZPMzlhUDJjSENDT09FQWRpNzRyR2E2MlVBWlk1cENBOEdyVW56?= =?utf-8?B?MkpkVzlkSE9ndHArQU45aDg5bmkwNkZvQmV6bXYyVWtaSDNDTEo0WDY2Ylln?= =?utf-8?B?UlE1dVpkSmFuejBDMytTK0pKclRwQmQ3R3V1MFF0U1ZCYWNHbVlLNGdNZDZJ?= =?utf-8?B?RFZ0T21KVUlhMjdRMER2cEVPUEN1a2JycWthMTY2bFdmRmhKWmJ3TG1MZkF2?= =?utf-8?B?WFIxaFhhWDU4cFVnUkFKaSt3dlZhUTVTVWFqR2ZLS1VxTFdSMkRzTjc2cHQ4?= =?utf-8?B?QnlBbHM2dkhVZHJIS3JhSzJ3MDBpVFZ2YzFETzFUZEwvQUJwaUZPMjlVaVo5?= =?utf-8?B?bFFSTGxMcWV4OGUva3R0Q0czVThSWkQ3QllWcVp5YVZJQmM5cUZiY3VzRVdq?= =?utf-8?B?dG9FeGNBMFJjY0FMTVhWVVpNaFNIYmlrc2NJZXNKRVNsQjJac2wzMTdDTnZV?= =?utf-8?B?Y1IreFpqcDU1UG5DR1FKTWZnZnZQQ2UyY1hTOXdwNlU4S0dXVXNyYTQ5TE44?= =?utf-8?B?N013OUwrUkN0eVNpVU1KNWsvVXRLYVYxY1VzcEhCNWQ2eHdTSGtIZHVTZk5N?= =?utf-8?B?S3hCcVpnUHFSNG9nY1VsOUx3ajlsS3l2WTRkQS9UUks1WG02ak1BODdrT01m?= =?utf-8?B?blFhQ3czRzhKdG1mK29LWWo4R2ZhdDhabmd6SW9HQlY3UHJvNjZNSU1PYy9S?= =?utf-8?B?UUU1cGdwZUU5MHJZYXJ2djJZdFIwZm5NWmV0ZGliL0hBZC9SangvTTJ4UU93?= =?utf-8?B?Q25FY29DMW1CV1FmVkZLeUozWlhYYjc3bnlhTlpkRGRKc0tGVy9WT3F6ekRC?= =?utf-8?B?T3p1Z1cvWGJEV1NRVEh6Zlg1VndLRXdFQTdOc0o1bVo0YXQ1Zm42THo1aUda?= =?utf-8?B?UTRqZW1uOTNLVGM5azJta3lTRTV5SkpoYm9iVnpqMUhETnhpYmErZVBFemFt?= =?utf-8?B?ZDZ4MmI5TTUxTHQ5NXFWcG9mVHdHYlo3aGcxVG54ZVppcEU4b00zSFRjOTVj?= =?utf-8?B?ejJoN0xOTTAwcVJoVG1iYTJLVG9xajRXWnFLQ1M3TWFwY3lXVkNaVWRnN3Ns?= =?utf-8?B?OFZkQW82ME5IL0lOUWVRVDFZTmdVUkI5bDUxMFBiL29ERW1kKzdkWUVvbXkw?= =?utf-8?B?aHl1UFFVK08yQTY0Z3duYzBmS2p0d1V5L2ZIZERwb29Ib3VsSG8yVjZoY05R?= =?utf-8?B?bVdrWm9tRXQzTmt1RUZxbUVwdWM4MkJsQm9qQVpGZTUyd3dSNnRFbk5NTHpa?= =?utf-8?B?OTlYZUpqb2h1d2VER2crTnorSFNGQzNYUnJzMXZ2RTdiQ0xMWjhRTVI4WVdB?= =?utf-8?B?TFo4WFpOOFZZbDhwdngwQisvakliK2ZoWm9iQzNnbEhsaDFDclR1MEE5TjAy?= =?utf-8?B?eWpXbEk4ektwd3ByWVBzdWdsRFpWbHdodVlXdWI4eXkxL1VYOElOK3pSZFBU?= =?utf-8?B?Y0pReDRXYi9DVTdzUFdvcHQvVXVEaVFjSWtzSUVTWmM1cnpPcHI2OUNYK0pV?= =?utf-8?B?NkhnT3BnQ0N5dVZ6OXZYYzQ5UDF0aktGOTFuN0hmQUlrTi94cmVTN3RkRlZp?= =?utf-8?B?TUp4SFRkS01Ydm82WnpaT0xHLzNScWhYVjNqdVR3QjgxMFJ2UHpRMnNRUVdC?= =?utf-8?Q?GS56lvII8Nm67IEzk+z1tIge/l3hgCgj4CLZdLf?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 52089834-26b8-43ea-c279-08d96d26e0bf X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Sep 2021 08:59:59.7743 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: HtS+A2rPT0pqBFluKaKUyD3nK26IxnMeQvVNQCjfY7O8h0+b6Qtv6eQXss7wlV672M7qpihj/5sGpTxJPVsHhQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5166 On 31.08.2021 09:30, Juergen Gross wrote: > In order to get Mini-OS master branch tested by OSStest, use it for > xen-unstable. > > Signed-off-by: Juergen Gross > --- > There are some Mini-OS patches pending, of which at least the Mini-OS > netfront fix should be committed as it will be required for qemu-stubdom > to work. > --- > Config.mk | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Config.mk b/Config.mk > index 4d723eec1d..d4e8ced104 100644 > --- a/Config.mk > +++ b/Config.mk > @@ -246,7 +246,7 @@ MINIOS_UPSTREAM_URL ?= git://xenbits.xen.org/mini-os.git > endif > OVMF_UPSTREAM_REVISION ?= b37cfdd2807181aed2fee1e17bd7ec1190db266a > QEMU_UPSTREAM_REVISION ?= master > -MINIOS_UPSTREAM_REVISION ?= 051b87bb9c19609976fb038f386920e1ce5454c5 > +MINIOS_UPSTREAM_REVISION ?= master I'm afraid this, effectively reverting 82c3d15c903a ("minios: Revert recent change and revert to working minios"), would set us up for the same problem again that was dealt with there. IOW you're re-proposing a change of yours (e013e8514389 ["config: use mini-os master for unstable"]) which was subsequently reverted, without spelling out what has since changed. Jan From xen-devel-bounces@lists.xenproject.org Wed Sep 01 09:31:35 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Sep 2021 09:31:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.176160.320644 (Exim 4.92) (envelope-from ) id 1mLMaN-0006eR-Vg; Wed, 01 Sep 2021 09:31:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 176160.320644; Wed, 01 Sep 2021 09:31:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLMaN-0006eK-QF; Wed, 01 Sep 2021 09:31:11 +0000 Received: by outflank-mailman (input) for mailman id 176160; Wed, 01 Sep 2021 09:31:10 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLMaM-000673-Ho for xen-devel@lists.xen.org; Wed, 01 Sep 2021 09:31:10 +0000 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id c4b943f9-c6d1-4fca-8114-98ddd83101fd; Wed, 01 Sep 2021 09:30:59 +0000 (UTC) Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLMa2-0006zy-LC; Wed, 01 Sep 2021 09:30:50 +0000 Received: from iwj by xenbits.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mLMa2-0006VB-JU; Wed, 01 Sep 2021 09:30:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c4b943f9-c6d1-4fca-8114-98ddd83101fd DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Date:Message-Id:Subject:CC:From:To:MIME-Version: Content-Transfer-Encoding:Content-Type; bh=0ePqXSIKBX48B2cK5m/t9DhA8yei6wa4P1bd3JfsXGo=; b=kYO0tI9pMZm8aDxEs1YWieGE2x IRgOiwDuDSuka3bNS2aX7mgC2LjKHfzVooAmUJCF8c0RTL+3zRsGfZUYv+/EUZPNyGcQQvGkuoJWK Vnqo0rBsKy4nyKJpJYeXw/SlCjvsnzuZmxb38YS4TVuEw8rbWwPjERCs+JkHvInS2pW8=; Content-Type: multipart/mixed; boundary="=separator"; charset="utf-8" Content-Transfer-Encoding: binary MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) To: xen-announce@lists.xen.org, xen-devel@lists.xen.org, xen-users@lists.xen.org, oss-security@lists.openwall.com From: Xen.org security team CC: Xen.org security team Subject: Xen Security Advisory 380 v3 (CVE-2021-28698) - long running loops in grant table handling Message-Id: Date: Wed, 01 Sep 2021 09:30:50 +0000 --=separator Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Xen Security Advisory CVE-2021-28698 / XSA-380 version 3 long running loops in grant table handling UPDATES IN VERSION 3 ==================== New bugfix patch on top of the prior set. ISSUE DESCRIPTION ================= In order to properly monitor resource use, Xen maintains information on the grant mappings a domain may create to map grants offered by other domains. In the process of carrying out certain actions, Xen would iterate over all such entries, including ones which aren't in use anymore and some which may have been created but never used. If the number of entries for a given domain is large enough, this iterating of the entire table may tie up a CPU for too long, starving other domains or causing issues in the hypervisor itself. Note that a domain may map its own grants, i.e. there is no need for multiple domains to be involved here. A pair of "cooperating" guests may, however, cause the effects to be more severe. IMPACT ====== Malicious or buggy guest kernels may be able to mount a Denial of Service (DoS) attack affecting the entire system. VULNERABLE SYSTEMS ================== All Xen versions from at least 3.2 onwards are vulnerable in principle. Systems running with default settings are generally believed to not be vulnerable. MITIGATION ========== The problem can be avoided by reducing the number of grant mappings Xen would allow guests to establish. For example, setting "gnttab_max_maptrack_frames=256" on the Xen command line (available from Xen 4.5 onwards) or "max_maptrack_frames=256" in the xl domain configurations (available from Xen 4.10 onwards) may be low enough for all hardware Xen is able to run on. Note that except for driver domains, guests don't normally have a need to establish grant mappings, i.e. they may be okay to run with "max_maptrack_frames=0" in their xl domain configurations. - From Xen 4.14 onwards it is also possible to alter the system wide upper bound of the number of grant mappings Xen would allow guests to establish by writing to the /params/gnttab_max_maptrack_frames hypervisor file system node. Note however that changing the value this way will only affect guests yet to be created on the respective host. CREDITS ======= This issue was discovered by Andrew Cooper of Citrix. RESOLUTION ========== Applying the appropriate pair of attached patches resolves this issue. Note that patches for released versions are generally prepared to apply to the stable branches, and may not apply cleanly to the most recent release tarball. Downstreams are encouraged to update to the tip of the stable branch before applying these patches. To address an issue observed with some compiler versions, another patch needs to be applied on top. This has been committed to the unstable tree (commit hash b6da9d0414d69c2682214ee3ecf9816fcac500d0) only so far. This patch is listed last below. xsa380/xsa380-[12].patch xen-unstable - Xen 4.15.x xsa380/xsa380-4.14-?.patch Xen 4.14.x xsa380/xsa380-4.13-?.patch Xen 4.13.x xsa380/xsa380-4.12-?.patch Xen 4.12.x xsa380/xsa380-4.11-?.patch Xen 4.11.x xsa380/xsa380-3.patch Xen 4.15.x - Xen 4.11.x $ sha256sum xsa380* xsa380*/* 3b1938277665c195f6822a1170c50a853efa6bc3dcd6b2b0b9bbb0849a57bbf6 xsa380.meta 65411a0fd05d534ed2238b259aa2877331ac0e79f2dda80b424f34fffcce108a xsa380/xsa380-1.patch e6cd6d345abaad38e10d6f680fe881e874e35a7295199e5430bacd209f0b7304 xsa380/xsa380-2.patch 1ead53a28dedb0a502a700d9ea933e89e385c1582f4790f558a11d0d39e9d374 xsa380/xsa380-3.patch f3b486aa99a75ab54f9e26e21a721a413f993b27dbc3e6f2fda976fe20ddbae3 xsa380/xsa380-4.11-1.patch 96a09c05ca87fe3590064ca6d269ca47b97c732401cb593ff1068ac91009f51a xsa380/xsa380-4.11-2.patch 496063cd4641258e1854a77f626cdd86c866c3ed8603bdc2ff9ab709008c84a7 xsa380/xsa380-4.12-1.patch d850e1263e89c7a718f2cddcfb639fe4a5095a1852fc35499ed16a4075d225e5 xsa380/xsa380-4.12-2.patch c23d34527a2ec68015ad78cd90365e4d80bce842ce01eeaa8cd2246021a55693 xsa380/xsa380-4.13-1.patch bd40ce749d02f343c79325488ac1348e1c9e88e698bbad351bdb0a0d3995f3e0 xsa380/xsa380-4.13-2.patch 9b06085f9a4b93c465563cd76fdc682ddb9dba968c214259425b234e7053a809 xsa380/xsa380-4.14-1.patch bf6b53880abd53b56226080d1a32839c7c8c459867104697cd76eeafc2ea382a xsa380/xsa380-4.14-2.patch $ DEPLOYMENT DURING EMBARGO ========================= Deployment of the patches and/or mitigations described above (or others which are substantially similar) is permitted during the embargo, even on public-facing systems with untrusted guest users and administrators. HOWEVER, care has to be taken to avoid restricting guests too much, as them suddenly being unable to map grants they used to be able to map may lead to re-discovery of the issue. But: Distribution of updated software is prohibited (except to other members of the predisclosure list). Predisclosure list members who wish to deploy significantly different patches and/or mitigations, please contact the Xen Project Security Team. (Note: this during-embargo deployment notice is retained in post-embargo publicly released Xen Project advisories, even though it is then no longer applicable. This is to enable the community to have oversight of the Xen Project Security Team's decisionmaking.) For more information about permissible uses of embargoed information, consult the Xen Project community's agreed Security Policy: http://www.xenproject.org/security-policy.html -----BEGIN PGP SIGNATURE----- iQFABAEBCAAqFiEEI+MiLBRfRHX6gGCng/4UyVfoK9kFAmEvSDUMHHBncEB4ZW4u b3JnAAoJEIP+FMlX6CvZfboH/jtTLKbkb/K4SPliIDSRym1+wx17Ho30F9IRfd7E ZdUBHfFLTEbZ/GvU+UkU914XeK49fCHZGylu2dcIRWgPmXFlqOtydFJny9a8sCjx 7/dLR1WXvhJ4eG8Hsma13uRzZuaF4JdXDp1M/QOr6aBHNTLBgMefbQNTAbFO0kzP 2xK3arGefi/eNa3GOEghrMlt2U/5r1h7PfLXBl69BETomOCOo5gyn6aQwqH/xKSY W2cmqN0hYLyQSA+jx6QuTknsvSLS6NWWPEk/xfs31Op0E/P3tga0u6hCbRvWzOmE AdISyyP8ogIBU4ekMn0H4yQoWKVgYctk3XAawBmogv+VJXI= =7wyB -----END PGP SIGNATURE----- --=separator Content-Type: application/octet-stream; name="xsa380.meta" Content-Disposition: attachment; filename="xsa380.meta" Content-Transfer-Encoding: base64 ewogICJYU0EiOiAzODAsCiAgIlN1cHBvcnRlZFZlcnNpb25zIjogWwogICAg Im1hc3RlciIsCiAgICAiNC4xNSIsCiAgICAiNC4xNCIsCiAgICAiNC4xMyIs CiAgICAiNC4xMiIsCiAgICAiNC4xMSIKICBdLAogICJUcmVlcyI6IFsKICAg ICJ4ZW4iCiAgXSwKICAiUmVjaXBlcyI6IHsKICAgICI0LjExIjogewogICAg ICAiUmVjaXBlcyI6IHsKICAgICAgICAieGVuIjogewogICAgICAgICAgIlN0 YWJsZVJlZiI6ICJlZjMyYzdhZmEyNzMxYjc1ODIyNmQ2ZTEwYTFlNDg5YjFh MTVmYzQxIiwKICAgICAgICAgICJQcmVyZXFzIjogWwogICAgICAgICAgICAz NzgsCiAgICAgICAgICAgIDM3OQogICAgICAgICAgXSwKICAgICAgICAgICJQ YXRjaGVzIjogWwogICAgICAgICAgICAieHNhMzgwL3hzYTM4MC00LjExLT8u cGF0Y2giCiAgICAgICAgICBdCiAgICAgICAgfQogICAgICB9CiAgICB9LAog ICAgIjQuMTIiOiB7CiAgICAgICJSZWNpcGVzIjogewogICAgICAgICJ4ZW4i OiB7CiAgICAgICAgICAiU3RhYmxlUmVmIjogImVhMjBlZWU5N2U5ZTA4NjEx MjdhODA3MGNjN2I5YWUzNTU3YjA5ZmIiLAogICAgICAgICAgIlByZXJlcXMi OiBbCiAgICAgICAgICAgIDM3OCwKICAgICAgICAgICAgMzc5CiAgICAgICAg ICBdLAogICAgICAgICAgIlBhdGNoZXMiOiBbCiAgICAgICAgICAgICJ4c2Ez ODAveHNhMzgwLTQuMTItPy5wYXRjaCIKICAgICAgICAgIF0KICAgICAgICB9 CiAgICAgIH0KICAgIH0sCiAgICAiNC4xMyI6IHsKICAgICAgIlJlY2lwZXMi OiB7CiAgICAgICAgInhlbiI6IHsKICAgICAgICAgICJTdGFibGVSZWYiOiAi MzJkNTgwOTAyYjk1OTAwMGQ3OWQ1MWRmZjAzYTM1NjA2NTNjNGZjYiIsCiAg ICAgICAgICAiUHJlcmVxcyI6IFsKICAgICAgICAgICAgMzc4LAogICAgICAg ICAgICAzNzkKICAgICAgICAgIF0sCiAgICAgICAgICAiUGF0Y2hlcyI6IFsK ICAgICAgICAgICAgInhzYTM4MC94c2EzODAtNC4xMy0/LnBhdGNoIgogICAg ICAgICAgXQogICAgICAgIH0KICAgICAgfQogICAgfSwKICAgICI0LjE0Ijog ewogICAgICAiUmVjaXBlcyI6IHsKICAgICAgICAieGVuIjogewogICAgICAg ICAgIlN0YWJsZVJlZiI6ICI0OTI5OWM0ODEzYjc4NDdkMjlkZjA3YmY3OTBm NTQ4OTA2MGYyYTljIiwKICAgICAgICAgICJQcmVyZXFzIjogWwogICAgICAg ICAgICAzNzgsCiAgICAgICAgICAgIDM3OQogICAgICAgICAgXSwKICAgICAg ICAgICJQYXRjaGVzIjogWwogICAgICAgICAgICAieHNhMzgwL3hzYTM4MC00 LjE0LT8ucGF0Y2giCiAgICAgICAgICBdCiAgICAgICAgfQogICAgICB9CiAg ICB9LAogICAgIjQuMTUiOiB7CiAgICAgICJSZWNpcGVzIjogewogICAgICAg ICJ4ZW4iOiB7CiAgICAgICAgICAiU3RhYmxlUmVmIjogImRiYTc3NDg5NmY3 ZGQ3NDc3M2MxNGQ1Mzc2NDNiN2Q3NDc3ZmVmY2QiLAogICAgICAgICAgIlBy ZXJlcXMiOiBbCiAgICAgICAgICAgIDM3OCwKICAgICAgICAgICAgMzc5CiAg ICAgICAgICBdLAogICAgICAgICAgIlBhdGNoZXMiOiBbCiAgICAgICAgICAg ICJ4c2EzODAveHNhMzgwLT8ucGF0Y2giCiAgICAgICAgICBdCiAgICAgICAg fQogICAgICB9CiAgICB9LAogICAgIm1hc3RlciI6IHsKICAgICAgIlJlY2lw ZXMiOiB7CiAgICAgICAgInhlbiI6IHsKICAgICAgICAgICJTdGFibGVSZWYi OiAiMjVkYTk0NTVmMWJiOGE2ZDMzMDM5NTc1YTdiMjhiZGZjNGUzZmNmZSIs CiAgICAgICAgICAiUHJlcmVxcyI6IFsKICAgICAgICAgICAgMzc4LAogICAg ICAgICAgICAzNzkKICAgICAgICAgIF0sCiAgICAgICAgICAiUGF0Y2hlcyI6 IFsKICAgICAgICAgICAgInhzYTM4MC94c2EzODAtPy5wYXRjaCIKICAgICAg ICAgIF0KICAgICAgICB9CiAgICAgIH0KICAgIH0KICB9Cn0= --=separator Content-Type: application/octet-stream; name="xsa380/xsa380-1.patch" Content-Disposition: attachment; filename="xsa380/xsa380-1.patch" Content-Transfer-Encoding: base64 RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0 OiBnbnR0YWI6IGFkZCBwcmVlbXB0aW9uIGNoZWNrIHRvIGdudHRhYl9yZWxl YXNlX21hcHBpbmdzKCkKCkEgZ3Vlc3QgbWF5IGRpZSB3aXRoIG1hbnkgZ3Jh bnQgbWFwcGluZ3Mgc3RpbGwgaW4gcGxhY2UsIG9yIHNpbXBseSB3aXRoCmEg bGFyZ2UgbWFwdHJhY2sgdGFibGUuIEl0ZXJhdGluZyB0aHJvdWdoIHRoaXMg bWF5IHRha2UgbW9yZSB0aW1lIHRoYW4KaXMgcmVhc29uYWJsZSB3aXRob3V0 IGludGVybWVkaWF0ZSBwcmVlbXB0aW9uICh0byBydW4gc29mdGlycXMgYW5k CnBlcmhhcHMgdGhlIHNjaGVkdWxlcikuCgpNb3ZlIHRoZSBpbnZvY2F0aW9u IG9mIHRoZSBmdW5jdGlvbiB0byB0aGUgc2VjdGlvbiB3aGVyZSBvdGhlcgpy ZXN0YXJ0YWJsZSBmdW5jdGlvbnMgZ2V0IGludm9rZWQsIGFuZCBoYXZlIHRo ZSBmdW5jdGlvbiBpdHNlbGYgY2hlY2sKZm9yIHByZWVtcHRpb24gZXZlcnkg b25jZSBpbiBhIHdoaWxlLiBIYXZlIGl0IGl0ZXJhdGUgdGhlIHRhYmxlCmJh Y2t3YXJkcywgc3VjaCB0aGF0IGRlY3JlYXNpbmcgdGhlIG1hcHRyYWNrIGxp bWl0IGlzIGFsbCBpdCB0YWtlcyB0bwpjb252ZXkgcmVzdGFydCBpbmZvcm1h dGlvbi4KCkluIGRvbWFpbl90ZWFyZG93bigpIGludHJvZHVjZSBQUk9HX25v bmUgc3VjaCB0aGF0IGluc2VydGluZyBhdCB0aGUKZnJvbnQgd2lsbCBiZSBl YXNpZXIgZ29pbmcgZm9yd2FyZC4KClRoaXMgaXMgcGFydCBvZiBDVkUtMjAy MS0yODY5OCAvIFhTQS0zODAuCgpSZXBvcnRlZC1ieTogQW5kcmV3IENvb3Bl ciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNvbT4KU2lnbmVkLW9mZi1ieTog SmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpSZXZpZXdlZC1ieTog SnVsaWVuIEdyYWxsIDxqZ3JhbGxAYW1hem9uLmNvbT4KLS0tCldoaWxlIEkg Y29uc2lkZXIgcmVtb3ZhbCBvZiB0aGUgZnJlZWluZyBvZiB0LT5tYXB0cmFj a1tpXSBmcm9tCmdyYW50X3RhYmxlX2Rlc3Ryb3koKSBhbiBpbnRlZ3JhbCBw YXJ0IG9mIHRoaXMgY2hhbmdlLCBhbHNvIGZyZWVpbmcKdC0+bWFwdHJhY2sg cmlnaHQgaW4gZ250dGFiX3JlbGVhc2VfbWFwcGluZ3MoKSB3b3VsZCBzZWVt IGxpa2UgYW4KdW5yZWxhdGVkIGNoYW5nZSB0byBtZSwgc28gSSdtIG5vdCBt b3ZpbmcgdGhhdCBvbmUgZm9yIG5vdy4gSWYgb3RoZXJzCnRoaW5rIGl0IHdv dWxkIGJldHRlciBiZSBtb3ZlZCwgSSdkIGJlIGhhcHB5IHRvIGRvIHNvLgoK V2hpbGUgaW4gcHJpbmNpcGxlIGl0IHdvdWxkIGJlIG5pY2UgdG8gYWxzbyBl bGltaW5hdGUgdGhlIG90aGVyIGxvb3BzCmZyb20gZ3JhbnRfdGFibGVfZGVz dHJveSgpICh3aGljaCBjYW4gYWxsIHRha2UgbG9uZyBhcyB3ZWxsIHByb3Zp ZGVkIGEKbGFyZ2UgZW5vdWdoIG1heF9ncmFudF9mcmFtZXMpLCAtPm1hcHRy YWNrW10gcmVhbGx5IGlzIHNwZWNpYWwgaW4gdGhhdAppdCBvbmx5IGdldHMg YWNjZXNzZWQgd2hlbiBwcm9jZXNzaW5nIHJlcXVlc3RzIGJ5IHRoZSBkb21h aW4gaXRzZWxmLiBUaGUKb3RoZXIgYXJyYXlzIG1heSBhbGwgY29udGludWUg dG8gYmUgYWNjZXNzZWQgYXMgcmVtb3RlIGRvbWFpbnMgZHJvcCB1c2VzCm9m IGdyYW50cyBieSB0aGUgZHlpbmcgZG9tYWluLgotLS0KdjM6IEFkZCBjb21t ZW50Lgp2MjogTW92ZSBnbnR0YWJfcmVsZWFzZV9tYXBwaW5ncygpIGludm9j YXRpb24gaW50byBkb21haW5fdGVhcmRvd24oKS4KICAgIERvbid0IGNyYXNo IHdoZW4gY2xlYW5pbmcgdXAgZG9tYWluIHdpdGhvdXQgbWFwdHJhY2sgdGFi bGUuIEV4dGVuZAogICAgY29tbWVudCBuZXh0IHRvIG1hcHRyYWNrX2xpbWl0 LgoKLS0tIGEveGVuL2NvbW1vbi9kb21haW4uYworKysgYi94ZW4vY29tbW9u L2RvbWFpbi5jCkBAIC00MTIsMTEgKzQxMiwxOCBAQCBzdGF0aWMgaW50IGRv bWFpbl90ZWFyZG93bihzdHJ1Y3QgZG9tYWluCiAgICAgICAgIHYgPSBkLT50 ZWFyZG93bi52Y3B1CiAKICAgICAgICAgZW51bSB7Ci0gICAgICAgICAgICBQ Uk9HX3ZjcHVfdGVhcmRvd24gPSAxLAorICAgICAgICAgICAgUFJPR19ub25l LAorICAgICAgICAgICAgUFJPR19nbnR0YWJfbWFwcGluZ3MsCisgICAgICAg ICAgICBQUk9HX3ZjcHVfdGVhcmRvd24sCiAgICAgICAgICAgICBQUk9HX2Rv bmUsCiAgICAgICAgIH07CiAKLSAgICBjYXNlIDA6CisgICAgY2FzZSBQUk9H X25vbmU6CisgICAgICAgIHJjID0gZ250dGFiX3JlbGVhc2VfbWFwcGluZ3Mo ZCk7CisgICAgICAgIGlmICggcmMgKQorICAgICAgICAgICAgcmV0dXJuIHJj OworCisgICAgUFJPR1JFU1MoZ250dGFiX21hcHBpbmdzKToKICAgICAgICAg Zm9yX2VhY2hfdmNwdSAoIGQsIHYgKQogICAgICAgICB7CiAgICAgICAgICAg ICBQUk9HUkVTU19WQ1BVKHRlYXJkb3duKTsKQEAgLTkwOCw3ICs5MTUsNiBA QCBpbnQgZG9tYWluX2tpbGwoc3RydWN0IGRvbWFpbiAqZCkKICAgICAgICAg ICAgIHJldHVybiBkb21haW5fa2lsbChkKTsKICAgICAgICAgZC0+aXNfZHlp bmcgPSBET01EWUlOR19keWluZzsKICAgICAgICAgYXJnb19kZXN0cm95KGQp OwotICAgICAgICBnbnR0YWJfcmVsZWFzZV9tYXBwaW5ncyhkKTsKICAgICAg ICAgdm51bWFfZGVzdHJveShkLT52bnVtYSk7CiAgICAgICAgIGRvbWFpbl9z ZXRfb3V0c3RhbmRpbmdfcGFnZXMoZCwgMCk7CiAgICAgICAgIC8qIGZhbGx0 aHJvdWdoICovCi0tLSBhL3hlbi9jb21tb24vZ3JhbnRfdGFibGUuYworKysg Yi94ZW4vY29tbW9uL2dyYW50X3RhYmxlLmMKQEAgLTY0LDcgKzY0LDEzIEBA IHN0cnVjdCBncmFudF90YWJsZSB7CiAgICAgdW5zaWduZWQgaW50ICAgICAg ICAgIG5yX2dyYW50X2ZyYW1lczsKICAgICAvKiBOdW1iZXIgb2YgZ3JhbnQg c3RhdHVzIGZyYW1lcyBzaGFyZWQgd2l0aCBndWVzdCAoZm9yIHZlcnNpb24g MikgKi8KICAgICB1bnNpZ25lZCBpbnQgICAgICAgICAgbnJfc3RhdHVzX2Zy YW1lczsKLSAgICAvKiBOdW1iZXIgb2YgYXZhaWxhYmxlIG1hcHRyYWNrIGVu dHJpZXMuICovCisgICAgLyoKKyAgICAgKiBOdW1iZXIgb2YgYXZhaWxhYmxl IG1hcHRyYWNrIGVudHJpZXMuICBGb3IgY2xlYW51cCBwdXJwb3NlcyBpdCBp cworICAgICAqIGltcG9ydGFudCB0byByZWFsaXplIHRoYXQgdGhpcyBmaWVs ZCBhbmQgQG1hcHRyYWNrIGZ1cnRoZXIgZG93biB3aWxsCisgICAgICogb25s eSBldmVyIGJlIGFjY2Vzc2VkIGJ5IHRoZSBsb2NhbCBkb21haW4uICBUaHVz IGl0IGlzIG9rYXkgdG8gY2xlYW4KKyAgICAgKiB1cCBlYXJseSwgYW5kIHRv IHNocmluayB0aGUgbGltaXQgZm9yIHRoZSBwdXJwb3NlIG9mIHRyYWNraW5n IGNsZWFudXAKKyAgICAgKiBwcm9ncmVzcy4KKyAgICAgKi8KICAgICB1bnNp Z25lZCBpbnQgICAgICAgICAgbWFwdHJhY2tfbGltaXQ7CiAgICAgLyogU2hh cmVkIGdyYW50IHRhYmxlIChzZWUgaW5jbHVkZS9wdWJsaWMvZ3JhbnRfdGFi bGUuaCkuICovCiAgICAgdW5pb24gewpAQCAtMzY3OSw5ICszNjg1LDcgQEAg ZG9fZ3JhbnRfdGFibGVfb3AoCiAjaW5jbHVkZSAiY29tcGF0L2dyYW50X3Rh YmxlLmMiCiAjZW5kaWYKIAotdm9pZAotZ250dGFiX3JlbGVhc2VfbWFwcGlu Z3MoCi0gICAgc3RydWN0IGRvbWFpbiAqZCkKK2ludCBnbnR0YWJfcmVsZWFz ZV9tYXBwaW5ncyhzdHJ1Y3QgZG9tYWluICpkKQogewogICAgIHN0cnVjdCBn cmFudF90YWJsZSAgICpndCA9IGQtPmdyYW50X3RhYmxlLCAqcmd0OwogICAg IHN0cnVjdCBncmFudF9tYXBwaW5nICptYXA7CkBAIC0zNjk1LDggKzM2OTks MzIgQEAgZ250dGFiX3JlbGVhc2VfbWFwcGluZ3MoCiAKICAgICBCVUdfT04o IWQtPmlzX2R5aW5nKTsKIAotICAgIGZvciAoIGhhbmRsZSA9IDA7IGhhbmRs ZSA8IGd0LT5tYXB0cmFja19saW1pdDsgaGFuZGxlKysgKQorICAgIGlmICgg IWd0IHx8ICFndC0+bWFwdHJhY2sgKQorICAgICAgICByZXR1cm4gMDsKKwor ICAgIGZvciAoIGhhbmRsZSA9IGd0LT5tYXB0cmFja19saW1pdDsgaGFuZGxl OyApCiAgICAgeworICAgICAgICAvKgorICAgICAgICAgKiBEZWFsIHdpdGgg ZnVsbCBwYWdlcyBzdWNoIHRoYXQgdGhlaXIgZnJlZWluZyAoaW4gdGhlIGJv ZHkgb2YgdGhlCisgICAgICAgICAqIGlmKCkpIHJlbWFpbnMgc2ltcGxlLgor ICAgICAgICAgKi8KKyAgICAgICAgaWYgKCBoYW5kbGUgPCBndC0+bWFwdHJh Y2tfbGltaXQgJiYgIShoYW5kbGUgJSBNQVBUUkFDS19QRVJfUEFHRSkgKQor ICAgICAgICB7CisgICAgICAgICAgICAvKgorICAgICAgICAgICAgICogQ2hh bmdpbmcgbWFwdHJhY2tfbGltaXQgYWx0ZXJzIG5yX21hcHRyYWNrX2ZyYW1l cygpJ2VzIHJldHVybgorICAgICAgICAgICAgICogdmFsdWUuIEZyZWUgdGhl IHRoZW4gZXhjZXNzIHRyYWlsaW5nIHBhZ2UgcmlnaHQgaGVyZSwgcmF0aGVy CisgICAgICAgICAgICAgKiB0aGFuIGxlYXZpbmcgaXQgdG8gZ3JhbnRfdGFi bGVfZGVzdHJveSgpIChhbmQgaW4gdHVybiByZXF1aXJpbmcKKyAgICAgICAg ICAgICAqIHRvIGxlYXZlIGd0LT5tYXB0cmFja19saW1pdCB1bmFsdGVyZWQp LgorICAgICAgICAgICAgICovCisgICAgICAgICAgICBndC0+bWFwdHJhY2tf bGltaXQgPSBoYW5kbGU7CisgICAgICAgICAgICBGUkVFX1hFTkhFQVBfUEFH RShndC0+bWFwdHJhY2tbbnJfbWFwdHJhY2tfZnJhbWVzKGd0KV0pOworCisg ICAgICAgICAgICBpZiAoIGh5cGVyY2FsbF9wcmVlbXB0X2NoZWNrKCkgKQor ICAgICAgICAgICAgICAgIHJldHVybiAtRVJFU1RBUlQ7CisgICAgICAgIH0K KworICAgICAgICAtLWhhbmRsZTsKKwogICAgICAgICBtYXAgPSAmbWFwdHJh Y2tfZW50cnkoZ3QsIGhhbmRsZSk7CiAgICAgICAgIGlmICggIShtYXAtPmZs YWdzICYgKEdOVE1BUF9kZXZpY2VfbWFwfEdOVE1BUF9ob3N0X21hcCkpICkK ICAgICAgICAgICAgIGNvbnRpbnVlOwpAQCAtMzc4MCw2ICszODA4LDExIEBA IGdudHRhYl9yZWxlYXNlX21hcHBpbmdzKAogCiAgICAgICAgIG1hcC0+Zmxh Z3MgPSAwOwogICAgIH0KKworICAgIGd0LT5tYXB0cmFja19saW1pdCA9IDA7 CisgICAgRlJFRV9YRU5IRUFQX1BBR0UoZ3QtPm1hcHRyYWNrWzBdKTsKKwor ICAgIHJldHVybiAwOwogfQogCiB2b2lkIGdyYW50X3RhYmxlX3dhcm5fYWN0 aXZlX2dyYW50cyhzdHJ1Y3QgZG9tYWluICpkKQpAQCAtMzg0Myw4ICszODc2 LDcgQEAgZ3JhbnRfdGFibGVfZGVzdHJveSgKICAgICAgICAgZnJlZV94ZW5o ZWFwX3BhZ2UodC0+c2hhcmVkX3Jhd1tpXSk7CiAgICAgeGZyZWUodC0+c2hh cmVkX3Jhdyk7CiAKLSAgICBmb3IgKCBpID0gMDsgaSA8IG5yX21hcHRyYWNr X2ZyYW1lcyh0KTsgaSsrICkKLSAgICAgICAgZnJlZV94ZW5oZWFwX3BhZ2Uo dC0+bWFwdHJhY2tbaV0pOworICAgIEFTU0VSVCghdC0+bWFwdHJhY2tfbGlt aXQpOwogICAgIHZmcmVlKHQtPm1hcHRyYWNrKTsKIAogICAgIGZvciAoIGkg PSAwOyBpIDwgbnJfYWN0aXZlX2dyYW50X2ZyYW1lcyh0KTsgaSsrICkKLS0t IGEveGVuL2luY2x1ZGUveGVuL2dyYW50X3RhYmxlLmgKKysrIGIveGVuL2lu Y2x1ZGUveGVuL2dyYW50X3RhYmxlLmgKQEAgLTQ3LDkgKzQ3LDcgQEAgdm9p ZCBncmFudF90YWJsZV9pbml0X3ZjcHUoc3RydWN0IHZjcHUgKgogdm9pZCBn cmFudF90YWJsZV93YXJuX2FjdGl2ZV9ncmFudHMoc3RydWN0IGRvbWFpbiAq ZCk7CiAKIC8qIERvbWFpbiBkZWF0aCByZWxlYXNlIG9mIGdyYW50ZWQgbWFw cGluZ3Mgb2Ygb3RoZXIgZG9tYWlucycgbWVtb3J5LiAqLwotdm9pZAotZ250 dGFiX3JlbGVhc2VfbWFwcGluZ3MoCi0gICAgc3RydWN0IGRvbWFpbiAqZCk7 CitpbnQgZ250dGFiX3JlbGVhc2VfbWFwcGluZ3Moc3RydWN0IGRvbWFpbiAq ZCk7CiAKIGludCBtZW1fc2hhcmluZ19ncmVmX3RvX2dmbihzdHJ1Y3QgZ3Jh bnRfdGFibGUgKmd0LCBncmFudF9yZWZfdCByZWYsCiAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgZ2ZuX3QgKmdmbiwgdWludDE2X3QgKnN0YXR1cyk7 CkBAIC04MCw3ICs3OCw3IEBAIHN0YXRpYyBpbmxpbmUgdm9pZCBncmFudF90 YWJsZV9pbml0X3ZjcHUKIAogc3RhdGljIGlubGluZSB2b2lkIGdyYW50X3Rh YmxlX3dhcm5fYWN0aXZlX2dyYW50cyhzdHJ1Y3QgZG9tYWluICpkKSB7fQog Ci1zdGF0aWMgaW5saW5lIHZvaWQgZ250dGFiX3JlbGVhc2VfbWFwcGluZ3Mo c3RydWN0IGRvbWFpbiAqZCkge30KK3N0YXRpYyBpbmxpbmUgaW50IGdudHRh Yl9yZWxlYXNlX21hcHBpbmdzKHN0cnVjdCBkb21haW4gKmQpIHsgcmV0dXJu IDA7IH0KIAogc3RhdGljIGlubGluZSBpbnQgbWVtX3NoYXJpbmdfZ3JlZl90 b19nZm4oc3RydWN0IGdyYW50X3RhYmxlICpndCwKICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIGdyYW50X3JlZl90IHJlZiwK --=separator Content-Type: application/octet-stream; name="xsa380/xsa380-2.patch" Content-Disposition: attachment; filename="xsa380/xsa380-2.patch" Content-Transfer-Encoding: base64 RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0 OiBnbnR0YWI6IHJlcGxhY2UgbWFwa2luZCgpCgptYXBraW5kKCkgZG9lc24n dCBzY2FsZSB2ZXJ5IHdlbGwgd2l0aCBsYXJnZXIgbWFwdHJhY2sgZW50cnkg Y291bnRzLAp1c2luZyBhIGJydXRlIGZvcmNlIGxpbmVhciBzZWFyY2ggdGhy b3VnaCBhbGwgZW50cmllcywgd2l0aCB0aGUgb25seQpvcHRpb24gb2YgYW4g ZWFybHkgbG9vcCBleGl0IGlmIGEgbWF0Y2hpbmcgd3JpdGFibGUgZW50cnkg d2FzIGZvdW5kLgpJbnRyb2R1Y2UgYSByYWRpeCB0cmVlIGFsb25nc2lkZSB0 aGUgbWFpbiBtYXB0cmFjayB0YWJsZSwgdGh1cwphbGxvd2luZyBtdWNoIGZh c3RlciBNRk4tYmFzZWQgbG9va3VwLiBUbyBhdm9pZCB0aGUgbmVlZCB0byBh Y3R1YWxseQphbGxvY2F0ZSBzcGFjZSBmb3IgdGhlIGluZGl2aWR1YWwgbm9k ZXMsIGVuY29kZSB0aGUgdHdvIGNvdW50ZXJzIGluIHRoZQpub2RlIHBvaW50 ZXJzIHRoZW1zZWx2ZXMsIHRodXMgbGltaXRpbmcgdGhlIG51bWJlciBvZiBw ZXJtaXR0ZWQKc2ltdWx0YW5lb3VzIHIvbyBhbmQgci93IG1hcHBpbmdzIG9m IHRoZSBzYW1lIE1GTiB0byAywrPCuS0xICg2NC1iaXQpIC8KMsK54oG1LTEg KDMyLWJpdCkgZWFjaC4KClRvIGF2b2lkIGVuZm9yY2luZyBhbiB1bm5lY2Vz c2FyaWx5IGxvdyBib3VuZCBvbiB0aGUgbnVtYmVyIG9mCnNpbXVsdGFuZW91 cyBtYXBwaW5ncyBvZiBhIHNpbmdsZSBNRk4sIGludHJvZHVjZQpyYWRpeF90 cmVlX3t1bG9uZ190b19wdHIscHRyX3RvX3Vsb25nfSBwYXJhbGxlbGluZwpy YWRpeF90cmVlX3tpbnRfdG9fcHRyLHB0cl90b19pbnR9LgoKQXMgYSBjb25z ZXF1ZW5jZSBsb2NraW5nIGNoYW5nZXMgYXJlIGFsc28gYXBwbGljYWJsZTog V2l0aCB0aGVyZSBubwpsb25nZXIgYmVpbmcgYW55IGluc3BlY3Rpb24gb2Yg dGhlIHJlbW90ZSBkb21haW4ncyBhY3RpdmUgZW50cmllcywKdGhlcmUncyBh bHNvIG5vIG5lZWQgYW55bW9yZSB0byBob2xkIHRoZSByZW1vdGUgZG9tYWlu J3MgZ3JhbnQgdGFibGUKbG9jay4gQW5kIHNpbmNlIHdlJ3JlIG5vIGxvbmdl ciBpdGVyYXRpbmcgb3ZlciB0aGUgbG9jYWwgZG9tYWluJ3MgbWFwCnRyYWNr IHRhYmxlLCB0aGUgbG9jayBpbiBtYXBfZ3JhbnRfcmVmKCkgY2FuIGFsc28g YmUgZHJvcHBlZCBiZWZvcmUgdGhlCm5ldyBtYXB0cmFjayBlbnRyeSBhY3R1 YWxseSBnZXRzIHBvcHVsYXRlZC4KCkFzIGEgbmljZSBzaWRlIGVmZmVjdCB0 aGlzIGFsc28gcmVkdWNlcyB0aGUgbnVtYmVyIG9mIElPTU1VIG9wZXJhdGlv bnMKaW4gdW5tYXBfY29tbW9uKCk6IFByZXZpb3VzbHkgd2Ugd291bGQgaGF2 ZSAiZXN0YWJsaXNoZWQiIGEgcmVhZGFibGUKbWFwcGluZyB3aGVuZXZlciB3 ZSBkaWRuJ3QgZmluZCBhIHdyaXRhYmxlIGVudHJ5IGFueW1vcmUgKHlldCwg b2YKY291cnNlLCBhdCBsZWFzdCBvbmUgcmVhZGFibGUgb25lKS4gQnV0IHdl IG9ubHkgbmVlZCB0byBkbyB0aGlzIGlmIHdlCmFjdHVhbGx5IGRyb3BwZWQg dGhlIGxhc3Qgd3JpdGFibGUgZW50cnksIG5vdCBpZiB0aGVyZSB3ZXJlIG5v bmUgYWxyZWFkeQpiZWZvcmUuCgpUaGlzIGlzIHBhcnQgb2YgQ1ZFLTIwMjEt Mjg2OTggLyBYU0EtMzgwLgoKU2lnbmVkLW9mZi1ieTogSmFuIEJldWxpY2gg PGpiZXVsaWNoQHN1c2UuY29tPgpSZXZpZXdlZC1ieTogSnVsaWVuIEdyYWxs IDxqZ3JhbGxAYW1hem9uLmNvbT4KLS0tCkkgaG9wZSB0aGF0IGxpbWl0aW5n IHRoZSBtYXAgY291bnQgdG8gMzJrIG9uIEFybTMyIGlzIGdvb2QgZW5vdWdo LiBJCmFsc28gaG9wZSBpdCBpcyBvdXQgb2YgcXVlc3Rpb24gdGhhdCAyRyBv ZiBtYXBwaW5ncyBhcmUgZW5vdWdoIG9uIDY0LWJpdAphcmNoaXRlY3R1cmVz LgoKSSdtIHVzaW5nIHRoZSBncmFudCB0YWJsZSBsb2NrIGZvciBzeW5jaHJv bml6YXRpb24gdG8gbGltaXQgZGlmZmVyZW5jZXMKaW4gYmVoYXZpb3IgdG8g cHJpb3IgY29kZS4gSSB0aGluayBpbiBwcmluY2lwbGUgdGhlIG1hcHRyYWNr IGxvY2sgY291bGQKYmUgdXNlZCBlcXVhbGx5IHdlbGwuCgpTaG91bGRuJ3Qg SU9NTVUgaW5zZXJ0aW9ucyBiZSBsaW1pdGVkIGFueXdheSB0byBHTlRNQVBf ZGV2aWNlX21hcApyZXF1ZXN0cz8gVGhpcyB3b3VsZCBmdXJ0aGVyIHNhdmUg b24gdGhlIG51bWJlciBvZiByYWRpeCB0cmVlIG5vZGVzIGluCm5lZWQgb2Yg bWFpbnRhaW5pbmcuCgpJJ20gaGVzaXRhbnQgdG8gaW50cm9kdWNlIEdOVFNU XyogaW4gYSBzZWN1cml0eSBwYXRjaCwgYnV0IGJlaW5nIGFibGUgdG8KdGVs bCBhbGxvY2F0aW9uIGZhaWx1cmUgb3IgY291bnRlciBvdmVyZmxvdyBmcm9t IG90aGVyIGVycm9ycyBtaWdodCBiZQp3b3J0aHdoaWxlLgoKSSBkb24ndCB0 aGluayBhZGRpbmcgYW55dGhpbmcgdG8gZ250dGFiX3VzYWdlX3ByaW50KCkg aXMgdXNlZnVsOgpyYWRpeF90cmVlX2dhbmdfbG9va3VwKCkgcmVxdWlyZXMg bm9kZXMgdG8gcmVjb3JkIHRoZWlyIG93biBpbmRleGVzIGludG8KdGhlIHRy ZWUsIHdoaWNoIHdlIGRvbid0IGRvIHRvIHNhdmUgc3BhY2UuIFlldCB3aXRo b3V0IGluZGV4ZXMgcHJpbnRpbmcKbm9kZSBjb250ZW50cyBpc24ndCB2ZXJ5 IHVzZWZ1bC4gUGx1cyB0aGVyZSdzIGFsc28gbm8gcHJpbnRpbmcgb2YgdGhl Cm1haW4gbWFwdHJhY2sgdGFibGUgY29udGVudHMuCi0tLQp2MzogQ2hlY2sg Zm9yIHJhZGl4X3RyZWVfbG9va3VwX3Nsb3QoKSByZXR1cm5pbmcgTlVMTC4g Q29udmVydCAtRUVYSVNUCiAgICB0byAtRUJVU1kuIEFkZCBjb21tZW50cy4g UmUtYmFzZSBvdmVyIGNvbW1lbnQgYWRkaXRpb24gaW4gcGF0Y2ggMS4KdjI6 IE5ldy4KCi0tLSBhL3hlbi9jb21tb24vZ3JhbnRfdGFibGUuYworKysgYi94 ZW4vY29tbW9uL2dyYW50X3RhYmxlLmMKQEAgLTM3LDYgKzM3LDcgQEAKICNp bmNsdWRlIDx4ZW4vaW9tbXUuaD4KICNpbmNsdWRlIDx4ZW4vcGFnaW5nLmg+ CiAjaW5jbHVkZSA8eGVuL2tleWhhbmRsZXIuaD4KKyNpbmNsdWRlIDx4ZW4v cmFkaXgtdHJlZS5oPgogI2luY2x1ZGUgPHhlbi92bWFwLmg+CiAjaW5jbHVk ZSA8eGVuL25vc3BlYy5oPgogI2luY2x1ZGUgPHhzbS94c20uaD4KQEAgLTgy LDggKzgzLDEzIEBAIHN0cnVjdCBncmFudF90YWJsZSB7CiAgICAgZ3JhbnRf c3RhdHVzX3QgICAgICAgKipzdGF0dXM7CiAgICAgLyogQWN0aXZlIGdyYW50 IHRhYmxlLiAqLwogICAgIHN0cnVjdCBhY3RpdmVfZ3JhbnRfZW50cnkgKiph Y3RpdmU7Ci0gICAgLyogTWFwcGluZyB0cmFja2luZyB0YWJsZSBwZXIgdmNw dS4gKi8KKyAgICAvKiBIYW5kbGUtaW5kZXhlZCB0cmFja2luZyB0YWJsZSBv ZiBtYXBwaW5ncy4gKi8KICAgICBzdHJ1Y3QgZ3JhbnRfbWFwcGluZyAqKm1h cHRyYWNrOworICAgIC8qCisgICAgICogTUZOLWluZGV4ZWQgdHJhY2tpbmcg dHJlZSBvZiBtYXBwaW5ncywgaWYgbmVlZGVkLiAgTm90ZSB0aGF0IHRoaXMg aXMKKyAgICAgKiBwcm90ZWN0ZWQgYnkgQGxvY2ssIG5vdCBAbWFwdHJhY2tf bG9jay4KKyAgICAgKi8KKyAgICBzdHJ1Y3QgcmFkaXhfdHJlZV9yb290IG1h cHRyYWNrX3RyZWU7CiAKICAgICAvKiBEb21haW4gdG8gd2hpY2ggdGhpcyBz dHJ1Y3QgZ3JhbnRfdGFibGUgYmVsb25ncy4gKi8KICAgICBjb25zdCBzdHJ1 Y3QgZG9tYWluICpkb21haW47CkBAIC01MTYsMzQgKzUyMiw2IEBAIHN0YXRp YyBpbnQgZ2V0X3BhZ2VkX2ZyYW1lKHVuc2lnbmVkIGxvbmcKICAgICByZXR1 cm4gR05UU1Rfb2theTsKIH0KIAotc3RhdGljIGlubGluZSB2b2lkCi1kb3Vi bGVfZ3RfbG9jayhzdHJ1Y3QgZ3JhbnRfdGFibGUgKmxndCwgc3RydWN0IGdy YW50X3RhYmxlICpyZ3QpCi17Ci0gICAgLyoKLSAgICAgKiBTZWUgbWFwa2lu ZCgpIGZvciB3aHkgdGhlIHdyaXRlIGxvY2sgaXMgYWxzbyByZXF1aXJlZCBm b3IgdGhlCi0gICAgICogcmVtb3RlIGRvbWFpbi4KLSAgICAgKi8KLSAgICBp ZiAoIGxndCA8IHJndCApCi0gICAgewotICAgICAgICBncmFudF93cml0ZV9s b2NrKGxndCk7Ci0gICAgICAgIGdyYW50X3dyaXRlX2xvY2socmd0KTsKLSAg ICB9Ci0gICAgZWxzZQotICAgIHsKLSAgICAgICAgaWYgKCBsZ3QgIT0gcmd0 ICkKLSAgICAgICAgICAgIGdyYW50X3dyaXRlX2xvY2socmd0KTsKLSAgICAg ICAgZ3JhbnRfd3JpdGVfbG9jayhsZ3QpOwotICAgIH0KLX0KLQotc3RhdGlj IGlubGluZSB2b2lkCi1kb3VibGVfZ3RfdW5sb2NrKHN0cnVjdCBncmFudF90 YWJsZSAqbGd0LCBzdHJ1Y3QgZ3JhbnRfdGFibGUgKnJndCkKLXsKLSAgICBn cmFudF93cml0ZV91bmxvY2sobGd0KTsKLSAgICBpZiAoIGxndCAhPSByZ3Qg KQotICAgICAgICBncmFudF93cml0ZV91bmxvY2socmd0KTsKLX0KLQogI2Rl ZmluZSBJTlZBTElEX01BUFRSQUNLX0hBTkRMRSBVSU5UX01BWAogCiBzdGF0 aWMgaW5saW5lIGdyYW50X2hhbmRsZV90CkBAIC05NzAsNDEgKzk0OCwxNyBA QCBzdGF0aWMgc3RydWN0IGFjdGl2ZV9ncmFudF9lbnRyeSAqZ3JhbnRfCiAg ICAgcmV0dXJuIEVSUl9QVFIoLUVJTlZBTCk7CiB9CiAKLSNkZWZpbmUgTUFQ S0lORF9SRUFEIDEKLSNkZWZpbmUgTUFQS0lORF9XUklURSAyCi1zdGF0aWMg dW5zaWduZWQgaW50IG1hcGtpbmQoCi0gICAgc3RydWN0IGdyYW50X3RhYmxl ICpsZ3QsIGNvbnN0IHN0cnVjdCBkb21haW4gKnJkLCBtZm5fdCBtZm4pCi17 Ci0gICAgc3RydWN0IGdyYW50X21hcHBpbmcgKm1hcDsKLSAgICBncmFudF9o YW5kbGVfdCBoYW5kbGUsIGxpbWl0ID0gbGd0LT5tYXB0cmFja19saW1pdDsK LSAgICB1bnNpZ25lZCBpbnQga2luZCA9IDA7Ci0KLSAgICAvKgotICAgICAq IE11c3QgaGF2ZSB0aGUgbG9jYWwgZG9tYWluJ3MgZ3JhbnQgdGFibGUgd3Jp dGUgbG9jayB3aGVuCi0gICAgICogaXRlcmF0aW5nIG92ZXIgaXRzIG1hcHRy YWNrIGVudHJpZXMuCi0gICAgICovCi0gICAgQVNTRVJUKHBlcmNwdV9yd19p c193cml0ZV9sb2NrZWQoJmxndC0+bG9jaykpOwotICAgIC8qCi0gICAgICog TXVzdCBoYXZlIHRoZSByZW1vdGUgZG9tYWluJ3MgZ3JhbnQgdGFibGUgd3Jp dGUgbG9jayB3aGlsZQotICAgICAqIGNvdW50aW5nIGl0cyBhY3RpdmUgZW50 cmllcy4KLSAgICAgKi8KLSAgICBBU1NFUlQocGVyY3B1X3J3X2lzX3dyaXRl X2xvY2tlZCgmcmQtPmdyYW50X3RhYmxlLT5sb2NrKSk7Ci0KLSAgICBzbXBf cm1iKCk7Ci0KLSAgICBmb3IgKCBoYW5kbGUgPSAwOyAhKGtpbmQgJiBNQVBL SU5EX1dSSVRFKSAmJiBoYW5kbGUgPCBsaW1pdDsgaGFuZGxlKysgKQotICAg IHsKLSAgICAgICAgbWFwID0gJm1hcHRyYWNrX2VudHJ5KGxndCwgaGFuZGxl KTsKLSAgICAgICAgaWYgKCAhKG1hcC0+ZmxhZ3MgJiAoR05UTUFQX2Rldmlj ZV9tYXB8R05UTUFQX2hvc3RfbWFwKSkgfHwKLSAgICAgICAgICAgICBtYXAt PmRvbWlkICE9IHJkLT5kb21haW5faWQgKQotICAgICAgICAgICAgY29udGlu dWU7Ci0gICAgICAgIGlmICggbWZuX2VxKF9hY3RpdmVfZW50cnkocmQtPmdy YW50X3RhYmxlLCBtYXAtPnJlZikubWZuLCBtZm4pICkKLSAgICAgICAgICAg IGtpbmQgfD0gbWFwLT5mbGFncyAmIEdOVE1BUF9yZWFkb25seSA/Ci0gICAg ICAgICAgICAgICAgICAgIE1BUEtJTkRfUkVBRCA6IE1BUEtJTkRfV1JJVEU7 Ci0gICAgfQotCi0gICAgcmV0dXJuIGtpbmQ7Ci19Cit1bmlvbiBtYXB0cmFj a19ub2RlIHsKKyAgICBzdHJ1Y3QgeworICAgICAgICAvKiBSYWRpeCB0cmVl IHNsb3QgcG9pbnRlcnMgdXNlIHR3byBvZiB0aGUgYml0cy4gKi8KKyNpZmRl ZiBfX0JJR19FTkRJQU5fQklURklFTEQKKyAgICAgICAgdW5zaWduZWQgbG9u ZyAgICA6IDI7CisjZW5kaWYKKyAgICAgICAgdW5zaWduZWQgbG9uZyByZCA6 IEJJVFNfUEVSX0xPTkcgLyAyIC0gMTsKKyAgICAgICAgdW5zaWduZWQgbG9u ZyB3ciA6IEJJVFNfUEVSX0xPTkcgLyAyIC0gMTsKKyAgICB9IGNudDsKKyAg ICB1bnNpZ25lZCBsb25nIHJhdzsKK307CiAKIHN0YXRpYyB2b2lkCiBtYXBf Z3JhbnRfcmVmKApAQCAtMTAyMyw3ICs5NzcsNiBAQCBtYXBfZ3JhbnRfcmVm KAogICAgIHN0cnVjdCBncmFudF9tYXBwaW5nICptdDsKICAgICBncmFudF9l bnRyeV9oZWFkZXJfdCAqc2hhaDsKICAgICB1aW50MTZfdCAqc3RhdHVzOwot ICAgIGJvb2xfdCBuZWVkX2lvbW11OwogCiAgICAgbGQgPSBjdXJyZW50LT5k b21haW47CiAKQEAgLTEyNDQsMzEgKzExOTcsNzUgQEAgbWFwX2dyYW50X3Jl ZigKICAgICAgKiBhcyBtZW0tc2hhcmluZyBhbmQgSU9NTVUgdXNlIGFyZSBp bmNvbXBhdGlibGUpLiBUaGUgZG9tX2lvIGNhc2Ugd291bGQKICAgICAgKiBu ZWVkIGNoZWNraW5nIHNlcGFyYXRlbHkgaWYgd2UgY29tcGFyZWQgYWdhaW5z dCBvd25lciBoZXJlLgogICAgICAqLwotICAgIG5lZWRfaW9tbXUgPSBsZCAh PSByZCAmJiBnbnR0YWJfbmVlZF9pb21tdV9tYXBwaW5nKGxkKTsKLSAgICBp ZiAoIG5lZWRfaW9tbXUgKQorICAgIGlmICggbGQgIT0gcmQgJiYgZ250dGFi X25lZWRfaW9tbXVfbWFwcGluZyhsZCkgKQogICAgIHsKKyAgICAgICAgdW5p b24gbWFwdHJhY2tfbm9kZSBub2RlID0geworICAgICAgICAgICAgLmNudC5y ZCA9ICEhKG9wLT5mbGFncyAmIEdOVE1BUF9yZWFkb25seSksCisgICAgICAg ICAgICAuY250LndyID0gIShvcC0+ZmxhZ3MgJiBHTlRNQVBfcmVhZG9ubHkp LAorICAgICAgICB9OworICAgICAgICBpbnQgZXJyOworICAgICAgICB2b2lk ICoqc2xvdCA9IE5VTEw7CiAgICAgICAgIHVuc2lnbmVkIGludCBraW5kOwog Ci0gICAgICAgIGRvdWJsZV9ndF9sb2NrKGxndCwgcmd0KTsKKyAgICAgICAg Z3JhbnRfd3JpdGVfbG9jayhsZ3QpOworCisgICAgICAgIGVyciA9IHJhZGl4 X3RyZWVfaW5zZXJ0KCZsZ3QtPm1hcHRyYWNrX3RyZWUsIG1mbl94KG1mbiks CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHJhZGl4X3RyZWVf dWxvbmdfdG9fcHRyKG5vZGUucmF3KSk7CisgICAgICAgIGlmICggZXJyID09 IC1FRVhJU1QgKQorICAgICAgICB7CisgICAgICAgICAgICBzbG90ID0gcmFk aXhfdHJlZV9sb29rdXBfc2xvdCgmbGd0LT5tYXB0cmFja190cmVlLCBtZm5f eChtZm4pKTsKKyAgICAgICAgICAgIGlmICggbGlrZWx5KHNsb3QpICkKKyAg ICAgICAgICAgIHsKKyAgICAgICAgICAgICAgICBub2RlLnJhdyA9IHJhZGl4 X3RyZWVfcHRyX3RvX3Vsb25nKCpzbG90KTsKKyAgICAgICAgICAgICAgICBl cnIgPSAtRUJVU1k7CisKKyAgICAgICAgICAgICAgICAvKiBVcGRhdGUgbm9k ZSBvbmx5IHdoZW4gcmVmY291bnQgZG9lc24ndCBvdmVyZmxvdy4gKi8KKyAg ICAgICAgICAgICAgICBpZiAoIG9wLT5mbGFncyAmIEdOVE1BUF9yZWFkb25s eSA/ICsrbm9kZS5jbnQucmQKKyAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICA6ICsrbm9kZS5jbnQud3IgKQorICAg ICAgICAgICAgICAgIHsKKyAgICAgICAgICAgICAgICAgICAgcmFkaXhfdHJl ZV9yZXBsYWNlX3Nsb3Qoc2xvdCwKKyAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgcmFkaXhfdHJlZV91bG9uZ190b19wdHIo bm9kZS5yYXcpKTsKKyAgICAgICAgICAgICAgICAgICAgZXJyID0gMDsKKyAg ICAgICAgICAgICAgICB9CisgICAgICAgICAgICB9CisgICAgICAgICAgICBl bHNlCisgICAgICAgICAgICAgICAgQVNTRVJUX1VOUkVBQ0hBQkxFKCk7Cisg ICAgICAgIH0KIAogICAgICAgICAvKgogICAgICAgICAgKiBXZSdyZSBub3Qg dHJhbnNsYXRlZCwgc28gd2Uga25vdyB0aGF0IGRmbnMgYW5kIG1mbnMgYXJl CiAgICAgICAgICAqIHRoZSBzYW1lIHRoaW5ncywgc28gdGhlIElPTU1VIGVu dHJ5IGlzIGFsd2F5cyAxLXRvLTEuCiAgICAgICAgICAqLwotICAgICAgICBr aW5kID0gbWFwa2luZChsZ3QsIHJkLCBtZm4pOwotICAgICAgICBpZiAoICEo b3AtPmZsYWdzICYgR05UTUFQX3JlYWRvbmx5KSAmJgotICAgICAgICAgICAg ICEoa2luZCAmIE1BUEtJTkRfV1JJVEUpICkKKyAgICAgICAgaWYgKCAhKG9w LT5mbGFncyAmIEdOVE1BUF9yZWFkb25seSkgJiYgbm9kZS5jbnQud3IgPT0g MSApCiAgICAgICAgICAgICBraW5kID0gSU9NTVVGX3JlYWRhYmxlIHwgSU9N TVVGX3dyaXRhYmxlOwotICAgICAgICBlbHNlIGlmICggIWtpbmQgKQorICAg ICAgICBlbHNlIGlmICggKG9wLT5mbGFncyAmIEdOVE1BUF9yZWFkb25seSkg JiYKKyAgICAgICAgICAgICAgICAgIG5vZGUuY250LnJkID09IDEgJiYgIW5v ZGUuY250LndyICkKICAgICAgICAgICAgIGtpbmQgPSBJT01NVUZfcmVhZGFi bGU7CiAgICAgICAgIGVsc2UKICAgICAgICAgICAgIGtpbmQgPSAwOwotICAg ICAgICBpZiAoIGtpbmQgJiYgaW9tbXVfbGVnYWN5X21hcChsZCwgX2Rmbiht Zm5feChtZm4pKSwgbWZuLCAxLCBraW5kKSApCisgICAgICAgIGlmICggZXJy IHx8CisgICAgICAgICAgICAgKGtpbmQgJiYgaW9tbXVfbGVnYWN5X21hcChs ZCwgX2RmbihtZm5feChtZm4pKSwgbWZuLCAxLCBraW5kKSkgKQogICAgICAg ICB7Ci0gICAgICAgICAgICBkb3VibGVfZ3RfdW5sb2NrKGxndCwgcmd0KTsK KyAgICAgICAgICAgIGlmICggIWVyciApCisgICAgICAgICAgICB7CisgICAg ICAgICAgICAgICAgaWYgKCBzbG90ICkKKyAgICAgICAgICAgICAgICB7Cisg ICAgICAgICAgICAgICAgICAgIG9wLT5mbGFncyAmIEdOVE1BUF9yZWFkb25s eSA/IG5vZGUuY250LnJkLS0KKyAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIDogbm9kZS5jbnQud3ItLTsKKyAgICAg ICAgICAgICAgICAgICAgcmFkaXhfdHJlZV9yZXBsYWNlX3Nsb3Qoc2xvdCwK KyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg cmFkaXhfdHJlZV91bG9uZ190b19wdHIobm9kZS5yYXcpKTsKKyAgICAgICAg ICAgICAgICB9CisgICAgICAgICAgICAgICAgZWxzZQorICAgICAgICAgICAg ICAgICAgICByYWRpeF90cmVlX2RlbGV0ZSgmbGd0LT5tYXB0cmFja190cmVl LCBtZm5feChtZm4pKTsKKyAgICAgICAgICAgIH0KKwogICAgICAgICAgICAg cmMgPSBHTlRTVF9nZW5lcmFsX2Vycm9yOwotICAgICAgICAgICAgZ290byB1 bmRvX291dDsKICAgICAgICAgfQorCisgICAgICAgIGdyYW50X3dyaXRlX3Vu bG9jayhsZ3QpOworCisgICAgICAgIGlmICggcmMgIT0gR05UU1Rfb2theSAp CisgICAgICAgICAgICBnb3RvIHVuZG9fb3V0OwogICAgIH0KIAogICAgIFRS QUNFXzFEKFRSQ19NRU1fUEFHRV9HUkFOVF9NQVAsIG9wLT5kb20pOwpAQCAt MTI3NiwxMCArMTI3Myw2IEBAIG1hcF9ncmFudF9yZWYoCiAgICAgLyoKICAg ICAgKiBBbGwgbWFwdHJhY2sgZW50cnkgdXNlcnMgY2hlY2sgbXQtPmZsYWdz IGZpcnN0IGJlZm9yZSB1c2luZyB0aGUKICAgICAgKiBvdGhlciBmaWVsZHMg c28ganVzdCBlbnN1cmUgdGhlIGZsYWdzIGZpZWxkIGlzIHN0b3JlZCBsYXN0 LgotICAgICAqCi0gICAgICogSG93ZXZlciwgaWYgZ250dGFiX25lZWRfaW9t bXVfbWFwcGluZygpIHRoZW4gdGhpcyB3b3VsZCByYWNlCi0gICAgICogd2l0 aCBhIGNvbmN1cnJlbnQgbWFwa2luZCgpIGNhbGwgKG9uIGFuIHVubWFwLCBm b3IgZXhhbXBsZSkKLSAgICAgKiBhbmQgYSBsb2NrIGlzIHJlcXVpcmVkLgog ICAgICAqLwogICAgIG10ID0gJm1hcHRyYWNrX2VudHJ5KGxndCwgaGFuZGxl KTsKICAgICBtdC0+ZG9taWQgPSBvcC0+ZG9tOwpAQCAtMTI4Nyw5ICsxMjgw LDYgQEAgbWFwX2dyYW50X3JlZigKICAgICBzbXBfd21iKCk7CiAgICAgd3Jp dGVfYXRvbWljKCZtdC0+ZmxhZ3MsIG9wLT5mbGFncyk7CiAKLSAgICBpZiAo IG5lZWRfaW9tbXUgKQotICAgICAgICBkb3VibGVfZ3RfdW5sb2NrKGxndCwg cmd0KTsKLQogICAgIG9wLT5kZXZfYnVzX2FkZHIgPSBtZm5fdG9fbWFkZHIo bWZuKTsKICAgICBvcC0+aGFuZGxlICAgICAgID0gaGFuZGxlOwogICAgIG9w LT5zdGF0dXMgICAgICAgPSBHTlRTVF9va2F5OwpAQCAtMTQ5NywxOSArMTQ4 NywzNCBAQCB1bm1hcF9jb21tb24oCiAgICAgLyogU2VlIHRoZSByZXNwZWN0 aXZlIGNvbW1lbnQgaW4gbWFwX2dyYW50X3JlZigpLiAqLwogICAgIGlmICgg cmMgPT0gR05UU1Rfb2theSAmJiBsZCAhPSByZCAmJiBnbnR0YWJfbmVlZF9p b21tdV9tYXBwaW5nKGxkKSApCiAgICAgewotICAgICAgICB1bnNpZ25lZCBp bnQga2luZDsKKyAgICAgICAgdm9pZCAqKnNsb3Q7CisgICAgICAgIHVuaW9u IG1hcHRyYWNrX25vZGUgbm9kZTsKICAgICAgICAgaW50IGVyciA9IDA7CiAK LSAgICAgICAgZG91YmxlX2d0X2xvY2sobGd0LCByZ3QpOworICAgICAgICBn cmFudF93cml0ZV9sb2NrKGxndCk7CisgICAgICAgIHNsb3QgPSByYWRpeF90 cmVlX2xvb2t1cF9zbG90KCZsZ3QtPm1hcHRyYWNrX3RyZWUsIG1mbl94KG9w LT5tZm4pKTsKKyAgICAgICAgbm9kZS5yYXcgPSBsaWtlbHkoc2xvdCkgPyBy YWRpeF90cmVlX3B0cl90b191bG9uZygqc2xvdCkgOiAwOworCisgICAgICAg IC8qIFJlZmNvdW50IG11c3Qgbm90IHVuZGVyZmxvdy4gKi8KKyAgICAgICAg aWYgKCAhKGZsYWdzICYgR05UTUFQX3JlYWRvbmx5ID8gbm9kZS5jbnQucmQt LQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgOiBu b2RlLmNudC53ci0tKSApCisgICAgICAgICAgICBCVUcoKTsKIAotICAgICAg ICBraW5kID0gbWFwa2luZChsZ3QsIHJkLCBvcC0+bWZuKTsKLSAgICAgICAg aWYgKCAha2luZCApCisgICAgICAgIGlmICggIW5vZGUucmF3ICkKICAgICAg ICAgICAgIGVyciA9IGlvbW11X2xlZ2FjeV91bm1hcChsZCwgX2RmbihtZm5f eChvcC0+bWZuKSksIDEpOwotICAgICAgICBlbHNlIGlmICggIShraW5kICYg TUFQS0lORF9XUklURSkgKQorICAgICAgICBlbHNlIGlmICggIShmbGFncyAm IEdOVE1BUF9yZWFkb25seSkgJiYgIW5vZGUuY250LndyICkKICAgICAgICAg ICAgIGVyciA9IGlvbW11X2xlZ2FjeV9tYXAobGQsIF9kZm4obWZuX3gob3At Pm1mbikpLCBvcC0+bWZuLCAxLAogICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICBJT01NVUZfcmVhZGFibGUpOwogCi0gICAgICAgIGRvdWJs ZV9ndF91bmxvY2sobGd0LCByZ3QpOworICAgICAgICBpZiAoIGVyciApCisg ICAgICAgICAgICA7CisgICAgICAgIGVsc2UgaWYgKCAhbm9kZS5yYXcgKQor ICAgICAgICAgICAgcmFkaXhfdHJlZV9kZWxldGUoJmxndC0+bWFwdHJhY2tf dHJlZSwgbWZuX3gob3AtPm1mbikpOworICAgICAgICBlbHNlCisgICAgICAg ICAgICByYWRpeF90cmVlX3JlcGxhY2Vfc2xvdChzbG90LAorICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgcmFkaXhfdHJlZV91bG9uZ190 b19wdHIobm9kZS5yYXcpKTsKKworICAgICAgICBncmFudF93cml0ZV91bmxv Y2sobGd0KTsKIAogICAgICAgICBpZiAoIGVyciApCiAgICAgICAgICAgICBy YyA9IEdOVFNUX2dlbmVyYWxfZXJyb3I7CkBAIC0xOTU2LDYgKzE5NjEsOCBA QCBpbnQgZ3JhbnRfdGFibGVfaW5pdChzdHJ1Y3QgZG9tYWluICpkLCBpCiAg ICAgICAgIGd0LT5tYXB0cmFjayA9IHZ6YWxsb2MoZ3QtPm1heF9tYXB0cmFj a19mcmFtZXMgKiBzaXplb2YoKmd0LT5tYXB0cmFjaykpOwogICAgICAgICBp ZiAoIGd0LT5tYXB0cmFjayA9PSBOVUxMICkKICAgICAgICAgICAgIGdvdG8g b3V0OworCisgICAgICAgIHJhZGl4X3RyZWVfaW5pdCgmZ3QtPm1hcHRyYWNr X3RyZWUpOwogICAgIH0KIAogICAgIC8qIFNoYXJlZCBncmFudCB0YWJsZS4g Ki8KQEAgLTM3MDQsNiArMzcxMSw4IEBAIGludCBnbnR0YWJfcmVsZWFzZV9t YXBwaW5ncyhzdHJ1Y3QgZG9tYWkKIAogICAgIGZvciAoIGhhbmRsZSA9IGd0 LT5tYXB0cmFja19saW1pdDsgaGFuZGxlOyApCiAgICAgeworICAgICAgICBt Zm5fdCBtZm47CisKICAgICAgICAgLyoKICAgICAgICAgICogRGVhbCB3aXRo IGZ1bGwgcGFnZXMgc3VjaCB0aGF0IHRoZWlyIGZyZWVpbmcgKGluIHRoZSBi b2R5IG9mIHRoZQogICAgICAgICAgKiBpZigpKSByZW1haW5zIHNpbXBsZS4K QEAgLTM4MDEsMTcgKzM4MTAsMzEgQEAgaW50IGdudHRhYl9yZWxlYXNlX21h cHBpbmdzKHN0cnVjdCBkb21haQogCiAgICAgICAgIHJlZHVjZV9zdGF0dXNf Zm9yX3BpbihyZCwgYWN0LCBzdGF0dXMsIG1hcC0+ZmxhZ3MgJiBHTlRNQVBf cmVhZG9ubHkpOwogCisgICAgICAgIG1mbiA9IGFjdC0+bWZuOworCiAgICAg ICAgIGFjdGl2ZV9lbnRyeV9yZWxlYXNlKGFjdCk7CiAgICAgICAgIGdyYW50 X3JlYWRfdW5sb2NrKHJndCk7CiAKICAgICAgICAgcmN1X3VubG9ja19kb21h aW4ocmQpOwogCiAgICAgICAgIG1hcC0+ZmxhZ3MgPSAwOworCisgICAgICAg IC8qCisgICAgICAgICAqIFRoaXMgaXMgZXhjZXNzaXZlIGluIHRoYXQgYSBz aW5nbGUgc3VjaCBjYWxsIHdvdWxkIHN1ZmZpY2UgcGVyCisgICAgICAgICAq IG1hcHBlZCBNRk4gKG9yIG5vbmUgYXQgYWxsLCBpZiBubyBlbnRyeSB3YXMg ZXZlciBpbnNlcnRlZCkuIEJ1dCBpdAorICAgICAgICAgKiBzaG91bGQgYmUg dGhlIGNvbW1vbiBjYXNlIGZvciBhbiBNRk4gdG8gYmUgbWFwcGVkIGp1c3Qg b25jZSwgYW5kCisgICAgICAgICAqIHRoaXMgd2F5IHdlIGRvbid0IG5lZWQg dG8gZnVydGhlciBtYWludGFpbiB0aGUgY291bnRlcnMuIFdlIGFsc28KKyAg ICAgICAgICogZG9uJ3Qgd2FudCB0byBsZWF2ZSBjbGVhbmluZyB1cCBvZiB0 aGUgdHJlZSBhcyBhIHdob2xlIHRvIHRoZSBlbmQKKyAgICAgICAgICogb2Yg dGhlIGZ1bmN0aW9uLCBhcyB0aGlzIGNvdWxkIHRha2UgcXVpdGUgc29tZSB0 aW1lLgorICAgICAgICAgKi8KKyAgICAgICAgcmFkaXhfdHJlZV9kZWxldGUo Jmd0LT5tYXB0cmFja190cmVlLCBtZm5feChtZm4pKTsKICAgICB9CiAKICAg ICBndC0+bWFwdHJhY2tfbGltaXQgPSAwOwogICAgIEZSRUVfWEVOSEVBUF9Q QUdFKGd0LT5tYXB0cmFja1swXSk7CiAKKyAgICByYWRpeF90cmVlX2Rlc3Ry b3koJmd0LT5tYXB0cmFja190cmVlLCBOVUxMKTsKKwogICAgIHJldHVybiAw OwogfQogCi0tLSBhL3hlbi9pbmNsdWRlL3hlbi9yYWRpeC10cmVlLmgKKysr IGIveGVuL2luY2x1ZGUveGVuL3JhZGl4LXRyZWUuaApAQCAtMTkwLDYgKzE5 MCwyNSBAQCBzdGF0aWMgaW5saW5lIGludCByYWRpeF90cmVlX3B0cl90b19p bnQoCiAgICAgcmV0dXJuIChpbnQpKChsb25nKXB0ciA+PiAyKTsKIH0KIAor LyoqCisgKiByYWRpeF90cmVlX3t1bG9uZ190b19wdHIscHRyX3RvX3Vsb25n fToKKyAqCisgKiBTYW1lIGZvciB1bnNpZ25lZCBsb25nIHZhbHVlcy4gQmV3 YXJlIHRob3VnaCB0aGF0IG9ubHkgQklUU19QRVJfTE9ORy0yCisgKiBiaXRz IGFyZSBhY3R1YWxseSB1c2FibGUgZm9yIHRoZSB2YWx1ZS4KKyAqLworc3Rh dGljIGlubGluZSB2b2lkICpyYWRpeF90cmVlX3Vsb25nX3RvX3B0cih1bnNp Z25lZCBsb25nIHZhbCkKK3sKKyAgICB1bnNpZ25lZCBsb25nIHB0ciA9ICh2 YWwgPDwgMikgfCAweDI7CisgICAgQVNTRVJUKChwdHIgPj4gMikgPT0gdmFs KTsKKyAgICByZXR1cm4gKHZvaWQgKilwdHI7Cit9CisKK3N0YXRpYyBpbmxp bmUgdW5zaWduZWQgbG9uZyByYWRpeF90cmVlX3B0cl90b191bG9uZyh2b2lk ICpwdHIpCit7CisgICAgQVNTRVJUKCgodW5zaWduZWQgbG9uZylwdHIgJiAw eDMpID09IDB4Mik7CisgICAgcmV0dXJuICh1bnNpZ25lZCBsb25nKXB0ciA+ PiAyOworfQorCiBpbnQgcmFkaXhfdHJlZV9pbnNlcnQoc3RydWN0IHJhZGl4 X3RyZWVfcm9vdCAqLCB1bnNpZ25lZCBsb25nLCB2b2lkICopOwogdm9pZCAq cmFkaXhfdHJlZV9sb29rdXAoc3RydWN0IHJhZGl4X3RyZWVfcm9vdCAqLCB1 bnNpZ25lZCBsb25nKTsKIHZvaWQgKipyYWRpeF90cmVlX2xvb2t1cF9zbG90 KHN0cnVjdCByYWRpeF90cmVlX3Jvb3QgKiwgdW5zaWduZWQgbG9uZyk7Cg== --=separator Content-Type: application/octet-stream; name="xsa380/xsa380-3.patch" Content-Disposition: attachment; filename="xsa380/xsa380-3.patch" Content-Transfer-Encoding: base64 RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0 OiBnbnR0YWI6IGF2b2lkIHRyaWdnZXJpbmcgYXNzZXJ0aW9uIGluIHJhZGl4 X3RyZWVfdWxvbmdfdG9fcHRyKCkKClJlbGV2YW50IHF1b3RlcyBmcm9tIHRo ZSBDMTEgc3RhbmRhcmQ6CgoiRXhjZXB0IHdoZXJlIGV4cGxpY2l0bHkgc3Rh dGVkIG90aGVyd2lzZSwgZm9yIHRoZSBwdXJwb3NlcyBvZiB0aGlzCiBzdWJj bGF1c2UgdW5uYW1lZCBtZW1iZXJzIG9mIG9iamVjdHMgb2Ygc3RydWN0dXJl IGFuZCB1bmlvbiB0eXBlIGRvIG5vdAogcGFydGljaXBhdGUgaW4gaW5pdGlh bGl6YXRpb24uIFVubmFtZWQgbWVtYmVycyBvZiBzdHJ1Y3R1cmUgb2JqZWN0 cwogaGF2ZSBpbmRldGVybWluYXRlIHZhbHVlIGV2ZW4gYWZ0ZXIgaW5pdGlh bGl6YXRpb24uIgoKIklmIHRoZXJlIGFyZSBmZXdlciBpbml0aWFsaXplcnMg aW4gYSBicmFjZS1lbmNsb3NlZCBsaXN0IHRoYW4gdGhlcmUgYXJlCiBlbGVt ZW50cyBvciBtZW1iZXJzIG9mIGFuIGFnZ3JlZ2F0ZSwgWy4uLl0sIHRoZSBy ZW1haW5kZXIgb2YgdGhlCiBhZ2dyZWdhdGUgc2hhbGwgYmUgaW5pdGlhbGl6 ZWQgaW1wbGljaXRseSB0aGUgc2FtZSBhcyBvYmplY3RzIHRoYXQgaGF2ZQog c3RhdGljIHN0b3JhZ2UgZHVyYXRpb24uIgoKIklmIGFuIG9iamVjdCB0aGF0 IGhhcyBzdGF0aWMgb3IgdGhyZWFkIHN0b3JhZ2UgZHVyYXRpb24gaXMgbm90 CiBpbml0aWFsaXplZCBleHBsaWNpdGx5LCB0aGVuOgogWy4uLl0KIOKAlCBp ZiBpdCBpcyBhbiBhZ2dyZWdhdGUsIGV2ZXJ5IG1lbWJlciBpcyBpbml0aWFs aXplZCAocmVjdXJzaXZlbHkpCiAgIGFjY29yZGluZyB0byB0aGVzZSBydWxl cywgYW5kIGFueSBwYWRkaW5nIGlzIGluaXRpYWxpemVkIHRvIHplcm8KICAg Yml0czsKIFsuLi5dIgoKIkEgYml0LWZpZWxkIGRlY2xhcmF0aW9uIHdpdGgg bm8gZGVjbGFyYXRvciwgYnV0IG9ubHkgYSBjb2xvbiBhbmQgYQogd2lkdGgs IGluZGljYXRlcyBhbiB1bm5hbWVkIGJpdC1maWVsZC4iIEZvb3Rub3RlOiAi QW4gdW5uYW1lZCBiaXQtZmllbGQKIHN0cnVjdHVyZSBtZW1iZXIgaXMgdXNl ZnVsIGZvciBwYWRkaW5nIHRvIGNvbmZvcm0gdG8gZXh0ZXJuYWxseSBpbXBv c2VkCiBsYXlvdXRzLiIKCiJUaGVyZSBtYXkgYmUgdW5uYW1lZCBwYWRkaW5n IHdpdGhpbiBhIHN0cnVjdHVyZSBvYmplY3QsIGJ1dCBub3QgYXQgaXRzCiBi ZWdpbm5pbmcuIgoKV2hpY2ggbWFrZXMgbWUgY29uY2x1ZGU6Ci0gV2hldGhl ciBhbiB1bm5hbWVkIGJpdC1maWVsZCBtZW1iZXIgaXMgYW4gdW5uYW1lZCBt ZW1iZXIgb3IgcGFkZGluZyBpcwogIHVuY2xlYXIsIGFuZCBoZW5jZSBhbHNv IHdoZXRoZXIgdGhlIGxhc3QgcXVvdGUgYWJvdmUgd291bGQgcmVuZGVyIHRo ZQogIGJpZyBlbmRpYW4gY2FzZSBvZiB0aGUgc3RydWN0dXJlIGRlY2xhcmF0 aW9uIGludmFsaWQuCi0gV2hldGhlciB0aGUgbnVtYmVyIG9mIG1lbWJlcnMg b2YgYW4gYWdncmVnYXRlIGluY2x1ZGVzIHVubmFtZWQgb25lcyBpcwogIGFs c28gbm90IHJlYWxseSBjbGVhci4KLSBUaGUgaW5pdGlhbGl6ZXIgaW4gbWFw X2dyYW50X3JlZigpIGluaXRpYWxpemVzIGFsbCBmaWVsZHMgb2YgdGhlICJj bnQiCiAgc3ViLXN0cnVjdHVyZSBvZiB0aGUgdW5pb24sIHNvIGFzc3VtaW5n IHRoZSBzZWNvbmQgcXVvdGUgYWJvdmUgYXBwbGllcwogIGhlcmUgKGluZGly ZWN0bHkpLCB0aGUgY29tcGlsZXIgaXNuJ3QgcmVxdWlyZWQgdG8gaW1wbGlj aXRseQogIGluaXRpYWxpemUgdGhlIHJlc3QgKGkuZS4gaW4gcGFydGljdWxh ciBhbnkgcGFkZGluZykgbGlrZSB3b3VsZCBoYXBwZW4KICBmb3Igc3RhdGlj IHN0b3JhZ2UgZHVyYXRpb24gb2JqZWN0cy4KCkdjYyA3LjQuMSBjYW4gYmUg b2JzZXJ2ZWQgKGFwcGFyZW50bHkgaW4gZGVidWcgYnVpbGRzIG9ubHkpIHRv IHRyYW5zbGF0ZQphZm9yZW1lbnRpb25lZCBpbml0aWFsaXplciB0byBhIHJl YWQtbW9kaWZ5LXdyaXRlIG9wZXJhdGlvbiBvZiBhIHN0YWNrCnZhcmlhYmxl LCBsZWF2aW5nIHVuY2hhbmdlZCB0aGUgdG9wIHR3byBiaXRzIG9mIHdoYXRl dmVyIHdhcyBwcmV2aW91c2x5CmluIHRoYXQgc3RhY2sgc2xvdC4gQ2xlYXJs eSBpZiBlaXRoZXIgb2YgdGhlIHR3byBiaXRzIHdlcmUgc2V0LApyYWRpeF90 cmVlX3Vsb25nX3RvX3B0cigpJ3MgYXNzZXJ0aW9uIHdvdWxkIHRyaWdnZXIu CgpUaGVyZWZvcmUsIHRvIGJlIG9uIHRoZSBzYWZlIHNpZGUsIGFkZCBhbiBl eHBsaWNpdCBwYWRkaW5nIGZpZWxkIGZvciB0aGUKbm9uLWJpZy1lbmRpYW4t Yml0ZmllbGRzIGNhc2UgYW5kIGdpdmUgYSBkdW1teSBuYW1lIHRvIGJvdGgg cGFkZGluZwpmaWVsZHMuCgpGaXhlczogOTc4MWI1MWVmZGUyICgiZ250dGFi OiByZXBsYWNlIG1hcGtpbmQoKSIpClNpZ25lZC1vZmYtYnk6IEphbiBCZXVs aWNoIDxqYmV1bGljaEBzdXNlLmNvbT4KQWNrZWQtYnk6IEFuZHJldyBDb29w ZXIgPGFuZHJldy5jb29wZXIzQGNpdHJpeC5jb20+CgotLS0gYS94ZW4vY29t bW9uL2dyYW50X3RhYmxlLmMKKysrIGIveGVuL2NvbW1vbi9ncmFudF90YWJs ZS5jCkBAIC05NTIsMTAgKzk1MiwxMyBAQCB1bmlvbiBtYXB0cmFja19ub2Rl IHsKICAgICBzdHJ1Y3QgewogICAgICAgICAvKiBSYWRpeCB0cmVlIHNsb3Qg cG9pbnRlcnMgdXNlIHR3byBvZiB0aGUgYml0cy4gKi8KICNpZmRlZiBfX0JJ R19FTkRJQU5fQklURklFTEQKLSAgICAgICAgdW5zaWduZWQgbG9uZyAgICA6 IDI7CisgICAgICAgIHVuc2lnbmVkIGxvbmcgXzAgOiAyOwogI2VuZGlmCiAg ICAgICAgIHVuc2lnbmVkIGxvbmcgcmQgOiBCSVRTX1BFUl9MT05HIC8gMiAt IDE7CiAgICAgICAgIHVuc2lnbmVkIGxvbmcgd3IgOiBCSVRTX1BFUl9MT05H IC8gMiAtIDE7CisjaWZuZGVmIF9fQklHX0VORElBTl9CSVRGSUVMRAorICAg ICAgICB1bnNpZ25lZCBsb25nIF8wIDogMjsKKyNlbmRpZgogICAgIH0gY250 OwogICAgIHVuc2lnbmVkIGxvbmcgcmF3OwogfTsK --=separator Content-Type: application/octet-stream; name="xsa380/xsa380-4.11-1.patch" Content-Disposition: attachment; filename="xsa380/xsa380-4.11-1.patch" Content-Transfer-Encoding: base64 RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0 OiBnbnR0YWI6IGFkZCBwcmVlbXB0aW9uIGNoZWNrIHRvIGdudHRhYl9yZWxl YXNlX21hcHBpbmdzKCkKCkEgZ3Vlc3QgbWF5IGRpZSB3aXRoIG1hbnkgZ3Jh bnQgbWFwcGluZ3Mgc3RpbGwgaW4gcGxhY2UsIG9yIHNpbXBseSB3aXRoCmEg bGFyZ2UgbWFwdHJhY2sgdGFibGUuIEl0ZXJhdGluZyB0aHJvdWdoIHRoaXMg bWF5IHRha2UgbW9yZSB0aW1lIHRoYW4KaXMgcmVhc29uYWJsZSB3aXRob3V0 IGludGVybWVkaWF0ZSBwcmVlbXB0aW9uICh0byBydW4gc29mdGlycXMgYW5k CnBlcmhhcHMgdGhlIHNjaGVkdWxlcikuCgpNb3ZlIHRoZSBpbnZvY2F0aW9u IG9mIHRoZSBmdW5jdGlvbiB0byB0aGUgc2VjdGlvbiB3aGVyZSBvdGhlcgpy ZXN0YXJ0YWJsZSBmdW5jdGlvbnMgZ2V0IGludm9rZWQsIGFuZCBoYXZlIHRo ZSBmdW5jdGlvbiBpdHNlbGYgY2hlY2sKZm9yIHByZWVtcHRpb24gZXZlcnkg b25jZSBpbiBhIHdoaWxlLiBIYXZlIGl0IGl0ZXJhdGUgdGhlIHRhYmxlCmJh Y2t3YXJkcywgc3VjaCB0aGF0IGRlY3JlYXNpbmcgdGhlIG1hcHRyYWNrIGxp bWl0IGlzIGFsbCBpdCB0YWtlcyB0bwpjb252ZXkgcmVzdGFydCBpbmZvcm1h dGlvbi4KCkluIGRvbWFpbl90ZWFyZG93bigpIGludHJvZHVjZSBQUk9HX25v bmUgc3VjaCB0aGF0IGluc2VydGluZyBhdCB0aGUKZnJvbnQgd2lsbCBiZSBl YXNpZXIgZ29pbmcgZm9yd2FyZC4KClRoaXMgaXMgcGFydCBvZiBDVkUtMjAy MS0yODY5OCAvIFhTQS0zODAuCgpSZXBvcnRlZC1ieTogQW5kcmV3IENvb3Bl ciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNvbT4KU2lnbmVkLW9mZi1ieTog SmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpSZXZpZXdlZC1ieTog SnVsaWVuIEdyYWxsIDxqZ3JhbGxAYW1hem9uLmNvbT4KCi0tLSBhL3hlbi9j b21tb24vZG9tYWluLmMKKysrIGIveGVuL2NvbW1vbi9kb21haW4uYwpAQCAt NjQ2LDEzICs2NDYsMTUgQEAgaW50IGRvbWFpbl9raWxsKHN0cnVjdCBkb21h aW4gKmQpCiAgICAgICAgIGlmICggZC0+aXNfZHlpbmcgIT0gRE9NRFlJTkdf YWxpdmUgKQogICAgICAgICAgICAgcmV0dXJuIGRvbWFpbl9raWxsKGQpOwog ICAgICAgICBkLT5pc19keWluZyA9IERPTURZSU5HX2R5aW5nOwotICAgICAg ICBnbnR0YWJfcmVsZWFzZV9tYXBwaW5ncyhkKTsKICAgICAgICAgdG1lbV9k ZXN0cm95KGQtPnRtZW1fY2xpZW50KTsKICAgICAgICAgdm51bWFfZGVzdHJv eShkLT52bnVtYSk7CiAgICAgICAgIGRvbWFpbl9zZXRfb3V0c3RhbmRpbmdf cGFnZXMoZCwgMCk7CiAgICAgICAgIGQtPnRtZW1fY2xpZW50ID0gTlVMTDsK ICAgICAgICAgLyogZmFsbHRocm91Z2ggKi8KICAgICBjYXNlIERPTURZSU5H X2R5aW5nOgorICAgICAgICByYyA9IGdudHRhYl9yZWxlYXNlX21hcHBpbmdz KGQpOworICAgICAgICBpZiAoIHJjICkKKyAgICAgICAgICAgIGJyZWFrOwog ICAgICAgICByYyA9IGV2dGNobl9kZXN0cm95KGQpOwogICAgICAgICBpZiAo IHJjICkKICAgICAgICAgICAgIGJyZWFrOwotLS0gYS94ZW4vY29tbW9uL2dy YW50X3RhYmxlLmMKKysrIGIveGVuL2NvbW1vbi9ncmFudF90YWJsZS5jCkBA IC02Miw3ICs2MiwxMyBAQCBzdHJ1Y3QgZ3JhbnRfdGFibGUgewogICAgIHVu c2lnbmVkIGludCAgICAgICAgICBucl9ncmFudF9mcmFtZXM7CiAgICAgLyog TnVtYmVyIG9mIGdyYW50IHN0YXR1cyBmcmFtZXMgc2hhcmVkIHdpdGggZ3Vl c3QgKGZvciB2ZXJzaW9uIDIpICovCiAgICAgdW5zaWduZWQgaW50ICAgICAg ICAgIG5yX3N0YXR1c19mcmFtZXM7Ci0gICAgLyogTnVtYmVyIG9mIGF2YWls YWJsZSBtYXB0cmFjayBlbnRyaWVzLiAqLworICAgIC8qCisgICAgICogTnVt YmVyIG9mIGF2YWlsYWJsZSBtYXB0cmFjayBlbnRyaWVzLiAgRm9yIGNsZWFu dXAgcHVycG9zZXMgaXQgaXMKKyAgICAgKiBpbXBvcnRhbnQgdG8gcmVhbGl6 ZSB0aGF0IHRoaXMgZmllbGQgYW5kIEBtYXB0cmFjayBmdXJ0aGVyIGRvd24g d2lsbAorICAgICAqIG9ubHkgZXZlciBiZSBhY2Nlc3NlZCBieSB0aGUgbG9j YWwgZG9tYWluLiAgVGh1cyBpdCBpcyBva2F5IHRvIGNsZWFuCisgICAgICog dXAgZWFybHksIGFuZCB0byBzaHJpbmsgdGhlIGxpbWl0IGZvciB0aGUgcHVy cG9zZSBvZiB0cmFja2luZyBjbGVhbnVwCisgICAgICogcHJvZ3Jlc3MuCisg ICAgICovCiAgICAgdW5zaWduZWQgaW50ICAgICAgICAgIG1hcHRyYWNrX2xp bWl0OwogICAgIC8qIFNoYXJlZCBncmFudCB0YWJsZSAoc2VlIGluY2x1ZGUv cHVibGljL2dyYW50X3RhYmxlLmgpLiAqLwogICAgIHVuaW9uIHsKQEAgLTM2 MTgsOSArMzYyNCw3IEBAIGdyYW50X3RhYmxlX2NyZWF0ZSgKICAgICByZXR1 cm4gcmV0OwogfQogCi12b2lkCi1nbnR0YWJfcmVsZWFzZV9tYXBwaW5ncygK LSAgICBzdHJ1Y3QgZG9tYWluICpkKQoraW50IGdudHRhYl9yZWxlYXNlX21h cHBpbmdzKHN0cnVjdCBkb21haW4gKmQpCiB7CiAgICAgc3RydWN0IGdyYW50 X3RhYmxlICAgKmd0ID0gZC0+Z3JhbnRfdGFibGUsICpyZ3Q7CiAgICAgc3Ry dWN0IGdyYW50X21hcHBpbmcgKm1hcDsKQEAgLTM2MzQsOCArMzYzOCwzMiBA QCBnbnR0YWJfcmVsZWFzZV9tYXBwaW5ncygKIAogICAgIEJVR19PTighZC0+ aXNfZHlpbmcpOwogCi0gICAgZm9yICggaGFuZGxlID0gMDsgaGFuZGxlIDwg Z3QtPm1hcHRyYWNrX2xpbWl0OyBoYW5kbGUrKyApCisgICAgaWYgKCAhZ3Qg fHwgIWd0LT5tYXB0cmFjayApCisgICAgICAgIHJldHVybiAwOworCisgICAg Zm9yICggaGFuZGxlID0gZ3QtPm1hcHRyYWNrX2xpbWl0OyBoYW5kbGU7ICkK ICAgICB7CisgICAgICAgIC8qCisgICAgICAgICAqIERlYWwgd2l0aCBmdWxs IHBhZ2VzIHN1Y2ggdGhhdCB0aGVpciBmcmVlaW5nIChpbiB0aGUgYm9keSBv ZiB0aGUKKyAgICAgICAgICogaWYoKSkgcmVtYWlucyBzaW1wbGUuCisgICAg ICAgICAqLworICAgICAgICBpZiAoIGhhbmRsZSA8IGd0LT5tYXB0cmFja19s aW1pdCAmJiAhKGhhbmRsZSAlIE1BUFRSQUNLX1BFUl9QQUdFKSApCisgICAg ICAgIHsKKyAgICAgICAgICAgIC8qCisgICAgICAgICAgICAgKiBDaGFuZ2lu ZyBtYXB0cmFja19saW1pdCBhbHRlcnMgbnJfbWFwdHJhY2tfZnJhbWVzKCkn ZXMgcmV0dXJuCisgICAgICAgICAgICAgKiB2YWx1ZS4gRnJlZSB0aGUgdGhl biBleGNlc3MgdHJhaWxpbmcgcGFnZSByaWdodCBoZXJlLCByYXRoZXIKKyAg ICAgICAgICAgICAqIHRoYW4gbGVhdmluZyBpdCB0byBncmFudF90YWJsZV9k ZXN0cm95KCkgKGFuZCBpbiB0dXJuIHJlcXVpcmluZworICAgICAgICAgICAg ICogdG8gbGVhdmUgZ3QtPm1hcHRyYWNrX2xpbWl0IHVuYWx0ZXJlZCkuCisg ICAgICAgICAgICAgKi8KKyAgICAgICAgICAgIGd0LT5tYXB0cmFja19saW1p dCA9IGhhbmRsZTsKKyAgICAgICAgICAgIEZSRUVfWEVOSEVBUF9QQUdFKGd0 LT5tYXB0cmFja1tucl9tYXB0cmFja19mcmFtZXMoZ3QpXSk7CisKKyAgICAg ICAgICAgIGlmICggaHlwZXJjYWxsX3ByZWVtcHRfY2hlY2soKSApCisgICAg ICAgICAgICAgICAgcmV0dXJuIC1FUkVTVEFSVDsKKyAgICAgICAgfQorCisg ICAgICAgIC0taGFuZGxlOworCiAgICAgICAgIG1hcCA9ICZtYXB0cmFja19l bnRyeShndCwgaGFuZGxlKTsKICAgICAgICAgaWYgKCAhKG1hcC0+ZmxhZ3Mg JiAoR05UTUFQX2RldmljZV9tYXB8R05UTUFQX2hvc3RfbWFwKSkgKQogICAg ICAgICAgICAgY29udGludWU7CkBAIC0zNzIzLDYgKzM3NTEsMTEgQEAgZ250 dGFiX3JlbGVhc2VfbWFwcGluZ3MoCiAKICAgICAgICAgbWFwLT5mbGFncyA9 IDA7CiAgICAgfQorCisgICAgZ3QtPm1hcHRyYWNrX2xpbWl0ID0gMDsKKyAg ICBGUkVFX1hFTkhFQVBfUEFHRShndC0+bWFwdHJhY2tbMF0pOworCisgICAg cmV0dXJuIDA7CiB9CiAKIHZvaWQgZ3JhbnRfdGFibGVfd2Fybl9hY3RpdmVf Z3JhbnRzKHN0cnVjdCBkb21haW4gKmQpCkBAIC0zNzg1LDggKzM4MTgsNyBA QCBncmFudF90YWJsZV9kZXN0cm95KAogICAgICAgICBmcmVlX3hlbmhlYXBf cGFnZSh0LT5zaGFyZWRfcmF3W2ldKTsKICAgICB4ZnJlZSh0LT5zaGFyZWRf cmF3KTsKIAotICAgIGZvciAoIGkgPSAwOyBpIDwgbnJfbWFwdHJhY2tfZnJh bWVzKHQpOyBpKysgKQotICAgICAgICBmcmVlX3hlbmhlYXBfcGFnZSh0LT5t YXB0cmFja1tpXSk7CisgICAgQVNTRVJUKCF0LT5tYXB0cmFja19saW1pdCk7 CiAgICAgdmZyZWUodC0+bWFwdHJhY2spOwogCiAgICAgZm9yICggaSA9IDA7 IGkgPCBucl9hY3RpdmVfZ3JhbnRfZnJhbWVzKHQpOyBpKysgKQotLS0gYS94 ZW4vaW5jbHVkZS94ZW4vZ3JhbnRfdGFibGUuaAorKysgYi94ZW4vaW5jbHVk ZS94ZW4vZ3JhbnRfdGFibGUuaApAQCAtNDYsOSArNDYsNyBAQCBpbnQgZ3Jh bnRfdGFibGVfc2V0X2xpbWl0cyhzdHJ1Y3QgZG9tYWluCiB2b2lkIGdyYW50 X3RhYmxlX3dhcm5fYWN0aXZlX2dyYW50cyhzdHJ1Y3QgZG9tYWluICpkKTsK IAogLyogRG9tYWluIGRlYXRoIHJlbGVhc2Ugb2YgZ3JhbnRlZCBtYXBwaW5n cyBvZiBvdGhlciBkb21haW5zJyBtZW1vcnkuICovCi12b2lkCi1nbnR0YWJf cmVsZWFzZV9tYXBwaW5ncygKLSAgICBzdHJ1Y3QgZG9tYWluICpkKTsKK2lu dCBnbnR0YWJfcmVsZWFzZV9tYXBwaW5ncyhzdHJ1Y3QgZG9tYWluICpkKTsK IAogaW50IG1lbV9zaGFyaW5nX2dyZWZfdG9fZ2ZuKHN0cnVjdCBncmFudF90 YWJsZSAqZ3QsIGdyYW50X3JlZl90IHJlZiwKICAgICAgICAgICAgICAgICAg ICAgICAgICAgICBnZm5fdCAqZ2ZuLCB1aW50MTZfdCAqc3RhdHVzKTsK --=separator Content-Type: application/octet-stream; name="xsa380/xsa380-4.11-2.patch" Content-Disposition: attachment; filename="xsa380/xsa380-4.11-2.patch" Content-Transfer-Encoding: base64 RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0 OiBnbnR0YWI6IHJlcGxhY2UgbWFwa2luZCgpCgptYXBraW5kKCkgZG9lc24n dCBzY2FsZSB2ZXJ5IHdlbGwgd2l0aCBsYXJnZXIgbWFwdHJhY2sgZW50cnkg Y291bnRzLAp1c2luZyBhIGJydXRlIGZvcmNlIGxpbmVhciBzZWFyY2ggdGhy b3VnaCBhbGwgZW50cmllcywgd2l0aCB0aGUgb25seQpvcHRpb24gb2YgYW4g ZWFybHkgbG9vcCBleGl0IGlmIGEgbWF0Y2hpbmcgd3JpdGFibGUgZW50cnkg d2FzIGZvdW5kLgpJbnRyb2R1Y2UgYSByYWRpeCB0cmVlIGFsb25nc2lkZSB0 aGUgbWFpbiBtYXB0cmFjayB0YWJsZSwgdGh1cwphbGxvd2luZyBtdWNoIGZh c3RlciBNRk4tYmFzZWQgbG9va3VwLiBUbyBhdm9pZCB0aGUgbmVlZCB0byBh Y3R1YWxseQphbGxvY2F0ZSBzcGFjZSBmb3IgdGhlIGluZGl2aWR1YWwgbm9k ZXMsIGVuY29kZSB0aGUgdHdvIGNvdW50ZXJzIGluIHRoZQpub2RlIHBvaW50 ZXJzIHRoZW1zZWx2ZXMsIHRodXMgbGltaXRpbmcgdGhlIG51bWJlciBvZiBw ZXJtaXR0ZWQKc2ltdWx0YW5lb3VzIHIvbyBhbmQgci93IG1hcHBpbmdzIG9m IHRoZSBzYW1lIE1GTiB0byAywrPCuS0xICg2NC1iaXQpIC8KMsK54oG1LTEg KDMyLWJpdCkgZWFjaC4KClRvIGF2b2lkIGVuZm9yY2luZyBhbiB1bm5lY2Vz c2FyaWx5IGxvdyBib3VuZCBvbiB0aGUgbnVtYmVyIG9mCnNpbXVsdGFuZW91 cyBtYXBwaW5ncyBvZiBhIHNpbmdsZSBNRk4sIGludHJvZHVjZQpyYWRpeF90 cmVlX3t1bG9uZ190b19wdHIscHRyX3RvX3Vsb25nfSBwYXJhbGxlbGluZwpy YWRpeF90cmVlX3tpbnRfdG9fcHRyLHB0cl90b19pbnR9LgoKQXMgYSBjb25z ZXF1ZW5jZSBsb2NraW5nIGNoYW5nZXMgYXJlIGFsc28gYXBwbGljYWJsZTog V2l0aCB0aGVyZSBubwpsb25nZXIgYmVpbmcgYW55IGluc3BlY3Rpb24gb2Yg dGhlIHJlbW90ZSBkb21haW4ncyBhY3RpdmUgZW50cmllcywKdGhlcmUncyBh bHNvIG5vIG5lZWQgYW55bW9yZSB0byBob2xkIHRoZSByZW1vdGUgZG9tYWlu J3MgZ3JhbnQgdGFibGUKbG9jay4gQW5kIHNpbmNlIHdlJ3JlIG5vIGxvbmdl ciBpdGVyYXRpbmcgb3ZlciB0aGUgbG9jYWwgZG9tYWluJ3MgbWFwCnRyYWNr IHRhYmxlLCB0aGUgbG9jayBpbiBtYXBfZ3JhbnRfcmVmKCkgY2FuIGFsc28g YmUgZHJvcHBlZCBiZWZvcmUgdGhlCm5ldyBtYXB0cmFjayBlbnRyeSBhY3R1 YWxseSBnZXRzIHBvcHVsYXRlZC4KCkFzIGEgbmljZSBzaWRlIGVmZmVjdCB0 aGlzIGFsc28gcmVkdWNlcyB0aGUgbnVtYmVyIG9mIElPTU1VIG9wZXJhdGlv bnMKaW4gdW5tYXBfY29tbW9uKCk6IFByZXZpb3VzbHkgd2Ugd291bGQgaGF2 ZSAiZXN0YWJsaXNoZWQiIGEgcmVhZGFibGUKbWFwcGluZyB3aGVuZXZlciB3 ZSBkaWRuJ3QgZmluZCBhIHdyaXRhYmxlIGVudHJ5IGFueW1vcmUgKHlldCwg b2YKY291cnNlLCBhdCBsZWFzdCBvbmUgcmVhZGFibGUgb25lKS4gQnV0IHdl IG9ubHkgbmVlZCB0byBkbyB0aGlzIGlmIHdlCmFjdHVhbGx5IGRyb3BwZWQg dGhlIGxhc3Qgd3JpdGFibGUgZW50cnksIG5vdCBpZiB0aGVyZSB3ZXJlIG5v bmUgYWxyZWFkeQpiZWZvcmUuCgpUaGlzIGlzIHBhcnQgb2YgQ1ZFLTIwMjEt Mjg2OTggLyBYU0EtMzgwLgoKU2lnbmVkLW9mZi1ieTogSmFuIEJldWxpY2gg PGpiZXVsaWNoQHN1c2UuY29tPgpSZXZpZXdlZC1ieTogSnVsaWVuIEdyYWxs IDxqZ3JhbGxAYW1hem9uLmNvbT4KCi0tLSBhL3hlbi9jb21tb24vZ3JhbnRf dGFibGUuYworKysgYi94ZW4vY29tbW9uL2dyYW50X3RhYmxlLmMKQEAgLTM2 LDYgKzM2LDcgQEAKICNpbmNsdWRlIDx4ZW4vaW9tbXUuaD4KICNpbmNsdWRl IDx4ZW4vcGFnaW5nLmg+CiAjaW5jbHVkZSA8eGVuL2tleWhhbmRsZXIuaD4K KyNpbmNsdWRlIDx4ZW4vcmFkaXgtdHJlZS5oPgogI2luY2x1ZGUgPHhlbi92 bWFwLmg+CiAjaW5jbHVkZSA8eHNtL3hzbS5oPgogI2luY2x1ZGUgPGFzbS9m bHVzaHRsYi5oPgpAQCAtODAsOCArODEsMTMgQEAgc3RydWN0IGdyYW50X3Rh YmxlIHsKICAgICBncmFudF9zdGF0dXNfdCAgICAgICAqKnN0YXR1czsKICAg ICAvKiBBY3RpdmUgZ3JhbnQgdGFibGUuICovCiAgICAgc3RydWN0IGFjdGl2 ZV9ncmFudF9lbnRyeSAqKmFjdGl2ZTsKLSAgICAvKiBNYXBwaW5nIHRyYWNr aW5nIHRhYmxlIHBlciB2Y3B1LiAqLworICAgIC8qIEhhbmRsZS1pbmRleGVk IHRyYWNraW5nIHRhYmxlIG9mIG1hcHBpbmdzLiAqLwogICAgIHN0cnVjdCBn cmFudF9tYXBwaW5nICoqbWFwdHJhY2s7CisgICAgLyoKKyAgICAgKiBNRk4t aW5kZXhlZCB0cmFja2luZyB0cmVlIG9mIG1hcHBpbmdzLCBpZiBuZWVkZWQu ICBOb3RlIHRoYXQgdGhpcyBpcworICAgICAqIHByb3RlY3RlZCBieSBAbG9j aywgbm90IEBtYXB0cmFja19sb2NrLgorICAgICAqLworICAgIHN0cnVjdCBy YWRpeF90cmVlX3Jvb3QgbWFwdHJhY2tfdHJlZTsKIAogICAgIC8qIERvbWFp biB0byB3aGljaCB0aGlzIHN0cnVjdCBncmFudF90YWJsZSBiZWxvbmdzLiAq LwogICAgIGNvbnN0IHN0cnVjdCBkb21haW4gKmRvbWFpbjsKQEAgLTQyMSwz NCArNDI3LDYgQEAgc3RhdGljIGludCBnZXRfcGFnZWRfZnJhbWUodW5zaWdu ZWQgbG9uZwogICAgIHJldHVybiByYzsKIH0KIAotc3RhdGljIGlubGluZSB2 b2lkCi1kb3VibGVfZ3RfbG9jayhzdHJ1Y3QgZ3JhbnRfdGFibGUgKmxndCwg c3RydWN0IGdyYW50X3RhYmxlICpyZ3QpCi17Ci0gICAgLyoKLSAgICAgKiBT ZWUgbWFwa2luZCgpIGZvciB3aHkgdGhlIHdyaXRlIGxvY2sgaXMgYWxzbyBy ZXF1aXJlZCBmb3IgdGhlCi0gICAgICogcmVtb3RlIGRvbWFpbi4KLSAgICAg Ki8KLSAgICBpZiAoIGxndCA8IHJndCApCi0gICAgewotICAgICAgICBncmFu dF93cml0ZV9sb2NrKGxndCk7Ci0gICAgICAgIGdyYW50X3dyaXRlX2xvY2so cmd0KTsKLSAgICB9Ci0gICAgZWxzZQotICAgIHsKLSAgICAgICAgaWYgKCBs Z3QgIT0gcmd0ICkKLSAgICAgICAgICAgIGdyYW50X3dyaXRlX2xvY2socmd0 KTsKLSAgICAgICAgZ3JhbnRfd3JpdGVfbG9jayhsZ3QpOwotICAgIH0KLX0K LQotc3RhdGljIGlubGluZSB2b2lkCi1kb3VibGVfZ3RfdW5sb2NrKHN0cnVj dCBncmFudF90YWJsZSAqbGd0LCBzdHJ1Y3QgZ3JhbnRfdGFibGUgKnJndCkK LXsKLSAgICBncmFudF93cml0ZV91bmxvY2sobGd0KTsKLSAgICBpZiAoIGxn dCAhPSByZ3QgKQotICAgICAgICBncmFudF93cml0ZV91bmxvY2socmd0KTsK LX0KLQogI2RlZmluZSBJTlZBTElEX01BUFRSQUNLX0hBTkRMRSBVSU5UX01B WAogCiBzdGF0aWMgaW5saW5lIGdyYW50X2hhbmRsZV90CkBAIC04NzEsNDEg Kzg0OSwxNyBAQCBzdGF0aWMgc3RydWN0IGFjdGl2ZV9ncmFudF9lbnRyeSAq Z3JhbnRfCiAgICAgcmV0dXJuIEVSUl9QVFIoLUVJTlZBTCk7CiB9CiAKLSNk ZWZpbmUgTUFQS0lORF9SRUFEIDEKLSNkZWZpbmUgTUFQS0lORF9XUklURSAy Ci1zdGF0aWMgdW5zaWduZWQgaW50IG1hcGtpbmQoCi0gICAgc3RydWN0IGdy YW50X3RhYmxlICpsZ3QsIGNvbnN0IHN0cnVjdCBkb21haW4gKnJkLCBtZm5f dCBtZm4pCi17Ci0gICAgc3RydWN0IGdyYW50X21hcHBpbmcgKm1hcDsKLSAg ICBncmFudF9oYW5kbGVfdCBoYW5kbGUsIGxpbWl0ID0gbGd0LT5tYXB0cmFj a19saW1pdDsKLSAgICB1bnNpZ25lZCBpbnQga2luZCA9IDA7Ci0KLSAgICAv KgotICAgICAqIE11c3QgaGF2ZSB0aGUgbG9jYWwgZG9tYWluJ3MgZ3JhbnQg dGFibGUgd3JpdGUgbG9jayB3aGVuCi0gICAgICogaXRlcmF0aW5nIG92ZXIg aXRzIG1hcHRyYWNrIGVudHJpZXMuCi0gICAgICovCi0gICAgQVNTRVJUKHBl cmNwdV9yd19pc193cml0ZV9sb2NrZWQoJmxndC0+bG9jaykpOwotICAgIC8q Ci0gICAgICogTXVzdCBoYXZlIHRoZSByZW1vdGUgZG9tYWluJ3MgZ3JhbnQg dGFibGUgd3JpdGUgbG9jayB3aGlsZQotICAgICAqIGNvdW50aW5nIGl0cyBh Y3RpdmUgZW50cmllcy4KLSAgICAgKi8KLSAgICBBU1NFUlQocGVyY3B1X3J3 X2lzX3dyaXRlX2xvY2tlZCgmcmQtPmdyYW50X3RhYmxlLT5sb2NrKSk7Ci0K LSAgICBzbXBfcm1iKCk7Ci0KLSAgICBmb3IgKCBoYW5kbGUgPSAwOyAhKGtp bmQgJiBNQVBLSU5EX1dSSVRFKSAmJiBoYW5kbGUgPCBsaW1pdDsgaGFuZGxl KysgKQotICAgIHsKLSAgICAgICAgbWFwID0gJm1hcHRyYWNrX2VudHJ5KGxn dCwgaGFuZGxlKTsKLSAgICAgICAgaWYgKCAhKG1hcC0+ZmxhZ3MgJiAoR05U TUFQX2RldmljZV9tYXB8R05UTUFQX2hvc3RfbWFwKSkgfHwKLSAgICAgICAg ICAgICBtYXAtPmRvbWlkICE9IHJkLT5kb21haW5faWQgKQotICAgICAgICAg ICAgY29udGludWU7Ci0gICAgICAgIGlmICggbWZuX2VxKF9hY3RpdmVfZW50 cnkocmQtPmdyYW50X3RhYmxlLCBtYXAtPnJlZikuZnJhbWUsIG1mbikgKQot ICAgICAgICAgICAga2luZCB8PSBtYXAtPmZsYWdzICYgR05UTUFQX3JlYWRv bmx5ID8KLSAgICAgICAgICAgICAgICAgICAgTUFQS0lORF9SRUFEIDogTUFQ S0lORF9XUklURTsKLSAgICB9Ci0KLSAgICByZXR1cm4ga2luZDsKLX0KK3Vu aW9uIG1hcHRyYWNrX25vZGUgeworICAgIHN0cnVjdCB7CisgICAgICAgIC8q IFJhZGl4IHRyZWUgc2xvdCBwb2ludGVycyB1c2UgdHdvIG9mIHRoZSBiaXRz LiAqLworI2lmZGVmIF9fQklHX0VORElBTl9CSVRGSUVMRAorICAgICAgICB1 bnNpZ25lZCBsb25nICAgIDogMjsKKyNlbmRpZgorICAgICAgICB1bnNpZ25l ZCBsb25nIHJkIDogQklUU19QRVJfTE9ORyAvIDIgLSAxOworICAgICAgICB1 bnNpZ25lZCBsb25nIHdyIDogQklUU19QRVJfTE9ORyAvIDIgLSAxOworICAg IH0gY250OworICAgIHVuc2lnbmVkIGxvbmcgcmF3OworfTsKIAogLyoKICAq IFJldHVybnMgMCBpZiBUTEIgZmx1c2ggLyBpbnZhbGlkYXRlIHJlcXVpcmVk IGJ5IGNhbGxlci4KQEAgLTkzMSw3ICs4ODUsNiBAQCBtYXBfZ3JhbnRfcmVm KAogICAgIHN0cnVjdCBncmFudF9tYXBwaW5nICptdDsKICAgICBncmFudF9l bnRyeV9oZWFkZXJfdCAqc2hhaDsKICAgICB1aW50MTZfdCAqc3RhdHVzOwot ICAgIGJvb2xfdCBuZWVkX2lvbW11OwogCiAgICAgbGVkID0gY3VycmVudDsK ICAgICBsZCA9IGxlZC0+ZG9tYWluOwpAQCAtMTEzOSwzMSArMTA5Miw3NSBA QCBtYXBfZ3JhbnRfcmVmKAogICAgICAgICBnb3RvIHVuZG9fb3V0OwogICAg IH0KIAotICAgIG5lZWRfaW9tbXUgPSBnbnR0YWJfbmVlZF9pb21tdV9tYXBw aW5nKGxkKTsKLSAgICBpZiAoIG5lZWRfaW9tbXUgKQorICAgIGlmICggZ250 dGFiX25lZWRfaW9tbXVfbWFwcGluZyhsZCkgKQogICAgIHsKKyAgICAgICAg dW5pb24gbWFwdHJhY2tfbm9kZSBub2RlID0geworICAgICAgICAgICAgLmNu dC5yZCA9ICEhKG9wLT5mbGFncyAmIEdOVE1BUF9yZWFkb25seSksCisgICAg ICAgICAgICAuY250LndyID0gIShvcC0+ZmxhZ3MgJiBHTlRNQVBfcmVhZG9u bHkpLAorICAgICAgICB9OworICAgICAgICBpbnQgZXJyOworICAgICAgICB2 b2lkICoqc2xvdCA9IE5VTEw7CiAgICAgICAgIHVuc2lnbmVkIGludCBraW5k OwogCi0gICAgICAgIGRvdWJsZV9ndF9sb2NrKGxndCwgcmd0KTsKKyAgICAg ICAgZ3JhbnRfd3JpdGVfbG9jayhsZ3QpOworCisgICAgICAgIGVyciA9IHJh ZGl4X3RyZWVfaW5zZXJ0KCZsZ3QtPm1hcHRyYWNrX3RyZWUsIG1mbl94KGZy YW1lKSwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcmFkaXhf dHJlZV91bG9uZ190b19wdHIobm9kZS5yYXcpKTsKKyAgICAgICAgaWYgKCBl cnIgPT0gLUVFWElTVCApCisgICAgICAgIHsKKyAgICAgICAgICAgIHNsb3Qg PSByYWRpeF90cmVlX2xvb2t1cF9zbG90KCZsZ3QtPm1hcHRyYWNrX3RyZWUs IG1mbl94KGZyYW1lKSk7CisgICAgICAgICAgICBpZiAoIGxpa2VseShzbG90 KSApCisgICAgICAgICAgICB7CisgICAgICAgICAgICAgICAgbm9kZS5yYXcg PSByYWRpeF90cmVlX3B0cl90b191bG9uZygqc2xvdCk7CisgICAgICAgICAg ICAgICAgZXJyID0gLUVCVVNZOworCisgICAgICAgICAgICAgICAgLyogVXBk YXRlIG5vZGUgb25seSB3aGVuIHJlZmNvdW50IGRvZXNuJ3Qgb3ZlcmZsb3cu ICovCisgICAgICAgICAgICAgICAgaWYgKCBvcC0+ZmxhZ3MgJiBHTlRNQVBf cmVhZG9ubHkgPyArK25vZGUuY250LnJkCisgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgOiArK25vZGUuY250Lndy ICkKKyAgICAgICAgICAgICAgICB7CisgICAgICAgICAgICAgICAgICAgIHJh ZGl4X3RyZWVfcmVwbGFjZV9zbG90KHNsb3QsCisgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIHJhZGl4X3RyZWVfdWxvbmdf dG9fcHRyKG5vZGUucmF3KSk7CisgICAgICAgICAgICAgICAgICAgIGVyciA9 IDA7CisgICAgICAgICAgICAgICAgfQorICAgICAgICAgICAgfQorICAgICAg ICAgICAgZWxzZQorICAgICAgICAgICAgICAgIEFTU0VSVF9VTlJFQUNIQUJM RSgpOworICAgICAgICB9CiAKICAgICAgICAgLyoKICAgICAgICAgICogV2Un cmUgbm90IHRyYW5zbGF0ZWQsIHNvIHdlIGtub3cgdGhhdCBkZm5zIGFuZCBt Zm5zIGFyZQogICAgICAgICAgKiB0aGUgc2FtZSB0aGluZ3MsIHNvIHRoZSBJ T01NVSBlbnRyeSBpcyBhbHdheXMgMS10by0xLgogICAgICAgICAgKi8KLSAg ICAgICAga2luZCA9IG1hcGtpbmQobGd0LCByZCwgZnJhbWUpOwotICAgICAg ICBpZiAoICEob3AtPmZsYWdzICYgR05UTUFQX3JlYWRvbmx5KSAmJgotICAg ICAgICAgICAgICEoa2luZCAmIE1BUEtJTkRfV1JJVEUpICkKKyAgICAgICAg aWYgKCAhKG9wLT5mbGFncyAmIEdOVE1BUF9yZWFkb25seSkgJiYgbm9kZS5j bnQud3IgPT0gMSApCiAgICAgICAgICAgICBraW5kID0gSU9NTVVGX3JlYWRh YmxlIHwgSU9NTVVGX3dyaXRhYmxlOwotICAgICAgICBlbHNlIGlmICggIWtp bmQgKQorICAgICAgICBlbHNlIGlmICggKG9wLT5mbGFncyAmIEdOVE1BUF9y ZWFkb25seSkgJiYKKyAgICAgICAgICAgICAgICAgIG5vZGUuY250LnJkID09 IDEgJiYgIW5vZGUuY250LndyICkKICAgICAgICAgICAgIGtpbmQgPSBJT01N VUZfcmVhZGFibGU7CiAgICAgICAgIGVsc2UKICAgICAgICAgICAgIGtpbmQg PSAwOwotICAgICAgICBpZiAoIGtpbmQgJiYgaW9tbXVfbWFwX3BhZ2UobGQs IG1mbl94KGZyYW1lKSwgbWZuX3goZnJhbWUpLCBraW5kKSApCisgICAgICAg IGlmICggZXJyIHx8CisgICAgICAgICAgICAgKGtpbmQgJiYgaW9tbXVfbWFw X3BhZ2UobGQsIG1mbl94KGZyYW1lKSwgbWZuX3goZnJhbWUpLCBraW5kKSkg KQogICAgICAgICB7Ci0gICAgICAgICAgICBkb3VibGVfZ3RfdW5sb2NrKGxn dCwgcmd0KTsKKyAgICAgICAgICAgIGlmICggIWVyciApCisgICAgICAgICAg ICB7CisgICAgICAgICAgICAgICAgaWYgKCBzbG90ICkKKyAgICAgICAgICAg ICAgICB7CisgICAgICAgICAgICAgICAgICAgIG9wLT5mbGFncyAmIEdOVE1B UF9yZWFkb25seSA/IG5vZGUuY250LnJkLS0KKyAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIDogbm9kZS5jbnQud3It LTsKKyAgICAgICAgICAgICAgICAgICAgcmFkaXhfdHJlZV9yZXBsYWNlX3Ns b3Qoc2xvdCwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgcmFkaXhfdHJlZV91bG9uZ190b19wdHIobm9kZS5yYXcpKTsK KyAgICAgICAgICAgICAgICB9CisgICAgICAgICAgICAgICAgZWxzZQorICAg ICAgICAgICAgICAgICAgICByYWRpeF90cmVlX2RlbGV0ZSgmbGd0LT5tYXB0 cmFja190cmVlLCBtZm5feChmcmFtZSkpOworICAgICAgICAgICAgfQorCiAg ICAgICAgICAgICByYyA9IEdOVFNUX2dlbmVyYWxfZXJyb3I7Ci0gICAgICAg ICAgICBnb3RvIHVuZG9fb3V0OwogICAgICAgICB9CisKKyAgICAgICAgZ3Jh bnRfd3JpdGVfdW5sb2NrKGxndCk7CisKKyAgICAgICAgaWYgKCByYyAhPSBH TlRTVF9va2F5ICkKKyAgICAgICAgICAgIGdvdG8gdW5kb19vdXQ7CiAgICAg fQogCiAgICAgVFJBQ0VfMUQoVFJDX01FTV9QQUdFX0dSQU5UX01BUCwgb3At PmRvbSk7CkBAIC0xMTcxLDEwICsxMTY4LDYgQEAgbWFwX2dyYW50X3JlZigK ICAgICAvKgogICAgICAqIEFsbCBtYXB0cmFjayBlbnRyeSB1c2VycyBjaGVj ayBtdC0+ZmxhZ3MgZmlyc3QgYmVmb3JlIHVzaW5nIHRoZQogICAgICAqIG90 aGVyIGZpZWxkcyBzbyBqdXN0IGVuc3VyZSB0aGUgZmxhZ3MgZmllbGQgaXMg c3RvcmVkIGxhc3QuCi0gICAgICoKLSAgICAgKiBIb3dldmVyLCBpZiBnbnR0 YWJfbmVlZF9pb21tdV9tYXBwaW5nKCkgdGhlbiB0aGlzIHdvdWxkIHJhY2UK LSAgICAgKiB3aXRoIGEgY29uY3VycmVudCBtYXBraW5kKCkgY2FsbCAob24g YW4gdW5tYXAsIGZvciBleGFtcGxlKQotICAgICAqIGFuZCBhIGxvY2sgaXMg cmVxdWlyZWQuCiAgICAgICovCiAgICAgbXQgPSAmbWFwdHJhY2tfZW50cnko bGd0LCBoYW5kbGUpOwogICAgIG10LT5kb21pZCA9IG9wLT5kb207CkBAIC0x MTgyLDkgKzExNzUsNiBAQCBtYXBfZ3JhbnRfcmVmKAogICAgIHNtcF93bWIo KTsKICAgICB3cml0ZV9hdG9taWMoJm10LT5mbGFncywgb3AtPmZsYWdzKTsK IAotICAgIGlmICggbmVlZF9pb21tdSApCi0gICAgICAgIGRvdWJsZV9ndF91 bmxvY2sobGd0LCByZ3QpOwotCiAgICAgb3AtPmRldl9idXNfYWRkciA9IG1m bl90b19tYWRkcihmcmFtZSk7CiAgICAgb3AtPmhhbmRsZSAgICAgICA9IGhh bmRsZTsKICAgICBvcC0+c3RhdHVzICAgICAgID0gR05UU1Rfb2theTsKQEAg LTE0MTEsMTkgKzE0MDEsMzQgQEAgdW5tYXBfY29tbW9uKAogCiAgICAgaWYg KCByYyA9PSBHTlRTVF9va2F5ICYmIGdudHRhYl9uZWVkX2lvbW11X21hcHBp bmcobGQpICkKICAgICB7Ci0gICAgICAgIHVuc2lnbmVkIGludCBraW5kOwor ICAgICAgICB2b2lkICoqc2xvdDsKKyAgICAgICAgdW5pb24gbWFwdHJhY2tf bm9kZSBub2RlOwogICAgICAgICBpbnQgZXJyID0gMDsKIAotICAgICAgICBk b3VibGVfZ3RfbG9jayhsZ3QsIHJndCk7CisgICAgICAgIGdyYW50X3dyaXRl X2xvY2sobGd0KTsKKyAgICAgICAgc2xvdCA9IHJhZGl4X3RyZWVfbG9va3Vw X3Nsb3QoJmxndC0+bWFwdHJhY2tfdHJlZSwgbWZuX3gob3AtPmZyYW1lKSk7 CisgICAgICAgIG5vZGUucmF3ID0gbGlrZWx5KHNsb3QpID8gcmFkaXhfdHJl ZV9wdHJfdG9fdWxvbmcoKnNsb3QpIDogMDsKKworICAgICAgICAvKiBSZWZj b3VudCBtdXN0IG5vdCB1bmRlcmZsb3cuICovCisgICAgICAgIGlmICggIShm bGFncyAmIEdOVE1BUF9yZWFkb25seSA/IG5vZGUuY250LnJkLS0KKyAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIDogbm9kZS5jbnQu d3ItLSkgKQorICAgICAgICAgICAgQlVHKCk7CiAKLSAgICAgICAga2luZCA9 IG1hcGtpbmQobGd0LCByZCwgb3AtPmZyYW1lKTsKLSAgICAgICAgaWYgKCAh a2luZCApCisgICAgICAgIGlmICggIW5vZGUucmF3ICkKICAgICAgICAgICAg IGVyciA9IGlvbW11X3VubWFwX3BhZ2UobGQsIG1mbl94KG9wLT5mcmFtZSkp OwotICAgICAgICBlbHNlIGlmICggIShraW5kICYgTUFQS0lORF9XUklURSkg KQorICAgICAgICBlbHNlIGlmICggIShmbGFncyAmIEdOVE1BUF9yZWFkb25s eSkgJiYgIW5vZGUuY250LndyICkKICAgICAgICAgICAgIGVyciA9IGlvbW11 X21hcF9wYWdlKGxkLCBtZm5feChvcC0+ZnJhbWUpLAogICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgbWZuX3gob3AtPmZyYW1lKSwgSU9NTVVG X3JlYWRhYmxlKTsKIAotICAgICAgICBkb3VibGVfZ3RfdW5sb2NrKGxndCwg cmd0KTsKKyAgICAgICAgaWYgKCBlcnIgKQorICAgICAgICAgICAgOworICAg ICAgICBlbHNlIGlmICggIW5vZGUucmF3ICkKKyAgICAgICAgICAgIHJhZGl4 X3RyZWVfZGVsZXRlKCZsZ3QtPm1hcHRyYWNrX3RyZWUsIG1mbl94KG9wLT5m cmFtZSkpOworICAgICAgICBlbHNlCisgICAgICAgICAgICByYWRpeF90cmVl X3JlcGxhY2Vfc2xvdChzbG90LAorICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgcmFkaXhfdHJlZV91bG9uZ190b19wdHIobm9kZS5yYXcp KTsKKworICAgICAgICBncmFudF93cml0ZV91bmxvY2sobGd0KTsKIAogICAg ICAgICBpZiAoIGVyciApCiAgICAgICAgICAgICByYyA9IEdOVFNUX2dlbmVy YWxfZXJyb3I7CkBAIC0xODU0LDYgKzE4NTksOCBAQCBncmFudF90YWJsZV9p bml0KHN0cnVjdCBkb21haW4gKmQsIHN0cnVjCiAgICAgICAgIGd0LT5tYXB0 cmFjayA9IHZ6YWxsb2MoZ3QtPm1heF9tYXB0cmFja19mcmFtZXMgKiBzaXpl b2YoKmd0LT5tYXB0cmFjaykpOwogICAgICAgICBpZiAoIGd0LT5tYXB0cmFj ayA9PSBOVUxMICkKICAgICAgICAgICAgIGdvdG8gb3V0OworCisgICAgICAg IHJhZGl4X3RyZWVfaW5pdCgmZ3QtPm1hcHRyYWNrX3RyZWUpOwogICAgIH0K IAogICAgIC8qIFNoYXJlZCBncmFudCB0YWJsZS4gKi8KQEAgLTM2NDMsNiAr MzY1MCw4IEBAIGludCBnbnR0YWJfcmVsZWFzZV9tYXBwaW5ncyhzdHJ1Y3Qg ZG9tYWkKIAogICAgIGZvciAoIGhhbmRsZSA9IGd0LT5tYXB0cmFja19saW1p dDsgaGFuZGxlOyApCiAgICAgeworICAgICAgICBtZm5fdCBtZm47CisKICAg ICAgICAgLyoKICAgICAgICAgICogRGVhbCB3aXRoIGZ1bGwgcGFnZXMgc3Vj aCB0aGF0IHRoZWlyIGZyZWVpbmcgKGluIHRoZSBib2R5IG9mIHRoZQogICAg ICAgICAgKiBpZigpKSByZW1haW5zIHNpbXBsZS4KQEAgLTM3NDQsMTcgKzM3 NTMsMzEgQEAgaW50IGdudHRhYl9yZWxlYXNlX21hcHBpbmdzKHN0cnVjdCBk b21haQogICAgICAgICBpZiAoIGFjdC0+cGluID09IDAgKQogICAgICAgICAg ICAgZ250dGFiX2NsZWFyX2ZsYWcocmQsIF9HVEZfcmVhZGluZywgc3RhdHVz KTsKIAorICAgICAgICBtZm4gPSBhY3QtPmZyYW1lOworCiAgICAgICAgIGFj dGl2ZV9lbnRyeV9yZWxlYXNlKGFjdCk7CiAgICAgICAgIGdyYW50X3JlYWRf dW5sb2NrKHJndCk7CiAKICAgICAgICAgcmN1X3VubG9ja19kb21haW4ocmQp OwogCiAgICAgICAgIG1hcC0+ZmxhZ3MgPSAwOworCisgICAgICAgIC8qCisg ICAgICAgICAqIFRoaXMgaXMgZXhjZXNzaXZlIGluIHRoYXQgYSBzaW5nbGUg c3VjaCBjYWxsIHdvdWxkIHN1ZmZpY2UgcGVyCisgICAgICAgICAqIG1hcHBl ZCBNRk4gKG9yIG5vbmUgYXQgYWxsLCBpZiBubyBlbnRyeSB3YXMgZXZlciBp bnNlcnRlZCkuIEJ1dCBpdAorICAgICAgICAgKiBzaG91bGQgYmUgdGhlIGNv bW1vbiBjYXNlIGZvciBhbiBNRk4gdG8gYmUgbWFwcGVkIGp1c3Qgb25jZSwg YW5kCisgICAgICAgICAqIHRoaXMgd2F5IHdlIGRvbid0IG5lZWQgdG8gZnVy dGhlciBtYWludGFpbiB0aGUgY291bnRlcnMuIFdlIGFsc28KKyAgICAgICAg ICogZG9uJ3Qgd2FudCB0byBsZWF2ZSBjbGVhbmluZyB1cCBvZiB0aGUgdHJl ZSBhcyBhIHdob2xlIHRvIHRoZSBlbmQKKyAgICAgICAgICogb2YgdGhlIGZ1 bmN0aW9uLCBhcyB0aGlzIGNvdWxkIHRha2UgcXVpdGUgc29tZSB0aW1lLgor ICAgICAgICAgKi8KKyAgICAgICAgcmFkaXhfdHJlZV9kZWxldGUoJmd0LT5t YXB0cmFja190cmVlLCBtZm5feChtZm4pKTsKICAgICB9CiAKICAgICBndC0+ bWFwdHJhY2tfbGltaXQgPSAwOwogICAgIEZSRUVfWEVOSEVBUF9QQUdFKGd0 LT5tYXB0cmFja1swXSk7CiAKKyAgICByYWRpeF90cmVlX2Rlc3Ryb3koJmd0 LT5tYXB0cmFja190cmVlLCBOVUxMKTsKKwogICAgIHJldHVybiAwOwogfQog Ci0tLSBhL3hlbi9pbmNsdWRlL3hlbi9yYWRpeC10cmVlLmgKKysrIGIveGVu L2luY2x1ZGUveGVuL3JhZGl4LXRyZWUuaApAQCAtMTkwLDYgKzE5MCwyNSBA QCBzdGF0aWMgaW5saW5lIGludCByYWRpeF90cmVlX3B0cl90b19pbnQoCiAg ICAgcmV0dXJuIChpbnQpKChsb25nKXB0ciA+PiAyKTsKIH0KIAorLyoqCisg KiByYWRpeF90cmVlX3t1bG9uZ190b19wdHIscHRyX3RvX3Vsb25nfToKKyAq CisgKiBTYW1lIGZvciB1bnNpZ25lZCBsb25nIHZhbHVlcy4gQmV3YXJlIHRo b3VnaCB0aGF0IG9ubHkgQklUU19QRVJfTE9ORy0yCisgKiBiaXRzIGFyZSBh Y3R1YWxseSB1c2FibGUgZm9yIHRoZSB2YWx1ZS4KKyAqLworc3RhdGljIGlu bGluZSB2b2lkICpyYWRpeF90cmVlX3Vsb25nX3RvX3B0cih1bnNpZ25lZCBs b25nIHZhbCkKK3sKKyAgICB1bnNpZ25lZCBsb25nIHB0ciA9ICh2YWwgPDwg MikgfCAweDI7CisgICAgQVNTRVJUKChwdHIgPj4gMikgPT0gdmFsKTsKKyAg ICByZXR1cm4gKHZvaWQgKilwdHI7Cit9CisKK3N0YXRpYyBpbmxpbmUgdW5z aWduZWQgbG9uZyByYWRpeF90cmVlX3B0cl90b191bG9uZyh2b2lkICpwdHIp Cit7CisgICAgQVNTRVJUKCgodW5zaWduZWQgbG9uZylwdHIgJiAweDMpID09 IDB4Mik7CisgICAgcmV0dXJuICh1bnNpZ25lZCBsb25nKXB0ciA+PiAyOwor fQorCiBpbnQgcmFkaXhfdHJlZV9pbnNlcnQoc3RydWN0IHJhZGl4X3RyZWVf cm9vdCAqLCB1bnNpZ25lZCBsb25nLCB2b2lkICopOwogdm9pZCAqcmFkaXhf dHJlZV9sb29rdXAoc3RydWN0IHJhZGl4X3RyZWVfcm9vdCAqLCB1bnNpZ25l ZCBsb25nKTsKIHZvaWQgKipyYWRpeF90cmVlX2xvb2t1cF9zbG90KHN0cnVj dCByYWRpeF90cmVlX3Jvb3QgKiwgdW5zaWduZWQgbG9uZyk7Cg== --=separator Content-Type: application/octet-stream; name="xsa380/xsa380-4.12-1.patch" Content-Disposition: attachment; filename="xsa380/xsa380-4.12-1.patch" Content-Transfer-Encoding: base64 RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0 OiBnbnR0YWI6IGFkZCBwcmVlbXB0aW9uIGNoZWNrIHRvIGdudHRhYl9yZWxl YXNlX21hcHBpbmdzKCkKCkEgZ3Vlc3QgbWF5IGRpZSB3aXRoIG1hbnkgZ3Jh bnQgbWFwcGluZ3Mgc3RpbGwgaW4gcGxhY2UsIG9yIHNpbXBseSB3aXRoCmEg bGFyZ2UgbWFwdHJhY2sgdGFibGUuIEl0ZXJhdGluZyB0aHJvdWdoIHRoaXMg bWF5IHRha2UgbW9yZSB0aW1lIHRoYW4KaXMgcmVhc29uYWJsZSB3aXRob3V0 IGludGVybWVkaWF0ZSBwcmVlbXB0aW9uICh0byBydW4gc29mdGlycXMgYW5k CnBlcmhhcHMgdGhlIHNjaGVkdWxlcikuCgpNb3ZlIHRoZSBpbnZvY2F0aW9u IG9mIHRoZSBmdW5jdGlvbiB0byB0aGUgc2VjdGlvbiB3aGVyZSBvdGhlcgpy ZXN0YXJ0YWJsZSBmdW5jdGlvbnMgZ2V0IGludm9rZWQsIGFuZCBoYXZlIHRo ZSBmdW5jdGlvbiBpdHNlbGYgY2hlY2sKZm9yIHByZWVtcHRpb24gZXZlcnkg b25jZSBpbiBhIHdoaWxlLiBIYXZlIGl0IGl0ZXJhdGUgdGhlIHRhYmxlCmJh Y2t3YXJkcywgc3VjaCB0aGF0IGRlY3JlYXNpbmcgdGhlIG1hcHRyYWNrIGxp bWl0IGlzIGFsbCBpdCB0YWtlcyB0bwpjb252ZXkgcmVzdGFydCBpbmZvcm1h dGlvbi4KCkluIGRvbWFpbl90ZWFyZG93bigpIGludHJvZHVjZSBQUk9HX25v bmUgc3VjaCB0aGF0IGluc2VydGluZyBhdCB0aGUKZnJvbnQgd2lsbCBiZSBl YXNpZXIgZ29pbmcgZm9yd2FyZC4KClRoaXMgaXMgcGFydCBvZiBDVkUtMjAy MS0yODY5OCAvIFhTQS0zODAuCgpSZXBvcnRlZC1ieTogQW5kcmV3IENvb3Bl ciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNvbT4KU2lnbmVkLW9mZi1ieTog SmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpSZXZpZXdlZC1ieTog SnVsaWVuIEdyYWxsIDxqZ3JhbGxAYW1hem9uLmNvbT4KCi0tLSBhL3hlbi9j b21tb24vZG9tYWluLmMKKysrIGIveGVuL2NvbW1vbi9kb21haW4uYwpAQCAt NzI0LDEzICs3MjQsMTUgQEAgaW50IGRvbWFpbl9raWxsKHN0cnVjdCBkb21h aW4gKmQpCiAgICAgICAgICAgICByZXR1cm4gZG9tYWluX2tpbGwoZCk7CiAg ICAgICAgIGQtPmlzX2R5aW5nID0gRE9NRFlJTkdfZHlpbmc7CiAgICAgICAg IGFyZ29fZGVzdHJveShkKTsKLSAgICAgICAgZ250dGFiX3JlbGVhc2VfbWFw cGluZ3MoZCk7CiAgICAgICAgIHRtZW1fZGVzdHJveShkLT50bWVtX2NsaWVu dCk7CiAgICAgICAgIHZudW1hX2Rlc3Ryb3koZC0+dm51bWEpOwogICAgICAg ICBkb21haW5fc2V0X291dHN0YW5kaW5nX3BhZ2VzKGQsIDApOwogICAgICAg ICBkLT50bWVtX2NsaWVudCA9IE5VTEw7CiAgICAgICAgIC8qIGZhbGx0aHJv dWdoICovCiAgICAgY2FzZSBET01EWUlOR19keWluZzoKKyAgICAgICAgcmMg PSBnbnR0YWJfcmVsZWFzZV9tYXBwaW5ncyhkKTsKKyAgICAgICAgaWYgKCBy YyApCisgICAgICAgICAgICBicmVhazsKICAgICAgICAgcmMgPSBldnRjaG5f ZGVzdHJveShkKTsKICAgICAgICAgaWYgKCByYyApCiAgICAgICAgICAgICBi cmVhazsKLS0tIGEveGVuL2NvbW1vbi9ncmFudF90YWJsZS5jCisrKyBiL3hl bi9jb21tb24vZ3JhbnRfdGFibGUuYwpAQCAtNjIsNyArNjIsMTMgQEAgc3Ry dWN0IGdyYW50X3RhYmxlIHsKICAgICB1bnNpZ25lZCBpbnQgICAgICAgICAg bnJfZ3JhbnRfZnJhbWVzOwogICAgIC8qIE51bWJlciBvZiBncmFudCBzdGF0 dXMgZnJhbWVzIHNoYXJlZCB3aXRoIGd1ZXN0IChmb3IgdmVyc2lvbiAyKSAq LwogICAgIHVuc2lnbmVkIGludCAgICAgICAgICBucl9zdGF0dXNfZnJhbWVz OwotICAgIC8qIE51bWJlciBvZiBhdmFpbGFibGUgbWFwdHJhY2sgZW50cmll cy4gKi8KKyAgICAvKgorICAgICAqIE51bWJlciBvZiBhdmFpbGFibGUgbWFw dHJhY2sgZW50cmllcy4gIEZvciBjbGVhbnVwIHB1cnBvc2VzIGl0IGlzCisg ICAgICogaW1wb3J0YW50IHRvIHJlYWxpemUgdGhhdCB0aGlzIGZpZWxkIGFu ZCBAbWFwdHJhY2sgZnVydGhlciBkb3duIHdpbGwKKyAgICAgKiBvbmx5IGV2 ZXIgYmUgYWNjZXNzZWQgYnkgdGhlIGxvY2FsIGRvbWFpbi4gIFRodXMgaXQg aXMgb2theSB0byBjbGVhbgorICAgICAqIHVwIGVhcmx5LCBhbmQgdG8gc2hy aW5rIHRoZSBsaW1pdCBmb3IgdGhlIHB1cnBvc2Ugb2YgdHJhY2tpbmcgY2xl YW51cAorICAgICAqIHByb2dyZXNzLgorICAgICAqLwogICAgIHVuc2lnbmVk IGludCAgICAgICAgICBtYXB0cmFja19saW1pdDsKICAgICAvKiBTaGFyZWQg Z3JhbnQgdGFibGUgKHNlZSBpbmNsdWRlL3B1YmxpYy9ncmFudF90YWJsZS5o KS4gKi8KICAgICB1bmlvbiB7CkBAIC0zNjA0LDkgKzM2MTAsNyBAQCBkb19n cmFudF90YWJsZV9vcCgKICNpbmNsdWRlICJjb21wYXQvZ3JhbnRfdGFibGUu YyIKICNlbmRpZgogCi12b2lkCi1nbnR0YWJfcmVsZWFzZV9tYXBwaW5ncygK LSAgICBzdHJ1Y3QgZG9tYWluICpkKQoraW50IGdudHRhYl9yZWxlYXNlX21h cHBpbmdzKHN0cnVjdCBkb21haW4gKmQpCiB7CiAgICAgc3RydWN0IGdyYW50 X3RhYmxlICAgKmd0ID0gZC0+Z3JhbnRfdGFibGUsICpyZ3Q7CiAgICAgc3Ry dWN0IGdyYW50X21hcHBpbmcgKm1hcDsKQEAgLTM2MjAsOCArMzYyNCwzMiBA QCBnbnR0YWJfcmVsZWFzZV9tYXBwaW5ncygKIAogICAgIEJVR19PTighZC0+ aXNfZHlpbmcpOwogCi0gICAgZm9yICggaGFuZGxlID0gMDsgaGFuZGxlIDwg Z3QtPm1hcHRyYWNrX2xpbWl0OyBoYW5kbGUrKyApCisgICAgaWYgKCAhZ3Qg fHwgIWd0LT5tYXB0cmFjayApCisgICAgICAgIHJldHVybiAwOworCisgICAg Zm9yICggaGFuZGxlID0gZ3QtPm1hcHRyYWNrX2xpbWl0OyBoYW5kbGU7ICkK ICAgICB7CisgICAgICAgIC8qCisgICAgICAgICAqIERlYWwgd2l0aCBmdWxs IHBhZ2VzIHN1Y2ggdGhhdCB0aGVpciBmcmVlaW5nIChpbiB0aGUgYm9keSBv ZiB0aGUKKyAgICAgICAgICogaWYoKSkgcmVtYWlucyBzaW1wbGUuCisgICAg ICAgICAqLworICAgICAgICBpZiAoIGhhbmRsZSA8IGd0LT5tYXB0cmFja19s aW1pdCAmJiAhKGhhbmRsZSAlIE1BUFRSQUNLX1BFUl9QQUdFKSApCisgICAg ICAgIHsKKyAgICAgICAgICAgIC8qCisgICAgICAgICAgICAgKiBDaGFuZ2lu ZyBtYXB0cmFja19saW1pdCBhbHRlcnMgbnJfbWFwdHJhY2tfZnJhbWVzKCkn ZXMgcmV0dXJuCisgICAgICAgICAgICAgKiB2YWx1ZS4gRnJlZSB0aGUgdGhl biBleGNlc3MgdHJhaWxpbmcgcGFnZSByaWdodCBoZXJlLCByYXRoZXIKKyAg ICAgICAgICAgICAqIHRoYW4gbGVhdmluZyBpdCB0byBncmFudF90YWJsZV9k ZXN0cm95KCkgKGFuZCBpbiB0dXJuIHJlcXVpcmluZworICAgICAgICAgICAg ICogdG8gbGVhdmUgZ3QtPm1hcHRyYWNrX2xpbWl0IHVuYWx0ZXJlZCkuCisg ICAgICAgICAgICAgKi8KKyAgICAgICAgICAgIGd0LT5tYXB0cmFja19saW1p dCA9IGhhbmRsZTsKKyAgICAgICAgICAgIEZSRUVfWEVOSEVBUF9QQUdFKGd0 LT5tYXB0cmFja1tucl9tYXB0cmFja19mcmFtZXMoZ3QpXSk7CisKKyAgICAg ICAgICAgIGlmICggaHlwZXJjYWxsX3ByZWVtcHRfY2hlY2soKSApCisgICAg ICAgICAgICAgICAgcmV0dXJuIC1FUkVTVEFSVDsKKyAgICAgICAgfQorCisg ICAgICAgIC0taGFuZGxlOworCiAgICAgICAgIG1hcCA9ICZtYXB0cmFja19l bnRyeShndCwgaGFuZGxlKTsKICAgICAgICAgaWYgKCAhKG1hcC0+ZmxhZ3Mg JiAoR05UTUFQX2RldmljZV9tYXB8R05UTUFQX2hvc3RfbWFwKSkgKQogICAg ICAgICAgICAgY29udGludWU7CkBAIC0zNzA5LDYgKzM3MzcsMTEgQEAgZ250 dGFiX3JlbGVhc2VfbWFwcGluZ3MoCiAKICAgICAgICAgbWFwLT5mbGFncyA9 IDA7CiAgICAgfQorCisgICAgZ3QtPm1hcHRyYWNrX2xpbWl0ID0gMDsKKyAg ICBGUkVFX1hFTkhFQVBfUEFHRShndC0+bWFwdHJhY2tbMF0pOworCisgICAg cmV0dXJuIDA7CiB9CiAKIHZvaWQgZ3JhbnRfdGFibGVfd2Fybl9hY3RpdmVf Z3JhbnRzKHN0cnVjdCBkb21haW4gKmQpCkBAIC0zNzcxLDggKzM4MDQsNyBA QCBncmFudF90YWJsZV9kZXN0cm95KAogICAgICAgICBmcmVlX3hlbmhlYXBf cGFnZSh0LT5zaGFyZWRfcmF3W2ldKTsKICAgICB4ZnJlZSh0LT5zaGFyZWRf cmF3KTsKIAotICAgIGZvciAoIGkgPSAwOyBpIDwgbnJfbWFwdHJhY2tfZnJh bWVzKHQpOyBpKysgKQotICAgICAgICBmcmVlX3hlbmhlYXBfcGFnZSh0LT5t YXB0cmFja1tpXSk7CisgICAgQVNTRVJUKCF0LT5tYXB0cmFja19saW1pdCk7 CiAgICAgdmZyZWUodC0+bWFwdHJhY2spOwogCiAgICAgZm9yICggaSA9IDA7 IGkgPCBucl9hY3RpdmVfZ3JhbnRfZnJhbWVzKHQpOyBpKysgKQotLS0gYS94 ZW4vaW5jbHVkZS94ZW4vZ3JhbnRfdGFibGUuaAorKysgYi94ZW4vaW5jbHVk ZS94ZW4vZ3JhbnRfdGFibGUuaApAQCAtNDYsOSArNDYsNyBAQCB2b2lkIGdy YW50X3RhYmxlX2luaXRfdmNwdShzdHJ1Y3QgdmNwdSAqCiB2b2lkIGdyYW50 X3RhYmxlX3dhcm5fYWN0aXZlX2dyYW50cyhzdHJ1Y3QgZG9tYWluICpkKTsK IAogLyogRG9tYWluIGRlYXRoIHJlbGVhc2Ugb2YgZ3JhbnRlZCBtYXBwaW5n cyBvZiBvdGhlciBkb21haW5zJyBtZW1vcnkuICovCi12b2lkCi1nbnR0YWJf cmVsZWFzZV9tYXBwaW5ncygKLSAgICBzdHJ1Y3QgZG9tYWluICpkKTsKK2lu dCBnbnR0YWJfcmVsZWFzZV9tYXBwaW5ncyhzdHJ1Y3QgZG9tYWluICpkKTsK IAogaW50IG1lbV9zaGFyaW5nX2dyZWZfdG9fZ2ZuKHN0cnVjdCBncmFudF90 YWJsZSAqZ3QsIGdyYW50X3JlZl90IHJlZiwKICAgICAgICAgICAgICAgICAg ICAgICAgICAgICBnZm5fdCAqZ2ZuLCB1aW50MTZfdCAqc3RhdHVzKTsK --=separator Content-Type: application/octet-stream; name="xsa380/xsa380-4.12-2.patch" Content-Disposition: attachment; filename="xsa380/xsa380-4.12-2.patch" Content-Transfer-Encoding: base64 RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0 OiBnbnR0YWI6IHJlcGxhY2UgbWFwa2luZCgpCgptYXBraW5kKCkgZG9lc24n dCBzY2FsZSB2ZXJ5IHdlbGwgd2l0aCBsYXJnZXIgbWFwdHJhY2sgZW50cnkg Y291bnRzLAp1c2luZyBhIGJydXRlIGZvcmNlIGxpbmVhciBzZWFyY2ggdGhy b3VnaCBhbGwgZW50cmllcywgd2l0aCB0aGUgb25seQpvcHRpb24gb2YgYW4g ZWFybHkgbG9vcCBleGl0IGlmIGEgbWF0Y2hpbmcgd3JpdGFibGUgZW50cnkg d2FzIGZvdW5kLgpJbnRyb2R1Y2UgYSByYWRpeCB0cmVlIGFsb25nc2lkZSB0 aGUgbWFpbiBtYXB0cmFjayB0YWJsZSwgdGh1cwphbGxvd2luZyBtdWNoIGZh c3RlciBNRk4tYmFzZWQgbG9va3VwLiBUbyBhdm9pZCB0aGUgbmVlZCB0byBh Y3R1YWxseQphbGxvY2F0ZSBzcGFjZSBmb3IgdGhlIGluZGl2aWR1YWwgbm9k ZXMsIGVuY29kZSB0aGUgdHdvIGNvdW50ZXJzIGluIHRoZQpub2RlIHBvaW50 ZXJzIHRoZW1zZWx2ZXMsIHRodXMgbGltaXRpbmcgdGhlIG51bWJlciBvZiBw ZXJtaXR0ZWQKc2ltdWx0YW5lb3VzIHIvbyBhbmQgci93IG1hcHBpbmdzIG9m IHRoZSBzYW1lIE1GTiB0byAywrPCuS0xICg2NC1iaXQpIC8KMsK54oG1LTEg KDMyLWJpdCkgZWFjaC4KClRvIGF2b2lkIGVuZm9yY2luZyBhbiB1bm5lY2Vz c2FyaWx5IGxvdyBib3VuZCBvbiB0aGUgbnVtYmVyIG9mCnNpbXVsdGFuZW91 cyBtYXBwaW5ncyBvZiBhIHNpbmdsZSBNRk4sIGludHJvZHVjZQpyYWRpeF90 cmVlX3t1bG9uZ190b19wdHIscHRyX3RvX3Vsb25nfSBwYXJhbGxlbGluZwpy YWRpeF90cmVlX3tpbnRfdG9fcHRyLHB0cl90b19pbnR9LgoKQXMgYSBjb25z ZXF1ZW5jZSBsb2NraW5nIGNoYW5nZXMgYXJlIGFsc28gYXBwbGljYWJsZTog V2l0aCB0aGVyZSBubwpsb25nZXIgYmVpbmcgYW55IGluc3BlY3Rpb24gb2Yg dGhlIHJlbW90ZSBkb21haW4ncyBhY3RpdmUgZW50cmllcywKdGhlcmUncyBh bHNvIG5vIG5lZWQgYW55bW9yZSB0byBob2xkIHRoZSByZW1vdGUgZG9tYWlu J3MgZ3JhbnQgdGFibGUKbG9jay4gQW5kIHNpbmNlIHdlJ3JlIG5vIGxvbmdl ciBpdGVyYXRpbmcgb3ZlciB0aGUgbG9jYWwgZG9tYWluJ3MgbWFwCnRyYWNr IHRhYmxlLCB0aGUgbG9jayBpbiBtYXBfZ3JhbnRfcmVmKCkgY2FuIGFsc28g YmUgZHJvcHBlZCBiZWZvcmUgdGhlCm5ldyBtYXB0cmFjayBlbnRyeSBhY3R1 YWxseSBnZXRzIHBvcHVsYXRlZC4KCkFzIGEgbmljZSBzaWRlIGVmZmVjdCB0 aGlzIGFsc28gcmVkdWNlcyB0aGUgbnVtYmVyIG9mIElPTU1VIG9wZXJhdGlv bnMKaW4gdW5tYXBfY29tbW9uKCk6IFByZXZpb3VzbHkgd2Ugd291bGQgaGF2 ZSAiZXN0YWJsaXNoZWQiIGEgcmVhZGFibGUKbWFwcGluZyB3aGVuZXZlciB3 ZSBkaWRuJ3QgZmluZCBhIHdyaXRhYmxlIGVudHJ5IGFueW1vcmUgKHlldCwg b2YKY291cnNlLCBhdCBsZWFzdCBvbmUgcmVhZGFibGUgb25lKS4gQnV0IHdl IG9ubHkgbmVlZCB0byBkbyB0aGlzIGlmIHdlCmFjdHVhbGx5IGRyb3BwZWQg dGhlIGxhc3Qgd3JpdGFibGUgZW50cnksIG5vdCBpZiB0aGVyZSB3ZXJlIG5v bmUgYWxyZWFkeQpiZWZvcmUuCgpUaGlzIGlzIHBhcnQgb2YgQ1ZFLTIwMjEt Mjg2OTggLyBYU0EtMzgwLgoKU2lnbmVkLW9mZi1ieTogSmFuIEJldWxpY2gg PGpiZXVsaWNoQHN1c2UuY29tPgpSZXZpZXdlZC1ieTogSnVsaWVuIEdyYWxs IDxqZ3JhbGxAYW1hem9uLmNvbT4KCi0tLSBhL3hlbi9jb21tb24vZ3JhbnRf dGFibGUuYworKysgYi94ZW4vY29tbW9uL2dyYW50X3RhYmxlLmMKQEAgLTM2 LDYgKzM2LDcgQEAKICNpbmNsdWRlIDx4ZW4vaW9tbXUuaD4KICNpbmNsdWRl IDx4ZW4vcGFnaW5nLmg+CiAjaW5jbHVkZSA8eGVuL2tleWhhbmRsZXIuaD4K KyNpbmNsdWRlIDx4ZW4vcmFkaXgtdHJlZS5oPgogI2luY2x1ZGUgPHhlbi92 bWFwLmg+CiAjaW5jbHVkZSA8eHNtL3hzbS5oPgogI2luY2x1ZGUgPGFzbS9m bHVzaHRsYi5oPgpAQCAtODAsOCArODEsMTMgQEAgc3RydWN0IGdyYW50X3Rh YmxlIHsKICAgICBncmFudF9zdGF0dXNfdCAgICAgICAqKnN0YXR1czsKICAg ICAvKiBBY3RpdmUgZ3JhbnQgdGFibGUuICovCiAgICAgc3RydWN0IGFjdGl2 ZV9ncmFudF9lbnRyeSAqKmFjdGl2ZTsKLSAgICAvKiBNYXBwaW5nIHRyYWNr aW5nIHRhYmxlIHBlciB2Y3B1LiAqLworICAgIC8qIEhhbmRsZS1pbmRleGVk IHRyYWNraW5nIHRhYmxlIG9mIG1hcHBpbmdzLiAqLwogICAgIHN0cnVjdCBn cmFudF9tYXBwaW5nICoqbWFwdHJhY2s7CisgICAgLyoKKyAgICAgKiBNRk4t aW5kZXhlZCB0cmFja2luZyB0cmVlIG9mIG1hcHBpbmdzLCBpZiBuZWVkZWQu ICBOb3RlIHRoYXQgdGhpcyBpcworICAgICAqIHByb3RlY3RlZCBieSBAbG9j aywgbm90IEBtYXB0cmFja19sb2NrLgorICAgICAqLworICAgIHN0cnVjdCBy YWRpeF90cmVlX3Jvb3QgbWFwdHJhY2tfdHJlZTsKIAogICAgIC8qIERvbWFp biB0byB3aGljaCB0aGlzIHN0cnVjdCBncmFudF90YWJsZSBiZWxvbmdzLiAq LwogICAgIGNvbnN0IHN0cnVjdCBkb21haW4gKmRvbWFpbjsKQEAgLTQ0NSwz NCArNDUxLDYgQEAgc3RhdGljIGludCBnZXRfcGFnZWRfZnJhbWUodW5zaWdu ZWQgbG9uZwogICAgIHJldHVybiBHTlRTVF9va2F5OwogfQogCi1zdGF0aWMg aW5saW5lIHZvaWQKLWRvdWJsZV9ndF9sb2NrKHN0cnVjdCBncmFudF90YWJs ZSAqbGd0LCBzdHJ1Y3QgZ3JhbnRfdGFibGUgKnJndCkKLXsKLSAgICAvKgot ICAgICAqIFNlZSBtYXBraW5kKCkgZm9yIHdoeSB0aGUgd3JpdGUgbG9jayBp cyBhbHNvIHJlcXVpcmVkIGZvciB0aGUKLSAgICAgKiByZW1vdGUgZG9tYWlu LgotICAgICAqLwotICAgIGlmICggbGd0IDwgcmd0ICkKLSAgICB7Ci0gICAg ICAgIGdyYW50X3dyaXRlX2xvY2sobGd0KTsKLSAgICAgICAgZ3JhbnRfd3Jp dGVfbG9jayhyZ3QpOwotICAgIH0KLSAgICBlbHNlCi0gICAgewotICAgICAg ICBpZiAoIGxndCAhPSByZ3QgKQotICAgICAgICAgICAgZ3JhbnRfd3JpdGVf bG9jayhyZ3QpOwotICAgICAgICBncmFudF93cml0ZV9sb2NrKGxndCk7Ci0g ICAgfQotfQotCi1zdGF0aWMgaW5saW5lIHZvaWQKLWRvdWJsZV9ndF91bmxv Y2soc3RydWN0IGdyYW50X3RhYmxlICpsZ3QsIHN0cnVjdCBncmFudF90YWJs ZSAqcmd0KQotewotICAgIGdyYW50X3dyaXRlX3VubG9jayhsZ3QpOwotICAg IGlmICggbGd0ICE9IHJndCApCi0gICAgICAgIGdyYW50X3dyaXRlX3VubG9j ayhyZ3QpOwotfQotCiAjZGVmaW5lIElOVkFMSURfTUFQVFJBQ0tfSEFORExF IFVJTlRfTUFYCiAKIHN0YXRpYyBpbmxpbmUgZ3JhbnRfaGFuZGxlX3QKQEAg LTg5NSw0MSArODczLDE3IEBAIHN0YXRpYyBzdHJ1Y3QgYWN0aXZlX2dyYW50 X2VudHJ5ICpncmFudF8KICAgICByZXR1cm4gRVJSX1BUUigtRUlOVkFMKTsK IH0KIAotI2RlZmluZSBNQVBLSU5EX1JFQUQgMQotI2RlZmluZSBNQVBLSU5E X1dSSVRFIDIKLXN0YXRpYyB1bnNpZ25lZCBpbnQgbWFwa2luZCgKLSAgICBz dHJ1Y3QgZ3JhbnRfdGFibGUgKmxndCwgY29uc3Qgc3RydWN0IGRvbWFpbiAq cmQsIG1mbl90IG1mbikKLXsKLSAgICBzdHJ1Y3QgZ3JhbnRfbWFwcGluZyAq bWFwOwotICAgIGdyYW50X2hhbmRsZV90IGhhbmRsZSwgbGltaXQgPSBsZ3Qt Pm1hcHRyYWNrX2xpbWl0OwotICAgIHVuc2lnbmVkIGludCBraW5kID0gMDsK LQotICAgIC8qCi0gICAgICogTXVzdCBoYXZlIHRoZSBsb2NhbCBkb21haW4n cyBncmFudCB0YWJsZSB3cml0ZSBsb2NrIHdoZW4KLSAgICAgKiBpdGVyYXRp bmcgb3ZlciBpdHMgbWFwdHJhY2sgZW50cmllcy4KLSAgICAgKi8KLSAgICBB U1NFUlQocGVyY3B1X3J3X2lzX3dyaXRlX2xvY2tlZCgmbGd0LT5sb2NrKSk7 Ci0gICAgLyoKLSAgICAgKiBNdXN0IGhhdmUgdGhlIHJlbW90ZSBkb21haW4n cyBncmFudCB0YWJsZSB3cml0ZSBsb2NrIHdoaWxlCi0gICAgICogY291bnRp bmcgaXRzIGFjdGl2ZSBlbnRyaWVzLgotICAgICAqLwotICAgIEFTU0VSVChw ZXJjcHVfcndfaXNfd3JpdGVfbG9ja2VkKCZyZC0+Z3JhbnRfdGFibGUtPmxv Y2spKTsKLQotICAgIHNtcF9ybWIoKTsKLQotICAgIGZvciAoIGhhbmRsZSA9 IDA7ICEoa2luZCAmIE1BUEtJTkRfV1JJVEUpICYmIGhhbmRsZSA8IGxpbWl0 OyBoYW5kbGUrKyApCi0gICAgewotICAgICAgICBtYXAgPSAmbWFwdHJhY2tf ZW50cnkobGd0LCBoYW5kbGUpOwotICAgICAgICBpZiAoICEobWFwLT5mbGFn cyAmIChHTlRNQVBfZGV2aWNlX21hcHxHTlRNQVBfaG9zdF9tYXApKSB8fAot ICAgICAgICAgICAgIG1hcC0+ZG9taWQgIT0gcmQtPmRvbWFpbl9pZCApCi0g ICAgICAgICAgICBjb250aW51ZTsKLSAgICAgICAgaWYgKCBtZm5fZXEoX2Fj dGl2ZV9lbnRyeShyZC0+Z3JhbnRfdGFibGUsIG1hcC0+cmVmKS5tZm4sIG1m bikgKQotICAgICAgICAgICAga2luZCB8PSBtYXAtPmZsYWdzICYgR05UTUFQ X3JlYWRvbmx5ID8KLSAgICAgICAgICAgICAgICAgICAgTUFQS0lORF9SRUFE IDogTUFQS0lORF9XUklURTsKLSAgICB9Ci0KLSAgICByZXR1cm4ga2luZDsK LX0KK3VuaW9uIG1hcHRyYWNrX25vZGUgeworICAgIHN0cnVjdCB7CisgICAg ICAgIC8qIFJhZGl4IHRyZWUgc2xvdCBwb2ludGVycyB1c2UgdHdvIG9mIHRo ZSBiaXRzLiAqLworI2lmZGVmIF9fQklHX0VORElBTl9CSVRGSUVMRAorICAg ICAgICB1bnNpZ25lZCBsb25nICAgIDogMjsKKyNlbmRpZgorICAgICAgICB1 bnNpZ25lZCBsb25nIHJkIDogQklUU19QRVJfTE9ORyAvIDIgLSAxOworICAg ICAgICB1bnNpZ25lZCBsb25nIHdyIDogQklUU19QRVJfTE9ORyAvIDIgLSAx OworICAgIH0gY250OworICAgIHVuc2lnbmVkIGxvbmcgcmF3OworfTsKIAog c3RhdGljIHZvaWQKIG1hcF9ncmFudF9yZWYoCkBAIC05NDgsNyArOTAyLDYg QEAgbWFwX2dyYW50X3JlZigKICAgICBzdHJ1Y3QgZ3JhbnRfbWFwcGluZyAq bXQ7CiAgICAgZ3JhbnRfZW50cnlfaGVhZGVyX3QgKnNoYWg7CiAgICAgdWlu dDE2X3QgKnN0YXR1czsKLSAgICBib29sX3QgbmVlZF9pb21tdTsKIAogICAg IGxlZCA9IGN1cnJlbnQ7CiAgICAgbGQgPSBsZWQtPmRvbWFpbjsKQEAgLTEx NTYsMzEgKzExMDksNzUgQEAgbWFwX2dyYW50X3JlZigKICAgICAgICAgZ290 byB1bmRvX291dDsKICAgICB9CiAKLSAgICBuZWVkX2lvbW11ID0gZ250dGFi X25lZWRfaW9tbXVfbWFwcGluZyhsZCk7Ci0gICAgaWYgKCBuZWVkX2lvbW11 ICkKKyAgICBpZiAoIGdudHRhYl9uZWVkX2lvbW11X21hcHBpbmcobGQpICkK ICAgICB7CisgICAgICAgIHVuaW9uIG1hcHRyYWNrX25vZGUgbm9kZSA9IHsK KyAgICAgICAgICAgIC5jbnQucmQgPSAhIShvcC0+ZmxhZ3MgJiBHTlRNQVBf cmVhZG9ubHkpLAorICAgICAgICAgICAgLmNudC53ciA9ICEob3AtPmZsYWdz ICYgR05UTUFQX3JlYWRvbmx5KSwKKyAgICAgICAgfTsKKyAgICAgICAgaW50 IGVycjsKKyAgICAgICAgdm9pZCAqKnNsb3QgPSBOVUxMOwogICAgICAgICB1 bnNpZ25lZCBpbnQga2luZDsKIAotICAgICAgICBkb3VibGVfZ3RfbG9jayhs Z3QsIHJndCk7CisgICAgICAgIGdyYW50X3dyaXRlX2xvY2sobGd0KTsKKwor ICAgICAgICBlcnIgPSByYWRpeF90cmVlX2luc2VydCgmbGd0LT5tYXB0cmFj a190cmVlLCBtZm5feChtZm4pLAorICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICByYWRpeF90cmVlX3Vsb25nX3RvX3B0cihub2RlLnJhdykpOwor ICAgICAgICBpZiAoIGVyciA9PSAtRUVYSVNUICkKKyAgICAgICAgeworICAg ICAgICAgICAgc2xvdCA9IHJhZGl4X3RyZWVfbG9va3VwX3Nsb3QoJmxndC0+ bWFwdHJhY2tfdHJlZSwgbWZuX3gobWZuKSk7CisgICAgICAgICAgICBpZiAo IGxpa2VseShzbG90KSApCisgICAgICAgICAgICB7CisgICAgICAgICAgICAg ICAgbm9kZS5yYXcgPSByYWRpeF90cmVlX3B0cl90b191bG9uZygqc2xvdCk7 CisgICAgICAgICAgICAgICAgZXJyID0gLUVCVVNZOworCisgICAgICAgICAg ICAgICAgLyogVXBkYXRlIG5vZGUgb25seSB3aGVuIHJlZmNvdW50IGRvZXNu J3Qgb3ZlcmZsb3cuICovCisgICAgICAgICAgICAgICAgaWYgKCBvcC0+Zmxh Z3MgJiBHTlRNQVBfcmVhZG9ubHkgPyArK25vZGUuY250LnJkCisgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgOiAr K25vZGUuY250LndyICkKKyAgICAgICAgICAgICAgICB7CisgICAgICAgICAg ICAgICAgICAgIHJhZGl4X3RyZWVfcmVwbGFjZV9zbG90KHNsb3QsCisgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHJhZGl4 X3RyZWVfdWxvbmdfdG9fcHRyKG5vZGUucmF3KSk7CisgICAgICAgICAgICAg ICAgICAgIGVyciA9IDA7CisgICAgICAgICAgICAgICAgfQorICAgICAgICAg ICAgfQorICAgICAgICAgICAgZWxzZQorICAgICAgICAgICAgICAgIEFTU0VS VF9VTlJFQUNIQUJMRSgpOworICAgICAgICB9CiAKICAgICAgICAgLyoKICAg ICAgICAgICogV2UncmUgbm90IHRyYW5zbGF0ZWQsIHNvIHdlIGtub3cgdGhh dCBkZm5zIGFuZCBtZm5zIGFyZQogICAgICAgICAgKiB0aGUgc2FtZSB0aGlu Z3MsIHNvIHRoZSBJT01NVSBlbnRyeSBpcyBhbHdheXMgMS10by0xLgogICAg ICAgICAgKi8KLSAgICAgICAga2luZCA9IG1hcGtpbmQobGd0LCByZCwgbWZu KTsKLSAgICAgICAgaWYgKCAhKG9wLT5mbGFncyAmIEdOVE1BUF9yZWFkb25s eSkgJiYKLSAgICAgICAgICAgICAhKGtpbmQgJiBNQVBLSU5EX1dSSVRFKSAp CisgICAgICAgIGlmICggIShvcC0+ZmxhZ3MgJiBHTlRNQVBfcmVhZG9ubHkp ICYmIG5vZGUuY250LndyID09IDEgKQogICAgICAgICAgICAga2luZCA9IElP TU1VRl9yZWFkYWJsZSB8IElPTU1VRl93cml0YWJsZTsKLSAgICAgICAgZWxz ZSBpZiAoICFraW5kICkKKyAgICAgICAgZWxzZSBpZiAoIChvcC0+ZmxhZ3Mg JiBHTlRNQVBfcmVhZG9ubHkpICYmCisgICAgICAgICAgICAgICAgICBub2Rl LmNudC5yZCA9PSAxICYmICFub2RlLmNudC53ciApCiAgICAgICAgICAgICBr aW5kID0gSU9NTVVGX3JlYWRhYmxlOwogICAgICAgICBlbHNlCiAgICAgICAg ICAgICBraW5kID0gMDsKLSAgICAgICAgaWYgKCBraW5kICYmIGlvbW11X2xl Z2FjeV9tYXAobGQsIF9kZm4obWZuX3gobWZuKSksIG1mbiwgMCwga2luZCkg KQorICAgICAgICBpZiAoIGVyciB8fAorICAgICAgICAgICAgIChraW5kICYm IGlvbW11X2xlZ2FjeV9tYXAobGQsIF9kZm4obWZuX3gobWZuKSksIG1mbiwg MCwga2luZCkpICkKICAgICAgICAgewotICAgICAgICAgICAgZG91YmxlX2d0 X3VubG9jayhsZ3QsIHJndCk7CisgICAgICAgICAgICBpZiAoICFlcnIgKQor ICAgICAgICAgICAgeworICAgICAgICAgICAgICAgIGlmICggc2xvdCApCisg ICAgICAgICAgICAgICAgeworICAgICAgICAgICAgICAgICAgICBvcC0+Zmxh Z3MgJiBHTlRNQVBfcmVhZG9ubHkgPyBub2RlLmNudC5yZC0tCisgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICA6IG5v ZGUuY250LndyLS07CisgICAgICAgICAgICAgICAgICAgIHJhZGl4X3RyZWVf cmVwbGFjZV9zbG90KHNsb3QsCisgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIHJhZGl4X3RyZWVfdWxvbmdfdG9fcHRyKG5v ZGUucmF3KSk7CisgICAgICAgICAgICAgICAgfQorICAgICAgICAgICAgICAg IGVsc2UKKyAgICAgICAgICAgICAgICAgICAgcmFkaXhfdHJlZV9kZWxldGUo JmxndC0+bWFwdHJhY2tfdHJlZSwgbWZuX3gobWZuKSk7CisgICAgICAgICAg ICB9CisKICAgICAgICAgICAgIHJjID0gR05UU1RfZ2VuZXJhbF9lcnJvcjsK LSAgICAgICAgICAgIGdvdG8gdW5kb19vdXQ7CiAgICAgICAgIH0KKworICAg ICAgICBncmFudF93cml0ZV91bmxvY2sobGd0KTsKKworICAgICAgICBpZiAo IHJjICE9IEdOVFNUX29rYXkgKQorICAgICAgICAgICAgZ290byB1bmRvX291 dDsKICAgICB9CiAKICAgICBUUkFDRV8xRChUUkNfTUVNX1BBR0VfR1JBTlRf TUFQLCBvcC0+ZG9tKTsKQEAgLTExODgsMTAgKzExODUsNiBAQCBtYXBfZ3Jh bnRfcmVmKAogICAgIC8qCiAgICAgICogQWxsIG1hcHRyYWNrIGVudHJ5IHVz ZXJzIGNoZWNrIG10LT5mbGFncyBmaXJzdCBiZWZvcmUgdXNpbmcgdGhlCiAg ICAgICogb3RoZXIgZmllbGRzIHNvIGp1c3QgZW5zdXJlIHRoZSBmbGFncyBm aWVsZCBpcyBzdG9yZWQgbGFzdC4KLSAgICAgKgotICAgICAqIEhvd2V2ZXIs IGlmIGdudHRhYl9uZWVkX2lvbW11X21hcHBpbmcoKSB0aGVuIHRoaXMgd291 bGQgcmFjZQotICAgICAqIHdpdGggYSBjb25jdXJyZW50IG1hcGtpbmQoKSBj YWxsIChvbiBhbiB1bm1hcCwgZm9yIGV4YW1wbGUpCi0gICAgICogYW5kIGEg bG9jayBpcyByZXF1aXJlZC4KICAgICAgKi8KICAgICBtdCA9ICZtYXB0cmFj a19lbnRyeShsZ3QsIGhhbmRsZSk7CiAgICAgbXQtPmRvbWlkID0gb3AtPmRv bTsKQEAgLTExOTksOSArMTE5Miw2IEBAIG1hcF9ncmFudF9yZWYoCiAgICAg c21wX3dtYigpOwogICAgIHdyaXRlX2F0b21pYygmbXQtPmZsYWdzLCBvcC0+ ZmxhZ3MpOwogCi0gICAgaWYgKCBuZWVkX2lvbW11ICkKLSAgICAgICAgZG91 YmxlX2d0X3VubG9jayhsZ3QsIHJndCk7Ci0KICAgICBvcC0+ZGV2X2J1c19h ZGRyID0gbWZuX3RvX21hZGRyKG1mbik7CiAgICAgb3AtPmhhbmRsZSAgICAg ICA9IGhhbmRsZTsKICAgICBvcC0+c3RhdHVzICAgICAgID0gR05UU1Rfb2th eTsKQEAgLTE0MTQsMTkgKzE0MDQsMzQgQEAgdW5tYXBfY29tbW9uKAogCiAg ICAgaWYgKCByYyA9PSBHTlRTVF9va2F5ICYmIGdudHRhYl9uZWVkX2lvbW11 X21hcHBpbmcobGQpICkKICAgICB7Ci0gICAgICAgIHVuc2lnbmVkIGludCBr aW5kOworICAgICAgICB2b2lkICoqc2xvdDsKKyAgICAgICAgdW5pb24gbWFw dHJhY2tfbm9kZSBub2RlOwogICAgICAgICBpbnQgZXJyID0gMDsKIAotICAg ICAgICBkb3VibGVfZ3RfbG9jayhsZ3QsIHJndCk7CisgICAgICAgIGdyYW50 X3dyaXRlX2xvY2sobGd0KTsKKyAgICAgICAgc2xvdCA9IHJhZGl4X3RyZWVf bG9va3VwX3Nsb3QoJmxndC0+bWFwdHJhY2tfdHJlZSwgbWZuX3gob3AtPm1m bikpOworICAgICAgICBub2RlLnJhdyA9IGxpa2VseShzbG90KSA/IHJhZGl4 X3RyZWVfcHRyX3RvX3Vsb25nKCpzbG90KSA6IDA7CisKKyAgICAgICAgLyog UmVmY291bnQgbXVzdCBub3QgdW5kZXJmbG93LiAqLworICAgICAgICBpZiAo ICEoZmxhZ3MgJiBHTlRNQVBfcmVhZG9ubHkgPyBub2RlLmNudC5yZC0tCisg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICA6IG5vZGUu Y250LndyLS0pICkKKyAgICAgICAgICAgIEJVRygpOwogCi0gICAgICAgIGtp bmQgPSBtYXBraW5kKGxndCwgcmQsIG9wLT5tZm4pOwotICAgICAgICBpZiAo ICFraW5kICkKKyAgICAgICAgaWYgKCAhbm9kZS5yYXcgKQogICAgICAgICAg ICAgZXJyID0gaW9tbXVfbGVnYWN5X3VubWFwKGxkLCBfZGZuKG1mbl94KG9w LT5tZm4pKSwgMCk7Ci0gICAgICAgIGVsc2UgaWYgKCAhKGtpbmQgJiBNQVBL SU5EX1dSSVRFKSApCisgICAgICAgIGVsc2UgaWYgKCAhKGZsYWdzICYgR05U TUFQX3JlYWRvbmx5KSAmJiAhbm9kZS5jbnQud3IgKQogICAgICAgICAgICAg ZXJyID0gaW9tbXVfbGVnYWN5X21hcChsZCwgX2RmbihtZm5feChvcC0+bWZu KSksIG9wLT5tZm4sIDAsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIElPTU1VRl9yZWFkYWJsZSk7CiAKLSAgICAgICAgZG91YmxlX2d0 X3VubG9jayhsZ3QsIHJndCk7CisgICAgICAgIGlmICggZXJyICkKKyAgICAg ICAgICAgIDsKKyAgICAgICAgZWxzZSBpZiAoICFub2RlLnJhdyApCisgICAg ICAgICAgICByYWRpeF90cmVlX2RlbGV0ZSgmbGd0LT5tYXB0cmFja190cmVl LCBtZm5feChvcC0+bWZuKSk7CisgICAgICAgIGVsc2UKKyAgICAgICAgICAg IHJhZGl4X3RyZWVfcmVwbGFjZV9zbG90KHNsb3QsCisgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICByYWRpeF90cmVlX3Vsb25nX3RvX3B0 cihub2RlLnJhdykpOworCisgICAgICAgIGdyYW50X3dyaXRlX3VubG9jayhs Z3QpOwogCiAgICAgICAgIGlmICggZXJyICkKICAgICAgICAgICAgIHJjID0g R05UU1RfZ2VuZXJhbF9lcnJvcjsKQEAgLTE4NzQsNiArMTg3OSw4IEBAIGlu dCBncmFudF90YWJsZV9pbml0KHN0cnVjdCBkb21haW4gKmQsIGkKICAgICAg ICAgZ3QtPm1hcHRyYWNrID0gdnphbGxvYyhndC0+bWF4X21hcHRyYWNrX2Zy YW1lcyAqIHNpemVvZigqZ3QtPm1hcHRyYWNrKSk7CiAgICAgICAgIGlmICgg Z3QtPm1hcHRyYWNrID09IE5VTEwgKQogICAgICAgICAgICAgZ290byBvdXQ7 CisKKyAgICAgICAgcmFkaXhfdHJlZV9pbml0KCZndC0+bWFwdHJhY2tfdHJl ZSk7CiAgICAgfQogCiAgICAgLyogU2hhcmVkIGdyYW50IHRhYmxlLiAqLwpA QCAtMzYyOSw2ICszNjM2LDggQEAgaW50IGdudHRhYl9yZWxlYXNlX21hcHBp bmdzKHN0cnVjdCBkb21haQogCiAgICAgZm9yICggaGFuZGxlID0gZ3QtPm1h cHRyYWNrX2xpbWl0OyBoYW5kbGU7ICkKICAgICB7CisgICAgICAgIG1mbl90 IG1mbjsKKwogICAgICAgICAvKgogICAgICAgICAgKiBEZWFsIHdpdGggZnVs bCBwYWdlcyBzdWNoIHRoYXQgdGhlaXIgZnJlZWluZyAoaW4gdGhlIGJvZHkg b2YgdGhlCiAgICAgICAgICAqIGlmKCkpIHJlbWFpbnMgc2ltcGxlLgpAQCAt MzczMCwxNyArMzczOSwzMSBAQCBpbnQgZ250dGFiX3JlbGVhc2VfbWFwcGlu Z3Moc3RydWN0IGRvbWFpCiAgICAgICAgIGlmICggYWN0LT5waW4gPT0gMCAp CiAgICAgICAgICAgICBnbnR0YWJfY2xlYXJfZmxhZyhyZCwgX0dURl9yZWFk aW5nLCBzdGF0dXMpOwogCisgICAgICAgIG1mbiA9IGFjdC0+bWZuOworCiAg ICAgICAgIGFjdGl2ZV9lbnRyeV9yZWxlYXNlKGFjdCk7CiAgICAgICAgIGdy YW50X3JlYWRfdW5sb2NrKHJndCk7CiAKICAgICAgICAgcmN1X3VubG9ja19k b21haW4ocmQpOwogCiAgICAgICAgIG1hcC0+ZmxhZ3MgPSAwOworCisgICAg ICAgIC8qCisgICAgICAgICAqIFRoaXMgaXMgZXhjZXNzaXZlIGluIHRoYXQg YSBzaW5nbGUgc3VjaCBjYWxsIHdvdWxkIHN1ZmZpY2UgcGVyCisgICAgICAg ICAqIG1hcHBlZCBNRk4gKG9yIG5vbmUgYXQgYWxsLCBpZiBubyBlbnRyeSB3 YXMgZXZlciBpbnNlcnRlZCkuIEJ1dCBpdAorICAgICAgICAgKiBzaG91bGQg YmUgdGhlIGNvbW1vbiBjYXNlIGZvciBhbiBNRk4gdG8gYmUgbWFwcGVkIGp1 c3Qgb25jZSwgYW5kCisgICAgICAgICAqIHRoaXMgd2F5IHdlIGRvbid0IG5l ZWQgdG8gZnVydGhlciBtYWludGFpbiB0aGUgY291bnRlcnMuIFdlIGFsc28K KyAgICAgICAgICogZG9uJ3Qgd2FudCB0byBsZWF2ZSBjbGVhbmluZyB1cCBv ZiB0aGUgdHJlZSBhcyBhIHdob2xlIHRvIHRoZSBlbmQKKyAgICAgICAgICog b2YgdGhlIGZ1bmN0aW9uLCBhcyB0aGlzIGNvdWxkIHRha2UgcXVpdGUgc29t ZSB0aW1lLgorICAgICAgICAgKi8KKyAgICAgICAgcmFkaXhfdHJlZV9kZWxl dGUoJmd0LT5tYXB0cmFja190cmVlLCBtZm5feChtZm4pKTsKICAgICB9CiAK ICAgICBndC0+bWFwdHJhY2tfbGltaXQgPSAwOwogICAgIEZSRUVfWEVOSEVB UF9QQUdFKGd0LT5tYXB0cmFja1swXSk7CiAKKyAgICByYWRpeF90cmVlX2Rl c3Ryb3koJmd0LT5tYXB0cmFja190cmVlLCBOVUxMKTsKKwogICAgIHJldHVy biAwOwogfQogCi0tLSBhL3hlbi9pbmNsdWRlL3hlbi9yYWRpeC10cmVlLmgK KysrIGIveGVuL2luY2x1ZGUveGVuL3JhZGl4LXRyZWUuaApAQCAtMTkwLDYg KzE5MCwyNSBAQCBzdGF0aWMgaW5saW5lIGludCByYWRpeF90cmVlX3B0cl90 b19pbnQoCiAgICAgcmV0dXJuIChpbnQpKChsb25nKXB0ciA+PiAyKTsKIH0K IAorLyoqCisgKiByYWRpeF90cmVlX3t1bG9uZ190b19wdHIscHRyX3RvX3Vs b25nfToKKyAqCisgKiBTYW1lIGZvciB1bnNpZ25lZCBsb25nIHZhbHVlcy4g QmV3YXJlIHRob3VnaCB0aGF0IG9ubHkgQklUU19QRVJfTE9ORy0yCisgKiBi aXRzIGFyZSBhY3R1YWxseSB1c2FibGUgZm9yIHRoZSB2YWx1ZS4KKyAqLwor c3RhdGljIGlubGluZSB2b2lkICpyYWRpeF90cmVlX3Vsb25nX3RvX3B0cih1 bnNpZ25lZCBsb25nIHZhbCkKK3sKKyAgICB1bnNpZ25lZCBsb25nIHB0ciA9 ICh2YWwgPDwgMikgfCAweDI7CisgICAgQVNTRVJUKChwdHIgPj4gMikgPT0g dmFsKTsKKyAgICByZXR1cm4gKHZvaWQgKilwdHI7Cit9CisKK3N0YXRpYyBp bmxpbmUgdW5zaWduZWQgbG9uZyByYWRpeF90cmVlX3B0cl90b191bG9uZyh2 b2lkICpwdHIpCit7CisgICAgQVNTRVJUKCgodW5zaWduZWQgbG9uZylwdHIg JiAweDMpID09IDB4Mik7CisgICAgcmV0dXJuICh1bnNpZ25lZCBsb25nKXB0 ciA+PiAyOworfQorCiBpbnQgcmFkaXhfdHJlZV9pbnNlcnQoc3RydWN0IHJh ZGl4X3RyZWVfcm9vdCAqLCB1bnNpZ25lZCBsb25nLCB2b2lkICopOwogdm9p ZCAqcmFkaXhfdHJlZV9sb29rdXAoc3RydWN0IHJhZGl4X3RyZWVfcm9vdCAq LCB1bnNpZ25lZCBsb25nKTsKIHZvaWQgKipyYWRpeF90cmVlX2xvb2t1cF9z bG90KHN0cnVjdCByYWRpeF90cmVlX3Jvb3QgKiwgdW5zaWduZWQgbG9uZyk7 Cg== --=separator Content-Type: application/octet-stream; name="xsa380/xsa380-4.13-1.patch" Content-Disposition: attachment; filename="xsa380/xsa380-4.13-1.patch" Content-Transfer-Encoding: base64 RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0 OiBnbnR0YWI6IGFkZCBwcmVlbXB0aW9uIGNoZWNrIHRvIGdudHRhYl9yZWxl YXNlX21hcHBpbmdzKCkKCkEgZ3Vlc3QgbWF5IGRpZSB3aXRoIG1hbnkgZ3Jh bnQgbWFwcGluZ3Mgc3RpbGwgaW4gcGxhY2UsIG9yIHNpbXBseSB3aXRoCmEg bGFyZ2UgbWFwdHJhY2sgdGFibGUuIEl0ZXJhdGluZyB0aHJvdWdoIHRoaXMg bWF5IHRha2UgbW9yZSB0aW1lIHRoYW4KaXMgcmVhc29uYWJsZSB3aXRob3V0 IGludGVybWVkaWF0ZSBwcmVlbXB0aW9uICh0byBydW4gc29mdGlycXMgYW5k CnBlcmhhcHMgdGhlIHNjaGVkdWxlcikuCgpNb3ZlIHRoZSBpbnZvY2F0aW9u IG9mIHRoZSBmdW5jdGlvbiB0byB0aGUgc2VjdGlvbiB3aGVyZSBvdGhlcgpy ZXN0YXJ0YWJsZSBmdW5jdGlvbnMgZ2V0IGludm9rZWQsIGFuZCBoYXZlIHRo ZSBmdW5jdGlvbiBpdHNlbGYgY2hlY2sKZm9yIHByZWVtcHRpb24gZXZlcnkg b25jZSBpbiBhIHdoaWxlLiBIYXZlIGl0IGl0ZXJhdGUgdGhlIHRhYmxlCmJh Y2t3YXJkcywgc3VjaCB0aGF0IGRlY3JlYXNpbmcgdGhlIG1hcHRyYWNrIGxp bWl0IGlzIGFsbCBpdCB0YWtlcyB0bwpjb252ZXkgcmVzdGFydCBpbmZvcm1h dGlvbi4KCkluIGRvbWFpbl90ZWFyZG93bigpIGludHJvZHVjZSBQUk9HX25v bmUgc3VjaCB0aGF0IGluc2VydGluZyBhdCB0aGUKZnJvbnQgd2lsbCBiZSBl YXNpZXIgZ29pbmcgZm9yd2FyZC4KClRoaXMgaXMgcGFydCBvZiBDVkUtMjAy MS0yODY5OCAvIFhTQS0zODAuCgpSZXBvcnRlZC1ieTogQW5kcmV3IENvb3Bl ciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNvbT4KU2lnbmVkLW9mZi1ieTog SmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpSZXZpZXdlZC1ieTog SnVsaWVuIEdyYWxsIDxqZ3JhbGxAYW1hem9uLmNvbT4KCi0tLSBhL3hlbi9j b21tb24vZG9tYWluLmMKKysrIGIveGVuL2NvbW1vbi9kb21haW4uYwpAQCAt Nzc2LDExICs3NzYsMTMgQEAgaW50IGRvbWFpbl9raWxsKHN0cnVjdCBkb21h aW4gKmQpCiAgICAgICAgICAgICByZXR1cm4gZG9tYWluX2tpbGwoZCk7CiAg ICAgICAgIGQtPmlzX2R5aW5nID0gRE9NRFlJTkdfZHlpbmc7CiAgICAgICAg IGFyZ29fZGVzdHJveShkKTsKLSAgICAgICAgZ250dGFiX3JlbGVhc2VfbWFw cGluZ3MoZCk7CiAgICAgICAgIHZudW1hX2Rlc3Ryb3koZC0+dm51bWEpOwog ICAgICAgICBkb21haW5fc2V0X291dHN0YW5kaW5nX3BhZ2VzKGQsIDApOwog ICAgICAgICAvKiBmYWxsdGhyb3VnaCAqLwogICAgIGNhc2UgRE9NRFlJTkdf ZHlpbmc6CisgICAgICAgIHJjID0gZ250dGFiX3JlbGVhc2VfbWFwcGluZ3Mo ZCk7CisgICAgICAgIGlmICggcmMgKQorICAgICAgICAgICAgYnJlYWs7CiAg ICAgICAgIHJjID0gZXZ0Y2huX2Rlc3Ryb3koZCk7CiAgICAgICAgIGlmICgg cmMgKQogICAgICAgICAgICAgYnJlYWs7Ci0tLSBhL3hlbi9jb21tb24vZ3Jh bnRfdGFibGUuYworKysgYi94ZW4vY29tbW9uL2dyYW50X3RhYmxlLmMKQEAg LTYzLDcgKzYzLDEzIEBAIHN0cnVjdCBncmFudF90YWJsZSB7CiAgICAgdW5z aWduZWQgaW50ICAgICAgICAgIG5yX2dyYW50X2ZyYW1lczsKICAgICAvKiBO dW1iZXIgb2YgZ3JhbnQgc3RhdHVzIGZyYW1lcyBzaGFyZWQgd2l0aCBndWVz dCAoZm9yIHZlcnNpb24gMikgKi8KICAgICB1bnNpZ25lZCBpbnQgICAgICAg ICAgbnJfc3RhdHVzX2ZyYW1lczsKLSAgICAvKiBOdW1iZXIgb2YgYXZhaWxh YmxlIG1hcHRyYWNrIGVudHJpZXMuICovCisgICAgLyoKKyAgICAgKiBOdW1i ZXIgb2YgYXZhaWxhYmxlIG1hcHRyYWNrIGVudHJpZXMuICBGb3IgY2xlYW51 cCBwdXJwb3NlcyBpdCBpcworICAgICAqIGltcG9ydGFudCB0byByZWFsaXpl IHRoYXQgdGhpcyBmaWVsZCBhbmQgQG1hcHRyYWNrIGZ1cnRoZXIgZG93biB3 aWxsCisgICAgICogb25seSBldmVyIGJlIGFjY2Vzc2VkIGJ5IHRoZSBsb2Nh bCBkb21haW4uICBUaHVzIGl0IGlzIG9rYXkgdG8gY2xlYW4KKyAgICAgKiB1 cCBlYXJseSwgYW5kIHRvIHNocmluayB0aGUgbGltaXQgZm9yIHRoZSBwdXJw b3NlIG9mIHRyYWNraW5nIGNsZWFudXAKKyAgICAgKiBwcm9ncmVzcy4KKyAg ICAgKi8KICAgICB1bnNpZ25lZCBpbnQgICAgICAgICAgbWFwdHJhY2tfbGlt aXQ7CiAgICAgLyogU2hhcmVkIGdyYW50IHRhYmxlIChzZWUgaW5jbHVkZS9w dWJsaWMvZ3JhbnRfdGFibGUuaCkuICovCiAgICAgdW5pb24gewpAQCAtMzY3 NSw5ICszNjgxLDcgQEAgZG9fZ3JhbnRfdGFibGVfb3AoCiAjaW5jbHVkZSAi Y29tcGF0L2dyYW50X3RhYmxlLmMiCiAjZW5kaWYKIAotdm9pZAotZ250dGFi X3JlbGVhc2VfbWFwcGluZ3MoCi0gICAgc3RydWN0IGRvbWFpbiAqZCkKK2lu dCBnbnR0YWJfcmVsZWFzZV9tYXBwaW5ncyhzdHJ1Y3QgZG9tYWluICpkKQog ewogICAgIHN0cnVjdCBncmFudF90YWJsZSAgICpndCA9IGQtPmdyYW50X3Rh YmxlLCAqcmd0OwogICAgIHN0cnVjdCBncmFudF9tYXBwaW5nICptYXA7CkBA IC0zNjkxLDEwICszNjk1LDM0IEBAIGdudHRhYl9yZWxlYXNlX21hcHBpbmdz KAogCiAgICAgQlVHX09OKCFkLT5pc19keWluZyk7CiAKLSAgICBmb3IgKCBo YW5kbGUgPSAwOyBoYW5kbGUgPCBndC0+bWFwdHJhY2tfbGltaXQ7IGhhbmRs ZSsrICkKKyAgICBpZiAoICFndCB8fCAhZ3QtPm1hcHRyYWNrICkKKyAgICAg ICAgcmV0dXJuIDA7CisKKyAgICBmb3IgKCBoYW5kbGUgPSBndC0+bWFwdHJh Y2tfbGltaXQ7IGhhbmRsZTsgKQogICAgIHsKICAgICAgICAgdW5zaWduZWQg aW50IGNsZWFyX2ZsYWdzID0gMDsKIAorICAgICAgICAvKgorICAgICAgICAg KiBEZWFsIHdpdGggZnVsbCBwYWdlcyBzdWNoIHRoYXQgdGhlaXIgZnJlZWlu ZyAoaW4gdGhlIGJvZHkgb2YgdGhlCisgICAgICAgICAqIGlmKCkpIHJlbWFp bnMgc2ltcGxlLgorICAgICAgICAgKi8KKyAgICAgICAgaWYgKCBoYW5kbGUg PCBndC0+bWFwdHJhY2tfbGltaXQgJiYgIShoYW5kbGUgJSBNQVBUUkFDS19Q RVJfUEFHRSkgKQorICAgICAgICB7CisgICAgICAgICAgICAvKgorICAgICAg ICAgICAgICogQ2hhbmdpbmcgbWFwdHJhY2tfbGltaXQgYWx0ZXJzIG5yX21h cHRyYWNrX2ZyYW1lcygpJ2VzIHJldHVybgorICAgICAgICAgICAgICogdmFs dWUuIEZyZWUgdGhlIHRoZW4gZXhjZXNzIHRyYWlsaW5nIHBhZ2UgcmlnaHQg aGVyZSwgcmF0aGVyCisgICAgICAgICAgICAgKiB0aGFuIGxlYXZpbmcgaXQg dG8gZ3JhbnRfdGFibGVfZGVzdHJveSgpIChhbmQgaW4gdHVybiByZXF1aXJp bmcKKyAgICAgICAgICAgICAqIHRvIGxlYXZlIGd0LT5tYXB0cmFja19saW1p dCB1bmFsdGVyZWQpLgorICAgICAgICAgICAgICovCisgICAgICAgICAgICBn dC0+bWFwdHJhY2tfbGltaXQgPSBoYW5kbGU7CisgICAgICAgICAgICBGUkVF X1hFTkhFQVBfUEFHRShndC0+bWFwdHJhY2tbbnJfbWFwdHJhY2tfZnJhbWVz KGd0KV0pOworCisgICAgICAgICAgICBpZiAoIGh5cGVyY2FsbF9wcmVlbXB0 X2NoZWNrKCkgKQorICAgICAgICAgICAgICAgIHJldHVybiAtRVJFU1RBUlQ7 CisgICAgICAgIH0KKworICAgICAgICAtLWhhbmRsZTsKKwogICAgICAgICBt YXAgPSAmbWFwdHJhY2tfZW50cnkoZ3QsIGhhbmRsZSk7CiAgICAgICAgIGlm ICggIShtYXAtPmZsYWdzICYgKEdOVE1BUF9kZXZpY2VfbWFwfEdOVE1BUF9o b3N0X21hcCkpICkKICAgICAgICAgICAgIGNvbnRpbnVlOwpAQCAtMzc4NSw2 ICszODEzLDExIEBAIGdudHRhYl9yZWxlYXNlX21hcHBpbmdzKAogCiAgICAg ICAgIG1hcC0+ZmxhZ3MgPSAwOwogICAgIH0KKworICAgIGd0LT5tYXB0cmFj a19saW1pdCA9IDA7CisgICAgRlJFRV9YRU5IRUFQX1BBR0UoZ3QtPm1hcHRy YWNrWzBdKTsKKworICAgIHJldHVybiAwOwogfQogCiB2b2lkIGdyYW50X3Rh YmxlX3dhcm5fYWN0aXZlX2dyYW50cyhzdHJ1Y3QgZG9tYWluICpkKQpAQCAt Mzg0OCw4ICszODgxLDcgQEAgZ3JhbnRfdGFibGVfZGVzdHJveSgKICAgICAg ICAgZnJlZV94ZW5oZWFwX3BhZ2UodC0+c2hhcmVkX3Jhd1tpXSk7CiAgICAg eGZyZWUodC0+c2hhcmVkX3Jhdyk7CiAKLSAgICBmb3IgKCBpID0gMDsgaSA8 IG5yX21hcHRyYWNrX2ZyYW1lcyh0KTsgaSsrICkKLSAgICAgICAgZnJlZV94 ZW5oZWFwX3BhZ2UodC0+bWFwdHJhY2tbaV0pOworICAgIEFTU0VSVCghdC0+ bWFwdHJhY2tfbGltaXQpOwogICAgIHZmcmVlKHQtPm1hcHRyYWNrKTsKIAog ICAgIGZvciAoIGkgPSAwOyBpIDwgbnJfYWN0aXZlX2dyYW50X2ZyYW1lcyh0 KTsgaSsrICkKLS0tIGEveGVuL2luY2x1ZGUveGVuL2dyYW50X3RhYmxlLmgK KysrIGIveGVuL2luY2x1ZGUveGVuL2dyYW50X3RhYmxlLmgKQEAgLTQ3LDkg KzQ3LDcgQEAgdm9pZCBncmFudF90YWJsZV9pbml0X3ZjcHUoc3RydWN0IHZj cHUgKgogdm9pZCBncmFudF90YWJsZV93YXJuX2FjdGl2ZV9ncmFudHMoc3Ry dWN0IGRvbWFpbiAqZCk7CiAKIC8qIERvbWFpbiBkZWF0aCByZWxlYXNlIG9m IGdyYW50ZWQgbWFwcGluZ3Mgb2Ygb3RoZXIgZG9tYWlucycgbWVtb3J5LiAq Lwotdm9pZAotZ250dGFiX3JlbGVhc2VfbWFwcGluZ3MoCi0gICAgc3RydWN0 IGRvbWFpbiAqZCk7CitpbnQgZ250dGFiX3JlbGVhc2VfbWFwcGluZ3Moc3Ry dWN0IGRvbWFpbiAqZCk7CiAKIGludCBtZW1fc2hhcmluZ19ncmVmX3RvX2dm bihzdHJ1Y3QgZ3JhbnRfdGFibGUgKmd0LCBncmFudF9yZWZfdCByZWYsCiAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgZ2ZuX3QgKmdmbiwgdWludDE2 X3QgKnN0YXR1cyk7CkBAIC03OCw3ICs3Niw3IEBAIHN0YXRpYyBpbmxpbmUg dm9pZCBncmFudF90YWJsZV9pbml0X3ZjcHUKIAogc3RhdGljIGlubGluZSB2 b2lkIGdyYW50X3RhYmxlX3dhcm5fYWN0aXZlX2dyYW50cyhzdHJ1Y3QgZG9t YWluICpkKSB7fQogCi1zdGF0aWMgaW5saW5lIHZvaWQgZ250dGFiX3JlbGVh c2VfbWFwcGluZ3Moc3RydWN0IGRvbWFpbiAqZCkge30KK3N0YXRpYyBpbmxp bmUgaW50IGdudHRhYl9yZWxlYXNlX21hcHBpbmdzKHN0cnVjdCBkb21haW4g KmQpIHsgcmV0dXJuIDA7IH0KIAogc3RhdGljIGlubGluZSBpbnQgbWVtX3No YXJpbmdfZ3JlZl90b19nZm4oc3RydWN0IGdyYW50X3RhYmxlICpndCwKICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGdyYW50 X3JlZl90IHJlZiwK --=separator Content-Type: application/octet-stream; name="xsa380/xsa380-4.13-2.patch" Content-Disposition: attachment; filename="xsa380/xsa380-4.13-2.patch" Content-Transfer-Encoding: base64 RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0 OiBnbnR0YWI6IHJlcGxhY2UgbWFwa2luZCgpCgptYXBraW5kKCkgZG9lc24n dCBzY2FsZSB2ZXJ5IHdlbGwgd2l0aCBsYXJnZXIgbWFwdHJhY2sgZW50cnkg Y291bnRzLAp1c2luZyBhIGJydXRlIGZvcmNlIGxpbmVhciBzZWFyY2ggdGhy b3VnaCBhbGwgZW50cmllcywgd2l0aCB0aGUgb25seQpvcHRpb24gb2YgYW4g ZWFybHkgbG9vcCBleGl0IGlmIGEgbWF0Y2hpbmcgd3JpdGFibGUgZW50cnkg d2FzIGZvdW5kLgpJbnRyb2R1Y2UgYSByYWRpeCB0cmVlIGFsb25nc2lkZSB0 aGUgbWFpbiBtYXB0cmFjayB0YWJsZSwgdGh1cwphbGxvd2luZyBtdWNoIGZh c3RlciBNRk4tYmFzZWQgbG9va3VwLiBUbyBhdm9pZCB0aGUgbmVlZCB0byBh Y3R1YWxseQphbGxvY2F0ZSBzcGFjZSBmb3IgdGhlIGluZGl2aWR1YWwgbm9k ZXMsIGVuY29kZSB0aGUgdHdvIGNvdW50ZXJzIGluIHRoZQpub2RlIHBvaW50 ZXJzIHRoZW1zZWx2ZXMsIHRodXMgbGltaXRpbmcgdGhlIG51bWJlciBvZiBw ZXJtaXR0ZWQKc2ltdWx0YW5lb3VzIHIvbyBhbmQgci93IG1hcHBpbmdzIG9m IHRoZSBzYW1lIE1GTiB0byAywrPCuS0xICg2NC1iaXQpIC8KMsK54oG1LTEg KDMyLWJpdCkgZWFjaC4KClRvIGF2b2lkIGVuZm9yY2luZyBhbiB1bm5lY2Vz c2FyaWx5IGxvdyBib3VuZCBvbiB0aGUgbnVtYmVyIG9mCnNpbXVsdGFuZW91 cyBtYXBwaW5ncyBvZiBhIHNpbmdsZSBNRk4sIGludHJvZHVjZQpyYWRpeF90 cmVlX3t1bG9uZ190b19wdHIscHRyX3RvX3Vsb25nfSBwYXJhbGxlbGluZwpy YWRpeF90cmVlX3tpbnRfdG9fcHRyLHB0cl90b19pbnR9LgoKQXMgYSBjb25z ZXF1ZW5jZSBsb2NraW5nIGNoYW5nZXMgYXJlIGFsc28gYXBwbGljYWJsZTog V2l0aCB0aGVyZSBubwpsb25nZXIgYmVpbmcgYW55IGluc3BlY3Rpb24gb2Yg dGhlIHJlbW90ZSBkb21haW4ncyBhY3RpdmUgZW50cmllcywKdGhlcmUncyBh bHNvIG5vIG5lZWQgYW55bW9yZSB0byBob2xkIHRoZSByZW1vdGUgZG9tYWlu J3MgZ3JhbnQgdGFibGUKbG9jay4gQW5kIHNpbmNlIHdlJ3JlIG5vIGxvbmdl ciBpdGVyYXRpbmcgb3ZlciB0aGUgbG9jYWwgZG9tYWluJ3MgbWFwCnRyYWNr IHRhYmxlLCB0aGUgbG9jayBpbiBtYXBfZ3JhbnRfcmVmKCkgY2FuIGFsc28g YmUgZHJvcHBlZCBiZWZvcmUgdGhlCm5ldyBtYXB0cmFjayBlbnRyeSBhY3R1 YWxseSBnZXRzIHBvcHVsYXRlZC4KCkFzIGEgbmljZSBzaWRlIGVmZmVjdCB0 aGlzIGFsc28gcmVkdWNlcyB0aGUgbnVtYmVyIG9mIElPTU1VIG9wZXJhdGlv bnMKaW4gdW5tYXBfY29tbW9uKCk6IFByZXZpb3VzbHkgd2Ugd291bGQgaGF2 ZSAiZXN0YWJsaXNoZWQiIGEgcmVhZGFibGUKbWFwcGluZyB3aGVuZXZlciB3 ZSBkaWRuJ3QgZmluZCBhIHdyaXRhYmxlIGVudHJ5IGFueW1vcmUgKHlldCwg b2YKY291cnNlLCBhdCBsZWFzdCBvbmUgcmVhZGFibGUgb25lKS4gQnV0IHdl IG9ubHkgbmVlZCB0byBkbyB0aGlzIGlmIHdlCmFjdHVhbGx5IGRyb3BwZWQg dGhlIGxhc3Qgd3JpdGFibGUgZW50cnksIG5vdCBpZiB0aGVyZSB3ZXJlIG5v bmUgYWxyZWFkeQpiZWZvcmUuCgpUaGlzIGlzIHBhcnQgb2YgQ1ZFLTIwMjEt Mjg2OTggLyBYU0EtMzgwLgoKU2lnbmVkLW9mZi1ieTogSmFuIEJldWxpY2gg PGpiZXVsaWNoQHN1c2UuY29tPgpSZXZpZXdlZC1ieTogSnVsaWVuIEdyYWxs IDxqZ3JhbGxAYW1hem9uLmNvbT4KCi0tLSBhL3hlbi9jb21tb24vZ3JhbnRf dGFibGUuYworKysgYi94ZW4vY29tbW9uL2dyYW50X3RhYmxlLmMKQEAgLTM2 LDYgKzM2LDcgQEAKICNpbmNsdWRlIDx4ZW4vaW9tbXUuaD4KICNpbmNsdWRl IDx4ZW4vcGFnaW5nLmg+CiAjaW5jbHVkZSA8eGVuL2tleWhhbmRsZXIuaD4K KyNpbmNsdWRlIDx4ZW4vcmFkaXgtdHJlZS5oPgogI2luY2x1ZGUgPHhlbi92 bWFwLmg+CiAjaW5jbHVkZSA8eGVuL25vc3BlYy5oPgogI2luY2x1ZGUgPHhz bS94c20uaD4KQEAgLTgxLDggKzgyLDEzIEBAIHN0cnVjdCBncmFudF90YWJs ZSB7CiAgICAgZ3JhbnRfc3RhdHVzX3QgICAgICAgKipzdGF0dXM7CiAgICAg LyogQWN0aXZlIGdyYW50IHRhYmxlLiAqLwogICAgIHN0cnVjdCBhY3RpdmVf Z3JhbnRfZW50cnkgKiphY3RpdmU7Ci0gICAgLyogTWFwcGluZyB0cmFja2lu ZyB0YWJsZSBwZXIgdmNwdS4gKi8KKyAgICAvKiBIYW5kbGUtaW5kZXhlZCB0 cmFja2luZyB0YWJsZSBvZiBtYXBwaW5ncy4gKi8KICAgICBzdHJ1Y3QgZ3Jh bnRfbWFwcGluZyAqKm1hcHRyYWNrOworICAgIC8qCisgICAgICogTUZOLWlu ZGV4ZWQgdHJhY2tpbmcgdHJlZSBvZiBtYXBwaW5ncywgaWYgbmVlZGVkLiAg Tm90ZSB0aGF0IHRoaXMgaXMKKyAgICAgKiBwcm90ZWN0ZWQgYnkgQGxvY2ss IG5vdCBAbWFwdHJhY2tfbG9jay4KKyAgICAgKi8KKyAgICBzdHJ1Y3QgcmFk aXhfdHJlZV9yb290IG1hcHRyYWNrX3RyZWU7CiAKICAgICAvKiBEb21haW4g dG8gd2hpY2ggdGhpcyBzdHJ1Y3QgZ3JhbnRfdGFibGUgYmVsb25ncy4gKi8K ICAgICBjb25zdCBzdHJ1Y3QgZG9tYWluICpkb21haW47CkBAIC00NjAsMzQg KzQ2Niw2IEBAIHN0YXRpYyBpbnQgZ2V0X3BhZ2VkX2ZyYW1lKHVuc2lnbmVk IGxvbmcKICAgICByZXR1cm4gR05UU1Rfb2theTsKIH0KIAotc3RhdGljIGlu bGluZSB2b2lkCi1kb3VibGVfZ3RfbG9jayhzdHJ1Y3QgZ3JhbnRfdGFibGUg KmxndCwgc3RydWN0IGdyYW50X3RhYmxlICpyZ3QpCi17Ci0gICAgLyoKLSAg ICAgKiBTZWUgbWFwa2luZCgpIGZvciB3aHkgdGhlIHdyaXRlIGxvY2sgaXMg YWxzbyByZXF1aXJlZCBmb3IgdGhlCi0gICAgICogcmVtb3RlIGRvbWFpbi4K LSAgICAgKi8KLSAgICBpZiAoIGxndCA8IHJndCApCi0gICAgewotICAgICAg ICBncmFudF93cml0ZV9sb2NrKGxndCk7Ci0gICAgICAgIGdyYW50X3dyaXRl X2xvY2socmd0KTsKLSAgICB9Ci0gICAgZWxzZQotICAgIHsKLSAgICAgICAg aWYgKCBsZ3QgIT0gcmd0ICkKLSAgICAgICAgICAgIGdyYW50X3dyaXRlX2xv Y2socmd0KTsKLSAgICAgICAgZ3JhbnRfd3JpdGVfbG9jayhsZ3QpOwotICAg IH0KLX0KLQotc3RhdGljIGlubGluZSB2b2lkCi1kb3VibGVfZ3RfdW5sb2Nr KHN0cnVjdCBncmFudF90YWJsZSAqbGd0LCBzdHJ1Y3QgZ3JhbnRfdGFibGUg KnJndCkKLXsKLSAgICBncmFudF93cml0ZV91bmxvY2sobGd0KTsKLSAgICBp ZiAoIGxndCAhPSByZ3QgKQotICAgICAgICBncmFudF93cml0ZV91bmxvY2so cmd0KTsKLX0KLQogI2RlZmluZSBJTlZBTElEX01BUFRSQUNLX0hBTkRMRSBV SU5UX01BWAogCiBzdGF0aWMgaW5saW5lIGdyYW50X2hhbmRsZV90CkBAIC05 MDcsNDEgKzg4NSwxNyBAQCBzdGF0aWMgc3RydWN0IGFjdGl2ZV9ncmFudF9l bnRyeSAqZ3JhbnRfCiAgICAgcmV0dXJuIEVSUl9QVFIoLUVJTlZBTCk7CiB9 CiAKLSNkZWZpbmUgTUFQS0lORF9SRUFEIDEKLSNkZWZpbmUgTUFQS0lORF9X UklURSAyCi1zdGF0aWMgdW5zaWduZWQgaW50IG1hcGtpbmQoCi0gICAgc3Ry dWN0IGdyYW50X3RhYmxlICpsZ3QsIGNvbnN0IHN0cnVjdCBkb21haW4gKnJk LCBtZm5fdCBtZm4pCi17Ci0gICAgc3RydWN0IGdyYW50X21hcHBpbmcgKm1h cDsKLSAgICBncmFudF9oYW5kbGVfdCBoYW5kbGUsIGxpbWl0ID0gbGd0LT5t YXB0cmFja19saW1pdDsKLSAgICB1bnNpZ25lZCBpbnQga2luZCA9IDA7Ci0K LSAgICAvKgotICAgICAqIE11c3QgaGF2ZSB0aGUgbG9jYWwgZG9tYWluJ3Mg Z3JhbnQgdGFibGUgd3JpdGUgbG9jayB3aGVuCi0gICAgICogaXRlcmF0aW5n IG92ZXIgaXRzIG1hcHRyYWNrIGVudHJpZXMuCi0gICAgICovCi0gICAgQVNT RVJUKHBlcmNwdV9yd19pc193cml0ZV9sb2NrZWQoJmxndC0+bG9jaykpOwot ICAgIC8qCi0gICAgICogTXVzdCBoYXZlIHRoZSByZW1vdGUgZG9tYWluJ3Mg Z3JhbnQgdGFibGUgd3JpdGUgbG9jayB3aGlsZQotICAgICAqIGNvdW50aW5n IGl0cyBhY3RpdmUgZW50cmllcy4KLSAgICAgKi8KLSAgICBBU1NFUlQocGVy Y3B1X3J3X2lzX3dyaXRlX2xvY2tlZCgmcmQtPmdyYW50X3RhYmxlLT5sb2Nr KSk7Ci0KLSAgICBzbXBfcm1iKCk7Ci0KLSAgICBmb3IgKCBoYW5kbGUgPSAw OyAhKGtpbmQgJiBNQVBLSU5EX1dSSVRFKSAmJiBoYW5kbGUgPCBsaW1pdDsg aGFuZGxlKysgKQotICAgIHsKLSAgICAgICAgbWFwID0gJm1hcHRyYWNrX2Vu dHJ5KGxndCwgaGFuZGxlKTsKLSAgICAgICAgaWYgKCAhKG1hcC0+ZmxhZ3Mg JiAoR05UTUFQX2RldmljZV9tYXB8R05UTUFQX2hvc3RfbWFwKSkgfHwKLSAg ICAgICAgICAgICBtYXAtPmRvbWlkICE9IHJkLT5kb21haW5faWQgKQotICAg ICAgICAgICAgY29udGludWU7Ci0gICAgICAgIGlmICggbWZuX2VxKF9hY3Rp dmVfZW50cnkocmQtPmdyYW50X3RhYmxlLCBtYXAtPnJlZikubWZuLCBtZm4p ICkKLSAgICAgICAgICAgIGtpbmQgfD0gbWFwLT5mbGFncyAmIEdOVE1BUF9y ZWFkb25seSA/Ci0gICAgICAgICAgICAgICAgICAgIE1BUEtJTkRfUkVBRCA6 IE1BUEtJTkRfV1JJVEU7Ci0gICAgfQotCi0gICAgcmV0dXJuIGtpbmQ7Ci19 Cit1bmlvbiBtYXB0cmFja19ub2RlIHsKKyAgICBzdHJ1Y3QgeworICAgICAg ICAvKiBSYWRpeCB0cmVlIHNsb3QgcG9pbnRlcnMgdXNlIHR3byBvZiB0aGUg Yml0cy4gKi8KKyNpZmRlZiBfX0JJR19FTkRJQU5fQklURklFTEQKKyAgICAg ICAgdW5zaWduZWQgbG9uZyAgICA6IDI7CisjZW5kaWYKKyAgICAgICAgdW5z aWduZWQgbG9uZyByZCA6IEJJVFNfUEVSX0xPTkcgLyAyIC0gMTsKKyAgICAg ICAgdW5zaWduZWQgbG9uZyB3ciA6IEJJVFNfUEVSX0xPTkcgLyAyIC0gMTsK KyAgICB9IGNudDsKKyAgICB1bnNpZ25lZCBsb25nIHJhdzsKK307CiAKIHN0 YXRpYyB2b2lkCiBtYXBfZ3JhbnRfcmVmKApAQCAtOTYxLDcgKzkxNSw2IEBA IG1hcF9ncmFudF9yZWYoCiAgICAgc3RydWN0IGdyYW50X21hcHBpbmcgKm10 OwogICAgIGdyYW50X2VudHJ5X2hlYWRlcl90ICpzaGFoOwogICAgIHVpbnQx Nl90ICpzdGF0dXM7Ci0gICAgYm9vbF90IG5lZWRfaW9tbXU7CiAKICAgICBs ZWQgPSBjdXJyZW50OwogICAgIGxkID0gbGVkLT5kb21haW47CkBAIC0xMTgx LDMxICsxMTM0LDc1IEBAIG1hcF9ncmFudF9yZWYoCiAgICAgICogYXMgbWVt LXNoYXJpbmcgYW5kIElPTU1VIHVzZSBhcmUgaW5jb21wYXRpYmxlKS4gVGhl IGRvbV9pbyBjYXNlIHdvdWxkCiAgICAgICogbmVlZCBjaGVja2luZyBzZXBh cmF0ZWx5IGlmIHdlIGNvbXBhcmVkIGFnYWluc3Qgb3duZXIgaGVyZS4KICAg ICAgKi8KLSAgICBuZWVkX2lvbW11ID0gbGQgIT0gcmQgJiYgZ250dGFiX25l ZWRfaW9tbXVfbWFwcGluZyhsZCk7Ci0gICAgaWYgKCBuZWVkX2lvbW11ICkK KyAgICBpZiAoIGxkICE9IHJkICYmIGdudHRhYl9uZWVkX2lvbW11X21hcHBp bmcobGQpICkKICAgICB7CisgICAgICAgIHVuaW9uIG1hcHRyYWNrX25vZGUg bm9kZSA9IHsKKyAgICAgICAgICAgIC5jbnQucmQgPSAhIShvcC0+ZmxhZ3Mg JiBHTlRNQVBfcmVhZG9ubHkpLAorICAgICAgICAgICAgLmNudC53ciA9ICEo b3AtPmZsYWdzICYgR05UTUFQX3JlYWRvbmx5KSwKKyAgICAgICAgfTsKKyAg ICAgICAgaW50IGVycjsKKyAgICAgICAgdm9pZCAqKnNsb3QgPSBOVUxMOwog ICAgICAgICB1bnNpZ25lZCBpbnQga2luZDsKIAotICAgICAgICBkb3VibGVf Z3RfbG9jayhsZ3QsIHJndCk7CisgICAgICAgIGdyYW50X3dyaXRlX2xvY2so bGd0KTsKKworICAgICAgICBlcnIgPSByYWRpeF90cmVlX2luc2VydCgmbGd0 LT5tYXB0cmFja190cmVlLCBtZm5feChtZm4pLAorICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICByYWRpeF90cmVlX3Vsb25nX3RvX3B0cihub2Rl LnJhdykpOworICAgICAgICBpZiAoIGVyciA9PSAtRUVYSVNUICkKKyAgICAg ICAgeworICAgICAgICAgICAgc2xvdCA9IHJhZGl4X3RyZWVfbG9va3VwX3Ns b3QoJmxndC0+bWFwdHJhY2tfdHJlZSwgbWZuX3gobWZuKSk7CisgICAgICAg ICAgICBpZiAoIGxpa2VseShzbG90KSApCisgICAgICAgICAgICB7CisgICAg ICAgICAgICAgICAgbm9kZS5yYXcgPSByYWRpeF90cmVlX3B0cl90b191bG9u Zygqc2xvdCk7CisgICAgICAgICAgICAgICAgZXJyID0gLUVCVVNZOworCisg ICAgICAgICAgICAgICAgLyogVXBkYXRlIG5vZGUgb25seSB3aGVuIHJlZmNv dW50IGRvZXNuJ3Qgb3ZlcmZsb3cuICovCisgICAgICAgICAgICAgICAgaWYg KCBvcC0+ZmxhZ3MgJiBHTlRNQVBfcmVhZG9ubHkgPyArK25vZGUuY250LnJk CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgOiArK25vZGUuY250LndyICkKKyAgICAgICAgICAgICAgICB7Cisg ICAgICAgICAgICAgICAgICAgIHJhZGl4X3RyZWVfcmVwbGFjZV9zbG90KHNs b3QsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIHJhZGl4X3RyZWVfdWxvbmdfdG9fcHRyKG5vZGUucmF3KSk7CisgICAg ICAgICAgICAgICAgICAgIGVyciA9IDA7CisgICAgICAgICAgICAgICAgfQor ICAgICAgICAgICAgfQorICAgICAgICAgICAgZWxzZQorICAgICAgICAgICAg ICAgIEFTU0VSVF9VTlJFQUNIQUJMRSgpOworICAgICAgICB9CiAKICAgICAg ICAgLyoKICAgICAgICAgICogV2UncmUgbm90IHRyYW5zbGF0ZWQsIHNvIHdl IGtub3cgdGhhdCBkZm5zIGFuZCBtZm5zIGFyZQogICAgICAgICAgKiB0aGUg c2FtZSB0aGluZ3MsIHNvIHRoZSBJT01NVSBlbnRyeSBpcyBhbHdheXMgMS10 by0xLgogICAgICAgICAgKi8KLSAgICAgICAga2luZCA9IG1hcGtpbmQobGd0 LCByZCwgbWZuKTsKLSAgICAgICAgaWYgKCAhKG9wLT5mbGFncyAmIEdOVE1B UF9yZWFkb25seSkgJiYKLSAgICAgICAgICAgICAhKGtpbmQgJiBNQVBLSU5E X1dSSVRFKSApCisgICAgICAgIGlmICggIShvcC0+ZmxhZ3MgJiBHTlRNQVBf cmVhZG9ubHkpICYmIG5vZGUuY250LndyID09IDEgKQogICAgICAgICAgICAg a2luZCA9IElPTU1VRl9yZWFkYWJsZSB8IElPTU1VRl93cml0YWJsZTsKLSAg ICAgICAgZWxzZSBpZiAoICFraW5kICkKKyAgICAgICAgZWxzZSBpZiAoIChv cC0+ZmxhZ3MgJiBHTlRNQVBfcmVhZG9ubHkpICYmCisgICAgICAgICAgICAg ICAgICBub2RlLmNudC5yZCA9PSAxICYmICFub2RlLmNudC53ciApCiAgICAg ICAgICAgICBraW5kID0gSU9NTVVGX3JlYWRhYmxlOwogICAgICAgICBlbHNl CiAgICAgICAgICAgICBraW5kID0gMDsKLSAgICAgICAgaWYgKCBraW5kICYm IGlvbW11X2xlZ2FjeV9tYXAobGQsIF9kZm4obWZuX3gobWZuKSksIG1mbiwg MCwga2luZCkgKQorICAgICAgICBpZiAoIGVyciB8fAorICAgICAgICAgICAg IChraW5kICYmIGlvbW11X2xlZ2FjeV9tYXAobGQsIF9kZm4obWZuX3gobWZu KSksIG1mbiwgMCwga2luZCkpICkKICAgICAgICAgewotICAgICAgICAgICAg ZG91YmxlX2d0X3VubG9jayhsZ3QsIHJndCk7CisgICAgICAgICAgICBpZiAo ICFlcnIgKQorICAgICAgICAgICAgeworICAgICAgICAgICAgICAgIGlmICgg c2xvdCApCisgICAgICAgICAgICAgICAgeworICAgICAgICAgICAgICAgICAg ICBvcC0+ZmxhZ3MgJiBHTlRNQVBfcmVhZG9ubHkgPyBub2RlLmNudC5yZC0t CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICA6IG5vZGUuY250LndyLS07CisgICAgICAgICAgICAgICAgICAgIHJh ZGl4X3RyZWVfcmVwbGFjZV9zbG90KHNsb3QsCisgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIHJhZGl4X3RyZWVfdWxvbmdf dG9fcHRyKG5vZGUucmF3KSk7CisgICAgICAgICAgICAgICAgfQorICAgICAg ICAgICAgICAgIGVsc2UKKyAgICAgICAgICAgICAgICAgICAgcmFkaXhfdHJl ZV9kZWxldGUoJmxndC0+bWFwdHJhY2tfdHJlZSwgbWZuX3gobWZuKSk7Cisg ICAgICAgICAgICB9CisKICAgICAgICAgICAgIHJjID0gR05UU1RfZ2VuZXJh bF9lcnJvcjsKLSAgICAgICAgICAgIGdvdG8gdW5kb19vdXQ7CiAgICAgICAg IH0KKworICAgICAgICBncmFudF93cml0ZV91bmxvY2sobGd0KTsKKworICAg ICAgICBpZiAoIHJjICE9IEdOVFNUX29rYXkgKQorICAgICAgICAgICAgZ290 byB1bmRvX291dDsKICAgICB9CiAKICAgICBUUkFDRV8xRChUUkNfTUVNX1BB R0VfR1JBTlRfTUFQLCBvcC0+ZG9tKTsKQEAgLTEyMTMsMTAgKzEyMTAsNiBA QCBtYXBfZ3JhbnRfcmVmKAogICAgIC8qCiAgICAgICogQWxsIG1hcHRyYWNr IGVudHJ5IHVzZXJzIGNoZWNrIG10LT5mbGFncyBmaXJzdCBiZWZvcmUgdXNp bmcgdGhlCiAgICAgICogb3RoZXIgZmllbGRzIHNvIGp1c3QgZW5zdXJlIHRo ZSBmbGFncyBmaWVsZCBpcyBzdG9yZWQgbGFzdC4KLSAgICAgKgotICAgICAq IEhvd2V2ZXIsIGlmIGdudHRhYl9uZWVkX2lvbW11X21hcHBpbmcoKSB0aGVu IHRoaXMgd291bGQgcmFjZQotICAgICAqIHdpdGggYSBjb25jdXJyZW50IG1h cGtpbmQoKSBjYWxsIChvbiBhbiB1bm1hcCwgZm9yIGV4YW1wbGUpCi0gICAg ICogYW5kIGEgbG9jayBpcyByZXF1aXJlZC4KICAgICAgKi8KICAgICBtdCA9 ICZtYXB0cmFja19lbnRyeShsZ3QsIGhhbmRsZSk7CiAgICAgbXQtPmRvbWlk ID0gb3AtPmRvbTsKQEAgLTEyMjQsOSArMTIxNyw2IEBAIG1hcF9ncmFudF9y ZWYoCiAgICAgc21wX3dtYigpOwogICAgIHdyaXRlX2F0b21pYygmbXQtPmZs YWdzLCBvcC0+ZmxhZ3MpOwogCi0gICAgaWYgKCBuZWVkX2lvbW11ICkKLSAg ICAgICAgZG91YmxlX2d0X3VubG9jayhsZ3QsIHJndCk7Ci0KICAgICBvcC0+ ZGV2X2J1c19hZGRyID0gbWZuX3RvX21hZGRyKG1mbik7CiAgICAgb3AtPmhh bmRsZSAgICAgICA9IGhhbmRsZTsKICAgICBvcC0+c3RhdHVzICAgICAgID0g R05UU1Rfb2theTsKQEAgLTE0NDgsMTkgKzE0MzgsMzQgQEAgdW5tYXBfY29t bW9uKAogICAgIC8qIFNlZSB0aGUgcmVzcGVjdGl2ZSBjb21tZW50IGluIG1h cF9ncmFudF9yZWYoKS4gKi8KICAgICBpZiAoIHJjID09IEdOVFNUX29rYXkg JiYgbGQgIT0gcmQgJiYgZ250dGFiX25lZWRfaW9tbXVfbWFwcGluZyhsZCkg KQogICAgIHsKLSAgICAgICAgdW5zaWduZWQgaW50IGtpbmQ7CisgICAgICAg IHZvaWQgKipzbG90OworICAgICAgICB1bmlvbiBtYXB0cmFja19ub2RlIG5v ZGU7CiAgICAgICAgIGludCBlcnIgPSAwOwogCi0gICAgICAgIGRvdWJsZV9n dF9sb2NrKGxndCwgcmd0KTsKKyAgICAgICAgZ3JhbnRfd3JpdGVfbG9jayhs Z3QpOworICAgICAgICBzbG90ID0gcmFkaXhfdHJlZV9sb29rdXBfc2xvdCgm bGd0LT5tYXB0cmFja190cmVlLCBtZm5feChvcC0+bWZuKSk7CisgICAgICAg IG5vZGUucmF3ID0gbGlrZWx5KHNsb3QpID8gcmFkaXhfdHJlZV9wdHJfdG9f dWxvbmcoKnNsb3QpIDogMDsKKworICAgICAgICAvKiBSZWZjb3VudCBtdXN0 IG5vdCB1bmRlcmZsb3cuICovCisgICAgICAgIGlmICggIShmbGFncyAmIEdO VE1BUF9yZWFkb25seSA/IG5vZGUuY250LnJkLS0KKyAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIDogbm9kZS5jbnQud3ItLSkgKQor ICAgICAgICAgICAgQlVHKCk7CiAKLSAgICAgICAga2luZCA9IG1hcGtpbmQo bGd0LCByZCwgb3AtPm1mbik7Ci0gICAgICAgIGlmICggIWtpbmQgKQorICAg ICAgICBpZiAoICFub2RlLnJhdyApCiAgICAgICAgICAgICBlcnIgPSBpb21t dV9sZWdhY3lfdW5tYXAobGQsIF9kZm4obWZuX3gob3AtPm1mbikpLCAwKTsK LSAgICAgICAgZWxzZSBpZiAoICEoa2luZCAmIE1BUEtJTkRfV1JJVEUpICkK KyAgICAgICAgZWxzZSBpZiAoICEoZmxhZ3MgJiBHTlRNQVBfcmVhZG9ubHkp ICYmICFub2RlLmNudC53ciApCiAgICAgICAgICAgICBlcnIgPSBpb21tdV9s ZWdhY3lfbWFwKGxkLCBfZGZuKG1mbl94KG9wLT5tZm4pKSwgb3AtPm1mbiwg MCwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgSU9NTVVG X3JlYWRhYmxlKTsKIAotICAgICAgICBkb3VibGVfZ3RfdW5sb2NrKGxndCwg cmd0KTsKKyAgICAgICAgaWYgKCBlcnIgKQorICAgICAgICAgICAgOworICAg ICAgICBlbHNlIGlmICggIW5vZGUucmF3ICkKKyAgICAgICAgICAgIHJhZGl4 X3RyZWVfZGVsZXRlKCZsZ3QtPm1hcHRyYWNrX3RyZWUsIG1mbl94KG9wLT5t Zm4pKTsKKyAgICAgICAgZWxzZQorICAgICAgICAgICAgcmFkaXhfdHJlZV9y ZXBsYWNlX3Nsb3Qoc2xvdCwKKyAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIHJhZGl4X3RyZWVfdWxvbmdfdG9fcHRyKG5vZGUucmF3KSk7 CisKKyAgICAgICAgZ3JhbnRfd3JpdGVfdW5sb2NrKGxndCk7CiAKICAgICAg ICAgaWYgKCBlcnIgKQogICAgICAgICAgICAgcmMgPSBHTlRTVF9nZW5lcmFs X2Vycm9yOwpAQCAtMTkxOCw2ICsxOTIzLDggQEAgaW50IGdyYW50X3RhYmxl X2luaXQoc3RydWN0IGRvbWFpbiAqZCwgaQogICAgICAgICBndC0+bWFwdHJh Y2sgPSB2emFsbG9jKGd0LT5tYXhfbWFwdHJhY2tfZnJhbWVzICogc2l6ZW9m KCpndC0+bWFwdHJhY2spKTsKICAgICAgICAgaWYgKCBndC0+bWFwdHJhY2sg PT0gTlVMTCApCiAgICAgICAgICAgICBnb3RvIG91dDsKKworICAgICAgICBy YWRpeF90cmVlX2luaXQoJmd0LT5tYXB0cmFja190cmVlKTsKICAgICB9CiAK ICAgICAvKiBTaGFyZWQgZ3JhbnQgdGFibGUuICovCkBAIC0zNzAxLDYgKzM3 MDgsNyBAQCBpbnQgZ250dGFiX3JlbGVhc2VfbWFwcGluZ3Moc3RydWN0IGRv bWFpCiAgICAgZm9yICggaGFuZGxlID0gZ3QtPm1hcHRyYWNrX2xpbWl0OyBo YW5kbGU7ICkKICAgICB7CiAgICAgICAgIHVuc2lnbmVkIGludCBjbGVhcl9m bGFncyA9IDA7CisgICAgICAgIG1mbl90IG1mbjsKIAogICAgICAgICAvKgog ICAgICAgICAgKiBEZWFsIHdpdGggZnVsbCBwYWdlcyBzdWNoIHRoYXQgdGhl aXIgZnJlZWluZyAoaW4gdGhlIGJvZHkgb2YgdGhlCkBAIC0zODA2LDE3ICsz ODE0LDMxIEBAIGludCBnbnR0YWJfcmVsZWFzZV9tYXBwaW5ncyhzdHJ1Y3Qg ZG9tYWkKICAgICAgICAgaWYgKCBjbGVhcl9mbGFncyApCiAgICAgICAgICAg ICBnbnR0YWJfY2xlYXJfZmxhZ3MocmQsIGNsZWFyX2ZsYWdzLCBzdGF0dXMp OwogCisgICAgICAgIG1mbiA9IGFjdC0+bWZuOworCiAgICAgICAgIGFjdGl2 ZV9lbnRyeV9yZWxlYXNlKGFjdCk7CiAgICAgICAgIGdyYW50X3JlYWRfdW5s b2NrKHJndCk7CiAKICAgICAgICAgcmN1X3VubG9ja19kb21haW4ocmQpOwog CiAgICAgICAgIG1hcC0+ZmxhZ3MgPSAwOworCisgICAgICAgIC8qCisgICAg ICAgICAqIFRoaXMgaXMgZXhjZXNzaXZlIGluIHRoYXQgYSBzaW5nbGUgc3Vj aCBjYWxsIHdvdWxkIHN1ZmZpY2UgcGVyCisgICAgICAgICAqIG1hcHBlZCBN Rk4gKG9yIG5vbmUgYXQgYWxsLCBpZiBubyBlbnRyeSB3YXMgZXZlciBpbnNl cnRlZCkuIEJ1dCBpdAorICAgICAgICAgKiBzaG91bGQgYmUgdGhlIGNvbW1v biBjYXNlIGZvciBhbiBNRk4gdG8gYmUgbWFwcGVkIGp1c3Qgb25jZSwgYW5k CisgICAgICAgICAqIHRoaXMgd2F5IHdlIGRvbid0IG5lZWQgdG8gZnVydGhl ciBtYWludGFpbiB0aGUgY291bnRlcnMuIFdlIGFsc28KKyAgICAgICAgICog ZG9uJ3Qgd2FudCB0byBsZWF2ZSBjbGVhbmluZyB1cCBvZiB0aGUgdHJlZSBh cyBhIHdob2xlIHRvIHRoZSBlbmQKKyAgICAgICAgICogb2YgdGhlIGZ1bmN0 aW9uLCBhcyB0aGlzIGNvdWxkIHRha2UgcXVpdGUgc29tZSB0aW1lLgorICAg ICAgICAgKi8KKyAgICAgICAgcmFkaXhfdHJlZV9kZWxldGUoJmd0LT5tYXB0 cmFja190cmVlLCBtZm5feChtZm4pKTsKICAgICB9CiAKICAgICBndC0+bWFw dHJhY2tfbGltaXQgPSAwOwogICAgIEZSRUVfWEVOSEVBUF9QQUdFKGd0LT5t YXB0cmFja1swXSk7CiAKKyAgICByYWRpeF90cmVlX2Rlc3Ryb3koJmd0LT5t YXB0cmFja190cmVlLCBOVUxMKTsKKwogICAgIHJldHVybiAwOwogfQogCi0t LSBhL3hlbi9pbmNsdWRlL3hlbi9yYWRpeC10cmVlLmgKKysrIGIveGVuL2lu Y2x1ZGUveGVuL3JhZGl4LXRyZWUuaApAQCAtMTkwLDYgKzE5MCwyNSBAQCBz dGF0aWMgaW5saW5lIGludCByYWRpeF90cmVlX3B0cl90b19pbnQoCiAgICAg cmV0dXJuIChpbnQpKChsb25nKXB0ciA+PiAyKTsKIH0KIAorLyoqCisgKiBy YWRpeF90cmVlX3t1bG9uZ190b19wdHIscHRyX3RvX3Vsb25nfToKKyAqCisg KiBTYW1lIGZvciB1bnNpZ25lZCBsb25nIHZhbHVlcy4gQmV3YXJlIHRob3Vn aCB0aGF0IG9ubHkgQklUU19QRVJfTE9ORy0yCisgKiBiaXRzIGFyZSBhY3R1 YWxseSB1c2FibGUgZm9yIHRoZSB2YWx1ZS4KKyAqLworc3RhdGljIGlubGlu ZSB2b2lkICpyYWRpeF90cmVlX3Vsb25nX3RvX3B0cih1bnNpZ25lZCBsb25n IHZhbCkKK3sKKyAgICB1bnNpZ25lZCBsb25nIHB0ciA9ICh2YWwgPDwgMikg fCAweDI7CisgICAgQVNTRVJUKChwdHIgPj4gMikgPT0gdmFsKTsKKyAgICBy ZXR1cm4gKHZvaWQgKilwdHI7Cit9CisKK3N0YXRpYyBpbmxpbmUgdW5zaWdu ZWQgbG9uZyByYWRpeF90cmVlX3B0cl90b191bG9uZyh2b2lkICpwdHIpCit7 CisgICAgQVNTRVJUKCgodW5zaWduZWQgbG9uZylwdHIgJiAweDMpID09IDB4 Mik7CisgICAgcmV0dXJuICh1bnNpZ25lZCBsb25nKXB0ciA+PiAyOworfQor CiBpbnQgcmFkaXhfdHJlZV9pbnNlcnQoc3RydWN0IHJhZGl4X3RyZWVfcm9v dCAqLCB1bnNpZ25lZCBsb25nLCB2b2lkICopOwogdm9pZCAqcmFkaXhfdHJl ZV9sb29rdXAoc3RydWN0IHJhZGl4X3RyZWVfcm9vdCAqLCB1bnNpZ25lZCBs b25nKTsKIHZvaWQgKipyYWRpeF90cmVlX2xvb2t1cF9zbG90KHN0cnVjdCBy YWRpeF90cmVlX3Jvb3QgKiwgdW5zaWduZWQgbG9uZyk7Cg== --=separator Content-Type: application/octet-stream; name="xsa380/xsa380-4.14-1.patch" Content-Disposition: attachment; filename="xsa380/xsa380-4.14-1.patch" Content-Transfer-Encoding: base64 RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0 OiBnbnR0YWI6IGFkZCBwcmVlbXB0aW9uIGNoZWNrIHRvIGdudHRhYl9yZWxl YXNlX21hcHBpbmdzKCkKCkEgZ3Vlc3QgbWF5IGRpZSB3aXRoIG1hbnkgZ3Jh bnQgbWFwcGluZ3Mgc3RpbGwgaW4gcGxhY2UsIG9yIHNpbXBseSB3aXRoCmEg bGFyZ2UgbWFwdHJhY2sgdGFibGUuIEl0ZXJhdGluZyB0aHJvdWdoIHRoaXMg bWF5IHRha2UgbW9yZSB0aW1lIHRoYW4KaXMgcmVhc29uYWJsZSB3aXRob3V0 IGludGVybWVkaWF0ZSBwcmVlbXB0aW9uICh0byBydW4gc29mdGlycXMgYW5k CnBlcmhhcHMgdGhlIHNjaGVkdWxlcikuCgpNb3ZlIHRoZSBpbnZvY2F0aW9u IG9mIHRoZSBmdW5jdGlvbiB0byB0aGUgc2VjdGlvbiB3aGVyZSBvdGhlcgpy ZXN0YXJ0YWJsZSBmdW5jdGlvbnMgZ2V0IGludm9rZWQsIGFuZCBoYXZlIHRo ZSBmdW5jdGlvbiBpdHNlbGYgY2hlY2sKZm9yIHByZWVtcHRpb24gZXZlcnkg b25jZSBpbiBhIHdoaWxlLiBIYXZlIGl0IGl0ZXJhdGUgdGhlIHRhYmxlCmJh Y2t3YXJkcywgc3VjaCB0aGF0IGRlY3JlYXNpbmcgdGhlIG1hcHRyYWNrIGxp bWl0IGlzIGFsbCBpdCB0YWtlcyB0bwpjb252ZXkgcmVzdGFydCBpbmZvcm1h dGlvbi4KCkluIGRvbWFpbl90ZWFyZG93bigpIGludHJvZHVjZSBQUk9HX25v bmUgc3VjaCB0aGF0IGluc2VydGluZyBhdCB0aGUKZnJvbnQgd2lsbCBiZSBl YXNpZXIgZ29pbmcgZm9yd2FyZC4KClRoaXMgaXMgcGFydCBvZiBDVkUtMjAy MS0yODY5OCAvIFhTQS0zODAuCgpSZXBvcnRlZC1ieTogQW5kcmV3IENvb3Bl ciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNvbT4KU2lnbmVkLW9mZi1ieTog SmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpSZXZpZXdlZC1ieTog SnVsaWVuIEdyYWxsIDxqZ3JhbGxAYW1hem9uLmNvbT4KCi0tLSBhL3hlbi9j b21tb24vZG9tYWluLmMKKysrIGIveGVuL2NvbW1vbi9kb21haW4uYwpAQCAt NzIxLDExICs3MjEsMTMgQEAgaW50IGRvbWFpbl9raWxsKHN0cnVjdCBkb21h aW4gKmQpCiAgICAgICAgICAgICByZXR1cm4gZG9tYWluX2tpbGwoZCk7CiAg ICAgICAgIGQtPmlzX2R5aW5nID0gRE9NRFlJTkdfZHlpbmc7CiAgICAgICAg IGFyZ29fZGVzdHJveShkKTsKLSAgICAgICAgZ250dGFiX3JlbGVhc2VfbWFw cGluZ3MoZCk7CiAgICAgICAgIHZudW1hX2Rlc3Ryb3koZC0+dm51bWEpOwog ICAgICAgICBkb21haW5fc2V0X291dHN0YW5kaW5nX3BhZ2VzKGQsIDApOwog ICAgICAgICAvKiBmYWxsdGhyb3VnaCAqLwogICAgIGNhc2UgRE9NRFlJTkdf ZHlpbmc6CisgICAgICAgIHJjID0gZ250dGFiX3JlbGVhc2VfbWFwcGluZ3Mo ZCk7CisgICAgICAgIGlmICggcmMgKQorICAgICAgICAgICAgYnJlYWs7CiAg ICAgICAgIHJjID0gZXZ0Y2huX2Rlc3Ryb3koZCk7CiAgICAgICAgIGlmICgg cmMgKQogICAgICAgICAgICAgYnJlYWs7Ci0tLSBhL3hlbi9jb21tb24vZ3Jh bnRfdGFibGUuYworKysgYi94ZW4vY29tbW9uL2dyYW50X3RhYmxlLmMKQEAg LTY0LDcgKzY0LDEzIEBAIHN0cnVjdCBncmFudF90YWJsZSB7CiAgICAgdW5z aWduZWQgaW50ICAgICAgICAgIG5yX2dyYW50X2ZyYW1lczsKICAgICAvKiBO dW1iZXIgb2YgZ3JhbnQgc3RhdHVzIGZyYW1lcyBzaGFyZWQgd2l0aCBndWVz dCAoZm9yIHZlcnNpb24gMikgKi8KICAgICB1bnNpZ25lZCBpbnQgICAgICAg ICAgbnJfc3RhdHVzX2ZyYW1lczsKLSAgICAvKiBOdW1iZXIgb2YgYXZhaWxh YmxlIG1hcHRyYWNrIGVudHJpZXMuICovCisgICAgLyoKKyAgICAgKiBOdW1i ZXIgb2YgYXZhaWxhYmxlIG1hcHRyYWNrIGVudHJpZXMuICBGb3IgY2xlYW51 cCBwdXJwb3NlcyBpdCBpcworICAgICAqIGltcG9ydGFudCB0byByZWFsaXpl IHRoYXQgdGhpcyBmaWVsZCBhbmQgQG1hcHRyYWNrIGZ1cnRoZXIgZG93biB3 aWxsCisgICAgICogb25seSBldmVyIGJlIGFjY2Vzc2VkIGJ5IHRoZSBsb2Nh bCBkb21haW4uICBUaHVzIGl0IGlzIG9rYXkgdG8gY2xlYW4KKyAgICAgKiB1 cCBlYXJseSwgYW5kIHRvIHNocmluayB0aGUgbGltaXQgZm9yIHRoZSBwdXJw b3NlIG9mIHRyYWNraW5nIGNsZWFudXAKKyAgICAgKiBwcm9ncmVzcy4KKyAg ICAgKi8KICAgICB1bnNpZ25lZCBpbnQgICAgICAgICAgbWFwdHJhY2tfbGlt aXQ7CiAgICAgLyogU2hhcmVkIGdyYW50IHRhYmxlIChzZWUgaW5jbHVkZS9w dWJsaWMvZ3JhbnRfdGFibGUuaCkuICovCiAgICAgdW5pb24gewpAQCAtMzcw OCw5ICszNzE0LDcgQEAgZG9fZ3JhbnRfdGFibGVfb3AoCiAjaW5jbHVkZSAi Y29tcGF0L2dyYW50X3RhYmxlLmMiCiAjZW5kaWYKIAotdm9pZAotZ250dGFi X3JlbGVhc2VfbWFwcGluZ3MoCi0gICAgc3RydWN0IGRvbWFpbiAqZCkKK2lu dCBnbnR0YWJfcmVsZWFzZV9tYXBwaW5ncyhzdHJ1Y3QgZG9tYWluICpkKQog ewogICAgIHN0cnVjdCBncmFudF90YWJsZSAgICpndCA9IGQtPmdyYW50X3Rh YmxlLCAqcmd0OwogICAgIHN0cnVjdCBncmFudF9tYXBwaW5nICptYXA7CkBA IC0zNzI0LDEwICszNzI4LDM0IEBAIGdudHRhYl9yZWxlYXNlX21hcHBpbmdz KAogCiAgICAgQlVHX09OKCFkLT5pc19keWluZyk7CiAKLSAgICBmb3IgKCBo YW5kbGUgPSAwOyBoYW5kbGUgPCBndC0+bWFwdHJhY2tfbGltaXQ7IGhhbmRs ZSsrICkKKyAgICBpZiAoICFndCB8fCAhZ3QtPm1hcHRyYWNrICkKKyAgICAg ICAgcmV0dXJuIDA7CisKKyAgICBmb3IgKCBoYW5kbGUgPSBndC0+bWFwdHJh Y2tfbGltaXQ7IGhhbmRsZTsgKQogICAgIHsKICAgICAgICAgdW5zaWduZWQg aW50IGNsZWFyX2ZsYWdzID0gMDsKIAorICAgICAgICAvKgorICAgICAgICAg KiBEZWFsIHdpdGggZnVsbCBwYWdlcyBzdWNoIHRoYXQgdGhlaXIgZnJlZWlu ZyAoaW4gdGhlIGJvZHkgb2YgdGhlCisgICAgICAgICAqIGlmKCkpIHJlbWFp bnMgc2ltcGxlLgorICAgICAgICAgKi8KKyAgICAgICAgaWYgKCBoYW5kbGUg PCBndC0+bWFwdHJhY2tfbGltaXQgJiYgIShoYW5kbGUgJSBNQVBUUkFDS19Q RVJfUEFHRSkgKQorICAgICAgICB7CisgICAgICAgICAgICAvKgorICAgICAg ICAgICAgICogQ2hhbmdpbmcgbWFwdHJhY2tfbGltaXQgYWx0ZXJzIG5yX21h cHRyYWNrX2ZyYW1lcygpJ2VzIHJldHVybgorICAgICAgICAgICAgICogdmFs dWUuIEZyZWUgdGhlIHRoZW4gZXhjZXNzIHRyYWlsaW5nIHBhZ2UgcmlnaHQg aGVyZSwgcmF0aGVyCisgICAgICAgICAgICAgKiB0aGFuIGxlYXZpbmcgaXQg dG8gZ3JhbnRfdGFibGVfZGVzdHJveSgpIChhbmQgaW4gdHVybiByZXF1aXJp bmcKKyAgICAgICAgICAgICAqIHRvIGxlYXZlIGd0LT5tYXB0cmFja19saW1p dCB1bmFsdGVyZWQpLgorICAgICAgICAgICAgICovCisgICAgICAgICAgICBn dC0+bWFwdHJhY2tfbGltaXQgPSBoYW5kbGU7CisgICAgICAgICAgICBGUkVF X1hFTkhFQVBfUEFHRShndC0+bWFwdHJhY2tbbnJfbWFwdHJhY2tfZnJhbWVz KGd0KV0pOworCisgICAgICAgICAgICBpZiAoIGh5cGVyY2FsbF9wcmVlbXB0 X2NoZWNrKCkgKQorICAgICAgICAgICAgICAgIHJldHVybiAtRVJFU1RBUlQ7 CisgICAgICAgIH0KKworICAgICAgICAtLWhhbmRsZTsKKwogICAgICAgICBt YXAgPSAmbWFwdHJhY2tfZW50cnkoZ3QsIGhhbmRsZSk7CiAgICAgICAgIGlm ICggIShtYXAtPmZsYWdzICYgKEdOVE1BUF9kZXZpY2VfbWFwfEdOVE1BUF9o b3N0X21hcCkpICkKICAgICAgICAgICAgIGNvbnRpbnVlOwpAQCAtMzgxOCw2 ICszODQ2LDExIEBAIGdudHRhYl9yZWxlYXNlX21hcHBpbmdzKAogCiAgICAg ICAgIG1hcC0+ZmxhZ3MgPSAwOwogICAgIH0KKworICAgIGd0LT5tYXB0cmFj a19saW1pdCA9IDA7CisgICAgRlJFRV9YRU5IRUFQX1BBR0UoZ3QtPm1hcHRy YWNrWzBdKTsKKworICAgIHJldHVybiAwOwogfQogCiB2b2lkIGdyYW50X3Rh YmxlX3dhcm5fYWN0aXZlX2dyYW50cyhzdHJ1Y3QgZG9tYWluICpkKQpAQCAt Mzg4MSw4ICszOTE0LDcgQEAgZ3JhbnRfdGFibGVfZGVzdHJveSgKICAgICAg ICAgZnJlZV94ZW5oZWFwX3BhZ2UodC0+c2hhcmVkX3Jhd1tpXSk7CiAgICAg eGZyZWUodC0+c2hhcmVkX3Jhdyk7CiAKLSAgICBmb3IgKCBpID0gMDsgaSA8 IG5yX21hcHRyYWNrX2ZyYW1lcyh0KTsgaSsrICkKLSAgICAgICAgZnJlZV94 ZW5oZWFwX3BhZ2UodC0+bWFwdHJhY2tbaV0pOworICAgIEFTU0VSVCghdC0+ bWFwdHJhY2tfbGltaXQpOwogICAgIHZmcmVlKHQtPm1hcHRyYWNrKTsKIAog ICAgIGZvciAoIGkgPSAwOyBpIDwgbnJfYWN0aXZlX2dyYW50X2ZyYW1lcyh0 KTsgaSsrICkKLS0tIGEveGVuL2luY2x1ZGUveGVuL2dyYW50X3RhYmxlLmgK KysrIGIveGVuL2luY2x1ZGUveGVuL2dyYW50X3RhYmxlLmgKQEAgLTQ3LDkg KzQ3LDcgQEAgdm9pZCBncmFudF90YWJsZV9pbml0X3ZjcHUoc3RydWN0IHZj cHUgKgogdm9pZCBncmFudF90YWJsZV93YXJuX2FjdGl2ZV9ncmFudHMoc3Ry dWN0IGRvbWFpbiAqZCk7CiAKIC8qIERvbWFpbiBkZWF0aCByZWxlYXNlIG9m IGdyYW50ZWQgbWFwcGluZ3Mgb2Ygb3RoZXIgZG9tYWlucycgbWVtb3J5LiAq Lwotdm9pZAotZ250dGFiX3JlbGVhc2VfbWFwcGluZ3MoCi0gICAgc3RydWN0 IGRvbWFpbiAqZCk7CitpbnQgZ250dGFiX3JlbGVhc2VfbWFwcGluZ3Moc3Ry dWN0IGRvbWFpbiAqZCk7CiAKIGludCBtZW1fc2hhcmluZ19ncmVmX3RvX2dm bihzdHJ1Y3QgZ3JhbnRfdGFibGUgKmd0LCBncmFudF9yZWZfdCByZWYsCiAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgZ2ZuX3QgKmdmbiwgdWludDE2 X3QgKnN0YXR1cyk7CkBAIC03OCw3ICs3Niw3IEBAIHN0YXRpYyBpbmxpbmUg dm9pZCBncmFudF90YWJsZV9pbml0X3ZjcHUKIAogc3RhdGljIGlubGluZSB2 b2lkIGdyYW50X3RhYmxlX3dhcm5fYWN0aXZlX2dyYW50cyhzdHJ1Y3QgZG9t YWluICpkKSB7fQogCi1zdGF0aWMgaW5saW5lIHZvaWQgZ250dGFiX3JlbGVh c2VfbWFwcGluZ3Moc3RydWN0IGRvbWFpbiAqZCkge30KK3N0YXRpYyBpbmxp bmUgaW50IGdudHRhYl9yZWxlYXNlX21hcHBpbmdzKHN0cnVjdCBkb21haW4g KmQpIHsgcmV0dXJuIDA7IH0KIAogc3RhdGljIGlubGluZSBpbnQgbWVtX3No YXJpbmdfZ3JlZl90b19nZm4oc3RydWN0IGdyYW50X3RhYmxlICpndCwKICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGdyYW50 X3JlZl90IHJlZiwK --=separator Content-Type: application/octet-stream; name="xsa380/xsa380-4.14-2.patch" Content-Disposition: attachment; filename="xsa380/xsa380-4.14-2.patch" Content-Transfer-Encoding: base64 RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0 OiBnbnR0YWI6IHJlcGxhY2UgbWFwa2luZCgpCgptYXBraW5kKCkgZG9lc24n dCBzY2FsZSB2ZXJ5IHdlbGwgd2l0aCBsYXJnZXIgbWFwdHJhY2sgZW50cnkg Y291bnRzLAp1c2luZyBhIGJydXRlIGZvcmNlIGxpbmVhciBzZWFyY2ggdGhy b3VnaCBhbGwgZW50cmllcywgd2l0aCB0aGUgb25seQpvcHRpb24gb2YgYW4g ZWFybHkgbG9vcCBleGl0IGlmIGEgbWF0Y2hpbmcgd3JpdGFibGUgZW50cnkg d2FzIGZvdW5kLgpJbnRyb2R1Y2UgYSByYWRpeCB0cmVlIGFsb25nc2lkZSB0 aGUgbWFpbiBtYXB0cmFjayB0YWJsZSwgdGh1cwphbGxvd2luZyBtdWNoIGZh c3RlciBNRk4tYmFzZWQgbG9va3VwLiBUbyBhdm9pZCB0aGUgbmVlZCB0byBh Y3R1YWxseQphbGxvY2F0ZSBzcGFjZSBmb3IgdGhlIGluZGl2aWR1YWwgbm9k ZXMsIGVuY29kZSB0aGUgdHdvIGNvdW50ZXJzIGluIHRoZQpub2RlIHBvaW50 ZXJzIHRoZW1zZWx2ZXMsIHRodXMgbGltaXRpbmcgdGhlIG51bWJlciBvZiBw ZXJtaXR0ZWQKc2ltdWx0YW5lb3VzIHIvbyBhbmQgci93IG1hcHBpbmdzIG9m IHRoZSBzYW1lIE1GTiB0byAywrPCuS0xICg2NC1iaXQpIC8KMsK54oG1LTEg KDMyLWJpdCkgZWFjaC4KClRvIGF2b2lkIGVuZm9yY2luZyBhbiB1bm5lY2Vz c2FyaWx5IGxvdyBib3VuZCBvbiB0aGUgbnVtYmVyIG9mCnNpbXVsdGFuZW91 cyBtYXBwaW5ncyBvZiBhIHNpbmdsZSBNRk4sIGludHJvZHVjZQpyYWRpeF90 cmVlX3t1bG9uZ190b19wdHIscHRyX3RvX3Vsb25nfSBwYXJhbGxlbGluZwpy YWRpeF90cmVlX3tpbnRfdG9fcHRyLHB0cl90b19pbnR9LgoKQXMgYSBjb25z ZXF1ZW5jZSBsb2NraW5nIGNoYW5nZXMgYXJlIGFsc28gYXBwbGljYWJsZTog V2l0aCB0aGVyZSBubwpsb25nZXIgYmVpbmcgYW55IGluc3BlY3Rpb24gb2Yg dGhlIHJlbW90ZSBkb21haW4ncyBhY3RpdmUgZW50cmllcywKdGhlcmUncyBh bHNvIG5vIG5lZWQgYW55bW9yZSB0byBob2xkIHRoZSByZW1vdGUgZG9tYWlu J3MgZ3JhbnQgdGFibGUKbG9jay4gQW5kIHNpbmNlIHdlJ3JlIG5vIGxvbmdl ciBpdGVyYXRpbmcgb3ZlciB0aGUgbG9jYWwgZG9tYWluJ3MgbWFwCnRyYWNr IHRhYmxlLCB0aGUgbG9jayBpbiBtYXBfZ3JhbnRfcmVmKCkgY2FuIGFsc28g YmUgZHJvcHBlZCBiZWZvcmUgdGhlCm5ldyBtYXB0cmFjayBlbnRyeSBhY3R1 YWxseSBnZXRzIHBvcHVsYXRlZC4KCkFzIGEgbmljZSBzaWRlIGVmZmVjdCB0 aGlzIGFsc28gcmVkdWNlcyB0aGUgbnVtYmVyIG9mIElPTU1VIG9wZXJhdGlv bnMKaW4gdW5tYXBfY29tbW9uKCk6IFByZXZpb3VzbHkgd2Ugd291bGQgaGF2 ZSAiZXN0YWJsaXNoZWQiIGEgcmVhZGFibGUKbWFwcGluZyB3aGVuZXZlciB3 ZSBkaWRuJ3QgZmluZCBhIHdyaXRhYmxlIGVudHJ5IGFueW1vcmUgKHlldCwg b2YKY291cnNlLCBhdCBsZWFzdCBvbmUgcmVhZGFibGUgb25lKS4gQnV0IHdl IG9ubHkgbmVlZCB0byBkbyB0aGlzIGlmIHdlCmFjdHVhbGx5IGRyb3BwZWQg dGhlIGxhc3Qgd3JpdGFibGUgZW50cnksIG5vdCBpZiB0aGVyZSB3ZXJlIG5v bmUgYWxyZWFkeQpiZWZvcmUuCgpUaGlzIGlzIHBhcnQgb2YgQ1ZFLTIwMjEt Mjg2OTggLyBYU0EtMzgwLgoKU2lnbmVkLW9mZi1ieTogSmFuIEJldWxpY2gg PGpiZXVsaWNoQHN1c2UuY29tPgpSZXZpZXdlZC1ieTogSnVsaWVuIEdyYWxs IDxqZ3JhbGxAYW1hem9uLmNvbT4KCi0tLSBhL3hlbi9jb21tb24vZ3JhbnRf dGFibGUuYworKysgYi94ZW4vY29tbW9uL2dyYW50X3RhYmxlLmMKQEAgLTM3 LDYgKzM3LDcgQEAKICNpbmNsdWRlIDx4ZW4vaW9tbXUuaD4KICNpbmNsdWRl IDx4ZW4vcGFnaW5nLmg+CiAjaW5jbHVkZSA8eGVuL2tleWhhbmRsZXIuaD4K KyNpbmNsdWRlIDx4ZW4vcmFkaXgtdHJlZS5oPgogI2luY2x1ZGUgPHhlbi92 bWFwLmg+CiAjaW5jbHVkZSA8eGVuL25vc3BlYy5oPgogI2luY2x1ZGUgPHhz bS94c20uaD4KQEAgLTgyLDggKzgzLDEzIEBAIHN0cnVjdCBncmFudF90YWJs ZSB7CiAgICAgZ3JhbnRfc3RhdHVzX3QgICAgICAgKipzdGF0dXM7CiAgICAg LyogQWN0aXZlIGdyYW50IHRhYmxlLiAqLwogICAgIHN0cnVjdCBhY3RpdmVf Z3JhbnRfZW50cnkgKiphY3RpdmU7Ci0gICAgLyogTWFwcGluZyB0cmFja2lu ZyB0YWJsZSBwZXIgdmNwdS4gKi8KKyAgICAvKiBIYW5kbGUtaW5kZXhlZCB0 cmFja2luZyB0YWJsZSBvZiBtYXBwaW5ncy4gKi8KICAgICBzdHJ1Y3QgZ3Jh bnRfbWFwcGluZyAqKm1hcHRyYWNrOworICAgIC8qCisgICAgICogTUZOLWlu ZGV4ZWQgdHJhY2tpbmcgdHJlZSBvZiBtYXBwaW5ncywgaWYgbmVlZGVkLiAg Tm90ZSB0aGF0IHRoaXMgaXMKKyAgICAgKiBwcm90ZWN0ZWQgYnkgQGxvY2ss IG5vdCBAbWFwdHJhY2tfbG9jay4KKyAgICAgKi8KKyAgICBzdHJ1Y3QgcmFk aXhfdHJlZV9yb290IG1hcHRyYWNrX3RyZWU7CiAKICAgICAvKiBEb21haW4g dG8gd2hpY2ggdGhpcyBzdHJ1Y3QgZ3JhbnRfdGFibGUgYmVsb25ncy4gKi8K ICAgICBjb25zdCBzdHJ1Y3QgZG9tYWluICpkb21haW47CkBAIC01MDEsMzQg KzUwNyw2IEBAIHN0YXRpYyBpbnQgZ2V0X3BhZ2VkX2ZyYW1lKHVuc2lnbmVk IGxvbmcKICAgICByZXR1cm4gR05UU1Rfb2theTsKIH0KIAotc3RhdGljIGlu bGluZSB2b2lkCi1kb3VibGVfZ3RfbG9jayhzdHJ1Y3QgZ3JhbnRfdGFibGUg KmxndCwgc3RydWN0IGdyYW50X3RhYmxlICpyZ3QpCi17Ci0gICAgLyoKLSAg ICAgKiBTZWUgbWFwa2luZCgpIGZvciB3aHkgdGhlIHdyaXRlIGxvY2sgaXMg YWxzbyByZXF1aXJlZCBmb3IgdGhlCi0gICAgICogcmVtb3RlIGRvbWFpbi4K LSAgICAgKi8KLSAgICBpZiAoIGxndCA8IHJndCApCi0gICAgewotICAgICAg ICBncmFudF93cml0ZV9sb2NrKGxndCk7Ci0gICAgICAgIGdyYW50X3dyaXRl X2xvY2socmd0KTsKLSAgICB9Ci0gICAgZWxzZQotICAgIHsKLSAgICAgICAg aWYgKCBsZ3QgIT0gcmd0ICkKLSAgICAgICAgICAgIGdyYW50X3dyaXRlX2xv Y2socmd0KTsKLSAgICAgICAgZ3JhbnRfd3JpdGVfbG9jayhsZ3QpOwotICAg IH0KLX0KLQotc3RhdGljIGlubGluZSB2b2lkCi1kb3VibGVfZ3RfdW5sb2Nr KHN0cnVjdCBncmFudF90YWJsZSAqbGd0LCBzdHJ1Y3QgZ3JhbnRfdGFibGUg KnJndCkKLXsKLSAgICBncmFudF93cml0ZV91bmxvY2sobGd0KTsKLSAgICBp ZiAoIGxndCAhPSByZ3QgKQotICAgICAgICBncmFudF93cml0ZV91bmxvY2so cmd0KTsKLX0KLQogI2RlZmluZSBJTlZBTElEX01BUFRSQUNLX0hBTkRMRSBV SU5UX01BWAogCiBzdGF0aWMgaW5saW5lIGdyYW50X2hhbmRsZV90CkBAIC05 NDgsNDEgKzkyNiwxNyBAQCBzdGF0aWMgc3RydWN0IGFjdGl2ZV9ncmFudF9l bnRyeSAqZ3JhbnRfCiAgICAgcmV0dXJuIEVSUl9QVFIoLUVJTlZBTCk7CiB9 CiAKLSNkZWZpbmUgTUFQS0lORF9SRUFEIDEKLSNkZWZpbmUgTUFQS0lORF9X UklURSAyCi1zdGF0aWMgdW5zaWduZWQgaW50IG1hcGtpbmQoCi0gICAgc3Ry dWN0IGdyYW50X3RhYmxlICpsZ3QsIGNvbnN0IHN0cnVjdCBkb21haW4gKnJk LCBtZm5fdCBtZm4pCi17Ci0gICAgc3RydWN0IGdyYW50X21hcHBpbmcgKm1h cDsKLSAgICBncmFudF9oYW5kbGVfdCBoYW5kbGUsIGxpbWl0ID0gbGd0LT5t YXB0cmFja19saW1pdDsKLSAgICB1bnNpZ25lZCBpbnQga2luZCA9IDA7Ci0K LSAgICAvKgotICAgICAqIE11c3QgaGF2ZSB0aGUgbG9jYWwgZG9tYWluJ3Mg Z3JhbnQgdGFibGUgd3JpdGUgbG9jayB3aGVuCi0gICAgICogaXRlcmF0aW5n IG92ZXIgaXRzIG1hcHRyYWNrIGVudHJpZXMuCi0gICAgICovCi0gICAgQVNT RVJUKHBlcmNwdV9yd19pc193cml0ZV9sb2NrZWQoJmxndC0+bG9jaykpOwot ICAgIC8qCi0gICAgICogTXVzdCBoYXZlIHRoZSByZW1vdGUgZG9tYWluJ3Mg Z3JhbnQgdGFibGUgd3JpdGUgbG9jayB3aGlsZQotICAgICAqIGNvdW50aW5n IGl0cyBhY3RpdmUgZW50cmllcy4KLSAgICAgKi8KLSAgICBBU1NFUlQocGVy Y3B1X3J3X2lzX3dyaXRlX2xvY2tlZCgmcmQtPmdyYW50X3RhYmxlLT5sb2Nr KSk7Ci0KLSAgICBzbXBfcm1iKCk7Ci0KLSAgICBmb3IgKCBoYW5kbGUgPSAw OyAhKGtpbmQgJiBNQVBLSU5EX1dSSVRFKSAmJiBoYW5kbGUgPCBsaW1pdDsg aGFuZGxlKysgKQotICAgIHsKLSAgICAgICAgbWFwID0gJm1hcHRyYWNrX2Vu dHJ5KGxndCwgaGFuZGxlKTsKLSAgICAgICAgaWYgKCAhKG1hcC0+ZmxhZ3Mg JiAoR05UTUFQX2RldmljZV9tYXB8R05UTUFQX2hvc3RfbWFwKSkgfHwKLSAg ICAgICAgICAgICBtYXAtPmRvbWlkICE9IHJkLT5kb21haW5faWQgKQotICAg ICAgICAgICAgY29udGludWU7Ci0gICAgICAgIGlmICggbWZuX2VxKF9hY3Rp dmVfZW50cnkocmQtPmdyYW50X3RhYmxlLCBtYXAtPnJlZikubWZuLCBtZm4p ICkKLSAgICAgICAgICAgIGtpbmQgfD0gbWFwLT5mbGFncyAmIEdOVE1BUF9y ZWFkb25seSA/Ci0gICAgICAgICAgICAgICAgICAgIE1BUEtJTkRfUkVBRCA6 IE1BUEtJTkRfV1JJVEU7Ci0gICAgfQotCi0gICAgcmV0dXJuIGtpbmQ7Ci19 Cit1bmlvbiBtYXB0cmFja19ub2RlIHsKKyAgICBzdHJ1Y3QgeworICAgICAg ICAvKiBSYWRpeCB0cmVlIHNsb3QgcG9pbnRlcnMgdXNlIHR3byBvZiB0aGUg Yml0cy4gKi8KKyNpZmRlZiBfX0JJR19FTkRJQU5fQklURklFTEQKKyAgICAg ICAgdW5zaWduZWQgbG9uZyAgICA6IDI7CisjZW5kaWYKKyAgICAgICAgdW5z aWduZWQgbG9uZyByZCA6IEJJVFNfUEVSX0xPTkcgLyAyIC0gMTsKKyAgICAg ICAgdW5zaWduZWQgbG9uZyB3ciA6IEJJVFNfUEVSX0xPTkcgLyAyIC0gMTsK KyAgICB9IGNudDsKKyAgICB1bnNpZ25lZCBsb25nIHJhdzsKK307CiAKIHN0 YXRpYyB2b2lkCiBtYXBfZ3JhbnRfcmVmKApAQCAtMTAwMSw3ICs5NTUsNiBA QCBtYXBfZ3JhbnRfcmVmKAogICAgIHN0cnVjdCBncmFudF9tYXBwaW5nICpt dDsKICAgICBncmFudF9lbnRyeV9oZWFkZXJfdCAqc2hhaDsKICAgICB1aW50 MTZfdCAqc3RhdHVzOwotICAgIGJvb2xfdCBuZWVkX2lvbW11OwogCiAgICAg bGQgPSBjdXJyZW50LT5kb21haW47CiAKQEAgLTEyMjAsMzEgKzExNzMsNzUg QEAgbWFwX2dyYW50X3JlZigKICAgICAgKiBhcyBtZW0tc2hhcmluZyBhbmQg SU9NTVUgdXNlIGFyZSBpbmNvbXBhdGlibGUpLiBUaGUgZG9tX2lvIGNhc2Ug d291bGQKICAgICAgKiBuZWVkIGNoZWNraW5nIHNlcGFyYXRlbHkgaWYgd2Ug Y29tcGFyZWQgYWdhaW5zdCBvd25lciBoZXJlLgogICAgICAqLwotICAgIG5l ZWRfaW9tbXUgPSBsZCAhPSByZCAmJiBnbnR0YWJfbmVlZF9pb21tdV9tYXBw aW5nKGxkKTsKLSAgICBpZiAoIG5lZWRfaW9tbXUgKQorICAgIGlmICggbGQg IT0gcmQgJiYgZ250dGFiX25lZWRfaW9tbXVfbWFwcGluZyhsZCkgKQogICAg IHsKKyAgICAgICAgdW5pb24gbWFwdHJhY2tfbm9kZSBub2RlID0geworICAg ICAgICAgICAgLmNudC5yZCA9ICEhKG9wLT5mbGFncyAmIEdOVE1BUF9yZWFk b25seSksCisgICAgICAgICAgICAuY250LndyID0gIShvcC0+ZmxhZ3MgJiBH TlRNQVBfcmVhZG9ubHkpLAorICAgICAgICB9OworICAgICAgICBpbnQgZXJy OworICAgICAgICB2b2lkICoqc2xvdCA9IE5VTEw7CiAgICAgICAgIHVuc2ln bmVkIGludCBraW5kOwogCi0gICAgICAgIGRvdWJsZV9ndF9sb2NrKGxndCwg cmd0KTsKKyAgICAgICAgZ3JhbnRfd3JpdGVfbG9jayhsZ3QpOworCisgICAg ICAgIGVyciA9IHJhZGl4X3RyZWVfaW5zZXJ0KCZsZ3QtPm1hcHRyYWNrX3Ry ZWUsIG1mbl94KG1mbiksCisgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIHJhZGl4X3RyZWVfdWxvbmdfdG9fcHRyKG5vZGUucmF3KSk7CisgICAg ICAgIGlmICggZXJyID09IC1FRVhJU1QgKQorICAgICAgICB7CisgICAgICAg ICAgICBzbG90ID0gcmFkaXhfdHJlZV9sb29rdXBfc2xvdCgmbGd0LT5tYXB0 cmFja190cmVlLCBtZm5feChtZm4pKTsKKyAgICAgICAgICAgIGlmICggbGlr ZWx5KHNsb3QpICkKKyAgICAgICAgICAgIHsKKyAgICAgICAgICAgICAgICBu b2RlLnJhdyA9IHJhZGl4X3RyZWVfcHRyX3RvX3Vsb25nKCpzbG90KTsKKyAg ICAgICAgICAgICAgICBlcnIgPSAtRUJVU1k7CisKKyAgICAgICAgICAgICAg ICAvKiBVcGRhdGUgbm9kZSBvbmx5IHdoZW4gcmVmY291bnQgZG9lc24ndCBv dmVyZmxvdy4gKi8KKyAgICAgICAgICAgICAgICBpZiAoIG9wLT5mbGFncyAm IEdOVE1BUF9yZWFkb25seSA/ICsrbm9kZS5jbnQucmQKKyAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICA6ICsrbm9k ZS5jbnQud3IgKQorICAgICAgICAgICAgICAgIHsKKyAgICAgICAgICAgICAg ICAgICAgcmFkaXhfdHJlZV9yZXBsYWNlX3Nsb3Qoc2xvdCwKKyAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcmFkaXhfdHJl ZV91bG9uZ190b19wdHIobm9kZS5yYXcpKTsKKyAgICAgICAgICAgICAgICAg ICAgZXJyID0gMDsKKyAgICAgICAgICAgICAgICB9CisgICAgICAgICAgICB9 CisgICAgICAgICAgICBlbHNlCisgICAgICAgICAgICAgICAgQVNTRVJUX1VO UkVBQ0hBQkxFKCk7CisgICAgICAgIH0KIAogICAgICAgICAvKgogICAgICAg ICAgKiBXZSdyZSBub3QgdHJhbnNsYXRlZCwgc28gd2Uga25vdyB0aGF0IGRm bnMgYW5kIG1mbnMgYXJlCiAgICAgICAgICAqIHRoZSBzYW1lIHRoaW5ncywg c28gdGhlIElPTU1VIGVudHJ5IGlzIGFsd2F5cyAxLXRvLTEuCiAgICAgICAg ICAqLwotICAgICAgICBraW5kID0gbWFwa2luZChsZ3QsIHJkLCBtZm4pOwot ICAgICAgICBpZiAoICEob3AtPmZsYWdzICYgR05UTUFQX3JlYWRvbmx5KSAm JgotICAgICAgICAgICAgICEoa2luZCAmIE1BUEtJTkRfV1JJVEUpICkKKyAg ICAgICAgaWYgKCAhKG9wLT5mbGFncyAmIEdOVE1BUF9yZWFkb25seSkgJiYg bm9kZS5jbnQud3IgPT0gMSApCiAgICAgICAgICAgICBraW5kID0gSU9NTVVG X3JlYWRhYmxlIHwgSU9NTVVGX3dyaXRhYmxlOwotICAgICAgICBlbHNlIGlm ICggIWtpbmQgKQorICAgICAgICBlbHNlIGlmICggKG9wLT5mbGFncyAmIEdO VE1BUF9yZWFkb25seSkgJiYKKyAgICAgICAgICAgICAgICAgIG5vZGUuY250 LnJkID09IDEgJiYgIW5vZGUuY250LndyICkKICAgICAgICAgICAgIGtpbmQg PSBJT01NVUZfcmVhZGFibGU7CiAgICAgICAgIGVsc2UKICAgICAgICAgICAg IGtpbmQgPSAwOwotICAgICAgICBpZiAoIGtpbmQgJiYgaW9tbXVfbGVnYWN5 X21hcChsZCwgX2RmbihtZm5feChtZm4pKSwgbWZuLCAwLCBraW5kKSApCisg ICAgICAgIGlmICggZXJyIHx8CisgICAgICAgICAgICAgKGtpbmQgJiYgaW9t bXVfbGVnYWN5X21hcChsZCwgX2RmbihtZm5feChtZm4pKSwgbWZuLCAwLCBr aW5kKSkgKQogICAgICAgICB7Ci0gICAgICAgICAgICBkb3VibGVfZ3RfdW5s b2NrKGxndCwgcmd0KTsKKyAgICAgICAgICAgIGlmICggIWVyciApCisgICAg ICAgICAgICB7CisgICAgICAgICAgICAgICAgaWYgKCBzbG90ICkKKyAgICAg ICAgICAgICAgICB7CisgICAgICAgICAgICAgICAgICAgIG9wLT5mbGFncyAm IEdOVE1BUF9yZWFkb25seSA/IG5vZGUuY250LnJkLS0KKyAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIDogbm9kZS5j bnQud3ItLTsKKyAgICAgICAgICAgICAgICAgICAgcmFkaXhfdHJlZV9yZXBs YWNlX3Nsb3Qoc2xvdCwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgcmFkaXhfdHJlZV91bG9uZ190b19wdHIobm9kZS5y YXcpKTsKKyAgICAgICAgICAgICAgICB9CisgICAgICAgICAgICAgICAgZWxz ZQorICAgICAgICAgICAgICAgICAgICByYWRpeF90cmVlX2RlbGV0ZSgmbGd0 LT5tYXB0cmFja190cmVlLCBtZm5feChtZm4pKTsKKyAgICAgICAgICAgIH0K KwogICAgICAgICAgICAgcmMgPSBHTlRTVF9nZW5lcmFsX2Vycm9yOwotICAg ICAgICAgICAgZ290byB1bmRvX291dDsKICAgICAgICAgfQorCisgICAgICAg IGdyYW50X3dyaXRlX3VubG9jayhsZ3QpOworCisgICAgICAgIGlmICggcmMg IT0gR05UU1Rfb2theSApCisgICAgICAgICAgICBnb3RvIHVuZG9fb3V0Owog ICAgIH0KIAogICAgIFRSQUNFXzFEKFRSQ19NRU1fUEFHRV9HUkFOVF9NQVAs IG9wLT5kb20pOwpAQCAtMTI1MiwxMCArMTI0OSw2IEBAIG1hcF9ncmFudF9y ZWYoCiAgICAgLyoKICAgICAgKiBBbGwgbWFwdHJhY2sgZW50cnkgdXNlcnMg Y2hlY2sgbXQtPmZsYWdzIGZpcnN0IGJlZm9yZSB1c2luZyB0aGUKICAgICAg KiBvdGhlciBmaWVsZHMgc28ganVzdCBlbnN1cmUgdGhlIGZsYWdzIGZpZWxk IGlzIHN0b3JlZCBsYXN0LgotICAgICAqCi0gICAgICogSG93ZXZlciwgaWYg Z250dGFiX25lZWRfaW9tbXVfbWFwcGluZygpIHRoZW4gdGhpcyB3b3VsZCBy YWNlCi0gICAgICogd2l0aCBhIGNvbmN1cnJlbnQgbWFwa2luZCgpIGNhbGwg KG9uIGFuIHVubWFwLCBmb3IgZXhhbXBsZSkKLSAgICAgKiBhbmQgYSBsb2Nr IGlzIHJlcXVpcmVkLgogICAgICAqLwogICAgIG10ID0gJm1hcHRyYWNrX2Vu dHJ5KGxndCwgaGFuZGxlKTsKICAgICBtdC0+ZG9taWQgPSBvcC0+ZG9tOwpA QCAtMTI2Myw5ICsxMjU2LDYgQEAgbWFwX2dyYW50X3JlZigKICAgICBzbXBf d21iKCk7CiAgICAgd3JpdGVfYXRvbWljKCZtdC0+ZmxhZ3MsIG9wLT5mbGFn cyk7CiAKLSAgICBpZiAoIG5lZWRfaW9tbXUgKQotICAgICAgICBkb3VibGVf Z3RfdW5sb2NrKGxndCwgcmd0KTsKLQogICAgIG9wLT5kZXZfYnVzX2FkZHIg PSBtZm5fdG9fbWFkZHIobWZuKTsKICAgICBvcC0+aGFuZGxlICAgICAgID0g aGFuZGxlOwogICAgIG9wLT5zdGF0dXMgICAgICAgPSBHTlRTVF9va2F5OwpA QCAtMTQ4NywxOSArMTQ3NywzNCBAQCB1bm1hcF9jb21tb24oCiAgICAgLyog U2VlIHRoZSByZXNwZWN0aXZlIGNvbW1lbnQgaW4gbWFwX2dyYW50X3JlZigp LiAqLwogICAgIGlmICggcmMgPT0gR05UU1Rfb2theSAmJiBsZCAhPSByZCAm JiBnbnR0YWJfbmVlZF9pb21tdV9tYXBwaW5nKGxkKSApCiAgICAgewotICAg ICAgICB1bnNpZ25lZCBpbnQga2luZDsKKyAgICAgICAgdm9pZCAqKnNsb3Q7 CisgICAgICAgIHVuaW9uIG1hcHRyYWNrX25vZGUgbm9kZTsKICAgICAgICAg aW50IGVyciA9IDA7CiAKLSAgICAgICAgZG91YmxlX2d0X2xvY2sobGd0LCBy Z3QpOworICAgICAgICBncmFudF93cml0ZV9sb2NrKGxndCk7CisgICAgICAg IHNsb3QgPSByYWRpeF90cmVlX2xvb2t1cF9zbG90KCZsZ3QtPm1hcHRyYWNr X3RyZWUsIG1mbl94KG9wLT5tZm4pKTsKKyAgICAgICAgbm9kZS5yYXcgPSBs aWtlbHkoc2xvdCkgPyByYWRpeF90cmVlX3B0cl90b191bG9uZygqc2xvdCkg OiAwOworCisgICAgICAgIC8qIFJlZmNvdW50IG11c3Qgbm90IHVuZGVyZmxv dy4gKi8KKyAgICAgICAgaWYgKCAhKGZsYWdzICYgR05UTUFQX3JlYWRvbmx5 ID8gbm9kZS5jbnQucmQtLQorICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgOiBub2RlLmNudC53ci0tKSApCisgICAgICAgICAgICBC VUcoKTsKIAotICAgICAgICBraW5kID0gbWFwa2luZChsZ3QsIHJkLCBvcC0+ bWZuKTsKLSAgICAgICAgaWYgKCAha2luZCApCisgICAgICAgIGlmICggIW5v ZGUucmF3ICkKICAgICAgICAgICAgIGVyciA9IGlvbW11X2xlZ2FjeV91bm1h cChsZCwgX2RmbihtZm5feChvcC0+bWZuKSksIDApOwotICAgICAgICBlbHNl IGlmICggIShraW5kICYgTUFQS0lORF9XUklURSkgKQorICAgICAgICBlbHNl IGlmICggIShmbGFncyAmIEdOVE1BUF9yZWFkb25seSkgJiYgIW5vZGUuY250 LndyICkKICAgICAgICAgICAgIGVyciA9IGlvbW11X2xlZ2FjeV9tYXAobGQs IF9kZm4obWZuX3gob3AtPm1mbikpLCBvcC0+bWZuLCAwLAogICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBJT01NVUZfcmVhZGFibGUpOwog Ci0gICAgICAgIGRvdWJsZV9ndF91bmxvY2sobGd0LCByZ3QpOworICAgICAg ICBpZiAoIGVyciApCisgICAgICAgICAgICA7CisgICAgICAgIGVsc2UgaWYg KCAhbm9kZS5yYXcgKQorICAgICAgICAgICAgcmFkaXhfdHJlZV9kZWxldGUo JmxndC0+bWFwdHJhY2tfdHJlZSwgbWZuX3gob3AtPm1mbikpOworICAgICAg ICBlbHNlCisgICAgICAgICAgICByYWRpeF90cmVlX3JlcGxhY2Vfc2xvdChz bG90LAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcmFk aXhfdHJlZV91bG9uZ190b19wdHIobm9kZS5yYXcpKTsKKworICAgICAgICBn cmFudF93cml0ZV91bmxvY2sobGd0KTsKIAogICAgICAgICBpZiAoIGVyciAp CiAgICAgICAgICAgICByYyA9IEdOVFNUX2dlbmVyYWxfZXJyb3I7CkBAIC0x OTUxLDYgKzE5NTYsOCBAQCBpbnQgZ3JhbnRfdGFibGVfaW5pdChzdHJ1Y3Qg ZG9tYWluICpkLCBpCiAgICAgICAgIGd0LT5tYXB0cmFjayA9IHZ6YWxsb2Mo Z3QtPm1heF9tYXB0cmFja19mcmFtZXMgKiBzaXplb2YoKmd0LT5tYXB0cmFj aykpOwogICAgICAgICBpZiAoIGd0LT5tYXB0cmFjayA9PSBOVUxMICkKICAg ICAgICAgICAgIGdvdG8gb3V0OworCisgICAgICAgIHJhZGl4X3RyZWVfaW5p dCgmZ3QtPm1hcHRyYWNrX3RyZWUpOwogICAgIH0KIAogICAgIC8qIFNoYXJl ZCBncmFudCB0YWJsZS4gKi8KQEAgLTM3MzQsNiArMzc0MSw3IEBAIGludCBn bnR0YWJfcmVsZWFzZV9tYXBwaW5ncyhzdHJ1Y3QgZG9tYWkKICAgICBmb3Ig KCBoYW5kbGUgPSBndC0+bWFwdHJhY2tfbGltaXQ7IGhhbmRsZTsgKQogICAg IHsKICAgICAgICAgdW5zaWduZWQgaW50IGNsZWFyX2ZsYWdzID0gMDsKKyAg ICAgICAgbWZuX3QgbWZuOwogCiAgICAgICAgIC8qCiAgICAgICAgICAqIERl YWwgd2l0aCBmdWxsIHBhZ2VzIHN1Y2ggdGhhdCB0aGVpciBmcmVlaW5nIChp biB0aGUgYm9keSBvZiB0aGUKQEAgLTM4MzksMTcgKzM4NDcsMzEgQEAgaW50 IGdudHRhYl9yZWxlYXNlX21hcHBpbmdzKHN0cnVjdCBkb21haQogICAgICAg ICBpZiAoIGNsZWFyX2ZsYWdzICkKICAgICAgICAgICAgIGdudHRhYl9jbGVh cl9mbGFncyhyZCwgY2xlYXJfZmxhZ3MsIHN0YXR1cyk7CiAKKyAgICAgICAg bWZuID0gYWN0LT5tZm47CisKICAgICAgICAgYWN0aXZlX2VudHJ5X3JlbGVh c2UoYWN0KTsKICAgICAgICAgZ3JhbnRfcmVhZF91bmxvY2socmd0KTsKIAog ICAgICAgICByY3VfdW5sb2NrX2RvbWFpbihyZCk7CiAKICAgICAgICAgbWFw LT5mbGFncyA9IDA7CisKKyAgICAgICAgLyoKKyAgICAgICAgICogVGhpcyBp cyBleGNlc3NpdmUgaW4gdGhhdCBhIHNpbmdsZSBzdWNoIGNhbGwgd291bGQg c3VmZmljZSBwZXIKKyAgICAgICAgICogbWFwcGVkIE1GTiAob3Igbm9uZSBh dCBhbGwsIGlmIG5vIGVudHJ5IHdhcyBldmVyIGluc2VydGVkKS4gQnV0IGl0 CisgICAgICAgICAqIHNob3VsZCBiZSB0aGUgY29tbW9uIGNhc2UgZm9yIGFu IE1GTiB0byBiZSBtYXBwZWQganVzdCBvbmNlLCBhbmQKKyAgICAgICAgICog dGhpcyB3YXkgd2UgZG9uJ3QgbmVlZCB0byBmdXJ0aGVyIG1haW50YWluIHRo ZSBjb3VudGVycy4gV2UgYWxzbworICAgICAgICAgKiBkb24ndCB3YW50IHRv IGxlYXZlIGNsZWFuaW5nIHVwIG9mIHRoZSB0cmVlIGFzIGEgd2hvbGUgdG8g dGhlIGVuZAorICAgICAgICAgKiBvZiB0aGUgZnVuY3Rpb24sIGFzIHRoaXMg Y291bGQgdGFrZSBxdWl0ZSBzb21lIHRpbWUuCisgICAgICAgICAqLworICAg ICAgICByYWRpeF90cmVlX2RlbGV0ZSgmZ3QtPm1hcHRyYWNrX3RyZWUsIG1m bl94KG1mbikpOwogICAgIH0KIAogICAgIGd0LT5tYXB0cmFja19saW1pdCA9 IDA7CiAgICAgRlJFRV9YRU5IRUFQX1BBR0UoZ3QtPm1hcHRyYWNrWzBdKTsK IAorICAgIHJhZGl4X3RyZWVfZGVzdHJveSgmZ3QtPm1hcHRyYWNrX3RyZWUs IE5VTEwpOworCiAgICAgcmV0dXJuIDA7CiB9CiAKLS0tIGEveGVuL2luY2x1 ZGUveGVuL3JhZGl4LXRyZWUuaAorKysgYi94ZW4vaW5jbHVkZS94ZW4vcmFk aXgtdHJlZS5oCkBAIC0xOTAsNiArMTkwLDI1IEBAIHN0YXRpYyBpbmxpbmUg aW50IHJhZGl4X3RyZWVfcHRyX3RvX2ludCgKICAgICByZXR1cm4gKGludCko KGxvbmcpcHRyID4+IDIpOwogfQogCisvKioKKyAqIHJhZGl4X3RyZWVfe3Vs b25nX3RvX3B0cixwdHJfdG9fdWxvbmd9OgorICoKKyAqIFNhbWUgZm9yIHVu c2lnbmVkIGxvbmcgdmFsdWVzLiBCZXdhcmUgdGhvdWdoIHRoYXQgb25seSBC SVRTX1BFUl9MT05HLTIKKyAqIGJpdHMgYXJlIGFjdHVhbGx5IHVzYWJsZSBm b3IgdGhlIHZhbHVlLgorICovCitzdGF0aWMgaW5saW5lIHZvaWQgKnJhZGl4 X3RyZWVfdWxvbmdfdG9fcHRyKHVuc2lnbmVkIGxvbmcgdmFsKQoreworICAg IHVuc2lnbmVkIGxvbmcgcHRyID0gKHZhbCA8PCAyKSB8IDB4MjsKKyAgICBB U1NFUlQoKHB0ciA+PiAyKSA9PSB2YWwpOworICAgIHJldHVybiAodm9pZCAq KXB0cjsKK30KKworc3RhdGljIGlubGluZSB1bnNpZ25lZCBsb25nIHJhZGl4 X3RyZWVfcHRyX3RvX3Vsb25nKHZvaWQgKnB0cikKK3sKKyAgICBBU1NFUlQo KCh1bnNpZ25lZCBsb25nKXB0ciAmIDB4MykgPT0gMHgyKTsKKyAgICByZXR1 cm4gKHVuc2lnbmVkIGxvbmcpcHRyID4+IDI7Cit9CisKIGludCByYWRpeF90 cmVlX2luc2VydChzdHJ1Y3QgcmFkaXhfdHJlZV9yb290ICosIHVuc2lnbmVk IGxvbmcsIHZvaWQgKik7CiB2b2lkICpyYWRpeF90cmVlX2xvb2t1cChzdHJ1 Y3QgcmFkaXhfdHJlZV9yb290ICosIHVuc2lnbmVkIGxvbmcpOwogdm9pZCAq KnJhZGl4X3RyZWVfbG9va3VwX3Nsb3Qoc3RydWN0IHJhZGl4X3RyZWVfcm9v dCAqLCB1bnNpZ25lZCBsb25nKTsK --=separator-- From xen-devel-bounces@lists.xenproject.org Wed Sep 01 09:32:56 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Sep 2021 09:32:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.176195.320669 (Exim 4.92) (envelope-from ) id 1mLMbs-0000MC-G9; Wed, 01 Sep 2021 09:32:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 176195.320669; Wed, 01 Sep 2021 09:32:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLMbs-0000M5-D9; Wed, 01 Sep 2021 09:32:44 +0000 Received: by outflank-mailman (input) for mailman id 176195; Wed, 01 Sep 2021 09:32:42 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLMbq-0000LW-Ok; Wed, 01 Sep 2021 09:32:42 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLMbq-00073c-Hy; Wed, 01 Sep 2021 09:32:42 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLMbp-00014L-98; Wed, 01 Sep 2021 09:32:41 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mLMbp-00014r-8b; Wed, 01 Sep 2021 09:32:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=EdBIv1pfTVLmatmwiIhji2JZc4VYFRPftioRwfnDEnI=; b=1vLvU3zXy2fwphOWsZvpsqiMKz ZygFPPoMyiKsBcC4TW0CD49mNK5m/ayPDNdjaDQGNswb6mS12xpPLgGTl8lFerOTI3m2BgXm0PJCt MHU1ve3WZRAlcywhx3wUF0R/X6NxUVkpZffvo1HgqiflSrXOZ5Ti27jlz0gs69jlw0jI=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.11-testing test] 164676: regressions - FAIL X-Osstest-Failures: xen-4.11-testing:test-amd64-amd64-xl-qemuu-ovmf-amd64:debian-hvm-install:fail:regression xen-4.11-testing:test-amd64-i386-xl-qemuu-ovmf-amd64:debian-hvm-install:fail:regression xen-4.11-testing:test-arm64-arm64-xl-credit2:xen-boot:fail:heisenbug xen-4.11-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-4.11-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.11-testing:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:debian-hvm-install:fail:nonblocking xen-4.11-testing:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:debian-hvm-install:fail:nonblocking xen-4.11-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.11-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-4.11-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-4.11-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.11-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.11-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.11-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.11-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.11-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.11-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.11-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.11-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.11-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.11-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.11-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.11-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.11-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-4.11-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-4.11-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.11-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.11-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-4.11-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-4.11-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-4.11-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-4.11-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.11-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-4.11-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.11-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-4.11-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-4.11-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-4.11-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-4.11-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-4.11-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-4.11-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-4.11-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-4.11-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-4.11-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-4.11-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-4.11-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.11-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-4.11-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-4.11-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-4.11-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-4.11-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.11-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.11-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-4.11-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-4.11-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-4.11-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=ec4654ce64d87f14567008cfb42568fd434f1bed X-Osstest-Versions-That: xen=ef32c7afa2731b758226d6e10a1e489b1a15fc41 From: osstest service owner Date: Wed, 01 Sep 2021 09:32:41 +0000 flight 164676 xen-4.11-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/164676/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-ovmf-amd64 12 debian-hvm-install fail REGR. vs. 162548 test-amd64-i386-xl-qemuu-ovmf-amd64 12 debian-hvm-install fail REGR. vs. 162548 Tests which are failing intermittently (not blocking): test-arm64-arm64-xl-credit2 8 xen-boot fail pass in 164625 Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-credit2 15 migrate-support-check fail in 164625 never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail in 164625 never pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 12 debian-hvm-install fail like 162548 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 12 debian-hvm-install fail like 162548 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 162548 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 162548 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 162548 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 162548 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 162548 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 162548 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 162548 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 162548 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 162548 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 162548 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 162548 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass version targeted for testing: xen ec4654ce64d87f14567008cfb42568fd434f1bed baseline version: xen ef32c7afa2731b758226d6e10a1e489b1a15fc41 Last test of basis 162548 2021-06-08 18:37:00 Z 84 days Testing same since 164486 2021-08-25 14:05:55 Z 6 days 5 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Jan Beulich Jason Andryuk Roger Pau Monné jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 450 lines long.) From xen-devel-bounces@lists.xenproject.org Wed Sep 01 09:33:34 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Sep 2021 09:33:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.176159.320683 (Exim 4.92) (envelope-from ) id 1mLMcg-0001B2-0C; Wed, 01 Sep 2021 09:33:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 176159.320683; Wed, 01 Sep 2021 09:33:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLMcf-0001Av-Rl; Wed, 01 Sep 2021 09:33:33 +0000 Received: by outflank-mailman (input) for mailman id 176159; Wed, 01 Sep 2021 09:31:09 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLMaL-00066x-L3 for xen-devel@lists.xen.org; Wed, 01 Sep 2021 09:31:09 +0000 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 50e6d84a-0b07-11ec-adbd-12813bfff9fa; Wed, 01 Sep 2021 09:30:59 +0000 (UTC) Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLMZy-0006zN-V2; Wed, 01 Sep 2021 09:30:46 +0000 Received: from iwj by xenbits.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mLMZy-0006TJ-Rw; Wed, 01 Sep 2021 09:30:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 50e6d84a-0b07-11ec-adbd-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Date:Message-Id:Subject:CC:From:To:MIME-Version: Content-Transfer-Encoding:Content-Type; bh=+rCVNnLKnAbp2uXbXH1bwsbzmEqZNGPyQGmZ8gq+7kE=; b=XVzq51vovCfFiKqUSm6Ks3HKws fa7WW4d9ebxm6BNl1z7XocAuZjsDUp3PGUxHPto1K+pgyM7YYj1Q/MivtuVo2QCBsyn41GUVrbVWt 9krhcgY0GfWpIxXHH9ziFnXtd1cfQL0mmP77a+nu0AzyaXr+SA2LqYsaSjXtmqxgNmtc=; Content-Type: multipart/mixed; boundary="=separator"; charset="utf-8" Content-Transfer-Encoding: binary MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) To: xen-announce@lists.xen.org, xen-devel@lists.xen.org, xen-users@lists.xen.org, oss-security@lists.openwall.com From: Xen.org security team CC: Xen.org security team Subject: Xen Security Advisory 378 v3 (CVE-2021-28694,CVE-2021-28695,CVE-2021-28696) - IOMMU page mapping issues on x86 Message-Id: Date: Wed, 01 Sep 2021 09:30:46 +0000 --=separator Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Xen Security Advisory CVE-2021-28694,CVE-2021-28695,CVE-2021-28696 / XSA-378 version 3 IOMMU page mapping issues on x86 UPDATES IN VERSION 3 ==================== Warn about dom0=pvh breakage in Resolution section. ISSUE DESCRIPTION ================= Both AMD and Intel allow ACPI tables to specify regions of memory which should be left untranslated, which typically means these addresses should pass the translation phase unaltered. While these are typically device specific ACPI properties, they can also be specified to apply to a range of devices, or even all devices. On all systems with such regions Xen failed to prevent guests from undoing/replacing such mappings (CVE-2021-28694). On AMD systems, where a discontinuous range is specified by firmware, the supposedly-excluded middle range will also be identity-mapped (CVE-2021-28695). Further, on AMD systems, upon de-assigment of a physical device from a guest, the identity mappings would be left in place, allowing a guest continued access to ranges of memory which it shouldn't have access to anymore (CVE-2021-28696). IMPACT ====== The precise impact is system specific, but can - on affected systems - be any or all of privilege escalation, denial of service, or information leaks. VULNERABLE SYSTEMS ================== The vulnerability is only exploitable by guests granted access to physical devices (ie, via PCI passthrough). All versions of Xen are affected. Only x86 systems with IOMMUs and with firmware specifying memory regions to be identity mapped are affected. Other x86 systems are not affected. Whether a particular system whose ACPI tables declare such memory region(s) is actually affected cannot be known without knowing when and/or how these regions are used. For example, if these regions were used only during system boot, there would not be any vulnerability. The necessary knowledge can only be obtained from, collectively, the hardware and firmware manufacturers. On Arm hardware IOMMU use is not security supported. Accordingly, we have not undertaken an analysis of these issues for Arm systems. MITIGATION ========== Not permitting untrusted guests access to phsyical devices will avoid the vulnerability. Likewise, limiting untrusted guest access to physical devices whose firmware-provided ACPI tables declare identity mappings, will avoid the vulnerability. (Provided that there are no identity mapped regions which are specified by the ACPI tables to apply globally.) Note that a system is still vulnerable if a guest was trusted, while it had such a device assigned, and then has the device removed in anticipation of the guest becoming untrusted (because of, for example, the insertion of an untrusted kernel module), CREDITS ======= This issue was discovered by Jan Beulich of SUSE. RESOLUTION ========== Applying the appropriate set of attached patches resolves this issue. However, these patches are known to badly break PVH dom0 support. Work is ongoing to resolve the problem, and will be committed to the appropriate Xen trees (including backports) when ready. PVH dom0 has "Technical Preview" status so we do not intend to distribute the fixes via an update to this advisory Note that patches for released versions are generally prepared to apply to the stable branches, and may not apply cleanly to the most recent release tarball. Downstreams are encouraged to update to the tip of the stable branch before applying these patches. xsa378/xsa378-?.patch xen-unstable xsa378/xsa378-4.15-?.patch Xen 4.15.x xsa378/xsa378-4.14-?.patch Xen 4.14.x xsa378/xsa378-4.13-*.patch Xen 4.13.x xsa378/xsa378-4.12-*.patch Xen 4.12.x xsa378/xsa378-4.11-*.patch Xen 4.11.x $ sha256sum xsa378* xsa378*/* b3b49681468bd2be4b95fc1d3861493bbea63bac1c115a12ece76d0313b6a81c xsa378.meta 2560d4418e6b6d022b4e7fe1f84906ca13b3180537e746ee81cd3f97f0e86c35 xsa378/xsa378-1.patch 134b207c38f8d76bbc218220f1e61f82780e8166818ef51217716023cc27ce3c xsa378/xsa378-2.patch c166ef60e08a80440f79d92abe8488b123c8017e7633dbddacb95b20899f9b2b xsa378/xsa378-3.patch a2677e157724f57f65165f361a309c417d123ff009168f16d3a0e342b7a601eb xsa378/xsa378-4.11-0a.patch 832f52f420bb47784bdefd75edd1ca521658327aafb94b4f3586da522d0d19c1 xsa378/xsa378-4.11-0b.patch 9eb7c53892f01424eec6b788f879b36dd75a6f89b1c8b9c973237603525d6546 xsa378/xsa378-4.11-0c.patch 48021fb9a2c52d7939fd11bbba80c67a5a5b6cae2039b4b2a2c6203eb5841260 xsa378/xsa378-4.11-1.patch 4f3fd39aa328c1e397aa2a10b92e98cc341908a8834302a4fc0f230876dd3570 xsa378/xsa378-4.11-2.patch 6e2eeecd2ccc4029f80888263f44b80acf078d69aeffda4d6accd8b2d0899182 xsa378/xsa378-4.11-3.patch 194b27510c8765f1cf8abee57624a075ab26f4f889aa8c201e126643f570f55a xsa378/xsa378-4.11-4.patch e8f4eab0984a7db2ca0c6c9ac0fb9107e45ddd572a36454db4a1bdb8b9a8b0c6 xsa378/xsa378-4.11-5.patch 943c7556be47b1a0f2273cf5691fe70dc65e6cb50ff0477d1d61eb3f0ba87a97 xsa378/xsa378-4.11-6.patch 2eb572e1a55caa4aca31f74a3844135a204c4e023a6776d7adc4f4043663fb99 xsa378/xsa378-4.11-7.patch 7c24ba33461d3adcb195a6611df3e9c0501e9dcacf9b8811456450b291d23edf xsa378/xsa378-4.11-8.patch fe14ea6699df673b787f93ff821838f2280407674df0c8c06d40efe8320e8748 xsa378/xsa378-4.12-0a.patch 1ba10aef9ea99c4455a34e61792ca65ea6b2ece56f05cd0b4adc14600a7ae346 xsa378/xsa378-4.12-0b.patch 2c2dbc0c18b695c1d2c93e4137228f82b6d21d895c3165a9e29ddea3db78e36a xsa378/xsa378-4.12-0c.patch 48021fb9a2c52d7939fd11bbba80c67a5a5b6cae2039b4b2a2c6203eb5841260 xsa378/xsa378-4.12-1.patch f0d62506ccdf081d0efbb553e2d33f17a084272d21f43bf95d11fda2dcc8a3fa xsa378/xsa378-4.12-2.patch e266512b18fc30e5bd4884cd720aa81644d3ca3323b38fe1f77d06fa98dd515d xsa378/xsa378-4.12-3.patch 076f9955593a8ebdea5f24ed302b8a1004bbf50da4c8becf1f93764066b8981c xsa378/xsa378-4.12-4.patch 9639bc35636ffae4e2b6dd026387347960c1fb986cb2924a18314a72e6b6ec0a xsa378/xsa378-4.12-5.patch 32dd659aa365d9f8197d99b9334c22b33e9ce805e30376457df6e507f92282c8 xsa378/xsa378-4.12-6.patch 7eaae2fa968eb11e27277141456cc1bd657025aee738221c368e153535c7c0f4 xsa378/xsa378-4.12-7.patch 05982f43f35b580ff41f74b1280e469e0dd20176f184ec04a4874303c2aa3ad1 xsa378/xsa378-4.12-8.patch c6f551ef9903a343b47692b34a63c70165a2dbf74878a6be6511cdffd55a7e8c xsa378/xsa378-4.13-0a.patch 223cd63f7e1c39d862b8654da698455ded65ecb5abae0f57c330921522b7fdb4 xsa378/xsa378-4.13-0b.patch 5c33aa24f14e779dfe914e809cff11260083169a3adfb07a31ce11243d80b3ef xsa378/xsa378-4.13-0c.patch 1d55426ff6a41f0ef4cbd2c943edafff394157703bb0b6ae751564abf93b5ee7 xsa378/xsa378-4.13-1.patch 4d5e7d5e65cd28d6bc7d1a9f2ab24f09dfaef295c4199d5f2db00915dcaa174f xsa378/xsa378-4.13-2.patch 78df0bcb347f8bb45827f74b191aad36b6e907eb38c6d535035f2b2739645551 xsa378/xsa378-4.13-3.patch 237c33e0ae01a23db01721afb8e6a39101bfe081f8b75dbcff6b9fa9c9aaceda xsa378/xsa378-4.13-4.patch 7d2f3ae3881d28073be54a6dfb35f13004e4efee742952788430201d86307ecf xsa378/xsa378-4.13-5.patch 2ecd7580394667db0c41e4819025393e59ae24d6c97d54451c8e683585057367 xsa378/xsa378-4.13-6.patch 592a03d00e5d22d7a3c001681968dc469c70b3e57998b95877388e9528904ea2 xsa378/xsa378-4.13-7.patch 54e6a095f706c66dbbd74e39aa1d88031c9b537589e73ceb2925e2f0cc1854f0 xsa378/xsa378-4.13-8.patch 1d55426ff6a41f0ef4cbd2c943edafff394157703bb0b6ae751564abf93b5ee7 xsa378/xsa378-4.14-1.patch 86fbd88eb8a358575e42cf335c444b047ddb4d2f1c6a1bc6f9e57e6ac0041074 xsa378/xsa378-4.14-2.patch 0a23e5f93ff1bb55f003a56e0ef8c531384b164f0e840f5794acdb9ae3e91996 xsa378/xsa378-4.14-3.patch e2226f7ddae1d24dbee8cf19efa8d67ebf312f3d10641cb9aec21d68a3c8f818 xsa378/xsa378-4.14-4.patch f2cf8f7e4aa0460e606b5564adde366332ed323c4d5e3f957e64299ef1bc9baf xsa378/xsa378-4.14-5.patch 7811426975757e3bb8c6ab3161ba2354e1780b55b9e6be7928229d5f23bf79b6 xsa378/xsa378-4.14-6.patch 58147bd6c0ea4e08e84a17afc796be4bbe53e6fbc1d393f9fe3c6191fd33eba5 xsa378/xsa378-4.14-7.patch 682a011d807a7c284faf0ec9d2cf0aabaddbc658979dea2b9ccbc007b660f9c5 xsa378/xsa378-4.14-8.patch a00ada0cd673f0909cc7b462cb532dbd6fe17601e06bd84272f5ff1857ea4c73 xsa378/xsa378-4.15-1.patch d74cc325be1e47d61ba3b1400837af35d044bf1d25806aa98926ec262f80bddd xsa378/xsa378-4.15-2.patch 2ad685a04dbbdd2c81761b58146e70059b8a8a92b0c1176f36933510293ece5b xsa378/xsa378-4.15-3.patch 18de9facccd70ce49dd839e219fe71667c43110e474e5d7b56a503a5786fc7e0 xsa378/xsa378-4.15-4.patch 296558b27ba82176f6d06b721102c8ba7c7e6e99d29b29392ea82244e88df0b9 xsa378/xsa378-4.15-5.patch 5d7cc84c66daf0aceab9407fa72f2827024c847f4ca10f8d123eee87b7451aba xsa378/xsa378-4.15-6.patch fd4aa4447562230a6684d17e6e4c55f1e48df4773247f66ab9d01181003bc9aa xsa378/xsa378-4.15-7.patch 5305e3bc513bcd3e016ca3bbecc6cae38c8ed2b2eacb13e82f7b1f4401d3b67d xsa378/xsa378-4.15-8.patch 78390bf59344ea5dcbfa5831db3634b3f1b3aabf029160c72cdbeeec2b46b2a9 xsa378/xsa378-4.patch 76fb4a1f2604b98d3a803744ad212b3984117ec8c8011ad6db3759f9337a9b5a xsa378/xsa378-5.patch a627f8c6b7d2ffac0b6de945189f96b718aeab8e0c8bb11476a40585d6411bd7 xsa378/xsa378-6.patch 28814b51fabd3c5cb3ca249ad291781f589cddd55fc8152fdd5668c5fcdc727c xsa378/xsa378-7.patch 30e31749ade75fd5ab4c41fa27fe2124bdcc602ccc803a85e5eeec1b9c48a9c1 xsa378/xsa378-8.patch $ DEPLOYMENT DURING EMBARGO ========================= Deployment of the patches and/or mitigations described above (or others which are substantially similar) is permitted during the embargo, even on public-facing systems with untrusted guest users and administrators. But: Distribution of updated software is prohibited (except to other members of the predisclosure list). Predisclosure list members who wish to deploy significantly different patches and/or mitigations, please contact the Xen Project Security Team. (Note: this during-embargo deployment notice is retained in post-embargo publicly released Xen Project advisories, even though it is then no longer applicable. This is to enable the community to have oversight of the Xen Project Security Team's decisionmaking.) For more information about permissible uses of embargoed information, consult the Xen Project community's agreed Security Policy: http://www.xenproject.org/security-policy.html -----BEGIN PGP SIGNATURE----- iQFABAEBCAAqFiEEI+MiLBRfRHX6gGCng/4UyVfoK9kFAmEvSCUMHHBncEB4ZW4u b3JnAAoJEIP+FMlX6CvZrUYH/iYMkjMzUpv5ik/quZ+z34uXwq/mD8x8ROZKXDev tgojXcFo0vNlcr71R0J5KrE0YeX+3MjbjqbF7A30cnw4/bgmvhzcdP/fwOfIKFYE JqaGoDaxFRpsIMvHFXV6OxtjgBgleUukaikUrcwWUG+L90KMmjqZU4IAlNcBAALC J6rDB8nHqD1s+ODIPdPE149jIE7LJfVqyuu9h4r/jmLEDRJBS2YEs6zgClqnIApl 3WBpZNhp8Tk3BFtbQcu4Uh9c0itymtp+8VsY0xzF2bWsE4aoe5DKHv0DyTSLe9Md pMG0egH7ZrI3MV4nzHdbhkA2Hn3X0rsJiI7TXpmmQPmgi4g= =A/oT -----END PGP SIGNATURE----- --=separator Content-Type: application/octet-stream; name="xsa378.meta" Content-Disposition: attachment; filename="xsa378.meta" Content-Transfer-Encoding: base64 ewogICJYU0EiOiAzNzgsCiAgIlN1cHBvcnRlZFZlcnNpb25zIjogWwogICAg Im1hc3RlciIsCiAgICAiNC4xNSIsCiAgICAiNC4xNCIsCiAgICAiNC4xMyIs CiAgICAiNC4xMiIsCiAgICAiNC4xMSIKICBdLAogICJUcmVlcyI6IFsKICAg ICJ4ZW4iCiAgXSwKICAiUmVjaXBlcyI6IHsKICAgICI0LjExIjogewogICAg ICAiUmVjaXBlcyI6IHsKICAgICAgICAieGVuIjogewogICAgICAgICAgIlN0 YWJsZVJlZiI6ICJlZjMyYzdhZmEyNzMxYjc1ODIyNmQ2ZTEwYTFlNDg5YjFh MTVmYzQxIiwKICAgICAgICAgICJQcmVyZXFzIjogW10sCiAgICAgICAgICAi UGF0Y2hlcyI6IFsKICAgICAgICAgICAgInhzYTM3OC94c2EzNzgtNC4xMS0q LnBhdGNoIgogICAgICAgICAgXQogICAgICAgIH0KICAgICAgfQogICAgfSwK ICAgICI0LjEyIjogewogICAgICAiUmVjaXBlcyI6IHsKICAgICAgICAieGVu IjogewogICAgICAgICAgIlN0YWJsZVJlZiI6ICJlYTIwZWVlOTdlOWUwODYx MTI3YTgwNzBjYzdiOWFlMzU1N2IwOWZiIiwKICAgICAgICAgICJQcmVyZXFz IjogWwogICAgICAgICAgICAzODMKICAgICAgICAgIF0sCiAgICAgICAgICAi UGF0Y2hlcyI6IFsKICAgICAgICAgICAgInhzYTM3OC94c2EzNzgtNC4xMi0q LnBhdGNoIgogICAgICAgICAgXQogICAgICAgIH0KICAgICAgfQogICAgfSwK ICAgICI0LjEzIjogewogICAgICAiUmVjaXBlcyI6IHsKICAgICAgICAieGVu IjogewogICAgICAgICAgIlN0YWJsZVJlZiI6ICIzMmQ1ODA5MDJiOTU5MDAw ZDc5ZDUxZGZmMDNhMzU2MDY1M2M0ZmNiIiwKICAgICAgICAgICJQcmVyZXFz IjogWwogICAgICAgICAgICAzODMKICAgICAgICAgIF0sCiAgICAgICAgICAi UGF0Y2hlcyI6IFsKICAgICAgICAgICAgInhzYTM3OC94c2EzNzgtNC4xMy0q LnBhdGNoIgogICAgICAgICAgXQogICAgICAgIH0KICAgICAgfQogICAgfSwK ICAgICI0LjE0IjogewogICAgICAiUmVjaXBlcyI6IHsKICAgICAgICAieGVu IjogewogICAgICAgICAgIlN0YWJsZVJlZiI6ICI0OTI5OWM0ODEzYjc4NDdk MjlkZjA3YmY3OTBmNTQ4OTA2MGYyYTljIiwKICAgICAgICAgICJQcmVyZXFz IjogWwogICAgICAgICAgICAzODMKICAgICAgICAgIF0sCiAgICAgICAgICAi UGF0Y2hlcyI6IFsKICAgICAgICAgICAgInhzYTM3OC94c2EzNzgtNC4xNC0q LnBhdGNoIgogICAgICAgICAgXQogICAgICAgIH0KICAgICAgfQogICAgfSwK ICAgICI0LjE1IjogewogICAgICAiUmVjaXBlcyI6IHsKICAgICAgICAieGVu IjogewogICAgICAgICAgIlN0YWJsZVJlZiI6ICJkYmE3NzQ4OTZmN2RkNzQ3 NzNjMTRkNTM3NjQzYjdkNzQ3N2ZlZmNkIiwKICAgICAgICAgICJQcmVyZXFz IjogWwogICAgICAgICAgICAzODMKICAgICAgICAgIF0sCiAgICAgICAgICAi UGF0Y2hlcyI6IFsKICAgICAgICAgICAgInhzYTM3OC94c2EzNzgtNC4xNS0q LnBhdGNoIgogICAgICAgICAgXQogICAgICAgIH0KICAgICAgfQogICAgfSwK ICAgICJtYXN0ZXIiOiB7CiAgICAgICJSZWNpcGVzIjogewogICAgICAgICJ4 ZW4iOiB7CiAgICAgICAgICAiU3RhYmxlUmVmIjogIjI1ZGE5NDU1ZjFiYjhh NmQzMzAzOTU3NWE3YjI4YmRmYzRlM2ZjZmUiLAogICAgICAgICAgIlByZXJl cXMiOiBbCiAgICAgICAgICAgIDM4MwogICAgICAgICAgXSwKICAgICAgICAg ICJQYXRjaGVzIjogWwogICAgICAgICAgICAieHNhMzc4L3hzYTM3OC0/LnBh dGNoIgogICAgICAgICAgXQogICAgICAgIH0KICAgICAgfQogICAgfQogIH0K fQ== --=separator Content-Type: application/octet-stream; name="xsa378/xsa378-1.patch" Content-Disposition: attachment; filename="xsa378/xsa378-1.patch" Content-Transfer-Encoding: base64 RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0 OiBBTUQvSU9NTVU6IGNvcnJlY3QgZ2xvYmFsIGV4Y2x1c2lvbiByYW5nZSBl eHRlbmRpbmcKCkJlc2lkZXMgdW5pdHkgbWFwcGluZyByZWdpb25zLCB0aGUg QU1EIElPTU1VIHNwZWMgYWxzbyBwcm92aWRlcyBmb3IKZXhjbHVzaW9uIHJh bmdlcyAoYXJlYXMgb2YgbWVtb3J5IG5vdCB0byBiZSBzdWJqZWN0IHRvIERN QSB0cmFuc2xhdGlvbikKdG8gYmUgc3BlY2lmaWVkIGJ5IGZpcm13YXJlIGlu IHRoZSBBQ1BJIHRhYmxlcy4gVGhlIHNwZWMgZG9lcyBub3QgcHV0CmFueSBj b25zdHJhaW50cyBvbiB0aGUgbnVtYmVyIG9mIHN1Y2ggcmVnaW9ucy4KCkJs aW5kbHkgYXNzdW1pbmcgYWxsIGFkZHJlc3NlcyBiZXR3ZWVuIGFueSB0d28g c3VjaCByYW5nZXMgc2hvdWxkIGFsc28KYmUgZXhjbHVkZWQgY2FuJ3QgYmUg cmlnaHQuIFNpbmNlIGhhcmR3YXJlIGhhcyByb29tIGZvciBqdXN0IGEgc2lu Z2xlCnN1Y2ggcmFuZ2UgKGNvbXByaXNlZCBvZiB0aGUgRXhjbHVzaW9uIEJh c2UgUmVnaXN0ZXIgYW5kIHRoZSBFeGNsdXNpb24KUmFuZ2UgTGltaXQgUmVn aXN0ZXIpLCBjb21iaW5lIG9ubHkgYWRqYWNlbnQgb3Igb3ZlcmxhcHBpbmcg cmVnaW9ucyAoZm9yCm5vdzsgdGhpcyBtYXkgcmVxdWlyZSBmdXJ0aGVyIGFk anVzdG1lbnQgaW4gY2FzZSB0YWJsZSBlbnRyaWVzIGFyZW4ndApzb3J0ZWQg YnkgYWRkcmVzcykgd2l0aCBtYXRjaGluZyBleGNsdXNpb25fYWxsb3dfYWxs IHNldHRpbmdzLiBUaGlzCnJlcXVpcmVzIGJ1YmJsaW5nIHVwIGVycm9yIGlu ZGljYXRvcnMsIHN1Y2ggdGhhdCBJT01NVSBpbml0IGNhbiBiZQpmYWlsZWQg d2hlbiBjb25jYXRlbmF0aW9uIHdhc24ndCBwb3NzaWJsZS4KCkZ1cnRoZXJt b3JlLCBzaW5jZSB0aGUgZXhjbHVzaW9uIHJhbmdlIHNwZWNpZmllZCBpbiBJ T01NVSByZWdpc3RlcnMKaW1wbGllcyBSL1cgYWNjZXNzLCByZWplY3QgcmVx dWVzdHMgYXNraW5nIGZvciBsZXNzIHBlcm1pc3Npb25zICh0aGlzCndpbGwg YmUgYnJvdWdodCBjbG9zZXIgdG8gdGhlIHNwZWMgYnkgYSBzdWJzZXF1ZW50 IGNoYW5nZSkuCgpUaGlzIGlzIHBhcnQgb2YgWFNBLTM3OCAvIENWRS0yMDIx LTI4Njk1LgoKU2lnbmVkLW9mZi1ieTogSmFuIEJldWxpY2ggPGpiZXVsaWNo QHN1c2UuY29tPgpSZXZpZXdlZC1ieTogUGF1bCBEdXJyYW50IDxwYXVsQHhl bi5vcmc+Ci0tLQp2ODogQWRkIGNvbW1lbnRzIHRvIHBsYWluIHRydWUvZmFs c2UgZnVuY3Rpb24gYXJndW1lbnRzLgp2NDogRG9uJ3QgYWNjZXB0IHJlcXVl c3RzIG5vdCBhbGxvd2luZyBmb3IgYm90aCByZWFkaW5nIGFuZCB3cml0aW5n LgogICAgRG9uJ3QgYWNjZXB0IG1pc21hdGNoZXMgaW4gdGhlIGV4Y2x1c2lv bl9hbGxvd19hbGwgc2V0dGluZy4gQ292ZXIKICAgIGZvciB0aGUgZHJvcHBp bmcgb2YgImNvcnJlY3QgbGltaXQgY2FsY3VsYXRpb24gaW4gSVZNRCBwYXJz aW5nIi4KdjI6IEFjY2VwdCBvdmVybGFwcGluZyByZWdpb25zIGFzIHdlbGwu Ci0tLQpUQkQ6IFNob3VsZCB3ZSBhc3N1bWUgcmFuZG9tIG9yZGVyIG9mIGVu dHJpZXMgcmlnaHQgYXdheT8KVEJEOiBBbmRyZXcgc3VnZ2VzdHMgdGhlcmUg YXJlIGluZGljYXRpb25zIG9mIG9ubHkgb25lIGdsb2JhbCBleGNsdXNpb24K ICAgICByYW5nZSBiZWluZyBhbGxvd2VkLCB3aGljaCB3b3VsZCB0aGVuIChw cmVzdW1hYmx5KSBiZSB0aWVkIHRvCiAgICAgQUNQSV9JVk1EX0VYQ0xVU0lP Tl9SQU5HRSAoYXMgcGVyIGFib3ZlKS4KCi0tLSBhL3hlbi9kcml2ZXJzL3Bh c3N0aHJvdWdoL2FtZC9pb21tdV9hY3BpLmMKKysrIGIveGVuL2RyaXZlcnMv cGFzc3Rocm91Z2gvYW1kL2lvbW11X2FjcGkuYwpAQCAtMTE2LDEyICsxMTYs MjEgQEAgc3RhdGljIHN0cnVjdCBhbWRfaW9tbXUgKiBfX2luaXQgZmluZF9p bwogICAgIHJldHVybiBOVUxMOwogfQogCi1zdGF0aWMgdm9pZCBfX2luaXQg cmVzZXJ2ZV9pb21tdV9leGNsdXNpb25fcmFuZ2UoCi0gICAgc3RydWN0IGFt ZF9pb21tdSAqaW9tbXUsIHVpbnQ2NF90IGJhc2UsIHVpbnQ2NF90IGxpbWl0 KQorc3RhdGljIGludCBfX2luaXQgcmVzZXJ2ZV9pb21tdV9leGNsdXNpb25f cmFuZ2UoCisgICAgc3RydWN0IGFtZF9pb21tdSAqaW9tbXUsIHVpbnQ2NF90 IGJhc2UsIHVpbnQ2NF90IGxpbWl0LAorICAgIGJvb2wgYWxsLCBib29sIGl3 LCBib29sIGlyKQogeworICAgIGlmICggIWlyIHx8ICFpdyApCisgICAgICAg IHJldHVybiAtRVBFUk07CisKICAgICAvKiBuZWVkIHRvIGV4dGVuZCBleGNs dXNpb24gcmFuZ2U/ICovCiAgICAgaWYgKCBpb21tdS0+ZXhjbHVzaW9uX2Vu YWJsZSApCiAgICAgeworICAgICAgICBpZiAoIGlvbW11LT5leGNsdXNpb25f bGltaXQgKyBQQUdFX1NJWkUgPCBiYXNlIHx8CisgICAgICAgICAgICAgbGlt aXQgKyBQQUdFX1NJWkUgPCBpb21tdS0+ZXhjbHVzaW9uX2Jhc2UgfHwKKyAg ICAgICAgICAgICBpb21tdS0+ZXhjbHVzaW9uX2FsbG93X2FsbCAhPSBhbGwg KQorICAgICAgICAgICAgcmV0dXJuIC1FQlVTWTsKKwogICAgICAgICBpZiAo IGlvbW11LT5leGNsdXNpb25fYmFzZSA8IGJhc2UgKQogICAgICAgICAgICAg YmFzZSA9IGlvbW11LT5leGNsdXNpb25fYmFzZTsKICAgICAgICAgaWYgKCBp b21tdS0+ZXhjbHVzaW9uX2xpbWl0ID4gbGltaXQgKQpAQCAtMTI5LDE2ICsx MzgsMTEgQEAgc3RhdGljIHZvaWQgX19pbml0IHJlc2VydmVfaW9tbXVfZXhj bHVzaQogICAgIH0KIAogICAgIGlvbW11LT5leGNsdXNpb25fZW5hYmxlID0g SU9NTVVfQ09OVFJPTF9FTkFCTEVEOworICAgIGlvbW11LT5leGNsdXNpb25f YWxsb3dfYWxsID0gYWxsOwogICAgIGlvbW11LT5leGNsdXNpb25fYmFzZSA9 IGJhc2U7CiAgICAgaW9tbXUtPmV4Y2x1c2lvbl9saW1pdCA9IGxpbWl0Owot fQogCi1zdGF0aWMgdm9pZCBfX2luaXQgcmVzZXJ2ZV9pb21tdV9leGNsdXNp b25fcmFuZ2VfYWxsKAotICAgIHN0cnVjdCBhbWRfaW9tbXUgKmlvbW11LAot ICAgIHVuc2lnbmVkIGxvbmcgYmFzZSwgdW5zaWduZWQgbG9uZyBsaW1pdCkK LXsKLSAgICByZXNlcnZlX2lvbW11X2V4Y2x1c2lvbl9yYW5nZShpb21tdSwg YmFzZSwgbGltaXQpOwotICAgIGlvbW11LT5leGNsdXNpb25fYWxsb3dfYWxs ID0gSU9NTVVfQ09OVFJPTF9FTkFCTEVEOworICAgIHJldHVybiAwOwogfQog CiBzdGF0aWMgdm9pZCBfX2luaXQgcmVzZXJ2ZV91bml0eV9tYXBfZm9yX2Rl dmljZSgKQEAgLTE3Niw2ICsxODAsNyBAQCBzdGF0aWMgaW50IF9faW5pdCBy ZWdpc3Rlcl9leGNsdXNpb25fcmFuCiAgICAgdW5zaWduZWQgbG9uZyByYW5n ZV90b3AsIGlvbW11X3RvcCwgbGVuZ3RoOwogICAgIHN0cnVjdCBhbWRfaW9t bXUgKmlvbW11OwogICAgIHVuc2lnbmVkIGludCBiZGY7CisgICAgaW50IHJj ID0gMDsKIAogICAgIC8qIGlzIHBhcnQgb2YgZXhjbHVzaW9uIHJhbmdlIGlu c2lkZSBvZiBJT01NVSB2aXJ0dWFsIGFkZHJlc3Mgc3BhY2U/ICovCiAgICAg Lyogbm90ZTogJ2xpbWl0JyBwYXJhbWV0ZXIgaXMgYXNzdW1lZCB0byBiZSBw YWdlLWFsaWduZWQgKi8KQEAgLTE5NywxMCArMjAyLDE1IEBAIHN0YXRpYyBp bnQgX19pbml0IHJlZ2lzdGVyX2V4Y2x1c2lvbl9yYW4KICAgICBpZiAoIGxp bWl0ID49IGlvbW11X3RvcCApCiAgICAgewogICAgICAgICBmb3JfZWFjaF9h bWRfaW9tbXUoIGlvbW11ICkKLSAgICAgICAgICAgIHJlc2VydmVfaW9tbXVf ZXhjbHVzaW9uX3JhbmdlX2FsbChpb21tdSwgYmFzZSwgbGltaXQpOworICAg ICAgICB7CisgICAgICAgICAgICByYyA9IHJlc2VydmVfaW9tbXVfZXhjbHVz aW9uX3JhbmdlKGlvbW11LCBiYXNlLCBsaW1pdCwKKyAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdHJ1ZSAvKiBhbGwg Ki8sIGl3LCBpcik7CisgICAgICAgICAgICBpZiAoIHJjICkKKyAgICAgICAg ICAgICAgICBicmVhazsKKyAgICAgICAgfQogICAgIH0KIAotICAgIHJldHVy biAwOworICAgIHJldHVybiByYzsKIH0KIAogc3RhdGljIGludCBfX2luaXQg cmVnaXN0ZXJfZXhjbHVzaW9uX3JhbmdlX2Zvcl9kZXZpY2UoCkBAIC0yMTEs NiArMjIxLDcgQEAgc3RhdGljIGludCBfX2luaXQgcmVnaXN0ZXJfZXhjbHVz aW9uX3JhbgogICAgIHVuc2lnbmVkIGxvbmcgcmFuZ2VfdG9wLCBpb21tdV90 b3AsIGxlbmd0aDsKICAgICBzdHJ1Y3QgYW1kX2lvbW11ICppb21tdTsKICAg ICB1MTYgcmVxOworICAgIGludCByYyA9IDA7CiAKICAgICBpb21tdSA9IGZp bmRfaW9tbXVfZm9yX2RldmljZShzZWcsIGJkZik7CiAgICAgaWYgKCAhaW9t bXUgKQpAQCAtMjQwLDEyICsyNTEsMTMgQEAgc3RhdGljIGludCBfX2luaXQg cmVnaXN0ZXJfZXhjbHVzaW9uX3JhbgogICAgIC8qIHJlZ2lzdGVyIElPTU1V IGV4Y2x1c2lvbiByYW5nZSBzZXR0aW5ncyBmb3IgZGV2aWNlICovCiAgICAg aWYgKCBsaW1pdCA+PSBpb21tdV90b3AgICkKICAgICB7Ci0gICAgICAgIHJl c2VydmVfaW9tbXVfZXhjbHVzaW9uX3JhbmdlKGlvbW11LCBiYXNlLCBsaW1p dCk7CisgICAgICAgIHJjID0gcmVzZXJ2ZV9pb21tdV9leGNsdXNpb25fcmFu Z2UoaW9tbXUsIGJhc2UsIGxpbWl0LAorICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIGZhbHNlIC8qIGFsbCAqLywgaXcsIGly KTsKICAgICAgICAgaXZyc19tYXBwaW5nc1tiZGZdLmR0ZV9hbGxvd19leGNs dXNpb24gPSB0cnVlOwogICAgICAgICBpdnJzX21hcHBpbmdzW3JlcV0uZHRl X2FsbG93X2V4Y2x1c2lvbiA9IHRydWU7CiAgICAgfQogCi0gICAgcmV0dXJu IDA7CisgICAgcmV0dXJuIHJjOwogfQogCiBzdGF0aWMgaW50IF9faW5pdCBy ZWdpc3Rlcl9leGNsdXNpb25fcmFuZ2VfZm9yX2lvbW11X2RldmljZXMoCkBA IC0yNTUsNiArMjY3LDcgQEAgc3RhdGljIGludCBfX2luaXQgcmVnaXN0ZXJf ZXhjbHVzaW9uX3JhbgogICAgIHVuc2lnbmVkIGxvbmcgcmFuZ2VfdG9wLCBp b21tdV90b3AsIGxlbmd0aDsKICAgICB1bnNpZ25lZCBpbnQgYmRmOwogICAg IHUxNiByZXE7CisgICAgaW50IHJjID0gMDsKIAogICAgIC8qIGlzIHBhcnQg b2YgZXhjbHVzaW9uIHJhbmdlIGluc2lkZSBvZiBJT01NVSB2aXJ0dWFsIGFk ZHJlc3Mgc3BhY2U/ICovCiAgICAgLyogbm90ZTogJ2xpbWl0JyBwYXJhbWV0 ZXIgaXMgYXNzdW1lZCB0byBiZSBwYWdlLWFsaWduZWQgKi8KQEAgLTI4NSw4 ICsyOTgsMTAgQEAgc3RhdGljIGludCBfX2luaXQgcmVnaXN0ZXJfZXhjbHVz aW9uX3JhbgogCiAgICAgLyogcmVnaXN0ZXIgSU9NTVUgZXhjbHVzaW9uIHJh bmdlIHNldHRpbmdzICovCiAgICAgaWYgKCBsaW1pdCA+PSBpb21tdV90b3Ag KQotICAgICAgICByZXNlcnZlX2lvbW11X2V4Y2x1c2lvbl9yYW5nZV9hbGwo aW9tbXUsIGJhc2UsIGxpbWl0KTsKLSAgICByZXR1cm4gMDsKKyAgICAgICAg cmMgPSByZXNlcnZlX2lvbW11X2V4Y2x1c2lvbl9yYW5nZShpb21tdSwgYmFz ZSwgbGltaXQsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgdHJ1ZSAvKiBhbGwgKi8sIGl3LCBpcik7CisKKyAgICByZXR1 cm4gcmM7CiB9CiAKIHN0YXRpYyBpbnQgX19pbml0IHBhcnNlX2l2bWRfZGV2 aWNlX3NlbGVjdCgK --=separator Content-Type: application/octet-stream; name="xsa378/xsa378-2.patch" Content-Disposition: attachment; filename="xsa378/xsa378-2.patch" Content-Transfer-Encoding: base64 RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0 OiBBTUQvSU9NTVU6IGNvcnJlY3QgZGV2aWNlIHVuaXR5IG1hcCBoYW5kbGlu ZwoKQmxpbmRseSBhc3N1bWluZyBhbGwgYWRkcmVzc2VzIGJldHdlZW4gYW55 IHR3byBzdWNoIHJhbmdlcywgc3BlY2lmaWVkIGJ5CmZpcm13YXJlIGluIHRo ZSBBQ1BJIHRhYmxlcywgc2hvdWxkIGFsc28gYmUgdW5pdHktbWFwcGVkIGNh bid0IGJlIHJpZ2h0LgpOb3IgY2FuIGl0IGJlIGNvcnJlY3QgdG8gbWVyZ2Ug cmFuZ2VzIHdpdGggZGlmZmVyaW5nIHBlcm1pc3Npb25zLiBUcmFjawpyYW5n ZXMgaW5kaXZpZHVhbGx5OyBkb24ndCBtZXJnZSBhdCBhbGwsIGJ1dCBjaGVj ayBmb3Igb3ZlcmxhcHMgaW5zdGVhZC4KVGhpcyByZXF1aXJlcyBidWJibGlu ZyB1cCBlcnJvciBpbmRpY2F0b3JzLCBzdWNoIHRoYXQgSU9NTVUgaW5pdCBj YW4gYmUKZmFpbGVkIHdoZW4gYWxsb2NhdGlvbiBvZiBhIG5ldyB0cmFja2lu ZyBzdHJ1Y3Qgd2Fzbid0IHBvc3NpYmxlLCBvciBhbgpvdmVybGFwIHdhcyBk ZXRlY3RlZC4KCkF0IHRoaXMgb2NjYXNpb24gYWxzbyBzdG9wIGlnbm9yaW5n CmFtZF9pb21tdV9yZXNlcnZlX2RvbWFpbl91bml0eV9tYXAoKSdzIHJldHVy biB2YWx1ZS4KClRoaXMgaXMgcGFydCBvZiBYU0EtMzc4IC8gQ1ZFLTIwMjEt Mjg2OTUuCgpTaWduZWQtb2ZmLWJ5OiBKYW4gQmV1bGljaCA8amJldWxpY2hA c3VzZS5jb20+ClJldmlld2VkLWJ5OiBHZW9yZ2UgRHVubGFwIDxnZW9yZ2Uu ZHVubGFwQGNpdHJpeC5jb20+ClJldmlld2VkLWJ5OiBQYXVsIER1cnJhbnQg PHBhdWxAeGVuLm9yZz4KLS0tClRCRDogT3ZlcmxhcHBpbmcgcmFuZ2VzIGNv dWxkIGJlIGRlYWx0IHdpdGggKHdoZW4gdGhleSBzcGVjaWZ5IHRoZSBzYW1l CiAgICAgcGVybWlzc2lvbnMpIGJ5IHNwbGl0dGluZyB0aGUgcmFuZ2VzIHRv IG5vbi1vdmVybGFwcGluZyBwaWVjZXMuIFNlZQogICAgICJJT01NVTogZ2Vu ZXJhbGl6ZSBWVC1kJ3MgdHJhY2tpbmcgb2YgbWFwcGVkIFJNUlIgcmVnaW9u cyIgYW5kIGl0cwogICAgIHVzZXIgIkFNRC9JT01NVTogcmUtYXJyYW5nZS9j b21wbGV0ZSByZS1hc3NpZ25tZW50IGhhbmRsaW5nIiBmb3IKICAgICB3aHkg b3ZlcmxhcHMgY2FuJ3QgYmUgYWNjZXB0ZWQgd2l0aCB0aGUgY2hvc2VuIHRy YWNraW5nIG1vZGVsLiBCdXQKICAgICB0aGUgYmFzZSBhc3N1bXB0aW9uIGlz IGFueXdheSBmb3IgZmlybXdhcmUgdG8gbm90IHN1cmZhY2UKICAgICBvdmVy bGFwcGluZyByYW5nZXMgaW4gdGhlIGZpcnN0IHBsYWNlLgotLS0Kdjg6IEZp eCBidWlsZCAoZmFpbHVyZSByZXN1bHRlZCBmcm9tIGEgcGllY2Ugb2YgY29k ZSBsaXZpbmcgaGVyZSB3aGljaAogICAgb25seSBhIGxhdGVyIHBhdGNoIHNo b3VsZCBhZGQpLiBSZS1iYXNlIG92ZXIgYWRqdXN0bWVudHMgdG8gZWFybGll cgogICAgcGF0Y2guCnY1OiBEb24ndCBhbGxvdyBvdmVybGFwcyAoZXhjZXB0 IGV4YWN0IG1hdGNoZXMpIGFuZCBkb24ndCBtZXJnZS4KICAgIFJlLWJhc2Uu CnY0OiBBZGp1c3QgdGl0bGUuIFJlLWJhc2Ugb3ZlciBjaGFuZ2VzIGVhcmxp ZXIgaW4gdGhlIHNlcmllcy4KdjI6IFJlLWJhc2Ugb3ZlciBYU0EtMzAyLgoK LS0tIGEveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvYW1kL2lvbW11LmgKKysr IGIveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvYW1kL2lvbW11LmgKQEAgLTEw NywyMCArMTA3LDI0IEBAIHN0cnVjdCBhbWRfaW9tbXUgewogICAgIHN0cnVj dCBsaXN0X2hlYWQgYXRzX2RldmljZXM7CiB9OwogCitzdHJ1Y3QgaXZyc191 bml0eV9tYXAgeworICAgIGJvb2wgcmVhZDoxOworICAgIGJvb2wgd3JpdGU6 MTsKKyAgICBwYWRkcl90IGFkZHI7CisgICAgdW5zaWduZWQgbG9uZyBsZW5n dGg7CisgICAgc3RydWN0IGl2cnNfdW5pdHlfbWFwICpuZXh0OworfTsKKwog c3RydWN0IGl2cnNfbWFwcGluZ3MgewogICAgIHVpbnQxNl90IGR0ZV9yZXF1 ZXN0b3JfaWQ7CiAgICAgYm9vbCB2YWxpZDoxOwogICAgIGJvb2wgZHRlX2Fs bG93X2V4Y2x1c2lvbjoxOwotICAgIGJvb2wgdW5pdHlfbWFwX2VuYWJsZTox OwotICAgIGJvb2wgd3JpdGVfcGVybWlzc2lvbjoxOwotICAgIGJvb2wgcmVh ZF9wZXJtaXNzaW9uOjE7CiAKICAgICAvKiBpdmhkIGRldmljZSBkYXRhIHNl dHRpbmdzICovCiAgICAgdWludDhfdCBkZXZpY2VfZmxhZ3M7CiAKLSAgICB1 bnNpZ25lZCBsb25nIGFkZHJfcmFuZ2Vfc3RhcnQ7Ci0gICAgdW5zaWduZWQg bG9uZyBhZGRyX3JhbmdlX2xlbmd0aDsKICAgICBzdHJ1Y3QgYW1kX2lvbW11 ICppb21tdTsKKyAgICBzdHJ1Y3QgaXZyc191bml0eV9tYXAgKnVuaXR5X21h cDsKIAogICAgIC8qIHBlciBkZXZpY2UgaW50ZXJydXB0IHJlbWFwcGluZyB0 YWJsZSAqLwogICAgIHZvaWQgKmludHJlbWFwX3RhYmxlOwotLS0gYS94ZW4v ZHJpdmVycy9wYXNzdGhyb3VnaC9hbWQvaW9tbXVfYWNwaS5jCisrKyBiL3hl bi9kcml2ZXJzL3Bhc3N0aHJvdWdoL2FtZC9pb21tdV9hY3BpLmMKQEAgLTE0 NSwzMiArMTQ1LDQ4IEBAIHN0YXRpYyBpbnQgX19pbml0IHJlc2VydmVfaW9t bXVfZXhjbHVzaW8KICAgICByZXR1cm4gMDsKIH0KIAotc3RhdGljIHZvaWQg X19pbml0IHJlc2VydmVfdW5pdHlfbWFwX2Zvcl9kZXZpY2UoCi0gICAgdTE2 IHNlZywgdTE2IGJkZiwgdW5zaWduZWQgbG9uZyBiYXNlLAotICAgIHVuc2ln bmVkIGxvbmcgbGVuZ3RoLCB1OCBpdywgdTggaXIpCitzdGF0aWMgaW50IF9f aW5pdCByZXNlcnZlX3VuaXR5X21hcF9mb3JfZGV2aWNlKAorICAgIHVpbnQx Nl90IHNlZywgdWludDE2X3QgYmRmLCB1bnNpZ25lZCBsb25nIGJhc2UsCisg ICAgdW5zaWduZWQgbG9uZyBsZW5ndGgsIGJvb2wgaXcsIGJvb2wgaXIpCiB7 CiAgICAgc3RydWN0IGl2cnNfbWFwcGluZ3MgKml2cnNfbWFwcGluZ3MgPSBn ZXRfaXZyc19tYXBwaW5ncyhzZWcpOwotICAgIHVuc2lnbmVkIGxvbmcgb2xk X3RvcCwgbmV3X3RvcDsKKyAgICBzdHJ1Y3QgaXZyc191bml0eV9tYXAgKnVu aXR5X21hcCA9IGl2cnNfbWFwcGluZ3NbYmRmXS51bml0eV9tYXA7CiAKLSAg ICAvKiBuZWVkIHRvIGV4dGVuZCB1bml0eS1tYXBwZWQgcmFuZ2U/ICovCi0g ICAgaWYgKCBpdnJzX21hcHBpbmdzW2JkZl0udW5pdHlfbWFwX2VuYWJsZSAp CisgICAgLyogQ2hlY2sgZm9yIG92ZXJsYXBzLiAqLworICAgIGZvciAoIDsg dW5pdHlfbWFwOyB1bml0eV9tYXAgPSB1bml0eV9tYXAtPm5leHQgKQogICAg IHsKLSAgICAgICAgb2xkX3RvcCA9IGl2cnNfbWFwcGluZ3NbYmRmXS5hZGRy X3JhbmdlX3N0YXJ0ICsKLSAgICAgICAgICAgIGl2cnNfbWFwcGluZ3NbYmRm XS5hZGRyX3JhbmdlX2xlbmd0aDsKLSAgICAgICAgbmV3X3RvcCA9IGJhc2Ug KyBsZW5ndGg7Ci0gICAgICAgIGlmICggb2xkX3RvcCA+IG5ld190b3AgKQot ICAgICAgICAgICAgbmV3X3RvcCA9IG9sZF90b3A7Ci0gICAgICAgIGlmICgg aXZyc19tYXBwaW5nc1tiZGZdLmFkZHJfcmFuZ2Vfc3RhcnQgPCBiYXNlICkK LSAgICAgICAgICAgIGJhc2UgPSBpdnJzX21hcHBpbmdzW2JkZl0uYWRkcl9y YW5nZV9zdGFydDsKLSAgICAgICAgbGVuZ3RoID0gbmV3X3RvcCAtIGJhc2U7 Ci0gICAgfQotCi0gICAgLyogZXh0ZW5kIHIvdyBwZXJtaXNzaW9tcyBhbmQg a2VlcCBhZ2dyZWdhdGUgKi8KLSAgICBpdnJzX21hcHBpbmdzW2JkZl0ud3Jp dGVfcGVybWlzc2lvbiA9IGl3OwotICAgIGl2cnNfbWFwcGluZ3NbYmRmXS5y ZWFkX3Blcm1pc3Npb24gPSBpcjsKLSAgICBpdnJzX21hcHBpbmdzW2JkZl0u dW5pdHlfbWFwX2VuYWJsZSA9IHRydWU7Ci0gICAgaXZyc19tYXBwaW5nc1ti ZGZdLmFkZHJfcmFuZ2Vfc3RhcnQgPSBiYXNlOwotICAgIGl2cnNfbWFwcGlu Z3NbYmRmXS5hZGRyX3JhbmdlX2xlbmd0aCA9IGxlbmd0aDsKKyAgICAgICAg LyoKKyAgICAgICAgICogRXhhY3QgbWF0Y2hlcyBhcmUgb2theS4gVGhpcyBj YW4gaW4gcGFydGljdWxhciBoYXBwZW4gd2hlbgorICAgICAgICAgKiByZWdp c3Rlcl9leGNsdXNpb25fcmFuZ2VfZm9yX2RldmljZSgpIGNhbGxzIGhlcmUg dHdpY2UgZm9yIHRoZQorICAgICAgICAgKiBzYW1lIChzLGIsZCxmKS4KKyAg ICAgICAgICovCisgICAgICAgIGlmICggYmFzZSA9PSB1bml0eV9tYXAtPmFk ZHIgJiYgbGVuZ3RoID09IHVuaXR5X21hcC0+bGVuZ3RoICYmCisgICAgICAg ICAgICAgaXIgPT0gdW5pdHlfbWFwLT5yZWFkICYmIGl3ID09IHVuaXR5X21h cC0+d3JpdGUgKQorICAgICAgICAgICAgcmV0dXJuIDA7CisKKyAgICAgICAg aWYgKCB1bml0eV9tYXAtPmFkZHIgKyB1bml0eV9tYXAtPmxlbmd0aCA+IGJh c2UgJiYKKyAgICAgICAgICAgICBiYXNlICsgbGVuZ3RoID4gdW5pdHlfbWFw LT5hZGRyICkKKyAgICAgICAgeworICAgICAgICAgICAgQU1EX0lPTU1VX0RF QlVHKCJJVk1EIEVycm9yOiBvdmVybGFwIFslbHgsJWx4KSB2cyBbJWx4LCVs eClcbiIsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgYmFzZSwgYmFz ZSArIGxlbmd0aCwgdW5pdHlfbWFwLT5hZGRyLAorICAgICAgICAgICAgICAg ICAgICAgICAgICAgIHVuaXR5X21hcC0+YWRkciArIHVuaXR5X21hcC0+bGVu Z3RoKTsKKyAgICAgICAgICAgIHJldHVybiAtRVBFUk07CisgICAgICAgIH0K KyAgICB9CisKKyAgICAvKiBQb3B1bGF0ZSBhbmQgaW5zZXJ0IGEgbmV3IHVu aXR5IG1hcC4gKi8KKyAgICB1bml0eV9tYXAgPSB4bWFsbG9jKHN0cnVjdCBp dnJzX3VuaXR5X21hcCk7CisgICAgaWYgKCAhdW5pdHlfbWFwICkKKyAgICAg ICAgcmV0dXJuIC1FTk9NRU07CisKKyAgICB1bml0eV9tYXAtPnJlYWQgPSBp cjsKKyAgICB1bml0eV9tYXAtPndyaXRlID0gaXc7CisgICAgdW5pdHlfbWFw LT5hZGRyID0gYmFzZTsKKyAgICB1bml0eV9tYXAtPmxlbmd0aCA9IGxlbmd0 aDsKKyAgICB1bml0eV9tYXAtPm5leHQgPSBpdnJzX21hcHBpbmdzW2JkZl0u dW5pdHlfbWFwOworICAgIGl2cnNfbWFwcGluZ3NbYmRmXS51bml0eV9tYXAg PSB1bml0eV9tYXA7CisKKyAgICByZXR1cm4gMDsKIH0KIAogc3RhdGljIGlu dCBfX2luaXQgcmVnaXN0ZXJfZXhjbHVzaW9uX3JhbmdlX2Zvcl9hbGxfZGV2 aWNlcygKQEAgLTE5MywxMyArMjA5LDEzIEBAIHN0YXRpYyBpbnQgX19pbml0 IHJlZ2lzdGVyX2V4Y2x1c2lvbl9yYW4KICAgICAgICAgbGVuZ3RoID0gcmFu Z2VfdG9wIC0gYmFzZTsKICAgICAgICAgLyogcmVzZXJ2ZSByL3cgdW5pdHkt bWFwcGVkIHBhZ2UgZW50cmllcyBmb3IgZGV2aWNlcyAqLwogICAgICAgICAv KiBub3RlOiB0aGVzZSBlbnRyaWVzIGFyZSBwYXJ0IG9mIHRoZSBleGNsdXNp b24gcmFuZ2UgKi8KLSAgICAgICAgZm9yICggYmRmID0gMDsgYmRmIDwgaXZy c19iZGZfZW50cmllczsgYmRmKysgKQotICAgICAgICAgICAgcmVzZXJ2ZV91 bml0eV9tYXBfZm9yX2RldmljZShzZWcsIGJkZiwgYmFzZSwgbGVuZ3RoLCBp dywgaXIpOworICAgICAgICBmb3IgKCBiZGYgPSAwOyAhcmMgJiYgYmRmIDwg aXZyc19iZGZfZW50cmllczsgYmRmKysgKQorICAgICAgICAgICAgcmMgPSBy ZXNlcnZlX3VuaXR5X21hcF9mb3JfZGV2aWNlKHNlZywgYmRmLCBiYXNlLCBs ZW5ndGgsIGl3LCBpcik7CiAgICAgICAgIC8qIHB1c2ggJ2Jhc2UnIGp1c3Qg b3V0c2lkZSBvZiB2aXJ0dWFsIGFkZHJlc3Mgc3BhY2UgKi8KICAgICAgICAg YmFzZSA9IGlvbW11X3RvcDsKICAgICB9CiAgICAgLyogcmVnaXN0ZXIgSU9N TVUgZXhjbHVzaW9uIHJhbmdlIHNldHRpbmdzICovCi0gICAgaWYgKCBsaW1p dCA+PSBpb21tdV90b3AgKQorICAgIGlmICggIXJjICYmIGxpbWl0ID49IGlv bW11X3RvcCApCiAgICAgewogICAgICAgICBmb3JfZWFjaF9hbWRfaW9tbXUo IGlvbW11ICkKICAgICAgICAgewpAQCAtMjQxLDE1ICsyNTcsMTUgQEAgc3Rh dGljIGludCBfX2luaXQgcmVnaXN0ZXJfZXhjbHVzaW9uX3JhbgogICAgICAg ICBsZW5ndGggPSByYW5nZV90b3AgLSBiYXNlOwogICAgICAgICAvKiByZXNl cnZlIHVuaXR5LW1hcHBlZCBwYWdlIGVudHJpZXMgZm9yIGRldmljZSAqLwog ICAgICAgICAvKiBub3RlOiB0aGVzZSBlbnRyaWVzIGFyZSBwYXJ0IG9mIHRo ZSBleGNsdXNpb24gcmFuZ2UgKi8KLSAgICAgICAgcmVzZXJ2ZV91bml0eV9t YXBfZm9yX2RldmljZShzZWcsIGJkZiwgYmFzZSwgbGVuZ3RoLCBpdywgaXIp OwotICAgICAgICByZXNlcnZlX3VuaXR5X21hcF9mb3JfZGV2aWNlKHNlZywg cmVxLCBiYXNlLCBsZW5ndGgsIGl3LCBpcik7CisgICAgICAgIHJjID0gcmVz ZXJ2ZV91bml0eV9tYXBfZm9yX2RldmljZShzZWcsIGJkZiwgYmFzZSwgbGVu Z3RoLCBpdywgaXIpID86CisgICAgICAgICAgICAgcmVzZXJ2ZV91bml0eV9t YXBfZm9yX2RldmljZShzZWcsIHJlcSwgYmFzZSwgbGVuZ3RoLCBpdywgaXIp OwogCiAgICAgICAgIC8qIHB1c2ggJ2Jhc2UnIGp1c3Qgb3V0c2lkZSBvZiB2 aXJ0dWFsIGFkZHJlc3Mgc3BhY2UgKi8KICAgICAgICAgYmFzZSA9IGlvbW11 X3RvcDsKICAgICB9CiAKICAgICAvKiByZWdpc3RlciBJT01NVSBleGNsdXNp b24gcmFuZ2Ugc2V0dGluZ3MgZm9yIGRldmljZSAqLwotICAgIGlmICggbGlt aXQgPj0gaW9tbXVfdG9wICApCisgICAgaWYgKCAhcmMgJiYgbGltaXQgPj0g aW9tbXVfdG9wICApCiAgICAgewogICAgICAgICByYyA9IHJlc2VydmVfaW9t bXVfZXhjbHVzaW9uX3JhbmdlKGlvbW11LCBiYXNlLCBsaW1pdCwKICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBmYWxzZSAv KiBhbGwgKi8sIGl3LCBpcik7CkBAIC0yODAsMTUgKzI5NiwxNSBAQCBzdGF0 aWMgaW50IF9faW5pdCByZWdpc3Rlcl9leGNsdXNpb25fcmFuCiAgICAgICAg IGxlbmd0aCA9IHJhbmdlX3RvcCAtIGJhc2U7CiAgICAgICAgIC8qIHJlc2Vy dmUgci93IHVuaXR5LW1hcHBlZCBwYWdlIGVudHJpZXMgZm9yIGRldmljZXMg Ki8KICAgICAgICAgLyogbm90ZTogdGhlc2UgZW50cmllcyBhcmUgcGFydCBv ZiB0aGUgZXhjbHVzaW9uIHJhbmdlICovCi0gICAgICAgIGZvciAoIGJkZiA9 IDA7IGJkZiA8IGl2cnNfYmRmX2VudHJpZXM7IGJkZisrICkKKyAgICAgICAg Zm9yICggYmRmID0gMDsgIXJjICYmIGJkZiA8IGl2cnNfYmRmX2VudHJpZXM7 IGJkZisrICkKICAgICAgICAgewogICAgICAgICAgICAgaWYgKCBpb21tdSA9 PSBmaW5kX2lvbW11X2Zvcl9kZXZpY2UoaW9tbXUtPnNlZywgYmRmKSApCiAg ICAgICAgICAgICB7Ci0gICAgICAgICAgICAgICAgcmVzZXJ2ZV91bml0eV9t YXBfZm9yX2RldmljZShpb21tdS0+c2VnLCBiZGYsIGJhc2UsIGxlbmd0aCwK LSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IGl3LCBpcik7CiAgICAgICAgICAgICAgICAgcmVxID0gZ2V0X2l2cnNfbWFw cGluZ3MoaW9tbXUtPnNlZylbYmRmXS5kdGVfcmVxdWVzdG9yX2lkOwotICAg ICAgICAgICAgICAgIHJlc2VydmVfdW5pdHlfbWFwX2Zvcl9kZXZpY2UoaW9t bXUtPnNlZywgcmVxLCBiYXNlLCBsZW5ndGgsCi0gICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBpdywgaXIpOworICAgICAg ICAgICAgICAgIHJjID0gcmVzZXJ2ZV91bml0eV9tYXBfZm9yX2RldmljZShp b21tdS0+c2VnLCBiZGYsIGJhc2UsIGxlbmd0aCwKKyAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgaXcsIGlyKSA/ OgorICAgICAgICAgICAgICAgICAgICAgcmVzZXJ2ZV91bml0eV9tYXBfZm9y X2RldmljZShpb21tdS0+c2VnLCByZXEsIGJhc2UsIGxlbmd0aCwKKyAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg aXcsIGlyKTsKICAgICAgICAgICAgIH0KICAgICAgICAgfQogCkBAIC0yOTcs NyArMzEzLDcgQEAgc3RhdGljIGludCBfX2luaXQgcmVnaXN0ZXJfZXhjbHVz aW9uX3JhbgogICAgIH0KIAogICAgIC8qIHJlZ2lzdGVyIElPTU1VIGV4Y2x1 c2lvbiByYW5nZSBzZXR0aW5ncyAqLwotICAgIGlmICggbGltaXQgPj0gaW9t bXVfdG9wICkKKyAgICBpZiAoICFyYyAmJiBsaW1pdCA+PSBpb21tdV90b3Ag KQogICAgICAgICByYyA9IHJlc2VydmVfaW9tbXVfZXhjbHVzaW9uX3Jhbmdl KGlvbW11LCBiYXNlLCBsaW1pdCwKICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICB0cnVlIC8qIGFsbCAqLywgaXcsIGlyKTsK IAotLS0gYS94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC9hbWQvcGNpX2FtZF9p b21tdS5jCisrKyBiL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL2FtZC9wY2lf YW1kX2lvbW11LmMKQEAgLTM4NCwxNSArMzg0LDE3IEBAIHN0YXRpYyBpbnQg YW1kX2lvbW11X2Fzc2lnbl9kZXZpY2Uoc3RydWMKICAgICBzdHJ1Y3QgaXZy c19tYXBwaW5ncyAqaXZyc19tYXBwaW5ncyA9IGdldF9pdnJzX21hcHBpbmdz KHBkZXYtPnNlZyk7CiAgICAgaW50IGJkZiA9IFBDSV9CREYyKHBkZXYtPmJ1 cywgZGV2Zm4pOwogICAgIGludCByZXFfaWQgPSBnZXRfZG1hX3JlcXVlc3Rv cl9pZChwZGV2LT5zZWcsIGJkZik7CisgICAgY29uc3Qgc3RydWN0IGl2cnNf dW5pdHlfbWFwICp1bml0eV9tYXA7CiAKLSAgICBpZiAoIGl2cnNfbWFwcGlu Z3NbcmVxX2lkXS51bml0eV9tYXBfZW5hYmxlICkKKyAgICBmb3IgKCB1bml0 eV9tYXAgPSBpdnJzX21hcHBpbmdzW3JlcV9pZF0udW5pdHlfbWFwOyB1bml0 eV9tYXA7CisgICAgICAgICAgdW5pdHlfbWFwID0gdW5pdHlfbWFwLT5uZXh0 ICkKICAgICB7Ci0gICAgICAgIGFtZF9pb21tdV9yZXNlcnZlX2RvbWFpbl91 bml0eV9tYXAoCi0gICAgICAgICAgICBkLAotICAgICAgICAgICAgaXZyc19t YXBwaW5nc1tyZXFfaWRdLmFkZHJfcmFuZ2Vfc3RhcnQsCi0gICAgICAgICAg ICBpdnJzX21hcHBpbmdzW3JlcV9pZF0uYWRkcl9yYW5nZV9sZW5ndGgsCi0g ICAgICAgICAgICBpdnJzX21hcHBpbmdzW3JlcV9pZF0ud3JpdGVfcGVybWlz c2lvbiwKLSAgICAgICAgICAgIGl2cnNfbWFwcGluZ3NbcmVxX2lkXS5yZWFk X3Blcm1pc3Npb24pOworICAgICAgICBpbnQgcmMgPSBhbWRfaW9tbXVfcmVz ZXJ2ZV9kb21haW5fdW5pdHlfbWFwKAorICAgICAgICAgICAgICAgICAgICAg ZCwgdW5pdHlfbWFwLT5hZGRyLCB1bml0eV9tYXAtPmxlbmd0aCwKKyAgICAg ICAgICAgICAgICAgICAgIHVuaXR5X21hcC0+d3JpdGUsIHVuaXR5X21hcC0+ cmVhZCk7CisKKyAgICAgICAgaWYgKCByYyApCisgICAgICAgICAgICByZXR1 cm4gcmM7CiAgICAgfQogCiAgICAgcmV0dXJuIHJlYXNzaWduX2RldmljZShw ZGV2LT5kb21haW4sIGQsIGRldmZuLCBwZGV2KTsK --=separator Content-Type: application/octet-stream; name="xsa378/xsa378-3.patch" Content-Disposition: attachment; filename="xsa378/xsa378-3.patch" Content-Transfer-Encoding: base64 RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0 OiBJT01NVTogYWxzbyBwYXNzIHAybV9hY2Nlc3NfdCB0byBwMm1fZ2V0X2lv bW11X2ZsYWdzKCkKCkEgc3Vic2VxdWVudCBjaGFuZ2Ugd2lsbCB3YW50IHRv IGN1c3RvbWl6ZSB0aGUgSU9NTVUgcGVybWlzc2lvbnMgYmFzZWQKb24gdGhp cy4KClRoaXMgaXMgcGFydCBvZiBYU0EtMzc4LgoKU2lnbmVkLW9mZi1ieTog SmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpSZXZpZXdlZC1ieTog UGF1bCBEdXJyYW50IDxwYXVsQHhlbi5vcmc+Ci0tLQp2NTogTmV3LgoKLS0t IGEveGVuL2FyY2gveDg2L21tL3AybS1lcHQuYworKysgYi94ZW4vYXJjaC94 ODYvbW0vcDJtLWVwdC5jCkBAIC04MDgsNyArODA4LDcgQEAgZXB0X3NldF9l bnRyeShzdHJ1Y3QgcDJtX2RvbWFpbiAqcDJtLCBnZgogICAgIGJvb2xfdCBl bnRyeV93cml0dGVuID0gMDsKICAgICBib29sX3QgbmVlZF9tb2RpZnlfdnRk X3RhYmxlID0gMTsKICAgICBib29sX3QgdnRkX3B0ZV9wcmVzZW50ID0gMDsK LSAgICB1bnNpZ25lZCBpbnQgaW9tbXVfZmxhZ3MgPSBwMm1fZ2V0X2lvbW11 X2ZsYWdzKHAybXQsIG1mbik7CisgICAgdW5zaWduZWQgaW50IGlvbW11X2Zs YWdzID0gcDJtX2dldF9pb21tdV9mbGFncyhwMm10LCBwMm1hLCBtZm4pOwog ICAgIGJvb2xfdCBuZWVkc19zeW5jID0gMTsKICAgICBlcHRfZW50cnlfdCBv bGRfZW50cnkgPSB7IC5lcHRlID0gMCB9OwogICAgIGVwdF9lbnRyeV90IG5l d19lbnRyeSA9IHsgLmVwdGUgPSAwIH07CkBAIC05MzgsOCArOTM4LDggQEAg ZXB0X3NldF9lbnRyeShzdHJ1Y3QgcDJtX2RvbWFpbiAqcDJtLCBnZgogCiAg ICAgICAgIC8qIFNhZmUgdG8gcmVhZC10aGVuLXdyaXRlIGJlY2F1c2Ugd2Ug aG9sZCB0aGUgcDJtIGxvY2sgKi8KICAgICAgICAgaWYgKCBlcHRfZW50cnkt Pm1mbiA9PSBuZXdfZW50cnkubWZuICYmCi0gICAgICAgICAgICAgcDJtX2dl dF9pb21tdV9mbGFncyhlcHRfZW50cnktPnNhX3AybXQsIF9tZm4oZXB0X2Vu dHJ5LT5tZm4pKSA9PQotICAgICAgICAgICAgIGlvbW11X2ZsYWdzICkKKyAg ICAgICAgICAgICBwMm1fZ2V0X2lvbW11X2ZsYWdzKGVwdF9lbnRyeS0+c2Ff cDJtdCwgZXB0X2VudHJ5LT5hY2Nlc3MsCisgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICBfbWZuKGVwdF9lbnRyeS0+bWZuKSkgPT0gaW9tbXVf ZmxhZ3MgKQogICAgICAgICAgICAgbmVlZF9tb2RpZnlfdnRkX3RhYmxlID0g MDsKIAogICAgICAgICBlcHRfcDJtX3R5cGVfdG9fZmxhZ3MocDJtLCAmbmV3 X2VudHJ5KTsKLS0tIGEveGVuL2FyY2gveDg2L21tL3AybS1wdC5jCisrKyBi L3hlbi9hcmNoL3g4Ni9tbS9wMm0tcHQuYwpAQCAtNTQ1LDYgKzU0NSwxNiBA QCBpbnQgcDJtX3B0X2hhbmRsZV9kZWZlcnJlZF9jaGFuZ2VzKHVpbnQ2CiAg ICAgcmV0dXJuIHJjOwogfQogCisvKiBSZWNvbnN0cnVjdCBhIGZha2UgcDJt X2FjY2Vzc190IGZyb20gc3RvcmVkIFBURSBmbGFncy4gKi8KK3N0YXRpYyBw Mm1fYWNjZXNzX3QgcDJtX2ZsYWdzX3RvX2FjY2Vzcyh1bnNpZ25lZCBpbnQg ZmxhZ3MpCit7CisgICAgaWYgKCBmbGFncyAmIF9QQUdFX1BSRVNFTlQgKQor ICAgICAgICByZXR1cm4gcDJtX2FjY2Vzc19uOworCisgICAgLyogTm8gbmVl ZCB0byBsb29rIGF0IF9QQUdFX05YIGZvciBub3cuICovCisgICAgcmV0dXJu IGZsYWdzICYgX1BBR0VfUlcgPyBwMm1fYWNjZXNzX3J3IDogcDJtX2FjY2Vz c19yOworfQorCiAvKiBDaGVja3Mgb25seSBhcHBsaWNhYmxlIHRvIGVudHJp ZXMgd2l0aCBvcmRlciA+IFBBR0VfT1JERVJfNEsgKi8KIHN0YXRpYyB2b2lk IGNoZWNrX2VudHJ5KG1mbl90IG1mbiwgcDJtX3R5cGVfdCBuZXcsIHAybV90 eXBlX3Qgb2xkLAogICAgICAgICAgICAgICAgICAgICAgICAgdW5zaWduZWQg aW50IG9yZGVyKQpAQCAtNTc5LDcgKzU4OSw3IEBAIHAybV9wdF9zZXRfZW50 cnkoc3RydWN0IHAybV9kb21haW4gKnAybSwKICAgICBsMl9wZ2VudHJ5X3Qg bDJlX2NvbnRlbnQ7CiAgICAgbDNfcGdlbnRyeV90IGwzZV9jb250ZW50Owog ICAgIGludCByYzsKLSAgICB1bnNpZ25lZCBpbnQgaW9tbXVfcHRlX2ZsYWdz ID0gcDJtX2dldF9pb21tdV9mbGFncyhwMm10LCBtZm4pOworICAgIHVuc2ln bmVkIGludCBpb21tdV9wdGVfZmxhZ3MgPSBwMm1fZ2V0X2lvbW11X2ZsYWdz KHAybXQsIHAybWEsIG1mbik7CiAgICAgLyoKICAgICAgKiBvbGRfbWZuIGFu ZCBpb21tdV9vbGRfZmxhZ3MgY29udHJvbCBwb3NzaWJsZSBmbHVzaC91cGRh dGUgbmVlZHMgb24gdGhlCiAgICAgICogSU9NTVU6IFdlIG5lZWQgdG8gZmx1 c2ggd2hlbiBNRk4gb3IgZmxhZ3MgKGkuZS4gcGVybWlzc2lvbnMpIGNoYW5n ZS4KQEAgLTY0Miw2ICs2NTIsNyBAQCBwMm1fcHRfc2V0X2VudHJ5KHN0cnVj dCBwMm1fZG9tYWluICpwMm0sCiAgICAgICAgICAgICAgICAgb2xkX21mbiA9 IGwxZV9nZXRfcGZuKCpwMm1fZW50cnkpOwogICAgICAgICAgICAgICAgIGlv bW11X29sZF9mbGFncyA9CiAgICAgICAgICAgICAgICAgICAgIHAybV9nZXRf aW9tbXVfZmxhZ3MocDJtX2ZsYWdzX3RvX3R5cGUoZmxhZ3MpLAorICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHAybV9mbGFnc190 b19hY2Nlc3MoZmxhZ3MpLAogICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIF9tZm4ob2xkX21mbikpOwogICAgICAgICAgICAgfQog ICAgICAgICAgICAgZWxzZQpAQCAtNjg0LDkgKzY5NSwxMCBAQCBwMm1fcHRf c2V0X2VudHJ5KHN0cnVjdCBwMm1fZG9tYWluICpwMm0sCiAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIDAsIEwxX1BBR0VUQUJMRV9FTlRS SUVTKTsKICAgICAgICAgQVNTRVJUKHAybV9lbnRyeSk7CiAgICAgICAgIG9s ZF9tZm4gPSBsMWVfZ2V0X3BmbigqcDJtX2VudHJ5KTsKKyAgICAgICAgZmxh Z3MgPSBsMWVfZ2V0X2ZsYWdzKCpwMm1fZW50cnkpOwogICAgICAgICBpb21t dV9vbGRfZmxhZ3MgPQotICAgICAgICAgICAgcDJtX2dldF9pb21tdV9mbGFn cyhwMm1fZmxhZ3NfdG9fdHlwZShsMWVfZ2V0X2ZsYWdzKCpwMm1fZW50cnkp KSwKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgX21mbihvbGRf bWZuKSk7CisgICAgICAgICAgICBwMm1fZ2V0X2lvbW11X2ZsYWdzKHAybV9m bGFnc190b190eXBlKGZsYWdzKSwKKyAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgcDJtX2ZsYWdzX3RvX2FjY2VzcyhmbGFncyksIF9tZm4ob2xk X21mbikpOwogCiAgICAgICAgIGlmICggbWZuX3ZhbGlkKG1mbikgfHwgcDJt X2FsbG93c19pbnZhbGlkX21mbihwMm10KSApCiAgICAgICAgICAgICBlbnRy eV9jb250ZW50ID0gcDJtX2wxZV9mcm9tX3BmbihtZm5feChtZm4pLApAQCAt NzE0LDYgKzcyNiw3IEBAIHAybV9wdF9zZXRfZW50cnkoc3RydWN0IHAybV9k b21haW4gKnAybSwKICAgICAgICAgICAgICAgICBvbGRfbWZuID0gbDFlX2dl dF9wZm4oKnAybV9lbnRyeSk7CiAgICAgICAgICAgICAgICAgaW9tbXVfb2xk X2ZsYWdzID0KICAgICAgICAgICAgICAgICAgICAgcDJtX2dldF9pb21tdV9m bGFncyhwMm1fZmxhZ3NfdG9fdHlwZShmbGFncyksCisgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgcDJtX2ZsYWdzX3RvX2FjY2Vz cyhmbGFncyksCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgX21mbihvbGRfbWZuKSk7CiAgICAgICAgICAgICB9CiAgICAgICAg ICAgICBlbHNlCi0tLSBhL3hlbi9pbmNsdWRlL2FzbS14ODYvcDJtLmgKKysr IGIveGVuL2luY2x1ZGUvYXNtLXg4Ni9wMm0uaApAQCAtODkxLDcgKzg5MSw4 IEBAIHN0YXRpYyBpbmxpbmUgdm9pZCBwMm1fYWx0cDJtX2NoZWNrKHN0cnUK IC8qCiAgKiBwMm0gdHlwZSB0byBJT01NVSBmbGFncwogICovCi1zdGF0aWMg aW5saW5lIHVuc2lnbmVkIGludCBwMm1fZ2V0X2lvbW11X2ZsYWdzKHAybV90 eXBlX3QgcDJtdCwgbWZuX3QgbWZuKQorc3RhdGljIGlubGluZSB1bnNpZ25l ZCBpbnQgcDJtX2dldF9pb21tdV9mbGFncyhwMm1fdHlwZV90IHAybXQsCisg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IHAybV9hY2Nlc3NfdCBwMm1hLCBtZm5fdCBtZm4pCiB7CiAgICAgdW5zaWdu ZWQgaW50IGZsYWdzOwogCg== --=separator Content-Type: application/octet-stream; name="xsa378/xsa378-4.11-0a.patch" Content-Disposition: attachment; filename="xsa378/xsa378-4.11-0a.patch" Content-Transfer-Encoding: base64 RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0 OiB4ODYvcDJtOiBmaXggUG9EIGFjY291bnRpbmcgaW4gZ3Vlc3RfcGh5c21h cF9hZGRfZW50cnkoKQoKVGhlIGluaXRpYWwgb2JzZXJ2YXRpb24gd2FzIHRo YXQgdGhlIG1mbl92YWxpZCgpIGNoZWNrIGNvbWVzIHRvbyBsYXRlOgpOZWl0 aGVyIG1mbl9hZGQoKSBub3IgbWZuX3RvX3BhZ2UoKSAobGV0IGFsb25lIGRl LXJlZmVyZW5jaW5nIHRoZQpyZXN1bHQgb2YgdGhlIGxhdHRlcikgYXJlIHZh bGlkIGZvciBNRk5zIGZhaWxpbmcgdGhpcyBjaGVjay4gTW92ZSBpdCB1cAph bmQgLSBub3RpY2luZyB0aGF0IHRoZXJlJ3Mgbm8gY2FsbGVyIGRvaW5nIHNv IC0gYWxzbyBhZGQgYW4gYXNzZXJ0aW9uCnRoYXQgdGhpcyBzaG91bGQgbmV2 ZXIgcHJvZHVjZSAiZmFsc2UiIGhlcmUuCgpJbiB0dXJuIHRoaXMgd291bGQg aGF2ZSBtZWFudCB0aGF0IHRoZSAiZWxzZSIgdG8gdGhhdCBpZigpIGNvdWxk IG5vdyBnbwphd2F5LCB3aGljaCBkaWRuJ3Qgc2VlbSByaWdodCBhdCBhbGwu IEFuZCBpbmRlZWQsIGNvbnNpZGVyaW5nIGNhbGxlcnMKbGlrZSBtZW1vcnlf ZXhjaGFuZ2UoKSBvciB2YXJpb3VzIGdyYW50IHRhYmxlIGZ1bmN0aW9ucywg dGhlIFBvRAphY2NvdW50aW5nIHNob3VsZCBoYXZlIGJlZW4gb3V0c2lkZSBv ZiB0aGF0IGlmKCkgZnJvbSB0aGUgdmVyeQpiZWdpbm5pbmcuCgpTaWduZWQt b2ZmLWJ5OiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+CkFja2Vk LWJ5OiBBbmRyZXcgQ29vcGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29t PgoKLS0tIGEveGVuL2FyY2gveDg2L21tL3AybS5jCisrKyBiL3hlbi9hcmNo L3g4Ni9tbS9wMm0uYwpAQCAtNzk0LDYgKzc5NCwxMiBAQCBndWVzdF9waHlz bWFwX2FkZF9lbnRyeShzdHJ1Y3QgZG9tYWluICpkCiAgICAgaWYgKCBwMm1f aXNfZm9yZWlnbih0KSApCiAgICAgICAgIHJldHVybiAtRUlOVkFMOwogCisg ICAgaWYgKCAhbWZuX3ZhbGlkKG1mbikgKQorICAgIHsKKyAgICAgICAgQVNT RVJUX1VOUkVBQ0hBQkxFKCk7CisgICAgICAgIHJldHVybiAtRUlOVkFMOwor ICAgIH0KKwogICAgIHAybV9sb2NrKHAybSk7CiAKICAgICBQMk1fREVCVUco ImFkZGluZyBnZm49JSNseCBtZm49JSNseFxuIiwgZ2ZuX3goZ2ZuKSwgbWZu X3gobWZuKSk7CkBAIC04OTQsMTIgKzkwMCwxMyBAQCBndWVzdF9waHlzbWFw X2FkZF9lbnRyeShzdHJ1Y3QgZG9tYWluICpkCiAgICAgfQogCiAgICAgLyog Tm93LCBhY3R1YWxseSBkbyB0aGUgdHdvLXdheSBtYXBwaW5nICovCi0gICAg aWYgKCBtZm5fdmFsaWQobWZuKSApCisgICAgcmMgPSBwMm1fc2V0X2VudHJ5 KHAybSwgZ2ZuLCBtZm4sIHBhZ2Vfb3JkZXIsIHQsIHAybS0+ZGVmYXVsdF9h Y2Nlc3MpOworICAgIGlmICggcmMgPT0gMCApCiAgICAgewotICAgICAgICBy YyA9IHAybV9zZXRfZW50cnkocDJtLCBnZm4sIG1mbiwgcGFnZV9vcmRlciwg dCwKLSAgICAgICAgICAgICAgICAgICAgICAgICAgIHAybS0+ZGVmYXVsdF9h Y2Nlc3MpOwotICAgICAgICBpZiAoIHJjICkKLSAgICAgICAgICAgIGdvdG8g b3V0OyAvKiBGYWlsZWQgdG8gdXBkYXRlIHAybSwgYmFpbCB3aXRob3V0IHVw ZGF0aW5nIG0ycC4gKi8KKyAgICAgICAgcG9kX2xvY2socDJtKTsKKyAgICAg ICAgcDJtLT5wb2QuZW50cnlfY291bnQgLT0gcG9kX2NvdW50OworICAgICAg ICBCVUdfT04ocDJtLT5wb2QuZW50cnlfY291bnQgPCAwKTsKKyAgICAgICAg cG9kX3VubG9jayhwMm0pOwogCiAgICAgICAgIGlmICggIXAybV9pc19ncmFu dCh0KSApCiAgICAgICAgIHsKQEAgLTkwOCwyMiArOTE1LDcgQEAgZ3Vlc3Rf cGh5c21hcF9hZGRfZW50cnkoc3RydWN0IGRvbWFpbiAqZAogICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIGdmbl94KGdmbl9hZGQoZ2ZuLCBp KSkpOwogICAgICAgICB9CiAgICAgfQotICAgIGVsc2UKLSAgICB7Ci0gICAg ICAgIGdkcHJpbnRrKFhFTkxPR19XQVJOSU5HLCAiQWRkaW5nIGJhZCBtZm4g dG8gcDJtIG1hcCAoJSNseCAtPiAlI2x4KVxuIiwKLSAgICAgICAgICAgICAg ICAgZ2ZuX3goZ2ZuKSwgbWZuX3gobWZuKSk7Ci0gICAgICAgIHJjID0gcDJt X3NldF9lbnRyeShwMm0sIGdmbiwgSU5WQUxJRF9NRk4sIHBhZ2Vfb3JkZXIs Ci0gICAgICAgICAgICAgICAgICAgICAgICAgICBwMm1faW52YWxpZCwgcDJt LT5kZWZhdWx0X2FjY2Vzcyk7Ci0gICAgICAgIGlmICggcmMgPT0gMCApCi0g ICAgICAgIHsKLSAgICAgICAgICAgIHBvZF9sb2NrKHAybSk7Ci0gICAgICAg ICAgICBwMm0tPnBvZC5lbnRyeV9jb3VudCAtPSBwb2RfY291bnQ7Ci0gICAg ICAgICAgICBCVUdfT04ocDJtLT5wb2QuZW50cnlfY291bnQgPCAwKTsKLSAg ICAgICAgICAgIHBvZF91bmxvY2socDJtKTsKLSAgICAgICAgfQotICAgIH0K IAotb3V0OgogICAgIHAybV91bmxvY2socDJtKTsKIAogICAgIHJldHVybiBy YzsK --=separator Content-Type: application/octet-stream; name="xsa378/xsa378-4.11-0b.patch" Content-Disposition: attachment; filename="xsa378/xsa378-4.11-0b.patch" Content-Transfer-Encoding: base64 RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0 OiB4ODYvcDJtOiBkb24ndCBpZ25vcmUgcDJtX3JlbW92ZV9wYWdlKCkncyBy ZXR1cm4gdmFsdWUKCkl0J3Mgbm90IHZlcnkgbmljZSB0byByZXR1cm4gZnJv bSBndWVzdF9waHlzbWFwX2FkZF9lbnRyeSgpIGFmdGVyCnBlcmhhcHMgYWxy ZWFkeSBoYXZpbmcgbWFkZSBzb21lIGNoYW5nZXMgdG8gdGhlIFAyTSwgYnV0 IHRoaXMgaXMgcHJlLQpleGlzdGluZyBwcmFjdGljZSBpbiB0aGUgZnVuY3Rp b24sIGFuZCBpbW8gYmV0dGVyIHRoYW4gaWdub3JpbmcgZXJyb3JzLgoKVGFr ZSB0aGUgbGliZXJ0eSBhbmQgcmVwbGFjZSBhbiBtZm5fYWRkKCkgaW5zdGFu Y2Ugd2l0aCBhIGxvY2FsIHZhcmlhYmxlCmFscmVhZHkgaG9sZGluZyB0aGUg cmVzdWx0IChhcyBwcm92ZW4gYnkgdGhlIGNoZWNrIGltbWVkaWF0ZWx5IGFo ZWFkKS4KClNpZ25lZC1vZmYtYnk6IEphbiBCZXVsaWNoIDxqYmV1bGljaEBz dXNlLmNvbT4KUmV2aWV3ZWQtYnk6IFBhdWwgRHVycmFudCA8cGF1bC5kdXJy YW50QGNpdHJpeC5jb20+CkFja2VkLWJ5OiBBbmRyZXcgQ29vcGVyIDxhbmRy ZXcuY29vcGVyM0BjaXRyaXguY29tPgoKLS0tIGEveGVuL2FyY2gveDg2L21t L3AybS5jCisrKyBiL3hlbi9hcmNoL3g4Ni9tbS9wMm0uYwpAQCAtNzAyLDgg KzcwMiw3IEBAIHZvaWQgcDJtX2ZpbmFsX3RlYXJkb3duKHN0cnVjdCBkb21h aW4gKmQKICAgICBwMm1fdGVhcmRvd25faG9zdHAybShkKTsKIH0KIAotCi1z dGF0aWMgaW50CitzdGF0aWMgaW50IF9fbXVzdF9jaGVjawogcDJtX3JlbW92 ZV9wYWdlKHN0cnVjdCBwMm1fZG9tYWluICpwMm0sIHVuc2lnbmVkIGxvbmcg Z2ZuX2wsIHVuc2lnbmVkIGxvbmcgbWZuLAogICAgICAgICAgICAgICAgIHVu c2lnbmVkIGludCBwYWdlX29yZGVyKQogewpAQCAtODkyLDkgKzg5MSw5IEBA IGd1ZXN0X3BoeXNtYXBfYWRkX2VudHJ5KHN0cnVjdCBkb21haW4gKmQKICAg ICAgICAgICAgICAgICBBU1NFUlQobWZuX3ZhbGlkKG9tZm4pKTsKICAgICAg ICAgICAgICAgICBQMk1fREVCVUcoIm9sZCBnZm49JSNseCAtPiBtZm4gJSNs eFxuIiwKICAgICAgICAgICAgICAgICAgICAgICAgICAgZ2ZuX3gob2dmbikg LCBtZm5feChvbWZuKSk7Ci0gICAgICAgICAgICAgICAgaWYgKCBtZm5fZXEo b21mbiwgbWZuX2FkZChtZm4sIGkpKSApCi0gICAgICAgICAgICAgICAgICAg IHAybV9yZW1vdmVfcGFnZShwMm0sIGdmbl94KG9nZm4pLCBtZm5feChtZm5f YWRkKG1mbiwgaSkpLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgMCk7CisgICAgICAgICAgICAgICAgaWYgKCBtZm5fZXEob21mbiwg bWZuX2FkZChtZm4sIGkpKSAmJgorICAgICAgICAgICAgICAgICAgICAgKHJj ID0gcDJtX3JlbW92ZV9wYWdlKHAybSwgZ2ZuX3gob2dmbiksIG1mbl94KG9t Zm4pLCAwKSkgKQorICAgICAgICAgICAgICAgICAgICBnb3RvIG91dDsKICAg ICAgICAgICAgIH0KICAgICAgICAgfQogICAgIH0KQEAgLTkxNiw2ICs5MTUs NyBAQCBndWVzdF9waHlzbWFwX2FkZF9lbnRyeShzdHJ1Y3QgZG9tYWluICpk CiAgICAgICAgIH0KICAgICB9CiAKKyBvdXQ6CiAgICAgcDJtX3VubG9jayhw Mm0pOwogCiAgICAgcmV0dXJuIHJjOwpAQCAtMjM4NSw5ICsyMzg1LDkgQEAg aW50IHAybV9jaGFuZ2VfYWx0cDJtX2dmbihzdHJ1Y3QgZG9tYWluCiAKICAg ICBpZiAoIGdmbl9lcShuZXdfZ2ZuLCBJTlZBTElEX0dGTikgKQogICAgIHsK LSAgICAgICAgaWYgKCBtZm5fdmFsaWQobWZuKSApCi0gICAgICAgICAgICBw Mm1fcmVtb3ZlX3BhZ2UoYXAybSwgZ2ZuX3gob2xkX2dmbiksIG1mbl94KG1m biksIFBBR0VfT1JERVJfNEspOwotICAgICAgICByYyA9IDA7CisgICAgICAg IHJjID0gbWZuX3ZhbGlkKG1mbikKKyAgICAgICAgICAgICA/IHAybV9yZW1v dmVfcGFnZShhcDJtLCBnZm5feChvbGRfZ2ZuKSwgbWZuX3gobWZuKSwgUEFH RV9PUkRFUl80SykKKyAgICAgICAgICAgICA6IDA7CiAgICAgICAgIGdvdG8g b3V0OwogICAgIH0KIAo= --=separator Content-Type: application/octet-stream; name="xsa378/xsa378-4.11-0c.patch" Content-Disposition: attachment; filename="xsa378/xsa378-4.11-0c.patch" Content-Transfer-Encoding: base64 RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0 OiB4ODYvcDJtOiBkb24ndCBhc3NlcnQgdGhhdCB0aGUgcGFzc2VkIGluIE1G TiBtYXRjaGVzIGZvciBhIHJlbW92ZQoKZ3Vlc3RfcGh5c21hcF9yZW1vdmVf cGFnZSgpIGdldHMgaGFuZGVkIGFuIE1GTiBmcm9tIHRoZSBvdXRzaWRlLCB5 ZXQKdGFrZXMgdGhlIG5lY2Vzc2FyeSBsb2NrIHRvIHByZXZlbnQgZnVydGhl ciBjaGFuZ2VzIHRvIHRoZSBHRk4gPC0+IE1GTgptYXBwaW5nIGl0c2VsZi4g V2hpbGUgc29tZSBjYWxsZXJzLCBpbiBwYXJ0aWN1bGFyIGd1ZXN0X3JlbW92 ZV9wYWdlKCkKKGJ5IHdheSBvZiBoYXZpbmcgY2FsbGVkIGdldF9nZm5fcXVl cnkoKSksIGhvbGQgdGhlIEdGTiBsb2NrIGFscmVhZHksCnZhcmlvdXMgb3Ro ZXJzIChtb3N0IG5vdGFibHkgcGVyaGFwcyB0aGUgMm5kIGluc3RhbmNlIGlu Cnhlbm1lbV9hZGRfdG9fcGh5c21hcF9vbmUoKSkgZG9uJ3QuIFdoaWxlIGl0 IGFsc28gaXMgYW4gb3B0aW9uIHRvIGZpeAphbGwgdGhlIGNhbGxlcnMsIGRl YWwgd2l0aCB0aGUgaXNzdWUgaW4gcDJtX3JlbW92ZV9wYWdlKCkgaW5zdGVh ZDoKUmVwbGFjZSB0aGUgQVNTRVJUKCkgYnkgYSBjb25kaXRpb25hbCBhbmQg c3BsaXQgdGhlIGxvb3AgaW50byB0d28sIHN1Y2gKdGhhdCBhbGwgY2hlY2tp bmcgZ2V0cyBkb25lIGJlZm9yZSBhbnkgbW9kaWZpY2F0aW9uIHdvdWxkIG9j Y3VyLgoKU2lnbmVkLW9mZi1ieTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1 c2UuY29tPgpSZXZpZXdlZC1ieTogUGF1bCBEdXJyYW50IDxwYXVsLmR1cnJh bnRAY2l0cml4LmNvbT4KQWNrZWQtYnk6IEFuZHJldyBDb29wZXIgPGFuZHJl dy5jb29wZXIzQGNpdHJpeC5jb20+CgotLS0gYS94ZW4vYXJjaC94ODYvbW0v cDJtLmMKKysrIGIveGVuL2FyY2gveDg2L21tL3AybS5jCkBAIC03MDgsNyAr NzA4LDYgQEAgcDJtX3JlbW92ZV9wYWdlKHN0cnVjdCBwMm1fZG9tYWluICpw Mm0sCiB7CiAgICAgdW5zaWduZWQgbG9uZyBpOwogICAgIGdmbl90IGdmbiA9 IF9nZm4oZ2ZuX2wpOwotICAgIG1mbl90IG1mbl9yZXR1cm47CiAgICAgcDJt X3R5cGVfdCB0OwogICAgIHAybV9hY2Nlc3NfdCBhOwogCkBAIC03MTksMTUg KzcxOCwyNiBAQCBwMm1fcmVtb3ZlX3BhZ2Uoc3RydWN0IHAybV9kb21haW4g KnAybSwKICAgICBBU1NFUlQoZ2ZuX2xvY2tlZF9ieV9tZShwMm0sIGdmbikp OwogICAgIFAyTV9ERUJVRygicmVtb3ZpbmcgZ2ZuPSUjbHggbWZuPSUjbHhc biIsIGdmbl9sLCBtZm4pOwogCisgICAgZm9yICggaSA9IDA7IGkgPCAoMVVM IDw8IHBhZ2Vfb3JkZXIpOyApCisgICAgeworICAgICAgICB1bnNpZ25lZCBp bnQgY3VyX29yZGVyOworICAgICAgICBtZm5fdCBtZm5fcmV0dXJuID0gcDJt LT5nZXRfZW50cnkocDJtLCBnZm5fYWRkKGdmbiwgaSksICZ0LCAmYSwgMCwK KyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICZj dXJfb3JkZXIsIE5VTEwpOworCisgICAgICAgIGlmICggcDJtX2lzX3ZhbGlk KHQpICYmCisgICAgICAgICAgICAgKCFtZm5fdmFsaWQoX21mbihtZm4pKSB8 fCBtZm4gKyBpICE9IG1mbl94KG1mbl9yZXR1cm4pKSApCisgICAgICAgICAg ICByZXR1cm4gLUVJTFNFUTsKKworICAgICAgICBpICs9ICgxVUwgPDwgY3Vy X29yZGVyKSAtICgoZ2ZuX2wgKyBpKSAmICgoMVVMIDw8IGN1cl9vcmRlcikg LSAxKSk7CisgICAgfQorCiAgICAgaWYgKCBtZm5fdmFsaWQoX21mbihtZm4p KSApCiAgICAgewogICAgICAgICBmb3IgKCBpID0gMDsgaSA8ICgxVUwgPDwg cGFnZV9vcmRlcik7IGkrKyApCiAgICAgICAgIHsKLSAgICAgICAgICAgIG1m bl9yZXR1cm4gPSBwMm0tPmdldF9lbnRyeShwMm0sIGdmbl9hZGQoZ2ZuLCBp KSwgJnQsICZhLCAwLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIE5VTEwsIE5VTEwpOworICAgICAgICAgICAgcDJtLT5nZXRf ZW50cnkocDJtLCBnZm5fYWRkKGdmbiwgaSksICZ0LCAmYSwgMCwgTlVMTCwg TlVMTCk7CiAgICAgICAgICAgICBpZiAoICFwMm1faXNfZ3JhbnQodCkgJiYg IXAybV9pc19zaGFyZWQodCkgJiYgIXAybV9pc19mb3JlaWduKHQpICkKICAg ICAgICAgICAgICAgICBzZXRfZ3Bmbl9mcm9tX21mbihtZm4raSwgSU5WQUxJ RF9NMlBfRU5UUlkpOwotICAgICAgICAgICAgQVNTRVJUKCAhcDJtX2lzX3Zh bGlkKHQpIHx8IG1mbiArIGkgPT0gbWZuX3gobWZuX3JldHVybikgKTsKICAg ICAgICAgfQogICAgIH0KICAgICByZXR1cm4gcDJtX3NldF9lbnRyeShwMm0s IGdmbiwgSU5WQUxJRF9NRk4sIHBhZ2Vfb3JkZXIsIHAybV9pbnZhbGlkLAo= --=separator Content-Type: application/octet-stream; name="xsa378/xsa378-4.11-1.patch" Content-Disposition: attachment; filename="xsa378/xsa378-4.11-1.patch" Content-Transfer-Encoding: base64 RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0 OiBBTUQvSU9NTVU6IGNvcnJlY3QgZ2xvYmFsIGV4Y2x1c2lvbiByYW5nZSBl eHRlbmRpbmcKCkJlc2lkZXMgdW5pdHkgbWFwcGluZyByZWdpb25zLCB0aGUg QU1EIElPTU1VIHNwZWMgYWxzbyBwcm92aWRlcyBmb3IKZXhjbHVzaW9uIHJh bmdlcyAoYXJlYXMgb2YgbWVtb3J5IG5vdCB0byBiZSBzdWJqZWN0IHRvIERN QSB0cmFuc2xhdGlvbikKdG8gYmUgc3BlY2lmaWVkIGJ5IGZpcm13YXJlIGlu IHRoZSBBQ1BJIHRhYmxlcy4gVGhlIHNwZWMgZG9lcyBub3QgcHV0CmFueSBj b25zdHJhaW50cyBvbiB0aGUgbnVtYmVyIG9mIHN1Y2ggcmVnaW9ucy4KCkJs aW5kbHkgYXNzdW1pbmcgYWxsIGFkZHJlc3NlcyBiZXR3ZWVuIGFueSB0d28g c3VjaCByYW5nZXMgc2hvdWxkIGFsc28KYmUgZXhjbHVkZWQgY2FuJ3QgYmUg cmlnaHQuIFNpbmNlIGhhcmR3YXJlIGhhcyByb29tIGZvciBqdXN0IGEgc2lu Z2xlCnN1Y2ggcmFuZ2UgKGNvbXByaXNlZCBvZiB0aGUgRXhjbHVzaW9uIEJh c2UgUmVnaXN0ZXIgYW5kIHRoZSBFeGNsdXNpb24KUmFuZ2UgTGltaXQgUmVn aXN0ZXIpLCBjb21iaW5lIG9ubHkgYWRqYWNlbnQgb3Igb3ZlcmxhcHBpbmcg cmVnaW9ucyAoZm9yCm5vdzsgdGhpcyBtYXkgcmVxdWlyZSBmdXJ0aGVyIGFk anVzdG1lbnQgaW4gY2FzZSB0YWJsZSBlbnRyaWVzIGFyZW4ndApzb3J0ZWQg YnkgYWRkcmVzcykgd2l0aCBtYXRjaGluZyBleGNsdXNpb25fYWxsb3dfYWxs IHNldHRpbmdzLiBUaGlzCnJlcXVpcmVzIGJ1YmJsaW5nIHVwIGVycm9yIGlu ZGljYXRvcnMsIHN1Y2ggdGhhdCBJT01NVSBpbml0IGNhbiBiZQpmYWlsZWQg d2hlbiBjb25jYXRlbmF0aW9uIHdhc24ndCBwb3NzaWJsZS4KCkZ1cnRoZXJt b3JlLCBzaW5jZSB0aGUgZXhjbHVzaW9uIHJhbmdlIHNwZWNpZmllZCBpbiBJ T01NVSByZWdpc3RlcnMKaW1wbGllcyBSL1cgYWNjZXNzLCByZWplY3QgcmVx dWVzdHMgYXNraW5nIGZvciBsZXNzIHBlcm1pc3Npb25zICh0aGlzCndpbGwg YmUgYnJvdWdodCBjbG9zZXIgdG8gdGhlIHNwZWMgYnkgYSBzdWJzZXF1ZW50 IGNoYW5nZSkuCgpUaGlzIGlzIHBhcnQgb2YgWFNBLTM3OCAvIENWRS0yMDIx LTI4Njk1LgoKU2lnbmVkLW9mZi1ieTogSmFuIEJldWxpY2ggPGpiZXVsaWNo QHN1c2UuY29tPgpSZXZpZXdlZC1ieTogUGF1bCBEdXJyYW50IDxwYXVsQHhl bi5vcmc+CgotLS0gYS94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC9hbWQvaW9t bXVfYWNwaS5jCisrKyBiL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL2FtZC9p b21tdV9hY3BpLmMKQEAgLTk4LDEyICs5OCwyMSBAQCBzdGF0aWMgc3RydWN0 IGFtZF9pb21tdSAqIF9faW5pdCBmaW5kX2lvCiAgICAgcmV0dXJuIE5VTEw7 CiB9CiAKLXN0YXRpYyB2b2lkIF9faW5pdCByZXNlcnZlX2lvbW11X2V4Y2x1 c2lvbl9yYW5nZSgKLSAgICBzdHJ1Y3QgYW1kX2lvbW11ICppb21tdSwgdWlu dDY0X3QgYmFzZSwgdWludDY0X3QgbGltaXQpCitzdGF0aWMgaW50IF9faW5p dCByZXNlcnZlX2lvbW11X2V4Y2x1c2lvbl9yYW5nZSgKKyAgICBzdHJ1Y3Qg YW1kX2lvbW11ICppb21tdSwgdWludDY0X3QgYmFzZSwgdWludDY0X3QgbGlt aXQsCisgICAgYm9vbCBhbGwsIGJvb2wgaXcsIGJvb2wgaXIpCiB7CisgICAg aWYgKCAhaXIgfHwgIWl3ICkKKyAgICAgICAgcmV0dXJuIC1FUEVSTTsKKwog ICAgIC8qIG5lZWQgdG8gZXh0ZW5kIGV4Y2x1c2lvbiByYW5nZT8gKi8KICAg ICBpZiAoIGlvbW11LT5leGNsdXNpb25fZW5hYmxlICkKICAgICB7CisgICAg ICAgIGlmICggaW9tbXUtPmV4Y2x1c2lvbl9saW1pdCArIFBBR0VfU0laRSA8 IGJhc2UgfHwKKyAgICAgICAgICAgICBsaW1pdCArIFBBR0VfU0laRSA8IGlv bW11LT5leGNsdXNpb25fYmFzZSB8fAorICAgICAgICAgICAgIGlvbW11LT5l eGNsdXNpb25fYWxsb3dfYWxsICE9IGFsbCApCisgICAgICAgICAgICByZXR1 cm4gLUVCVVNZOworCiAgICAgICAgIGlmICggaW9tbXUtPmV4Y2x1c2lvbl9i YXNlIDwgYmFzZSApCiAgICAgICAgICAgICBiYXNlID0gaW9tbXUtPmV4Y2x1 c2lvbl9iYXNlOwogICAgICAgICBpZiAoIGlvbW11LT5leGNsdXNpb25fbGlt aXQgPiBsaW1pdCApCkBAIC0xMTEsMTYgKzEyMCwxMSBAQCBzdGF0aWMgdm9p ZCBfX2luaXQgcmVzZXJ2ZV9pb21tdV9leGNsdXNpCiAgICAgfQogCiAgICAg aW9tbXUtPmV4Y2x1c2lvbl9lbmFibGUgPSBJT01NVV9DT05UUk9MX0VOQUJM RUQ7CisgICAgaW9tbXUtPmV4Y2x1c2lvbl9hbGxvd19hbGwgPSBhbGw7CiAg ICAgaW9tbXUtPmV4Y2x1c2lvbl9iYXNlID0gYmFzZTsKICAgICBpb21tdS0+ ZXhjbHVzaW9uX2xpbWl0ID0gbGltaXQ7Ci19CiAKLXN0YXRpYyB2b2lkIF9f aW5pdCByZXNlcnZlX2lvbW11X2V4Y2x1c2lvbl9yYW5nZV9hbGwoCi0gICAg c3RydWN0IGFtZF9pb21tdSAqaW9tbXUsCi0gICAgdW5zaWduZWQgbG9uZyBi YXNlLCB1bnNpZ25lZCBsb25nIGxpbWl0KQotewotICAgIHJlc2VydmVfaW9t bXVfZXhjbHVzaW9uX3JhbmdlKGlvbW11LCBiYXNlLCBsaW1pdCk7Ci0gICAg aW9tbXUtPmV4Y2x1c2lvbl9hbGxvd19hbGwgPSBJT01NVV9DT05UUk9MX0VO QUJMRUQ7CisgICAgcmV0dXJuIDA7CiB9CiAKIHN0YXRpYyB2b2lkIF9faW5p dCByZXNlcnZlX3VuaXR5X21hcF9mb3JfZGV2aWNlKApAQCAtMTU4LDYgKzE2 Miw3IEBAIHN0YXRpYyBpbnQgX19pbml0IHJlZ2lzdGVyX2V4Y2x1c2lvbl9y YW4KICAgICB1bnNpZ25lZCBsb25nIHJhbmdlX3RvcCwgaW9tbXVfdG9wLCBs ZW5ndGg7CiAgICAgc3RydWN0IGFtZF9pb21tdSAqaW9tbXU7CiAgICAgdW5z aWduZWQgaW50IGJkZjsKKyAgICBpbnQgcmMgPSAwOwogCiAgICAgLyogaXMg cGFydCBvZiBleGNsdXNpb24gcmFuZ2UgaW5zaWRlIG9mIElPTU1VIHZpcnR1 YWwgYWRkcmVzcyBzcGFjZT8gKi8KICAgICAvKiBub3RlOiAnbGltaXQnIHBh cmFtZXRlciBpcyBhc3N1bWVkIHRvIGJlIHBhZ2UtYWxpZ25lZCAqLwpAQCAt MTc5LDEwICsxODQsMTUgQEAgc3RhdGljIGludCBfX2luaXQgcmVnaXN0ZXJf ZXhjbHVzaW9uX3JhbgogICAgIGlmICggbGltaXQgPj0gaW9tbXVfdG9wICkK ICAgICB7CiAgICAgICAgIGZvcl9lYWNoX2FtZF9pb21tdSggaW9tbXUgKQot ICAgICAgICAgICAgcmVzZXJ2ZV9pb21tdV9leGNsdXNpb25fcmFuZ2VfYWxs KGlvbW11LCBiYXNlLCBsaW1pdCk7CisgICAgICAgIHsKKyAgICAgICAgICAg IHJjID0gcmVzZXJ2ZV9pb21tdV9leGNsdXNpb25fcmFuZ2UoaW9tbXUsIGJh c2UsIGxpbWl0LAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICB0cnVlIC8qIGFsbCAqLywgaXcsIGlyKTsKKyAgICAg ICAgICAgIGlmICggcmMgKQorICAgICAgICAgICAgICAgIGJyZWFrOworICAg ICAgICB9CiAgICAgfQogCi0gICAgcmV0dXJuIDA7CisgICAgcmV0dXJuIHJj OwogfQogCiBzdGF0aWMgaW50IF9faW5pdCByZWdpc3Rlcl9leGNsdXNpb25f cmFuZ2VfZm9yX2RldmljZSgKQEAgLTE5Myw2ICsyMDMsNyBAQCBzdGF0aWMg aW50IF9faW5pdCByZWdpc3Rlcl9leGNsdXNpb25fcmFuCiAgICAgdW5zaWdu ZWQgbG9uZyByYW5nZV90b3AsIGlvbW11X3RvcCwgbGVuZ3RoOwogICAgIHN0 cnVjdCBhbWRfaW9tbXUgKmlvbW11OwogICAgIHUxNiByZXE7CisgICAgaW50 IHJjID0gMDsKIAogICAgIGlvbW11ID0gZmluZF9pb21tdV9mb3JfZGV2aWNl KHNlZywgYmRmKTsKICAgICBpZiAoICFpb21tdSApCkBAIC0yMjIsMTIgKzIz MywxMyBAQCBzdGF0aWMgaW50IF9faW5pdCByZWdpc3Rlcl9leGNsdXNpb25f cmFuCiAgICAgLyogcmVnaXN0ZXIgSU9NTVUgZXhjbHVzaW9uIHJhbmdlIHNl dHRpbmdzIGZvciBkZXZpY2UgKi8KICAgICBpZiAoIGxpbWl0ID49IGlvbW11 X3RvcCAgKQogICAgIHsKLSAgICAgICAgcmVzZXJ2ZV9pb21tdV9leGNsdXNp b25fcmFuZ2UoaW9tbXUsIGJhc2UsIGxpbWl0KTsKKyAgICAgICAgcmMgPSBy ZXNlcnZlX2lvbW11X2V4Y2x1c2lvbl9yYW5nZShpb21tdSwgYmFzZSwgbGlt aXQsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgZmFsc2UgLyogYWxsICovLCBpdywgaXIpOwogICAgICAgICBpdnJzX21h cHBpbmdzW2JkZl0uZHRlX2FsbG93X2V4Y2x1c2lvbiA9IElPTU1VX0NPTlRS T0xfRU5BQkxFRDsKICAgICAgICAgaXZyc19tYXBwaW5nc1tyZXFdLmR0ZV9h bGxvd19leGNsdXNpb24gPSBJT01NVV9DT05UUk9MX0VOQUJMRUQ7CiAgICAg fQogCi0gICAgcmV0dXJuIDA7CisgICAgcmV0dXJuIHJjOwogfQogCiBzdGF0 aWMgaW50IF9faW5pdCByZWdpc3Rlcl9leGNsdXNpb25fcmFuZ2VfZm9yX2lv bW11X2RldmljZXMoCkBAIC0yMzcsNiArMjQ5LDcgQEAgc3RhdGljIGludCBf X2luaXQgcmVnaXN0ZXJfZXhjbHVzaW9uX3JhbgogICAgIHVuc2lnbmVkIGxv bmcgcmFuZ2VfdG9wLCBpb21tdV90b3AsIGxlbmd0aDsKICAgICB1bnNpZ25l ZCBpbnQgYmRmOwogICAgIHUxNiByZXE7CisgICAgaW50IHJjID0gMDsKIAog ICAgIC8qIGlzIHBhcnQgb2YgZXhjbHVzaW9uIHJhbmdlIGluc2lkZSBvZiBJ T01NVSB2aXJ0dWFsIGFkZHJlc3Mgc3BhY2U/ICovCiAgICAgLyogbm90ZTog J2xpbWl0JyBwYXJhbWV0ZXIgaXMgYXNzdW1lZCB0byBiZSBwYWdlLWFsaWdu ZWQgKi8KQEAgLTI2Nyw4ICsyODAsMTAgQEAgc3RhdGljIGludCBfX2luaXQg cmVnaXN0ZXJfZXhjbHVzaW9uX3JhbgogCiAgICAgLyogcmVnaXN0ZXIgSU9N TVUgZXhjbHVzaW9uIHJhbmdlIHNldHRpbmdzICovCiAgICAgaWYgKCBsaW1p dCA+PSBpb21tdV90b3AgKQotICAgICAgICByZXNlcnZlX2lvbW11X2V4Y2x1 c2lvbl9yYW5nZV9hbGwoaW9tbXUsIGJhc2UsIGxpbWl0KTsKLSAgICByZXR1 cm4gMDsKKyAgICAgICAgcmMgPSByZXNlcnZlX2lvbW11X2V4Y2x1c2lvbl9y YW5nZShpb21tdSwgYmFzZSwgbGltaXQsCisgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgdHJ1ZSAvKiBhbGwgKi8sIGl3LCBp cik7CisKKyAgICByZXR1cm4gcmM7CiB9CiAKIHN0YXRpYyBpbnQgX19pbml0 IHBhcnNlX2l2bWRfZGV2aWNlX3NlbGVjdCgK --=separator Content-Type: application/octet-stream; name="xsa378/xsa378-4.11-2.patch" Content-Disposition: attachment; filename="xsa378/xsa378-4.11-2.patch" Content-Transfer-Encoding: base64 RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0 OiBBTUQvSU9NTVU6IGNvcnJlY3QgZGV2aWNlIHVuaXR5IG1hcCBoYW5kbGlu ZwoKQmxpbmRseSBhc3N1bWluZyBhbGwgYWRkcmVzc2VzIGJldHdlZW4gYW55 IHR3byBzdWNoIHJhbmdlcywgc3BlY2lmaWVkIGJ5CmZpcm13YXJlIGluIHRo ZSBBQ1BJIHRhYmxlcywgc2hvdWxkIGFsc28gYmUgdW5pdHktbWFwcGVkIGNh bid0IGJlIHJpZ2h0LgpOb3IgY2FuIGl0IGJlIGNvcnJlY3QgdG8gbWVyZ2Ug cmFuZ2VzIHdpdGggZGlmZmVyaW5nIHBlcm1pc3Npb25zLiBUcmFjawpyYW5n ZXMgaW5kaXZpZHVhbGx5OyBkb24ndCBtZXJnZSBhdCBhbGwsIGJ1dCBjaGVj ayBmb3Igb3ZlcmxhcHMgaW5zdGVhZC4KVGhpcyByZXF1aXJlcyBidWJibGlu ZyB1cCBlcnJvciBpbmRpY2F0b3JzLCBzdWNoIHRoYXQgSU9NTVUgaW5pdCBj YW4gYmUKZmFpbGVkIHdoZW4gYWxsb2NhdGlvbiBvZiBhIG5ldyB0cmFja2lu ZyBzdHJ1Y3Qgd2Fzbid0IHBvc3NpYmxlLCBvciBhbgpvdmVybGFwIHdhcyBk ZXRlY3RlZC4KCkF0IHRoaXMgb2NjYXNpb24gYWxzbyBzdG9wIGlnbm9yaW5n CmFtZF9pb21tdV9yZXNlcnZlX2RvbWFpbl91bml0eV9tYXAoKSdzIHJldHVy biB2YWx1ZS4KClRoaXMgaXMgcGFydCBvZiBYU0EtMzc4IC8gQ1ZFLTIwMjEt Mjg2OTUuCgpTaWduZWQtb2ZmLWJ5OiBKYW4gQmV1bGljaCA8amJldWxpY2hA c3VzZS5jb20+ClJldmlld2VkLWJ5OiBHZW9yZ2UgRHVubGFwIDxnZW9yZ2Uu ZHVubGFwQGNpdHJpeC5jb20+ClJldmlld2VkLWJ5OiBQYXVsIER1cnJhbnQg PHBhdWxAeGVuLm9yZz4KCi0tLSBhL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdo L2FtZC9pb21tdV9hY3BpLmMKKysrIGIveGVuL2RyaXZlcnMvcGFzc3Rocm91 Z2gvYW1kL2lvbW11X2FjcGkuYwpAQCAtMTI3LDMyICsxMjcsNDggQEAgc3Rh dGljIGludCBfX2luaXQgcmVzZXJ2ZV9pb21tdV9leGNsdXNpbwogICAgIHJl dHVybiAwOwogfQogCi1zdGF0aWMgdm9pZCBfX2luaXQgcmVzZXJ2ZV91bml0 eV9tYXBfZm9yX2RldmljZSgKLSAgICB1MTYgc2VnLCB1MTYgYmRmLCB1bnNp Z25lZCBsb25nIGJhc2UsCi0gICAgdW5zaWduZWQgbG9uZyBsZW5ndGgsIHU4 IGl3LCB1OCBpcikKK3N0YXRpYyBpbnQgX19pbml0IHJlc2VydmVfdW5pdHlf bWFwX2Zvcl9kZXZpY2UoCisgICAgdWludDE2X3Qgc2VnLCB1aW50MTZfdCBi ZGYsIHVuc2lnbmVkIGxvbmcgYmFzZSwKKyAgICB1bnNpZ25lZCBsb25nIGxl bmd0aCwgYm9vbCBpdywgYm9vbCBpcikKIHsKICAgICBzdHJ1Y3QgaXZyc19t YXBwaW5ncyAqaXZyc19tYXBwaW5ncyA9IGdldF9pdnJzX21hcHBpbmdzKHNl Zyk7Ci0gICAgdW5zaWduZWQgbG9uZyBvbGRfdG9wLCBuZXdfdG9wOworICAg IHN0cnVjdCBpdnJzX3VuaXR5X21hcCAqdW5pdHlfbWFwID0gaXZyc19tYXBw aW5nc1tiZGZdLnVuaXR5X21hcDsKIAotICAgIC8qIG5lZWQgdG8gZXh0ZW5k IHVuaXR5LW1hcHBlZCByYW5nZT8gKi8KLSAgICBpZiAoIGl2cnNfbWFwcGlu Z3NbYmRmXS51bml0eV9tYXBfZW5hYmxlICkKKyAgICAvKiBDaGVjayBmb3Ig b3ZlcmxhcHMuICovCisgICAgZm9yICggOyB1bml0eV9tYXA7IHVuaXR5X21h cCA9IHVuaXR5X21hcC0+bmV4dCApCiAgICAgewotICAgICAgICBvbGRfdG9w ID0gaXZyc19tYXBwaW5nc1tiZGZdLmFkZHJfcmFuZ2Vfc3RhcnQgKwotICAg ICAgICAgICAgaXZyc19tYXBwaW5nc1tiZGZdLmFkZHJfcmFuZ2VfbGVuZ3Ro OwotICAgICAgICBuZXdfdG9wID0gYmFzZSArIGxlbmd0aDsKLSAgICAgICAg aWYgKCBvbGRfdG9wID4gbmV3X3RvcCApCi0gICAgICAgICAgICBuZXdfdG9w ID0gb2xkX3RvcDsKLSAgICAgICAgaWYgKCBpdnJzX21hcHBpbmdzW2JkZl0u YWRkcl9yYW5nZV9zdGFydCA8IGJhc2UgKQotICAgICAgICAgICAgYmFzZSA9 IGl2cnNfbWFwcGluZ3NbYmRmXS5hZGRyX3JhbmdlX3N0YXJ0OwotICAgICAg ICBsZW5ndGggPSBuZXdfdG9wIC0gYmFzZTsKLSAgICB9Ci0KLSAgICAvKiBl eHRlbmQgci93IHBlcm1pc3Npb21zIGFuZCBrZWVwIGFnZ3JlZ2F0ZSAqLwot ICAgIGl2cnNfbWFwcGluZ3NbYmRmXS53cml0ZV9wZXJtaXNzaW9uID0gaXc7 Ci0gICAgaXZyc19tYXBwaW5nc1tiZGZdLnJlYWRfcGVybWlzc2lvbiA9IGly OwotICAgIGl2cnNfbWFwcGluZ3NbYmRmXS51bml0eV9tYXBfZW5hYmxlID0g SU9NTVVfQ09OVFJPTF9FTkFCTEVEOwotICAgIGl2cnNfbWFwcGluZ3NbYmRm XS5hZGRyX3JhbmdlX3N0YXJ0ID0gYmFzZTsKLSAgICBpdnJzX21hcHBpbmdz W2JkZl0uYWRkcl9yYW5nZV9sZW5ndGggPSBsZW5ndGg7CisgICAgICAgIC8q CisgICAgICAgICAqIEV4YWN0IG1hdGNoZXMgYXJlIG9rYXkuIFRoaXMgY2Fu IGluIHBhcnRpY3VsYXIgaGFwcGVuIHdoZW4KKyAgICAgICAgICogcmVnaXN0 ZXJfZXhjbHVzaW9uX3JhbmdlX2Zvcl9kZXZpY2UoKSBjYWxscyBoZXJlIHR3 aWNlIGZvciB0aGUKKyAgICAgICAgICogc2FtZSAocyxiLGQsZikuCisgICAg ICAgICAqLworICAgICAgICBpZiAoIGJhc2UgPT0gdW5pdHlfbWFwLT5hZGRy ICYmIGxlbmd0aCA9PSB1bml0eV9tYXAtPmxlbmd0aCAmJgorICAgICAgICAg ICAgIGlyID09IHVuaXR5X21hcC0+cmVhZCAmJiBpdyA9PSB1bml0eV9tYXAt PndyaXRlICkKKyAgICAgICAgICAgIHJldHVybiAwOworCisgICAgICAgIGlm ICggdW5pdHlfbWFwLT5hZGRyICsgdW5pdHlfbWFwLT5sZW5ndGggPiBiYXNl ICYmCisgICAgICAgICAgICAgYmFzZSArIGxlbmd0aCA+IHVuaXR5X21hcC0+ YWRkciApCisgICAgICAgIHsKKyAgICAgICAgICAgIEFNRF9JT01NVV9ERUJV RygiSVZNRCBFcnJvcjogb3ZlcmxhcCBbJWx4LCVseCkgdnMgWyVseCwlbHgp XG4iLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgIGJhc2UsIGJhc2Ug KyBsZW5ndGgsIHVuaXR5X21hcC0+YWRkciwKKyAgICAgICAgICAgICAgICAg ICAgICAgICAgICB1bml0eV9tYXAtPmFkZHIgKyB1bml0eV9tYXAtPmxlbmd0 aCk7CisgICAgICAgICAgICByZXR1cm4gLUVQRVJNOworICAgICAgICB9Cisg ICAgfQorCisgICAgLyogUG9wdWxhdGUgYW5kIGluc2VydCBhIG5ldyB1bml0 eSBtYXAuICovCisgICAgdW5pdHlfbWFwID0geG1hbGxvYyhzdHJ1Y3QgaXZy c191bml0eV9tYXApOworICAgIGlmICggIXVuaXR5X21hcCApCisgICAgICAg IHJldHVybiAtRU5PTUVNOworCisgICAgdW5pdHlfbWFwLT5yZWFkID0gaXI7 CisgICAgdW5pdHlfbWFwLT53cml0ZSA9IGl3OworICAgIHVuaXR5X21hcC0+ YWRkciA9IGJhc2U7CisgICAgdW5pdHlfbWFwLT5sZW5ndGggPSBsZW5ndGg7 CisgICAgdW5pdHlfbWFwLT5uZXh0ID0gaXZyc19tYXBwaW5nc1tiZGZdLnVu aXR5X21hcDsKKyAgICBpdnJzX21hcHBpbmdzW2JkZl0udW5pdHlfbWFwID0g dW5pdHlfbWFwOworCisgICAgcmV0dXJuIDA7CiB9CiAKIHN0YXRpYyBpbnQg X19pbml0IHJlZ2lzdGVyX2V4Y2x1c2lvbl9yYW5nZV9mb3JfYWxsX2Rldmlj ZXMoCkBAIC0xNzUsMTMgKzE5MSwxMyBAQCBzdGF0aWMgaW50IF9faW5pdCBy ZWdpc3Rlcl9leGNsdXNpb25fcmFuCiAgICAgICAgIGxlbmd0aCA9IHJhbmdl X3RvcCAtIGJhc2U7CiAgICAgICAgIC8qIHJlc2VydmUgci93IHVuaXR5LW1h cHBlZCBwYWdlIGVudHJpZXMgZm9yIGRldmljZXMgKi8KICAgICAgICAgLyog bm90ZTogdGhlc2UgZW50cmllcyBhcmUgcGFydCBvZiB0aGUgZXhjbHVzaW9u IHJhbmdlICovCi0gICAgICAgIGZvciAoIGJkZiA9IDA7IGJkZiA8IGl2cnNf YmRmX2VudHJpZXM7IGJkZisrICkKLSAgICAgICAgICAgIHJlc2VydmVfdW5p dHlfbWFwX2Zvcl9kZXZpY2Uoc2VnLCBiZGYsIGJhc2UsIGxlbmd0aCwgaXcs IGlyKTsKKyAgICAgICAgZm9yICggYmRmID0gMDsgIXJjICYmIGJkZiA8IGl2 cnNfYmRmX2VudHJpZXM7IGJkZisrICkKKyAgICAgICAgICAgIHJjID0gcmVz ZXJ2ZV91bml0eV9tYXBfZm9yX2RldmljZShzZWcsIGJkZiwgYmFzZSwgbGVu Z3RoLCBpdywgaXIpOwogICAgICAgICAvKiBwdXNoICdiYXNlJyBqdXN0IG91 dHNpZGUgb2YgdmlydHVhbCBhZGRyZXNzIHNwYWNlICovCiAgICAgICAgIGJh c2UgPSBpb21tdV90b3A7CiAgICAgfQogICAgIC8qIHJlZ2lzdGVyIElPTU1V IGV4Y2x1c2lvbiByYW5nZSBzZXR0aW5ncyAqLwotICAgIGlmICggbGltaXQg Pj0gaW9tbXVfdG9wICkKKyAgICBpZiAoICFyYyAmJiBsaW1pdCA+PSBpb21t dV90b3AgKQogICAgIHsKICAgICAgICAgZm9yX2VhY2hfYW1kX2lvbW11KCBp b21tdSApCiAgICAgICAgIHsKQEAgLTIyMywxNSArMjM5LDE1IEBAIHN0YXRp YyBpbnQgX19pbml0IHJlZ2lzdGVyX2V4Y2x1c2lvbl9yYW4KICAgICAgICAg bGVuZ3RoID0gcmFuZ2VfdG9wIC0gYmFzZTsKICAgICAgICAgLyogcmVzZXJ2 ZSB1bml0eS1tYXBwZWQgcGFnZSBlbnRyaWVzIGZvciBkZXZpY2UgKi8KICAg ICAgICAgLyogbm90ZTogdGhlc2UgZW50cmllcyBhcmUgcGFydCBvZiB0aGUg ZXhjbHVzaW9uIHJhbmdlICovCi0gICAgICAgIHJlc2VydmVfdW5pdHlfbWFw X2Zvcl9kZXZpY2Uoc2VnLCBiZGYsIGJhc2UsIGxlbmd0aCwgaXcsIGlyKTsK LSAgICAgICAgcmVzZXJ2ZV91bml0eV9tYXBfZm9yX2RldmljZShzZWcsIHJl cSwgYmFzZSwgbGVuZ3RoLCBpdywgaXIpOworICAgICAgICByYyA9IHJlc2Vy dmVfdW5pdHlfbWFwX2Zvcl9kZXZpY2Uoc2VnLCBiZGYsIGJhc2UsIGxlbmd0 aCwgaXcsIGlyKSA/OgorICAgICAgICAgICAgIHJlc2VydmVfdW5pdHlfbWFw X2Zvcl9kZXZpY2Uoc2VnLCByZXEsIGJhc2UsIGxlbmd0aCwgaXcsIGlyKTsK IAogICAgICAgICAvKiBwdXNoICdiYXNlJyBqdXN0IG91dHNpZGUgb2Ygdmly dHVhbCBhZGRyZXNzIHNwYWNlICovCiAgICAgICAgIGJhc2UgPSBpb21tdV90 b3A7CiAgICAgfQogCiAgICAgLyogcmVnaXN0ZXIgSU9NTVUgZXhjbHVzaW9u IHJhbmdlIHNldHRpbmdzIGZvciBkZXZpY2UgKi8KLSAgICBpZiAoIGxpbWl0 ID49IGlvbW11X3RvcCAgKQorICAgIGlmICggIXJjICYmIGxpbWl0ID49IGlv bW11X3RvcCAgKQogICAgIHsKICAgICAgICAgcmMgPSByZXNlcnZlX2lvbW11 X2V4Y2x1c2lvbl9yYW5nZShpb21tdSwgYmFzZSwgbGltaXQsCiAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZmFsc2UgLyog YWxsICovLCBpdywgaXIpOwpAQCAtMjYyLDE1ICsyNzgsMTUgQEAgc3RhdGlj IGludCBfX2luaXQgcmVnaXN0ZXJfZXhjbHVzaW9uX3JhbgogICAgICAgICBs ZW5ndGggPSByYW5nZV90b3AgLSBiYXNlOwogICAgICAgICAvKiByZXNlcnZl IHIvdyB1bml0eS1tYXBwZWQgcGFnZSBlbnRyaWVzIGZvciBkZXZpY2VzICov CiAgICAgICAgIC8qIG5vdGU6IHRoZXNlIGVudHJpZXMgYXJlIHBhcnQgb2Yg dGhlIGV4Y2x1c2lvbiByYW5nZSAqLwotICAgICAgICBmb3IgKCBiZGYgPSAw OyBiZGYgPCBpdnJzX2JkZl9lbnRyaWVzOyBiZGYrKyApCisgICAgICAgIGZv ciAoIGJkZiA9IDA7ICFyYyAmJiBiZGYgPCBpdnJzX2JkZl9lbnRyaWVzOyBi ZGYrKyApCiAgICAgICAgIHsKICAgICAgICAgICAgIGlmICggaW9tbXUgPT0g ZmluZF9pb21tdV9mb3JfZGV2aWNlKGlvbW11LT5zZWcsIGJkZikgKQogICAg ICAgICAgICAgewotICAgICAgICAgICAgICAgIHJlc2VydmVfdW5pdHlfbWFw X2Zvcl9kZXZpY2UoaW9tbXUtPnNlZywgYmRmLCBiYXNlLCBsZW5ndGgsCi0g ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBp dywgaXIpOwogICAgICAgICAgICAgICAgIHJlcSA9IGdldF9pdnJzX21hcHBp bmdzKGlvbW11LT5zZWcpW2JkZl0uZHRlX3JlcXVlc3Rvcl9pZDsKLSAgICAg ICAgICAgICAgICByZXNlcnZlX3VuaXR5X21hcF9mb3JfZGV2aWNlKGlvbW11 LT5zZWcsIHJlcSwgYmFzZSwgbGVuZ3RoLAotICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgaXcsIGlyKTsKKyAgICAgICAg ICAgICAgICByYyA9IHJlc2VydmVfdW5pdHlfbWFwX2Zvcl9kZXZpY2UoaW9t bXUtPnNlZywgYmRmLCBiYXNlLCBsZW5ndGgsCisgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGl3LCBpcikgPzoK KyAgICAgICAgICAgICAgICAgICAgIHJlc2VydmVfdW5pdHlfbWFwX2Zvcl9k ZXZpY2UoaW9tbXUtPnNlZywgcmVxLCBiYXNlLCBsZW5ndGgsCisgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGl3 LCBpcik7CiAgICAgICAgICAgICB9CiAgICAgICAgIH0KIApAQCAtMjc5LDcg KzI5NSw3IEBAIHN0YXRpYyBpbnQgX19pbml0IHJlZ2lzdGVyX2V4Y2x1c2lv bl9yYW4KICAgICB9CiAKICAgICAvKiByZWdpc3RlciBJT01NVSBleGNsdXNp b24gcmFuZ2Ugc2V0dGluZ3MgKi8KLSAgICBpZiAoIGxpbWl0ID49IGlvbW11 X3RvcCApCisgICAgaWYgKCAhcmMgJiYgbGltaXQgPj0gaW9tbXVfdG9wICkK ICAgICAgICAgcmMgPSByZXNlcnZlX2lvbW11X2V4Y2x1c2lvbl9yYW5nZShp b21tdSwgYmFzZSwgbGltaXQsCiAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgdHJ1ZSAvKiBhbGwgKi8sIGl3LCBpcik7CiAK LS0tIGEveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvYW1kL2lvbW11X2luaXQu YworKysgYi94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC9hbWQvaW9tbXVfaW5p dC5jCkBAIC0xMTg3LDcgKzExODcsNiBAQCBzdGF0aWMgaW50IF9faW5pdCBh bGxvY19pdnJzX21hcHBpbmdzKHUxCiAgICAgewogICAgICAgICBpdnJzX21h cHBpbmdzW2JkZl0uZHRlX3JlcXVlc3Rvcl9pZCA9IGJkZjsKICAgICAgICAg aXZyc19tYXBwaW5nc1tiZGZdLmR0ZV9hbGxvd19leGNsdXNpb24gPSBJT01N VV9DT05UUk9MX0RJU0FCTEVEOwotICAgICAgICBpdnJzX21hcHBpbmdzW2Jk Zl0udW5pdHlfbWFwX2VuYWJsZSA9IElPTU1VX0NPTlRST0xfRElTQUJMRUQ7 CiAgICAgICAgIGl2cnNfbWFwcGluZ3NbYmRmXS5pb21tdSA9IE5VTEw7CiAK ICAgICAgICAgaXZyc19tYXBwaW5nc1tiZGZdLmludHJlbWFwX3RhYmxlID0g TlVMTDsKLS0tIGEveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvYW1kL3BjaV9h bWRfaW9tbXUuYworKysgYi94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC9hbWQv cGNpX2FtZF9pb21tdS5jCkBAIC0zNzIsMTUgKzM3MiwxNyBAQCBzdGF0aWMg aW50IGFtZF9pb21tdV9hc3NpZ25fZGV2aWNlKHN0cnVjCiAgICAgc3RydWN0 IGl2cnNfbWFwcGluZ3MgKml2cnNfbWFwcGluZ3MgPSBnZXRfaXZyc19tYXBw aW5ncyhwZGV2LT5zZWcpOwogICAgIGludCBiZGYgPSBQQ0lfQkRGMihwZGV2 LT5idXMsIGRldmZuKTsKICAgICBpbnQgcmVxX2lkID0gZ2V0X2RtYV9yZXF1 ZXN0b3JfaWQocGRldi0+c2VnLCBiZGYpOworICAgIGNvbnN0IHN0cnVjdCBp dnJzX3VuaXR5X21hcCAqdW5pdHlfbWFwOwogCi0gICAgaWYgKCBpdnJzX21h cHBpbmdzW3JlcV9pZF0udW5pdHlfbWFwX2VuYWJsZSApCisgICAgZm9yICgg dW5pdHlfbWFwID0gaXZyc19tYXBwaW5nc1tyZXFfaWRdLnVuaXR5X21hcDsg dW5pdHlfbWFwOworICAgICAgICAgIHVuaXR5X21hcCA9IHVuaXR5X21hcC0+ bmV4dCApCiAgICAgewotICAgICAgICBhbWRfaW9tbXVfcmVzZXJ2ZV9kb21h aW5fdW5pdHlfbWFwKAotICAgICAgICAgICAgZCwKLSAgICAgICAgICAgIGl2 cnNfbWFwcGluZ3NbcmVxX2lkXS5hZGRyX3JhbmdlX3N0YXJ0LAotICAgICAg ICAgICAgaXZyc19tYXBwaW5nc1tyZXFfaWRdLmFkZHJfcmFuZ2VfbGVuZ3Ro LAotICAgICAgICAgICAgaXZyc19tYXBwaW5nc1tyZXFfaWRdLndyaXRlX3Bl cm1pc3Npb24sCi0gICAgICAgICAgICBpdnJzX21hcHBpbmdzW3JlcV9pZF0u cmVhZF9wZXJtaXNzaW9uKTsKKyAgICAgICAgaW50IHJjID0gYW1kX2lvbW11 X3Jlc2VydmVfZG9tYWluX3VuaXR5X21hcCgKKyAgICAgICAgICAgICAgICAg ICAgIGQsIHVuaXR5X21hcC0+YWRkciwgdW5pdHlfbWFwLT5sZW5ndGgsCisg ICAgICAgICAgICAgICAgICAgICB1bml0eV9tYXAtPndyaXRlLCB1bml0eV9t YXAtPnJlYWQpOworCisgICAgICAgIGlmICggcmMgKQorICAgICAgICAgICAg cmV0dXJuIHJjOwogICAgIH0KIAogICAgIHJldHVybiByZWFzc2lnbl9kZXZp Y2UocGRldi0+ZG9tYWluLCBkLCBkZXZmbiwgcGRldik7Ci0tLSBhL3hlbi9p bmNsdWRlL2FzbS14ODYvYW1kLWlvbW11LmgKKysrIGIveGVuL2luY2x1ZGUv YXNtLXg4Ni9hbWQtaW9tbXUuaApAQCAtMTA4LDE1ICsxMDgsMTkgQEAgc3Ry dWN0IGFtZF9pb21tdSB7CiAgICAgc3RydWN0IGxpc3RfaGVhZCBhdHNfZGV2 aWNlczsKIH07CiAKK3N0cnVjdCBpdnJzX3VuaXR5X21hcCB7CisgICAgYm9v bCByZWFkOjE7CisgICAgYm9vbCB3cml0ZToxOworICAgIHBhZGRyX3QgYWRk cjsKKyAgICB1bnNpZ25lZCBsb25nIGxlbmd0aDsKKyAgICBzdHJ1Y3QgaXZy c191bml0eV9tYXAgKm5leHQ7Cit9OworCiBzdHJ1Y3QgaXZyc19tYXBwaW5n cyB7CiAgICAgdTE2IGR0ZV9yZXF1ZXN0b3JfaWQ7CiAgICAgdTggZHRlX2Fs bG93X2V4Y2x1c2lvbjsKLSAgICB1OCB1bml0eV9tYXBfZW5hYmxlOwotICAg IHU4IHdyaXRlX3Blcm1pc3Npb247Ci0gICAgdTggcmVhZF9wZXJtaXNzaW9u OwotICAgIHVuc2lnbmVkIGxvbmcgYWRkcl9yYW5nZV9zdGFydDsKLSAgICB1 bnNpZ25lZCBsb25nIGFkZHJfcmFuZ2VfbGVuZ3RoOwogICAgIHN0cnVjdCBh bWRfaW9tbXUgKmlvbW11OworICAgIHN0cnVjdCBpdnJzX3VuaXR5X21hcCAq dW5pdHlfbWFwOwogCiAgICAgLyogcGVyIGRldmljZSBpbnRlcnJ1cHQgcmVt YXBwaW5nIHRhYmxlICovCiAgICAgdm9pZCAqaW50cmVtYXBfdGFibGU7Cg== --=separator Content-Type: application/octet-stream; name="xsa378/xsa378-4.11-3.patch" Content-Disposition: attachment; filename="xsa378/xsa378-4.11-3.patch" Content-Transfer-Encoding: base64 RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0 OiBJT01NVTogYWxzbyBwYXNzIHAybV9hY2Nlc3NfdCB0byBwMm1fZ2V0X2lv bW11X2ZsYWdzKCkKCkEgc3Vic2VxdWVudCBjaGFuZ2Ugd2lsbCB3YW50IHRv IGN1c3RvbWl6ZSB0aGUgSU9NTVUgcGVybWlzc2lvbnMgYmFzZWQKb24gdGhp cy4KClRoaXMgaXMgcGFydCBvZiBYU0EtMzc4LgoKU2lnbmVkLW9mZi1ieTog SmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpSZXZpZXdlZC1ieTog UGF1bCBEdXJyYW50IDxwYXVsQHhlbi5vcmc+CgotLS0gYS94ZW4vYXJjaC94 ODYvbW0vcDJtLWVwdC5jCisrKyBiL3hlbi9hcmNoL3g4Ni9tbS9wMm0tZXB0 LmMKQEAgLTcxMSw3ICs3MTEsNyBAQCBlcHRfc2V0X2VudHJ5KHN0cnVjdCBw Mm1fZG9tYWluICpwMm0sIGdmCiAgICAgdWludDhfdCBpcGF0ID0gMDsKICAg ICBib29sX3QgbmVlZF9tb2RpZnlfdnRkX3RhYmxlID0gMTsKICAgICBib29s X3QgdnRkX3B0ZV9wcmVzZW50ID0gMDsKLSAgICB1bnNpZ25lZCBpbnQgaW9t bXVfZmxhZ3MgPSBwMm1fZ2V0X2lvbW11X2ZsYWdzKHAybXQsIG1mbik7Cisg ICAgdW5zaWduZWQgaW50IGlvbW11X2ZsYWdzID0gcDJtX2dldF9pb21tdV9m bGFncyhwMm10LCBwMm1hLCBtZm4pOwogICAgIGJvb2xfdCBuZWVkc19zeW5j ID0gMTsKICAgICBlcHRfZW50cnlfdCBvbGRfZW50cnkgPSB7IC5lcHRlID0g MCB9OwogICAgIGVwdF9lbnRyeV90IG5ld19lbnRyeSA9IHsgLmVwdGUgPSAw IH07CkBAIC04MzcsOCArODM3LDggQEAgZXB0X3NldF9lbnRyeShzdHJ1Y3Qg cDJtX2RvbWFpbiAqcDJtLCBnZgogCiAgICAgICAgIC8qIFNhZmUgdG8gcmVh ZC10aGVuLXdyaXRlIGJlY2F1c2Ugd2UgaG9sZCB0aGUgcDJtIGxvY2sgKi8K ICAgICAgICAgaWYgKCBlcHRfZW50cnktPm1mbiA9PSBuZXdfZW50cnkubWZu ICYmCi0gICAgICAgICAgICAgcDJtX2dldF9pb21tdV9mbGFncyhlcHRfZW50 cnktPnNhX3AybXQsIF9tZm4oZXB0X2VudHJ5LT5tZm4pKSA9PQotICAgICAg ICAgICAgIGlvbW11X2ZsYWdzICkKKyAgICAgICAgICAgICBwMm1fZ2V0X2lv bW11X2ZsYWdzKGVwdF9lbnRyeS0+c2FfcDJtdCwgZXB0X2VudHJ5LT5hY2Nl c3MsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBfbWZuKGVw dF9lbnRyeS0+bWZuKSkgPT0gaW9tbXVfZmxhZ3MgKQogICAgICAgICAgICAg bmVlZF9tb2RpZnlfdnRkX3RhYmxlID0gMDsKIAogICAgICAgICBlcHRfcDJt X3R5cGVfdG9fZmxhZ3MocDJtLCAmbmV3X2VudHJ5LCBwMm10LCBwMm1hKTsK LS0tIGEveGVuL2FyY2gveDg2L21tL3AybS1wdC5jCisrKyBiL3hlbi9hcmNo L3g4Ni9tbS9wMm0tcHQuYwpAQCAtNDcxLDYgKzQ3MSwxNiBAQCBpbnQgcDJt X3B0X2hhbmRsZV9kZWZlcnJlZF9jaGFuZ2VzKHVpbnQ2CiAgICAgcmV0dXJu IHJjOwogfQogCisvKiBSZWNvbnN0cnVjdCBhIGZha2UgcDJtX2FjY2Vzc190 IGZyb20gc3RvcmVkIFBURSBmbGFncy4gKi8KK3N0YXRpYyBwMm1fYWNjZXNz X3QgcDJtX2ZsYWdzX3RvX2FjY2Vzcyh1bnNpZ25lZCBpbnQgZmxhZ3MpCit7 CisgICAgaWYgKCBmbGFncyAmIF9QQUdFX1BSRVNFTlQgKQorICAgICAgICBy ZXR1cm4gcDJtX2FjY2Vzc19uOworCisgICAgLyogTm8gbmVlZCB0byBsb29r IGF0IF9QQUdFX05YIGZvciBub3cuICovCisgICAgcmV0dXJuIGZsYWdzICYg X1BBR0VfUlcgPyBwMm1fYWNjZXNzX3J3IDogcDJtX2FjY2Vzc19yOworfQor CiAvKiBSZXR1cm5zOiAwIGZvciBzdWNjZXNzLCAtZXJybm8gZm9yIGZhaWx1 cmUgKi8KIHN0YXRpYyBpbnQKIHAybV9wdF9zZXRfZW50cnkoc3RydWN0IHAy bV9kb21haW4gKnAybSwgZ2ZuX3QgZ2ZuXywgbWZuX3QgbWZuLApAQCAtNDg3 LDcgKzQ5Nyw3IEBAIHAybV9wdF9zZXRfZW50cnkoc3RydWN0IHAybV9kb21h aW4gKnAybSwKICAgICBsMl9wZ2VudHJ5X3QgbDJlX2NvbnRlbnQ7CiAgICAg bDNfcGdlbnRyeV90IGwzZV9jb250ZW50OwogICAgIGludCByYzsKLSAgICB1 bnNpZ25lZCBpbnQgaW9tbXVfcHRlX2ZsYWdzID0gcDJtX2dldF9pb21tdV9m bGFncyhwMm10LCBtZm4pOworICAgIHVuc2lnbmVkIGludCBpb21tdV9wdGVf ZmxhZ3MgPSBwMm1fZ2V0X2lvbW11X2ZsYWdzKHAybXQsIHAybWEsIG1mbik7 CiAgICAgLyoKICAgICAgKiBvbGRfbWZuIGFuZCBpb21tdV9vbGRfZmxhZ3Mg Y29udHJvbCBwb3NzaWJsZSBmbHVzaC91cGRhdGUgbmVlZHMgb24gdGhlCiAg ICAgICogSU9NTVU6IFdlIG5lZWQgdG8gZmx1c2ggd2hlbiBNRk4gb3IgZmxh Z3MgKGkuZS4gcGVybWlzc2lvbnMpIGNoYW5nZS4KQEAgLTU1Niw2ICs1NjYs NyBAQCBwMm1fcHRfc2V0X2VudHJ5KHN0cnVjdCBwMm1fZG9tYWluICpwMm0s CiAgICAgICAgICAgICAgICAgb2xkX21mbiA9IGwxZV9nZXRfcGZuKCpwMm1f ZW50cnkpOwogICAgICAgICAgICAgICAgIGlvbW11X29sZF9mbGFncyA9CiAg ICAgICAgICAgICAgICAgICAgIHAybV9nZXRfaW9tbXVfZmxhZ3MocDJtX2Zs YWdzX3RvX3R5cGUoZmxhZ3MpLAorICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIHAybV9mbGFnc190b19hY2Nlc3MoZmxhZ3MpLAog ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIF9tZm4o b2xkX21mbikpOwogICAgICAgICAgICAgfQogICAgICAgICAgICAgZWxzZQpA QCAtNjAyLDkgKzYxMywxMCBAQCBwMm1fcHRfc2V0X2VudHJ5KHN0cnVjdCBw Mm1fZG9tYWluICpwMm0sCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIDAsIEwxX1BBR0VUQUJMRV9FTlRSSUVTKTsKICAgICAgICAgQVNT RVJUKHAybV9lbnRyeSk7CiAgICAgICAgIG9sZF9tZm4gPSBsMWVfZ2V0X3Bm bigqcDJtX2VudHJ5KTsKKyAgICAgICAgZmxhZ3MgPSBsMWVfZ2V0X2ZsYWdz KCpwMm1fZW50cnkpOwogICAgICAgICBpb21tdV9vbGRfZmxhZ3MgPQotICAg ICAgICAgICAgcDJtX2dldF9pb21tdV9mbGFncyhwMm1fZmxhZ3NfdG9fdHlw ZShsMWVfZ2V0X2ZsYWdzKCpwMm1fZW50cnkpKSwKLSAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgX21mbihvbGRfbWZuKSk7CisgICAgICAgICAg ICBwMm1fZ2V0X2lvbW11X2ZsYWdzKHAybV9mbGFnc190b190eXBlKGZsYWdz KSwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcDJtX2ZsYWdz X3RvX2FjY2VzcyhmbGFncyksIF9tZm4ob2xkX21mbikpOwogCiAgICAgICAg IGlmICggbWZuX3ZhbGlkKG1mbikgfHwgcDJtX2FsbG93c19pbnZhbGlkX21m bihwMm10KSApCiAgICAgICAgICAgICBlbnRyeV9jb250ZW50ID0gcDJtX2wx ZV9mcm9tX3BmbihtZm5feChtZm4pLApAQCAtNjQ4LDYgKzY2MCw3IEBAIHAy bV9wdF9zZXRfZW50cnkoc3RydWN0IHAybV9kb21haW4gKnAybSwKICAgICAg ICAgICAgICAgICBvbGRfbWZuID0gbDFlX2dldF9wZm4oKnAybV9lbnRyeSk7 CiAgICAgICAgICAgICAgICAgaW9tbXVfb2xkX2ZsYWdzID0KICAgICAgICAg ICAgICAgICAgICAgcDJtX2dldF9pb21tdV9mbGFncyhwMm1fZmxhZ3NfdG9f dHlwZShmbGFncyksCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgcDJtX2ZsYWdzX3RvX2FjY2VzcyhmbGFncyksCiAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgX21mbihvbGRfbWZu KSk7CiAgICAgICAgICAgICB9CiAgICAgICAgICAgICBlbHNlCi0tLSBhL3hl bi9pbmNsdWRlL2FzbS14ODYvcDJtLmgKKysrIGIveGVuL2luY2x1ZGUvYXNt LXg4Ni9wMm0uaApAQCAtODM5LDcgKzgzOSw4IEBAIGludCBwMm1fYWx0cDJt X3Byb3BhZ2F0ZV9jaGFuZ2Uoc3RydWN0IGQKIC8qCiAgKiBwMm0gdHlwZSB0 byBJT01NVSBmbGFncwogICovCi1zdGF0aWMgaW5saW5lIHVuc2lnbmVkIGlu dCBwMm1fZ2V0X2lvbW11X2ZsYWdzKHAybV90eXBlX3QgcDJtdCwgbWZuX3Qg bWZuKQorc3RhdGljIGlubGluZSB1bnNpZ25lZCBpbnQgcDJtX2dldF9pb21t dV9mbGFncyhwMm1fdHlwZV90IHAybXQsCisgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIHAybV9hY2Nlc3NfdCBwMm1h LCBtZm5fdCBtZm4pCiB7CiAgICAgdW5zaWduZWQgaW50IGZsYWdzOwogCg== --=separator Content-Type: application/octet-stream; name="xsa378/xsa378-4.11-4.patch" Content-Disposition: attachment; filename="xsa378/xsa378-4.11-4.patch" Content-Transfer-Encoding: base64 RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0 OiBJT01NVTogZ2VuZXJhbGl6ZSBWVC1kJ3MgdHJhY2tpbmcgb2YgbWFwcGVk IFJNUlIgcmVnaW9ucwoKSW4gb3JkZXIgdG8gcmUtdXNlIGl0IGVsc2V3aGVy ZSwgbW92ZSB0aGUgbG9naWMgdG8gdmVuZG9yIGluZGVwZW5kZW50CmNvZGUg YW5kIHN0cmlwIGl0IG9mIFJNUlIgc3BlY2lmaWNzLgoKTm90ZSB0aGF0IHRo ZSBwcmlvciAibWFwIiBwYXJhbWV0ZXIgZ2V0cyBmb2xkZWQgaW50byB0aGUg bmV3ICJwMm1hIiBvbmUKKHdoaWNoIEFNRCBJT01NVSBjb2RlIHdpbGwgd2Fu dCB0byBtYWtlIHVzZSBvZiksIGFzc2lnbmluZyBhbHRlcm5hdGl2ZQptZWFu aW5nICgidW5tYXAiKSB0byBwMm1fYWNjZXNzX3guIFByZXBhcmUgc2V0X2lk ZW50aXR5X3AybV9lbnRyeSgpIGFuZApwMm1fZ2V0X2lvbW11X2ZsYWdzKCkg Zm9yIGdldHRpbmcgcGFzc2VkIGFjY2VzcyB0eXBlcyBvdGhlciB0aGFuCnAy bV9hY2Nlc3NfcncgKGluIHRoZSBsYXR0ZXIgY2FzZSBqdXN0IGZvciBwMm1f bW1pb19kaXJlY3QgcmVxdWVzdHMpLgoKTm90ZSBhbHNvIHRoYXQsIHRvIGJl IG9uIHRoZSBzYWZlIHNpZGUsIGFuIG92ZXJsYXAgY2hlY2sgZ2V0cyBhZGRl ZCB0bwp0aGUgbWFpbiBsb29wIG9mIGlvbW11X2lkZW50aXR5X21hcHBpbmco KS4KClRoaXMgaXMgcGFydCBvZiBYU0EtMzc4LgoKU2lnbmVkLW9mZi1ieTog SmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpSZXZpZXdlZC1ieTog UGF1bCBEdXJyYW50IDxwYXVsQHhlbi5vcmc+CgotLS0gYS94ZW4vYXJjaC94 ODYvbW0vcDJtLmMKKysrIGIveGVuL2FyY2gveDg2L21tL3AybS5jCkBAIC0x MTU3LDcgKzExNTcsOCBAQCBpbnQgc2V0X2lkZW50aXR5X3AybV9lbnRyeShz dHJ1Y3QgZG9tYWluCiAgICAgewogICAgICAgICBpZiAoICFuZWVkX2lvbW11 KGQpICkKICAgICAgICAgICAgIHJldHVybiAwOwotICAgICAgICByZXR1cm4g aW9tbXVfbWFwX3BhZ2UoZCwgZ2ZuX2wsIGdmbl9sLCBJT01NVUZfcmVhZGFi bGV8SU9NTVVGX3dyaXRhYmxlKTsKKyAgICAgICAgcmV0dXJuIGlvbW11X21h cF9wYWdlKGQsIGdmbl9sLCBnZm5fbCwKKyAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIHAybV9hY2Nlc3NfdG9faW9tbXVfZmxhZ3MocDJtYSkpOwog ICAgIH0KIAogICAgIGdmbl9sb2NrKHAybSwgZ2ZuLCAwKTsKLS0tIGEveGVu L2RyaXZlcnMvcGFzc3Rocm91Z2gvdnRkL2lvbW11LmMKKysrIGIveGVuL2Ry aXZlcnMvcGFzc3Rocm91Z2gvdnRkL2lvbW11LmMKQEAgLTQyLDEyICs0Miw2 IEBACiAjaW5jbHVkZSAidnRkLmgiCiAjaW5jbHVkZSAiLi4vYXRzLmgiCiAK LXN0cnVjdCBtYXBwZWRfcm1yciB7Ci0gICAgc3RydWN0IGxpc3RfaGVhZCBs aXN0OwotICAgIHU2NCBiYXNlLCBlbmQ7Ci0gICAgdW5zaWduZWQgaW50IGNv dW50OwotfTsKLQogLyogUG9zc2libGUgdW5maWx0ZXJlZCBMQVBJQy9NU0kg bWVzc2FnZXMgZnJvbSB1bnRydXN0ZWQgc291cmNlcz8gKi8KIGJvb2wgX19y ZWFkX21vc3RseSB1bnRydXN0ZWRfbXNpOwogCkBAIC0xNzg1LDE2ICsxNzc5 LDExIEBAIG91dDoKIHN0YXRpYyB2b2lkIGlvbW11X2RvbWFpbl90ZWFyZG93 bihzdHJ1Y3QgZG9tYWluICpkKQogewogICAgIHN0cnVjdCBkb21haW5faW9t bXUgKmhkID0gZG9tX2lvbW11KGQpOwotICAgIHN0cnVjdCBtYXBwZWRfcm1y ciAqbXJtcnIsICp0bXA7CiAKICAgICBpZiAoIGxpc3RfZW1wdHkoJmFjcGlf ZHJoZF91bml0cykgKQogICAgICAgICByZXR1cm47CiAKLSAgICBsaXN0X2Zv cl9lYWNoX2VudHJ5X3NhZmUgKCBtcm1yciwgdG1wLCAmaGQtPmFyY2gubWFw cGVkX3JtcnJzLCBsaXN0ICkKLSAgICB7Ci0gICAgICAgIGxpc3RfZGVsKCZt cm1yci0+bGlzdCk7Ci0gICAgICAgIHhmcmVlKG1ybXJyKTsKLSAgICB9Cisg ICAgaW9tbXVfaWRlbnRpdHlfbWFwX3RlYXJkb3duKGQpOwogCiAgICAgaWYg KCBpb21tdV91c2VfaGFwX3B0KGQpICkKICAgICAgICAgcmV0dXJuOwpAQCAt MTkwMyw3NCArMTg5Miw2IEBAIHN0YXRpYyB2b2lkIGlvbW11X3NldF9wZ2Qo c3RydWN0IGRvbWFpbgogICAgICAgICBwYWdldGFibGVfZ2V0X3BhZGRyKHBh Z2V0YWJsZV9mcm9tX21mbihwZ2RfbWZuKSk7CiB9CiAKLXN0YXRpYyBpbnQg cm1ycl9pZGVudGl0eV9tYXBwaW5nKHN0cnVjdCBkb21haW4gKmQsIGJvb2xf dCBtYXAsCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjb25z dCBzdHJ1Y3QgYWNwaV9ybXJyX3VuaXQgKnJtcnIsCi0gICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICB1MzIgZmxhZykKLXsKLSAgICB1bnNpZ25l ZCBsb25nIGJhc2VfcGZuID0gcm1yci0+YmFzZV9hZGRyZXNzID4+IFBBR0Vf U0hJRlRfNEs7Ci0gICAgdW5zaWduZWQgbG9uZyBlbmRfcGZuID0gUEFHRV9B TElHTl80SyhybXJyLT5lbmRfYWRkcmVzcykgPj4gUEFHRV9TSElGVF80SzsK LSAgICBzdHJ1Y3QgbWFwcGVkX3JtcnIgKm1ybXJyOwotICAgIHN0cnVjdCBk b21haW5faW9tbXUgKmhkID0gZG9tX2lvbW11KGQpOwotCi0gICAgQVNTRVJU KHBjaWRldnNfbG9ja2VkKCkpOwotICAgIEFTU0VSVChybXJyLT5iYXNlX2Fk ZHJlc3MgPCBybXJyLT5lbmRfYWRkcmVzcyk7Ci0KLSAgICAvKgotICAgICAq IE5vIG5lZWQgdG8gYWNxdWlyZSBoZC0+YXJjaC5tYXBwaW5nX2xvY2s6IEJv dGggaW5zZXJ0aW9uIGFuZCByZW1vdmFsCi0gICAgICogZ2V0IGRvbmUgd2hp bGUgaG9sZGluZyBwY2lkZXZzX2xvY2suCi0gICAgICovCi0gICAgbGlzdF9m b3JfZWFjaF9lbnRyeSggbXJtcnIsICZoZC0+YXJjaC5tYXBwZWRfcm1ycnMs IGxpc3QgKQotICAgIHsKLSAgICAgICAgaWYgKCBtcm1yci0+YmFzZSA9PSBy bXJyLT5iYXNlX2FkZHJlc3MgJiYKLSAgICAgICAgICAgICBtcm1yci0+ZW5k ID09IHJtcnItPmVuZF9hZGRyZXNzICkKLSAgICAgICAgewotICAgICAgICAg ICAgaW50IHJldCA9IDA7Ci0KLSAgICAgICAgICAgIGlmICggbWFwICkKLSAg ICAgICAgICAgIHsKLSAgICAgICAgICAgICAgICArK21ybXJyLT5jb3VudDsK LSAgICAgICAgICAgICAgICByZXR1cm4gMDsKLSAgICAgICAgICAgIH0KLQot ICAgICAgICAgICAgaWYgKCAtLW1ybXJyLT5jb3VudCApCi0gICAgICAgICAg ICAgICAgcmV0dXJuIDA7Ci0KLSAgICAgICAgICAgIHdoaWxlICggYmFzZV9w Zm4gPCBlbmRfcGZuICkKLSAgICAgICAgICAgIHsKLSAgICAgICAgICAgICAg ICBpZiAoIGNsZWFyX2lkZW50aXR5X3AybV9lbnRyeShkLCBiYXNlX3Bmbikg KQotICAgICAgICAgICAgICAgICAgICByZXQgPSAtRU5YSU87Ci0gICAgICAg ICAgICAgICAgYmFzZV9wZm4rKzsKLSAgICAgICAgICAgIH0KLQotICAgICAg ICAgICAgbGlzdF9kZWwoJm1ybXJyLT5saXN0KTsKLSAgICAgICAgICAgIHhm cmVlKG1ybXJyKTsKLSAgICAgICAgICAgIHJldHVybiByZXQ7Ci0gICAgICAg IH0KLSAgICB9Ci0KLSAgICBpZiAoICFtYXAgKQotICAgICAgICByZXR1cm4g LUVOT0VOVDsKLQotICAgIHdoaWxlICggYmFzZV9wZm4gPCBlbmRfcGZuICkK LSAgICB7Ci0gICAgICAgIGludCBlcnIgPSBzZXRfaWRlbnRpdHlfcDJtX2Vu dHJ5KGQsIGJhc2VfcGZuLCBwMm1fYWNjZXNzX3J3LCBmbGFnKTsKLQotICAg ICAgICBpZiAoIGVyciApCi0gICAgICAgICAgICByZXR1cm4gZXJyOwotICAg ICAgICBiYXNlX3BmbisrOwotICAgIH0KLQotICAgIG1ybXJyID0geG1hbGxv YyhzdHJ1Y3QgbWFwcGVkX3JtcnIpOwotICAgIGlmICggIW1ybXJyICkKLSAg ICAgICAgcmV0dXJuIC1FTk9NRU07Ci0gICAgbXJtcnItPmJhc2UgPSBybXJy LT5iYXNlX2FkZHJlc3M7Ci0gICAgbXJtcnItPmVuZCA9IHJtcnItPmVuZF9h ZGRyZXNzOwotICAgIG1ybXJyLT5jb3VudCA9IDE7Ci0gICAgbGlzdF9hZGRf dGFpbCgmbXJtcnItPmxpc3QsICZoZC0+YXJjaC5tYXBwZWRfcm1ycnMpOwot Ci0gICAgcmV0dXJuIDA7Ci19Ci0KIHN0YXRpYyBpbnQgaW50ZWxfaW9tbXVf YWRkX2RldmljZSh1OCBkZXZmbiwgc3RydWN0IHBjaV9kZXYgKnBkZXYpCiB7 CiAgICAgc3RydWN0IGFjcGlfcm1ycl91bml0ICpybXJyOwpAQCAtMjAwMiw3 ICsxOTIzLDkgQEAgc3RhdGljIGludCBpbnRlbF9pb21tdV9hZGRfZGV2aWNl KHU4IGRldgogICAgICAgICAgICAgICogU2luY2UgUk1SUnMgYXJlIGFsd2F5 cyByZXNlcnZlZCBpbiB0aGUgZTgyMCBtYXAgZm9yIHRoZSBoYXJkd2FyZQog ICAgICAgICAgICAgICogZG9tYWluLCB0aGVyZSBzaG91bGRuJ3QgYmUgYSBj b25mbGljdC4KICAgICAgICAgICAgICAqLwotICAgICAgICAgICAgcmV0ID0g cm1ycl9pZGVudGl0eV9tYXBwaW5nKHBkZXYtPmRvbWFpbiwgMSwgcm1yciwg MCk7CisgICAgICAgICAgICByZXQgPSBpb21tdV9pZGVudGl0eV9tYXBwaW5n KHBkZXYtPmRvbWFpbiwgcDJtX2FjY2Vzc19ydywKKyAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgcm1yci0+YmFzZV9hZGRyZXNz LCBybXJyLT5lbmRfYWRkcmVzcywKKyAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgMCk7CiAgICAgICAgICAgICBpZiAoIHJldCAp CiAgICAgICAgICAgICAgICAgZHByaW50ayhYRU5MT0dfRVJSIFZURFBSRUZJ WCwgImQlZDogUk1SUiBtYXBwaW5nIGZhaWxlZFxuIiwKICAgICAgICAgICAg ICAgICAgICAgICAgIHBkZXYtPmRvbWFpbi0+ZG9tYWluX2lkKTsKQEAgLTIw NDcsNyArMTk3MCw4IEBAIHN0YXRpYyBpbnQgaW50ZWxfaW9tbXVfcmVtb3Zl X2RldmljZSh1OAogICAgICAgICAgKiBBbnkgZmxhZyBpcyBub3RoaW5nIHRv IGNsZWFyIHRoZXNlIG1hcHBpbmdzIGJ1dCBoZXJlCiAgICAgICAgICAqIGl0 cyBhbHdheXMgc2FmZSBhbmQgc3RyaWN0IHRvIHNldCAwLgogICAgICAgICAg Ki8KLSAgICAgICAgcm1ycl9pZGVudGl0eV9tYXBwaW5nKHBkZXYtPmRvbWFp biwgMCwgcm1yciwgMCk7CisgICAgICAgIGlvbW11X2lkZW50aXR5X21hcHBp bmcocGRldi0+ZG9tYWluLCBwMm1fYWNjZXNzX3gsIHJtcnItPmJhc2VfYWRk cmVzcywKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBybXJyLT5l bmRfYWRkcmVzcywgMCk7CiAgICAgfQogCiAgICAgcmV0dXJuIGRvbWFpbl9j b250ZXh0X3VubWFwKHBkZXYtPmRvbWFpbiwgZGV2Zm4sIHBkZXYpOwpAQCAt MjIxNCw3ICsyMTM4LDggQEAgc3RhdGljIHZvaWQgX19od2RvbV9pbml0IHNl dHVwX2h3ZG9tX3JtcgogICAgICAgICAgKiBkb21haW4sIHRoZXJlIHNob3Vs ZG4ndCBiZSBhIGNvbmZsaWN0LiBTbyBpdHMgYWx3YXlzIHNhZmUgYW5kCiAg ICAgICAgICAqIHN0cmljdCB0byBzZXQgMC4KICAgICAgICAgICovCi0gICAg ICAgIHJldCA9IHJtcnJfaWRlbnRpdHlfbWFwcGluZyhkLCAxLCBybXJyLCAw KTsKKyAgICAgICAgcmV0ID0gaW9tbXVfaWRlbnRpdHlfbWFwcGluZyhkLCBw Mm1fYWNjZXNzX3J3LCBybXJyLT5iYXNlX2FkZHJlc3MsCisgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgcm1yci0+ZW5kX2FkZHJlc3Ms IDApOwogICAgICAgICBpZiAoIHJldCApCiAgICAgICAgICAgICBkcHJpbnRr KFhFTkxPR19FUlIgVlREUFJFRklYLAogICAgICAgICAgICAgICAgICAgICAg IklPTU1VOiBtYXBwaW5nIHJlc2VydmVkIHJlZ2lvbiBmYWlsZWRcbiIpOwpA QCAtMjM3MSw3ICsyMjk2LDkgQEAgc3RhdGljIGludCByZWFzc2lnbl9kZXZp Y2Vfb3duZXJzaGlwKAogICAgICAgICAgICAgICAgICAqIEFueSBSTVJSIGZs YWcgaXMgYWx3YXlzIGlnbm9yZWQgd2hlbiByZW1vdmUgYSBkZXZpY2UsCiAg ICAgICAgICAgICAgICAgICogYnV0IGl0cyBhbHdheXMgc2FmZSBhbmQgc3Ry aWN0IHRvIHNldCAwLgogICAgICAgICAgICAgICAgICAqLwotICAgICAgICAg ICAgICAgIHJldCA9IHJtcnJfaWRlbnRpdHlfbWFwcGluZyhzb3VyY2UsIDAs IHJtcnIsIDApOworICAgICAgICAgICAgICAgIHJldCA9IGlvbW11X2lkZW50 aXR5X21hcHBpbmcoc291cmNlLCBwMm1fYWNjZXNzX3gsCisgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBybXJyLT5iYXNl X2FkZHJlc3MsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICBybXJyLT5lbmRfYWRkcmVzcywgMCk7CiAgICAgICAgICAg ICAgICAgaWYgKCByZXQgIT0gLUVOT0VOVCApCiAgICAgICAgICAgICAgICAg ICAgIHJldHVybiByZXQ7CiAgICAgICAgICAgICB9CkBAIC0yNDY4LDcgKzIz OTUsOCBAQCBzdGF0aWMgaW50IGludGVsX2lvbW11X2Fzc2lnbl9kZXZpY2Uo CiAgICAgICAgICAgICAgUENJX0JVUyhiZGYpID09IGJ1cyAmJgogICAgICAg ICAgICAgIFBDSV9ERVZGTjIoYmRmKSA9PSBkZXZmbiApCiAgICAgICAgIHsK LSAgICAgICAgICAgIHJldCA9IHJtcnJfaWRlbnRpdHlfbWFwcGluZyhkLCAx LCBybXJyLCBmbGFnKTsKKyAgICAgICAgICAgIHJldCA9IGlvbW11X2lkZW50 aXR5X21hcHBpbmcoZCwgcDJtX2FjY2Vzc19ydywgcm1yci0+YmFzZV9hZGRy ZXNzLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBybXJyLT5lbmRfYWRkcmVzcywgZmxhZyk7CiAgICAgICAgICAgICBpZiAo IHJldCApCiAgICAgICAgICAgICB7CiAgICAgICAgICAgICAgICAgaW50IHJj OwotLS0gYS94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC94ODYvaW9tbXUuYwor KysgYi94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC94ODYvaW9tbXUuYwpAQCAt MTQ0LDcgKzE0NCw3IEBAIGludCBhcmNoX2lvbW11X2RvbWFpbl9pbml0KHN0 cnVjdCBkb21haW4KICAgICBzdHJ1Y3QgZG9tYWluX2lvbW11ICpoZCA9IGRv bV9pb21tdShkKTsKIAogICAgIHNwaW5fbG9ja19pbml0KCZoZC0+YXJjaC5t YXBwaW5nX2xvY2spOwotICAgIElOSVRfTElTVF9IRUFEKCZoZC0+YXJjaC5t YXBwZWRfcm1ycnMpOworICAgIElOSVRfTElTVF9IRUFEKCZoZC0+YXJjaC5p ZGVudGl0eV9tYXBzKTsKIAogICAgIHJldHVybiAwOwogfQpAQCAtMTUzLDYg KzE1Myw5OSBAQCB2b2lkIGFyY2hfaW9tbXVfZG9tYWluX2Rlc3Ryb3koc3Ry dWN0IGRvCiB7CiB9CiAKK3N0cnVjdCBpZGVudGl0eV9tYXAgeworICAgIHN0 cnVjdCBsaXN0X2hlYWQgbGlzdDsKKyAgICBwYWRkcl90IGJhc2UsIGVuZDsK KyAgICBwMm1fYWNjZXNzX3QgYWNjZXNzOworICAgIHVuc2lnbmVkIGludCBj b3VudDsKK307CisKK2ludCBpb21tdV9pZGVudGl0eV9tYXBwaW5nKHN0cnVj dCBkb21haW4gKmQsIHAybV9hY2Nlc3NfdCBwMm1hLAorICAgICAgICAgICAg ICAgICAgICAgICAgICAgcGFkZHJfdCBiYXNlLCBwYWRkcl90IGVuZCwKKyAg ICAgICAgICAgICAgICAgICAgICAgICAgIHVuc2lnbmVkIGludCBmbGFnKQor eworICAgIHVuc2lnbmVkIGxvbmcgYmFzZV9wZm4gPSBiYXNlID4+IFBBR0Vf U0hJRlRfNEs7CisgICAgdW5zaWduZWQgbG9uZyBlbmRfcGZuID0gUEFHRV9B TElHTl80SyhlbmQpID4+IFBBR0VfU0hJRlRfNEs7CisgICAgc3RydWN0IGlk ZW50aXR5X21hcCAqbWFwOworICAgIHN0cnVjdCBkb21haW5faW9tbXUgKmhk ID0gZG9tX2lvbW11KGQpOworCisgICAgQVNTRVJUKHBjaWRldnNfbG9ja2Vk KCkpOworICAgIEFTU0VSVChiYXNlIDwgZW5kKTsKKworICAgIC8qCisgICAg ICogTm8gbmVlZCB0byBhY3F1aXJlIGhkLT5hcmNoLm1hcHBpbmdfbG9jazog Qm90aCBpbnNlcnRpb24gYW5kIHJlbW92YWwKKyAgICAgKiBnZXQgZG9uZSB3 aGlsZSBob2xkaW5nIHBjaWRldnNfbG9jay4KKyAgICAgKi8KKyAgICBsaXN0 X2Zvcl9lYWNoX2VudHJ5KCBtYXAsICZoZC0+YXJjaC5pZGVudGl0eV9tYXBz LCBsaXN0ICkKKyAgICB7CisgICAgICAgIGlmICggbWFwLT5iYXNlID09IGJh c2UgJiYgbWFwLT5lbmQgPT0gZW5kICkKKyAgICAgICAgeworICAgICAgICAg ICAgaW50IHJldCA9IDA7CisKKyAgICAgICAgICAgIGlmICggcDJtYSAhPSBw Mm1fYWNjZXNzX3ggKQorICAgICAgICAgICAgeworICAgICAgICAgICAgICAg IGlmICggbWFwLT5hY2Nlc3MgIT0gcDJtYSApCisgICAgICAgICAgICAgICAg ICAgIHJldHVybiAtRUFERFJJTlVTRTsKKyAgICAgICAgICAgICAgICArK21h cC0+Y291bnQ7CisgICAgICAgICAgICAgICAgcmV0dXJuIDA7CisgICAgICAg ICAgICB9CisKKyAgICAgICAgICAgIGlmICggLS1tYXAtPmNvdW50ICkKKyAg ICAgICAgICAgICAgICByZXR1cm4gMDsKKworICAgICAgICAgICAgd2hpbGUg KCBiYXNlX3BmbiA8IGVuZF9wZm4gKQorICAgICAgICAgICAgeworICAgICAg ICAgICAgICAgIGlmICggY2xlYXJfaWRlbnRpdHlfcDJtX2VudHJ5KGQsIGJh c2VfcGZuKSApCisgICAgICAgICAgICAgICAgICAgIHJldCA9IC1FTlhJTzsK KyAgICAgICAgICAgICAgICBiYXNlX3BmbisrOworICAgICAgICAgICAgfQor CisgICAgICAgICAgICBsaXN0X2RlbCgmbWFwLT5saXN0KTsKKyAgICAgICAg ICAgIHhmcmVlKG1hcCk7CisKKyAgICAgICAgICAgIHJldHVybiByZXQ7Cisg ICAgICAgIH0KKworICAgICAgICBpZiAoIGVuZCA+PSBtYXAtPmJhc2UgJiYg bWFwLT5lbmQgPj0gYmFzZSApCisgICAgICAgICAgICByZXR1cm4gLUVBRERS SU5VU0U7CisgICAgfQorCisgICAgaWYgKCBwMm1hID09IHAybV9hY2Nlc3Nf eCApCisgICAgICAgIHJldHVybiAtRU5PRU5UOworCisgICAgd2hpbGUgKCBi YXNlX3BmbiA8IGVuZF9wZm4gKQorICAgIHsKKyAgICAgICAgaW50IGVyciA9 IHNldF9pZGVudGl0eV9wMm1fZW50cnkoZCwgYmFzZV9wZm4sIHAybWEsIGZs YWcpOworCisgICAgICAgIGlmICggZXJyICkKKyAgICAgICAgICAgIHJldHVy biBlcnI7CisgICAgICAgIGJhc2VfcGZuKys7CisgICAgfQorCisgICAgbWFw ID0geG1hbGxvYyhzdHJ1Y3QgaWRlbnRpdHlfbWFwKTsKKyAgICBpZiAoICFt YXAgKQorICAgICAgICByZXR1cm4gLUVOT01FTTsKKyAgICBtYXAtPmJhc2Ug PSBiYXNlOworICAgIG1hcC0+ZW5kID0gZW5kOworICAgIG1hcC0+YWNjZXNz ID0gcDJtYTsKKyAgICBtYXAtPmNvdW50ID0gMTsKKyAgICBsaXN0X2FkZF90 YWlsKCZtYXAtPmxpc3QsICZoZC0+YXJjaC5pZGVudGl0eV9tYXBzKTsKKwor ICAgIHJldHVybiAwOworfQorCit2b2lkIGlvbW11X2lkZW50aXR5X21hcF90 ZWFyZG93bihzdHJ1Y3QgZG9tYWluICpkKQoreworICAgIHN0cnVjdCBkb21h aW5faW9tbXUgKmhkID0gZG9tX2lvbW11KGQpOworICAgIHN0cnVjdCBpZGVu dGl0eV9tYXAgKm1hcCwgKnRtcDsKKworICAgIGxpc3RfZm9yX2VhY2hfZW50 cnlfc2FmZSAoIG1hcCwgdG1wLCAmaGQtPmFyY2guaWRlbnRpdHlfbWFwcywg bGlzdCApCisgICAgeworICAgICAgICBsaXN0X2RlbCgmbWFwLT5saXN0KTsK KyAgICAgICAgeGZyZWUobWFwKTsKKyAgICB9Cit9CisKIC8qCiAgKiBMb2Nh bCB2YXJpYWJsZXM6CiAgKiBtb2RlOiBDCi0tLSBhL3hlbi9pbmNsdWRlL2Fz bS14ODYvaW9tbXUuaAorKysgYi94ZW4vaW5jbHVkZS9hc20teDg2L2lvbW11 LmgKQEAgLTE2LDYgKzE2LDcgQEAKIAogI2luY2x1ZGUgPHhlbi9lcnJuby5o PgogI2luY2x1ZGUgPHhlbi9saXN0Lmg+CisjaW5jbHVkZSA8eGVuL21lbV9h Y2Nlc3MuaD4KICNpbmNsdWRlIDx4ZW4vc3BpbmxvY2suaD4KICNpbmNsdWRl IDxhc20vcHJvY2Vzc29yLmg+CiAjaW5jbHVkZSA8YXNtL2h2bS92bXgvdm1j cy5oPgpAQCAtMzYsNyArMzcsNyBAQCBzdHJ1Y3QgYXJjaF9pb21tdQogICAg IHNwaW5sb2NrX3QgbWFwcGluZ19sb2NrOyAgICAgICAgICAgIC8qIGlvIHBh Z2UgdGFibGUgbG9jayAqLwogICAgIGludCBhZ2F3OyAgICAgLyogYWRqdXN0 ZWQgZ3Vlc3QgYWRkcmVzcyB3aWR0aCwgMCBpcyBsZXZlbCAyIDMwLWJpdCAq LwogICAgIHU2NCBpb21tdV9iaXRtYXA7ICAgICAgICAgICAgICAvKiBiaXRt YXAgb2YgaW9tbXUocykgdGhhdCB0aGUgZG9tYWluIHVzZXMgKi8KLSAgICBz dHJ1Y3QgbGlzdF9oZWFkIG1hcHBlZF9ybXJyczsKKyAgICBzdHJ1Y3QgbGlz dF9oZWFkIGlkZW50aXR5X21hcHM7CiAKICAgICAvKiBhbWQgaW9tbXUgc3Vw cG9ydCAqLwogICAgIGludCBwYWdpbmdfbW9kZTsKQEAgLTk0LDYgKzk1LDEx IEBAIGJvb2xfdCBpb21tdV9zdXBwb3J0c19laW0odm9pZCk7CiBpbnQgaW9t bXVfZW5hYmxlX3gyYXBpY19JUih2b2lkKTsKIHZvaWQgaW9tbXVfZGlzYWJs ZV94MmFwaWNfSVIodm9pZCk7CiAKK2ludCBpb21tdV9pZGVudGl0eV9tYXBw aW5nKHN0cnVjdCBkb21haW4gKmQsIHAybV9hY2Nlc3NfdCBwMm1hLAorICAg ICAgICAgICAgICAgICAgICAgICAgICAgcGFkZHJfdCBiYXNlLCBwYWRkcl90 IGVuZCwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgIHVuc2lnbmVkIGlu dCBmbGFnKTsKK3ZvaWQgaW9tbXVfaWRlbnRpdHlfbWFwX3RlYXJkb3duKHN0 cnVjdCBkb21haW4gKmQpOworCiBleHRlcm4gYm9vbCB1bnRydXN0ZWRfbXNp OwogCiBpbnQgcGlfdXBkYXRlX2lydGUoY29uc3Qgc3RydWN0IHBpX2Rlc2Mg KnBpX2Rlc2MsIGNvbnN0IHN0cnVjdCBwaXJxICpwaXJxLAotLS0gYS94ZW4v aW5jbHVkZS9hc20teDg2L21lbV9hY2Nlc3MuaAorKysgYi94ZW4vaW5jbHVk ZS9hc20teDg2L21lbV9hY2Nlc3MuaApAQCAtNDQsMTAgKzQ0LDggQEAgYm9v bCBwMm1fbWVtX2FjY2Vzc19lbXVsYXRlX2NoZWNrKHN0cnVjdAogICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNvbnN0IHZtX2V2ZW50X3Jl c3BvbnNlX3QgKnJzcCk7CiAKIC8qIFNhbml0eSBjaGVjayBmb3IgbWVtX2Fj Y2VzcyBoYXJkd2FyZSBzdXBwb3J0ICovCi1zdGF0aWMgaW5saW5lIGJvb2wg cDJtX21lbV9hY2Nlc3Nfc2FuaXR5X2NoZWNrKHN0cnVjdCBkb21haW4gKmQp Ci17Ci0gICAgcmV0dXJuIGlzX2h2bV9kb21haW4oZCkgJiYgY3B1X2hhc192 bXggJiYgaGFwX2VuYWJsZWQoZCk7Ci19CisjZGVmaW5lIHAybV9tZW1fYWNj ZXNzX3Nhbml0eV9jaGVjayhkKSBcCisgICAgKGlzX2h2bV9kb21haW4oZCkg JiYgY3B1X2hhc192bXggJiYgaGFwX2VuYWJsZWQoZCkpCiAKICNlbmRpZiAv Kl9fQVNNX1g4Nl9NRU1fQUNDRVNTX0hfXyAqLwogCi0tLSBhL3hlbi9pbmNs dWRlL2FzbS14ODYvcDJtLmgKKysrIGIveGVuL2luY2x1ZGUvYXNtLXg4Ni9w Mm0uaApAQCAtODM2LDYgKzgzNiwzNCBAQCBpbnQgcDJtX2FsdHAybV9wcm9w YWdhdGVfY2hhbmdlKHN0cnVjdCBkCiAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIG1mbl90IG1mbiwgdW5zaWduZWQgaW50IHBhZ2Vfb3JkZXIs CiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHAybV90eXBlX3Qg cDJtdCwgcDJtX2FjY2Vzc190IHAybWEpOwogCisvKiBwMm0gYWNjZXNzIHRv IElPTU1VIGZsYWdzICovCitzdGF0aWMgaW5saW5lIHVuc2lnbmVkIGludCBw Mm1fYWNjZXNzX3RvX2lvbW11X2ZsYWdzKHAybV9hY2Nlc3NfdCBwMm1hKQor eworICAgIHN3aXRjaCAoIHAybWEgKQorICAgIHsKKyAgICBjYXNlIHAybV9h Y2Nlc3Nfcnc6CisgICAgY2FzZSBwMm1fYWNjZXNzX3J3eDoKKyAgICAgICAg cmV0dXJuIElPTU1VRl9yZWFkYWJsZSB8IElPTU1VRl93cml0YWJsZTsKKwor ICAgIGNhc2UgcDJtX2FjY2Vzc19yOgorICAgIGNhc2UgcDJtX2FjY2Vzc19y eDoKKyAgICBjYXNlIHAybV9hY2Nlc3Nfcngycnc6CisgICAgICAgIHJldHVy biBJT01NVUZfcmVhZGFibGU7CisKKyAgICBjYXNlIHAybV9hY2Nlc3NfdzoK KyAgICBjYXNlIHAybV9hY2Nlc3Nfd3g6CisgICAgICAgIHJldHVybiBJT01N VUZfd3JpdGFibGU7CisKKyAgICBjYXNlIHAybV9hY2Nlc3NfbjoKKyAgICBj YXNlIHAybV9hY2Nlc3NfeDoKKyAgICBjYXNlIHAybV9hY2Nlc3NfbjJyd3g6 CisgICAgICAgIHJldHVybiAwOworICAgIH0KKworICAgIEFTU0VSVF9VTlJF QUNIQUJMRSgpOworICAgIHJldHVybiAwOworfQorCiAvKgogICogcDJtIHR5 cGUgdG8gSU9NTVUgZmxhZ3MKICAqLwpAQCAtODU3LDkgKzg4NSwxMCBAQCBz dGF0aWMgaW5saW5lIHVuc2lnbmVkIGludCBwMm1fZ2V0X2lvbW11CiAgICAg ICAgIGZsYWdzID0gSU9NTVVGX3JlYWRhYmxlOwogICAgICAgICBicmVhazsK ICAgICBjYXNlIHAybV9tbWlvX2RpcmVjdDoKLSAgICAgICAgZmxhZ3MgPSBJ T01NVUZfcmVhZGFibGU7Ci0gICAgICAgIGlmICggIXJhbmdlc2V0X2NvbnRh aW5zX3NpbmdsZXRvbihtbWlvX3JvX3JhbmdlcywgbWZuX3gobWZuKSkgKQot ICAgICAgICAgICAgZmxhZ3MgfD0gSU9NTVVGX3dyaXRhYmxlOworICAgICAg ICBmbGFncyA9IHAybV9hY2Nlc3NfdG9faW9tbXVfZmxhZ3MocDJtYSk7Cisg ICAgICAgIGlmICggKGZsYWdzICYgSU9NTVVGX3dyaXRhYmxlKSAmJgorICAg ICAgICAgICAgIHJhbmdlc2V0X2NvbnRhaW5zX3NpbmdsZXRvbihtbWlvX3Jv X3JhbmdlcywgbWZuX3gobWZuKSkgKQorICAgICAgICAgICAgZmxhZ3MgJj0g fklPTU1VRl93cml0YWJsZTsKICAgICAgICAgYnJlYWs7CiAgICAgZGVmYXVs dDoKICAgICAgICAgZmxhZ3MgPSAwOwo= --=separator Content-Type: application/octet-stream; name="xsa378/xsa378-4.11-5.patch" Content-Disposition: attachment; filename="xsa378/xsa378-4.11-5.patch" Content-Transfer-Encoding: base64 RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0 OiBBTUQvSU9NTVU6IHJlLWFycmFuZ2UvY29tcGxldGUgcmUtYXNzaWdubWVu dCBoYW5kbGluZwoKUHJpb3IgdG8gdGhlIGFzc2lnbm1lbnQgc3RlcCBoYXZp bmcgY29tcGxldGVkIHN1Y2Nlc3NmdWxseSwgZGV2aWNlcwpzaG91bGQgbm90 IGdldCBhc3NvY2lhdGVkIHdpdGggdGhlaXIgbmV3IG93bmVyLiBIYW5kIHRo ZSBkZXZpY2UgdG8gRG9tSU8KKHBlcmhhcHMgdGVtcG9yYXJpbHkpLCB1bnRp bCBhZnRlciB0aGUgZGUtYXNzaWdubWVudCBzdGVwIGhhcyBjb21wbGV0ZWQu CgpEZS1hc3NpZ25tZW50IG9mIGEgZGV2aWNlIChmcm9tIG90aGVyIHRoYW4g RG9tMCkgYXMgd2VsbCBhcyBmYWlsdXJlIG9mCnJlYXNzaWduX2RldmljZSgp IGR1cmluZyBhc3NpZ25tZW50IHNob3VsZCByZXN1bHQgaW4gdW5pdHkgbWFw cGluZ3MKZ2V0dGluZyB0b3JuIGRvd24uIFRoaXMgaW4gdHVybiByZXF1aXJl cyBzd2l0Y2hpbmcgdG8gYSByZWZjb3VudGVkCm1hcHBpbmcgYXBwcm9hY2gs IGFzIHdhcyBhbHJlYWR5IHVzZWQgYnkgVlQtZCBmb3IgaXRzIFJNUlJzLCB0 byBwcmV2ZW50CnVubWFwcGluZyBhIHJlZ2lvbiB1c2VkIGJ5IG11bHRpcGxl IGRldmljZXMuCgpUaGlzIGlzIENWRS0yMDIxLTI4Njk2IC8gcGFydCBvZiBY U0EtMzc4LgoKU2lnbmVkLW9mZi1ieTogSmFuIEJldWxpY2ggPGpiZXVsaWNo QHN1c2UuY29tPgpSZXZpZXdlZC1ieTogUGF1bCBEdXJyYW50IDxwYXVsQHhl bi5vcmc+CgotLS0gYS94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC9hbWQvaW9t bXVfbWFwLmMKKysrIGIveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvYW1kL2lv bW11X21hcC5jCkBAIC03MTYsMjcgKzcxNiw0OSBAQCBpbnQgYW1kX2lvbW11 X3VubWFwX3BhZ2Uoc3RydWN0IGRvbWFpbiAqCiAgICAgcmV0dXJuIDA7CiB9 CiAKLWludCBhbWRfaW9tbXVfcmVzZXJ2ZV9kb21haW5fdW5pdHlfbWFwKHN0 cnVjdCBkb21haW4gKmRvbWFpbiwKLSAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIHU2NCBwaHlzX2FkZHIsCi0gICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICB1bnNpZ25lZCBsb25nIHNpemUs IGludCBpdywgaW50IGlyKQoraW50IGFtZF9pb21tdV9yZXNlcnZlX2RvbWFp bl91bml0eV9tYXAoc3RydWN0IGRvbWFpbiAqZCwKKyAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIGNvbnN0IHN0cnVjdCBpdnJzX3Vu aXR5X21hcCAqbWFwLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgdW5zaWduZWQgaW50IGZsYWcpCiB7Ci0gICAgdW5zaWduZWQg bG9uZyBucGFnZXMsIGk7Ci0gICAgdW5zaWduZWQgbG9uZyBnZm47Ci0gICAg dW5zaWduZWQgaW50IGZsYWdzID0gISFpcjsKLSAgICBpbnQgcnQgPSAwOwot Ci0gICAgaWYgKCBpdyApCi0gICAgICAgIGZsYWdzIHw9IElPTU1VRl93cml0 YWJsZTsKLQotICAgIG5wYWdlcyA9IHJlZ2lvbl90b19wYWdlcyhwaHlzX2Fk ZHIsIHNpemUpOwotICAgIGdmbiA9IHBoeXNfYWRkciA+PiBQQUdFX1NISUZU OwotICAgIGZvciAoIGkgPSAwOyBpIDwgbnBhZ2VzOyBpKysgKQorICAgIGlu dCByYzsKKworICAgIGlmICggZCA9PSBkb21faW8gKQorICAgICAgICByZXR1 cm4gMDsKKworICAgIGZvciAoIHJjID0gMDsgIXJjICYmIG1hcDsgbWFwID0g bWFwLT5uZXh0ICkKICAgICB7Ci0gICAgICAgIHJ0ID0gYW1kX2lvbW11X21h cF9wYWdlKGRvbWFpbiwgZ2ZuICtpLCBnZm4gK2ksIGZsYWdzKTsKLSAgICAg ICAgaWYgKCBydCAhPSAwICkKLSAgICAgICAgICAgIHJldHVybiBydDsKKyAg ICAgICAgcDJtX2FjY2Vzc190IHAybWEgPSBwMm1fYWNjZXNzX247CisKKyAg ICAgICAgaWYgKCBtYXAtPnJlYWQgKQorICAgICAgICAgICAgcDJtYSB8PSBw Mm1fYWNjZXNzX3I7CisgICAgICAgIGlmICggbWFwLT53cml0ZSApCisgICAg ICAgICAgICBwMm1hIHw9IHAybV9hY2Nlc3NfdzsKKworICAgICAgICByYyA9 IGlvbW11X2lkZW50aXR5X21hcHBpbmcoZCwgcDJtYSwgbWFwLT5hZGRyLAor ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgbWFwLT5hZGRy ICsgbWFwLT5sZW5ndGggLSAxLCBmbGFnKTsKICAgICB9Ci0gICAgcmV0dXJu IDA7CisKKyAgICByZXR1cm4gcmM7Cit9CisKK2ludCBhbWRfaW9tbXVfcmVz ZXJ2ZV9kb21haW5fdW5pdHlfdW5tYXAoc3RydWN0IGRvbWFpbiAqZCwKKyAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgY29uc3Qg c3RydWN0IGl2cnNfdW5pdHlfbWFwICptYXApCit7CisgICAgaW50IHJjOwor CisgICAgaWYgKCBkID09IGRvbV9pbyApCisgICAgICAgIHJldHVybiAwOwor CisgICAgZm9yICggcmMgPSAwOyBtYXA7IG1hcCA9IG1hcC0+bmV4dCApCisg ICAgeworICAgICAgICBpbnQgcmV0ID0gaW9tbXVfaWRlbnRpdHlfbWFwcGlu ZyhkLCBwMm1fYWNjZXNzX3gsIG1hcC0+YWRkciwKKyAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgbWFwLT5hZGRyICsgbWFwLT5s ZW5ndGggLSAxLCAwKTsKKworICAgICAgICBpZiAoIHJldCAmJiByZXQgIT0g LUVOT0VOVCAmJiAhcmMgKQorICAgICAgICAgICAgcmMgPSByZXQ7CisgICAg fQorCisgICAgcmV0dXJuIHJjOwogfQogCiAvKiBTaGFyZSBwMm0gdGFibGUg d2l0aCBpb21tdS4gKi8KLS0tIGEveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gv YW1kL3BjaV9hbWRfaW9tbXUuYworKysgYi94ZW4vZHJpdmVycy9wYXNzdGhy b3VnaC9hbWQvcGNpX2FtZF9pb21tdS5jCkBAIC0zMzMsNiArMzMzLDcgQEAg c3RhdGljIGludCByZWFzc2lnbl9kZXZpY2Uoc3RydWN0IGRvbWFpbgogICAg IHN0cnVjdCBhbWRfaW9tbXUgKmlvbW11OwogICAgIGludCBiZGYsIHJjOwog ICAgIHN0cnVjdCBkb21haW5faW9tbXUgKnQgPSBkb21faW9tbXUodGFyZ2V0 KTsKKyAgICBjb25zdCBzdHJ1Y3QgaXZyc19tYXBwaW5ncyAqaXZyc19tYXBw aW5ncyA9IGdldF9pdnJzX21hcHBpbmdzKHBkZXYtPnNlZyk7CiAKICAgICBi ZGYgPSBQQ0lfQkRGMihwZGV2LT5idXMsIHBkZXYtPmRldmZuKTsKICAgICBp b21tdSA9IGZpbmRfaW9tbXVfZm9yX2RldmljZShwZGV2LT5zZWcsIGJkZik7 CkBAIC0zNDcsMTAgKzM0OCwyNCBAQCBzdGF0aWMgaW50IHJlYXNzaWduX2Rl dmljZShzdHJ1Y3QgZG9tYWluCiAKICAgICBhbWRfaW9tbXVfZGlzYWJsZV9k b21haW5fZGV2aWNlKHNvdXJjZSwgaW9tbXUsIGRldmZuLCBwZGV2KTsKIAot ICAgIGlmICggZGV2Zm4gPT0gcGRldi0+ZGV2Zm4gKQorICAgIC8qCisgICAg ICogSWYgdGhlIGRldmljZSBiZWxvbmdzIHRvIHRoZSBoYXJkd2FyZSBkb21h aW4sIGFuZCBpdCBoYXMgYSB1bml0eSBtYXBwaW5nLAorICAgICAqIGRvbid0 IHJlbW92ZSBpdCBmcm9tIHRoZSBoYXJkd2FyZSBkb21haW4sIGJlY2F1c2Ug QklPUyBtYXkgcmVmZXJlbmNlIHRoYXQKKyAgICAgKiBtYXBwaW5nLgorICAg ICAqLworICAgIGlmICggIWlzX2hhcmR3YXJlX2RvbWFpbihzb3VyY2UpICkK KyAgICB7CisgICAgICAgIHJjID0gYW1kX2lvbW11X3Jlc2VydmVfZG9tYWlu X3VuaXR5X3VubWFwKAorICAgICAgICAgICAgICAgICBzb3VyY2UsCisgICAg ICAgICAgICAgICAgIGl2cnNfbWFwcGluZ3NbZ2V0X2RtYV9yZXF1ZXN0b3Jf aWQocGRldi0+c2VnLCBiZGYpXS51bml0eV9tYXApOworICAgICAgICBpZiAo IHJjICkKKyAgICAgICAgICAgIHJldHVybiByYzsKKyAgICB9CisKKyAgICBp ZiAoIGRldmZuID09IHBkZXYtPmRldmZuICYmIHBkZXYtPmRvbWFpbiAhPSBk b21faW8gKQogICAgIHsKLSAgICAgICAgbGlzdF9tb3ZlKCZwZGV2LT5kb21h aW5fbGlzdCwgJnRhcmdldC0+YXJjaC5wZGV2X2xpc3QpOwotICAgICAgICBw ZGV2LT5kb21haW4gPSB0YXJnZXQ7CisgICAgICAgIGxpc3RfbW92ZSgmcGRl di0+ZG9tYWluX2xpc3QsICZkb21faW8tPmFyY2gucGRldl9saXN0KTsKKyAg ICAgICAgcGRldi0+ZG9tYWluID0gZG9tX2lvOwogICAgIH0KIAogICAgIHJj ID0gYWxsb2NhdGVfZG9tYWluX3Jlc291cmNlcyh0KTsKQEAgLTM2Miw2ICsz NzcsMTIgQEAgc3RhdGljIGludCByZWFzc2lnbl9kZXZpY2Uoc3RydWN0IGRv bWFpbgogICAgICAgICAgICAgICAgICAgICBwZGV2LT5zZWcsIHBkZXYtPmJ1 cywgUENJX1NMT1QoZGV2Zm4pLCBQQ0lfRlVOQyhkZXZmbiksCiAgICAgICAg ICAgICAgICAgICAgIHNvdXJjZS0+ZG9tYWluX2lkLCB0YXJnZXQtPmRvbWFp bl9pZCk7CiAKKyAgICBpZiAoIGRldmZuID09IHBkZXYtPmRldmZuICYmIHBk ZXYtPmRvbWFpbiAhPSB0YXJnZXQgKQorICAgIHsKKyAgICAgICAgbGlzdF9t b3ZlKCZwZGV2LT5kb21haW5fbGlzdCwgJnRhcmdldC0+YXJjaC5wZGV2X2xp c3QpOworICAgICAgICBwZGV2LT5kb21haW4gPSB0YXJnZXQ7CisgICAgfQor CiAgICAgcmV0dXJuIDA7CiB9CiAKQEAgLTM3MiwyMCArMzkzLDI4IEBAIHN0 YXRpYyBpbnQgYW1kX2lvbW11X2Fzc2lnbl9kZXZpY2Uoc3RydWMKICAgICBz dHJ1Y3QgaXZyc19tYXBwaW5ncyAqaXZyc19tYXBwaW5ncyA9IGdldF9pdnJz X21hcHBpbmdzKHBkZXYtPnNlZyk7CiAgICAgaW50IGJkZiA9IFBDSV9CREYy KHBkZXYtPmJ1cywgZGV2Zm4pOwogICAgIGludCByZXFfaWQgPSBnZXRfZG1h X3JlcXVlc3Rvcl9pZChwZGV2LT5zZWcsIGJkZik7Ci0gICAgY29uc3Qgc3Ry dWN0IGl2cnNfdW5pdHlfbWFwICp1bml0eV9tYXA7CisgICAgaW50IHJjID0g YW1kX2lvbW11X3Jlc2VydmVfZG9tYWluX3VuaXR5X21hcCgKKyAgICAgICAg ICAgICAgICAgZCwgaXZyc19tYXBwaW5nc1tyZXFfaWRdLnVuaXR5X21hcCwg ZmxhZyk7CisKKyAgICBpZiAoICFyYyApCisgICAgICAgIHJjID0gcmVhc3Np Z25fZGV2aWNlKHBkZXYtPmRvbWFpbiwgZCwgZGV2Zm4sIHBkZXYpOwogCi0g ICAgZm9yICggdW5pdHlfbWFwID0gaXZyc19tYXBwaW5nc1tyZXFfaWRdLnVu aXR5X21hcDsgdW5pdHlfbWFwOwotICAgICAgICAgIHVuaXR5X21hcCA9IHVu aXR5X21hcC0+bmV4dCApCisgICAgaWYgKCByYyAmJiAhaXNfaGFyZHdhcmVf ZG9tYWluKGQpICkKICAgICB7Ci0gICAgICAgIGludCByYyA9IGFtZF9pb21t dV9yZXNlcnZlX2RvbWFpbl91bml0eV9tYXAoCi0gICAgICAgICAgICAgICAg ICAgICBkLCB1bml0eV9tYXAtPmFkZHIsIHVuaXR5X21hcC0+bGVuZ3RoLAot ICAgICAgICAgICAgICAgICAgICAgdW5pdHlfbWFwLT53cml0ZSwgdW5pdHlf bWFwLT5yZWFkKTsKKyAgICAgICAgaW50IHJldCA9IGFtZF9pb21tdV9yZXNl cnZlX2RvbWFpbl91bml0eV91bm1hcCgKKyAgICAgICAgICAgICAgICAgICAg ICBkLCBpdnJzX21hcHBpbmdzW3JlcV9pZF0udW5pdHlfbWFwKTsKIAotICAg ICAgICBpZiAoIHJjICkKLSAgICAgICAgICAgIHJldHVybiByYzsKKyAgICAg ICAgaWYgKCByZXQgKQorICAgICAgICB7CisgICAgICAgICAgICBwcmludGso WEVOTE9HX0VSUiAiQU1ELVZpOiAiCisgICAgICAgICAgICAgICAgICAgInVu aXR5LXVubWFwIGZvciBkJWQvJTA0eDolMDJ4OiUwMnguJXUgZmFpbGVkICgl ZClcbiIsCisgICAgICAgICAgICAgICAgICAgZC0+ZG9tYWluX2lkLCBwZGV2 LT5zZWcsIHBkZXYtPmJ1cywKKyAgICAgICAgICAgICAgICAgICBQQ0lfU0xP VChkZXZmbiksIFBDSV9GVU5DKGRldmZuKSwgcmV0KTsKKyAgICAgICAgICAg IGRvbWFpbl9jcmFzaChkKTsKKyAgICAgICAgfQogICAgIH0KIAotICAgIHJl dHVybiByZWFzc2lnbl9kZXZpY2UocGRldi0+ZG9tYWluLCBkLCBkZXZmbiwg cGRldik7CisgICAgcmV0dXJuIHJjOwogfQogCiBzdGF0aWMgdm9pZCBkZWFs bG9jYXRlX25leHRfcGFnZV90YWJsZShzdHJ1Y3QgcGFnZV9pbmZvICpwZywg aW50IGxldmVsKQpAQCAtNDUxLDYgKzQ4MCw3IEBAIHN0YXRpYyB2b2lkIGRl YWxsb2NhdGVfaW9tbXVfcGFnZV90YWJsZXMKIAogc3RhdGljIHZvaWQgYW1k X2lvbW11X2RvbWFpbl9kZXN0cm95KHN0cnVjdCBkb21haW4gKmQpCiB7Cisg ICAgaW9tbXVfaWRlbnRpdHlfbWFwX3RlYXJkb3duKGQpOwogICAgIGRlYWxs b2NhdGVfaW9tbXVfcGFnZV90YWJsZXMoZCk7CiAgICAgYW1kX2lvbW11X2Zs dXNoX2FsbF9wYWdlcyhkKTsKIH0KLS0tIGEveGVuL2luY2x1ZGUvYXNtLXg4 Ni9odm0vc3ZtL2FtZC1pb21tdS1wcm90by5oCisrKyBiL3hlbi9pbmNsdWRl L2FzbS14ODYvaHZtL3N2bS9hbWQtaW9tbXUtcHJvdG8uaApAQCAtNjAsOCAr NjAsMTAgQEAgaW50IF9fbXVzdF9jaGVjayBhbWRfaW9tbXVfdW5tYXBfcGFn ZShzdAogdTY0IGFtZF9pb21tdV9nZXRfbmV4dF90YWJsZV9mcm9tX3B0ZSh1 MzIgKmVudHJ5KTsKIGludCBfX211c3RfY2hlY2sgYW1kX2lvbW11X2FsbG9j X3Jvb3Qoc3RydWN0IGRvbWFpbl9pb21tdSAqaGQpOwogaW50IGFtZF9pb21t dV9yZXNlcnZlX2RvbWFpbl91bml0eV9tYXAoc3RydWN0IGRvbWFpbiAqZG9t YWluLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg dTY0IHBoeXNfYWRkciwgdW5zaWduZWQgbG9uZyBzaXplLAotICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgaW50IGl3LCBpbnQgaXIp OworICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgY29u c3Qgc3RydWN0IGl2cnNfdW5pdHlfbWFwICptYXAsCisgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICB1bnNpZ25lZCBpbnQgZmxhZyk7 CitpbnQgYW1kX2lvbW11X3Jlc2VydmVfZG9tYWluX3VuaXR5X3VubWFwKHN0 cnVjdCBkb21haW4gKmQsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIGNvbnN0IHN0cnVjdCBpdnJzX3VuaXR5X21hcCAqbWFw KTsKIAogLyogU2hhcmUgcDJtIHRhYmxlIHdpdGggaW9tbXUgKi8KIHZvaWQg YW1kX2lvbW11X3NoYXJlX3AybShzdHJ1Y3QgZG9tYWluICpkKTsK --=separator Content-Type: application/octet-stream; name="xsa378/xsa378-4.11-6.patch" Content-Disposition: attachment; filename="xsa378/xsa378-4.11-6.patch" Content-Transfer-Encoding: base64 RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0 OiBBTUQvSU9NTVU6IHJlLWFycmFuZ2UgZXhjbHVzaW9uIHJhbmdlIGFuZCB1 bml0eSBtYXAgcmVjb3JkaW5nCgpUaGUgc3BlYyBtYWtlcyBubyBwcm92aXNp b25zIGZvciBPUyBiZWhhdmlvciBoZXJlIHRvIGRlcGVuZCBvbiB0aGUKYW1v dW50IG9mIFJBTSBmb3VuZCBvbiB0aGUgc3lzdGVtLiBXaGlsZSB0aGUgc3Bl YyBtYXkgbm90IHN1ZmZpY2llbnRseQpjbGVhcmx5IGRpc3Rpbmd1aXNoIGJv dGgga2luZHMgb2YgcmVnaW9ucywgdGhleSBhcmUgc3VyZWx5IG1lYW50IHRv IGJlCnNlcGFyYXRlIHRoaW5nczogT25seSByZWdpb25zIHdpdGggQUNQSV9J Vk1EX0VYQ0xVU0lPTl9SQU5HRSBzZXQgc2hvdWxkCmJlIGNhbmRpZGF0ZXMg Zm9yIHB1dHRpbmcgaW4gdGhlIGV4Y2x1c2lvbiByYW5nZSByZWdpc3RlcnMu IChBcyB0aGVyZSdzCm9ubHkgYSBzaW5nbGUgc3VjaCBwYWlyIG9mIHJlZ2lz dGVycyBwZXIgSU9NTVUsIHNlY29uZGFyeSBub24tYWRqYWNlbnQKcmVnaW9u cyB3aXRoIHRoZSBmbGFnIHNldCBhbHJlYWR5IGdldCBjb252ZXJ0ZWQgdG8g dW5pdHkgbWFwcGVkCnJlZ2lvbnMuKQoKRmlyc3Qgb2YgYWxsLCBkcm9wIHRo ZSBkZXBlbmRlbmN5IG9uIG1heF9wYWdlLiBXaXRoIGNvbW1pdCBiNGYwNDIy MzZhZTAKKCJBTUQvSU9NTVU6IENlYXNlIHVzaW5nIGEgZHluYW1pYyBoZWln aHQgZm9yIHRoZSBJT01NVSBwYWdldGFibGVzIikgdGhlCnVzZSBvZiBpdCBo ZXJlIHdhcyBzdGFsZSBhbnl3YXk7IGl0IHdhcyBib2d1cyBhbHJlYWR5IGJl Zm9yZSwgYXMgaXQKZGlkbid0IGFjY291bnQgZm9yIG1heF9wYWdlIGdldHRp bmcgaW5jcmVhc2VkIGxhdGVyIG9uLiBTaW1wbHkgdHJ5IGFuCmV4Y2x1c2lv biByYW5nZSByZWdpc3RyYXRpb24gZmlyc3QsIGFuZCBpZiBpdCBmYWlscyAo Zm9yIGJlaW5nCnVuc3VpdGFibGUgb3Igbm9uLW1lcmdlYWJsZSksIHJlZ2lz dGVyIGEgdW5pdHkgbWFwcGluZyByYW5nZS4KCldpdGggdGhpcyB2YXJpb3Vz IGxvY2FsIHZhcmlhYmxlcyBiZWNvbWUgdW5uZWNlc3NhcnkgYW5kIGhlbmNl IGdldApkcm9wcGVkIGF0IHRoZSBzYW1lIHRpbWUuCgpXaXRoIHRoZSBtYXhf cGFnZSBib3VuZGFyeSBkcm9wcGVkIGZvciB1c2luZyB1bml0eSBtYXBzLCB0 aGUgbWluaW11bQpwYWdlIHRhYmxlIHRyZWUgaGVpZ2h0IG5vdyBuZWVkcyBi b3RoIHJlY29yZGluZyBhbmQgZW5mb3JjaW5nIGluCmFtZF9pb21tdV9kb21h aW5faW5pdCgpLiBTaW5jZSB3ZSBjYW4ndCBwcmVkaWN0IHdoaWNoIGRldmlj ZXMgbWF5IGdldAphc3NpZ25lZCB0byBhIGRvbWFpbiwgb3VyIG9ubHkgb3B0 aW9uIGlzIHRvIHVuaWZvcm1seSBmb3JjZSBhdCBsZWFzdAp0aGF0IGhlaWdo dCBmb3IgYWxsIGRvbWFpbnMsIG5vdyB0aGF0IHRoZSBoZWlnaHQgaXNuJ3Qg ZHluYW1pYyBhbnltb3JlLgoKRnVydGhlciBkb24ndCBtYWtlIHVzZSBvZiB0 aGUgZXhjbHVzaW9uIHJhbmdlIHVubGVzcyBBQ1BJIGRhdGEgc2F5cyBzby4K Ck5vdGUgdGhhdCBleGNsdXNpb24gcmFuZ2UgcmVnaXN0cmF0aW9uIGluCnJl Z2lzdGVyX3JhbmdlX2Zvcl9hbGxfZGV2aWNlcygpIGlzIG9uIGEgYmVzdCBl ZmZvcnQgYmFzaXMuIEhlbmNlIHVuaXR5Cm1hcCBlbnRyaWVzIGFsc28gcmVn aXN0ZXJlZCBhcmUgcmVkdW5kYW50IHdoZW4gdGhlIGZvcm1lciBzdWNjZWVk ZWQsIGJ1dAp0aGV5IGFsc28gZG8gbm8gaGFybS4gSW1wcm92ZW1lbnRzIGlu IHRoaXMgYXJlYSBjYW4gYmUgZG9uZSBsYXRlciBpbW8uCgpBbHNvIGFkanVz dCB0eXBlcyB3aGVyZSBzdWl0YWJsZSB3aXRob3V0IHRvdWNoaW5nIGV4dHJh IGxpbmVzLgoKVGhpcyBpcyBwYXJ0IG9mIFhTQS0zNzguCgpTaWduZWQtb2Zm LWJ5OiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+ClJldmlld2Vk LWJ5OiBQYXVsIER1cnJhbnQgPHBhdWxAeGVuLm9yZz4KCi0tLSBhL3hlbi9k cml2ZXJzL3Bhc3N0aHJvdWdoL2FtZC9pb21tdV9hY3BpLmMKKysrIGIveGVu L2RyaXZlcnMvcGFzc3Rocm91Z2gvYW1kL2lvbW11X2FjcGkuYwpAQCAtOTks MTIgKzk5LDggQEAgc3RhdGljIHN0cnVjdCBhbWRfaW9tbXUgKiBfX2luaXQg ZmluZF9pbwogfQogCiBzdGF0aWMgaW50IF9faW5pdCByZXNlcnZlX2lvbW11 X2V4Y2x1c2lvbl9yYW5nZSgKLSAgICBzdHJ1Y3QgYW1kX2lvbW11ICppb21t dSwgdWludDY0X3QgYmFzZSwgdWludDY0X3QgbGltaXQsCi0gICAgYm9vbCBh bGwsIGJvb2wgaXcsIGJvb2wgaXIpCisgICAgc3RydWN0IGFtZF9pb21tdSAq aW9tbXUsIHBhZGRyX3QgYmFzZSwgcGFkZHJfdCBsaW1pdCwgYm9vbCBhbGwp CiB7Ci0gICAgaWYgKCAhaXIgfHwgIWl3ICkKLSAgICAgICAgcmV0dXJuIC1F UEVSTTsKLQogICAgIC8qIG5lZWQgdG8gZXh0ZW5kIGV4Y2x1c2lvbiByYW5n ZT8gKi8KICAgICBpZiAoIGlvbW11LT5leGNsdXNpb25fZW5hYmxlICkKICAg ICB7CkBAIC0xMzMsMTQgKzEyOSwxOCBAQCBzdGF0aWMgaW50IF9faW5pdCBy ZXNlcnZlX3VuaXR5X21hcF9mb3JfCiB7CiAgICAgc3RydWN0IGl2cnNfbWFw cGluZ3MgKml2cnNfbWFwcGluZ3MgPSBnZXRfaXZyc19tYXBwaW5ncyhzZWcp OwogICAgIHN0cnVjdCBpdnJzX3VuaXR5X21hcCAqdW5pdHlfbWFwID0gaXZy c19tYXBwaW5nc1tiZGZdLnVuaXR5X21hcDsKKyAgICBpbnQgcGFnaW5nX21v ZGUgPSBhbWRfaW9tbXVfZ2V0X3BhZ2luZ19tb2RlKFBGTl9VUChiYXNlICsg bGVuZ3RoKSk7CisKKyAgICBpZiAoIHBhZ2luZ19tb2RlIDwgMCApCisgICAg ICAgIHJldHVybiBwYWdpbmdfbW9kZTsKIAogICAgIC8qIENoZWNrIGZvciBv dmVybGFwcy4gKi8KICAgICBmb3IgKCA7IHVuaXR5X21hcDsgdW5pdHlfbWFw ID0gdW5pdHlfbWFwLT5uZXh0ICkKICAgICB7CiAgICAgICAgIC8qCiAgICAg ICAgICAqIEV4YWN0IG1hdGNoZXMgYXJlIG9rYXkuIFRoaXMgY2FuIGluIHBh cnRpY3VsYXIgaGFwcGVuIHdoZW4KLSAgICAgICAgICogcmVnaXN0ZXJfZXhj bHVzaW9uX3JhbmdlX2Zvcl9kZXZpY2UoKSBjYWxscyBoZXJlIHR3aWNlIGZv ciB0aGUKLSAgICAgICAgICogc2FtZSAocyxiLGQsZikuCisgICAgICAgICAq IHJlZ2lzdGVyX3JhbmdlX2Zvcl9kZXZpY2UoKSBjYWxscyBoZXJlIHR3aWNl IGZvciB0aGUgc2FtZQorICAgICAgICAgKiAocyxiLGQsZikuCiAgICAgICAg ICAqLwogICAgICAgICBpZiAoIGJhc2UgPT0gdW5pdHlfbWFwLT5hZGRyICYm IGxlbmd0aCA9PSB1bml0eV9tYXAtPmxlbmd0aCAmJgogICAgICAgICAgICAg IGlyID09IHVuaXR5X21hcC0+cmVhZCAmJiBpdyA9PSB1bml0eV9tYXAtPndy aXRlICkKQEAgLTE2OCw1NSArMTY4LDUyIEBAIHN0YXRpYyBpbnQgX19pbml0 IHJlc2VydmVfdW5pdHlfbWFwX2Zvcl8KICAgICB1bml0eV9tYXAtPm5leHQg PSBpdnJzX21hcHBpbmdzW2JkZl0udW5pdHlfbWFwOwogICAgIGl2cnNfbWFw cGluZ3NbYmRmXS51bml0eV9tYXAgPSB1bml0eV9tYXA7CiAKKyAgICBpZiAo IHBhZ2luZ19tb2RlID4gYW1kX2lvbW11X21pbl9wYWdpbmdfbW9kZSApCisg ICAgICAgIGFtZF9pb21tdV9taW5fcGFnaW5nX21vZGUgPSBwYWdpbmdfbW9k ZTsKKwogICAgIHJldHVybiAwOwogfQogCi1zdGF0aWMgaW50IF9faW5pdCBy ZWdpc3Rlcl9leGNsdXNpb25fcmFuZ2VfZm9yX2FsbF9kZXZpY2VzKAotICAg IHVuc2lnbmVkIGxvbmcgYmFzZSwgdW5zaWduZWQgbG9uZyBsaW1pdCwgdTgg aXcsIHU4IGlyKQorc3RhdGljIGludCBfX2luaXQgcmVnaXN0ZXJfcmFuZ2Vf Zm9yX2FsbF9kZXZpY2VzKAorICAgIHBhZGRyX3QgYmFzZSwgcGFkZHJfdCBs aW1pdCwgYm9vbCBpdywgYm9vbCBpciwgYm9vbCBleGNsdXNpb24pCiB7CiAg ICAgaW50IHNlZyA9IDA7IC8qIFhYWCAqLwotICAgIHVuc2lnbmVkIGxvbmcg cmFuZ2VfdG9wLCBpb21tdV90b3AsIGxlbmd0aDsKICAgICBzdHJ1Y3QgYW1k X2lvbW11ICppb21tdTsKLSAgICB1bnNpZ25lZCBpbnQgYmRmOwogICAgIGlu dCByYyA9IDA7CiAKICAgICAvKiBpcyBwYXJ0IG9mIGV4Y2x1c2lvbiByYW5n ZSBpbnNpZGUgb2YgSU9NTVUgdmlydHVhbCBhZGRyZXNzIHNwYWNlPyAqLwog ICAgIC8qIG5vdGU6ICdsaW1pdCcgcGFyYW1ldGVyIGlzIGFzc3VtZWQgdG8g YmUgcGFnZS1hbGlnbmVkICovCi0gICAgcmFuZ2VfdG9wID0gbGltaXQgKyBQ QUdFX1NJWkU7Ci0gICAgaW9tbXVfdG9wID0gbWF4X3BhZ2UgKiBQQUdFX1NJ WkU7Ci0gICAgaWYgKCBiYXNlIDwgaW9tbXVfdG9wICkKLSAgICB7Ci0gICAg ICAgIGlmICggcmFuZ2VfdG9wID4gaW9tbXVfdG9wICkKLSAgICAgICAgICAg IHJhbmdlX3RvcCA9IGlvbW11X3RvcDsKLSAgICAgICAgbGVuZ3RoID0gcmFu Z2VfdG9wIC0gYmFzZTsKLSAgICAgICAgLyogcmVzZXJ2ZSByL3cgdW5pdHkt bWFwcGVkIHBhZ2UgZW50cmllcyBmb3IgZGV2aWNlcyAqLwotICAgICAgICAv KiBub3RlOiB0aGVzZSBlbnRyaWVzIGFyZSBwYXJ0IG9mIHRoZSBleGNsdXNp b24gcmFuZ2UgKi8KLSAgICAgICAgZm9yICggYmRmID0gMDsgIXJjICYmIGJk ZiA8IGl2cnNfYmRmX2VudHJpZXM7IGJkZisrICkKLSAgICAgICAgICAgIHJj ID0gcmVzZXJ2ZV91bml0eV9tYXBfZm9yX2RldmljZShzZWcsIGJkZiwgYmFz ZSwgbGVuZ3RoLCBpdywgaXIpOwotICAgICAgICAvKiBwdXNoICdiYXNlJyBq dXN0IG91dHNpZGUgb2YgdmlydHVhbCBhZGRyZXNzIHNwYWNlICovCi0gICAg ICAgIGJhc2UgPSBpb21tdV90b3A7Ci0gICAgfQotICAgIC8qIHJlZ2lzdGVy IElPTU1VIGV4Y2x1c2lvbiByYW5nZSBzZXR0aW5ncyAqLwotICAgIGlmICgg IXJjICYmIGxpbWl0ID49IGlvbW11X3RvcCApCisgICAgaWYgKCBleGNsdXNp b24gKQogICAgIHsKICAgICAgICAgZm9yX2VhY2hfYW1kX2lvbW11KCBpb21t dSApCiAgICAgICAgIHsKLSAgICAgICAgICAgIHJjID0gcmVzZXJ2ZV9pb21t dV9leGNsdXNpb25fcmFuZ2UoaW9tbXUsIGJhc2UsIGxpbWl0LAotICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB0cnVl IC8qIGFsbCAqLywgaXcsIGlyKTsKLSAgICAgICAgICAgIGlmICggcmMgKQot ICAgICAgICAgICAgICAgIGJyZWFrOworICAgICAgICAgICAgaW50IHJldCA9 IHJlc2VydmVfaW9tbXVfZXhjbHVzaW9uX3JhbmdlKGlvbW11LCBiYXNlLCBs aW1pdCwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICB0cnVlIC8qIGFsbCAqLyk7CisKKyAgICAgICAgICAg IGlmICggcmV0ICYmICFyYyApCisgICAgICAgICAgICAgICAgcmMgPSByZXQ7 CiAgICAgICAgIH0KICAgICB9CiAKKyAgICBpZiAoICFleGNsdXNpb24gfHwg cmMgKQorICAgIHsKKyAgICAgICAgcGFkZHJfdCBsZW5ndGggPSBsaW1pdCAr IFBBR0VfU0laRSAtIGJhc2U7CisgICAgICAgIHVuc2lnbmVkIGludCBiZGY7 CisKKyAgICAgICAgLyogcmVzZXJ2ZSByL3cgdW5pdHktbWFwcGVkIHBhZ2Ug ZW50cmllcyBmb3IgZGV2aWNlcyAqLworICAgICAgICBmb3IgKCBiZGYgPSBy YyA9IDA7ICFyYyAmJiBiZGYgPCBpdnJzX2JkZl9lbnRyaWVzOyBiZGYrKyAp CisgICAgICAgICAgICByYyA9IHJlc2VydmVfdW5pdHlfbWFwX2Zvcl9kZXZp Y2Uoc2VnLCBiZGYsIGJhc2UsIGxlbmd0aCwgaXcsIGlyKTsKKyAgICB9CisK ICAgICByZXR1cm4gcmM7CiB9CiAKLXN0YXRpYyBpbnQgX19pbml0IHJlZ2lz dGVyX2V4Y2x1c2lvbl9yYW5nZV9mb3JfZGV2aWNlKAotICAgIHUxNiBiZGYs IHVuc2lnbmVkIGxvbmcgYmFzZSwgdW5zaWduZWQgbG9uZyBsaW1pdCwgdTgg aXcsIHU4IGlyKQorc3RhdGljIGludCBfX2luaXQgcmVnaXN0ZXJfcmFuZ2Vf Zm9yX2RldmljZSgKKyAgICB1bnNpZ25lZCBpbnQgYmRmLCBwYWRkcl90IGJh c2UsIHBhZGRyX3QgbGltaXQsCisgICAgYm9vbCBpdywgYm9vbCBpciwgYm9v bCBleGNsdXNpb24pCiB7CiAgICAgaW50IHNlZyA9IDA7IC8qIFhYWCAqLwog ICAgIHN0cnVjdCBpdnJzX21hcHBpbmdzICppdnJzX21hcHBpbmdzID0gZ2V0 X2l2cnNfbWFwcGluZ3Moc2VnKTsKLSAgICB1bnNpZ25lZCBsb25nIHJhbmdl X3RvcCwgaW9tbXVfdG9wLCBsZW5ndGg7CiAgICAgc3RydWN0IGFtZF9pb21t dSAqaW9tbXU7CiAgICAgdTE2IHJlcTsKICAgICBpbnQgcmMgPSAwOwpAQCAt MjMwLDI3ICsyMjcsMTkgQEAgc3RhdGljIGludCBfX2luaXQgcmVnaXN0ZXJf ZXhjbHVzaW9uX3JhbgogICAgIHJlcSA9IGl2cnNfbWFwcGluZ3NbYmRmXS5k dGVfcmVxdWVzdG9yX2lkOwogCiAgICAgLyogbm90ZTogJ2xpbWl0JyBwYXJh bWV0ZXIgaXMgYXNzdW1lZCB0byBiZSBwYWdlLWFsaWduZWQgKi8KLSAgICBy YW5nZV90b3AgPSBsaW1pdCArIFBBR0VfU0laRTsKLSAgICBpb21tdV90b3Ag PSBtYXhfcGFnZSAqIFBBR0VfU0laRTsKLSAgICBpZiAoIGJhc2UgPCBpb21t dV90b3AgKQotICAgIHsKLSAgICAgICAgaWYgKCByYW5nZV90b3AgPiBpb21t dV90b3AgKQotICAgICAgICAgICAgcmFuZ2VfdG9wID0gaW9tbXVfdG9wOwot ICAgICAgICBsZW5ndGggPSByYW5nZV90b3AgLSBiYXNlOworICAgIGlmICgg ZXhjbHVzaW9uICkKKyAgICAgICAgcmMgPSByZXNlcnZlX2lvbW11X2V4Y2x1 c2lvbl9yYW5nZShpb21tdSwgYmFzZSwgbGltaXQsCisgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZmFsc2UgLyogYWxsICov KTsKKyAgICBpZiAoICFleGNsdXNpb24gfHwgcmMgKQorICAgIHsKKyAgICAg ICAgcGFkZHJfdCBsZW5ndGggPSBsaW1pdCArIFBBR0VfU0laRSAtIGJhc2U7 CisKICAgICAgICAgLyogcmVzZXJ2ZSB1bml0eS1tYXBwZWQgcGFnZSBlbnRy aWVzIGZvciBkZXZpY2UgKi8KLSAgICAgICAgLyogbm90ZTogdGhlc2UgZW50 cmllcyBhcmUgcGFydCBvZiB0aGUgZXhjbHVzaW9uIHJhbmdlICovCiAgICAg ICAgIHJjID0gcmVzZXJ2ZV91bml0eV9tYXBfZm9yX2RldmljZShzZWcsIGJk ZiwgYmFzZSwgbGVuZ3RoLCBpdywgaXIpID86CiAgICAgICAgICAgICAgcmVz ZXJ2ZV91bml0eV9tYXBfZm9yX2RldmljZShzZWcsIHJlcSwgYmFzZSwgbGVu Z3RoLCBpdywgaXIpOwotCi0gICAgICAgIC8qIHB1c2ggJ2Jhc2UnIGp1c3Qg b3V0c2lkZSBvZiB2aXJ0dWFsIGFkZHJlc3Mgc3BhY2UgKi8KLSAgICAgICAg YmFzZSA9IGlvbW11X3RvcDsKICAgICB9Ci0KLSAgICAvKiByZWdpc3RlciBJ T01NVSBleGNsdXNpb24gcmFuZ2Ugc2V0dGluZ3MgZm9yIGRldmljZSAqLwot ICAgIGlmICggIXJjICYmIGxpbWl0ID49IGlvbW11X3RvcCAgKQorICAgIGVs c2UKICAgICB7Ci0gICAgICAgIHJjID0gcmVzZXJ2ZV9pb21tdV9leGNsdXNp b25fcmFuZ2UoaW9tbXUsIGJhc2UsIGxpbWl0LAotICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIGZhbHNlIC8qIGFsbCAqLywg aXcsIGlyKTsKICAgICAgICAgaXZyc19tYXBwaW5nc1tiZGZdLmR0ZV9hbGxv d19leGNsdXNpb24gPSBJT01NVV9DT05UUk9MX0VOQUJMRUQ7CiAgICAgICAg IGl2cnNfbWFwcGluZ3NbcmVxXS5kdGVfYWxsb3dfZXhjbHVzaW9uID0gSU9N TVVfQ09OVFJPTF9FTkFCTEVEOwogICAgIH0KQEAgLTI1OCw1MyArMjQ3LDQy IEBAIHN0YXRpYyBpbnQgX19pbml0IHJlZ2lzdGVyX2V4Y2x1c2lvbl9yYW4K ICAgICByZXR1cm4gcmM7CiB9CiAKLXN0YXRpYyBpbnQgX19pbml0IHJlZ2lz dGVyX2V4Y2x1c2lvbl9yYW5nZV9mb3JfaW9tbXVfZGV2aWNlcygKLSAgICBz dHJ1Y3QgYW1kX2lvbW11ICppb21tdSwKLSAgICB1bnNpZ25lZCBsb25nIGJh c2UsIHVuc2lnbmVkIGxvbmcgbGltaXQsIHU4IGl3LCB1OCBpcikKK3N0YXRp YyBpbnQgX19pbml0IHJlZ2lzdGVyX3JhbmdlX2Zvcl9pb21tdV9kZXZpY2Vz KAorICAgIHN0cnVjdCBhbWRfaW9tbXUgKmlvbW11LCBwYWRkcl90IGJhc2Us IHBhZGRyX3QgbGltaXQsCisgICAgYm9vbCBpdywgYm9vbCBpciwgYm9vbCBl eGNsdXNpb24pCiB7Ci0gICAgdW5zaWduZWQgbG9uZyByYW5nZV90b3AsIGlv bW11X3RvcCwgbGVuZ3RoOworICAgIC8qIG5vdGU6ICdsaW1pdCcgcGFyYW1l dGVyIGlzIGFzc3VtZWQgdG8gYmUgcGFnZS1hbGlnbmVkICovCisgICAgcGFk ZHJfdCBsZW5ndGggPSBsaW1pdCArIFBBR0VfU0laRSAtIGJhc2U7CiAgICAg dW5zaWduZWQgaW50IGJkZjsKICAgICB1MTYgcmVxOwotICAgIGludCByYyA9 IDA7CisgICAgaW50IHJjOwogCi0gICAgLyogaXMgcGFydCBvZiBleGNsdXNp b24gcmFuZ2UgaW5zaWRlIG9mIElPTU1VIHZpcnR1YWwgYWRkcmVzcyBzcGFj ZT8gKi8KLSAgICAvKiBub3RlOiAnbGltaXQnIHBhcmFtZXRlciBpcyBhc3N1 bWVkIHRvIGJlIHBhZ2UtYWxpZ25lZCAqLwotICAgIHJhbmdlX3RvcCA9IGxp bWl0ICsgUEFHRV9TSVpFOwotICAgIGlvbW11X3RvcCA9IG1heF9wYWdlICog UEFHRV9TSVpFOwotICAgIGlmICggYmFzZSA8IGlvbW11X3RvcCApCi0gICAg ewotICAgICAgICBpZiAoIHJhbmdlX3RvcCA+IGlvbW11X3RvcCApCi0gICAg ICAgICAgICByYW5nZV90b3AgPSBpb21tdV90b3A7Ci0gICAgICAgIGxlbmd0 aCA9IHJhbmdlX3RvcCAtIGJhc2U7Ci0gICAgICAgIC8qIHJlc2VydmUgci93 IHVuaXR5LW1hcHBlZCBwYWdlIGVudHJpZXMgZm9yIGRldmljZXMgKi8KLSAg ICAgICAgLyogbm90ZTogdGhlc2UgZW50cmllcyBhcmUgcGFydCBvZiB0aGUg ZXhjbHVzaW9uIHJhbmdlICovCi0gICAgICAgIGZvciAoIGJkZiA9IDA7ICFy YyAmJiBiZGYgPCBpdnJzX2JkZl9lbnRyaWVzOyBiZGYrKyApCi0gICAgICAg IHsKLSAgICAgICAgICAgIGlmICggaW9tbXUgPT0gZmluZF9pb21tdV9mb3Jf ZGV2aWNlKGlvbW11LT5zZWcsIGJkZikgKQotICAgICAgICAgICAgewotICAg ICAgICAgICAgICAgIHJlcSA9IGdldF9pdnJzX21hcHBpbmdzKGlvbW11LT5z ZWcpW2JkZl0uZHRlX3JlcXVlc3Rvcl9pZDsKLSAgICAgICAgICAgICAgICBy YyA9IHJlc2VydmVfdW5pdHlfbWFwX2Zvcl9kZXZpY2UoaW9tbXUtPnNlZywg YmRmLCBiYXNlLCBsZW5ndGgsCi0gICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIGl3LCBpcikgPzoKLSAgICAgICAg ICAgICAgICAgICAgIHJlc2VydmVfdW5pdHlfbWFwX2Zvcl9kZXZpY2UoaW9t bXUtPnNlZywgcmVxLCBiYXNlLCBsZW5ndGgsCi0gICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGl3LCBpcik7Ci0g ICAgICAgICAgICB9Ci0gICAgICAgIH0KLQotICAgICAgICAvKiBwdXNoICdi YXNlJyBqdXN0IG91dHNpZGUgb2YgdmlydHVhbCBhZGRyZXNzIHNwYWNlICov Ci0gICAgICAgIGJhc2UgPSBpb21tdV90b3A7CisgICAgaWYgKCBleGNsdXNp b24gKQorICAgIHsKKyAgICAgICAgcmMgPSByZXNlcnZlX2lvbW11X2V4Y2x1 c2lvbl9yYW5nZShpb21tdSwgYmFzZSwgbGltaXQsIHRydWUgLyogYWxsICov KTsKKyAgICAgICAgaWYgKCAhcmMgKQorICAgICAgICAgICAgcmV0dXJuIDA7 CiAgICAgfQogCi0gICAgLyogcmVnaXN0ZXIgSU9NTVUgZXhjbHVzaW9uIHJh bmdlIHNldHRpbmdzICovCi0gICAgaWYgKCAhcmMgJiYgbGltaXQgPj0gaW9t bXVfdG9wICkKLSAgICAgICAgcmMgPSByZXNlcnZlX2lvbW11X2V4Y2x1c2lv bl9yYW5nZShpb21tdSwgYmFzZSwgbGltaXQsCi0gICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgdHJ1ZSAvKiBhbGwgKi8sIGl3 LCBpcik7CisgICAgLyogcmVzZXJ2ZSB1bml0eS1tYXBwZWQgcGFnZSBlbnRy aWVzIGZvciBkZXZpY2VzICovCisgICAgZm9yICggYmRmID0gcmMgPSAwOyAh cmMgJiYgYmRmIDwgaXZyc19iZGZfZW50cmllczsgYmRmKysgKQorICAgIHsK KyAgICAgICAgaWYgKCBpb21tdSAhPSBmaW5kX2lvbW11X2Zvcl9kZXZpY2Uo aW9tbXUtPnNlZywgYmRmKSApCisgICAgICAgICAgICBjb250aW51ZTsKKwor ICAgICAgICByZXEgPSBnZXRfaXZyc19tYXBwaW5ncyhpb21tdS0+c2VnKVti ZGZdLmR0ZV9yZXF1ZXN0b3JfaWQ7CisgICAgICAgIHJjID0gcmVzZXJ2ZV91 bml0eV9tYXBfZm9yX2RldmljZShpb21tdS0+c2VnLCBiZGYsIGJhc2UsIGxl bmd0aCwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIGl3LCBpcikgPzoKKyAgICAgICAgICAgICByZXNlcnZlX3VuaXR5X21h cF9mb3JfZGV2aWNlKGlvbW11LT5zZWcsIHJlcSwgYmFzZSwgbGVuZ3RoLAor ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgaXcs IGlyKTsKKyAgICB9CiAKICAgICByZXR1cm4gcmM7CiB9CiAKIHN0YXRpYyBp bnQgX19pbml0IHBhcnNlX2l2bWRfZGV2aWNlX3NlbGVjdCgKICAgICBjb25z dCBzdHJ1Y3QgYWNwaV9pdnJzX21lbW9yeSAqaXZtZF9ibG9jaywKLSAgICB1 bnNpZ25lZCBsb25nIGJhc2UsIHVuc2lnbmVkIGxvbmcgbGltaXQsIHU4IGl3 LCB1OCBpcikKKyAgICBwYWRkcl90IGJhc2UsIHBhZGRyX3QgbGltaXQsIGJv b2wgaXcsIGJvb2wgaXIsIGJvb2wgZXhjbHVzaW9uKQogewogICAgIHUxNiBi ZGY7CiAKQEAgLTMxNSwxMiArMjkzLDEyIEBAIHN0YXRpYyBpbnQgX19pbml0 IHBhcnNlX2l2bWRfZGV2aWNlX3NlbGUKICAgICAgICAgcmV0dXJuIC1FTk9E RVY7CiAgICAgfQogCi0gICAgcmV0dXJuIHJlZ2lzdGVyX2V4Y2x1c2lvbl9y YW5nZV9mb3JfZGV2aWNlKGJkZiwgYmFzZSwgbGltaXQsIGl3LCBpcik7Cisg ICAgcmV0dXJuIHJlZ2lzdGVyX3JhbmdlX2Zvcl9kZXZpY2UoYmRmLCBiYXNl LCBsaW1pdCwgaXcsIGlyLCBleGNsdXNpb24pOwogfQogCiBzdGF0aWMgaW50 IF9faW5pdCBwYXJzZV9pdm1kX2RldmljZV9yYW5nZSgKICAgICBjb25zdCBz dHJ1Y3QgYWNwaV9pdnJzX21lbW9yeSAqaXZtZF9ibG9jaywKLSAgICB1bnNp Z25lZCBsb25nIGJhc2UsIHVuc2lnbmVkIGxvbmcgbGltaXQsIHU4IGl3LCB1 OCBpcikKKyAgICBwYWRkcl90IGJhc2UsIHBhZGRyX3QgbGltaXQsIGJvb2wg aXcsIGJvb2wgaXIsIGJvb2wgZXhjbHVzaW9uKQogewogICAgIHVuc2lnbmVk IGludCBmaXJzdF9iZGYsIGxhc3RfYmRmLCBiZGY7CiAgICAgaW50IGVycm9y OwpAQCAtMzQyLDE1ICszMjAsMTUgQEAgc3RhdGljIGludCBfX2luaXQgcGFy c2VfaXZtZF9kZXZpY2VfcmFuZwogICAgIH0KIAogICAgIGZvciAoIGJkZiA9 IGZpcnN0X2JkZiwgZXJyb3IgPSAwOyAoYmRmIDw9IGxhc3RfYmRmKSAmJiAh ZXJyb3I7IGJkZisrICkKLSAgICAgICAgZXJyb3IgPSByZWdpc3Rlcl9leGNs dXNpb25fcmFuZ2VfZm9yX2RldmljZSgKLSAgICAgICAgICAgIGJkZiwgYmFz ZSwgbGltaXQsIGl3LCBpcik7CisgICAgICAgIGVycm9yID0gcmVnaXN0ZXJf cmFuZ2VfZm9yX2RldmljZSgKKyAgICAgICAgICAgIGJkZiwgYmFzZSwgbGlt aXQsIGl3LCBpciwgZXhjbHVzaW9uKTsKIAogICAgIHJldHVybiBlcnJvcjsK IH0KIAogc3RhdGljIGludCBfX2luaXQgcGFyc2VfaXZtZF9kZXZpY2VfaW9t bXUoCiAgICAgY29uc3Qgc3RydWN0IGFjcGlfaXZyc19tZW1vcnkgKml2bWRf YmxvY2ssCi0gICAgdW5zaWduZWQgbG9uZyBiYXNlLCB1bnNpZ25lZCBsb25n IGxpbWl0LCB1OCBpdywgdTggaXIpCisgICAgcGFkZHJfdCBiYXNlLCBwYWRk cl90IGxpbWl0LCBib29sIGl3LCBib29sIGlyLCBib29sIGV4Y2x1c2lvbikK IHsKICAgICBpbnQgc2VnID0gMDsgLyogWFhYICovCiAgICAgc3RydWN0IGFt ZF9pb21tdSAqaW9tbXU7CkBAIC0zNjUsMTQgKzM0MywxNCBAQCBzdGF0aWMg aW50IF9faW5pdCBwYXJzZV9pdm1kX2RldmljZV9pb21tCiAgICAgICAgIHJl dHVybiAtRU5PREVWOwogICAgIH0KIAotICAgIHJldHVybiByZWdpc3Rlcl9l eGNsdXNpb25fcmFuZ2VfZm9yX2lvbW11X2RldmljZXMoCi0gICAgICAgIGlv bW11LCBiYXNlLCBsaW1pdCwgaXcsIGlyKTsKKyAgICByZXR1cm4gcmVnaXN0 ZXJfcmFuZ2VfZm9yX2lvbW11X2RldmljZXMoCisgICAgICAgIGlvbW11LCBi YXNlLCBsaW1pdCwgaXcsIGlyLCBleGNsdXNpb24pOwogfQogCiBzdGF0aWMg aW50IF9faW5pdCBwYXJzZV9pdm1kX2Jsb2NrKGNvbnN0IHN0cnVjdCBhY3Bp X2l2cnNfbWVtb3J5ICppdm1kX2Jsb2NrKQogewogICAgIHVuc2lnbmVkIGxv bmcgc3RhcnRfYWRkciwgbWVtX2xlbmd0aCwgYmFzZSwgbGltaXQ7Ci0gICAg dTggaXcsIGlyOworICAgIGJvb2wgaXcgPSB0cnVlLCBpciA9IHRydWUsIGV4 Y2x1c2lvbiA9IGZhbHNlOwogCiAgICAgaWYgKCBpdm1kX2Jsb2NrLT5oZWFk ZXIubGVuZ3RoIDwgc2l6ZW9mKCppdm1kX2Jsb2NrKSApCiAgICAgewpAQCAt Mzg5LDEzICszNjcsMTEgQEAgc3RhdGljIGludCBfX2luaXQgcGFyc2VfaXZt ZF9ibG9jayhjb25zdAogICAgICAgICAgICAgICAgICAgICBpdm1kX2Jsb2Nr LT5oZWFkZXIudHlwZSwgc3RhcnRfYWRkciwgbWVtX2xlbmd0aCk7CiAKICAg ICBpZiAoIGl2bWRfYmxvY2stPmhlYWRlci5mbGFncyAmIEFDUElfSVZNRF9F WENMVVNJT05fUkFOR0UgKQotICAgICAgICBpdyA9IGlyID0gSU9NTVVfQ09O VFJPTF9FTkFCTEVEOworICAgICAgICBleGNsdXNpb24gPSB0cnVlOwogICAg IGVsc2UgaWYgKCBpdm1kX2Jsb2NrLT5oZWFkZXIuZmxhZ3MgJiBBQ1BJX0lW TURfVU5JVFkgKQogICAgIHsKLSAgICAgICAgaXcgPSBpdm1kX2Jsb2NrLT5o ZWFkZXIuZmxhZ3MgJiBBQ1BJX0lWTURfUkVBRCA/Ci0gICAgICAgICAgICBJ T01NVV9DT05UUk9MX0VOQUJMRUQgOiBJT01NVV9DT05UUk9MX0RJU0FCTEVE OwotICAgICAgICBpciA9IGl2bWRfYmxvY2stPmhlYWRlci5mbGFncyAmIEFD UElfSVZNRF9XUklURSA/Ci0gICAgICAgICAgICBJT01NVV9DT05UUk9MX0VO QUJMRUQgOiBJT01NVV9DT05UUk9MX0RJU0FCTEVEOworICAgICAgICBpdyA9 IGl2bWRfYmxvY2stPmhlYWRlci5mbGFncyAmIEFDUElfSVZNRF9SRUFEOwor ICAgICAgICBpciA9IGl2bWRfYmxvY2stPmhlYWRlci5mbGFncyAmIEFDUElf SVZNRF9XUklURTsKICAgICB9CiAgICAgZWxzZQogICAgIHsKQEAgLTQwNiwy MCArMzgyLDIwIEBAIHN0YXRpYyBpbnQgX19pbml0IHBhcnNlX2l2bWRfYmxv Y2soY29uc3QKICAgICBzd2l0Y2goIGl2bWRfYmxvY2stPmhlYWRlci50eXBl ICkKICAgICB7CiAgICAgY2FzZSBBQ1BJX0lWUlNfVFlQRV9NRU1PUllfQUxM OgotICAgICAgICByZXR1cm4gcmVnaXN0ZXJfZXhjbHVzaW9uX3JhbmdlX2Zv cl9hbGxfZGV2aWNlcygKLSAgICAgICAgICAgIGJhc2UsIGxpbWl0LCBpdywg aXIpOworICAgICAgICByZXR1cm4gcmVnaXN0ZXJfcmFuZ2VfZm9yX2FsbF9k ZXZpY2VzKAorICAgICAgICAgICAgYmFzZSwgbGltaXQsIGl3LCBpciwgZXhj bHVzaW9uKTsKIAogICAgIGNhc2UgQUNQSV9JVlJTX1RZUEVfTUVNT1JZX09O RToKLSAgICAgICAgcmV0dXJuIHBhcnNlX2l2bWRfZGV2aWNlX3NlbGVjdChp dm1kX2Jsb2NrLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIGJhc2UsIGxpbWl0LCBpdywgaXIpOworICAgICAgICByZXR1cm4g cGFyc2VfaXZtZF9kZXZpY2Vfc2VsZWN0KGl2bWRfYmxvY2ssIGJhc2UsIGxp bWl0LAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IGl3LCBpciwgZXhjbHVzaW9uKTsKIAogICAgIGNhc2UgQUNQSV9JVlJTX1RZ UEVfTUVNT1JZX1JBTkdFOgotICAgICAgICByZXR1cm4gcGFyc2VfaXZtZF9k ZXZpY2VfcmFuZ2UoaXZtZF9ibG9jaywKLSAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIGJhc2UsIGxpbWl0LCBpdywgaXIpOworICAg ICAgICByZXR1cm4gcGFyc2VfaXZtZF9kZXZpY2VfcmFuZ2UoaXZtZF9ibG9j aywgYmFzZSwgbGltaXQsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICBpdywgaXIsIGV4Y2x1c2lvbik7CiAKICAgICBjYXNlIEFD UElfSVZSU19UWVBFX01FTU9SWV9JT01NVToKLSAgICAgICAgcmV0dXJuIHBh cnNlX2l2bWRfZGV2aWNlX2lvbW11KGl2bWRfYmxvY2ssCi0gICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBiYXNlLCBsaW1pdCwgaXcs IGlyKTsKKyAgICAgICAgcmV0dXJuIHBhcnNlX2l2bWRfZGV2aWNlX2lvbW11 KGl2bWRfYmxvY2ssIGJhc2UsIGxpbWl0LAorICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgaXcsIGlyLCBleGNsdXNpb24pOwogCiAg ICAgZGVmYXVsdDoKICAgICAgICAgQU1EX0lPTU1VX0RFQlVHKCJJVk1EIEVy cm9yOiBJbnZhbGlkIEJsb2NrIFR5cGUhXG4iKTsKLS0tIGEveGVuL2RyaXZl cnMvcGFzc3Rocm91Z2gvYW1kL3BjaV9hbWRfaW9tbXUuYworKysgYi94ZW4v ZHJpdmVycy9wYXNzdGhyb3VnaC9hbWQvcGNpX2FtZF9pb21tdS5jCkBAIC0y MTgsNiArMjE4LDggQEAgc3RhdGljIGludCBfX211c3RfY2hlY2sgYWxsb2Nh dGVfZG9tYWluXwogICAgIHJldHVybiByYzsKIH0KIAoraW50IF9fcmVhZF9t b3N0bHkgYW1kX2lvbW11X21pbl9wYWdpbmdfbW9kZSA9IDE7CisKIHN0YXRp YyBpbnQgYW1kX2lvbW11X2RvbWFpbl9pbml0KHN0cnVjdCBkb21haW4gKmQp CiB7CiAgICAgc3RydWN0IGRvbWFpbl9pb21tdSAqaGQgPSBkb21faW9tbXUo ZCk7CkBAIC0yMjksMTEgKzIzMSwxMyBAQCBzdGF0aWMgaW50IGFtZF9pb21t dV9kb21haW5faW5pdChzdHJ1Y3QKICAgICAgKiAtIEhWTSBjb3VsZCBpbiBw cmluY2lwbGUgdXNlIDMgb3IgNCBkZXBlbmRpbmcgb24gaG93IG11Y2ggZ3Vl c3QKICAgICAgKiAgIHBoeXNpY2FsIGFkZHJlc3Mgc3BhY2Ugd2UgZ2l2ZSBp dCwgYnV0IHRoaXMgaXNuJ3Qga25vd24geWV0IHNvIHVzZSA0CiAgICAgICog ICB1bmlsYXRlcmFsbHkuCisgICAgICogLSBVbml0eSBtYXBzIG1heSByZXF1 aXJlIGFuIGV2ZW4gaGlnaGVyIG51bWJlci4KICAgICAgKi8KLSAgICBoZC0+ YXJjaC5wYWdpbmdfbW9kZSA9IGFtZF9pb21tdV9nZXRfcGFnaW5nX21vZGUo Ci0gICAgICAgIGlzX2h2bV9kb21haW4oZCkKLSAgICAgICAgPyAxdWwgPDwg KERFRkFVTFRfRE9NQUlOX0FERFJFU1NfV0lEVEggLSBQQUdFX1NISUZUKQot ICAgICAgICA6IGdldF91cHBlcl9tZm5fYm91bmQoKSArIDEpOworICAgIGhk LT5hcmNoLnBhZ2luZ19tb2RlID0gbWF4KGFtZF9pb21tdV9nZXRfcGFnaW5n X21vZGUoCisgICAgICAgICAgICBpc19odm1fZG9tYWluKGQpCisgICAgICAg ICAgICA/IDF1bCA8PCAoREVGQVVMVF9ET01BSU5fQUREUkVTU19XSURUSCAt IFBBR0VfU0hJRlQpCisgICAgICAgICAgICA6IGdldF91cHBlcl9tZm5fYm91 bmQoKSArIDEpLAorICAgICAgICBhbWRfaW9tbXVfbWluX3BhZ2luZ19tb2Rl KTsKIAogICAgIHJldHVybiAwOwogfQotLS0gYS94ZW4vaW5jbHVkZS9hc20t eDg2L2h2bS9zdm0vYW1kLWlvbW11LXByb3RvLmgKKysrIGIveGVuL2luY2x1 ZGUvYXNtLXg4Ni9odm0vc3ZtL2FtZC1pb21tdS1wcm90by5oCkBAIC0xMjYs NiArMTI2LDggQEAgZXh0ZXJuIHN0cnVjdCBocGV0X3NiZGYgewogICAgIH0g aW5pdDsKIH0gaHBldF9zYmRmOwogCitleHRlcm4gaW50IGFtZF9pb21tdV9t aW5fcGFnaW5nX21vZGU7CisKIGV4dGVybiB2b2lkICpzaGFyZWRfaW50cmVt YXBfdGFibGU7CiBleHRlcm4gdW5zaWduZWQgbG9uZyAqc2hhcmVkX2ludHJl bWFwX2ludXNlOwogCg== --=separator Content-Type: application/octet-stream; name="xsa378/xsa378-4.11-7.patch" Content-Disposition: attachment; filename="xsa378/xsa378-4.11-7.patch" Content-Transfer-Encoding: base64 RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0 OiB4ODYvcDJtOiBpbnRyb2R1Y2UgcDJtX2lzX3NwZWNpYWwoKQoKU2VlaW5n IHRoZSBzaW1pbGFyaXR5IG9mIGdyYW50LCBmb3JlaWduLCBhbmQgKHN1YnNl cXVlbnRseSkgZGlyZWN0LU1NSU8KaGFuZGxpbmcsIGludHJvZHVjZSBhIG5l dyBQMk0gdHlwZSBncm91cCBuYW1lZCAic3BlY2lhbCIgKGFzIGluICJuZWVk aW5nCnNwZWNpYWwgYWNjZXNzb3JzIHRvIGNyZWF0ZS9kZXN0cm95IikuCgpB bHNvIHVzZSAtRVBFUk0gaW5zdGVhZCBvZiBvdGhlciBlcnJvciBjb2RlcyBv biB0aGUgdHdvIGRvbWFpbl9jcmFzaCgpCnBhdGhzIHRvdWNoZWQuCgpUaGlz IGlzIHBhcnQgb2YgWFNBLTM3OC4KClNpZ25lZC1vZmYtYnk6IEphbiBCZXVs aWNoIDxqYmV1bGljaEBzdXNlLmNvbT4KUmV2aWV3ZWQtYnk6IFBhdWwgRHVy cmFudCA8cGF1bEB4ZW4ub3JnPgoKLS0tIGEveGVuL2FyY2gveDg2L21tL3Ay bS5jCisrKyBiL3hlbi9hcmNoL3g4Ni9tbS9wMm0uYwpAQCAtNzM2LDcgKzcz Niw3IEBAIHAybV9yZW1vdmVfcGFnZShzdHJ1Y3QgcDJtX2RvbWFpbiAqcDJt LAogICAgICAgICBmb3IgKCBpID0gMDsgaSA8ICgxVUwgPDwgcGFnZV9vcmRl cik7IGkrKyApCiAgICAgICAgIHsKICAgICAgICAgICAgIHAybS0+Z2V0X2Vu dHJ5KHAybSwgZ2ZuX2FkZChnZm4sIGkpLCAmdCwgJmEsIDAsIE5VTEwsIE5V TEwpOwotICAgICAgICAgICAgaWYgKCAhcDJtX2lzX2dyYW50KHQpICYmICFw Mm1faXNfc2hhcmVkKHQpICYmICFwMm1faXNfZm9yZWlnbih0KSApCisgICAg ICAgICAgICBpZiAoICFwMm1faXNfc3BlY2lhbCh0KSAmJiAhcDJtX2lzX3No YXJlZCh0KSApCiAgICAgICAgICAgICAgICAgc2V0X2dwZm5fZnJvbV9tZm4o bWZuK2ksIElOVkFMSURfTTJQX0VOVFJZKTsKICAgICAgICAgfQogICAgIH0K QEAgLTg0OCwxMyArODQ4LDEzIEBAIGd1ZXN0X3BoeXNtYXBfYWRkX2VudHJ5 KHN0cnVjdCBkb21haW4gKmQKICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAmb3QsICZhLCAwLCBOVUxMLCBOVUxMKTsKICAgICAgICAgICAg IEFTU0VSVCghcDJtX2lzX3NoYXJlZChvdCkpOwogICAgICAgICB9Ci0gICAg ICAgIGlmICggcDJtX2lzX2dyYW50KG90KSB8fCBwMm1faXNfZm9yZWlnbihv dCkgKQorICAgICAgICBpZiAoIHAybV9pc19zcGVjaWFsKG90KSApCiAgICAg ICAgIHsKLSAgICAgICAgICAgIC8qIFJlYWxseSBzaG91bGRuJ3QgYmUgdW5t YXBwaW5nIGdyYW50L2ZvcmVpZ24gbWFwcyB0aGlzIHdheSAqLworICAgICAg ICAgICAgLyogRG9uJ3QgcGVybWl0IHVubWFwcGluZyBncmFudC9mb3JlaWdu IHRoaXMgd2F5LiAqLwogICAgICAgICAgICAgZG9tYWluX2NyYXNoKGQpOwog ICAgICAgICAgICAgcDJtX3VubG9jayhwMm0pOwogICAgICAgICAgICAgCi0g ICAgICAgICAgICByZXR1cm4gLUVJTlZBTDsKKyAgICAgICAgICAgIHJldHVy biAtRVBFUk07CiAgICAgICAgIH0KICAgICAgICAgZWxzZSBpZiAoIHAybV9p c19yYW0ob3QpICYmICFwMm1faXNfcGFnZWQob3QpICkKICAgICAgICAgewpA QCAtOTQ3LDggKzk0Nyw3IEBAIGludCBwMm1fY2hhbmdlX3R5cGVfb25lKHN0 cnVjdCBkb21haW4gKmQKICAgICBzdHJ1Y3QgcDJtX2RvbWFpbiAqcDJtID0g cDJtX2dldF9ob3N0cDJtKGQpOwogICAgIGludCByYzsKIAotICAgIEJVR19P TihwMm1faXNfZ3JhbnQob3QpIHx8IHAybV9pc19ncmFudChudCkpOwotICAg IEJVR19PTihwMm1faXNfZm9yZWlnbihvdCkgfHwgcDJtX2lzX2ZvcmVpZ24o bnQpKTsKKyAgICBCVUdfT04ocDJtX2lzX3NwZWNpYWwob3QpIHx8IHAybV9p c19zcGVjaWFsKG50KSk7CiAKICAgICBnZm5fbG9jayhwMm0sIGdmbiwgMCk7 CiAKQEAgLTEwOTEsMTEgKzEwOTAsMTEgQEAgc3RhdGljIGludCBzZXRfdHlw ZWRfcDJtX2VudHJ5KHN0cnVjdCBkbwogICAgICAgICBnZm5fdW5sb2NrKHAy bSwgZ2ZuLCBvcmRlcik7CiAgICAgICAgIHJldHVybiBjdXJfb3JkZXIgKyAx OwogICAgIH0KLSAgICBpZiAoIHAybV9pc19ncmFudChvdCkgfHwgcDJtX2lz X2ZvcmVpZ24ob3QpICkKKyAgICBpZiAoIHAybV9pc19zcGVjaWFsKG90KSAp CiAgICAgewogICAgICAgICBnZm5fdW5sb2NrKHAybSwgZ2ZuLCBvcmRlcik7 CiAgICAgICAgIGRvbWFpbl9jcmFzaChkKTsKLSAgICAgICAgcmV0dXJuIC1F Tk9FTlQ7CisgICAgICAgIHJldHVybiAtRVBFUk07CiAgICAgfQogICAgIGVs c2UgaWYgKCBwMm1faXNfcmFtKG90KSApCiAgICAgewotLS0gYS94ZW4vaW5j bHVkZS9hc20teDg2L3AybS5oCisrKyBiL3hlbi9pbmNsdWRlL2FzbS14ODYv cDJtLmgKQEAgLTE0Miw2ICsxNDIsMTAgQEAgdHlwZWRlZiB1bnNpZ25lZCBp bnQgcDJtX3F1ZXJ5X3Q7CiAgICAgICAgICAgICAgICAgICAgICAgICAgICAg fCBwMm1fdG9fbWFzayhwMm1fcmFtX2xvZ2RpcnR5KSApCiAjZGVmaW5lIFAy TV9TSEFSRURfVFlQRVMgICAocDJtX3RvX21hc2socDJtX3JhbV9zaGFyZWQp KQogCisvKiBUeXBlcyBlc3RhYmxpc2hlZC9jbGVhbmVkIHVwIHZpYSBzcGVj aWFsIGFjY2Vzc29ycy4gKi8KKyNkZWZpbmUgUDJNX1NQRUNJQUxfVFlQRVMg KFAyTV9HUkFOVF9UWVBFUyB8IFwKKyAgICAgICAgICAgICAgICAgICAgICAg ICAgIHAybV90b19tYXNrKHAybV9tYXBfZm9yZWlnbikpCisKIC8qIFZhbGlk IHR5cGVzIG5vdCBuZWNlc3NhcmlseSBhc3NvY2lhdGVkIHdpdGggYSAodmFs aWQpIE1GTi4gKi8KICNkZWZpbmUgUDJNX0lOVkFMSURfTUZOX1RZUEVTIChQ Mk1fUE9EX1RZUEVTICAgICAgICAgICAgICAgICAgXAogICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIHwgcDJtX3RvX21hc2socDJtX21taW9fZGly ZWN0KSBcCkBAIC0xNzAsNiArMTc0LDcgQEAgdHlwZWRlZiB1bnNpZ25lZCBp bnQgcDJtX3F1ZXJ5X3Q7CiAjZGVmaW5lIHAybV9pc19wYWdlZChfdCkgICAg KHAybV90b19tYXNrKF90KSAmIFAyTV9QQUdFRF9UWVBFUykKICNkZWZpbmUg cDJtX2lzX3NoYXJhYmxlKF90KSAocDJtX3RvX21hc2soX3QpICYgUDJNX1NI QVJBQkxFX1RZUEVTKQogI2RlZmluZSBwMm1faXNfc2hhcmVkKF90KSAgIChw Mm1fdG9fbWFzayhfdCkgJiBQMk1fU0hBUkVEX1RZUEVTKQorI2RlZmluZSBw Mm1faXNfc3BlY2lhbChfdCkgIChwMm1fdG9fbWFzayhfdCkgJiBQMk1fU1BF Q0lBTF9UWVBFUykKICNkZWZpbmUgcDJtX2lzX2Jyb2tlbihfdCkgICAocDJt X3RvX21hc2soX3QpICYgUDJNX0JST0tFTl9UWVBFUykKICNkZWZpbmUgcDJt X2lzX2ZvcmVpZ24oX3QpICAocDJtX3RvX21hc2soX3QpICYgcDJtX3RvX21h c2socDJtX21hcF9mb3JlaWduKSkKIAo= --=separator Content-Type: application/octet-stream; name="xsa378/xsa378-4.11-8.patch" Content-Disposition: attachment; filename="xsa378/xsa378-4.11-8.patch" Content-Transfer-Encoding: base64 RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0 OiB4ODYvcDJtOiBndWFyZCAoaW4gcGFydGljdWxhcikgaWRlbnRpdHkgbWFw cGluZyBlbnRyaWVzCgpTdWNoIGVudHJpZXMsIGNyZWF0ZWQgYnkgc2V0X2lk ZW50aXR5X3AybV9lbnRyeSgpLCBzaG91bGQgb25seSBiZQpkZXN0cm95ZWQg YnkgY2xlYXJfaWRlbnRpdHlfcDJtX2VudHJ5KCkuIEhvd2V2ZXIsIHNpbWls YXJseSwgZW50cmllcwpjcmVhdGVkIGJ5IHNldF9tbWlvX3AybV9lbnRyeSgp IHNob3VsZCBvbmx5IGJlIHRvcm4gZG93biBieQpjbGVhcl9tbWlvX3AybV9l bnRyeSgpLCBzbyB0aGUgbG9naWMgZ2V0cyBiYXNlZCB1cG9uIHAybV9tbWlv X2RpcmVjdCBhcwp0aGUgZW50cnkgdHlwZSAoc2VwYXJhdGlvbiBiZXR3ZWVu ICJvcmRpbmFyeSIgYW5kIDE6MSBtYXBwaW5ncyB3b3VsZApyZXF1aXJlIGEg ZnVydGhlciBpbmRpY2F0b3IgdG8gdGVsbCBhcGFydCB0aGUgdHdvKS4KCkFz IHRvIHRoZSBndWVzdF9yZW1vdmVfcGFnZSgpIGNoYW5nZSwgY29tbWl0IDQ4 ZGZiMjk3YTIwYSAoIng4Ni9QVkg6CmFsbG93IGd1ZXN0X3JlbW92ZV9wYWdl IHRvIHJlbW92ZSBwMm1fbW1pb19kaXJlY3QgcGFnZXMiKSwgd2hpY2gKaW50 cm9kdWNlZCB0aGUgY2FsbCB0byBjbGVhcl9tbWlvX3AybV9lbnRyeSgpLCBj bGFpbWVkIHRoaXMgd2FzIGRvbmUgZm9yCmh3ZG9tIG9ubHkgd2l0aG91dCB0 aGlzIGFjdHVhbGx5IGhhdmluZyBiZWVuIHRoZSBjYXNlLiBIb3dldmVyLCB0 aGlzCmNvZGUgc2hvdWxkbid0IGJlIHRoZXJlIGluIHRoZSBmaXJzdCBwbGFj ZSwgYXMgTU1JTyBlbnRyaWVzIHNob3VsZG4ndCBiZQpkcm9wcGVkIHRoaXMg d2F5LiBBdm9pZCB0cmlnZ2VyaW5nIHRoZSB3YXJuaW5nIGFnYWluIHRoYXQg NDhkZmIyOTdhMjBhCnNpbGVuY2VkIGJ5IGFuIGFkanVzdG1lbnQgdG8geGVu bWVtX2FkZF90b19waHlzbWFwX29uZSgpIGluc3RlYWQuCgpOb3RlIHRoYXQg Z3Vlc3RfcGh5c21hcF9tYXJrX3BvcHVsYXRlX29uX2RlbWFuZCgpIGdldHMg dGlnaHRlbmVkIGJleW9uZAp0aGUgaW1tZWRpYXRlIHB1cnBvc2Ugb2YgdGhp cyBjaGFuZ2UuCgpOb3RlIGFsc28gdGhhdCBJIGRpZG4ndCBpbnNwZWN0IGNv ZGUgd2hpY2ggaXNuJ3Qgc2VjdXJpdHkgc3VwcG9ydGVkLAplLmcuIHNoYXJp bmcsIHBhZ2luZywgb3IgYWx0cDJtLgoKVGhpcyBpcyBDVkUtMjAyMS0yODY5 NCAvIHBhcnQgb2YgWFNBLTM3OC4KClNpZ25lZC1vZmYtYnk6IEphbiBCZXVs aWNoIDxqYmV1bGljaEBzdXNlLmNvbT4KUmV2aWV3ZWQtYnk6IFBhdWwgRHVy cmFudCA8cGF1bEB4ZW4ub3JnPgoKLS0tIGEveGVuL2FyY2gveDg2L21tLmMK KysrIGIveGVuL2FyY2gveDg2L21tLmMKQEAgLTQ3ODMsNyArNDc4Myw5IEBA IGludCB4ZW5tZW1fYWRkX3RvX3BoeXNtYXBfb25lKAogCiAgICAgLyogUmVt b3ZlIHByZXZpb3VzbHkgbWFwcGVkIHBhZ2UgaWYgaXQgd2FzIHByZXNlbnQu ICovCiAgICAgcHJldl9tZm4gPSBtZm5feChnZXRfZ2ZuKGQsIGdmbl94KGdw Zm4pLCAmcDJtdCkpOwotICAgIGlmICggbWZuX3ZhbGlkKF9tZm4ocHJldl9t Zm4pKSApCisgICAgaWYgKCBwMm10ID09IHAybV9tbWlvX2RpcmVjdCApCisg ICAgICAgIHJjID0gLUVQRVJNOworICAgIGVsc2UgaWYgKCBtZm5fdmFsaWQo X21mbihwcmV2X21mbikpICkKICAgICB7CiAgICAgICAgIGlmICggaXNfeGVu X2hlYXBfbWZuKHByZXZfbWZuKSApCiAgICAgICAgICAgICAvKiBYZW4gaGVh cCBmcmFtZXMgYXJlIHNpbXBseSB1bmhvb2tlZCBmcm9tIHRoaXMgcGh5cyBz bG90LiAqLwotLS0gYS94ZW4vYXJjaC94ODYvbW0vcDJtLmMKKysrIGIveGVu L2FyY2gveDg2L21tL3AybS5jCkBAIC03MjUsNyArNzI1LDggQEAgcDJtX3Jl bW92ZV9wYWdlKHN0cnVjdCBwMm1fZG9tYWluICpwMm0sCiAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAmY3VyX29yZGVyLCBO VUxMKTsKIAogICAgICAgICBpZiAoIHAybV9pc192YWxpZCh0KSAmJgotICAg ICAgICAgICAgICghbWZuX3ZhbGlkKF9tZm4obWZuKSkgfHwgbWZuICsgaSAh PSBtZm5feChtZm5fcmV0dXJuKSkgKQorICAgICAgICAgICAgICghbWZuX3Zh bGlkKF9tZm4obWZuKSkgfHwgdCA9PSBwMm1fbW1pb19kaXJlY3QgfHwKKyAg ICAgICAgICAgICAgbWZuICsgaSAhPSBtZm5feChtZm5fcmV0dXJuKSkgKQog ICAgICAgICAgICAgcmV0dXJuIC1FSUxTRVE7CiAKICAgICAgICAgaSArPSAo MVVMIDw8IGN1cl9vcmRlcikgLSAoKGdmbl9sICsgaSkgJiAoKDFVTCA8PCBj dXJfb3JkZXIpIC0gMSkpOwpAQCAtODAzLDcgKzgwNCw3IEBAIGd1ZXN0X3Bo eXNtYXBfYWRkX2VudHJ5KHN0cnVjdCBkb21haW4gKmQKICAgICBpZiAoIHAy bV9pc19mb3JlaWduKHQpICkKICAgICAgICAgcmV0dXJuIC1FSU5WQUw7CiAK LSAgICBpZiAoICFtZm5fdmFsaWQobWZuKSApCisgICAgaWYgKCAhbWZuX3Zh bGlkKG1mbikgfHwgdCA9PSBwMm1fbW1pb19kaXJlY3QgKQogICAgIHsKICAg ICAgICAgQVNTRVJUX1VOUkVBQ0hBQkxFKCk7CiAgICAgICAgIHJldHVybiAt RUlOVkFMOwpAQCAtODUwLDcgKzg1MSw3IEBAIGd1ZXN0X3BoeXNtYXBfYWRk X2VudHJ5KHN0cnVjdCBkb21haW4gKmQKICAgICAgICAgfQogICAgICAgICBp ZiAoIHAybV9pc19zcGVjaWFsKG90KSApCiAgICAgICAgIHsKLSAgICAgICAg ICAgIC8qIERvbid0IHBlcm1pdCB1bm1hcHBpbmcgZ3JhbnQvZm9yZWlnbiB0 aGlzIHdheS4gKi8KKyAgICAgICAgICAgIC8qIERvbid0IHBlcm1pdCB1bm1h cHBpbmcgZ3JhbnQvZm9yZWlnbi9kaXJlY3QtTU1JTyB0aGlzIHdheS4gKi8K ICAgICAgICAgICAgIGRvbWFpbl9jcmFzaChkKTsKICAgICAgICAgICAgIHAy bV91bmxvY2socDJtKTsKICAgICAgICAgICAgIApAQCAtMTE5Miw4ICsxMTkz LDggQEAgaW50IHNldF9pZGVudGl0eV9wMm1fZW50cnkoc3RydWN0IGRvbWFp bgogICogICAgb3JkZXIrMSAgZm9yIGNhbGxlciB0byByZXRyeSB3aXRoIG9y ZGVyIChndWFyYW50ZWVkIHNtYWxsZXIgdGhhbgogICogICAgICAgICAgICAg dGhlIG9yZGVyIHZhbHVlIHBhc3NlZCBpbikKICAqLwotaW50IGNsZWFyX21t aW9fcDJtX2VudHJ5KHN0cnVjdCBkb21haW4gKmQsIHVuc2lnbmVkIGxvbmcg Z2ZuX2wsIG1mbl90IG1mbiwKLSAgICAgICAgICAgICAgICAgICAgICAgICB1 bnNpZ25lZCBpbnQgb3JkZXIpCitzdGF0aWMgaW50IGNsZWFyX21taW9fcDJt X2VudHJ5KHN0cnVjdCBkb21haW4gKmQsIHVuc2lnbmVkIGxvbmcgZ2ZuX2ws CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIG1mbl90IG1mbiwg dW5zaWduZWQgaW50IG9yZGVyKQogewogICAgIGludCByYyA9IC1FSU5WQUw7 CiAgICAgZ2ZuX3QgZ2ZuID0gX2dmbihnZm5fbCk7Ci0tLSBhL3hlbi9hcmNo L3g4Ni9tbS9wMm0tcG9kLmMKKysrIGIveGVuL2FyY2gveDg2L21tL3AybS1w b2QuYwpAQCAtMTMwMiwxNyArMTMwMiwxNyBAQCBndWVzdF9waHlzbWFwX21h cmtfcG9wdWxhdGVfb25fZGVtYW5kKHN0CiAKICAgICAgICAgcDJtLT5nZXRf ZW50cnkocDJtLCBnZm5fYWRkKGdmbiwgaSksICZvdCwgJmEsIDAsICZjdXJf b3JkZXIsIE5VTEwpOwogICAgICAgICBuID0gMVVMIDw8IG1pbihvcmRlciwg Y3VyX29yZGVyKTsKLSAgICAgICAgaWYgKCBwMm1faXNfcmFtKG90KSApCisg ICAgICAgIGlmICggb3QgPT0gcDJtX3BvcHVsYXRlX29uX2RlbWFuZCApCisg ICAgICAgIHsKKyAgICAgICAgICAgIC8qIENvdW50IGhvdyBtYW55IFBvRCBl bnRyaWVzIHdlJ2xsIGJlIHJlcGxhY2luZyBpZiBzdWNjZXNzZnVsICovCisg ICAgICAgICAgICBwb2RfY291bnQgKz0gbjsKKyAgICAgICAgfQorICAgICAg ICBlbHNlIGlmICggb3QgIT0gcDJtX2ludmFsaWQgJiYgb3QgIT0gcDJtX21t aW9fZG0gKQogICAgICAgICB7CiAgICAgICAgICAgICBQMk1fREVCVUcoImdm bl90b19tZm4gcmV0dXJuZWQgdHlwZSAlZCFcbiIsIG90KTsKICAgICAgICAg ICAgIHJjID0gLUVCVVNZOwogICAgICAgICAgICAgZ290byBvdXQ7CiAgICAg ICAgIH0KLSAgICAgICAgZWxzZSBpZiAoIG90ID09IHAybV9wb3B1bGF0ZV9v bl9kZW1hbmQgKQotICAgICAgICB7Ci0gICAgICAgICAgICAvKiBDb3VudCBo b3cgbWFuIFBvRCBlbnRyaWVzIHdlJ2xsIGJlIHJlcGxhY2luZyBpZiBzdWNj ZXNzZnVsICovCi0gICAgICAgICAgICBwb2RfY291bnQgKz0gbjsKLSAgICAg ICAgfQogICAgIH0KIAogICAgIC8qIE5vdywgYWN0dWFsbHkgZG8gdGhlIHR3 by13YXkgbWFwcGluZyAqLwotLS0gYS94ZW4vY29tbW9uL21lbW9yeS5jCisr KyBiL3hlbi9jb21tb24vbWVtb3J5LmMKQEAgLTMzNSw3ICszMzUsNyBAQCBp bnQgZ3Vlc3RfcmVtb3ZlX3BhZ2Uoc3RydWN0IGRvbWFpbiAqZCwKICAgICB9 CiAgICAgaWYgKCBwMm10ID09IHAybV9tbWlvX2RpcmVjdCApCiAgICAgewot ICAgICAgICByYyA9IGNsZWFyX21taW9fcDJtX2VudHJ5KGQsIGdtZm4sIG1m biwgUEFHRV9PUkRFUl80Syk7CisgICAgICAgIHJjID0gLUVQRVJNOwogICAg ICAgICBnb3RvIG91dF9wdXRfZ2ZuOwogICAgIH0KICNlbHNlCkBAIC0xNjUx LDYgKzE2NTEsMTUgQEAgaW50IHByZXBhcmVfcmluZ19mb3JfaGVscGVyKAog ICAgICAgICByZXR1cm4gLUVOT0VOVDsKICAgICB9CiAjZW5kaWYKKyNpZmRl ZiBDT05GSUdfWDg2CisgICAgaWYgKCBwMm10ID09IHAybV9tbWlvX2RpcmVj dCApCisgICAgeworICAgICAgICBpZiAoIHBhZ2UgKQorICAgICAgICAgICAg cHV0X3BhZ2UocGFnZSk7CisKKyAgICAgICAgcmV0dXJuIC1FUEVSTTsKKyAg ICB9CisjZW5kaWYKIAogICAgIGlmICggIXBhZ2UgKQogICAgICAgICByZXR1 cm4gLUVJTlZBTDsKLS0tIGEveGVuL2luY2x1ZGUvYXNtLXg4Ni9wMm0uaAor KysgYi94ZW4vaW5jbHVkZS9hc20teDg2L3AybS5oCkBAIC0xNDQsNyArMTQ0 LDggQEAgdHlwZWRlZiB1bnNpZ25lZCBpbnQgcDJtX3F1ZXJ5X3Q7CiAKIC8q IFR5cGVzIGVzdGFibGlzaGVkL2NsZWFuZWQgdXAgdmlhIHNwZWNpYWwgYWNj ZXNzb3JzLiAqLwogI2RlZmluZSBQMk1fU1BFQ0lBTF9UWVBFUyAoUDJNX0dS QU5UX1RZUEVTIHwgXAotICAgICAgICAgICAgICAgICAgICAgICAgICAgcDJt X3RvX21hc2socDJtX21hcF9mb3JlaWduKSkKKyAgICAgICAgICAgICAgICAg ICAgICAgICAgIHAybV90b19tYXNrKHAybV9tYXBfZm9yZWlnbikgfCBcCisg ICAgICAgICAgICAgICAgICAgICAgICAgICBwMm1fdG9fbWFzayhwMm1fbW1p b19kaXJlY3QpKQogCiAvKiBWYWxpZCB0eXBlcyBub3QgbmVjZXNzYXJpbHkg YXNzb2NpYXRlZCB3aXRoIGEgKHZhbGlkKSBNRk4uICovCiAjZGVmaW5lIFAy TV9JTlZBTElEX01GTl9UWVBFUyAoUDJNX1BPRF9UWVBFUyAgICAgICAgICAg ICAgICAgIFwKQEAgLTYyOSw4ICs2MzAsNiBAQCBpbnQgc2V0X2ZvcmVpZ25f cDJtX2VudHJ5KHN0cnVjdCBkb21haW4KIC8qIFNldCBtbWlvIGFkZHJlc3Nl cyBpbiB0aGUgcDJtIHRhYmxlIChmb3IgcGFzcy10aHJvdWdoKSAqLwogaW50 IHNldF9tbWlvX3AybV9lbnRyeShzdHJ1Y3QgZG9tYWluICpkLCB1bnNpZ25l ZCBsb25nIGdmbiwgbWZuX3QgbWZuLAogICAgICAgICAgICAgICAgICAgICAg ICB1bnNpZ25lZCBpbnQgb3JkZXIsIHAybV9hY2Nlc3NfdCBhY2Nlc3MpOwot aW50IGNsZWFyX21taW9fcDJtX2VudHJ5KHN0cnVjdCBkb21haW4gKmQsIHVu c2lnbmVkIGxvbmcgZ2ZuLCBtZm5fdCBtZm4sCi0gICAgICAgICAgICAgICAg ICAgICAgICAgdW5zaWduZWQgaW50IG9yZGVyKTsKIAogLyogU2V0IGlkZW50 aXR5IGFkZHJlc3NlcyBpbiB0aGUgcDJtIHRhYmxlIChmb3IgcGFzcy10aHJv dWdoKSAqLwogaW50IHNldF9pZGVudGl0eV9wMm1fZW50cnkoc3RydWN0IGRv bWFpbiAqZCwgdW5zaWduZWQgbG9uZyBnZm4sCg== --=separator Content-Type: application/octet-stream; name="xsa378/xsa378-4.12-0a.patch" Content-Disposition: attachment; filename="xsa378/xsa378-4.12-0a.patch" Content-Transfer-Encoding: base64 RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0 OiB4ODYvcDJtOiBmaXggUG9EIGFjY291bnRpbmcgaW4gZ3Vlc3RfcGh5c21h cF9hZGRfZW50cnkoKQoKVGhlIGluaXRpYWwgb2JzZXJ2YXRpb24gd2FzIHRo YXQgdGhlIG1mbl92YWxpZCgpIGNoZWNrIGNvbWVzIHRvbyBsYXRlOgpOZWl0 aGVyIG1mbl9hZGQoKSBub3IgbWZuX3RvX3BhZ2UoKSAobGV0IGFsb25lIGRl LXJlZmVyZW5jaW5nIHRoZQpyZXN1bHQgb2YgdGhlIGxhdHRlcikgYXJlIHZh bGlkIGZvciBNRk5zIGZhaWxpbmcgdGhpcyBjaGVjay4gTW92ZSBpdCB1cAph bmQgLSBub3RpY2luZyB0aGF0IHRoZXJlJ3Mgbm8gY2FsbGVyIGRvaW5nIHNv IC0gYWxzbyBhZGQgYW4gYXNzZXJ0aW9uCnRoYXQgdGhpcyBzaG91bGQgbmV2 ZXIgcHJvZHVjZSAiZmFsc2UiIGhlcmUuCgpJbiB0dXJuIHRoaXMgd291bGQg aGF2ZSBtZWFudCB0aGF0IHRoZSAiZWxzZSIgdG8gdGhhdCBpZigpIGNvdWxk IG5vdyBnbwphd2F5LCB3aGljaCBkaWRuJ3Qgc2VlbSByaWdodCBhdCBhbGwu IEFuZCBpbmRlZWQsIGNvbnNpZGVyaW5nIGNhbGxlcnMKbGlrZSBtZW1vcnlf ZXhjaGFuZ2UoKSBvciB2YXJpb3VzIGdyYW50IHRhYmxlIGZ1bmN0aW9ucywg dGhlIFBvRAphY2NvdW50aW5nIHNob3VsZCBoYXZlIGJlZW4gb3V0c2lkZSBv ZiB0aGF0IGlmKCkgZnJvbSB0aGUgdmVyeQpiZWdpbm5pbmcuCgpTaWduZWQt b2ZmLWJ5OiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+CkFja2Vk LWJ5OiBBbmRyZXcgQ29vcGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29t PgoKLS0tIGEveGVuL2FyY2gveDg2L21tL3AybS5jCisrKyBiL3hlbi9hcmNo L3g4Ni9tbS9wMm0uYwpAQCAtODY0LDYgKzg2NCwxMiBAQCBndWVzdF9waHlz bWFwX2FkZF9lbnRyeShzdHJ1Y3QgZG9tYWluICpkCiAgICAgaWYgKCBwMm1f aXNfZm9yZWlnbih0KSApCiAgICAgICAgIHJldHVybiAtRUlOVkFMOwogCisg ICAgaWYgKCAhbWZuX3ZhbGlkKG1mbikgKQorICAgIHsKKyAgICAgICAgQVNT RVJUX1VOUkVBQ0hBQkxFKCk7CisgICAgICAgIHJldHVybiAtRUlOVkFMOwor ICAgIH0KKwogICAgIHAybV9sb2NrKHAybSk7CiAKICAgICBQMk1fREVCVUco ImFkZGluZyBnZm49JSNseCBtZm49JSNseFxuIiwgZ2ZuX3goZ2ZuKSwgbWZu X3gobWZuKSk7CkBAIC05NjMsMTIgKzk2OSwxNSBAQCBndWVzdF9waHlzbWFw X2FkZF9lbnRyeShzdHJ1Y3QgZG9tYWluICpkCiAgICAgfQogCiAgICAgLyog Tm93LCBhY3R1YWxseSBkbyB0aGUgdHdvLXdheSBtYXBwaW5nICovCi0gICAg aWYgKCBtZm5fdmFsaWQobWZuKSApCisgICAgcmMgPSBwMm1fc2V0X2VudHJ5 KHAybSwgZ2ZuLCBtZm4sIHBhZ2Vfb3JkZXIsIHQsIHAybS0+ZGVmYXVsdF9h Y2Nlc3MpOworICAgIGlmICggcmMgPT0gMCApCiAgICAgewotICAgICAgICBy YyA9IHAybV9zZXRfZW50cnkocDJtLCBnZm4sIG1mbiwgcGFnZV9vcmRlciwg dCwKLSAgICAgICAgICAgICAgICAgICAgICAgICAgIHAybS0+ZGVmYXVsdF9h Y2Nlc3MpOwotICAgICAgICBpZiAoIHJjICkKLSAgICAgICAgICAgIGdvdG8g b3V0OyAvKiBGYWlsZWQgdG8gdXBkYXRlIHAybSwgYmFpbCB3aXRob3V0IHVw ZGF0aW5nIG0ycC4gKi8KKyNpZmRlZiBDT05GSUdfSFZNCisgICAgICAgIHBv ZF9sb2NrKHAybSk7CisgICAgICAgIHAybS0+cG9kLmVudHJ5X2NvdW50IC09 IHBvZF9jb3VudDsKKyAgICAgICAgQlVHX09OKHAybS0+cG9kLmVudHJ5X2Nv dW50IDwgMCk7CisgICAgICAgIHBvZF91bmxvY2socDJtKTsKKyNlbmRpZgog CiAgICAgICAgIGlmICggIXAybV9pc19ncmFudCh0KSApCiAgICAgICAgIHsK QEAgLTk3NywyNCArOTg2LDcgQEAgZ3Vlc3RfcGh5c21hcF9hZGRfZW50cnko c3RydWN0IGRvbWFpbiAqZAogICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIGdmbl94KGdmbl9hZGQoZ2ZuLCBpKSkpOwogICAgICAgICB9CiAg ICAgfQotICAgIGVsc2UKLSAgICB7Ci0gICAgICAgIGdkcHJpbnRrKFhFTkxP R19XQVJOSU5HLCAiQWRkaW5nIGJhZCBtZm4gdG8gcDJtIG1hcCAoJSNseCAt PiAlI2x4KVxuIiwKLSAgICAgICAgICAgICAgICAgZ2ZuX3goZ2ZuKSwgbWZu X3gobWZuKSk7Ci0gICAgICAgIHJjID0gcDJtX3NldF9lbnRyeShwMm0sIGdm biwgSU5WQUxJRF9NRk4sIHBhZ2Vfb3JkZXIsCi0gICAgICAgICAgICAgICAg ICAgICAgICAgICBwMm1faW52YWxpZCwgcDJtLT5kZWZhdWx0X2FjY2Vzcyk7 Ci0jaWZkZWYgQ09ORklHX0hWTQotICAgICAgICBpZiAoIHJjID09IDAgKQot ICAgICAgICB7Ci0gICAgICAgICAgICBwb2RfbG9jayhwMm0pOwotICAgICAg ICAgICAgcDJtLT5wb2QuZW50cnlfY291bnQgLT0gcG9kX2NvdW50OwotICAg ICAgICAgICAgQlVHX09OKHAybS0+cG9kLmVudHJ5X2NvdW50IDwgMCk7Ci0g ICAgICAgICAgICBwb2RfdW5sb2NrKHAybSk7Ci0gICAgICAgIH0KLSNlbmRp ZgotICAgIH0KIAotb3V0OgogICAgIHAybV91bmxvY2socDJtKTsKIAogICAg IHJldHVybiByYzsK --=separator Content-Type: application/octet-stream; name="xsa378/xsa378-4.12-0b.patch" Content-Disposition: attachment; filename="xsa378/xsa378-4.12-0b.patch" Content-Transfer-Encoding: base64 RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0 OiB4ODYvcDJtOiBkb24ndCBpZ25vcmUgcDJtX3JlbW92ZV9wYWdlKCkncyBy ZXR1cm4gdmFsdWUKCkl0J3Mgbm90IHZlcnkgbmljZSB0byByZXR1cm4gZnJv bSBndWVzdF9waHlzbWFwX2FkZF9lbnRyeSgpIGFmdGVyCnBlcmhhcHMgYWxy ZWFkeSBoYXZpbmcgbWFkZSBzb21lIGNoYW5nZXMgdG8gdGhlIFAyTSwgYnV0 IHRoaXMgaXMgcHJlLQpleGlzdGluZyBwcmFjdGljZSBpbiB0aGUgZnVuY3Rp b24sIGFuZCBpbW8gYmV0dGVyIHRoYW4gaWdub3JpbmcgZXJyb3JzLgoKVGFr ZSB0aGUgbGliZXJ0eSBhbmQgcmVwbGFjZSBhbiBtZm5fYWRkKCkgaW5zdGFu Y2Ugd2l0aCBhIGxvY2FsIHZhcmlhYmxlCmFscmVhZHkgaG9sZGluZyB0aGUg cmVzdWx0IChhcyBwcm92ZW4gYnkgdGhlIGNoZWNrIGltbWVkaWF0ZWx5IGFo ZWFkKS4KClNpZ25lZC1vZmYtYnk6IEphbiBCZXVsaWNoIDxqYmV1bGljaEBz dXNlLmNvbT4KUmV2aWV3ZWQtYnk6IFBhdWwgRHVycmFudCA8cGF1bC5kdXJy YW50QGNpdHJpeC5jb20+CkFja2VkLWJ5OiBBbmRyZXcgQ29vcGVyIDxhbmRy ZXcuY29vcGVyM0BjaXRyaXguY29tPgoKLS0tIGEveGVuL2FyY2gveDg2L21t L3AybS5jCisrKyBiL3hlbi9hcmNoL3g4Ni9tbS9wMm0uYwpAQCAtNzcyLDgg Kzc3Miw3IEBAIHZvaWQgcDJtX2ZpbmFsX3RlYXJkb3duKHN0cnVjdCBkb21h aW4gKmQKICAgICBwMm1fdGVhcmRvd25faG9zdHAybShkKTsKIH0KIAotCi1z dGF0aWMgaW50CitzdGF0aWMgaW50IF9fbXVzdF9jaGVjawogcDJtX3JlbW92 ZV9wYWdlKHN0cnVjdCBwMm1fZG9tYWluICpwMm0sIHVuc2lnbmVkIGxvbmcg Z2ZuX2wsIHVuc2lnbmVkIGxvbmcgbWZuLAogICAgICAgICAgICAgICAgIHVu c2lnbmVkIGludCBwYWdlX29yZGVyKQogewpAQCAtOTYxLDkgKzk2MCw5IEBA IGd1ZXN0X3BoeXNtYXBfYWRkX2VudHJ5KHN0cnVjdCBkb21haW4gKmQKICAg ICAgICAgICAgICAgICBBU1NFUlQobWZuX3ZhbGlkKG9tZm4pKTsKICAgICAg ICAgICAgICAgICBQMk1fREVCVUcoIm9sZCBnZm49JSNseCAtPiBtZm4gJSNs eFxuIiwKICAgICAgICAgICAgICAgICAgICAgICAgICAgZ2ZuX3gob2dmbikg LCBtZm5feChvbWZuKSk7Ci0gICAgICAgICAgICAgICAgaWYgKCBtZm5fZXEo b21mbiwgbWZuX2FkZChtZm4sIGkpKSApCi0gICAgICAgICAgICAgICAgICAg IHAybV9yZW1vdmVfcGFnZShwMm0sIGdmbl94KG9nZm4pLCBtZm5feChtZm5f YWRkKG1mbiwgaSkpLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgMCk7CisgICAgICAgICAgICAgICAgaWYgKCBtZm5fZXEob21mbiwg bWZuX2FkZChtZm4sIGkpKSAmJgorICAgICAgICAgICAgICAgICAgICAgKHJj ID0gcDJtX3JlbW92ZV9wYWdlKHAybSwgZ2ZuX3gob2dmbiksIG1mbl94KG9t Zm4pLCAwKSkgKQorICAgICAgICAgICAgICAgICAgICBnb3RvIG91dDsKICAg ICAgICAgICAgIH0KICAgICAgICAgfQogICAgIH0KQEAgLTk4Nyw2ICs5ODYs NyBAQCBndWVzdF9waHlzbWFwX2FkZF9lbnRyeShzdHJ1Y3QgZG9tYWluICpk CiAgICAgICAgIH0KICAgICB9CiAKKyBvdXQ6CiAgICAgcDJtX3VubG9jayhw Mm0pOwogCiAgICAgcmV0dXJuIHJjOwpAQCAtMjY0Niw5ICsyNjQ2LDkgQEAg aW50IHAybV9jaGFuZ2VfYWx0cDJtX2dmbihzdHJ1Y3QgZG9tYWluCiAKICAg ICBpZiAoIGdmbl9lcShuZXdfZ2ZuLCBJTlZBTElEX0dGTikgKQogICAgIHsK LSAgICAgICAgaWYgKCBtZm5fdmFsaWQobWZuKSApCi0gICAgICAgICAgICBw Mm1fcmVtb3ZlX3BhZ2UoYXAybSwgZ2ZuX3gob2xkX2dmbiksIG1mbl94KG1m biksIFBBR0VfT1JERVJfNEspOwotICAgICAgICByYyA9IDA7CisgICAgICAg IHJjID0gbWZuX3ZhbGlkKG1mbikKKyAgICAgICAgICAgICA/IHAybV9yZW1v dmVfcGFnZShhcDJtLCBnZm5feChvbGRfZ2ZuKSwgbWZuX3gobWZuKSwgUEFH RV9PUkRFUl80SykKKyAgICAgICAgICAgICA6IDA7CiAgICAgICAgIGdvdG8g b3V0OwogICAgIH0KIAo= --=separator Content-Type: application/octet-stream; name="xsa378/xsa378-4.12-0c.patch" Content-Disposition: attachment; filename="xsa378/xsa378-4.12-0c.patch" Content-Transfer-Encoding: base64 RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0 OiB4ODYvcDJtOiBkb24ndCBhc3NlcnQgdGhhdCB0aGUgcGFzc2VkIGluIE1G TiBtYXRjaGVzIGZvciBhIHJlbW92ZQoKZ3Vlc3RfcGh5c21hcF9yZW1vdmVf cGFnZSgpIGdldHMgaGFuZGVkIGFuIE1GTiBmcm9tIHRoZSBvdXRzaWRlLCB5 ZXQKdGFrZXMgdGhlIG5lY2Vzc2FyeSBsb2NrIHRvIHByZXZlbnQgZnVydGhl ciBjaGFuZ2VzIHRvIHRoZSBHRk4gPC0+IE1GTgptYXBwaW5nIGl0c2VsZi4g V2hpbGUgc29tZSBjYWxsZXJzLCBpbiBwYXJ0aWN1bGFyIGd1ZXN0X3JlbW92 ZV9wYWdlKCkKKGJ5IHdheSBvZiBoYXZpbmcgY2FsbGVkIGdldF9nZm5fcXVl cnkoKSksIGhvbGQgdGhlIEdGTiBsb2NrIGFscmVhZHksCnZhcmlvdXMgb3Ro ZXJzIChtb3N0IG5vdGFibHkgcGVyaGFwcyB0aGUgMm5kIGluc3RhbmNlIGlu Cnhlbm1lbV9hZGRfdG9fcGh5c21hcF9vbmUoKSkgZG9uJ3QuIFdoaWxlIGl0 IGFsc28gaXMgYW4gb3B0aW9uIHRvIGZpeAphbGwgdGhlIGNhbGxlcnMsIGRl YWwgd2l0aCB0aGUgaXNzdWUgaW4gcDJtX3JlbW92ZV9wYWdlKCkgaW5zdGVh ZDoKUmVwbGFjZSB0aGUgQVNTRVJUKCkgYnkgYSBjb25kaXRpb25hbCBhbmQg c3BsaXQgdGhlIGxvb3AgaW50byB0d28sIHN1Y2gKdGhhdCBhbGwgY2hlY2tp bmcgZ2V0cyBkb25lIGJlZm9yZSBhbnkgbW9kaWZpY2F0aW9uIHdvdWxkIG9j Y3VyLgoKU2lnbmVkLW9mZi1ieTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1 c2UuY29tPgpSZXZpZXdlZC1ieTogUGF1bCBEdXJyYW50IDxwYXVsLmR1cnJh bnRAY2l0cml4LmNvbT4KQWNrZWQtYnk6IEFuZHJldyBDb29wZXIgPGFuZHJl dy5jb29wZXIzQGNpdHJpeC5jb20+CgotLS0gYS94ZW4vYXJjaC94ODYvbW0v cDJtLmMKKysrIGIveGVuL2FyY2gveDg2L21tL3AybS5jCkBAIC03NzgsNyAr Nzc4LDYgQEAgcDJtX3JlbW92ZV9wYWdlKHN0cnVjdCBwMm1fZG9tYWluICpw Mm0sCiB7CiAgICAgdW5zaWduZWQgbG9uZyBpOwogICAgIGdmbl90IGdmbiA9 IF9nZm4oZ2ZuX2wpOwotICAgIG1mbl90IG1mbl9yZXR1cm47CiAgICAgcDJt X3R5cGVfdCB0OwogICAgIHAybV9hY2Nlc3NfdCBhOwogCkBAIC03ODksMTUg Kzc4OCwyNiBAQCBwMm1fcmVtb3ZlX3BhZ2Uoc3RydWN0IHAybV9kb21haW4g KnAybSwKICAgICBBU1NFUlQoZ2ZuX2xvY2tlZF9ieV9tZShwMm0sIGdmbikp OwogICAgIFAyTV9ERUJVRygicmVtb3ZpbmcgZ2ZuPSUjbHggbWZuPSUjbHhc biIsIGdmbl9sLCBtZm4pOwogCisgICAgZm9yICggaSA9IDA7IGkgPCAoMVVM IDw8IHBhZ2Vfb3JkZXIpOyApCisgICAgeworICAgICAgICB1bnNpZ25lZCBp bnQgY3VyX29yZGVyOworICAgICAgICBtZm5fdCBtZm5fcmV0dXJuID0gcDJt LT5nZXRfZW50cnkocDJtLCBnZm5fYWRkKGdmbiwgaSksICZ0LCAmYSwgMCwK KyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICZj dXJfb3JkZXIsIE5VTEwpOworCisgICAgICAgIGlmICggcDJtX2lzX3ZhbGlk KHQpICYmCisgICAgICAgICAgICAgKCFtZm5fdmFsaWQoX21mbihtZm4pKSB8 fCBtZm4gKyBpICE9IG1mbl94KG1mbl9yZXR1cm4pKSApCisgICAgICAgICAg ICByZXR1cm4gLUVJTFNFUTsKKworICAgICAgICBpICs9ICgxVUwgPDwgY3Vy X29yZGVyKSAtICgoZ2ZuX2wgKyBpKSAmICgoMVVMIDw8IGN1cl9vcmRlcikg LSAxKSk7CisgICAgfQorCiAgICAgaWYgKCBtZm5fdmFsaWQoX21mbihtZm4p KSApCiAgICAgewogICAgICAgICBmb3IgKCBpID0gMDsgaSA8ICgxVUwgPDwg cGFnZV9vcmRlcik7IGkrKyApCiAgICAgICAgIHsKLSAgICAgICAgICAgIG1m bl9yZXR1cm4gPSBwMm0tPmdldF9lbnRyeShwMm0sIGdmbl9hZGQoZ2ZuLCBp KSwgJnQsICZhLCAwLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIE5VTEwsIE5VTEwpOworICAgICAgICAgICAgcDJtLT5nZXRf ZW50cnkocDJtLCBnZm5fYWRkKGdmbiwgaSksICZ0LCAmYSwgMCwgTlVMTCwg TlVMTCk7CiAgICAgICAgICAgICBpZiAoICFwMm1faXNfZ3JhbnQodCkgJiYg IXAybV9pc19zaGFyZWQodCkgJiYgIXAybV9pc19mb3JlaWduKHQpICkKICAg ICAgICAgICAgICAgICBzZXRfZ3Bmbl9mcm9tX21mbihtZm4raSwgSU5WQUxJ RF9NMlBfRU5UUlkpOwotICAgICAgICAgICAgQVNTRVJUKCAhcDJtX2lzX3Zh bGlkKHQpIHx8IG1mbiArIGkgPT0gbWZuX3gobWZuX3JldHVybikgKTsKICAg ICAgICAgfQogICAgIH0KICAgICByZXR1cm4gcDJtX3NldF9lbnRyeShwMm0s IGdmbiwgSU5WQUxJRF9NRk4sIHBhZ2Vfb3JkZXIsIHAybV9pbnZhbGlkLAo= --=separator Content-Type: application/octet-stream; name="xsa378/xsa378-4.12-1.patch" Content-Disposition: attachment; filename="xsa378/xsa378-4.12-1.patch" Content-Transfer-Encoding: base64 RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0 OiBBTUQvSU9NTVU6IGNvcnJlY3QgZ2xvYmFsIGV4Y2x1c2lvbiByYW5nZSBl eHRlbmRpbmcKCkJlc2lkZXMgdW5pdHkgbWFwcGluZyByZWdpb25zLCB0aGUg QU1EIElPTU1VIHNwZWMgYWxzbyBwcm92aWRlcyBmb3IKZXhjbHVzaW9uIHJh bmdlcyAoYXJlYXMgb2YgbWVtb3J5IG5vdCB0byBiZSBzdWJqZWN0IHRvIERN QSB0cmFuc2xhdGlvbikKdG8gYmUgc3BlY2lmaWVkIGJ5IGZpcm13YXJlIGlu IHRoZSBBQ1BJIHRhYmxlcy4gVGhlIHNwZWMgZG9lcyBub3QgcHV0CmFueSBj b25zdHJhaW50cyBvbiB0aGUgbnVtYmVyIG9mIHN1Y2ggcmVnaW9ucy4KCkJs aW5kbHkgYXNzdW1pbmcgYWxsIGFkZHJlc3NlcyBiZXR3ZWVuIGFueSB0d28g c3VjaCByYW5nZXMgc2hvdWxkIGFsc28KYmUgZXhjbHVkZWQgY2FuJ3QgYmUg cmlnaHQuIFNpbmNlIGhhcmR3YXJlIGhhcyByb29tIGZvciBqdXN0IGEgc2lu Z2xlCnN1Y2ggcmFuZ2UgKGNvbXByaXNlZCBvZiB0aGUgRXhjbHVzaW9uIEJh c2UgUmVnaXN0ZXIgYW5kIHRoZSBFeGNsdXNpb24KUmFuZ2UgTGltaXQgUmVn aXN0ZXIpLCBjb21iaW5lIG9ubHkgYWRqYWNlbnQgb3Igb3ZlcmxhcHBpbmcg cmVnaW9ucyAoZm9yCm5vdzsgdGhpcyBtYXkgcmVxdWlyZSBmdXJ0aGVyIGFk anVzdG1lbnQgaW4gY2FzZSB0YWJsZSBlbnRyaWVzIGFyZW4ndApzb3J0ZWQg YnkgYWRkcmVzcykgd2l0aCBtYXRjaGluZyBleGNsdXNpb25fYWxsb3dfYWxs IHNldHRpbmdzLiBUaGlzCnJlcXVpcmVzIGJ1YmJsaW5nIHVwIGVycm9yIGlu ZGljYXRvcnMsIHN1Y2ggdGhhdCBJT01NVSBpbml0IGNhbiBiZQpmYWlsZWQg d2hlbiBjb25jYXRlbmF0aW9uIHdhc24ndCBwb3NzaWJsZS4KCkZ1cnRoZXJt b3JlLCBzaW5jZSB0aGUgZXhjbHVzaW9uIHJhbmdlIHNwZWNpZmllZCBpbiBJ T01NVSByZWdpc3RlcnMKaW1wbGllcyBSL1cgYWNjZXNzLCByZWplY3QgcmVx dWVzdHMgYXNraW5nIGZvciBsZXNzIHBlcm1pc3Npb25zICh0aGlzCndpbGwg YmUgYnJvdWdodCBjbG9zZXIgdG8gdGhlIHNwZWMgYnkgYSBzdWJzZXF1ZW50 IGNoYW5nZSkuCgpUaGlzIGlzIHBhcnQgb2YgWFNBLTM3OCAvIENWRS0yMDIx LTI4Njk1LgoKU2lnbmVkLW9mZi1ieTogSmFuIEJldWxpY2ggPGpiZXVsaWNo QHN1c2UuY29tPgpSZXZpZXdlZC1ieTogUGF1bCBEdXJyYW50IDxwYXVsQHhl bi5vcmc+CgotLS0gYS94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC9hbWQvaW9t bXVfYWNwaS5jCisrKyBiL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL2FtZC9p b21tdV9hY3BpLmMKQEAgLTk4LDEyICs5OCwyMSBAQCBzdGF0aWMgc3RydWN0 IGFtZF9pb21tdSAqIF9faW5pdCBmaW5kX2lvCiAgICAgcmV0dXJuIE5VTEw7 CiB9CiAKLXN0YXRpYyB2b2lkIF9faW5pdCByZXNlcnZlX2lvbW11X2V4Y2x1 c2lvbl9yYW5nZSgKLSAgICBzdHJ1Y3QgYW1kX2lvbW11ICppb21tdSwgdWlu dDY0X3QgYmFzZSwgdWludDY0X3QgbGltaXQpCitzdGF0aWMgaW50IF9faW5p dCByZXNlcnZlX2lvbW11X2V4Y2x1c2lvbl9yYW5nZSgKKyAgICBzdHJ1Y3Qg YW1kX2lvbW11ICppb21tdSwgdWludDY0X3QgYmFzZSwgdWludDY0X3QgbGlt aXQsCisgICAgYm9vbCBhbGwsIGJvb2wgaXcsIGJvb2wgaXIpCiB7CisgICAg aWYgKCAhaXIgfHwgIWl3ICkKKyAgICAgICAgcmV0dXJuIC1FUEVSTTsKKwog ICAgIC8qIG5lZWQgdG8gZXh0ZW5kIGV4Y2x1c2lvbiByYW5nZT8gKi8KICAg ICBpZiAoIGlvbW11LT5leGNsdXNpb25fZW5hYmxlICkKICAgICB7CisgICAg ICAgIGlmICggaW9tbXUtPmV4Y2x1c2lvbl9saW1pdCArIFBBR0VfU0laRSA8 IGJhc2UgfHwKKyAgICAgICAgICAgICBsaW1pdCArIFBBR0VfU0laRSA8IGlv bW11LT5leGNsdXNpb25fYmFzZSB8fAorICAgICAgICAgICAgIGlvbW11LT5l eGNsdXNpb25fYWxsb3dfYWxsICE9IGFsbCApCisgICAgICAgICAgICByZXR1 cm4gLUVCVVNZOworCiAgICAgICAgIGlmICggaW9tbXUtPmV4Y2x1c2lvbl9i YXNlIDwgYmFzZSApCiAgICAgICAgICAgICBiYXNlID0gaW9tbXUtPmV4Y2x1 c2lvbl9iYXNlOwogICAgICAgICBpZiAoIGlvbW11LT5leGNsdXNpb25fbGlt aXQgPiBsaW1pdCApCkBAIC0xMTEsMTYgKzEyMCwxMSBAQCBzdGF0aWMgdm9p ZCBfX2luaXQgcmVzZXJ2ZV9pb21tdV9leGNsdXNpCiAgICAgfQogCiAgICAg aW9tbXUtPmV4Y2x1c2lvbl9lbmFibGUgPSBJT01NVV9DT05UUk9MX0VOQUJM RUQ7CisgICAgaW9tbXUtPmV4Y2x1c2lvbl9hbGxvd19hbGwgPSBhbGw7CiAg ICAgaW9tbXUtPmV4Y2x1c2lvbl9iYXNlID0gYmFzZTsKICAgICBpb21tdS0+ ZXhjbHVzaW9uX2xpbWl0ID0gbGltaXQ7Ci19CiAKLXN0YXRpYyB2b2lkIF9f aW5pdCByZXNlcnZlX2lvbW11X2V4Y2x1c2lvbl9yYW5nZV9hbGwoCi0gICAg c3RydWN0IGFtZF9pb21tdSAqaW9tbXUsCi0gICAgdW5zaWduZWQgbG9uZyBi YXNlLCB1bnNpZ25lZCBsb25nIGxpbWl0KQotewotICAgIHJlc2VydmVfaW9t bXVfZXhjbHVzaW9uX3JhbmdlKGlvbW11LCBiYXNlLCBsaW1pdCk7Ci0gICAg aW9tbXUtPmV4Y2x1c2lvbl9hbGxvd19hbGwgPSBJT01NVV9DT05UUk9MX0VO QUJMRUQ7CisgICAgcmV0dXJuIDA7CiB9CiAKIHN0YXRpYyB2b2lkIF9faW5p dCByZXNlcnZlX3VuaXR5X21hcF9mb3JfZGV2aWNlKApAQCAtMTU4LDYgKzE2 Miw3IEBAIHN0YXRpYyBpbnQgX19pbml0IHJlZ2lzdGVyX2V4Y2x1c2lvbl9y YW4KICAgICB1bnNpZ25lZCBsb25nIHJhbmdlX3RvcCwgaW9tbXVfdG9wLCBs ZW5ndGg7CiAgICAgc3RydWN0IGFtZF9pb21tdSAqaW9tbXU7CiAgICAgdW5z aWduZWQgaW50IGJkZjsKKyAgICBpbnQgcmMgPSAwOwogCiAgICAgLyogaXMg cGFydCBvZiBleGNsdXNpb24gcmFuZ2UgaW5zaWRlIG9mIElPTU1VIHZpcnR1 YWwgYWRkcmVzcyBzcGFjZT8gKi8KICAgICAvKiBub3RlOiAnbGltaXQnIHBh cmFtZXRlciBpcyBhc3N1bWVkIHRvIGJlIHBhZ2UtYWxpZ25lZCAqLwpAQCAt MTc5LDEwICsxODQsMTUgQEAgc3RhdGljIGludCBfX2luaXQgcmVnaXN0ZXJf ZXhjbHVzaW9uX3JhbgogICAgIGlmICggbGltaXQgPj0gaW9tbXVfdG9wICkK ICAgICB7CiAgICAgICAgIGZvcl9lYWNoX2FtZF9pb21tdSggaW9tbXUgKQot ICAgICAgICAgICAgcmVzZXJ2ZV9pb21tdV9leGNsdXNpb25fcmFuZ2VfYWxs KGlvbW11LCBiYXNlLCBsaW1pdCk7CisgICAgICAgIHsKKyAgICAgICAgICAg IHJjID0gcmVzZXJ2ZV9pb21tdV9leGNsdXNpb25fcmFuZ2UoaW9tbXUsIGJh c2UsIGxpbWl0LAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICB0cnVlIC8qIGFsbCAqLywgaXcsIGlyKTsKKyAgICAg ICAgICAgIGlmICggcmMgKQorICAgICAgICAgICAgICAgIGJyZWFrOworICAg ICAgICB9CiAgICAgfQogCi0gICAgcmV0dXJuIDA7CisgICAgcmV0dXJuIHJj OwogfQogCiBzdGF0aWMgaW50IF9faW5pdCByZWdpc3Rlcl9leGNsdXNpb25f cmFuZ2VfZm9yX2RldmljZSgKQEAgLTE5Myw2ICsyMDMsNyBAQCBzdGF0aWMg aW50IF9faW5pdCByZWdpc3Rlcl9leGNsdXNpb25fcmFuCiAgICAgdW5zaWdu ZWQgbG9uZyByYW5nZV90b3AsIGlvbW11X3RvcCwgbGVuZ3RoOwogICAgIHN0 cnVjdCBhbWRfaW9tbXUgKmlvbW11OwogICAgIHUxNiByZXE7CisgICAgaW50 IHJjID0gMDsKIAogICAgIGlvbW11ID0gZmluZF9pb21tdV9mb3JfZGV2aWNl KHNlZywgYmRmKTsKICAgICBpZiAoICFpb21tdSApCkBAIC0yMjIsMTIgKzIz MywxMyBAQCBzdGF0aWMgaW50IF9faW5pdCByZWdpc3Rlcl9leGNsdXNpb25f cmFuCiAgICAgLyogcmVnaXN0ZXIgSU9NTVUgZXhjbHVzaW9uIHJhbmdlIHNl dHRpbmdzIGZvciBkZXZpY2UgKi8KICAgICBpZiAoIGxpbWl0ID49IGlvbW11 X3RvcCAgKQogICAgIHsKLSAgICAgICAgcmVzZXJ2ZV9pb21tdV9leGNsdXNp b25fcmFuZ2UoaW9tbXUsIGJhc2UsIGxpbWl0KTsKKyAgICAgICAgcmMgPSBy ZXNlcnZlX2lvbW11X2V4Y2x1c2lvbl9yYW5nZShpb21tdSwgYmFzZSwgbGlt aXQsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgZmFsc2UgLyogYWxsICovLCBpdywgaXIpOwogICAgICAgICBpdnJzX21h cHBpbmdzW2JkZl0uZHRlX2FsbG93X2V4Y2x1c2lvbiA9IElPTU1VX0NPTlRS T0xfRU5BQkxFRDsKICAgICAgICAgaXZyc19tYXBwaW5nc1tyZXFdLmR0ZV9h bGxvd19leGNsdXNpb24gPSBJT01NVV9DT05UUk9MX0VOQUJMRUQ7CiAgICAg fQogCi0gICAgcmV0dXJuIDA7CisgICAgcmV0dXJuIHJjOwogfQogCiBzdGF0 aWMgaW50IF9faW5pdCByZWdpc3Rlcl9leGNsdXNpb25fcmFuZ2VfZm9yX2lv bW11X2RldmljZXMoCkBAIC0yMzcsNiArMjQ5LDcgQEAgc3RhdGljIGludCBf X2luaXQgcmVnaXN0ZXJfZXhjbHVzaW9uX3JhbgogICAgIHVuc2lnbmVkIGxv bmcgcmFuZ2VfdG9wLCBpb21tdV90b3AsIGxlbmd0aDsKICAgICB1bnNpZ25l ZCBpbnQgYmRmOwogICAgIHUxNiByZXE7CisgICAgaW50IHJjID0gMDsKIAog ICAgIC8qIGlzIHBhcnQgb2YgZXhjbHVzaW9uIHJhbmdlIGluc2lkZSBvZiBJ T01NVSB2aXJ0dWFsIGFkZHJlc3Mgc3BhY2U/ICovCiAgICAgLyogbm90ZTog J2xpbWl0JyBwYXJhbWV0ZXIgaXMgYXNzdW1lZCB0byBiZSBwYWdlLWFsaWdu ZWQgKi8KQEAgLTI2Nyw4ICsyODAsMTAgQEAgc3RhdGljIGludCBfX2luaXQg cmVnaXN0ZXJfZXhjbHVzaW9uX3JhbgogCiAgICAgLyogcmVnaXN0ZXIgSU9N TVUgZXhjbHVzaW9uIHJhbmdlIHNldHRpbmdzICovCiAgICAgaWYgKCBsaW1p dCA+PSBpb21tdV90b3AgKQotICAgICAgICByZXNlcnZlX2lvbW11X2V4Y2x1 c2lvbl9yYW5nZV9hbGwoaW9tbXUsIGJhc2UsIGxpbWl0KTsKLSAgICByZXR1 cm4gMDsKKyAgICAgICAgcmMgPSByZXNlcnZlX2lvbW11X2V4Y2x1c2lvbl9y YW5nZShpb21tdSwgYmFzZSwgbGltaXQsCisgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgdHJ1ZSAvKiBhbGwgKi8sIGl3LCBp cik7CisKKyAgICByZXR1cm4gcmM7CiB9CiAKIHN0YXRpYyBpbnQgX19pbml0 IHBhcnNlX2l2bWRfZGV2aWNlX3NlbGVjdCgK --=separator Content-Type: application/octet-stream; name="xsa378/xsa378-4.12-2.patch" Content-Disposition: attachment; filename="xsa378/xsa378-4.12-2.patch" Content-Transfer-Encoding: base64 RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0 OiBBTUQvSU9NTVU6IGNvcnJlY3QgZGV2aWNlIHVuaXR5IG1hcCBoYW5kbGlu ZwoKQmxpbmRseSBhc3N1bWluZyBhbGwgYWRkcmVzc2VzIGJldHdlZW4gYW55 IHR3byBzdWNoIHJhbmdlcywgc3BlY2lmaWVkIGJ5CmZpcm13YXJlIGluIHRo ZSBBQ1BJIHRhYmxlcywgc2hvdWxkIGFsc28gYmUgdW5pdHktbWFwcGVkIGNh bid0IGJlIHJpZ2h0LgpOb3IgY2FuIGl0IGJlIGNvcnJlY3QgdG8gbWVyZ2Ug cmFuZ2VzIHdpdGggZGlmZmVyaW5nIHBlcm1pc3Npb25zLiBUcmFjawpyYW5n ZXMgaW5kaXZpZHVhbGx5OyBkb24ndCBtZXJnZSBhdCBhbGwsIGJ1dCBjaGVj ayBmb3Igb3ZlcmxhcHMgaW5zdGVhZC4KVGhpcyByZXF1aXJlcyBidWJibGlu ZyB1cCBlcnJvciBpbmRpY2F0b3JzLCBzdWNoIHRoYXQgSU9NTVUgaW5pdCBj YW4gYmUKZmFpbGVkIHdoZW4gYWxsb2NhdGlvbiBvZiBhIG5ldyB0cmFja2lu ZyBzdHJ1Y3Qgd2Fzbid0IHBvc3NpYmxlLCBvciBhbgpvdmVybGFwIHdhcyBk ZXRlY3RlZC4KCkF0IHRoaXMgb2NjYXNpb24gYWxzbyBzdG9wIGlnbm9yaW5n CmFtZF9pb21tdV9yZXNlcnZlX2RvbWFpbl91bml0eV9tYXAoKSdzIHJldHVy biB2YWx1ZS4KClRoaXMgaXMgcGFydCBvZiBYU0EtMzc4IC8gQ1ZFLTIwMjEt Mjg2OTUuCgpTaWduZWQtb2ZmLWJ5OiBKYW4gQmV1bGljaCA8amJldWxpY2hA c3VzZS5jb20+ClJldmlld2VkLWJ5OiBHZW9yZ2UgRHVubGFwIDxnZW9yZ2Uu ZHVubGFwQGNpdHJpeC5jb20+ClJldmlld2VkLWJ5OiBQYXVsIER1cnJhbnQg PHBhdWxAeGVuLm9yZz4KCi0tLSBhL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdo L2FtZC9pb21tdV9hY3BpLmMKKysrIGIveGVuL2RyaXZlcnMvcGFzc3Rocm91 Z2gvYW1kL2lvbW11X2FjcGkuYwpAQCAtMTI3LDMyICsxMjcsNDggQEAgc3Rh dGljIGludCBfX2luaXQgcmVzZXJ2ZV9pb21tdV9leGNsdXNpbwogICAgIHJl dHVybiAwOwogfQogCi1zdGF0aWMgdm9pZCBfX2luaXQgcmVzZXJ2ZV91bml0 eV9tYXBfZm9yX2RldmljZSgKLSAgICB1MTYgc2VnLCB1MTYgYmRmLCB1bnNp Z25lZCBsb25nIGJhc2UsCi0gICAgdW5zaWduZWQgbG9uZyBsZW5ndGgsIHU4 IGl3LCB1OCBpcikKK3N0YXRpYyBpbnQgX19pbml0IHJlc2VydmVfdW5pdHlf bWFwX2Zvcl9kZXZpY2UoCisgICAgdWludDE2X3Qgc2VnLCB1aW50MTZfdCBi ZGYsIHVuc2lnbmVkIGxvbmcgYmFzZSwKKyAgICB1bnNpZ25lZCBsb25nIGxl bmd0aCwgYm9vbCBpdywgYm9vbCBpcikKIHsKICAgICBzdHJ1Y3QgaXZyc19t YXBwaW5ncyAqaXZyc19tYXBwaW5ncyA9IGdldF9pdnJzX21hcHBpbmdzKHNl Zyk7Ci0gICAgdW5zaWduZWQgbG9uZyBvbGRfdG9wLCBuZXdfdG9wOworICAg IHN0cnVjdCBpdnJzX3VuaXR5X21hcCAqdW5pdHlfbWFwID0gaXZyc19tYXBw aW5nc1tiZGZdLnVuaXR5X21hcDsKIAotICAgIC8qIG5lZWQgdG8gZXh0ZW5k IHVuaXR5LW1hcHBlZCByYW5nZT8gKi8KLSAgICBpZiAoIGl2cnNfbWFwcGlu Z3NbYmRmXS51bml0eV9tYXBfZW5hYmxlICkKKyAgICAvKiBDaGVjayBmb3Ig b3ZlcmxhcHMuICovCisgICAgZm9yICggOyB1bml0eV9tYXA7IHVuaXR5X21h cCA9IHVuaXR5X21hcC0+bmV4dCApCiAgICAgewotICAgICAgICBvbGRfdG9w ID0gaXZyc19tYXBwaW5nc1tiZGZdLmFkZHJfcmFuZ2Vfc3RhcnQgKwotICAg ICAgICAgICAgaXZyc19tYXBwaW5nc1tiZGZdLmFkZHJfcmFuZ2VfbGVuZ3Ro OwotICAgICAgICBuZXdfdG9wID0gYmFzZSArIGxlbmd0aDsKLSAgICAgICAg aWYgKCBvbGRfdG9wID4gbmV3X3RvcCApCi0gICAgICAgICAgICBuZXdfdG9w ID0gb2xkX3RvcDsKLSAgICAgICAgaWYgKCBpdnJzX21hcHBpbmdzW2JkZl0u YWRkcl9yYW5nZV9zdGFydCA8IGJhc2UgKQotICAgICAgICAgICAgYmFzZSA9 IGl2cnNfbWFwcGluZ3NbYmRmXS5hZGRyX3JhbmdlX3N0YXJ0OwotICAgICAg ICBsZW5ndGggPSBuZXdfdG9wIC0gYmFzZTsKLSAgICB9Ci0KLSAgICAvKiBl eHRlbmQgci93IHBlcm1pc3Npb21zIGFuZCBrZWVwIGFnZ3JlZ2F0ZSAqLwot ICAgIGl2cnNfbWFwcGluZ3NbYmRmXS53cml0ZV9wZXJtaXNzaW9uID0gaXc7 Ci0gICAgaXZyc19tYXBwaW5nc1tiZGZdLnJlYWRfcGVybWlzc2lvbiA9IGly OwotICAgIGl2cnNfbWFwcGluZ3NbYmRmXS51bml0eV9tYXBfZW5hYmxlID0g SU9NTVVfQ09OVFJPTF9FTkFCTEVEOwotICAgIGl2cnNfbWFwcGluZ3NbYmRm XS5hZGRyX3JhbmdlX3N0YXJ0ID0gYmFzZTsKLSAgICBpdnJzX21hcHBpbmdz W2JkZl0uYWRkcl9yYW5nZV9sZW5ndGggPSBsZW5ndGg7CisgICAgICAgIC8q CisgICAgICAgICAqIEV4YWN0IG1hdGNoZXMgYXJlIG9rYXkuIFRoaXMgY2Fu IGluIHBhcnRpY3VsYXIgaGFwcGVuIHdoZW4KKyAgICAgICAgICogcmVnaXN0 ZXJfZXhjbHVzaW9uX3JhbmdlX2Zvcl9kZXZpY2UoKSBjYWxscyBoZXJlIHR3 aWNlIGZvciB0aGUKKyAgICAgICAgICogc2FtZSAocyxiLGQsZikuCisgICAg ICAgICAqLworICAgICAgICBpZiAoIGJhc2UgPT0gdW5pdHlfbWFwLT5hZGRy ICYmIGxlbmd0aCA9PSB1bml0eV9tYXAtPmxlbmd0aCAmJgorICAgICAgICAg ICAgIGlyID09IHVuaXR5X21hcC0+cmVhZCAmJiBpdyA9PSB1bml0eV9tYXAt PndyaXRlICkKKyAgICAgICAgICAgIHJldHVybiAwOworCisgICAgICAgIGlm ICggdW5pdHlfbWFwLT5hZGRyICsgdW5pdHlfbWFwLT5sZW5ndGggPiBiYXNl ICYmCisgICAgICAgICAgICAgYmFzZSArIGxlbmd0aCA+IHVuaXR5X21hcC0+ YWRkciApCisgICAgICAgIHsKKyAgICAgICAgICAgIEFNRF9JT01NVV9ERUJV RygiSVZNRCBFcnJvcjogb3ZlcmxhcCBbJWx4LCVseCkgdnMgWyVseCwlbHgp XG4iLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgIGJhc2UsIGJhc2Ug KyBsZW5ndGgsIHVuaXR5X21hcC0+YWRkciwKKyAgICAgICAgICAgICAgICAg ICAgICAgICAgICB1bml0eV9tYXAtPmFkZHIgKyB1bml0eV9tYXAtPmxlbmd0 aCk7CisgICAgICAgICAgICByZXR1cm4gLUVQRVJNOworICAgICAgICB9Cisg ICAgfQorCisgICAgLyogUG9wdWxhdGUgYW5kIGluc2VydCBhIG5ldyB1bml0 eSBtYXAuICovCisgICAgdW5pdHlfbWFwID0geG1hbGxvYyhzdHJ1Y3QgaXZy c191bml0eV9tYXApOworICAgIGlmICggIXVuaXR5X21hcCApCisgICAgICAg IHJldHVybiAtRU5PTUVNOworCisgICAgdW5pdHlfbWFwLT5yZWFkID0gaXI7 CisgICAgdW5pdHlfbWFwLT53cml0ZSA9IGl3OworICAgIHVuaXR5X21hcC0+ YWRkciA9IGJhc2U7CisgICAgdW5pdHlfbWFwLT5sZW5ndGggPSBsZW5ndGg7 CisgICAgdW5pdHlfbWFwLT5uZXh0ID0gaXZyc19tYXBwaW5nc1tiZGZdLnVu aXR5X21hcDsKKyAgICBpdnJzX21hcHBpbmdzW2JkZl0udW5pdHlfbWFwID0g dW5pdHlfbWFwOworCisgICAgcmV0dXJuIDA7CiB9CiAKIHN0YXRpYyBpbnQg X19pbml0IHJlZ2lzdGVyX2V4Y2x1c2lvbl9yYW5nZV9mb3JfYWxsX2Rldmlj ZXMoCkBAIC0xNzUsMTMgKzE5MSwxMyBAQCBzdGF0aWMgaW50IF9faW5pdCBy ZWdpc3Rlcl9leGNsdXNpb25fcmFuCiAgICAgICAgIGxlbmd0aCA9IHJhbmdl X3RvcCAtIGJhc2U7CiAgICAgICAgIC8qIHJlc2VydmUgci93IHVuaXR5LW1h cHBlZCBwYWdlIGVudHJpZXMgZm9yIGRldmljZXMgKi8KICAgICAgICAgLyog bm90ZTogdGhlc2UgZW50cmllcyBhcmUgcGFydCBvZiB0aGUgZXhjbHVzaW9u IHJhbmdlICovCi0gICAgICAgIGZvciAoIGJkZiA9IDA7IGJkZiA8IGl2cnNf YmRmX2VudHJpZXM7IGJkZisrICkKLSAgICAgICAgICAgIHJlc2VydmVfdW5p dHlfbWFwX2Zvcl9kZXZpY2Uoc2VnLCBiZGYsIGJhc2UsIGxlbmd0aCwgaXcs IGlyKTsKKyAgICAgICAgZm9yICggYmRmID0gMDsgIXJjICYmIGJkZiA8IGl2 cnNfYmRmX2VudHJpZXM7IGJkZisrICkKKyAgICAgICAgICAgIHJjID0gcmVz ZXJ2ZV91bml0eV9tYXBfZm9yX2RldmljZShzZWcsIGJkZiwgYmFzZSwgbGVu Z3RoLCBpdywgaXIpOwogICAgICAgICAvKiBwdXNoICdiYXNlJyBqdXN0IG91 dHNpZGUgb2YgdmlydHVhbCBhZGRyZXNzIHNwYWNlICovCiAgICAgICAgIGJh c2UgPSBpb21tdV90b3A7CiAgICAgfQogICAgIC8qIHJlZ2lzdGVyIElPTU1V IGV4Y2x1c2lvbiByYW5nZSBzZXR0aW5ncyAqLwotICAgIGlmICggbGltaXQg Pj0gaW9tbXVfdG9wICkKKyAgICBpZiAoICFyYyAmJiBsaW1pdCA+PSBpb21t dV90b3AgKQogICAgIHsKICAgICAgICAgZm9yX2VhY2hfYW1kX2lvbW11KCBp b21tdSApCiAgICAgICAgIHsKQEAgLTIyMywxNSArMjM5LDE1IEBAIHN0YXRp YyBpbnQgX19pbml0IHJlZ2lzdGVyX2V4Y2x1c2lvbl9yYW4KICAgICAgICAg bGVuZ3RoID0gcmFuZ2VfdG9wIC0gYmFzZTsKICAgICAgICAgLyogcmVzZXJ2 ZSB1bml0eS1tYXBwZWQgcGFnZSBlbnRyaWVzIGZvciBkZXZpY2UgKi8KICAg ICAgICAgLyogbm90ZTogdGhlc2UgZW50cmllcyBhcmUgcGFydCBvZiB0aGUg ZXhjbHVzaW9uIHJhbmdlICovCi0gICAgICAgIHJlc2VydmVfdW5pdHlfbWFw X2Zvcl9kZXZpY2Uoc2VnLCBiZGYsIGJhc2UsIGxlbmd0aCwgaXcsIGlyKTsK LSAgICAgICAgcmVzZXJ2ZV91bml0eV9tYXBfZm9yX2RldmljZShzZWcsIHJl cSwgYmFzZSwgbGVuZ3RoLCBpdywgaXIpOworICAgICAgICByYyA9IHJlc2Vy dmVfdW5pdHlfbWFwX2Zvcl9kZXZpY2Uoc2VnLCBiZGYsIGJhc2UsIGxlbmd0 aCwgaXcsIGlyKSA/OgorICAgICAgICAgICAgIHJlc2VydmVfdW5pdHlfbWFw X2Zvcl9kZXZpY2Uoc2VnLCByZXEsIGJhc2UsIGxlbmd0aCwgaXcsIGlyKTsK IAogICAgICAgICAvKiBwdXNoICdiYXNlJyBqdXN0IG91dHNpZGUgb2Ygdmly dHVhbCBhZGRyZXNzIHNwYWNlICovCiAgICAgICAgIGJhc2UgPSBpb21tdV90 b3A7CiAgICAgfQogCiAgICAgLyogcmVnaXN0ZXIgSU9NTVUgZXhjbHVzaW9u IHJhbmdlIHNldHRpbmdzIGZvciBkZXZpY2UgKi8KLSAgICBpZiAoIGxpbWl0 ID49IGlvbW11X3RvcCAgKQorICAgIGlmICggIXJjICYmIGxpbWl0ID49IGlv bW11X3RvcCAgKQogICAgIHsKICAgICAgICAgcmMgPSByZXNlcnZlX2lvbW11 X2V4Y2x1c2lvbl9yYW5nZShpb21tdSwgYmFzZSwgbGltaXQsCiAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZmFsc2UgLyog YWxsICovLCBpdywgaXIpOwpAQCAtMjYyLDE1ICsyNzgsMTUgQEAgc3RhdGlj IGludCBfX2luaXQgcmVnaXN0ZXJfZXhjbHVzaW9uX3JhbgogICAgICAgICBs ZW5ndGggPSByYW5nZV90b3AgLSBiYXNlOwogICAgICAgICAvKiByZXNlcnZl IHIvdyB1bml0eS1tYXBwZWQgcGFnZSBlbnRyaWVzIGZvciBkZXZpY2VzICov CiAgICAgICAgIC8qIG5vdGU6IHRoZXNlIGVudHJpZXMgYXJlIHBhcnQgb2Yg dGhlIGV4Y2x1c2lvbiByYW5nZSAqLwotICAgICAgICBmb3IgKCBiZGYgPSAw OyBiZGYgPCBpdnJzX2JkZl9lbnRyaWVzOyBiZGYrKyApCisgICAgICAgIGZv ciAoIGJkZiA9IDA7ICFyYyAmJiBiZGYgPCBpdnJzX2JkZl9lbnRyaWVzOyBi ZGYrKyApCiAgICAgICAgIHsKICAgICAgICAgICAgIGlmICggaW9tbXUgPT0g ZmluZF9pb21tdV9mb3JfZGV2aWNlKGlvbW11LT5zZWcsIGJkZikgKQogICAg ICAgICAgICAgewotICAgICAgICAgICAgICAgIHJlc2VydmVfdW5pdHlfbWFw X2Zvcl9kZXZpY2UoaW9tbXUtPnNlZywgYmRmLCBiYXNlLCBsZW5ndGgsCi0g ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBp dywgaXIpOwogICAgICAgICAgICAgICAgIHJlcSA9IGdldF9pdnJzX21hcHBp bmdzKGlvbW11LT5zZWcpW2JkZl0uZHRlX3JlcXVlc3Rvcl9pZDsKLSAgICAg ICAgICAgICAgICByZXNlcnZlX3VuaXR5X21hcF9mb3JfZGV2aWNlKGlvbW11 LT5zZWcsIHJlcSwgYmFzZSwgbGVuZ3RoLAotICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgaXcsIGlyKTsKKyAgICAgICAg ICAgICAgICByYyA9IHJlc2VydmVfdW5pdHlfbWFwX2Zvcl9kZXZpY2UoaW9t bXUtPnNlZywgYmRmLCBiYXNlLCBsZW5ndGgsCisgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGl3LCBpcikgPzoK KyAgICAgICAgICAgICAgICAgICAgIHJlc2VydmVfdW5pdHlfbWFwX2Zvcl9k ZXZpY2UoaW9tbXUtPnNlZywgcmVxLCBiYXNlLCBsZW5ndGgsCisgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGl3 LCBpcik7CiAgICAgICAgICAgICB9CiAgICAgICAgIH0KIApAQCAtMjc5LDcg KzI5NSw3IEBAIHN0YXRpYyBpbnQgX19pbml0IHJlZ2lzdGVyX2V4Y2x1c2lv bl9yYW4KICAgICB9CiAKICAgICAvKiByZWdpc3RlciBJT01NVSBleGNsdXNp b24gcmFuZ2Ugc2V0dGluZ3MgKi8KLSAgICBpZiAoIGxpbWl0ID49IGlvbW11 X3RvcCApCisgICAgaWYgKCAhcmMgJiYgbGltaXQgPj0gaW9tbXVfdG9wICkK ICAgICAgICAgcmMgPSByZXNlcnZlX2lvbW11X2V4Y2x1c2lvbl9yYW5nZShp b21tdSwgYmFzZSwgbGltaXQsCiAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgdHJ1ZSAvKiBhbGwgKi8sIGl3LCBpcik7CiAK LS0tIGEveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvYW1kL2lvbW11X2luaXQu YworKysgYi94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC9hbWQvaW9tbXVfaW5p dC5jCkBAIC0xMTg5LDcgKzExODksNiBAQCBzdGF0aWMgaW50IF9faW5pdCBh bGxvY19pdnJzX21hcHBpbmdzKHUxCiAgICAgewogICAgICAgICBpdnJzX21h cHBpbmdzW2JkZl0uZHRlX3JlcXVlc3Rvcl9pZCA9IGJkZjsKICAgICAgICAg aXZyc19tYXBwaW5nc1tiZGZdLmR0ZV9hbGxvd19leGNsdXNpb24gPSBJT01N VV9DT05UUk9MX0RJU0FCTEVEOwotICAgICAgICBpdnJzX21hcHBpbmdzW2Jk Zl0udW5pdHlfbWFwX2VuYWJsZSA9IElPTU1VX0NPTlRST0xfRElTQUJMRUQ7 CiAgICAgICAgIGl2cnNfbWFwcGluZ3NbYmRmXS5pb21tdSA9IE5VTEw7CiAK ICAgICAgICAgaXZyc19tYXBwaW5nc1tiZGZdLmludHJlbWFwX3RhYmxlID0g TlVMTDsKLS0tIGEveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvYW1kL3BjaV9h bWRfaW9tbXUuYworKysgYi94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC9hbWQv cGNpX2FtZF9pb21tdS5jCkBAIC0zNDYsMTUgKzM0NiwxNyBAQCBzdGF0aWMg aW50IGFtZF9pb21tdV9hc3NpZ25fZGV2aWNlKHN0cnVjCiAgICAgc3RydWN0 IGl2cnNfbWFwcGluZ3MgKml2cnNfbWFwcGluZ3MgPSBnZXRfaXZyc19tYXBw aW5ncyhwZGV2LT5zZWcpOwogICAgIGludCBiZGYgPSBQQ0lfQkRGMihwZGV2 LT5idXMsIGRldmZuKTsKICAgICBpbnQgcmVxX2lkID0gZ2V0X2RtYV9yZXF1 ZXN0b3JfaWQocGRldi0+c2VnLCBiZGYpOworICAgIGNvbnN0IHN0cnVjdCBp dnJzX3VuaXR5X21hcCAqdW5pdHlfbWFwOwogCi0gICAgaWYgKCBpdnJzX21h cHBpbmdzW3JlcV9pZF0udW5pdHlfbWFwX2VuYWJsZSApCisgICAgZm9yICgg dW5pdHlfbWFwID0gaXZyc19tYXBwaW5nc1tyZXFfaWRdLnVuaXR5X21hcDsg dW5pdHlfbWFwOworICAgICAgICAgIHVuaXR5X21hcCA9IHVuaXR5X21hcC0+ bmV4dCApCiAgICAgewotICAgICAgICBhbWRfaW9tbXVfcmVzZXJ2ZV9kb21h aW5fdW5pdHlfbWFwKAotICAgICAgICAgICAgZCwKLSAgICAgICAgICAgIGl2 cnNfbWFwcGluZ3NbcmVxX2lkXS5hZGRyX3JhbmdlX3N0YXJ0LAotICAgICAg ICAgICAgaXZyc19tYXBwaW5nc1tyZXFfaWRdLmFkZHJfcmFuZ2VfbGVuZ3Ro LAotICAgICAgICAgICAgaXZyc19tYXBwaW5nc1tyZXFfaWRdLndyaXRlX3Bl cm1pc3Npb24sCi0gICAgICAgICAgICBpdnJzX21hcHBpbmdzW3JlcV9pZF0u cmVhZF9wZXJtaXNzaW9uKTsKKyAgICAgICAgaW50IHJjID0gYW1kX2lvbW11 X3Jlc2VydmVfZG9tYWluX3VuaXR5X21hcCgKKyAgICAgICAgICAgICAgICAg ICAgIGQsIHVuaXR5X21hcC0+YWRkciwgdW5pdHlfbWFwLT5sZW5ndGgsCisg ICAgICAgICAgICAgICAgICAgICB1bml0eV9tYXAtPndyaXRlLCB1bml0eV9t YXAtPnJlYWQpOworCisgICAgICAgIGlmICggcmMgKQorICAgICAgICAgICAg cmV0dXJuIHJjOwogICAgIH0KIAogICAgIHJldHVybiByZWFzc2lnbl9kZXZp Y2UocGRldi0+ZG9tYWluLCBkLCBkZXZmbiwgcGRldik7Ci0tLSBhL3hlbi9p bmNsdWRlL2FzbS14ODYvYW1kLWlvbW11LmgKKysrIGIveGVuL2luY2x1ZGUv YXNtLXg4Ni9hbWQtaW9tbXUuaApAQCAtMTA4LDE1ICsxMDgsMTkgQEAgc3Ry dWN0IGFtZF9pb21tdSB7CiAgICAgc3RydWN0IGxpc3RfaGVhZCBhdHNfZGV2 aWNlczsKIH07CiAKK3N0cnVjdCBpdnJzX3VuaXR5X21hcCB7CisgICAgYm9v bCByZWFkOjE7CisgICAgYm9vbCB3cml0ZToxOworICAgIHBhZGRyX3QgYWRk cjsKKyAgICB1bnNpZ25lZCBsb25nIGxlbmd0aDsKKyAgICBzdHJ1Y3QgaXZy c191bml0eV9tYXAgKm5leHQ7Cit9OworCiBzdHJ1Y3QgaXZyc19tYXBwaW5n cyB7CiAgICAgdTE2IGR0ZV9yZXF1ZXN0b3JfaWQ7CiAgICAgdTggZHRlX2Fs bG93X2V4Y2x1c2lvbjsKLSAgICB1OCB1bml0eV9tYXBfZW5hYmxlOwotICAg IHU4IHdyaXRlX3Blcm1pc3Npb247Ci0gICAgdTggcmVhZF9wZXJtaXNzaW9u OwotICAgIHVuc2lnbmVkIGxvbmcgYWRkcl9yYW5nZV9zdGFydDsKLSAgICB1 bnNpZ25lZCBsb25nIGFkZHJfcmFuZ2VfbGVuZ3RoOwogICAgIHN0cnVjdCBh bWRfaW9tbXUgKmlvbW11OworICAgIHN0cnVjdCBpdnJzX3VuaXR5X21hcCAq dW5pdHlfbWFwOwogCiAgICAgLyogcGVyIGRldmljZSBpbnRlcnJ1cHQgcmVt YXBwaW5nIHRhYmxlICovCiAgICAgdm9pZCAqaW50cmVtYXBfdGFibGU7Cg== --=separator Content-Type: application/octet-stream; name="xsa378/xsa378-4.12-3.patch" Content-Disposition: attachment; filename="xsa378/xsa378-4.12-3.patch" Content-Transfer-Encoding: base64 RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0 OiBJT01NVTogYWxzbyBwYXNzIHAybV9hY2Nlc3NfdCB0byBwMm1fZ2V0X2lv bW11X2ZsYWdzKCkKCkEgc3Vic2VxdWVudCBjaGFuZ2Ugd2lsbCB3YW50IHRv IGN1c3RvbWl6ZSB0aGUgSU9NTVUgcGVybWlzc2lvbnMgYmFzZWQKb24gdGhp cy4KClRoaXMgaXMgcGFydCBvZiBYU0EtMzc4LgoKU2lnbmVkLW9mZi1ieTog SmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpSZXZpZXdlZC1ieTog UGF1bCBEdXJyYW50IDxwYXVsQHhlbi5vcmc+CgotLS0gYS94ZW4vYXJjaC94 ODYvbW0vcDJtLWVwdC5jCisrKyBiL3hlbi9hcmNoL3g4Ni9tbS9wMm0tZXB0 LmMKQEAgLTY3Miw3ICs2NzIsNyBAQCBlcHRfc2V0X2VudHJ5KHN0cnVjdCBw Mm1fZG9tYWluICpwMm0sIGdmCiAgICAgdWludDhfdCBpcGF0ID0gMDsKICAg ICBib29sX3QgbmVlZF9tb2RpZnlfdnRkX3RhYmxlID0gMTsKICAgICBib29s X3QgdnRkX3B0ZV9wcmVzZW50ID0gMDsKLSAgICB1bnNpZ25lZCBpbnQgaW9t bXVfZmxhZ3MgPSBwMm1fZ2V0X2lvbW11X2ZsYWdzKHAybXQsIG1mbik7Cisg ICAgdW5zaWduZWQgaW50IGlvbW11X2ZsYWdzID0gcDJtX2dldF9pb21tdV9m bGFncyhwMm10LCBwMm1hLCBtZm4pOwogICAgIGJvb2xfdCBuZWVkc19zeW5j ID0gMTsKICAgICBlcHRfZW50cnlfdCBvbGRfZW50cnkgPSB7IC5lcHRlID0g MCB9OwogICAgIGVwdF9lbnRyeV90IG5ld19lbnRyeSA9IHsgLmVwdGUgPSAw IH07CkBAIC03OTksOCArNzk5LDggQEAgZXB0X3NldF9lbnRyeShzdHJ1Y3Qg cDJtX2RvbWFpbiAqcDJtLCBnZgogCiAgICAgICAgIC8qIFNhZmUgdG8gcmVh ZC10aGVuLXdyaXRlIGJlY2F1c2Ugd2UgaG9sZCB0aGUgcDJtIGxvY2sgKi8K ICAgICAgICAgaWYgKCBlcHRfZW50cnktPm1mbiA9PSBuZXdfZW50cnkubWZu ICYmCi0gICAgICAgICAgICAgcDJtX2dldF9pb21tdV9mbGFncyhlcHRfZW50 cnktPnNhX3AybXQsIF9tZm4oZXB0X2VudHJ5LT5tZm4pKSA9PQotICAgICAg ICAgICAgIGlvbW11X2ZsYWdzICkKKyAgICAgICAgICAgICBwMm1fZ2V0X2lv bW11X2ZsYWdzKGVwdF9lbnRyeS0+c2FfcDJtdCwgZXB0X2VudHJ5LT5hY2Nl c3MsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBfbWZuKGVw dF9lbnRyeS0+bWZuKSkgPT0gaW9tbXVfZmxhZ3MgKQogICAgICAgICAgICAg bmVlZF9tb2RpZnlfdnRkX3RhYmxlID0gMDsKIAogICAgICAgICBlcHRfcDJt X3R5cGVfdG9fZmxhZ3MocDJtLCAmbmV3X2VudHJ5LCBwMm10LCBwMm1hKTsK LS0tIGEveGVuL2FyY2gveDg2L21tL3AybS1wdC5jCisrKyBiL3hlbi9hcmNo L3g4Ni9tbS9wMm0tcHQuYwpAQCAtNTEyLDYgKzUxMiwxNiBAQCBpbnQgcDJt X3B0X2hhbmRsZV9kZWZlcnJlZF9jaGFuZ2VzKHVpbnQ2CiAgICAgcmV0dXJu IHJjOwogfQogCisvKiBSZWNvbnN0cnVjdCBhIGZha2UgcDJtX2FjY2Vzc190 IGZyb20gc3RvcmVkIFBURSBmbGFncy4gKi8KK3N0YXRpYyBwMm1fYWNjZXNz X3QgcDJtX2ZsYWdzX3RvX2FjY2Vzcyh1bnNpZ25lZCBpbnQgZmxhZ3MpCit7 CisgICAgaWYgKCBmbGFncyAmIF9QQUdFX1BSRVNFTlQgKQorICAgICAgICBy ZXR1cm4gcDJtX2FjY2Vzc19uOworCisgICAgLyogTm8gbmVlZCB0byBsb29r IGF0IF9QQUdFX05YIGZvciBub3cuICovCisgICAgcmV0dXJuIGZsYWdzICYg X1BBR0VfUlcgPyBwMm1fYWNjZXNzX3J3IDogcDJtX2FjY2Vzc19yOworfQor CiAvKiBDaGVja3Mgb25seSBhcHBsaWNhYmxlIHRvIGVudHJpZXMgd2l0aCBv cmRlciA+IFBBR0VfT1JERVJfNEsgKi8KIHN0YXRpYyB2b2lkIGNoZWNrX2Vu dHJ5KG1mbl90IG1mbiwgcDJtX3R5cGVfdCBuZXcsIHAybV90eXBlX3Qgb2xk LAogICAgICAgICAgICAgICAgICAgICAgICAgdW5zaWduZWQgaW50IG9yZGVy KQpAQCAtNTQ2LDcgKzU1Niw3IEBAIHAybV9wdF9zZXRfZW50cnkoc3RydWN0 IHAybV9kb21haW4gKnAybSwKICAgICBsMl9wZ2VudHJ5X3QgbDJlX2NvbnRl bnQ7CiAgICAgbDNfcGdlbnRyeV90IGwzZV9jb250ZW50OwogICAgIGludCBy YzsKLSAgICB1bnNpZ25lZCBpbnQgaW9tbXVfcHRlX2ZsYWdzID0gcDJtX2dl dF9pb21tdV9mbGFncyhwMm10LCBtZm4pOworICAgIHVuc2lnbmVkIGludCBp b21tdV9wdGVfZmxhZ3MgPSBwMm1fZ2V0X2lvbW11X2ZsYWdzKHAybXQsIHAy bWEsIG1mbik7CiAgICAgLyoKICAgICAgKiBvbGRfbWZuIGFuZCBpb21tdV9v bGRfZmxhZ3MgY29udHJvbCBwb3NzaWJsZSBmbHVzaC91cGRhdGUgbmVlZHMg b24gdGhlCiAgICAgICogSU9NTVU6IFdlIG5lZWQgdG8gZmx1c2ggd2hlbiBN Rk4gb3IgZmxhZ3MgKGkuZS4gcGVybWlzc2lvbnMpIGNoYW5nZS4KQEAgLTYw OSw2ICs2MTksNyBAQCBwMm1fcHRfc2V0X2VudHJ5KHN0cnVjdCBwMm1fZG9t YWluICpwMm0sCiAgICAgICAgICAgICAgICAgb2xkX21mbiA9IGwxZV9nZXRf cGZuKCpwMm1fZW50cnkpOwogICAgICAgICAgICAgICAgIGlvbW11X29sZF9m bGFncyA9CiAgICAgICAgICAgICAgICAgICAgIHAybV9nZXRfaW9tbXVfZmxh Z3MocDJtX2ZsYWdzX3RvX3R5cGUoZmxhZ3MpLAorICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIHAybV9mbGFnc190b19hY2Nlc3Mo ZmxhZ3MpLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIF9tZm4ob2xkX21mbikpOwogICAgICAgICAgICAgfQogICAgICAgICAg ICAgZWxzZQpAQCAtNjU0LDkgKzY2NSwxMCBAQCBwMm1fcHRfc2V0X2VudHJ5 KHN0cnVjdCBwMm1fZG9tYWluICpwMm0sCiAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIDAsIEwxX1BBR0VUQUJMRV9FTlRSSUVTKTsKICAg ICAgICAgQVNTRVJUKHAybV9lbnRyeSk7CiAgICAgICAgIG9sZF9tZm4gPSBs MWVfZ2V0X3BmbigqcDJtX2VudHJ5KTsKKyAgICAgICAgZmxhZ3MgPSBsMWVf Z2V0X2ZsYWdzKCpwMm1fZW50cnkpOwogICAgICAgICBpb21tdV9vbGRfZmxh Z3MgPQotICAgICAgICAgICAgcDJtX2dldF9pb21tdV9mbGFncyhwMm1fZmxh Z3NfdG9fdHlwZShsMWVfZ2V0X2ZsYWdzKCpwMm1fZW50cnkpKSwKLSAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgX21mbihvbGRfbWZuKSk7Cisg ICAgICAgICAgICBwMm1fZ2V0X2lvbW11X2ZsYWdzKHAybV9mbGFnc190b190 eXBlKGZsYWdzKSwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg cDJtX2ZsYWdzX3RvX2FjY2VzcyhmbGFncyksIF9tZm4ob2xkX21mbikpOwog CiAgICAgICAgIGlmICggbWZuX3ZhbGlkKG1mbikgfHwgcDJtX2FsbG93c19p bnZhbGlkX21mbihwMm10KSApCiAgICAgICAgICAgICBlbnRyeV9jb250ZW50 ID0gcDJtX2wxZV9mcm9tX3BmbihtZm5feChtZm4pLApAQCAtNjg3LDYgKzY5 OSw3IEBAIHAybV9wdF9zZXRfZW50cnkoc3RydWN0IHAybV9kb21haW4gKnAy bSwKICAgICAgICAgICAgICAgICBvbGRfbWZuID0gbDFlX2dldF9wZm4oKnAy bV9lbnRyeSk7CiAgICAgICAgICAgICAgICAgaW9tbXVfb2xkX2ZsYWdzID0K ICAgICAgICAgICAgICAgICAgICAgcDJtX2dldF9pb21tdV9mbGFncyhwMm1f ZmxhZ3NfdG9fdHlwZShmbGFncyksCisgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgcDJtX2ZsYWdzX3RvX2FjY2VzcyhmbGFncyks CiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgX21m bihvbGRfbWZuKSk7CiAgICAgICAgICAgICB9CiAgICAgICAgICAgICBlbHNl Ci0tLSBhL3hlbi9pbmNsdWRlL2FzbS14ODYvcDJtLmgKKysrIGIveGVuL2lu Y2x1ZGUvYXNtLXg4Ni9wMm0uaApAQCAtODk5LDcgKzg5OSw4IEBAIHN0YXRp YyBpbmxpbmUgdm9pZCBwMm1fYWx0cDJtX2NoZWNrKHN0cnUKIC8qCiAgKiBw Mm0gdHlwZSB0byBJT01NVSBmbGFncwogICovCi1zdGF0aWMgaW5saW5lIHVu c2lnbmVkIGludCBwMm1fZ2V0X2lvbW11X2ZsYWdzKHAybV90eXBlX3QgcDJt dCwgbWZuX3QgbWZuKQorc3RhdGljIGlubGluZSB1bnNpZ25lZCBpbnQgcDJt X2dldF9pb21tdV9mbGFncyhwMm1fdHlwZV90IHAybXQsCisgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHAybV9hY2Nl c3NfdCBwMm1hLCBtZm5fdCBtZm4pCiB7CiAgICAgdW5zaWduZWQgaW50IGZs YWdzOwogCg== --=separator Content-Type: application/octet-stream; name="xsa378/xsa378-4.12-4.patch" Content-Disposition: attachment; filename="xsa378/xsa378-4.12-4.patch" Content-Transfer-Encoding: base64 RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0 OiBJT01NVTogZ2VuZXJhbGl6ZSBWVC1kJ3MgdHJhY2tpbmcgb2YgbWFwcGVk IFJNUlIgcmVnaW9ucwoKSW4gb3JkZXIgdG8gcmUtdXNlIGl0IGVsc2V3aGVy ZSwgbW92ZSB0aGUgbG9naWMgdG8gdmVuZG9yIGluZGVwZW5kZW50CmNvZGUg YW5kIHN0cmlwIGl0IG9mIFJNUlIgc3BlY2lmaWNzLgoKTm90ZSB0aGF0IHRo ZSBwcmlvciAibWFwIiBwYXJhbWV0ZXIgZ2V0cyBmb2xkZWQgaW50byB0aGUg bmV3ICJwMm1hIiBvbmUKKHdoaWNoIEFNRCBJT01NVSBjb2RlIHdpbGwgd2Fu dCB0byBtYWtlIHVzZSBvZiksIGFzc2lnbmluZyBhbHRlcm5hdGl2ZQptZWFu aW5nICgidW5tYXAiKSB0byBwMm1fYWNjZXNzX3guIFByZXBhcmUgc2V0X2lk ZW50aXR5X3AybV9lbnRyeSgpIGFuZApwMm1fZ2V0X2lvbW11X2ZsYWdzKCkg Zm9yIGdldHRpbmcgcGFzc2VkIGFjY2VzcyB0eXBlcyBvdGhlciB0aGFuCnAy bV9hY2Nlc3NfcncgKGluIHRoZSBsYXR0ZXIgY2FzZSBqdXN0IGZvciBwMm1f bW1pb19kaXJlY3QgcmVxdWVzdHMpLgoKTm90ZSBhbHNvIHRoYXQsIHRvIGJl IG9uIHRoZSBzYWZlIHNpZGUsIGFuIG92ZXJsYXAgY2hlY2sgZ2V0cyBhZGRl ZCB0bwp0aGUgbWFpbiBsb29wIG9mIGlvbW11X2lkZW50aXR5X21hcHBpbmco KS4KClRoaXMgaXMgcGFydCBvZiBYU0EtMzc4LgoKU2lnbmVkLW9mZi1ieTog SmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpSZXZpZXdlZC1ieTog UGF1bCBEdXJyYW50IDxwYXVsQHhlbi5vcmc+CgotLS0gYS94ZW4vYXJjaC94 ODYvbW0vcDJtLmMKKysrIGIveGVuL2FyY2gveDg2L21tL3AybS5jCkBAIC0x MzQxLDcgKzEzNDEsNyBAQCBpbnQgc2V0X2lkZW50aXR5X3AybV9lbnRyeShz dHJ1Y3QgZG9tYWluCiAgICAgICAgIGlmICggIWhhc19pb21tdV9wdChkKSAp CiAgICAgICAgICAgICByZXR1cm4gMDsKICAgICAgICAgcmV0dXJuIGlvbW11 X2xlZ2FjeV9tYXAoZCwgX2RmbihnZm5fbCksIF9tZm4oZ2ZuX2wpLCBQQUdF X09SREVSXzRLLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBJ T01NVUZfcmVhZGFibGUgfCBJT01NVUZfd3JpdGFibGUpOworICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICBwMm1fYWNjZXNzX3RvX2lvbW11X2Zs YWdzKHAybWEpKTsKICAgICB9CiAKICAgICBnZm5fbG9jayhwMm0sIGdmbiwg MCk7Ci0tLSBhL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL3Z0ZC9pb21tdS5j CisrKyBiL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL3Z0ZC9pb21tdS5jCkBA IC00MiwxMiArNDIsNiBAQAogI2luY2x1ZGUgInZ0ZC5oIgogI2luY2x1ZGUg Ii4uL2F0cy5oIgogCi1zdHJ1Y3QgbWFwcGVkX3JtcnIgewotICAgIHN0cnVj dCBsaXN0X2hlYWQgbGlzdDsKLSAgICB1NjQgYmFzZSwgZW5kOwotICAgIHVu c2lnbmVkIGludCBjb3VudDsKLX07Ci0KIC8qIFBvc3NpYmxlIHVuZmlsdGVy ZWQgTEFQSUMvTVNJIG1lc3NhZ2VzIGZyb20gdW50cnVzdGVkIHNvdXJjZXM/ ICovCiBib29sIF9fcmVhZF9tb3N0bHkgdW50cnVzdGVkX21zaTsKIApAQCAt MTc4NywxNiArMTc4MSwxMSBAQCBvdXQ6CiBzdGF0aWMgdm9pZCBpb21tdV9k b21haW5fdGVhcmRvd24oc3RydWN0IGRvbWFpbiAqZCkKIHsKICAgICBzdHJ1 Y3QgZG9tYWluX2lvbW11ICpoZCA9IGRvbV9pb21tdShkKTsKLSAgICBzdHJ1 Y3QgbWFwcGVkX3JtcnIgKm1ybXJyLCAqdG1wOwogCiAgICAgaWYgKCBsaXN0 X2VtcHR5KCZhY3BpX2RyaGRfdW5pdHMpICkKICAgICAgICAgcmV0dXJuOwog Ci0gICAgbGlzdF9mb3JfZWFjaF9lbnRyeV9zYWZlICggbXJtcnIsIHRtcCwg JmhkLT5hcmNoLm1hcHBlZF9ybXJycywgbGlzdCApCi0gICAgewotICAgICAg ICBsaXN0X2RlbCgmbXJtcnItPmxpc3QpOwotICAgICAgICB4ZnJlZShtcm1y cik7Ci0gICAgfQorICAgIGlvbW11X2lkZW50aXR5X21hcF90ZWFyZG93bihk KTsKIAogICAgIEFTU0VSVChpb21tdV9lbmFibGVkKTsKIApAQCAtMTk1NSw3 NCArMTk0NCw2IEBAIHN0YXRpYyB2b2lkIGlvbW11X3NldF9wZ2Qoc3RydWN0 IGRvbWFpbgogICAgICAgICBwYWdldGFibGVfZ2V0X3BhZGRyKHBhZ2V0YWJs ZV9mcm9tX21mbihwZ2RfbWZuKSk7CiB9CiAKLXN0YXRpYyBpbnQgcm1ycl9p ZGVudGl0eV9tYXBwaW5nKHN0cnVjdCBkb21haW4gKmQsIGJvb2xfdCBtYXAs Ci0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjb25zdCBzdHJ1 Y3QgYWNwaV9ybXJyX3VuaXQgKnJtcnIsCi0gICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICB1MzIgZmxhZykKLXsKLSAgICB1bnNpZ25lZCBsb25n IGJhc2VfcGZuID0gcm1yci0+YmFzZV9hZGRyZXNzID4+IFBBR0VfU0hJRlRf NEs7Ci0gICAgdW5zaWduZWQgbG9uZyBlbmRfcGZuID0gUEFHRV9BTElHTl80 SyhybXJyLT5lbmRfYWRkcmVzcykgPj4gUEFHRV9TSElGVF80SzsKLSAgICBz dHJ1Y3QgbWFwcGVkX3JtcnIgKm1ybXJyOwotICAgIHN0cnVjdCBkb21haW5f aW9tbXUgKmhkID0gZG9tX2lvbW11KGQpOwotCi0gICAgQVNTRVJUKHBjaWRl dnNfbG9ja2VkKCkpOwotICAgIEFTU0VSVChybXJyLT5iYXNlX2FkZHJlc3Mg PCBybXJyLT5lbmRfYWRkcmVzcyk7Ci0KLSAgICAvKgotICAgICAqIE5vIG5l ZWQgdG8gYWNxdWlyZSBoZC0+YXJjaC5tYXBwaW5nX2xvY2s6IEJvdGggaW5z ZXJ0aW9uIGFuZCByZW1vdmFsCi0gICAgICogZ2V0IGRvbmUgd2hpbGUgaG9s ZGluZyBwY2lkZXZzX2xvY2suCi0gICAgICovCi0gICAgbGlzdF9mb3JfZWFj aF9lbnRyeSggbXJtcnIsICZoZC0+YXJjaC5tYXBwZWRfcm1ycnMsIGxpc3Qg KQotICAgIHsKLSAgICAgICAgaWYgKCBtcm1yci0+YmFzZSA9PSBybXJyLT5i YXNlX2FkZHJlc3MgJiYKLSAgICAgICAgICAgICBtcm1yci0+ZW5kID09IHJt cnItPmVuZF9hZGRyZXNzICkKLSAgICAgICAgewotICAgICAgICAgICAgaW50 IHJldCA9IDA7Ci0KLSAgICAgICAgICAgIGlmICggbWFwICkKLSAgICAgICAg ICAgIHsKLSAgICAgICAgICAgICAgICArK21ybXJyLT5jb3VudDsKLSAgICAg ICAgICAgICAgICByZXR1cm4gMDsKLSAgICAgICAgICAgIH0KLQotICAgICAg ICAgICAgaWYgKCAtLW1ybXJyLT5jb3VudCApCi0gICAgICAgICAgICAgICAg cmV0dXJuIDA7Ci0KLSAgICAgICAgICAgIHdoaWxlICggYmFzZV9wZm4gPCBl bmRfcGZuICkKLSAgICAgICAgICAgIHsKLSAgICAgICAgICAgICAgICBpZiAo IGNsZWFyX2lkZW50aXR5X3AybV9lbnRyeShkLCBiYXNlX3BmbikgKQotICAg ICAgICAgICAgICAgICAgICByZXQgPSAtRU5YSU87Ci0gICAgICAgICAgICAg ICAgYmFzZV9wZm4rKzsKLSAgICAgICAgICAgIH0KLQotICAgICAgICAgICAg bGlzdF9kZWwoJm1ybXJyLT5saXN0KTsKLSAgICAgICAgICAgIHhmcmVlKG1y bXJyKTsKLSAgICAgICAgICAgIHJldHVybiByZXQ7Ci0gICAgICAgIH0KLSAg ICB9Ci0KLSAgICBpZiAoICFtYXAgKQotICAgICAgICByZXR1cm4gLUVOT0VO VDsKLQotICAgIHdoaWxlICggYmFzZV9wZm4gPCBlbmRfcGZuICkKLSAgICB7 Ci0gICAgICAgIGludCBlcnIgPSBzZXRfaWRlbnRpdHlfcDJtX2VudHJ5KGQs IGJhc2VfcGZuLCBwMm1fYWNjZXNzX3J3LCBmbGFnKTsKLQotICAgICAgICBp ZiAoIGVyciApCi0gICAgICAgICAgICByZXR1cm4gZXJyOwotICAgICAgICBi YXNlX3BmbisrOwotICAgIH0KLQotICAgIG1ybXJyID0geG1hbGxvYyhzdHJ1 Y3QgbWFwcGVkX3JtcnIpOwotICAgIGlmICggIW1ybXJyICkKLSAgICAgICAg cmV0dXJuIC1FTk9NRU07Ci0gICAgbXJtcnItPmJhc2UgPSBybXJyLT5iYXNl X2FkZHJlc3M7Ci0gICAgbXJtcnItPmVuZCA9IHJtcnItPmVuZF9hZGRyZXNz OwotICAgIG1ybXJyLT5jb3VudCA9IDE7Ci0gICAgbGlzdF9hZGRfdGFpbCgm bXJtcnItPmxpc3QsICZoZC0+YXJjaC5tYXBwZWRfcm1ycnMpOwotCi0gICAg cmV0dXJuIDA7Ci19Ci0KIHN0YXRpYyBpbnQgaW50ZWxfaW9tbXVfYWRkX2Rl dmljZSh1OCBkZXZmbiwgc3RydWN0IHBjaV9kZXYgKnBkZXYpCiB7CiAgICAg c3RydWN0IGFjcGlfcm1ycl91bml0ICpybXJyOwpAQCAtMjA1NCw3ICsxOTc1 LDkgQEAgc3RhdGljIGludCBpbnRlbF9pb21tdV9hZGRfZGV2aWNlKHU4IGRl dgogICAgICAgICAgICAgICogU2luY2UgUk1SUnMgYXJlIGFsd2F5cyByZXNl cnZlZCBpbiB0aGUgZTgyMCBtYXAgZm9yIHRoZSBoYXJkd2FyZQogICAgICAg ICAgICAgICogZG9tYWluLCB0aGVyZSBzaG91bGRuJ3QgYmUgYSBjb25mbGlj dC4KICAgICAgICAgICAgICAqLwotICAgICAgICAgICAgcmV0ID0gcm1ycl9p ZGVudGl0eV9tYXBwaW5nKHBkZXYtPmRvbWFpbiwgMSwgcm1yciwgMCk7Cisg ICAgICAgICAgICByZXQgPSBpb21tdV9pZGVudGl0eV9tYXBwaW5nKHBkZXYt PmRvbWFpbiwgcDJtX2FjY2Vzc19ydywKKyAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgcm1yci0+YmFzZV9hZGRyZXNzLCBybXJy LT5lbmRfYWRkcmVzcywKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgMCk7CiAgICAgICAgICAgICBpZiAoIHJldCApCiAgICAg ICAgICAgICAgICAgZHByaW50ayhYRU5MT0dfRVJSIFZURFBSRUZJWCwgImQl ZDogUk1SUiBtYXBwaW5nIGZhaWxlZFxuIiwKICAgICAgICAgICAgICAgICAg ICAgICAgIHBkZXYtPmRvbWFpbi0+ZG9tYWluX2lkKTsKQEAgLTIwOTksNyAr MjAyMiw4IEBAIHN0YXRpYyBpbnQgaW50ZWxfaW9tbXVfcmVtb3ZlX2Rldmlj ZSh1OAogICAgICAgICAgKiBBbnkgZmxhZyBpcyBub3RoaW5nIHRvIGNsZWFy IHRoZXNlIG1hcHBpbmdzIGJ1dCBoZXJlCiAgICAgICAgICAqIGl0cyBhbHdh eXMgc2FmZSBhbmQgc3RyaWN0IHRvIHNldCAwLgogICAgICAgICAgKi8KLSAg ICAgICAgcm1ycl9pZGVudGl0eV9tYXBwaW5nKHBkZXYtPmRvbWFpbiwgMCwg cm1yciwgMCk7CisgICAgICAgIGlvbW11X2lkZW50aXR5X21hcHBpbmcocGRl di0+ZG9tYWluLCBwMm1fYWNjZXNzX3gsIHJtcnItPmJhc2VfYWRkcmVzcywK KyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBybXJyLT5lbmRfYWRk cmVzcywgMCk7CiAgICAgfQogCiAgICAgcmV0dXJuIGRvbWFpbl9jb250ZXh0 X3VubWFwKHBkZXYtPmRvbWFpbiwgZGV2Zm4sIHBkZXYpOwpAQCAtMjI2Niw3 ICsyMTkwLDggQEAgc3RhdGljIHZvaWQgX19od2RvbV9pbml0IHNldHVwX2h3 ZG9tX3JtcgogICAgICAgICAgKiBkb21haW4sIHRoZXJlIHNob3VsZG4ndCBi ZSBhIGNvbmZsaWN0LiBTbyBpdHMgYWx3YXlzIHNhZmUgYW5kCiAgICAgICAg ICAqIHN0cmljdCB0byBzZXQgMC4KICAgICAgICAgICovCi0gICAgICAgIHJl dCA9IHJtcnJfaWRlbnRpdHlfbWFwcGluZyhkLCAxLCBybXJyLCAwKTsKKyAg ICAgICAgcmV0ID0gaW9tbXVfaWRlbnRpdHlfbWFwcGluZyhkLCBwMm1fYWNj ZXNzX3J3LCBybXJyLT5iYXNlX2FkZHJlc3MsCisgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgcm1yci0+ZW5kX2FkZHJlc3MsIDApOwog ICAgICAgICBpZiAoIHJldCApCiAgICAgICAgICAgICBkcHJpbnRrKFhFTkxP R19FUlIgVlREUFJFRklYLAogICAgICAgICAgICAgICAgICAgICAgIklPTU1V OiBtYXBwaW5nIHJlc2VydmVkIHJlZ2lvbiBmYWlsZWRcbiIpOwpAQCAtMjQy NSw3ICsyMzUwLDkgQEAgc3RhdGljIGludCByZWFzc2lnbl9kZXZpY2Vfb3du ZXJzaGlwKAogICAgICAgICAgICAgICAgICAqIEFueSBSTVJSIGZsYWcgaXMg YWx3YXlzIGlnbm9yZWQgd2hlbiByZW1vdmUgYSBkZXZpY2UsCiAgICAgICAg ICAgICAgICAgICogYnV0IGl0cyBhbHdheXMgc2FmZSBhbmQgc3RyaWN0IHRv IHNldCAwLgogICAgICAgICAgICAgICAgICAqLwotICAgICAgICAgICAgICAg IHJldCA9IHJtcnJfaWRlbnRpdHlfbWFwcGluZyhzb3VyY2UsIDAsIHJtcnIs IDApOworICAgICAgICAgICAgICAgIHJldCA9IGlvbW11X2lkZW50aXR5X21h cHBpbmcoc291cmNlLCBwMm1fYWNjZXNzX3gsCisgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBybXJyLT5iYXNlX2FkZHJl c3MsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICBybXJyLT5lbmRfYWRkcmVzcywgMCk7CiAgICAgICAgICAgICAgICAg aWYgKCByZXQgIT0gLUVOT0VOVCApCiAgICAgICAgICAgICAgICAgICAgIHJl dHVybiByZXQ7CiAgICAgICAgICAgICB9CkBAIC0yNTIyLDcgKzI0NDksOCBA QCBzdGF0aWMgaW50IGludGVsX2lvbW11X2Fzc2lnbl9kZXZpY2UoCiAgICAg ICAgICAgICAgUENJX0JVUyhiZGYpID09IGJ1cyAmJgogICAgICAgICAgICAg IFBDSV9ERVZGTjIoYmRmKSA9PSBkZXZmbiApCiAgICAgICAgIHsKLSAgICAg ICAgICAgIHJldCA9IHJtcnJfaWRlbnRpdHlfbWFwcGluZyhkLCAxLCBybXJy LCBmbGFnKTsKKyAgICAgICAgICAgIHJldCA9IGlvbW11X2lkZW50aXR5X21h cHBpbmcoZCwgcDJtX2FjY2Vzc19ydywgcm1yci0+YmFzZV9hZGRyZXNzLAor ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBybXJy LT5lbmRfYWRkcmVzcywgZmxhZyk7CiAgICAgICAgICAgICBpZiAoIHJldCAp CiAgICAgICAgICAgICB7CiAgICAgICAgICAgICAgICAgaW50IHJjOwotLS0g YS94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC94ODYvaW9tbXUuYworKysgYi94 ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC94ODYvaW9tbXUuYwpAQCAtMTUwLDcg KzE1MCw3IEBAIGludCBhcmNoX2lvbW11X2RvbWFpbl9pbml0KHN0cnVjdCBk b21haW4KICAgICBzdHJ1Y3QgZG9tYWluX2lvbW11ICpoZCA9IGRvbV9pb21t dShkKTsKIAogICAgIHNwaW5fbG9ja19pbml0KCZoZC0+YXJjaC5tYXBwaW5n X2xvY2spOwotICAgIElOSVRfTElTVF9IRUFEKCZoZC0+YXJjaC5tYXBwZWRf cm1ycnMpOworICAgIElOSVRfTElTVF9IRUFEKCZoZC0+YXJjaC5pZGVudGl0 eV9tYXBzKTsKIAogICAgIHJldHVybiAwOwogfQpAQCAtMTU5LDYgKzE1OSw5 OSBAQCB2b2lkIGFyY2hfaW9tbXVfZG9tYWluX2Rlc3Ryb3koc3RydWN0IGRv CiB7CiB9CiAKK3N0cnVjdCBpZGVudGl0eV9tYXAgeworICAgIHN0cnVjdCBs aXN0X2hlYWQgbGlzdDsKKyAgICBwYWRkcl90IGJhc2UsIGVuZDsKKyAgICBw Mm1fYWNjZXNzX3QgYWNjZXNzOworICAgIHVuc2lnbmVkIGludCBjb3VudDsK K307CisKK2ludCBpb21tdV9pZGVudGl0eV9tYXBwaW5nKHN0cnVjdCBkb21h aW4gKmQsIHAybV9hY2Nlc3NfdCBwMm1hLAorICAgICAgICAgICAgICAgICAg ICAgICAgICAgcGFkZHJfdCBiYXNlLCBwYWRkcl90IGVuZCwKKyAgICAgICAg ICAgICAgICAgICAgICAgICAgIHVuc2lnbmVkIGludCBmbGFnKQoreworICAg IHVuc2lnbmVkIGxvbmcgYmFzZV9wZm4gPSBiYXNlID4+IFBBR0VfU0hJRlRf NEs7CisgICAgdW5zaWduZWQgbG9uZyBlbmRfcGZuID0gUEFHRV9BTElHTl80 SyhlbmQpID4+IFBBR0VfU0hJRlRfNEs7CisgICAgc3RydWN0IGlkZW50aXR5 X21hcCAqbWFwOworICAgIHN0cnVjdCBkb21haW5faW9tbXUgKmhkID0gZG9t X2lvbW11KGQpOworCisgICAgQVNTRVJUKHBjaWRldnNfbG9ja2VkKCkpOwor ICAgIEFTU0VSVChiYXNlIDwgZW5kKTsKKworICAgIC8qCisgICAgICogTm8g bmVlZCB0byBhY3F1aXJlIGhkLT5hcmNoLm1hcHBpbmdfbG9jazogQm90aCBp bnNlcnRpb24gYW5kIHJlbW92YWwKKyAgICAgKiBnZXQgZG9uZSB3aGlsZSBo b2xkaW5nIHBjaWRldnNfbG9jay4KKyAgICAgKi8KKyAgICBsaXN0X2Zvcl9l YWNoX2VudHJ5KCBtYXAsICZoZC0+YXJjaC5pZGVudGl0eV9tYXBzLCBsaXN0 ICkKKyAgICB7CisgICAgICAgIGlmICggbWFwLT5iYXNlID09IGJhc2UgJiYg bWFwLT5lbmQgPT0gZW5kICkKKyAgICAgICAgeworICAgICAgICAgICAgaW50 IHJldCA9IDA7CisKKyAgICAgICAgICAgIGlmICggcDJtYSAhPSBwMm1fYWNj ZXNzX3ggKQorICAgICAgICAgICAgeworICAgICAgICAgICAgICAgIGlmICgg bWFwLT5hY2Nlc3MgIT0gcDJtYSApCisgICAgICAgICAgICAgICAgICAgIHJl dHVybiAtRUFERFJJTlVTRTsKKyAgICAgICAgICAgICAgICArK21hcC0+Y291 bnQ7CisgICAgICAgICAgICAgICAgcmV0dXJuIDA7CisgICAgICAgICAgICB9 CisKKyAgICAgICAgICAgIGlmICggLS1tYXAtPmNvdW50ICkKKyAgICAgICAg ICAgICAgICByZXR1cm4gMDsKKworICAgICAgICAgICAgd2hpbGUgKCBiYXNl X3BmbiA8IGVuZF9wZm4gKQorICAgICAgICAgICAgeworICAgICAgICAgICAg ICAgIGlmICggY2xlYXJfaWRlbnRpdHlfcDJtX2VudHJ5KGQsIGJhc2VfcGZu KSApCisgICAgICAgICAgICAgICAgICAgIHJldCA9IC1FTlhJTzsKKyAgICAg ICAgICAgICAgICBiYXNlX3BmbisrOworICAgICAgICAgICAgfQorCisgICAg ICAgICAgICBsaXN0X2RlbCgmbWFwLT5saXN0KTsKKyAgICAgICAgICAgIHhm cmVlKG1hcCk7CisKKyAgICAgICAgICAgIHJldHVybiByZXQ7CisgICAgICAg IH0KKworICAgICAgICBpZiAoIGVuZCA+PSBtYXAtPmJhc2UgJiYgbWFwLT5l bmQgPj0gYmFzZSApCisgICAgICAgICAgICByZXR1cm4gLUVBRERSSU5VU0U7 CisgICAgfQorCisgICAgaWYgKCBwMm1hID09IHAybV9hY2Nlc3NfeCApCisg ICAgICAgIHJldHVybiAtRU5PRU5UOworCisgICAgd2hpbGUgKCBiYXNlX3Bm biA8IGVuZF9wZm4gKQorICAgIHsKKyAgICAgICAgaW50IGVyciA9IHNldF9p ZGVudGl0eV9wMm1fZW50cnkoZCwgYmFzZV9wZm4sIHAybWEsIGZsYWcpOwor CisgICAgICAgIGlmICggZXJyICkKKyAgICAgICAgICAgIHJldHVybiBlcnI7 CisgICAgICAgIGJhc2VfcGZuKys7CisgICAgfQorCisgICAgbWFwID0geG1h bGxvYyhzdHJ1Y3QgaWRlbnRpdHlfbWFwKTsKKyAgICBpZiAoICFtYXAgKQor ICAgICAgICByZXR1cm4gLUVOT01FTTsKKyAgICBtYXAtPmJhc2UgPSBiYXNl OworICAgIG1hcC0+ZW5kID0gZW5kOworICAgIG1hcC0+YWNjZXNzID0gcDJt YTsKKyAgICBtYXAtPmNvdW50ID0gMTsKKyAgICBsaXN0X2FkZF90YWlsKCZt YXAtPmxpc3QsICZoZC0+YXJjaC5pZGVudGl0eV9tYXBzKTsKKworICAgIHJl dHVybiAwOworfQorCit2b2lkIGlvbW11X2lkZW50aXR5X21hcF90ZWFyZG93 bihzdHJ1Y3QgZG9tYWluICpkKQoreworICAgIHN0cnVjdCBkb21haW5faW9t bXUgKmhkID0gZG9tX2lvbW11KGQpOworICAgIHN0cnVjdCBpZGVudGl0eV9t YXAgKm1hcCwgKnRtcDsKKworICAgIGxpc3RfZm9yX2VhY2hfZW50cnlfc2Fm ZSAoIG1hcCwgdG1wLCAmaGQtPmFyY2guaWRlbnRpdHlfbWFwcywgbGlzdCAp CisgICAgeworICAgICAgICBsaXN0X2RlbCgmbWFwLT5saXN0KTsKKyAgICAg ICAgeGZyZWUobWFwKTsKKyAgICB9Cit9CisKIHN0YXRpYyBib29sIF9faHdk b21faW5pdCBod2RvbV9pb21tdV9tYXAoY29uc3Qgc3RydWN0IGRvbWFpbiAq ZCwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg dW5zaWduZWQgbG9uZyBwZm4sCiAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIHVuc2lnbmVkIGxvbmcgbWF4X3BmbikKLS0tIGEv eGVuL2luY2x1ZGUvYXNtLXg4Ni9pb21tdS5oCisrKyBiL3hlbi9pbmNsdWRl L2FzbS14ODYvaW9tbXUuaApAQCAtMTYsNiArMTYsNyBAQAogCiAjaW5jbHVk ZSA8eGVuL2Vycm5vLmg+CiAjaW5jbHVkZSA8eGVuL2xpc3QuaD4KKyNpbmNs dWRlIDx4ZW4vbWVtX2FjY2Vzcy5oPgogI2luY2x1ZGUgPHhlbi9zcGlubG9j ay5oPgogI2luY2x1ZGUgPGFzbS9wcm9jZXNzb3IuaD4KICNpbmNsdWRlIDxh c20vaHZtL3ZteC92bWNzLmg+CkBAIC00OCw3ICs0OSw3IEBAIHN0cnVjdCBh cmNoX2lvbW11CiAgICAgc3BpbmxvY2tfdCBtYXBwaW5nX2xvY2s7ICAgICAg ICAgICAgLyogaW8gcGFnZSB0YWJsZSBsb2NrICovCiAgICAgaW50IGFnYXc7 ICAgICAvKiBhZGp1c3RlZCBndWVzdCBhZGRyZXNzIHdpZHRoLCAwIGlzIGxl dmVsIDIgMzAtYml0ICovCiAgICAgdTY0IGlvbW11X2JpdG1hcDsgICAgICAg ICAgICAgIC8qIGJpdG1hcCBvZiBpb21tdShzKSB0aGF0IHRoZSBkb21haW4g dXNlcyAqLwotICAgIHN0cnVjdCBsaXN0X2hlYWQgbWFwcGVkX3JtcnJzOwor ICAgIHN0cnVjdCBsaXN0X2hlYWQgaWRlbnRpdHlfbWFwczsKIAogICAgIC8q IGFtZCBpb21tdSBzdXBwb3J0ICovCiAgICAgaW50IHBhZ2luZ19tb2RlOwpA QCAtOTQsNiArOTUsMTEgQEAgYm9vbF90IGlvbW11X3N1cHBvcnRzX2VpbSh2 b2lkKTsKIGludCBpb21tdV9lbmFibGVfeDJhcGljX0lSKHZvaWQpOwogdm9p ZCBpb21tdV9kaXNhYmxlX3gyYXBpY19JUih2b2lkKTsKIAoraW50IGlvbW11 X2lkZW50aXR5X21hcHBpbmcoc3RydWN0IGRvbWFpbiAqZCwgcDJtX2FjY2Vz c190IHAybWEsCisgICAgICAgICAgICAgICAgICAgICAgICAgICBwYWRkcl90 IGJhc2UsIHBhZGRyX3QgZW5kLAorICAgICAgICAgICAgICAgICAgICAgICAg ICAgdW5zaWduZWQgaW50IGZsYWcpOwordm9pZCBpb21tdV9pZGVudGl0eV9t YXBfdGVhcmRvd24oc3RydWN0IGRvbWFpbiAqZCk7CisKIGV4dGVybiBib29s IHVudHJ1c3RlZF9tc2k7CiAKIGludCBwaV91cGRhdGVfaXJ0ZShjb25zdCBz dHJ1Y3QgcGlfZGVzYyAqcGlfZGVzYywgY29uc3Qgc3RydWN0IHBpcnEgKnBp cnEsCi0tLSBhL3hlbi9pbmNsdWRlL2FzbS14ODYvcDJtLmgKKysrIGIveGVu L2luY2x1ZGUvYXNtLXg4Ni9wMm0uaApAQCAtODk2LDYgKzg5NiwzNCBAQCBz dHJ1Y3QgcDJtX2RvbWFpbiAqcDJtX2dldF9hbHRwMm0oc3RydWN0CiBzdGF0 aWMgaW5saW5lIHZvaWQgcDJtX2FsdHAybV9jaGVjayhzdHJ1Y3QgdmNwdSAq diwgdWludDE2X3QgaWR4KSB7fQogI2VuZGlmCiAKKy8qIHAybSBhY2Nlc3Mg dG8gSU9NTVUgZmxhZ3MgKi8KK3N0YXRpYyBpbmxpbmUgdW5zaWduZWQgaW50 IHAybV9hY2Nlc3NfdG9faW9tbXVfZmxhZ3MocDJtX2FjY2Vzc190IHAybWEp Cit7CisgICAgc3dpdGNoICggcDJtYSApCisgICAgeworICAgIGNhc2UgcDJt X2FjY2Vzc19ydzoKKyAgICBjYXNlIHAybV9hY2Nlc3Nfcnd4OgorICAgICAg ICByZXR1cm4gSU9NTVVGX3JlYWRhYmxlIHwgSU9NTVVGX3dyaXRhYmxlOwor CisgICAgY2FzZSBwMm1fYWNjZXNzX3I6CisgICAgY2FzZSBwMm1fYWNjZXNz X3J4OgorICAgIGNhc2UgcDJtX2FjY2Vzc19yeDJydzoKKyAgICAgICAgcmV0 dXJuIElPTU1VRl9yZWFkYWJsZTsKKworICAgIGNhc2UgcDJtX2FjY2Vzc193 OgorICAgIGNhc2UgcDJtX2FjY2Vzc193eDoKKyAgICAgICAgcmV0dXJuIElP TU1VRl93cml0YWJsZTsKKworICAgIGNhc2UgcDJtX2FjY2Vzc19uOgorICAg IGNhc2UgcDJtX2FjY2Vzc194OgorICAgIGNhc2UgcDJtX2FjY2Vzc19uMnJ3 eDoKKyAgICAgICAgcmV0dXJuIDA7CisgICAgfQorCisgICAgQVNTRVJUX1VO UkVBQ0hBQkxFKCk7CisgICAgcmV0dXJuIDA7Cit9CisKIC8qCiAgKiBwMm0g dHlwZSB0byBJT01NVSBmbGFncwogICovCkBAIC05MTcsOSArOTQ1LDEwIEBA IHN0YXRpYyBpbmxpbmUgdW5zaWduZWQgaW50IHAybV9nZXRfaW9tbXUKICAg ICAgICAgZmxhZ3MgPSBJT01NVUZfcmVhZGFibGU7CiAgICAgICAgIGJyZWFr OwogICAgIGNhc2UgcDJtX21taW9fZGlyZWN0OgotICAgICAgICBmbGFncyA9 IElPTU1VRl9yZWFkYWJsZTsKLSAgICAgICAgaWYgKCAhcmFuZ2VzZXRfY29u dGFpbnNfc2luZ2xldG9uKG1taW9fcm9fcmFuZ2VzLCBtZm5feChtZm4pKSAp Ci0gICAgICAgICAgICBmbGFncyB8PSBJT01NVUZfd3JpdGFibGU7CisgICAg ICAgIGZsYWdzID0gcDJtX2FjY2Vzc190b19pb21tdV9mbGFncyhwMm1hKTsK KyAgICAgICAgaWYgKCAoZmxhZ3MgJiBJT01NVUZfd3JpdGFibGUpICYmCisg ICAgICAgICAgICAgcmFuZ2VzZXRfY29udGFpbnNfc2luZ2xldG9uKG1taW9f cm9fcmFuZ2VzLCBtZm5feChtZm4pKSApCisgICAgICAgICAgICBmbGFncyAm PSB+SU9NTVVGX3dyaXRhYmxlOwogICAgICAgICBicmVhazsKICAgICBkZWZh dWx0OgogICAgICAgICBmbGFncyA9IDA7Cg== --=separator Content-Type: application/octet-stream; name="xsa378/xsa378-4.12-5.patch" Content-Disposition: attachment; filename="xsa378/xsa378-4.12-5.patch" Content-Transfer-Encoding: base64 RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0 OiBBTUQvSU9NTVU6IHJlLWFycmFuZ2UvY29tcGxldGUgcmUtYXNzaWdubWVu dCBoYW5kbGluZwoKUHJpb3IgdG8gdGhlIGFzc2lnbm1lbnQgc3RlcCBoYXZp bmcgY29tcGxldGVkIHN1Y2Nlc3NmdWxseSwgZGV2aWNlcwpzaG91bGQgbm90 IGdldCBhc3NvY2lhdGVkIHdpdGggdGhlaXIgbmV3IG93bmVyLiBIYW5kIHRo ZSBkZXZpY2UgdG8gRG9tSU8KKHBlcmhhcHMgdGVtcG9yYXJpbHkpLCB1bnRp bCBhZnRlciB0aGUgZGUtYXNzaWdubWVudCBzdGVwIGhhcyBjb21wbGV0ZWQu CgpEZS1hc3NpZ25tZW50IG9mIGEgZGV2aWNlIChmcm9tIG90aGVyIHRoYW4g RG9tMCkgYXMgd2VsbCBhcyBmYWlsdXJlIG9mCnJlYXNzaWduX2RldmljZSgp IGR1cmluZyBhc3NpZ25tZW50IHNob3VsZCByZXN1bHQgaW4gdW5pdHkgbWFw cGluZ3MKZ2V0dGluZyB0b3JuIGRvd24uIFRoaXMgaW4gdHVybiByZXF1aXJl cyBzd2l0Y2hpbmcgdG8gYSByZWZjb3VudGVkCm1hcHBpbmcgYXBwcm9hY2gs IGFzIHdhcyBhbHJlYWR5IHVzZWQgYnkgVlQtZCBmb3IgaXRzIFJNUlJzLCB0 byBwcmV2ZW50CnVubWFwcGluZyBhIHJlZ2lvbiB1c2VkIGJ5IG11bHRpcGxl IGRldmljZXMuCgpUaGlzIGlzIENWRS0yMDIxLTI4Njk2IC8gcGFydCBvZiBY U0EtMzc4LgoKU2lnbmVkLW9mZi1ieTogSmFuIEJldWxpY2ggPGpiZXVsaWNo QHN1c2UuY29tPgpSZXZpZXdlZC1ieTogUGF1bCBEdXJyYW50IDxwYXVsQHhl bi5vcmc+CgotLS0gYS94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC9hbWQvaW9t bXVfbWFwLmMKKysrIGIveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvYW1kL2lv bW11X21hcC5jCkBAIC02MTMsMzggKzYxMyw0OSBAQCBpbnQgYW1kX2lvbW11 X2ZsdXNoX2lvdGxiX2FsbChzdHJ1Y3QgZG9tCiAgICAgcmV0dXJuIDA7CiB9 CiAKLWludCBhbWRfaW9tbXVfcmVzZXJ2ZV9kb21haW5fdW5pdHlfbWFwKHN0 cnVjdCBkb21haW4gKmRvbWFpbiwKLSAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIHBhZGRyX3QgcGh5c19hZGRyLAotICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdW5zaWduZWQgbG9uZyBz aXplLCBpbnQgaXcsIGludCBpcikKK2ludCBhbWRfaW9tbXVfcmVzZXJ2ZV9k b21haW5fdW5pdHlfbWFwKHN0cnVjdCBkb21haW4gKmQsCisgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjb25zdCBzdHJ1Y3QgaXZy c191bml0eV9tYXAgKm1hcCwKKyAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIHVuc2lnbmVkIGludCBmbGFnKQogewotICAgIHVuc2ln bmVkIGxvbmcgbnBhZ2VzLCBpOwotICAgIHVuc2lnbmVkIGxvbmcgZ2ZuOwot ICAgIHVuc2lnbmVkIGludCBmbGFncyA9ICEhaXI7Ci0gICAgdW5zaWduZWQg aW50IGZsdXNoX2ZsYWdzID0gMDsKLSAgICBpbnQgcnQgPSAwOwotCi0gICAg aWYgKCBpdyApCi0gICAgICAgIGZsYWdzIHw9IElPTU1VRl93cml0YWJsZTsK LQotICAgIG5wYWdlcyA9IHJlZ2lvbl90b19wYWdlcyhwaHlzX2FkZHIsIHNp emUpOwotICAgIGdmbiA9IHBoeXNfYWRkciA+PiBQQUdFX1NISUZUOwotICAg IGZvciAoIGkgPSAwOyBpIDwgbnBhZ2VzOyBpKysgKQorICAgIGludCByYzsK KworICAgIGlmICggZCA9PSBkb21faW8gKQorICAgICAgICByZXR1cm4gMDsK KworICAgIGZvciAoIHJjID0gMDsgIXJjICYmIG1hcDsgbWFwID0gbWFwLT5u ZXh0ICkKICAgICB7Ci0gICAgICAgIHVuc2lnbmVkIGxvbmcgZnJhbWUgPSBn Zm4gKyBpOworICAgICAgICBwMm1fYWNjZXNzX3QgcDJtYSA9IHAybV9hY2Nl c3NfbjsKKworICAgICAgICBpZiAoIG1hcC0+cmVhZCApCisgICAgICAgICAg ICBwMm1hIHw9IHAybV9hY2Nlc3NfcjsKKyAgICAgICAgaWYgKCBtYXAtPndy aXRlICkKKyAgICAgICAgICAgIHAybWEgfD0gcDJtX2FjY2Vzc193OwogCi0g ICAgICAgIHJ0ID0gYW1kX2lvbW11X21hcF9wYWdlKGRvbWFpbiwgX2Rmbihm cmFtZSksIF9tZm4oZnJhbWUpLCBmbGFncywKLSAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgJmZsdXNoX2ZsYWdzKTsKLSAgICAgICAgaWYgKCBy dCAhPSAwICkKLSAgICAgICAgICAgIGJyZWFrOworICAgICAgICByYyA9IGlv bW11X2lkZW50aXR5X21hcHBpbmcoZCwgcDJtYSwgbWFwLT5hZGRyLAorICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgbWFwLT5hZGRyICsg bWFwLT5sZW5ndGggLSAxLCBmbGFnKTsKICAgICB9CiAKLSAgICAvKiBVc2Ug d2hpbGUtYnJlYWsgdG8gYXZvaWQgY29tcGlsZXIgd2FybmluZyAqLwotICAg IHdoaWxlICggZmx1c2hfZmxhZ3MgJiYKLSAgICAgICAgICAgIGFtZF9pb21t dV9mbHVzaF9pb3RsYl9wYWdlcyhkb21haW4sIF9kZm4oZ2ZuKSwKLSAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBucGFnZXMsIGZs dXNoX2ZsYWdzKSApCi0gICAgICAgIGJyZWFrOworICAgIHJldHVybiByYzsK K30KKworaW50IGFtZF9pb21tdV9yZXNlcnZlX2RvbWFpbl91bml0eV91bm1h cChzdHJ1Y3QgZG9tYWluICpkLAorICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBjb25zdCBzdHJ1Y3QgaXZyc191bml0eV9tYXAg Km1hcCkKK3sKKyAgICBpbnQgcmM7CisKKyAgICBpZiAoIGQgPT0gZG9tX2lv ICkKKyAgICAgICAgcmV0dXJuIDA7CisKKyAgICBmb3IgKCByYyA9IDA7IG1h cDsgbWFwID0gbWFwLT5uZXh0ICkKKyAgICB7CisgICAgICAgIGludCByZXQg PSBpb21tdV9pZGVudGl0eV9tYXBwaW5nKGQsIHAybV9hY2Nlc3NfeCwgbWFw LT5hZGRyLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICBtYXAtPmFkZHIgKyBtYXAtPmxlbmd0aCAtIDEsIDApOworCisgICAg ICAgIGlmICggcmV0ICYmIHJldCAhPSAtRU5PRU5UICYmICFyYyApCisgICAg ICAgICAgICByYyA9IHJldDsKKyAgICB9CiAKLSAgICByZXR1cm4gcnQ7Cisg ICAgcmV0dXJuIHJjOwogfQogCiAvKiBTaGFyZSBwMm0gdGFibGUgd2l0aCBp b21tdS4gKi8KLS0tIGEveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvYW1kL3Bj aV9hbWRfaW9tbXUuYworKysgYi94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC9h bWQvcGNpX2FtZF9pb21tdS5jCkBAIC0zMDcsNiArMzA3LDcgQEAgc3RhdGlj IGludCByZWFzc2lnbl9kZXZpY2Uoc3RydWN0IGRvbWFpbgogICAgIHN0cnVj dCBhbWRfaW9tbXUgKmlvbW11OwogICAgIGludCBiZGYsIHJjOwogICAgIHN0 cnVjdCBkb21haW5faW9tbXUgKnQgPSBkb21faW9tbXUodGFyZ2V0KTsKKyAg ICBjb25zdCBzdHJ1Y3QgaXZyc19tYXBwaW5ncyAqaXZyc19tYXBwaW5ncyA9 IGdldF9pdnJzX21hcHBpbmdzKHBkZXYtPnNlZyk7CiAKICAgICBiZGYgPSBQ Q0lfQkRGMihwZGV2LT5idXMsIHBkZXYtPmRldmZuKTsKICAgICBpb21tdSA9 IGZpbmRfaW9tbXVfZm9yX2RldmljZShwZGV2LT5zZWcsIGJkZik7CkBAIC0z MjEsMTAgKzMyMiwyNCBAQCBzdGF0aWMgaW50IHJlYXNzaWduX2RldmljZShz dHJ1Y3QgZG9tYWluCiAKICAgICBhbWRfaW9tbXVfZGlzYWJsZV9kb21haW5f ZGV2aWNlKHNvdXJjZSwgaW9tbXUsIGRldmZuLCBwZGV2KTsKIAotICAgIGlm ICggZGV2Zm4gPT0gcGRldi0+ZGV2Zm4gKQorICAgIC8qCisgICAgICogSWYg dGhlIGRldmljZSBiZWxvbmdzIHRvIHRoZSBoYXJkd2FyZSBkb21haW4sIGFu ZCBpdCBoYXMgYSB1bml0eSBtYXBwaW5nLAorICAgICAqIGRvbid0IHJlbW92 ZSBpdCBmcm9tIHRoZSBoYXJkd2FyZSBkb21haW4sIGJlY2F1c2UgQklPUyBt YXkgcmVmZXJlbmNlIHRoYXQKKyAgICAgKiBtYXBwaW5nLgorICAgICAqLwor ICAgIGlmICggIWlzX2hhcmR3YXJlX2RvbWFpbihzb3VyY2UpICkKKyAgICB7 CisgICAgICAgIHJjID0gYW1kX2lvbW11X3Jlc2VydmVfZG9tYWluX3VuaXR5 X3VubWFwKAorICAgICAgICAgICAgICAgICBzb3VyY2UsCisgICAgICAgICAg ICAgICAgIGl2cnNfbWFwcGluZ3NbZ2V0X2RtYV9yZXF1ZXN0b3JfaWQocGRl di0+c2VnLCBiZGYpXS51bml0eV9tYXApOworICAgICAgICBpZiAoIHJjICkK KyAgICAgICAgICAgIHJldHVybiByYzsKKyAgICB9CisKKyAgICBpZiAoIGRl dmZuID09IHBkZXYtPmRldmZuICYmIHBkZXYtPmRvbWFpbiAhPSBkb21faW8g KQogICAgIHsKLSAgICAgICAgbGlzdF9tb3ZlKCZwZGV2LT5kb21haW5fbGlz dCwgJnRhcmdldC0+YXJjaC5wZGV2X2xpc3QpOwotICAgICAgICBwZGV2LT5k b21haW4gPSB0YXJnZXQ7CisgICAgICAgIGxpc3RfbW92ZSgmcGRldi0+ZG9t YWluX2xpc3QsICZkb21faW8tPmFyY2gucGRldl9saXN0KTsKKyAgICAgICAg cGRldi0+ZG9tYWluID0gZG9tX2lvOwogICAgIH0KIAogICAgIHJjID0gYWxs b2NhdGVfZG9tYWluX3Jlc291cmNlcyh0KTsKQEAgLTMzNiw2ICszNTEsMTIg QEAgc3RhdGljIGludCByZWFzc2lnbl9kZXZpY2Uoc3RydWN0IGRvbWFpbgog ICAgICAgICAgICAgICAgICAgICBwZGV2LT5zZWcsIHBkZXYtPmJ1cywgUENJ X1NMT1QoZGV2Zm4pLCBQQ0lfRlVOQyhkZXZmbiksCiAgICAgICAgICAgICAg ICAgICAgIHNvdXJjZS0+ZG9tYWluX2lkLCB0YXJnZXQtPmRvbWFpbl9pZCk7 CiAKKyAgICBpZiAoIGRldmZuID09IHBkZXYtPmRldmZuICYmIHBkZXYtPmRv bWFpbiAhPSB0YXJnZXQgKQorICAgIHsKKyAgICAgICAgbGlzdF9tb3ZlKCZw ZGV2LT5kb21haW5fbGlzdCwgJnRhcmdldC0+YXJjaC5wZGV2X2xpc3QpOwor ICAgICAgICBwZGV2LT5kb21haW4gPSB0YXJnZXQ7CisgICAgfQorCiAgICAg cmV0dXJuIDA7CiB9CiAKQEAgLTM0NiwyMCArMzY3LDI4IEBAIHN0YXRpYyBp bnQgYW1kX2lvbW11X2Fzc2lnbl9kZXZpY2Uoc3RydWMKICAgICBzdHJ1Y3Qg aXZyc19tYXBwaW5ncyAqaXZyc19tYXBwaW5ncyA9IGdldF9pdnJzX21hcHBp bmdzKHBkZXYtPnNlZyk7CiAgICAgaW50IGJkZiA9IFBDSV9CREYyKHBkZXYt PmJ1cywgZGV2Zm4pOwogICAgIGludCByZXFfaWQgPSBnZXRfZG1hX3JlcXVl c3Rvcl9pZChwZGV2LT5zZWcsIGJkZik7Ci0gICAgY29uc3Qgc3RydWN0IGl2 cnNfdW5pdHlfbWFwICp1bml0eV9tYXA7CisgICAgaW50IHJjID0gYW1kX2lv bW11X3Jlc2VydmVfZG9tYWluX3VuaXR5X21hcCgKKyAgICAgICAgICAgICAg ICAgZCwgaXZyc19tYXBwaW5nc1tyZXFfaWRdLnVuaXR5X21hcCwgZmxhZyk7 CisKKyAgICBpZiAoICFyYyApCisgICAgICAgIHJjID0gcmVhc3NpZ25fZGV2 aWNlKHBkZXYtPmRvbWFpbiwgZCwgZGV2Zm4sIHBkZXYpOwogCi0gICAgZm9y ICggdW5pdHlfbWFwID0gaXZyc19tYXBwaW5nc1tyZXFfaWRdLnVuaXR5X21h cDsgdW5pdHlfbWFwOwotICAgICAgICAgIHVuaXR5X21hcCA9IHVuaXR5X21h cC0+bmV4dCApCisgICAgaWYgKCByYyAmJiAhaXNfaGFyZHdhcmVfZG9tYWlu KGQpICkKICAgICB7Ci0gICAgICAgIGludCByYyA9IGFtZF9pb21tdV9yZXNl cnZlX2RvbWFpbl91bml0eV9tYXAoCi0gICAgICAgICAgICAgICAgICAgICBk LCB1bml0eV9tYXAtPmFkZHIsIHVuaXR5X21hcC0+bGVuZ3RoLAotICAgICAg ICAgICAgICAgICAgICAgdW5pdHlfbWFwLT53cml0ZSwgdW5pdHlfbWFwLT5y ZWFkKTsKKyAgICAgICAgaW50IHJldCA9IGFtZF9pb21tdV9yZXNlcnZlX2Rv bWFpbl91bml0eV91bm1hcCgKKyAgICAgICAgICAgICAgICAgICAgICBkLCBp dnJzX21hcHBpbmdzW3JlcV9pZF0udW5pdHlfbWFwKTsKIAotICAgICAgICBp ZiAoIHJjICkKLSAgICAgICAgICAgIHJldHVybiByYzsKKyAgICAgICAgaWYg KCByZXQgKQorICAgICAgICB7CisgICAgICAgICAgICBwcmludGsoWEVOTE9H X0VSUiAiQU1ELVZpOiAiCisgICAgICAgICAgICAgICAgICAgInVuaXR5LXVu bWFwIGZvciAlcGQvJTA0eDolMDJ4OiUwMnguJXUgZmFpbGVkICglZClcbiIs CisgICAgICAgICAgICAgICAgICAgZCwgcGRldi0+c2VnLCBwZGV2LT5idXMs CisgICAgICAgICAgICAgICAgICAgUENJX1NMT1QoZGV2Zm4pLCBQQ0lfRlVO QyhkZXZmbiksIHJldCk7CisgICAgICAgICAgICBkb21haW5fY3Jhc2goZCk7 CisgICAgICAgIH0KICAgICB9CiAKLSAgICByZXR1cm4gcmVhc3NpZ25fZGV2 aWNlKHBkZXYtPmRvbWFpbiwgZCwgZGV2Zm4sIHBkZXYpOworICAgIHJldHVy biByYzsKIH0KIAogc3RhdGljIHZvaWQgZGVhbGxvY2F0ZV9uZXh0X3BhZ2Vf dGFibGUoc3RydWN0IHBhZ2VfaW5mbyAqcGcsIGludCBsZXZlbCkKQEAgLTQy NSw2ICs0NTQsNyBAQCBzdGF0aWMgdm9pZCBkZWFsbG9jYXRlX2lvbW11X3Bh Z2VfdGFibGVzCiAKIHN0YXRpYyB2b2lkIGFtZF9pb21tdV9kb21haW5fZGVz dHJveShzdHJ1Y3QgZG9tYWluICpkKQogeworICAgIGlvbW11X2lkZW50aXR5 X21hcF90ZWFyZG93bihkKTsKICAgICBkZWFsbG9jYXRlX2lvbW11X3BhZ2Vf dGFibGVzKGQpOwogICAgIGFtZF9pb21tdV9mbHVzaF9hbGxfcGFnZXMoZCk7 CiB9Ci0tLSBhL3hlbi9pbmNsdWRlL2FzbS14ODYvaHZtL3N2bS9hbWQtaW9t bXUtcHJvdG8uaAorKysgYi94ZW4vaW5jbHVkZS9hc20teDg2L2h2bS9zdm0v YW1kLWlvbW11LXByb3RvLmgKQEAgLTYyLDggKzYyLDEwIEBAIGludCBfX211 c3RfY2hlY2sgYW1kX2lvbW11X3VubWFwX3BhZ2Uoc3QKIHVpbnQ2NF90IGFt ZF9pb21tdV9nZXRfYWRkcmVzc19mcm9tX3B0ZSh2b2lkICplbnRyeSk7CiBp bnQgX19tdXN0X2NoZWNrIGFtZF9pb21tdV9hbGxvY19yb290KHN0cnVjdCBk b21haW5faW9tbXUgKmhkKTsKIGludCBhbWRfaW9tbXVfcmVzZXJ2ZV9kb21h aW5fdW5pdHlfbWFwKHN0cnVjdCBkb21haW4gKmRvbWFpbiwKLSAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHBhZGRyX3QgcGh5c19h ZGRyLCB1bnNpZ25lZCBsb25nIHNpemUsCi0gICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICBpbnQgaXcsIGludCBpcik7CisgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjb25zdCBzdHJ1Y3Qg aXZyc191bml0eV9tYXAgKm1hcCwKKyAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIHVuc2lnbmVkIGludCBmbGFnKTsKK2ludCBhbWRf aW9tbXVfcmVzZXJ2ZV9kb21haW5fdW5pdHlfdW5tYXAoc3RydWN0IGRvbWFp biAqZCwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgY29uc3Qgc3RydWN0IGl2cnNfdW5pdHlfbWFwICptYXApOwogaW50IF9f bXVzdF9jaGVjayBhbWRfaW9tbXVfZmx1c2hfaW90bGJfcGFnZXMoc3RydWN0 IGRvbWFpbiAqZCwgZGZuX3QgZGZuLAogICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgdW5zaWduZWQgaW50IHBhZ2VfY291 bnQsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICB1bnNpZ25lZCBpbnQgZmx1c2hfZmxhZ3MpOwo= --=separator Content-Type: application/octet-stream; name="xsa378/xsa378-4.12-6.patch" Content-Disposition: attachment; filename="xsa378/xsa378-4.12-6.patch" Content-Transfer-Encoding: base64 RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0 OiBBTUQvSU9NTVU6IHJlLWFycmFuZ2UgZXhjbHVzaW9uIHJhbmdlIGFuZCB1 bml0eSBtYXAgcmVjb3JkaW5nCgpUaGUgc3BlYyBtYWtlcyBubyBwcm92aXNp b25zIGZvciBPUyBiZWhhdmlvciBoZXJlIHRvIGRlcGVuZCBvbiB0aGUKYW1v dW50IG9mIFJBTSBmb3VuZCBvbiB0aGUgc3lzdGVtLiBXaGlsZSB0aGUgc3Bl YyBtYXkgbm90IHN1ZmZpY2llbnRseQpjbGVhcmx5IGRpc3Rpbmd1aXNoIGJv dGgga2luZHMgb2YgcmVnaW9ucywgdGhleSBhcmUgc3VyZWx5IG1lYW50IHRv IGJlCnNlcGFyYXRlIHRoaW5nczogT25seSByZWdpb25zIHdpdGggQUNQSV9J Vk1EX0VYQ0xVU0lPTl9SQU5HRSBzZXQgc2hvdWxkCmJlIGNhbmRpZGF0ZXMg Zm9yIHB1dHRpbmcgaW4gdGhlIGV4Y2x1c2lvbiByYW5nZSByZWdpc3RlcnMu IChBcyB0aGVyZSdzCm9ubHkgYSBzaW5nbGUgc3VjaCBwYWlyIG9mIHJlZ2lz dGVycyBwZXIgSU9NTVUsIHNlY29uZGFyeSBub24tYWRqYWNlbnQKcmVnaW9u cyB3aXRoIHRoZSBmbGFnIHNldCBhbHJlYWR5IGdldCBjb252ZXJ0ZWQgdG8g dW5pdHkgbWFwcGVkCnJlZ2lvbnMuKQoKRmlyc3Qgb2YgYWxsLCBkcm9wIHRo ZSBkZXBlbmRlbmN5IG9uIG1heF9wYWdlLiBXaXRoIGNvbW1pdCBiNGYwNDIy MzZhZTAKKCJBTUQvSU9NTVU6IENlYXNlIHVzaW5nIGEgZHluYW1pYyBoZWln aHQgZm9yIHRoZSBJT01NVSBwYWdldGFibGVzIikgdGhlCnVzZSBvZiBpdCBo ZXJlIHdhcyBzdGFsZSBhbnl3YXk7IGl0IHdhcyBib2d1cyBhbHJlYWR5IGJl Zm9yZSwgYXMgaXQKZGlkbid0IGFjY291bnQgZm9yIG1heF9wYWdlIGdldHRp bmcgaW5jcmVhc2VkIGxhdGVyIG9uLiBTaW1wbHkgdHJ5IGFuCmV4Y2x1c2lv biByYW5nZSByZWdpc3RyYXRpb24gZmlyc3QsIGFuZCBpZiBpdCBmYWlscyAo Zm9yIGJlaW5nCnVuc3VpdGFibGUgb3Igbm9uLW1lcmdlYWJsZSksIHJlZ2lz dGVyIGEgdW5pdHkgbWFwcGluZyByYW5nZS4KCldpdGggdGhpcyB2YXJpb3Vz IGxvY2FsIHZhcmlhYmxlcyBiZWNvbWUgdW5uZWNlc3NhcnkgYW5kIGhlbmNl IGdldApkcm9wcGVkIGF0IHRoZSBzYW1lIHRpbWUuCgpXaXRoIHRoZSBtYXhf cGFnZSBib3VuZGFyeSBkcm9wcGVkIGZvciB1c2luZyB1bml0eSBtYXBzLCB0 aGUgbWluaW11bQpwYWdlIHRhYmxlIHRyZWUgaGVpZ2h0IG5vdyBuZWVkcyBi b3RoIHJlY29yZGluZyBhbmQgZW5mb3JjaW5nIGluCmFtZF9pb21tdV9kb21h aW5faW5pdCgpLiBTaW5jZSB3ZSBjYW4ndCBwcmVkaWN0IHdoaWNoIGRldmlj ZXMgbWF5IGdldAphc3NpZ25lZCB0byBhIGRvbWFpbiwgb3VyIG9ubHkgb3B0 aW9uIGlzIHRvIHVuaWZvcm1seSBmb3JjZSBhdCBsZWFzdAp0aGF0IGhlaWdo dCBmb3IgYWxsIGRvbWFpbnMsIG5vdyB0aGF0IHRoZSBoZWlnaHQgaXNuJ3Qg ZHluYW1pYyBhbnltb3JlLgoKRnVydGhlciBkb24ndCBtYWtlIHVzZSBvZiB0 aGUgZXhjbHVzaW9uIHJhbmdlIHVubGVzcyBBQ1BJIGRhdGEgc2F5cyBzby4K Ck5vdGUgdGhhdCBleGNsdXNpb24gcmFuZ2UgcmVnaXN0cmF0aW9uIGluCnJl Z2lzdGVyX3JhbmdlX2Zvcl9hbGxfZGV2aWNlcygpIGlzIG9uIGEgYmVzdCBl ZmZvcnQgYmFzaXMuIEhlbmNlIHVuaXR5Cm1hcCBlbnRyaWVzIGFsc28gcmVn aXN0ZXJlZCBhcmUgcmVkdW5kYW50IHdoZW4gdGhlIGZvcm1lciBzdWNjZWVk ZWQsIGJ1dAp0aGV5IGFsc28gZG8gbm8gaGFybS4gSW1wcm92ZW1lbnRzIGlu IHRoaXMgYXJlYSBjYW4gYmUgZG9uZSBsYXRlciBpbW8uCgpBbHNvIGFkanVz dCB0eXBlcyB3aGVyZSBzdWl0YWJsZSB3aXRob3V0IHRvdWNoaW5nIGV4dHJh IGxpbmVzLgoKVGhpcyBpcyBwYXJ0IG9mIFhTQS0zNzguCgpTaWduZWQtb2Zm LWJ5OiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+ClJldmlld2Vk LWJ5OiBQYXVsIER1cnJhbnQgPHBhdWxAeGVuLm9yZz4KCi0tLSBhL3hlbi9k cml2ZXJzL3Bhc3N0aHJvdWdoL2FtZC9pb21tdV9hY3BpLmMKKysrIGIveGVu L2RyaXZlcnMvcGFzc3Rocm91Z2gvYW1kL2lvbW11X2FjcGkuYwpAQCAtOTks MTIgKzk5LDggQEAgc3RhdGljIHN0cnVjdCBhbWRfaW9tbXUgKiBfX2luaXQg ZmluZF9pbwogfQogCiBzdGF0aWMgaW50IF9faW5pdCByZXNlcnZlX2lvbW11 X2V4Y2x1c2lvbl9yYW5nZSgKLSAgICBzdHJ1Y3QgYW1kX2lvbW11ICppb21t dSwgdWludDY0X3QgYmFzZSwgdWludDY0X3QgbGltaXQsCi0gICAgYm9vbCBh bGwsIGJvb2wgaXcsIGJvb2wgaXIpCisgICAgc3RydWN0IGFtZF9pb21tdSAq aW9tbXUsIHBhZGRyX3QgYmFzZSwgcGFkZHJfdCBsaW1pdCwgYm9vbCBhbGwp CiB7Ci0gICAgaWYgKCAhaXIgfHwgIWl3ICkKLSAgICAgICAgcmV0dXJuIC1F UEVSTTsKLQogICAgIC8qIG5lZWQgdG8gZXh0ZW5kIGV4Y2x1c2lvbiByYW5n ZT8gKi8KICAgICBpZiAoIGlvbW11LT5leGNsdXNpb25fZW5hYmxlICkKICAg ICB7CkBAIC0xMzMsMTQgKzEyOSwxOCBAQCBzdGF0aWMgaW50IF9faW5pdCBy ZXNlcnZlX3VuaXR5X21hcF9mb3JfCiB7CiAgICAgc3RydWN0IGl2cnNfbWFw cGluZ3MgKml2cnNfbWFwcGluZ3MgPSBnZXRfaXZyc19tYXBwaW5ncyhzZWcp OwogICAgIHN0cnVjdCBpdnJzX3VuaXR5X21hcCAqdW5pdHlfbWFwID0gaXZy c19tYXBwaW5nc1tiZGZdLnVuaXR5X21hcDsKKyAgICBpbnQgcGFnaW5nX21v ZGUgPSBhbWRfaW9tbXVfZ2V0X3BhZ2luZ19tb2RlKFBGTl9VUChiYXNlICsg bGVuZ3RoKSk7CisKKyAgICBpZiAoIHBhZ2luZ19tb2RlIDwgMCApCisgICAg ICAgIHJldHVybiBwYWdpbmdfbW9kZTsKIAogICAgIC8qIENoZWNrIGZvciBv dmVybGFwcy4gKi8KICAgICBmb3IgKCA7IHVuaXR5X21hcDsgdW5pdHlfbWFw ID0gdW5pdHlfbWFwLT5uZXh0ICkKICAgICB7CiAgICAgICAgIC8qCiAgICAg ICAgICAqIEV4YWN0IG1hdGNoZXMgYXJlIG9rYXkuIFRoaXMgY2FuIGluIHBh cnRpY3VsYXIgaGFwcGVuIHdoZW4KLSAgICAgICAgICogcmVnaXN0ZXJfZXhj bHVzaW9uX3JhbmdlX2Zvcl9kZXZpY2UoKSBjYWxscyBoZXJlIHR3aWNlIGZv ciB0aGUKLSAgICAgICAgICogc2FtZSAocyxiLGQsZikuCisgICAgICAgICAq IHJlZ2lzdGVyX3JhbmdlX2Zvcl9kZXZpY2UoKSBjYWxscyBoZXJlIHR3aWNl IGZvciB0aGUgc2FtZQorICAgICAgICAgKiAocyxiLGQsZikuCiAgICAgICAg ICAqLwogICAgICAgICBpZiAoIGJhc2UgPT0gdW5pdHlfbWFwLT5hZGRyICYm IGxlbmd0aCA9PSB1bml0eV9tYXAtPmxlbmd0aCAmJgogICAgICAgICAgICAg IGlyID09IHVuaXR5X21hcC0+cmVhZCAmJiBpdyA9PSB1bml0eV9tYXAtPndy aXRlICkKQEAgLTE2OCw1NSArMTY4LDUyIEBAIHN0YXRpYyBpbnQgX19pbml0 IHJlc2VydmVfdW5pdHlfbWFwX2Zvcl8KICAgICB1bml0eV9tYXAtPm5leHQg PSBpdnJzX21hcHBpbmdzW2JkZl0udW5pdHlfbWFwOwogICAgIGl2cnNfbWFw cGluZ3NbYmRmXS51bml0eV9tYXAgPSB1bml0eV9tYXA7CiAKKyAgICBpZiAo IHBhZ2luZ19tb2RlID4gYW1kX2lvbW11X21pbl9wYWdpbmdfbW9kZSApCisg ICAgICAgIGFtZF9pb21tdV9taW5fcGFnaW5nX21vZGUgPSBwYWdpbmdfbW9k ZTsKKwogICAgIHJldHVybiAwOwogfQogCi1zdGF0aWMgaW50IF9faW5pdCBy ZWdpc3Rlcl9leGNsdXNpb25fcmFuZ2VfZm9yX2FsbF9kZXZpY2VzKAotICAg IHVuc2lnbmVkIGxvbmcgYmFzZSwgdW5zaWduZWQgbG9uZyBsaW1pdCwgdTgg aXcsIHU4IGlyKQorc3RhdGljIGludCBfX2luaXQgcmVnaXN0ZXJfcmFuZ2Vf Zm9yX2FsbF9kZXZpY2VzKAorICAgIHBhZGRyX3QgYmFzZSwgcGFkZHJfdCBs aW1pdCwgYm9vbCBpdywgYm9vbCBpciwgYm9vbCBleGNsdXNpb24pCiB7CiAg ICAgaW50IHNlZyA9IDA7IC8qIFhYWCAqLwotICAgIHVuc2lnbmVkIGxvbmcg cmFuZ2VfdG9wLCBpb21tdV90b3AsIGxlbmd0aDsKICAgICBzdHJ1Y3QgYW1k X2lvbW11ICppb21tdTsKLSAgICB1bnNpZ25lZCBpbnQgYmRmOwogICAgIGlu dCByYyA9IDA7CiAKICAgICAvKiBpcyBwYXJ0IG9mIGV4Y2x1c2lvbiByYW5n ZSBpbnNpZGUgb2YgSU9NTVUgdmlydHVhbCBhZGRyZXNzIHNwYWNlPyAqLwog ICAgIC8qIG5vdGU6ICdsaW1pdCcgcGFyYW1ldGVyIGlzIGFzc3VtZWQgdG8g YmUgcGFnZS1hbGlnbmVkICovCi0gICAgcmFuZ2VfdG9wID0gbGltaXQgKyBQ QUdFX1NJWkU7Ci0gICAgaW9tbXVfdG9wID0gbWF4X3BhZ2UgKiBQQUdFX1NJ WkU7Ci0gICAgaWYgKCBiYXNlIDwgaW9tbXVfdG9wICkKLSAgICB7Ci0gICAg ICAgIGlmICggcmFuZ2VfdG9wID4gaW9tbXVfdG9wICkKLSAgICAgICAgICAg IHJhbmdlX3RvcCA9IGlvbW11X3RvcDsKLSAgICAgICAgbGVuZ3RoID0gcmFu Z2VfdG9wIC0gYmFzZTsKLSAgICAgICAgLyogcmVzZXJ2ZSByL3cgdW5pdHkt bWFwcGVkIHBhZ2UgZW50cmllcyBmb3IgZGV2aWNlcyAqLwotICAgICAgICAv KiBub3RlOiB0aGVzZSBlbnRyaWVzIGFyZSBwYXJ0IG9mIHRoZSBleGNsdXNp b24gcmFuZ2UgKi8KLSAgICAgICAgZm9yICggYmRmID0gMDsgIXJjICYmIGJk ZiA8IGl2cnNfYmRmX2VudHJpZXM7IGJkZisrICkKLSAgICAgICAgICAgIHJj ID0gcmVzZXJ2ZV91bml0eV9tYXBfZm9yX2RldmljZShzZWcsIGJkZiwgYmFz ZSwgbGVuZ3RoLCBpdywgaXIpOwotICAgICAgICAvKiBwdXNoICdiYXNlJyBq dXN0IG91dHNpZGUgb2YgdmlydHVhbCBhZGRyZXNzIHNwYWNlICovCi0gICAg ICAgIGJhc2UgPSBpb21tdV90b3A7Ci0gICAgfQotICAgIC8qIHJlZ2lzdGVy IElPTU1VIGV4Y2x1c2lvbiByYW5nZSBzZXR0aW5ncyAqLwotICAgIGlmICgg IXJjICYmIGxpbWl0ID49IGlvbW11X3RvcCApCisgICAgaWYgKCBleGNsdXNp b24gKQogICAgIHsKICAgICAgICAgZm9yX2VhY2hfYW1kX2lvbW11KCBpb21t dSApCiAgICAgICAgIHsKLSAgICAgICAgICAgIHJjID0gcmVzZXJ2ZV9pb21t dV9leGNsdXNpb25fcmFuZ2UoaW9tbXUsIGJhc2UsIGxpbWl0LAotICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB0cnVl IC8qIGFsbCAqLywgaXcsIGlyKTsKLSAgICAgICAgICAgIGlmICggcmMgKQot ICAgICAgICAgICAgICAgIGJyZWFrOworICAgICAgICAgICAgaW50IHJldCA9 IHJlc2VydmVfaW9tbXVfZXhjbHVzaW9uX3JhbmdlKGlvbW11LCBiYXNlLCBs aW1pdCwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICB0cnVlIC8qIGFsbCAqLyk7CisKKyAgICAgICAgICAg IGlmICggcmV0ICYmICFyYyApCisgICAgICAgICAgICAgICAgcmMgPSByZXQ7 CiAgICAgICAgIH0KICAgICB9CiAKKyAgICBpZiAoICFleGNsdXNpb24gfHwg cmMgKQorICAgIHsKKyAgICAgICAgcGFkZHJfdCBsZW5ndGggPSBsaW1pdCAr IFBBR0VfU0laRSAtIGJhc2U7CisgICAgICAgIHVuc2lnbmVkIGludCBiZGY7 CisKKyAgICAgICAgLyogcmVzZXJ2ZSByL3cgdW5pdHktbWFwcGVkIHBhZ2Ug ZW50cmllcyBmb3IgZGV2aWNlcyAqLworICAgICAgICBmb3IgKCBiZGYgPSBy YyA9IDA7ICFyYyAmJiBiZGYgPCBpdnJzX2JkZl9lbnRyaWVzOyBiZGYrKyAp CisgICAgICAgICAgICByYyA9IHJlc2VydmVfdW5pdHlfbWFwX2Zvcl9kZXZp Y2Uoc2VnLCBiZGYsIGJhc2UsIGxlbmd0aCwgaXcsIGlyKTsKKyAgICB9CisK ICAgICByZXR1cm4gcmM7CiB9CiAKLXN0YXRpYyBpbnQgX19pbml0IHJlZ2lz dGVyX2V4Y2x1c2lvbl9yYW5nZV9mb3JfZGV2aWNlKAotICAgIHUxNiBiZGYs IHVuc2lnbmVkIGxvbmcgYmFzZSwgdW5zaWduZWQgbG9uZyBsaW1pdCwgdTgg aXcsIHU4IGlyKQorc3RhdGljIGludCBfX2luaXQgcmVnaXN0ZXJfcmFuZ2Vf Zm9yX2RldmljZSgKKyAgICB1bnNpZ25lZCBpbnQgYmRmLCBwYWRkcl90IGJh c2UsIHBhZGRyX3QgbGltaXQsCisgICAgYm9vbCBpdywgYm9vbCBpciwgYm9v bCBleGNsdXNpb24pCiB7CiAgICAgaW50IHNlZyA9IDA7IC8qIFhYWCAqLwog ICAgIHN0cnVjdCBpdnJzX21hcHBpbmdzICppdnJzX21hcHBpbmdzID0gZ2V0 X2l2cnNfbWFwcGluZ3Moc2VnKTsKLSAgICB1bnNpZ25lZCBsb25nIHJhbmdl X3RvcCwgaW9tbXVfdG9wLCBsZW5ndGg7CiAgICAgc3RydWN0IGFtZF9pb21t dSAqaW9tbXU7CiAgICAgdTE2IHJlcTsKICAgICBpbnQgcmMgPSAwOwpAQCAt MjMwLDI3ICsyMjcsMTkgQEAgc3RhdGljIGludCBfX2luaXQgcmVnaXN0ZXJf ZXhjbHVzaW9uX3JhbgogICAgIHJlcSA9IGl2cnNfbWFwcGluZ3NbYmRmXS5k dGVfcmVxdWVzdG9yX2lkOwogCiAgICAgLyogbm90ZTogJ2xpbWl0JyBwYXJh bWV0ZXIgaXMgYXNzdW1lZCB0byBiZSBwYWdlLWFsaWduZWQgKi8KLSAgICBy YW5nZV90b3AgPSBsaW1pdCArIFBBR0VfU0laRTsKLSAgICBpb21tdV90b3Ag PSBtYXhfcGFnZSAqIFBBR0VfU0laRTsKLSAgICBpZiAoIGJhc2UgPCBpb21t dV90b3AgKQotICAgIHsKLSAgICAgICAgaWYgKCByYW5nZV90b3AgPiBpb21t dV90b3AgKQotICAgICAgICAgICAgcmFuZ2VfdG9wID0gaW9tbXVfdG9wOwot ICAgICAgICBsZW5ndGggPSByYW5nZV90b3AgLSBiYXNlOworICAgIGlmICgg ZXhjbHVzaW9uICkKKyAgICAgICAgcmMgPSByZXNlcnZlX2lvbW11X2V4Y2x1 c2lvbl9yYW5nZShpb21tdSwgYmFzZSwgbGltaXQsCisgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZmFsc2UgLyogYWxsICov KTsKKyAgICBpZiAoICFleGNsdXNpb24gfHwgcmMgKQorICAgIHsKKyAgICAg ICAgcGFkZHJfdCBsZW5ndGggPSBsaW1pdCArIFBBR0VfU0laRSAtIGJhc2U7 CisKICAgICAgICAgLyogcmVzZXJ2ZSB1bml0eS1tYXBwZWQgcGFnZSBlbnRy aWVzIGZvciBkZXZpY2UgKi8KLSAgICAgICAgLyogbm90ZTogdGhlc2UgZW50 cmllcyBhcmUgcGFydCBvZiB0aGUgZXhjbHVzaW9uIHJhbmdlICovCiAgICAg ICAgIHJjID0gcmVzZXJ2ZV91bml0eV9tYXBfZm9yX2RldmljZShzZWcsIGJk ZiwgYmFzZSwgbGVuZ3RoLCBpdywgaXIpID86CiAgICAgICAgICAgICAgcmVz ZXJ2ZV91bml0eV9tYXBfZm9yX2RldmljZShzZWcsIHJlcSwgYmFzZSwgbGVu Z3RoLCBpdywgaXIpOwotCi0gICAgICAgIC8qIHB1c2ggJ2Jhc2UnIGp1c3Qg b3V0c2lkZSBvZiB2aXJ0dWFsIGFkZHJlc3Mgc3BhY2UgKi8KLSAgICAgICAg YmFzZSA9IGlvbW11X3RvcDsKICAgICB9Ci0KLSAgICAvKiByZWdpc3RlciBJ T01NVSBleGNsdXNpb24gcmFuZ2Ugc2V0dGluZ3MgZm9yIGRldmljZSAqLwot ICAgIGlmICggIXJjICYmIGxpbWl0ID49IGlvbW11X3RvcCAgKQorICAgIGVs c2UKICAgICB7Ci0gICAgICAgIHJjID0gcmVzZXJ2ZV9pb21tdV9leGNsdXNp b25fcmFuZ2UoaW9tbXUsIGJhc2UsIGxpbWl0LAotICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIGZhbHNlIC8qIGFsbCAqLywg aXcsIGlyKTsKICAgICAgICAgaXZyc19tYXBwaW5nc1tiZGZdLmR0ZV9hbGxv d19leGNsdXNpb24gPSBJT01NVV9DT05UUk9MX0VOQUJMRUQ7CiAgICAgICAg IGl2cnNfbWFwcGluZ3NbcmVxXS5kdGVfYWxsb3dfZXhjbHVzaW9uID0gSU9N TVVfQ09OVFJPTF9FTkFCTEVEOwogICAgIH0KQEAgLTI1OCw1MyArMjQ3LDQy IEBAIHN0YXRpYyBpbnQgX19pbml0IHJlZ2lzdGVyX2V4Y2x1c2lvbl9yYW4K ICAgICByZXR1cm4gcmM7CiB9CiAKLXN0YXRpYyBpbnQgX19pbml0IHJlZ2lz dGVyX2V4Y2x1c2lvbl9yYW5nZV9mb3JfaW9tbXVfZGV2aWNlcygKLSAgICBz dHJ1Y3QgYW1kX2lvbW11ICppb21tdSwKLSAgICB1bnNpZ25lZCBsb25nIGJh c2UsIHVuc2lnbmVkIGxvbmcgbGltaXQsIHU4IGl3LCB1OCBpcikKK3N0YXRp YyBpbnQgX19pbml0IHJlZ2lzdGVyX3JhbmdlX2Zvcl9pb21tdV9kZXZpY2Vz KAorICAgIHN0cnVjdCBhbWRfaW9tbXUgKmlvbW11LCBwYWRkcl90IGJhc2Us IHBhZGRyX3QgbGltaXQsCisgICAgYm9vbCBpdywgYm9vbCBpciwgYm9vbCBl eGNsdXNpb24pCiB7Ci0gICAgdW5zaWduZWQgbG9uZyByYW5nZV90b3AsIGlv bW11X3RvcCwgbGVuZ3RoOworICAgIC8qIG5vdGU6ICdsaW1pdCcgcGFyYW1l dGVyIGlzIGFzc3VtZWQgdG8gYmUgcGFnZS1hbGlnbmVkICovCisgICAgcGFk ZHJfdCBsZW5ndGggPSBsaW1pdCArIFBBR0VfU0laRSAtIGJhc2U7CiAgICAg dW5zaWduZWQgaW50IGJkZjsKICAgICB1MTYgcmVxOwotICAgIGludCByYyA9 IDA7CisgICAgaW50IHJjOwogCi0gICAgLyogaXMgcGFydCBvZiBleGNsdXNp b24gcmFuZ2UgaW5zaWRlIG9mIElPTU1VIHZpcnR1YWwgYWRkcmVzcyBzcGFj ZT8gKi8KLSAgICAvKiBub3RlOiAnbGltaXQnIHBhcmFtZXRlciBpcyBhc3N1 bWVkIHRvIGJlIHBhZ2UtYWxpZ25lZCAqLwotICAgIHJhbmdlX3RvcCA9IGxp bWl0ICsgUEFHRV9TSVpFOwotICAgIGlvbW11X3RvcCA9IG1heF9wYWdlICog UEFHRV9TSVpFOwotICAgIGlmICggYmFzZSA8IGlvbW11X3RvcCApCi0gICAg ewotICAgICAgICBpZiAoIHJhbmdlX3RvcCA+IGlvbW11X3RvcCApCi0gICAg ICAgICAgICByYW5nZV90b3AgPSBpb21tdV90b3A7Ci0gICAgICAgIGxlbmd0 aCA9IHJhbmdlX3RvcCAtIGJhc2U7Ci0gICAgICAgIC8qIHJlc2VydmUgci93 IHVuaXR5LW1hcHBlZCBwYWdlIGVudHJpZXMgZm9yIGRldmljZXMgKi8KLSAg ICAgICAgLyogbm90ZTogdGhlc2UgZW50cmllcyBhcmUgcGFydCBvZiB0aGUg ZXhjbHVzaW9uIHJhbmdlICovCi0gICAgICAgIGZvciAoIGJkZiA9IDA7ICFy YyAmJiBiZGYgPCBpdnJzX2JkZl9lbnRyaWVzOyBiZGYrKyApCi0gICAgICAg IHsKLSAgICAgICAgICAgIGlmICggaW9tbXUgPT0gZmluZF9pb21tdV9mb3Jf ZGV2aWNlKGlvbW11LT5zZWcsIGJkZikgKQotICAgICAgICAgICAgewotICAg ICAgICAgICAgICAgIHJlcSA9IGdldF9pdnJzX21hcHBpbmdzKGlvbW11LT5z ZWcpW2JkZl0uZHRlX3JlcXVlc3Rvcl9pZDsKLSAgICAgICAgICAgICAgICBy YyA9IHJlc2VydmVfdW5pdHlfbWFwX2Zvcl9kZXZpY2UoaW9tbXUtPnNlZywg YmRmLCBiYXNlLCBsZW5ndGgsCi0gICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIGl3LCBpcikgPzoKLSAgICAgICAg ICAgICAgICAgICAgIHJlc2VydmVfdW5pdHlfbWFwX2Zvcl9kZXZpY2UoaW9t bXUtPnNlZywgcmVxLCBiYXNlLCBsZW5ndGgsCi0gICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGl3LCBpcik7Ci0g ICAgICAgICAgICB9Ci0gICAgICAgIH0KLQotICAgICAgICAvKiBwdXNoICdi YXNlJyBqdXN0IG91dHNpZGUgb2YgdmlydHVhbCBhZGRyZXNzIHNwYWNlICov Ci0gICAgICAgIGJhc2UgPSBpb21tdV90b3A7CisgICAgaWYgKCBleGNsdXNp b24gKQorICAgIHsKKyAgICAgICAgcmMgPSByZXNlcnZlX2lvbW11X2V4Y2x1 c2lvbl9yYW5nZShpb21tdSwgYmFzZSwgbGltaXQsIHRydWUgLyogYWxsICov KTsKKyAgICAgICAgaWYgKCAhcmMgKQorICAgICAgICAgICAgcmV0dXJuIDA7 CiAgICAgfQogCi0gICAgLyogcmVnaXN0ZXIgSU9NTVUgZXhjbHVzaW9uIHJh bmdlIHNldHRpbmdzICovCi0gICAgaWYgKCAhcmMgJiYgbGltaXQgPj0gaW9t bXVfdG9wICkKLSAgICAgICAgcmMgPSByZXNlcnZlX2lvbW11X2V4Y2x1c2lv bl9yYW5nZShpb21tdSwgYmFzZSwgbGltaXQsCi0gICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgdHJ1ZSAvKiBhbGwgKi8sIGl3 LCBpcik7CisgICAgLyogcmVzZXJ2ZSB1bml0eS1tYXBwZWQgcGFnZSBlbnRy aWVzIGZvciBkZXZpY2VzICovCisgICAgZm9yICggYmRmID0gcmMgPSAwOyAh cmMgJiYgYmRmIDwgaXZyc19iZGZfZW50cmllczsgYmRmKysgKQorICAgIHsK KyAgICAgICAgaWYgKCBpb21tdSAhPSBmaW5kX2lvbW11X2Zvcl9kZXZpY2Uo aW9tbXUtPnNlZywgYmRmKSApCisgICAgICAgICAgICBjb250aW51ZTsKKwor ICAgICAgICByZXEgPSBnZXRfaXZyc19tYXBwaW5ncyhpb21tdS0+c2VnKVti ZGZdLmR0ZV9yZXF1ZXN0b3JfaWQ7CisgICAgICAgIHJjID0gcmVzZXJ2ZV91 bml0eV9tYXBfZm9yX2RldmljZShpb21tdS0+c2VnLCBiZGYsIGJhc2UsIGxl bmd0aCwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIGl3LCBpcikgPzoKKyAgICAgICAgICAgICByZXNlcnZlX3VuaXR5X21h cF9mb3JfZGV2aWNlKGlvbW11LT5zZWcsIHJlcSwgYmFzZSwgbGVuZ3RoLAor ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgaXcs IGlyKTsKKyAgICB9CiAKICAgICByZXR1cm4gcmM7CiB9CiAKIHN0YXRpYyBp bnQgX19pbml0IHBhcnNlX2l2bWRfZGV2aWNlX3NlbGVjdCgKICAgICBjb25z dCBzdHJ1Y3QgYWNwaV9pdnJzX21lbW9yeSAqaXZtZF9ibG9jaywKLSAgICB1 bnNpZ25lZCBsb25nIGJhc2UsIHVuc2lnbmVkIGxvbmcgbGltaXQsIHU4IGl3 LCB1OCBpcikKKyAgICBwYWRkcl90IGJhc2UsIHBhZGRyX3QgbGltaXQsIGJv b2wgaXcsIGJvb2wgaXIsIGJvb2wgZXhjbHVzaW9uKQogewogICAgIHUxNiBi ZGY7CiAKQEAgLTMxNSwxMiArMjkzLDEyIEBAIHN0YXRpYyBpbnQgX19pbml0 IHBhcnNlX2l2bWRfZGV2aWNlX3NlbGUKICAgICAgICAgcmV0dXJuIC1FTk9E RVY7CiAgICAgfQogCi0gICAgcmV0dXJuIHJlZ2lzdGVyX2V4Y2x1c2lvbl9y YW5nZV9mb3JfZGV2aWNlKGJkZiwgYmFzZSwgbGltaXQsIGl3LCBpcik7Cisg ICAgcmV0dXJuIHJlZ2lzdGVyX3JhbmdlX2Zvcl9kZXZpY2UoYmRmLCBiYXNl LCBsaW1pdCwgaXcsIGlyLCBleGNsdXNpb24pOwogfQogCiBzdGF0aWMgaW50 IF9faW5pdCBwYXJzZV9pdm1kX2RldmljZV9yYW5nZSgKICAgICBjb25zdCBz dHJ1Y3QgYWNwaV9pdnJzX21lbW9yeSAqaXZtZF9ibG9jaywKLSAgICB1bnNp Z25lZCBsb25nIGJhc2UsIHVuc2lnbmVkIGxvbmcgbGltaXQsIHU4IGl3LCB1 OCBpcikKKyAgICBwYWRkcl90IGJhc2UsIHBhZGRyX3QgbGltaXQsIGJvb2wg aXcsIGJvb2wgaXIsIGJvb2wgZXhjbHVzaW9uKQogewogICAgIHVuc2lnbmVk IGludCBmaXJzdF9iZGYsIGxhc3RfYmRmLCBiZGY7CiAgICAgaW50IGVycm9y OwpAQCAtMzQyLDE1ICszMjAsMTUgQEAgc3RhdGljIGludCBfX2luaXQgcGFy c2VfaXZtZF9kZXZpY2VfcmFuZwogICAgIH0KIAogICAgIGZvciAoIGJkZiA9 IGZpcnN0X2JkZiwgZXJyb3IgPSAwOyAoYmRmIDw9IGxhc3RfYmRmKSAmJiAh ZXJyb3I7IGJkZisrICkKLSAgICAgICAgZXJyb3IgPSByZWdpc3Rlcl9leGNs dXNpb25fcmFuZ2VfZm9yX2RldmljZSgKLSAgICAgICAgICAgIGJkZiwgYmFz ZSwgbGltaXQsIGl3LCBpcik7CisgICAgICAgIGVycm9yID0gcmVnaXN0ZXJf cmFuZ2VfZm9yX2RldmljZSgKKyAgICAgICAgICAgIGJkZiwgYmFzZSwgbGlt aXQsIGl3LCBpciwgZXhjbHVzaW9uKTsKIAogICAgIHJldHVybiBlcnJvcjsK IH0KIAogc3RhdGljIGludCBfX2luaXQgcGFyc2VfaXZtZF9kZXZpY2VfaW9t bXUoCiAgICAgY29uc3Qgc3RydWN0IGFjcGlfaXZyc19tZW1vcnkgKml2bWRf YmxvY2ssCi0gICAgdW5zaWduZWQgbG9uZyBiYXNlLCB1bnNpZ25lZCBsb25n IGxpbWl0LCB1OCBpdywgdTggaXIpCisgICAgcGFkZHJfdCBiYXNlLCBwYWRk cl90IGxpbWl0LCBib29sIGl3LCBib29sIGlyLCBib29sIGV4Y2x1c2lvbikK IHsKICAgICBpbnQgc2VnID0gMDsgLyogWFhYICovCiAgICAgc3RydWN0IGFt ZF9pb21tdSAqaW9tbXU7CkBAIC0zNjUsMTQgKzM0MywxNCBAQCBzdGF0aWMg aW50IF9faW5pdCBwYXJzZV9pdm1kX2RldmljZV9pb21tCiAgICAgICAgIHJl dHVybiAtRU5PREVWOwogICAgIH0KIAotICAgIHJldHVybiByZWdpc3Rlcl9l eGNsdXNpb25fcmFuZ2VfZm9yX2lvbW11X2RldmljZXMoCi0gICAgICAgIGlv bW11LCBiYXNlLCBsaW1pdCwgaXcsIGlyKTsKKyAgICByZXR1cm4gcmVnaXN0 ZXJfcmFuZ2VfZm9yX2lvbW11X2RldmljZXMoCisgICAgICAgIGlvbW11LCBi YXNlLCBsaW1pdCwgaXcsIGlyLCBleGNsdXNpb24pOwogfQogCiBzdGF0aWMg aW50IF9faW5pdCBwYXJzZV9pdm1kX2Jsb2NrKGNvbnN0IHN0cnVjdCBhY3Bp X2l2cnNfbWVtb3J5ICppdm1kX2Jsb2NrKQogewogICAgIHVuc2lnbmVkIGxv bmcgc3RhcnRfYWRkciwgbWVtX2xlbmd0aCwgYmFzZSwgbGltaXQ7Ci0gICAg dTggaXcsIGlyOworICAgIGJvb2wgaXcgPSB0cnVlLCBpciA9IHRydWUsIGV4 Y2x1c2lvbiA9IGZhbHNlOwogCiAgICAgaWYgKCBpdm1kX2Jsb2NrLT5oZWFk ZXIubGVuZ3RoIDwgc2l6ZW9mKCppdm1kX2Jsb2NrKSApCiAgICAgewpAQCAt Mzg5LDEzICszNjcsMTEgQEAgc3RhdGljIGludCBfX2luaXQgcGFyc2VfaXZt ZF9ibG9jayhjb25zdAogICAgICAgICAgICAgICAgICAgICBpdm1kX2Jsb2Nr LT5oZWFkZXIudHlwZSwgc3RhcnRfYWRkciwgbWVtX2xlbmd0aCk7CiAKICAg ICBpZiAoIGl2bWRfYmxvY2stPmhlYWRlci5mbGFncyAmIEFDUElfSVZNRF9F WENMVVNJT05fUkFOR0UgKQotICAgICAgICBpdyA9IGlyID0gSU9NTVVfQ09O VFJPTF9FTkFCTEVEOworICAgICAgICBleGNsdXNpb24gPSB0cnVlOwogICAg IGVsc2UgaWYgKCBpdm1kX2Jsb2NrLT5oZWFkZXIuZmxhZ3MgJiBBQ1BJX0lW TURfVU5JVFkgKQogICAgIHsKLSAgICAgICAgaXcgPSBpdm1kX2Jsb2NrLT5o ZWFkZXIuZmxhZ3MgJiBBQ1BJX0lWTURfUkVBRCA/Ci0gICAgICAgICAgICBJ T01NVV9DT05UUk9MX0VOQUJMRUQgOiBJT01NVV9DT05UUk9MX0RJU0FCTEVE OwotICAgICAgICBpciA9IGl2bWRfYmxvY2stPmhlYWRlci5mbGFncyAmIEFD UElfSVZNRF9XUklURSA/Ci0gICAgICAgICAgICBJT01NVV9DT05UUk9MX0VO QUJMRUQgOiBJT01NVV9DT05UUk9MX0RJU0FCTEVEOworICAgICAgICBpdyA9 IGl2bWRfYmxvY2stPmhlYWRlci5mbGFncyAmIEFDUElfSVZNRF9SRUFEOwor ICAgICAgICBpciA9IGl2bWRfYmxvY2stPmhlYWRlci5mbGFncyAmIEFDUElf SVZNRF9XUklURTsKICAgICB9CiAgICAgZWxzZQogICAgIHsKQEAgLTQwNiwy MCArMzgyLDIwIEBAIHN0YXRpYyBpbnQgX19pbml0IHBhcnNlX2l2bWRfYmxv Y2soY29uc3QKICAgICBzd2l0Y2goIGl2bWRfYmxvY2stPmhlYWRlci50eXBl ICkKICAgICB7CiAgICAgY2FzZSBBQ1BJX0lWUlNfVFlQRV9NRU1PUllfQUxM OgotICAgICAgICByZXR1cm4gcmVnaXN0ZXJfZXhjbHVzaW9uX3JhbmdlX2Zv cl9hbGxfZGV2aWNlcygKLSAgICAgICAgICAgIGJhc2UsIGxpbWl0LCBpdywg aXIpOworICAgICAgICByZXR1cm4gcmVnaXN0ZXJfcmFuZ2VfZm9yX2FsbF9k ZXZpY2VzKAorICAgICAgICAgICAgYmFzZSwgbGltaXQsIGl3LCBpciwgZXhj bHVzaW9uKTsKIAogICAgIGNhc2UgQUNQSV9JVlJTX1RZUEVfTUVNT1JZX09O RToKLSAgICAgICAgcmV0dXJuIHBhcnNlX2l2bWRfZGV2aWNlX3NlbGVjdChp dm1kX2Jsb2NrLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIGJhc2UsIGxpbWl0LCBpdywgaXIpOworICAgICAgICByZXR1cm4g cGFyc2VfaXZtZF9kZXZpY2Vfc2VsZWN0KGl2bWRfYmxvY2ssIGJhc2UsIGxp bWl0LAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IGl3LCBpciwgZXhjbHVzaW9uKTsKIAogICAgIGNhc2UgQUNQSV9JVlJTX1RZ UEVfTUVNT1JZX1JBTkdFOgotICAgICAgICByZXR1cm4gcGFyc2VfaXZtZF9k ZXZpY2VfcmFuZ2UoaXZtZF9ibG9jaywKLSAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIGJhc2UsIGxpbWl0LCBpdywgaXIpOworICAg ICAgICByZXR1cm4gcGFyc2VfaXZtZF9kZXZpY2VfcmFuZ2UoaXZtZF9ibG9j aywgYmFzZSwgbGltaXQsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICBpdywgaXIsIGV4Y2x1c2lvbik7CiAKICAgICBjYXNlIEFD UElfSVZSU19UWVBFX01FTU9SWV9JT01NVToKLSAgICAgICAgcmV0dXJuIHBh cnNlX2l2bWRfZGV2aWNlX2lvbW11KGl2bWRfYmxvY2ssCi0gICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBiYXNlLCBsaW1pdCwgaXcs IGlyKTsKKyAgICAgICAgcmV0dXJuIHBhcnNlX2l2bWRfZGV2aWNlX2lvbW11 KGl2bWRfYmxvY2ssIGJhc2UsIGxpbWl0LAorICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgaXcsIGlyLCBleGNsdXNpb24pOwogCiAg ICAgZGVmYXVsdDoKICAgICAgICAgQU1EX0lPTU1VX0RFQlVHKCJJVk1EIEVy cm9yOiBJbnZhbGlkIEJsb2NrIFR5cGUhXG4iKTsKLS0tIGEveGVuL2RyaXZl cnMvcGFzc3Rocm91Z2gvYW1kL3BjaV9hbWRfaW9tbXUuYworKysgYi94ZW4v ZHJpdmVycy9wYXNzdGhyb3VnaC9hbWQvcGNpX2FtZF9pb21tdS5jCkBAIC0y MjIsNiArMjIyLDggQEAgc3RhdGljIGludCBfX211c3RfY2hlY2sgYWxsb2Nh dGVfZG9tYWluXwogICAgIHJldHVybiByYzsKIH0KIAoraW50IF9fcmVhZF9t b3N0bHkgYW1kX2lvbW11X21pbl9wYWdpbmdfbW9kZSA9IDE7CisKIHN0YXRp YyBpbnQgYW1kX2lvbW11X2RvbWFpbl9pbml0KHN0cnVjdCBkb21haW4gKmQp CiB7CiAgICAgc3RydWN0IGRvbWFpbl9pb21tdSAqaGQgPSBkb21faW9tbXUo ZCk7CkBAIC0yMzMsMTEgKzIzNSwxMyBAQCBzdGF0aWMgaW50IGFtZF9pb21t dV9kb21haW5faW5pdChzdHJ1Y3QKICAgICAgKiAtIEhWTSBjb3VsZCBpbiBw cmluY2lwbGUgdXNlIDMgb3IgNCBkZXBlbmRpbmcgb24gaG93IG11Y2ggZ3Vl c3QKICAgICAgKiAgIHBoeXNpY2FsIGFkZHJlc3Mgc3BhY2Ugd2UgZ2l2ZSBp dCwgYnV0IHRoaXMgaXNuJ3Qga25vd24geWV0IHNvIHVzZSA0CiAgICAgICog ICB1bmlsYXRlcmFsbHkuCisgICAgICogLSBVbml0eSBtYXBzIG1heSByZXF1 aXJlIGFuIGV2ZW4gaGlnaGVyIG51bWJlci4KICAgICAgKi8KLSAgICBoZC0+ YXJjaC5wYWdpbmdfbW9kZSA9IGFtZF9pb21tdV9nZXRfcGFnaW5nX21vZGUo Ci0gICAgICAgIGlzX2h2bV9kb21haW4oZCkKLSAgICAgICAgPyAxdWwgPDwg KERFRkFVTFRfRE9NQUlOX0FERFJFU1NfV0lEVEggLSBQQUdFX1NISUZUKQot ICAgICAgICA6IGdldF91cHBlcl9tZm5fYm91bmQoKSArIDEpOworICAgIGhk LT5hcmNoLnBhZ2luZ19tb2RlID0gbWF4KGFtZF9pb21tdV9nZXRfcGFnaW5n X21vZGUoCisgICAgICAgICAgICBpc19odm1fZG9tYWluKGQpCisgICAgICAg ICAgICA/IDF1bCA8PCAoREVGQVVMVF9ET01BSU5fQUREUkVTU19XSURUSCAt IFBBR0VfU0hJRlQpCisgICAgICAgICAgICA6IGdldF91cHBlcl9tZm5fYm91 bmQoKSArIDEpLAorICAgICAgICBhbWRfaW9tbXVfbWluX3BhZ2luZ19tb2Rl KTsKIAogICAgIHJldHVybiAwOwogfQotLS0gYS94ZW4vaW5jbHVkZS9hc20t eDg2L2h2bS9zdm0vYW1kLWlvbW11LXByb3RvLmgKKysrIGIveGVuL2luY2x1 ZGUvYXNtLXg4Ni9odm0vc3ZtL2FtZC1pb21tdS1wcm90by5oCkBAIC0xMzIs NiArMTMyLDggQEAgZXh0ZXJuIHN0cnVjdCBocGV0X3NiZGYgewogICAgIH0g aW5pdDsKIH0gaHBldF9zYmRmOwogCitleHRlcm4gaW50IGFtZF9pb21tdV9t aW5fcGFnaW5nX21vZGU7CisKIGV4dGVybiB2b2lkICpzaGFyZWRfaW50cmVt YXBfdGFibGU7CiBleHRlcm4gdW5zaWduZWQgbG9uZyAqc2hhcmVkX2ludHJl bWFwX2ludXNlOwogCg== --=separator Content-Type: application/octet-stream; name="xsa378/xsa378-4.12-7.patch" Content-Disposition: attachment; filename="xsa378/xsa378-4.12-7.patch" Content-Transfer-Encoding: base64 RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0 OiB4ODYvcDJtOiBpbnRyb2R1Y2UgcDJtX2lzX3NwZWNpYWwoKQoKU2VlaW5n IHRoZSBzaW1pbGFyaXR5IG9mIGdyYW50LCBmb3JlaWduLCBhbmQgKHN1YnNl cXVlbnRseSkgZGlyZWN0LU1NSU8KaGFuZGxpbmcsIGludHJvZHVjZSBhIG5l dyBQMk0gdHlwZSBncm91cCBuYW1lZCAic3BlY2lhbCIgKGFzIGluICJuZWVk aW5nCnNwZWNpYWwgYWNjZXNzb3JzIHRvIGNyZWF0ZS9kZXN0cm95IikuCgpB bHNvIHVzZSAtRVBFUk0gaW5zdGVhZCBvZiBvdGhlciBlcnJvciBjb2RlcyBv biB0aGUgdHdvIGRvbWFpbl9jcmFzaCgpCnBhdGhzIHRvdWNoZWQuCgpUaGlz IGlzIHBhcnQgb2YgWFNBLTM3OC4KClNpZ25lZC1vZmYtYnk6IEphbiBCZXVs aWNoIDxqYmV1bGljaEBzdXNlLmNvbT4KUmV2aWV3ZWQtYnk6IFBhdWwgRHVy cmFudCA8cGF1bEB4ZW4ub3JnPgoKLS0tIGEveGVuL2FyY2gveDg2L21tL3Ay bS5jCisrKyBiL3hlbi9hcmNoL3g4Ni9tbS9wMm0uYwpAQCAtODA2LDcgKzgw Niw3IEBAIHAybV9yZW1vdmVfcGFnZShzdHJ1Y3QgcDJtX2RvbWFpbiAqcDJt LAogICAgICAgICBmb3IgKCBpID0gMDsgaSA8ICgxVUwgPDwgcGFnZV9vcmRl cik7IGkrKyApCiAgICAgICAgIHsKICAgICAgICAgICAgIHAybS0+Z2V0X2Vu dHJ5KHAybSwgZ2ZuX2FkZChnZm4sIGkpLCAmdCwgJmEsIDAsIE5VTEwsIE5V TEwpOwotICAgICAgICAgICAgaWYgKCAhcDJtX2lzX2dyYW50KHQpICYmICFw Mm1faXNfc2hhcmVkKHQpICYmICFwMm1faXNfZm9yZWlnbih0KSApCisgICAg ICAgICAgICBpZiAoICFwMm1faXNfc3BlY2lhbCh0KSAmJiAhcDJtX2lzX3No YXJlZCh0KSApCiAgICAgICAgICAgICAgICAgc2V0X2dwZm5fZnJvbV9tZm4o bWZuK2ksIElOVkFMSURfTTJQX0VOVFJZKTsKICAgICAgICAgfQogICAgIH0K QEAgLTkxNywxMyArOTE3LDEzIEBAIGd1ZXN0X3BoeXNtYXBfYWRkX2VudHJ5 KHN0cnVjdCBkb21haW4gKmQKICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAmb3QsICZhLCAwLCBOVUxMLCBOVUxMKTsKICAgICAgICAgICAg IEFTU0VSVCghcDJtX2lzX3NoYXJlZChvdCkpOwogICAgICAgICB9Ci0gICAg ICAgIGlmICggcDJtX2lzX2dyYW50KG90KSB8fCBwMm1faXNfZm9yZWlnbihv dCkgKQorICAgICAgICBpZiAoIHAybV9pc19zcGVjaWFsKG90KSApCiAgICAg ICAgIHsKLSAgICAgICAgICAgIC8qIFJlYWxseSBzaG91bGRuJ3QgYmUgdW5t YXBwaW5nIGdyYW50L2ZvcmVpZ24gbWFwcyB0aGlzIHdheSAqLworICAgICAg ICAgICAgLyogRG9uJ3QgcGVybWl0IHVubWFwcGluZyBncmFudC9mb3JlaWdu IHRoaXMgd2F5LiAqLwogICAgICAgICAgICAgZG9tYWluX2NyYXNoKGQpOwog ICAgICAgICAgICAgcDJtX3VubG9jayhwMm0pOwogICAgICAgICAgICAgCi0g ICAgICAgICAgICByZXR1cm4gLUVJTlZBTDsKKyAgICAgICAgICAgIHJldHVy biAtRVBFUk07CiAgICAgICAgIH0KICAgICAgICAgZWxzZSBpZiAoIHAybV9p c19yYW0ob3QpICYmICFwMm1faXNfcGFnZWQob3QpICkKICAgICAgICAgewpA QCAtMTAxOCw4ICsxMDE4LDcgQEAgaW50IHAybV9jaGFuZ2VfdHlwZV9vbmUo c3RydWN0IGRvbWFpbiAqZAogICAgIHN0cnVjdCBwMm1fZG9tYWluICpwMm0g PSBwMm1fZ2V0X2hvc3RwMm0oZCk7CiAgICAgaW50IHJjOwogCi0gICAgQlVH X09OKHAybV9pc19ncmFudChvdCkgfHwgcDJtX2lzX2dyYW50KG50KSk7Ci0g ICAgQlVHX09OKHAybV9pc19mb3JlaWduKG90KSB8fCBwMm1faXNfZm9yZWln bihudCkpOworICAgIEJVR19PTihwMm1faXNfc3BlY2lhbChvdCkgfHwgcDJt X2lzX3NwZWNpYWwobnQpKTsKIAogICAgIGdmbl9sb2NrKHAybSwgZ2ZuLCAw KTsKIApAQCAtMTI3MiwxMSArMTI3MSwxMSBAQCBzdGF0aWMgaW50IHNldF90 eXBlZF9wMm1fZW50cnkoc3RydWN0IGRvCiAgICAgICAgIGdmbl91bmxvY2so cDJtLCBnZm4sIG9yZGVyKTsKICAgICAgICAgcmV0dXJuIGN1cl9vcmRlciAr IDE7CiAgICAgfQotICAgIGlmICggcDJtX2lzX2dyYW50KG90KSB8fCBwMm1f aXNfZm9yZWlnbihvdCkgKQorICAgIGlmICggcDJtX2lzX3NwZWNpYWwob3Qp ICkKICAgICB7CiAgICAgICAgIGdmbl91bmxvY2socDJtLCBnZm4sIG9yZGVy KTsKICAgICAgICAgZG9tYWluX2NyYXNoKGQpOwotICAgICAgICByZXR1cm4g LUVOT0VOVDsKKyAgICAgICAgcmV0dXJuIC1FUEVSTTsKICAgICB9CiAgICAg ZWxzZSBpZiAoIHAybV9pc19yYW0ob3QpICkKICAgICB7Ci0tLSBhL3hlbi9p bmNsdWRlL2FzbS14ODYvcDJtLmgKKysrIGIveGVuL2luY2x1ZGUvYXNtLXg4 Ni9wMm0uaApAQCAtMTQxLDYgKzE0MSwxMCBAQCB0eXBlZGVmIHVuc2lnbmVk IGludCBwMm1fcXVlcnlfdDsKICAgICAgICAgICAgICAgICAgICAgICAgICAg ICB8IHAybV90b19tYXNrKHAybV9yYW1fbG9nZGlydHkpICkKICNkZWZpbmUg UDJNX1NIQVJFRF9UWVBFUyAgIChwMm1fdG9fbWFzayhwMm1fcmFtX3NoYXJl ZCkpCiAKKy8qIFR5cGVzIGVzdGFibGlzaGVkL2NsZWFuZWQgdXAgdmlhIHNw ZWNpYWwgYWNjZXNzb3JzLiAqLworI2RlZmluZSBQMk1fU1BFQ0lBTF9UWVBF UyAoUDJNX0dSQU5UX1RZUEVTIHwgXAorICAgICAgICAgICAgICAgICAgICAg ICAgICAgcDJtX3RvX21hc2socDJtX21hcF9mb3JlaWduKSkKKwogLyogVmFs aWQgdHlwZXMgbm90IG5lY2Vzc2FyaWx5IGFzc29jaWF0ZWQgd2l0aCBhICh2 YWxpZCkgTUZOLiAqLwogI2RlZmluZSBQMk1fSU5WQUxJRF9NRk5fVFlQRVMg KFAyTV9QT0RfVFlQRVMgICAgICAgICAgICAgICAgICBcCiAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgfCBwMm1fdG9fbWFzayhwMm1fbW1pb19k aXJlY3QpIFwKQEAgLTE2OSw2ICsxNzMsNyBAQCB0eXBlZGVmIHVuc2lnbmVk IGludCBwMm1fcXVlcnlfdDsKICNkZWZpbmUgcDJtX2lzX3BhZ2VkKF90KSAg ICAocDJtX3RvX21hc2soX3QpICYgUDJNX1BBR0VEX1RZUEVTKQogI2RlZmlu ZSBwMm1faXNfc2hhcmFibGUoX3QpIChwMm1fdG9fbWFzayhfdCkgJiBQMk1f U0hBUkFCTEVfVFlQRVMpCiAjZGVmaW5lIHAybV9pc19zaGFyZWQoX3QpICAg KHAybV90b19tYXNrKF90KSAmIFAyTV9TSEFSRURfVFlQRVMpCisjZGVmaW5l IHAybV9pc19zcGVjaWFsKF90KSAgKHAybV90b19tYXNrKF90KSAmIFAyTV9T UEVDSUFMX1RZUEVTKQogI2RlZmluZSBwMm1faXNfYnJva2VuKF90KSAgIChw Mm1fdG9fbWFzayhfdCkgJiBQMk1fQlJPS0VOX1RZUEVTKQogI2RlZmluZSBw Mm1faXNfZm9yZWlnbihfdCkgIChwMm1fdG9fbWFzayhfdCkgJiBwMm1fdG9f bWFzayhwMm1fbWFwX2ZvcmVpZ24pKQogCg== --=separator Content-Type: application/octet-stream; name="xsa378/xsa378-4.12-8.patch" Content-Disposition: attachment; filename="xsa378/xsa378-4.12-8.patch" Content-Transfer-Encoding: base64 RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0 OiB4ODYvcDJtOiBndWFyZCAoaW4gcGFydGljdWxhcikgaWRlbnRpdHkgbWFw cGluZyBlbnRyaWVzCgpTdWNoIGVudHJpZXMsIGNyZWF0ZWQgYnkgc2V0X2lk ZW50aXR5X3AybV9lbnRyeSgpLCBzaG91bGQgb25seSBiZQpkZXN0cm95ZWQg YnkgY2xlYXJfaWRlbnRpdHlfcDJtX2VudHJ5KCkuIEhvd2V2ZXIsIHNpbWls YXJseSwgZW50cmllcwpjcmVhdGVkIGJ5IHNldF9tbWlvX3AybV9lbnRyeSgp IHNob3VsZCBvbmx5IGJlIHRvcm4gZG93biBieQpjbGVhcl9tbWlvX3AybV9l bnRyeSgpLCBzbyB0aGUgbG9naWMgZ2V0cyBiYXNlZCB1cG9uIHAybV9tbWlv X2RpcmVjdCBhcwp0aGUgZW50cnkgdHlwZSAoc2VwYXJhdGlvbiBiZXR3ZWVu ICJvcmRpbmFyeSIgYW5kIDE6MSBtYXBwaW5ncyB3b3VsZApyZXF1aXJlIGEg ZnVydGhlciBpbmRpY2F0b3IgdG8gdGVsbCBhcGFydCB0aGUgdHdvKS4KCkFz IHRvIHRoZSBndWVzdF9yZW1vdmVfcGFnZSgpIGNoYW5nZSwgY29tbWl0IDQ4 ZGZiMjk3YTIwYSAoIng4Ni9QVkg6CmFsbG93IGd1ZXN0X3JlbW92ZV9wYWdl IHRvIHJlbW92ZSBwMm1fbW1pb19kaXJlY3QgcGFnZXMiKSwgd2hpY2gKaW50 cm9kdWNlZCB0aGUgY2FsbCB0byBjbGVhcl9tbWlvX3AybV9lbnRyeSgpLCBj bGFpbWVkIHRoaXMgd2FzIGRvbmUgZm9yCmh3ZG9tIG9ubHkgd2l0aG91dCB0 aGlzIGFjdHVhbGx5IGhhdmluZyBiZWVuIHRoZSBjYXNlLiBIb3dldmVyLCB0 aGlzCmNvZGUgc2hvdWxkbid0IGJlIHRoZXJlIGluIHRoZSBmaXJzdCBwbGFj ZSwgYXMgTU1JTyBlbnRyaWVzIHNob3VsZG4ndCBiZQpkcm9wcGVkIHRoaXMg d2F5LiBBdm9pZCB0cmlnZ2VyaW5nIHRoZSB3YXJuaW5nIGFnYWluIHRoYXQg NDhkZmIyOTdhMjBhCnNpbGVuY2VkIGJ5IGFuIGFkanVzdG1lbnQgdG8geGVu bWVtX2FkZF90b19waHlzbWFwX29uZSgpIGluc3RlYWQuCgpOb3RlIHRoYXQg Z3Vlc3RfcGh5c21hcF9tYXJrX3BvcHVsYXRlX29uX2RlbWFuZCgpIGdldHMg dGlnaHRlbmVkIGJleW9uZAp0aGUgaW1tZWRpYXRlIHB1cnBvc2Ugb2YgdGhp cyBjaGFuZ2UuCgpOb3RlIGFsc28gdGhhdCBJIGRpZG4ndCBpbnNwZWN0IGNv ZGUgd2hpY2ggaXNuJ3Qgc2VjdXJpdHkgc3VwcG9ydGVkLAplLmcuIHNoYXJp bmcsIHBhZ2luZywgb3IgYWx0cDJtLgoKVGhpcyBpcyBDVkUtMjAyMS0yODY5 NCAvIHBhcnQgb2YgWFNBLTM3OC4KClNpZ25lZC1vZmYtYnk6IEphbiBCZXVs aWNoIDxqYmV1bGljaEBzdXNlLmNvbT4KUmV2aWV3ZWQtYnk6IFBhdWwgRHVy cmFudCA8cGF1bEB4ZW4ub3JnPgoKLS0tIGEveGVuL2FyY2gveDg2L21tLmMK KysrIGIveGVuL2FyY2gveDg2L21tLmMKQEAgLTQ4MDksNyArNDgwOSw5IEBA IGludCB4ZW5tZW1fYWRkX3RvX3BoeXNtYXBfb25lKAogCiAgICAgLyogUmVt b3ZlIHByZXZpb3VzbHkgbWFwcGVkIHBhZ2UgaWYgaXQgd2FzIHByZXNlbnQu ICovCiAgICAgcHJldl9tZm4gPSBtZm5feChnZXRfZ2ZuKGQsIGdmbl94KGdw Zm4pLCAmcDJtdCkpOwotICAgIGlmICggbWZuX3ZhbGlkKF9tZm4ocHJldl9t Zm4pKSApCisgICAgaWYgKCBwMm10ID09IHAybV9tbWlvX2RpcmVjdCApCisg ICAgICAgIHJjID0gLUVQRVJNOworICAgIGVsc2UgaWYgKCBtZm5fdmFsaWQo X21mbihwcmV2X21mbikpICkKICAgICB7CiAgICAgICAgIGlmICggaXNfeGVu X2hlYXBfbWZuKHByZXZfbWZuKSApCiAgICAgICAgICAgICAvKiBYZW4gaGVh cCBmcmFtZXMgYXJlIHNpbXBseSB1bmhvb2tlZCBmcm9tIHRoaXMgcGh5cyBz bG90LiAqLwotLS0gYS94ZW4vYXJjaC94ODYvbW0vcDJtLmMKKysrIGIveGVu L2FyY2gveDg2L21tL3AybS5jCkBAIC03OTUsNyArNzk1LDggQEAgcDJtX3Jl bW92ZV9wYWdlKHN0cnVjdCBwMm1fZG9tYWluICpwMm0sCiAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAmY3VyX29yZGVyLCBO VUxMKTsKIAogICAgICAgICBpZiAoIHAybV9pc192YWxpZCh0KSAmJgotICAg ICAgICAgICAgICghbWZuX3ZhbGlkKF9tZm4obWZuKSkgfHwgbWZuICsgaSAh PSBtZm5feChtZm5fcmV0dXJuKSkgKQorICAgICAgICAgICAgICghbWZuX3Zh bGlkKF9tZm4obWZuKSkgfHwgdCA9PSBwMm1fbW1pb19kaXJlY3QgfHwKKyAg ICAgICAgICAgICAgbWZuICsgaSAhPSBtZm5feChtZm5fcmV0dXJuKSkgKQog ICAgICAgICAgICAgcmV0dXJuIC1FSUxTRVE7CiAKICAgICAgICAgaSArPSAo MVVMIDw8IGN1cl9vcmRlcikgLSAoKGdmbl9sICsgaSkgJiAoKDFVTCA8PCBj dXJfb3JkZXIpIC0gMSkpOwpAQCAtODczLDcgKzg3NCw3IEBAIGd1ZXN0X3Bo eXNtYXBfYWRkX2VudHJ5KHN0cnVjdCBkb21haW4gKmQKICAgICBpZiAoIHAy bV9pc19mb3JlaWduKHQpICkKICAgICAgICAgcmV0dXJuIC1FSU5WQUw7CiAK LSAgICBpZiAoICFtZm5fdmFsaWQobWZuKSApCisgICAgaWYgKCAhbWZuX3Zh bGlkKG1mbikgfHwgdCA9PSBwMm1fbW1pb19kaXJlY3QgKQogICAgIHsKICAg ICAgICAgQVNTRVJUX1VOUkVBQ0hBQkxFKCk7CiAgICAgICAgIHJldHVybiAt RUlOVkFMOwpAQCAtOTE5LDcgKzkyMCw3IEBAIGd1ZXN0X3BoeXNtYXBfYWRk X2VudHJ5KHN0cnVjdCBkb21haW4gKmQKICAgICAgICAgfQogICAgICAgICBp ZiAoIHAybV9pc19zcGVjaWFsKG90KSApCiAgICAgICAgIHsKLSAgICAgICAg ICAgIC8qIERvbid0IHBlcm1pdCB1bm1hcHBpbmcgZ3JhbnQvZm9yZWlnbiB0 aGlzIHdheS4gKi8KKyAgICAgICAgICAgIC8qIERvbid0IHBlcm1pdCB1bm1h cHBpbmcgZ3JhbnQvZm9yZWlnbi9kaXJlY3QtTU1JTyB0aGlzIHdheS4gKi8K ICAgICAgICAgICAgIGRvbWFpbl9jcmFzaChkKTsKICAgICAgICAgICAgIHAy bV91bmxvY2socDJtKTsKICAgICAgICAgICAgIApAQCAtMTM3NSw4ICsxMzc2 LDggQEAgaW50IHNldF9pZGVudGl0eV9wMm1fZW50cnkoc3RydWN0IGRvbWFp bgogICogICAgb3JkZXIrMSAgZm9yIGNhbGxlciB0byByZXRyeSB3aXRoIG9y ZGVyIChndWFyYW50ZWVkIHNtYWxsZXIgdGhhbgogICogICAgICAgICAgICAg dGhlIG9yZGVyIHZhbHVlIHBhc3NlZCBpbikKICAqLwotaW50IGNsZWFyX21t aW9fcDJtX2VudHJ5KHN0cnVjdCBkb21haW4gKmQsIHVuc2lnbmVkIGxvbmcg Z2ZuX2wsIG1mbl90IG1mbiwKLSAgICAgICAgICAgICAgICAgICAgICAgICB1 bnNpZ25lZCBpbnQgb3JkZXIpCitzdGF0aWMgaW50IGNsZWFyX21taW9fcDJt X2VudHJ5KHN0cnVjdCBkb21haW4gKmQsIHVuc2lnbmVkIGxvbmcgZ2ZuX2ws CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIG1mbl90IG1mbiwg dW5zaWduZWQgaW50IG9yZGVyKQogewogICAgIGludCByYyA9IC1FSU5WQUw7 CiAgICAgZ2ZuX3QgZ2ZuID0gX2dmbihnZm5fbCk7Ci0tLSBhL3hlbi9hcmNo L3g4Ni9tbS9wMm0tcG9kLmMKKysrIGIveGVuL2FyY2gveDg2L21tL3AybS1w b2QuYwpAQCAtMTI5NywxNyArMTI5NywxNyBAQCBndWVzdF9waHlzbWFwX21h cmtfcG9wdWxhdGVfb25fZGVtYW5kKHN0CiAKICAgICAgICAgcDJtLT5nZXRf ZW50cnkocDJtLCBnZm5fYWRkKGdmbiwgaSksICZvdCwgJmEsIDAsICZjdXJf b3JkZXIsIE5VTEwpOwogICAgICAgICBuID0gMVVMIDw8IG1pbihvcmRlciwg Y3VyX29yZGVyKTsKLSAgICAgICAgaWYgKCBwMm1faXNfcmFtKG90KSApCisg ICAgICAgIGlmICggb3QgPT0gcDJtX3BvcHVsYXRlX29uX2RlbWFuZCApCisg ICAgICAgIHsKKyAgICAgICAgICAgIC8qIENvdW50IGhvdyBtYW55IFBvRCBl bnRyaWVzIHdlJ2xsIGJlIHJlcGxhY2luZyBpZiBzdWNjZXNzZnVsICovCisg ICAgICAgICAgICBwb2RfY291bnQgKz0gbjsKKyAgICAgICAgfQorICAgICAg ICBlbHNlIGlmICggb3QgIT0gcDJtX2ludmFsaWQgJiYgb3QgIT0gcDJtX21t aW9fZG0gKQogICAgICAgICB7CiAgICAgICAgICAgICBQMk1fREVCVUcoImdm bl90b19tZm4gcmV0dXJuZWQgdHlwZSAlZCFcbiIsIG90KTsKICAgICAgICAg ICAgIHJjID0gLUVCVVNZOwogICAgICAgICAgICAgZ290byBvdXQ7CiAgICAg ICAgIH0KLSAgICAgICAgZWxzZSBpZiAoIG90ID09IHAybV9wb3B1bGF0ZV9v bl9kZW1hbmQgKQotICAgICAgICB7Ci0gICAgICAgICAgICAvKiBDb3VudCBo b3cgbWFuIFBvRCBlbnRyaWVzIHdlJ2xsIGJlIHJlcGxhY2luZyBpZiBzdWNj ZXNzZnVsICovCi0gICAgICAgICAgICBwb2RfY291bnQgKz0gbjsKLSAgICAg ICAgfQogICAgIH0KIAogICAgIC8qIE5vdywgYWN0dWFsbHkgZG8gdGhlIHR3 by13YXkgbWFwcGluZyAqLwotLS0gYS94ZW4vY29tbW9uL21lbW9yeS5jCisr KyBiL3hlbi9jb21tb24vbWVtb3J5LmMKQEAgLTMzNiw3ICszMzYsNyBAQCBp bnQgZ3Vlc3RfcmVtb3ZlX3BhZ2Uoc3RydWN0IGRvbWFpbiAqZCwKICAgICB9 CiAgICAgaWYgKCBwMm10ID09IHAybV9tbWlvX2RpcmVjdCApCiAgICAgewot ICAgICAgICByYyA9IGNsZWFyX21taW9fcDJtX2VudHJ5KGQsIGdtZm4sIG1m biwgUEFHRV9PUkRFUl80Syk7CisgICAgICAgIHJjID0gLUVQRVJNOwogICAg ICAgICBnb3RvIG91dF9wdXRfZ2ZuOwogICAgIH0KICNlbHNlCkBAIC0xNzI0 LDYgKzE3MjQsMTUgQEAgaW50IGNoZWNrX2dldF9wYWdlX2Zyb21fZ2ZuKHN0 cnVjdCBkb21haQogICAgICAgICByZXR1cm4gLUVBR0FJTjsKICAgICB9CiAj ZW5kaWYKKyNpZmRlZiBDT05GSUdfWDg2CisgICAgaWYgKCBwMm10ID09IHAy bV9tbWlvX2RpcmVjdCApCisgICAgeworICAgICAgICBpZiAoIHBhZ2UgKQor ICAgICAgICAgICAgcHV0X3BhZ2UocGFnZSk7CisKKyAgICAgICAgcmV0dXJu IC1FUEVSTTsKKyAgICB9CisjZW5kaWYKIAogICAgIGlmICggIXBhZ2UgKQog ICAgICAgICByZXR1cm4gLUVJTlZBTDsKLS0tIGEveGVuL2luY2x1ZGUvYXNt LXg4Ni9wMm0uaAorKysgYi94ZW4vaW5jbHVkZS9hc20teDg2L3AybS5oCkBA IC0xNDMsNyArMTQzLDggQEAgdHlwZWRlZiB1bnNpZ25lZCBpbnQgcDJtX3F1 ZXJ5X3Q7CiAKIC8qIFR5cGVzIGVzdGFibGlzaGVkL2NsZWFuZWQgdXAgdmlh IHNwZWNpYWwgYWNjZXNzb3JzLiAqLwogI2RlZmluZSBQMk1fU1BFQ0lBTF9U WVBFUyAoUDJNX0dSQU5UX1RZUEVTIHwgXAotICAgICAgICAgICAgICAgICAg ICAgICAgICAgcDJtX3RvX21hc2socDJtX21hcF9mb3JlaWduKSkKKyAgICAg ICAgICAgICAgICAgICAgICAgICAgIHAybV90b19tYXNrKHAybV9tYXBfZm9y ZWlnbikgfCBcCisgICAgICAgICAgICAgICAgICAgICAgICAgICBwMm1fdG9f bWFzayhwMm1fbW1pb19kaXJlY3QpKQogCiAvKiBWYWxpZCB0eXBlcyBub3Qg bmVjZXNzYXJpbHkgYXNzb2NpYXRlZCB3aXRoIGEgKHZhbGlkKSBNRk4uICov CiAjZGVmaW5lIFAyTV9JTlZBTElEX01GTl9UWVBFUyAoUDJNX1BPRF9UWVBF UyAgICAgICAgICAgICAgICAgIFwKQEAgLTY0MCw4ICs2NDEsNiBAQCBpbnQg c2V0X2ZvcmVpZ25fcDJtX2VudHJ5KHN0cnVjdCBkb21haW4KIC8qIFNldCBt bWlvIGFkZHJlc3NlcyBpbiB0aGUgcDJtIHRhYmxlIChmb3IgcGFzcy10aHJv dWdoKSAqLwogaW50IHNldF9tbWlvX3AybV9lbnRyeShzdHJ1Y3QgZG9tYWlu ICpkLCB1bnNpZ25lZCBsb25nIGdmbiwgbWZuX3QgbWZuLAogICAgICAgICAg ICAgICAgICAgICAgICB1bnNpZ25lZCBpbnQgb3JkZXIsIHAybV9hY2Nlc3Nf dCBhY2Nlc3MpOwotaW50IGNsZWFyX21taW9fcDJtX2VudHJ5KHN0cnVjdCBk b21haW4gKmQsIHVuc2lnbmVkIGxvbmcgZ2ZuLCBtZm5fdCBtZm4sCi0gICAg ICAgICAgICAgICAgICAgICAgICAgdW5zaWduZWQgaW50IG9yZGVyKTsKIAog LyogU2V0IGlkZW50aXR5IGFkZHJlc3NlcyBpbiB0aGUgcDJtIHRhYmxlIChm b3IgcGFzcy10aHJvdWdoKSAqLwogaW50IHNldF9pZGVudGl0eV9wMm1fZW50 cnkoc3RydWN0IGRvbWFpbiAqZCwgdW5zaWduZWQgbG9uZyBnZm4sCg== --=separator Content-Type: application/octet-stream; name="xsa378/xsa378-4.13-0a.patch" Content-Disposition: attachment; filename="xsa378/xsa378-4.13-0a.patch" Content-Transfer-Encoding: base64 RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0 OiB4ODYvcDJtOiBmaXggUG9EIGFjY291bnRpbmcgaW4gZ3Vlc3RfcGh5c21h cF9hZGRfZW50cnkoKQoKVGhlIGluaXRpYWwgb2JzZXJ2YXRpb24gd2FzIHRo YXQgdGhlIG1mbl92YWxpZCgpIGNoZWNrIGNvbWVzIHRvbyBsYXRlOgpOZWl0 aGVyIG1mbl9hZGQoKSBub3IgbWZuX3RvX3BhZ2UoKSAobGV0IGFsb25lIGRl LXJlZmVyZW5jaW5nIHRoZQpyZXN1bHQgb2YgdGhlIGxhdHRlcikgYXJlIHZh bGlkIGZvciBNRk5zIGZhaWxpbmcgdGhpcyBjaGVjay4gTW92ZSBpdCB1cAph bmQgLSBub3RpY2luZyB0aGF0IHRoZXJlJ3Mgbm8gY2FsbGVyIGRvaW5nIHNv IC0gYWxzbyBhZGQgYW4gYXNzZXJ0aW9uCnRoYXQgdGhpcyBzaG91bGQgbmV2 ZXIgcHJvZHVjZSAiZmFsc2UiIGhlcmUuCgpJbiB0dXJuIHRoaXMgd291bGQg aGF2ZSBtZWFudCB0aGF0IHRoZSAiZWxzZSIgdG8gdGhhdCBpZigpIGNvdWxk IG5vdyBnbwphd2F5LCB3aGljaCBkaWRuJ3Qgc2VlbSByaWdodCBhdCBhbGwu IEFuZCBpbmRlZWQsIGNvbnNpZGVyaW5nIGNhbGxlcnMKbGlrZSBtZW1vcnlf ZXhjaGFuZ2UoKSBvciB2YXJpb3VzIGdyYW50IHRhYmxlIGZ1bmN0aW9ucywg dGhlIFBvRAphY2NvdW50aW5nIHNob3VsZCBoYXZlIGJlZW4gb3V0c2lkZSBv ZiB0aGF0IGlmKCkgZnJvbSB0aGUgdmVyeQpiZWdpbm5pbmcuCgpTaWduZWQt b2ZmLWJ5OiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+CkFja2Vk LWJ5OiBBbmRyZXcgQ29vcGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29t PgptYXN0ZXIgY29tbWl0OiBhZWEyNzBlM2Y3YzBkYjY5NmM4OGEwZTk0YjFl Y2U3YWJkMzM5Yzg0Cm1hc3RlciBkYXRlOiAyMDIwLTAyLTIxIDE3OjE0OjM4 ICswMTAwCgotLS0gYS94ZW4vYXJjaC94ODYvbW0vcDJtLmMKKysrIGIveGVu L2FyY2gveDg2L21tL3AybS5jCkBAIC04ODEsNiArODgxLDEyIEBAIGd1ZXN0 X3BoeXNtYXBfYWRkX2VudHJ5KHN0cnVjdCBkb21haW4gKmQKICAgICBpZiAo IHAybV9pc19mb3JlaWduKHQpICkKICAgICAgICAgcmV0dXJuIC1FSU5WQUw7 CiAKKyAgICBpZiAoICFtZm5fdmFsaWQobWZuKSApCisgICAgeworICAgICAg ICBBU1NFUlRfVU5SRUFDSEFCTEUoKTsKKyAgICAgICAgcmV0dXJuIC1FSU5W QUw7CisgICAgfQorCiAgICAgcDJtX2xvY2socDJtKTsKIAogICAgIFAyTV9E RUJVRygiYWRkaW5nIGdmbj0lI2x4IG1mbj0lI2x4XG4iLCBnZm5feChnZm4p LCBtZm5feChtZm4pKTsKQEAgLTk4MSwxMiArOTg3LDEzIEBAIGd1ZXN0X3Bo eXNtYXBfYWRkX2VudHJ5KHN0cnVjdCBkb21haW4gKmQKICAgICB9CiAKICAg ICAvKiBOb3csIGFjdHVhbGx5IGRvIHRoZSB0d28td2F5IG1hcHBpbmcgKi8K LSAgICBpZiAoIG1mbl92YWxpZChtZm4pICkKKyAgICByYyA9IHAybV9zZXRf ZW50cnkocDJtLCBnZm4sIG1mbiwgcGFnZV9vcmRlciwgdCwgcDJtLT5kZWZh dWx0X2FjY2Vzcyk7CisgICAgaWYgKCByYyA9PSAwICkKICAgICB7Ci0gICAg ICAgIHJjID0gcDJtX3NldF9lbnRyeShwMm0sIGdmbiwgbWZuLCBwYWdlX29y ZGVyLCB0LAotICAgICAgICAgICAgICAgICAgICAgICAgICAgcDJtLT5kZWZh dWx0X2FjY2Vzcyk7Ci0gICAgICAgIGlmICggcmMgKQotICAgICAgICAgICAg Z290byBvdXQ7IC8qIEZhaWxlZCB0byB1cGRhdGUgcDJtLCBiYWlsIHdpdGhv dXQgdXBkYXRpbmcgbTJwLiAqLworICAgICAgICBwb2RfbG9jayhwMm0pOwor ICAgICAgICBwMm0tPnBvZC5lbnRyeV9jb3VudCAtPSBwb2RfY291bnQ7Cisg ICAgICAgIEJVR19PTihwMm0tPnBvZC5lbnRyeV9jb3VudCA8IDApOworICAg ICAgICBwb2RfdW5sb2NrKHAybSk7CiAKICAgICAgICAgaWYgKCAhcDJtX2lz X2dyYW50KHQpICkKICAgICAgICAgewpAQCAtOTk1LDIyICsxMDAyLDcgQEAg Z3Vlc3RfcGh5c21hcF9hZGRfZW50cnkoc3RydWN0IGRvbWFpbiAqZAogICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGdmbl94KGdmbl9hZGQo Z2ZuLCBpKSkpOwogICAgICAgICB9CiAgICAgfQotICAgIGVsc2UKLSAgICB7 Ci0gICAgICAgIGdkcHJpbnRrKFhFTkxPR19XQVJOSU5HLCAiQWRkaW5nIGJh ZCBtZm4gdG8gcDJtIG1hcCAoJSNseCAtPiAlI2x4KVxuIiwKLSAgICAgICAg ICAgICAgICAgZ2ZuX3goZ2ZuKSwgbWZuX3gobWZuKSk7Ci0gICAgICAgIHJj ID0gcDJtX3NldF9lbnRyeShwMm0sIGdmbiwgSU5WQUxJRF9NRk4sIHBhZ2Vf b3JkZXIsCi0gICAgICAgICAgICAgICAgICAgICAgICAgICBwMm1faW52YWxp ZCwgcDJtLT5kZWZhdWx0X2FjY2Vzcyk7Ci0gICAgICAgIGlmICggcmMgPT0g MCApCi0gICAgICAgIHsKLSAgICAgICAgICAgIHBvZF9sb2NrKHAybSk7Ci0g ICAgICAgICAgICBwMm0tPnBvZC5lbnRyeV9jb3VudCAtPSBwb2RfY291bnQ7 Ci0gICAgICAgICAgICBCVUdfT04ocDJtLT5wb2QuZW50cnlfY291bnQgPCAw KTsKLSAgICAgICAgICAgIHBvZF91bmxvY2socDJtKTsKLSAgICAgICAgfQot ICAgIH0KIAotb3V0OgogICAgIHAybV91bmxvY2socDJtKTsKIAogICAgIHJl dHVybiByYzsK --=separator Content-Type: application/octet-stream; name="xsa378/xsa378-4.13-0b.patch" Content-Disposition: attachment; filename="xsa378/xsa378-4.13-0b.patch" Content-Transfer-Encoding: base64 RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0 OiB4ODYvcDJtOiBkb24ndCBpZ25vcmUgcDJtX3JlbW92ZV9wYWdlKCkncyBy ZXR1cm4gdmFsdWUKCkl0J3Mgbm90IHZlcnkgbmljZSB0byByZXR1cm4gZnJv bSBndWVzdF9waHlzbWFwX2FkZF9lbnRyeSgpIGFmdGVyCnBlcmhhcHMgYWxy ZWFkeSBoYXZpbmcgbWFkZSBzb21lIGNoYW5nZXMgdG8gdGhlIFAyTSwgYnV0 IHRoaXMgaXMgcHJlLQpleGlzdGluZyBwcmFjdGljZSBpbiB0aGUgZnVuY3Rp b24sIGFuZCBpbW8gYmV0dGVyIHRoYW4gaWdub3JpbmcgZXJyb3JzLgoKVGFr ZSB0aGUgbGliZXJ0eSBhbmQgcmVwbGFjZSBhbiBtZm5fYWRkKCkgaW5zdGFu Y2Ugd2l0aCBhIGxvY2FsIHZhcmlhYmxlCmFscmVhZHkgaG9sZGluZyB0aGUg cmVzdWx0IChhcyBwcm92ZW4gYnkgdGhlIGNoZWNrIGltbWVkaWF0ZWx5IGFo ZWFkKS4KClNpZ25lZC1vZmYtYnk6IEphbiBCZXVsaWNoIDxqYmV1bGljaEBz dXNlLmNvbT4KUmV2aWV3ZWQtYnk6IFBhdWwgRHVycmFudCA8cGF1bC5kdXJy YW50QGNpdHJpeC5jb20+CkFja2VkLWJ5OiBBbmRyZXcgQ29vcGVyIDxhbmRy ZXcuY29vcGVyM0BjaXRyaXguY29tPgptYXN0ZXIgY29tbWl0OiBhNmIwNTFh ODdhNTg2MzQ3OTY5YmZiYWE2OTI1YWMwZjBjODQ1NDEzCm1hc3RlciBkYXRl OiAyMDIwLTA0LTAzIDEwOjU2OjEwICswMjAwCgotLS0gYS94ZW4vYXJjaC94 ODYvbW0vcDJtLmMKKysrIGIveGVuL2FyY2gveDg2L21tL3AybS5jCkBAIC03 NzMsOCArNzczLDcgQEAgdm9pZCBwMm1fZmluYWxfdGVhcmRvd24oc3RydWN0 IGRvbWFpbiAqZAogICAgIHAybV90ZWFyZG93bl9ob3N0cDJtKGQpOwogfQog Ci0KLXN0YXRpYyBpbnQKK3N0YXRpYyBpbnQgX19tdXN0X2NoZWNrCiBwMm1f cmVtb3ZlX3BhZ2Uoc3RydWN0IHAybV9kb21haW4gKnAybSwgdW5zaWduZWQg bG9uZyBnZm5fbCwgdW5zaWduZWQgbG9uZyBtZm4sCiAgICAgICAgICAgICAg ICAgdW5zaWduZWQgaW50IHBhZ2Vfb3JkZXIpCiB7CkBAIC05NzksOSArOTc4 LDkgQEAgZ3Vlc3RfcGh5c21hcF9hZGRfZW50cnkoc3RydWN0IGRvbWFpbiAq ZAogICAgICAgICAgICAgICAgIEFTU0VSVChtZm5fdmFsaWQob21mbikpOwog ICAgICAgICAgICAgICAgIFAyTV9ERUJVRygib2xkIGdmbj0lI2x4IC0+IG1m biAlI2x4XG4iLAogICAgICAgICAgICAgICAgICAgICAgICAgICBnZm5feChv Z2ZuKSAsIG1mbl94KG9tZm4pKTsKLSAgICAgICAgICAgICAgICBpZiAoIG1m bl9lcShvbWZuLCBtZm5fYWRkKG1mbiwgaSkpICkKLSAgICAgICAgICAgICAg ICAgICAgcDJtX3JlbW92ZV9wYWdlKHAybSwgZ2ZuX3gob2dmbiksIG1mbl94 KG1mbl9hZGQobWZuLCBpKSksCi0gICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAwKTsKKyAgICAgICAgICAgICAgICBpZiAoIG1mbl9lcShv bWZuLCBtZm5fYWRkKG1mbiwgaSkpICYmCisgICAgICAgICAgICAgICAgICAg ICAocmMgPSBwMm1fcmVtb3ZlX3BhZ2UocDJtLCBnZm5feChvZ2ZuKSwgbWZu X3gob21mbiksIDApKSApCisgICAgICAgICAgICAgICAgICAgIGdvdG8gb3V0 OwogICAgICAgICAgICAgfQogICAgICAgICB9CiAgICAgfQpAQCAtMTAwMyw2 ICsxMDAyLDcgQEAgZ3Vlc3RfcGh5c21hcF9hZGRfZW50cnkoc3RydWN0IGRv bWFpbiAqZAogICAgICAgICB9CiAgICAgfQogCisgb3V0OgogICAgIHAybV91 bmxvY2socDJtKTsKIAogICAgIHJldHVybiByYzsKQEAgLTI2OTAsOSArMjY5 MCw5IEBAIGludCBwMm1fY2hhbmdlX2FsdHAybV9nZm4oc3RydWN0IGRvbWFp bgogICAgIGlmICggZ2ZuX2VxKG5ld19nZm4sIElOVkFMSURfR0ZOKSApCiAg ICAgewogICAgICAgICBtZm4gPSBhcDJtLT5nZXRfZW50cnkoYXAybSwgb2xk X2dmbiwgJnQsICZhLCAwLCBOVUxMLCBOVUxMKTsKLSAgICAgICAgaWYgKCBt Zm5fdmFsaWQobWZuKSApCi0gICAgICAgICAgICBwMm1fcmVtb3ZlX3BhZ2Uo YXAybSwgZ2ZuX3gob2xkX2dmbiksIG1mbl94KG1mbiksIFBBR0VfT1JERVJf NEspOwotICAgICAgICByYyA9IDA7CisgICAgICAgIHJjID0gbWZuX3ZhbGlk KG1mbikKKyAgICAgICAgICAgICA/IHAybV9yZW1vdmVfcGFnZShhcDJtLCBn Zm5feChvbGRfZ2ZuKSwgbWZuX3gobWZuKSwgUEFHRV9PUkRFUl80SykKKyAg ICAgICAgICAgICA6IDA7CiAgICAgICAgIGdvdG8gb3V0OwogICAgIH0KIAo= --=separator Content-Type: application/octet-stream; name="xsa378/xsa378-4.13-0c.patch" Content-Disposition: attachment; filename="xsa378/xsa378-4.13-0c.patch" Content-Transfer-Encoding: base64 RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0 OiB4ODYvcDJtOiBkb24ndCBhc3NlcnQgdGhhdCB0aGUgcGFzc2VkIGluIE1G TiBtYXRjaGVzIGZvciBhIHJlbW92ZQoKZ3Vlc3RfcGh5c21hcF9yZW1vdmVf cGFnZSgpIGdldHMgaGFuZGVkIGFuIE1GTiBmcm9tIHRoZSBvdXRzaWRlLCB5 ZXQKdGFrZXMgdGhlIG5lY2Vzc2FyeSBsb2NrIHRvIHByZXZlbnQgZnVydGhl ciBjaGFuZ2VzIHRvIHRoZSBHRk4gPC0+IE1GTgptYXBwaW5nIGl0c2VsZi4g V2hpbGUgc29tZSBjYWxsZXJzLCBpbiBwYXJ0aWN1bGFyIGd1ZXN0X3JlbW92 ZV9wYWdlKCkKKGJ5IHdheSBvZiBoYXZpbmcgY2FsbGVkIGdldF9nZm5fcXVl cnkoKSksIGhvbGQgdGhlIEdGTiBsb2NrIGFscmVhZHksCnZhcmlvdXMgb3Ro ZXJzIChtb3N0IG5vdGFibHkgcGVyaGFwcyB0aGUgMm5kIGluc3RhbmNlIGlu Cnhlbm1lbV9hZGRfdG9fcGh5c21hcF9vbmUoKSkgZG9uJ3QuIFdoaWxlIGl0 IGFsc28gaXMgYW4gb3B0aW9uIHRvIGZpeAphbGwgdGhlIGNhbGxlcnMsIGRl YWwgd2l0aCB0aGUgaXNzdWUgaW4gcDJtX3JlbW92ZV9wYWdlKCkgaW5zdGVh ZDoKUmVwbGFjZSB0aGUgQVNTRVJUKCkgYnkgYSBjb25kaXRpb25hbCBhbmQg c3BsaXQgdGhlIGxvb3AgaW50byB0d28sIHN1Y2gKdGhhdCBhbGwgY2hlY2tp bmcgZ2V0cyBkb25lIGJlZm9yZSBhbnkgbW9kaWZpY2F0aW9uIHdvdWxkIG9j Y3VyLgoKU2lnbmVkLW9mZi1ieTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1 c2UuY29tPgpSZXZpZXdlZC1ieTogUGF1bCBEdXJyYW50IDxwYXVsLmR1cnJh bnRAY2l0cml4LmNvbT4KQWNrZWQtYnk6IEFuZHJldyBDb29wZXIgPGFuZHJl dy5jb29wZXIzQGNpdHJpeC5jb20+Cm1hc3RlciBjb21taXQ6IGM2NWVhMTZk YmNhZmJlNGZlMjE2OTNiMThmOGMyYTNjNWQxNDYwMGUKbWFzdGVyIGRhdGU6 IDIwMjAtMDQtMDMgMTA6NTY6NTUgKzAyMDAKCi0tLSBhL3hlbi9hcmNoL3g4 Ni9tbS9wMm0uYworKysgYi94ZW4vYXJjaC94ODYvbW0vcDJtLmMKQEAgLTc3 OSw3ICs3NzksNiBAQCBwMm1fcmVtb3ZlX3BhZ2Uoc3RydWN0IHAybV9kb21h aW4gKnAybSwKIHsKICAgICB1bnNpZ25lZCBsb25nIGk7CiAgICAgZ2ZuX3Qg Z2ZuID0gX2dmbihnZm5fbCk7Ci0gICAgbWZuX3QgbWZuX3JldHVybjsKICAg ICBwMm1fdHlwZV90IHQ7CiAgICAgcDJtX2FjY2Vzc190IGE7CiAKQEAgLTc5 MCwxNSArNzg5LDI2IEBAIHAybV9yZW1vdmVfcGFnZShzdHJ1Y3QgcDJtX2Rv bWFpbiAqcDJtLAogICAgIEFTU0VSVChnZm5fbG9ja2VkX2J5X21lKHAybSwg Z2ZuKSk7CiAgICAgUDJNX0RFQlVHKCJyZW1vdmluZyBnZm49JSNseCBtZm49 JSNseFxuIiwgZ2ZuX2wsIG1mbik7CiAKKyAgICBmb3IgKCBpID0gMDsgaSA8 ICgxVUwgPDwgcGFnZV9vcmRlcik7ICkKKyAgICB7CisgICAgICAgIHVuc2ln bmVkIGludCBjdXJfb3JkZXI7CisgICAgICAgIG1mbl90IG1mbl9yZXR1cm4g PSBwMm0tPmdldF9lbnRyeShwMm0sIGdmbl9hZGQoZ2ZuLCBpKSwgJnQsICZh LCAwLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgJmN1cl9vcmRlciwgTlVMTCk7CisKKyAgICAgICAgaWYgKCBwMm1faXNf dmFsaWQodCkgJiYKKyAgICAgICAgICAgICAoIW1mbl92YWxpZChfbWZuKG1m bikpIHx8IG1mbiArIGkgIT0gbWZuX3gobWZuX3JldHVybikpICkKKyAgICAg ICAgICAgIHJldHVybiAtRUlMU0VROworCisgICAgICAgIGkgKz0gKDFVTCA8 PCBjdXJfb3JkZXIpIC0gKChnZm5fbCArIGkpICYgKCgxVUwgPDwgY3VyX29y ZGVyKSAtIDEpKTsKKyAgICB9CisKICAgICBpZiAoIG1mbl92YWxpZChfbWZu KG1mbikpICkKICAgICB7CiAgICAgICAgIGZvciAoIGkgPSAwOyBpIDwgKDFV TCA8PCBwYWdlX29yZGVyKTsgaSsrICkKICAgICAgICAgewotICAgICAgICAg ICAgbWZuX3JldHVybiA9IHAybS0+Z2V0X2VudHJ5KHAybSwgZ2ZuX2FkZChn Zm4sIGkpLCAmdCwgJmEsIDAsCi0gICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgTlVMTCwgTlVMTCk7CisgICAgICAgICAgICBwMm0t PmdldF9lbnRyeShwMm0sIGdmbl9hZGQoZ2ZuLCBpKSwgJnQsICZhLCAwLCBO VUxMLCBOVUxMKTsKICAgICAgICAgICAgIGlmICggIXAybV9pc19ncmFudCh0 KSAmJiAhcDJtX2lzX3NoYXJlZCh0KSAmJiAhcDJtX2lzX2ZvcmVpZ24odCkg KQogICAgICAgICAgICAgICAgIHNldF9ncGZuX2Zyb21fbWZuKG1mbitpLCBJ TlZBTElEX00yUF9FTlRSWSk7Ci0gICAgICAgICAgICBBU1NFUlQoICFwMm1f aXNfdmFsaWQodCkgfHwgbWZuICsgaSA9PSBtZm5feChtZm5fcmV0dXJuKSAp OwogICAgICAgICB9CiAgICAgfQogICAgIHJldHVybiBwMm1fc2V0X2VudHJ5 KHAybSwgZ2ZuLCBJTlZBTElEX01GTiwgcGFnZV9vcmRlciwgcDJtX2ludmFs aWQsCg== --=separator Content-Type: application/octet-stream; name="xsa378/xsa378-4.13-1.patch" Content-Disposition: attachment; filename="xsa378/xsa378-4.13-1.patch" Content-Transfer-Encoding: base64 RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0 OiBBTUQvSU9NTVU6IGNvcnJlY3QgZ2xvYmFsIGV4Y2x1c2lvbiByYW5nZSBl eHRlbmRpbmcKCkJlc2lkZXMgdW5pdHkgbWFwcGluZyByZWdpb25zLCB0aGUg QU1EIElPTU1VIHNwZWMgYWxzbyBwcm92aWRlcyBmb3IKZXhjbHVzaW9uIHJh bmdlcyAoYXJlYXMgb2YgbWVtb3J5IG5vdCB0byBiZSBzdWJqZWN0IHRvIERN QSB0cmFuc2xhdGlvbikKdG8gYmUgc3BlY2lmaWVkIGJ5IGZpcm13YXJlIGlu IHRoZSBBQ1BJIHRhYmxlcy4gVGhlIHNwZWMgZG9lcyBub3QgcHV0CmFueSBj b25zdHJhaW50cyBvbiB0aGUgbnVtYmVyIG9mIHN1Y2ggcmVnaW9ucy4KCkJs aW5kbHkgYXNzdW1pbmcgYWxsIGFkZHJlc3NlcyBiZXR3ZWVuIGFueSB0d28g c3VjaCByYW5nZXMgc2hvdWxkIGFsc28KYmUgZXhjbHVkZWQgY2FuJ3QgYmUg cmlnaHQuIFNpbmNlIGhhcmR3YXJlIGhhcyByb29tIGZvciBqdXN0IGEgc2lu Z2xlCnN1Y2ggcmFuZ2UgKGNvbXByaXNlZCBvZiB0aGUgRXhjbHVzaW9uIEJh c2UgUmVnaXN0ZXIgYW5kIHRoZSBFeGNsdXNpb24KUmFuZ2UgTGltaXQgUmVn aXN0ZXIpLCBjb21iaW5lIG9ubHkgYWRqYWNlbnQgb3Igb3ZlcmxhcHBpbmcg cmVnaW9ucyAoZm9yCm5vdzsgdGhpcyBtYXkgcmVxdWlyZSBmdXJ0aGVyIGFk anVzdG1lbnQgaW4gY2FzZSB0YWJsZSBlbnRyaWVzIGFyZW4ndApzb3J0ZWQg YnkgYWRkcmVzcykgd2l0aCBtYXRjaGluZyBleGNsdXNpb25fYWxsb3dfYWxs IHNldHRpbmdzLiBUaGlzCnJlcXVpcmVzIGJ1YmJsaW5nIHVwIGVycm9yIGlu ZGljYXRvcnMsIHN1Y2ggdGhhdCBJT01NVSBpbml0IGNhbiBiZQpmYWlsZWQg d2hlbiBjb25jYXRlbmF0aW9uIHdhc24ndCBwb3NzaWJsZS4KCkZ1cnRoZXJt b3JlLCBzaW5jZSB0aGUgZXhjbHVzaW9uIHJhbmdlIHNwZWNpZmllZCBpbiBJ T01NVSByZWdpc3RlcnMKaW1wbGllcyBSL1cgYWNjZXNzLCByZWplY3QgcmVx dWVzdHMgYXNraW5nIGZvciBsZXNzIHBlcm1pc3Npb25zICh0aGlzCndpbGwg YmUgYnJvdWdodCBjbG9zZXIgdG8gdGhlIHNwZWMgYnkgYSBzdWJzZXF1ZW50 IGNoYW5nZSkuCgpUaGlzIGlzIHBhcnQgb2YgWFNBLTM3OCAvIENWRS0yMDIx LTI4Njk1LgoKU2lnbmVkLW9mZi1ieTogSmFuIEJldWxpY2ggPGpiZXVsaWNo QHN1c2UuY29tPgpSZXZpZXdlZC1ieTogUGF1bCBEdXJyYW50IDxwYXVsQHhl bi5vcmc+CgotLS0gYS94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC9hbWQvaW9t bXVfYWNwaS5jCisrKyBiL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL2FtZC9p b21tdV9hY3BpLmMKQEAgLTExNywxMiArMTE3LDIxIEBAIHN0YXRpYyBzdHJ1 Y3QgYW1kX2lvbW11ICogX19pbml0IGZpbmRfaW8KICAgICByZXR1cm4gTlVM TDsKIH0KIAotc3RhdGljIHZvaWQgX19pbml0IHJlc2VydmVfaW9tbXVfZXhj bHVzaW9uX3JhbmdlKAotICAgIHN0cnVjdCBhbWRfaW9tbXUgKmlvbW11LCB1 aW50NjRfdCBiYXNlLCB1aW50NjRfdCBsaW1pdCkKK3N0YXRpYyBpbnQgX19p bml0IHJlc2VydmVfaW9tbXVfZXhjbHVzaW9uX3JhbmdlKAorICAgIHN0cnVj dCBhbWRfaW9tbXUgKmlvbW11LCB1aW50NjRfdCBiYXNlLCB1aW50NjRfdCBs aW1pdCwKKyAgICBib29sIGFsbCwgYm9vbCBpdywgYm9vbCBpcikKIHsKKyAg ICBpZiAoICFpciB8fCAhaXcgKQorICAgICAgICByZXR1cm4gLUVQRVJNOwor CiAgICAgLyogbmVlZCB0byBleHRlbmQgZXhjbHVzaW9uIHJhbmdlPyAqLwog ICAgIGlmICggaW9tbXUtPmV4Y2x1c2lvbl9lbmFibGUgKQogICAgIHsKKyAg ICAgICAgaWYgKCBpb21tdS0+ZXhjbHVzaW9uX2xpbWl0ICsgUEFHRV9TSVpF IDwgYmFzZSB8fAorICAgICAgICAgICAgIGxpbWl0ICsgUEFHRV9TSVpFIDwg aW9tbXUtPmV4Y2x1c2lvbl9iYXNlIHx8CisgICAgICAgICAgICAgaW9tbXUt PmV4Y2x1c2lvbl9hbGxvd19hbGwgIT0gYWxsICkKKyAgICAgICAgICAgIHJl dHVybiAtRUJVU1k7CisKICAgICAgICAgaWYgKCBpb21tdS0+ZXhjbHVzaW9u X2Jhc2UgPCBiYXNlICkKICAgICAgICAgICAgIGJhc2UgPSBpb21tdS0+ZXhj bHVzaW9uX2Jhc2U7CiAgICAgICAgIGlmICggaW9tbXUtPmV4Y2x1c2lvbl9s aW1pdCA+IGxpbWl0ICkKQEAgLTEzMCwxNiArMTM5LDExIEBAIHN0YXRpYyB2 b2lkIF9faW5pdCByZXNlcnZlX2lvbW11X2V4Y2x1c2kKICAgICB9CiAKICAg ICBpb21tdS0+ZXhjbHVzaW9uX2VuYWJsZSA9IElPTU1VX0NPTlRST0xfRU5B QkxFRDsKKyAgICBpb21tdS0+ZXhjbHVzaW9uX2FsbG93X2FsbCA9IGFsbDsK ICAgICBpb21tdS0+ZXhjbHVzaW9uX2Jhc2UgPSBiYXNlOwogICAgIGlvbW11 LT5leGNsdXNpb25fbGltaXQgPSBsaW1pdDsKLX0KIAotc3RhdGljIHZvaWQg X19pbml0IHJlc2VydmVfaW9tbXVfZXhjbHVzaW9uX3JhbmdlX2FsbCgKLSAg ICBzdHJ1Y3QgYW1kX2lvbW11ICppb21tdSwKLSAgICB1bnNpZ25lZCBsb25n IGJhc2UsIHVuc2lnbmVkIGxvbmcgbGltaXQpCi17Ci0gICAgcmVzZXJ2ZV9p b21tdV9leGNsdXNpb25fcmFuZ2UoaW9tbXUsIGJhc2UsIGxpbWl0KTsKLSAg ICBpb21tdS0+ZXhjbHVzaW9uX2FsbG93X2FsbCA9IElPTU1VX0NPTlRST0xf RU5BQkxFRDsKKyAgICByZXR1cm4gMDsKIH0KIAogc3RhdGljIHZvaWQgX19p bml0IHJlc2VydmVfdW5pdHlfbWFwX2Zvcl9kZXZpY2UoCkBAIC0xNzcsNiAr MTgxLDcgQEAgc3RhdGljIGludCBfX2luaXQgcmVnaXN0ZXJfZXhjbHVzaW9u X3JhbgogICAgIHVuc2lnbmVkIGxvbmcgcmFuZ2VfdG9wLCBpb21tdV90b3As IGxlbmd0aDsKICAgICBzdHJ1Y3QgYW1kX2lvbW11ICppb21tdTsKICAgICB1 bnNpZ25lZCBpbnQgYmRmOworICAgIGludCByYyA9IDA7CiAKICAgICAvKiBp cyBwYXJ0IG9mIGV4Y2x1c2lvbiByYW5nZSBpbnNpZGUgb2YgSU9NTVUgdmly dHVhbCBhZGRyZXNzIHNwYWNlPyAqLwogICAgIC8qIG5vdGU6ICdsaW1pdCcg cGFyYW1ldGVyIGlzIGFzc3VtZWQgdG8gYmUgcGFnZS1hbGlnbmVkICovCkBA IC0xOTgsMTAgKzIwMywxNSBAQCBzdGF0aWMgaW50IF9faW5pdCByZWdpc3Rl cl9leGNsdXNpb25fcmFuCiAgICAgaWYgKCBsaW1pdCA+PSBpb21tdV90b3Ag KQogICAgIHsKICAgICAgICAgZm9yX2VhY2hfYW1kX2lvbW11KCBpb21tdSAp Ci0gICAgICAgICAgICByZXNlcnZlX2lvbW11X2V4Y2x1c2lvbl9yYW5nZV9h bGwoaW9tbXUsIGJhc2UsIGxpbWl0KTsKKyAgICAgICAgeworICAgICAgICAg ICAgcmMgPSByZXNlcnZlX2lvbW11X2V4Y2x1c2lvbl9yYW5nZShpb21tdSwg YmFzZSwgbGltaXQsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIHRydWUgLyogYWxsICovLCBpdywgaXIpOworICAg ICAgICAgICAgaWYgKCByYyApCisgICAgICAgICAgICAgICAgYnJlYWs7Cisg ICAgICAgIH0KICAgICB9CiAKLSAgICByZXR1cm4gMDsKKyAgICByZXR1cm4g cmM7CiB9CiAKIHN0YXRpYyBpbnQgX19pbml0IHJlZ2lzdGVyX2V4Y2x1c2lv bl9yYW5nZV9mb3JfZGV2aWNlKApAQCAtMjEyLDYgKzIyMiw3IEBAIHN0YXRp YyBpbnQgX19pbml0IHJlZ2lzdGVyX2V4Y2x1c2lvbl9yYW4KICAgICB1bnNp Z25lZCBsb25nIHJhbmdlX3RvcCwgaW9tbXVfdG9wLCBsZW5ndGg7CiAgICAg c3RydWN0IGFtZF9pb21tdSAqaW9tbXU7CiAgICAgdTE2IHJlcTsKKyAgICBp bnQgcmMgPSAwOwogCiAgICAgaW9tbXUgPSBmaW5kX2lvbW11X2Zvcl9kZXZp Y2Uoc2VnLCBiZGYpOwogICAgIGlmICggIWlvbW11ICkKQEAgLTI0MSwxMiAr MjUyLDEzIEBAIHN0YXRpYyBpbnQgX19pbml0IHJlZ2lzdGVyX2V4Y2x1c2lv bl9yYW4KICAgICAvKiByZWdpc3RlciBJT01NVSBleGNsdXNpb24gcmFuZ2Ug c2V0dGluZ3MgZm9yIGRldmljZSAqLwogICAgIGlmICggbGltaXQgPj0gaW9t bXVfdG9wICApCiAgICAgewotICAgICAgICByZXNlcnZlX2lvbW11X2V4Y2x1 c2lvbl9yYW5nZShpb21tdSwgYmFzZSwgbGltaXQpOworICAgICAgICByYyA9 IHJlc2VydmVfaW9tbXVfZXhjbHVzaW9uX3JhbmdlKGlvbW11LCBiYXNlLCBs aW1pdCwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICBmYWxzZSAvKiBhbGwgKi8sIGl3LCBpcik7CiAgICAgICAgIGl2cnNf bWFwcGluZ3NbYmRmXS5kdGVfYWxsb3dfZXhjbHVzaW9uID0gdHJ1ZTsKICAg ICAgICAgaXZyc19tYXBwaW5nc1tyZXFdLmR0ZV9hbGxvd19leGNsdXNpb24g PSB0cnVlOwogICAgIH0KIAotICAgIHJldHVybiAwOworICAgIHJldHVybiBy YzsKIH0KIAogc3RhdGljIGludCBfX2luaXQgcmVnaXN0ZXJfZXhjbHVzaW9u X3JhbmdlX2Zvcl9pb21tdV9kZXZpY2VzKApAQCAtMjU2LDYgKzI2OCw3IEBA IHN0YXRpYyBpbnQgX19pbml0IHJlZ2lzdGVyX2V4Y2x1c2lvbl9yYW4KICAg ICB1bnNpZ25lZCBsb25nIHJhbmdlX3RvcCwgaW9tbXVfdG9wLCBsZW5ndGg7 CiAgICAgdW5zaWduZWQgaW50IGJkZjsKICAgICB1MTYgcmVxOworICAgIGlu dCByYyA9IDA7CiAKICAgICAvKiBpcyBwYXJ0IG9mIGV4Y2x1c2lvbiByYW5n ZSBpbnNpZGUgb2YgSU9NTVUgdmlydHVhbCBhZGRyZXNzIHNwYWNlPyAqLwog ICAgIC8qIG5vdGU6ICdsaW1pdCcgcGFyYW1ldGVyIGlzIGFzc3VtZWQgdG8g YmUgcGFnZS1hbGlnbmVkICovCkBAIC0yODYsOCArMjk5LDEwIEBAIHN0YXRp YyBpbnQgX19pbml0IHJlZ2lzdGVyX2V4Y2x1c2lvbl9yYW4KIAogICAgIC8q IHJlZ2lzdGVyIElPTU1VIGV4Y2x1c2lvbiByYW5nZSBzZXR0aW5ncyAqLwog ICAgIGlmICggbGltaXQgPj0gaW9tbXVfdG9wICkKLSAgICAgICAgcmVzZXJ2 ZV9pb21tdV9leGNsdXNpb25fcmFuZ2VfYWxsKGlvbW11LCBiYXNlLCBsaW1p dCk7Ci0gICAgcmV0dXJuIDA7CisgICAgICAgIHJjID0gcmVzZXJ2ZV9pb21t dV9leGNsdXNpb25fcmFuZ2UoaW9tbXUsIGJhc2UsIGxpbWl0LAorICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHRydWUgLyog YWxsICovLCBpdywgaXIpOworCisgICAgcmV0dXJuIHJjOwogfQogCiBzdGF0 aWMgaW50IF9faW5pdCBwYXJzZV9pdm1kX2RldmljZV9zZWxlY3QoCg== --=separator Content-Type: application/octet-stream; name="xsa378/xsa378-4.13-2.patch" Content-Disposition: attachment; filename="xsa378/xsa378-4.13-2.patch" Content-Transfer-Encoding: base64 RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0 OiBBTUQvSU9NTVU6IGNvcnJlY3QgZGV2aWNlIHVuaXR5IG1hcCBoYW5kbGlu ZwoKQmxpbmRseSBhc3N1bWluZyBhbGwgYWRkcmVzc2VzIGJldHdlZW4gYW55 IHR3byBzdWNoIHJhbmdlcywgc3BlY2lmaWVkIGJ5CmZpcm13YXJlIGluIHRo ZSBBQ1BJIHRhYmxlcywgc2hvdWxkIGFsc28gYmUgdW5pdHktbWFwcGVkIGNh bid0IGJlIHJpZ2h0LgpOb3IgY2FuIGl0IGJlIGNvcnJlY3QgdG8gbWVyZ2Ug cmFuZ2VzIHdpdGggZGlmZmVyaW5nIHBlcm1pc3Npb25zLiBUcmFjawpyYW5n ZXMgaW5kaXZpZHVhbGx5OyBkb24ndCBtZXJnZSBhdCBhbGwsIGJ1dCBjaGVj ayBmb3Igb3ZlcmxhcHMgaW5zdGVhZC4KVGhpcyByZXF1aXJlcyBidWJibGlu ZyB1cCBlcnJvciBpbmRpY2F0b3JzLCBzdWNoIHRoYXQgSU9NTVUgaW5pdCBj YW4gYmUKZmFpbGVkIHdoZW4gYWxsb2NhdGlvbiBvZiBhIG5ldyB0cmFja2lu ZyBzdHJ1Y3Qgd2Fzbid0IHBvc3NpYmxlLCBvciBhbgpvdmVybGFwIHdhcyBk ZXRlY3RlZC4KCkF0IHRoaXMgb2NjYXNpb24gYWxzbyBzdG9wIGlnbm9yaW5n CmFtZF9pb21tdV9yZXNlcnZlX2RvbWFpbl91bml0eV9tYXAoKSdzIHJldHVy biB2YWx1ZS4KClRoaXMgaXMgcGFydCBvZiBYU0EtMzc4IC8gQ1ZFLTIwMjEt Mjg2OTUuCgpTaWduZWQtb2ZmLWJ5OiBKYW4gQmV1bGljaCA8amJldWxpY2hA c3VzZS5jb20+ClJldmlld2VkLWJ5OiBHZW9yZ2UgRHVubGFwIDxnZW9yZ2Uu ZHVubGFwQGNpdHJpeC5jb20+ClJldmlld2VkLWJ5OiBQYXVsIER1cnJhbnQg PHBhdWxAeGVuLm9yZz4KCi0tLSBhL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdo L2FtZC9pb21tdV9hY3BpLmMKKysrIGIveGVuL2RyaXZlcnMvcGFzc3Rocm91 Z2gvYW1kL2lvbW11X2FjcGkuYwpAQCAtMTQ2LDMyICsxNDYsNDggQEAgc3Rh dGljIGludCBfX2luaXQgcmVzZXJ2ZV9pb21tdV9leGNsdXNpbwogICAgIHJl dHVybiAwOwogfQogCi1zdGF0aWMgdm9pZCBfX2luaXQgcmVzZXJ2ZV91bml0 eV9tYXBfZm9yX2RldmljZSgKLSAgICB1MTYgc2VnLCB1MTYgYmRmLCB1bnNp Z25lZCBsb25nIGJhc2UsCi0gICAgdW5zaWduZWQgbG9uZyBsZW5ndGgsIHU4 IGl3LCB1OCBpcikKK3N0YXRpYyBpbnQgX19pbml0IHJlc2VydmVfdW5pdHlf bWFwX2Zvcl9kZXZpY2UoCisgICAgdWludDE2X3Qgc2VnLCB1aW50MTZfdCBi ZGYsIHVuc2lnbmVkIGxvbmcgYmFzZSwKKyAgICB1bnNpZ25lZCBsb25nIGxl bmd0aCwgYm9vbCBpdywgYm9vbCBpcikKIHsKICAgICBzdHJ1Y3QgaXZyc19t YXBwaW5ncyAqaXZyc19tYXBwaW5ncyA9IGdldF9pdnJzX21hcHBpbmdzKHNl Zyk7Ci0gICAgdW5zaWduZWQgbG9uZyBvbGRfdG9wLCBuZXdfdG9wOworICAg IHN0cnVjdCBpdnJzX3VuaXR5X21hcCAqdW5pdHlfbWFwID0gaXZyc19tYXBw aW5nc1tiZGZdLnVuaXR5X21hcDsKIAotICAgIC8qIG5lZWQgdG8gZXh0ZW5k IHVuaXR5LW1hcHBlZCByYW5nZT8gKi8KLSAgICBpZiAoIGl2cnNfbWFwcGlu Z3NbYmRmXS51bml0eV9tYXBfZW5hYmxlICkKKyAgICAvKiBDaGVjayBmb3Ig b3ZlcmxhcHMuICovCisgICAgZm9yICggOyB1bml0eV9tYXA7IHVuaXR5X21h cCA9IHVuaXR5X21hcC0+bmV4dCApCiAgICAgewotICAgICAgICBvbGRfdG9w ID0gaXZyc19tYXBwaW5nc1tiZGZdLmFkZHJfcmFuZ2Vfc3RhcnQgKwotICAg ICAgICAgICAgaXZyc19tYXBwaW5nc1tiZGZdLmFkZHJfcmFuZ2VfbGVuZ3Ro OwotICAgICAgICBuZXdfdG9wID0gYmFzZSArIGxlbmd0aDsKLSAgICAgICAg aWYgKCBvbGRfdG9wID4gbmV3X3RvcCApCi0gICAgICAgICAgICBuZXdfdG9w ID0gb2xkX3RvcDsKLSAgICAgICAgaWYgKCBpdnJzX21hcHBpbmdzW2JkZl0u YWRkcl9yYW5nZV9zdGFydCA8IGJhc2UgKQotICAgICAgICAgICAgYmFzZSA9 IGl2cnNfbWFwcGluZ3NbYmRmXS5hZGRyX3JhbmdlX3N0YXJ0OwotICAgICAg ICBsZW5ndGggPSBuZXdfdG9wIC0gYmFzZTsKLSAgICB9Ci0KLSAgICAvKiBl eHRlbmQgci93IHBlcm1pc3Npb21zIGFuZCBrZWVwIGFnZ3JlZ2F0ZSAqLwot ICAgIGl2cnNfbWFwcGluZ3NbYmRmXS53cml0ZV9wZXJtaXNzaW9uID0gaXc7 Ci0gICAgaXZyc19tYXBwaW5nc1tiZGZdLnJlYWRfcGVybWlzc2lvbiA9IGly OwotICAgIGl2cnNfbWFwcGluZ3NbYmRmXS51bml0eV9tYXBfZW5hYmxlID0g dHJ1ZTsKLSAgICBpdnJzX21hcHBpbmdzW2JkZl0uYWRkcl9yYW5nZV9zdGFy dCA9IGJhc2U7Ci0gICAgaXZyc19tYXBwaW5nc1tiZGZdLmFkZHJfcmFuZ2Vf bGVuZ3RoID0gbGVuZ3RoOworICAgICAgICAvKgorICAgICAgICAgKiBFeGFj dCBtYXRjaGVzIGFyZSBva2F5LiBUaGlzIGNhbiBpbiBwYXJ0aWN1bGFyIGhh cHBlbiB3aGVuCisgICAgICAgICAqIHJlZ2lzdGVyX2V4Y2x1c2lvbl9yYW5n ZV9mb3JfZGV2aWNlKCkgY2FsbHMgaGVyZSB0d2ljZSBmb3IgdGhlCisgICAg ICAgICAqIHNhbWUgKHMsYixkLGYpLgorICAgICAgICAgKi8KKyAgICAgICAg aWYgKCBiYXNlID09IHVuaXR5X21hcC0+YWRkciAmJiBsZW5ndGggPT0gdW5p dHlfbWFwLT5sZW5ndGggJiYKKyAgICAgICAgICAgICBpciA9PSB1bml0eV9t YXAtPnJlYWQgJiYgaXcgPT0gdW5pdHlfbWFwLT53cml0ZSApCisgICAgICAg ICAgICByZXR1cm4gMDsKKworICAgICAgICBpZiAoIHVuaXR5X21hcC0+YWRk ciArIHVuaXR5X21hcC0+bGVuZ3RoID4gYmFzZSAmJgorICAgICAgICAgICAg IGJhc2UgKyBsZW5ndGggPiB1bml0eV9tYXAtPmFkZHIgKQorICAgICAgICB7 CisgICAgICAgICAgICBBTURfSU9NTVVfREVCVUcoIklWTUQgRXJyb3I6IG92 ZXJsYXAgWyVseCwlbHgpIHZzIFslbHgsJWx4KVxuIiwKKyAgICAgICAgICAg ICAgICAgICAgICAgICAgICBiYXNlLCBiYXNlICsgbGVuZ3RoLCB1bml0eV9t YXAtPmFkZHIsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgdW5pdHlf bWFwLT5hZGRyICsgdW5pdHlfbWFwLT5sZW5ndGgpOworICAgICAgICAgICAg cmV0dXJuIC1FUEVSTTsKKyAgICAgICAgfQorICAgIH0KKworICAgIC8qIFBv cHVsYXRlIGFuZCBpbnNlcnQgYSBuZXcgdW5pdHkgbWFwLiAqLworICAgIHVu aXR5X21hcCA9IHhtYWxsb2Moc3RydWN0IGl2cnNfdW5pdHlfbWFwKTsKKyAg ICBpZiAoICF1bml0eV9tYXAgKQorICAgICAgICByZXR1cm4gLUVOT01FTTsK KworICAgIHVuaXR5X21hcC0+cmVhZCA9IGlyOworICAgIHVuaXR5X21hcC0+ d3JpdGUgPSBpdzsKKyAgICB1bml0eV9tYXAtPmFkZHIgPSBiYXNlOworICAg IHVuaXR5X21hcC0+bGVuZ3RoID0gbGVuZ3RoOworICAgIHVuaXR5X21hcC0+ bmV4dCA9IGl2cnNfbWFwcGluZ3NbYmRmXS51bml0eV9tYXA7CisgICAgaXZy c19tYXBwaW5nc1tiZGZdLnVuaXR5X21hcCA9IHVuaXR5X21hcDsKKworICAg IHJldHVybiAwOwogfQogCiBzdGF0aWMgaW50IF9faW5pdCByZWdpc3Rlcl9l eGNsdXNpb25fcmFuZ2VfZm9yX2FsbF9kZXZpY2VzKApAQCAtMTk0LDEzICsy MTAsMTMgQEAgc3RhdGljIGludCBfX2luaXQgcmVnaXN0ZXJfZXhjbHVzaW9u X3JhbgogICAgICAgICBsZW5ndGggPSByYW5nZV90b3AgLSBiYXNlOwogICAg ICAgICAvKiByZXNlcnZlIHIvdyB1bml0eS1tYXBwZWQgcGFnZSBlbnRyaWVz IGZvciBkZXZpY2VzICovCiAgICAgICAgIC8qIG5vdGU6IHRoZXNlIGVudHJp ZXMgYXJlIHBhcnQgb2YgdGhlIGV4Y2x1c2lvbiByYW5nZSAqLwotICAgICAg ICBmb3IgKCBiZGYgPSAwOyBiZGYgPCBpdnJzX2JkZl9lbnRyaWVzOyBiZGYr KyApCi0gICAgICAgICAgICByZXNlcnZlX3VuaXR5X21hcF9mb3JfZGV2aWNl KHNlZywgYmRmLCBiYXNlLCBsZW5ndGgsIGl3LCBpcik7CisgICAgICAgIGZv ciAoIGJkZiA9IDA7ICFyYyAmJiBiZGYgPCBpdnJzX2JkZl9lbnRyaWVzOyBi ZGYrKyApCisgICAgICAgICAgICByYyA9IHJlc2VydmVfdW5pdHlfbWFwX2Zv cl9kZXZpY2Uoc2VnLCBiZGYsIGJhc2UsIGxlbmd0aCwgaXcsIGlyKTsKICAg ICAgICAgLyogcHVzaCAnYmFzZScganVzdCBvdXRzaWRlIG9mIHZpcnR1YWwg YWRkcmVzcyBzcGFjZSAqLwogICAgICAgICBiYXNlID0gaW9tbXVfdG9wOwog ICAgIH0KICAgICAvKiByZWdpc3RlciBJT01NVSBleGNsdXNpb24gcmFuZ2Ug c2V0dGluZ3MgKi8KLSAgICBpZiAoIGxpbWl0ID49IGlvbW11X3RvcCApCisg ICAgaWYgKCAhcmMgJiYgbGltaXQgPj0gaW9tbXVfdG9wICkKICAgICB7CiAg ICAgICAgIGZvcl9lYWNoX2FtZF9pb21tdSggaW9tbXUgKQogICAgICAgICB7 CkBAIC0yNDIsMTUgKzI1OCwxNSBAQCBzdGF0aWMgaW50IF9faW5pdCByZWdp c3Rlcl9leGNsdXNpb25fcmFuCiAgICAgICAgIGxlbmd0aCA9IHJhbmdlX3Rv cCAtIGJhc2U7CiAgICAgICAgIC8qIHJlc2VydmUgdW5pdHktbWFwcGVkIHBh Z2UgZW50cmllcyBmb3IgZGV2aWNlICovCiAgICAgICAgIC8qIG5vdGU6IHRo ZXNlIGVudHJpZXMgYXJlIHBhcnQgb2YgdGhlIGV4Y2x1c2lvbiByYW5nZSAq LwotICAgICAgICByZXNlcnZlX3VuaXR5X21hcF9mb3JfZGV2aWNlKHNlZywg YmRmLCBiYXNlLCBsZW5ndGgsIGl3LCBpcik7Ci0gICAgICAgIHJlc2VydmVf dW5pdHlfbWFwX2Zvcl9kZXZpY2Uoc2VnLCByZXEsIGJhc2UsIGxlbmd0aCwg aXcsIGlyKTsKKyAgICAgICAgcmMgPSByZXNlcnZlX3VuaXR5X21hcF9mb3Jf ZGV2aWNlKHNlZywgYmRmLCBiYXNlLCBsZW5ndGgsIGl3LCBpcikgPzoKKyAg ICAgICAgICAgICByZXNlcnZlX3VuaXR5X21hcF9mb3JfZGV2aWNlKHNlZywg cmVxLCBiYXNlLCBsZW5ndGgsIGl3LCBpcik7CiAKICAgICAgICAgLyogcHVz aCAnYmFzZScganVzdCBvdXRzaWRlIG9mIHZpcnR1YWwgYWRkcmVzcyBzcGFj ZSAqLwogICAgICAgICBiYXNlID0gaW9tbXVfdG9wOwogICAgIH0KIAogICAg IC8qIHJlZ2lzdGVyIElPTU1VIGV4Y2x1c2lvbiByYW5nZSBzZXR0aW5ncyBm b3IgZGV2aWNlICovCi0gICAgaWYgKCBsaW1pdCA+PSBpb21tdV90b3AgICkK KyAgICBpZiAoICFyYyAmJiBsaW1pdCA+PSBpb21tdV90b3AgICkKICAgICB7 CiAgICAgICAgIHJjID0gcmVzZXJ2ZV9pb21tdV9leGNsdXNpb25fcmFuZ2Uo aW9tbXUsIGJhc2UsIGxpbWl0LAogICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIGZhbHNlIC8qIGFsbCAqLywgaXcsIGlyKTsK QEAgLTI4MSwxNSArMjk3LDE1IEBAIHN0YXRpYyBpbnQgX19pbml0IHJlZ2lz dGVyX2V4Y2x1c2lvbl9yYW4KICAgICAgICAgbGVuZ3RoID0gcmFuZ2VfdG9w IC0gYmFzZTsKICAgICAgICAgLyogcmVzZXJ2ZSByL3cgdW5pdHktbWFwcGVk IHBhZ2UgZW50cmllcyBmb3IgZGV2aWNlcyAqLwogICAgICAgICAvKiBub3Rl OiB0aGVzZSBlbnRyaWVzIGFyZSBwYXJ0IG9mIHRoZSBleGNsdXNpb24gcmFu Z2UgKi8KLSAgICAgICAgZm9yICggYmRmID0gMDsgYmRmIDwgaXZyc19iZGZf ZW50cmllczsgYmRmKysgKQorICAgICAgICBmb3IgKCBiZGYgPSAwOyAhcmMg JiYgYmRmIDwgaXZyc19iZGZfZW50cmllczsgYmRmKysgKQogICAgICAgICB7 CiAgICAgICAgICAgICBpZiAoIGlvbW11ID09IGZpbmRfaW9tbXVfZm9yX2Rl dmljZShpb21tdS0+c2VnLCBiZGYpICkKICAgICAgICAgICAgIHsKLSAgICAg ICAgICAgICAgICByZXNlcnZlX3VuaXR5X21hcF9mb3JfZGV2aWNlKGlvbW11 LT5zZWcsIGJkZiwgYmFzZSwgbGVuZ3RoLAotICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgaXcsIGlyKTsKICAgICAgICAg ICAgICAgICByZXEgPSBnZXRfaXZyc19tYXBwaW5ncyhpb21tdS0+c2VnKVti ZGZdLmR0ZV9yZXF1ZXN0b3JfaWQ7Ci0gICAgICAgICAgICAgICAgcmVzZXJ2 ZV91bml0eV9tYXBfZm9yX2RldmljZShpb21tdS0+c2VnLCByZXEsIGJhc2Us IGxlbmd0aCwKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIGl3LCBpcik7CisgICAgICAgICAgICAgICAgcmMgPSByZXNl cnZlX3VuaXR5X21hcF9mb3JfZGV2aWNlKGlvbW11LT5zZWcsIGJkZiwgYmFz ZSwgbGVuZ3RoLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBpdywgaXIpID86CisgICAgICAgICAgICAgICAg ICAgICByZXNlcnZlX3VuaXR5X21hcF9mb3JfZGV2aWNlKGlvbW11LT5zZWcs IHJlcSwgYmFzZSwgbGVuZ3RoLAorICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBpdywgaXIpOwogICAgICAgICAg ICAgfQogICAgICAgICB9CiAKQEAgLTI5OCw3ICszMTQsNyBAQCBzdGF0aWMg aW50IF9faW5pdCByZWdpc3Rlcl9leGNsdXNpb25fcmFuCiAgICAgfQogCiAg ICAgLyogcmVnaXN0ZXIgSU9NTVUgZXhjbHVzaW9uIHJhbmdlIHNldHRpbmdz ICovCi0gICAgaWYgKCBsaW1pdCA+PSBpb21tdV90b3AgKQorICAgIGlmICgg IXJjICYmIGxpbWl0ID49IGlvbW11X3RvcCApCiAgICAgICAgIHJjID0gcmVz ZXJ2ZV9pb21tdV9leGNsdXNpb25fcmFuZ2UoaW9tbXUsIGJhc2UsIGxpbWl0 LAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IHRydWUgLyogYWxsICovLCBpdywgaXIpOwogCi0tLSBhL3hlbi9kcml2ZXJz L3Bhc3N0aHJvdWdoL2FtZC9wY2lfYW1kX2lvbW11LmMKKysrIGIveGVuL2Ry aXZlcnMvcGFzc3Rocm91Z2gvYW1kL3BjaV9hbWRfaW9tbXUuYwpAQCAtMzY5 LDE1ICszNjksMTcgQEAgc3RhdGljIGludCBhbWRfaW9tbXVfYXNzaWduX2Rl dmljZShzdHJ1YwogICAgIHN0cnVjdCBpdnJzX21hcHBpbmdzICppdnJzX21h cHBpbmdzID0gZ2V0X2l2cnNfbWFwcGluZ3MocGRldi0+c2VnKTsKICAgICBp bnQgYmRmID0gUENJX0JERjIocGRldi0+YnVzLCBkZXZmbik7CiAgICAgaW50 IHJlcV9pZCA9IGdldF9kbWFfcmVxdWVzdG9yX2lkKHBkZXYtPnNlZywgYmRm KTsKKyAgICBjb25zdCBzdHJ1Y3QgaXZyc191bml0eV9tYXAgKnVuaXR5X21h cDsKIAotICAgIGlmICggaXZyc19tYXBwaW5nc1tyZXFfaWRdLnVuaXR5X21h cF9lbmFibGUgKQorICAgIGZvciAoIHVuaXR5X21hcCA9IGl2cnNfbWFwcGlu Z3NbcmVxX2lkXS51bml0eV9tYXA7IHVuaXR5X21hcDsKKyAgICAgICAgICB1 bml0eV9tYXAgPSB1bml0eV9tYXAtPm5leHQgKQogICAgIHsKLSAgICAgICAg YW1kX2lvbW11X3Jlc2VydmVfZG9tYWluX3VuaXR5X21hcCgKLSAgICAgICAg ICAgIGQsCi0gICAgICAgICAgICBpdnJzX21hcHBpbmdzW3JlcV9pZF0uYWRk cl9yYW5nZV9zdGFydCwKLSAgICAgICAgICAgIGl2cnNfbWFwcGluZ3NbcmVx X2lkXS5hZGRyX3JhbmdlX2xlbmd0aCwKLSAgICAgICAgICAgIGl2cnNfbWFw cGluZ3NbcmVxX2lkXS53cml0ZV9wZXJtaXNzaW9uLAotICAgICAgICAgICAg aXZyc19tYXBwaW5nc1tyZXFfaWRdLnJlYWRfcGVybWlzc2lvbik7CisgICAg ICAgIGludCByYyA9IGFtZF9pb21tdV9yZXNlcnZlX2RvbWFpbl91bml0eV9t YXAoCisgICAgICAgICAgICAgICAgICAgICBkLCB1bml0eV9tYXAtPmFkZHIs IHVuaXR5X21hcC0+bGVuZ3RoLAorICAgICAgICAgICAgICAgICAgICAgdW5p dHlfbWFwLT53cml0ZSwgdW5pdHlfbWFwLT5yZWFkKTsKKworICAgICAgICBp ZiAoIHJjICkKKyAgICAgICAgICAgIHJldHVybiByYzsKICAgICB9CiAKICAg ICByZXR1cm4gcmVhc3NpZ25fZGV2aWNlKHBkZXYtPmRvbWFpbiwgZCwgZGV2 Zm4sIHBkZXYpOwotLS0gYS94ZW4vaW5jbHVkZS9hc20teDg2L2FtZC1pb21t dS5oCisrKyBiL3hlbi9pbmNsdWRlL2FzbS14ODYvYW1kLWlvbW11LmgKQEAg LTEwNSwyMCArMTA1LDI0IEBAIHN0cnVjdCBhbWRfaW9tbXUgewogICAgIHN0 cnVjdCBsaXN0X2hlYWQgYXRzX2RldmljZXM7CiB9OwogCitzdHJ1Y3QgaXZy c191bml0eV9tYXAgeworICAgIGJvb2wgcmVhZDoxOworICAgIGJvb2wgd3Jp dGU6MTsKKyAgICBwYWRkcl90IGFkZHI7CisgICAgdW5zaWduZWQgbG9uZyBs ZW5ndGg7CisgICAgc3RydWN0IGl2cnNfdW5pdHlfbWFwICpuZXh0OworfTsK Kwogc3RydWN0IGl2cnNfbWFwcGluZ3MgewogICAgIHVpbnQxNl90IGR0ZV9y ZXF1ZXN0b3JfaWQ7CiAgICAgYm9vbCB2YWxpZDoxOwogICAgIGJvb2wgZHRl X2FsbG93X2V4Y2x1c2lvbjoxOwotICAgIGJvb2wgdW5pdHlfbWFwX2VuYWJs ZToxOwotICAgIGJvb2wgd3JpdGVfcGVybWlzc2lvbjoxOwotICAgIGJvb2wg cmVhZF9wZXJtaXNzaW9uOjE7CiAKICAgICAvKiBpdmhkIGRldmljZSBkYXRh IHNldHRpbmdzICovCiAgICAgdWludDhfdCBkZXZpY2VfZmxhZ3M7CiAKLSAg ICB1bnNpZ25lZCBsb25nIGFkZHJfcmFuZ2Vfc3RhcnQ7Ci0gICAgdW5zaWdu ZWQgbG9uZyBhZGRyX3JhbmdlX2xlbmd0aDsKICAgICBzdHJ1Y3QgYW1kX2lv bW11ICppb21tdTsKKyAgICBzdHJ1Y3QgaXZyc191bml0eV9tYXAgKnVuaXR5 X21hcDsKIAogICAgIC8qIHBlciBkZXZpY2UgaW50ZXJydXB0IHJlbWFwcGlu ZyB0YWJsZSAqLwogICAgIHZvaWQgKmludHJlbWFwX3RhYmxlOwo= --=separator Content-Type: application/octet-stream; name="xsa378/xsa378-4.13-3.patch" Content-Disposition: attachment; filename="xsa378/xsa378-4.13-3.patch" Content-Transfer-Encoding: base64 RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0 OiBJT01NVTogYWxzbyBwYXNzIHAybV9hY2Nlc3NfdCB0byBwMm1fZ2V0X2lv bW11X2ZsYWdzKCkKCkEgc3Vic2VxdWVudCBjaGFuZ2Ugd2lsbCB3YW50IHRv IGN1c3RvbWl6ZSB0aGUgSU9NTVUgcGVybWlzc2lvbnMgYmFzZWQKb24gdGhp cy4KClRoaXMgaXMgcGFydCBvZiBYU0EtMzc4LgoKU2lnbmVkLW9mZi1ieTog SmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpSZXZpZXdlZC1ieTog UGF1bCBEdXJyYW50IDxwYXVsQHhlbi5vcmc+CgotLS0gYS94ZW4vYXJjaC94 ODYvbW0vcDJtLWVwdC5jCisrKyBiL3hlbi9hcmNoL3g4Ni9tbS9wMm0tZXB0 LmMKQEAgLTY3OCw3ICs2NzgsNyBAQCBlcHRfc2V0X2VudHJ5KHN0cnVjdCBw Mm1fZG9tYWluICpwMm0sIGdmCiAgICAgdWludDhfdCBpcGF0ID0gMDsKICAg ICBib29sX3QgbmVlZF9tb2RpZnlfdnRkX3RhYmxlID0gMTsKICAgICBib29s X3QgdnRkX3B0ZV9wcmVzZW50ID0gMDsKLSAgICB1bnNpZ25lZCBpbnQgaW9t bXVfZmxhZ3MgPSBwMm1fZ2V0X2lvbW11X2ZsYWdzKHAybXQsIG1mbik7Cisg ICAgdW5zaWduZWQgaW50IGlvbW11X2ZsYWdzID0gcDJtX2dldF9pb21tdV9m bGFncyhwMm10LCBwMm1hLCBtZm4pOwogICAgIGJvb2xfdCBuZWVkc19zeW5j ID0gMTsKICAgICBlcHRfZW50cnlfdCBvbGRfZW50cnkgPSB7IC5lcHRlID0g MCB9OwogICAgIGVwdF9lbnRyeV90IG5ld19lbnRyeSA9IHsgLmVwdGUgPSAw IH07CkBAIC04MDUsOCArODA1LDggQEAgZXB0X3NldF9lbnRyeShzdHJ1Y3Qg cDJtX2RvbWFpbiAqcDJtLCBnZgogCiAgICAgICAgIC8qIFNhZmUgdG8gcmVh ZC10aGVuLXdyaXRlIGJlY2F1c2Ugd2UgaG9sZCB0aGUgcDJtIGxvY2sgKi8K ICAgICAgICAgaWYgKCBlcHRfZW50cnktPm1mbiA9PSBuZXdfZW50cnkubWZu ICYmCi0gICAgICAgICAgICAgcDJtX2dldF9pb21tdV9mbGFncyhlcHRfZW50 cnktPnNhX3AybXQsIF9tZm4oZXB0X2VudHJ5LT5tZm4pKSA9PQotICAgICAg ICAgICAgIGlvbW11X2ZsYWdzICkKKyAgICAgICAgICAgICBwMm1fZ2V0X2lv bW11X2ZsYWdzKGVwdF9lbnRyeS0+c2FfcDJtdCwgZXB0X2VudHJ5LT5hY2Nl c3MsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBfbWZuKGVw dF9lbnRyeS0+bWZuKSkgPT0gaW9tbXVfZmxhZ3MgKQogICAgICAgICAgICAg bmVlZF9tb2RpZnlfdnRkX3RhYmxlID0gMDsKIAogICAgICAgICBlcHRfcDJt X3R5cGVfdG9fZmxhZ3MocDJtLCAmbmV3X2VudHJ5LCBwMm10LCBwMm1hKTsK LS0tIGEveGVuL2FyY2gveDg2L21tL3AybS1wdC5jCisrKyBiL3hlbi9hcmNo L3g4Ni9tbS9wMm0tcHQuYwpAQCAtNDgwLDYgKzQ4MCwxNiBAQCBpbnQgcDJt X3B0X2hhbmRsZV9kZWZlcnJlZF9jaGFuZ2VzKHVpbnQ2CiAgICAgcmV0dXJu IHJjOwogfQogCisvKiBSZWNvbnN0cnVjdCBhIGZha2UgcDJtX2FjY2Vzc190 IGZyb20gc3RvcmVkIFBURSBmbGFncy4gKi8KK3N0YXRpYyBwMm1fYWNjZXNz X3QgcDJtX2ZsYWdzX3RvX2FjY2Vzcyh1bnNpZ25lZCBpbnQgZmxhZ3MpCit7 CisgICAgaWYgKCBmbGFncyAmIF9QQUdFX1BSRVNFTlQgKQorICAgICAgICBy ZXR1cm4gcDJtX2FjY2Vzc19uOworCisgICAgLyogTm8gbmVlZCB0byBsb29r IGF0IF9QQUdFX05YIGZvciBub3cuICovCisgICAgcmV0dXJuIGZsYWdzICYg X1BBR0VfUlcgPyBwMm1fYWNjZXNzX3J3IDogcDJtX2FjY2Vzc19yOworfQor CiAvKiBDaGVja3Mgb25seSBhcHBsaWNhYmxlIHRvIGVudHJpZXMgd2l0aCBv cmRlciA+IFBBR0VfT1JERVJfNEsgKi8KIHN0YXRpYyB2b2lkIGNoZWNrX2Vu dHJ5KG1mbl90IG1mbiwgcDJtX3R5cGVfdCBuZXcsIHAybV90eXBlX3Qgb2xk LAogICAgICAgICAgICAgICAgICAgICAgICAgdW5zaWduZWQgaW50IG9yZGVy KQpAQCAtNTE0LDcgKzUyNCw3IEBAIHAybV9wdF9zZXRfZW50cnkoc3RydWN0 IHAybV9kb21haW4gKnAybSwKICAgICBsMl9wZ2VudHJ5X3QgbDJlX2NvbnRl bnQ7CiAgICAgbDNfcGdlbnRyeV90IGwzZV9jb250ZW50OwogICAgIGludCBy YzsKLSAgICB1bnNpZ25lZCBpbnQgaW9tbXVfcHRlX2ZsYWdzID0gcDJtX2dl dF9pb21tdV9mbGFncyhwMm10LCBtZm4pOworICAgIHVuc2lnbmVkIGludCBp b21tdV9wdGVfZmxhZ3MgPSBwMm1fZ2V0X2lvbW11X2ZsYWdzKHAybXQsIHAy bWEsIG1mbik7CiAgICAgLyoKICAgICAgKiBvbGRfbWZuIGFuZCBpb21tdV9v bGRfZmxhZ3MgY29udHJvbCBwb3NzaWJsZSBmbHVzaC91cGRhdGUgbmVlZHMg b24gdGhlCiAgICAgICogSU9NTVU6IFdlIG5lZWQgdG8gZmx1c2ggd2hlbiBN Rk4gb3IgZmxhZ3MgKGkuZS4gcGVybWlzc2lvbnMpIGNoYW5nZS4KQEAgLTU3 Nyw2ICs1ODcsNyBAQCBwMm1fcHRfc2V0X2VudHJ5KHN0cnVjdCBwMm1fZG9t YWluICpwMm0sCiAgICAgICAgICAgICAgICAgb2xkX21mbiA9IGwxZV9nZXRf cGZuKCpwMm1fZW50cnkpOwogICAgICAgICAgICAgICAgIGlvbW11X29sZF9m bGFncyA9CiAgICAgICAgICAgICAgICAgICAgIHAybV9nZXRfaW9tbXVfZmxh Z3MocDJtX2ZsYWdzX3RvX3R5cGUoZmxhZ3MpLAorICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIHAybV9mbGFnc190b19hY2Nlc3Mo ZmxhZ3MpLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIF9tZm4ob2xkX21mbikpOwogICAgICAgICAgICAgfQogICAgICAgICAg ICAgZWxzZQpAQCAtNjE5LDkgKzYzMCwxMCBAQCBwMm1fcHRfc2V0X2VudHJ5 KHN0cnVjdCBwMm1fZG9tYWluICpwMm0sCiAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIDAsIEwxX1BBR0VUQUJMRV9FTlRSSUVTKTsKICAg ICAgICAgQVNTRVJUKHAybV9lbnRyeSk7CiAgICAgICAgIG9sZF9tZm4gPSBs MWVfZ2V0X3BmbigqcDJtX2VudHJ5KTsKKyAgICAgICAgZmxhZ3MgPSBsMWVf Z2V0X2ZsYWdzKCpwMm1fZW50cnkpOwogICAgICAgICBpb21tdV9vbGRfZmxh Z3MgPQotICAgICAgICAgICAgcDJtX2dldF9pb21tdV9mbGFncyhwMm1fZmxh Z3NfdG9fdHlwZShsMWVfZ2V0X2ZsYWdzKCpwMm1fZW50cnkpKSwKLSAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgX21mbihvbGRfbWZuKSk7Cisg ICAgICAgICAgICBwMm1fZ2V0X2lvbW11X2ZsYWdzKHAybV9mbGFnc190b190 eXBlKGZsYWdzKSwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg cDJtX2ZsYWdzX3RvX2FjY2VzcyhmbGFncyksIF9tZm4ob2xkX21mbikpOwog CiAgICAgICAgIGlmICggbWZuX3ZhbGlkKG1mbikgfHwgcDJtX2FsbG93c19p bnZhbGlkX21mbihwMm10KSApCiAgICAgICAgICAgICBlbnRyeV9jb250ZW50 ID0gcDJtX2wxZV9mcm9tX3BmbihtZm5feChtZm4pLApAQCAtNjQ5LDYgKzY2 MSw3IEBAIHAybV9wdF9zZXRfZW50cnkoc3RydWN0IHAybV9kb21haW4gKnAy bSwKICAgICAgICAgICAgICAgICBvbGRfbWZuID0gbDFlX2dldF9wZm4oKnAy bV9lbnRyeSk7CiAgICAgICAgICAgICAgICAgaW9tbXVfb2xkX2ZsYWdzID0K ICAgICAgICAgICAgICAgICAgICAgcDJtX2dldF9pb21tdV9mbGFncyhwMm1f ZmxhZ3NfdG9fdHlwZShmbGFncyksCisgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgcDJtX2ZsYWdzX3RvX2FjY2VzcyhmbGFncyks CiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgX21m bihvbGRfbWZuKSk7CiAgICAgICAgICAgICB9CiAgICAgICAgICAgICBlbHNl Ci0tLSBhL3hlbi9pbmNsdWRlL2FzbS14ODYvcDJtLmgKKysrIGIveGVuL2lu Y2x1ZGUvYXNtLXg4Ni9wMm0uaApAQCAtOTA4LDcgKzkwOCw4IEBAIHN0YXRp YyBpbmxpbmUgdm9pZCBwMm1fYWx0cDJtX2NoZWNrKHN0cnUKIC8qCiAgKiBw Mm0gdHlwZSB0byBJT01NVSBmbGFncwogICovCi1zdGF0aWMgaW5saW5lIHVu c2lnbmVkIGludCBwMm1fZ2V0X2lvbW11X2ZsYWdzKHAybV90eXBlX3QgcDJt dCwgbWZuX3QgbWZuKQorc3RhdGljIGlubGluZSB1bnNpZ25lZCBpbnQgcDJt X2dldF9pb21tdV9mbGFncyhwMm1fdHlwZV90IHAybXQsCisgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHAybV9hY2Nl c3NfdCBwMm1hLCBtZm5fdCBtZm4pCiB7CiAgICAgdW5zaWduZWQgaW50IGZs YWdzOwogCg== --=separator Content-Type: application/octet-stream; name="xsa378/xsa378-4.13-4.patch" Content-Disposition: attachment; filename="xsa378/xsa378-4.13-4.patch" Content-Transfer-Encoding: base64 RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0 OiBJT01NVTogZ2VuZXJhbGl6ZSBWVC1kJ3MgdHJhY2tpbmcgb2YgbWFwcGVk IFJNUlIgcmVnaW9ucwoKSW4gb3JkZXIgdG8gcmUtdXNlIGl0IGVsc2V3aGVy ZSwgbW92ZSB0aGUgbG9naWMgdG8gdmVuZG9yIGluZGVwZW5kZW50CmNvZGUg YW5kIHN0cmlwIGl0IG9mIFJNUlIgc3BlY2lmaWNzLgoKTm90ZSB0aGF0IHRo ZSBwcmlvciAibWFwIiBwYXJhbWV0ZXIgZ2V0cyBmb2xkZWQgaW50byB0aGUg bmV3ICJwMm1hIiBvbmUKKHdoaWNoIEFNRCBJT01NVSBjb2RlIHdpbGwgd2Fu dCB0byBtYWtlIHVzZSBvZiksIGFzc2lnbmluZyBhbHRlcm5hdGl2ZQptZWFu aW5nICgidW5tYXAiKSB0byBwMm1fYWNjZXNzX3guIFByZXBhcmUgc2V0X2lk ZW50aXR5X3AybV9lbnRyeSgpIGFuZApwMm1fZ2V0X2lvbW11X2ZsYWdzKCkg Zm9yIGdldHRpbmcgcGFzc2VkIGFjY2VzcyB0eXBlcyBvdGhlciB0aGFuCnAy bV9hY2Nlc3NfcncgKGluIHRoZSBsYXR0ZXIgY2FzZSBqdXN0IGZvciBwMm1f bW1pb19kaXJlY3QgcmVxdWVzdHMpLgoKTm90ZSBhbHNvIHRoYXQsIHRvIGJl IG9uIHRoZSBzYWZlIHNpZGUsIGFuIG92ZXJsYXAgY2hlY2sgZ2V0cyBhZGRl ZCB0bwp0aGUgbWFpbiBsb29wIG9mIGlvbW11X2lkZW50aXR5X21hcHBpbmco KS4KClRoaXMgaXMgcGFydCBvZiBYU0EtMzc4LgoKU2lnbmVkLW9mZi1ieTog SmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpSZXZpZXdlZC1ieTog UGF1bCBEdXJyYW50IDxwYXVsQHhlbi5vcmc+CgotLS0gYS94ZW4vYXJjaC94 ODYvbW0vcDJtLmMKKysrIGIveGVuL2FyY2gveDg2L21tL3AybS5jCkBAIC0x MzUxLDcgKzEzNTEsNyBAQCBpbnQgc2V0X2lkZW50aXR5X3AybV9lbnRyeShz dHJ1Y3QgZG9tYWluCiAgICAgICAgIGlmICggIWlzX2lvbW11X2VuYWJsZWQo ZCkgKQogICAgICAgICAgICAgcmV0dXJuIDA7CiAgICAgICAgIHJldHVybiBp b21tdV9sZWdhY3lfbWFwKGQsIF9kZm4oZ2ZuX2wpLCBfbWZuKGdmbl9sKSwg UEFHRV9PUkRFUl80SywKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgSU9NTVVGX3JlYWRhYmxlIHwgSU9NTVVGX3dyaXRhYmxlKTsKKyAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgcDJtX2FjY2Vzc190b19pb21t dV9mbGFncyhwMm1hKSk7CiAgICAgfQogCiAgICAgZ2ZuX2xvY2socDJtLCBn Zm4sIDApOwotLS0gYS94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC92dGQvaW9t bXUuYworKysgYi94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC92dGQvaW9tbXUu YwpAQCAtNDIsMTIgKzQyLDYgQEAKICNpbmNsdWRlICJ2dGQuaCIKICNpbmNs dWRlICIuLi9hdHMuaCIKIAotc3RydWN0IG1hcHBlZF9ybXJyIHsKLSAgICBz dHJ1Y3QgbGlzdF9oZWFkIGxpc3Q7Ci0gICAgdTY0IGJhc2UsIGVuZDsKLSAg ICB1bnNpZ25lZCBpbnQgY291bnQ7Ci19OwotCiAvKiBQb3NzaWJsZSB1bmZp bHRlcmVkIExBUElDL01TSSBtZXNzYWdlcyBmcm9tIHVudHJ1c3RlZCBzb3Vy Y2VzPyAqLwogYm9vbCBfX3JlYWRfbW9zdGx5IHVudHJ1c3RlZF9tc2k7CiAK QEAgLTE3OTksMTcgKzE3OTMsMTIgQEAgb3V0Ogogc3RhdGljIHZvaWQgaW9t bXVfZG9tYWluX3RlYXJkb3duKHN0cnVjdCBkb21haW4gKmQpCiB7CiAgICAg c3RydWN0IGRvbWFpbl9pb21tdSAqaGQgPSBkb21faW9tbXUoZCk7Ci0gICAg c3RydWN0IG1hcHBlZF9ybXJyICptcm1yciwgKnRtcDsKICAgICBjb25zdCBz dHJ1Y3QgYWNwaV9kcmhkX3VuaXQgKmRyaGQ7CiAKICAgICBpZiAoIGxpc3Rf ZW1wdHkoJmFjcGlfZHJoZF91bml0cykgKQogICAgICAgICByZXR1cm47CiAK LSAgICBsaXN0X2Zvcl9lYWNoX2VudHJ5X3NhZmUgKCBtcm1yciwgdG1wLCAm aGQtPmFyY2gubWFwcGVkX3JtcnJzLCBsaXN0ICkKLSAgICB7Ci0gICAgICAg IGxpc3RfZGVsKCZtcm1yci0+bGlzdCk7Ci0gICAgICAgIHhmcmVlKG1ybXJy KTsKLSAgICB9CisgICAgaW9tbXVfaWRlbnRpdHlfbWFwX3RlYXJkb3duKGQp OwogCiAgICAgQVNTRVJUKGlzX2lvbW11X2VuYWJsZWQoZCkpOwogCkBAIC0x OTYzLDc0ICsxOTUyLDYgQEAgc3RhdGljIHZvaWQgaW9tbXVfc2V0X3BnZChz dHJ1Y3QgZG9tYWluCiAgICAgICAgIHBhZ2V0YWJsZV9nZXRfcGFkZHIocGFn ZXRhYmxlX2Zyb21fbWZuKHBnZF9tZm4pKTsKIH0KIAotc3RhdGljIGludCBy bXJyX2lkZW50aXR5X21hcHBpbmcoc3RydWN0IGRvbWFpbiAqZCwgYm9vbF90 IG1hcCwKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNvbnN0 IHN0cnVjdCBhY3BpX3JtcnJfdW5pdCAqcm1yciwKLSAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIHUzMiBmbGFnKQotewotICAgIHVuc2lnbmVk IGxvbmcgYmFzZV9wZm4gPSBybXJyLT5iYXNlX2FkZHJlc3MgPj4gUEFHRV9T SElGVF80SzsKLSAgICB1bnNpZ25lZCBsb25nIGVuZF9wZm4gPSBQQUdFX0FM SUdOXzRLKHJtcnItPmVuZF9hZGRyZXNzKSA+PiBQQUdFX1NISUZUXzRLOwot ICAgIHN0cnVjdCBtYXBwZWRfcm1yciAqbXJtcnI7Ci0gICAgc3RydWN0IGRv bWFpbl9pb21tdSAqaGQgPSBkb21faW9tbXUoZCk7Ci0KLSAgICBBU1NFUlQo cGNpZGV2c19sb2NrZWQoKSk7Ci0gICAgQVNTRVJUKHJtcnItPmJhc2VfYWRk cmVzcyA8IHJtcnItPmVuZF9hZGRyZXNzKTsKLQotICAgIC8qCi0gICAgICog Tm8gbmVlZCB0byBhY3F1aXJlIGhkLT5hcmNoLm1hcHBpbmdfbG9jazogQm90 aCBpbnNlcnRpb24gYW5kIHJlbW92YWwKLSAgICAgKiBnZXQgZG9uZSB3aGls ZSBob2xkaW5nIHBjaWRldnNfbG9jay4KLSAgICAgKi8KLSAgICBsaXN0X2Zv cl9lYWNoX2VudHJ5KCBtcm1yciwgJmhkLT5hcmNoLm1hcHBlZF9ybXJycywg bGlzdCApCi0gICAgewotICAgICAgICBpZiAoIG1ybXJyLT5iYXNlID09IHJt cnItPmJhc2VfYWRkcmVzcyAmJgotICAgICAgICAgICAgIG1ybXJyLT5lbmQg PT0gcm1yci0+ZW5kX2FkZHJlc3MgKQotICAgICAgICB7Ci0gICAgICAgICAg ICBpbnQgcmV0ID0gMDsKLQotICAgICAgICAgICAgaWYgKCBtYXAgKQotICAg ICAgICAgICAgewotICAgICAgICAgICAgICAgICsrbXJtcnItPmNvdW50Owot ICAgICAgICAgICAgICAgIHJldHVybiAwOwotICAgICAgICAgICAgfQotCi0g ICAgICAgICAgICBpZiAoIC0tbXJtcnItPmNvdW50ICkKLSAgICAgICAgICAg ICAgICByZXR1cm4gMDsKLQotICAgICAgICAgICAgd2hpbGUgKCBiYXNlX3Bm biA8IGVuZF9wZm4gKQotICAgICAgICAgICAgewotICAgICAgICAgICAgICAg IGlmICggY2xlYXJfaWRlbnRpdHlfcDJtX2VudHJ5KGQsIGJhc2VfcGZuKSAp Ci0gICAgICAgICAgICAgICAgICAgIHJldCA9IC1FTlhJTzsKLSAgICAgICAg ICAgICAgICBiYXNlX3BmbisrOwotICAgICAgICAgICAgfQotCi0gICAgICAg ICAgICBsaXN0X2RlbCgmbXJtcnItPmxpc3QpOwotICAgICAgICAgICAgeGZy ZWUobXJtcnIpOwotICAgICAgICAgICAgcmV0dXJuIHJldDsKLSAgICAgICAg fQotICAgIH0KLQotICAgIGlmICggIW1hcCApCi0gICAgICAgIHJldHVybiAt RU5PRU5UOwotCi0gICAgd2hpbGUgKCBiYXNlX3BmbiA8IGVuZF9wZm4gKQot ICAgIHsKLSAgICAgICAgaW50IGVyciA9IHNldF9pZGVudGl0eV9wMm1fZW50 cnkoZCwgYmFzZV9wZm4sIHAybV9hY2Nlc3NfcncsIGZsYWcpOwotCi0gICAg ICAgIGlmICggZXJyICkKLSAgICAgICAgICAgIHJldHVybiBlcnI7Ci0gICAg ICAgIGJhc2VfcGZuKys7Ci0gICAgfQotCi0gICAgbXJtcnIgPSB4bWFsbG9j KHN0cnVjdCBtYXBwZWRfcm1ycik7Ci0gICAgaWYgKCAhbXJtcnIgKQotICAg ICAgICByZXR1cm4gLUVOT01FTTsKLSAgICBtcm1yci0+YmFzZSA9IHJtcnIt PmJhc2VfYWRkcmVzczsKLSAgICBtcm1yci0+ZW5kID0gcm1yci0+ZW5kX2Fk ZHJlc3M7Ci0gICAgbXJtcnItPmNvdW50ID0gMTsKLSAgICBsaXN0X2FkZF90 YWlsKCZtcm1yci0+bGlzdCwgJmhkLT5hcmNoLm1hcHBlZF9ybXJycyk7Ci0K LSAgICByZXR1cm4gMDsKLX0KLQogc3RhdGljIGludCBpbnRlbF9pb21tdV9h ZGRfZGV2aWNlKHU4IGRldmZuLCBzdHJ1Y3QgcGNpX2RldiAqcGRldikKIHsK ICAgICBzdHJ1Y3QgYWNwaV9ybXJyX3VuaXQgKnJtcnI7CkBAIC0yMDYyLDcg KzE5ODMsOSBAQCBzdGF0aWMgaW50IGludGVsX2lvbW11X2FkZF9kZXZpY2Uo dTggZGV2CiAgICAgICAgICAgICAgKiBTaW5jZSBSTVJScyBhcmUgYWx3YXlz IHJlc2VydmVkIGluIHRoZSBlODIwIG1hcCBmb3IgdGhlIGhhcmR3YXJlCiAg ICAgICAgICAgICAgKiBkb21haW4sIHRoZXJlIHNob3VsZG4ndCBiZSBhIGNv bmZsaWN0LgogICAgICAgICAgICAgICovCi0gICAgICAgICAgICByZXQgPSBy bXJyX2lkZW50aXR5X21hcHBpbmcocGRldi0+ZG9tYWluLCAxLCBybXJyLCAw KTsKKyAgICAgICAgICAgIHJldCA9IGlvbW11X2lkZW50aXR5X21hcHBpbmco cGRldi0+ZG9tYWluLCBwMm1fYWNjZXNzX3J3LAorICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBybXJyLT5iYXNlX2FkZHJlc3Ms IHJtcnItPmVuZF9hZGRyZXNzLAorICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAwKTsKICAgICAgICAgICAgIGlmICggcmV0ICkK ICAgICAgICAgICAgICAgICBkcHJpbnRrKFhFTkxPR19FUlIgVlREUFJFRklY LCAiZCVkOiBSTVJSIG1hcHBpbmcgZmFpbGVkXG4iLAogICAgICAgICAgICAg ICAgICAgICAgICAgcGRldi0+ZG9tYWluLT5kb21haW5faWQpOwpAQCAtMjEw Nyw3ICsyMDMwLDggQEAgc3RhdGljIGludCBpbnRlbF9pb21tdV9yZW1vdmVf ZGV2aWNlKHU4CiAgICAgICAgICAqIEFueSBmbGFnIGlzIG5vdGhpbmcgdG8g Y2xlYXIgdGhlc2UgbWFwcGluZ3MgYnV0IGhlcmUKICAgICAgICAgICogaXRz IGFsd2F5cyBzYWZlIGFuZCBzdHJpY3QgdG8gc2V0IDAuCiAgICAgICAgICAq LwotICAgICAgICBybXJyX2lkZW50aXR5X21hcHBpbmcocGRldi0+ZG9tYWlu LCAwLCBybXJyLCAwKTsKKyAgICAgICAgaW9tbXVfaWRlbnRpdHlfbWFwcGlu ZyhwZGV2LT5kb21haW4sIHAybV9hY2Nlc3NfeCwgcm1yci0+YmFzZV9hZGRy ZXNzLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHJtcnItPmVu ZF9hZGRyZXNzLCAwKTsKICAgICB9CiAKICAgICByZXR1cm4gZG9tYWluX2Nv bnRleHRfdW5tYXAocGRldi0+ZG9tYWluLCBkZXZmbiwgcGRldik7CkBAIC0y MzA2LDcgKzIyMzAsOCBAQCBzdGF0aWMgdm9pZCBfX2h3ZG9tX2luaXQgc2V0 dXBfaHdkb21fcm1yCiAgICAgICAgICAqIGRvbWFpbiwgdGhlcmUgc2hvdWxk bid0IGJlIGEgY29uZmxpY3QuIFNvIGl0cyBhbHdheXMgc2FmZSBhbmQKICAg ICAgICAgICogc3RyaWN0IHRvIHNldCAwLgogICAgICAgICAgKi8KLSAgICAg ICAgcmV0ID0gcm1ycl9pZGVudGl0eV9tYXBwaW5nKGQsIDEsIHJtcnIsIDAp OworICAgICAgICByZXQgPSBpb21tdV9pZGVudGl0eV9tYXBwaW5nKGQsIHAy bV9hY2Nlc3NfcncsIHJtcnItPmJhc2VfYWRkcmVzcywKKyAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBybXJyLT5lbmRfYWRkcmVzcywg MCk7CiAgICAgICAgIGlmICggcmV0ICkKICAgICAgICAgICAgIGRwcmludGso WEVOTE9HX0VSUiBWVERQUkVGSVgsCiAgICAgICAgICAgICAgICAgICAgICAi SU9NTVU6IG1hcHBpbmcgcmVzZXJ2ZWQgcmVnaW9uIGZhaWxlZFxuIik7CkBA IC0yNDY1LDcgKzIzOTAsOSBAQCBzdGF0aWMgaW50IHJlYXNzaWduX2Rldmlj ZV9vd25lcnNoaXAoCiAgICAgICAgICAgICAgICAgICogQW55IFJNUlIgZmxh ZyBpcyBhbHdheXMgaWdub3JlZCB3aGVuIHJlbW92ZSBhIGRldmljZSwKICAg ICAgICAgICAgICAgICAgKiBidXQgaXRzIGFsd2F5cyBzYWZlIGFuZCBzdHJp Y3QgdG8gc2V0IDAuCiAgICAgICAgICAgICAgICAgICovCi0gICAgICAgICAg ICAgICAgcmV0ID0gcm1ycl9pZGVudGl0eV9tYXBwaW5nKHNvdXJjZSwgMCwg cm1yciwgMCk7CisgICAgICAgICAgICAgICAgcmV0ID0gaW9tbXVfaWRlbnRp dHlfbWFwcGluZyhzb3VyY2UsIHAybV9hY2Nlc3NfeCwKKyAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHJtcnItPmJhc2Vf YWRkcmVzcywKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIHJtcnItPmVuZF9hZGRyZXNzLCAwKTsKICAgICAgICAgICAg ICAgICBpZiAoIHJldCAhPSAtRU5PRU5UICkKICAgICAgICAgICAgICAgICAg ICAgcmV0dXJuIHJldDsKICAgICAgICAgICAgIH0KQEAgLTI1NjIsNyArMjQ4 OSw4IEBAIHN0YXRpYyBpbnQgaW50ZWxfaW9tbXVfYXNzaWduX2RldmljZSgK ICAgICAgICAgICAgICBQQ0lfQlVTKGJkZikgPT0gYnVzICYmCiAgICAgICAg ICAgICAgUENJX0RFVkZOMihiZGYpID09IGRldmZuICkKICAgICAgICAgewot ICAgICAgICAgICAgcmV0ID0gcm1ycl9pZGVudGl0eV9tYXBwaW5nKGQsIDEs IHJtcnIsIGZsYWcpOworICAgICAgICAgICAgcmV0ID0gaW9tbXVfaWRlbnRp dHlfbWFwcGluZyhkLCBwMm1fYWNjZXNzX3J3LCBybXJyLT5iYXNlX2FkZHJl c3MsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IHJtcnItPmVuZF9hZGRyZXNzLCBmbGFnKTsKICAgICAgICAgICAgIGlmICgg cmV0ICkKICAgICAgICAgICAgIHsKICAgICAgICAgICAgICAgICBpbnQgcmM7 Ci0tLSBhL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL3g4Ni9pb21tdS5jCisr KyBiL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL3g4Ni9pb21tdS5jCkBAIC0x MjcsNyArMTI3LDcgQEAgaW50IGFyY2hfaW9tbXVfZG9tYWluX2luaXQoc3Ry dWN0IGRvbWFpbgogICAgIHN0cnVjdCBkb21haW5faW9tbXUgKmhkID0gZG9t X2lvbW11KGQpOwogCiAgICAgc3Bpbl9sb2NrX2luaXQoJmhkLT5hcmNoLm1h cHBpbmdfbG9jayk7Ci0gICAgSU5JVF9MSVNUX0hFQUQoJmhkLT5hcmNoLm1h cHBlZF9ybXJycyk7CisgICAgSU5JVF9MSVNUX0hFQUQoJmhkLT5hcmNoLmlk ZW50aXR5X21hcHMpOwogCiAgICAgcmV0dXJuIDA7CiB9CkBAIC0xMzYsNiAr MTM2LDk5IEBAIHZvaWQgYXJjaF9pb21tdV9kb21haW5fZGVzdHJveShzdHJ1 Y3QgZG8KIHsKIH0KIAorc3RydWN0IGlkZW50aXR5X21hcCB7CisgICAgc3Ry dWN0IGxpc3RfaGVhZCBsaXN0OworICAgIHBhZGRyX3QgYmFzZSwgZW5kOwor ICAgIHAybV9hY2Nlc3NfdCBhY2Nlc3M7CisgICAgdW5zaWduZWQgaW50IGNv dW50OworfTsKKworaW50IGlvbW11X2lkZW50aXR5X21hcHBpbmcoc3RydWN0 IGRvbWFpbiAqZCwgcDJtX2FjY2Vzc190IHAybWEsCisgICAgICAgICAgICAg ICAgICAgICAgICAgICBwYWRkcl90IGJhc2UsIHBhZGRyX3QgZW5kLAorICAg ICAgICAgICAgICAgICAgICAgICAgICAgdW5zaWduZWQgaW50IGZsYWcpCit7 CisgICAgdW5zaWduZWQgbG9uZyBiYXNlX3BmbiA9IGJhc2UgPj4gUEFHRV9T SElGVF80SzsKKyAgICB1bnNpZ25lZCBsb25nIGVuZF9wZm4gPSBQQUdFX0FM SUdOXzRLKGVuZCkgPj4gUEFHRV9TSElGVF80SzsKKyAgICBzdHJ1Y3QgaWRl bnRpdHlfbWFwICptYXA7CisgICAgc3RydWN0IGRvbWFpbl9pb21tdSAqaGQg PSBkb21faW9tbXUoZCk7CisKKyAgICBBU1NFUlQocGNpZGV2c19sb2NrZWQo KSk7CisgICAgQVNTRVJUKGJhc2UgPCBlbmQpOworCisgICAgLyoKKyAgICAg KiBObyBuZWVkIHRvIGFjcXVpcmUgaGQtPmFyY2gubWFwcGluZ19sb2NrOiBC b3RoIGluc2VydGlvbiBhbmQgcmVtb3ZhbAorICAgICAqIGdldCBkb25lIHdo aWxlIGhvbGRpbmcgcGNpZGV2c19sb2NrLgorICAgICAqLworICAgIGxpc3Rf Zm9yX2VhY2hfZW50cnkoIG1hcCwgJmhkLT5hcmNoLmlkZW50aXR5X21hcHMs IGxpc3QgKQorICAgIHsKKyAgICAgICAgaWYgKCBtYXAtPmJhc2UgPT0gYmFz ZSAmJiBtYXAtPmVuZCA9PSBlbmQgKQorICAgICAgICB7CisgICAgICAgICAg ICBpbnQgcmV0ID0gMDsKKworICAgICAgICAgICAgaWYgKCBwMm1hICE9IHAy bV9hY2Nlc3NfeCApCisgICAgICAgICAgICB7CisgICAgICAgICAgICAgICAg aWYgKCBtYXAtPmFjY2VzcyAhPSBwMm1hICkKKyAgICAgICAgICAgICAgICAg ICAgcmV0dXJuIC1FQUREUklOVVNFOworICAgICAgICAgICAgICAgICsrbWFw LT5jb3VudDsKKyAgICAgICAgICAgICAgICByZXR1cm4gMDsKKyAgICAgICAg ICAgIH0KKworICAgICAgICAgICAgaWYgKCAtLW1hcC0+Y291bnQgKQorICAg ICAgICAgICAgICAgIHJldHVybiAwOworCisgICAgICAgICAgICB3aGlsZSAo IGJhc2VfcGZuIDwgZW5kX3BmbiApCisgICAgICAgICAgICB7CisgICAgICAg ICAgICAgICAgaWYgKCBjbGVhcl9pZGVudGl0eV9wMm1fZW50cnkoZCwgYmFz ZV9wZm4pICkKKyAgICAgICAgICAgICAgICAgICAgcmV0ID0gLUVOWElPOwor ICAgICAgICAgICAgICAgIGJhc2VfcGZuKys7CisgICAgICAgICAgICB9CisK KyAgICAgICAgICAgIGxpc3RfZGVsKCZtYXAtPmxpc3QpOworICAgICAgICAg ICAgeGZyZWUobWFwKTsKKworICAgICAgICAgICAgcmV0dXJuIHJldDsKKyAg ICAgICAgfQorCisgICAgICAgIGlmICggZW5kID49IG1hcC0+YmFzZSAmJiBt YXAtPmVuZCA+PSBiYXNlICkKKyAgICAgICAgICAgIHJldHVybiAtRUFERFJJ TlVTRTsKKyAgICB9CisKKyAgICBpZiAoIHAybWEgPT0gcDJtX2FjY2Vzc194 ICkKKyAgICAgICAgcmV0dXJuIC1FTk9FTlQ7CisKKyAgICB3aGlsZSAoIGJh c2VfcGZuIDwgZW5kX3BmbiApCisgICAgeworICAgICAgICBpbnQgZXJyID0g c2V0X2lkZW50aXR5X3AybV9lbnRyeShkLCBiYXNlX3BmbiwgcDJtYSwgZmxh Zyk7CisKKyAgICAgICAgaWYgKCBlcnIgKQorICAgICAgICAgICAgcmV0dXJu IGVycjsKKyAgICAgICAgYmFzZV9wZm4rKzsKKyAgICB9CisKKyAgICBtYXAg PSB4bWFsbG9jKHN0cnVjdCBpZGVudGl0eV9tYXApOworICAgIGlmICggIW1h cCApCisgICAgICAgIHJldHVybiAtRU5PTUVNOworICAgIG1hcC0+YmFzZSA9 IGJhc2U7CisgICAgbWFwLT5lbmQgPSBlbmQ7CisgICAgbWFwLT5hY2Nlc3Mg PSBwMm1hOworICAgIG1hcC0+Y291bnQgPSAxOworICAgIGxpc3RfYWRkX3Rh aWwoJm1hcC0+bGlzdCwgJmhkLT5hcmNoLmlkZW50aXR5X21hcHMpOworCisg ICAgcmV0dXJuIDA7Cit9CisKK3ZvaWQgaW9tbXVfaWRlbnRpdHlfbWFwX3Rl YXJkb3duKHN0cnVjdCBkb21haW4gKmQpCit7CisgICAgc3RydWN0IGRvbWFp bl9pb21tdSAqaGQgPSBkb21faW9tbXUoZCk7CisgICAgc3RydWN0IGlkZW50 aXR5X21hcCAqbWFwLCAqdG1wOworCisgICAgbGlzdF9mb3JfZWFjaF9lbnRy eV9zYWZlICggbWFwLCB0bXAsICZoZC0+YXJjaC5pZGVudGl0eV9tYXBzLCBs aXN0ICkKKyAgICB7CisgICAgICAgIGxpc3RfZGVsKCZtYXAtPmxpc3QpOwor ICAgICAgICB4ZnJlZShtYXApOworICAgIH0KK30KKwogc3RhdGljIGJvb2wg X19od2RvbV9pbml0IGh3ZG9tX2lvbW11X21hcChjb25zdCBzdHJ1Y3QgZG9t YWluICpkLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICB1bnNpZ25lZCBsb25nIHBmbiwKICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgdW5zaWduZWQgbG9uZyBtYXhfcGZuKQot LS0gYS94ZW4vaW5jbHVkZS9hc20teDg2L2lvbW11LmgKKysrIGIveGVuL2lu Y2x1ZGUvYXNtLXg4Ni9pb21tdS5oCkBAIC0xNiw2ICsxNiw3IEBACiAKICNp bmNsdWRlIDx4ZW4vZXJybm8uaD4KICNpbmNsdWRlIDx4ZW4vbGlzdC5oPgor I2luY2x1ZGUgPHhlbi9tZW1fYWNjZXNzLmg+CiAjaW5jbHVkZSA8eGVuL3Nw aW5sb2NrLmg+CiAjaW5jbHVkZSA8YXNtL2FwaWNkZWYuaD4KICNpbmNsdWRl IDxhc20vcHJvY2Vzc29yLmg+CkBAIC00OSw3ICs1MCw3IEBAIHN0cnVjdCBh cmNoX2lvbW11CiAgICAgc3BpbmxvY2tfdCBtYXBwaW5nX2xvY2s7ICAgICAg ICAgICAgLyogaW8gcGFnZSB0YWJsZSBsb2NrICovCiAgICAgaW50IGFnYXc7 ICAgICAvKiBhZGp1c3RlZCBndWVzdCBhZGRyZXNzIHdpZHRoLCAwIGlzIGxl dmVsIDIgMzAtYml0ICovCiAgICAgdTY0IGlvbW11X2JpdG1hcDsgICAgICAg ICAgICAgIC8qIGJpdG1hcCBvZiBpb21tdShzKSB0aGF0IHRoZSBkb21haW4g dXNlcyAqLwotICAgIHN0cnVjdCBsaXN0X2hlYWQgbWFwcGVkX3JtcnJzOwor ICAgIHN0cnVjdCBsaXN0X2hlYWQgaWRlbnRpdHlfbWFwczsKIAogICAgIC8q IGFtZCBpb21tdSBzdXBwb3J0ICovCiAgICAgaW50IHBhZ2luZ19tb2RlOwpA QCAtMTEyLDYgKzExMywxMSBAQCBzdGF0aWMgaW5saW5lIHZvaWQgaW9tbXVf ZGlzYWJsZV94MmFwaWMoCiAgICAgICAgIGlvbW11X29wcy5kaXNhYmxlX3gy YXBpYygpOwogfQogCitpbnQgaW9tbXVfaWRlbnRpdHlfbWFwcGluZyhzdHJ1 Y3QgZG9tYWluICpkLCBwMm1fYWNjZXNzX3QgcDJtYSwKKyAgICAgICAgICAg ICAgICAgICAgICAgICAgIHBhZGRyX3QgYmFzZSwgcGFkZHJfdCBlbmQsCisg ICAgICAgICAgICAgICAgICAgICAgICAgICB1bnNpZ25lZCBpbnQgZmxhZyk7 Cit2b2lkIGlvbW11X2lkZW50aXR5X21hcF90ZWFyZG93bihzdHJ1Y3QgZG9t YWluICpkKTsKKwogZXh0ZXJuIGJvb2wgdW50cnVzdGVkX21zaTsKIAogaW50 IHBpX3VwZGF0ZV9pcnRlKGNvbnN0IHN0cnVjdCBwaV9kZXNjICpwaV9kZXNj LCBjb25zdCBzdHJ1Y3QgcGlycSAqcGlycSwKLS0tIGEveGVuL2luY2x1ZGUv YXNtLXg4Ni9wMm0uaAorKysgYi94ZW4vaW5jbHVkZS9hc20teDg2L3AybS5o CkBAIC05MDUsNiArOTA1LDM0IEBAIHN0cnVjdCBwMm1fZG9tYWluICpwMm1f Z2V0X2FsdHAybShzdHJ1Y3QKIHN0YXRpYyBpbmxpbmUgdm9pZCBwMm1fYWx0 cDJtX2NoZWNrKHN0cnVjdCB2Y3B1ICp2LCB1aW50MTZfdCBpZHgpIHt9CiAj ZW5kaWYKIAorLyogcDJtIGFjY2VzcyB0byBJT01NVSBmbGFncyAqLworc3Rh dGljIGlubGluZSB1bnNpZ25lZCBpbnQgcDJtX2FjY2Vzc190b19pb21tdV9m bGFncyhwMm1fYWNjZXNzX3QgcDJtYSkKK3sKKyAgICBzd2l0Y2ggKCBwMm1h ICkKKyAgICB7CisgICAgY2FzZSBwMm1fYWNjZXNzX3J3OgorICAgIGNhc2Ug cDJtX2FjY2Vzc19yd3g6CisgICAgICAgIHJldHVybiBJT01NVUZfcmVhZGFi bGUgfCBJT01NVUZfd3JpdGFibGU7CisKKyAgICBjYXNlIHAybV9hY2Nlc3Nf cjoKKyAgICBjYXNlIHAybV9hY2Nlc3Nfcng6CisgICAgY2FzZSBwMm1fYWNj ZXNzX3J4MnJ3OgorICAgICAgICByZXR1cm4gSU9NTVVGX3JlYWRhYmxlOwor CisgICAgY2FzZSBwMm1fYWNjZXNzX3c6CisgICAgY2FzZSBwMm1fYWNjZXNz X3d4OgorICAgICAgICByZXR1cm4gSU9NTVVGX3dyaXRhYmxlOworCisgICAg Y2FzZSBwMm1fYWNjZXNzX246CisgICAgY2FzZSBwMm1fYWNjZXNzX3g6Cisg ICAgY2FzZSBwMm1fYWNjZXNzX24ycnd4OgorICAgICAgICByZXR1cm4gMDsK KyAgICB9CisKKyAgICBBU1NFUlRfVU5SRUFDSEFCTEUoKTsKKyAgICByZXR1 cm4gMDsKK30KKwogLyoKICAqIHAybSB0eXBlIHRvIElPTU1VIGZsYWdzCiAg Ki8KQEAgLTkyNiw5ICs5NTQsMTAgQEAgc3RhdGljIGlubGluZSB1bnNpZ25l ZCBpbnQgcDJtX2dldF9pb21tdQogICAgICAgICBmbGFncyA9IElPTU1VRl9y ZWFkYWJsZTsKICAgICAgICAgYnJlYWs7CiAgICAgY2FzZSBwMm1fbW1pb19k aXJlY3Q6Ci0gICAgICAgIGZsYWdzID0gSU9NTVVGX3JlYWRhYmxlOwotICAg ICAgICBpZiAoICFyYW5nZXNldF9jb250YWluc19zaW5nbGV0b24obW1pb19y b19yYW5nZXMsIG1mbl94KG1mbikpICkKLSAgICAgICAgICAgIGZsYWdzIHw9 IElPTU1VRl93cml0YWJsZTsKKyAgICAgICAgZmxhZ3MgPSBwMm1fYWNjZXNz X3RvX2lvbW11X2ZsYWdzKHAybWEpOworICAgICAgICBpZiAoIChmbGFncyAm IElPTU1VRl93cml0YWJsZSkgJiYKKyAgICAgICAgICAgICByYW5nZXNldF9j b250YWluc19zaW5nbGV0b24obW1pb19yb19yYW5nZXMsIG1mbl94KG1mbikp ICkKKyAgICAgICAgICAgIGZsYWdzICY9IH5JT01NVUZfd3JpdGFibGU7CiAg ICAgICAgIGJyZWFrOwogICAgIGRlZmF1bHQ6CiAgICAgICAgIGZsYWdzID0g MDsK --=separator Content-Type: application/octet-stream; name="xsa378/xsa378-4.13-5.patch" Content-Disposition: attachment; filename="xsa378/xsa378-4.13-5.patch" Content-Transfer-Encoding: base64 RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0 OiBBTUQvSU9NTVU6IHJlLWFycmFuZ2UvY29tcGxldGUgcmUtYXNzaWdubWVu dCBoYW5kbGluZwoKUHJpb3IgdG8gdGhlIGFzc2lnbm1lbnQgc3RlcCBoYXZp bmcgY29tcGxldGVkIHN1Y2Nlc3NmdWxseSwgZGV2aWNlcwpzaG91bGQgbm90 IGdldCBhc3NvY2lhdGVkIHdpdGggdGhlaXIgbmV3IG93bmVyLiBIYW5kIHRo ZSBkZXZpY2UgdG8gRG9tSU8KKHBlcmhhcHMgdGVtcG9yYXJpbHkpLCB1bnRp bCBhZnRlciB0aGUgZGUtYXNzaWdubWVudCBzdGVwIGhhcyBjb21wbGV0ZWQu CgpEZS1hc3NpZ25tZW50IG9mIGEgZGV2aWNlIChmcm9tIG90aGVyIHRoYW4g RG9tMCkgYXMgd2VsbCBhcyBmYWlsdXJlIG9mCnJlYXNzaWduX2RldmljZSgp IGR1cmluZyBhc3NpZ25tZW50IHNob3VsZCByZXN1bHQgaW4gdW5pdHkgbWFw cGluZ3MKZ2V0dGluZyB0b3JuIGRvd24uIFRoaXMgaW4gdHVybiByZXF1aXJl cyBzd2l0Y2hpbmcgdG8gYSByZWZjb3VudGVkCm1hcHBpbmcgYXBwcm9hY2gs IGFzIHdhcyBhbHJlYWR5IHVzZWQgYnkgVlQtZCBmb3IgaXRzIFJNUlJzLCB0 byBwcmV2ZW50CnVubWFwcGluZyBhIHJlZ2lvbiB1c2VkIGJ5IG11bHRpcGxl IGRldmljZXMuCgpUaGlzIGlzIENWRS0yMDIxLTI4Njk2IC8gcGFydCBvZiBY U0EtMzc4LgoKU2lnbmVkLW9mZi1ieTogSmFuIEJldWxpY2ggPGpiZXVsaWNo QHN1c2UuY29tPgpSZXZpZXdlZC1ieTogUGF1bCBEdXJyYW50IDxwYXVsQHhl bi5vcmc+CgotLS0gYS94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC9hbWQvaW9t bXVfbWFwLmMKKysrIGIveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvYW1kL2lv bW11X21hcC5jCkBAIC00MzAsMzggKzQzMCw0OSBAQCBpbnQgYW1kX2lvbW11 X2ZsdXNoX2lvdGxiX2FsbChzdHJ1Y3QgZG9tCiAgICAgcmV0dXJuIDA7CiB9 CiAKLWludCBhbWRfaW9tbXVfcmVzZXJ2ZV9kb21haW5fdW5pdHlfbWFwKHN0 cnVjdCBkb21haW4gKmRvbWFpbiwKLSAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIHBhZGRyX3QgcGh5c19hZGRyLAotICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdW5zaWduZWQgbG9uZyBz aXplLCBpbnQgaXcsIGludCBpcikKK2ludCBhbWRfaW9tbXVfcmVzZXJ2ZV9k b21haW5fdW5pdHlfbWFwKHN0cnVjdCBkb21haW4gKmQsCisgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjb25zdCBzdHJ1Y3QgaXZy c191bml0eV9tYXAgKm1hcCwKKyAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIHVuc2lnbmVkIGludCBmbGFnKQogewotICAgIHVuc2ln bmVkIGxvbmcgbnBhZ2VzLCBpOwotICAgIHVuc2lnbmVkIGxvbmcgZ2ZuOwot ICAgIHVuc2lnbmVkIGludCBmbGFncyA9ICEhaXI7Ci0gICAgdW5zaWduZWQg aW50IGZsdXNoX2ZsYWdzID0gMDsKLSAgICBpbnQgcnQgPSAwOwotCi0gICAg aWYgKCBpdyApCi0gICAgICAgIGZsYWdzIHw9IElPTU1VRl93cml0YWJsZTsK LQotICAgIG5wYWdlcyA9IHJlZ2lvbl90b19wYWdlcyhwaHlzX2FkZHIsIHNp emUpOwotICAgIGdmbiA9IHBoeXNfYWRkciA+PiBQQUdFX1NISUZUOwotICAg IGZvciAoIGkgPSAwOyBpIDwgbnBhZ2VzOyBpKysgKQorICAgIGludCByYzsK KworICAgIGlmICggZCA9PSBkb21faW8gKQorICAgICAgICByZXR1cm4gMDsK KworICAgIGZvciAoIHJjID0gMDsgIXJjICYmIG1hcDsgbWFwID0gbWFwLT5u ZXh0ICkKICAgICB7Ci0gICAgICAgIHVuc2lnbmVkIGxvbmcgZnJhbWUgPSBn Zm4gKyBpOworICAgICAgICBwMm1fYWNjZXNzX3QgcDJtYSA9IHAybV9hY2Nl c3NfbjsKKworICAgICAgICBpZiAoIG1hcC0+cmVhZCApCisgICAgICAgICAg ICBwMm1hIHw9IHAybV9hY2Nlc3NfcjsKKyAgICAgICAgaWYgKCBtYXAtPndy aXRlICkKKyAgICAgICAgICAgIHAybWEgfD0gcDJtX2FjY2Vzc193OwogCi0g ICAgICAgIHJ0ID0gYW1kX2lvbW11X21hcF9wYWdlKGRvbWFpbiwgX2Rmbihm cmFtZSksIF9tZm4oZnJhbWUpLCBmbGFncywKLSAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgJmZsdXNoX2ZsYWdzKTsKLSAgICAgICAgaWYgKCBy dCAhPSAwICkKLSAgICAgICAgICAgIGJyZWFrOworICAgICAgICByYyA9IGlv bW11X2lkZW50aXR5X21hcHBpbmcoZCwgcDJtYSwgbWFwLT5hZGRyLAorICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgbWFwLT5hZGRyICsg bWFwLT5sZW5ndGggLSAxLCBmbGFnKTsKICAgICB9CiAKLSAgICAvKiBVc2Ug d2hpbGUtYnJlYWsgdG8gYXZvaWQgY29tcGlsZXIgd2FybmluZyAqLwotICAg IHdoaWxlICggZmx1c2hfZmxhZ3MgJiYKLSAgICAgICAgICAgIGFtZF9pb21t dV9mbHVzaF9pb3RsYl9wYWdlcyhkb21haW4sIF9kZm4oZ2ZuKSwKLSAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBucGFnZXMsIGZs dXNoX2ZsYWdzKSApCi0gICAgICAgIGJyZWFrOworICAgIHJldHVybiByYzsK K30KKworaW50IGFtZF9pb21tdV9yZXNlcnZlX2RvbWFpbl91bml0eV91bm1h cChzdHJ1Y3QgZG9tYWluICpkLAorICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBjb25zdCBzdHJ1Y3QgaXZyc191bml0eV9tYXAg Km1hcCkKK3sKKyAgICBpbnQgcmM7CisKKyAgICBpZiAoIGQgPT0gZG9tX2lv ICkKKyAgICAgICAgcmV0dXJuIDA7CisKKyAgICBmb3IgKCByYyA9IDA7IG1h cDsgbWFwID0gbWFwLT5uZXh0ICkKKyAgICB7CisgICAgICAgIGludCByZXQg PSBpb21tdV9pZGVudGl0eV9tYXBwaW5nKGQsIHAybV9hY2Nlc3NfeCwgbWFw LT5hZGRyLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICBtYXAtPmFkZHIgKyBtYXAtPmxlbmd0aCAtIDEsIDApOworCisgICAg ICAgIGlmICggcmV0ICYmIHJldCAhPSAtRU5PRU5UICYmICFyYyApCisgICAg ICAgICAgICByYyA9IHJldDsKKyAgICB9CiAKLSAgICByZXR1cm4gcnQ7Cisg ICAgcmV0dXJuIHJjOwogfQogCiBpbnQgX19pbml0IGFtZF9pb21tdV9xdWFy YW50aW5lX2luaXQoc3RydWN0IGRvbWFpbiAqZCkKLS0tIGEveGVuL2RyaXZl cnMvcGFzc3Rocm91Z2gvYW1kL3BjaV9hbWRfaW9tbXUuYworKysgYi94ZW4v ZHJpdmVycy9wYXNzdGhyb3VnaC9hbWQvcGNpX2FtZF9pb21tdS5jCkBAIC0z MzAsNiArMzMwLDcgQEAgc3RhdGljIGludCByZWFzc2lnbl9kZXZpY2Uoc3Ry dWN0IGRvbWFpbgogICAgIHN0cnVjdCBhbWRfaW9tbXUgKmlvbW11OwogICAg IGludCBiZGYsIHJjOwogICAgIHN0cnVjdCBkb21haW5faW9tbXUgKnQgPSBk b21faW9tbXUodGFyZ2V0KTsKKyAgICBjb25zdCBzdHJ1Y3QgaXZyc19tYXBw aW5ncyAqaXZyc19tYXBwaW5ncyA9IGdldF9pdnJzX21hcHBpbmdzKHBkZXYt PnNlZyk7CiAKICAgICBiZGYgPSBQQ0lfQkRGMihwZGV2LT5idXMsIHBkZXYt PmRldmZuKTsKICAgICBpb21tdSA9IGZpbmRfaW9tbXVfZm9yX2RldmljZShw ZGV2LT5zZWcsIGJkZik7CkBAIC0zNDQsMTAgKzM0NSwyNCBAQCBzdGF0aWMg aW50IHJlYXNzaWduX2RldmljZShzdHJ1Y3QgZG9tYWluCiAKICAgICBhbWRf aW9tbXVfZGlzYWJsZV9kb21haW5fZGV2aWNlKHNvdXJjZSwgaW9tbXUsIGRl dmZuLCBwZGV2KTsKIAotICAgIGlmICggZGV2Zm4gPT0gcGRldi0+ZGV2Zm4g KQorICAgIC8qCisgICAgICogSWYgdGhlIGRldmljZSBiZWxvbmdzIHRvIHRo ZSBoYXJkd2FyZSBkb21haW4sIGFuZCBpdCBoYXMgYSB1bml0eSBtYXBwaW5n LAorICAgICAqIGRvbid0IHJlbW92ZSBpdCBmcm9tIHRoZSBoYXJkd2FyZSBk b21haW4sIGJlY2F1c2UgQklPUyBtYXkgcmVmZXJlbmNlIHRoYXQKKyAgICAg KiBtYXBwaW5nLgorICAgICAqLworICAgIGlmICggIWlzX2hhcmR3YXJlX2Rv bWFpbihzb3VyY2UpICkKKyAgICB7CisgICAgICAgIHJjID0gYW1kX2lvbW11 X3Jlc2VydmVfZG9tYWluX3VuaXR5X3VubWFwKAorICAgICAgICAgICAgICAg ICBzb3VyY2UsCisgICAgICAgICAgICAgICAgIGl2cnNfbWFwcGluZ3NbZ2V0 X2RtYV9yZXF1ZXN0b3JfaWQocGRldi0+c2VnLCBiZGYpXS51bml0eV9tYXAp OworICAgICAgICBpZiAoIHJjICkKKyAgICAgICAgICAgIHJldHVybiByYzsK KyAgICB9CisKKyAgICBpZiAoIGRldmZuID09IHBkZXYtPmRldmZuICYmIHBk ZXYtPmRvbWFpbiAhPSBkb21faW8gKQogICAgIHsKLSAgICAgICAgbGlzdF9t b3ZlKCZwZGV2LT5kb21haW5fbGlzdCwgJnRhcmdldC0+cGRldl9saXN0KTsK LSAgICAgICAgcGRldi0+ZG9tYWluID0gdGFyZ2V0OworICAgICAgICBsaXN0 X21vdmUoJnBkZXYtPmRvbWFpbl9saXN0LCAmZG9tX2lvLT5wZGV2X2xpc3Qp OworICAgICAgICBwZGV2LT5kb21haW4gPSBkb21faW87CiAgICAgfQogCiAg ICAgcmMgPSBhbGxvY2F0ZV9kb21haW5fcmVzb3VyY2VzKHQpOwpAQCAtMzU5 LDYgKzM3NCwxMiBAQCBzdGF0aWMgaW50IHJlYXNzaWduX2RldmljZShzdHJ1 Y3QgZG9tYWluCiAgICAgICAgICAgICAgICAgICAgIHBkZXYtPnNlZywgcGRl di0+YnVzLCBQQ0lfU0xPVChkZXZmbiksIFBDSV9GVU5DKGRldmZuKSwKICAg ICAgICAgICAgICAgICAgICAgc291cmNlLT5kb21haW5faWQsIHRhcmdldC0+ ZG9tYWluX2lkKTsKIAorICAgIGlmICggZGV2Zm4gPT0gcGRldi0+ZGV2Zm4g JiYgcGRldi0+ZG9tYWluICE9IHRhcmdldCApCisgICAgeworICAgICAgICBs aXN0X21vdmUoJnBkZXYtPmRvbWFpbl9saXN0LCAmdGFyZ2V0LT5wZGV2X2xp c3QpOworICAgICAgICBwZGV2LT5kb21haW4gPSB0YXJnZXQ7CisgICAgfQor CiAgICAgcmV0dXJuIDA7CiB9CiAKQEAgLTM2OSwyMCArMzkwLDI4IEBAIHN0 YXRpYyBpbnQgYW1kX2lvbW11X2Fzc2lnbl9kZXZpY2Uoc3RydWMKICAgICBz dHJ1Y3QgaXZyc19tYXBwaW5ncyAqaXZyc19tYXBwaW5ncyA9IGdldF9pdnJz X21hcHBpbmdzKHBkZXYtPnNlZyk7CiAgICAgaW50IGJkZiA9IFBDSV9CREYy KHBkZXYtPmJ1cywgZGV2Zm4pOwogICAgIGludCByZXFfaWQgPSBnZXRfZG1h X3JlcXVlc3Rvcl9pZChwZGV2LT5zZWcsIGJkZik7Ci0gICAgY29uc3Qgc3Ry dWN0IGl2cnNfdW5pdHlfbWFwICp1bml0eV9tYXA7CisgICAgaW50IHJjID0g YW1kX2lvbW11X3Jlc2VydmVfZG9tYWluX3VuaXR5X21hcCgKKyAgICAgICAg ICAgICAgICAgZCwgaXZyc19tYXBwaW5nc1tyZXFfaWRdLnVuaXR5X21hcCwg ZmxhZyk7CisKKyAgICBpZiAoICFyYyApCisgICAgICAgIHJjID0gcmVhc3Np Z25fZGV2aWNlKHBkZXYtPmRvbWFpbiwgZCwgZGV2Zm4sIHBkZXYpOwogCi0g ICAgZm9yICggdW5pdHlfbWFwID0gaXZyc19tYXBwaW5nc1tyZXFfaWRdLnVu aXR5X21hcDsgdW5pdHlfbWFwOwotICAgICAgICAgIHVuaXR5X21hcCA9IHVu aXR5X21hcC0+bmV4dCApCisgICAgaWYgKCByYyAmJiAhaXNfaGFyZHdhcmVf ZG9tYWluKGQpICkKICAgICB7Ci0gICAgICAgIGludCByYyA9IGFtZF9pb21t dV9yZXNlcnZlX2RvbWFpbl91bml0eV9tYXAoCi0gICAgICAgICAgICAgICAg ICAgICBkLCB1bml0eV9tYXAtPmFkZHIsIHVuaXR5X21hcC0+bGVuZ3RoLAot ICAgICAgICAgICAgICAgICAgICAgdW5pdHlfbWFwLT53cml0ZSwgdW5pdHlf bWFwLT5yZWFkKTsKKyAgICAgICAgaW50IHJldCA9IGFtZF9pb21tdV9yZXNl cnZlX2RvbWFpbl91bml0eV91bm1hcCgKKyAgICAgICAgICAgICAgICAgICAg ICBkLCBpdnJzX21hcHBpbmdzW3JlcV9pZF0udW5pdHlfbWFwKTsKIAotICAg ICAgICBpZiAoIHJjICkKLSAgICAgICAgICAgIHJldHVybiByYzsKKyAgICAg ICAgaWYgKCByZXQgKQorICAgICAgICB7CisgICAgICAgICAgICBwcmludGso WEVOTE9HX0VSUiAiQU1ELVZpOiAiCisgICAgICAgICAgICAgICAgICAgInVu aXR5LXVubWFwIGZvciAlcGQvJTA0eDolMDJ4OiUwMnguJXUgZmFpbGVkICgl ZClcbiIsCisgICAgICAgICAgICAgICAgICAgZCwgcGRldi0+c2VnLCBwZGV2 LT5idXMsCisgICAgICAgICAgICAgICAgICAgUENJX1NMT1QoZGV2Zm4pLCBQ Q0lfRlVOQyhkZXZmbiksIHJldCk7CisgICAgICAgICAgICBkb21haW5fY3Jh c2goZCk7CisgICAgICAgIH0KICAgICB9CiAKLSAgICByZXR1cm4gcmVhc3Np Z25fZGV2aWNlKHBkZXYtPmRvbWFpbiwgZCwgZGV2Zm4sIHBkZXYpOworICAg IHJldHVybiByYzsKIH0KIAogc3RhdGljIHZvaWQgZGVhbGxvY2F0ZV9uZXh0 X3BhZ2VfdGFibGUoc3RydWN0IHBhZ2VfaW5mbyAqcGcsIGludCBsZXZlbCkK QEAgLTQ0MSw2ICs0NzAsNyBAQCBzdGF0aWMgdm9pZCBkZWFsbG9jYXRlX2lv bW11X3BhZ2VfdGFibGVzCiAKIHN0YXRpYyB2b2lkIGFtZF9pb21tdV9kb21h aW5fZGVzdHJveShzdHJ1Y3QgZG9tYWluICpkKQogeworICAgIGlvbW11X2lk ZW50aXR5X21hcF90ZWFyZG93bihkKTsKICAgICBkZWFsbG9jYXRlX2lvbW11 X3BhZ2VfdGFibGVzKGQpOwogICAgIGFtZF9pb21tdV9mbHVzaF9hbGxfcGFn ZXMoZCk7CiB9Ci0tLSBhL3hlbi9pbmNsdWRlL2FzbS14ODYvaHZtL3N2bS9h bWQtaW9tbXUtcHJvdG8uaAorKysgYi94ZW4vaW5jbHVkZS9hc20teDg2L2h2 bS9zdm0vYW1kLWlvbW11LXByb3RvLmgKQEAgLTY0LDggKzY0LDEwIEBAIGlu dCBfX211c3RfY2hlY2sgYW1kX2lvbW11X3VubWFwX3BhZ2Uoc3QKICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdW5zaWduZWQgaW50 ICpmbHVzaF9mbGFncyk7CiBpbnQgX19tdXN0X2NoZWNrIGFtZF9pb21tdV9h bGxvY19yb290KHN0cnVjdCBkb21haW5faW9tbXUgKmhkKTsKIGludCBhbWRf aW9tbXVfcmVzZXJ2ZV9kb21haW5fdW5pdHlfbWFwKHN0cnVjdCBkb21haW4g KmRvbWFpbiwKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIHBhZGRyX3QgcGh5c19hZGRyLCB1bnNpZ25lZCBsb25nIHNpemUsCi0g ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBpbnQgaXcs IGludCBpcik7CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICBjb25zdCBzdHJ1Y3QgaXZyc191bml0eV9tYXAgKm1hcCwKKyAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHVuc2lnbmVkIGlu dCBmbGFnKTsKK2ludCBhbWRfaW9tbXVfcmVzZXJ2ZV9kb21haW5fdW5pdHlf dW5tYXAoc3RydWN0IGRvbWFpbiAqZCwKKyAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgY29uc3Qgc3RydWN0IGl2cnNfdW5pdHlf bWFwICptYXApOwogaW50IF9fbXVzdF9jaGVjayBhbWRfaW9tbXVfZmx1c2hf aW90bGJfcGFnZXMoc3RydWN0IGRvbWFpbiAqZCwgZGZuX3QgZGZuLAogICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdW5z aWduZWQgaW50IHBhZ2VfY291bnQsCiAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICB1bnNpZ25lZCBpbnQgZmx1c2hfZmxh Z3MpOwo= --=separator Content-Type: application/octet-stream; name="xsa378/xsa378-4.13-6.patch" Content-Disposition: attachment; filename="xsa378/xsa378-4.13-6.patch" Content-Transfer-Encoding: base64 RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0 OiBBTUQvSU9NTVU6IHJlLWFycmFuZ2UgZXhjbHVzaW9uIHJhbmdlIGFuZCB1 bml0eSBtYXAgcmVjb3JkaW5nCgpUaGUgc3BlYyBtYWtlcyBubyBwcm92aXNp b25zIGZvciBPUyBiZWhhdmlvciBoZXJlIHRvIGRlcGVuZCBvbiB0aGUKYW1v dW50IG9mIFJBTSBmb3VuZCBvbiB0aGUgc3lzdGVtLiBXaGlsZSB0aGUgc3Bl YyBtYXkgbm90IHN1ZmZpY2llbnRseQpjbGVhcmx5IGRpc3Rpbmd1aXNoIGJv dGgga2luZHMgb2YgcmVnaW9ucywgdGhleSBhcmUgc3VyZWx5IG1lYW50IHRv IGJlCnNlcGFyYXRlIHRoaW5nczogT25seSByZWdpb25zIHdpdGggQUNQSV9J Vk1EX0VYQ0xVU0lPTl9SQU5HRSBzZXQgc2hvdWxkCmJlIGNhbmRpZGF0ZXMg Zm9yIHB1dHRpbmcgaW4gdGhlIGV4Y2x1c2lvbiByYW5nZSByZWdpc3RlcnMu IChBcyB0aGVyZSdzCm9ubHkgYSBzaW5nbGUgc3VjaCBwYWlyIG9mIHJlZ2lz dGVycyBwZXIgSU9NTVUsIHNlY29uZGFyeSBub24tYWRqYWNlbnQKcmVnaW9u cyB3aXRoIHRoZSBmbGFnIHNldCBhbHJlYWR5IGdldCBjb252ZXJ0ZWQgdG8g dW5pdHkgbWFwcGVkCnJlZ2lvbnMuKQoKRmlyc3Qgb2YgYWxsLCBkcm9wIHRo ZSBkZXBlbmRlbmN5IG9uIG1heF9wYWdlLiBXaXRoIGNvbW1pdCBiNGYwNDIy MzZhZTAKKCJBTUQvSU9NTVU6IENlYXNlIHVzaW5nIGEgZHluYW1pYyBoZWln aHQgZm9yIHRoZSBJT01NVSBwYWdldGFibGVzIikgdGhlCnVzZSBvZiBpdCBo ZXJlIHdhcyBzdGFsZSBhbnl3YXk7IGl0IHdhcyBib2d1cyBhbHJlYWR5IGJl Zm9yZSwgYXMgaXQKZGlkbid0IGFjY291bnQgZm9yIG1heF9wYWdlIGdldHRp bmcgaW5jcmVhc2VkIGxhdGVyIG9uLiBTaW1wbHkgdHJ5IGFuCmV4Y2x1c2lv biByYW5nZSByZWdpc3RyYXRpb24gZmlyc3QsIGFuZCBpZiBpdCBmYWlscyAo Zm9yIGJlaW5nCnVuc3VpdGFibGUgb3Igbm9uLW1lcmdlYWJsZSksIHJlZ2lz dGVyIGEgdW5pdHkgbWFwcGluZyByYW5nZS4KCldpdGggdGhpcyB2YXJpb3Vz IGxvY2FsIHZhcmlhYmxlcyBiZWNvbWUgdW5uZWNlc3NhcnkgYW5kIGhlbmNl IGdldApkcm9wcGVkIGF0IHRoZSBzYW1lIHRpbWUuCgpXaXRoIHRoZSBtYXhf cGFnZSBib3VuZGFyeSBkcm9wcGVkIGZvciB1c2luZyB1bml0eSBtYXBzLCB0 aGUgbWluaW11bQpwYWdlIHRhYmxlIHRyZWUgaGVpZ2h0IG5vdyBuZWVkcyBi b3RoIHJlY29yZGluZyBhbmQgZW5mb3JjaW5nIGluCmFtZF9pb21tdV9kb21h aW5faW5pdCgpLiBTaW5jZSB3ZSBjYW4ndCBwcmVkaWN0IHdoaWNoIGRldmlj ZXMgbWF5IGdldAphc3NpZ25lZCB0byBhIGRvbWFpbiwgb3VyIG9ubHkgb3B0 aW9uIGlzIHRvIHVuaWZvcm1seSBmb3JjZSBhdCBsZWFzdAp0aGF0IGhlaWdo dCBmb3IgYWxsIGRvbWFpbnMsIG5vdyB0aGF0IHRoZSBoZWlnaHQgaXNuJ3Qg ZHluYW1pYyBhbnltb3JlLgoKRnVydGhlciBkb24ndCBtYWtlIHVzZSBvZiB0 aGUgZXhjbHVzaW9uIHJhbmdlIHVubGVzcyBBQ1BJIGRhdGEgc2F5cyBzby4K Ck5vdGUgdGhhdCBleGNsdXNpb24gcmFuZ2UgcmVnaXN0cmF0aW9uIGluCnJl Z2lzdGVyX3JhbmdlX2Zvcl9hbGxfZGV2aWNlcygpIGlzIG9uIGEgYmVzdCBl ZmZvcnQgYmFzaXMuIEhlbmNlIHVuaXR5Cm1hcCBlbnRyaWVzIGFsc28gcmVn aXN0ZXJlZCBhcmUgcmVkdW5kYW50IHdoZW4gdGhlIGZvcm1lciBzdWNjZWVk ZWQsIGJ1dAp0aGV5IGFsc28gZG8gbm8gaGFybS4gSW1wcm92ZW1lbnRzIGlu IHRoaXMgYXJlYSBjYW4gYmUgZG9uZSBsYXRlciBpbW8uCgpBbHNvIGFkanVz dCB0eXBlcyB3aGVyZSBzdWl0YWJsZSB3aXRob3V0IHRvdWNoaW5nIGV4dHJh IGxpbmVzLgoKVGhpcyBpcyBwYXJ0IG9mIFhTQS0zNzguCgpTaWduZWQtb2Zm LWJ5OiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+ClJldmlld2Vk LWJ5OiBQYXVsIER1cnJhbnQgPHBhdWxAeGVuLm9yZz4KCi0tLSBhL3hlbi9k cml2ZXJzL3Bhc3N0aHJvdWdoL2FtZC9pb21tdV9hY3BpLmMKKysrIGIveGVu L2RyaXZlcnMvcGFzc3Rocm91Z2gvYW1kL2lvbW11X2FjcGkuYwpAQCAtMTE4 LDEyICsxMTgsOCBAQCBzdGF0aWMgc3RydWN0IGFtZF9pb21tdSAqIF9faW5p dCBmaW5kX2lvCiB9CiAKIHN0YXRpYyBpbnQgX19pbml0IHJlc2VydmVfaW9t bXVfZXhjbHVzaW9uX3JhbmdlKAotICAgIHN0cnVjdCBhbWRfaW9tbXUgKmlv bW11LCB1aW50NjRfdCBiYXNlLCB1aW50NjRfdCBsaW1pdCwKLSAgICBib29s IGFsbCwgYm9vbCBpdywgYm9vbCBpcikKKyAgICBzdHJ1Y3QgYW1kX2lvbW11 ICppb21tdSwgcGFkZHJfdCBiYXNlLCBwYWRkcl90IGxpbWl0LCBib29sIGFs bCkKIHsKLSAgICBpZiAoICFpciB8fCAhaXcgKQotICAgICAgICByZXR1cm4g LUVQRVJNOwotCiAgICAgLyogbmVlZCB0byBleHRlbmQgZXhjbHVzaW9uIHJh bmdlPyAqLwogICAgIGlmICggaW9tbXUtPmV4Y2x1c2lvbl9lbmFibGUgKQog ICAgIHsKQEAgLTE1MiwxNCArMTQ4LDE4IEBAIHN0YXRpYyBpbnQgX19pbml0 IHJlc2VydmVfdW5pdHlfbWFwX2Zvcl8KIHsKICAgICBzdHJ1Y3QgaXZyc19t YXBwaW5ncyAqaXZyc19tYXBwaW5ncyA9IGdldF9pdnJzX21hcHBpbmdzKHNl Zyk7CiAgICAgc3RydWN0IGl2cnNfdW5pdHlfbWFwICp1bml0eV9tYXAgPSBp dnJzX21hcHBpbmdzW2JkZl0udW5pdHlfbWFwOworICAgIGludCBwYWdpbmdf bW9kZSA9IGFtZF9pb21tdV9nZXRfcGFnaW5nX21vZGUoUEZOX1VQKGJhc2Ug KyBsZW5ndGgpKTsKKworICAgIGlmICggcGFnaW5nX21vZGUgPCAwICkKKyAg ICAgICAgcmV0dXJuIHBhZ2luZ19tb2RlOwogCiAgICAgLyogQ2hlY2sgZm9y IG92ZXJsYXBzLiAqLwogICAgIGZvciAoIDsgdW5pdHlfbWFwOyB1bml0eV9t YXAgPSB1bml0eV9tYXAtPm5leHQgKQogICAgIHsKICAgICAgICAgLyoKICAg ICAgICAgICogRXhhY3QgbWF0Y2hlcyBhcmUgb2theS4gVGhpcyBjYW4gaW4g cGFydGljdWxhciBoYXBwZW4gd2hlbgotICAgICAgICAgKiByZWdpc3Rlcl9l eGNsdXNpb25fcmFuZ2VfZm9yX2RldmljZSgpIGNhbGxzIGhlcmUgdHdpY2Ug Zm9yIHRoZQotICAgICAgICAgKiBzYW1lIChzLGIsZCxmKS4KKyAgICAgICAg ICogcmVnaXN0ZXJfcmFuZ2VfZm9yX2RldmljZSgpIGNhbGxzIGhlcmUgdHdp Y2UgZm9yIHRoZSBzYW1lCisgICAgICAgICAqIChzLGIsZCxmKS4KICAgICAg ICAgICovCiAgICAgICAgIGlmICggYmFzZSA9PSB1bml0eV9tYXAtPmFkZHIg JiYgbGVuZ3RoID09IHVuaXR5X21hcC0+bGVuZ3RoICYmCiAgICAgICAgICAg ICAgaXIgPT0gdW5pdHlfbWFwLT5yZWFkICYmIGl3ID09IHVuaXR5X21hcC0+ d3JpdGUgKQpAQCAtMTg3LDU1ICsxODcsNTIgQEAgc3RhdGljIGludCBfX2lu aXQgcmVzZXJ2ZV91bml0eV9tYXBfZm9yXwogICAgIHVuaXR5X21hcC0+bmV4 dCA9IGl2cnNfbWFwcGluZ3NbYmRmXS51bml0eV9tYXA7CiAgICAgaXZyc19t YXBwaW5nc1tiZGZdLnVuaXR5X21hcCA9IHVuaXR5X21hcDsKIAorICAgIGlm ICggcGFnaW5nX21vZGUgPiBhbWRfaW9tbXVfbWluX3BhZ2luZ19tb2RlICkK KyAgICAgICAgYW1kX2lvbW11X21pbl9wYWdpbmdfbW9kZSA9IHBhZ2luZ19t b2RlOworCiAgICAgcmV0dXJuIDA7CiB9CiAKLXN0YXRpYyBpbnQgX19pbml0 IHJlZ2lzdGVyX2V4Y2x1c2lvbl9yYW5nZV9mb3JfYWxsX2RldmljZXMoCi0g ICAgdW5zaWduZWQgbG9uZyBiYXNlLCB1bnNpZ25lZCBsb25nIGxpbWl0LCB1 OCBpdywgdTggaXIpCitzdGF0aWMgaW50IF9faW5pdCByZWdpc3Rlcl9yYW5n ZV9mb3JfYWxsX2RldmljZXMoCisgICAgcGFkZHJfdCBiYXNlLCBwYWRkcl90 IGxpbWl0LCBib29sIGl3LCBib29sIGlyLCBib29sIGV4Y2x1c2lvbikKIHsK ICAgICBpbnQgc2VnID0gMDsgLyogWFhYICovCi0gICAgdW5zaWduZWQgbG9u ZyByYW5nZV90b3AsIGlvbW11X3RvcCwgbGVuZ3RoOwogICAgIHN0cnVjdCBh bWRfaW9tbXUgKmlvbW11OwotICAgIHVuc2lnbmVkIGludCBiZGY7CiAgICAg aW50IHJjID0gMDsKIAogICAgIC8qIGlzIHBhcnQgb2YgZXhjbHVzaW9uIHJh bmdlIGluc2lkZSBvZiBJT01NVSB2aXJ0dWFsIGFkZHJlc3Mgc3BhY2U/ICov CiAgICAgLyogbm90ZTogJ2xpbWl0JyBwYXJhbWV0ZXIgaXMgYXNzdW1lZCB0 byBiZSBwYWdlLWFsaWduZWQgKi8KLSAgICByYW5nZV90b3AgPSBsaW1pdCAr IFBBR0VfU0laRTsKLSAgICBpb21tdV90b3AgPSBtYXhfcGFnZSAqIFBBR0Vf U0laRTsKLSAgICBpZiAoIGJhc2UgPCBpb21tdV90b3AgKQotICAgIHsKLSAg ICAgICAgaWYgKCByYW5nZV90b3AgPiBpb21tdV90b3AgKQotICAgICAgICAg ICAgcmFuZ2VfdG9wID0gaW9tbXVfdG9wOwotICAgICAgICBsZW5ndGggPSBy YW5nZV90b3AgLSBiYXNlOwotICAgICAgICAvKiByZXNlcnZlIHIvdyB1bml0 eS1tYXBwZWQgcGFnZSBlbnRyaWVzIGZvciBkZXZpY2VzICovCi0gICAgICAg IC8qIG5vdGU6IHRoZXNlIGVudHJpZXMgYXJlIHBhcnQgb2YgdGhlIGV4Y2x1 c2lvbiByYW5nZSAqLwotICAgICAgICBmb3IgKCBiZGYgPSAwOyAhcmMgJiYg YmRmIDwgaXZyc19iZGZfZW50cmllczsgYmRmKysgKQotICAgICAgICAgICAg cmMgPSByZXNlcnZlX3VuaXR5X21hcF9mb3JfZGV2aWNlKHNlZywgYmRmLCBi YXNlLCBsZW5ndGgsIGl3LCBpcik7Ci0gICAgICAgIC8qIHB1c2ggJ2Jhc2Un IGp1c3Qgb3V0c2lkZSBvZiB2aXJ0dWFsIGFkZHJlc3Mgc3BhY2UgKi8KLSAg ICAgICAgYmFzZSA9IGlvbW11X3RvcDsKLSAgICB9Ci0gICAgLyogcmVnaXN0 ZXIgSU9NTVUgZXhjbHVzaW9uIHJhbmdlIHNldHRpbmdzICovCi0gICAgaWYg KCAhcmMgJiYgbGltaXQgPj0gaW9tbXVfdG9wICkKKyAgICBpZiAoIGV4Y2x1 c2lvbiApCiAgICAgewogICAgICAgICBmb3JfZWFjaF9hbWRfaW9tbXUoIGlv bW11ICkKICAgICAgICAgewotICAgICAgICAgICAgcmMgPSByZXNlcnZlX2lv bW11X2V4Y2x1c2lvbl9yYW5nZShpb21tdSwgYmFzZSwgbGltaXQsCi0gICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHRy dWUgLyogYWxsICovLCBpdywgaXIpOwotICAgICAgICAgICAgaWYgKCByYyAp Ci0gICAgICAgICAgICAgICAgYnJlYWs7CisgICAgICAgICAgICBpbnQgcmV0 ID0gcmVzZXJ2ZV9pb21tdV9leGNsdXNpb25fcmFuZ2UoaW9tbXUsIGJhc2Us IGxpbWl0LAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIHRydWUgLyogYWxsICovKTsKKworICAgICAgICAg ICAgaWYgKCByZXQgJiYgIXJjICkKKyAgICAgICAgICAgICAgICByYyA9IHJl dDsKICAgICAgICAgfQogICAgIH0KIAorICAgIGlmICggIWV4Y2x1c2lvbiB8 fCByYyApCisgICAgeworICAgICAgICBwYWRkcl90IGxlbmd0aCA9IGxpbWl0 ICsgUEFHRV9TSVpFIC0gYmFzZTsKKyAgICAgICAgdW5zaWduZWQgaW50IGJk ZjsKKworICAgICAgICAvKiByZXNlcnZlIHIvdyB1bml0eS1tYXBwZWQgcGFn ZSBlbnRyaWVzIGZvciBkZXZpY2VzICovCisgICAgICAgIGZvciAoIGJkZiA9 IHJjID0gMDsgIXJjICYmIGJkZiA8IGl2cnNfYmRmX2VudHJpZXM7IGJkZisr ICkKKyAgICAgICAgICAgIHJjID0gcmVzZXJ2ZV91bml0eV9tYXBfZm9yX2Rl dmljZShzZWcsIGJkZiwgYmFzZSwgbGVuZ3RoLCBpdywgaXIpOworICAgIH0K KwogICAgIHJldHVybiByYzsKIH0KIAotc3RhdGljIGludCBfX2luaXQgcmVn aXN0ZXJfZXhjbHVzaW9uX3JhbmdlX2Zvcl9kZXZpY2UoCi0gICAgdTE2IGJk ZiwgdW5zaWduZWQgbG9uZyBiYXNlLCB1bnNpZ25lZCBsb25nIGxpbWl0LCB1 OCBpdywgdTggaXIpCitzdGF0aWMgaW50IF9faW5pdCByZWdpc3Rlcl9yYW5n ZV9mb3JfZGV2aWNlKAorICAgIHVuc2lnbmVkIGludCBiZGYsIHBhZGRyX3Qg YmFzZSwgcGFkZHJfdCBsaW1pdCwKKyAgICBib29sIGl3LCBib29sIGlyLCBi b29sIGV4Y2x1c2lvbikKIHsKICAgICBpbnQgc2VnID0gMDsgLyogWFhYICov CiAgICAgc3RydWN0IGl2cnNfbWFwcGluZ3MgKml2cnNfbWFwcGluZ3MgPSBn ZXRfaXZyc19tYXBwaW5ncyhzZWcpOwotICAgIHVuc2lnbmVkIGxvbmcgcmFu Z2VfdG9wLCBpb21tdV90b3AsIGxlbmd0aDsKICAgICBzdHJ1Y3QgYW1kX2lv bW11ICppb21tdTsKICAgICB1MTYgcmVxOwogICAgIGludCByYyA9IDA7CkBA IC0yNDksMjcgKzI0NiwxOSBAQCBzdGF0aWMgaW50IF9faW5pdCByZWdpc3Rl cl9leGNsdXNpb25fcmFuCiAgICAgcmVxID0gaXZyc19tYXBwaW5nc1tiZGZd LmR0ZV9yZXF1ZXN0b3JfaWQ7CiAKICAgICAvKiBub3RlOiAnbGltaXQnIHBh cmFtZXRlciBpcyBhc3N1bWVkIHRvIGJlIHBhZ2UtYWxpZ25lZCAqLwotICAg IHJhbmdlX3RvcCA9IGxpbWl0ICsgUEFHRV9TSVpFOwotICAgIGlvbW11X3Rv cCA9IG1heF9wYWdlICogUEFHRV9TSVpFOwotICAgIGlmICggYmFzZSA8IGlv bW11X3RvcCApCi0gICAgewotICAgICAgICBpZiAoIHJhbmdlX3RvcCA+IGlv bW11X3RvcCApCi0gICAgICAgICAgICByYW5nZV90b3AgPSBpb21tdV90b3A7 Ci0gICAgICAgIGxlbmd0aCA9IHJhbmdlX3RvcCAtIGJhc2U7CisgICAgaWYg KCBleGNsdXNpb24gKQorICAgICAgICByYyA9IHJlc2VydmVfaW9tbXVfZXhj bHVzaW9uX3JhbmdlKGlvbW11LCBiYXNlLCBsaW1pdCwKKyAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBmYWxzZSAvKiBhbGwg Ki8pOworICAgIGlmICggIWV4Y2x1c2lvbiB8fCByYyApCisgICAgeworICAg ICAgICBwYWRkcl90IGxlbmd0aCA9IGxpbWl0ICsgUEFHRV9TSVpFIC0gYmFz ZTsKKwogICAgICAgICAvKiByZXNlcnZlIHVuaXR5LW1hcHBlZCBwYWdlIGVu dHJpZXMgZm9yIGRldmljZSAqLwotICAgICAgICAvKiBub3RlOiB0aGVzZSBl bnRyaWVzIGFyZSBwYXJ0IG9mIHRoZSBleGNsdXNpb24gcmFuZ2UgKi8KICAg ICAgICAgcmMgPSByZXNlcnZlX3VuaXR5X21hcF9mb3JfZGV2aWNlKHNlZywg YmRmLCBiYXNlLCBsZW5ndGgsIGl3LCBpcikgPzoKICAgICAgICAgICAgICBy ZXNlcnZlX3VuaXR5X21hcF9mb3JfZGV2aWNlKHNlZywgcmVxLCBiYXNlLCBs ZW5ndGgsIGl3LCBpcik7Ci0KLSAgICAgICAgLyogcHVzaCAnYmFzZScganVz dCBvdXRzaWRlIG9mIHZpcnR1YWwgYWRkcmVzcyBzcGFjZSAqLwotICAgICAg ICBiYXNlID0gaW9tbXVfdG9wOwogICAgIH0KLQotICAgIC8qIHJlZ2lzdGVy IElPTU1VIGV4Y2x1c2lvbiByYW5nZSBzZXR0aW5ncyBmb3IgZGV2aWNlICov Ci0gICAgaWYgKCAhcmMgJiYgbGltaXQgPj0gaW9tbXVfdG9wICApCisgICAg ZWxzZQogICAgIHsKLSAgICAgICAgcmMgPSByZXNlcnZlX2lvbW11X2V4Y2x1 c2lvbl9yYW5nZShpb21tdSwgYmFzZSwgbGltaXQsCi0gICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZmFsc2UgLyogYWxsICov LCBpdywgaXIpOwogICAgICAgICBpdnJzX21hcHBpbmdzW2JkZl0uZHRlX2Fs bG93X2V4Y2x1c2lvbiA9IHRydWU7CiAgICAgICAgIGl2cnNfbWFwcGluZ3Nb cmVxXS5kdGVfYWxsb3dfZXhjbHVzaW9uID0gdHJ1ZTsKICAgICB9CkBAIC0y NzcsNTMgKzI2Niw0MiBAQCBzdGF0aWMgaW50IF9faW5pdCByZWdpc3Rlcl9l eGNsdXNpb25fcmFuCiAgICAgcmV0dXJuIHJjOwogfQogCi1zdGF0aWMgaW50 IF9faW5pdCByZWdpc3Rlcl9leGNsdXNpb25fcmFuZ2VfZm9yX2lvbW11X2Rl dmljZXMoCi0gICAgc3RydWN0IGFtZF9pb21tdSAqaW9tbXUsCi0gICAgdW5z aWduZWQgbG9uZyBiYXNlLCB1bnNpZ25lZCBsb25nIGxpbWl0LCB1OCBpdywg dTggaXIpCitzdGF0aWMgaW50IF9faW5pdCByZWdpc3Rlcl9yYW5nZV9mb3Jf aW9tbXVfZGV2aWNlcygKKyAgICBzdHJ1Y3QgYW1kX2lvbW11ICppb21tdSwg cGFkZHJfdCBiYXNlLCBwYWRkcl90IGxpbWl0LAorICAgIGJvb2wgaXcsIGJv b2wgaXIsIGJvb2wgZXhjbHVzaW9uKQogewotICAgIHVuc2lnbmVkIGxvbmcg cmFuZ2VfdG9wLCBpb21tdV90b3AsIGxlbmd0aDsKKyAgICAvKiBub3RlOiAn bGltaXQnIHBhcmFtZXRlciBpcyBhc3N1bWVkIHRvIGJlIHBhZ2UtYWxpZ25l ZCAqLworICAgIHBhZGRyX3QgbGVuZ3RoID0gbGltaXQgKyBQQUdFX1NJWkUg LSBiYXNlOwogICAgIHVuc2lnbmVkIGludCBiZGY7CiAgICAgdTE2IHJlcTsK LSAgICBpbnQgcmMgPSAwOworICAgIGludCByYzsKIAotICAgIC8qIGlzIHBh cnQgb2YgZXhjbHVzaW9uIHJhbmdlIGluc2lkZSBvZiBJT01NVSB2aXJ0dWFs IGFkZHJlc3Mgc3BhY2U/ICovCi0gICAgLyogbm90ZTogJ2xpbWl0JyBwYXJh bWV0ZXIgaXMgYXNzdW1lZCB0byBiZSBwYWdlLWFsaWduZWQgKi8KLSAgICBy YW5nZV90b3AgPSBsaW1pdCArIFBBR0VfU0laRTsKLSAgICBpb21tdV90b3Ag PSBtYXhfcGFnZSAqIFBBR0VfU0laRTsKLSAgICBpZiAoIGJhc2UgPCBpb21t dV90b3AgKQotICAgIHsKLSAgICAgICAgaWYgKCByYW5nZV90b3AgPiBpb21t dV90b3AgKQotICAgICAgICAgICAgcmFuZ2VfdG9wID0gaW9tbXVfdG9wOwot ICAgICAgICBsZW5ndGggPSByYW5nZV90b3AgLSBiYXNlOwotICAgICAgICAv KiByZXNlcnZlIHIvdyB1bml0eS1tYXBwZWQgcGFnZSBlbnRyaWVzIGZvciBk ZXZpY2VzICovCi0gICAgICAgIC8qIG5vdGU6IHRoZXNlIGVudHJpZXMgYXJl IHBhcnQgb2YgdGhlIGV4Y2x1c2lvbiByYW5nZSAqLwotICAgICAgICBmb3Ig KCBiZGYgPSAwOyAhcmMgJiYgYmRmIDwgaXZyc19iZGZfZW50cmllczsgYmRm KysgKQotICAgICAgICB7Ci0gICAgICAgICAgICBpZiAoIGlvbW11ID09IGZp bmRfaW9tbXVfZm9yX2RldmljZShpb21tdS0+c2VnLCBiZGYpICkKLSAgICAg ICAgICAgIHsKLSAgICAgICAgICAgICAgICByZXEgPSBnZXRfaXZyc19tYXBw aW5ncyhpb21tdS0+c2VnKVtiZGZdLmR0ZV9yZXF1ZXN0b3JfaWQ7Ci0gICAg ICAgICAgICAgICAgcmMgPSByZXNlcnZlX3VuaXR5X21hcF9mb3JfZGV2aWNl KGlvbW11LT5zZWcsIGJkZiwgYmFzZSwgbGVuZ3RoLAotICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBpdywgaXIp ID86Ci0gICAgICAgICAgICAgICAgICAgICByZXNlcnZlX3VuaXR5X21hcF9m b3JfZGV2aWNlKGlvbW11LT5zZWcsIHJlcSwgYmFzZSwgbGVuZ3RoLAotICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBpdywgaXIpOwotICAgICAgICAgICAgfQotICAgICAgICB9Ci0KLSAgICAg ICAgLyogcHVzaCAnYmFzZScganVzdCBvdXRzaWRlIG9mIHZpcnR1YWwgYWRk cmVzcyBzcGFjZSAqLwotICAgICAgICBiYXNlID0gaW9tbXVfdG9wOworICAg IGlmICggZXhjbHVzaW9uICkKKyAgICB7CisgICAgICAgIHJjID0gcmVzZXJ2 ZV9pb21tdV9leGNsdXNpb25fcmFuZ2UoaW9tbXUsIGJhc2UsIGxpbWl0LCB0 cnVlIC8qIGFsbCAqLyk7CisgICAgICAgIGlmICggIXJjICkKKyAgICAgICAg ICAgIHJldHVybiAwOwogICAgIH0KIAotICAgIC8qIHJlZ2lzdGVyIElPTU1V IGV4Y2x1c2lvbiByYW5nZSBzZXR0aW5ncyAqLwotICAgIGlmICggIXJjICYm IGxpbWl0ID49IGlvbW11X3RvcCApCi0gICAgICAgIHJjID0gcmVzZXJ2ZV9p b21tdV9leGNsdXNpb25fcmFuZ2UoaW9tbXUsIGJhc2UsIGxpbWl0LAotICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHRydWUg LyogYWxsICovLCBpdywgaXIpOworICAgIC8qIHJlc2VydmUgdW5pdHktbWFw cGVkIHBhZ2UgZW50cmllcyBmb3IgZGV2aWNlcyAqLworICAgIGZvciAoIGJk ZiA9IHJjID0gMDsgIXJjICYmIGJkZiA8IGl2cnNfYmRmX2VudHJpZXM7IGJk ZisrICkKKyAgICB7CisgICAgICAgIGlmICggaW9tbXUgIT0gZmluZF9pb21t dV9mb3JfZGV2aWNlKGlvbW11LT5zZWcsIGJkZikgKQorICAgICAgICAgICAg Y29udGludWU7CisKKyAgICAgICAgcmVxID0gZ2V0X2l2cnNfbWFwcGluZ3Mo aW9tbXUtPnNlZylbYmRmXS5kdGVfcmVxdWVzdG9yX2lkOworICAgICAgICBy YyA9IHJlc2VydmVfdW5pdHlfbWFwX2Zvcl9kZXZpY2UoaW9tbXUtPnNlZywg YmRmLCBiYXNlLCBsZW5ndGgsCisgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBpdywgaXIpID86CisgICAgICAgICAgICAgcmVz ZXJ2ZV91bml0eV9tYXBfZm9yX2RldmljZShpb21tdS0+c2VnLCByZXEsIGJh c2UsIGxlbmd0aCwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIGl3LCBpcik7CisgICAgfQogCiAgICAgcmV0dXJuIHJjOwog fQogCiBzdGF0aWMgaW50IF9faW5pdCBwYXJzZV9pdm1kX2RldmljZV9zZWxl Y3QoCiAgICAgY29uc3Qgc3RydWN0IGFjcGlfaXZyc19tZW1vcnkgKml2bWRf YmxvY2ssCi0gICAgdW5zaWduZWQgbG9uZyBiYXNlLCB1bnNpZ25lZCBsb25n IGxpbWl0LCB1OCBpdywgdTggaXIpCisgICAgcGFkZHJfdCBiYXNlLCBwYWRk cl90IGxpbWl0LCBib29sIGl3LCBib29sIGlyLCBib29sIGV4Y2x1c2lvbikK IHsKICAgICB1MTYgYmRmOwogCkBAIC0zMzQsMTIgKzMxMiwxMiBAQCBzdGF0 aWMgaW50IF9faW5pdCBwYXJzZV9pdm1kX2RldmljZV9zZWxlCiAgICAgICAg IHJldHVybiAtRU5PREVWOwogICAgIH0KIAotICAgIHJldHVybiByZWdpc3Rl cl9leGNsdXNpb25fcmFuZ2VfZm9yX2RldmljZShiZGYsIGJhc2UsIGxpbWl0 LCBpdywgaXIpOworICAgIHJldHVybiByZWdpc3Rlcl9yYW5nZV9mb3JfZGV2 aWNlKGJkZiwgYmFzZSwgbGltaXQsIGl3LCBpciwgZXhjbHVzaW9uKTsKIH0K IAogc3RhdGljIGludCBfX2luaXQgcGFyc2VfaXZtZF9kZXZpY2VfcmFuZ2Uo CiAgICAgY29uc3Qgc3RydWN0IGFjcGlfaXZyc19tZW1vcnkgKml2bWRfYmxv Y2ssCi0gICAgdW5zaWduZWQgbG9uZyBiYXNlLCB1bnNpZ25lZCBsb25nIGxp bWl0LCB1OCBpdywgdTggaXIpCisgICAgcGFkZHJfdCBiYXNlLCBwYWRkcl90 IGxpbWl0LCBib29sIGl3LCBib29sIGlyLCBib29sIGV4Y2x1c2lvbikKIHsK ICAgICB1bnNpZ25lZCBpbnQgZmlyc3RfYmRmLCBsYXN0X2JkZiwgYmRmOwog ICAgIGludCBlcnJvcjsKQEAgLTM2MSwxNSArMzM5LDE1IEBAIHN0YXRpYyBp bnQgX19pbml0IHBhcnNlX2l2bWRfZGV2aWNlX3JhbmcKICAgICB9CiAKICAg ICBmb3IgKCBiZGYgPSBmaXJzdF9iZGYsIGVycm9yID0gMDsgKGJkZiA8PSBs YXN0X2JkZikgJiYgIWVycm9yOyBiZGYrKyApCi0gICAgICAgIGVycm9yID0g cmVnaXN0ZXJfZXhjbHVzaW9uX3JhbmdlX2Zvcl9kZXZpY2UoCi0gICAgICAg ICAgICBiZGYsIGJhc2UsIGxpbWl0LCBpdywgaXIpOworICAgICAgICBlcnJv ciA9IHJlZ2lzdGVyX3JhbmdlX2Zvcl9kZXZpY2UoCisgICAgICAgICAgICBi ZGYsIGJhc2UsIGxpbWl0LCBpdywgaXIsIGV4Y2x1c2lvbik7CiAKICAgICBy ZXR1cm4gZXJyb3I7CiB9CiAKIHN0YXRpYyBpbnQgX19pbml0IHBhcnNlX2l2 bWRfZGV2aWNlX2lvbW11KAogICAgIGNvbnN0IHN0cnVjdCBhY3BpX2l2cnNf bWVtb3J5ICppdm1kX2Jsb2NrLAotICAgIHVuc2lnbmVkIGxvbmcgYmFzZSwg dW5zaWduZWQgbG9uZyBsaW1pdCwgdTggaXcsIHU4IGlyKQorICAgIHBhZGRy X3QgYmFzZSwgcGFkZHJfdCBsaW1pdCwgYm9vbCBpdywgYm9vbCBpciwgYm9v bCBleGNsdXNpb24pCiB7CiAgICAgaW50IHNlZyA9IDA7IC8qIFhYWCAqLwog ICAgIHN0cnVjdCBhbWRfaW9tbXUgKmlvbW11OwpAQCAtMzg0LDE0ICszNjIs MTQgQEAgc3RhdGljIGludCBfX2luaXQgcGFyc2VfaXZtZF9kZXZpY2VfaW9t bQogICAgICAgICByZXR1cm4gLUVOT0RFVjsKICAgICB9CiAKLSAgICByZXR1 cm4gcmVnaXN0ZXJfZXhjbHVzaW9uX3JhbmdlX2Zvcl9pb21tdV9kZXZpY2Vz KAotICAgICAgICBpb21tdSwgYmFzZSwgbGltaXQsIGl3LCBpcik7CisgICAg cmV0dXJuIHJlZ2lzdGVyX3JhbmdlX2Zvcl9pb21tdV9kZXZpY2VzKAorICAg ICAgICBpb21tdSwgYmFzZSwgbGltaXQsIGl3LCBpciwgZXhjbHVzaW9uKTsK IH0KIAogc3RhdGljIGludCBfX2luaXQgcGFyc2VfaXZtZF9ibG9jayhjb25z dCBzdHJ1Y3QgYWNwaV9pdnJzX21lbW9yeSAqaXZtZF9ibG9jaykKIHsKICAg ICB1bnNpZ25lZCBsb25nIHN0YXJ0X2FkZHIsIG1lbV9sZW5ndGgsIGJhc2Us IGxpbWl0OwotICAgIHU4IGl3LCBpcjsKKyAgICBib29sIGl3ID0gdHJ1ZSwg aXIgPSB0cnVlLCBleGNsdXNpb24gPSBmYWxzZTsKIAogICAgIGlmICggaXZt ZF9ibG9jay0+aGVhZGVyLmxlbmd0aCA8IHNpemVvZigqaXZtZF9ibG9jaykg KQogICAgIHsKQEAgLTQwOCwxMyArMzg2LDExIEBAIHN0YXRpYyBpbnQgX19p bml0IHBhcnNlX2l2bWRfYmxvY2soY29uc3QKICAgICAgICAgICAgICAgICAg ICAgaXZtZF9ibG9jay0+aGVhZGVyLnR5cGUsIHN0YXJ0X2FkZHIsIG1lbV9s ZW5ndGgpOwogCiAgICAgaWYgKCBpdm1kX2Jsb2NrLT5oZWFkZXIuZmxhZ3Mg JiBBQ1BJX0lWTURfRVhDTFVTSU9OX1JBTkdFICkKLSAgICAgICAgaXcgPSBp ciA9IElPTU1VX0NPTlRST0xfRU5BQkxFRDsKKyAgICAgICAgZXhjbHVzaW9u ID0gdHJ1ZTsKICAgICBlbHNlIGlmICggaXZtZF9ibG9jay0+aGVhZGVyLmZs YWdzICYgQUNQSV9JVk1EX1VOSVRZICkKICAgICB7Ci0gICAgICAgIGl3ID0g aXZtZF9ibG9jay0+aGVhZGVyLmZsYWdzICYgQUNQSV9JVk1EX1JFQUQgPwot ICAgICAgICAgICAgSU9NTVVfQ09OVFJPTF9FTkFCTEVEIDogSU9NTVVfQ09O VFJPTF9ESVNBQkxFRDsKLSAgICAgICAgaXIgPSBpdm1kX2Jsb2NrLT5oZWFk ZXIuZmxhZ3MgJiBBQ1BJX0lWTURfV1JJVEUgPwotICAgICAgICAgICAgSU9N TVVfQ09OVFJPTF9FTkFCTEVEIDogSU9NTVVfQ09OVFJPTF9ESVNBQkxFRDsK KyAgICAgICAgaXcgPSBpdm1kX2Jsb2NrLT5oZWFkZXIuZmxhZ3MgJiBBQ1BJ X0lWTURfUkVBRDsKKyAgICAgICAgaXIgPSBpdm1kX2Jsb2NrLT5oZWFkZXIu ZmxhZ3MgJiBBQ1BJX0lWTURfV1JJVEU7CiAgICAgfQogICAgIGVsc2UKICAg ICB7CkBAIC00MjUsMjAgKzQwMSwyMCBAQCBzdGF0aWMgaW50IF9faW5pdCBw YXJzZV9pdm1kX2Jsb2NrKGNvbnN0CiAgICAgc3dpdGNoKCBpdm1kX2Jsb2Nr LT5oZWFkZXIudHlwZSApCiAgICAgewogICAgIGNhc2UgQUNQSV9JVlJTX1RZ UEVfTUVNT1JZX0FMTDoKLSAgICAgICAgcmV0dXJuIHJlZ2lzdGVyX2V4Y2x1 c2lvbl9yYW5nZV9mb3JfYWxsX2RldmljZXMoCi0gICAgICAgICAgICBiYXNl LCBsaW1pdCwgaXcsIGlyKTsKKyAgICAgICAgcmV0dXJuIHJlZ2lzdGVyX3Jh bmdlX2Zvcl9hbGxfZGV2aWNlcygKKyAgICAgICAgICAgIGJhc2UsIGxpbWl0 LCBpdywgaXIsIGV4Y2x1c2lvbik7CiAKICAgICBjYXNlIEFDUElfSVZSU19U WVBFX01FTU9SWV9PTkU6Ci0gICAgICAgIHJldHVybiBwYXJzZV9pdm1kX2Rl dmljZV9zZWxlY3QoaXZtZF9ibG9jaywKLSAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICBiYXNlLCBsaW1pdCwgaXcsIGlyKTsKKyAg ICAgICAgcmV0dXJuIHBhcnNlX2l2bWRfZGV2aWNlX3NlbGVjdChpdm1kX2Js b2NrLCBiYXNlLCBsaW1pdCwKKyAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICBpdywgaXIsIGV4Y2x1c2lvbik7CiAKICAgICBjYXNl IEFDUElfSVZSU19UWVBFX01FTU9SWV9SQU5HRToKLSAgICAgICAgcmV0dXJu IHBhcnNlX2l2bWRfZGV2aWNlX3JhbmdlKGl2bWRfYmxvY2ssCi0gICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBiYXNlLCBsaW1pdCwg aXcsIGlyKTsKKyAgICAgICAgcmV0dXJuIHBhcnNlX2l2bWRfZGV2aWNlX3Jh bmdlKGl2bWRfYmxvY2ssIGJhc2UsIGxpbWl0LAorICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgaXcsIGlyLCBleGNsdXNpb24pOwog CiAgICAgY2FzZSBBQ1BJX0lWUlNfVFlQRV9NRU1PUllfSU9NTVU6Ci0gICAg ICAgIHJldHVybiBwYXJzZV9pdm1kX2RldmljZV9pb21tdShpdm1kX2Jsb2Nr LAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgYmFz ZSwgbGltaXQsIGl3LCBpcik7CisgICAgICAgIHJldHVybiBwYXJzZV9pdm1k X2RldmljZV9pb21tdShpdm1kX2Jsb2NrLCBiYXNlLCBsaW1pdCwKKyAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGl3LCBpciwgZXhj bHVzaW9uKTsKIAogICAgIGRlZmF1bHQ6CiAgICAgICAgIEFNRF9JT01NVV9E RUJVRygiSVZNRCBFcnJvcjogSW52YWxpZCBCbG9jayBUeXBlIVxuIik7Ci0t LSBhL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL2FtZC9wY2lfYW1kX2lvbW11 LmMKKysrIGIveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvYW1kL3BjaV9hbWRf aW9tbXUuYwpAQCAtMjM0LDYgKzIzNCw4IEBAIHN0YXRpYyBpbnQgX19tdXN0 X2NoZWNrIGFsbG9jYXRlX2RvbWFpbl8KICAgICByZXR1cm4gcmM7CiB9CiAK K2ludCBfX3JlYWRfbW9zdGx5IGFtZF9pb21tdV9taW5fcGFnaW5nX21vZGUg PSAxOworCiBzdGF0aWMgaW50IGFtZF9pb21tdV9kb21haW5faW5pdChzdHJ1 Y3QgZG9tYWluICpkKQogewogICAgIHN0cnVjdCBkb21haW5faW9tbXUgKmhk ID0gZG9tX2lvbW11KGQpOwpAQCAtMjQ1LDExICsyNDcsMTMgQEAgc3RhdGlj IGludCBhbWRfaW9tbXVfZG9tYWluX2luaXQoc3RydWN0CiAgICAgICogLSBI Vk0gY291bGQgaW4gcHJpbmNpcGxlIHVzZSAzIG9yIDQgZGVwZW5kaW5nIG9u IGhvdyBtdWNoIGd1ZXN0CiAgICAgICogICBwaHlzaWNhbCBhZGRyZXNzIHNw YWNlIHdlIGdpdmUgaXQsIGJ1dCB0aGlzIGlzbid0IGtub3duIHlldCBzbyB1 c2UgNAogICAgICAqICAgdW5pbGF0ZXJhbGx5LgorICAgICAqIC0gVW5pdHkg bWFwcyBtYXkgcmVxdWlyZSBhbiBldmVuIGhpZ2hlciBudW1iZXIuCiAgICAg ICovCi0gICAgaGQtPmFyY2gucGFnaW5nX21vZGUgPSBhbWRfaW9tbXVfZ2V0 X3BhZ2luZ19tb2RlKAotICAgICAgICBpc19odm1fZG9tYWluKGQpCi0gICAg ICAgID8gMXVsIDw8IChERUZBVUxUX0RPTUFJTl9BRERSRVNTX1dJRFRIIC0g UEFHRV9TSElGVCkKLSAgICAgICAgOiBnZXRfdXBwZXJfbWZuX2JvdW5kKCkg KyAxKTsKKyAgICBoZC0+YXJjaC5wYWdpbmdfbW9kZSA9IG1heChhbWRfaW9t bXVfZ2V0X3BhZ2luZ19tb2RlKAorICAgICAgICAgICAgaXNfaHZtX2RvbWFp bihkKQorICAgICAgICAgICAgPyAxdWwgPDwgKERFRkFVTFRfRE9NQUlOX0FE RFJFU1NfV0lEVEggLSBQQUdFX1NISUZUKQorICAgICAgICAgICAgOiBnZXRf dXBwZXJfbWZuX2JvdW5kKCkgKyAxKSwKKyAgICAgICAgYW1kX2lvbW11X21p bl9wYWdpbmdfbW9kZSk7CiAKICAgICByZXR1cm4gMDsKIH0KLS0tIGEveGVu L2luY2x1ZGUvYXNtLXg4Ni9odm0vc3ZtL2FtZC1pb21tdS1wcm90by5oCisr KyBiL3hlbi9pbmNsdWRlL2FzbS14ODYvaHZtL3N2bS9hbWQtaW9tbXUtcHJv dG8uaApAQCAtMTQwLDYgKzE0MCw4IEBAIGV4dGVybiBzdHJ1Y3QgaHBldF9z YmRmIHsKICAgICB9IGluaXQ7CiB9IGhwZXRfc2JkZjsKIAorZXh0ZXJuIGlu dCBhbWRfaW9tbXVfbWluX3BhZ2luZ19tb2RlOworCiBleHRlcm4gdm9pZCAq c2hhcmVkX2ludHJlbWFwX3RhYmxlOwogZXh0ZXJuIHVuc2lnbmVkIGxvbmcg KnNoYXJlZF9pbnRyZW1hcF9pbnVzZTsKIAo= --=separator Content-Type: application/octet-stream; name="xsa378/xsa378-4.13-7.patch" Content-Disposition: attachment; filename="xsa378/xsa378-4.13-7.patch" Content-Transfer-Encoding: base64 RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0 OiB4ODYvcDJtOiBpbnRyb2R1Y2UgcDJtX2lzX3NwZWNpYWwoKQoKU2VlaW5n IHRoZSBzaW1pbGFyaXR5IG9mIGdyYW50LCBmb3JlaWduLCBhbmQgKHN1YnNl cXVlbnRseSkgZGlyZWN0LU1NSU8KaGFuZGxpbmcsIGludHJvZHVjZSBhIG5l dyBQMk0gdHlwZSBncm91cCBuYW1lZCAic3BlY2lhbCIgKGFzIGluICJuZWVk aW5nCnNwZWNpYWwgYWNjZXNzb3JzIHRvIGNyZWF0ZS9kZXN0cm95IikuCgpB bHNvIHVzZSAtRVBFUk0gaW5zdGVhZCBvZiBvdGhlciBlcnJvciBjb2RlcyBv biB0aGUgdHdvIGRvbWFpbl9jcmFzaCgpCnBhdGhzIHRvdWNoZWQuCgpUaGlz IGlzIHBhcnQgb2YgWFNBLTM3OC4KClNpZ25lZC1vZmYtYnk6IEphbiBCZXVs aWNoIDxqYmV1bGljaEBzdXNlLmNvbT4KUmV2aWV3ZWQtYnk6IFBhdWwgRHVy cmFudCA8cGF1bEB4ZW4ub3JnPgoKLS0tIGEveGVuL2FyY2gveDg2L21tL3Ay bS5jCisrKyBiL3hlbi9hcmNoL3g4Ni9tbS9wMm0uYwpAQCAtODA3LDcgKzgw Nyw3IEBAIHAybV9yZW1vdmVfcGFnZShzdHJ1Y3QgcDJtX2RvbWFpbiAqcDJt LAogICAgICAgICBmb3IgKCBpID0gMDsgaSA8ICgxVUwgPDwgcGFnZV9vcmRl cik7IGkrKyApCiAgICAgICAgIHsKICAgICAgICAgICAgIHAybS0+Z2V0X2Vu dHJ5KHAybSwgZ2ZuX2FkZChnZm4sIGkpLCAmdCwgJmEsIDAsIE5VTEwsIE5V TEwpOwotICAgICAgICAgICAgaWYgKCAhcDJtX2lzX2dyYW50KHQpICYmICFw Mm1faXNfc2hhcmVkKHQpICYmICFwMm1faXNfZm9yZWlnbih0KSApCisgICAg ICAgICAgICBpZiAoICFwMm1faXNfc3BlY2lhbCh0KSAmJiAhcDJtX2lzX3No YXJlZCh0KSApCiAgICAgICAgICAgICAgICAgc2V0X2dwZm5fZnJvbV9tZm4o bWZuK2ksIElOVkFMSURfTTJQX0VOVFJZKTsKICAgICAgICAgfQogICAgIH0K QEAgLTkzNCwxMyArOTM0LDEzIEBAIGd1ZXN0X3BoeXNtYXBfYWRkX2VudHJ5 KHN0cnVjdCBkb21haW4gKmQKICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAmb3QsICZhLCAwLCBOVUxMLCBOVUxMKTsKICAgICAgICAgICAg IEFTU0VSVCghcDJtX2lzX3NoYXJlZChvdCkpOwogICAgICAgICB9Ci0gICAg ICAgIGlmICggcDJtX2lzX2dyYW50KG90KSB8fCBwMm1faXNfZm9yZWlnbihv dCkgKQorICAgICAgICBpZiAoIHAybV9pc19zcGVjaWFsKG90KSApCiAgICAg ICAgIHsKLSAgICAgICAgICAgIC8qIFJlYWxseSBzaG91bGRuJ3QgYmUgdW5t YXBwaW5nIGdyYW50L2ZvcmVpZ24gbWFwcyB0aGlzIHdheSAqLworICAgICAg ICAgICAgLyogRG9uJ3QgcGVybWl0IHVubWFwcGluZyBncmFudC9mb3JlaWdu IHRoaXMgd2F5LiAqLwogICAgICAgICAgICAgZG9tYWluX2NyYXNoKGQpOwog ICAgICAgICAgICAgcDJtX3VubG9jayhwMm0pOwogICAgICAgICAgICAgCi0g ICAgICAgICAgICByZXR1cm4gLUVJTlZBTDsKKyAgICAgICAgICAgIHJldHVy biAtRVBFUk07CiAgICAgICAgIH0KICAgICAgICAgZWxzZSBpZiAoIHAybV9p c19yYW0ob3QpICYmICFwMm1faXNfcGFnZWQob3QpICkKICAgICAgICAgewpA QCAtMTAzNCw4ICsxMDM0LDcgQEAgaW50IHAybV9jaGFuZ2VfdHlwZV9vbmUo c3RydWN0IGRvbWFpbiAqZAogICAgIHN0cnVjdCBwMm1fZG9tYWluICpwMm0g PSBwMm1fZ2V0X2hvc3RwMm0oZCk7CiAgICAgaW50IHJjOwogCi0gICAgQlVH X09OKHAybV9pc19ncmFudChvdCkgfHwgcDJtX2lzX2dyYW50KG50KSk7Ci0g ICAgQlVHX09OKHAybV9pc19mb3JlaWduKG90KSB8fCBwMm1faXNfZm9yZWln bihudCkpOworICAgIEJVR19PTihwMm1faXNfc3BlY2lhbChvdCkgfHwgcDJt X2lzX3NwZWNpYWwobnQpKTsKIAogICAgIGdmbl9sb2NrKHAybSwgZ2ZuLCAw KTsKIApAQCAtMTI4MiwxMSArMTI4MSwxMSBAQCBzdGF0aWMgaW50IHNldF90 eXBlZF9wMm1fZW50cnkoc3RydWN0IGRvCiAgICAgICAgIGdmbl91bmxvY2so cDJtLCBnZm4sIG9yZGVyKTsKICAgICAgICAgcmV0dXJuIGN1cl9vcmRlciAr IDE7CiAgICAgfQotICAgIGlmICggcDJtX2lzX2dyYW50KG90KSB8fCBwMm1f aXNfZm9yZWlnbihvdCkgKQorICAgIGlmICggcDJtX2lzX3NwZWNpYWwob3Qp ICkKICAgICB7CiAgICAgICAgIGdmbl91bmxvY2socDJtLCBnZm4sIG9yZGVy KTsKICAgICAgICAgZG9tYWluX2NyYXNoKGQpOwotICAgICAgICByZXR1cm4g LUVOT0VOVDsKKyAgICAgICAgcmV0dXJuIC1FUEVSTTsKICAgICB9CiAgICAg ZWxzZSBpZiAoIHAybV9pc19yYW0ob3QpICkKICAgICB7Ci0tLSBhL3hlbi9p bmNsdWRlL2FzbS14ODYvcDJtLmgKKysrIGIveGVuL2luY2x1ZGUvYXNtLXg4 Ni9wMm0uaApAQCAtMTQxLDYgKzE0MSwxMCBAQCB0eXBlZGVmIHVuc2lnbmVk IGludCBwMm1fcXVlcnlfdDsKICAgICAgICAgICAgICAgICAgICAgICAgICAg ICB8IHAybV90b19tYXNrKHAybV9yYW1fbG9nZGlydHkpICkKICNkZWZpbmUg UDJNX1NIQVJFRF9UWVBFUyAgIChwMm1fdG9fbWFzayhwMm1fcmFtX3NoYXJl ZCkpCiAKKy8qIFR5cGVzIGVzdGFibGlzaGVkL2NsZWFuZWQgdXAgdmlhIHNw ZWNpYWwgYWNjZXNzb3JzLiAqLworI2RlZmluZSBQMk1fU1BFQ0lBTF9UWVBF UyAoUDJNX0dSQU5UX1RZUEVTIHwgXAorICAgICAgICAgICAgICAgICAgICAg ICAgICAgcDJtX3RvX21hc2socDJtX21hcF9mb3JlaWduKSkKKwogLyogVmFs aWQgdHlwZXMgbm90IG5lY2Vzc2FyaWx5IGFzc29jaWF0ZWQgd2l0aCBhICh2 YWxpZCkgTUZOLiAqLwogI2RlZmluZSBQMk1fSU5WQUxJRF9NRk5fVFlQRVMg KFAyTV9QT0RfVFlQRVMgICAgICAgICAgICAgICAgICBcCiAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgfCBwMm1fdG9fbWFzayhwMm1fbW1pb19k aXJlY3QpIFwKQEAgLTE2OSw2ICsxNzMsNyBAQCB0eXBlZGVmIHVuc2lnbmVk IGludCBwMm1fcXVlcnlfdDsKICNkZWZpbmUgcDJtX2lzX3BhZ2VkKF90KSAg ICAocDJtX3RvX21hc2soX3QpICYgUDJNX1BBR0VEX1RZUEVTKQogI2RlZmlu ZSBwMm1faXNfc2hhcmFibGUoX3QpIChwMm1fdG9fbWFzayhfdCkgJiBQMk1f U0hBUkFCTEVfVFlQRVMpCiAjZGVmaW5lIHAybV9pc19zaGFyZWQoX3QpICAg KHAybV90b19tYXNrKF90KSAmIFAyTV9TSEFSRURfVFlQRVMpCisjZGVmaW5l IHAybV9pc19zcGVjaWFsKF90KSAgKHAybV90b19tYXNrKF90KSAmIFAyTV9T UEVDSUFMX1RZUEVTKQogI2RlZmluZSBwMm1faXNfYnJva2VuKF90KSAgIChw Mm1fdG9fbWFzayhfdCkgJiBQMk1fQlJPS0VOX1RZUEVTKQogI2RlZmluZSBw Mm1faXNfZm9yZWlnbihfdCkgIChwMm1fdG9fbWFzayhfdCkgJiBwMm1fdG9f bWFzayhwMm1fbWFwX2ZvcmVpZ24pKQogCg== --=separator Content-Type: application/octet-stream; name="xsa378/xsa378-4.13-8.patch" Content-Disposition: attachment; filename="xsa378/xsa378-4.13-8.patch" Content-Transfer-Encoding: base64 RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0 OiB4ODYvcDJtOiBndWFyZCAoaW4gcGFydGljdWxhcikgaWRlbnRpdHkgbWFw cGluZyBlbnRyaWVzCgpTdWNoIGVudHJpZXMsIGNyZWF0ZWQgYnkgc2V0X2lk ZW50aXR5X3AybV9lbnRyeSgpLCBzaG91bGQgb25seSBiZQpkZXN0cm95ZWQg YnkgY2xlYXJfaWRlbnRpdHlfcDJtX2VudHJ5KCkuIEhvd2V2ZXIsIHNpbWls YXJseSwgZW50cmllcwpjcmVhdGVkIGJ5IHNldF9tbWlvX3AybV9lbnRyeSgp IHNob3VsZCBvbmx5IGJlIHRvcm4gZG93biBieQpjbGVhcl9tbWlvX3AybV9l bnRyeSgpLCBzbyB0aGUgbG9naWMgZ2V0cyBiYXNlZCB1cG9uIHAybV9tbWlv X2RpcmVjdCBhcwp0aGUgZW50cnkgdHlwZSAoc2VwYXJhdGlvbiBiZXR3ZWVu ICJvcmRpbmFyeSIgYW5kIDE6MSBtYXBwaW5ncyB3b3VsZApyZXF1aXJlIGEg ZnVydGhlciBpbmRpY2F0b3IgdG8gdGVsbCBhcGFydCB0aGUgdHdvKS4KCkFz IHRvIHRoZSBndWVzdF9yZW1vdmVfcGFnZSgpIGNoYW5nZSwgY29tbWl0IDQ4 ZGZiMjk3YTIwYSAoIng4Ni9QVkg6CmFsbG93IGd1ZXN0X3JlbW92ZV9wYWdl IHRvIHJlbW92ZSBwMm1fbW1pb19kaXJlY3QgcGFnZXMiKSwgd2hpY2gKaW50 cm9kdWNlZCB0aGUgY2FsbCB0byBjbGVhcl9tbWlvX3AybV9lbnRyeSgpLCBj bGFpbWVkIHRoaXMgd2FzIGRvbmUgZm9yCmh3ZG9tIG9ubHkgd2l0aG91dCB0 aGlzIGFjdHVhbGx5IGhhdmluZyBiZWVuIHRoZSBjYXNlLiBIb3dldmVyLCB0 aGlzCmNvZGUgc2hvdWxkbid0IGJlIHRoZXJlIGluIHRoZSBmaXJzdCBwbGFj ZSwgYXMgTU1JTyBlbnRyaWVzIHNob3VsZG4ndCBiZQpkcm9wcGVkIHRoaXMg d2F5LiBBdm9pZCB0cmlnZ2VyaW5nIHRoZSB3YXJuaW5nIGFnYWluIHRoYXQg NDhkZmIyOTdhMjBhCnNpbGVuY2VkIGJ5IGFuIGFkanVzdG1lbnQgdG8geGVu bWVtX2FkZF90b19waHlzbWFwX29uZSgpIGluc3RlYWQuCgpOb3RlIHRoYXQg Z3Vlc3RfcGh5c21hcF9tYXJrX3BvcHVsYXRlX29uX2RlbWFuZCgpIGdldHMg dGlnaHRlbmVkIGJleW9uZAp0aGUgaW1tZWRpYXRlIHB1cnBvc2Ugb2YgdGhp cyBjaGFuZ2UuCgpOb3RlIGFsc28gdGhhdCBJIGRpZG4ndCBpbnNwZWN0IGNv ZGUgd2hpY2ggaXNuJ3Qgc2VjdXJpdHkgc3VwcG9ydGVkLAplLmcuIHNoYXJp bmcsIHBhZ2luZywgb3IgYWx0cDJtLgoKVGhpcyBpcyBDVkUtMjAyMS0yODY5 NCAvIHBhcnQgb2YgWFNBLTM3OC4KClNpZ25lZC1vZmYtYnk6IEphbiBCZXVs aWNoIDxqYmV1bGljaEBzdXNlLmNvbT4KUmV2aWV3ZWQtYnk6IFBhdWwgRHVy cmFudCA8cGF1bEB4ZW4ub3JnPgoKLS0tIGEveGVuL2FyY2gveDg2L21tLmMK KysrIGIveGVuL2FyY2gveDg2L21tLmMKQEAgLTQ3NzAsNyArNDc3MCw5IEBA IGludCB4ZW5tZW1fYWRkX3RvX3BoeXNtYXBfb25lKAogCiAgICAgLyogUmVt b3ZlIHByZXZpb3VzbHkgbWFwcGVkIHBhZ2UgaWYgaXQgd2FzIHByZXNlbnQu ICovCiAgICAgcHJldl9tZm4gPSBnZXRfZ2ZuKGQsIGdmbl94KGdwZm4pLCAm cDJtdCk7Ci0gICAgaWYgKCBtZm5fdmFsaWQocHJldl9tZm4pICkKKyAgICBp ZiAoIHAybXQgPT0gcDJtX21taW9fZGlyZWN0ICkKKyAgICAgICAgcmMgPSAt RVBFUk07CisgICAgZWxzZSBpZiAoIG1mbl92YWxpZChwcmV2X21mbikgKQog ICAgIHsKICAgICAgICAgaWYgKCBpc194ZW5faGVhcF9tZm4ocHJldl9tZm4p ICkKICAgICAgICAgICAgIC8qIFhlbiBoZWFwIGZyYW1lcyBhcmUgc2ltcGx5 IHVuaG9va2VkIGZyb20gdGhpcyBwaHlzIHNsb3QuICovCi0tLSBhL3hlbi9h cmNoL3g4Ni9tbS9wMm0uYworKysgYi94ZW4vYXJjaC94ODYvbW0vcDJtLmMK QEAgLTc5Niw3ICs3OTYsOCBAQCBwMm1fcmVtb3ZlX3BhZ2Uoc3RydWN0IHAy bV9kb21haW4gKnAybSwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICZjdXJfb3JkZXIsIE5VTEwpOwogCiAgICAgICAgIGlm ICggcDJtX2lzX3ZhbGlkKHQpICYmCi0gICAgICAgICAgICAgKCFtZm5fdmFs aWQoX21mbihtZm4pKSB8fCBtZm4gKyBpICE9IG1mbl94KG1mbl9yZXR1cm4p KSApCisgICAgICAgICAgICAgKCFtZm5fdmFsaWQoX21mbihtZm4pKSB8fCB0 ID09IHAybV9tbWlvX2RpcmVjdCB8fAorICAgICAgICAgICAgICBtZm4gKyBp ICE9IG1mbl94KG1mbl9yZXR1cm4pKSApCiAgICAgICAgICAgICByZXR1cm4g LUVJTFNFUTsKIAogICAgICAgICBpICs9ICgxVUwgPDwgY3VyX29yZGVyKSAt ICgoZ2ZuX2wgKyBpKSAmICgoMVVMIDw8IGN1cl9vcmRlcikgLSAxKSk7CkBA IC04OTAsNyArODkxLDcgQEAgZ3Vlc3RfcGh5c21hcF9hZGRfZW50cnkoc3Ry dWN0IGRvbWFpbiAqZAogICAgIGlmICggcDJtX2lzX2ZvcmVpZ24odCkgKQog ICAgICAgICByZXR1cm4gLUVJTlZBTDsKIAotICAgIGlmICggIW1mbl92YWxp ZChtZm4pICkKKyAgICBpZiAoICFtZm5fdmFsaWQobWZuKSB8fCB0ID09IHAy bV9tbWlvX2RpcmVjdCApCiAgICAgewogICAgICAgICBBU1NFUlRfVU5SRUFD SEFCTEUoKTsKICAgICAgICAgcmV0dXJuIC1FSU5WQUw7CkBAIC05MzYsNyAr OTM3LDcgQEAgZ3Vlc3RfcGh5c21hcF9hZGRfZW50cnkoc3RydWN0IGRvbWFp biAqZAogICAgICAgICB9CiAgICAgICAgIGlmICggcDJtX2lzX3NwZWNpYWwo b3QpICkKICAgICAgICAgewotICAgICAgICAgICAgLyogRG9uJ3QgcGVybWl0 IHVubWFwcGluZyBncmFudC9mb3JlaWduIHRoaXMgd2F5LiAqLworICAgICAg ICAgICAgLyogRG9uJ3QgcGVybWl0IHVubWFwcGluZyBncmFudC9mb3JlaWdu L2RpcmVjdC1NTUlPIHRoaXMgd2F5LiAqLwogICAgICAgICAgICAgZG9tYWlu X2NyYXNoKGQpOwogICAgICAgICAgICAgcDJtX3VubG9jayhwMm0pOwogICAg ICAgICAgICAgCkBAIC0xMzg1LDggKzEzODYsOCBAQCBpbnQgc2V0X2lkZW50 aXR5X3AybV9lbnRyeShzdHJ1Y3QgZG9tYWluCiAgKiAgICBvcmRlcisxICBm b3IgY2FsbGVyIHRvIHJldHJ5IHdpdGggb3JkZXIgKGd1YXJhbnRlZWQgc21h bGxlciB0aGFuCiAgKiAgICAgICAgICAgICB0aGUgb3JkZXIgdmFsdWUgcGFz c2VkIGluKQogICovCi1pbnQgY2xlYXJfbW1pb19wMm1fZW50cnkoc3RydWN0 IGRvbWFpbiAqZCwgdW5zaWduZWQgbG9uZyBnZm5fbCwgbWZuX3QgbWZuLAot ICAgICAgICAgICAgICAgICAgICAgICAgIHVuc2lnbmVkIGludCBvcmRlcikK K3N0YXRpYyBpbnQgY2xlYXJfbW1pb19wMm1fZW50cnkoc3RydWN0IGRvbWFp biAqZCwgdW5zaWduZWQgbG9uZyBnZm5fbCwKKyAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgbWZuX3QgbWZuLCB1bnNpZ25lZCBpbnQgb3JkZXIp CiB7CiAgICAgaW50IHJjID0gLUVJTlZBTDsKICAgICBnZm5fdCBnZm4gPSBf Z2ZuKGdmbl9sKTsKLS0tIGEveGVuL2FyY2gveDg2L21tL3AybS1wb2QuYwor KysgYi94ZW4vYXJjaC94ODYvbW0vcDJtLXBvZC5jCkBAIC0xMjk1LDE3ICsx Mjk1LDE3IEBAIGd1ZXN0X3BoeXNtYXBfbWFya19wb3B1bGF0ZV9vbl9kZW1h bmQoc3QKIAogICAgICAgICBwMm0tPmdldF9lbnRyeShwMm0sIGdmbl9hZGQo Z2ZuLCBpKSwgJm90LCAmYSwgMCwgJmN1cl9vcmRlciwgTlVMTCk7CiAgICAg ICAgIG4gPSAxVUwgPDwgbWluKG9yZGVyLCBjdXJfb3JkZXIpOwotICAgICAg ICBpZiAoIHAybV9pc19yYW0ob3QpICkKKyAgICAgICAgaWYgKCBvdCA9PSBw Mm1fcG9wdWxhdGVfb25fZGVtYW5kICkKKyAgICAgICAgeworICAgICAgICAg ICAgLyogQ291bnQgaG93IG1hbnkgUG9EIGVudHJpZXMgd2UnbGwgYmUgcmVw bGFjaW5nIGlmIHN1Y2Nlc3NmdWwgKi8KKyAgICAgICAgICAgIHBvZF9jb3Vu dCArPSBuOworICAgICAgICB9CisgICAgICAgIGVsc2UgaWYgKCBvdCAhPSBw Mm1faW52YWxpZCAmJiBvdCAhPSBwMm1fbW1pb19kbSApCiAgICAgICAgIHsK ICAgICAgICAgICAgIFAyTV9ERUJVRygiZ2ZuX3RvX21mbiByZXR1cm5lZCB0 eXBlICVkIVxuIiwgb3QpOwogICAgICAgICAgICAgcmMgPSAtRUJVU1k7CiAg ICAgICAgICAgICBnb3RvIG91dDsKICAgICAgICAgfQotICAgICAgICBlbHNl IGlmICggb3QgPT0gcDJtX3BvcHVsYXRlX29uX2RlbWFuZCApCi0gICAgICAg IHsKLSAgICAgICAgICAgIC8qIENvdW50IGhvdyBtYW4gUG9EIGVudHJpZXMg d2UnbGwgYmUgcmVwbGFjaW5nIGlmIHN1Y2Nlc3NmdWwgKi8KLSAgICAgICAg ICAgIHBvZF9jb3VudCArPSBuOwotICAgICAgICB9CiAgICAgfQogCiAgICAg LyogTm93LCBhY3R1YWxseSBkbyB0aGUgdHdvLXdheSBtYXBwaW5nICovCi0t LSBhL3hlbi9jb21tb24vbWVtb3J5LmMKKysrIGIveGVuL2NvbW1vbi9tZW1v cnkuYwpAQCAtMzI4LDcgKzMyOCw3IEBAIGludCBndWVzdF9yZW1vdmVfcGFn ZShzdHJ1Y3QgZG9tYWluICpkLAogICAgIH0KICAgICBpZiAoIHAybXQgPT0g cDJtX21taW9fZGlyZWN0ICkKICAgICB7Ci0gICAgICAgIHJjID0gY2xlYXJf bW1pb19wMm1fZW50cnkoZCwgZ21mbiwgbWZuLCBQQUdFX09SREVSXzRLKTsK KyAgICAgICAgcmMgPSAtRVBFUk07CiAgICAgICAgIGdvdG8gb3V0X3B1dF9n Zm47CiAgICAgfQogI2Vsc2UKQEAgLTE3MjAsNiArMTcyMCwxNSBAQCBpbnQg Y2hlY2tfZ2V0X3BhZ2VfZnJvbV9nZm4oc3RydWN0IGRvbWFpCiAgICAgICAg IHJldHVybiAtRUFHQUlOOwogICAgIH0KICNlbmRpZgorI2lmZGVmIENPTkZJ R19YODYKKyAgICBpZiAoIHAybXQgPT0gcDJtX21taW9fZGlyZWN0ICkKKyAg ICB7CisgICAgICAgIGlmICggcGFnZSApCisgICAgICAgICAgICBwdXRfcGFn ZShwYWdlKTsKKworICAgICAgICByZXR1cm4gLUVQRVJNOworICAgIH0KKyNl bmRpZgogCiAgICAgaWYgKCAhcGFnZSApCiAgICAgICAgIHJldHVybiAtRUlO VkFMOwotLS0gYS94ZW4vaW5jbHVkZS9hc20teDg2L3AybS5oCisrKyBiL3hl bi9pbmNsdWRlL2FzbS14ODYvcDJtLmgKQEAgLTE0Myw3ICsxNDMsOCBAQCB0 eXBlZGVmIHVuc2lnbmVkIGludCBwMm1fcXVlcnlfdDsKIAogLyogVHlwZXMg ZXN0YWJsaXNoZWQvY2xlYW5lZCB1cCB2aWEgc3BlY2lhbCBhY2Nlc3NvcnMu ICovCiAjZGVmaW5lIFAyTV9TUEVDSUFMX1RZUEVTIChQMk1fR1JBTlRfVFlQ RVMgfCBcCi0gICAgICAgICAgICAgICAgICAgICAgICAgICBwMm1fdG9fbWFz ayhwMm1fbWFwX2ZvcmVpZ24pKQorICAgICAgICAgICAgICAgICAgICAgICAg ICAgcDJtX3RvX21hc2socDJtX21hcF9mb3JlaWduKSB8IFwKKyAgICAgICAg ICAgICAgICAgICAgICAgICAgIHAybV90b19tYXNrKHAybV9tbWlvX2RpcmVj dCkpCiAKIC8qIFZhbGlkIHR5cGVzIG5vdCBuZWNlc3NhcmlseSBhc3NvY2lh dGVkIHdpdGggYSAodmFsaWQpIE1GTi4gKi8KICNkZWZpbmUgUDJNX0lOVkFM SURfTUZOX1RZUEVTIChQMk1fUE9EX1RZUEVTICAgICAgICAgICAgICAgICAg XApAQCAtNjQ5LDggKzY1MCw2IEBAIGludCBzZXRfZm9yZWlnbl9wMm1fZW50 cnkoc3RydWN0IGRvbWFpbgogLyogU2V0IG1taW8gYWRkcmVzc2VzIGluIHRo ZSBwMm0gdGFibGUgKGZvciBwYXNzLXRocm91Z2gpICovCiBpbnQgc2V0X21t aW9fcDJtX2VudHJ5KHN0cnVjdCBkb21haW4gKmQsIHVuc2lnbmVkIGxvbmcg Z2ZuLCBtZm5fdCBtZm4sCiAgICAgICAgICAgICAgICAgICAgICAgIHVuc2ln bmVkIGludCBvcmRlciwgcDJtX2FjY2Vzc190IGFjY2Vzcyk7Ci1pbnQgY2xl YXJfbW1pb19wMm1fZW50cnkoc3RydWN0IGRvbWFpbiAqZCwgdW5zaWduZWQg bG9uZyBnZm4sIG1mbl90IG1mbiwKLSAgICAgICAgICAgICAgICAgICAgICAg ICB1bnNpZ25lZCBpbnQgb3JkZXIpOwogCiAvKiBTZXQgaWRlbnRpdHkgYWRk cmVzc2VzIGluIHRoZSBwMm0gdGFibGUgKGZvciBwYXNzLXRocm91Z2gpICov CiBpbnQgc2V0X2lkZW50aXR5X3AybV9lbnRyeShzdHJ1Y3QgZG9tYWluICpk LCB1bnNpZ25lZCBsb25nIGdmbiwK --=separator Content-Type: application/octet-stream; name="xsa378/xsa378-4.14-1.patch" Content-Disposition: attachment; filename="xsa378/xsa378-4.14-1.patch" Content-Transfer-Encoding: base64 RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0 OiBBTUQvSU9NTVU6IGNvcnJlY3QgZ2xvYmFsIGV4Y2x1c2lvbiByYW5nZSBl eHRlbmRpbmcKCkJlc2lkZXMgdW5pdHkgbWFwcGluZyByZWdpb25zLCB0aGUg QU1EIElPTU1VIHNwZWMgYWxzbyBwcm92aWRlcyBmb3IKZXhjbHVzaW9uIHJh bmdlcyAoYXJlYXMgb2YgbWVtb3J5IG5vdCB0byBiZSBzdWJqZWN0IHRvIERN QSB0cmFuc2xhdGlvbikKdG8gYmUgc3BlY2lmaWVkIGJ5IGZpcm13YXJlIGlu IHRoZSBBQ1BJIHRhYmxlcy4gVGhlIHNwZWMgZG9lcyBub3QgcHV0CmFueSBj b25zdHJhaW50cyBvbiB0aGUgbnVtYmVyIG9mIHN1Y2ggcmVnaW9ucy4KCkJs aW5kbHkgYXNzdW1pbmcgYWxsIGFkZHJlc3NlcyBiZXR3ZWVuIGFueSB0d28g c3VjaCByYW5nZXMgc2hvdWxkIGFsc28KYmUgZXhjbHVkZWQgY2FuJ3QgYmUg cmlnaHQuIFNpbmNlIGhhcmR3YXJlIGhhcyByb29tIGZvciBqdXN0IGEgc2lu Z2xlCnN1Y2ggcmFuZ2UgKGNvbXByaXNlZCBvZiB0aGUgRXhjbHVzaW9uIEJh c2UgUmVnaXN0ZXIgYW5kIHRoZSBFeGNsdXNpb24KUmFuZ2UgTGltaXQgUmVn aXN0ZXIpLCBjb21iaW5lIG9ubHkgYWRqYWNlbnQgb3Igb3ZlcmxhcHBpbmcg cmVnaW9ucyAoZm9yCm5vdzsgdGhpcyBtYXkgcmVxdWlyZSBmdXJ0aGVyIGFk anVzdG1lbnQgaW4gY2FzZSB0YWJsZSBlbnRyaWVzIGFyZW4ndApzb3J0ZWQg YnkgYWRkcmVzcykgd2l0aCBtYXRjaGluZyBleGNsdXNpb25fYWxsb3dfYWxs IHNldHRpbmdzLiBUaGlzCnJlcXVpcmVzIGJ1YmJsaW5nIHVwIGVycm9yIGlu ZGljYXRvcnMsIHN1Y2ggdGhhdCBJT01NVSBpbml0IGNhbiBiZQpmYWlsZWQg d2hlbiBjb25jYXRlbmF0aW9uIHdhc24ndCBwb3NzaWJsZS4KCkZ1cnRoZXJt b3JlLCBzaW5jZSB0aGUgZXhjbHVzaW9uIHJhbmdlIHNwZWNpZmllZCBpbiBJ T01NVSByZWdpc3RlcnMKaW1wbGllcyBSL1cgYWNjZXNzLCByZWplY3QgcmVx dWVzdHMgYXNraW5nIGZvciBsZXNzIHBlcm1pc3Npb25zICh0aGlzCndpbGwg YmUgYnJvdWdodCBjbG9zZXIgdG8gdGhlIHNwZWMgYnkgYSBzdWJzZXF1ZW50 IGNoYW5nZSkuCgpUaGlzIGlzIHBhcnQgb2YgWFNBLTM3OCAvIENWRS0yMDIx LTI4Njk1LgoKU2lnbmVkLW9mZi1ieTogSmFuIEJldWxpY2ggPGpiZXVsaWNo QHN1c2UuY29tPgpSZXZpZXdlZC1ieTogUGF1bCBEdXJyYW50IDxwYXVsQHhl bi5vcmc+CgotLS0gYS94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC9hbWQvaW9t bXVfYWNwaS5jCisrKyBiL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL2FtZC9p b21tdV9hY3BpLmMKQEAgLTExNywxMiArMTE3LDIxIEBAIHN0YXRpYyBzdHJ1 Y3QgYW1kX2lvbW11ICogX19pbml0IGZpbmRfaW8KICAgICByZXR1cm4gTlVM TDsKIH0KIAotc3RhdGljIHZvaWQgX19pbml0IHJlc2VydmVfaW9tbXVfZXhj bHVzaW9uX3JhbmdlKAotICAgIHN0cnVjdCBhbWRfaW9tbXUgKmlvbW11LCB1 aW50NjRfdCBiYXNlLCB1aW50NjRfdCBsaW1pdCkKK3N0YXRpYyBpbnQgX19p bml0IHJlc2VydmVfaW9tbXVfZXhjbHVzaW9uX3JhbmdlKAorICAgIHN0cnVj dCBhbWRfaW9tbXUgKmlvbW11LCB1aW50NjRfdCBiYXNlLCB1aW50NjRfdCBs aW1pdCwKKyAgICBib29sIGFsbCwgYm9vbCBpdywgYm9vbCBpcikKIHsKKyAg ICBpZiAoICFpciB8fCAhaXcgKQorICAgICAgICByZXR1cm4gLUVQRVJNOwor CiAgICAgLyogbmVlZCB0byBleHRlbmQgZXhjbHVzaW9uIHJhbmdlPyAqLwog ICAgIGlmICggaW9tbXUtPmV4Y2x1c2lvbl9lbmFibGUgKQogICAgIHsKKyAg ICAgICAgaWYgKCBpb21tdS0+ZXhjbHVzaW9uX2xpbWl0ICsgUEFHRV9TSVpF IDwgYmFzZSB8fAorICAgICAgICAgICAgIGxpbWl0ICsgUEFHRV9TSVpFIDwg aW9tbXUtPmV4Y2x1c2lvbl9iYXNlIHx8CisgICAgICAgICAgICAgaW9tbXUt PmV4Y2x1c2lvbl9hbGxvd19hbGwgIT0gYWxsICkKKyAgICAgICAgICAgIHJl dHVybiAtRUJVU1k7CisKICAgICAgICAgaWYgKCBpb21tdS0+ZXhjbHVzaW9u X2Jhc2UgPCBiYXNlICkKICAgICAgICAgICAgIGJhc2UgPSBpb21tdS0+ZXhj bHVzaW9uX2Jhc2U7CiAgICAgICAgIGlmICggaW9tbXUtPmV4Y2x1c2lvbl9s aW1pdCA+IGxpbWl0ICkKQEAgLTEzMCwxNiArMTM5LDExIEBAIHN0YXRpYyB2 b2lkIF9faW5pdCByZXNlcnZlX2lvbW11X2V4Y2x1c2kKICAgICB9CiAKICAg ICBpb21tdS0+ZXhjbHVzaW9uX2VuYWJsZSA9IElPTU1VX0NPTlRST0xfRU5B QkxFRDsKKyAgICBpb21tdS0+ZXhjbHVzaW9uX2FsbG93X2FsbCA9IGFsbDsK ICAgICBpb21tdS0+ZXhjbHVzaW9uX2Jhc2UgPSBiYXNlOwogICAgIGlvbW11 LT5leGNsdXNpb25fbGltaXQgPSBsaW1pdDsKLX0KIAotc3RhdGljIHZvaWQg X19pbml0IHJlc2VydmVfaW9tbXVfZXhjbHVzaW9uX3JhbmdlX2FsbCgKLSAg ICBzdHJ1Y3QgYW1kX2lvbW11ICppb21tdSwKLSAgICB1bnNpZ25lZCBsb25n IGJhc2UsIHVuc2lnbmVkIGxvbmcgbGltaXQpCi17Ci0gICAgcmVzZXJ2ZV9p b21tdV9leGNsdXNpb25fcmFuZ2UoaW9tbXUsIGJhc2UsIGxpbWl0KTsKLSAg ICBpb21tdS0+ZXhjbHVzaW9uX2FsbG93X2FsbCA9IElPTU1VX0NPTlRST0xf RU5BQkxFRDsKKyAgICByZXR1cm4gMDsKIH0KIAogc3RhdGljIHZvaWQgX19p bml0IHJlc2VydmVfdW5pdHlfbWFwX2Zvcl9kZXZpY2UoCkBAIC0xNzcsNiAr MTgxLDcgQEAgc3RhdGljIGludCBfX2luaXQgcmVnaXN0ZXJfZXhjbHVzaW9u X3JhbgogICAgIHVuc2lnbmVkIGxvbmcgcmFuZ2VfdG9wLCBpb21tdV90b3As IGxlbmd0aDsKICAgICBzdHJ1Y3QgYW1kX2lvbW11ICppb21tdTsKICAgICB1 bnNpZ25lZCBpbnQgYmRmOworICAgIGludCByYyA9IDA7CiAKICAgICAvKiBp cyBwYXJ0IG9mIGV4Y2x1c2lvbiByYW5nZSBpbnNpZGUgb2YgSU9NTVUgdmly dHVhbCBhZGRyZXNzIHNwYWNlPyAqLwogICAgIC8qIG5vdGU6ICdsaW1pdCcg cGFyYW1ldGVyIGlzIGFzc3VtZWQgdG8gYmUgcGFnZS1hbGlnbmVkICovCkBA IC0xOTgsMTAgKzIwMywxNSBAQCBzdGF0aWMgaW50IF9faW5pdCByZWdpc3Rl cl9leGNsdXNpb25fcmFuCiAgICAgaWYgKCBsaW1pdCA+PSBpb21tdV90b3Ag KQogICAgIHsKICAgICAgICAgZm9yX2VhY2hfYW1kX2lvbW11KCBpb21tdSAp Ci0gICAgICAgICAgICByZXNlcnZlX2lvbW11X2V4Y2x1c2lvbl9yYW5nZV9h bGwoaW9tbXUsIGJhc2UsIGxpbWl0KTsKKyAgICAgICAgeworICAgICAgICAg ICAgcmMgPSByZXNlcnZlX2lvbW11X2V4Y2x1c2lvbl9yYW5nZShpb21tdSwg YmFzZSwgbGltaXQsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIHRydWUgLyogYWxsICovLCBpdywgaXIpOworICAg ICAgICAgICAgaWYgKCByYyApCisgICAgICAgICAgICAgICAgYnJlYWs7Cisg ICAgICAgIH0KICAgICB9CiAKLSAgICByZXR1cm4gMDsKKyAgICByZXR1cm4g cmM7CiB9CiAKIHN0YXRpYyBpbnQgX19pbml0IHJlZ2lzdGVyX2V4Y2x1c2lv bl9yYW5nZV9mb3JfZGV2aWNlKApAQCAtMjEyLDYgKzIyMiw3IEBAIHN0YXRp YyBpbnQgX19pbml0IHJlZ2lzdGVyX2V4Y2x1c2lvbl9yYW4KICAgICB1bnNp Z25lZCBsb25nIHJhbmdlX3RvcCwgaW9tbXVfdG9wLCBsZW5ndGg7CiAgICAg c3RydWN0IGFtZF9pb21tdSAqaW9tbXU7CiAgICAgdTE2IHJlcTsKKyAgICBp bnQgcmMgPSAwOwogCiAgICAgaW9tbXUgPSBmaW5kX2lvbW11X2Zvcl9kZXZp Y2Uoc2VnLCBiZGYpOwogICAgIGlmICggIWlvbW11ICkKQEAgLTI0MSwxMiAr MjUyLDEzIEBAIHN0YXRpYyBpbnQgX19pbml0IHJlZ2lzdGVyX2V4Y2x1c2lv bl9yYW4KICAgICAvKiByZWdpc3RlciBJT01NVSBleGNsdXNpb24gcmFuZ2Ug c2V0dGluZ3MgZm9yIGRldmljZSAqLwogICAgIGlmICggbGltaXQgPj0gaW9t bXVfdG9wICApCiAgICAgewotICAgICAgICByZXNlcnZlX2lvbW11X2V4Y2x1 c2lvbl9yYW5nZShpb21tdSwgYmFzZSwgbGltaXQpOworICAgICAgICByYyA9 IHJlc2VydmVfaW9tbXVfZXhjbHVzaW9uX3JhbmdlKGlvbW11LCBiYXNlLCBs aW1pdCwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICBmYWxzZSAvKiBhbGwgKi8sIGl3LCBpcik7CiAgICAgICAgIGl2cnNf bWFwcGluZ3NbYmRmXS5kdGVfYWxsb3dfZXhjbHVzaW9uID0gdHJ1ZTsKICAg ICAgICAgaXZyc19tYXBwaW5nc1tyZXFdLmR0ZV9hbGxvd19leGNsdXNpb24g PSB0cnVlOwogICAgIH0KIAotICAgIHJldHVybiAwOworICAgIHJldHVybiBy YzsKIH0KIAogc3RhdGljIGludCBfX2luaXQgcmVnaXN0ZXJfZXhjbHVzaW9u X3JhbmdlX2Zvcl9pb21tdV9kZXZpY2VzKApAQCAtMjU2LDYgKzI2OCw3IEBA IHN0YXRpYyBpbnQgX19pbml0IHJlZ2lzdGVyX2V4Y2x1c2lvbl9yYW4KICAg ICB1bnNpZ25lZCBsb25nIHJhbmdlX3RvcCwgaW9tbXVfdG9wLCBsZW5ndGg7 CiAgICAgdW5zaWduZWQgaW50IGJkZjsKICAgICB1MTYgcmVxOworICAgIGlu dCByYyA9IDA7CiAKICAgICAvKiBpcyBwYXJ0IG9mIGV4Y2x1c2lvbiByYW5n ZSBpbnNpZGUgb2YgSU9NTVUgdmlydHVhbCBhZGRyZXNzIHNwYWNlPyAqLwog ICAgIC8qIG5vdGU6ICdsaW1pdCcgcGFyYW1ldGVyIGlzIGFzc3VtZWQgdG8g YmUgcGFnZS1hbGlnbmVkICovCkBAIC0yODYsOCArMjk5LDEwIEBAIHN0YXRp YyBpbnQgX19pbml0IHJlZ2lzdGVyX2V4Y2x1c2lvbl9yYW4KIAogICAgIC8q IHJlZ2lzdGVyIElPTU1VIGV4Y2x1c2lvbiByYW5nZSBzZXR0aW5ncyAqLwog ICAgIGlmICggbGltaXQgPj0gaW9tbXVfdG9wICkKLSAgICAgICAgcmVzZXJ2 ZV9pb21tdV9leGNsdXNpb25fcmFuZ2VfYWxsKGlvbW11LCBiYXNlLCBsaW1p dCk7Ci0gICAgcmV0dXJuIDA7CisgICAgICAgIHJjID0gcmVzZXJ2ZV9pb21t dV9leGNsdXNpb25fcmFuZ2UoaW9tbXUsIGJhc2UsIGxpbWl0LAorICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHRydWUgLyog YWxsICovLCBpdywgaXIpOworCisgICAgcmV0dXJuIHJjOwogfQogCiBzdGF0 aWMgaW50IF9faW5pdCBwYXJzZV9pdm1kX2RldmljZV9zZWxlY3QoCg== --=separator Content-Type: application/octet-stream; name="xsa378/xsa378-4.14-2.patch" Content-Disposition: attachment; filename="xsa378/xsa378-4.14-2.patch" Content-Transfer-Encoding: base64 RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0 OiBBTUQvSU9NTVU6IGNvcnJlY3QgZGV2aWNlIHVuaXR5IG1hcCBoYW5kbGlu ZwoKQmxpbmRseSBhc3N1bWluZyBhbGwgYWRkcmVzc2VzIGJldHdlZW4gYW55 IHR3byBzdWNoIHJhbmdlcywgc3BlY2lmaWVkIGJ5CmZpcm13YXJlIGluIHRo ZSBBQ1BJIHRhYmxlcywgc2hvdWxkIGFsc28gYmUgdW5pdHktbWFwcGVkIGNh bid0IGJlIHJpZ2h0LgpOb3IgY2FuIGl0IGJlIGNvcnJlY3QgdG8gbWVyZ2Ug cmFuZ2VzIHdpdGggZGlmZmVyaW5nIHBlcm1pc3Npb25zLiBUcmFjawpyYW5n ZXMgaW5kaXZpZHVhbGx5OyBkb24ndCBtZXJnZSBhdCBhbGwsIGJ1dCBjaGVj ayBmb3Igb3ZlcmxhcHMgaW5zdGVhZC4KVGhpcyByZXF1aXJlcyBidWJibGlu ZyB1cCBlcnJvciBpbmRpY2F0b3JzLCBzdWNoIHRoYXQgSU9NTVUgaW5pdCBj YW4gYmUKZmFpbGVkIHdoZW4gYWxsb2NhdGlvbiBvZiBhIG5ldyB0cmFja2lu ZyBzdHJ1Y3Qgd2Fzbid0IHBvc3NpYmxlLCBvciBhbgpvdmVybGFwIHdhcyBk ZXRlY3RlZC4KCkF0IHRoaXMgb2NjYXNpb24gYWxzbyBzdG9wIGlnbm9yaW5n CmFtZF9pb21tdV9yZXNlcnZlX2RvbWFpbl91bml0eV9tYXAoKSdzIHJldHVy biB2YWx1ZS4KClRoaXMgaXMgcGFydCBvZiBYU0EtMzc4IC8gQ1ZFLTIwMjEt Mjg2OTUuCgpTaWduZWQtb2ZmLWJ5OiBKYW4gQmV1bGljaCA8amJldWxpY2hA c3VzZS5jb20+ClJldmlld2VkLWJ5OiBHZW9yZ2UgRHVubGFwIDxnZW9yZ2Uu ZHVubGFwQGNpdHJpeC5jb20+ClJldmlld2VkLWJ5OiBQYXVsIER1cnJhbnQg PHBhdWxAeGVuLm9yZz4KCi0tLSBhL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdo L2FtZC9pb21tdS5oCisrKyBiL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL2Ft ZC9pb21tdS5oCkBAIC0xMDcsMjAgKzEwNywyNCBAQCBzdHJ1Y3QgYW1kX2lv bW11IHsKICAgICBzdHJ1Y3QgbGlzdF9oZWFkIGF0c19kZXZpY2VzOwogfTsK IAorc3RydWN0IGl2cnNfdW5pdHlfbWFwIHsKKyAgICBib29sIHJlYWQ6MTsK KyAgICBib29sIHdyaXRlOjE7CisgICAgcGFkZHJfdCBhZGRyOworICAgIHVu c2lnbmVkIGxvbmcgbGVuZ3RoOworICAgIHN0cnVjdCBpdnJzX3VuaXR5X21h cCAqbmV4dDsKK307CisKIHN0cnVjdCBpdnJzX21hcHBpbmdzIHsKICAgICB1 aW50MTZfdCBkdGVfcmVxdWVzdG9yX2lkOwogICAgIGJvb2wgdmFsaWQ6MTsK ICAgICBib29sIGR0ZV9hbGxvd19leGNsdXNpb246MTsKLSAgICBib29sIHVu aXR5X21hcF9lbmFibGU6MTsKLSAgICBib29sIHdyaXRlX3Blcm1pc3Npb246 MTsKLSAgICBib29sIHJlYWRfcGVybWlzc2lvbjoxOwogCiAgICAgLyogaXZo ZCBkZXZpY2UgZGF0YSBzZXR0aW5ncyAqLwogICAgIHVpbnQ4X3QgZGV2aWNl X2ZsYWdzOwogCi0gICAgdW5zaWduZWQgbG9uZyBhZGRyX3JhbmdlX3N0YXJ0 OwotICAgIHVuc2lnbmVkIGxvbmcgYWRkcl9yYW5nZV9sZW5ndGg7CiAgICAg c3RydWN0IGFtZF9pb21tdSAqaW9tbXU7CisgICAgc3RydWN0IGl2cnNfdW5p dHlfbWFwICp1bml0eV9tYXA7CiAKICAgICAvKiBwZXIgZGV2aWNlIGludGVy cnVwdCByZW1hcHBpbmcgdGFibGUgKi8KICAgICB2b2lkICppbnRyZW1hcF90 YWJsZTsKLS0tIGEveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvYW1kL2lvbW11 X2FjcGkuYworKysgYi94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC9hbWQvaW9t bXVfYWNwaS5jCkBAIC0xNDYsMzIgKzE0Niw0OCBAQCBzdGF0aWMgaW50IF9f aW5pdCByZXNlcnZlX2lvbW11X2V4Y2x1c2lvCiAgICAgcmV0dXJuIDA7CiB9 CiAKLXN0YXRpYyB2b2lkIF9faW5pdCByZXNlcnZlX3VuaXR5X21hcF9mb3Jf ZGV2aWNlKAotICAgIHUxNiBzZWcsIHUxNiBiZGYsIHVuc2lnbmVkIGxvbmcg YmFzZSwKLSAgICB1bnNpZ25lZCBsb25nIGxlbmd0aCwgdTggaXcsIHU4IGly KQorc3RhdGljIGludCBfX2luaXQgcmVzZXJ2ZV91bml0eV9tYXBfZm9yX2Rl dmljZSgKKyAgICB1aW50MTZfdCBzZWcsIHVpbnQxNl90IGJkZiwgdW5zaWdu ZWQgbG9uZyBiYXNlLAorICAgIHVuc2lnbmVkIGxvbmcgbGVuZ3RoLCBib29s IGl3LCBib29sIGlyKQogewogICAgIHN0cnVjdCBpdnJzX21hcHBpbmdzICpp dnJzX21hcHBpbmdzID0gZ2V0X2l2cnNfbWFwcGluZ3Moc2VnKTsKLSAgICB1 bnNpZ25lZCBsb25nIG9sZF90b3AsIG5ld190b3A7CisgICAgc3RydWN0IGl2 cnNfdW5pdHlfbWFwICp1bml0eV9tYXAgPSBpdnJzX21hcHBpbmdzW2JkZl0u dW5pdHlfbWFwOwogCi0gICAgLyogbmVlZCB0byBleHRlbmQgdW5pdHktbWFw cGVkIHJhbmdlPyAqLwotICAgIGlmICggaXZyc19tYXBwaW5nc1tiZGZdLnVu aXR5X21hcF9lbmFibGUgKQorICAgIC8qIENoZWNrIGZvciBvdmVybGFwcy4g Ki8KKyAgICBmb3IgKCA7IHVuaXR5X21hcDsgdW5pdHlfbWFwID0gdW5pdHlf bWFwLT5uZXh0ICkKICAgICB7Ci0gICAgICAgIG9sZF90b3AgPSBpdnJzX21h cHBpbmdzW2JkZl0uYWRkcl9yYW5nZV9zdGFydCArCi0gICAgICAgICAgICBp dnJzX21hcHBpbmdzW2JkZl0uYWRkcl9yYW5nZV9sZW5ndGg7Ci0gICAgICAg IG5ld190b3AgPSBiYXNlICsgbGVuZ3RoOwotICAgICAgICBpZiAoIG9sZF90 b3AgPiBuZXdfdG9wICkKLSAgICAgICAgICAgIG5ld190b3AgPSBvbGRfdG9w OwotICAgICAgICBpZiAoIGl2cnNfbWFwcGluZ3NbYmRmXS5hZGRyX3Jhbmdl X3N0YXJ0IDwgYmFzZSApCi0gICAgICAgICAgICBiYXNlID0gaXZyc19tYXBw aW5nc1tiZGZdLmFkZHJfcmFuZ2Vfc3RhcnQ7Ci0gICAgICAgIGxlbmd0aCA9 IG5ld190b3AgLSBiYXNlOwotICAgIH0KLQotICAgIC8qIGV4dGVuZCByL3cg cGVybWlzc2lvbXMgYW5kIGtlZXAgYWdncmVnYXRlICovCi0gICAgaXZyc19t YXBwaW5nc1tiZGZdLndyaXRlX3Blcm1pc3Npb24gPSBpdzsKLSAgICBpdnJz X21hcHBpbmdzW2JkZl0ucmVhZF9wZXJtaXNzaW9uID0gaXI7Ci0gICAgaXZy c19tYXBwaW5nc1tiZGZdLnVuaXR5X21hcF9lbmFibGUgPSB0cnVlOwotICAg IGl2cnNfbWFwcGluZ3NbYmRmXS5hZGRyX3JhbmdlX3N0YXJ0ID0gYmFzZTsK LSAgICBpdnJzX21hcHBpbmdzW2JkZl0uYWRkcl9yYW5nZV9sZW5ndGggPSBs ZW5ndGg7CisgICAgICAgIC8qCisgICAgICAgICAqIEV4YWN0IG1hdGNoZXMg YXJlIG9rYXkuIFRoaXMgY2FuIGluIHBhcnRpY3VsYXIgaGFwcGVuIHdoZW4K KyAgICAgICAgICogcmVnaXN0ZXJfZXhjbHVzaW9uX3JhbmdlX2Zvcl9kZXZp Y2UoKSBjYWxscyBoZXJlIHR3aWNlIGZvciB0aGUKKyAgICAgICAgICogc2Ft ZSAocyxiLGQsZikuCisgICAgICAgICAqLworICAgICAgICBpZiAoIGJhc2Ug PT0gdW5pdHlfbWFwLT5hZGRyICYmIGxlbmd0aCA9PSB1bml0eV9tYXAtPmxl bmd0aCAmJgorICAgICAgICAgICAgIGlyID09IHVuaXR5X21hcC0+cmVhZCAm JiBpdyA9PSB1bml0eV9tYXAtPndyaXRlICkKKyAgICAgICAgICAgIHJldHVy biAwOworCisgICAgICAgIGlmICggdW5pdHlfbWFwLT5hZGRyICsgdW5pdHlf bWFwLT5sZW5ndGggPiBiYXNlICYmCisgICAgICAgICAgICAgYmFzZSArIGxl bmd0aCA+IHVuaXR5X21hcC0+YWRkciApCisgICAgICAgIHsKKyAgICAgICAg ICAgIEFNRF9JT01NVV9ERUJVRygiSVZNRCBFcnJvcjogb3ZlcmxhcCBbJWx4 LCVseCkgdnMgWyVseCwlbHgpXG4iLAorICAgICAgICAgICAgICAgICAgICAg ICAgICAgIGJhc2UsIGJhc2UgKyBsZW5ndGgsIHVuaXR5X21hcC0+YWRkciwK KyAgICAgICAgICAgICAgICAgICAgICAgICAgICB1bml0eV9tYXAtPmFkZHIg KyB1bml0eV9tYXAtPmxlbmd0aCk7CisgICAgICAgICAgICByZXR1cm4gLUVQ RVJNOworICAgICAgICB9CisgICAgfQorCisgICAgLyogUG9wdWxhdGUgYW5k IGluc2VydCBhIG5ldyB1bml0eSBtYXAuICovCisgICAgdW5pdHlfbWFwID0g eG1hbGxvYyhzdHJ1Y3QgaXZyc191bml0eV9tYXApOworICAgIGlmICggIXVu aXR5X21hcCApCisgICAgICAgIHJldHVybiAtRU5PTUVNOworCisgICAgdW5p dHlfbWFwLT5yZWFkID0gaXI7CisgICAgdW5pdHlfbWFwLT53cml0ZSA9IGl3 OworICAgIHVuaXR5X21hcC0+YWRkciA9IGJhc2U7CisgICAgdW5pdHlfbWFw LT5sZW5ndGggPSBsZW5ndGg7CisgICAgdW5pdHlfbWFwLT5uZXh0ID0gaXZy c19tYXBwaW5nc1tiZGZdLnVuaXR5X21hcDsKKyAgICBpdnJzX21hcHBpbmdz W2JkZl0udW5pdHlfbWFwID0gdW5pdHlfbWFwOworCisgICAgcmV0dXJuIDA7 CiB9CiAKIHN0YXRpYyBpbnQgX19pbml0IHJlZ2lzdGVyX2V4Y2x1c2lvbl9y YW5nZV9mb3JfYWxsX2RldmljZXMoCkBAIC0xOTQsMTMgKzIxMCwxMyBAQCBz dGF0aWMgaW50IF9faW5pdCByZWdpc3Rlcl9leGNsdXNpb25fcmFuCiAgICAg ICAgIGxlbmd0aCA9IHJhbmdlX3RvcCAtIGJhc2U7CiAgICAgICAgIC8qIHJl c2VydmUgci93IHVuaXR5LW1hcHBlZCBwYWdlIGVudHJpZXMgZm9yIGRldmlj ZXMgKi8KICAgICAgICAgLyogbm90ZTogdGhlc2UgZW50cmllcyBhcmUgcGFy dCBvZiB0aGUgZXhjbHVzaW9uIHJhbmdlICovCi0gICAgICAgIGZvciAoIGJk ZiA9IDA7IGJkZiA8IGl2cnNfYmRmX2VudHJpZXM7IGJkZisrICkKLSAgICAg ICAgICAgIHJlc2VydmVfdW5pdHlfbWFwX2Zvcl9kZXZpY2Uoc2VnLCBiZGYs IGJhc2UsIGxlbmd0aCwgaXcsIGlyKTsKKyAgICAgICAgZm9yICggYmRmID0g MDsgIXJjICYmIGJkZiA8IGl2cnNfYmRmX2VudHJpZXM7IGJkZisrICkKKyAg ICAgICAgICAgIHJjID0gcmVzZXJ2ZV91bml0eV9tYXBfZm9yX2RldmljZShz ZWcsIGJkZiwgYmFzZSwgbGVuZ3RoLCBpdywgaXIpOwogICAgICAgICAvKiBw dXNoICdiYXNlJyBqdXN0IG91dHNpZGUgb2YgdmlydHVhbCBhZGRyZXNzIHNw YWNlICovCiAgICAgICAgIGJhc2UgPSBpb21tdV90b3A7CiAgICAgfQogICAg IC8qIHJlZ2lzdGVyIElPTU1VIGV4Y2x1c2lvbiByYW5nZSBzZXR0aW5ncyAq LwotICAgIGlmICggbGltaXQgPj0gaW9tbXVfdG9wICkKKyAgICBpZiAoICFy YyAmJiBsaW1pdCA+PSBpb21tdV90b3AgKQogICAgIHsKICAgICAgICAgZm9y X2VhY2hfYW1kX2lvbW11KCBpb21tdSApCiAgICAgICAgIHsKQEAgLTI0Miwx NSArMjU4LDE1IEBAIHN0YXRpYyBpbnQgX19pbml0IHJlZ2lzdGVyX2V4Y2x1 c2lvbl9yYW4KICAgICAgICAgbGVuZ3RoID0gcmFuZ2VfdG9wIC0gYmFzZTsK ICAgICAgICAgLyogcmVzZXJ2ZSB1bml0eS1tYXBwZWQgcGFnZSBlbnRyaWVz IGZvciBkZXZpY2UgKi8KICAgICAgICAgLyogbm90ZTogdGhlc2UgZW50cmll cyBhcmUgcGFydCBvZiB0aGUgZXhjbHVzaW9uIHJhbmdlICovCi0gICAgICAg IHJlc2VydmVfdW5pdHlfbWFwX2Zvcl9kZXZpY2Uoc2VnLCBiZGYsIGJhc2Us IGxlbmd0aCwgaXcsIGlyKTsKLSAgICAgICAgcmVzZXJ2ZV91bml0eV9tYXBf Zm9yX2RldmljZShzZWcsIHJlcSwgYmFzZSwgbGVuZ3RoLCBpdywgaXIpOwor ICAgICAgICByYyA9IHJlc2VydmVfdW5pdHlfbWFwX2Zvcl9kZXZpY2Uoc2Vn LCBiZGYsIGJhc2UsIGxlbmd0aCwgaXcsIGlyKSA/OgorICAgICAgICAgICAg IHJlc2VydmVfdW5pdHlfbWFwX2Zvcl9kZXZpY2Uoc2VnLCByZXEsIGJhc2Us IGxlbmd0aCwgaXcsIGlyKTsKIAogICAgICAgICAvKiBwdXNoICdiYXNlJyBq dXN0IG91dHNpZGUgb2YgdmlydHVhbCBhZGRyZXNzIHNwYWNlICovCiAgICAg ICAgIGJhc2UgPSBpb21tdV90b3A7CiAgICAgfQogCiAgICAgLyogcmVnaXN0 ZXIgSU9NTVUgZXhjbHVzaW9uIHJhbmdlIHNldHRpbmdzIGZvciBkZXZpY2Ug Ki8KLSAgICBpZiAoIGxpbWl0ID49IGlvbW11X3RvcCAgKQorICAgIGlmICgg IXJjICYmIGxpbWl0ID49IGlvbW11X3RvcCAgKQogICAgIHsKICAgICAgICAg cmMgPSByZXNlcnZlX2lvbW11X2V4Y2x1c2lvbl9yYW5nZShpb21tdSwgYmFz ZSwgbGltaXQsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgZmFsc2UgLyogYWxsICovLCBpdywgaXIpOwpAQCAtMjgxLDE1 ICsyOTcsMTUgQEAgc3RhdGljIGludCBfX2luaXQgcmVnaXN0ZXJfZXhjbHVz aW9uX3JhbgogICAgICAgICBsZW5ndGggPSByYW5nZV90b3AgLSBiYXNlOwog ICAgICAgICAvKiByZXNlcnZlIHIvdyB1bml0eS1tYXBwZWQgcGFnZSBlbnRy aWVzIGZvciBkZXZpY2VzICovCiAgICAgICAgIC8qIG5vdGU6IHRoZXNlIGVu dHJpZXMgYXJlIHBhcnQgb2YgdGhlIGV4Y2x1c2lvbiByYW5nZSAqLwotICAg ICAgICBmb3IgKCBiZGYgPSAwOyBiZGYgPCBpdnJzX2JkZl9lbnRyaWVzOyBi ZGYrKyApCisgICAgICAgIGZvciAoIGJkZiA9IDA7ICFyYyAmJiBiZGYgPCBp dnJzX2JkZl9lbnRyaWVzOyBiZGYrKyApCiAgICAgICAgIHsKICAgICAgICAg ICAgIGlmICggaW9tbXUgPT0gZmluZF9pb21tdV9mb3JfZGV2aWNlKGlvbW11 LT5zZWcsIGJkZikgKQogICAgICAgICAgICAgewotICAgICAgICAgICAgICAg IHJlc2VydmVfdW5pdHlfbWFwX2Zvcl9kZXZpY2UoaW9tbXUtPnNlZywgYmRm LCBiYXNlLCBsZW5ndGgsCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBpdywgaXIpOwogICAgICAgICAgICAgICAgIHJl cSA9IGdldF9pdnJzX21hcHBpbmdzKGlvbW11LT5zZWcpW2JkZl0uZHRlX3Jl cXVlc3Rvcl9pZDsKLSAgICAgICAgICAgICAgICByZXNlcnZlX3VuaXR5X21h cF9mb3JfZGV2aWNlKGlvbW11LT5zZWcsIHJlcSwgYmFzZSwgbGVuZ3RoLAot ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg aXcsIGlyKTsKKyAgICAgICAgICAgICAgICByYyA9IHJlc2VydmVfdW5pdHlf bWFwX2Zvcl9kZXZpY2UoaW9tbXUtPnNlZywgYmRmLCBiYXNlLCBsZW5ndGgs CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIGl3LCBpcikgPzoKKyAgICAgICAgICAgICAgICAgICAgIHJlc2Vy dmVfdW5pdHlfbWFwX2Zvcl9kZXZpY2UoaW9tbXUtPnNlZywgcmVxLCBiYXNl LCBsZW5ndGgsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIGl3LCBpcik7CiAgICAgICAgICAgICB9CiAgICAg ICAgIH0KIApAQCAtMjk4LDcgKzMxNCw3IEBAIHN0YXRpYyBpbnQgX19pbml0 IHJlZ2lzdGVyX2V4Y2x1c2lvbl9yYW4KICAgICB9CiAKICAgICAvKiByZWdp c3RlciBJT01NVSBleGNsdXNpb24gcmFuZ2Ugc2V0dGluZ3MgKi8KLSAgICBp ZiAoIGxpbWl0ID49IGlvbW11X3RvcCApCisgICAgaWYgKCAhcmMgJiYgbGlt aXQgPj0gaW9tbXVfdG9wICkKICAgICAgICAgcmMgPSByZXNlcnZlX2lvbW11 X2V4Y2x1c2lvbl9yYW5nZShpb21tdSwgYmFzZSwgbGltaXQsCiAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdHJ1ZSAvKiBh bGwgKi8sIGl3LCBpcik7CiAKLS0tIGEveGVuL2RyaXZlcnMvcGFzc3Rocm91 Z2gvYW1kL3BjaV9hbWRfaW9tbXUuYworKysgYi94ZW4vZHJpdmVycy9wYXNz dGhyb3VnaC9hbWQvcGNpX2FtZF9pb21tdS5jCkBAIC0zNjYsMTUgKzM2Niwx NyBAQCBzdGF0aWMgaW50IGFtZF9pb21tdV9hc3NpZ25fZGV2aWNlKHN0cnVj CiAgICAgc3RydWN0IGl2cnNfbWFwcGluZ3MgKml2cnNfbWFwcGluZ3MgPSBn ZXRfaXZyc19tYXBwaW5ncyhwZGV2LT5zZWcpOwogICAgIGludCBiZGYgPSBQ Q0lfQkRGMihwZGV2LT5idXMsIGRldmZuKTsKICAgICBpbnQgcmVxX2lkID0g Z2V0X2RtYV9yZXF1ZXN0b3JfaWQocGRldi0+c2VnLCBiZGYpOworICAgIGNv bnN0IHN0cnVjdCBpdnJzX3VuaXR5X21hcCAqdW5pdHlfbWFwOwogCi0gICAg aWYgKCBpdnJzX21hcHBpbmdzW3JlcV9pZF0udW5pdHlfbWFwX2VuYWJsZSAp CisgICAgZm9yICggdW5pdHlfbWFwID0gaXZyc19tYXBwaW5nc1tyZXFfaWRd LnVuaXR5X21hcDsgdW5pdHlfbWFwOworICAgICAgICAgIHVuaXR5X21hcCA9 IHVuaXR5X21hcC0+bmV4dCApCiAgICAgewotICAgICAgICBhbWRfaW9tbXVf cmVzZXJ2ZV9kb21haW5fdW5pdHlfbWFwKAotICAgICAgICAgICAgZCwKLSAg ICAgICAgICAgIGl2cnNfbWFwcGluZ3NbcmVxX2lkXS5hZGRyX3JhbmdlX3N0 YXJ0LAotICAgICAgICAgICAgaXZyc19tYXBwaW5nc1tyZXFfaWRdLmFkZHJf cmFuZ2VfbGVuZ3RoLAotICAgICAgICAgICAgaXZyc19tYXBwaW5nc1tyZXFf aWRdLndyaXRlX3Blcm1pc3Npb24sCi0gICAgICAgICAgICBpdnJzX21hcHBp bmdzW3JlcV9pZF0ucmVhZF9wZXJtaXNzaW9uKTsKKyAgICAgICAgaW50IHJj ID0gYW1kX2lvbW11X3Jlc2VydmVfZG9tYWluX3VuaXR5X21hcCgKKyAgICAg ICAgICAgICAgICAgICAgIGQsIHVuaXR5X21hcC0+YWRkciwgdW5pdHlfbWFw LT5sZW5ndGgsCisgICAgICAgICAgICAgICAgICAgICB1bml0eV9tYXAtPndy aXRlLCB1bml0eV9tYXAtPnJlYWQpOworCisgICAgICAgIGlmICggcmMgKQor ICAgICAgICAgICAgcmV0dXJuIHJjOwogICAgIH0KIAogICAgIHJldHVybiBy ZWFzc2lnbl9kZXZpY2UocGRldi0+ZG9tYWluLCBkLCBkZXZmbiwgcGRldik7 Cg== --=separator Content-Type: application/octet-stream; name="xsa378/xsa378-4.14-3.patch" Content-Disposition: attachment; filename="xsa378/xsa378-4.14-3.patch" Content-Transfer-Encoding: base64 RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0 OiBJT01NVTogYWxzbyBwYXNzIHAybV9hY2Nlc3NfdCB0byBwMm1fZ2V0X2lv bW11X2ZsYWdzKCkKCkEgc3Vic2VxdWVudCBjaGFuZ2Ugd2lsbCB3YW50IHRv IGN1c3RvbWl6ZSB0aGUgSU9NTVUgcGVybWlzc2lvbnMgYmFzZWQKb24gdGhp cy4KClRoaXMgaXMgcGFydCBvZiBYU0EtMzc4LgoKU2lnbmVkLW9mZi1ieTog SmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpSZXZpZXdlZC1ieTog UGF1bCBEdXJyYW50IDxwYXVsQHhlbi5vcmc+CgotLS0gYS94ZW4vYXJjaC94 ODYvbW0vcDJtLWVwdC5jCisrKyBiL3hlbi9hcmNoL3g4Ni9tbS9wMm0tZXB0 LmMKQEAgLTY4MCw3ICs2ODAsNyBAQCBlcHRfc2V0X2VudHJ5KHN0cnVjdCBw Mm1fZG9tYWluICpwMm0sIGdmCiAgICAgdWludDhfdCBpcGF0ID0gMDsKICAg ICBib29sX3QgbmVlZF9tb2RpZnlfdnRkX3RhYmxlID0gMTsKICAgICBib29s X3QgdnRkX3B0ZV9wcmVzZW50ID0gMDsKLSAgICB1bnNpZ25lZCBpbnQgaW9t bXVfZmxhZ3MgPSBwMm1fZ2V0X2lvbW11X2ZsYWdzKHAybXQsIG1mbik7Cisg ICAgdW5zaWduZWQgaW50IGlvbW11X2ZsYWdzID0gcDJtX2dldF9pb21tdV9m bGFncyhwMm10LCBwMm1hLCBtZm4pOwogICAgIGJvb2xfdCBuZWVkc19zeW5j ID0gMTsKICAgICBlcHRfZW50cnlfdCBvbGRfZW50cnkgPSB7IC5lcHRlID0g MCB9OwogICAgIGVwdF9lbnRyeV90IG5ld19lbnRyeSA9IHsgLmVwdGUgPSAw IH07CkBAIC04MDgsOCArODA4LDggQEAgZXB0X3NldF9lbnRyeShzdHJ1Y3Qg cDJtX2RvbWFpbiAqcDJtLCBnZgogCiAgICAgICAgIC8qIFNhZmUgdG8gcmVh ZC10aGVuLXdyaXRlIGJlY2F1c2Ugd2UgaG9sZCB0aGUgcDJtIGxvY2sgKi8K ICAgICAgICAgaWYgKCBlcHRfZW50cnktPm1mbiA9PSBuZXdfZW50cnkubWZu ICYmCi0gICAgICAgICAgICAgcDJtX2dldF9pb21tdV9mbGFncyhlcHRfZW50 cnktPnNhX3AybXQsIF9tZm4oZXB0X2VudHJ5LT5tZm4pKSA9PQotICAgICAg ICAgICAgIGlvbW11X2ZsYWdzICkKKyAgICAgICAgICAgICBwMm1fZ2V0X2lv bW11X2ZsYWdzKGVwdF9lbnRyeS0+c2FfcDJtdCwgZXB0X2VudHJ5LT5hY2Nl c3MsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBfbWZuKGVw dF9lbnRyeS0+bWZuKSkgPT0gaW9tbXVfZmxhZ3MgKQogICAgICAgICAgICAg bmVlZF9tb2RpZnlfdnRkX3RhYmxlID0gMDsKIAogICAgICAgICBlcHRfcDJt X3R5cGVfdG9fZmxhZ3MocDJtLCAmbmV3X2VudHJ5KTsKLS0tIGEveGVuL2Fy Y2gveDg2L21tL3AybS1wdC5jCisrKyBiL3hlbi9hcmNoL3g4Ni9tbS9wMm0t cHQuYwpAQCAtNDgwLDYgKzQ4MCwxNiBAQCBpbnQgcDJtX3B0X2hhbmRsZV9k ZWZlcnJlZF9jaGFuZ2VzKHVpbnQ2CiAgICAgcmV0dXJuIHJjOwogfQogCisv KiBSZWNvbnN0cnVjdCBhIGZha2UgcDJtX2FjY2Vzc190IGZyb20gc3RvcmVk IFBURSBmbGFncy4gKi8KK3N0YXRpYyBwMm1fYWNjZXNzX3QgcDJtX2ZsYWdz X3RvX2FjY2Vzcyh1bnNpZ25lZCBpbnQgZmxhZ3MpCit7CisgICAgaWYgKCBm bGFncyAmIF9QQUdFX1BSRVNFTlQgKQorICAgICAgICByZXR1cm4gcDJtX2Fj Y2Vzc19uOworCisgICAgLyogTm8gbmVlZCB0byBsb29rIGF0IF9QQUdFX05Y IGZvciBub3cuICovCisgICAgcmV0dXJuIGZsYWdzICYgX1BBR0VfUlcgPyBw Mm1fYWNjZXNzX3J3IDogcDJtX2FjY2Vzc19yOworfQorCiAvKiBDaGVja3Mg b25seSBhcHBsaWNhYmxlIHRvIGVudHJpZXMgd2l0aCBvcmRlciA+IFBBR0Vf T1JERVJfNEsgKi8KIHN0YXRpYyB2b2lkIGNoZWNrX2VudHJ5KG1mbl90IG1m biwgcDJtX3R5cGVfdCBuZXcsIHAybV90eXBlX3Qgb2xkLAogICAgICAgICAg ICAgICAgICAgICAgICAgdW5zaWduZWQgaW50IG9yZGVyKQpAQCAtNTE0LDcg KzUyNCw3IEBAIHAybV9wdF9zZXRfZW50cnkoc3RydWN0IHAybV9kb21haW4g KnAybSwKICAgICBsMl9wZ2VudHJ5X3QgbDJlX2NvbnRlbnQ7CiAgICAgbDNf cGdlbnRyeV90IGwzZV9jb250ZW50OwogICAgIGludCByYzsKLSAgICB1bnNp Z25lZCBpbnQgaW9tbXVfcHRlX2ZsYWdzID0gcDJtX2dldF9pb21tdV9mbGFn cyhwMm10LCBtZm4pOworICAgIHVuc2lnbmVkIGludCBpb21tdV9wdGVfZmxh Z3MgPSBwMm1fZ2V0X2lvbW11X2ZsYWdzKHAybXQsIHAybWEsIG1mbik7CiAg ICAgLyoKICAgICAgKiBvbGRfbWZuIGFuZCBpb21tdV9vbGRfZmxhZ3MgY29u dHJvbCBwb3NzaWJsZSBmbHVzaC91cGRhdGUgbmVlZHMgb24gdGhlCiAgICAg ICogSU9NTVU6IFdlIG5lZWQgdG8gZmx1c2ggd2hlbiBNRk4gb3IgZmxhZ3Mg KGkuZS4gcGVybWlzc2lvbnMpIGNoYW5nZS4KQEAgLTU3Nyw2ICs1ODcsNyBA QCBwMm1fcHRfc2V0X2VudHJ5KHN0cnVjdCBwMm1fZG9tYWluICpwMm0sCiAg ICAgICAgICAgICAgICAgb2xkX21mbiA9IGwxZV9nZXRfcGZuKCpwMm1fZW50 cnkpOwogICAgICAgICAgICAgICAgIGlvbW11X29sZF9mbGFncyA9CiAgICAg ICAgICAgICAgICAgICAgIHAybV9nZXRfaW9tbXVfZmxhZ3MocDJtX2ZsYWdz X3RvX3R5cGUoZmxhZ3MpLAorICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIHAybV9mbGFnc190b19hY2Nlc3MoZmxhZ3MpLAogICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIF9tZm4ob2xk X21mbikpOwogICAgICAgICAgICAgfQogICAgICAgICAgICAgZWxzZQpAQCAt NjE5LDkgKzYzMCwxMCBAQCBwMm1fcHRfc2V0X2VudHJ5KHN0cnVjdCBwMm1f ZG9tYWluICpwMm0sCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIDAsIEwxX1BBR0VUQUJMRV9FTlRSSUVTKTsKICAgICAgICAgQVNTRVJU KHAybV9lbnRyeSk7CiAgICAgICAgIG9sZF9tZm4gPSBsMWVfZ2V0X3Bmbigq cDJtX2VudHJ5KTsKKyAgICAgICAgZmxhZ3MgPSBsMWVfZ2V0X2ZsYWdzKCpw Mm1fZW50cnkpOwogICAgICAgICBpb21tdV9vbGRfZmxhZ3MgPQotICAgICAg ICAgICAgcDJtX2dldF9pb21tdV9mbGFncyhwMm1fZmxhZ3NfdG9fdHlwZShs MWVfZ2V0X2ZsYWdzKCpwMm1fZW50cnkpKSwKLSAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgX21mbihvbGRfbWZuKSk7CisgICAgICAgICAgICBw Mm1fZ2V0X2lvbW11X2ZsYWdzKHAybV9mbGFnc190b190eXBlKGZsYWdzKSwK KyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcDJtX2ZsYWdzX3Rv X2FjY2VzcyhmbGFncyksIF9tZm4ob2xkX21mbikpOwogCiAgICAgICAgIGlm ICggbWZuX3ZhbGlkKG1mbikgfHwgcDJtX2FsbG93c19pbnZhbGlkX21mbihw Mm10KSApCiAgICAgICAgICAgICBlbnRyeV9jb250ZW50ID0gcDJtX2wxZV9m cm9tX3BmbihtZm5feChtZm4pLApAQCAtNjQ5LDYgKzY2MSw3IEBAIHAybV9w dF9zZXRfZW50cnkoc3RydWN0IHAybV9kb21haW4gKnAybSwKICAgICAgICAg ICAgICAgICBvbGRfbWZuID0gbDFlX2dldF9wZm4oKnAybV9lbnRyeSk7CiAg ICAgICAgICAgICAgICAgaW9tbXVfb2xkX2ZsYWdzID0KICAgICAgICAgICAg ICAgICAgICAgcDJtX2dldF9pb21tdV9mbGFncyhwMm1fZmxhZ3NfdG9fdHlw ZShmbGFncyksCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgcDJtX2ZsYWdzX3RvX2FjY2VzcyhmbGFncyksCiAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgX21mbihvbGRfbWZuKSk7 CiAgICAgICAgICAgICB9CiAgICAgICAgICAgICBlbHNlCi0tLSBhL3hlbi9p bmNsdWRlL2FzbS14ODYvcDJtLmgKKysrIGIveGVuL2luY2x1ZGUvYXNtLXg4 Ni9wMm0uaApAQCAtOTAzLDcgKzkwMyw4IEBAIHN0YXRpYyBpbmxpbmUgdm9p ZCBwMm1fYWx0cDJtX2NoZWNrKHN0cnUKIC8qCiAgKiBwMm0gdHlwZSB0byBJ T01NVSBmbGFncwogICovCi1zdGF0aWMgaW5saW5lIHVuc2lnbmVkIGludCBw Mm1fZ2V0X2lvbW11X2ZsYWdzKHAybV90eXBlX3QgcDJtdCwgbWZuX3QgbWZu KQorc3RhdGljIGlubGluZSB1bnNpZ25lZCBpbnQgcDJtX2dldF9pb21tdV9m bGFncyhwMm1fdHlwZV90IHAybXQsCisgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIHAybV9hY2Nlc3NfdCBwMm1hLCBt Zm5fdCBtZm4pCiB7CiAgICAgdW5zaWduZWQgaW50IGZsYWdzOwogCg== --=separator Content-Type: application/octet-stream; name="xsa378/xsa378-4.14-4.patch" Content-Disposition: attachment; filename="xsa378/xsa378-4.14-4.patch" Content-Transfer-Encoding: base64 RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0 OiBJT01NVTogZ2VuZXJhbGl6ZSBWVC1kJ3MgdHJhY2tpbmcgb2YgbWFwcGVk IFJNUlIgcmVnaW9ucwoKSW4gb3JkZXIgdG8gcmUtdXNlIGl0IGVsc2V3aGVy ZSwgbW92ZSB0aGUgbG9naWMgdG8gdmVuZG9yIGluZGVwZW5kZW50CmNvZGUg YW5kIHN0cmlwIGl0IG9mIFJNUlIgc3BlY2lmaWNzLgoKTm90ZSB0aGF0IHRo ZSBwcmlvciAibWFwIiBwYXJhbWV0ZXIgZ2V0cyBmb2xkZWQgaW50byB0aGUg bmV3ICJwMm1hIiBvbmUKKHdoaWNoIEFNRCBJT01NVSBjb2RlIHdpbGwgd2Fu dCB0byBtYWtlIHVzZSBvZiksIGFzc2lnbmluZyBhbHRlcm5hdGl2ZQptZWFu aW5nICgidW5tYXAiKSB0byBwMm1fYWNjZXNzX3guIFByZXBhcmUgc2V0X2lk ZW50aXR5X3AybV9lbnRyeSgpIGFuZApwMm1fZ2V0X2lvbW11X2ZsYWdzKCkg Zm9yIGdldHRpbmcgcGFzc2VkIGFjY2VzcyB0eXBlcyBvdGhlciB0aGFuCnAy bV9hY2Nlc3NfcncgKGluIHRoZSBsYXR0ZXIgY2FzZSBqdXN0IGZvciBwMm1f bW1pb19kaXJlY3QgcmVxdWVzdHMpLgoKTm90ZSBhbHNvIHRoYXQsIHRvIGJl IG9uIHRoZSBzYWZlIHNpZGUsIGFuIG92ZXJsYXAgY2hlY2sgZ2V0cyBhZGRl ZCB0bwp0aGUgbWFpbiBsb29wIG9mIGlvbW11X2lkZW50aXR5X21hcHBpbmco KS4KClRoaXMgaXMgcGFydCBvZiBYU0EtMzc4LgoKU2lnbmVkLW9mZi1ieTog SmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpSZXZpZXdlZC1ieTog UGF1bCBEdXJyYW50IDxwYXVsQHhlbi5vcmc+CgotLS0gYS94ZW4vYXJjaC94 ODYvbW0vcDJtLmMKKysrIGIveGVuL2FyY2gveDg2L21tL3AybS5jCkBAIC0x MzUzLDcgKzEzNTMsNyBAQCBpbnQgc2V0X2lkZW50aXR5X3AybV9lbnRyeShz dHJ1Y3QgZG9tYWluCiAgICAgICAgIGlmICggIWlzX2lvbW11X2VuYWJsZWQo ZCkgKQogICAgICAgICAgICAgcmV0dXJuIDA7CiAgICAgICAgIHJldHVybiBp b21tdV9sZWdhY3lfbWFwKGQsIF9kZm4oZ2ZuX2wpLCBfbWZuKGdmbl9sKSwg UEFHRV9PUkRFUl80SywKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgSU9NTVVGX3JlYWRhYmxlIHwgSU9NTVVGX3dyaXRhYmxlKTsKKyAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgcDJtX2FjY2Vzc190b19pb21t dV9mbGFncyhwMm1hKSk7CiAgICAgfQogCiAgICAgZ2ZuX2xvY2socDJtLCBn Zm4sIDApOwotLS0gYS94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC92dGQvaW9t bXUuYworKysgYi94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC92dGQvaW9tbXUu YwpAQCAtNDIsMTIgKzQyLDYgQEAKICNpbmNsdWRlICJ2dGQuaCIKICNpbmNs dWRlICIuLi9hdHMuaCIKIAotc3RydWN0IG1hcHBlZF9ybXJyIHsKLSAgICBz dHJ1Y3QgbGlzdF9oZWFkIGxpc3Q7Ci0gICAgdTY0IGJhc2UsIGVuZDsKLSAg ICB1bnNpZ25lZCBpbnQgY291bnQ7Ci19OwotCiAvKiBQb3NzaWJsZSB1bmZp bHRlcmVkIExBUElDL01TSSBtZXNzYWdlcyBmcm9tIHVudHJ1c3RlZCBzb3Vy Y2VzPyAqLwogYm9vbCBfX3JlYWRfbW9zdGx5IHVudHJ1c3RlZF9tc2k7CiAK QEAgLTE4MDAsMTcgKzE3OTQsMTIgQEAgb3V0Ogogc3RhdGljIHZvaWQgaW9t bXVfZG9tYWluX3RlYXJkb3duKHN0cnVjdCBkb21haW4gKmQpCiB7CiAgICAg c3RydWN0IGRvbWFpbl9pb21tdSAqaGQgPSBkb21faW9tbXUoZCk7Ci0gICAg c3RydWN0IG1hcHBlZF9ybXJyICptcm1yciwgKnRtcDsKICAgICBjb25zdCBz dHJ1Y3QgYWNwaV9kcmhkX3VuaXQgKmRyaGQ7CiAKICAgICBpZiAoIGxpc3Rf ZW1wdHkoJmFjcGlfZHJoZF91bml0cykgKQogICAgICAgICByZXR1cm47CiAK LSAgICBsaXN0X2Zvcl9lYWNoX2VudHJ5X3NhZmUgKCBtcm1yciwgdG1wLCAm aGQtPmFyY2gubWFwcGVkX3JtcnJzLCBsaXN0ICkKLSAgICB7Ci0gICAgICAg IGxpc3RfZGVsKCZtcm1yci0+bGlzdCk7Ci0gICAgICAgIHhmcmVlKG1ybXJy KTsKLSAgICB9CisgICAgaW9tbXVfaWRlbnRpdHlfbWFwX3RlYXJkb3duKGQp OwogCiAgICAgQVNTRVJUKGlzX2lvbW11X2VuYWJsZWQoZCkpOwogCkBAIC0x OTY2LDc0ICsxOTU1LDYgQEAgc3RhdGljIHZvaWQgaW9tbXVfc2V0X3BnZChz dHJ1Y3QgZG9tYWluCiAgICAgICAgIHBhZ2V0YWJsZV9nZXRfcGFkZHIocGFn ZXRhYmxlX2Zyb21fbWZuKHBnZF9tZm4pKTsKIH0KIAotc3RhdGljIGludCBy bXJyX2lkZW50aXR5X21hcHBpbmcoc3RydWN0IGRvbWFpbiAqZCwgYm9vbF90 IG1hcCwKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNvbnN0 IHN0cnVjdCBhY3BpX3JtcnJfdW5pdCAqcm1yciwKLSAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIHUzMiBmbGFnKQotewotICAgIHVuc2lnbmVk IGxvbmcgYmFzZV9wZm4gPSBybXJyLT5iYXNlX2FkZHJlc3MgPj4gUEFHRV9T SElGVF80SzsKLSAgICB1bnNpZ25lZCBsb25nIGVuZF9wZm4gPSBQQUdFX0FM SUdOXzRLKHJtcnItPmVuZF9hZGRyZXNzKSA+PiBQQUdFX1NISUZUXzRLOwot ICAgIHN0cnVjdCBtYXBwZWRfcm1yciAqbXJtcnI7Ci0gICAgc3RydWN0IGRv bWFpbl9pb21tdSAqaGQgPSBkb21faW9tbXUoZCk7Ci0KLSAgICBBU1NFUlQo cGNpZGV2c19sb2NrZWQoKSk7Ci0gICAgQVNTRVJUKHJtcnItPmJhc2VfYWRk cmVzcyA8IHJtcnItPmVuZF9hZGRyZXNzKTsKLQotICAgIC8qCi0gICAgICog Tm8gbmVlZCB0byBhY3F1aXJlIGhkLT5hcmNoLm1hcHBpbmdfbG9jazogQm90 aCBpbnNlcnRpb24gYW5kIHJlbW92YWwKLSAgICAgKiBnZXQgZG9uZSB3aGls ZSBob2xkaW5nIHBjaWRldnNfbG9jay4KLSAgICAgKi8KLSAgICBsaXN0X2Zv cl9lYWNoX2VudHJ5KCBtcm1yciwgJmhkLT5hcmNoLm1hcHBlZF9ybXJycywg bGlzdCApCi0gICAgewotICAgICAgICBpZiAoIG1ybXJyLT5iYXNlID09IHJt cnItPmJhc2VfYWRkcmVzcyAmJgotICAgICAgICAgICAgIG1ybXJyLT5lbmQg PT0gcm1yci0+ZW5kX2FkZHJlc3MgKQotICAgICAgICB7Ci0gICAgICAgICAg ICBpbnQgcmV0ID0gMDsKLQotICAgICAgICAgICAgaWYgKCBtYXAgKQotICAg ICAgICAgICAgewotICAgICAgICAgICAgICAgICsrbXJtcnItPmNvdW50Owot ICAgICAgICAgICAgICAgIHJldHVybiAwOwotICAgICAgICAgICAgfQotCi0g ICAgICAgICAgICBpZiAoIC0tbXJtcnItPmNvdW50ICkKLSAgICAgICAgICAg ICAgICByZXR1cm4gMDsKLQotICAgICAgICAgICAgd2hpbGUgKCBiYXNlX3Bm biA8IGVuZF9wZm4gKQotICAgICAgICAgICAgewotICAgICAgICAgICAgICAg IGlmICggY2xlYXJfaWRlbnRpdHlfcDJtX2VudHJ5KGQsIGJhc2VfcGZuKSAp Ci0gICAgICAgICAgICAgICAgICAgIHJldCA9IC1FTlhJTzsKLSAgICAgICAg ICAgICAgICBiYXNlX3BmbisrOwotICAgICAgICAgICAgfQotCi0gICAgICAg ICAgICBsaXN0X2RlbCgmbXJtcnItPmxpc3QpOwotICAgICAgICAgICAgeGZy ZWUobXJtcnIpOwotICAgICAgICAgICAgcmV0dXJuIHJldDsKLSAgICAgICAg fQotICAgIH0KLQotICAgIGlmICggIW1hcCApCi0gICAgICAgIHJldHVybiAt RU5PRU5UOwotCi0gICAgd2hpbGUgKCBiYXNlX3BmbiA8IGVuZF9wZm4gKQot ICAgIHsKLSAgICAgICAgaW50IGVyciA9IHNldF9pZGVudGl0eV9wMm1fZW50 cnkoZCwgYmFzZV9wZm4sIHAybV9hY2Nlc3NfcncsIGZsYWcpOwotCi0gICAg ICAgIGlmICggZXJyICkKLSAgICAgICAgICAgIHJldHVybiBlcnI7Ci0gICAg ICAgIGJhc2VfcGZuKys7Ci0gICAgfQotCi0gICAgbXJtcnIgPSB4bWFsbG9j KHN0cnVjdCBtYXBwZWRfcm1ycik7Ci0gICAgaWYgKCAhbXJtcnIgKQotICAg ICAgICByZXR1cm4gLUVOT01FTTsKLSAgICBtcm1yci0+YmFzZSA9IHJtcnIt PmJhc2VfYWRkcmVzczsKLSAgICBtcm1yci0+ZW5kID0gcm1yci0+ZW5kX2Fk ZHJlc3M7Ci0gICAgbXJtcnItPmNvdW50ID0gMTsKLSAgICBsaXN0X2FkZF90 YWlsKCZtcm1yci0+bGlzdCwgJmhkLT5hcmNoLm1hcHBlZF9ybXJycyk7Ci0K LSAgICByZXR1cm4gMDsKLX0KLQogc3RhdGljIGludCBpbnRlbF9pb21tdV9h ZGRfZGV2aWNlKHU4IGRldmZuLCBzdHJ1Y3QgcGNpX2RldiAqcGRldikKIHsK ICAgICBzdHJ1Y3QgYWNwaV9ybXJyX3VuaXQgKnJtcnI7CkBAIC0yMDY1LDcg KzE5ODYsOSBAQCBzdGF0aWMgaW50IGludGVsX2lvbW11X2FkZF9kZXZpY2Uo dTggZGV2CiAgICAgICAgICAgICAgKiBTaW5jZSBSTVJScyBhcmUgYWx3YXlz IHJlc2VydmVkIGluIHRoZSBlODIwIG1hcCBmb3IgdGhlIGhhcmR3YXJlCiAg ICAgICAgICAgICAgKiBkb21haW4sIHRoZXJlIHNob3VsZG4ndCBiZSBhIGNv bmZsaWN0LgogICAgICAgICAgICAgICovCi0gICAgICAgICAgICByZXQgPSBy bXJyX2lkZW50aXR5X21hcHBpbmcocGRldi0+ZG9tYWluLCAxLCBybXJyLCAw KTsKKyAgICAgICAgICAgIHJldCA9IGlvbW11X2lkZW50aXR5X21hcHBpbmco cGRldi0+ZG9tYWluLCBwMm1fYWNjZXNzX3J3LAorICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBybXJyLT5iYXNlX2FkZHJlc3Ms IHJtcnItPmVuZF9hZGRyZXNzLAorICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAwKTsKICAgICAgICAgICAgIGlmICggcmV0ICkK ICAgICAgICAgICAgICAgICBkcHJpbnRrKFhFTkxPR19FUlIgVlREUFJFRklY LCAiZCVkOiBSTVJSIG1hcHBpbmcgZmFpbGVkXG4iLAogICAgICAgICAgICAg ICAgICAgICAgICAgcGRldi0+ZG9tYWluLT5kb21haW5faWQpOwpAQCAtMjEx MCw3ICsyMDMzLDggQEAgc3RhdGljIGludCBpbnRlbF9pb21tdV9yZW1vdmVf ZGV2aWNlKHU4CiAgICAgICAgICAqIEFueSBmbGFnIGlzIG5vdGhpbmcgdG8g Y2xlYXIgdGhlc2UgbWFwcGluZ3MgYnV0IGhlcmUKICAgICAgICAgICogaXRz IGFsd2F5cyBzYWZlIGFuZCBzdHJpY3QgdG8gc2V0IDAuCiAgICAgICAgICAq LwotICAgICAgICBybXJyX2lkZW50aXR5X21hcHBpbmcocGRldi0+ZG9tYWlu LCAwLCBybXJyLCAwKTsKKyAgICAgICAgaW9tbXVfaWRlbnRpdHlfbWFwcGlu ZyhwZGV2LT5kb21haW4sIHAybV9hY2Nlc3NfeCwgcm1yci0+YmFzZV9hZGRy ZXNzLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHJtcnItPmVu ZF9hZGRyZXNzLCAwKTsKICAgICB9CiAKICAgICByZXR1cm4gZG9tYWluX2Nv bnRleHRfdW5tYXAocGRldi0+ZG9tYWluLCBkZXZmbiwgcGRldik7CkBAIC0y MzA5LDcgKzIyMzMsOCBAQCBzdGF0aWMgdm9pZCBfX2h3ZG9tX2luaXQgc2V0 dXBfaHdkb21fcm1yCiAgICAgICAgICAqIGRvbWFpbiwgdGhlcmUgc2hvdWxk bid0IGJlIGEgY29uZmxpY3QuIFNvIGl0cyBhbHdheXMgc2FmZSBhbmQKICAg ICAgICAgICogc3RyaWN0IHRvIHNldCAwLgogICAgICAgICAgKi8KLSAgICAg ICAgcmV0ID0gcm1ycl9pZGVudGl0eV9tYXBwaW5nKGQsIDEsIHJtcnIsIDAp OworICAgICAgICByZXQgPSBpb21tdV9pZGVudGl0eV9tYXBwaW5nKGQsIHAy bV9hY2Nlc3NfcncsIHJtcnItPmJhc2VfYWRkcmVzcywKKyAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBybXJyLT5lbmRfYWRkcmVzcywg MCk7CiAgICAgICAgIGlmICggcmV0ICkKICAgICAgICAgICAgIGRwcmludGso WEVOTE9HX0VSUiBWVERQUkVGSVgsCiAgICAgICAgICAgICAgICAgICAgICAi SU9NTVU6IG1hcHBpbmcgcmVzZXJ2ZWQgcmVnaW9uIGZhaWxlZFxuIik7CkBA IC0yNDgwLDcgKzI0MDUsOSBAQCBzdGF0aWMgaW50IHJlYXNzaWduX2Rldmlj ZV9vd25lcnNoaXAoCiAgICAgICAgICAgICAgICAgICogQW55IFJNUlIgZmxh ZyBpcyBhbHdheXMgaWdub3JlZCB3aGVuIHJlbW92ZSBhIGRldmljZSwKICAg ICAgICAgICAgICAgICAgKiBidXQgaXRzIGFsd2F5cyBzYWZlIGFuZCBzdHJp Y3QgdG8gc2V0IDAuCiAgICAgICAgICAgICAgICAgICovCi0gICAgICAgICAg ICAgICAgcmV0ID0gcm1ycl9pZGVudGl0eV9tYXBwaW5nKHNvdXJjZSwgMCwg cm1yciwgMCk7CisgICAgICAgICAgICAgICAgcmV0ID0gaW9tbXVfaWRlbnRp dHlfbWFwcGluZyhzb3VyY2UsIHAybV9hY2Nlc3NfeCwKKyAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHJtcnItPmJhc2Vf YWRkcmVzcywKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIHJtcnItPmVuZF9hZGRyZXNzLCAwKTsKICAgICAgICAgICAg ICAgICBpZiAoIHJldCAhPSAtRU5PRU5UICkKICAgICAgICAgICAgICAgICAg ICAgcmV0dXJuIHJldDsKICAgICAgICAgICAgIH0KQEAgLTI1NzcsNyArMjUw NCw4IEBAIHN0YXRpYyBpbnQgaW50ZWxfaW9tbXVfYXNzaWduX2RldmljZSgK ICAgICAgICAgICAgICBQQ0lfQlVTKGJkZikgPT0gYnVzICYmCiAgICAgICAg ICAgICAgUENJX0RFVkZOMihiZGYpID09IGRldmZuICkKICAgICAgICAgewot ICAgICAgICAgICAgcmV0ID0gcm1ycl9pZGVudGl0eV9tYXBwaW5nKGQsIDEs IHJtcnIsIGZsYWcpOworICAgICAgICAgICAgcmV0ID0gaW9tbXVfaWRlbnRp dHlfbWFwcGluZyhkLCBwMm1fYWNjZXNzX3J3LCBybXJyLT5iYXNlX2FkZHJl c3MsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IHJtcnItPmVuZF9hZGRyZXNzLCBmbGFnKTsKICAgICAgICAgICAgIGlmICgg cmV0ICkKICAgICAgICAgICAgIHsKICAgICAgICAgICAgICAgICBpbnQgcmM7 Ci0tLSBhL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL3g4Ni9pb21tdS5jCisr KyBiL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL3g4Ni9pb21tdS5jCkBAIC0x MzksNyArMTM5LDcgQEAgaW50IGFyY2hfaW9tbXVfZG9tYWluX2luaXQoc3Ry dWN0IGRvbWFpbgogICAgIHN0cnVjdCBkb21haW5faW9tbXUgKmhkID0gZG9t X2lvbW11KGQpOwogCiAgICAgc3Bpbl9sb2NrX2luaXQoJmhkLT5hcmNoLm1h cHBpbmdfbG9jayk7Ci0gICAgSU5JVF9MSVNUX0hFQUQoJmhkLT5hcmNoLm1h cHBlZF9ybXJycyk7CisgICAgSU5JVF9MSVNUX0hFQUQoJmhkLT5hcmNoLmlk ZW50aXR5X21hcHMpOwogCiAgICAgcmV0dXJuIDA7CiB9CkBAIC0xNDgsNiAr MTQ4LDk5IEBAIHZvaWQgYXJjaF9pb21tdV9kb21haW5fZGVzdHJveShzdHJ1 Y3QgZG8KIHsKIH0KIAorc3RydWN0IGlkZW50aXR5X21hcCB7CisgICAgc3Ry dWN0IGxpc3RfaGVhZCBsaXN0OworICAgIHBhZGRyX3QgYmFzZSwgZW5kOwor ICAgIHAybV9hY2Nlc3NfdCBhY2Nlc3M7CisgICAgdW5zaWduZWQgaW50IGNv dW50OworfTsKKworaW50IGlvbW11X2lkZW50aXR5X21hcHBpbmcoc3RydWN0 IGRvbWFpbiAqZCwgcDJtX2FjY2Vzc190IHAybWEsCisgICAgICAgICAgICAg ICAgICAgICAgICAgICBwYWRkcl90IGJhc2UsIHBhZGRyX3QgZW5kLAorICAg ICAgICAgICAgICAgICAgICAgICAgICAgdW5zaWduZWQgaW50IGZsYWcpCit7 CisgICAgdW5zaWduZWQgbG9uZyBiYXNlX3BmbiA9IGJhc2UgPj4gUEFHRV9T SElGVF80SzsKKyAgICB1bnNpZ25lZCBsb25nIGVuZF9wZm4gPSBQQUdFX0FM SUdOXzRLKGVuZCkgPj4gUEFHRV9TSElGVF80SzsKKyAgICBzdHJ1Y3QgaWRl bnRpdHlfbWFwICptYXA7CisgICAgc3RydWN0IGRvbWFpbl9pb21tdSAqaGQg PSBkb21faW9tbXUoZCk7CisKKyAgICBBU1NFUlQocGNpZGV2c19sb2NrZWQo KSk7CisgICAgQVNTRVJUKGJhc2UgPCBlbmQpOworCisgICAgLyoKKyAgICAg KiBObyBuZWVkIHRvIGFjcXVpcmUgaGQtPmFyY2gubWFwcGluZ19sb2NrOiBC b3RoIGluc2VydGlvbiBhbmQgcmVtb3ZhbAorICAgICAqIGdldCBkb25lIHdo aWxlIGhvbGRpbmcgcGNpZGV2c19sb2NrLgorICAgICAqLworICAgIGxpc3Rf Zm9yX2VhY2hfZW50cnkoIG1hcCwgJmhkLT5hcmNoLmlkZW50aXR5X21hcHMs IGxpc3QgKQorICAgIHsKKyAgICAgICAgaWYgKCBtYXAtPmJhc2UgPT0gYmFz ZSAmJiBtYXAtPmVuZCA9PSBlbmQgKQorICAgICAgICB7CisgICAgICAgICAg ICBpbnQgcmV0ID0gMDsKKworICAgICAgICAgICAgaWYgKCBwMm1hICE9IHAy bV9hY2Nlc3NfeCApCisgICAgICAgICAgICB7CisgICAgICAgICAgICAgICAg aWYgKCBtYXAtPmFjY2VzcyAhPSBwMm1hICkKKyAgICAgICAgICAgICAgICAg ICAgcmV0dXJuIC1FQUREUklOVVNFOworICAgICAgICAgICAgICAgICsrbWFw LT5jb3VudDsKKyAgICAgICAgICAgICAgICByZXR1cm4gMDsKKyAgICAgICAg ICAgIH0KKworICAgICAgICAgICAgaWYgKCAtLW1hcC0+Y291bnQgKQorICAg ICAgICAgICAgICAgIHJldHVybiAwOworCisgICAgICAgICAgICB3aGlsZSAo IGJhc2VfcGZuIDwgZW5kX3BmbiApCisgICAgICAgICAgICB7CisgICAgICAg ICAgICAgICAgaWYgKCBjbGVhcl9pZGVudGl0eV9wMm1fZW50cnkoZCwgYmFz ZV9wZm4pICkKKyAgICAgICAgICAgICAgICAgICAgcmV0ID0gLUVOWElPOwor ICAgICAgICAgICAgICAgIGJhc2VfcGZuKys7CisgICAgICAgICAgICB9CisK KyAgICAgICAgICAgIGxpc3RfZGVsKCZtYXAtPmxpc3QpOworICAgICAgICAg ICAgeGZyZWUobWFwKTsKKworICAgICAgICAgICAgcmV0dXJuIHJldDsKKyAg ICAgICAgfQorCisgICAgICAgIGlmICggZW5kID49IG1hcC0+YmFzZSAmJiBt YXAtPmVuZCA+PSBiYXNlICkKKyAgICAgICAgICAgIHJldHVybiAtRUFERFJJ TlVTRTsKKyAgICB9CisKKyAgICBpZiAoIHAybWEgPT0gcDJtX2FjY2Vzc194 ICkKKyAgICAgICAgcmV0dXJuIC1FTk9FTlQ7CisKKyAgICB3aGlsZSAoIGJh c2VfcGZuIDwgZW5kX3BmbiApCisgICAgeworICAgICAgICBpbnQgZXJyID0g c2V0X2lkZW50aXR5X3AybV9lbnRyeShkLCBiYXNlX3BmbiwgcDJtYSwgZmxh Zyk7CisKKyAgICAgICAgaWYgKCBlcnIgKQorICAgICAgICAgICAgcmV0dXJu IGVycjsKKyAgICAgICAgYmFzZV9wZm4rKzsKKyAgICB9CisKKyAgICBtYXAg PSB4bWFsbG9jKHN0cnVjdCBpZGVudGl0eV9tYXApOworICAgIGlmICggIW1h cCApCisgICAgICAgIHJldHVybiAtRU5PTUVNOworICAgIG1hcC0+YmFzZSA9 IGJhc2U7CisgICAgbWFwLT5lbmQgPSBlbmQ7CisgICAgbWFwLT5hY2Nlc3Mg PSBwMm1hOworICAgIG1hcC0+Y291bnQgPSAxOworICAgIGxpc3RfYWRkX3Rh aWwoJm1hcC0+bGlzdCwgJmhkLT5hcmNoLmlkZW50aXR5X21hcHMpOworCisg ICAgcmV0dXJuIDA7Cit9CisKK3ZvaWQgaW9tbXVfaWRlbnRpdHlfbWFwX3Rl YXJkb3duKHN0cnVjdCBkb21haW4gKmQpCit7CisgICAgc3RydWN0IGRvbWFp bl9pb21tdSAqaGQgPSBkb21faW9tbXUoZCk7CisgICAgc3RydWN0IGlkZW50 aXR5X21hcCAqbWFwLCAqdG1wOworCisgICAgbGlzdF9mb3JfZWFjaF9lbnRy eV9zYWZlICggbWFwLCB0bXAsICZoZC0+YXJjaC5pZGVudGl0eV9tYXBzLCBs aXN0ICkKKyAgICB7CisgICAgICAgIGxpc3RfZGVsKCZtYXAtPmxpc3QpOwor ICAgICAgICB4ZnJlZShtYXApOworICAgIH0KK30KKwogc3RhdGljIGJvb2wg X19od2RvbV9pbml0IGh3ZG9tX2lvbW11X21hcChjb25zdCBzdHJ1Y3QgZG9t YWluICpkLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICB1bnNpZ25lZCBsb25nIHBmbiwKICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgdW5zaWduZWQgbG9uZyBtYXhfcGZuKQot LS0gYS94ZW4vaW5jbHVkZS9hc20teDg2L2lvbW11LmgKKysrIGIveGVuL2lu Y2x1ZGUvYXNtLXg4Ni9pb21tdS5oCkBAIC0xNiw2ICsxNiw3IEBACiAKICNp bmNsdWRlIDx4ZW4vZXJybm8uaD4KICNpbmNsdWRlIDx4ZW4vbGlzdC5oPgor I2luY2x1ZGUgPHhlbi9tZW1fYWNjZXNzLmg+CiAjaW5jbHVkZSA8eGVuL3Nw aW5sb2NrLmg+CiAjaW5jbHVkZSA8YXNtL2FwaWNkZWYuaD4KICNpbmNsdWRl IDxhc20vcHJvY2Vzc29yLmg+CkBAIC00OSw3ICs1MCw3IEBAIHN0cnVjdCBh cmNoX2lvbW11CiAgICAgc3BpbmxvY2tfdCBtYXBwaW5nX2xvY2s7ICAgICAg ICAgICAgLyogaW8gcGFnZSB0YWJsZSBsb2NrICovCiAgICAgaW50IGFnYXc7 ICAgICAvKiBhZGp1c3RlZCBndWVzdCBhZGRyZXNzIHdpZHRoLCAwIGlzIGxl dmVsIDIgMzAtYml0ICovCiAgICAgdTY0IGlvbW11X2JpdG1hcDsgICAgICAg ICAgICAgIC8qIGJpdG1hcCBvZiBpb21tdShzKSB0aGF0IHRoZSBkb21haW4g dXNlcyAqLwotICAgIHN0cnVjdCBsaXN0X2hlYWQgbWFwcGVkX3JtcnJzOwor ICAgIHN0cnVjdCBsaXN0X2hlYWQgaWRlbnRpdHlfbWFwczsKIAogICAgIC8q IGFtZCBpb21tdSBzdXBwb3J0ICovCiAgICAgaW50IHBhZ2luZ19tb2RlOwpA QCAtMTEyLDYgKzExMywxMSBAQCBzdGF0aWMgaW5saW5lIHZvaWQgaW9tbXVf ZGlzYWJsZV94MmFwaWMoCiAgICAgICAgIGlvbW11X29wcy5kaXNhYmxlX3gy YXBpYygpOwogfQogCitpbnQgaW9tbXVfaWRlbnRpdHlfbWFwcGluZyhzdHJ1 Y3QgZG9tYWluICpkLCBwMm1fYWNjZXNzX3QgcDJtYSwKKyAgICAgICAgICAg ICAgICAgICAgICAgICAgIHBhZGRyX3QgYmFzZSwgcGFkZHJfdCBlbmQsCisg ICAgICAgICAgICAgICAgICAgICAgICAgICB1bnNpZ25lZCBpbnQgZmxhZyk7 Cit2b2lkIGlvbW11X2lkZW50aXR5X21hcF90ZWFyZG93bihzdHJ1Y3QgZG9t YWluICpkKTsKKwogZXh0ZXJuIGJvb2wgdW50cnVzdGVkX21zaTsKIAogaW50 IHBpX3VwZGF0ZV9pcnRlKGNvbnN0IHN0cnVjdCBwaV9kZXNjICpwaV9kZXNj LCBjb25zdCBzdHJ1Y3QgcGlycSAqcGlycSwKLS0tIGEveGVuL2luY2x1ZGUv YXNtLXg4Ni9wMm0uaAorKysgYi94ZW4vaW5jbHVkZS9hc20teDg2L3AybS5o CkBAIC05MDAsNiArOTAwLDM0IEBAIHN0cnVjdCBwMm1fZG9tYWluICpwMm1f Z2V0X2FsdHAybShzdHJ1Y3QKIHN0YXRpYyBpbmxpbmUgdm9pZCBwMm1fYWx0 cDJtX2NoZWNrKHN0cnVjdCB2Y3B1ICp2LCB1aW50MTZfdCBpZHgpIHt9CiAj ZW5kaWYKIAorLyogcDJtIGFjY2VzcyB0byBJT01NVSBmbGFncyAqLworc3Rh dGljIGlubGluZSB1bnNpZ25lZCBpbnQgcDJtX2FjY2Vzc190b19pb21tdV9m bGFncyhwMm1fYWNjZXNzX3QgcDJtYSkKK3sKKyAgICBzd2l0Y2ggKCBwMm1h ICkKKyAgICB7CisgICAgY2FzZSBwMm1fYWNjZXNzX3J3OgorICAgIGNhc2Ug cDJtX2FjY2Vzc19yd3g6CisgICAgICAgIHJldHVybiBJT01NVUZfcmVhZGFi bGUgfCBJT01NVUZfd3JpdGFibGU7CisKKyAgICBjYXNlIHAybV9hY2Nlc3Nf cjoKKyAgICBjYXNlIHAybV9hY2Nlc3Nfcng6CisgICAgY2FzZSBwMm1fYWNj ZXNzX3J4MnJ3OgorICAgICAgICByZXR1cm4gSU9NTVVGX3JlYWRhYmxlOwor CisgICAgY2FzZSBwMm1fYWNjZXNzX3c6CisgICAgY2FzZSBwMm1fYWNjZXNz X3d4OgorICAgICAgICByZXR1cm4gSU9NTVVGX3dyaXRhYmxlOworCisgICAg Y2FzZSBwMm1fYWNjZXNzX246CisgICAgY2FzZSBwMm1fYWNjZXNzX3g6Cisg ICAgY2FzZSBwMm1fYWNjZXNzX24ycnd4OgorICAgICAgICByZXR1cm4gMDsK KyAgICB9CisKKyAgICBBU1NFUlRfVU5SRUFDSEFCTEUoKTsKKyAgICByZXR1 cm4gMDsKK30KKwogLyoKICAqIHAybSB0eXBlIHRvIElPTU1VIGZsYWdzCiAg Ki8KQEAgLTkyMSw5ICs5NDksMTAgQEAgc3RhdGljIGlubGluZSB1bnNpZ25l ZCBpbnQgcDJtX2dldF9pb21tdQogICAgICAgICBmbGFncyA9IElPTU1VRl9y ZWFkYWJsZTsKICAgICAgICAgYnJlYWs7CiAgICAgY2FzZSBwMm1fbW1pb19k aXJlY3Q6Ci0gICAgICAgIGZsYWdzID0gSU9NTVVGX3JlYWRhYmxlOwotICAg ICAgICBpZiAoICFyYW5nZXNldF9jb250YWluc19zaW5nbGV0b24obW1pb19y b19yYW5nZXMsIG1mbl94KG1mbikpICkKLSAgICAgICAgICAgIGZsYWdzIHw9 IElPTU1VRl93cml0YWJsZTsKKyAgICAgICAgZmxhZ3MgPSBwMm1fYWNjZXNz X3RvX2lvbW11X2ZsYWdzKHAybWEpOworICAgICAgICBpZiAoIChmbGFncyAm IElPTU1VRl93cml0YWJsZSkgJiYKKyAgICAgICAgICAgICByYW5nZXNldF9j b250YWluc19zaW5nbGV0b24obW1pb19yb19yYW5nZXMsIG1mbl94KG1mbikp ICkKKyAgICAgICAgICAgIGZsYWdzICY9IH5JT01NVUZfd3JpdGFibGU7CiAg ICAgICAgIGJyZWFrOwogICAgIGRlZmF1bHQ6CiAgICAgICAgIGZsYWdzID0g MDsK --=separator Content-Type: application/octet-stream; name="xsa378/xsa378-4.14-5.patch" Content-Disposition: attachment; filename="xsa378/xsa378-4.14-5.patch" Content-Transfer-Encoding: base64 RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0 OiBBTUQvSU9NTVU6IHJlLWFycmFuZ2UvY29tcGxldGUgcmUtYXNzaWdubWVu dCBoYW5kbGluZwoKUHJpb3IgdG8gdGhlIGFzc2lnbm1lbnQgc3RlcCBoYXZp bmcgY29tcGxldGVkIHN1Y2Nlc3NmdWxseSwgZGV2aWNlcwpzaG91bGQgbm90 IGdldCBhc3NvY2lhdGVkIHdpdGggdGhlaXIgbmV3IG93bmVyLiBIYW5kIHRo ZSBkZXZpY2UgdG8gRG9tSU8KKHBlcmhhcHMgdGVtcG9yYXJpbHkpLCB1bnRp bCBhZnRlciB0aGUgZGUtYXNzaWdubWVudCBzdGVwIGhhcyBjb21wbGV0ZWQu CgpEZS1hc3NpZ25tZW50IG9mIGEgZGV2aWNlIChmcm9tIG90aGVyIHRoYW4g RG9tMCkgYXMgd2VsbCBhcyBmYWlsdXJlIG9mCnJlYXNzaWduX2RldmljZSgp IGR1cmluZyBhc3NpZ25tZW50IHNob3VsZCByZXN1bHQgaW4gdW5pdHkgbWFw cGluZ3MKZ2V0dGluZyB0b3JuIGRvd24uIFRoaXMgaW4gdHVybiByZXF1aXJl cyBzd2l0Y2hpbmcgdG8gYSByZWZjb3VudGVkCm1hcHBpbmcgYXBwcm9hY2gs IGFzIHdhcyBhbHJlYWR5IHVzZWQgYnkgVlQtZCBmb3IgaXRzIFJNUlJzLCB0 byBwcmV2ZW50CnVubWFwcGluZyBhIHJlZ2lvbiB1c2VkIGJ5IG11bHRpcGxl IGRldmljZXMuCgpUaGlzIGlzIENWRS0yMDIxLTI4Njk2IC8gcGFydCBvZiBY U0EtMzc4LgoKU2lnbmVkLW9mZi1ieTogSmFuIEJldWxpY2ggPGpiZXVsaWNo QHN1c2UuY29tPgpSZXZpZXdlZC1ieTogUGF1bCBEdXJyYW50IDxwYXVsQHhl bi5vcmc+CgotLS0gYS94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC9hbWQvaW9t bXUuaAorKysgYi94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC9hbWQvaW9tbXUu aApAQCAtMjMyLDggKzIzMiwxMCBAQCBpbnQgX19tdXN0X2NoZWNrIGFtZF9p b21tdV91bm1hcF9wYWdlKHN0CiAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIHVuc2lnbmVkIGludCAqZmx1c2hfZmxhZ3MpOwogaW50 IF9fbXVzdF9jaGVjayBhbWRfaW9tbXVfYWxsb2Nfcm9vdChzdHJ1Y3QgZG9t YWluX2lvbW11ICpoZCk7CiBpbnQgYW1kX2lvbW11X3Jlc2VydmVfZG9tYWlu X3VuaXR5X21hcChzdHJ1Y3QgZG9tYWluICpkb21haW4sCi0gICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBwYWRkcl90IHBoeXNfYWRk ciwgdW5zaWduZWQgbG9uZyBzaXplLAotICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgaW50IGl3LCBpbnQgaXIpOworICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgY29uc3Qgc3RydWN0IGl2 cnNfdW5pdHlfbWFwICptYXAsCisgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICB1bnNpZ25lZCBpbnQgZmxhZyk7CitpbnQgYW1kX2lv bW11X3Jlc2VydmVfZG9tYWluX3VuaXR5X3VubWFwKHN0cnVjdCBkb21haW4g KmQsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IGNvbnN0IHN0cnVjdCBpdnJzX3VuaXR5X21hcCAqbWFwKTsKIGludCBfX211 c3RfY2hlY2sgYW1kX2lvbW11X2ZsdXNoX2lvdGxiX3BhZ2VzKHN0cnVjdCBk b21haW4gKmQsIGRmbl90IGRmbiwKICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIHVuc2lnbmVkIGludCBwYWdlX2NvdW50 LAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgdW5zaWduZWQgaW50IGZsdXNoX2ZsYWdzKTsKLS0tIGEveGVuL2RyaXZl cnMvcGFzc3Rocm91Z2gvYW1kL2lvbW11X21hcC5jCisrKyBiL3hlbi9kcml2 ZXJzL3Bhc3N0aHJvdWdoL2FtZC9pb21tdV9tYXAuYwpAQCAtNDIwLDM4ICs0 MjAsNDkgQEAgaW50IGFtZF9pb21tdV9mbHVzaF9pb3RsYl9hbGwoc3RydWN0 IGRvbQogICAgIHJldHVybiAwOwogfQogCi1pbnQgYW1kX2lvbW11X3Jlc2Vy dmVfZG9tYWluX3VuaXR5X21hcChzdHJ1Y3QgZG9tYWluICpkb21haW4sCi0g ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBwYWRkcl90 IHBoeXNfYWRkciwKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIHVuc2lnbmVkIGxvbmcgc2l6ZSwgaW50IGl3LCBpbnQgaXIpCitp bnQgYW1kX2lvbW11X3Jlc2VydmVfZG9tYWluX3VuaXR5X21hcChzdHJ1Y3Qg ZG9tYWluICpkLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgY29uc3Qgc3RydWN0IGl2cnNfdW5pdHlfbWFwICptYXAsCisgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB1bnNpZ25lZCBp bnQgZmxhZykKIHsKLSAgICB1bnNpZ25lZCBsb25nIG5wYWdlcywgaTsKLSAg ICB1bnNpZ25lZCBsb25nIGdmbjsKLSAgICB1bnNpZ25lZCBpbnQgZmxhZ3Mg PSAhIWlyOwotICAgIHVuc2lnbmVkIGludCBmbHVzaF9mbGFncyA9IDA7Ci0g ICAgaW50IHJ0ID0gMDsKLQotICAgIGlmICggaXcgKQotICAgICAgICBmbGFn cyB8PSBJT01NVUZfd3JpdGFibGU7Ci0KLSAgICBucGFnZXMgPSByZWdpb25f dG9fcGFnZXMocGh5c19hZGRyLCBzaXplKTsKLSAgICBnZm4gPSBwaHlzX2Fk ZHIgPj4gUEFHRV9TSElGVDsKLSAgICBmb3IgKCBpID0gMDsgaSA8IG5wYWdl czsgaSsrICkKKyAgICBpbnQgcmM7CisKKyAgICBpZiAoIGQgPT0gZG9tX2lv ICkKKyAgICAgICAgcmV0dXJuIDA7CisKKyAgICBmb3IgKCByYyA9IDA7ICFy YyAmJiBtYXA7IG1hcCA9IG1hcC0+bmV4dCApCiAgICAgewotICAgICAgICB1 bnNpZ25lZCBsb25nIGZyYW1lID0gZ2ZuICsgaTsKKyAgICAgICAgcDJtX2Fj Y2Vzc190IHAybWEgPSBwMm1fYWNjZXNzX247CisKKyAgICAgICAgaWYgKCBt YXAtPnJlYWQgKQorICAgICAgICAgICAgcDJtYSB8PSBwMm1fYWNjZXNzX3I7 CisgICAgICAgIGlmICggbWFwLT53cml0ZSApCisgICAgICAgICAgICBwMm1h IHw9IHAybV9hY2Nlc3NfdzsKIAotICAgICAgICBydCA9IGFtZF9pb21tdV9t YXBfcGFnZShkb21haW4sIF9kZm4oZnJhbWUpLCBfbWZuKGZyYW1lKSwgZmxh Z3MsCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICZmbHVzaF9m bGFncyk7Ci0gICAgICAgIGlmICggcnQgIT0gMCApCi0gICAgICAgICAgICBi cmVhazsKKyAgICAgICAgcmMgPSBpb21tdV9pZGVudGl0eV9tYXBwaW5nKGQs IHAybWEsIG1hcC0+YWRkciwKKyAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIG1hcC0+YWRkciArIG1hcC0+bGVuZ3RoIC0gMSwgZmxhZyk7 CiAgICAgfQogCi0gICAgLyogVXNlIHdoaWxlLWJyZWFrIHRvIGF2b2lkIGNv bXBpbGVyIHdhcm5pbmcgKi8KLSAgICB3aGlsZSAoIGZsdXNoX2ZsYWdzICYm Ci0gICAgICAgICAgICBhbWRfaW9tbXVfZmx1c2hfaW90bGJfcGFnZXMoZG9t YWluLCBfZGZuKGdmbiksCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgbnBhZ2VzLCBmbHVzaF9mbGFncykgKQotICAgICAgICBi cmVhazsKKyAgICByZXR1cm4gcmM7Cit9CisKK2ludCBhbWRfaW9tbXVfcmVz ZXJ2ZV9kb21haW5fdW5pdHlfdW5tYXAoc3RydWN0IGRvbWFpbiAqZCwKKyAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgY29uc3Qg c3RydWN0IGl2cnNfdW5pdHlfbWFwICptYXApCit7CisgICAgaW50IHJjOwor CisgICAgaWYgKCBkID09IGRvbV9pbyApCisgICAgICAgIHJldHVybiAwOwor CisgICAgZm9yICggcmMgPSAwOyBtYXA7IG1hcCA9IG1hcC0+bmV4dCApCisg ICAgeworICAgICAgICBpbnQgcmV0ID0gaW9tbXVfaWRlbnRpdHlfbWFwcGlu ZyhkLCBwMm1fYWNjZXNzX3gsIG1hcC0+YWRkciwKKyAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgbWFwLT5hZGRyICsgbWFwLT5s ZW5ndGggLSAxLCAwKTsKKworICAgICAgICBpZiAoIHJldCAmJiByZXQgIT0g LUVOT0VOVCAmJiAhcmMgKQorICAgICAgICAgICAgcmMgPSByZXQ7CisgICAg fQogCi0gICAgcmV0dXJuIHJ0OworICAgIHJldHVybiByYzsKIH0KIAogaW50 IF9faW5pdCBhbWRfaW9tbXVfcXVhcmFudGluZV9pbml0KHN0cnVjdCBkb21h aW4gKmQpCi0tLSBhL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL2FtZC9wY2lf YW1kX2lvbW11LmMKKysrIGIveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvYW1k L3BjaV9hbWRfaW9tbXUuYwpAQCAtMzI3LDYgKzMyNyw3IEBAIHN0YXRpYyBp bnQgcmVhc3NpZ25fZGV2aWNlKHN0cnVjdCBkb21haW4KICAgICBzdHJ1Y3Qg YW1kX2lvbW11ICppb21tdTsKICAgICBpbnQgYmRmLCByYzsKICAgICBzdHJ1 Y3QgZG9tYWluX2lvbW11ICp0ID0gZG9tX2lvbW11KHRhcmdldCk7CisgICAg Y29uc3Qgc3RydWN0IGl2cnNfbWFwcGluZ3MgKml2cnNfbWFwcGluZ3MgPSBn ZXRfaXZyc19tYXBwaW5ncyhwZGV2LT5zZWcpOwogCiAgICAgYmRmID0gUENJ X0JERjIocGRldi0+YnVzLCBwZGV2LT5kZXZmbik7CiAgICAgaW9tbXUgPSBm aW5kX2lvbW11X2Zvcl9kZXZpY2UocGRldi0+c2VnLCBiZGYpOwpAQCAtMzQx LDEwICszNDIsMjQgQEAgc3RhdGljIGludCByZWFzc2lnbl9kZXZpY2Uoc3Ry dWN0IGRvbWFpbgogCiAgICAgYW1kX2lvbW11X2Rpc2FibGVfZG9tYWluX2Rl dmljZShzb3VyY2UsIGlvbW11LCBkZXZmbiwgcGRldik7CiAKLSAgICBpZiAo IGRldmZuID09IHBkZXYtPmRldmZuICkKKyAgICAvKgorICAgICAqIElmIHRo ZSBkZXZpY2UgYmVsb25ncyB0byB0aGUgaGFyZHdhcmUgZG9tYWluLCBhbmQg aXQgaGFzIGEgdW5pdHkgbWFwcGluZywKKyAgICAgKiBkb24ndCByZW1vdmUg aXQgZnJvbSB0aGUgaGFyZHdhcmUgZG9tYWluLCBiZWNhdXNlIEJJT1MgbWF5 IHJlZmVyZW5jZSB0aGF0CisgICAgICogbWFwcGluZy4KKyAgICAgKi8KKyAg ICBpZiAoICFpc19oYXJkd2FyZV9kb21haW4oc291cmNlKSApCisgICAgewor ICAgICAgICByYyA9IGFtZF9pb21tdV9yZXNlcnZlX2RvbWFpbl91bml0eV91 bm1hcCgKKyAgICAgICAgICAgICAgICAgc291cmNlLAorICAgICAgICAgICAg ICAgICBpdnJzX21hcHBpbmdzW2dldF9kbWFfcmVxdWVzdG9yX2lkKHBkZXYt PnNlZywgYmRmKV0udW5pdHlfbWFwKTsKKyAgICAgICAgaWYgKCByYyApCisg ICAgICAgICAgICByZXR1cm4gcmM7CisgICAgfQorCisgICAgaWYgKCBkZXZm biA9PSBwZGV2LT5kZXZmbiAmJiBwZGV2LT5kb21haW4gIT0gZG9tX2lvICkK ICAgICB7Ci0gICAgICAgIGxpc3RfbW92ZSgmcGRldi0+ZG9tYWluX2xpc3Qs ICZ0YXJnZXQtPnBkZXZfbGlzdCk7Ci0gICAgICAgIHBkZXYtPmRvbWFpbiA9 IHRhcmdldDsKKyAgICAgICAgbGlzdF9tb3ZlKCZwZGV2LT5kb21haW5fbGlz dCwgJmRvbV9pby0+cGRldl9saXN0KTsKKyAgICAgICAgcGRldi0+ZG9tYWlu ID0gZG9tX2lvOwogICAgIH0KIAogICAgIHJjID0gYWxsb2NhdGVfZG9tYWlu X3Jlc291cmNlcyh0KTsKQEAgLTM1Niw2ICszNzEsMTIgQEAgc3RhdGljIGlu dCByZWFzc2lnbl9kZXZpY2Uoc3RydWN0IGRvbWFpbgogICAgICAgICAgICAg ICAgICAgICBwZGV2LT5zZWcsIHBkZXYtPmJ1cywgUENJX1NMT1QoZGV2Zm4p LCBQQ0lfRlVOQyhkZXZmbiksCiAgICAgICAgICAgICAgICAgICAgIHNvdXJj ZS0+ZG9tYWluX2lkLCB0YXJnZXQtPmRvbWFpbl9pZCk7CiAKKyAgICBpZiAo IGRldmZuID09IHBkZXYtPmRldmZuICYmIHBkZXYtPmRvbWFpbiAhPSB0YXJn ZXQgKQorICAgIHsKKyAgICAgICAgbGlzdF9tb3ZlKCZwZGV2LT5kb21haW5f bGlzdCwgJnRhcmdldC0+cGRldl9saXN0KTsKKyAgICAgICAgcGRldi0+ZG9t YWluID0gdGFyZ2V0OworICAgIH0KKwogICAgIHJldHVybiAwOwogfQogCkBA IC0zNjYsMjAgKzM4NywyOCBAQCBzdGF0aWMgaW50IGFtZF9pb21tdV9hc3Np Z25fZGV2aWNlKHN0cnVjCiAgICAgc3RydWN0IGl2cnNfbWFwcGluZ3MgKml2 cnNfbWFwcGluZ3MgPSBnZXRfaXZyc19tYXBwaW5ncyhwZGV2LT5zZWcpOwog ICAgIGludCBiZGYgPSBQQ0lfQkRGMihwZGV2LT5idXMsIGRldmZuKTsKICAg ICBpbnQgcmVxX2lkID0gZ2V0X2RtYV9yZXF1ZXN0b3JfaWQocGRldi0+c2Vn LCBiZGYpOwotICAgIGNvbnN0IHN0cnVjdCBpdnJzX3VuaXR5X21hcCAqdW5p dHlfbWFwOworICAgIGludCByYyA9IGFtZF9pb21tdV9yZXNlcnZlX2RvbWFp bl91bml0eV9tYXAoCisgICAgICAgICAgICAgICAgIGQsIGl2cnNfbWFwcGlu Z3NbcmVxX2lkXS51bml0eV9tYXAsIGZsYWcpOworCisgICAgaWYgKCAhcmMg KQorICAgICAgICByYyA9IHJlYXNzaWduX2RldmljZShwZGV2LT5kb21haW4s IGQsIGRldmZuLCBwZGV2KTsKIAotICAgIGZvciAoIHVuaXR5X21hcCA9IGl2 cnNfbWFwcGluZ3NbcmVxX2lkXS51bml0eV9tYXA7IHVuaXR5X21hcDsKLSAg ICAgICAgICB1bml0eV9tYXAgPSB1bml0eV9tYXAtPm5leHQgKQorICAgIGlm ICggcmMgJiYgIWlzX2hhcmR3YXJlX2RvbWFpbihkKSApCiAgICAgewotICAg ICAgICBpbnQgcmMgPSBhbWRfaW9tbXVfcmVzZXJ2ZV9kb21haW5fdW5pdHlf bWFwKAotICAgICAgICAgICAgICAgICAgICAgZCwgdW5pdHlfbWFwLT5hZGRy LCB1bml0eV9tYXAtPmxlbmd0aCwKLSAgICAgICAgICAgICAgICAgICAgIHVu aXR5X21hcC0+d3JpdGUsIHVuaXR5X21hcC0+cmVhZCk7CisgICAgICAgIGlu dCByZXQgPSBhbWRfaW9tbXVfcmVzZXJ2ZV9kb21haW5fdW5pdHlfdW5tYXAo CisgICAgICAgICAgICAgICAgICAgICAgZCwgaXZyc19tYXBwaW5nc1tyZXFf aWRdLnVuaXR5X21hcCk7CiAKLSAgICAgICAgaWYgKCByYyApCi0gICAgICAg ICAgICByZXR1cm4gcmM7CisgICAgICAgIGlmICggcmV0ICkKKyAgICAgICAg eworICAgICAgICAgICAgcHJpbnRrKFhFTkxPR19FUlIgIkFNRC1WaTogIgor ICAgICAgICAgICAgICAgICAgICJ1bml0eS11bm1hcCBmb3IgJXBkLyUwNHg6 JTAyeDolMDJ4LiV1IGZhaWxlZCAoJWQpXG4iLAorICAgICAgICAgICAgICAg ICAgIGQsIHBkZXYtPnNlZywgcGRldi0+YnVzLAorICAgICAgICAgICAgICAg ICAgIFBDSV9TTE9UKGRldmZuKSwgUENJX0ZVTkMoZGV2Zm4pLCByZXQpOwor ICAgICAgICAgICAgZG9tYWluX2NyYXNoKGQpOworICAgICAgICB9CiAgICAg fQogCi0gICAgcmV0dXJuIHJlYXNzaWduX2RldmljZShwZGV2LT5kb21haW4s IGQsIGRldmZuLCBwZGV2KTsKKyAgICByZXR1cm4gcmM7CiB9CiAKIHN0YXRp YyB2b2lkIGRlYWxsb2NhdGVfbmV4dF9wYWdlX3RhYmxlKHN0cnVjdCBwYWdl X2luZm8gKnBnLCBpbnQgbGV2ZWwpCkBAIC00MzgsNiArNDY3LDcgQEAgc3Rh dGljIHZvaWQgZGVhbGxvY2F0ZV9pb21tdV9wYWdlX3RhYmxlcwogCiBzdGF0 aWMgdm9pZCBhbWRfaW9tbXVfZG9tYWluX2Rlc3Ryb3koc3RydWN0IGRvbWFp biAqZCkKIHsKKyAgICBpb21tdV9pZGVudGl0eV9tYXBfdGVhcmRvd24oZCk7 CiAgICAgZGVhbGxvY2F0ZV9pb21tdV9wYWdlX3RhYmxlcyhkKTsKICAgICBh bWRfaW9tbXVfZmx1c2hfYWxsX3BhZ2VzKGQpOwogfQo= --=separator Content-Type: application/octet-stream; name="xsa378/xsa378-4.14-6.patch" Content-Disposition: attachment; filename="xsa378/xsa378-4.14-6.patch" Content-Transfer-Encoding: base64 RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0 OiBBTUQvSU9NTVU6IHJlLWFycmFuZ2UgZXhjbHVzaW9uIHJhbmdlIGFuZCB1 bml0eSBtYXAgcmVjb3JkaW5nCgpUaGUgc3BlYyBtYWtlcyBubyBwcm92aXNp b25zIGZvciBPUyBiZWhhdmlvciBoZXJlIHRvIGRlcGVuZCBvbiB0aGUKYW1v dW50IG9mIFJBTSBmb3VuZCBvbiB0aGUgc3lzdGVtLiBXaGlsZSB0aGUgc3Bl YyBtYXkgbm90IHN1ZmZpY2llbnRseQpjbGVhcmx5IGRpc3Rpbmd1aXNoIGJv dGgga2luZHMgb2YgcmVnaW9ucywgdGhleSBhcmUgc3VyZWx5IG1lYW50IHRv IGJlCnNlcGFyYXRlIHRoaW5nczogT25seSByZWdpb25zIHdpdGggQUNQSV9J Vk1EX0VYQ0xVU0lPTl9SQU5HRSBzZXQgc2hvdWxkCmJlIGNhbmRpZGF0ZXMg Zm9yIHB1dHRpbmcgaW4gdGhlIGV4Y2x1c2lvbiByYW5nZSByZWdpc3RlcnMu IChBcyB0aGVyZSdzCm9ubHkgYSBzaW5nbGUgc3VjaCBwYWlyIG9mIHJlZ2lz dGVycyBwZXIgSU9NTVUsIHNlY29uZGFyeSBub24tYWRqYWNlbnQKcmVnaW9u cyB3aXRoIHRoZSBmbGFnIHNldCBhbHJlYWR5IGdldCBjb252ZXJ0ZWQgdG8g dW5pdHkgbWFwcGVkCnJlZ2lvbnMuKQoKRmlyc3Qgb2YgYWxsLCBkcm9wIHRo ZSBkZXBlbmRlbmN5IG9uIG1heF9wYWdlLiBXaXRoIGNvbW1pdCBiNGYwNDIy MzZhZTAKKCJBTUQvSU9NTVU6IENlYXNlIHVzaW5nIGEgZHluYW1pYyBoZWln aHQgZm9yIHRoZSBJT01NVSBwYWdldGFibGVzIikgdGhlCnVzZSBvZiBpdCBo ZXJlIHdhcyBzdGFsZSBhbnl3YXk7IGl0IHdhcyBib2d1cyBhbHJlYWR5IGJl Zm9yZSwgYXMgaXQKZGlkbid0IGFjY291bnQgZm9yIG1heF9wYWdlIGdldHRp bmcgaW5jcmVhc2VkIGxhdGVyIG9uLiBTaW1wbHkgdHJ5IGFuCmV4Y2x1c2lv biByYW5nZSByZWdpc3RyYXRpb24gZmlyc3QsIGFuZCBpZiBpdCBmYWlscyAo Zm9yIGJlaW5nCnVuc3VpdGFibGUgb3Igbm9uLW1lcmdlYWJsZSksIHJlZ2lz dGVyIGEgdW5pdHkgbWFwcGluZyByYW5nZS4KCldpdGggdGhpcyB2YXJpb3Vz IGxvY2FsIHZhcmlhYmxlcyBiZWNvbWUgdW5uZWNlc3NhcnkgYW5kIGhlbmNl IGdldApkcm9wcGVkIGF0IHRoZSBzYW1lIHRpbWUuCgpXaXRoIHRoZSBtYXhf cGFnZSBib3VuZGFyeSBkcm9wcGVkIGZvciB1c2luZyB1bml0eSBtYXBzLCB0 aGUgbWluaW11bQpwYWdlIHRhYmxlIHRyZWUgaGVpZ2h0IG5vdyBuZWVkcyBi b3RoIHJlY29yZGluZyBhbmQgZW5mb3JjaW5nIGluCmFtZF9pb21tdV9kb21h aW5faW5pdCgpLiBTaW5jZSB3ZSBjYW4ndCBwcmVkaWN0IHdoaWNoIGRldmlj ZXMgbWF5IGdldAphc3NpZ25lZCB0byBhIGRvbWFpbiwgb3VyIG9ubHkgb3B0 aW9uIGlzIHRvIHVuaWZvcm1seSBmb3JjZSBhdCBsZWFzdAp0aGF0IGhlaWdo dCBmb3IgYWxsIGRvbWFpbnMsIG5vdyB0aGF0IHRoZSBoZWlnaHQgaXNuJ3Qg ZHluYW1pYyBhbnltb3JlLgoKRnVydGhlciBkb24ndCBtYWtlIHVzZSBvZiB0 aGUgZXhjbHVzaW9uIHJhbmdlIHVubGVzcyBBQ1BJIGRhdGEgc2F5cyBzby4K Ck5vdGUgdGhhdCBleGNsdXNpb24gcmFuZ2UgcmVnaXN0cmF0aW9uIGluCnJl Z2lzdGVyX3JhbmdlX2Zvcl9hbGxfZGV2aWNlcygpIGlzIG9uIGEgYmVzdCBl ZmZvcnQgYmFzaXMuIEhlbmNlIHVuaXR5Cm1hcCBlbnRyaWVzIGFsc28gcmVn aXN0ZXJlZCBhcmUgcmVkdW5kYW50IHdoZW4gdGhlIGZvcm1lciBzdWNjZWVk ZWQsIGJ1dAp0aGV5IGFsc28gZG8gbm8gaGFybS4gSW1wcm92ZW1lbnRzIGlu IHRoaXMgYXJlYSBjYW4gYmUgZG9uZSBsYXRlciBpbW8uCgpBbHNvIGFkanVz dCB0eXBlcyB3aGVyZSBzdWl0YWJsZSB3aXRob3V0IHRvdWNoaW5nIGV4dHJh IGxpbmVzLgoKVGhpcyBpcyBwYXJ0IG9mIFhTQS0zNzguCgpTaWduZWQtb2Zm LWJ5OiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+ClJldmlld2Vk LWJ5OiBQYXVsIER1cnJhbnQgPHBhdWxAeGVuLm9yZz4KCi0tLSBhL3hlbi9k cml2ZXJzL3Bhc3N0aHJvdWdoL2FtZC9pb21tdS5oCisrKyBiL3hlbi9kcml2 ZXJzL3Bhc3N0aHJvdWdoL2FtZC9pb21tdS5oCkBAIC0zMDgsNiArMzA4LDgg QEAgZXh0ZXJuIHN0cnVjdCBocGV0X3NiZGYgewogICAgIH0gaW5pdDsKIH0g aHBldF9zYmRmOwogCitleHRlcm4gaW50IGFtZF9pb21tdV9taW5fcGFnaW5n X21vZGU7CisKIGV4dGVybiB2b2lkICpzaGFyZWRfaW50cmVtYXBfdGFibGU7 CiBleHRlcm4gdW5zaWduZWQgbG9uZyAqc2hhcmVkX2ludHJlbWFwX2ludXNl OwogCi0tLSBhL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL2FtZC9pb21tdV9h Y3BpLmMKKysrIGIveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvYW1kL2lvbW11 X2FjcGkuYwpAQCAtMTE4LDEyICsxMTgsOCBAQCBzdGF0aWMgc3RydWN0IGFt ZF9pb21tdSAqIF9faW5pdCBmaW5kX2lvCiB9CiAKIHN0YXRpYyBpbnQgX19p bml0IHJlc2VydmVfaW9tbXVfZXhjbHVzaW9uX3JhbmdlKAotICAgIHN0cnVj dCBhbWRfaW9tbXUgKmlvbW11LCB1aW50NjRfdCBiYXNlLCB1aW50NjRfdCBs aW1pdCwKLSAgICBib29sIGFsbCwgYm9vbCBpdywgYm9vbCBpcikKKyAgICBz dHJ1Y3QgYW1kX2lvbW11ICppb21tdSwgcGFkZHJfdCBiYXNlLCBwYWRkcl90 IGxpbWl0LCBib29sIGFsbCkKIHsKLSAgICBpZiAoICFpciB8fCAhaXcgKQot ICAgICAgICByZXR1cm4gLUVQRVJNOwotCiAgICAgLyogbmVlZCB0byBleHRl bmQgZXhjbHVzaW9uIHJhbmdlPyAqLwogICAgIGlmICggaW9tbXUtPmV4Y2x1 c2lvbl9lbmFibGUgKQogICAgIHsKQEAgLTE1MiwxNCArMTQ4LDE4IEBAIHN0 YXRpYyBpbnQgX19pbml0IHJlc2VydmVfdW5pdHlfbWFwX2Zvcl8KIHsKICAg ICBzdHJ1Y3QgaXZyc19tYXBwaW5ncyAqaXZyc19tYXBwaW5ncyA9IGdldF9p dnJzX21hcHBpbmdzKHNlZyk7CiAgICAgc3RydWN0IGl2cnNfdW5pdHlfbWFw ICp1bml0eV9tYXAgPSBpdnJzX21hcHBpbmdzW2JkZl0udW5pdHlfbWFwOwor ICAgIGludCBwYWdpbmdfbW9kZSA9IGFtZF9pb21tdV9nZXRfcGFnaW5nX21v ZGUoUEZOX1VQKGJhc2UgKyBsZW5ndGgpKTsKKworICAgIGlmICggcGFnaW5n X21vZGUgPCAwICkKKyAgICAgICAgcmV0dXJuIHBhZ2luZ19tb2RlOwogCiAg ICAgLyogQ2hlY2sgZm9yIG92ZXJsYXBzLiAqLwogICAgIGZvciAoIDsgdW5p dHlfbWFwOyB1bml0eV9tYXAgPSB1bml0eV9tYXAtPm5leHQgKQogICAgIHsK ICAgICAgICAgLyoKICAgICAgICAgICogRXhhY3QgbWF0Y2hlcyBhcmUgb2th eS4gVGhpcyBjYW4gaW4gcGFydGljdWxhciBoYXBwZW4gd2hlbgotICAgICAg ICAgKiByZWdpc3Rlcl9leGNsdXNpb25fcmFuZ2VfZm9yX2RldmljZSgpIGNh bGxzIGhlcmUgdHdpY2UgZm9yIHRoZQotICAgICAgICAgKiBzYW1lIChzLGIs ZCxmKS4KKyAgICAgICAgICogcmVnaXN0ZXJfcmFuZ2VfZm9yX2RldmljZSgp IGNhbGxzIGhlcmUgdHdpY2UgZm9yIHRoZSBzYW1lCisgICAgICAgICAqIChz LGIsZCxmKS4KICAgICAgICAgICovCiAgICAgICAgIGlmICggYmFzZSA9PSB1 bml0eV9tYXAtPmFkZHIgJiYgbGVuZ3RoID09IHVuaXR5X21hcC0+bGVuZ3Ro ICYmCiAgICAgICAgICAgICAgaXIgPT0gdW5pdHlfbWFwLT5yZWFkICYmIGl3 ID09IHVuaXR5X21hcC0+d3JpdGUgKQpAQCAtMTg3LDU1ICsxODcsNTIgQEAg c3RhdGljIGludCBfX2luaXQgcmVzZXJ2ZV91bml0eV9tYXBfZm9yXwogICAg IHVuaXR5X21hcC0+bmV4dCA9IGl2cnNfbWFwcGluZ3NbYmRmXS51bml0eV9t YXA7CiAgICAgaXZyc19tYXBwaW5nc1tiZGZdLnVuaXR5X21hcCA9IHVuaXR5 X21hcDsKIAorICAgIGlmICggcGFnaW5nX21vZGUgPiBhbWRfaW9tbXVfbWlu X3BhZ2luZ19tb2RlICkKKyAgICAgICAgYW1kX2lvbW11X21pbl9wYWdpbmdf bW9kZSA9IHBhZ2luZ19tb2RlOworCiAgICAgcmV0dXJuIDA7CiB9CiAKLXN0 YXRpYyBpbnQgX19pbml0IHJlZ2lzdGVyX2V4Y2x1c2lvbl9yYW5nZV9mb3Jf YWxsX2RldmljZXMoCi0gICAgdW5zaWduZWQgbG9uZyBiYXNlLCB1bnNpZ25l ZCBsb25nIGxpbWl0LCB1OCBpdywgdTggaXIpCitzdGF0aWMgaW50IF9faW5p dCByZWdpc3Rlcl9yYW5nZV9mb3JfYWxsX2RldmljZXMoCisgICAgcGFkZHJf dCBiYXNlLCBwYWRkcl90IGxpbWl0LCBib29sIGl3LCBib29sIGlyLCBib29s IGV4Y2x1c2lvbikKIHsKICAgICBpbnQgc2VnID0gMDsgLyogWFhYICovCi0g ICAgdW5zaWduZWQgbG9uZyByYW5nZV90b3AsIGlvbW11X3RvcCwgbGVuZ3Ro OwogICAgIHN0cnVjdCBhbWRfaW9tbXUgKmlvbW11OwotICAgIHVuc2lnbmVk IGludCBiZGY7CiAgICAgaW50IHJjID0gMDsKIAogICAgIC8qIGlzIHBhcnQg b2YgZXhjbHVzaW9uIHJhbmdlIGluc2lkZSBvZiBJT01NVSB2aXJ0dWFsIGFk ZHJlc3Mgc3BhY2U/ICovCiAgICAgLyogbm90ZTogJ2xpbWl0JyBwYXJhbWV0 ZXIgaXMgYXNzdW1lZCB0byBiZSBwYWdlLWFsaWduZWQgKi8KLSAgICByYW5n ZV90b3AgPSBsaW1pdCArIFBBR0VfU0laRTsKLSAgICBpb21tdV90b3AgPSBt YXhfcGFnZSAqIFBBR0VfU0laRTsKLSAgICBpZiAoIGJhc2UgPCBpb21tdV90 b3AgKQotICAgIHsKLSAgICAgICAgaWYgKCByYW5nZV90b3AgPiBpb21tdV90 b3AgKQotICAgICAgICAgICAgcmFuZ2VfdG9wID0gaW9tbXVfdG9wOwotICAg ICAgICBsZW5ndGggPSByYW5nZV90b3AgLSBiYXNlOwotICAgICAgICAvKiBy ZXNlcnZlIHIvdyB1bml0eS1tYXBwZWQgcGFnZSBlbnRyaWVzIGZvciBkZXZp Y2VzICovCi0gICAgICAgIC8qIG5vdGU6IHRoZXNlIGVudHJpZXMgYXJlIHBh cnQgb2YgdGhlIGV4Y2x1c2lvbiByYW5nZSAqLwotICAgICAgICBmb3IgKCBi ZGYgPSAwOyAhcmMgJiYgYmRmIDwgaXZyc19iZGZfZW50cmllczsgYmRmKysg KQotICAgICAgICAgICAgcmMgPSByZXNlcnZlX3VuaXR5X21hcF9mb3JfZGV2 aWNlKHNlZywgYmRmLCBiYXNlLCBsZW5ndGgsIGl3LCBpcik7Ci0gICAgICAg IC8qIHB1c2ggJ2Jhc2UnIGp1c3Qgb3V0c2lkZSBvZiB2aXJ0dWFsIGFkZHJl c3Mgc3BhY2UgKi8KLSAgICAgICAgYmFzZSA9IGlvbW11X3RvcDsKLSAgICB9 Ci0gICAgLyogcmVnaXN0ZXIgSU9NTVUgZXhjbHVzaW9uIHJhbmdlIHNldHRp bmdzICovCi0gICAgaWYgKCAhcmMgJiYgbGltaXQgPj0gaW9tbXVfdG9wICkK KyAgICBpZiAoIGV4Y2x1c2lvbiApCiAgICAgewogICAgICAgICBmb3JfZWFj aF9hbWRfaW9tbXUoIGlvbW11ICkKICAgICAgICAgewotICAgICAgICAgICAg cmMgPSByZXNlcnZlX2lvbW11X2V4Y2x1c2lvbl9yYW5nZShpb21tdSwgYmFz ZSwgbGltaXQsCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIHRydWUgLyogYWxsICovLCBpdywgaXIpOwotICAgICAg ICAgICAgaWYgKCByYyApCi0gICAgICAgICAgICAgICAgYnJlYWs7CisgICAg ICAgICAgICBpbnQgcmV0ID0gcmVzZXJ2ZV9pb21tdV9leGNsdXNpb25fcmFu Z2UoaW9tbXUsIGJhc2UsIGxpbWl0LAorICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHRydWUgLyogYWxsICov KTsKKworICAgICAgICAgICAgaWYgKCByZXQgJiYgIXJjICkKKyAgICAgICAg ICAgICAgICByYyA9IHJldDsKICAgICAgICAgfQogICAgIH0KIAorICAgIGlm ICggIWV4Y2x1c2lvbiB8fCByYyApCisgICAgeworICAgICAgICBwYWRkcl90 IGxlbmd0aCA9IGxpbWl0ICsgUEFHRV9TSVpFIC0gYmFzZTsKKyAgICAgICAg dW5zaWduZWQgaW50IGJkZjsKKworICAgICAgICAvKiByZXNlcnZlIHIvdyB1 bml0eS1tYXBwZWQgcGFnZSBlbnRyaWVzIGZvciBkZXZpY2VzICovCisgICAg ICAgIGZvciAoIGJkZiA9IHJjID0gMDsgIXJjICYmIGJkZiA8IGl2cnNfYmRm X2VudHJpZXM7IGJkZisrICkKKyAgICAgICAgICAgIHJjID0gcmVzZXJ2ZV91 bml0eV9tYXBfZm9yX2RldmljZShzZWcsIGJkZiwgYmFzZSwgbGVuZ3RoLCBp dywgaXIpOworICAgIH0KKwogICAgIHJldHVybiByYzsKIH0KIAotc3RhdGlj IGludCBfX2luaXQgcmVnaXN0ZXJfZXhjbHVzaW9uX3JhbmdlX2Zvcl9kZXZp Y2UoCi0gICAgdTE2IGJkZiwgdW5zaWduZWQgbG9uZyBiYXNlLCB1bnNpZ25l ZCBsb25nIGxpbWl0LCB1OCBpdywgdTggaXIpCitzdGF0aWMgaW50IF9faW5p dCByZWdpc3Rlcl9yYW5nZV9mb3JfZGV2aWNlKAorICAgIHVuc2lnbmVkIGlu dCBiZGYsIHBhZGRyX3QgYmFzZSwgcGFkZHJfdCBsaW1pdCwKKyAgICBib29s IGl3LCBib29sIGlyLCBib29sIGV4Y2x1c2lvbikKIHsKICAgICBpbnQgc2Vn ID0gMDsgLyogWFhYICovCiAgICAgc3RydWN0IGl2cnNfbWFwcGluZ3MgKml2 cnNfbWFwcGluZ3MgPSBnZXRfaXZyc19tYXBwaW5ncyhzZWcpOwotICAgIHVu c2lnbmVkIGxvbmcgcmFuZ2VfdG9wLCBpb21tdV90b3AsIGxlbmd0aDsKICAg ICBzdHJ1Y3QgYW1kX2lvbW11ICppb21tdTsKICAgICB1MTYgcmVxOwogICAg IGludCByYyA9IDA7CkBAIC0yNDksMjcgKzI0NiwxOSBAQCBzdGF0aWMgaW50 IF9faW5pdCByZWdpc3Rlcl9leGNsdXNpb25fcmFuCiAgICAgcmVxID0gaXZy c19tYXBwaW5nc1tiZGZdLmR0ZV9yZXF1ZXN0b3JfaWQ7CiAKICAgICAvKiBu b3RlOiAnbGltaXQnIHBhcmFtZXRlciBpcyBhc3N1bWVkIHRvIGJlIHBhZ2Ut YWxpZ25lZCAqLwotICAgIHJhbmdlX3RvcCA9IGxpbWl0ICsgUEFHRV9TSVpF OwotICAgIGlvbW11X3RvcCA9IG1heF9wYWdlICogUEFHRV9TSVpFOwotICAg IGlmICggYmFzZSA8IGlvbW11X3RvcCApCi0gICAgewotICAgICAgICBpZiAo IHJhbmdlX3RvcCA+IGlvbW11X3RvcCApCi0gICAgICAgICAgICByYW5nZV90 b3AgPSBpb21tdV90b3A7Ci0gICAgICAgIGxlbmd0aCA9IHJhbmdlX3RvcCAt IGJhc2U7CisgICAgaWYgKCBleGNsdXNpb24gKQorICAgICAgICByYyA9IHJl c2VydmVfaW9tbXVfZXhjbHVzaW9uX3JhbmdlKGlvbW11LCBiYXNlLCBsaW1p dCwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBmYWxzZSAvKiBhbGwgKi8pOworICAgIGlmICggIWV4Y2x1c2lvbiB8fCBy YyApCisgICAgeworICAgICAgICBwYWRkcl90IGxlbmd0aCA9IGxpbWl0ICsg UEFHRV9TSVpFIC0gYmFzZTsKKwogICAgICAgICAvKiByZXNlcnZlIHVuaXR5 LW1hcHBlZCBwYWdlIGVudHJpZXMgZm9yIGRldmljZSAqLwotICAgICAgICAv KiBub3RlOiB0aGVzZSBlbnRyaWVzIGFyZSBwYXJ0IG9mIHRoZSBleGNsdXNp b24gcmFuZ2UgKi8KICAgICAgICAgcmMgPSByZXNlcnZlX3VuaXR5X21hcF9m b3JfZGV2aWNlKHNlZywgYmRmLCBiYXNlLCBsZW5ndGgsIGl3LCBpcikgPzoK ICAgICAgICAgICAgICByZXNlcnZlX3VuaXR5X21hcF9mb3JfZGV2aWNlKHNl ZywgcmVxLCBiYXNlLCBsZW5ndGgsIGl3LCBpcik7Ci0KLSAgICAgICAgLyog cHVzaCAnYmFzZScganVzdCBvdXRzaWRlIG9mIHZpcnR1YWwgYWRkcmVzcyBz cGFjZSAqLwotICAgICAgICBiYXNlID0gaW9tbXVfdG9wOwogICAgIH0KLQot ICAgIC8qIHJlZ2lzdGVyIElPTU1VIGV4Y2x1c2lvbiByYW5nZSBzZXR0aW5n cyBmb3IgZGV2aWNlICovCi0gICAgaWYgKCAhcmMgJiYgbGltaXQgPj0gaW9t bXVfdG9wICApCisgICAgZWxzZQogICAgIHsKLSAgICAgICAgcmMgPSByZXNl cnZlX2lvbW11X2V4Y2x1c2lvbl9yYW5nZShpb21tdSwgYmFzZSwgbGltaXQs Ci0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ZmFsc2UgLyogYWxsICovLCBpdywgaXIpOwogICAgICAgICBpdnJzX21hcHBp bmdzW2JkZl0uZHRlX2FsbG93X2V4Y2x1c2lvbiA9IHRydWU7CiAgICAgICAg IGl2cnNfbWFwcGluZ3NbcmVxXS5kdGVfYWxsb3dfZXhjbHVzaW9uID0gdHJ1 ZTsKICAgICB9CkBAIC0yNzcsNTMgKzI2Niw0MiBAQCBzdGF0aWMgaW50IF9f aW5pdCByZWdpc3Rlcl9leGNsdXNpb25fcmFuCiAgICAgcmV0dXJuIHJjOwog fQogCi1zdGF0aWMgaW50IF9faW5pdCByZWdpc3Rlcl9leGNsdXNpb25fcmFu Z2VfZm9yX2lvbW11X2RldmljZXMoCi0gICAgc3RydWN0IGFtZF9pb21tdSAq aW9tbXUsCi0gICAgdW5zaWduZWQgbG9uZyBiYXNlLCB1bnNpZ25lZCBsb25n IGxpbWl0LCB1OCBpdywgdTggaXIpCitzdGF0aWMgaW50IF9faW5pdCByZWdp c3Rlcl9yYW5nZV9mb3JfaW9tbXVfZGV2aWNlcygKKyAgICBzdHJ1Y3QgYW1k X2lvbW11ICppb21tdSwgcGFkZHJfdCBiYXNlLCBwYWRkcl90IGxpbWl0LAor ICAgIGJvb2wgaXcsIGJvb2wgaXIsIGJvb2wgZXhjbHVzaW9uKQogewotICAg IHVuc2lnbmVkIGxvbmcgcmFuZ2VfdG9wLCBpb21tdV90b3AsIGxlbmd0aDsK KyAgICAvKiBub3RlOiAnbGltaXQnIHBhcmFtZXRlciBpcyBhc3N1bWVkIHRv IGJlIHBhZ2UtYWxpZ25lZCAqLworICAgIHBhZGRyX3QgbGVuZ3RoID0gbGlt aXQgKyBQQUdFX1NJWkUgLSBiYXNlOwogICAgIHVuc2lnbmVkIGludCBiZGY7 CiAgICAgdTE2IHJlcTsKLSAgICBpbnQgcmMgPSAwOworICAgIGludCByYzsK IAotICAgIC8qIGlzIHBhcnQgb2YgZXhjbHVzaW9uIHJhbmdlIGluc2lkZSBv ZiBJT01NVSB2aXJ0dWFsIGFkZHJlc3Mgc3BhY2U/ICovCi0gICAgLyogbm90 ZTogJ2xpbWl0JyBwYXJhbWV0ZXIgaXMgYXNzdW1lZCB0byBiZSBwYWdlLWFs aWduZWQgKi8KLSAgICByYW5nZV90b3AgPSBsaW1pdCArIFBBR0VfU0laRTsK LSAgICBpb21tdV90b3AgPSBtYXhfcGFnZSAqIFBBR0VfU0laRTsKLSAgICBp ZiAoIGJhc2UgPCBpb21tdV90b3AgKQotICAgIHsKLSAgICAgICAgaWYgKCBy YW5nZV90b3AgPiBpb21tdV90b3AgKQotICAgICAgICAgICAgcmFuZ2VfdG9w ID0gaW9tbXVfdG9wOwotICAgICAgICBsZW5ndGggPSByYW5nZV90b3AgLSBi YXNlOwotICAgICAgICAvKiByZXNlcnZlIHIvdyB1bml0eS1tYXBwZWQgcGFn ZSBlbnRyaWVzIGZvciBkZXZpY2VzICovCi0gICAgICAgIC8qIG5vdGU6IHRo ZXNlIGVudHJpZXMgYXJlIHBhcnQgb2YgdGhlIGV4Y2x1c2lvbiByYW5nZSAq LwotICAgICAgICBmb3IgKCBiZGYgPSAwOyAhcmMgJiYgYmRmIDwgaXZyc19i ZGZfZW50cmllczsgYmRmKysgKQotICAgICAgICB7Ci0gICAgICAgICAgICBp ZiAoIGlvbW11ID09IGZpbmRfaW9tbXVfZm9yX2RldmljZShpb21tdS0+c2Vn LCBiZGYpICkKLSAgICAgICAgICAgIHsKLSAgICAgICAgICAgICAgICByZXEg PSBnZXRfaXZyc19tYXBwaW5ncyhpb21tdS0+c2VnKVtiZGZdLmR0ZV9yZXF1 ZXN0b3JfaWQ7Ci0gICAgICAgICAgICAgICAgcmMgPSByZXNlcnZlX3VuaXR5 X21hcF9mb3JfZGV2aWNlKGlvbW11LT5zZWcsIGJkZiwgYmFzZSwgbGVuZ3Ro LAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICBpdywgaXIpID86Ci0gICAgICAgICAgICAgICAgICAgICByZXNl cnZlX3VuaXR5X21hcF9mb3JfZGV2aWNlKGlvbW11LT5zZWcsIHJlcSwgYmFz ZSwgbGVuZ3RoLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBpdywgaXIpOwotICAgICAgICAgICAgfQotICAg ICAgICB9Ci0KLSAgICAgICAgLyogcHVzaCAnYmFzZScganVzdCBvdXRzaWRl IG9mIHZpcnR1YWwgYWRkcmVzcyBzcGFjZSAqLwotICAgICAgICBiYXNlID0g aW9tbXVfdG9wOworICAgIGlmICggZXhjbHVzaW9uICkKKyAgICB7CisgICAg ICAgIHJjID0gcmVzZXJ2ZV9pb21tdV9leGNsdXNpb25fcmFuZ2UoaW9tbXUs IGJhc2UsIGxpbWl0LCB0cnVlIC8qIGFsbCAqLyk7CisgICAgICAgIGlmICgg IXJjICkKKyAgICAgICAgICAgIHJldHVybiAwOwogICAgIH0KIAotICAgIC8q IHJlZ2lzdGVyIElPTU1VIGV4Y2x1c2lvbiByYW5nZSBzZXR0aW5ncyAqLwot ICAgIGlmICggIXJjICYmIGxpbWl0ID49IGlvbW11X3RvcCApCi0gICAgICAg IHJjID0gcmVzZXJ2ZV9pb21tdV9leGNsdXNpb25fcmFuZ2UoaW9tbXUsIGJh c2UsIGxpbWl0LAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIHRydWUgLyogYWxsICovLCBpdywgaXIpOworICAgIC8qIHJl c2VydmUgdW5pdHktbWFwcGVkIHBhZ2UgZW50cmllcyBmb3IgZGV2aWNlcyAq LworICAgIGZvciAoIGJkZiA9IHJjID0gMDsgIXJjICYmIGJkZiA8IGl2cnNf YmRmX2VudHJpZXM7IGJkZisrICkKKyAgICB7CisgICAgICAgIGlmICggaW9t bXUgIT0gZmluZF9pb21tdV9mb3JfZGV2aWNlKGlvbW11LT5zZWcsIGJkZikg KQorICAgICAgICAgICAgY29udGludWU7CisKKyAgICAgICAgcmVxID0gZ2V0 X2l2cnNfbWFwcGluZ3MoaW9tbXUtPnNlZylbYmRmXS5kdGVfcmVxdWVzdG9y X2lkOworICAgICAgICByYyA9IHJlc2VydmVfdW5pdHlfbWFwX2Zvcl9kZXZp Y2UoaW9tbXUtPnNlZywgYmRmLCBiYXNlLCBsZW5ndGgsCisgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBpdywgaXIpID86Cisg ICAgICAgICAgICAgcmVzZXJ2ZV91bml0eV9tYXBfZm9yX2RldmljZShpb21t dS0+c2VnLCByZXEsIGJhc2UsIGxlbmd0aCwKKyAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIGl3LCBpcik7CisgICAgfQogCiAg ICAgcmV0dXJuIHJjOwogfQogCiBzdGF0aWMgaW50IF9faW5pdCBwYXJzZV9p dm1kX2RldmljZV9zZWxlY3QoCiAgICAgY29uc3Qgc3RydWN0IGFjcGlfaXZy c19tZW1vcnkgKml2bWRfYmxvY2ssCi0gICAgdW5zaWduZWQgbG9uZyBiYXNl LCB1bnNpZ25lZCBsb25nIGxpbWl0LCB1OCBpdywgdTggaXIpCisgICAgcGFk ZHJfdCBiYXNlLCBwYWRkcl90IGxpbWl0LCBib29sIGl3LCBib29sIGlyLCBi b29sIGV4Y2x1c2lvbikKIHsKICAgICB1MTYgYmRmOwogCkBAIC0zMzQsMTIg KzMxMiwxMiBAQCBzdGF0aWMgaW50IF9faW5pdCBwYXJzZV9pdm1kX2Rldmlj ZV9zZWxlCiAgICAgICAgIHJldHVybiAtRU5PREVWOwogICAgIH0KIAotICAg IHJldHVybiByZWdpc3Rlcl9leGNsdXNpb25fcmFuZ2VfZm9yX2RldmljZShi ZGYsIGJhc2UsIGxpbWl0LCBpdywgaXIpOworICAgIHJldHVybiByZWdpc3Rl cl9yYW5nZV9mb3JfZGV2aWNlKGJkZiwgYmFzZSwgbGltaXQsIGl3LCBpciwg ZXhjbHVzaW9uKTsKIH0KIAogc3RhdGljIGludCBfX2luaXQgcGFyc2VfaXZt ZF9kZXZpY2VfcmFuZ2UoCiAgICAgY29uc3Qgc3RydWN0IGFjcGlfaXZyc19t ZW1vcnkgKml2bWRfYmxvY2ssCi0gICAgdW5zaWduZWQgbG9uZyBiYXNlLCB1 bnNpZ25lZCBsb25nIGxpbWl0LCB1OCBpdywgdTggaXIpCisgICAgcGFkZHJf dCBiYXNlLCBwYWRkcl90IGxpbWl0LCBib29sIGl3LCBib29sIGlyLCBib29s IGV4Y2x1c2lvbikKIHsKICAgICB1bnNpZ25lZCBpbnQgZmlyc3RfYmRmLCBs YXN0X2JkZiwgYmRmOwogICAgIGludCBlcnJvcjsKQEAgLTM2MSwxNSArMzM5 LDE1IEBAIHN0YXRpYyBpbnQgX19pbml0IHBhcnNlX2l2bWRfZGV2aWNlX3Jh bmcKICAgICB9CiAKICAgICBmb3IgKCBiZGYgPSBmaXJzdF9iZGYsIGVycm9y ID0gMDsgKGJkZiA8PSBsYXN0X2JkZikgJiYgIWVycm9yOyBiZGYrKyApCi0g ICAgICAgIGVycm9yID0gcmVnaXN0ZXJfZXhjbHVzaW9uX3JhbmdlX2Zvcl9k ZXZpY2UoCi0gICAgICAgICAgICBiZGYsIGJhc2UsIGxpbWl0LCBpdywgaXIp OworICAgICAgICBlcnJvciA9IHJlZ2lzdGVyX3JhbmdlX2Zvcl9kZXZpY2Uo CisgICAgICAgICAgICBiZGYsIGJhc2UsIGxpbWl0LCBpdywgaXIsIGV4Y2x1 c2lvbik7CiAKICAgICByZXR1cm4gZXJyb3I7CiB9CiAKIHN0YXRpYyBpbnQg X19pbml0IHBhcnNlX2l2bWRfZGV2aWNlX2lvbW11KAogICAgIGNvbnN0IHN0 cnVjdCBhY3BpX2l2cnNfbWVtb3J5ICppdm1kX2Jsb2NrLAotICAgIHVuc2ln bmVkIGxvbmcgYmFzZSwgdW5zaWduZWQgbG9uZyBsaW1pdCwgdTggaXcsIHU4 IGlyKQorICAgIHBhZGRyX3QgYmFzZSwgcGFkZHJfdCBsaW1pdCwgYm9vbCBp dywgYm9vbCBpciwgYm9vbCBleGNsdXNpb24pCiB7CiAgICAgaW50IHNlZyA9 IDA7IC8qIFhYWCAqLwogICAgIHN0cnVjdCBhbWRfaW9tbXUgKmlvbW11OwpA QCAtMzg0LDE0ICszNjIsMTQgQEAgc3RhdGljIGludCBfX2luaXQgcGFyc2Vf aXZtZF9kZXZpY2VfaW9tbQogICAgICAgICByZXR1cm4gLUVOT0RFVjsKICAg ICB9CiAKLSAgICByZXR1cm4gcmVnaXN0ZXJfZXhjbHVzaW9uX3JhbmdlX2Zv cl9pb21tdV9kZXZpY2VzKAotICAgICAgICBpb21tdSwgYmFzZSwgbGltaXQs IGl3LCBpcik7CisgICAgcmV0dXJuIHJlZ2lzdGVyX3JhbmdlX2Zvcl9pb21t dV9kZXZpY2VzKAorICAgICAgICBpb21tdSwgYmFzZSwgbGltaXQsIGl3LCBp ciwgZXhjbHVzaW9uKTsKIH0KIAogc3RhdGljIGludCBfX2luaXQgcGFyc2Vf aXZtZF9ibG9jayhjb25zdCBzdHJ1Y3QgYWNwaV9pdnJzX21lbW9yeSAqaXZt ZF9ibG9jaykKIHsKICAgICB1bnNpZ25lZCBsb25nIHN0YXJ0X2FkZHIsIG1l bV9sZW5ndGgsIGJhc2UsIGxpbWl0OwotICAgIHU4IGl3LCBpcjsKKyAgICBi b29sIGl3ID0gdHJ1ZSwgaXIgPSB0cnVlLCBleGNsdXNpb24gPSBmYWxzZTsK IAogICAgIGlmICggaXZtZF9ibG9jay0+aGVhZGVyLmxlbmd0aCA8IHNpemVv ZigqaXZtZF9ibG9jaykgKQogICAgIHsKQEAgLTQwOCwxMyArMzg2LDExIEBA IHN0YXRpYyBpbnQgX19pbml0IHBhcnNlX2l2bWRfYmxvY2soY29uc3QKICAg ICAgICAgICAgICAgICAgICAgaXZtZF9ibG9jay0+aGVhZGVyLnR5cGUsIHN0 YXJ0X2FkZHIsIG1lbV9sZW5ndGgpOwogCiAgICAgaWYgKCBpdm1kX2Jsb2Nr LT5oZWFkZXIuZmxhZ3MgJiBBQ1BJX0lWTURfRVhDTFVTSU9OX1JBTkdFICkK LSAgICAgICAgaXcgPSBpciA9IElPTU1VX0NPTlRST0xfRU5BQkxFRDsKKyAg ICAgICAgZXhjbHVzaW9uID0gdHJ1ZTsKICAgICBlbHNlIGlmICggaXZtZF9i bG9jay0+aGVhZGVyLmZsYWdzICYgQUNQSV9JVk1EX1VOSVRZICkKICAgICB7 Ci0gICAgICAgIGl3ID0gaXZtZF9ibG9jay0+aGVhZGVyLmZsYWdzICYgQUNQ SV9JVk1EX1JFQUQgPwotICAgICAgICAgICAgSU9NTVVfQ09OVFJPTF9FTkFC TEVEIDogSU9NTVVfQ09OVFJPTF9ESVNBQkxFRDsKLSAgICAgICAgaXIgPSBp dm1kX2Jsb2NrLT5oZWFkZXIuZmxhZ3MgJiBBQ1BJX0lWTURfV1JJVEUgPwot ICAgICAgICAgICAgSU9NTVVfQ09OVFJPTF9FTkFCTEVEIDogSU9NTVVfQ09O VFJPTF9ESVNBQkxFRDsKKyAgICAgICAgaXcgPSBpdm1kX2Jsb2NrLT5oZWFk ZXIuZmxhZ3MgJiBBQ1BJX0lWTURfUkVBRDsKKyAgICAgICAgaXIgPSBpdm1k X2Jsb2NrLT5oZWFkZXIuZmxhZ3MgJiBBQ1BJX0lWTURfV1JJVEU7CiAgICAg fQogICAgIGVsc2UKICAgICB7CkBAIC00MjUsMjAgKzQwMSwyMCBAQCBzdGF0 aWMgaW50IF9faW5pdCBwYXJzZV9pdm1kX2Jsb2NrKGNvbnN0CiAgICAgc3dp dGNoKCBpdm1kX2Jsb2NrLT5oZWFkZXIudHlwZSApCiAgICAgewogICAgIGNh c2UgQUNQSV9JVlJTX1RZUEVfTUVNT1JZX0FMTDoKLSAgICAgICAgcmV0dXJu IHJlZ2lzdGVyX2V4Y2x1c2lvbl9yYW5nZV9mb3JfYWxsX2RldmljZXMoCi0g ICAgICAgICAgICBiYXNlLCBsaW1pdCwgaXcsIGlyKTsKKyAgICAgICAgcmV0 dXJuIHJlZ2lzdGVyX3JhbmdlX2Zvcl9hbGxfZGV2aWNlcygKKyAgICAgICAg ICAgIGJhc2UsIGxpbWl0LCBpdywgaXIsIGV4Y2x1c2lvbik7CiAKICAgICBj YXNlIEFDUElfSVZSU19UWVBFX01FTU9SWV9PTkU6Ci0gICAgICAgIHJldHVy biBwYXJzZV9pdm1kX2RldmljZV9zZWxlY3QoaXZtZF9ibG9jaywKLSAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBiYXNlLCBsaW1p dCwgaXcsIGlyKTsKKyAgICAgICAgcmV0dXJuIHBhcnNlX2l2bWRfZGV2aWNl X3NlbGVjdChpdm1kX2Jsb2NrLCBiYXNlLCBsaW1pdCwKKyAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBpdywgaXIsIGV4Y2x1c2lv bik7CiAKICAgICBjYXNlIEFDUElfSVZSU19UWVBFX01FTU9SWV9SQU5HRToK LSAgICAgICAgcmV0dXJuIHBhcnNlX2l2bWRfZGV2aWNlX3JhbmdlKGl2bWRf YmxvY2ssCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBiYXNlLCBsaW1pdCwgaXcsIGlyKTsKKyAgICAgICAgcmV0dXJuIHBhcnNl X2l2bWRfZGV2aWNlX3JhbmdlKGl2bWRfYmxvY2ssIGJhc2UsIGxpbWl0LAor ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgaXcsIGly LCBleGNsdXNpb24pOwogCiAgICAgY2FzZSBBQ1BJX0lWUlNfVFlQRV9NRU1P UllfSU9NTVU6Ci0gICAgICAgIHJldHVybiBwYXJzZV9pdm1kX2RldmljZV9p b21tdShpdm1kX2Jsb2NrLAotICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgYmFzZSwgbGltaXQsIGl3LCBpcik7CisgICAgICAgIHJl dHVybiBwYXJzZV9pdm1kX2RldmljZV9pb21tdShpdm1kX2Jsb2NrLCBiYXNl LCBsaW1pdCwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIGl3LCBpciwgZXhjbHVzaW9uKTsKIAogICAgIGRlZmF1bHQ6CiAgICAg ICAgIEFNRF9JT01NVV9ERUJVRygiSVZNRCBFcnJvcjogSW52YWxpZCBCbG9j ayBUeXBlIVxuIik7Ci0tLSBhL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL2Ft ZC9wY2lfYW1kX2lvbW11LmMKKysrIGIveGVuL2RyaXZlcnMvcGFzc3Rocm91 Z2gvYW1kL3BjaV9hbWRfaW9tbXUuYwpAQCAtMjMxLDYgKzIzMSw4IEBAIHN0 YXRpYyBpbnQgX19tdXN0X2NoZWNrIGFsbG9jYXRlX2RvbWFpbl8KICAgICBy ZXR1cm4gcmM7CiB9CiAKK2ludCBfX3JlYWRfbW9zdGx5IGFtZF9pb21tdV9t aW5fcGFnaW5nX21vZGUgPSAxOworCiBzdGF0aWMgaW50IGFtZF9pb21tdV9k b21haW5faW5pdChzdHJ1Y3QgZG9tYWluICpkKQogewogICAgIHN0cnVjdCBk b21haW5faW9tbXUgKmhkID0gZG9tX2lvbW11KGQpOwpAQCAtMjQyLDExICsy NDQsMTMgQEAgc3RhdGljIGludCBhbWRfaW9tbXVfZG9tYWluX2luaXQoc3Ry dWN0CiAgICAgICogLSBIVk0gY291bGQgaW4gcHJpbmNpcGxlIHVzZSAzIG9y IDQgZGVwZW5kaW5nIG9uIGhvdyBtdWNoIGd1ZXN0CiAgICAgICogICBwaHlz aWNhbCBhZGRyZXNzIHNwYWNlIHdlIGdpdmUgaXQsIGJ1dCB0aGlzIGlzbid0 IGtub3duIHlldCBzbyB1c2UgNAogICAgICAqICAgdW5pbGF0ZXJhbGx5Lgor ICAgICAqIC0gVW5pdHkgbWFwcyBtYXkgcmVxdWlyZSBhbiBldmVuIGhpZ2hl ciBudW1iZXIuCiAgICAgICovCi0gICAgaGQtPmFyY2gucGFnaW5nX21vZGUg PSBhbWRfaW9tbXVfZ2V0X3BhZ2luZ19tb2RlKAotICAgICAgICBpc19odm1f ZG9tYWluKGQpCi0gICAgICAgID8gMXVsIDw8IChERUZBVUxUX0RPTUFJTl9B RERSRVNTX1dJRFRIIC0gUEFHRV9TSElGVCkKLSAgICAgICAgOiBnZXRfdXBw ZXJfbWZuX2JvdW5kKCkgKyAxKTsKKyAgICBoZC0+YXJjaC5wYWdpbmdfbW9k ZSA9IG1heChhbWRfaW9tbXVfZ2V0X3BhZ2luZ19tb2RlKAorICAgICAgICAg ICAgaXNfaHZtX2RvbWFpbihkKQorICAgICAgICAgICAgPyAxdWwgPDwgKERF RkFVTFRfRE9NQUlOX0FERFJFU1NfV0lEVEggLSBQQUdFX1NISUZUKQorICAg ICAgICAgICAgOiBnZXRfdXBwZXJfbWZuX2JvdW5kKCkgKyAxKSwKKyAgICAg ICAgYW1kX2lvbW11X21pbl9wYWdpbmdfbW9kZSk7CiAKICAgICByZXR1cm4g MDsKIH0K --=separator Content-Type: application/octet-stream; name="xsa378/xsa378-4.14-7.patch" Content-Disposition: attachment; filename="xsa378/xsa378-4.14-7.patch" Content-Transfer-Encoding: base64 RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0 OiB4ODYvcDJtOiBpbnRyb2R1Y2UgcDJtX2lzX3NwZWNpYWwoKQoKU2VlaW5n IHRoZSBzaW1pbGFyaXR5IG9mIGdyYW50LCBmb3JlaWduLCBhbmQgKHN1YnNl cXVlbnRseSkgZGlyZWN0LU1NSU8KaGFuZGxpbmcsIGludHJvZHVjZSBhIG5l dyBQMk0gdHlwZSBncm91cCBuYW1lZCAic3BlY2lhbCIgKGFzIGluICJuZWVk aW5nCnNwZWNpYWwgYWNjZXNzb3JzIHRvIGNyZWF0ZS9kZXN0cm95IikuCgpB bHNvIHVzZSAtRVBFUk0gaW5zdGVhZCBvZiBvdGhlciBlcnJvciBjb2RlcyBv biB0aGUgdHdvIGRvbWFpbl9jcmFzaCgpCnBhdGhzIHRvdWNoZWQuCgpUaGlz IGlzIHBhcnQgb2YgWFNBLTM3OC4KClNpZ25lZC1vZmYtYnk6IEphbiBCZXVs aWNoIDxqYmV1bGljaEBzdXNlLmNvbT4KUmV2aWV3ZWQtYnk6IFBhdWwgRHVy cmFudCA8cGF1bEB4ZW4ub3JnPgoKLS0tIGEveGVuL2FyY2gveDg2L21tL3Ay bS5jCisrKyBiL3hlbi9hcmNoL3g4Ni9tbS9wMm0uYwpAQCAtODA3LDcgKzgw Nyw3IEBAIHAybV9yZW1vdmVfcGFnZShzdHJ1Y3QgcDJtX2RvbWFpbiAqcDJt LAogICAgICAgICBmb3IgKCBpID0gMDsgaSA8ICgxVUwgPDwgcGFnZV9vcmRl cik7IGkrKyApCiAgICAgICAgIHsKICAgICAgICAgICAgIHAybS0+Z2V0X2Vu dHJ5KHAybSwgZ2ZuX2FkZChnZm4sIGkpLCAmdCwgJmEsIDAsIE5VTEwsIE5V TEwpOwotICAgICAgICAgICAgaWYgKCAhcDJtX2lzX2dyYW50KHQpICYmICFw Mm1faXNfc2hhcmVkKHQpICYmICFwMm1faXNfZm9yZWlnbih0KSApCisgICAg ICAgICAgICBpZiAoICFwMm1faXNfc3BlY2lhbCh0KSAmJiAhcDJtX2lzX3No YXJlZCh0KSApCiAgICAgICAgICAgICAgICAgc2V0X2dwZm5fZnJvbV9tZm4o bWZuX3gobWZuKSArIGksIElOVkFMSURfTTJQX0VOVFJZKTsKICAgICAgICAg fQogICAgIH0KQEAgLTkzNSwxMyArOTM1LDEzIEBAIGd1ZXN0X3BoeXNtYXBf YWRkX2VudHJ5KHN0cnVjdCBkb21haW4gKmQKICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAmb3QsICZhLCAwLCBOVUxMLCBOVUxMKTsKICAg ICAgICAgICAgIEFTU0VSVCghcDJtX2lzX3NoYXJlZChvdCkpOwogICAgICAg ICB9Ci0gICAgICAgIGlmICggcDJtX2lzX2dyYW50KG90KSB8fCBwMm1faXNf Zm9yZWlnbihvdCkgKQorICAgICAgICBpZiAoIHAybV9pc19zcGVjaWFsKG90 KSApCiAgICAgICAgIHsKLSAgICAgICAgICAgIC8qIFJlYWxseSBzaG91bGRu J3QgYmUgdW5tYXBwaW5nIGdyYW50L2ZvcmVpZ24gbWFwcyB0aGlzIHdheSAq LworICAgICAgICAgICAgLyogRG9uJ3QgcGVybWl0IHVubWFwcGluZyBncmFu dC9mb3JlaWduIHRoaXMgd2F5LiAqLwogICAgICAgICAgICAgZG9tYWluX2Ny YXNoKGQpOwogICAgICAgICAgICAgcDJtX3VubG9jayhwMm0pOwogICAgICAg ICAgICAgCi0gICAgICAgICAgICByZXR1cm4gLUVJTlZBTDsKKyAgICAgICAg ICAgIHJldHVybiAtRVBFUk07CiAgICAgICAgIH0KICAgICAgICAgZWxzZSBp ZiAoIHAybV9pc19yYW0ob3QpICYmICFwMm1faXNfcGFnZWQob3QpICkKICAg ICAgICAgewpAQCAtMTAzNSw4ICsxMDM1LDcgQEAgaW50IHAybV9jaGFuZ2Vf dHlwZV9vbmUoc3RydWN0IGRvbWFpbiAqZAogICAgIHN0cnVjdCBwMm1fZG9t YWluICpwMm0gPSBwMm1fZ2V0X2hvc3RwMm0oZCk7CiAgICAgaW50IHJjOwog Ci0gICAgQlVHX09OKHAybV9pc19ncmFudChvdCkgfHwgcDJtX2lzX2dyYW50 KG50KSk7Ci0gICAgQlVHX09OKHAybV9pc19mb3JlaWduKG90KSB8fCBwMm1f aXNfZm9yZWlnbihudCkpOworICAgIEJVR19PTihwMm1faXNfc3BlY2lhbChv dCkgfHwgcDJtX2lzX3NwZWNpYWwobnQpKTsKIAogICAgIGdmbl9sb2NrKHAy bSwgZ2ZuLCAwKTsKIApAQCAtMTI4MywxMSArMTI4MiwxMSBAQCBzdGF0aWMg aW50IHNldF90eXBlZF9wMm1fZW50cnkoc3RydWN0IGRvCiAgICAgICAgIGdm bl91bmxvY2socDJtLCBnZm4sIG9yZGVyKTsKICAgICAgICAgcmV0dXJuIGN1 cl9vcmRlciArIDE7CiAgICAgfQotICAgIGlmICggcDJtX2lzX2dyYW50KG90 KSB8fCBwMm1faXNfZm9yZWlnbihvdCkgKQorICAgIGlmICggcDJtX2lzX3Nw ZWNpYWwob3QpICkKICAgICB7CiAgICAgICAgIGdmbl91bmxvY2socDJtLCBn Zm4sIG9yZGVyKTsKICAgICAgICAgZG9tYWluX2NyYXNoKGQpOwotICAgICAg ICByZXR1cm4gLUVOT0VOVDsKKyAgICAgICAgcmV0dXJuIC1FUEVSTTsKICAg ICB9CiAgICAgZWxzZSBpZiAoIHAybV9pc19yYW0ob3QpICkKICAgICB7Ci0t LSBhL3hlbi9pbmNsdWRlL2FzbS14ODYvcDJtLmgKKysrIGIveGVuL2luY2x1 ZGUvYXNtLXg4Ni9wMm0uaApAQCAtMTQxLDYgKzE0MSwxMCBAQCB0eXBlZGVm IHVuc2lnbmVkIGludCBwMm1fcXVlcnlfdDsKICAgICAgICAgICAgICAgICAg ICAgICAgICAgICB8IHAybV90b19tYXNrKHAybV9yYW1fbG9nZGlydHkpICkK ICNkZWZpbmUgUDJNX1NIQVJFRF9UWVBFUyAgIChwMm1fdG9fbWFzayhwMm1f cmFtX3NoYXJlZCkpCiAKKy8qIFR5cGVzIGVzdGFibGlzaGVkL2NsZWFuZWQg dXAgdmlhIHNwZWNpYWwgYWNjZXNzb3JzLiAqLworI2RlZmluZSBQMk1fU1BF Q0lBTF9UWVBFUyAoUDJNX0dSQU5UX1RZUEVTIHwgXAorICAgICAgICAgICAg ICAgICAgICAgICAgICAgcDJtX3RvX21hc2socDJtX21hcF9mb3JlaWduKSkK KwogLyogVmFsaWQgdHlwZXMgbm90IG5lY2Vzc2FyaWx5IGFzc29jaWF0ZWQg d2l0aCBhICh2YWxpZCkgTUZOLiAqLwogI2RlZmluZSBQMk1fSU5WQUxJRF9N Rk5fVFlQRVMgKFAyTV9QT0RfVFlQRVMgICAgICAgICAgICAgICAgICBcCiAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfCBwMm1fdG9fbWFzayhw Mm1fbW1pb19kaXJlY3QpIFwKQEAgLTE2OSw2ICsxNzMsNyBAQCB0eXBlZGVm IHVuc2lnbmVkIGludCBwMm1fcXVlcnlfdDsKICNkZWZpbmUgcDJtX2lzX3Bh Z2VkKF90KSAgICAocDJtX3RvX21hc2soX3QpICYgUDJNX1BBR0VEX1RZUEVT KQogI2RlZmluZSBwMm1faXNfc2hhcmFibGUoX3QpIChwMm1fdG9fbWFzayhf dCkgJiBQMk1fU0hBUkFCTEVfVFlQRVMpCiAjZGVmaW5lIHAybV9pc19zaGFy ZWQoX3QpICAgKHAybV90b19tYXNrKF90KSAmIFAyTV9TSEFSRURfVFlQRVMp CisjZGVmaW5lIHAybV9pc19zcGVjaWFsKF90KSAgKHAybV90b19tYXNrKF90 KSAmIFAyTV9TUEVDSUFMX1RZUEVTKQogI2RlZmluZSBwMm1faXNfYnJva2Vu KF90KSAgIChwMm1fdG9fbWFzayhfdCkgJiBQMk1fQlJPS0VOX1RZUEVTKQog I2RlZmluZSBwMm1faXNfZm9yZWlnbihfdCkgIChwMm1fdG9fbWFzayhfdCkg JiBwMm1fdG9fbWFzayhwMm1fbWFwX2ZvcmVpZ24pKQogCg== --=separator Content-Type: application/octet-stream; name="xsa378/xsa378-4.14-8.patch" Content-Disposition: attachment; filename="xsa378/xsa378-4.14-8.patch" Content-Transfer-Encoding: base64 RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0 OiB4ODYvcDJtOiBndWFyZCAoaW4gcGFydGljdWxhcikgaWRlbnRpdHkgbWFw cGluZyBlbnRyaWVzCgpTdWNoIGVudHJpZXMsIGNyZWF0ZWQgYnkgc2V0X2lk ZW50aXR5X3AybV9lbnRyeSgpLCBzaG91bGQgb25seSBiZQpkZXN0cm95ZWQg YnkgY2xlYXJfaWRlbnRpdHlfcDJtX2VudHJ5KCkuIEhvd2V2ZXIsIHNpbWls YXJseSwgZW50cmllcwpjcmVhdGVkIGJ5IHNldF9tbWlvX3AybV9lbnRyeSgp IHNob3VsZCBvbmx5IGJlIHRvcm4gZG93biBieQpjbGVhcl9tbWlvX3AybV9l bnRyeSgpLCBzbyB0aGUgbG9naWMgZ2V0cyBiYXNlZCB1cG9uIHAybV9tbWlv X2RpcmVjdCBhcwp0aGUgZW50cnkgdHlwZSAoc2VwYXJhdGlvbiBiZXR3ZWVu ICJvcmRpbmFyeSIgYW5kIDE6MSBtYXBwaW5ncyB3b3VsZApyZXF1aXJlIGEg ZnVydGhlciBpbmRpY2F0b3IgdG8gdGVsbCBhcGFydCB0aGUgdHdvKS4KCkFz IHRvIHRoZSBndWVzdF9yZW1vdmVfcGFnZSgpIGNoYW5nZSwgY29tbWl0IDQ4 ZGZiMjk3YTIwYSAoIng4Ni9QVkg6CmFsbG93IGd1ZXN0X3JlbW92ZV9wYWdl IHRvIHJlbW92ZSBwMm1fbW1pb19kaXJlY3QgcGFnZXMiKSwgd2hpY2gKaW50 cm9kdWNlZCB0aGUgY2FsbCB0byBjbGVhcl9tbWlvX3AybV9lbnRyeSgpLCBj bGFpbWVkIHRoaXMgd2FzIGRvbmUgZm9yCmh3ZG9tIG9ubHkgd2l0aG91dCB0 aGlzIGFjdHVhbGx5IGhhdmluZyBiZWVuIHRoZSBjYXNlLiBIb3dldmVyLCB0 aGlzCmNvZGUgc2hvdWxkbid0IGJlIHRoZXJlIGluIHRoZSBmaXJzdCBwbGFj ZSwgYXMgTU1JTyBlbnRyaWVzIHNob3VsZG4ndCBiZQpkcm9wcGVkIHRoaXMg d2F5LiBBdm9pZCB0cmlnZ2VyaW5nIHRoZSB3YXJuaW5nIGFnYWluIHRoYXQg NDhkZmIyOTdhMjBhCnNpbGVuY2VkIGJ5IGFuIGFkanVzdG1lbnQgdG8geGVu bWVtX2FkZF90b19waHlzbWFwX29uZSgpIGluc3RlYWQuCgpOb3RlIHRoYXQg Z3Vlc3RfcGh5c21hcF9tYXJrX3BvcHVsYXRlX29uX2RlbWFuZCgpIGdldHMg dGlnaHRlbmVkIGJleW9uZAp0aGUgaW1tZWRpYXRlIHB1cnBvc2Ugb2YgdGhp cyBjaGFuZ2UuCgpOb3RlIGFsc28gdGhhdCBJIGRpZG4ndCBpbnNwZWN0IGNv ZGUgd2hpY2ggaXNuJ3Qgc2VjdXJpdHkgc3VwcG9ydGVkLAplLmcuIHNoYXJp bmcsIHBhZ2luZywgb3IgYWx0cDJtLgoKVGhpcyBpcyBDVkUtMjAyMS0yODY5 NCAvIHBhcnQgb2YgWFNBLTM3OC4KClNpZ25lZC1vZmYtYnk6IEphbiBCZXVs aWNoIDxqYmV1bGljaEBzdXNlLmNvbT4KUmV2aWV3ZWQtYnk6IFBhdWwgRHVy cmFudCA8cGF1bEB4ZW4ub3JnPgoKLS0tIGEveGVuL2FyY2gveDg2L21tLmMK KysrIGIveGVuL2FyY2gveDg2L21tLmMKQEAgLTQ2NTIsNyArNDY1Miw5IEBA IGludCB4ZW5tZW1fYWRkX3RvX3BoeXNtYXBfb25lKAogCiAgICAgLyogUmVt b3ZlIHByZXZpb3VzbHkgbWFwcGVkIHBhZ2UgaWYgaXQgd2FzIHByZXNlbnQu ICovCiAgICAgcHJldl9tZm4gPSBnZXRfZ2ZuKGQsIGdmbl94KGdwZm4pLCAm cDJtdCk7Ci0gICAgaWYgKCBtZm5fdmFsaWQocHJldl9tZm4pICkKKyAgICBp ZiAoIHAybXQgPT0gcDJtX21taW9fZGlyZWN0ICkKKyAgICAgICAgcmMgPSAt RVBFUk07CisgICAgZWxzZSBpZiAoIG1mbl92YWxpZChwcmV2X21mbikgKQog ICAgIHsKICAgICAgICAgaWYgKCBpc19zcGVjaWFsX3BhZ2UobWZuX3RvX3Bh Z2UocHJldl9tZm4pKSApCiAgICAgICAgICAgICAvKiBTcGVjaWFsIHBhZ2Vz IGFyZSBzaW1wbHkgdW5ob29rZWQgZnJvbSB0aGlzIHBoeXMgc2xvdC4gKi8K LS0tIGEveGVuL2FyY2gveDg2L21tL3AybS5jCisrKyBiL3hlbi9hcmNoL3g4 Ni9tbS9wMm0uYwpAQCAtNzk1LDcgKzc5NSw4IEBAIHAybV9yZW1vdmVfcGFn ZShzdHJ1Y3QgcDJtX2RvbWFpbiAqcDJtLAogICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgJmN1cl9vcmRlciwgTlVMTCk7CiAK ICAgICAgICAgaWYgKCBwMm1faXNfdmFsaWQodCkgJiYKLSAgICAgICAgICAg ICAoIW1mbl92YWxpZChtZm4pIHx8ICFtZm5fZXEobWZuX2FkZChtZm4sIGkp LCBtZm5fcmV0dXJuKSkgKQorICAgICAgICAgICAgICghbWZuX3ZhbGlkKG1m bikgfHwgdCA9PSBwMm1fbW1pb19kaXJlY3QgfHwKKyAgICAgICAgICAgICAg IW1mbl9lcShtZm5fYWRkKG1mbiwgaSksIG1mbl9yZXR1cm4pKSApCiAgICAg ICAgICAgICByZXR1cm4gLUVJTFNFUTsKIAogICAgICAgICBpICs9ICgxVUwg PDwgY3VyX29yZGVyKSAtCkBAIC04OTMsNyArODk0LDcgQEAgZ3Vlc3RfcGh5 c21hcF9hZGRfZW50cnkoc3RydWN0IGRvbWFpbiAqZAogICAgIGlmICggcDJt X2lzX2ZvcmVpZ24odCkgKQogICAgICAgICByZXR1cm4gLUVJTlZBTDsKIAot ICAgIGlmICggIW1mbl92YWxpZChtZm4pICkKKyAgICBpZiAoICFtZm5fdmFs aWQobWZuKSB8fCB0ID09IHAybV9tbWlvX2RpcmVjdCApCiAgICAgewogICAg ICAgICBBU1NFUlRfVU5SRUFDSEFCTEUoKTsKICAgICAgICAgcmV0dXJuIC1F SU5WQUw7CkBAIC05MzcsNyArOTM4LDcgQEAgZ3Vlc3RfcGh5c21hcF9hZGRf ZW50cnkoc3RydWN0IGRvbWFpbiAqZAogICAgICAgICB9CiAgICAgICAgIGlm ICggcDJtX2lzX3NwZWNpYWwob3QpICkKICAgICAgICAgewotICAgICAgICAg ICAgLyogRG9uJ3QgcGVybWl0IHVubWFwcGluZyBncmFudC9mb3JlaWduIHRo aXMgd2F5LiAqLworICAgICAgICAgICAgLyogRG9uJ3QgcGVybWl0IHVubWFw cGluZyBncmFudC9mb3JlaWduL2RpcmVjdC1NTUlPIHRoaXMgd2F5LiAqLwog ICAgICAgICAgICAgZG9tYWluX2NyYXNoKGQpOwogICAgICAgICAgICAgcDJt X3VubG9jayhwMm0pOwogICAgICAgICAgICAgCkBAIC0xMzg3LDggKzEzODgs OCBAQCBpbnQgc2V0X2lkZW50aXR5X3AybV9lbnRyeShzdHJ1Y3QgZG9tYWlu CiAgKiAgICBvcmRlcisxICBmb3IgY2FsbGVyIHRvIHJldHJ5IHdpdGggb3Jk ZXIgKGd1YXJhbnRlZWQgc21hbGxlciB0aGFuCiAgKiAgICAgICAgICAgICB0 aGUgb3JkZXIgdmFsdWUgcGFzc2VkIGluKQogICovCi1pbnQgY2xlYXJfbW1p b19wMm1fZW50cnkoc3RydWN0IGRvbWFpbiAqZCwgdW5zaWduZWQgbG9uZyBn Zm5fbCwgbWZuX3QgbWZuLAotICAgICAgICAgICAgICAgICAgICAgICAgIHVu c2lnbmVkIGludCBvcmRlcikKK3N0YXRpYyBpbnQgY2xlYXJfbW1pb19wMm1f ZW50cnkoc3RydWN0IGRvbWFpbiAqZCwgdW5zaWduZWQgbG9uZyBnZm5fbCwK KyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgbWZuX3QgbWZuLCB1 bnNpZ25lZCBpbnQgb3JkZXIpCiB7CiAgICAgaW50IHJjID0gLUVJTlZBTDsK ICAgICBnZm5fdCBnZm4gPSBfZ2ZuKGdmbl9sKTsKLS0tIGEveGVuL2FyY2gv eDg2L21tL3AybS1wb2QuYworKysgYi94ZW4vYXJjaC94ODYvbW0vcDJtLXBv ZC5jCkBAIC0xMjkyLDE3ICsxMjkyLDE3IEBAIGd1ZXN0X3BoeXNtYXBfbWFy a19wb3B1bGF0ZV9vbl9kZW1hbmQoc3QKIAogICAgICAgICBwMm0tPmdldF9l bnRyeShwMm0sIGdmbl9hZGQoZ2ZuLCBpKSwgJm90LCAmYSwgMCwgJmN1cl9v cmRlciwgTlVMTCk7CiAgICAgICAgIG4gPSAxVUwgPDwgbWluKG9yZGVyLCBj dXJfb3JkZXIpOwotICAgICAgICBpZiAoIHAybV9pc19yYW0ob3QpICkKKyAg ICAgICAgaWYgKCBvdCA9PSBwMm1fcG9wdWxhdGVfb25fZGVtYW5kICkKKyAg ICAgICAgeworICAgICAgICAgICAgLyogQ291bnQgaG93IG1hbnkgUG9EIGVu dHJpZXMgd2UnbGwgYmUgcmVwbGFjaW5nIGlmIHN1Y2Nlc3NmdWwgKi8KKyAg ICAgICAgICAgIHBvZF9jb3VudCArPSBuOworICAgICAgICB9CisgICAgICAg IGVsc2UgaWYgKCBvdCAhPSBwMm1faW52YWxpZCAmJiBvdCAhPSBwMm1fbW1p b19kbSApCiAgICAgICAgIHsKICAgICAgICAgICAgIFAyTV9ERUJVRygiZ2Zu X3RvX21mbiByZXR1cm5lZCB0eXBlICVkIVxuIiwgb3QpOwogICAgICAgICAg ICAgcmMgPSAtRUJVU1k7CiAgICAgICAgICAgICBnb3RvIG91dDsKICAgICAg ICAgfQotICAgICAgICBlbHNlIGlmICggb3QgPT0gcDJtX3BvcHVsYXRlX29u X2RlbWFuZCApCi0gICAgICAgIHsKLSAgICAgICAgICAgIC8qIENvdW50IGhv dyBtYW4gUG9EIGVudHJpZXMgd2UnbGwgYmUgcmVwbGFjaW5nIGlmIHN1Y2Nl c3NmdWwgKi8KLSAgICAgICAgICAgIHBvZF9jb3VudCArPSBuOwotICAgICAg ICB9CiAgICAgfQogCiAgICAgLyogTm93LCBhY3R1YWxseSBkbyB0aGUgdHdv LXdheSBtYXBwaW5nICovCi0tLSBhL3hlbi9jb21tb24vbWVtb3J5LmMKKysr IGIveGVuL2NvbW1vbi9tZW1vcnkuYwpAQCAtMzI5LDcgKzMyOSw3IEBAIGlu dCBndWVzdF9yZW1vdmVfcGFnZShzdHJ1Y3QgZG9tYWluICpkLAogICAgIH0K ICAgICBpZiAoIHAybXQgPT0gcDJtX21taW9fZGlyZWN0ICkKICAgICB7Ci0g ICAgICAgIHJjID0gY2xlYXJfbW1pb19wMm1fZW50cnkoZCwgZ21mbiwgbWZu LCBQQUdFX09SREVSXzRLKTsKKyAgICAgICAgcmMgPSAtRVBFUk07CiAgICAg ICAgIGdvdG8gb3V0X3B1dF9nZm47CiAgICAgfQogI2Vsc2UKQEAgLTE3MjEs NiArMTcyMSwxNSBAQCBpbnQgY2hlY2tfZ2V0X3BhZ2VfZnJvbV9nZm4oc3Ry dWN0IGRvbWFpCiAgICAgICAgIHJldHVybiAtRUFHQUlOOwogICAgIH0KICNl bmRpZgorI2lmZGVmIENPTkZJR19YODYKKyAgICBpZiAoIHAybXQgPT0gcDJt X21taW9fZGlyZWN0ICkKKyAgICB7CisgICAgICAgIGlmICggcGFnZSApCisg ICAgICAgICAgICBwdXRfcGFnZShwYWdlKTsKKworICAgICAgICByZXR1cm4g LUVQRVJNOworICAgIH0KKyNlbmRpZgogCiAgICAgaWYgKCAhcGFnZSApCiAg ICAgICAgIHJldHVybiAtRUlOVkFMOwotLS0gYS94ZW4vaW5jbHVkZS9hc20t eDg2L3AybS5oCisrKyBiL3hlbi9pbmNsdWRlL2FzbS14ODYvcDJtLmgKQEAg LTE0Myw3ICsxNDMsOCBAQCB0eXBlZGVmIHVuc2lnbmVkIGludCBwMm1fcXVl cnlfdDsKIAogLyogVHlwZXMgZXN0YWJsaXNoZWQvY2xlYW5lZCB1cCB2aWEg c3BlY2lhbCBhY2Nlc3NvcnMuICovCiAjZGVmaW5lIFAyTV9TUEVDSUFMX1RZ UEVTIChQMk1fR1JBTlRfVFlQRVMgfCBcCi0gICAgICAgICAgICAgICAgICAg ICAgICAgICBwMm1fdG9fbWFzayhwMm1fbWFwX2ZvcmVpZ24pKQorICAgICAg ICAgICAgICAgICAgICAgICAgICAgcDJtX3RvX21hc2socDJtX21hcF9mb3Jl aWduKSB8IFwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgIHAybV90b19t YXNrKHAybV9tbWlvX2RpcmVjdCkpCiAKIC8qIFZhbGlkIHR5cGVzIG5vdCBu ZWNlc3NhcmlseSBhc3NvY2lhdGVkIHdpdGggYSAodmFsaWQpIE1GTi4gKi8K ICNkZWZpbmUgUDJNX0lOVkFMSURfTUZOX1RZUEVTIChQMk1fUE9EX1RZUEVT ICAgICAgICAgICAgICAgICAgXApAQCAtNjQ1LDggKzY0Niw2IEBAIGludCBz ZXRfZm9yZWlnbl9wMm1fZW50cnkoc3RydWN0IGRvbWFpbgogLyogU2V0IG1t aW8gYWRkcmVzc2VzIGluIHRoZSBwMm0gdGFibGUgKGZvciBwYXNzLXRocm91 Z2gpICovCiBpbnQgc2V0X21taW9fcDJtX2VudHJ5KHN0cnVjdCBkb21haW4g KmQsIGdmbl90IGdmbiwgbWZuX3QgbWZuLAogICAgICAgICAgICAgICAgICAg ICAgICB1bnNpZ25lZCBpbnQgb3JkZXIpOwotaW50IGNsZWFyX21taW9fcDJt X2VudHJ5KHN0cnVjdCBkb21haW4gKmQsIHVuc2lnbmVkIGxvbmcgZ2ZuLCBt Zm5fdCBtZm4sCi0gICAgICAgICAgICAgICAgICAgICAgICAgdW5zaWduZWQg aW50IG9yZGVyKTsKIAogLyogU2V0IGlkZW50aXR5IGFkZHJlc3NlcyBpbiB0 aGUgcDJtIHRhYmxlIChmb3IgcGFzcy10aHJvdWdoKSAqLwogaW50IHNldF9p ZGVudGl0eV9wMm1fZW50cnkoc3RydWN0IGRvbWFpbiAqZCwgdW5zaWduZWQg bG9uZyBnZm4sCg== --=separator Content-Type: application/octet-stream; name="xsa378/xsa378-4.15-1.patch" Content-Disposition: attachment; filename="xsa378/xsa378-4.15-1.patch" Content-Transfer-Encoding: base64 RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0 OiBBTUQvSU9NTVU6IGNvcnJlY3QgZ2xvYmFsIGV4Y2x1c2lvbiByYW5nZSBl eHRlbmRpbmcKCkJlc2lkZXMgdW5pdHkgbWFwcGluZyByZWdpb25zLCB0aGUg QU1EIElPTU1VIHNwZWMgYWxzbyBwcm92aWRlcyBmb3IKZXhjbHVzaW9uIHJh bmdlcyAoYXJlYXMgb2YgbWVtb3J5IG5vdCB0byBiZSBzdWJqZWN0IHRvIERN QSB0cmFuc2xhdGlvbikKdG8gYmUgc3BlY2lmaWVkIGJ5IGZpcm13YXJlIGlu IHRoZSBBQ1BJIHRhYmxlcy4gVGhlIHNwZWMgZG9lcyBub3QgcHV0CmFueSBj b25zdHJhaW50cyBvbiB0aGUgbnVtYmVyIG9mIHN1Y2ggcmVnaW9ucy4KCkJs aW5kbHkgYXNzdW1pbmcgYWxsIGFkZHJlc3NlcyBiZXR3ZWVuIGFueSB0d28g c3VjaCByYW5nZXMgc2hvdWxkIGFsc28KYmUgZXhjbHVkZWQgY2FuJ3QgYmUg cmlnaHQuIFNpbmNlIGhhcmR3YXJlIGhhcyByb29tIGZvciBqdXN0IGEgc2lu Z2xlCnN1Y2ggcmFuZ2UgKGNvbXByaXNlZCBvZiB0aGUgRXhjbHVzaW9uIEJh c2UgUmVnaXN0ZXIgYW5kIHRoZSBFeGNsdXNpb24KUmFuZ2UgTGltaXQgUmVn aXN0ZXIpLCBjb21iaW5lIG9ubHkgYWRqYWNlbnQgb3Igb3ZlcmxhcHBpbmcg cmVnaW9ucyAoZm9yCm5vdzsgdGhpcyBtYXkgcmVxdWlyZSBmdXJ0aGVyIGFk anVzdG1lbnQgaW4gY2FzZSB0YWJsZSBlbnRyaWVzIGFyZW4ndApzb3J0ZWQg YnkgYWRkcmVzcykgd2l0aCBtYXRjaGluZyBleGNsdXNpb25fYWxsb3dfYWxs IHNldHRpbmdzLiBUaGlzCnJlcXVpcmVzIGJ1YmJsaW5nIHVwIGVycm9yIGlu ZGljYXRvcnMsIHN1Y2ggdGhhdCBJT01NVSBpbml0IGNhbiBiZQpmYWlsZWQg d2hlbiBjb25jYXRlbmF0aW9uIHdhc24ndCBwb3NzaWJsZS4KCkZ1cnRoZXJt b3JlLCBzaW5jZSB0aGUgZXhjbHVzaW9uIHJhbmdlIHNwZWNpZmllZCBpbiBJ T01NVSByZWdpc3RlcnMKaW1wbGllcyBSL1cgYWNjZXNzLCByZWplY3QgcmVx dWVzdHMgYXNraW5nIGZvciBsZXNzIHBlcm1pc3Npb25zICh0aGlzCndpbGwg YmUgYnJvdWdodCBjbG9zZXIgdG8gdGhlIHNwZWMgYnkgYSBzdWJzZXF1ZW50 IGNoYW5nZSkuCgpUaGlzIGlzIHBhcnQgb2YgWFNBLTM3OCAvIENWRS0yMDIx LTI4Njk1LgoKU2lnbmVkLW9mZi1ieTogSmFuIEJldWxpY2ggPGpiZXVsaWNo QHN1c2UuY29tPgpSZXZpZXdlZC1ieTogUGF1bCBEdXJyYW50IDxwYXVsQHhl bi5vcmc+CgotLS0gYS94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC9hbWQvaW9t bXVfYWNwaS5jCisrKyBiL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL2FtZC9p b21tdV9hY3BpLmMKQEAgLTExNiwxMiArMTE2LDIxIEBAIHN0YXRpYyBzdHJ1 Y3QgYW1kX2lvbW11ICogX19pbml0IGZpbmRfaW8KICAgICByZXR1cm4gTlVM TDsKIH0KIAotc3RhdGljIHZvaWQgX19pbml0IHJlc2VydmVfaW9tbXVfZXhj bHVzaW9uX3JhbmdlKAotICAgIHN0cnVjdCBhbWRfaW9tbXUgKmlvbW11LCB1 aW50NjRfdCBiYXNlLCB1aW50NjRfdCBsaW1pdCkKK3N0YXRpYyBpbnQgX19p bml0IHJlc2VydmVfaW9tbXVfZXhjbHVzaW9uX3JhbmdlKAorICAgIHN0cnVj dCBhbWRfaW9tbXUgKmlvbW11LCB1aW50NjRfdCBiYXNlLCB1aW50NjRfdCBs aW1pdCwKKyAgICBib29sIGFsbCwgYm9vbCBpdywgYm9vbCBpcikKIHsKKyAg ICBpZiAoICFpciB8fCAhaXcgKQorICAgICAgICByZXR1cm4gLUVQRVJNOwor CiAgICAgLyogbmVlZCB0byBleHRlbmQgZXhjbHVzaW9uIHJhbmdlPyAqLwog ICAgIGlmICggaW9tbXUtPmV4Y2x1c2lvbl9lbmFibGUgKQogICAgIHsKKyAg ICAgICAgaWYgKCBpb21tdS0+ZXhjbHVzaW9uX2xpbWl0ICsgUEFHRV9TSVpF IDwgYmFzZSB8fAorICAgICAgICAgICAgIGxpbWl0ICsgUEFHRV9TSVpFIDwg aW9tbXUtPmV4Y2x1c2lvbl9iYXNlIHx8CisgICAgICAgICAgICAgaW9tbXUt PmV4Y2x1c2lvbl9hbGxvd19hbGwgIT0gYWxsICkKKyAgICAgICAgICAgIHJl dHVybiAtRUJVU1k7CisKICAgICAgICAgaWYgKCBpb21tdS0+ZXhjbHVzaW9u X2Jhc2UgPCBiYXNlICkKICAgICAgICAgICAgIGJhc2UgPSBpb21tdS0+ZXhj bHVzaW9uX2Jhc2U7CiAgICAgICAgIGlmICggaW9tbXUtPmV4Y2x1c2lvbl9s aW1pdCA+IGxpbWl0ICkKQEAgLTEyOSwxNiArMTM4LDExIEBAIHN0YXRpYyB2 b2lkIF9faW5pdCByZXNlcnZlX2lvbW11X2V4Y2x1c2kKICAgICB9CiAKICAg ICBpb21tdS0+ZXhjbHVzaW9uX2VuYWJsZSA9IElPTU1VX0NPTlRST0xfRU5B QkxFRDsKKyAgICBpb21tdS0+ZXhjbHVzaW9uX2FsbG93X2FsbCA9IGFsbDsK ICAgICBpb21tdS0+ZXhjbHVzaW9uX2Jhc2UgPSBiYXNlOwogICAgIGlvbW11 LT5leGNsdXNpb25fbGltaXQgPSBsaW1pdDsKLX0KIAotc3RhdGljIHZvaWQg X19pbml0IHJlc2VydmVfaW9tbXVfZXhjbHVzaW9uX3JhbmdlX2FsbCgKLSAg ICBzdHJ1Y3QgYW1kX2lvbW11ICppb21tdSwKLSAgICB1bnNpZ25lZCBsb25n IGJhc2UsIHVuc2lnbmVkIGxvbmcgbGltaXQpCi17Ci0gICAgcmVzZXJ2ZV9p b21tdV9leGNsdXNpb25fcmFuZ2UoaW9tbXUsIGJhc2UsIGxpbWl0KTsKLSAg ICBpb21tdS0+ZXhjbHVzaW9uX2FsbG93X2FsbCA9IElPTU1VX0NPTlRST0xf RU5BQkxFRDsKKyAgICByZXR1cm4gMDsKIH0KIAogc3RhdGljIHZvaWQgX19p bml0IHJlc2VydmVfdW5pdHlfbWFwX2Zvcl9kZXZpY2UoCkBAIC0xNzYsNiAr MTgwLDcgQEAgc3RhdGljIGludCBfX2luaXQgcmVnaXN0ZXJfZXhjbHVzaW9u X3JhbgogICAgIHVuc2lnbmVkIGxvbmcgcmFuZ2VfdG9wLCBpb21tdV90b3As IGxlbmd0aDsKICAgICBzdHJ1Y3QgYW1kX2lvbW11ICppb21tdTsKICAgICB1 bnNpZ25lZCBpbnQgYmRmOworICAgIGludCByYyA9IDA7CiAKICAgICAvKiBp cyBwYXJ0IG9mIGV4Y2x1c2lvbiByYW5nZSBpbnNpZGUgb2YgSU9NTVUgdmly dHVhbCBhZGRyZXNzIHNwYWNlPyAqLwogICAgIC8qIG5vdGU6ICdsaW1pdCcg cGFyYW1ldGVyIGlzIGFzc3VtZWQgdG8gYmUgcGFnZS1hbGlnbmVkICovCkBA IC0xOTcsMTAgKzIwMiwxNSBAQCBzdGF0aWMgaW50IF9faW5pdCByZWdpc3Rl cl9leGNsdXNpb25fcmFuCiAgICAgaWYgKCBsaW1pdCA+PSBpb21tdV90b3Ag KQogICAgIHsKICAgICAgICAgZm9yX2VhY2hfYW1kX2lvbW11KCBpb21tdSAp Ci0gICAgICAgICAgICByZXNlcnZlX2lvbW11X2V4Y2x1c2lvbl9yYW5nZV9h bGwoaW9tbXUsIGJhc2UsIGxpbWl0KTsKKyAgICAgICAgeworICAgICAgICAg ICAgcmMgPSByZXNlcnZlX2lvbW11X2V4Y2x1c2lvbl9yYW5nZShpb21tdSwg YmFzZSwgbGltaXQsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIHRydWUgLyogYWxsICovLCBpdywgaXIpOworICAg ICAgICAgICAgaWYgKCByYyApCisgICAgICAgICAgICAgICAgYnJlYWs7Cisg ICAgICAgIH0KICAgICB9CiAKLSAgICByZXR1cm4gMDsKKyAgICByZXR1cm4g cmM7CiB9CiAKIHN0YXRpYyBpbnQgX19pbml0IHJlZ2lzdGVyX2V4Y2x1c2lv bl9yYW5nZV9mb3JfZGV2aWNlKApAQCAtMjExLDYgKzIyMSw3IEBAIHN0YXRp YyBpbnQgX19pbml0IHJlZ2lzdGVyX2V4Y2x1c2lvbl9yYW4KICAgICB1bnNp Z25lZCBsb25nIHJhbmdlX3RvcCwgaW9tbXVfdG9wLCBsZW5ndGg7CiAgICAg c3RydWN0IGFtZF9pb21tdSAqaW9tbXU7CiAgICAgdTE2IHJlcTsKKyAgICBp bnQgcmMgPSAwOwogCiAgICAgaW9tbXUgPSBmaW5kX2lvbW11X2Zvcl9kZXZp Y2Uoc2VnLCBiZGYpOwogICAgIGlmICggIWlvbW11ICkKQEAgLTI0MCwxMiAr MjUxLDEzIEBAIHN0YXRpYyBpbnQgX19pbml0IHJlZ2lzdGVyX2V4Y2x1c2lv bl9yYW4KICAgICAvKiByZWdpc3RlciBJT01NVSBleGNsdXNpb24gcmFuZ2Ug c2V0dGluZ3MgZm9yIGRldmljZSAqLwogICAgIGlmICggbGltaXQgPj0gaW9t bXVfdG9wICApCiAgICAgewotICAgICAgICByZXNlcnZlX2lvbW11X2V4Y2x1 c2lvbl9yYW5nZShpb21tdSwgYmFzZSwgbGltaXQpOworICAgICAgICByYyA9 IHJlc2VydmVfaW9tbXVfZXhjbHVzaW9uX3JhbmdlKGlvbW11LCBiYXNlLCBs aW1pdCwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICBmYWxzZSAvKiBhbGwgKi8sIGl3LCBpcik7CiAgICAgICAgIGl2cnNf bWFwcGluZ3NbYmRmXS5kdGVfYWxsb3dfZXhjbHVzaW9uID0gdHJ1ZTsKICAg ICAgICAgaXZyc19tYXBwaW5nc1tyZXFdLmR0ZV9hbGxvd19leGNsdXNpb24g PSB0cnVlOwogICAgIH0KIAotICAgIHJldHVybiAwOworICAgIHJldHVybiBy YzsKIH0KIAogc3RhdGljIGludCBfX2luaXQgcmVnaXN0ZXJfZXhjbHVzaW9u X3JhbmdlX2Zvcl9pb21tdV9kZXZpY2VzKApAQCAtMjU1LDYgKzI2Nyw3IEBA IHN0YXRpYyBpbnQgX19pbml0IHJlZ2lzdGVyX2V4Y2x1c2lvbl9yYW4KICAg ICB1bnNpZ25lZCBsb25nIHJhbmdlX3RvcCwgaW9tbXVfdG9wLCBsZW5ndGg7 CiAgICAgdW5zaWduZWQgaW50IGJkZjsKICAgICB1MTYgcmVxOworICAgIGlu dCByYyA9IDA7CiAKICAgICAvKiBpcyBwYXJ0IG9mIGV4Y2x1c2lvbiByYW5n ZSBpbnNpZGUgb2YgSU9NTVUgdmlydHVhbCBhZGRyZXNzIHNwYWNlPyAqLwog ICAgIC8qIG5vdGU6ICdsaW1pdCcgcGFyYW1ldGVyIGlzIGFzc3VtZWQgdG8g YmUgcGFnZS1hbGlnbmVkICovCkBAIC0yODUsOCArMjk4LDEwIEBAIHN0YXRp YyBpbnQgX19pbml0IHJlZ2lzdGVyX2V4Y2x1c2lvbl9yYW4KIAogICAgIC8q IHJlZ2lzdGVyIElPTU1VIGV4Y2x1c2lvbiByYW5nZSBzZXR0aW5ncyAqLwog ICAgIGlmICggbGltaXQgPj0gaW9tbXVfdG9wICkKLSAgICAgICAgcmVzZXJ2 ZV9pb21tdV9leGNsdXNpb25fcmFuZ2VfYWxsKGlvbW11LCBiYXNlLCBsaW1p dCk7Ci0gICAgcmV0dXJuIDA7CisgICAgICAgIHJjID0gcmVzZXJ2ZV9pb21t dV9leGNsdXNpb25fcmFuZ2UoaW9tbXUsIGJhc2UsIGxpbWl0LAorICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHRydWUgLyog YWxsICovLCBpdywgaXIpOworCisgICAgcmV0dXJuIHJjOwogfQogCiBzdGF0 aWMgaW50IF9faW5pdCBwYXJzZV9pdm1kX2RldmljZV9zZWxlY3QoCg== --=separator Content-Type: application/octet-stream; name="xsa378/xsa378-4.15-2.patch" Content-Disposition: attachment; filename="xsa378/xsa378-4.15-2.patch" Content-Transfer-Encoding: base64 RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0 OiBBTUQvSU9NTVU6IGNvcnJlY3QgZGV2aWNlIHVuaXR5IG1hcCBoYW5kbGlu ZwoKQmxpbmRseSBhc3N1bWluZyBhbGwgYWRkcmVzc2VzIGJldHdlZW4gYW55 IHR3byBzdWNoIHJhbmdlcywgc3BlY2lmaWVkIGJ5CmZpcm13YXJlIGluIHRo ZSBBQ1BJIHRhYmxlcywgc2hvdWxkIGFsc28gYmUgdW5pdHktbWFwcGVkIGNh bid0IGJlIHJpZ2h0LgpOb3IgY2FuIGl0IGJlIGNvcnJlY3QgdG8gbWVyZ2Ug cmFuZ2VzIHdpdGggZGlmZmVyaW5nIHBlcm1pc3Npb25zLiBUcmFjawpyYW5n ZXMgaW5kaXZpZHVhbGx5OyBkb24ndCBtZXJnZSBhdCBhbGwsIGJ1dCBjaGVj ayBmb3Igb3ZlcmxhcHMgaW5zdGVhZC4KVGhpcyByZXF1aXJlcyBidWJibGlu ZyB1cCBlcnJvciBpbmRpY2F0b3JzLCBzdWNoIHRoYXQgSU9NTVUgaW5pdCBj YW4gYmUKZmFpbGVkIHdoZW4gYWxsb2NhdGlvbiBvZiBhIG5ldyB0cmFja2lu ZyBzdHJ1Y3Qgd2Fzbid0IHBvc3NpYmxlLCBvciBhbgpvdmVybGFwIHdhcyBk ZXRlY3RlZC4KCkF0IHRoaXMgb2NjYXNpb24gYWxzbyBzdG9wIGlnbm9yaW5n CmFtZF9pb21tdV9yZXNlcnZlX2RvbWFpbl91bml0eV9tYXAoKSdzIHJldHVy biB2YWx1ZS4KClRoaXMgaXMgcGFydCBvZiBYU0EtMzc4IC8gQ1ZFLTIwMjEt Mjg2OTUuCgpTaWduZWQtb2ZmLWJ5OiBKYW4gQmV1bGljaCA8amJldWxpY2hA c3VzZS5jb20+ClJldmlld2VkLWJ5OiBHZW9yZ2UgRHVubGFwIDxnZW9yZ2Uu ZHVubGFwQGNpdHJpeC5jb20+ClJldmlld2VkLWJ5OiBQYXVsIER1cnJhbnQg PHBhdWxAeGVuLm9yZz4KCi0tLSBhL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdo L2FtZC9pb21tdS5oCisrKyBiL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL2Ft ZC9pb21tdS5oCkBAIC0xMDcsMjAgKzEwNywyNCBAQCBzdHJ1Y3QgYW1kX2lv bW11IHsKICAgICBzdHJ1Y3QgbGlzdF9oZWFkIGF0c19kZXZpY2VzOwogfTsK IAorc3RydWN0IGl2cnNfdW5pdHlfbWFwIHsKKyAgICBib29sIHJlYWQ6MTsK KyAgICBib29sIHdyaXRlOjE7CisgICAgcGFkZHJfdCBhZGRyOworICAgIHVu c2lnbmVkIGxvbmcgbGVuZ3RoOworICAgIHN0cnVjdCBpdnJzX3VuaXR5X21h cCAqbmV4dDsKK307CisKIHN0cnVjdCBpdnJzX21hcHBpbmdzIHsKICAgICB1 aW50MTZfdCBkdGVfcmVxdWVzdG9yX2lkOwogICAgIGJvb2wgdmFsaWQ6MTsK ICAgICBib29sIGR0ZV9hbGxvd19leGNsdXNpb246MTsKLSAgICBib29sIHVu aXR5X21hcF9lbmFibGU6MTsKLSAgICBib29sIHdyaXRlX3Blcm1pc3Npb246 MTsKLSAgICBib29sIHJlYWRfcGVybWlzc2lvbjoxOwogCiAgICAgLyogaXZo ZCBkZXZpY2UgZGF0YSBzZXR0aW5ncyAqLwogICAgIHVpbnQ4X3QgZGV2aWNl X2ZsYWdzOwogCi0gICAgdW5zaWduZWQgbG9uZyBhZGRyX3JhbmdlX3N0YXJ0 OwotICAgIHVuc2lnbmVkIGxvbmcgYWRkcl9yYW5nZV9sZW5ndGg7CiAgICAg c3RydWN0IGFtZF9pb21tdSAqaW9tbXU7CisgICAgc3RydWN0IGl2cnNfdW5p dHlfbWFwICp1bml0eV9tYXA7CiAKICAgICAvKiBwZXIgZGV2aWNlIGludGVy cnVwdCByZW1hcHBpbmcgdGFibGUgKi8KICAgICB2b2lkICppbnRyZW1hcF90 YWJsZTsKLS0tIGEveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvYW1kL2lvbW11 X2FjcGkuYworKysgYi94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC9hbWQvaW9t bXVfYWNwaS5jCkBAIC0xNDUsMzIgKzE0NSw0OCBAQCBzdGF0aWMgaW50IF9f aW5pdCByZXNlcnZlX2lvbW11X2V4Y2x1c2lvCiAgICAgcmV0dXJuIDA7CiB9 CiAKLXN0YXRpYyB2b2lkIF9faW5pdCByZXNlcnZlX3VuaXR5X21hcF9mb3Jf ZGV2aWNlKAotICAgIHUxNiBzZWcsIHUxNiBiZGYsIHVuc2lnbmVkIGxvbmcg YmFzZSwKLSAgICB1bnNpZ25lZCBsb25nIGxlbmd0aCwgdTggaXcsIHU4IGly KQorc3RhdGljIGludCBfX2luaXQgcmVzZXJ2ZV91bml0eV9tYXBfZm9yX2Rl dmljZSgKKyAgICB1aW50MTZfdCBzZWcsIHVpbnQxNl90IGJkZiwgdW5zaWdu ZWQgbG9uZyBiYXNlLAorICAgIHVuc2lnbmVkIGxvbmcgbGVuZ3RoLCBib29s IGl3LCBib29sIGlyKQogewogICAgIHN0cnVjdCBpdnJzX21hcHBpbmdzICpp dnJzX21hcHBpbmdzID0gZ2V0X2l2cnNfbWFwcGluZ3Moc2VnKTsKLSAgICB1 bnNpZ25lZCBsb25nIG9sZF90b3AsIG5ld190b3A7CisgICAgc3RydWN0IGl2 cnNfdW5pdHlfbWFwICp1bml0eV9tYXAgPSBpdnJzX21hcHBpbmdzW2JkZl0u dW5pdHlfbWFwOwogCi0gICAgLyogbmVlZCB0byBleHRlbmQgdW5pdHktbWFw cGVkIHJhbmdlPyAqLwotICAgIGlmICggaXZyc19tYXBwaW5nc1tiZGZdLnVu aXR5X21hcF9lbmFibGUgKQorICAgIC8qIENoZWNrIGZvciBvdmVybGFwcy4g Ki8KKyAgICBmb3IgKCA7IHVuaXR5X21hcDsgdW5pdHlfbWFwID0gdW5pdHlf bWFwLT5uZXh0ICkKICAgICB7Ci0gICAgICAgIG9sZF90b3AgPSBpdnJzX21h cHBpbmdzW2JkZl0uYWRkcl9yYW5nZV9zdGFydCArCi0gICAgICAgICAgICBp dnJzX21hcHBpbmdzW2JkZl0uYWRkcl9yYW5nZV9sZW5ndGg7Ci0gICAgICAg IG5ld190b3AgPSBiYXNlICsgbGVuZ3RoOwotICAgICAgICBpZiAoIG9sZF90 b3AgPiBuZXdfdG9wICkKLSAgICAgICAgICAgIG5ld190b3AgPSBvbGRfdG9w OwotICAgICAgICBpZiAoIGl2cnNfbWFwcGluZ3NbYmRmXS5hZGRyX3Jhbmdl X3N0YXJ0IDwgYmFzZSApCi0gICAgICAgICAgICBiYXNlID0gaXZyc19tYXBw aW5nc1tiZGZdLmFkZHJfcmFuZ2Vfc3RhcnQ7Ci0gICAgICAgIGxlbmd0aCA9 IG5ld190b3AgLSBiYXNlOwotICAgIH0KLQotICAgIC8qIGV4dGVuZCByL3cg cGVybWlzc2lvbXMgYW5kIGtlZXAgYWdncmVnYXRlICovCi0gICAgaXZyc19t YXBwaW5nc1tiZGZdLndyaXRlX3Blcm1pc3Npb24gPSBpdzsKLSAgICBpdnJz X21hcHBpbmdzW2JkZl0ucmVhZF9wZXJtaXNzaW9uID0gaXI7Ci0gICAgaXZy c19tYXBwaW5nc1tiZGZdLnVuaXR5X21hcF9lbmFibGUgPSB0cnVlOwotICAg IGl2cnNfbWFwcGluZ3NbYmRmXS5hZGRyX3JhbmdlX3N0YXJ0ID0gYmFzZTsK LSAgICBpdnJzX21hcHBpbmdzW2JkZl0uYWRkcl9yYW5nZV9sZW5ndGggPSBs ZW5ndGg7CisgICAgICAgIC8qCisgICAgICAgICAqIEV4YWN0IG1hdGNoZXMg YXJlIG9rYXkuIFRoaXMgY2FuIGluIHBhcnRpY3VsYXIgaGFwcGVuIHdoZW4K KyAgICAgICAgICogcmVnaXN0ZXJfZXhjbHVzaW9uX3JhbmdlX2Zvcl9kZXZp Y2UoKSBjYWxscyBoZXJlIHR3aWNlIGZvciB0aGUKKyAgICAgICAgICogc2Ft ZSAocyxiLGQsZikuCisgICAgICAgICAqLworICAgICAgICBpZiAoIGJhc2Ug PT0gdW5pdHlfbWFwLT5hZGRyICYmIGxlbmd0aCA9PSB1bml0eV9tYXAtPmxl bmd0aCAmJgorICAgICAgICAgICAgIGlyID09IHVuaXR5X21hcC0+cmVhZCAm JiBpdyA9PSB1bml0eV9tYXAtPndyaXRlICkKKyAgICAgICAgICAgIHJldHVy biAwOworCisgICAgICAgIGlmICggdW5pdHlfbWFwLT5hZGRyICsgdW5pdHlf bWFwLT5sZW5ndGggPiBiYXNlICYmCisgICAgICAgICAgICAgYmFzZSArIGxl bmd0aCA+IHVuaXR5X21hcC0+YWRkciApCisgICAgICAgIHsKKyAgICAgICAg ICAgIEFNRF9JT01NVV9ERUJVRygiSVZNRCBFcnJvcjogb3ZlcmxhcCBbJWx4 LCVseCkgdnMgWyVseCwlbHgpXG4iLAorICAgICAgICAgICAgICAgICAgICAg ICAgICAgIGJhc2UsIGJhc2UgKyBsZW5ndGgsIHVuaXR5X21hcC0+YWRkciwK KyAgICAgICAgICAgICAgICAgICAgICAgICAgICB1bml0eV9tYXAtPmFkZHIg KyB1bml0eV9tYXAtPmxlbmd0aCk7CisgICAgICAgICAgICByZXR1cm4gLUVQ RVJNOworICAgICAgICB9CisgICAgfQorCisgICAgLyogUG9wdWxhdGUgYW5k IGluc2VydCBhIG5ldyB1bml0eSBtYXAuICovCisgICAgdW5pdHlfbWFwID0g eG1hbGxvYyhzdHJ1Y3QgaXZyc191bml0eV9tYXApOworICAgIGlmICggIXVu aXR5X21hcCApCisgICAgICAgIHJldHVybiAtRU5PTUVNOworCisgICAgdW5p dHlfbWFwLT5yZWFkID0gaXI7CisgICAgdW5pdHlfbWFwLT53cml0ZSA9IGl3 OworICAgIHVuaXR5X21hcC0+YWRkciA9IGJhc2U7CisgICAgdW5pdHlfbWFw LT5sZW5ndGggPSBsZW5ndGg7CisgICAgdW5pdHlfbWFwLT5uZXh0ID0gaXZy c19tYXBwaW5nc1tiZGZdLnVuaXR5X21hcDsKKyAgICBpdnJzX21hcHBpbmdz W2JkZl0udW5pdHlfbWFwID0gdW5pdHlfbWFwOworCisgICAgcmV0dXJuIDA7 CiB9CiAKIHN0YXRpYyBpbnQgX19pbml0IHJlZ2lzdGVyX2V4Y2x1c2lvbl9y YW5nZV9mb3JfYWxsX2RldmljZXMoCkBAIC0xOTMsMTMgKzIwOSwxMyBAQCBz dGF0aWMgaW50IF9faW5pdCByZWdpc3Rlcl9leGNsdXNpb25fcmFuCiAgICAg ICAgIGxlbmd0aCA9IHJhbmdlX3RvcCAtIGJhc2U7CiAgICAgICAgIC8qIHJl c2VydmUgci93IHVuaXR5LW1hcHBlZCBwYWdlIGVudHJpZXMgZm9yIGRldmlj ZXMgKi8KICAgICAgICAgLyogbm90ZTogdGhlc2UgZW50cmllcyBhcmUgcGFy dCBvZiB0aGUgZXhjbHVzaW9uIHJhbmdlICovCi0gICAgICAgIGZvciAoIGJk ZiA9IDA7IGJkZiA8IGl2cnNfYmRmX2VudHJpZXM7IGJkZisrICkKLSAgICAg ICAgICAgIHJlc2VydmVfdW5pdHlfbWFwX2Zvcl9kZXZpY2Uoc2VnLCBiZGYs IGJhc2UsIGxlbmd0aCwgaXcsIGlyKTsKKyAgICAgICAgZm9yICggYmRmID0g MDsgIXJjICYmIGJkZiA8IGl2cnNfYmRmX2VudHJpZXM7IGJkZisrICkKKyAg ICAgICAgICAgIHJjID0gcmVzZXJ2ZV91bml0eV9tYXBfZm9yX2RldmljZShz ZWcsIGJkZiwgYmFzZSwgbGVuZ3RoLCBpdywgaXIpOwogICAgICAgICAvKiBw dXNoICdiYXNlJyBqdXN0IG91dHNpZGUgb2YgdmlydHVhbCBhZGRyZXNzIHNw YWNlICovCiAgICAgICAgIGJhc2UgPSBpb21tdV90b3A7CiAgICAgfQogICAg IC8qIHJlZ2lzdGVyIElPTU1VIGV4Y2x1c2lvbiByYW5nZSBzZXR0aW5ncyAq LwotICAgIGlmICggbGltaXQgPj0gaW9tbXVfdG9wICkKKyAgICBpZiAoICFy YyAmJiBsaW1pdCA+PSBpb21tdV90b3AgKQogICAgIHsKICAgICAgICAgZm9y X2VhY2hfYW1kX2lvbW11KCBpb21tdSApCiAgICAgICAgIHsKQEAgLTI0MSwx NSArMjU3LDE1IEBAIHN0YXRpYyBpbnQgX19pbml0IHJlZ2lzdGVyX2V4Y2x1 c2lvbl9yYW4KICAgICAgICAgbGVuZ3RoID0gcmFuZ2VfdG9wIC0gYmFzZTsK ICAgICAgICAgLyogcmVzZXJ2ZSB1bml0eS1tYXBwZWQgcGFnZSBlbnRyaWVz IGZvciBkZXZpY2UgKi8KICAgICAgICAgLyogbm90ZTogdGhlc2UgZW50cmll cyBhcmUgcGFydCBvZiB0aGUgZXhjbHVzaW9uIHJhbmdlICovCi0gICAgICAg IHJlc2VydmVfdW5pdHlfbWFwX2Zvcl9kZXZpY2Uoc2VnLCBiZGYsIGJhc2Us IGxlbmd0aCwgaXcsIGlyKTsKLSAgICAgICAgcmVzZXJ2ZV91bml0eV9tYXBf Zm9yX2RldmljZShzZWcsIHJlcSwgYmFzZSwgbGVuZ3RoLCBpdywgaXIpOwor ICAgICAgICByYyA9IHJlc2VydmVfdW5pdHlfbWFwX2Zvcl9kZXZpY2Uoc2Vn LCBiZGYsIGJhc2UsIGxlbmd0aCwgaXcsIGlyKSA/OgorICAgICAgICAgICAg IHJlc2VydmVfdW5pdHlfbWFwX2Zvcl9kZXZpY2Uoc2VnLCByZXEsIGJhc2Us IGxlbmd0aCwgaXcsIGlyKTsKIAogICAgICAgICAvKiBwdXNoICdiYXNlJyBq dXN0IG91dHNpZGUgb2YgdmlydHVhbCBhZGRyZXNzIHNwYWNlICovCiAgICAg ICAgIGJhc2UgPSBpb21tdV90b3A7CiAgICAgfQogCiAgICAgLyogcmVnaXN0 ZXIgSU9NTVUgZXhjbHVzaW9uIHJhbmdlIHNldHRpbmdzIGZvciBkZXZpY2Ug Ki8KLSAgICBpZiAoIGxpbWl0ID49IGlvbW11X3RvcCAgKQorICAgIGlmICgg IXJjICYmIGxpbWl0ID49IGlvbW11X3RvcCAgKQogICAgIHsKICAgICAgICAg cmMgPSByZXNlcnZlX2lvbW11X2V4Y2x1c2lvbl9yYW5nZShpb21tdSwgYmFz ZSwgbGltaXQsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgZmFsc2UgLyogYWxsICovLCBpdywgaXIpOwpAQCAtMjgwLDE1 ICsyOTYsMTUgQEAgc3RhdGljIGludCBfX2luaXQgcmVnaXN0ZXJfZXhjbHVz aW9uX3JhbgogICAgICAgICBsZW5ndGggPSByYW5nZV90b3AgLSBiYXNlOwog ICAgICAgICAvKiByZXNlcnZlIHIvdyB1bml0eS1tYXBwZWQgcGFnZSBlbnRy aWVzIGZvciBkZXZpY2VzICovCiAgICAgICAgIC8qIG5vdGU6IHRoZXNlIGVu dHJpZXMgYXJlIHBhcnQgb2YgdGhlIGV4Y2x1c2lvbiByYW5nZSAqLwotICAg ICAgICBmb3IgKCBiZGYgPSAwOyBiZGYgPCBpdnJzX2JkZl9lbnRyaWVzOyBi ZGYrKyApCisgICAgICAgIGZvciAoIGJkZiA9IDA7ICFyYyAmJiBiZGYgPCBp dnJzX2JkZl9lbnRyaWVzOyBiZGYrKyApCiAgICAgICAgIHsKICAgICAgICAg ICAgIGlmICggaW9tbXUgPT0gZmluZF9pb21tdV9mb3JfZGV2aWNlKGlvbW11 LT5zZWcsIGJkZikgKQogICAgICAgICAgICAgewotICAgICAgICAgICAgICAg IHJlc2VydmVfdW5pdHlfbWFwX2Zvcl9kZXZpY2UoaW9tbXUtPnNlZywgYmRm LCBiYXNlLCBsZW5ndGgsCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBpdywgaXIpOwogICAgICAgICAgICAgICAgIHJl cSA9IGdldF9pdnJzX21hcHBpbmdzKGlvbW11LT5zZWcpW2JkZl0uZHRlX3Jl cXVlc3Rvcl9pZDsKLSAgICAgICAgICAgICAgICByZXNlcnZlX3VuaXR5X21h cF9mb3JfZGV2aWNlKGlvbW11LT5zZWcsIHJlcSwgYmFzZSwgbGVuZ3RoLAot ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg aXcsIGlyKTsKKyAgICAgICAgICAgICAgICByYyA9IHJlc2VydmVfdW5pdHlf bWFwX2Zvcl9kZXZpY2UoaW9tbXUtPnNlZywgYmRmLCBiYXNlLCBsZW5ndGgs CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIGl3LCBpcikgPzoKKyAgICAgICAgICAgICAgICAgICAgIHJlc2Vy dmVfdW5pdHlfbWFwX2Zvcl9kZXZpY2UoaW9tbXUtPnNlZywgcmVxLCBiYXNl LCBsZW5ndGgsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIGl3LCBpcik7CiAgICAgICAgICAgICB9CiAgICAg ICAgIH0KIApAQCAtMjk3LDcgKzMxMyw3IEBAIHN0YXRpYyBpbnQgX19pbml0 IHJlZ2lzdGVyX2V4Y2x1c2lvbl9yYW4KICAgICB9CiAKICAgICAvKiByZWdp c3RlciBJT01NVSBleGNsdXNpb24gcmFuZ2Ugc2V0dGluZ3MgKi8KLSAgICBp ZiAoIGxpbWl0ID49IGlvbW11X3RvcCApCisgICAgaWYgKCAhcmMgJiYgbGlt aXQgPj0gaW9tbXVfdG9wICkKICAgICAgICAgcmMgPSByZXNlcnZlX2lvbW11 X2V4Y2x1c2lvbl9yYW5nZShpb21tdSwgYmFzZSwgbGltaXQsCiAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdHJ1ZSAvKiBh bGwgKi8sIGl3LCBpcik7CiAKLS0tIGEveGVuL2RyaXZlcnMvcGFzc3Rocm91 Z2gvYW1kL3BjaV9hbWRfaW9tbXUuYworKysgYi94ZW4vZHJpdmVycy9wYXNz dGhyb3VnaC9hbWQvcGNpX2FtZF9pb21tdS5jCkBAIC0zNjcsMTUgKzM2Nywx NyBAQCBzdGF0aWMgaW50IGFtZF9pb21tdV9hc3NpZ25fZGV2aWNlKHN0cnVj CiAgICAgc3RydWN0IGl2cnNfbWFwcGluZ3MgKml2cnNfbWFwcGluZ3MgPSBn ZXRfaXZyc19tYXBwaW5ncyhwZGV2LT5zZWcpOwogICAgIGludCBiZGYgPSBQ Q0lfQkRGMihwZGV2LT5idXMsIGRldmZuKTsKICAgICBpbnQgcmVxX2lkID0g Z2V0X2RtYV9yZXF1ZXN0b3JfaWQocGRldi0+c2VnLCBiZGYpOworICAgIGNv bnN0IHN0cnVjdCBpdnJzX3VuaXR5X21hcCAqdW5pdHlfbWFwOwogCi0gICAg aWYgKCBpdnJzX21hcHBpbmdzW3JlcV9pZF0udW5pdHlfbWFwX2VuYWJsZSAp CisgICAgZm9yICggdW5pdHlfbWFwID0gaXZyc19tYXBwaW5nc1tyZXFfaWRd LnVuaXR5X21hcDsgdW5pdHlfbWFwOworICAgICAgICAgIHVuaXR5X21hcCA9 IHVuaXR5X21hcC0+bmV4dCApCiAgICAgewotICAgICAgICBhbWRfaW9tbXVf cmVzZXJ2ZV9kb21haW5fdW5pdHlfbWFwKAotICAgICAgICAgICAgZCwKLSAg ICAgICAgICAgIGl2cnNfbWFwcGluZ3NbcmVxX2lkXS5hZGRyX3JhbmdlX3N0 YXJ0LAotICAgICAgICAgICAgaXZyc19tYXBwaW5nc1tyZXFfaWRdLmFkZHJf cmFuZ2VfbGVuZ3RoLAotICAgICAgICAgICAgaXZyc19tYXBwaW5nc1tyZXFf aWRdLndyaXRlX3Blcm1pc3Npb24sCi0gICAgICAgICAgICBpdnJzX21hcHBp bmdzW3JlcV9pZF0ucmVhZF9wZXJtaXNzaW9uKTsKKyAgICAgICAgaW50IHJj ID0gYW1kX2lvbW11X3Jlc2VydmVfZG9tYWluX3VuaXR5X21hcCgKKyAgICAg ICAgICAgICAgICAgICAgIGQsIHVuaXR5X21hcC0+YWRkciwgdW5pdHlfbWFw LT5sZW5ndGgsCisgICAgICAgICAgICAgICAgICAgICB1bml0eV9tYXAtPndy aXRlLCB1bml0eV9tYXAtPnJlYWQpOworCisgICAgICAgIGlmICggcmMgKQor ICAgICAgICAgICAgcmV0dXJuIHJjOwogICAgIH0KIAogICAgIHJldHVybiBy ZWFzc2lnbl9kZXZpY2UocGRldi0+ZG9tYWluLCBkLCBkZXZmbiwgcGRldik7 Cg== --=separator Content-Type: application/octet-stream; name="xsa378/xsa378-4.15-3.patch" Content-Disposition: attachment; filename="xsa378/xsa378-4.15-3.patch" Content-Transfer-Encoding: base64 RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0 OiBJT01NVTogYWxzbyBwYXNzIHAybV9hY2Nlc3NfdCB0byBwMm1fZ2V0X2lv bW11X2ZsYWdzKCkKCkEgc3Vic2VxdWVudCBjaGFuZ2Ugd2lsbCB3YW50IHRv IGN1c3RvbWl6ZSB0aGUgSU9NTVUgcGVybWlzc2lvbnMgYmFzZWQKb24gdGhp cy4KClRoaXMgaXMgcGFydCBvZiBYU0EtMzc4LgoKU2lnbmVkLW9mZi1ieTog SmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpSZXZpZXdlZC1ieTog UGF1bCBEdXJyYW50IDxwYXVsQHhlbi5vcmc+CgotLS0gYS94ZW4vYXJjaC94 ODYvbW0vcDJtLWVwdC5jCisrKyBiL3hlbi9hcmNoL3g4Ni9tbS9wMm0tZXB0 LmMKQEAgLTY4MSw3ICs2ODEsNyBAQCBlcHRfc2V0X2VudHJ5KHN0cnVjdCBw Mm1fZG9tYWluICpwMm0sIGdmCiAgICAgdWludDhfdCBpcGF0ID0gMDsKICAg ICBib29sX3QgbmVlZF9tb2RpZnlfdnRkX3RhYmxlID0gMTsKICAgICBib29s X3QgdnRkX3B0ZV9wcmVzZW50ID0gMDsKLSAgICB1bnNpZ25lZCBpbnQgaW9t bXVfZmxhZ3MgPSBwMm1fZ2V0X2lvbW11X2ZsYWdzKHAybXQsIG1mbik7Cisg ICAgdW5zaWduZWQgaW50IGlvbW11X2ZsYWdzID0gcDJtX2dldF9pb21tdV9m bGFncyhwMm10LCBwMm1hLCBtZm4pOwogICAgIGJvb2xfdCBuZWVkc19zeW5j ID0gMTsKICAgICBlcHRfZW50cnlfdCBvbGRfZW50cnkgPSB7IC5lcHRlID0g MCB9OwogICAgIGVwdF9lbnRyeV90IG5ld19lbnRyeSA9IHsgLmVwdGUgPSAw IH07CkBAIC04MDksOCArODA5LDggQEAgZXB0X3NldF9lbnRyeShzdHJ1Y3Qg cDJtX2RvbWFpbiAqcDJtLCBnZgogCiAgICAgICAgIC8qIFNhZmUgdG8gcmVh ZC10aGVuLXdyaXRlIGJlY2F1c2Ugd2UgaG9sZCB0aGUgcDJtIGxvY2sgKi8K ICAgICAgICAgaWYgKCBlcHRfZW50cnktPm1mbiA9PSBuZXdfZW50cnkubWZu ICYmCi0gICAgICAgICAgICAgcDJtX2dldF9pb21tdV9mbGFncyhlcHRfZW50 cnktPnNhX3AybXQsIF9tZm4oZXB0X2VudHJ5LT5tZm4pKSA9PQotICAgICAg ICAgICAgIGlvbW11X2ZsYWdzICkKKyAgICAgICAgICAgICBwMm1fZ2V0X2lv bW11X2ZsYWdzKGVwdF9lbnRyeS0+c2FfcDJtdCwgZXB0X2VudHJ5LT5hY2Nl c3MsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBfbWZuKGVw dF9lbnRyeS0+bWZuKSkgPT0gaW9tbXVfZmxhZ3MgKQogICAgICAgICAgICAg bmVlZF9tb2RpZnlfdnRkX3RhYmxlID0gMDsKIAogICAgICAgICBlcHRfcDJt X3R5cGVfdG9fZmxhZ3MocDJtLCAmbmV3X2VudHJ5KTsKLS0tIGEveGVuL2Fy Y2gveDg2L21tL3AybS1wdC5jCisrKyBiL3hlbi9hcmNoL3g4Ni9tbS9wMm0t cHQuYwpAQCAtNTQ1LDYgKzU0NSwxNiBAQCBpbnQgcDJtX3B0X2hhbmRsZV9k ZWZlcnJlZF9jaGFuZ2VzKHVpbnQ2CiAgICAgcmV0dXJuIHJjOwogfQogCisv KiBSZWNvbnN0cnVjdCBhIGZha2UgcDJtX2FjY2Vzc190IGZyb20gc3RvcmVk IFBURSBmbGFncy4gKi8KK3N0YXRpYyBwMm1fYWNjZXNzX3QgcDJtX2ZsYWdz X3RvX2FjY2Vzcyh1bnNpZ25lZCBpbnQgZmxhZ3MpCit7CisgICAgaWYgKCBm bGFncyAmIF9QQUdFX1BSRVNFTlQgKQorICAgICAgICByZXR1cm4gcDJtX2Fj Y2Vzc19uOworCisgICAgLyogTm8gbmVlZCB0byBsb29rIGF0IF9QQUdFX05Y IGZvciBub3cuICovCisgICAgcmV0dXJuIGZsYWdzICYgX1BBR0VfUlcgPyBw Mm1fYWNjZXNzX3J3IDogcDJtX2FjY2Vzc19yOworfQorCiAvKiBDaGVja3Mg b25seSBhcHBsaWNhYmxlIHRvIGVudHJpZXMgd2l0aCBvcmRlciA+IFBBR0Vf T1JERVJfNEsgKi8KIHN0YXRpYyB2b2lkIGNoZWNrX2VudHJ5KG1mbl90IG1m biwgcDJtX3R5cGVfdCBuZXcsIHAybV90eXBlX3Qgb2xkLAogICAgICAgICAg ICAgICAgICAgICAgICAgdW5zaWduZWQgaW50IG9yZGVyKQpAQCAtNTc5LDcg KzU4OSw3IEBAIHAybV9wdF9zZXRfZW50cnkoc3RydWN0IHAybV9kb21haW4g KnAybSwKICAgICBsMl9wZ2VudHJ5X3QgbDJlX2NvbnRlbnQ7CiAgICAgbDNf cGdlbnRyeV90IGwzZV9jb250ZW50OwogICAgIGludCByYzsKLSAgICB1bnNp Z25lZCBpbnQgaW9tbXVfcHRlX2ZsYWdzID0gcDJtX2dldF9pb21tdV9mbGFn cyhwMm10LCBtZm4pOworICAgIHVuc2lnbmVkIGludCBpb21tdV9wdGVfZmxh Z3MgPSBwMm1fZ2V0X2lvbW11X2ZsYWdzKHAybXQsIHAybWEsIG1mbik7CiAg ICAgLyoKICAgICAgKiBvbGRfbWZuIGFuZCBpb21tdV9vbGRfZmxhZ3MgY29u dHJvbCBwb3NzaWJsZSBmbHVzaC91cGRhdGUgbmVlZHMgb24gdGhlCiAgICAg ICogSU9NTVU6IFdlIG5lZWQgdG8gZmx1c2ggd2hlbiBNRk4gb3IgZmxhZ3Mg KGkuZS4gcGVybWlzc2lvbnMpIGNoYW5nZS4KQEAgLTY0Miw2ICs2NTIsNyBA QCBwMm1fcHRfc2V0X2VudHJ5KHN0cnVjdCBwMm1fZG9tYWluICpwMm0sCiAg ICAgICAgICAgICAgICAgb2xkX21mbiA9IGwxZV9nZXRfcGZuKCpwMm1fZW50 cnkpOwogICAgICAgICAgICAgICAgIGlvbW11X29sZF9mbGFncyA9CiAgICAg ICAgICAgICAgICAgICAgIHAybV9nZXRfaW9tbXVfZmxhZ3MocDJtX2ZsYWdz X3RvX3R5cGUoZmxhZ3MpLAorICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIHAybV9mbGFnc190b19hY2Nlc3MoZmxhZ3MpLAogICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIF9tZm4ob2xk X21mbikpOwogICAgICAgICAgICAgfQogICAgICAgICAgICAgZWxzZQpAQCAt Njg0LDkgKzY5NSwxMCBAQCBwMm1fcHRfc2V0X2VudHJ5KHN0cnVjdCBwMm1f ZG9tYWluICpwMm0sCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIDAsIEwxX1BBR0VUQUJMRV9FTlRSSUVTKTsKICAgICAgICAgQVNTRVJU KHAybV9lbnRyeSk7CiAgICAgICAgIG9sZF9tZm4gPSBsMWVfZ2V0X3Bmbigq cDJtX2VudHJ5KTsKKyAgICAgICAgZmxhZ3MgPSBsMWVfZ2V0X2ZsYWdzKCpw Mm1fZW50cnkpOwogICAgICAgICBpb21tdV9vbGRfZmxhZ3MgPQotICAgICAg ICAgICAgcDJtX2dldF9pb21tdV9mbGFncyhwMm1fZmxhZ3NfdG9fdHlwZShs MWVfZ2V0X2ZsYWdzKCpwMm1fZW50cnkpKSwKLSAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgX21mbihvbGRfbWZuKSk7CisgICAgICAgICAgICBw Mm1fZ2V0X2lvbW11X2ZsYWdzKHAybV9mbGFnc190b190eXBlKGZsYWdzKSwK KyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcDJtX2ZsYWdzX3Rv X2FjY2VzcyhmbGFncyksIF9tZm4ob2xkX21mbikpOwogCiAgICAgICAgIGlm ICggbWZuX3ZhbGlkKG1mbikgfHwgcDJtX2FsbG93c19pbnZhbGlkX21mbihw Mm10KSApCiAgICAgICAgICAgICBlbnRyeV9jb250ZW50ID0gcDJtX2wxZV9m cm9tX3BmbihtZm5feChtZm4pLApAQCAtNzE0LDYgKzcyNiw3IEBAIHAybV9w dF9zZXRfZW50cnkoc3RydWN0IHAybV9kb21haW4gKnAybSwKICAgICAgICAg ICAgICAgICBvbGRfbWZuID0gbDFlX2dldF9wZm4oKnAybV9lbnRyeSk7CiAg ICAgICAgICAgICAgICAgaW9tbXVfb2xkX2ZsYWdzID0KICAgICAgICAgICAg ICAgICAgICAgcDJtX2dldF9pb21tdV9mbGFncyhwMm1fZmxhZ3NfdG9fdHlw ZShmbGFncyksCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgcDJtX2ZsYWdzX3RvX2FjY2VzcyhmbGFncyksCiAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgX21mbihvbGRfbWZuKSk7 CiAgICAgICAgICAgICB9CiAgICAgICAgICAgICBlbHNlCi0tLSBhL3hlbi9p bmNsdWRlL2FzbS14ODYvcDJtLmgKKysrIGIveGVuL2luY2x1ZGUvYXNtLXg4 Ni9wMm0uaApAQCAtOTE1LDcgKzkxNSw4IEBAIHN0YXRpYyBpbmxpbmUgdm9p ZCBwMm1fYWx0cDJtX2NoZWNrKHN0cnUKIC8qCiAgKiBwMm0gdHlwZSB0byBJ T01NVSBmbGFncwogICovCi1zdGF0aWMgaW5saW5lIHVuc2lnbmVkIGludCBw Mm1fZ2V0X2lvbW11X2ZsYWdzKHAybV90eXBlX3QgcDJtdCwgbWZuX3QgbWZu KQorc3RhdGljIGlubGluZSB1bnNpZ25lZCBpbnQgcDJtX2dldF9pb21tdV9m bGFncyhwMm1fdHlwZV90IHAybXQsCisgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIHAybV9hY2Nlc3NfdCBwMm1hLCBt Zm5fdCBtZm4pCiB7CiAgICAgdW5zaWduZWQgaW50IGZsYWdzOwogCg== --=separator Content-Type: application/octet-stream; name="xsa378/xsa378-4.15-4.patch" Content-Disposition: attachment; filename="xsa378/xsa378-4.15-4.patch" Content-Transfer-Encoding: base64 RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0 OiBJT01NVTogZ2VuZXJhbGl6ZSBWVC1kJ3MgdHJhY2tpbmcgb2YgbWFwcGVk IFJNUlIgcmVnaW9ucwoKSW4gb3JkZXIgdG8gcmUtdXNlIGl0IGVsc2V3aGVy ZSwgbW92ZSB0aGUgbG9naWMgdG8gdmVuZG9yIGluZGVwZW5kZW50CmNvZGUg YW5kIHN0cmlwIGl0IG9mIFJNUlIgc3BlY2lmaWNzLgoKTm90ZSB0aGF0IHRo ZSBwcmlvciAibWFwIiBwYXJhbWV0ZXIgZ2V0cyBmb2xkZWQgaW50byB0aGUg bmV3ICJwMm1hIiBvbmUKKHdoaWNoIEFNRCBJT01NVSBjb2RlIHdpbGwgd2Fu dCB0byBtYWtlIHVzZSBvZiksIGFzc2lnbmluZyBhbHRlcm5hdGl2ZQptZWFu aW5nICgidW5tYXAiKSB0byBwMm1fYWNjZXNzX3guIFByZXBhcmUgc2V0X2lk ZW50aXR5X3AybV9lbnRyeSgpIGFuZApwMm1fZ2V0X2lvbW11X2ZsYWdzKCkg Zm9yIGdldHRpbmcgcGFzc2VkIGFjY2VzcyB0eXBlcyBvdGhlciB0aGFuCnAy bV9hY2Nlc3NfcncgKGluIHRoZSBsYXR0ZXIgY2FzZSBqdXN0IGZvciBwMm1f bW1pb19kaXJlY3QgcmVxdWVzdHMpLgoKTm90ZSBhbHNvIHRoYXQsIHRvIGJl IG9uIHRoZSBzYWZlIHNpZGUsIGFuIG92ZXJsYXAgY2hlY2sgZ2V0cyBhZGRl ZCB0bwp0aGUgbWFpbiBsb29wIG9mIGlvbW11X2lkZW50aXR5X21hcHBpbmco KS4KClRoaXMgaXMgcGFydCBvZiBYU0EtMzc4LgoKU2lnbmVkLW9mZi1ieTog SmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpSZXZpZXdlZC1ieTog UGF1bCBEdXJyYW50IDxwYXVsQHhlbi5vcmc+CgotLS0gYS94ZW4vYXJjaC94 ODYvbW0vcDJtLmMKKysrIGIveGVuL2FyY2gveDg2L21tL3AybS5jCkBAIC0x MzY1LDcgKzEzNjUsNyBAQCBpbnQgc2V0X2lkZW50aXR5X3AybV9lbnRyeShz dHJ1Y3QgZG9tYWluCiAgICAgICAgICAgICByZXR1cm4gMDsKICAgICAgICAg cmV0dXJuIGlvbW11X2xlZ2FjeV9tYXAoZCwgX2RmbihnZm5fbCksIF9tZm4o Z2ZuX2wpLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAxdWwg PDwgUEFHRV9PUkRFUl80SywKLSAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgSU9NTVVGX3JlYWRhYmxlIHwgSU9NTVVGX3dyaXRhYmxlKTsKKyAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcDJtX2FjY2Vzc190b19p b21tdV9mbGFncyhwMm1hKSk7CiAgICAgfQogCiAgICAgZ2ZuX2xvY2socDJt LCBnZm4sIDApOwotLS0gYS94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC92dGQv aW9tbXUuYworKysgYi94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC92dGQvaW9t bXUuYwpAQCAtNDIsMTIgKzQyLDYgQEAKICNpbmNsdWRlICJ2dGQuaCIKICNp bmNsdWRlICIuLi9hdHMuaCIKIAotc3RydWN0IG1hcHBlZF9ybXJyIHsKLSAg ICBzdHJ1Y3QgbGlzdF9oZWFkIGxpc3Q7Ci0gICAgdTY0IGJhc2UsIGVuZDsK LSAgICB1bnNpZ25lZCBpbnQgY291bnQ7Ci19OwotCiAvKiBQb3NzaWJsZSB1 bmZpbHRlcmVkIExBUElDL01TSSBtZXNzYWdlcyBmcm9tIHVudHJ1c3RlZCBz b3VyY2VzPyAqLwogYm9vbCBfX3JlYWRfbW9zdGx5IHVudHJ1c3RlZF9tc2k7 CiAKQEAgLTEzMTEsNyArMTMwNSw2IEBAIHN0YXRpYyBpbnQgaW50ZWxfaW9t bXVfZG9tYWluX2luaXQoc3RydWMKICAgICBzdHJ1Y3QgZG9tYWluX2lvbW11 ICpoZCA9IGRvbV9pb21tdShkKTsKIAogICAgIGhkLT5hcmNoLnZ0ZC5hZ2F3 ID0gd2lkdGhfdG9fYWdhdyhERUZBVUxUX0RPTUFJTl9BRERSRVNTX1dJRFRI KTsKLSAgICBJTklUX0xJU1RfSEVBRCgmaGQtPmFyY2gudnRkLm1hcHBlZF9y bXJycyk7CiAKICAgICByZXR1cm4gMDsKIH0KQEAgLTE3ODgsMTcgKzE3ODEs MTIgQEAgc3RhdGljIHZvaWQgaW9tbXVfY2xlYXJfcm9vdF9wZ3RhYmxlKHN0 cgogc3RhdGljIHZvaWQgaW9tbXVfZG9tYWluX3RlYXJkb3duKHN0cnVjdCBk b21haW4gKmQpCiB7CiAgICAgc3RydWN0IGRvbWFpbl9pb21tdSAqaGQgPSBk b21faW9tbXUoZCk7Ci0gICAgc3RydWN0IG1hcHBlZF9ybXJyICptcm1yciwg KnRtcDsKICAgICBjb25zdCBzdHJ1Y3QgYWNwaV9kcmhkX3VuaXQgKmRyaGQ7 CiAKICAgICBpZiAoIGxpc3RfZW1wdHkoJmFjcGlfZHJoZF91bml0cykgKQog ICAgICAgICByZXR1cm47CiAKLSAgICBsaXN0X2Zvcl9lYWNoX2VudHJ5X3Nh ZmUgKCBtcm1yciwgdG1wLCAmaGQtPmFyY2gudnRkLm1hcHBlZF9ybXJycywg bGlzdCApCi0gICAgewotICAgICAgICBsaXN0X2RlbCgmbXJtcnItPmxpc3Qp OwotICAgICAgICB4ZnJlZShtcm1ycik7Ci0gICAgfQorICAgIGlvbW11X2lk ZW50aXR5X21hcF90ZWFyZG93bihkKTsKIAogICAgIEFTU0VSVCghaGQtPmFy Y2gudnRkLnBnZF9tYWRkcik7CiAKQEAgLTE5NDYsNzQgKzE5MzQsNiBAQCBz dGF0aWMgaW50IF9faW5pdCB2dGRfZXB0X3BhZ2VfY29tcGF0aWJsCiAgICAg ICAgICAgIChlcHRfaGFzXzFnYihlcHRfY2FwKSAmJiBvcHRfaGFwXzFnYikg PD0gY2FwX3Nwc18xZ2IodnRkX2NhcCk7CiB9CiAKLXN0YXRpYyBpbnQgcm1y cl9pZGVudGl0eV9tYXBwaW5nKHN0cnVjdCBkb21haW4gKmQsIGJvb2xfdCBt YXAsCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjb25zdCBz dHJ1Y3QgYWNwaV9ybXJyX3VuaXQgKnJtcnIsCi0gICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICB1MzIgZmxhZykKLXsKLSAgICB1bnNpZ25lZCBs b25nIGJhc2VfcGZuID0gcm1yci0+YmFzZV9hZGRyZXNzID4+IFBBR0VfU0hJ RlRfNEs7Ci0gICAgdW5zaWduZWQgbG9uZyBlbmRfcGZuID0gUEFHRV9BTElH Tl80SyhybXJyLT5lbmRfYWRkcmVzcykgPj4gUEFHRV9TSElGVF80SzsKLSAg ICBzdHJ1Y3QgbWFwcGVkX3JtcnIgKm1ybXJyOwotICAgIHN0cnVjdCBkb21h aW5faW9tbXUgKmhkID0gZG9tX2lvbW11KGQpOwotCi0gICAgQVNTRVJUKHBj aWRldnNfbG9ja2VkKCkpOwotICAgIEFTU0VSVChybXJyLT5iYXNlX2FkZHJl c3MgPCBybXJyLT5lbmRfYWRkcmVzcyk7Ci0KLSAgICAvKgotICAgICAqIE5v IG5lZWQgdG8gYWNxdWlyZSBoZC0+YXJjaC5tYXBwaW5nX2xvY2s6IEJvdGgg aW5zZXJ0aW9uIGFuZCByZW1vdmFsCi0gICAgICogZ2V0IGRvbmUgd2hpbGUg aG9sZGluZyBwY2lkZXZzX2xvY2suCi0gICAgICovCi0gICAgbGlzdF9mb3Jf ZWFjaF9lbnRyeSggbXJtcnIsICZoZC0+YXJjaC52dGQubWFwcGVkX3JtcnJz LCBsaXN0ICkKLSAgICB7Ci0gICAgICAgIGlmICggbXJtcnItPmJhc2UgPT0g cm1yci0+YmFzZV9hZGRyZXNzICYmCi0gICAgICAgICAgICAgbXJtcnItPmVu ZCA9PSBybXJyLT5lbmRfYWRkcmVzcyApCi0gICAgICAgIHsKLSAgICAgICAg ICAgIGludCByZXQgPSAwOwotCi0gICAgICAgICAgICBpZiAoIG1hcCApCi0g ICAgICAgICAgICB7Ci0gICAgICAgICAgICAgICAgKyttcm1yci0+Y291bnQ7 Ci0gICAgICAgICAgICAgICAgcmV0dXJuIDA7Ci0gICAgICAgICAgICB9Ci0K LSAgICAgICAgICAgIGlmICggLS1tcm1yci0+Y291bnQgKQotICAgICAgICAg ICAgICAgIHJldHVybiAwOwotCi0gICAgICAgICAgICB3aGlsZSAoIGJhc2Vf cGZuIDwgZW5kX3BmbiApCi0gICAgICAgICAgICB7Ci0gICAgICAgICAgICAg ICAgaWYgKCBjbGVhcl9pZGVudGl0eV9wMm1fZW50cnkoZCwgYmFzZV9wZm4p ICkKLSAgICAgICAgICAgICAgICAgICAgcmV0ID0gLUVOWElPOwotICAgICAg ICAgICAgICAgIGJhc2VfcGZuKys7Ci0gICAgICAgICAgICB9Ci0KLSAgICAg ICAgICAgIGxpc3RfZGVsKCZtcm1yci0+bGlzdCk7Ci0gICAgICAgICAgICB4 ZnJlZShtcm1ycik7Ci0gICAgICAgICAgICByZXR1cm4gcmV0OwotICAgICAg ICB9Ci0gICAgfQotCi0gICAgaWYgKCAhbWFwICkKLSAgICAgICAgcmV0dXJu IC1FTk9FTlQ7Ci0KLSAgICB3aGlsZSAoIGJhc2VfcGZuIDwgZW5kX3BmbiAp Ci0gICAgewotICAgICAgICBpbnQgZXJyID0gc2V0X2lkZW50aXR5X3AybV9l bnRyeShkLCBiYXNlX3BmbiwgcDJtX2FjY2Vzc19ydywgZmxhZyk7Ci0KLSAg ICAgICAgaWYgKCBlcnIgKQotICAgICAgICAgICAgcmV0dXJuIGVycjsKLSAg ICAgICAgYmFzZV9wZm4rKzsKLSAgICB9Ci0KLSAgICBtcm1yciA9IHhtYWxs b2Moc3RydWN0IG1hcHBlZF9ybXJyKTsKLSAgICBpZiAoICFtcm1yciApCi0g ICAgICAgIHJldHVybiAtRU5PTUVNOwotICAgIG1ybXJyLT5iYXNlID0gcm1y ci0+YmFzZV9hZGRyZXNzOwotICAgIG1ybXJyLT5lbmQgPSBybXJyLT5lbmRf YWRkcmVzczsKLSAgICBtcm1yci0+Y291bnQgPSAxOwotICAgIGxpc3RfYWRk X3RhaWwoJm1ybXJyLT5saXN0LCAmaGQtPmFyY2gudnRkLm1hcHBlZF9ybXJy cyk7Ci0KLSAgICByZXR1cm4gMDsKLX0KLQogc3RhdGljIGludCBpbnRlbF9p b21tdV9hZGRfZGV2aWNlKHU4IGRldmZuLCBzdHJ1Y3QgcGNpX2RldiAqcGRl dikKIHsKICAgICBzdHJ1Y3QgYWNwaV9ybXJyX3VuaXQgKnJtcnI7CkBAIC0y MDQ1LDcgKzE5NjUsOSBAQCBzdGF0aWMgaW50IGludGVsX2lvbW11X2FkZF9k ZXZpY2UodTggZGV2CiAgICAgICAgICAgICAgKiBTaW5jZSBSTVJScyBhcmUg YWx3YXlzIHJlc2VydmVkIGluIHRoZSBlODIwIG1hcCBmb3IgdGhlIGhhcmR3 YXJlCiAgICAgICAgICAgICAgKiBkb21haW4sIHRoZXJlIHNob3VsZG4ndCBi ZSBhIGNvbmZsaWN0LgogICAgICAgICAgICAgICovCi0gICAgICAgICAgICBy ZXQgPSBybXJyX2lkZW50aXR5X21hcHBpbmcocGRldi0+ZG9tYWluLCAxLCBy bXJyLCAwKTsKKyAgICAgICAgICAgIHJldCA9IGlvbW11X2lkZW50aXR5X21h cHBpbmcocGRldi0+ZG9tYWluLCBwMm1fYWNjZXNzX3J3LAorICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBybXJyLT5iYXNlX2Fk ZHJlc3MsIHJtcnItPmVuZF9hZGRyZXNzLAorICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAwKTsKICAgICAgICAgICAgIGlmICgg cmV0ICkKICAgICAgICAgICAgICAgICBkcHJpbnRrKFhFTkxPR19FUlIgVlRE UFJFRklYLCAiZCVkOiBSTVJSIG1hcHBpbmcgZmFpbGVkXG4iLAogICAgICAg ICAgICAgICAgICAgICAgICAgcGRldi0+ZG9tYWluLT5kb21haW5faWQpOwpA QCAtMjA5MCw3ICsyMDEyLDggQEAgc3RhdGljIGludCBpbnRlbF9pb21tdV9y ZW1vdmVfZGV2aWNlKHU4CiAgICAgICAgICAqIEFueSBmbGFnIGlzIG5vdGhp bmcgdG8gY2xlYXIgdGhlc2UgbWFwcGluZ3MgYnV0IGhlcmUKICAgICAgICAg ICogaXRzIGFsd2F5cyBzYWZlIGFuZCBzdHJpY3QgdG8gc2V0IDAuCiAgICAg ICAgICAqLwotICAgICAgICBybXJyX2lkZW50aXR5X21hcHBpbmcocGRldi0+ ZG9tYWluLCAwLCBybXJyLCAwKTsKKyAgICAgICAgaW9tbXVfaWRlbnRpdHlf bWFwcGluZyhwZGV2LT5kb21haW4sIHAybV9hY2Nlc3NfeCwgcm1yci0+YmFz ZV9hZGRyZXNzLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHJt cnItPmVuZF9hZGRyZXNzLCAwKTsKICAgICB9CiAKICAgICByZXR1cm4gZG9t YWluX2NvbnRleHRfdW5tYXAocGRldi0+ZG9tYWluLCBkZXZmbiwgcGRldik7 CkBAIC0yMjg5LDcgKzIyMTIsOCBAQCBzdGF0aWMgdm9pZCBfX2h3ZG9tX2lu aXQgc2V0dXBfaHdkb21fcm1yCiAgICAgICAgICAqIGRvbWFpbiwgdGhlcmUg c2hvdWxkbid0IGJlIGEgY29uZmxpY3QuIFNvIGl0cyBhbHdheXMgc2FmZSBh bmQKICAgICAgICAgICogc3RyaWN0IHRvIHNldCAwLgogICAgICAgICAgKi8K LSAgICAgICAgcmV0ID0gcm1ycl9pZGVudGl0eV9tYXBwaW5nKGQsIDEsIHJt cnIsIDApOworICAgICAgICByZXQgPSBpb21tdV9pZGVudGl0eV9tYXBwaW5n KGQsIHAybV9hY2Nlc3NfcncsIHJtcnItPmJhc2VfYWRkcmVzcywKKyAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBybXJyLT5lbmRfYWRk cmVzcywgMCk7CiAgICAgICAgIGlmICggcmV0ICkKICAgICAgICAgICAgIGRw cmludGsoWEVOTE9HX0VSUiBWVERQUkVGSVgsCiAgICAgICAgICAgICAgICAg ICAgICAiSU9NTVU6IG1hcHBpbmcgcmVzZXJ2ZWQgcmVnaW9uIGZhaWxlZFxu Iik7CkBAIC0yNDYwLDcgKzIzODQsOSBAQCBzdGF0aWMgaW50IHJlYXNzaWdu X2RldmljZV9vd25lcnNoaXAoCiAgICAgICAgICAgICAgICAgICogQW55IFJN UlIgZmxhZyBpcyBhbHdheXMgaWdub3JlZCB3aGVuIHJlbW92ZSBhIGRldmlj ZSwKICAgICAgICAgICAgICAgICAgKiBidXQgaXRzIGFsd2F5cyBzYWZlIGFu ZCBzdHJpY3QgdG8gc2V0IDAuCiAgICAgICAgICAgICAgICAgICovCi0gICAg ICAgICAgICAgICAgcmV0ID0gcm1ycl9pZGVudGl0eV9tYXBwaW5nKHNvdXJj ZSwgMCwgcm1yciwgMCk7CisgICAgICAgICAgICAgICAgcmV0ID0gaW9tbXVf aWRlbnRpdHlfbWFwcGluZyhzb3VyY2UsIHAybV9hY2Nlc3NfeCwKKyAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHJtcnIt PmJhc2VfYWRkcmVzcywKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIHJtcnItPmVuZF9hZGRyZXNzLCAwKTsKICAgICAg ICAgICAgICAgICBpZiAoIHJldCAhPSAtRU5PRU5UICkKICAgICAgICAgICAg ICAgICAgICAgcmV0dXJuIHJldDsKICAgICAgICAgICAgIH0KQEAgLTI1NTYs NyArMjQ4Miw4IEBAIHN0YXRpYyBpbnQgaW50ZWxfaW9tbXVfYXNzaWduX2Rl dmljZSgKICAgICAgICAgICAgICBQQ0lfQlVTKGJkZikgPT0gYnVzICYmCiAg ICAgICAgICAgICAgUENJX0RFVkZOMihiZGYpID09IGRldmZuICkKICAgICAg ICAgewotICAgICAgICAgICAgcmV0ID0gcm1ycl9pZGVudGl0eV9tYXBwaW5n KGQsIDEsIHJtcnIsIGZsYWcpOworICAgICAgICAgICAgcmV0ID0gaW9tbXVf aWRlbnRpdHlfbWFwcGluZyhkLCBwMm1fYWNjZXNzX3J3LCBybXJyLT5iYXNl X2FkZHJlc3MsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIHJtcnItPmVuZF9hZGRyZXNzLCBmbGFnKTsKICAgICAgICAgICAg IGlmICggcmV0ICkKICAgICAgICAgICAgIHsKICAgICAgICAgICAgICAgICBp bnQgcmM7Ci0tLSBhL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL3g4Ni9pb21t dS5jCisrKyBiL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL3g4Ni9pb21tdS5j CkBAIC0xNDMsNiArMTQzLDcgQEAgaW50IGFyY2hfaW9tbXVfZG9tYWluX2lu aXQoc3RydWN0IGRvbWFpbgogCiAgICAgSU5JVF9QQUdFX0xJU1RfSEVBRCgm aGQtPmFyY2gucGd0YWJsZXMubGlzdCk7CiAgICAgc3Bpbl9sb2NrX2luaXQo JmhkLT5hcmNoLnBndGFibGVzLmxvY2spOworICAgIElOSVRfTElTVF9IRUFE KCZoZC0+YXJjaC5pZGVudGl0eV9tYXBzKTsKIAogICAgIHJldHVybiAwOwog fQpAQCAtMTU4LDYgKzE1OSw5OSBAQCB2b2lkIGFyY2hfaW9tbXVfZG9tYWlu X2Rlc3Ryb3koc3RydWN0IGRvCiAgICAgICAgICAgIHBhZ2VfbGlzdF9lbXB0 eSgmZG9tX2lvbW11KGQpLT5hcmNoLnBndGFibGVzLmxpc3QpKTsKIH0KIAor c3RydWN0IGlkZW50aXR5X21hcCB7CisgICAgc3RydWN0IGxpc3RfaGVhZCBs aXN0OworICAgIHBhZGRyX3QgYmFzZSwgZW5kOworICAgIHAybV9hY2Nlc3Nf dCBhY2Nlc3M7CisgICAgdW5zaWduZWQgaW50IGNvdW50OworfTsKKworaW50 IGlvbW11X2lkZW50aXR5X21hcHBpbmcoc3RydWN0IGRvbWFpbiAqZCwgcDJt X2FjY2Vzc190IHAybWEsCisgICAgICAgICAgICAgICAgICAgICAgICAgICBw YWRkcl90IGJhc2UsIHBhZGRyX3QgZW5kLAorICAgICAgICAgICAgICAgICAg ICAgICAgICAgdW5zaWduZWQgaW50IGZsYWcpCit7CisgICAgdW5zaWduZWQg bG9uZyBiYXNlX3BmbiA9IGJhc2UgPj4gUEFHRV9TSElGVF80SzsKKyAgICB1 bnNpZ25lZCBsb25nIGVuZF9wZm4gPSBQQUdFX0FMSUdOXzRLKGVuZCkgPj4g UEFHRV9TSElGVF80SzsKKyAgICBzdHJ1Y3QgaWRlbnRpdHlfbWFwICptYXA7 CisgICAgc3RydWN0IGRvbWFpbl9pb21tdSAqaGQgPSBkb21faW9tbXUoZCk7 CisKKyAgICBBU1NFUlQocGNpZGV2c19sb2NrZWQoKSk7CisgICAgQVNTRVJU KGJhc2UgPCBlbmQpOworCisgICAgLyoKKyAgICAgKiBObyBuZWVkIHRvIGFj cXVpcmUgaGQtPmFyY2gubWFwcGluZ19sb2NrOiBCb3RoIGluc2VydGlvbiBh bmQgcmVtb3ZhbAorICAgICAqIGdldCBkb25lIHdoaWxlIGhvbGRpbmcgcGNp ZGV2c19sb2NrLgorICAgICAqLworICAgIGxpc3RfZm9yX2VhY2hfZW50cnko IG1hcCwgJmhkLT5hcmNoLmlkZW50aXR5X21hcHMsIGxpc3QgKQorICAgIHsK KyAgICAgICAgaWYgKCBtYXAtPmJhc2UgPT0gYmFzZSAmJiBtYXAtPmVuZCA9 PSBlbmQgKQorICAgICAgICB7CisgICAgICAgICAgICBpbnQgcmV0ID0gMDsK KworICAgICAgICAgICAgaWYgKCBwMm1hICE9IHAybV9hY2Nlc3NfeCApCisg ICAgICAgICAgICB7CisgICAgICAgICAgICAgICAgaWYgKCBtYXAtPmFjY2Vz cyAhPSBwMm1hICkKKyAgICAgICAgICAgICAgICAgICAgcmV0dXJuIC1FQURE UklOVVNFOworICAgICAgICAgICAgICAgICsrbWFwLT5jb3VudDsKKyAgICAg ICAgICAgICAgICByZXR1cm4gMDsKKyAgICAgICAgICAgIH0KKworICAgICAg ICAgICAgaWYgKCAtLW1hcC0+Y291bnQgKQorICAgICAgICAgICAgICAgIHJl dHVybiAwOworCisgICAgICAgICAgICB3aGlsZSAoIGJhc2VfcGZuIDwgZW5k X3BmbiApCisgICAgICAgICAgICB7CisgICAgICAgICAgICAgICAgaWYgKCBj bGVhcl9pZGVudGl0eV9wMm1fZW50cnkoZCwgYmFzZV9wZm4pICkKKyAgICAg ICAgICAgICAgICAgICAgcmV0ID0gLUVOWElPOworICAgICAgICAgICAgICAg IGJhc2VfcGZuKys7CisgICAgICAgICAgICB9CisKKyAgICAgICAgICAgIGxp c3RfZGVsKCZtYXAtPmxpc3QpOworICAgICAgICAgICAgeGZyZWUobWFwKTsK KworICAgICAgICAgICAgcmV0dXJuIHJldDsKKyAgICAgICAgfQorCisgICAg ICAgIGlmICggZW5kID49IG1hcC0+YmFzZSAmJiBtYXAtPmVuZCA+PSBiYXNl ICkKKyAgICAgICAgICAgIHJldHVybiAtRUFERFJJTlVTRTsKKyAgICB9CisK KyAgICBpZiAoIHAybWEgPT0gcDJtX2FjY2Vzc194ICkKKyAgICAgICAgcmV0 dXJuIC1FTk9FTlQ7CisKKyAgICB3aGlsZSAoIGJhc2VfcGZuIDwgZW5kX3Bm biApCisgICAgeworICAgICAgICBpbnQgZXJyID0gc2V0X2lkZW50aXR5X3Ay bV9lbnRyeShkLCBiYXNlX3BmbiwgcDJtYSwgZmxhZyk7CisKKyAgICAgICAg aWYgKCBlcnIgKQorICAgICAgICAgICAgcmV0dXJuIGVycjsKKyAgICAgICAg YmFzZV9wZm4rKzsKKyAgICB9CisKKyAgICBtYXAgPSB4bWFsbG9jKHN0cnVj dCBpZGVudGl0eV9tYXApOworICAgIGlmICggIW1hcCApCisgICAgICAgIHJl dHVybiAtRU5PTUVNOworICAgIG1hcC0+YmFzZSA9IGJhc2U7CisgICAgbWFw LT5lbmQgPSBlbmQ7CisgICAgbWFwLT5hY2Nlc3MgPSBwMm1hOworICAgIG1h cC0+Y291bnQgPSAxOworICAgIGxpc3RfYWRkX3RhaWwoJm1hcC0+bGlzdCwg JmhkLT5hcmNoLmlkZW50aXR5X21hcHMpOworCisgICAgcmV0dXJuIDA7Cit9 CisKK3ZvaWQgaW9tbXVfaWRlbnRpdHlfbWFwX3RlYXJkb3duKHN0cnVjdCBk b21haW4gKmQpCit7CisgICAgc3RydWN0IGRvbWFpbl9pb21tdSAqaGQgPSBk b21faW9tbXUoZCk7CisgICAgc3RydWN0IGlkZW50aXR5X21hcCAqbWFwLCAq dG1wOworCisgICAgbGlzdF9mb3JfZWFjaF9lbnRyeV9zYWZlICggbWFwLCB0 bXAsICZoZC0+YXJjaC5pZGVudGl0eV9tYXBzLCBsaXN0ICkKKyAgICB7Cisg ICAgICAgIGxpc3RfZGVsKCZtYXAtPmxpc3QpOworICAgICAgICB4ZnJlZSht YXApOworICAgIH0KK30KKwogc3RhdGljIGJvb2wgX19od2RvbV9pbml0IGh3 ZG9tX2lvbW11X21hcChjb25zdCBzdHJ1Y3QgZG9tYWluICpkLAogICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB1bnNpZ25lZCBs b25nIHBmbiwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgdW5zaWduZWQgbG9uZyBtYXhfcGZuKQotLS0gYS94ZW4vaW5jbHVk ZS9hc20teDg2L2lvbW11LmgKKysrIGIveGVuL2luY2x1ZGUvYXNtLXg4Ni9p b21tdS5oCkBAIC0xNiw2ICsxNiw3IEBACiAKICNpbmNsdWRlIDx4ZW4vZXJy bm8uaD4KICNpbmNsdWRlIDx4ZW4vbGlzdC5oPgorI2luY2x1ZGUgPHhlbi9t ZW1fYWNjZXNzLmg+CiAjaW5jbHVkZSA8eGVuL3NwaW5sb2NrLmg+CiAjaW5j bHVkZSA8YXNtL2FwaWNkZWYuaD4KICNpbmNsdWRlIDxhc20vcHJvY2Vzc29y Lmg+CkBAIC01MSwxMyArNTIsMTQgQEAgc3RydWN0IGFyY2hfaW9tbXUKICAg ICAgICAgc3BpbmxvY2tfdCBsb2NrOwogICAgIH0gcGd0YWJsZXM7CiAKKyAg ICBzdHJ1Y3QgbGlzdF9oZWFkIGlkZW50aXR5X21hcHM7CisKICAgICB1bmlv biB7CiAgICAgICAgIC8qIEludGVsIFZULWQgKi8KICAgICAgICAgc3RydWN0 IHsKICAgICAgICAgICAgIHVpbnQ2NF90IHBnZF9tYWRkcjsgLyogaW8gcGFn ZSBkaXJlY3RvcnkgbWFjaGluZSBhZGRyZXNzICovCiAgICAgICAgICAgICB1 bnNpZ25lZCBpbnQgYWdhdzsgLyogYWRqdXN0ZWQgZ3Vlc3QgYWRkcmVzcyB3 aWR0aCwgMCBpcyBsZXZlbCAyIDMwLWJpdCAqLwogICAgICAgICAgICAgdWlu dDY0X3QgaW9tbXVfYml0bWFwOyAvKiBiaXRtYXAgb2YgaW9tbXUocykgdGhh dCB0aGUgZG9tYWluIHVzZXMgKi8KLSAgICAgICAgICAgIHN0cnVjdCBsaXN0 X2hlYWQgbWFwcGVkX3JtcnJzOwogICAgICAgICB9IHZ0ZDsKICAgICAgICAg LyogQU1EIElPTU1VICovCiAgICAgICAgIHN0cnVjdCB7CkBAIC0xMjMsNiAr MTI1LDExIEBAIHN0YXRpYyBpbmxpbmUgdm9pZCBpb21tdV9kaXNhYmxlX3gy YXBpYygKICAgICAgICAgaW9tbXVfb3BzLmRpc2FibGVfeDJhcGljKCk7CiB9 CiAKK2ludCBpb21tdV9pZGVudGl0eV9tYXBwaW5nKHN0cnVjdCBkb21haW4g KmQsIHAybV9hY2Nlc3NfdCBwMm1hLAorICAgICAgICAgICAgICAgICAgICAg ICAgICAgcGFkZHJfdCBiYXNlLCBwYWRkcl90IGVuZCwKKyAgICAgICAgICAg ICAgICAgICAgICAgICAgIHVuc2lnbmVkIGludCBmbGFnKTsKK3ZvaWQgaW9t bXVfaWRlbnRpdHlfbWFwX3RlYXJkb3duKHN0cnVjdCBkb21haW4gKmQpOwor CiBleHRlcm4gYm9vbCB1bnRydXN0ZWRfbXNpOwogCiBpbnQgcGlfdXBkYXRl X2lydGUoY29uc3Qgc3RydWN0IHBpX2Rlc2MgKnBpX2Rlc2MsIGNvbnN0IHN0 cnVjdCBwaXJxICpwaXJxLAotLS0gYS94ZW4vaW5jbHVkZS9hc20teDg2L3Ay bS5oCisrKyBiL3hlbi9pbmNsdWRlL2FzbS14ODYvcDJtLmgKQEAgLTkxMiw2 ICs5MTIsMzQgQEAgc3RydWN0IHAybV9kb21haW4gKnAybV9nZXRfYWx0cDJt KHN0cnVjdAogc3RhdGljIGlubGluZSB2b2lkIHAybV9hbHRwMm1fY2hlY2so c3RydWN0IHZjcHUgKnYsIHVpbnQxNl90IGlkeCkge30KICNlbmRpZgogCisv KiBwMm0gYWNjZXNzIHRvIElPTU1VIGZsYWdzICovCitzdGF0aWMgaW5saW5l IHVuc2lnbmVkIGludCBwMm1fYWNjZXNzX3RvX2lvbW11X2ZsYWdzKHAybV9h Y2Nlc3NfdCBwMm1hKQoreworICAgIHN3aXRjaCAoIHAybWEgKQorICAgIHsK KyAgICBjYXNlIHAybV9hY2Nlc3Nfcnc6CisgICAgY2FzZSBwMm1fYWNjZXNz X3J3eDoKKyAgICAgICAgcmV0dXJuIElPTU1VRl9yZWFkYWJsZSB8IElPTU1V Rl93cml0YWJsZTsKKworICAgIGNhc2UgcDJtX2FjY2Vzc19yOgorICAgIGNh c2UgcDJtX2FjY2Vzc19yeDoKKyAgICBjYXNlIHAybV9hY2Nlc3Nfcngycnc6 CisgICAgICAgIHJldHVybiBJT01NVUZfcmVhZGFibGU7CisKKyAgICBjYXNl IHAybV9hY2Nlc3NfdzoKKyAgICBjYXNlIHAybV9hY2Nlc3Nfd3g6CisgICAg ICAgIHJldHVybiBJT01NVUZfd3JpdGFibGU7CisKKyAgICBjYXNlIHAybV9h Y2Nlc3NfbjoKKyAgICBjYXNlIHAybV9hY2Nlc3NfeDoKKyAgICBjYXNlIHAy bV9hY2Nlc3NfbjJyd3g6CisgICAgICAgIHJldHVybiAwOworICAgIH0KKwor ICAgIEFTU0VSVF9VTlJFQUNIQUJMRSgpOworICAgIHJldHVybiAwOworfQor CiAvKgogICogcDJtIHR5cGUgdG8gSU9NTVUgZmxhZ3MKICAqLwpAQCAtOTMz LDkgKzk2MSwxMCBAQCBzdGF0aWMgaW5saW5lIHVuc2lnbmVkIGludCBwMm1f Z2V0X2lvbW11CiAgICAgICAgIGZsYWdzID0gSU9NTVVGX3JlYWRhYmxlOwog ICAgICAgICBicmVhazsKICAgICBjYXNlIHAybV9tbWlvX2RpcmVjdDoKLSAg ICAgICAgZmxhZ3MgPSBJT01NVUZfcmVhZGFibGU7Ci0gICAgICAgIGlmICgg IXJhbmdlc2V0X2NvbnRhaW5zX3NpbmdsZXRvbihtbWlvX3JvX3Jhbmdlcywg bWZuX3gobWZuKSkgKQotICAgICAgICAgICAgZmxhZ3MgfD0gSU9NTVVGX3dy aXRhYmxlOworICAgICAgICBmbGFncyA9IHAybV9hY2Nlc3NfdG9faW9tbXVf ZmxhZ3MocDJtYSk7CisgICAgICAgIGlmICggKGZsYWdzICYgSU9NTVVGX3dy aXRhYmxlKSAmJgorICAgICAgICAgICAgIHJhbmdlc2V0X2NvbnRhaW5zX3Np bmdsZXRvbihtbWlvX3JvX3JhbmdlcywgbWZuX3gobWZuKSkgKQorICAgICAg ICAgICAgZmxhZ3MgJj0gfklPTU1VRl93cml0YWJsZTsKICAgICAgICAgYnJl YWs7CiAgICAgZGVmYXVsdDoKICAgICAgICAgZmxhZ3MgPSAwOwo= --=separator Content-Type: application/octet-stream; name="xsa378/xsa378-4.15-5.patch" Content-Disposition: attachment; filename="xsa378/xsa378-4.15-5.patch" Content-Transfer-Encoding: base64 RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0 OiBBTUQvSU9NTVU6IHJlLWFycmFuZ2UvY29tcGxldGUgcmUtYXNzaWdubWVu dCBoYW5kbGluZwoKUHJpb3IgdG8gdGhlIGFzc2lnbm1lbnQgc3RlcCBoYXZp bmcgY29tcGxldGVkIHN1Y2Nlc3NmdWxseSwgZGV2aWNlcwpzaG91bGQgbm90 IGdldCBhc3NvY2lhdGVkIHdpdGggdGhlaXIgbmV3IG93bmVyLiBIYW5kIHRo ZSBkZXZpY2UgdG8gRG9tSU8KKHBlcmhhcHMgdGVtcG9yYXJpbHkpLCB1bnRp bCBhZnRlciB0aGUgZGUtYXNzaWdubWVudCBzdGVwIGhhcyBjb21wbGV0ZWQu CgpEZS1hc3NpZ25tZW50IG9mIGEgZGV2aWNlIChmcm9tIG90aGVyIHRoYW4g RG9tMCkgYXMgd2VsbCBhcyBmYWlsdXJlIG9mCnJlYXNzaWduX2RldmljZSgp IGR1cmluZyBhc3NpZ25tZW50IHNob3VsZCByZXN1bHQgaW4gdW5pdHkgbWFw cGluZ3MKZ2V0dGluZyB0b3JuIGRvd24uIFRoaXMgaW4gdHVybiByZXF1aXJl cyBzd2l0Y2hpbmcgdG8gYSByZWZjb3VudGVkCm1hcHBpbmcgYXBwcm9hY2gs IGFzIHdhcyBhbHJlYWR5IHVzZWQgYnkgVlQtZCBmb3IgaXRzIFJNUlJzLCB0 byBwcmV2ZW50CnVubWFwcGluZyBhIHJlZ2lvbiB1c2VkIGJ5IG11bHRpcGxl IGRldmljZXMuCgpUaGlzIGlzIENWRS0yMDIxLTI4Njk2IC8gcGFydCBvZiBY U0EtMzc4LgoKU2lnbmVkLW9mZi1ieTogSmFuIEJldWxpY2ggPGpiZXVsaWNo QHN1c2UuY29tPgpSZXZpZXdlZC1ieTogUGF1bCBEdXJyYW50IDxwYXVsQHhl bi5vcmc+CgotLS0gYS94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC9hbWQvaW9t bXUuaAorKysgYi94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC9hbWQvaW9tbXUu aApAQCAtMjMyLDggKzIzMiwxMCBAQCBpbnQgX19tdXN0X2NoZWNrIGFtZF9p b21tdV91bm1hcF9wYWdlKHN0CiAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIHVuc2lnbmVkIGludCAqZmx1c2hfZmxhZ3MpOwogaW50 IF9fbXVzdF9jaGVjayBhbWRfaW9tbXVfYWxsb2Nfcm9vdChzdHJ1Y3QgZG9t YWluICpkKTsKIGludCBhbWRfaW9tbXVfcmVzZXJ2ZV9kb21haW5fdW5pdHlf bWFwKHN0cnVjdCBkb21haW4gKmRvbWFpbiwKLSAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIHBhZGRyX3QgcGh5c19hZGRyLCB1bnNp Z25lZCBsb25nIHNpemUsCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICBpbnQgaXcsIGludCBpcik7CisgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICBjb25zdCBzdHJ1Y3QgaXZyc191bml0 eV9tYXAgKm1hcCwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIHVuc2lnbmVkIGludCBmbGFnKTsKK2ludCBhbWRfaW9tbXVfcmVz ZXJ2ZV9kb21haW5fdW5pdHlfdW5tYXAoc3RydWN0IGRvbWFpbiAqZCwKKyAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgY29uc3Qg c3RydWN0IGl2cnNfdW5pdHlfbWFwICptYXApOwogaW50IF9fbXVzdF9jaGVj ayBhbWRfaW9tbXVfZmx1c2hfaW90bGJfcGFnZXMoc3RydWN0IGRvbWFpbiAq ZCwgZGZuX3QgZGZuLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgdW5zaWduZWQgbG9uZyBwYWdlX2NvdW50LAogICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdW5z aWduZWQgaW50IGZsdXNoX2ZsYWdzKTsKLS0tIGEveGVuL2RyaXZlcnMvcGFz c3Rocm91Z2gvYW1kL2lvbW11X21hcC5jCisrKyBiL3hlbi9kcml2ZXJzL3Bh c3N0aHJvdWdoL2FtZC9pb21tdV9tYXAuYwpAQCAtNDE5LDM4ICs0MTksNDkg QEAgaW50IGFtZF9pb21tdV9mbHVzaF9pb3RsYl9hbGwoc3RydWN0IGRvbQog ICAgIHJldHVybiAwOwogfQogCi1pbnQgYW1kX2lvbW11X3Jlc2VydmVfZG9t YWluX3VuaXR5X21hcChzdHJ1Y3QgZG9tYWluICpkb21haW4sCi0gICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBwYWRkcl90IHBoeXNf YWRkciwKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IHVuc2lnbmVkIGxvbmcgc2l6ZSwgaW50IGl3LCBpbnQgaXIpCitpbnQgYW1k X2lvbW11X3Jlc2VydmVfZG9tYWluX3VuaXR5X21hcChzdHJ1Y3QgZG9tYWlu ICpkLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg Y29uc3Qgc3RydWN0IGl2cnNfdW5pdHlfbWFwICptYXAsCisgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICB1bnNpZ25lZCBpbnQgZmxh ZykKIHsKLSAgICB1bnNpZ25lZCBsb25nIG5wYWdlcywgaTsKLSAgICB1bnNp Z25lZCBsb25nIGdmbjsKLSAgICB1bnNpZ25lZCBpbnQgZmxhZ3MgPSAhIWly OwotICAgIHVuc2lnbmVkIGludCBmbHVzaF9mbGFncyA9IDA7Ci0gICAgaW50 IHJ0ID0gMDsKLQotICAgIGlmICggaXcgKQotICAgICAgICBmbGFncyB8PSBJ T01NVUZfd3JpdGFibGU7Ci0KLSAgICBucGFnZXMgPSByZWdpb25fdG9fcGFn ZXMocGh5c19hZGRyLCBzaXplKTsKLSAgICBnZm4gPSBwaHlzX2FkZHIgPj4g UEFHRV9TSElGVDsKLSAgICBmb3IgKCBpID0gMDsgaSA8IG5wYWdlczsgaSsr ICkKKyAgICBpbnQgcmM7CisKKyAgICBpZiAoIGQgPT0gZG9tX2lvICkKKyAg ICAgICAgcmV0dXJuIDA7CisKKyAgICBmb3IgKCByYyA9IDA7ICFyYyAmJiBt YXA7IG1hcCA9IG1hcC0+bmV4dCApCiAgICAgewotICAgICAgICB1bnNpZ25l ZCBsb25nIGZyYW1lID0gZ2ZuICsgaTsKKyAgICAgICAgcDJtX2FjY2Vzc190 IHAybWEgPSBwMm1fYWNjZXNzX247CisKKyAgICAgICAgaWYgKCBtYXAtPnJl YWQgKQorICAgICAgICAgICAgcDJtYSB8PSBwMm1fYWNjZXNzX3I7CisgICAg ICAgIGlmICggbWFwLT53cml0ZSApCisgICAgICAgICAgICBwMm1hIHw9IHAy bV9hY2Nlc3NfdzsKIAotICAgICAgICBydCA9IGFtZF9pb21tdV9tYXBfcGFn ZShkb21haW4sIF9kZm4oZnJhbWUpLCBfbWZuKGZyYW1lKSwgZmxhZ3MsCi0g ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICZmbHVzaF9mbGFncyk7 Ci0gICAgICAgIGlmICggcnQgIT0gMCApCi0gICAgICAgICAgICBicmVhazsK KyAgICAgICAgcmMgPSBpb21tdV9pZGVudGl0eV9tYXBwaW5nKGQsIHAybWEs IG1hcC0+YWRkciwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIG1hcC0+YWRkciArIG1hcC0+bGVuZ3RoIC0gMSwgZmxhZyk7CiAgICAg fQogCi0gICAgLyogVXNlIHdoaWxlLWJyZWFrIHRvIGF2b2lkIGNvbXBpbGVy IHdhcm5pbmcgKi8KLSAgICB3aGlsZSAoIGZsdXNoX2ZsYWdzICYmCi0gICAg ICAgICAgICBhbWRfaW9tbXVfZmx1c2hfaW90bGJfcGFnZXMoZG9tYWluLCBf ZGZuKGdmbiksCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgbnBhZ2VzLCBmbHVzaF9mbGFncykgKQotICAgICAgICBicmVhazsK KyAgICByZXR1cm4gcmM7Cit9CisKK2ludCBhbWRfaW9tbXVfcmVzZXJ2ZV9k b21haW5fdW5pdHlfdW5tYXAoc3RydWN0IGRvbWFpbiAqZCwKKyAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgY29uc3Qgc3RydWN0 IGl2cnNfdW5pdHlfbWFwICptYXApCit7CisgICAgaW50IHJjOworCisgICAg aWYgKCBkID09IGRvbV9pbyApCisgICAgICAgIHJldHVybiAwOworCisgICAg Zm9yICggcmMgPSAwOyBtYXA7IG1hcCA9IG1hcC0+bmV4dCApCisgICAgewor ICAgICAgICBpbnQgcmV0ID0gaW9tbXVfaWRlbnRpdHlfbWFwcGluZyhkLCBw Mm1fYWNjZXNzX3gsIG1hcC0+YWRkciwKKyAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgbWFwLT5hZGRyICsgbWFwLT5sZW5ndGgg LSAxLCAwKTsKKworICAgICAgICBpZiAoIHJldCAmJiByZXQgIT0gLUVOT0VO VCAmJiAhcmMgKQorICAgICAgICAgICAgcmMgPSByZXQ7CisgICAgfQogCi0g ICAgcmV0dXJuIHJ0OworICAgIHJldHVybiByYzsKIH0KIAogaW50IF9faW5p dCBhbWRfaW9tbXVfcXVhcmFudGluZV9pbml0KHN0cnVjdCBkb21haW4gKmQp Ci0tLSBhL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL2FtZC9wY2lfYW1kX2lv bW11LmMKKysrIGIveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvYW1kL3BjaV9h bWRfaW9tbXUuYwpAQCAtMzI5LDYgKzMyOSw3IEBAIHN0YXRpYyBpbnQgcmVh c3NpZ25fZGV2aWNlKHN0cnVjdCBkb21haW4KIHsKICAgICBzdHJ1Y3QgYW1k X2lvbW11ICppb21tdTsKICAgICBpbnQgYmRmLCByYzsKKyAgICBjb25zdCBz dHJ1Y3QgaXZyc19tYXBwaW5ncyAqaXZyc19tYXBwaW5ncyA9IGdldF9pdnJz X21hcHBpbmdzKHBkZXYtPnNlZyk7CiAKICAgICBiZGYgPSBQQ0lfQkRGMihw ZGV2LT5idXMsIHBkZXYtPmRldmZuKTsKICAgICBpb21tdSA9IGZpbmRfaW9t bXVfZm9yX2RldmljZShwZGV2LT5zZWcsIGJkZik7CkBAIC0zNDMsMTAgKzM0 NCwyNCBAQCBzdGF0aWMgaW50IHJlYXNzaWduX2RldmljZShzdHJ1Y3QgZG9t YWluCiAKICAgICBhbWRfaW9tbXVfZGlzYWJsZV9kb21haW5fZGV2aWNlKHNv dXJjZSwgaW9tbXUsIGRldmZuLCBwZGV2KTsKIAotICAgIGlmICggZGV2Zm4g PT0gcGRldi0+ZGV2Zm4gKQorICAgIC8qCisgICAgICogSWYgdGhlIGRldmlj ZSBiZWxvbmdzIHRvIHRoZSBoYXJkd2FyZSBkb21haW4sIGFuZCBpdCBoYXMg YSB1bml0eSBtYXBwaW5nLAorICAgICAqIGRvbid0IHJlbW92ZSBpdCBmcm9t IHRoZSBoYXJkd2FyZSBkb21haW4sIGJlY2F1c2UgQklPUyBtYXkgcmVmZXJl bmNlIHRoYXQKKyAgICAgKiBtYXBwaW5nLgorICAgICAqLworICAgIGlmICgg IWlzX2hhcmR3YXJlX2RvbWFpbihzb3VyY2UpICkKICAgICB7Ci0gICAgICAg IGxpc3RfbW92ZSgmcGRldi0+ZG9tYWluX2xpc3QsICZ0YXJnZXQtPnBkZXZf bGlzdCk7Ci0gICAgICAgIHBkZXYtPmRvbWFpbiA9IHRhcmdldDsKKyAgICAg ICAgcmMgPSBhbWRfaW9tbXVfcmVzZXJ2ZV9kb21haW5fdW5pdHlfdW5tYXAo CisgICAgICAgICAgICAgICAgIHNvdXJjZSwKKyAgICAgICAgICAgICAgICAg aXZyc19tYXBwaW5nc1tnZXRfZG1hX3JlcXVlc3Rvcl9pZChwZGV2LT5zZWcs IGJkZildLnVuaXR5X21hcCk7CisgICAgICAgIGlmICggcmMgKQorICAgICAg ICAgICAgcmV0dXJuIHJjOworICAgIH0KKworICAgIGlmICggZGV2Zm4gPT0g cGRldi0+ZGV2Zm4gJiYgcGRldi0+ZG9tYWluICE9IGRvbV9pbyApCisgICAg eworICAgICAgICBsaXN0X21vdmUoJnBkZXYtPmRvbWFpbl9saXN0LCAmZG9t X2lvLT5wZGV2X2xpc3QpOworICAgICAgICBwZGV2LT5kb21haW4gPSBkb21f aW87CiAgICAgfQogCiAgICAgcmMgPSBhbGxvY2F0ZV9kb21haW5fcmVzb3Vy Y2VzKHRhcmdldCk7CkBAIC0zNTcsNiArMzcyLDEyIEBAIHN0YXRpYyBpbnQg cmVhc3NpZ25fZGV2aWNlKHN0cnVjdCBkb21haW4KICAgICBBTURfSU9NTVVf REVCVUcoIlJlLWFzc2lnbiAlcHAgZnJvbSBkb20lZCB0byBkb20lZFxuIiwK ICAgICAgICAgICAgICAgICAgICAgJnBkZXYtPnNiZGYsIHNvdXJjZS0+ZG9t YWluX2lkLCB0YXJnZXQtPmRvbWFpbl9pZCk7CiAKKyAgICBpZiAoIGRldmZu ID09IHBkZXYtPmRldmZuICYmIHBkZXYtPmRvbWFpbiAhPSB0YXJnZXQgKQor ICAgIHsKKyAgICAgICAgbGlzdF9tb3ZlKCZwZGV2LT5kb21haW5fbGlzdCwg JnRhcmdldC0+cGRldl9saXN0KTsKKyAgICAgICAgcGRldi0+ZG9tYWluID0g dGFyZ2V0OworICAgIH0KKwogICAgIHJldHVybiAwOwogfQogCkBAIC0zNjcs MjAgKzM4OCwyOCBAQCBzdGF0aWMgaW50IGFtZF9pb21tdV9hc3NpZ25fZGV2 aWNlKHN0cnVjCiAgICAgc3RydWN0IGl2cnNfbWFwcGluZ3MgKml2cnNfbWFw cGluZ3MgPSBnZXRfaXZyc19tYXBwaW5ncyhwZGV2LT5zZWcpOwogICAgIGlu dCBiZGYgPSBQQ0lfQkRGMihwZGV2LT5idXMsIGRldmZuKTsKICAgICBpbnQg cmVxX2lkID0gZ2V0X2RtYV9yZXF1ZXN0b3JfaWQocGRldi0+c2VnLCBiZGYp OwotICAgIGNvbnN0IHN0cnVjdCBpdnJzX3VuaXR5X21hcCAqdW5pdHlfbWFw OworICAgIGludCByYyA9IGFtZF9pb21tdV9yZXNlcnZlX2RvbWFpbl91bml0 eV9tYXAoCisgICAgICAgICAgICAgICAgIGQsIGl2cnNfbWFwcGluZ3NbcmVx X2lkXS51bml0eV9tYXAsIGZsYWcpOwogCi0gICAgZm9yICggdW5pdHlfbWFw ID0gaXZyc19tYXBwaW5nc1tyZXFfaWRdLnVuaXR5X21hcDsgdW5pdHlfbWFw OwotICAgICAgICAgIHVuaXR5X21hcCA9IHVuaXR5X21hcC0+bmV4dCApCisg ICAgaWYgKCAhcmMgKQorICAgICAgICByYyA9IHJlYXNzaWduX2RldmljZShw ZGV2LT5kb21haW4sIGQsIGRldmZuLCBwZGV2KTsKKworICAgIGlmICggcmMg JiYgIWlzX2hhcmR3YXJlX2RvbWFpbihkKSApCiAgICAgewotICAgICAgICBp bnQgcmMgPSBhbWRfaW9tbXVfcmVzZXJ2ZV9kb21haW5fdW5pdHlfbWFwKAot ICAgICAgICAgICAgICAgICAgICAgZCwgdW5pdHlfbWFwLT5hZGRyLCB1bml0 eV9tYXAtPmxlbmd0aCwKLSAgICAgICAgICAgICAgICAgICAgIHVuaXR5X21h cC0+d3JpdGUsIHVuaXR5X21hcC0+cmVhZCk7CisgICAgICAgIGludCByZXQg PSBhbWRfaW9tbXVfcmVzZXJ2ZV9kb21haW5fdW5pdHlfdW5tYXAoCisgICAg ICAgICAgICAgICAgICAgICAgZCwgaXZyc19tYXBwaW5nc1tyZXFfaWRdLnVu aXR5X21hcCk7CiAKLSAgICAgICAgaWYgKCByYyApCi0gICAgICAgICAgICBy ZXR1cm4gcmM7CisgICAgICAgIGlmICggcmV0ICkKKyAgICAgICAgeworICAg ICAgICAgICAgcHJpbnRrKFhFTkxPR19FUlIgIkFNRC1WaTogIgorICAgICAg ICAgICAgICAgICAgICJ1bml0eS11bm1hcCBmb3IgJXBkLyUwNHg6JTAyeDol MDJ4LiV1IGZhaWxlZCAoJWQpXG4iLAorICAgICAgICAgICAgICAgICAgIGQs IHBkZXYtPnNlZywgcGRldi0+YnVzLAorICAgICAgICAgICAgICAgICAgIFBD SV9TTE9UKGRldmZuKSwgUENJX0ZVTkMoZGV2Zm4pLCByZXQpOworICAgICAg ICAgICAgZG9tYWluX2NyYXNoKGQpOworICAgICAgICB9CiAgICAgfQogCi0g ICAgcmV0dXJuIHJlYXNzaWduX2RldmljZShwZGV2LT5kb21haW4sIGQsIGRl dmZuLCBwZGV2KTsKKyAgICByZXR1cm4gcmM7CiB9CiAKIHN0YXRpYyB2b2lk IGFtZF9pb21tdV9jbGVhcl9yb290X3BndGFibGUoc3RydWN0IGRvbWFpbiAq ZCkKQEAgLTM5NCw2ICs0MjMsNyBAQCBzdGF0aWMgdm9pZCBhbWRfaW9tbXVf Y2xlYXJfcm9vdF9wZ3RhYmxlCiAKIHN0YXRpYyB2b2lkIGFtZF9pb21tdV9k b21haW5fZGVzdHJveShzdHJ1Y3QgZG9tYWluICpkKQogeworICAgIGlvbW11 X2lkZW50aXR5X21hcF90ZWFyZG93bihkKTsKICAgICBBU1NFUlQoIWRvbV9p b21tdShkKS0+YXJjaC5hbWQucm9vdF90YWJsZSk7CiB9CiAK --=separator Content-Type: application/octet-stream; name="xsa378/xsa378-4.15-6.patch" Content-Disposition: attachment; filename="xsa378/xsa378-4.15-6.patch" Content-Transfer-Encoding: base64 RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0 OiBBTUQvSU9NTVU6IHJlLWFycmFuZ2UgZXhjbHVzaW9uIHJhbmdlIGFuZCB1 bml0eSBtYXAgcmVjb3JkaW5nCgpUaGUgc3BlYyBtYWtlcyBubyBwcm92aXNp b25zIGZvciBPUyBiZWhhdmlvciBoZXJlIHRvIGRlcGVuZCBvbiB0aGUKYW1v dW50IG9mIFJBTSBmb3VuZCBvbiB0aGUgc3lzdGVtLiBXaGlsZSB0aGUgc3Bl YyBtYXkgbm90IHN1ZmZpY2llbnRseQpjbGVhcmx5IGRpc3Rpbmd1aXNoIGJv dGgga2luZHMgb2YgcmVnaW9ucywgdGhleSBhcmUgc3VyZWx5IG1lYW50IHRv IGJlCnNlcGFyYXRlIHRoaW5nczogT25seSByZWdpb25zIHdpdGggQUNQSV9J Vk1EX0VYQ0xVU0lPTl9SQU5HRSBzZXQgc2hvdWxkCmJlIGNhbmRpZGF0ZXMg Zm9yIHB1dHRpbmcgaW4gdGhlIGV4Y2x1c2lvbiByYW5nZSByZWdpc3RlcnMu IChBcyB0aGVyZSdzCm9ubHkgYSBzaW5nbGUgc3VjaCBwYWlyIG9mIHJlZ2lz dGVycyBwZXIgSU9NTVUsIHNlY29uZGFyeSBub24tYWRqYWNlbnQKcmVnaW9u cyB3aXRoIHRoZSBmbGFnIHNldCBhbHJlYWR5IGdldCBjb252ZXJ0ZWQgdG8g dW5pdHkgbWFwcGVkCnJlZ2lvbnMuKQoKRmlyc3Qgb2YgYWxsLCBkcm9wIHRo ZSBkZXBlbmRlbmN5IG9uIG1heF9wYWdlLiBXaXRoIGNvbW1pdCBiNGYwNDIy MzZhZTAKKCJBTUQvSU9NTVU6IENlYXNlIHVzaW5nIGEgZHluYW1pYyBoZWln aHQgZm9yIHRoZSBJT01NVSBwYWdldGFibGVzIikgdGhlCnVzZSBvZiBpdCBo ZXJlIHdhcyBzdGFsZSBhbnl3YXk7IGl0IHdhcyBib2d1cyBhbHJlYWR5IGJl Zm9yZSwgYXMgaXQKZGlkbid0IGFjY291bnQgZm9yIG1heF9wYWdlIGdldHRp bmcgaW5jcmVhc2VkIGxhdGVyIG9uLiBTaW1wbHkgdHJ5IGFuCmV4Y2x1c2lv biByYW5nZSByZWdpc3RyYXRpb24gZmlyc3QsIGFuZCBpZiBpdCBmYWlscyAo Zm9yIGJlaW5nCnVuc3VpdGFibGUgb3Igbm9uLW1lcmdlYWJsZSksIHJlZ2lz dGVyIGEgdW5pdHkgbWFwcGluZyByYW5nZS4KCldpdGggdGhpcyB2YXJpb3Vz IGxvY2FsIHZhcmlhYmxlcyBiZWNvbWUgdW5uZWNlc3NhcnkgYW5kIGhlbmNl IGdldApkcm9wcGVkIGF0IHRoZSBzYW1lIHRpbWUuCgpXaXRoIHRoZSBtYXhf cGFnZSBib3VuZGFyeSBkcm9wcGVkIGZvciB1c2luZyB1bml0eSBtYXBzLCB0 aGUgbWluaW11bQpwYWdlIHRhYmxlIHRyZWUgaGVpZ2h0IG5vdyBuZWVkcyBi b3RoIHJlY29yZGluZyBhbmQgZW5mb3JjaW5nIGluCmFtZF9pb21tdV9kb21h aW5faW5pdCgpLiBTaW5jZSB3ZSBjYW4ndCBwcmVkaWN0IHdoaWNoIGRldmlj ZXMgbWF5IGdldAphc3NpZ25lZCB0byBhIGRvbWFpbiwgb3VyIG9ubHkgb3B0 aW9uIGlzIHRvIHVuaWZvcm1seSBmb3JjZSBhdCBsZWFzdAp0aGF0IGhlaWdo dCBmb3IgYWxsIGRvbWFpbnMsIG5vdyB0aGF0IHRoZSBoZWlnaHQgaXNuJ3Qg ZHluYW1pYyBhbnltb3JlLgoKRnVydGhlciBkb24ndCBtYWtlIHVzZSBvZiB0 aGUgZXhjbHVzaW9uIHJhbmdlIHVubGVzcyBBQ1BJIGRhdGEgc2F5cyBzby4K Ck5vdGUgdGhhdCBleGNsdXNpb24gcmFuZ2UgcmVnaXN0cmF0aW9uIGluCnJl Z2lzdGVyX3JhbmdlX2Zvcl9hbGxfZGV2aWNlcygpIGlzIG9uIGEgYmVzdCBl ZmZvcnQgYmFzaXMuIEhlbmNlIHVuaXR5Cm1hcCBlbnRyaWVzIGFsc28gcmVn aXN0ZXJlZCBhcmUgcmVkdW5kYW50IHdoZW4gdGhlIGZvcm1lciBzdWNjZWVk ZWQsIGJ1dAp0aGV5IGFsc28gZG8gbm8gaGFybS4gSW1wcm92ZW1lbnRzIGlu IHRoaXMgYXJlYSBjYW4gYmUgZG9uZSBsYXRlciBpbW8uCgpBbHNvIGFkanVz dCB0eXBlcyB3aGVyZSBzdWl0YWJsZSB3aXRob3V0IHRvdWNoaW5nIGV4dHJh IGxpbmVzLgoKVGhpcyBpcyBwYXJ0IG9mIFhTQS0zNzguCgpTaWduZWQtb2Zm LWJ5OiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+ClJldmlld2Vk LWJ5OiBQYXVsIER1cnJhbnQgPHBhdWxAeGVuLm9yZz4KCi0tLSBhL3hlbi9k cml2ZXJzL3Bhc3N0aHJvdWdoL2FtZC9pb21tdS5oCisrKyBiL3hlbi9kcml2 ZXJzL3Bhc3N0aHJvdWdoL2FtZC9pb21tdS5oCkBAIC0zMDQsNiArMzA0LDgg QEAgZXh0ZXJuIHN0cnVjdCBocGV0X3NiZGYgewogICAgIH0gaW5pdDsKIH0g aHBldF9zYmRmOwogCitleHRlcm4gaW50IGFtZF9pb21tdV9taW5fcGFnaW5n X21vZGU7CisKIGV4dGVybiB2b2lkICpzaGFyZWRfaW50cmVtYXBfdGFibGU7 CiBleHRlcm4gdW5zaWduZWQgbG9uZyAqc2hhcmVkX2ludHJlbWFwX2ludXNl OwogCi0tLSBhL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL2FtZC9pb21tdV9h Y3BpLmMKKysrIGIveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvYW1kL2lvbW11 X2FjcGkuYwpAQCAtMTE3LDEyICsxMTcsOCBAQCBzdGF0aWMgc3RydWN0IGFt ZF9pb21tdSAqIF9faW5pdCBmaW5kX2lvCiB9CiAKIHN0YXRpYyBpbnQgX19p bml0IHJlc2VydmVfaW9tbXVfZXhjbHVzaW9uX3JhbmdlKAotICAgIHN0cnVj dCBhbWRfaW9tbXUgKmlvbW11LCB1aW50NjRfdCBiYXNlLCB1aW50NjRfdCBs aW1pdCwKLSAgICBib29sIGFsbCwgYm9vbCBpdywgYm9vbCBpcikKKyAgICBz dHJ1Y3QgYW1kX2lvbW11ICppb21tdSwgcGFkZHJfdCBiYXNlLCBwYWRkcl90 IGxpbWl0LCBib29sIGFsbCkKIHsKLSAgICBpZiAoICFpciB8fCAhaXcgKQot ICAgICAgICByZXR1cm4gLUVQRVJNOwotCiAgICAgLyogbmVlZCB0byBleHRl bmQgZXhjbHVzaW9uIHJhbmdlPyAqLwogICAgIGlmICggaW9tbXUtPmV4Y2x1 c2lvbl9lbmFibGUgKQogICAgIHsKQEAgLTE1MSwxNCArMTQ3LDE4IEBAIHN0 YXRpYyBpbnQgX19pbml0IHJlc2VydmVfdW5pdHlfbWFwX2Zvcl8KIHsKICAg ICBzdHJ1Y3QgaXZyc19tYXBwaW5ncyAqaXZyc19tYXBwaW5ncyA9IGdldF9p dnJzX21hcHBpbmdzKHNlZyk7CiAgICAgc3RydWN0IGl2cnNfdW5pdHlfbWFw ICp1bml0eV9tYXAgPSBpdnJzX21hcHBpbmdzW2JkZl0udW5pdHlfbWFwOwor ICAgIGludCBwYWdpbmdfbW9kZSA9IGFtZF9pb21tdV9nZXRfcGFnaW5nX21v ZGUoUEZOX1VQKGJhc2UgKyBsZW5ndGgpKTsKKworICAgIGlmICggcGFnaW5n X21vZGUgPCAwICkKKyAgICAgICAgcmV0dXJuIHBhZ2luZ19tb2RlOwogCiAg ICAgLyogQ2hlY2sgZm9yIG92ZXJsYXBzLiAqLwogICAgIGZvciAoIDsgdW5p dHlfbWFwOyB1bml0eV9tYXAgPSB1bml0eV9tYXAtPm5leHQgKQogICAgIHsK ICAgICAgICAgLyoKICAgICAgICAgICogRXhhY3QgbWF0Y2hlcyBhcmUgb2th eS4gVGhpcyBjYW4gaW4gcGFydGljdWxhciBoYXBwZW4gd2hlbgotICAgICAg ICAgKiByZWdpc3Rlcl9leGNsdXNpb25fcmFuZ2VfZm9yX2RldmljZSgpIGNh bGxzIGhlcmUgdHdpY2UgZm9yIHRoZQotICAgICAgICAgKiBzYW1lIChzLGIs ZCxmKS4KKyAgICAgICAgICogcmVnaXN0ZXJfcmFuZ2VfZm9yX2RldmljZSgp IGNhbGxzIGhlcmUgdHdpY2UgZm9yIHRoZSBzYW1lCisgICAgICAgICAqIChz LGIsZCxmKS4KICAgICAgICAgICovCiAgICAgICAgIGlmICggYmFzZSA9PSB1 bml0eV9tYXAtPmFkZHIgJiYgbGVuZ3RoID09IHVuaXR5X21hcC0+bGVuZ3Ro ICYmCiAgICAgICAgICAgICAgaXIgPT0gdW5pdHlfbWFwLT5yZWFkICYmIGl3 ID09IHVuaXR5X21hcC0+d3JpdGUgKQpAQCAtMTg2LDU1ICsxODYsNTIgQEAg c3RhdGljIGludCBfX2luaXQgcmVzZXJ2ZV91bml0eV9tYXBfZm9yXwogICAg IHVuaXR5X21hcC0+bmV4dCA9IGl2cnNfbWFwcGluZ3NbYmRmXS51bml0eV9t YXA7CiAgICAgaXZyc19tYXBwaW5nc1tiZGZdLnVuaXR5X21hcCA9IHVuaXR5 X21hcDsKIAorICAgIGlmICggcGFnaW5nX21vZGUgPiBhbWRfaW9tbXVfbWlu X3BhZ2luZ19tb2RlICkKKyAgICAgICAgYW1kX2lvbW11X21pbl9wYWdpbmdf bW9kZSA9IHBhZ2luZ19tb2RlOworCiAgICAgcmV0dXJuIDA7CiB9CiAKLXN0 YXRpYyBpbnQgX19pbml0IHJlZ2lzdGVyX2V4Y2x1c2lvbl9yYW5nZV9mb3Jf YWxsX2RldmljZXMoCi0gICAgdW5zaWduZWQgbG9uZyBiYXNlLCB1bnNpZ25l ZCBsb25nIGxpbWl0LCB1OCBpdywgdTggaXIpCitzdGF0aWMgaW50IF9faW5p dCByZWdpc3Rlcl9yYW5nZV9mb3JfYWxsX2RldmljZXMoCisgICAgcGFkZHJf dCBiYXNlLCBwYWRkcl90IGxpbWl0LCBib29sIGl3LCBib29sIGlyLCBib29s IGV4Y2x1c2lvbikKIHsKICAgICBpbnQgc2VnID0gMDsgLyogWFhYICovCi0g ICAgdW5zaWduZWQgbG9uZyByYW5nZV90b3AsIGlvbW11X3RvcCwgbGVuZ3Ro OwogICAgIHN0cnVjdCBhbWRfaW9tbXUgKmlvbW11OwotICAgIHVuc2lnbmVk IGludCBiZGY7CiAgICAgaW50IHJjID0gMDsKIAogICAgIC8qIGlzIHBhcnQg b2YgZXhjbHVzaW9uIHJhbmdlIGluc2lkZSBvZiBJT01NVSB2aXJ0dWFsIGFk ZHJlc3Mgc3BhY2U/ICovCiAgICAgLyogbm90ZTogJ2xpbWl0JyBwYXJhbWV0 ZXIgaXMgYXNzdW1lZCB0byBiZSBwYWdlLWFsaWduZWQgKi8KLSAgICByYW5n ZV90b3AgPSBsaW1pdCArIFBBR0VfU0laRTsKLSAgICBpb21tdV90b3AgPSBt YXhfcGFnZSAqIFBBR0VfU0laRTsKLSAgICBpZiAoIGJhc2UgPCBpb21tdV90 b3AgKQotICAgIHsKLSAgICAgICAgaWYgKCByYW5nZV90b3AgPiBpb21tdV90 b3AgKQotICAgICAgICAgICAgcmFuZ2VfdG9wID0gaW9tbXVfdG9wOwotICAg ICAgICBsZW5ndGggPSByYW5nZV90b3AgLSBiYXNlOwotICAgICAgICAvKiBy ZXNlcnZlIHIvdyB1bml0eS1tYXBwZWQgcGFnZSBlbnRyaWVzIGZvciBkZXZp Y2VzICovCi0gICAgICAgIC8qIG5vdGU6IHRoZXNlIGVudHJpZXMgYXJlIHBh cnQgb2YgdGhlIGV4Y2x1c2lvbiByYW5nZSAqLwotICAgICAgICBmb3IgKCBi ZGYgPSAwOyAhcmMgJiYgYmRmIDwgaXZyc19iZGZfZW50cmllczsgYmRmKysg KQotICAgICAgICAgICAgcmMgPSByZXNlcnZlX3VuaXR5X21hcF9mb3JfZGV2 aWNlKHNlZywgYmRmLCBiYXNlLCBsZW5ndGgsIGl3LCBpcik7Ci0gICAgICAg IC8qIHB1c2ggJ2Jhc2UnIGp1c3Qgb3V0c2lkZSBvZiB2aXJ0dWFsIGFkZHJl c3Mgc3BhY2UgKi8KLSAgICAgICAgYmFzZSA9IGlvbW11X3RvcDsKLSAgICB9 Ci0gICAgLyogcmVnaXN0ZXIgSU9NTVUgZXhjbHVzaW9uIHJhbmdlIHNldHRp bmdzICovCi0gICAgaWYgKCAhcmMgJiYgbGltaXQgPj0gaW9tbXVfdG9wICkK KyAgICBpZiAoIGV4Y2x1c2lvbiApCiAgICAgewogICAgICAgICBmb3JfZWFj aF9hbWRfaW9tbXUoIGlvbW11ICkKICAgICAgICAgewotICAgICAgICAgICAg cmMgPSByZXNlcnZlX2lvbW11X2V4Y2x1c2lvbl9yYW5nZShpb21tdSwgYmFz ZSwgbGltaXQsCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIHRydWUgLyogYWxsICovLCBpdywgaXIpOwotICAgICAg ICAgICAgaWYgKCByYyApCi0gICAgICAgICAgICAgICAgYnJlYWs7CisgICAg ICAgICAgICBpbnQgcmV0ID0gcmVzZXJ2ZV9pb21tdV9leGNsdXNpb25fcmFu Z2UoaW9tbXUsIGJhc2UsIGxpbWl0LAorICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHRydWUgLyogYWxsICov KTsKKworICAgICAgICAgICAgaWYgKCByZXQgJiYgIXJjICkKKyAgICAgICAg ICAgICAgICByYyA9IHJldDsKICAgICAgICAgfQogICAgIH0KIAorICAgIGlm ICggIWV4Y2x1c2lvbiB8fCByYyApCisgICAgeworICAgICAgICBwYWRkcl90 IGxlbmd0aCA9IGxpbWl0ICsgUEFHRV9TSVpFIC0gYmFzZTsKKyAgICAgICAg dW5zaWduZWQgaW50IGJkZjsKKworICAgICAgICAvKiByZXNlcnZlIHIvdyB1 bml0eS1tYXBwZWQgcGFnZSBlbnRyaWVzIGZvciBkZXZpY2VzICovCisgICAg ICAgIGZvciAoIGJkZiA9IHJjID0gMDsgIXJjICYmIGJkZiA8IGl2cnNfYmRm X2VudHJpZXM7IGJkZisrICkKKyAgICAgICAgICAgIHJjID0gcmVzZXJ2ZV91 bml0eV9tYXBfZm9yX2RldmljZShzZWcsIGJkZiwgYmFzZSwgbGVuZ3RoLCBp dywgaXIpOworICAgIH0KKwogICAgIHJldHVybiByYzsKIH0KIAotc3RhdGlj IGludCBfX2luaXQgcmVnaXN0ZXJfZXhjbHVzaW9uX3JhbmdlX2Zvcl9kZXZp Y2UoCi0gICAgdTE2IGJkZiwgdW5zaWduZWQgbG9uZyBiYXNlLCB1bnNpZ25l ZCBsb25nIGxpbWl0LCB1OCBpdywgdTggaXIpCitzdGF0aWMgaW50IF9faW5p dCByZWdpc3Rlcl9yYW5nZV9mb3JfZGV2aWNlKAorICAgIHVuc2lnbmVkIGlu dCBiZGYsIHBhZGRyX3QgYmFzZSwgcGFkZHJfdCBsaW1pdCwKKyAgICBib29s IGl3LCBib29sIGlyLCBib29sIGV4Y2x1c2lvbikKIHsKICAgICBpbnQgc2Vn ID0gMDsgLyogWFhYICovCiAgICAgc3RydWN0IGl2cnNfbWFwcGluZ3MgKml2 cnNfbWFwcGluZ3MgPSBnZXRfaXZyc19tYXBwaW5ncyhzZWcpOwotICAgIHVu c2lnbmVkIGxvbmcgcmFuZ2VfdG9wLCBpb21tdV90b3AsIGxlbmd0aDsKICAg ICBzdHJ1Y3QgYW1kX2lvbW11ICppb21tdTsKICAgICB1MTYgcmVxOwogICAg IGludCByYyA9IDA7CkBAIC0yNDgsMjcgKzI0NSwxOSBAQCBzdGF0aWMgaW50 IF9faW5pdCByZWdpc3Rlcl9leGNsdXNpb25fcmFuCiAgICAgcmVxID0gaXZy c19tYXBwaW5nc1tiZGZdLmR0ZV9yZXF1ZXN0b3JfaWQ7CiAKICAgICAvKiBu b3RlOiAnbGltaXQnIHBhcmFtZXRlciBpcyBhc3N1bWVkIHRvIGJlIHBhZ2Ut YWxpZ25lZCAqLwotICAgIHJhbmdlX3RvcCA9IGxpbWl0ICsgUEFHRV9TSVpF OwotICAgIGlvbW11X3RvcCA9IG1heF9wYWdlICogUEFHRV9TSVpFOwotICAg IGlmICggYmFzZSA8IGlvbW11X3RvcCApCi0gICAgewotICAgICAgICBpZiAo IHJhbmdlX3RvcCA+IGlvbW11X3RvcCApCi0gICAgICAgICAgICByYW5nZV90 b3AgPSBpb21tdV90b3A7Ci0gICAgICAgIGxlbmd0aCA9IHJhbmdlX3RvcCAt IGJhc2U7CisgICAgaWYgKCBleGNsdXNpb24gKQorICAgICAgICByYyA9IHJl c2VydmVfaW9tbXVfZXhjbHVzaW9uX3JhbmdlKGlvbW11LCBiYXNlLCBsaW1p dCwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBmYWxzZSAvKiBhbGwgKi8pOworICAgIGlmICggIWV4Y2x1c2lvbiB8fCBy YyApCisgICAgeworICAgICAgICBwYWRkcl90IGxlbmd0aCA9IGxpbWl0ICsg UEFHRV9TSVpFIC0gYmFzZTsKKwogICAgICAgICAvKiByZXNlcnZlIHVuaXR5 LW1hcHBlZCBwYWdlIGVudHJpZXMgZm9yIGRldmljZSAqLwotICAgICAgICAv KiBub3RlOiB0aGVzZSBlbnRyaWVzIGFyZSBwYXJ0IG9mIHRoZSBleGNsdXNp b24gcmFuZ2UgKi8KICAgICAgICAgcmMgPSByZXNlcnZlX3VuaXR5X21hcF9m b3JfZGV2aWNlKHNlZywgYmRmLCBiYXNlLCBsZW5ndGgsIGl3LCBpcikgPzoK ICAgICAgICAgICAgICByZXNlcnZlX3VuaXR5X21hcF9mb3JfZGV2aWNlKHNl ZywgcmVxLCBiYXNlLCBsZW5ndGgsIGl3LCBpcik7Ci0KLSAgICAgICAgLyog cHVzaCAnYmFzZScganVzdCBvdXRzaWRlIG9mIHZpcnR1YWwgYWRkcmVzcyBz cGFjZSAqLwotICAgICAgICBiYXNlID0gaW9tbXVfdG9wOwogICAgIH0KLQot ICAgIC8qIHJlZ2lzdGVyIElPTU1VIGV4Y2x1c2lvbiByYW5nZSBzZXR0aW5n cyBmb3IgZGV2aWNlICovCi0gICAgaWYgKCAhcmMgJiYgbGltaXQgPj0gaW9t bXVfdG9wICApCisgICAgZWxzZQogICAgIHsKLSAgICAgICAgcmMgPSByZXNl cnZlX2lvbW11X2V4Y2x1c2lvbl9yYW5nZShpb21tdSwgYmFzZSwgbGltaXQs Ci0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ZmFsc2UgLyogYWxsICovLCBpdywgaXIpOwogICAgICAgICBpdnJzX21hcHBp bmdzW2JkZl0uZHRlX2FsbG93X2V4Y2x1c2lvbiA9IHRydWU7CiAgICAgICAg IGl2cnNfbWFwcGluZ3NbcmVxXS5kdGVfYWxsb3dfZXhjbHVzaW9uID0gdHJ1 ZTsKICAgICB9CkBAIC0yNzYsNTMgKzI2NSw0MiBAQCBzdGF0aWMgaW50IF9f aW5pdCByZWdpc3Rlcl9leGNsdXNpb25fcmFuCiAgICAgcmV0dXJuIHJjOwog fQogCi1zdGF0aWMgaW50IF9faW5pdCByZWdpc3Rlcl9leGNsdXNpb25fcmFu Z2VfZm9yX2lvbW11X2RldmljZXMoCi0gICAgc3RydWN0IGFtZF9pb21tdSAq aW9tbXUsCi0gICAgdW5zaWduZWQgbG9uZyBiYXNlLCB1bnNpZ25lZCBsb25n IGxpbWl0LCB1OCBpdywgdTggaXIpCitzdGF0aWMgaW50IF9faW5pdCByZWdp c3Rlcl9yYW5nZV9mb3JfaW9tbXVfZGV2aWNlcygKKyAgICBzdHJ1Y3QgYW1k X2lvbW11ICppb21tdSwgcGFkZHJfdCBiYXNlLCBwYWRkcl90IGxpbWl0LAor ICAgIGJvb2wgaXcsIGJvb2wgaXIsIGJvb2wgZXhjbHVzaW9uKQogewotICAg IHVuc2lnbmVkIGxvbmcgcmFuZ2VfdG9wLCBpb21tdV90b3AsIGxlbmd0aDsK KyAgICAvKiBub3RlOiAnbGltaXQnIHBhcmFtZXRlciBpcyBhc3N1bWVkIHRv IGJlIHBhZ2UtYWxpZ25lZCAqLworICAgIHBhZGRyX3QgbGVuZ3RoID0gbGlt aXQgKyBQQUdFX1NJWkUgLSBiYXNlOwogICAgIHVuc2lnbmVkIGludCBiZGY7 CiAgICAgdTE2IHJlcTsKLSAgICBpbnQgcmMgPSAwOworICAgIGludCByYzsK IAotICAgIC8qIGlzIHBhcnQgb2YgZXhjbHVzaW9uIHJhbmdlIGluc2lkZSBv ZiBJT01NVSB2aXJ0dWFsIGFkZHJlc3Mgc3BhY2U/ICovCi0gICAgLyogbm90 ZTogJ2xpbWl0JyBwYXJhbWV0ZXIgaXMgYXNzdW1lZCB0byBiZSBwYWdlLWFs aWduZWQgKi8KLSAgICByYW5nZV90b3AgPSBsaW1pdCArIFBBR0VfU0laRTsK LSAgICBpb21tdV90b3AgPSBtYXhfcGFnZSAqIFBBR0VfU0laRTsKLSAgICBp ZiAoIGJhc2UgPCBpb21tdV90b3AgKQotICAgIHsKLSAgICAgICAgaWYgKCBy YW5nZV90b3AgPiBpb21tdV90b3AgKQotICAgICAgICAgICAgcmFuZ2VfdG9w ID0gaW9tbXVfdG9wOwotICAgICAgICBsZW5ndGggPSByYW5nZV90b3AgLSBi YXNlOwotICAgICAgICAvKiByZXNlcnZlIHIvdyB1bml0eS1tYXBwZWQgcGFn ZSBlbnRyaWVzIGZvciBkZXZpY2VzICovCi0gICAgICAgIC8qIG5vdGU6IHRo ZXNlIGVudHJpZXMgYXJlIHBhcnQgb2YgdGhlIGV4Y2x1c2lvbiByYW5nZSAq LwotICAgICAgICBmb3IgKCBiZGYgPSAwOyAhcmMgJiYgYmRmIDwgaXZyc19i ZGZfZW50cmllczsgYmRmKysgKQotICAgICAgICB7Ci0gICAgICAgICAgICBp ZiAoIGlvbW11ID09IGZpbmRfaW9tbXVfZm9yX2RldmljZShpb21tdS0+c2Vn LCBiZGYpICkKLSAgICAgICAgICAgIHsKLSAgICAgICAgICAgICAgICByZXEg PSBnZXRfaXZyc19tYXBwaW5ncyhpb21tdS0+c2VnKVtiZGZdLmR0ZV9yZXF1 ZXN0b3JfaWQ7Ci0gICAgICAgICAgICAgICAgcmMgPSByZXNlcnZlX3VuaXR5 X21hcF9mb3JfZGV2aWNlKGlvbW11LT5zZWcsIGJkZiwgYmFzZSwgbGVuZ3Ro LAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICBpdywgaXIpID86Ci0gICAgICAgICAgICAgICAgICAgICByZXNl cnZlX3VuaXR5X21hcF9mb3JfZGV2aWNlKGlvbW11LT5zZWcsIHJlcSwgYmFz ZSwgbGVuZ3RoLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBpdywgaXIpOwotICAgICAgICAgICAgfQotICAg ICAgICB9Ci0KLSAgICAgICAgLyogcHVzaCAnYmFzZScganVzdCBvdXRzaWRl IG9mIHZpcnR1YWwgYWRkcmVzcyBzcGFjZSAqLwotICAgICAgICBiYXNlID0g aW9tbXVfdG9wOworICAgIGlmICggZXhjbHVzaW9uICkKKyAgICB7CisgICAg ICAgIHJjID0gcmVzZXJ2ZV9pb21tdV9leGNsdXNpb25fcmFuZ2UoaW9tbXUs IGJhc2UsIGxpbWl0LCB0cnVlIC8qIGFsbCAqLyk7CisgICAgICAgIGlmICgg IXJjICkKKyAgICAgICAgICAgIHJldHVybiAwOwogICAgIH0KIAotICAgIC8q IHJlZ2lzdGVyIElPTU1VIGV4Y2x1c2lvbiByYW5nZSBzZXR0aW5ncyAqLwot ICAgIGlmICggIXJjICYmIGxpbWl0ID49IGlvbW11X3RvcCApCi0gICAgICAg IHJjID0gcmVzZXJ2ZV9pb21tdV9leGNsdXNpb25fcmFuZ2UoaW9tbXUsIGJh c2UsIGxpbWl0LAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIHRydWUgLyogYWxsICovLCBpdywgaXIpOworICAgIC8qIHJl c2VydmUgdW5pdHktbWFwcGVkIHBhZ2UgZW50cmllcyBmb3IgZGV2aWNlcyAq LworICAgIGZvciAoIGJkZiA9IHJjID0gMDsgIXJjICYmIGJkZiA8IGl2cnNf YmRmX2VudHJpZXM7IGJkZisrICkKKyAgICB7CisgICAgICAgIGlmICggaW9t bXUgIT0gZmluZF9pb21tdV9mb3JfZGV2aWNlKGlvbW11LT5zZWcsIGJkZikg KQorICAgICAgICAgICAgY29udGludWU7CisKKyAgICAgICAgcmVxID0gZ2V0 X2l2cnNfbWFwcGluZ3MoaW9tbXUtPnNlZylbYmRmXS5kdGVfcmVxdWVzdG9y X2lkOworICAgICAgICByYyA9IHJlc2VydmVfdW5pdHlfbWFwX2Zvcl9kZXZp Y2UoaW9tbXUtPnNlZywgYmRmLCBiYXNlLCBsZW5ndGgsCisgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBpdywgaXIpID86Cisg ICAgICAgICAgICAgcmVzZXJ2ZV91bml0eV9tYXBfZm9yX2RldmljZShpb21t dS0+c2VnLCByZXEsIGJhc2UsIGxlbmd0aCwKKyAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIGl3LCBpcik7CisgICAgfQogCiAg ICAgcmV0dXJuIHJjOwogfQogCiBzdGF0aWMgaW50IF9faW5pdCBwYXJzZV9p dm1kX2RldmljZV9zZWxlY3QoCiAgICAgY29uc3Qgc3RydWN0IGFjcGlfaXZy c19tZW1vcnkgKml2bWRfYmxvY2ssCi0gICAgdW5zaWduZWQgbG9uZyBiYXNl LCB1bnNpZ25lZCBsb25nIGxpbWl0LCB1OCBpdywgdTggaXIpCisgICAgcGFk ZHJfdCBiYXNlLCBwYWRkcl90IGxpbWl0LCBib29sIGl3LCBib29sIGlyLCBi b29sIGV4Y2x1c2lvbikKIHsKICAgICB1MTYgYmRmOwogCkBAIC0zMzMsMTIg KzMxMSwxMiBAQCBzdGF0aWMgaW50IF9faW5pdCBwYXJzZV9pdm1kX2Rldmlj ZV9zZWxlCiAgICAgICAgIHJldHVybiAtRU5PREVWOwogICAgIH0KIAotICAg IHJldHVybiByZWdpc3Rlcl9leGNsdXNpb25fcmFuZ2VfZm9yX2RldmljZShi ZGYsIGJhc2UsIGxpbWl0LCBpdywgaXIpOworICAgIHJldHVybiByZWdpc3Rl cl9yYW5nZV9mb3JfZGV2aWNlKGJkZiwgYmFzZSwgbGltaXQsIGl3LCBpciwg ZXhjbHVzaW9uKTsKIH0KIAogc3RhdGljIGludCBfX2luaXQgcGFyc2VfaXZt ZF9kZXZpY2VfcmFuZ2UoCiAgICAgY29uc3Qgc3RydWN0IGFjcGlfaXZyc19t ZW1vcnkgKml2bWRfYmxvY2ssCi0gICAgdW5zaWduZWQgbG9uZyBiYXNlLCB1 bnNpZ25lZCBsb25nIGxpbWl0LCB1OCBpdywgdTggaXIpCisgICAgcGFkZHJf dCBiYXNlLCBwYWRkcl90IGxpbWl0LCBib29sIGl3LCBib29sIGlyLCBib29s IGV4Y2x1c2lvbikKIHsKICAgICB1bnNpZ25lZCBpbnQgZmlyc3RfYmRmLCBs YXN0X2JkZiwgYmRmOwogICAgIGludCBlcnJvcjsKQEAgLTM2MCwxNSArMzM4 LDE1IEBAIHN0YXRpYyBpbnQgX19pbml0IHBhcnNlX2l2bWRfZGV2aWNlX3Jh bmcKICAgICB9CiAKICAgICBmb3IgKCBiZGYgPSBmaXJzdF9iZGYsIGVycm9y ID0gMDsgKGJkZiA8PSBsYXN0X2JkZikgJiYgIWVycm9yOyBiZGYrKyApCi0g ICAgICAgIGVycm9yID0gcmVnaXN0ZXJfZXhjbHVzaW9uX3JhbmdlX2Zvcl9k ZXZpY2UoCi0gICAgICAgICAgICBiZGYsIGJhc2UsIGxpbWl0LCBpdywgaXIp OworICAgICAgICBlcnJvciA9IHJlZ2lzdGVyX3JhbmdlX2Zvcl9kZXZpY2Uo CisgICAgICAgICAgICBiZGYsIGJhc2UsIGxpbWl0LCBpdywgaXIsIGV4Y2x1 c2lvbik7CiAKICAgICByZXR1cm4gZXJyb3I7CiB9CiAKIHN0YXRpYyBpbnQg X19pbml0IHBhcnNlX2l2bWRfZGV2aWNlX2lvbW11KAogICAgIGNvbnN0IHN0 cnVjdCBhY3BpX2l2cnNfbWVtb3J5ICppdm1kX2Jsb2NrLAotICAgIHVuc2ln bmVkIGxvbmcgYmFzZSwgdW5zaWduZWQgbG9uZyBsaW1pdCwgdTggaXcsIHU4 IGlyKQorICAgIHBhZGRyX3QgYmFzZSwgcGFkZHJfdCBsaW1pdCwgYm9vbCBp dywgYm9vbCBpciwgYm9vbCBleGNsdXNpb24pCiB7CiAgICAgaW50IHNlZyA9 IDA7IC8qIFhYWCAqLwogICAgIHN0cnVjdCBhbWRfaW9tbXUgKmlvbW11OwpA QCAtMzgzLDE0ICszNjEsMTQgQEAgc3RhdGljIGludCBfX2luaXQgcGFyc2Vf aXZtZF9kZXZpY2VfaW9tbQogICAgICAgICByZXR1cm4gLUVOT0RFVjsKICAg ICB9CiAKLSAgICByZXR1cm4gcmVnaXN0ZXJfZXhjbHVzaW9uX3JhbmdlX2Zv cl9pb21tdV9kZXZpY2VzKAotICAgICAgICBpb21tdSwgYmFzZSwgbGltaXQs IGl3LCBpcik7CisgICAgcmV0dXJuIHJlZ2lzdGVyX3JhbmdlX2Zvcl9pb21t dV9kZXZpY2VzKAorICAgICAgICBpb21tdSwgYmFzZSwgbGltaXQsIGl3LCBp ciwgZXhjbHVzaW9uKTsKIH0KIAogc3RhdGljIGludCBfX2luaXQgcGFyc2Vf aXZtZF9ibG9jayhjb25zdCBzdHJ1Y3QgYWNwaV9pdnJzX21lbW9yeSAqaXZt ZF9ibG9jaykKIHsKICAgICB1bnNpZ25lZCBsb25nIHN0YXJ0X2FkZHIsIG1l bV9sZW5ndGgsIGJhc2UsIGxpbWl0OwotICAgIHU4IGl3LCBpcjsKKyAgICBi b29sIGl3ID0gdHJ1ZSwgaXIgPSB0cnVlLCBleGNsdXNpb24gPSBmYWxzZTsK IAogICAgIGlmICggaXZtZF9ibG9jay0+aGVhZGVyLmxlbmd0aCA8IHNpemVv ZigqaXZtZF9ibG9jaykgKQogICAgIHsKQEAgLTQwNywxMyArMzg1LDExIEBA IHN0YXRpYyBpbnQgX19pbml0IHBhcnNlX2l2bWRfYmxvY2soY29uc3QKICAg ICAgICAgICAgICAgICAgICAgaXZtZF9ibG9jay0+aGVhZGVyLnR5cGUsIHN0 YXJ0X2FkZHIsIG1lbV9sZW5ndGgpOwogCiAgICAgaWYgKCBpdm1kX2Jsb2Nr LT5oZWFkZXIuZmxhZ3MgJiBBQ1BJX0lWTURfRVhDTFVTSU9OX1JBTkdFICkK LSAgICAgICAgaXcgPSBpciA9IElPTU1VX0NPTlRST0xfRU5BQkxFRDsKKyAg ICAgICAgZXhjbHVzaW9uID0gdHJ1ZTsKICAgICBlbHNlIGlmICggaXZtZF9i bG9jay0+aGVhZGVyLmZsYWdzICYgQUNQSV9JVk1EX1VOSVRZICkKICAgICB7 Ci0gICAgICAgIGl3ID0gaXZtZF9ibG9jay0+aGVhZGVyLmZsYWdzICYgQUNQ SV9JVk1EX1JFQUQgPwotICAgICAgICAgICAgSU9NTVVfQ09OVFJPTF9FTkFC TEVEIDogSU9NTVVfQ09OVFJPTF9ESVNBQkxFRDsKLSAgICAgICAgaXIgPSBp dm1kX2Jsb2NrLT5oZWFkZXIuZmxhZ3MgJiBBQ1BJX0lWTURfV1JJVEUgPwot ICAgICAgICAgICAgSU9NTVVfQ09OVFJPTF9FTkFCTEVEIDogSU9NTVVfQ09O VFJPTF9ESVNBQkxFRDsKKyAgICAgICAgaXcgPSBpdm1kX2Jsb2NrLT5oZWFk ZXIuZmxhZ3MgJiBBQ1BJX0lWTURfUkVBRDsKKyAgICAgICAgaXIgPSBpdm1k X2Jsb2NrLT5oZWFkZXIuZmxhZ3MgJiBBQ1BJX0lWTURfV1JJVEU7CiAgICAg fQogICAgIGVsc2UKICAgICB7CkBAIC00MjQsMjAgKzQwMCwyMCBAQCBzdGF0 aWMgaW50IF9faW5pdCBwYXJzZV9pdm1kX2Jsb2NrKGNvbnN0CiAgICAgc3dp dGNoKCBpdm1kX2Jsb2NrLT5oZWFkZXIudHlwZSApCiAgICAgewogICAgIGNh c2UgQUNQSV9JVlJTX1RZUEVfTUVNT1JZX0FMTDoKLSAgICAgICAgcmV0dXJu IHJlZ2lzdGVyX2V4Y2x1c2lvbl9yYW5nZV9mb3JfYWxsX2RldmljZXMoCi0g ICAgICAgICAgICBiYXNlLCBsaW1pdCwgaXcsIGlyKTsKKyAgICAgICAgcmV0 dXJuIHJlZ2lzdGVyX3JhbmdlX2Zvcl9hbGxfZGV2aWNlcygKKyAgICAgICAg ICAgIGJhc2UsIGxpbWl0LCBpdywgaXIsIGV4Y2x1c2lvbik7CiAKICAgICBj YXNlIEFDUElfSVZSU19UWVBFX01FTU9SWV9PTkU6Ci0gICAgICAgIHJldHVy biBwYXJzZV9pdm1kX2RldmljZV9zZWxlY3QoaXZtZF9ibG9jaywKLSAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBiYXNlLCBsaW1p dCwgaXcsIGlyKTsKKyAgICAgICAgcmV0dXJuIHBhcnNlX2l2bWRfZGV2aWNl X3NlbGVjdChpdm1kX2Jsb2NrLCBiYXNlLCBsaW1pdCwKKyAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBpdywgaXIsIGV4Y2x1c2lv bik7CiAKICAgICBjYXNlIEFDUElfSVZSU19UWVBFX01FTU9SWV9SQU5HRToK LSAgICAgICAgcmV0dXJuIHBhcnNlX2l2bWRfZGV2aWNlX3JhbmdlKGl2bWRf YmxvY2ssCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBiYXNlLCBsaW1pdCwgaXcsIGlyKTsKKyAgICAgICAgcmV0dXJuIHBhcnNl X2l2bWRfZGV2aWNlX3JhbmdlKGl2bWRfYmxvY2ssIGJhc2UsIGxpbWl0LAor ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgaXcsIGly LCBleGNsdXNpb24pOwogCiAgICAgY2FzZSBBQ1BJX0lWUlNfVFlQRV9NRU1P UllfSU9NTVU6Ci0gICAgICAgIHJldHVybiBwYXJzZV9pdm1kX2RldmljZV9p b21tdShpdm1kX2Jsb2NrLAotICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgYmFzZSwgbGltaXQsIGl3LCBpcik7CisgICAgICAgIHJl dHVybiBwYXJzZV9pdm1kX2RldmljZV9pb21tdShpdm1kX2Jsb2NrLCBiYXNl LCBsaW1pdCwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIGl3LCBpciwgZXhjbHVzaW9uKTsKIAogICAgIGRlZmF1bHQ6CiAgICAg ICAgIEFNRF9JT01NVV9ERUJVRygiSVZNRCBFcnJvcjogSW52YWxpZCBCbG9j ayBUeXBlIVxuIik7Ci0tLSBhL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL2Ft ZC9wY2lfYW1kX2lvbW11LmMKKysrIGIveGVuL2RyaXZlcnMvcGFzc3Rocm91 Z2gvYW1kL3BjaV9hbWRfaW9tbXUuYwpAQCAtMjM0LDYgKzIzNCw4IEBAIHN0 YXRpYyBpbnQgX19tdXN0X2NoZWNrIGFsbG9jYXRlX2RvbWFpbl8KICAgICBy ZXR1cm4gcmM7CiB9CiAKK2ludCBfX3JlYWRfbW9zdGx5IGFtZF9pb21tdV9t aW5fcGFnaW5nX21vZGUgPSAxOworCiBzdGF0aWMgaW50IGFtZF9pb21tdV9k b21haW5faW5pdChzdHJ1Y3QgZG9tYWluICpkKQogewogICAgIHN0cnVjdCBk b21haW5faW9tbXUgKmhkID0gZG9tX2lvbW11KGQpOwpAQCAtMjQ1LDExICsy NDcsMTMgQEAgc3RhdGljIGludCBhbWRfaW9tbXVfZG9tYWluX2luaXQoc3Ry dWN0CiAgICAgICogLSBIVk0gY291bGQgaW4gcHJpbmNpcGxlIHVzZSAzIG9y IDQgZGVwZW5kaW5nIG9uIGhvdyBtdWNoIGd1ZXN0CiAgICAgICogICBwaHlz aWNhbCBhZGRyZXNzIHNwYWNlIHdlIGdpdmUgaXQsIGJ1dCB0aGlzIGlzbid0 IGtub3duIHlldCBzbyB1c2UgNAogICAgICAqICAgdW5pbGF0ZXJhbGx5Lgor ICAgICAqIC0gVW5pdHkgbWFwcyBtYXkgcmVxdWlyZSBhbiBldmVuIGhpZ2hl ciBudW1iZXIuCiAgICAgICovCi0gICAgaGQtPmFyY2guYW1kLnBhZ2luZ19t b2RlID0gYW1kX2lvbW11X2dldF9wYWdpbmdfbW9kZSgKLSAgICAgICAgaXNf aHZtX2RvbWFpbihkKQotICAgICAgICA/IDF1bCA8PCAoREVGQVVMVF9ET01B SU5fQUREUkVTU19XSURUSCAtIFBBR0VfU0hJRlQpCi0gICAgICAgIDogZ2V0 X3VwcGVyX21mbl9ib3VuZCgpICsgMSk7CisgICAgaGQtPmFyY2guYW1kLnBh Z2luZ19tb2RlID0gbWF4KGFtZF9pb21tdV9nZXRfcGFnaW5nX21vZGUoCisg ICAgICAgICAgICBpc19odm1fZG9tYWluKGQpCisgICAgICAgICAgICA/IDF1 bCA8PCAoREVGQVVMVF9ET01BSU5fQUREUkVTU19XSURUSCAtIFBBR0VfU0hJ RlQpCisgICAgICAgICAgICA6IGdldF91cHBlcl9tZm5fYm91bmQoKSArIDEp LAorICAgICAgICBhbWRfaW9tbXVfbWluX3BhZ2luZ19tb2RlKTsKIAogICAg IHJldHVybiAwOwogfQo= --=separator Content-Type: application/octet-stream; name="xsa378/xsa378-4.15-7.patch" Content-Disposition: attachment; filename="xsa378/xsa378-4.15-7.patch" Content-Transfer-Encoding: base64 RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0 OiB4ODYvcDJtOiBpbnRyb2R1Y2UgcDJtX2lzX3NwZWNpYWwoKQoKU2VlaW5n IHRoZSBzaW1pbGFyaXR5IG9mIGdyYW50LCBmb3JlaWduLCBhbmQgKHN1YnNl cXVlbnRseSkgZGlyZWN0LU1NSU8KaGFuZGxpbmcsIGludHJvZHVjZSBhIG5l dyBQMk0gdHlwZSBncm91cCBuYW1lZCAic3BlY2lhbCIgKGFzIGluICJuZWVk aW5nCnNwZWNpYWwgYWNjZXNzb3JzIHRvIGNyZWF0ZS9kZXN0cm95IikuCgpB bHNvIHVzZSAtRVBFUk0gaW5zdGVhZCBvZiBvdGhlciBlcnJvciBjb2RlcyBv biB0aGUgdHdvIGRvbWFpbl9jcmFzaCgpCnBhdGhzIHRvdWNoZWQuCgpUaGlz IGlzIHBhcnQgb2YgWFNBLTM3OC4KClNpZ25lZC1vZmYtYnk6IEphbiBCZXVs aWNoIDxqYmV1bGljaEBzdXNlLmNvbT4KUmV2aWV3ZWQtYnk6IFBhdWwgRHVy cmFudCA8cGF1bEB4ZW4ub3JnPgoKLS0tIGEveGVuL2FyY2gveDg2L21tL3Ay bS5jCisrKyBiL3hlbi9hcmNoL3g4Ni9tbS9wMm0uYwpAQCAtODExLDcgKzgx MSw3IEBAIHAybV9yZW1vdmVfcGFnZShzdHJ1Y3QgcDJtX2RvbWFpbiAqcDJt LAogICAgICAgICBmb3IgKCBpID0gMDsgaSA8ICgxVUwgPDwgcGFnZV9vcmRl cik7IGkrKyApCiAgICAgICAgIHsKICAgICAgICAgICAgIHAybS0+Z2V0X2Vu dHJ5KHAybSwgZ2ZuX2FkZChnZm4sIGkpLCAmdCwgJmEsIDAsIE5VTEwsIE5V TEwpOwotICAgICAgICAgICAgaWYgKCAhcDJtX2lzX2dyYW50KHQpICYmICFw Mm1faXNfc2hhcmVkKHQpICYmICFwMm1faXNfZm9yZWlnbih0KSApCisgICAg ICAgICAgICBpZiAoICFwMm1faXNfc3BlY2lhbCh0KSAmJiAhcDJtX2lzX3No YXJlZCh0KSApCiAgICAgICAgICAgICAgICAgc2V0X2dwZm5fZnJvbV9tZm4o bWZuX3gobWZuKSArIGksIElOVkFMSURfTTJQX0VOVFJZKTsKICAgICAgICAg fQogICAgIH0KQEAgLTk0MSwxMyArOTQxLDEzIEBAIGd1ZXN0X3BoeXNtYXBf YWRkX2VudHJ5KHN0cnVjdCBkb21haW4gKmQKICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAmb3QsICZhLCAwLCBOVUxMLCBOVUxMKTsKICAg ICAgICAgICAgIEFTU0VSVCghcDJtX2lzX3NoYXJlZChvdCkpOwogICAgICAg ICB9Ci0gICAgICAgIGlmICggcDJtX2lzX2dyYW50KG90KSB8fCBwMm1faXNf Zm9yZWlnbihvdCkgKQorICAgICAgICBpZiAoIHAybV9pc19zcGVjaWFsKG90 KSApCiAgICAgICAgIHsKLSAgICAgICAgICAgIC8qIFJlYWxseSBzaG91bGRu J3QgYmUgdW5tYXBwaW5nIGdyYW50L2ZvcmVpZ24gbWFwcyB0aGlzIHdheSAq LworICAgICAgICAgICAgLyogRG9uJ3QgcGVybWl0IHVubWFwcGluZyBncmFu dC9mb3JlaWduIHRoaXMgd2F5LiAqLwogICAgICAgICAgICAgZG9tYWluX2Ny YXNoKGQpOwogICAgICAgICAgICAgcDJtX3VubG9jayhwMm0pOwogICAgICAg ICAgICAgCi0gICAgICAgICAgICByZXR1cm4gLUVJTlZBTDsKKyAgICAgICAg ICAgIHJldHVybiAtRVBFUk07CiAgICAgICAgIH0KICAgICAgICAgZWxzZSBp ZiAoIHAybV9pc19yYW0ob3QpICYmICFwMm1faXNfcGFnZWQob3QpICkKICAg ICAgICAgewpAQCAtMTA0MSw4ICsxMDQxLDcgQEAgaW50IHAybV9jaGFuZ2Vf dHlwZV9vbmUoc3RydWN0IGRvbWFpbiAqZAogICAgIHN0cnVjdCBwMm1fZG9t YWluICpwMm0gPSBwMm1fZ2V0X2hvc3RwMm0oZCk7CiAgICAgaW50IHJjOwog Ci0gICAgQlVHX09OKHAybV9pc19ncmFudChvdCkgfHwgcDJtX2lzX2dyYW50 KG50KSk7Ci0gICAgQlVHX09OKHAybV9pc19mb3JlaWduKG90KSB8fCBwMm1f aXNfZm9yZWlnbihudCkpOworICAgIEJVR19PTihwMm1faXNfc3BlY2lhbChv dCkgfHwgcDJtX2lzX3NwZWNpYWwobnQpKTsKIAogICAgIGdmbl9sb2NrKHAy bSwgZ2ZuLCAwKTsKIApAQCAtMTI4OSwxMSArMTI4OCwxMSBAQCBzdGF0aWMg aW50IHNldF90eXBlZF9wMm1fZW50cnkoc3RydWN0IGRvCiAgICAgICAgIGdm bl91bmxvY2socDJtLCBnZm4sIG9yZGVyKTsKICAgICAgICAgcmV0dXJuIGN1 cl9vcmRlciArIDE7CiAgICAgfQotICAgIGlmICggcDJtX2lzX2dyYW50KG90 KSB8fCBwMm1faXNfZm9yZWlnbihvdCkgKQorICAgIGlmICggcDJtX2lzX3Nw ZWNpYWwob3QpICkKICAgICB7CiAgICAgICAgIGdmbl91bmxvY2socDJtLCBn Zm4sIG9yZGVyKTsKICAgICAgICAgZG9tYWluX2NyYXNoKGQpOwotICAgICAg ICByZXR1cm4gLUVOT0VOVDsKKyAgICAgICAgcmV0dXJuIC1FUEVSTTsKICAg ICB9CiAgICAgZWxzZSBpZiAoIHAybV9pc19yYW0ob3QpICkKICAgICB7Ci0t LSBhL3hlbi9pbmNsdWRlL2FzbS14ODYvcDJtLmgKKysrIGIveGVuL2luY2x1 ZGUvYXNtLXg4Ni9wMm0uaApAQCAtMTQ5LDYgKzE0OSwxMCBAQCB0eXBlZGVm IHVuc2lnbmVkIGludCBwMm1fcXVlcnlfdDsKICAgICAgICAgICAgICAgICAg ICAgICAgICAgICB8IHAybV90b19tYXNrKHAybV9yYW1fbG9nZGlydHkpICkK ICNkZWZpbmUgUDJNX1NIQVJFRF9UWVBFUyAgIChwMm1fdG9fbWFzayhwMm1f cmFtX3NoYXJlZCkpCiAKKy8qIFR5cGVzIGVzdGFibGlzaGVkL2NsZWFuZWQg dXAgdmlhIHNwZWNpYWwgYWNjZXNzb3JzLiAqLworI2RlZmluZSBQMk1fU1BF Q0lBTF9UWVBFUyAoUDJNX0dSQU5UX1RZUEVTIHwgXAorICAgICAgICAgICAg ICAgICAgICAgICAgICAgcDJtX3RvX21hc2socDJtX21hcF9mb3JlaWduKSkK KwogLyogVmFsaWQgdHlwZXMgbm90IG5lY2Vzc2FyaWx5IGFzc29jaWF0ZWQg d2l0aCBhICh2YWxpZCkgTUZOLiAqLwogI2RlZmluZSBQMk1fSU5WQUxJRF9N Rk5fVFlQRVMgKFAyTV9QT0RfVFlQRVMgICAgICAgICAgICAgICAgICBcCiAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfCBwMm1fdG9fbWFzayhw Mm1fbW1pb19kaXJlY3QpIFwKQEAgLTE3Nyw2ICsxODEsNyBAQCB0eXBlZGVm IHVuc2lnbmVkIGludCBwMm1fcXVlcnlfdDsKICNkZWZpbmUgcDJtX2lzX3Bh Z2VkKF90KSAgICAocDJtX3RvX21hc2soX3QpICYgUDJNX1BBR0VEX1RZUEVT KQogI2RlZmluZSBwMm1faXNfc2hhcmFibGUoX3QpIChwMm1fdG9fbWFzayhf dCkgJiBQMk1fU0hBUkFCTEVfVFlQRVMpCiAjZGVmaW5lIHAybV9pc19zaGFy ZWQoX3QpICAgKHAybV90b19tYXNrKF90KSAmIFAyTV9TSEFSRURfVFlQRVMp CisjZGVmaW5lIHAybV9pc19zcGVjaWFsKF90KSAgKHAybV90b19tYXNrKF90 KSAmIFAyTV9TUEVDSUFMX1RZUEVTKQogI2RlZmluZSBwMm1faXNfYnJva2Vu KF90KSAgIChwMm1fdG9fbWFzayhfdCkgJiBQMk1fQlJPS0VOX1RZUEVTKQog I2RlZmluZSBwMm1faXNfZm9yZWlnbihfdCkgIChwMm1fdG9fbWFzayhfdCkg JiBwMm1fdG9fbWFzayhwMm1fbWFwX2ZvcmVpZ24pKQogCg== --=separator Content-Type: application/octet-stream; name="xsa378/xsa378-4.15-8.patch" Content-Disposition: attachment; filename="xsa378/xsa378-4.15-8.patch" Content-Transfer-Encoding: base64 RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0 OiB4ODYvcDJtOiBndWFyZCAoaW4gcGFydGljdWxhcikgaWRlbnRpdHkgbWFw cGluZyBlbnRyaWVzCgpTdWNoIGVudHJpZXMsIGNyZWF0ZWQgYnkgc2V0X2lk ZW50aXR5X3AybV9lbnRyeSgpLCBzaG91bGQgb25seSBiZQpkZXN0cm95ZWQg YnkgY2xlYXJfaWRlbnRpdHlfcDJtX2VudHJ5KCkuIEhvd2V2ZXIsIHNpbWls YXJseSwgZW50cmllcwpjcmVhdGVkIGJ5IHNldF9tbWlvX3AybV9lbnRyeSgp IHNob3VsZCBvbmx5IGJlIHRvcm4gZG93biBieQpjbGVhcl9tbWlvX3AybV9l bnRyeSgpLCBzbyB0aGUgbG9naWMgZ2V0cyBiYXNlZCB1cG9uIHAybV9tbWlv X2RpcmVjdCBhcwp0aGUgZW50cnkgdHlwZSAoc2VwYXJhdGlvbiBiZXR3ZWVu ICJvcmRpbmFyeSIgYW5kIDE6MSBtYXBwaW5ncyB3b3VsZApyZXF1aXJlIGEg ZnVydGhlciBpbmRpY2F0b3IgdG8gdGVsbCBhcGFydCB0aGUgdHdvKS4KCkFz IHRvIHRoZSBndWVzdF9yZW1vdmVfcGFnZSgpIGNoYW5nZSwgY29tbWl0IDQ4 ZGZiMjk3YTIwYSAoIng4Ni9QVkg6CmFsbG93IGd1ZXN0X3JlbW92ZV9wYWdl IHRvIHJlbW92ZSBwMm1fbW1pb19kaXJlY3QgcGFnZXMiKSwgd2hpY2gKaW50 cm9kdWNlZCB0aGUgY2FsbCB0byBjbGVhcl9tbWlvX3AybV9lbnRyeSgpLCBj bGFpbWVkIHRoaXMgd2FzIGRvbmUgZm9yCmh3ZG9tIG9ubHkgd2l0aG91dCB0 aGlzIGFjdHVhbGx5IGhhdmluZyBiZWVuIHRoZSBjYXNlLiBIb3dldmVyLCB0 aGlzCmNvZGUgc2hvdWxkbid0IGJlIHRoZXJlIGluIHRoZSBmaXJzdCBwbGFj ZSwgYXMgTU1JTyBlbnRyaWVzIHNob3VsZG4ndCBiZQpkcm9wcGVkIHRoaXMg d2F5LiBBdm9pZCB0cmlnZ2VyaW5nIHRoZSB3YXJuaW5nIGFnYWluIHRoYXQg NDhkZmIyOTdhMjBhCnNpbGVuY2VkIGJ5IGFuIGFkanVzdG1lbnQgdG8geGVu bWVtX2FkZF90b19waHlzbWFwX29uZSgpIGluc3RlYWQuCgpOb3RlIHRoYXQg Z3Vlc3RfcGh5c21hcF9tYXJrX3BvcHVsYXRlX29uX2RlbWFuZCgpIGdldHMg dGlnaHRlbmVkIGJleW9uZAp0aGUgaW1tZWRpYXRlIHB1cnBvc2Ugb2YgdGhp cyBjaGFuZ2UuCgpOb3RlIGFsc28gdGhhdCBJIGRpZG4ndCBpbnNwZWN0IGNv ZGUgd2hpY2ggaXNuJ3Qgc2VjdXJpdHkgc3VwcG9ydGVkLAplLmcuIHNoYXJp bmcsIHBhZ2luZywgb3IgYWx0cDJtLgoKVGhpcyBpcyBDVkUtMjAyMS0yODY5 NCAvIHBhcnQgb2YgWFNBLTM3OC4KClNpZ25lZC1vZmYtYnk6IEphbiBCZXVs aWNoIDxqYmV1bGljaEBzdXNlLmNvbT4KUmV2aWV3ZWQtYnk6IFBhdWwgRHVy cmFudCA8cGF1bEB4ZW4ub3JnPgoKLS0tIGEveGVuL2FyY2gveDg2L21tL3Ay bS5jCisrKyBiL3hlbi9hcmNoL3g4Ni9tbS9wMm0uYwpAQCAtNzk5LDcgKzc5 OSw4IEBAIHAybV9yZW1vdmVfcGFnZShzdHJ1Y3QgcDJtX2RvbWFpbiAqcDJt LAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg JmN1cl9vcmRlciwgTlVMTCk7CiAKICAgICAgICAgaWYgKCBwMm1faXNfdmFs aWQodCkgJiYKLSAgICAgICAgICAgICAoIW1mbl92YWxpZChtZm4pIHx8ICFt Zm5fZXEobWZuX2FkZChtZm4sIGkpLCBtZm5fcmV0dXJuKSkgKQorICAgICAg ICAgICAgICghbWZuX3ZhbGlkKG1mbikgfHwgdCA9PSBwMm1fbW1pb19kaXJl Y3QgfHwKKyAgICAgICAgICAgICAgIW1mbl9lcShtZm5fYWRkKG1mbiwgaSks IG1mbl9yZXR1cm4pKSApCiAgICAgICAgICAgICByZXR1cm4gLUVJTFNFUTsK IAogICAgICAgICBpICs9ICgxVUwgPDwgY3VyX29yZGVyKSAtCkBAIC04OTks NyArOTAwLDcgQEAgZ3Vlc3RfcGh5c21hcF9hZGRfZW50cnkoc3RydWN0IGRv bWFpbiAqZAogICAgIGlmICggcDJtX2lzX2ZvcmVpZ24odCkgKQogICAgICAg ICByZXR1cm4gLUVJTlZBTDsKIAotICAgIGlmICggIW1mbl92YWxpZChtZm4p ICkKKyAgICBpZiAoICFtZm5fdmFsaWQobWZuKSB8fCB0ID09IHAybV9tbWlv X2RpcmVjdCApCiAgICAgewogICAgICAgICBBU1NFUlRfVU5SRUFDSEFCTEUo KTsKICAgICAgICAgcmV0dXJuIC1FSU5WQUw7CkBAIC05NDMsNyArOTQ0LDcg QEAgZ3Vlc3RfcGh5c21hcF9hZGRfZW50cnkoc3RydWN0IGRvbWFpbiAqZAog ICAgICAgICB9CiAgICAgICAgIGlmICggcDJtX2lzX3NwZWNpYWwob3QpICkK ICAgICAgICAgewotICAgICAgICAgICAgLyogRG9uJ3QgcGVybWl0IHVubWFw cGluZyBncmFudC9mb3JlaWduIHRoaXMgd2F5LiAqLworICAgICAgICAgICAg LyogRG9uJ3QgcGVybWl0IHVubWFwcGluZyBncmFudC9mb3JlaWduL2RpcmVj dC1NTUlPIHRoaXMgd2F5LiAqLwogICAgICAgICAgICAgZG9tYWluX2NyYXNo KGQpOwogICAgICAgICAgICAgcDJtX3VubG9jayhwMm0pOwogICAgICAgICAg ICAgCkBAIC0xMzk5LDggKzE0MDAsOCBAQCBpbnQgc2V0X2lkZW50aXR5X3Ay bV9lbnRyeShzdHJ1Y3QgZG9tYWluCiAgKiAgICBvcmRlcisxICBmb3IgY2Fs bGVyIHRvIHJldHJ5IHdpdGggb3JkZXIgKGd1YXJhbnRlZWQgc21hbGxlciB0 aGFuCiAgKiAgICAgICAgICAgICB0aGUgb3JkZXIgdmFsdWUgcGFzc2VkIGlu KQogICovCi1pbnQgY2xlYXJfbW1pb19wMm1fZW50cnkoc3RydWN0IGRvbWFp biAqZCwgdW5zaWduZWQgbG9uZyBnZm5fbCwgbWZuX3QgbWZuLAotICAgICAg ICAgICAgICAgICAgICAgICAgIHVuc2lnbmVkIGludCBvcmRlcikKK3N0YXRp YyBpbnQgY2xlYXJfbW1pb19wMm1fZW50cnkoc3RydWN0IGRvbWFpbiAqZCwg dW5zaWduZWQgbG9uZyBnZm5fbCwKKyAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgbWZuX3QgbWZuLCB1bnNpZ25lZCBpbnQgb3JkZXIpCiB7CiAg ICAgaW50IHJjID0gLUVJTlZBTDsKICAgICBnZm5fdCBnZm4gPSBfZ2ZuKGdm bl9sKTsKQEAgLTI3MzEsNyArMjczMiw5IEBAIGludCB4ZW5tZW1fYWRkX3Rv X3BoeXNtYXBfb25lKAogCiAgICAgLyogUmVtb3ZlIHByZXZpb3VzbHkgbWFw cGVkIHBhZ2UgaWYgaXQgd2FzIHByZXNlbnQuICovCiAgICAgcHJldl9tZm4g PSBnZXRfZ2ZuKGQsIGdmbl94KGdwZm4pLCAmcDJtdCk7Ci0gICAgaWYgKCBt Zm5fdmFsaWQocHJldl9tZm4pICkKKyAgICBpZiAoIHAybXQgPT0gcDJtX21t aW9fZGlyZWN0ICkKKyAgICAgICAgcmMgPSAtRVBFUk07CisgICAgZWxzZSBp ZiAoIG1mbl92YWxpZChwcmV2X21mbikgKQogICAgIHsKICAgICAgICAgaWYg KCBpc19zcGVjaWFsX3BhZ2UobWZuX3RvX3BhZ2UocHJldl9tZm4pKSApCiAg ICAgICAgICAgICAvKiBTcGVjaWFsIHBhZ2VzIGFyZSBzaW1wbHkgdW5ob29r ZWQgZnJvbSB0aGlzIHBoeXMgc2xvdC4gKi8KLS0tIGEveGVuL2FyY2gveDg2 L21tL3AybS1wb2QuYworKysgYi94ZW4vYXJjaC94ODYvbW0vcDJtLXBvZC5j CkBAIC0xMjk5LDE3ICsxMjk5LDE3IEBAIGd1ZXN0X3BoeXNtYXBfbWFya19w b3B1bGF0ZV9vbl9kZW1hbmQoc3QKIAogICAgICAgICBwMm0tPmdldF9lbnRy eShwMm0sIGdmbl9hZGQoZ2ZuLCBpKSwgJm90LCAmYSwgMCwgJmN1cl9vcmRl ciwgTlVMTCk7CiAgICAgICAgIG4gPSAxVUwgPDwgbWluKG9yZGVyLCBjdXJf b3JkZXIpOwotICAgICAgICBpZiAoIHAybV9pc19yYW0ob3QpICkKKyAgICAg ICAgaWYgKCBvdCA9PSBwMm1fcG9wdWxhdGVfb25fZGVtYW5kICkKKyAgICAg ICAgeworICAgICAgICAgICAgLyogQ291bnQgaG93IG1hbnkgUG9EIGVudHJp ZXMgd2UnbGwgYmUgcmVwbGFjaW5nIGlmIHN1Y2Nlc3NmdWwgKi8KKyAgICAg ICAgICAgIHBvZF9jb3VudCArPSBuOworICAgICAgICB9CisgICAgICAgIGVs c2UgaWYgKCBvdCAhPSBwMm1faW52YWxpZCAmJiBvdCAhPSBwMm1fbW1pb19k bSApCiAgICAgICAgIHsKICAgICAgICAgICAgIFAyTV9ERUJVRygiZ2ZuX3Rv X21mbiByZXR1cm5lZCB0eXBlICVkIVxuIiwgb3QpOwogICAgICAgICAgICAg cmMgPSAtRUJVU1k7CiAgICAgICAgICAgICBnb3RvIG91dDsKICAgICAgICAg fQotICAgICAgICBlbHNlIGlmICggb3QgPT0gcDJtX3BvcHVsYXRlX29uX2Rl bWFuZCApCi0gICAgICAgIHsKLSAgICAgICAgICAgIC8qIENvdW50IGhvdyBt YW4gUG9EIGVudHJpZXMgd2UnbGwgYmUgcmVwbGFjaW5nIGlmIHN1Y2Nlc3Nm dWwgKi8KLSAgICAgICAgICAgIHBvZF9jb3VudCArPSBuOwotICAgICAgICB9 CiAgICAgfQogCiAgICAgLyogTm93LCBhY3R1YWxseSBkbyB0aGUgdHdvLXdh eSBtYXBwaW5nICovCi0tLSBhL3hlbi9jb21tb24vbWVtb3J5LmMKKysrIGIv eGVuL2NvbW1vbi9tZW1vcnkuYwpAQCAtMzMwLDcgKzMzMCw3IEBAIGludCBn dWVzdF9yZW1vdmVfcGFnZShzdHJ1Y3QgZG9tYWluICpkLAogICAgIH0KICAg ICBpZiAoIHAybXQgPT0gcDJtX21taW9fZGlyZWN0ICkKICAgICB7Ci0gICAg ICAgIHJjID0gY2xlYXJfbW1pb19wMm1fZW50cnkoZCwgZ21mbiwgbWZuLCBQ QUdFX09SREVSXzRLKTsKKyAgICAgICAgcmMgPSAtRVBFUk07CiAgICAgICAg IGdvdG8gb3V0X3B1dF9nZm47CiAgICAgfQogI2Vsc2UKQEAgLTE4NzUsNiAr MTg3NSwxNSBAQCBpbnQgY2hlY2tfZ2V0X3BhZ2VfZnJvbV9nZm4oc3RydWN0 IGRvbWFpCiAgICAgICAgIHJldHVybiAtRUFHQUlOOwogICAgIH0KICNlbmRp ZgorI2lmZGVmIENPTkZJR19YODYKKyAgICBpZiAoIHAybXQgPT0gcDJtX21t aW9fZGlyZWN0ICkKKyAgICB7CisgICAgICAgIGlmICggcGFnZSApCisgICAg ICAgICAgICBwdXRfcGFnZShwYWdlKTsKKworICAgICAgICByZXR1cm4gLUVQ RVJNOworICAgIH0KKyNlbmRpZgogCiAgICAgaWYgKCAhcGFnZSApCiAgICAg ICAgIHJldHVybiAtRUlOVkFMOwotLS0gYS94ZW4vaW5jbHVkZS9hc20teDg2 L3AybS5oCisrKyBiL3hlbi9pbmNsdWRlL2FzbS14ODYvcDJtLmgKQEAgLTE1 MSw3ICsxNTEsOCBAQCB0eXBlZGVmIHVuc2lnbmVkIGludCBwMm1fcXVlcnlf dDsKIAogLyogVHlwZXMgZXN0YWJsaXNoZWQvY2xlYW5lZCB1cCB2aWEgc3Bl Y2lhbCBhY2Nlc3NvcnMuICovCiAjZGVmaW5lIFAyTV9TUEVDSUFMX1RZUEVT IChQMk1fR1JBTlRfVFlQRVMgfCBcCi0gICAgICAgICAgICAgICAgICAgICAg ICAgICBwMm1fdG9fbWFzayhwMm1fbWFwX2ZvcmVpZ24pKQorICAgICAgICAg ICAgICAgICAgICAgICAgICAgcDJtX3RvX21hc2socDJtX21hcF9mb3JlaWdu KSB8IFwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgIHAybV90b19tYXNr KHAybV9tbWlvX2RpcmVjdCkpCiAKIC8qIFZhbGlkIHR5cGVzIG5vdCBuZWNl c3NhcmlseSBhc3NvY2lhdGVkIHdpdGggYSAodmFsaWQpIE1GTi4gKi8KICNk ZWZpbmUgUDJNX0lOVkFMSURfTUZOX1RZUEVTIChQMk1fUE9EX1RZUEVTICAg ICAgICAgICAgICAgICAgXApAQCAtNjY2LDggKzY2Nyw2IEBAIGludCBwMm1f aXNfbG9nZGlydHlfcmFuZ2Uoc3RydWN0IHAybV9kb20KIC8qIFNldCBtbWlv IGFkZHJlc3NlcyBpbiB0aGUgcDJtIHRhYmxlIChmb3IgcGFzcy10aHJvdWdo KSAqLwogaW50IHNldF9tbWlvX3AybV9lbnRyeShzdHJ1Y3QgZG9tYWluICpk LCBnZm5fdCBnZm4sIG1mbl90IG1mbiwKICAgICAgICAgICAgICAgICAgICAg ICAgdW5zaWduZWQgaW50IG9yZGVyKTsKLWludCBjbGVhcl9tbWlvX3AybV9l bnRyeShzdHJ1Y3QgZG9tYWluICpkLCB1bnNpZ25lZCBsb25nIGdmbiwgbWZu X3QgbWZuLAotICAgICAgICAgICAgICAgICAgICAgICAgIHVuc2lnbmVkIGlu dCBvcmRlcik7CiAKIC8qIFNldCBpZGVudGl0eSBhZGRyZXNzZXMgaW4gdGhl IHAybSB0YWJsZSAoZm9yIHBhc3MtdGhyb3VnaCkgKi8KIGludCBzZXRfaWRl bnRpdHlfcDJtX2VudHJ5KHN0cnVjdCBkb21haW4gKmQsIHVuc2lnbmVkIGxv bmcgZ2ZuLAo= --=separator Content-Type: application/octet-stream; name="xsa378/xsa378-4.patch" Content-Disposition: attachment; filename="xsa378/xsa378-4.patch" Content-Transfer-Encoding: base64 RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0 OiBJT01NVTogZ2VuZXJhbGl6ZSBWVC1kJ3MgdHJhY2tpbmcgb2YgbWFwcGVk IFJNUlIgcmVnaW9ucwoKSW4gb3JkZXIgdG8gcmUtdXNlIGl0IGVsc2V3aGVy ZSwgbW92ZSB0aGUgbG9naWMgdG8gdmVuZG9yIGluZGVwZW5kZW50CmNvZGUg YW5kIHN0cmlwIGl0IG9mIFJNUlIgc3BlY2lmaWNzLgoKTm90ZSB0aGF0IHRo ZSBwcmlvciAibWFwIiBwYXJhbWV0ZXIgZ2V0cyBmb2xkZWQgaW50byB0aGUg bmV3ICJwMm1hIiBvbmUKKHdoaWNoIEFNRCBJT01NVSBjb2RlIHdpbGwgd2Fu dCB0byBtYWtlIHVzZSBvZiksIGFzc2lnbmluZyBhbHRlcm5hdGl2ZQptZWFu aW5nICgidW5tYXAiKSB0byBwMm1fYWNjZXNzX3guIFByZXBhcmUgc2V0X2lk ZW50aXR5X3AybV9lbnRyeSgpIGFuZApwMm1fZ2V0X2lvbW11X2ZsYWdzKCkg Zm9yIGdldHRpbmcgcGFzc2VkIGFjY2VzcyB0eXBlcyBvdGhlciB0aGFuCnAy bV9hY2Nlc3NfcncgKGluIHRoZSBsYXR0ZXIgY2FzZSBqdXN0IGZvciBwMm1f bW1pb19kaXJlY3QgcmVxdWVzdHMpLgoKTm90ZSBhbHNvIHRoYXQsIHRvIGJl IG9uIHRoZSBzYWZlIHNpZGUsIGFuIG92ZXJsYXAgY2hlY2sgZ2V0cyBhZGRl ZCB0bwp0aGUgbWFpbiBsb29wIG9mIGlvbW11X2lkZW50aXR5X21hcHBpbmco KS4KClRoaXMgaXMgcGFydCBvZiBYU0EtMzc4LgoKU2lnbmVkLW9mZi1ieTog SmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpSZXZpZXdlZC1ieTog UGF1bCBEdXJyYW50IDxwYXVsQHhlbi5vcmc+Ci0tLQpUQkQ6IEluIHRoaXMg Y29udGV4dCAodGhlIGxhdGVzdCkgSSBxdWVzdGlvbiB3aGV0aGVyIGl0IGlz IGEgZ29vZCBpZGVhCiAgICAgZm9yIGNsZWFyX2lkZW50aXR5X3AybV9lbnRy eSgpIHRvIHJldHVybiBzdWNjZXNzIHdoZW4gaXQgZGlkbid0CiAgICAgY2xl YXIgdGhlIGVudHJ5IGJlY2F1c2Ugb2YgbWlzbWF0Y2hpbmcgdHlwZSBvciBN Rk4uClRCRDogUXVlc3Rpb24gaXMgd2hldGhlciBwMm1fZ2V0X2lvbW11X2Zs YWdzKCkgc2hvdWxkIGFwcGx5IHRoZSBhY2Nlc3MKICAgICByZXN0cmljdGlv biBpbiBhbGwgY2FzZXMsIG5vdCBqdXN0IGZvciBwMm1fbW1pb19kaXJlY3Qu ClRCRDogTmVpdGhlciBwb3NzaWJsZSBwbGFjZW1lbnQgb2YgcDJtX2FjY2Vz c19yeDJydyBhbmQgcDJtX2FjY2Vzc19uMnJ3eAogICAgIGluIHAybV9hY2Nl c3NfdG9faW9tbXVfZmxhZ3MoKSBsb29rcyBlbnRpcmVseSBjb3JyZWN0L3Nl bnNpYmxlLgotLS0Kdjk6IFJlLWJhc2UuCnY3OiBzL3VuaXR5X21hcC9pZGVu dGl0eV9tYXAvZy4gUmUtYmFzZS4KdjY6IFJlLWJhc2UuCnY1OiBOZXcuCgot LS0gYS94ZW4vYXJjaC94ODYvbW0vcDJtLmMKKysrIGIveGVuL2FyY2gveDg2 L21tL3AybS5jCkBAIC0xNDI3LDcgKzE0MjcsNyBAQCBpbnQgc2V0X2lkZW50 aXR5X3AybV9lbnRyeShzdHJ1Y3QgZG9tYWluCiAgICAgICAgICAgICByZXR1 cm4gMDsKICAgICAgICAgcmV0dXJuIGlvbW11X2xlZ2FjeV9tYXAoZCwgX2Rm bihnZm5fbCksIF9tZm4oZ2ZuX2wpLAogICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAxdWwgPDwgUEFHRV9PUkRFUl80SywKLSAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgSU9NTVVGX3JlYWRhYmxlIHwgSU9NTVVG X3dyaXRhYmxlKTsKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg cDJtX2FjY2Vzc190b19pb21tdV9mbGFncyhwMm1hKSk7CiAjaWZkZWYgQ09O RklHX0hWTQogICAgIH0KIAotLS0gYS94ZW4vZHJpdmVycy9wYXNzdGhyb3Vn aC92dGQvaW9tbXUuYworKysgYi94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC92 dGQvaW9tbXUuYwpAQCAtNDUsMTIgKzQ1LDYgQEAKIC8qIGRvbV9pbyBpcyB1 c2VkIGFzIGEgc2VudGluZWwgZm9yIHF1YXJhbnRpbmVkIGRldmljZXMgKi8K ICNkZWZpbmUgUVVBUkFOVElORV9TS0lQKGQpICgoZCkgPT0gZG9tX2lvICYm ICFkb21faW9tbXUoZCktPmFyY2gudnRkLnBnZF9tYWRkcikKIAotc3RydWN0 IG1hcHBlZF9ybXJyIHsKLSAgICBzdHJ1Y3QgbGlzdF9oZWFkIGxpc3Q7Ci0g ICAgdTY0IGJhc2UsIGVuZDsKLSAgICB1bnNpZ25lZCBpbnQgY291bnQ7Ci19 OwotCiAvKiBQb3NzaWJsZSB1bmZpbHRlcmVkIExBUElDL01TSSBtZXNzYWdl cyBmcm9tIHVudHJ1c3RlZCBzb3VyY2VzPyAqLwogYm9vbCBfX3JlYWRfbW9z dGx5IHVudHJ1c3RlZF9tc2k7CiAKQEAgLTEzMDYsNyArMTMwMCw2IEBAIHN0 YXRpYyBpbnQgaW50ZWxfaW9tbXVfZG9tYWluX2luaXQoc3RydWMKICAgICBz dHJ1Y3QgZG9tYWluX2lvbW11ICpoZCA9IGRvbV9pb21tdShkKTsKIAogICAg IGhkLT5hcmNoLnZ0ZC5hZ2F3ID0gd2lkdGhfdG9fYWdhdyhERUZBVUxUX0RP TUFJTl9BRERSRVNTX1dJRFRIKTsKLSAgICBJTklUX0xJU1RfSEVBRCgmaGQt PmFyY2gudnRkLm1hcHBlZF9ybXJycyk7CiAKICAgICByZXR1cm4gMDsKIH0K QEAgLTE3ODUsMTcgKzE3NzgsMTIgQEAgc3RhdGljIHZvaWQgaW9tbXVfY2xl YXJfcm9vdF9wZ3RhYmxlKHN0cgogc3RhdGljIHZvaWQgaW9tbXVfZG9tYWlu X3RlYXJkb3duKHN0cnVjdCBkb21haW4gKmQpCiB7CiAgICAgc3RydWN0IGRv bWFpbl9pb21tdSAqaGQgPSBkb21faW9tbXUoZCk7Ci0gICAgc3RydWN0IG1h cHBlZF9ybXJyICptcm1yciwgKnRtcDsKICAgICBjb25zdCBzdHJ1Y3QgYWNw aV9kcmhkX3VuaXQgKmRyaGQ7CiAKICAgICBpZiAoIGxpc3RfZW1wdHkoJmFj cGlfZHJoZF91bml0cykgKQogICAgICAgICByZXR1cm47CiAKLSAgICBsaXN0 X2Zvcl9lYWNoX2VudHJ5X3NhZmUgKCBtcm1yciwgdG1wLCAmaGQtPmFyY2gu dnRkLm1hcHBlZF9ybXJycywgbGlzdCApCi0gICAgewotICAgICAgICBsaXN0 X2RlbCgmbXJtcnItPmxpc3QpOwotICAgICAgICB4ZnJlZShtcm1ycik7Ci0g ICAgfQorICAgIGlvbW11X2lkZW50aXR5X21hcF90ZWFyZG93bihkKTsKIAog ICAgIEFTU0VSVCghaGQtPmFyY2gudnRkLnBnZF9tYWRkcik7CiAKQEAgLTE5 NDMsNzQgKzE5MzEsNiBAQCBzdGF0aWMgaW50IF9faW5pdCB2dGRfZXB0X3Bh Z2VfY29tcGF0aWJsCiAgICAgICAgICAgIChlcHRfaGFzXzFnYihlcHRfY2Fw KSAmJiBvcHRfaGFwXzFnYikgPD0gY2FwX3Nwc18xZ2IodnRkX2NhcCk7CiB9 CiAKLXN0YXRpYyBpbnQgcm1ycl9pZGVudGl0eV9tYXBwaW5nKHN0cnVjdCBk b21haW4gKmQsIGJvb2xfdCBtYXAsCi0gICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICBjb25zdCBzdHJ1Y3QgYWNwaV9ybXJyX3VuaXQgKnJtcnIs Ci0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB1MzIgZmxhZykK LXsKLSAgICB1bnNpZ25lZCBsb25nIGJhc2VfcGZuID0gcm1yci0+YmFzZV9h ZGRyZXNzID4+IFBBR0VfU0hJRlRfNEs7Ci0gICAgdW5zaWduZWQgbG9uZyBl bmRfcGZuID0gUEFHRV9BTElHTl80SyhybXJyLT5lbmRfYWRkcmVzcykgPj4g UEFHRV9TSElGVF80SzsKLSAgICBzdHJ1Y3QgbWFwcGVkX3JtcnIgKm1ybXJy OwotICAgIHN0cnVjdCBkb21haW5faW9tbXUgKmhkID0gZG9tX2lvbW11KGQp OwotCi0gICAgQVNTRVJUKHBjaWRldnNfbG9ja2VkKCkpOwotICAgIEFTU0VS VChybXJyLT5iYXNlX2FkZHJlc3MgPCBybXJyLT5lbmRfYWRkcmVzcyk7Ci0K LSAgICAvKgotICAgICAqIE5vIG5lZWQgdG8gYWNxdWlyZSBoZC0+YXJjaC5t YXBwaW5nX2xvY2s6IEJvdGggaW5zZXJ0aW9uIGFuZCByZW1vdmFsCi0gICAg ICogZ2V0IGRvbmUgd2hpbGUgaG9sZGluZyBwY2lkZXZzX2xvY2suCi0gICAg ICovCi0gICAgbGlzdF9mb3JfZWFjaF9lbnRyeSggbXJtcnIsICZoZC0+YXJj aC52dGQubWFwcGVkX3JtcnJzLCBsaXN0ICkKLSAgICB7Ci0gICAgICAgIGlm ICggbXJtcnItPmJhc2UgPT0gcm1yci0+YmFzZV9hZGRyZXNzICYmCi0gICAg ICAgICAgICAgbXJtcnItPmVuZCA9PSBybXJyLT5lbmRfYWRkcmVzcyApCi0g ICAgICAgIHsKLSAgICAgICAgICAgIGludCByZXQgPSAwOwotCi0gICAgICAg ICAgICBpZiAoIG1hcCApCi0gICAgICAgICAgICB7Ci0gICAgICAgICAgICAg ICAgKyttcm1yci0+Y291bnQ7Ci0gICAgICAgICAgICAgICAgcmV0dXJuIDA7 Ci0gICAgICAgICAgICB9Ci0KLSAgICAgICAgICAgIGlmICggLS1tcm1yci0+ Y291bnQgKQotICAgICAgICAgICAgICAgIHJldHVybiAwOwotCi0gICAgICAg ICAgICB3aGlsZSAoIGJhc2VfcGZuIDwgZW5kX3BmbiApCi0gICAgICAgICAg ICB7Ci0gICAgICAgICAgICAgICAgaWYgKCBjbGVhcl9pZGVudGl0eV9wMm1f ZW50cnkoZCwgYmFzZV9wZm4pICkKLSAgICAgICAgICAgICAgICAgICAgcmV0 ID0gLUVOWElPOwotICAgICAgICAgICAgICAgIGJhc2VfcGZuKys7Ci0gICAg ICAgICAgICB9Ci0KLSAgICAgICAgICAgIGxpc3RfZGVsKCZtcm1yci0+bGlz dCk7Ci0gICAgICAgICAgICB4ZnJlZShtcm1ycik7Ci0gICAgICAgICAgICBy ZXR1cm4gcmV0OwotICAgICAgICB9Ci0gICAgfQotCi0gICAgaWYgKCAhbWFw ICkKLSAgICAgICAgcmV0dXJuIC1FTk9FTlQ7Ci0KLSAgICB3aGlsZSAoIGJh c2VfcGZuIDwgZW5kX3BmbiApCi0gICAgewotICAgICAgICBpbnQgZXJyID0g c2V0X2lkZW50aXR5X3AybV9lbnRyeShkLCBiYXNlX3BmbiwgcDJtX2FjY2Vz c19ydywgZmxhZyk7Ci0KLSAgICAgICAgaWYgKCBlcnIgKQotICAgICAgICAg ICAgcmV0dXJuIGVycjsKLSAgICAgICAgYmFzZV9wZm4rKzsKLSAgICB9Ci0K LSAgICBtcm1yciA9IHhtYWxsb2Moc3RydWN0IG1hcHBlZF9ybXJyKTsKLSAg ICBpZiAoICFtcm1yciApCi0gICAgICAgIHJldHVybiAtRU5PTUVNOwotICAg IG1ybXJyLT5iYXNlID0gcm1yci0+YmFzZV9hZGRyZXNzOwotICAgIG1ybXJy LT5lbmQgPSBybXJyLT5lbmRfYWRkcmVzczsKLSAgICBtcm1yci0+Y291bnQg PSAxOwotICAgIGxpc3RfYWRkX3RhaWwoJm1ybXJyLT5saXN0LCAmaGQtPmFy Y2gudnRkLm1hcHBlZF9ybXJycyk7Ci0KLSAgICByZXR1cm4gMDsKLX0KLQog c3RhdGljIGludCBpbnRlbF9pb21tdV9hZGRfZGV2aWNlKHU4IGRldmZuLCBz dHJ1Y3QgcGNpX2RldiAqcGRldikKIHsKICAgICBzdHJ1Y3QgYWNwaV9ybXJy X3VuaXQgKnJtcnI7CkBAIC0yMDQyLDcgKzE5NjIsOSBAQCBzdGF0aWMgaW50 IGludGVsX2lvbW11X2FkZF9kZXZpY2UodTggZGV2CiAgICAgICAgICAgICAg KiBTaW5jZSBSTVJScyBhcmUgYWx3YXlzIHJlc2VydmVkIGluIHRoZSBlODIw IG1hcCBmb3IgdGhlIGhhcmR3YXJlCiAgICAgICAgICAgICAgKiBkb21haW4s IHRoZXJlIHNob3VsZG4ndCBiZSBhIGNvbmZsaWN0LgogICAgICAgICAgICAg ICovCi0gICAgICAgICAgICByZXQgPSBybXJyX2lkZW50aXR5X21hcHBpbmco cGRldi0+ZG9tYWluLCAxLCBybXJyLCAwKTsKKyAgICAgICAgICAgIHJldCA9 IGlvbW11X2lkZW50aXR5X21hcHBpbmcocGRldi0+ZG9tYWluLCBwMm1fYWNj ZXNzX3J3LAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICBybXJyLT5iYXNlX2FkZHJlc3MsIHJtcnItPmVuZF9hZGRyZXNzLAor ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAwKTsK ICAgICAgICAgICAgIGlmICggcmV0ICkKICAgICAgICAgICAgICAgICBkcHJp bnRrKFhFTkxPR19FUlIgVlREUFJFRklYLCAiZCVkOiBSTVJSIG1hcHBpbmcg ZmFpbGVkXG4iLAogICAgICAgICAgICAgICAgICAgICAgICAgcGRldi0+ZG9t YWluLT5kb21haW5faWQpOwpAQCAtMjA4Nyw3ICsyMDA5LDggQEAgc3RhdGlj IGludCBpbnRlbF9pb21tdV9yZW1vdmVfZGV2aWNlKHU4CiAgICAgICAgICAq IEFueSBmbGFnIGlzIG5vdGhpbmcgdG8gY2xlYXIgdGhlc2UgbWFwcGluZ3Mg YnV0IGhlcmUKICAgICAgICAgICogaXRzIGFsd2F5cyBzYWZlIGFuZCBzdHJp Y3QgdG8gc2V0IDAuCiAgICAgICAgICAqLwotICAgICAgICBybXJyX2lkZW50 aXR5X21hcHBpbmcocGRldi0+ZG9tYWluLCAwLCBybXJyLCAwKTsKKyAgICAg ICAgaW9tbXVfaWRlbnRpdHlfbWFwcGluZyhwZGV2LT5kb21haW4sIHAybV9h Y2Nlc3NfeCwgcm1yci0+YmFzZV9hZGRyZXNzLAorICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIHJtcnItPmVuZF9hZGRyZXNzLCAwKTsKICAgICB9 CiAKICAgICByZXR1cm4gZG9tYWluX2NvbnRleHRfdW5tYXAocGRldi0+ZG9t YWluLCBkZXZmbiwgcGRldik7CkBAIC0yMjg2LDcgKzIyMDksOCBAQCBzdGF0 aWMgdm9pZCBfX2h3ZG9tX2luaXQgc2V0dXBfaHdkb21fcm1yCiAgICAgICAg ICAqIGRvbWFpbiwgdGhlcmUgc2hvdWxkbid0IGJlIGEgY29uZmxpY3QuIFNv IGl0cyBhbHdheXMgc2FmZSBhbmQKICAgICAgICAgICogc3RyaWN0IHRvIHNl dCAwLgogICAgICAgICAgKi8KLSAgICAgICAgcmV0ID0gcm1ycl9pZGVudGl0 eV9tYXBwaW5nKGQsIDEsIHJtcnIsIDApOworICAgICAgICByZXQgPSBpb21t dV9pZGVudGl0eV9tYXBwaW5nKGQsIHAybV9hY2Nlc3NfcncsIHJtcnItPmJh c2VfYWRkcmVzcywKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICBybXJyLT5lbmRfYWRkcmVzcywgMCk7CiAgICAgICAgIGlmICggcmV0 ICkKICAgICAgICAgICAgIGRwcmludGsoWEVOTE9HX0VSUiBWVERQUkVGSVgs CiAgICAgICAgICAgICAgICAgICAgICAiSU9NTVU6IG1hcHBpbmcgcmVzZXJ2 ZWQgcmVnaW9uIGZhaWxlZFxuIik7CkBAIC0yNDY4LDcgKzIzOTIsOSBAQCBz dGF0aWMgaW50IHJlYXNzaWduX2RldmljZV9vd25lcnNoaXAoCiAgICAgICAg ICAgICAgICAgICogQW55IFJNUlIgZmxhZyBpcyBhbHdheXMgaWdub3JlZCB3 aGVuIHJlbW92ZSBhIGRldmljZSwKICAgICAgICAgICAgICAgICAgKiBidXQg aXRzIGFsd2F5cyBzYWZlIGFuZCBzdHJpY3QgdG8gc2V0IDAuCiAgICAgICAg ICAgICAgICAgICovCi0gICAgICAgICAgICAgICAgcmV0ID0gcm1ycl9pZGVu dGl0eV9tYXBwaW5nKHNvdXJjZSwgMCwgcm1yciwgMCk7CisgICAgICAgICAg ICAgICAgcmV0ID0gaW9tbXVfaWRlbnRpdHlfbWFwcGluZyhzb3VyY2UsIHAy bV9hY2Nlc3NfeCwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIHJtcnItPmJhc2VfYWRkcmVzcywKKyAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHJtcnItPmVuZF9h ZGRyZXNzLCAwKTsKICAgICAgICAgICAgICAgICBpZiAoIHJldCAhPSAtRU5P RU5UICkKICAgICAgICAgICAgICAgICAgICAgcmV0dXJuIHJldDsKICAgICAg ICAgICAgIH0KQEAgLTI1NjQsNyArMjQ5MCw4IEBAIHN0YXRpYyBpbnQgaW50 ZWxfaW9tbXVfYXNzaWduX2RldmljZSgKICAgICAgICAgICAgICBQQ0lfQlVT KGJkZikgPT0gYnVzICYmCiAgICAgICAgICAgICAgUENJX0RFVkZOMihiZGYp ID09IGRldmZuICkKICAgICAgICAgewotICAgICAgICAgICAgcmV0ID0gcm1y cl9pZGVudGl0eV9tYXBwaW5nKGQsIDEsIHJtcnIsIGZsYWcpOworICAgICAg ICAgICAgcmV0ID0gaW9tbXVfaWRlbnRpdHlfbWFwcGluZyhkLCBwMm1fYWNj ZXNzX3J3LCBybXJyLT5iYXNlX2FkZHJlc3MsCisgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIHJtcnItPmVuZF9hZGRyZXNzLCBm bGFnKTsKICAgICAgICAgICAgIGlmICggcmV0ICkKICAgICAgICAgICAgIHsK ICAgICAgICAgICAgICAgICBpbnQgcmM7Ci0tLSBhL3hlbi9kcml2ZXJzL3Bh c3N0aHJvdWdoL3g4Ni9pb21tdS5jCisrKyBiL3hlbi9kcml2ZXJzL3Bhc3N0 aHJvdWdoL3g4Ni9pb21tdS5jCkBAIC0xNDQsNiArMTQ0LDcgQEAgaW50IGFy Y2hfaW9tbXVfZG9tYWluX2luaXQoc3RydWN0IGRvbWFpbgogCiAgICAgSU5J VF9QQUdFX0xJU1RfSEVBRCgmaGQtPmFyY2gucGd0YWJsZXMubGlzdCk7CiAg ICAgc3Bpbl9sb2NrX2luaXQoJmhkLT5hcmNoLnBndGFibGVzLmxvY2spOwor ICAgIElOSVRfTElTVF9IRUFEKCZoZC0+YXJjaC5pZGVudGl0eV9tYXBzKTsK IAogICAgIHJldHVybiAwOwogfQpAQCAtMTU5LDYgKzE2MCw5OSBAQCB2b2lk IGFyY2hfaW9tbXVfZG9tYWluX2Rlc3Ryb3koc3RydWN0IGRvCiAgICAgICAg ICAgIHBhZ2VfbGlzdF9lbXB0eSgmZG9tX2lvbW11KGQpLT5hcmNoLnBndGFi bGVzLmxpc3QpKTsKIH0KIAorc3RydWN0IGlkZW50aXR5X21hcCB7CisgICAg c3RydWN0IGxpc3RfaGVhZCBsaXN0OworICAgIHBhZGRyX3QgYmFzZSwgZW5k OworICAgIHAybV9hY2Nlc3NfdCBhY2Nlc3M7CisgICAgdW5zaWduZWQgaW50 IGNvdW50OworfTsKKworaW50IGlvbW11X2lkZW50aXR5X21hcHBpbmcoc3Ry dWN0IGRvbWFpbiAqZCwgcDJtX2FjY2Vzc190IHAybWEsCisgICAgICAgICAg ICAgICAgICAgICAgICAgICBwYWRkcl90IGJhc2UsIHBhZGRyX3QgZW5kLAor ICAgICAgICAgICAgICAgICAgICAgICAgICAgdW5zaWduZWQgaW50IGZsYWcp Cit7CisgICAgdW5zaWduZWQgbG9uZyBiYXNlX3BmbiA9IGJhc2UgPj4gUEFH RV9TSElGVF80SzsKKyAgICB1bnNpZ25lZCBsb25nIGVuZF9wZm4gPSBQQUdF X0FMSUdOXzRLKGVuZCkgPj4gUEFHRV9TSElGVF80SzsKKyAgICBzdHJ1Y3Qg aWRlbnRpdHlfbWFwICptYXA7CisgICAgc3RydWN0IGRvbWFpbl9pb21tdSAq aGQgPSBkb21faW9tbXUoZCk7CisKKyAgICBBU1NFUlQocGNpZGV2c19sb2Nr ZWQoKSk7CisgICAgQVNTRVJUKGJhc2UgPCBlbmQpOworCisgICAgLyoKKyAg ICAgKiBObyBuZWVkIHRvIGFjcXVpcmUgaGQtPmFyY2gubWFwcGluZ19sb2Nr OiBCb3RoIGluc2VydGlvbiBhbmQgcmVtb3ZhbAorICAgICAqIGdldCBkb25l IHdoaWxlIGhvbGRpbmcgcGNpZGV2c19sb2NrLgorICAgICAqLworICAgIGxp c3RfZm9yX2VhY2hfZW50cnkoIG1hcCwgJmhkLT5hcmNoLmlkZW50aXR5X21h cHMsIGxpc3QgKQorICAgIHsKKyAgICAgICAgaWYgKCBtYXAtPmJhc2UgPT0g YmFzZSAmJiBtYXAtPmVuZCA9PSBlbmQgKQorICAgICAgICB7CisgICAgICAg ICAgICBpbnQgcmV0ID0gMDsKKworICAgICAgICAgICAgaWYgKCBwMm1hICE9 IHAybV9hY2Nlc3NfeCApCisgICAgICAgICAgICB7CisgICAgICAgICAgICAg ICAgaWYgKCBtYXAtPmFjY2VzcyAhPSBwMm1hICkKKyAgICAgICAgICAgICAg ICAgICAgcmV0dXJuIC1FQUREUklOVVNFOworICAgICAgICAgICAgICAgICsr bWFwLT5jb3VudDsKKyAgICAgICAgICAgICAgICByZXR1cm4gMDsKKyAgICAg ICAgICAgIH0KKworICAgICAgICAgICAgaWYgKCAtLW1hcC0+Y291bnQgKQor ICAgICAgICAgICAgICAgIHJldHVybiAwOworCisgICAgICAgICAgICB3aGls ZSAoIGJhc2VfcGZuIDwgZW5kX3BmbiApCisgICAgICAgICAgICB7CisgICAg ICAgICAgICAgICAgaWYgKCBjbGVhcl9pZGVudGl0eV9wMm1fZW50cnkoZCwg YmFzZV9wZm4pICkKKyAgICAgICAgICAgICAgICAgICAgcmV0ID0gLUVOWElP OworICAgICAgICAgICAgICAgIGJhc2VfcGZuKys7CisgICAgICAgICAgICB9 CisKKyAgICAgICAgICAgIGxpc3RfZGVsKCZtYXAtPmxpc3QpOworICAgICAg ICAgICAgeGZyZWUobWFwKTsKKworICAgICAgICAgICAgcmV0dXJuIHJldDsK KyAgICAgICAgfQorCisgICAgICAgIGlmICggZW5kID49IG1hcC0+YmFzZSAm JiBtYXAtPmVuZCA+PSBiYXNlICkKKyAgICAgICAgICAgIHJldHVybiAtRUFE RFJJTlVTRTsKKyAgICB9CisKKyAgICBpZiAoIHAybWEgPT0gcDJtX2FjY2Vz c194ICkKKyAgICAgICAgcmV0dXJuIC1FTk9FTlQ7CisKKyAgICB3aGlsZSAo IGJhc2VfcGZuIDwgZW5kX3BmbiApCisgICAgeworICAgICAgICBpbnQgZXJy ID0gc2V0X2lkZW50aXR5X3AybV9lbnRyeShkLCBiYXNlX3BmbiwgcDJtYSwg ZmxhZyk7CisKKyAgICAgICAgaWYgKCBlcnIgKQorICAgICAgICAgICAgcmV0 dXJuIGVycjsKKyAgICAgICAgYmFzZV9wZm4rKzsKKyAgICB9CisKKyAgICBt YXAgPSB4bWFsbG9jKHN0cnVjdCBpZGVudGl0eV9tYXApOworICAgIGlmICgg IW1hcCApCisgICAgICAgIHJldHVybiAtRU5PTUVNOworICAgIG1hcC0+YmFz ZSA9IGJhc2U7CisgICAgbWFwLT5lbmQgPSBlbmQ7CisgICAgbWFwLT5hY2Nl c3MgPSBwMm1hOworICAgIG1hcC0+Y291bnQgPSAxOworICAgIGxpc3RfYWRk X3RhaWwoJm1hcC0+bGlzdCwgJmhkLT5hcmNoLmlkZW50aXR5X21hcHMpOwor CisgICAgcmV0dXJuIDA7Cit9CisKK3ZvaWQgaW9tbXVfaWRlbnRpdHlfbWFw X3RlYXJkb3duKHN0cnVjdCBkb21haW4gKmQpCit7CisgICAgc3RydWN0IGRv bWFpbl9pb21tdSAqaGQgPSBkb21faW9tbXUoZCk7CisgICAgc3RydWN0IGlk ZW50aXR5X21hcCAqbWFwLCAqdG1wOworCisgICAgbGlzdF9mb3JfZWFjaF9l bnRyeV9zYWZlICggbWFwLCB0bXAsICZoZC0+YXJjaC5pZGVudGl0eV9tYXBz LCBsaXN0ICkKKyAgICB7CisgICAgICAgIGxpc3RfZGVsKCZtYXAtPmxpc3Qp OworICAgICAgICB4ZnJlZShtYXApOworICAgIH0KK30KKwogc3RhdGljIGJv b2wgX19od2RvbV9pbml0IGh3ZG9tX2lvbW11X21hcChjb25zdCBzdHJ1Y3Qg ZG9tYWluICpkLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICB1bnNpZ25lZCBsb25nIHBmbiwKICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgdW5zaWduZWQgbG9uZyBtYXhfcGZu KQotLS0gYS94ZW4vaW5jbHVkZS9hc20teDg2L2lvbW11LmgKKysrIGIveGVu L2luY2x1ZGUvYXNtLXg4Ni9pb21tdS5oCkBAIC0xNiw2ICsxNiw3IEBACiAK ICNpbmNsdWRlIDx4ZW4vZXJybm8uaD4KICNpbmNsdWRlIDx4ZW4vbGlzdC5o PgorI2luY2x1ZGUgPHhlbi9tZW1fYWNjZXNzLmg+CiAjaW5jbHVkZSA8eGVu L3NwaW5sb2NrLmg+CiAjaW5jbHVkZSA8YXNtL2FwaWNkZWYuaD4KICNpbmNs dWRlIDxhc20vcHJvY2Vzc29yLmg+CkBAIC01MCwxMyArNTEsMTQgQEAgc3Ry dWN0IGFyY2hfaW9tbXUKICAgICAgICAgc3BpbmxvY2tfdCBsb2NrOwogICAg IH0gcGd0YWJsZXM7CiAKKyAgICBzdHJ1Y3QgbGlzdF9oZWFkIGlkZW50aXR5 X21hcHM7CisKICAgICB1bmlvbiB7CiAgICAgICAgIC8qIEludGVsIFZULWQg Ki8KICAgICAgICAgc3RydWN0IHsKICAgICAgICAgICAgIHVpbnQ2NF90IHBn ZF9tYWRkcjsgLyogaW8gcGFnZSBkaXJlY3RvcnkgbWFjaGluZSBhZGRyZXNz ICovCiAgICAgICAgICAgICB1bnNpZ25lZCBpbnQgYWdhdzsgLyogYWRqdXN0 ZWQgZ3Vlc3QgYWRkcmVzcyB3aWR0aCwgMCBpcyBsZXZlbCAyIDMwLWJpdCAq LwogICAgICAgICAgICAgdWludDY0X3QgaW9tbXVfYml0bWFwOyAvKiBiaXRt YXAgb2YgaW9tbXUocykgdGhhdCB0aGUgZG9tYWluIHVzZXMgKi8KLSAgICAg ICAgICAgIHN0cnVjdCBsaXN0X2hlYWQgbWFwcGVkX3JtcnJzOwogICAgICAg ICB9IHZ0ZDsKICAgICAgICAgLyogQU1EIElPTU1VICovCiAgICAgICAgIHN0 cnVjdCB7CkBAIC0xMjIsNiArMTI0LDExIEBAIHN0YXRpYyBpbmxpbmUgdm9p ZCBpb21tdV9kaXNhYmxlX3gyYXBpYygKICAgICAgICAgaW9tbXVfb3BzLmRp c2FibGVfeDJhcGljKCk7CiB9CiAKK2ludCBpb21tdV9pZGVudGl0eV9tYXBw aW5nKHN0cnVjdCBkb21haW4gKmQsIHAybV9hY2Nlc3NfdCBwMm1hLAorICAg ICAgICAgICAgICAgICAgICAgICAgICAgcGFkZHJfdCBiYXNlLCBwYWRkcl90 IGVuZCwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgIHVuc2lnbmVkIGlu dCBmbGFnKTsKK3ZvaWQgaW9tbXVfaWRlbnRpdHlfbWFwX3RlYXJkb3duKHN0 cnVjdCBkb21haW4gKmQpOworCiBleHRlcm4gYm9vbCB1bnRydXN0ZWRfbXNp OwogCiBpbnQgcGlfdXBkYXRlX2lydGUoY29uc3Qgc3RydWN0IHBpX2Rlc2Mg KnBpX2Rlc2MsIGNvbnN0IHN0cnVjdCBwaXJxICpwaXJxLAotLS0gYS94ZW4v aW5jbHVkZS9hc20teDg2L3AybS5oCisrKyBiL3hlbi9pbmNsdWRlL2FzbS14 ODYvcDJtLmgKQEAgLTg4OCw2ICs4ODgsMzQgQEAgc3RydWN0IHAybV9kb21h aW4gKnAybV9nZXRfYWx0cDJtKHN0cnVjdAogc3RhdGljIGlubGluZSB2b2lk IHAybV9hbHRwMm1fY2hlY2soc3RydWN0IHZjcHUgKnYsIHVpbnQxNl90IGlk eCkge30KICNlbmRpZgogCisvKiBwMm0gYWNjZXNzIHRvIElPTU1VIGZsYWdz ICovCitzdGF0aWMgaW5saW5lIHVuc2lnbmVkIGludCBwMm1fYWNjZXNzX3Rv X2lvbW11X2ZsYWdzKHAybV9hY2Nlc3NfdCBwMm1hKQoreworICAgIHN3aXRj aCAoIHAybWEgKQorICAgIHsKKyAgICBjYXNlIHAybV9hY2Nlc3Nfcnc6Cisg ICAgY2FzZSBwMm1fYWNjZXNzX3J3eDoKKyAgICAgICAgcmV0dXJuIElPTU1V Rl9yZWFkYWJsZSB8IElPTU1VRl93cml0YWJsZTsKKworICAgIGNhc2UgcDJt X2FjY2Vzc19yOgorICAgIGNhc2UgcDJtX2FjY2Vzc19yeDoKKyAgICBjYXNl IHAybV9hY2Nlc3Nfcngycnc6CisgICAgICAgIHJldHVybiBJT01NVUZfcmVh ZGFibGU7CisKKyAgICBjYXNlIHAybV9hY2Nlc3NfdzoKKyAgICBjYXNlIHAy bV9hY2Nlc3Nfd3g6CisgICAgICAgIHJldHVybiBJT01NVUZfd3JpdGFibGU7 CisKKyAgICBjYXNlIHAybV9hY2Nlc3NfbjoKKyAgICBjYXNlIHAybV9hY2Nl c3NfeDoKKyAgICBjYXNlIHAybV9hY2Nlc3NfbjJyd3g6CisgICAgICAgIHJl dHVybiAwOworICAgIH0KKworICAgIEFTU0VSVF9VTlJFQUNIQUJMRSgpOwor ICAgIHJldHVybiAwOworfQorCiAvKgogICogcDJtIHR5cGUgdG8gSU9NTVUg ZmxhZ3MKICAqLwpAQCAtOTA5LDkgKzkzNywxMCBAQCBzdGF0aWMgaW5saW5l IHVuc2lnbmVkIGludCBwMm1fZ2V0X2lvbW11CiAgICAgICAgIGZsYWdzID0g SU9NTVVGX3JlYWRhYmxlOwogICAgICAgICBicmVhazsKICAgICBjYXNlIHAy bV9tbWlvX2RpcmVjdDoKLSAgICAgICAgZmxhZ3MgPSBJT01NVUZfcmVhZGFi bGU7Ci0gICAgICAgIGlmICggIXJhbmdlc2V0X2NvbnRhaW5zX3NpbmdsZXRv bihtbWlvX3JvX3JhbmdlcywgbWZuX3gobWZuKSkgKQotICAgICAgICAgICAg ZmxhZ3MgfD0gSU9NTVVGX3dyaXRhYmxlOworICAgICAgICBmbGFncyA9IHAy bV9hY2Nlc3NfdG9faW9tbXVfZmxhZ3MocDJtYSk7CisgICAgICAgIGlmICgg KGZsYWdzICYgSU9NTVVGX3dyaXRhYmxlKSAmJgorICAgICAgICAgICAgIHJh bmdlc2V0X2NvbnRhaW5zX3NpbmdsZXRvbihtbWlvX3JvX3JhbmdlcywgbWZu X3gobWZuKSkgKQorICAgICAgICAgICAgZmxhZ3MgJj0gfklPTU1VRl93cml0 YWJsZTsKICAgICAgICAgYnJlYWs7CiAgICAgZGVmYXVsdDoKICAgICAgICAg ZmxhZ3MgPSAwOwo= --=separator Content-Type: application/octet-stream; name="xsa378/xsa378-5.patch" Content-Disposition: attachment; filename="xsa378/xsa378-5.patch" Content-Transfer-Encoding: base64 RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0 OiBBTUQvSU9NTVU6IHJlLWFycmFuZ2UvY29tcGxldGUgcmUtYXNzaWdubWVu dCBoYW5kbGluZwoKUHJpb3IgdG8gdGhlIGFzc2lnbm1lbnQgc3RlcCBoYXZp bmcgY29tcGxldGVkIHN1Y2Nlc3NmdWxseSwgZGV2aWNlcwpzaG91bGQgbm90 IGdldCBhc3NvY2lhdGVkIHdpdGggdGhlaXIgbmV3IG93bmVyLiBIYW5kIHRo ZSBkZXZpY2UgdG8gRG9tSU8KKHBlcmhhcHMgdGVtcG9yYXJpbHkpLCB1bnRp bCBhZnRlciB0aGUgZGUtYXNzaWdubWVudCBzdGVwIGhhcyBjb21wbGV0ZWQu CgpEZS1hc3NpZ25tZW50IG9mIGEgZGV2aWNlIChmcm9tIG90aGVyIHRoYW4g RG9tMCkgYXMgd2VsbCBhcyBmYWlsdXJlIG9mCnJlYXNzaWduX2RldmljZSgp IGR1cmluZyBhc3NpZ25tZW50IHNob3VsZCByZXN1bHQgaW4gdW5pdHkgbWFw cGluZ3MKZ2V0dGluZyB0b3JuIGRvd24uIFRoaXMgaW4gdHVybiByZXF1aXJl cyBzd2l0Y2hpbmcgdG8gYSByZWZjb3VudGVkCm1hcHBpbmcgYXBwcm9hY2gs IGFzIHdhcyBhbHJlYWR5IHVzZWQgYnkgVlQtZCBmb3IgaXRzIFJNUlJzLCB0 byBwcmV2ZW50CnVubWFwcGluZyBhIHJlZ2lvbiB1c2VkIGJ5IG11bHRpcGxl IGRldmljZXMuCgpUaGlzIGlzIENWRS0yMDIxLTI4Njk2IC8gcGFydCBvZiBY U0EtMzc4LgoKU2lnbmVkLW9mZi1ieTogSmFuIEJldWxpY2ggPGpiZXVsaWNo QHN1c2UuY29tPgpSZXZpZXdlZC1ieTogUGF1bCBEdXJyYW50IDxwYXVsQHhl bi5vcmc+Ci0tLQp2OTogUmUtYmFzZS4Kdjc6IFJlLWJhc2UuCnY2OiBSZS1i YXNlLgp2NTogU3dpdGNoIHRvIHVzaW5nIGlvbW11X2lkZW50aXR5X21hcHBp bmcoKS4gQWxzbyB1bm1hcCgpIHdoZW4gYW55CiAgICBtYXAoKSBmYWlscyBp biBhbWRfaW9tbXVfYXNzaWduX2RldmljZSgpLCB1bmxlc3MgaXQncyBEb20w LiBSZS1iYXNlLgp2NDogVXNlIGRhZGRyX3RvX2RmbigpLiBEcm9wIHN0cmF5 IGJsYW5rIGxpbmUuIERvbid0IGV2ZXIgdW5tYXAgZnJvbQogICAgRG9tMC4K djM6IFVzZSBEb21JTyBpbnN0ZWFkIG9mIERvbVhFTi4KdjI6IFJlLWJhc2Ug b3ZlciBYU0EtMzAyLgoKLS0tIGEveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gv YW1kL2lvbW11LmgKKysrIGIveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvYW1k L2lvbW11LmgKQEAgLTIzMiw4ICsyMzIsMTAgQEAgaW50IF9fbXVzdF9jaGVj ayBhbWRfaW9tbXVfdW5tYXBfcGFnZShzdAogICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICB1bnNpZ25lZCBpbnQgKmZsdXNoX2ZsYWdz KTsKIGludCBfX211c3RfY2hlY2sgYW1kX2lvbW11X2FsbG9jX3Jvb3Qoc3Ry dWN0IGRvbWFpbiAqZCk7CiBpbnQgYW1kX2lvbW11X3Jlc2VydmVfZG9tYWlu X3VuaXR5X21hcChzdHJ1Y3QgZG9tYWluICpkb21haW4sCi0gICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBwYWRkcl90IHBoeXNfYWRk ciwgdW5zaWduZWQgbG9uZyBzaXplLAotICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgaW50IGl3LCBpbnQgaXIpOworICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgY29uc3Qgc3RydWN0IGl2 cnNfdW5pdHlfbWFwICptYXAsCisgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICB1bnNpZ25lZCBpbnQgZmxhZyk7CitpbnQgYW1kX2lv bW11X3Jlc2VydmVfZG9tYWluX3VuaXR5X3VubWFwKHN0cnVjdCBkb21haW4g KmQsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IGNvbnN0IHN0cnVjdCBpdnJzX3VuaXR5X21hcCAqbWFwKTsKIGludCBfX211 c3RfY2hlY2sgYW1kX2lvbW11X2ZsdXNoX2lvdGxiX3BhZ2VzKHN0cnVjdCBk b21haW4gKmQsIGRmbl90IGRmbiwKICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIHVuc2lnbmVkIGxvbmcgcGFnZV9jb3Vu dCwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIHVuc2lnbmVkIGludCBmbHVzaF9mbGFncyk7Ci0tLSBhL3hlbi9kcml2 ZXJzL3Bhc3N0aHJvdWdoL2FtZC9pb21tdV9tYXAuYworKysgYi94ZW4vZHJp dmVycy9wYXNzdGhyb3VnaC9hbWQvaW9tbXVfbWFwLmMKQEAgLTQxOSwzOCAr NDE5LDQ5IEBAIGludCBhbWRfaW9tbXVfZmx1c2hfaW90bGJfYWxsKHN0cnVj dCBkb20KICAgICByZXR1cm4gMDsKIH0KIAotaW50IGFtZF9pb21tdV9yZXNl cnZlX2RvbWFpbl91bml0eV9tYXAoc3RydWN0IGRvbWFpbiAqZG9tYWluLAot ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcGFkZHJf dCBwaHlzX2FkZHIsCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICB1bnNpZ25lZCBsb25nIHNpemUsIGludCBpdywgaW50IGlyKQor aW50IGFtZF9pb21tdV9yZXNlcnZlX2RvbWFpbl91bml0eV9tYXAoc3RydWN0 IGRvbWFpbiAqZCwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIGNvbnN0IHN0cnVjdCBpdnJzX3VuaXR5X21hcCAqbWFwLAorICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdW5zaWduZWQg aW50IGZsYWcpCiB7Ci0gICAgdW5zaWduZWQgbG9uZyBucGFnZXMsIGk7Ci0g ICAgdW5zaWduZWQgbG9uZyBnZm47Ci0gICAgdW5zaWduZWQgaW50IGZsYWdz ID0gISFpcjsKLSAgICB1bnNpZ25lZCBpbnQgZmx1c2hfZmxhZ3MgPSAwOwot ICAgIGludCBydCA9IDA7Ci0KLSAgICBpZiAoIGl3ICkKLSAgICAgICAgZmxh Z3MgfD0gSU9NTVVGX3dyaXRhYmxlOwotCi0gICAgbnBhZ2VzID0gcmVnaW9u X3RvX3BhZ2VzKHBoeXNfYWRkciwgc2l6ZSk7Ci0gICAgZ2ZuID0gcGh5c19h ZGRyID4+IFBBR0VfU0hJRlQ7Ci0gICAgZm9yICggaSA9IDA7IGkgPCBucGFn ZXM7IGkrKyApCisgICAgaW50IHJjOworCisgICAgaWYgKCBkID09IGRvbV9p byApCisgICAgICAgIHJldHVybiAwOworCisgICAgZm9yICggcmMgPSAwOyAh cmMgJiYgbWFwOyBtYXAgPSBtYXAtPm5leHQgKQogICAgIHsKLSAgICAgICAg dW5zaWduZWQgbG9uZyBmcmFtZSA9IGdmbiArIGk7CisgICAgICAgIHAybV9h Y2Nlc3NfdCBwMm1hID0gcDJtX2FjY2Vzc19uOworCisgICAgICAgIGlmICgg bWFwLT5yZWFkICkKKyAgICAgICAgICAgIHAybWEgfD0gcDJtX2FjY2Vzc19y OworICAgICAgICBpZiAoIG1hcC0+d3JpdGUgKQorICAgICAgICAgICAgcDJt YSB8PSBwMm1fYWNjZXNzX3c7CiAKLSAgICAgICAgcnQgPSBhbWRfaW9tbXVf bWFwX3BhZ2UoZG9tYWluLCBfZGZuKGZyYW1lKSwgX21mbihmcmFtZSksIGZs YWdzLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAmZmx1c2hf ZmxhZ3MpOwotICAgICAgICBpZiAoIHJ0ICE9IDAgKQotICAgICAgICAgICAg YnJlYWs7CisgICAgICAgIHJjID0gaW9tbXVfaWRlbnRpdHlfbWFwcGluZyhk LCBwMm1hLCBtYXAtPmFkZHIsCisgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICBtYXAtPmFkZHIgKyBtYXAtPmxlbmd0aCAtIDEsIGZsYWcp OwogICAgIH0KIAotICAgIC8qIFVzZSB3aGlsZS1icmVhayB0byBhdm9pZCBj b21waWxlciB3YXJuaW5nICovCi0gICAgd2hpbGUgKCBmbHVzaF9mbGFncyAm JgotICAgICAgICAgICAgYW1kX2lvbW11X2ZsdXNoX2lvdGxiX3BhZ2VzKGRv bWFpbiwgX2RmbihnZm4pLAotICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIG5wYWdlcywgZmx1c2hfZmxhZ3MpICkKLSAgICAgICAg YnJlYWs7CisgICAgcmV0dXJuIHJjOworfQorCitpbnQgYW1kX2lvbW11X3Jl c2VydmVfZG9tYWluX3VuaXR5X3VubWFwKHN0cnVjdCBkb21haW4gKmQsCisg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNvbnN0 IHN0cnVjdCBpdnJzX3VuaXR5X21hcCAqbWFwKQoreworICAgIGludCByYzsK KworICAgIGlmICggZCA9PSBkb21faW8gKQorICAgICAgICByZXR1cm4gMDsK KworICAgIGZvciAoIHJjID0gMDsgbWFwOyBtYXAgPSBtYXAtPm5leHQgKQor ICAgIHsKKyAgICAgICAgaW50IHJldCA9IGlvbW11X2lkZW50aXR5X21hcHBp bmcoZCwgcDJtX2FjY2Vzc194LCBtYXAtPmFkZHIsCisgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIG1hcC0+YWRkciArIG1hcC0+ bGVuZ3RoIC0gMSwgMCk7CisKKyAgICAgICAgaWYgKCByZXQgJiYgcmV0ICE9 IC1FTk9FTlQgJiYgIXJjICkKKyAgICAgICAgICAgIHJjID0gcmV0OworICAg IH0KIAotICAgIHJldHVybiBydDsKKyAgICByZXR1cm4gcmM7CiB9CiAKIGlu dCBfX2luaXQgYW1kX2lvbW11X3F1YXJhbnRpbmVfaW5pdChzdHJ1Y3QgZG9t YWluICpkKQotLS0gYS94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC9hbWQvcGNp X2FtZF9pb21tdS5jCisrKyBiL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL2Ft ZC9wY2lfYW1kX2lvbW11LmMKQEAgLTM0Nyw2ICszNDcsNyBAQCBzdGF0aWMg aW50IHJlYXNzaWduX2RldmljZShzdHJ1Y3QgZG9tYWluCiB7CiAgICAgc3Ry dWN0IGFtZF9pb21tdSAqaW9tbXU7CiAgICAgaW50IGJkZiwgcmM7CisgICAg Y29uc3Qgc3RydWN0IGl2cnNfbWFwcGluZ3MgKml2cnNfbWFwcGluZ3MgPSBn ZXRfaXZyc19tYXBwaW5ncyhwZGV2LT5zZWcpOwogCiAgICAgYmRmID0gUENJ X0JERjIocGRldi0+YnVzLCBwZGV2LT5kZXZmbik7CiAgICAgaW9tbXUgPSBm aW5kX2lvbW11X2Zvcl9kZXZpY2UocGRldi0+c2VnLCBiZGYpOwpAQCAtMzYx LDEwICszNjIsMjQgQEAgc3RhdGljIGludCByZWFzc2lnbl9kZXZpY2Uoc3Ry dWN0IGRvbWFpbgogCiAgICAgYW1kX2lvbW11X2Rpc2FibGVfZG9tYWluX2Rl dmljZShzb3VyY2UsIGlvbW11LCBkZXZmbiwgcGRldik7CiAKLSAgICBpZiAo IGRldmZuID09IHBkZXYtPmRldmZuICkKKyAgICAvKgorICAgICAqIElmIHRo ZSBkZXZpY2UgYmVsb25ncyB0byB0aGUgaGFyZHdhcmUgZG9tYWluLCBhbmQg aXQgaGFzIGEgdW5pdHkgbWFwcGluZywKKyAgICAgKiBkb24ndCByZW1vdmUg aXQgZnJvbSB0aGUgaGFyZHdhcmUgZG9tYWluLCBiZWNhdXNlIEJJT1MgbWF5 IHJlZmVyZW5jZSB0aGF0CisgICAgICogbWFwcGluZy4KKyAgICAgKi8KKyAg ICBpZiAoICFpc19oYXJkd2FyZV9kb21haW4oc291cmNlKSApCiAgICAgewot ICAgICAgICBsaXN0X21vdmUoJnBkZXYtPmRvbWFpbl9saXN0LCAmdGFyZ2V0 LT5wZGV2X2xpc3QpOwotICAgICAgICBwZGV2LT5kb21haW4gPSB0YXJnZXQ7 CisgICAgICAgIHJjID0gYW1kX2lvbW11X3Jlc2VydmVfZG9tYWluX3VuaXR5 X3VubWFwKAorICAgICAgICAgICAgICAgICBzb3VyY2UsCisgICAgICAgICAg ICAgICAgIGl2cnNfbWFwcGluZ3NbZ2V0X2RtYV9yZXF1ZXN0b3JfaWQocGRl di0+c2VnLCBiZGYpXS51bml0eV9tYXApOworICAgICAgICBpZiAoIHJjICkK KyAgICAgICAgICAgIHJldHVybiByYzsKKyAgICB9CisKKyAgICBpZiAoIGRl dmZuID09IHBkZXYtPmRldmZuICYmIHBkZXYtPmRvbWFpbiAhPSBkb21faW8g KQorICAgIHsKKyAgICAgICAgbGlzdF9tb3ZlKCZwZGV2LT5kb21haW5fbGlz dCwgJmRvbV9pby0+cGRldl9saXN0KTsKKyAgICAgICAgcGRldi0+ZG9tYWlu ID0gZG9tX2lvOwogICAgIH0KIAogICAgIHJjID0gYW1kX2lvbW11X3NldHVw X2RvbWFpbl9kZXZpY2UodGFyZ2V0LCBpb21tdSwgZGV2Zm4sIHBkZXYpOwpA QCAtMzc0LDYgKzM4OSwxMiBAQCBzdGF0aWMgaW50IHJlYXNzaWduX2Rldmlj ZShzdHJ1Y3QgZG9tYWluCiAgICAgQU1EX0lPTU1VX0RFQlVHKCJSZS1hc3Np Z24gJXBwIGZyb20gZG9tJWQgdG8gZG9tJWRcbiIsCiAgICAgICAgICAgICAg ICAgICAgICZwZGV2LT5zYmRmLCBzb3VyY2UtPmRvbWFpbl9pZCwgdGFyZ2V0 LT5kb21haW5faWQpOwogCisgICAgaWYgKCBkZXZmbiA9PSBwZGV2LT5kZXZm biAmJiBwZGV2LT5kb21haW4gIT0gdGFyZ2V0ICkKKyAgICB7CisgICAgICAg IGxpc3RfbW92ZSgmcGRldi0+ZG9tYWluX2xpc3QsICZ0YXJnZXQtPnBkZXZf bGlzdCk7CisgICAgICAgIHBkZXYtPmRvbWFpbiA9IHRhcmdldDsKKyAgICB9 CisKICAgICByZXR1cm4gMDsKIH0KIApAQCAtMzg0LDIwICs0MDUsMjggQEAg c3RhdGljIGludCBhbWRfaW9tbXVfYXNzaWduX2RldmljZShzdHJ1YwogICAg IHN0cnVjdCBpdnJzX21hcHBpbmdzICppdnJzX21hcHBpbmdzID0gZ2V0X2l2 cnNfbWFwcGluZ3MocGRldi0+c2VnKTsKICAgICBpbnQgYmRmID0gUENJX0JE RjIocGRldi0+YnVzLCBkZXZmbik7CiAgICAgaW50IHJlcV9pZCA9IGdldF9k bWFfcmVxdWVzdG9yX2lkKHBkZXYtPnNlZywgYmRmKTsKLSAgICBjb25zdCBz dHJ1Y3QgaXZyc191bml0eV9tYXAgKnVuaXR5X21hcDsKKyAgICBpbnQgcmMg PSBhbWRfaW9tbXVfcmVzZXJ2ZV9kb21haW5fdW5pdHlfbWFwKAorICAgICAg ICAgICAgICAgICBkLCBpdnJzX21hcHBpbmdzW3JlcV9pZF0udW5pdHlfbWFw LCBmbGFnKTsKIAotICAgIGZvciAoIHVuaXR5X21hcCA9IGl2cnNfbWFwcGlu Z3NbcmVxX2lkXS51bml0eV9tYXA7IHVuaXR5X21hcDsKLSAgICAgICAgICB1 bml0eV9tYXAgPSB1bml0eV9tYXAtPm5leHQgKQorICAgIGlmICggIXJjICkK KyAgICAgICAgcmMgPSByZWFzc2lnbl9kZXZpY2UocGRldi0+ZG9tYWluLCBk LCBkZXZmbiwgcGRldik7CisKKyAgICBpZiAoIHJjICYmICFpc19oYXJkd2Fy ZV9kb21haW4oZCkgKQogICAgIHsKLSAgICAgICAgaW50IHJjID0gYW1kX2lv bW11X3Jlc2VydmVfZG9tYWluX3VuaXR5X21hcCgKLSAgICAgICAgICAgICAg ICAgICAgIGQsIHVuaXR5X21hcC0+YWRkciwgdW5pdHlfbWFwLT5sZW5ndGgs Ci0gICAgICAgICAgICAgICAgICAgICB1bml0eV9tYXAtPndyaXRlLCB1bml0 eV9tYXAtPnJlYWQpOworICAgICAgICBpbnQgcmV0ID0gYW1kX2lvbW11X3Jl c2VydmVfZG9tYWluX3VuaXR5X3VubWFwKAorICAgICAgICAgICAgICAgICAg ICAgIGQsIGl2cnNfbWFwcGluZ3NbcmVxX2lkXS51bml0eV9tYXApOwogCi0g ICAgICAgIGlmICggcmMgKQotICAgICAgICAgICAgcmV0dXJuIHJjOworICAg ICAgICBpZiAoIHJldCApCisgICAgICAgIHsKKyAgICAgICAgICAgIHByaW50 ayhYRU5MT0dfRVJSICJBTUQtVmk6ICIKKyAgICAgICAgICAgICAgICAgICAi dW5pdHktdW5tYXAgZm9yICVwZC8lMDR4OiUwMng6JTAyeC4ldSBmYWlsZWQg KCVkKVxuIiwKKyAgICAgICAgICAgICAgICAgICBkLCBwZGV2LT5zZWcsIHBk ZXYtPmJ1cywKKyAgICAgICAgICAgICAgICAgICBQQ0lfU0xPVChkZXZmbiks IFBDSV9GVU5DKGRldmZuKSwgcmV0KTsKKyAgICAgICAgICAgIGRvbWFpbl9j cmFzaChkKTsKKyAgICAgICAgfQogICAgIH0KIAotICAgIHJldHVybiByZWFz c2lnbl9kZXZpY2UocGRldi0+ZG9tYWluLCBkLCBkZXZmbiwgcGRldik7Cisg ICAgcmV0dXJuIHJjOwogfQogCiBzdGF0aWMgdm9pZCBhbWRfaW9tbXVfY2xl YXJfcm9vdF9wZ3RhYmxlKHN0cnVjdCBkb21haW4gKmQpCkBAIC00MTEsNiAr NDQwLDcgQEAgc3RhdGljIHZvaWQgYW1kX2lvbW11X2NsZWFyX3Jvb3RfcGd0 YWJsZQogCiBzdGF0aWMgdm9pZCBhbWRfaW9tbXVfZG9tYWluX2Rlc3Ryb3ko c3RydWN0IGRvbWFpbiAqZCkKIHsKKyAgICBpb21tdV9pZGVudGl0eV9tYXBf dGVhcmRvd24oZCk7CiAgICAgQVNTRVJUKCFkb21faW9tbXUoZCktPmFyY2gu YW1kLnJvb3RfdGFibGUpOwogfQogCg== --=separator Content-Type: application/octet-stream; name="xsa378/xsa378-6.patch" Content-Disposition: attachment; filename="xsa378/xsa378-6.patch" Content-Transfer-Encoding: base64 RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0 OiBBTUQvSU9NTVU6IHJlLWFycmFuZ2UgZXhjbHVzaW9uIHJhbmdlIGFuZCB1 bml0eSBtYXAgcmVjb3JkaW5nCgpUaGUgc3BlYyBtYWtlcyBubyBwcm92aXNp b25zIGZvciBPUyBiZWhhdmlvciBoZXJlIHRvIGRlcGVuZCBvbiB0aGUKYW1v dW50IG9mIFJBTSBmb3VuZCBvbiB0aGUgc3lzdGVtLiBXaGlsZSB0aGUgc3Bl YyBtYXkgbm90IHN1ZmZpY2llbnRseQpjbGVhcmx5IGRpc3Rpbmd1aXNoIGJv dGgga2luZHMgb2YgcmVnaW9ucywgdGhleSBhcmUgc3VyZWx5IG1lYW50IHRv IGJlCnNlcGFyYXRlIHRoaW5nczogT25seSByZWdpb25zIHdpdGggQUNQSV9J Vk1EX0VYQ0xVU0lPTl9SQU5HRSBzZXQgc2hvdWxkCmJlIGNhbmRpZGF0ZXMg Zm9yIHB1dHRpbmcgaW4gdGhlIGV4Y2x1c2lvbiByYW5nZSByZWdpc3RlcnMu IChBcyB0aGVyZSdzCm9ubHkgYSBzaW5nbGUgc3VjaCBwYWlyIG9mIHJlZ2lz dGVycyBwZXIgSU9NTVUsIHNlY29uZGFyeSBub24tYWRqYWNlbnQKcmVnaW9u cyB3aXRoIHRoZSBmbGFnIHNldCBhbHJlYWR5IGdldCBjb252ZXJ0ZWQgdG8g dW5pdHkgbWFwcGVkCnJlZ2lvbnMuKQoKRmlyc3Qgb2YgYWxsLCBkcm9wIHRo ZSBkZXBlbmRlbmN5IG9uIG1heF9wYWdlLiBXaXRoIGNvbW1pdCBiNGYwNDIy MzZhZTAKKCJBTUQvSU9NTVU6IENlYXNlIHVzaW5nIGEgZHluYW1pYyBoZWln aHQgZm9yIHRoZSBJT01NVSBwYWdldGFibGVzIikgdGhlCnVzZSBvZiBpdCBo ZXJlIHdhcyBzdGFsZSBhbnl3YXk7IGl0IHdhcyBib2d1cyBhbHJlYWR5IGJl Zm9yZSwgYXMgaXQKZGlkbid0IGFjY291bnQgZm9yIG1heF9wYWdlIGdldHRp bmcgaW5jcmVhc2VkIGxhdGVyIG9uLiBTaW1wbHkgdHJ5IGFuCmV4Y2x1c2lv biByYW5nZSByZWdpc3RyYXRpb24gZmlyc3QsIGFuZCBpZiBpdCBmYWlscyAo Zm9yIGJlaW5nCnVuc3VpdGFibGUgb3Igbm9uLW1lcmdlYWJsZSksIHJlZ2lz dGVyIGEgdW5pdHkgbWFwcGluZyByYW5nZS4KCldpdGggdGhpcyB2YXJpb3Vz IGxvY2FsIHZhcmlhYmxlcyBiZWNvbWUgdW5uZWNlc3NhcnkgYW5kIGhlbmNl IGdldApkcm9wcGVkIGF0IHRoZSBzYW1lIHRpbWUuCgpXaXRoIHRoZSBtYXhf cGFnZSBib3VuZGFyeSBkcm9wcGVkIGZvciB1c2luZyB1bml0eSBtYXBzLCB0 aGUgbWluaW11bQpwYWdlIHRhYmxlIHRyZWUgaGVpZ2h0IG5vdyBuZWVkcyBi b3RoIHJlY29yZGluZyBhbmQgZW5mb3JjaW5nIGluCmFtZF9pb21tdV9kb21h aW5faW5pdCgpLiBTaW5jZSB3ZSBjYW4ndCBwcmVkaWN0IHdoaWNoIGRldmlj ZXMgbWF5IGdldAphc3NpZ25lZCB0byBhIGRvbWFpbiwgb3VyIG9ubHkgb3B0 aW9uIGlzIHRvIHVuaWZvcm1seSBmb3JjZSBhdCBsZWFzdAp0aGF0IGhlaWdo dCBmb3IgYWxsIGRvbWFpbnMsIG5vdyB0aGF0IHRoZSBoZWlnaHQgaXNuJ3Qg ZHluYW1pYyBhbnltb3JlLgoKRnVydGhlciBkb24ndCBtYWtlIHVzZSBvZiB0 aGUgZXhjbHVzaW9uIHJhbmdlIHVubGVzcyBBQ1BJIGRhdGEgc2F5cyBzby4K Ck5vdGUgdGhhdCBleGNsdXNpb24gcmFuZ2UgcmVnaXN0cmF0aW9uIGluCnJl Z2lzdGVyX3JhbmdlX2Zvcl9hbGxfZGV2aWNlcygpIGlzIG9uIGEgYmVzdCBl ZmZvcnQgYmFzaXMuIEhlbmNlIHVuaXR5Cm1hcCBlbnRyaWVzIGFsc28gcmVn aXN0ZXJlZCBhcmUgcmVkdW5kYW50IHdoZW4gdGhlIGZvcm1lciBzdWNjZWVk ZWQsIGJ1dAp0aGV5IGFsc28gZG8gbm8gaGFybS4gSW1wcm92ZW1lbnRzIGlu IHRoaXMgYXJlYSBjYW4gYmUgZG9uZSBsYXRlciBpbW8uCgpBbHNvIGFkanVz dCB0eXBlcyB3aGVyZSBzdWl0YWJsZSB3aXRob3V0IHRvdWNoaW5nIGV4dHJh IGxpbmVzLgoKVGhpcyBpcyBwYXJ0IG9mIFhTQS0zNzguCgpTaWduZWQtb2Zm LWJ5OiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+ClJldmlld2Vk LWJ5OiBQYXVsIER1cnJhbnQgPHBhdWxAeGVuLm9yZz4KLS0tClRCRDogVGhl IGFkanVzdG1lbnQgZG9uZSB0byBhbWRfaW9tbXVfZG9tYWluX2luaXQoKSB3 b3VsZCBzdWdnZXN0IHRoYXQKICAgICBpdCBtaWdodCBiZSB3b3J0aCBjb25z aWRlcmluZyB0byB1c2UgdGhlIGV4Y2x1c2lvbiByYW5nZSByZWdpc3Rlcgog ICAgIGZvciB0aGUgaGlnaGVzdCByZXBvcnRlZCAoYW5kIHN1aXRhYmxlKSBy YW5nZSwgcmF0aGVyIHRoYW4gdGhlCiAgICAgZmlyc3Qgb25lIGZvdW5kICho b3dldmVyIHVubGlrZWx5IGl0IG1pZ2h0IGJlIHRvIGZpbmQgbXVsdGlwbGUK ICAgICBvbmVzIGluIHRoZSBmaXJzdCBwbGFjZSkuIFRoYXQgd2F5IHdlIG1p Z2h0IGJlIGFibGUgdG8gbGltaXQgdGhlCiAgICAgcGFnZSB0YWJsZSB0cmVl IGhlaWdodC4KLS0tCnY5OiBSZS1iYXNlLgp2ODogUmUtYmFzZSBvdmVyIGFk anVzdG1lbnRzIHRvIGVhcmxpZXIgcGF0Y2guCnY3OiBEb24ndCB1c2UgZXhj bHVzaW9uIHJhbmdlIHdoZW4gQUNQSSB0YWJsZSBlbnRyeSBkb2Vzbid0IHNh eSBzby4KdjY6IFJlLWJhc2UuCnY1OiBOZXcuCi0tLQpCYWNrcG9ydGluZyBu b3RlOiBUaGlzIGRlcGVuZHMgb24gYjc1YjNjNjJmZTRhICgiQU1EL0lPTU1V OiBmaXgKb2ZmLWJ5LW9uZSBpbiBhbWRfaW9tbXVfZ2V0X3BhZ2luZ19tb2Rl KCkgY2FsbGVycyIpLgoKLS0tIGEveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gv YW1kL2lvbW11LmgKKysrIGIveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvYW1k L2lvbW11LmgKQEAgLTMwNCw2ICszMDQsOCBAQCBleHRlcm4gc3RydWN0IGhw ZXRfc2JkZiB7CiAgICAgfSBpbml0OwogfSBocGV0X3NiZGY7CiAKK2V4dGVy biBpbnQgYW1kX2lvbW11X21pbl9wYWdpbmdfbW9kZTsKKwogZXh0ZXJuIHZv aWQgKnNoYXJlZF9pbnRyZW1hcF90YWJsZTsKIGV4dGVybiB1bnNpZ25lZCBs b25nICpzaGFyZWRfaW50cmVtYXBfaW51c2U7CiAKLS0tIGEveGVuL2RyaXZl cnMvcGFzc3Rocm91Z2gvYW1kL2lvbW11X2FjcGkuYworKysgYi94ZW4vZHJp dmVycy9wYXNzdGhyb3VnaC9hbWQvaW9tbXVfYWNwaS5jCkBAIC0xMTcsMTIg KzExNyw4IEBAIHN0YXRpYyBzdHJ1Y3QgYW1kX2lvbW11ICogX19pbml0IGZp bmRfaW8KIH0KIAogc3RhdGljIGludCBfX2luaXQgcmVzZXJ2ZV9pb21tdV9l eGNsdXNpb25fcmFuZ2UoCi0gICAgc3RydWN0IGFtZF9pb21tdSAqaW9tbXUs IHVpbnQ2NF90IGJhc2UsIHVpbnQ2NF90IGxpbWl0LAotICAgIGJvb2wgYWxs LCBib29sIGl3LCBib29sIGlyKQorICAgIHN0cnVjdCBhbWRfaW9tbXUgKmlv bW11LCBwYWRkcl90IGJhc2UsIHBhZGRyX3QgbGltaXQsIGJvb2wgYWxsKQog ewotICAgIGlmICggIWlyIHx8ICFpdyApCi0gICAgICAgIHJldHVybiAtRVBF Uk07Ci0KICAgICAvKiBuZWVkIHRvIGV4dGVuZCBleGNsdXNpb24gcmFuZ2U/ ICovCiAgICAgaWYgKCBpb21tdS0+ZXhjbHVzaW9uX2VuYWJsZSApCiAgICAg ewpAQCAtMTUxLDE0ICsxNDcsMTggQEAgc3RhdGljIGludCBfX2luaXQgcmVz ZXJ2ZV91bml0eV9tYXBfZm9yXwogewogICAgIHN0cnVjdCBpdnJzX21hcHBp bmdzICppdnJzX21hcHBpbmdzID0gZ2V0X2l2cnNfbWFwcGluZ3Moc2VnKTsK ICAgICBzdHJ1Y3QgaXZyc191bml0eV9tYXAgKnVuaXR5X21hcCA9IGl2cnNf bWFwcGluZ3NbYmRmXS51bml0eV9tYXA7CisgICAgaW50IHBhZ2luZ19tb2Rl ID0gYW1kX2lvbW11X2dldF9wYWdpbmdfbW9kZShQRk5fVVAoYmFzZSArIGxl bmd0aCkpOworCisgICAgaWYgKCBwYWdpbmdfbW9kZSA8IDAgKQorICAgICAg ICByZXR1cm4gcGFnaW5nX21vZGU7CiAKICAgICAvKiBDaGVjayBmb3Igb3Zl cmxhcHMuICovCiAgICAgZm9yICggOyB1bml0eV9tYXA7IHVuaXR5X21hcCA9 IHVuaXR5X21hcC0+bmV4dCApCiAgICAgewogICAgICAgICAvKgogICAgICAg ICAgKiBFeGFjdCBtYXRjaGVzIGFyZSBva2F5LiBUaGlzIGNhbiBpbiBwYXJ0 aWN1bGFyIGhhcHBlbiB3aGVuCi0gICAgICAgICAqIHJlZ2lzdGVyX2V4Y2x1 c2lvbl9yYW5nZV9mb3JfZGV2aWNlKCkgY2FsbHMgaGVyZSB0d2ljZSBmb3Ig dGhlCi0gICAgICAgICAqIHNhbWUgKHMsYixkLGYpLgorICAgICAgICAgKiBy ZWdpc3Rlcl9yYW5nZV9mb3JfZGV2aWNlKCkgY2FsbHMgaGVyZSB0d2ljZSBm b3IgdGhlIHNhbWUKKyAgICAgICAgICogKHMsYixkLGYpLgogICAgICAgICAg Ki8KICAgICAgICAgaWYgKCBiYXNlID09IHVuaXR5X21hcC0+YWRkciAmJiBs ZW5ndGggPT0gdW5pdHlfbWFwLT5sZW5ndGggJiYKICAgICAgICAgICAgICBp ciA9PSB1bml0eV9tYXAtPnJlYWQgJiYgaXcgPT0gdW5pdHlfbWFwLT53cml0 ZSApCkBAIC0xODYsNTUgKzE4Niw1MiBAQCBzdGF0aWMgaW50IF9faW5pdCBy ZXNlcnZlX3VuaXR5X21hcF9mb3JfCiAgICAgdW5pdHlfbWFwLT5uZXh0ID0g aXZyc19tYXBwaW5nc1tiZGZdLnVuaXR5X21hcDsKICAgICBpdnJzX21hcHBp bmdzW2JkZl0udW5pdHlfbWFwID0gdW5pdHlfbWFwOwogCisgICAgaWYgKCBw YWdpbmdfbW9kZSA+IGFtZF9pb21tdV9taW5fcGFnaW5nX21vZGUgKQorICAg ICAgICBhbWRfaW9tbXVfbWluX3BhZ2luZ19tb2RlID0gcGFnaW5nX21vZGU7 CisKICAgICByZXR1cm4gMDsKIH0KIAotc3RhdGljIGludCBfX2luaXQgcmVn aXN0ZXJfZXhjbHVzaW9uX3JhbmdlX2Zvcl9hbGxfZGV2aWNlcygKLSAgICB1 bnNpZ25lZCBsb25nIGJhc2UsIHVuc2lnbmVkIGxvbmcgbGltaXQsIHU4IGl3 LCB1OCBpcikKK3N0YXRpYyBpbnQgX19pbml0IHJlZ2lzdGVyX3JhbmdlX2Zv cl9hbGxfZGV2aWNlcygKKyAgICBwYWRkcl90IGJhc2UsIHBhZGRyX3QgbGlt aXQsIGJvb2wgaXcsIGJvb2wgaXIsIGJvb2wgZXhjbHVzaW9uKQogewogICAg IGludCBzZWcgPSAwOyAvKiBYWFggKi8KLSAgICB1bnNpZ25lZCBsb25nIHJh bmdlX3RvcCwgaW9tbXVfdG9wLCBsZW5ndGg7CiAgICAgc3RydWN0IGFtZF9p b21tdSAqaW9tbXU7Ci0gICAgdW5zaWduZWQgaW50IGJkZjsKICAgICBpbnQg cmMgPSAwOwogCiAgICAgLyogaXMgcGFydCBvZiBleGNsdXNpb24gcmFuZ2Ug aW5zaWRlIG9mIElPTU1VIHZpcnR1YWwgYWRkcmVzcyBzcGFjZT8gKi8KICAg ICAvKiBub3RlOiAnbGltaXQnIHBhcmFtZXRlciBpcyBhc3N1bWVkIHRvIGJl IHBhZ2UtYWxpZ25lZCAqLwotICAgIHJhbmdlX3RvcCA9IGxpbWl0ICsgUEFH RV9TSVpFOwotICAgIGlvbW11X3RvcCA9IG1heF9wYWdlICogUEFHRV9TSVpF OwotICAgIGlmICggYmFzZSA8IGlvbW11X3RvcCApCi0gICAgewotICAgICAg ICBpZiAoIHJhbmdlX3RvcCA+IGlvbW11X3RvcCApCi0gICAgICAgICAgICBy YW5nZV90b3AgPSBpb21tdV90b3A7Ci0gICAgICAgIGxlbmd0aCA9IHJhbmdl X3RvcCAtIGJhc2U7Ci0gICAgICAgIC8qIHJlc2VydmUgci93IHVuaXR5LW1h cHBlZCBwYWdlIGVudHJpZXMgZm9yIGRldmljZXMgKi8KLSAgICAgICAgLyog bm90ZTogdGhlc2UgZW50cmllcyBhcmUgcGFydCBvZiB0aGUgZXhjbHVzaW9u IHJhbmdlICovCi0gICAgICAgIGZvciAoIGJkZiA9IDA7ICFyYyAmJiBiZGYg PCBpdnJzX2JkZl9lbnRyaWVzOyBiZGYrKyApCi0gICAgICAgICAgICByYyA9 IHJlc2VydmVfdW5pdHlfbWFwX2Zvcl9kZXZpY2Uoc2VnLCBiZGYsIGJhc2Us IGxlbmd0aCwgaXcsIGlyKTsKLSAgICAgICAgLyogcHVzaCAnYmFzZScganVz dCBvdXRzaWRlIG9mIHZpcnR1YWwgYWRkcmVzcyBzcGFjZSAqLwotICAgICAg ICBiYXNlID0gaW9tbXVfdG9wOwotICAgIH0KLSAgICAvKiByZWdpc3RlciBJ T01NVSBleGNsdXNpb24gcmFuZ2Ugc2V0dGluZ3MgKi8KLSAgICBpZiAoICFy YyAmJiBsaW1pdCA+PSBpb21tdV90b3AgKQorICAgIGlmICggZXhjbHVzaW9u ICkKICAgICB7CiAgICAgICAgIGZvcl9lYWNoX2FtZF9pb21tdSggaW9tbXUg KQogICAgICAgICB7Ci0gICAgICAgICAgICByYyA9IHJlc2VydmVfaW9tbXVf ZXhjbHVzaW9uX3JhbmdlKGlvbW11LCBiYXNlLCBsaW1pdCwKLSAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdHJ1ZSAv KiBhbGwgKi8sIGl3LCBpcik7Ci0gICAgICAgICAgICBpZiAoIHJjICkKLSAg ICAgICAgICAgICAgICBicmVhazsKKyAgICAgICAgICAgIGludCByZXQgPSBy ZXNlcnZlX2lvbW11X2V4Y2x1c2lvbl9yYW5nZShpb21tdSwgYmFzZSwgbGlt aXQsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgdHJ1ZSAvKiBhbGwgKi8pOworCisgICAgICAgICAgICBp ZiAoIHJldCAmJiAhcmMgKQorICAgICAgICAgICAgICAgIHJjID0gcmV0Owog ICAgICAgICB9CiAgICAgfQogCisgICAgaWYgKCAhZXhjbHVzaW9uIHx8IHJj ICkKKyAgICB7CisgICAgICAgIHBhZGRyX3QgbGVuZ3RoID0gbGltaXQgKyBQ QUdFX1NJWkUgLSBiYXNlOworICAgICAgICB1bnNpZ25lZCBpbnQgYmRmOwor CisgICAgICAgIC8qIHJlc2VydmUgci93IHVuaXR5LW1hcHBlZCBwYWdlIGVu dHJpZXMgZm9yIGRldmljZXMgKi8KKyAgICAgICAgZm9yICggYmRmID0gcmMg PSAwOyAhcmMgJiYgYmRmIDwgaXZyc19iZGZfZW50cmllczsgYmRmKysgKQor ICAgICAgICAgICAgcmMgPSByZXNlcnZlX3VuaXR5X21hcF9mb3JfZGV2aWNl KHNlZywgYmRmLCBiYXNlLCBsZW5ndGgsIGl3LCBpcik7CisgICAgfQorCiAg ICAgcmV0dXJuIHJjOwogfQogCi1zdGF0aWMgaW50IF9faW5pdCByZWdpc3Rl cl9leGNsdXNpb25fcmFuZ2VfZm9yX2RldmljZSgKLSAgICB1MTYgYmRmLCB1 bnNpZ25lZCBsb25nIGJhc2UsIHVuc2lnbmVkIGxvbmcgbGltaXQsIHU4IGl3 LCB1OCBpcikKK3N0YXRpYyBpbnQgX19pbml0IHJlZ2lzdGVyX3JhbmdlX2Zv cl9kZXZpY2UoCisgICAgdW5zaWduZWQgaW50IGJkZiwgcGFkZHJfdCBiYXNl LCBwYWRkcl90IGxpbWl0LAorICAgIGJvb2wgaXcsIGJvb2wgaXIsIGJvb2wg ZXhjbHVzaW9uKQogewogICAgIGludCBzZWcgPSAwOyAvKiBYWFggKi8KICAg ICBzdHJ1Y3QgaXZyc19tYXBwaW5ncyAqaXZyc19tYXBwaW5ncyA9IGdldF9p dnJzX21hcHBpbmdzKHNlZyk7Ci0gICAgdW5zaWduZWQgbG9uZyByYW5nZV90 b3AsIGlvbW11X3RvcCwgbGVuZ3RoOwogICAgIHN0cnVjdCBhbWRfaW9tbXUg KmlvbW11OwogICAgIHUxNiByZXE7CiAgICAgaW50IHJjID0gMDsKQEAgLTI0 OCwyNyArMjQ1LDE5IEBAIHN0YXRpYyBpbnQgX19pbml0IHJlZ2lzdGVyX2V4 Y2x1c2lvbl9yYW4KICAgICByZXEgPSBpdnJzX21hcHBpbmdzW2JkZl0uZHRl X3JlcXVlc3Rvcl9pZDsKIAogICAgIC8qIG5vdGU6ICdsaW1pdCcgcGFyYW1l dGVyIGlzIGFzc3VtZWQgdG8gYmUgcGFnZS1hbGlnbmVkICovCi0gICAgcmFu Z2VfdG9wID0gbGltaXQgKyBQQUdFX1NJWkU7Ci0gICAgaW9tbXVfdG9wID0g bWF4X3BhZ2UgKiBQQUdFX1NJWkU7Ci0gICAgaWYgKCBiYXNlIDwgaW9tbXVf dG9wICkKLSAgICB7Ci0gICAgICAgIGlmICggcmFuZ2VfdG9wID4gaW9tbXVf dG9wICkKLSAgICAgICAgICAgIHJhbmdlX3RvcCA9IGlvbW11X3RvcDsKLSAg ICAgICAgbGVuZ3RoID0gcmFuZ2VfdG9wIC0gYmFzZTsKKyAgICBpZiAoIGV4 Y2x1c2lvbiApCisgICAgICAgIHJjID0gcmVzZXJ2ZV9pb21tdV9leGNsdXNp b25fcmFuZ2UoaW9tbXUsIGJhc2UsIGxpbWl0LAorICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIGZhbHNlIC8qIGFsbCAqLyk7 CisgICAgaWYgKCAhZXhjbHVzaW9uIHx8IHJjICkKKyAgICB7CisgICAgICAg IHBhZGRyX3QgbGVuZ3RoID0gbGltaXQgKyBQQUdFX1NJWkUgLSBiYXNlOwor CiAgICAgICAgIC8qIHJlc2VydmUgdW5pdHktbWFwcGVkIHBhZ2UgZW50cmll cyBmb3IgZGV2aWNlICovCi0gICAgICAgIC8qIG5vdGU6IHRoZXNlIGVudHJp ZXMgYXJlIHBhcnQgb2YgdGhlIGV4Y2x1c2lvbiByYW5nZSAqLwogICAgICAg ICByYyA9IHJlc2VydmVfdW5pdHlfbWFwX2Zvcl9kZXZpY2Uoc2VnLCBiZGYs IGJhc2UsIGxlbmd0aCwgaXcsIGlyKSA/OgogICAgICAgICAgICAgIHJlc2Vy dmVfdW5pdHlfbWFwX2Zvcl9kZXZpY2Uoc2VnLCByZXEsIGJhc2UsIGxlbmd0 aCwgaXcsIGlyKTsKLQotICAgICAgICAvKiBwdXNoICdiYXNlJyBqdXN0IG91 dHNpZGUgb2YgdmlydHVhbCBhZGRyZXNzIHNwYWNlICovCi0gICAgICAgIGJh c2UgPSBpb21tdV90b3A7CiAgICAgfQotCi0gICAgLyogcmVnaXN0ZXIgSU9N TVUgZXhjbHVzaW9uIHJhbmdlIHNldHRpbmdzIGZvciBkZXZpY2UgKi8KLSAg ICBpZiAoICFyYyAmJiBsaW1pdCA+PSBpb21tdV90b3AgICkKKyAgICBlbHNl CiAgICAgewotICAgICAgICByYyA9IHJlc2VydmVfaW9tbXVfZXhjbHVzaW9u X3JhbmdlKGlvbW11LCBiYXNlLCBsaW1pdCwKLSAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBmYWxzZSAvKiBhbGwgKi8sIGl3 LCBpcik7CiAgICAgICAgIGl2cnNfbWFwcGluZ3NbYmRmXS5kdGVfYWxsb3df ZXhjbHVzaW9uID0gdHJ1ZTsKICAgICAgICAgaXZyc19tYXBwaW5nc1tyZXFd LmR0ZV9hbGxvd19leGNsdXNpb24gPSB0cnVlOwogICAgIH0KQEAgLTI3Niw1 MyArMjY1LDQyIEBAIHN0YXRpYyBpbnQgX19pbml0IHJlZ2lzdGVyX2V4Y2x1 c2lvbl9yYW4KICAgICByZXR1cm4gcmM7CiB9CiAKLXN0YXRpYyBpbnQgX19p bml0IHJlZ2lzdGVyX2V4Y2x1c2lvbl9yYW5nZV9mb3JfaW9tbXVfZGV2aWNl cygKLSAgICBzdHJ1Y3QgYW1kX2lvbW11ICppb21tdSwKLSAgICB1bnNpZ25l ZCBsb25nIGJhc2UsIHVuc2lnbmVkIGxvbmcgbGltaXQsIHU4IGl3LCB1OCBp cikKK3N0YXRpYyBpbnQgX19pbml0IHJlZ2lzdGVyX3JhbmdlX2Zvcl9pb21t dV9kZXZpY2VzKAorICAgIHN0cnVjdCBhbWRfaW9tbXUgKmlvbW11LCBwYWRk cl90IGJhc2UsIHBhZGRyX3QgbGltaXQsCisgICAgYm9vbCBpdywgYm9vbCBp ciwgYm9vbCBleGNsdXNpb24pCiB7Ci0gICAgdW5zaWduZWQgbG9uZyByYW5n ZV90b3AsIGlvbW11X3RvcCwgbGVuZ3RoOworICAgIC8qIG5vdGU6ICdsaW1p dCcgcGFyYW1ldGVyIGlzIGFzc3VtZWQgdG8gYmUgcGFnZS1hbGlnbmVkICov CisgICAgcGFkZHJfdCBsZW5ndGggPSBsaW1pdCArIFBBR0VfU0laRSAtIGJh c2U7CiAgICAgdW5zaWduZWQgaW50IGJkZjsKICAgICB1MTYgcmVxOwotICAg IGludCByYyA9IDA7CisgICAgaW50IHJjOwogCi0gICAgLyogaXMgcGFydCBv ZiBleGNsdXNpb24gcmFuZ2UgaW5zaWRlIG9mIElPTU1VIHZpcnR1YWwgYWRk cmVzcyBzcGFjZT8gKi8KLSAgICAvKiBub3RlOiAnbGltaXQnIHBhcmFtZXRl ciBpcyBhc3N1bWVkIHRvIGJlIHBhZ2UtYWxpZ25lZCAqLwotICAgIHJhbmdl X3RvcCA9IGxpbWl0ICsgUEFHRV9TSVpFOwotICAgIGlvbW11X3RvcCA9IG1h eF9wYWdlICogUEFHRV9TSVpFOwotICAgIGlmICggYmFzZSA8IGlvbW11X3Rv cCApCi0gICAgewotICAgICAgICBpZiAoIHJhbmdlX3RvcCA+IGlvbW11X3Rv cCApCi0gICAgICAgICAgICByYW5nZV90b3AgPSBpb21tdV90b3A7Ci0gICAg ICAgIGxlbmd0aCA9IHJhbmdlX3RvcCAtIGJhc2U7Ci0gICAgICAgIC8qIHJl c2VydmUgci93IHVuaXR5LW1hcHBlZCBwYWdlIGVudHJpZXMgZm9yIGRldmlj ZXMgKi8KLSAgICAgICAgLyogbm90ZTogdGhlc2UgZW50cmllcyBhcmUgcGFy dCBvZiB0aGUgZXhjbHVzaW9uIHJhbmdlICovCi0gICAgICAgIGZvciAoIGJk ZiA9IDA7ICFyYyAmJiBiZGYgPCBpdnJzX2JkZl9lbnRyaWVzOyBiZGYrKyAp Ci0gICAgICAgIHsKLSAgICAgICAgICAgIGlmICggaW9tbXUgPT0gZmluZF9p b21tdV9mb3JfZGV2aWNlKGlvbW11LT5zZWcsIGJkZikgKQotICAgICAgICAg ICAgewotICAgICAgICAgICAgICAgIHJlcSA9IGdldF9pdnJzX21hcHBpbmdz KGlvbW11LT5zZWcpW2JkZl0uZHRlX3JlcXVlc3Rvcl9pZDsKLSAgICAgICAg ICAgICAgICByYyA9IHJlc2VydmVfdW5pdHlfbWFwX2Zvcl9kZXZpY2UoaW9t bXUtPnNlZywgYmRmLCBiYXNlLCBsZW5ndGgsCi0gICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGl3LCBpcikgPzoK LSAgICAgICAgICAgICAgICAgICAgIHJlc2VydmVfdW5pdHlfbWFwX2Zvcl9k ZXZpY2UoaW9tbXUtPnNlZywgcmVxLCBiYXNlLCBsZW5ndGgsCi0gICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGl3 LCBpcik7Ci0gICAgICAgICAgICB9Ci0gICAgICAgIH0KLQotICAgICAgICAv KiBwdXNoICdiYXNlJyBqdXN0IG91dHNpZGUgb2YgdmlydHVhbCBhZGRyZXNz IHNwYWNlICovCi0gICAgICAgIGJhc2UgPSBpb21tdV90b3A7CisgICAgaWYg KCBleGNsdXNpb24gKQorICAgIHsKKyAgICAgICAgcmMgPSByZXNlcnZlX2lv bW11X2V4Y2x1c2lvbl9yYW5nZShpb21tdSwgYmFzZSwgbGltaXQsIHRydWUg LyogYWxsICovKTsKKyAgICAgICAgaWYgKCAhcmMgKQorICAgICAgICAgICAg cmV0dXJuIDA7CiAgICAgfQogCi0gICAgLyogcmVnaXN0ZXIgSU9NTVUgZXhj bHVzaW9uIHJhbmdlIHNldHRpbmdzICovCi0gICAgaWYgKCAhcmMgJiYgbGlt aXQgPj0gaW9tbXVfdG9wICkKLSAgICAgICAgcmMgPSByZXNlcnZlX2lvbW11 X2V4Y2x1c2lvbl9yYW5nZShpb21tdSwgYmFzZSwgbGltaXQsCi0gICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdHJ1ZSAvKiBh bGwgKi8sIGl3LCBpcik7CisgICAgLyogcmVzZXJ2ZSB1bml0eS1tYXBwZWQg cGFnZSBlbnRyaWVzIGZvciBkZXZpY2VzICovCisgICAgZm9yICggYmRmID0g cmMgPSAwOyAhcmMgJiYgYmRmIDwgaXZyc19iZGZfZW50cmllczsgYmRmKysg KQorICAgIHsKKyAgICAgICAgaWYgKCBpb21tdSAhPSBmaW5kX2lvbW11X2Zv cl9kZXZpY2UoaW9tbXUtPnNlZywgYmRmKSApCisgICAgICAgICAgICBjb250 aW51ZTsKKworICAgICAgICByZXEgPSBnZXRfaXZyc19tYXBwaW5ncyhpb21t dS0+c2VnKVtiZGZdLmR0ZV9yZXF1ZXN0b3JfaWQ7CisgICAgICAgIHJjID0g cmVzZXJ2ZV91bml0eV9tYXBfZm9yX2RldmljZShpb21tdS0+c2VnLCBiZGYs IGJhc2UsIGxlbmd0aCwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIGl3LCBpcikgPzoKKyAgICAgICAgICAgICByZXNlcnZl X3VuaXR5X21hcF9mb3JfZGV2aWNlKGlvbW11LT5zZWcsIHJlcSwgYmFzZSwg bGVuZ3RoLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgaXcsIGlyKTsKKyAgICB9CiAKICAgICByZXR1cm4gcmM7CiB9CiAK IHN0YXRpYyBpbnQgX19pbml0IHBhcnNlX2l2bWRfZGV2aWNlX3NlbGVjdCgK ICAgICBjb25zdCBzdHJ1Y3QgYWNwaV9pdnJzX21lbW9yeSAqaXZtZF9ibG9j aywKLSAgICB1bnNpZ25lZCBsb25nIGJhc2UsIHVuc2lnbmVkIGxvbmcgbGlt aXQsIHU4IGl3LCB1OCBpcikKKyAgICBwYWRkcl90IGJhc2UsIHBhZGRyX3Qg bGltaXQsIGJvb2wgaXcsIGJvb2wgaXIsIGJvb2wgZXhjbHVzaW9uKQogewog ICAgIHUxNiBiZGY7CiAKQEAgLTMzMywxMiArMzExLDEyIEBAIHN0YXRpYyBp bnQgX19pbml0IHBhcnNlX2l2bWRfZGV2aWNlX3NlbGUKICAgICAgICAgcmV0 dXJuIC1FTk9ERVY7CiAgICAgfQogCi0gICAgcmV0dXJuIHJlZ2lzdGVyX2V4 Y2x1c2lvbl9yYW5nZV9mb3JfZGV2aWNlKGJkZiwgYmFzZSwgbGltaXQsIGl3 LCBpcik7CisgICAgcmV0dXJuIHJlZ2lzdGVyX3JhbmdlX2Zvcl9kZXZpY2Uo YmRmLCBiYXNlLCBsaW1pdCwgaXcsIGlyLCBleGNsdXNpb24pOwogfQogCiBz dGF0aWMgaW50IF9faW5pdCBwYXJzZV9pdm1kX2RldmljZV9yYW5nZSgKICAg ICBjb25zdCBzdHJ1Y3QgYWNwaV9pdnJzX21lbW9yeSAqaXZtZF9ibG9jaywK LSAgICB1bnNpZ25lZCBsb25nIGJhc2UsIHVuc2lnbmVkIGxvbmcgbGltaXQs IHU4IGl3LCB1OCBpcikKKyAgICBwYWRkcl90IGJhc2UsIHBhZGRyX3QgbGlt aXQsIGJvb2wgaXcsIGJvb2wgaXIsIGJvb2wgZXhjbHVzaW9uKQogewogICAg IHVuc2lnbmVkIGludCBmaXJzdF9iZGYsIGxhc3RfYmRmLCBiZGY7CiAgICAg aW50IGVycm9yOwpAQCAtMzYwLDE1ICszMzgsMTUgQEAgc3RhdGljIGludCBf X2luaXQgcGFyc2VfaXZtZF9kZXZpY2VfcmFuZwogICAgIH0KIAogICAgIGZv ciAoIGJkZiA9IGZpcnN0X2JkZiwgZXJyb3IgPSAwOyAoYmRmIDw9IGxhc3Rf YmRmKSAmJiAhZXJyb3I7IGJkZisrICkKLSAgICAgICAgZXJyb3IgPSByZWdp c3Rlcl9leGNsdXNpb25fcmFuZ2VfZm9yX2RldmljZSgKLSAgICAgICAgICAg IGJkZiwgYmFzZSwgbGltaXQsIGl3LCBpcik7CisgICAgICAgIGVycm9yID0g cmVnaXN0ZXJfcmFuZ2VfZm9yX2RldmljZSgKKyAgICAgICAgICAgIGJkZiwg YmFzZSwgbGltaXQsIGl3LCBpciwgZXhjbHVzaW9uKTsKIAogICAgIHJldHVy biBlcnJvcjsKIH0KIAogc3RhdGljIGludCBfX2luaXQgcGFyc2VfaXZtZF9k ZXZpY2VfaW9tbXUoCiAgICAgY29uc3Qgc3RydWN0IGFjcGlfaXZyc19tZW1v cnkgKml2bWRfYmxvY2ssCi0gICAgdW5zaWduZWQgbG9uZyBiYXNlLCB1bnNp Z25lZCBsb25nIGxpbWl0LCB1OCBpdywgdTggaXIpCisgICAgcGFkZHJfdCBi YXNlLCBwYWRkcl90IGxpbWl0LCBib29sIGl3LCBib29sIGlyLCBib29sIGV4 Y2x1c2lvbikKIHsKICAgICBpbnQgc2VnID0gMDsgLyogWFhYICovCiAgICAg c3RydWN0IGFtZF9pb21tdSAqaW9tbXU7CkBAIC0zODMsMTQgKzM2MSwxNCBA QCBzdGF0aWMgaW50IF9faW5pdCBwYXJzZV9pdm1kX2RldmljZV9pb21tCiAg ICAgICAgIHJldHVybiAtRU5PREVWOwogICAgIH0KIAotICAgIHJldHVybiBy ZWdpc3Rlcl9leGNsdXNpb25fcmFuZ2VfZm9yX2lvbW11X2RldmljZXMoCi0g ICAgICAgIGlvbW11LCBiYXNlLCBsaW1pdCwgaXcsIGlyKTsKKyAgICByZXR1 cm4gcmVnaXN0ZXJfcmFuZ2VfZm9yX2lvbW11X2RldmljZXMoCisgICAgICAg IGlvbW11LCBiYXNlLCBsaW1pdCwgaXcsIGlyLCBleGNsdXNpb24pOwogfQog CiBzdGF0aWMgaW50IF9faW5pdCBwYXJzZV9pdm1kX2Jsb2NrKGNvbnN0IHN0 cnVjdCBhY3BpX2l2cnNfbWVtb3J5ICppdm1kX2Jsb2NrKQogewogICAgIHVu c2lnbmVkIGxvbmcgc3RhcnRfYWRkciwgbWVtX2xlbmd0aCwgYmFzZSwgbGlt aXQ7Ci0gICAgdTggaXcsIGlyOworICAgIGJvb2wgaXcgPSB0cnVlLCBpciA9 IHRydWUsIGV4Y2x1c2lvbiA9IGZhbHNlOwogCiAgICAgaWYgKCBpdm1kX2Js b2NrLT5oZWFkZXIubGVuZ3RoIDwgc2l6ZW9mKCppdm1kX2Jsb2NrKSApCiAg ICAgewpAQCAtNDA3LDEzICszODUsMTEgQEAgc3RhdGljIGludCBfX2luaXQg cGFyc2VfaXZtZF9ibG9jayhjb25zdAogICAgICAgICAgICAgICAgICAgICBp dm1kX2Jsb2NrLT5oZWFkZXIudHlwZSwgc3RhcnRfYWRkciwgbWVtX2xlbmd0 aCk7CiAKICAgICBpZiAoIGl2bWRfYmxvY2stPmhlYWRlci5mbGFncyAmIEFD UElfSVZNRF9FWENMVVNJT05fUkFOR0UgKQotICAgICAgICBpdyA9IGlyID0g SU9NTVVfQ09OVFJPTF9FTkFCTEVEOworICAgICAgICBleGNsdXNpb24gPSB0 cnVlOwogICAgIGVsc2UgaWYgKCBpdm1kX2Jsb2NrLT5oZWFkZXIuZmxhZ3Mg JiBBQ1BJX0lWTURfVU5JVFkgKQogICAgIHsKLSAgICAgICAgaXcgPSBpdm1k X2Jsb2NrLT5oZWFkZXIuZmxhZ3MgJiBBQ1BJX0lWTURfUkVBRCA/Ci0gICAg ICAgICAgICBJT01NVV9DT05UUk9MX0VOQUJMRUQgOiBJT01NVV9DT05UUk9M X0RJU0FCTEVEOwotICAgICAgICBpciA9IGl2bWRfYmxvY2stPmhlYWRlci5m bGFncyAmIEFDUElfSVZNRF9XUklURSA/Ci0gICAgICAgICAgICBJT01NVV9D T05UUk9MX0VOQUJMRUQgOiBJT01NVV9DT05UUk9MX0RJU0FCTEVEOworICAg ICAgICBpdyA9IGl2bWRfYmxvY2stPmhlYWRlci5mbGFncyAmIEFDUElfSVZN RF9SRUFEOworICAgICAgICBpciA9IGl2bWRfYmxvY2stPmhlYWRlci5mbGFn cyAmIEFDUElfSVZNRF9XUklURTsKICAgICB9CiAgICAgZWxzZQogICAgIHsK QEAgLTQyNCwyMCArNDAwLDIwIEBAIHN0YXRpYyBpbnQgX19pbml0IHBhcnNl X2l2bWRfYmxvY2soY29uc3QKICAgICBzd2l0Y2goIGl2bWRfYmxvY2stPmhl YWRlci50eXBlICkKICAgICB7CiAgICAgY2FzZSBBQ1BJX0lWUlNfVFlQRV9N RU1PUllfQUxMOgotICAgICAgICByZXR1cm4gcmVnaXN0ZXJfZXhjbHVzaW9u X3JhbmdlX2Zvcl9hbGxfZGV2aWNlcygKLSAgICAgICAgICAgIGJhc2UsIGxp bWl0LCBpdywgaXIpOworICAgICAgICByZXR1cm4gcmVnaXN0ZXJfcmFuZ2Vf Zm9yX2FsbF9kZXZpY2VzKAorICAgICAgICAgICAgYmFzZSwgbGltaXQsIGl3 LCBpciwgZXhjbHVzaW9uKTsKIAogICAgIGNhc2UgQUNQSV9JVlJTX1RZUEVf TUVNT1JZX09ORToKLSAgICAgICAgcmV0dXJuIHBhcnNlX2l2bWRfZGV2aWNl X3NlbGVjdChpdm1kX2Jsb2NrLAotICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIGJhc2UsIGxpbWl0LCBpdywgaXIpOworICAgICAg ICByZXR1cm4gcGFyc2VfaXZtZF9kZXZpY2Vfc2VsZWN0KGl2bWRfYmxvY2ss IGJhc2UsIGxpbWl0LAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIGl3LCBpciwgZXhjbHVzaW9uKTsKIAogICAgIGNhc2UgQUNQ SV9JVlJTX1RZUEVfTUVNT1JZX1JBTkdFOgotICAgICAgICByZXR1cm4gcGFy c2VfaXZtZF9kZXZpY2VfcmFuZ2UoaXZtZF9ibG9jaywKLSAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIGJhc2UsIGxpbWl0LCBpdywg aXIpOworICAgICAgICByZXR1cm4gcGFyc2VfaXZtZF9kZXZpY2VfcmFuZ2Uo aXZtZF9ibG9jaywgYmFzZSwgbGltaXQsCisgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICBpdywgaXIsIGV4Y2x1c2lvbik7CiAKICAg ICBjYXNlIEFDUElfSVZSU19UWVBFX01FTU9SWV9JT01NVToKLSAgICAgICAg cmV0dXJuIHBhcnNlX2l2bWRfZGV2aWNlX2lvbW11KGl2bWRfYmxvY2ssCi0g ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBiYXNlLCBs aW1pdCwgaXcsIGlyKTsKKyAgICAgICAgcmV0dXJuIHBhcnNlX2l2bWRfZGV2 aWNlX2lvbW11KGl2bWRfYmxvY2ssIGJhc2UsIGxpbWl0LAorICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgaXcsIGlyLCBleGNsdXNp b24pOwogCiAgICAgZGVmYXVsdDoKICAgICAgICAgQU1EX0lPTU1VX0RFQlVH KCJJVk1EIEVycm9yOiBJbnZhbGlkIEJsb2NrIFR5cGUhXG4iKTsKLS0tIGEv eGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvYW1kL3BjaV9hbWRfaW9tbXUuYwor KysgYi94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC9hbWQvcGNpX2FtZF9pb21t dS5jCkBAIC0yNDYsNiArMjQ2LDggQEAgaW50IGFtZF9pb21tdV9hbGxvY19y b290KHN0cnVjdCBkb21haW4gKgogICAgIHJldHVybiAwOwogfQogCitpbnQg X19yZWFkX21vc3RseSBhbWRfaW9tbXVfbWluX3BhZ2luZ19tb2RlID0gMTsK Kwogc3RhdGljIGludCBhbWRfaW9tbXVfZG9tYWluX2luaXQoc3RydWN0IGRv bWFpbiAqZCkKIHsKICAgICBzdHJ1Y3QgZG9tYWluX2lvbW11ICpoZCA9IGRv bV9pb21tdShkKTsKQEAgLTI1NywxMSArMjU5LDEzIEBAIHN0YXRpYyBpbnQg YW1kX2lvbW11X2RvbWFpbl9pbml0KHN0cnVjdAogICAgICAqIC0gSFZNIGNv dWxkIGluIHByaW5jaXBsZSB1c2UgMyBvciA0IGRlcGVuZGluZyBvbiBob3cg bXVjaCBndWVzdAogICAgICAqICAgcGh5c2ljYWwgYWRkcmVzcyBzcGFjZSB3 ZSBnaXZlIGl0LCBidXQgdGhpcyBpc24ndCBrbm93biB5ZXQgc28gdXNlIDQK ICAgICAgKiAgIHVuaWxhdGVyYWxseS4KKyAgICAgKiAtIFVuaXR5IG1hcHMg bWF5IHJlcXVpcmUgYW4gZXZlbiBoaWdoZXIgbnVtYmVyLgogICAgICAqLwot ICAgIGhkLT5hcmNoLmFtZC5wYWdpbmdfbW9kZSA9IGFtZF9pb21tdV9nZXRf cGFnaW5nX21vZGUoCi0gICAgICAgIGlzX2h2bV9kb21haW4oZCkKLSAgICAg ICAgPyAxdWwgPDwgKERFRkFVTFRfRE9NQUlOX0FERFJFU1NfV0lEVEggLSBQ QUdFX1NISUZUKQotICAgICAgICA6IGdldF91cHBlcl9tZm5fYm91bmQoKSAr IDEpOworICAgIGhkLT5hcmNoLmFtZC5wYWdpbmdfbW9kZSA9IG1heChhbWRf aW9tbXVfZ2V0X3BhZ2luZ19tb2RlKAorICAgICAgICAgICAgaXNfaHZtX2Rv bWFpbihkKQorICAgICAgICAgICAgPyAxdWwgPDwgKERFRkFVTFRfRE9NQUlO X0FERFJFU1NfV0lEVEggLSBQQUdFX1NISUZUKQorICAgICAgICAgICAgOiBn ZXRfdXBwZXJfbWZuX2JvdW5kKCkgKyAxKSwKKyAgICAgICAgYW1kX2lvbW11 X21pbl9wYWdpbmdfbW9kZSk7CiAKICAgICByZXR1cm4gMDsKIH0K --=separator Content-Type: application/octet-stream; name="xsa378/xsa378-7.patch" Content-Disposition: attachment; filename="xsa378/xsa378-7.patch" Content-Transfer-Encoding: base64 RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0 OiB4ODYvcDJtOiBpbnRyb2R1Y2UgcDJtX2lzX3NwZWNpYWwoKQoKU2VlaW5n IHRoZSBzaW1pbGFyaXR5IG9mIGdyYW50LCBmb3JlaWduLCBhbmQgKHN1YnNl cXVlbnRseSkgZGlyZWN0LU1NSU8KaGFuZGxpbmcsIGludHJvZHVjZSBhIG5l dyBQMk0gdHlwZSBncm91cCBuYW1lZCAic3BlY2lhbCIgKGFzIGluICJuZWVk aW5nCnNwZWNpYWwgYWNjZXNzb3JzIHRvIGNyZWF0ZS9kZXN0cm95IikuCgpB bHNvIHVzZSAtRVBFUk0gaW5zdGVhZCBvZiBvdGhlciBlcnJvciBjb2RlcyBv biB0aGUgdHdvIGRvbWFpbl9jcmFzaCgpCnBhdGhzIHRvdWNoZWQuCgpUaGlz IGlzIHBhcnQgb2YgWFNBLTM3OC4KClNpZ25lZC1vZmYtYnk6IEphbiBCZXVs aWNoIDxqYmV1bGljaEBzdXNlLmNvbT4KUmV2aWV3ZWQtYnk6IFBhdWwgRHVy cmFudCA8cGF1bEB4ZW4ub3JnPgotLS0Kdjg6IE5ldywgc3BsaXQgZnJvbSBz dWJzZXF1ZW50IHBhdGNoLgoKLS0tIGEveGVuL2FyY2gveDg2L21tL3AybS5j CisrKyBiL3hlbi9hcmNoL3g4Ni9tbS9wMm0uYwpAQCAtODE3LDcgKzgxNyw3 IEBAIHAybV9yZW1vdmVfcGFnZShzdHJ1Y3QgcDJtX2RvbWFpbiAqcDJtLAog ICAgICAgICBmb3IgKCBpID0gMDsgaSA8ICgxVUwgPDwgcGFnZV9vcmRlcik7 IGkrKyApCiAgICAgICAgIHsKICAgICAgICAgICAgIHAybS0+Z2V0X2VudHJ5 KHAybSwgZ2ZuX2FkZChnZm4sIGkpLCAmdCwgJmEsIDAsIE5VTEwsIE5VTEwp OwotICAgICAgICAgICAgaWYgKCAhcDJtX2lzX2dyYW50KHQpICYmICFwMm1f aXNfc2hhcmVkKHQpICYmICFwMm1faXNfZm9yZWlnbih0KSApCisgICAgICAg ICAgICBpZiAoICFwMm1faXNfc3BlY2lhbCh0KSAmJiAhcDJtX2lzX3NoYXJl ZCh0KSApCiAgICAgICAgICAgICAgICAgc2V0X2dwZm5fZnJvbV9tZm4obWZu X3gobWZuKSArIGksIElOVkFMSURfTTJQX0VOVFJZKTsKICAgICAgICAgfQog ICAgIH0KQEAgLTk1NCwxMyArOTU0LDEzIEBAIGd1ZXN0X3BoeXNtYXBfYWRk X2VudHJ5KHN0cnVjdCBkb21haW4gKmQKICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAmb3QsICZhLCAwLCBOVUxMLCBOVUxMKTsKICAgICAg ICAgICAgIEFTU0VSVCghcDJtX2lzX3NoYXJlZChvdCkpOwogICAgICAgICB9 Ci0gICAgICAgIGlmICggcDJtX2lzX2dyYW50KG90KSB8fCBwMm1faXNfZm9y ZWlnbihvdCkgKQorICAgICAgICBpZiAoIHAybV9pc19zcGVjaWFsKG90KSAp CiAgICAgICAgIHsKLSAgICAgICAgICAgIC8qIFJlYWxseSBzaG91bGRuJ3Qg YmUgdW5tYXBwaW5nIGdyYW50L2ZvcmVpZ24gbWFwcyB0aGlzIHdheSAqLwor ICAgICAgICAgICAgLyogRG9uJ3QgcGVybWl0IHVubWFwcGluZyBncmFudC9m b3JlaWduIHRoaXMgd2F5LiAqLwogICAgICAgICAgICAgZG9tYWluX2NyYXNo KGQpOwogICAgICAgICAgICAgcDJtX3VubG9jayhwMm0pOwogICAgICAgICAg ICAgCi0gICAgICAgICAgICByZXR1cm4gLUVJTlZBTDsKKyAgICAgICAgICAg IHJldHVybiAtRVBFUk07CiAgICAgICAgIH0KICAgICAgICAgZWxzZSBpZiAo IHAybV9pc19yYW0ob3QpICYmICFwMm1faXNfcGFnZWQob3QpICkKICAgICAg ICAgewpAQCAtMTA1Myw4ICsxMDUzLDcgQEAgaW50IHAybV9jaGFuZ2VfdHlw ZV9vbmUoc3RydWN0IGRvbWFpbiAqZAogICAgIHN0cnVjdCBwMm1fZG9tYWlu ICpwMm0gPSBwMm1fZ2V0X2hvc3RwMm0oZCk7CiAgICAgaW50IHJjOwogCi0g ICAgQlVHX09OKHAybV9pc19ncmFudChvdCkgfHwgcDJtX2lzX2dyYW50KG50 KSk7Ci0gICAgQlVHX09OKHAybV9pc19mb3JlaWduKG90KSB8fCBwMm1faXNf Zm9yZWlnbihudCkpOworICAgIEJVR19PTihwMm1faXNfc3BlY2lhbChvdCkg fHwgcDJtX2lzX3NwZWNpYWwobnQpKTsKIAogICAgIGdmbl9sb2NrKHAybSwg Z2ZuLCAwKTsKIApAQCAtMTMwMCwxMSArMTI5OSwxMSBAQCBzdGF0aWMgaW50 IHNldF90eXBlZF9wMm1fZW50cnkoc3RydWN0IGRvCiAgICAgICAgIGdmbl91 bmxvY2socDJtLCBnZm4sIG9yZGVyKTsKICAgICAgICAgcmV0dXJuIGN1cl9v cmRlciArIDE7CiAgICAgfQotICAgIGlmICggcDJtX2lzX2dyYW50KG90KSB8 fCBwMm1faXNfZm9yZWlnbihvdCkgKQorICAgIGlmICggcDJtX2lzX3NwZWNp YWwob3QpICkKICAgICB7CiAgICAgICAgIGdmbl91bmxvY2socDJtLCBnZm4s IG9yZGVyKTsKICAgICAgICAgZG9tYWluX2NyYXNoKGQpOwotICAgICAgICBy ZXR1cm4gLUVOT0VOVDsKKyAgICAgICAgcmV0dXJuIC1FUEVSTTsKICAgICB9 CiAgICAgZWxzZSBpZiAoIHAybV9pc19yYW0ob3QpICkKICAgICB7Ci0tLSBh L3hlbi9pbmNsdWRlL2FzbS14ODYvcDJtLmgKKysrIGIveGVuL2luY2x1ZGUv YXNtLXg4Ni9wMm0uaApAQCAtMTU0LDYgKzE1NCwxMCBAQCB0eXBlZGVmIHVu c2lnbmVkIGludCBwMm1fcXVlcnlfdDsKICAgICAgICAgICAgICAgICAgICAg ICAgICAgICB8IHAybV90b19tYXNrKHAybV9yYW1fbG9nZGlydHkpICkKICNk ZWZpbmUgUDJNX1NIQVJFRF9UWVBFUyAgIChwMm1fdG9fbWFzayhwMm1fcmFt X3NoYXJlZCkpCiAKKy8qIFR5cGVzIGVzdGFibGlzaGVkL2NsZWFuZWQgdXAg dmlhIHNwZWNpYWwgYWNjZXNzb3JzLiAqLworI2RlZmluZSBQMk1fU1BFQ0lB TF9UWVBFUyAoUDJNX0dSQU5UX1RZUEVTIHwgXAorICAgICAgICAgICAgICAg ICAgICAgICAgICAgcDJtX3RvX21hc2socDJtX21hcF9mb3JlaWduKSkKKwog LyogVmFsaWQgdHlwZXMgbm90IG5lY2Vzc2FyaWx5IGFzc29jaWF0ZWQgd2l0 aCBhICh2YWxpZCkgTUZOLiAqLwogI2RlZmluZSBQMk1fSU5WQUxJRF9NRk5f VFlQRVMgKFAyTV9QT0RfVFlQRVMgICAgICAgICAgICAgICAgICBcCiAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgfCBwMm1fdG9fbWFzayhwMm1f bW1pb19kaXJlY3QpIFwKQEAgLTE4Miw2ICsxODYsNyBAQCB0eXBlZGVmIHVu c2lnbmVkIGludCBwMm1fcXVlcnlfdDsKICNkZWZpbmUgcDJtX2lzX3BhZ2Vk KF90KSAgICAocDJtX3RvX21hc2soX3QpICYgUDJNX1BBR0VEX1RZUEVTKQog I2RlZmluZSBwMm1faXNfc2hhcmFibGUoX3QpIChwMm1fdG9fbWFzayhfdCkg JiBQMk1fU0hBUkFCTEVfVFlQRVMpCiAjZGVmaW5lIHAybV9pc19zaGFyZWQo X3QpICAgKHAybV90b19tYXNrKF90KSAmIFAyTV9TSEFSRURfVFlQRVMpCisj ZGVmaW5lIHAybV9pc19zcGVjaWFsKF90KSAgKHAybV90b19tYXNrKF90KSAm IFAyTV9TUEVDSUFMX1RZUEVTKQogI2RlZmluZSBwMm1faXNfYnJva2VuKF90 KSAgIChwMm1fdG9fbWFzayhfdCkgJiBQMk1fQlJPS0VOX1RZUEVTKQogI2Rl ZmluZSBwMm1faXNfZm9yZWlnbihfdCkgIChwMm1fdG9fbWFzayhfdCkgJiBw Mm1fdG9fbWFzayhwMm1fbWFwX2ZvcmVpZ24pKQogCg== --=separator Content-Type: application/octet-stream; name="xsa378/xsa378-8.patch" Content-Disposition: attachment; filename="xsa378/xsa378-8.patch" Content-Transfer-Encoding: base64 RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0 OiB4ODYvcDJtOiBndWFyZCAoaW4gcGFydGljdWxhcikgaWRlbnRpdHkgbWFw cGluZyBlbnRyaWVzCgpTdWNoIGVudHJpZXMsIGNyZWF0ZWQgYnkgc2V0X2lk ZW50aXR5X3AybV9lbnRyeSgpLCBzaG91bGQgb25seSBiZQpkZXN0cm95ZWQg YnkgY2xlYXJfaWRlbnRpdHlfcDJtX2VudHJ5KCkuIEhvd2V2ZXIsIHNpbWls YXJseSwgZW50cmllcwpjcmVhdGVkIGJ5IHNldF9tbWlvX3AybV9lbnRyeSgp IHNob3VsZCBvbmx5IGJlIHRvcm4gZG93biBieQpjbGVhcl9tbWlvX3AybV9l bnRyeSgpLCBzbyB0aGUgbG9naWMgZ2V0cyBiYXNlZCB1cG9uIHAybV9tbWlv X2RpcmVjdCBhcwp0aGUgZW50cnkgdHlwZSAoc2VwYXJhdGlvbiBiZXR3ZWVu ICJvcmRpbmFyeSIgYW5kIDE6MSBtYXBwaW5ncyB3b3VsZApyZXF1aXJlIGEg ZnVydGhlciBpbmRpY2F0b3IgdG8gdGVsbCBhcGFydCB0aGUgdHdvKS4KCkFz IHRvIHRoZSBndWVzdF9yZW1vdmVfcGFnZSgpIGNoYW5nZSwgY29tbWl0IDQ4 ZGZiMjk3YTIwYSAoIng4Ni9QVkg6CmFsbG93IGd1ZXN0X3JlbW92ZV9wYWdl IHRvIHJlbW92ZSBwMm1fbW1pb19kaXJlY3QgcGFnZXMiKSwgd2hpY2gKaW50 cm9kdWNlZCB0aGUgY2FsbCB0byBjbGVhcl9tbWlvX3AybV9lbnRyeSgpLCBj bGFpbWVkIHRoaXMgd2FzIGRvbmUgZm9yCmh3ZG9tIG9ubHkgd2l0aG91dCB0 aGlzIGFjdHVhbGx5IGhhdmluZyBiZWVuIHRoZSBjYXNlLiBIb3dldmVyLCB0 aGlzCmNvZGUgc2hvdWxkbid0IGJlIHRoZXJlIGluIHRoZSBmaXJzdCBwbGFj ZSwgYXMgTU1JTyBlbnRyaWVzIHNob3VsZG4ndCBiZQpkcm9wcGVkIHRoaXMg d2F5LiBBdm9pZCB0cmlnZ2VyaW5nIHRoZSB3YXJuaW5nIGFnYWluIHRoYXQg NDhkZmIyOTdhMjBhCnNpbGVuY2VkIGJ5IGFuIGFkanVzdG1lbnQgdG8geGVu bWVtX2FkZF90b19waHlzbWFwX29uZSgpIGluc3RlYWQuCgpOb3RlIHRoYXQg Z3Vlc3RfcGh5c21hcF9tYXJrX3BvcHVsYXRlX29uX2RlbWFuZCgpIGdldHMg dGlnaHRlbmVkIGJleW9uZAp0aGUgaW1tZWRpYXRlIHB1cnBvc2Ugb2YgdGhp cyBjaGFuZ2UuCgpOb3RlIGFsc28gdGhhdCBJIGRpZG4ndCBpbnNwZWN0IGNv ZGUgd2hpY2ggaXNuJ3Qgc2VjdXJpdHkgc3VwcG9ydGVkLAplLmcuIHNoYXJp bmcsIHBhZ2luZywgb3IgYWx0cDJtLgoKVGhpcyBpcyBDVkUtMjAyMS0yODY5 NCAvIHBhcnQgb2YgWFNBLTM3OC4KClNpZ25lZC1vZmYtYnk6IEphbiBCZXVs aWNoIDxqYmV1bGljaEBzdXNlLmNvbT4KUmV2aWV3ZWQtYnk6IFBhdWwgRHVy cmFudCA8cGF1bEB4ZW4ub3JnPgotLS0Kdjg6IFNwbGl0IG9mZiBpbnRyb2R1 Y3Rpb24gb2YgcDJtX2lzX3NwZWNpYWwoKS4Kdjc6IFJlLWJhc2UuCnY2OiBB bHNvIGFkanVzdCB4ZW5tZW1fYWRkX3RvX3BoeXNtYXBfb25lKCkuIEZ1bGx5 IGRyb3AgcDJtX21taW9fZGlyZWN0CiAgICBzcGVjaWFsIGhhbmRsaW5nIGZy b20gZ3Vlc3RfcmVtb3ZlX3BhZ2UoKTsganVzdCByZXR1cm4gYW4gZXJyb3Iu CiAgICBNYWtlIGNsZWFyX21taW9fcDJtX2VudHJ5KCkgc3RhdGljLgp2NTog TmV3LgotLS0KQmFja3BvcnRpbmcgbm90ZTogV2hpbGUgbGlrZWx5IG5vdGlj YWJsZSBieSBwYXRjaCBjb25mbGljdHMgYW55d2F5LCB0aGlzCmRlcGVuZHMg b24gb25lIG9yIGJvdGggb2YgYTZiMDUxYTg3YTU4ICgieDg2L3AybTogZG9u J3QgaWdub3JlCnAybV9yZW1vdmVfcGFnZSgpJ3MgcmV0dXJuIHZhbHVlIikg YW5kIGM2NWVhMTZkYmNhZiAoIng4Ni9wMm06IGRvbid0CmFzc2VydCB0aGF0 IHRoZSBwYXNzZWQgaW4gTUZOIG1hdGNoZXMgZm9yIGEgcmVtb3ZlIikuCgot LS0gYS94ZW4vYXJjaC94ODYvbW0vcDJtLmMKKysrIGIveGVuL2FyY2gveDg2 L21tL3AybS5jCkBAIC04MDUsNyArODA1LDggQEAgcDJtX3JlbW92ZV9wYWdl KHN0cnVjdCBwMm1fZG9tYWluICpwMm0sCiAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAmY3VyX29yZGVyLCBOVUxMKTsKIAog ICAgICAgICBpZiAoIHAybV9pc192YWxpZCh0KSAmJgotICAgICAgICAgICAg ICghbWZuX3ZhbGlkKG1mbikgfHwgIW1mbl9lcShtZm5fYWRkKG1mbiwgaSks IG1mbl9yZXR1cm4pKSApCisgICAgICAgICAgICAgKCFtZm5fdmFsaWQobWZu KSB8fCB0ID09IHAybV9tbWlvX2RpcmVjdCB8fAorICAgICAgICAgICAgICAh bWZuX2VxKG1mbl9hZGQobWZuLCBpKSwgbWZuX3JldHVybikpICkKICAgICAg ICAgICAgIHJldHVybiAtRUlMU0VROwogCiAgICAgICAgIGkgKz0gKDFVTCA8 PCBjdXJfb3JkZXIpIC0KQEAgLTkxMiw3ICs5MTMsNyBAQCBndWVzdF9waHlz bWFwX2FkZF9lbnRyeShzdHJ1Y3QgZG9tYWluICpkCiAgICAgaWYgKCBwMm1f aXNfZm9yZWlnbih0KSApCiAgICAgICAgIHJldHVybiAtRUlOVkFMOwogCi0g ICAgaWYgKCAhbWZuX3ZhbGlkKG1mbikgKQorICAgIGlmICggIW1mbl92YWxp ZChtZm4pIHx8IHQgPT0gcDJtX21taW9fZGlyZWN0ICkKICAgICB7CiAgICAg ICAgIEFTU0VSVF9VTlJFQUNIQUJMRSgpOwogICAgICAgICByZXR1cm4gLUVJ TlZBTDsKQEAgLTk1Niw3ICs5NTcsNyBAQCBndWVzdF9waHlzbWFwX2FkZF9l bnRyeShzdHJ1Y3QgZG9tYWluICpkCiAgICAgICAgIH0KICAgICAgICAgaWYg KCBwMm1faXNfc3BlY2lhbChvdCkgKQogICAgICAgICB7Ci0gICAgICAgICAg ICAvKiBEb24ndCBwZXJtaXQgdW5tYXBwaW5nIGdyYW50L2ZvcmVpZ24gdGhp cyB3YXkuICovCisgICAgICAgICAgICAvKiBEb24ndCBwZXJtaXQgdW5tYXBw aW5nIGdyYW50L2ZvcmVpZ24vZGlyZWN0LU1NSU8gdGhpcyB3YXkuICovCiAg ICAgICAgICAgICBkb21haW5fY3Jhc2goZCk7CiAgICAgICAgICAgICBwMm1f dW5sb2NrKHAybSk7CiAgICAgICAgICAgICAKQEAgLTEzNjQsOCArMTM2NSw4 IEBAIGludCBzZXRfbW1pb19wMm1fZW50cnkoc3RydWN0IGRvbWFpbiAqZCwK ICAqICAgIG9yZGVyKzEgIGZvciBjYWxsZXIgdG8gcmV0cnkgd2l0aCBvcmRl ciAoZ3VhcmFudGVlZCBzbWFsbGVyIHRoYW4KICAqICAgICAgICAgICAgIHRo ZSBvcmRlciB2YWx1ZSBwYXNzZWQgaW4pCiAgKi8KLWludCBjbGVhcl9tbWlv X3AybV9lbnRyeShzdHJ1Y3QgZG9tYWluICpkLCB1bnNpZ25lZCBsb25nIGdm bl9sLCBtZm5fdCBtZm4sCi0gICAgICAgICAgICAgICAgICAgICAgICAgdW5z aWduZWQgaW50IG9yZGVyKQorc3RhdGljIGludCBjbGVhcl9tbWlvX3AybV9l bnRyeShzdHJ1Y3QgZG9tYWluICpkLCB1bnNpZ25lZCBsb25nIGdmbl9sLAor ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBtZm5fdCBtZm4sIHVu c2lnbmVkIGludCBvcmRlcikKIHsKICAgICBpbnQgcmMgPSAtRUlOVkFMOwog ICAgIGdmbl90IGdmbiA9IF9nZm4oZ2ZuX2wpOwpAQCAtMjc2Niw3ICsyNzY3 LDkgQEAgaW50IHhlbm1lbV9hZGRfdG9fcGh5c21hcF9vbmUoCiAKICAgICAv KiBSZW1vdmUgcHJldmlvdXNseSBtYXBwZWQgcGFnZSBpZiBpdCB3YXMgcHJl c2VudC4gKi8KICAgICBwcmV2X21mbiA9IGdldF9nZm4oZCwgZ2ZuX3goZ3Bm biksICZwMm10KTsKLSAgICBpZiAoIG1mbl92YWxpZChwcmV2X21mbikgKQor ICAgIGlmICggcDJtdCA9PSBwMm1fbW1pb19kaXJlY3QgKQorICAgICAgICBy YyA9IC1FUEVSTTsKKyAgICBlbHNlIGlmICggbWZuX3ZhbGlkKHByZXZfbWZu KSApCiAgICAgewogICAgICAgICBpZiAoIGlzX3NwZWNpYWxfcGFnZShtZm5f dG9fcGFnZShwcmV2X21mbikpICkKICAgICAgICAgICAgIC8qIFNwZWNpYWwg cGFnZXMgYXJlIHNpbXBseSB1bmhvb2tlZCBmcm9tIHRoaXMgcGh5cyBzbG90 LiAqLwotLS0gYS94ZW4vYXJjaC94ODYvbW0vcDJtLXBvZC5jCisrKyBiL3hl bi9hcmNoL3g4Ni9tbS9wMm0tcG9kLmMKQEAgLTEyOTksMTcgKzEyOTksMTcg QEAgZ3Vlc3RfcGh5c21hcF9tYXJrX3BvcHVsYXRlX29uX2RlbWFuZChzdAog CiAgICAgICAgIHAybS0+Z2V0X2VudHJ5KHAybSwgZ2ZuX2FkZChnZm4sIGkp LCAmb3QsICZhLCAwLCAmY3VyX29yZGVyLCBOVUxMKTsKICAgICAgICAgbiA9 IDFVTCA8PCBtaW4ob3JkZXIsIGN1cl9vcmRlcik7Ci0gICAgICAgIGlmICgg cDJtX2lzX3JhbShvdCkgKQorICAgICAgICBpZiAoIG90ID09IHAybV9wb3B1 bGF0ZV9vbl9kZW1hbmQgKQorICAgICAgICB7CisgICAgICAgICAgICAvKiBD b3VudCBob3cgbWFueSBQb0QgZW50cmllcyB3ZSdsbCBiZSByZXBsYWNpbmcg aWYgc3VjY2Vzc2Z1bCAqLworICAgICAgICAgICAgcG9kX2NvdW50ICs9IG47 CisgICAgICAgIH0KKyAgICAgICAgZWxzZSBpZiAoIG90ICE9IHAybV9pbnZh bGlkICYmIG90ICE9IHAybV9tbWlvX2RtICkKICAgICAgICAgewogICAgICAg ICAgICAgUDJNX0RFQlVHKCJnZm5fdG9fbWZuIHJldHVybmVkIHR5cGUgJWQh XG4iLCBvdCk7CiAgICAgICAgICAgICByYyA9IC1FQlVTWTsKICAgICAgICAg ICAgIGdvdG8gb3V0OwogICAgICAgICB9Ci0gICAgICAgIGVsc2UgaWYgKCBv dCA9PSBwMm1fcG9wdWxhdGVfb25fZGVtYW5kICkKLSAgICAgICAgewotICAg ICAgICAgICAgLyogQ291bnQgaG93IG1hbiBQb0QgZW50cmllcyB3ZSdsbCBi ZSByZXBsYWNpbmcgaWYgc3VjY2Vzc2Z1bCAqLwotICAgICAgICAgICAgcG9k X2NvdW50ICs9IG47Ci0gICAgICAgIH0KICAgICB9CiAKICAgICAvKiBOb3cs IGFjdHVhbGx5IGRvIHRoZSB0d28td2F5IG1hcHBpbmcgKi8KLS0tIGEveGVu L2NvbW1vbi9tZW1vcnkuYworKysgYi94ZW4vY29tbW9uL21lbW9yeS5jCkBA IC0zMzIsNyArMzMyLDcgQEAgaW50IGd1ZXN0X3JlbW92ZV9wYWdlKHN0cnVj dCBkb21haW4gKmQsCiAgICAgfQogICAgIGlmICggcDJtdCA9PSBwMm1fbW1p b19kaXJlY3QgKQogICAgIHsKLSAgICAgICAgcmMgPSBjbGVhcl9tbWlvX3Ay bV9lbnRyeShkLCBnbWZuLCBtZm4sIFBBR0VfT1JERVJfNEspOworICAgICAg ICByYyA9IC1FUEVSTTsKICAgICAgICAgZ290byBvdXRfcHV0X2dmbjsKICAg ICB9CiAjZWxzZQpAQCAtMTg4OCw2ICsxODg4LDE1IEBAIGludCBjaGVja19n ZXRfcGFnZV9mcm9tX2dmbihzdHJ1Y3QgZG9tYWkKICAgICAgICAgcmV0dXJu IC1FQUdBSU47CiAgICAgfQogI2VuZGlmCisjaWZkZWYgQ09ORklHX1g4Ngor ICAgIGlmICggcDJtdCA9PSBwMm1fbW1pb19kaXJlY3QgKQorICAgIHsKKyAg ICAgICAgaWYgKCBwYWdlICkKKyAgICAgICAgICAgIHB1dF9wYWdlKHBhZ2Up OworCisgICAgICAgIHJldHVybiAtRVBFUk07CisgICAgfQorI2VuZGlmCiAK ICAgICBpZiAoICFwYWdlICkKICAgICAgICAgcmV0dXJuIC1FSU5WQUw7Ci0t LSBhL3hlbi9pbmNsdWRlL2FzbS14ODYvcDJtLmgKKysrIGIveGVuL2luY2x1 ZGUvYXNtLXg4Ni9wMm0uaApAQCAtMTU2LDcgKzE1Niw4IEBAIHR5cGVkZWYg dW5zaWduZWQgaW50IHAybV9xdWVyeV90OwogCiAvKiBUeXBlcyBlc3RhYmxp c2hlZC9jbGVhbmVkIHVwIHZpYSBzcGVjaWFsIGFjY2Vzc29ycy4gKi8KICNk ZWZpbmUgUDJNX1NQRUNJQUxfVFlQRVMgKFAyTV9HUkFOVF9UWVBFUyB8IFwK LSAgICAgICAgICAgICAgICAgICAgICAgICAgIHAybV90b19tYXNrKHAybV9t YXBfZm9yZWlnbikpCisgICAgICAgICAgICAgICAgICAgICAgICAgICBwMm1f dG9fbWFzayhwMm1fbWFwX2ZvcmVpZ24pIHwgXAorICAgICAgICAgICAgICAg ICAgICAgICAgICAgcDJtX3RvX21hc2socDJtX21taW9fZGlyZWN0KSkKIAog LyogVmFsaWQgdHlwZXMgbm90IG5lY2Vzc2FyaWx5IGFzc29jaWF0ZWQgd2l0 aCBhICh2YWxpZCkgTUZOLiAqLwogI2RlZmluZSBQMk1fSU5WQUxJRF9NRk5f VFlQRVMgKFAyTV9QT0RfVFlQRVMgICAgICAgICAgICAgICAgICBcCkBAIC02 MjcsMTkgKzYyOCw5IEBAIGludCBwMm1fZmluaXNoX3R5cGVfY2hhbmdlKHN0 cnVjdCBkb21haW4KIGludCBwMm1faXNfbG9nZGlydHlfcmFuZ2Uoc3RydWN0 IHAybV9kb21haW4gKiwgdW5zaWduZWQgbG9uZyBzdGFydCwKICAgICAgICAg ICAgICAgICAgICAgICAgICAgdW5zaWduZWQgbG9uZyBlbmQpOwogCi0jaWZk ZWYgQ09ORklHX0hWTQogLyogU2V0IG1taW8gYWRkcmVzc2VzIGluIHRoZSBw Mm0gdGFibGUgKGZvciBwYXNzLXRocm91Z2gpICovCiBpbnQgc2V0X21taW9f cDJtX2VudHJ5KHN0cnVjdCBkb21haW4gKmQsIGdmbl90IGdmbiwgbWZuX3Qg bWZuLAogICAgICAgICAgICAgICAgICAgICAgICB1bnNpZ25lZCBpbnQgb3Jk ZXIpOwotaW50IGNsZWFyX21taW9fcDJtX2VudHJ5KHN0cnVjdCBkb21haW4g KmQsIHVuc2lnbmVkIGxvbmcgZ2ZuLCBtZm5fdCBtZm4sCi0gICAgICAgICAg ICAgICAgICAgICAgICAgdW5zaWduZWQgaW50IG9yZGVyKTsKLSNlbHNlCi1z dGF0aWMgaW5saW5lIGludCBjbGVhcl9tbWlvX3AybV9lbnRyeShzdHJ1Y3Qg ZG9tYWluICpkLCB1bnNpZ25lZCBsb25nIGdmbiwKLSAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIG1mbl90IG1mbiwgdW5zaWduZWQg aW50IG9yZGVyKQotewotICAgIHJldHVybiAtRUlPOwotfQotI2VuZGlmCiAK IC8qIFNldCBpZGVudGl0eSBhZGRyZXNzZXMgaW4gdGhlIHAybSB0YWJsZSAo Zm9yIHBhc3MtdGhyb3VnaCkgKi8KIGludCBzZXRfaWRlbnRpdHlfcDJtX2Vu dHJ5KHN0cnVjdCBkb21haW4gKmQsIHVuc2lnbmVkIGxvbmcgZ2ZuLAo= --=separator-- From xen-devel-bounces@lists.xenproject.org Wed Sep 01 09:38:52 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Sep 2021 09:38:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.176234.320694 (Exim 4.92) (envelope-from ) id 1mLMhd-0002Ib-Ta; Wed, 01 Sep 2021 09:38:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 176234.320694; Wed, 01 Sep 2021 09:38:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLMhd-0002IU-Pr; Wed, 01 Sep 2021 09:38:41 +0000 Received: by outflank-mailman (input) for mailman id 176234; Wed, 01 Sep 2021 09:38:40 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLMhc-0002IO-OD for xen-devel@lists.xenproject.org; Wed, 01 Sep 2021 09:38:40 +0000 Received: from foss.arm.com (unknown [217.140.110.172]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTP id 62c9ef60-0b08-11ec-adbf-12813bfff9fa; Wed, 01 Sep 2021 09:38:38 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4A07B1FB; Wed, 1 Sep 2021 02:38:38 -0700 (PDT) Received: from [10.57.13.24] (unknown [10.57.13.24]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0E67D3F766; Wed, 1 Sep 2021 02:38:36 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 62c9ef60-0b08-11ec-adbf-12813bfff9fa Subject: Re: [PATCH v2] xen/arm64: Remove vreg_emulate_sysreg32 To: Julien Grall , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Volodymyr Babchuk , bertrand.marquis@arm.com, Ash Wilding , Ian Jackson References: <20210729104258.6320-1-michal.orzel@arm.com> <4a5ac822-3078-de0e-8f84-6881d47ad3eb@xen.org> From: Michal Orzel Message-ID: <8974fc82-94c1-ef85-153c-0923f5faf331@arm.com> Date: Wed, 1 Sep 2021 11:38:27 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Hi Julien, On 06.08.2021 13:12, Julien Grall wrote: > > > On 29/07/2021 12:47, Michal Orzel wrote: >> Hi Julien, > > Hi Michal, > >> On 29.07.2021 13:20, Julien Grall wrote: >>> Hi Michal, >>> >>> On 29/07/2021 11:42, Michal Orzel wrote: >>>> According to ARMv8A architecture, AArch64 registers >>>> are 64bit wide even though in many cases the upper >>>> 32bit is reserved. Therefore there is no need for >>>> function vreg_emulate_sysreg32 on arm64. This means >>>> that we can have just one function vreg_emulate_sysreg >>>> using new function pointer: >>>> typedef bool (*vreg_reg_fn_t)(struct cpu_user_regs *regs, >>>>                                 register_t *r, bool read); >>>> >>>> Modify vreg_emulate_cp32 to use the new function pointer >>>> as well. >>>> >>>> This change allows to properly use 64bit registers in AArch64 >>>> state and in case of AArch32 the upper 32 bits of AArch64 >>>> registers are inaccessible and are ignored(D1.20.1 ARM DDI 0487A.j). >>> >>> What you wrote only says that the bits are ignored. It doesn't say whether the bits will be 0. >>> >>> They are probably, but as I wrote yesterday, I couldn't confirm it. >>> >> Should I then remove this part of the commit or write below?: >> "We can assume that those bits will be 0 but the architecture >> reference manual does not clarify this." > > There was some back and forth on security@xen.org about this. I will summarizing the discussion here as we considered this was a just a bug. > > I wasn't looking at the correct section in the Arm Arm. There is a paragraph clearly describing the expected behavior in a different section (thanks Ash for the pointer!). Per section D1.19.2 in DDI 0487F.c: > > " > If the general-purpose register was accessible from AArch32 state > > The upper 32 bits either become zero, or hold the value that the same architectural register held before any AArch32 execution. The choice between these two options is IMPLEMENTATION DEFINED, and might vary dynamically within an implementation. Correspondingly, software must > regard the value as being a CONSTRAINED UNPREDICTABLE choice between these two values. > > This behavior applies regardless of whether any execution occurred at the Exception level that was using AArch32. That is, this behavior applies even if AArch32 state was entered by an exception > return from AArch64 state, and another exception was immediately taken to AArch64 state without any instruction execution in AArch32 state. > " > > So we can't assume the top 32-bits are zeroed unless the hypervisor ensured they were. Today, we don't have that guarantee in Xen. > > This needs to be fixed. The two approachs we discussed are: >    1) Update set_user_reg() to zero the top 32-bit. We have a couple of places using directly the fields xN. So we would need to switch them to use set_user_reg() >    2) Only saving/restoring the bottom 32-bit when entering/leaving the hypervisor. > > At the moment, my preference goes towards the latter because we don't risk to introduce new place where set_user_reg() is not used. > > I have quickly hack the entry path. This would look like: > > diff --git a/xen/arch/arm/arm64/entry.S b/xen/arch/arm/arm64/entry.S > index fc3811ad0ad5..65e24c88b059 100644 > --- a/xen/arch/arm/arm64/entry.S > +++ b/xen/arch/arm/arm64/entry.S > @@ -111,6 +111,11 @@ >   */ >          .macro  entry, hyp, compat, save_x0_x1=1 >          sub     sp, sp, #(UREGS_SPSR_el1 - UREGS_LR) /* CPSR, PC, SP, LR */ > +        .if \compat == 1 /* AArch32 mode */ > +        /* Clobber the top 32-bit of the registers */ > +        mov    w0, w0 > +        mov    w1, w1 > +        .endif >          push    x28, x29 >          push    x26, x27 >          push    x24, x25 > > I haven't looked whether this can be optimized or the exit path would be easier to modify. > > Anyway, this is not a new bug so I would be fine to get this patch merged first. Although, I think this wants to be fixed for xen 4.16 (CCing Ian to track it). > > I will try to find sometimes in the next couple of weeks to fix it and have another review of this patch. > As the 4.16 release is getting closer I wanted to ask whether you need help with creating a pre-work patch so that this patch can be merged. I believe this patch wants to be merged for 4.16 as the other sysreg related patches are merged already, so I'm offering a help. > Cheers, > Cheers, Michal From xen-devel-bounces@lists.xenproject.org Wed Sep 01 09:53:27 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Sep 2021 09:53:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.176242.320705 (Exim 4.92) (envelope-from ) id 1mLMvg-0004yM-6b; Wed, 01 Sep 2021 09:53:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 176242.320705; Wed, 01 Sep 2021 09:53:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLMvg-0004yF-2X; Wed, 01 Sep 2021 09:53:12 +0000 Received: by outflank-mailman (input) for mailman id 176242; Wed, 01 Sep 2021 09:53:10 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLMve-0004y9-Im for xen-devel@lists.xenproject.org; Wed, 01 Sep 2021 09:53:10 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 69716eea-0b0a-11ec-adc0-12813bfff9fa; Wed, 01 Sep 2021 09:53:09 +0000 (UTC) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05lp2172.outbound.protection.outlook.com [104.47.17.172]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-18-dFfHWNfUN2y5W7OlfD3puw-1; Wed, 01 Sep 2021 11:53:07 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR04MB4941.eurprd04.prod.outlook.com (2603:10a6:803:5a::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19; Wed, 1 Sep 2021 09:53:06 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4478.019; Wed, 1 Sep 2021 09:53:06 +0000 Received: from [10.156.60.236] (37.24.206.209) by FR3P281CA0061.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4b::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.12 via Frontend Transport; Wed, 1 Sep 2021 09:53:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 69716eea-0b0a-11ec-adc0-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1630489988; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Z1EDBZu0WpUcHKjJqurIDGUHD3q1CvmzH/q+2dgnymM=; b=UNOuXtzX1WfS4Itl56Dniar6aziQvRhPOOwbMiGAejyfT7/wL/Ubbk25sJyRzmhSmE6PHv yQ4E2CGTUKEb5NVdthKesxgynyJf9aTliPgx9MVWgIwPhz2rWvYw0vqIAYI20QdgjtqdB+ 3PSmNuEiYrsNHvU3Q6CUg9XjQHDaWQ0= X-MC-Unique: dFfHWNfUN2y5W7OlfD3puw-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kOi5t8fkV7mE3oEPg24gICc669mhOlN2DGhKYKFInlEE5E5f3L7o2Yb+t+z7q3qvxomxmiDN6DtDXCux36Zd/3v/ErklmaWGch1hWV3GV47QBNYUu8uftl1noVPv3g+JyVx97pvYxIso4i5YxraU/lOdiCoHNXk/ZOiyqjXH7qWL5GdZJq1u+bZbLuXt/rJtM6tXz8Bb0pe+gd46r4CuUpznztHqEbfEXaVrnykhkhVmT25gM1xz5nsbLC/TzRFHrwkXMBTJJOwn4gxg0LFTo8P64BCO5hdYZm9JLA9jn6Y/n3xaUVjbysMiEeaKljmqYJHgeVeGkaYGhQr+Eaeixw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=AT3M3+5f9uqBf3l+DjU+HB2tK3g3eHcn74+2vK7NM2E=; b=lQyb7C5MKqEA1yrFo9gCTwm/ewjumtyAPB9SBH0TStIruQaZ+OyYE9AqXFn/+X39URQG6FouLPWbVPQ1Sv2c21YVl6lNqOwXgQ1b+ZpCyTclEOv+VU7SLwRlGQ07hp+5LgzBwNUXFp5mJWUttIZcHIwk1Ufd9A1qdwGkjUCtlZ0DRLdlg5YjXhCKJbHCwAgacQTeaOTmiO4QJ8hd579Zjb/fXZuwHr7wYagmt4QLE8DoY7Vr5VO/dYLJ63LGz23NXIpmLDQG8hMEaiP7Fw6WGqLczLnNuf+CGBnH54OGxolpQ2UYIBxgfO1F8Ldouv0+289P7Ckstf3/kTen9rcQXA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com; Subject: Re: [PATCH 2/4] x86/P2M: relax guarding of MMIO entries To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= CC: Andrew Cooper , Wei Liu , "xen-devel@lists.xenproject.org" References: <93ecc397-1293-69b1-e70d-3c5f9317229a@suse.com> <7f56c625-eee6-31c4-2d6f-bd7334867d83@citrix.com> <5d69d4c0-7a04-c3da-f971-616363c6d63d@suse.com> From: Jan Beulich Message-ID: Date: Wed, 1 Sep 2021 11:53:03 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: FR3P281CA0061.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4b::9) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2f4b8d0a-9d7b-4713-6a83-08d96d2e4bdb X-MS-TrafficTypeDiagnostic: VI1PR04MB4941: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: eC9GN7Dwb2K0It89krZxNDB32XENRWHOYuEPmP3LUra9psOcaSi+8YDuX7gqOhyB7qvyPNoC7f1XCJ51iRN0xPlZatzgIme+WiYUgzX5GPEftKOmmF41AtyFF/RwqxGNDBhCOBmHhlKx4emEzqJ7sR1Rk/Z3fcJPT2mCCNlCQlh6FwSxe9VadpNRtTX+XNgOeBEiS3e8DtNTkJtHWony2+YNmHkbzybIisnV5AG/A1Uvg08yhGvxUXkHuZuxRh4zh1FYTlkneMUKTzlEHdMUI4Gb9a69wNyUcwyLbPMzqnoXbA1ycYNOL6NHlrweDUAMXNRYWOFP5XYoHqoIUD5qKSTO4GkOK2XrIcXaIluVSQIkVTOjPbdZEAwy1uj8Hipnfox0J5ul/6pUqxQz6aGSo7FUejnSTD6DyP6WONs2VGJNQrGGOjlpmpeG5DyqgLiKUxx5GWZluEkYF7jKwZbPCjmSSYkjLkDDakZr2ibAH96Y4fZg/aYy+RYTFK1xZI+HlfZtswGhQhxFQHXVUbtk1qxl4G3J9OrhLWIAycJotEfU3kIFSqK8yZCm3TTuz3b1xCr3iK4CqcOBe1BntJSsAzij3f7uneEJBr+x+9h/TcqHhLr+pF+G/FDXXiqpNK6mFnOddfJUM98FBpi3efJ1DO9LeKu0ShP+OM10aSX4//LT6dxnUhvrDrMeW35QcXid7HrDUzRyAdesf/T3w/QPI/EojMsbJCekYynY4QRX3VA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(66946007)(956004)(31696002)(26005)(83380400001)(2616005)(186003)(53546011)(66556008)(2906002)(38100700002)(66476007)(86362001)(4326008)(5660300002)(8676002)(6916009)(8936002)(316002)(16576012)(36756003)(31686004)(6486002)(508600001)(54906003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?2OhPcru4d2grG4422h733Ol2f5dSOxofVAdgTIvYWv8Q1PBMQfOkaEls9j2g?= =?us-ascii?Q?u+GflmQVa+ejP0iqBD1/L/kLcBg7NnV02G5PYEdhQoP7pjNs62WpPebToxZe?= =?us-ascii?Q?lhlqs0DNxq15cxg1fIBR3xRMfcN/64kBrKyy2PLFcGjByi9vjL6tbclezImI?= =?us-ascii?Q?J5HjjBUAbfyVbUwWwDWLtcpx3tcFPgrs0DIXV+bIaKXZ1qPEWze8Zp8DcBiD?= =?us-ascii?Q?57tIAnu1CF32O9Qd/RrYBCpHUtKfVuLwAU0JxONIEYvT35Ru7dPI93Zbxpmd?= =?us-ascii?Q?q/SHOl7l8KXxQIyyR+btlVokmJypx6SQk73jC9fmFaDJK/Rukarqf1mstOAg?= =?us-ascii?Q?/yvJdPXk56IJ8KkGogYGosUTHAM9vAOAx4Q3w+MzUZLG+eAq97YNvDcqJGeo?= =?us-ascii?Q?T/zlntkC73EfCli3z3P3tqr0IW/he+CeKfm6sE24myOrGbNp4QtNXXCmxrkC?= =?us-ascii?Q?L6ZeQ4qEzl4HrxtfOJc05jxi4MsDnQFfLJN53arpwEIWRe66yIfruqxw3NiT?= =?us-ascii?Q?vdv3QD1aTaOrpRGNrb0msZL/9uDTjCCRzTUtsmkegGXsr7Ff+9ZpV78DotPC?= =?us-ascii?Q?WrAXUkGj4G5szt45ElWio3KQZ6aVs96t2HaRGNfwmxeKV+uMKg8MzAxtylSl?= =?us-ascii?Q?NM6y2wbNrYEgjLoUlNu3sE9E3xEnc8Gf5pFealmR9K8deXkzTbQSwLHz74ie?= =?us-ascii?Q?urh1rSa16AUKzXhRkU9hwo+85ef2L/BAGf0E8X0o5ShcJnPyKAkg53rDhiy9?= =?us-ascii?Q?qFrpkz22iz5RIg6YfYZgqjdxm1TO2VqpGGkjciSG0mRYmnQAUUiuWQNOuJjh?= =?us-ascii?Q?FwOVDZjjzO9eBkZWNw71SB7wm1kUOw9L6z7MlR1aF/S3dCoBZFYUPhKCHc+m?= =?us-ascii?Q?/7fbn+h2iwNJ88nYW1kJ7gO8v2T9621y37gGfS19r5jGH3luW2DK07NGFn0G?= =?us-ascii?Q?ceDf6WJ57tDxQFVglZ9ruiK/gnpbPB0Qy16+p8FMNYsoBgvVR2t4vh5R7aor?= =?us-ascii?Q?pbtkjuu7soFyHImm5IlfK93F8edjNTdwRKyG47Zli+obl00XOjTkxghJ9VUp?= =?us-ascii?Q?nfMHbBTB4n7wQQpil4aR9bdRU59qbmKasHw2qR92WEE4GCCYEobue6pTp8Gs?= =?us-ascii?Q?MEJoLQKuWtJv5AI3KQTWgEg6QS43256DCFt/kcc3nVRw2p+k+5vi50VZG/6L?= =?us-ascii?Q?6YI7RD8s+41lVOPILhRP4WO2st7wlmQ0KLjJQBObpG7IXfPKRcN+vCrzZwVq?= =?us-ascii?Q?GJrBuMXR/K1ch/4ZHpic+f/fwDRjCtuqrtkLgaFy6q78cnwxxRia0YD32TAR?= =?us-ascii?Q?OSYGGS4l9K8Uzk0FeMa0yZnI?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2f4b8d0a-9d7b-4713-6a83-08d96d2e4bdb X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Sep 2021 09:53:05.9119 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: aWyzBaQ+tWpHjtK26mhZaY13nCRp3OblQzNH0pRVS17/dKr513B+aBu2pMppvD5ymovagzHSvPZxjkBpgtaPxg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4941 On 01.09.2021 10:50, Roger Pau Monn=C3=A9 wrote: > On Tue, Aug 31, 2021 at 05:38:49PM +0200, Jan Beulich wrote: >> On 31.08.2021 17:25, Andrew Cooper wrote: >>> On 31/08/2021 14:26, Jan Beulich wrote: >>>> On 31.08.2021 15:16, Andrew Cooper wrote: >>>>> On 30/08/2021 14:02, Jan Beulich wrote: >>>>>> Further permit "access" to differ in the "executable" attribute. Whi= le >>>>>> ideally only ROM regions would get mapped with X set, getting there = is >>>>>> quite a bit of work. Therefore, as a temporary measure, permit X to >>>>>> vary. For Dom0 the more permissive of the types will be used, while = for >>>>>> DomU it'll be the more restrictive one. >>>>> Split behaviour between dom0 and domU based on types alone cannot >>>>> possibly be correct. >>>> True, but what do you do. >>>> >>>>> DomU's need to execute ROMs too, and this looks like will malfunction= if >>>>> a ROM ends up in the region that HVMLoader relocated RAM from. >>>>> >>>>> As this is a temporary bodge emergency bugfix, don't try to be clever= - >>>>> just take the latest access. >>>> And how do we know that that's what is going to work? >>> >>> Because it's the pre-existing behaviour. >> >> Valid point. But for the DomU case there simply has not been any >> pre-existing behavior. Hence my desire to be restrictive initially >> there. >> >>>> We should >>>> strictly accumulate for Dom0. And what we do for DomU is moot for >>>> the moment, until PCI passthrough becomes a thing for PVH. Hence >>>> I've opted to be restrictive there - I'd rather see things break >>>> (and getting adjusted) when this future work actually gets carried >>>> out, than leave things permissive for no-one to notice that it's >>>> too permissive, leading to an XSA. >>> >>> Restricting execute permissions is something unique to virt.=C2=A0 It d= oesn't >>> exist in a non-virtualised system, as I and D side reads are >>> indistinguishable outside of the core. >>> >>> Furthermore, it is inexpressible on some systems/configurations. >>> >>> Introspection is the only technology which should be restricting execut= e >>> permissions in the p2m, and only when it takes responsibility for >>> dealing with the fallout. >> >> IOW are you saying that the calls to set_identity_p2m_entry() >> (pre-dating XSA-378) were wrong to use p2m_access_rw? Because that's >> what's getting the way here. >=20 > I did wonder this before, because I saw some messages on a couple of > systems about mappings override, and I'm not sure why we need to use > p2m_access_rw. My first thought was to suggest to switch to use the > default access type for the domain, like set_mmio_p2m_entry does. >=20 > I have to admit I'm not sure I see the point of preventing execution, > but it's possible I'm missing something. Well, what good can come from allowing execution from, say, the IO-APIC or LAPIC pages? Or other MMIO-mapped register space? Insn fetches might even trip bad hardware behavior in such a case by being the wrong granularity. It's imo really only ROM space which ought to have execution permitted. The issue isn't just with execution, though, and as a result I may need to change the logic here to also include at least W. As of one of the XSA-378 changes we may now pass just p2m_access_r to iommu_identity_mapping(), if the ACPI tables on an AMD system were saying so. (We may also pass p2m_access_w, but I sincerely hope no firmware would specify write but no read access.) Similarly in "IOMMU/x86: restrict IO-APIC mappings for PV Dom0" I now pass p2m_access_r to set_identity_p2m_entry(). I suppose an underlying issue is the mixed purpose of using p2m_access_*, which possibly has been against the intentions in the first place. We cannot, for example, express r/o access to an MMIO page without using p2m_access_r (or p2m_access_rx), as there's no suitable p2m type to express this via type alone. We may need to split p2m_mmio_direct into multiple types (up to 7), I guess, if we wanted to remove this (ab)use of p2m_access_*. Jan From xen-devel-bounces@lists.xenproject.org Wed Sep 01 09:53:44 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Sep 2021 09:53:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.176246.320716 (Exim 4.92) (envelope-from ) id 1mLMwC-0005TN-F2; Wed, 01 Sep 2021 09:53:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 176246.320716; Wed, 01 Sep 2021 09:53:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLMwC-0005TG-C0; Wed, 01 Sep 2021 09:53:44 +0000 Received: by outflank-mailman (input) for mailman id 176246; Wed, 01 Sep 2021 09:53:42 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLMwA-0005Sz-LP for xen-devel@lists.xenproject.org; Wed, 01 Sep 2021 09:53:42 +0000 Received: from smtp-out2.suse.de (unknown [195.135.220.29]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 923e60a0-1d40-42e7-946d-0916f4d96220; Wed, 01 Sep 2021 09:53:41 +0000 (UTC) Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id A1C98202A9; Wed, 1 Sep 2021 09:53:40 +0000 (UTC) Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap1.suse-dmz.suse.de (Postfix) with ESMTPS id 5360A13A45; Wed, 1 Sep 2021 09:53:40 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap1.suse-dmz.suse.de with ESMTPSA id sOO0EaRNL2G0IAAAGKfGzw (envelope-from ); Wed, 01 Sep 2021 09:53:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 923e60a0-1d40-42e7-946d-0916f4d96220 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1630490020; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=aA6sPNMThuGUNYnDlunOAMyTa2yY+DaSnBdOYNd2FZY=; b=SeLuetNliD5GxhPHaMqcoEt2BmM/HT1trHCMQ5aac751U5VCy1NIjeb3saIDbKMUS1Apbb 0IFRCp5PxCSZsE/VHKgZhRRCbW8XIHOLCtoKbT21kcW0d/P+sySIPMhx+PyrdMwYho6Mcl CRCbjCM/BZPrnVx7rtK12EyTPf1F+uE= To: Jan Beulich , Wei Liu Cc: Andrew Cooper , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , xen-devel@lists.xenproject.org References: <20210831073039.7101-1-jgross@suse.com> <6837d551-6473-e34d-c0ae-043fcaa9482b@suse.com> From: Juergen Gross Subject: Re: [PATCH] Config: use Mini-OS master for xen-unstable Message-ID: Date: Wed, 1 Sep 2021 11:53:39 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <6837d551-6473-e34d-c0ae-043fcaa9482b@suse.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="nffqn2zrwFK8ViexzHzIWpM3CQjmypOq3" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --nffqn2zrwFK8ViexzHzIWpM3CQjmypOq3 Content-Type: multipart/mixed; boundary="qDn4ONRi1pYHvLeWVtpyF4cKY3t3VuEvq"; protected-headers="v1" From: Juergen Gross To: Jan Beulich , Wei Liu Cc: Andrew Cooper , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , xen-devel@lists.xenproject.org Message-ID: Subject: Re: [PATCH] Config: use Mini-OS master for xen-unstable References: <20210831073039.7101-1-jgross@suse.com> <6837d551-6473-e34d-c0ae-043fcaa9482b@suse.com> In-Reply-To: <6837d551-6473-e34d-c0ae-043fcaa9482b@suse.com> --qDn4ONRi1pYHvLeWVtpyF4cKY3t3VuEvq Content-Type: multipart/mixed; boundary="------------909B2A3919721982D934BD8C" Content-Language: en-US This is a multi-part message in MIME format. --------------909B2A3919721982D934BD8C Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 01.09.21 10:59, Jan Beulich wrote: > On 31.08.2021 09:30, Juergen Gross wrote: >> In order to get Mini-OS master branch tested by OSStest, use it for >> xen-unstable. >> >> Signed-off-by: Juergen Gross >> --- >> There are some Mini-OS patches pending, of which at least the Mini-OS >> netfront fix should be committed as it will be required for qemu-stubd= om >> to work. >> --- >> Config.mk | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/Config.mk b/Config.mk >> index 4d723eec1d..d4e8ced104 100644 >> --- a/Config.mk >> +++ b/Config.mk >> @@ -246,7 +246,7 @@ MINIOS_UPSTREAM_URL ?=3D git://xenbits.xen.org/min= i-os.git >> endif >> OVMF_UPSTREAM_REVISION ?=3D b37cfdd2807181aed2fee1e17bd7ec1190db266a= >> QEMU_UPSTREAM_REVISION ?=3D master >> -MINIOS_UPSTREAM_REVISION ?=3D 051b87bb9c19609976fb038f386920e1ce5454c= 5 >> +MINIOS_UPSTREAM_REVISION ?=3D master >=20 > I'm afraid this, effectively reverting 82c3d15c903a ("minios: Revert re= cent > change and revert to working minios"), would set us up for the same pro= blem > again that was dealt with there. IOW you're re-proposing a change of yo= urs > (e013e8514389 ["config: use mini-os master for unstable"]) which was > subsequently reverted, without spelling out what has since changed. How do you suggest to proceed then? Will every Mini-OS commit require to be followed by a Xen commit then, which will either result in a test success, or in a revert of that Xen commit? It should be noted that the presumed interface change in Mini-OS causing the failure in OSStest last year has been reverted by me. Juergen --------------909B2A3919721982D934BD8C Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Transfer-Encoding: quoted-printable Content-Description: OpenPGP public key Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy= cWx w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O= f8Z d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y= 9bf IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq= G7/ 377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR= 3Jv c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA= QIe AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT= hpw dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0= MbD 1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv= oPH Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v= 5QL +qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ= 2Vu IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC= QoL BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr= Wf0 teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC= /nu AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh= ITT d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm= XBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz= 80h SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC= AcD AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn= FOX gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1= jnD kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0= N51 N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l= otu fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1= tqS EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA= hsD BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3= g3O ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5= dM7 wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5= D+j LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm= V2x AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N= Eaw QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW= nHI s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR= wgn BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV= bVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk= pEd IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA= QAB wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw= Tbe 8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1= vJz Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8= VGi wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW= svi uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX= zXs ZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------909B2A3919721982D934BD8C-- --qDn4ONRi1pYHvLeWVtpyF4cKY3t3VuEvq-- --nffqn2zrwFK8ViexzHzIWpM3CQjmypOq3 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmEvTaMFAwAAAAAACgkQsN6d1ii/Ey8n BAf/SHfDRN/F/Dz+lUFMTTxNvOB8w2/qMorYOPAKT/kAKDmyC/UGUeNjKALUdGEt3kdd6PrQVczs 9JiaeeL/4OJLv2pnccrfXu/wwABZatvgy1VPyr+siI6jV1HxGGhEgDXsZ5bgyIIGxBfCVQaEyE57 M4PZG1bOZ5oPmtj5Bz5UA2it8xs1yMwqRcr11k7XbnCA0P4oHOC+bZew70P/U6+/Qp1Ku05aeBtz FUjoOVrrm3u6X8gIKcUu6StmB2rBPQbpWAXNNnu6ay8XsYoVnBp59OW2jQ474bTOcv+X11L//bdJ /KxJH+rmgXGe5Mfw+B3WmMqIBZhEFxShqmZrbDAS8w== =zCn0 -----END PGP SIGNATURE----- --nffqn2zrwFK8ViexzHzIWpM3CQjmypOq3-- From xen-devel-bounces@lists.xenproject.org Wed Sep 01 09:56:02 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Sep 2021 09:56:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.176255.320726 (Exim 4.92) (envelope-from ) id 1mLMyQ-0006G9-1Z; Wed, 01 Sep 2021 09:56:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 176255.320726; Wed, 01 Sep 2021 09:56:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLMyP-0006G2-Uk; Wed, 01 Sep 2021 09:56:01 +0000 Received: by outflank-mailman (input) for mailman id 176255; Wed, 01 Sep 2021 09:56:01 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLMyP-0006Fq-03 for xen-devel@lists.xenproject.org; Wed, 01 Sep 2021 09:56:01 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 6655b2a7-e3b7-4fb0-9e6d-2cc730b15527; Wed, 01 Sep 2021 09:56:00 +0000 (UTC) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05lp2170.outbound.protection.outlook.com [104.47.17.170]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-18-3lGGkDqjPbiQOR7DLdaJ2g-1; Wed, 01 Sep 2021 11:55:57 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR04MB4845.eurprd04.prod.outlook.com (2603:10a6:803:51::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.21; Wed, 1 Sep 2021 09:55:56 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4478.019; Wed, 1 Sep 2021 09:55:56 +0000 Received: from [10.156.60.236] (37.24.206.209) by FR0P281CA0070.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:49::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.4 via Frontend Transport; Wed, 1 Sep 2021 09:55:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6655b2a7-e3b7-4fb0-9e6d-2cc730b15527 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1630490159; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FGtjZiIFf5R/oYLpBhLuFfUgjNszBMgjxxQb52D/ECA=; b=IpegrnIB96Y939kQ3nJiC+2A/bQu/mkswGUcgxOPHnsHmUscZQrOC9n2owxl10Jh1wMixJ 5sJCpTfGiuQB/ch+OAMB5oO26q3fenY6LHcC5kNTSpJIsmAnNo1C6hZjT8/mLKNs54CHef GqkjPFbhj8vy4lIM0S9qi2fYFcIGZns= X-MC-Unique: 3lGGkDqjPbiQOR7DLdaJ2g-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MuJGUsdzmBgRgSs3Fd2EEmjjX8tc9VOzjEnkyyCrs7zkix2mQvERZAzDG8gAWBqqbBJWKNjoShK0VD2JOfwyrdO7J0YNnrG5lu+gd+tOXeqsrQOzWUYu5cMrClSo+1dOXOMsJZdLuvxuF8POCjRQckMY01zX1fkAZje5kDkB0ci++JNtqecwspC77FLjWHSi6LPdc5Nw2Cv/YHZrYiu6/tK+bZrwuuu8Nrd+Mh2ksTBBvzFx7p+JNbmDRzyPuLlxBaKPUhqA5G03gAESkcjqrDqly5HebwibbdvEzngmx8R974Hx3UbG0a6bJ0ODqOmnWYOlK3dmoMnvIbecBS0pzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FGtjZiIFf5R/oYLpBhLuFfUgjNszBMgjxxQb52D/ECA=; b=JoPOkj2JXoCd4iFw3tjp7oSW6+6H4mcV18h4tXgMhHA3Qxp0OJJPD42xCFgViCQYArj+fQn2NQxfarUmeBTcm/54BthwJwZ5JKlbBF1qyQXD+nyaMLiWQHWPOSDWhEOZKBDu0VVpA5/SlUH/6ir+FmR0jCxJ6Khel8nxp7YhTk1r7K9H52zKg+rbaQ24QlmpMSyW0Oql/R30MUiD1zdI09/O9+qpDWPhEGTWmxTKdRkUVFPU6LQb9XfmZf7Yx6zbu22u1+ERVxfWA74rvZdBnNxBk2zI2YOOSgDDk4RJTxArr4WJlvZo0byZhGLc+npaUti3/YYvzp5NM69EeNRLnA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=suse.com; Subject: Re: [PATCH] Config: use Mini-OS master for xen-unstable To: Juergen Gross Cc: Andrew Cooper , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , xen-devel@lists.xenproject.org, Wei Liu References: <20210831073039.7101-1-jgross@suse.com> <6837d551-6473-e34d-c0ae-043fcaa9482b@suse.com> From: Jan Beulich Message-ID: <3a662b17-bde7-df0f-3d96-d275c70b43b4@suse.com> Date: Wed, 1 Sep 2021 11:55:54 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0070.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:49::20) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 94446512-6cd1-4f10-0bbf-08d96d2eb192 X-MS-TrafficTypeDiagnostic: VI1PR04MB4845: X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: v9l2HxlLY7d2v56MxpKDbJxZ3nqM7uw6Gcx65ojkoco8to87Kz/qls+56GkNvnanQXquuNCqeSjbAtxHwpgDq9mMQL1NIPqPu8toXmJhxM0FPw3vElThbNMCSbEu5RMOqyf30mDrQWr8Zu+fJyasOT7vThYQVXtJ2bSXaiOYyVuEJRyc1Y1FE3Q1XSgEiP/hE75HmDtBPfTKujgJKlXGPJa0HglFm/czZHMcXrDOeXh+Nz5r/sIp1m4T2vMxpMN7GBnCDL6ScRuXZWYrT2x8vFYcZgad2ocRdZ0ArHurHkS5+QyOxUTXRbjsz6W0wIE0LbHWoVPO/lFCo9uQSEF8P27oRZaHnhmiPnmAwPLmwD7MthGPtsgWi5YqWEauR+r+dwu8i/r/fH5O/nL3eNWi8NvHvG+c3txooF5kAYdZA1p64a7W+JsDaihdmm+VExfdtG87aNhUCrSOag0WXWfqCmSU7qDdhtB58CoahQMrObEnQ860KOzcxu4aqDIPIpt7K+BNGlugm5lTj1riH6qlQc96QGLVz0wwzu9ClELoXrdBp1LtppLte7/SlBEUOzqzmqMJFTBlwWrFweXx2gwp9Sj8KGHWdsMS/hiqBdjuELos339tp+f3sIow6b1BOSjsEHH+metoOxOqfrYlnXbYjye1HL4q65mwhCFXBzqTs3AfQe7VS6c+9t+1UpoZrgxhFPbpXMSlH3rw3MkhTLXQcfCIQmMgfpXskkIaYQ0rjwplb0npM5w/0ofjOz+nrPD8 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(66946007)(6486002)(8936002)(508600001)(6636002)(66476007)(2906002)(6862004)(54906003)(66556008)(86362001)(53546011)(4326008)(316002)(16576012)(83380400001)(38100700002)(31696002)(5660300002)(26005)(8676002)(31686004)(2616005)(36756003)(956004)(186003)(37006003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NjZxSmRNKzBLeUswTHYvRzZFcXlJUlZUYjlQaDdDS0tob2FOcUVnL1VGYUdH?= =?utf-8?B?cXRTQXZqdmR4QlhOa3VXcFc2cFU2clRaMlRHaVZLVW16dG0wQ3A2TzROSWR3?= =?utf-8?B?d0lmLzJnTU9GVExTWWFRQWFJekFHekp4a09zOUNqYnVaZE54dERhdHVWOWZN?= =?utf-8?B?cTNXRGh2K0FHK21pQWtmZ1pwYUIvNW0ybWxScEpGMSsxUzNxRlFPaGk0UjRK?= =?utf-8?B?Y0hGdFZXSEZFQ25ZOTdKNFlmaGRMeWZDTE1IVjQrQVQzL3lCZ3dneTFVY2k4?= =?utf-8?B?NVlnTE8xQnBib0ExcC9LcnpmcWZteTBLVXhpUnVkQzRGTnkwMkxsWHYzY2Ry?= =?utf-8?B?RkpSajJVb2xFN2cyQUJUVStqVGNFdHhOSWdVUWROV2FiUWl1TGhneGFCLzZP?= =?utf-8?B?Ui9BczNCdForMlRTU1pUQkhXRTdkcnRZWENVMW5KZmVSdlRQK3lTaFozdmVp?= =?utf-8?B?VlQrNVgwV1IvMzA2bmtiN2xpdm9LTmNick1zc3l3VHA3dnRGNnJsUVpmNnhL?= =?utf-8?B?TVQ1YzdnbUcxeTRsdDhoZGwrMHdvdnZOSnA4MVczWmxOYjFQeDFRYlNJeXZr?= =?utf-8?B?N3lLZ0hoUmJjTTUrWUc5VFJLeTNrcXFnM1BHaG96N0ZXb1JQd0o1UWdBQWFO?= =?utf-8?B?TlFvRVhjYmhzeEZiUXNGYktwQlRmUUxPN05veVNXL0R0Yno2d2p6TmJJdWtT?= =?utf-8?B?Z0Q1ME9jajhWZ1lYcWQwelRXdEhLRVJwSW9oTjlBcjVpMzBOYlB1TDhlWUl6?= =?utf-8?B?czJSb1JOenR3WDhwOG1GZjRuSVF6aTUzenVLWllZUXJ4bXFNQzRRdXJUOWJx?= =?utf-8?B?cDVzSzNEaFZkN0VkZDVMQWhGQWlMUmxVS2RKcENVMHVmWVJZMkRmUGlFRmxa?= =?utf-8?B?YVphK0FVQVNOZ0w0TEx0QUxVU2FHRTdkMi9LenB0RmtOaEdtT1VtcHJoZk5S?= =?utf-8?B?S2MvWDlJS0RuZUZuRzJYeGRHTW11Z0oyRW8rOE5NNmlFTCt3aVRFcWtMeE5o?= =?utf-8?B?SDlIU1MvK2NiU1FjdXJob0Z6dTJHdGdHSE56ZDlNVXpja0dJamR3SlRBb0J1?= =?utf-8?B?akx3WWpnREUwb2ZUMzg0UnNIbUFTbEh5OWE2UTJuUzcwNWhuL3FGMmY4WHRu?= =?utf-8?B?dVcvTTgyZ3dHRnVJRERPOTFnYmVRYjZTbU5SdTlkMTV4Mk1zMXByWVp0N2RQ?= =?utf-8?B?Q1BDSFpHTHJZVnhzRGdsRVFDdlpCYkU3bVRROURUaVBhVUkvOXZjZ0FwWGZV?= =?utf-8?B?bzFjTnFaeXZnamhVMEkya211a2hSTStqZnBySkJLdS9XcWZlTDBralk0N2cv?= =?utf-8?B?MmozRUI0ZmV4dzh5TWNiVmM2R0FGZVJ4dnRrWkhyUkRPSzQ5alNrREpWVnpR?= =?utf-8?B?NnVOVzFlek9SSHg2enlXZmx6WVNKbXk3MGh2SzNJRjMyTEY5Q1dlaHBRbVJj?= =?utf-8?B?NCtMdC9JQzRHR0JvbVMzeU16MzZxbXJNZjVGQ1FadFNibDg0TUVVRmFYWWRZ?= =?utf-8?B?WHhwK21ZTCtWNUhVTURyaURSVFpuSnhNcHJ1RFE3dnFrR0xocTZoa3NkZ3dE?= =?utf-8?B?bWwwcGg3R0s2OTZEc2N1OTI1K2liWmh1L1A1dEYzU1h6N0xyREk5Zm9DSGFT?= =?utf-8?B?T21xbmM3bjFNKzgrTmlwZWhMNUxKd2lmZVBWeFFDOFNXK0U3eGZ2aGFkODFm?= =?utf-8?B?eDZWaEZ6YTZTclBCc1hXUnRiZGk2US9BUEtPUVd0SkdydTM2STZBWE1GdjZO?= =?utf-8?Q?U8QOSkl+vjfs/4aTDiUfWTUMB1I3Dy7q3nHKovx?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 94446512-6cd1-4f10-0bbf-08d96d2eb192 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Sep 2021 09:55:56.5397 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: B3gaREVvKF3qEyVu8Gy+UedJq80sZKo4xOrnZB5h6rLrHFG029f9RI5mcjao/wga9yRBaOUcT+F7KcMCq/Dp3g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4845 On 01.09.2021 11:53, Juergen Gross wrote: > On 01.09.21 10:59, Jan Beulich wrote: >> On 31.08.2021 09:30, Juergen Gross wrote: >>> In order to get Mini-OS master branch tested by OSStest, use it for >>> xen-unstable. >>> >>> Signed-off-by: Juergen Gross >>> --- >>> There are some Mini-OS patches pending, of which at least the Mini-OS >>> netfront fix should be committed as it will be required for qemu-stubdom >>> to work. >>> --- >>> Config.mk | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/Config.mk b/Config.mk >>> index 4d723eec1d..d4e8ced104 100644 >>> --- a/Config.mk >>> +++ b/Config.mk >>> @@ -246,7 +246,7 @@ MINIOS_UPSTREAM_URL ?= git://xenbits.xen.org/mini-os.git >>> endif >>> OVMF_UPSTREAM_REVISION ?= b37cfdd2807181aed2fee1e17bd7ec1190db266a >>> QEMU_UPSTREAM_REVISION ?= master >>> -MINIOS_UPSTREAM_REVISION ?= 051b87bb9c19609976fb038f386920e1ce5454c5 >>> +MINIOS_UPSTREAM_REVISION ?= master >> >> I'm afraid this, effectively reverting 82c3d15c903a ("minios: Revert recent >> change and revert to working minios"), would set us up for the same problem >> again that was dealt with there. IOW you're re-proposing a change of yours >> (e013e8514389 ["config: use mini-os master for unstable"]) which was >> subsequently reverted, without spelling out what has since changed. > > How do you suggest to proceed then? > > Will every Mini-OS commit require to be followed by a Xen commit then, > which will either result in a test success, or in a revert of that Xen > commit? Once the two trees are assumed to be fully decoupled, and once a push gate has been put in place for mini-os.git, we can do what you suggest. Jan From xen-devel-bounces@lists.xenproject.org Wed Sep 01 10:00:07 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Sep 2021 10:00:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.176261.320737 (Exim 4.92) (envelope-from ) id 1mLN2H-0006vU-JQ; Wed, 01 Sep 2021 10:00:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 176261.320737; Wed, 01 Sep 2021 10:00:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLN2H-0006v5-G5; Wed, 01 Sep 2021 10:00:01 +0000 Received: by outflank-mailman (input) for mailman id 176261; Wed, 01 Sep 2021 10:00:00 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLN2F-0006uz-P6 for xen-devel@lists.xenproject.org; Wed, 01 Sep 2021 10:00:00 +0000 Received: from mx0a-0039f301.pphosted.com (unknown [148.163.133.242]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 5d42ca6e-0b0b-11ec-adc1-12813bfff9fa; Wed, 01 Sep 2021 09:59:58 +0000 (UTC) Received: from pps.filterd (m0174678.ppops.net [127.0.0.1]) by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 1818W2aY029947; Wed, 1 Sep 2021 09:59:55 GMT Received: from eur02-ve1-obe.outbound.protection.outlook.com (mail-ve1eur02lp2050.outbound.protection.outlook.com [104.47.6.50]) by mx0a-0039f301.pphosted.com with ESMTP id 3at5yr8h4j-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 01 Sep 2021 09:59:55 +0000 Received: from AM7PR03MB6593.eurprd03.prod.outlook.com (2603:10a6:20b:1b4::10) by AS8PR03MB6757.eurprd03.prod.outlook.com (2603:10a6:20b:292::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.23; Wed, 1 Sep 2021 09:59:52 +0000 Received: from AM7PR03MB6593.eurprd03.prod.outlook.com ([fe80::7cb2:a2bc:d477:683d]) by AM7PR03MB6593.eurprd03.prod.outlook.com ([fe80::7cb2:a2bc:d477:683d%9]) with mapi id 15.20.4457.024; Wed, 1 Sep 2021 09:59:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5d42ca6e-0b0b-11ec-adc1-12813bfff9fa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oQL0FSUpOR6ZZw4dzZ/WLDoYJRtr+dnA/6nKFP+FJdK3t7mQDaLQmiv/4yzs2ddRWiuquNuEWv3lGIRiirB+fSyN/nylMaMo3p2g9vsv3KuikQANoY8PVRlJdaAeXB2nQDXsKaKRGbqSXtQ4Lw41VsrJ+8U7dAyEVzsWryJSuefKp/cEZfc9gkV3mJlYVLvF32f5pcTk8h/7W/mORBBzsJ9k8cbBmfmNNn8Cd+NQlBkK2jxU9Pq0Fy8MxntIX71NF+aSeKHoV1RHwpDYd3oa8fDy1TlWGN6ghWQ6KUbHKC2U39EPLXHk68sGit7tjboKBV89C0nmxKXzoSX4qKU1HA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=La8gXQMXfHGw4BBQ/lbRYKOiAPc1dG59oOZFJuu/0R4=; b=atiOGJeaTfQD/X7a0Y5DxpMn/1zW8kvmxi+a0vyi117D0eUM5CIeTxrjskfuGc13BpsURhpQ+nSMbsxcllTBoFPk6r+GEsL5Fdp1DHOfJiJx6/HMB+QH/Rv5CECRl/6xh7N9qyle5VZPhw5jqy11vcXe0cgRH8SJmnJ/lRi6344yDtFfJFDxemywR/DLLDOdiY8j6d7Qh9KJGHA2krlmJnrhwzoCiP9Xf2nUyVVDAqjXQU5zc8pbwbeh/UTj3zq3eV0QzmcifqBBya8ow80o9pGQFNd9/vBSwr1GFB6ikB2aHvJPOd3p/8YfskKNJ9bIVrU1mPo6qPK83gxO1CR4gg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=La8gXQMXfHGw4BBQ/lbRYKOiAPc1dG59oOZFJuu/0R4=; b=bzgZGNp7TSEPPhuFfoDeIX+LYW42sv438/+BrxDIlI2dQfHWYB+gBDxPQy5NjOesZTnCTpfabMjXtIXBx7xW2A8wRbMmeElQW4ixWD/SRX1I0gJdT+gjNUh/rUq33i9KRsqrrQHDBsYF8ep0piMuYhVAXJ9f/x8Dll3dxhSEekPU2uMZv96ngmr77IQS/4adLQh8YfwGLtfxrLc7PbC2ewBVh+28tJdmjoYRhI79GTJodghkuos7QX8GOriEAztEVINyMsC1rAqy+it25hH6inp41Qj0KfaoclfYwL3eeaKgTN/9/j95JWBqHgBmb/dZcyIIbCcI6G7oCuFYHBXzvA== From: Roman Skakun To: Stefano Stabellini CC: Julien Grall , "xen-devel@lists.xenproject.org" , Bertrand Marquis , Andrii Anisov , Roman Skakun , Roman Skakun Subject: Re: Disable IOMMU in Dom0 Thread-Topic: Disable IOMMU in Dom0 Thread-Index: AQHXnnd7IVjUu+L6S0mPq9naNxJ1FauOJ3YAgADDGos= Date: Wed, 1 Sep 2021 09:59:52 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=epam.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e480f3ce-6a3e-44ea-c1c1-08d96d2f3e73 x-ms-traffictypediagnostic: AS8PR03MB6757: x-ms-exchange-transport-forked: True x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 0J2GrC+3U+dvjt4VfBDewh7ZaRnVTgwszZGiIN0mOXsMZzgeDF77YwUx8Pm5AUhzbQlGUCbi9+v6gL0+1oJsSxAUrwLj+Xj/6e5xybjMaohm7o+PR7IyxWzOh8AhOpOAlZ5Ca9HBCaNlVno7qmv30UCRvVukBnK/GLHgf5NTiT1tTXmS8VKIFIm9N6RWyq5yVJkHqqVWnxPWQ0Bhl4ejxTUZpnzeDa4DxrUyenP/JvJgSsF5NuKRXdZ1SC/dA00TE7ljuyhKggETqugoKEtkweuKQDGorQG2ndDyAKSI1ERuk4DCNfRY2wDWR8xJHVguTE9o87jg8cKRUTelZeKkDjTsmsK9iFfS1VU0ko/ielKUf+YX2h4VUqLNruOX8B0qzK0//8z5fm9vUlwvGAcDgVuGC7EFOMRrHAps3aIlZSEQpWcECaV0XntF7y6OQGdwTjtl5aLT6A4Qz3bQF1/HuBjj9SIg9Di/V8DGKe6P8nCQ/jsW8abmoaW3IdioKxHz/hepValPgsn3NGJ8N4F0wEINhKhm8zR7Xks7v4skV5ckSa5knP6BbRxL7T82AqiWWL9Qw6CiaaeWB0lm4/2ZXjazO/AFR7Pr50vMeuKZj0WOQ9m1VE8vMXdXzbxqIMJprD3ky20QVNWba9GBKaxpp8oBQKXDckG4Wd3qUq8yziTAZakugn7aE7/4JYnMYONgVoLAw/iurTy8Fu0nDjJS7Luru5IOFFlDWHeQ9gBsBebrvLKBHk5QG5dpYsXNxXYpkHig5AB22lSz05A3KZ6z5AgOY+uRLpkserliFVRZilM= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM7PR03MB6593.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(83380400001)(966005)(54906003)(38070700005)(166002)(508600001)(66946007)(6916009)(52536014)(5660300002)(33656002)(19627235002)(316002)(38100700002)(26005)(64756008)(8676002)(66556008)(4326008)(66476007)(122000001)(86362001)(6506007)(8936002)(76116006)(186003)(2906002)(107886003)(55016002)(9686003)(19627405001)(53546011)(7696005)(66446008)(71200400001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?dXdAFwMOel6Y+LgrmmBEe1vCjW3DC5BUNlcOIlLOyh2n0EWZbpck3S2c/l8s?= =?us-ascii?Q?T0QumJZ3ENjw0IrYSxWQnzh3jKnHPPenoHkzzpAsImy7txk9nzJK2n/hF6Gs?= =?us-ascii?Q?2hgaoem6aqfDy1ZGzVgsCHnHNYYJjK2/60WW9Ugpw6uMm3MxFHvM72eag6HU?= =?us-ascii?Q?bPBuBwe0nbe4xBP0+sR85COktzASZQ6+onMsEh1Yolvpo2DShj1Bw2rJ4MlE?= =?us-ascii?Q?62enXAV3f0s1/9w+4k3cGFNj832PjXgmUMiW+Vd9e9YYbCtjbaiMwAi39wgK?= =?us-ascii?Q?Eneh+IBI4hLd9iXjmvXiJz8CLGoTUiv51ehpdYF6daOLntbyUMvs9y3ZSC3l?= =?us-ascii?Q?AjaBmw2cjbcYBvOuOeDPBhFMbTdDdxeXRL7OuSwk58bW8keAZiItYUwItDZ2?= =?us-ascii?Q?iAYDjOVQMMSfh7ioTko3MjORqUMrAkWlQEQ9782JY3z2oh6A/6gh5kAO6wYp?= =?us-ascii?Q?QdWbphIxTYknFHfjgut4tcuEp3N3uDcfr4cXagegyGnEor8o3qvsRs3bRMwa?= =?us-ascii?Q?1movT+uemGV+P6QAoiRSFQrGFh5IVG8dElY1BrmjGQS0leG5ULBr2mdg7tc4?= =?us-ascii?Q?8BsdxqO4g5CrfXildw3BfkFtoRJcdA1g/xmhW6ql+VbGW2GFu73I1wtPsmhR?= =?us-ascii?Q?vdAsQ9H8WQRFdnwAAL+m9z3N3nGOqlN3HaJf5iLo7trIuwce19ap115gNcVp?= =?us-ascii?Q?bvFodvtttggo376TWvV+V9LEoyH8qyDvIQ3Qy4tLI2jBWH9ASI3lm7JhhWh2?= =?us-ascii?Q?acDJN4P7w99/Nryw9KIMOfl+H7sVK5WWs49+I7BS3XBG8wD7xLXetigURkoB?= =?us-ascii?Q?LDpeUTij61reziSVhgqMIXF5XSkHTflsWuqeQn2t8/rG7JBj/0RRI/mNMBwi?= =?us-ascii?Q?jRflXKkknibU7FZ50qLxMrXhu/1FjBnJvrm+iUWJbA933yVLr7nJZY8JIgN9?= =?us-ascii?Q?B/49zypIpMAvKaLe0MROOpQoZ2IBl/L1F1T7k3nidbo/QfDWVXRZaaHtQoAg?= =?us-ascii?Q?uOFSep8RqUjOT340v+367anbCl9Jw0pk8nnweXZSHMrbO2pUVT5jTyQCTp0L?= =?us-ascii?Q?I9+RgFGBGAgMDcjPN1Vvf5eScJ4Ez/xqq1eU9DMNPdFAXeDOrT4WYA8N1jYA?= =?us-ascii?Q?MJHyPKRilmNc26Ki70J/+tue3lFqk45dJovIuXOgvjwTTL0D8O66DEzvQkEU?= =?us-ascii?Q?coyRF7X9hxDME5w9TPhkorolqUbmveKZckNrrxgeOhTEk29tjJdPy1P9FSj+?= =?us-ascii?Q?uPQS8LKJdc8yLNdqtbjhNKOIm8KqS1PQXC4hAPcRX3DF1zAao7YPNO9iX6L1?= =?us-ascii?Q?+Mc=3D?= Content-Type: multipart/alternative; boundary="_000_AM7PR03MB659358C0EBA9D71AEEF7A60885CD9AM7PR03MB6593eurp_" MIME-Version: 1.0 X-OriginatorOrg: epam.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM7PR03MB6593.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e480f3ce-6a3e-44ea-c1c1-08d96d2f3e73 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Sep 2021 09:59:52.7354 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: xvyKAp3fP1C2MdxzGwuduA5+107HnnQ6ba5q06+VmopgXhShct6Ii4VMyBE16KIXZcyN8LmR6OaXs3Z2T7RAvw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR03MB6757 X-Proofpoint-GUID: YE7uaaEk6YAdQTzKXmC9hKelH24PX-Ys X-Proofpoint-ORIG-GUID: YE7uaaEk6YAdQTzKXmC9hKelH24PX-Ys X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.391,FMLib:17.0.607.475 definitions=2021-09-01_03,2021-08-31_01,2020-04-07_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 bulkscore=0 phishscore=0 lowpriorityscore=0 mlxscore=0 clxscore=1015 malwarescore=0 mlxlogscore=999 impostorscore=0 priorityscore=1501 suspectscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2107140000 definitions=main-2109010058 --_000_AM7PR03MB659358C0EBA9D71AEEF7A60885CD9AM7PR03MB6593eurp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi, Stefano! Thanks for responding! > If you have a setup where Dom0 is not 1:1 mapped (which is not currently > possible with upstream Xen but it is possible with cache coloring) and > uses the IOMMU to make device DMA work like regular DomUs, then passing > XENFEAT_not_direct_mapped to Linux would make it work. Without > XENFEAT_not_direct_mapped, Linux would try to use swiotlb-xen which has > code that relies on Linux being 1:1 mapped to work properly. I'm using 1:1 Dom0. According to your patch series, xen-swiotlb fops will be applied for all de= vices because XENFEAT_direct_mapped is active, as shown here: https://elixir.bootlin.com/linux/v5.14/source/arch/arm64/mm/dma-mapping.c#L= 56 I agreed, that xen-swiotlb should work correctly, but in my case, I retriev= ed MFN here: https://elixir.bootlin.com/linux/v5.14/source/drivers/xen/swiotlb-xen.c#L36= 6 which is greater than 32bit and xen-swiotlb tries to use bounce buffer as e= xpected. It can lead to decrease a performance because I have a long buffer ~4MB. I thought, that we can disable swiotlb fops for devices which are controlle= d by IOMMU. Cheers, ________________________________ From: Stefano Stabellini Sent: Wednesday, September 1, 2021 12:50 AM To: Roman Skakun Cc: Stefano Stabellini ; Julien Grall ; xen-devel@lists.xenproject.org ; Bertr= and Marquis ; Andrii Anisov ; Roman Skakun Subject: Re: Disable IOMMU in Dom0 On Tue, 31 Aug 2021, Roman Skakun wrote: > Hi, Stefano! > > I have seen your negotiation of disabling xen-swiotlb for devices which a= re controlled by IOMMU in Dom0: > https://urldefense.com/v3/__https://patchwork.kernel.org/project/xen-deve= l/patch/alpine.DEB.2.21.2102161333090.3234@sstabellini-ThinkPad-T480s/__;!!= GF_29dbcQIUBPA!hl4_2pWlI3NQmAkwh4uvJFu7NhcOay9O9bIJRr7eOOMKD_I2z8MPbwnSXpNm= qU6F$ [patchwork[.]kernel[.]org] > > As I was thinking to create a common implementation because I have the is= sue > when device controlled by IOMMU using xen-swiotlb fops and bounce buffer = as the result. > https://urldefense.com/v3/__https://lore.kernel.org/xen-devel/060b5741-92= 2c-115c-7e8c-97d8aa5f46f4@xen.org/T/__;!!GF_29dbcQIUBPA!hl4_2pWlI3NQmAkwh4u= vJFu7NhcOay9O9bIJRr7eOOMKD_I2z8MPbwnSXp1TdIa7$ [lore[.]kernel[.]org] > > Do you have any future plans to finish implementation for upstream? Hi Roman, The feature is already upstream in Linux as f5079a9a2, and the new feature flags are XENFEAT_direct_mapped and XENFEAT_not_direct_mapped. If you have a setup where Dom0 is not 1:1 mapped (which is not currently possible with upstream Xen but it is possible with cache coloring) and uses the IOMMU to make device DMA work like regular DomUs, then passing XENFEAT_not_direct_mapped to Linux would make it work. Without XENFEAT_not_direct_mapped, Linux would try to use swiotlb-xen which has code that relies on Linux being 1:1 mapped to work properly. Is that the same problem that you have, or is dom0 1:1 mapped in your case? If dom0 is 1:1 mapped then swiotlb-xen should work regardless of whether the IOMMU is enabled or disabled. I hope this helps. Cheers, Stefano --_000_AM7PR03MB659358C0EBA9D71AEEF7A60885CD9AM7PR03MB6593eurp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable
Hi, Stefano!

Thanks for responding!

> If you have a set= up where Dom0 is not 1:1 mapped (which is not currently
> possible with ups= tream Xen but it is possible with cache coloring) and
> uses the IOMMU to= make device DMA work like regular DomUs, then passing
> XENFEAT_not_direc= t_mapped to Linux would make it work. Without
> XENFEAT_not_direc= t_mapped, Linux would try to use swiotlb-xen which has
> code that relies = on Linux being 1:1 mapped to work properly.

I'm using 1:1 Dom0.
According to your patch series, xen-swiotlb fops will be applied for all = devices 
because XENFEAT_direct_mapped is active, as shown here:
https://elixir= .bootlin.com/linux/v5.14/source/arch/arm64/mm/dma-mapping.c#L56<= br>

I agreed, th= at xen-swiotlb should work correctly, but in my case, I retrieved MFN here:=
which is greater th= an 32bit and xen-swiotlb tries to use bounce buffer as expected.
It can lead to decrease a performance because I have a long buffer ~4MB.

I thought, that we can disable swiotlb fops for devices which are controlled by IOMMU= .

Cheers,
From: Stefano Stabellini &l= t;sstabellini@kernel.org>
Sent: Wednesday, September 1, 2021 12:50 AM
To: Roman Skakun <Roman_Skakun@epam.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>; Julien Grall = <julien@xen.org>; xen-devel@lists.xenproject.org <xen-devel@lists.= xenproject.org>; Bertrand Marquis <bertrand.marquis@arm.com>; Andr= ii Anisov <Andrii_Anisov@epam.com>; Roman Skakun <rm.skakun@gmail.= com>
Subject: Re: Disable IOMMU in Dom0
 
On Tue, 31 Aug 2021, Roman Skakun wrote:
> Hi, Stefano!
>
> I have seen your negotiation of disabling xen-swiotlb for devices whic= h are controlled by IOMMU in Dom0:
> https://urldefense.com/v3/__https://patchwork.kernel.org/project/xen-devel/= patch/alpine.DEB.2.21.2102161333090.3234@sstabellini-ThinkPad-T480s/__;!!GF= _29dbcQIUBPA!hl4_2pWlI3NQmAkwh4uvJFu7NhcOay9O9bIJRr7eOOMKD_I2z8MPbwnSXpNmqU= 6F$ [patchwork[.]kernel[.]org]
>
> As I was thinking to create a common implementation because I have the= issue
> when device controlled by IOMMU using xen-swiotlb fops and bounce buff= er as the result.
> https://urldefense.com/v3/__https://lore.kernel.org/xen-devel/060b5741-922c= -115c-7e8c-97d8aa5f46f4@xen.org/T/__;!!GF_29dbcQIUBPA!hl4_2pWlI3NQmAkwh4uvJ= Fu7NhcOay9O9bIJRr7eOOMKD_I2z8MPbwnSXp1TdIa7$ [lore[.]kernel[.]org]
>
> Do you have any future plans to finish implementation for upstream?
Hi Roman,

The feature is already upstream in Linux as f5079a9a2, and the new
feature flags are XENFEAT_direct_mapped and XENFEAT_not_direct_mapped.

If you have a setup where Dom0 is not 1:1 mapped (which is not currently possible with upstream Xen but it is possible with cache coloring) and
uses the IOMMU to make device DMA work like regular DomUs, then passing
XENFEAT_not_direct_mapped to Linux would make it work. Without
XENFEAT_not_direct_mapped, Linux would try to use swiotlb-xen which has
code that relies on Linux being 1:1 mapped to work properly.

Is that the same problem that you have, or is dom0 1:1 mapped in your
case? If dom0 is 1:1 mapped then swiotlb-xen should work regardless of
whether the IOMMU is enabled or disabled.

I hope this helps.

Cheers,

Stefano
--_000_AM7PR03MB659358C0EBA9D71AEEF7A60885CD9AM7PR03MB6593eurp_-- From xen-devel-bounces@lists.xenproject.org Wed Sep 01 10:05:59 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Sep 2021 10:05:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.176268.320748 (Exim 4.92) (envelope-from ) id 1mLN7w-0000Ee-Cc; Wed, 01 Sep 2021 10:05:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 176268.320748; Wed, 01 Sep 2021 10:05:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLN7w-0000EX-9g; Wed, 01 Sep 2021 10:05:52 +0000 Received: by outflank-mailman (input) for mailman id 176268; Wed, 01 Sep 2021 10:05:51 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLN7u-0000EN-Uy; Wed, 01 Sep 2021 10:05:50 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLN7u-0007jP-Py; Wed, 01 Sep 2021 10:05:50 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLN7u-0003Qd-I2; Wed, 01 Sep 2021 10:05:50 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mLN7u-0004H0-Ha; Wed, 01 Sep 2021 10:05:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=j24VJPcwVdYQa9uXurFdKSllutLiT6F+ExzgVYTfIp4=; b=5ThjvdKqEVYCOp9dDeFj3Gamh6 acyoEzYMhEZ5sUiiCkLYI/y5AKu6StXQ/cxEkMuatfIBD90ESXPTBzeiBNmE0d4z++H0NXeetWFfu e5FiZZ4Uxv8FTHJpRMZacknwWJ+ETqOQ2Q8gmFFrmzh3Pdby16lzv353IKPyBTqgDyzE=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-coverity test] 164692: all pass - PUSHED X-Osstest-Versions-This: xen=96607a8e680e7f965ca868d11f8b0636317d2618 X-Osstest-Versions-That: xen=8064488062641ae505b2a7369611c38057a7788b From: osstest service owner Date: Wed, 01 Sep 2021 10:05:50 +0000 flight 164692 xen-unstable-coverity real [real] http://logs.test-lab.xenproject.org/osstest/logs/164692/ Perfect :-) All tests in this flight passed as required version targeted for testing: xen 96607a8e680e7f965ca868d11f8b0636317d2618 baseline version: xen 8064488062641ae505b2a7369611c38057a7788b Last test of basis 164595 2021-08-29 09:18:29 Z 3 days Testing same since 164692 2021-09-01 09:18:30 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Fabrice Fontaine Ian Jackson Jan Beulich Julien Grall jobs: coverity-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 8064488062..96607a8e68 96607a8e680e7f965ca868d11f8b0636317d2618 -> coverity-tested/smoke From xen-devel-bounces@lists.xenproject.org Wed Sep 01 10:22:19 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Sep 2021 10:22:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.176276.320762 (Exim 4.92) (envelope-from ) id 1mLNNg-0002ri-QU; Wed, 01 Sep 2021 10:22:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 176276.320762; Wed, 01 Sep 2021 10:22:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLNNg-0002rG-NE; Wed, 01 Sep 2021 10:22:08 +0000 Received: by outflank-mailman (input) for mailman id 176276; Wed, 01 Sep 2021 10:22:07 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLNNf-0002r8-NB for xen-devel@lists.xenproject.org; Wed, 01 Sep 2021 10:22:07 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLNNd-0007zX-Co; Wed, 01 Sep 2021 10:22:05 +0000 Received: from [54.239.6.187] (helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1mLNNd-00061t-6E; Wed, 01 Sep 2021 10:22:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=J5xaLmys0DZR5B87YG9hJdaXxyVbpOBZsGEg/stJC60=; b=aWti9DinL7kqLdmR6/NApgKp90 akIy4rqjEAA6OrkcRX7JHprBmlesV4muG2yJ6hbRBQ4aPKMbNZ7AKxSpd2UwAApU1egBJd8Y62MF7 J7BDU2zgRpPJrppbGcUIofyclo98wzOG/T+zB5Wu6LiJIMeU67wEaW1SoLPXX/UkgFj0=; Subject: Re: Disable IOMMU in Dom0 To: Roman Skakun , Stefano Stabellini Cc: "xen-devel@lists.xenproject.org" , Bertrand Marquis , Andrii Anisov , Roman Skakun , Oleksandr Tyshchenko References: From: Julien Grall Message-ID: <179e4b7f-38d9-991d-3f99-64a74559986d@xen.org> Date: Wed, 1 Sep 2021 11:22:03 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Hi Roman On 01/09/2021 10:59, Roman Skakun wrote: >> If you have a setup where Dom0 is not 1:1 mapped (which is not currently >> possible with upstream Xen but it is possible with cache coloring) and >> uses the IOMMU to make device DMA work like regular DomUs, then passing >> XENFEAT_not_direct_mapped to Linux would make it work. Without >> XENFEAT_not_direct_mapped, Linux would try to use swiotlb-xen which has >> code that relies on Linux being 1:1 mapped to work properly. > > I'm using 1:1 Dom0. > According to your patch series, xen-swiotlb fops will be applied for all > devices > because XENFEAT_direct_mapped is active, as shown here: > https://elixir.bootlin.com/linux/v5.14/source/arch/arm64/mm/dma-mapping.c#L56 > > > I agreed, that xen-swiotlb should work correctly, but in my case, I > retrieved MFN here: > https://elixir.bootlin.com/linux/v5.14/source/drivers/xen/swiotlb-xen.c#L366 > > which is greater than 32bit and xen-swiotlb tries to use bounce buffer > as expected. > It can lead to decrease a performance because I have a long buffer ~4MB. > > I thought, that we can disable swiotlb fops for devices which are > controlled by IOMMU. Yes you can disable swiotlb for devices which are controlled by the IOMMU. But this will not make your problem disappear, it simply hides until it bites you in a more subttle way. From what you wrote, you have a 32-bit DMA capable. So you always need to have an address below 4GB. For foreign mapping, there is no guarantee the Guest Physical Address will actually be below 4GB. Today, the ballooning code only ask Linux to steal *a* RAM page for mapping the foreign page. This may or may not be below 4GB depending on how you assigned the RAM to dom0 (IIRC you had some RAM above 4GB). But that's the current behavior. One of your work colleague is looking at avoid to steal RAM page to avoid exhausting the memory. So foreign mapping may end up to be a lot higher in memory. IOW, you will need to be able to bounce the DMA buffer for your device. If you want to avoid bouncing, the proper way would be to rework the ballonning code so pages are allocated below 4GB. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Sep 01 10:24:09 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Sep 2021 10:24:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.176282.320774 (Exim 4.92) (envelope-from ) id 1mLNPd-0003UM-7f; Wed, 01 Sep 2021 10:24:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 176282.320774; Wed, 01 Sep 2021 10:24:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLNPd-0003UF-49; Wed, 01 Sep 2021 10:24:09 +0000 Received: by outflank-mailman (input) for mailman id 176282; Wed, 01 Sep 2021 10:24:07 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLNPb-0003U5-LE; Wed, 01 Sep 2021 10:24:07 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLNPb-00081A-F4; Wed, 01 Sep 2021 10:24:07 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLNPb-0004fT-88; Wed, 01 Sep 2021 10:24:07 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mLNPb-0003IW-7d; Wed, 01 Sep 2021 10:24:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=9CfheEgIl+2VO5giw5dGD+foRsQnOqOT4h60Tyc1jsE=; b=fkMNCsLl0TICMYlpPZR3fzesxK HYuAaLSXT5b+2m0zLT/Qkqcl8YSdWY/dVcldW6l8mc8HaOoiAC0XF0YUxmemw6vAczUKHzudX3yir sE5HwK4/TGIEKn/xkIJDOAnaQ3ptzAKUEjT7PEhrPatJyKQPifLlI8Sk/vj0EnzuMbdM=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 164686: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=9f3eda177a4b2d4a33ff1b0307cad42906396562 X-Osstest-Versions-That: ovmf=cae735f61328d64e2e8991036707b9e78c0f5f63 From: osstest service owner Date: Wed, 01 Sep 2021 10:24:07 +0000 flight 164686 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/164686/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 164674 build-amd64-xsm 6 xen-build fail REGR. vs. 164674 build-i386-xsm 6 xen-build fail REGR. vs. 164674 build-i386 6 xen-build fail REGR. vs. 164674 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 9f3eda177a4b2d4a33ff1b0307cad42906396562 baseline version: ovmf cae735f61328d64e2e8991036707b9e78c0f5f63 Last test of basis 164674 2021-08-31 02:56:52 Z 1 days Testing same since 164686 2021-09-01 03:03:43 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Anthony PERARD Gary Lin Jim Fehlig Lin, Gary (HPS OE-Linux) jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit 9f3eda177a4b2d4a33ff1b0307cad42906396562 Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:29:48 2021 +0800 OvmfPkg/OvmfXen: add QemuKernelLoaderFsDxe Without QemuKernelLoaderFsDxe, QemuLoadKernelImage() couldn't download the kernel, initrd, and kernel command line from QEMU's fw_cfg. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3574 Signed-off-by: Gary Lin Acked-by: Anthony PERARD Reviewed-by: Philippe Mathieu-Daude Reviewed-by: Gerd Hoffmann Tested-by: Jim Fehlig commit 5b5f10d7465004e3e40ec1f50a3b490b4db595e7 Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:31:15 2021 +0800 OvmfPkg/SmmControl2Dxe: use PcdAcpiS3Enable to detect S3 support To avoid the potential inconsistency between PcdAcpiS3Enable and QemuFwCfgS3Enabled(), this commit modifies SmmControl2Dxe to detect S3 support by PcdAcpiS3Enable as modules in MdeModulePkg do. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3573 Signed-off-by: Gary Lin Reviewed-by: Gerd Hoffmann Reviewed-by: Jiewen Yao Tested-by: Jim Fehlig commit 52e2dabc0f8d3af09c213072ce8ba734302f585d Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:31:14 2021 +0800 OvmfPkg/PlatformBootManagerLib: use PcdAcpiS3Enable to detect S3 support To avoid the potential inconsistency between PcdAcpiS3Enable and QemuFwCfgS3Enabled(), this commit modifies PlatformBootManagerLib to detect S3 support by PcdAcpiS3Enable as modules in MdeModulePkg do. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3573 Signed-off-by: Gary Lin Reviewed-by: Gerd Hoffmann Reviewed-by: Jiewen Yao Tested-by: Jim Fehlig commit 28152333bccb778b62e6e97446b28bfa0e92ef82 Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:31:13 2021 +0800 OvmfPkg/LockBoxLib: use PcdAcpiS3Enable to detect S3 support To avoid the potential inconsistency between PcdAcpiS3Enable and QemuFwCfgS3Enabled(), this commit modifies LockBoxLib to detect S3 support by PcdAcpiS3Enable as modules in MdeModulePkg do. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3573 Signed-off-by: Gary Lin Reviewed-by: Philippe Mathieu-Daude Reviewed-by: Gerd Hoffmann Reviewed-by: Jiewen Yao Tested-by: Jim Fehlig commit cb0d24637dfdd869618b9635dfb8e3b0746393a6 Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:31:12 2021 +0800 OvmfPkg/OvmfXen: set PcdAcpiS3Enable at initialization There are several functions in OvmfPkg/Library using QemuFwCfgS3Enabled() to detect the S3 support status. However, in MdeModulePkg, PcdAcpiS3Enable is used to check S3 support. Since InitializeXenPlatform() didn't set PcdAcpiS3Enable as InitializePlatform() did, this made the inconsistency between drivers/functions. For example, S3SaveStateDxe checked PcdAcpiS3Enable and skipped S3BootScript because the default value is FALSE. On the other hand, PlatformBootManagerBeforeConsole() from OvmfPkg/Library called QemuFwCfgS3Enabled() and found it returned TRUE, so it invoked SaveS3BootScript(). However, S3SaveStateDxe skipped S3BootScript, so SaveS3BootScript() asserted due to EFI_NOT_FOUND. This issue mainly affects "HVM Direct Kernel Boot". When used, "fw_cfg" is enabled in QEMU and QemuFwCfgS3Enabled() returns true in that case. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3573 Signed-off-by: Gary Lin Reviewed-by: Anthony PERARD Reviewed-by: Gerd Hoffmann Reviewed-by: Jiewen Yao Tested-by: Jim Fehlig From xen-devel-bounces@lists.xenproject.org Wed Sep 01 10:33:08 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Sep 2021 10:33:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.176290.320790 (Exim 4.92) (envelope-from ) id 1mLNY2-00059S-4V; Wed, 01 Sep 2021 10:32:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 176290.320790; Wed, 01 Sep 2021 10:32:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLNY2-00059L-1N; Wed, 01 Sep 2021 10:32:50 +0000 Received: by outflank-mailman (input) for mailman id 176290; Wed, 01 Sep 2021 10:32:48 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLNY0-00059F-D7 for xen-devel@lists.xenproject.org; Wed, 01 Sep 2021 10:32:48 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLNY0-0008BJ-BW for xen-devel@lists.xenproject.org; Wed, 01 Sep 2021 10:32:48 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1mLNY0-00079q-AT for xen-devel@lists.xenproject.org; Wed, 01 Sep 2021 10:32:48 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1mLNXn-00088q-W7; Wed, 01 Sep 2021 11:32:36 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=cwyy9inWMU2OFz4WdY/TbmnH7ieKYhzdnQ4z+pCsQBM=; b=fywikXv1TWe3rr4D8XCHI+zxMy BXOIy+KbegKgUFnGfLRq14O8RvOsuqm317+hru5SmnPvh9bcvwNtWHoVHleooPTQo72kqdRBswcpI 8Vh5MrOy02knzvP218+jLlR4UDadge/A/68oMp/P99OXiGPpUnzQcB0IBMaWxd4Axfkw=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24879.22211.552820.121035@mariner.uk.xensource.com> Date: Wed, 1 Sep 2021 11:32:35 +0100 To: Juergen Gross Cc: Jan Beulich , Wei Liu , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , xen-devel@lists.xenproject.org Subject: Re: [PATCH] Config: use Mini-OS master for xen-unstable In-Reply-To: References: <20210831073039.7101-1-jgross@suse.com> <6837d551-6473-e34d-c0ae-043fcaa9482b@suse.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Juergen Gross writes ("Re: [PATCH] Config: use Mini-OS master for xen-unstable"): > How do you suggest to proceed then? > > Will every Mini-OS commit require to be followed by a Xen commit then, > which will either result in a test success, or in a revert of that Xen > commit? That is how the current arrangement works. That's strict coupling. If you want to decouple it, that's possible. Ie, run a separate osstest "branch" (ie, series of flights) for mini-os; have a separate osstest-tested mini-os output branch, etc. Wei, if we were to do that, should we have a "staging" and "main" for mini-os in the main mini-os tree, or what ? Ian. From xen-devel-bounces@lists.xenproject.org Wed Sep 01 11:05:40 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Sep 2021 11:05:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.176300.320808 (Exim 4.92) (envelope-from ) id 1mLO3W-0000Sr-Nm; Wed, 01 Sep 2021 11:05:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 176300.320808; Wed, 01 Sep 2021 11:05:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLO3W-0000Sk-KG; Wed, 01 Sep 2021 11:05:22 +0000 Received: by outflank-mailman (input) for mailman id 176300; Wed, 01 Sep 2021 11:05:21 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLO3V-0000Se-2E for xen-devel@lists.xenproject.org; Wed, 01 Sep 2021 11:05:21 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (unknown [40.107.7.59]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 7d43c135-0b14-11ec-adc6-12813bfff9fa; Wed, 01 Sep 2021 11:05:19 +0000 (UTC) Received: from AM5P194CA0016.EURP194.PROD.OUTLOOK.COM (2603:10a6:203:8f::26) by PAXPR08MB6365.eurprd08.prod.outlook.com (2603:10a6:102:156::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.24; Wed, 1 Sep 2021 11:05:17 +0000 Received: from AM5EUR03FT039.eop-EUR03.prod.protection.outlook.com (2603:10a6:203:8f:cafe::e) by AM5P194CA0016.outlook.office365.com (2603:10a6:203:8f::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.17 via Frontend Transport; Wed, 1 Sep 2021 11:05:17 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT039.mail.protection.outlook.com (10.152.17.185) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.17 via Frontend Transport; Wed, 1 Sep 2021 11:05:16 +0000 Received: ("Tessian outbound f11f34576ce3:v103"); Wed, 01 Sep 2021 11:05:16 +0000 Received: from a6d1ef8b4f9a.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id B27C819D-887B-4E18-942E-769D873BED20.1; Wed, 01 Sep 2021 11:05:10 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id a6d1ef8b4f9a.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 01 Sep 2021 11:05:10 +0000 Received: from DB9PR08MB6857.eurprd08.prod.outlook.com (2603:10a6:10:2a2::7) by DB9PR08MB6507.eurprd08.prod.outlook.com (2603:10a6:10:25a::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.24; Wed, 1 Sep 2021 11:04:54 +0000 Received: from DB9PR08MB6857.eurprd08.prod.outlook.com ([fe80::2c28:50cf:49fd:da32]) by DB9PR08MB6857.eurprd08.prod.outlook.com ([fe80::2c28:50cf:49fd:da32%7]) with mapi id 15.20.4457.024; Wed, 1 Sep 2021 11:04:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7d43c135-0b14-11ec-adc6-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=taURv7rLin99uMRFD4DUiQt0w7d5GpQcs6q42zdEV4c=; b=dOe2ZzxLd7Fnf0BEO/ImzgRIN1Zhfc44eJvv0Tye8Sbt7Bg+yB2rJP/BJRPZtzTv0vw0YTrrYQWiu/qM8mOgQsqONRO3utuJS0r/8yS1gtLq3twqOC0A+1UX4mO52nu66UIqFGUzg2Z+Hq4sdGuI0O2JMkmtMu//mS+v9srcWaI= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=H3sUvAp3Y+T5ffH83q2K15+0jiHu8+Lf3BBw09sqYAdgCbVE1c7oRxQRB0OnmS0YxDbvd1IAfgPgXxHO6NuXvjSuKvm3f/54RdHnJzwoHA2I+6bx4J2Rra20wL+0V7iUCo2hgidioN0M+pPVEGXqdcgWPtdp2wVWo2hZy/3+AYTG5rEQvgwjLaOZ7SYwjlxVSRvPpR3HHMoUGdFaCqu24lXegqTMNWXDHYfcWovaeuHLcjddvVSiDhBCa7DvCMtvglqIwSQxRIuP/nCta/bH4ogvgS3HJeEizVEYyBfs0xnQhmVqM1pN7HBDWBQJwjWktp9l0Xe06QwUbU8XEJ7Q/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=taURv7rLin99uMRFD4DUiQt0w7d5GpQcs6q42zdEV4c=; b=cZyJ6HksLM2uPO40guGsveb9qwgNeB05QeoWkSs2wG0y/U7f4LFFVJjzRc1al0P4lUwtnaXkaEAL2gwi0iz7X9LfmL9urQKoYJLxFVGODRIKfGiamegemftnWP3EphdJNREuVLJWB2pmr7nf9QNRHtB/n0dQvHvG/Q8ryzAWrqwAj3xyYwnsyHCAEqe+fzxoOToJGBDxLRnyTkWErasbNcD3MLQHGl8wcn3LWr222Ew8ONqbBvRHxGd0njGk9bWEXvumIM7hO5e/ETVztaQh00JbswfIBX2QJjqOp7CyCEOuvKWHSnc+c4XwF12Uxuoz+hszSWWzOUx4lbkCA2MiEA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=taURv7rLin99uMRFD4DUiQt0w7d5GpQcs6q42zdEV4c=; b=dOe2ZzxLd7Fnf0BEO/ImzgRIN1Zhfc44eJvv0Tye8Sbt7Bg+yB2rJP/BJRPZtzTv0vw0YTrrYQWiu/qM8mOgQsqONRO3utuJS0r/8yS1gtLq3twqOC0A+1UX4mO52nu66UIqFGUzg2Z+Hq4sdGuI0O2JMkmtMu//mS+v9srcWaI= From: Wei Chen To: Stefano Stabellini CC: "xen-devel@lists.xenproject.org" , "julien@xen.org" , Bertrand Marquis Subject: RE: [XEN RFC PATCH 24/40] xen/arm: introduce a helper to parse device tree NUMA distance map Thread-Topic: [XEN RFC PATCH 24/40] xen/arm: introduce a helper to parse device tree NUMA distance map Thread-Index: AQHXjps+iLbrOQu8n06b5z+EtCRt06uM5puAgABnI4CAAPWOAIAA3gOA Date: Wed, 1 Sep 2021 11:04:53 +0000 Message-ID: References: <20210811102423.28908-1-wei.chen@arm.com> <20210811102423.28908-25-wei.chen@arm.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: C3D79CBE99666740BDBA0FEEF858F8C1.0 x-checkrecipientchecked: true Authentication-Results-Original: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=arm.com; x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: 96c79db5-a1c1-4b46-aa1f-08d96d386131 x-ms-traffictypediagnostic: DB9PR08MB6507:|PAXPR08MB6365: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:10000;OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: OQhFkHAc/Vg6Pu292zrG1qOYz4jj8UnazzNez37Mwv7mV7ufB8Y2F7m1ZU51UsBKzzaWEiSTFp/Inufd8XpV11sBiUSoRjWR2998cn4P3hXlRbpH66bkPDMyc3jqQcp7WwW+BTyEjZJJiLYcrGi8Lb8wNdNGxEgPRsR/eDLtWScpcDK9x7Hx3UHkMO7fa6d5OnpKrOtBj4gjjNXcwcaRS2E38IvUAq+m6Zplpg94r1Isc7iMbhcTVfwHXeS+bQbgawvcY+DGEA5CixQgz5mp0IoZRM9C2EvMVBuQ4z74vY91iT5eu+tmGKYumQJlLgH11mBWv9kJVtrdZ2LV3hzxsxXo9+G6CZZpeUWYCXVHOZzuruDVi7cdHH4ZZfR8S6T1VxkHh3WuaqGhygP1Fvhee6IUz/SOBWJ6OkOpzTQAHv1wryD/Md0AA2jQ8fNygam++xC+cZAhaqzNpD5o81XIWEt+p6G/cYANV8pj8XBFJ7Znxp4CyY+gHuTLx8lI9s4BqaQBHKPWKX3se0pFO+vcf1g2kNib4frxA98V8KGgtrhTF/L38j8XFikQeDIQqODPMghrnJKa3gDUdea8Zd2pHx5v2PskjW92LapkH64d/s1aH37EakC2seioICHUzTKZLnkIYU2y4VWSTEQdFthGSFmpdgukLtrS+A8YVUw2wemJhex9okHZR/HAEREJekaoSkRrLEWmOx/OiMiffWDs2g== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB9PR08MB6857.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(136003)(376002)(396003)(39860400002)(346002)(366004)(186003)(53546011)(66946007)(76116006)(55016002)(6506007)(7696005)(64756008)(52536014)(66446008)(66556008)(6916009)(8676002)(66476007)(478600001)(9686003)(4326008)(83380400001)(26005)(38070700005)(8936002)(33656002)(316002)(71200400001)(2906002)(122000001)(86362001)(38100700002)(5660300002)(54906003);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?d0lteWo5c3pMdUQ4RlppK2kza0RENjNML1piR21Mc0VPdzhFaFU5Y2ZYb0lr?= =?utf-8?B?Y1FMUWROTmN2T24rcElQaTZKL0tieVpnMEFqUmpSODZ1NFQ2K3NWMEloMU13?= =?utf-8?B?TTBiTHNoeVJtY0MzRW9MN0VuaGpVZmw1UXZrZGx5bm5talc2ZmdwNDh1Zjl0?= =?utf-8?B?bXU3czFteEZBMmdhU0QzbDdKV1cwMmVLYkZWVGIxRDhvSituRHlsU250L0ZK?= =?utf-8?B?VGtyRFlUZmJzVHZOQ0UrUTIxMUZqUjFOMTBQV0REL3ZJZWFNeGtabGEydGdM?= =?utf-8?B?NG83Y21LQitMSUxpc3NrM1V6V2duekNpc3RMc0J0MmMxZDdDRU92R3phY2JL?= =?utf-8?B?SDM0YVNHanQzM0ZTa2JJalhOYUhnc21KSy96ZFhCR2NMb2ZDZHZBbTR0RlQ0?= =?utf-8?B?dkx4WjR6QkJmL25aK3NkajBtWUpsc1orbmthbnRZQXY3ZkNtNVVmZ3FhWVlR?= =?utf-8?B?d1FKaUk3a20wR2RIaUoybERqNlJyZmE2K1dnOHVYTTdsV21nU1lHTFdsUmUv?= =?utf-8?B?NXI0WCt6a011bXpKNU5rWGk3eWV0ZldsbXR5NlZ6ZU5OQkcwY3BINU9VRGtP?= =?utf-8?B?R3VXV1I3R0RLMHlkaFRUQUdnUVRtNjJQUHZYNkR5Sjh2bUNBaHBJU3lRYmdG?= =?utf-8?B?My8za09DZVZFV2VHWHgvVXdBSTdtY3J3SE03RHc3dVFKa3ozV3VKdXNtS1lE?= =?utf-8?B?VlRsM3ZKUU5NOGlyK0RLRDlrVFczUDRNcTM0L1YyRmxYQzdqaFMwRzA5UUdy?= =?utf-8?B?MzVRVURnVlhSdnMzcXZNVURnYlZUZUE1NTRlNExucnpha3dkWEdPSGlwd3Ns?= =?utf-8?B?TEVKSC9vbmcrL1MyN1ovdmx6RzYzYWdmdGZPanBLZVpXYkhZMXlFaHlvQ3hF?= =?utf-8?B?clNNMytwWDZmVHNUTm1wRlNjTUY1Nnc1SXRQaEVqNlB2aGlkNE96WmxYSTNS?= =?utf-8?B?bnhpR0d0TGMzUzl5MW1UOHpoNnZ6U2hxakFkOXFXajJyQWN6bkoxejlpbnlC?= =?utf-8?B?U3NMTldoNG5jU0FrdWlIT2s5T0doSUlVK1pEdUpXVFloNUlSMGZoYnJJay83?= =?utf-8?B?ZmRlVzhRMkFNamRjejMwaGdiVG1lK2NkSVQ2TlFFaWg4VnZUbFVDOCtWeDBE?= =?utf-8?B?UVAxdUZFb0F5d2VJOSt0bnl0OWF2dDRHRzNmdkFMZjBMbnFEVTVRKzdFdE9x?= =?utf-8?B?dkQrL25STFczcHAxMVBLQlYyd3pHWjZqUlRWbVUvcDgwUFExSkJKZ1RMdzBa?= =?utf-8?B?YjQ3OWZpTDczVFEwNmtacmphUHdMazJnNjhQYWh1bkE3UFMyV3NGb1V6LzZi?= =?utf-8?B?c3dRMFc5a1lCTUtZcktTUUQyTmlSaUZ0Qnlqb1hQWVdLOXl6SlU2S1RSRHBY?= =?utf-8?B?b3hoQ3p4R0d4cENDNnFVQ2NyRUpZTHlBM2duRW9YdXcvWWk1VXFiN3JLVDdK?= =?utf-8?B?cVV0dTVGSjNWejk1VDExSEVPV1p0RU84dXFjR2RGcGx5VG80U3lWcGZOMzFS?= =?utf-8?B?YmpGelhBeHJldHRzMStpYzF2UkhISHVJSm1HcW5CUmRrcDQ4eVNVbUtTWUU1?= =?utf-8?B?S0Jpd0dtTE1wbWF2RFkwa3BnMndQQU95WlAvNmprMHRybkdDT0ZJcEFka0Zp?= =?utf-8?B?SkV4djZRQVdlNFQ1U1BFamtGanZXbWxFR0pUV28veXVOc0dqOThlNWh4UTZz?= =?utf-8?B?cTNFL0xGTFZkMlc1ankxdW1xUFpPN1ZVOWRVU2RZNjlDYmhlSGFVUHFCMjU5?= =?utf-8?Q?59IMbKIbpR5+Cxou3R/O68xRyYuUo/dN9BaQYrh?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB6507 Original-Authentication-Results: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT039.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 4f0d553c-e065-4eea-5992-08d96d3853d0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: JwArvXzP4kESMjXKXPw+MBfSiUEhjyMlWVR9wZtDAReobnoTMP71bp3aBYiHkF/Xwq1LUOe6U6ZAwrZMT3S9SEhILo4WNhGQCjlSALCSVOT8uvhSzjncoK/glw6s209EkOJO6jku3ahbZJ/2KIqnQzykIRchoUBaBsJWSoHMGeplXYsBRwFgILEkDQuNXH8wCnsGmzrq1suuTTd9hp4lZ2XJRjV/6Tdr0oCaH6vU6rwknmmlZsU4ZBRNYqC0d+RzaF4RKATlpNF0M5a6TkM4bzYXi+U6G5g5jDsHlkpnnGbU8YQJ9OYBuIQJ1FG4XBv0OANHZ1zuqhMFrMa588lZrCW2lm2Gbmtpun4wzhtLJMqAS/3JMC7w3EIVotPX371Tl07/1RgwllWSvx0/xExsyyaASAGDIFyzPZdc6egDtsiWGNLz9HkpKHdPEz5UdHsexZOdEv5m1rKFiB0CsBTNF7On9IJ85bsTMjcB4EY/12WxwI64qRcvgd93Defcp7odW97P4iK0W4sQpbL7dtTy0PS9Oxu3yxl/OAcM9okbfHdPVYuDdGd2BUmotAuk1+A7Z7C9vtbF5Fc5ODJYgBAfK4h87WoedNTgL34dNFBtXBkZPo1QzrQOg05KZ2a8Cv+ttxdcQ6KUPL/1XRz9Cji1BNog/gR4p15T/QN6Gtf3uldzkjGp4zQqCZ1FAyoLYcZmXNvvaP8ynUwdBRdbRYJ+pQ== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(336012)(53546011)(47076005)(8676002)(316002)(86362001)(7696005)(2906002)(5660300002)(356005)(70586007)(70206006)(83380400001)(81166007)(82310400003)(9686003)(508600001)(6506007)(8936002)(33656002)(4326008)(36860700001)(26005)(55016002)(52536014)(6862004)(186003)(54906003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Sep 2021 11:05:16.5177 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 96c79db5-a1c1-4b46-aa1f-08d96d386131 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT039.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6365 SGkgU3RlZmFubywNCg0KPiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBYZW4t ZGV2ZWwgPHhlbi1kZXZlbC1ib3VuY2VzQGxpc3RzLnhlbnByb2plY3Qub3JnPiBPbiBCZWhhbGYg T2YNCj4gU3RlZmFubyBTdGFiZWxsaW5pDQo+IFNlbnQ6IDIwMjHlubQ55pyIMeaXpSA1OjM2DQo+ IFRvOiBXZWkgQ2hlbiA8V2VpLkNoZW5AYXJtLmNvbT4NCj4gQ2M6IFN0ZWZhbm8gU3RhYmVsbGlu aSA8c3N0YWJlbGxpbmlAa2VybmVsLm9yZz47IHhlbi0NCj4gZGV2ZWxAbGlzdHMueGVucHJvamVj dC5vcmc7IGp1bGllbkB4ZW4ub3JnOyBCZXJ0cmFuZCBNYXJxdWlzDQo+IDxCZXJ0cmFuZC5NYXJx dWlzQGFybS5jb20+DQo+IFN1YmplY3Q6IFJFOiBbWEVOIFJGQyBQQVRDSCAyNC80MF0geGVuL2Fy bTogaW50cm9kdWNlIGEgaGVscGVyIHRvIHBhcnNlDQo+IGRldmljZSB0cmVlIE5VTUEgZGlzdGFu Y2UgbWFwDQo+IA0KPiBPbiBUdWUsIDMxIEF1ZyAyMDIxLCBXZWkgQ2hlbiB3cm90ZToNCj4gPiBI aSBTdGVmYW5vLA0KPiA+DQo+ID4gPiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiA+ID4g RnJvbTogU3RlZmFubyBTdGFiZWxsaW5pIDxzc3RhYmVsbGluaUBrZXJuZWwub3JnPg0KPiA+ID4g U2VudDogMjAyMeW5tDjmnIgzMeaXpSA4OjQ4DQo+ID4gPiBUbzogV2VpIENoZW4gPFdlaS5DaGVu QGFybS5jb20+DQo+ID4gPiBDYzogeGVuLWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnOyBzc3Rh YmVsbGluaUBrZXJuZWwub3JnOw0KPiBqdWxpZW5AeGVuLm9yZzsNCj4gPiA+IGpiZXVsaWNoQHN1 c2UuY29tOyBCZXJ0cmFuZCBNYXJxdWlzIDxCZXJ0cmFuZC5NYXJxdWlzQGFybS5jb20+DQo+ID4g PiBTdWJqZWN0OiBSZTogW1hFTiBSRkMgUEFUQ0ggMjQvNDBdIHhlbi9hcm06IGludHJvZHVjZSBh IGhlbHBlciB0bw0KPiBwYXJzZQ0KPiA+ID4gZGV2aWNlIHRyZWUgTlVNQSBkaXN0YW5jZSBtYXAN Cj4gPiA+DQo+ID4gPiBPbiBXZWQsIDExIEF1ZyAyMDIxLCBXZWkgQ2hlbiB3cm90ZToNCj4gPiA+ ID4gQSBOVU1BIGF3YXJlIGRldmljZSB0cmVlIHdpbGwgcHJvdmlkZSBhICJkaXN0YW5jZS1tYXAi IG5vZGUgdG8NCj4gPiA+ID4gZGVzY3JpYmUgZGlzdGFuY2UgYmV0d2VlbiBhbnkgdHdvIG5vZGVz LiBUaGlzIHBhdGNoIGludHJvZHVjZSBhDQo+ID4gPiA+IG5ldyBoZWxwZXIgdG8gcGFyc2UgdGhp cyBkaXN0YW5jZSBtYXAuDQo+ID4gPiA+DQo+ID4gPiA+IFNpZ25lZC1vZmYtYnk6IFdlaSBDaGVu IDx3ZWkuY2hlbkBhcm0uY29tPg0KPiA+ID4gPiAtLS0NCj4gPiA+ID4gIHhlbi9hcmNoL2FybS9u dW1hX2RldmljZV90cmVlLmMgfCA2Nw0KPiArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr KysNCj4gPiA+ID4gIDEgZmlsZSBjaGFuZ2VkLCA2NyBpbnNlcnRpb25zKCspDQo+ID4gPiA+DQo+ ID4gPiA+IGRpZmYgLS1naXQgYS94ZW4vYXJjaC9hcm0vbnVtYV9kZXZpY2VfdHJlZS5jDQo+ID4g PiBiL3hlbi9hcmNoL2FybS9udW1hX2RldmljZV90cmVlLmMNCj4gPiA+ID4gaW5kZXggYmJlMDgx ZGNkMS4uNmUwZDFkM2Q5ZiAxMDA2NDQNCj4gPiA+ID4gLS0tIGEveGVuL2FyY2gvYXJtL251bWFf ZGV2aWNlX3RyZWUuYw0KPiA+ID4gPiArKysgYi94ZW4vYXJjaC9hcm0vbnVtYV9kZXZpY2VfdHJl ZS5jDQo+ID4gPiA+IEBAIC0yMDAsMyArMjAwLDcwIEBAIGRldmljZV90cmVlX3BhcnNlX251bWFf bWVtb3J5X25vZGUoY29uc3Qgdm9pZA0KPiAqZmR0LA0KPiA+ID4gaW50IG5vZGUsDQo+ID4gPiA+ DQo+ID4gPiA+ICAgICAgcmV0dXJuIDA7DQo+ID4gPiA+ICB9DQo+ID4gPiA+ICsNCj4gPiA+ID4g Ky8qIFBhcnNlIE5VTUEgZGlzdGFuY2UgbWFwIHYxICovDQo+ID4gPiA+ICtpbnQgX19pbml0DQo+ ID4gPiA+ICtkZXZpY2VfdHJlZV9wYXJzZV9udW1hX2Rpc3RhbmNlX21hcF92MShjb25zdCB2b2lk ICpmZHQsIGludCBub2RlKQ0KPiA+ID4gPiArew0KPiA+ID4gPiArICAgIGNvbnN0IHN0cnVjdCBm ZHRfcHJvcGVydHkgKnByb3A7DQo+ID4gPiA+ICsgICAgY29uc3QgX19iZTMyICptYXRyaXg7DQo+ ID4gPiA+ICsgICAgaW50IGVudHJ5X2NvdW50LCBsZW4sIGk7DQo+ID4gPiA+ICsNCj4gPiA+ID4g KyAgICBwcmludGsoWEVOTE9HX0lORk8gIk5VTUE6IHBhcnNpbmcgbnVtYS1kaXN0YW5jZS1tYXBc biIpOw0KPiA+ID4gPiArDQo+ID4gPiA+ICsgICAgcHJvcCA9IGZkdF9nZXRfcHJvcGVydHkoZmR0 LCBub2RlLCAiZGlzdGFuY2UtbWF0cml4IiwgJmxlbik7DQo+ID4gPiA+ICsgICAgaWYgKCAhcHJv cCApDQo+ID4gPiA+ICsgICAgew0KPiA+ID4gPiArICAgICAgICBwcmludGsoWEVOTE9HX1dBUk5J TkcNCj4gPiA+ID4gKyAgICAgICAgICAgICAgICJOVU1BOiBObyBkaXN0YW5jZS1tYXRyaXggcHJv cGVydHkgaW4gZGlzdGFuY2UtDQo+IG1hcFxuIik7DQo+ID4gPiA+ICsNCj4gPiA+ID4gKyAgICAg ICAgcmV0dXJuIC1FSU5WQUw7DQo+ID4gPiA+ICsgICAgfQ0KPiA+ID4gPiArDQo+ID4gPiA+ICsg ICAgaWYgKCBsZW4gJSBzaXplb2YodWludDMyX3QpICE9IDAgKQ0KPiA+ID4gPiArICAgIHsNCj4g PiA+ID4gKyAgICAgICAgcHJpbnRrKFhFTkxPR19XQVJOSU5HDQo+ID4gPiA+ICsgICAgICAgICAg ICAgICAiZGlzdGFuY2UtbWF0cml4IGluIG5vZGUgaXMgbm90IGEgbXVsdGlwbGUgb2YNCj4gdTMy XG4iKTsNCj4gPiA+ID4gKyAgICAgICAgcmV0dXJuIC1FSU5WQUw7DQo+ID4gPiA+ICsgICAgfQ0K PiA+ID4gPiArDQo+ID4gPiA+ICsgICAgZW50cnlfY291bnQgPSBsZW4gLyBzaXplb2YodWludDMy X3QpOw0KPiA+ID4gPiArICAgIGlmICggZW50cnlfY291bnQgPD0gMCApDQo+ID4gPiA+ICsgICAg ew0KPiA+ID4gPiArICAgICAgICBwcmludGsoWEVOTE9HX1dBUk5JTkcgIk5VTUE6IEludmFsaWQg ZGlzdGFuY2UtbWF0cml4XG4iKTsNCj4gPiA+ID4gKw0KPiA+ID4gPiArICAgICAgICByZXR1cm4g LUVJTlZBTDsNCj4gPiA+ID4gKyAgICB9DQo+ID4gPiA+ICsNCj4gPiA+ID4gKyAgICBtYXRyaXgg PSAoY29uc3QgX19iZTMyICopcHJvcC0+ZGF0YTsNCj4gPiA+ID4gKyAgICBmb3IgKCBpID0gMDsg aSArIDIgPCBlbnRyeV9jb3VudDsgaSArPSAzICkNCj4gPiA+ID4gKyAgICB7DQo+ID4gPiA+ICsg ICAgICAgIHVpbnQzMl90IGZyb20sIHRvLCBkaXN0YW5jZTsNCj4gPiA+ID4gKw0KPiA+ID4gPiAr ICAgICAgICBmcm9tID0gZHRfcmVhZF9udW1iZXIobWF0cml4LCAxKTsNCj4gPiA+ID4gKyAgICAg ICAgbWF0cml4Kys7DQo+ID4gPiA+ICsgICAgICAgIHRvID0gZHRfcmVhZF9udW1iZXIobWF0cml4 LCAxKTsNCj4gPiA+ID4gKyAgICAgICAgbWF0cml4Kys7DQo+ID4gPiA+ICsgICAgICAgIGRpc3Rh bmNlID0gZHRfcmVhZF9udW1iZXIobWF0cml4LCAxKTsNCj4gPiA+ID4gKyAgICAgICAgbWF0cml4 Kys7DQo+ID4gPiA+ICsNCj4gPiA+ID4gKyAgICAgICAgaWYgKCAoZnJvbSA9PSB0byAmJiBkaXN0 YW5jZSAhPSBOVU1BX0xPQ0FMX0RJU1RBTkNFKSB8fA0KPiA+ID4gPiArICAgICAgICAgICAgKGZy b20gIT0gdG8gJiYgZGlzdGFuY2UgPD0gTlVNQV9MT0NBTF9ESVNUQU5DRSkgKQ0KPiA+ID4gPiAr ICAgICAgICB7DQo+ID4gPiA+ICsgICAgICAgICAgICBwcmludGsoWEVOTE9HX1dBUk5JTkcNCj4g PiA+ID4gKyAgICAgICAgICAgICAgICAgICAiSW52YWxpZCBub2RlcycgZGlzdGFuY2UgZnJvbSBu b2RlIyVkIHRvIG5vZGUjJWQNCj4gPiA+ID0gJWRcbiIsDQo+ID4gPiA+ICsgICAgICAgICAgICAg ICAgICAgZnJvbSwgdG8sIGRpc3RhbmNlKTsNCj4gPiA+ID4gKyAgICAgICAgICAgIHJldHVybiAt RUlOVkFMOw0KPiA+ID4gPiArICAgICAgICB9DQo+ID4gPiA+ICsNCj4gPiA+ID4gKyAgICAgICAg cHJpbnRrKFhFTkxPR19JTkZPICJOVU1BOiBkaXN0YW5jZSBmcm9tIG5vZGUjJWQgdG8gbm9kZSMl ZA0KPiA+ID4gPSAlZFxuIiwNCj4gPiA+ID4gKyAgICAgICAgICAgICAgIGZyb20sIHRvLCBkaXN0 YW5jZSk7DQo+ID4gPiA+ICsgICAgICAgIG51bWFfc2V0X2Rpc3RhbmNlKGZyb20sIHRvLCBkaXN0 YW5jZSk7DQo+ID4gPiA+ICsNCj4gPiA+ID4gKyAgICAgICAgLyogU2V0IGRlZmF1bHQgZGlzdGFu Y2Ugb2Ygbm9kZSBCLT5BIHNhbWUgYXMgQS0+QiAqLw0KPiA+ID4gPiArICAgICAgICBpZiAodG8g PiBmcm9tKQ0KPiA+ID4gPiArICAgICAgICAgICAgIG51bWFfc2V0X2Rpc3RhbmNlKHRvLCBmcm9t LCBkaXN0YW5jZSk7DQo+ID4gPg0KPiA+ID4gSSBhbSBhIGJpdCB1bnN1cmUgYWJvdXQgdGhpcyBs YXN0IDIgbGluZXM6IHdoeSBjYWxsaW5nDQo+IG51bWFfc2V0X2Rpc3RhbmNlDQo+ID4gPiBpbiB0 aGUgb3Bwb3NpdGUgZGlyZWN0aW9uIG9ubHkgd2hlbiB0byA+IGZyb20/IFdvdWxkbid0IGl0IGJl IE9LIHRvDQo+ID4gPiBhbHdheXMgZG8gYm90aDoNCj4gPiA+DQo+ID4gPiBudW1hX3NldF9kaXN0 YW5jZShmcm9tLCB0bywgZGlzdGFuY2UpOw0KPiA+ID4gbnVtYV9zZXRfZGlzdGFuY2UodG8sIGZy b20sIGRpc3RhbmNlKTsNCj4gPiA+DQo+ID4gPiA/DQo+ID4gPg0KPiA+IEkgYm9ycm93ZWQgdGhp cyBjb2RlIGZyb20gTGludXgsIGJ1dCBoZXJlIGlzIG15IHVuZGVyc3RhbmRpbmc6DQo+ID4NCj4g PiBGaXJzdCwgSSByZWFkIHNvbWUgbm90ZXMgaW4gRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2Jp bmRpbmdzL251bWEudHh0DQo+ID4gMS4gRWFjaCBlbnRyeSByZXByZXNlbnRzIGRpc3RhbmNlIGZy b20gZmlyc3Qgbm9kZSB0byBzZWNvbmQgbm9kZS4NCj4gPiBUaGUgZGlzdGFuY2VzIGFyZSBlcXVh bCBpbiBlaXRoZXIgZGlyZWN0aW9uLg0KPiA+IDIuIGRpc3RhbmNlLW1hdHJpeCBzaG91bGQgaGF2 ZSBlbnRyaWVzIGluIGxleGljb2dyYXBoaWNhbCBhc2NlbmRpbmcNCj4gPiBvcmRlciBvZiBub2Rl cy4NCj4gPg0KPiA+IEhlcmUgaXMgYW4gZXhhbXBsZSBvZiBkaXN0YW5jZS1tYXAgbm9kZSBpbiBE VEI6DQo+ID4gU2FtcGxlIzEsIGZ1bGwgbGlzdDoNCj4gPiAJCWRpc3RhbmNlLW1hcCB7DQo+ID4g CQkJIGNvbXBhdGlibGUgPSAibnVtYS1kaXN0YW5jZS1tYXAtdjEiOw0KPiA+IAkJCSBkaXN0YW5j ZS1tYXRyaXggPSA8MCAwICAxMD4sDQo+ID4gCQkJCQkgICA8MCAxICAyMD4sDQo+ID4gCQkJCQkg ICA8MCAyICA0MD4sDQo+ID4gCQkJCQkgICA8MCAzICAyMD4sDQo+ID4gCQkJCQkgICA8MSAwICAy MD4sDQo+ID4gCQkJCQkgICA8MSAxICAxMD4sDQo+ID4gCQkJCQkgICA8MSAyICAyMD4sDQo+ID4g CQkJCQkgICA8MSAzICA0MD4sDQo+ID4gCQkJCQkgICA8MiAwICA0MD4sDQo+ID4gCQkJCQkgICA8 MiAxICAyMD4sDQo+ID4gCQkJCQkgICA8MiAyICAxMD4sDQo+ID4gCQkJCQkgICA8MiAzICAyMD4s DQo+ID4gCQkJCQkgICA8MyAwICAyMD4sDQo+ID4gCQkJCQkgICA8MyAxICA0MD4sDQo+ID4gCQkJ CQkgICA8MyAyICAyMD4sDQo+ID4gCQkJCQkgICA8MyAzICAxMD47DQo+ID4gCQl9Ow0KPiA+DQo+ ID4gQ2FsbCBudW1hX3NldF9kaXN0YW5jZSB3aGVuICJ0byA+IGZyb20iIHdpbGwgcHJldmVudCBY ZW4gdG8gY2FsbA0KPiA+IG51bWFfc2V0X2Rpc3RhbmNlKDAsIDEsIDIwKSBhZ2FpbiB3aGVuIGl0 J3Mgc2V0dGluZyBkaXN0YW5jZSBmb3IgPDEgMA0KPiAyMD4uDQo+ID4gQnV0LCBudW1hX3NldF9k aXN0YW5jZSgxLCAwLCAyMCkgd2lsbCBiZSBjYWxsIHR3aWNlLg0KPiA+DQo+ID4gTm9ybWFsbHks IGRpc3RhbmNlLW1hcCBub2RlIHdpbGwgYmUgb3B0aW1pemVkIGluIGZvbGxvd2luZyBzYW1wbGUj MiwNCj4gPiBhbGwgcmVkdW5kYW50IGVudHJpZXMgYXJlIHJlbW92ZWQ6DQo+ID4gU2FtcGxlIzIs IHBhcnRpYWwgbGlzdDoNCj4gPiAJCWRpc3RhbmNlLW1hcCB7DQo+ID4gCQkJIGNvbXBhdGlibGUg PSAibnVtYS1kaXN0YW5jZS1tYXAtdjEiOw0KPiA+IAkJCSBkaXN0YW5jZS1tYXRyaXggPSA8MCAw ICAxMD4sDQo+ID4gCQkJCQkgICA8MCAxICAyMD4sDQo+ID4gCQkJCQkgICA8MCAyICA0MD4sDQo+ ID4gCQkJCQkgICA8MCAzICAyMD4sDQo+ID4gCQkJCQkgICA8MSAxICAxMD4sDQo+ID4gCQkJCQkg ICA8MSAyICAyMD4sDQo+ID4gCQkJCQkgICA8MSAzICA0MD4sDQo+ID4gCQkJCQkgICA8MiAyICAx MD4sDQo+ID4gCQkJCQkgICA8MiAzICAyMD4sDQo+ID4gCQkJCQkgICA8MyAzICAxMD47DQo+ID4g CQl9Ow0KPiA+DQo+ID4gVGhlcmUgaXMgbm90IGFueSAiZnJvbSA+IHRvIiBlbnRyeSBpbiB0aGUg bWFwLiBCdXQgdXNpbmcgdGhpcyBwYXJ0aWFsDQo+IG1hcA0KPiA+IHN0aWxsIGNhbiBzZXQgYWxs IGRpc3RhbmNlcyBmb3IgYWxsIHBhaXJzLiBBbmQgbnVtYV9zZXRfZGlzdGFuY2UoMSwgMCwNCj4g MjApDQo+ID4gd2lsbCBiZSBvbmx5IG9uY2UuDQo+IA0KPiBJIHNlZS4gSSBjYW4ndCBmaW5kIGlu IERvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9udW1hLnR4dCB3aGVyZQ0KPiBpdCBz YXlzIHRoYXQgImZyb20gPiB0byIgbm9kZXMgY2FuIGJlIG9taXR0ZWQuIElmIGl0IGlzIG5vdCB3 cml0dGVuDQo+IGRvd24sIHRoZW4gc29tZWJvZHkgY291bGQgZWFzaWx5IG9wdGltaXplIGl0IHRo ZSBvcHBvc2l0ZSB3YXk6DQo+IA0KPiAgCQkJIGRpc3RhbmNlLW1hdHJpeCA9IDwwIDAgIDEwPiwN Cj4gIAkJCQkJICAgPDEgMCAgMjA+LA0KPiAgCQkJCQkgICA8MiAwICA0MD4sDQo+ICAJCQkJCSAg IDwzIDAgIDIwPiwNCj4gIAkJCQkJICAgPDEgMSAgMTA+LA0KPiAgCQkJCQkgICA8MiAxICAyMD4s DQo+ICAJCQkJCSAgIDwzIDEgIDQwPiwNCj4gIAkJCQkJICAgPDIgMiAgMTA+LA0KPiAgCQkJCQkg ICA8MyAyICAyMD4sDQo+ICAJCQkJCSAgIDwzIDMgIDEwPjsNCj4gDQoNClllcywgeW91J3JlIHJp Z2h0LiBTcGVjIGRvZXNuJ3Qgc2F5IG9wcG9zaXRlIHdheSBpcyB1bmFsbG93ZWQuDQoNCj4gSSB0 aGluayB0aGUgY29kZSBpbiBYZW4gc2hvdWxkIGJlIHJlc2lsaWVudCBhbmQgYWJsZSB0byBjb3Bl IHdpdGggYQ0KPiBkZXZpY2UgdHJlZSBsaWtlIHRoZSBvbmUgeW91IHdyb3RlIG9yIHRoZSBvbmUg SSB3cm90ZS4gRnJvbSBhIGNvZGUNCj4gcGVyc3BlY3RpdmUsIGl0IHNob3VsZCBiZSB2ZXJ5IGVh c3kgdG8gZG8uIElmIG5vdGhpbmcgZWxzZSBpdCB3b3VsZCBtYWtlDQo+IFhlbiBtb3JlIHJlc2ls aWVudCBhZ2FpbnN0IGJ1Z2d5IGZpcm13YXJlLg0KPiANCj4gDQoNCkkgZG9uJ3QgZGlzYWdyZWUg d2l0aCB0aGF0Lg0KDQo+ID4gPiBCdXQgaW4gYW55IGNhc2UsIEkgaGF2ZSBhIGRpZmZlcmVudCBz dWdnZXN0aW9uLiBUaGUgYmluZGluZyBzdGF0ZXMNCj4gdGhhdA0KPiA+ID4gImRpc3RhbmNlcyBh cmUgZXF1YWwgaW4gZWl0aGVyIGRpcmVjdGlvbiIuIEFsc28gaXQgaGFzIGFuIGV4YW1wbGUNCj4g d2hlcmUNCj4gPiA+IG9ubHkgb25lIGRpcmVjdGlvbiBpcyBleHByZXNzZWQgdW5mb3J0dW5hdGVs eSAoYXQgdGhlIGVuZCBvZiB0aGUNCj4gPiA+IGRvY3VtZW50KS4NCj4gPiA+DQo+ID4NCj4gPiBP aCwgSSBzaG91bGQgc2VlIHRoaXMgY29tbWVudCBmaXJzdCwgdGhlbiBJIHdpbGwgbm90IHBvc3Qg YWJvdmUNCj4gPiBjb21tZW50IDogKQ0KPiA+DQo+ID4gPiBTbyBteSBzdWdnZXN0aW9uIGlzIHRv IHBhcnNlIGl0IGFzIGZvbGxvd3M6DQo+ID4gPg0KPiA+ID4gLSBjYWxsIG51bWFfc2V0X2Rpc3Rh bmNlIGp1c3Qgb25jZSBmcm9tDQo+ID4gPiAgIGRldmljZV90cmVlX3BhcnNlX251bWFfZGlzdGFu Y2VfbWFwX3YxDQo+ID4gPg0KPiA+ID4gLSBpbiBudW1hX3NldF9kaXN0YW5jZToNCj4gPiA+ICAg ICAtIHNldCBub2RlX2Rpc3RhbmNlX21hcFtmcm9tXVt0b10gPSBkaXN0YW5jZTsNCj4gPiA+ICAg ICAtIGNoZWNrIG5vZGVfZGlzdGFuY2VfbWFwW3RvXVtmcm9tXQ0KPiA+ID4gICAgICAgICAgIC0g aWYgdW5zZXQsIG5vZGVfZGlzdGFuY2VfbWFwW3RvXVtmcm9tXSA9IGRpc3RhbmNlOw0KPiA+ID4g ICAgICAgICAgIC0gaWYgYWxyZWFkeSBzZXQgdG8gdGhlIHNhbWUgdmFsdWUsIHJldHVybiBzdWNj ZXNzOw0KPiA+ID4gICAgICAgICAgIC0gaWYgYWxyZWFkeSBzZXQgdG8gYSBkaWZmZXJlbnQgdmFs dWUsIHJldHVybiBlcnJvcjsNCj4gPg0KPiA+IEkgZG9uJ3QgcmVhbGx5IGxpa2UgdGhpcyBpbXBs ZW1lbnRhdGlvbi4gSSB3YW50IHRoZSBiZWhhdmlvciBvZg0KPiA+IG51bWFfc2V0X2Rpc3RhbmNl IGp1c3QgbGlrZSB0aGUgZnVuY3Rpb24gbmFtZSwgZG8gbm90IGluY2x1ZGUNCj4gPiBpbXBsaWNp dCBvcGVyYXRpb25zLiBPdGhlcndpc2UsIGV4Y2VwdCB0aGUgdXNlciByZWFkIHRoaXMgZnVuY3Rp b24NCj4gPiBpbXBsZW1lbnRhdGlvbiBiZWZvcmUgaGUgdXNlIGl0LCBoZSBwcm9iYWJseSBkb2Vz bid0IGtub3cgdGhpcw0KPiA+IGZ1bmN0aW9uIGhhcyBkb25lIHNvIG1hbnkgdGhpbmdzLg0KPiAN Cj4gWW91IGNhbiBsZWF2ZSBudW1hX3NldF9kaXN0YW5jZSBhcy1pcyB3aXRob3V0IGFueSBpbXBs aWNpdCBvcGVyYXRpb25zLg0KPiANCj4gSW4gdGhhdCBjYXNlLCBqdXN0IGNhbGwgbnVtYV9zZXRf ZGlzdGFuY2UgdHdpY2UgZnJvbSBudW1hX3NldF9kaXN0YW5jZQ0KPiBmb3IgYm90aCBmcm9tL3Rv IGFuZCB0by9mcm9tLiBudW1hX3NldF9kaXN0YW5jZSBjb3VsZCByZXR1cm4gZXJyb3IgaXMNCg0K SSBhbSBPSyBmb3IgdGhlIGZpcnN0IHNlbnRlbmNlLiBCdXQuLi4NCg0KPiB0aGUgZW50cnkgd2Fz IGFscmVhZHkgc2V0IHRvIGEgZGlmZmVyZW50IHZhbHVlIG9yIHN1Y2Nlc3Mgb3RoZXJ3aXNlDQo+ IChhbHNvIGluIHRoZSBjYXNlIGl0IHdhcyBhbHJlYWR5IHNldCB0byB0aGUgc2FtZSB2YWx1ZSku IFRoaXMgd291bGQNCg0KLi4uIEkgcHJlZmVyIG5vdCB0byBjaGVjayB0aGUgcHJldmlvdXMgdmFs dWUuIFN1YnNlcXVlbnQgbnVtYV9zZXRfZGlzdGFuY2UNCmNhbGwgd2lsbCBvdmVycmlkZSBwcmV2 aW91cyBjYWxscy4gS2VlcCBudW1hX3NldF9kaXN0YW5jZSBhcyBzaW1wbGUgYXMNCml0IGNhbi4g QW5kIHdoZW4geW91IHBhc3MgbmV3IGRhdGEgdG8gbnVtYV9zZXRfZGlzdGFuY2UsIGl0IGRvZXNu J3QNCmtub3cgd2hldGhlciB0aGUgcHJldmlvdXMgZGF0YSB3YXMgY29ycmVjdCBvciB0aGUgbmV3 IGRhdGEgaXMgY29ycmVjdC4NCk9ubHkgY2FsbGVyIG1heSBoYXZlIGtub3duLiAgDQoNCj4gYWxs b3cgWGVuIHRvIGNvcGUgd2l0aCBib3RoIHNjZW5hcmlvcyBhYm92ZS4NCg== From xen-devel-bounces@lists.xenproject.org Wed Sep 01 11:13:28 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Sep 2021 11:13:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.176307.320819 (Exim 4.92) (envelope-from ) id 1mLOBH-00029A-NC; Wed, 01 Sep 2021 11:13:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 176307.320819; Wed, 01 Sep 2021 11:13:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLOBH-000293-Jq; Wed, 01 Sep 2021 11:13:23 +0000 Received: by outflank-mailman (input) for mailman id 176307; Wed, 01 Sep 2021 11:13:23 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLOBG-00028x-Sr for xen-devel@lists.xen.org; Wed, 01 Sep 2021 11:13:22 +0000 Received: from EUR03-DB5-obe.outbound.protection.outlook.com (unknown [40.107.4.76]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 9bb5ca6c-0b15-11ec-adc6-12813bfff9fa; Wed, 01 Sep 2021 11:13:18 +0000 (UTC) Received: from DU2PR04CA0325.eurprd04.prod.outlook.com (2603:10a6:10:2b5::30) by AM0PR08MB4194.eurprd08.prod.outlook.com (2603:10a6:208:130::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.23; Wed, 1 Sep 2021 11:13:13 +0000 Received: from DB5EUR03FT036.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:2b5:cafe::24) by DU2PR04CA0325.outlook.office365.com (2603:10a6:10:2b5::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.17 via Frontend Transport; Wed, 1 Sep 2021 11:13:13 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT036.mail.protection.outlook.com (10.152.20.185) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.17 via Frontend Transport; Wed, 1 Sep 2021 11:13:13 +0000 Received: ("Tessian outbound 32695b2df2f8:v103"); Wed, 01 Sep 2021 11:13:12 +0000 Received: from bd6ec8162f79.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id BA8665A1-F513-4FEB-8A42-7A1934CDEE01.1; Wed, 01 Sep 2021 11:13:03 +0000 Received: from EUR02-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id bd6ec8162f79.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 01 Sep 2021 11:13:03 +0000 Received: from DB9PR08MB6857.eurprd08.prod.outlook.com (2603:10a6:10:2a2::7) by DBBPR08MB4887.eurprd08.prod.outlook.com (2603:10a6:10:d7::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.23; Wed, 1 Sep 2021 11:12:59 +0000 Received: from DB9PR08MB6857.eurprd08.prod.outlook.com ([fe80::2c28:50cf:49fd:da32]) by DB9PR08MB6857.eurprd08.prod.outlook.com ([fe80::2c28:50cf:49fd:da32%7]) with mapi id 15.20.4457.024; Wed, 1 Sep 2021 11:12:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9bb5ca6c-0b15-11ec-adc6-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qymYKIcXOO0dP0B4z6PRI6eakNqJsD30akV7Mw1HHHg=; b=rX+Yy4gsYmATFacMupKndvzmQVMDbH1PkzeRfORDwAhFm4WU/i1cueDAK9HTmfZuWfehm3GxZzrrvk/KBBYd0IyzrLMlznRLC3QoCnyKHi4YbFCevrQqW6U23bhwyuhM5UDtcjLC5jz71ck12G5FCZeno1z90AksAbj/BTDL5us= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; lists.xen.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;lists.xen.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: b2e5d06b9e648783 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iJm09T/LgAhZ6lxIoeNR5kpvzsWp2QAtwZW6Anlrh63hWGCrIgs5heMYE2umvMh0m5pI4N6RsVWh8UQiLZsTHEOOkbabtsHbmbcTRqaVBqTbdYdlPKyP0j4/OfBnJnM7N09sNpUrAioXnyuHSxTb46X1kcidPnFwdbsqKBEkpXQmseZCWhJkalQ0Tfr+Dsvv/V4YLPhVwLHHVjqqN8UOA29LQQKoeJ1H/5ia1Dx87bU/EYGtSOUwhfS6ovyf8b4G9IZXiLSek/NYWURpm+GgJAM+SSfPDGz8NdhFaVnYN0bWRKE1UUZzX4pCfjbfWq/iphOhxpFQnFizGm0c4UyBFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qymYKIcXOO0dP0B4z6PRI6eakNqJsD30akV7Mw1HHHg=; b=hyDev9GVkOiJbP650AyNIlaMdCLxvwIZ9zf46NixmDHTXlCnTHbsmWuSML6aue9AbPIXb1pMYKKCiME+niZIFztf3iXwbPIX3Kk4GaW4rqLWQ7hGIcS81MHy9AT0lWOEsXIQdfvpz23nzVZ+zjPTkaTE22eaaEmEW11G6UE+agAOhVN67AER7nfa/lqvWa4Zi7nMzGgICsSz6nWaQt6EEhWbaSHbTZtmC79lC7P7iLqr1z2bsG06+D+2MQFN+Z4u0l3P7RuRisHUTKq+lF/QVhBcgddxWfxdAlnibFvETSy5Qwt6I8OAtxyGhEogMhQGofQ0OQKK3s8MMGCa+bl3DA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qymYKIcXOO0dP0B4z6PRI6eakNqJsD30akV7Mw1HHHg=; b=rX+Yy4gsYmATFacMupKndvzmQVMDbH1PkzeRfORDwAhFm4WU/i1cueDAK9HTmfZuWfehm3GxZzrrvk/KBBYd0IyzrLMlznRLC3QoCnyKHi4YbFCevrQqW6U23bhwyuhM5UDtcjLC5jz71ck12G5FCZeno1z90AksAbj/BTDL5us= From: Wei Chen To: AKASHI Takahiro CC: Oleksandr Tyshchenko , Stefano Stabellini , Alex Benn??e , Kaly Xin , Stratos Mailing List , "virtio-dev@lists.oasis-open.org" , Arnd Bergmann , Viresh Kumar , Stefano Stabellini , "stefanha@redhat.com" , Jan Kiszka , Carl van Schaik , "pratikp@quicinc.com" , Srivatsa Vaddagiri , Jean-Philippe Brucker , Mathieu Poirier , Oleksandr Tyshchenko , Bertrand Marquis , Artem Mygaiev , Julien Grall , Juergen Gross , Paul Durrant , nd , Xen Devel Subject: RE: Enabling hypervisor agnosticism for VirtIO backends Thread-Topic: Enabling hypervisor agnosticism for VirtIO backends Thread-Index: AQHXiWXOlXnRp9GT30mY/CfP5cid16tt4TUAgAVQpQCAAsKLQIABdsmAgAADLTCAAWVyAIAAMB+ggAMGMQCACZ/8gIAAKWUQgAd5oYCAAeKfwA== Date: Wed, 1 Sep 2021 11:12:58 +0000 Message-ID: References: <20210811062748.GB54169@laputa> <20210817080757.GC43203@laputa> <20210818053840.GE39588@laputa> <20210820064150.GC13452@laputa> <20210826094047.GA55218@laputa> <20210831061805.GB69817@laputa> In-Reply-To: <20210831061805.GB69817@laputa> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: D25FD981A493B04A9A287D69C0E5CFEB.0 Authentication-Results-Original: linaro.org; dkim=none (message not signed) header.d=none;linaro.org; dmarc=none action=none header.from=arm.com; x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: c29a6f61-2d92-4bc3-74e8-08d96d397d37 x-ms-traffictypediagnostic: DBBPR08MB4887:|AM0PR08MB4194: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:7219;OLM:7219; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 3D+9LuLEUPjDhKQM7OQC2G2wWIqfA1xYzIQ/Ue2vZumRNJBbfelqjG7Lj6NhUjUgbp2yoqQX6FZbIRJ15XJyyeHnoO4vXCQkTphkwON0U3hPoXPr6xqnslxTG+gv9E8ATlYPXXW3SW3cjsdjPn3DN4MGMPAJPJV02kL3RXU/t+z9WLOwERuhG5QWFrWmIQEtF+20cGZEHjHkvya01NQ7PWI39fU5CqUl/VcwkZFITtq3aUwJMm+cFiyZhJrszuxG8QzW7rjQPoDKzyU8qtSFn60Vg0OEZZZqShpxbgRU+JkPLCk0qK6UBv3/5tYCENbXtFwlqweIWijQVQhnZ9CLsT02aCfCmCWhNYVt0w1o5RZ5jT0ZW2gNV9Rd+FNI78/CjUhf/b9MZ487oV4iIwG+UO4NoFa68ClA9UiGhhyfGOKHAJhHCCvJCivumhwKN2JYz2PSX6sCo9+nN6JUTW+d0CjQZfqlka+CxK8kIs3VR+hcw+sUFr2rmBW+NMb1fGBLrlU75426tJmWCSFFVqzUhoprwDATcLB9D/NRouM50Z+TtN9cNplE71YLy+1Hnp7vTF9lsi0sHvuS4zhjw1ZxAn6k2810UMlh5X9c+INcgRmvfTJhXykUry+YFbNqNFGgztNLrTGgclmSgSYmkHICKYsrJYdXh6BZotz1O2xevlD98eT2qR0v6005UVUmFVZEwPzliasK/b62sKFeESSxkAEVeOJ4AWoP3diPt1C/ilYoL0tH4G3v4+21bQJUg+d4BFJ/PZfTlRnXlzJmiUh+SBahCQbKjPyncsEwxLEwHKfFJ/Sd4qnuUIg5ZlcfcXMuawbn+cpves41PIAx2sA4Bw== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB9PR08MB6857.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(366004)(136003)(39860400002)(396003)(376002)(71200400001)(8936002)(66476007)(33656002)(6506007)(478600001)(52536014)(122000001)(7696005)(53546011)(38100700002)(55016002)(966005)(9686003)(54906003)(30864003)(38070700005)(8676002)(186003)(26005)(76116006)(2906002)(7416002)(86362001)(316002)(66446008)(66556008)(66946007)(83380400001)(5660300002)(64756008)(66574015)(6916009)(4326008)(559001)(579004);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?OEZqL1dTREV1SE9UK012VkVZaUZCOEpWR2sxbnhzNGNWd3RzSDRuUTNHVmEy?= =?utf-8?B?U3dPRTZCY2JtYmZCckRzOGJVVXk3UXMrcW5xZHNrLzFrVHlPdFB3YTg5Wmpq?= =?utf-8?B?U0xSWStOMVRtM0F1ZFpDUndJdkYvVHBlMEhwRVFXWDBsOHQvQ20xbFlSMHp3?= =?utf-8?B?QTdMZUZFbXpET01CMUoxWFR6RWRjZlBnazEzL1lRTUI5MVlEUmRzQXhNQXpR?= =?utf-8?B?TzUxUFJ6b2xFaU03T1RkUEpodERkWXVNbG5jYk80QkxabWJyTFUwOHkwYk51?= =?utf-8?B?ekgyaXJLNVpoUm1Za0xicVV2SG1KODRwekRSbXYwdTlJZThvR2V3bmErYlhi?= =?utf-8?B?OFB4TW1Xek0zbEhQNzVIMjNsM1loYktMU0ZkVkwyWG9SVkZ5M2U3YkdaUWN5?= =?utf-8?B?TUo0T2tpTDBFUGRJdXNxY3pJSXAzZTZIMk9yL2xiZGFmRTFKYmREVjgzdG1w?= =?utf-8?B?b21rWmZOQXVDWm9nTDl6b3p4bitPdnV0TVY3Y016b1RWNkY2WCs5ZUpjZGx0?= =?utf-8?B?aGhueWpLc010OWRZeXpQL0VJRmo1bmFyc04xOHJPNC82NThDQzFoZjZ6K2hD?= =?utf-8?B?WDJYcUI2TmlwNThTbWZZeEIwVXM1R0RJR0NlSWI1WnhKUDFGQkFLdi9YNVdB?= =?utf-8?B?b2ZDYWVtWm53WUJLeHVzN0R2NWQxcitzaExaV3NnUnJ3WjI5UE9zR2RBU3NJ?= =?utf-8?B?Rlh2N1NOdkVEUVFSMXB0RHJMVUJYajlRckhQbXZrNnJldEd3enJWT1lUckVC?= =?utf-8?B?L2FSYWNVTEkyVXVENGFCeVV5SDZNWVFVam9yNkpWSVhUNU9IS1Y3Sk10L2Qz?= =?utf-8?B?LzQ3OXRZUVUrSzJqZjBGeHRTSmtqajUrQTJHelV3K002NW1wUWJZNktScjk0?= =?utf-8?B?RWE2eXlVNk5yNEFJenY3WFV0bVVWOGh4RVI1MXB1cUl5ZVRyeTZSTUxxMXJV?= =?utf-8?B?Y21sQUxqS1g2NFVObW1XQmdUazRrMGRmdHZRcFJzaG9jOHo1N2lGVnpYTUlp?= =?utf-8?B?MU5kTnJWa0hxU2crcHpBL0Z3NEg5TmZjcGIza0pzdnZLejFaNlZKSzNYWkFR?= =?utf-8?B?OVRzdXlqN0dIRmlrOWxSd2NwQjhmaThkSWdqVldUaEE3TUkyV3YzZUFuV0Rq?= =?utf-8?B?d3BTTFlQT0xWajNWemZDY3BaZjJBZXZFSE54c3JIelJyUTRhVFo0NHRmSCtM?= =?utf-8?B?NEN2NTBSK2s1N0xYVklUVGQvWlkvemluOTlLMTBtTWFOOFZKYXNVNXVZUDZP?= =?utf-8?B?U3pTb1pLbERndkNvMmRWdHZzZWtQaVpCbUlNK1N6ek5SQVVpYnpTaGZXNCts?= =?utf-8?B?bkRCS1hFaEFDVWVFU2loTDQzd0taQ2FPL0srYTVyKzdJTEJMZTlDV09PL052?= =?utf-8?B?OHNXTTJCa21RMjFUZ0g3N3lqaDJiNzdrUi80M1Y3ejJsb1RMQWoyT1dKUFR4?= =?utf-8?B?eWltQVVyOTBidEJ6Zm1ITGdmRkNCNkpna1VDcm03cjBDcVF0TnF2bm9sSTR1?= =?utf-8?B?bGM5bnI3YW9wTHk3d0dEZVJJM1lIeGR4dUpIZTJTNDFYQWpLTm9FZnRvMnE5?= =?utf-8?B?R0U1SG5NMy9hNDhtR0NyU1k3dE5xYmFvaVBXNmYrc3JOSGNnVWRqMHRhYXNl?= =?utf-8?B?K2R2RjY2b0g3TnFkU3Fya04vdUlPejNJTXRiU09kSWpteUthY29jYW5vRU5k?= =?utf-8?B?dE4yOTZTUjBKekFWaUJBUy9xZWN6RTI3VFYxcSszK3YxNWlFeXFtVHRvS3ox?= =?utf-8?Q?PFUtBbLwHxHzoidzA3sVo8UOQuRBXiDFGe3eVMG?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB4887 Original-Authentication-Results: linaro.org; dkim=none (message not signed) header.d=none;linaro.org; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT036.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: cf1ce180-4049-448c-436d-08d96d3974f3 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: DuU9i8WxAogp7VDvU7Ka+zJZHBcrQEFCj/Yu3sfj60fX9/ZvSM4Gx4VS5ERSEHQHLBlSzN0zjyByez4NTX7CWbkx5iNqFa+PubhhP1s06X77fomdZ3Ea5Du5g9js1GXzzZCzo+O431AO1lti8Ly/TQoSdycM2toZX0hqDS5R9ID9yBfV0NtJAlw+Cs2f1TWEe9wVcKEYUGPGCP6mqls+Et5stFfM4cj1vxQeEqwP+lGUoY12KcuvJflJKUNGV6fn5KAQGvYQOv9eMoOEicyFB5LpWjxIwDzOyqlyw0J5xFmIlyO/JBfINHV3PXUZ462f7dhUhAwPExJ39hGRBeR0i++c6dthZ0Mh1p9xrE4naXKgiOvBDVrMztinCtYolutbIJXdxe6oFTMscdkZFYBNmzGvpC6Ft+EB7qmCN3ZtG29LGH4EX1lb41haOUXAsGB13FJhBQmwvSr3eZsEL5MicwvK7VeWB1+TnEh+Zcf1zd0HGdkdLIQhW4jzYK3zNK6IrRAli10jpQiStiRP3HJwOSw667KdJMnYhKOkXbo6WkKylxedfwDbfpF5UV6PUTzwV9Ph/BpKboUKzH9C7YKRFWh4uhn+1yiaQf5bxs+xKnND6PoaUAkj+gvQm9TJ5j4v7GGNU3TAJwoJuJalF2VBHlAqHb396GwBnAgUlinJRg4DDN+tUowjhAamwQee6OAAIbg4ZJ4xvZ0Dzxcc3Zp5J5YfNV9UYl+u9PQXlg408UMF3Cw60JvZ/Trxt6xSYFx0B/XQhr6OOaMUb0jBJ/TbEUKQmsx55GiIMGoOIWTIue55KdcSfsuqCm1qq+o9R7cNH+j4aXJ5FMaRMPZLORA70w== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(316002)(5660300002)(966005)(508600001)(36860700001)(6506007)(9686003)(30864003)(53546011)(55016002)(8936002)(82310400003)(70206006)(26005)(70586007)(4326008)(6862004)(54906003)(86362001)(8676002)(7696005)(2906002)(33656002)(83380400001)(52536014)(356005)(81166007)(47076005)(186003)(336012)(66574015)(579004);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Sep 2021 11:13:13.0900 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c29a6f61-2d92-4bc3-74e8-08d96d397d37 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT036.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB4194 SGkgQWthc2hpLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEFLQVNI SSBUYWthaGlybyA8dGFrYWhpcm8uYWthc2hpQGxpbmFyby5vcmc+DQo+IFNlbnQ6IDIwMjHlubQ4 5pyIMzHml6UgMTQ6MTgNCj4gVG86IFdlaSBDaGVuIDxXZWkuQ2hlbkBhcm0uY29tPg0KPiBDYzog T2xla3NhbmRyIFR5c2hjaGVua28gPG9sZWtzdHlzaEBnbWFpbC5jb20+OyBTdGVmYW5vIFN0YWJl bGxpbmkNCj4gPHNzdGFiZWxsaW5pQGtlcm5lbC5vcmc+OyBBbGV4IEJlbm4/P2UgPGFsZXguYmVu bmVlQGxpbmFyby5vcmc+OyBLYWx5IFhpbg0KPiA8S2FseS5YaW5AYXJtLmNvbT47IFN0cmF0b3Mg TWFpbGluZyBMaXN0IDxzdHJhdG9zLWRldkBvcC1saXN0cy5saW5hcm8ub3JnPjsNCj4gdmlydGlv LWRldkBsaXN0cy5vYXNpcy1vcGVuLm9yZzsgQXJuZCBCZXJnbWFubiA8YXJuZC5iZXJnbWFubkBs aW5hcm8ub3JnPjsNCj4gVmlyZXNoIEt1bWFyIDx2aXJlc2gua3VtYXJAbGluYXJvLm9yZz47IFN0 ZWZhbm8gU3RhYmVsbGluaQ0KPiA8c3RlZmFuby5zdGFiZWxsaW5pQHhpbGlueC5jb20+OyBzdGVm YW5oYUByZWRoYXQuY29tOyBKYW4gS2lzemthDQo+IDxqYW4ua2lzemthQHNpZW1lbnMuY29tPjsg Q2FybCB2YW4gU2NoYWlrIDxjdmFuc2NoYUBxdGkucXVhbGNvbW0uY29tPjsNCj4gcHJhdGlrcEBx dWljaW5jLmNvbTsgU3JpdmF0c2EgVmFkZGFnaXJpIDx2YXRzYUBjb2RlYXVyb3JhLm9yZz47IEpl YW4tDQo+IFBoaWxpcHBlIEJydWNrZXIgPGplYW4tcGhpbGlwcGVAbGluYXJvLm9yZz47IE1hdGhp ZXUgUG9pcmllcg0KPiA8bWF0aGlldS5wb2lyaWVyQGxpbmFyby5vcmc+OyBPbGVrc2FuZHIgVHlz aGNoZW5rbw0KPiA8T2xla3NhbmRyX1R5c2hjaGVua29AZXBhbS5jb20+OyBCZXJ0cmFuZCBNYXJx dWlzDQo+IDxCZXJ0cmFuZC5NYXJxdWlzQGFybS5jb20+OyBBcnRlbSBNeWdhaWV2IDxBcnRlbV9N eWdhaWV2QGVwYW0uY29tPjsgSnVsaWVuDQo+IEdyYWxsIDxqdWxpZW5AeGVuLm9yZz47IEp1ZXJn ZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT47IFBhdWwgRHVycmFudA0KPiA8cGF1bEB4ZW4ub3Jn PjsgWGVuIERldmVsIDx4ZW4tZGV2ZWxAbGlzdHMueGVuLm9yZz4NCj4gU3ViamVjdDogUmU6IEVu YWJsaW5nIGh5cGVydmlzb3IgYWdub3N0aWNpc20gZm9yIFZpcnRJTyBiYWNrZW5kcw0KPiANCj4g V2VpLA0KPiANCj4gT24gVGh1LCBBdWcgMjYsIDIwMjEgYXQgMTI6MTA6MTlQTSArMDAwMCwgV2Vp IENoZW4gd3JvdGU6DQo+ID4gSGkgQWthc2hpLA0KPiA+DQo+ID4gPiAtLS0tLU9yaWdpbmFsIE1l c3NhZ2UtLS0tLQ0KPiA+ID4gRnJvbTogQUtBU0hJIFRha2FoaXJvIDx0YWthaGlyby5ha2FzaGlA bGluYXJvLm9yZz4NCj4gPiA+IFNlbnQ6IDIwMjHlubQ45pyIMjbml6UgMTc6NDENCj4gPiA+IFRv OiBXZWkgQ2hlbiA8V2VpLkNoZW5AYXJtLmNvbT4NCj4gPiA+IENjOiBPbGVrc2FuZHIgVHlzaGNo ZW5rbyA8b2xla3N0eXNoQGdtYWlsLmNvbT47IFN0ZWZhbm8gU3RhYmVsbGluaQ0KPiA+ID4gPHNz dGFiZWxsaW5pQGtlcm5lbC5vcmc+OyBBbGV4IEJlbm4/P2UgPGFsZXguYmVubmVlQGxpbmFyby5v cmc+OyBLYWx5DQo+IFhpbg0KPiA+ID4gPEthbHkuWGluQGFybS5jb20+OyBTdHJhdG9zIE1haWxp bmcgTGlzdCA8c3RyYXRvcy1kZXZAb3AtDQo+IGxpc3RzLmxpbmFyby5vcmc+Ow0KPiA+ID4gdmly dGlvLWRldkBsaXN0cy5vYXNpcy1vcGVuLm9yZzsgQXJuZCBCZXJnbWFubg0KPiA8YXJuZC5iZXJn bWFubkBsaW5hcm8ub3JnPjsNCj4gPiA+IFZpcmVzaCBLdW1hciA8dmlyZXNoLmt1bWFyQGxpbmFy by5vcmc+OyBTdGVmYW5vIFN0YWJlbGxpbmkNCj4gPiA+IDxzdGVmYW5vLnN0YWJlbGxpbmlAeGls aW54LmNvbT47IHN0ZWZhbmhhQHJlZGhhdC5jb207IEphbiBLaXN6a2ENCj4gPiA+IDxqYW4ua2lz emthQHNpZW1lbnMuY29tPjsgQ2FybCB2YW4gU2NoYWlrIDxjdmFuc2NoYUBxdGkucXVhbGNvbW0u Y29tPjsNCj4gPiA+IHByYXRpa3BAcXVpY2luYy5jb207IFNyaXZhdHNhIFZhZGRhZ2lyaSA8dmF0 c2FAY29kZWF1cm9yYS5vcmc+OyBKZWFuLQ0KPiA+ID4gUGhpbGlwcGUgQnJ1Y2tlciA8amVhbi1w aGlsaXBwZUBsaW5hcm8ub3JnPjsgTWF0aGlldSBQb2lyaWVyDQo+ID4gPiA8bWF0aGlldS5wb2ly aWVyQGxpbmFyby5vcmc+OyBPbGVrc2FuZHIgVHlzaGNoZW5rbw0KPiA+ID4gPE9sZWtzYW5kcl9U eXNoY2hlbmtvQGVwYW0uY29tPjsgQmVydHJhbmQgTWFycXVpcw0KPiA+ID4gPEJlcnRyYW5kLk1h cnF1aXNAYXJtLmNvbT47IEFydGVtIE15Z2FpZXYgPEFydGVtX015Z2FpZXZAZXBhbS5jb20+Ow0K PiBKdWxpZW4NCj4gPiA+IEdyYWxsIDxqdWxpZW5AeGVuLm9yZz47IEp1ZXJnZW4gR3Jvc3MgPGpn cm9zc0BzdXNlLmNvbT47IFBhdWwgRHVycmFudA0KPiA+ID4gPHBhdWxAeGVuLm9yZz47IFhlbiBE ZXZlbCA8eGVuLWRldmVsQGxpc3RzLnhlbi5vcmc+DQo+ID4gPiBTdWJqZWN0OiBSZTogRW5hYmxp bmcgaHlwZXJ2aXNvciBhZ25vc3RpY2lzbSBmb3IgVmlydElPIGJhY2tlbmRzDQo+ID4gPg0KPiA+ ID4gSGkgV2VpLA0KPiA+ID4NCj4gPiA+IE9uIEZyaSwgQXVnIDIwLCAyMDIxIGF0IDAzOjQxOjUw UE0gKzA5MDAsIEFLQVNISSBUYWthaGlybyB3cm90ZToNCj4gPiA+ID4gT24gV2VkLCBBdWcgMTgs IDIwMjEgYXQgMDg6MzU6NTFBTSArMDAwMCwgV2VpIENoZW4gd3JvdGU6DQo+ID4gPiA+ID4gSGkg QWthc2hp77yMDQo+ID4gPiA+ID4NCj4gPiA+ID4gPiA+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0t LS0tDQo+ID4gPiA+ID4gPiBGcm9tOiBBS0FTSEkgVGFrYWhpcm8gPHRha2FoaXJvLmFrYXNoaUBs aW5hcm8ub3JnPg0KPiA+ID4gPiA+ID4gU2VudDogMjAyMeW5tDjmnIgxOOaXpSAxMzozOQ0KPiA+ ID4gPiA+ID4gVG86IFdlaSBDaGVuIDxXZWkuQ2hlbkBhcm0uY29tPg0KPiA+ID4gPiA+ID4gQ2M6 IE9sZWtzYW5kciBUeXNoY2hlbmtvIDxvbGVrc3R5c2hAZ21haWwuY29tPjsgU3RlZmFubw0KPiBT dGFiZWxsaW5pDQo+ID4gPiA+ID4gPiA8c3N0YWJlbGxpbmlAa2VybmVsLm9yZz47IEFsZXggQmVu bj8/ZSA8YWxleC5iZW5uZWVAbGluYXJvLm9yZz47DQo+ID4gPiBTdHJhdG9zDQo+ID4gPiA+ID4g PiBNYWlsaW5nIExpc3QgPHN0cmF0b3MtZGV2QG9wLWxpc3RzLmxpbmFyby5vcmc+OyB2aXJ0aW8t DQo+ID4gPiBkZXZAbGlzdHMub2FzaXMtDQo+ID4gPiA+ID4gPiBvcGVuLm9yZzsgQXJuZCBCZXJn bWFubiA8YXJuZC5iZXJnbWFubkBsaW5hcm8ub3JnPjsgVmlyZXNoIEt1bWFyDQo+ID4gPiA+ID4g PiA8dmlyZXNoLmt1bWFyQGxpbmFyby5vcmc+OyBTdGVmYW5vIFN0YWJlbGxpbmkNCj4gPiA+ID4g PiA+IDxzdGVmYW5vLnN0YWJlbGxpbmlAeGlsaW54LmNvbT47IHN0ZWZhbmhhQHJlZGhhdC5jb207 IEphbiBLaXN6a2ENCj4gPiA+ID4gPiA+IDxqYW4ua2lzemthQHNpZW1lbnMuY29tPjsgQ2FybCB2 YW4gU2NoYWlrDQo+ID4gPiA8Y3ZhbnNjaGFAcXRpLnF1YWxjb21tLmNvbT47DQo+ID4gPiA+ID4g PiBwcmF0aWtwQHF1aWNpbmMuY29tOyBTcml2YXRzYSBWYWRkYWdpcmkgPHZhdHNhQGNvZGVhdXJv cmEub3JnPjsNCj4gPiA+IEplYW4tDQo+ID4gPiA+ID4gPiBQaGlsaXBwZSBCcnVja2VyIDxqZWFu LXBoaWxpcHBlQGxpbmFyby5vcmc+OyBNYXRoaWV1IFBvaXJpZXINCj4gPiA+ID4gPiA+IDxtYXRo aWV1LnBvaXJpZXJAbGluYXJvLm9yZz47IE9sZWtzYW5kciBUeXNoY2hlbmtvDQo+ID4gPiA+ID4g PiA8T2xla3NhbmRyX1R5c2hjaGVua29AZXBhbS5jb20+OyBCZXJ0cmFuZCBNYXJxdWlzDQo+ID4g PiA+ID4gPiA8QmVydHJhbmQuTWFycXVpc0Bhcm0uY29tPjsgQXJ0ZW0gTXlnYWlldg0KPiA8QXJ0 ZW1fTXlnYWlldkBlcGFtLmNvbT47DQo+ID4gPiBKdWxpZW4NCj4gPiA+ID4gPiA+IEdyYWxsIDxq dWxpZW5AeGVuLm9yZz47IEp1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT47IFBhdWwNCj4g PiA+IER1cnJhbnQNCj4gPiA+ID4gPiA+IDxwYXVsQHhlbi5vcmc+OyBYZW4gRGV2ZWwgPHhlbi1k ZXZlbEBsaXN0cy54ZW4ub3JnPg0KPiA+ID4gPiA+ID4gU3ViamVjdDogUmU6IEVuYWJsaW5nIGh5 cGVydmlzb3IgYWdub3N0aWNpc20gZm9yIFZpcnRJTyBiYWNrZW5kcw0KPiA+ID4gPiA+ID4NCj4g PiA+ID4gPiA+IE9uIFR1ZSwgQXVnIDE3LCAyMDIxIGF0IDA4OjM5OjA5QU0gKzAwMDAsIFdlaSBD aGVuIHdyb3RlOg0KPiA+ID4gPiA+ID4gPiBIaSBBa2FzaGksDQo+ID4gPiA+ID4gPiA+DQo+ID4g PiA+ID4gPiA+ID4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gPiA+ID4gPiA+ID4gPiBG cm9tOiBBS0FTSEkgVGFrYWhpcm8gPHRha2FoaXJvLmFrYXNoaUBsaW5hcm8ub3JnPg0KPiA+ID4g PiA+ID4gPiA+IFNlbnQ6IDIwMjHlubQ45pyIMTfml6UgMTY6MDgNCj4gPiA+ID4gPiA+ID4gPiBU bzogV2VpIENoZW4gPFdlaS5DaGVuQGFybS5jb20+DQo+ID4gPiA+ID4gPiA+ID4gQ2M6IE9sZWtz YW5kciBUeXNoY2hlbmtvIDxvbGVrc3R5c2hAZ21haWwuY29tPjsgU3RlZmFubw0KPiA+ID4gU3Rh YmVsbGluaQ0KPiA+ID4gPiA+ID4gPiA+IDxzc3RhYmVsbGluaUBrZXJuZWwub3JnPjsgQWxleCBC ZW5uPz9lDQo+IDxhbGV4LmJlbm5lZUBsaW5hcm8ub3JnPjsNCj4gPiA+ID4gPiA+IFN0cmF0b3MN Cj4gPiA+ID4gPiA+ID4gPiBNYWlsaW5nIExpc3QgPHN0cmF0b3MtZGV2QG9wLWxpc3RzLmxpbmFy by5vcmc+OyB2aXJ0aW8tDQo+ID4gPiA+ID4gPiBkZXZAbGlzdHMub2FzaXMtDQo+ID4gPiA+ID4g PiA+ID4gb3Blbi5vcmc7IEFybmQgQmVyZ21hbm4gPGFybmQuYmVyZ21hbm5AbGluYXJvLm9yZz47 IFZpcmVzaA0KPiBLdW1hcg0KPiA+ID4gPiA+ID4gPiA+IDx2aXJlc2gua3VtYXJAbGluYXJvLm9y Zz47IFN0ZWZhbm8gU3RhYmVsbGluaQ0KPiA+ID4gPiA+ID4gPiA+IDxzdGVmYW5vLnN0YWJlbGxp bmlAeGlsaW54LmNvbT47IHN0ZWZhbmhhQHJlZGhhdC5jb207IEphbg0KPiBLaXN6a2ENCj4gPiA+ ID4gPiA+ID4gPiA8amFuLmtpc3prYUBzaWVtZW5zLmNvbT47IENhcmwgdmFuIFNjaGFpaw0KPiA+ ID4gPGN2YW5zY2hhQHF0aS5xdWFsY29tbS5jb20+Ow0KPiA+ID4gPiA+ID4gPiA+IHByYXRpa3BA cXVpY2luYy5jb207IFNyaXZhdHNhIFZhZGRhZ2lyaQ0KPiA8dmF0c2FAY29kZWF1cm9yYS5vcmc+ Ow0KPiA+ID4gSmVhbi0NCj4gPiA+ID4gPiA+ID4gPiBQaGlsaXBwZSBCcnVja2VyIDxqZWFuLXBo aWxpcHBlQGxpbmFyby5vcmc+OyBNYXRoaWV1IFBvaXJpZXINCj4gPiA+ID4gPiA+ID4gPiA8bWF0 aGlldS5wb2lyaWVyQGxpbmFyby5vcmc+OyBPbGVrc2FuZHIgVHlzaGNoZW5rbw0KPiA+ID4gPiA+ ID4gPiA+IDxPbGVrc2FuZHJfVHlzaGNoZW5rb0BlcGFtLmNvbT47IEJlcnRyYW5kIE1hcnF1aXMN Cj4gPiA+ID4gPiA+ID4gPiA8QmVydHJhbmQuTWFycXVpc0Bhcm0uY29tPjsgQXJ0ZW0gTXlnYWll dg0KPiA+ID4gPEFydGVtX015Z2FpZXZAZXBhbS5jb20+Ow0KPiA+ID4gPiA+ID4gSnVsaWVuDQo+ ID4gPiA+ID4gPiA+ID4gR3JhbGwgPGp1bGllbkB4ZW4ub3JnPjsgSnVlcmdlbiBHcm9zcyA8amdy b3NzQHN1c2UuY29tPjsNCj4gUGF1bA0KPiA+ID4gRHVycmFudA0KPiA+ID4gPiA+ID4gPiA+IDxw YXVsQHhlbi5vcmc+OyBYZW4gRGV2ZWwgPHhlbi1kZXZlbEBsaXN0cy54ZW4ub3JnPg0KPiA+ID4g PiA+ID4gPiA+IFN1YmplY3Q6IFJlOiBFbmFibGluZyBoeXBlcnZpc29yIGFnbm9zdGljaXNtIGZv ciBWaXJ0SU8NCj4gYmFja2VuZHMNCj4gPiA+ID4gPiA+ID4gPg0KPiA+ID4gPiA+ID4gPiA+IEhp IFdlaSwgT2xla3NhbmRyLA0KPiA+ID4gPiA+ID4gPiA+DQo+ID4gPiA+ID4gPiA+ID4gT24gTW9u LCBBdWcgMTYsIDIwMjEgYXQgMTA6MDQ6MDNBTSArMDAwMCwgV2VpIENoZW4gd3JvdGU6DQo+ID4g PiA+ID4gPiA+ID4gPiBIaSBBbGwsDQo+ID4gPiA+ID4gPiA+ID4gPg0KPiA+ID4gPiA+ID4gPiA+ ID4gVGhhbmtzIGZvciBTdGVmYW5vIHRvIGxpbmsgbXkga3ZtdG9vbCBmb3IgWGVuIHByb3Bvc2Fs DQo+IGhlcmUuDQo+ID4gPiA+ID4gPiA+ID4gPiBUaGlzIHByb3Bvc2FsIGlzIHN0aWxsIGRpc2N1 c3NpbmcgaW4gWGVuIGFuZCBLVk0NCj4gY29tbXVuaXRpZXMuDQo+ID4gPiA+ID4gPiA+ID4gPiBU aGUgbWFpbiB3b3JrIGlzIHRvIGRlY291cGxlIHRoZSBrdm10b29sIGZyb20gS1ZNIGFuZCBtYWtl DQo+ID4gPiA+ID4gPiA+ID4gPiBvdGhlciBoeXBlcnZpc29ycyBjYW4gcmV1c2UgdGhlIHZpcnR1 YWwgZGV2aWNlDQo+IGltcGxlbWVudGF0aW9ucy4NCj4gPiA+ID4gPiA+ID4gPiA+DQo+ID4gPiA+ ID4gPiA+ID4gPiBJbiB0aGlzIGNhc2UsIHdlIG5lZWQgdG8gaW50cm9kdWNlIGFuIGludGVybWVk aWF0ZQ0KPiBoeXBlcnZpc29yDQo+ID4gPiA+ID4gPiA+ID4gPiBsYXllciBmb3IgVk1NIGFic3Ry YWN0aW9uLCBXaGljaCBpcywgSSB0aGluayBpdCdzIHZlcnkNCj4gY2xvc2UNCj4gPiA+ID4gPiA+ ID4gPiA+IHRvIHN0cmF0b3MnIHZpcnRpbyBoeXBlcnZpc29yIGFnbm9zdGljaXNtIHdvcmsuDQo+ ID4gPiA+ID4gPiA+ID4NCj4gPiA+ID4gPiA+ID4gPiAjIE15IHByb3Bvc2FsWzFdIGNvbWVzIGZy b20gbXkgb3duIGlkZWEgYW5kIGRvZXNuJ3QgYWx3YXlzDQo+ID4gPiByZXByZXNlbnQNCj4gPiA+ ID4gPiA+ID4gPiAjIExpbmFybydzIHZpZXcgb24gdGhpcyBzdWJqZWN0IG5vciByZWZsZWN0IEFs ZXgncyBjb25jZXJucy4NCj4gPiA+ID4gPiA+IE5ldmVydGhlbGVzcywNCj4gPiA+ID4gPiA+ID4g Pg0KPiA+ID4gPiA+ID4gPiA+IFlvdXIgaWRlYSBhbmQgbXkgcHJvcG9zYWwgc2VlbSB0byBzaGFy ZSB0aGUgc2FtZSBiYWNrZ3JvdW5kLg0KPiA+ID4gPiA+ID4gPiA+IEJvdGggaGF2ZSB0aGUgc2lt aWxhciBnb2FsIGFuZCBjdXJyZW50bHkgc3RhcnQgd2l0aCwgYXQNCj4gZmlyc3QsDQo+ID4gPiBY ZW4NCj4gPiA+ID4gPiA+ID4gPiBhbmQgYXJlIGJhc2VkIG9uIGt2bS10b29sLiAoQWN0dWFsbHks IG15IHdvcmsgaXMgZGVyaXZlZA0KPiBmcm9tDQo+ID4gPiA+ID4gPiA+ID4gRVBBTSdzIHZpcnRp by1kaXNrLCB3aGljaCBpcyBhbHNvIGJhc2VkIG9uIGt2bS10b29sLikNCj4gPiA+ID4gPiA+ID4g Pg0KPiA+ID4gPiA+ID4gPiA+IEluIHBhcnRpY3VsYXIsIHRoZSBhYnN0cmFjdGlvbiBvZiBoeXBl cnZpc29yIGludGVyZmFjZXMgaGFzDQo+IGENCj4gPiA+IHNhbWUNCj4gPiA+ID4gPiA+ID4gPiBz ZXQgb2YgaW50ZXJmYWNlcyAoZm9yIHlvdXIgInN0cnVjdCB2bW1faW1wbCIgYW5kIG15ICJSUEMN Cj4gPiA+IGludGVyZmFjZXMiKS4NCj4gPiA+ID4gPiA+ID4gPiBUaGlzIGlzIG5vdCBjby1pbmNp ZGVudCBhcyB3ZSBib3RoIHNoYXJlIHRoZSBzYW1lIG9yaWdpbiBhcw0KPiBJDQo+ID4gPiBzYWlk DQo+ID4gPiA+ID4gPiBhYm92ZS4NCj4gPiA+ID4gPiA+ID4gPiBBbmQgc28gd2Ugd2lsbCBhbHNv IHNoYXJlIHRoZSBzYW1lIGlzc3Vlcy4gT25lIG9mIHRoZW0gaXMgYQ0KPiB3YXkNCj4gPiA+IG9m DQo+ID4gPiA+ID4gPiA+ID4gInNoYXJpbmcvbWFwcGluZyBGRSdzIG1lbW9yeSIuIFRoZXJlIGlz IHNvbWUgdHJhZGUtb2ZmDQo+IGJldHdlZW4NCj4gPiA+ID4gPiA+ID4gPiB0aGUgcG9ydGFiaWxp dHkgYW5kIHRoZSBwZXJmb3JtYW5jZSBpbXBhY3QuDQo+ID4gPiA+ID4gPiA+ID4gU28gd2UgY2Fu IGRpc2N1c3MgdGhlIHRvcGljIGhlcmUgaW4gdGhpcyBNTCwgdG9vLg0KPiA+ID4gPiA+ID4gPiA+ IChTZWUgQWxleCdzIG9yaWdpbmFsIGVtYWlsLCB0b28pLg0KPiA+ID4gPiA+ID4gPiA+DQo+ID4g PiA+ID4gPiA+IFllcywgSSBhZ3JlZS4NCj4gPiA+ID4gPiA+ID4NCj4gPiA+ID4gPiA+ID4gPiBP biB0aGUgb3RoZXIgaGFuZCwgbXkgYXBwcm9hY2ggYWltcyB0byBjcmVhdGUgYSAic2luZ2xlLQ0K PiBiaW5hcnkiDQo+ID4gPiA+ID4gPiBzb2x1dGlvbg0KPiA+ID4gPiA+ID4gPiA+IGluIHdoaWNo IHRoZSBzYW1lIGJpbmFyeSBvZiBCRSB2bSBjb3VsZCBydW4gb24gYW55DQo+IGh5cGVydmlzb3Jz Lg0KPiA+ID4gPiA+ID4gPiA+IFNvbWVob3cgc2ltaWxhciB0byB5b3VyICJwcm9wb3NhbC0jMiIg aW4gWzJdLCBidXQgaW4gbXkNCj4gc29sdXRpb24sDQo+ID4gPiBhbGwNCj4gPiA+ID4gPiA+ID4g PiB0aGUgaHlwZXJ2aXNvci1zcGVjaWZpYyBjb2RlIHdvdWxkIGJlIHB1dCBpbnRvIGFub3RoZXIN Cj4gZW50aXR5DQo+ID4gPiAoVk0pLA0KPiA+ID4gPiA+ID4gPiA+IG5hbWVkICJ2aXJ0aW8tcHJv eHkiIGFuZCB0aGUgYWJzdHJhY3RlZCBvcGVyYXRpb25zIGFyZQ0KPiBzZXJ2ZWQNCj4gPiA+IHZp YSBSUEMuDQo+ID4gPiA+ID4gPiA+ID4gKEluIHRoaXMgc2Vuc2UsIEJFIGlzIGh5cGVydmlzb3It YWdub3N0aWMgYnV0IG1pZ2h0IGhhdmUgT1MNCj4gPiA+ID4gPiA+IGRlcGVuZGVuY3kuKQ0KPiA+ ID4gPiA+ID4gPiA+IEJ1dCBJIGtub3cgdGhhdCB3ZSBuZWVkIGRpc2N1c3MgaWYgdGhpcyBpcyBh IHJlcXVpcmVtZW50DQo+IGV2ZW4NCj4gPiA+ID4gPiA+ID4gPiBpbiBTdHJhdG9zIHByb2plY3Qg b3Igbm90LiAoTWF5YmUgbm90KQ0KPiA+ID4gPiA+ID4gPiA+DQo+ID4gPiA+ID4gPiA+DQo+ID4g PiA+ID4gPiA+IFNvcnJ5LCBJIGhhdmVuJ3QgaGFkIHRpbWUgdG8gZmluaXNoIHJlYWRpbmcgeW91 ciB2aXJ0aW8tcHJveHkNCj4gPiA+IGNvbXBsZXRlbHkNCj4gPiA+ID4gPiA+ID4gKEkgd2lsbCBk byBpdCBBU0FQKS4gQnV0IGZyb20geW91ciBkZXNjcmlwdGlvbiwgaXQgc2VlbXMgd2UNCj4gbmVl ZCBhDQo+ID4gPiA+ID4gPiA+IDNyZCBWTSBiZXR3ZWVuIEZFIGFuZCBCRT8gTXkgY29uY2VybiBp cyB0aGF0LCBpZiBteSBhc3N1bXB0aW9uDQo+IGlzDQo+ID4gPiByaWdodCwNCj4gPiA+ID4gPiA+ ID4gd2lsbCBpdCBpbmNyZWFzZSB0aGUgbGF0ZW5jeSBpbiBkYXRhIHRyYW5zcG9ydCBwYXRoPyBF dmVuIGlmDQo+IHdlJ3JlDQo+ID4gPiA+ID4gPiA+IHVzaW5nIHNvbWUgbGlnaHR3ZWlnaHQgZ3Vl c3QgbGlrZSBSVE9TIG9yIFVuaWtlcm5lbCwNCj4gPiA+ID4gPiA+DQo+ID4gPiA+ID4gPiBZZXMs IHlvdSdyZSByaWdodC4gQnV0IEknbSBhZnJhaWQgdGhhdCBpdCBpcyBhIG1hdHRlciBvZiBkZWdy ZWUuDQo+ID4gPiA+ID4gPiBBcyBmYXIgYXMgd2UgZXhlY3V0ZSAnbWFwcGluZycgb3BlcmF0aW9u cyBhdCBldmVyeSBmZXRjaCBvZg0KPiBwYXlsb2FkLA0KPiA+ID4gPiA+ID4gd2Ugd2lsbCBzZWUg bGF0ZW5jeSBpc3N1ZSAoZXZlbiBpbiB5b3VyIGNhc2UpIGFuZCBpZiB3ZSBoYXZlDQo+IHNvbWUN Cj4gPiA+IHNvbHV0aW9uDQo+ID4gPiA+ID4gPiBmb3IgaXQsIHdlIHdvbid0IHNlZSBpdCBuZWl0 aGVyIGluIG15IHByb3Bvc2FsIDopDQo+ID4gPiA+ID4gPg0KPiA+ID4gPiA+DQo+ID4gPiA+ID4g T2xla3NhbmRyIGhhcyBzZW50IGEgcHJvcG9zYWwgdG8gWGVuIG1haWxpbmcgbGlzdCB0byByZWR1 Y2UgdGhpcw0KPiBraW5kDQo+ID4gPiA+ID4gb2YgIm1hcHBpbmcvdW5tYXBwaW5nIiBvcGVyYXRp b25zLiBTbyB0aGUgbGF0ZW5jeSBjYXVzZWQgYnkgdGhpcw0KPiA+ID4gYmVoYXZpb3INCj4gPiA+ ID4gPiBvbiBYZW4gbWF5IGV2ZW50dWFsbHkgYmUgZWxpbWluYXRlZCwgYW5kIExpbnV4LUtWTSBk b2Vzbid0IGhhdmUNCj4gdGhhdA0KPiA+ID4gcHJvYmxlbS4NCj4gPiA+ID4NCj4gPiA+ID4gT2J2 aW91c2x5LCBJIGhhdmUgbm90IHlldCBjYXVnaHQgdXAgdGhlcmUgaW4gdGhlIGRpc2N1c3Npb24u DQo+ID4gPiA+IFdoaWNoIHBhdGNoIHNwZWNpZmljYWxseT8NCj4gPiA+DQo+ID4gPiBDYW4geW91 IGdpdmUgbWUgdGhlIGxpbmsgdG8gdGhlIGRpc2N1c3Npb24gb3IgcGF0Y2gsIHBsZWFzZT8NCj4g PiA+DQo+ID4NCj4gPiBJdCdzIGEgUkZDIGRpc2N1c3Npb24uIFdlIGhhdmUgdGVzdGVkIHRoaXMg UkZDIHBhdGNoIGludGVybmFsbHkuDQo+ID4gaHR0cHM6Ly9saXN0cy54ZW5wcm9qZWN0Lm9yZy9h cmNoaXZlcy9odG1sL3hlbi1kZXZlbC8yMDIxLQ0KPiAwNy9tc2cwMTUzMi5odG1sDQo+IA0KPiBJ J20gYWZyYWlkIHRoYXQgSSBtaXNzIHNvbWV0aGluZyBoZXJlLCBidXQgSSBkb24ndCBrbm93DQo+ IHdoeSB0aGlzIHByb3Bvc2VkIEFQSSB3aWxsIGxlYWQgdG8gZWxpbWluYXRpbmcgJ21tYXAnIGlu IGFjY2Vzc2luZw0KPiB0aGUgcXVldWVkIHBheWxvYWQgYXQgZXZlcnkgcmVxdWVzdD8NCj4gDQoN ClRoaXMgQVBJIGdpdmUgWGVuIGRldmljZSBtb2RlbCAoUUVNVSBvciBrdm10b29sKSB0aGUgYWJp bGl0eSB0byBtYXANCndob2xlIGd1ZXN0IFJBTSBpbiBkZXZpY2UgbW9kZWwncyBhZGRyZXNzIHNw YWNlLiBJbiB0aGlzIGNhc2UsIGRldmljZQ0KbW9kZWwgZG9lc24ndCBuZWVkIGR5bmFtaWMgaHlw ZXJjYWxsIHRvIG1hcC91bm1hcCBwYXlsb2FkIG1lbW9yeS4NCkl0IGNhbiB1c2UgYSBmbGF0IG9m ZnNldCB0byBhY2Nlc3MgcGF5bG9hZCBtZW1vcnkgaW4gaXRzIGFkZHJlc3MNCnNwYWNlIGRpcmVj dGx5LiBKdXN0IExpa2UgS1ZNIGRldmljZSBtb2RlbCBkb2VzIG5vdy4NCg0KQmVmb3JlIHRoaXMg QVBJLCBXaGVuIGRldmljZSBtb2RlbCB0byBtYXAgd2hvbGUgZ3Vlc3QgbWVtb3J5LCB3aWxsDQpz ZXZlcmVseSBjb25zdW1lIHRoZSBwaHlzaWNhbCBwYWdlcyBvZiBEb20tMC9Eb20tRC4NCg0KPiAt VGFrYWhpcm8gQWthc2hpDQo+IA0KPiANCj4gPiA+IFRoYW5rcywNCj4gPiA+IC1UYWthaGlybyBB a2FzaGkNCj4gPiA+DQo+ID4gPiA+IC1UYWthaGlybyBBa2FzaGkNCj4gPiA+ID4NCj4gPiA+ID4g PiA+ID4gPiBTcGVjaWZpY2FsbHkgc3BlYWtpbmcgYWJvdXQga3ZtLXRvb2wsIEkgaGF2ZSBhIGNv bmNlcm4gYWJvdXQNCj4gaXRzDQo+ID4gPiA+ID4gPiA+ID4gbGljZW5zZSB0ZXJtOyBUYXJnZXRp bmcgZGlmZmVyZW50IGh5cGVydmlzb3JzIGFuZCBkaWZmZXJlbnQNCj4gT1NzDQo+ID4gPiA+ID4g PiA+ID4gKHdoaWNoIEkgYXNzdW1lIGluY2x1ZGVzIFJUT1MncyksIHRoZSByZXN1bHRhbnQgbGli cmFyeQ0KPiBzaG91bGQNCj4gPiA+IGJlDQo+ID4gPiA+ID4gPiA+ID4gbGljZW5zZSBwZXJtaXNz aXZlIGFuZCBHUEwgZm9yIGt2bS10b29sIG1pZ2h0IGJlIGFuIGlzc3VlLg0KPiA+ID4gPiA+ID4g PiA+IEFueSB0aG91Z2h0cz8NCj4gPiA+ID4gPiA+ID4gPg0KPiA+ID4gPiA+ID4gPg0KPiA+ID4g PiA+ID4gPiBZZXMuIElmIHVzZXIgd2FudCB0byBpbXBsZW1lbnQgYSBGcmVlQlNEIGRldmljZSBt b2RlbCwgYnV0IHRoZQ0KPiA+ID4gdmlydGlvDQo+ID4gPiA+ID4gPiA+IGxpYnJhcnkgaXMgR1BM LiBUaGVuIEdQTCB3b3VsZCBiZSBhIHByb2JsZW0uIElmIHdlIGhhdmUNCj4gYW5vdGhlcg0KPiA+ ID4gZ29vZA0KPiA+ID4gPiA+ID4gPiBjYW5kaWRhdGUsIEkgYW0gb3BlbiB0byBpdC4NCj4gPiA+ ID4gPiA+DQo+ID4gPiA+ID4gPiBJIGhhdmUgc29tZSBjYW5kaWRhdGVzLCBwYXJ0aWN1bGFybHkg Zm9yIHZxL3ZyaW5nLCBpbiBteSBtaW5kOg0KPiA+ID4gPiA+ID4gKiBPcGVuLUFNUCwgb3INCj4g PiA+ID4gPiA+ICogY29ycmVzcG9uZGluZyBGcmVlLUJTRCBjb2RlDQo+ID4gPiA+ID4gPg0KPiA+ ID4gPiA+DQo+ID4gPiA+ID4gSW50ZXJlc3RpbmcsIEkgd2lsbCBsb29rIGludG8gdGhlbSA6ICkN Cj4gPiA+ID4gPg0KPiA+ID4gPiA+IENoZWVycywNCj4gPiA+ID4gPiBXZWkgQ2hlbg0KPiA+ID4g PiA+DQo+ID4gPiA+ID4gPiAtVGFrYWhpcm8gQWthc2hpDQo+ID4gPiA+ID4gPg0KPiA+ID4gPiA+ ID4NCj4gPiA+ID4gPiA+ID4gPiAtVGFrYWhpcm8gQWthc2hpDQo+ID4gPiA+ID4gPiA+ID4NCj4g PiA+ID4gPiA+ID4gPg0KPiA+ID4gPiA+ID4gPiA+IFsxXSBodHRwczovL29wLWxpc3RzLmxpbmFy by5vcmcvcGlwZXJtYWlsL3N0cmF0b3MtZGV2LzIwMjEtDQo+ID4gPiA+ID4gPiA+ID4gQXVndXN0 LzAwMDU0OC5odG1sDQo+ID4gPiA+ID4gPiA+ID4gWzJdIGh0dHBzOi8vbWFyYy5pbmZvLz9sPXhl bi1kZXZlbCZtPTE2MjM3Mzc1NDcwNTIzMyZ3PTINCj4gPiA+ID4gPiA+ID4gPg0KPiA+ID4gPiA+ ID4gPiA+ID4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gRnJvbTogT2xla3NhbmRyIFR5c2hjaGVua28g PG9sZWtzdHlzaEBnbWFpbC5jb20+DQo+ID4gPiA+ID4gPiA+ID4gPiA+IFNlbnQ6IDIwMjHlubQ4 5pyIMTTml6UgMjM6MzgNCj4gPiA+ID4gPiA+ID4gPiA+ID4gVG86IEFLQVNISSBUYWthaGlybyA8 dGFrYWhpcm8uYWthc2hpQGxpbmFyby5vcmc+Ow0KPiBTdGVmYW5vDQo+ID4gPiA+ID4gPiBTdGFi ZWxsaW5pDQo+ID4gPiA+ID4gPiA+ID4gPHNzdGFiZWxsaW5pQGtlcm5lbC5vcmc+DQo+ID4gPiA+ ID4gPiA+ID4gPiA+IENjOiBBbGV4IEJlbm4/P2UgPGFsZXguYmVubmVlQGxpbmFyby5vcmc+OyBT dHJhdG9zDQo+IE1haWxpbmcNCj4gPiA+IExpc3QNCj4gPiA+ID4gPiA+ID4gPiA8c3RyYXRvcy1k ZXZAb3AtbGlzdHMubGluYXJvLm9yZz47IHZpcnRpby1kZXZAbGlzdHMub2FzaXMtDQo+ID4gPiBv cGVuLm9yZzsNCj4gPiA+ID4gPiA+IEFybmQNCj4gPiA+ID4gPiA+ID4gPiBCZXJnbWFubiA8YXJu ZC5iZXJnbWFubkBsaW5hcm8ub3JnPjsgVmlyZXNoIEt1bWFyDQo+ID4gPiA+ID4gPiA+ID4gPHZp cmVzaC5rdW1hckBsaW5hcm8ub3JnPjsgU3RlZmFubyBTdGFiZWxsaW5pDQo+ID4gPiA+ID4gPiA+ ID4gPHN0ZWZhbm8uc3RhYmVsbGluaUB4aWxpbnguY29tPjsgc3RlZmFuaGFAcmVkaGF0LmNvbTsg SmFuDQo+IEtpc3prYQ0KPiA+ID4gPiA+ID4gPiA+IDxqYW4ua2lzemthQHNpZW1lbnMuY29tPjsg Q2FybCB2YW4gU2NoYWlrDQo+ID4gPiA8Y3ZhbnNjaGFAcXRpLnF1YWxjb21tLmNvbT47DQo+ID4g PiA+ID4gPiA+ID4gcHJhdGlrcEBxdWljaW5jLmNvbTsgU3JpdmF0c2EgVmFkZGFnaXJpDQo+IDx2 YXRzYUBjb2RlYXVyb3JhLm9yZz47DQo+ID4gPiBKZWFuLQ0KPiA+ID4gPiA+ID4gPiA+IFBoaWxp cHBlIEJydWNrZXIgPGplYW4tcGhpbGlwcGVAbGluYXJvLm9yZz47IE1hdGhpZXUgUG9pcmllcg0K PiA+ID4gPiA+ID4gPiA+IDxtYXRoaWV1LnBvaXJpZXJAbGluYXJvLm9yZz47IFdlaSBDaGVuIDxX ZWkuQ2hlbkBhcm0uY29tPjsNCj4gPiA+IE9sZWtzYW5kcg0KPiA+ID4gPiA+ID4gPiA+IFR5c2hj aGVua28gPE9sZWtzYW5kcl9UeXNoY2hlbmtvQGVwYW0uY29tPjsgQmVydHJhbmQgTWFycXVpcw0K PiA+ID4gPiA+ID4gPiA+IDxCZXJ0cmFuZC5NYXJxdWlzQGFybS5jb20+OyBBcnRlbSBNeWdhaWV2 DQo+ID4gPiA8QXJ0ZW1fTXlnYWlldkBlcGFtLmNvbT47DQo+ID4gPiA+ID4gPiBKdWxpZW4NCj4g PiA+ID4gPiA+ID4gPiBHcmFsbCA8anVsaWVuQHhlbi5vcmc+OyBKdWVyZ2VuIEdyb3NzIDxqZ3Jv c3NAc3VzZS5jb20+Ow0KPiBQYXVsDQo+ID4gPiBEdXJyYW50DQo+ID4gPiA+ID4gPiA+ID4gPHBh dWxAeGVuLm9yZz47IFhlbiBEZXZlbCA8eGVuLWRldmVsQGxpc3RzLnhlbi5vcmc+DQo+ID4gPiA+ ID4gPiA+ID4gPiA+IFN1YmplY3Q6IFJlOiBFbmFibGluZyBoeXBlcnZpc29yIGFnbm9zdGljaXNt IGZvciBWaXJ0SU8NCj4gPiA+IGJhY2tlbmRzDQo+ID4gPiA+ID4gPiA+ID4gPiA+DQo+ID4gPiA+ ID4gPiA+ID4gPiA+IEhlbGxvLCBhbGwuDQo+ID4gPiA+ID4gPiA+ID4gPiA+DQo+ID4gPiA+ID4g PiA+ID4gPiA+IFBsZWFzZSBzZWUgc29tZSBjb21tZW50cyBiZWxvdy4gQW5kIHNvcnJ5IGZvciB0 aGUNCj4gcG9zc2libGUNCj4gPiA+IGZvcm1hdA0KPiA+ID4gPiA+ID4gPiA+IGlzc3Vlcy4NCj4g PiA+ID4gPiA+ID4gPiA+ID4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiBPbiBXZWQsIEF1ZyAxMSwg MjAyMSBhdCA5OjI3IEFNIEFLQVNISSBUYWthaGlybw0KPiA+ID4gPiA+ID4gPiA+IDxtYWlsdG86 dGFrYWhpcm8uYWthc2hpQGxpbmFyby5vcmc+IHdyb3RlOg0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ IE9uIFdlZCwgQXVnIDA0LCAyMDIxIGF0IDEyOjIwOjAxUE0gLTA3MDAsIFN0ZWZhbm8NCj4gPiA+ IFN0YWJlbGxpbmkNCj4gPiA+ID4gPiA+IHdyb3RlOg0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4g Q0NpbmcgcGVvcGxlIHdvcmtpbmcgb24gWGVuK1ZpcnRJTyBhbmQgSU9SRVFzLiBOb3QNCj4gPiA+ IHRyaW1taW5nDQo+ID4gPiA+ID4gPiB0aGUNCj4gPiA+ID4gPiA+ID4gPiBvcmlnaW5hbA0KPiA+ ID4gPiA+ID4gPiA+ID4gPiA+ID4gZW1haWwgdG8gbGV0IHRoZW0gcmVhZCB0aGUgZnVsbCBjb250 ZXh0Lg0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+IE15 IGNvbW1lbnRzIGJlbG93IGFyZSByZWxhdGVkIHRvIGEgcG90ZW50aWFsIFhlbg0KPiA+ID4gPiA+ ID4gaW1wbGVtZW50YXRpb24sDQo+ID4gPiA+ID4gPiA+ID4gbm90DQo+ID4gPiA+ID4gPiA+ID4g PiA+ID4gPiBiZWNhdXNlIGl0IGlzIHRoZSBvbmx5IGltcGxlbWVudGF0aW9uIHRoYXQgbWF0dGVy cywNCj4gYnV0DQo+ID4gPiA+ID4gPiBiZWNhdXNlIGl0DQo+ID4gPiA+ID4gPiA+ID4gaXMNCj4g PiA+ID4gPiA+ID4gPiA+ID4gPiA+IHRoZSBvbmUgSSBrbm93IGJlc3QuDQo+ID4gPiA+ID4gPiA+ ID4gPiA+ID4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiBQbGVhc2Ugbm90ZSB0aGF0IG15IHByb3Bv c2FsIChhbmQgaGVuY2UgdGhlIHdvcmtpbmcNCj4gPiA+IHByb3RvdHlwZSlbMV0NCj4gPiA+ID4g PiA+ID4gPiA+ID4gPiBpcyBiYXNlZCBvbiBYZW4ncyB2aXJ0aW8gaW1wbGVtZW50YXRpb24gKGku ZS4gSU9SRVEpDQo+IGFuZA0KPiA+ID4gPiA+ID4gPiA+IHBhcnRpY3VsYXJseQ0KPiA+ID4gPiA+ ID4gPiA+ID4gPiA+IEVQQU0ncyB2aXJ0aW8tZGlzayBhcHBsaWNhdGlvbiAoYmFja2VuZCBzZXJ2 ZXIpLg0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+IEl0IGhhcyBiZWVuLCBJIGJlbGlldmUsIHdlbGwg Z2VuZXJhbGl6ZWQgYnV0IGlzIHN0aWxsDQo+IGENCj4gPiA+IGJpdA0KPiA+ID4gPiA+ID4gYmlh c2VkDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gdG93YXJkIHRoaXMgb3JpZ2luYWwgZGVzaWduLg0K PiA+ID4gPiA+ID4gPiA+ID4gPiA+DQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gU28gSSBob3BlIHlv dSBsaWtlIG15IGFwcHJvYWNoIDopDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4NCj4gPiA+ID4gPiA+ ID4gPiA+ID4gPiBbMV0gaHR0cHM6Ly9vcC1saXN0cy5saW5hcm8ub3JnL3BpcGVybWFpbC9zdHJh dG9zLQ0KPiA+ID4gZGV2LzIwMjEtDQo+ID4gPiA+ID4gPiA+ID4gQXVndXN0LzAwMDU0Ni5odG1s DQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiBMZXQgbWUgdGFr ZSB0aGlzIG9wcG9ydHVuaXR5IHRvIGV4cGxhaW4gYSBiaXQgbW9yZQ0KPiBhYm91dA0KPiA+ID4g bXkNCj4gPiA+ID4gPiA+IGFwcHJvYWNoDQo+ID4gPiA+ID4gPiA+ID4gYmVsb3cuDQo+ID4gPiA+ ID4gPiA+ID4gPiA+ID4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+IEFsc28sIHBsZWFzZSBzZWUg dGhpcyByZWxldmFudCBlbWFpbCB0aHJlYWQ6DQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiBodHRw czovL21hcmMuaW5mby8/bD14ZW4tZGV2ZWwmbT0xNjIzNzM3NTQ3MDUyMzMmdz0yDQo+ID4gPiA+ ID4gPiA+ID4gPiA+ID4gPg0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4NCj4gPiA+ID4gPiA+ID4g PiA+ID4gPiA+IE9uIFdlZCwgNCBBdWcgMjAyMSwgQWxleCBCZW5uw6llIHdyb3RlOg0KPiA+ID4g PiA+ID4gPiA+ID4gPiA+ID4gPiBIaSwNCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4NCj4gPiA+ ID4gPiA+ID4gPiA+ID4gPiA+ID4gT25lIG9mIHRoZSBnb2FscyBvZiBQcm9qZWN0IFN0cmF0b3Mg aXMgdG8gZW5hYmxlDQo+ID4gPiBoeXBlcnZpc29yDQo+ID4gPiA+ID4gPiA+ID4gYWdub3N0aWMN Cj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gYmFja2VuZHMgc28gd2UgY2FuIGVuYWJsZSBhcyBt dWNoIHJlLXVzZSBvZiBjb2RlDQo+IGFzDQo+ID4gPiBwb3NzaWJsZQ0KPiA+ID4gPiA+ID4gYW5k DQo+ID4gPiA+ID4gPiA+ID4gYXZvaWQNCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gcmVwZWF0 aW5nIG91cnNlbHZlcy4gVGhpcyBpcyB0aGUgZmxpcCBzaWRlIG9mIHRoZQ0KPiA+ID4gZnJvbnQg ZW5kDQo+ID4gPiA+ID4gPiA+ID4gd2hlcmUNCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gbXVs dGlwbGUgZnJvbnQtZW5kIGltcGxlbWVudGF0aW9ucyBhcmUgcmVxdWlyZWQgLQ0KPiBvbmUNCj4g PiA+IHBlciBPUywNCj4gPiA+ID4gPiA+ID4gPiBhc3N1bWluZw0KPiA+ID4gPiA+ID4gPiA+ID4g PiA+ID4gPiB5b3UgZG9uJ3QganVzdCB3YW50IExpbnV4IGd1ZXN0cy4gVGhlIHJlc3VsdGFudA0K PiBndWVzdHMNCj4gPiA+IGFyZQ0KPiA+ID4gPiA+ID4gPiA+IHRyaXZpYWxseQ0KPiA+ID4gPiA+ ID4gPiA+ID4gPiA+ID4gPiBtb3ZhYmxlIGJldHdlZW4gaHlwZXJ2aXNvcnMgbW9kdWxvIGFueSBh YnN0cmFjdGVkDQo+ID4gPiBwYXJhdmlydA0KPiA+ID4gPiA+ID4gdHlwZQ0KPiA+ID4gPiA+ID4g PiA+ID4gPiA+ID4gPiBpbnRlcmZhY2VzLg0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPg0KPiA+ ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiBJbiBteSBvcmlnaW5hbCB0aHVtYiBuYWlsIHNrZXRjaCBv ZiBhIHNvbHV0aW9uIEkNCj4gPiA+IGVudmlzaW9uZWQNCj4gPiA+ID4gPiA+ID4gPiB2aG9zdC11 c2VyDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+IGRhZW1vbnMgcnVubmluZyBpbiBhIGJyb2Fk bHkgUE9TSVggbGlrZQ0KPiBlbnZpcm9ubWVudC4NCj4gPiA+IFRoZQ0KPiA+ID4gPiA+ID4gPiA+ IGludGVyZmFjZSB0bw0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiB0aGUgZGFlbW9uIGlzIGZh aXJseSBzaW1wbGUgcmVxdWlyaW5nIG9ubHkgc29tZQ0KPiBtYXBwZWQNCj4gPiA+ID4gPiA+IG1l bW9yeQ0KPiA+ID4gPiA+ID4gPiA+IGFuZCBzb21lDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ IHNvcnQgb2Ygc2lnbmFsbGluZyBmb3IgZXZlbnRzIChvbiBMaW51eCB0aGlzIGlzDQo+ID4gPiBl dmVudGZkKS4NCj4gPiA+ID4gPiA+IFRoZQ0KPiA+ID4gPiA+ID4gPiA+IGlkZWEgd2FzIGENCj4g PiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gc3R1YiBiaW5hcnkgd291bGQgYmUgcmVzcG9uc2libGUg Zm9yIGFueQ0KPiBoeXBlcnZpc29yDQo+ID4gPiBzcGVjaWZpYw0KPiA+ID4gPiA+ID4gPiA+IHNl dHVwIGFuZA0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiB0aGVuIGxhdW5jaCBhIGNvbW1vbiBi aW5hcnkgdG8gZGVhbCB3aXRoIHRoZQ0KPiBhY3R1YWwNCj4gPiA+ID4gPiA+IHZpcnRxdWV1ZQ0K PiA+ID4gPiA+ID4gPiA+IHJlcXVlc3RzDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+IHRoZW1z ZWx2ZXMuDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+DQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4g PiA+IFNpbmNlIHRoYXQgb3JpZ2luYWwgc2tldGNoIHdlJ3ZlIHNlZW4gYW4gZXhwYW5zaW9uDQo+ IGluDQo+ID4gPiB0aGUNCj4gPiA+ID4gPiA+IHNvcnQNCj4gPiA+ID4gPiA+ID4gPiBvZiB3YXlz DQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+IGJhY2tlbmRzIGNvdWxkIGJlIGNyZWF0ZWQuIFRo ZXJlIGlzIGludGVyZXN0IGluDQo+ID4gPiA+ID4gPiBlbmNhcHN1bGF0aW5nDQo+ID4gPiA+ID4g PiA+ID4gYmFja2VuZHMNCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gaW4gUlRPU2VzIG9yIHVu aWtlcm5lbHMgZm9yIHNvbHV0aW9ucyBsaWtlIFNDTUkuDQo+IFRoZXJlDQo+ID4gPiA+ID4gPiBp bnRlcmVzdA0KPiA+ID4gPiA+ID4gPiA+IGluIFJ1c3QNCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ ID4gaGFzIHByb21wdGVkIGlkZWFzIG9mIHVzaW5nIHRoZSB0cmFpdCBpbnRlcmZhY2UgdG8NCj4g PiA+IGFic3RyYWN0DQo+ID4gPiA+ID4gPiA+ID4gZGlmZmVyZW5jZXMNCj4gPiA+ID4gPiA+ID4g PiA+ID4gPiA+ID4gYXdheSBhcyB3ZWxsIGFzIHRoZSBpZGVhIG9mIGJhcmUtbWV0YWwgUnVzdA0K PiBiYWNrZW5kcy4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4NCj4gPiA+ID4gPiA+ID4gPiA+ ID4gPiA+ID4gV2UgaGF2ZSBhIGNhcmQgKFNUUi0xMikgY2FsbGVkICJIeXBlcmNhbGwNCj4gPiA+ IFN0YW5kYXJkaXNhdGlvbiINCj4gPiA+ID4gPiA+IHdoaWNoDQo+ID4gPiA+ID4gPiA+ID4gPiA+ ID4gPiA+IGNhbGxzIGZvciBhIGRlc2NyaXB0aW9uIG9mIHRoZSBBUElzIG5lZWRlZCBmcm9tDQo+ IHRoZQ0KPiA+ID4gPiA+ID4gaHlwZXJ2aXNvcg0KPiA+ID4gPiA+ID4gPiA+IHNpZGUgdG8NCj4g PiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gc3VwcG9ydCBWaXJ0SU8gZ3Vlc3RzIGFuZCB0aGVpciBi YWNrZW5kcy4gSG93ZXZlcg0KPiB3ZQ0KPiA+ID4gYXJlDQo+ID4gPiA+ID4gPiBzb21lDQo+ID4g PiA+ID4gPiA+ID4gd2F5IG9mZg0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiBmcm9tIHRoYXQg YXQgdGhlIG1vbWVudCBhcyBJIHRoaW5rIHdlIG5lZWQgdG8gYXQNCj4gbGVhc3QNCj4gPiA+ID4g PiA+ID4gPiBkZW1vbnN0cmF0ZSBvbmUNCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gcG9ydGFi bGUgYmFja2VuZCBiZWZvcmUgd2Ugc3RhcnQgY29kaWZ5aW5nDQo+ID4gPiByZXF1aXJlbWVudHMu IFRvDQo+ID4gPiA+ID4gPiB0aGF0DQo+ID4gPiA+ID4gPiA+ID4gZW5kIEkNCj4gPiA+ID4gPiA+ ID4gPiA+ID4gPiA+ID4gd2FudCB0byB0aGluayBhYm91dCB3aGF0IHdlIG5lZWQgZm9yIGEgYmFj a2VuZCB0bw0KPiA+ID4gZnVuY3Rpb24uDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+DQo+ID4g PiA+ID4gPiA+ID4gPiA+ID4gPiA+IENvbmZpZ3VyYXRpb24NCj4gPiA+ID4gPiA+ID4gPiA+ID4g PiA+ID4gPT09PT09PT09PT09PQ0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPg0KPiA+ID4gPiA+ ID4gPiA+ID4gPiA+ID4gPiBJbiB0aGUgdHlwZS0yIHNldHVwIHRoaXMgaXMgdHlwaWNhbGx5IGZh aXJseQ0KPiBzaW1wbGUNCj4gPiA+IGJlY2F1c2UNCj4gPiA+ID4gPiA+IHRoZQ0KPiA+ID4gPiA+ ID4gPiA+IGhvc3QNCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gc3lzdGVtIGNhbiBvcmNoZXN0 cmF0ZSB0aGUgdmFyaW91cyBtb2R1bGVzIHRoYXQNCj4gbWFrZQ0KPiA+ID4gdXAgdGhlDQo+ID4g PiA+ID4gPiA+ID4gY29tcGxldGUNCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gc3lzdGVtLiBJ biB0aGUgdHlwZS0xIGNhc2UgKG9yIGV2ZW4gdHlwZS0yIHdpdGgNCj4gPiA+IGRlbGVnYXRlZA0K PiA+ID4gPiA+ID4gPiA+IHNlcnZpY2UgVk1zKQ0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiB3 ZSBuZWVkIHNvbWUgc29ydCBvZiBtZWNoYW5pc20gdG8gaW5mb3JtIHRoZQ0KPiBiYWNrZW5kDQo+ ID4gPiBWTQ0KPiA+ID4gPiA+ID4gYWJvdXQNCj4gPiA+ID4gPiA+ID4gPiBrZXkNCj4gPiA+ID4g PiA+ID4gPiA+ID4gPiA+ID4gZGV0YWlscyBhYm91dCB0aGUgc3lzdGVtOg0KPiA+ID4gPiA+ID4g PiA+ID4gPiA+ID4gPg0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiAgIC0gd2hlcmUgdmlydCBx dWV1ZSBtZW1vcnkgaXMgaW4gaXQncyBhZGRyZXNzDQo+IHNwYWNlDQo+ID4gPiA+ID4gPiA+ID4g PiA+ID4gPiA+ICAgLSBob3cgaXQncyBnb2luZyB0byByZWNlaXZlIChpbnRlcnJ1cHQpIGFuZA0K PiB0cmlnZ2VyDQo+ID4gPiAoa2ljaykNCj4gPiA+ID4gPiA+ID4gPiBldmVudHMNCj4gPiA+ID4g PiA+ID4gPiA+ID4gPiA+ID4gICAtIHdoYXQgKGlmIGFueSkgcmVzb3VyY2VzIHRoZSBiYWNrZW5k IG5lZWRzIHRvDQo+ID4gPiBjb25uZWN0IHRvDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+DQo+ ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+IE9idmlvdXNseSB5b3UgY2FuIGVsaWRlIG92ZXIgY29u ZmlndXJhdGlvbiBpc3N1ZXMNCj4gYnkNCj4gPiA+IGhhdmluZw0KPiA+ID4gPiA+ID4gPiA+IHN0 YXRpYw0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiBjb25maWd1cmF0aW9ucyBhbmQgYmFraW5n IHRoZSBhc3N1bXB0aW9ucyBpbnRvDQo+IHlvdXINCj4gPiA+IGd1ZXN0DQo+ID4gPiA+ID4gPiBp bWFnZXMNCj4gPiA+ID4gPiA+ID4gPiBob3dldmVyDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ IHRoaXMgaXNuJ3Qgc2NhbGFibGUgaW4gdGhlIGxvbmcgdGVybS4gVGhlIG9idmlvdXMNCj4gPiA+ IHNvbHV0aW9uDQo+ID4gPiA+ID4gPiBzZWVtcw0KPiA+ID4gPiA+ID4gPiA+IHRvIGJlDQo+ID4g PiA+ID4gPiA+ID4gPiA+ID4gPiA+IGV4dGVuZGluZyBhIHN1YnNldCBvZiBEZXZpY2UgVHJlZSBk YXRhIHRvIHVzZXINCj4gc3BhY2UNCj4gPiA+IGJ1dA0KPiA+ID4gPiA+ID4gcGVyaGFwcw0KPiA+ ID4gPiA+ID4gPiA+IHRoZXJlDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+IGFyZSBvdGhlciBh cHByb2FjaGVzPw0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPg0KPiA+ID4gPiA+ID4gPiA+ID4g PiA+ID4gPiBCZWZvcmUgYW55IHZpcnRpbyB0cmFuc2FjdGlvbnMgY2FuIHRha2UgcGxhY2UgdGhl DQo+ID4gPiA+ID4gPiBhcHByb3ByaWF0ZQ0KPiA+ID4gPiA+ID4gPiA+IG1lbW9yeQ0KPiA+ID4g PiA+ID4gPiA+ID4gPiA+ID4gPiBtYXBwaW5ncyBuZWVkIHRvIGJlIG1hZGUgYmV0d2VlbiB0aGUg RkUgZ3Vlc3QgYW5kDQo+IHRoZQ0KPiA+ID4gQkUNCj4gPiA+ID4gPiA+IGd1ZXN0Lg0KPiA+ID4g PiA+ID4gPiA+ID4gPiA+ID4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gQ3VycmVudGx5IHRo ZSB3aG9sZSBvZiB0aGUgRkUgZ3Vlc3RzIGFkZHJlc3Mgc3BhY2UNCj4gPiA+IG5lZWRzIHRvDQo+ ID4gPiA+ID4gPiBiZQ0KPiA+ID4gPiA+ID4gPiA+IHZpc2libGUNCj4gPiA+ID4gPiA+ID4gPiA+ ID4gPiA+ID4gdG8gd2hhdGV2ZXIgaXMgc2VydmluZyB0aGUgdmlydGlvIHJlcXVlc3RzLiBJIGNh bg0KPiA+ID4gZW52aXNpb24gMw0KPiA+ID4gPiA+ID4gPiA+IGFwcHJvYWNoZXM6DQo+ID4gPiA+ ID4gPiA+ID4gPiA+ID4gPiA+DQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ICAqIEJFIGd1ZXN0 IGJvb3RzIHdpdGggbWVtb3J5IGFscmVhZHkgbWFwcGVkDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4g PiA+DQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ICBUaGlzIHdvdWxkIGVudGFpbCB0aGUgZ3Vl c3QgT1Mga25vd2luZyB3aGVyZSBpbg0KPiBpdCdzDQo+ID4gPiBHdWVzdA0KPiA+ID4gPiA+ID4g PiA+IFBoeXNpY2FsDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ICBBZGRyZXNzIHNwYWNlIGlz IGFscmVhZHkgdGFrZW4gdXAgYW5kIGF2b2lkaW5nDQo+ID4gPiBjbGFzaGluZy4gSQ0KPiA+ID4g PiA+ID4gPiA+IHdvdWxkIGFzc3VtZQ0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiAgaW4gdGhp cyBjYXNlIHlvdSB3b3VsZCB3YW50IGEgc3RhbmRhcmQgaW50ZXJmYWNlDQo+IHRvDQo+ID4gPiA+ ID4gPiB1c2Vyc3BhY2UNCj4gPiA+ID4gPiA+ID4gPiB0byB0aGVuDQo+ID4gPiA+ID4gPiA+ID4g PiA+ID4gPiA+ICBtYWtlIHRoYXQgYWRkcmVzcyBzcGFjZSB2aXNpYmxlIHRvIHRoZSBiYWNrZW5k DQo+IGRhZW1vbi4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPg0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ IFlldCBhbm90aGVyIHdheSBoZXJlIGlzIHRoYXQgd2Ugd291bGQgaGF2ZSB3ZWxsIGtub3duDQo+ ID4gPiAic2hhcmVkDQo+ID4gPiA+ID4gPiA+ID4gbWVtb3J5IiBiZXR3ZWVuDQo+ID4gPiA+ID4g PiA+ID4gPiA+ID4gVk1zLiBJIHRoaW5rIHRoYXQgSmFpbGhvdXNlJ3MgaXZzaG1lbSBnaXZlcyB1 cyBnb29kDQo+ID4gPiBpbnNpZ2h0cyBvbg0KPiA+ID4gPiA+ID4gdGhpcw0KPiA+ID4gPiA+ID4g PiA+IG1hdHRlcg0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+IGFuZCB0aGF0IGl0IGNhbiBldmVuIGJl IGFuIGFsdGVybmF0aXZlIGZvciBoeXBlcnZpc29yLQ0KPiA+ID4gYWdub3N0aWMNCj4gPiA+ID4g PiA+ID4gPiBzb2x1dGlvbi4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPg0KPiA+ID4gPiA+ID4gPiA+ ID4gPiA+IChQbGVhc2Ugbm90ZSBtZW1vcnkgcmVnaW9ucyBpbiBpdnNobWVtIGFwcGVhciBhcyBh IFBDSQ0KPiA+ID4gZGV2aWNlDQo+ID4gPiA+ID4gPiBhbmQNCj4gPiA+ID4gPiA+ID4gPiBjYW4g YmUNCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiBtYXBwZWQgbG9jYWxseS4pDQo+ID4gPiA+ID4gPiA+ ID4gPiA+ID4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiBJIHdhbnQgdG8gYWRkIHRoaXMgc2hhcmVk IG1lbW9yeSBhc3BlY3QgdG8gbXkgdmlydGlvLQ0KPiBwcm94eSwNCj4gPiA+IGJ1dA0KPiA+ID4g PiA+ID4gPiA+ID4gPiA+IHRoZSByZXN1bHRhbnQgc29sdXRpb24gd291bGQgZXZlbnR1YWxseSBs b29rIHNpbWlsYXINCj4gdG8NCj4gPiA+IGl2c2htZW0uDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4N Cj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gICogQkUgZ3Vlc3RzIGJvb3RzIHdpdGggYSBoeXBl cnZpc29yIGhhbmRsZSB0bw0KPiBtZW1vcnkNCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4NCj4g PiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gIFRoZSBCRSBndWVzdCBpcyB0aGVuIGZyZWUgdG8gbWFw IHRoZSBGRSdzIG1lbW9yeQ0KPiB0bw0KPiA+ID4gd2hlcmUNCj4gPiA+ID4gPiA+IGl0DQo+ID4g PiA+ID4gPiA+ID4gd2FudHMgaW4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gIHRoZSBCRSdz IGd1ZXN0IHBoeXNpY2FsIGFkZHJlc3Mgc3BhY2UuDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPg0K PiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gSSBjYW5ub3Qgc2VlIGhvdyB0aGlzIGNvdWxkIHdvcmsg Zm9yIFhlbi4gVGhlcmUgaXMNCj4gbm8NCj4gPiA+ICJoYW5kbGUiDQo+ID4gPiA+ID4gPiB0bw0K PiA+ID4gPiA+ID4gPiA+IGdpdmUNCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+IHRvIHRoZSBiYWNr ZW5kIGlmIHRoZSBiYWNrZW5kIGlzIG5vdCBydW5uaW5nIGluIGRvbTAuDQo+IFNvDQo+ID4gPiBm b3INCj4gPiA+ID4gPiA+IFhlbiBJDQo+ID4gPiA+ID4gPiA+ID4gdGhpbmsNCj4gPiA+ID4gPiA+ ID4gPiA+ID4gPiA+IHRoZSBtZW1vcnkgaGFzIHRvIGJlIGFscmVhZHkgbWFwcGVkDQo+ID4gPiA+ ID4gPiA+ID4gPiA+ID4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiBJbiBYZW4ncyBJT1JFUSBzb2x1 dGlvbiAodmlydGlvLWJsayksIHRoZSBmb2xsb3dpbmcNCj4gPiA+IGluZm9ybWF0aW9uDQo+ID4g PiA+ID4gPiBpcw0KPiA+ID4gPiA+ID4gPiA+IGV4cGVjdGVkDQo+ID4gPiA+ID4gPiA+ID4gPiA+ ID4gdG8gYmUgZXhwb3NlZCB0byBCRSB2aWEgWGVuc3RvcmU6DQo+ID4gPiA+ID4gPiA+ID4gPiA+ ID4gKEkga25vdyB0aGF0IHRoaXMgaXMgYSB0ZW50YXRpdmUgYXBwcm9hY2ggdGhvdWdoLikNCj4g PiA+ID4gPiA+ID4gPiA+ID4gPiAgICAtIHRoZSBzdGFydCBhZGRyZXNzIG9mIGNvbmZpZ3VyYXRp b24gc3BhY2UNCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiAgICAtIGludGVycnVwdCBudW1iZXINCj4g PiA+ID4gPiA+ID4gPiA+ID4gPiAgICAtIGZpbGUgcGF0aCBmb3IgYmFja2luZyBzdG9yYWdlDQo+ ID4gPiA+ID4gPiA+ID4gPiA+ID4gICAgLSByZWFkLW9ubHkgZmxhZw0KPiA+ID4gPiA+ID4gPiA+ ID4gPiA+IEFuZCB0aGUgQkUgc2VydmVyIGhhdmUgdG8gY2FsbCBhIHBhcnRpY3VsYXIgaHlwZXJ2 aXNvcg0KPiA+ID4gaW50ZXJmYWNlDQo+ID4gPiA+ID4gPiB0bw0KPiA+ID4gPiA+ID4gPiA+ID4g PiA+IG1hcCB0aGUgY29uZmlndXJhdGlvbiBzcGFjZS4NCj4gPiA+ID4gPiA+ID4gPiA+ID4NCj4g PiA+ID4gPiA+ID4gPiA+ID4gWWVzLCBYZW5zdG9yZSB3YXMgY2hvc2VuIGFzIGEgc2ltcGxlIHdh eSB0byBwYXNzDQo+ID4gPiBjb25maWd1cmF0aW9uDQo+ID4gPiA+ID4gPiBpbmZvIHRvDQo+ID4g PiA+ID4gPiA+ID4gdGhlIGJhY2tlbmQgcnVubmluZyBpbiBhIG5vbi10b29sc3RhY2sgZG9tYWlu Lg0KPiA+ID4gPiA+ID4gPiA+ID4gPiBJIHJlbWVtYmVyLCB0aGVyZSB3YXMgYSB3aXNoIHRvIGF2 b2lkIHVzaW5nIFhlbnN0b3JlIGluDQo+ID4gPiBWaXJ0aW8NCj4gPiA+ID4gPiA+IGJhY2tlbmQN Cj4gPiA+ID4gPiA+ID4gPiBpdHNlbGYgaWYgcG9zc2libGUsIHNvIGZvciBub24tdG9vbHN0YWNr IGRvbWFpbiwgdGhpcyBjb3VsZA0KPiBkb25lDQo+ID4gPiB3aXRoDQo+ID4gPiA+ID4gPiA+ID4g YWRqdXN0aW5nIGRldmQgKGRhZW1vbiB0aGF0IGxpc3RlbnMgZm9yIGRldmljZXMgYW5kIGxhdW5j aGVzDQo+ID4gPiBiYWNrZW5kcykNCj4gPiA+ID4gPiA+ID4gPiA+ID4gdG8gcmVhZCBiYWNrZW5k IGNvbmZpZ3VyYXRpb24gZnJvbSB0aGUgWGVuc3RvcmUgYW55d2F5DQo+IGFuZA0KPiA+ID4gcGFz cyBpdA0KPiA+ID4gPiA+ID4gdG8NCj4gPiA+ID4gPiA+ID4gPiB0aGUgYmFja2VuZCB2aWEgY29t bWFuZCBsaW5lIGFyZ3VtZW50cy4NCj4gPiA+ID4gPiA+ID4gPiA+ID4NCj4gPiA+ID4gPiA+ID4g PiA+DQo+ID4gPiA+ID4gPiA+ID4gPiBZZXMsIGluIGN1cnJlbnQgUG9DIGNvZGUgd2UncmUgdXNp bmcgeGVuc3RvcmUgdG8gcGFzcw0KPiBkZXZpY2UNCj4gPiA+ID4gPiA+ID4gPiBjb25maWd1cmF0 aW9uLg0KPiA+ID4gPiA+ID4gPiA+ID4gV2UgYWxzbyBkZXNpZ25lZCBhIHN0YXRpYyBkZXZpY2Ug Y29uZmlndXJhdGlvbiBwYXJzZQ0KPiBtZXRob2QNCj4gPiA+IGZvcg0KPiA+ID4gPiA+ID4gRG9t MGxlc3MNCj4gPiA+ID4gPiA+ID4gPiBvcg0KPiA+ID4gPiA+ID4gPiA+ID4gb3RoZXIgc2NlbmFy aW9zIGRvbid0IGhhdmUgeGVudG9vbC4geWVzLCBpdCdzIGZyb20gZGV2aWNlDQo+ID4gPiBtb2Rl bA0KPiA+ID4gPiA+ID4gY29tbWFuZA0KPiA+ID4gPiA+ID4gPiA+IGxpbmUNCj4gPiA+ID4gPiA+ ID4gPiA+IG9yIGEgY29uZmlnIGZpbGUuDQo+ID4gPiA+ID4gPiA+ID4gPg0KPiA+ID4gPiA+ID4g PiA+ID4gPiBCdXQsIGlmIC4uLg0KPiA+ID4gPiA+ID4gPiA+ID4gPg0KPiA+ID4gPiA+ID4gPiA+ ID4gPiA+DQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gSW4gbXkgYXBwcm9hY2ggKHZpcnRpby1wcm94 eSksIGFsbCB0aG9zZSBYZW4gKG9yDQo+ID4gPiBoeXBlcnZpc29yKS0NCj4gPiA+ID4gPiA+ID4g PiBzcGVjaWZpYw0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+IHN0dWZmcyBhcmUgY29udGFpbmVkIGlu IHZpcnRpby1wcm94eSwgeWV0IGFub3RoZXIgVk0sDQo+IHRvDQo+ID4gPiBoaWRlDQo+ID4gPiA+ ID4gPiBhbGwNCj4gPiA+ID4gPiA+ID4gPiBkZXRhaWxzLg0KPiA+ID4gPiA+ID4gPiA+ID4gPg0K PiA+ID4gPiA+ID4gPiA+ID4gPiAuLi4gdGhlIHNvbHV0aW9uIGhvdyB0byBvdmVyY29tZSB0aGF0 IGlzIGFscmVhZHkgZm91bmQNCj4gYW5kDQo+ID4gPiBwcm92ZW4NCj4gPiA+ID4gPiA+IHRvDQo+ ID4gPiA+ID4gPiA+ID4gd29yayB0aGVuIGV2ZW4gYmV0dGVyLg0KPiA+ID4gPiA+ID4gPiA+ID4g Pg0KPiA+ID4gPiA+ID4gPiA+ID4gPg0KPiA+ID4gPiA+ID4gPiA+ID4gPg0KPiA+ID4gPiA+ID4g PiA+ID4gPiA+ICMgTXkgcG9pbnQgaXMgdGhhdCBhICJoYW5kbGUiIGlzIG5vdCBtYW5kYXRvcnkg Zm9yDQo+ID4gPiBleGVjdXRpbmcNCj4gPiA+ID4gPiA+IG1hcHBpbmcuDQo+ID4gPiA+ID4gPiA+ ID4gPiA+ID4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+IGFuZCB0aGUgbWFwcGluZyBwcm9iYWJs eSBkb25lIGJ5IHRoZQ0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gdG9vbHN0YWNrIChhbHNvIHNl ZSBiZWxvdy4pIE9yIHdlIHdvdWxkIGhhdmUgdG8NCj4gaW52ZW50IGENCj4gPiA+IG5ldw0KPiA+ ID4gPiA+ID4gWGVuDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiBoeXBlcnZpc29yIGludGVyZmFj ZSBhbmQgWGVuIHZpcnR1YWwgbWFjaGluZQ0KPiBwcml2aWxlZ2VzDQo+ID4gPiB0bw0KPiA+ID4g PiA+ID4gYWxsb3cNCj4gPiA+ID4gPiA+ID4gPiB0aGlzDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4g PiBraW5kIG9mIG1hcHBpbmcuDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4NCj4gPiA+ID4gPiA+ID4g PiA+ID4gPiA+IElmIHdlIHJ1biB0aGUgYmFja2VuZCBpbiBEb20wIHRoYXQgd2UgaGF2ZSBubw0K PiBwcm9ibGVtcw0KPiA+ID4gb2YNCj4gPiA+ID4gPiA+IGNvdXJzZS4NCj4gPiA+ID4gPiA+ID4g PiA+ID4gPg0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+IE9uZSBvZiBkaWZmaWN1bHRpZXMgb24gWGVu IHRoYXQgSSBmb3VuZCBpbiBteSBhcHByb2FjaA0KPiBpcw0KPiA+ID4gdGhhdA0KPiA+ID4gPiA+ ID4gPiA+IGNhbGxpbmcNCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiBzdWNoIGh5cGVydmlzb3IgaW50 ZWZhY2VzIChyZWdpc3RlcmluZyBJT1JFUSwgbWFwcGluZw0KPiA+ID4gbWVtb3J5KSBpcw0KPiA+ ID4gPiA+ID4gPiA+IG9ubHkNCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiBhbGxvd2VkIG9uIEJFIHNl cnZlcnMgdGhlbXNlbHZpZXMgYW5kIHNvIHdlIHdpbGwgaGF2ZQ0KPiB0bw0KPiA+ID4gZXh0ZW5k DQo+ID4gPiA+ID4gPiA+ID4gdGhvc2UNCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiBpbnRlcmZhY2Vz Lg0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+IFRoaXMsIGhvd2V2ZXIsIHdpbGwgcmFpc2Ugc29tZSBj b25jZXJuIG9uIHNlY3VyaXR5IGFuZA0KPiA+ID4gcHJpdmlsZWdlDQo+ID4gPiA+ID4gPiA+ID4g ZGlzdHJpYnV0aW9uDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gYXMgU3RlZmFuIHN1Z2dlc3RlZC4N Cj4gPiA+ID4gPiA+ID4gPiA+ID4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gV2UgYWxzbyBmYWNlZCBw b2xpY3kgcmVsYXRlZCBpc3N1ZXMgd2l0aCBWaXJ0aW8gYmFja2VuZA0KPiA+ID4gcnVubmluZyBp bg0KPiA+ID4gPiA+ID4gPiA+IG90aGVyIHRoYW4gRG9tMCBkb21haW4gaW4gYSAiZHVtbXkiIHhz bSBtb2RlLiBJbiBvdXIgdGFyZ2V0DQo+ID4gPiBzeXN0ZW0gd2UNCj4gPiA+ID4gPiA+IHJ1bg0K PiA+ID4gPiA+ID4gPiA+IHRoZSBiYWNrZW5kIGluIGEgZHJpdmVyDQo+ID4gPiA+ID4gPiA+ID4g PiA+IGRvbWFpbiAod2UgY2FsbCBpdCBEb21EKSB3aGVyZSB0aGUgdW5kZXJseWluZyBIL1cNCj4g cmVzaWRlcy4NCj4gPiA+IFdlDQo+ID4gPiA+ID4gPiB0cnVzdCBpdCwNCj4gPiA+ID4gPiA+ID4g PiBzbyB3ZSB3cm90ZSBwb2xpY3kgcnVsZXMgKHRvIGJlIHVzZWQgaW4gImZsYXNrIiB4c20gbW9k ZSkgdG8NCj4gPiA+IHByb3ZpZGUNCj4gPiA+ID4gPiA+IGl0DQo+ID4gPiA+ID4gPiA+ID4gd2l0 aCBhIGxpdHRsZSBiaXQgbW9yZSBwcml2aWxlZ2VzIHRoYW4gYSBzaW1wbGUgRG9tVSBoYWQuDQo+ ID4gPiA+ID4gPiA+ID4gPiA+IE5vdyBpdCBpcyBwZXJtaXR0ZWQgdG8gaXNzdWUgZGV2aWNlLW1v ZGVsLCByZXNvdXJjZSBhbmQNCj4gPiA+IG1lbW9yeQ0KPiA+ID4gPiA+ID4gPiA+IG1hcHBpbmdz LCBldGMgY2FsbHMuDQo+ID4gPiA+ID4gPiA+ID4gPiA+DQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4g Pg0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gVG8g YWN0aXZhdGUgdGhlIG1hcHBpbmcgd2lsbA0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiAgcmVx dWlyZSBzb21lIHNvcnQgb2YgaHlwZXJjYWxsIHRvIHRoZSBoeXBlcnZpc29yLg0KPiBJDQo+ID4g PiBjYW4gc2VlDQo+ID4gPiA+ID4gPiB0d28NCj4gPiA+ID4gPiA+ID4gPiBvcHRpb25zDQo+ID4g PiA+ID4gPiA+ID4gPiA+ID4gPiA+ICBhdCB0aGlzIHBvaW50Og0KPiA+ID4gPiA+ID4gPiA+ID4g PiA+ID4gPg0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiAgIC0gZXhwb3NlIHRoZSBoYW5kbGUg dG8gdXNlcnNwYWNlIGZvcg0KPiBkYWVtb24vaGVscGVyDQo+ID4gPiB0bw0KPiA+ID4gPiA+ID4g dHJpZ2dlcg0KPiA+ID4gPiA+ID4gPiA+IHRoZQ0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiAg ICAgbWFwcGluZyB2aWEgZXhpc3RpbmcgaHlwZXJjYWxsIGludGVyZmFjZXMuIElmDQo+ID4gPiB1 c2luZyBhDQo+ID4gPiA+ID4gPiBoZWxwZXINCj4gPiA+ID4gPiA+ID4gPiB5b3UNCj4gPiA+ID4g PiA+ID4gPiA+ID4gPiA+ID4gICAgIHdvdWxkIGhhdmUgYSBoeXBlcnZpc29yIHNwZWNpZmljIG9u ZSB0byBhdm9pZA0KPiB0aGUNCj4gPiA+IGRhZW1vbg0KPiA+ID4gPiA+ID4gPiA+IGhhdmluZyB0 bw0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiAgICAgY2FyZSB0b28gbXVjaCBhYm91dCB0aGUg ZGV0YWlscyBvciBwdXNoIHRoYXQNCj4gPiA+IGNvbXBsZXhpdHkNCj4gPiA+ID4gPiA+IGludG8N Cj4gPiA+ID4gPiA+ID4gPiBhDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ICAgICBjb21waWxl IHRpbWUgb3B0aW9uIGZvciB0aGUgZGFlbW9uIHdoaWNoIHdvdWxkDQo+ID4gPiByZXN1bHQgaW4N Cj4gPiA+ID4gPiA+ID4gPiBkaWZmZXJlbnQNCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gICAg IGJpbmFyaWVzIGFsdGhvdWdoIGEgY29tbW9uIHNvdXJjZSBiYXNlLg0KPiA+ID4gPiA+ID4gPiA+ ID4gPiA+ID4gPg0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiAgIC0gZXhwb3NlIGEgbmV3IGtl cm5lbCBBQkkgdG8gYWJzdHJhY3QgdGhlDQo+IGh5cGVyY2FsbA0KPiA+ID4gPiA+ID4gPiA+IGRp ZmZlcmVuY2VzIGF3YXkNCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gICAgIGluIHRoZSBndWVz dCBrZXJuZWwuIEluIHRoaXMgY2FzZSB0aGUNCj4gdXNlcnNwYWNlDQo+ID4gPiB3b3VsZA0KPiA+ ID4gPiA+ID4gPiA+IGVzc2VudGlhbGx5DQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ICAgICBh c2sgZm9yIGFuIGFic3RyYWN0ICJtYXAgZ3Vlc3QgTiBtZW1vcnkgdG8NCj4gPiA+IHVzZXJzcGFj ZQ0KPiA+ID4gPiA+ID4gcHRyIg0KPiA+ID4gPiA+ID4gPiA+IGFuZCBsZXQNCj4gPiA+ID4gPiA+ ID4gPiA+ID4gPiA+ID4gICAgIHRoZSBrZXJuZWwgZGVhbCB3aXRoIHRoZSBkaWZmZXJlbnQgaHlw ZXJjYWxsDQo+ID4gPiBpbnRlcmZhY2VzLg0KPiA+ID4gPiA+ID4gPiA+IFRoaXMgb2YNCj4gPiA+ ID4gPiA+ID4gPiA+ID4gPiA+ID4gICAgIGNvdXJzZSBhc3N1bWVzIHRoZSBtYWpvcml0eSBvZiBC RSBndWVzdHMgd291bGQNCj4gYmUNCj4gPiA+IExpbnV4DQo+ID4gPiA+ID4gPiA+ID4ga2VybmVs cyBhbmQNCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gICAgIGxlYXZlcyB0aGUgYmFyZS1tZXRh bC91bmlrZXJuZWwgYXBwcm9hY2hlcyB0bw0KPiA+ID4gdGhlaXIgb3duDQo+ID4gPiA+ID4gPiA+ ID4gZGV2aWNlcy4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4NCj4gPiA+ID4gPiA+ID4gPiA+ ID4gPiA+ID4gT3BlcmF0aW9uDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID09PT09PT09PQ0K PiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPg0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiBUaGUg Y29yZSBvZiB0aGUgb3BlcmF0aW9uIG9mIFZpcnRJTyBpcyBmYWlybHkNCj4gc2ltcGxlLg0KPiA+ ID4gT25jZQ0KPiA+ID4gPiA+ID4gdGhlDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+IHZob3N0 LXVzZXIgZmVhdHVyZSBuZWdvdGlhdGlvbiBpcyBkb25lIGl0J3MgYSBjYXNlDQo+IG9mDQo+ID4g PiA+ID4gPiByZWNlaXZpbmcNCj4gPiA+ID4gPiA+ID4gPiB1cGRhdGUNCj4gPiA+ID4gPiA+ID4g PiA+ID4gPiA+ID4gZXZlbnRzIGFuZCBwYXJzaW5nIHRoZSByZXN1bHRhbnQgdmlydCBxdWV1ZSBm b3INCj4gZGF0YS4NCj4gPiA+IFRoZQ0KPiA+ID4gPiA+ID4gdmhvc3QtDQo+ID4gPiA+ID4gPiA+ ID4gdXNlcg0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiBzcGVjaWZpY2F0aW9uIGhhbmRsZXMg YSBidW5jaCBvZiBzZXR1cCBiZWZvcmUgdGhhdA0KPiA+ID4gcG9pbnQsDQo+ID4gPiA+ID4gPiBt b3N0bHkNCj4gPiA+ID4gPiA+ID4gPiB0bw0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiBkZXRh aWwgd2hlcmUgdGhlIHZpcnQgcXVldWVzIGFyZSBzZXQgdXAgRkQncyBmb3INCj4gPiA+IG1lbW9y eSBhbmQNCj4gPiA+ID4gPiA+ID4gPiBldmVudA0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiBj b21tdW5pY2F0aW9uLiBUaGlzIGlzIHdoZXJlIHRoZSBlbnZpc2lvbmVkIHN0dWINCj4gPiA+IHBy b2Nlc3MNCj4gPiA+ID4gPiA+IHdvdWxkDQo+ID4gPiA+ID4gPiA+ID4gYmUNCj4gPiA+ID4gPiA+ ID4gPiA+ID4gPiA+ID4gcmVzcG9uc2libGUgZm9yIGdldHRpbmcgdGhlIGRhZW1vbiB1cCBhbmQg cmVhZHkgdG8NCj4gcnVuLg0KPiA+ID4gVGhpcw0KPiA+ID4gPiA+ID4gaXMNCj4gPiA+ID4gPiA+ ID4gPiA+ID4gPiA+ID4gY3VycmVudGx5IGRvbmUgaW5zaWRlIGEgYmlnIFZNTSBsaWtlIFFFTVUg YnV0IEkNCj4gPiA+IHN1c3BlY3QgYQ0KPiA+ID4gPiA+ID4gbW9kZXJuDQo+ID4gPiA+ID4gPiA+ ID4gPiA+ID4gPiA+IGFwcHJvYWNoIHdvdWxkIGJlIHRvIHVzZSB0aGUgcnVzdC12bW0gdmhvc3Qg Y3JhdGUuDQo+IEl0DQo+ID4gPiB3b3VsZA0KPiA+ID4gPiA+ID4gdGhlbg0KPiA+ID4gPiA+ID4g PiA+IGVpdGhlcg0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiBjb21tdW5pY2F0ZSB3aXRoIHRo ZSBrZXJuZWwncyBhYnN0cmFjdGVkIEFCSSBvciBiZQ0KPiByZS0NCj4gPiA+ID4gPiA+IHRhcmdl dGVkDQo+ID4gPiA+ID4gPiA+ID4gYXMgYQ0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiBidWls ZCBvcHRpb24gZm9yIHRoZSB2YXJpb3VzIGh5cGVydmlzb3JzLg0KPiA+ID4gPiA+ID4gPiA+ID4g PiA+ID4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+IE9uZSB0aGluZyBJIG1lbnRpb25lZCBiZWZv cmUgdG8gQWxleCBpcyB0aGF0IFhlbg0KPiBkb2Vzbid0DQo+ID4gPiBoYXZlDQo+ID4gPiA+ID4g PiBWTU1zDQo+ID4gPiA+ID4gPiA+ID4gdGhlDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiB3YXkg dGhleSBhcmUgdHlwaWNhbGx5IGVudmlzaW9uZWQgYW5kIGRlc2NyaWJlZCBpbg0KPiBvdGhlcg0K PiA+ID4gPiA+ID4gPiA+IGVudmlyb25tZW50cy4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+IElu c3RlYWQsIFhlbiBoYXMgSU9SRVEgc2VydmVycy4gRWFjaCBvZiB0aGVtDQo+IGNvbm5lY3RzDQo+ ID4gPiA+ID4gPiA+ID4gaW5kZXBlbmRlbnRseSB0bw0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4g WGVuIHZpYSB0aGUgSU9SRVEgaW50ZXJmYWNlLiBFLmcuIHRvZGF5IG11bHRpcGxlDQo+IFFFTVVz DQo+ID4gPiBjb3VsZA0KPiA+ID4gPiA+ID4gYmUNCj4gPiA+ID4gPiA+ID4gPiB1c2VkIGFzDQo+ ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiBlbXVsYXRvcnMgZm9yIGEgc2luZ2xlIFhlbiBWTSwgZWFj aCBvZiB0aGVtDQo+IGNvbm5lY3RpbmcNCj4gPiA+IHRvIFhlbg0KPiA+ID4gPiA+ID4gPiA+ID4g PiA+ID4gaW5kZXBlbmRlbnRseSB2aWEgdGhlIElPUkVRIGludGVyZmFjZS4NCj4gPiA+ID4gPiA+ ID4gPiA+ID4gPiA+DQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiBUaGUgY29tcG9uZW50IHJlc3Bv bnNpYmxlIGZvciBzdGFydGluZyBhIGRhZW1vbg0KPiBhbmQvb3INCj4gPiA+IHNldHRpbmcNCj4g PiA+ID4gPiA+IHVwDQo+ID4gPiA+ID4gPiA+ID4gc2hhcmVkDQo+ID4gPiA+ID4gPiA+ID4gPiA+ ID4gPiBpbnRlcmZhY2VzIGlzIHRoZSB0b29sc3RhY2s6IHRoZSB4bCBjb21tYW5kIGFuZCB0aGUN Cj4gPiA+ID4gPiA+IGxpYnhsL2xpYnhjDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiBsaWJyYXJp ZXMuDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiBJIHRoaW5r IHRoYXQgVk0gY29uZmlndXJhdGlvbiBtYW5hZ2VtZW50IChvcg0KPiBvcmNoZXN0cmF0aW9uDQo+ ID4gPiBpbg0KPiA+ID4gPiA+ID4gPiA+IFN0YXJ0b3MNCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiBq YXJnb24/KSBpcyBhIHN1YmplY3QgdG8gZGViYXRlIGluIHBhcmFsbGVsLg0KPiA+ID4gPiA+ID4g PiA+ID4gPiA+IE90aGVyd2lzZSwgaXMgdGhlcmUgYW55IGdvb2QgYXNzdW1wdGlvbiB0byBhdm9p ZCBpdA0KPiByaWdodA0KPiA+ID4gbm93Pw0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+DQo+ID4gPiA+ ID4gPiA+ID4gPiA+ID4gPiBPbGVrc2FuZHIgYW5kIG90aGVycyBJIENDZWQgaGF2ZSBiZWVuIHdv cmtpbmcgb24NCj4gd2F5cw0KPiA+ID4gZm9yIHRoZQ0KPiA+ID4gPiA+ID4gPiA+IHRvb2xzdGFj aw0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gdG8gY3JlYXRlIHZpcnRpbyBiYWNrZW5kcyBhbmQg c2V0dXAgbWVtb3J5IG1hcHBpbmdzLg0KPiA+ID4gVGhleQ0KPiA+ID4gPiA+ID4gbWlnaHQgYmUN Cj4gPiA+ID4gPiA+ID4gPiBhYmxlDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiB0byBwcm92aWRl IG1vcmUgaW5mbyBvbiB0aGUgc3ViamVjdC4gSSBkbyB0aGluayB3ZQ0KPiBtaXNzDQo+ID4gPiBh IHdheQ0KPiA+ID4gPiA+ID4gdG8NCj4gPiA+ID4gPiA+ID4gPiBwcm92aWRlDQo+ID4gPiA+ID4g PiA+ID4gPiA+ID4gPiB0aGUgY29uZmlndXJhdGlvbiB0byB0aGUgYmFja2VuZCBhbmQgYW55dGhp bmcgZWxzZQ0KPiB0aGF0DQo+ID4gPiB0aGUNCj4gPiA+ID4gPiA+ID4gPiBiYWNrZW5kDQo+ID4g PiA+ID4gPiA+ID4gPiA+ID4gPiBtaWdodCByZXF1aXJlIHRvIHN0YXJ0IGRvaW5nIGl0cyBqb2Iu DQo+ID4gPiA+ID4gPiA+ID4gPiA+DQo+ID4gPiA+ID4gPiA+ID4gPiA+IFllcywgc29tZSB3b3Jr IGhhcyBiZWVuIGRvbmUgZm9yIHRoZSB0b29sc3RhY2sgdG8gaGFuZGxlDQo+ID4gPiBWaXJ0aW8N Cj4gPiA+ID4gPiA+IE1NSU8NCj4gPiA+ID4gPiA+ID4gPiBkZXZpY2VzIGluDQo+ID4gPiA+ID4g PiA+ID4gPiA+IGdlbmVyYWwgYW5kIFZpcnRpbyBibG9jayBkZXZpY2VzIGluIHBhcnRpY3VsYXIu IEhvd2V2ZXIsDQo+IGl0DQo+ID4gPiBoYXMNCj4gPiA+ID4gPiA+IG5vdA0KPiA+ID4gPiA+ID4g PiA+IGJlZW4gdXBzdHJlYW5lZCB5ZXQuDQo+ID4gPiA+ID4gPiA+ID4gPiA+IFVwZGF0ZWQgcGF0 Y2hlcyBvbiByZXZpZXcgbm93Og0KPiA+ID4gPiA+ID4gPiA+ID4gPiBodHRwczovL2xvcmUua2Vy bmVsLm9yZy94ZW4tZGV2ZWwvMTYyMTYyNjM2MS0yOTA3Ni0xLQ0KPiBnaXQtDQo+ID4gPiBzZW5k LQ0KPiA+ID4gPiA+ID4gZW1haWwtDQo+ID4gPiA+ID4gPiA+ID4gb2xla3N0eXNoQGdtYWlsLmNv bS8NCj4gPiA+ID4gPiA+ID4gPiA+ID4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gVGhlcmUgaXMgYW4g YWRkaXRpb25hbCAoYWxzbyBpbXBvcnRhbnQpIGFjdGl2aXR5IHRvDQo+ID4gPiBpbXByb3ZlL2Zp eA0KPiA+ID4gPiA+ID4gPiA+IGZvcmVpZ24gbWVtb3J5IG1hcHBpbmcgb24gQXJtIHdoaWNoIEkg YW0gYWxzbyBpbnZvbHZlZCBpbi4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gVGhlIGZvcmVpZ24gbWVt b3J5IG1hcHBpbmcgaXMgcHJvcG9zZWQgdG8gYmUgdXNlZCBmb3INCj4gVmlydGlvDQo+ID4gPiA+ ID4gPiBiYWNrZW5kcw0KPiA+ID4gPiA+ID4gPiA+IChkZXZpY2UgZW11bGF0b3JzKSBpZiB0aGVy ZSBpcyBhIG5lZWQgdG8gcnVuIGd1ZXN0IE9TDQo+IGNvbXBsZXRlbHkNCj4gPiA+ID4gPiA+ID4g PiB1bm1vZGlmaWVkLg0KPiA+ID4gPiA+ID4gPiA+ID4gPiBPZiBjb3Vyc2UsIHRoZSBtb3JlIHNl Y3VyZSB3YXkgd291bGQgYmUgdG8gdXNlIGdyYW50DQo+IG1lbW9yeQ0KPiA+ID4gPiA+ID4gbWFw cGluZy4NCj4gPiA+ID4gPiA+ID4gPiBCcmlldGx5LCB0aGUgbWFpbiBkaWZmZXJlbmNlIGJldHdl ZW4gdGhlbSBpcyB0aGF0IHdpdGgNCj4gZm9yZWlnbg0KPiA+ID4gbWFwcGluZw0KPiA+ID4gPiA+ ID4gdGhlDQo+ID4gPiA+ID4gPiA+ID4gYmFja2VuZA0KPiA+ID4gPiA+ID4gPiA+ID4gPiBjYW4g bWFwIGFueSBndWVzdCBtZW1vcnkgaXQgd2FudHMgdG8gbWFwLCBidXQgd2l0aCBncmFudA0KPiA+ ID4gbWFwcGluZw0KPiA+ID4gPiA+ID4gaXQgaXMNCj4gPiA+ID4gPiA+ID4gPiBhbGxvd2VkIHRv IG1hcCBvbmx5IHdoYXQgd2FzIHByZXZpb3VzbHkgZ3JhbnRlZCBieSB0aGUNCj4gZnJvbnRlbmQu DQo+ID4gPiA+ID4gPiA+ID4gPiA+DQo+ID4gPiA+ID4gPiA+ID4gPiA+IFNvLCB0aGVyZSBtaWdo dCBiZSBhIHByb2JsZW0gaWYgd2Ugd2FudCB0byBwcmUtbWFwIHNvbWUNCj4gPiA+IGd1ZXN0DQo+ ID4gPiA+ID4gPiBtZW1vcnkNCj4gPiA+ID4gPiA+ID4gPiBpbiBhZHZhbmNlIG9yIHRvIGNhY2hl IG1hcHBpbmdzIGluIHRoZSBiYWNrZW5kIGluIG9yZGVyIHRvDQo+ID4gPiBpbXByb3ZlDQo+ID4g PiA+ID4gPiA+ID4gcGVyZm9ybWFuY2UgKGJlY2F1c2UgdGhlIG1hcHBpbmcvdW5tYXBwaW5nIGd1 ZXN0IHBhZ2VzIGV2ZXJ5DQo+ID4gPiByZXF1ZXN0DQo+ID4gPiA+ID4gPiA+ID4gcmVxdWlyZXMg YSBsb3Qgb2YgYmFjayBhbmQgZm9ydGggdG8gWGVuICsgUDJNIHVwZGF0ZXMpLiBJbiBhDQo+ID4g PiBudXRzaGVsbCwNCj4gPiA+ID4gPiA+ID4gPiBjdXJyZW50bHksIGluIG9yZGVyIHRvIG1hcCBh IGd1ZXN0IHBhZ2UgaW50byB0aGUgYmFja2VuZA0KPiBhZGRyZXNzDQo+ID4gPiBzcGFjZQ0KPiA+ ID4gPiA+ID4gd2UNCj4gPiA+ID4gPiA+ID4gPiBuZWVkIHRvIHN0ZWFsIGEgcmVhbCBwaHlzaWNh bCBwYWdlIGZyb20gdGhlIGJhY2tlbmQgZG9tYWluLg0KPiBTbywNCj4gPiA+IHdpdGgNCj4gPiA+ ID4gPiA+IHRoZQ0KPiA+ID4gPiA+ID4gPiA+IHNhaWQgb3B0aW1pemF0aW9ucyB3ZSBtaWdodCBl bmQgdXAgd2l0aCBubyBmcmVlIG1lbW9yeSBpbg0KPiB0aGUNCj4gPiA+IGJhY2tlbmQNCj4gPiA+ ID4gPiA+ID4gPiBkb21haW4gKHNlZSBYU0EtMzAwKS4gQW5kIHdoYXQgd2UgdHJ5IHRvIGFjaGll dmUgaXMgdG8gbm90DQo+IHdhc3RlDQo+ID4gPiBhDQo+ID4gPiA+ID4gPiByZWFsDQo+ID4gPiA+ ID4gPiA+ID4gZG9tYWluIG1lbW9yeSBhdCBhbGwgYnkgcHJvdmlkaW5nIHNhZmUgbm9uLWFsbG9j YXRlZC15ZXQgKHNvDQo+ID4gPiB1bnVzZWQpDQo+ID4gPiA+ID4gPiA+ID4gYWRkcmVzcyBzcGFj ZSBmb3IgdGhlIGZvcmVpZ24gKGFuZCBncmFudCkgcGFnZXMgdG8gYmUgbWFwcGVkDQo+ID4gPiBp bnRvLA0KPiA+ID4gPiA+ID4gdGhpcw0KPiA+ID4gPiA+ID4gPiA+IGVuYWJsaW5nIHdvcmsgaW1w bGllcyBYZW4gYW5kIExpbnV4IChhbmQgbGlrZWx5IERUQiBiaW5kaW5ncykNCj4gPiA+IGNoYW5n ZXMuDQo+ID4gPiA+ID4gPiA+ID4gSG93ZXZlciwgYXMgaXQgdHVybmVkIG91dCwgZm9yIHRoaXMg dG8gd29yayBpbiBhIHByb3BlciBhbmQNCj4gc2FmZQ0KPiA+ID4gd2F5DQo+ID4gPiA+ID4gPiBz b21lDQo+ID4gPiA+ID4gPiA+ID4gcHJlcmVxIHdvcmsgbmVlZHMgdG8gYmUgZG9uZS4NCj4gPiA+ ID4gPiA+ID4gPiA+ID4gWW91IGNhbiBmaW5kIHRoZSByZWxhdGVkIFhlbiBkaXNjdXNzaW9uIGF0 Og0KPiA+ID4gPiA+ID4gPiA+ID4gPiBodHRwczovL2xvcmUua2VybmVsLm9yZy94ZW4tZGV2ZWwv MTYyNzQ4OTExMC0yNTYzMy0xLQ0KPiBnaXQtDQo+ID4gPiBzZW5kLQ0KPiA+ID4gPiA+ID4gZW1h aWwtDQo+ID4gPiA+ID4gPiA+ID4gb2xla3N0eXNoQGdtYWlsLmNvbS8NCj4gPiA+ID4gPiA+ID4g PiA+ID4NCj4gPiA+ID4gPiA+ID4gPiA+ID4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+DQo+ID4g PiA+ID4gPiA+ID4gPiA+ID4gPg0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiBPbmUgcXVlc3Rp b24gaXMgaG93IHRvIGJlc3QgaGFuZGxlIG5vdGlmaWNhdGlvbg0KPiBhbmQNCj4gPiA+IGtpY2tz Lg0KPiA+ID4gPiA+ID4gVGhlDQo+ID4gPiA+ID4gPiA+ID4gZXhpc3RpbmcNCj4gPiA+ID4gPiA+ ID4gPiA+ID4gPiA+ID4gdmhvc3QtdXNlciBmcmFtZXdvcmsgdXNlcyBldmVudGZkIHRvIHNpZ25h bCB0aGUNCj4gZGFlbW9uDQo+ID4gPiA+ID4gPiAoYWx0aG91Z2gNCj4gPiA+ID4gPiA+ID4gPiBR RU1VDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+IGlzIHF1aXRlIGNhcGFibGUgb2Ygc2ltdWxh dGluZyB0aGVtIHdoZW4geW91IHVzZQ0KPiBUQ0cpLg0KPiA+ID4gWGVuDQo+ID4gPiA+ID4gPiBo YXMNCj4gPiA+ID4gPiA+ID4gPiBpdCdzIG93bg0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiBJ T1JFUSBtZWNoYW5pc20uIEhvd2V2ZXIgbGF0ZW5jeSBpcyBhbiBpbXBvcnRhbnQNCj4gPiA+IGZh Y3RvciBhbmQNCj4gPiA+ID4gPiA+ID4gPiBoYXZpbmcNCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ ID4gZXZlbnRzIGdvIHRocm91Z2ggdGhlIHN0dWIgd291bGQgYWRkIHF1aXRlIGEgbG90Lg0KPiA+ ID4gPiA+ID4gPiA+ID4gPiA+ID4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+IFllYWggSSB0aGlu aywgcmVnYXJkbGVzcyBvZiBhbnl0aGluZyBlbHNlLCB3ZSB3YW50DQo+IHRoZQ0KPiA+ID4gPiA+ ID4gYmFja2VuZHMgdG8NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+IGNvbm5lY3QgZGlyZWN0bHkg dG8gdGhlIFhlbiBoeXBlcnZpc29yLg0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+DQo+ID4gPiA+ID4g PiA+ID4gPiA+ID4gSW4gbXkgYXBwcm9hY2gsDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gIGEpIEJF IC0+IEZFOiBpbnRlcnJ1cHRzIHRyaWdnZXJlZCBieSBCRSBjYWxsaW5nIGENCj4gPiA+IGh5cGVy dmlzb3INCj4gPiA+ID4gPiA+ID4gPiBpbnRlcmZhY2UNCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiAg ICAgICAgICAgICAgIHZpYSB2aXJ0aW8tcHJveHkNCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiAgYikg RkUgLT4gQkU6IE1NSU8gdG8gY29uZmlnIHJhaXNlcyBldmVudHMgKGluIGV2ZW50DQo+ID4gPiBj aGFubmVscyksDQo+ID4gPiA+ID4gPiA+ID4gd2hpY2ggaXMNCj4gPiA+ID4gPiA+ID4gPiA+ID4g PiAgICAgICAgICAgICAgIGNvbnZlcnRlZCB0byBhIGNhbGxiYWNrIHRvIEJFIHZpYQ0KPiB2aXJ0 aW8tDQo+ID4gPiBwcm94eQ0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ICAgICAgICAgICAgICAgKFhl bidzIGV2ZW50IGNoYW5uZWwgaXMgaW50ZXJubmFsbHkNCj4gPiA+IGltcGxlbWVudGVkIGJ5DQo+ ID4gPiA+ID4gPiA+ID4gaW50ZXJydXB0cy4pDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4NCj4gPiA+ ID4gPiA+ID4gPiA+ID4gPiBJIGRvbid0IGtub3cgd2hhdCAiY29ubmVjdCBkaXJlY3RseSIgbWVh bnMgaGVyZSwgYnV0DQo+ID4gPiBzZW5kaW5nDQo+ID4gPiA+ID4gPiA+ID4gaW50ZXJydXB0cw0K PiA+ID4gPiA+ID4gPiA+ID4gPiA+IHRvIHRoZSBvcHBvc2l0ZSBzaWRlIHdvdWxkIGJlIGJlc3Qg ZWZmaWNpZW50Lg0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+IEl2c2htZW0sIEkgc3VwcG9zZSwgdGFr ZXMgdGhpcyBhcHByb2FjaCBieSB1dGlsaXppbmcNCj4gUENJJ3MNCj4gPiA+IG1zaS14DQo+ID4g PiA+ID4gPiA+ID4gbWVjaGFuaXNtLg0KPiA+ID4gPiA+ID4gPiA+ID4gPg0KPiA+ID4gPiA+ID4g PiA+ID4gPiBBZ3JlZSB0aGF0IE1TSSB3b3VsZCBiZSBtb3JlIGVmZmljaWVudCB0aGFuIFNQSS4u Lg0KPiA+ID4gPiA+ID4gPiA+ID4gPiBBdCB0aGUgbW9tZW50LCBpbiBvcmRlciB0byBub3RpZnkg dGhlIGZyb250ZW5kLCB0aGUNCj4gYmFja2VuZA0KPiA+ID4gaXNzdWVzDQo+ID4gPiA+ID4gPiBh DQo+ID4gPiA+ID4gPiA+ID4gc3BlY2lmaWMgZGV2aWNlLW1vZGVsIGNhbGwgdG8gcXVlcnkgWGVu IHRvIGluamVjdCBhDQo+ID4gPiBjb3JyZXNwb25kaW5nIFNQSQ0KPiA+ID4gPiA+ID4gdG8NCj4g PiA+ID4gPiA+ID4gPiB0aGUgZ3Vlc3QuDQo+ID4gPiA+ID4gPiA+ID4gPiA+DQo+ID4gPiA+ID4g PiA+ID4gPiA+DQo+ID4gPiA+ID4gPiA+ID4gPiA+DQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPg0K PiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiBDb3VsZCB3ZSBjb25zaWRlciB0aGUga2VybmVsIGlu dGVybmFsbHkgY29udmVydGluZw0KPiA+ID4gSU9SRVENCj4gPiA+ID4gPiA+ID4gPiBtZXNzYWdl cyBmcm9tDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+IHRoZSBYZW4gaHlwZXJ2aXNvciB0byBl dmVudGZkIGV2ZW50cz8gV291bGQgdGhpcw0KPiBzY2FsZQ0KPiA+ID4gd2l0aA0KPiA+ID4gPiA+ ID4gPiA+IG90aGVyIGtlcm5lbA0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiBoeXBlcmNhbGwg aW50ZXJmYWNlcz8NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4NCj4gPiA+ID4gPiA+ID4gPiA+ ID4gPiA+ID4gU28gYW55IHRob3VnaHRzIG9uIHdoYXQgZGlyZWN0aW9ucyBhcmUgd29ydGgNCj4g PiA+IGV4cGVyaW1lbnRpbmcNCj4gPiA+ID4gPiA+IHdpdGg/DQo+ID4gPiA+ID4gPiA+ID4gPiA+ ID4gPg0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gT25lIG9wdGlvbiB3ZSBzaG91bGQgY29uc2lk ZXIgaXMgZm9yIGVhY2ggYmFja2VuZCB0bw0KPiA+ID4gY29ubmVjdA0KPiA+ID4gPiA+ID4gdG8N Cj4gPiA+ID4gPiA+ID4gPiBYZW4gdmlhDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiB0aGUgSU9S RVEgaW50ZXJmYWNlLiBXZSBjb3VsZCBnZW5lcmFsaXplIHRoZSBJT1JFUQ0KPiA+ID4gaW50ZXJm YWNlDQo+ID4gPiA+ID4gPiBhbmQNCj4gPiA+ID4gPiA+ID4gPiBtYWtlIGl0DQo+ID4gPiA+ID4g PiA+ID4gPiA+ID4gPiBoeXBlcnZpc29yIGFnbm9zdGljLiBUaGUgaW50ZXJmYWNlIGlzIHJlYWxs eSB0cml2aWFsDQo+IGFuZA0KPiA+ID4gZWFzeQ0KPiA+ID4gPiA+ID4gdG8NCj4gPiA+ID4gPiA+ ID4gPiBhZGQuDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiBB cyBJIHNhaWQgYWJvdmUsIG15IHByb3Bvc2FsIGRvZXMgdGhlIHNhbWUgdGhpbmcgdGhhdA0KPiB5 b3UNCj4gPiA+ID4gPiA+IG1lbnRpb25lZA0KPiA+ID4gPiA+ID4gPiA+IGhlcmUgOikNCj4gPiA+ ID4gPiA+ID4gPiA+ID4gPiBUaGUgZGlmZmVyZW5jZSBpcyB0aGF0IEkgZG8gY2FsbCBoeXBlcnZp c29yIGludGVyZmFjZXMNCj4gdmlhDQo+ID4gPiA+ID4gPiB2aXJ0aW8tDQo+ID4gPiA+ID4gPiA+ ID4gcHJveHkuDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ IFRoZSBvbmx5IFhlbi1zcGVjaWZpYyBwYXJ0IGlzIHRoZSBub3RpZmljYXRpb24NCj4gbWVjaGFu aXNtLA0KPiA+ID4gPiA+ID4gd2hpY2ggaXMNCj4gPiA+ID4gPiA+ID4gPiBhbg0KPiA+ID4gPiA+ ID4gPiA+ID4gPiA+ID4gZXZlbnQgY2hhbm5lbC4gSWYgd2UgcmVwbGFjZWQgdGhlIGV2ZW50IGNo YW5uZWwgd2l0aA0KPiA+ID4gc29tZXRoaW5nDQo+ID4gPiA+ID4gPiA+ID4gZWxzZSB0aGUNCj4g PiA+ID4gPiA+ID4gPiA+ID4gPiA+IGludGVyZmFjZSB3b3VsZCBiZSBnZW5lcmljLiBTZWU6DQo+ ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiBodHRwczovL2dpdGxhYi5jb20veGVuLXByb2plY3QveGVu Ly0NCj4gPiA+ID4gPiA+ID4gPiAvYmxvYi9zdGFnaW5nL3hlbi9pbmNsdWRlL3B1YmxpYy9odm0v aW9yZXEuaCNMNTINCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+DQo+ID4gPiA+ID4gPiA+ID4gPiA+ ID4gPiBJIGRvbid0IHRoaW5rIHRoYXQgdHJhbnNsYXRpbmcgSU9SRVFzIHRvIGV2ZW50ZmQgaW4N Cj4gdGhlDQo+ID4gPiBrZXJuZWwNCj4gPiA+ID4gPiA+IGlzDQo+ID4gPiA+ID4gPiA+ID4gYQ0K PiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gZ29vZCBpZGVhOiBpZiBmZWVscyBsaWtlIGl0IHdvdWxk IGJlIGV4dHJhDQo+IGNvbXBsZXhpdHkNCj4gPiA+IGFuZCB0aGF0DQo+ID4gPiA+ID4gPiB0aGUN Cj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+IGtlcm5lbCBzaG91bGRuJ3QgYmUgaW52b2x2ZWQgYXMg dGhpcyBpcyBhIGJhY2tlbmQtDQo+ID4gPiBoeXBlcnZpc29yDQo+ID4gPiA+ID4gPiA+ID4gaW50 ZXJmYWNlLg0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+DQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gR2l2 ZW4gdGhhdCB3ZSBtYXkgd2FudCB0byBpbXBsZW1lbnQgQkUgYXMgYSBiYXJlLW1ldGFsDQo+ID4g PiA+ID4gPiBhcHBsaWNhdGlvbg0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+IGFzIEkgZGlkIG9uIFpl cGh5ciwgSSBkb24ndCB0aGluayB0aGF0IHRoZSB0cmFuc2xhdGlvbg0KPiA+ID4gd291bGQgbm90 DQo+ID4gPiA+ID4gPiBiZQ0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+IGEgYmlnIGlzc3VlLCBlc3Bl Y2lhbGx5IG9uIFJUT1Mncy4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiBJdCB3aWxsIGJlIHNvbWUg a2luZCBvZiBhYnN0cmFjdGlvbiBsYXllciBvZiBpbnRlcnJ1cHQNCj4gPiA+IGhhbmRsaW5nDQo+ ID4gPiA+ID4gPiA+ID4gPiA+ID4gKG9yIG5vdGhpbmcgYnV0IGEgY2FsbGJhY2sgbWVjaGFuaXNt KS4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPg0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gQWxzbywg ZXZlbnRmZCBpcyB2ZXJ5IExpbnV4LWNlbnRyaWMgYW5kIHdlIGFyZQ0KPiB0cnlpbmcgdG8NCj4g PiA+ID4gPiA+IGRlc2lnbiBhbg0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gaW50ZXJmYWNlIHRo YXQgY291bGQgd29yayB3ZWxsIGZvciBSVE9TZXMgdG9vLiBJZiB3ZQ0KPiA+ID4gd2FudCB0bw0K PiA+ID4gPiA+ID4gZG8NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+IHNvbWV0aGluZyBkaWZmZXJl bnQsIGJvdGggT1MtYWdub3N0aWMgYW5kDQo+IGh5cGVydmlzb3ItDQo+ID4gPiBhZ25vc3RpYywN Cj4gPiA+ID4gPiA+ID4gPiBwZXJoYXBzDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiB3ZSBjb3Vs ZCBkZXNpZ24gYSBuZXcgaW50ZXJmYWNlLiBPbmUgdGhhdCBjb3VsZCBiZQ0KPiA+ID4gPiA+ID4g aW1wbGVtZW50YWJsZQ0KPiA+ID4gPiA+ID4gPiA+IGluIHRoZQ0KPiA+ID4gPiA+ID4gPiA+ID4g PiA+ID4gWGVuIGh5cGVydmlzb3IgaXRzZWxmIChsaWtlIElPUkVRKSBhbmQgb2YgY291cnNlIGFu eQ0KPiA+ID4gb3RoZXINCj4gPiA+ID4gPiA+ID4gPiBoeXBlcnZpc29yDQo+ID4gPiA+ID4gPiA+ ID4gPiA+ID4gPiB0b28uDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPg0KPiA+ID4gPiA+ID4gPiA+ ID4gPiA+ID4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+IFRoZXJlIGlzIGFsc28gYW5vdGhlciBw cm9ibGVtLiBJT1JFUSBpcyBwcm9iYWJseSBub3QNCj4gYmUNCj4gPiA+IHRoZQ0KPiA+ID4gPiA+ ID4gb25seQ0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gaW50ZXJmYWNlIG5lZWRlZC4gSGF2ZSBh IGxvb2sgYXQNCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+IGh0dHBzOi8vbWFyYy5pbmZvLz9sPXhl bi1kZXZlbCZtPTE2MjM3Mzc1NDcwNTIzMyZ3PTIuDQo+ID4gPiBEb24ndCB3ZQ0KPiA+ID4gPiA+ ID4gPiA+IGFsc28gbmVlZA0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gYW4gaW50ZXJmYWNlIGZv ciB0aGUgYmFja2VuZCB0byBpbmplY3QgaW50ZXJydXB0cw0KPiBpbnRvDQo+ID4gPiB0aGUNCj4g PiA+ID4gPiA+ID4gPiBmcm9udGVuZD8gQW5kDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiBpZiB0 aGUgYmFja2VuZCByZXF1aXJlcyBkeW5hbWljIG1lbW9yeSBtYXBwaW5ncyBvZg0KPiA+ID4gZnJv bnRlbmQNCj4gPiA+ID4gPiA+IHBhZ2VzLA0KPiA+ID4gPiA+ID4gPiA+IHRoZW4NCj4gPiA+ID4g PiA+ID4gPiA+ID4gPiA+IHdlIHdvdWxkIGFsc28gbmVlZCBhbiBpbnRlcmZhY2UgdG8gbWFwL3Vu bWFwIGRvbVUNCj4gcGFnZXMuDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4NCj4gPiA+ID4gPiA+ID4g PiA+ID4gPiBNeSBwcm9wb3NhbCBkb2N1bWVudCBtaWdodCBoZWxwIGhlcmU7IEFsbCB0aGUNCj4g aW50ZXJmYWNlcw0KPiA+ID4gPiA+ID4gcmVxdWlyZWQNCj4gPiA+ID4gPiA+ID4gPiBmb3INCj4g PiA+ID4gPiA+ID4gPiA+ID4gPiB2aXJ0aW8tcHJveHkgKG9yIGh5cGVydmlzb3ItcmVsYXRlZCBp bnRlcmZhY2VzKSBhcmUNCj4gbGlzdGVkDQo+ID4gPiBhcw0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ IFJQQyBwcm90b2NvbHMgOikNCj4gPiA+ID4gPiA+ID4gPiA+ID4gPg0KPiA+ID4gPiA+ID4gPiA+ ID4gPiA+ID4gVGhlc2UgaW50ZXJmYWNlcyBhcmUgYSBsb3QgbW9yZSBwcm9ibGVtYXRpYyB0aGFu DQo+IElPUkVROg0KPiA+ID4gSU9SRVENCj4gPiA+ID4gPiA+IGlzDQo+ID4gPiA+ID4gPiA+ID4g dGlueQ0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gYW5kIHNlbGYtY29udGFpbmVkLiBJdCBpcyBl YXN5IHRvIGFkZCBhbnl3aGVyZS4gQQ0KPiBuZXcNCj4gPiA+ID4gPiA+IGludGVyZmFjZSB0bw0K PiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gaW5qZWN0IGludGVycnVwdHMgb3IgbWFwIHBhZ2VzIGlz IG1vcmUgZGlmZmljdWx0IHRvDQo+ID4gPiBtYW5hZ2UNCj4gPiA+ID4gPiA+IGJlY2F1c2UNCj4g PiA+ID4gPiA+ID4gPiBpdA0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gd291bGQgcmVxdWlyZSBj aGFuZ2VzIHNjYXR0ZXJlZCBhY3Jvc3MgdGhlIHZhcmlvdXMNCj4gPiA+IGVtdWxhdG9ycy4NCj4g PiA+ID4gPiA+ID4gPiA+ID4gPg0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+IEV4YWN0bHkuIEkgaGF2 ZSBubyBjb25maWRlbnQgeWV0IHRoYXQgbXkgYXBwcm9hY2ggd2lsbA0KPiA+ID4gYWxzbw0KPiA+ ID4gPiA+ID4gYXBwbHkNCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiB0byBvdGhlciBoeXBlcnZpc29y cyB0aGFuIFhlbi4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiBUZWNobmljYWxseSwgeWVzLCBidXQg d2hldGhlciBwZW9wbGUgY2FuIGFjY2VwdCBpdCBvcg0KPiBub3QNCj4gPiA+IGlzIGENCj4gPiA+ ID4gPiA+ID4gPiBkaWZmZXJlbnQNCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiBtYXR0ZXIuDQo+ID4g PiA+ID4gPiA+ID4gPiA+ID4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiBUaGFua3MsDQo+ID4gPiA+ ID4gPiA+ID4gPiA+ID4gLVRha2FoaXJvIEFrYXNoaQ0KPiA+ID4gPiA+ID4gPiA+ID4gPg0KPiA+ ID4gPiA+ID4gPiA+ID4gPg0KPiA+ID4gPiA+ID4gPiA+ID4gPg0KPiA+ID4gPiA+ID4gPiA+ID4g PiAtLQ0KPiA+ID4gPiA+ID4gPiA+ID4gPiBSZWdhcmRzLA0KPiA+ID4gPiA+ID4gPiA+ID4gPg0K PiA+ID4gPiA+ID4gPiA+ID4gPiBPbGVrc2FuZHIgVHlzaGNoZW5rbw0KPiA+ID4gPiA+ID4gPiA+ ID4gSU1QT1JUQU5UIE5PVElDRTogVGhlIGNvbnRlbnRzIG9mIHRoaXMgZW1haWwgYW5kIGFueQ0K PiA+ID4gYXR0YWNobWVudHMgYXJlDQo+ID4gPiA+ID4gPiA+ID4gY29uZmlkZW50aWFsIGFuZCBt YXkgYWxzbyBiZSBwcml2aWxlZ2VkLiBJZiB5b3UgYXJlIG5vdCB0aGUNCj4gPiA+IGludGVuZGVk DQo+ID4gPiA+ID4gPiA+ID4gcmVjaXBpZW50LCBwbGVhc2Ugbm90aWZ5IHRoZSBzZW5kZXIgaW1t ZWRpYXRlbHkgYW5kIGRvIG5vdA0KPiA+ID4gZGlzY2xvc2UNCj4gPiA+ID4gPiA+IHRoZQ0KPiA+ ID4gPiA+ID4gPiA+IGNvbnRlbnRzIHRvIGFueSBvdGhlciBwZXJzb24sIHVzZSBpdCBmb3IgYW55 IHB1cnBvc2UsIG9yDQo+IHN0b3JlDQo+ID4gPiBvciBjb3B5DQo+ID4gPiA+ID4gPiB0aGUNCj4g PiA+ID4gPiA+ID4gPiBpbmZvcm1hdGlvbiBpbiBhbnkgbWVkaXVtLiBUaGFuayB5b3UuDQo+ID4g PiA+ID4gPiA+IElNUE9SVEFOVCBOT1RJQ0U6IFRoZSBjb250ZW50cyBvZiB0aGlzIGVtYWlsIGFu ZCBhbnkNCj4gYXR0YWNobWVudHMNCj4gPiA+IGFyZQ0KPiA+ID4gPiA+ID4gY29uZmlkZW50aWFs IGFuZCBtYXkgYWxzbyBiZSBwcml2aWxlZ2VkLiBJZiB5b3UgYXJlIG5vdCB0aGUNCj4gaW50ZW5k ZWQNCj4gPiA+ID4gPiA+IHJlY2lwaWVudCwgcGxlYXNlIG5vdGlmeSB0aGUgc2VuZGVyIGltbWVk aWF0ZWx5IGFuZCBkbyBub3QNCj4gZGlzY2xvc2UNCj4gPiA+IHRoZQ0KPiA+ID4gPiA+ID4gY29u dGVudHMgdG8gYW55IG90aGVyIHBlcnNvbiwgdXNlIGl0IGZvciBhbnkgcHVycG9zZSwgb3Igc3Rv cmUNCj4gb3INCj4gPiA+IGNvcHkgdGhlDQo+ID4gPiA+ID4gPiBpbmZvcm1hdGlvbiBpbiBhbnkg bWVkaXVtLiBUaGFuayB5b3UuDQo+ID4gPiA+ID4gSU1QT1JUQU5UIE5PVElDRTogVGhlIGNvbnRl bnRzIG9mIHRoaXMgZW1haWwgYW5kIGFueSBhdHRhY2htZW50cw0KPiBhcmUNCj4gPiA+IGNvbmZp ZGVudGlhbCBhbmQgbWF5IGFsc28gYmUgcHJpdmlsZWdlZC4gSWYgeW91IGFyZSBub3QgdGhlIGlu dGVuZGVkDQo+ID4gPiByZWNpcGllbnQsIHBsZWFzZSBub3RpZnkgdGhlIHNlbmRlciBpbW1lZGlh dGVseSBhbmQgZG8gbm90IGRpc2Nsb3NlDQo+IHRoZQ0KPiA+ID4gY29udGVudHMgdG8gYW55IG90 aGVyIHBlcnNvbiwgdXNlIGl0IGZvciBhbnkgcHVycG9zZSwgb3Igc3RvcmUgb3IgY29weQ0KPiB0 aGUNCj4gPiA+IGluZm9ybWF0aW9uIGluIGFueSBtZWRpdW0uIFRoYW5rIHlvdS4NCj4gPiBJTVBP UlRBTlQgTk9USUNFOiBUaGUgY29udGVudHMgb2YgdGhpcyBlbWFpbCBhbmQgYW55IGF0dGFjaG1l bnRzIGFyZQ0KPiBjb25maWRlbnRpYWwgYW5kIG1heSBhbHNvIGJlIHByaXZpbGVnZWQuIElmIHlv dSBhcmUgbm90IHRoZSBpbnRlbmRlZA0KPiByZWNpcGllbnQsIHBsZWFzZSBub3RpZnkgdGhlIHNl bmRlciBpbW1lZGlhdGVseSBhbmQgZG8gbm90IGRpc2Nsb3NlIHRoZQ0KPiBjb250ZW50cyB0byBh bnkgb3RoZXIgcGVyc29uLCB1c2UgaXQgZm9yIGFueSBwdXJwb3NlLCBvciBzdG9yZSBvciBjb3B5 IHRoZQ0KPiBpbmZvcm1hdGlvbiBpbiBhbnkgbWVkaXVtLiBUaGFuayB5b3UuDQo= From xen-devel-bounces@lists.xenproject.org Wed Sep 01 11:48:40 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Sep 2021 11:48:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.176318.320841 (Exim 4.92) (envelope-from ) id 1mLOiv-00061F-Kd; Wed, 01 Sep 2021 11:48:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 176318.320841; Wed, 01 Sep 2021 11:48:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLOiv-000618-Hd; Wed, 01 Sep 2021 11:48:09 +0000 Received: by outflank-mailman (input) for mailman id 176318; Wed, 01 Sep 2021 11:48:08 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLOit-00060y-Ue; Wed, 01 Sep 2021 11:48:07 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLOit-00011v-Q6; Wed, 01 Sep 2021 11:48:07 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLOit-0000tK-J8; Wed, 01 Sep 2021 11:48:07 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mLOit-0005bE-If; Wed, 01 Sep 2021 11:48:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=3Rth7U/q/9bvQyAWjxieMb40Jd1LEppkXg3cKsRDZKE=; b=GBEXuN4lTf+PAfqrqB9EZfD9aw z15VSt3PWfUQMhFb4MCtWuNjhl1unGaf2QA0C7JGudjddR4f3y8XRT71fUDfPZ1q8J1aByZMgWKPA 06CNla7KiNgyV3lTcNOakzZ0wP+tcyEmrttVxLRd7rDg8mY+l4VNan0r8S4o56nrwlQU=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 164688: regressions - FAIL X-Osstest-Failures: libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=a4785a1ea58a59c6ee14619b9bbeb4856eaf8175 X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Wed, 01 Sep 2021 11:48:07 +0000 flight 164688 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/164688/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a version targeted for testing: libvirt a4785a1ea58a59c6ee14619b9bbeb4856eaf8175 baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 418 days Failing since 151818 2020-07-11 04:18:52 Z 417 days 408 attempts Testing same since 164688 2021-09-01 04:20:58 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Andika Triwidada Andrea Bolognani Balázs Meskó Barrett Schonefeld Bastian Germann Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Bjoern Walk Boris Fiuczynski Brian Turek Bruno Haible Chris Mayo Christian Ehrhardt Christian Kirbach Christian Schoenebeck Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé Didik Supriadi Dmytro Linkin Eiichi Tsukata Eric Farman Erik Skultety Fabian Affolter Fabian Freyer Fabiano Fidêncio Fangge Jin Farhan Ali Fedora Weblate Translation gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Hela Basa Helmut Grohne Ian Wienand Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen Jean-Baptiste Holcroft Jia Zhou Jianan Gao Jim Fehlig Jin Yan Jinsheng Zhang Jiri Denemark John Ferlan Jonathan Watt Jonathon Jongsma Julio Faracco Justin Gatzen Ján Tomko Kashyap Chamarthy Kevin Locke Kristina Hanicova Laine Stump Laszlo Ersek Lee Yarwood Liao Pingfang Lin Ma Lin Ma Lin Ma Liu Yiding Luke Yue Luyao Zhong Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Markus Schade Martin Kletzander Masayoshi Mizuma Matej Cepl Matt Coleman Matt Coleman Mauro Matteo Cascella Meina Li Michal Privoznik Michał Smyk Milo Casagrande Moshe Levi Muha Aliss Nathan Neal Gompa Nick Shyrokovskiy Nickys Music Group Nico Pache Nikolay Shirokovskiy Olaf Hering Olesya Gerasimenko Orion Poplawski Pany Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Richard W.M. Jones Ricky Tigg Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Shambarger Sebastian Mitterle SeongHyun Jo Shalini Chellathurai Saroja Shaojun Yang Shi Lei simmon Simon Chopin Simon Gaiser Simon Rowe Stefan Bader Stefan Berger Stefan Berger Stefan Hajnoczi Szymon Scholz Thomas Huth Tim Wiederhake Tomáš Golembiovský Tomáš Janoušek Tuguoyi Ville Skyttä Vinayak Kale Wang Xin WangJian Weblate Wei Liu Wei Liu William Douglas Yalei Li <274268859@qq.com> Yalei Li Yang Fei Yang Hang Yanqiu Zhang Yaroslav Kargin Yi Li Yi Wang Yuri Chornoivan Zbigniew Jędrzejewski-Szmek zhangjl02 Zheng Chuan zhenwei pi Zhenyu Ye Zhenyu Zheng Zhenzhong Duan jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 71454 lines long.) From xen-devel-bounces@lists.xenproject.org Wed Sep 01 11:49:53 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Sep 2021 11:49:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.176325.320855 (Exim 4.92) (envelope-from ) id 1mLOkb-0006as-0o; Wed, 01 Sep 2021 11:49:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 176325.320855; Wed, 01 Sep 2021 11:49:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLOka-0006al-U5; Wed, 01 Sep 2021 11:49:52 +0000 Received: by outflank-mailman (input) for mailman id 176325; Wed, 01 Sep 2021 11:49:50 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLOkY-0006ab-LS for xen-devel@lists.xenproject.org; Wed, 01 Sep 2021 11:49:50 +0000 Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id b5789470-0b1a-11ec-adcd-12813bfff9fa; Wed, 01 Sep 2021 11:49:49 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b5789470-0b1a-11ec-adcd-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1630496989; h=to:cc:references:from:subject:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=35SwvRjjqZ2KnuTWfd6fU16T0czSr0GGQW4+FbwuguA=; b=D/rmxfz8wodF7lzhzF55kz0snDFbLU9ZywLVWwCLEkKo9S7141kVq894 DjGbkPoHx1V4f90freWZsUCdfBdLU771TZP55Z8RwMEUrIdPDbA11LPB0 Bk+abGn6Co1sp4EVKLlXwLeYoAfayCwiXFWxgEQKPVd8+iX0njGaZv0F+ M=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: Tt9abo8Jh6bH658YlIkLPZtE83hkPRUjbi68J1FQIjXHyvupdzQ97k/6MOLc/WCgito3LGKiIG 1NsRBVcjwaNxXNbAZDhSfPy6Iw0swWH4mb6C6nXyI49fieD09Jzk/LGfKGhkUBTSLAzmtJO9KK gmrBQ0FI6gynknTMTWvPUPXSZq8Lpf87XXQ6/CaE7DjI5+5YrQ2dM2+salV1AxkaICYgTVqix8 L27fhgILjctj+POvhFWi8BhhsCvfBlxMwRCkw6D+ACesd93Jh9lqRPWy35p363l1uhXpdokpW0 qyF2EbTliryKgiPVC/pYcaQf X-SBRS: 5.1 X-MesageID: 53523089 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:8i7vcK0NYLSmBIeU/mjBLgqjBTJyeYIsimQD101hICG9Lfb3qy n+ppsmPEHP5Ar5OEtBpTiBUJPwJU80hqQFn7X5Wo3SIzUO2VHYUL2KiLGC/9SOIVyEygcw79 YHT0E6MqyMMbEYt7eI3ODbKadZ/DDvysnB7o2yvhQdL3AeV0gj1XYfNu/yKDwHeOAsP+tBKH Pz3Lsjm9PtQwVsUiztbUN1LtQr6ue72q7OUFojPVoK+QOOhTSn5PrTFAWZ5A4XV3dqza05+W bIvgTl7uH72svLiiP05iv21dB7idHhwtxMCIiljdUUECzljkKNaJ56U7OPkTgpqKWE6Uoskv PLvxA8Vv4Dqk/5TyWQm1/AygPg2DEh5zvLzkKZu2LqpYjDSDczG6N69M9kWyqcz3BlkMB30a pN0W7cnYFQFwn8kCP04MWNfw12l2KvyEBS1NI7vjh6a88zebVRpYsQ8Ad+C5EbBh/374ghDa 1HENzc3vBLalmXBkqp/FWH+ObcGUjbIy32BHTr4qeuomFrdTFCvgglLfUk7zM9HMlXcegd2w ysWZ4Y5o2nTactHOhA7ak6MJCK4sGke2OEDIuoGyWRKEgwAQOHl3fG2sRA2AiUQu1/8HITou WMbLoKjx98R6rRYff+lKGjtCq9GlmAYQ== X-IronPort-AV: E=Sophos;i="5.84,369,1620705600"; d="scan'208";a="53523089" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PPZbS1jOrRpOst6n+6nM+/o7uOL1PHvVU96Xn1xsOp7V6/xuFQWZLgU1xg1cFjEniKOOedkju+UIUNNJMh5vtdRH56wUU3x2mCkfuor/mgvx3kLvcs9xjlPSpJ/l653pm55ww272tFRlzfaoKmcgIPyxmtO0WUVoILsg9sZ2wHs0ljklugi1JddWC6ogo0ZgRcXDpTlyAiT3Tx3sNhE8ByXoL+pG/l8vMHZPI5OE+fndV4xZqjozjGLUgZV1AUJouvY8DWYBfHhVwUGZjaAfcHmoQMagbGrupJA/dVVC/ngjbxYrz3ABxu62deUnyqPvvQ9av9n0SkCgcBnE64SuRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=cKjO7PQGRNxGgIvaAymBw9Wc66auu2P0CgYv89Iupg4=; b=QBwBcrcwv/kk/NQ+wrBHuDoE7zNr/28C5XmKa/55gMcYTPcAnjUxCNaoG2nG+Pvx5sUBp1k4SRa8YasxjUCrAo78hrkFfdNPDBaoscE0k9/2HPs/K/4k4y9xyG9SbVrbKFZ/4E4mPIL0ftTtq3KsS2HiIdL8bdOVvZ87YFylEfnmiSCFOaSoYIlChOS9w1k7SBq/MVh7+fYGn3Zs/oObaLMCwAJ2r8xu8Oky/AZj6NkmYQqCO7dHcbyPSSsVq0ItOprT4OetvT9jSsVxO2YTD16Hdw3DTl0tAPycMfVyGryigTC6F3QjseMMH/zBL+7I388N4XMjuaRdNfArYyE8Mg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cKjO7PQGRNxGgIvaAymBw9Wc66auu2P0CgYv89Iupg4=; b=SLHwyq6PSzue0yxO+Chmeh6OVKBD6amNIqCv6VwOZYb6yx9gn0QMMcwvG4LXX8ceHv7W2/S9OEFmccj59h6qm/TejXSxw/P3LQ8F0EMM0+Rx8w40W/OKWDZ7M0t6amlo76EC2IBZu3w4BTrnNeSADnaPuZgDeLocoqxhPXUJVHA= To: Jan Beulich CC: Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , "xen-devel@lists.xenproject.org" References: <013c49f5-7a14-9d9e-4d25-75934bf6349f@suse.com> <9cfc122f-dc4e-9dc0-0b57-48abf941025a@citrix.com> <866a3677-1f1a-e0e5-7ab0-10c210e25610@suse.com> <2265ca67-2a30-a858-38ba-a6343782929e@suse.com> <2ef761cf-e609-e0df-e360-9e904f5ad9a2@citrix.com> From: Andrew Cooper Subject: Re: [PATCH 1/4] x86/PVH: de-duplicate mappings for first Mb of Dom0 memory Message-ID: <96563cf3-4c99-520e-99d4-68bf98ef46a2@citrix.com> Date: Wed, 1 Sep 2021 12:49:35 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: en-GB X-ClientProxiedBy: LO4P123CA0339.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18c::20) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4fa0e4f4-e39b-442c-f827-08d96d3e9588 X-MS-TrafficTypeDiagnostic: BY5PR03MB5045: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2276; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VdDZsNlVRE/GOg6HbW5K4gdbEeLHaCClLtf7HYeElVkHygl1MzxpTUU2eMsVOAOorQR+NlJUJrnC6iTG5RHdMaqRUb3Pju/rr1Gaj/Ezte2ORlCnh4LHV7yldAEHA/siwrXu/j3A1/SaItvM5VR/RDvweaa8FCJNwy9brSbp/NeVMs/O7ExCyTi4DOIzCE7M4FbKtJPV7LGkDRPLZqTuvyl41yVHwBfi70zbFioka8bPK88kf7Ow3t/QjryAGHO9/zz30AZbGHnI/4CPev165uQRgaQ3prQDxuAqh8ak3ntWaQtXtIW1GF4mucVKprQOvYFNXgLa18Kkd64Lxh2xTtW4kQbl39i7B1X4PkhqFcxDtJFgPF1olrKDtsahkykES7kfbK3NFk9tpDca7NNhz8DlDWZPxKKfmjNauVUwq1ETLGGwfpceoexhefLGcYn5c2fP+aH1dLpzM3wjJk1OzmBNx76/+L4EDAe/TxuFKrkqT+nLYz0zgw0P39PJ7tMq3PxiI2JPGscg1XHMuZ/Vjaci9L0sfBPOn4z7V0Zmzu5OstCKOlj6li1URdSYpirbQIVxSS+6fFtaJF3OCrC+Vkm90W0l45kbJQMBocaNqSv5r0L6gTfgdHsgibJsq/zDgnD6jMuOStZMMyTDUD+DbmbDLdDWKdQS/0DGwaCHdYU/OKIBU2eWW4jogFe6uEBf/7s0/XqBDVFHeGWwzq+5U0ab6xDQLq1PjPL6OpX3z3g= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(6486002)(956004)(38100700002)(54906003)(2616005)(16576012)(6916009)(66476007)(86362001)(31686004)(31696002)(508600001)(6666004)(8936002)(36756003)(8676002)(2906002)(53546011)(55236004)(66946007)(186003)(26005)(316002)(4326008)(66556008)(5660300002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WVJYSjl3WjFiYmpOUzJodTM2R21TeVVlQWdrOHc3M3Z4d2duOHpQZ0RWMmFY?= =?utf-8?B?a1NYbkRVWWVvNkdBMnJVZllNUjIzS0laU0FxWVJBSXdrbVhlRFNnM0ZFQi9a?= =?utf-8?B?cit2NmRKTXA5UWc3SHV5NDlPV1pHYmxtejlOWFZpak5YN0tta2FuSmprc1RK?= =?utf-8?B?Ty9IY05iTlZtYmJUSjFNRGJCU2RObVVXUnlWZGsrNm1oYnkyVndVZzFtbHgx?= =?utf-8?B?Vk1vMTdnd2psb0NEd1pBQVBxRC90RTZtSTB5L2ZWUU9McjVqWEtwSDRJNFBu?= =?utf-8?B?SWREV20vN2RMVkNLZWUxemNRTDVaYU9wOHlOd1M4R2JuQjdCam5oL0pRQXlo?= =?utf-8?B?OU1CYnZmYmdwOWNmU2h6NXgrUkZTeDBHZE9WQlJSQVRoQTdxdFdSc1BqWFY3?= =?utf-8?B?T0FpSnQreDhoQ1hDTlhhUnJndXBJWTEvSkxkRzJlaE5DWVgyUDZJWjlBQUNq?= =?utf-8?B?MTFEQjc0RU5tODloRUNXeFlZZ1JZZ0syamtIbDBlNHU0ZWxWOTM5TkpOT2ZX?= =?utf-8?B?YkErTjZQQWZzYUV6SkhOMnRwcSs2U1d1R1dhTk8wY2VOd05NbndvSm5ESzQy?= =?utf-8?B?VXZqZHBzQ3NndzRXbTQ1bVRsZDJtNXZYS0JuWGNCdERDbytOWUVvVzFZK08v?= =?utf-8?B?VTZwaDRteGhBOHY1UFVseE43eDZWbzVKcXJjUUQvSUpNZ0YrSWhaWDR4ZVpT?= =?utf-8?B?RkY3RlFCUjlVdjdLUGFFNWVKRDhsR0w1UFJGcTNJZzk4N2FOWGV1Q1ZzL2JC?= =?utf-8?B?ckllS25ROGdqTDdsWkZqdzN6TTd1MmNnN0RDc04wWU5KVUpPT01DUFhybitG?= =?utf-8?B?TWR6bURET3ZzSlN6cFBLYTJmQWM3bitPZ2FkT2tOTEJnTklLT2U4WWdNNmV0?= =?utf-8?B?b3p4a1Z5STNkNlc3YUNuUTVMaE1YWGI4YjhQRDUrazNQeHJDS1g4bDl3dklk?= =?utf-8?B?SkJ0bUc0Wktta1Fad2ZRVkRNV1JVN2JYZVl2d0NLbmFQVTNMNUtBZXlWaUs2?= =?utf-8?B?Z1VtVG95QlBLMkQ1MVpqUWxCdXdtR2syS0dVdnF0MjdjY2dJTUJCT0l0Q3ZJ?= =?utf-8?B?bzZOUnJnTWRqenlpVzdZSXY4OWVQRW9xeFhiUHlqVlBwaFBrUGMwd1owYWU4?= =?utf-8?B?MEVnSmxyVCtLcTBVL25pRHcxUTRMdmM1RFA4MHExdGpQSVFURmhpc0xOY3Rh?= =?utf-8?B?WmJ0NHNSTlpuZGdnWm1SVGEzbGRiV3Z4SU8vN1VHb1FER21kZ2x5bkV2YnVl?= =?utf-8?B?TmtvSm5XOHFZc1d6a1phV2NKTmczWCtrNWRBT0FQd0tQYXdMUXNDWlV0b2Vi?= =?utf-8?B?YmRUY3NLRk5MQXdKV2tFWXZBU2JXZWs0bHA2QSswVXNmYkZVL0ZpcFBEbTZl?= =?utf-8?B?NUs4VTdsenhRVncxSTNhMkhVa1c4dTdRblhHUEhCUTN1Mk9GTGtST2phOUlP?= =?utf-8?B?SlVzbGtBTWwzMW9HdUFJdzIrUmJ5K1Ezd3U0Rjc1aDUxYi91eERBMCs5SGta?= =?utf-8?B?YVZ5WDloOEs5SFdIKzNiMnFFSG9sTUFyVE1Ud1RjOVc1WXRZMFkyRmFCd2tt?= =?utf-8?B?dUd2YVE0M2ZqUXhhRy9obkdOZ2hSbXZhMFZNRVhKZ3lQaDQ1RUk1Y1I4WGV3?= =?utf-8?B?eXI0QU4wUkRLZXMxeXhRWW1YTmZFS0dRM25NMUpWa2FTdjRDNXRTeThwUVpw?= =?utf-8?B?dnlwbGx4MHNEczhtNHZrbTJRZnFPcjlBMXlSakE1cHFqTGZwTDJQSWRTcUtt?= =?utf-8?Q?fOW478VM6qY5eO1FIm04AOT2dYkgv0+/rAg1fNE?= X-MS-Exchange-CrossTenant-Network-Message-Id: 4fa0e4f4-e39b-442c-f827-08d96d3e9588 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Sep 2021 11:49:41.5226 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: lHMNK6NdFOd2YA85XwjNKIBtMBOILlhob2fYU5wmHUxbIsblrzafj2ySPylL/k1FtwPEwaRV1dufV+uUl/y/ApknV9uhfHEch3gi9sUNuIQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR03MB5045 X-OriginatorOrg: citrix.com On 31/08/2021 14:36, Jan Beulich wrote: > On 31.08.2021 15:27, Andrew Cooper wrote: >> On 31/08/2021 14:19, Jan Beulich wrote: >>>>>> @@ -1095,6 +1101,17 @@ static int __init pvh_setup_acpi(struct >>>>>> nr_pages =3D PFN_UP((d->arch.e820[i].addr & ~PAGE_MASK) + >>>>>> d->arch.e820[i].size); >>>>>> =20 >>>>>> + /* Memory below 1MB has been dealt with by pvh_populate_p2m= (). */ >>>>>> + if ( pfn < PFN_DOWN(MB(1)) ) >>>>>> + { >>>>>> + if ( pfn + nr_pages <=3D PFN_DOWN(MB(1)) ) >>>>>> + continue; >>>>>> + >>>>>> + /* This shouldn't happen, but is easy to deal with. */ >>>>> I'm not sure this comment is helpful. >>>>> >>>>> Under PVH, there is nothing special about the 1M boundary, and we can >>>>> reasonably have something else here or crossing the boundary. >>>> As long as we have this special treatment of the low Mb, the boundary >>>> is meaningful imo. I'd see the comment go away when the handling in >>>> general gets streamlined. >>> I should have added: And as long as Dom0's E820 map gets cloned from >>> the host's, which will necessarily consider the 1Mb boundary special. >> Not when you're booting virtualised in the first place. > You mean when Xen itself runs in PVH (not HVM) mode, and then in turn > has a PVH Dom0? And if the underlying Xen has not in turn cloned > the E820 from the host's? That's surely too exotic a case to warrant > removing this comment. If you insist, I can mention that case as a > possible exception. It's a long way from exotic. Also the magic surrounding the 1M boundary is disappearing on real hardware with legacy BIOS support being dropped from platforms. The comment is misleading and should be dropped.=C2=A0 The logic is still perfectly clear given the outer comment. ~Andrew From xen-devel-bounces@lists.xenproject.org Wed Sep 01 12:27:24 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Sep 2021 12:27:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.176337.320878 (Exim 4.92) (envelope-from ) id 1mLPKZ-00031d-7L; Wed, 01 Sep 2021 12:27:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 176337.320878; Wed, 01 Sep 2021 12:27:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLPKZ-00031W-44; Wed, 01 Sep 2021 12:27:03 +0000 Received: by outflank-mailman (input) for mailman id 176337; Wed, 01 Sep 2021 12:27:01 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLPKX-00031M-Q0; Wed, 01 Sep 2021 12:27:01 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLPKX-0001j2-Le; Wed, 01 Sep 2021 12:27:01 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLPKX-0002HD-A4; Wed, 01 Sep 2021 12:27:01 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mLPKX-0004SF-9W; Wed, 01 Sep 2021 12:27:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=cehNK+/L30sbac4CFO5mJJ2ywt8vH27tObIs9axzprU=; b=NyMQjXNtnYgKgzDCAdnFH7cYPK agFkt85cURMY1ZKorjCaKMSH6GgY19xlQ/QgpgQr10YDdFQrZ1xD0tvMqbakRtFGOhDgex8YQKSCv k5PFfQ+qOf5YIzKbHYtP0EKr7Z04/ybjV51rfwBenZdIgrN7JOEX4RW5TbRdpdVuu/dk=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 164695: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=b170806518c1e414939c8b085866544814e1ce8e X-Osstest-Versions-That: ovmf=cae735f61328d64e2e8991036707b9e78c0f5f63 From: osstest service owner Date: Wed, 01 Sep 2021 12:27:01 +0000 flight 164695 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/164695/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 164674 build-amd64-xsm 6 xen-build fail REGR. vs. 164674 build-i386-xsm 6 xen-build fail REGR. vs. 164674 build-i386 6 xen-build fail REGR. vs. 164674 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf b170806518c1e414939c8b085866544814e1ce8e baseline version: ovmf cae735f61328d64e2e8991036707b9e78c0f5f63 Last test of basis 164674 2021-08-31 02:56:52 Z 1 days Failing since 164686 2021-09-01 03:03:43 Z 0 days 2 attempts Testing same since 164695 2021-09-01 10:40:04 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Anthony PERARD DunTan Gary Lin Jim Fehlig Lin, Gary (HPS OE-Linux) Mark Wilson Marvin H?user Wenxing Hou jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit b170806518c1e414939c8b085866544814e1ce8e Author: Mark Wilson Date: Fri Nov 13 08:05:18 2020 +0800 UefiCpuPkg: Clean up save state boundary checks and comments. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2956 In functions ReadSaveStateRegisterByIndex and WriteSaveStateRegister: * check width > 4 instead of >= 4 when writing upper 32 bytes. - This improves the code but will not affect functionality. Cc: Eric Dong Reviewed-by: Ray Ni Signed-off-by: Mark Wilson commit 3b3f88228812e2c642eea8746858a4dad928ebf7 Author: Marvin H?user Date: Mon Aug 9 14:09:25 2021 +0800 MdeModulePkg/PiSmmCore: Drop deprecated image profiling commands The legacy codebase allowed SMM images to be registered for profiling from DXE. Support for this has been dropped entirely, so remove the remaining handlers. Cc: Jian J Wang Cc: Hao A Wu Cc: Eric Dong Reviewed-by: Ray Ni Cc: Vitaly Cheptsov Signed-off-by: Marvin H?user commit cdda3f74a1327663a5d48cca13507085ba403af7 Author: Marvin H?user Date: Mon Aug 9 03:39:53 2021 +0800 UefiPayloadPkg/UefiPayloadEntry: Fix memory corruption UefiPayloadEntry's AllocatePool() applies the "sizeof" operator to HOB index rather than the HOB header structure. This yields 4 Bytes compared to the 8 Bytes the structure header requires. Fix the call to allocate the required space instead. Reviewed-by: Guo Dong Reviewed-by: Ray Ni Cc: Maurice Ma Cc: Benjamin You Cc: Vitaly Cheptsov Signed-off-by: Marvin H?user commit 5d34cc49d5d348012fe8acf9fb618826bd541a7c Author: Wenxing Hou Date: Tue Aug 24 16:11:11 2021 +0800 UefiCpuPkg/PiSmmCpuDxeSmm: Update mPatchCetSupported set condition REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3584 Function AsmCpuid should first check the value for Basic CPUID Information. The fix is to update the mPatchCetSupported judgment statement. Signed-off-by: Wenxing Hou Reviewed-by: Ray Ni Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Cc: Sheng W Cc: Yao Jiewen commit f0fe55bca4651734abf1752a1d7c69fb5bee00b9 Author: duntan Date: Fri Aug 20 13:04:29 2021 +0800 UefiPayloadPkg: Fix the build error when enable Core ci for UefiPayloadPkg V1: Add quotes when using $(ARCH) in .dsc and .fdf file. The quotes are added due to the way by which Core ci parse the .dsc file. Add UINTN in Hob.c to fix cast from pointer to integer of different size error. V2: Delete lines which reference ShellBinPkg.The pkg doesn't exist in edk2. Cc: Guo Dong Cc: Ray Ni Cc: Maurice Ma Cc: Benjamin You Signed-off-by: DunTan Reviewed-by: Ray Ni commit 9f3eda177a4b2d4a33ff1b0307cad42906396562 Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:29:48 2021 +0800 OvmfPkg/OvmfXen: add QemuKernelLoaderFsDxe Without QemuKernelLoaderFsDxe, QemuLoadKernelImage() couldn't download the kernel, initrd, and kernel command line from QEMU's fw_cfg. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3574 Signed-off-by: Gary Lin Acked-by: Anthony PERARD Reviewed-by: Philippe Mathieu-Daude Reviewed-by: Gerd Hoffmann Tested-by: Jim Fehlig commit 5b5f10d7465004e3e40ec1f50a3b490b4db595e7 Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:31:15 2021 +0800 OvmfPkg/SmmControl2Dxe: use PcdAcpiS3Enable to detect S3 support To avoid the potential inconsistency between PcdAcpiS3Enable and QemuFwCfgS3Enabled(), this commit modifies SmmControl2Dxe to detect S3 support by PcdAcpiS3Enable as modules in MdeModulePkg do. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3573 Signed-off-by: Gary Lin Reviewed-by: Gerd Hoffmann Reviewed-by: Jiewen Yao Tested-by: Jim Fehlig commit 52e2dabc0f8d3af09c213072ce8ba734302f585d Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:31:14 2021 +0800 OvmfPkg/PlatformBootManagerLib: use PcdAcpiS3Enable to detect S3 support To avoid the potential inconsistency between PcdAcpiS3Enable and QemuFwCfgS3Enabled(), this commit modifies PlatformBootManagerLib to detect S3 support by PcdAcpiS3Enable as modules in MdeModulePkg do. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3573 Signed-off-by: Gary Lin Reviewed-by: Gerd Hoffmann Reviewed-by: Jiewen Yao Tested-by: Jim Fehlig commit 28152333bccb778b62e6e97446b28bfa0e92ef82 Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:31:13 2021 +0800 OvmfPkg/LockBoxLib: use PcdAcpiS3Enable to detect S3 support To avoid the potential inconsistency between PcdAcpiS3Enable and QemuFwCfgS3Enabled(), this commit modifies LockBoxLib to detect S3 support by PcdAcpiS3Enable as modules in MdeModulePkg do. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3573 Signed-off-by: Gary Lin Reviewed-by: Philippe Mathieu-Daude Reviewed-by: Gerd Hoffmann Reviewed-by: Jiewen Yao Tested-by: Jim Fehlig commit cb0d24637dfdd869618b9635dfb8e3b0746393a6 Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:31:12 2021 +0800 OvmfPkg/OvmfXen: set PcdAcpiS3Enable at initialization There are several functions in OvmfPkg/Library using QemuFwCfgS3Enabled() to detect the S3 support status. However, in MdeModulePkg, PcdAcpiS3Enable is used to check S3 support. Since InitializeXenPlatform() didn't set PcdAcpiS3Enable as InitializePlatform() did, this made the inconsistency between drivers/functions. For example, S3SaveStateDxe checked PcdAcpiS3Enable and skipped S3BootScript because the default value is FALSE. On the other hand, PlatformBootManagerBeforeConsole() from OvmfPkg/Library called QemuFwCfgS3Enabled() and found it returned TRUE, so it invoked SaveS3BootScript(). However, S3SaveStateDxe skipped S3BootScript, so SaveS3BootScript() asserted due to EFI_NOT_FOUND. This issue mainly affects "HVM Direct Kernel Boot". When used, "fw_cfg" is enabled in QEMU and QemuFwCfgS3Enabled() returns true in that case. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3573 Signed-off-by: Gary Lin Reviewed-by: Anthony PERARD Reviewed-by: Gerd Hoffmann Reviewed-by: Jiewen Yao Tested-by: Jim Fehlig From xen-devel-bounces@lists.xenproject.org Wed Sep 01 12:29:31 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Sep 2021 12:29:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.176344.320893 (Exim 4.92) (envelope-from ) id 1mLPMw-0003fy-NF; Wed, 01 Sep 2021 12:29:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 176344.320893; Wed, 01 Sep 2021 12:29:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLPMw-0003fr-Jd; Wed, 01 Sep 2021 12:29:30 +0000 Received: by outflank-mailman (input) for mailman id 176344; Wed, 01 Sep 2021 12:29:29 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLPMv-0003fj-0W for xen-devel@lists.xen.org; Wed, 01 Sep 2021 12:29:29 +0000 Received: from mail-pg1-x52f.google.com (unknown [2607:f8b0:4864:20::52f]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 19227e72-2afa-4c5a-983b-279d7332980d; Wed, 01 Sep 2021 12:29:20 +0000 (UTC) Received: by mail-pg1-x52f.google.com with SMTP id s11so2574023pgr.11 for ; Wed, 01 Sep 2021 05:29:20 -0700 (PDT) Received: from laputa (p784a44f4.tkyea130.ap.so-net.ne.jp. [120.74.68.244]) by smtp.gmail.com with ESMTPSA id 11sm24800891pgh.52.2021.09.01.05.29.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Sep 2021 05:29:18 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 19227e72-2afa-4c5a-983b-279d7332980d DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=07U2ss57vpxKYbvMqehbTSa/mQqWhg8J3EKt6sEzu1Q=; b=tGEGEJQN/y8wkh6wE9Tpje/mLcwS1Cpy3s5pLdntikNHnVh1IemOBAjnAl85CfDjFa vlDDXh8UrmfY3Yla0qa5wbTMrogk5Qz/GyWKc0Rs7GSer2zm7XPzP7SDEpKONpSqiIn4 YNcsHJYcn73N59BmxcDuI+LK1SWBy4/F/5A9trw2x3zr5IYxbHP6vIv5KuSDw8gnUpmt C9ev6p1PS/WW3/B7WlqzFMgVn5tLXsJOpyc6Sdatl38qu8Gdzkc9pphWii6WARPgBkt3 N+Wuy47sNSORxdFKe/H/AZ3wu2PCmxIGpozp0tB2kQJdprr9hEEkpSLgVTSdcKk06T0W Ps2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=07U2ss57vpxKYbvMqehbTSa/mQqWhg8J3EKt6sEzu1Q=; b=GJNahvGXOQaslOFZ/EaUdT3rEvxtJk8a1uw/GJ+0+qH3Doe0qOWAsJedSFMRwGE+h3 m5keSVcPY125/m7kR0ubVrZts723q7irnFuSOZ1i7v7g0lGYPnxZpGczO/j8Pwl03e2I tPvNscI/50RDMbRdaCS9wJCoQYVS28UMSzYO0jbdYeeoiMM6XY1bNAJLZFjld13TICPJ 1tBbGvmyzb8P8GHL9nMrV3ykEv2cSoEOsczmccqilosGi5H4+pZP7qJSYH1Zxcwmfgt6 ELhzpvWqiU5wgi/oz/wvkcqJZ2pDSYRsbh1c8TsTg9zOQ6nh24JHssCH09tq9zrV61ox LZkw== X-Gm-Message-State: AOAM533cBkfOaAc31PqFqiqrVYwpARliBtRKn/hWFXLL5+YN9sZJ0S92 oPFKL/qUpYMq+lCjYgwrJTttlQ== X-Google-Smtp-Source: ABdhPJx7LVfGA76Fa52njG3Bl8xTL8wryQTg0FB02cmdtaD+7SpKet6xkUpwxHIe7GgFKBfahnN+0g== X-Received: by 2002:a63:e04a:: with SMTP id n10mr32324146pgj.381.1630499359569; Wed, 01 Sep 2021 05:29:19 -0700 (PDT) Date: Wed, 1 Sep 2021 21:29:10 +0900 From: AKASHI Takahiro To: Wei Chen Cc: Oleksandr Tyshchenko , Stefano Stabellini , Alex Benn??e , Kaly Xin , Stratos Mailing List , "virtio-dev@lists.oasis-open.org" , Arnd Bergmann , Viresh Kumar , Stefano Stabellini , "stefanha@redhat.com" , Jan Kiszka , Carl van Schaik , "pratikp@quicinc.com" , Srivatsa Vaddagiri , Jean-Philippe Brucker , Mathieu Poirier , Oleksandr Tyshchenko , Bertrand Marquis , Artem Mygaiev , Julien Grall , Juergen Gross , Paul Durrant , nd , Xen Devel Subject: Re: Enabling hypervisor agnosticism for VirtIO backends Message-ID: <20210901122910.GA100270@laputa> References: <20210817080757.GC43203@laputa> <20210818053840.GE39588@laputa> <20210820064150.GC13452@laputa> <20210826094047.GA55218@laputa> <20210831061805.GB69817@laputa> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Hi Wei, On Wed, Sep 01, 2021 at 11:12:58AM +0000, Wei Chen wrote: > Hi Akashi, > > > -----Original Message----- > > From: AKASHI Takahiro > > Sent: 2021年8月31日 14:18 > > To: Wei Chen > > Cc: Oleksandr Tyshchenko ; Stefano Stabellini > > ; Alex Benn??e ; Kaly Xin > > ; Stratos Mailing List ; > > virtio-dev@lists.oasis-open.org; Arnd Bergmann ; > > Viresh Kumar ; Stefano Stabellini > > ; stefanha@redhat.com; Jan Kiszka > > ; Carl van Schaik ; > > pratikp@quicinc.com; Srivatsa Vaddagiri ; Jean- > > Philippe Brucker ; Mathieu Poirier > > ; Oleksandr Tyshchenko > > ; Bertrand Marquis > > ; Artem Mygaiev ; Julien > > Grall ; Juergen Gross ; Paul Durrant > > ; Xen Devel > > Subject: Re: Enabling hypervisor agnosticism for VirtIO backends > > > > Wei, > > > > On Thu, Aug 26, 2021 at 12:10:19PM +0000, Wei Chen wrote: > > > Hi Akashi, > > > > > > > -----Original Message----- > > > > From: AKASHI Takahiro > > > > Sent: 2021年8月26日 17:41 > > > > To: Wei Chen > > > > Cc: Oleksandr Tyshchenko ; Stefano Stabellini > > > > ; Alex Benn??e ; Kaly > > Xin > > > > ; Stratos Mailing List > lists.linaro.org>; > > > > virtio-dev@lists.oasis-open.org; Arnd Bergmann > > ; > > > > Viresh Kumar ; Stefano Stabellini > > > > ; stefanha@redhat.com; Jan Kiszka > > > > ; Carl van Schaik ; > > > > pratikp@quicinc.com; Srivatsa Vaddagiri ; Jean- > > > > Philippe Brucker ; Mathieu Poirier > > > > ; Oleksandr Tyshchenko > > > > ; Bertrand Marquis > > > > ; Artem Mygaiev ; > > Julien > > > > Grall ; Juergen Gross ; Paul Durrant > > > > ; Xen Devel > > > > Subject: Re: Enabling hypervisor agnosticism for VirtIO backends > > > > > > > > Hi Wei, > > > > > > > > On Fri, Aug 20, 2021 at 03:41:50PM +0900, AKASHI Takahiro wrote: > > > > > On Wed, Aug 18, 2021 at 08:35:51AM +0000, Wei Chen wrote: > > > > > > Hi Akashi， > > > > > > > > > > > > > -----Original Message----- > > > > > > > From: AKASHI Takahiro > > > > > > > Sent: 2021年8月18日 13:39 > > > > > > > To: Wei Chen > > > > > > > Cc: Oleksandr Tyshchenko ; Stefano > > Stabellini > > > > > > > ; Alex Benn??e ; > > > > Stratos > > > > > > > Mailing List ; virtio- > > > > dev@lists.oasis- > > > > > > > open.org; Arnd Bergmann ; Viresh Kumar > > > > > > > ; Stefano Stabellini > > > > > > > ; stefanha@redhat.com; Jan Kiszka > > > > > > > ; Carl van Schaik > > > > ; > > > > > > > pratikp@quicinc.com; Srivatsa Vaddagiri ; > > > > Jean- > > > > > > > Philippe Brucker ; Mathieu Poirier > > > > > > > ; Oleksandr Tyshchenko > > > > > > > ; Bertrand Marquis > > > > > > > ; Artem Mygaiev > > ; > > > > Julien > > > > > > > Grall ; Juergen Gross ; Paul > > > > Durrant > > > > > > > ; Xen Devel > > > > > > > Subject: Re: Enabling hypervisor agnosticism for VirtIO backends > > > > > > > > > > > > > > On Tue, Aug 17, 2021 at 08:39:09AM +0000, Wei Chen wrote: > > > > > > > > Hi Akashi, > > > > > > > > > > > > > > > > > -----Original Message----- > > > > > > > > > From: AKASHI Takahiro > > > > > > > > > Sent: 2021年8月17日 16:08 > > > > > > > > > To: Wei Chen > > > > > > > > > Cc: Oleksandr Tyshchenko ; Stefano > > > > Stabellini > > > > > > > > > ; Alex Benn??e > > ; > > > > > > > Stratos > > > > > > > > > Mailing List ; virtio- > > > > > > > dev@lists.oasis- > > > > > > > > > open.org; Arnd Bergmann ; Viresh > > Kumar > > > > > > > > > ; Stefano Stabellini > > > > > > > > > ; stefanha@redhat.com; Jan > > Kiszka > > > > > > > > > ; Carl van Schaik > > > > ; > > > > > > > > > pratikp@quicinc.com; Srivatsa Vaddagiri > > ; > > > > Jean- > > > > > > > > > Philippe Brucker ; Mathieu Poirier > > > > > > > > > ; Oleksandr Tyshchenko > > > > > > > > > ; Bertrand Marquis > > > > > > > > > ; Artem Mygaiev > > > > ; > > > > > > > Julien > > > > > > > > > Grall ; Juergen Gross ; > > Paul > > > > Durrant > > > > > > > > > ; Xen Devel > > > > > > > > > Subject: Re: Enabling hypervisor agnosticism for VirtIO > > backends > > > > > > > > > > > > > > > > > > Hi Wei, Oleksandr, > > > > > > > > > > > > > > > > > > On Mon, Aug 16, 2021 at 10:04:03AM +0000, Wei Chen wrote: > > > > > > > > > > Hi All, > > > > > > > > > > > > > > > > > > > > Thanks for Stefano to link my kvmtool for Xen proposal > > here. > > > > > > > > > > This proposal is still discussing in Xen and KVM > > communities. > > > > > > > > > > The main work is to decouple the kvmtool from KVM and make > > > > > > > > > > other hypervisors can reuse the virtual device > > implementations. > > > > > > > > > > > > > > > > > > > > In this case, we need to introduce an intermediate > > hypervisor > > > > > > > > > > layer for VMM abstraction, Which is, I think it's very > > close > > > > > > > > > > to stratos' virtio hypervisor agnosticism work. > > > > > > > > > > > > > > > > > > # My proposal[1] comes from my own idea and doesn't always > > > > represent > > > > > > > > > # Linaro's view on this subject nor reflect Alex's concerns. > > > > > > > Nevertheless, > > > > > > > > > > > > > > > > > > Your idea and my proposal seem to share the same background. > > > > > > > > > Both have the similar goal and currently start with, at > > first, > > > > Xen > > > > > > > > > and are based on kvm-tool. (Actually, my work is derived > > from > > > > > > > > > EPAM's virtio-disk, which is also based on kvm-tool.) > > > > > > > > > > > > > > > > > > In particular, the abstraction of hypervisor interfaces has > > a > > > > same > > > > > > > > > set of interfaces (for your "struct vmm_impl" and my "RPC > > > > interfaces"). > > > > > > > > > This is not co-incident as we both share the same origin as > > I > > > > said > > > > > > > above. > > > > > > > > > And so we will also share the same issues. One of them is a > > way > > > > of > > > > > > > > > "sharing/mapping FE's memory". There is some trade-off > > between > > > > > > > > > the portability and the performance impact. > > > > > > > > > So we can discuss the topic here in this ML, too. > > > > > > > > > (See Alex's original email, too). > > > > > > > > > > > > > > > > > Yes, I agree. > > > > > > > > > > > > > > > > > On the other hand, my approach aims to create a "single- > > binary" > > > > > > > solution > > > > > > > > > in which the same binary of BE vm could run on any > > hypervisors. > > > > > > > > > Somehow similar to your "proposal-#2" in [2], but in my > > solution, > > > > all > > > > > > > > > the hypervisor-specific code would be put into another > > entity > > > > (VM), > > > > > > > > > named "virtio-proxy" and the abstracted operations are > > served > > > > via RPC. > > > > > > > > > (In this sense, BE is hypervisor-agnostic but might have OS > > > > > > > dependency.) > > > > > > > > > But I know that we need discuss if this is a requirement > > even > > > > > > > > > in Stratos project or not. (Maybe not) > > > > > > > > > > > > > > > > > > > > > > > > > Sorry, I haven't had time to finish reading your virtio-proxy > > > > completely > > > > > > > > (I will do it ASAP). But from your description, it seems we > > need a > > > > > > > > 3rd VM between FE and BE? My concern is that, if my assumption > > is > > > > right, > > > > > > > > will it increase the latency in data transport path? Even if > > we're > > > > > > > > using some lightweight guest like RTOS or Unikernel, > > > > > > > > > > > > > > Yes, you're right. But I'm afraid that it is a matter of degree. > > > > > > > As far as we execute 'mapping' operations at every fetch of > > payload, > > > > > > > we will see latency issue (even in your case) and if we have > > some > > > > solution > > > > > > > for it, we won't see it neither in my proposal :) > > > > > > > > > > > > > > > > > > > Oleksandr has sent a proposal to Xen mailing list to reduce this > > kind > > > > > > of "mapping/unmapping" operations. So the latency caused by this > > > > behavior > > > > > > on Xen may eventually be eliminated, and Linux-KVM doesn't have > > that > > > > problem. > > > > > > > > > > Obviously, I have not yet caught up there in the discussion. > > > > > Which patch specifically? > > > > > > > > Can you give me the link to the discussion or patch, please? > > > > > > > > > > It's a RFC discussion. We have tested this RFC patch internally. > > > https://lists.xenproject.org/archives/html/xen-devel/2021- > > 07/msg01532.html > > > > I'm afraid that I miss something here, but I don't know > > why this proposed API will lead to eliminating 'mmap' in accessing > > the queued payload at every request? > > > > This API give Xen device model (QEMU or kvmtool) the ability to map > whole guest RAM in device model's address space. In this case, device > model doesn't need dynamic hypercall to map/unmap payload memory. > It can use a flat offset to access payload memory in its address > space directly. Just Like KVM device model does now. Thank you. Quickly, let me make sure one thing: This API itself doesn't do any mapping operations, right? So I suppose that virtio BE guest is responsible to 1) fetch the information about all the memory regions in FE, 2) call this API to allocate a big chunk of unused space in BE, 3) create grant/foreign mappings for FE onto this region(S) in the initialization/configuration of emulated virtio devices. Is this the way this API is expected to be used? Does Xen already has an interface for (1)? -Takahiro Akashi > Before this API, When device model to map whole guest memory, will > severely consume the physical pages of Dom-0/Dom-D. > > > -Takahiro Akashi > > > > > > > > Thanks, > > > > -Takahiro Akashi > > > > > > > > > -Takahiro Akashi > > > > > > > > > > > > > > Specifically speaking about kvm-tool, I have a concern about > > its > > > > > > > > > license term; Targeting different hypervisors and different > > OSs > > > > > > > > > (which I assume includes RTOS's), the resultant library > > should > > > > be > > > > > > > > > license permissive and GPL for kvm-tool might be an issue. > > > > > > > > > Any thoughts? > > > > > > > > > > > > > > > > > > > > > > > > > Yes. If user want to implement a FreeBSD device model, but the > > > > virtio > > > > > > > > library is GPL. Then GPL would be a problem. If we have > > another > > > > good > > > > > > > > candidate, I am open to it. > > > > > > > > > > > > > > I have some candidates, particularly for vq/vring, in my mind: > > > > > > > * Open-AMP, or > > > > > > > * corresponding Free-BSD code > > > > > > > > > > > > > > > > > > > Interesting, I will look into them : ) > > > > > > > > > > > > Cheers, > > > > > > Wei Chen > > > > > > > > > > > > > -Takahiro Akashi > > > > > > > > > > > > > > > > > > > > > > > -Takahiro Akashi > > > > > > > > > > > > > > > > > > > > > > > > > > > [1] https://op-lists.linaro.org/pipermail/stratos-dev/2021- > > > > > > > > > August/000548.html > > > > > > > > > [2] https://marc.info/?l=xen-devel&m=162373754705233&w=2 > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > From: Oleksandr Tyshchenko > > > > > > > > > > > Sent: 2021年8月14日 23:38 > > > > > > > > > > > To: AKASHI Takahiro ; > > Stefano > > > > > > > Stabellini > > > > > > > > > > > > > > > > > > > > Cc: Alex Benn??e ; Stratos > > Mailing > > > > List > > > > > > > > > ; virtio-dev@lists.oasis- > > > > open.org; > > > > > > > Arnd > > > > > > > > > Bergmann ; Viresh Kumar > > > > > > > > > ; Stefano Stabellini > > > > > > > > > ; stefanha@redhat.com; Jan > > Kiszka > > > > > > > > > ; Carl van Schaik > > > > ; > > > > > > > > > pratikp@quicinc.com; Srivatsa Vaddagiri > > ; > > > > Jean- > > > > > > > > > Philippe Brucker ; Mathieu Poirier > > > > > > > > > ; Wei Chen ; > > > > Oleksandr > > > > > > > > > Tyshchenko ; Bertrand Marquis > > > > > > > > > ; Artem Mygaiev > > > > ; > > > > > > > Julien > > > > > > > > > Grall ; Juergen Gross ; > > Paul > > > > Durrant > > > > > > > > > ; Xen Devel > > > > > > > > > > > Subject: Re: Enabling hypervisor agnosticism for VirtIO > > > > backends > > > > > > > > > > > > > > > > > > > > > > Hello, all. > > > > > > > > > > > > > > > > > > > > > > Please see some comments below. And sorry for the > > possible > > > > format > > > > > > > > > issues. > > > > > > > > > > > > > > > > > > > > > > > On Wed, Aug 11, 2021 at 9:27 AM AKASHI Takahiro > > > > > > > > > wrote: > > > > > > > > > > > > On Wed, Aug 04, 2021 at 12:20:01PM -0700, Stefano > > > > Stabellini > > > > > > > wrote: > > > > > > > > > > > > > CCing people working on Xen+VirtIO and IOREQs. Not > > > > trimming > > > > > > > the > > > > > > > > > original > > > > > > > > > > > > > email to let them read the full context. > > > > > > > > > > > > > > > > > > > > > > > > > > My comments below are related to a potential Xen > > > > > > > implementation, > > > > > > > > > not > > > > > > > > > > > > > because it is the only implementation that matters, > > but > > > > > > > because it > > > > > > > > > is > > > > > > > > > > > > > the one I know best. > > > > > > > > > > > > > > > > > > > > > > > > Please note that my proposal (and hence the working > > > > prototype)[1] > > > > > > > > > > > > is based on Xen's virtio implementation (i.e. IOREQ) > > and > > > > > > > > > particularly > > > > > > > > > > > > EPAM's virtio-disk application (backend server). > > > > > > > > > > > > It has been, I believe, well generalized but is still > > a > > > > bit > > > > > > > biased > > > > > > > > > > > > toward this original design. > > > > > > > > > > > > > > > > > > > > > > > > So I hope you like my approach :) > > > > > > > > > > > > > > > > > > > > > > > > [1] https://op-lists.linaro.org/pipermail/stratos- > > > > dev/2021- > > > > > > > > > August/000546.html > > > > > > > > > > > > > > > > > > > > > > > > Let me take this opportunity to explain a bit more > > about > > > > my > > > > > > > approach > > > > > > > > > below. > > > > > > > > > > > > > > > > > > > > > > > > > Also, please see this relevant email thread: > > > > > > > > > > > > > https://marc.info/?l=xen-devel&m=162373754705233&w=2 > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On Wed, 4 Aug 2021, Alex Bennée wrote: > > > > > > > > > > > > > > Hi, > > > > > > > > > > > > > > > > > > > > > > > > > > > > One of the goals of Project Stratos is to enable > > > > hypervisor > > > > > > > > > agnostic > > > > > > > > > > > > > > backends so we can enable as much re-use of code > > as > > > > possible > > > > > > > and > > > > > > > > > avoid > > > > > > > > > > > > > > repeating ourselves. This is the flip side of the > > > > front end > > > > > > > > > where > > > > > > > > > > > > > > multiple front-end implementations are required - > > one > > > > per OS, > > > > > > > > > assuming > > > > > > > > > > > > > > you don't just want Linux guests. The resultant > > guests > > > > are > > > > > > > > > trivially > > > > > > > > > > > > > > movable between hypervisors modulo any abstracted > > > > paravirt > > > > > > > type > > > > > > > > > > > > > > interfaces. > > > > > > > > > > > > > > > > > > > > > > > > > > > > In my original thumb nail sketch of a solution I > > > > envisioned > > > > > > > > > vhost-user > > > > > > > > > > > > > > daemons running in a broadly POSIX like > > environment. > > > > The > > > > > > > > > interface to > > > > > > > > > > > > > > the daemon is fairly simple requiring only some > > mapped > > > > > > > memory > > > > > > > > > and some > > > > > > > > > > > > > > sort of signalling for events (on Linux this is > > > > eventfd). > > > > > > > The > > > > > > > > > idea was a > > > > > > > > > > > > > > stub binary would be responsible for any > > hypervisor > > > > specific > > > > > > > > > setup and > > > > > > > > > > > > > > then launch a common binary to deal with the > > actual > > > > > > > virtqueue > > > > > > > > > requests > > > > > > > > > > > > > > themselves. > > > > > > > > > > > > > > > > > > > > > > > > > > > > Since that original sketch we've seen an expansion > > in > > > > the > > > > > > > sort > > > > > > > > > of ways > > > > > > > > > > > > > > backends could be created. There is interest in > > > > > > > encapsulating > > > > > > > > > backends > > > > > > > > > > > > > > in RTOSes or unikernels for solutions like SCMI. > > There > > > > > > > interest > > > > > > > > > in Rust > > > > > > > > > > > > > > has prompted ideas of using the trait interface to > > > > abstract > > > > > > > > > differences > > > > > > > > > > > > > > away as well as the idea of bare-metal Rust > > backends. > > > > > > > > > > > > > > > > > > > > > > > > > > > > We have a card (STR-12) called "Hypercall > > > > Standardisation" > > > > > > > which > > > > > > > > > > > > > > calls for a description of the APIs needed from > > the > > > > > > > hypervisor > > > > > > > > > side to > > > > > > > > > > > > > > support VirtIO guests and their backends. However > > we > > > > are > > > > > > > some > > > > > > > > > way off > > > > > > > > > > > > > > from that at the moment as I think we need to at > > least > > > > > > > > > demonstrate one > > > > > > > > > > > > > > portable backend before we start codifying > > > > requirements. To > > > > > > > that > > > > > > > > > end I > > > > > > > > > > > > > > want to think about what we need for a backend to > > > > function. > > > > > > > > > > > > > > > > > > > > > > > > > > > > Configuration > > > > > > > > > > > > > > ============= > > > > > > > > > > > > > > > > > > > > > > > > > > > > In the type-2 setup this is typically fairly > > simple > > > > because > > > > > > > the > > > > > > > > > host > > > > > > > > > > > > > > system can orchestrate the various modules that > > make > > > > up the > > > > > > > > > complete > > > > > > > > > > > > > > system. In the type-1 case (or even type-2 with > > > > delegated > > > > > > > > > service VMs) > > > > > > > > > > > > > > we need some sort of mechanism to inform the > > backend > > > > VM > > > > > > > about > > > > > > > > > key > > > > > > > > > > > > > > details about the system: > > > > > > > > > > > > > > > > > > > > > > > > > > > > - where virt queue memory is in it's address > > space > > > > > > > > > > > > > > - how it's going to receive (interrupt) and > > trigger > > > > (kick) > > > > > > > > > events > > > > > > > > > > > > > > - what (if any) resources the backend needs to > > > > connect to > > > > > > > > > > > > > > > > > > > > > > > > > > > > Obviously you can elide over configuration issues > > by > > > > having > > > > > > > > > static > > > > > > > > > > > > > > configurations and baking the assumptions into > > your > > > > guest > > > > > > > images > > > > > > > > > however > > > > > > > > > > > > > > this isn't scalable in the long term. The obvious > > > > solution > > > > > > > seems > > > > > > > > > to be > > > > > > > > > > > > > > extending a subset of Device Tree data to user > > space > > > > but > > > > > > > perhaps > > > > > > > > > there > > > > > > > > > > > > > > are other approaches? > > > > > > > > > > > > > > > > > > > > > > > > > > > > Before any virtio transactions can take place the > > > > > > > appropriate > > > > > > > > > memory > > > > > > > > > > > > > > mappings need to be made between the FE guest and > > the > > > > BE > > > > > > > guest. > > > > > > > > > > > > > > > > > > > > > > > > > > > Currently the whole of the FE guests address space > > > > needs to > > > > > > > be > > > > > > > > > visible > > > > > > > > > > > > > > to whatever is serving the virtio requests. I can > > > > envision 3 > > > > > > > > > approaches: > > > > > > > > > > > > > > > > > > > > > > > > > > > > * BE guest boots with memory already mapped > > > > > > > > > > > > > > > > > > > > > > > > > > > > This would entail the guest OS knowing where in > > it's > > > > Guest > > > > > > > > > Physical > > > > > > > > > > > > > > Address space is already taken up and avoiding > > > > clashing. I > > > > > > > > > would assume > > > > > > > > > > > > > > in this case you would want a standard interface > > to > > > > > > > userspace > > > > > > > > > to then > > > > > > > > > > > > > > make that address space visible to the backend > > daemon. > > > > > > > > > > > > > > > > > > > > > > > > Yet another way here is that we would have well known > > > > "shared > > > > > > > > > memory" between > > > > > > > > > > > > VMs. I think that Jailhouse's ivshmem gives us good > > > > insights on > > > > > > > this > > > > > > > > > matter > > > > > > > > > > > > and that it can even be an alternative for hypervisor- > > > > agnostic > > > > > > > > > solution. > > > > > > > > > > > > > > > > > > > > > > > > (Please note memory regions in ivshmem appear as a PCI > > > > device > > > > > > > and > > > > > > > > > can be > > > > > > > > > > > > mapped locally.) > > > > > > > > > > > > > > > > > > > > > > > > I want to add this shared memory aspect to my virtio- > > proxy, > > > > but > > > > > > > > > > > > the resultant solution would eventually look similar > > to > > > > ivshmem. > > > > > > > > > > > > > > > > > > > > > > > > > > * BE guests boots with a hypervisor handle to > > memory > > > > > > > > > > > > > > > > > > > > > > > > > > > > The BE guest is then free to map the FE's memory > > to > > > > where > > > > > > > it > > > > > > > > > wants in > > > > > > > > > > > > > > the BE's guest physical address space. > > > > > > > > > > > > > > > > > > > > > > > > > > I cannot see how this could work for Xen. There is > > no > > > > "handle" > > > > > > > to > > > > > > > > > give > > > > > > > > > > > > > to the backend if the backend is not running in dom0. > > So > > > > for > > > > > > > Xen I > > > > > > > > > think > > > > > > > > > > > > > the memory has to be already mapped > > > > > > > > > > > > > > > > > > > > > > > > In Xen's IOREQ solution (virtio-blk), the following > > > > information > > > > > > > is > > > > > > > > > expected > > > > > > > > > > > > to be exposed to BE via Xenstore: > > > > > > > > > > > > (I know that this is a tentative approach though.) > > > > > > > > > > > > - the start address of configuration space > > > > > > > > > > > > - interrupt number > > > > > > > > > > > > - file path for backing storage > > > > > > > > > > > > - read-only flag > > > > > > > > > > > > And the BE server have to call a particular hypervisor > > > > interface > > > > > > > to > > > > > > > > > > > > map the configuration space. > > > > > > > > > > > > > > > > > > > > > > Yes, Xenstore was chosen as a simple way to pass > > > > configuration > > > > > > > info to > > > > > > > > > the backend running in a non-toolstack domain. > > > > > > > > > > > I remember, there was a wish to avoid using Xenstore in > > > > Virtio > > > > > > > backend > > > > > > > > > itself if possible, so for non-toolstack domain, this could > > done > > > > with > > > > > > > > > adjusting devd (daemon that listens for devices and launches > > > > backends) > > > > > > > > > > > to read backend configuration from the Xenstore anyway > > and > > > > pass it > > > > > > > to > > > > > > > > > the backend via command line arguments. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Yes, in current PoC code we're using xenstore to pass > > device > > > > > > > > > configuration. > > > > > > > > > > We also designed a static device configuration parse > > method > > > > for > > > > > > > Dom0less > > > > > > > > > or > > > > > > > > > > other scenarios don't have xentool. yes, it's from device > > > > model > > > > > > > command > > > > > > > > > line > > > > > > > > > > or a config file. > > > > > > > > > > > > > > > > > > > > > But, if ... > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > In my approach (virtio-proxy), all those Xen (or > > > > hypervisor)- > > > > > > > > > specific > > > > > > > > > > > > stuffs are contained in virtio-proxy, yet another VM, > > to > > > > hide > > > > > > > all > > > > > > > > > details. > > > > > > > > > > > > > > > > > > > > > > ... the solution how to overcome that is already found > > and > > > > proven > > > > > > > to > > > > > > > > > work then even better. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > # My point is that a "handle" is not mandatory for > > > > executing > > > > > > > mapping. > > > > > > > > > > > > > > > > > > > > > > > > > and the mapping probably done by the > > > > > > > > > > > > > toolstack (also see below.) Or we would have to > > invent a > > > > new > > > > > > > Xen > > > > > > > > > > > > > hypervisor interface and Xen virtual machine > > privileges > > > > to > > > > > > > allow > > > > > > > > > this > > > > > > > > > > > > > kind of mapping. > > > > > > > > > > > > > > > > > > > > > > > > > If we run the backend in Dom0 that we have no > > problems > > > > of > > > > > > > course. > > > > > > > > > > > > > > > > > > > > > > > > One of difficulties on Xen that I found in my approach > > is > > > > that > > > > > > > > > calling > > > > > > > > > > > > such hypervisor intefaces (registering IOREQ, mapping > > > > memory) is > > > > > > > > > only > > > > > > > > > > > > allowed on BE servers themselvies and so we will have > > to > > > > extend > > > > > > > > > those > > > > > > > > > > > > interfaces. > > > > > > > > > > > > This, however, will raise some concern on security and > > > > privilege > > > > > > > > > distribution > > > > > > > > > > > > as Stefan suggested. > > > > > > > > > > > > > > > > > > > > > > We also faced policy related issues with Virtio backend > > > > running in > > > > > > > > > other than Dom0 domain in a "dummy" xsm mode. In our target > > > > system we > > > > > > > run > > > > > > > > > the backend in a driver > > > > > > > > > > > domain (we call it DomD) where the underlying H/W > > resides. > > > > We > > > > > > > trust it, > > > > > > > > > so we wrote policy rules (to be used in "flask" xsm mode) to > > > > provide > > > > > > > it > > > > > > > > > with a little bit more privileges than a simple DomU had. > > > > > > > > > > > Now it is permitted to issue device-model, resource and > > > > memory > > > > > > > > > mappings, etc calls. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > To activate the mapping will > > > > > > > > > > > > > > require some sort of hypercall to the hypervisor. > > I > > > > can see > > > > > > > two > > > > > > > > > options > > > > > > > > > > > > > > at this point: > > > > > > > > > > > > > > > > > > > > > > > > > > > > - expose the handle to userspace for > > daemon/helper > > > > to > > > > > > > trigger > > > > > > > > > the > > > > > > > > > > > > > > mapping via existing hypercall interfaces. If > > > > using a > > > > > > > helper > > > > > > > > > you > > > > > > > > > > > > > > would have a hypervisor specific one to avoid > > the > > > > daemon > > > > > > > > > having to > > > > > > > > > > > > > > care too much about the details or push that > > > > complexity > > > > > > > into > > > > > > > > > a > > > > > > > > > > > > > > compile time option for the daemon which would > > > > result in > > > > > > > > > different > > > > > > > > > > > > > > binaries although a common source base. > > > > > > > > > > > > > > > > > > > > > > > > > > > > - expose a new kernel ABI to abstract the > > hypercall > > > > > > > > > differences away > > > > > > > > > > > > > > in the guest kernel. In this case the > > userspace > > > > would > > > > > > > > > essentially > > > > > > > > > > > > > > ask for an abstract "map guest N memory to > > > > userspace > > > > > > > ptr" > > > > > > > > > and let > > > > > > > > > > > > > > the kernel deal with the different hypercall > > > > interfaces. > > > > > > > > > This of > > > > > > > > > > > > > > course assumes the majority of BE guests would > > be > > > > Linux > > > > > > > > > kernels and > > > > > > > > > > > > > > leaves the bare-metal/unikernel approaches to > > > > their own > > > > > > > > > devices. > > > > > > > > > > > > > > > > > > > > > > > > > > > > Operation > > > > > > > > > > > > > > ========= > > > > > > > > > > > > > > > > > > > > > > > > > > > > The core of the operation of VirtIO is fairly > > simple. > > > > Once > > > > > > > the > > > > > > > > > > > > > > vhost-user feature negotiation is done it's a case > > of > > > > > > > receiving > > > > > > > > > update > > > > > > > > > > > > > > events and parsing the resultant virt queue for > > data. > > > > The > > > > > > > vhost- > > > > > > > > > user > > > > > > > > > > > > > > specification handles a bunch of setup before that > > > > point, > > > > > > > mostly > > > > > > > > > to > > > > > > > > > > > > > > detail where the virt queues are set up FD's for > > > > memory and > > > > > > > > > event > > > > > > > > > > > > > > communication. This is where the envisioned stub > > > > process > > > > > > > would > > > > > > > > > be > > > > > > > > > > > > > > responsible for getting the daemon up and ready to > > run. > > > > This > > > > > > > is > > > > > > > > > > > > > > currently done inside a big VMM like QEMU but I > > > > suspect a > > > > > > > modern > > > > > > > > > > > > > > approach would be to use the rust-vmm vhost crate. > > It > > > > would > > > > > > > then > > > > > > > > > either > > > > > > > > > > > > > > communicate with the kernel's abstracted ABI or be > > re- > > > > > > > targeted > > > > > > > > > as a > > > > > > > > > > > > > > build option for the various hypervisors. > > > > > > > > > > > > > > > > > > > > > > > > > > One thing I mentioned before to Alex is that Xen > > doesn't > > > > have > > > > > > > VMMs > > > > > > > > > the > > > > > > > > > > > > > way they are typically envisioned and described in > > other > > > > > > > > > environments. > > > > > > > > > > > > > Instead, Xen has IOREQ servers. Each of them > > connects > > > > > > > > > independently to > > > > > > > > > > > > > Xen via the IOREQ interface. E.g. today multiple > > QEMUs > > > > could > > > > > > > be > > > > > > > > > used as > > > > > > > > > > > > > emulators for a single Xen VM, each of them > > connecting > > > > to Xen > > > > > > > > > > > > > independently via the IOREQ interface. > > > > > > > > > > > > > > > > > > > > > > > > > > The component responsible for starting a daemon > > and/or > > > > setting > > > > > > > up > > > > > > > > > shared > > > > > > > > > > > > > interfaces is the toolstack: the xl command and the > > > > > > > libxl/libxc > > > > > > > > > > > > > libraries. > > > > > > > > > > > > > > > > > > > > > > > > I think that VM configuration management (or > > orchestration > > > > in > > > > > > > > > Startos > > > > > > > > > > > > jargon?) is a subject to debate in parallel. > > > > > > > > > > > > Otherwise, is there any good assumption to avoid it > > right > > > > now? > > > > > > > > > > > > > > > > > > > > > > > > > Oleksandr and others I CCed have been working on > > ways > > > > for the > > > > > > > > > toolstack > > > > > > > > > > > > > to create virtio backends and setup memory mappings. > > > > They > > > > > > > might be > > > > > > > > > able > > > > > > > > > > > > > to provide more info on the subject. I do think we > > miss > > > > a way > > > > > > > to > > > > > > > > > provide > > > > > > > > > > > > > the configuration to the backend and anything else > > that > > > > the > > > > > > > > > backend > > > > > > > > > > > > > might require to start doing its job. > > > > > > > > > > > > > > > > > > > > > > Yes, some work has been done for the toolstack to handle > > > > Virtio > > > > > > > MMIO > > > > > > > > > devices in > > > > > > > > > > > general and Virtio block devices in particular. However, > > it > > > > has > > > > > > > not > > > > > > > > > been upstreaned yet. > > > > > > > > > > > Updated patches on review now: > > > > > > > > > > > https://lore.kernel.org/xen-devel/1621626361-29076-1- > > git- > > > > send- > > > > > > > email- > > > > > > > > > olekstysh@gmail.com/ > > > > > > > > > > > > > > > > > > > > > > There is an additional (also important) activity to > > > > improve/fix > > > > > > > > > foreign memory mapping on Arm which I am also involved in. > > > > > > > > > > > The foreign memory mapping is proposed to be used for > > Virtio > > > > > > > backends > > > > > > > > > (device emulators) if there is a need to run guest OS > > completely > > > > > > > > > unmodified. > > > > > > > > > > > Of course, the more secure way would be to use grant > > memory > > > > > > > mapping. > > > > > > > > > Brietly, the main difference between them is that with > > foreign > > > > mapping > > > > > > > the > > > > > > > > > backend > > > > > > > > > > > can map any guest memory it wants to map, but with grant > > > > mapping > > > > > > > it is > > > > > > > > > allowed to map only what was previously granted by the > > frontend. > > > > > > > > > > > > > > > > > > > > > > So, there might be a problem if we want to pre-map some > > > > guest > > > > > > > memory > > > > > > > > > in advance or to cache mappings in the backend in order to > > > > improve > > > > > > > > > performance (because the mapping/unmapping guest pages every > > > > request > > > > > > > > > requires a lot of back and forth to Xen + P2M updates). In a > > > > nutshell, > > > > > > > > > currently, in order to map a guest page into the backend > > address > > > > space > > > > > > > we > > > > > > > > > need to steal a real physical page from the backend domain. > > So, > > > > with > > > > > > > the > > > > > > > > > said optimizations we might end up with no free memory in > > the > > > > backend > > > > > > > > > domain (see XSA-300). And what we try to achieve is to not > > waste > > > > a > > > > > > > real > > > > > > > > > domain memory at all by providing safe non-allocated-yet (so > > > > unused) > > > > > > > > > address space for the foreign (and grant) pages to be mapped > > > > into, > > > > > > > this > > > > > > > > > enabling work implies Xen and Linux (and likely DTB bindings) > > > > changes. > > > > > > > > > However, as it turned out, for this to work in a proper and > > safe > > > > way > > > > > > > some > > > > > > > > > prereq work needs to be done. > > > > > > > > > > > You can find the related Xen discussion at: > > > > > > > > > > > https://lore.kernel.org/xen-devel/1627489110-25633-1- > > git- > > > > send- > > > > > > > email- > > > > > > > > > olekstysh@gmail.com/ > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > One question is how to best handle notification > > and > > > > kicks. > > > > > > > The > > > > > > > > > existing > > > > > > > > > > > > > > vhost-user framework uses eventfd to signal the > > daemon > > > > > > > (although > > > > > > > > > QEMU > > > > > > > > > > > > > > is quite capable of simulating them when you use > > TCG). > > > > Xen > > > > > > > has > > > > > > > > > it's own > > > > > > > > > > > > > > IOREQ mechanism. However latency is an important > > > > factor and > > > > > > > > > having > > > > > > > > > > > > > > events go through the stub would add quite a lot. > > > > > > > > > > > > > > > > > > > > > > > > > > Yeah I think, regardless of anything else, we want > > the > > > > > > > backends to > > > > > > > > > > > > > connect directly to the Xen hypervisor. > > > > > > > > > > > > > > > > > > > > > > > > In my approach, > > > > > > > > > > > > a) BE -> FE: interrupts triggered by BE calling a > > > > hypervisor > > > > > > > > > interface > > > > > > > > > > > > via virtio-proxy > > > > > > > > > > > > b) FE -> BE: MMIO to config raises events (in event > > > > channels), > > > > > > > > > which is > > > > > > > > > > > > converted to a callback to BE via > > virtio- > > > > proxy > > > > > > > > > > > > (Xen's event channel is internnally > > > > implemented by > > > > > > > > > interrupts.) > > > > > > > > > > > > > > > > > > > > > > > > I don't know what "connect directly" means here, but > > > > sending > > > > > > > > > interrupts > > > > > > > > > > > > to the opposite side would be best efficient. > > > > > > > > > > > > Ivshmem, I suppose, takes this approach by utilizing > > PCI's > > > > msi-x > > > > > > > > > mechanism. > > > > > > > > > > > > > > > > > > > > > > Agree that MSI would be more efficient than SPI... > > > > > > > > > > > At the moment, in order to notify the frontend, the > > backend > > > > issues > > > > > > > a > > > > > > > > > specific device-model call to query Xen to inject a > > > > corresponding SPI > > > > > > > to > > > > > > > > > the guest. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Could we consider the kernel internally converting > > > > IOREQ > > > > > > > > > messages from > > > > > > > > > > > > > > the Xen hypervisor to eventfd events? Would this > > scale > > > > with > > > > > > > > > other kernel > > > > > > > > > > > > > > hypercall interfaces? > > > > > > > > > > > > > > > > > > > > > > > > > > > > So any thoughts on what directions are worth > > > > experimenting > > > > > > > with? > > > > > > > > > > > > > > > > > > > > > > > > > > One option we should consider is for each backend to > > > > connect > > > > > > > to > > > > > > > > > Xen via > > > > > > > > > > > > > the IOREQ interface. We could generalize the IOREQ > > > > interface > > > > > > > and > > > > > > > > > make it > > > > > > > > > > > > > hypervisor agnostic. The interface is really trivial > > and > > > > easy > > > > > > > to > > > > > > > > > add. > > > > > > > > > > > > > > > > > > > > > > > > As I said above, my proposal does the same thing that > > you > > > > > > > mentioned > > > > > > > > > here :) > > > > > > > > > > > > The difference is that I do call hypervisor interfaces > > via > > > > > > > virtio- > > > > > > > > > proxy. > > > > > > > > > > > > > > > > > > > > > > > > > The only Xen-specific part is the notification > > mechanism, > > > > > > > which is > > > > > > > > > an > > > > > > > > > > > > > event channel. If we replaced the event channel with > > > > something > > > > > > > > > else the > > > > > > > > > > > > > interface would be generic. See: > > > > > > > > > > > > > https://gitlab.com/xen-project/xen/- > > > > > > > > > /blob/staging/xen/include/public/hvm/ioreq.h#L52 > > > > > > > > > > > > > > > > > > > > > > > > > > I don't think that translating IOREQs to eventfd in > > the > > > > kernel > > > > > > > is > > > > > > > > > a > > > > > > > > > > > > > good idea: if feels like it would be extra > > complexity > > > > and that > > > > > > > the > > > > > > > > > > > > > kernel shouldn't be involved as this is a backend- > > > > hypervisor > > > > > > > > > interface. > > > > > > > > > > > > > > > > > > > > > > > > Given that we may want to implement BE as a bare-metal > > > > > > > application > > > > > > > > > > > > as I did on Zephyr, I don't think that the translation > > > > would not > > > > > > > be > > > > > > > > > > > > a big issue, especially on RTOS's. > > > > > > > > > > > > It will be some kind of abstraction layer of interrupt > > > > handling > > > > > > > > > > > > (or nothing but a callback mechanism). > > > > > > > > > > > > > > > > > > > > > > > > > Also, eventfd is very Linux-centric and we are > > trying to > > > > > > > design an > > > > > > > > > > > > > interface that could work well for RTOSes too. If we > > > > want to > > > > > > > do > > > > > > > > > > > > > something different, both OS-agnostic and > > hypervisor- > > > > agnostic, > > > > > > > > > perhaps > > > > > > > > > > > > > we could design a new interface. One that could be > > > > > > > implementable > > > > > > > > > in the > > > > > > > > > > > > > Xen hypervisor itself (like IOREQ) and of course any > > > > other > > > > > > > > > hypervisor > > > > > > > > > > > > > too. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > There is also another problem. IOREQ is probably not > > be > > > > the > > > > > > > only > > > > > > > > > > > > > interface needed. Have a look at > > > > > > > > > > > > > https://marc.info/?l=xen-devel&m=162373754705233&w=2. > > > > Don't we > > > > > > > > > also need > > > > > > > > > > > > > an interface for the backend to inject interrupts > > into > > > > the > > > > > > > > > frontend? And > > > > > > > > > > > > > if the backend requires dynamic memory mappings of > > > > frontend > > > > > > > pages, > > > > > > > > > then > > > > > > > > > > > > > we would also need an interface to map/unmap domU > > pages. > > > > > > > > > > > > > > > > > > > > > > > > My proposal document might help here; All the > > interfaces > > > > > > > required > > > > > > > > > for > > > > > > > > > > > > virtio-proxy (or hypervisor-related interfaces) are > > listed > > > > as > > > > > > > > > > > > RPC protocols :) > > > > > > > > > > > > > > > > > > > > > > > > > These interfaces are a lot more problematic than > > IOREQ: > > > > IOREQ > > > > > > > is > > > > > > > > > tiny > > > > > > > > > > > > > and self-contained. It is easy to add anywhere. A > > new > > > > > > > interface to > > > > > > > > > > > > > inject interrupts or map pages is more difficult to > > > > manage > > > > > > > because > > > > > > > > > it > > > > > > > > > > > > > would require changes scattered across the various > > > > emulators. > > > > > > > > > > > > > > > > > > > > > > > > Exactly. I have no confident yet that my approach will > > > > also > > > > > > > apply > > > > > > > > > > > > to other hypervisors than Xen. > > > > > > > > > > > > Technically, yes, but whether people can accept it or > > not > > > > is a > > > > > > > > > different > > > > > > > > > > > > matter. > > > > > > > > > > > > > > > > > > > > > > > > Thanks, > > > > > > > > > > > > -Takahiro Akashi > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > > > > > Regards, > > > > > > > > > > > > > > > > > > > > > > Oleksandr Tyshchenko > > > > > > > > > > IMPORTANT NOTICE: The contents of this email and any > > > > attachments are > > > > > > > > > confidential and may also be privileged. If you are not the > > > > intended > > > > > > > > > recipient, please notify the sender immediately and do not > > > > disclose > > > > > > > the > > > > > > > > > contents to any other person, use it for any purpose, or > > store > > > > or copy > > > > > > > the > > > > > > > > > information in any medium. Thank you. > > > > > > > > IMPORTANT NOTICE: The contents of this email and any > > attachments > > > > are > > > > > > > confidential and may also be privileged. If you are not the > > intended > > > > > > > recipient, please notify the sender immediately and do not > > disclose > > > > the > > > > > > > contents to any other person, use it for any purpose, or store > > or > > > > copy the > > > > > > > information in any medium. Thank you. > > > > > > IMPORTANT NOTICE: The contents of this email and any attachments > > are > > > > confidential and may also be privileged. If you are not the intended > > > > recipient, please notify the sender immediately and do not disclose > > the > > > > contents to any other person, use it for any purpose, or store or copy > > the > > > > information in any medium. Thank you. > > > IMPORTANT NOTICE: The contents of this email and any attachments are > > confidential and may also be privileged. If you are not the intended > > recipient, please notify the sender immediately and do not disclose the > > contents to any other person, use it for any purpose, or store or copy the > > information in any medium. Thank you. From xen-devel-bounces@lists.xenproject.org Wed Sep 01 12:43:36 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Sep 2021 12:43:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.176353.320910 (Exim 4.92) (envelope-from ) id 1mLPaO-0006NL-5w; Wed, 01 Sep 2021 12:43:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 176353.320910; Wed, 01 Sep 2021 12:43:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLPaO-0006NE-1x; Wed, 01 Sep 2021 12:43:24 +0000 Received: by outflank-mailman (input) for mailman id 176353; Wed, 01 Sep 2021 12:43:23 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLPaN-0006N8-3v for xen-devel@lists.xenproject.org; Wed, 01 Sep 2021 12:43:23 +0000 Received: from foss.arm.com (unknown [217.140.110.172]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTP id 2f8e18dd-0b22-11ec-add5-12813bfff9fa; Wed, 01 Sep 2021 12:43:20 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A138F1042; Wed, 1 Sep 2021 05:43:19 -0700 (PDT) Received: from e123311-lin.arm.com (unknown [10.57.13.24]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B66CF3F766; Wed, 1 Sep 2021 05:43:17 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2f8e18dd-0b22-11ec-add5-12813bfff9fa From: Michal Orzel To: xen-devel@lists.xenproject.org Cc: Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Volodymyr Babchuk , bertrand.marquis@arm.com Subject: [PATCH] xen/arm: Introduce pmu_access parameter Date: Wed, 1 Sep 2021 14:43:08 +0200 Message-Id: <20210901124308.31573-1-michal.orzel@arm.com> X-Mailer: git-send-email 2.29.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Introduce new Xen command line parameter called "pmu_access". The default value is "trap": Xen traps PMU accesses. In case of setting pmu_access to "native", Xen does not trap PMU accesses allowing all the guests to access PMU registers. However, guests cannot make use of PMU overflow interrupts as PMU uses PPI which Xen cannot route to guests. This option is only intended for development and testing purposes. Do not use this in production system. Signed-off-by: Michal Orzel --- docs/misc/xen-command-line.pandoc | 18 +++++++++++++++++ xen/arch/arm/traps.c | 33 ++++++++++++++++++++++++++++++- 2 files changed, 50 insertions(+), 1 deletion(-) diff --git a/docs/misc/xen-command-line.pandoc b/docs/misc/xen-command-line.pandoc index b175645fde..03637a9f6d 100644 --- a/docs/misc/xen-command-line.pandoc +++ b/docs/misc/xen-command-line.pandoc @@ -1813,6 +1813,24 @@ paging controls access to usermode addresses. ### ple_window (Intel) > `= ` +### pmu_access (arm) +> `= trap | native` + +> Default: `trap` + +Controls for accessing Performance Monitor Unit (PMU). + +By default Xen traps Performance Monitor accesses. +When setting pmu_access to `native`, Xen does not trap PMU accesses allowing +the guests to access PMU registers. This option is intended to aid monitoring +and measuring the performance. Setting pmu_access to `native` allows +all the guests to access PMU, however, there is no mechanism for forwarding +PMU overflow interrupt requests. + +*Warning* +This option is only intended for development and testing purposes. +Do not use this in production system. + ### psr (Intel) > `= List of ( cmt: | rmid_max: | cat: | cos_max: | cdp: )` diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c index 219ab3c3fb..d30e78b4d6 100644 --- a/xen/arch/arm/traps.c +++ b/xen/arch/arm/traps.c @@ -34,6 +34,7 @@ #include #include #include +#include #include #include @@ -77,12 +78,19 @@ static int debug_stack_lines = 40; #define stack_words_per_line 4 #endif +static const char __initconst warning_pmu_access[] = + "WARNING: PMU ACCESSES ARE NOW ENABLED\n" + "This option is intended to aid monitoring and measuring\n" + "the performance by allowing the guests to access PMU registers.\n" + "It has implications on the security of the system.\n" + "Please *DO NOT* use this in production.\n"; + integer_param("debug_stack_lines", debug_stack_lines); static enum { TRAP, NATIVE, -} vwfi; +} vwfi, pmu_access; static int __init parse_vwfi(const char *s) { @@ -95,6 +103,29 @@ static int __init parse_vwfi(const char *s) } custom_param("vwfi", parse_vwfi); +static int __init parse_pmu_access(const char *s) +{ + if ( !strcmp(s, "native") ) + pmu_access = NATIVE; + else + pmu_access = TRAP; + + return 0; +} +custom_param("pmu_access", parse_pmu_access); + +static int __init update_pmu_access(void) +{ + if ( pmu_access == NATIVE ) + { + WRITE_SYSREG(READ_SYSREG(MDCR_EL2) &~ (HDCR_TPM|HDCR_TPMCR), MDCR_EL2); + warning_add(warning_pmu_access); + } + + return 0; +} +__initcall(update_pmu_access); + register_t get_default_hcr_flags(void) { return (HCR_PTW|HCR_BSU_INNER|HCR_AMO|HCR_IMO|HCR_FMO|HCR_VM| -- 2.29.0 From xen-devel-bounces@lists.xenproject.org Wed Sep 01 12:47:53 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Sep 2021 12:47:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.176359.320921 (Exim 4.92) (envelope-from ) id 1mLPei-00071s-OJ; Wed, 01 Sep 2021 12:47:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 176359.320921; Wed, 01 Sep 2021 12:47:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLPei-00071l-KP; Wed, 01 Sep 2021 12:47:52 +0000 Received: by outflank-mailman (input) for mailman id 176359; Wed, 01 Sep 2021 12:47:51 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLPeh-00071f-Cq for xen-devel@lists.xenproject.org; Wed, 01 Sep 2021 12:47:51 +0000 Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id d08a981e-0b22-11ec-add6-12813bfff9fa; Wed, 01 Sep 2021 12:47:50 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d08a981e-0b22-11ec-add6-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1630500470; h=to:cc:references:from:subject:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=h6mJzdTcFw3IRJ6Tvbd87qhOMqz7nqvNglic+QwxbPI=; b=HhFzni5QH6luLYn1LAsYA3fNdt0OUyoJbJTThbazXXe3kHMhCcVd8HOU kSQrQ7iKSZC691bAXz+foqvG1F136S3rGvciTB1SSXSPk5e1lURmzfU2S dvd98sLQSeNhUTT7QivUBRh94j8qJC2v/GD85as5kgmJ2t1odseqpJtG9 A=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: yt6rC4h0IVg9WGAgQqBw+QI6Vyb4RHsSc6ZlVB+K0T/55JP6s6qj35S9ggo30I++PdE4fBkTFr UD2cYkH3DbnCECHRq9hRLxSqhqw+WvMyxBId3EmoXf/QlWSfIQkbJJtt2CefiqLayQ01zWdrDS zFst2jTkHAdQslKjesrQKNk2uN2UOdPy9OTTpBTkWHGX5BKcVDD8p5dlO5nr6X5mi/6OZ4Hpzb shOmxOSp/r0AIyJffE4nRU/dzjSRC59fxXjoSzZliKPubAs1ivOp3/cjr3Ggb0M+vIzTDqgg1r 7sHXvMP44Xpog+lgvMoVYiW3 X-SBRS: 5.1 X-MesageID: 52179159 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:O+qdP6yIvAOamiwdUOZ5KrPxouskLtp133Aq2lEZdPULSKOlfp GV8MjziyWYtN9wYhAdcdDpAtjkfZquz+8L3WB3B8bfYOCGghrUEGgG1+XfKlLbalXDH4JmpM Bdmu1FeafN5DtB/LbHCWuDYq8dKbC8mcjC74eurAYecegpUdAF0+4QMHfrLqQcfnghOXNWLu v/2iMKnUvaRZxBBf7LeEXtEtKz6OHjpdbDW1orFhQn4A6BgXeB76P7KQGR2lM7XylUybkv3G DZm0ihj5/T8s2T+1v57Sv+/p5WkNzuxp9qA9GNsNEcLnHJhhyzbIpsdrWetHQeof2p6nwtjN 7Qyi1Qcfhb2jf0RCWYsBHt0w7v3HIH7GLj80aRhT/ZrcnwVFsBeoB8rLMcViGcx1srvdl63q 4O9XmerYBrARTJmzm4z8TUVjlx/3DE40YKoKo2tThyQIEeYLheocg050VOCqoNGyr89cQODP RuNsfB//xbGGnqLEwxhlMfhOBEY05DWStvGiM5y4qoOnlt7TBEJnIjtYkidixqzuNld3EsjN 60QZiBl9l1P4QrhOxGdb88qWbeMB26ffv2ChPnHb3QLtBOB5v8ke+D3FwL3pDcRHUp9up+pH 2TaiIViYYNE3ieQPFmmqc7qSzwfA== X-IronPort-AV: E=Sophos;i="5.84,369,1620705600"; d="scan'208";a="52179159" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VehwfQI3Yr0WBQFibVvQEaG1LPfYEzpwEhoCcelziCNpSFcZGwoKLwYteeQkacAKGDWgtfOK5zV9bLWt2hmH4pYbuYcAVycf0a3j2EmD0OuBzrORMcUZkgx/pISnC2J+UwR8FUnB0AuGMNU7T6Srknurfflt6SX3E/6ZXE9teW7eZAVI8h4G9jO4RJHZeYwtUAlDHf5YDgoXJIRFC1D52CMJ8lkHc0w5GjD4ftcy9k0yO10w+ySnYaVnVN+ZUjAIXjh5gigw0q0tcZH2TeNpmVlvdy9rJ+jUoGYDav2nJZ5F+7Y/jthRBBUXsjrBpPmJo+cT2r8hEbc6bIAQODioQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tjDlw24xjL9N6LfcvdiORpfx0u28EjiV6lJoNjLfxq8=; b=W6o4kmppL91QG6I9Dz2uK6zVgiKL6PoXwcTmI8ViPCXT8oqW7ZoRwbIszzKSyCJj3o5ahfZCYDW+KkogUb9yWBRl1MXl0U6LVDQ4WonTHpz0GELWlCZgW30Pkk4A09ZhYZIflrLCgt2VTT7eSUfUGqJY0Z82qGqKS1KOctzpFPkhRAU9t/M/TUtPzIJRKTTE5qpNtkNgDmS7iD4RZKvWKaaxEl/lnBCV3vET1yKdWoo0aPqelgfuLKcmF29IETbYwEiAcbjL3k5t1yLaB5lMuekqc6RGGTOg4AH1mDBLrCoTUcr/SM55v2LKxlnwwZK3+Y9YbkqyWwpoKrl1rbkflw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tjDlw24xjL9N6LfcvdiORpfx0u28EjiV6lJoNjLfxq8=; b=d2uV98ZJ6Z8VgmoEuRoyExqVWaap36SQRaTIjQ9tF0Gkrob6LU4Hu5wQEijsKAMpyyYUh6C9D8SGe9I64bXxNl+JAhz9O1pjUHYCNOPLCvOTyYRqB8Ej6ofng8kUryW3ldVOMp/MjukUhZjFQNtMl7htzT+IYPwJfMV4kvUwIEc= To: Jan Beulich CC: Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , "xen-devel@lists.xenproject.org" References: <93ecc397-1293-69b1-e70d-3c5f9317229a@suse.com> <7f56c625-eee6-31c4-2d6f-bd7334867d83@citrix.com> <5d69d4c0-7a04-c3da-f971-616363c6d63d@suse.com> From: Andrew Cooper Subject: Re: [PATCH 2/4] x86/P2M: relax guarding of MMIO entries Message-ID: <62cb78c9-f4fd-76e7-225d-bc575f10850f@citrix.com> Date: Wed, 1 Sep 2021 13:47:40 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: <5d69d4c0-7a04-c3da-f971-616363c6d63d@suse.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: en-GB X-ClientProxiedBy: LO4P123CA0357.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18d::20) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5405d40e-c282-4aea-83a2-08d96d46b2f6 X-MS-TrafficTypeDiagnostic: BY5PR03MB4997: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: X8wG6yt5GYJNe95xxdetZ5DX+ZM7eoFiskJ9wiN7pW9/XFXmy9OxE6Uv3SjDET2d3AgfzzrjFzvsPpu7scxilLctrBjixUbclWOxlb9NKnXuOfRrMmZncSTewoa1h8xZadXhTjzOqvs/q21x/QdFUnpstanfV4aRhtIDHX0IYS1tn+hErZMY4s+UEFOdTJ9qlI68TJWKcwV/dWHFIXZpQZrmBkxSvIswK2FrF1k+IYjGgVkgyCCpy8VOMIMRTy+3wL/MeatLgQSPftlxZ9rNaTIzHB8qcA1DixE6u+OHXgei6TTyPQ671dKzNNZ2lLKEU4sxCmI5g01oGSDqJiyrwLtUhX9msdT+eBP1hmUvhYrgBNjRGgsGkPrNvjjoKvKOWdg4GsEyuajifesNcZIIafR09lB9dUoWKdA4KOTGuSwC4utqz8hypczeotCj47U1xsr2M3AuhGCn8nPgHPHuZpxc3mD3+nQAJuc2btJ1qAtlahCjgk7l4pTzt2t49st2htuj4GfWYW8mZ+u0eSc7Jbn8Pnya+TITdmNVTJm1ub3lqR4dQUU8mBuN+Na2LhW5ddgousfyyJZoQ7Qv24XzPsBLL3OQD8oD1IaO7QWR19Mqrrx+DC4y5gSlW94QfD4tz2PN38gSD8OOT0BirhA2kJJDwkjiQZuu+MbPYDQwKmPDoOqNdysOHvTRLUodaEVh5XcwfrNJCDa4W1tGmJurhaAs6PQ2D4/rt/wnREwmYko= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(396003)(39860400002)(366004)(346002)(136003)(956004)(86362001)(66476007)(66556008)(2616005)(16576012)(31696002)(66946007)(26005)(5660300002)(54906003)(36756003)(2906002)(478600001)(6666004)(316002)(8676002)(186003)(55236004)(4326008)(31686004)(53546011)(6486002)(6916009)(38100700002)(83380400001)(8936002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RkxJbGNGUUFYYzcyTUZnSDNGb092WXNva3pYR1FlYXo4RVQ4V3dKSVJRaklv?= =?utf-8?B?VDJrVmlsOEo0WDhVamYzNXAwOFoxUmY4TytWdlpGQzEvYkIvUnZCaHBWeXRi?= =?utf-8?B?aFdLT3o1ck5yWjBDeE1xZEZ5WU5iN2sxcGVPVzNHZmpDZGFLQUpFMkhQQ2hx?= =?utf-8?B?OUNKTWNnK2RPdzV2VDJkc2piQitvNXBOdWFKTWtaSzdidll2VkgyZXFyZVQx?= =?utf-8?B?VkVXZ1RXTHpqdS9ZL2E5MTdiWndkRkJaRlBadm1ITGtsbzhVQXBQd3pCcGRP?= =?utf-8?B?SjcxcFVGUHd2am9Sek5TZmU3M3NBM3VKZ3lUd05ONy9IUkdWVlV4dlFoZnQr?= =?utf-8?B?aWJLTFdtK0JENWR6VG8rdGJmRHQ1ZkxWcFlEdzFPSC9FYjdoMENXMk9uZFl2?= =?utf-8?B?akppQ2VVYWYzdUVndDZ3elBlSkZpOFhoSUE0Y25SbFVtUEUvVDd6R0NzUDhV?= =?utf-8?B?d3haUGJ0QkRob2RYaVNqQmhuYXM2ZkRXbktUbmt0Ry9PcEgwem9ZUTlqRGNu?= =?utf-8?B?WlB0a3dpelkvclRVMTlsSUtNOUhUYzg0ZGRDNzRsUGdPSnIwMkdNMVR4VGdq?= =?utf-8?B?TjJiRGlpRytzV2RmVTFWdVFJU0FXYmtWUUs2bTdtbGF3QVBSU1JDTGVJdVNq?= =?utf-8?B?R2ZSYXM3VVE2QjNkU2lTNFVyZy8yUG9ONlZpaVNxb3JLaU1rY0NxZXNzb09j?= =?utf-8?B?eCs0TTFiUzRKSWh4N09vNTJTVmRUUU9FNS9HNlNoK2wzamNQNWF4N0dydm13?= =?utf-8?B?ajE0K0o4SzBxRWVFRFhCY2xsd0xiVElaWVF0VlRIY0RPektLaHVoV09VWkJO?= =?utf-8?B?WFJ1eUFQSzRaZG9ZZzVZbFB1QllFNUpPMlgwcXRvUWE4TGdWMkRoejFpVHlr?= =?utf-8?B?QlB2cjZwdnJkbHlPMW0zMWxibnBRc0xhdnU1YXo4VFVWMVNGL1E5eTBuOHY4?= =?utf-8?B?WC9ZOFNsbkJxM2lld2MxSHJudEZ4cGRmcGVrOTYxNjBwUzBVaUFLMEh4cnR4?= =?utf-8?B?RW5RTDZ3OWVBMlBQNkpyaHlnS1UyK29pUUlGNnNrNThIUUhRYk5TdUpDUFc5?= =?utf-8?B?YWV5VW1GeU9MaWo2b3VtM3FKcWxjZ29zSFpESG9JejZ5cGUxZlQ3U2JsM2tW?= =?utf-8?B?eVdOZzNRM1JINDdjd3l3cEJMYzI4b3plcmJnYXpvQ0hKRUwzL1JmbjUwcVBE?= =?utf-8?B?WkowRHNRY0lCNnVNeUVMR3RPV3QxeldWakxwYW11ZC9lbWFhTGRPazlFS0R0?= =?utf-8?B?L3llZ3I4MGhENjhkVWRFOUlZK3N5MjZ0VVhRb0c1TXE2dmpvdTJPWStLcFdH?= =?utf-8?B?RTJKOHRHYTZSOVBtK0w5cVhsY2x0dnJWSmR3QUFEcFBZcExObWpMRkpsS0dD?= =?utf-8?B?UW1zUTJadzVrcUROOWFlWE1LTElqRy84MjZiVi9udzM4eHAyamVoMXdRVDBz?= =?utf-8?B?SklCcGowMnBLWVZ1TkcvNW5qejNENUEzTWFSRHRsZzhZblJ1QTBuK216cm5q?= =?utf-8?B?TTNiR1NRR1gzQ2k2VlRocGc0OUVEaGhGSUorSVQ5M2pITU9wUm5mTkFsdHdj?= =?utf-8?B?eXhQdys0cVRVMEdtdlMrdEtPemY5bE1iZ0phS3VadElERXhJcGNqT2RwQ1Rj?= =?utf-8?B?eGU3YW12blNHSXNDVHVacUZHNm54NkdDUFR0WUQzZTBHQU5VcWQ2SWxMOWtW?= =?utf-8?B?ekgwOUorT1R2MDdKMGsydzlzempPZmQ2NmYxb3plNE9UUmJYMEdiZVJJTjZj?= =?utf-8?Q?92sogwZlfbxijYlchVOFquK31v7toqtdoKHlx0G?= X-MS-Exchange-CrossTenant-Network-Message-Id: 5405d40e-c282-4aea-83a2-08d96d46b2f6 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Sep 2021 12:47:46.8553 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: CF3Rl+KfsU6yvVA4Spcl/1DnmOGEn9Fw3gEwZWwv0KhXHL2xnfYG9N7ddWfRcZapweD8K3eO23tlwMUr6EUoJDPhEFMeeaB1pO+jvM3gwDI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR03MB4997 X-OriginatorOrg: citrix.com On 31/08/2021 16:38, Jan Beulich wrote: > On 31.08.2021 17:25, Andrew Cooper wrote: >> On 31/08/2021 14:26, Jan Beulich wrote: >>> On 31.08.2021 15:16, Andrew Cooper wrote: >>>> On 30/08/2021 14:02, Jan Beulich wrote: >>>>> Further permit "access" to differ in the "executable" attribute. Whil= e >>>>> ideally only ROM regions would get mapped with X set, getting there i= s >>>>> quite a bit of work. Therefore, as a temporary measure, permit X to >>>>> vary. For Dom0 the more permissive of the types will be used, while f= or >>>>> DomU it'll be the more restrictive one. >>>> Split behaviour between dom0 and domU based on types alone cannot >>>> possibly be correct. >>> True, but what do you do. >>> >>>> DomU's need to execute ROMs too, and this looks like will malfunction = if >>>> a ROM ends up in the region that HVMLoader relocated RAM from. >>>> >>>> As this is a temporary bodge emergency bugfix, don't try to be clever = - >>>> just take the latest access. >>> And how do we know that that's what is going to work? >> Because it's the pre-existing behaviour. > Valid point. But for the DomU case there simply has not been any > pre-existing behavior. Hence my desire to be restrictive initially > there. But you're conflating a feature (under question anyway, because I gave you an example where I expect this will collide in a regular domU already), with an emergency bugfix to unbreak staging caused by an unexpected interaction in a security hotfix. At an absolute minimum, this patch needs splitting in two to separate the bugfix from the proposed feature. >>> We should >>> strictly accumulate for Dom0. And what we do for DomU is moot for >>> the moment, until PCI passthrough becomes a thing for PVH. Hence >>> I've opted to be restrictive there - I'd rather see things break >>> (and getting adjusted) when this future work actually gets carried >>> out, than leave things permissive for no-one to notice that it's >>> too permissive, leading to an XSA. >> Restricting execute permissions is something unique to virt.=C2=A0 It do= esn't >> exist in a non-virtualised system, as I and D side reads are >> indistinguishable outside of the core. >> >> Furthermore, it is inexpressible on some systems/configurations. >> >> Introspection is the only technology which should be restricting execute >> permissions in the p2m, and only when it takes responsibility for >> dealing with the fallout. > IOW are you saying that the calls to set_identity_p2m_entry() > (pre-dating XSA-378) were wrong to use p2m_access_rw? Yes. > Because that's > what's getting the way here. On a real machine, you really can write some executable code into an E820 reserved region and jump to it.=C2=A0 You can also execute code from real BARs is you happen to know that they are prefetchable (or you're a glutton for UC reads...) And there is the WPBT ACPI table which exists specifically to let firmware inject drivers/applications into a windows environment, and may come out of the SPI ROM in the first place. Is it sensible to execute an E820 reserved region, or unmarked BAR?=C2=A0 Probably not. Should it work, because that's how real hardware behaves?=C2=A0 Absolutely. Any restrictions beyond that want handling by some kind of introspection agent which has a policy of what to do with legal-but-dodgy-looking actions= . > Plus, as a side note, then we don't even have e.g. IOMMUF_executable. Just as I vs D side reads are indistinguishable outside of the CPU core, the same is in principle true for PCI devices which execute code (e.g. GPU shaders).=C2=A0 Reads on the bus are just reads. That said, the latest SIOV spec does appear to include the ER (Execution Request) bit for use with PASSID/Shared-Virtual-Memory, which interacts with the EPT-X/ia32-NX bits, and goes as far as having SMEP/SMAP bits in the IOMMU configuration.=C2=A0 I'm not sure if this is in released hardware yet, but it's clearly on the horizon.=C2=A0 I can't spot any execute relate= d controls in the AMD IOMMU spec, although it does have user/supervisor for PASSID/SVM. ~Andrew From xen-devel-bounces@lists.xenproject.org Wed Sep 01 12:55:52 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Sep 2021 12:55:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.176367.320938 (Exim 4.92) (envelope-from ) id 1mLPmB-0000Ca-Jt; Wed, 01 Sep 2021 12:55:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 176367.320938; Wed, 01 Sep 2021 12:55:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLPmB-0000CT-G3; Wed, 01 Sep 2021 12:55:35 +0000 Received: by outflank-mailman (input) for mailman id 176367; Wed, 01 Sep 2021 12:55:34 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLPmA-0000CN-I3 for xen-devel@lists.xenproject.org; Wed, 01 Sep 2021 12:55:34 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLPm6-0002Dm-PT; Wed, 01 Sep 2021 12:55:30 +0000 Received: from [54.239.6.187] (helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1mLPm6-0007By-Hy; Wed, 01 Sep 2021 12:55:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=2jdGvkMeJGwBMQ7U7T6XK/oCun6VmqB1B0FRR7GMfzI=; b=dtAyaE/e4bARK5hKVTA1wVYfVO l3n2kZkw2WaHB57QZzLrXIrWn+uwBcorCRlr6Xb6sR7Av3cLGZIWSGpiAsXiqTpDiXv9aPHoWMkwE wzL5m0nuyYYXTHozaFytCXDtHsJ9lcKQ8jYKmgJiSO0ds/E0LgDGM6djJmak31SKh+w4=; Subject: Re: [PATCH] xen/arm: Introduce pmu_access parameter To: Michal Orzel , xen-devel@lists.xenproject.org Cc: Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Stefano Stabellini , Wei Liu , Volodymyr Babchuk , bertrand.marquis@arm.com References: <20210901124308.31573-1-michal.orzel@arm.com> From: Julien Grall Message-ID: <599515f0-4b8a-3a71-caea-b17ec27c9123@xen.org> Date: Wed, 1 Sep 2021 13:55:28 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210901124308.31573-1-michal.orzel@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Hi, On 01/09/2021 13:43, Michal Orzel wrote: > Introduce new Xen command line parameter called "pmu_access". > The default value is "trap": Xen traps PMU accesses. > In case of setting pmu_access to "native", Xen does not trap > PMU accesses allowing all the guests to access PMU registers. > However, guests cannot make use of PMU overflow interrupts as > PMU uses PPI which Xen cannot route to guests. > > This option is only intended for development and testing purposes. > Do not use this in production system. I am afraid your option is not safe even in development system as a vCPU may move between pCPUs. However, even if we restricted the use to pinned vCPU *and* dedicated pCPU, I am not convinced that exposing an half backed PMU (the overflow interrupt would not work) to the guest is the right solution. This likely means the guest OS would need to be modified and therefore the usage of this option is fairly limited. So I think the first steps are: 1) Make the PPI work. There was some attempt in the past for it on xen-devel. You could have a look. 2) Provide PMU bindings With that in place, we can discuss how to expose the PMU even if it is unsafe in some conditions. > > Signed-off-by: Michal Orzel > --- > docs/misc/xen-command-line.pandoc | 18 +++++++++++++++++ > xen/arch/arm/traps.c | 33 ++++++++++++++++++++++++++++++- > 2 files changed, 50 insertions(+), 1 deletion(-) > > diff --git a/docs/misc/xen-command-line.pandoc b/docs/misc/xen-command-line.pandoc > index b175645fde..03637a9f6d 100644 > --- a/docs/misc/xen-command-line.pandoc > +++ b/docs/misc/xen-command-line.pandoc > @@ -1813,6 +1813,24 @@ paging controls access to usermode addresses. > ### ple_window (Intel) > > `= ` > > +### pmu_access (arm) > +> `= trap | native` > + > +> Default: `trap` > + > +Controls for accessing Performance Monitor Unit (PMU). > + > +By default Xen traps Performance Monitor accesses. > +When setting pmu_access to `native`, Xen does not trap PMU accesses allowing > +the guests to access PMU registers. This option is intended to aid monitoring > +and measuring the performance. Setting pmu_access to `native` allows > +all the guests to access PMU, however, there is no mechanism for forwarding > +PMU overflow interrupt requests. > + > +*Warning* > +This option is only intended for development and testing purposes. > +Do not use this in production system. > + > ### psr (Intel) > > `= List of ( cmt: | rmid_max: | cat: | cos_max: | cdp: )` > > diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c > index 219ab3c3fb..d30e78b4d6 100644 > --- a/xen/arch/arm/traps.c > +++ b/xen/arch/arm/traps.c > @@ -34,6 +34,7 @@ > #include > #include > #include > +#include > > #include > #include > @@ -77,12 +78,19 @@ static int debug_stack_lines = 40; > #define stack_words_per_line 4 > #endif > > +static const char __initconst warning_pmu_access[] = > + "WARNING: PMU ACCESSES ARE NOW ENABLED\n" > + "This option is intended to aid monitoring and measuring\n" > + "the performance by allowing the guests to access PMU registers.\n" > + "It has implications on the security of the system.\n" > + "Please *DO NOT* use this in production.\n"; > + > integer_param("debug_stack_lines", debug_stack_lines); > > static enum { > TRAP, > NATIVE, > -} vwfi; > +} vwfi, pmu_access; > > static int __init parse_vwfi(const char *s) > { > @@ -95,6 +103,29 @@ static int __init parse_vwfi(const char *s) > } > custom_param("vwfi", parse_vwfi); > > +static int __init parse_pmu_access(const char *s) > +{ > + if ( !strcmp(s, "native") ) > + pmu_access = NATIVE; > + else > + pmu_access = TRAP; > + > + return 0; > +} > +custom_param("pmu_access", parse_pmu_access); > + > +static int __init update_pmu_access(void) > +{ > + if ( pmu_access == NATIVE ) > + { > + WRITE_SYSREG(READ_SYSREG(MDCR_EL2) &~ (HDCR_TPM|HDCR_TPMCR), MDCR_EL2); > + warning_add(warning_pmu_access); > + } > + > + return 0; > +} > +__initcall(update_pmu_access); > + > register_t get_default_hcr_flags(void) > { > return (HCR_PTW|HCR_BSU_INNER|HCR_AMO|HCR_IMO|HCR_FMO|HCR_VM| > Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Sep 01 13:08:25 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Sep 2021 13:08:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.176373.320948 (Exim 4.92) (envelope-from ) id 1mLPyN-0001up-NP; Wed, 01 Sep 2021 13:08:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 176373.320948; Wed, 01 Sep 2021 13:08:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLPyN-0001ui-KQ; Wed, 01 Sep 2021 13:08:11 +0000 Received: by outflank-mailman (input) for mailman id 176373; Wed, 01 Sep 2021 13:08:10 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLPyM-0001uc-1j for xen-devel@lists.xenproject.org; Wed, 01 Sep 2021 13:08:10 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id a906c2b8-1a14-4c4a-bd88-808982da25ca; Wed, 01 Sep 2021 13:08:08 +0000 (UTC) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04lp2059.outbound.protection.outlook.com [104.47.13.59]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-28-LBB-0BR0M1afRj73yfeIcw-1; Wed, 01 Sep 2021 15:08:06 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR0402MB3934.eurprd04.prod.outlook.com (2603:10a6:803:1b::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.23; Wed, 1 Sep 2021 13:08:04 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4478.019; Wed, 1 Sep 2021 13:08:04 +0000 Received: from [10.156.60.236] (37.24.206.209) by PR3P189CA0077.EURP189.PROD.OUTLOOK.COM (2603:10a6:102:b4::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.17 via Frontend Transport; Wed, 1 Sep 2021 13:08:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a906c2b8-1a14-4c4a-bd88-808982da25ca DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1630501687; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kKOJUpvcTFM8hyAhhxDP25PXxQ/V9ZW9KDvbc9qzjtc=; b=W3SGPKuwsFly/nRvsu+u7cKqF0qou50X72FHXDJ7LZ+4HvCgWfvhYhxzhacFnAk4h7ElyK rePzS95B1Q0B8n6KEbiMduapheNoEoI9NE4esCvAFnrM7O5PNsqVAlyWMheWX3UfU3YuA4 ZrxhtW6VQ3lONXnHa3Nxt7iXKqwkKRA= X-MC-Unique: LBB-0BR0M1afRj73yfeIcw-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SDDSdJLfPuegCUeDLRclJQFt4Tt4PDzQ9+wMnf9KuHABi1KthxETQzUrDvSbDAIrpWuean7z1HtUYAHbSOsKG7tP+grvxbqvChoQc935X92UXv/jRbZLg38VvBsW037bcayDBAiKyRagRLwqZcHcFEL3Lv40r0ytdv5qrWVDFPqYZtGE9G4f7j4iozq5vhwLIm4hWSaP5bBWhof0yNuCtUhXl4pmPmsyfdmJPrqNI/8mNRx5GH5sT99jBDAdSqYoqhQkAibdTvopdqFdYsCl3yl4WyvA+nfsfO0JcmKjY9Y1Qf4nSvGTQFOovi7xvefYT7kQsnd9gS1vk/6O2BJX/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Zj3a51YS0sJYi/JgKZoY15y3HvCrl4xmlsN+RSvg7T4=; b=KaRX+6TnU6ZH7U7+J7j0O8V5NYN/X67Q5Kb3gLKgTtQ7T5gbuzl/MD9h5OUQ9tGn/U2t/g7wI1EqhK8ue6RFm46PHxtCgUF8az8/kfTkjOmlA59mh+R2hVRK6AohMZiuY2MDEwppvyWWHuYXrb42WKoAnxHM3xESEzO6LRju4ns3t3+3onTqfDOUU3MdnKDT0gQuO3TTP+B3rPwbOxSIGGiPd/muM5gOWH0ncX/w0tcLYv7EW3OCwKhyA6bmCjMRZA1R8OMnr85ylEuY5yk5HNTNsh1IUfhkXYPdSNJdynNofbBMXprqKpS5tq3GkQHjLjy2Cz/pWdshP88uv0tyBA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com; Subject: Re: [PATCH 2/4] x86/P2M: relax guarding of MMIO entries To: Andrew Cooper CC: Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , "xen-devel@lists.xenproject.org" References: <93ecc397-1293-69b1-e70d-3c5f9317229a@suse.com> <7f56c625-eee6-31c4-2d6f-bd7334867d83@citrix.com> <5d69d4c0-7a04-c3da-f971-616363c6d63d@suse.com> <62cb78c9-f4fd-76e7-225d-bc575f10850f@citrix.com> From: Jan Beulich Message-ID: <818cc08e-8372-35c4-935f-86a87cceec75@suse.com> Date: Wed, 1 Sep 2021 15:08:02 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: <62cb78c9-f4fd-76e7-225d-bc575f10850f@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: PR3P189CA0077.EURP189.PROD.OUTLOOK.COM (2603:10a6:102:b4::22) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 14109199-61f2-43d9-12a6-08d96d498897 X-MS-TrafficTypeDiagnostic: VI1PR0402MB3934: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ehrCuRY1QnwLcCPSjdSepu4DdseauyPFCyw+m/luUE1ynD1v5dFPWyosTDBwUH1UsZKpJhXu1ywDxI0ab4XPf6BY5ySC8j0c/TED8cizNgaCdbeWSvKSbkj+AZoJA8fgimVO4IR6UGx42RtCddjf6h/JWU59zY0+Qs+xQbch6Nj4YgzFiao+wqMc3eHPUlpsh7CCLqbHDTpwS9OCCuVNtczqagOrBn6C4k1poW6noLX0jFJ0QJhfh5xG7i+T9p3M9gxknVevPvN6a9IYuBDt5Mx0wOMg+lychpBInvDVUqpVMFz7BkWUAwbSPbRtZju9sChsgjQrphP1ZDkAica+ufjmOqRMj4qDU/ryrrVFxsTImr/purj3OCzkHpKKf9ew9IvdNfXmFySdWF7nVPFh7IOwOzVTuzQNQV1abVgPcdFUazLXp6eleIjJgUUnkrDBSRsHbNI2J8pnY9Q5Pag1G4w8dINQ2ZFLdpTM3RkCbJ5gvmic200wG9inFC2tiotnqmn+uJOKztIq9SfRv1z4ZNwSP796GwYfm16I1aEBBxWc/ajlX3/F03wmImHO+fdHGWLEC8eUtdgEEWUS+PmuxEOG95o09r2yp+KRU0OQ+e/HPcnHo1EgIEYGtAeyNENM2LM+v4sHMFUnsgbS8TZ2BeA98hX2ip8tbiE01nbpoNGXxG9saZL4YPmTyL27cvFjHvtnXZv8LIMfW3d5eNeubGOzkUHqq3aGuaECUXQ+TEQ= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(346002)(376002)(39860400002)(396003)(136003)(366004)(54906003)(6916009)(36756003)(38100700002)(4326008)(31696002)(5660300002)(31686004)(83380400001)(26005)(316002)(66946007)(53546011)(2906002)(66556008)(8676002)(66476007)(6486002)(16576012)(956004)(8936002)(478600001)(86362001)(2616005)(186003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?5tq/BWyhVfmd1Z3Bt6/LnQkS8XkSR8ALSkf5dBRb2DlAoLK8+jqiLyh4d3nW?= =?us-ascii?Q?f3r9wgOkyGoiFlzLmOUv4gJkRks/s+Oi6BnJyuYtxH41vzIpu91EuIrd9rkw?= =?us-ascii?Q?ruUtuVKtJFF5qibtirW+SLJ4CnoCDlmFhODMkYz0SYVpnuTB2bRrlGN5h0Bn?= =?us-ascii?Q?Ve+MXURaMXLeH7tLZN3pCSVdwyemAmL9wdrXytBJV2G0xcKzlo/MP2M9b3Fl?= =?us-ascii?Q?IxkHuaoFHnqa7I7f+oBC/fwtX5biNK/3qot+x5tfvfU80Vd8CiIaEx0Nhmmp?= =?us-ascii?Q?4zNFjI7b0Bi/xBnxYz8Om+1bargQ6+yb7c5A9pANSFOIsyI80yTPOPBy1+8n?= =?us-ascii?Q?YWwvp91L85gjhrGJWAW441xdrT4/Ry+nsI+colizqJB0wKY3DFBNgkA+YtAc?= =?us-ascii?Q?bF+oyTnHm68SkFTjgIzEPVGfFdgI7jyIDLd2jtzIy8rITdq8LgDqlslXTNbw?= =?us-ascii?Q?Ym2pqn2iqbq9E661AuMZYHiA8hGL330tOiRhm7a+/rv29tcwBSUAnCEkM8yL?= =?us-ascii?Q?qBA7P71piVAbtfCzQtXZYM495iVoPYuJRmpHbYLtiEojewLzAaDoMzhv5AAy?= =?us-ascii?Q?iCouckIyECw/3AqY9fw1QC+Km+0EheDetXDispyDJqCq6VKnKh/r2C9hplj0?= =?us-ascii?Q?8OfVER3QKwUgRDSEo4W5Tx3arjIg1bJpUEGEHkcXPQBZk2LpoK4ULXXpK7b7?= =?us-ascii?Q?v9BEzaRQ6l9GAV2vG3aYLETcvQlF0uzmxdcwWX6u4Atvaa6i+WAsNO48/tTa?= =?us-ascii?Q?Nnv6+zO2266HaqJAO5d1PzKEjVnFp6Dadol9XAeSCdo7EzKNa9SEfoYKaS+n?= =?us-ascii?Q?ZvYDd+q1MBbxBOYDpgu0arD9zNwMka0zf0MjTr8PXxeJ4RuSwIlE1oVPcpW9?= =?us-ascii?Q?1gj5QYt8wwPYx6FmJiYs1YhMEFMYrn+IqY3HbCh9PxrT4gnUkYzbj4KcYk0s?= =?us-ascii?Q?SSJGLOusQ08m1MVHsuanbm+zbkGpbWs0THsw6zoJ3t6PK986veczVHj2erwY?= =?us-ascii?Q?+Hh016a5NN7JKbADRlNkXFuekexECRwT4ZnDpmJ8AlPFQ+ZtC/ncU3Z7Q51j?= =?us-ascii?Q?Anh0+/b8JmIUjoaFUk2JGbJbNUlSdHboja4NdmHv7iHntNxxGww+NwWweA6q?= =?us-ascii?Q?yDpyjFFKl9CvgBmAhwv3ELm8FrSAGWszQPf4zV4HcRxzmWUoch7A9uu6szjy?= =?us-ascii?Q?AfzQFbOyReoorxqrgDXhUAHA4FA6uan+hR8qmxiFSjGrC7ZHnyxAlNK33w/9?= =?us-ascii?Q?7HMUU72fkCzrnYnmDCaDUK4wsbgr/3ysS1NCs3kjZ9dvFTjns/tWvS69zI8g?= =?us-ascii?Q?iJ0sjqkVWZWQiTeHdY3vDjCZ?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 14109199-61f2-43d9-12a6-08d96d498897 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Sep 2021 13:08:04.5705 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rn+5t6xCfAYqUfx/0xwYygrvSZA139ZK7GgMLpEEWtvUgBVcr8w46iWrUN18FHA3slZiiH3xMEpEtndDLD691g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3934 On 01.09.2021 14:47, Andrew Cooper wrote: > On 31/08/2021 16:38, Jan Beulich wrote: >> On 31.08.2021 17:25, Andrew Cooper wrote: >>> On 31/08/2021 14:26, Jan Beulich wrote: >>>> On 31.08.2021 15:16, Andrew Cooper wrote: >>>>> On 30/08/2021 14:02, Jan Beulich wrote: >>>>>> Further permit "access" to differ in the "executable" attribute. Whi= le >>>>>> ideally only ROM regions would get mapped with X set, getting there = is >>>>>> quite a bit of work. Therefore, as a temporary measure, permit X to >>>>>> vary. For Dom0 the more permissive of the types will be used, while = for >>>>>> DomU it'll be the more restrictive one. >>>>> Split behaviour between dom0 and domU based on types alone cannot >>>>> possibly be correct. >>>> True, but what do you do. >>>> >>>>> DomU's need to execute ROMs too, and this looks like will malfunction= if >>>>> a ROM ends up in the region that HVMLoader relocated RAM from. >>>>> >>>>> As this is a temporary bodge emergency bugfix, don't try to be clever= - >>>>> just take the latest access. >>>> And how do we know that that's what is going to work? >>> Because it's the pre-existing behaviour. >> Valid point. But for the DomU case there simply has not been any >> pre-existing behavior. Hence my desire to be restrictive initially >> there. >=20 > But you're conflating a feature (under question anyway, because I gave > you an example where I expect this will collide in a regular domU > already), I don't think your example fits: hvmloader moving RAM will first convert the p2m slot to non-present. Then a ROM page can get mapped there quite fine. A direct transition (without going through n/p) would not work independent of the change here: The MFNs would differ, as would the p2m types. > with an emergency bugfix to unbreak staging caused by an > unexpected interaction in a security hotfix. >=20 > At an absolute minimum, this patch needs splitting in two to separate > the bugfix from the proposed feature. Well, okay, I will split the patch, despite not being convinced this will do us any good - we'd backport just the part you consider a bug fix, but not the part you deem a feature (and which I consider part of the bug fix). >>>> We should >>>> strictly accumulate for Dom0. And what we do for DomU is moot for >>>> the moment, until PCI passthrough becomes a thing for PVH. Hence >>>> I've opted to be restrictive there - I'd rather see things break >>>> (and getting adjusted) when this future work actually gets carried >>>> out, than leave things permissive for no-one to notice that it's >>>> too permissive, leading to an XSA. Actually I think I was missing an important aspect here: The code in question gets used not only for PVH, but also for HVM, where pass- through is a thing. Hence I'll restrict the "feature" part to Dom0 for now. >>> Restricting execute permissions is something unique to virt.=C2=A0 It d= oesn't >>> exist in a non-virtualised system, as I and D side reads are >>> indistinguishable outside of the core. >>> >>> Furthermore, it is inexpressible on some systems/configurations. >>> >>> Introspection is the only technology which should be restricting execut= e >>> permissions in the p2m, and only when it takes responsibility for >>> dealing with the fallout. >> IOW are you saying that the calls to set_identity_p2m_entry() >> (pre-dating XSA-378) were wrong to use p2m_access_rw? >=20 > Yes. >=20 >> Because that's >> what's getting the way here. >=20 > On a real machine, you really can write some executable code into an > E820 reserved region and jump to it.=C2=A0 You can also execute code from > real BARs is you happen to know that they are prefetchable (or you're a > glutton for UC reads...) >=20 > And there is the WPBT ACPI table which exists specifically to let > firmware inject drivers/applications into a windows environment, and may > come out of the SPI ROM in the first place. >=20 >=20 > Is it sensible to execute an E820 reserved region, or unmarked BAR?=C2=A0 > Probably not. >=20 > Should it work, because that's how real hardware behaves?=C2=A0 Absolutel= y. >=20 > Any restrictions beyond that want handling by some kind of introspection > agent which has a policy of what to do with legal-but-dodgy-looking actio= ns. IOW you suggest we remove p2m_access_t parameters from various functions, going with just default access? Of course, as pointed out in another reply, we'll need to split p2m_mmio_direct into multiple types then, at the very least to honor the potential r/o restriction of AMD IOMMU unity mapped regions. (FAOD all of this isn't a short term plan anyway, at least afaic.) Jan From xen-devel-bounces@lists.xenproject.org Wed Sep 01 13:10:50 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Sep 2021 13:10:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.176380.320960 (Exim 4.92) (envelope-from ) id 1mLQ0w-0003Iq-AN; Wed, 01 Sep 2021 13:10:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 176380.320960; Wed, 01 Sep 2021 13:10:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLQ0w-0003Ii-7L; Wed, 01 Sep 2021 13:10:50 +0000 Received: by outflank-mailman (input) for mailman id 176380; Wed, 01 Sep 2021 13:10:49 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLQ0v-0003Ic-N5 for xen-devel@lists.xenproject.org; Wed, 01 Sep 2021 13:10:49 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (unknown [40.107.20.59]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id da6234c4-7ba4-4d9a-871e-c0fb449e7526; Wed, 01 Sep 2021 13:10:44 +0000 (UTC) Received: from DU2PR04CA0296.eurprd04.prod.outlook.com (2603:10a6:10:28c::31) by AM6PR08MB4262.eurprd08.prod.outlook.com (2603:10a6:20b:b4::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.23; Wed, 1 Sep 2021 13:10:43 +0000 Received: from DB5EUR03FT062.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:28c:cafe::9b) by DU2PR04CA0296.outlook.office365.com (2603:10a6:10:28c::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.17 via Frontend Transport; Wed, 1 Sep 2021 13:10:42 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT062.mail.protection.outlook.com (10.152.20.197) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.17 via Frontend Transport; Wed, 1 Sep 2021 13:10:42 +0000 Received: ("Tessian outbound 5918cb94a4b5:v103"); Wed, 01 Sep 2021 13:10:42 +0000 Received: from 4568ce9c777a.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id D4AAC822-4C85-48D1-BCF6-987B4E5F6BD3.1; Wed, 01 Sep 2021 13:10:35 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 4568ce9c777a.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 01 Sep 2021 13:10:35 +0000 Received: from PAXPR08MB6446.eurprd08.prod.outlook.com (2603:10a6:102:12d::10) by PA4PR08MB6080.eurprd08.prod.outlook.com (2603:10a6:102:ec::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.23; Wed, 1 Sep 2021 13:10:34 +0000 Received: from PAXPR08MB6446.eurprd08.prod.outlook.com ([fe80::c029:ed0:82e7:3c2f]) by PAXPR08MB6446.eurprd08.prod.outlook.com ([fe80::c029:ed0:82e7:3c2f%6]) with mapi id 15.20.4457.024; Wed, 1 Sep 2021 13:10:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: da6234c4-7ba4-4d9a-871e-c0fb449e7526 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qwJnAE7Gxld7BbtZEYeSNKlissKtld1AdmcWjzKLjfU=; b=4HYkgxs7k5oT0SuUzKVcOVLnZSFL4ddFc/UiJbnriMkAK7uRzJV5G6V6h0rg+BIOSzH2L264a5QnHlPhhfSrD83A8Q4tyODGj9fts4bC5TAE19fi296CZ3SWS9PmDm3Owt2u+WQiPJ/kikLfvIOPbnLOjXKoPzFOl+Guonuz8lE= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: f1b80aaeefa67559 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ox+UeuvfD6mMTfI1bDlPDOFzHXCrGqVSTRjP+7fOOWey9O/jR8C1h8KgnkP71zABZULuNFO90v5RRKxbFrIMwxzvBXnqfEruA0UGgakvkCO20HIJJKX5Tl3e2tVK3DuZJZHqbMKf49JdPp4cpBGseTzdP4BH9iLVvP+Hc1GdX7OSGRJqIMtxcLCMjYqn6EPXlh8RJM+GUNwdwZV7BIF6wPK8DWlWmD2LRSSKW+hIg+DKcDEn5ojZvLyVY/TSwOREzqGt54Baoqq9gHqf1MDgPrtTldKqz7BFAiRLat3tMQMOGkJxxCFIgICo7NFIn84+Ql/PksuULkmDPlY1beSlxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qwJnAE7Gxld7BbtZEYeSNKlissKtld1AdmcWjzKLjfU=; b=I5JGzPpq/q6Ln+qwQ1lnz7T9YYjrJV0UADUCbIerrXuWccKa8lvgKCt8gZkDyeRrHayO3TD69v5T4mKeLsXRz5ABUaNyZJn2FJWrGANJ0cHnDZXCGAmPvN9QZVe58NU/hjMlrg7o3tFUatSGe/2IaAuLQPmGMpUhskA31ULOKSAl5PscCHrlcbGFqrHKOs6QyVDRGph3FFaY0Vyuxs4335MQ3XXwn2CzGIRhutZv8eaUkuZnxqmaF3gCDCf3e8w3WHHkSOnVg1tTkJQZgsU6GajdVNNedKJ1GQmTKRCOP4kNFSIBR6au0VSnS/2M4YM5evQf4jUBGqrS2L2V+FJr/A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qwJnAE7Gxld7BbtZEYeSNKlissKtld1AdmcWjzKLjfU=; b=4HYkgxs7k5oT0SuUzKVcOVLnZSFL4ddFc/UiJbnriMkAK7uRzJV5G6V6h0rg+BIOSzH2L264a5QnHlPhhfSrD83A8Q4tyODGj9fts4bC5TAE19fi296CZ3SWS9PmDm3Owt2u+WQiPJ/kikLfvIOPbnLOjXKoPzFOl+Guonuz8lE= From: Bertrand Marquis To: Julien Grall CC: Michal Orzel , "xen-devel@lists.xenproject.org" , Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Stefano Stabellini , Wei Liu , Volodymyr Babchuk Subject: Re: [PATCH] xen/arm: Introduce pmu_access parameter Thread-Topic: [PATCH] xen/arm: Introduce pmu_access parameter Thread-Index: AQHXny72/ET98Hho/USYtlrYv98fUauPIugAgAAENgA= Date: Wed, 1 Sep 2021 13:10:33 +0000 Message-ID: <44B48162-EB44-4295-9629-2D95A40D7232@arm.com> References: <20210901124308.31573-1-michal.orzel@arm.com> <599515f0-4b8a-3a71-caea-b17ec27c9123@xen.org> In-Reply-To: <599515f0-4b8a-3a71-caea-b17ec27c9123@xen.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3654.120.0.1.13) Authentication-Results-Original: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com; x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: 9672f376-092a-468a-7bb7-08d96d49e72b x-ms-traffictypediagnostic: PA4PR08MB6080:|AM6PR08MB4262: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:5797;OLM:5797; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: tynD5neOP/ZjryYfOQbXwLD3c2WawOOVSrQPmDAW4Gf609g1WBTrQ8J4of/1cCJGYFJyggnDqtZrZ03vpogd0vSejekcNrZD5uTioq3jhs1TWVT42NY0wAZ+YYQoR8lR6oZxAe+lUDVR7zSNg13RTdQguIpYQ8ojA/0cjPtQUtR3dRXyk+Ust5L3d+315r444aGmQZyiTmUaYsE10zEfXNVsw4aKvalJUaRegfSs2dEkjqM/uvrtaUgX+fXcSRSSNVbWLFroyXFmaYKGcxouSr1OZjqX+KDJdPnVM6s6EViKVy7IHo9aHtFaLjh1iQarJWHRyIENn6t52jkfINEgHmwJOOqxXFxduqiRYHOcD461t3nUBd3IKpPoo3v6/5QcFVd/t3dlAAjOI1vrDkkFAPMLjc1UBaZOpm1nZyhTcN3GgeyBuCqExf/B0hNB+c3Dc9U4aCVelslYAxtUSH/qYdsT82Lnbute+HD7ZQdAHlGK4JMx8H5oTkBnml8p4bJQt2QOTwR2QW7Znsh0fd5xiz5si3w0xyAmBWUgJO7OCggUsF5QRGuupTYroXl+wyQqfiRSrpwSCxA2V17/cqxHTi7+kE2/KMDN1M/n04zOdwifBNLiDv93vjy/A2PL6hOtPEfPxHeSnJLTHhMfJ9NgTeZftdgwVBv2jdNLDPVzzF5kIjyVjrDyxjDoBHVf5By39+cLofGVIJ8wuJSU/t8lPmk81kdEZOx7tgSYYbibeTRGVJ658qg0JbwP7g7wxHh0 X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB6446.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(39860400002)(396003)(136003)(346002)(376002)(366004)(478600001)(36756003)(4326008)(6486002)(8676002)(71200400001)(38070700005)(6506007)(38100700002)(53546011)(8936002)(54906003)(66946007)(6512007)(122000001)(186003)(66446008)(64756008)(66556008)(66476007)(6916009)(91956017)(76116006)(86362001)(2906002)(2616005)(316002)(26005)(83380400001)(33656002)(5660300002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?WkVpQ3p0dW9hTlBaUE5iaEVFQkd0bEpRdnh4VVNVN1R1RG54WUxrWldmMVhX?= =?utf-8?B?UW1oYjJBYy9OdXcwRjg1eGVkQ1RiNjRkcG1wbitIQjJOTkdOM1E5R2pyOXpQ?= =?utf-8?B?TU95ajRyY29CdVY2cVV6SC9lQTdheTdDa2VMQndXRjN5d0JoeWRnbG13TUlr?= =?utf-8?B?SktuK2pwck14UTFhZ01yeWJHcDZ5eWdXdHNWMHdWcC92TktzaTgyOU1TdlVr?= =?utf-8?B?UngwWDJsN1YrQlVLc1RYdWVKQlNscGQyem9OOWxDWTRyZFg5Rk5BWjVBQXBh?= =?utf-8?B?Y2lFT2xaQTFHR1ppOC9KSWlaY2ZzMXVuSWZ5U0g2dW9heFN5ekRaWkx5b29p?= =?utf-8?B?c01YRGliWkdsWEFSUHhTakdDZEVVVExraW9jbkZKeGxsOVZjdjQ1Tk9Rb3oy?= =?utf-8?B?UzlOVGduY1ZhVWFVVVZtdExZYWRrQzdWSktFUHo5S3pzenQ2czN1bnFCdk4w?= =?utf-8?B?Q3YxWFYvcDBLSmRWZGpKTlJ4UHpJT2R3eVg5WTRhK25odUVUcFo2eUNBQTZQ?= =?utf-8?B?WDNlZllhcjNOZG0xL0NSM04xd3RXbGFwWGdJYnZITisza3Y5VWVBaU5CVTUr?= =?utf-8?B?Rjk4ZkhhQjArZTF2dDRGNldOS0pzNUs0S3djU1A0b0cxZm1ZQnBUM0J0U0Zn?= =?utf-8?B?WG0wMUkvdFNON1JXQTA5b1ltMjRWaFZiNitTUVFLSXhWcDNoT1BJZTl4dWp4?= =?utf-8?B?Qm5lZ3VnVjh2SVlQZnVBOHJZZzhnMEQzVExzS1RkNHdlSUhRY1VKMFhBV2VJ?= =?utf-8?B?by8rd3UxLzRLblVVTm9mbms2WkZRSW1kQ1FQWGdxZUxQdVVybkpCVGh3M2VU?= =?utf-8?B?OWk1c0RuTnBlMWFDL1drOEx6d2IybklpT3QyWngzT09DYWEvaEFyR2lQNm9q?= =?utf-8?B?aDN3ZnYvSzBtaDdiOVdZaU1zb3lQbXJZc094anVFVW4rTmVNVnpuU25ZRUQx?= =?utf-8?B?RkRPNjlGNlp0eDVTdVhROXV4ZzU5ZVRYL3VpZ09KUmpjcnRGZ2hLTWRIOXIw?= =?utf-8?B?V3NESkwrWXhPakc0TnZHbkJFOFI2eXlaMUgyc3hkVHYrUjNFa3A3VXAzUEk3?= =?utf-8?B?TGNmZGg0RFBMMURHdERGaVZaL24wZm5zWHozQll3WU8vOFl2b1UzYzVqYkVx?= =?utf-8?B?VGpPWlZnbUF5TVJFR2R3azl2SkFJd2dzdFE3SXJLUnNxRlFKckhHLzFKSlVQ?= =?utf-8?B?ZFBTditPMSs5QmdmaUtHc1hLMzQ5WEdXbU85aU9hMkhFRWh6S0FZTHhnOVpS?= =?utf-8?B?QWhWdWtsMWVrVmVsc0phd1UxTjhIc1JtY3l2R1NHNXVQOXhCeDRpbm9aY3J1?= =?utf-8?B?TFFZUU02dkdlY3F5WitJWWVGb1NGelFMZEF4b0w3NWp3NlJwcDExQXQrV0Ji?= =?utf-8?B?aDByVWlKL24rYWpvWTBwQUFnNFNTbklsbHFzdHZtTGRNd01xVzZnRi9lK2dK?= =?utf-8?B?dHZRaVI4K1dSWEhjdXozNzBLRnFaTWVheHdLZk12b05XUllTazR5b3ZlcGNX?= =?utf-8?B?a1doWFpWbitWVXRhWjFsQVN1Y011OU04Sm1FdVJrWVJObll4OGV4MDhnMVpP?= =?utf-8?B?MGs1WFN0b3lwNFZwd20wRFVJdnM5R2tsOENyOEtmZFplci91RU1BTGNDYXBD?= =?utf-8?B?NnZaTzYwandzYXN1ekVnSis5d3lBLzB1Vmkyd3Q2ZjZJL29QU2c1TDBvaHJz?= =?utf-8?B?TWJkWmRFNDlIWEZvc1BiNmV1S2J4NUxuTU5yRlQ0eHBKL01YV0Q2TElaNlFM?= =?utf-8?Q?GsUvCscjYDEr+A1Qg6OhZyxxXXTYfCGSFrZCZpB?= Content-Type: text/plain; charset="utf-8" Content-ID: <2DB9E7BA48157D4A8E6F07C397D7B3B3@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB6080 Original-Authentication-Results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT062.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: a3a685c1-8879-4f51-b411-08d96d49e1f8 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: PhFURO3WDi0vQjxjCtBiNW/wvfU5f8JUBDOTlkwzEvr8ZyoQXDjtJ0OD7mLVsLMt/MQ/nUzw+UpohGvEkujjgRfeCNxampQauPYB7uohqa6dWlJD1sRs+qn6s0PAbCKtC3fSTislQCSd3MatDSEH3uYKdRY5aqCHx3UO1hQsvbH6mF/I6NiohU8Mz8b6nUPda7qk1y6uSqlZloQacpVl+mplu2jQd/z6GakMQNzqurEFeqXR2q0POe+Qpev3Wv/T3CnrUBP2Ti2x7+9LQDSZ2SnjBzNRC6gBwt6lU4+2ct0zcSsE3WLP1cWQhyVA59AbnCLWKaFupsLToCB8yHXXMH1S884vgaphm+yJEom2e+/lExWeH8sAjwIXWrXTxHhsOzqVVxfnr9M13iUAgmuylz7T1JIO71Iunc68UdqAIpRnRkmtJwcZuWRhsH3K5aRjP7c4R6+HKv1v7EIMeYAjFfo8INfHSFbyMKP0mRAlUpC1elcx+cIA3XqCDydhbi5NeCcRvXY3iibVZevCR4X041rq3i3HV1B4ecT8Kx1zu6voq8eWkhgT7d5wJYz6XY36P96z88vjMKeCOQZkivY4+qK0jFocvXJ+oL315ivFoe04ft0QUMa3m2nYeMPYJo8OgUXoJC/PIfJwA/bZIQ+kflAgBUURRBWRs50mlMUxnEvVyjsDc6au5lE6sIrc6klaMiP0m58xWWYcSYuq1M0PcA== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(136003)(376002)(346002)(39860400002)(396003)(36840700001)(46966006)(6862004)(336012)(36860700001)(356005)(478600001)(6512007)(316002)(86362001)(8936002)(54906003)(4326008)(5660300002)(53546011)(36756003)(186003)(2616005)(8676002)(107886003)(70586007)(81166007)(26005)(70206006)(82310400003)(47076005)(82740400003)(83380400001)(6486002)(2906002)(6506007)(33656002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Sep 2021 13:10:42.7962 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9672f376-092a-468a-7bb7-08d96d49e72b X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT062.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4262 SGkgSnVsaWVuLA0KDQo+IE9uIDEgU2VwIDIwMjEsIGF0IDEzOjU1LCBKdWxpZW4gR3JhbGwgPGp1 bGllbkB4ZW4ub3JnPiB3cm90ZToNCj4gDQo+IEhpLA0KPiANCj4gT24gMDEvMDkvMjAyMSAxMzo0 MywgTWljaGFsIE9yemVsIHdyb3RlOg0KPj4gSW50cm9kdWNlIG5ldyBYZW4gY29tbWFuZCBsaW5l IHBhcmFtZXRlciBjYWxsZWQgInBtdV9hY2Nlc3MiLg0KPj4gVGhlIGRlZmF1bHQgdmFsdWUgaXMg InRyYXAiOiBYZW4gdHJhcHMgUE1VIGFjY2Vzc2VzLg0KPj4gSW4gY2FzZSBvZiBzZXR0aW5nIHBt dV9hY2Nlc3MgdG8gIm5hdGl2ZSIsIFhlbiBkb2VzIG5vdCB0cmFwDQo+PiBQTVUgYWNjZXNzZXMg YWxsb3dpbmcgYWxsIHRoZSBndWVzdHMgdG8gYWNjZXNzIFBNVSByZWdpc3RlcnMuDQo+PiBIb3dl dmVyLCBndWVzdHMgY2Fubm90IG1ha2UgdXNlIG9mIFBNVSBvdmVyZmxvdyBpbnRlcnJ1cHRzIGFz DQo+PiBQTVUgdXNlcyBQUEkgd2hpY2ggWGVuIGNhbm5vdCByb3V0ZSB0byBndWVzdHMuDQo+PiBU aGlzIG9wdGlvbiBpcyBvbmx5IGludGVuZGVkIGZvciBkZXZlbG9wbWVudCBhbmQgdGVzdGluZyBw dXJwb3Nlcy4NCj4+IERvIG5vdCB1c2UgdGhpcyBpbiBwcm9kdWN0aW9uIHN5c3RlbS4NCj4gSSBh bSBhZnJhaWQgeW91ciBvcHRpb24gaXMgbm90IHNhZmUgZXZlbiBpbiBkZXZlbG9wbWVudCBzeXN0 ZW0gYXMgYSB2Q1BVIG1heSBtb3ZlIGJldHdlZW4gcENQVXMuDQo+IA0KPiBIb3dldmVyLCBldmVu IGlmIHdlIHJlc3RyaWN0ZWQgdGhlIHVzZSB0byBwaW5uZWQgdkNQVSAqYW5kKiBkZWRpY2F0ZWQg cENQVSwgSSBhbSBub3QgY29udmluY2VkIHRoYXQgZXhwb3NpbmcgYW4gaGFsZiBiYWNrZWQgUE1V ICh0aGUgb3ZlcmZsb3cgaW50ZXJydXB0IHdvdWxkIG5vdCB3b3JrKSB0byB0aGUgZ3Vlc3QgaXMg dGhlIHJpZ2h0IHNvbHV0aW9uLiBUaGlzIGxpa2VseSBtZWFucyB0aGUgZ3Vlc3QgT1Mgd291bGQg bmVlZCB0byBiZSBtb2RpZmllZCBhbmQgdGhlcmVmb3JlIHRoZSB1c2FnZSBvZiB0aGlzIG9wdGlv biBpcyBmYWlybHkgbGltaXRlZC4NCj4gDQo+IFNvIEkgdGhpbmsgdGhlIGZpcnN0IHN0ZXBzIGFy ZToNCj4gIDEpIE1ha2UgdGhlIFBQSSB3b3JrLiBUaGVyZSB3YXMgc29tZSBhdHRlbXB0IGluIHRo ZSBwYXN0IGZvciBpdCBvbiB4ZW4tZGV2ZWwuIFlvdSBjb3VsZCBoYXZlIGEgbG9vay4NCj4gIDIp IFByb3ZpZGUgUE1VIGJpbmRpbmdzDQo+IA0KPiBXaXRoIHRoYXQgaW4gcGxhY2UsIHdlIGNhbiBk aXNjdXNzIGhvdyB0byBleHBvc2UgdGhlIFBNVSBldmVuIGlmIGl0IGlzIHVuc2FmZSBpbiBzb21l IGNvbmRpdGlvbnMuDQoNCldpdGggdGhvc2UgbGltaXRhdGlvbnMsIHVzaW5nIHRoZSBQTVUgdG8g bW9uaXRvciB0aGUgc3lzdGVtIHBlcmZvcm1hbmNlcyBvciBvbiBzb21lIHNwZWNpZmljIHVzZSBj YXNlcyBpcyBzdGlsbCByZWFsbHkgdXNlZnVsLg0KV2UgYXJlIHVzaW5nIHRoYXQgdG8gZG8gc29t ZSBiZW5jaG1hcmtzIG9mIFhlbiBvciBvZiBzb21lIGFwcGxpY2F0aW9ucyB0byBjb21wYXJlIHRo ZSBiZWhhdmlvdXIgdG8gYSBuYXRpdmUgc3lzdGVtIG9yDQphbmFseXNlIHRoZSBwZXJmb3JtYW5j ZXMgb2YgWGVuIGl0c2VsZiAoaHlwZXJjYWxscyxjb250ZXh0IHN3aXRjaCDigKZldGMpDQoNClRo ZSBzdGVwcyB5b3UgYXJlIG1lbnRpb25pbmcgZG8gbWFrZSBzZW5zZSBidXQgdXNpbmcgdGhlIFBN VSB3aXRob3V0IHRob3NlIGtub3dpbmcgdGhlIGxpbWl0YXRpb25zIGlzIGFsc28gdmVyeSB1c2Vm dWwuDQoNCkNoZWVycw0KQmVydHJhbmQNCg0KDQo+IA0KPj4gU2lnbmVkLW9mZi1ieTogTWljaGFs IE9yemVsIDxtaWNoYWwub3J6ZWxAYXJtLmNvbT4gPiAtLS0NCj4+ICBkb2NzL21pc2MveGVuLWNv bW1hbmQtbGluZS5wYW5kb2MgfCAxOCArKysrKysrKysrKysrKysrKw0KPj4gIHhlbi9hcmNoL2Fy bS90cmFwcy5jICAgICAgICAgICAgICB8IDMzICsrKysrKysrKysrKysrKysrKysrKysrKysrKysr Ky0NCj4+ICAyIGZpbGVzIGNoYW5nZWQsIDUwIGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkN Cj4+IGRpZmYgLS1naXQgYS9kb2NzL21pc2MveGVuLWNvbW1hbmQtbGluZS5wYW5kb2MgYi9kb2Nz L21pc2MveGVuLWNvbW1hbmQtbGluZS5wYW5kb2MNCj4+IGluZGV4IGIxNzU2NDVmZGUuLjAzNjM3 YTlmNmQgMTAwNjQ0DQo+PiAtLS0gYS9kb2NzL21pc2MveGVuLWNvbW1hbmQtbGluZS5wYW5kb2MN Cj4+ICsrKyBiL2RvY3MvbWlzYy94ZW4tY29tbWFuZC1saW5lLnBhbmRvYw0KPj4gQEAgLTE4MTMs NiArMTgxMywyNCBAQCBwYWdpbmcgY29udHJvbHMgYWNjZXNzIHRvIHVzZXJtb2RlIGFkZHJlc3Nl cy4NCj4+ICAjIyMgcGxlX3dpbmRvdyAoSW50ZWwpDQo+PiAgPiBgPSA8aW50ZWdlcj5gDQo+PiAg KyMjIyBwbXVfYWNjZXNzIChhcm0pDQo+PiArPiBgPSB0cmFwIHwgbmF0aXZlYA0KPj4gKw0KPj4g Kz4gRGVmYXVsdDogYHRyYXBgDQo+PiArDQo+PiArQ29udHJvbHMgZm9yIGFjY2Vzc2luZyBQZXJm b3JtYW5jZSBNb25pdG9yIFVuaXQgKFBNVSkuDQo+PiArDQo+PiArQnkgZGVmYXVsdCBYZW4gdHJh cHMgUGVyZm9ybWFuY2UgTW9uaXRvciBhY2Nlc3Nlcy4NCj4+ICtXaGVuIHNldHRpbmcgcG11X2Fj Y2VzcyB0byBgbmF0aXZlYCwgWGVuIGRvZXMgbm90IHRyYXAgUE1VIGFjY2Vzc2VzIGFsbG93aW5n DQo+PiArdGhlIGd1ZXN0cyB0byBhY2Nlc3MgUE1VIHJlZ2lzdGVycy4gVGhpcyBvcHRpb24gaXMg aW50ZW5kZWQgdG8gYWlkIG1vbml0b3JpbmcNCj4+ICthbmQgbWVhc3VyaW5nIHRoZSBwZXJmb3Jt YW5jZS4gU2V0dGluZyBwbXVfYWNjZXNzIHRvIGBuYXRpdmVgIGFsbG93cw0KPj4gK2FsbCB0aGUg Z3Vlc3RzIHRvIGFjY2VzcyBQTVUsIGhvd2V2ZXIsIHRoZXJlIGlzIG5vIG1lY2hhbmlzbSBmb3Ig Zm9yd2FyZGluZw0KPj4gK1BNVSBvdmVyZmxvdyBpbnRlcnJ1cHQgcmVxdWVzdHMuDQo+PiArDQo+ PiArKldhcm5pbmcqDQo+PiArVGhpcyBvcHRpb24gaXMgb25seSBpbnRlbmRlZCBmb3IgZGV2ZWxv cG1lbnQgYW5kIHRlc3RpbmcgcHVycG9zZXMuDQo+PiArRG8gbm90IHVzZSB0aGlzIGluIHByb2R1 Y3Rpb24gc3lzdGVtLg0KPj4gKw0KPj4gICMjIyBwc3IgKEludGVsKQ0KPj4gID4gYD0gTGlzdCBv ZiAoIGNtdDo8Ym9vbGVhbj4gfCBybWlkX21heDo8aW50ZWdlcj4gfCBjYXQ6PGJvb2xlYW4+IHwg Y29zX21heDo8aW50ZWdlcj4gfCBjZHA6PGJvb2xlYW4+IClgDQo+PiAgZGlmZiAtLWdpdCBhL3hl bi9hcmNoL2FybS90cmFwcy5jIGIveGVuL2FyY2gvYXJtL3RyYXBzLmMNCj4+IGluZGV4IDIxOWFi M2MzZmIuLmQzMGU3OGI0ZDYgMTAwNjQ0DQo+PiAtLS0gYS94ZW4vYXJjaC9hcm0vdHJhcHMuYw0K Pj4gKysrIGIveGVuL2FyY2gvYXJtL3RyYXBzLmMNCj4+IEBAIC0zNCw2ICszNCw3IEBADQo+PiAg I2luY2x1ZGUgPHhlbi9zeW1ib2xzLmg+DQo+PiAgI2luY2x1ZGUgPHhlbi92ZXJzaW9uLmg+DQo+ PiAgI2luY2x1ZGUgPHhlbi92aXJ0dWFsX3JlZ2lvbi5oPg0KPj4gKyNpbmNsdWRlIDx4ZW4vd2Fy bmluZy5oPg0KPj4gICAgI2luY2x1ZGUgPHB1YmxpYy9zY2hlZC5oPg0KPj4gICNpbmNsdWRlIDxw dWJsaWMveGVuLmg+DQo+PiBAQCAtNzcsMTIgKzc4LDE5IEBAIHN0YXRpYyBpbnQgZGVidWdfc3Rh Y2tfbGluZXMgPSA0MDsNCj4+ICAjZGVmaW5lIHN0YWNrX3dvcmRzX3Blcl9saW5lIDQNCj4+ICAj ZW5kaWYNCj4+ICArc3RhdGljIGNvbnN0IGNoYXIgX19pbml0Y29uc3Qgd2FybmluZ19wbXVfYWNj ZXNzW10gPQ0KPj4gKyAgICAiV0FSTklORzogUE1VIEFDQ0VTU0VTIEFSRSBOT1cgRU5BQkxFRFxu Ig0KPj4gKyAgICAiVGhpcyBvcHRpb24gaXMgaW50ZW5kZWQgdG8gYWlkIG1vbml0b3JpbmcgYW5k IG1lYXN1cmluZ1xuIg0KPj4gKyAgICAidGhlIHBlcmZvcm1hbmNlIGJ5IGFsbG93aW5nIHRoZSBn dWVzdHMgdG8gYWNjZXNzIFBNVSByZWdpc3RlcnMuXG4iDQo+PiArICAgICJJdCBoYXMgaW1wbGlj YXRpb25zIG9uIHRoZSBzZWN1cml0eSBvZiB0aGUgc3lzdGVtLlxuIg0KPj4gKyAgICAiUGxlYXNl ICpETyBOT1QqIHVzZSB0aGlzIGluIHByb2R1Y3Rpb24uXG4iOw0KPj4gKw0KPj4gIGludGVnZXJf cGFyYW0oImRlYnVnX3N0YWNrX2xpbmVzIiwgZGVidWdfc3RhY2tfbGluZXMpOw0KPj4gICAgc3Rh dGljIGVudW0gew0KPj4gIAlUUkFQLA0KPj4gIAlOQVRJVkUsDQo+PiAtfSB2d2ZpOw0KPj4gK30g dndmaSwgcG11X2FjY2VzczsNCj4+ICAgIHN0YXRpYyBpbnQgX19pbml0IHBhcnNlX3Z3ZmkoY29u c3QgY2hhciAqcykNCj4+ICB7DQo+PiBAQCAtOTUsNiArMTAzLDI5IEBAIHN0YXRpYyBpbnQgX19p bml0IHBhcnNlX3Z3ZmkoY29uc3QgY2hhciAqcykNCj4+ICB9DQo+PiAgY3VzdG9tX3BhcmFtKCJ2 d2ZpIiwgcGFyc2VfdndmaSk7DQo+PiAgK3N0YXRpYyBpbnQgX19pbml0IHBhcnNlX3BtdV9hY2Nl c3MoY29uc3QgY2hhciAqcykNCj4+ICt7DQo+PiArICAgIGlmICggIXN0cmNtcChzLCAibmF0aXZl IikgKQ0KPj4gKyAgICAgICAgcG11X2FjY2VzcyA9IE5BVElWRTsNCj4+ICsgICAgZWxzZQ0KPj4g KyAgICAgICAgcG11X2FjY2VzcyA9IFRSQVA7DQo+PiArDQo+PiArICAgIHJldHVybiAwOw0KPj4g K30NCj4+ICtjdXN0b21fcGFyYW0oInBtdV9hY2Nlc3MiLCBwYXJzZV9wbXVfYWNjZXNzKTsNCj4+ ICsNCj4+ICtzdGF0aWMgaW50IF9faW5pdCB1cGRhdGVfcG11X2FjY2Vzcyh2b2lkKQ0KPj4gK3sN Cj4+ICsgICAgaWYgKCBwbXVfYWNjZXNzID09IE5BVElWRSApDQo+PiArICAgIHsNCj4+ICsgICAg ICAgIFdSSVRFX1NZU1JFRyhSRUFEX1NZU1JFRyhNRENSX0VMMikgJn4gKEhEQ1JfVFBNfEhEQ1Jf VFBNQ1IpLCBNRENSX0VMMik7DQo+PiArICAgICAgICB3YXJuaW5nX2FkZCh3YXJuaW5nX3BtdV9h Y2Nlc3MpOw0KPj4gKyAgICB9DQo+PiArDQo+PiArICAgIHJldHVybiAwOw0KPj4gK30NCj4+ICtf X2luaXRjYWxsKHVwZGF0ZV9wbXVfYWNjZXNzKTsNCj4+ICsNCj4+ICByZWdpc3Rlcl90IGdldF9k ZWZhdWx0X2hjcl9mbGFncyh2b2lkKQ0KPj4gIHsNCj4+ICAgICAgcmV0dXJuICAoSENSX1BUV3xI Q1JfQlNVX0lOTkVSfEhDUl9BTU98SENSX0lNT3xIQ1JfRk1PfEhDUl9WTXwNCj4gDQo+IENoZWVy cywNCj4gDQo+IC0tIA0KPiBKdWxpZW4gR3JhbGwNCg0K From xen-devel-bounces@lists.xenproject.org Wed Sep 01 13:18:32 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Sep 2021 13:18:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.176386.320971 (Exim 4.92) (envelope-from ) id 1mLQ89-0004F6-21; Wed, 01 Sep 2021 13:18:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 176386.320971; Wed, 01 Sep 2021 13:18:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLQ88-0004Ez-UN; Wed, 01 Sep 2021 13:18:16 +0000 Received: by outflank-mailman (input) for mailman id 176386; Wed, 01 Sep 2021 13:18:15 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLQ87-0004EZ-MM; Wed, 01 Sep 2021 13:18:15 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLQ87-0002d1-GT; Wed, 01 Sep 2021 13:18:15 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLQ87-0004zh-7I; Wed, 01 Sep 2021 13:18:15 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mLQ87-0004kd-6o; Wed, 01 Sep 2021 13:18:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=pO8xrE9MD3M/RlePB0hCndllLyMICn5OEKnGgj0YIoI=; b=ZEiJdBBsogdWFJed7sqYZCiCBU /PyHaEwuQvVmkeoca/I3bCEmC13rRInFzNygSz9fUmdjI4PEU1D8gwccXK/5QI20UFQNq04OkW6cB UtJmbEvb7zUgBQMXMj247We7IjCMcwYv2+zKqpyS0iSCKhGxXYv2SSKHiwy+48muUtmg=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-upstream-unstable test] 164679: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-upstream-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:guest-start/debianhvm.repeat:fail:heisenbug qemu-upstream-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-upstream-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-upstream-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-upstream-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-upstream-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-upstream-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-upstream-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-upstream-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-upstream-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-upstream-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-upstream-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-upstream-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-upstream-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-upstream-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-upstream-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-upstream-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-upstream-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-upstream-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-upstream-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-upstream-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-upstream-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-upstream-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-upstream-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-upstream-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-upstream-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-upstream-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-upstream-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-upstream-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-upstream-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-upstream-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-upstream-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-upstream-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-upstream-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-upstream-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-upstream-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-upstream-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-upstream-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-upstream-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-upstream-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-upstream-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-upstream-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-upstream-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-upstream-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-upstream-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-upstream-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-upstream-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-upstream-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=b6e539830bf45e2d7a6bd86ddfdf003088b173b0 X-Osstest-Versions-That: qemuu=136c34c9bc4179dc64b15b2bb5f0c54ca4ddf823 From: osstest service owner Date: Wed, 01 Sep 2021 13:18:15 +0000 flight 164679 qemu-upstream-unstable real [real] flight 164696 qemu-upstream-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/164679/ http://logs.test-lab.xenproject.org/osstest/logs/164696/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 18 guest-start/debianhvm.repeat fail pass in 164696-retest Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 163309 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 163309 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 163309 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 163309 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 163309 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 163309 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 163309 test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: qemuu b6e539830bf45e2d7a6bd86ddfdf003088b173b0 baseline version: qemuu 136c34c9bc4179dc64b15b2bb5f0c54ca4ddf823 Last test of basis 163309 2021-07-05 10:10:06 Z 58 days Testing same since 164679 2021-08-31 11:08:25 Z 1 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Aaron Lindsay Ahmed Abouzied Akihiko Odaki Alberto Garcia Aleksandar Rikalo Alessandro Di Federico Alex Bennée Alex Williamson Alexander Bulekov Alexander Graf Alexander Wagner Alexandre Iooss Alexey Kardashevskiy Alexey Neyman Ali Shirvani Alistair Francis Alyssa Ross Andreas Schwab Andrew Jones Andrew Melnychenko Anthony PERARD Ard Biesheuvel Arseny Krasnov Atish Patra Axel Heider BALATON Zoltan Basil Salman Basil Salman Basil Salman Basil Salman Bastian Koppelmann Benjamin Herrenschmidt Bharata B Rao Bibo Mao Bin Meng Bin Meng Brad Smith Brijesh Singh Bruno Larsen (billionai) Cai Huoqing Carlos Venegas Changbin Du Chenyi Qiang Chetan Pant Cho, Yu-Chen Christian Borntraeger Christian Schoenebeck Christina Wang Claudio Fontana Cleber Rosa Coiby Xu Cole Robinson Connor Kuehl Corey Minyard Cornelia Huck Cédric Le Goater Damien Goutte-Gattat Daniel Henrique Barboza Daniel P. Berrangé David Edmondson David Gibson David Hildenbrand David Michael Dennis Wölfing Dmitry Voronetskiy Dmitry Voronetskiy Dov Murik Dr. David Alan Gilbert Dylan Jhong Edgar E. Iglesias Eduardo Habkost Eduardo Habkost for memory backend and machine core Eduardo Otubo Emanuele Giuseppe Esposito Emmanuel Blot Eric Auger Eric Blake Eric Farman Fabian Ebner Fabiano Rosas Fabrice Fontaine Feng Lin Filip Vidojevic Finn Thain Frank Chang Frederic Konrad Frederic Konrad Gan Qixin Gerd Hoffmann Giuseppe Musacchio Gollu Appalanaidu Greg Kurz Guenter Roeck Han Han Hanna Reitz Heinrich Schuchardt hnick@vmware.com Hongzheng-Li Hou Weiying Hubert Jasudowicz Hyman Hyman Huang(黄勇) Ian Jackson Igor Druzhinin Igor Mammedov <imammedo@redhat.com>
Igor Mammedov Ilya Dryomov Ilya Leoshkevich Jade Fink Jagannathan Raman James Bottomley Jamie Iles Jason Andryuk Jason Thorpe Jason Wang Jean-Philippe Brucker Jinhua Cao Joe Komlodi Joel Stanley Joelle van Dyne John Arbuckle John Snow John Sucaet Jonathan Albrecht jonathan.albrecht Jose Martins Jose R. Ziviani Juergen Lock Julia Suvorova Kamil Rytarowski Katsuhiro Ueno Keith Busch Keqian Zhu Kevin Wolf Khem Raj Kirill Tkhai Kirti Wankhede Kit Westneat Kito Cheng Klaus Jensen KONRAD Frederic Konstantin Nazarov Kostiantyn Kostiuk Kunkun Jiang Lara Lazier Laszlo Ersek Laurent Vivier Laurent Vivier Lei Rao Leonardo Bras Li Qiang Li Qiang Li Zhijian Liren Wei LIU Zhiwei Lucas Mateus Castro (alqotel) Luis Fernando Fujita Pires Luis Pires Lukas Jünger Lukas Straub Maciej S. Szmigiero Mahesh Salgaonkar Mahmoud Mandour Mao Zhongyi maobibo Marc Hartmayer Marc-André Lureau Marcel Apfelbaum Marcel Apfelbaum Mark Cave-Ayland Mark Johnston Mark Nelson Markus Armbruster Matheus Ferst Mathieu Poirier Matthew Rosato Matus Kysel Mauro Matteo Cascella Max Filippov Max Reitz Maxim Levitsky Maxim Uvarov Michael Forney Michael Rolnik Michael Roth Michael S. Tsirkin Michael Tokarev Michael Walle Michal Privoznik Miroslav Rezanina Murilo Opsfelder Araujo Myriad-Dreamin Nicholas Piggin Nick Hudson Niklas Cassel Nolan Leake Olaf Hering Or Ozeri Owen Anderson Padmakar Kalghatgi Paolo Bonzini Paolo Montesel Patrick Venture Paul A. Clarke Paul Durrant Pavel Dovgalyuk Pavel Pisa Peng Liang Peter Collingbourne Peter Krempa Peter Lieven Peter Maydell Peter Xu Philippe Mathieu-Daudé Philippe Mathieu-Daudé Qiang Liu Ram Pai Rao, Lei Raphael Norwitz Ravi Bangoria Rebecca Cran Reinoud Zandijk Ricardo Koller Ricgard Henderson Richard Henderson Richard W.M. Jones Richard Zak Robert Hoo Roman Bolshakov Roman Kagan Roman Kapl Ruimei Yan Ruinland ChuanTzu Tsai Samuel Thibault Serge Guelton Sergio Lopez Shivaprasad G Bhat Silvano Cirujano Cuesta Stefan Berger Stefan Hajnoczi Stefan Reiter Stefan Weil Stefano Garzarella Stephen Long Tarun Gupta Taylor Simpson Thomas Huth Titus Rwantare Tom Lendacky Ulrich Weigand Vaibhav Jain VictorV (Kunlun Lab) Vijai Kumar K Viktor Ashirov Vincent Bernat Viresh Kumar Vitaly Kuznetsov Vivek Goyal Vivek Kasireddy Vladimir Sementsov-Ogievskiy Volker Rümelin Wainer dos Santos Moschetta Warner Losh Wei Liu Wei Wang Willian Rampazzo Xie Yongji Xingang Wang Xuzhou Cheng YAMAMOTO Takashi Yang Zhong Yasuo Kuwahara Yuri Benditovich Yuval Shaia Zenghui Yu Zhang Chen zhenwei pi Zhenzhong Duan Ziqiao Kong jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git 136c34c9bc..b6e539830b b6e539830bf45e2d7a6bd86ddfdf003088b173b0 -> master From xen-devel-bounces@lists.xenproject.org Wed Sep 01 13:20:48 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Sep 2021 13:20:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.176394.320985 (Exim 4.92) (envelope-from ) id 1mLQAZ-0005dc-JT; Wed, 01 Sep 2021 13:20:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 176394.320985; Wed, 01 Sep 2021 13:20:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLQAZ-0005dV-Ga; Wed, 01 Sep 2021 13:20:47 +0000 Received: by outflank-mailman (input) for mailman id 176394; Wed, 01 Sep 2021 13:20:45 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLQAX-0005dN-Rx for xen-devel@lists.xen.org; Wed, 01 Sep 2021 13:20:45 +0000 Received: from mail-wr1-x429.google.com (unknown [2a00:1450:4864:20::429]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id b5b09572-24bc-452d-87bf-2c25f69caa2f; Wed, 01 Sep 2021 13:20:44 +0000 (UTC) Received: by mail-wr1-x429.google.com with SMTP id u9so4458220wrg.8 for ; Wed, 01 Sep 2021 06:20:44 -0700 (PDT) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id h11sm25481339wrx.9.2021.09.01.06.20.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Sep 2021 06:20:43 -0700 (PDT) Received: from zen (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 6C4D31FF96; Wed, 1 Sep 2021 14:20:42 +0100 (BST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b5b09572-24bc-452d-87bf-2c25f69caa2f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=references:user-agent:from:to:cc:subject:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=y/0tGsa7zxs1Lge6n3O6ldiXuhSjzQntOAObjxG3wD8=; b=gAnfhwBM6t2sfmWr0LXDnlOXCmfqqkhQvg8PKhZg0mwsVmibDpiyA0ycZRCaPZM/o9 jWOSV+puCL7VGYR9cJuMUCQlMqfLPQlGiUk4SK9A0wFvpOSsKIHMhHZqu/KF8pArEMJ6 /K2zuth1vsa6Noddrq4zuOPYXKJkZ2Q9hgUfk2iqtVSf3BP0pVK0BmuZpJghk56qVwZA KVVzErNnIv1DqO8RRtIGGKsQZL1U0Fo/GZjHHXlX/1c8vF2xbQQ2E4gI1nVjtDGHg3K0 gW/ehRFVFcBd1onW2djYp7qR7jy11EXMYIKqt/C/T3/bAZglF4+LSDewaVtD3Rnk96w+ C7Jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject:date :in-reply-to:message-id:mime-version:content-transfer-encoding; bh=y/0tGsa7zxs1Lge6n3O6ldiXuhSjzQntOAObjxG3wD8=; b=Nb5mqR5TsAz+SC1PjkXWUrHYg7+RYIk2PofavxzZZ1W9z7k7DyBIdtI9aTlSci0TB7 w8t1qSFHcHfg0Wd9Tq2jcnOy2Xz7IfFH9r3JetnYwMqHRDb66kjuPrhcnXtx/UfZhD7h 8gAyvV9hCMoX2x67efoVVNilx6cTOonqBF1BdCC8cCRUhScHRYES2nZ9crHt9aSwxhFP 91HZB7plrUKY4oQH24/CRhOQ7Rl8aOF+DQGtd/kO+kup8bxHyUMNKwiCkjyu7+7ChprY QvlrizXqekLy6BCTjxcC8uGmcJoSt+1MftQlVXdLmf92RYVE+iN/U1OrrayTL7T0gh3c tMrA== X-Gm-Message-State: AOAM5316lkUVkwVO/rO9hvknS0Y5pkVZv6uNUiUh6Yw9tgWnf+gODKmJ pTvSvzZ9GexVS8CvljiORcLmVA== X-Google-Smtp-Source: ABdhPJxCevrGYCx7XFVJhI0D2nblAkpnQCi5PGoMrSDHbafJqS3oT1ctZ1duD7JVNhkkNRwTAvhNgg== X-Received: by 2002:adf:b7cd:: with SMTP id t13mr17597181wre.63.1630502444042; Wed, 01 Sep 2021 06:20:44 -0700 (PDT) References: <87v94ldrqq.fsf@linaro.org> User-agent: mu4e 1.7.0; emacs 28.0.50 From: Alex =?utf-8?Q?Benn=C3=A9e?= To: Stefan Hajnoczi Cc: Stefano Stabellini , Stratos Mailing List , virtio-dev@lists.oasis-open.org, Arnd Bergmann , Viresh Kumar , AKASHI Takahiro , Stefano Stabellini , Jan Kiszka , Carl van Schaik , pratikp@quicinc.com, Srivatsa Vaddagiri , Jean-Philippe Brucker , Mathieu Poirier , Wei.Chen@arm.com, olekstysh@gmail.com, Oleksandr_Tyshchenko@epam.com, Bertrand.Marquis@arm.com, Artem_Mygaiev@epam.com, julien@xen.org, jgross@suse.com, paul@xen.org, xen-devel@lists.xen.org, Elena Afanasova Subject: Re: Enabling hypervisor agnosticism for VirtIO backends Date: Wed, 01 Sep 2021 13:53:34 +0100 In-reply-to: Message-ID: <875yvkh1p1.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Stefan Hajnoczi writes: > [[PGP Signed Part:Undecided]] > On Wed, Aug 04, 2021 at 12:20:01PM -0700, Stefano Stabellini wrote: >> > Could we consider the kernel internally converting IOREQ messages from >> > the Xen hypervisor to eventfd events? Would this scale with other kern= el >> > hypercall interfaces? >> >=20 >> > So any thoughts on what directions are worth experimenting with? >>=20=20 >> One option we should consider is for each backend to connect to Xen via >> the IOREQ interface. We could generalize the IOREQ interface and make it >> hypervisor agnostic. The interface is really trivial and easy to add. >> The only Xen-specific part is the notification mechanism, which is an >> event channel. If we replaced the event channel with something else the >> interface would be generic. See: >> https://gitlab.com/xen-project/xen/-/blob/staging/xen/include/public/hvm= /ioreq.h#L52 > > There have been experiments with something kind of similar in KVM > recently (see struct ioregionfd_cmd): > https://lore.kernel.org/kvm/dad3d025bcf15ece11d9df0ff685e8ab0a4f2edd.1613= 828727.git.eafanasova@gmail.com/ Reading the cover letter was very useful in showing how this provides a separate channel for signalling IO events to userspace instead of using the normal type-2 vmexit type event. I wonder how deeply tied the userspace facing side of this is to KVM? Could it provide a common FD type interface to IOREQ? As I understand IOREQ this is currently a direct communication between userspace and the hypervisor using the existing Xen message bus. My worry would be that by adding knowledge of what the underlying hypervisor is we'd end up with excess complexity in the kernel. For one thing we certainly wouldn't want an API version dependency on the kernel to understand which version of the Xen hypervisor it was running on. >> There is also another problem. IOREQ is probably not be the only >> interface needed. Have a look at >> https://marc.info/?l=3Dxen-devel&m=3D162373754705233&w=3D2. Don't we als= o need >> an interface for the backend to inject interrupts into the frontend? And >> if the backend requires dynamic memory mappings of frontend pages, then >> we would also need an interface to map/unmap domU pages. >>=20 >> These interfaces are a lot more problematic than IOREQ: IOREQ is tiny >> and self-contained. It is easy to add anywhere. A new interface to >> inject interrupts or map pages is more difficult to manage because it >> would require changes scattered across the various emulators. > > Something like ioreq is indeed necessary to implement arbitrary devices, > but if you are willing to restrict yourself to VIRTIO then other > interfaces are possible too because the VIRTIO device model is different > from the general purpose x86 PIO/MMIO that Xen's ioreq seems to > support. It's true our focus is just VirtIO which does support alternative transport options however most implementations seem to be targeting virtio-mmio for it's relative simplicity and understood semantics (modulo a desire for MSI to reduce round trip latency handling signalling). > > Stefan > > [[End of PGP Signed Part]] --=20 Alex Benn=C3=A9e From xen-devel-bounces@lists.xenproject.org Wed Sep 01 13:22:31 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Sep 2021 13:22:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.176400.320995 (Exim 4.92) (envelope-from ) id 1mLQCE-0006Tl-VB; Wed, 01 Sep 2021 13:22:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 176400.320995; Wed, 01 Sep 2021 13:22:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLQCE-0006Te-SE; Wed, 01 Sep 2021 13:22:30 +0000 Received: by outflank-mailman (input) for mailman id 176400; Wed, 01 Sep 2021 13:22:29 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLQCD-0006TY-LR for xen-devel@lists.xen.org; Wed, 01 Sep 2021 13:22:29 +0000 Received: from mail-lf1-x12d.google.com (unknown [2a00:1450:4864:20::12d]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id cf2850d5-6dd5-40f8-bffe-1da694fcf464; Wed, 01 Sep 2021 13:22:28 +0000 (UTC) Received: by mail-lf1-x12d.google.com with SMTP id t19so4487310lfe.13; Wed, 01 Sep 2021 06:22:28 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cf2850d5-6dd5-40f8-bffe-1da694fcf464 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=jaFQ1dJz/0jVDnUJDux1CudavpmIQDH+qRgNmOHy2kw=; b=V08N3wY0tEFQVk3cnI/b65MC6y/NleF6UKnkKSF4FljmBjrUCVrMazguZLA7LdjAmT +ukjleA/aXsaghg8GdsMYuAgm5c+MPEAreIaSQmdzDGpoYxtukbwGOq6AUzSQwEpTY7+ AeRpjO4diPCC57slSCKz6Up8XUfN5G55R75Z0ghi/XJHYQzGmDGp0k5rosewss7I0J/f I3lzZ16I+iwkRH8e8zHzRSxcJ5rmOUhqIQSEZfM6y6/Rh5VlbXhlnuTgeV0C1Ud4mU1N SF3wfplIkh8EJ7NydDk2HhzRMfGvJ4zuckdXpFbwpiK3mBrr//Kfse12BEWAhzVvi6fQ 5kXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jaFQ1dJz/0jVDnUJDux1CudavpmIQDH+qRgNmOHy2kw=; b=JrpFxVaBMe8DrcL/LAJ8shCaXJ4Ue23W3hoyGVRIfapRy/ZvbNVLLlSjeZSgktxEDL Vh2Sp7eI/S1m6J+aOzTPhK/OjKSQv0DUsS8VLE/ER2OXJb5e7DrDEUAfcWFKgCUWBIJ9 s/Kla6Em+S3TDU16XXV5I2ZSffiv70n7ZR6GPpIqH7YWe4QeKI1cBHkGYPUgPG9WhT98 qUpcueZVT0jFl0KmEqCN6AjuV272lFqDw+t4pBkERk2Z1dpyDJJF6Upf9ouXhwuLQxhT NxWj42tEw9w3UQ1iaCguh0upNstAu2iIOjf088UvzbfhRVoDPW5yNR+VLsjcSeD6swWs 81Xg== X-Gm-Message-State: AOAM531FlJMmjORy+uaUxkviFED/ekdPu42SfqE9CgrRoMpouTj6ERDZ +BbtjZgMJBUCUdkKkArhpvZNhTj6cG5Ld3/jo3Y= X-Google-Smtp-Source: ABdhPJzjhjRenLVlNS1HJ0Z1WF422vUK6cSHDYkcons243OdgRRX3wOE4F63Tq0W2CKrBteyFQ6T9OAR2SBTJbX1W8Y= X-Received: by 2002:ac2:5d4a:: with SMTP id w10mr26376733lfd.529.1630502546778; Wed, 01 Sep 2021 06:22:26 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Jason Andryuk Date: Wed, 1 Sep 2021 09:22:14 -0400 Message-ID: Subject: Re: Xen Security Advisory 378 v3 (CVE-2021-28694,CVE-2021-28695,CVE-2021-28696) - IOMMU page mapping issues on x86 To: "Xen.org security team" Cc: xen-announce@lists.xen.org, xen-devel@lists.xen.org, xen-users@lists.xen.org, oss-security@lists.openwall.com, "Xen.org security team" Content-Type: text/plain; charset="UTF-8" On Wed, Sep 1, 2021 at 5:34 AM Xen.org security team wrote: > > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA256 > > Xen Security Advisory CVE-2021-28694,CVE-2021-28695,CVE-2021-28696 / XSA-378 > version 3 > > IOMMU page mapping issues on x86 > > UPDATES IN VERSION 3 > ==================== > > Warn about dom0=pvh breakage in Resolution section. > > ISSUE DESCRIPTION > ================= > > Both AMD and Intel allow ACPI tables to specify regions of memory > which should be left untranslated, which typically means these > addresses should pass the translation phase unaltered. While these > are typically device specific ACPI properties, they can also be > specified to apply to a range of devices, or even all devices. > > On all systems with such regions Xen failed to prevent guests from > undoing/replacing such mappings (CVE-2021-28694). Hi, Is there a way to identify if a system's ACPI tables have untranslated regions? Does it show up in xen or linux dmesg or can it be identified in sysfs? Thanks, Jason From xen-devel-bounces@lists.xenproject.org Wed Sep 01 13:39:58 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Sep 2021 13:39:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.176414.321021 (Exim 4.92) (envelope-from ) id 1mLQSo-0008Kt-Ph; Wed, 01 Sep 2021 13:39:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 176414.321021; Wed, 01 Sep 2021 13:39:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLQSo-0008Km-MA; Wed, 01 Sep 2021 13:39:38 +0000 Received: by outflank-mailman (input) for mailman id 176414; Wed, 01 Sep 2021 13:39:38 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLQSo-0008Kg-1K for xen-devel@lists.xenproject.org; Wed, 01 Sep 2021 13:39:38 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 0c2ac658-0b2a-11ec-ade2-12813bfff9fa; Wed, 01 Sep 2021 13:39:37 +0000 (UTC) Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-am5eur02lp2056.outbound.protection.outlook.com [104.47.4.56]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-11-fbMU7R2YNQioOZLaDSkUtQ-1; Wed, 01 Sep 2021 15:39:35 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR0401MB2335.eurprd04.prod.outlook.com (2603:10a6:800:2e::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19; Wed, 1 Sep 2021 13:39:33 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4478.019; Wed, 1 Sep 2021 13:39:33 +0000 Received: from [10.156.60.236] (37.24.206.209) by PR0P264CA0279.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:1::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Wed, 1 Sep 2021 13:39:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0c2ac658-0b2a-11ec-ade2-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1630503576; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=6gOIlwfeDw151rTxi3HU+tBg3DOPTUR73ZuMPiIZHoc=; b=Z482f9E7EEmo6MVfw58J/4W1+m1CYfp6Nqr/DXVVLrcKisF7NavRafDuwn9T+trw6AOtvd L6XSiLCr85ZBNOfiYGxCyUgB5thTvk0wPluICpB5SemewSXsl8qyPOq4HluupM+5GJStkO JZ+N+TCmE/U5XgaD1fl9hGnw/9VDY6U= X-MC-Unique: fbMU7R2YNQioOZLaDSkUtQ-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JBhcJGpW5huymKKurh1Y480OXWQYKrpZ0ZPCfYX/2LQcj/OTZxGIWy0BhYkNF26PqQQxLraxurcPWSFrsyE3MOHV/x4Hrbd7K5L1qa7Bl7Xf1b/I7F8+aUuxoe9FmvNly07BKavMIdm9QzuLzcu8WY4ly+KLzvI5NawY4lBjdP2htQC8XCd9fA+bOMbu9yRUbvSYziTHM8zQxQsP0dn42k0PBsgGzjUieeSdvNWaWV1U7iWfCyhIF/iVau1EgDwKL2oG23hcmfRCXaJ47TSfhhhs91QL7srqbRPrfvPre/q5uTU65SPLl1feU9tN/+uxXvwKolew9rgfkaV8gq61RA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=6gOIlwfeDw151rTxi3HU+tBg3DOPTUR73ZuMPiIZHoc=; b=CRp3Ye82S0aOXdlC4tp4jCzjyS9ZmS92mF73ZVYdbNG6BqTgbMRzU2ylYQFyCcflU1qpQTUky9sQNpJBdzjesEtAjWjOQTIIxVqUKKEv2rd/8EOgm/9C2uKF7USILMQN69fso0fz7qKWyVtbP4DytqfdEkWV03gKBgtafki0piCDK7KyS8bDlpW3D7QVnYBAM5Mj/K7KfCmdOVtnaZnAmt16D8wdQtCcFdh0R3bii38FmlImXRzUDsT6UDO249NL+8uoVjZ3kh/5kBOZdWDJT3ONSJ9Ehfke8o57BHUuFwcQe1dRAg/1KdpS/aD8kQDHnT0DxlTMTK4bz4Gd9L5E0g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com; To: Julien Grall , Stefano Stabellini , Andrew Cooper From: Jan Beulich Subject: vcpu_show_execution_state() difference between Arm and x86 Cc: "xen-devel@lists.xenproject.org" Message-ID: <85dc06ff-04df-2148-81c5-26bd25d1142f@suse.com> Date: Wed, 1 Sep 2021 15:39:31 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PR0P264CA0279.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:1::27) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e96cb151-17a3-4cd7-69e4-08d96d4dee7f X-MS-TrafficTypeDiagnostic: VI1PR0401MB2335: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +++OrTw4EWygWwWI14Rtt7qgQeSSx4f6jECIqLjA/sGU65yRp+VV+o/k8wy66ExXG1SHJKDy5O30ULidjBv0cdgGQlcHUCi90mC2HsQELaD3uEaVB2zNI4zqzK3twtfWKMk6zroiSqwMeOYtqkTzpvemuksW1/VKAVUP6VuiBksUv2WL0DgNus+1nenMx/nsvS3FCNssgSZX9I2TlDr0bF3YJehyRukPUFhyR9oSq5+S6tqq4yOKeZ7RTrcXpWBuWFXgAXTaTLt5sZXZ04bvZ+8diHxSUhSVZUlUDZqK4BBLsdt1eI6b5ogiGKUdW9292vcQjczdcoLXHQihowKdCWEmZR8ocRI1CWX4BLEfO17e0lfULpmhBmQn/Q3v/GsXcd6jsjlHiVOfdrTVNjYkDU+kFwkkzC7fe1MAGARRcmObUFwQQEzOnNiE2XxhvYj94GmP98qpcbgAFgvWpYwDoe2mJcUoS2Ft2+NyOKAg4DLlacmYrKabLhYBB3D2q6d9qXxZT+6ITMQ3Y/wUeFFeTwdN0MUNov3BbmaA07kFjpp4eEonE6gzz8603d/l/N/PuQ4pH6+A4Y70pKwZIZog7TUTLHWRrnLboQr2cOfUqRCyzLrxIQc6i4Q1TnSVvY/gE3nAVy2cXC+ROEYnzy+jki4Pue4r3TxXE4n+SwW2FMLh22t/jp3aFiqpYr4LF3o3n/tGBGf0F7YvtU4nPb5oPTX219IJrNoPANekTfyjqTM= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(136003)(376002)(396003)(366004)(346002)(39860400002)(4326008)(36756003)(5660300002)(478600001)(2906002)(31696002)(31686004)(8676002)(38100700002)(956004)(86362001)(2616005)(4744005)(6486002)(66946007)(83380400001)(66556008)(66476007)(8936002)(316002)(16576012)(110136005)(26005)(186003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cVhjT20wOWl0bEFvSHl1eFNXYUk0L3MzWVlNODJ5VTRNbUNTcGJ0QzB6bjZE?= =?utf-8?B?SFpUL0JTOU1WYUNzN1NUS05jUE1UNXpLUmE0UFRhRVJtOEpUVXM1TXUyVUV4?= =?utf-8?B?NTFVSDNkc1hyTVVWNjlqeDZBRmNaZnhvaC95cVdJcklzRTZKdkJnQXg3akNn?= =?utf-8?B?ZjVwNkt6MCtWRnQ4NUNlUFRCVk1yV3J2b2VDeHBxcVBzQjdiQ2V0SGhRaFVS?= =?utf-8?B?T2M4azlMOUlQVmFLbkV1Q3ZGcXcxeFVHN21OalVhSUZ4UCsza0w2WndqL2JW?= =?utf-8?B?NDAxNlhpRU5XYy8vcWN2RnhEeFR0Z3NXYlhHeHJuV2hNaXZVcUY0N0tSa2dU?= =?utf-8?B?WmRQRjZ0WkJYMitlOVdDZnUxaEdITjQ1YjkyOGZ5ZGFSUUcycy9qUkFQQkQ0?= =?utf-8?B?ZEtGYkhtRWZZbDlVNkZzMHRxVEZZM1BETWpIK25Od21JazdwY2ZGMVBKMU9J?= =?utf-8?B?cWl2a2F1REZFazV3VzQ0OVBIR0JWODFjNHIwYngxTk00Z2VZdU1jSmk2eHpj?= =?utf-8?B?eEZTLy90dkNyQ0FUU0xuYktscCtIazkxZ3YzcnczN2w3cmVSZmpEdzVWSGRN?= =?utf-8?B?V3NsSmk2ZmJ4TDlRU0F5YXd0UThRYW0xb2xJdU00aGRSaG5Nd3FJeTRoV2lj?= =?utf-8?B?VmFxT1c3QkZqRTYxeHRkekFSeis0LzUxQVpmL3FYZHlVSmE5SnYxMFBxdEhK?= =?utf-8?B?VXVNMDZnWGxEVjhhSGdITnhCWlZmdDdtTEEzYUV2ZkZ2ZmhRZEh4QXZZMEF5?= =?utf-8?B?eUsyeTl0bWtFck1MMzJSY2R1UXlaOEZ0Q1RGQTBmenhDdGFMblRGbHBvV25z?= =?utf-8?B?Q25hR3lyQjZTOHF6R2xjVFdzZzBWYkE3QjRVZU1rb25lMStyMjNHdFFYK3FX?= =?utf-8?B?anBZbzliRms5ZTJub3ZlaTQ4a2FJYytSQThiamdnUllicjZNMmsyR2hYb01y?= =?utf-8?B?Nk5BMXRiTUFLbEt3blk3eUsvWkpzK2xlbXhvMlhQcDdVaEw4TGxmWVUyUnRp?= =?utf-8?B?STlJSkpGVWpLTDNXVjFtOE10dkRVRUhDbTVwSGp6Q1hPamdCaXZhZHkzMmdZ?= =?utf-8?B?SWFwSXhVTjI0Z0x1STNMNUUxZlpWaXJIZmZkcFUyQTBySDRvTFNaVnd1NUFR?= =?utf-8?B?VFBrSDRXaFpzZWZHalA2ZGtBQjZRVFNMc1FyWmxtcURWbk9nT1UrcWNxY2dN?= =?utf-8?B?RTdsK1R1UlNQa0svbnBZUlhZNGE3dENDblkrT0E3NU5uWFUrV0RxcEVJN0pw?= =?utf-8?B?VXdlMzM5ZzRFZDA3VGtTWkZIa1VlSkk3VnNmRXJ0VWY0c3N6L3pySEtKbVBi?= =?utf-8?B?WHBZNzJZRGx6ZjhpR2ZPVVN1UWlsZGk4dzNZazdmSmJ4YUYwMkl5SzdoVjFs?= =?utf-8?B?RXhsSVhibTN0UzRVV2tuOXMvTVlldG5ReWdNSnBTYXJ5ZTlQRW5kKzRWZDkv?= =?utf-8?B?RXMweVRrcnZ1MnREdnNZcUVyRGZYRHlYalQ3T1M4OWg2OUQ4VUNOcjE4RFRI?= =?utf-8?B?a0w0Rm94TW5EelhVWWhyUGRTWnpCbXNiV3d0d0RJYW1SSnNrMG90MG5CenBz?= =?utf-8?B?UFhwNmhwa0hjOGRZZjZkVEdBd2VpSG5ENnBMRThUalIyaGNIMU5xNkxWazhv?= =?utf-8?B?bnN4Zm9JSEJvdGxmb3B5UmlvOHJSVXhmOVQwaGZpSlpSVGpUZEthaWdYdDNi?= =?utf-8?B?Z2tKenczRk5qVGtoRlFsQkdOdCtLY1VtVFI3KzVTMkxxdlU2VHo0VW1LbEpB?= =?utf-8?Q?bu68Kq05zmHGd2uBKDkowWwCgQqlLLKIizgLpu7?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: e96cb151-17a3-4cd7-69e4-08d96d4dee7f X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Sep 2021 13:39:33.1932 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: M+DLaaVeiAmqLYWFog5pgxerKDbudS7thTvwuaPC+/CYtxuuwAQwhF2M4MZUlein1YesZpdQtJltB6ESARnjyw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2335 All, back in 2016 Andrew added code to x86'es variant to avoid interleaving of output. The same issue ought to exist on Arm. The lock acquired, or more importantly the turning off of IRQs while doing so, is now getting in the way of having PVH Dom0's state dumped the 2nd time. For register state I did find a sufficiently simple (yet not pretty) workaround. For the stack, where I can't reasonably avoid using p2m functions, this is going to be more difficult. Since I expect Arm to want to also have interleave protection at some point, and since Arm also acquires the p2m lock while accessing Dom0's stacks, I wonder whether anyone has any clever idea on how to avoid the (valid) triggering of check_lock()'s assertion without intrusive changes. (As to intrusive changes - acquiring the p2m lock up front in recursive mode, plus silencing check_lock() for nested acquires of a lock that's already being held by a CPU was my initial idea.) Thanks, Jan From xen-devel-bounces@lists.xenproject.org Wed Sep 01 13:45:57 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Sep 2021 13:45:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.176422.321038 (Exim 4.92) (envelope-from ) id 1mLQYg-0001W3-Iu; Wed, 01 Sep 2021 13:45:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 176422.321038; Wed, 01 Sep 2021 13:45:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLQYg-0001Vw-DT; Wed, 01 Sep 2021 13:45:42 +0000 Received: by outflank-mailman (input) for mailman id 176422; Wed, 01 Sep 2021 13:45:41 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLQYf-0001Vq-B5 for xen-devel@lists.xen.org; Wed, 01 Sep 2021 13:45:41 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id e4bd0fda-0b2a-11ec-ade8-12813bfff9fa; Wed, 01 Sep 2021 13:45:40 +0000 (UTC) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04lp2055.outbound.protection.outlook.com [104.47.12.55]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-27-7b8lZMMcPm6vtlABb0kWiw-1; Wed, 01 Sep 2021 15:45:38 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR0401MB2334.eurprd04.prod.outlook.com (2603:10a6:800:29::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.23; Wed, 1 Sep 2021 13:45:36 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4478.019; Wed, 1 Sep 2021 13:45:36 +0000 Received: from [10.156.60.236] (37.24.206.209) by AM3PR05CA0124.eurprd05.prod.outlook.com (2603:10a6:207:2::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Wed, 1 Sep 2021 13:45:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e4bd0fda-0b2a-11ec-ade8-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1630503939; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=h++qf6KL033IrhpD4G9A6T6GzqjOOh03iX8crHOUczI=; b=gkCU88ShhK9ERjWmul6HOvfOC+Gqj0MyoxfQqpDYrS13bi1SzLhEXzMv9oRTXMWP85qhuA Qlf9GEgda3jyo+kU5fCnH9jH/tE271AB4yyK07+p4TTpVMH+trKSlQBJ16lh0dKD0oOMe8 C72qUL1TzjLQez44b8Qld6r4Un4MO9w= X-MC-Unique: 7b8lZMMcPm6vtlABb0kWiw-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GuXJfWY0amJ91RgzcHI470nvMF64yGQ3cnRte9BYhY/5ix/pOgT3/l0WrDbceGnUmo91wGrHuAz2ESz8JkC1Sh8jrSRmqDh4KYDpZ1eIRMfLWOOf99ySvgQw1dYfvX0gF8qmJNs6Z/0Uj0tuoymOjQA8K4uGWbRY1riL+t0/mz7SppE4JRxe4DlaYP84TdcFq5VYXG2jZKPfAmLS+8S6i8mcfKyU9/7bOwNidn702QFEghLyJ7FJ5vA0FCh7wpiO7PRwEuYnAuXVUVnWU2xpHs+x4YAEs0yicOzxhiWXy/0pTtJockM7kiwuBITPfn5DDIDHOg7WgfY9PwSi+2DQbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=h++qf6KL033IrhpD4G9A6T6GzqjOOh03iX8crHOUczI=; b=Yg5C7l/JK4Ol2KDRKt/3rW7rwD0yAREQK9pb7+YNteb49CiX3W7dgtCkSoZXxPXl/CG43pmRZa2bDhM/9rtG2H5NZLNWCCe7bzauDkavAf/I7jlu0fM8RvwNJjntpjwiUq6I18jryTq3tR8UYPtqlGv6YhyyK1w6OWqHb2NhGd76NxxcnmCdn6MuWZdB3Ja+1PXVkyqMUSKPZH44rD/6yRYJ99P3UyB6HcNO7c8irErHf/ZFNCpIKToebI6L/MQfAsGQ2tU+3d/lFqF8XD1ymo5vwwqgHpxImgo/vg5+8WFdDDjTE5Xh5j4JlJTbkViITH3Usmu60yc6X93gCsD8rQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: lists.xen.org; dkim=none (message not signed) header.d=none;lists.xen.org; dmarc=none action=none header.from=suse.com; Subject: Re: Xen Security Advisory 378 v3 (CVE-2021-28694,CVE-2021-28695,CVE-2021-28696) - IOMMU page mapping issues on x86 To: Jason Andryuk Cc: xen-devel@lists.xen.org References: From: Jan Beulich Message-ID: <367a756d-9a14-6970-3820-d863a998583e@suse.com> Date: Wed, 1 Sep 2021 15:45:34 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM3PR05CA0124.eurprd05.prod.outlook.com (2603:10a6:207:2::26) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 60b81f1d-a3fd-4b7d-ba5c-08d96d4ec6d7 X-MS-TrafficTypeDiagnostic: VI1PR0401MB2334: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6430; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Lm9E47T5e3pNBd3xexBskqnLAhkNqfNUfcAVkxdv1rgj+8PIvqVOEWIPYuU7Fl+b9/k99CnB5SbWShUlH8THGGhJG76BHpPuSrk9qP4EwlQ2R9zUVDP8W0gA6g6S/jis+ex+HrTqmQNvY4b3U2KPrET/jKVXRk8TYJal/SiVoAkWBv+x/PHgNvcYU23rrUZlczfcFhwN1suGbAYsFBxbHi9L601qgx2irA7qTN2RMvfCupv0SKyko8bxMRq3eM7+GIxGqnWNHtxjG9bEEGYLkMyhMT0tOlu51cFh5XJLg170o0zhcGormi/tSFCPhe1lNS8AT0x3BY+LK/Uovi9a78O1lf5kq2gthBCWHw5chw0gXvyNjN5e2oAwKQWcQF3iC1ERfcbuQttqnuSThAVO1OG/vzL2gBeTNhiMvseOCVJEai0cz8OwvTlDk+50lg9OeyfLsJTobZ0YKiFdRjiwzXX6H8F0UM6pryJmQgsPPM61Ak2s+4Aj4xKaNmTRmHdBxp/FLb/31Ws3LPDLvkvB3DbTnopy9KqMh2eBIBcOzrekaKz+54i6aDudZvWQdcmm7mjrZmzYnSl7sJofZ+u3ZT2w0d4w881QIPzCPfQrWQzA3kVYBZObwdXe57aR/H6bl7QEmwmIVxjAohBODGndHfu2tcaMdgMlC6R3dEC7mpYVDvrGYfYTtkfPG4XpaqJIx/wed2riSh2tadnjTaBxVDWo5EHVQrUHX66VKdnz+QJ9B2T01ssQNq/j2j7uJfWJ X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(396003)(366004)(136003)(376002)(346002)(39860400002)(66946007)(15650500001)(36756003)(83380400001)(2616005)(956004)(6916009)(4326008)(16576012)(316002)(2906002)(31686004)(66556008)(66476007)(86362001)(31696002)(53546011)(5660300002)(8936002)(26005)(6486002)(478600001)(8676002)(38100700002)(186003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RHg1Q3BVeTJ2VTlaa3lING9DSW5oblhnaXh4QTVQbHAxVlpPWDhuRWNWbVc5?= =?utf-8?B?aU12SGZ4bzdpQ2dXM3JRYnhSNW95am1aVjlzWjRCNmduaUJ4eUR6MzVNb3Bu?= =?utf-8?B?QkZrY1BkTkxmVS82aHd0cERyMlJrSEcrMlhiYTBVamZHUXZzalJramhFVHdP?= =?utf-8?B?WTJCZFZoOFZncCtCWkFUL3FuNXgwWFR5bGNVUVgrS3ZvL2RSSHRMYVVyVE1o?= =?utf-8?B?cW5SWEE1VjdiOTNWYU95cWxndDRnVTI3OG5aYldsbzBLb3dNN2xBSWxRc3Zo?= =?utf-8?B?YnJVbGpJWDJUaS9sVENyL1IzaEpxK011SmVNQThnZGNEWU0xalhiUEplcFBO?= =?utf-8?B?QlYxTXk4c0dMdWJhZTZJYVVrODNvbUpvcGUrR29nWWhYZVU1WEhrUU85Sk9I?= =?utf-8?B?emVwbCtrWFJleUFuVVgrUCt2eVZGYmk4QWQxTmk1aXFtTElpTG5YUm44R29a?= =?utf-8?B?UWdrRFdLL2JnRUw5SmhBdzhKR2szY3FsMlQ0b2wvcHdzalNHR1N1Njdad0x1?= =?utf-8?B?UVZiYjBueHZTRmEyektWK0FhUXpYL3RIV09ldGdzRzY1cEN2eTVVVEgzREVQ?= =?utf-8?B?aHdnZ3IxbUZDb2RrS051ZDdTRTY0RmR1cFZIemMrNXZneFQ2aWRyaGVOL0dp?= =?utf-8?B?cHd5NFo4M09OdVlCWjBKOG54MVgzOXdMcU5RWVR3TnF4RTF4K2p0Wmsvb2Jx?= =?utf-8?B?dE8xbEpXRmgrbUljc2Q2SlNRVW5LSkFiZHNyRkpwQXV0ZTd5cm9QT2hKelIr?= =?utf-8?B?SUVVY3c4cXFqUE5QclA0YTluVnNtUVozT25sVXQ4bzZzcGVXdFNNQ1pGcjBR?= =?utf-8?B?RksrQTBiN0x0ME14Z3N5dTRlTXIyOCtYSzdLUWNuQ1B0M1FhUzBXQ2c1Qm8y?= =?utf-8?B?dlNUa2ttMGxMVHR5bWVjZkU1V2NHU1puYVFpaStQUVBFQ0huZ24wWVpmVUNk?= =?utf-8?B?a1kwaVltaVUxU1crV1ZrUkxNN2t6SWFTUTcvKzhxcXRCRm1COUNiY2pyRVNj?= =?utf-8?B?RW04ZGZyQnFvU2lXdGMyV3lJZFRCUUZyQ2xvMysxVXVIdDNYTlhCRGY4S1Jm?= =?utf-8?B?SFpNR0IvMHV0Uzl3WnVkWnRWWVFKSE5ZOXdvY2dOL2NyZFhZUzZQd1p6SWQv?= =?utf-8?B?THJERDRpUEl0N3VZWUJJVmdFVFlJVnhSMkVCc0FuczJHUDMyT2oyeW10bnp1?= =?utf-8?B?US82N0U4Mkx5UjkrbVlGemY1WnNEajl1OFdSbi9kdU1CdnZDOVU3MzBCSEFF?= =?utf-8?B?KzBrQXJNWFRHa2c1L1FKSU5YY1lqVzVETksvTlVtcE9pditHNGl4bEdKTzdH?= =?utf-8?B?cGRnT3JRUjVRTXR1b2F3SFhqcis5WHZubGlxdWZSSnRKMldCRnFGaXZhZnBO?= =?utf-8?B?K3dwR2J6UWJuWmU1SU5YTk95dkU3SmVQMGxRRkR2N3FwdDI3ZFlFcGdMa2oz?= =?utf-8?B?QlhnV3BmSGlOWHRXUzVPSGVBYlRFNjQyT01iYkNDRnU4OUc2UUxocm95NnlF?= =?utf-8?B?TkU5WFJMWlRlTW94cVR6enFPVjhyeUQxYXV4S3U5S1FZKzI4QXYvWENSSjhj?= =?utf-8?B?YUx5TGVDdWtQUjVGNlpPZzlRUElidmVNK1M1Njd5cytnOUNrQjRabVFJMTZW?= =?utf-8?B?NHdUVUMyeUZOSkYxSXltU0RsanJsZWNCbGtIazdZeVI0UEJGcHFSckVueU1p?= =?utf-8?B?TDJzUU9GdmlVT08rVmJqWitaSVhUblo4VEcvVjdDT1N5MGhkdjZIS0ppTERL?= =?utf-8?Q?aMJeP/a0hD4XvkiwIDftT0bIdPnpli1Mv+p09Xl?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 60b81f1d-a3fd-4b7d-ba5c-08d96d4ec6d7 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Sep 2021 13:45:36.1518 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: E3V2wUtrqZrPA87VtkBWBub158OXgC4bKAn+P+aDMPOpp6VtRv+bnWOiX3Tnyrc6nnwRR3n2F84jUmTssJ+mAQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2334 (removing all lists inappropriate for a question like this one) On 01.09.2021 15:22, Jason Andryuk wrote: > On Wed, Sep 1, 2021 at 5:34 AM Xen.org security team wrote: >> >> -----BEGIN PGP SIGNED MESSAGE----- >> Hash: SHA256 >> >> Xen Security Advisory CVE-2021-28694,CVE-2021-28695,CVE-2021-28696 / XSA-378 >> version 3 >> >> IOMMU page mapping issues on x86 >> >> UPDATES IN VERSION 3 >> ==================== >> >> Warn about dom0=pvh breakage in Resolution section. >> >> ISSUE DESCRIPTION >> ================= >> >> Both AMD and Intel allow ACPI tables to specify regions of memory >> which should be left untranslated, which typically means these >> addresses should pass the translation phase unaltered. While these >> are typically device specific ACPI properties, they can also be >> specified to apply to a range of devices, or even all devices. >> >> On all systems with such regions Xen failed to prevent guests from >> undoing/replacing such mappings (CVE-2021-28694). > > Is there a way to identify if a system's ACPI tables have untranslated > regions? Does it show up in xen or linux dmesg or can it be > identified in sysfs? For VT-d, "iommu=verbose" will cause ACPI table contents to get logged. For AMD you need to go one step further and set "iommu=debug". Obviously you'll want to be careful with enabling anything like this on production systems. Jan From xen-devel-bounces@lists.xenproject.org Wed Sep 01 13:48:57 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Sep 2021 13:48:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.176429.321049 (Exim 4.92) (envelope-from ) id 1mLQbo-0002E3-35; Wed, 01 Sep 2021 13:48:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 176429.321049; Wed, 01 Sep 2021 13:48:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLQbn-0002Dw-Vw; Wed, 01 Sep 2021 13:48:55 +0000 Received: by outflank-mailman (input) for mailman id 176429; Wed, 01 Sep 2021 13:48:54 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLQbm-0002Dq-Kg for xen-devel@lists.xenproject.org; Wed, 01 Sep 2021 13:48:54 +0000 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 580d6a66-0b2b-11ec-ade8-12813bfff9fa; Wed, 01 Sep 2021 13:48:53 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 580d6a66-0b2b-11ec-ade8-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1630504133; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=Qh3XfuC09YdLPSqmBa5G4bMkC4fwUMe2iEY/h46nkQ8=; b=CW6sGQCzJwCCS7ZbuDN4Oq+OHUTRId554N65EV7BwcoG1hQ1tgvDywrP +sLwsQj9/dOpZh8mlR2xT1Yuw525jRW/3mvrtG0sVDdXK78WxsDvR9sJ/ 9Yy1yiqv8PvKJzn9dm2cwNvYdshgt/OK9TM4df6updgEbupt6pRLIsTUZ o=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: jPi5RsrDq8vGxVA0R5jGxt5cenwvNBfmBZGDQMKiE1AFYKURsTUmSTbwQra4o5dyL59hBeY8ZK 4idzOWHFaBF7g8iREyL1Yjhi9Pq/4Et2hc3Ae04KWUWZc+jd14hUvsxjO1y9Ai0mtOvwf7MtyG +d/olGD96J2WM3+a3UCASXQz4xcTZ6Wb9XCs5f2emQn5Vozut7L8Cu1k643/A8easgzRZnWRNb ElncjzE7/9IpFudkEtNW9GkpgvOffpKe6SHHq+gtpTOkQPmiLt7tJUwmRnK6XSyJ+ht6Q3pJB0 mMQOBniVUtDseSIDuJ68S+49 X-SBRS: 5.1 X-MesageID: 51396146 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:+WB0G6P5PJ+DH8BcT1L155DYdb4zR+YMi2TDiHoedfUFSKOlfp 6V8MjztSWVtN4QMEtQ/+xoHJPwPE80kqQFnbX5XI3SJjUO3VHIEGgM1/qG/9SNIVybygcZ79 YeT0EcMqyBMbEZt7eD3ODQKb9Jq7PrgcPY55as854ud3AQV0gJ1XYJNu/xKDwOeOApP+tfKH LKjfA32QZINE5nIviTNz0gZazuttfLnJXpbVovAAMm0hCHiXeN5KThGxaV8x8CW3cXqI1Sv1 Ttokjc3OGOovu7whjT2yv66IlXosLozp9mCNaXgsYYBz3wgkKDZZhnWZeFoDcpydvfp2oCoZ 3pmVMNLs5z43TeciWcpgbs4RDp1HIU53rr2Taj8DDeiP28YAh/J9tKhIpffBecwVEnpstA3K VC2H/cn4ZLDDvb9R6NpOTgZlVPrA6ZsHAimekcgzh0So0FcoJcqoQZ4Qd8DIoAJiTn84oqed MeTP003MwmNG9yUkqp+lWGmLeXLzMO91a9Mwk/U/WuonprdCsT9Tpf+CQd9k1wvK7VBaM0vt gtn8xT5cZzp/QtHNdA7dE6MIKK41z2MGDx2V2pUCDa/YE8SjjwQs3MkfgIDN/DQu1/8HJ1ou WYbG9l X-IronPort-AV: E=Sophos;i="5.84,369,1620705600"; d="scan'208";a="51396146" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Hni2p7i6o8Fc8nMMgBLTmo2PuGG3ZzI2f1YKH8ioqFl5Y0hawo8p/+r3zXsx25d7brFFws0ha+mm6IjE7Z3vaADbFh2tg+sl6ZEIb4Z5ggWsJSvdUZjj6tYR/FCczpC233kYkuXL8coYz3rKgqc+fuZPu4VYF8ycxodSUaDeaZRo3P0oRZmx/jgWilBJssKI4uwmKVWzpmDtbUdK79ra1BJIdzi6mtr34rlQNGUG+CmlDyUCmELKndXSFxqQdmw26aofilFlHCweTiHaB+wQZNBgc9Aa6u1e1JXtfpB9ljK5s8w1wS4FtWwAdeNA5j9VFhAZffFrjCaYi9/3Iw6R7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0uko84/08g7wVwgcKSsgJA9ORW/fkmuAIxaRx9UBpIw=; b=Uj8PqFGqRk7J8OifrZ9KfBd0j+3oqnQS7sgKSgUA4CMt3t2NQrlaQm5Eybjnl/ht1J42QWZkvMrOGlYLX7cH9F7Y61gwl4jVdSlUNHalGrZZXJ2yrPWul5Yt9RxVz+tZtoQKNIWo7lzroLgKU1iIU43mUdRcfGdpneF7CLVCnhHLULDzRgWWjxdjyBuJJeivpKxagzI7sxXMTEtdK4WayYg+grgbTgl+pOofu4mKHkvrMrnUpYtYPctpv+E8rRWk0t4GASMQ0NubXf8SskkNy8swP0VHbg7YZn9VSbfnBU895VUBlwKpUNF6WQ2vxiK+WwJe8llMNyTgXSwMzb69yw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0uko84/08g7wVwgcKSsgJA9ORW/fkmuAIxaRx9UBpIw=; b=e6xzsuQNFBn1dawlLa4DZOmsiO70TtY6lujay/4cOzQoR+dffOafwYTNYRnD7oHK3T6suTR/WeSj3lWYkY0VDvj+nauJROAKUATldr9aKdxiFcViJYKGJh4U7GRYUzEKHJRr6uHYP74Sr1jOIWiRIj+NW2TsWnONJb6NR7CQAzU= Date: Wed, 1 Sep 2021 15:48:24 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich CC: Andrew Cooper , Wei Liu , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH 2/4] x86/P2M: relax guarding of MMIO entries Message-ID: References: <93ecc397-1293-69b1-e70d-3c5f9317229a@suse.com> <7f56c625-eee6-31c4-2d6f-bd7334867d83@citrix.com> <5d69d4c0-7a04-c3da-f971-616363c6d63d@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: PR1PR01CA0035.eurprd01.prod.exchangelabs.com (2603:10a6:102::48) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: bc2a53e1-0d91-4a32-74f5-08d96d4f2e4d X-MS-TrafficTypeDiagnostic: DM6PR03MB4763: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: n+IbpYeOeTMzhjFzLAJz9/6ouWC2LTS4xhC/baz3NqHVWeIvvcX2Q9rnSZE5J5h6+GKUzSC5c2mWz2LMewH+2kAXB+g1Wm6W08An21ZdTCGMFgf2cdhFmj6+Dv0b3M4hZVFdWpjFrWr2Vp5CqXUbigpXVrbNoEj1SxQJDFD/SBnqQmkIy+xNmWCX2uJEpf4sKR6gQqTsHpibXAgxpdrQCY+/KjCd68XHlkU9GZC82sFkdhh/Xogu6xyNVhRaAitsyrdobEDmTLkM5Pwf4Il9Qsbyb+JN14aPg8Xo9qRsP9+mhUsmSrUMVE2y2RoXrWN8HbOYK4n8ogpfcLaJoWTA2czG8nKMCk7PvbFCOKOO0C1bAMciy+uORDYDh+7r8pe8gjvFcPi1sYObgZ0AzZ9pZ8aLSa/0hYioK98undPO0MeW9BWIm/1tSy+y7oUB09RNW3b4OgLyBVzCM0OeIzfAz4PnBoiq38RcDN2hA54p1Pp9vU4Eb520yRQyOD6zH+59k89ubMF96TdZG7yACLwPJrWjOHzsvza1qsE2RyIhmiAdDhuA3EWrnAyhGJxo1pI5M+ydq3EHGN9dMYk3oJUagfe9KqvX5Lh6WLd1zFtNSdTxlyGIW3biuLkaAwWqMheBA9y1OTYqfTwJk6vIPzDkaQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(7916004)(4636009)(396003)(136003)(366004)(346002)(376002)(39860400002)(38100700002)(86362001)(4326008)(53546011)(9686003)(66556008)(33716001)(956004)(5660300002)(66946007)(83380400001)(6496006)(6666004)(66476007)(8676002)(6486002)(26005)(186003)(2906002)(478600001)(316002)(8936002)(54906003)(85182001)(6916009);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Mi83anFXVytGeXNndU5RSFFzRXpSa3FGMDJxL0ZiQWUvQThQekhacW4yV21W?= =?utf-8?B?d2dtVzlkTmtlNmVQVEptZzVtNjZ2bTJzNHU5TVkrSE1BTEJ5cXRkOGZxTnpa?= =?utf-8?B?bU1tOXRNb25wMHNrbTB3Z1VWMUc5aVUydXhoNGNoTnYrRXA4SmpjWkUwVFpE?= =?utf-8?B?Y1BEWTNSY0JrdDhxelRRQUMvRnRsVnNvSkV3T01zMjFYMnV1WkQ0c2k5aHRR?= =?utf-8?B?ZDJSVkRnTlZLejhSdlA3NDBkRlUzTzMweG1KcEVXL1RoeFNmdkR4emdTUVZx?= =?utf-8?B?dE5WVG4yMFZsNllZTHA5SGZHcm9CK0RTL3lvVkl0cHNkNXFyK1ZpeXdneHAz?= =?utf-8?B?b2FCOGhBQ0VTL1BscG9xdk5kdklrUjdmaEpyZ3A1b05LUWF3bUZxUG9zRFNn?= =?utf-8?B?cXIyUmc4RWtRckVYRys0MlhBeTdjVzhuV1FmYUNMa0hHSVVPU0d6Wm5XbEpF?= =?utf-8?B?SHdJanBrSFFBbFN5UFNYd2FBQ2FGWXV3amNlVVhma1ovcWdReHZ3WmoxTTBK?= =?utf-8?B?UWJsc21UTk5RaUhFa3R5SGdTMXA5RmpPcjBwVmJEQ2F4M1czaVV3MGR2RlBn?= =?utf-8?B?QmYvYWJ3UHQ1Yk5Gd2IvUi9EVitWUlhTalBhdjZ5clFoWGlKQmMwUlpCU3dI?= =?utf-8?B?Z3hYYnR5TVMzZmVHQUNEMXYvTjhVdGVoWE9NNVhwUlRoRUROTWNZRzNkcU5C?= =?utf-8?B?TG5Kc0g1OXkvOXRNay95UittclN0TUIrZTY0a2grelRwMVdrSExjQjdncnBH?= =?utf-8?B?SEhoZzdjbWwzTHhjSkYzcVU2bFh6WnJ5ZU1WQ2c4Y212L3d1Q25NVXE1RmpD?= =?utf-8?B?dlBudUVsRHpzMUZVWGVuTUVOREJzZWlBeURteDluMmJsSDl2WHBFaVJMcmVT?= =?utf-8?B?R2RneHlyNW5hdHpWMmREZlBSRDB2dEJTa2JwZk1JeUZBZ3cvVHFxdEZ1ZC9Q?= =?utf-8?B?b01uZDI2UzZWcmRkYytvSDNwLzhBd2o0S21xL2FBZExjNHlqWTRzV1YzTHhV?= =?utf-8?B?c3IwS2VvSnpTNjJXY2o1RUxpdTViM1l3R0ZBdGFTdmx3dlJGcWVVNlpDWFo5?= =?utf-8?B?aFlSeWFkT1Q2VTdldW55MUdhYUVPUjFmRVBxZE5sMXpNcWI3YWJBOU5lZkFP?= =?utf-8?B?T20wcjd5WWVEc1hIV01FRjN3bUJTeXF1NVdKc1FsL0dOQ05YejBNZWVBZWQv?= =?utf-8?B?eVE0ZG5jWnZKTjA3VTUyQlhIeEFnbGlWUlZ6c09PK0w3c0xDVTlsTnhlTVZh?= =?utf-8?B?dUlSeU4weXZmQ0dCOWRCQ1NrY2xQUzc3OWZXUWM2TUsvOVZUQ3ZubDNGUWNy?= =?utf-8?B?ckowU216YWc5N01vOGN6Lzh0ZkpyUzczMWpWQTNSUVFyNzQwMS8zaDhNNnBU?= =?utf-8?B?b2RKWHVyS1Q5dFRpd2hHdTQrL2h1dUUvNHZEYVBsT0N5c1Q5bzdWZ0N4Titw?= =?utf-8?B?WDVreGE2TjBRU201OWlHMUlpRjkxN3hhY2ljdE9BSFZoOXBlMjdWenpSSHFa?= =?utf-8?B?UGorK1VCeEFxYjZNUzB1QXo2VGhlci9qRjh4WjYwakxhY3lZQTg1c1RQYVF1?= =?utf-8?B?elZ5TExHVnh1SHV2bG15VG1sMWVzNFhMZ25uOENaU1EzZHpGamxIbFVIWGJz?= =?utf-8?B?YjNrYkpHc216b1Z4dUZlSG9ERnl6QmRwVlpWTlR5cTZ6T3NpWjN6NHNOTTFh?= =?utf-8?B?elN1d3BKTm1JSVpzYk9aZGNsbmlGdWorcFc4WDJHbm1VU1o2emV6MlBRM3hq?= =?utf-8?Q?CUtUxC3BQK2i+ycnuqxYZl9ibNylvKXqZ1ZmuUA?= X-MS-Exchange-CrossTenant-Network-Message-Id: bc2a53e1-0d91-4a32-74f5-08d96d4f2e4d X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Sep 2021 13:48:29.7442 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Tb2SOovK+89YBZvcjbFbxzluKwpHXZ/FYuQG6mY86cqbfyk5J3cwO+xYib4uw1KPjSwiGTg9BlrIY+jdob5K6w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4763 X-OriginatorOrg: citrix.com On Wed, Sep 01, 2021 at 11:53:03AM +0200, Jan Beulich wrote: > On 01.09.2021 10:50, Roger Pau Monné wrote: > > On Tue, Aug 31, 2021 at 05:38:49PM +0200, Jan Beulich wrote: > >> On 31.08.2021 17:25, Andrew Cooper wrote: > >>> On 31/08/2021 14:26, Jan Beulich wrote: > >>>> On 31.08.2021 15:16, Andrew Cooper wrote: > >>>>> On 30/08/2021 14:02, Jan Beulich wrote: > >>>>>> Further permit "access" to differ in the "executable" attribute. While > >>>>>> ideally only ROM regions would get mapped with X set, getting there is > >>>>>> quite a bit of work. Therefore, as a temporary measure, permit X to > >>>>>> vary. For Dom0 the more permissive of the types will be used, while for > >>>>>> DomU it'll be the more restrictive one. > >>>>> Split behaviour between dom0 and domU based on types alone cannot > >>>>> possibly be correct. > >>>> True, but what do you do. > >>>> > >>>>> DomU's need to execute ROMs too, and this looks like will malfunction if > >>>>> a ROM ends up in the region that HVMLoader relocated RAM from. > >>>>> > >>>>> As this is a temporary bodge emergency bugfix, don't try to be clever - > >>>>> just take the latest access. > >>>> And how do we know that that's what is going to work? > >>> > >>> Because it's the pre-existing behaviour. > >> > >> Valid point. But for the DomU case there simply has not been any > >> pre-existing behavior. Hence my desire to be restrictive initially > >> there. > >> > >>>> We should > >>>> strictly accumulate for Dom0. And what we do for DomU is moot for > >>>> the moment, until PCI passthrough becomes a thing for PVH. Hence > >>>> I've opted to be restrictive there - I'd rather see things break > >>>> (and getting adjusted) when this future work actually gets carried > >>>> out, than leave things permissive for no-one to notice that it's > >>>> too permissive, leading to an XSA. > >>> > >>> Restricting execute permissions is something unique to virt.  It doesn't > >>> exist in a non-virtualised system, as I and D side reads are > >>> indistinguishable outside of the core. > >>> > >>> Furthermore, it is inexpressible on some systems/configurations. > >>> > >>> Introspection is the only technology which should be restricting execute > >>> permissions in the p2m, and only when it takes responsibility for > >>> dealing with the fallout. > >> > >> IOW are you saying that the calls to set_identity_p2m_entry() > >> (pre-dating XSA-378) were wrong to use p2m_access_rw? Because that's > >> what's getting the way here. > > > > I did wonder this before, because I saw some messages on a couple of > > systems about mappings override, and I'm not sure why we need to use > > p2m_access_rw. My first thought was to suggest to switch to use the > > default access type for the domain, like set_mmio_p2m_entry does. > > > > I have to admit I'm not sure I see the point of preventing execution, > > but it's possible I'm missing something. > > Well, what good can come from allowing execution from, say, the > IO-APIC or LAPIC pages? Or other MMIO-mapped register space? map_mmio_regions does already map BARs with execute permissions, so it's just some MMIO regions that get mapped without execution permissions, which makes all this confusing. > Insn > fetches might even trip bad hardware behavior in such a case by > being the wrong granularity. Normal reads could also trigger such bad hardware behavior, so I'm not sure preventing execution provides Xen any more safety. > It's imo really only ROM space which > ought to have execution permitted. > > The issue isn't just with execution, though, and as a result I may > need to change the logic here to also include at least W. As of > one of the XSA-378 changes we may now pass just p2m_access_r to > iommu_identity_mapping(), if the ACPI tables on an AMD system were > saying so. (We may also pass p2m_access_w, but I sincerely hope no > firmware would specify write but no read access.) > > Similarly in "IOMMU/x86: restrict IO-APIC mappings for PV Dom0" I > now pass p2m_access_r to set_identity_p2m_entry(). Not really I think, as PVH dom0 is the only user of the set_identity_p2m_entry call in arch_iommu_hwdom_init, and we should never identity map the IO-APIC range in that case because a set of emulated IO-APIC replacements are provided and those require ranges to be unmapped so that accesses can be trapped. > > I suppose an underlying issue is the mixed purpose of using > p2m_access_*, which possibly has been against the intentions in the > first place. We cannot, for example, express r/o access to an MMIO > page without using p2m_access_r (or p2m_access_rx), as there's no > suitable p2m type to express this via type alone. We may need to > split p2m_mmio_direct into multiple types (up to 7), I guess, if > we wanted to remove this (ab)use of p2m_access_*. My main complaint is mostly with the fact that some MMIO ranges are mapped without execute permissions when mapped by set_identity_p2m_entry vs map_mmio_regions that will map them with the default permissions and that has execution set. If the mappings from arch_iommu_hwdom_init for example would use the default permissions that could solve quite a lot of the issues there AFAIC. Roger. From xen-devel-bounces@lists.xenproject.org Wed Sep 01 13:52:02 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Sep 2021 13:52:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.176436.321060 (Exim 4.92) (envelope-from ) id 1mLQei-0003my-HF; Wed, 01 Sep 2021 13:51:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 176436.321060; Wed, 01 Sep 2021 13:51:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLQei-0003mr-E8; Wed, 01 Sep 2021 13:51:56 +0000 Received: by outflank-mailman (input) for mailman id 176436; Wed, 01 Sep 2021 13:51:55 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLQeh-0003mh-Al; Wed, 01 Sep 2021 13:51:55 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLQeh-0003DP-4O; Wed, 01 Sep 2021 13:51:55 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLQeg-0006LF-Rl; Wed, 01 Sep 2021 13:51:54 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mLQeg-0000xx-R5; Wed, 01 Sep 2021 13:51:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=zxDmiBiuazEHqG8wBcaJfsNq8jtHVu9JVDVRK4LgWnY=; b=6/TIkGyJ2cBv4a8H1b+aBKR7Ai YX/kivcLlQZ9kScwBIz6KNd8df8XIn9YA2nwVlpMFCnJX2wUlGxeSLtJfXbTnEr8l2H2cIBDUKCyI fVkvjm5G+g11E2QLObRBI7MgCbFQGlFGhm9c47ekxjZfOYDeCIT9y+cM/HrwzYahqu4E=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 164689: regressions - FAIL X-Osstest-Failures: linux-linus:build-amd64-pvops:kernel-build:fail:regression linux-linus:test-arm64-arm64-xl-credit1:debian-fixup:fail:regression linux-linus:test-arm64-arm64-xl-thunderx:debian-fixup:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:debian-fixup:fail:regression linux-linus:test-arm64-arm64-xl-credit2:debian-fixup:fail:regression linux-linus:test-arm64-arm64-xl:debian-fixup:fail:regression linux-linus:test-arm64-arm64-xl-xsm:debian-fixup:fail:regression linux-linus:build-i386-pvops:kernel-build:fail:regression linux-linus:test-armhf-armhf-xl-rtds:guest-start:fail:allowable linux-linus:test-amd64-i386-xl-qemut-ws16-amd64:build-check(1):blocked:nonblocking linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64:build-check(1):blocked:nonblocking linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:build-check(1):blocked:nonblocking linux-linus:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:build-check(1):blocked:nonblocking linux-linus:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:build-check(1):blocked:nonblocking linux-linus:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking linux-linus:test-amd64-i386-xl-qemuu-win7-amd64:build-check(1):blocked:nonblocking linux-linus:test-amd64-i386-xl-qemuu-ws16-amd64:build-check(1):blocked:nonblocking linux-linus:test-amd64-i386-xl-raw:build-check(1):blocked:nonblocking linux-linus:test-amd64-i386-xl-shadow:build-check(1):blocked:nonblocking linux-linus:test-amd64-i386-xl-xsm:build-check(1):blocked:nonblocking linux-linus:test-amd64-i386-freebsd10-i386:build-check(1):blocked:nonblocking linux-linus:test-amd64-i386-freebsd10-amd64:build-check(1):blocked:nonblocking linux-linus:test-amd64-i386-examine:build-check(1):blocked:nonblocking linux-linus:test-amd64-coresched-i386-xl:build-check(1):blocked:nonblocking linux-linus:test-amd64-coresched-amd64-xl:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-xsm:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-shadow:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-rtds:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-dom0pvh-xl-amd:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-dom0pvh-xl-intel:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-qcow2:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-examine:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-pvshim:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-pvhv2-intel:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-pair:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-pvhv2-amd:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-pygrub:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-qemuu-freebsd11-amd64:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-multivcpu:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-qemuu-freebsd12-amd64:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-credit2:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-intel:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-credit1:build-check(1):blocked:nonblocking linux-linus:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking linux-linus:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking linux-linus:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-linus:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking linux-linus:test-amd64-i386-pair:build-check(1):blocked:nonblocking linux-linus:test-amd64-i386-qemut-rhel6hvm-amd:build-check(1):blocked:nonblocking linux-linus:test-amd64-i386-qemut-rhel6hvm-intel:build-check(1):blocked:nonblocking linux-linus:test-amd64-i386-qemuu-rhel6hvm-amd:build-check(1):blocked:nonblocking linux-linus:test-amd64-i386-qemuu-rhel6hvm-intel:build-check(1):blocked:nonblocking linux-linus:test-amd64-i386-xl:build-check(1):blocked:nonblocking linux-linus:test-amd64-i386-xl-pvshim:build-check(1):blocked:nonblocking linux-linus:test-amd64-i386-xl-qemut-debianhvm-amd64:build-check(1):blocked:nonblocking linux-linus:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:build-check(1):blocked:nonblocking linux-linus:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-linus:test-amd64-i386-xl-qemut-win7-amd64:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=9e9fb7655ed585da8f468e29221f0ba194a5f613 X-Osstest-Versions-That: linux=deacdb3e3979979016fcd0ffd518c320a62ad166 From: osstest service owner Date: Wed, 01 Sep 2021 13:51:54 +0000 flight 164689 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/164689/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-pvops 6 kernel-build fail REGR. vs. 152332 test-arm64-arm64-xl-credit1 13 debian-fixup fail REGR. vs. 152332 test-arm64-arm64-xl-thunderx 13 debian-fixup fail REGR. vs. 152332 test-arm64-arm64-libvirt-xsm 13 debian-fixup fail REGR. vs. 152332 test-arm64-arm64-xl-credit2 13 debian-fixup fail REGR. vs. 152332 test-arm64-arm64-xl 13 debian-fixup fail REGR. vs. 152332 test-arm64-arm64-xl-xsm 13 debian-fixup fail REGR. vs. 152332 build-i386-pvops 6 kernel-build fail REGR. vs. 152332 Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 14 guest-start fail REGR. vs. 152332 Tests which did not succeed, but are not blocking: test-amd64-i386-xl-qemut-ws16-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-debianhvm-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-win7-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ws16-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-raw 1 build-check(1) blocked n/a test-amd64-i386-xl-shadow 1 build-check(1) blocked n/a test-amd64-i386-xl-xsm 1 build-check(1) blocked n/a test-amd64-i386-freebsd10-i386 1 build-check(1) blocked n/a test-amd64-i386-freebsd10-amd64 1 build-check(1) blocked n/a test-amd64-i386-examine 1 build-check(1) blocked n/a test-amd64-coresched-i386-xl 1 build-check(1) blocked n/a test-amd64-coresched-amd64-xl 1 build-check(1) blocked n/a test-amd64-amd64-xl-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-shadow 1 build-check(1) blocked n/a test-amd64-amd64-xl-rtds 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ws16-amd64 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-win7-amd64 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-debianhvm-amd64 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemut-ws16-amd64 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemut-win7-amd64 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 1 build-check(1) blocked n/a test-amd64-amd64-dom0pvh-xl-amd 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemut-debianhvm-amd64 1 build-check(1) blocked n/a test-amd64-amd64-dom0pvh-xl-intel 1 build-check(1) blocked n/a test-amd64-amd64-xl-qcow2 1 build-check(1) blocked n/a test-amd64-amd64-examine 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-xl-pvshim 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-xl-pvhv2-intel 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-pair 1 build-check(1) blocked n/a test-amd64-amd64-xl-pvhv2-amd 1 build-check(1) blocked n/a test-amd64-amd64-pygrub 1 build-check(1) blocked n/a test-amd64-amd64-qemuu-freebsd11-amd64 1 build-check(1) blocked n/a test-amd64-amd64-xl-multivcpu 1 build-check(1) blocked n/a test-amd64-amd64-qemuu-freebsd12-amd64 1 build-check(1) blocked n/a test-amd64-amd64-qemuu-nested-amd 1 build-check(1) blocked n/a test-amd64-amd64-xl-credit2 1 build-check(1) blocked n/a test-amd64-amd64-qemuu-nested-intel 1 build-check(1) blocked n/a test-amd64-amd64-xl 1 build-check(1) blocked n/a test-amd64-amd64-xl-credit1 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-pair 1 build-check(1) blocked n/a test-amd64-i386-qemut-rhel6hvm-amd 1 build-check(1) blocked n/a test-amd64-i386-qemut-rhel6hvm-intel 1 build-check(1) blocked n/a test-amd64-i386-qemuu-rhel6hvm-amd 1 build-check(1) blocked n/a test-amd64-i386-qemuu-rhel6hvm-intel 1 build-check(1) blocked n/a test-amd64-i386-xl 1 build-check(1) blocked n/a test-amd64-i386-xl-pvshim 1 build-check(1) blocked n/a test-amd64-i386-xl-qemut-debianhvm-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemut-debianhvm-i386-xsm 1 build-check(1) blocked n/a test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-xl-qemut-win7-amd64 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 16 saverestore-support-check fail like 152332 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152332 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux 9e9fb7655ed585da8f468e29221f0ba194a5f613 baseline version: linux deacdb3e3979979016fcd0ffd518c320a62ad166 Last test of basis 152332 2020-07-31 19:41:23 Z 396 days Failing since 152366 2020-08-01 20:49:34 Z 395 days 684 attempts Testing same since 164689 2021-09-01 04:20:58 Z 0 days 1 attempts ------------------------------------------------------------ 6967 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops fail build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops fail test-amd64-amd64-xl blocked test-amd64-coresched-amd64-xl blocked test-arm64-arm64-xl fail test-armhf-armhf-xl pass test-amd64-i386-xl blocked test-amd64-coresched-i386-xl blocked test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm blocked test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemut-debianhvm-i386-xsm blocked test-amd64-i386-xl-qemut-debianhvm-i386-xsm blocked test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm blocked test-amd64-i386-xl-qemuu-debianhvm-i386-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm fail test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm blocked test-arm64-arm64-xl-xsm fail test-amd64-i386-xl-xsm blocked test-amd64-amd64-qemuu-nested-amd blocked test-amd64-amd64-xl-pvhv2-amd blocked test-amd64-i386-qemut-rhel6hvm-amd blocked test-amd64-i386-qemuu-rhel6hvm-amd blocked test-amd64-amd64-dom0pvh-xl-amd blocked test-amd64-amd64-xl-qemut-debianhvm-amd64 blocked test-amd64-i386-xl-qemut-debianhvm-amd64 blocked test-amd64-amd64-xl-qemuu-debianhvm-amd64 blocked test-amd64-i386-xl-qemuu-debianhvm-amd64 blocked test-amd64-i386-freebsd10-amd64 blocked test-amd64-amd64-qemuu-freebsd11-amd64 blocked test-amd64-amd64-qemuu-freebsd12-amd64 blocked test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked test-amd64-amd64-xl-qemut-win7-amd64 blocked test-amd64-i386-xl-qemut-win7-amd64 blocked test-amd64-amd64-xl-qemuu-win7-amd64 blocked test-amd64-i386-xl-qemuu-win7-amd64 blocked test-amd64-amd64-xl-qemut-ws16-amd64 blocked test-amd64-i386-xl-qemut-ws16-amd64 blocked test-amd64-amd64-xl-qemuu-ws16-amd64 blocked test-amd64-i386-xl-qemuu-ws16-amd64 blocked test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 blocked test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 blocked test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict blocked test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict blocked test-amd64-amd64-examine blocked test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine blocked test-amd64-i386-freebsd10-i386 blocked test-amd64-amd64-qemuu-nested-intel blocked test-amd64-amd64-xl-pvhv2-intel blocked test-amd64-i386-qemut-rhel6hvm-intel blocked test-amd64-i386-qemuu-rhel6hvm-intel blocked test-amd64-amd64-dom0pvh-xl-intel blocked test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt pass test-amd64-i386-libvirt blocked test-amd64-amd64-xl-multivcpu blocked test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair blocked test-amd64-i386-pair blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-xl-pvshim blocked test-amd64-i386-xl-pvshim blocked test-amd64-amd64-pygrub blocked test-amd64-amd64-xl-qcow2 blocked test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw blocked test-amd64-amd64-xl-rtds blocked test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow blocked test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow blocked test-amd64-amd64-xl-shadow blocked test-amd64-i386-xl-shadow blocked test-arm64-arm64-xl-thunderx fail test-amd64-amd64-libvirt-vhd blocked test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2103251 lines long.) From xen-devel-bounces@lists.xenproject.org Wed Sep 01 13:57:00 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Sep 2021 13:57:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.176444.321074 (Exim 4.92) (envelope-from ) id 1mLQjT-0004WK-8g; Wed, 01 Sep 2021 13:56:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 176444.321074; Wed, 01 Sep 2021 13:56:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLQjT-0004WD-5B; Wed, 01 Sep 2021 13:56:51 +0000 Received: by outflank-mailman (input) for mailman id 176444; Wed, 01 Sep 2021 13:56:50 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLQjS-0004W7-2y for xen-devel@lists.xenproject.org; Wed, 01 Sep 2021 13:56:50 +0000 Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 7348bdf3-0b2c-11ec-adeb-12813bfff9fa; Wed, 01 Sep 2021 13:56:48 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7348bdf3-0b2c-11ec-adeb-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1630504608; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=eYJQJArDZC7fN6Yxqf5+EVylu10Lw5x4htbEdY96X90=; b=VV24t14fAhFeVNcZ9wvrsX9H+GAYF8411kYEBD+MlbWguRoDFGq3ZpUL 7U2D+pRK2ZC7HICfDS6M4d8EDy3V0mGFYZQP6ykexT2egtY5MKvuXJoCr iGfj8gNzV04RgkWYVxG0bmZ4HsIhouqKGMIP28H7bVAM2aH4eBgodTY+D c=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: 6dvqWVnEwM6SEJ8MmxvtZ2WID4OZ2nsjPKjJUSq2pDMgyl0soQm0RP7D6OU0KX+XzKpSRo6njK B0+UH/rUMjfJX796/X1VbmCjgmntnd0V5+lnmeKRUPNT+Pvj1Wq8AJt11Do5M+BUYbUCXpIUUA /2R5+6vI8V5hrj2tqTy04G4Zg04njaBD/uuiqfgKSOduATk3X4rL2znPh3QsGw0LPQ2cNRKlSW LBqJOibNCd9doebXBAQuA/Agg8Y5YwTZ+sdl6z1/yTjjNG8cnwd5glk/059Y27XKwdvJmMFGEQ GM3vN6vOn5vpBDsUsVjflcpX X-SBRS: 5.1 X-MesageID: 53535801 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:Ggx2N6le8q/+24tuJdDpYqcf+p7pDfLp3DAbv31ZSRFFG/FxXq iV7Y0mPHjP+VAssRAb6Le90ca7LU80maQb3WAxB8bBYOCEghrKEGgB1+vfKlTbckWUnINgPM 9bAtBD4bbLY2SS4/ya3CCIV/MH5uDvytHZuQ6n9QYIcegQUdAE0++yYjzraXGfh2F9dOAE/O D33Ls6m9L6E05nEfhSwxE+LpX+TxmiruOZXfbAbyRXmTWzsQ== X-IronPort-AV: E=Sophos;i="5.84,369,1620705600"; d="scan'208";a="53535801" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CRyJDE8gATnRhc7ntydSeH8JaS4KoPbAfz7HkINJF/pPALKw4nWmErY3cZdAkRv9mvWlGsfxdCLD6LUoiRGKpqK2OR+ezcW8tlFAZr5SgcU87MnbOlwgpBv5Csqkra9sckot5fnRvetaXhoP+cW+bmgowWwNWnL5vD2jy3Y0ajs4kKoG66gP6ZvmlJJsofigwyosvE7LTfb6syrjJJJklvs4NYvG2CEeX1JMLBzafzwQFaPyB7O8IwzUk914IySQd0ubkRHg5oFkNcwVk/WWUumOC9GTSEScCm4VYOBzAAm7a9FKsX8Tlrkbw3+l6JnefTufMjit9UZxsrX29gqHOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=O/Rwm/zZbFnYdOqWPNkLOtEmXucxfXteYGvFJw99IeA=; b=Ucu3do1Mucy4Jv9goTV9dX6eAaZfJ+FtSC3Cy5TlS9xzpPsS/S6jsjCQHB6+TvNH38qRbYpO4V/mzGyru0uO1sseYuSSzBor1983TPb5y27KZ4NfeXrubc05zxwwUvqWngjQn8aTZLSP43i+5umcWhl//DP3bt+UPv95fX4BNxIsspD33JkPMhwwaZC8nqUtJ3Gu4oe1NQpxfBXfksMCQJZ9MHedLLpJ1/09C9szBgZ0piIhDp9pj56s/xFDBy6dGg0rDb/5WlxM5M1eRrpxK6Q3TS/zcYYG7egjWu0XvOkTrLFRs9vwDTNbO+88NhnRAAW2MQxG5CMbznpyZnvjaQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=O/Rwm/zZbFnYdOqWPNkLOtEmXucxfXteYGvFJw99IeA=; b=CQ3lRVrAZq+cuaEPD3haeU715gSouzAAqlLTH+LuEgiwvmmMBDQpU5c2h9vE6rx/mNBuYUwu8VUUdOzh1i4AkYIfWKv6s4n+7Ui3n757gk1JWNi0lBL1iGTlviLG/1IK7dNtQh3EJddqGS6EUXHmJpeaRdiTmzRI/LbLLJJPJqc= Date: Wed, 1 Sep 2021 15:56:40 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich CC: "xen-devel@lists.xenproject.org" , Andrew Cooper , Wei Liu Subject: Re: [PATCH 0/4] x86/PVH: Dom0 building adjustments Message-ID: References: Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: MR2P264CA0155.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501:1::18) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: fcac1e0d-6b7d-437b-861d-08d96d5055e6 X-MS-TrafficTypeDiagnostic: DM6PR03MB4844: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: PpZEmP5tvtGotuYUm/EmbLj9mo9rU4abSl544HqEnGKU1zyW5tMM1fu0loSlGgH/TvAgnZHU6iyzs2lmRrEIZN49q7bER/3mvbkBMSkPTzRIhH+BFZU8G7ERM3EaDv7deOVSrrTi7cLBL9SRyPDF3/qTjbi4zQl8Yr6qavh8Wuf1A7a3n0IEY6nY+ITxJ59RAaap5QVZmDD1ntXOmjVN5DiAvIZfj0qvSf9i403CHDxhK8QVaYEN97Iwr/+R7cOxkCXa+VFznUoXH2IQ37Da80OKHgOfnlwFMVc10n8muNbjpRrROrJZ8VdVp+c1OZV2CBvnIJzzwdZ/kffVtbDCRHP8S6T5eB8bzCUjGW9CqTPOfVeYUQDxpaaCZ1Aepscx/BYo2s5jxabCiYnqioZLuTrurYgUWZcIooWBHPfsGJA7Y+/06tJ42chGo+wd2/cjlmCOqaBJ1ai0E5+4m4Gi6L64W7SYp5vvcyw8YCw6H0a7bZknz3TrKMkDd2VX6nCfTik7erVrNT9vi+fp0OzR4ZBrCbGpZfGeUcVTg4JQGGlstaJT0clPme5teDCEVC+cIjhbooGIxTOsNkYx/zjo5JUZRThmU5eNNSMVWPw0EsUWfIHaOZoca69K4IXD/WMbotHgZBKSGOIjr2uH9ayCUA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(7916004)(346002)(136003)(396003)(376002)(366004)(39860400002)(6496006)(956004)(86362001)(5660300002)(33716001)(66476007)(66556008)(53546011)(54906003)(26005)(6666004)(316002)(186003)(66946007)(4326008)(9686003)(478600001)(85182001)(6486002)(83380400001)(8936002)(38100700002)(2906002)(8676002)(6916009);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bVFJRm5IdGQ1dGxnSWpEVkcwUXZvRGM4QXZYa2RrZG1CNUpkL3p5Tkw1V0Z6?= =?utf-8?B?cGRzNGRDWjBDU3NITXh3WWRtSnYxWW5DNUgrcWY2dmZXSFRQTi9ZMk12M04z?= =?utf-8?B?ZGcvUjYrSGU0SjIydnpjclcrdlgvUmtnWFNMTE9USFUyTnJiQXhPMW1TSzV0?= =?utf-8?B?VGR0SnFHbWhJa0VxUDd5RUxFUzh6eUo1VHYzY3R3U3NXT1loRnp3VThqVGlq?= =?utf-8?B?NE5VNzhOUXBWOXhzcXVWRjBJY3MrdWpIWGphVkZqYnJBTnMrODlLK0d1dHZC?= =?utf-8?B?UGZGRklwWWorZmQ5K3pRSDVUVTdZSHlMVmhFankrc1dWWFkvODN0VVUrUy9z?= =?utf-8?B?dUh2VCtHN0hjclFDYjd6UTBNbEIvS2ZwTElSTFZNZVFzVlAxTWx2SC9pYzU2?= =?utf-8?B?U3p3bmZMd1AxeHFsTTZBQWQ5MnNOUXdUamFDYzNDRjhSeHBwYkhHQ3ZGdmsx?= =?utf-8?B?eVNrOEFWMUMvaE5EakgvMWRkcmVST2xWWHZsbDlGZlZlM1diM2ltV3c2RXdH?= =?utf-8?B?R0RVa0ViQ0JMcm14VWMyL0Q3eDFmNVZHQXN5QVVTb1VDYU43YlY5UnZ0cUgr?= =?utf-8?B?TUgxc0lJZi9odXpLVFVLVFh3UHd0MjJwcTA1NlZqN3ExS2k4UEowTEhFRjlG?= =?utf-8?B?TnNUZFlOd2tmeHl5VndqRnE2NDBVd0tIdG4yT0ZCdWxyT3Z2WHpkNWlRenNa?= =?utf-8?B?K0tyQTlsS25qdE5FWjlybEJKMjJxakZvbVZKb0xvSkNRTkNOdC9DVmVwTkZI?= =?utf-8?B?T3RPZ3F0bkFUWkFwNWN4bWpXWUgxakIvaHJnL1YxYTNYYVk5czY2bnFoSlpy?= =?utf-8?B?YTJHeStmV3k3QVlXMjl1VWZTcnFNdHUzUVJRdFlOYjNnZ2lRYmloZkxtMjA2?= =?utf-8?B?WEc4MHlaSDM5SHpuOVluWEcvbUIxOEtXc2l2dUcrRXliWmNMeEFENDQ1WHdl?= =?utf-8?B?TjVQZXhmSWwvdWVVR0k1UEMvU1ZKU3hxS3FlMGE2WUJFQWwvMnFmY3ZTeTY4?= =?utf-8?B?ajkxdU9SZHpZTFVkeGpRa2lmTy9raXRiVjFjRG9SaHV6K3pSOG40a0wzckhK?= =?utf-8?B?aGQ0dC9xMDF6OGFzb1VVU0o4TXlobldXRUpIVDdVT254V3BXZnJ5ejU1SjZV?= =?utf-8?B?djFLazZBKzB3ZVVuak4vZ0t5QUtzbWRIdnhYWlRCUU15MHJEZ1JyOU45NUlv?= =?utf-8?B?dURLeHNWV1duSWdqcGFpMy95K0ZXUTVKYVZMQkxRczB6cEptcHh3clR5cVR5?= =?utf-8?B?UGdEN1ZGWkJXYTRkMmx2RFlNdThrT1liSU5CaEJqSHdqNXdtNUJ2Yy9XU3pN?= =?utf-8?B?bWVnamcvNEZ3TVdrVWxLNDhIUzBlNWd1c1ZiVVY1TVhITEppMnpWNGhTNng2?= =?utf-8?B?VzJHL09uRW1xb3B6OUdDQUF2ZlNHNDhXZGhEd0xWMTFvS3J6cEdVbTB4eUhG?= =?utf-8?B?cmRTWVBlTTdINVY5T1lGZ3FxNjJDZ2xreHhwUVEzQmNaeTlyZlBZZlUreWtQ?= =?utf-8?B?ZXdWeXBnQzA3M0VGOE12STJhODRpeDJELzJoRWlMUDlIcElQUGV6VEFQMkpT?= =?utf-8?B?bWF3NkUrSWFGRi9wS25xUVBCcEtxQ3h5VzhnV2hidjZjNGpXaEQrV1dYbUxn?= =?utf-8?B?RWtwZ2E3WGpxRTNMODBvZjMyMW0wTHQvelI3R2VJVGg0ZVlJODNvWDlhMkZt?= =?utf-8?B?d0ZOSXFFOTd3TkRnOHZBMnJrZnpwbFV2MHhKY0xpOGRCWEZIVHVqR3FORWVH?= =?utf-8?Q?4PFcvr6i9JsOsRFMtdpdUwOlDVPkXKHmrnjUWWH?= X-MS-Exchange-CrossTenant-Network-Message-Id: fcac1e0d-6b7d-437b-861d-08d96d5055e6 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Sep 2021 13:56:45.7509 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: oPO7si4FIV8lmBFhi1Y1yeWZajC5qqH55yPZK6SvM9ha9wfc28rsouH3vxE4w/lfSrPe1NWTxdlBVr2ejGRP4w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4844 X-OriginatorOrg: citrix.com On Tue, Aug 31, 2021 at 10:53:59AM +0200, Jan Beulich wrote: > On 30.08.2021 15:01, Jan Beulich wrote: > > The code building PVH Dom0 made use of sequences of P2M changes > > which are disallowed as of XSA-378. First of all population of the > > first Mb of memory needs to be redone. Then, largely as a > > workaround, checking introduced by XSA-378 needs to be slightly > > relaxed. > > > > Note that with these adjustments I get Dom0 to start booting on my > > development system, but the Dom0 kernel then gets stuck. Since it > > was the first time for me to try PVH Dom0 in this context (see > > below for why I was hesitant), I cannot tell yet whether this is > > due further fallout from the XSA, or some further unrelated > > problem. Iff you have some time could you check without the XSA applied? I have to admit I haven't been testing staging, so it's possible some breakage as slipped in (however osstest seemed fine with it). > > Dom0's BSP is in VPF_blocked state while all APs are > > still in VPF_down. The 'd' debug key, unhelpfully, doesn't produce > > any output, so it's non-trivial to check whether (like PV likes to > > do) Dom0 has panic()ed without leaving any (visible) output. Not sure it would help much, but maybe you can post the Xen+Linux output? Do you have iommu debug/verbose enabled to catch iommu faults? > Correction: I did mean '0' here, producing merely > > (XEN) '0' pressed -> dumping Dom0's registers > (XEN) *** Dumping Dom0 vcpu#0 state: *** > (XEN) *** Dumping Dom0 vcpu#1 state: *** > (XEN) *** Dumping Dom0 vcpu#2 state: *** > (XEN) *** Dumping Dom0 vcpu#3 state: *** > > 'd' output supports the "system is idle" that was also visible from > 'q' output. Can you dump the state of the VMCS and see where the IP points to in Linux? Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Wed Sep 01 14:06:11 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Sep 2021 14:06:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.176453.321090 (Exim 4.92) (envelope-from ) id 1mLQsO-0006GX-7L; Wed, 01 Sep 2021 14:06:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 176453.321090; Wed, 01 Sep 2021 14:06:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLQsO-0006GQ-3j; Wed, 01 Sep 2021 14:06:04 +0000 Received: by outflank-mailman (input) for mailman id 176453; Wed, 01 Sep 2021 14:06:03 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLQsN-0006GK-7g for xen-devel@lists.xenproject.org; Wed, 01 Sep 2021 14:06:03 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 9d39c2ae-c4d0-4bcc-9315-8e38495a13b0; Wed, 01 Sep 2021 14:06:02 +0000 (UTC) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04lp2059.outbound.protection.outlook.com [104.47.12.59]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-15-JttB8YdOMda894Ng-kwk_Q-1; Wed, 01 Sep 2021 16:06:00 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR04MB5598.eurprd04.prod.outlook.com (2603:10a6:803:e9::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.23; Wed, 1 Sep 2021 14:05:58 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4478.019; Wed, 1 Sep 2021 14:05:58 +0000 Received: from [10.156.60.236] (37.24.206.209) by PR2PR09CA0014.eurprd09.prod.outlook.com (2603:10a6:101:16::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Wed, 1 Sep 2021 14:05:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9d39c2ae-c4d0-4bcc-9315-8e38495a13b0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1630505161; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dqWHal1kSmpABLmnO9tkjLbFQHGNQcZ3wuTeZ1Bs8FE=; b=Lcj9sV3pBRA0zGtf4W0Ew+Em84AJDGPr9Yycxb4rvQgEOP1wc97tZg5SM6EMSWjUdovBfh BagboJcsrCMVLwh6XgC2oDlfMhCWETGXBCSlFONoO9Frpw1Hotei1XHzdGcrm2syRw7TAU nzT1mxQB8uw0t/ZwIk6JRSPWksGxkko= X-MC-Unique: JttB8YdOMda894Ng-kwk_Q-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DjUHqOWzRUNL9QlCkm1cLKLVBY7B/lLKPtbKv98snqghPwianmnh9oZmPTzAT/4cCWzz/nYacZBUTkl8t9x3onMCII5hLJWwf1Mrvh8BsosvImXZ6wies1l4tDV3DrTj9ZDv3UqzHPe0YJOUWlqwltfhxmwCjRFyM71ao8pHaUrjNAKX2/k1DUIEWnbiOOgjMbaRawkgIHNvBJVPHURmv5EBN66ziU0zM6oO1wEpPBdZ/yd2Dt9U+zM96Qlxill5E8iISlPtwI6ghGBK+MIMurbhHzfjqGQV6ZklQ23SwOO4n34tEaIl8eTfN7Fi7JTYtPipui9f++7qNWPl/ccjJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=paypqYQBXso7iTGQUkcCymonj0cg77qB8rkP+sbL1jE=; b=XJaJWGwmZ0Fra57Se5qp+oxp+ioxrkkfUGwGcLj/SKE2Y1hjDRGEMiiOHPcOsv67Eyxrfr08r3vNvF6ly+eLWruQsnNlkHX/DmnzQNADLKbdMwVrCOB1A0hTwDXpd1qrHsOF/wEBspivdoZleEfl2vsIesTrBM/bV483lNbZ+cRa956YJC6v1VIrHIcKVrb4E3HK469E6tBgdQvTTLuZcr/bSwqTdwjSDn+IElonWjYHf9HVnZDxVuwqAv2WTYLoGAbgdyzN/6ryj70iBhOIz+LCL4Gb/XLHO0ASpWAWI1MQRDFK/jvVJON71ORBYUQHvelFMlSS60YsgXDeFkXH6Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com; Subject: Re: [PATCH 2/4] x86/P2M: relax guarding of MMIO entries To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= CC: Andrew Cooper , Wei Liu , "xen-devel@lists.xenproject.org" References: <93ecc397-1293-69b1-e70d-3c5f9317229a@suse.com> <7f56c625-eee6-31c4-2d6f-bd7334867d83@citrix.com> <5d69d4c0-7a04-c3da-f971-616363c6d63d@suse.com> From: Jan Beulich Message-ID: <9682f7a9-7c67-a9c3-0345-11c110193f52@suse.com> Date: Wed, 1 Sep 2021 16:05:56 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: PR2PR09CA0014.eurprd09.prod.outlook.com (2603:10a6:101:16::26) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ced71f10-58d2-4911-befa-08d96d519f46 X-MS-TrafficTypeDiagnostic: VI1PR04MB5598: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: EZLZdJpqAVRbmzg9G42NNm1xuYil3/cWALCsrqLJQUGHrRoL6lXSdGtf+bUFDqULyGCGi1dypTHUItVMWIvLOjgWWr3zOitJhpaexgf/QsddFXK8RztFBrwbHvhu4xuZth4aR+PTKEIkaqedxYKACmUVUI8svOsusbfYCAkA6FofKcszQH2Mlceh6lnINn7TadtpEW8+BCbXxEZYtTrmRDxXKvgxJq0M/R5KLHYDOD43fZava8uWQszCQ8g5ZHtNZtv5X2S6n2XJx2Z7Ixj4oQVWtkQCj76gJiXSNgi0P5AvJTJv3JNfffyaiD7oWHEU/X76C3gR3qaHdOQsnabDAb1NiRufW4pLgrsN0i1lfxuFTe2V1EFOMZAkPmiqH0SadT5sWp7sYBCXagriuvNM8lW+fz7+a5oRvW9ALqsf8IzbYqcrBQngKYSD8d03/5poo0aMBLdY8q5KuBXHu//2NLRtiQwUsPaz1R8BEUSKKE45QcaInit+D0M5eCT1OGtVexmcNH1ejHkgzcqEHeQH5EJJgEzHJXAD/lME7ifk7LYNP0CnTc5ulHHD7RdAZGfvoq0G3p1/7oX0ewCUIY4D8RDdtD+kzLFThmlpF0ZIExfqt1kG1g3kcYs91wjhw4OBI6Sokd109T71DWe3WoBhJA4rZqGh8m/vYC55SLS1EyH3q269+gwnPoExwgdV31GSqtez5sIgEf/v+T/ujGrwhzdbHzJNaAM/I3u/qETxa/k= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(136003)(346002)(396003)(376002)(39860400002)(53546011)(38100700002)(36756003)(8676002)(6916009)(6486002)(2906002)(31696002)(186003)(5660300002)(8936002)(26005)(478600001)(956004)(83380400001)(16576012)(54906003)(4326008)(66946007)(66476007)(66556008)(31686004)(86362001)(316002)(2616005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?uCsrbEH13C/c88d3uq4WMugelqd/tgqx8vOTlnitcyd7XT7sis5sXqXkjz6X?= =?us-ascii?Q?uz+gsdX8kwYNQSk1hIdpI3B6X8+lbIkSn5zBwNt83DmTwaIYRjmDFR32zBZ+?= =?us-ascii?Q?n5aKlvf9SEfVlD+2wl9sv4XrSEjeWTEspHfbKETP+xOc7X8lwek3ffO4zQk1?= =?us-ascii?Q?kgoHjWZbdyu1DmghlOsfkM9xfqLkP1F8KLqkdmbtT3gjuvP+b8vwOcRlO3Zf?= =?us-ascii?Q?MWtehunU2QFzfE2BAPEPgAg7wh07CQlD3RgxNqm3dj0ARpY1BTwhepwN5Xzk?= =?us-ascii?Q?ZOO9FzMxk2svd4nZG7XG+GO8O61IKNNaCfhudRjCq+RagiNBNIVWGd5cNolP?= =?us-ascii?Q?iz4l1L1YJ89p9nZl7djTAOeEyNeOKByPydq51UuRAj5X/uVYFHu10vSK8R02?= =?us-ascii?Q?bJHsEu2CIKREJlD+UW1BDZeKyMlDJLBLUJc/U2eOqS/e4idvAFXajFMXU/rX?= =?us-ascii?Q?aqAkPCSszkzZ22gAEsdWCCb1iuZV+s9XlI+wre7f61H8tCUAGQHYQy3Y/Y8Z?= =?us-ascii?Q?Biqk7JHuayLbyKE1iuqyQrEosUkFuIvJ5IUYHKYw+1BsxSXdbSPy1hrRahqI?= =?us-ascii?Q?N2/4/35NIzZsmQyIqT5cN5gTl6H1WR0R2SSZ9rYkfQ1HUE2LYa3+71JWlSgr?= =?us-ascii?Q?FIQl9j1vlzpOOvz/YXHaw7oGPABe9Bf1L+HxTQwEpjIf3Poa2JNMO9+5HVDz?= =?us-ascii?Q?S7sEPEofm123O1Yvf+4kixlnCRydsDmlQUuYK0CAK0fs7RN0z+wRyq5mUH7P?= =?us-ascii?Q?l+Uv6bosyXY5OBl7hokjtzTVIB2OCzhDf8g/3/ZriP0gKJ0KJ3tiMNkGSqAz?= =?us-ascii?Q?6tN/zw0nAnXHFigmUmCQhYgDQbYD4nD9j3RXkhPehO255fgPjXrsw179GTmT?= =?us-ascii?Q?dlb0mI9pssDUjmuAiNTgdBN3AqDNcYbL5X61NLTHqsipiA+5nUn9BVScDNaW?= =?us-ascii?Q?sjb10rOAXaW4cFfPzaXjYiZwOOVeSBELIX+dRBly4tLo9e98Wy5U1vn0RJrH?= =?us-ascii?Q?5FsdMk64ZxnYU0yHAhZyfheAOLSTV74+LfglzpPdQjuNqJaMoA7NacAh9dlq?= =?us-ascii?Q?t4tBDOeW4ZOSVta5U0dQeLxslFWPpXUuchUyv7+pltKdhLtHn1ZEVwyRm4EZ?= =?us-ascii?Q?6Jl1es+4Lg61QtZ65GRi1JbYeyD16ToWgXmE8R260tLvo7fU/e8ULPDW0WAh?= =?us-ascii?Q?pruFU0YjmzFegj5zQuHzVv4SmKWRSoGx/XeH4geHOZi8iIbHAmO+bKfHgcM4?= =?us-ascii?Q?44ojUC2TA2Yn6gwP761sjmLk8kHk7TqlZYZTVsjdV0F6fQK2LUJnSD9mfGQn?= =?us-ascii?Q?v61AZqsqqJb6VSO0rNG3TxUp?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: ced71f10-58d2-4911-befa-08d96d519f46 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Sep 2021 14:05:58.2667 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 8JS7TxIV/o/XVTPfISXZ/b1gdduJfVPNhbJDlX52dp6npQ45YqbLIvt5nVtcNVH0sMLQKLyAXNPxNUbsizvOkw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5598 On 01.09.2021 15:48, Roger Pau Monn=C3=A9 wrote: > On Wed, Sep 01, 2021 at 11:53:03AM +0200, Jan Beulich wrote: >> The issue isn't just with execution, though, and as a result I may >> need to change the logic here to also include at least W. As of >> one of the XSA-378 changes we may now pass just p2m_access_r to >> iommu_identity_mapping(), if the ACPI tables on an AMD system were >> saying so. (We may also pass p2m_access_w, but I sincerely hope no >> firmware would specify write but no read access.) >> >> Similarly in "IOMMU/x86: restrict IO-APIC mappings for PV Dom0" I >> now pass p2m_access_r to set_identity_p2m_entry(). >=20 > Not really I think, as PVH dom0 is the only user of the > set_identity_p2m_entry call in arch_iommu_hwdom_init, and we should > never identity map the IO-APIC range in that case because a set of > emulated IO-APIC replacements are provided and those require ranges to > be unmapped so that accesses can be trapped. Correct, this would be only a latent issue for now. The code passes that value, but that path is not going to be taken (until, perhaps, a future change). >> I suppose an underlying issue is the mixed purpose of using >> p2m_access_*, which possibly has been against the intentions in the >> first place. We cannot, for example, express r/o access to an MMIO >> page without using p2m_access_r (or p2m_access_rx), as there's no >> suitable p2m type to express this via type alone. We may need to >> split p2m_mmio_direct into multiple types (up to 7), I guess, if >> we wanted to remove this (ab)use of p2m_access_*. >=20 > My main complaint is mostly with the fact that some MMIO ranges are > mapped without execute permissions when mapped by > set_identity_p2m_entry vs map_mmio_regions that will map them with the > default permissions and that has execution set. Right - as said in a reply to Andrew, we may need to drop some p2m_access_t parameters in favor of using default permissions. But at least for AMD's IOMMU-unity-mapped ranges we will need to have a way to express at least r/o. Jan From xen-devel-bounces@lists.xenproject.org Wed Sep 01 14:16:17 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Sep 2021 14:16:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.176461.321120 (Exim 4.92) (envelope-from ) id 1mLR21-0008L8-HD; Wed, 01 Sep 2021 14:16:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 176461.321120; Wed, 01 Sep 2021 14:16:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLR21-0008Kz-Dg; Wed, 01 Sep 2021 14:16:01 +0000 Received: by outflank-mailman (input) for mailman id 176461; Wed, 01 Sep 2021 14:16:00 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLR20-0007uB-9r for xen-devel@lists.xen.org; Wed, 01 Sep 2021 14:16:00 +0000 Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 5d5064de-aaff-4d0b-b2e1-04820891abd9; Wed, 01 Sep 2021 14:15:53 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5d5064de-aaff-4d0b-b2e1-04820891abd9 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1630505753; h=to:cc:references:from:subject:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=9G1ixSwpVVNGO1qRAX6VZalDZxApZgkQDoR8Qn+vkJ8=; b=TsbSjKru0uqxfW7Z2gI3J5b+LdmwoiasA1xw0FDNYqTt+Mv1YCedGyHI QKUeJt26GR8aLlhAUCgjIfb0hO+6mIjjyEDbbtveSot1usJPJuvWmQyNf 2NsLl/xNqgMNizd+38WZ/AqU4tlGLuPUtfuw3TB/y2nBpx0hEqFmTYbmu 4=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: jReWgYl4LhKRC49tJO1X6kLz9XPWilzcEjx7uo+RU7C/pmTAF/49A7VNUznIYMmgmPzJhGwAMD b7kjXB2GgNsP2V+8FiD78hKAufV6WrT9K94ggJ7ZWWoJjjlDFbokr0R7KWtgmedrDCW0bed6es qtNVefiGvOCBv8n2wshBZEUN+JvxMpAfIIrfov99781KqSeY29eSxyGaWpbzj4wt9+TIH8qU3K pa0QvEdNb/uIfoc3SPuysCX0LiUVbjT2ZQ77VsiGjUEbgyq0dpvIzE0VnxPc40UJhL0k665V0v USu7frJixBq6jcAUVLjaSYOc X-SBRS: 5.1 X-MesageID: 53539810 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:z7uTmqhJkhqUKspSXCnSq/OhrnBQXgoji2hC6mlwRA09TyX5ra qTdZUgpH3JYVkqNE3I9eruBEDiewK+yXcW2+gs1N6ZNWGKhILBFupfBODZowEIdReRygcn79 YET0B/YueAdmSTj6zBkXOF+wBL+qj7zEiq792us0uEVWtRGsVdB58SMHfiLqVxLjM2YqbQRP Knl6x6TyPLQwVvUviG X-IronPort-AV: E=Sophos;i="5.84,369,1620705600"; d="scan'208";a="53539810" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fYbYmCJH+WJklh4o8rDBPVj/33lbhgYmnWm0ogsc4QS2Jm4UVOtgaK8C3ylx3hoXIq+KNLqqCowcF7OdNKllOV+Mw9wob6TVf1Bpn2QZxzHi4Hb/WQikuS4+Zo8S3vZl4e2GZqUAg9jWi4L9OXnYD+l/WjxTMQK2AxAMcm+JcO7q5v4QJ9pq4hEXD66g+sYbwg7uFmOWnt8U2j+Rm+bN0+8KFjLPsxnKlDv2tVwYt3+y2V9jLsWspy/xtAaYn+QvIsL8ZwDwpABJcput94pmiGPlE5yMW64NMY9C3QILsGvRbkLGNGYL9JT8EGmcDB0goJjY01O1TpMSXO20CXMwLw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CiBzRMexSlFVfa1By3ARHlf7/NosDQULtDXwjFeft14=; b=Wa3zR+FNV8Z1gbEQFgdsf/oFNVGQyg8yediOTYI1UeP+0BySo1ZIQ8zdcLi+2gJnCjgXUek026qJiBBSjDl2Q+Uqk0dPY85EzqKtrCTFX5Y2J6KpqATdp4tbnms/pP6XfvOMMtCB8nq3FzC6UaHisIOGjyemi18EijjDZWp7KfGTUFyAEQncCfUoDSlDw8UZDy6Q23RkyHBtNAViSf+La6lcHLp+ljyYob+o1pQ3WPDOW1znNeSq67W3GU2AaworQvC+OmMFOXf5nEST0Xs764pwcMOWDgOLbSAD43D2l6o5v0/4y8OoCbKUUB0+AH2W158VM1c1AeOM13JUKNXifw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CiBzRMexSlFVfa1By3ARHlf7/NosDQULtDXwjFeft14=; b=VdL0Rp8yod+mjLG0Tisy0+BaIegQ1GRk76S/9mYeOKVX+cklOFIFD0yQ9Q4Xj/tqRh3EMPbLlqLtdmwbQpFP7R4tNTio46zyujxWcByKY6SYvBgONu4Zvzcz4Unr5CBzageoXlayIjkmExIFI5MWNCnPfJv7rQA4O1X402Gs25M= To: Jason Andryuk , Xen.org security team CC: , , , , "Xen.org security team" References: From: Andrew Cooper Subject: Re: Xen Security Advisory 378 v3 (CVE-2021-28694,CVE-2021-28695,CVE-2021-28696) - IOMMU page mapping issues on x86 Message-ID: <43ba10b9-4b20-81d4-6bdc-18f9c2e2e0bc@citrix.com> Date: Wed, 1 Sep 2021 15:15:42 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: en-GB X-ClientProxiedBy: LO2P123CA0073.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:138::6) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 233b439b-3171-444e-d1fe-08d96d53000b X-MS-TrafficTypeDiagnostic: BYAPR03MB3861: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7219; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: YlrVzEdOwyd4p4YyT1+xDKvUIYH2vTA4KKrgtaoryH3DoBaZ46y8fKkPSzQ9uzSu9oysNpyIceLKBiVg/7kT7fGthqRZr3977LbToSj9wmXxb+8uHdgBOIbjnSOI5UV4jJ2Sfa6tDvZjl9SHipB1aAsEFfzijD/eVN3zDalPBq1SKD0v8yufF2tH8YOtR0r+rd7109tZNVbTY2TbU+QMYNhnHccYRG4OujO2Nc5Wm5N5E6E0eML9Uji+BWZvaX+RW4ENC042hiOg8Z+VVDRzQzJMXmTvcFwsSX3uFFmrCzq6H/3E6I6i8oowAJoyRbKcAfxjRJHjAqmhuNnCAOjGtMBwnsT7yZiRdFktmioSOEILIluQM9hA8t7SRKxEOZ86YUataMsPnUPgS/ZxL4nky1JjCmINEQjrLI9fAoSrPO5uJ5czYxUN8+xY6xxOxZ+hjZK34xx1aGJ85XvncNKNNoSwrDfxMsPIxqtr0wBHhfWwnFw5m2kmVTpOj+nCCiM+cHphpM0nxDUnEcV2AoajXtD1aEC/4Y6A8zZn1CBJvuCxUyhNJkN7BhZFCdU0jPqddc4BxmJiyYqSv1bASq8MhT+ZA406dxX28jwZoMHAqONhEPVRnWLTwMzYLsHYeuBgCatBg5hpof7yldRsy91f1GPraIgZZce35lotcc8QDvj+b+2ha/lUUmgxWnKf5oUYXa2rQMSJCBT38c/VY0HzbH1PzkiqFWrS0MqiJNYBjAE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(136003)(346002)(376002)(39860400002)(396003)(366004)(38100700002)(31686004)(86362001)(6486002)(5660300002)(8676002)(66946007)(8936002)(83380400001)(6666004)(31696002)(66556008)(66476007)(15650500001)(4326008)(316002)(110136005)(16576012)(26005)(36756003)(186003)(478600001)(956004)(55236004)(53546011)(2906002)(2616005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bG9HcXcrVkIxOHNFSXZBWjVwTUQ1d0NPWDVZSUh5cHptQ2V5K3RRQ3RDSVJH?= =?utf-8?B?TjU0UGV2UWt3SFYwNlVkdlllbTFtMVRIVjdNc2diYmVGSWtRTjJLMHpnaU9u?= =?utf-8?B?RGxDVm13Rm5PdGoxR2ZWVXRBRVV5bWVWZlRadDdMSyszcHhPRXdLM082NG4y?= =?utf-8?B?U20zM1dVRXEwbU04TWlRMk5ZeUFHdkJpRHN0UEJlc1dlV0c0WWRYUDRCa3pv?= =?utf-8?B?NVBBSG5HeHlPbS9KcjBhMFQySU83YVVYUlppbzlsYm9hN0JyYkNsb3Y2TDMw?= =?utf-8?B?dmNDK25KdDhlVDVjTHpsRG9WWkVkQWhEaG9CMng3MUF4L0ZuWWtKc1VpVGwx?= =?utf-8?B?VkhveGlJZGxZbVBkNXU1VlBSSGo0SXNyOHNOZ1BRa1l3cGpUcE1YY2ttZFlE?= =?utf-8?B?c21SNllQVncveDJSN1lIazlnZ3NGdFA1TklnMDUzNVozZnVDMjBIakEvcVMv?= =?utf-8?B?RmM3NWcyV2llcnBCSWN5RXVLMTBNZExSR0xHRFlMMHNsMms3V3ltTXJnQWZT?= =?utf-8?B?U3Z3ZWIzT2hzRks4MlNNVC82eFlUUy9KRm1qd3RndnMzLzc0aS9JYVZ4UUYv?= =?utf-8?B?UWh1YUUveW1EQytyMkFsQnNuYkJTcUhGUWN6MDkxZE1JTzlRRWQ1THIrRDJp?= =?utf-8?B?LzVnSUFpNVB2Q210bE9nVitKMXl1ckgrN1Jtd3A2VHhOV3VtcG9GSG56Q2xk?= =?utf-8?B?NVZmWmFydFV1aytUZDRtbW8vOG1yYlkyMlVVYUduMXMzQ01Tc09CSzhQNkVD?= =?utf-8?B?UGZVamtFaW41NzljOHJFNW5nWHJ3N1dyM2o0aHVua1ZEVHFjbEVOaUc4RVJW?= =?utf-8?B?cjdwb3dURGthM1FOSVRGU1M5bUwzNlFXY0NBWjk3Wkt0UCtqYlNzV0ltZnRZ?= =?utf-8?B?bGRycXZhano5dEswYzY1TUlPV3NzS2grQXJIbjZTZnk5RWN0dVY5K3MxVGtN?= =?utf-8?B?V2VwdEw2cWZOWTNjOUtaTXRCQ2R4UUdFbzZBVWE0NktSdlZzQXFFcHdkRGkr?= =?utf-8?B?NWdXc1hoQmJRS0dTSE9mZ3gwbWgzaEczSjQxTWlNYTFxNUxFV1U0TlpPWStE?= =?utf-8?B?alJoZUttcXBFMkVzN2JMM0lDWVpSTDJ1THNaMVNjdk5QOXlSSW5OQ0FrTjJJ?= =?utf-8?B?VGs1bWwrS0xhZW0xNnlIU2pzL3NNRkVCbXdaTXJwWnJnTzBKbVJpcHJGdzN3?= =?utf-8?B?Vy9HYlljTExCYlh4VFNTZDVvc3h5U29HNTdSV1k2cXZ2L3lQRnBmZFFEcXFx?= =?utf-8?B?b3h5NUwvZm40YzlOeG5lbmlORnNsa3luSVdpMnBUaG1rVFdDQXFtQmdmQUtC?= =?utf-8?B?UWpJMENqRHdqbHZ5c1I1UmN4dFc3NTJzRy9lblVPMXpnUURJbHFTUmtvdU1M?= =?utf-8?B?bVlabGxiVU13SUVLUGh2T3hFbFlCTWZ5akFwUVNjRU9ycTRqR2Z1VkhBRTVW?= =?utf-8?B?aFpmY3pDcHl3ZjBaYWU0eC80SDRlMDEweWtvVXo0SjBUeFhrS1hMenljU1dF?= =?utf-8?B?V290azY4clBRTHFEYXRoMUxJeVdYVzNHTHdNUEdHU0dNSkI1SCtBemdkb1JU?= =?utf-8?B?c1Z5dlpuVlBBeG54dkdIOHNkcXBlakw3TmpYTkhSbGNUa3QrT053eSt6a3Nm?= =?utf-8?B?RW1Ta3VLNitPbkY4eGlzK3drMDVIM1VqTWtOUDY3VWhVQ2xlTUFOS3JGSzA0?= =?utf-8?B?M2VIelhGZ0VPYzVvSDc3UEs2R3NiVjM5Wld4SllzeERqOHQyTTQ3NXNza0x4?= =?utf-8?Q?0DErMNqBZ9c7rzkGe8H8u5vpqTcCFSAn3gpVEJm?= X-MS-Exchange-CrossTenant-Network-Message-Id: 233b439b-3171-444e-d1fe-08d96d53000b X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Sep 2021 14:15:50.1472 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Js9mm6UeiYw54KeNyeuL1/3dX+wMRzRqyXCYzraVNrPAlbz+LVflrRnXipHl6auEZ3JCC9BqUqRaJl448oUYifNePqRHFx20mzllBhakcgI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB3861 X-OriginatorOrg: citrix.com On 01/09/2021 14:22, Jason Andryuk wrote: > On Wed, Sep 1, 2021 at 5:34 AM Xen.org security team w= rote: >> -----BEGIN PGP SIGNED MESSAGE----- >> Hash: SHA256 >> >> Xen Security Advisory CVE-2021-28694,CVE-2021-28695,CVE-2021-28696 / XS= A-378 >> version 3 >> >> IOMMU page mapping issues on x86 >> >> UPDATES IN VERSION 3 >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >> >> Warn about dom0=3Dpvh breakage in Resolution section. >> >> ISSUE DESCRIPTION >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >> >> Both AMD and Intel allow ACPI tables to specify regions of memory >> which should be left untranslated, which typically means these >> addresses should pass the translation phase unaltered. While these >> are typically device specific ACPI properties, they can also be >> specified to apply to a range of devices, or even all devices. >> >> On all systems with such regions Xen failed to prevent guests from >> undoing/replacing such mappings (CVE-2021-28694). > Hi, > > Is there a way to identify if a system's ACPI tables have untranslated > regions? Does it show up in xen or linux dmesg or can it be > identified in sysfs? It's possible, but a little convoluted to do.=C2=A0 In dom0 (and in an empt= y directory) you want: acpidump > acpi.dmp acpixtract -a acpi.dmp On Intel, open up rmad.dat and hexedit the first 4 bytes from RMAD to DMAR (yes - really - this is how we stop the dom0 kernel from trying to poke the IOMMU directly.) Then disassemble (iasl -d) either rmad.dat or ivrs.dat depending on whether you're on Intel or AMD. On Intel, you're looking for Reserved Memory Regions, while on AMD you're looking for IVMD ranges (specifically, types 20 thru 22) These, if present, describe a range of memory needing identity mapping, and a scope of the PCI device(s) the range applies to. ~Andrew From xen-devel-bounces@lists.xenproject.org Wed Sep 01 14:19:49 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Sep 2021 14:19:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.176488.321136 (Exim 4.92) (envelope-from ) id 1mLR5g-0001Fl-8a; Wed, 01 Sep 2021 14:19:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 176488.321136; Wed, 01 Sep 2021 14:19:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLR5g-0001Fe-5g; Wed, 01 Sep 2021 14:19:48 +0000 Received: by outflank-mailman (input) for mailman id 176488; Wed, 01 Sep 2021 14:19:46 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLR5e-0001FR-Le for xen-devel@lists.xenproject.org; Wed, 01 Sep 2021 14:19:46 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id a6bf3524-59be-40ec-a7af-5a65a7662838; Wed, 01 Sep 2021 14:19:45 +0000 (UTC) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05lp2110.outbound.protection.outlook.com [104.47.18.110]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-37-pO-0Ug3aNSKlsbxObN8-zQ-1; Wed, 01 Sep 2021 16:19:43 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR0402MB3933.eurprd04.prod.outlook.com (2603:10a6:803:24::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.24; Wed, 1 Sep 2021 14:19:42 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4478.019; Wed, 1 Sep 2021 14:19:42 +0000 Received: from [10.156.60.236] (37.24.206.209) by PR1P264CA0008.FRAP264.PROD.OUTLOOK.COM (2603:10a6:102:19e::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.23 via Frontend Transport; Wed, 1 Sep 2021 14:19:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a6bf3524-59be-40ec-a7af-5a65a7662838 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1630505984; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tQvyW9DZnTbNz1g08eDHxiiv3P155ZpR0UZdx8FIPGY=; b=XcHdqP7S2a4Ka3OzIdYDDFCELdnzpDskxnc+IuFxRO4f+eSejIVDR19t73C6cp8tqWsSa6 kRGKTrz7/ZbOe2SEFIxgd+jrZ+7bX9TyjEvlwiCHlQQvOGT7gfcYSlEufs0DRyGoPRYKNJ KCLos0K7CJh7GLH2FdHwdL9uIQYkfrs= X-MC-Unique: pO-0Ug3aNSKlsbxObN8-zQ-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=d1JwmWHmVkxC17IAWtWsXZ6e/7Yn/j2Mfg1mvPh++ppSeFFMXhdR2nwaoYuWFPDERhs8WCsRdB3vuPiR8AenBRtoTcyDbMbHWpPE+RrD40MSbAEaTQhst89fhJH4Bl1xfrvLjmwDl9hlf9SXNw9J3uCa9la7yWX8JxHA0XB0yrRaz2xZVD5+3tIfrgteji1HjWDLV708RUOmas3KlSyxxAXooHKjSut8kiCns4EtKoDyuSQ/e5Q+ZC+9J4O4iVtVa1sF5gM8pRIqBNz71GvbCYu1i2wK9ZA9iYuQ3gA93vJpba8dihS91H/FxgBgsbAiS/br3pMWFvR4txK3FkKEEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PmraVwts6NZHguDo6kFeRqkMKWV84aKR4N5NB7fnG4Y=; b=Y+pNbrhgjZ2lzkIpKUA27VJVoraviRC/tTOVuKwxa6GKd1GIUBAmPy9bxgjSLyis/afO3aXzdMw6A6yGX3TLAvf5Y9ppEWwRbLdtU/Cbxn8zc3lxsSLPe3HmHfTMLsZuiHd11EKfTdvplk/rqdjVLqzTTswrFpQIrydmgrjxp1RFurkQRPwRFLoV5HzBWP3uVHD6TbQX4TlpxsjvPqqhJUME/y1Iofv92g6EXt8zp7Tq03q9b2LP9yLojtspmW9QaAEYxjQJ9Q7wMPpYurEHanO0/lELezJNu4+g+5SQ3XvkCxA9BuL0wKjnvHTlIp2rWeX1pbubVT21+Dp4htvy2A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=suse.com; Subject: Re: [PATCH 0/4] x86/PVH: Dom0 building adjustments To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= CC: "xen-devel@lists.xenproject.org" , Andrew Cooper , Wei Liu References: From: Jan Beulich Message-ID: <17c5ce48-11e6-ac97-fa67-294cbb8b79b7@suse.com> Date: Wed, 1 Sep 2021 16:19:40 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: PR1P264CA0008.FRAP264.PROD.OUTLOOK.COM (2603:10a6:102:19e::13) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 18118962-76fd-4960-2a47-08d96d538a41 X-MS-TrafficTypeDiagnostic: VI1PR0402MB3933: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 99wmS3++441NMUm23N7P34rGaiR7JqlOaYSJDF18MlTHLNJRYdM+HHYhZG4PgZ35g9zGXnfC3DWduPfD62Er14lQEt47IkC94aF3enKm0nnxZKMMp9v3hfOR5KwsYpI+/wXHlmVPHAYZou6Hkf0KMJXPkpOTEqDmktOrOZAt4Ts2s7lTlBxalVhrcegr3/yMLDLPjEgLhfhReugiMkzV5GfqbX3hpd62TEhgIP+Ai9X1ct8knDODHnO1vz6JW+PUAuDJzrBzMZ85DQKaQopnBcvVBGJJektmODFb/q96T+grNhRw68oCEJXrhsJWzVPKQ29RPiYu2rIsULzTeqlJ0k87d/4gaNF83GpoiZMXYsorRKuGy6zCAaJUPqrG3epstNK51XLVweS/2wa7QHUWQgQcviOVDibDgLgSZ+Vqs+SmqPDjNoMk9fI3gvwV2Kv7YaYQwXlAr7ELUnW4fdKvwyDMnJ2T5LaIhPAHDbd1MORTAhZ9Xmfz7u8waugXA7j7IuQex51nbdKHXmnjFbqVg30sNPMg4WqgmuQPP8SJWz6/y13hOh8hIyoW9H3nSGRsULc3r3rfaN1c6WPqo7/6Nw8Susn4iJB9m/Y4BKT4kdWcIHp2AXpFmbFcXjjolEa7xkXJAJsixct4POrYiC2LlGYKznjy80ImQ418V83Ik6ZCb79y3WBAGOGwnVbS2CHiI2X59ZSHWkw2pJgxix7cCAFSGDzMJ+nGAMCoYrgI3Aw= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(39860400002)(346002)(376002)(366004)(136003)(396003)(8936002)(31686004)(4326008)(36756003)(26005)(186003)(6916009)(83380400001)(956004)(2616005)(66476007)(2906002)(66556008)(8676002)(53546011)(38100700002)(31696002)(316002)(478600001)(6486002)(16576012)(66946007)(86362001)(54906003)(5660300002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?XFEJSOHv4THPSg81W2K6anC7cOpTYyckTO+8CMB95Tiuqa1M8wi6APyVfXQd?= =?us-ascii?Q?CcvfRCCtl1jAwDstEUVcxm8kKFDhVkyVSnd+53n5vmSfT2XmjcqH+owkc/zh?= =?us-ascii?Q?cwO/M6BtWTngj47xS77Rt1X0fDQwSdjWsigsM9Hyoy/MPS9TtjkSe9GB1OPI?= =?us-ascii?Q?Hg/XP5YtKT7o0Ax8XrtymCfuiLBu4qOlinpRMqrmNmRUrUqUmWHQaXBShSsm?= =?us-ascii?Q?lsiTqjKS3BYDs5pcjMM4HHnBpBc3+vcN/6bzDF3RpkvotU7MqarubPG9ZcVv?= =?us-ascii?Q?DmnQH7uTzBM374MBP0asBVPkg6fJqU4tvDDtxNQgrh2X689tHHd1iyLIB5D7?= =?us-ascii?Q?gpUoO+T9hFK8BO5QOPIv8sHQlu0A5f0xG7hV9ovK/d/oFMrx0+qpJOdSUMpd?= =?us-ascii?Q?/kw2wpHB+ZB8sS7WzVfynngOjSzMWEIcBdnAjiK8tOwzzm70Nv0nHDP0AG6g?= =?us-ascii?Q?gO4pgUuywimOjvIlwm9tz49B+tfksw1I9urGoDiTRrRqebt6dYtr3pox2FyE?= =?us-ascii?Q?gI5hqRmeLwEWdDDfi/OMP+aTEdSASUmAShbni9t4kog5nDjT1LBS+5cOXt2P?= =?us-ascii?Q?/JhoRhGtzrH1Ij3eI0+pXA57R8wYLbLvyFOh2ONNPqVy3hCecVdV/jzROyZx?= =?us-ascii?Q?RHqzhoa7+uggMObF56ZjjgU/noYJjlrIZmPRtQ1IlQAPt+H6xjgy4BNbHz5L?= =?us-ascii?Q?SkTxT/ppAt4cqnsRhENN3/BEVzqUm95ctp9ickmN9W2zMaeBLw1h9bix2z6d?= =?us-ascii?Q?L1GXKPJ/iBMlRa1WNm+rfSaP2wrr9gpYqG/nGxz6MW0deg3ajCjWoymTDPFl?= =?us-ascii?Q?3L1BsE8WZ7ZPNl9BJ2AN2pMefihpMGxfqVLX93aKpVJQHyvyYCiI8RvLkSz+?= =?us-ascii?Q?NpmM3nNRjBq4E0JdzQXWI2Y83qNCfd3KD+IJqKaXk4YTgUnoZq/29iLLnMvl?= =?us-ascii?Q?LNN7X8NrbMyv/FVycHhFloGFzqScCYVPXA6sF8OOg2Jj7SYwGRNpxORG+c3f?= =?us-ascii?Q?r7/C6NIk07jNturre0twO/usWrmXR5RQ5x/UWuIdx5pd6pJOKJrxk38ahMvA?= =?us-ascii?Q?QnZ4Wf6uNutDfEjGNhsZ8k2khLc4E6psor04ixVwjUNZPmVWhabdSW/fjGQE?= =?us-ascii?Q?mba5oYP2uZJZit8pRLasmdfPLvsBJ/YCf++Mm2pgP6Zaa/rbEaPFkyjsQRmx?= =?us-ascii?Q?ZDcgqLX0rzZZbGpnZzYvRkuw5dGXg/eDPIU0NbldQSBWh+cwvMs7UFFZSwfG?= =?us-ascii?Q?cpSnFNmRfxyDfinpQiOSd6xShtPbhlLYUEym/Dawl4nBDUZ86Hm7OKqtqBUh?= =?us-ascii?Q?eKv/Sj5zODiAuB62GNbUuYjq?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 18118962-76fd-4960-2a47-08d96d538a41 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Sep 2021 14:19:42.0074 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: MNN04Ce+d1dSEimCtB8IPK+zoD/+YoB14W17VtEmOnDmweG18petr3AoDuFzcpFe3VSkV5fJhHEcnDtXttgdhA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3933 On 01.09.2021 15:56, Roger Pau Monn=C3=A9 wrote: > On Tue, Aug 31, 2021 at 10:53:59AM +0200, Jan Beulich wrote: >> On 30.08.2021 15:01, Jan Beulich wrote: >>> The code building PVH Dom0 made use of sequences of P2M changes >>> which are disallowed as of XSA-378. First of all population of the >>> first Mb of memory needs to be redone. Then, largely as a >>> workaround, checking introduced by XSA-378 needs to be slightly >>> relaxed. >>> >>> Note that with these adjustments I get Dom0 to start booting on my >>> development system, but the Dom0 kernel then gets stuck. Since it >>> was the first time for me to try PVH Dom0 in this context (see >>> below for why I was hesitant), I cannot tell yet whether this is >>> due further fallout from the XSA, or some further unrelated >>> problem. >=20 > Iff you have some time could you check without the XSA applied? I have > to admit I haven't been testing staging, so it's possible some > breakage as slipped in (however osstest seemed fine with it). Well, I'd rather try to use the time to find the actual issue. From osstest being fine I'm kind of inferring this might be machine specific, or this might be due to yet some other of the overly many patches I'm carrying. So if I can't infer anything from the stack once I can actually dump that, I may indeed need to bisect my pile, which would then also include the XSA-378 patches (as I didn't have time to re-base so far). >>> Dom0's BSP is in VPF_blocked state while all APs are >>> still in VPF_down. The 'd' debug key, unhelpfully, doesn't produce >>> any output, so it's non-trivial to check whether (like PV likes to >>> do) Dom0 has panic()ed without leaving any (visible) output. >=20 > Not sure it would help much, but maybe you can post the Xen+Linux > output? There's no Linux output yet by that point (and either "earlyprintk=3Dxen" doesn't work in PVH mode, or it's even too early for that). All Xen has to say is (XEN) Dom0 callback via changed to Direct Vector 0xf3 (XEN) vmx.c:3265:d0v0 RDMSR 0x0000064e unimplemented (XEN) vmx.c:3265:d0v0 RDMSR 0x00000034 unimplemented > Do you have iommu debug/verbose enabled to catch iommu faults? I'll try to remember to check that, but since Linux hasn't brought up APs yet I don't think there's any device activity just yet. >> Correction: I did mean '0' here, producing merely >> >> (XEN) '0' pressed -> dumping Dom0's registers >> (XEN) *** Dumping Dom0 vcpu#0 state: *** >> (XEN) *** Dumping Dom0 vcpu#1 state: *** >> (XEN) *** Dumping Dom0 vcpu#2 state: *** >> (XEN) *** Dumping Dom0 vcpu#3 state: *** >> >> 'd' output supports the "system is idle" that was also visible from >> 'q' output. >=20 > Can you dump the state of the VMCS and see where the IP points to in > Linux? Both that and the register dumping I have meanwhile working tell me that it's the HLT in default_idle(). IOW Dom0 gives the impression of also being idle, at the first glance. The stack pointer, however, is farther away from the stack top than I would have expected, so it may still have entered default_idle() for other reasons. The VMCS also told me that the last VM entry was to deliver an interrupt at vector 0xf3 (i.e. the "callback" one). Jan From xen-devel-bounces@lists.xenproject.org Wed Sep 01 14:24:17 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Sep 2021 14:24:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.176497.321148 (Exim 4.92) (envelope-from ) id 1mLR9t-0002rr-S8; Wed, 01 Sep 2021 14:24:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 176497.321148; Wed, 01 Sep 2021 14:24:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLR9t-0002rk-Mu; Wed, 01 Sep 2021 14:24:09 +0000 Received: by outflank-mailman (input) for mailman id 176497; Wed, 01 Sep 2021 14:24:08 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLR9s-0002re-FG for xen-devel@lists.xenproject.org; Wed, 01 Sep 2021 14:24:08 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLR9o-0003rO-8c; Wed, 01 Sep 2021 14:24:04 +0000 Received: from [54.239.6.187] (helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1mLR9o-0000BT-1a; Wed, 01 Sep 2021 14:24:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=1BPnIhtExWspVUUxouiBfqJrd9IwX6xVp7qTG38Djw4=; b=dbi/pPqONio3mP7UO1zDHTrSNc puc1wVTvvd7TmQ9EPXVvHkwRMFwAmQeYrMBbhy1T/XQAm/7CAyewfOmheM8bCMrhlxZgqUXVb+pWU UvD5uRdFGZpGK0c7ppS4FmfIXggeI6+c2N52iopJLQjlenmeIcgdQSzlMWgz5hJjcj0o=; Subject: Re: [PATCH] xen/arm: Introduce pmu_access parameter To: Bertrand Marquis Cc: Michal Orzel , "xen-devel@lists.xenproject.org" , Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Stefano Stabellini , Wei Liu , Volodymyr Babchuk References: <20210901124308.31573-1-michal.orzel@arm.com> <599515f0-4b8a-3a71-caea-b17ec27c9123@xen.org> <44B48162-EB44-4295-9629-2D95A40D7232@arm.com> From: Julien Grall Message-ID: <46e36ba5-8b3d-2d43-6297-b92d2654ab72@xen.org> Date: Wed, 1 Sep 2021 15:24:01 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <44B48162-EB44-4295-9629-2D95A40D7232@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit On 01/09/2021 14:10, Bertrand Marquis wrote: > Hi Julien, Hi Bertrand, > >> On 1 Sep 2021, at 13:55, Julien Grall wrote: >> >> Hi, >> >> On 01/09/2021 13:43, Michal Orzel wrote: >>> Introduce new Xen command line parameter called "pmu_access". >>> The default value is "trap": Xen traps PMU accesses. >>> In case of setting pmu_access to "native", Xen does not trap >>> PMU accesses allowing all the guests to access PMU registers. >>> However, guests cannot make use of PMU overflow interrupts as >>> PMU uses PPI which Xen cannot route to guests. >>> This option is only intended for development and testing purposes. >>> Do not use this in production system. >> I am afraid your option is not safe even in development system as a vCPU may move between pCPUs. >> >> However, even if we restricted the use to pinned vCPU *and* dedicated pCPU, I am not convinced that exposing an half backed PMU (the overflow interrupt would not work) to the guest is the right solution. This likely means the guest OS would need to be modified and therefore the usage of this option is fairly limited. >> >> So I think the first steps are: >> 1) Make the PPI work. There was some attempt in the past for it on xen-devel. You could have a look. >> 2) Provide PMU bindings >> >> With that in place, we can discuss how to expose the PMU even if it is unsafe in some conditions. > > With those limitations, using the PMU to monitor the system performances or on some specific use cases is still really useful. > We are using that to do some benchmarks of Xen or of some applications to compare the behaviour to a native system or > analyse the performances of Xen itself (hypercalls,context switch …etc) I understand this is useful for some setup and I am not trying to say we should not have a way to expose the PMU (even unsafely) in upstream. However, I think the option as it stands is too wide (this should be a per domain knob) and we should properly expose the PMU (interrupts, bindings...). > > The steps you are mentioning do make sense but using the PMU without those knowing the limitations is also very useful. Right, this would require a lot more work than what I wrote before. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Sep 01 14:25:25 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Sep 2021 14:25:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.176503.321159 (Exim 4.92) (envelope-from ) id 1mLRB7-0003SQ-6k; Wed, 01 Sep 2021 14:25:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 176503.321159; Wed, 01 Sep 2021 14:25:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLRB7-0003SJ-1w; Wed, 01 Sep 2021 14:25:25 +0000 Received: by outflank-mailman (input) for mailman id 176503; Wed, 01 Sep 2021 14:25:22 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLRB4-0003S6-SA for xen-devel@lists.xenproject.org; Wed, 01 Sep 2021 14:25:22 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 7058c3e0-0b30-11ec-adf6-12813bfff9fa; Wed, 01 Sep 2021 14:25:22 +0000 (UTC) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04lp2055.outbound.protection.outlook.com [104.47.14.55]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-32-x6Wda70zPZ-kkgxYV1AHfg-1; Wed, 01 Sep 2021 16:25:20 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (20.178.127.208) by VI1PR0401MB2333.eurprd04.prod.outlook.com (10.169.133.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19; Wed, 1 Sep 2021 14:25:19 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4478.019; Wed, 1 Sep 2021 14:25:19 +0000 Received: from [10.156.60.236] (37.24.206.209) by AM0P190CA0023.EURP190.PROD.OUTLOOK.COM (2603:10a6:208:190::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Wed, 1 Sep 2021 14:25:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7058c3e0-0b30-11ec-adf6-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1630506321; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7HPcJqXemlh/M+q3GUqr/9ybdIci7HrM7vUhZHsFzCs=; b=jXSpoqUVYZqiwSXr/VF1HIvKiupZnhD50emelEkkorfyOcrCzB7U7508AM5r1VkDscr2Sn Fja6Y9EhtfbgTpnUCE6tV+kqn2HyEZBuTssJ+MQPRfNeUefrYwowh7Ll1NkhHrnyB7zDNf IDUc3kNJzD10hrs+aHMrF9CJzwpbOJU= X-MC-Unique: x6Wda70zPZ-kkgxYV1AHfg-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dks4BD7DFn9qEVxSaOoiPrPtnl9MG6K1lZnD4vLbPzKFVTHsJ/9HghzsSkwApTNu0Z3nEyNtytcYBlfDMm7785xzzVg9ZRvjga673CwOqSiepFJPzbzwkEa7JkKsinoGaolHlb6MMjElfDbnR4COTIMK25mo4M7ohtOfwcN00iuDGuuRu1qKz1UbWLhD+XC0oi8yGyVye3XGmYyHnyQuuLs3dXcOY/ObpSzPp+TO9ppSfk0EfZzISdPK7mZnETimbDwdMzu5gey+e9D4xdFABjhPIrMqCZ+5v4isJ+KoTaB+m+C2sGN0w5NB817Au/NYDQeYgafhSYR5GCaN97zWqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=3Fevk7k48OM6SAmkM3l2HgTjJcLe/LKPJf4QIPKH2os=; b=mnp9xYwr5kj2IKbgCDJsqM5b96f0/McoZqrsfZkfyDSnuF3zvxYhOYx2bjjWTVxLVwc1/gRf8yGyt2fRSLwRRLVsNSl1r9n/P+kJtrIia8htaPApFmDO2pwnuyIT8FUdq4ksnCVbc9eqc9pkDkz41pFpMBIxOgRr46Ef9O26B2plmoPd/tJCZ671t8PqnS5H45Oy4TRuH3ukTbIvYaHfke5Bs5r97D8qHhVH6glrq8tFmDLaOsx21X5SFKA1EAKZsu/EVsba3c2jvhj86C1W53MgsKcdmRnnIY64WpwoijXasQb1HGQpjzaadB/CnmvzgyKB4G4puDZ/XGAddrcnIw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=suse.com; Subject: Re: [PATCH 0/4] x86/PVH: Dom0 building adjustments From: Jan Beulich To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= CC: "xen-devel@lists.xenproject.org" , Andrew Cooper , Wei Liu References: <17c5ce48-11e6-ac97-fa67-294cbb8b79b7@suse.com> Message-ID: Date: Wed, 1 Sep 2021 16:25:17 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: <17c5ce48-11e6-ac97-fa67-294cbb8b79b7@suse.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AM0P190CA0023.EURP190.PROD.OUTLOOK.COM (2603:10a6:208:190::33) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 44a8f791-a8cd-41c7-8231-08d96d54533f X-MS-TrafficTypeDiagnostic: VI1PR0401MB2333: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:3276; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: tsB6AwgsbuRyQ8bEJW2Z/TwBDf/3hhixoo7t3335gPUAmaLzFC/ph0xT5bVdjRdd8UlEZHua+m/KNhnxb8AlxxqjwrJfTJR/KoTBFIqnkfxfGFkhWvxkCx4svY1HVzsQK5497htAnt9kBmOPiWIZwf+K0Fw/NEYST9DZt7o+x34jLXHrD6Puw6avMAezf5QX7+5E0YxlcRszR7mX78182OUISnCLxPnUHlRrCxT+paYhPtsLXUZPKFupA9jAQxdspGFhey/3GLhuNk2T6/GcNSXx1sLFrTFpiJyX9vc4TntlCxA6AwPwnyZ2TmuN3rZ1niCkw+SFCZ8eOT1NJzqHzl+zo8iX1yUBMj7XHdfhH4hUKxrKb/+uIHR6P7RNK6nvP91E4X3xFxStD+GX3Q1QF6PCpAMwFoQReVFbFcrmhZkSk90ZOyS1iAA8jwUke/YIggw1dTKEaq743cn7KKLxzgNjH6F8oh3/xGn9Z4smr5VhX7HIPMKVILWU67Odi/cFyo/Q+kHazl8suqbWX1oEQjpftQp5W6SeTdCzYsW9bj0agcs+zhd/tFLQ9egscFG6AgbgNfHXiLFDpp39f3Wq2IrxcnAMIJI5FnuJZAkScWJxOw0qCTC2Lc8iytMxrAo9Z+njW/XU1M0w0HJlSlkkl5TW2/d+tM3VxUOaoOn4TJZaDFV+0m6o4wqWtxuuuJEdUsk/kIlbFEE3GnQEiZuRYoAD7p8htz/vNiXyrZRL1PF5x0/MGtqA4WjGwbjbwJr5 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(136003)(39860400002)(396003)(366004)(346002)(376002)(54906003)(53546011)(31686004)(956004)(2616005)(16576012)(86362001)(316002)(186003)(31696002)(36756003)(38100700002)(8936002)(8676002)(5660300002)(6486002)(2906002)(83380400001)(4744005)(66946007)(66556008)(66476007)(6916009)(478600001)(4326008)(26005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?fh2bxSI7YJ1P41qfjRRzA7H5A0v6/E7j73CdJvOr1Us0BR/HttGvxElM/KRN?= =?us-ascii?Q?u86BrmXDeOAOdN8ols/w9nZInOvAxiWOJJr7C/AsUOiwXAwkG0TyTHR1LC5k?= =?us-ascii?Q?ErrOSoGBD5EonwYvyiNBCd3HMO0cxmQDrB8ryAO3zYEwVwCq6wk+HVHGy/xb?= =?us-ascii?Q?bDZ5/98LgaaoioRaAPEg4kFEOUuI5q2LvhXHdKwzhob2UtnBk6OMZgmkHn8C?= =?us-ascii?Q?sx7EliUZvp6olGtucIgy68DAqXZNVE8YOEjV/ayJhfdbDLgGeS8LDQbKir8y?= =?us-ascii?Q?DdTYmwaTpb29OD4vsaea35Qg2iSfXB4ainD4iMX5AHhiLjGiXuTjOyUhyM/4?= =?us-ascii?Q?sdEBhjdkl61d3xNlE4Ab51Qy/qdF6PvZOHL0f8Y/6cfIiMQJf1KUm9ZcnYit?= =?us-ascii?Q?kHDWQ0EUcLkv3Hp+inbhR4zGbJKpsEnauQS0X6Qucoc94PW4pKzarxJbqj9E?= =?us-ascii?Q?BhM45tkM1DRqw0NYlygf35htmMLi6TXEXXA2ntBrX5R7BOppL23VufJqGfoX?= =?us-ascii?Q?gjlIQr3RMH2Y2zr0mTiJETL4mFnjEgTPkEZZ2mcx9fKCuXFgyDQCzl9KXiZg?= =?us-ascii?Q?LKOG8AfHLnNRLoJ5KtPZmsgOjVheUnmfckYLe/xyPrmyBoBXo6TlCpq1mOx5?= =?us-ascii?Q?DQ61U/2GvXKq+bFQwZBXvRMQyEWBbJF/klh6MH03AW0/IuD1lebcTk5Cpa0n?= =?us-ascii?Q?yxHAZ/Srwzme5uFZh5W46JDfVn+9N6lshTOgeK6PSH8IzBDsyP0zSLFiRCWr?= =?us-ascii?Q?nk9HukzGoyFuW3y3So/HeerFeVXG3cOcHoeEUwOKCTnfQq1bxKmNms7j5Awy?= =?us-ascii?Q?h3Fz8wVHUEYKjSCmuKCh8URB8s/8z42JTiJfQLRZZNV3FKWUPksqlE/jGIkl?= =?us-ascii?Q?hwiUHcpo7C9eO1JvjYMsji3nO+266AJUD+MKYBHdiF+OIvRj4ZjmAKDFNdxI?= =?us-ascii?Q?u0Bp+xNcALJDz8+RA+mLSJCejRjfrSaKWu/hlgbw7U6JK4bY56lcs+CMqgaI?= =?us-ascii?Q?1AiBu/7KwDRdH3YgRtADWZArQePyI1IYFj4vq4FIpB9Z+Tx6CYi/cdSP72CT?= =?us-ascii?Q?jPrrwhH05fleqm4g9ajnsx+d479tgLGoN5sxAGoPdkEo4KD+XJAPPsfZs3a8?= =?us-ascii?Q?olWsijWqJqAii/pLJ6+xvkfiJ2XMQCk+omRAVE2YhlWnkiSbkcs/gV+yUUL8?= =?us-ascii?Q?ew8uqwl2zS2APcfFS3ty18JgrblzBV2tSCUKP5NAdMv184UviIgNZqyCJgf3?= =?us-ascii?Q?TGAzKTP8j2QzT6v8pieCj8WMjuQfvf8yyqG2tJEg+GyZrg8s/4/3pBA+/za9?= =?us-ascii?Q?RhWU/nlVCgEbCk5XKULfE5Ue?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 44a8f791-a8cd-41c7-8231-08d96d54533f X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Sep 2021 14:25:19.1896 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: hk+dvaco5348to9K5jyYM2xGZhSzqoa3IxKpAhk1eo3cvUCrYHtTDFJ4BUGgG8RvnTfVNejh+KGc1fLOl2l2kQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2333 On 01.09.2021 16:19, Jan Beulich wrote: > On 01.09.2021 15:56, Roger Pau Monn=C3=A9 wrote: >> Do you have iommu debug/verbose enabled to catch iommu faults? >=20 > I'll try to remember to check that, but since Linux hasn't > brought up APs yet I don't think there's any device activity > just yet. No IOMMU faults, as expected. Jan From xen-devel-bounces@lists.xenproject.org Wed Sep 01 14:34:32 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Sep 2021 14:34:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.176509.321169 (Exim 4.92) (envelope-from ) id 1mLRJm-00059I-1z; Wed, 01 Sep 2021 14:34:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 176509.321169; Wed, 01 Sep 2021 14:34:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLRJl-00059B-Uy; Wed, 01 Sep 2021 14:34:21 +0000 Received: by outflank-mailman (input) for mailman id 176509; Wed, 01 Sep 2021 14:34:21 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLRJl-000591-6m; Wed, 01 Sep 2021 14:34:21 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLRJk-00041t-WA; Wed, 01 Sep 2021 14:34:21 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLRJk-0008Ry-PU; Wed, 01 Sep 2021 14:34:20 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mLRJk-0002Fk-P1; Wed, 01 Sep 2021 14:34:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Message-Id:Subject:To; bh=EJjEFxAXfiM72/PLrvPX3UAZ6GtaE4crts9y9ZHbeqY=; b=cBtgGRiRAAfyYYjwqWHuYbqWk2 Vcy7kNDiCCTLTDSMFwkAK4lY+uMUv7wvca1QS3tX6bXpRccAXe8llCMFHoIpnZfIsO/WrgwHsTAJA 4TQ11We5TETV/VBzsIFHrphZKbrPf04Z2ATOwf3I883slf+jB0CXfI2jiy3Fnrih36zQ=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Subject: [ovmf bisection] complete build-amd64 Message-Id: From: osstest service owner Date: Wed, 01 Sep 2021 14:34:20 +0000 branch xen-unstable xenbranch xen-unstable job build-amd64 testid xen-build Tree: ovmf https://github.com/tianocore/edk2.git Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git Tree: qemuu git://xenbits.xen.org/qemu-xen.git Tree: seabios git://xenbits.xen.org/osstest/seabios.git Tree: xen git://xenbits.xen.org/xen.git *** Found and reproduced problem changeset *** Bug is in tree: ovmf https://github.com/tianocore/edk2.git Bug introduced: 9f3eda177a4b2d4a33ff1b0307cad42906396562 Bug not present: 5b5f10d7465004e3e40ec1f50a3b490b4db595e7 Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/164710/ commit 9f3eda177a4b2d4a33ff1b0307cad42906396562 Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:29:48 2021 +0800 OvmfPkg/OvmfXen: add QemuKernelLoaderFsDxe Without QemuKernelLoaderFsDxe, QemuLoadKernelImage() couldn't download the kernel, initrd, and kernel command line from QEMU's fw_cfg. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3574 Signed-off-by: Gary Lin Acked-by: Anthony PERARD Reviewed-by: Philippe Mathieu-Daude Reviewed-by: Gerd Hoffmann Tested-by: Jim Fehlig For bisection revision-tuple graph see: http://logs.test-lab.xenproject.org/osstest/results/bisect/ovmf/build-amd64.xen-build.html Revision IDs in each graph node refer, respectively, to the Trees above. ---------------------------------------- Running cs-bisection-step --graph-out=/home/logs/results/bisect/ovmf/build-amd64.xen-build --summary-out=tmp/164710.bisection-summary --basis-template=164674 --blessings=real,real-bisect,real-retry ovmf build-amd64 xen-build Searching for failure / basis pass: 164695 fail [host=himrod1] / 164674 [host=himrod2] 164630 [host=himrod2] 164556 ok. Failure / basis pass flights: 164695 / 164556 (tree with no url: minios) Tree: ovmf https://github.com/tianocore/edk2.git Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git Tree: qemuu git://xenbits.xen.org/qemu-xen.git Tree: seabios git://xenbits.xen.org/osstest/seabios.git Tree: xen git://xenbits.xen.org/xen.git Latest b170806518c1e414939c8b085866544814e1ce8e 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 136c34c9bc4179dc64b15b2bb5f0c54ca4ddf823 54082c81d96028ba8c76fbe6784085cf1df76b20 a931e8e64af07bd333a31f3b71a3f8f3e7910857 Basis pass a82bad9730178a1e3a67c9bfc83412b87a8ad734 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 136c34c9bc4179dc64b15b2bb5f0c54ca4ddf823 54082c81d96028ba8c76fbe6784085cf1df76b20 a931e8e64af07bd333a31f3b71a3f8f3e7910857 Generating revisions with ./adhoc-revtuple-generator https://github.com/tianocore/edk2.git#a82bad9730178a1e3a67c9bfc83412b87a8ad734-b170806518c1e414939c8b085866544814e1ce8e git://xenbits.xen.org/qemu-xen-traditional.git#3d273dd05e51e5a1ffba3d98c7437ee84e8f8764-3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 git://xenbits.xen.org/qemu-xen.git#136c34c9bc4179dc64b15b2bb5f0c54ca4ddf823-136c34c9bc4179dc64b15b2bb5f0c54ca4ddf823 git://xenbits.xen.org/osstest/seabios.git#54082c81d96028ba8c76fbe6784085cf1df76b\ 20-54082c81d96028ba8c76fbe6784085cf1df76b20 git://xenbits.xen.org/xen.git#a931e8e64af07bd333a31f3b71a3f8f3e7910857-a931e8e64af07bd333a31f3b71a3f8f3e7910857 Loaded 5001 nodes in revision graph Searching for test results: 164556 pass a82bad9730178a1e3a67c9bfc83412b87a8ad734 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 136c34c9bc4179dc64b15b2bb5f0c54ca4ddf823 54082c81d96028ba8c76fbe6784085cf1df76b20 a931e8e64af07bd333a31f3b71a3f8f3e7910857 164630 [host=himrod2] 164674 [host=himrod2] 164686 fail 9f3eda177a4b2d4a33ff1b0307cad42906396562 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 136c34c9bc4179dc64b15b2bb5f0c54ca4ddf823 54082c81d96028ba8c76fbe6784085cf1df76b20 a931e8e64af07bd333a31f3b71a3f8f3e7910857 164694 pass a82bad9730178a1e3a67c9bfc83412b87a8ad734 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 136c34c9bc4179dc64b15b2bb5f0c54ca4ddf823 54082c81d96028ba8c76fbe6784085cf1df76b20 a931e8e64af07bd333a31f3b71a3f8f3e7910857 164697 fail 9f3eda177a4b2d4a33ff1b0307cad42906396562 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 136c34c9bc4179dc64b15b2bb5f0c54ca4ddf823 54082c81d96028ba8c76fbe6784085cf1df76b20 a931e8e64af07bd333a31f3b71a3f8f3e7910857 164699 pass b04453d36bd87735aadd29adbefce8d147f18a35 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 136c34c9bc4179dc64b15b2bb5f0c54ca4ddf823 54082c81d96028ba8c76fbe6784085cf1df76b20 a931e8e64af07bd333a31f3b71a3f8f3e7910857 164700 pass cae735f61328d64e2e8991036707b9e78c0f5f63 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 136c34c9bc4179dc64b15b2bb5f0c54ca4ddf823 54082c81d96028ba8c76fbe6784085cf1df76b20 a931e8e64af07bd333a31f3b71a3f8f3e7910857 164701 pass 28152333bccb778b62e6e97446b28bfa0e92ef82 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 136c34c9bc4179dc64b15b2bb5f0c54ca4ddf823 54082c81d96028ba8c76fbe6784085cf1df76b20 a931e8e64af07bd333a31f3b71a3f8f3e7910857 164695 fail b170806518c1e414939c8b085866544814e1ce8e 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 136c34c9bc4179dc64b15b2bb5f0c54ca4ddf823 54082c81d96028ba8c76fbe6784085cf1df76b20 a931e8e64af07bd333a31f3b71a3f8f3e7910857 164702 pass 52e2dabc0f8d3af09c213072ce8ba734302f585d 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 136c34c9bc4179dc64b15b2bb5f0c54ca4ddf823 54082c81d96028ba8c76fbe6784085cf1df76b20 a931e8e64af07bd333a31f3b71a3f8f3e7910857 164703 pass 5b5f10d7465004e3e40ec1f50a3b490b4db595e7 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 136c34c9bc4179dc64b15b2bb5f0c54ca4ddf823 54082c81d96028ba8c76fbe6784085cf1df76b20 a931e8e64af07bd333a31f3b71a3f8f3e7910857 164705 fail 9f3eda177a4b2d4a33ff1b0307cad42906396562 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 136c34c9bc4179dc64b15b2bb5f0c54ca4ddf823 54082c81d96028ba8c76fbe6784085cf1df76b20 a931e8e64af07bd333a31f3b71a3f8f3e7910857 164706 pass 5b5f10d7465004e3e40ec1f50a3b490b4db595e7 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 136c34c9bc4179dc64b15b2bb5f0c54ca4ddf823 54082c81d96028ba8c76fbe6784085cf1df76b20 a931e8e64af07bd333a31f3b71a3f8f3e7910857 164707 fail 9f3eda177a4b2d4a33ff1b0307cad42906396562 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 136c34c9bc4179dc64b15b2bb5f0c54ca4ddf823 54082c81d96028ba8c76fbe6784085cf1df76b20 a931e8e64af07bd333a31f3b71a3f8f3e7910857 164708 pass 5b5f10d7465004e3e40ec1f50a3b490b4db595e7 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 136c34c9bc4179dc64b15b2bb5f0c54ca4ddf823 54082c81d96028ba8c76fbe6784085cf1df76b20 a931e8e64af07bd333a31f3b71a3f8f3e7910857 164710 fail 9f3eda177a4b2d4a33ff1b0307cad42906396562 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 136c34c9bc4179dc64b15b2bb5f0c54ca4ddf823 54082c81d96028ba8c76fbe6784085cf1df76b20 a931e8e64af07bd333a31f3b71a3f8f3e7910857 Searching for interesting versions Result found: flight 164556 (pass), for basis pass For basis failure, parent search stopping at 5b5f10d7465004e3e40ec1f50a3b490b4db595e7 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 136c34c9bc4179dc64b15b2bb5f0c54ca4ddf823 54082c81d96028ba8c76fbe6784085cf1df76b20 a931e8e64af07bd333a31f3b71a3f8f3e7910857, results HASH(0x561ed27d4058) HASH(0x561ed27e6cf0) HASH(0x561ed2848548) For basis failure, parent search stopping at 52e2dabc0f8d3af09c213072ce8ba734302f585d 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 136c34c9bc4179dc64b15b2bb5f0c54ca4ddf823 54082c81d\ 96028ba8c76fbe6784085cf1df76b20 a931e8e64af07bd333a31f3b71a3f8f3e7910857, results HASH(0x561ed27dc0a0) For basis failure, parent search stopping at 28152333bccb778b62e6e97446b28bfa0e92ef82 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 136c34c9bc4179dc64b15b2bb5f0c54ca4ddf823 54082c81d96028ba8c76fbe6784085cf1df76b20 a931e8e64af07bd333a31f3b71a3f8f3e7910857, results HASH(0x561ed27db5f8) For basis failure, parent search stopping at cae735f61328d64e2e8991036707b9e78c0f5f63 3d273dd05e51e5a1ffba3d98c7437ee\ 84e8f8764 136c34c9bc4179dc64b15b2bb5f0c54ca4ddf823 54082c81d96028ba8c76fbe6784085cf1df76b20 a931e8e64af07bd333a31f3b71a3f8f3e7910857, results HASH(0x561ed27d95f0) For basis failure, parent search stopping at b04453d36bd87735aadd29adbefce8d147f18a35 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 136c34c9bc4179dc64b15b2bb5f0c54ca4ddf823 54082c81d96028ba8c76fbe6784085cf1df76b20 a931e8e64af07bd333a31f3b71a3f8f3e7910857, results HASH(0x561ed27cf120) For basis failure, parent search stopping at a82bad973017\ 8a1e3a67c9bfc83412b87a8ad734 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 136c34c9bc4179dc64b15b2bb5f0c54ca4ddf823 54082c81d96028ba8c76fbe6784085cf1df76b20 a931e8e64af07bd333a31f3b71a3f8f3e7910857, results HASH(0x561ed27cd298) HASH(0x561ed27c4440) Result found: flight 164686 (fail), for basis failure (at ancestor ~5000) Repro found: flight 164694 (pass), for basis pass Repro found: flight 164695 (fail), for basis failure 0 revisions at 5b5f10d7465004e3e40ec1f50a3b490b4db595e7 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 136c34c9bc4179dc64b15b2bb5f0c54ca4ddf823 54082c81d96028ba8c76fbe6784085cf1df76b20 a931e8e64af07bd333a31f3b71a3f8f3e7910857 No revisions left to test, checking graph state. Result found: flight 164703 (pass), for last pass Result found: flight 164705 (fail), for first failure Repro found: flight 164706 (pass), for last pass Repro found: flight 164707 (fail), for first failure Repro found: flight 164708 (pass), for last pass Repro found: flight 164710 (fail), for first failure *** Found and reproduced problem changeset *** Bug is in tree: ovmf https://github.com/tianocore/edk2.git Bug introduced: 9f3eda177a4b2d4a33ff1b0307cad42906396562 Bug not present: 5b5f10d7465004e3e40ec1f50a3b490b4db595e7 Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/164710/ commit 9f3eda177a4b2d4a33ff1b0307cad42906396562 Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:29:48 2021 +0800 OvmfPkg/OvmfXen: add QemuKernelLoaderFsDxe Without QemuKernelLoaderFsDxe, QemuLoadKernelImage() couldn't download the kernel, initrd, and kernel command line from QEMU's fw_cfg. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3574 Signed-off-by: Gary Lin Acked-by: Anthony PERARD Reviewed-by: Philippe Mathieu-Daude Reviewed-by: Gerd Hoffmann Tested-by: Jim Fehlig Revision graph left in /home/logs/results/bisect/ovmf/build-amd64.xen-build.{dot,ps,png,html,svg}. ---------------------------------------- 164710: tolerable ALL FAIL flight 164710 ovmf real-bisect [real] http://logs.test-lab.xenproject.org/osstest/logs/164710/ Failures :-/ but no regressions. Tests which did not succeed, including tests which could not be run: build-amd64 6 xen-build fail baseline untested jobs: build-amd64 fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary From xen-devel-bounces@lists.xenproject.org Wed Sep 01 15:06:39 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Sep 2021 15:06:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.176520.321193 (Exim 4.92) (envelope-from ) id 1mLRob-0000cB-Qq; Wed, 01 Sep 2021 15:06:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 176520.321193; Wed, 01 Sep 2021 15:06:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLRob-0000c4-No; Wed, 01 Sep 2021 15:06:13 +0000 Received: by outflank-mailman (input) for mailman id 176520; Wed, 01 Sep 2021 15:06:12 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLRoa-0000bt-9C for xen-devel@lists.xenproject.org; Wed, 01 Sep 2021 15:06:12 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 262e4026-ba4f-4d09-9b19-2a6765503b85; Wed, 01 Sep 2021 15:06:10 +0000 (UTC) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05lp2105.outbound.protection.outlook.com [104.47.18.105]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-12-nk--lYA9MjSxirvyqLSAYA-1; Wed, 01 Sep 2021 17:06:08 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR04MB6864.eurprd04.prod.outlook.com (2603:10a6:803:138::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19; Wed, 1 Sep 2021 15:06:05 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4478.019; Wed, 1 Sep 2021 15:06:05 +0000 Received: from [10.156.60.236] (37.24.206.209) by PR3P191CA0021.EURP191.PROD.OUTLOOK.COM (2603:10a6:102:54::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.23 via Frontend Transport; Wed, 1 Sep 2021 15:06:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 262e4026-ba4f-4d09-9b19-2a6765503b85 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1630508769; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lIEEVx3pKZhCJQYNuhuiguKiqn5e+HYCDbQkL7NIP7I=; b=f2TUGBMhWp5o1bkG8YjVQQMGOLV4R5wK1HPb4h1/2FtWriMEVctaEuka12XaVthvAc+qfz 4k4vVjbUaXh0Zv/UspIiAOwn5ZpWyGiHMK9zOCecQXh0AYIa4qdilQXr/grrJzkqOGwaIH Mihr6SOwi0PQeva8ktoECo2FT+T7siY= X-MC-Unique: nk--lYA9MjSxirvyqLSAYA-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lsVp0pnb5svi4vgRWnekEUj0FYNzoQMJwN75M/1z6MpcacJcx7kL4pRWezLC4CKAnWU9HnRhpNQWDTd3u86ubd6ZSf+I/n/GF6x6/Wdobg5ihJXdXyA4AumO2jINxDgYRAdr+ELRFxxLY734u8XLvsVTKjL8nIz5lFe+90TYUWaW6YdP4ZP05LNe7iikRMl33vLqH/Pv1/8S1zr0FhrkNGI/j5sWyqCW724a68IxuL5aY4GPppOGC7yxMp+DfRBlp3YAUDhCSwZHWMWQJ3r3FlzdUX6HtFe+8ICoHVAbiLlSL2AegBgxXHzsxFesoR0YIgRl42J99blIiwVWu5sneg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=lIEEVx3pKZhCJQYNuhuiguKiqn5e+HYCDbQkL7NIP7I=; b=EOAXveL+MZ9jEWbSSGxZlMdQeEGg7xTsr/lkhokGk3jGmYC8srUbwLdRj5/m6vYPV5tXcgCyY3z4Y/xmSIlXrgb9V7wSaq9sml0uCXmLift2Z/CRuAWT/9yr3uDCBwPfHl6q8ePsiCDpSWGcUbgMziSm8UiG7WcCZPwPRotoI8hKVjtnUPnFIPZoOlsQxJwWIgIaVDrxsa/3/oMSwthT+uPfMyosgn4eKn7WqvLzQF0bFSHHKI7560CPnCVW9FFv0vm9CdpX3B3Dpy2W+7z8/9/brDT9+g9f2NnXSR90CNPUOzzcmOpMM6iAQgHOQSSoCCE35bw2EBD/NokJ+CaW/A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: citrix.com; dkim=none (message not signed) header.d=none;citrix.com; dmarc=none action=none header.from=suse.com; Subject: Re: [PATCH 0/4] x86/PVH: Dom0 building adjustments From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: Message-ID: <1d600035-851a-190a-f744-8cd7b2d887fd@suse.com> Date: Wed, 1 Sep 2021 17:06:03 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PR3P191CA0021.EURP191.PROD.OUTLOOK.COM (2603:10a6:102:54::26) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 40e84511-4ea7-4a6d-76af-08d96d5a056f X-MS-TrafficTypeDiagnostic: VI1PR04MB6864: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: K5D4Y5B1MkK36YlI2zLhx1Pv7URAjtQSDEx+DoruwOBOdwRXnbIJ4UMDsrpn1eWvZXouSy4rRN7H9t5ATr58kGRNm/nivRrbUnThmavzvG0KiOu8X6pUe+xLIV0keyTwKI+IiIh0WPlP7bv8z+U9HDODl2KpPYy//f9WUFX8bcvVFXc+Ju8IiFkOVkKc9V1ttNv/730rY0fck0RvCiNMnLrf022278zXxMtnxs0/Vkd3vXiZcG9sdhm2M2Pg5pQUsdJTnGrrEQoSpyXN24L1CPzk7YJhoW8AKphJExyyk6n3EXhpc1302NcN5ZOdd9hzgUPyfJ21QG/+kN9DRFswo25rw5kXTmukyaUVEjSMkOs68kP//9MzGizzN66G9bOa3mDpZ+yCo3P701OiF2yFFG+kn5tfo8wkhHMMniCKwFsqJsnpDUxRdckANFaAHmKJVG119Igz7WV5MzXAw+pylOkssEJxBIAzSakB1cJ7g4+ecrfj9H1D2Fr5KyzPhz4p+ZyNeXcMGVoeENrXH+dOKXFqwDnSu9vXsYt9aq6KdLOsVb/zcJfKF2VLYeYx6bT0RicCCwq+aj3/7RGmmokNXt78V/dIW3VAasW+WACmfitME6lfHRGJPmwqxT3hm/5QlkJOnjNoJIyNrWsa8gFL/pr4ixvHCv0/Hsri+66KzCgqNCqZcc+tRHZv2XK9Z0sMiuvTXnYr3v+la6A+wZDHG+SraUsu4XUmGLGVVLttEs0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(54906003)(53546011)(31686004)(16576012)(2616005)(956004)(86362001)(316002)(8936002)(186003)(31696002)(36756003)(38100700002)(8676002)(5660300002)(6486002)(2906002)(83380400001)(66946007)(66556008)(66476007)(6916009)(4326008)(26005)(508600001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NHhtNmRTTmtQcGhBMTZ3MTRndWQvcjBQQ3doWWhIWmZ2bzM4cUg2ODBMQ0t1?= =?utf-8?B?OXQzaEVvOG5uc0syMXNjY1Fzb2xxOHNpdml2cm1jdWw2UUNYcTdGcmZiWngr?= =?utf-8?B?UU9mckRNcnQwVHVRMFhHNHgxb2lCOVZKZlBYanRWL1FMVDlvUHhGZ0VzRFV5?= =?utf-8?B?T25jMjd4Rm5sdStSSGV4d2lSbEhMYjlRMlZoTTJKdFRmSzFPTnNoTWpIcEEx?= =?utf-8?B?bXI0RGZYYVU1YWF2eEhQN3dKUkQ2T2VPN0lUYkMxYWs5T2gvK1BrelNOM1dl?= =?utf-8?B?SU5lQmxIOHhjekhCZXdFL0lwby8wTDJhbVEwUDZIaDR2QWVnVkpVbGZvQkxF?= =?utf-8?B?LzNlN1VVNTJpK01WcUJIQ1dSWnVyVG9MNkdKYzhGUTdNKzVVN1dDV1lUaTh3?= =?utf-8?B?Rzl3My9Ycnp6RlRGcFZXazlxYzBMVEV4ei9MaG1BamIyUFB1WjM5a2JtSldE?= =?utf-8?B?ZlhrQVRBS013UG1WYTVEWUNnWjQ4VmNUSGFaa2xvN3Y1MGhySlNwUXZZaTJx?= =?utf-8?B?cVhBbEc1OG5tdzN5Mmptd00yN0ZBYzlCWU1ZM2JxcFRqcXRucWZXTno2VDMx?= =?utf-8?B?cllhZzcwVzcvZ3lhZUVQQTIzTm5UUktWMjIyd3pkMWQ2MjZpZ3pMejNLT3N6?= =?utf-8?B?YVRrb2VRcWZoSkZWcVBtbExhVVc0aE52WVN2ZEhTdk1qbDFkdXR2VUY1b1Rw?= =?utf-8?B?clpRY3pTUTZPVG5sWmNNdTY1TW5wTmFlNDJJWi8xQks3Q01Id29mTGh4ZHUy?= =?utf-8?B?K3ZFUkxuYnlSNzArQUdzazNVRStCWFRpZzdjbWJIcGxPTUk5QS9EdmJCeUJY?= =?utf-8?B?YndXTjAwS0FLQzMwOFNienpLV29hWThKSk8wNmlCM0pQUDNQS3RKbnVzV1U5?= =?utf-8?B?bXNRTm16T3hxKzU3OGV5ditHaE1BSDVUb251N0RYUHNSQ1dKSXUrU04zdVVE?= =?utf-8?B?MUMzalNUNVkvaDNQbHk3WDJ1Uk95UWhTSzVjcncvNUp4QVRTYzhzWmJ6QU9V?= =?utf-8?B?OE0ybnNrSGRKSE8yTzJ5Tm1YTHIyOVBIZFNhakNnMks2ZWpnV2pySDE1VVUx?= =?utf-8?B?WFlvd0VCZ0JxV3RUS2VrYk1yV0VUNDNObGFoRDlZV3I0L2dRTmRkQWdQSEp5?= =?utf-8?B?clo3TXZpbTdjc08vRmhvTzNMR0ZNUzlzUmFRY0FYUDFpeVp2TEFUc0ZIYys0?= =?utf-8?B?V0pFbGpQRnQwSVVkaEdTZkRhUERmaTZlR01waVVLYkRZN1lkM05RTGcwWjBB?= =?utf-8?B?U1ZBa1BYTDRvNG0wV2hHNkxZYXRoenpaQWE2QWR2RW1QSGpoNmptekJhbGNx?= =?utf-8?B?NnJueVdHam1lTW9TNnVYVFljT2tPTUJhemJKQWJuRFlTajVIekVyU1JnczFT?= =?utf-8?B?YmQxOWtWVnBSZlNiRGJSUGtGRjhUZnJBeHVKUmlVOTdiZk9QRlRtTVJNREly?= =?utf-8?B?TXdrQTlxNWxIc2pVaUo2ZXMxcG04NEthMlJMbmhBcThxZWREbDhTRDAza280?= =?utf-8?B?QzNUVzlZVVl6cUI3bGpLcEFZanhWZ1VILytYMDhlaXRtQjVYb2I3QzJFai94?= =?utf-8?B?K3ZtQk1zTVo1ZGxKb2E5RnQwWEtrWERrdmFZRmpxdXgrbWY5a1JUQy8rTmhu?= =?utf-8?B?NFR4OG1ucVJNNnRQUVVuRVd4eGNqck1GbmtVcXhPa0JiQmFVVWtBckE1bTM4?= =?utf-8?B?TmgxbHhxSE4xM3NaNXQ5UEd5ZDlqbVdaMS9zdjZQa3Q3bURTVUVEd1IvZi9Z?= =?utf-8?Q?czvYt1qGIbQtBQSiKbcoixduH+oFEPuT6XCuFTC?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 40e84511-4ea7-4a6d-76af-08d96d5a056f X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Sep 2021 15:06:05.7060 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: FaEUpYWZx21VHKcv6/9vgIzW1oM5VHgGaLwYMyf0P17JPP5I9RIlq0rziLDz5sb1LRrAlVXl+Ea5/VO9RaeuAg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6864 On 30.08.2021 15:01, Jan Beulich wrote: > The code building PVH Dom0 made use of sequences of P2M changes > which are disallowed as of XSA-378. First of all population of the > first Mb of memory needs to be redone. Then, largely as a > workaround, checking introduced by XSA-378 needs to be slightly > relaxed. > > Note that with these adjustments I get Dom0 to start booting on my > development system, but the Dom0 kernel then gets stuck. Since it > was the first time for me to try PVH Dom0 in this context (see > below for why I was hesitant), I cannot tell yet whether this is > due further fallout from the XSA, or some further unrelated > problem. Dom0's BSP is in VPF_blocked state while all APs are > still in VPF_down. The '0' debug key, unhelpfully, doesn't produce > any output, so it's non-trivial to check whether (like PV likes to > do) Dom0 has panic()ed without leaving any (visible) output. Having made '0' work at least partly, I can now see that Dom0's vCPU0 enters its idle loop after having gone through all normal initialization. Clearly certain things must not have worked as intended (no APs booted, no drivers loaded afaict), but I'm having a hard time seeing how to find out what that might be when there's no output at all. PV Dom0 does not require any special command line option to do output to both the VGA console and through hvc_xen (making its output also go to the serial log) - is this perhaps different for PVH? I couldn't find anything under docs/ ... Jan From xen-devel-bounces@lists.xenproject.org Wed Sep 01 15:24:58 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Sep 2021 15:24:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.176530.321216 (Exim 4.92) (envelope-from ) id 1mLS6H-0003M7-EH; Wed, 01 Sep 2021 15:24:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 176530.321216; Wed, 01 Sep 2021 15:24:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLS6H-0003M0-BC; Wed, 01 Sep 2021 15:24:29 +0000 Received: by outflank-mailman (input) for mailman id 176530; Wed, 01 Sep 2021 15:24:27 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLS6F-0003Lu-E9 for xen-devel@lists.xenproject.org; Wed, 01 Sep 2021 15:24:27 +0000 Received: from smtp-out1.suse.de (unknown [195.135.220.28]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id b053ab93-0b38-11ec-adfd-12813bfff9fa; Wed, 01 Sep 2021 15:24:26 +0000 (UTC) Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 998982258A; Wed, 1 Sep 2021 15:24:25 +0000 (UTC) Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap1.suse-dmz.suse.de (Postfix) with ESMTPS id 6C02B13AD8; Wed, 1 Sep 2021 15:24:25 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap1.suse-dmz.suse.de with ESMTPSA id icDXGCmbL2E9fgAAGKfGzw (envelope-from ); Wed, 01 Sep 2021 15:24:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b053ab93-0b38-11ec-adfd-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1630509865; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=UDNb358/nQzDG8jtYlhrBrmnU7HIB/SQi6GDbLNHHRM=; b=N+CdnPNdkGF2+88rmtd5N9EvrgQi+3UcsW1BWTu7wpNt7Yi66kVZceRekPvc7iZnVC1GA0 OVXfUNpIGYs599vTyrN3ucXATmUeBRIOLVjJCcZ5CXFXBxCiSi5RFxI9amFaOyY+3hQE3N R6tDOJ0C2lMQhPXm2YLrSdjj0Gff31A= Subject: Re: [PATCH 0/4] x86/PVH: Dom0 building adjustments To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <1d600035-851a-190a-f744-8cd7b2d887fd@suse.com> From: Juergen Gross Message-ID: <02ebe247-6891-dbdf-82f7-5b33b5a08dd5@suse.com> Date: Wed, 1 Sep 2021 17:24:24 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <1d600035-851a-190a-f744-8cd7b2d887fd@suse.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Iqbl49u9DNzZ0n75ACpqzJ0tOW9ot3wUF" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Iqbl49u9DNzZ0n75ACpqzJ0tOW9ot3wUF Content-Type: multipart/mixed; boundary="KfmP4bymJzv4KKJycYhWi0mz7a5vFdZ3t"; protected-headers="v1" From: Juergen Gross To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Message-ID: <02ebe247-6891-dbdf-82f7-5b33b5a08dd5@suse.com> Subject: Re: [PATCH 0/4] x86/PVH: Dom0 building adjustments References: <1d600035-851a-190a-f744-8cd7b2d887fd@suse.com> In-Reply-To: <1d600035-851a-190a-f744-8cd7b2d887fd@suse.com> --KfmP4bymJzv4KKJycYhWi0mz7a5vFdZ3t Content-Type: multipart/mixed; boundary="------------A9357959A655AB520B15A2F3" Content-Language: en-US This is a multi-part message in MIME format. --------------A9357959A655AB520B15A2F3 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 01.09.21 17:06, Jan Beulich wrote: > On 30.08.2021 15:01, Jan Beulich wrote: >> The code building PVH Dom0 made use of sequences of P2M changes >> which are disallowed as of XSA-378. First of all population of the >> first Mb of memory needs to be redone. Then, largely as a >> workaround, checking introduced by XSA-378 needs to be slightly >> relaxed. >> >> Note that with these adjustments I get Dom0 to start booting on my >> development system, but the Dom0 kernel then gets stuck. Since it >> was the first time for me to try PVH Dom0 in this context (see >> below for why I was hesitant), I cannot tell yet whether this is >> due further fallout from the XSA, or some further unrelated >> problem. Dom0's BSP is in VPF_blocked state while all APs are >> still in VPF_down. The '0' debug key, unhelpfully, doesn't produce >> any output, so it's non-trivial to check whether (like PV likes to >> do) Dom0 has panic()ed without leaving any (visible) output. >=20 > Having made '0' work at least partly, I can now see that Dom0's > vCPU0 enters its idle loop after having gone through all normal > initialization. Clearly certain things must not have worked as > intended (no APs booted, no drivers loaded afaict), but I'm > having a hard time seeing how to find out what that might be > when there's no output at all. PV Dom0 does not require any > special command line option to do output to both the VGA console > and through hvc_xen (making its output also go to the serial > log) - is this perhaps different for PVH? I couldn't find > anything under docs/ ... Did you add earlyprintk=3Dxen to the dom0 boot parameters? Juergen --------------A9357959A655AB520B15A2F3 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Transfer-Encoding: quoted-printable Content-Description: OpenPGP public key Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy= cWx w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O= f8Z d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y= 9bf IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq= G7/ 377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR= 3Jv c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA= QIe AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT= hpw dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0= MbD 1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv= oPH Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v= 5QL +qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ= 2Vu IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC= QoL BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr= Wf0 teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC= /nu AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh= ITT d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm= XBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz= 80h SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC= AcD AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn= FOX gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1= jnD kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0= N51 N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l= otu fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1= tqS EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA= hsD BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3= g3O ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5= dM7 wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5= D+j LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm= V2x AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N= Eaw QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW= nHI s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR= wgn BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV= bVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk= pEd IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA= QAB wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw= Tbe 8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1= vJz Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8= VGi wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW= svi uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX= zXs ZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------A9357959A655AB520B15A2F3-- --KfmP4bymJzv4KKJycYhWi0mz7a5vFdZ3t-- --Iqbl49u9DNzZ0n75ACpqzJ0tOW9ot3wUF Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmEvmygFAwAAAAAACgkQsN6d1ii/Ey+O eQf+ImG1ACU1xjQmOG9RvSEfIFi9B0Dbp26QVsEYmvhmAKTV9xgLXHzrAj/vno+jidq92Lujyr7x wOXZRL1mxIuNnlK+ESrf54eAAG4r9BP8/w8DB+JDcbBNsHAsvzl5Xz2Pc5CImjCWoccoWShEAykD nqjpwYNraR75Z1m6RRbZ1F8G11UR7lunu2RCCZZPfmDCfwtFAWvMkiU2ijrk1vEYa6tyGQ8UWxFu x6KU0F032xtJeGfNbWh5M8YkYjGxn+RaP4k2kHags0KS7oH9T0vQBBNelRzzEgC69JkEpq4LsHUm Lw4wgTZ0Ig288JVWDHk2fY3Rz6Jy9f0pFX1GuGWU2w== =2MfS -----END PGP SIGNATURE----- --Iqbl49u9DNzZ0n75ACpqzJ0tOW9ot3wUF-- From xen-devel-bounces@lists.xenproject.org Wed Sep 01 15:52:25 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Sep 2021 15:52:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.176537.321227 (Exim 4.92) (envelope-from ) id 1mLSWx-00075i-Md; Wed, 01 Sep 2021 15:52:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 176537.321227; Wed, 01 Sep 2021 15:52:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLSWx-00075b-JX; Wed, 01 Sep 2021 15:52:03 +0000 Received: by outflank-mailman (input) for mailman id 176537; Wed, 01 Sep 2021 15:52:03 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLSWx-00075V-4K for xen-devel@lists.xenproject.org; Wed, 01 Sep 2021 15:52:03 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 1642fdd1-e56f-4bcf-ae0a-0e39a73f0556; Wed, 01 Sep 2021 15:52:01 +0000 (UTC) Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01lp2058.outbound.protection.outlook.com [104.47.1.58]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-29-5N_FybicO5GK4fwW33LkwA-2; Wed, 01 Sep 2021 17:51:59 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR04MB2960.eurprd04.prod.outlook.com (2603:10a6:802:9::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.23; Wed, 1 Sep 2021 15:51:56 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4478.019; Wed, 1 Sep 2021 15:51:56 +0000 Received: from [10.156.60.236] (37.24.206.209) by PR3PR09CA0017.eurprd09.prod.outlook.com (2603:10a6:102:b7::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Wed, 1 Sep 2021 15:51:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1642fdd1-e56f-4bcf-ae0a-0e39a73f0556 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1630511520; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yDUxKs17CBRyEk1FI7eJvE3umkbbk3O/fEeF6QKW0cg=; b=EHjzOGsFJpi3XeMDuHI20cTqO3YUZtuBXbcMePnicEdbL3LV3F3TnG8FKblI6V9GU25sVQ dMhAn1ufylATYLbhnaAFNuuSt6+jjppRBJMU7gsH3ON01J/WPHdjF77S2+1LW3PcW5S9+j E3HPHQyKLpsX+3ybeb8dGiTaOhCRC9E= X-MC-Unique: 5N_FybicO5GK4fwW33LkwA-2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Gk8N2VnkqjKffSgjxCLbiPTQs40owmPlLJsXp4oEjqm6t6KOtI0hNgdNerZV25Y0hzGetzG9WmqNhtzg7zzGJPMSjJkKc0TLKCGaTK6EY+zuTbA4/s5H3kwpLDkKwA9XvrJe3+37UGszrkDMZ5SezPaT6OukqhKTr3PvToA/E9HXE13iXeqVdnejRGQY0007jKjKX7FqW8SyMOaXcO7Al4oMF5q9P94bgvdsJRQS8HMs1fgjsjv86oS1zOYiNfKqiOdqKiwUETVIfpO8ECLoPGqxgGOB5py6xWtnrDTAAwPSy6GhT5l3GwVXgQd1N6jdIWo51iiW3NMb6CuFixCFhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yDUxKs17CBRyEk1FI7eJvE3umkbbk3O/fEeF6QKW0cg=; b=H0gxnNBCyS13nzEsQDbay45/XVyIxd2pcUBQF2pl6UzgbIYFE9mOD2RyISD6H69siqDZ6Am0957f8AkdTpUV757DCOnb7jyad4I4nYs9Ae+0KcX97DhG9re6a1ijJ+5aAFvAqWyjIzXuCp1j14vRbXfUV7/dze1JQ4YToziES1bri6cGizGQJsP5a1ftSlNuHaQC+rZ37h9J92VgKVwg1rd081zOLtiQGwZBdc30a6K3rc7z9+PfW0uBgNYwSGiZ4sB9VTHtqJIgoMCRZqYQVyS/IOxpLHO8BgojhThsfUX9H+oHdFMJYXvO0CwFMWzdQArj5al8gTG2nUYU1fX52Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: citrix.com; dkim=none (message not signed) header.d=none;citrix.com; dmarc=none action=none header.from=suse.com; Subject: Re: [PATCH 0/4] x86/PVH: Dom0 building adjustments To: Juergen Gross Cc: Andrew Cooper , "xen-devel@lists.xenproject.org" , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <1d600035-851a-190a-f744-8cd7b2d887fd@suse.com> <02ebe247-6891-dbdf-82f7-5b33b5a08dd5@suse.com> From: Jan Beulich Message-ID: <32638483-c44f-d2f7-a741-c51dd98461c8@suse.com> Date: Wed, 1 Sep 2021 17:51:54 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: <02ebe247-6891-dbdf-82f7-5b33b5a08dd5@suse.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PR3PR09CA0017.eurprd09.prod.outlook.com (2603:10a6:102:b7::22) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d62c22a7-a491-42dd-81a3-08d96d606d25 X-MS-TrafficTypeDiagnostic: VI1PR04MB2960: X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:3826; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Z/BhyqfxnNuO/PKuyx0HTtvAAWSdjpB0asnAgOtB1GaqSMT2+ryrZIjBguJtFCzZgiHCdvzJKbLY2VhezkLHn2y2bfIY9CACJ4vVv8oPYc5B1LA1epJ566z15ul8OAIfBniZe6iaoYfN9KMQHY5vKmzfo/X5npTpFzGFWpHRtfVMkuoQApIxPcKjMny3M01DYmHYodw+BFl44drIPvbMu5Dyo9Xo1MnYAFMtqSabFVYvceKoJ3jIW+tOKSbO0KiLxNPTYWljs29wmqH/1OTFDpSbX4IFieeYgPePRXj7I4JM5BcVBA9vh9ui6PsFdvtfcrXLRr8LOfWq91HhctF87VpJlXjBcXu3yo2Cy+oaTPOxCAYjNdwZ4M90Zkfj7pFdwULGPXOVz2uUg4ZXijVIHLSGQcswMlw3fjxF61vIo4y9PpstdgGNUDPwQS6rnf4Q75hYVY8yeRbSZUbGxA/Fvim3vTIlwgJMwamU4kbUX4a1z5ktXo3zjvPckJnQzuFWgp+4TGWHUw/gPF5y8q/xDVdbXmeTEi+qe4KJSBG/5OULCVAlPFhTi+8SjrmR6KAVo1Rdk4pkK4e9clqDste80cnVyHyIAb8B5wSLCzuLvXRIgbZEV1NTWL9Tslnfkal5E575lKF/k9sr/UDlqdn7IKCxZMm4QkSKDGsFRqZPAJyBuuGYhEBGbLJDN5qh/JOCgDAvnPcBUwigUSaYILG7wZE1IYEHaMTf0VQQFem4Lvk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(136003)(366004)(346002)(376002)(39860400002)(396003)(8936002)(5660300002)(53546011)(66946007)(36756003)(37006003)(83380400001)(66476007)(66556008)(6486002)(31686004)(6862004)(478600001)(956004)(86362001)(31696002)(8676002)(6636002)(38100700002)(2616005)(16576012)(4326008)(2906002)(316002)(26005)(186003)(54906003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TmFzVHVzRFdDY1UvRTJkSysvdlRMY21HTEE1Q1RJcnBPUExva2E4MzQ2L0JW?= =?utf-8?B?N2VTTVNrb2Z2bGQ1SFJqbFFIaGQzWm5OVWR2dXFOTWdFck0vWFZGK1FHeGl2?= =?utf-8?B?Q1dKaTE2Ti9meWJZaDVZM2Nvdjk1Mi93cDNNaXM1UHJYTGEwK2dka01Yd0VS?= =?utf-8?B?VlVnK0tuRE1UbHEzSS9VZVhyZHdsN25oNlMwaTNqbll6VnZFNmkxK2ZOeGJW?= =?utf-8?B?cnVXTXcycjViWjI0aEN5aGFDaStHM1pvc0FuRlNyZmNQSlRvK1dxcENLWHhB?= =?utf-8?B?eEEwNjBOS0c1K2puMHg5cThCcnhIRWU3dXd6NHJNcUxWT0N5a0RxbXB5TDFS?= =?utf-8?B?dXZsS2VqL2RzSVYyUGlaRDFjL0hURHhITmVQQmZ4alhaOXllbFNhWW9kQzI3?= =?utf-8?B?S3pxMkJCSEZyM0RVRzRsNW1PdDJuek9zcjR3aDFrMTkrZ3E3aURlSXo5bWJU?= =?utf-8?B?cXpmdXFlajhydGRqazgxa2ZzZ0FVT3hsRm5iZXdWalAvNVBVbS9xaUhPQjk0?= =?utf-8?B?OFI2NzZ6MS9VdDFyZ092bUUzc1lyUVhUSitrWGJiRGVjZVF6RnlEZnV5dWlS?= =?utf-8?B?TTRBNkN6WU96ek1iYVZQbnoyanNncVFDU3FWcWowTXA1NUdJcDRSdXRGZXBR?= =?utf-8?B?WEM5dWxUVk9rVjF4cTZjTWNHTGxteDFRdEhaNXEzM1hjd0dFT0VIQ1BLQTJV?= =?utf-8?B?SGI4ZEhESHA4ZEI5d2g4VkVEdVVyTmZHRGpnYTZMeEhKL3NpZnYxaUtBN0Iy?= =?utf-8?B?RlZzeW9Rc0dnZ1U5OHNYVnFiTng3V3pmVTRCTUx0eVh2TGplMGFaRVBmRG5I?= =?utf-8?B?ZjhSdzlzenBLWHhuNFBWWVRYMm1YWmpPakFrS3FrYjloa0ppczBqQVZvR0d6?= =?utf-8?B?bHkyRjZTeUxSVXR4eiswQWRlbi8wRlE0OEhPSEN1RHNqblR0THJZcUVmQ2Fp?= =?utf-8?B?Yk1aNUFLYnh6K2F1SEdpd3hNYkQ3dm9MYVFqcmJ1TXY3cWIxMWErUldKeGt0?= =?utf-8?B?cENkaXFUMkU0RTR3MkpSdndBY3VyYnJaZ2g2U2l4YWpWTUdaNWE0NmNLaTJO?= =?utf-8?B?djZtQTZsQXozTDBxM1ZZd0lPWEtvcjVsOEhlL1V3Um5Gb0FZT2FXNnJZNDBr?= =?utf-8?B?RkprK2VkbUN0TERCdHpWaG5GZ0VkUVZwdzYwSjZVckJlUGQ4TEtuQ1JxQVFz?= =?utf-8?B?NURtSlZZRjVQOHdqUWxRajdNckk5dHRoNkExVnRwSUljanBTV0wzTzltSExQ?= =?utf-8?B?R2xSdUQrYVRKaG1jYnhVSTFzckhVaVJKTmMySFBJYlFLT2pLMXVhK1FEUFJB?= =?utf-8?B?b1FiemhIOWhlSWFNSDRwN2YzM1YvUmpaTlY2ZDQ5UHE4VnpSM0N4YlNJUFl0?= =?utf-8?B?emZZK1psbFRXdFI1QW5BQ2hsSEJGMUh4RjlIYzlqcFJ1MjBGT0NkYkczL0x4?= =?utf-8?B?N21PMit2WWZ3TkRFQXdqVEk1YllBOHhyOTNuRW4weTNucm1xYy9ScXJLSHJN?= =?utf-8?B?TWE1b2pjKzRMbTJ5aUNReFdzeERFSDNkU1Z1Y216T2w1bnE4cTlUUFBDdkRk?= =?utf-8?B?VG9rcDBWWlZyblN4ZE9uUUhOWGFhRTYxL0hPRkpOQjNYVE1HQUFGczVTMTc3?= =?utf-8?B?Z0hSQ20rdytiaXlwWVpjOWtMbTQ4YTlFZlNEaEVacG5uRENBN0IrTTZveWZt?= =?utf-8?B?dllyamJ3NjNBV1VNR3BEYnQ2enRRWHk2SFNXYmNpM2tnR2pSdGFZcFRuMndY?= =?utf-8?Q?PZ6xtpSK0V/fP1C1DZowbOeOkCvq0bwADw5B4YK?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: d62c22a7-a491-42dd-81a3-08d96d606d25 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Sep 2021 15:51:56.6477 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: nVOOVHIT9fBOhPnyV7BE3owEi0dcsSlOXtaNutaeWvOCtTzuEXd4z/SYd+eKYY9JylT/DXQnACs2BT0pqsHJ/Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB2960 On 01.09.2021 17:24, Juergen Gross wrote: > On 01.09.21 17:06, Jan Beulich wrote: >> On 30.08.2021 15:01, Jan Beulich wrote: >>> The code building PVH Dom0 made use of sequences of P2M changes >>> which are disallowed as of XSA-378. First of all population of the >>> first Mb of memory needs to be redone. Then, largely as a >>> workaround, checking introduced by XSA-378 needs to be slightly >>> relaxed. >>> >>> Note that with these adjustments I get Dom0 to start booting on my >>> development system, but the Dom0 kernel then gets stuck. Since it >>> was the first time for me to try PVH Dom0 in this context (see >>> below for why I was hesitant), I cannot tell yet whether this is >>> due further fallout from the XSA, or some further unrelated >>> problem. Dom0's BSP is in VPF_blocked state while all APs are >>> still in VPF_down. The '0' debug key, unhelpfully, doesn't produce >>> any output, so it's non-trivial to check whether (like PV likes to >>> do) Dom0 has panic()ed without leaving any (visible) output. >> >> Having made '0' work at least partly, I can now see that Dom0's >> vCPU0 enters its idle loop after having gone through all normal >> initialization. Clearly certain things must not have worked as >> intended (no APs booted, no drivers loaded afaict), but I'm >> having a hard time seeing how to find out what that might be >> when there's no output at all. PV Dom0 does not require any >> special command line option to do output to both the VGA console >> and through hvc_xen (making its output also go to the serial >> log) - is this perhaps different for PVH? I couldn't find >> anything under docs/ ... > > Did you add earlyprintk=xen to the dom0 boot parameters? Yes (I did mention this before) - no difference at all. I guess I'll try again, just in case I made a stupid mistake. Jan From xen-devel-bounces@lists.xenproject.org Wed Sep 01 16:07:05 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Sep 2021 16:07:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.176546.321244 (Exim 4.92) (envelope-from ) id 1mLSlD-00010l-4D; Wed, 01 Sep 2021 16:06:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 176546.321244; Wed, 01 Sep 2021 16:06:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLSlD-00010e-1C; Wed, 01 Sep 2021 16:06:47 +0000 Received: by outflank-mailman (input) for mailman id 176546; Wed, 01 Sep 2021 16:06:46 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLSlC-00010Y-4n for xen-devel@lists.xenproject.org; Wed, 01 Sep 2021 16:06:46 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 99e5fc56-0b3e-11ec-ae00-12813bfff9fa; Wed, 01 Sep 2021 16:06:44 +0000 (UTC) Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-he1eur02lp2057.outbound.protection.outlook.com [104.47.5.57]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-24-sbgjM-IgPLW50Sk0nrDtbw-1; Wed, 01 Sep 2021 18:06:42 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR04MB6174.eurprd04.prod.outlook.com (2603:10a6:803:fa::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.20; Wed, 1 Sep 2021 16:06:39 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4478.019; Wed, 1 Sep 2021 16:06:39 +0000 Received: from [10.156.60.236] (37.24.206.209) by AM0PR05CA0079.eurprd05.prod.outlook.com (2603:10a6:208:136::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Wed, 1 Sep 2021 16:06:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 99e5fc56-0b3e-11ec-ae00-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1630512403; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=tt+7kx5BdjY1U94SmVlxWaRlQbb57pNXoUVSt8g/sWM=; b=NX9025zHV5SrMf2eaV8FstQb0O2zfrMmlcJbljXRo1RVbYTQkpI8t5wfrQJkel4Sp/JSea wz2pzQ9vhNC8SjUuZ8fKAC8NL70edTopac/X6ck/dLva6VsuIVhVhHDiMpyhNzTobL5YdZ 7Lc0FSgELa1yAYULrz+DV+n8qPOm1fg= X-MC-Unique: sbgjM-IgPLW50Sk0nrDtbw-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CSNlk/SaIxvLDw3VzVNotapcqgLkSLmQup7XbyEuz45fLQe3O1kccLOccSDxcjYhXHh/+t6ZeXayoVJZ7m1Nje8nBTC1Mry4qvIOmJNNAskafJQ6BMphCZ1H+5Amrc4zSdAjtSO7wGs14v6bgjRQUWo0HiHsZSLtHPmmvQOtaczMkoGuWXkWtL8OakZqUn1swTpwAmCsdPFX1HFPCIdhwJKyq5LqM/SGVTrb2y7U8J3S48WUjo78PkwQ/OjGYf1vDr0hQ4/WsG0BD3l+FvfyCapBjzXmzWDESGv/dZhQBLY7pNxSs1xx+m4JAnFbQ9odSqA2xnqeqVNwSl1UZKf/RQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tt+7kx5BdjY1U94SmVlxWaRlQbb57pNXoUVSt8g/sWM=; b=mGU749/3xxMTAqGM5Pzu5WxGOfQ2gqs/IkRoRU6RHWtcYDpw9slq4ex6Sz/ef145SAZxPZSjfV1ZozUyYI04EEgvXmWbbmdsx2MDWpFjRPcLfAVbVoiHel4O+wRFtixUWx0l6TqmadkLcXDOV8iyF9zSDAD6O6Fx7orFcjQeQtktbSL3TcEDPiFYB7xGf3nF6FVbZWSam6xE4Y6luUwA4RI/NU3ZsUdu/m497nSDMVT/UBfH1O9z8yhRZgU6uPkMN927MDy+ybwlPdXbSoAIyhK5oSUoLQJ61yhNVgp1L/BGult73hrbP0usjvAJj1efveSC9A07craV7B4R6j7zqw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: citrix.com; dkim=none (message not signed) header.d=none;citrix.com; dmarc=none action=none header.from=suse.com; To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= From: Jan Beulich Subject: [PATCH] common: guest_physmap_add_page()'s return value needs checking Message-ID: Date: Wed, 1 Sep 2021 18:06:37 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM0PR05CA0079.eurprd05.prod.outlook.com (2603:10a6:208:136::19) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2ce9d0ae-d029-4ac7-589d-08d96d627b84 X-MS-TrafficTypeDiagnostic: VI1PR04MB6174: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: vpjI26fkDv6QD2Kl1Klj+xnjoRqyHuKDNzgP1lJuQyBTZlL5FrVKhBgLCdz7ry+dqczTQx74iict04exc61SA3SunMzd3hmxFPvhmy//XZkrMwzZ+7NflA3gHSP8H5qr/fs5s9adxyVS72wPwOqIGxQHrb9skSB+ApDi7RBAkaPcQISTNRVGfJqWizHeqDY0gHkrsfbNMIqD7cZFo3FJ88vF/8oOHTLb+xh/U9K5H7KgfeRVenWIJre+7YYCQPFwknsDIo9kyluOarAcMJC4Bx6RTc+UIT+E8uNseFc795pXuQIJvf+eOY3ecCnfA+w2y9PoOuExo593kxHB6IIlNpeohsJO+ogNtLeFni7w8vZZJHthF0t2HHabZaJC5sDMVwYNHXF9lHnv+ESp5z8y5MKawPU31u1pTXQ4j5LN+0/xm+QPF3/qez3j5mad7efsUvfOtUB0R6bVhHy+5a6oV08wQUHDOrB/GSJ5ucFtX+UX1NU+bffLtOvvxX96HiVRjmm63V7ZqzEFdptjAvWqfFY03HpT/DD58w6lwwznYwKzrnPMl92vir+CCO7jBdtBNYviR1IE1+42SDfk5mQKs3AkhEziK2tqIrz7wSEOlLCnVQMTsi6hy4lAhpIaTOmgQs+W8+peIzXj+e/N8fgrQFHmepqUw1dr6n43hCJJopnJQtVBrD7bkkCt0Py5Ah5nQzGyXcBiymuxqeIV9Z4BYpNeUUw+kQzoIEUmNofDA/s= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(136003)(376002)(396003)(366004)(39860400002)(346002)(8936002)(5660300002)(2906002)(31696002)(478600001)(6916009)(16576012)(6486002)(2616005)(83380400001)(38100700002)(316002)(54906003)(66556008)(186003)(86362001)(8676002)(26005)(31686004)(66476007)(4326008)(956004)(36756003)(66946007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cFhYTWtwZnFkTEMvdlQxSEM3T3dYWXZ0cTFGczlRSzFNY0ZyUE05TElGeDdN?= =?utf-8?B?dXUwWUhVbUI4cEFFemVVaFdtTHBEYi9TTkZGQUNXbzFTOE9IRmhjR2orYm9r?= =?utf-8?B?bFVSM1JYL3FCOEU1ek5hdDlKUFdQU0tMalAwdDBhNUZnbVhURkNxNWlnZ1NO?= =?utf-8?B?YThuN0dWdC8ydk9JSTIvaysva0dtTjA4aTMwcE9Zbm1zMXl3VCtZY2o2UVpN?= =?utf-8?B?T25pUzYxUG5NNFlBWUVGMW9aVW5xNjQ2Y2ZMV3FtRVpYOUgyMXFVbnNFUzdp?= =?utf-8?B?TUViREV6SjBXUmJTZUxvK0dUU1B0T2pXak1JZGhueUR1bzhuWjlUMDBJT3BY?= =?utf-8?B?cGFQYUhORXFRTllHdjRRSkNMRW1BWUg4RE51d3dycWRhT3B6OXA3TDBtcFhF?= =?utf-8?B?N0Njd1h2UGsrR2o3ditkZSsra09TRXZ4ekZOeVk1WWREOEZuM1crS1NFTkQ0?= =?utf-8?B?WCs5YkpQV2FmWTBqOTc4RzVJc0F5dnlEMHVCbzRrNFBkVk4zTE1VZzYwc3pt?= =?utf-8?B?NzRydGdLbHFqS1JwaExTSGIwMFJ3dEFOSk10S1hlQ3pFK1pZdzdWKzRBYkxn?= =?utf-8?B?MWp3VVdlc25weGFiam1hU3I1Yy9lRlV4aXNxRDdDbWNMaGJMRVdFRmNwMVJ1?= =?utf-8?B?SFc2TTBTWTcxMXNFQk9JSXVJMFJxVnVRVmtNVlVQRE1oZS9yRExyRkp2cUo1?= =?utf-8?B?bm9abS9teWdPc1IvNDRVbzFIVHpYTXl6SDg3Y3JHcGZ0VmZxV0l0UnNKMmdU?= =?utf-8?B?MEU3c2JJNnhEaFhVYjJsUUlhckNPUWJGVXR4OFpuY3FZN3dOc2ZiMGJwWFJl?= =?utf-8?B?OWpLZGs0KzdkbnkxS1BHUFl4QjVtNXVBekdPaXVvblhlbzZUaER0U2phUG9l?= =?utf-8?B?NlBpY0szeS9qQWROUUkzd3lxb3VwNzFtSi9CakxSU25EaWo5WE5nZVc4K0l0?= =?utf-8?B?T0F0SWN1WkUxWnhtM3FJVzNBTFY3RjBxSjMzQjBMaHk0TUYySk1uZDU2YVZq?= =?utf-8?B?WFJxdWx4a3NIVmxlYWx5R09xVG5qMXJrSnZYd1luK0ZTM3hzTzVGSjJnMitm?= =?utf-8?B?bGkvY0VON0U3b3JlK2lKTFlHdU1IbzVmTGFVUk4yemxVOXFSRW9FYzAxR25h?= =?utf-8?B?MFZ1b1huSlNFWlY2WmZrWUxvYVJJZFZvWWhBaDZGajNobGUxemtOZlBEZVJV?= =?utf-8?B?cU5aVXdKR2JyMUprRkw3bk5iYWhTY2JiMElYaUVaNlUrVFcrUkFpOUF6dDlR?= =?utf-8?B?TVVJT3RYbEM2d28zOWs4c0IyTC9lZEZxbVBaV1lieGw1UUFCc2p6S3ZuWkla?= =?utf-8?B?MS9EVlhDUFk5eDA2eTExTXk5N1c5dDZoWjUxcnZSYjZoNFVEN0tKbWR3UHBM?= =?utf-8?B?SlhBOEtJYkh3YUdLZVJFb0sxWkpUQi8xQ1U4MFBQdGY5dFhjbzR0YWlrOTlZ?= =?utf-8?B?L3NHSEo1c21zVFVpNE43MGpLYndxcXFEU0JCS2srN2F4bEkrTXVyV2JmcHNl?= =?utf-8?B?M1F6ZXorcnUvYXpUTWwxUlcvWVZ0MUZFRUhsZWhJaDNOeHRYeWlpUlgwU1hC?= =?utf-8?B?cEhnNnNGNG05VHFLWnM0WFEzVVY2dTBicVNKWU4zTm1mSWZZOXl5bDJ0MG1t?= =?utf-8?B?QVUyVjNXb2VzN0NXVkVGWmRaM3o1b0p6Z0xXMkJtZGtBSk1mVVdzd1YrRTMv?= =?utf-8?B?dFB3SjQ0SHQxd3Z2SktlY3JFMW1teC9oQ1dFM3UyM21BckRlTGx2WC8zV1l5?= =?utf-8?Q?hcqgHkN0xv2Xq30twLcvvesezGzC1nC8Xd1eMOo?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2ce9d0ae-d029-4ac7-589d-08d96d627b84 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Sep 2021 16:06:39.7258 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: vlqGfXZuf3At/oNe3DAFp+/0CHHXS5N1ZEeQrV17B/bJGboOAtFgJZ+AQLTzlo+uKa9yoLrrIprhP/NkkalD2A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6174 The function may fail; it is not correct to indicate "success" in this case up the call stack. Mark the function must-check to prove all cases have been caught (and no new ones will get introduced). Signed-off-by: Jan Beulich --- In the grant-transfer case it is not really clear to me whether we can stick to setting GTF_transfer_completed in the error case. Since a guest may spin-wait for the flag to become set, simply not setting the flag is not an option either. I was wondering whether we may want to slightly alter (extend) the ABI and allow for a GTF_transfer_committed -> GTF_transfer_completed transition (i.e. clearing GTF_transfer_committed at the same time as setting GTF_transfer_completed). --- a/xen/common/grant_table.c +++ b/xen/common/grant_table.c @@ -2394,7 +2394,7 @@ gnttab_transfer( { grant_entry_v1_t *sha = &shared_entry_v1(e->grant_table, gop.ref); - guest_physmap_add_page(e, _gfn(sha->frame), mfn, 0); + rc = guest_physmap_add_page(e, _gfn(sha->frame), mfn, 0); if ( !paging_mode_translate(e) ) sha->frame = mfn_x(mfn); } @@ -2402,7 +2402,7 @@ gnttab_transfer( { grant_entry_v2_t *sha = &shared_entry_v2(e->grant_table, gop.ref); - guest_physmap_add_page(e, _gfn(sha->full_page.frame), mfn, 0); + rc = guest_physmap_add_page(e, _gfn(sha->full_page.frame), mfn, 0); if ( !paging_mode_translate(e) ) sha->full_page.frame = mfn_x(mfn); } @@ -2415,7 +2415,7 @@ gnttab_transfer( rcu_unlock_domain(e); - gop.status = GNTST_okay; + gop.status = rc ? GNTST_general_error : GNTST_okay; copyback: if ( unlikely(__copy_field_to_guest(uop, &gop, status)) ) --- a/xen/common/memory.c +++ b/xen/common/memory.c @@ -268,7 +268,8 @@ static void populate_physmap(struct memo mfn = page_to_mfn(page); } - guest_physmap_add_page(d, _gfn(gpfn), mfn, a->extent_order); + if ( guest_physmap_add_page(d, _gfn(gpfn), mfn, a->extent_order) ) + goto out; if ( !paging_mode_translate(d) && /* Inform the domain of the new page's machine address. */ @@ -765,8 +766,8 @@ static long memory_exchange(XEN_GUEST_HA } mfn = page_to_mfn(page); - guest_physmap_add_page(d, _gfn(gpfn), mfn, - exch.out.extent_order); + rc = guest_physmap_add_page(d, _gfn(gpfn), mfn, + exch.out.extent_order) ?: rc; if ( !paging_mode_translate(d) && __copy_mfn_to_guest_offset(exch.out.extent_start, --- a/xen/include/asm-arm/p2m.h +++ b/xen/include/asm-arm/p2m.h @@ -307,10 +307,9 @@ int guest_physmap_add_entry(struct domai p2m_type_t t); /* Untyped version for RAM only, for compatibility */ -static inline int guest_physmap_add_page(struct domain *d, - gfn_t gfn, - mfn_t mfn, - unsigned int page_order) +static inline int __must_check +guest_physmap_add_page(struct domain *d, gfn_t gfn, mfn_t mfn, + unsigned int page_order) { return guest_physmap_add_entry(d, gfn, mfn, page_order, p2m_ram_rw); } --- a/xen/include/asm-x86/p2m.h +++ b/xen/include/asm-x86/p2m.h @@ -583,8 +583,8 @@ int guest_physmap_add_entry(struct domain *d, gfn_t gfn, p2m_type_t t); /* Untyped version for RAM only, for compatibility and PV. */ -int guest_physmap_add_page(struct domain *d, gfn_t gfn, mfn_t mfn, - unsigned int page_order); +int __must_check guest_physmap_add_page(struct domain *d, gfn_t gfn, mfn_t mfn, + unsigned int page_order); /* Set a p2m range as populate-on-demand */ int guest_physmap_mark_populate_on_demand(struct domain *d, unsigned long gfn, From xen-devel-bounces@lists.xenproject.org Wed Sep 01 16:13:27 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Sep 2021 16:13:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.176552.321255 (Exim 4.92) (envelope-from ) id 1mLSrT-0002di-Rg; Wed, 01 Sep 2021 16:13:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 176552.321255; Wed, 01 Sep 2021 16:13:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLSrT-0002db-OI; Wed, 01 Sep 2021 16:13:15 +0000 Received: by outflank-mailman (input) for mailman id 176552; Wed, 01 Sep 2021 16:13:13 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLSrR-0002dV-Kx for xen-devel@lists.xenproject.org; Wed, 01 Sep 2021 16:13:13 +0000 Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 81102a66-0b3f-11ec-ae01-12813bfff9fa; Wed, 01 Sep 2021 16:13:12 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 81102a66-0b3f-11ec-ae01-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1630512792; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=HvvlN/n0WnyfSJuxCS3vjmgoOHALxUs8+4ZZAxp0Ed8=; b=WaHU6LM8OQbM/MGhAUFoBhQITBqYf52tPMckkuU4tyZ4HRIQ666Ijgek ezSOEHLUlafatuLcSFq+3gZJ0PqxiAJt3L9naHNq+/US2s7S9uD81JPwZ eDKg76jgpHH7DcrTkItFPzM6f+NdejKWXpzJuRpbibu4Ls1pgEpqMwi7L c=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: gjr09FkSY08HDDV29MdiUKT/rneNt0X7U9fFtSFhq1QEe++zSzlICW/mIUFtakzC7vxvoe8ajh 67T8B9xtSr+LGaPLqlRXyJlcgGVZ6Ciumx1fdvbnPBgtjZ7lFqnbu47pG5lEycjTllAHZx94bH Vxl3NGZxwOqSMqn+SmMRZCX0Q+4m2UhthqodgOkRK7LZ/nrOuCPntC6kRD5A1VfOuMzN5G6pN0 kn6ycrgTSiNUDG6eMtSf9f1iPRMPINEAMRxf0xkQB2wiELjJyTPHz31J4AAwVFL9QNlRPwVYpO SXgXxn/1eMiz8KjRoEN9S0H+ X-SBRS: 5.1 X-MesageID: 52206275 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:9huq46hoVw77GhpT+UxzAz1XoXBQXhEji2hC6mlwRA09TyXBrb HXoBwavSWVtN9jYgBapTngAtjwfZqyz+8Q3WB8B9mftUzdyRKVxeJZnPvfKl/bakrDH4dmvM 8LHsQQNDSzNykdsS+Q2njaLz9U+qjjzEnev5a9854Cd2BXgqdbhDuRQTzraHGeDDM2eKYRBd 6Y4MxfzgDQB0j+eKyAdwU4tsb41qL2qK4= X-IronPort-AV: E=Sophos;i="5.84,369,1620705600"; d="scan'208";a="52206275" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PEd3Rn+azAXta2wzmUGSDW4o+AADo4swardXmAKHmIuiy4joq8yOmiViEfUVhIq19MO2NZ0tuXrCpO0ni5/awd5OPmp4qYplWiYL26Ui5FC1/i9M4qoShUk/mO74d/Yo2nNP+2L7sL2azabKrkReNKGqE3sfDtsOfSSR/bbG17G/vhWwEdMW9w+GW7sakfCpn/ksV0TNVTlo/56Z9xUn7k/i8duOMf9gkc/yF/uqPFo5yo96mmpOHpU5CXhuRlQOlkMHfggdAGGQ+rkigAHtEegKufFEJenWiBgOdDiZRmXg0rSsBz8mGasr2bhqwIeMb6qZtlbl4shrZzSvexSDdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=w3gAsDWXO8sHjqoatlOYh71lPbgIcsOnbCK8nxc/AU8=; b=IgFaIPFwhhJiYJS0zw7CxwqvXc6aEedghCJz0kJUprOhCoDrpxnSYaGO+NFccbBMY10r7Tc6eiTI3jYLpKiP09mK09t/OveUEMsH3TihLnSc5MhITb9P2kU8DGd0a3WOQNL8cCHSkvaEAtVYVIXApVVzm66EEveMc8AO5/KIcsqAd7fHKfLtzRl+hGqSwP0LHeyeuP0ZiKpyyxHiHQ4FHlc8veRwmT+rspemna9LrmlyhhqdaNCGp3BUcPcU5TbRZ/9naGcYJi/zAAq53O7zroQZ8ualvTOsb9t+5vX+ey+y38sN+9AKi9BKTYn9K00OxSQ4eBWhQm4eZz4Dc118/w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=w3gAsDWXO8sHjqoatlOYh71lPbgIcsOnbCK8nxc/AU8=; b=owP3rKZPw4jaVsu+JwbkGzp1YieXzlpvuMW1fct51/emHFMHuBr+XqrFxjleRLHZo04gEy0ckV/SlNUb3dEIb8jk+B5Rp2Za2CyQsRZvsG0ZYPRfNhEH3cH8TzxkN9ji08RCGPVtKtcZIPVgKEC03c678W5rrvyrgqQUAJEX08w= Date: Wed, 1 Sep 2021 18:13:03 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich CC: "xen-devel@lists.xenproject.org" , Andrew Cooper , Wei Liu Subject: Re: [PATCH 0/4] x86/PVH: Dom0 building adjustments Message-ID: References: <17c5ce48-11e6-ac97-fa67-294cbb8b79b7@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <17c5ce48-11e6-ac97-fa67-294cbb8b79b7@suse.com> X-ClientProxiedBy: MR2P264CA0171.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501::10) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2fef1be4-0fca-4577-0fbd-08d96d636379 X-MS-TrafficTypeDiagnostic: DS7PR03MB5590: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bxJew0XlIm2AISGmCQh+bEzt+9A0LDVSwyBB9dk/uw+R15Z/jkNr7RVFkLEm67V8SShZqNRD8UsQaQVaPuqQeUmZQhk7voeSg2C+BkrX9y5CfTIjIp54/Roenp/WbP3GFtoAnt4YeoEKt1mFl4su1wuZ1JtvYwSniBbba/ombyvPRkW2FlD88kFelvGSXVl9TPHIYgygFgftPOeIGoRphRkGwgVJAxOkGWOCfUkScgNIbQjdA1pT0Bfde1dUeSbkbE7mjVDrF9cMcerEkBuyNpCK5BWnuBFGAGVTSEHQF3cC4gYs9eiK5hC2JRJASHP9KfCxX0okF3w0TLW83p8tCrRAW4lgjckabCy/LMSyGiS5bAakiveai9dM9dUNbYyI3BuUbZFOvLO8KZWPRFbjxAO0hc85taZe9+JxcY6IAHJHknlQKco3yNx2D1yMDdojAL/NTDCMCbCVxYok+4Kq7O91JFhP/ZNZKv/FLoBwXCZ1ob9VAsLRss67LEno6mhQjHopSV/3PHBsxZprzYn+GAtlrQQXc2TFOP6gnqSjZLsin5z17COlxzaK8f4QDEO6dgLT34xt1ubHBOF7I0Jab6IVbD8kmKUh5qGWFplBgy+6ghewhHMteysOFmlYenHivrs+yPSZ8diSNTyDOBoZSA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(7916004)(4636009)(376002)(346002)(136003)(396003)(39840400004)(366004)(86362001)(85182001)(316002)(4326008)(6916009)(8676002)(6486002)(66476007)(9686003)(54906003)(83380400001)(2906002)(6666004)(66946007)(26005)(53546011)(956004)(38100700002)(33716001)(186003)(5660300002)(8936002)(478600001)(66556008)(6496006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dkNwZ3RHYjdFRlljOFlZRUdEVWE5U05PTmRIUUtEQUhCSmFpbmU0ODg1WEs2?= =?utf-8?B?MTJ0MmVnZU9QUG5MSVZhamwyWVdiT3p2U1g5eUxBUFF1MnpuTGtxdkl2YUdM?= =?utf-8?B?bm5JTUpJOHpTakhEN1V3bUgxMVZLSEJPaENSZzRtQnNRRVp1VHVJeGJrcVNY?= =?utf-8?B?L0FEUXJUamszU1cwZk9URGlQVzhEang5Q0ZYNlVhaEhkZVRZenNDRXY5akd4?= =?utf-8?B?aFR4bGs3VDZRRFBiYTBMeEhhRTFJRVUzSFczei9xZkRJTW5OYzczdVNESkxw?= =?utf-8?B?dkRhQkRoY01wbnBNRkJSUjdFMFVpKzM3OFdtY053cDFyWmo1MDIxSit6SEcy?= =?utf-8?B?L29sek1Ubkp2OHZsTGRQTXF2OEt1R3UrY3BNWnRISVpPdVhTeTE4OTM2a3JI?= =?utf-8?B?US9TL09jOVdRREUyODA2UG1LZ291N2wzV1NocnhYRjJlYllPQ2F5WGdXWmNH?= =?utf-8?B?S0FjQis1UHEvMUtkZWV5d3ptWXhkTXRYc254UWUwbHk1dlBvdElWVHVtYWJ2?= =?utf-8?B?Y0ZxL3JmVVdNcTJEWmUyak43LzNtUmhlak1zaTkycDg4SzVkVndjQ0ZmV1cy?= =?utf-8?B?MjBRT0xVOFZkRGJyK2RmTjVKQUJkZmtuVUVzQk5aR3RsMXFrRFIyTUsySmsv?= =?utf-8?B?UWdmUmdPbU10K0wzNWdHbU5MS2xPckVkbU9jOERNQWpES1lIRUZ1TVgxeWNJ?= =?utf-8?B?NE00aExzRm5URk9kSnkxWXpxUFdXQzlKYk40ZnFkb2JJajBiMEVQSm5tTFVE?= =?utf-8?B?dTdsYWpWcS9ZUG5McFN4V0h6Y0JRU1JnTWFkZ1NUWE5yRkExR3oxQ1BvYVpM?= =?utf-8?B?Z0VBQW8yVjNQVEd5RVcxckVWWXJvekJmOGdrMVIwNk04YjVoaGhGajZhczVO?= =?utf-8?B?QlNaVHphNmYrRytrQWxXZU1BVlpRNEo2UXRGdytraUpWL1A2RGRiR29XMTlN?= =?utf-8?B?U3dGTHZtZlAweG4ySUJDZG1EdG9SSWxhSkEwYWtJNmgydlBBKzNsek5EYXFL?= =?utf-8?B?L2JVZ2IvRVZ2Ny9sVFFoVkJzYkRDL3VHVTVBM3RsU1d1Mlh1cTVBRTdIRUp1?= =?utf-8?B?TlZMVXpoeXFHTWZGcTF5U3diVVI1NFRib3JjQzRRejJKUHVQR1ord0xtNXNa?= =?utf-8?B?YWNBNEkvN1A2czdNdDk1bTlyV1NxYmFXbkF4T0lHemRjcCt4cGhXR05yYnRn?= =?utf-8?B?aGNreUVVeERtSWdSS1NxL2hIcFlScFpnOFFDZTZlN2xVcTg2dFJoTHc2dXNa?= =?utf-8?B?YWhVWnZXQU16M3NOczFZSlpLNmhxQ2FMQ2FpSlBQRW5Mak9VdkNDWTBhN21o?= =?utf-8?B?QVc0b2xhdU4zS0JLd0RJakY4MlNKNTFxWnlmb005enBHQWc0a1QxQkx5ejZv?= =?utf-8?B?cjdldU9QSE5CcTE1UE03dWFUSnltcHNNdWhQYk1RN3hRYW5ZRVpEWWtaTTd2?= =?utf-8?B?akx5c1lYOVpHaWtBV3VNanExNjduUHFDUE5MSE1QalJBc2Q5c1BxWGgxZXF4?= =?utf-8?B?MHRKUVdtczA4aWJaWDF4cUFIaDNHOFJWamF2YmpoUXg2YUo1WUg5T3BrbnNp?= =?utf-8?B?STNpUXNialdTcE5nSFprLzZKTUNQS2pkV2U1YUg4VTY1bWVuQ3VjNDVXY1Qy?= =?utf-8?B?Ujh0WDNFNVNZM202OWkxaEhyRDdibG0wYWZPajAxYm5mcGV4Z3JLWnR3Wkkz?= =?utf-8?B?NlJxMG1vTTlJd3pmazJYMmpvODkwRWkrdWI1b3BoSXV5RFZ2N2tSYndRMnhI?= =?utf-8?Q?G7DBNlaD/lAp42WXI/PE6C+vOZvk+ghIgVMrcZc?= X-MS-Exchange-CrossTenant-Network-Message-Id: 2fef1be4-0fca-4577-0fbd-08d96d636379 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Sep 2021 16:13:08.9854 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: oUKrbj29RCl5yKvLkjHwtpYVs1JGH5mOMotbej5gOofsiAfDWB5WzytGyzl6Qok0rf6qDsVdSmAN/yYsSmglKQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR03MB5590 X-OriginatorOrg: citrix.com On Wed, Sep 01, 2021 at 04:19:40PM +0200, Jan Beulich wrote: > On 01.09.2021 15:56, Roger Pau Monné wrote: > > On Tue, Aug 31, 2021 at 10:53:59AM +0200, Jan Beulich wrote: > >> On 30.08.2021 15:01, Jan Beulich wrote: > >>> The code building PVH Dom0 made use of sequences of P2M changes > >>> which are disallowed as of XSA-378. First of all population of the > >>> first Mb of memory needs to be redone. Then, largely as a > >>> workaround, checking introduced by XSA-378 needs to be slightly > >>> relaxed. > >>> > >>> Note that with these adjustments I get Dom0 to start booting on my > >>> development system, but the Dom0 kernel then gets stuck. Since it > >>> was the first time for me to try PVH Dom0 in this context (see > >>> below for why I was hesitant), I cannot tell yet whether this is > >>> due further fallout from the XSA, or some further unrelated > >>> problem. > > > > Iff you have some time could you check without the XSA applied? I have > > to admit I haven't been testing staging, so it's possible some > > breakage as slipped in (however osstest seemed fine with it). > > Well, I'd rather try to use the time to find the actual issue. From > osstest being fine I'm kind of inferring this might be machine > specific, or this might be due to yet some other of the overly many > patches I'm carrying. So if I can't infer anything from the stack > once I can actually dump that, I may indeed need to bisect my pile, > which would then also include the XSA-378 patches (as I didn't have > time to re-base so far). > > >>> Dom0's BSP is in VPF_blocked state while all APs are > >>> still in VPF_down. The 'd' debug key, unhelpfully, doesn't produce > >>> any output, so it's non-trivial to check whether (like PV likes to > >>> do) Dom0 has panic()ed without leaving any (visible) output. > > > > Not sure it would help much, but maybe you can post the Xen+Linux > > output? > > There's no Linux output yet by that point (and either > "earlyprintk=xen" doesn't work in PVH mode, or it's even too early > for that). All Xen has to say is > > (XEN) Dom0 callback via changed to Direct Vector 0xf3 > (XEN) vmx.c:3265:d0v0 RDMSR 0x0000064e unimplemented > (XEN) vmx.c:3265:d0v0 RDMSR 0x00000034 unimplemented Weird, I don't see why earlyprintk=xen shouldn't work in PVH mode, unless it's not properly wired up. Certainly needs checking and fixing, or else we won't be able to make much progress I think. > > Do you have iommu debug/verbose enabled to catch iommu faults? > > I'll try to remember to check that, but since Linux hasn't > brought up APs yet I don't think there's any device activity > just yet. > > >> Correction: I did mean '0' here, producing merely > >> > >> (XEN) '0' pressed -> dumping Dom0's registers > >> (XEN) *** Dumping Dom0 vcpu#0 state: *** > >> (XEN) *** Dumping Dom0 vcpu#1 state: *** > >> (XEN) *** Dumping Dom0 vcpu#2 state: *** > >> (XEN) *** Dumping Dom0 vcpu#3 state: *** > >> > >> 'd' output supports the "system is idle" that was also visible from > >> 'q' output. > > > > Can you dump the state of the VMCS and see where the IP points to in > > Linux? > > Both that and the register dumping I have meanwhile working tell > me that it's the HLT in default_idle(). IOW Dom0 gives the impression > of also being idle, at the first glance. The stack pointer, however, > is farther away from the stack top than I would have expected, so it > may still have entered default_idle() for other reasons. > > The VMCS also told me that the last VM entry was to deliver an > interrupt at vector 0xf3 (i.e. the "callback" one). That's all quite weird. Did dom0 setup the vCPU timer? What version of Linux are you using? It seems to get stuck very early (or either fail to output anything while booting), which seems unlikely to be related to your specific hardware. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Wed Sep 01 16:22:09 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Sep 2021 16:22:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.176560.321272 (Exim 4.92) (envelope-from ) id 1mLSzt-0004LF-PJ; Wed, 01 Sep 2021 16:21:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 176560.321272; Wed, 01 Sep 2021 16:21:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLSzt-0004L8-M3; Wed, 01 Sep 2021 16:21:57 +0000 Received: by outflank-mailman (input) for mailman id 176560; Wed, 01 Sep 2021 16:21:56 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLSzs-0004Kz-6k for xen-devel@lists.xenproject.org; Wed, 01 Sep 2021 16:21:56 +0000 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id b85db17c-0b40-11ec-ae01-12813bfff9fa; Wed, 01 Sep 2021 16:21:54 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 740B56069E; Wed, 1 Sep 2021 16:21:53 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b85db17c-0b40-11ec-ae01-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1630513313; bh=vRwjV5s4lKaeJNiv3puLhTfXA2shIEq8W7TQ2apezrQ=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=GNJG9s+oQomjzMi7Ot9T/6d3kPwB5n24zx2sr0/cIe3y+JlHPZTIyy4EayFEPChI9 nY6FdxHdbvKkfUvXKdkQJ8yFPRwIglYeHSRKCkh9Z/GJ2TVd6Lgnyr28fz+YFavDzC sTkIpvZSW9EMHqjl83oxOJhdgOwZtEx9LZu6MX47lVaS3cGE9fqiMblOmkyqT2aUZ/ UiV01PZ+V2hDNCHuVguyY5C62p1VpJNurWZ/Fip8U0MiBlItTjpSN7hU77sqp5sUuY k8AJ/EDTecw3krj6HCRSsrGBBNCHZbtGf8/PdT4eK067dXFPIBEnszi4pW1pk8sOoX NlS5SCe5098Ng== Date: Wed, 1 Sep 2021 09:21:42 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: Wei Chen cc: Stefano Stabellini , "xen-devel@lists.xenproject.org" , "julien@xen.org" , Bertrand Marquis Subject: RE: [XEN RFC PATCH 24/40] xen/arm: introduce a helper to parse device tree NUMA distance map In-Reply-To: Message-ID: References: <20210811102423.28908-1-wei.chen@arm.com> <20210811102423.28908-25-wei.chen@arm.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323329-968995931-1630513313=:17925" This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-968995931-1630513313=:17925 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT On Wed, 1 Sep 2021, Wei Chen wrote: > Hi Stefano, > > > -----Original Message----- > > From: Xen-devel On Behalf Of > > Stefano Stabellini > > Sent: 2021年9月1日 5:36 > > To: Wei Chen > > Cc: Stefano Stabellini ; xen- > > devel@lists.xenproject.org; julien@xen.org; Bertrand Marquis > > > > Subject: RE: [XEN RFC PATCH 24/40] xen/arm: introduce a helper to parse > > device tree NUMA distance map > > > > On Tue, 31 Aug 2021, Wei Chen wrote: > > > Hi Stefano, > > > > > > > -----Original Message----- > > > > From: Stefano Stabellini > > > > Sent: 2021年8月31日 8:48 > > > > To: Wei Chen > > > > Cc: xen-devel@lists.xenproject.org; sstabellini@kernel.org; > > julien@xen.org; > > > > jbeulich@suse.com; Bertrand Marquis > > > > Subject: Re: [XEN RFC PATCH 24/40] xen/arm: introduce a helper to > > parse > > > > device tree NUMA distance map > > > > > > > > On Wed, 11 Aug 2021, Wei Chen wrote: > > > > > A NUMA aware device tree will provide a "distance-map" node to > > > > > describe distance between any two nodes. This patch introduce a > > > > > new helper to parse this distance map. > > > > > > > > > > Signed-off-by: Wei Chen > > > > > --- > > > > > xen/arch/arm/numa_device_tree.c | 67 > > +++++++++++++++++++++++++++++++++ > > > > > 1 file changed, 67 insertions(+) > > > > > > > > > > diff --git a/xen/arch/arm/numa_device_tree.c > > > > b/xen/arch/arm/numa_device_tree.c > > > > > index bbe081dcd1..6e0d1d3d9f 100644 > > > > > --- a/xen/arch/arm/numa_device_tree.c > > > > > +++ b/xen/arch/arm/numa_device_tree.c > > > > > @@ -200,3 +200,70 @@ device_tree_parse_numa_memory_node(const void > > *fdt, > > > > int node, > > > > > > > > > > return 0; > > > > > } > > > > > + > > > > > +/* Parse NUMA distance map v1 */ > > > > > +int __init > > > > > +device_tree_parse_numa_distance_map_v1(const void *fdt, int node) > > > > > +{ > > > > > + const struct fdt_property *prop; > > > > > + const __be32 *matrix; > > > > > + int entry_count, len, i; > > > > > + > > > > > + printk(XENLOG_INFO "NUMA: parsing numa-distance-map\n"); > > > > > + > > > > > + prop = fdt_get_property(fdt, node, "distance-matrix", &len); > > > > > + if ( !prop ) > > > > > + { > > > > > + printk(XENLOG_WARNING > > > > > + "NUMA: No distance-matrix property in distance- > > map\n"); > > > > > + > > > > > + return -EINVAL; > > > > > + } > > > > > + > > > > > + if ( len % sizeof(uint32_t) != 0 ) > > > > > + { > > > > > + printk(XENLOG_WARNING > > > > > + "distance-matrix in node is not a multiple of > > u32\n"); > > > > > + return -EINVAL; > > > > > + } > > > > > + > > > > > + entry_count = len / sizeof(uint32_t); > > > > > + if ( entry_count <= 0 ) > > > > > + { > > > > > + printk(XENLOG_WARNING "NUMA: Invalid distance-matrix\n"); > > > > > + > > > > > + return -EINVAL; > > > > > + } > > > > > + > > > > > + matrix = (const __be32 *)prop->data; > > > > > + for ( i = 0; i + 2 < entry_count; i += 3 ) > > > > > + { > > > > > + uint32_t from, to, distance; > > > > > + > > > > > + from = dt_read_number(matrix, 1); > > > > > + matrix++; > > > > > + to = dt_read_number(matrix, 1); > > > > > + matrix++; > > > > > + distance = dt_read_number(matrix, 1); > > > > > + matrix++; > > > > > + > > > > > + if ( (from == to && distance != NUMA_LOCAL_DISTANCE) || > > > > > + (from != to && distance <= NUMA_LOCAL_DISTANCE) ) > > > > > + { > > > > > + printk(XENLOG_WARNING > > > > > + "Invalid nodes' distance from node#%d to node#%d > > > > = %d\n", > > > > > + from, to, distance); > > > > > + return -EINVAL; > > > > > + } > > > > > + > > > > > + printk(XENLOG_INFO "NUMA: distance from node#%d to node#%d > > > > = %d\n", > > > > > + from, to, distance); > > > > > + numa_set_distance(from, to, distance); > > > > > + > > > > > + /* Set default distance of node B->A same as A->B */ > > > > > + if (to > from) > > > > > + numa_set_distance(to, from, distance); > > > > > > > > I am a bit unsure about this last 2 lines: why calling > > numa_set_distance > > > > in the opposite direction only when to > from? Wouldn't it be OK to > > > > always do both: > > > > > > > > numa_set_distance(from, to, distance); > > > > numa_set_distance(to, from, distance); > > > > > > > > ? > > > > > > > I borrowed this code from Linux, but here is my understanding: > > > > > > First, I read some notes in Documentation/devicetree/bindings/numa.txt > > > 1. Each entry represents distance from first node to second node. > > > The distances are equal in either direction. > > > 2. distance-matrix should have entries in lexicographical ascending > > > order of nodes. > > > > > > Here is an example of distance-map node in DTB: > > > Sample#1, full list: > > > distance-map { > > > compatible = "numa-distance-map-v1"; > > > distance-matrix = <0 0 10>, > > > <0 1 20>, > > > <0 2 40>, > > > <0 3 20>, > > > <1 0 20>, > > > <1 1 10>, > > > <1 2 20>, > > > <1 3 40>, > > > <2 0 40>, > > > <2 1 20>, > > > <2 2 10>, > > > <2 3 20>, > > > <3 0 20>, > > > <3 1 40>, > > > <3 2 20>, > > > <3 3 10>; > > > }; > > > > > > Call numa_set_distance when "to > from" will prevent Xen to call > > > numa_set_distance(0, 1, 20) again when it's setting distance for <1 0 > > 20>. > > > But, numa_set_distance(1, 0, 20) will be call twice. > > > > > > Normally, distance-map node will be optimized in following sample#2, > > > all redundant entries are removed: > > > Sample#2, partial list: > > > distance-map { > > > compatible = "numa-distance-map-v1"; > > > distance-matrix = <0 0 10>, > > > <0 1 20>, > > > <0 2 40>, > > > <0 3 20>, > > > <1 1 10>, > > > <1 2 20>, > > > <1 3 40>, > > > <2 2 10>, > > > <2 3 20>, > > > <3 3 10>; > > > }; > > > > > > There is not any "from > to" entry in the map. But using this partial > > map > > > still can set all distances for all pairs. And numa_set_distance(1, 0, > > 20) > > > will be only once. > > > > I see. I can't find in Documentation/devicetree/bindings/numa.txt where > > it says that "from > to" nodes can be omitted. If it is not written > > down, then somebody could easily optimize it the opposite way: > > > > distance-matrix = <0 0 10>, > > <1 0 20>, > > <2 0 40>, > > <3 0 20>, > > <1 1 10>, > > <2 1 20>, > > <3 1 40>, > > <2 2 10>, > > <3 2 20>, > > <3 3 10>; > > > > Yes, you're right. Spec doesn't say opposite way is unallowed. > > > I think the code in Xen should be resilient and able to cope with a > > device tree like the one you wrote or the one I wrote. From a code > > perspective, it should be very easy to do. If nothing else it would make > > Xen more resilient against buggy firmware. > > > > > > I don't disagree with that. > > > > > But in any case, I have a different suggestion. The binding states > > that > > > > "distances are equal in either direction". Also it has an example > > where > > > > only one direction is expressed unfortunately (at the end of the > > > > document). > > > > > > > > > > Oh, I should see this comment first, then I will not post above > > > comment : ) > > > > > > > So my suggestion is to parse it as follows: > > > > > > > > - call numa_set_distance just once from > > > > device_tree_parse_numa_distance_map_v1 > > > > > > > > - in numa_set_distance: > > > > - set node_distance_map[from][to] = distance; > > > > - check node_distance_map[to][from] > > > > - if unset, node_distance_map[to][from] = distance; > > > > - if already set to the same value, return success; > > > > - if already set to a different value, return error; > > > > > > I don't really like this implementation. I want the behavior of > > > numa_set_distance just like the function name, do not include > > > implicit operations. Otherwise, except the user read this function > > > implementation before he use it, he probably doesn't know this > > > function has done so many things. > > > > You can leave numa_set_distance as-is without any implicit operations. > > > > In that case, just call numa_set_distance twice from numa_set_distance > > for both from/to and to/from. numa_set_distance could return error is > > I am OK for the first sentence. But... > > > the entry was already set to a different value or success otherwise > > (also in the case it was already set to the same value). This would > > ... I prefer not to check the previous value. Subsequent numa_set_distance > call will override previous calls. Keep numa_set_distance as simple as > it can. And when you pass new data to numa_set_distance, it doesn't > know whether the previous data was correct or the new data is correct. > Only caller may have known. That might be OK but if not numa_set_distance then somebody else needs to check against overwriting previous values. That is to be able to spot bad device tree cases like: 0 1 20 1 0 40 --8323329-968995931-1630513313=:17925-- From xen-devel-bounces@lists.xenproject.org Wed Sep 01 16:25:05 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Sep 2021 16:25:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.176567.321283 (Exim 4.92) (envelope-from ) id 1mLT2u-00055Y-Bn; Wed, 01 Sep 2021 16:25:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 176567.321283; Wed, 01 Sep 2021 16:25:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLT2u-00055R-8e; Wed, 01 Sep 2021 16:25:04 +0000 Received: by outflank-mailman (input) for mailman id 176567; Wed, 01 Sep 2021 16:25:03 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLT2t-000559-NM; Wed, 01 Sep 2021 16:25:03 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLT2t-0006Nk-Dj; Wed, 01 Sep 2021 16:25:03 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLT2t-0004xd-7M; Wed, 01 Sep 2021 16:25:03 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mLT2t-0007F0-6u; Wed, 01 Sep 2021 16:25:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=3GXjwKk1jtgZb8r2OIwTJemQ5cT4UDoIsUDY52UewyE=; b=Rno4H2CnRUzfODlEzp8OQg3DNj UxZWVrEED9Pjp+3mIy4TSOLmhdmHIeorPcIPnArB8uatvOl6HnYzyb73MydS72kUXD5tnu4HgdgPj KZLr9m34juD/vxo1lOk/MjnAGWaM5uvYTOeen9DFRGB+dOb/gLdLGT65GuptsKsPeoFk=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 164704: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=b170806518c1e414939c8b085866544814e1ce8e X-Osstest-Versions-That: ovmf=cae735f61328d64e2e8991036707b9e78c0f5f63 From: osstest service owner Date: Wed, 01 Sep 2021 16:25:03 +0000 flight 164704 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/164704/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 164674 build-amd64-xsm 6 xen-build fail REGR. vs. 164674 build-i386-xsm 6 xen-build fail REGR. vs. 164674 build-i386 6 xen-build fail REGR. vs. 164674 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf b170806518c1e414939c8b085866544814e1ce8e baseline version: ovmf cae735f61328d64e2e8991036707b9e78c0f5f63 Last test of basis 164674 2021-08-31 02:56:52 Z 1 days Failing since 164686 2021-09-01 03:03:43 Z 0 days 3 attempts Testing same since 164695 2021-09-01 10:40:04 Z 0 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Anthony PERARD DunTan Gary Lin Jim Fehlig Lin, Gary (HPS OE-Linux) Mark Wilson Marvin H?user Wenxing Hou jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit b170806518c1e414939c8b085866544814e1ce8e Author: Mark Wilson Date: Fri Nov 13 08:05:18 2020 +0800 UefiCpuPkg: Clean up save state boundary checks and comments. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2956 In functions ReadSaveStateRegisterByIndex and WriteSaveStateRegister: * check width > 4 instead of >= 4 when writing upper 32 bytes. - This improves the code but will not affect functionality. Cc: Eric Dong Reviewed-by: Ray Ni Signed-off-by: Mark Wilson commit 3b3f88228812e2c642eea8746858a4dad928ebf7 Author: Marvin H?user Date: Mon Aug 9 14:09:25 2021 +0800 MdeModulePkg/PiSmmCore: Drop deprecated image profiling commands The legacy codebase allowed SMM images to be registered for profiling from DXE. Support for this has been dropped entirely, so remove the remaining handlers. Cc: Jian J Wang Cc: Hao A Wu Cc: Eric Dong Reviewed-by: Ray Ni Cc: Vitaly Cheptsov Signed-off-by: Marvin H?user commit cdda3f74a1327663a5d48cca13507085ba403af7 Author: Marvin H?user Date: Mon Aug 9 03:39:53 2021 +0800 UefiPayloadPkg/UefiPayloadEntry: Fix memory corruption UefiPayloadEntry's AllocatePool() applies the "sizeof" operator to HOB index rather than the HOB header structure. This yields 4 Bytes compared to the 8 Bytes the structure header requires. Fix the call to allocate the required space instead. Reviewed-by: Guo Dong Reviewed-by: Ray Ni Cc: Maurice Ma Cc: Benjamin You Cc: Vitaly Cheptsov Signed-off-by: Marvin H?user commit 5d34cc49d5d348012fe8acf9fb618826bd541a7c Author: Wenxing Hou Date: Tue Aug 24 16:11:11 2021 +0800 UefiCpuPkg/PiSmmCpuDxeSmm: Update mPatchCetSupported set condition REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3584 Function AsmCpuid should first check the value for Basic CPUID Information. The fix is to update the mPatchCetSupported judgment statement. Signed-off-by: Wenxing Hou Reviewed-by: Ray Ni Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Cc: Sheng W Cc: Yao Jiewen commit f0fe55bca4651734abf1752a1d7c69fb5bee00b9 Author: duntan Date: Fri Aug 20 13:04:29 2021 +0800 UefiPayloadPkg: Fix the build error when enable Core ci for UefiPayloadPkg V1: Add quotes when using $(ARCH) in .dsc and .fdf file. The quotes are added due to the way by which Core ci parse the .dsc file. Add UINTN in Hob.c to fix cast from pointer to integer of different size error. V2: Delete lines which reference ShellBinPkg.The pkg doesn't exist in edk2. Cc: Guo Dong Cc: Ray Ni Cc: Maurice Ma Cc: Benjamin You Signed-off-by: DunTan Reviewed-by: Ray Ni commit 9f3eda177a4b2d4a33ff1b0307cad42906396562 Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:29:48 2021 +0800 OvmfPkg/OvmfXen: add QemuKernelLoaderFsDxe Without QemuKernelLoaderFsDxe, QemuLoadKernelImage() couldn't download the kernel, initrd, and kernel command line from QEMU's fw_cfg. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3574 Signed-off-by: Gary Lin Acked-by: Anthony PERARD Reviewed-by: Philippe Mathieu-Daude Reviewed-by: Gerd Hoffmann Tested-by: Jim Fehlig commit 5b5f10d7465004e3e40ec1f50a3b490b4db595e7 Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:31:15 2021 +0800 OvmfPkg/SmmControl2Dxe: use PcdAcpiS3Enable to detect S3 support To avoid the potential inconsistency between PcdAcpiS3Enable and QemuFwCfgS3Enabled(), this commit modifies SmmControl2Dxe to detect S3 support by PcdAcpiS3Enable as modules in MdeModulePkg do. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3573 Signed-off-by: Gary Lin Reviewed-by: Gerd Hoffmann Reviewed-by: Jiewen Yao Tested-by: Jim Fehlig commit 52e2dabc0f8d3af09c213072ce8ba734302f585d Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:31:14 2021 +0800 OvmfPkg/PlatformBootManagerLib: use PcdAcpiS3Enable to detect S3 support To avoid the potential inconsistency between PcdAcpiS3Enable and QemuFwCfgS3Enabled(), this commit modifies PlatformBootManagerLib to detect S3 support by PcdAcpiS3Enable as modules in MdeModulePkg do. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3573 Signed-off-by: Gary Lin Reviewed-by: Gerd Hoffmann Reviewed-by: Jiewen Yao Tested-by: Jim Fehlig commit 28152333bccb778b62e6e97446b28bfa0e92ef82 Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:31:13 2021 +0800 OvmfPkg/LockBoxLib: use PcdAcpiS3Enable to detect S3 support To avoid the potential inconsistency between PcdAcpiS3Enable and QemuFwCfgS3Enabled(), this commit modifies LockBoxLib to detect S3 support by PcdAcpiS3Enable as modules in MdeModulePkg do. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3573 Signed-off-by: Gary Lin Reviewed-by: Philippe Mathieu-Daude Reviewed-by: Gerd Hoffmann Reviewed-by: Jiewen Yao Tested-by: Jim Fehlig commit cb0d24637dfdd869618b9635dfb8e3b0746393a6 Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:31:12 2021 +0800 OvmfPkg/OvmfXen: set PcdAcpiS3Enable at initialization There are several functions in OvmfPkg/Library using QemuFwCfgS3Enabled() to detect the S3 support status. However, in MdeModulePkg, PcdAcpiS3Enable is used to check S3 support. Since InitializeXenPlatform() didn't set PcdAcpiS3Enable as InitializePlatform() did, this made the inconsistency between drivers/functions. For example, S3SaveStateDxe checked PcdAcpiS3Enable and skipped S3BootScript because the default value is FALSE. On the other hand, PlatformBootManagerBeforeConsole() from OvmfPkg/Library called QemuFwCfgS3Enabled() and found it returned TRUE, so it invoked SaveS3BootScript(). However, S3SaveStateDxe skipped S3BootScript, so SaveS3BootScript() asserted due to EFI_NOT_FOUND. This issue mainly affects "HVM Direct Kernel Boot". When used, "fw_cfg" is enabled in QEMU and QemuFwCfgS3Enabled() returns true in that case. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3573 Signed-off-by: Gary Lin Reviewed-by: Anthony PERARD Reviewed-by: Gerd Hoffmann Reviewed-by: Jiewen Yao Tested-by: Jim Fehlig From xen-devel-bounces@lists.xenproject.org Wed Sep 01 16:26:32 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Sep 2021 16:26:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.176574.321297 (Exim 4.92) (envelope-from ) id 1mLT4J-0005hH-Os; Wed, 01 Sep 2021 16:26:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 176574.321297; Wed, 01 Sep 2021 16:26:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLT4J-0005hA-Lp; Wed, 01 Sep 2021 16:26:31 +0000 Received: by outflank-mailman (input) for mailman id 176574; Wed, 01 Sep 2021 16:26:30 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLT4I-0005gw-AR for xen-devel@lists.xen.org; Wed, 01 Sep 2021 16:26:30 +0000 Received: from mail-wm1-x329.google.com (unknown [2a00:1450:4864:20::329]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 0add8b29-e91e-4907-9b94-66544d7c7a2f; Wed, 01 Sep 2021 16:26:28 +0000 (UTC) Received: by mail-wm1-x329.google.com with SMTP id k20-20020a05600c0b5400b002e87ad6956eso84542wmr.1 for ; Wed, 01 Sep 2021 09:26:28 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0add8b29-e91e-4907-9b94-66544d7c7a2f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=hD6i+Tmn6yQISidhCVyfY7yvCP2yOSJZBebtAHZRXp8=; b=CwvDbyjqE/5U4XrUdyWNPgwHyB8fguYfy6xEzFi3IH08QqKYsTprTFs24eXjfPCF8a ShehDh1Qm/bis30H4x8En2ucFmy//wQL6v8omiNkShASFVlaa2o/31esQtfnNGwKMWID +IINvGanj9JDaUIM4ww8f5noBQvL2l0PakkYoT2VuViWy1V9zmMBA4jy6qw8W63G/TrP 0bXzpe42VGXPnbah1UHS6yiZNNyzT1w0UKqAa9SE2wHTouHAjz+pPxz4I/EFBCZJOnkc 0zf/6X8gwHuAFja90RBn+fFOMr3IiNSFB+p24nrVd/lUFuVS1gx035Qjv5VfEBgssWAq Ls7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hD6i+Tmn6yQISidhCVyfY7yvCP2yOSJZBebtAHZRXp8=; b=qj6HsWGv4ojU4LfqMsSCAeVaFuyme0mqlrlv3+eIHwfS3fTdT5i+m1K7wgJLPtvuMf Y7gOuLlCakjBiJmYviuRXUdPfgahFCFZWmy6DVl1yXp/NATVgMMgrK8SArOn7mO59mxL 39u+o+a1H4gQWS+kcH93rWiElh15FgwsRQOGRae4yiuz07RpmOF+cRl2wQvNdXNn+Tgy VbU+hcrFI0zGYNaYlqt1ncZXsFRwmEf6ByxK9L40kykU06x33Gusovar+4veIgvuZtYi 6EBuadbYLJsVzCGFv2kMbEy7ls5ERKohLypBjpgvsItnSnChXXLmR+GRJadficQRjvyB 82WA== X-Gm-Message-State: AOAM5327NqANsbPjWpcx1Dk2OWcHaR5J6ftsSXOoAYapVCYsDADsxLPb Fy5XuowL2V3+38vFFqZhcRn1wqdBDK4BidCzvUM= X-Google-Smtp-Source: ABdhPJxysw6v03n5aApJo8ZcR8hFITSnVlLB+2zC4NsLIOHNVJn4JcLUuEUjcZXwFCHikApOxhJ1pTdAJ66vKauC56c= X-Received: by 2002:a1c:a181:: with SMTP id k123mr378799wme.90.1630513587810; Wed, 01 Sep 2021 09:26:27 -0700 (PDT) MIME-Version: 1.0 References: <20210817080757.GC43203@laputa> <20210818053840.GE39588@laputa> <20210820064150.GC13452@laputa> <20210826094047.GA55218@laputa> <20210831061805.GB69817@laputa> <20210901122910.GA100270@laputa> In-Reply-To: <20210901122910.GA100270@laputa> From: Oleksandr Tyshchenko Date: Wed, 1 Sep 2021 19:26:16 +0300 Message-ID: Subject: Re: Enabling hypervisor agnosticism for VirtIO backends To: AKASHI Takahiro Cc: Wei Chen , Stefano Stabellini , "Alex Benn??e" , Kaly Xin , Stratos Mailing List , "virtio-dev@lists.oasis-open.org" , Arnd Bergmann , Viresh Kumar , Stefano Stabellini , "stefanha@redhat.com" , Jan Kiszka , Carl van Schaik , "pratikp@quicinc.com" , Srivatsa Vaddagiri , Jean-Philippe Brucker , Mathieu Poirier , Oleksandr Tyshchenko , Bertrand Marquis , Artem Mygaiev , Julien Grall , Juergen Gross , Paul Durrant , nd , Xen Devel Content-Type: multipart/alternative; boundary="00000000000033f5d805caf1878f" --00000000000033f5d805caf1878f Content-Type: text/plain; charset="UTF-8" Hi Akashi, I am sorry for the possible format issues. > > > > > > > > > It's a RFC discussion. We have tested this RFC patch internally. > > > > https://lists.xenproject.org/archives/html/xen-devel/2021- > > > 07/msg01532.html > > > > > > I'm afraid that I miss something here, but I don't know > > > why this proposed API will lead to eliminating 'mmap' in accessing > > > the queued payload at every request? > > > > > > > This API give Xen device model (QEMU or kvmtool) the ability to map > > whole guest RAM in device model's address space. In this case, device > > model doesn't need dynamic hypercall to map/unmap payload memory. > > It can use a flat offset to access payload memory in its address > > space directly. Just Like KVM device model does now. > Yes! > > Thank you. Quickly, let me make sure one thing: > This API itself doesn't do any mapping operations, right? Right. The only purpose of that "API" is to guery hypervisor to find unallocated address space ranges to map the foreign pages into (instead of stealing real RAM pages), In a nutshell, if you try to map the whole guest memory in the backend address space on Arm (or even cache some mappings) you might end up with memory exhaustion in the backend domain (XSA-300), and the possibility to hit XSA-300 is higher if your backend needs to serve several Guests. Of course, this depends on the memory assigned to the backend domain and to the Guest(s) it serves... We believe that with the proposed solution the backend will be able to handle Guest(s) without wasting it's real RAM. However, please note that proposed Xen + Linux changes which are on review now [1] are far from the final solution and require rework and some prereq work to operate in a proper and safe way. > > So I suppose that virtio BE guest is responsible to > 1) fetch the information about all the memory regions in FE, > 2) call this API to allocate a big chunk of unused space in BE, > 3) create grant/foreign mappings for FE onto this region(S) > in the initialization/configuration of emulated virtio devices. > > Is this the way this API is expected to be used? > No really, the userspace backend doesn't need to call this API at all, all what backend calls is still xenforeignmemory_map()/xenforeignmemory_unmap(), so let's say "magic" is done by Linux and Xen internally. You can take a look at the virtio-disk PoC [2] (last 4 patches) to better understand what Wei and I are talking about. There we map the Guest memory at the beginning and just calculate a pointer at runtime. Again, the code is not in good shape, but it is enough to demonstrate the feasibility of the improvement. > Does Xen already has an interface for (1)? > I am not aware of anything existing. For the PoC I guessed the Guest memory layout in a really hackish way (I got total Guest memory size, so having GUEST_RAMX_BASE/GUEST_RAMX_SIZE in hand just performed calculation). Definitely, it is a no-go, so 1) deserves additional discussion/design. [1] https://lore.kernel.org/xen-devel/1627489110-25633-1-git-send-email-olekstysh@gmail.com/ https://lore.kernel.org/lkml/1627490656-1267-1-git-send-email-olekstysh@gmail.com/ https://lore.kernel.org/lkml/1627490656-1267-2-git-send-email-olekstysh@gmail.com/ [2] https://github.com/otyshchenko1/virtio-disk/commits/map_opt_next -- Regards, Oleksandr Tyshchenko --00000000000033f5d805caf1878f Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Hi Akashi,

<= /div>
I am sorry for the possible format issues.

=

> > >
> > > It's a RFC discussion. We have tested this RFC patch int= ernally.
> > > https://lists.xenproject.or= g/archives/html/xen-devel/2021-
> > 07/msg01532.html
> >
> > I'm afraid that I miss something here, but I don't know > > why this proposed API will lead to eliminating 'mmap' in = accessing
> > the queued payload at every request?
> >
>
> This API give Xen device model (QEMU or kvmtool) the ability to map > whole guest RAM in device model's address space. In this case, dev= ice
> model doesn't need dynamic hypercall to map/unmap payload memory.<= br> > It can use a flat offset to access payload memory in its address
> space directly. Just Like KVM device model does now.
<= div>Yes!
=C2=A0

Thank you. Quickly, let me make sure one thing:
This API itself doesn't do any mapping operations, right?
<= div>=C2=A0
Right. The only purpose of that "API" is to = guery hypervisor to find unallocated address space ranges to map the foreig= n pages into (instead of stealing real RAM pages),
In a nutshell,= if you try to map the whole guest memory in the backend address space on A= rm (or even cache some mappings) you might end up with memory exhaustion in= the backend domain (XSA-300),
and the possibility to hit XSA-300= is higher if your backend needs to serve several Guests. Of course, this d= epends on the memory assigned to the backend domain and to the Guest(s) it = serves...
We believe that with the proposed solution the backend = will be able to handle Guest(s) without wasting it's real RAM. However,= please note that proposed Xen=C2=A0+ Linux changes which are on review now= [1] are far from the final solution and require rework and some prereq wor= k to operate in a proper and safe way.
=C2=A0

So I suppose that virtio BE guest is responsible to
1) fetch the information about all the memory regions in FE,
2) call this API to allocate a big chunk of unused space in BE,
3) create grant/foreign mappings for FE onto this region(S)
in the initialization/configuration of emulated virtio devices.

Is this the way this API is expected to be used?
=C2= =A0
No really, the userspace backend doesn't need to call thi= s API at all, all what backend calls is still xenforeignmemory_map()/xenfor= eignmemory_unmap(), so let's say "magic" is done by Linux and= Xen internally.
You can take a look at the virtio-disk PoC [2] (= last 4 patches) to better understand what Wei and I are talking about. Ther= e we map the Guest memory at the beginning and just calculate a pointer at = runtime. Again, the code
is not in good shape, but it is enough t= o demonstrate the feasibility of the improvement.

= =C2=A0
Does Xen already has an interface for (1)?
=C2=A0
I am not aware of anything existing. For the PoC I guessed the Guest = memory layout in a really hackish way (I got total Guest memory size, so ha= ving GUEST_RAMX_BASE/GUEST_RAMX_SIZE in hand just performed calculation). D= efinitely, it is a no-go, so 1) deserves additional discussion/design.

[2]=C2=A0
--
Regards,

Oleksandr Tyshchenk= o
--00000000000033f5d805caf1878f-- From xen-devel-bounces@lists.xenproject.org Wed Sep 01 17:52:17 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Sep 2021 17:52:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.176591.321337 (Exim 4.92) (envelope-from ) id 1mLUOa-0008C8-6W; Wed, 01 Sep 2021 17:51:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 176591.321337; Wed, 01 Sep 2021 17:51:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLUOa-0008C1-3f; Wed, 01 Sep 2021 17:51:32 +0000 Received: by outflank-mailman (input) for mailman id 176591; Wed, 01 Sep 2021 17:51:30 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLUOY-0008Bo-G6; Wed, 01 Sep 2021 17:51:30 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLUOY-0007q7-AT; Wed, 01 Sep 2021 17:51:30 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLUOY-0001lK-39; Wed, 01 Sep 2021 17:51:30 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mLUOY-0004yd-2f; Wed, 01 Sep 2021 17:51:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Message-Id:Subject:To; bh=gVoODzvwTLgF6rGhJdmnqDDgXPX/Bg3PyRE+sZLd31s=; b=V2mJHWxwXFV48lJvuqa0bB2/Kg 8/1tM9Lxr/zNaUBCluYVUCrcAlJkq+8oWf1mu4BntOMWxgPQ9X7l6i/T4v0F0YjJE1u1UL2Qt9xSv Okw0N6StTWhi3T5StKBHk+Hc6p57Hx6sqte9ac0Pj0f9D3vTA7bJbs8DEe8pwgmLXaiY=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Subject: [ovmf bisection] complete build-amd64-xsm Message-Id: From: osstest service owner Date: Wed, 01 Sep 2021 17:51:30 +0000 branch xen-unstable xenbranch xen-unstable job build-amd64-xsm testid xen-build Tree: ovmf https://github.com/tianocore/edk2.git Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git Tree: qemuu git://xenbits.xen.org/qemu-xen.git Tree: seabios git://xenbits.xen.org/osstest/seabios.git Tree: xen git://xenbits.xen.org/xen.git *** Found and reproduced problem changeset *** Bug is in tree: ovmf https://github.com/tianocore/edk2.git Bug introduced: 9f3eda177a4b2d4a33ff1b0307cad42906396562 Bug not present: 5b5f10d7465004e3e40ec1f50a3b490b4db595e7 Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/164722/ commit 9f3eda177a4b2d4a33ff1b0307cad42906396562 Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:29:48 2021 +0800 OvmfPkg/OvmfXen: add QemuKernelLoaderFsDxe Without QemuKernelLoaderFsDxe, QemuLoadKernelImage() couldn't download the kernel, initrd, and kernel command line from QEMU's fw_cfg. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3574 Signed-off-by: Gary Lin Acked-by: Anthony PERARD Reviewed-by: Philippe Mathieu-Daude Reviewed-by: Gerd Hoffmann Tested-by: Jim Fehlig For bisection revision-tuple graph see: http://logs.test-lab.xenproject.org/osstest/results/bisect/ovmf/build-amd64-xsm.xen-build.html Revision IDs in each graph node refer, respectively, to the Trees above. ---------------------------------------- Running cs-bisection-step --graph-out=/home/logs/results/bisect/ovmf/build-amd64-xsm.xen-build --summary-out=tmp/164722.bisection-summary --basis-template=164674 --blessings=real,real-bisect,real-retry ovmf build-amd64-xsm xen-build Searching for failure / basis pass: 164704 fail [host=himrod2] / 164674 ok. Failure / basis pass flights: 164704 / 164674 (tree with no url: minios) Tree: ovmf https://github.com/tianocore/edk2.git Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git Tree: qemuu git://xenbits.xen.org/qemu-xen.git Tree: seabios git://xenbits.xen.org/osstest/seabios.git Tree: xen git://xenbits.xen.org/xen.git Latest b170806518c1e414939c8b085866544814e1ce8e 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 136c34c9bc4179dc64b15b2bb5f0c54ca4ddf823 54082c81d96028ba8c76fbe6784085cf1df76b20 a931e8e64af07bd333a31f3b71a3f8f3e7910857 Basis pass cae735f61328d64e2e8991036707b9e78c0f5f63 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 136c34c9bc4179dc64b15b2bb5f0c54ca4ddf823 54082c81d96028ba8c76fbe6784085cf1df76b20 a931e8e64af07bd333a31f3b71a3f8f3e7910857 Generating revisions with ./adhoc-revtuple-generator https://github.com/tianocore/edk2.git#cae735f61328d64e2e8991036707b9e78c0f5f63-b170806518c1e414939c8b085866544814e1ce8e git://xenbits.xen.org/qemu-xen-traditional.git#3d273dd05e51e5a1ffba3d98c7437ee84e8f8764-3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 git://xenbits.xen.org/qemu-xen.git#136c34c9bc4179dc64b15b2bb5f0c54ca4ddf823-136c34c9bc4179dc64b15b2bb5f0c54ca4ddf823 git://xenbits.xen.org/osstest/seabios.git#54082c81d96028ba8c76fbe6784085cf1df76b\ 20-54082c81d96028ba8c76fbe6784085cf1df76b20 git://xenbits.xen.org/xen.git#a931e8e64af07bd333a31f3b71a3f8f3e7910857-a931e8e64af07bd333a31f3b71a3f8f3e7910857 Loaded 5001 nodes in revision graph Searching for test results: 164674 pass cae735f61328d64e2e8991036707b9e78c0f5f63 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 136c34c9bc4179dc64b15b2bb5f0c54ca4ddf823 54082c81d96028ba8c76fbe6784085cf1df76b20 a931e8e64af07bd333a31f3b71a3f8f3e7910857 164686 [host=himrod1] 164695 fail b170806518c1e414939c8b085866544814e1ce8e 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 136c34c9bc4179dc64b15b2bb5f0c54ca4ddf823 54082c81d96028ba8c76fbe6784085cf1df76b20 a931e8e64af07bd333a31f3b71a3f8f3e7910857 164711 pass cae735f61328d64e2e8991036707b9e78c0f5f63 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 136c34c9bc4179dc64b15b2bb5f0c54ca4ddf823 54082c81d96028ba8c76fbe6784085cf1df76b20 a931e8e64af07bd333a31f3b71a3f8f3e7910857 164712 fail b170806518c1e414939c8b085866544814e1ce8e 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 136c34c9bc4179dc64b15b2bb5f0c54ca4ddf823 54082c81d96028ba8c76fbe6784085cf1df76b20 a931e8e64af07bd333a31f3b71a3f8f3e7910857 164713 fail 9f3eda177a4b2d4a33ff1b0307cad42906396562 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 136c34c9bc4179dc64b15b2bb5f0c54ca4ddf823 54082c81d96028ba8c76fbe6784085cf1df76b20 a931e8e64af07bd333a31f3b71a3f8f3e7910857 164714 pass 28152333bccb778b62e6e97446b28bfa0e92ef82 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 136c34c9bc4179dc64b15b2bb5f0c54ca4ddf823 54082c81d96028ba8c76fbe6784085cf1df76b20 a931e8e64af07bd333a31f3b71a3f8f3e7910857 164715 pass 52e2dabc0f8d3af09c213072ce8ba734302f585d 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 136c34c9bc4179dc64b15b2bb5f0c54ca4ddf823 54082c81d96028ba8c76fbe6784085cf1df76b20 a931e8e64af07bd333a31f3b71a3f8f3e7910857 164704 fail b170806518c1e414939c8b085866544814e1ce8e 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 136c34c9bc4179dc64b15b2bb5f0c54ca4ddf823 54082c81d96028ba8c76fbe6784085cf1df76b20 a931e8e64af07bd333a31f3b71a3f8f3e7910857 164716 pass 5b5f10d7465004e3e40ec1f50a3b490b4db595e7 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 136c34c9bc4179dc64b15b2bb5f0c54ca4ddf823 54082c81d96028ba8c76fbe6784085cf1df76b20 a931e8e64af07bd333a31f3b71a3f8f3e7910857 164717 fail 9f3eda177a4b2d4a33ff1b0307cad42906396562 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 136c34c9bc4179dc64b15b2bb5f0c54ca4ddf823 54082c81d96028ba8c76fbe6784085cf1df76b20 a931e8e64af07bd333a31f3b71a3f8f3e7910857 164719 pass 5b5f10d7465004e3e40ec1f50a3b490b4db595e7 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 136c34c9bc4179dc64b15b2bb5f0c54ca4ddf823 54082c81d96028ba8c76fbe6784085cf1df76b20 a931e8e64af07bd333a31f3b71a3f8f3e7910857 164720 fail 9f3eda177a4b2d4a33ff1b0307cad42906396562 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 136c34c9bc4179dc64b15b2bb5f0c54ca4ddf823 54082c81d96028ba8c76fbe6784085cf1df76b20 a931e8e64af07bd333a31f3b71a3f8f3e7910857 164721 pass 5b5f10d7465004e3e40ec1f50a3b490b4db595e7 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 136c34c9bc4179dc64b15b2bb5f0c54ca4ddf823 54082c81d96028ba8c76fbe6784085cf1df76b20 a931e8e64af07bd333a31f3b71a3f8f3e7910857 164722 fail 9f3eda177a4b2d4a33ff1b0307cad42906396562 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 136c34c9bc4179dc64b15b2bb5f0c54ca4ddf823 54082c81d96028ba8c76fbe6784085cf1df76b20 a931e8e64af07bd333a31f3b71a3f8f3e7910857 Searching for interesting versions Result found: flight 164674 (pass), for basis pass For basis failure, parent search stopping at 5b5f10d7465004e3e40ec1f50a3b490b4db595e7 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 136c34c9bc4179dc64b15b2bb5f0c54ca4ddf823 54082c81d96028ba8c76fbe6784085cf1df76b20 a931e8e64af07bd333a31f3b71a3f8f3e7910857, results HASH(0x561910c2bd50) HASH(0x561910c2f580) HASH(0x561910c33110) For basis failure, parent search stopping at 52e2dabc0f8d3af09c213072ce8ba734302f585d 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 136c34c9bc4179dc64b15b2bb5f0c54ca4ddf823 54082c81d\ 96028ba8c76fbe6784085cf1df76b20 a931e8e64af07bd333a31f3b71a3f8f3e7910857, results HASH(0x561910c27ec0) For basis failure, parent search stopping at 28152333bccb778b62e6e97446b28bfa0e92ef82 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 136c34c9bc4179dc64b15b2bb5f0c54ca4ddf823 54082c81d96028ba8c76fbe6784085cf1df76b20 a931e8e64af07bd333a31f3b71a3f8f3e7910857, results HASH(0x561910c26c98) For basis failure, parent search stopping at cae735f61328d64e2e8991036707b9e78c0f5f63 3d273dd05e51e5a1ffba3d98c7437ee\ 84e8f8764 136c34c9bc4179dc64b15b2bb5f0c54ca4ddf823 54082c81d96028ba8c76fbe6784085cf1df76b20 a931e8e64af07bd333a31f3b71a3f8f3e7910857, results HASH(0x561910c19838) HASH(0x561910c20178) Result found: flight 164695 (fail), for basis failure (at ancestor ~5000) Repro found: flight 164711 (pass), for basis pass Repro found: flight 164712 (fail), for basis failure 0 revisions at 5b5f10d7465004e3e40ec1f50a3b490b4db595e7 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 136c34c9bc4179dc64b15b2bb5f0c54ca4ddf823 54082c81d96028ba8c76fbe6784085cf1df76b20 a931e8e64af07bd333a31f3b71a3f8f3e7910857 No revisions left to test, checking graph state. Result found: flight 164716 (pass), for last pass Result found: flight 164717 (fail), for first failure Repro found: flight 164719 (pass), for last pass Repro found: flight 164720 (fail), for first failure Repro found: flight 164721 (pass), for last pass Repro found: flight 164722 (fail), for first failure *** Found and reproduced problem changeset *** Bug is in tree: ovmf https://github.com/tianocore/edk2.git Bug introduced: 9f3eda177a4b2d4a33ff1b0307cad42906396562 Bug not present: 5b5f10d7465004e3e40ec1f50a3b490b4db595e7 Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/164722/ commit 9f3eda177a4b2d4a33ff1b0307cad42906396562 Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:29:48 2021 +0800 OvmfPkg/OvmfXen: add QemuKernelLoaderFsDxe Without QemuKernelLoaderFsDxe, QemuLoadKernelImage() couldn't download the kernel, initrd, and kernel command line from QEMU's fw_cfg. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3574 Signed-off-by: Gary Lin Acked-by: Anthony PERARD Reviewed-by: Philippe Mathieu-Daude Reviewed-by: Gerd Hoffmann Tested-by: Jim Fehlig Revision graph left in /home/logs/results/bisect/ovmf/build-amd64-xsm.xen-build.{dot,ps,png,html,svg}. ---------------------------------------- 164722: tolerable ALL FAIL flight 164722 ovmf real-bisect [real] http://logs.test-lab.xenproject.org/osstest/logs/164722/ Failures :-/ but no regressions. Tests which did not succeed, including tests which could not be run: build-amd64-xsm 6 xen-build fail baseline untested jobs: build-amd64-xsm fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary From xen-devel-bounces@lists.xenproject.org Wed Sep 01 17:54:45 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Sep 2021 17:54:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.176600.321355 (Exim 4.92) (envelope-from ) id 1mLURZ-0000VJ-Tb; Wed, 01 Sep 2021 17:54:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 176600.321355; Wed, 01 Sep 2021 17:54:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLURZ-0000VC-QS; Wed, 01 Sep 2021 17:54:37 +0000 Received: by outflank-mailman (input) for mailman id 176600; Wed, 01 Sep 2021 17:54:36 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLURY-0000V6-Mt for xen-devel@lists.xenproject.org; Wed, 01 Sep 2021 17:54:36 +0000 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id ab1c3152-0b4d-11ec-ae10-12813bfff9fa; Wed, 01 Sep 2021 17:54:35 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 8F05D61075; Wed, 1 Sep 2021 17:54:34 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ab1c3152-0b4d-11ec-ae10-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1630518875; bh=DUYclV0TShbbiOecFDX12GrrUJ+2Px1HUu7Ti14aY7A=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=E/2Vg2VmQYMX33ke1fDrCFkwKZAxJiN07iIg7F/Lw3A5A97UTDBL8QL0IWyGAAaad Qj0R5EgohIYcg8WgHWVmxum+RofseXOscq8E/5hbyH54C+R2AaoOwumNen4Ub0kAJ8 5YjZnIzHoSlg/8HWICwcCGkJwLWYXK7zA6oJyCk1+pFwLbFvEwglkX2FgiWDZWuALM YPQGNCgjokyYQMI8MRw8uhV37qch7VwfBEqPavXymiSO28qEc9O/YPx04aF4JW0tLv 9+YTAvxhdRcSQTgEOXkAHSFv0o3pIf/z0/9pF/OF/aTgss9pq4iuYZ9G/wOa4nOzr6 bYD2V6CfSvYRQ== Date: Wed, 1 Sep 2021 10:54:33 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: Julien Grall cc: Bertrand Marquis , Michal Orzel , "xen-devel@lists.xenproject.org" , Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Stefano Stabellini , Wei Liu , Volodymyr Babchuk Subject: Re: [PATCH] xen/arm: Introduce pmu_access parameter In-Reply-To: <46e36ba5-8b3d-2d43-6297-b92d2654ab72@xen.org> Message-ID: References: <20210901124308.31573-1-michal.orzel@arm.com> <599515f0-4b8a-3a71-caea-b17ec27c9123@xen.org> <44B48162-EB44-4295-9629-2D95A40D7232@arm.com> <46e36ba5-8b3d-2d43-6297-b92d2654ab72@xen.org> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: multipart/mixed; BOUNDARY="8323329-93430960-1630518639=:17925" Content-ID: This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-93430960-1630518639=:17925 Content-Type: text/plain; CHARSET=UTF-8 Content-Transfer-Encoding: 8BIT Content-ID: On Wed, 1 Sep 2021, Julien Grall wrote: > On 01/09/2021 14:10, Bertrand Marquis wrote: > > > On 1 Sep 2021, at 13:55, Julien Grall wrote: > > > > > > Hi, > > > > > > On 01/09/2021 13:43, Michal Orzel wrote: > > > > Introduce new Xen command line parameter called "pmu_access". > > > > The default value is "trap": Xen traps PMU accesses. > > > > In case of setting pmu_access to "native", Xen does not trap > > > > PMU accesses allowing all the guests to access PMU registers. > > > > However, guests cannot make use of PMU overflow interrupts as > > > > PMU uses PPI which Xen cannot route to guests. > > > > This option is only intended for development and testing purposes. > > > > Do not use this in production system. > > > I am afraid your option is not safe even in development system as a vCPU > > > may move between pCPUs. > > > > > > However, even if we restricted the use to pinned vCPU *and* dedicated > > > pCPU, I am not convinced that exposing an half backed PMU (the overflow > > > interrupt would not work) to the guest is the right solution. This likely > > > means the guest OS would need to be modified and therefore the usage of > > > this option is fairly limited. > > > > > > So I think the first steps are: > > > 1) Make the PPI work. There was some attempt in the past for it on > > > xen-devel. You could have a look. > > > 2) Provide PMU bindings > > > > > > With that in place, we can discuss how to expose the PMU even if it is > > > unsafe in some conditions. > > > > With those limitations, using the PMU to monitor the system performances or > > on some specific use cases is still really useful. > > We are using that to do some benchmarks of Xen or of some applications to > > compare the behaviour to a native system or > > analyse the performances of Xen itself (hypercalls,context switch …etc) I also already had to write a patch almost exactly like this one to provide to customers a few months back. > I understand this is useful for some setup and I am not trying to say we > should not have a way to expose the PMU (even unsafely) in upstream. However, > I think the option as it stands is too wide (this should be a per domain knob) > and we should properly expose the PMU (interrupts, bindings...). I have never used PMU directly myself, only provided a patch similar to this one. But as far as I could tell the users were fully satisfied with it and it had no interrupts support either. Could it be that interrupts are not actually needed to read the perf counters, which is probably what users care about? In regards to "this should be a per domain knob", in reality if you are doing PMU experiments you don't care if only one or all domains have access: you are working in a controlled environment trying to figure out if your setup meets the timing requirements. There are no security or safety concerns (those are different experiments) and there is no interference problems in the sense of multiple domains trying to access PMU at the same time -- you control the domains you decide which one is accessing them. So I am in favor of a patch like this one because it actually satisfy our requirements. Even if we had per-domain support and interrupts support, I don't think they would end up being used. --8323329-93430960-1630518639=:17925-- From xen-devel-bounces@lists.xenproject.org Wed Sep 01 18:11:36 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Sep 2021 18:11:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.176607.321366 (Exim 4.92) (envelope-from ) id 1mLUhk-0003B3-Bx; Wed, 01 Sep 2021 18:11:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 176607.321366; Wed, 01 Sep 2021 18:11:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLUhk-0003Aw-8o; Wed, 01 Sep 2021 18:11:20 +0000 Received: by outflank-mailman (input) for mailman id 176607; Wed, 01 Sep 2021 18:11:19 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLUhi-0003AX-W8 for xen-devel@lists.xenproject.org; Wed, 01 Sep 2021 18:11:19 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLUhi-0008Fy-NV; Wed, 01 Sep 2021 18:11:18 +0000 Received: from [54.239.6.187] (helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1mLUhi-0000v1-HK; Wed, 01 Sep 2021 18:11:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=icnWcTlQp/oE8mUZ05u+b5+ihbagLiHOfp5+wRHA+Gc=; b=ZXdspewTVPJE5qslYe9D6qFmL2 lv3B7YG6jLU5MkHS2IRcnpiiL6EVEEvykaBV6Mu+ns+7kg2AsTdaLsbalT5KF8OdiT/dVcJchCVBy LrA48cP23cRl/urp4BWc6GQOOrYUTq6bifGG/k6xxKNq3kJ9nXABAqL9SH6dNMTp9SDo=; Subject: Re: vcpu_show_execution_state() difference between Arm and x86 To: Jan Beulich , Stefano Stabellini , Andrew Cooper Cc: "xen-devel@lists.xenproject.org" References: <85dc06ff-04df-2148-81c5-26bd25d1142f@suse.com> From: Julien Grall Message-ID: <8f295eeb-e8f2-a115-3f83-60922d0fe5f9@xen.org> Date: Wed, 1 Sep 2021 19:11:15 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <85dc06ff-04df-2148-81c5-26bd25d1142f@suse.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit On 01/09/2021 14:39, Jan Beulich wrote: > All, > > back in 2016 Andrew added code to x86'es variant to avoid interleaving > of output. The same issue ought to exist on Arm. Agree. I guess we got away so far because it is pretty rare to have two CPUs running at the same. > The lock acquired, > or more importantly the turning off of IRQs while doing so, is now > getting in the way of having PVH Dom0's state dumped the 2nd time. I am not quite too sure to understand the problem with PVH dom0. Do you have a pointer to the issue? > For > register state I did find a sufficiently simple (yet not pretty) > workaround. For the stack, where I can't reasonably avoid using p2m > functions, this is going to be more difficult. > > Since I expect Arm to want to also have interleave protection at some > point, and since Arm also acquires the p2m lock while accessing Dom0's > stacks, I wonder whether anyone has any clever idea on how to avoid > the (valid) triggering of check_lock()'s assertion without intrusive > changes. (As to intrusive changes - acquiring the p2m lock up front in > recursive mode, plus silencing check_lock() for nested acquires of a > lock that's already being held by a CPU was my initial idea.) At least one Arm, the P2M lock is a rwlock which is not yet recursive. But then it feels to me that this solution is only going to cause us more trouble in the future. I looked at the original commit to find out the reason to use the console lock. AFAICT, this was to allow console_force_unlock() to work properly. But it is not entirely clear why we couldn't get a new lock (with IRQ enabled) that could be forced unlocked in that function. Can either you or Andrew clarify it? The other solution I can think off is buffering the output for show_registers and only print it once at the end. The downside is we may not get any output if there is an issue in the middle of the dump. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Sep 01 18:31:12 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Sep 2021 18:31:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.176616.321377 (Exim 4.92) (envelope-from ) id 1mLV0j-00060G-8T; Wed, 01 Sep 2021 18:30:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 176616.321377; Wed, 01 Sep 2021 18:30:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLV0j-000609-5Y; Wed, 01 Sep 2021 18:30:57 +0000 Received: by outflank-mailman (input) for mailman id 176616; Wed, 01 Sep 2021 18:30:56 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLV0h-000603-Ve for xen-devel@lists.xenproject.org; Wed, 01 Sep 2021 18:30:55 +0000 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 1d05f4a3-0a22-45c4-9358-3b17bc4240e3; Wed, 01 Sep 2021 18:30:54 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 0DE5461090; Wed, 1 Sep 2021 18:30:54 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1d05f4a3-0a22-45c4-9358-3b17bc4240e3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1630521054; bh=PI67GhDQWWeYIukosO0exq6kkx/XCvPBL+4kl7aUjaQ=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=j+oevX6Pi+xFWQOjT69dJfBnwrbu/z0PbpQySvHDFCre2oH+paWL4Fe7TLqvN6UuF f1Od+l5IlLHWQMkRfeg/M2/Lti0gNJAMEcsjQkplFAy2kKkjhHrJj6AIAdUx1fGkLa p7gCUYYALULKL0cFZH0GP2Ax/nAvtxSNsVLPTYRrQXPJj8gLHiT4IfIMMl1IZZiBz+ VxYqdYrmSu61YiwZajWJEE5wxt3RdAB3uVcT1Bme9O8Fp8O3RQZsp6/w9rYOT+CoDq t2neVELFFfn4QgVyl64mu7W2Pbq68qFp19Z5su2+cL56cDlcovkhuJy4c3+cwK1buN m7LEcmGY0mADA== Date: Wed, 1 Sep 2021 11:30:53 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: Julien Grall cc: Stefano Stabellini , Wei Chen , xen-devel@lists.xenproject.org, jbeulich@suse.com, Bertrand.Marquis@arm.com Subject: Re: [XEN RFC PATCH 25/40] xen/arm: unified entry to parse all NUMA data from device tree In-Reply-To: <088e4b16-afea-8248-55f1-a081bba7f80c@xen.org> Message-ID: References: <20210811102423.28908-1-wei.chen@arm.com> <20210811102423.28908-26-wei.chen@arm.com> <088e4b16-afea-8248-55f1-a081bba7f80c@xen.org> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Tue, 31 Aug 2021, Julien Grall wrote: > Hi Stefano, > > On 31/08/2021 01:54, Stefano Stabellini wrote: > > On Wed, 11 Aug 2021, Wei Chen wrote: > > > In this API, we scan whole device tree to parse CPU node id, memory > > > node id and distance-map. Though early_scan_node will invoke has a > > > handler to process memory nodes. If we want to parse memory node id > > > in this handler, we have to embeded NUMA parse code in this handler. > > > But we still need to scan whole device tree to find CPU NUMA id and > > > distance-map. In this case, we include memory NUMA id parse in this > > > API too. Another benefit is that we have a unique entry for device > > > tree NUMA data parse. > > > > > > Signed-off-by: Wei Chen > > > --- > > > xen/arch/arm/numa_device_tree.c | 31 ++++++++++++++++++++++++++++--- > > > xen/include/asm-arm/numa.h | 1 + > > > 2 files changed, 29 insertions(+), 3 deletions(-) > > > > > > diff --git a/xen/arch/arm/numa_device_tree.c > > > b/xen/arch/arm/numa_device_tree.c > > > index 6e0d1d3d9f..27ffb72f7b 100644 > > > --- a/xen/arch/arm/numa_device_tree.c > > > +++ b/xen/arch/arm/numa_device_tree.c > > > @@ -131,7 +131,8 @@ save_memblk: > > > } > > > /* Parse CPU NUMA node info */ > > > -int __init device_tree_parse_numa_cpu_node(const void *fdt, int node) > > > +static int __init > > > +device_tree_parse_numa_cpu_node(const void *fdt, int node) > > > { > > > uint32_t nid; > > > @@ -147,7 +148,7 @@ int __init device_tree_parse_numa_cpu_node(const > > > void *fdt, int node) > > > } > > > /* Parse memory node NUMA info */ > > > -int __init > > > +static int __init > > > device_tree_parse_numa_memory_node(const void *fdt, int node, > > > const char *name, uint32_t addr_cells, uint32_t size_cells) > > > { > > > @@ -202,7 +203,7 @@ device_tree_parse_numa_memory_node(const void *fdt, > > > int node, > > > } > > > /* Parse NUMA distance map v1 */ > > > -int __init > > > +static int __init > > > device_tree_parse_numa_distance_map_v1(const void *fdt, int node) > > > { > > > const struct fdt_property *prop; > > > @@ -267,3 +268,27 @@ device_tree_parse_numa_distance_map_v1(const void > > > *fdt, int node) > > > return 0; > > > } > > > + > > > +static int __init fdt_scan_numa_nodes(const void *fdt, > > > + int node, const char *uname, int depth, > > > + u32 address_cells, u32 size_cells, void *data) > > > +{ > > > + int ret = 0; > > > + > > > + if ( fdt_node_check_type(fdt, node, "cpu") == 0 ) > > > + ret = device_tree_parse_numa_cpu_node(fdt, node); > > > + else if ( fdt_node_check_type(fdt, node, "memory") == 0 ) > > > + ret = device_tree_parse_numa_memory_node(fdt, node, uname, > > > + address_cells, size_cells); > > > + else if ( fdt_node_check_compatible(fdt, node, > > > + "numa-distance-map-v1") == 0 ) > > > + ret = device_tree_parse_numa_distance_map_v1(fdt, node); > > > + > > > + return ret; > > > +} > > > > Julien, do you have an opinion on whether it might be worth reusing the > > existing early_scan_node function for this to avoiding another full FDT > > scan (to avoid another call to device_tree_for_each_node)? > > I don't like the full FDT scan and actually drafted an e-mail in reply-to [1] > to suggest parse all the NUMA information from early_scan_node(). > > However, we don't know whether ACPI or DT will be used at the time > early_scan_node() is called. So we will need to revert any change which can > make the code a little more awkward. > > So I decided to drop my e-mail because I prefer the full DT scan for now. We > can look at optimizing later if this becomes a pain point. Uhm, yes you are right. We would have to move some of the logic to detect ACPI earlier to early_scan_node (e.g. xen/arch/arm/acpi/boot.c:dt_scan_depth1_nodes). That could actually be a good idea, but it is true that could be done with a separate patch later. From xen-devel-bounces@lists.xenproject.org Wed Sep 01 18:33:35 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Sep 2021 18:33:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.176622.321388 (Exim 4.92) (envelope-from ) id 1mLV3F-0006ry-Nm; Wed, 01 Sep 2021 18:33:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 176622.321388; Wed, 01 Sep 2021 18:33:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLV3F-0006rr-Ka; Wed, 01 Sep 2021 18:33:33 +0000 Received: by outflank-mailman (input) for mailman id 176622; Wed, 01 Sep 2021 18:33:33 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLV3F-0006rl-Ay for xen-devel@lists.xenproject.org; Wed, 01 Sep 2021 18:33:33 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLV3B-00009l-De; Wed, 01 Sep 2021 18:33:29 +0000 Received: from [54.239.6.187] (helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1mLV3B-0003Hv-6u; Wed, 01 Sep 2021 18:33:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=9PGx/b8tr+VJ14PQ7FQDRJ8vRtnsMyRlQBn9zoS8bA4=; b=ZzVDPPSiIxDnYRWqoLlpuisL1m 0Hhm4oREb5mZoJY/QZ8yfX7XSKUi2rarC3kiuCy0wkrs5uoL/TqofHmiDg1IY0mQtubIDX/7r3kDg GQTpBUnFNkarj0KA2Z1jrWwj68Cdv/BJ0VyYZmglcxANZU9pKxAQI5aab4lRFV6jp9LE=; Subject: Re: [PATCH] xen/arm: Introduce pmu_access parameter To: Stefano Stabellini Cc: Bertrand Marquis , Michal Orzel , "xen-devel@lists.xenproject.org" , Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Wei Liu , Volodymyr Babchuk References: <20210901124308.31573-1-michal.orzel@arm.com> <599515f0-4b8a-3a71-caea-b17ec27c9123@xen.org> <44B48162-EB44-4295-9629-2D95A40D7232@arm.com> <46e36ba5-8b3d-2d43-6297-b92d2654ab72@xen.org> From: Julien Grall Message-ID: <0e72fb05-a477-ef79-c26f-bc011393a403@xen.org> Date: Wed, 1 Sep 2021 19:33:26 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit Hi Stefano, On 01/09/2021 18:54, Stefano Stabellini wrote: > On Wed, 1 Sep 2021, Julien Grall wrote: >> On 01/09/2021 14:10, Bertrand Marquis wrote: >>>> On 1 Sep 2021, at 13:55, Julien Grall wrote: >>>> >>>> Hi, >>>> >>>> On 01/09/2021 13:43, Michal Orzel wrote: >>>>> Introduce new Xen command line parameter called "pmu_access". >>>>> The default value is "trap": Xen traps PMU accesses. >>>>> In case of setting pmu_access to "native", Xen does not trap >>>>> PMU accesses allowing all the guests to access PMU registers. >>>>> However, guests cannot make use of PMU overflow interrupts as >>>>> PMU uses PPI which Xen cannot route to guests. >>>>> This option is only intended for development and testing purposes. >>>>> Do not use this in production system. >>>> I am afraid your option is not safe even in development system as a vCPU >>>> may move between pCPUs. >>>> >>>> However, even if we restricted the use to pinned vCPU *and* dedicated >>>> pCPU, I am not convinced that exposing an half backed PMU (the overflow >>>> interrupt would not work) to the guest is the right solution. This likely >>>> means the guest OS would need to be modified and therefore the usage of >>>> this option is fairly limited. >>>> >>>> So I think the first steps are: >>>> 1) Make the PPI work. There was some attempt in the past for it on >>>> xen-devel. You could have a look. >>>> 2) Provide PMU bindings >>>> >>>> With that in place, we can discuss how to expose the PMU even if it is >>>> unsafe in some conditions. >>> >>> With those limitations, using the PMU to monitor the system performances or >>> on some specific use cases is still really useful. >>> We are using that to do some benchmarks of Xen or of some applications to >>> compare the behaviour to a native system or >>> analyse the performances of Xen itself (hypercalls,context switch …etc) > > I also already had to write a patch almost exactly like this one to > provide to customers a few months back. > > >> I understand this is useful for some setup and I am not trying to say we >> should not have a way to expose the PMU (even unsafely) in upstream. However, >> I think the option as it stands is too wide (this should be a per domain knob) >> and we should properly expose the PMU (interrupts, bindings...). > > I have never used PMU directly myself, only provided a patch similar to > this one. But as far as I could tell the users were fully satisfied > with it and it had no interrupts support either. Could it be that > interrupts are not actually needed to read the perf counters, which is > probably what users care about? You don't need the interrupts to read the perf counters. But AFAIU, you would have to poll at a regular interval yourself. There is also the question on how to catch the overflow? > > In regards to "this should be a per domain knob", in reality if you are > doing PMU experiments you don't care if only one or all domains have > access: you are working in a controlled environment trying to figure out > if your setup meets the timing requirements. There are no security or > safety concerns (those are different experiments) and there is no > interference problems in the sense of multiple domains trying to access > PMU at the same time -- you control the domains you decide which one is > accessing them. > > So I am in favor of a patch like this one because it actually satisfy > our requirements. Even if we had per-domain support and interrupts > support, I don't think they would end up being used. I have to disagree with that. There are valid use-cases where you may want to expose the PMU for using perf to a single domain because you know it is safe to do so. I appreciate this is may not be the use case for your users (yet), but I have seen (and used) it on x86. So to me this approach is short-sighed. TBH, this is not the first time I have seen patch for "let's expose the same feature to everyone because this is easy to do" and really dislike it. Exposing a new feature from the toolstack is easier than you think (baring the lack of reviews), this is a matter of creating a new flag a new option. This would make Xen a lot more flexible and enable more users... So as it stands: NAcked-by: Julien Grall Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Sep 01 19:18:05 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Sep 2021 19:18:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.176628.321399 (Exim 4.92) (envelope-from ) id 1mLVk0-0003bF-5R; Wed, 01 Sep 2021 19:17:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 176628.321399; Wed, 01 Sep 2021 19:17:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLVk0-0003b8-25; Wed, 01 Sep 2021 19:17:44 +0000 Received: by outflank-mailman (input) for mailman id 176628; Wed, 01 Sep 2021 19:17:42 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLVjy-0003ay-R8; Wed, 01 Sep 2021 19:17:42 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLVjy-0000td-KC; Wed, 01 Sep 2021 19:17:42 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLVjy-0004yL-8e; Wed, 01 Sep 2021 19:17:42 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mLVjy-0000Pe-87; Wed, 01 Sep 2021 19:17:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=2kijOnpQXrHSVAla8qAxcva3/OA/I7JNm8i02Ah8h5U=; b=gSc+Epg67JtWdtzwTWQRch/hPQ pc1bNZZZkGuL42qVL9jCo/chm2krBXZy75IJDMfEHIWXkts7AhWu8iRiqikj3hROWFYY/j+6vYB1U MbyyExvuHvUL35NJWu0AK58yKbHT8W+0mUnIHk9z6BLBtzh9asROX6+FdGocJi6c6z3U=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 164687: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-arm64-arm64-xl-credit2:xen-boot:fail:heisenbug xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=96607a8e680e7f965ca868d11f8b0636317d2618 X-Osstest-Versions-That: xen=a931e8e64af07bd333a31f3b71a3f8f3e7910857 From: osstest service owner Date: Wed, 01 Sep 2021 19:17:42 +0000 flight 164687 xen-unstable real [real] flight 164724 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/164687/ http://logs.test-lab.xenproject.org/osstest/logs/164724/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-arm64-arm64-xl-credit2 8 xen-boot fail pass in 164724-retest Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-credit2 15 migrate-support-check fail in 164724 never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail in 164724 never pass test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 164477 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 164477 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 164477 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 164477 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 164477 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 164477 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 164477 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 164477 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 164477 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 164477 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 164477 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen 96607a8e680e7f965ca868d11f8b0636317d2618 baseline version: xen a931e8e64af07bd333a31f3b71a3f8f3e7910857 Last test of basis 164477 2021-08-25 09:09:48 Z 7 days Failing since 164499 2021-08-26 10:21:51 Z 6 days 5 attempts Testing same since 164687 2021-09-01 03:44:10 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Fabrice Fontaine Ian Jackson Jan Beulich Julien Grall Julien Grall Stefano Stabellini jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git a931e8e64a..96607a8e68 96607a8e680e7f965ca868d11f8b0636317d2618 -> master From xen-devel-bounces@lists.xenproject.org Wed Sep 01 20:02:47 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Sep 2021 20:02:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.176663.321504 (Exim 4.92) (envelope-from ) id 1mLWRK-0002LJ-T2; Wed, 01 Sep 2021 20:02:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 176663.321504; Wed, 01 Sep 2021 20:02:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLWRK-0002LC-Ps; Wed, 01 Sep 2021 20:02:30 +0000 Received: by outflank-mailman (input) for mailman id 176663; Wed, 01 Sep 2021 20:02:30 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLWRK-0002L6-3F for xen-devel@lists.xenproject.org; Wed, 01 Sep 2021 20:02:30 +0000 Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 60c7c1e6-1de6-4860-9bd0-4cb4b60bdd2b; Wed, 01 Sep 2021 20:02:29 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 60c7c1e6-1de6-4860-9bd0-4cb4b60bdd2b DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1630526548; h=to:cc:references:from:subject:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=EmmyNtx9gJnqTuQ1T0C4F0cNpIZQvuM75YDFAWagy74=; b=Si3uCYNbLsJIGNACwi/8aOVJ29ocU+luRPuncqpSYgdwdzucxmdZj/sK mYfpIVhIKTWiKe4S8wwx3u4FGYmWnapbvgSUglJLFHuQfkB63J6RgiB2t syHTm0MYIjxuA4eo0d5JN9uBSuzmXCpPhCJnpkoyvlqDfVzp1kep5vKSH 4=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: YrbDmm78MqY8HkOXyNnxTm+XUC472m1zU8p0jm4KvCFkX1zPUjZeThCktDYOs/C+ml7jLgQR1A 7yQpHbEhU5Yp9kF7fRJ87eQT3Xph+ClSDmH4Tz9kiZLf3eG4mSzIoOoWgc4w2YYyzpMJ3VPIkw bHki+XWuna1xmI6SkNUINki52x1lTnlHoCO/OS2xl1AVh0PSLdPXp9fOb3CYwhUPlGJUtil/wL Q2RrilOEq4EwW20IP7FwxC5tB0fVCBV60mGGhP4B4/NzrCX9CViUp5QjOeYG4zR5FFVkgE7cRc FxoG8OhLoShTmGIwmvPRQ3wM X-SBRS: 5.1 X-MesageID: 53580309 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:BTEvT6Ah5Vrc5grlHegisceALOsnbusQ8zAXPh9KJiC9I/b1qy nxppkmPH/P6Qr4WBkb6LW90dq7MAzhHPlOkPUs1NaZLXTbUQ6TQr2KgrGSuwEIdxeOkdK1kJ 0QCZSWa+eAfWSS7/yKmTVQeuxIqLLskNHK9JXjJjVWPGVXgslbnnZE422gYytLrWd9dPgE/d anl7F6T23KQwVoUi33PAhLY8Hz4/nw0L72ax8PABAqrCGIkDOT8bb/VzyVxA0XXT9jyaortT GtqX252oyT99WAjjPM3W7a6Jpb3PPn19t4HcSJzuwYMC/lhAqEbJloH5eCoDc2iuey70tCqq iDnz4Qe+BIr1/BdGC8phXgnyHmzTYV8nfnjWSVhHPyyPaJDg4SOo5kv8Z0YxHZ400vsJVXy6 RQxV+UsJJREFfpgDn9z8KgbWApqmOE5V4Z1cIDhX1WVoUTLJVLq5YEwU9TGJAcWArn9YEcFv V0Bs203ocUTbqjVQGcgoBT+q3qYpxqdS32BHTq+/blkwS+pUoJinfxn6ck7y49HPtXceg22w zGWp4Y342mAPVmNZ6UqY86ML2K41f2MGbx2VSpUBza/ZE8SgfwQqHMkcIIDcGRCdE1JcgJ6d j8uG0xjx96R6upM7zU4KF2 X-IronPort-AV: E=Sophos;i="5.84,370,1620705600"; d="scan'208";a="53580309" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GjRT/FjPZS6CbnMueP2+d7fUFHy52bNwYgpVFML6OfLwlQkXDKtgJRNdq7KD9esG41lTSrySb87zFwgkPV1NhBvnKMssh4cZtBAgvUJnl1/DKyjOq+w/p/ubwU6tjVleRuWROxpaxYaxWwfvGsNliWhFfYS8vhEYyjEDcFDZ59ycasUEw3lVeuZ3bTtGSqCsWR+Upm1dGz62uukCwxSs9tnYphrkzRENyS0ufqzY+L3aRde0vIpkdzE7kSD08kMShi0zxoT11qIPWEoqWKHS3todBuJddZDtbztDezCsvFyMoubRy8n3u5RKxMz9NVU+HBwtX7DOuH4rGayZDhP01g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EmmyNtx9gJnqTuQ1T0C4F0cNpIZQvuM75YDFAWagy74=; b=aD2Sg7++GJQTZwTsM4iC9gsTOzwApxlxHZbZ1Yl5I0yq/11bGYSBr2M44A2QtAlAvX5AZLO5REcSK6PL+f/lC5CEGiiwuElc3i2elI2Bg0qXVkN/OrujecZJlxMSvksqxnenhyxeTDxNruDahkkXfKsWW9mTrpDKqCfkf+D80Z0DOVcjb96XaKylRnQ1Ko+hvyvRXeMzo0xebY0y6VBvZBlCLL0JxteU3nlL3CWienjDj8Mo8hhonQLUAQUUQgCrFq1KsXZjTq8ohKp7Ed+X2LjVtTRFZf6IK/D9wr7as3Lff2vWrI3Oo6tLydH5bWecjPPhuNpvLag7wZJd732mig== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EmmyNtx9gJnqTuQ1T0C4F0cNpIZQvuM75YDFAWagy74=; b=Bn8Tk0RD/41282DH7wnfZcMQ+GxVzjHOUet/4u8X9GpiABoYNE8MvQ0uS16L58cUTICfJ9F38BIPWVwlwf78pD3Y0OpGmGJ1ZBsZuK7WBKY6IElC+qD2bogyLZvDSbr1BI0F5ek7wcdkh7jkA0H0QB1frXRc8OaZn/jNEEryCG4= To: Jan Beulich , "xen-devel@lists.xenproject.org" CC: George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: From: Andrew Cooper Subject: Re: [PATCH] common: guest_physmap_add_page()'s return value needs checking Message-ID: <601d46e2-5c08-3948-85bc-1e027358700b@citrix.com> Date: Wed, 1 Sep 2021 21:02:16 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: en-GB X-ClientProxiedBy: LO2P123CA0083.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:138::16) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2fd9dd0f-a1c7-4afd-5bb3-08d96d836989 X-MS-TrafficTypeDiagnostic: BYAPR03MB3560: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MexvoXncCsIbznvqnfacMJ7V6q0akAtzYRoZ0TBJpARbps1x31yYA4hVOrP69lktsPTp5UiVj8SjAoRN2zzf1pfVXyybObhjFLiueKYaQiFKYjlWo8kSTfTC0ItNxizV2P7N+SBc++x2IDc2pkrdX2mVwPK15bmL9SOuaD5eHXUZCYT1r4YWDZ18SX2vamR4wbm36cUJWpZEgTOe5QxYQGZFXHsxIDVTD9l2xDABHQVmu58ZRNLBt/QlI0tyq3WVrm9U6RTskGSj+qQrHsPErLc+dK6zCyPQzt+I+8PkFO3ty8pTI+DL9EuKMx0ajGWQYRX80Q2YDH41boobE/Z9cWsbAAwsYcXemMhcfxB7LRDMomP4KyMwq7CMeWnQ0ddXf9ZSf1L0EExxJVpkiGmfq/s7EabyQsXhoGKGoLiCC4Ze4Sp5Qf7OT/xJyi1pFLnDqsN2yLOqBydc+YW44EzVHnE4ZHqDBI1Sro7tUYImZkbAFRPrcuFNctmtc/xAWsSoaRyqRn853zjfazBuTxtR/OKhZvmz0c+f90Yv4VrNv07ahlLFXjpvoVpGZJx7Qihn/KVgYz3Ge8K4ZKFCq54TqYM8nf0el/S6kNIXs5mqCzZKfhK5OZO5WVnzmipucuNmewC3BcfwSF9MxyCQms+Gz4fJayJ2XX9xnJwo+eohgODrTJ0fr3up3aXeve3Qys8tqD6TvKlaEd0ulzyn4Auuw9YZDy23sJUrTCti7wtTWfg= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(376002)(346002)(39860400002)(366004)(136003)(4326008)(55236004)(38100700002)(16576012)(54906003)(53546011)(316002)(8676002)(186003)(6666004)(86362001)(6486002)(2616005)(36756003)(2906002)(26005)(110136005)(107886003)(66946007)(31686004)(8936002)(31696002)(5660300002)(66476007)(66556008)(956004)(478600001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RElSajFKZHF6cERuWDAyTlF5QndWbFRKNWdoV2VoaXdOa0pWOGRJTmpEZGRD?= =?utf-8?B?MUNBVitpTWdHeXplM3c5TmhiRjVQNUU4ak04STFaMDRhN0pGa2JqaERYUlRB?= =?utf-8?B?MnN6UmxwVzhKU3BXdzZhRStsSzZOZmdORmQvaVl6TmFHTWVaanFWM2tWOWx1?= =?utf-8?B?em9kWTc1akpKYndrNjE2NkNwN1hsQjhXM0hJdGg0d2dZSWRMWUtadzBjWUNK?= =?utf-8?B?cVc5d3FETldOeVo5U2JFc3NYYTVOdW16a3U0T1Jzc0pHOURsVEtsOHJJeXRv?= =?utf-8?B?aUpLUEJlaERMa204L0NxWXdaeWs5WUdCRDhXbHRzSGsxeWhGZHRpMWV4VmJx?= =?utf-8?B?QXdLejBBZEhmOHZDR0s5czR0SjY1ZGRSOXVjamUzZXptdzhTZlFOblpOU3c2?= =?utf-8?B?RzdWYSs5TlBReWNEWGZscEt4eTFSN1JtRXNHQlo0SCtrQmdIQ0JscDQ2VmpJ?= =?utf-8?B?Z2dxYTdoRUVNaGxwenMrbUpia2pzN2pWOGtHRElkWStXWmpXMmNPbU5ZSnNa?= =?utf-8?B?THNGcHlJSVlMdFlJVFNLU3FSZDJPbDdrQXFXZWgwUmpEdGJOTEtNRTJiWjRq?= =?utf-8?B?UGl6a3FmbE5raEppZFEvTzMzZ0MweDZiOVdQWjgzUVhORUsybVFiazVwcTJK?= =?utf-8?B?bzM0WTBCNitYNkFWdDlQZ0pmNk9rVWxxajBrdlNlNWRnb2xrTjJpeVdkbUFV?= =?utf-8?B?eWp3bFNRdnp5RVFZVWJQeWZuMUhqWlM4cEh5VDJ3SDRxcnd2M2FIUG91bnF1?= =?utf-8?B?TkxENlM3TEt5SmRVTWRHdGZFcSs0cHhNd1B0aFc3ZmJCR01Bb3lEenYzYXNj?= =?utf-8?B?bk5tR2lxYy9IVUdUTFRBS0pQbkZ6MlRLMlBIT0hZa2xzUnVDdGo3UkkrWGdm?= =?utf-8?B?UFk5aFFHMkJMNmg2ZUZvSitDWnVjNUN6OWV1d3phSExaK3JtUmlVY3JVUEhl?= =?utf-8?B?YTRZRnQzRjhpc0FuNGtyZXFGemF5U1RiUVV3OTVSYm9GRmhCOUpJb2owT1FR?= =?utf-8?B?NS9xS2lqQkljVk9ZVS91NFNjTjR6VFRiblpSNUdwSEpSVVppTjhiaktDZksw?= =?utf-8?B?ckN3RFFscXpwMjFSSjltOWhTL2pqS3NVdGo1V0pXSHRBMzFGakxWcnpjWG1n?= =?utf-8?B?dHpUWGY4Ujh2SWFlWm1heVloL0VLY2JYSGtJbFAvaThQTnA5SUhMT1l2RHFX?= =?utf-8?B?SDlnZXpwemJseXV0bjNhcWVXUGM4VkJoVTZUeHJ5YnhhZUtNSnhjQTUxM0lS?= =?utf-8?B?amQ2cy9KUkFVbmR1dmJ3djVBS09xZVhIa0FQSm1sTWFvNlM0b2NHanZVUFRS?= =?utf-8?B?NGdlRVA2MVg2cTBMVG9ZWGNueU8razM0bE1yK2VaQ1c3NXhPL2hBdXB4NXdv?= =?utf-8?B?WDRpbTBkUDZVbTVuUllUQS82Z2NTTWJTOFduSXVlakN0THN5Q3VKeHRPOFhm?= =?utf-8?B?SjdPQUxHb29vWjhOOExyTDE2QWFsUUJqaldOdjVTazRVLzlTSDltbnFoL3dK?= =?utf-8?B?SFVJR0dxUlVzT00zYkJObWsxbXIzR1Bqb05BZCtYUGNxSHdxbzlOb01zTUkx?= =?utf-8?B?Y0UydjNZbjRuNlY0TnAzOWJ0eVBMMDU5MlVCWlJlU1lGVlQ4L3VBWFFLY21E?= =?utf-8?B?ZU5wTE5zYUNWaFFsRHdidkpnZGhWTnVGL2hPNWFWQ21HREg2WWcxLzZvRmV2?= =?utf-8?B?MmFtalhNZjNFMkRZUnJVUktYSTdQMzBicFpPOXA0dHh5VGlYM1hkM0xiQWhS?= =?utf-8?Q?QpHJh98xseG0YFX84jRkBuuEue3pW2CBFyrHzuE?= X-MS-Exchange-CrossTenant-Network-Message-Id: 2fd9dd0f-a1c7-4afd-5bb3-08d96d836989 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Sep 2021 20:02:23.1017 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Tm+4ouc25JYwTS+wF78Pk4NeRlK+veLwaKi2VH+tTQXoS6vJ4KR1nvYbssoElopkLryFSnf8CWq5zVjJBquw7DhbEVlkrSewzgjZzgy/qhM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB3560 X-OriginatorOrg: citrix.com On 01/09/2021 17:06, Jan Beulich wrote: > The function may fail; it is not correct to indicate "success" in this > case up the call stack. Mark the function must-check to prove all > cases have been caught (and no new ones will get introduced). > > Signed-off-by: Jan Beulich > --- > In the grant-transfer case it is not really clear to me whether we can > stick to setting GTF_transfer_completed in the error case. Since a guest > may spin-wait for the flag to become set, simply not setting the flag is > not an option either. I was wondering whether we may want to slightly > alter (extend) the ABI and allow for a GTF_transfer_committed -> > GTF_transfer_completed transition (i.e. clearing GTF_transfer_committed > at the same time as setting GTF_transfer_completed). Considering there are no production users of gnttab_transfer(), we can do what we want.=C2=A0 It was introduced for (IIRC) netlink2 and never got into production, and then we clobbered it almost entirely in an XSA several years ago by restricting steal_page() to PV guests only. As a consequence, we can do anything which seems sensible, and does not necessarily need to be bound by a guest spinning on the bit. The concept of gnttab_transfer() alone is crazy from an in-guest memory management point of view.=C2=A0 We could alternatively save our future selv= es more trouble by just Kconfig'ing it out now, deleting it in several releases time, and fogetting about the problem as nothing will break in practice. ~Andrew From xen-devel-bounces@lists.xenproject.org Wed Sep 01 21:19:02 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Sep 2021 21:19:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.176672.321516 (Exim 4.92) (envelope-from ) id 1mLXd5-00026V-Ed; Wed, 01 Sep 2021 21:18:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 176672.321516; Wed, 01 Sep 2021 21:18:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLXd5-00026O-BA; Wed, 01 Sep 2021 21:18:43 +0000 Received: by outflank-mailman (input) for mailman id 176672; Wed, 01 Sep 2021 21:18:42 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLXd4-00026E-Pj; Wed, 01 Sep 2021 21:18:42 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLXd4-0003CS-B3; Wed, 01 Sep 2021 21:18:42 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLXd3-0002LW-Uc; Wed, 01 Sep 2021 21:18:42 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mLXd3-0004CE-U9; Wed, 01 Sep 2021 21:18:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=pkrosh2zFTxkIRnLKSgp7UDnqR7KcXQp9OY/znICQw4=; b=ZCvhCg09ivZi9hTkd+Wh67YhAu o3uXpMGLHwq7CesgFezbk2qnJv02VpTSclHT0BGWnfz3yZfVAsVFeWcAygUVfosMl8T6x2CXs/jHP 6sCMrO0BT+j/ZKyIcEGdUpHUtE2suMaOg/aO5OPqQueepJD+3P6vyigtzS26InJ25ljA=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 164690: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=d52dff5d8048d4982437db9606c27bb4127cf9d0 X-Osstest-Versions-That: qemuu=ad22d0583300df420819e6c89b1c022b998fac8a From: osstest service owner Date: Wed, 01 Sep 2021 21:18:41 +0000 flight 164690 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/164690/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 164601 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 164601 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 164601 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 164601 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 164601 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 164601 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 164601 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: qemuu d52dff5d8048d4982437db9606c27bb4127cf9d0 baseline version: qemuu ad22d0583300df420819e6c89b1c022b998fac8a Last test of basis 164601 2021-08-29 11:06:48 Z 3 days Testing same since 164690 2021-09-01 08:37:55 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Gerd Hoffmann Marc-André Lureau Peter Maydell jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git ad22d05833..d52dff5d80 d52dff5d8048d4982437db9606c27bb4127cf9d0 -> upstream-tested From xen-devel-bounces@lists.xenproject.org Wed Sep 01 23:08:26 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Sep 2021 23:08:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.176684.321542 (Exim 4.92) (envelope-from ) id 1mLZL0-0006Hb-Lg; Wed, 01 Sep 2021 23:08:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 176684.321542; Wed, 01 Sep 2021 23:08:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLZL0-0006HU-Hs; Wed, 01 Sep 2021 23:08:10 +0000 Received: by outflank-mailman (input) for mailman id 176684; Wed, 01 Sep 2021 23:08:08 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLZKy-0006HK-Jm; Wed, 01 Sep 2021 23:08:08 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLZKy-0005Bt-DU; Wed, 01 Sep 2021 23:08:08 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLZKy-0002ZE-4t; Wed, 01 Sep 2021 23:08:08 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mLZKy-0007au-4L; Wed, 01 Sep 2021 23:08:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=I753QPrczn9QkuyxqPxdWPBn6WhmIc/0JnZFdYDjdVo=; b=UTIX8gcZwPEBKG/eZbxXSYQQVa G1EEcSal6ZpqQJ3o5rYst7JJqSwlE3GMmF8NT/5h8/N2hkKrYbqLDnVR8rnhWDRqLW28ihK53VQ/I inFjYf5LQALUUjV2UmA3m7ufCq9hYRAD4AcDMTW5srAXAJ5qX5JFraDhA4AJnB3F6/Ek=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 164718: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=12e33dca4c0612a0975265e5ba641c6261a26455 X-Osstest-Versions-That: ovmf=cae735f61328d64e2e8991036707b9e78c0f5f63 From: osstest service owner Date: Wed, 01 Sep 2021 23:08:08 +0000 flight 164718 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/164718/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 164674 build-amd64-xsm 6 xen-build fail REGR. vs. 164674 build-i386-xsm 6 xen-build fail REGR. vs. 164674 build-i386 6 xen-build fail REGR. vs. 164674 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 12e33dca4c0612a0975265e5ba641c6261a26455 baseline version: ovmf cae735f61328d64e2e8991036707b9e78c0f5f63 Last test of basis 164674 2021-08-31 02:56:52 Z 1 days Failing since 164686 2021-09-01 03:03:43 Z 0 days 4 attempts Testing same since 164718 2021-09-01 16:40:02 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Anthony PERARD DunTan Gary Lin Jim Fehlig Lin, Gary (HPS OE-Linux) Loo Tung Lun Loo, Tung Lun Mark Wilson Marvin H?user Wenxing Hou jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit 12e33dca4c0612a0975265e5ba641c6261a26455 Author: Loo, Tung Lun Date: Tue Aug 17 15:43:12 2021 +0800 IntelFsp2Pkg: Support Config File and Binary delta comparison BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3567 This patch is to enable config editor to have a new feature that can spell out the delta between the default configuration files' data, such as YAML and BSF, against the data stored in the binary. This can help users understand and track the difference when modifications are made. Cc: Maurice Ma Cc: Nate DeSimone Cc: Star Zeng Cc: Chasel Chiu Signed-off-by: Loo Tung Lun Reviewed-by: Chasel Chiu commit b170806518c1e414939c8b085866544814e1ce8e Author: Mark Wilson Date: Fri Nov 13 08:05:18 2020 +0800 UefiCpuPkg: Clean up save state boundary checks and comments. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2956 In functions ReadSaveStateRegisterByIndex and WriteSaveStateRegister: * check width > 4 instead of >= 4 when writing upper 32 bytes. - This improves the code but will not affect functionality. Cc: Eric Dong Reviewed-by: Ray Ni Signed-off-by: Mark Wilson commit 3b3f88228812e2c642eea8746858a4dad928ebf7 Author: Marvin H?user Date: Mon Aug 9 14:09:25 2021 +0800 MdeModulePkg/PiSmmCore: Drop deprecated image profiling commands The legacy codebase allowed SMM images to be registered for profiling from DXE. Support for this has been dropped entirely, so remove the remaining handlers. Cc: Jian J Wang Cc: Hao A Wu Cc: Eric Dong Reviewed-by: Ray Ni Cc: Vitaly Cheptsov Signed-off-by: Marvin H?user commit cdda3f74a1327663a5d48cca13507085ba403af7 Author: Marvin H?user Date: Mon Aug 9 03:39:53 2021 +0800 UefiPayloadPkg/UefiPayloadEntry: Fix memory corruption UefiPayloadEntry's AllocatePool() applies the "sizeof" operator to HOB index rather than the HOB header structure. This yields 4 Bytes compared to the 8 Bytes the structure header requires. Fix the call to allocate the required space instead. Reviewed-by: Guo Dong Reviewed-by: Ray Ni Cc: Maurice Ma Cc: Benjamin You Cc: Vitaly Cheptsov Signed-off-by: Marvin H?user commit 5d34cc49d5d348012fe8acf9fb618826bd541a7c Author: Wenxing Hou Date: Tue Aug 24 16:11:11 2021 +0800 UefiCpuPkg/PiSmmCpuDxeSmm: Update mPatchCetSupported set condition REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3584 Function AsmCpuid should first check the value for Basic CPUID Information. The fix is to update the mPatchCetSupported judgment statement. Signed-off-by: Wenxing Hou Reviewed-by: Ray Ni Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Cc: Sheng W Cc: Yao Jiewen commit f0fe55bca4651734abf1752a1d7c69fb5bee00b9 Author: duntan Date: Fri Aug 20 13:04:29 2021 +0800 UefiPayloadPkg: Fix the build error when enable Core ci for UefiPayloadPkg V1: Add quotes when using $(ARCH) in .dsc and .fdf file. The quotes are added due to the way by which Core ci parse the .dsc file. Add UINTN in Hob.c to fix cast from pointer to integer of different size error. V2: Delete lines which reference ShellBinPkg.The pkg doesn't exist in edk2. Cc: Guo Dong Cc: Ray Ni Cc: Maurice Ma Cc: Benjamin You Signed-off-by: DunTan Reviewed-by: Ray Ni commit 9f3eda177a4b2d4a33ff1b0307cad42906396562 Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:29:48 2021 +0800 OvmfPkg/OvmfXen: add QemuKernelLoaderFsDxe Without QemuKernelLoaderFsDxe, QemuLoadKernelImage() couldn't download the kernel, initrd, and kernel command line from QEMU's fw_cfg. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3574 Signed-off-by: Gary Lin Acked-by: Anthony PERARD Reviewed-by: Philippe Mathieu-Daude Reviewed-by: Gerd Hoffmann Tested-by: Jim Fehlig commit 5b5f10d7465004e3e40ec1f50a3b490b4db595e7 Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:31:15 2021 +0800 OvmfPkg/SmmControl2Dxe: use PcdAcpiS3Enable to detect S3 support To avoid the potential inconsistency between PcdAcpiS3Enable and QemuFwCfgS3Enabled(), this commit modifies SmmControl2Dxe to detect S3 support by PcdAcpiS3Enable as modules in MdeModulePkg do. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3573 Signed-off-by: Gary Lin Reviewed-by: Gerd Hoffmann Reviewed-by: Jiewen Yao Tested-by: Jim Fehlig commit 52e2dabc0f8d3af09c213072ce8ba734302f585d Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:31:14 2021 +0800 OvmfPkg/PlatformBootManagerLib: use PcdAcpiS3Enable to detect S3 support To avoid the potential inconsistency between PcdAcpiS3Enable and QemuFwCfgS3Enabled(), this commit modifies PlatformBootManagerLib to detect S3 support by PcdAcpiS3Enable as modules in MdeModulePkg do. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3573 Signed-off-by: Gary Lin Reviewed-by: Gerd Hoffmann Reviewed-by: Jiewen Yao Tested-by: Jim Fehlig commit 28152333bccb778b62e6e97446b28bfa0e92ef82 Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:31:13 2021 +0800 OvmfPkg/LockBoxLib: use PcdAcpiS3Enable to detect S3 support To avoid the potential inconsistency between PcdAcpiS3Enable and QemuFwCfgS3Enabled(), this commit modifies LockBoxLib to detect S3 support by PcdAcpiS3Enable as modules in MdeModulePkg do. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3573 Signed-off-by: Gary Lin Reviewed-by: Philippe Mathieu-Daude Reviewed-by: Gerd Hoffmann Reviewed-by: Jiewen Yao Tested-by: Jim Fehlig commit cb0d24637dfdd869618b9635dfb8e3b0746393a6 Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:31:12 2021 +0800 OvmfPkg/OvmfXen: set PcdAcpiS3Enable at initialization There are several functions in OvmfPkg/Library using QemuFwCfgS3Enabled() to detect the S3 support status. However, in MdeModulePkg, PcdAcpiS3Enable is used to check S3 support. Since InitializeXenPlatform() didn't set PcdAcpiS3Enable as InitializePlatform() did, this made the inconsistency between drivers/functions. For example, S3SaveStateDxe checked PcdAcpiS3Enable and skipped S3BootScript because the default value is FALSE. On the other hand, PlatformBootManagerBeforeConsole() from OvmfPkg/Library called QemuFwCfgS3Enabled() and found it returned TRUE, so it invoked SaveS3BootScript(). However, S3SaveStateDxe skipped S3BootScript, so SaveS3BootScript() asserted due to EFI_NOT_FOUND. This issue mainly affects "HVM Direct Kernel Boot". When used, "fw_cfg" is enabled in QEMU and QemuFwCfgS3Enabled() returns true in that case. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3573 Signed-off-by: Gary Lin Reviewed-by: Anthony PERARD Reviewed-by: Gerd Hoffmann Reviewed-by: Jiewen Yao Tested-by: Jim Fehlig From xen-devel-bounces@lists.xenproject.org Wed Sep 01 23:56:26 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 01 Sep 2021 23:56:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.176695.321562 (Exim 4.92) (envelope-from ) id 1mLa5a-0003rS-Jc; Wed, 01 Sep 2021 23:56:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 176695.321562; Wed, 01 Sep 2021 23:56:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLa5a-0003rL-GV; Wed, 01 Sep 2021 23:56:18 +0000 Received: by outflank-mailman (input) for mailman id 176695; Wed, 01 Sep 2021 23:56:17 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLa5Z-0003rB-Gy; Wed, 01 Sep 2021 23:56:17 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLa5Z-0005zH-4g; Wed, 01 Sep 2021 23:56:17 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLa5Y-0004Na-RF; Wed, 01 Sep 2021 23:56:16 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mLa5Y-0005qk-Qi; Wed, 01 Sep 2021 23:56:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=KhrTjozmEmC9DKBQdIbpOY0sMTdu47t2eezytA/Jc78=; b=fP5xV+faZgfes4WV95aVIdIwgR aCRugFIIp/KOy5Qb8OQdto41t9bh/BpHhRXcJkChpHyjzQJsoKGqYKMQcixILadk4CcXWijRi3DGl 1OkP+xzreGLLbSR2cSVO1yczstfaLIRaOyY7zWS8e53tiiN/ziGcbXHqbClTqiYW12h0=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 164709: regressions - FAIL X-Osstest-Failures: linux-linus:build-amd64-pvops:kernel-build:fail:regression linux-linus:test-arm64-arm64-xl-credit1:debian-fixup:fail:regression linux-linus:test-arm64-arm64-xl-thunderx:debian-fixup:fail:regression linux-linus:test-arm64-arm64-xl:debian-fixup:fail:regression linux-linus:test-arm64-arm64-xl-credit2:guest-start:fail:regression linux-linus:test-arm64-arm64-xl-xsm:debian-fixup:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:guest-start:fail:regression linux-linus:build-i386-pvops:kernel-build:fail:regression linux-linus:test-amd64-i386-xl-qemut-ws16-amd64:build-check(1):blocked:nonblocking linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64:build-check(1):blocked:nonblocking linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:build-check(1):blocked:nonblocking linux-linus:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:build-check(1):blocked:nonblocking linux-linus:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:build-check(1):blocked:nonblocking linux-linus:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking linux-linus:test-amd64-i386-xl-qemuu-win7-amd64:build-check(1):blocked:nonblocking linux-linus:test-amd64-i386-xl-qemuu-ws16-amd64:build-check(1):blocked:nonblocking linux-linus:test-amd64-i386-xl-raw:build-check(1):blocked:nonblocking linux-linus:test-amd64-i386-xl-shadow:build-check(1):blocked:nonblocking linux-linus:test-amd64-i386-xl-xsm:build-check(1):blocked:nonblocking linux-linus:test-amd64-i386-freebsd10-i386:build-check(1):blocked:nonblocking linux-linus:test-amd64-i386-freebsd10-amd64:build-check(1):blocked:nonblocking linux-linus:test-amd64-i386-examine:build-check(1):blocked:nonblocking linux-linus:test-amd64-coresched-i386-xl:build-check(1):blocked:nonblocking linux-linus:test-amd64-coresched-amd64-xl:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-xsm:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-shadow:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-rtds:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-dom0pvh-xl-amd:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-dom0pvh-xl-intel:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-qcow2:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-examine:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-pvshim:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-pvhv2-intel:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-pair:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-pvhv2-amd:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-pygrub:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-qemuu-freebsd11-amd64:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-multivcpu:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-qemuu-freebsd12-amd64:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-credit2:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-intel:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-credit1:build-check(1):blocked:nonblocking linux-linus:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking linux-linus:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking linux-linus:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-linus:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking linux-linus:test-amd64-i386-pair:build-check(1):blocked:nonblocking linux-linus:test-amd64-i386-qemut-rhel6hvm-amd:build-check(1):blocked:nonblocking linux-linus:test-amd64-i386-qemut-rhel6hvm-intel:build-check(1):blocked:nonblocking linux-linus:test-amd64-i386-qemuu-rhel6hvm-amd:build-check(1):blocked:nonblocking linux-linus:test-amd64-i386-qemuu-rhel6hvm-intel:build-check(1):blocked:nonblocking linux-linus:test-amd64-i386-xl:build-check(1):blocked:nonblocking linux-linus:test-amd64-i386-xl-pvshim:build-check(1):blocked:nonblocking linux-linus:test-amd64-i386-xl-qemut-debianhvm-amd64:build-check(1):blocked:nonblocking linux-linus:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:build-check(1):blocked:nonblocking linux-linus:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking linux-linus:test-amd64-i386-xl-qemut-win7-amd64:build-check(1):blocked:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=9e9fb7655ed585da8f468e29221f0ba194a5f613 X-Osstest-Versions-That: linux=deacdb3e3979979016fcd0ffd518c320a62ad166 From: osstest service owner Date: Wed, 01 Sep 2021 23:56:16 +0000 flight 164709 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/164709/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-pvops 6 kernel-build fail REGR. vs. 152332 test-arm64-arm64-xl-credit1 13 debian-fixup fail REGR. vs. 152332 test-arm64-arm64-xl-thunderx 13 debian-fixup fail REGR. vs. 152332 test-arm64-arm64-xl 13 debian-fixup fail REGR. vs. 152332 test-arm64-arm64-xl-credit2 14 guest-start fail REGR. vs. 152332 test-arm64-arm64-xl-xsm 13 debian-fixup fail REGR. vs. 152332 test-arm64-arm64-libvirt-xsm 14 guest-start fail REGR. vs. 152332 build-i386-pvops 6 kernel-build fail REGR. vs. 152332 Tests which did not succeed, but are not blocking: test-amd64-i386-xl-qemut-ws16-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-debianhvm-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-win7-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ws16-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-raw 1 build-check(1) blocked n/a test-amd64-i386-xl-shadow 1 build-check(1) blocked n/a test-amd64-i386-xl-xsm 1 build-check(1) blocked n/a test-amd64-i386-freebsd10-i386 1 build-check(1) blocked n/a test-amd64-i386-freebsd10-amd64 1 build-check(1) blocked n/a test-amd64-i386-examine 1 build-check(1) blocked n/a test-amd64-coresched-i386-xl 1 build-check(1) blocked n/a test-amd64-coresched-amd64-xl 1 build-check(1) blocked n/a test-amd64-amd64-xl-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-shadow 1 build-check(1) blocked n/a test-amd64-amd64-xl-rtds 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ws16-amd64 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-win7-amd64 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-debianhvm-amd64 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemut-ws16-amd64 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemut-win7-amd64 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 1 build-check(1) blocked n/a test-amd64-amd64-dom0pvh-xl-amd 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemut-debianhvm-amd64 1 build-check(1) blocked n/a test-amd64-amd64-dom0pvh-xl-intel 1 build-check(1) blocked n/a test-amd64-amd64-xl-qcow2 1 build-check(1) blocked n/a test-amd64-amd64-examine 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-xl-pvshim 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-xl-pvhv2-intel 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-amd64-pair 1 build-check(1) blocked n/a test-amd64-amd64-xl-pvhv2-amd 1 build-check(1) blocked n/a test-amd64-amd64-pygrub 1 build-check(1) blocked n/a test-amd64-amd64-qemuu-freebsd11-amd64 1 build-check(1) blocked n/a test-amd64-amd64-xl-multivcpu 1 build-check(1) blocked n/a test-amd64-amd64-qemuu-freebsd12-amd64 1 build-check(1) blocked n/a test-amd64-amd64-qemuu-nested-amd 1 build-check(1) blocked n/a test-amd64-amd64-xl-credit2 1 build-check(1) blocked n/a test-amd64-amd64-qemuu-nested-intel 1 build-check(1) blocked n/a test-amd64-amd64-xl 1 build-check(1) blocked n/a test-amd64-amd64-xl-credit1 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-pair 1 build-check(1) blocked n/a test-amd64-i386-qemut-rhel6hvm-amd 1 build-check(1) blocked n/a test-amd64-i386-qemut-rhel6hvm-intel 1 build-check(1) blocked n/a test-amd64-i386-qemuu-rhel6hvm-amd 1 build-check(1) blocked n/a test-amd64-i386-qemuu-rhel6hvm-intel 1 build-check(1) blocked n/a test-amd64-i386-xl 1 build-check(1) blocked n/a test-amd64-i386-xl-pvshim 1 build-check(1) blocked n/a test-amd64-i386-xl-qemut-debianhvm-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemut-debianhvm-i386-xsm 1 build-check(1) blocked n/a test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-xl-qemut-win7-amd64 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 16 saverestore-support-check fail like 152332 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152332 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux 9e9fb7655ed585da8f468e29221f0ba194a5f613 baseline version: linux deacdb3e3979979016fcd0ffd518c320a62ad166 Last test of basis 152332 2020-07-31 19:41:23 Z 397 days Failing since 152366 2020-08-01 20:49:34 Z 396 days 685 attempts Testing same since 164689 2021-09-01 04:20:58 Z 0 days 2 attempts ------------------------------------------------------------ 6967 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops fail build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops fail test-amd64-amd64-xl blocked test-amd64-coresched-amd64-xl blocked test-arm64-arm64-xl fail test-armhf-armhf-xl pass test-amd64-i386-xl blocked test-amd64-coresched-i386-xl blocked test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm blocked test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemut-debianhvm-i386-xsm blocked test-amd64-i386-xl-qemut-debianhvm-i386-xsm blocked test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm blocked test-amd64-i386-xl-qemuu-debianhvm-i386-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm fail test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm blocked test-arm64-arm64-xl-xsm fail test-amd64-i386-xl-xsm blocked test-amd64-amd64-qemuu-nested-amd blocked test-amd64-amd64-xl-pvhv2-amd blocked test-amd64-i386-qemut-rhel6hvm-amd blocked test-amd64-i386-qemuu-rhel6hvm-amd blocked test-amd64-amd64-dom0pvh-xl-amd blocked test-amd64-amd64-xl-qemut-debianhvm-amd64 blocked test-amd64-i386-xl-qemut-debianhvm-amd64 blocked test-amd64-amd64-xl-qemuu-debianhvm-amd64 blocked test-amd64-i386-xl-qemuu-debianhvm-amd64 blocked test-amd64-i386-freebsd10-amd64 blocked test-amd64-amd64-qemuu-freebsd11-amd64 blocked test-amd64-amd64-qemuu-freebsd12-amd64 blocked test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked test-amd64-amd64-xl-qemut-win7-amd64 blocked test-amd64-i386-xl-qemut-win7-amd64 blocked test-amd64-amd64-xl-qemuu-win7-amd64 blocked test-amd64-i386-xl-qemuu-win7-amd64 blocked test-amd64-amd64-xl-qemut-ws16-amd64 blocked test-amd64-i386-xl-qemut-ws16-amd64 blocked test-amd64-amd64-xl-qemuu-ws16-amd64 blocked test-amd64-i386-xl-qemuu-ws16-amd64 blocked test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 blocked test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 blocked test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict blocked test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict blocked test-amd64-amd64-examine blocked test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine blocked test-amd64-i386-freebsd10-i386 blocked test-amd64-amd64-qemuu-nested-intel blocked test-amd64-amd64-xl-pvhv2-intel blocked test-amd64-i386-qemut-rhel6hvm-intel blocked test-amd64-i386-qemuu-rhel6hvm-intel blocked test-amd64-amd64-dom0pvh-xl-intel blocked test-amd64-amd64-libvirt blocked test-armhf-armhf-libvirt pass test-amd64-i386-libvirt blocked test-amd64-amd64-xl-multivcpu blocked test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair blocked test-amd64-i386-pair blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-amd64-amd64-xl-pvshim blocked test-amd64-i386-xl-pvshim blocked test-amd64-amd64-pygrub blocked test-amd64-amd64-xl-qcow2 blocked test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw blocked test-amd64-amd64-xl-rtds blocked test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow blocked test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow blocked test-amd64-amd64-xl-shadow blocked test-amd64-i386-xl-shadow blocked test-arm64-arm64-xl-thunderx fail test-amd64-amd64-libvirt-vhd blocked test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2103251 lines long.) From xen-devel-bounces@lists.xenproject.org Thu Sep 02 00:14:18 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 00:14:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.176704.321582 (Exim 4.92) (envelope-from ) id 1mLaMm-0007Da-Ix; Thu, 02 Sep 2021 00:14:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 176704.321582; Thu, 02 Sep 2021 00:14:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLaMm-0007DT-FM; Thu, 02 Sep 2021 00:14:04 +0000 Received: by outflank-mailman (input) for mailman id 176704; Thu, 02 Sep 2021 00:14:02 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLaMk-0007DJ-De; Thu, 02 Sep 2021 00:14:02 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLaMk-0006tL-8u; Thu, 02 Sep 2021 00:14:02 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLaMk-00051T-0d; Thu, 02 Sep 2021 00:14:02 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mLaMk-0005T3-0A; Thu, 02 Sep 2021 00:14:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=LqEoeYbL2qClYzMcBg6XPcebzs9wV6/lc4/p47SYp34=; b=VtpGTC7eLxWD7ueRFMVmJIZMHS KC80bqX1SpEuodAyFJ9pRLTOIjzIs5OzBkxxYV23xVja4qv11s+C/UPq0RxhQbLKXFkk3RY2MnC/J fHZlRaqpXbOzqELydJ3jpGcNn5/kzBSGSpJu/eJ+egktXPVEzonydFRW1lQ3Jz2znO2c=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 164728: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=12e33dca4c0612a0975265e5ba641c6261a26455 X-Osstest-Versions-That: ovmf=cae735f61328d64e2e8991036707b9e78c0f5f63 From: osstest service owner Date: Thu, 02 Sep 2021 00:14:02 +0000 flight 164728 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/164728/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 164674 build-amd64-xsm 6 xen-build fail REGR. vs. 164674 build-i386-xsm 6 xen-build fail REGR. vs. 164674 build-i386 6 xen-build fail REGR. vs. 164674 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 12e33dca4c0612a0975265e5ba641c6261a26455 baseline version: ovmf cae735f61328d64e2e8991036707b9e78c0f5f63 Last test of basis 164674 2021-08-31 02:56:52 Z 1 days Failing since 164686 2021-09-01 03:03:43 Z 0 days 5 attempts Testing same since 164718 2021-09-01 16:40:02 Z 0 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Anthony PERARD DunTan Gary Lin Jim Fehlig Lin, Gary (HPS OE-Linux) Loo Tung Lun Loo, Tung Lun Mark Wilson Marvin H?user Wenxing Hou jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit 12e33dca4c0612a0975265e5ba641c6261a26455 Author: Loo, Tung Lun Date: Tue Aug 17 15:43:12 2021 +0800 IntelFsp2Pkg: Support Config File and Binary delta comparison BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3567 This patch is to enable config editor to have a new feature that can spell out the delta between the default configuration files' data, such as YAML and BSF, against the data stored in the binary. This can help users understand and track the difference when modifications are made. Cc: Maurice Ma Cc: Nate DeSimone Cc: Star Zeng Cc: Chasel Chiu Signed-off-by: Loo Tung Lun Reviewed-by: Chasel Chiu commit b170806518c1e414939c8b085866544814e1ce8e Author: Mark Wilson Date: Fri Nov 13 08:05:18 2020 +0800 UefiCpuPkg: Clean up save state boundary checks and comments. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2956 In functions ReadSaveStateRegisterByIndex and WriteSaveStateRegister: * check width > 4 instead of >= 4 when writing upper 32 bytes. - This improves the code but will not affect functionality. Cc: Eric Dong Reviewed-by: Ray Ni Signed-off-by: Mark Wilson commit 3b3f88228812e2c642eea8746858a4dad928ebf7 Author: Marvin H?user Date: Mon Aug 9 14:09:25 2021 +0800 MdeModulePkg/PiSmmCore: Drop deprecated image profiling commands The legacy codebase allowed SMM images to be registered for profiling from DXE. Support for this has been dropped entirely, so remove the remaining handlers. Cc: Jian J Wang Cc: Hao A Wu Cc: Eric Dong Reviewed-by: Ray Ni Cc: Vitaly Cheptsov Signed-off-by: Marvin H?user commit cdda3f74a1327663a5d48cca13507085ba403af7 Author: Marvin H?user Date: Mon Aug 9 03:39:53 2021 +0800 UefiPayloadPkg/UefiPayloadEntry: Fix memory corruption UefiPayloadEntry's AllocatePool() applies the "sizeof" operator to HOB index rather than the HOB header structure. This yields 4 Bytes compared to the 8 Bytes the structure header requires. Fix the call to allocate the required space instead. Reviewed-by: Guo Dong Reviewed-by: Ray Ni Cc: Maurice Ma Cc: Benjamin You Cc: Vitaly Cheptsov Signed-off-by: Marvin H?user commit 5d34cc49d5d348012fe8acf9fb618826bd541a7c Author: Wenxing Hou Date: Tue Aug 24 16:11:11 2021 +0800 UefiCpuPkg/PiSmmCpuDxeSmm: Update mPatchCetSupported set condition REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3584 Function AsmCpuid should first check the value for Basic CPUID Information. The fix is to update the mPatchCetSupported judgment statement. Signed-off-by: Wenxing Hou Reviewed-by: Ray Ni Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Cc: Sheng W Cc: Yao Jiewen commit f0fe55bca4651734abf1752a1d7c69fb5bee00b9 Author: duntan Date: Fri Aug 20 13:04:29 2021 +0800 UefiPayloadPkg: Fix the build error when enable Core ci for UefiPayloadPkg V1: Add quotes when using $(ARCH) in .dsc and .fdf file. The quotes are added due to the way by which Core ci parse the .dsc file. Add UINTN in Hob.c to fix cast from pointer to integer of different size error. V2: Delete lines which reference ShellBinPkg.The pkg doesn't exist in edk2. Cc: Guo Dong Cc: Ray Ni Cc: Maurice Ma Cc: Benjamin You Signed-off-by: DunTan Reviewed-by: Ray Ni commit 9f3eda177a4b2d4a33ff1b0307cad42906396562 Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:29:48 2021 +0800 OvmfPkg/OvmfXen: add QemuKernelLoaderFsDxe Without QemuKernelLoaderFsDxe, QemuLoadKernelImage() couldn't download the kernel, initrd, and kernel command line from QEMU's fw_cfg. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3574 Signed-off-by: Gary Lin Acked-by: Anthony PERARD Reviewed-by: Philippe Mathieu-Daude Reviewed-by: Gerd Hoffmann Tested-by: Jim Fehlig commit 5b5f10d7465004e3e40ec1f50a3b490b4db595e7 Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:31:15 2021 +0800 OvmfPkg/SmmControl2Dxe: use PcdAcpiS3Enable to detect S3 support To avoid the potential inconsistency between PcdAcpiS3Enable and QemuFwCfgS3Enabled(), this commit modifies SmmControl2Dxe to detect S3 support by PcdAcpiS3Enable as modules in MdeModulePkg do. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3573 Signed-off-by: Gary Lin Reviewed-by: Gerd Hoffmann Reviewed-by: Jiewen Yao Tested-by: Jim Fehlig commit 52e2dabc0f8d3af09c213072ce8ba734302f585d Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:31:14 2021 +0800 OvmfPkg/PlatformBootManagerLib: use PcdAcpiS3Enable to detect S3 support To avoid the potential inconsistency between PcdAcpiS3Enable and QemuFwCfgS3Enabled(), this commit modifies PlatformBootManagerLib to detect S3 support by PcdAcpiS3Enable as modules in MdeModulePkg do. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3573 Signed-off-by: Gary Lin Reviewed-by: Gerd Hoffmann Reviewed-by: Jiewen Yao Tested-by: Jim Fehlig commit 28152333bccb778b62e6e97446b28bfa0e92ef82 Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:31:13 2021 +0800 OvmfPkg/LockBoxLib: use PcdAcpiS3Enable to detect S3 support To avoid the potential inconsistency between PcdAcpiS3Enable and QemuFwCfgS3Enabled(), this commit modifies LockBoxLib to detect S3 support by PcdAcpiS3Enable as modules in MdeModulePkg do. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3573 Signed-off-by: Gary Lin Reviewed-by: Philippe Mathieu-Daude Reviewed-by: Gerd Hoffmann Reviewed-by: Jiewen Yao Tested-by: Jim Fehlig commit cb0d24637dfdd869618b9635dfb8e3b0746393a6 Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:31:12 2021 +0800 OvmfPkg/OvmfXen: set PcdAcpiS3Enable at initialization There are several functions in OvmfPkg/Library using QemuFwCfgS3Enabled() to detect the S3 support status. However, in MdeModulePkg, PcdAcpiS3Enable is used to check S3 support. Since InitializeXenPlatform() didn't set PcdAcpiS3Enable as InitializePlatform() did, this made the inconsistency between drivers/functions. For example, S3SaveStateDxe checked PcdAcpiS3Enable and skipped S3BootScript because the default value is FALSE. On the other hand, PlatformBootManagerBeforeConsole() from OvmfPkg/Library called QemuFwCfgS3Enabled() and found it returned TRUE, so it invoked SaveS3BootScript(). However, S3SaveStateDxe skipped S3BootScript, so SaveS3BootScript() asserted due to EFI_NOT_FOUND. This issue mainly affects "HVM Direct Kernel Boot". When used, "fw_cfg" is enabled in QEMU and QemuFwCfgS3Enabled() returns true in that case. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3573 Signed-off-by: Gary Lin Reviewed-by: Anthony PERARD Reviewed-by: Gerd Hoffmann Reviewed-by: Jiewen Yao Tested-by: Jim Fehlig From xen-devel-bounces@lists.xenproject.org Thu Sep 02 00:15:12 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 00:15:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.176712.321596 (Exim 4.92) (envelope-from ) id 1mLaNs-0007qQ-6D; Thu, 02 Sep 2021 00:15:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 176712.321596; Thu, 02 Sep 2021 00:15:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLaNs-0007qJ-2y; Thu, 02 Sep 2021 00:15:12 +0000 Received: by outflank-mailman (input) for mailman id 176712; Thu, 02 Sep 2021 00:15:10 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLaNq-0007qB-9S for xen-devel@lists.xenproject.org; Thu, 02 Sep 2021 00:15:10 +0000 Received: from outbound.mail.eo.outlook.com (unknown [40.93.8.0]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id d0838a62-e773-4bfa-8b8e-f7f674f62b80; Thu, 02 Sep 2021 00:15:06 +0000 (UTC) Received: from MWHPR21MB1593.namprd21.prod.outlook.com (2603:10b6:301:7c::11) by MWHPR21MB0797.namprd21.prod.outlook.com (2603:10b6:300:11b::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.1; Thu, 2 Sep 2021 00:15:03 +0000 Received: from MWHPR21MB1593.namprd21.prod.outlook.com ([fe80::3c8b:6387:cd5:7d86]) by MWHPR21MB1593.namprd21.prod.outlook.com ([fe80::3c8b:6387:cd5:7d86%8]) with mapi id 15.20.4478.014; Thu, 2 Sep 2021 00:15:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d0838a62-e773-4bfa-8b8e-f7f674f62b80 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=h8BvVlJXCwbhMTEelowaN9kx+nSDBGru5s7InceIX2Po4KWVpJ9roHMd/HCgBjctY+yfPUfYaGNLdP0C7C3/k3ibkdI3yS8myRWQ9hSAdwm3RmSgF4ic3PwzTh+Ohfs+bJc0QJ3CJy2p/VsqBqit7kPKrafI+XuMeCOkvhEidSOTySuNX/5lq7eUVBuymJX//cN1tcVRrsuR/E7FrJDR7mrAww93YjW5uljePBfs9Yzw8nXxhffKaIH97oJ68UrXfRd20GiPMro2luozaSykmfstmHPOP+V/5hqh67T4Bxu/qVIxO3B3mOaE01uFDrbW4avWGix5Zu/9cYBxrFUmLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=2wJZwyg52cCLIvGROM9MWlEN9cOqwTvnQY12hCyFx/M=; b=PBg5e0gbR6i6m1kfUdBM0yttzgG6W3oki6YYMb+OpIhotgMUyPhbW/zmQqSfdenV5yHItttnIcqtZjyZtxHGNhRiM8A2XYeRSl/Cj92gJUdhaWkUgov87B+UkKqmp6oVPKIIEw6ETznyygch+fSUdwnIY4mkFFgzryPgGHDeC+5a2AVdLSONFKAkf+p7Gm+l/PVtc/MOanHkQRSKxFnRaQwT7PxVT8ZlM0PV5eca63f/J7m24zMpHzY9eptYV0Kivpl/xlbRRBI6Po8SGvg4uctJU8fSdJGIJ4njXkQaehViwJQPV9x6bYIHXnI8lEGRt1I4xEPkQKP/+90DvR7wnQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2wJZwyg52cCLIvGROM9MWlEN9cOqwTvnQY12hCyFx/M=; b=aIfunch/uFPwfCEApTqxLCAAZxJPvXnaRb7Pj8i7HYwjQ8P8SbWpTRgpUiYkQLLmQVAKBJZ3ttPxukfts2EM+obZus2xdhUWv56/DaGyXjYJFT/fM0RvR7hCvbagI3R+8jullzbTd+QlKODpqdoy3y4R+/5uzJJAHAHD0vo+GI8= From: Michael Kelley To: Tianyu Lan , KY Srinivasan , Haiyang Zhang , Stephen Hemminger , "wei.liu@kernel.org" , Dexuan Cui , "catalin.marinas@arm.com" , "will@kernel.org" , "tglx@linutronix.de" , "mingo@redhat.com" , "bp@alien8.de" , "x86@kernel.org" , "hpa@zytor.com" , "dave.hansen@linux.intel.com" , "luto@kernel.org" , "peterz@infradead.org" , "konrad.wilk@oracle.com" , "boris.ostrovsky@oracle.com" , "jgross@suse.com" , "sstabellini@kernel.org" , "joro@8bytes.org" , "davem@davemloft.net" , "kuba@kernel.org" , "jejb@linux.ibm.com" , "martin.petersen@oracle.com" , "gregkh@linuxfoundation.org" , "arnd@arndb.de" , "hch@lst.de" , "m.szyprowski@samsung.com" , "robin.murphy@arm.com" , "brijesh.singh@amd.com" , "thomas.lendacky@amd.com" , Tianyu Lan , "pgonda@google.com" , "martin.b.radev@gmail.com" , "akpm@linux-foundation.org" , "kirill.shutemov@linux.intel.com" , "rppt@kernel.org" , "hannes@cmpxchg.org" , "aneesh.kumar@linux.ibm.com" , "krish.sadhukhan@oracle.com" , "saravanand@fb.com" , "linux-arm-kernel@lists.infradead.org" , "xen-devel@lists.xenproject.org" , "rientjes@google.com" , "ardb@kernel.org" CC: "iommu@lists.linux-foundation.org" , "linux-arch@vger.kernel.org" , "linux-hyperv@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-scsi@vger.kernel.org" , "netdev@vger.kernel.org" , vkuznets , "parri.andrea@gmail.com" , "dave.hansen@intel.com" Subject: RE: [PATCH V4 01/13] x86/hyperv: Initialize GHCB page in Isolation VM Thread-Topic: [PATCH V4 01/13] x86/hyperv: Initialize GHCB page in Isolation VM Thread-Index: AQHXm2f8V9hgDb15oEeIZM6sY/3E8auH7dAA Date: Thu, 2 Sep 2021 00:15:03 +0000 Message-ID: References: <20210827172114.414281-1-ltykernel@gmail.com> <20210827172114.414281-2-ltykernel@gmail.com> In-Reply-To: <20210827172114.414281-2-ltykernel@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ActionId=11e436c2-915c-4d7c-84ac-3bd04a4dfdb3;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=true;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Standard;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=Internal;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2021-08-27T22:24:34Z;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=microsoft.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a93f77f8-5e8d-4146-86b8-08d96da6b5ec x-ms-traffictypediagnostic: MWHPR21MB0797: x-ms-exchange-transport-forked: True x-ld-processed: 72f988bf-86f1-41af-91ab-2d7cd011db47,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3044; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: epIsuYLDpNuvDcYJI1k0v+H+bBdkVs7GflPwJ89C7scLQt3PA8qBjBhhCjLcJ3STPnN7wrJytjcvU4hl0MYDSA/M207W9ZMTZ37Wd6OugAl6aezKycuTmFk77kpY88OfUh09NeI0vZ4l6URGi1BH3jkOgO+sBcjXVlellQ8kYwwGTZgl6scPuWO8up0RHHvR4XObjCS7HjHaI42LIbnIFzqWLzxJXgHp8+oIix3fh+zOf65qNMd4iPQv2BVuuaBLCRWplWUr6H6vAJsDFInSEDqIyrmje5XPV1EtXzoD4nLSWfOU/9a2gtMZBFaMWlOl7UAN59dHTNCldAD3s3wEI9/wOLRjXaRJzoBwjuSFBNjl6RzLrbZ89J8F4nI1fw1zrMoMilaQVJ70R0JBJ3ZwpI5Ofnc9WCTeH5wWTQ6Sb+McqQLhvO5+cie/iUTFJD5dls2fMYR6e8/pYxNXIN6EMcUR2KVAg6ys9nRDPECW3zkcnpIqDVHkPioYmSY7FgpGUFN3fA4//FfoMO0FLRP+K7Ce7o48GQ8mGf09t+UBtngfnTv0eBbrJTOu+Sa0H/sM4I1zEIBewjnOW0yLv+eQ4zPILbVDpuUHDPmP6sX8KJNwCtY+VtTxvts+r5CeSerSZ4SqHQKDausoCx4hUmtY+NW/I839xu+E8yjEnKCrz7eHixQWz5DX0oYg0LQdZzN9/TRgoXgK78QrvIGhVO7kFhR6FAN4+CDioU83HC74qgE= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR21MB1593.namprd21.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(2906002)(38070700005)(8936002)(316002)(8676002)(7696005)(71200400001)(5660300002)(52536014)(10290500003)(82960400001)(508600001)(8990500004)(82950400001)(7366002)(7406005)(66446008)(83380400001)(186003)(66476007)(66556008)(122000001)(76116006)(86362001)(921005)(33656002)(66946007)(9686003)(54906003)(55016002)(110136005)(64756008)(6506007)(4326008)(7416002)(38100700002)(26005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?+SGvGo5LkyV3z+SW3AVjl3lmleGqyjpZ/boSbjjpuWW5SKx1ApAWYE1hlCTO?= =?us-ascii?Q?M7dMdQq8LUMvGbrXI86PorsvIaGjOuHQgc8ceSyzq6p2IEw6aj9e7RoNsLzh?= =?us-ascii?Q?+2RamO64+yd2hERjxFouOqyFd7ereJcl5HrAbIk/6CgQp6X3igVVNtA+OIXb?= =?us-ascii?Q?/V8Jr8+Swayl2Zkek8ng1r0qv6bnyZ4e2yq6vGz3XJIDzVWJQnsPtXRZ4n3Y?= =?us-ascii?Q?hToD/HPrFnHlMOK7KCeeuPruWaF4duxcruMBuYlSYsdvjiX/NYtevhjo4mPk?= =?us-ascii?Q?Pp1BPdyc54XNnenMlC5Rcx4zBjW2lPehSKRIYjtSy3u8A2hT3i/fIZ+rLS1W?= =?us-ascii?Q?skCK43EqJq9ZRA/0ayPuCPeUln685c3+YEU4DDVj/V2Awtfnlmw3Spy978Cl?= =?us-ascii?Q?G4mqEOPp0hFGPKHcY7Ppkz/S6ZkUYqZzKGH9g0lIBlbQVZKSrnVXaT/xpxuM?= =?us-ascii?Q?eO24L6OEKTYxWDhBCkaXqzRgVYLmMXdDCy0+JDoLdIEVBKvUUtzqX0pThptA?= =?us-ascii?Q?pExZRrp8K19Sf2lPHyjS6LtJrHvGRL8qwNHNdxVJCqtyZGpkYERdxwHXNt0K?= =?us-ascii?Q?dzF3dwCHdaOFdglJHBoihyelfe3V1o5d8A2lfM0GWICQOHEcZLQPqeOaOYFt?= =?us-ascii?Q?n4rabWOuGaNTLALS5eIwgjX548KNnEOuoP+77UvnBS1uNcnijusVJEiGF09J?= =?us-ascii?Q?JcgHidD1tXjJTsSNdnFGr+h8DtyEx7eop+uJtdq0dcoqM+UHqXBDG7wIygjG?= =?us-ascii?Q?qzn6p4DT21ArJV8QRDEewJCEdMw6BCtIPj1BXXqIH7dQD62DjHU7VvmUrUhC?= =?us-ascii?Q?JCSGgUn1pxSZDm+E1ydRtgM8UnQzzvSDJLMIyFx0YT3HM3huVz5TFRXqUmJ9?= =?us-ascii?Q?UxGP7a1EUwoftA0kAEj2zLBcTjqblpcnT27wzhwEzMfkRpaqSg7GSF/64xvy?= =?us-ascii?Q?4UB/j/0IBxnyPxY/hwJgVr4zpFAsIKyaYhE8SswCoPSQC1Va3yraTzHVJhJB?= =?us-ascii?Q?GWhOODZX3rIKIUGD0IiXw0IQASfRTS/4+Us/SKfYFOnvhD5PqRIy95JkjsIG?= =?us-ascii?Q?lDPpsidDnekVVuLsMKzaGYmmLSlqdUWCA9gRttqi8MJUyKf5pWY8dFxmGCqv?= =?us-ascii?Q?2y5AmFXa1jJRXarV4vIoPvevlzJqmtbgToTktN+Y1CxX8F4Fvl3wtHsfmZB3?= =?us-ascii?Q?A1ZWW4MKulOUpPCCsBOsVgROJuS9wvCloK1LZKwWqqMbqguRY5EDJ395PM2D?= =?us-ascii?Q?A2bcYFF+ZlueEd2dVCTkguUibyFLiqHbMdXYdvk6Q32xl2Mn8EEvqlAioWsz?= =?us-ascii?Q?H+rz7J+co1poMS4EpHmARJCo?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR21MB1593.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a93f77f8-5e8d-4146-86b8-08d96da6b5ec X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Sep 2021 00:15:03.0983 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: p8dISAuhX9IHX9/2j7Bsfwp5edDHyaJ+23+T2AH2eOY3r/aR7IqvRmfOlB8qS0BdABm/bMD8pSHZu6ldb6ZT/WmE/DgBmGyuWoge9svJhZM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR21MB0797 From: Tianyu Lan Sent: Friday, August 27, 2021 10:21 = AM >=20 > Hyperv exposes GHCB page via SEV ES GHCB MSR for SNP guest > to communicate with hypervisor. Map GHCB page for all > cpus to read/write MSR register and submit hvcall request > via ghcb page. >=20 > Signed-off-by: Tianyu Lan > --- > Chagne since v3: > * Rename ghcb_base to hv_ghcb_pg and move it out of > struct ms_hyperv_info. > * Allocate hv_ghcb_pg before cpuhp_setup_state() and leverage > hv_cpu_init() to initialize ghcb page. > --- > arch/x86/hyperv/hv_init.c | 68 +++++++++++++++++++++++++++++---- > arch/x86/include/asm/mshyperv.h | 4 ++ > arch/x86/kernel/cpu/mshyperv.c | 3 ++ > include/asm-generic/mshyperv.h | 1 + > 4 files changed, 69 insertions(+), 7 deletions(-) >=20 > diff --git a/arch/x86/hyperv/hv_init.c b/arch/x86/hyperv/hv_init.c > index 708a2712a516..eba10ed4f73e 100644 > --- a/arch/x86/hyperv/hv_init.c > +++ b/arch/x86/hyperv/hv_init.c > @@ -20,6 +20,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -36,12 +37,42 @@ EXPORT_SYMBOL_GPL(hv_current_partition_id); > void *hv_hypercall_pg; > EXPORT_SYMBOL_GPL(hv_hypercall_pg); >=20 > +void __percpu **hv_ghcb_pg; > + > /* Storage to save the hypercall page temporarily for hibernation */ > static void *hv_hypercall_pg_saved; >=20 > struct hv_vp_assist_page **hv_vp_assist_page; > EXPORT_SYMBOL_GPL(hv_vp_assist_page); >=20 > +static int hyperv_init_ghcb(void) > +{ > + u64 ghcb_gpa; > + void *ghcb_va; > + void **ghcb_base; > + > + if (!hv_isolation_type_snp()) > + return 0; > + > + if (!hv_ghcb_pg) > + return -EINVAL; > + > + /* > + * GHCB page is allocated by paravisor. The address > + * returned by MSR_AMD64_SEV_ES_GHCB is above shared > + * ghcb boundary and map it here. I'm not sure what the "shared ghcb boundary" is. Did you mean "shared_gpa_boundary"? > + */ > + rdmsrl(MSR_AMD64_SEV_ES_GHCB, ghcb_gpa); > + ghcb_va =3D memremap(ghcb_gpa, HV_HYP_PAGE_SIZE, MEMREMAP_WB); > + if (!ghcb_va) > + return -ENOMEM; > + > + ghcb_base =3D (void **)this_cpu_ptr(hv_ghcb_pg); > + *ghcb_base =3D ghcb_va; > + > + return 0; > +} > + > static int hv_cpu_init(unsigned int cpu) > { > union hv_vp_assist_msr_contents msr =3D { 0 }; > @@ -85,7 +116,7 @@ static int hv_cpu_init(unsigned int cpu) > } > } >=20 > - return 0; > + return hyperv_init_ghcb(); > } >=20 > static void (*hv_reenlightenment_cb)(void); > @@ -177,6 +208,14 @@ static int hv_cpu_die(unsigned int cpu) > { > struct hv_reenlightenment_control re_ctrl; > unsigned int new_cpu; > + void **ghcb_va; > + > + if (hv_ghcb_pg) { > + ghcb_va =3D (void **)this_cpu_ptr(hv_ghcb_pg); > + if (*ghcb_va) > + memunmap(*ghcb_va); > + *ghcb_va =3D NULL; > + } >=20 > hv_common_cpu_die(cpu); >=20 > @@ -366,10 +405,16 @@ void __init hyperv_init(void) > goto common_free; > } >=20 > + if (hv_isolation_type_snp()) { > + hv_ghcb_pg =3D alloc_percpu(void *); > + if (!hv_ghcb_pg) > + goto free_vp_assist_page; > + } > + > cpuhp =3D cpuhp_setup_state(CPUHP_AP_ONLINE_DYN, "x86/hyperv_init:onlin= e", > hv_cpu_init, hv_cpu_die); > if (cpuhp < 0) > - goto free_vp_assist_page; > + goto free_ghcb_page; >=20 > /* > * Setup the hypercall page and enable hypercalls. > @@ -383,10 +428,8 @@ void __init hyperv_init(void) > VMALLOC_END, GFP_KERNEL, PAGE_KERNEL_ROX, > VM_FLUSH_RESET_PERMS, NUMA_NO_NODE, > __builtin_return_address(0)); > - if (hv_hypercall_pg =3D=3D NULL) { > - wrmsrl(HV_X64_MSR_GUEST_OS_ID, 0); > - goto remove_cpuhp_state; > - } > + if (hv_hypercall_pg =3D=3D NULL) > + goto clean_guest_os_id; >=20 > rdmsrl(HV_X64_MSR_HYPERCALL, hypercall_msr.as_uint64); > hypercall_msr.enable =3D 1; > @@ -456,8 +499,11 @@ void __init hyperv_init(void) > hv_query_ext_cap(0); > return; >=20 > -remove_cpuhp_state: > +clean_guest_os_id: > + wrmsrl(HV_X64_MSR_GUEST_OS_ID, 0); > cpuhp_remove_state(cpuhp); > +free_ghcb_page: > + free_percpu(hv_ghcb_pg); > free_vp_assist_page: > kfree(hv_vp_assist_page); > hv_vp_assist_page =3D NULL; > @@ -559,3 +605,11 @@ bool hv_is_isolation_supported(void) > { > return hv_get_isolation_type() !=3D HV_ISOLATION_TYPE_NONE; > } > + > +DEFINE_STATIC_KEY_FALSE(isolation_type_snp); > + > +bool hv_isolation_type_snp(void) > +{ > + return static_branch_unlikely(&isolation_type_snp); > +} > +EXPORT_SYMBOL_GPL(hv_isolation_type_snp); > diff --git a/arch/x86/include/asm/mshyperv.h b/arch/x86/include/asm/mshyp= erv.h > index adccbc209169..37739a277ac6 100644 > --- a/arch/x86/include/asm/mshyperv.h > +++ b/arch/x86/include/asm/mshyperv.h > @@ -11,6 +11,8 @@ > #include > #include >=20 > +DECLARE_STATIC_KEY_FALSE(isolation_type_snp); > + > typedef int (*hyperv_fill_flush_list_func)( > struct hv_guest_mapping_flush_list *flush, > void *data); > @@ -39,6 +41,8 @@ extern void *hv_hypercall_pg; >=20 > extern u64 hv_current_partition_id; >=20 > +extern void __percpu **hv_ghcb_pg; > + > int hv_call_deposit_pages(int node, u64 partition_id, u32 num_pages); > int hv_call_add_logical_proc(int node, u32 lp_index, u32 acpi_id); > int hv_call_create_vp(int node, u64 partition_id, u32 vp_index, u32 flag= s); > diff --git a/arch/x86/kernel/cpu/mshyperv.c b/arch/x86/kernel/cpu/mshyper= v.c > index 6b5835a087a3..20557a9d6e25 100644 > --- a/arch/x86/kernel/cpu/mshyperv.c > +++ b/arch/x86/kernel/cpu/mshyperv.c > @@ -316,6 +316,9 @@ static void __init ms_hyperv_init_platform(void) >=20 > pr_info("Hyper-V: Isolation Config: Group A 0x%x, Group B 0x%x\n", > ms_hyperv.isolation_config_a, ms_hyperv.isolation_config_b); > + > + if (hv_get_isolation_type() =3D=3D HV_ISOLATION_TYPE_SNP) > + static_branch_enable(&isolation_type_snp); > } >=20 > if (hv_max_functions_eax >=3D HYPERV_CPUID_NESTED_FEATURES) { > diff --git a/include/asm-generic/mshyperv.h b/include/asm-generic/mshyper= v.h > index c1ab6a6e72b5..0924bbd8458e 100644 > --- a/include/asm-generic/mshyperv.h > +++ b/include/asm-generic/mshyperv.h > @@ -237,6 +237,7 @@ bool hv_is_hyperv_initialized(void); > bool hv_is_hibernation_supported(void); > enum hv_isolation_type hv_get_isolation_type(void); > bool hv_is_isolation_supported(void); > +bool hv_isolation_type_snp(void); > void hyperv_cleanup(void); > bool hv_query_ext_cap(u64 cap_query); > #else /* CONFIG_HYPERV */ > -- > 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu Sep 02 00:15:36 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 00:15:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.176715.321607 (Exim 4.92) (envelope-from ) id 1mLaOF-0008ND-Eh; Thu, 02 Sep 2021 00:15:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 176715.321607; Thu, 02 Sep 2021 00:15:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLaOF-0008N6-Bi; Thu, 02 Sep 2021 00:15:35 +0000 Received: by outflank-mailman (input) for mailman id 176715; Thu, 02 Sep 2021 00:15:34 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLaOE-0008IR-Ay for xen-devel@lists.xenproject.org; Thu, 02 Sep 2021 00:15:34 +0000 Received: from outbound.mail.eo.outlook.com (unknown [40.93.8.0]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 27f8eb29-ef3f-4de2-a97e-6b7e1cfc01c6; Thu, 02 Sep 2021 00:15:30 +0000 (UTC) Received: from MWHPR21MB1593.namprd21.prod.outlook.com (2603:10b6:301:7c::11) by MWHPR21MB0797.namprd21.prod.outlook.com (2603:10b6:300:11b::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.1; Thu, 2 Sep 2021 00:15:28 +0000 Received: from MWHPR21MB1593.namprd21.prod.outlook.com ([fe80::3c8b:6387:cd5:7d86]) by MWHPR21MB1593.namprd21.prod.outlook.com ([fe80::3c8b:6387:cd5:7d86%8]) with mapi id 15.20.4478.014; Thu, 2 Sep 2021 00:15:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 27f8eb29-ef3f-4de2-a97e-6b7e1cfc01c6 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=E4b3tJqAMNcxiBzzEYA+v8JE1ZchrBMzycvlyjyyEaC0jibjIvp+NMHjfnl2zmnDwsHyahDsfktZS8PTxXLG+popmuIiBWOXz62JNRCg9cA3EIm3Fl2xpFj6Zb2E/Ag12U7AtWeOq4NSjPWf3SV5ApwYFF+YKVYCId1L+R6KTZgx4cfIU/K5XPnwYiY1o/g4hR/u1cb1vUVxSKhGMtzSSJHjHZb5BPRHV3RnDzTsYRaTSA+xSq2F8Taod9dNaV71f1ckAKaLxZ5Qrqk+CmtCaJL1DO4F+SyEp1a8zv0sXuUqZuBN1RaDEnrXuzNTwu4E/W1rIOKs+UF6tV8gxM7bGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=6tVUDVw6S4dvfWR9PY8PHDrUdy5zfJaPLLhUIx49AUM=; b=JZjZjgEg7RToqs/5LVea8kPluWOU/O61jvpFHollPfj+oJSi4JR6eH8JW9kRxmyA4RWMfTsnQqQ9vk17ASZSn0SBndGQ80RprXLJvPnw2hHOZFV2OUh4LdbhMb5jVIhtJs3mWBUI3PNFrzD7ylBwuFNgnu/mIEsIDCM9MW/6rDWCEHCQCSKU085CFaUyU+tpEjMWtatYhqNFOx7W3vy9K9wJIswRA4qOifGPTLZstnDYGQmBn7ysip7alJ6+IzLOcVCvmoyD21LhMQseCHCxpNVNstFrjO4eGcsMRqRscHSddmU7n0N199RZiy80BVwWLHDvY6pb+7o+me7ayHlk7A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6tVUDVw6S4dvfWR9PY8PHDrUdy5zfJaPLLhUIx49AUM=; b=XumoSZuZrB97O7Abt8lXvJ9jNJfQv5OV+xW/t/sl9NOQ/+OdR4zwVipb0ca/QetLiiid3b5PZeIMVJ443lNTePri9lg8ZMU+k+6BuJWmz0nL0oKwaKRHiUIC7602NP1teRCekzNyw17VX8V+3GXFOslyI6mSMYd+0qzlfcZegFg= From: Michael Kelley To: Tianyu Lan , KY Srinivasan , Haiyang Zhang , Stephen Hemminger , "wei.liu@kernel.org" , Dexuan Cui , "catalin.marinas@arm.com" , "will@kernel.org" , "tglx@linutronix.de" , "mingo@redhat.com" , "bp@alien8.de" , "x86@kernel.org" , "hpa@zytor.com" , "dave.hansen@linux.intel.com" , "luto@kernel.org" , "peterz@infradead.org" , "konrad.wilk@oracle.com" , "boris.ostrovsky@oracle.com" , "jgross@suse.com" , "sstabellini@kernel.org" , "joro@8bytes.org" , "davem@davemloft.net" , "kuba@kernel.org" , "jejb@linux.ibm.com" , "martin.petersen@oracle.com" , "gregkh@linuxfoundation.org" , "arnd@arndb.de" , "hch@lst.de" , "m.szyprowski@samsung.com" , "robin.murphy@arm.com" , "brijesh.singh@amd.com" , "thomas.lendacky@amd.com" , Tianyu Lan , "pgonda@google.com" , "martin.b.radev@gmail.com" , "akpm@linux-foundation.org" , "kirill.shutemov@linux.intel.com" , "rppt@kernel.org" , "hannes@cmpxchg.org" , "aneesh.kumar@linux.ibm.com" , "krish.sadhukhan@oracle.com" , "saravanand@fb.com" , "linux-arm-kernel@lists.infradead.org" , "xen-devel@lists.xenproject.org" , "rientjes@google.com" , "ardb@kernel.org" CC: "iommu@lists.linux-foundation.org" , "linux-arch@vger.kernel.org" , "linux-hyperv@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-scsi@vger.kernel.org" , "netdev@vger.kernel.org" , vkuznets , "parri.andrea@gmail.com" , "dave.hansen@intel.com" Subject: RE: [PATCH V4 02/13] x86/hyperv: Initialize shared memory boundary in the Isolation VM. Thread-Topic: [PATCH V4 02/13] x86/hyperv: Initialize shared memory boundary in the Isolation VM. Thread-Index: AQHXm2f5YhiZigcKo0WndvjSqX/I9KuH761w Date: Thu, 2 Sep 2021 00:15:27 +0000 Message-ID: References: <20210827172114.414281-1-ltykernel@gmail.com> <20210827172114.414281-3-ltykernel@gmail.com> In-Reply-To: <20210827172114.414281-3-ltykernel@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ActionId=0a271260-2add-4c88-99c4-2e5b54a0e418;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=true;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Standard;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=Internal;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2021-08-27T22:31:14Z;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=microsoft.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 0bb98b2c-b332-43be-b6bc-08d96da6c4b7 x-ms-traffictypediagnostic: MWHPR21MB0797: x-ms-exchange-transport-forked: True x-ld-processed: 72f988bf-86f1-41af-91ab-2d7cd011db47,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4714; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Zzhi7VwaXM35ruQkmXyNvFX42K8MnHgcxR/I3JJ+p15J4AndM8A8FmXFNPW0Pw8Zmj5+C/dQkGgoAPemXaY0hIgueRmcLQgPytlXLZYv1msC0kBb0zg2LC1O/bANppFMlGFQstY1/XNvxZsH9spLv3aAl9A4dNcvZStMcPOVrKOLVuv+nDhIgq4fK3KXfsO4GdfwA1kEyDV25i4RCCxvMewMCc9uEP87gxhsd9Pl8+hCRnPMjvEcttz6uV0CP2h477ANsQg/YwF3fdGcCnJownxpZwVAUvFDf+hKjXN6ksIpzSW1U4gOHq2f0QIKx0i7mBp0Oma1Tyi4sQvsJ6YSHs2vTKVW4WOXUT1xl6ro+ymF7OzJk9Dysu2CKhEo8+1tCVg8bM3E1rnbYTrCWmAl7vRXivkk6XMwpUojkA1+rMvn3XEaQZwMM6GPP4WPuAIhp7+vByu4U8NP5lj2ffCybg6h6xUrShI4JkrArYq1qzNufWyC8aVh4p0k28nzgoVtL1cvWYZ7CT46DmYDP/gVhwwHKhgBtNVmcI+9dfUgW62vHeD77Qlo9uXoSxIjiVa2hLen6ZE+hCVPK4au4pauws+DPDiU64wJOURLa3BzaOGckOZ+MFRc5stLX/0DsR0UPlNCGbgqVCC4J3JNW4Tac2vCad2Ul8E8GLFt66H7NKEJf9IELvrkPYiHpEf8II1jmaYpQav5ec5kN7poLkKbHd/VfqCb79Ba6ivjZvF72Xg= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR21MB1593.namprd21.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(2906002)(38070700005)(8936002)(316002)(8676002)(7696005)(71200400001)(5660300002)(52536014)(10290500003)(82960400001)(508600001)(8990500004)(82950400001)(7366002)(7406005)(66446008)(83380400001)(186003)(66476007)(66556008)(122000001)(76116006)(86362001)(921005)(33656002)(66946007)(9686003)(54906003)(55016002)(110136005)(64756008)(6506007)(4326008)(7416002)(38100700002)(26005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?a1LzKABlpY2yhIlj+iKhGJUcJvC5jESOKLs2Un6hyPqUyS6IMhSh+/lr4UEg?= =?us-ascii?Q?w4bnjgOkDQSxvfqIbFWEZAzGVSuLVIBM4RQ/I86Nn1ARK/FcNqUjRlr9TmSj?= =?us-ascii?Q?9qyHRcd495zNkey5DZL/fabj2qoNgeBp82a97j5ZQVGLE9vVLtvoggyGeUgp?= =?us-ascii?Q?2xCOv/jeJmCqda4zvsT3tgkxXvBWZVb3sISBZYsCRBDEmPamgwcUeBzVvbtX?= =?us-ascii?Q?VGIjkwOjmm10orfXz7Cgchunxbb1VuEFU/wMBozMap5TT6IiWP5+BQFfy/Iz?= =?us-ascii?Q?gupQltgZqYsx35Evb86AUkTXsp4fG3dYkzZ0P8u+uk5+BLqENGX5ssRaIoaS?= =?us-ascii?Q?DFIcuFZmoXPM7Of2oQkcWs5EACSU0XgrWQi61j4qki8Qssm8lT9Ia6XVa0Ji?= =?us-ascii?Q?os3x4qfNzqFQcZLqqUziRbomGbLaFNf/sB5gAcIkh+RGt9A2ozj+rmSvcKqV?= =?us-ascii?Q?2lLtSkDRdJA1KH8VdBc+s5qQsrtpaPn7WkL1Z6231nhUoOUaJmSsMm1wSi7t?= =?us-ascii?Q?ETzPaZHbWMN3NmCGr3hq07iKmE06QOLZclGMxy6ZO4vEnXY2iknm4oAMCbhv?= =?us-ascii?Q?/u1tex/FmTFBJyhfl02YFRCT2w/MiIcpK8utaFED4nNUN+vhdlo5IwmZ17QX?= =?us-ascii?Q?QP7r5xsNZVxjVoi+OCGRBHWpo/2uRpZQFojUCEKH4MssdzvR6BgC5vSh7LCk?= =?us-ascii?Q?e4lnYHSXS0lEkFsEkfTU0LVRer4M2HHgg/V9vbGUWU8iXrUK+l3gdvlSdJ8F?= =?us-ascii?Q?nXh0iWR7Pwk9p6pU1va7cOebYDKGsG2S8cAvT+O1RNYvU9aaFYsSXOF+InoU?= =?us-ascii?Q?tswUliudNqGh8ijCBXjReAIeb+XzWFrpBuQxBTrKMEj4adRifDNKRrisvXwu?= =?us-ascii?Q?1sopz+gy1XxgBpb2wbV3povJXd4rDFWXSjxbshyzGBGqSh9fsQEqax6hcE2p?= =?us-ascii?Q?G5AaQc5l3LvDxC0WSaqtHmyU0M1GBp1fu86fKP6CyhHWz0TbHekuiW/rHV6j?= =?us-ascii?Q?TfgIpj+iOZBMHdTdtBlAmLmA5v9JEs+26IrHhbO48+b2PaV9ImIixo370IWc?= =?us-ascii?Q?+4pdlJaIzduBwQn1/pzyIZ4NuHNoxJt01ab4/WTT+nBUlAa6sl4x9gs0KThQ?= =?us-ascii?Q?kmwqeNT+VXoO0T31VLZRNtJcz6rAZ0rWDrhj7rVfEYe5CQc/XEjRjoLS4+d4?= =?us-ascii?Q?Tm09Us06khNRTuhmGc+gGt8QG9UO+Sau7cnxUX6vm3h7U4HD3SpcI3WPwvR8?= =?us-ascii?Q?sxx+sFAULKiGz5tCKQ17Z8bJp9Myyb1bM+LObHFwNrntegCzX+UXMLAzXRyE?= =?us-ascii?Q?Ece15J/8FKpNHmK4Omwm5laf?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR21MB1593.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0bb98b2c-b332-43be-b6bc-08d96da6c4b7 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Sep 2021 00:15:27.9650 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: kqyCC46tRZ6Ol7tcUTWt/2lSA8O5oztS7qxpD8ekw1tgtmu+y1jejDT1KAvl57lUrUlPeLUjEzGIJsjVZ1O4C5AKq10LHwiGv5P17CeeGlQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR21MB0797 From: Tianyu Lan Sent: Friday, August 27, 2021 10:21 = AM >=20 > Hyper-V exposes shared memory boundary via cpuid > HYPERV_CPUID_ISOLATION_CONFIG and store it in the > shared_gpa_boundary of ms_hyperv struct. This prepares > to share memory with host for SNP guest. >=20 > Signed-off-by: Tianyu Lan > --- > Change since v3: > * user BIT_ULL to get shared_gpa_boundary > * Rename field Reserved* to reserved > --- > arch/x86/kernel/cpu/mshyperv.c | 2 ++ > include/asm-generic/mshyperv.h | 12 +++++++++++- > 2 files changed, 13 insertions(+), 1 deletion(-) >=20 > diff --git a/arch/x86/kernel/cpu/mshyperv.c b/arch/x86/kernel/cpu/mshyper= v.c > index 20557a9d6e25..8bb001198316 100644 > --- a/arch/x86/kernel/cpu/mshyperv.c > +++ b/arch/x86/kernel/cpu/mshyperv.c > @@ -313,6 +313,8 @@ static void __init ms_hyperv_init_platform(void) > if (ms_hyperv.priv_high & HV_ISOLATION) { > ms_hyperv.isolation_config_a =3D cpuid_eax(HYPERV_CPUID_ISOLATION_CONF= IG); > ms_hyperv.isolation_config_b =3D cpuid_ebx(HYPERV_CPUID_ISOLATION_CONF= IG); > + ms_hyperv.shared_gpa_boundary =3D > + BIT_ULL(ms_hyperv.shared_gpa_boundary_bits); >=20 > pr_info("Hyper-V: Isolation Config: Group A 0x%x, Group B 0x%x\n", > ms_hyperv.isolation_config_a, ms_hyperv.isolation_config_b); > diff --git a/include/asm-generic/mshyperv.h b/include/asm-generic/mshyper= v.h > index 0924bbd8458e..7537ae1db828 100644 > --- a/include/asm-generic/mshyperv.h > +++ b/include/asm-generic/mshyperv.h > @@ -35,7 +35,17 @@ struct ms_hyperv_info { > u32 max_vp_index; > u32 max_lp_index; > u32 isolation_config_a; > - u32 isolation_config_b; > + union { > + u32 isolation_config_b; > + struct { > + u32 cvm_type : 4; > + u32 reserved11 : 1; > + u32 shared_gpa_boundary_active : 1; > + u32 shared_gpa_boundary_bits : 6; > + u32 reserved12 : 20; I'm still curious about the "11" and "12" in the reserved field names. Why not just "reserved1" and "reserved2"? Having the "11" and "12" isn't wrong, but it makes one wonder why since it's not usual. :-) > + }; > + }; > + u64 shared_gpa_boundary; > }; > extern struct ms_hyperv_info ms_hyperv; >=20 > -- > 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu Sep 02 00:16:45 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 00:16:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.176725.321618 (Exim 4.92) (envelope-from ) id 1mLaPM-0000hN-S5; Thu, 02 Sep 2021 00:16:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 176725.321618; Thu, 02 Sep 2021 00:16:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLaPM-0000hG-Oj; Thu, 02 Sep 2021 00:16:44 +0000 Received: by outflank-mailman (input) for mailman id 176725; Thu, 02 Sep 2021 00:16:43 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLaPL-0000h4-8U for xen-devel@lists.xenproject.org; Thu, 02 Sep 2021 00:16:43 +0000 Received: from outbound.mail.eo.outlook.com (unknown [40.93.8.14]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 0a38c2e2-0b83-11ec-ae2c-12813bfff9fa; Thu, 02 Sep 2021 00:16:38 +0000 (UTC) Received: from MWHPR21MB1593.namprd21.prod.outlook.com (2603:10b6:301:7c::11) by CO1PR21MB1314.namprd21.prod.outlook.com (2603:10b6:303:151::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.4; Thu, 2 Sep 2021 00:16:34 +0000 Received: from MWHPR21MB1593.namprd21.prod.outlook.com ([fe80::3c8b:6387:cd5:7d86]) by MWHPR21MB1593.namprd21.prod.outlook.com ([fe80::3c8b:6387:cd5:7d86%8]) with mapi id 15.20.4478.014; Thu, 2 Sep 2021 00:16:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0a38c2e2-0b83-11ec-ae2c-12813bfff9fa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Y4w4QNo088iiDF7WpKo5d2HaaMS7RSYImGHIUr5/Tl//9csWEPwMnnX2KMUrNybliUOgQ1Sloxs+2j4rmwjbJmbbCIBFvjtlz85hZLLBGZ9TgOZToBXaRJNMNWSh91AKGSmyqtSiJLtdqOIfO9CUqDD/lyATiZqihVd1+b7QXC3XEfL9OooQ9O2zKto4VlElV7nm1X1EUtzlAIPyEeANEtDH+Pkt0VaPyroFgHjcCpROgDjTGRX2SX6BgaB1KNjxaxkB+8+IuhBBux5xF5RypFjlKhA2/LPxDLEXvGBl0Jc79ULx4pZSkdMiUKyGTCmQteA7HoztderafBWQw0665w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=rGjVQNUXVDO4QwZnYpGSTcEEWMpwB5D9QDdioJ1qzYM=; b=PPe4WGH5WOMJJijs85AS7NtP8dE8jdNfodo5az0kecFnWGgjTwrXGbc9Bh0EAjFfakMIMPH6l6CtKKOoWWuvjKFH3+4d+9ljimrIrYwSN+i2dH62SPQRPb6tqiDK05RKcFCzyKhPqTaIRSAgGUm7yi0qk7FuOQKeHOYi/wjFy+dE29M1+V8+mapMfVrNwrUmKBz6xeqX/m/1sawbUL2LAmoXos6PljQVPjoxb6Wms0ANUoGpPw//MmbKYH7PsPRWz/Qkyx17lxkvFx//MTcFLbDp9k8pSdAKPg8Dq6KnCnlXyrg5J5xVAGGzUVFcR4RtyHIQz+4/u0u0o+y75NwpiQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rGjVQNUXVDO4QwZnYpGSTcEEWMpwB5D9QDdioJ1qzYM=; b=MIeMV26IwzWTaPJPirf8QDvR17EiHNKPWCapnyJH/eF0HmSxebOyZBlG7hPUktF8//ikMwtRGa7AFnHi3W1X2Qbzi7HAo2tLcka+rlM3qE2lfM6KqNdmMWAAHw9zQHACwHW1ZBU1ZZxBMqYE+geJk41lwvqvn/qXYcZDChSn0pc= From: Michael Kelley To: Tianyu Lan , KY Srinivasan , Haiyang Zhang , Stephen Hemminger , "wei.liu@kernel.org" , Dexuan Cui , "catalin.marinas@arm.com" , "will@kernel.org" , "tglx@linutronix.de" , "mingo@redhat.com" , "bp@alien8.de" , "x86@kernel.org" , "hpa@zytor.com" , "dave.hansen@linux.intel.com" , "luto@kernel.org" , "peterz@infradead.org" , "konrad.wilk@oracle.com" , "boris.ostrovsky@oracle.com" , "jgross@suse.com" , "sstabellini@kernel.org" , "joro@8bytes.org" , "davem@davemloft.net" , "kuba@kernel.org" , "jejb@linux.ibm.com" , "martin.petersen@oracle.com" , "gregkh@linuxfoundation.org" , "arnd@arndb.de" , "hch@lst.de" , "m.szyprowski@samsung.com" , "robin.murphy@arm.com" , "brijesh.singh@amd.com" , "thomas.lendacky@amd.com" , Tianyu Lan , "pgonda@google.com" , "martin.b.radev@gmail.com" , "akpm@linux-foundation.org" , "kirill.shutemov@linux.intel.com" , "rppt@kernel.org" , "hannes@cmpxchg.org" , "aneesh.kumar@linux.ibm.com" , "krish.sadhukhan@oracle.com" , "saravanand@fb.com" , "linux-arm-kernel@lists.infradead.org" , "xen-devel@lists.xenproject.org" , "rientjes@google.com" , "ardb@kernel.org" CC: "iommu@lists.linux-foundation.org" , "linux-arch@vger.kernel.org" , "linux-hyperv@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-scsi@vger.kernel.org" , "netdev@vger.kernel.org" , vkuznets , "parri.andrea@gmail.com" , "dave.hansen@intel.com" Subject: RE: [PATCH V4 03/13] x86/hyperv: Add new hvcall guest address host visibility support Thread-Topic: [PATCH V4 03/13] x86/hyperv: Add new hvcall guest address host visibility support Thread-Index: AQHXm2f+zKaCHZTB30K5pZMyKctp/auH8Tww Date: Thu, 2 Sep 2021 00:16:34 +0000 Message-ID: References: <20210827172114.414281-1-ltykernel@gmail.com> <20210827172114.414281-4-ltykernel@gmail.com> In-Reply-To: <20210827172114.414281-4-ltykernel@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ActionId=a96f9a08-110c-4822-a43b-0d2d08ef1746;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=true;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Standard;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=Internal;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2021-08-27T22:36:48Z;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=microsoft.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a47f00d8-8849-4fbb-ac96-08d96da6ec39 x-ms-traffictypediagnostic: CO1PR21MB1314: x-ms-exchange-transport-forked: True x-ld-processed: 72f988bf-86f1-41af-91ab-2d7cd011db47,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: bTLYupGy/LbS0xQhhUnKkQfH9+pV+XrKMU1UnFme7fWER5H9Lr3jDBjpUkxY0EkbkHZcSGWKDKclo+u+QKdSeGEisecMjpytRwf9xNfDlXpv+V8ENWd8PKHKIw3kARh0Nh4V/da9ORN23Kh/DeSFEBtzpFBrP6xMANv7yrPfXAvaaI58RXcIP1t1jhNgAFHHfj4UnnmnWR0o7fZSjReGnURTZCdxeb8/swyFn581WqpbFyTD8bcn9OfkaRMwmG6Sgbj+5qifE3gIXkITOw/zFaiCeWNoxi2jn8R3kZiYnYwIOLUMVhy9qXs3wSgiLiQsvrHnIlf+UZWaEmvilnyR3usEack32K63cAqL/B3NrrzuOM8L6nxRO9m4uMVT/nHl/t9QHlqolHaVENQOrlh2jSLkkluiH+Nr0XB9w70sesqPJF7aE/okVzfkm+6+yTbL9VvrEllLpMtBpRj5wQWzoAij3Puc0gM168glxxBQj18MAockWNwPgLDseDANo9f+p54S71AL4p5jowoDOUySP/FxCZz6RKJX1bay9EtELMdVRumApAMrrF4rvD/7i3KH8VloBbAn6uhuo8WlMCoZFayEMRJ6diiBg9dYV+1pHd+1g4dIHfN6oiPz/jbEGea9VRy3gCGeopeTZGJqO5SbZOlGkmD+BWXv+FK8gt5I1gQ1XzdtpmBLne4S2tacAqqJi3kKqW/xFvMXia3b7ipzAcq4V8is9c4ng75n34p5f74= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR21MB1593.namprd21.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(26005)(10290500003)(7696005)(186003)(66946007)(6506007)(76116006)(38100700002)(8676002)(110136005)(9686003)(316002)(54906003)(71200400001)(38070700005)(8990500004)(86362001)(55016002)(2906002)(122000001)(508600001)(8936002)(4326008)(7406005)(5660300002)(7416002)(7366002)(33656002)(52536014)(83380400001)(82950400001)(30864003)(66556008)(82960400001)(921005)(66476007)(66446008)(64756008);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Oyj20tWEpY4HT/oJ0UQqteE/BHXeBnXQUewR3f2TeAjvT1uuMkia78HGPYvo?= =?us-ascii?Q?/uacGbRrpw/7VcTrGhpFMstHzc0fC8fO7Uw5Bb0kUKI1fOQdpN83fNfQxbXW?= =?us-ascii?Q?D5OCEJMIVHVv6Ncg9Cxv2+sUly5BVW4t9Yk+IVGKbuVnNhDV6uKotO5ve6lg?= =?us-ascii?Q?uwBlEL0ci6e3XakoPhb7mbCI7RYJZjcwyAc7uST8rLK6w7K0ne/NzfRKFnh6?= =?us-ascii?Q?rRA8hpkvJjEktQiB61q1wFPWr8mRdW0/CmTBfD33kAy7SGey2SPSuCm/BG8s?= =?us-ascii?Q?Kv95F7VSo9HxxJSjYIq5ibFONL1FXWgPjofkqblmd2ovd2ad/mLcvV4ISWcE?= =?us-ascii?Q?WwGaFkpatO2zq9l1RaWGgsxeX03ZP3W+cDtE2qByEZlVJvpRZie9XaiIzwFc?= =?us-ascii?Q?QvRtnO0wTQiAFv/Vo5Vx40kiTtmbKCXnbQG+dzlZlDts2z0/IbnRaxU6d6P9?= =?us-ascii?Q?yhoMNLAYM58UQs119ru35xWRyLJ/nN5vDMTwH4pmttQUmaHj6ZMBvJ41kOFC?= =?us-ascii?Q?Hwc24zW7BlOi9Y68VlvcZ/2G1w3FTSgO/ArRJ/1IKeJ7e24Yt4wdA+d15FiP?= =?us-ascii?Q?qzX0q2jA0GHD/fvrYz9dkmx8yf/vNMSCv2xzAoK4QO6owDL5uuxSIwlJNVcj?= =?us-ascii?Q?Uedr/m9USGqqXg9RwWw2kuwQX39q0U1Wbmug0D4NGxbnHxYynPZBs/7rL3l2?= =?us-ascii?Q?SDWbHl0oj4wADgD/bpFhaz91PMv68rklAYXj/5GdNzMzWYWUONKQsznKKGwH?= =?us-ascii?Q?KIXB4VWEO+5wW0vuO5ydrPUgXzk86IcWBdhq36tmpZI360haF53Ts8U4Vc/6?= =?us-ascii?Q?82+mvgYqeVGfKB1EHNTv/w1CVUnKMnbcKtXSWLbp4gNxS2htKc7NscF5IJ5u?= =?us-ascii?Q?qiLG9VBT6F9dMweSXpR50DgSmgQrT1Aag8QgXb6RJeA+BIOZ+3vT4ujLf+CI?= =?us-ascii?Q?azag7e+UT03PqqBKtrxhnrelfjta8AUUBEfgursanYZG4WMgydj9exK9w5q0?= =?us-ascii?Q?YlG3gguR2WncMBb4UXV0ZWp45zoCpuL9GmF+hN7M7H4g7IN5cycZaDFuq3dR?= =?us-ascii?Q?Kcp/8nHaiVltDvUC3mh9BA5gpfiir8JnPRtXqu72nV1hz0An0vF5MOPo1rJu?= =?us-ascii?Q?fGpkAWMOw7QKfLD0jEumZO5cONj4c4Ic9LkJX6KlrjE41CTd0j4WURg46EBF?= =?us-ascii?Q?hkZ/vJXFuBr+pOFkbACLizdbLqpoxyRi4P8k6cHFqmIcHePqcG8drUEIhv+w?= =?us-ascii?Q?hoBcAFW1u09sn1dvP47QsLMkAku0hCZmlmjtd074t982tKScsc5dNyi8rnBH?= =?us-ascii?Q?btNv23jiKRhT+7da4+VEJf4Z?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR21MB1593.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a47f00d8-8849-4fbb-ac96-08d96da6ec39 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Sep 2021 00:16:34.1759 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: iy7Bm09R2ybhwyJZEZLyvD9iuXUgQWan7i+o0pFTehAQFo+nV250s0Vhubtgu9mRkpslfJasLFpR6yX495cvj7CTXKrGKBt/EevN0WlWfzE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR21MB1314 From: Tianyu Lan Sent: Friday, August 27, 2021 10:21 = AM >=20 > Add new hvcall guest address host visibility support to mark > memory visible to host. Call it inside set_memory_decrypted > /encrypted(). Add HYPERVISOR feature check in the > hv_is_isolation_supported() to optimize in non-virtualization > environment. >=20 > Acked-by: Dave Hansen > Signed-off-by: Tianyu Lan > --- > Change since v3: > * Fix error code handle in the __hv_set_mem_host_visibility(). > * Move HvCallModifySparseGpaPageHostVisibility near to enum > hv_mem_host_visibility. >=20 > Change since v2: > * Rework __set_memory_enc_dec() and call Hyper-V and AMD function > according to platform check. >=20 > Change since v1: > * Use new staic call x86_set_memory_enc to avoid add Hyper-V > specific check in the set_memory code. > --- > arch/x86/hyperv/Makefile | 2 +- > arch/x86/hyperv/hv_init.c | 6 ++ > arch/x86/hyperv/ivm.c | 113 +++++++++++++++++++++++++++++ > arch/x86/include/asm/hyperv-tlfs.h | 17 +++++ > arch/x86/include/asm/mshyperv.h | 4 +- > arch/x86/mm/pat/set_memory.c | 19 +++-- > include/asm-generic/hyperv-tlfs.h | 1 + > include/asm-generic/mshyperv.h | 1 + > 8 files changed, 156 insertions(+), 7 deletions(-) > create mode 100644 arch/x86/hyperv/ivm.c >=20 > diff --git a/arch/x86/hyperv/Makefile b/arch/x86/hyperv/Makefile > index 48e2c51464e8..5d2de10809ae 100644 > --- a/arch/x86/hyperv/Makefile > +++ b/arch/x86/hyperv/Makefile > @@ -1,5 +1,5 @@ > # SPDX-License-Identifier: GPL-2.0-only > -obj-y :=3D hv_init.o mmu.o nested.o irqdomain.o > +obj-y :=3D hv_init.o mmu.o nested.o irqdomain.o ivm.o > obj-$(CONFIG_X86_64) +=3D hv_apic.o hv_proc.o >=20 > ifdef CONFIG_X86_64 > diff --git a/arch/x86/hyperv/hv_init.c b/arch/x86/hyperv/hv_init.c > index eba10ed4f73e..b1aa42f60faa 100644 > --- a/arch/x86/hyperv/hv_init.c > +++ b/arch/x86/hyperv/hv_init.c > @@ -603,6 +603,12 @@ EXPORT_SYMBOL_GPL(hv_get_isolation_type); >=20 > bool hv_is_isolation_supported(void) > { > + if (!cpu_feature_enabled(X86_FEATURE_HYPERVISOR)) > + return 0; Use "return false" per previous comment from Wei Liu. > + > + if (!hypervisor_is_type(X86_HYPER_MS_HYPERV)) > + return 0; Use "return false". > + > return hv_get_isolation_type() !=3D HV_ISOLATION_TYPE_NONE; > } >=20 > diff --git a/arch/x86/hyperv/ivm.c b/arch/x86/hyperv/ivm.c > new file mode 100644 > index 000000000000..a069c788ce3c > --- /dev/null > +++ b/arch/x86/hyperv/ivm.c > @@ -0,0 +1,113 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Hyper-V Isolation VM interface with paravisor and hypervisor > + * > + * Author: > + * Tianyu Lan > + */ > + > +#include > +#include > +#include > +#include > +#include > +#include > + > +/* > + * hv_mark_gpa_visibility - Set pages visible to host via hvcall. > + * > + * In Isolation VM, all guest memory is encripted from host and guest s/encripted/encrypted/ > + * needs to set memory visible to host via hvcall before sharing memory > + * with host. > + */ > +int hv_mark_gpa_visibility(u16 count, const u64 pfn[], > + enum hv_mem_host_visibility visibility) > +{ > + struct hv_gpa_range_for_visibility **input_pcpu, *input; > + u16 pages_processed; > + u64 hv_status; > + unsigned long flags; > + > + /* no-op if partition isolation is not enabled */ > + if (!hv_is_isolation_supported()) > + return 0; > + > + if (count > HV_MAX_MODIFY_GPA_REP_COUNT) { > + pr_err("Hyper-V: GPA count:%d exceeds supported:%lu\n", count, > + HV_MAX_MODIFY_GPA_REP_COUNT); > + return -EINVAL; > + } > + > + local_irq_save(flags); > + input_pcpu =3D (struct hv_gpa_range_for_visibility **) > + this_cpu_ptr(hyperv_pcpu_input_arg); > + input =3D *input_pcpu; > + if (unlikely(!input)) { > + local_irq_restore(flags); > + return -EINVAL; > + } > + > + input->partition_id =3D HV_PARTITION_ID_SELF; > + input->host_visibility =3D visibility; > + input->reserved0 =3D 0; > + input->reserved1 =3D 0; > + memcpy((void *)input->gpa_page_list, pfn, count * sizeof(*pfn)); > + hv_status =3D hv_do_rep_hypercall( > + HVCALL_MODIFY_SPARSE_GPA_PAGE_HOST_VISIBILITY, count, > + 0, input, &pages_processed); > + local_irq_restore(flags); > + > + if (hv_result_success(hv_status)) > + return 0; > + else > + return -EFAULT; > +} > +EXPORT_SYMBOL(hv_mark_gpa_visibility); In later comments on Patch 7 of this series, I have suggested that code in that patch should not call hv_mark_gpa_visibility() directly, but instead should call set_memory_encrypted() and set_memory_decrypted(). I'm thinking that those functions should be the standard way to change the visibility of pages in the Isolated VM case. Then hv_mark_gpa_visibility() could be static and it would not need a stub version for ARM64. It would only be called by __hv_set_mem_host_visibility below, and in turn by set_memory_encrypted()/decrypted(). =20 > + > +static int __hv_set_mem_host_visibility(void *kbuffer, int pagecount, > + enum hv_mem_host_visibility visibility) > +{ > + u64 *pfn_array; > + int ret =3D 0; > + int i, pfn; > + > + if (!hv_is_isolation_supported() || !hv_hypercall_pg) > + return 0; > + > + pfn_array =3D kmalloc(HV_HYP_PAGE_SIZE, GFP_KERNEL); > + if (!pfn_array) > + return -ENOMEM; > + > + for (i =3D 0, pfn =3D 0; i < pagecount; i++) { > + pfn_array[pfn] =3D virt_to_hvpfn(kbuffer + i * HV_HYP_PAGE_SIZE); > + pfn++; > + > + if (pfn =3D=3D HV_MAX_MODIFY_GPA_REP_COUNT || i =3D=3D pagecount - 1) = { > + ret =3D hv_mark_gpa_visibility(pfn, pfn_array, > + visibility); > + if (ret) > + goto err_free_pfn_array; > + pfn =3D 0; > + } > + } > + > + err_free_pfn_array: > + kfree(pfn_array); > + return ret; > +} > + > +/* > + * hv_set_mem_host_visibility - Set specified memory visible to host. > + * > + * In Isolation VM, all guest memory is encrypted from host and guest > + * needs to set memory visible to host via hvcall before sharing memory > + * with host. This function works as wrap of hv_mark_gpa_visibility() > + * with memory base and size. > + */ > +int hv_set_mem_host_visibility(unsigned long addr, int numpages, bool vi= sible) > +{ > + enum hv_mem_host_visibility visibility =3D visible ? > + VMBUS_PAGE_VISIBLE_READ_WRITE : VMBUS_PAGE_NOT_VISIBLE; > + > + return __hv_set_mem_host_visibility((void *)addr, numpages, visibility)= ; > +} Is there a need for this wrapper function? Couldn't the handling of the ho= st visibility enum be folded into __hv_set_mem_host_visibility() and the initi= al double underscore dropped? Maybe I missed it, but I don't see that __hv_set_mem_host_visibility() is called anyplace else. Just trying to av= oid complexity if it isn't really needed. > diff --git a/arch/x86/include/asm/hyperv-tlfs.h b/arch/x86/include/asm/hy= perv-tlfs.h > index 2322d6bd5883..381e88122a5f 100644 > --- a/arch/x86/include/asm/hyperv-tlfs.h > +++ b/arch/x86/include/asm/hyperv-tlfs.h > @@ -276,6 +276,23 @@ enum hv_isolation_type { > #define HV_X64_MSR_TIME_REF_COUNT HV_REGISTER_TIME_REF_COUNT > #define HV_X64_MSR_REFERENCE_TSC HV_REGISTER_REFERENCE_TSC >=20 > +/* Hyper-V memory host visibility */ > +enum hv_mem_host_visibility { > + VMBUS_PAGE_NOT_VISIBLE =3D 0, > + VMBUS_PAGE_VISIBLE_READ_ONLY =3D 1, > + VMBUS_PAGE_VISIBLE_READ_WRITE =3D 3 > +}; > + > +/* HvCallModifySparseGpaPageHostVisibility hypercall */ > +#define HV_MAX_MODIFY_GPA_REP_COUNT ((PAGE_SIZE / sizeof(u64)) - 2) > +struct hv_gpa_range_for_visibility { > + u64 partition_id; > + u32 host_visibility:2; > + u32 reserved0:30; > + u32 reserved1; > + u64 gpa_page_list[HV_MAX_MODIFY_GPA_REP_COUNT]; > +} __packed; > + > /* > * Declare the MSR used to setup pages used to communicate with the hype= rvisor. > */ > diff --git a/arch/x86/include/asm/mshyperv.h b/arch/x86/include/asm/mshyp= erv.h > index 37739a277ac6..ffb2af079c6b 100644 > --- a/arch/x86/include/asm/mshyperv.h > +++ b/arch/x86/include/asm/mshyperv.h > @@ -192,7 +192,9 @@ struct irq_domain *hv_create_pci_msi_domain(void); > int hv_map_ioapic_interrupt(int ioapic_id, bool level, int vcpu, int vec= tor, > struct hv_interrupt_entry *entry); > int hv_unmap_ioapic_interrupt(int ioapic_id, struct hv_interrupt_entry *= entry); > - > +int hv_mark_gpa_visibility(u16 count, const u64 pfn[], > + enum hv_mem_host_visibility visibility); > +int hv_set_mem_host_visibility(unsigned long addr, int numpages, bool vi= sible); > #else /* CONFIG_HYPERV */ > static inline void hyperv_init(void) {} > static inline void hyperv_setup_mmu_ops(void) {} > diff --git a/arch/x86/mm/pat/set_memory.c b/arch/x86/mm/pat/set_memory.c > index ad8a5c586a35..1e4a0882820a 100644 > --- a/arch/x86/mm/pat/set_memory.c > +++ b/arch/x86/mm/pat/set_memory.c > @@ -29,6 +29,8 @@ > #include > #include > #include > +#include > +#include >=20 > #include "../mm_internal.h" >=20 > @@ -1980,15 +1982,11 @@ int set_memory_global(unsigned long addr, int num= pages) > __pgprot(_PAGE_GLOBAL), 0); > } >=20 > -static int __set_memory_enc_dec(unsigned long addr, int numpages, bool e= nc) > +static int __set_memory_enc_pgtable(unsigned long addr, int numpages, bo= ol enc) > { > struct cpa_data cpa; > int ret; >=20 > - /* Nothing to do if memory encryption is not active */ > - if (!mem_encrypt_active()) > - return 0; > - > /* Should not be working on unaligned addresses */ > if (WARN_ONCE(addr & ~PAGE_MASK, "misaligned address: %#lx\n", addr)) > addr &=3D PAGE_MASK; > @@ -2023,6 +2021,17 @@ static int __set_memory_enc_dec(unsigned long addr= , int numpages, bool enc) > return ret; > } >=20 > +static int __set_memory_enc_dec(unsigned long addr, int numpages, bool e= nc) > +{ > + if (hv_is_isolation_supported()) > + return hv_set_mem_host_visibility(addr, numpages, !enc); > + > + if (mem_encrypt_active()) > + return __set_memory_enc_pgtable(addr, numpages, enc); > + > + return 0; > +} > + > int set_memory_encrypted(unsigned long addr, int numpages) > { > return __set_memory_enc_dec(addr, numpages, true); > diff --git a/include/asm-generic/hyperv-tlfs.h b/include/asm-generic/hype= rv-tlfs.h > index 56348a541c50..8ed6733d5146 100644 > --- a/include/asm-generic/hyperv-tlfs.h > +++ b/include/asm-generic/hyperv-tlfs.h > @@ -158,6 +158,7 @@ struct ms_hyperv_tsc_page { > #define HVCALL_RETARGET_INTERRUPT 0x007e > #define HVCALL_FLUSH_GUEST_PHYSICAL_ADDRESS_SPACE 0x00af > #define HVCALL_FLUSH_GUEST_PHYSICAL_ADDRESS_LIST 0x00b0 > +#define HVCALL_MODIFY_SPARSE_GPA_PAGE_HOST_VISIBILITY 0x00db >=20 > /* Extended hypercalls */ > #define HV_EXT_CALL_QUERY_CAPABILITIES 0x8001 > diff --git a/include/asm-generic/mshyperv.h b/include/asm-generic/mshyper= v.h > index 7537ae1db828..aa55447b9700 100644 > --- a/include/asm-generic/mshyperv.h > +++ b/include/asm-generic/mshyperv.h > @@ -254,6 +254,7 @@ bool hv_query_ext_cap(u64 cap_query); > static inline bool hv_is_hyperv_initialized(void) { return false; } > static inline bool hv_is_hibernation_supported(void) { return false; } > static inline void hyperv_cleanup(void) {} > +static inline hv_is_isolation_supported(void); > #endif /* CONFIG_HYPERV */ >=20 > #endif > -- > 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu Sep 02 00:17:40 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 00:17:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.176731.321629 (Exim 4.92) (envelope-from ) id 1mLaQG-0001Kd-77; Thu, 02 Sep 2021 00:17:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 176731.321629; Thu, 02 Sep 2021 00:17:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLaQG-0001KW-39; Thu, 02 Sep 2021 00:17:40 +0000 Received: by outflank-mailman (input) for mailman id 176731; Thu, 02 Sep 2021 00:17:39 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLaQF-0001KJ-7m for xen-devel@lists.xenproject.org; Thu, 02 Sep 2021 00:17:39 +0000 Received: from outbound.mail.eo.outlook.com (unknown [40.93.8.13]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 998183fd-87cc-4b4e-8529-d0b98a59f69d; Thu, 02 Sep 2021 00:17:36 +0000 (UTC) Received: from MWHPR21MB1593.namprd21.prod.outlook.com (2603:10b6:301:7c::11) by CO1PR21MB1314.namprd21.prod.outlook.com (2603:10b6:303:151::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.4; Thu, 2 Sep 2021 00:17:22 +0000 Received: from MWHPR21MB1593.namprd21.prod.outlook.com ([fe80::3c8b:6387:cd5:7d86]) by MWHPR21MB1593.namprd21.prod.outlook.com ([fe80::3c8b:6387:cd5:7d86%8]) with mapi id 15.20.4478.014; Thu, 2 Sep 2021 00:17:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 998183fd-87cc-4b4e-8529-d0b98a59f69d ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LfmIQHlIMHkqsDEAx8MQ1NAfCm8Ro4Ky/wpN3QRZZqC+gl24I3fBOBpaAoJ276Zn4/+W7dy3A4lBJqQ62Whv2d3K48CbNH7Rhos//THmKEOs2CH7ppX0wYO9pTwByCirxd7peIwJwAfWE5182t9MkY34906BI5iNMD6h2WrRZV194+8iA4ckgtIAgH9afbS7KEp6JUx2KXZVhvFMGdYFEU6DIaDUYaSI0WTmQzR57bo04IgRksMlZdnCmswT659u5mbwWNnKf3/v3UZtFlUGgqUemB42CjLGGy8qWMVHgPynoYB1PZ598QH60CxFJTc9m3vcNrrxayo8G3MO3gcnCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=owhgNgpehRNG4rXYBOXS5bq3vm/tUORmSSFhaZC5C1c=; b=J2j5p1zJj6tGbpheajl6tqdPVzbC73oG0tZiZKx1v3FPAHaRsjaUVrpBRw9iwA1npsTobm9MyZgTr9x3WIrOSosPbbar6hb8buls0dvgQlzGachFJosDiQMMwSIF+MCh/CY5Oi9SmDCM+8cbfmRSDTbMb7mHuYS0AELmkGpZX90DB6Mt4O/SZLCe/hr105Yl0c1mRR4V4riLQbDTB3TjyYMCMYMsVgmFAw9IKs6dpWnzV8vyMWyc+lqawHiGXawRyYftzdZ9JCC2/CdR3I+Pgl5RKSB/2uqti0dLVjHFpQr6yOZKPzdBh8JLBbRcVoZbga1ULR64YAqPePd42YNDXg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=owhgNgpehRNG4rXYBOXS5bq3vm/tUORmSSFhaZC5C1c=; b=ZskhXqZeDDAqP6hth/AVqP2hJ6V/pcbzmclUYaXy0ADUh1saL12nGxB4dWFO/MWBYPZYCeVYgOheGEye6uf+eTrppAbd31RRqUORI3N6aLT3qWwiCOWk0qMULnCsK9RhX41zy7/2vLb7BADf+XqyPZaE+Iv/otMaNSzzRljSsKg= From: Michael Kelley To: Tianyu Lan , KY Srinivasan , Haiyang Zhang , Stephen Hemminger , "wei.liu@kernel.org" , Dexuan Cui , "catalin.marinas@arm.com" , "will@kernel.org" , "tglx@linutronix.de" , "mingo@redhat.com" , "bp@alien8.de" , "x86@kernel.org" , "hpa@zytor.com" , "dave.hansen@linux.intel.com" , "luto@kernel.org" , "peterz@infradead.org" , "konrad.wilk@oracle.com" , "boris.ostrovsky@oracle.com" , "jgross@suse.com" , "sstabellini@kernel.org" , "joro@8bytes.org" , "davem@davemloft.net" , "kuba@kernel.org" , "jejb@linux.ibm.com" , "martin.petersen@oracle.com" , "gregkh@linuxfoundation.org" , "arnd@arndb.de" , "hch@lst.de" , "m.szyprowski@samsung.com" , "robin.murphy@arm.com" , "brijesh.singh@amd.com" , "thomas.lendacky@amd.com" , Tianyu Lan , "pgonda@google.com" , "martin.b.radev@gmail.com" , "akpm@linux-foundation.org" , "kirill.shutemov@linux.intel.com" , "rppt@kernel.org" , "hannes@cmpxchg.org" , "aneesh.kumar@linux.ibm.com" , "krish.sadhukhan@oracle.com" , "saravanand@fb.com" , "linux-arm-kernel@lists.infradead.org" , "xen-devel@lists.xenproject.org" , "rientjes@google.com" , "ardb@kernel.org" CC: "iommu@lists.linux-foundation.org" , "linux-arch@vger.kernel.org" , "linux-hyperv@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-scsi@vger.kernel.org" , "netdev@vger.kernel.org" , vkuznets , "parri.andrea@gmail.com" , "dave.hansen@intel.com" Subject: RE: [PATCH V4 04/13] hyperv: Mark vmbus ring buffer visible to host in Isolation VM Thread-Topic: [PATCH V4 04/13] hyperv: Mark vmbus ring buffer visible to host in Isolation VM Thread-Index: AQHXm2gHOMlvw7enDEWSDoli9Xi0FquJEt7Q Date: Thu, 2 Sep 2021 00:17:21 +0000 Message-ID: References: <20210827172114.414281-1-ltykernel@gmail.com> <20210827172114.414281-5-ltykernel@gmail.com> In-Reply-To: <20210827172114.414281-5-ltykernel@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ActionId=8b920a56-6992-44f3-a51e-d6ed365110c4;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=true;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Standard;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=Internal;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2021-08-28T15:53:27Z;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=microsoft.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 4cf4ec66-38f2-483e-19b0-08d96da708a2 x-ms-traffictypediagnostic: CO1PR21MB1314: x-ms-exchange-transport-forked: True x-ld-processed: 72f988bf-86f1-41af-91ab-2d7cd011db47,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:56; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: JS2keamfM0jx37N7WlgsOSbQHuA0Wn2B+meaecDh668t0uFHu1b6F9vaDvTBLx2VKFqIXQux4S7RdVg5kLwZAzhkddRHN09fdW0rHMs/zwus14Ri4c2uJZAjZNiJJxon53OVVyCnwptUWdC3djGkubA5Iufw+jkPnEqoh2bcjvVZwaJ3a/Spocbf0Z/3W+RTTnAph5VpUoFZW7YcPIUrJe/SdC+L54R1e+bf+r1PkjfCmpcyRDbOZWqSiQSuxWVcbOjJCizQpivEiGiZn3Z0/wpe/hEqtsUKigJRtrud00EoMtoOe7Rew3IEzgVp3SFOzaJaS2L8FQG64zrGBx0ZjbkSn7g5GZYkw4onVe2qtl7nIpkwZC5NAanU2BykM9Zw9nOUzo6RYgFKKtHaEJRJigK8FZccbFPztem2qGOaY+1MJTbSTAragATuoKZ+sz0OhzdupvCIZSb2WBMVG2MbmBGBjhZIjrq8oFj7vNxrPq+8Ad9DzLBivoyGQwKcybt7VHCSw8WwnfKpIc4kczVKYt2owMPsBvIxAoRS9dCpAbMxBVb3GZ3+NmD3iTXbDH8fptRTaCRYgnxB7Hgl4YNWId9Zc77Gcz9Oxk15pklkdCcwpAHlccCF8LsWK4fCFdEN98mOTflZE9UBbLCfDdBWEQuIa/E1jXCYSHt5xDO0T5gHlrFIQcoqLGXCmogNYVv5l0fDox/iMA7wNJEnBou53cOPq2lw5w8WxLGfarsrFWY= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR21MB1593.namprd21.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(26005)(10290500003)(7696005)(186003)(66946007)(6506007)(76116006)(38100700002)(8676002)(110136005)(9686003)(316002)(54906003)(71200400001)(38070700005)(8990500004)(86362001)(55016002)(2906002)(122000001)(508600001)(8936002)(4326008)(7406005)(5660300002)(7416002)(7366002)(33656002)(52536014)(83380400001)(82950400001)(30864003)(66556008)(82960400001)(921005)(66476007)(66446008)(64756008)(579004);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?myQ8QsXlfAfVc23WymszcgcfUlIfJShxhHjbJ2Aib3aynOpa5jp1m09TdBOP?= =?us-ascii?Q?44/cyx/EUsQn02ziq8stvkYyA2AH219MYTbHgkZ0PQO4uphUjo+EoK/6jX93?= =?us-ascii?Q?/8+oVNcd0ZzfI8oDPDi4KFFKM+NFIB79Ft6rQpuGGERSF2M9GJajNTIRyu+L?= =?us-ascii?Q?1uRGT6XJsA9+5xtqvTSffvm6KHvwD/L0Fk+XLjyzzqBJITEn01Ut/oB8ragL?= =?us-ascii?Q?Pe+gfGJlxHYB2GRd1yhJIESJhcX9jO9rIHeeNHguyzgosvuXiY5Kk98mKfqD?= =?us-ascii?Q?jnnrbNrvyu1KAQSh3O43imVdxYZVhcmTXw36md5kdZJr0BOJI5J2a+Bnzutj?= =?us-ascii?Q?x8Bcqs2PRM2nLaRVLxbU4VHAwd1Oc/pZLE1NimqV1Hrk+G18FlP7b6Hcg1iT?= =?us-ascii?Q?B41PuTjVN0HgdNDwzLbtAMjdpYkTYqKRX9Wu0NZnPgAboV8jKSZ8y55xPb9J?= =?us-ascii?Q?jYifbwG3d/3ObjcplK7DZIks7DZHsJmRKD7ZTD0L3ESwUMPRS5x9q1jSKUvu?= =?us-ascii?Q?IxPHYsR3u2mUH83T4g3F9l47fKXzRGyGB0kHvXiAEU+osfPJh4qGiKiKKLoB?= =?us-ascii?Q?u8PO4EDKyBxifNj43NynqQrRaivVnclmt1pvmGeMOOa6v/2c9zVQv4FSXWtK?= =?us-ascii?Q?96kaxaam2QlwCfG0kkO51XU7gyKY75KQWnCcntCuK1ONzTJY/8xBXxjw6LDG?= =?us-ascii?Q?R9mp2ZsMDUfoJ6pZuMGsczXz5TO1MqYX+ctwvqAMehPtgzigJ4mlXnfkdl+q?= =?us-ascii?Q?fG7LSyRXQtKq+gv5Gt2z+BmRgKLPMySLDihIpPqGVdsgh9hNuiwkv9C3bEbI?= =?us-ascii?Q?bhNdVeGjZVjKE0408/GwvocD2kymDt0j/+0DIfZu70ZcNoewYNPugEh9fNDG?= =?us-ascii?Q?Pi5QQZ8MRjqAlYBk/P2E6/pkwjIxxqLcbK2Oe6c1RqUaK0n2ix/F3e8OydKm?= =?us-ascii?Q?i/8FgDCGm+x2AIodelpK2kJlusSYbi9Sg4Y1Ti66LnG1si8mM3wf4V5R5U7w?= =?us-ascii?Q?AfqyAEhVwXJgTlZP7ckgQREkdKmpqp4qdott4zlHCxVYQAieh28g+Q17pEfC?= =?us-ascii?Q?lYm8rmVfpgxTLCJfM/8I1pOCLh0Nxj/Z6K9ThcY4wmqlKE3pbayzJ6+rwXrN?= =?us-ascii?Q?iiY+Ke6HBCWlHS4ZiYUsdqGGDFmZcqRBYEggP4RvI2NfsHaX8jBpzEY5XJOV?= =?us-ascii?Q?ZN7D50242CoX0WGg5ksLuGhXcTQo3GUnn1qwBft1qVmXW7hQVqUDMfG7Tufz?= =?us-ascii?Q?K+KjAfUJpRQucjdmLeoeEv3zKMTw1x5vYTkgAmexLc43Sko03RTL7tY3S3Z1?= =?us-ascii?Q?nvWdQTsTDtPen+Cxg/Z9ym3o?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR21MB1593.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4cf4ec66-38f2-483e-19b0-08d96da708a2 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Sep 2021 00:17:21.8744 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: RvDiBlbiojDhzzfcbdOFBQye/Pw0hBMnWGLgEzVinucglU+0phNLl1XfUwN/S83lBQSENW2MEid4+ZQm1OH2Wai4GCLnrqZil8MQ9Y0w9dU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR21MB1314 From: Tianyu Lan Sent: Friday, August 27, 2021 10:21 = AM >=20 > Mark vmbus ring buffer visible with set_memory_decrypted() when > establish gpadl handle. >=20 > Signed-off-by: Tianyu Lan > --- > Change since v3: > * Change vmbus_teardown_gpadl() parameter and put gpadl handle, > buffer and buffer size in the struct vmbus_gpadl. > --- > drivers/hv/channel.c | 36 ++++++++++++++++++++++++++++----- > drivers/net/hyperv/hyperv_net.h | 1 + > drivers/net/hyperv/netvsc.c | 16 +++++++++++---- > drivers/uio/uio_hv_generic.c | 14 +++++++++++-- > include/linux/hyperv.h | 8 +++++++- > 5 files changed, 63 insertions(+), 12 deletions(-) >=20 > diff --git a/drivers/hv/channel.c b/drivers/hv/channel.c > index f3761c73b074..82650beb3af0 100644 > --- a/drivers/hv/channel.c > +++ b/drivers/hv/channel.c > @@ -17,6 +17,7 @@ > #include > #include > #include > +#include > #include > #include >=20 > @@ -474,6 +475,13 @@ static int __vmbus_establish_gpadl(struct vmbus_chan= nel *channel, > if (ret) > return ret; >=20 > + ret =3D set_memory_decrypted((unsigned long)kbuffer, > + HVPFN_UP(size)); > + if (ret) { > + pr_warn("Failed to set host visibility for new GPADL %d.\n", ret); > + return ret; > + } > + > init_completion(&msginfo->waitevent); > msginfo->waiting_channel =3D channel; >=20 > @@ -549,6 +557,11 @@ static int __vmbus_establish_gpadl(struct vmbus_chan= nel *channel, > } >=20 > kfree(msginfo); > + > + if (ret) > + set_memory_encrypted((unsigned long)kbuffer, > + HVPFN_UP(size)); > + > return ret; > } >=20 > @@ -639,6 +652,7 @@ static int __vmbus_open(struct vmbus_channel *newchan= nel, > struct vmbus_channel_open_channel *open_msg; > struct vmbus_channel_msginfo *open_info =3D NULL; > struct page *page =3D newchannel->ringbuffer_page; > + struct vmbus_gpadl gpadl; > u32 send_pages, recv_pages; > unsigned long flags; > int err; > @@ -759,7 +773,10 @@ static int __vmbus_open(struct vmbus_channel *newcha= nnel, > error_free_info: > kfree(open_info); > error_free_gpadl: > - vmbus_teardown_gpadl(newchannel, newchannel->ringbuffer_gpadlhandle); > + gpadl.gpadl_handle =3D newchannel->ringbuffer_gpadlhandle; > + gpadl.buffer =3D page_address(newchannel->ringbuffer_page); > + gpadl.size =3D (send_pages + recv_pages) << PAGE_SHIFT; > + vmbus_teardown_gpadl(newchannel, &gpadl); > newchannel->ringbuffer_gpadlhandle =3D 0; > error_clean_ring: > hv_ringbuffer_cleanup(&newchannel->outbound); > @@ -806,7 +823,7 @@ EXPORT_SYMBOL_GPL(vmbus_open); > /* > * vmbus_teardown_gpadl -Teardown the specified GPADL handle > */ > -int vmbus_teardown_gpadl(struct vmbus_channel *channel, u32 gpadl_handle= ) > +int vmbus_teardown_gpadl(struct vmbus_channel *channel, struct vmbus_gpa= dl *gpadl) > { > struct vmbus_channel_gpadl_teardown *msg; > struct vmbus_channel_msginfo *info; > @@ -825,7 +842,7 @@ int vmbus_teardown_gpadl(struct vmbus_channel *channe= l, u32 gpadl_handle) >=20 > msg->header.msgtype =3D CHANNELMSG_GPADL_TEARDOWN; > msg->child_relid =3D channel->offermsg.child_relid; > - msg->gpadl =3D gpadl_handle; > + msg->gpadl =3D gpadl->gpadl_handle; >=20 > spin_lock_irqsave(&vmbus_connection.channelmsg_lock, flags); > list_add_tail(&info->msglistentry, > @@ -859,6 +876,12 @@ int vmbus_teardown_gpadl(struct vmbus_channel *chann= el, u32 gpadl_handle) > spin_unlock_irqrestore(&vmbus_connection.channelmsg_lock, flags); >=20 > kfree(info); > + > + ret =3D set_memory_encrypted((unsigned long)gpadl->buffer, > + HVPFN_UP(gpadl->size)); > + if (ret) > + pr_warn("Fail to set mem host visibility in GPADL teardown %d.\n", ret= ); > + > return ret; > } > EXPORT_SYMBOL_GPL(vmbus_teardown_gpadl); > @@ -896,6 +919,7 @@ void vmbus_reset_channel_cb(struct vmbus_channel *cha= nnel) > static int vmbus_close_internal(struct vmbus_channel *channel) > { > struct vmbus_channel_close_channel *msg; > + struct vmbus_gpadl gpadl; > int ret; >=20 > vmbus_reset_channel_cb(channel); > @@ -934,8 +958,10 @@ static int vmbus_close_internal(struct vmbus_channel= *channel) >=20 > /* Tear down the gpadl for the channel's ring buffer */ > else if (channel->ringbuffer_gpadlhandle) { > - ret =3D vmbus_teardown_gpadl(channel, > - channel->ringbuffer_gpadlhandle); > + gpadl.gpadl_handle =3D channel->ringbuffer_gpadlhandle; > + gpadl.buffer =3D page_address(channel->ringbuffer_page); > + gpadl.size =3D channel->ringbuffer_pagecount; > + ret =3D vmbus_teardown_gpadl(channel, &gpadl); > if (ret) { > pr_err("Close failed: teardown gpadl return %d\n", ret); > /* > diff --git a/drivers/net/hyperv/hyperv_net.h b/drivers/net/hyperv/hyperv_= net.h > index bc48855dff10..aa7c9962dbd8 100644 > --- a/drivers/net/hyperv/hyperv_net.h > +++ b/drivers/net/hyperv/hyperv_net.h > @@ -1082,6 +1082,7 @@ struct netvsc_device { >=20 > /* Send buffer allocated by us */ > void *send_buf; > + u32 send_buf_size; > u32 send_buf_gpadl_handle; > u32 send_section_cnt; > u32 send_section_size; > diff --git a/drivers/net/hyperv/netvsc.c b/drivers/net/hyperv/netvsc.c > index 7bd935412853..f19bffff6a63 100644 > --- a/drivers/net/hyperv/netvsc.c > +++ b/drivers/net/hyperv/netvsc.c > @@ -276,11 +276,14 @@ static void netvsc_teardown_recv_gpadl(struct hv_de= vice *device, > struct netvsc_device *net_device, > struct net_device *ndev) > { > + struct vmbus_gpadl gpadl; > int ret; >=20 > if (net_device->recv_buf_gpadl_handle) { > - ret =3D vmbus_teardown_gpadl(device->channel, > - net_device->recv_buf_gpadl_handle); > + gpadl.gpadl_handle =3D net_device->recv_buf_gpadl_handle; > + gpadl.buffer =3D net_device->recv_buf; > + gpadl.size =3D net_device->recv_buf_size; > + ret =3D vmbus_teardown_gpadl(device->channel, &gpadl); >=20 > /* If we failed here, we might as well return and have a leak > * rather than continue and a bugchk > @@ -298,11 +301,15 @@ static void netvsc_teardown_send_gpadl(struct hv_de= vice *device, > struct netvsc_device *net_device, > struct net_device *ndev) > { > + struct vmbus_gpadl gpadl; > int ret; >=20 > if (net_device->send_buf_gpadl_handle) { > - ret =3D vmbus_teardown_gpadl(device->channel, > - net_device->send_buf_gpadl_handle); > + gpadl.gpadl_handle =3D net_device->send_buf_gpadl_handle; > + gpadl.buffer =3D net_device->send_buf; > + gpadl.size =3D net_device->send_buf_size; > + > + ret =3D vmbus_teardown_gpadl(device->channel, &gpadl); >=20 > /* If we failed here, we might as well return and have a leak > * rather than continue and a bugchk > @@ -463,6 +470,7 @@ static int netvsc_init_buf(struct hv_device *device, > ret =3D -ENOMEM; > goto cleanup; > } > + net_device->send_buf_size =3D buf_size; >=20 > /* Establish the gpadl handle for this buffer on this > * channel. Note: This call uses the vmbus connection rather > diff --git a/drivers/uio/uio_hv_generic.c b/drivers/uio/uio_hv_generic.c > index 652fe2547587..13c5df8dd11d 100644 > --- a/drivers/uio/uio_hv_generic.c > +++ b/drivers/uio/uio_hv_generic.c > @@ -179,14 +179,24 @@ hv_uio_new_channel(struct vmbus_channel *new_sc) > static void > hv_uio_cleanup(struct hv_device *dev, struct hv_uio_private_data *pdata) > { > + struct vmbus_gpadl gpadl; > + > if (pdata->send_gpadl) { > - vmbus_teardown_gpadl(dev->channel, pdata->send_gpadl); > + gpadl.gpadl_handle =3D pdata->send_gpadl; > + gpadl.buffer =3D pdata->send_buf; > + gpadl.size =3D SEND_BUFFER_SIZE; > + > + vmbus_teardown_gpadl(dev->channel, &gpadl); > pdata->send_gpadl =3D 0; > vfree(pdata->send_buf); > } >=20 > if (pdata->recv_gpadl) { > - vmbus_teardown_gpadl(dev->channel, pdata->recv_gpadl); > + gpadl.gpadl_handle =3D pdata->recv_gpadl; > + gpadl.buffer =3D pdata->recv_buf; > + gpadl.size =3D RECV_BUFFER_SIZE; > + > + vmbus_teardown_gpadl(dev->channel, &gpadl); > pdata->recv_gpadl =3D 0; > vfree(pdata->recv_buf); > } > diff --git a/include/linux/hyperv.h b/include/linux/hyperv.h > index ddc8713ce57b..757e09606fd3 100644 > --- a/include/linux/hyperv.h > +++ b/include/linux/hyperv.h > @@ -803,6 +803,12 @@ struct vmbus_device { >=20 > #define VMBUS_DEFAULT_MAX_PKT_SIZE 4096 >=20 > +struct vmbus_gpadl { > + u32 gpadl_handle; > + u32 size; > + void *buffer; > +}; > + > struct vmbus_channel { > struct list_head listentry; >=20 > @@ -1195,7 +1201,7 @@ extern int vmbus_establish_gpadl(struct vmbus_chann= el *channel, > u32 *gpadl_handle); >=20 > extern int vmbus_teardown_gpadl(struct vmbus_channel *channel, > - u32 gpadl_handle); > + struct vmbus_gpadl *gpadl); >=20 > void vmbus_reset_channel_cb(struct vmbus_channel *channel); >=20 > -- > 2.25.1 This isn't quite what I had in mind in my comments on v3 of this patch series. My idea is to store the full struct vmbus_gpadl data structure in places where previously just the u32 gpadl_handle was stored. Then pass around a pointer to the struct vmbus_gpadl where previously just the gpadl_handle (or a pointer to it) was passed. This lets __vmbus_establish_gpadl() fill in the actual handle value as well the other info (buffer pointer and size) that vmbus_teardown_gpadl() needs. Callers of the gpadl functions don't need to worry about saving or finding the right info. Most of the changes are just tweaking the references to what is now a struct instead of a u32. =20 Here's a diff of what I had in mind. My version also has vmbus_teardown_gpadl() set the handle field to zero, rather than each caller having to do it. The code compiles, but I have not done a runtime test. This diff is a net +21 lines of code, whereas your v3 and v4 patches were both +51 lines of code. diff --git a/drivers/hv/channel.c b/drivers/hv/channel.c index f3761c7..fc041ae 100644 --- a/drivers/hv/channel.c +++ b/drivers/hv/channel.c @@ -17,6 +17,7 @@ #include #include #include +#include #include #include =20 @@ -456,7 +457,7 @@ static int create_gpadl_header(enum hv_gpadl_type type,= void *kbuffer, static int __vmbus_establish_gpadl(struct vmbus_channel *channel, enum hv_gpadl_type type, void *kbuffer, u32 size, u32 send_offset, - u32 *gpadl_handle) + struct vmbus_gpadl *gpadl_handle) { struct vmbus_channel_gpadl_header *gpadlmsg; struct vmbus_channel_gpadl_body *gpadl_body; @@ -474,6 +475,13 @@ static int __vmbus_establish_gpadl(struct vmbus_channe= l *channel, if (ret) return ret; =20 + ret =3D set_memory_decrypted((unsigned long)kbuffer, + HVPFN_UP(size)); + if (ret) { + pr_warn("Failed to set host visibility for new GPADL %d.\n", ret); + return ret; + } + init_completion(&msginfo->waitevent); msginfo->waiting_channel =3D channel; =20 @@ -537,7 +545,9 @@ static int __vmbus_establish_gpadl(struct vmbus_channel= *channel, } =20 /* At this point, we received the gpadl created msg */ - *gpadl_handle =3D gpadlmsg->gpadl; + gpadl_handle->handle =3D gpadlmsg->gpadl; + gpadl_handle->buffer =3D kbuffer; + gpadl_handle->size =3D size; =20 cleanup: spin_lock_irqsave(&vmbus_connection.channelmsg_lock, flags); @@ -549,6 +559,11 @@ static int __vmbus_establish_gpadl(struct vmbus_channe= l *channel, } =20 kfree(msginfo); + + if (ret) + set_memory_encrypted((unsigned long)kbuffer, + HVPFN_UP(size)); + return ret; } =20 @@ -561,7 +576,7 @@ static int __vmbus_establish_gpadl(struct vmbus_channel= *channel, * @gpadl_handle: some funky thing */ int vmbus_establish_gpadl(struct vmbus_channel *channel, void *kbuffer, - u32 size, u32 *gpadl_handle) + u32 size, struct vmbus_gpadl *gpadl_handle) { return __vmbus_establish_gpadl(channel, HV_GPADL_BUFFER, kbuffer, size, 0U, gpadl_handle); @@ -675,7 +690,7 @@ static int __vmbus_open(struct vmbus_channel *newchanne= l, goto error_clean_ring; =20 /* Establish the gpadl for the ring buffer */ - newchannel->ringbuffer_gpadlhandle =3D 0; + newchannel->ringbuffer_gpadlhandle.handle =3D 0; =20 err =3D __vmbus_establish_gpadl(newchannel, HV_GPADL_RING, page_address(newchannel->ringbuffer_page), @@ -701,7 +716,7 @@ static int __vmbus_open(struct vmbus_channel *newchanne= l, open_msg->header.msgtype =3D CHANNELMSG_OPENCHANNEL; open_msg->openid =3D newchannel->offermsg.child_relid; open_msg->child_relid =3D newchannel->offermsg.child_relid; - open_msg->ringbuffer_gpadlhandle =3D newchannel->ringbuffer_gpadlhandle; + open_msg->ringbuffer_gpadlhandle =3D newchannel->ringbuffer_gpadlhandle.h= andle; /* * The unit of ->downstream_ringbuffer_pageoffset is HV_HYP_PAGE and * the unit of ->ringbuffer_send_offset (i.e. send_pages) is PAGE, so @@ -759,8 +774,7 @@ static int __vmbus_open(struct vmbus_channel *newchanne= l, error_free_info: kfree(open_info); error_free_gpadl: - vmbus_teardown_gpadl(newchannel, newchannel->ringbuffer_gpadlhandle); - newchannel->ringbuffer_gpadlhandle =3D 0; + vmbus_teardown_gpadl(newchannel, &newchannel->ringbuffer_gpadlhandle); error_clean_ring: hv_ringbuffer_cleanup(&newchannel->outbound); hv_ringbuffer_cleanup(&newchannel->inbound); @@ -806,7 +820,7 @@ int vmbus_open(struct vmbus_channel *newchannel, /* * vmbus_teardown_gpadl -Teardown the specified GPADL handle */ -int vmbus_teardown_gpadl(struct vmbus_channel *channel, u32 gpadl_handle) +int vmbus_teardown_gpadl(struct vmbus_channel *channel, struct vmbus_gpadl= *gpadl) { struct vmbus_channel_gpadl_teardown *msg; struct vmbus_channel_msginfo *info; @@ -825,7 +839,7 @@ int vmbus_teardown_gpadl(struct vmbus_channel *channel,= u32 gpadl_handle) =20 msg->header.msgtype =3D CHANNELMSG_GPADL_TEARDOWN; msg->child_relid =3D channel->offermsg.child_relid; - msg->gpadl =3D gpadl_handle; + msg->gpadl =3D gpadl->handle; =20 spin_lock_irqsave(&vmbus_connection.channelmsg_lock, flags); list_add_tail(&info->msglistentry, @@ -844,6 +858,7 @@ int vmbus_teardown_gpadl(struct vmbus_channel *channel,= u32 gpadl_handle) goto post_msg_err; =20 wait_for_completion(&info->waitevent); + gpadl->handle =3D 0; =20 post_msg_err: /* @@ -859,6 +874,12 @@ int vmbus_teardown_gpadl(struct vmbus_channel *channel= , u32 gpadl_handle) spin_unlock_irqrestore(&vmbus_connection.channelmsg_lock, flags); =20 kfree(info); + + ret =3D set_memory_encrypted((unsigned long)gpadl->buffer, + HVPFN_UP(gpadl->size)); + if (ret) + pr_warn("Fail to set mem host visibility in GPADL teardown %d.\n", ret); + return ret; } EXPORT_SYMBOL_GPL(vmbus_teardown_gpadl); @@ -933,9 +954,9 @@ static int vmbus_close_internal(struct vmbus_channel *c= hannel) } =20 /* Tear down the gpadl for the channel's ring buffer */ - else if (channel->ringbuffer_gpadlhandle) { + else if (channel->ringbuffer_gpadlhandle.handle) { ret =3D vmbus_teardown_gpadl(channel, - channel->ringbuffer_gpadlhandle); + &channel->ringbuffer_gpadlhandle); if (ret) { pr_err("Close failed: teardown gpadl return %d\n", ret); /* @@ -943,8 +964,6 @@ static int vmbus_close_internal(struct vmbus_channel *c= hannel) * it is perhaps better to leak memory. */ } - - channel->ringbuffer_gpadlhandle =3D 0; } =20 if (!ret) diff --git a/drivers/net/hyperv/hyperv_net.h b/drivers/net/hyperv/hyperv_ne= t.h index bc48855..54cbce1 100644 --- a/drivers/net/hyperv/hyperv_net.h +++ b/drivers/net/hyperv/hyperv_net.h @@ -1075,14 +1075,14 @@ struct netvsc_device { /* Receive buffer allocated by us but manages by NetVSP */ void *recv_buf; u32 recv_buf_size; /* allocated bytes */ - u32 recv_buf_gpadl_handle; + struct vmbus_gpadl recv_buf_gpadl_handle; u32 recv_section_cnt; u32 recv_section_size; u32 recv_completion_cnt; =20 /* Send buffer allocated by us */ void *send_buf; - u32 send_buf_gpadl_handle; + struct vmbus_gpadl send_buf_gpadl_handle; u32 send_section_cnt; u32 send_section_size; unsigned long *send_section_map; diff --git a/drivers/net/hyperv/netvsc.c b/drivers/net/hyperv/netvsc.c index 7bd9354..585974c 100644 --- a/drivers/net/hyperv/netvsc.c +++ b/drivers/net/hyperv/netvsc.c @@ -278,9 +278,9 @@ static void netvsc_teardown_recv_gpadl(struct hv_device= *device, { int ret; =20 - if (net_device->recv_buf_gpadl_handle) { + if (net_device->recv_buf_gpadl_handle.handle) { ret =3D vmbus_teardown_gpadl(device->channel, - net_device->recv_buf_gpadl_handle); + &net_device->recv_buf_gpadl_handle); =20 /* If we failed here, we might as well return and have a leak * rather than continue and a bugchk @@ -290,7 +290,6 @@ static void netvsc_teardown_recv_gpadl(struct hv_device= *device, "unable to teardown receive buffer's gpadl\n"); return; } - net_device->recv_buf_gpadl_handle =3D 0; } } =20 @@ -300,9 +299,9 @@ static void netvsc_teardown_send_gpadl(struct hv_device= *device, { int ret; =20 - if (net_device->send_buf_gpadl_handle) { + if (net_device->send_buf_gpadl_handle.handle) { ret =3D vmbus_teardown_gpadl(device->channel, - net_device->send_buf_gpadl_handle); + &net_device->send_buf_gpadl_handle); =20 /* If we failed here, we might as well return and have a leak * rather than continue and a bugchk @@ -312,7 +311,6 @@ static void netvsc_teardown_send_gpadl(struct hv_device= *device, "unable to teardown send buffer's gpadl\n"); return; } - net_device->send_buf_gpadl_handle =3D 0; } } =20 @@ -380,7 +378,7 @@ static int netvsc_init_buf(struct hv_device *device, memset(init_packet, 0, sizeof(struct nvsp_message)); init_packet->hdr.msg_type =3D NVSP_MSG1_TYPE_SEND_RECV_BUF; init_packet->msg.v1_msg.send_recv_buf. - gpadl_handle =3D net_device->recv_buf_gpadl_handle; + gpadl_handle =3D net_device->recv_buf_gpadl_handle.handle; init_packet->msg.v1_msg. send_recv_buf.id =3D NETVSC_RECEIVE_BUFFER_ID; =20 @@ -482,7 +480,7 @@ static int netvsc_init_buf(struct hv_device *device, memset(init_packet, 0, sizeof(struct nvsp_message)); init_packet->hdr.msg_type =3D NVSP_MSG1_TYPE_SEND_SEND_BUF; init_packet->msg.v1_msg.send_send_buf.gpadl_handle =3D - net_device->send_buf_gpadl_handle; + net_device->send_buf_gpadl_handle.handle; init_packet->msg.v1_msg.send_send_buf.id =3D NETVSC_SEND_BUFFER_ID; =20 trace_nvsp_send(ndev, init_packet); diff --git a/drivers/uio/uio_hv_generic.c b/drivers/uio/uio_hv_generic.c index 652fe25..97e08e7 100644 --- a/drivers/uio/uio_hv_generic.c +++ b/drivers/uio/uio_hv_generic.c @@ -58,11 +58,11 @@ struct hv_uio_private_data { atomic_t refcnt; =20 void *recv_buf; - u32 recv_gpadl; + struct vmbus_gpadl recv_gpadl; char recv_name[32]; /* "recv_4294967295" */ =20 void *send_buf; - u32 send_gpadl; + struct vmbus_gpadl send_gpadl; char send_name[32]; }; =20 @@ -179,15 +179,13 @@ static int hv_uio_ring_mmap(struct file *filp, struct= kobject *kobj, static void hv_uio_cleanup(struct hv_device *dev, struct hv_uio_private_data *pdata) { - if (pdata->send_gpadl) { - vmbus_teardown_gpadl(dev->channel, pdata->send_gpadl); - pdata->send_gpadl =3D 0; + if (pdata->send_gpadl.handle) { + vmbus_teardown_gpadl(dev->channel, &pdata->send_gpadl); vfree(pdata->send_buf); } =20 - if (pdata->recv_gpadl) { - vmbus_teardown_gpadl(dev->channel, pdata->recv_gpadl); - pdata->recv_gpadl =3D 0; + if (pdata->recv_gpadl.handle) { + vmbus_teardown_gpadl(dev->channel, &pdata->recv_gpadl); vfree(pdata->recv_buf); } } diff --git a/include/linux/hyperv.h b/include/linux/hyperv.h index 2e859d2..a0d64c3 100644 --- a/include/linux/hyperv.h +++ b/include/linux/hyperv.h @@ -809,6 +809,12 @@ struct vmbus_device { =20 #define VMBUS_DEFAULT_MAX_PKT_SIZE 4096 =20 +struct vmbus_gpadl { + u32 handle; + u32 size; + void *buffer; +}; + struct vmbus_channel { struct list_head listentry; =20 @@ -828,7 +834,7 @@ struct vmbus_channel { bool rescind_ref; /* got rescind msg, got channel reference */ struct completion rescind_event; =20 - u32 ringbuffer_gpadlhandle; + struct vmbus_gpadl ringbuffer_gpadlhandle; =20 /* Allocated memory for ring buffer */ struct page *ringbuffer_page; @@ -1208,10 +1214,10 @@ extern int vmbus_sendpacket_mpb_desc(struct vmbus_c= hannel *channel, extern int vmbus_establish_gpadl(struct vmbus_channel *channel, void *kbuffer, u32 size, - u32 *gpadl_handle); + struct vmbus_gpadl *gpadl_handle); =20 extern int vmbus_teardown_gpadl(struct vmbus_channel *channel, - u32 gpadl_handle); + struct vmbus_gpadl *gpadl); =20 void vmbus_reset_channel_cb(struct vmbus_channel *channel); From xen-devel-bounces@lists.xenproject.org Thu Sep 02 00:20:42 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 00:20:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.176738.321639 (Exim 4.92) (envelope-from ) id 1mLaT7-0002mB-OT; Thu, 02 Sep 2021 00:20:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 176738.321639; Thu, 02 Sep 2021 00:20:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLaT7-0002m4-LX; Thu, 02 Sep 2021 00:20:37 +0000 Received: by outflank-mailman (input) for mailman id 176738; Thu, 02 Sep 2021 00:20:36 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLaT6-0002ly-6w for xen-devel@lists.xenproject.org; Thu, 02 Sep 2021 00:20:36 +0000 Received: from outbound.mail.eo.outlook.com (unknown [40.93.3.12]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 95582b6a-0b83-11ec-ae2d-12813bfff9fa; Thu, 02 Sep 2021 00:20:31 +0000 (UTC) Received: from MWHPR21MB1593.namprd21.prod.outlook.com (2603:10b6:301:7c::11) by MW2PR2101MB1019.namprd21.prod.outlook.com (2603:10b6:302:5::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.6; Thu, 2 Sep 2021 00:20:28 +0000 Received: from MWHPR21MB1593.namprd21.prod.outlook.com ([fe80::3c8b:6387:cd5:7d86]) by MWHPR21MB1593.namprd21.prod.outlook.com ([fe80::3c8b:6387:cd5:7d86%8]) with mapi id 15.20.4478.014; Thu, 2 Sep 2021 00:20:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 95582b6a-0b83-11ec-ae2d-12813bfff9fa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=k83v89YVVc0G1XqbkkLj6dfEwTSojS2fSelG4HtWtU1ErvNnbw40jyjzblBtrkNATS2YsG9I2fHM94o5F7gTPrg0ny+D0wMYqlzjt9gVEKHym5j1sMKXGyDhWi/kDeEsFYQbR/32jRqxhltZnFoUBzpHd3jBt9Crv7PeSVZY2sDfC0+PsFzh8Knca7Ecm+Jh6jMQoydr9piR4OHDALSIRw5N+M4xoD5Z6Pj9lMBuzD+8Fpw2wiqUDg86OnmLiQmTaTS1Jfnck5dyum8oSlIv0Ey9pB0g7PTizpg23ILWZn+MIE/Ukoou77lOrbwWbCR3cZKPJWaupYzyYZdWOCQE0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=uSAcrrAsaLphArkTow8aPf5W91AfPrV8zL6lQf1PILA=; b=HFZXSuxknTm3S2CREWA+2VhMCRMANvuHegWkDgbrBCoSrJkX0DoGM08rOXtpsNkqZKNTyziWu2AZ4gOz5OoohBrZMEVUXilTEHQTtJIpWySnKI/El6N/xYBNjGEiTXx9dyxVp3XvV4Vd8DP/IJxSEoiIrFfc2g1TfoTGUrJr+xVKXB41y33Bv25nQSVK0pWohTmadHb4HKhcaSd+ugHZb0GnVDS07y1noam21lnvriqCH8BnSK57ba8UXmxJ3OhFWV/5B9IlEUxDu1lFJMO+Efub9AkIyrK09eiMi43MgK4gMjvsZmmQyrJYmvfxQoDSWGbCB5xa+lwoWeCsfFllJg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uSAcrrAsaLphArkTow8aPf5W91AfPrV8zL6lQf1PILA=; b=AeuGe5LwAEiMrZh5Cu8Mwsy+8XYsLsfMr0CCy6lIyi296lgyc3vps0FxLTvaSFjbS0uYUHIsqc5BI3nSN+2wuVWKzi1ZpmnrMHwQVxvK0do9f0aeRpi+bkoDcm9WY79tnsKMyYxGI5B8AFd3lf9ni2tgjTkIdDkxeN/6sG9Uy+c= From: Michael Kelley To: Tianyu Lan , KY Srinivasan , Haiyang Zhang , Stephen Hemminger , "wei.liu@kernel.org" , Dexuan Cui , "catalin.marinas@arm.com" , "will@kernel.org" , "tglx@linutronix.de" , "mingo@redhat.com" , "bp@alien8.de" , "x86@kernel.org" , "hpa@zytor.com" , "dave.hansen@linux.intel.com" , "luto@kernel.org" , "peterz@infradead.org" , "konrad.wilk@oracle.com" , "boris.ostrovsky@oracle.com" , "jgross@suse.com" , "sstabellini@kernel.org" , "joro@8bytes.org" , "davem@davemloft.net" , "kuba@kernel.org" , "jejb@linux.ibm.com" , "martin.petersen@oracle.com" , "gregkh@linuxfoundation.org" , "arnd@arndb.de" , "hch@lst.de" , "m.szyprowski@samsung.com" , "robin.murphy@arm.com" , "brijesh.singh@amd.com" , "thomas.lendacky@amd.com" , Tianyu Lan , "pgonda@google.com" , "martin.b.radev@gmail.com" , "akpm@linux-foundation.org" , "kirill.shutemov@linux.intel.com" , "rppt@kernel.org" , "hannes@cmpxchg.org" , "aneesh.kumar@linux.ibm.com" , "krish.sadhukhan@oracle.com" , "saravanand@fb.com" , "linux-arm-kernel@lists.infradead.org" , "xen-devel@lists.xenproject.org" , "rientjes@google.com" , "ardb@kernel.org" CC: "iommu@lists.linux-foundation.org" , "linux-arch@vger.kernel.org" , "linux-hyperv@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-scsi@vger.kernel.org" , "netdev@vger.kernel.org" , vkuznets , "parri.andrea@gmail.com" , "dave.hansen@intel.com" Subject: RE: [PATCH V4 06/13] hyperv: Add ghcb hvcall support for SNP VM Thread-Topic: [PATCH V4 06/13] hyperv: Add ghcb hvcall support for SNP VM Thread-Index: AQHXm2f/0mSKj2OCNkCC+r4DaEQmJquKug9A Date: Thu, 2 Sep 2021 00:20:28 +0000 Message-ID: References: <20210827172114.414281-1-ltykernel@gmail.com> <20210827172114.414281-7-ltykernel@gmail.com> In-Reply-To: <20210827172114.414281-7-ltykernel@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ActionId=6d580330-91d6-4af5-96cd-a8d1305f2392;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=true;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Standard;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=Internal;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2021-08-29T17:08:06Z;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=microsoft.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 1ef6e0ca-5957-4140-2dba-08d96da777c1 x-ms-traffictypediagnostic: MW2PR2101MB1019: x-ms-exchange-transport-forked: True x-ld-processed: 72f988bf-86f1-41af-91ab-2d7cd011db47,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5236; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: hh48EIj+igbz1dMXOksKbSyyFrHFlI5LJftl0O2XFLfLUgWQoUQY+o7dG3cKu31K+5Qw055KqyXURz92W1+2KfZnMKi6fBkhlT1YtjLqke2U2qwjHGTTrk2C8Di8BFqsxE340VRpaRxpLqUa0HNwfZIwB8grGSABzGjQKajnFZfCP6ZMyiDwHyuoJXwLLwhci6qoUTePZTEC7YOsUKGRPT0k02KTDRddNI3ZcRZKo5RAcSVaFb1f9kxbHMJZorxewBJxTO37cJnIHbEYmwP+s9zgRaDY1g/lrLcTaM0ueULKPwYbXsX0bfvc28PRA41gwYNCex3cv1tTrVpfZ6gfA21kBWEuTItaZH832AGHqPTd4HXYVUly7MSKFND45t7piGGv3YvrBaU9vif0f2T88Ld04AXSqXU9+KDHvlS+VoKSSVghPyW+Pnrt3jRZqDIb/dr5PA5B9e97lKPfJn24CKl7vakZYKRSa/W2sLAMXpWskUt9Qb+sWlQxArdxzP5flFgPzL510Wsss17jYSOKbWFIB8nUP5AdgAj+QarEa2vVQ+dCMT8DvNfRJv8Tuo1pBkRMPvw5LgGRpvcMdKdePbIFdBhx5GngE+LZYl8FpWO+lBAr1L6SH88ZwgzZ5enyjAibAaIwOga3Q9w3l5bDgHcXQKiajMIuaUvn8aMch6AiXAKzOVsX51nRZ+ptWoBzOu28V9waKu8Mj6VkdejbA9LwFRIx3Bn1V64evmkF2Gs= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR21MB1593.namprd21.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(4326008)(66556008)(66476007)(64756008)(921005)(66446008)(10290500003)(26005)(55016002)(66946007)(2906002)(7416002)(82950400001)(82960400001)(52536014)(7366002)(5660300002)(7406005)(76116006)(6506007)(316002)(508600001)(8676002)(8990500004)(71200400001)(122000001)(9686003)(86362001)(7696005)(38100700002)(83380400001)(38070700005)(33656002)(186003)(8936002)(110136005)(54906003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?m6hUatX3Wt0L18oS1Yu9aEWLCF2uuZMJfEdIY7AHScXfuZuS9Vn1i5zr0kMX?= =?us-ascii?Q?UyDb74sjV+Y/mJVP7pmDTaxal7lh4mwvOZiQ+VHsLiSIrG2YLVgJhWrr2r+a?= =?us-ascii?Q?Scr7JKHoBNz3+yZuxgbPZ1zFJxLGdDtxv6Y0RtMQS367vHuFXdFz04f3D+ww?= =?us-ascii?Q?jKgV2pNzpRaFyzQrQbeEfuTDmzNs655TEp/TFFA9YGf4cnyjYzTDOg5m+a5Y?= =?us-ascii?Q?S/IH++PysmFJsXjboHB8rN/UXWNR0lpaEoqE3h8UNWvp3lltNcsrcEhykJcJ?= =?us-ascii?Q?bAnyMXKIGdQzfobT7jCFyyrPoCFGlMCktNWsBM7OsNqQZT3Wg+TgS1aqpXDK?= =?us-ascii?Q?oLXIjMSAx7Q0pu3Ehjk0dAKJM/maCVFKFoY3OVmgmllXgi/WVqms0+m1tU+f?= =?us-ascii?Q?J+z1W0iHOMDQub++FmeOuRPgaXHMIRr57ktzcK1awLP9FoBruaVk1YLFbC7A?= =?us-ascii?Q?0RFLu73/0BzK/7z+pgSrAoCV2+SVWYyZa2hzyWZ0Ba0P7hLCubCJtoKA6ZRx?= =?us-ascii?Q?ltkynVtjd3Jd/gTU+cpguMpE+0eyX66vM8VubA+dBhpLnoE42G+LszgFRAMh?= =?us-ascii?Q?+uQjnXszP5rFOGJhddSIK2RlWeSPcwUXl6KMXsjBWR919E0N2yb0fGhgGQ70?= =?us-ascii?Q?nLNLetSBMA/oyydd6Sojj/aNxR9lgqya8cVLCNR53YwqO/9LakQeyvX6vj3I?= =?us-ascii?Q?qEjf2bmrS/F/P5+fc/RfzTKmQXveg/PgV+FRtYOhXclhfT+4BNeS28UvRXNa?= =?us-ascii?Q?NmT0vvuVDsZoLBbpZCJ63MrwsiP2GoS97FxfijKyvCcNJYEMMSx2RYvVc/xT?= =?us-ascii?Q?hRWHnNrVDJAjIlzLOeq4B+TTxqxq4N3ZqUEAhuNKu6q/Zf9eJpVB97LL022l?= =?us-ascii?Q?xJ1wO91ryKPf8U14K92Yyle6LGG4663Z7+/3zQiDFcD2eOH329G6aWwHuoyW?= =?us-ascii?Q?1QOynDuZ9fk6nfDE4uM/CFH9Pl7/ugNM46BidxO1RrsyRTN4gPPj6zdkGLgE?= =?us-ascii?Q?IBzAV4EzkqKKO9j6h+M2n+IE23ECcRiPMTyxlrjFEgwn19RwPRxdV4jBqdVX?= =?us-ascii?Q?jgRjeyEgAicEeBdwk/iOs17bgx3ovSZxgMmNGixKevcERWyjtnS4EdIH+iR3?= =?us-ascii?Q?Zt9iO7TL8VoNLbH8F1Uqdd1nzK3Kup7b+7Li7tdNirudyfm+aTRQbh4dG0ir?= =?us-ascii?Q?zl0VAIGENIVsisC2yxxoLrn3pidcN0VOl+BCd8ISSux3/3kKRccNT0QliUHz?= =?us-ascii?Q?37EN7y/zvGP+yOt37yjUsOqcpuB0at/dOrdrZ40fn2+e0tIPCJ5XC2ANZa92?= =?us-ascii?Q?dI4XwIEaregrSP4uNqlmiQPU?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR21MB1593.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1ef6e0ca-5957-4140-2dba-08d96da777c1 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Sep 2021 00:20:28.3182 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 3eA+qo79/uH9Dbp62BmlOSNm51w8AwVRPXoN6jwWsBsxnooEZz+t3zwtKNtVVlv0ClKDK/DmKF0WXrAsb3MspbKkw+PcOVzmV2MNKBDKP2I= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2PR2101MB1019 From: Tianyu Lan Sent: Friday, August 27, 2021 10:21 = AM >=20 Subject line tag should probably be "x86/hyperv:" since the majority of the code added is under arch/x86. > hyperv provides ghcb hvcall to handle VMBus > HVCALL_SIGNAL_EVENT and HVCALL_POST_MESSAGE > msg in SNP Isolation VM. Add such support. >=20 > Signed-off-by: Tianyu Lan > --- > Change since v3: > * Add hv_ghcb_hypercall() stub function to avoid > compile error for ARM. > --- > arch/x86/hyperv/ivm.c | 71 ++++++++++++++++++++++++++++++++++ > drivers/hv/connection.c | 6 ++- > drivers/hv/hv.c | 8 +++- > drivers/hv/hv_common.c | 6 +++ > include/asm-generic/mshyperv.h | 1 + > 5 files changed, 90 insertions(+), 2 deletions(-) >=20 > diff --git a/arch/x86/hyperv/ivm.c b/arch/x86/hyperv/ivm.c > index f56fe4f73000..e761c67e2218 100644 > --- a/arch/x86/hyperv/ivm.c > +++ b/arch/x86/hyperv/ivm.c > @@ -17,10 +17,81 @@ > #include > #include >=20 > +#define GHCB_USAGE_HYPERV_CALL 1 > + > union hv_ghcb { > struct ghcb ghcb; > + struct { > + u64 hypercalldata[509]; > + u64 outputgpa; > + union { > + union { > + struct { > + u32 callcode : 16; > + u32 isfast : 1; > + u32 reserved1 : 14; > + u32 isnested : 1; > + u32 countofelements : 12; > + u32 reserved2 : 4; > + u32 repstartindex : 12; > + u32 reserved3 : 4; > + }; > + u64 asuint64; > + } hypercallinput; > + union { > + struct { > + u16 callstatus; > + u16 reserved1; > + u32 elementsprocessed : 12; > + u32 reserved2 : 20; > + }; > + u64 asunit64; > + } hypercalloutput; > + }; > + u64 reserved2; > + } hypercall; > } __packed __aligned(HV_HYP_PAGE_SIZE); >=20 > +u64 hv_ghcb_hypercall(u64 control, void *input, void *output, u32 input_= size) > +{ > + union hv_ghcb *hv_ghcb; > + void **ghcb_base; > + unsigned long flags; > + > + if (!hv_ghcb_pg) > + return -EFAULT; > + > + WARN_ON(in_nmi()); > + > + local_irq_save(flags); > + ghcb_base =3D (void **)this_cpu_ptr(hv_ghcb_pg); > + hv_ghcb =3D (union hv_ghcb *)*ghcb_base; > + if (!hv_ghcb) { > + local_irq_restore(flags); > + return -EFAULT; > + } > + > + hv_ghcb->ghcb.protocol_version =3D GHCB_PROTOCOL_MAX; > + hv_ghcb->ghcb.ghcb_usage =3D GHCB_USAGE_HYPERV_CALL; > + > + hv_ghcb->hypercall.outputgpa =3D (u64)output; > + hv_ghcb->hypercall.hypercallinput.asuint64 =3D 0; > + hv_ghcb->hypercall.hypercallinput.callcode =3D control; > + > + if (input_size) > + memcpy(hv_ghcb->hypercall.hypercalldata, input, input_size); > + > + VMGEXIT(); > + > + hv_ghcb->ghcb.ghcb_usage =3D 0xffffffff; > + memset(hv_ghcb->ghcb.save.valid_bitmap, 0, > + sizeof(hv_ghcb->ghcb.save.valid_bitmap)); > + > + local_irq_restore(flags); > + > + return hv_ghcb->hypercall.hypercalloutput.callstatus; The hypercall.hypercalloutput.callstatus value must be saved in a local variable *before* the call to local_irq_restore(). Then the local variable is the return value. Once local_irq_restore() is called, the GHCB page could get reused. > +} > + > void hv_ghcb_msr_write(u64 msr, u64 value) > { > union hv_ghcb *hv_ghcb; > diff --git a/drivers/hv/connection.c b/drivers/hv/connection.c > index 5e479d54918c..6d315c1465e0 100644 > --- a/drivers/hv/connection.c > +++ b/drivers/hv/connection.c > @@ -447,6 +447,10 @@ void vmbus_set_event(struct vmbus_channel *channel) >=20 > ++channel->sig_events; >=20 > - hv_do_fast_hypercall8(HVCALL_SIGNAL_EVENT, channel->sig_event); > + if (hv_isolation_type_snp()) > + hv_ghcb_hypercall(HVCALL_SIGNAL_EVENT, &channel->sig_event, > + NULL, sizeof(u64)); Better to use "sizeof(channel->sig_event)" instead of explicitly coding the type. > + else > + hv_do_fast_hypercall8(HVCALL_SIGNAL_EVENT, channel->sig_event); > } > EXPORT_SYMBOL_GPL(vmbus_set_event); > diff --git a/drivers/hv/hv.c b/drivers/hv/hv.c > index 97b21256a9db..d4531c64d9d3 100644 > --- a/drivers/hv/hv.c > +++ b/drivers/hv/hv.c > @@ -98,7 +98,13 @@ int hv_post_message(union hv_connection_id connection_= id, > aligned_msg->payload_size =3D payload_size; > memcpy((void *)aligned_msg->payload, payload, payload_size); >=20 > - status =3D hv_do_hypercall(HVCALL_POST_MESSAGE, aligned_msg, NULL); > + if (hv_isolation_type_snp()) > + status =3D hv_ghcb_hypercall(HVCALL_POST_MESSAGE, > + (void *)aligned_msg, NULL, > + sizeof(struct hv_input_post_message)); As above, use "sizeof(*aligned_msg)". > + else > + status =3D hv_do_hypercall(HVCALL_POST_MESSAGE, > + aligned_msg, NULL); >=20 > /* Preemption must remain disabled until after the hypercall > * so some other thread can't get scheduled onto this cpu and > diff --git a/drivers/hv/hv_common.c b/drivers/hv/hv_common.c > index 1fc82d237161..7be173a99f27 100644 > --- a/drivers/hv/hv_common.c > +++ b/drivers/hv/hv_common.c > @@ -289,3 +289,9 @@ void __weak hyperv_cleanup(void) > { > } > EXPORT_SYMBOL_GPL(hyperv_cleanup); > + > +u64 __weak hv_ghcb_hypercall(u64 control, void *input, void *output, u32= input_size) > +{ > + return HV_STATUS_INVALID_PARAMETER; > +} > +EXPORT_SYMBOL_GPL(hv_ghcb_hypercall); > diff --git a/include/asm-generic/mshyperv.h b/include/asm-generic/mshyper= v.h > index 04a687d95eac..0da45807c36a 100644 > --- a/include/asm-generic/mshyperv.h > +++ b/include/asm-generic/mshyperv.h > @@ -250,6 +250,7 @@ bool hv_is_hibernation_supported(void); > enum hv_isolation_type hv_get_isolation_type(void); > bool hv_is_isolation_supported(void); > bool hv_isolation_type_snp(void); > +u64 hv_ghcb_hypercall(u64 control, void *input, void *output, u32 input_= size); > void hyperv_cleanup(void); > bool hv_query_ext_cap(u64 cap_query); > #else /* CONFIG_HYPERV */ > -- > 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu Sep 02 00:21:33 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 00:21:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.176744.321650 (Exim 4.92) (envelope-from ) id 1mLaU1-0003aO-2f; Thu, 02 Sep 2021 00:21:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 176744.321650; Thu, 02 Sep 2021 00:21:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLaU0-0003aH-Vu; Thu, 02 Sep 2021 00:21:32 +0000 Received: by outflank-mailman (input) for mailman id 176744; Thu, 02 Sep 2021 00:21:31 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLaTz-0003aB-Gi for xen-devel@lists.xenproject.org; Thu, 02 Sep 2021 00:21:31 +0000 Received: from outbound.mail.eo.outlook.com (unknown [40.93.3.13]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id b67d74d0-0b83-11ec-ae2d-12813bfff9fa; Thu, 02 Sep 2021 00:21:27 +0000 (UTC) Received: from MWHPR21MB1593.namprd21.prod.outlook.com (2603:10b6:301:7c::11) by MW2PR2101MB1019.namprd21.prod.outlook.com (2603:10b6:302:5::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.6; Thu, 2 Sep 2021 00:21:24 +0000 Received: from MWHPR21MB1593.namprd21.prod.outlook.com ([fe80::3c8b:6387:cd5:7d86]) by MWHPR21MB1593.namprd21.prod.outlook.com ([fe80::3c8b:6387:cd5:7d86%8]) with mapi id 15.20.4478.014; Thu, 2 Sep 2021 00:21:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b67d74d0-0b83-11ec-ae2d-12813bfff9fa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DpFAEAVFtRJX1cTnnpRrX3R9Pm8gSHt0iXZHDYb88Ud8MzsVIKt0rQdFMcNLZlm0LHgQhOL99Xo1yH6JTnxDpqXM3nbtPc/lyPIkSLqLHLZTwFputX5NZuSiXZ1Vm/5dUyps0EGsiBAC+Zkmu8mGkINU3TAuGnAWNdNV+FTLQ47olsWuhp5cMEPn0NF8LFs6bt5cmSfhj64fBOim9HjOaa/K1lmSXDoPoPV7pi/bhcPz4r2koxMX1HcOi7j9DPIdLIOFmJBNWkig/PAr3XKHfCvBHkdMV9SIB5U6ph8xEpLJt9wnd9LMRcCevwtC4mcG8j0RVdO71mw22MbqfUCXLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=Mqf14wQtw+7JBy9v/vfQD5FN7Z7H44udWTOYeVPnD5A=; b=T7SuaRWd0/1riTDQu1TvUyEICtpJthhBkGQpZ9xd/R46UTMCDHn7592zKpzg8fGjXDrcUweNiNcOdwCpn255g4f5rrR+bRghzPBIutc5+TOt9j+bwpOL8QLrrtoE2nB59dRQii0R1PHyNnk+6leXMPfxnMQ2YBYjVaDdxK5zsx0LMi0FsMdgsrhthqSnZIpWKoK926sRFWFNDYuN+XB1H2EMIvkiP1x8rEF/kHJ/j160HRV/dzpdoBsVDqVI4j0/Taai6mlk+SL7f7MItqooweZ8SA9L/PgE6Go2J+hpnzd+1MUHUo4jY0pGfxSqXzMZvI0Wn/Ya7egdLwPvhWyb7w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Mqf14wQtw+7JBy9v/vfQD5FN7Z7H44udWTOYeVPnD5A=; b=WRS/XTElGOOmSfSxr8RARTjq6kei7DdGfXZSQeOIEASbO2LFrNR5iACVCa0FNfGdT8Ech8QPYtCIoRfUZyPbtGjgS24mc1NdB7q/Cz3nj6yOsvQENJfvSdJTcbz7ecGD4mXQUmgJd1rPOpCrQWUjQ0pstyJglbDhtysSDP3u2iM= From: Michael Kelley To: Tianyu Lan , KY Srinivasan , Haiyang Zhang , Stephen Hemminger , "wei.liu@kernel.org" , Dexuan Cui , "catalin.marinas@arm.com" , "will@kernel.org" , "tglx@linutronix.de" , "mingo@redhat.com" , "bp@alien8.de" , "x86@kernel.org" , "hpa@zytor.com" , "dave.hansen@linux.intel.com" , "luto@kernel.org" , "peterz@infradead.org" , "konrad.wilk@oracle.com" , "boris.ostrovsky@oracle.com" , "jgross@suse.com" , "sstabellini@kernel.org" , "joro@8bytes.org" , "davem@davemloft.net" , "kuba@kernel.org" , "jejb@linux.ibm.com" , "martin.petersen@oracle.com" , "gregkh@linuxfoundation.org" , "arnd@arndb.de" , "hch@lst.de" , "m.szyprowski@samsung.com" , "robin.murphy@arm.com" , "brijesh.singh@amd.com" , "thomas.lendacky@amd.com" , Tianyu Lan , "pgonda@google.com" , "martin.b.radev@gmail.com" , "akpm@linux-foundation.org" , "kirill.shutemov@linux.intel.com" , "rppt@kernel.org" , "hannes@cmpxchg.org" , "aneesh.kumar@linux.ibm.com" , "krish.sadhukhan@oracle.com" , "saravanand@fb.com" , "linux-arm-kernel@lists.infradead.org" , "xen-devel@lists.xenproject.org" , "rientjes@google.com" , "ardb@kernel.org" CC: "iommu@lists.linux-foundation.org" , "linux-arch@vger.kernel.org" , "linux-hyperv@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-scsi@vger.kernel.org" , "netdev@vger.kernel.org" , vkuznets , "parri.andrea@gmail.com" , "dave.hansen@intel.com" Subject: RE: [PATCH V4 07/13] hyperv/Vmbus: Add SNP support for VMbus channel initiate message Thread-Topic: [PATCH V4 07/13] hyperv/Vmbus: Add SNP support for VMbus channel initiate message Thread-Index: AQHXm2gBdvpa+X8MqESuEZ+wA8gCQ6uKsPEw Date: Thu, 2 Sep 2021 00:21:24 +0000 Message-ID: References: <20210827172114.414281-1-ltykernel@gmail.com> <20210827172114.414281-8-ltykernel@gmail.com> In-Reply-To: <20210827172114.414281-8-ltykernel@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ActionId=18641334-deb6-4e85-959f-298ebfb11fed;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=true;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Standard;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=Internal;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2021-08-29T16:35:29Z;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=microsoft.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 24e4b7bc-b0c1-4b1d-8cec-08d96da7992c x-ms-traffictypediagnostic: MW2PR2101MB1019: x-ms-exchange-transport-forked: True x-ld-processed: 72f988bf-86f1-41af-91ab-2d7cd011db47,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4714; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: DXQW1zzjyK4YVkF1ykwSGWrws5AuKCpcL60tLoEFQfNz4OE7v47/9aWyCXZgxHs2OfyoZcU1s/7pzwcK52fMuoSWu1PLT7xQg5x+NXGlvDAteXE+bRTTu5C7JmM9cf/2hxdBi7dxz+byW25l9TH6FPHQXtzXk762upIUw5ry0c3Pr1eiLPXlq/LIDh6QE2o63LX3Xy5LT6qQb4tyEFDAb/YwY0XqAf8zRJefLyWPS9JzzHyCDX1iil4W9scABHTddjwPwm/bHHxSNCnQQqABixngwYIs9ohyjVegZPDSaPJGZR11lzkMUKWm9IJ2QBckpNcIhloJ0Uzuxf9XMUMrebWHwrLtz03RrlukRWZ5vntjeGGVTW5K12t1UWLRQF6FAnLTS4BV1QZA8MKVWOGBScX4xwOkwfWPWDXBtAQwmczPxhcnWyqNTiSwlYrh/TFYU/mYXrE3E8kjrrcnfGlUdGatu3caVm2uRDlE4gePdzoHkLtaNav+qKFK6bhDbVEBt3IhWL07HhCHC6hYM79cAnZT+2flvTVG1Gf0VFxMo3wkgFdULXl0lQ3HWqqm12h+lpyqnD0LKTlgnMm90tpc28EqQCqS7u4qQEvrAKXhQ4tAOI/Rkr5vOrYnODFp62MOFDvITTOuj0zK+Y3EzRUZ/n81hEdVy75UbEOqPIswBIX6jtaPxpAJv50Qn0XgAJtZ7yq9Z7TM8nothzzVnV6+LM8gBzUt6RFI+fEsu7PyjeM= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR21MB1593.namprd21.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(4326008)(66556008)(66476007)(64756008)(921005)(66446008)(10290500003)(26005)(55016002)(66946007)(2906002)(7416002)(82950400001)(82960400001)(52536014)(7366002)(5660300002)(7406005)(76116006)(6506007)(316002)(508600001)(8676002)(8990500004)(15650500001)(71200400001)(122000001)(9686003)(86362001)(7696005)(38100700002)(83380400001)(38070700005)(33656002)(186003)(8936002)(110136005)(54906003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?80/e3gUgachnycbVd5r3uUqOemHZxHUVPdbVExd1VVw7E5+cFX8fzMliAkjq?= =?us-ascii?Q?NVp0Sl9gVYXLNgOrb/zhkTWrjhRVaF4CeExuSuBg+P/fILrA6B1oNqOXKgWf?= =?us-ascii?Q?3vhi5VovoPdDncZotT3ktFkm2RSpHFhUD5vfJ630psAWUbJsRlDna9xwSodE?= =?us-ascii?Q?v44mdrCLv13r36yBxZFbz5wXSaBDoyOdu0HKdn1/9/D2Y+HpKbVIlsdMYrfs?= =?us-ascii?Q?pFMsG25nU0W0T1GIfXfKp91MrnPhjkKLLrEJl49FO99T0y8lXidw1Eb0Slfa?= =?us-ascii?Q?qK615ya9jCH3C7YW89JJ2EdOi1b0lJZawwdw9tHVPzCPmc33B8/I9WghhPwn?= =?us-ascii?Q?1jj41MowK5iMTQ0J90rzxFWVy7nVZYrDQu+rHFYz3itwRl4wZAqziTdCz0dW?= =?us-ascii?Q?B5tIN4u0im/teed4Q5sLszoUKYkqGfzAN3HAe+k2AeFcslkf3pZCpEof4zog?= =?us-ascii?Q?Gp8Cq1ZJQkfyXTLpoh3fdYTieVKi6HuF3WHxr/N04ljtCt5bYwItS1byfczJ?= =?us-ascii?Q?tXoqwN1rWfYxEu5SenG0R3AIfpfOojO93WXgJUpmiPPxjQjJywulNeeAHU+B?= =?us-ascii?Q?ZvWpmlm5oF5HRBOjv+dkEFE0Iq1+io4hssD9Vx8TOqWapbOOTu2WaxE00h22?= =?us-ascii?Q?GUXsJlUi6HoOKvIgCwjbFRC4RATmrvlNLaX+8mnEGGtSuomDjAJwQOG46aNo?= =?us-ascii?Q?O7QNGTwIjIMKhnqfZ3SyJPX2ZuuCDd3+mudmIEJtpd1VuQgYxaAkfBZdHJgG?= =?us-ascii?Q?gG54nU29LkLgPVHoRroTR0EQwIhxpKtWun0RrrBBdoq8ZVObxZOeMGw1UObX?= =?us-ascii?Q?YTGu8kXnPSyyUUr9kKktZpU7fbjMxzNCvOcKFimKeMZ6YORnY2/UBPxsZenO?= =?us-ascii?Q?Gkl+AjHsucnAuZ43jVsBFH8nkBY37RZWOAj0LSlNrKUf5877ZgxEFO4l3jb9?= =?us-ascii?Q?nE9xfNOadBsiLxzbjj5u7zYqQ2ud6BkPBEQ6higZl2OCdJ2TL3f6CF7BZqqp?= =?us-ascii?Q?oLFRTqxVMmdyLMsUgCmb+aJtI3bOySO/wHX1w+wo1Iz2W/pJBOKc7kgBAjnw?= =?us-ascii?Q?BIxVDY2w9LkRchVClpu19mvsNJeu2kRf+3EyqXg+IiBSc0LukXRB7166NWXQ?= =?us-ascii?Q?yiEgcTn/sxrD4jAaiSlF1mdzt/OUAMZ8PBIkYXhVIMIMQ4irna/kHGmsfV3W?= =?us-ascii?Q?rngpaCeAJKB+7HPsP3UiOBC5PygUjaNt/iAL+UL9SrJ2g8UFuASFydBPjW2Z?= =?us-ascii?Q?PdDBZw0RxX+Y8zc7IHfy7E+Xwfv+EKL+EnDF3UMAjf0+wiBA0BULLPAkRYXU?= =?us-ascii?Q?6CHGz2V6NC6lwXkHoZh9vGKD?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR21MB1593.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 24e4b7bc-b0c1-4b1d-8cec-08d96da7992c X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Sep 2021 00:21:24.4076 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: r07DIs7vHswtxB9LhpsP5x44bMSZ3HFWS6aSop8iZ2SVU44k5Q6//diDx1yPWIqR6SKynf4MyuvRP4ypBuzp1/Qi0qvz5lF9wjYTwpI2mQY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2PR2101MB1019 From: Tianyu Lan Sent: Friday, August 27, 2021 10:21 = AM >=20 Subject line tag should be "Drivers: hv: vmbus:" > The monitor pages in the CHANNELMSG_INITIATE_CONTACT msg are shared > with host in Isolation VM and so it's necessary to use hvcall to set > them visible to host. In Isolation VM with AMD SEV SNP, the access > address should be in the extra space which is above shared gpa > boundary. So remap these pages into the extra address(pa + > shared_gpa_boundary). >=20 > Introduce monitor_pages_original[] in the struct vmbus_connection > to store monitor page virtual address returned by hv_alloc_hyperv_ > zeroed_page() and free monitor page via monitor_pages_original in > the vmbus_disconnect(). The monitor_pages[] is to used to access > monitor page and it is initialized to be equal with monitor_pages_ > original. The monitor_pages[] will be overridden in the isolation VM > with va of extra address. >=20 > Signed-off-by: Tianyu Lan > --- > Change since v3: > * Rename monitor_pages_va with monitor_pages_original > * free monitor page via monitor_pages_original and > monitor_pages is used to access monitor page. >=20 > Change since v1: > * Not remap monitor pages in the non-SNP isolation VM. > --- > drivers/hv/connection.c | 75 ++++++++++++++++++++++++++++++++++++--- > drivers/hv/hyperv_vmbus.h | 1 + > 2 files changed, 72 insertions(+), 4 deletions(-) >=20 > diff --git a/drivers/hv/connection.c b/drivers/hv/connection.c > index 6d315c1465e0..9a48d8115c87 100644 > --- a/drivers/hv/connection.c > +++ b/drivers/hv/connection.c > @@ -19,6 +19,7 @@ > #include > #include > #include > +#include > #include >=20 > #include "hyperv_vmbus.h" > @@ -104,6 +105,12 @@ int vmbus_negotiate_version(struct vmbus_channel_msg= info *msginfo, u32 version) >=20 > msg->monitor_page1 =3D virt_to_phys(vmbus_connection.monitor_pages[0]); > msg->monitor_page2 =3D virt_to_phys(vmbus_connection.monitor_pages[1]); > + > + if (hv_isolation_type_snp()) { > + msg->monitor_page1 +=3D ms_hyperv.shared_gpa_boundary; > + msg->monitor_page2 +=3D ms_hyperv.shared_gpa_boundary; > + } > + > msg->target_vcpu =3D hv_cpu_number_to_vp_number(VMBUS_CONNECT_CPU); >=20 > /* > @@ -148,6 +155,35 @@ int vmbus_negotiate_version(struct vmbus_channel_msg= info *msginfo, u32 version) > return -ECONNREFUSED; > } >=20 > + > + if (hv_is_isolation_supported()) { > + if (hv_isolation_type_snp()) { > + vmbus_connection.monitor_pages[0] > + =3D memremap(msg->monitor_page1, HV_HYP_PAGE_SIZE, > + MEMREMAP_WB); > + if (!vmbus_connection.monitor_pages[0]) > + return -ENOMEM; > + > + vmbus_connection.monitor_pages[1] > + =3D memremap(msg->monitor_page2, HV_HYP_PAGE_SIZE, > + MEMREMAP_WB); > + if (!vmbus_connection.monitor_pages[1]) { > + memunmap(vmbus_connection.monitor_pages[0]); > + return -ENOMEM; > + } > + } > + > + /* > + * Set memory host visibility hvcall smears memory > + * and so zero monitor pages here. > + */ > + memset(vmbus_connection.monitor_pages[0], 0x00, > + HV_HYP_PAGE_SIZE); > + memset(vmbus_connection.monitor_pages[1], 0x00, > + HV_HYP_PAGE_SIZE); > + > + } I still find it somewhat confusing to have the handling of the shared_gpa_boundary and memory mapping in the function for negotiating the VMbus version. I think the code works as written, but it would seem cleaner and easier to understand to precompute the physical addresses and do all the mapping and memory zero'ing in a single place in vmbus_connect(). Then the negotiate version function can focus on doing only the version negotiation. > + > return ret; > } >=20 > @@ -159,6 +195,7 @@ int vmbus_connect(void) > struct vmbus_channel_msginfo *msginfo =3D NULL; > int i, ret =3D 0; > __u32 version; > + u64 pfn[2]; >=20 > /* Initialize the vmbus connection */ > vmbus_connection.conn_state =3D CONNECTING; > @@ -216,6 +253,21 @@ int vmbus_connect(void) > goto cleanup; > } >=20 > + vmbus_connection.monitor_pages_original[0] > + =3D vmbus_connection.monitor_pages[0]; > + vmbus_connection.monitor_pages_original[1] > + =3D vmbus_connection.monitor_pages[1]; > + > + if (hv_is_isolation_supported()) { > + pfn[0] =3D virt_to_hvpfn(vmbus_connection.monitor_pages[0]); > + pfn[1] =3D virt_to_hvpfn(vmbus_connection.monitor_pages[1]); > + if (hv_mark_gpa_visibility(2, pfn, > + VMBUS_PAGE_VISIBLE_READ_WRITE)) { In Patch 4 of this series, host visibility for the specified buffer is done by calling set_memory_decrypted()/set_memory_encrypted(). Could the same be done here? The code would be more consistent overall with better encapsulation. hv_mark_gpa_visibility() would not need to be exported or need an ARM64 stub. set_memory_decrypted()/encrypted() seem to be the primary functions that should be used for this purpose, and they have already have the appropriate stubs for architectures that don't support memory encryption. > + ret =3D -EFAULT; > + goto cleanup; > + } > + } > + > msginfo =3D kzalloc(sizeof(*msginfo) + > sizeof(struct vmbus_channel_initiate_contact), > GFP_KERNEL); > @@ -284,6 +336,8 @@ int vmbus_connect(void) >=20 > void vmbus_disconnect(void) > { > + u64 pfn[2]; > + > /* > * First send the unload request to the host. > */ > @@ -303,10 +357,23 @@ void vmbus_disconnect(void) > vmbus_connection.int_page =3D NULL; > } >=20 > - hv_free_hyperv_page((unsigned long)vmbus_connection.monitor_pages[0]); > - hv_free_hyperv_page((unsigned long)vmbus_connection.monitor_pages[1]); > - vmbus_connection.monitor_pages[0] =3D NULL; > - vmbus_connection.monitor_pages[1] =3D NULL; > + if (hv_is_isolation_supported()) { > + memunmap(vmbus_connection.monitor_pages[0]); > + memunmap(vmbus_connection.monitor_pages[1]); > + > + pfn[0] =3D virt_to_hvpfn(vmbus_connection.monitor_pages[0]); > + pfn[1] =3D virt_to_hvpfn(vmbus_connection.monitor_pages[1]); > + hv_mark_gpa_visibility(2, pfn, VMBUS_PAGE_NOT_VISIBLE); Same comment about using set_memory_encrypted() instead. > + } > + > + hv_free_hyperv_page((unsigned long) > + vmbus_connection.monitor_pages_original[0]); > + hv_free_hyperv_page((unsigned long) > + vmbus_connection.monitor_pages_original[1]); > + vmbus_connection.monitor_pages_original[0] =3D > + vmbus_connection.monitor_pages[0] =3D NULL; > + vmbus_connection.monitor_pages_original[1] =3D > + vmbus_connection.monitor_pages[1] =3D NULL; > } >=20 > /* > diff --git a/drivers/hv/hyperv_vmbus.h b/drivers/hv/hyperv_vmbus.h > index 42f3d9d123a1..7cb11ef694da 100644 > --- a/drivers/hv/hyperv_vmbus.h > +++ b/drivers/hv/hyperv_vmbus.h > @@ -240,6 +240,7 @@ struct vmbus_connection { > * is child->parent notification > */ > struct hv_monitor_page *monitor_pages[2]; > + void *monitor_pages_original[2]; > struct list_head chn_msg_list; > spinlock_t channelmsg_lock; >=20 > -- > 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu Sep 02 00:23:27 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 00:23:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.176751.321661 (Exim 4.92) (envelope-from ) id 1mLaVq-0004Jl-Lb; Thu, 02 Sep 2021 00:23:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 176751.321661; Thu, 02 Sep 2021 00:23:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLaVq-0004Jd-IV; Thu, 02 Sep 2021 00:23:26 +0000 Received: by outflank-mailman (input) for mailman id 176751; Thu, 02 Sep 2021 00:23:25 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLaVp-0004JU-Lv for xen-devel@lists.xenproject.org; Thu, 02 Sep 2021 00:23:25 +0000 Received: from outbound.mail.eo.outlook.com (unknown [40.93.3.13]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id fa2cf48b-0b83-11ec-ae2d-12813bfff9fa; Thu, 02 Sep 2021 00:23:21 +0000 (UTC) Received: from MWHPR21MB1593.namprd21.prod.outlook.com (2603:10b6:301:7c::11) by MW2PR2101MB1019.namprd21.prod.outlook.com (2603:10b6:302:5::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.6; Thu, 2 Sep 2021 00:23:08 +0000 Received: from MWHPR21MB1593.namprd21.prod.outlook.com ([fe80::3c8b:6387:cd5:7d86]) by MWHPR21MB1593.namprd21.prod.outlook.com ([fe80::3c8b:6387:cd5:7d86%8]) with mapi id 15.20.4478.014; Thu, 2 Sep 2021 00:23:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fa2cf48b-0b83-11ec-ae2d-12813bfff9fa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=S8hY9iJsRcCnx9oyRQ/hspUHIv5ff5374Rs6oJjEBnrTbvDk5OVpo0Dytg9YAtPPhZr2l5bsIK+3ilDvmgjxGyhDo5DazVJGf5g3p9s+a7ifYE/OqB+IVNp6W/b1GDIf14H4eQPlzE5fHzkG9QcOTAaGkRXI0CheiguOKNcKQBwnDgTmC20tuonkdBTxywuHT+oa3OFcYQE4s+NacqVM7320m1M2DWs3PTUtXvlQlWH4xqX/50jUCo0tmFahSIIj/Oq7ny4p7lSYujeyDChp/0Ze+ZUy5UBVLgnyj/inOOjQp+xFjvmb3XKi38+uCARx9Yx0y7ezjshT6Ergk0biRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=qzrjg2Ld5ycVv0rSLliu9cUFTVcVw5lvAUeicQF2lCU=; b=TD5YCrNUvn78vMeILZY/K1kN7MDYqpxRmyv1nyfnfetEvkiiGIWOviUgmGTxUOT3tTz8DT6AcojE/n4UXu+xZujVVXiORo734A80/XxTJrls2GzULEfoo5gU20wm6ZO9C8LxbRPQHJt8ZPIubtjEJdOnrWFCsmEcCuk5mEFvdbGkkO11QK7njiEmOONbnL2RYCgWzLX+yJL8B7gQlzVffowcYscJWFwefoK/8KWpqtwihCvDRisT3CBgLgf1QciWejLJmWELbTH+YzPtVfqhhRSuy3TmZh07wf6x+5vBZzen2El8KBTx5ivWGaJ8+JpsJhC0VRrSnVJ9Qsl5D8CYHA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qzrjg2Ld5ycVv0rSLliu9cUFTVcVw5lvAUeicQF2lCU=; b=U5bibdZiNOinwuDMK081bP3N0/p7F9BHnGIsAEpvJQuA6Ihj7otxojR0zUqUnUiD0Yh4MRNEIdDf402n6pckNC3TDDyvLAY8dufxHi/UK6uoVZLuRrk7ZJ6pH91S32HeTbmhMDfTzCVd+wpm6DZK8k33MsTtVd3/LunuK+n82Qk= From: Michael Kelley To: Tianyu Lan , KY Srinivasan , Haiyang Zhang , Stephen Hemminger , "wei.liu@kernel.org" , Dexuan Cui , "catalin.marinas@arm.com" , "will@kernel.org" , "tglx@linutronix.de" , "mingo@redhat.com" , "bp@alien8.de" , "x86@kernel.org" , "hpa@zytor.com" , "dave.hansen@linux.intel.com" , "luto@kernel.org" , "peterz@infradead.org" , "konrad.wilk@oracle.com" , "boris.ostrovsky@oracle.com" , "jgross@suse.com" , "sstabellini@kernel.org" , "joro@8bytes.org" , "davem@davemloft.net" , "kuba@kernel.org" , "jejb@linux.ibm.com" , "martin.petersen@oracle.com" , "gregkh@linuxfoundation.org" , "arnd@arndb.de" , "hch@lst.de" , "m.szyprowski@samsung.com" , "robin.murphy@arm.com" , "brijesh.singh@amd.com" , "thomas.lendacky@amd.com" , Tianyu Lan , "pgonda@google.com" , "martin.b.radev@gmail.com" , "akpm@linux-foundation.org" , "kirill.shutemov@linux.intel.com" , "rppt@kernel.org" , "hannes@cmpxchg.org" , "aneesh.kumar@linux.ibm.com" , "krish.sadhukhan@oracle.com" , "saravanand@fb.com" , "linux-arm-kernel@lists.infradead.org" , "xen-devel@lists.xenproject.org" , "rientjes@google.com" , "ardb@kernel.org" CC: "iommu@lists.linux-foundation.org" , "linux-arch@vger.kernel.org" , "linux-hyperv@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-scsi@vger.kernel.org" , "netdev@vger.kernel.org" , vkuznets , "parri.andrea@gmail.com" , "dave.hansen@intel.com" Subject: RE: [PATCH V4 08/13] hyperv/vmbus: Initialize VMbus ring buffer for Isolation VM Thread-Topic: [PATCH V4 08/13] hyperv/vmbus: Initialize VMbus ring buffer for Isolation VM Thread-Index: AQHXm2gFIWSYU02+UUyReBHQOl5/ZauK4YnA Date: Thu, 2 Sep 2021 00:23:08 +0000 Message-ID: References: <20210827172114.414281-1-ltykernel@gmail.com> <20210827172114.414281-9-ltykernel@gmail.com> In-Reply-To: <20210827172114.414281-9-ltykernel@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ActionId=bc1bd6dd-73be-4423-bfec-d24cf5650634;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=true;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Standard;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=Internal;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2021-08-29T19:29:24Z;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=microsoft.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: fdd00e19-74c7-465e-488a-08d96da7d743 x-ms-traffictypediagnostic: MW2PR2101MB1019: x-ms-exchange-transport-forked: True x-ld-processed: 72f988bf-86f1-41af-91ab-2d7cd011db47,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1360; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: a/1uWWyCm6KRWpOZ3PLSe+hwH5KkYNdAfvjSkhJa6lFuCklklUG/XcyZBFKgN2AmmBkr2TBUHNINXZNh0dNw4ocmONb7WXoudBjauOPc3GnHW4Wg/qf5gmFold/8RyJO7lTfbQrenuk7lt8iraXKKwG1PTU24Fi5pm3jjxvzwoErjxm0Rk3pGEuIhCb2yt/jHdUohFwAJLrtIvyy/49dwrizA4T+wUah8Ydz/Zj4XnKnbNdJZSCobmq1u2VKgoxxZCODLTqyUjE3Mynw9xmlOYY8MMMaw1yZNSMDK45zhYSEjigcd6DBOcTRRVniT1qsRFMpwNpmtA+mIM+a0MUW86c0SFDSZoS+NbOp8J5RP9iFmaRdRmiMYYGYJ14vVmkrtqLCd0AD+jRbTPgTMWN2a3jem1lPpfnOSuZtLLjEI1s2CxJT2f+l3tIzzMp+U+vRsAwEYhRvlHT6+v47USlJufwuSsjmfG2BFgoRWAo8+LGnfd4cp/+f5KQDfPLigB7oTEGNKVc2sJR+T7Z5J1pQduSXsskar11wKYUD8XHYCaM2Qd4lsEPFR9Kmb92XK/YIsQrOiaGtJw21wMlwgUNUorsDwOXEkhWymepocLVf7Q94IDyyMEUBcLH/V5//3uUc2/Wdt0+z9PYdVcNrOKn9tLXZrqSsuMnIoDizHEX72nYhCg2KyUSvRmna68APZlkt4iw8SwP5mEH4CiXI407t1fR3sOBR6YA7uF5M0Xye0y0= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR21MB1593.namprd21.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(4326008)(66556008)(66476007)(64756008)(921005)(66446008)(10290500003)(26005)(55016002)(66946007)(2906002)(7416002)(82950400001)(82960400001)(52536014)(7366002)(5660300002)(7406005)(76116006)(6506007)(316002)(508600001)(8676002)(8990500004)(71200400001)(122000001)(9686003)(86362001)(7696005)(38100700002)(83380400001)(38070700005)(33656002)(186003)(8936002)(110136005)(54906003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?6XoYftWOuBZ8DMMdcUow8qMAsztK90BM4zwgFHqXCTT0/q3RP3X2SwCIN0AN?= =?us-ascii?Q?1CO7TSM7aUgUQLy7/CS7apcmkWvaltP9dLrgtfUDUC21iu4mseZZaxiPcowW?= =?us-ascii?Q?FMzfYbCUD/MFcaRSpeOttttCfjw3BU+ayYxvspuBvq37pb7GREN1+j54ihRI?= =?us-ascii?Q?q+YKDNIRsQ8e5q9Mm49uRK3NMEPv1wDKWzDX4Dr9DfKAC3P/szxR4vsOu5ji?= =?us-ascii?Q?an3hnegJR3hQpW5lgodD7eGTGEl+yACooBujO62NgBtEvX2F3cKyTtYGg7Dv?= =?us-ascii?Q?qxlWTBCFJ372GbfMENy6ySZbmimtyzpCb9XIr2BsANfKh7KQSIyNryOjHC+S?= =?us-ascii?Q?lei2n1cWW4Zkbp59Uow5NopFsoKMwh8GpQmwLoXvfg6tex7uXWqDWO0q6/2/?= =?us-ascii?Q?d1DZ9BhOXns3eLlElLCP432cZOsypM9iC9J7ZqLpPF9U9wSJQpqcP9ssyrRW?= =?us-ascii?Q?zWbSM3DX8sO/rXmASE5w4QQVm007eC3GdWNg19sRSWdWAQe6TufvoVdHG97T?= =?us-ascii?Q?z6aUCZyPbPwv9Hmv3voLunZ5wMGOrsjrDqeeEEBu0ra3tb7zQ33xsJrELABw?= =?us-ascii?Q?stXUSAkVZg/1YtJbdRvCmIYsghJ7CdGKEo8LWxfaV+/pzXGuRrYLVEKyzccg?= =?us-ascii?Q?uHS0Ac94KveJFfPz8X9ggjJWrkzeNt9GJ+9PA8Q3nXrtYgyBL+vk27ZAsNvV?= =?us-ascii?Q?Xo+wRjsh7oIVMxQOAwDmROPephgD8IaokpRhpnr3JWa0077FA9EpgtSnqOSg?= =?us-ascii?Q?148fkt6WhUETRuE9dcbdbDda9c4b0hJ5F1dMTS1I2UPgSpUo9LXXUh0LIDt8?= =?us-ascii?Q?8/k2FJkot+Nc82CvZvBob6T4ntN9duPJtHpnV0fZAEc0KZ5eyohvIJNyZlU1?= =?us-ascii?Q?kWzW0qNRF7ofsWr1haiGZfqkplyq+PShvF/9C80NnqZSWC2vLfgqGTjxMgDj?= =?us-ascii?Q?NUhxmBOvxs+284vS99i5RTaL26s28x/V3OdB5u38+M6+sblMeeYIARkqWaS/?= =?us-ascii?Q?v2Bpm45vyAYk7NPFqOpiuxPLKsbyFqdZgNeQUDMLoKmf58EBDi9qdbV2QbSh?= =?us-ascii?Q?rq1BiCTg6y0U9W1rBsL3quQ1AJFe8yqXkuELcZObY+COu/BQlUVZys9+mJiy?= =?us-ascii?Q?MZ7HJL41DJJmC/9yrNJn8rCb5Y3K+DR8K+S1IsrUflLh3r+MeuVTXs28LwwO?= =?us-ascii?Q?JNztev9TSSmPYmRm9g2k3TTuad7FbXxy8kfAQaX3/pbrSkVqTy+wpJSgR8yL?= =?us-ascii?Q?xyPkiLcnYOOQjVYm8k/3s/ZYp5fjpLDafvtV9xpv25hsgcalc+ravYcCs5BA?= =?us-ascii?Q?8MmkSCuy0Xlhbl8Au+1+r8+q?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR21MB1593.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fdd00e19-74c7-465e-488a-08d96da7d743 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Sep 2021 00:23:08.5814 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: bDiVg39aGq1FaXP2zo95/QN78I8IgtTSDrwy0TrxEwRiCpJ/PsqE6NddNnIMEFHdz5LmrkDwBlr26DPvAdo1fd6EHWSKXQK+l7enS4fOYHQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2PR2101MB1019 From: Tianyu Lan Sent: Friday, August 27, 2021 10:21 = AM >=20 Subject tag should be "Drivers: hv: vmbus: " > VMbus ring buffer are shared with host and it's need to > be accessed via extra address space of Isolation VM with > AMD SNP support. This patch is to map the ring buffer > address in extra address space via vmap_pfn(). Hyperv set > memory host visibility hvcall smears data in the ring buffer > and so reset the ring buffer memory to zero after mapping. >=20 > Signed-off-by: Tianyu Lan > --- > Change since v3: > * Remove hv_ringbuffer_post_init(), merge map > operation for Isolation VM into hv_ringbuffer_init() > * Call hv_ringbuffer_init() after __vmbus_establish_gpadl(). > --- > drivers/hv/Kconfig | 1 + > drivers/hv/channel.c | 19 +++++++------- > drivers/hv/ring_buffer.c | 56 ++++++++++++++++++++++++++++++---------- > 3 files changed, 54 insertions(+), 22 deletions(-) >=20 > diff --git a/drivers/hv/Kconfig b/drivers/hv/Kconfig > index d1123ceb38f3..dd12af20e467 100644 > --- a/drivers/hv/Kconfig > +++ b/drivers/hv/Kconfig > @@ -8,6 +8,7 @@ config HYPERV > || (ARM64 && !CPU_BIG_ENDIAN)) > select PARAVIRT > select X86_HV_CALLBACK_VECTOR if X86 > + select VMAP_PFN > help > Select this option to run Linux as a Hyper-V client operating > system. > diff --git a/drivers/hv/channel.c b/drivers/hv/channel.c > index 82650beb3af0..81f8629e4491 100644 > --- a/drivers/hv/channel.c > +++ b/drivers/hv/channel.c > @@ -679,15 +679,6 @@ static int __vmbus_open(struct vmbus_channel *newcha= nnel, > if (!newchannel->max_pkt_size) > newchannel->max_pkt_size =3D VMBUS_DEFAULT_MAX_PKT_SIZE; >=20 > - err =3D hv_ringbuffer_init(&newchannel->outbound, page, send_pages, 0); > - if (err) > - goto error_clean_ring; > - > - err =3D hv_ringbuffer_init(&newchannel->inbound, &page[send_pages], > - recv_pages, newchannel->max_pkt_size); > - if (err) > - goto error_clean_ring; > - > /* Establish the gpadl for the ring buffer */ > newchannel->ringbuffer_gpadlhandle =3D 0; >=20 > @@ -699,6 +690,16 @@ static int __vmbus_open(struct vmbus_channel *newcha= nnel, > if (err) > goto error_clean_ring; >=20 > + err =3D hv_ringbuffer_init(&newchannel->outbound, > + page, send_pages, 0); > + if (err) > + goto error_free_gpadl; > + > + err =3D hv_ringbuffer_init(&newchannel->inbound, &page[send_pages], > + recv_pages, newchannel->max_pkt_size); > + if (err) > + goto error_free_gpadl; > + > /* Create and init the channel open message */ > open_info =3D kzalloc(sizeof(*open_info) + > sizeof(struct vmbus_channel_open_channel), > diff --git a/drivers/hv/ring_buffer.c b/drivers/hv/ring_buffer.c > index 2aee356840a2..24d64d18eb65 100644 > --- a/drivers/hv/ring_buffer.c > +++ b/drivers/hv/ring_buffer.c > @@ -17,6 +17,8 @@ > #include > #include > #include > +#include > +#include >=20 > #include "hyperv_vmbus.h" >=20 > @@ -183,8 +185,10 @@ void hv_ringbuffer_pre_init(struct vmbus_channel *ch= annel) > int hv_ringbuffer_init(struct hv_ring_buffer_info *ring_info, > struct page *pages, u32 page_cnt, u32 max_pkt_size) > { > - int i; > struct page **pages_wraparound; > + unsigned long *pfns_wraparound; > + u64 pfn; > + int i; >=20 > BUILD_BUG_ON((sizeof(struct hv_ring_buffer) !=3D PAGE_SIZE)); >=20 > @@ -192,23 +196,49 @@ int hv_ringbuffer_init(struct hv_ring_buffer_info *= ring_info, > * First page holds struct hv_ring_buffer, do wraparound mapping for > * the rest. > */ > - pages_wraparound =3D kcalloc(page_cnt * 2 - 1, sizeof(struct page *), > - GFP_KERNEL); > - if (!pages_wraparound) > - return -ENOMEM; > + if (hv_isolation_type_snp()) { > + pfn =3D page_to_pfn(pages) + > + HVPFN_DOWN(ms_hyperv.shared_gpa_boundary); Use PFN_DOWN, not HVPFN_DOWN. This is all done in units of guest page size, not Hyper-V page size. >=20 > - pages_wraparound[0] =3D pages; > - for (i =3D 0; i < 2 * (page_cnt - 1); i++) > - pages_wraparound[i + 1] =3D &pages[i % (page_cnt - 1) + 1]; > + pfns_wraparound =3D kcalloc(page_cnt * 2 - 1, > + sizeof(unsigned long), GFP_KERNEL); > + if (!pfns_wraparound) > + return -ENOMEM; >=20 > - ring_info->ring_buffer =3D (struct hv_ring_buffer *) > - vmap(pages_wraparound, page_cnt * 2 - 1, VM_MAP, PAGE_KERNEL); > + pfns_wraparound[0] =3D pfn; > + for (i =3D 0; i < 2 * (page_cnt - 1); i++) > + pfns_wraparound[i + 1] =3D pfn + i % (page_cnt - 1) + 1; >=20 > - kfree(pages_wraparound); > + ring_info->ring_buffer =3D (struct hv_ring_buffer *) > + vmap_pfn(pfns_wraparound, page_cnt * 2 - 1, > + PAGE_KERNEL); > + kfree(pfns_wraparound); >=20 > + if (!ring_info->ring_buffer) > + return -ENOMEM; > + > + /* Zero ring buffer after setting memory host visibility. */ > + memset(ring_info->ring_buffer, 0x00, > + HV_HYP_PAGE_SIZE * page_cnt); The page_cnt parameter is in units of the guest page size. So this should use PAGE_SIZE, not HV_HYP_PAGE_SIZE. > + } else { > + pages_wraparound =3D kcalloc(page_cnt * 2 - 1, > + sizeof(struct page *), > + GFP_KERNEL); > + > + pages_wraparound[0] =3D pages; > + for (i =3D 0; i < 2 * (page_cnt - 1); i++) > + pages_wraparound[i + 1] =3D > + &pages[i % (page_cnt - 1) + 1]; > + > + ring_info->ring_buffer =3D (struct hv_ring_buffer *) > + vmap(pages_wraparound, page_cnt * 2 - 1, VM_MAP, > + PAGE_KERNEL); > + > + kfree(pages_wraparound); > + if (!ring_info->ring_buffer) > + return -ENOMEM; > + } With this patch, the code is a big "if" statement with two halves -- one when SNP isolation is in effect, and the other when not. The SNP isolation case does the work using PFNs with the shared_gpa_boundary added, while the other case does the same work but using struct page. Perhaps I'm missing something, but can both halves be combined and always do the work using PFNs? The only difference is whether to add the shared_gpa_boundary, and whether to zero the memory when done. So get the starting PFN, then have an "if" statement for whether to add the shared_gpa_boundary. Then everything else is the same. At the end, use an "if" statement to decide whether to zero the memory. It would really be better to have the logic in this algorithm coded only once. >=20 > - if (!ring_info->ring_buffer) > - return -ENOMEM; >=20 > ring_info->ring_buffer->read_index =3D > ring_info->ring_buffer->write_index =3D 0; > -- > 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu Sep 02 01:27:49 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 01:27:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.176761.321685 (Exim 4.92) (envelope-from ) id 1mLbVu-0003zp-B2; Thu, 02 Sep 2021 01:27:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 176761.321685; Thu, 02 Sep 2021 01:27:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLbVu-0003zi-6r; Thu, 02 Sep 2021 01:27:34 +0000 Received: by outflank-mailman (input) for mailman id 176761; Thu, 02 Sep 2021 01:27:33 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLbVt-0003zb-K0 for xen-devel@lists.xenproject.org; Thu, 02 Sep 2021 01:27:33 +0000 Received: from outbound.mail.eo.outlook.com (unknown [40.93.8.1]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id f217440e-29c0-4c22-a23c-3a3dc3d95c61; Thu, 02 Sep 2021 01:27:31 +0000 (UTC) Received: from MWHPR21MB1593.namprd21.prod.outlook.com (2603:10b6:301:7c::11) by MWHPR21MB0767.namprd21.prod.outlook.com (2603:10b6:300:76::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.0; Thu, 2 Sep 2021 01:27:14 +0000 Received: from MWHPR21MB1593.namprd21.prod.outlook.com ([fe80::3c8b:6387:cd5:7d86]) by MWHPR21MB1593.namprd21.prod.outlook.com ([fe80::3c8b:6387:cd5:7d86%8]) with mapi id 15.20.4478.014; Thu, 2 Sep 2021 01:27:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f217440e-29c0-4c22-a23c-3a3dc3d95c61 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PqH6zbdXDocj/kohzFNuFSZBk5b/2UyJU4cNNkSedGUI/Bt9AxktZr3L9inKZ89BLNZWRm8pjRFCVSdZmWh/D7zCDBnsK08tTqyTw8xnPM9T8qD795zce97qnANfvL4DnnQWxwCb2N4JEwDw0UEvFAm8otRci6Tysb/aS5cHwHhOfjMh3cXZAj1eIBlay6EwhFekB2EYr8FJCDpHO5MVGXV2/2iIorc6FfGOf9YZax4NWdmFeVRYUsLHy0SiExMp8GxVdCILOrEVCk4FOUhnoaVD2FX2c9FWXysJSUXRZcQi06bPgUZu/8NUdXzsATcF5LAx2D2WuDHfJe7lhyKDHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=BZ2kwHMnelplbCchdbwZ+ia6PwO7lsSSD7ssrmF5dHQ=; b=dp8QKS4leVE/cV8OgvsZK9JLaqJ7eGztPQq3Qf2qrspWwGLK2Ys0PMv8qGHsPkGBKmaiFNJTmyJ27T6w1rxsJvMl9L83mH/xVWiVI8vUNkIC7JexfSgzx8/Vfl2ISUmJltmBEjp7JSzWVHyZxHuNBprA5P5NHl3VMYE1zmE6ACs3LpDfNWq1FUjoNp6/EIAsZsvm/505P1UXIw2TKXH/GyQnyK8OB/FF5og9GMqmW87u5UvwctGCN7/F/sadvMj454yKssyDGfjXlwLOtm3AX9vao2CUITlniy2ov2giGs+dfJfYtvU2SyznIOQjF1qqwxTb1HWM5AvGNsY4v6VoPA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BZ2kwHMnelplbCchdbwZ+ia6PwO7lsSSD7ssrmF5dHQ=; b=YHOFezUF1yqpjllueuzWf+I0rHCtn83zrPTxn6ZddbZkFWosRcY7pGRkctpTaFd5I318INsrp+RQMmpsEpNjrO1bXE1mmqkIZDv0nFyFWs2LtR75VcpuZZTLMsJP0SuJTo3dkxZyNT5Z8InyQJ1QrId29JvNHTHxv7r7b4eyu1A= From: Michael Kelley To: Tianyu Lan , KY Srinivasan , Haiyang Zhang , Stephen Hemminger , "wei.liu@kernel.org" , Dexuan Cui , "catalin.marinas@arm.com" , "will@kernel.org" , "tglx@linutronix.de" , "mingo@redhat.com" , "bp@alien8.de" , "x86@kernel.org" , "hpa@zytor.com" , "dave.hansen@linux.intel.com" , "luto@kernel.org" , "peterz@infradead.org" , "konrad.wilk@oracle.com" , "boris.ostrovsky@oracle.com" , "jgross@suse.com" , "sstabellini@kernel.org" , "joro@8bytes.org" , "davem@davemloft.net" , "kuba@kernel.org" , "jejb@linux.ibm.com" , "martin.petersen@oracle.com" , "gregkh@linuxfoundation.org" , "arnd@arndb.de" , "hch@lst.de" , "m.szyprowski@samsung.com" , "robin.murphy@arm.com" , "brijesh.singh@amd.com" , "thomas.lendacky@amd.com" , Tianyu Lan , "pgonda@google.com" , "martin.b.radev@gmail.com" , "akpm@linux-foundation.org" , "kirill.shutemov@linux.intel.com" , "rppt@kernel.org" , "hannes@cmpxchg.org" , "aneesh.kumar@linux.ibm.com" , "krish.sadhukhan@oracle.com" , "saravanand@fb.com" , "linux-arm-kernel@lists.infradead.org" , "xen-devel@lists.xenproject.org" , "rientjes@google.com" , "ardb@kernel.org" CC: "iommu@lists.linux-foundation.org" , "linux-arch@vger.kernel.org" , "linux-hyperv@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-scsi@vger.kernel.org" , "netdev@vger.kernel.org" , vkuznets , "parri.andrea@gmail.com" , "dave.hansen@intel.com" Subject: RE: [PATCH V4 11/13] hyperv/IOMMU: Enable swiotlb bounce buffer for Isolation VM Thread-Topic: [PATCH V4 11/13] hyperv/IOMMU: Enable swiotlb bounce buffer for Isolation VM Thread-Index: AQHXm2gQQ4+yOBIZA0OE+jNjJUIyPauJR4sw Date: Thu, 2 Sep 2021 01:27:14 +0000 Message-ID: References: <20210827172114.414281-1-ltykernel@gmail.com> <20210827172114.414281-12-ltykernel@gmail.com> In-Reply-To: <20210827172114.414281-12-ltykernel@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ActionId=38142b78-d6f5-49b9-b305-836e5d853fb5;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=true;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Standard;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=Internal;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2021-08-28T19:01:59Z;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=microsoft.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6b34df77-4512-4c58-304d-08d96db0cbb2 x-ms-traffictypediagnostic: MWHPR21MB0767: x-ms-exchange-transport-forked: True x-ld-processed: 72f988bf-86f1-41af-91ab-2d7cd011db47,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:50; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: dNq0v0YJw7pRWijNhH6+mIFGGl3G+Qy79F9GPxBTEW6zvQTzNqClqowJIrhXZYp9GMtvZLsJp+tfuP2Tq9Qzulp93q84HKxOehoOdf6j5szdLfh8p6NKk4iBe0baCWKjhzr/XVFCpi2tzdKK7mhtiQXQdsKXcc+fAKRo/nIVdw1dBzrRoiMOsLwHrPNJl33LKNf/mTN2SCqHWsKWNnKgs70cJ27xsUSSU9jgWcxgraVidVFIrG+lJL0jVO7cL+tGq8qLvO0/E2f2dApLKfSVWxpmBzjXhM9KrqBRioxe2hXhZApwWIpsjYaGp37/uQZjdvb3HrwX4crtF5ITsReC2o5kK3wwjo37h/aJLeedmXT1rVes9TIc8Y6cUWGdejCHMoGfNYeisGNCby/L7jGOxFU4CXJgRRgKt+VRvayQwPh+fP+FsOEj9loTggZaNzdFNxYYj+QASN+y6ba9wth9UbMhI82frDFbwjruTQ1KnVrA7wIBMd4ZkpbfdkqkRbGIRGW11qQrY6a06A9mA4mnbSP/WIOH/9adlHFdVVA6F5WfiQWe7hUqMuqYC8DXeSz120oAzCMrDApGxQ5zZQ8MGTdwIfibzSrUc4ysz7CPc2G9TBXSbhSG+R2Aqxkuh7PuwyMx2hx3fuLZ2svCeqDC6n1ovPoJYs3UQU37UGg0XjVuR/ltirl+LZk8Sm+t5QRDajCrPxWnjESMJSZ46C9Cil2Ckv2R+mNO5DdNtc7RKUA= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR21MB1593.namprd21.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(7366002)(71200400001)(83380400001)(66476007)(66946007)(82950400001)(7416002)(316002)(38100700002)(7406005)(86362001)(9686003)(76116006)(921005)(66446008)(4326008)(64756008)(33656002)(10290500003)(2906002)(508600001)(186003)(7696005)(6506007)(55016002)(38070700005)(82960400001)(8676002)(122000001)(8936002)(52536014)(8990500004)(54906003)(26005)(5660300002)(110136005)(66556008);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?49jzUXvgf7ZLIZvLg6Q1/1eUHzzwc3TfIDOhgzDpWNqfBbBgjatdlOGSnacX?= =?us-ascii?Q?ENqJRp+Z0muZsNhTVYljQwAe/VGj2sStR4WnwzZc79blYZvjVMk+GG0MweJe?= =?us-ascii?Q?2JqqGqlvmjOnf4EXWk+S1brb/7E1P9hA5Oiawk0Zfw+v4bTMJIi/V6FXez2D?= =?us-ascii?Q?ci8LPNuzdPxLnUkIwX/5AfMsb+4g5Tm33b7LPpZMtiLGrhDTlCH9hRF6dz28?= =?us-ascii?Q?XQ+9iLPB0lid5Rd+ouoAatq4QEGqryt/JqQrDB64Arr+YXHMpGTYN5K81L9Y?= =?us-ascii?Q?wJF628NgGQSRV9cgx64AmqJ4pdV7onoO9aT3xMzSZ7uuxdkjtNm7cFyuKz7d?= =?us-ascii?Q?JdP4kC1d33iP9/Fy/9xiKq9fxhkEgySgN2uEJcwA62mHZoShL5HfMPw17oL1?= =?us-ascii?Q?2o5NLnScTG89+ja+xQQIH9+ZFXAmtNDxDLjQXexz4s3d7oZHGsRHDpkor/3z?= =?us-ascii?Q?Xz7K1yGKF1+d3geiaFVInqOs1B1PRX/ISoy66V8EJG83zv/tng4lN62g0VU6?= =?us-ascii?Q?EHFWVPQwulkliliYaj83EyaMBfE0tKy6lSA9i/e7aqiK/GVz+KdwRe/GM83C?= =?us-ascii?Q?3IqSpRfKdZHHrQfXW0b9Tz9m5791BaKicfzQLqopfkn+Bm9fAzOyLsDYPId/?= =?us-ascii?Q?rRPI/mORNTvsSZ43cQThwfR//IzO27dIfeRi4EqtEd4TmpkdxE6hNj7xIF2E?= =?us-ascii?Q?DY0hfGunCRPEpkvCxRGUVvRHxkzQ7Xi7lCTVYFCNkZRLEyPnk2DfzTfphJ5v?= =?us-ascii?Q?f1FhT8/5vTYzmdsBX7mDQuxMQb1pNuSND18uQ6wVzHML9exonLJWPKldospq?= =?us-ascii?Q?PfKItemm+7ZwQVg+Dfn+jlBmMuB0uiaFKZXWzB3xyMvwvy2H0gE5wETBA7pM?= =?us-ascii?Q?pYlH/htXd34h/GFdDYo8TqMI5lbfI1zQ7Xmpa01bOMRzT3yr7TvvLFx3ozXT?= =?us-ascii?Q?59AoBSq0rNeJfOXXJmMBTJHZbtZVg2lw9u0S788POdPmqLonKm/LA64/QtiU?= =?us-ascii?Q?nYnglQMC4AF/hH8P9+CyOOFokvkJeUrKsyyF7Hy9Wgy5QC1rSCS0xM7hOTLf?= =?us-ascii?Q?EF+5WVbpx6UKzzsgThY0B/RSWIk5wXoSLEr/aDXhWAhyPVUznQqaLoI1o7tg?= =?us-ascii?Q?DxYNRg48YTnP7nuF8p2UheDY/7jtOJGIz+cBnGn0brq9gya+pKXcNZU6fusb?= =?us-ascii?Q?lQghAss56HBsmXFDmJQVOp/5XUoBjjMle/4yh6rwurNoEWHZOaAGPgx9l3UA?= =?us-ascii?Q?ODSn8cZc52xyUtnnI4yHzECBTay9uqWw5IVAdqEZuTZHLr7+fX3XTOArA0q7?= =?us-ascii?Q?YItS/HFI811TBI46JLo079y1?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR21MB1593.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6b34df77-4512-4c58-304d-08d96db0cbb2 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Sep 2021 01:27:14.5072 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 2KGO2qEIsLkOxALKzCEuY2PwU2DdLRgZF+IJZLEV/P7dB4OctEWxjII6iy63CCsAmyNnusPkM8cmgSdfqC69NrrNVbuVYcoMq/KOXZBRD5g= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR21MB0767 From: Tianyu Lan Sent: Friday, August 27, 2021 10:21 = AM >=20 > hyperv Isolation VM requires bounce buffer support to copy > data from/to encrypted memory and so enable swiotlb force > mode to use swiotlb bounce buffer for DMA transaction. >=20 > In Isolation VM with AMD SEV, the bounce buffer needs to be > accessed via extra address space which is above shared_gpa_boundary > (E.G 39 bit address line) reported by Hyper-V CPUID ISOLATION_CONFIG. > The access physical address will be original physical address + > shared_gpa_boundary. The shared_gpa_boundary in the AMD SEV SNP > spec is called virtual top of memory(vTOM). Memory addresses below > vTOM are automatically treated as private while memory above > vTOM is treated as shared. >=20 > Swiotlb bounce buffer code calls dma_map_decrypted() > to mark bounce buffer visible to host and map it in extra > address space. Populate dma memory decrypted ops with hv > map/unmap function. >=20 > Hyper-V initalizes swiotlb bounce buffer and default swiotlb > needs to be disabled. pci_swiotlb_detect_override() and > pci_swiotlb_detect_4gb() enable the default one. To override > the setting, hyperv_swiotlb_detect() needs to run before > these detect functions which depends on the pci_xen_swiotlb_ > init(). Make pci_xen_swiotlb_init() depends on the hyperv_swiotlb > _detect() to keep the order. >=20 > The map function vmap_pfn() can't work in the early place > hyperv_iommu_swiotlb_init() and so initialize swiotlb bounce > buffer in the hyperv_iommu_swiotlb_later_init(). >=20 > Signed-off-by: Tianyu Lan > --- > Change since v3: > * Get hyperv bounce bufffer size via default swiotlb > bounce buffer size function and keep default size as > same as the one in the AMD SEV VM. > --- > arch/x86/hyperv/ivm.c | 28 +++++++++++++++ > arch/x86/include/asm/mshyperv.h | 2 ++ > arch/x86/mm/mem_encrypt.c | 3 +- > arch/x86/xen/pci-swiotlb-xen.c | 3 +- > drivers/hv/vmbus_drv.c | 3 ++ > drivers/iommu/hyperv-iommu.c | 61 +++++++++++++++++++++++++++++++++ > include/linux/hyperv.h | 1 + > 7 files changed, 99 insertions(+), 2 deletions(-) >=20 > diff --git a/arch/x86/hyperv/ivm.c b/arch/x86/hyperv/ivm.c > index e761c67e2218..84563b3c9f3a 100644 > --- a/arch/x86/hyperv/ivm.c > +++ b/arch/x86/hyperv/ivm.c > @@ -294,3 +294,31 @@ int hv_set_mem_host_visibility(unsigned long addr, i= nt numpages, bool visible) >=20 > return __hv_set_mem_host_visibility((void *)addr, numpages, visibility)= ; > } > + > +/* > + * hv_map_memory - map memory to extra space in the AMD SEV-SNP Isolatio= n VM. > + */ > +void *hv_map_memory(void *addr, unsigned long size) > +{ > + unsigned long *pfns =3D kcalloc(size / HV_HYP_PAGE_SIZE, > + sizeof(unsigned long), GFP_KERNEL); Should be PAGE_SIZE, not HV_HYP_PAGE_SIZE, since this code only manipulates guest page tables. There's no communication with Hyper-V that requires HV_HYP_PAGE_SIZE. > + void *vaddr; > + int i; > + > + if (!pfns) > + return NULL; > + > + for (i =3D 0; i < size / PAGE_SIZE; i++) > + pfns[i] =3D virt_to_hvpfn(addr + i * PAGE_SIZE) + Use virt_to_pfn(), not virt_to_hvpfn(), for the same reason. > + (ms_hyperv.shared_gpa_boundary >> PAGE_SHIFT); > + > + vaddr =3D vmap_pfn(pfns, size / PAGE_SIZE, PAGE_KERNEL_IO); > + kfree(pfns); > + > + return vaddr; > +} > + > +void hv_unmap_memory(void *addr) > +{ > + vunmap(addr); > +} > diff --git a/arch/x86/include/asm/mshyperv.h b/arch/x86/include/asm/mshyp= erv.h > index b77f4caee3ee..627fcf8d443c 100644 > --- a/arch/x86/include/asm/mshyperv.h > +++ b/arch/x86/include/asm/mshyperv.h > @@ -252,6 +252,8 @@ int hv_unmap_ioapic_interrupt(int ioapic_id, struct h= v_interrupt_entry *entry); > int hv_mark_gpa_visibility(u16 count, const u64 pfn[], > enum hv_mem_host_visibility visibility); > int hv_set_mem_host_visibility(unsigned long addr, int numpages, bool vi= sible); > +void *hv_map_memory(void *addr, unsigned long size); > +void hv_unmap_memory(void *addr); > void hv_sint_wrmsrl_ghcb(u64 msr, u64 value); > void hv_sint_rdmsrl_ghcb(u64 msr, u64 *value); > void hv_signal_eom_ghcb(void); > diff --git a/arch/x86/mm/mem_encrypt.c b/arch/x86/mm/mem_encrypt.c > index ff08dc463634..e2db0b8ed938 100644 > --- a/arch/x86/mm/mem_encrypt.c > +++ b/arch/x86/mm/mem_encrypt.c > @@ -30,6 +30,7 @@ > #include > #include > #include > +#include >=20 > #include "mm_internal.h" >=20 > @@ -202,7 +203,7 @@ void __init sev_setup_arch(void) > phys_addr_t total_mem =3D memblock_phys_mem_size(); > unsigned long size; >=20 > - if (!sev_active()) > + if (!sev_active() && !hv_is_isolation_supported()) > return; >=20 > /* > diff --git a/arch/x86/xen/pci-swiotlb-xen.c b/arch/x86/xen/pci-swiotlb-xe= n.c > index 54f9aa7e8457..43bd031aa332 100644 > --- a/arch/x86/xen/pci-swiotlb-xen.c > +++ b/arch/x86/xen/pci-swiotlb-xen.c > @@ -4,6 +4,7 @@ >=20 > #include > #include > +#include > #include >=20 > #include > @@ -91,6 +92,6 @@ int pci_xen_swiotlb_init_late(void) > EXPORT_SYMBOL_GPL(pci_xen_swiotlb_init_late); >=20 > IOMMU_INIT_FINISH(pci_xen_swiotlb_detect, > - NULL, > + hyperv_swiotlb_detect, > pci_xen_swiotlb_init, > NULL); > diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c > index 57bbbaa4e8f7..f068e22a5636 100644 > --- a/drivers/hv/vmbus_drv.c > +++ b/drivers/hv/vmbus_drv.c > @@ -23,6 +23,7 @@ > #include > #include >=20 > +#include > #include > #include > #include > @@ -2081,6 +2082,7 @@ struct hv_device *vmbus_device_create(const guid_t = *type, > return child_device_obj; > } >=20 > +static u64 vmbus_dma_mask =3D DMA_BIT_MASK(64); > /* > * vmbus_device_register - Register the child device > */ > @@ -2121,6 +2123,7 @@ int vmbus_device_register(struct hv_device *child_d= evice_obj) > } > hv_debug_add_dev_dir(child_device_obj); >=20 > + child_device_obj->device.dma_mask =3D &vmbus_dma_mask; > return 0; >=20 > err_kset_unregister: > diff --git a/drivers/iommu/hyperv-iommu.c b/drivers/iommu/hyperv-iommu.c > index e285a220c913..899563551574 100644 > --- a/drivers/iommu/hyperv-iommu.c > +++ b/drivers/iommu/hyperv-iommu.c > @@ -13,14 +13,22 @@ > #include > #include > #include > +#include > +#include >=20 > #include > #include > #include > #include > +#include > +#include > #include > #include > #include > +#include > +#include > +#include > +#include >=20 > #include "irq_remapping.h" >=20 > @@ -36,6 +44,9 @@ > static cpumask_t ioapic_max_cpumask =3D { CPU_BITS_NONE }; > static struct irq_domain *ioapic_ir_domain; >=20 > +static unsigned long hyperv_io_tlb_size; > +static void *hyperv_io_tlb_start; > + > static int hyperv_ir_set_affinity(struct irq_data *data, > const struct cpumask *mask, bool force) > { > @@ -337,4 +348,54 @@ static const struct irq_domain_ops hyperv_root_ir_do= main_ops =3D { > .free =3D hyperv_root_irq_remapping_free, > }; >=20 > +void __init hyperv_iommu_swiotlb_init(void) > +{ > + /* > + * Allocate Hyper-V swiotlb bounce buffer at early place > + * to reserve large contiguous memory. > + */ > + hyperv_io_tlb_size =3D swiotlb_size_or_default(); > + hyperv_io_tlb_start =3D memblock_alloc( > + hyperv_io_tlb_size, HV_HYP_PAGE_SIZE); Could the alignment be specified as just PAGE_SIZE? I don't see any particular relationship here to the Hyper-V page size. > + > + if (!hyperv_io_tlb_start) { > + pr_warn("Fail to allocate Hyper-V swiotlb buffer.\n"); > + return; > + } > +} > + > +int __init hyperv_swiotlb_detect(void) > +{ > + if (hypervisor_is_type(X86_HYPER_MS_HYPERV) > + && hv_is_isolation_supported()) { > + /* > + * Enable swiotlb force mode in Isolation VM to > + * use swiotlb bounce buffer for dma transaction. > + */ > + swiotlb_force =3D SWIOTLB_FORCE; > + > + dma_memory_generic_decrypted_ops.map =3D hv_map_memory; > + dma_memory_generic_decrypted_ops.unmap =3D hv_unmap_memory; > + return 1; > + } > + > + return 0; > +} > + > +void __init hyperv_iommu_swiotlb_later_init(void) > +{ > + /* > + * Swiotlb bounce buffer needs to be mapped in extra address > + * space. Map function doesn't work in the early place and so > + * call swiotlb_late_init_with_tbl() here. > + */ > + if (swiotlb_late_init_with_tbl(hyperv_io_tlb_start, > + hyperv_io_tlb_size >> IO_TLB_SHIFT)) > + panic("Fail to initialize hyperv swiotlb.\n"); > +} > + > +IOMMU_INIT_FINISH(hyperv_swiotlb_detect, > + NULL, hyperv_iommu_swiotlb_init, > + hyperv_iommu_swiotlb_later_init); > + > #endif > diff --git a/include/linux/hyperv.h b/include/linux/hyperv.h > index 757e09606fd3..724a735d722a 100644 > --- a/include/linux/hyperv.h > +++ b/include/linux/hyperv.h > @@ -1739,6 +1739,7 @@ int hyperv_write_cfg_blk(struct pci_dev *dev, void = *buf, unsigned int len, > int hyperv_reg_block_invalidate(struct pci_dev *dev, void *context, > void (*block_invalidate)(void *context, > u64 block_mask)); > +int __init hyperv_swiotlb_detect(void); >=20 > struct hyperv_pci_block_ops { > int (*read_block)(struct pci_dev *dev, void *buf, unsigned int buf_len, > -- > 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu Sep 02 01:31:22 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 01:31:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.176770.321702 (Exim 4.92) (envelope-from ) id 1mLbZa-0005ge-3c; Thu, 02 Sep 2021 01:31:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 176770.321702; Thu, 02 Sep 2021 01:31:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLbZZ-0005gX-U7; Thu, 02 Sep 2021 01:31:21 +0000 Received: by outflank-mailman (input) for mailman id 176770; Thu, 02 Sep 2021 01:31:20 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLbZY-0005gR-6d for xen-devel@lists.xen.org; Thu, 02 Sep 2021 01:31:20 +0000 Received: from EUR03-AM5-obe.outbound.protection.outlook.com (unknown [40.107.3.73]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id ae9e7f78-35e3-404d-aa11-9ba934235093; Thu, 02 Sep 2021 01:31:12 +0000 (UTC) Received: from AM4PR0302CA0009.eurprd03.prod.outlook.com (2603:10a6:205:2::22) by AS8PR08MB7142.eurprd08.prod.outlook.com (2603:10a6:20b:402::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.23; Thu, 2 Sep 2021 01:30:45 +0000 Received: from VE1EUR03FT064.eop-EUR03.prod.protection.outlook.com (2603:10a6:205:2:cafe::d9) by AM4PR0302CA0009.outlook.office365.com (2603:10a6:205:2::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Thu, 2 Sep 2021 01:30:45 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT064.mail.protection.outlook.com (10.152.19.210) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.17 via Frontend Transport; Thu, 2 Sep 2021 01:30:44 +0000 Received: ("Tessian outbound 6ba9ec11d42b:v103"); Thu, 02 Sep 2021 01:30:43 +0000 Received: from c82113e1ef35.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 4A84C218-891F-4D71-9360-D6E99C6F380C.1; Thu, 02 Sep 2021 01:30:42 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id c82113e1ef35.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 02 Sep 2021 01:30:42 +0000 Received: from DB9PR08MB6857.eurprd08.prod.outlook.com (2603:10a6:10:2a2::7) by DB9PR08MB6890.eurprd08.prod.outlook.com (2603:10a6:10:2a8::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.23; Thu, 2 Sep 2021 01:30:36 +0000 Received: from DB9PR08MB6857.eurprd08.prod.outlook.com ([fe80::2c28:50cf:49fd:da32]) by DB9PR08MB6857.eurprd08.prod.outlook.com ([fe80::2c28:50cf:49fd:da32%7]) with mapi id 15.20.4457.026; Thu, 2 Sep 2021 01:30:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ae9e7f78-35e3-404d-aa11-9ba934235093 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AQMxAsYY4/hP7OgFAreOwfcANt90hvUXFToNMh6+Q7g=; b=JqPWYmrmfSLIwU5SPpKSHUtAKwQaPILY5Eam00Lr4bqt6xKqITBCnqPQGL+rEvv9stV9TWTuvmwhAjTXfrLQcJFrHQTjbZRWf+NFOs1ljkZE+HH2GzthwOLNFybs0vYr3rbCs8GLzh7b7imnumjVpT0/xcmmtd6H8SkGPxk1t6w= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; lists.xen.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;lists.xen.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SvRXmSb0duufpIrkmzkzF4DaOlSsSTpVEgPlUSWETocWkgn7zUkis24RazJZYMu+lYbfbSgTFOyHmkls7mM4bvcZ4/dYyg/HrCOlqI90efZ/unM8l7EK+19vnuO7PjmP1CFys5+kmrn//4QwpeT0j5g0VDigONk4FhJWmDqoiQMYuzsZd9GLEnU0HDWrVgKGIlfGDaDf3OuRoArtQmKddpH7G/84JWR6S971KqmKMXeJPb+/xqbTFcxkoBHWUUMAco3TvAS13kWXTFfGmxRfno4zfaNKeHnnFBsq6Anc+P2Ee/u6jtvpZGeUoN+Jc+o40pJpcAABqSGnTuTIjJF/QQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AQMxAsYY4/hP7OgFAreOwfcANt90hvUXFToNMh6+Q7g=; b=h00dH6vLO7SJXiYiJIEFxkxkcXk6/yfcrSZJLNlTA53aKU+vZKoVYqXgcvHc9Wf9vhom2A7SbUPVx0RYtOTD6MzilzSDeYk9M4xKq2rL6CRwqadfFNDM1R6fl1JYWV8xq7CkCmahbk/W3PjGlAK2+H5gz1DS5VkoxMET7Rb0sG5hQfaWGqqKRlODOAHttLvxnp/ZTtNLJd1g1/lYf6Qoz9eCFylqUbxx04nFZNpvaU1Q+uYWda1s8uymLgmDz5TP6gmLvhQa0777gBFJIFlysHKTWLM+p7lN3N1vYXrpjedlA+t/mAS7j0fcq6i7eMFk9AtUFt3ll/Xuzq1P5QdLOA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AQMxAsYY4/hP7OgFAreOwfcANt90hvUXFToNMh6+Q7g=; b=JqPWYmrmfSLIwU5SPpKSHUtAKwQaPILY5Eam00Lr4bqt6xKqITBCnqPQGL+rEvv9stV9TWTuvmwhAjTXfrLQcJFrHQTjbZRWf+NFOs1ljkZE+HH2GzthwOLNFybs0vYr3rbCs8GLzh7b7imnumjVpT0/xcmmtd6H8SkGPxk1t6w= From: Wei Chen To: AKASHI Takahiro CC: Oleksandr Tyshchenko , Stefano Stabellini , Alex Benn??e , Kaly Xin , Stratos Mailing List , "virtio-dev@lists.oasis-open.org" , Arnd Bergmann , Viresh Kumar , Stefano Stabellini , "stefanha@redhat.com" , Jan Kiszka , Carl van Schaik , "pratikp@quicinc.com" , Srivatsa Vaddagiri , Jean-Philippe Brucker , Mathieu Poirier , Oleksandr Tyshchenko , Bertrand Marquis , Artem Mygaiev , Julien Grall , Juergen Gross , Paul Durrant , nd , Xen Devel Subject: RE: Enabling hypervisor agnosticism for VirtIO backends Thread-Topic: Enabling hypervisor agnosticism for VirtIO backends Thread-Index: AQHXiWXOlXnRp9GT30mY/CfP5cid16tt4TUAgAVQpQCAAsKLQIABdsmAgAADLTCAAWVyAIAAMB+ggAMGMQCACZ/8gIAAKWUQgAd5oYCAAeKfwIAAF2QAgADY4nA= Date: Thu, 2 Sep 2021 01:30:34 +0000 Message-ID: References: <20210817080757.GC43203@laputa> <20210818053840.GE39588@laputa> <20210820064150.GC13452@laputa> <20210826094047.GA55218@laputa> <20210831061805.GB69817@laputa> <20210901122910.GA100270@laputa> In-Reply-To: <20210901122910.GA100270@laputa> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 31FB94E798E61943B3D0F32FDA2C2E35.0 x-checkrecipientchecked: true Authentication-Results-Original: linaro.org; dkim=none (message not signed) header.d=none;linaro.org; dmarc=none action=none header.from=arm.com; x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: 9c1bad50-8fe3-4233-9823-08d96db148d5 x-ms-traffictypediagnostic: DB9PR08MB6890:|AS8PR08MB7142: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:8882;OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 7c9Q0dU+GVK7k8AaKwPi0cpGAIo5AYqArgzjy4DN3zlofthc8I/0x9XfpDPXn08NY/M+d5ppel6x8kqPIZULDklE55MfHFciGTCbU9XhbwhyMtlV16/hwKJkuyc5cdH5MY8gcVuJ25HEHndlJJXzwZmPQ77752N0KOYUETQ5Cge/8uDuhGEORFaFFaaT6i4OYOyfm9s28Il2vXX+4T0yjz+KRZC5kd2aeqQmjAiAYvx/7RbWs8T9AqZ7HNhtsGE8Zax2GgnSpU6GiaUqzyejLVIWxrt05XLliWyQyVmWrLBs1aMqoRmT/pLm2lR6nt9pT5HEk0LFE1YXPp7K32RjFUqpupH8DVm3ZhtN71NipAGlWYw77VJTqX0qUIl2drmwocLCbdsMM8R8kX5NogbO3IVhe4NUjAiHKjc7ow1KRN+hRrjsni71s541TLNS7P600IIL8gDeUNcg8Ua2KqAeG5fum+vrrKDhy/ZyJHyNJJiVmqEcRX4zRxYFhqoubn1VRyInMaA8TR/v0KGAnZ6mQTf+nYVUkMbYkRwZH58ec6MIw/OPc2cIUL5jofTX0y9RihXT3zt1a0YYgQx6APyPn2Q3YWJBuSkPnFTnzvJmu2b0HoE7rU2lYbB7mPq9CNMeREDd7c+Vst27AUC8dzESdoksyVEb1EvFgg7A7EcGbPmmqvS1u7k1z/nFtU5krEta+YW1Mvxmo5t9/9rWvRIuRQJ/cdH0RqcFoZI69aIB4zJAEELvL9h6vQTfuc4U4cWyy/zKTX7NLmtzsmKjkyIZzvYyZx+BLeHCd+BBoA9WdAA7q73bK/jQL3l70VbOn9okPhVuTvawabpZeRzX4l8e5w== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB9PR08MB6857.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(136003)(39860400002)(366004)(396003)(376002)(30864003)(33656002)(186003)(54906003)(86362001)(71200400001)(83380400001)(4326008)(66574015)(8676002)(478600001)(52536014)(76116006)(7416002)(38100700002)(5660300002)(6916009)(66946007)(53546011)(66556008)(64756008)(966005)(55016002)(9686003)(8936002)(26005)(122000001)(316002)(38070700005)(6506007)(66446008)(7696005)(66476007)(2906002)(579004)(559001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?MjRvTUUwWHRwRXFwMmRFNERFZkJZYk4wWXIrUHpGbUxIV1N0SWo3NTFTYkFn?= =?utf-8?B?T0wxeHZnRWdINS80amtrY09TR1VYNU51djI1SGZhNUNWVTdkRmIyZCtIYUxF?= =?utf-8?B?VlB2MkYvb3NVQ1BQMC9kYi9vMlQ0VENoSzJ6b1NQbWFtbFlaYTlVM0p2MDNw?= =?utf-8?B?STd0WUtkSjJrQUJtdDdZdHVTWDFiWWRNNHROSTBKVHFXa2l2TVVBZzNGM2hz?= =?utf-8?B?RUo5bzZ0L3lBSVVBK2ppczJWS1gzWHBOUWFCeGR1U1FDWTA5QVEydTdaanhY?= =?utf-8?B?NE1nQlhYUFpOTFVMT3lXczhmNERpb0ZWRy9nWFdYdHlZTzNDVVpyRjNISVRo?= =?utf-8?B?bHdpeXg2SGV0U09GMVlTMk02UXFZYmV6OGRJSk1aMGFrNGh1ZllYdldmYjBQ?= =?utf-8?B?UzM4aVhJY2VNUyt5dHZEeDhDa2dmTjAxU3N2MTBvR0J3V1lvNE1WNzFNVHZR?= =?utf-8?B?Z3J4TGtvcnFRUlR5SzEwU0lQRnNxZU96NzB2UGltVFd3M1l5T2U1Uk0xNHl2?= =?utf-8?B?RW4vVy9OZmt4ZGV4LzczOTJKcUgzWHlYc0xqcEJzaEhGaFZHS1NwUzF5bkJq?= =?utf-8?B?ZHhSY2pWNUltdkZjTmpUS2t2aGRXOS9JZnZYYTk0NnlBY3Y4c1o2QmRidmZm?= =?utf-8?B?V2hZTUpTMGxtM1liMy9GK3dkeGRSUFhDM3VESjBkQzhFQkxuRVJqS2pIbllu?= =?utf-8?B?VCthaXppVXY1dWo4Ym5HSkc2MCt0VlRia0Z3Z0tOL1dPWlc4RUFmUVN3eDZw?= =?utf-8?B?NmVBNy83MXpXTVBGVUI2elF1TjdOSzVjQllCMGRPUG1MQXlNbWp0U0VvT0w1?= =?utf-8?B?MHRnT2NpZmFKRmxER3Biekg2MERqWm9QbHJ3eEJOYVNvMWFlTFczZEVsWU1S?= =?utf-8?B?dnkrTXpkTnlMTElhMW01TjFsV1FqUUo5aWVoUmJUZkYvalhyVWF3ZGE2cDli?= =?utf-8?B?Ry85R3ZJMXZJWXM4Wmx5YkNicnFVVkpVSWdiNkVnNmZycWZOanhBSnBlVk1N?= =?utf-8?B?NStWM1NpUHZVWU1nSFI0ZVhCQVdBUnpZWC9oTUVFNGFIUWFacDZXQ2hlVkpR?= =?utf-8?B?S01vOVZlSC9Ob29vN0ZEbU9jblFkRjkwZzRCaVc1cGFESUh5QWgwSytab1VO?= =?utf-8?B?dUdnMTZvaUUzUGljNm11dWMzRHM3alpOcnovYUEzdUUvSGN3RkFJelNRbmp5?= =?utf-8?B?QUZEeDhwREkwcWxqMW40KzFSUXAzTnpFRXc1UE1EL0xXQm45UzZhOWZLamtk?= =?utf-8?B?S2xVK2dqeVlodmVrcUlheU5oUzk3V1ljR01kc1VDcHRHSGdFTHR6aXVPZkcx?= =?utf-8?B?YnVCRjJ6TDhKV0JqN3hFUmFpd2tjaTJKS0lTenBpbnR2M3ErOEdLUnJWdk1j?= =?utf-8?B?Ym5tYmExRHpDeTFPcnlyZ1JUZFBxejFjdERSRE9hYUg5ckpjZlo3Mmk1SG5j?= =?utf-8?B?Y3daaXJhcDgrK1RXMyticitPbFJRdEZUVDVtWjRhUmJCbDcxU3k3N2RJeUpm?= =?utf-8?B?UG0zY29lU1VVbkpIT3RMUjdENEg5RkZ0dnZxcUVLSGRkNno4SGVma2dHL0N4?= =?utf-8?B?RXkvaURseTJrQ0NTRWdEeFk3ZFlSUDNHVlJJcGRnei9GZ0Z1dHZPU042WWlu?= =?utf-8?B?QTN0bjlHMnlIR3VUZUlyMUU2Tkl1MjFobWVpRHF0aWJSbVE1R25CUC9jWHM1?= =?utf-8?B?cEVrSkZZYVdLYURjYURjbEVhejcxMi9SeUxqWVJ5dGRweTd1dEhMRmg5Tys5?= =?utf-8?Q?hwc7OuVDqmgj2l39Ns6zwnIr1g9XFXveepCL5MX?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB6890 Original-Authentication-Results: linaro.org; dkim=none (message not signed) header.d=none;linaro.org; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT064.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 4ef72bad-92f2-4db1-ca58-08d96db1431a X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: cER8HBOGBs2bSvSTR4asddcv2Xjhmkjb54PyUd4kmJWGOczx3X8plfrzNmPHhR5KwU9/0w+n7rF6l8fQSIXTZAP5lYTEjFfhIKFZRU2nBlJW1HJI8+mIALdAi0h39TbGnhG9pFzphv2egVBguOeqIBYEG1Lj3JexoKxPwv80hOotKr9O6Q1KDgFPyJA7ZwHMBrH2bkJk8sGyuyQxqi0C5izPb+z8YwSs9G2rsakko4TJ6O4m628Lgio+UV77SI7XJckOG0OAv+2QWISN5kZHxJlbjQn3xl/LkE84K8nsSZTqt3yFyomlmsIqPms1sEwig0Ud5vI7SICgYsQoC0a+AkxDipDEA1FBuA9Yapo2sGsyQlYZq/iAWvj7rfXAGfflzDuT7EUS67Tbxoz/MrWdAFc54L8Bes7grUloqOPuJK1Oer443lJ4MfZA5UAJyfmBysNNVHqbptjTIbPNLlZSjk6nj3JEpz9hW1IuEo0btY7igH3x7UN9GQYKIm7Y5lYOO0AqTHDnHs6AnWbZIIHIPPs67KDvT7VAvKcsUzlmfcBmgiy7mMRq41oeAO/+CsZTTFyjQlPKZVmeU0FrqtTDL6gb1JWaXY0fWqyEitMMNHOaCu0TUu0t4Hr43JbpztDqlm9M+rP19eBjZJnGyttkdR8uKSjFpGat6DUWWZJMoAQT+Fs+FldWhRMGx2GDdYMj/+Q/DRmFaMcnSE2xDgVscFIMcWBgwaIobL/Tuva9ZqP0fCRfD2RW06AIiHvjOfzyn9tmY1ovuYVM7mOYrVomRfKsoZliWy/IUr6xXEOzPQ+6hoCQP0tisOMYD4V4vgxelD6FZumQP+7Im6T+vczcKg== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(396003)(39860400002)(376002)(136003)(346002)(36840700001)(46966006)(186003)(8676002)(53546011)(70586007)(2906002)(70206006)(82310400003)(86362001)(356005)(26005)(81166007)(336012)(54906003)(7696005)(5660300002)(6506007)(6862004)(8936002)(82740400003)(316002)(33656002)(9686003)(47076005)(52536014)(66574015)(478600001)(83380400001)(55016002)(30864003)(36860700001)(966005)(4326008)(579004)(559001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Sep 2021 01:30:44.7099 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9c1bad50-8fe3-4233-9823-08d96db148d5 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT064.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB7142 SGkgQWthc2hpLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEFLQVNI SSBUYWthaGlybyA8dGFrYWhpcm8uYWthc2hpQGxpbmFyby5vcmc+DQo+IFNlbnQ6IDIwMjHlubQ5 5pyIMeaXpSAyMDoyOQ0KPiBUbzogV2VpIENoZW4gPFdlaS5DaGVuQGFybS5jb20+DQo+IENjOiBP bGVrc2FuZHIgVHlzaGNoZW5rbyA8b2xla3N0eXNoQGdtYWlsLmNvbT47IFN0ZWZhbm8gU3RhYmVs bGluaQ0KPiA8c3N0YWJlbGxpbmlAa2VybmVsLm9yZz47IEFsZXggQmVubj8/ZSA8YWxleC5iZW5u ZWVAbGluYXJvLm9yZz47IEthbHkgWGluDQo+IDxLYWx5LlhpbkBhcm0uY29tPjsgU3RyYXRvcyBN YWlsaW5nIExpc3QgPHN0cmF0b3MtZGV2QG9wLWxpc3RzLmxpbmFyby5vcmc+Ow0KPiB2aXJ0aW8t ZGV2QGxpc3RzLm9hc2lzLW9wZW4ub3JnOyBBcm5kIEJlcmdtYW5uIDxhcm5kLmJlcmdtYW5uQGxp bmFyby5vcmc+Ow0KPiBWaXJlc2ggS3VtYXIgPHZpcmVzaC5rdW1hckBsaW5hcm8ub3JnPjsgU3Rl ZmFubyBTdGFiZWxsaW5pDQo+IDxzdGVmYW5vLnN0YWJlbGxpbmlAeGlsaW54LmNvbT47IHN0ZWZh bmhhQHJlZGhhdC5jb207IEphbiBLaXN6a2ENCj4gPGphbi5raXN6a2FAc2llbWVucy5jb20+OyBD YXJsIHZhbiBTY2hhaWsgPGN2YW5zY2hhQHF0aS5xdWFsY29tbS5jb20+Ow0KPiBwcmF0aWtwQHF1 aWNpbmMuY29tOyBTcml2YXRzYSBWYWRkYWdpcmkgPHZhdHNhQGNvZGVhdXJvcmEub3JnPjsgSmVh bi0NCj4gUGhpbGlwcGUgQnJ1Y2tlciA8amVhbi1waGlsaXBwZUBsaW5hcm8ub3JnPjsgTWF0aGll dSBQb2lyaWVyDQo+IDxtYXRoaWV1LnBvaXJpZXJAbGluYXJvLm9yZz47IE9sZWtzYW5kciBUeXNo Y2hlbmtvDQo+IDxPbGVrc2FuZHJfVHlzaGNoZW5rb0BlcGFtLmNvbT47IEJlcnRyYW5kIE1hcnF1 aXMNCj4gPEJlcnRyYW5kLk1hcnF1aXNAYXJtLmNvbT47IEFydGVtIE15Z2FpZXYgPEFydGVtX015 Z2FpZXZAZXBhbS5jb20+OyBKdWxpZW4NCj4gR3JhbGwgPGp1bGllbkB4ZW4ub3JnPjsgSnVlcmdl biBHcm9zcyA8amdyb3NzQHN1c2UuY29tPjsgUGF1bCBEdXJyYW50DQo+IDxwYXVsQHhlbi5vcmc+ OyBuZCA8bmRAYXJtLmNvbT47IFhlbiBEZXZlbCA8eGVuLWRldmVsQGxpc3RzLnhlbi5vcmc+DQo+ IFN1YmplY3Q6IFJlOiBFbmFibGluZyBoeXBlcnZpc29yIGFnbm9zdGljaXNtIGZvciBWaXJ0SU8g YmFja2VuZHMNCj4gDQo+IEhpIFdlaSwNCj4gDQo+IE9uIFdlZCwgU2VwIDAxLCAyMDIxIGF0IDEx OjEyOjU4QU0gKzAwMDAsIFdlaSBDaGVuIHdyb3RlOg0KPiA+IEhpIEFrYXNoaSwNCj4gPg0KPiA+ ID4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gPiA+IEZyb206IEFLQVNISSBUYWthaGly byA8dGFrYWhpcm8uYWthc2hpQGxpbmFyby5vcmc+DQo+ID4gPiBTZW50OiAyMDIx5bm0OOaciDMx 5pelIDE0OjE4DQo+ID4gPiBUbzogV2VpIENoZW4gPFdlaS5DaGVuQGFybS5jb20+DQo+ID4gPiBD YzogT2xla3NhbmRyIFR5c2hjaGVua28gPG9sZWtzdHlzaEBnbWFpbC5jb20+OyBTdGVmYW5vIFN0 YWJlbGxpbmkNCj4gPiA+IDxzc3RhYmVsbGluaUBrZXJuZWwub3JnPjsgQWxleCBCZW5uPz9lIDxh bGV4LmJlbm5lZUBsaW5hcm8ub3JnPjsgS2FseQ0KPiBYaW4NCj4gPiA+IDxLYWx5LlhpbkBhcm0u Y29tPjsgU3RyYXRvcyBNYWlsaW5nIExpc3QgPHN0cmF0b3MtZGV2QG9wLQ0KPiBsaXN0cy5saW5h cm8ub3JnPjsNCj4gPiA+IHZpcnRpby1kZXZAbGlzdHMub2FzaXMtb3Blbi5vcmc7IEFybmQgQmVy Z21hbm4NCj4gPGFybmQuYmVyZ21hbm5AbGluYXJvLm9yZz47DQo+ID4gPiBWaXJlc2ggS3VtYXIg PHZpcmVzaC5rdW1hckBsaW5hcm8ub3JnPjsgU3RlZmFubyBTdGFiZWxsaW5pDQo+ID4gPiA8c3Rl ZmFuby5zdGFiZWxsaW5pQHhpbGlueC5jb20+OyBzdGVmYW5oYUByZWRoYXQuY29tOyBKYW4gS2lz emthDQo+ID4gPiA8amFuLmtpc3prYUBzaWVtZW5zLmNvbT47IENhcmwgdmFuIFNjaGFpayA8Y3Zh bnNjaGFAcXRpLnF1YWxjb21tLmNvbT47DQo+ID4gPiBwcmF0aWtwQHF1aWNpbmMuY29tOyBTcml2 YXRzYSBWYWRkYWdpcmkgPHZhdHNhQGNvZGVhdXJvcmEub3JnPjsgSmVhbi0NCj4gPiA+IFBoaWxp cHBlIEJydWNrZXIgPGplYW4tcGhpbGlwcGVAbGluYXJvLm9yZz47IE1hdGhpZXUgUG9pcmllcg0K PiA+ID4gPG1hdGhpZXUucG9pcmllckBsaW5hcm8ub3JnPjsgT2xla3NhbmRyIFR5c2hjaGVua28N Cj4gPiA+IDxPbGVrc2FuZHJfVHlzaGNoZW5rb0BlcGFtLmNvbT47IEJlcnRyYW5kIE1hcnF1aXMN Cj4gPiA+IDxCZXJ0cmFuZC5NYXJxdWlzQGFybS5jb20+OyBBcnRlbSBNeWdhaWV2IDxBcnRlbV9N eWdhaWV2QGVwYW0uY29tPjsNCj4gSnVsaWVuDQo+ID4gPiBHcmFsbCA8anVsaWVuQHhlbi5vcmc+ OyBKdWVyZ2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+OyBQYXVsIER1cnJhbnQNCj4gPiA+IDxw YXVsQHhlbi5vcmc+OyBYZW4gRGV2ZWwgPHhlbi1kZXZlbEBsaXN0cy54ZW4ub3JnPg0KPiA+ID4g U3ViamVjdDogUmU6IEVuYWJsaW5nIGh5cGVydmlzb3IgYWdub3N0aWNpc20gZm9yIFZpcnRJTyBi YWNrZW5kcw0KPiA+ID4NCj4gPiA+IFdlaSwNCj4gPiA+DQo+ID4gPiBPbiBUaHUsIEF1ZyAyNiwg MjAyMSBhdCAxMjoxMDoxOVBNICswMDAwLCBXZWkgQ2hlbiB3cm90ZToNCj4gPiA+ID4gSGkgQWth c2hpLA0KPiA+ID4gPg0KPiA+ID4gPiA+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+ID4g PiA+ID4gRnJvbTogQUtBU0hJIFRha2FoaXJvIDx0YWthaGlyby5ha2FzaGlAbGluYXJvLm9yZz4N Cj4gPiA+ID4gPiBTZW50OiAyMDIx5bm0OOaciDI25pelIDE3OjQxDQo+ID4gPiA+ID4gVG86IFdl aSBDaGVuIDxXZWkuQ2hlbkBhcm0uY29tPg0KPiA+ID4gPiA+IENjOiBPbGVrc2FuZHIgVHlzaGNo ZW5rbyA8b2xla3N0eXNoQGdtYWlsLmNvbT47IFN0ZWZhbm8gU3RhYmVsbGluaQ0KPiA+ID4gPiA+ IDxzc3RhYmVsbGluaUBrZXJuZWwub3JnPjsgQWxleCBCZW5uPz9lIDxhbGV4LmJlbm5lZUBsaW5h cm8ub3JnPjsNCj4gS2FseQ0KPiA+ID4gWGluDQo+ID4gPiA+ID4gPEthbHkuWGluQGFybS5jb20+ OyBTdHJhdG9zIE1haWxpbmcgTGlzdCA8c3RyYXRvcy1kZXZAb3AtDQo+ID4gPiBsaXN0cy5saW5h cm8ub3JnPjsNCj4gPiA+ID4gPiB2aXJ0aW8tZGV2QGxpc3RzLm9hc2lzLW9wZW4ub3JnOyBBcm5k IEJlcmdtYW5uDQo+ID4gPiA8YXJuZC5iZXJnbWFubkBsaW5hcm8ub3JnPjsNCj4gPiA+ID4gPiBW aXJlc2ggS3VtYXIgPHZpcmVzaC5rdW1hckBsaW5hcm8ub3JnPjsgU3RlZmFubyBTdGFiZWxsaW5p DQo+ID4gPiA+ID4gPHN0ZWZhbm8uc3RhYmVsbGluaUB4aWxpbnguY29tPjsgc3RlZmFuaGFAcmVk aGF0LmNvbTsgSmFuIEtpc3prYQ0KPiA+ID4gPiA+IDxqYW4ua2lzemthQHNpZW1lbnMuY29tPjsg Q2FybCB2YW4gU2NoYWlrDQo+IDxjdmFuc2NoYUBxdGkucXVhbGNvbW0uY29tPjsNCj4gPiA+ID4g PiBwcmF0aWtwQHF1aWNpbmMuY29tOyBTcml2YXRzYSBWYWRkYWdpcmkgPHZhdHNhQGNvZGVhdXJv cmEub3JnPjsNCj4gSmVhbi0NCj4gPiA+ID4gPiBQaGlsaXBwZSBCcnVja2VyIDxqZWFuLXBoaWxp cHBlQGxpbmFyby5vcmc+OyBNYXRoaWV1IFBvaXJpZXINCj4gPiA+ID4gPiA8bWF0aGlldS5wb2ly aWVyQGxpbmFyby5vcmc+OyBPbGVrc2FuZHIgVHlzaGNoZW5rbw0KPiA+ID4gPiA+IDxPbGVrc2Fu ZHJfVHlzaGNoZW5rb0BlcGFtLmNvbT47IEJlcnRyYW5kIE1hcnF1aXMNCj4gPiA+ID4gPiA8QmVy dHJhbmQuTWFycXVpc0Bhcm0uY29tPjsgQXJ0ZW0gTXlnYWlldiA8QXJ0ZW1fTXlnYWlldkBlcGFt LmNvbT47DQo+ID4gPiBKdWxpZW4NCj4gPiA+ID4gPiBHcmFsbCA8anVsaWVuQHhlbi5vcmc+OyBK dWVyZ2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+OyBQYXVsDQo+IER1cnJhbnQNCj4gPiA+ID4g PiA8cGF1bEB4ZW4ub3JnPjsgWGVuIERldmVsIDx4ZW4tZGV2ZWxAbGlzdHMueGVuLm9yZz4NCj4g PiA+ID4gPiBTdWJqZWN0OiBSZTogRW5hYmxpbmcgaHlwZXJ2aXNvciBhZ25vc3RpY2lzbSBmb3Ig VmlydElPIGJhY2tlbmRzDQo+ID4gPiA+ID4NCj4gPiA+ID4gPiBIaSBXZWksDQo+ID4gPiA+ID4N Cj4gPiA+ID4gPiBPbiBGcmksIEF1ZyAyMCwgMjAyMSBhdCAwMzo0MTo1MFBNICswOTAwLCBBS0FT SEkgVGFrYWhpcm8gd3JvdGU6DQo+ID4gPiA+ID4gPiBPbiBXZWQsIEF1ZyAxOCwgMjAyMSBhdCAw ODozNTo1MUFNICswMDAwLCBXZWkgQ2hlbiB3cm90ZToNCj4gPiA+ID4gPiA+ID4gSGkgQWthc2hp 77yMDQo+ID4gPiA+ID4gPiA+DQo+ID4gPiA+ID4gPiA+ID4gLS0tLS1PcmlnaW5hbCBNZXNzYWdl LS0tLS0NCj4gPiA+ID4gPiA+ID4gPiBGcm9tOiBBS0FTSEkgVGFrYWhpcm8gPHRha2FoaXJvLmFr YXNoaUBsaW5hcm8ub3JnPg0KPiA+ID4gPiA+ID4gPiA+IFNlbnQ6IDIwMjHlubQ45pyIMTjml6Ug MTM6MzkNCj4gPiA+ID4gPiA+ID4gPiBUbzogV2VpIENoZW4gPFdlaS5DaGVuQGFybS5jb20+DQo+ ID4gPiA+ID4gPiA+ID4gQ2M6IE9sZWtzYW5kciBUeXNoY2hlbmtvIDxvbGVrc3R5c2hAZ21haWwu Y29tPjsgU3RlZmFubw0KPiA+ID4gU3RhYmVsbGluaQ0KPiA+ID4gPiA+ID4gPiA+IDxzc3RhYmVs bGluaUBrZXJuZWwub3JnPjsgQWxleCBCZW5uPz9lDQo+IDxhbGV4LmJlbm5lZUBsaW5hcm8ub3Jn PjsNCj4gPiA+ID4gPiBTdHJhdG9zDQo+ID4gPiA+ID4gPiA+ID4gTWFpbGluZyBMaXN0IDxzdHJh dG9zLWRldkBvcC1saXN0cy5saW5hcm8ub3JnPjsgdmlydGlvLQ0KPiA+ID4gPiA+IGRldkBsaXN0 cy5vYXNpcy0NCj4gPiA+ID4gPiA+ID4gPiBvcGVuLm9yZzsgQXJuZCBCZXJnbWFubiA8YXJuZC5i ZXJnbWFubkBsaW5hcm8ub3JnPjsgVmlyZXNoDQo+IEt1bWFyDQo+ID4gPiA+ID4gPiA+ID4gPHZp cmVzaC5rdW1hckBsaW5hcm8ub3JnPjsgU3RlZmFubyBTdGFiZWxsaW5pDQo+ID4gPiA+ID4gPiA+ ID4gPHN0ZWZhbm8uc3RhYmVsbGluaUB4aWxpbnguY29tPjsgc3RlZmFuaGFAcmVkaGF0LmNvbTsg SmFuDQo+IEtpc3prYQ0KPiA+ID4gPiA+ID4gPiA+IDxqYW4ua2lzemthQHNpZW1lbnMuY29tPjsg Q2FybCB2YW4gU2NoYWlrDQo+ID4gPiA+ID4gPGN2YW5zY2hhQHF0aS5xdWFsY29tbS5jb20+Ow0K PiA+ID4gPiA+ID4gPiA+IHByYXRpa3BAcXVpY2luYy5jb207IFNyaXZhdHNhIFZhZGRhZ2lyaQ0K PiA8dmF0c2FAY29kZWF1cm9yYS5vcmc+Ow0KPiA+ID4gPiA+IEplYW4tDQo+ID4gPiA+ID4gPiA+ ID4gUGhpbGlwcGUgQnJ1Y2tlciA8amVhbi1waGlsaXBwZUBsaW5hcm8ub3JnPjsgTWF0aGlldSBQ b2lyaWVyDQo+ID4gPiA+ID4gPiA+ID4gPG1hdGhpZXUucG9pcmllckBsaW5hcm8ub3JnPjsgT2xl a3NhbmRyIFR5c2hjaGVua28NCj4gPiA+ID4gPiA+ID4gPiA8T2xla3NhbmRyX1R5c2hjaGVua29A ZXBhbS5jb20+OyBCZXJ0cmFuZCBNYXJxdWlzDQo+ID4gPiA+ID4gPiA+ID4gPEJlcnRyYW5kLk1h cnF1aXNAYXJtLmNvbT47IEFydGVtIE15Z2FpZXYNCj4gPiA+IDxBcnRlbV9NeWdhaWV2QGVwYW0u Y29tPjsNCj4gPiA+ID4gPiBKdWxpZW4NCj4gPiA+ID4gPiA+ID4gPiBHcmFsbCA8anVsaWVuQHhl bi5vcmc+OyBKdWVyZ2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+Ow0KPiBQYXVsDQo+ID4gPiA+ ID4gRHVycmFudA0KPiA+ID4gPiA+ID4gPiA+IDxwYXVsQHhlbi5vcmc+OyBYZW4gRGV2ZWwgPHhl bi1kZXZlbEBsaXN0cy54ZW4ub3JnPg0KPiA+ID4gPiA+ID4gPiA+IFN1YmplY3Q6IFJlOiBFbmFi bGluZyBoeXBlcnZpc29yIGFnbm9zdGljaXNtIGZvciBWaXJ0SU8NCj4gYmFja2VuZHMNCj4gPiA+ ID4gPiA+ID4gPg0KPiA+ID4gPiA+ID4gPiA+IE9uIFR1ZSwgQXVnIDE3LCAyMDIxIGF0IDA4OjM5 OjA5QU0gKzAwMDAsIFdlaSBDaGVuIHdyb3RlOg0KPiA+ID4gPiA+ID4gPiA+ID4gSGkgQWthc2hp LA0KPiA+ID4gPiA+ID4gPiA+ID4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gLS0tLS1PcmlnaW5hbCBN ZXNzYWdlLS0tLS0NCj4gPiA+ID4gPiA+ID4gPiA+ID4gRnJvbTogQUtBU0hJIFRha2FoaXJvIDx0 YWthaGlyby5ha2FzaGlAbGluYXJvLm9yZz4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gU2VudDogMjAy MeW5tDjmnIgxN+aXpSAxNjowOA0KPiA+ID4gPiA+ID4gPiA+ID4gPiBUbzogV2VpIENoZW4gPFdl aS5DaGVuQGFybS5jb20+DQo+ID4gPiA+ID4gPiA+ID4gPiA+IENjOiBPbGVrc2FuZHIgVHlzaGNo ZW5rbyA8b2xla3N0eXNoQGdtYWlsLmNvbT47IFN0ZWZhbm8NCj4gPiA+ID4gPiBTdGFiZWxsaW5p DQo+ID4gPiA+ID4gPiA+ID4gPiA+IDxzc3RhYmVsbGluaUBrZXJuZWwub3JnPjsgQWxleCBCZW5u Pz9lDQo+ID4gPiA8YWxleC5iZW5uZWVAbGluYXJvLm9yZz47DQo+ID4gPiA+ID4gPiA+ID4gU3Ry YXRvcw0KPiA+ID4gPiA+ID4gPiA+ID4gPiBNYWlsaW5nIExpc3QgPHN0cmF0b3MtZGV2QG9wLWxp c3RzLmxpbmFyby5vcmc+OyB2aXJ0aW8tDQo+ID4gPiA+ID4gPiA+ID4gZGV2QGxpc3RzLm9hc2lz LQ0KPiA+ID4gPiA+ID4gPiA+ID4gPiBvcGVuLm9yZzsgQXJuZCBCZXJnbWFubiA8YXJuZC5iZXJn bWFubkBsaW5hcm8ub3JnPjsNCj4gVmlyZXNoDQo+ID4gPiBLdW1hcg0KPiA+ID4gPiA+ID4gPiA+ ID4gPiA8dmlyZXNoLmt1bWFyQGxpbmFyby5vcmc+OyBTdGVmYW5vIFN0YWJlbGxpbmkNCj4gPiA+ ID4gPiA+ID4gPiA+ID4gPHN0ZWZhbm8uc3RhYmVsbGluaUB4aWxpbnguY29tPjsgc3RlZmFuaGFA cmVkaGF0LmNvbTsNCj4gSmFuDQo+ID4gPiBLaXN6a2ENCj4gPiA+ID4gPiA+ID4gPiA+ID4gPGph bi5raXN6a2FAc2llbWVucy5jb20+OyBDYXJsIHZhbiBTY2hhaWsNCj4gPiA+ID4gPiA8Y3ZhbnNj aGFAcXRpLnF1YWxjb21tLmNvbT47DQo+ID4gPiA+ID4gPiA+ID4gPiA+IHByYXRpa3BAcXVpY2lu Yy5jb207IFNyaXZhdHNhIFZhZGRhZ2lyaQ0KPiA+ID4gPHZhdHNhQGNvZGVhdXJvcmEub3JnPjsN Cj4gPiA+ID4gPiBKZWFuLQ0KPiA+ID4gPiA+ID4gPiA+ID4gPiBQaGlsaXBwZSBCcnVja2VyIDxq ZWFuLXBoaWxpcHBlQGxpbmFyby5vcmc+OyBNYXRoaWV1DQo+IFBvaXJpZXINCj4gPiA+ID4gPiA+ ID4gPiA+ID4gPG1hdGhpZXUucG9pcmllckBsaW5hcm8ub3JnPjsgT2xla3NhbmRyIFR5c2hjaGVu a28NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPE9sZWtzYW5kcl9UeXNoY2hlbmtvQGVwYW0uY29tPjsg QmVydHJhbmQgTWFycXVpcw0KPiA+ID4gPiA+ID4gPiA+ID4gPiA8QmVydHJhbmQuTWFycXVpc0Bh cm0uY29tPjsgQXJ0ZW0gTXlnYWlldg0KPiA+ID4gPiA+IDxBcnRlbV9NeWdhaWV2QGVwYW0uY29t PjsNCj4gPiA+ID4gPiA+ID4gPiBKdWxpZW4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gR3JhbGwgPGp1 bGllbkB4ZW4ub3JnPjsgSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuY29tPjsNCj4gPiA+IFBh dWwNCj4gPiA+ID4gPiBEdXJyYW50DQo+ID4gPiA+ID4gPiA+ID4gPiA+IDxwYXVsQHhlbi5vcmc+ OyBYZW4gRGV2ZWwgPHhlbi1kZXZlbEBsaXN0cy54ZW4ub3JnPg0KPiA+ID4gPiA+ID4gPiA+ID4g PiBTdWJqZWN0OiBSZTogRW5hYmxpbmcgaHlwZXJ2aXNvciBhZ25vc3RpY2lzbSBmb3IgVmlydElP DQo+ID4gPiBiYWNrZW5kcw0KPiA+ID4gPiA+ID4gPiA+ID4gPg0KPiA+ID4gPiA+ID4gPiA+ID4g PiBIaSBXZWksIE9sZWtzYW5kciwNCj4gPiA+ID4gPiA+ID4gPiA+ID4NCj4gPiA+ID4gPiA+ID4g PiA+ID4gT24gTW9uLCBBdWcgMTYsIDIwMjEgYXQgMTA6MDQ6MDNBTSArMDAwMCwgV2VpIENoZW4g d3JvdGU6DQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gSGkgQWxsLA0KPiA+ID4gPiA+ID4gPiA+ID4g PiA+DQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gVGhhbmtzIGZvciBTdGVmYW5vIHRvIGxpbmsgbXkg a3ZtdG9vbCBmb3IgWGVuIHByb3Bvc2FsDQo+ID4gPiBoZXJlLg0KPiA+ID4gPiA+ID4gPiA+ID4g PiA+IFRoaXMgcHJvcG9zYWwgaXMgc3RpbGwgZGlzY3Vzc2luZyBpbiBYZW4gYW5kIEtWTQ0KPiA+ ID4gY29tbXVuaXRpZXMuDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gVGhlIG1haW4gd29yayBpcyB0 byBkZWNvdXBsZSB0aGUga3ZtdG9vbCBmcm9tIEtWTSBhbmQNCj4gbWFrZQ0KPiA+ID4gPiA+ID4g PiA+ID4gPiA+IG90aGVyIGh5cGVydmlzb3JzIGNhbiByZXVzZSB0aGUgdmlydHVhbCBkZXZpY2UN Cj4gPiA+IGltcGxlbWVudGF0aW9ucy4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPg0KPiA+ID4gPiA+ ID4gPiA+ID4gPiA+IEluIHRoaXMgY2FzZSwgd2UgbmVlZCB0byBpbnRyb2R1Y2UgYW4gaW50ZXJt ZWRpYXRlDQo+ID4gPiBoeXBlcnZpc29yDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gbGF5ZXIgZm9y IFZNTSBhYnN0cmFjdGlvbiwgV2hpY2ggaXMsIEkgdGhpbmsgaXQncyB2ZXJ5DQo+ID4gPiBjbG9z ZQ0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+IHRvIHN0cmF0b3MnIHZpcnRpbyBoeXBlcnZpc29yIGFn bm9zdGljaXNtIHdvcmsuDQo+ID4gPiA+ID4gPiA+ID4gPiA+DQo+ID4gPiA+ID4gPiA+ID4gPiA+ ICMgTXkgcHJvcG9zYWxbMV0gY29tZXMgZnJvbSBteSBvd24gaWRlYSBhbmQgZG9lc24ndA0KPiBh bHdheXMNCj4gPiA+ID4gPiByZXByZXNlbnQNCj4gPiA+ID4gPiA+ID4gPiA+ID4gIyBMaW5hcm8n cyB2aWV3IG9uIHRoaXMgc3ViamVjdCBub3IgcmVmbGVjdCBBbGV4J3MNCj4gY29uY2VybnMuDQo+ ID4gPiA+ID4gPiA+ID4gTmV2ZXJ0aGVsZXNzLA0KPiA+ID4gPiA+ID4gPiA+ID4gPg0KPiA+ID4g PiA+ID4gPiA+ID4gPiBZb3VyIGlkZWEgYW5kIG15IHByb3Bvc2FsIHNlZW0gdG8gc2hhcmUgdGhl IHNhbWUNCj4gYmFja2dyb3VuZC4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gQm90aCBoYXZlIHRoZSBz aW1pbGFyIGdvYWwgYW5kIGN1cnJlbnRseSBzdGFydCB3aXRoLCBhdA0KPiA+ID4gZmlyc3QsDQo+ ID4gPiA+ID4gWGVuDQo+ID4gPiA+ID4gPiA+ID4gPiA+IGFuZCBhcmUgYmFzZWQgb24ga3ZtLXRv b2wuIChBY3R1YWxseSwgbXkgd29yayBpcyBkZXJpdmVkDQo+ID4gPiBmcm9tDQo+ID4gPiA+ID4g PiA+ID4gPiA+IEVQQU0ncyB2aXJ0aW8tZGlzaywgd2hpY2ggaXMgYWxzbyBiYXNlZCBvbiBrdm0t dG9vbC4pDQo+ID4gPiA+ID4gPiA+ID4gPiA+DQo+ID4gPiA+ID4gPiA+ID4gPiA+IEluIHBhcnRp Y3VsYXIsIHRoZSBhYnN0cmFjdGlvbiBvZiBoeXBlcnZpc29yIGludGVyZmFjZXMNCj4gaGFzDQo+ ID4gPiBhDQo+ID4gPiA+ID4gc2FtZQ0KPiA+ID4gPiA+ID4gPiA+ID4gPiBzZXQgb2YgaW50ZXJm YWNlcyAoZm9yIHlvdXIgInN0cnVjdCB2bW1faW1wbCIgYW5kIG15DQo+ICJSUEMNCj4gPiA+ID4g PiBpbnRlcmZhY2VzIikuDQo+ID4gPiA+ID4gPiA+ID4gPiA+IFRoaXMgaXMgbm90IGNvLWluY2lk ZW50IGFzIHdlIGJvdGggc2hhcmUgdGhlIHNhbWUgb3JpZ2luDQo+IGFzDQo+ID4gPiBJDQo+ID4g PiA+ID4gc2FpZA0KPiA+ID4gPiA+ID4gPiA+IGFib3ZlLg0KPiA+ID4gPiA+ID4gPiA+ID4gPiBB bmQgc28gd2Ugd2lsbCBhbHNvIHNoYXJlIHRoZSBzYW1lIGlzc3Vlcy4gT25lIG9mIHRoZW0NCj4g aXMgYQ0KPiA+ID4gd2F5DQo+ID4gPiA+ID4gb2YNCj4gPiA+ID4gPiA+ID4gPiA+ID4gInNoYXJp bmcvbWFwcGluZyBGRSdzIG1lbW9yeSIuIFRoZXJlIGlzIHNvbWUgdHJhZGUtb2ZmDQo+ID4gPiBi ZXR3ZWVuDQo+ID4gPiA+ID4gPiA+ID4gPiA+IHRoZSBwb3J0YWJpbGl0eSBhbmQgdGhlIHBlcmZv cm1hbmNlIGltcGFjdC4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gU28gd2UgY2FuIGRpc2N1c3MgdGhl IHRvcGljIGhlcmUgaW4gdGhpcyBNTCwgdG9vLg0KPiA+ID4gPiA+ID4gPiA+ID4gPiAoU2VlIEFs ZXgncyBvcmlnaW5hbCBlbWFpbCwgdG9vKS4NCj4gPiA+ID4gPiA+ID4gPiA+ID4NCj4gPiA+ID4g PiA+ID4gPiA+IFllcywgSSBhZ3JlZS4NCj4gPiA+ID4gPiA+ID4gPiA+DQo+ID4gPiA+ID4gPiA+ ID4gPiA+IE9uIHRoZSBvdGhlciBoYW5kLCBteSBhcHByb2FjaCBhaW1zIHRvIGNyZWF0ZSBhICJz aW5nbGUtDQo+ID4gPiBiaW5hcnkiDQo+ID4gPiA+ID4gPiA+ID4gc29sdXRpb24NCj4gPiA+ID4g PiA+ID4gPiA+ID4gaW4gd2hpY2ggdGhlIHNhbWUgYmluYXJ5IG9mIEJFIHZtIGNvdWxkIHJ1biBv biBhbnkNCj4gPiA+IGh5cGVydmlzb3JzLg0KPiA+ID4gPiA+ID4gPiA+ID4gPiBTb21laG93IHNp bWlsYXIgdG8geW91ciAicHJvcG9zYWwtIzIiIGluIFsyXSwgYnV0IGluIG15DQo+ID4gPiBzb2x1 dGlvbiwNCj4gPiA+ID4gPiBhbGwNCj4gPiA+ID4gPiA+ID4gPiA+ID4gdGhlIGh5cGVydmlzb3It c3BlY2lmaWMgY29kZSB3b3VsZCBiZSBwdXQgaW50byBhbm90aGVyDQo+ID4gPiBlbnRpdHkNCj4g PiA+ID4gPiAoVk0pLA0KPiA+ID4gPiA+ID4gPiA+ID4gPiBuYW1lZCAidmlydGlvLXByb3h5IiBh bmQgdGhlIGFic3RyYWN0ZWQgb3BlcmF0aW9ucyBhcmUNCj4gPiA+IHNlcnZlZA0KPiA+ID4gPiA+ IHZpYSBSUEMuDQo+ID4gPiA+ID4gPiA+ID4gPiA+IChJbiB0aGlzIHNlbnNlLCBCRSBpcyBoeXBl cnZpc29yLWFnbm9zdGljIGJ1dCBtaWdodCBoYXZlDQo+IE9TDQo+ID4gPiA+ID4gPiA+ID4gZGVw ZW5kZW5jeS4pDQo+ID4gPiA+ID4gPiA+ID4gPiA+IEJ1dCBJIGtub3cgdGhhdCB3ZSBuZWVkIGRp c2N1c3MgaWYgdGhpcyBpcyBhIHJlcXVpcmVtZW50DQo+ID4gPiBldmVuDQo+ID4gPiA+ID4gPiA+ ID4gPiA+IGluIFN0cmF0b3MgcHJvamVjdCBvciBub3QuIChNYXliZSBub3QpDQo+ID4gPiA+ID4g PiA+ID4gPiA+DQo+ID4gPiA+ID4gPiA+ID4gPg0KPiA+ID4gPiA+ID4gPiA+ID4gU29ycnksIEkg aGF2ZW4ndCBoYWQgdGltZSB0byBmaW5pc2ggcmVhZGluZyB5b3VyIHZpcnRpby0NCj4gcHJveHkN Cj4gPiA+ID4gPiBjb21wbGV0ZWx5DQo+ID4gPiA+ID4gPiA+ID4gPiAoSSB3aWxsIGRvIGl0IEFT QVApLiBCdXQgZnJvbSB5b3VyIGRlc2NyaXB0aW9uLCBpdCBzZWVtcw0KPiB3ZQ0KPiA+ID4gbmVl ZCBhDQo+ID4gPiA+ID4gPiA+ID4gPiAzcmQgVk0gYmV0d2VlbiBGRSBhbmQgQkU/IE15IGNvbmNl cm4gaXMgdGhhdCwgaWYgbXkNCj4gYXNzdW1wdGlvbg0KPiA+ID4gaXMNCj4gPiA+ID4gPiByaWdo dCwNCj4gPiA+ID4gPiA+ID4gPiA+IHdpbGwgaXQgaW5jcmVhc2UgdGhlIGxhdGVuY3kgaW4gZGF0 YSB0cmFuc3BvcnQgcGF0aD8gRXZlbg0KPiBpZg0KPiA+ID4gd2UncmUNCj4gPiA+ID4gPiA+ID4g PiA+IHVzaW5nIHNvbWUgbGlnaHR3ZWlnaHQgZ3Vlc3QgbGlrZSBSVE9TIG9yIFVuaWtlcm5lbCwN Cj4gPiA+ID4gPiA+ID4gPg0KPiA+ID4gPiA+ID4gPiA+IFllcywgeW91J3JlIHJpZ2h0LiBCdXQg SSdtIGFmcmFpZCB0aGF0IGl0IGlzIGEgbWF0dGVyIG9mDQo+IGRlZ3JlZS4NCj4gPiA+ID4gPiA+ ID4gPiBBcyBmYXIgYXMgd2UgZXhlY3V0ZSAnbWFwcGluZycgb3BlcmF0aW9ucyBhdCBldmVyeSBm ZXRjaCBvZg0KPiA+ID4gcGF5bG9hZCwNCj4gPiA+ID4gPiA+ID4gPiB3ZSB3aWxsIHNlZSBsYXRl bmN5IGlzc3VlIChldmVuIGluIHlvdXIgY2FzZSkgYW5kIGlmIHdlIGhhdmUNCj4gPiA+IHNvbWUN Cj4gPiA+ID4gPiBzb2x1dGlvbg0KPiA+ID4gPiA+ID4gPiA+IGZvciBpdCwgd2Ugd29uJ3Qgc2Vl IGl0IG5laXRoZXIgaW4gbXkgcHJvcG9zYWwgOikNCj4gPiA+ID4gPiA+ID4gPg0KPiA+ID4gPiA+ ID4gPg0KPiA+ID4gPiA+ID4gPiBPbGVrc2FuZHIgaGFzIHNlbnQgYSBwcm9wb3NhbCB0byBYZW4g bWFpbGluZyBsaXN0IHRvIHJlZHVjZQ0KPiB0aGlzDQo+ID4gPiBraW5kDQo+ID4gPiA+ID4gPiA+ IG9mICJtYXBwaW5nL3VubWFwcGluZyIgb3BlcmF0aW9ucy4gU28gdGhlIGxhdGVuY3kgY2F1c2Vk IGJ5DQo+IHRoaXMNCj4gPiA+ID4gPiBiZWhhdmlvcg0KPiA+ID4gPiA+ID4gPiBvbiBYZW4gbWF5 IGV2ZW50dWFsbHkgYmUgZWxpbWluYXRlZCwgYW5kIExpbnV4LUtWTSBkb2Vzbid0DQo+IGhhdmUN Cj4gPiA+IHRoYXQNCj4gPiA+ID4gPiBwcm9ibGVtLg0KPiA+ID4gPiA+ID4NCj4gPiA+ID4gPiA+ IE9idmlvdXNseSwgSSBoYXZlIG5vdCB5ZXQgY2F1Z2h0IHVwIHRoZXJlIGluIHRoZSBkaXNjdXNz aW9uLg0KPiA+ID4gPiA+ID4gV2hpY2ggcGF0Y2ggc3BlY2lmaWNhbGx5Pw0KPiA+ID4gPiA+DQo+ ID4gPiA+ID4gQ2FuIHlvdSBnaXZlIG1lIHRoZSBsaW5rIHRvIHRoZSBkaXNjdXNzaW9uIG9yIHBh dGNoLCBwbGVhc2U/DQo+ID4gPiA+ID4NCj4gPiA+ID4NCj4gPiA+ID4gSXQncyBhIFJGQyBkaXNj dXNzaW9uLiBXZSBoYXZlIHRlc3RlZCB0aGlzIFJGQyBwYXRjaCBpbnRlcm5hbGx5Lg0KPiA+ID4g PiBodHRwczovL2xpc3RzLnhlbnByb2plY3Qub3JnL2FyY2hpdmVzL2h0bWwveGVuLWRldmVsLzIw MjEtDQo+ID4gPiAwNy9tc2cwMTUzMi5odG1sDQo+ID4gPg0KPiA+ID4gSSdtIGFmcmFpZCB0aGF0 IEkgbWlzcyBzb21ldGhpbmcgaGVyZSwgYnV0IEkgZG9uJ3Qga25vdw0KPiA+ID4gd2h5IHRoaXMg cHJvcG9zZWQgQVBJIHdpbGwgbGVhZCB0byBlbGltaW5hdGluZyAnbW1hcCcgaW4gYWNjZXNzaW5n DQo+ID4gPiB0aGUgcXVldWVkIHBheWxvYWQgYXQgZXZlcnkgcmVxdWVzdD8NCj4gPiA+DQo+ID4N Cj4gPiBUaGlzIEFQSSBnaXZlIFhlbiBkZXZpY2UgbW9kZWwgKFFFTVUgb3Iga3ZtdG9vbCkgdGhl IGFiaWxpdHkgdG8gbWFwDQo+ID4gd2hvbGUgZ3Vlc3QgUkFNIGluIGRldmljZSBtb2RlbCdzIGFk ZHJlc3Mgc3BhY2UuIEluIHRoaXMgY2FzZSwgZGV2aWNlDQo+ID4gbW9kZWwgZG9lc24ndCBuZWVk IGR5bmFtaWMgaHlwZXJjYWxsIHRvIG1hcC91bm1hcCBwYXlsb2FkIG1lbW9yeS4NCj4gPiBJdCBj YW4gdXNlIGEgZmxhdCBvZmZzZXQgdG8gYWNjZXNzIHBheWxvYWQgbWVtb3J5IGluIGl0cyBhZGRy ZXNzDQo+ID4gc3BhY2UgZGlyZWN0bHkuIEp1c3QgTGlrZSBLVk0gZGV2aWNlIG1vZGVsIGRvZXMg bm93Lg0KPiANCj4gVGhhbmsgeW91LiBRdWlja2x5LCBsZXQgbWUgbWFrZSBzdXJlIG9uZSB0aGlu ZzoNCj4gVGhpcyBBUEkgaXRzZWxmIGRvZXNuJ3QgZG8gYW55IG1hcHBpbmcgb3BlcmF0aW9ucywg cmlnaHQ/DQo+IFNvIEkgc3VwcG9zZSB0aGF0IHZpcnRpbyBCRSBndWVzdCBpcyByZXNwb25zaWJs ZSB0bw0KPiAxKSBmZXRjaCB0aGUgaW5mb3JtYXRpb24gYWJvdXQgYWxsIHRoZSBtZW1vcnkgcmVn aW9ucyBpbiBGRSwNCj4gMikgY2FsbCB0aGlzIEFQSSB0byBhbGxvY2F0ZSBhIGJpZyBjaHVuayBv ZiB1bnVzZWQgc3BhY2UgaW4gQkUsDQo+IDMpIGNyZWF0ZSBncmFudC9mb3JlaWduIG1hcHBpbmdz IGZvciBGRSBvbnRvIHRoaXMgcmVnaW9uKFMpDQo+IGluIHRoZSBpbml0aWFsaXphdGlvbi9jb25m aWd1cmF0aW9uIG9mIGVtdWxhdGVkIHZpcnRpbyBkZXZpY2VzLg0KPiANCj4gSXMgdGhpcyB0aGUg d2F5IHRoaXMgQVBJIGlzIGV4cGVjdGVkIHRvIGJlIHVzZWQ/DQo+IERvZXMgWGVuIGFscmVhZHkg aGFzIGFuIGludGVyZmFjZSBmb3IgKDEpPw0KPiANCg0KVGhleSBhcmUgZGlzY3Vzc2luZyBpbiB0 aGF0IHRocmVhZCB0byBmaW5kIGEgcHJvcGVyIHdheSB0byBkbyBpdC4NCkJlY2F1c2UgdGhpcyBB UEkgaXMgY29tbW9uLCBib3RoIHg4NiBhbmQgQXJtIHNob3VsZCBiZSBjb25zaWRlcmVkLg0KDQo+ IC1UYWthaGlybyBBa2FzaGkNCj4gDQo+ID4gQmVmb3JlIHRoaXMgQVBJLCBXaGVuIGRldmljZSBt b2RlbCB0byBtYXAgd2hvbGUgZ3Vlc3QgbWVtb3J5LCB3aWxsDQo+ID4gc2V2ZXJlbHkgY29uc3Vt ZSB0aGUgcGh5c2ljYWwgcGFnZXMgb2YgRG9tLTAvRG9tLUQuDQo+ID4NCj4gPiA+IC1UYWthaGly byBBa2FzaGkNCj4gPiA+DQo+ID4gPg0KPiA+ID4gPiA+IFRoYW5rcywNCj4gPiA+ID4gPiAtVGFr YWhpcm8gQWthc2hpDQo+ID4gPiA+ID4NCj4gPiA+ID4gPiA+IC1UYWthaGlybyBBa2FzaGkNCj4g PiA+ID4gPiA+DQo+ID4gPiA+ID4gPiA+ID4gPiA+IFNwZWNpZmljYWxseSBzcGVha2luZyBhYm91 dCBrdm0tdG9vbCwgSSBoYXZlIGEgY29uY2Vybg0KPiBhYm91dA0KPiA+ID4gaXRzDQo+ID4gPiA+ ID4gPiA+ID4gPiA+IGxpY2Vuc2UgdGVybTsgVGFyZ2V0aW5nIGRpZmZlcmVudCBoeXBlcnZpc29y cyBhbmQNCj4gZGlmZmVyZW50DQo+ID4gPiBPU3MNCj4gPiA+ID4gPiA+ID4gPiA+ID4gKHdoaWNo IEkgYXNzdW1lIGluY2x1ZGVzIFJUT1MncyksIHRoZSByZXN1bHRhbnQgbGlicmFyeQ0KPiA+ID4g c2hvdWxkDQo+ID4gPiA+ID4gYmUNCj4gPiA+ID4gPiA+ID4gPiA+ID4gbGljZW5zZSBwZXJtaXNz aXZlIGFuZCBHUEwgZm9yIGt2bS10b29sIG1pZ2h0IGJlIGFuDQo+IGlzc3VlLg0KPiA+ID4gPiA+ ID4gPiA+ID4gPiBBbnkgdGhvdWdodHM/DQo+ID4gPiA+ID4gPiA+ID4gPiA+DQo+ID4gPiA+ID4g PiA+ID4gPg0KPiA+ID4gPiA+ID4gPiA+ID4gWWVzLiBJZiB1c2VyIHdhbnQgdG8gaW1wbGVtZW50 IGEgRnJlZUJTRCBkZXZpY2UgbW9kZWwsIGJ1dA0KPiB0aGUNCj4gPiA+ID4gPiB2aXJ0aW8NCj4g PiA+ID4gPiA+ID4gPiA+IGxpYnJhcnkgaXMgR1BMLiBUaGVuIEdQTCB3b3VsZCBiZSBhIHByb2Js ZW0uIElmIHdlIGhhdmUNCj4gPiA+IGFub3RoZXINCj4gPiA+ID4gPiBnb29kDQo+ID4gPiA+ID4g PiA+ID4gPiBjYW5kaWRhdGUsIEkgYW0gb3BlbiB0byBpdC4NCj4gPiA+ID4gPiA+ID4gPg0KPiA+ ID4gPiA+ID4gPiA+IEkgaGF2ZSBzb21lIGNhbmRpZGF0ZXMsIHBhcnRpY3VsYXJseSBmb3IgdnEv dnJpbmcsIGluIG15DQo+IG1pbmQ6DQo+ID4gPiA+ID4gPiA+ID4gKiBPcGVuLUFNUCwgb3INCj4g PiA+ID4gPiA+ID4gPiAqIGNvcnJlc3BvbmRpbmcgRnJlZS1CU0QgY29kZQ0KPiA+ID4gPiA+ID4g PiA+DQo+ID4gPiA+ID4gPiA+DQo+ID4gPiA+ID4gPiA+IEludGVyZXN0aW5nLCBJIHdpbGwgbG9v ayBpbnRvIHRoZW0gOiApDQo+ID4gPiA+ID4gPiA+DQo+ID4gPiA+ID4gPiA+IENoZWVycywNCj4g PiA+ID4gPiA+ID4gV2VpIENoZW4NCj4gPiA+ID4gPiA+ID4NCj4gPiA+ID4gPiA+ID4gPiAtVGFr YWhpcm8gQWthc2hpDQo+ID4gPiA+ID4gPiA+ID4NCj4gPiA+ID4gPiA+ID4gPg0KPiA+ID4gPiA+ ID4gPiA+ID4gPiAtVGFrYWhpcm8gQWthc2hpDQo+ID4gPiA+ID4gPiA+ID4gPiA+DQo+ID4gPiA+ ID4gPiA+ID4gPiA+DQo+ID4gPiA+ID4gPiA+ID4gPiA+IFsxXSBodHRwczovL29wLWxpc3RzLmxp bmFyby5vcmcvcGlwZXJtYWlsL3N0cmF0b3MtDQo+IGRldi8yMDIxLQ0KPiA+ID4gPiA+ID4gPiA+ ID4gPiBBdWd1c3QvMDAwNTQ4Lmh0bWwNCj4gPiA+ID4gPiA+ID4gPiA+ID4gWzJdIGh0dHBzOi8v bWFyYy5pbmZvLz9sPXhlbi1kZXZlbCZtPTE2MjM3Mzc1NDcwNTIzMyZ3PTINCj4gPiA+ID4gPiA+ ID4gPiA+ID4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPg0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4g RnJvbTogT2xla3NhbmRyIFR5c2hjaGVua28gPG9sZWtzdHlzaEBnbWFpbC5jb20+DQo+ID4gPiA+ ID4gPiA+ID4gPiA+ID4gPiBTZW50OiAyMDIx5bm0OOaciDE05pelIDIzOjM4DQo+ID4gPiA+ID4g PiA+ID4gPiA+ID4gPiBUbzogQUtBU0hJIFRha2FoaXJvIDx0YWthaGlyby5ha2FzaGlAbGluYXJv Lm9yZz47DQo+ID4gPiBTdGVmYW5vDQo+ID4gPiA+ID4gPiA+ID4gU3RhYmVsbGluaQ0KPiA+ID4g PiA+ID4gPiA+ID4gPiA8c3N0YWJlbGxpbmlAa2VybmVsLm9yZz4NCj4gPiA+ID4gPiA+ID4gPiA+ ID4gPiA+IENjOiBBbGV4IEJlbm4/P2UgPGFsZXguYmVubmVlQGxpbmFyby5vcmc+OyBTdHJhdG9z DQo+ID4gPiBNYWlsaW5nDQo+ID4gPiA+ID4gTGlzdA0KPiA+ID4gPiA+ID4gPiA+ID4gPiA8c3Ry YXRvcy1kZXZAb3AtbGlzdHMubGluYXJvLm9yZz47IHZpcnRpby0NCj4gZGV2QGxpc3RzLm9hc2lz LQ0KPiA+ID4gPiA+IG9wZW4ub3JnOw0KPiA+ID4gPiA+ID4gPiA+IEFybmQNCj4gPiA+ID4gPiA+ ID4gPiA+ID4gQmVyZ21hbm4gPGFybmQuYmVyZ21hbm5AbGluYXJvLm9yZz47IFZpcmVzaCBLdW1h cg0KPiA+ID4gPiA+ID4gPiA+ID4gPiA8dmlyZXNoLmt1bWFyQGxpbmFyby5vcmc+OyBTdGVmYW5v IFN0YWJlbGxpbmkNCj4gPiA+ID4gPiA+ID4gPiA+ID4gPHN0ZWZhbm8uc3RhYmVsbGluaUB4aWxp bnguY29tPjsgc3RlZmFuaGFAcmVkaGF0LmNvbTsNCj4gSmFuDQo+ID4gPiBLaXN6a2ENCj4gPiA+ ID4gPiA+ID4gPiA+ID4gPGphbi5raXN6a2FAc2llbWVucy5jb20+OyBDYXJsIHZhbiBTY2hhaWsN Cj4gPiA+ID4gPiA8Y3ZhbnNjaGFAcXRpLnF1YWxjb21tLmNvbT47DQo+ID4gPiA+ID4gPiA+ID4g PiA+IHByYXRpa3BAcXVpY2luYy5jb207IFNyaXZhdHNhIFZhZGRhZ2lyaQ0KPiA+ID4gPHZhdHNh QGNvZGVhdXJvcmEub3JnPjsNCj4gPiA+ID4gPiBKZWFuLQ0KPiA+ID4gPiA+ID4gPiA+ID4gPiBQ aGlsaXBwZSBCcnVja2VyIDxqZWFuLXBoaWxpcHBlQGxpbmFyby5vcmc+OyBNYXRoaWV1DQo+IFBv aXJpZXINCj4gPiA+ID4gPiA+ID4gPiA+ID4gPG1hdGhpZXUucG9pcmllckBsaW5hcm8ub3JnPjsg V2VpIENoZW4NCj4gPFdlaS5DaGVuQGFybS5jb20+Ow0KPiA+ID4gPiA+IE9sZWtzYW5kcg0KPiA+ ID4gPiA+ID4gPiA+ID4gPiBUeXNoY2hlbmtvIDxPbGVrc2FuZHJfVHlzaGNoZW5rb0BlcGFtLmNv bT47IEJlcnRyYW5kDQo+IE1hcnF1aXMNCj4gPiA+ID4gPiA+ID4gPiA+ID4gPEJlcnRyYW5kLk1h cnF1aXNAYXJtLmNvbT47IEFydGVtIE15Z2FpZXYNCj4gPiA+ID4gPiA8QXJ0ZW1fTXlnYWlldkBl cGFtLmNvbT47DQo+ID4gPiA+ID4gPiA+ID4gSnVsaWVuDQo+ID4gPiA+ID4gPiA+ID4gPiA+IEdy YWxsIDxqdWxpZW5AeGVuLm9yZz47IEp1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT47DQo+ ID4gPiBQYXVsDQo+ID4gPiA+ID4gRHVycmFudA0KPiA+ID4gPiA+ID4gPiA+ID4gPiA8cGF1bEB4 ZW4ub3JnPjsgWGVuIERldmVsIDx4ZW4tZGV2ZWxAbGlzdHMueGVuLm9yZz4NCj4gPiA+ID4gPiA+ ID4gPiA+ID4gPiA+IFN1YmplY3Q6IFJlOiBFbmFibGluZyBoeXBlcnZpc29yIGFnbm9zdGljaXNt IGZvcg0KPiBWaXJ0SU8NCj4gPiA+ID4gPiBiYWNrZW5kcw0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ ID4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+IEhlbGxvLCBhbGwuDQo+ID4gPiA+ID4gPiA+ID4g PiA+ID4gPg0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gUGxlYXNlIHNlZSBzb21lIGNvbW1lbnRz IGJlbG93LiBBbmQgc29ycnkgZm9yIHRoZQ0KPiA+ID4gcG9zc2libGUNCj4gPiA+ID4gPiBmb3Jt YXQNCj4gPiA+ID4gPiA+ID4gPiA+ID4gaXNzdWVzLg0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4N Cj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gT24gV2VkLCBBdWcgMTEsIDIwMjEgYXQgOToyNyBB TSBBS0FTSEkgVGFrYWhpcm8NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPG1haWx0bzp0YWthaGlyby5h a2FzaGlAbGluYXJvLm9yZz4gd3JvdGU6DQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+IE9uIFdl ZCwgQXVnIDA0LCAyMDIxIGF0IDEyOjIwOjAxUE0gLTA3MDAsIFN0ZWZhbm8NCj4gPiA+ID4gPiBT dGFiZWxsaW5pDQo+ID4gPiA+ID4gPiA+ID4gd3JvdGU6DQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4g PiA+ID4gQ0NpbmcgcGVvcGxlIHdvcmtpbmcgb24gWGVuK1ZpcnRJTyBhbmQgSU9SRVFzLg0KPiBO b3QNCj4gPiA+ID4gPiB0cmltbWluZw0KPiA+ID4gPiA+ID4gPiA+IHRoZQ0KPiA+ID4gPiA+ID4g PiA+ID4gPiBvcmlnaW5hbA0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+IGVtYWlsIHRvIGxl dCB0aGVtIHJlYWQgdGhlIGZ1bGwgY29udGV4dC4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4g Pg0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+IE15IGNvbW1lbnRzIGJlbG93IGFyZSByZWxh dGVkIHRvIGEgcG90ZW50aWFsIFhlbg0KPiA+ID4gPiA+ID4gPiA+IGltcGxlbWVudGF0aW9uLA0K PiA+ID4gPiA+ID4gPiA+ID4gPiBub3QNCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiBiZWNh dXNlIGl0IGlzIHRoZSBvbmx5IGltcGxlbWVudGF0aW9uIHRoYXQNCj4gbWF0dGVycywNCj4gPiA+ IGJ1dA0KPiA+ID4gPiA+ID4gPiA+IGJlY2F1c2UgaXQNCj4gPiA+ID4gPiA+ID4gPiA+ID4gaXMN Cj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiB0aGUgb25lIEkga25vdyBiZXN0Lg0KPiA+ID4g PiA+ID4gPiA+ID4gPiA+ID4gPg0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiBQbGVhc2Ugbm90 ZSB0aGF0IG15IHByb3Bvc2FsIChhbmQgaGVuY2UgdGhlDQo+IHdvcmtpbmcNCj4gPiA+ID4gPiBw cm90b3R5cGUpWzFdDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+IGlzIGJhc2VkIG9uIFhlbidz IHZpcnRpbyBpbXBsZW1lbnRhdGlvbiAoaS5lLg0KPiBJT1JFUSkNCj4gPiA+IGFuZA0KPiA+ID4g PiA+ID4gPiA+ID4gPiBwYXJ0aWN1bGFybHkNCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gRVBB TSdzIHZpcnRpby1kaXNrIGFwcGxpY2F0aW9uIChiYWNrZW5kIHNlcnZlcikuDQo+ID4gPiA+ID4g PiA+ID4gPiA+ID4gPiA+IEl0IGhhcyBiZWVuLCBJIGJlbGlldmUsIHdlbGwgZ2VuZXJhbGl6ZWQg YnV0IGlzDQo+IHN0aWxsDQo+ID4gPiBhDQo+ID4gPiA+ID4gYml0DQo+ID4gPiA+ID4gPiA+ID4g Ymlhc2VkDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+IHRvd2FyZCB0aGlzIG9yaWdpbmFsIGRl c2lnbi4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ ID4gU28gSSBob3BlIHlvdSBsaWtlIG15IGFwcHJvYWNoIDopDQo+ID4gPiA+ID4gPiA+ID4gPiA+ ID4gPiA+DQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+IFsxXSBodHRwczovL29wLWxpc3RzLmxp bmFyby5vcmcvcGlwZXJtYWlsL3N0cmF0b3MtDQo+ID4gPiA+ID4gZGV2LzIwMjEtDQo+ID4gPiA+ ID4gPiA+ID4gPiA+IEF1Z3VzdC8wMDA1NDYuaHRtbA0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4g Pg0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiBMZXQgbWUgdGFrZSB0aGlzIG9wcG9ydHVuaXR5 IHRvIGV4cGxhaW4gYSBiaXQgbW9yZQ0KPiA+ID4gYWJvdXQNCj4gPiA+ID4gPiBteQ0KPiA+ID4g PiA+ID4gPiA+IGFwcHJvYWNoDQo+ID4gPiA+ID4gPiA+ID4gPiA+IGJlbG93Lg0KPiA+ID4gPiA+ ID4gPiA+ID4gPiA+ID4gPg0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+IEFsc28sIHBsZWFz ZSBzZWUgdGhpcyByZWxldmFudCBlbWFpbCB0aHJlYWQ6DQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4g PiA+ID4gaHR0cHM6Ly9tYXJjLmluZm8vP2w9eGVuLQ0KPiBkZXZlbCZtPTE2MjM3Mzc1NDcwNTIz MyZ3PTINCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPg0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ ID4gPiA+DQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gT24gV2VkLCA0IEF1ZyAyMDIxLCBB bGV4IEJlbm7DqWUgd3JvdGU6DQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiBIaSwNCj4g PiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+DQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4g PiBPbmUgb2YgdGhlIGdvYWxzIG9mIFByb2plY3QgU3RyYXRvcyBpcyB0bw0KPiBlbmFibGUNCj4g PiA+ID4gPiBoeXBlcnZpc29yDQo+ID4gPiA+ID4gPiA+ID4gPiA+IGFnbm9zdGljDQo+ID4gPiA+ ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiBiYWNrZW5kcyBzbyB3ZSBjYW4gZW5hYmxlIGFzIG11Y2gg cmUtdXNlIG9mDQo+IGNvZGUNCj4gPiA+IGFzDQo+ID4gPiA+ID4gcG9zc2libGUNCj4gPiA+ID4g PiA+ID4gPiBhbmQNCj4gPiA+ID4gPiA+ID4gPiA+ID4gYXZvaWQNCj4gPiA+ID4gPiA+ID4gPiA+ ID4gPiA+ID4gPiA+IHJlcGVhdGluZyBvdXJzZWx2ZXMuIFRoaXMgaXMgdGhlIGZsaXAgc2lkZSBv Zg0KPiB0aGUNCj4gPiA+ID4gPiBmcm9udCBlbmQNCj4gPiA+ID4gPiA+ID4gPiA+ID4gd2hlcmUN Cj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+IG11bHRpcGxlIGZyb250LWVuZCBpbXBsZW1l bnRhdGlvbnMgYXJlDQo+IHJlcXVpcmVkIC0NCj4gPiA+IG9uZQ0KPiA+ID4gPiA+IHBlciBPUywN Cj4gPiA+ID4gPiA+ID4gPiA+ID4gYXNzdW1pbmcNCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4g PiA+IHlvdSBkb24ndCBqdXN0IHdhbnQgTGludXggZ3Vlc3RzLiBUaGUNCj4gcmVzdWx0YW50DQo+ ID4gPiBndWVzdHMNCj4gPiA+ID4gPiBhcmUNCj4gPiA+ID4gPiA+ID4gPiA+ID4gdHJpdmlhbGx5 DQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiBtb3ZhYmxlIGJldHdlZW4gaHlwZXJ2aXNv cnMgbW9kdWxvIGFueQ0KPiBhYnN0cmFjdGVkDQo+ID4gPiA+ID4gcGFyYXZpcnQNCj4gPiA+ID4g PiA+ID4gPiB0eXBlDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiBpbnRlcmZhY2VzLg0K PiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4g PiA+IEluIG15IG9yaWdpbmFsIHRodW1iIG5haWwgc2tldGNoIG9mIGEgc29sdXRpb24NCj4gSQ0K PiA+ID4gPiA+IGVudmlzaW9uZWQNCj4gPiA+ID4gPiA+ID4gPiA+ID4gdmhvc3QtdXNlcg0KPiA+ ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gZGFlbW9ucyBydW5uaW5nIGluIGEgYnJvYWRseSBQ T1NJWCBsaWtlDQo+ID4gPiBlbnZpcm9ubWVudC4NCj4gPiA+ID4gPiBUaGUNCj4gPiA+ID4gPiA+ ID4gPiA+ID4gaW50ZXJmYWNlIHRvDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiB0aGUg ZGFlbW9uIGlzIGZhaXJseSBzaW1wbGUgcmVxdWlyaW5nIG9ubHkNCj4gc29tZQ0KPiA+ID4gbWFw cGVkDQo+ID4gPiA+ID4gPiA+ID4gbWVtb3J5DQo+ID4gPiA+ID4gPiA+ID4gPiA+IGFuZCBzb21l DQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiBzb3J0IG9mIHNpZ25hbGxpbmcgZm9yIGV2 ZW50cyAob24gTGludXggdGhpcw0KPiBpcw0KPiA+ID4gPiA+IGV2ZW50ZmQpLg0KPiA+ID4gPiA+ ID4gPiA+IFRoZQ0KPiA+ID4gPiA+ID4gPiA+ID4gPiBpZGVhIHdhcyBhDQo+ID4gPiA+ID4gPiA+ ID4gPiA+ID4gPiA+ID4gPiBzdHViIGJpbmFyeSB3b3VsZCBiZSByZXNwb25zaWJsZSBmb3IgYW55 DQo+ID4gPiBoeXBlcnZpc29yDQo+ID4gPiA+ID4gc3BlY2lmaWMNCj4gPiA+ID4gPiA+ID4gPiA+ ID4gc2V0dXAgYW5kDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiB0aGVuIGxhdW5jaCBh IGNvbW1vbiBiaW5hcnkgdG8gZGVhbCB3aXRoIHRoZQ0KPiA+ID4gYWN0dWFsDQo+ID4gPiA+ID4g PiA+ID4gdmlydHF1ZXVlDQo+ID4gPiA+ID4gPiA+ID4gPiA+IHJlcXVlc3RzDQo+ID4gPiA+ID4g PiA+ID4gPiA+ID4gPiA+ID4gPiB0aGVtc2VsdmVzLg0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4g PiA+ID4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+IFNpbmNlIHRoYXQgb3JpZ2luYWwg c2tldGNoIHdlJ3ZlIHNlZW4gYW4NCj4gZXhwYW5zaW9uDQo+ID4gPiBpbg0KPiA+ID4gPiA+IHRo ZQ0KPiA+ID4gPiA+ID4gPiA+IHNvcnQNCj4gPiA+ID4gPiA+ID4gPiA+ID4gb2Ygd2F5cw0KPiA+ ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gYmFja2VuZHMgY291bGQgYmUgY3JlYXRlZC4gVGhl cmUgaXMgaW50ZXJlc3QNCj4gaW4NCj4gPiA+ID4gPiA+ID4gPiBlbmNhcHN1bGF0aW5nDQo+ID4g PiA+ID4gPiA+ID4gPiA+IGJhY2tlbmRzDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiBp biBSVE9TZXMgb3IgdW5pa2VybmVscyBmb3Igc29sdXRpb25zIGxpa2UNCj4gU0NNSS4NCj4gPiA+ IFRoZXJlDQo+ID4gPiA+ID4gPiA+ID4gaW50ZXJlc3QNCj4gPiA+ID4gPiA+ID4gPiA+ID4gaW4g UnVzdA0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gaGFzIHByb21wdGVkIGlkZWFzIG9m IHVzaW5nIHRoZSB0cmFpdA0KPiBpbnRlcmZhY2UgdG8NCj4gPiA+ID4gPiBhYnN0cmFjdA0KPiA+ ID4gPiA+ID4gPiA+ID4gPiBkaWZmZXJlbmNlcw0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ ID4gYXdheSBhcyB3ZWxsIGFzIHRoZSBpZGVhIG9mIGJhcmUtbWV0YWwgUnVzdA0KPiA+ID4gYmFj a2VuZHMuDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPg0KPiA+ID4gPiA+ID4gPiA+ID4g PiA+ID4gPiA+ID4gV2UgaGF2ZSBhIGNhcmQgKFNUUi0xMikgY2FsbGVkICJIeXBlcmNhbGwNCj4g PiA+ID4gPiBTdGFuZGFyZGlzYXRpb24iDQo+ID4gPiA+ID4gPiA+ID4gd2hpY2gNCj4gPiA+ID4g PiA+ID4gPiA+ID4gPiA+ID4gPiA+IGNhbGxzIGZvciBhIGRlc2NyaXB0aW9uIG9mIHRoZSBBUElz IG5lZWRlZA0KPiBmcm9tDQo+ID4gPiB0aGUNCj4gPiA+ID4gPiA+ID4gPiBoeXBlcnZpc29yDQo+ ID4gPiA+ID4gPiA+ID4gPiA+IHNpZGUgdG8NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ IHN1cHBvcnQgVmlydElPIGd1ZXN0cyBhbmQgdGhlaXIgYmFja2VuZHMuDQo+IEhvd2V2ZXINCj4g PiA+IHdlDQo+ID4gPiA+ID4gYXJlDQo+ID4gPiA+ID4gPiA+ID4gc29tZQ0KPiA+ID4gPiA+ID4g PiA+ID4gPiB3YXkgb2ZmDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiBmcm9tIHRoYXQg YXQgdGhlIG1vbWVudCBhcyBJIHRoaW5rIHdlIG5lZWQgdG8NCj4gYXQNCj4gPiA+IGxlYXN0DQo+ ID4gPiA+ID4gPiA+ID4gPiA+IGRlbW9uc3RyYXRlIG9uZQ0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ ID4gPiA+ID4gcG9ydGFibGUgYmFja2VuZCBiZWZvcmUgd2Ugc3RhcnQgY29kaWZ5aW5nDQo+ID4g PiA+ID4gcmVxdWlyZW1lbnRzLiBUbw0KPiA+ID4gPiA+ID4gPiA+IHRoYXQNCj4gPiA+ID4gPiA+ ID4gPiA+ID4gZW5kIEkNCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+IHdhbnQgdG8gdGhp bmsgYWJvdXQgd2hhdCB3ZSBuZWVkIGZvciBhIGJhY2tlbmQNCj4gdG8NCj4gPiA+ID4gPiBmdW5j dGlvbi4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+DQo+ID4gPiA+ID4gPiA+ID4gPiA+ ID4gPiA+ID4gPiBDb25maWd1cmF0aW9uDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA9 PT09PT09PT09PT09DQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPg0KPiA+ID4gPiA+ID4g PiA+ID4gPiA+ID4gPiA+ID4gSW4gdGhlIHR5cGUtMiBzZXR1cCB0aGlzIGlzIHR5cGljYWxseSBm YWlybHkNCj4gPiA+IHNpbXBsZQ0KPiA+ID4gPiA+IGJlY2F1c2UNCj4gPiA+ID4gPiA+ID4gPiB0 aGUNCj4gPiA+ID4gPiA+ID4gPiA+ID4gaG9zdA0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ ID4gc3lzdGVtIGNhbiBvcmNoZXN0cmF0ZSB0aGUgdmFyaW91cyBtb2R1bGVzDQo+IHRoYXQNCj4g PiA+IG1ha2UNCj4gPiA+ID4gPiB1cCB0aGUNCj4gPiA+ID4gPiA+ID4gPiA+ID4gY29tcGxldGUN Cj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+IHN5c3RlbS4gSW4gdGhlIHR5cGUtMSBjYXNl IChvciBldmVuIHR5cGUtMg0KPiB3aXRoDQo+ID4gPiA+ID4gZGVsZWdhdGVkDQo+ID4gPiA+ID4g PiA+ID4gPiA+IHNlcnZpY2UgVk1zKQ0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gd2Ug bmVlZCBzb21lIHNvcnQgb2YgbWVjaGFuaXNtIHRvIGluZm9ybSB0aGUNCj4gPiA+IGJhY2tlbmQN Cj4gPiA+ID4gPiBWTQ0KPiA+ID4gPiA+ID4gPiA+IGFib3V0DQo+ID4gPiA+ID4gPiA+ID4gPiA+ IGtleQ0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gZGV0YWlscyBhYm91dCB0aGUgc3lz dGVtOg0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4NCj4gPiA+ID4gPiA+ID4gPiA+ID4g PiA+ID4gPiA+ICAgLSB3aGVyZSB2aXJ0IHF1ZXVlIG1lbW9yeSBpcyBpbiBpdCdzIGFkZHJlc3MN Cj4gPiA+IHNwYWNlDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiAgIC0gaG93IGl0J3Mg Z29pbmcgdG8gcmVjZWl2ZSAoaW50ZXJydXB0KSBhbmQNCj4gPiA+IHRyaWdnZXINCj4gPiA+ID4g PiAoa2ljaykNCj4gPiA+ID4gPiA+ID4gPiA+ID4gZXZlbnRzDQo+ID4gPiA+ID4gPiA+ID4gPiA+ ID4gPiA+ID4gPiAgIC0gd2hhdCAoaWYgYW55KSByZXNvdXJjZXMgdGhlIGJhY2tlbmQgbmVlZHMN Cj4gdG8NCj4gPiA+ID4gPiBjb25uZWN0IHRvDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4g Pg0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gT2J2aW91c2x5IHlvdSBjYW4gZWxpZGUg b3ZlciBjb25maWd1cmF0aW9uDQo+IGlzc3Vlcw0KPiA+ID4gYnkNCj4gPiA+ID4gPiBoYXZpbmcN Cj4gPiA+ID4gPiA+ID4gPiA+ID4gc3RhdGljDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4g PiBjb25maWd1cmF0aW9ucyBhbmQgYmFraW5nIHRoZSBhc3N1bXB0aW9ucyBpbnRvDQo+ID4gPiB5 b3VyDQo+ID4gPiA+ID4gZ3Vlc3QNCj4gPiA+ID4gPiA+ID4gPiBpbWFnZXMNCj4gPiA+ID4gPiA+ ID4gPiA+ID4gaG93ZXZlcg0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gdGhpcyBpc24n dCBzY2FsYWJsZSBpbiB0aGUgbG9uZyB0ZXJtLiBUaGUNCj4gb2J2aW91cw0KPiA+ID4gPiA+IHNv bHV0aW9uDQo+ID4gPiA+ID4gPiA+ID4gc2VlbXMNCj4gPiA+ID4gPiA+ID4gPiA+ID4gdG8gYmUN Cj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+IGV4dGVuZGluZyBhIHN1YnNldCBvZiBEZXZp Y2UgVHJlZSBkYXRhIHRvIHVzZXINCj4gPiA+IHNwYWNlDQo+ID4gPiA+ID4gYnV0DQo+ID4gPiA+ ID4gPiA+ID4gcGVyaGFwcw0KPiA+ID4gPiA+ID4gPiA+ID4gPiB0aGVyZQ0KPiA+ID4gPiA+ID4g PiA+ID4gPiA+ID4gPiA+ID4gYXJlIG90aGVyIGFwcHJvYWNoZXM/DQo+ID4gPiA+ID4gPiA+ID4g PiA+ID4gPiA+ID4gPg0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gQmVmb3JlIGFueSB2 aXJ0aW8gdHJhbnNhY3Rpb25zIGNhbiB0YWtlIHBsYWNlDQo+IHRoZQ0KPiA+ID4gPiA+ID4gPiA+ IGFwcHJvcHJpYXRlDQo+ID4gPiA+ID4gPiA+ID4gPiA+IG1lbW9yeQ0KPiA+ID4gPiA+ID4gPiA+ ID4gPiA+ID4gPiA+ID4gbWFwcGluZ3MgbmVlZCB0byBiZSBtYWRlIGJldHdlZW4gdGhlIEZFIGd1 ZXN0DQo+IGFuZA0KPiA+ID4gdGhlDQo+ID4gPiA+ID4gQkUNCj4gPiA+ID4gPiA+ID4gPiBndWVz dC4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPg0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4g PiA+ID4gQ3VycmVudGx5IHRoZSB3aG9sZSBvZiB0aGUgRkUgZ3Vlc3RzIGFkZHJlc3MNCj4gc3Bh Y2UNCj4gPiA+ID4gPiBuZWVkcyB0bw0KPiA+ID4gPiA+ID4gPiA+IGJlDQo+ID4gPiA+ID4gPiA+ ID4gPiA+IHZpc2libGUNCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+IHRvIHdoYXRldmVy IGlzIHNlcnZpbmcgdGhlIHZpcnRpbyByZXF1ZXN0cy4gSQ0KPiBjYW4NCj4gPiA+ID4gPiBlbnZp c2lvbiAzDQo+ID4gPiA+ID4gPiA+ID4gPiA+IGFwcHJvYWNoZXM6DQo+ID4gPiA+ID4gPiA+ID4g PiA+ID4gPiA+ID4gPg0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gICogQkUgZ3Vlc3Qg Ym9vdHMgd2l0aCBtZW1vcnkgYWxyZWFkeSBtYXBwZWQNCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ ID4gPiA+DQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiAgVGhpcyB3b3VsZCBlbnRhaWwg dGhlIGd1ZXN0IE9TIGtub3dpbmcgd2hlcmUNCj4gaW4NCj4gPiA+IGl0J3MNCj4gPiA+ID4gPiBH dWVzdA0KPiA+ID4gPiA+ID4gPiA+ID4gPiBQaHlzaWNhbA0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ ID4gPiA+ID4gIEFkZHJlc3Mgc3BhY2UgaXMgYWxyZWFkeSB0YWtlbiB1cCBhbmQNCj4gYXZvaWRp bmcNCj4gPiA+ID4gPiBjbGFzaGluZy4gSQ0KPiA+ID4gPiA+ID4gPiA+ID4gPiB3b3VsZCBhc3N1 bWUNCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ICBpbiB0aGlzIGNhc2UgeW91IHdvdWxk IHdhbnQgYSBzdGFuZGFyZA0KPiBpbnRlcmZhY2UNCj4gPiA+IHRvDQo+ID4gPiA+ID4gPiA+ID4g dXNlcnNwYWNlDQo+ID4gPiA+ID4gPiA+ID4gPiA+IHRvIHRoZW4NCj4gPiA+ID4gPiA+ID4gPiA+ ID4gPiA+ID4gPiA+ICBtYWtlIHRoYXQgYWRkcmVzcyBzcGFjZSB2aXNpYmxlIHRvIHRoZQ0KPiBi YWNrZW5kDQo+ID4gPiBkYWVtb24uDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+DQo+ID4gPiA+ ID4gPiA+ID4gPiA+ID4gPiA+IFlldCBhbm90aGVyIHdheSBoZXJlIGlzIHRoYXQgd2Ugd291bGQg aGF2ZSB3ZWxsDQo+IGtub3duDQo+ID4gPiA+ID4gInNoYXJlZA0KPiA+ID4gPiA+ID4gPiA+ID4g PiBtZW1vcnkiIGJldHdlZW4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gVk1zLiBJIHRoaW5r IHRoYXQgSmFpbGhvdXNlJ3MgaXZzaG1lbSBnaXZlcyB1cw0KPiBnb29kDQo+ID4gPiA+ID4gaW5z aWdodHMgb24NCj4gPiA+ID4gPiA+ID4gPiB0aGlzDQo+ID4gPiA+ID4gPiA+ID4gPiA+IG1hdHRl cg0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiBhbmQgdGhhdCBpdCBjYW4gZXZlbiBiZSBhbiBh bHRlcm5hdGl2ZSBmb3INCj4gaHlwZXJ2aXNvci0NCj4gPiA+ID4gPiBhZ25vc3RpYw0KPiA+ID4g PiA+ID4gPiA+ID4gPiBzb2x1dGlvbi4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4NCj4gPiA+ ID4gPiA+ID4gPiA+ID4gPiA+ID4gKFBsZWFzZSBub3RlIG1lbW9yeSByZWdpb25zIGluIGl2c2ht ZW0gYXBwZWFyIGFzIGENCj4gUENJDQo+ID4gPiA+ID4gZGV2aWNlDQo+ID4gPiA+ID4gPiA+ID4g YW5kDQo+ID4gPiA+ID4gPiA+ID4gPiA+IGNhbiBiZQ0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4g PiBtYXBwZWQgbG9jYWxseS4pDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+DQo+ID4gPiA+ID4g PiA+ID4gPiA+ID4gPiA+IEkgd2FudCB0byBhZGQgdGhpcyBzaGFyZWQgbWVtb3J5IGFzcGVjdCB0 byBteQ0KPiB2aXJ0aW8tDQo+ID4gPiBwcm94eSwNCj4gPiA+ID4gPiBidXQNCj4gPiA+ID4gPiA+ ID4gPiA+ID4gPiA+ID4gdGhlIHJlc3VsdGFudCBzb2x1dGlvbiB3b3VsZCBldmVudHVhbGx5IGxv b2sNCj4gc2ltaWxhcg0KPiA+ID4gdG8NCj4gPiA+ID4gPiBpdnNobWVtLg0KPiA+ID4gPiA+ID4g PiA+ID4gPiA+ID4gPg0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gICogQkUgZ3Vlc3Rz IGJvb3RzIHdpdGggYSBoeXBlcnZpc29yIGhhbmRsZSB0bw0KPiA+ID4gbWVtb3J5DQo+ID4gPiA+ ID4gPiA+ID4gPiA+ID4gPiA+ID4gPg0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gIFRo ZSBCRSBndWVzdCBpcyB0aGVuIGZyZWUgdG8gbWFwIHRoZSBGRSdzDQo+IG1lbW9yeQ0KPiA+ID4g dG8NCj4gPiA+ID4gPiB3aGVyZQ0KPiA+ID4gPiA+ID4gPiA+IGl0DQo+ID4gPiA+ID4gPiA+ID4g PiA+IHdhbnRzIGluDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiAgdGhlIEJFJ3MgZ3Vl c3QgcGh5c2ljYWwgYWRkcmVzcyBzcGFjZS4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPg0K PiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+IEkgY2Fubm90IHNlZSBob3cgdGhpcyBjb3VsZCB3 b3JrIGZvciBYZW4uIFRoZXJlDQo+IGlzDQo+ID4gPiBubw0KPiA+ID4gPiA+ICJoYW5kbGUiDQo+ ID4gPiA+ID4gPiA+ID4gdG8NCj4gPiA+ID4gPiA+ID4gPiA+ID4gZ2l2ZQ0KPiA+ID4gPiA+ID4g PiA+ID4gPiA+ID4gPiA+IHRvIHRoZSBiYWNrZW5kIGlmIHRoZSBiYWNrZW5kIGlzIG5vdCBydW5u aW5nIGluDQo+IGRvbTAuDQo+ID4gPiBTbw0KPiA+ID4gPiA+IGZvcg0KPiA+ID4gPiA+ID4gPiA+ IFhlbiBJDQo+ID4gPiA+ID4gPiA+ID4gPiA+IHRoaW5rDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4g PiA+ID4gdGhlIG1lbW9yeSBoYXMgdG8gYmUgYWxyZWFkeSBtYXBwZWQNCj4gPiA+ID4gPiA+ID4g PiA+ID4gPiA+ID4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gSW4gWGVuJ3MgSU9SRVEgc29s dXRpb24gKHZpcnRpby1ibGspLCB0aGUNCj4gZm9sbG93aW5nDQo+ID4gPiA+ID4gaW5mb3JtYXRp b24NCj4gPiA+ID4gPiA+ID4gPiBpcw0KPiA+ID4gPiA+ID4gPiA+ID4gPiBleHBlY3RlZA0KPiA+ ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiB0byBiZSBleHBvc2VkIHRvIEJFIHZpYSBYZW5zdG9yZToN Cj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gKEkga25vdyB0aGF0IHRoaXMgaXMgYSB0ZW50YXRp dmUgYXBwcm9hY2ggdGhvdWdoLikNCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gICAgLSB0aGUg c3RhcnQgYWRkcmVzcyBvZiBjb25maWd1cmF0aW9uIHNwYWNlDQo+ID4gPiA+ID4gPiA+ID4gPiA+ ID4gPiA+ICAgIC0gaW50ZXJydXB0IG51bWJlcg0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiAg ICAtIGZpbGUgcGF0aCBmb3IgYmFja2luZyBzdG9yYWdlDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4g PiA+ICAgIC0gcmVhZC1vbmx5IGZsYWcNCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gQW5kIHRo ZSBCRSBzZXJ2ZXIgaGF2ZSB0byBjYWxsIGEgcGFydGljdWxhcg0KPiBoeXBlcnZpc29yDQo+ID4g PiA+ID4gaW50ZXJmYWNlDQo+ID4gPiA+ID4gPiA+ID4gdG8NCj4gPiA+ID4gPiA+ID4gPiA+ID4g PiA+ID4gbWFwIHRoZSBjb25maWd1cmF0aW9uIHNwYWNlLg0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ ID4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+IFllcywgWGVuc3RvcmUgd2FzIGNob3NlbiBhcyBh IHNpbXBsZSB3YXkgdG8gcGFzcw0KPiA+ID4gPiA+IGNvbmZpZ3VyYXRpb24NCj4gPiA+ID4gPiA+ ID4gPiBpbmZvIHRvDQo+ID4gPiA+ID4gPiA+ID4gPiA+IHRoZSBiYWNrZW5kIHJ1bm5pbmcgaW4g YSBub24tdG9vbHN0YWNrIGRvbWFpbi4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+IEkgcmVtZW1i ZXIsIHRoZXJlIHdhcyBhIHdpc2ggdG8gYXZvaWQgdXNpbmcgWGVuc3RvcmUNCj4gaW4NCj4gPiA+ ID4gPiBWaXJ0aW8NCj4gPiA+ID4gPiA+ID4gPiBiYWNrZW5kDQo+ID4gPiA+ID4gPiA+ID4gPiA+ IGl0c2VsZiBpZiBwb3NzaWJsZSwgc28gZm9yIG5vbi10b29sc3RhY2sgZG9tYWluLCB0aGlzDQo+ IGNvdWxkDQo+ID4gPiBkb25lDQo+ID4gPiA+ID4gd2l0aA0KPiA+ID4gPiA+ID4gPiA+ID4gPiBh ZGp1c3RpbmcgZGV2ZCAoZGFlbW9uIHRoYXQgbGlzdGVucyBmb3IgZGV2aWNlcyBhbmQNCj4gbGF1 bmNoZXMNCj4gPiA+ID4gPiBiYWNrZW5kcykNCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+IHRvIHJl YWQgYmFja2VuZCBjb25maWd1cmF0aW9uIGZyb20gdGhlIFhlbnN0b3JlDQo+IGFueXdheQ0KPiA+ ID4gYW5kDQo+ID4gPiA+ID4gcGFzcyBpdA0KPiA+ID4gPiA+ID4gPiA+IHRvDQo+ID4gPiA+ID4g PiA+ID4gPiA+IHRoZSBiYWNrZW5kIHZpYSBjb21tYW5kIGxpbmUgYXJndW1lbnRzLg0KPiA+ID4g PiA+ID4gPiA+ID4gPiA+ID4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPg0KPiA+ID4gPiA+ID4gPiA+ ID4gPiA+IFllcywgaW4gY3VycmVudCBQb0MgY29kZSB3ZSdyZSB1c2luZyB4ZW5zdG9yZSB0byBw YXNzDQo+ID4gPiBkZXZpY2UNCj4gPiA+ID4gPiA+ID4gPiA+ID4gY29uZmlndXJhdGlvbi4NCj4g PiA+ID4gPiA+ID4gPiA+ID4gPiBXZSBhbHNvIGRlc2lnbmVkIGEgc3RhdGljIGRldmljZSBjb25m aWd1cmF0aW9uIHBhcnNlDQo+ID4gPiBtZXRob2QNCj4gPiA+ID4gPiBmb3INCj4gPiA+ID4gPiA+ ID4gPiBEb20wbGVzcw0KPiA+ID4gPiA+ID4gPiA+ID4gPiBvcg0KPiA+ID4gPiA+ID4gPiA+ID4g PiA+IG90aGVyIHNjZW5hcmlvcyBkb24ndCBoYXZlIHhlbnRvb2wuIHllcywgaXQncyBmcm9tDQo+ IGRldmljZQ0KPiA+ID4gPiA+IG1vZGVsDQo+ID4gPiA+ID4gPiA+ID4gY29tbWFuZA0KPiA+ID4g PiA+ID4gPiA+ID4gPiBsaW5lDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gb3IgYSBjb25maWcgZmls ZS4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPg0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gQnV0LCBp ZiAuLi4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+DQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ DQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+IEluIG15IGFwcHJvYWNoICh2aXJ0aW8tcHJveHkp LCBhbGwgdGhvc2UgWGVuIChvcg0KPiA+ID4gPiA+IGh5cGVydmlzb3IpLQ0KPiA+ID4gPiA+ID4g PiA+ID4gPiBzcGVjaWZpYw0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiBzdHVmZnMgYXJlIGNv bnRhaW5lZCBpbiB2aXJ0aW8tcHJveHksIHlldCBhbm90aGVyDQo+IFZNLA0KPiA+ID4gdG8NCj4g PiA+ID4gPiBoaWRlDQo+ID4gPiA+ID4gPiA+ID4gYWxsDQo+ID4gPiA+ID4gPiA+ID4gPiA+IGRl dGFpbHMuDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPg0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4g Li4uIHRoZSBzb2x1dGlvbiBob3cgdG8gb3ZlcmNvbWUgdGhhdCBpcyBhbHJlYWR5DQo+IGZvdW5k DQo+ID4gPiBhbmQNCj4gPiA+ID4gPiBwcm92ZW4NCj4gPiA+ID4gPiA+ID4gPiB0bw0KPiA+ID4g PiA+ID4gPiA+ID4gPiB3b3JrIHRoZW4gZXZlbiBiZXR0ZXIuDQo+ID4gPiA+ID4gPiA+ID4gPiA+ ID4gPg0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+DQo+ ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ICMgTXkgcG9pbnQgaXMgdGhhdCBhICJoYW5kbGUiIGlz IG5vdCBtYW5kYXRvcnkgZm9yDQo+ID4gPiA+ID4gZXhlY3V0aW5nDQo+ID4gPiA+ID4gPiA+ID4g bWFwcGluZy4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4NCj4gPiA+ID4gPiA+ID4gPiA+ID4g PiA+ID4gPiBhbmQgdGhlIG1hcHBpbmcgcHJvYmFibHkgZG9uZSBieSB0aGUNCj4gPiA+ID4gPiA+ ID4gPiA+ID4gPiA+ID4gPiB0b29sc3RhY2sgKGFsc28gc2VlIGJlbG93LikgT3Igd2Ugd291bGQg aGF2ZSB0bw0KPiA+ID4gaW52ZW50IGENCj4gPiA+ID4gPiBuZXcNCj4gPiA+ID4gPiA+ID4gPiBY ZW4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiBoeXBlcnZpc29yIGludGVyZmFjZSBhbmQg WGVuIHZpcnR1YWwgbWFjaGluZQ0KPiA+ID4gcHJpdmlsZWdlcw0KPiA+ID4gPiA+IHRvDQo+ID4g PiA+ID4gPiA+ID4gYWxsb3cNCj4gPiA+ID4gPiA+ID4gPiA+ID4gdGhpcw0KPiA+ID4gPiA+ID4g PiA+ID4gPiA+ID4gPiA+IGtpbmQgb2YgbWFwcGluZy4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ ID4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiBJZiB3ZSBydW4gdGhlIGJhY2tlbmQgaW4g RG9tMCB0aGF0IHdlIGhhdmUgbm8NCj4gPiA+IHByb2JsZW1zDQo+ID4gPiA+ID4gb2YNCj4gPiA+ ID4gPiA+ID4gPiBjb3Vyc2UuDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+DQo+ID4gPiA+ID4g PiA+ID4gPiA+ID4gPiA+IE9uZSBvZiBkaWZmaWN1bHRpZXMgb24gWGVuIHRoYXQgSSBmb3VuZCBp biBteQ0KPiBhcHByb2FjaA0KPiA+ID4gaXMNCj4gPiA+ID4gPiB0aGF0DQo+ID4gPiA+ID4gPiA+ ID4gPiA+IGNhbGxpbmcNCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gc3VjaCBoeXBlcnZpc29y IGludGVmYWNlcyAocmVnaXN0ZXJpbmcgSU9SRVEsDQo+IG1hcHBpbmcNCj4gPiA+ID4gPiBtZW1v cnkpIGlzDQo+ID4gPiA+ID4gPiA+ID4gPiA+IG9ubHkNCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ ID4gYWxsb3dlZCBvbiBCRSBzZXJ2ZXJzIHRoZW1zZWx2aWVzIGFuZCBzbyB3ZSB3aWxsDQo+IGhh dmUNCj4gPiA+IHRvDQo+ID4gPiA+ID4gZXh0ZW5kDQo+ID4gPiA+ID4gPiA+ID4gPiA+IHRob3Nl DQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+IGludGVyZmFjZXMuDQo+ID4gPiA+ID4gPiA+ID4g PiA+ID4gPiA+IFRoaXMsIGhvd2V2ZXIsIHdpbGwgcmFpc2Ugc29tZSBjb25jZXJuIG9uIHNlY3Vy aXR5DQo+IGFuZA0KPiA+ID4gPiA+IHByaXZpbGVnZQ0KPiA+ID4gPiA+ID4gPiA+ID4gPiBkaXN0 cmlidXRpb24NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gYXMgU3RlZmFuIHN1Z2dlc3RlZC4N Cj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+DQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiBXZSBhbHNv IGZhY2VkIHBvbGljeSByZWxhdGVkIGlzc3VlcyB3aXRoIFZpcnRpbw0KPiBiYWNrZW5kDQo+ID4g PiA+ID4gcnVubmluZyBpbg0KPiA+ID4gPiA+ID4gPiA+ID4gPiBvdGhlciB0aGFuIERvbTAgZG9t YWluIGluIGEgImR1bW15IiB4c20gbW9kZS4gSW4gb3VyDQo+IHRhcmdldA0KPiA+ID4gPiA+IHN5 c3RlbSB3ZQ0KPiA+ID4gPiA+ID4gPiA+IHJ1bg0KPiA+ID4gPiA+ID4gPiA+ID4gPiB0aGUgYmFj a2VuZCBpbiBhIGRyaXZlcg0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gZG9tYWluICh3ZSBjYWxs IGl0IERvbUQpIHdoZXJlIHRoZSB1bmRlcmx5aW5nIEgvVw0KPiA+ID4gcmVzaWRlcy4NCj4gPiA+ ID4gPiBXZQ0KPiA+ID4gPiA+ID4gPiA+IHRydXN0IGl0LA0KPiA+ID4gPiA+ID4gPiA+ID4gPiBz byB3ZSB3cm90ZSBwb2xpY3kgcnVsZXMgKHRvIGJlIHVzZWQgaW4gImZsYXNrIiB4c20gbW9kZSkN Cj4gdG8NCj4gPiA+ID4gPiBwcm92aWRlDQo+ID4gPiA+ID4gPiA+ID4gaXQNCj4gPiA+ID4gPiA+ ID4gPiA+ID4gd2l0aCBhIGxpdHRsZSBiaXQgbW9yZSBwcml2aWxlZ2VzIHRoYW4gYSBzaW1wbGUg RG9tVSBoYWQuDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiBOb3cgaXQgaXMgcGVybWl0dGVkIHRv IGlzc3VlIGRldmljZS1tb2RlbCwgcmVzb3VyY2UNCj4gYW5kDQo+ID4gPiA+ID4gbWVtb3J5DQo+ ID4gPiA+ID4gPiA+ID4gPiA+IG1hcHBpbmdzLCBldGMgY2FsbHMuDQo+ID4gPiA+ID4gPiA+ID4g PiA+ID4gPg0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+DQo+ID4gPiA+ID4gPiA+ID4gPiA+ ID4gPiA+ID4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+IFRvIGFjdGl2YXRlIHRoZSBt YXBwaW5nIHdpbGwNCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ICByZXF1aXJlIHNvbWUg c29ydCBvZiBoeXBlcmNhbGwgdG8gdGhlDQo+IGh5cGVydmlzb3IuDQo+ID4gPiBJDQo+ID4gPiA+ ID4gY2FuIHNlZQ0KPiA+ID4gPiA+ID4gPiA+IHR3bw0KPiA+ID4gPiA+ID4gPiA+ID4gPiBvcHRp b25zDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiAgYXQgdGhpcyBwb2ludDoNCj4gPiA+ ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+DQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiAg IC0gZXhwb3NlIHRoZSBoYW5kbGUgdG8gdXNlcnNwYWNlIGZvcg0KPiA+ID4gZGFlbW9uL2hlbHBl cg0KPiA+ID4gPiA+IHRvDQo+ID4gPiA+ID4gPiA+ID4gdHJpZ2dlcg0KPiA+ID4gPiA+ID4gPiA+ ID4gPiB0aGUNCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ICAgICBtYXBwaW5nIHZpYSBl eGlzdGluZyBoeXBlcmNhbGwgaW50ZXJmYWNlcy4NCj4gSWYNCj4gPiA+ID4gPiB1c2luZyBhDQo+ ID4gPiA+ID4gPiA+ID4gaGVscGVyDQo+ID4gPiA+ID4gPiA+ID4gPiA+IHlvdQ0KPiA+ID4gPiA+ ID4gPiA+ID4gPiA+ID4gPiA+ID4gICAgIHdvdWxkIGhhdmUgYSBoeXBlcnZpc29yIHNwZWNpZmlj IG9uZSB0bw0KPiBhdm9pZA0KPiA+ID4gdGhlDQo+ID4gPiA+ID4gZGFlbW9uDQo+ID4gPiA+ID4g PiA+ID4gPiA+IGhhdmluZyB0bw0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gICAgIGNh cmUgdG9vIG11Y2ggYWJvdXQgdGhlIGRldGFpbHMgb3IgcHVzaA0KPiB0aGF0DQo+ID4gPiA+ID4g Y29tcGxleGl0eQ0KPiA+ID4gPiA+ID4gPiA+IGludG8NCj4gPiA+ID4gPiA+ID4gPiA+ID4gYQ0K PiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gICAgIGNvbXBpbGUgdGltZSBvcHRpb24gZm9y IHRoZSBkYWVtb24gd2hpY2gNCj4gd291bGQNCj4gPiA+ID4gPiByZXN1bHQgaW4NCj4gPiA+ID4g PiA+ID4gPiA+ID4gZGlmZmVyZW50DQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiAgICAg YmluYXJpZXMgYWx0aG91Z2ggYSBjb21tb24gc291cmNlIGJhc2UuDQo+ID4gPiA+ID4gPiA+ID4g PiA+ID4gPiA+ID4gPg0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gICAtIGV4cG9zZSBh IG5ldyBrZXJuZWwgQUJJIHRvIGFic3RyYWN0IHRoZQ0KPiA+ID4gaHlwZXJjYWxsDQo+ID4gPiA+ ID4gPiA+ID4gPiA+IGRpZmZlcmVuY2VzIGF3YXkNCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4g PiA+ICAgICBpbiB0aGUgZ3Vlc3Qga2VybmVsLiBJbiB0aGlzIGNhc2UgdGhlDQo+ID4gPiB1c2Vy c3BhY2UNCj4gPiA+ID4gPiB3b3VsZA0KPiA+ID4gPiA+ID4gPiA+ID4gPiBlc3NlbnRpYWxseQ0K PiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gICAgIGFzayBmb3IgYW4gYWJzdHJhY3QgIm1h cCBndWVzdCBOIG1lbW9yeSB0bw0KPiA+ID4gPiA+IHVzZXJzcGFjZQ0KPiA+ID4gPiA+ID4gPiA+ IHB0ciINCj4gPiA+ID4gPiA+ID4gPiA+ID4gYW5kIGxldA0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ ID4gPiA+ID4gICAgIHRoZSBrZXJuZWwgZGVhbCB3aXRoIHRoZSBkaWZmZXJlbnQNCj4gaHlwZXJj YWxsDQo+ID4gPiA+ID4gaW50ZXJmYWNlcy4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gVGhpcyBvZg0K PiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gICAgIGNvdXJzZSBhc3N1bWVzIHRoZSBtYWpv cml0eSBvZiBCRSBndWVzdHMNCj4gd291bGQNCj4gPiA+IGJlDQo+ID4gPiA+ID4gTGludXgNCj4g PiA+ID4gPiA+ID4gPiA+ID4ga2VybmVscyBhbmQNCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4g PiA+ICAgICBsZWF2ZXMgdGhlIGJhcmUtbWV0YWwvdW5pa2VybmVsIGFwcHJvYWNoZXMNCj4gdG8N Cj4gPiA+ID4gPiB0aGVpciBvd24NCj4gPiA+ID4gPiA+ID4gPiA+ID4gZGV2aWNlcy4NCj4gPiA+ ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+DQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiBP cGVyYXRpb24NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID09PT09PT09PQ0KPiA+ID4g PiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+IFRo ZSBjb3JlIG9mIHRoZSBvcGVyYXRpb24gb2YgVmlydElPIGlzIGZhaXJseQ0KPiA+ID4gc2ltcGxl Lg0KPiA+ID4gPiA+IE9uY2UNCj4gPiA+ID4gPiA+ID4gPiB0aGUNCj4gPiA+ID4gPiA+ID4gPiA+ ID4gPiA+ID4gPiA+IHZob3N0LXVzZXIgZmVhdHVyZSBuZWdvdGlhdGlvbiBpcyBkb25lIGl0J3Mg YQ0KPiBjYXNlDQo+ID4gPiBvZg0KPiA+ID4gPiA+ID4gPiA+IHJlY2VpdmluZw0KPiA+ID4gPiA+ ID4gPiA+ID4gPiB1cGRhdGUNCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+IGV2ZW50cyBh bmQgcGFyc2luZyB0aGUgcmVzdWx0YW50IHZpcnQgcXVldWUNCj4gZm9yDQo+ID4gPiBkYXRhLg0K PiA+ID4gPiA+IFRoZQ0KPiA+ID4gPiA+ID4gPiA+IHZob3N0LQ0KPiA+ID4gPiA+ID4gPiA+ID4g PiB1c2VyDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiBzcGVjaWZpY2F0aW9uIGhhbmRs ZXMgYSBidW5jaCBvZiBzZXR1cCBiZWZvcmUNCj4gdGhhdA0KPiA+ID4gPiA+IHBvaW50LA0KPiA+ ID4gPiA+ID4gPiA+IG1vc3RseQ0KPiA+ID4gPiA+ID4gPiA+ID4gPiB0bw0KPiA+ID4gPiA+ID4g PiA+ID4gPiA+ID4gPiA+ID4gZGV0YWlsIHdoZXJlIHRoZSB2aXJ0IHF1ZXVlcyBhcmUgc2V0IHVw IEZEJ3MNCj4gZm9yDQo+ID4gPiA+ID4gbWVtb3J5IGFuZA0KPiA+ID4gPiA+ID4gPiA+ID4gPiBl dmVudA0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gY29tbXVuaWNhdGlvbi4gVGhpcyBp cyB3aGVyZSB0aGUgZW52aXNpb25lZA0KPiBzdHViDQo+ID4gPiA+ID4gcHJvY2Vzcw0KPiA+ID4g PiA+ID4gPiA+IHdvdWxkDQo+ID4gPiA+ID4gPiA+ID4gPiA+IGJlDQo+ID4gPiA+ID4gPiA+ID4g PiA+ID4gPiA+ID4gPiByZXNwb25zaWJsZSBmb3IgZ2V0dGluZyB0aGUgZGFlbW9uIHVwIGFuZA0K PiByZWFkeSB0bw0KPiA+ID4gcnVuLg0KPiA+ID4gPiA+IFRoaXMNCj4gPiA+ID4gPiA+ID4gPiBp cw0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gY3VycmVudGx5IGRvbmUgaW5zaWRlIGEg YmlnIFZNTSBsaWtlIFFFTVUgYnV0DQo+IEkNCj4gPiA+ID4gPiBzdXNwZWN0IGENCj4gPiA+ID4g PiA+ID4gPiBtb2Rlcm4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+IGFwcHJvYWNoIHdv dWxkIGJlIHRvIHVzZSB0aGUgcnVzdC12bW0gdmhvc3QNCj4gY3JhdGUuDQo+ID4gPiBJdA0KPiA+ ID4gPiA+IHdvdWxkDQo+ID4gPiA+ID4gPiA+ID4gdGhlbg0KPiA+ID4gPiA+ID4gPiA+ID4gPiBl aXRoZXINCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+IGNvbW11bmljYXRlIHdpdGggdGhl IGtlcm5lbCdzIGFic3RyYWN0ZWQgQUJJDQo+IG9yIGJlDQo+ID4gPiByZS0NCj4gPiA+ID4gPiA+ ID4gPiB0YXJnZXRlZA0KPiA+ID4gPiA+ID4gPiA+ID4gPiBhcyBhDQo+ID4gPiA+ID4gPiA+ID4g PiA+ID4gPiA+ID4gPiBidWlsZCBvcHRpb24gZm9yIHRoZSB2YXJpb3VzIGh5cGVydmlzb3JzLg0K PiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+DQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4g T25lIHRoaW5nIEkgbWVudGlvbmVkIGJlZm9yZSB0byBBbGV4IGlzIHRoYXQgWGVuDQo+ID4gPiBk b2Vzbid0DQo+ID4gPiA+ID4gaGF2ZQ0KPiA+ID4gPiA+ID4gPiA+IFZNTXMNCj4gPiA+ID4gPiA+ ID4gPiA+ID4gdGhlDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gd2F5IHRoZXkgYXJlIHR5 cGljYWxseSBlbnZpc2lvbmVkIGFuZCBkZXNjcmliZWQNCj4gaW4NCj4gPiA+IG90aGVyDQo+ID4g PiA+ID4gPiA+ID4gPiA+IGVudmlyb25tZW50cy4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4g PiBJbnN0ZWFkLCBYZW4gaGFzIElPUkVRIHNlcnZlcnMuIEVhY2ggb2YgdGhlbQ0KPiA+ID4gY29u bmVjdHMNCj4gPiA+ID4gPiA+ID4gPiA+ID4gaW5kZXBlbmRlbnRseSB0bw0KPiA+ID4gPiA+ID4g PiA+ID4gPiA+ID4gPiA+IFhlbiB2aWEgdGhlIElPUkVRIGludGVyZmFjZS4gRS5nLiB0b2RheSBt dWx0aXBsZQ0KPiA+ID4gUUVNVXMNCj4gPiA+ID4gPiBjb3VsZA0KPiA+ID4gPiA+ID4gPiA+IGJl DQo+ID4gPiA+ID4gPiA+ID4gPiA+IHVzZWQgYXMNCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4g PiBlbXVsYXRvcnMgZm9yIGEgc2luZ2xlIFhlbiBWTSwgZWFjaCBvZiB0aGVtDQo+ID4gPiBjb25u ZWN0aW5nDQo+ID4gPiA+ID4gdG8gWGVuDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gaW5k ZXBlbmRlbnRseSB2aWEgdGhlIElPUkVRIGludGVyZmFjZS4NCj4gPiA+ID4gPiA+ID4gPiA+ID4g PiA+ID4gPg0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+IFRoZSBjb21wb25lbnQgcmVzcG9u c2libGUgZm9yIHN0YXJ0aW5nIGEgZGFlbW9uDQo+ID4gPiBhbmQvb3INCj4gPiA+ID4gPiBzZXR0 aW5nDQo+ID4gPiA+ID4gPiA+ID4gdXANCj4gPiA+ID4gPiA+ID4gPiA+ID4gc2hhcmVkDQo+ID4g PiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gaW50ZXJmYWNlcyBpcyB0aGUgdG9vbHN0YWNrOiB0aGUg eGwgY29tbWFuZCBhbmQNCj4gdGhlDQo+ID4gPiA+ID4gPiA+ID4gbGlieGwvbGlieGMNCj4gPiA+ ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiBsaWJyYXJpZXMuDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4g PiA+DQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+IEkgdGhpbmsgdGhhdCBWTSBjb25maWd1cmF0 aW9uIG1hbmFnZW1lbnQgKG9yDQo+ID4gPiBvcmNoZXN0cmF0aW9uDQo+ID4gPiA+ID4gaW4NCj4g PiA+ID4gPiA+ID4gPiA+ID4gU3RhcnRvcw0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiBqYXJn b24/KSBpcyBhIHN1YmplY3QgdG8gZGViYXRlIGluIHBhcmFsbGVsLg0KPiA+ID4gPiA+ID4gPiA+ ID4gPiA+ID4gPiBPdGhlcndpc2UsIGlzIHRoZXJlIGFueSBnb29kIGFzc3VtcHRpb24gdG8gYXZv aWQNCj4gaXQNCj4gPiA+IHJpZ2h0DQo+ID4gPiA+ID4gbm93Pw0KPiA+ID4gPiA+ID4gPiA+ID4g PiA+ID4gPg0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+IE9sZWtzYW5kciBhbmQgb3RoZXJz IEkgQ0NlZCBoYXZlIGJlZW4gd29ya2luZyBvbg0KPiA+ID4gd2F5cw0KPiA+ID4gPiA+IGZvciB0 aGUNCj4gPiA+ID4gPiA+ID4gPiA+ID4gdG9vbHN0YWNrDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4g PiA+ID4gdG8gY3JlYXRlIHZpcnRpbyBiYWNrZW5kcyBhbmQgc2V0dXAgbWVtb3J5DQo+IG1hcHBp bmdzLg0KPiA+ID4gPiA+IFRoZXkNCj4gPiA+ID4gPiA+ID4gPiBtaWdodCBiZQ0KPiA+ID4gPiA+ ID4gPiA+ID4gPiBhYmxlDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gdG8gcHJvdmlkZSBt b3JlIGluZm8gb24gdGhlIHN1YmplY3QuIEkgZG8gdGhpbmsNCj4gd2UNCj4gPiA+IG1pc3MNCj4g PiA+ID4gPiBhIHdheQ0KPiA+ID4gPiA+ID4gPiA+IHRvDQo+ID4gPiA+ID4gPiA+ID4gPiA+IHBy b3ZpZGUNCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiB0aGUgY29uZmlndXJhdGlvbiB0byB0 aGUgYmFja2VuZCBhbmQgYW55dGhpbmcNCj4gZWxzZQ0KPiA+ID4gdGhhdA0KPiA+ID4gPiA+IHRo ZQ0KPiA+ID4gPiA+ID4gPiA+ID4gPiBiYWNrZW5kDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ ID4gbWlnaHQgcmVxdWlyZSB0byBzdGFydCBkb2luZyBpdHMgam9iLg0KPiA+ID4gPiA+ID4gPiA+ ID4gPiA+ID4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+IFllcywgc29tZSB3b3JrIGhhcyBiZWVu IGRvbmUgZm9yIHRoZSB0b29sc3RhY2sgdG8NCj4gaGFuZGxlDQo+ID4gPiA+ID4gVmlydGlvDQo+ ID4gPiA+ID4gPiA+ID4gTU1JTw0KPiA+ID4gPiA+ID4gPiA+ID4gPiBkZXZpY2VzIGluDQo+ID4g PiA+ID4gPiA+ID4gPiA+ID4gPiBnZW5lcmFsIGFuZCBWaXJ0aW8gYmxvY2sgZGV2aWNlcyBpbiBw YXJ0aWN1bGFyLg0KPiBIb3dldmVyLA0KPiA+ID4gaXQNCj4gPiA+ID4gPiBoYXMNCj4gPiA+ID4g PiA+ID4gPiBub3QNCj4gPiA+ID4gPiA+ID4gPiA+ID4gYmVlbiB1cHN0cmVhbmVkIHlldC4NCj4g PiA+ID4gPiA+ID4gPiA+ID4gPiA+IFVwZGF0ZWQgcGF0Y2hlcyBvbiByZXZpZXcgbm93Og0KPiA+ ID4gPiA+ID4gPiA+ID4gPiA+ID4gaHR0cHM6Ly9sb3JlLmtlcm5lbC5vcmcveGVuLWRldmVsLzE2 MjE2MjYzNjEtMjkwNzYtDQo+IDEtDQo+ID4gPiBnaXQtDQo+ID4gPiA+ID4gc2VuZC0NCj4gPiA+ ID4gPiA+ID4gPiBlbWFpbC0NCj4gPiA+ID4gPiA+ID4gPiA+ID4gb2xla3N0eXNoQGdtYWlsLmNv bS8NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+DQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiBUaGVy ZSBpcyBhbiBhZGRpdGlvbmFsIChhbHNvIGltcG9ydGFudCkgYWN0aXZpdHkgdG8NCj4gPiA+ID4g PiBpbXByb3ZlL2ZpeA0KPiA+ID4gPiA+ID4gPiA+ID4gPiBmb3JlaWduIG1lbW9yeSBtYXBwaW5n IG9uIEFybSB3aGljaCBJIGFtIGFsc28gaW52b2x2ZWQNCj4gaW4uDQo+ID4gPiA+ID4gPiA+ID4g PiA+ID4gPiBUaGUgZm9yZWlnbiBtZW1vcnkgbWFwcGluZyBpcyBwcm9wb3NlZCB0byBiZSB1c2Vk DQo+IGZvcg0KPiA+ID4gVmlydGlvDQo+ID4gPiA+ID4gPiA+ID4gYmFja2VuZHMNCj4gPiA+ID4g PiA+ID4gPiA+ID4gKGRldmljZSBlbXVsYXRvcnMpIGlmIHRoZXJlIGlzIGEgbmVlZCB0byBydW4g Z3Vlc3QgT1MNCj4gPiA+IGNvbXBsZXRlbHkNCj4gPiA+ID4gPiA+ID4gPiA+ID4gdW5tb2RpZmll ZC4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+IE9mIGNvdXJzZSwgdGhlIG1vcmUgc2VjdXJlIHdh eSB3b3VsZCBiZSB0byB1c2UgZ3JhbnQNCj4gPiA+IG1lbW9yeQ0KPiA+ID4gPiA+ID4gPiA+IG1h cHBpbmcuDQo+ID4gPiA+ID4gPiA+ID4gPiA+IEJyaWV0bHksIHRoZSBtYWluIGRpZmZlcmVuY2Ug YmV0d2VlbiB0aGVtIGlzIHRoYXQgd2l0aA0KPiA+ID4gZm9yZWlnbg0KPiA+ID4gPiA+IG1hcHBp bmcNCj4gPiA+ID4gPiA+ID4gPiB0aGUNCj4gPiA+ID4gPiA+ID4gPiA+ID4gYmFja2VuZA0KPiA+ ID4gPiA+ID4gPiA+ID4gPiA+ID4gY2FuIG1hcCBhbnkgZ3Vlc3QgbWVtb3J5IGl0IHdhbnRzIHRv IG1hcCwgYnV0IHdpdGgNCj4gZ3JhbnQNCj4gPiA+ID4gPiBtYXBwaW5nDQo+ID4gPiA+ID4gPiA+ ID4gaXQgaXMNCj4gPiA+ID4gPiA+ID4gPiA+ID4gYWxsb3dlZCB0byBtYXAgb25seSB3aGF0IHdh cyBwcmV2aW91c2x5IGdyYW50ZWQgYnkgdGhlDQo+ID4gPiBmcm9udGVuZC4NCj4gPiA+ID4gPiA+ ID4gPiA+ID4gPiA+DQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiBTbywgdGhlcmUgbWlnaHQgYmUg YSBwcm9ibGVtIGlmIHdlIHdhbnQgdG8gcHJlLW1hcA0KPiBzb21lDQo+ID4gPiA+ID4gZ3Vlc3QN Cj4gPiA+ID4gPiA+ID4gPiBtZW1vcnkNCj4gPiA+ID4gPiA+ID4gPiA+ID4gaW4gYWR2YW5jZSBv ciB0byBjYWNoZSBtYXBwaW5ncyBpbiB0aGUgYmFja2VuZCBpbiBvcmRlcg0KPiB0bw0KPiA+ID4g PiA+IGltcHJvdmUNCj4gPiA+ID4gPiA+ID4gPiA+ID4gcGVyZm9ybWFuY2UgKGJlY2F1c2UgdGhl IG1hcHBpbmcvdW5tYXBwaW5nIGd1ZXN0IHBhZ2VzDQo+IGV2ZXJ5DQo+ID4gPiA+ID4gcmVxdWVz dA0KPiA+ID4gPiA+ID4gPiA+ID4gPiByZXF1aXJlcyBhIGxvdCBvZiBiYWNrIGFuZCBmb3J0aCB0 byBYZW4gKyBQMk0gdXBkYXRlcykuDQo+IEluIGENCj4gPiA+ID4gPiBudXRzaGVsbCwNCj4gPiA+ ID4gPiA+ID4gPiA+ID4gY3VycmVudGx5LCBpbiBvcmRlciB0byBtYXAgYSBndWVzdCBwYWdlIGlu dG8gdGhlIGJhY2tlbmQNCj4gPiA+IGFkZHJlc3MNCj4gPiA+ID4gPiBzcGFjZQ0KPiA+ID4gPiA+ ID4gPiA+IHdlDQo+ID4gPiA+ID4gPiA+ID4gPiA+IG5lZWQgdG8gc3RlYWwgYSByZWFsIHBoeXNp Y2FsIHBhZ2UgZnJvbSB0aGUgYmFja2VuZA0KPiBkb21haW4uDQo+ID4gPiBTbywNCj4gPiA+ID4g PiB3aXRoDQo+ID4gPiA+ID4gPiA+ID4gdGhlDQo+ID4gPiA+ID4gPiA+ID4gPiA+IHNhaWQgb3B0 aW1pemF0aW9ucyB3ZSBtaWdodCBlbmQgdXAgd2l0aCBubyBmcmVlIG1lbW9yeQ0KPiBpbg0KPiA+ ID4gdGhlDQo+ID4gPiA+ID4gYmFja2VuZA0KPiA+ID4gPiA+ID4gPiA+ID4gPiBkb21haW4gKHNl ZSBYU0EtMzAwKS4gQW5kIHdoYXQgd2UgdHJ5IHRvIGFjaGlldmUgaXMgdG8NCj4gbm90DQo+ID4g PiB3YXN0ZQ0KPiA+ID4gPiA+IGENCj4gPiA+ID4gPiA+ID4gPiByZWFsDQo+ID4gPiA+ID4gPiA+ ID4gPiA+IGRvbWFpbiBtZW1vcnkgYXQgYWxsIGJ5IHByb3ZpZGluZyBzYWZlIG5vbi1hbGxvY2F0 ZWQteWV0DQo+IChzbw0KPiA+ID4gPiA+IHVudXNlZCkNCj4gPiA+ID4gPiA+ID4gPiA+ID4gYWRk cmVzcyBzcGFjZSBmb3IgdGhlIGZvcmVpZ24gKGFuZCBncmFudCkgcGFnZXMgdG8gYmUNCj4gbWFw cGVkDQo+ID4gPiA+ID4gaW50bywNCj4gPiA+ID4gPiA+ID4gPiB0aGlzDQo+ID4gPiA+ID4gPiA+ ID4gPiA+IGVuYWJsaW5nIHdvcmsgaW1wbGllcyBYZW4gYW5kIExpbnV4IChhbmQgbGlrZWx5IERU Qg0KPiBiaW5kaW5ncykNCj4gPiA+ID4gPiBjaGFuZ2VzLg0KPiA+ID4gPiA+ID4gPiA+ID4gPiBI b3dldmVyLCBhcyBpdCB0dXJuZWQgb3V0LCBmb3IgdGhpcyB0byB3b3JrIGluIGEgcHJvcGVyDQo+ IGFuZA0KPiA+ID4gc2FmZQ0KPiA+ID4gPiA+IHdheQ0KPiA+ID4gPiA+ID4gPiA+IHNvbWUNCj4g PiA+ID4gPiA+ID4gPiA+ID4gcHJlcmVxIHdvcmsgbmVlZHMgdG8gYmUgZG9uZS4NCj4gPiA+ID4g PiA+ID4gPiA+ID4gPiA+IFlvdSBjYW4gZmluZCB0aGUgcmVsYXRlZCBYZW4gZGlzY3Vzc2lvbiBh dDoNCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+IGh0dHBzOi8vbG9yZS5rZXJuZWwub3JnL3hlbi1k ZXZlbC8xNjI3NDg5MTEwLTI1NjMzLQ0KPiAxLQ0KPiA+ID4gZ2l0LQ0KPiA+ID4gPiA+IHNlbmQt DQo+ID4gPiA+ID4gPiA+ID4gZW1haWwtDQo+ID4gPiA+ID4gPiA+ID4gPiA+IG9sZWtzdHlzaEBn bWFpbC5jb20vDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPg0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ ID4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPg0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4g PiA+DQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiBPbmUgcXVlc3Rpb24gaXMgaG93IHRv IGJlc3QgaGFuZGxlDQo+IG5vdGlmaWNhdGlvbg0KPiA+ID4gYW5kDQo+ID4gPiA+ID4ga2lja3Mu DQo+ID4gPiA+ID4gPiA+ID4gVGhlDQo+ID4gPiA+ID4gPiA+ID4gPiA+IGV4aXN0aW5nDQo+ID4g PiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiB2aG9zdC11c2VyIGZyYW1ld29yayB1c2VzIGV2ZW50 ZmQgdG8gc2lnbmFsDQo+IHRoZQ0KPiA+ID4gZGFlbW9uDQo+ID4gPiA+ID4gPiA+ID4gKGFsdGhv dWdoDQo+ID4gPiA+ID4gPiA+ID4gPiA+IFFFTVUNCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4g PiA+IGlzIHF1aXRlIGNhcGFibGUgb2Ygc2ltdWxhdGluZyB0aGVtIHdoZW4geW91DQo+IHVzZQ0K PiA+ID4gVENHKS4NCj4gPiA+ID4gPiBYZW4NCj4gPiA+ID4gPiA+ID4gPiBoYXMNCj4gPiA+ID4g PiA+ID4gPiA+ID4gaXQncyBvd24NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+IElPUkVR IG1lY2hhbmlzbS4gSG93ZXZlciBsYXRlbmN5IGlzIGFuDQo+IGltcG9ydGFudA0KPiA+ID4gPiA+ IGZhY3RvciBhbmQNCj4gPiA+ID4gPiA+ID4gPiA+ID4gaGF2aW5nDQo+ID4gPiA+ID4gPiA+ID4g PiA+ID4gPiA+ID4gPiBldmVudHMgZ28gdGhyb3VnaCB0aGUgc3R1YiB3b3VsZCBhZGQgcXVpdGUg YQ0KPiBsb3QuDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4NCj4gPiA+ID4gPiA+ID4gPiA+ ID4gPiA+ID4gPiBZZWFoIEkgdGhpbmssIHJlZ2FyZGxlc3Mgb2YgYW55dGhpbmcgZWxzZSwgd2UN Cj4gd2FudA0KPiA+ID4gdGhlDQo+ID4gPiA+ID4gPiA+ID4gYmFja2VuZHMgdG8NCj4gPiA+ID4g PiA+ID4gPiA+ID4gPiA+ID4gPiBjb25uZWN0IGRpcmVjdGx5IHRvIHRoZSBYZW4gaHlwZXJ2aXNv ci4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4g SW4gbXkgYXBwcm9hY2gsDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ICBhKSBCRSAtPiBGRTog aW50ZXJydXB0cyB0cmlnZ2VyZWQgYnkgQkUgY2FsbGluZyBhDQo+ID4gPiA+ID4gaHlwZXJ2aXNv cg0KPiA+ID4gPiA+ID4gPiA+ID4gPiBpbnRlcmZhY2UNCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ ID4gICAgICAgICAgICAgICB2aWEgdmlydGlvLXByb3h5DQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4g PiA+ICBiKSBGRSAtPiBCRTogTU1JTyB0byBjb25maWcgcmFpc2VzIGV2ZW50cyAoaW4NCj4gZXZl bnQNCj4gPiA+ID4gPiBjaGFubmVscyksDQo+ID4gPiA+ID4gPiA+ID4gPiA+IHdoaWNoIGlzDQo+ ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ICAgICAgICAgICAgICAgY29udmVydGVkIHRvIGEgY2Fs bGJhY2sgdG8gQkUgdmlhDQo+ID4gPiB2aXJ0aW8tDQo+ID4gPiA+ID4gcHJveHkNCj4gPiA+ID4g PiA+ID4gPiA+ID4gPiA+ID4gICAgICAgICAgICAgICAoWGVuJ3MgZXZlbnQgY2hhbm5lbCBpcyBp bnRlcm5uYWxseQ0KPiA+ID4gPiA+IGltcGxlbWVudGVkIGJ5DQo+ID4gPiA+ID4gPiA+ID4gPiA+ IGludGVycnVwdHMuKQ0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPg0KPiA+ID4gPiA+ID4gPiA+ ID4gPiA+ID4gPiBJIGRvbid0IGtub3cgd2hhdCAiY29ubmVjdCBkaXJlY3RseSIgbWVhbnMgaGVy ZSwNCj4gYnV0DQo+ID4gPiA+ID4gc2VuZGluZw0KPiA+ID4gPiA+ID4gPiA+ID4gPiBpbnRlcnJ1 cHRzDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+IHRvIHRoZSBvcHBvc2l0ZSBzaWRlIHdvdWxk IGJlIGJlc3QgZWZmaWNpZW50Lg0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiBJdnNobWVtLCBJ IHN1cHBvc2UsIHRha2VzIHRoaXMgYXBwcm9hY2ggYnkNCj4gdXRpbGl6aW5nDQo+ID4gPiBQQ0kn cw0KPiA+ID4gPiA+IG1zaS14DQo+ID4gPiA+ID4gPiA+ID4gPiA+IG1lY2hhbmlzbS4NCj4gPiA+ ID4gPiA+ID4gPiA+ID4gPiA+DQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiBBZ3JlZSB0aGF0IE1T SSB3b3VsZCBiZSBtb3JlIGVmZmljaWVudCB0aGFuIFNQSS4uLg0KPiA+ID4gPiA+ID4gPiA+ID4g PiA+ID4gQXQgdGhlIG1vbWVudCwgaW4gb3JkZXIgdG8gbm90aWZ5IHRoZSBmcm9udGVuZCwgdGhl DQo+ID4gPiBiYWNrZW5kDQo+ID4gPiA+ID4gaXNzdWVzDQo+ID4gPiA+ID4gPiA+ID4gYQ0KPiA+ ID4gPiA+ID4gPiA+ID4gPiBzcGVjaWZpYyBkZXZpY2UtbW9kZWwgY2FsbCB0byBxdWVyeSBYZW4g dG8gaW5qZWN0IGENCj4gPiA+ID4gPiBjb3JyZXNwb25kaW5nIFNQSQ0KPiA+ID4gPiA+ID4gPiA+ IHRvDQo+ID4gPiA+ID4gPiA+ID4gPiA+IHRoZSBndWVzdC4NCj4gPiA+ID4gPiA+ID4gPiA+ID4g PiA+DQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPg0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4NCj4g PiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPg0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4g Q291bGQgd2UgY29uc2lkZXIgdGhlIGtlcm5lbCBpbnRlcm5hbGx5DQo+IGNvbnZlcnRpbmcNCj4g PiA+ID4gPiBJT1JFUQ0KPiA+ID4gPiA+ID4gPiA+ID4gPiBtZXNzYWdlcyBmcm9tDQo+ID4gPiA+ ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiB0aGUgWGVuIGh5cGVydmlzb3IgdG8gZXZlbnRmZCBldmVu dHM/IFdvdWxkDQo+IHRoaXMNCj4gPiA+IHNjYWxlDQo+ID4gPiA+ID4gd2l0aA0KPiA+ID4gPiA+ ID4gPiA+ID4gPiBvdGhlciBrZXJuZWwNCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+IGh5 cGVyY2FsbCBpbnRlcmZhY2VzPw0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4NCj4gPiA+ ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+IFNvIGFueSB0aG91Z2h0cyBvbiB3aGF0IGRpcmVjdGlv bnMgYXJlIHdvcnRoDQo+ID4gPiA+ID4gZXhwZXJpbWVudGluZw0KPiA+ID4gPiA+ID4gPiA+IHdp dGg/DQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ ID4gPiBPbmUgb3B0aW9uIHdlIHNob3VsZCBjb25zaWRlciBpcyBmb3IgZWFjaA0KPiBiYWNrZW5k IHRvDQo+ID4gPiA+ID4gY29ubmVjdA0KPiA+ID4gPiA+ID4gPiA+IHRvDQo+ID4gPiA+ID4gPiA+ ID4gPiA+IFhlbiB2aWENCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiB0aGUgSU9SRVEgaW50 ZXJmYWNlLiBXZSBjb3VsZCBnZW5lcmFsaXplIHRoZQ0KPiBJT1JFUQ0KPiA+ID4gPiA+IGludGVy ZmFjZQ0KPiA+ID4gPiA+ID4gPiA+IGFuZA0KPiA+ID4gPiA+ID4gPiA+ID4gPiBtYWtlIGl0DQo+ ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gaHlwZXJ2aXNvciBhZ25vc3RpYy4gVGhlIGludGVy ZmFjZSBpcyByZWFsbHkNCj4gdHJpdmlhbA0KPiA+ID4gYW5kDQo+ID4gPiA+ID4gZWFzeQ0KPiA+ ID4gPiA+ID4gPiA+IHRvDQo+ID4gPiA+ID4gPiA+ID4gPiA+IGFkZC4NCj4gPiA+ID4gPiA+ID4g PiA+ID4gPiA+ID4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gQXMgSSBzYWlkIGFib3ZlLCBt eSBwcm9wb3NhbCBkb2VzIHRoZSBzYW1lIHRoaW5nDQo+IHRoYXQNCj4gPiA+IHlvdQ0KPiA+ID4g PiA+ID4gPiA+IG1lbnRpb25lZA0KPiA+ID4gPiA+ID4gPiA+ID4gPiBoZXJlIDopDQo+ID4gPiA+ ID4gPiA+ID4gPiA+ID4gPiA+IFRoZSBkaWZmZXJlbmNlIGlzIHRoYXQgSSBkbyBjYWxsIGh5cGVy dmlzb3INCj4gaW50ZXJmYWNlcw0KPiA+ID4gdmlhDQo+ID4gPiA+ID4gPiA+ID4gdmlydGlvLQ0K PiA+ID4gPiA+ID4gPiA+ID4gPiBwcm94eS4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4NCj4g PiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiBUaGUgb25seSBYZW4tc3BlY2lmaWMgcGFydCBpcyB0 aGUgbm90aWZpY2F0aW9uDQo+ID4gPiBtZWNoYW5pc20sDQo+ID4gPiA+ID4gPiA+ID4gd2hpY2gg aXMNCj4gPiA+ID4gPiA+ID4gPiA+ID4gYW4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiBl dmVudCBjaGFubmVsLiBJZiB3ZSByZXBsYWNlZCB0aGUgZXZlbnQgY2hhbm5lbA0KPiB3aXRoDQo+ ID4gPiA+ID4gc29tZXRoaW5nDQo+ID4gPiA+ID4gPiA+ID4gPiA+IGVsc2UgdGhlDQo+ID4gPiA+ ID4gPiA+ID4gPiA+ID4gPiA+ID4gaW50ZXJmYWNlIHdvdWxkIGJlIGdlbmVyaWMuIFNlZToNCj4g PiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiBodHRwczovL2dpdGxhYi5jb20veGVuLXByb2plY3Qv eGVuLy0NCj4gPiA+ID4gPiA+ID4gPiA+ID4gL2Jsb2Ivc3RhZ2luZy94ZW4vaW5jbHVkZS9wdWJs aWMvaHZtL2lvcmVxLmgjTDUyDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4NCj4gPiA+ID4g PiA+ID4gPiA+ID4gPiA+ID4gPiBJIGRvbid0IHRoaW5rIHRoYXQgdHJhbnNsYXRpbmcgSU9SRVFz IHRvIGV2ZW50ZmQNCj4gaW4NCj4gPiA+IHRoZQ0KPiA+ID4gPiA+IGtlcm5lbA0KPiA+ID4gPiA+ ID4gPiA+IGlzDQo+ID4gPiA+ID4gPiA+ID4gPiA+IGENCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ ID4gPiBnb29kIGlkZWE6IGlmIGZlZWxzIGxpa2UgaXQgd291bGQgYmUgZXh0cmENCj4gPiA+IGNv bXBsZXhpdHkNCj4gPiA+ID4gPiBhbmQgdGhhdA0KPiA+ID4gPiA+ID4gPiA+IHRoZQ0KPiA+ID4g PiA+ID4gPiA+ID4gPiA+ID4gPiA+IGtlcm5lbCBzaG91bGRuJ3QgYmUgaW52b2x2ZWQgYXMgdGhp cyBpcyBhDQo+IGJhY2tlbmQtDQo+ID4gPiA+ID4gaHlwZXJ2aXNvcg0KPiA+ID4gPiA+ID4gPiA+ ID4gPiBpbnRlcmZhY2UuDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+DQo+ID4gPiA+ID4gPiA+ ID4gPiA+ID4gPiA+IEdpdmVuIHRoYXQgd2UgbWF5IHdhbnQgdG8gaW1wbGVtZW50IEJFIGFzIGEg YmFyZS0NCj4gbWV0YWwNCj4gPiA+ID4gPiA+ID4gPiBhcHBsaWNhdGlvbg0KPiA+ID4gPiA+ID4g PiA+ID4gPiA+ID4gPiBhcyBJIGRpZCBvbiBaZXBoeXIsIEkgZG9uJ3QgdGhpbmsgdGhhdCB0aGUN Cj4gdHJhbnNsYXRpb24NCj4gPiA+ID4gPiB3b3VsZCBub3QNCj4gPiA+ID4gPiA+ID4gPiBiZQ0K PiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiBhIGJpZyBpc3N1ZSwgZXNwZWNpYWxseSBvbiBSVE9T J3MuDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+IEl0IHdpbGwgYmUgc29tZSBraW5kIG9mIGFi c3RyYWN0aW9uIGxheWVyIG9mDQo+IGludGVycnVwdA0KPiA+ID4gPiA+IGhhbmRsaW5nDQo+ID4g PiA+ID4gPiA+ID4gPiA+ID4gPiA+IChvciBub3RoaW5nIGJ1dCBhIGNhbGxiYWNrIG1lY2hhbmlz bSkuDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+DQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ ID4gQWxzbywgZXZlbnRmZCBpcyB2ZXJ5IExpbnV4LWNlbnRyaWMgYW5kIHdlIGFyZQ0KPiA+ID4g dHJ5aW5nIHRvDQo+ID4gPiA+ID4gPiA+ID4gZGVzaWduIGFuDQo+ID4gPiA+ID4gPiA+ID4gPiA+ ID4gPiA+ID4gaW50ZXJmYWNlIHRoYXQgY291bGQgd29yayB3ZWxsIGZvciBSVE9TZXMgdG9vLg0K PiBJZiB3ZQ0KPiA+ID4gPiA+IHdhbnQgdG8NCj4gPiA+ID4gPiA+ID4gPiBkbw0KPiA+ID4gPiA+ ID4gPiA+ID4gPiA+ID4gPiA+IHNvbWV0aGluZyBkaWZmZXJlbnQsIGJvdGggT1MtYWdub3N0aWMg YW5kDQo+ID4gPiBoeXBlcnZpc29yLQ0KPiA+ID4gPiA+IGFnbm9zdGljLA0KPiA+ID4gPiA+ID4g PiA+ID4gPiBwZXJoYXBzDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gd2UgY291bGQgZGVz aWduIGEgbmV3IGludGVyZmFjZS4gT25lIHRoYXQgY291bGQNCj4gYmUNCj4gPiA+ID4gPiA+ID4g PiBpbXBsZW1lbnRhYmxlDQo+ID4gPiA+ID4gPiA+ID4gPiA+IGluIHRoZQ0KPiA+ID4gPiA+ID4g PiA+ID4gPiA+ID4gPiA+IFhlbiBoeXBlcnZpc29yIGl0c2VsZiAobGlrZSBJT1JFUSkgYW5kIG9m IGNvdXJzZQ0KPiBhbnkNCj4gPiA+ID4gPiBvdGhlcg0KPiA+ID4gPiA+ID4gPiA+ID4gPiBoeXBl cnZpc29yDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gdG9vLg0KPiA+ID4gPiA+ID4gPiA+ ID4gPiA+ID4gPiA+DQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4NCj4gPiA+ID4gPiA+ID4g PiA+ID4gPiA+ID4gPiBUaGVyZSBpcyBhbHNvIGFub3RoZXIgcHJvYmxlbS4gSU9SRVEgaXMgcHJv YmFibHkNCj4gbm90DQo+ID4gPiBiZQ0KPiA+ID4gPiA+IHRoZQ0KPiA+ID4gPiA+ID4gPiA+IG9u bHkNCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiBpbnRlcmZhY2UgbmVlZGVkLiBIYXZlIGEg bG9vayBhdA0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+IGh0dHBzOi8vbWFyYy5pbmZvLz9s PXhlbi0NCj4gZGV2ZWwmbT0xNjIzNzM3NTQ3MDUyMzMmdz0yLg0KPiA+ID4gPiA+IERvbid0IHdl DQo+ID4gPiA+ID4gPiA+ID4gPiA+IGFsc28gbmVlZA0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4g PiA+IGFuIGludGVyZmFjZSBmb3IgdGhlIGJhY2tlbmQgdG8gaW5qZWN0DQo+IGludGVycnVwdHMN Cj4gPiA+IGludG8NCj4gPiA+ID4gPiB0aGUNCj4gPiA+ID4gPiA+ID4gPiA+ID4gZnJvbnRlbmQ/ IEFuZA0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+IGlmIHRoZSBiYWNrZW5kIHJlcXVpcmVz IGR5bmFtaWMgbWVtb3J5IG1hcHBpbmdzDQo+IG9mDQo+ID4gPiA+ID4gZnJvbnRlbmQNCj4gPiA+ ID4gPiA+ID4gPiBwYWdlcywNCj4gPiA+ID4gPiA+ID4gPiA+ID4gdGhlbg0KPiA+ID4gPiA+ID4g PiA+ID4gPiA+ID4gPiA+IHdlIHdvdWxkIGFsc28gbmVlZCBhbiBpbnRlcmZhY2UgdG8gbWFwL3Vu bWFwDQo+IGRvbVUNCj4gPiA+IHBhZ2VzLg0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPg0KPiA+ ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiBNeSBwcm9wb3NhbCBkb2N1bWVudCBtaWdodCBoZWxwIGhl cmU7IEFsbCB0aGUNCj4gPiA+IGludGVyZmFjZXMNCj4gPiA+ID4gPiA+ID4gPiByZXF1aXJlZA0K PiA+ID4gPiA+ID4gPiA+ID4gPiBmb3INCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gdmlydGlv LXByb3h5IChvciBoeXBlcnZpc29yLXJlbGF0ZWQgaW50ZXJmYWNlcykNCj4gYXJlDQo+ID4gPiBs aXN0ZWQNCj4gPiA+ID4gPiBhcw0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiBSUEMgcHJvdG9j b2xzIDopDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+DQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4g PiA+ID4gVGhlc2UgaW50ZXJmYWNlcyBhcmUgYSBsb3QgbW9yZSBwcm9ibGVtYXRpYyB0aGFuDQo+ ID4gPiBJT1JFUToNCj4gPiA+ID4gPiBJT1JFUQ0KPiA+ID4gPiA+ID4gPiA+IGlzDQo+ID4gPiA+ ID4gPiA+ID4gPiA+IHRpbnkNCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiBhbmQgc2VsZi1j b250YWluZWQuIEl0IGlzIGVhc3kgdG8gYWRkIGFueXdoZXJlLg0KPiBBDQo+ID4gPiBuZXcNCj4g PiA+ID4gPiA+ID4gPiBpbnRlcmZhY2UgdG8NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiBp bmplY3QgaW50ZXJydXB0cyBvciBtYXAgcGFnZXMgaXMgbW9yZSBkaWZmaWN1bHQNCj4gdG8NCj4g PiA+ID4gPiBtYW5hZ2UNCj4gPiA+ID4gPiA+ID4gPiBiZWNhdXNlDQo+ID4gPiA+ID4gPiA+ID4g PiA+IGl0DQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gd291bGQgcmVxdWlyZSBjaGFuZ2Vz IHNjYXR0ZXJlZCBhY3Jvc3MgdGhlDQo+IHZhcmlvdXMNCj4gPiA+ID4gPiBlbXVsYXRvcnMuDQo+ ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+DQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+IEV4YWN0 bHkuIEkgaGF2ZSBubyBjb25maWRlbnQgeWV0IHRoYXQgbXkgYXBwcm9hY2gNCj4gd2lsbA0KPiA+ ID4gPiA+IGFsc28NCj4gPiA+ID4gPiA+ID4gPiBhcHBseQ0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ ID4gPiB0byBvdGhlciBoeXBlcnZpc29ycyB0aGFuIFhlbi4NCj4gPiA+ID4gPiA+ID4gPiA+ID4g PiA+ID4gVGVjaG5pY2FsbHksIHllcywgYnV0IHdoZXRoZXIgcGVvcGxlIGNhbiBhY2NlcHQgaXQN Cj4gb3INCj4gPiA+IG5vdA0KPiA+ID4gPiA+IGlzIGENCj4gPiA+ID4gPiA+ID4gPiA+ID4gZGlm ZmVyZW50DQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+IG1hdHRlci4NCj4gPiA+ID4gPiA+ID4g PiA+ID4gPiA+ID4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gVGhhbmtzLA0KPiA+ID4gPiA+ ID4gPiA+ID4gPiA+ID4gPiAtVGFrYWhpcm8gQWthc2hpDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4g Pg0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+DQo+ID4g PiA+ID4gPiA+ID4gPiA+ID4gPiAtLQ0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gUmVnYXJkcywN Cj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+DQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiBPbGVrc2Fu ZHIgVHlzaGNoZW5rbw0KDQo= From xen-devel-bounces@lists.xenproject.org Thu Sep 02 01:33:47 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 01:33:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.176777.321713 (Exim 4.92) (envelope-from ) id 1mLbbr-0006Oy-MU; Thu, 02 Sep 2021 01:33:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 176777.321713; Thu, 02 Sep 2021 01:33:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLbbr-0006Or-Hp; Thu, 02 Sep 2021 01:33:43 +0000 Received: by outflank-mailman (input) for mailman id 176777; Thu, 02 Sep 2021 01:33:42 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLbbq-0006Oh-DQ; Thu, 02 Sep 2021 01:33:42 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLbbq-0008J5-9X; Thu, 02 Sep 2021 01:33:42 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLbbp-0008A7-TL; Thu, 02 Sep 2021 01:33:42 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mLbbp-0004nd-Sp; Thu, 02 Sep 2021 01:33:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=qsEPoFgN8+i4iFXQU0KZjS9JdrEJXiSkpTu5VLLbcsA=; b=x/57GB9eEhXdqdsV0sxl379Lf1 /ZL0ZKQi5hrqNBmUFLVyk7R2lQiChkBnbnVO+KDyxsg8QYE7ElxOFp3Dd3DkHedvkzxNriTzoJan3 PNMnb4SvdahWgc7QJzoNwPCNHKzUNcDaJXC0swQ1Yqq5tFVCG3amrPJeOJ0JPKNT/n/c=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 164733: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=12e33dca4c0612a0975265e5ba641c6261a26455 X-Osstest-Versions-That: ovmf=cae735f61328d64e2e8991036707b9e78c0f5f63 From: osstest service owner Date: Thu, 02 Sep 2021 01:33:41 +0000 flight 164733 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/164733/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 164674 build-amd64-xsm 6 xen-build fail REGR. vs. 164674 build-i386-xsm 6 xen-build fail REGR. vs. 164674 build-i386 6 xen-build fail REGR. vs. 164674 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 12e33dca4c0612a0975265e5ba641c6261a26455 baseline version: ovmf cae735f61328d64e2e8991036707b9e78c0f5f63 Last test of basis 164674 2021-08-31 02:56:52 Z 1 days Failing since 164686 2021-09-01 03:03:43 Z 0 days 6 attempts Testing same since 164718 2021-09-01 16:40:02 Z 0 days 3 attempts ------------------------------------------------------------ People who touched revisions under test: Anthony PERARD DunTan Gary Lin Jim Fehlig Lin, Gary (HPS OE-Linux) Loo Tung Lun Loo, Tung Lun Mark Wilson Marvin H?user Wenxing Hou jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit 12e33dca4c0612a0975265e5ba641c6261a26455 Author: Loo, Tung Lun Date: Tue Aug 17 15:43:12 2021 +0800 IntelFsp2Pkg: Support Config File and Binary delta comparison BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3567 This patch is to enable config editor to have a new feature that can spell out the delta between the default configuration files' data, such as YAML and BSF, against the data stored in the binary. This can help users understand and track the difference when modifications are made. Cc: Maurice Ma Cc: Nate DeSimone Cc: Star Zeng Cc: Chasel Chiu Signed-off-by: Loo Tung Lun Reviewed-by: Chasel Chiu commit b170806518c1e414939c8b085866544814e1ce8e Author: Mark Wilson Date: Fri Nov 13 08:05:18 2020 +0800 UefiCpuPkg: Clean up save state boundary checks and comments. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2956 In functions ReadSaveStateRegisterByIndex and WriteSaveStateRegister: * check width > 4 instead of >= 4 when writing upper 32 bytes. - This improves the code but will not affect functionality. Cc: Eric Dong Reviewed-by: Ray Ni Signed-off-by: Mark Wilson commit 3b3f88228812e2c642eea8746858a4dad928ebf7 Author: Marvin H?user Date: Mon Aug 9 14:09:25 2021 +0800 MdeModulePkg/PiSmmCore: Drop deprecated image profiling commands The legacy codebase allowed SMM images to be registered for profiling from DXE. Support for this has been dropped entirely, so remove the remaining handlers. Cc: Jian J Wang Cc: Hao A Wu Cc: Eric Dong Reviewed-by: Ray Ni Cc: Vitaly Cheptsov Signed-off-by: Marvin H?user commit cdda3f74a1327663a5d48cca13507085ba403af7 Author: Marvin H?user Date: Mon Aug 9 03:39:53 2021 +0800 UefiPayloadPkg/UefiPayloadEntry: Fix memory corruption UefiPayloadEntry's AllocatePool() applies the "sizeof" operator to HOB index rather than the HOB header structure. This yields 4 Bytes compared to the 8 Bytes the structure header requires. Fix the call to allocate the required space instead. Reviewed-by: Guo Dong Reviewed-by: Ray Ni Cc: Maurice Ma Cc: Benjamin You Cc: Vitaly Cheptsov Signed-off-by: Marvin H?user commit 5d34cc49d5d348012fe8acf9fb618826bd541a7c Author: Wenxing Hou Date: Tue Aug 24 16:11:11 2021 +0800 UefiCpuPkg/PiSmmCpuDxeSmm: Update mPatchCetSupported set condition REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3584 Function AsmCpuid should first check the value for Basic CPUID Information. The fix is to update the mPatchCetSupported judgment statement. Signed-off-by: Wenxing Hou Reviewed-by: Ray Ni Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Cc: Sheng W Cc: Yao Jiewen commit f0fe55bca4651734abf1752a1d7c69fb5bee00b9 Author: duntan Date: Fri Aug 20 13:04:29 2021 +0800 UefiPayloadPkg: Fix the build error when enable Core ci for UefiPayloadPkg V1: Add quotes when using $(ARCH) in .dsc and .fdf file. The quotes are added due to the way by which Core ci parse the .dsc file. Add UINTN in Hob.c to fix cast from pointer to integer of different size error. V2: Delete lines which reference ShellBinPkg.The pkg doesn't exist in edk2. Cc: Guo Dong Cc: Ray Ni Cc: Maurice Ma Cc: Benjamin You Signed-off-by: DunTan Reviewed-by: Ray Ni commit 9f3eda177a4b2d4a33ff1b0307cad42906396562 Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:29:48 2021 +0800 OvmfPkg/OvmfXen: add QemuKernelLoaderFsDxe Without QemuKernelLoaderFsDxe, QemuLoadKernelImage() couldn't download the kernel, initrd, and kernel command line from QEMU's fw_cfg. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3574 Signed-off-by: Gary Lin Acked-by: Anthony PERARD Reviewed-by: Philippe Mathieu-Daude Reviewed-by: Gerd Hoffmann Tested-by: Jim Fehlig commit 5b5f10d7465004e3e40ec1f50a3b490b4db595e7 Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:31:15 2021 +0800 OvmfPkg/SmmControl2Dxe: use PcdAcpiS3Enable to detect S3 support To avoid the potential inconsistency between PcdAcpiS3Enable and QemuFwCfgS3Enabled(), this commit modifies SmmControl2Dxe to detect S3 support by PcdAcpiS3Enable as modules in MdeModulePkg do. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3573 Signed-off-by: Gary Lin Reviewed-by: Gerd Hoffmann Reviewed-by: Jiewen Yao Tested-by: Jim Fehlig commit 52e2dabc0f8d3af09c213072ce8ba734302f585d Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:31:14 2021 +0800 OvmfPkg/PlatformBootManagerLib: use PcdAcpiS3Enable to detect S3 support To avoid the potential inconsistency between PcdAcpiS3Enable and QemuFwCfgS3Enabled(), this commit modifies PlatformBootManagerLib to detect S3 support by PcdAcpiS3Enable as modules in MdeModulePkg do. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3573 Signed-off-by: Gary Lin Reviewed-by: Gerd Hoffmann Reviewed-by: Jiewen Yao Tested-by: Jim Fehlig commit 28152333bccb778b62e6e97446b28bfa0e92ef82 Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:31:13 2021 +0800 OvmfPkg/LockBoxLib: use PcdAcpiS3Enable to detect S3 support To avoid the potential inconsistency between PcdAcpiS3Enable and QemuFwCfgS3Enabled(), this commit modifies LockBoxLib to detect S3 support by PcdAcpiS3Enable as modules in MdeModulePkg do. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3573 Signed-off-by: Gary Lin Reviewed-by: Philippe Mathieu-Daude Reviewed-by: Gerd Hoffmann Reviewed-by: Jiewen Yao Tested-by: Jim Fehlig commit cb0d24637dfdd869618b9635dfb8e3b0746393a6 Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:31:12 2021 +0800 OvmfPkg/OvmfXen: set PcdAcpiS3Enable at initialization There are several functions in OvmfPkg/Library using QemuFwCfgS3Enabled() to detect the S3 support status. However, in MdeModulePkg, PcdAcpiS3Enable is used to check S3 support. Since InitializeXenPlatform() didn't set PcdAcpiS3Enable as InitializePlatform() did, this made the inconsistency between drivers/functions. For example, S3SaveStateDxe checked PcdAcpiS3Enable and skipped S3BootScript because the default value is FALSE. On the other hand, PlatformBootManagerBeforeConsole() from OvmfPkg/Library called QemuFwCfgS3Enabled() and found it returned TRUE, so it invoked SaveS3BootScript(). However, S3SaveStateDxe skipped S3BootScript, so SaveS3BootScript() asserted due to EFI_NOT_FOUND. This issue mainly affects "HVM Direct Kernel Boot". When used, "fw_cfg" is enabled in QEMU and QemuFwCfgS3Enabled() returns true in that case. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3573 Signed-off-by: Gary Lin Reviewed-by: Anthony PERARD Reviewed-by: Gerd Hoffmann Reviewed-by: Jiewen Yao Tested-by: Jim Fehlig From xen-devel-bounces@lists.xenproject.org Thu Sep 02 01:51:38 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 01:51:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.176786.321732 (Exim 4.92) (envelope-from ) id 1mLbt7-0000mf-5S; Thu, 02 Sep 2021 01:51:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 176786.321732; Thu, 02 Sep 2021 01:51:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLbt7-0000mY-1l; Thu, 02 Sep 2021 01:51:33 +0000 Received: by outflank-mailman (input) for mailman id 176786; Thu, 02 Sep 2021 01:51:31 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLbt5-0000mS-5k for xen-devel@lists.xen.org; Thu, 02 Sep 2021 01:51:31 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (unknown [40.107.6.87]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 46f9b54e-0b90-11ec-ae34-12813bfff9fa; Thu, 02 Sep 2021 01:51:24 +0000 (UTC) Received: from DB8PR06CA0065.eurprd06.prod.outlook.com (2603:10a6:10:120::39) by AM6PR08MB3430.eurprd08.prod.outlook.com (2603:10a6:20b:43::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.23; Thu, 2 Sep 2021 01:51:21 +0000 Received: from DB5EUR03FT024.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:120:cafe::d4) by DB8PR06CA0065.outlook.office365.com (2603:10a6:10:120::39) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.17 via Frontend Transport; Thu, 2 Sep 2021 01:51:21 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT024.mail.protection.outlook.com (10.152.20.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Thu, 2 Sep 2021 01:51:20 +0000 Received: ("Tessian outbound 56612e04f172:v103"); Thu, 02 Sep 2021 01:51:20 +0000 Received: from c4cfdaf40bab.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 8D5327BB-6238-4626-A4E2-77B47D878D02.1; Thu, 02 Sep 2021 01:51:19 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id c4cfdaf40bab.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 02 Sep 2021 01:51:19 +0000 Received: from DB9PR08MB6857.eurprd08.prod.outlook.com (2603:10a6:10:2a2::7) by DBBPR08MB4886.eurprd08.prod.outlook.com (2603:10a6:10:f4::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.23; Thu, 2 Sep 2021 01:50:50 +0000 Received: from DB9PR08MB6857.eurprd08.prod.outlook.com ([fe80::2c28:50cf:49fd:da32]) by DB9PR08MB6857.eurprd08.prod.outlook.com ([fe80::2c28:50cf:49fd:da32%7]) with mapi id 15.20.4457.026; Thu, 2 Sep 2021 01:50:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 46f9b54e-0b90-11ec-ae34-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=67jr1OBRC0o1ayuQ1as8Gfa0TcOJljslrUMNhB8dyuw=; b=yeq4pwiYliZmoYmNVQEtijnvgsGSPvTbvzkLDHC+++SskgSCEHW2UVGJXquubZ71M5QZXTVsO8GyHvShuj4rtNYlk1KyUbXBbhGyXugAF5uk06lqMP9FCmoGeikkPr0iGPZnO8SJR5ckuW22hyRe0WkGS41reBY+7IbPLjtxy/8= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; lists.xen.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;lists.xen.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eXwtsRSyGfTEDiDlnjAJxjNNuHTuhptzq8ORA2BpAisR9jQg0ZehjmlvZVRoUXllkFPem7dI34gkAK+QKtAJIGgVk5IlCfRkQxH1NnvyqX1kYGnFgr3n6/OorMtxDmArwNVAwTXIDPoJo0an8VLdmx0YA8/tVjR31M1s9fG3JtugMqvtvfPGjaeyOEpun7xDD5DSEqwMXNunM23oftVmyYNMtwN26kY+ZFFPN+b2FAWmar6WVy0LK2fJoptp7SJJuQMxS9V46z9ixmno8bvxckmDAi6kt9Po7IoN+MSfZneZIJRvR58MRAuDNt1V3g0BMHWh84E6lY/TrpmfpXIhhw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=67jr1OBRC0o1ayuQ1as8Gfa0TcOJljslrUMNhB8dyuw=; b=ci9Q5NWjne4CtEavERpV0i33Uh+Ikx+MxmnXR4XEaKBt5f1J6sGzOaFNA73tJTKa1CWzoHalTfco3+9FLj67jWVOKlca3d2AH3ssjwVenE89PrwFJnfgjRF92p0UlqlwIs0bDgpMznFk6MboEmO3xyHzrVtGydzo+A6yBGi0hQJLeueb0JqKM/B+n61zEf6qpvEX/1wDZH0eaQpFyC+dOfyzieWbqTY/BpNfxJo6oYV+fT+xTRlxfvNJr37dyFeoM0en+GsyQJ56NoVdNyaScCEyv90Mln6odS4FXK/1RMez94AxK+wvzilKVt75Qd+2ZJyc6Em+3T+xq6a48sNZng== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=67jr1OBRC0o1ayuQ1as8Gfa0TcOJljslrUMNhB8dyuw=; b=yeq4pwiYliZmoYmNVQEtijnvgsGSPvTbvzkLDHC+++SskgSCEHW2UVGJXquubZ71M5QZXTVsO8GyHvShuj4rtNYlk1KyUbXBbhGyXugAF5uk06lqMP9FCmoGeikkPr0iGPZnO8SJR5ckuW22hyRe0WkGS41reBY+7IbPLjtxy/8= From: Wei Chen To: Wei Chen , AKASHI Takahiro CC: Oleksandr Tyshchenko , Stefano Stabellini , Alex Benn??e , Kaly Xin , Stratos Mailing List , "virtio-dev@lists.oasis-open.org" , Arnd Bergmann , Viresh Kumar , Stefano Stabellini , "stefanha@redhat.com" , Jan Kiszka , Carl van Schaik , "pratikp@quicinc.com" , Srivatsa Vaddagiri , Jean-Philippe Brucker , Mathieu Poirier , Oleksandr Tyshchenko , Bertrand Marquis , Artem Mygaiev , Julien Grall , Juergen Gross , Paul Durrant , nd , Xen Devel Subject: RE: Enabling hypervisor agnosticism for VirtIO backends Thread-Topic: Enabling hypervisor agnosticism for VirtIO backends Thread-Index: AQHXiWXOlXnRp9GT30mY/CfP5cid16tt4TUAgAVQpQCAAsKLQIABdsmAgAADLTCAAWVyAIAAMB+ggAMGMQCACZ/8gIAAKWUQgAd5oYCAAeKfwIAAF2QAgADY4nCAAAatsA== Date: Thu, 2 Sep 2021 01:50:49 +0000 Message-ID: References: <20210817080757.GC43203@laputa> <20210818053840.GE39588@laputa> <20210820064150.GC13452@laputa> <20210826094047.GA55218@laputa> <20210831061805.GB69817@laputa> <20210901122910.GA100270@laputa> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: EF3DCAE37B0AA847B2A4DC19FCA89E88.0 x-checkrecipientchecked: true Authentication-Results-Original: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: 8e4df78d-ec5c-4f87-74b9-08d96db42991 x-ms-traffictypediagnostic: DBBPR08MB4886:|AM6PR08MB3430: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:8882;OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: GWrzqVot/KvGSsKO8j6OVdjTTvxiuNDausV2e1r8elS5+yl/R/uVMC2OLlqx72RoIUL0JTt+XydrQRmQRo811RhwG0RFMAkDvSQcHJon05j18BwKo5vsis3Q1ZIdviyZu0m7FOxbbr4XtGKdhtMRzQmpJOwDC4TQHYLcd7R51ca5CTaRJKKRashInEU2lTrsq7mLce4exo2edmlU/wmJ0ySqYmARWvWFGYC/3gPneM0X084wAIfKkjY+3N4awuWFn8O6lEctu66YAZgGcFqt1klezKGgb3FwmxkBGj+6inZ1cCK0MW5qpOTyxDM4zvdbsVtENeMIzXAc/TF8yap0nNuZVcpRVpqIKytaZR96uRfDEL6SlYP31LeBPgr5T7bXnGoOKef673yS9VzoYF7Dt74s4pTfRYxxT1LUNkiXBHLY9kxyWA4jq4nUwHNrx13qTAhYbkRH7ZvLCWAwIg3k59WathRHHLElFtx+gsr+GorMsVrMsIhkvH4Wh1gvSJolPTDtrQxgmGEm6bp2+7jZTSiBG+E6FUNaZu9q5bkBRsOeYxa/1VQQP1zgwWFzPb9/5ABU2ZAFez7vmspcClmWnvK+qh+qEHHV6wza1yX9g7lBSNjh3DKeqtDx4+go3U/Z7ydeX9W2H9OR28SMw+uQbtINzsioi2JN68uN45ZMJ2ZBx8G4W3ytxdiMJycfC0xOlaBAr61BqW9NANVx0aou3itKUzKGX8xlQEWXAsP0Yy/7oau+nP3gffxczwLZAj1pNnvqQDHBClJeHqNBGeuS/ZqumNWLsPU+C84GmhrliqeOU1Zi4JrJ8sz9d+8W4JHtFhP4BVFSrHXWCNKiSIGy3Q== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB9PR08MB6857.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(136003)(366004)(396003)(346002)(39860400002)(86362001)(38070700005)(30864003)(8936002)(8676002)(2906002)(110136005)(64756008)(66446008)(66556008)(54906003)(316002)(5660300002)(7696005)(122000001)(2940100002)(83380400001)(9686003)(966005)(55016002)(66574015)(38100700002)(478600001)(4326008)(71200400001)(186003)(6506007)(53546011)(26005)(33656002)(76116006)(66476007)(66946007)(7416002)(52536014)(559001)(579004);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?SVg1OFRSTWhPOTErRk9Wb1ZnU2lKR0JzUm40MEU4czF3SVZKL29sSkVnaHQy?= =?utf-8?B?K2ZjcUlJWFoxZnFrTEM5MktjNGRnVXBMU2hpMER0MFZYUjBFLzBZcW42VEw5?= =?utf-8?B?eUtjTkFOV24waXNOd1JCNW9Wa3VMM3ZLNmZBMlB6Q3lpc1dtNEwvUXAwVzBW?= =?utf-8?B?ZUZnVlZ3cUx3RlZ4Z08yTEcyVEFUN0czWU9jYkVJbnp2VHk2eXhuYldKWkFo?= =?utf-8?B?Rm9SMU01VnkwZ3BIK2hBemtRMlpSUDVxU1JYeXd0K1RVdHF4aGR4cGVxRG03?= =?utf-8?B?LzIwSjVEeDZwQUdUSTA0MnNpS0x2UVFEVUd3Z2VlQmtMTlA4cGJJblZncW9t?= =?utf-8?B?Nm02VWswU3RHZVQ4ODlxM0FCSmk1cjE4dTFHUEltNTRVaytzUEFxRkdZNG15?= =?utf-8?B?Yk5mTmVEUUdEdW1tWEJIZ3liY29vMUo3S2tjdnoxRDdhbFdXTCswQVoyY2wx?= =?utf-8?B?TFFFUCtnTFF0QjdNMENhUy9kbVFGOFZmQzNQZW9zZWlNdEtqbjhLWEVoN0Zn?= =?utf-8?B?ak5YM0YxdHhXSFdOOFNpYzFtYnhlcnQzY3V1YjVwZ203THZvZGpsWHBCei91?= =?utf-8?B?SW1Oa0RmSStFN25Vd0cycW1UcTFYTmFSL3FOWEJCSE5hS1JKYitkS1NjU2wy?= =?utf-8?B?ZlBNZ3ZuaDFxbXNMVEQrVGFmNWl3NHNwS1pDaUFiVWRhczRpNHZ4cXdjSkdF?= =?utf-8?B?YVdlTmN0YjZiOHdpdDkvU1JuRUhKOHphclI5QjF4OXMwUkN5L1QySG8vbUxU?= =?utf-8?B?elBHc2wzbUF2dzVvQS85K0JyMFNUVmFlR2I2Z0R1Mi8zSy9JTk0wZHFWQ3Rr?= =?utf-8?B?UGNpdVUrTkloVis5cld0Wm5GWDlaSnZYa3czamxFNHAyVHVuQk5hdThKazZX?= =?utf-8?B?VHROQUpaRkJPQnZNcUtRQnRGSUkxWGVJNE9BY3V5cWZzeWlidEFlQ20xQnpN?= =?utf-8?B?WldXcnFWU2JNZUxVWDBrYlJ5YVdWWVZGMFBjdXJhMC9FYzZFbUlkMFJsUTZx?= =?utf-8?B?aXJ5Yk9WUGc0eTM2Kzg1TUMzSjVpdks1c1VOOUF4eUVuck9MZUordTJ2WWJq?= =?utf-8?B?Q1pkS0tWQjdXR1YyT0lmRm44RDREY2YvZXRkUmo1ZTh5T0V3TVFXczdBVWZm?= =?utf-8?B?NWRJRjFZbUxHU2VOcFphWG1wM1lhakx2dHdXWDd2bEt1UHdsTDN1OHkwclU2?= =?utf-8?B?SHMrQWlFOFhBaFpBaUh0ODdUY1NtMnVOK2dmUWdZSXNuN3VDTTIydWxDUS9r?= =?utf-8?B?eUVoc2w5Tml4TDhzWXo0cUFiOXpHSGlYVVM5ZmxLMlMxRzVscEZodWRaKzdL?= =?utf-8?B?M3ZkanBrUGI2ZCszSnd6S2xHK3A2WCsvME9TTjFYcXN0UWJQdVZERmNtZkdJ?= =?utf-8?B?eXh2aDc4bW5CNWNHd3Z4VEJpMUUxRzBCVlpDcVR3S0dkcllIamNnaWRCVWZ2?= =?utf-8?B?VHNvSERlUjhGeUFVWmVockJoWWl2MjZqZ2krYy9RcUR5MFp0NWJJUjRLK1hn?= =?utf-8?B?MXY3RUZORVNSQTFKVU9TRzR6cHF0RUVVbVFMeGFEVUdwQ3l3VVJSTGcrQjVB?= =?utf-8?B?N3VlVDFrbmlyeUpwRFNUQW0yR0ZyUlEvNm9neGp0YUdxOHQrZWZNM05PUnJh?= =?utf-8?B?QkJPVloxSjZmcEJtSHpwaU5jcWRBcnRVQzN0djdYWkRVR29MZFVQMmhPT1NO?= =?utf-8?B?L2NNQ1hreG5GZTVVdGFzRVRqVDd3aHdtMjFNdUNVNVVaNkhvVC9xRFVlY1N4?= =?utf-8?Q?8Qy8T7/h2jTUsISheFkzxkOdeUNS3semOO2e4ws?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB4886 Original-Authentication-Results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT024.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 8b97cdaf-8e5f-42d2-7004-08d96db41743 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: E0aigNk6vmBuKMIiwjlQZC8f4cbcPQELC/0xx0aWofHWWh/aCnBErSEP2a8qEeE92331ccS+Y4E2aDq70OckR7eU8yua1PR7Lm4ZW7GkU73si1T1SMRoRqdSAMssKVY/icfYBnPXzeeByNN2UGEKzVX8Bu0PC8I4ct7jbiWxKPXq/W41DtMM9ShHVRCKYfkJDxxal3Is5pe8Q5ikoiuobCh99eq47ex6jMlxxoZ/4Dwa7Jes/TdxYkZl6rHHgxOHF1aRunT61Xjx9otsqcCgRj322DDUXZXHHt59Dp1o4lzOcTl8WpW2NBW7TF2t2i2WRTdYrPi1QdD/BxVlkaKaz1d+HQNE5mmg1QzlvYwnVhjzMDrnpIdSyKh+r6FDNPvu4vkCmVdFCcIq2RzfuvOY5UMzTn60Rhl5Vxukv+x/Wegxe0PHh7UsNhFbYOJT4JV8RkIyEUrX9UdBIW+oWsg4aTeukUKda8/tsj/P1dBoN/CGySxcEB4PRjwakexMkrxwLtjnE9M5NiTy1JmgRD2UfnSuoqvg0hKdbTLlQqyA9voPtDHIuilIIysLYpyK3IxZn1VWe9Qh63BWdSLX+kgyiCC3S22TbYPgz0p6LjVFAIk1IqICLEhEclttUFPA/T3gsbQUUP9LdtWlLBT5PYJ/hDG8Drpim6jhUWIsEL/zIcDMk9uAgDp3yJoIieUJhVH54doYu9OGfUoKCvUOPn9AdO6m4NkOYZGvoV9CcU4CE75RQa0yg9cyh+EBt3tYnh3ybSqPMKOalDR2HZ1if/UfkAq4CMo1GAk8H+bvQY8MHIAqnX6pEaNictCHbqyocmFl7ROBF59rQWevIiEAYxg0ow== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(376002)(136003)(396003)(346002)(39860400002)(46966006)(36840700001)(30864003)(336012)(478600001)(966005)(110136005)(7696005)(2906002)(5660300002)(26005)(52536014)(2940100002)(66574015)(6506007)(316002)(8676002)(53546011)(82310400003)(9686003)(4326008)(47076005)(81166007)(83380400001)(86362001)(356005)(186003)(8936002)(36860700001)(33656002)(55016002)(54906003)(70206006)(70586007)(82740400003)(579004)(559001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Sep 2021 01:51:20.8495 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8e4df78d-ec5c-4f87-74b9-08d96db42991 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT024.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3430 SGkgQWthc2hpLCBPbGVrc2FuZHIsDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4g RnJvbTogWGVuLWRldmVsIDx4ZW4tZGV2ZWwtYm91bmNlc0BsaXN0cy54ZW5wcm9qZWN0Lm9yZz4g T24gQmVoYWxmIE9mIFdlaQ0KPiBDaGVuDQo+IFNlbnQ6IDIwMjHlubQ55pyIMuaXpSA5OjMxDQo+ IFRvOiBBS0FTSEkgVGFrYWhpcm8gPHRha2FoaXJvLmFrYXNoaUBsaW5hcm8ub3JnPg0KPiBDYzog T2xla3NhbmRyIFR5c2hjaGVua28gPG9sZWtzdHlzaEBnbWFpbC5jb20+OyBTdGVmYW5vIFN0YWJl bGxpbmkNCj4gPHNzdGFiZWxsaW5pQGtlcm5lbC5vcmc+OyBBbGV4IEJlbm4/P2UgPGFsZXguYmVu bmVlQGxpbmFyby5vcmc+OyBLYWx5IFhpbg0KPiA8S2FseS5YaW5AYXJtLmNvbT47IFN0cmF0b3Mg TWFpbGluZyBMaXN0IDxzdHJhdG9zLWRldkBvcC1saXN0cy5saW5hcm8ub3JnPjsNCj4gdmlydGlv LWRldkBsaXN0cy5vYXNpcy1vcGVuLm9yZzsgQXJuZCBCZXJnbWFubiA8YXJuZC5iZXJnbWFubkBs aW5hcm8ub3JnPjsNCj4gVmlyZXNoIEt1bWFyIDx2aXJlc2gua3VtYXJAbGluYXJvLm9yZz47IFN0 ZWZhbm8gU3RhYmVsbGluaQ0KPiA8c3RlZmFuby5zdGFiZWxsaW5pQHhpbGlueC5jb20+OyBzdGVm YW5oYUByZWRoYXQuY29tOyBKYW4gS2lzemthDQo+IDxqYW4ua2lzemthQHNpZW1lbnMuY29tPjsg Q2FybCB2YW4gU2NoYWlrIDxjdmFuc2NoYUBxdGkucXVhbGNvbW0uY29tPjsNCj4gcHJhdGlrcEBx dWljaW5jLmNvbTsgU3JpdmF0c2EgVmFkZGFnaXJpIDx2YXRzYUBjb2RlYXVyb3JhLm9yZz47IEpl YW4tDQo+IFBoaWxpcHBlIEJydWNrZXIgPGplYW4tcGhpbGlwcGVAbGluYXJvLm9yZz47IE1hdGhp ZXUgUG9pcmllcg0KPiA8bWF0aGlldS5wb2lyaWVyQGxpbmFyby5vcmc+OyBPbGVrc2FuZHIgVHlz aGNoZW5rbw0KPiA8T2xla3NhbmRyX1R5c2hjaGVua29AZXBhbS5jb20+OyBCZXJ0cmFuZCBNYXJx dWlzDQo+IDxCZXJ0cmFuZC5NYXJxdWlzQGFybS5jb20+OyBBcnRlbSBNeWdhaWV2IDxBcnRlbV9N eWdhaWV2QGVwYW0uY29tPjsgSnVsaWVuDQo+IEdyYWxsIDxqdWxpZW5AeGVuLm9yZz47IEp1ZXJn ZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT47IFBhdWwgRHVycmFudA0KPiA8cGF1bEB4ZW4ub3Jn PjsgbmQgPG5kQGFybS5jb20+OyBYZW4gRGV2ZWwgPHhlbi1kZXZlbEBsaXN0cy54ZW4ub3JnPg0K PiBTdWJqZWN0OiBSRTogRW5hYmxpbmcgaHlwZXJ2aXNvciBhZ25vc3RpY2lzbSBmb3IgVmlydElP IGJhY2tlbmRzDQo+IA0KPiBIaSBBa2FzaGksDQo+IA0KPiA+IC0tLS0tT3JpZ2luYWwgTWVzc2Fn ZS0tLS0tDQo+ID4gRnJvbTogQUtBU0hJIFRha2FoaXJvIDx0YWthaGlyby5ha2FzaGlAbGluYXJv Lm9yZz4NCj4gPiBTZW50OiAyMDIx5bm0OeaciDHml6UgMjA6MjkNCj4gPiBUbzogV2VpIENoZW4g PFdlaS5DaGVuQGFybS5jb20+DQo+ID4gQ2M6IE9sZWtzYW5kciBUeXNoY2hlbmtvIDxvbGVrc3R5 c2hAZ21haWwuY29tPjsgU3RlZmFubyBTdGFiZWxsaW5pDQo+ID4gPHNzdGFiZWxsaW5pQGtlcm5l bC5vcmc+OyBBbGV4IEJlbm4/P2UgPGFsZXguYmVubmVlQGxpbmFyby5vcmc+OyBLYWx5DQo+IFhp bg0KPiA+IDxLYWx5LlhpbkBhcm0uY29tPjsgU3RyYXRvcyBNYWlsaW5nIExpc3QgPHN0cmF0b3Mt ZGV2QG9wLQ0KPiBsaXN0cy5saW5hcm8ub3JnPjsNCj4gPiB2aXJ0aW8tZGV2QGxpc3RzLm9hc2lz LW9wZW4ub3JnOyBBcm5kIEJlcmdtYW5uDQo+IDxhcm5kLmJlcmdtYW5uQGxpbmFyby5vcmc+Ow0K PiA+IFZpcmVzaCBLdW1hciA8dmlyZXNoLmt1bWFyQGxpbmFyby5vcmc+OyBTdGVmYW5vIFN0YWJl bGxpbmkNCj4gPiA8c3RlZmFuby5zdGFiZWxsaW5pQHhpbGlueC5jb20+OyBzdGVmYW5oYUByZWRo YXQuY29tOyBKYW4gS2lzemthDQo+ID4gPGphbi5raXN6a2FAc2llbWVucy5jb20+OyBDYXJsIHZh biBTY2hhaWsgPGN2YW5zY2hhQHF0aS5xdWFsY29tbS5jb20+Ow0KPiA+IHByYXRpa3BAcXVpY2lu Yy5jb207IFNyaXZhdHNhIFZhZGRhZ2lyaSA8dmF0c2FAY29kZWF1cm9yYS5vcmc+OyBKZWFuLQ0K PiA+IFBoaWxpcHBlIEJydWNrZXIgPGplYW4tcGhpbGlwcGVAbGluYXJvLm9yZz47IE1hdGhpZXUg UG9pcmllcg0KPiA+IDxtYXRoaWV1LnBvaXJpZXJAbGluYXJvLm9yZz47IE9sZWtzYW5kciBUeXNo Y2hlbmtvDQo+ID4gPE9sZWtzYW5kcl9UeXNoY2hlbmtvQGVwYW0uY29tPjsgQmVydHJhbmQgTWFy cXVpcw0KPiA+IDxCZXJ0cmFuZC5NYXJxdWlzQGFybS5jb20+OyBBcnRlbSBNeWdhaWV2IDxBcnRl bV9NeWdhaWV2QGVwYW0uY29tPjsNCj4gSnVsaWVuDQo+ID4gR3JhbGwgPGp1bGllbkB4ZW4ub3Jn PjsgSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuY29tPjsgUGF1bCBEdXJyYW50DQo+ID4gPHBh dWxAeGVuLm9yZz47IG5kIDxuZEBhcm0uY29tPjsgWGVuIERldmVsIDx4ZW4tZGV2ZWxAbGlzdHMu eGVuLm9yZz4NCj4gPiBTdWJqZWN0OiBSZTogRW5hYmxpbmcgaHlwZXJ2aXNvciBhZ25vc3RpY2lz bSBmb3IgVmlydElPIGJhY2tlbmRzDQo+ID4NCj4gPiBIaSBXZWksDQo+ID4NCj4gPiBPbiBXZWQs IFNlcCAwMSwgMjAyMSBhdCAxMToxMjo1OEFNICswMDAwLCBXZWkgQ2hlbiB3cm90ZToNCj4gPiA+ IEhpIEFrYXNoaSwNCj4gPiA+DQo+ID4gPiA+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+ ID4gPiA+IEZyb206IEFLQVNISSBUYWthaGlybyA8dGFrYWhpcm8uYWthc2hpQGxpbmFyby5vcmc+ DQo+ID4gPiA+IFNlbnQ6IDIwMjHlubQ45pyIMzHml6UgMTQ6MTgNCj4gPiA+ID4gVG86IFdlaSBD aGVuIDxXZWkuQ2hlbkBhcm0uY29tPg0KPiA+ID4gPiBDYzogT2xla3NhbmRyIFR5c2hjaGVua28g PG9sZWtzdHlzaEBnbWFpbC5jb20+OyBTdGVmYW5vIFN0YWJlbGxpbmkNCj4gPiA+ID4gPHNzdGFi ZWxsaW5pQGtlcm5lbC5vcmc+OyBBbGV4IEJlbm4/P2UgPGFsZXguYmVubmVlQGxpbmFyby5vcmc+ Ow0KPiBLYWx5DQo+ID4gWGluDQo+ID4gPiA+IDxLYWx5LlhpbkBhcm0uY29tPjsgU3RyYXRvcyBN YWlsaW5nIExpc3QgPHN0cmF0b3MtZGV2QG9wLQ0KPiA+IGxpc3RzLmxpbmFyby5vcmc+Ow0KPiA+ ID4gPiB2aXJ0aW8tZGV2QGxpc3RzLm9hc2lzLW9wZW4ub3JnOyBBcm5kIEJlcmdtYW5uDQo+ID4g PGFybmQuYmVyZ21hbm5AbGluYXJvLm9yZz47DQo+ID4gPiA+IFZpcmVzaCBLdW1hciA8dmlyZXNo Lmt1bWFyQGxpbmFyby5vcmc+OyBTdGVmYW5vIFN0YWJlbGxpbmkNCj4gPiA+ID4gPHN0ZWZhbm8u c3RhYmVsbGluaUB4aWxpbnguY29tPjsgc3RlZmFuaGFAcmVkaGF0LmNvbTsgSmFuIEtpc3prYQ0K PiA+ID4gPiA8amFuLmtpc3prYUBzaWVtZW5zLmNvbT47IENhcmwgdmFuIFNjaGFpaw0KPiA8Y3Zh bnNjaGFAcXRpLnF1YWxjb21tLmNvbT47DQo+ID4gPiA+IHByYXRpa3BAcXVpY2luYy5jb207IFNy aXZhdHNhIFZhZGRhZ2lyaSA8dmF0c2FAY29kZWF1cm9yYS5vcmc+Ow0KPiBKZWFuLQ0KPiA+ID4g PiBQaGlsaXBwZSBCcnVja2VyIDxqZWFuLXBoaWxpcHBlQGxpbmFyby5vcmc+OyBNYXRoaWV1IFBv aXJpZXINCj4gPiA+ID4gPG1hdGhpZXUucG9pcmllckBsaW5hcm8ub3JnPjsgT2xla3NhbmRyIFR5 c2hjaGVua28NCj4gPiA+ID4gPE9sZWtzYW5kcl9UeXNoY2hlbmtvQGVwYW0uY29tPjsgQmVydHJh bmQgTWFycXVpcw0KPiA+ID4gPiA8QmVydHJhbmQuTWFycXVpc0Bhcm0uY29tPjsgQXJ0ZW0gTXln YWlldiA8QXJ0ZW1fTXlnYWlldkBlcGFtLmNvbT47DQo+ID4gSnVsaWVuDQo+ID4gPiA+IEdyYWxs IDxqdWxpZW5AeGVuLm9yZz47IEp1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT47IFBhdWwN Cj4gRHVycmFudA0KPiA+ID4gPiA8cGF1bEB4ZW4ub3JnPjsgWGVuIERldmVsIDx4ZW4tZGV2ZWxA bGlzdHMueGVuLm9yZz4NCj4gPiA+ID4gU3ViamVjdDogUmU6IEVuYWJsaW5nIGh5cGVydmlzb3Ig YWdub3N0aWNpc20gZm9yIFZpcnRJTyBiYWNrZW5kcw0KPiA+ID4gPg0KPiA+ID4gPiBXZWksDQo+ ID4gPiA+DQo+ID4gPiA+IE9uIFRodSwgQXVnIDI2LCAyMDIxIGF0IDEyOjEwOjE5UE0gKzAwMDAs IFdlaSBDaGVuIHdyb3RlOg0KPiA+ID4gPiA+IEhpIEFrYXNoaSwNCj4gPiA+ID4gPg0KPiA+ID4g PiA+ID4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gPiA+ID4gPiA+IEZyb206IEFLQVNI SSBUYWthaGlybyA8dGFrYWhpcm8uYWthc2hpQGxpbmFyby5vcmc+DQo+ID4gPiA+ID4gPiBTZW50 OiAyMDIx5bm0OOaciDI25pelIDE3OjQxDQo+ID4gPiA+ID4gPiBUbzogV2VpIENoZW4gPFdlaS5D aGVuQGFybS5jb20+DQo+ID4gPiA+ID4gPiBDYzogT2xla3NhbmRyIFR5c2hjaGVua28gPG9sZWtz dHlzaEBnbWFpbC5jb20+OyBTdGVmYW5vDQo+IFN0YWJlbGxpbmkNCj4gPiA+ID4gPiA+IDxzc3Rh YmVsbGluaUBrZXJuZWwub3JnPjsgQWxleCBCZW5uPz9lIDxhbGV4LmJlbm5lZUBsaW5hcm8ub3Jn PjsNCj4gPiBLYWx5DQo+ID4gPiA+IFhpbg0KPiA+ID4gPiA+ID4gPEthbHkuWGluQGFybS5jb20+ OyBTdHJhdG9zIE1haWxpbmcgTGlzdCA8c3RyYXRvcy1kZXZAb3AtDQo+ID4gPiA+IGxpc3RzLmxp bmFyby5vcmc+Ow0KPiA+ID4gPiA+ID4gdmlydGlvLWRldkBsaXN0cy5vYXNpcy1vcGVuLm9yZzsg QXJuZCBCZXJnbWFubg0KPiA+ID4gPiA8YXJuZC5iZXJnbWFubkBsaW5hcm8ub3JnPjsNCj4gPiA+ ID4gPiA+IFZpcmVzaCBLdW1hciA8dmlyZXNoLmt1bWFyQGxpbmFyby5vcmc+OyBTdGVmYW5vIFN0 YWJlbGxpbmkNCj4gPiA+ID4gPiA+IDxzdGVmYW5vLnN0YWJlbGxpbmlAeGlsaW54LmNvbT47IHN0 ZWZhbmhhQHJlZGhhdC5jb207IEphbiBLaXN6a2ENCj4gPiA+ID4gPiA+IDxqYW4ua2lzemthQHNp ZW1lbnMuY29tPjsgQ2FybCB2YW4gU2NoYWlrDQo+ID4gPGN2YW5zY2hhQHF0aS5xdWFsY29tbS5j b20+Ow0KPiA+ID4gPiA+ID4gcHJhdGlrcEBxdWljaW5jLmNvbTsgU3JpdmF0c2EgVmFkZGFnaXJp IDx2YXRzYUBjb2RlYXVyb3JhLm9yZz47DQo+ID4gSmVhbi0NCj4gPiA+ID4gPiA+IFBoaWxpcHBl IEJydWNrZXIgPGplYW4tcGhpbGlwcGVAbGluYXJvLm9yZz47IE1hdGhpZXUgUG9pcmllcg0KPiA+ ID4gPiA+ID4gPG1hdGhpZXUucG9pcmllckBsaW5hcm8ub3JnPjsgT2xla3NhbmRyIFR5c2hjaGVu a28NCj4gPiA+ID4gPiA+IDxPbGVrc2FuZHJfVHlzaGNoZW5rb0BlcGFtLmNvbT47IEJlcnRyYW5k IE1hcnF1aXMNCj4gPiA+ID4gPiA+IDxCZXJ0cmFuZC5NYXJxdWlzQGFybS5jb20+OyBBcnRlbSBN eWdhaWV2DQo+IDxBcnRlbV9NeWdhaWV2QGVwYW0uY29tPjsNCj4gPiA+ID4gSnVsaWVuDQo+ID4g PiA+ID4gPiBHcmFsbCA8anVsaWVuQHhlbi5vcmc+OyBKdWVyZ2VuIEdyb3NzIDxqZ3Jvc3NAc3Vz ZS5jb20+OyBQYXVsDQo+ID4gRHVycmFudA0KPiA+ID4gPiA+ID4gPHBhdWxAeGVuLm9yZz47IFhl biBEZXZlbCA8eGVuLWRldmVsQGxpc3RzLnhlbi5vcmc+DQo+ID4gPiA+ID4gPiBTdWJqZWN0OiBS ZTogRW5hYmxpbmcgaHlwZXJ2aXNvciBhZ25vc3RpY2lzbSBmb3IgVmlydElPIGJhY2tlbmRzDQo+ ID4gPiA+ID4gPg0KPiA+ID4gPiA+ID4gSGkgV2VpLA0KPiA+ID4gPiA+ID4NCj4gPiA+ID4gPiA+ IE9uIEZyaSwgQXVnIDIwLCAyMDIxIGF0IDAzOjQxOjUwUE0gKzA5MDAsIEFLQVNISSBUYWthaGly byB3cm90ZToNCj4gPiA+ID4gPiA+ID4gT24gV2VkLCBBdWcgMTgsIDIwMjEgYXQgMDg6MzU6NTFB TSArMDAwMCwgV2VpIENoZW4gd3JvdGU6DQo+ID4gPiA+ID4gPiA+ID4gSGkgQWthc2hp77yMDQo+ ID4gPiA+ID4gPiA+ID4NCj4gPiA+ID4gPiA+ID4gPiA+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0t LS0tDQo+ID4gPiA+ID4gPiA+ID4gPiBGcm9tOiBBS0FTSEkgVGFrYWhpcm8gPHRha2FoaXJvLmFr YXNoaUBsaW5hcm8ub3JnPg0KPiA+ID4gPiA+ID4gPiA+ID4gU2VudDogMjAyMeW5tDjmnIgxOOaX pSAxMzozOQ0KPiA+ID4gPiA+ID4gPiA+ID4gVG86IFdlaSBDaGVuIDxXZWkuQ2hlbkBhcm0uY29t Pg0KPiA+ID4gPiA+ID4gPiA+ID4gQ2M6IE9sZWtzYW5kciBUeXNoY2hlbmtvIDxvbGVrc3R5c2hA Z21haWwuY29tPjsgU3RlZmFubw0KPiA+ID4gPiBTdGFiZWxsaW5pDQo+ID4gPiA+ID4gPiA+ID4g PiA8c3N0YWJlbGxpbmlAa2VybmVsLm9yZz47IEFsZXggQmVubj8/ZQ0KPiA+IDxhbGV4LmJlbm5l ZUBsaW5hcm8ub3JnPjsNCj4gPiA+ID4gPiA+IFN0cmF0b3MNCj4gPiA+ID4gPiA+ID4gPiA+IE1h aWxpbmcgTGlzdCA8c3RyYXRvcy1kZXZAb3AtbGlzdHMubGluYXJvLm9yZz47IHZpcnRpby0NCj4g PiA+ID4gPiA+IGRldkBsaXN0cy5vYXNpcy0NCj4gPiA+ID4gPiA+ID4gPiA+IG9wZW4ub3JnOyBB cm5kIEJlcmdtYW5uIDxhcm5kLmJlcmdtYW5uQGxpbmFyby5vcmc+OyBWaXJlc2gNCj4gPiBLdW1h cg0KPiA+ID4gPiA+ID4gPiA+ID4gPHZpcmVzaC5rdW1hckBsaW5hcm8ub3JnPjsgU3RlZmFubyBT dGFiZWxsaW5pDQo+ID4gPiA+ID4gPiA+ID4gPiA8c3RlZmFuby5zdGFiZWxsaW5pQHhpbGlueC5j b20+OyBzdGVmYW5oYUByZWRoYXQuY29tOyBKYW4NCj4gPiBLaXN6a2ENCj4gPiA+ID4gPiA+ID4g PiA+IDxqYW4ua2lzemthQHNpZW1lbnMuY29tPjsgQ2FybCB2YW4gU2NoYWlrDQo+ID4gPiA+ID4g PiA8Y3ZhbnNjaGFAcXRpLnF1YWxjb21tLmNvbT47DQo+ID4gPiA+ID4gPiA+ID4gPiBwcmF0aWtw QHF1aWNpbmMuY29tOyBTcml2YXRzYSBWYWRkYWdpcmkNCj4gPiA8dmF0c2FAY29kZWF1cm9yYS5v cmc+Ow0KPiA+ID4gPiA+ID4gSmVhbi0NCj4gPiA+ID4gPiA+ID4gPiA+IFBoaWxpcHBlIEJydWNr ZXIgPGplYW4tcGhpbGlwcGVAbGluYXJvLm9yZz47IE1hdGhpZXUNCj4gUG9pcmllcg0KPiA+ID4g PiA+ID4gPiA+ID4gPG1hdGhpZXUucG9pcmllckBsaW5hcm8ub3JnPjsgT2xla3NhbmRyIFR5c2hj aGVua28NCj4gPiA+ID4gPiA+ID4gPiA+IDxPbGVrc2FuZHJfVHlzaGNoZW5rb0BlcGFtLmNvbT47 IEJlcnRyYW5kIE1hcnF1aXMNCj4gPiA+ID4gPiA+ID4gPiA+IDxCZXJ0cmFuZC5NYXJxdWlzQGFy bS5jb20+OyBBcnRlbSBNeWdhaWV2DQo+ID4gPiA+IDxBcnRlbV9NeWdhaWV2QGVwYW0uY29tPjsN Cj4gPiA+ID4gPiA+IEp1bGllbg0KPiA+ID4gPiA+ID4gPiA+ID4gR3JhbGwgPGp1bGllbkB4ZW4u b3JnPjsgSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuY29tPjsNCj4gPiBQYXVsDQo+ID4gPiA+ ID4gPiBEdXJyYW50DQo+ID4gPiA+ID4gPiA+ID4gPiA8cGF1bEB4ZW4ub3JnPjsgWGVuIERldmVs IDx4ZW4tZGV2ZWxAbGlzdHMueGVuLm9yZz4NCj4gPiA+ID4gPiA+ID4gPiA+IFN1YmplY3Q6IFJl OiBFbmFibGluZyBoeXBlcnZpc29yIGFnbm9zdGljaXNtIGZvciBWaXJ0SU8NCj4gPiBiYWNrZW5k cw0KPiA+ID4gPiA+ID4gPiA+ID4NCj4gPiA+ID4gPiA+ID4gPiA+IE9uIFR1ZSwgQXVnIDE3LCAy MDIxIGF0IDA4OjM5OjA5QU0gKzAwMDAsIFdlaSBDaGVuIHdyb3RlOg0KPiA+ID4gPiA+ID4gPiA+ ID4gPiBIaSBBa2FzaGksDQo+ID4gPiA+ID4gPiA+ID4gPiA+DQo+ID4gPiA+ID4gPiA+ID4gPiA+ ID4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiBGcm9t OiBBS0FTSEkgVGFrYWhpcm8gPHRha2FoaXJvLmFrYXNoaUBsaW5hcm8ub3JnPg0KPiA+ID4gPiA+ ID4gPiA+ID4gPiA+IFNlbnQ6IDIwMjHlubQ45pyIMTfml6UgMTY6MDgNCj4gPiA+ID4gPiA+ID4g PiA+ID4gPiBUbzogV2VpIENoZW4gPFdlaS5DaGVuQGFybS5jb20+DQo+ID4gPiA+ID4gPiA+ID4g PiA+ID4gQ2M6IE9sZWtzYW5kciBUeXNoY2hlbmtvIDxvbGVrc3R5c2hAZ21haWwuY29tPjsNCj4g U3RlZmFubw0KPiA+ID4gPiA+ID4gU3RhYmVsbGluaQ0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+IDxz c3RhYmVsbGluaUBrZXJuZWwub3JnPjsgQWxleCBCZW5uPz9lDQo+ID4gPiA+IDxhbGV4LmJlbm5l ZUBsaW5hcm8ub3JnPjsNCj4gPiA+ID4gPiA+ID4gPiA+IFN0cmF0b3MNCj4gPiA+ID4gPiA+ID4g PiA+ID4gPiBNYWlsaW5nIExpc3QgPHN0cmF0b3MtZGV2QG9wLWxpc3RzLmxpbmFyby5vcmc+Ow0K PiB2aXJ0aW8tDQo+ID4gPiA+ID4gPiA+ID4gPiBkZXZAbGlzdHMub2FzaXMtDQo+ID4gPiA+ID4g PiA+ID4gPiA+ID4gb3Blbi5vcmc7IEFybmQgQmVyZ21hbm4gPGFybmQuYmVyZ21hbm5AbGluYXJv Lm9yZz47DQo+ID4gVmlyZXNoDQo+ID4gPiA+IEt1bWFyDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4g PHZpcmVzaC5rdW1hckBsaW5hcm8ub3JnPjsgU3RlZmFubyBTdGFiZWxsaW5pDQo+ID4gPiA+ID4g PiA+ID4gPiA+ID4gPHN0ZWZhbm8uc3RhYmVsbGluaUB4aWxpbnguY29tPjsgc3RlZmFuaGFAcmVk aGF0LmNvbTsNCj4gPiBKYW4NCj4gPiA+ID4gS2lzemthDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4g PGphbi5raXN6a2FAc2llbWVucy5jb20+OyBDYXJsIHZhbiBTY2hhaWsNCj4gPiA+ID4gPiA+IDxj dmFuc2NoYUBxdGkucXVhbGNvbW0uY29tPjsNCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiBwcmF0aWtw QHF1aWNpbmMuY29tOyBTcml2YXRzYSBWYWRkYWdpcmkNCj4gPiA+ID4gPHZhdHNhQGNvZGVhdXJv cmEub3JnPjsNCj4gPiA+ID4gPiA+IEplYW4tDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gUGhpbGlw cGUgQnJ1Y2tlciA8amVhbi1waGlsaXBwZUBsaW5hcm8ub3JnPjsgTWF0aGlldQ0KPiA+IFBvaXJp ZXINCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA8bWF0aGlldS5wb2lyaWVyQGxpbmFyby5vcmc+OyBP bGVrc2FuZHIgVHlzaGNoZW5rbw0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+IDxPbGVrc2FuZHJfVHlz aGNoZW5rb0BlcGFtLmNvbT47IEJlcnRyYW5kIE1hcnF1aXMNCj4gPiA+ID4gPiA+ID4gPiA+ID4g PiA8QmVydHJhbmQuTWFycXVpc0Bhcm0uY29tPjsgQXJ0ZW0gTXlnYWlldg0KPiA+ID4gPiA+ID4g PEFydGVtX015Z2FpZXZAZXBhbS5jb20+Ow0KPiA+ID4gPiA+ID4gPiA+ID4gSnVsaWVuDQo+ID4g PiA+ID4gPiA+ID4gPiA+ID4gR3JhbGwgPGp1bGllbkB4ZW4ub3JnPjsgSnVlcmdlbiBHcm9zcw0K PiA8amdyb3NzQHN1c2UuY29tPjsNCj4gPiA+ID4gUGF1bA0KPiA+ID4gPiA+ID4gRHVycmFudA0K PiA+ID4gPiA+ID4gPiA+ID4gPiA+IDxwYXVsQHhlbi5vcmc+OyBYZW4gRGV2ZWwgPHhlbi1kZXZl bEBsaXN0cy54ZW4ub3JnPg0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+IFN1YmplY3Q6IFJlOiBFbmFi bGluZyBoeXBlcnZpc29yIGFnbm9zdGljaXNtIGZvcg0KPiBWaXJ0SU8NCj4gPiA+ID4gYmFja2Vu ZHMNCj4gPiA+ID4gPiA+ID4gPiA+ID4gPg0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+IEhpIFdlaSwg T2xla3NhbmRyLA0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+DQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4g T24gTW9uLCBBdWcgMTYsIDIwMjEgYXQgMTA6MDQ6MDNBTSArMDAwMCwgV2VpIENoZW4NCj4gd3Jv dGU6DQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiBIaSBBbGwsDQo+ID4gPiA+ID4gPiA+ID4gPiA+ ID4gPg0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gVGhhbmtzIGZvciBTdGVmYW5vIHRvIGxpbmsg bXkga3ZtdG9vbCBmb3IgWGVuDQo+IHByb3Bvc2FsDQo+ID4gPiA+IGhlcmUuDQo+ID4gPiA+ID4g PiA+ID4gPiA+ID4gPiBUaGlzIHByb3Bvc2FsIGlzIHN0aWxsIGRpc2N1c3NpbmcgaW4gWGVuIGFu ZCBLVk0NCj4gPiA+ID4gY29tbXVuaXRpZXMuDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiBUaGUg bWFpbiB3b3JrIGlzIHRvIGRlY291cGxlIHRoZSBrdm10b29sIGZyb20gS1ZNDQo+IGFuZA0KPiA+ IG1ha2UNCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+IG90aGVyIGh5cGVydmlzb3JzIGNhbiByZXVz ZSB0aGUgdmlydHVhbCBkZXZpY2UNCj4gPiA+ID4gaW1wbGVtZW50YXRpb25zLg0KPiA+ID4gPiA+ ID4gPiA+ID4gPiA+ID4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+IEluIHRoaXMgY2FzZSwgd2Ug bmVlZCB0byBpbnRyb2R1Y2UgYW4gaW50ZXJtZWRpYXRlDQo+ID4gPiA+IGh5cGVydmlzb3INCj4g PiA+ID4gPiA+ID4gPiA+ID4gPiA+IGxheWVyIGZvciBWTU0gYWJzdHJhY3Rpb24sIFdoaWNoIGlz LCBJIHRoaW5rIGl0J3MNCj4gdmVyeQ0KPiA+ID4gPiBjbG9zZQ0KPiA+ID4gPiA+ID4gPiA+ID4g PiA+ID4gdG8gc3RyYXRvcycgdmlydGlvIGh5cGVydmlzb3IgYWdub3N0aWNpc20gd29yay4NCj4g PiA+ID4gPiA+ID4gPiA+ID4gPg0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ICMgTXkgcHJvcG9zYWxb MV0gY29tZXMgZnJvbSBteSBvd24gaWRlYSBhbmQgZG9lc24ndA0KPiA+IGFsd2F5cw0KPiA+ID4g PiA+ID4gcmVwcmVzZW50DQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gIyBMaW5hcm8ncyB2aWV3IG9u IHRoaXMgc3ViamVjdCBub3IgcmVmbGVjdCBBbGV4J3MNCj4gPiBjb25jZXJucy4NCj4gPiA+ID4g PiA+ID4gPiA+IE5ldmVydGhlbGVzcywNCj4gPiA+ID4gPiA+ID4gPiA+ID4gPg0KPiA+ID4gPiA+ ID4gPiA+ID4gPiA+IFlvdXIgaWRlYSBhbmQgbXkgcHJvcG9zYWwgc2VlbSB0byBzaGFyZSB0aGUg c2FtZQ0KPiA+IGJhY2tncm91bmQuDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gQm90aCBoYXZlIHRo ZSBzaW1pbGFyIGdvYWwgYW5kIGN1cnJlbnRseSBzdGFydCB3aXRoLA0KPiBhdA0KPiA+ID4gPiBm aXJzdCwNCj4gPiA+ID4gPiA+IFhlbg0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+IGFuZCBhcmUgYmFz ZWQgb24ga3ZtLXRvb2wuIChBY3R1YWxseSwgbXkgd29yayBpcw0KPiBkZXJpdmVkDQo+ID4gPiA+ IGZyb20NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiBFUEFNJ3MgdmlydGlvLWRpc2ssIHdoaWNoIGlz IGFsc28gYmFzZWQgb24ga3ZtLXRvb2wuKQ0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+DQo+ID4gPiA+ ID4gPiA+ID4gPiA+ID4gSW4gcGFydGljdWxhciwgdGhlIGFic3RyYWN0aW9uIG9mIGh5cGVydmlz b3INCj4gaW50ZXJmYWNlcw0KPiA+IGhhcw0KPiA+ID4gPiBhDQo+ID4gPiA+ID4gPiBzYW1lDQo+ ID4gPiA+ID4gPiA+ID4gPiA+ID4gc2V0IG9mIGludGVyZmFjZXMgKGZvciB5b3VyICJzdHJ1Y3Qg dm1tX2ltcGwiIGFuZCBteQ0KPiA+ICJSUEMNCj4gPiA+ID4gPiA+IGludGVyZmFjZXMiKS4NCj4g PiA+ID4gPiA+ID4gPiA+ID4gPiBUaGlzIGlzIG5vdCBjby1pbmNpZGVudCBhcyB3ZSBib3RoIHNo YXJlIHRoZSBzYW1lDQo+IG9yaWdpbg0KPiA+IGFzDQo+ID4gPiA+IEkNCj4gPiA+ID4gPiA+IHNh aWQNCj4gPiA+ID4gPiA+ID4gPiA+IGFib3ZlLg0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+IEFuZCBz byB3ZSB3aWxsIGFsc28gc2hhcmUgdGhlIHNhbWUgaXNzdWVzLiBPbmUgb2YgdGhlbQ0KPiA+IGlz IGENCj4gPiA+ID4gd2F5DQo+ID4gPiA+ID4gPiBvZg0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ICJz aGFyaW5nL21hcHBpbmcgRkUncyBtZW1vcnkiLiBUaGVyZSBpcyBzb21lIHRyYWRlLW9mZg0KPiA+ ID4gPiBiZXR3ZWVuDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gdGhlIHBvcnRhYmlsaXR5IGFuZCB0 aGUgcGVyZm9ybWFuY2UgaW1wYWN0Lg0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+IFNvIHdlIGNhbiBk aXNjdXNzIHRoZSB0b3BpYyBoZXJlIGluIHRoaXMgTUwsIHRvby4NCj4gPiA+ID4gPiA+ID4gPiA+ ID4gPiAoU2VlIEFsZXgncyBvcmlnaW5hbCBlbWFpbCwgdG9vKS4NCj4gPiA+ID4gPiA+ID4gPiA+ ID4gPg0KPiA+ID4gPiA+ID4gPiA+ID4gPiBZZXMsIEkgYWdyZWUuDQo+ID4gPiA+ID4gPiA+ID4g PiA+DQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gT24gdGhlIG90aGVyIGhhbmQsIG15IGFwcHJvYWNo IGFpbXMgdG8gY3JlYXRlIGENCj4gInNpbmdsZS0NCj4gPiA+ID4gYmluYXJ5Ig0KPiA+ID4gPiA+ ID4gPiA+ID4gc29sdXRpb24NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiBpbiB3aGljaCB0aGUgc2Ft ZSBiaW5hcnkgb2YgQkUgdm0gY291bGQgcnVuIG9uIGFueQ0KPiA+ID4gPiBoeXBlcnZpc29ycy4N Cj4gPiA+ID4gPiA+ID4gPiA+ID4gPiBTb21laG93IHNpbWlsYXIgdG8geW91ciAicHJvcG9zYWwt IzIiIGluIFsyXSwgYnV0IGluDQo+IG15DQo+ID4gPiA+IHNvbHV0aW9uLA0KPiA+ID4gPiA+ID4g YWxsDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gdGhlIGh5cGVydmlzb3Itc3BlY2lmaWMgY29kZSB3 b3VsZCBiZSBwdXQgaW50byBhbm90aGVyDQo+ID4gPiA+IGVudGl0eQ0KPiA+ID4gPiA+ID4gKFZN KSwNCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiBuYW1lZCAidmlydGlvLXByb3h5IiBhbmQgdGhlIGFi c3RyYWN0ZWQgb3BlcmF0aW9ucyBhcmUNCj4gPiA+ID4gc2VydmVkDQo+ID4gPiA+ID4gPiB2aWEg UlBDLg0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+IChJbiB0aGlzIHNlbnNlLCBCRSBpcyBoeXBlcnZp c29yLWFnbm9zdGljIGJ1dCBtaWdodA0KPiBoYXZlDQo+ID4gT1MNCj4gPiA+ID4gPiA+ID4gPiA+ IGRlcGVuZGVuY3kuKQ0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+IEJ1dCBJIGtub3cgdGhhdCB3ZSBu ZWVkIGRpc2N1c3MgaWYgdGhpcyBpcyBhDQo+IHJlcXVpcmVtZW50DQo+ID4gPiA+IGV2ZW4NCj4g PiA+ID4gPiA+ID4gPiA+ID4gPiBpbiBTdHJhdG9zIHByb2plY3Qgb3Igbm90LiAoTWF5YmUgbm90 KQ0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+DQo+ID4gPiA+ID4gPiA+ID4gPiA+DQo+ID4gPiA+ID4g PiA+ID4gPiA+IFNvcnJ5LCBJIGhhdmVuJ3QgaGFkIHRpbWUgdG8gZmluaXNoIHJlYWRpbmcgeW91 ciB2aXJ0aW8tDQo+ID4gcHJveHkNCj4gPiA+ID4gPiA+IGNvbXBsZXRlbHkNCj4gPiA+ID4gPiA+ ID4gPiA+ID4gKEkgd2lsbCBkbyBpdCBBU0FQKS4gQnV0IGZyb20geW91ciBkZXNjcmlwdGlvbiwg aXQgc2VlbXMNCj4gPiB3ZQ0KPiA+ID4gPiBuZWVkIGENCj4gPiA+ID4gPiA+ID4gPiA+ID4gM3Jk IFZNIGJldHdlZW4gRkUgYW5kIEJFPyBNeSBjb25jZXJuIGlzIHRoYXQsIGlmIG15DQo+ID4gYXNz dW1wdGlvbg0KPiA+ID4gPiBpcw0KPiA+ID4gPiA+ID4gcmlnaHQsDQo+ID4gPiA+ID4gPiA+ID4g PiA+IHdpbGwgaXQgaW5jcmVhc2UgdGhlIGxhdGVuY3kgaW4gZGF0YSB0cmFuc3BvcnQgcGF0aD8N Cj4gRXZlbg0KPiA+IGlmDQo+ID4gPiA+IHdlJ3JlDQo+ID4gPiA+ID4gPiA+ID4gPiA+IHVzaW5n IHNvbWUgbGlnaHR3ZWlnaHQgZ3Vlc3QgbGlrZSBSVE9TIG9yIFVuaWtlcm5lbCwNCj4gPiA+ID4g PiA+ID4gPiA+DQo+ID4gPiA+ID4gPiA+ID4gPiBZZXMsIHlvdSdyZSByaWdodC4gQnV0IEknbSBh ZnJhaWQgdGhhdCBpdCBpcyBhIG1hdHRlciBvZg0KPiA+IGRlZ3JlZS4NCj4gPiA+ID4gPiA+ID4g PiA+IEFzIGZhciBhcyB3ZSBleGVjdXRlICdtYXBwaW5nJyBvcGVyYXRpb25zIGF0IGV2ZXJ5IGZl dGNoDQo+IG9mDQo+ID4gPiA+IHBheWxvYWQsDQo+ID4gPiA+ID4gPiA+ID4gPiB3ZSB3aWxsIHNl ZSBsYXRlbmN5IGlzc3VlIChldmVuIGluIHlvdXIgY2FzZSkgYW5kIGlmIHdlDQo+IGhhdmUNCj4g PiA+ID4gc29tZQ0KPiA+ID4gPiA+ID4gc29sdXRpb24NCj4gPiA+ID4gPiA+ID4gPiA+IGZvciBp dCwgd2Ugd29uJ3Qgc2VlIGl0IG5laXRoZXIgaW4gbXkgcHJvcG9zYWwgOikNCj4gPiA+ID4gPiA+ ID4gPiA+DQo+ID4gPiA+ID4gPiA+ID4NCj4gPiA+ID4gPiA+ID4gPiBPbGVrc2FuZHIgaGFzIHNl bnQgYSBwcm9wb3NhbCB0byBYZW4gbWFpbGluZyBsaXN0IHRvIHJlZHVjZQ0KPiA+IHRoaXMNCj4g PiA+ID4ga2luZA0KPiA+ID4gPiA+ID4gPiA+IG9mICJtYXBwaW5nL3VubWFwcGluZyIgb3BlcmF0 aW9ucy4gU28gdGhlIGxhdGVuY3kgY2F1c2VkIGJ5DQo+ID4gdGhpcw0KPiA+ID4gPiA+ID4gYmVo YXZpb3INCj4gPiA+ID4gPiA+ID4gPiBvbiBYZW4gbWF5IGV2ZW50dWFsbHkgYmUgZWxpbWluYXRl ZCwgYW5kIExpbnV4LUtWTSBkb2Vzbid0DQo+ID4gaGF2ZQ0KPiA+ID4gPiB0aGF0DQo+ID4gPiA+ ID4gPiBwcm9ibGVtLg0KPiA+ID4gPiA+ID4gPg0KPiA+ID4gPiA+ID4gPiBPYnZpb3VzbHksIEkg aGF2ZSBub3QgeWV0IGNhdWdodCB1cCB0aGVyZSBpbiB0aGUgZGlzY3Vzc2lvbi4NCj4gPiA+ID4g PiA+ID4gV2hpY2ggcGF0Y2ggc3BlY2lmaWNhbGx5Pw0KPiA+ID4gPiA+ID4NCj4gPiA+ID4gPiA+ IENhbiB5b3UgZ2l2ZSBtZSB0aGUgbGluayB0byB0aGUgZGlzY3Vzc2lvbiBvciBwYXRjaCwgcGxl YXNlPw0KPiA+ID4gPiA+ID4NCj4gPiA+ID4gPg0KPiA+ID4gPiA+IEl0J3MgYSBSRkMgZGlzY3Vz c2lvbi4gV2UgaGF2ZSB0ZXN0ZWQgdGhpcyBSRkMgcGF0Y2ggaW50ZXJuYWxseS4NCj4gPiA+ID4g PiBodHRwczovL2xpc3RzLnhlbnByb2plY3Qub3JnL2FyY2hpdmVzL2h0bWwveGVuLWRldmVsLzIw MjEtDQo+ID4gPiA+IDA3L21zZzAxNTMyLmh0bWwNCj4gPiA+ID4NCj4gPiA+ID4gSSdtIGFmcmFp ZCB0aGF0IEkgbWlzcyBzb21ldGhpbmcgaGVyZSwgYnV0IEkgZG9uJ3Qga25vdw0KPiA+ID4gPiB3 aHkgdGhpcyBwcm9wb3NlZCBBUEkgd2lsbCBsZWFkIHRvIGVsaW1pbmF0aW5nICdtbWFwJyBpbiBh Y2Nlc3NpbmcNCj4gPiA+ID4gdGhlIHF1ZXVlZCBwYXlsb2FkIGF0IGV2ZXJ5IHJlcXVlc3Q/DQo+ ID4gPiA+DQo+ID4gPg0KPiA+ID4gVGhpcyBBUEkgZ2l2ZSBYZW4gZGV2aWNlIG1vZGVsIChRRU1V IG9yIGt2bXRvb2wpIHRoZSBhYmlsaXR5IHRvIG1hcA0KPiA+ID4gd2hvbGUgZ3Vlc3QgUkFNIGlu IGRldmljZSBtb2RlbCdzIGFkZHJlc3Mgc3BhY2UuIEluIHRoaXMgY2FzZSwgZGV2aWNlDQo+ID4g PiBtb2RlbCBkb2Vzbid0IG5lZWQgZHluYW1pYyBoeXBlcmNhbGwgdG8gbWFwL3VubWFwIHBheWxv YWQgbWVtb3J5Lg0KPiA+ID4gSXQgY2FuIHVzZSBhIGZsYXQgb2Zmc2V0IHRvIGFjY2VzcyBwYXls b2FkIG1lbW9yeSBpbiBpdHMgYWRkcmVzcw0KPiA+ID4gc3BhY2UgZGlyZWN0bHkuIEp1c3QgTGlr ZSBLVk0gZGV2aWNlIG1vZGVsIGRvZXMgbm93Lg0KPiA+DQo+ID4gVGhhbmsgeW91LiBRdWlja2x5 LCBsZXQgbWUgbWFrZSBzdXJlIG9uZSB0aGluZzoNCj4gPiBUaGlzIEFQSSBpdHNlbGYgZG9lc24n dCBkbyBhbnkgbWFwcGluZyBvcGVyYXRpb25zLCByaWdodD8NCj4gPiBTbyBJIHN1cHBvc2UgdGhh dCB2aXJ0aW8gQkUgZ3Vlc3QgaXMgcmVzcG9uc2libGUgdG8NCj4gPiAxKSBmZXRjaCB0aGUgaW5m b3JtYXRpb24gYWJvdXQgYWxsIHRoZSBtZW1vcnkgcmVnaW9ucyBpbiBGRSwNCj4gPiAyKSBjYWxs IHRoaXMgQVBJIHRvIGFsbG9jYXRlIGEgYmlnIGNodW5rIG9mIHVudXNlZCBzcGFjZSBpbiBCRSwN Cj4gPiAzKSBjcmVhdGUgZ3JhbnQvZm9yZWlnbiBtYXBwaW5ncyBmb3IgRkUgb250byB0aGlzIHJl Z2lvbihTKQ0KPiA+IGluIHRoZSBpbml0aWFsaXphdGlvbi9jb25maWd1cmF0aW9uIG9mIGVtdWxh dGVkIHZpcnRpbyBkZXZpY2VzLg0KPiA+DQo+ID4gSXMgdGhpcyB0aGUgd2F5IHRoaXMgQVBJIGlz IGV4cGVjdGVkIHRvIGJlIHVzZWQ/DQo+ID4gRG9lcyBYZW4gYWxyZWFkeSBoYXMgYW4gaW50ZXJm YWNlIGZvciAoMSk/DQo+ID4NCj4gDQo+IFRoZXkgYXJlIGRpc2N1c3NpbmcgaW4gdGhhdCB0aHJl YWQgdG8gZmluZCBhIHByb3BlciB3YXkgdG8gZG8gaXQuDQo+IEJlY2F1c2UgdGhpcyBBUEkgaXMg Y29tbW9uLCBib3RoIHg4NiBhbmQgQXJtIHNob3VsZCBiZSBjb25zaWRlcmVkLg0KPiANCg0KUGxl YXNlIGlnbm9yZSBteSBhYm92ZSByZXBseS4gSSBoYWRuJ3Qgc2VlbiBPbGVrc2FuZHIgaGFkIHJl cGxpZWQNCnRoaXMgcXVlc3Rpb24uIFNvcnJ5IGFib3V0IGl0IQ0KDQo+ID4gLVRha2FoaXJvIEFr YXNoaQ0KPiA+DQo+ID4gPiBCZWZvcmUgdGhpcyBBUEksIFdoZW4gZGV2aWNlIG1vZGVsIHRvIG1h cCB3aG9sZSBndWVzdCBtZW1vcnksIHdpbGwNCj4gPiA+IHNldmVyZWx5IGNvbnN1bWUgdGhlIHBo eXNpY2FsIHBhZ2VzIG9mIERvbS0wL0RvbS1ELg0KPiA+ID4NCj4gPiA+ID4gLVRha2FoaXJvIEFr YXNoaQ0KPiA+ID4gPg0KPiA+ID4gPg0KPiA+ID4gPiA+ID4gVGhhbmtzLA0KPiA+ID4gPiA+ID4g LVRha2FoaXJvIEFrYXNoaQ0KPiA+ID4gPiA+ID4NCj4gPiA+ID4gPiA+ID4gLVRha2FoaXJvIEFr YXNoaQ0KPiA+ID4gPiA+ID4gPg0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+IFNwZWNpZmljYWxseSBz cGVha2luZyBhYm91dCBrdm0tdG9vbCwgSSBoYXZlIGEgY29uY2Vybg0KPiA+IGFib3V0DQo+ID4g PiA+IGl0cw0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+IGxpY2Vuc2UgdGVybTsgVGFyZ2V0aW5nIGRp ZmZlcmVudCBoeXBlcnZpc29ycyBhbmQNCj4gPiBkaWZmZXJlbnQNCj4gPiA+ID4gT1NzDQo+ID4g PiA+ID4gPiA+ID4gPiA+ID4gKHdoaWNoIEkgYXNzdW1lIGluY2x1ZGVzIFJUT1MncyksIHRoZSBy ZXN1bHRhbnQNCj4gbGlicmFyeQ0KPiA+ID4gPiBzaG91bGQNCj4gPiA+ID4gPiA+IGJlDQo+ID4g PiA+ID4gPiA+ID4gPiA+ID4gbGljZW5zZSBwZXJtaXNzaXZlIGFuZCBHUEwgZm9yIGt2bS10b29s IG1pZ2h0IGJlIGFuDQo+ID4gaXNzdWUuDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gQW55IHRob3Vn aHRzPw0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+DQo+ID4gPiA+ID4gPiA+ID4gPiA+DQo+ID4gPiA+ ID4gPiA+ID4gPiA+IFllcy4gSWYgdXNlciB3YW50IHRvIGltcGxlbWVudCBhIEZyZWVCU0QgZGV2 aWNlIG1vZGVsLA0KPiBidXQNCj4gPiB0aGUNCj4gPiA+ID4gPiA+IHZpcnRpbw0KPiA+ID4gPiA+ ID4gPiA+ID4gPiBsaWJyYXJ5IGlzIEdQTC4gVGhlbiBHUEwgd291bGQgYmUgYSBwcm9ibGVtLiBJ ZiB3ZSBoYXZlDQo+ID4gPiA+IGFub3RoZXINCj4gPiA+ID4gPiA+IGdvb2QNCj4gPiA+ID4gPiA+ ID4gPiA+ID4gY2FuZGlkYXRlLCBJIGFtIG9wZW4gdG8gaXQuDQo+ID4gPiA+ID4gPiA+ID4gPg0K PiA+ID4gPiA+ID4gPiA+ID4gSSBoYXZlIHNvbWUgY2FuZGlkYXRlcywgcGFydGljdWxhcmx5IGZv ciB2cS92cmluZywgaW4gbXkNCj4gPiBtaW5kOg0KPiA+ID4gPiA+ID4gPiA+ID4gKiBPcGVuLUFN UCwgb3INCj4gPiA+ID4gPiA+ID4gPiA+ICogY29ycmVzcG9uZGluZyBGcmVlLUJTRCBjb2RlDQo+ ID4gPiA+ID4gPiA+ID4gPg0KPiA+ID4gPiA+ID4gPiA+DQo+ID4gPiA+ID4gPiA+ID4gSW50ZXJl c3RpbmcsIEkgd2lsbCBsb29rIGludG8gdGhlbSA6ICkNCj4gPiA+ID4gPiA+ID4gPg0KPiA+ID4g PiA+ID4gPiA+IENoZWVycywNCj4gPiA+ID4gPiA+ID4gPiBXZWkgQ2hlbg0KPiA+ID4gPiA+ID4g PiA+DQo+ID4gPiA+ID4gPiA+ID4gPiAtVGFrYWhpcm8gQWthc2hpDQo+ID4gPiA+ID4gPiA+ID4g Pg0KPiA+ID4gPiA+ID4gPiA+ID4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiAtVGFrYWhpcm8gQWth c2hpDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPg0KPiA+ID4g PiA+ID4gPiA+ID4gPiA+IFsxXSBodHRwczovL29wLWxpc3RzLmxpbmFyby5vcmcvcGlwZXJtYWls L3N0cmF0b3MtDQo+ID4gZGV2LzIwMjEtDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gQXVndXN0LzAw MDU0OC5odG1sDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gWzJdIGh0dHBzOi8vbWFyYy5pbmZvLz9s PXhlbi0NCj4gZGV2ZWwmbT0xNjIzNzM3NTQ3MDUyMzMmdz0yDQo+ID4gPiA+ID4gPiA+ID4gPiA+ ID4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+DQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+IEZy b206IE9sZWtzYW5kciBUeXNoY2hlbmtvIDxvbGVrc3R5c2hAZ21haWwuY29tPg0KPiA+ID4gPiA+ ID4gPiA+ID4gPiA+ID4gPiBTZW50OiAyMDIx5bm0OOaciDE05pelIDIzOjM4DQo+ID4gPiA+ID4g PiA+ID4gPiA+ID4gPiA+IFRvOiBBS0FTSEkgVGFrYWhpcm8gPHRha2FoaXJvLmFrYXNoaUBsaW5h cm8ub3JnPjsNCj4gPiA+ID4gU3RlZmFubw0KPiA+ID4gPiA+ID4gPiA+ID4gU3RhYmVsbGluaQ0K PiA+ID4gPiA+ID4gPiA+ID4gPiA+IDxzc3RhYmVsbGluaUBrZXJuZWwub3JnPg0KPiA+ID4gPiA+ ID4gPiA+ID4gPiA+ID4gPiBDYzogQWxleCBCZW5uPz9lIDxhbGV4LmJlbm5lZUBsaW5hcm8ub3Jn PjsgU3RyYXRvcw0KPiA+ID4gPiBNYWlsaW5nDQo+ID4gPiA+ID4gPiBMaXN0DQo+ID4gPiA+ID4g PiA+ID4gPiA+ID4gPHN0cmF0b3MtZGV2QG9wLWxpc3RzLmxpbmFyby5vcmc+OyB2aXJ0aW8tDQo+ ID4gZGV2QGxpc3RzLm9hc2lzLQ0KPiA+ID4gPiA+ID4gb3Blbi5vcmc7DQo+ID4gPiA+ID4gPiA+ ID4gPiBBcm5kDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gQmVyZ21hbm4gPGFybmQuYmVyZ21hbm5A bGluYXJvLm9yZz47IFZpcmVzaCBLdW1hcg0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+IDx2aXJlc2gu a3VtYXJAbGluYXJvLm9yZz47IFN0ZWZhbm8gU3RhYmVsbGluaQ0KPiA+ID4gPiA+ID4gPiA+ID4g PiA+IDxzdGVmYW5vLnN0YWJlbGxpbmlAeGlsaW54LmNvbT47IHN0ZWZhbmhhQHJlZGhhdC5jb207 DQo+ID4gSmFuDQo+ID4gPiA+IEtpc3prYQ0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+IDxqYW4ua2lz emthQHNpZW1lbnMuY29tPjsgQ2FybCB2YW4gU2NoYWlrDQo+ID4gPiA+ID4gPiA8Y3ZhbnNjaGFA cXRpLnF1YWxjb21tLmNvbT47DQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gcHJhdGlrcEBxdWljaW5j LmNvbTsgU3JpdmF0c2EgVmFkZGFnaXJpDQo+ID4gPiA+IDx2YXRzYUBjb2RlYXVyb3JhLm9yZz47 DQo+ID4gPiA+ID4gPiBKZWFuLQ0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+IFBoaWxpcHBlIEJydWNr ZXIgPGplYW4tcGhpbGlwcGVAbGluYXJvLm9yZz47IE1hdGhpZXUNCj4gPiBQb2lyaWVyDQo+ID4g PiA+ID4gPiA+ID4gPiA+ID4gPG1hdGhpZXUucG9pcmllckBsaW5hcm8ub3JnPjsgV2VpIENoZW4N Cj4gPiA8V2VpLkNoZW5AYXJtLmNvbT47DQo+ID4gPiA+ID4gPiBPbGVrc2FuZHINCj4gPiA+ID4g PiA+ID4gPiA+ID4gPiBUeXNoY2hlbmtvIDxPbGVrc2FuZHJfVHlzaGNoZW5rb0BlcGFtLmNvbT47 IEJlcnRyYW5kDQo+ID4gTWFycXVpcw0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+IDxCZXJ0cmFuZC5N YXJxdWlzQGFybS5jb20+OyBBcnRlbSBNeWdhaWV2DQo+ID4gPiA+ID4gPiA8QXJ0ZW1fTXlnYWll dkBlcGFtLmNvbT47DQo+ID4gPiA+ID4gPiA+ID4gPiBKdWxpZW4NCj4gPiA+ID4gPiA+ID4gPiA+ ID4gPiBHcmFsbCA8anVsaWVuQHhlbi5vcmc+OyBKdWVyZ2VuIEdyb3NzDQo+IDxqZ3Jvc3NAc3Vz ZS5jb20+Ow0KPiA+ID4gPiBQYXVsDQo+ID4gPiA+ID4gPiBEdXJyYW50DQo+ID4gPiA+ID4gPiA+ ID4gPiA+ID4gPHBhdWxAeGVuLm9yZz47IFhlbiBEZXZlbCA8eGVuLWRldmVsQGxpc3RzLnhlbi5v cmc+DQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+IFN1YmplY3Q6IFJlOiBFbmFibGluZyBoeXBl cnZpc29yIGFnbm9zdGljaXNtIGZvcg0KPiA+IFZpcnRJTw0KPiA+ID4gPiA+ID4gYmFja2VuZHMN Cj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gSGVs bG8sIGFsbC4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4NCj4gPiA+ID4gPiA+ID4gPiA+ID4g PiA+ID4gUGxlYXNlIHNlZSBzb21lIGNvbW1lbnRzIGJlbG93LiBBbmQgc29ycnkgZm9yIHRoZQ0K PiA+ID4gPiBwb3NzaWJsZQ0KPiA+ID4gPiA+ID4gZm9ybWF0DQo+ID4gPiA+ID4gPiA+ID4gPiA+ ID4gaXNzdWVzLg0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPg0KPiA+ID4gPiA+ID4gPiA+ID4g PiA+ID4gPiA+IE9uIFdlZCwgQXVnIDExLCAyMDIxIGF0IDk6MjcgQU0gQUtBU0hJIFRha2FoaXJv DQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPG1haWx0bzp0YWthaGlyby5ha2FzaGlAbGluYXJvLm9y Zz4gd3JvdGU6DQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gT24gV2VkLCBBdWcgMDQsIDIw MjEgYXQgMTI6MjA6MDFQTSAtMDcwMCwNCj4gU3RlZmFubw0KPiA+ID4gPiA+ID4gU3RhYmVsbGlu aQ0KPiA+ID4gPiA+ID4gPiA+ID4gd3JvdGU6DQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4g PiBDQ2luZyBwZW9wbGUgd29ya2luZyBvbiBYZW4rVmlydElPIGFuZCBJT1JFUXMuDQo+ID4gTm90 DQo+ID4gPiA+ID4gPiB0cmltbWluZw0KPiA+ID4gPiA+ID4gPiA+ID4gdGhlDQo+ID4gPiA+ID4g PiA+ID4gPiA+ID4gb3JpZ2luYWwNCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+IGVtYWls IHRvIGxldCB0aGVtIHJlYWQgdGhlIGZ1bGwgY29udGV4dC4NCj4gPiA+ID4gPiA+ID4gPiA+ID4g PiA+ID4gPiA+DQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiBNeSBjb21tZW50cyBiZWxv dyBhcmUgcmVsYXRlZCB0byBhIHBvdGVudGlhbA0KPiBYZW4NCj4gPiA+ID4gPiA+ID4gPiA+IGlt cGxlbWVudGF0aW9uLA0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+IG5vdA0KPiA+ID4gPiA+ID4gPiA+ ID4gPiA+ID4gPiA+ID4gYmVjYXVzZSBpdCBpcyB0aGUgb25seSBpbXBsZW1lbnRhdGlvbiB0aGF0 DQo+ID4gbWF0dGVycywNCj4gPiA+ID4gYnV0DQo+ID4gPiA+ID4gPiA+ID4gPiBiZWNhdXNlIGl0 DQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gaXMNCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ IHRoZSBvbmUgSSBrbm93IGJlc3QuDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4NCj4gPiA+ ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiBQbGVhc2Ugbm90ZSB0aGF0IG15IHByb3Bvc2FsIChhbmQg aGVuY2UgdGhlDQo+ID4gd29ya2luZw0KPiA+ID4gPiA+ID4gcHJvdG90eXBlKVsxXQ0KPiA+ID4g PiA+ID4gPiA+ID4gPiA+ID4gPiA+IGlzIGJhc2VkIG9uIFhlbidzIHZpcnRpbyBpbXBsZW1lbnRh dGlvbiAoaS5lLg0KPiA+IElPUkVRKQ0KPiA+ID4gPiBhbmQNCj4gPiA+ID4gPiA+ID4gPiA+ID4g PiBwYXJ0aWN1bGFybHkNCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiBFUEFNJ3MgdmlydGlv LWRpc2sgYXBwbGljYXRpb24gKGJhY2tlbmQgc2VydmVyKS4NCj4gPiA+ID4gPiA+ID4gPiA+ID4g PiA+ID4gPiBJdCBoYXMgYmVlbiwgSSBiZWxpZXZlLCB3ZWxsIGdlbmVyYWxpemVkIGJ1dCBpcw0K PiA+IHN0aWxsDQo+ID4gPiA+IGENCj4gPiA+ID4gPiA+IGJpdA0KPiA+ID4gPiA+ID4gPiA+ID4g Ymlhc2VkDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gdG93YXJkIHRoaXMgb3JpZ2luYWwg ZGVzaWduLg0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+DQo+ID4gPiA+ID4gPiA+ID4gPiA+ ID4gPiA+ID4gU28gSSBob3BlIHlvdSBsaWtlIG15IGFwcHJvYWNoIDopDQo+ID4gPiA+ID4gPiA+ ID4gPiA+ID4gPiA+ID4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiBbMV0gaHR0cHM6Ly9v cC0NCj4gbGlzdHMubGluYXJvLm9yZy9waXBlcm1haWwvc3RyYXRvcy0NCj4gPiA+ID4gPiA+IGRl di8yMDIxLQ0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+IEF1Z3VzdC8wMDA1NDYuaHRtbA0KPiA+ID4g PiA+ID4gPiA+ID4gPiA+ID4gPiA+DQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gTGV0IG1l IHRha2UgdGhpcyBvcHBvcnR1bml0eSB0byBleHBsYWluIGEgYml0DQo+IG1vcmUNCj4gPiA+ID4g YWJvdXQNCj4gPiA+ID4gPiA+IG15DQo+ID4gPiA+ID4gPiA+ID4gPiBhcHByb2FjaA0KPiA+ID4g PiA+ID4gPiA+ID4gPiA+IGJlbG93Lg0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+DQo+ID4g PiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiBBbHNvLCBwbGVhc2Ugc2VlIHRoaXMgcmVsZXZhbnQg ZW1haWwgdGhyZWFkOg0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gaHR0cHM6Ly9tYXJj LmluZm8vP2w9eGVuLQ0KPiA+IGRldmVsJm09MTYyMzczNzU0NzA1MjMzJnc9Mg0KPiA+ID4gPiA+ ID4gPiA+ID4gPiA+ID4gPiA+ID4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+DQo+ID4g PiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiBPbiBXZWQsIDQgQXVnIDIwMjEsIEFsZXggQmVubsOp ZSB3cm90ZToNCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gSGksDQo+ID4gPiA+ID4g PiA+ID4gPiA+ID4gPiA+ID4gPiA+DQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+IE9u ZSBvZiB0aGUgZ29hbHMgb2YgUHJvamVjdCBTdHJhdG9zIGlzIHRvDQo+ID4gZW5hYmxlDQo+ID4g PiA+ID4gPiBoeXBlcnZpc29yDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gYWdub3N0aWMNCj4gPiA+ ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gYmFja2VuZHMgc28gd2UgY2FuIGVuYWJsZSBhcyBt dWNoIHJlLXVzZSBvZg0KPiA+IGNvZGUNCj4gPiA+ID4gYXMNCj4gPiA+ID4gPiA+IHBvc3NpYmxl DQo+ID4gPiA+ID4gPiA+ID4gPiBhbmQNCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiBhdm9pZA0KPiA+ ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiByZXBlYXRpbmcgb3Vyc2VsdmVzLiBUaGlzIGlz IHRoZSBmbGlwIHNpZGUNCj4gb2YNCj4gPiB0aGUNCj4gPiA+ID4gPiA+IGZyb250IGVuZA0KPiA+ ID4gPiA+ID4gPiA+ID4gPiA+IHdoZXJlDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ IG11bHRpcGxlIGZyb250LWVuZCBpbXBsZW1lbnRhdGlvbnMgYXJlDQo+ID4gcmVxdWlyZWQgLQ0K PiA+ID4gPiBvbmUNCj4gPiA+ID4gPiA+IHBlciBPUywNCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiBh c3N1bWluZw0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiB5b3UgZG9uJ3QganVzdCB3 YW50IExpbnV4IGd1ZXN0cy4gVGhlDQo+ID4gcmVzdWx0YW50DQo+ID4gPiA+IGd1ZXN0cw0KPiA+ ID4gPiA+ID4gYXJlDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gdHJpdmlhbGx5DQo+ID4gPiA+ID4g PiA+ID4gPiA+ID4gPiA+ID4gPiA+IG1vdmFibGUgYmV0d2VlbiBoeXBlcnZpc29ycyBtb2R1bG8g YW55DQo+ID4gYWJzdHJhY3RlZA0KPiA+ID4gPiA+ID4gcGFyYXZpcnQNCj4gPiA+ID4gPiA+ID4g PiA+IHR5cGUNCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gaW50ZXJmYWNlcy4NCj4g PiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4g PiA+ID4gSW4gbXkgb3JpZ2luYWwgdGh1bWIgbmFpbCBza2V0Y2ggb2YgYQ0KPiBzb2x1dGlvbg0K PiA+IEkNCj4gPiA+ID4gPiA+IGVudmlzaW9uZWQNCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiB2aG9z dC11c2VyDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+IGRhZW1vbnMgcnVubmluZyBp biBhIGJyb2FkbHkgUE9TSVggbGlrZQ0KPiA+ID4gPiBlbnZpcm9ubWVudC4NCj4gPiA+ID4gPiA+ IFRoZQ0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+IGludGVyZmFjZSB0bw0KPiA+ID4gPiA+ID4gPiA+ ID4gPiA+ID4gPiA+ID4gPiB0aGUgZGFlbW9uIGlzIGZhaXJseSBzaW1wbGUgcmVxdWlyaW5nIG9u bHkNCj4gPiBzb21lDQo+ID4gPiA+IG1hcHBlZA0KPiA+ID4gPiA+ID4gPiA+ID4gbWVtb3J5DQo+ ID4gPiA+ID4gPiA+ID4gPiA+ID4gYW5kIHNvbWUNCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4g PiA+ID4gc29ydCBvZiBzaWduYWxsaW5nIGZvciBldmVudHMgKG9uIExpbnV4IHRoaXMNCj4gPiBp cw0KPiA+ID4gPiA+ID4gZXZlbnRmZCkuDQo+ID4gPiA+ID4gPiA+ID4gPiBUaGUNCj4gPiA+ID4g PiA+ID4gPiA+ID4gPiBpZGVhIHdhcyBhDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ IHN0dWIgYmluYXJ5IHdvdWxkIGJlIHJlc3BvbnNpYmxlIGZvciBhbnkNCj4gPiA+ID4gaHlwZXJ2 aXNvcg0KPiA+ID4gPiA+ID4gc3BlY2lmaWMNCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiBzZXR1cCBh bmQNCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gdGhlbiBsYXVuY2ggYSBjb21tb24g YmluYXJ5IHRvIGRlYWwgd2l0aCB0aGUNCj4gPiA+ID4gYWN0dWFsDQo+ID4gPiA+ID4gPiA+ID4g PiB2aXJ0cXVldWUNCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiByZXF1ZXN0cw0KPiA+ID4gPiA+ID4g PiA+ID4gPiA+ID4gPiA+ID4gPiB0aGVtc2VsdmVzLg0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4g PiA+ID4gPg0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiBTaW5jZSB0aGF0IG9yaWdp bmFsIHNrZXRjaCB3ZSd2ZSBzZWVuIGFuDQo+ID4gZXhwYW5zaW9uDQo+ID4gPiA+IGluDQo+ID4g PiA+ID4gPiB0aGUNCj4gPiA+ID4gPiA+ID4gPiA+IHNvcnQNCj4gPiA+ID4gPiA+ID4gPiA+ID4g PiBvZiB3YXlzDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+IGJhY2tlbmRzIGNvdWxk IGJlIGNyZWF0ZWQuIFRoZXJlIGlzIGludGVyZXN0DQo+ID4gaW4NCj4gPiA+ID4gPiA+ID4gPiA+ IGVuY2Fwc3VsYXRpbmcNCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiBiYWNrZW5kcw0KPiA+ID4gPiA+ ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiBpbiBSVE9TZXMgb3IgdW5pa2VybmVscyBmb3Igc29sdXRp b25zIGxpa2UNCj4gPiBTQ01JLg0KPiA+ID4gPiBUaGVyZQ0KPiA+ID4gPiA+ID4gPiA+ID4gaW50 ZXJlc3QNCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiBpbiBSdXN0DQo+ID4gPiA+ID4gPiA+ID4gPiA+ ID4gPiA+ID4gPiA+IGhhcyBwcm9tcHRlZCBpZGVhcyBvZiB1c2luZyB0aGUgdHJhaXQNCj4gPiBp bnRlcmZhY2UgdG8NCj4gPiA+ID4gPiA+IGFic3RyYWN0DQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4g ZGlmZmVyZW5jZXMNCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gYXdheSBhcyB3ZWxs IGFzIHRoZSBpZGVhIG9mIGJhcmUtbWV0YWwgUnVzdA0KPiA+ID4gPiBiYWNrZW5kcy4NCj4gPiA+ ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ ID4gV2UgaGF2ZSBhIGNhcmQgKFNUUi0xMikgY2FsbGVkICJIeXBlcmNhbGwNCj4gPiA+ID4gPiA+ IFN0YW5kYXJkaXNhdGlvbiINCj4gPiA+ID4gPiA+ID4gPiA+IHdoaWNoDQo+ID4gPiA+ID4gPiA+ ID4gPiA+ID4gPiA+ID4gPiA+IGNhbGxzIGZvciBhIGRlc2NyaXB0aW9uIG9mIHRoZSBBUElzIG5l ZWRlZA0KPiA+IGZyb20NCj4gPiA+ID4gdGhlDQo+ID4gPiA+ID4gPiA+ID4gPiBoeXBlcnZpc29y DQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gc2lkZSB0bw0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4g PiA+ID4gPiBzdXBwb3J0IFZpcnRJTyBndWVzdHMgYW5kIHRoZWlyIGJhY2tlbmRzLg0KPiA+IEhv d2V2ZXINCj4gPiA+ID4gd2UNCj4gPiA+ID4gPiA+IGFyZQ0KPiA+ID4gPiA+ID4gPiA+ID4gc29t ZQ0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+IHdheSBvZmYNCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ ID4gPiA+ID4gZnJvbSB0aGF0IGF0IHRoZSBtb21lbnQgYXMgSSB0aGluayB3ZSBuZWVkDQo+IHRv DQo+ID4gYXQNCj4gPiA+ID4gbGVhc3QNCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiBkZW1vbnN0cmF0 ZSBvbmUNCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gcG9ydGFibGUgYmFja2VuZCBi ZWZvcmUgd2Ugc3RhcnQgY29kaWZ5aW5nDQo+ID4gPiA+ID4gPiByZXF1aXJlbWVudHMuIFRvDQo+ ID4gPiA+ID4gPiA+ID4gPiB0aGF0DQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gZW5kIEkNCj4gPiA+ ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gd2FudCB0byB0aGluayBhYm91dCB3aGF0IHdlIG5l ZWQgZm9yIGENCj4gYmFja2VuZA0KPiA+IHRvDQo+ID4gPiA+ID4gPiBmdW5jdGlvbi4NCj4gPiA+ ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ ID4gQ29uZmlndXJhdGlvbg0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA9PT09PT09 PT09PT09DQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+DQo+ID4gPiA+ID4gPiA+ID4g PiA+ID4gPiA+ID4gPiA+IEluIHRoZSB0eXBlLTIgc2V0dXAgdGhpcyBpcyB0eXBpY2FsbHkgZmFp cmx5DQo+ID4gPiA+IHNpbXBsZQ0KPiA+ID4gPiA+ID4gYmVjYXVzZQ0KPiA+ID4gPiA+ID4gPiA+ ID4gdGhlDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gaG9zdA0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ ID4gPiA+ID4gPiBzeXN0ZW0gY2FuIG9yY2hlc3RyYXRlIHRoZSB2YXJpb3VzIG1vZHVsZXMNCj4g PiB0aGF0DQo+ID4gPiA+IG1ha2UNCj4gPiA+ID4gPiA+IHVwIHRoZQ0KPiA+ID4gPiA+ID4gPiA+ ID4gPiA+IGNvbXBsZXRlDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+IHN5c3RlbS4g SW4gdGhlIHR5cGUtMSBjYXNlIChvciBldmVuIHR5cGUtMg0KPiA+IHdpdGgNCj4gPiA+ID4gPiA+ IGRlbGVnYXRlZA0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+IHNlcnZpY2UgVk1zKQ0KPiA+ID4gPiA+ ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiB3ZSBuZWVkIHNvbWUgc29ydCBvZiBtZWNoYW5pc20gdG8g aW5mb3JtIHRoZQ0KPiA+ID4gPiBiYWNrZW5kDQo+ID4gPiA+ID4gPiBWTQ0KPiA+ID4gPiA+ID4g PiA+ID4gYWJvdXQNCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiBrZXkNCj4gPiA+ID4gPiA+ID4gPiA+ ID4gPiA+ID4gPiA+ID4gZGV0YWlscyBhYm91dCB0aGUgc3lzdGVtOg0KPiA+ID4gPiA+ID4gPiA+ ID4gPiA+ID4gPiA+ID4gPg0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiAgIC0gd2hl cmUgdmlydCBxdWV1ZSBtZW1vcnkgaXMgaW4gaXQncw0KPiBhZGRyZXNzDQo+ID4gPiA+IHNwYWNl DQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ICAgLSBob3cgaXQncyBnb2luZyB0byBy ZWNlaXZlIChpbnRlcnJ1cHQpDQo+IGFuZA0KPiA+ID4gPiB0cmlnZ2VyDQo+ID4gPiA+ID4gPiAo a2ljaykNCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiBldmVudHMNCj4gPiA+ID4gPiA+ID4gPiA+ID4g PiA+ID4gPiA+ID4gICAtIHdoYXQgKGlmIGFueSkgcmVzb3VyY2VzIHRoZSBiYWNrZW5kDQo+IG5l ZWRzDQo+ID4gdG8NCj4gPiA+ID4gPiA+IGNvbm5lY3QgdG8NCj4gPiA+ID4gPiA+ID4gPiA+ID4g PiA+ID4gPiA+ID4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gT2J2aW91c2x5IHlv dSBjYW4gZWxpZGUgb3ZlciBjb25maWd1cmF0aW9uDQo+ID4gaXNzdWVzDQo+ID4gPiA+IGJ5DQo+ ID4gPiA+ID4gPiBoYXZpbmcNCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiBzdGF0aWMNCj4gPiA+ID4g PiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gY29uZmlndXJhdGlvbnMgYW5kIGJha2luZyB0aGUgYXNz dW1wdGlvbnMNCj4gaW50bw0KPiA+ID4gPiB5b3VyDQo+ID4gPiA+ID4gPiBndWVzdA0KPiA+ID4g PiA+ID4gPiA+ID4gaW1hZ2VzDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gaG93ZXZlcg0KPiA+ID4g PiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiB0aGlzIGlzbid0IHNjYWxhYmxlIGluIHRoZSBsb25n IHRlcm0uIFRoZQ0KPiA+IG9idmlvdXMNCj4gPiA+ID4gPiA+IHNvbHV0aW9uDQo+ID4gPiA+ID4g PiA+ID4gPiBzZWVtcw0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+IHRvIGJlDQo+ID4gPiA+ID4gPiA+ ID4gPiA+ID4gPiA+ID4gPiA+IGV4dGVuZGluZyBhIHN1YnNldCBvZiBEZXZpY2UgVHJlZSBkYXRh IHRvDQo+IHVzZXINCj4gPiA+ID4gc3BhY2UNCj4gPiA+ID4gPiA+IGJ1dA0KPiA+ID4gPiA+ID4g PiA+ID4gcGVyaGFwcw0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+IHRoZXJlDQo+ID4gPiA+ID4gPiA+ ID4gPiA+ID4gPiA+ID4gPiA+IGFyZSBvdGhlciBhcHByb2FjaGVzPw0KPiA+ID4gPiA+ID4gPiA+ ID4gPiA+ID4gPiA+ID4gPg0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiBCZWZvcmUg YW55IHZpcnRpbyB0cmFuc2FjdGlvbnMgY2FuIHRha2UNCj4gcGxhY2UNCj4gPiB0aGUNCj4gPiA+ ID4gPiA+ID4gPiA+IGFwcHJvcHJpYXRlDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gbWVtb3J5DQo+ ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+IG1hcHBpbmdzIG5lZWQgdG8gYmUgbWFkZSBi ZXR3ZWVuIHRoZSBGRQ0KPiBndWVzdA0KPiA+IGFuZA0KPiA+ID4gPiB0aGUNCj4gPiA+ID4gPiA+ IEJFDQo+ID4gPiA+ID4gPiA+ID4gPiBndWVzdC4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4g PiA+DQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+IEN1cnJlbnRseSB0aGUgd2hvbGUg b2YgdGhlIEZFIGd1ZXN0cyBhZGRyZXNzDQo+ID4gc3BhY2UNCj4gPiA+ID4gPiA+IG5lZWRzIHRv DQo+ID4gPiA+ID4gPiA+ID4gPiBiZQ0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+IHZpc2libGUNCj4g PiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gdG8gd2hhdGV2ZXIgaXMgc2VydmluZyB0aGUg dmlydGlvIHJlcXVlc3RzLg0KPiBJDQo+ID4gY2FuDQo+ID4gPiA+ID4gPiBlbnZpc2lvbiAzDQo+ ID4gPiA+ID4gPiA+ID4gPiA+ID4gYXBwcm9hY2hlczoNCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ ID4gPiA+ID4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gICogQkUgZ3Vlc3QgYm9v dHMgd2l0aCBtZW1vcnkgYWxyZWFkeSBtYXBwZWQNCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4g PiA+ID4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gIFRoaXMgd291bGQgZW50YWls IHRoZSBndWVzdCBPUyBrbm93aW5nDQo+IHdoZXJlDQo+ID4gaW4NCj4gPiA+ID4gaXQncw0KPiA+ ID4gPiA+ID4gR3Vlc3QNCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiBQaHlzaWNhbA0KPiA+ID4gPiA+ ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiAgQWRkcmVzcyBzcGFjZSBpcyBhbHJlYWR5IHRha2VuIHVw IGFuZA0KPiA+IGF2b2lkaW5nDQo+ID4gPiA+ID4gPiBjbGFzaGluZy4gSQ0KPiA+ID4gPiA+ID4g PiA+ID4gPiA+IHdvdWxkIGFzc3VtZQ0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiAg aW4gdGhpcyBjYXNlIHlvdSB3b3VsZCB3YW50IGEgc3RhbmRhcmQNCj4gPiBpbnRlcmZhY2UNCj4g PiA+ID4gdG8NCj4gPiA+ID4gPiA+ID4gPiA+IHVzZXJzcGFjZQ0KPiA+ID4gPiA+ID4gPiA+ID4g PiA+IHRvIHRoZW4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gIG1ha2UgdGhhdCBh ZGRyZXNzIHNwYWNlIHZpc2libGUgdG8gdGhlDQo+ID4gYmFja2VuZA0KPiA+ID4gPiBkYWVtb24u DQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4g PiBZZXQgYW5vdGhlciB3YXkgaGVyZSBpcyB0aGF0IHdlIHdvdWxkIGhhdmUgd2VsbA0KPiA+IGtu b3duDQo+ID4gPiA+ID4gPiAic2hhcmVkDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gbWVtb3J5IiBi ZXR3ZWVuDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gVk1zLiBJIHRoaW5rIHRoYXQgSmFp bGhvdXNlJ3MgaXZzaG1lbSBnaXZlcyB1cw0KPiA+IGdvb2QNCj4gPiA+ID4gPiA+IGluc2lnaHRz IG9uDQo+ID4gPiA+ID4gPiA+ID4gPiB0aGlzDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gbWF0dGVy DQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gYW5kIHRoYXQgaXQgY2FuIGV2ZW4gYmUgYW4g YWx0ZXJuYXRpdmUgZm9yDQo+ID4gaHlwZXJ2aXNvci0NCj4gPiA+ID4gPiA+IGFnbm9zdGljDQo+ ID4gPiA+ID4gPiA+ID4gPiA+ID4gc29sdXRpb24uDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ ID4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiAoUGxlYXNlIG5vdGUgbWVtb3J5IHJlZ2lv bnMgaW4gaXZzaG1lbSBhcHBlYXIgYXMNCj4gYQ0KPiA+IFBDSQ0KPiA+ID4gPiA+ID4gZGV2aWNl DQo+ID4gPiA+ID4gPiA+ID4gPiBhbmQNCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiBjYW4gYmUNCj4g PiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiBtYXBwZWQgbG9jYWxseS4pDQo+ID4gPiA+ID4gPiA+ ID4gPiA+ID4gPiA+ID4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiBJIHdhbnQgdG8gYWRk IHRoaXMgc2hhcmVkIG1lbW9yeSBhc3BlY3QgdG8gbXkNCj4gPiB2aXJ0aW8tDQo+ID4gPiA+IHBy b3h5LA0KPiA+ID4gPiA+ID4gYnV0DQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gdGhlIHJl c3VsdGFudCBzb2x1dGlvbiB3b3VsZCBldmVudHVhbGx5IGxvb2sNCj4gPiBzaW1pbGFyDQo+ID4g PiA+IHRvDQo+ID4gPiA+ID4gPiBpdnNobWVtLg0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ DQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ICAqIEJFIGd1ZXN0cyBib290cyB3aXRo IGEgaHlwZXJ2aXNvciBoYW5kbGUNCj4gdG8NCj4gPiA+ID4gbWVtb3J5DQo+ID4gPiA+ID4gPiA+ ID4gPiA+ID4gPiA+ID4gPiA+DQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ICBUaGUg QkUgZ3Vlc3QgaXMgdGhlbiBmcmVlIHRvIG1hcCB0aGUgRkUncw0KPiA+IG1lbW9yeQ0KPiA+ID4g PiB0bw0KPiA+ID4gPiA+ID4gd2hlcmUNCj4gPiA+ID4gPiA+ID4gPiA+IGl0DQo+ID4gPiA+ID4g PiA+ID4gPiA+ID4gd2FudHMgaW4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gIHRo ZSBCRSdzIGd1ZXN0IHBoeXNpY2FsIGFkZHJlc3Mgc3BhY2UuDQo+ID4gPiA+ID4gPiA+ID4gPiA+ ID4gPiA+ID4gPg0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gSSBjYW5ub3Qgc2VlIGhv dyB0aGlzIGNvdWxkIHdvcmsgZm9yIFhlbi4NCj4gVGhlcmUNCj4gPiBpcw0KPiA+ID4gPiBubw0K PiA+ID4gPiA+ID4gImhhbmRsZSINCj4gPiA+ID4gPiA+ID4gPiA+IHRvDQo+ID4gPiA+ID4gPiA+ ID4gPiA+ID4gZ2l2ZQ0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gdG8gdGhlIGJhY2tl bmQgaWYgdGhlIGJhY2tlbmQgaXMgbm90IHJ1bm5pbmcNCj4gaW4NCj4gPiBkb20wLg0KPiA+ID4g PiBTbw0KPiA+ID4gPiA+ID4gZm9yDQo+ID4gPiA+ID4gPiA+ID4gPiBYZW4gSQ0KPiA+ID4gPiA+ ID4gPiA+ID4gPiA+IHRoaW5rDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiB0aGUgbWVt b3J5IGhhcyB0byBiZSBhbHJlYWR5IG1hcHBlZA0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ DQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gSW4gWGVuJ3MgSU9SRVEgc29sdXRpb24gKHZp cnRpby1ibGspLCB0aGUNCj4gPiBmb2xsb3dpbmcNCj4gPiA+ID4gPiA+IGluZm9ybWF0aW9uDQo+ ID4gPiA+ID4gPiA+ID4gPiBpcw0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+IGV4cGVjdGVkDQo+ID4g PiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gdG8gYmUgZXhwb3NlZCB0byBCRSB2aWEgWGVuc3RvcmU6 DQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gKEkga25vdyB0aGF0IHRoaXMgaXMgYSB0ZW50 YXRpdmUgYXBwcm9hY2gNCj4gdGhvdWdoLikNCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiAg ICAtIHRoZSBzdGFydCBhZGRyZXNzIG9mIGNvbmZpZ3VyYXRpb24gc3BhY2UNCj4gPiA+ID4gPiA+ ID4gPiA+ID4gPiA+ID4gPiAgICAtIGludGVycnVwdCBudW1iZXINCj4gPiA+ID4gPiA+ID4gPiA+ ID4gPiA+ID4gPiAgICAtIGZpbGUgcGF0aCBmb3IgYmFja2luZyBzdG9yYWdlDQo+ID4gPiA+ID4g PiA+ID4gPiA+ID4gPiA+ID4gICAgLSByZWFkLW9ubHkgZmxhZw0KPiA+ID4gPiA+ID4gPiA+ID4g PiA+ID4gPiA+IEFuZCB0aGUgQkUgc2VydmVyIGhhdmUgdG8gY2FsbCBhIHBhcnRpY3VsYXINCj4g PiBoeXBlcnZpc29yDQo+ID4gPiA+ID4gPiBpbnRlcmZhY2UNCj4gPiA+ID4gPiA+ID4gPiA+IHRv DQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gbWFwIHRoZSBjb25maWd1cmF0aW9uIHNwYWNl Lg0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPg0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiBZ ZXMsIFhlbnN0b3JlIHdhcyBjaG9zZW4gYXMgYSBzaW1wbGUgd2F5IHRvIHBhc3MNCj4gPiA+ID4g PiA+IGNvbmZpZ3VyYXRpb24NCj4gPiA+ID4gPiA+ID4gPiA+IGluZm8gdG8NCj4gPiA+ID4gPiA+ ID4gPiA+ID4gPiB0aGUgYmFja2VuZCBydW5uaW5nIGluIGEgbm9uLXRvb2xzdGFjayBkb21haW4u DQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+IEkgcmVtZW1iZXIsIHRoZXJlIHdhcyBhIHdpc2gg dG8gYXZvaWQgdXNpbmcNCj4gWGVuc3RvcmUNCj4gPiBpbg0KPiA+ID4gPiA+ID4gVmlydGlvDQo+ ID4gPiA+ID4gPiA+ID4gPiBiYWNrZW5kDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gaXRzZWxmIGlm IHBvc3NpYmxlLCBzbyBmb3Igbm9uLXRvb2xzdGFjayBkb21haW4sIHRoaXMNCj4gPiBjb3VsZA0K PiA+ID4gPiBkb25lDQo+ID4gPiA+ID4gPiB3aXRoDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gYWRq dXN0aW5nIGRldmQgKGRhZW1vbiB0aGF0IGxpc3RlbnMgZm9yIGRldmljZXMgYW5kDQo+ID4gbGF1 bmNoZXMNCj4gPiA+ID4gPiA+IGJhY2tlbmRzKQ0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiB0 byByZWFkIGJhY2tlbmQgY29uZmlndXJhdGlvbiBmcm9tIHRoZSBYZW5zdG9yZQ0KPiA+IGFueXdh eQ0KPiA+ID4gPiBhbmQNCj4gPiA+ID4gPiA+IHBhc3MgaXQNCj4gPiA+ID4gPiA+ID4gPiA+IHRv DQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gdGhlIGJhY2tlbmQgdmlhIGNvbW1hbmQgbGluZSBhcmd1 bWVudHMuDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+DQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4g Pg0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gWWVzLCBpbiBjdXJyZW50IFBvQyBjb2RlIHdlJ3Jl IHVzaW5nIHhlbnN0b3JlIHRvDQo+IHBhc3MNCj4gPiA+ID4gZGV2aWNlDQo+ID4gPiA+ID4gPiA+ ID4gPiA+ID4gY29uZmlndXJhdGlvbi4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+IFdlIGFsc28g ZGVzaWduZWQgYSBzdGF0aWMgZGV2aWNlIGNvbmZpZ3VyYXRpb24gcGFyc2UNCj4gPiA+ID4gbWV0 aG9kDQo+ID4gPiA+ID4gPiBmb3INCj4gPiA+ID4gPiA+ID4gPiA+IERvbTBsZXNzDQo+ID4gPiA+ ID4gPiA+ID4gPiA+ID4gb3INCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+IG90aGVyIHNjZW5hcmlv cyBkb24ndCBoYXZlIHhlbnRvb2wuIHllcywgaXQncyBmcm9tDQo+ID4gZGV2aWNlDQo+ID4gPiA+ ID4gPiBtb2RlbA0KPiA+ID4gPiA+ID4gPiA+ID4gY29tbWFuZA0KPiA+ID4gPiA+ID4gPiA+ID4g PiA+IGxpbmUNCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+IG9yIGEgY29uZmlnIGZpbGUuDQo+ID4g PiA+ID4gPiA+ID4gPiA+ID4gPg0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiBCdXQsIGlmIC4u Lg0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPg0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ DQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gSW4gbXkgYXBwcm9hY2ggKHZpcnRpby1wcm94 eSksIGFsbCB0aG9zZSBYZW4gKG9yDQo+ID4gPiA+ID4gPiBoeXBlcnZpc29yKS0NCj4gPiA+ID4g PiA+ID4gPiA+ID4gPiBzcGVjaWZpYw0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+IHN0dWZm cyBhcmUgY29udGFpbmVkIGluIHZpcnRpby1wcm94eSwgeWV0DQo+IGFub3RoZXINCj4gPiBWTSwN Cj4gPiA+ID4gdG8NCj4gPiA+ID4gPiA+IGhpZGUNCj4gPiA+ID4gPiA+ID4gPiA+IGFsbA0KPiA+ ID4gPiA+ID4gPiA+ID4gPiA+IGRldGFpbHMuDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+DQo+ ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+IC4uLiB0aGUgc29sdXRpb24gaG93IHRvIG92ZXJjb21l IHRoYXQgaXMgYWxyZWFkeQ0KPiA+IGZvdW5kDQo+ID4gPiA+IGFuZA0KPiA+ID4gPiA+ID4gcHJv dmVuDQo+ID4gPiA+ID4gPiA+ID4gPiB0bw0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+IHdvcmsgdGhl biBldmVuIGJldHRlci4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4NCj4gPiA+ID4gPiA+ID4g PiA+ID4gPiA+ID4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4NCj4gPiA+ID4gPiA+ID4gPiA+ ID4gPiA+ID4gPiAjIE15IHBvaW50IGlzIHRoYXQgYSAiaGFuZGxlIiBpcyBub3QgbWFuZGF0b3J5 DQo+IGZvcg0KPiA+ID4gPiA+ID4gZXhlY3V0aW5nDQo+ID4gPiA+ID4gPiA+ID4gPiBtYXBwaW5n Lg0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+DQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ ID4gPiBhbmQgdGhlIG1hcHBpbmcgcHJvYmFibHkgZG9uZSBieSB0aGUNCj4gPiA+ID4gPiA+ID4g PiA+ID4gPiA+ID4gPiA+IHRvb2xzdGFjayAoYWxzbyBzZWUgYmVsb3cuKSBPciB3ZSB3b3VsZCBo YXZlDQo+IHRvDQo+ID4gPiA+IGludmVudCBhDQo+ID4gPiA+ID4gPiBuZXcNCj4gPiA+ID4gPiA+ ID4gPiA+IFhlbg0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gaHlwZXJ2aXNvciBpbnRl cmZhY2UgYW5kIFhlbiB2aXJ0dWFsIG1hY2hpbmUNCj4gPiA+ID4gcHJpdmlsZWdlcw0KPiA+ID4g PiA+ID4gdG8NCj4gPiA+ID4gPiA+ID4gPiA+IGFsbG93DQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4g dGhpcw0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4ga2luZCBvZiBtYXBwaW5nLg0KPiA+ ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+DQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiBJ ZiB3ZSBydW4gdGhlIGJhY2tlbmQgaW4gRG9tMCB0aGF0IHdlIGhhdmUgbm8NCj4gPiA+ID4gcHJv YmxlbXMNCj4gPiA+ID4gPiA+IG9mDQo+ID4gPiA+ID4gPiA+ID4gPiBjb3Vyc2UuDQo+ID4gPiA+ ID4gPiA+ID4gPiA+ID4gPiA+ID4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiBPbmUgb2Yg ZGlmZmljdWx0aWVzIG9uIFhlbiB0aGF0IEkgZm91bmQgaW4gbXkNCj4gPiBhcHByb2FjaA0KPiA+ ID4gPiBpcw0KPiA+ID4gPiA+ID4gdGhhdA0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+IGNhbGxpbmcN Cj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiBzdWNoIGh5cGVydmlzb3IgaW50ZWZhY2VzIChy ZWdpc3RlcmluZyBJT1JFUSwNCj4gPiBtYXBwaW5nDQo+ID4gPiA+ID4gPiBtZW1vcnkpIGlzDQo+ ID4gPiA+ID4gPiA+ID4gPiA+ID4gb25seQ0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+IGFs bG93ZWQgb24gQkUgc2VydmVycyB0aGVtc2VsdmllcyBhbmQgc28gd2Ugd2lsbA0KPiA+IGhhdmUN Cj4gPiA+ID4gdG8NCj4gPiA+ID4gPiA+IGV4dGVuZA0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+IHRo b3NlDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gaW50ZXJmYWNlcy4NCj4gPiA+ID4gPiA+ ID4gPiA+ID4gPiA+ID4gPiBUaGlzLCBob3dldmVyLCB3aWxsIHJhaXNlIHNvbWUgY29uY2VybiBv bg0KPiBzZWN1cml0eQ0KPiA+IGFuZA0KPiA+ID4gPiA+ID4gcHJpdmlsZWdlDQo+ID4gPiA+ID4g PiA+ID4gPiA+ID4gZGlzdHJpYnV0aW9uDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gYXMg U3RlZmFuIHN1Z2dlc3RlZC4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4NCj4gPiA+ID4gPiA+ ID4gPiA+ID4gPiA+ID4gV2UgYWxzbyBmYWNlZCBwb2xpY3kgcmVsYXRlZCBpc3N1ZXMgd2l0aCBW aXJ0aW8NCj4gPiBiYWNrZW5kDQo+ID4gPiA+ID4gPiBydW5uaW5nIGluDQo+ID4gPiA+ID4gPiA+ ID4gPiA+ID4gb3RoZXIgdGhhbiBEb20wIGRvbWFpbiBpbiBhICJkdW1teSIgeHNtIG1vZGUuIElu IG91cg0KPiA+IHRhcmdldA0KPiA+ID4gPiA+ID4gc3lzdGVtIHdlDQo+ID4gPiA+ID4gPiA+ID4g PiBydW4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiB0aGUgYmFja2VuZCBpbiBhIGRyaXZlcg0KPiA+ ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiBkb21haW4gKHdlIGNhbGwgaXQgRG9tRCkgd2hlcmUgdGhl IHVuZGVybHlpbmcgSC9XDQo+ID4gPiA+IHJlc2lkZXMuDQo+ID4gPiA+ID4gPiBXZQ0KPiA+ID4g PiA+ID4gPiA+ID4gdHJ1c3QgaXQsDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gc28gd2Ugd3JvdGUg cG9saWN5IHJ1bGVzICh0byBiZSB1c2VkIGluICJmbGFzayIgeHNtDQo+IG1vZGUpDQo+ID4gdG8N Cj4gPiA+ID4gPiA+IHByb3ZpZGUNCj4gPiA+ID4gPiA+ID4gPiA+IGl0DQo+ID4gPiA+ID4gPiA+ ID4gPiA+ID4gd2l0aCBhIGxpdHRsZSBiaXQgbW9yZSBwcml2aWxlZ2VzIHRoYW4gYSBzaW1wbGUg RG9tVQ0KPiBoYWQuDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+IE5vdyBpdCBpcyBwZXJtaXR0 ZWQgdG8gaXNzdWUgZGV2aWNlLW1vZGVsLA0KPiByZXNvdXJjZQ0KPiA+IGFuZA0KPiA+ID4gPiA+ ID4gbWVtb3J5DQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gbWFwcGluZ3MsIGV0YyBjYWxscy4NCj4g PiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+DQo+ ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPg0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ ID4gPiBUbyBhY3RpdmF0ZSB0aGUgbWFwcGluZyB3aWxsDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4g PiA+ID4gPiA+ICByZXF1aXJlIHNvbWUgc29ydCBvZiBoeXBlcmNhbGwgdG8gdGhlDQo+ID4gaHlw ZXJ2aXNvci4NCj4gPiA+ID4gSQ0KPiA+ID4gPiA+ID4gY2FuIHNlZQ0KPiA+ID4gPiA+ID4gPiA+ ID4gdHdvDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gb3B0aW9ucw0KPiA+ID4gPiA+ID4gPiA+ID4g PiA+ID4gPiA+ID4gPiAgYXQgdGhpcyBwb2ludDoNCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4g PiA+ID4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gICAtIGV4cG9zZSB0aGUgaGFu ZGxlIHRvIHVzZXJzcGFjZSBmb3INCj4gPiA+ID4gZGFlbW9uL2hlbHBlcg0KPiA+ID4gPiA+ID4g dG8NCj4gPiA+ID4gPiA+ID4gPiA+IHRyaWdnZXINCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiB0aGUN Cj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gICAgIG1hcHBpbmcgdmlhIGV4aXN0aW5n IGh5cGVyY2FsbA0KPiBpbnRlcmZhY2VzLg0KPiA+IElmDQo+ID4gPiA+ID4gPiB1c2luZyBhDQo+ ID4gPiA+ID4gPiA+ID4gPiBoZWxwZXINCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiB5b3UNCj4gPiA+ ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gICAgIHdvdWxkIGhhdmUgYSBoeXBlcnZpc29yIHNw ZWNpZmljIG9uZSB0bw0KPiA+IGF2b2lkDQo+ID4gPiA+IHRoZQ0KPiA+ID4gPiA+ID4gZGFlbW9u DQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gaGF2aW5nIHRvDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4g PiA+ID4gPiA+ICAgICBjYXJlIHRvbyBtdWNoIGFib3V0IHRoZSBkZXRhaWxzIG9yIHB1c2gNCj4g PiB0aGF0DQo+ID4gPiA+ID4gPiBjb21wbGV4aXR5DQo+ID4gPiA+ID4gPiA+ID4gPiBpbnRvDQo+ ID4gPiA+ID4gPiA+ID4gPiA+ID4gYQ0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiAg ICAgY29tcGlsZSB0aW1lIG9wdGlvbiBmb3IgdGhlIGRhZW1vbiB3aGljaA0KPiA+IHdvdWxkDQo+ ID4gPiA+ID4gPiByZXN1bHQgaW4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiBkaWZmZXJlbnQNCj4g PiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gICAgIGJpbmFyaWVzIGFsdGhvdWdoIGEgY29t bW9uIHNvdXJjZSBiYXNlLg0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPg0KPiA+ID4g PiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiAgIC0gZXhwb3NlIGEgbmV3IGtlcm5lbCBBQkkgdG8g YWJzdHJhY3QgdGhlDQo+ID4gPiA+IGh5cGVyY2FsbA0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+IGRp ZmZlcmVuY2VzIGF3YXkNCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gICAgIGluIHRo ZSBndWVzdCBrZXJuZWwuIEluIHRoaXMgY2FzZSB0aGUNCj4gPiA+ID4gdXNlcnNwYWNlDQo+ID4g PiA+ID4gPiB3b3VsZA0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+IGVzc2VudGlhbGx5DQo+ID4gPiA+ ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ICAgICBhc2sgZm9yIGFuIGFic3RyYWN0ICJtYXAgZ3Vl c3QgTiBtZW1vcnkNCj4gdG8NCj4gPiA+ID4gPiA+IHVzZXJzcGFjZQ0KPiA+ID4gPiA+ID4gPiA+ ID4gcHRyIg0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+IGFuZCBsZXQNCj4gPiA+ID4gPiA+ID4gPiA+ ID4gPiA+ID4gPiA+ID4gICAgIHRoZSBrZXJuZWwgZGVhbCB3aXRoIHRoZSBkaWZmZXJlbnQNCj4g PiBoeXBlcmNhbGwNCj4gPiA+ID4gPiA+IGludGVyZmFjZXMuDQo+ID4gPiA+ID4gPiA+ID4gPiA+ ID4gVGhpcyBvZg0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiAgICAgY291cnNlIGFz c3VtZXMgdGhlIG1ham9yaXR5IG9mIEJFIGd1ZXN0cw0KPiA+IHdvdWxkDQo+ID4gPiA+IGJlDQo+ ID4gPiA+ID4gPiBMaW51eA0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+IGtlcm5lbHMgYW5kDQo+ID4g PiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ICAgICBsZWF2ZXMgdGhlIGJhcmUtbWV0YWwvdW5p a2VybmVsDQo+IGFwcHJvYWNoZXMNCj4gPiB0bw0KPiA+ID4gPiA+ID4gdGhlaXIgb3duDQo+ID4g PiA+ID4gPiA+ID4gPiA+ID4gZGV2aWNlcy4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ ID4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gT3BlcmF0aW9uDQo+ID4gPiA+ID4g PiA+ID4gPiA+ID4gPiA+ID4gPiA+ID09PT09PT09PQ0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4g PiA+ID4gPg0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiBUaGUgY29yZSBvZiB0aGUg b3BlcmF0aW9uIG9mIFZpcnRJTyBpcw0KPiBmYWlybHkNCj4gPiA+ID4gc2ltcGxlLg0KPiA+ID4g PiA+ID4gT25jZQ0KPiA+ID4gPiA+ID4gPiA+ID4gdGhlDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4g PiA+ID4gPiA+IHZob3N0LXVzZXIgZmVhdHVyZSBuZWdvdGlhdGlvbiBpcyBkb25lIGl0J3MNCj4g YQ0KPiA+IGNhc2UNCj4gPiA+ID4gb2YNCj4gPiA+ID4gPiA+ID4gPiA+IHJlY2VpdmluZw0KPiA+ ID4gPiA+ID4gPiA+ID4gPiA+IHVwZGF0ZQ0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4g PiBldmVudHMgYW5kIHBhcnNpbmcgdGhlIHJlc3VsdGFudCB2aXJ0IHF1ZXVlDQo+ID4gZm9yDQo+ ID4gPiA+IGRhdGEuDQo+ID4gPiA+ID4gPiBUaGUNCj4gPiA+ID4gPiA+ID4gPiA+IHZob3N0LQ0K PiA+ID4gPiA+ID4gPiA+ID4gPiA+IHVzZXINCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ ID4gc3BlY2lmaWNhdGlvbiBoYW5kbGVzIGEgYnVuY2ggb2Ygc2V0dXANCj4gYmVmb3JlDQo+ID4g dGhhdA0KPiA+ID4gPiA+ID4gcG9pbnQsDQo+ID4gPiA+ID4gPiA+ID4gPiBtb3N0bHkNCj4gPiA+ ID4gPiA+ID4gPiA+ID4gPiB0bw0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiBkZXRh aWwgd2hlcmUgdGhlIHZpcnQgcXVldWVzIGFyZSBzZXQgdXAgRkQncw0KPiA+IGZvcg0KPiA+ID4g PiA+ID4gbWVtb3J5IGFuZA0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+IGV2ZW50DQo+ID4gPiA+ID4g PiA+ID4gPiA+ID4gPiA+ID4gPiA+IGNvbW11bmljYXRpb24uIFRoaXMgaXMgd2hlcmUgdGhlIGVu dmlzaW9uZWQNCj4gPiBzdHViDQo+ID4gPiA+ID4gPiBwcm9jZXNzDQo+ID4gPiA+ID4gPiA+ID4g PiB3b3VsZA0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+IGJlDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4g PiA+ID4gPiA+IHJlc3BvbnNpYmxlIGZvciBnZXR0aW5nIHRoZSBkYWVtb24gdXAgYW5kDQo+ID4g cmVhZHkgdG8NCj4gPiA+ID4gcnVuLg0KPiA+ID4gPiA+ID4gVGhpcw0KPiA+ID4gPiA+ID4gPiA+ ID4gaXMNCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gY3VycmVudGx5IGRvbmUgaW5z aWRlIGEgYmlnIFZNTSBsaWtlIFFFTVUNCj4gYnV0DQo+ID4gSQ0KPiA+ID4gPiA+ID4gc3VzcGVj dCBhDQo+ID4gPiA+ID4gPiA+ID4gPiBtb2Rlcm4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4g PiA+ID4gYXBwcm9hY2ggd291bGQgYmUgdG8gdXNlIHRoZSBydXN0LXZtbSB2aG9zdA0KPiA+IGNy YXRlLg0KPiA+ID4gPiBJdA0KPiA+ID4gPiA+ID4gd291bGQNCj4gPiA+ID4gPiA+ID4gPiA+IHRo ZW4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiBlaXRoZXINCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ ID4gPiA+ID4gY29tbXVuaWNhdGUgd2l0aCB0aGUga2VybmVsJ3MgYWJzdHJhY3RlZCBBQkkNCj4g PiBvciBiZQ0KPiA+ID4gPiByZS0NCj4gPiA+ID4gPiA+ID4gPiA+IHRhcmdldGVkDQo+ID4gPiA+ ID4gPiA+ID4gPiA+ID4gYXMgYQ0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiBidWls ZCBvcHRpb24gZm9yIHRoZSB2YXJpb3VzIGh5cGVydmlzb3JzLg0KPiA+ID4gPiA+ID4gPiA+ID4g PiA+ID4gPiA+ID4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+IE9uZSB0aGluZyBJIG1l bnRpb25lZCBiZWZvcmUgdG8gQWxleCBpcyB0aGF0DQo+IFhlbg0KPiA+ID4gPiBkb2Vzbid0DQo+ ID4gPiA+ID4gPiBoYXZlDQo+ID4gPiA+ID4gPiA+ID4gPiBWTU1zDQo+ID4gPiA+ID4gPiA+ID4g PiA+ID4gdGhlDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiB3YXkgdGhleSBhcmUgdHlw aWNhbGx5IGVudmlzaW9uZWQgYW5kDQo+IGRlc2NyaWJlZA0KPiA+IGluDQo+ID4gPiA+IG90aGVy DQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gZW52aXJvbm1lbnRzLg0KPiA+ID4gPiA+ID4gPiA+ID4g PiA+ID4gPiA+ID4gSW5zdGVhZCwgWGVuIGhhcyBJT1JFUSBzZXJ2ZXJzLiBFYWNoIG9mIHRoZW0N Cj4gPiA+ID4gY29ubmVjdHMNCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiBpbmRlcGVuZGVudGx5IHRv DQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiBYZW4gdmlhIHRoZSBJT1JFUSBpbnRlcmZh Y2UuIEUuZy4gdG9kYXkNCj4gbXVsdGlwbGUNCj4gPiA+ID4gUUVNVXMNCj4gPiA+ID4gPiA+IGNv dWxkDQo+ID4gPiA+ID4gPiA+ID4gPiBiZQ0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+IHVzZWQgYXMN Cj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+IGVtdWxhdG9ycyBmb3IgYSBzaW5nbGUgWGVu IFZNLCBlYWNoIG9mIHRoZW0NCj4gPiA+ID4gY29ubmVjdGluZw0KPiA+ID4gPiA+ID4gdG8gWGVu DQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiBpbmRlcGVuZGVudGx5IHZpYSB0aGUgSU9S RVEgaW50ZXJmYWNlLg0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4NCj4gPiA+ID4gPiA+ ID4gPiA+ID4gPiA+ID4gPiA+IFRoZSBjb21wb25lbnQgcmVzcG9uc2libGUgZm9yIHN0YXJ0aW5n IGENCj4gZGFlbW9uDQo+ID4gPiA+IGFuZC9vcg0KPiA+ID4gPiA+ID4gc2V0dGluZw0KPiA+ID4g PiA+ID4gPiA+ID4gdXANCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiBzaGFyZWQNCj4gPiA+ID4gPiA+ ID4gPiA+ID4gPiA+ID4gPiA+IGludGVyZmFjZXMgaXMgdGhlIHRvb2xzdGFjazogdGhlIHhsIGNv bW1hbmQNCj4gYW5kDQo+ID4gdGhlDQo+ID4gPiA+ID4gPiA+ID4gPiBsaWJ4bC9saWJ4Yw0KPiA+ ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gbGlicmFyaWVzLg0KPiA+ID4gPiA+ID4gPiA+ID4g PiA+ID4gPiA+DQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gSSB0aGluayB0aGF0IFZNIGNv bmZpZ3VyYXRpb24gbWFuYWdlbWVudCAob3INCj4gPiA+ID4gb3JjaGVzdHJhdGlvbg0KPiA+ID4g PiA+ID4gaW4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiBTdGFydG9zDQo+ID4gPiA+ID4gPiA+ID4g PiA+ID4gPiA+ID4gamFyZ29uPykgaXMgYSBzdWJqZWN0IHRvIGRlYmF0ZSBpbiBwYXJhbGxlbC4N Cj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiBPdGhlcndpc2UsIGlzIHRoZXJlIGFueSBnb29k IGFzc3VtcHRpb24gdG8gYXZvaWQNCj4gPiBpdA0KPiA+ID4gPiByaWdodA0KPiA+ID4gPiA+ID4g bm93Pw0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+DQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4g PiA+ID4gPiBPbGVrc2FuZHIgYW5kIG90aGVycyBJIENDZWQgaGF2ZSBiZWVuIHdvcmtpbmcNCj4g b24NCj4gPiA+ID4gd2F5cw0KPiA+ID4gPiA+ID4gZm9yIHRoZQ0KPiA+ID4gPiA+ID4gPiA+ID4g PiA+IHRvb2xzdGFjaw0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gdG8gY3JlYXRlIHZp cnRpbyBiYWNrZW5kcyBhbmQgc2V0dXAgbWVtb3J5DQo+ID4gbWFwcGluZ3MuDQo+ID4gPiA+ID4g PiBUaGV5DQo+ID4gPiA+ID4gPiA+ID4gPiBtaWdodCBiZQ0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ IGFibGUNCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+IHRvIHByb3ZpZGUgbW9yZSBpbmZv IG9uIHRoZSBzdWJqZWN0LiBJIGRvDQo+IHRoaW5rDQo+ID4gd2UNCj4gPiA+ID4gbWlzcw0KPiA+ ID4gPiA+ID4gYSB3YXkNCj4gPiA+ID4gPiA+ID4gPiA+IHRvDQo+ID4gPiA+ID4gPiA+ID4gPiA+ ID4gcHJvdmlkZQ0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gdGhlIGNvbmZpZ3VyYXRp b24gdG8gdGhlIGJhY2tlbmQgYW5kIGFueXRoaW5nDQo+ID4gZWxzZQ0KPiA+ID4gPiB0aGF0DQo+ ID4gPiA+ID4gPiB0aGUNCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiBiYWNrZW5kDQo+ID4gPiA+ID4g PiA+ID4gPiA+ID4gPiA+ID4gPiBtaWdodCByZXF1aXJlIHRvIHN0YXJ0IGRvaW5nIGl0cyBqb2Iu DQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+DQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+IFll cywgc29tZSB3b3JrIGhhcyBiZWVuIGRvbmUgZm9yIHRoZSB0b29sc3RhY2sgdG8NCj4gPiBoYW5k bGUNCj4gPiA+ID4gPiA+IFZpcnRpbw0KPiA+ID4gPiA+ID4gPiA+ID4gTU1JTw0KPiA+ID4gPiA+ ID4gPiA+ID4gPiA+IGRldmljZXMgaW4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gZ2VuZXJh bCBhbmQgVmlydGlvIGJsb2NrIGRldmljZXMgaW4gcGFydGljdWxhci4NCj4gPiBIb3dldmVyLA0K PiA+ID4gPiBpdA0KPiA+ID4gPiA+ID4gaGFzDQo+ID4gPiA+ID4gPiA+ID4gPiBub3QNCj4gPiA+ ID4gPiA+ID4gPiA+ID4gPiBiZWVuIHVwc3RyZWFuZWQgeWV0Lg0KPiA+ID4gPiA+ID4gPiA+ID4g PiA+ID4gPiBVcGRhdGVkIHBhdGNoZXMgb24gcmV2aWV3IG5vdzoNCj4gPiA+ID4gPiA+ID4gPiA+ ID4gPiA+ID4gaHR0cHM6Ly9sb3JlLmtlcm5lbC5vcmcveGVuLWRldmVsLzE2MjE2MjYzNjEtDQo+ IDI5MDc2LQ0KPiA+IDEtDQo+ID4gPiA+IGdpdC0NCj4gPiA+ID4gPiA+IHNlbmQtDQo+ID4gPiA+ ID4gPiA+ID4gPiBlbWFpbC0NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiBvbGVrc3R5c2hAZ21haWwu Y29tLw0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPg0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4g PiBUaGVyZSBpcyBhbiBhZGRpdGlvbmFsIChhbHNvIGltcG9ydGFudCkgYWN0aXZpdHkNCj4gdG8N Cj4gPiA+ID4gPiA+IGltcHJvdmUvZml4DQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gZm9yZWlnbiBt ZW1vcnkgbWFwcGluZyBvbiBBcm0gd2hpY2ggSSBhbSBhbHNvIGludm9sdmVkDQo+ID4gaW4uDQo+ ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+IFRoZSBmb3JlaWduIG1lbW9yeSBtYXBwaW5nIGlzIHBy b3Bvc2VkIHRvIGJlIHVzZWQNCj4gPiBmb3INCj4gPiA+ID4gVmlydGlvDQo+ID4gPiA+ID4gPiA+ ID4gPiBiYWNrZW5kcw0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+IChkZXZpY2UgZW11bGF0b3JzKSBp ZiB0aGVyZSBpcyBhIG5lZWQgdG8gcnVuIGd1ZXN0IE9TDQo+ID4gPiA+IGNvbXBsZXRlbHkNCj4g PiA+ID4gPiA+ID4gPiA+ID4gPiB1bm1vZGlmaWVkLg0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4g PiBPZiBjb3Vyc2UsIHRoZSBtb3JlIHNlY3VyZSB3YXkgd291bGQgYmUgdG8gdXNlDQo+IGdyYW50 DQo+ID4gPiA+IG1lbW9yeQ0KPiA+ID4gPiA+ID4gPiA+ID4gbWFwcGluZy4NCj4gPiA+ID4gPiA+ ID4gPiA+ID4gPiBCcmlldGx5LCB0aGUgbWFpbiBkaWZmZXJlbmNlIGJldHdlZW4gdGhlbSBpcyB0 aGF0IHdpdGgNCj4gPiA+ID4gZm9yZWlnbg0KPiA+ID4gPiA+ID4gbWFwcGluZw0KPiA+ID4gPiA+ ID4gPiA+ID4gdGhlDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gYmFja2VuZA0KPiA+ID4gPiA+ID4g PiA+ID4gPiA+ID4gPiBjYW4gbWFwIGFueSBndWVzdCBtZW1vcnkgaXQgd2FudHMgdG8gbWFwLCBi dXQgd2l0aA0KPiA+IGdyYW50DQo+ID4gPiA+ID4gPiBtYXBwaW5nDQo+ID4gPiA+ID4gPiA+ID4g PiBpdCBpcw0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+IGFsbG93ZWQgdG8gbWFwIG9ubHkgd2hhdCB3 YXMgcHJldmlvdXNseSBncmFudGVkIGJ5IHRoZQ0KPiA+ID4gPiBmcm9udGVuZC4NCj4gPiA+ID4g PiA+ID4gPiA+ID4gPiA+ID4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gU28sIHRoZXJlIG1p Z2h0IGJlIGEgcHJvYmxlbSBpZiB3ZSB3YW50IHRvIHByZS1tYXANCj4gPiBzb21lDQo+ID4gPiA+ ID4gPiBndWVzdA0KPiA+ID4gPiA+ID4gPiA+ID4gbWVtb3J5DQo+ID4gPiA+ID4gPiA+ID4gPiA+ ID4gaW4gYWR2YW5jZSBvciB0byBjYWNoZSBtYXBwaW5ncyBpbiB0aGUgYmFja2VuZCBpbg0KPiBv cmRlcg0KPiA+IHRvDQo+ID4gPiA+ID4gPiBpbXByb3ZlDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4g cGVyZm9ybWFuY2UgKGJlY2F1c2UgdGhlIG1hcHBpbmcvdW5tYXBwaW5nIGd1ZXN0IHBhZ2VzDQo+ ID4gZXZlcnkNCj4gPiA+ID4gPiA+IHJlcXVlc3QNCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiByZXF1 aXJlcyBhIGxvdCBvZiBiYWNrIGFuZCBmb3J0aCB0byBYZW4gKyBQMk0gdXBkYXRlcykuDQo+ID4g SW4gYQ0KPiA+ID4gPiA+ID4gbnV0c2hlbGwsDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gY3VycmVu dGx5LCBpbiBvcmRlciB0byBtYXAgYSBndWVzdCBwYWdlIGludG8gdGhlDQo+IGJhY2tlbmQNCj4g PiA+ID4gYWRkcmVzcw0KPiA+ID4gPiA+ID4gc3BhY2UNCj4gPiA+ID4gPiA+ID4gPiA+IHdlDQo+ ID4gPiA+ID4gPiA+ID4gPiA+ID4gbmVlZCB0byBzdGVhbCBhIHJlYWwgcGh5c2ljYWwgcGFnZSBm cm9tIHRoZSBiYWNrZW5kDQo+ID4gZG9tYWluLg0KPiA+ID4gPiBTbywNCj4gPiA+ID4gPiA+IHdp dGgNCj4gPiA+ID4gPiA+ID4gPiA+IHRoZQ0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+IHNhaWQgb3B0 aW1pemF0aW9ucyB3ZSBtaWdodCBlbmQgdXAgd2l0aCBubyBmcmVlIG1lbW9yeQ0KPiA+IGluDQo+ ID4gPiA+IHRoZQ0KPiA+ID4gPiA+ID4gYmFja2VuZA0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+IGRv bWFpbiAoc2VlIFhTQS0zMDApLiBBbmQgd2hhdCB3ZSB0cnkgdG8gYWNoaWV2ZSBpcyB0bw0KPiA+ IG5vdA0KPiA+ID4gPiB3YXN0ZQ0KPiA+ID4gPiA+ID4gYQ0KPiA+ID4gPiA+ID4gPiA+ID4gcmVh bA0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+IGRvbWFpbiBtZW1vcnkgYXQgYWxsIGJ5IHByb3ZpZGlu ZyBzYWZlIG5vbi1hbGxvY2F0ZWQtDQo+IHlldA0KPiA+IChzbw0KPiA+ID4gPiA+ID4gdW51c2Vk KQ0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+IGFkZHJlc3Mgc3BhY2UgZm9yIHRoZSBmb3JlaWduIChh bmQgZ3JhbnQpIHBhZ2VzIHRvIGJlDQo+ID4gbWFwcGVkDQo+ID4gPiA+ID4gPiBpbnRvLA0KPiA+ ID4gPiA+ID4gPiA+ID4gdGhpcw0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+IGVuYWJsaW5nIHdvcmsg aW1wbGllcyBYZW4gYW5kIExpbnV4IChhbmQgbGlrZWx5IERUQg0KPiA+IGJpbmRpbmdzKQ0KPiA+ ID4gPiA+ID4gY2hhbmdlcy4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiBIb3dldmVyLCBhcyBpdCB0 dXJuZWQgb3V0LCBmb3IgdGhpcyB0byB3b3JrIGluIGENCj4gcHJvcGVyDQo+ID4gYW5kDQo+ID4g PiA+IHNhZmUNCj4gPiA+ID4gPiA+IHdheQ0KPiA+ID4gPiA+ID4gPiA+ID4gc29tZQ0KPiA+ID4g PiA+ID4gPiA+ID4gPiA+IHByZXJlcSB3b3JrIG5lZWRzIHRvIGJlIGRvbmUuDQo+ID4gPiA+ID4g PiA+ID4gPiA+ID4gPiA+IFlvdSBjYW4gZmluZCB0aGUgcmVsYXRlZCBYZW4gZGlzY3Vzc2lvbiBh dDoNCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gaHR0cHM6Ly9sb3JlLmtlcm5lbC5vcmcveGVu LWRldmVsLzE2Mjc0ODkxMTAtDQo+IDI1NjMzLQ0KPiA+IDEtDQo+ID4gPiA+IGdpdC0NCj4gPiA+ ID4gPiA+IHNlbmQtDQo+ID4gPiA+ID4gPiA+ID4gPiBlbWFpbC0NCj4gPiA+ID4gPiA+ID4gPiA+ ID4gPiBvbGVrc3R5c2hAZ21haWwuY29tLw0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPg0KPiA+ ID4gPiA+ID4gPiA+ID4gPiA+ID4gPg0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4NCj4g PiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+DQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4g PiA+IE9uZSBxdWVzdGlvbiBpcyBob3cgdG8gYmVzdCBoYW5kbGUNCj4gPiBub3RpZmljYXRpb24N Cj4gPiA+ID4gYW5kDQo+ID4gPiA+ID4gPiBraWNrcy4NCj4gPiA+ID4gPiA+ID4gPiA+IFRoZQ0K PiA+ID4gPiA+ID4gPiA+ID4gPiA+IGV4aXN0aW5nDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ ID4gPiA+IHZob3N0LXVzZXIgZnJhbWV3b3JrIHVzZXMgZXZlbnRmZCB0byBzaWduYWwNCj4gPiB0 aGUNCj4gPiA+ID4gZGFlbW9uDQo+ID4gPiA+ID4gPiA+ID4gPiAoYWx0aG91Z2gNCj4gPiA+ID4g PiA+ID4gPiA+ID4gPiBRRU1VDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+IGlzIHF1 aXRlIGNhcGFibGUgb2Ygc2ltdWxhdGluZyB0aGVtIHdoZW4geW91DQo+ID4gdXNlDQo+ID4gPiA+ IFRDRykuDQo+ID4gPiA+ID4gPiBYZW4NCj4gPiA+ID4gPiA+ID4gPiA+IGhhcw0KPiA+ID4gPiA+ ID4gPiA+ID4gPiA+IGl0J3Mgb3duDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+IElP UkVRIG1lY2hhbmlzbS4gSG93ZXZlciBsYXRlbmN5IGlzIGFuDQo+ID4gaW1wb3J0YW50DQo+ID4g PiA+ID4gPiBmYWN0b3IgYW5kDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gaGF2aW5nDQo+ID4gPiA+ ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+IGV2ZW50cyBnbyB0aHJvdWdoIHRoZSBzdHViIHdvdWxk IGFkZCBxdWl0ZSBhDQo+ID4gbG90Lg0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4NCj4g PiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+IFllYWggSSB0aGluaywgcmVnYXJkbGVzcyBvZiBh bnl0aGluZyBlbHNlLCB3ZQ0KPiA+IHdhbnQNCj4gPiA+ID4gdGhlDQo+ID4gPiA+ID4gPiA+ID4g PiBiYWNrZW5kcyB0bw0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gY29ubmVjdCBkaXJl Y3RseSB0byB0aGUgWGVuIGh5cGVydmlzb3IuDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4N Cj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiBJbiBteSBhcHByb2FjaCwNCj4gPiA+ID4gPiA+ ID4gPiA+ID4gPiA+ID4gPiAgYSkgQkUgLT4gRkU6IGludGVycnVwdHMgdHJpZ2dlcmVkIGJ5IEJF IGNhbGxpbmcNCj4gYQ0KPiA+ID4gPiA+ID4gaHlwZXJ2aXNvcg0KPiA+ID4gPiA+ID4gPiA+ID4g PiA+IGludGVyZmFjZQ0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ICAgICAgICAgICAgICAg dmlhIHZpcnRpby1wcm94eQ0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ICBiKSBGRSAtPiBC RTogTU1JTyB0byBjb25maWcgcmFpc2VzIGV2ZW50cyAoaW4NCj4gPiBldmVudA0KPiA+ID4gPiA+ ID4gY2hhbm5lbHMpLA0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+IHdoaWNoIGlzDQo+ID4gPiA+ID4g PiA+ID4gPiA+ID4gPiA+ID4gICAgICAgICAgICAgICBjb252ZXJ0ZWQgdG8gYSBjYWxsYmFjayB0 byBCRSB2aWENCj4gPiA+ID4gdmlydGlvLQ0KPiA+ID4gPiA+ID4gcHJveHkNCj4gPiA+ID4gPiA+ ID4gPiA+ID4gPiA+ID4gPiAgICAgICAgICAgICAgIChYZW4ncyBldmVudCBjaGFubmVsIGlzDQo+ IGludGVybm5hbGx5DQo+ID4gPiA+ID4gPiBpbXBsZW1lbnRlZCBieQ0KPiA+ID4gPiA+ID4gPiA+ ID4gPiA+IGludGVycnVwdHMuKQ0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+DQo+ID4gPiA+ ID4gPiA+ID4gPiA+ID4gPiA+ID4gSSBkb24ndCBrbm93IHdoYXQgImNvbm5lY3QgZGlyZWN0bHki IG1lYW5zIGhlcmUsDQo+ID4gYnV0DQo+ID4gPiA+ID4gPiBzZW5kaW5nDQo+ID4gPiA+ID4gPiA+ ID4gPiA+ID4gaW50ZXJydXB0cw0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+IHRvIHRoZSBv cHBvc2l0ZSBzaWRlIHdvdWxkIGJlIGJlc3QgZWZmaWNpZW50Lg0KPiA+ID4gPiA+ID4gPiA+ID4g PiA+ID4gPiA+IEl2c2htZW0sIEkgc3VwcG9zZSwgdGFrZXMgdGhpcyBhcHByb2FjaCBieQ0KPiA+ IHV0aWxpemluZw0KPiA+ID4gPiBQQ0kncw0KPiA+ID4gPiA+ID4gbXNpLXgNCj4gPiA+ID4gPiA+ ID4gPiA+ID4gPiBtZWNoYW5pc20uDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+DQo+ID4gPiA+ ID4gPiA+ID4gPiA+ID4gPiA+IEFncmVlIHRoYXQgTVNJIHdvdWxkIGJlIG1vcmUgZWZmaWNpZW50 IHRoYW4gU1BJLi4uDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+IEF0IHRoZSBtb21lbnQsIGlu IG9yZGVyIHRvIG5vdGlmeSB0aGUgZnJvbnRlbmQsDQo+IHRoZQ0KPiA+ID4gPiBiYWNrZW5kDQo+ ID4gPiA+ID4gPiBpc3N1ZXMNCj4gPiA+ID4gPiA+ID4gPiA+IGENCj4gPiA+ID4gPiA+ID4gPiA+ ID4gPiBzcGVjaWZpYyBkZXZpY2UtbW9kZWwgY2FsbCB0byBxdWVyeSBYZW4gdG8gaW5qZWN0IGEN Cj4gPiA+ID4gPiA+IGNvcnJlc3BvbmRpbmcgU1BJDQo+ID4gPiA+ID4gPiA+ID4gPiB0bw0KPiA+ ID4gPiA+ID4gPiA+ID4gPiA+IHRoZSBndWVzdC4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4N Cj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4NCj4g PiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+DQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4g PiA+IENvdWxkIHdlIGNvbnNpZGVyIHRoZSBrZXJuZWwgaW50ZXJuYWxseQ0KPiA+IGNvbnZlcnRp bmcNCj4gPiA+ID4gPiA+IElPUkVRDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gbWVzc2FnZXMgZnJv bQ0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiB0aGUgWGVuIGh5cGVydmlzb3IgdG8g ZXZlbnRmZCBldmVudHM/IFdvdWxkDQo+ID4gdGhpcw0KPiA+ID4gPiBzY2FsZQ0KPiA+ID4gPiA+ ID4gd2l0aA0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+IG90aGVyIGtlcm5lbA0KPiA+ID4gPiA+ID4g PiA+ID4gPiA+ID4gPiA+ID4gPiBoeXBlcmNhbGwgaW50ZXJmYWNlcz8NCj4gPiA+ID4gPiA+ID4g PiA+ID4gPiA+ID4gPiA+ID4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gU28gYW55 IHRob3VnaHRzIG9uIHdoYXQgZGlyZWN0aW9ucyBhcmUgd29ydGgNCj4gPiA+ID4gPiA+IGV4cGVy aW1lbnRpbmcNCj4gPiA+ID4gPiA+ID4gPiA+IHdpdGg/DQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4g PiA+ID4gPg0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gT25lIG9wdGlvbiB3ZSBzaG91 bGQgY29uc2lkZXIgaXMgZm9yIGVhY2gNCj4gPiBiYWNrZW5kIHRvDQo+ID4gPiA+ID4gPiBjb25u ZWN0DQo+ID4gPiA+ID4gPiA+ID4gPiB0bw0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+IFhlbiB2aWEN Cj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+IHRoZSBJT1JFUSBpbnRlcmZhY2UuIFdlIGNv dWxkIGdlbmVyYWxpemUgdGhlDQo+ID4gSU9SRVENCj4gPiA+ID4gPiA+IGludGVyZmFjZQ0KPiA+ ID4gPiA+ID4gPiA+ID4gYW5kDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gbWFrZSBpdA0KPiA+ID4g PiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gaHlwZXJ2aXNvciBhZ25vc3RpYy4gVGhlIGludGVyZmFj ZSBpcyByZWFsbHkNCj4gPiB0cml2aWFsDQo+ID4gPiA+IGFuZA0KPiA+ID4gPiA+ID4gZWFzeQ0K PiA+ID4gPiA+ID4gPiA+ID4gdG8NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiBhZGQuDQo+ID4gPiA+ ID4gPiA+ID4gPiA+ID4gPiA+ID4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiBBcyBJIHNh aWQgYWJvdmUsIG15IHByb3Bvc2FsIGRvZXMgdGhlIHNhbWUgdGhpbmcNCj4gPiB0aGF0DQo+ID4g PiA+IHlvdQ0KPiA+ID4gPiA+ID4gPiA+ID4gbWVudGlvbmVkDQo+ID4gPiA+ID4gPiA+ID4gPiA+ ID4gaGVyZSA6KQ0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+IFRoZSBkaWZmZXJlbmNlIGlz IHRoYXQgSSBkbyBjYWxsIGh5cGVydmlzb3INCj4gPiBpbnRlcmZhY2VzDQo+ID4gPiA+IHZpYQ0K PiA+ID4gPiA+ID4gPiA+ID4gdmlydGlvLQ0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+IHByb3h5Lg0K PiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+DQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4g PiBUaGUgb25seSBYZW4tc3BlY2lmaWMgcGFydCBpcyB0aGUgbm90aWZpY2F0aW9uDQo+ID4gPiA+ IG1lY2hhbmlzbSwNCj4gPiA+ID4gPiA+ID4gPiA+IHdoaWNoIGlzDQo+ID4gPiA+ID4gPiA+ID4g PiA+ID4gYW4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+IGV2ZW50IGNoYW5uZWwuIElm IHdlIHJlcGxhY2VkIHRoZSBldmVudA0KPiBjaGFubmVsDQo+ID4gd2l0aA0KPiA+ID4gPiA+ID4g c29tZXRoaW5nDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gZWxzZSB0aGUNCj4gPiA+ID4gPiA+ID4g PiA+ID4gPiA+ID4gPiA+IGludGVyZmFjZSB3b3VsZCBiZSBnZW5lcmljLiBTZWU6DQo+ID4gPiA+ ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiBodHRwczovL2dpdGxhYi5jb20veGVuLXByb2plY3QveGVu Ly0NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiAvYmxvYi9zdGFnaW5nL3hlbi9pbmNsdWRlL3B1Ymxp Yy9odm0vaW9yZXEuaCNMNTINCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+DQo+ID4gPiA+ ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiBJIGRvbid0IHRoaW5rIHRoYXQgdHJhbnNsYXRpbmcgSU9S RVFzIHRvDQo+IGV2ZW50ZmQNCj4gPiBpbg0KPiA+ID4gPiB0aGUNCj4gPiA+ID4gPiA+IGtlcm5l bA0KPiA+ID4gPiA+ID4gPiA+ID4gaXMNCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiBhDQo+ID4gPiA+ ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiBnb29kIGlkZWE6IGlmIGZlZWxzIGxpa2UgaXQgd291bGQg YmUgZXh0cmENCj4gPiA+ID4gY29tcGxleGl0eQ0KPiA+ID4gPiA+ID4gYW5kIHRoYXQNCj4gPiA+ ID4gPiA+ID4gPiA+IHRoZQ0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4ga2VybmVsIHNo b3VsZG4ndCBiZSBpbnZvbHZlZCBhcyB0aGlzIGlzIGENCj4gPiBiYWNrZW5kLQ0KPiA+ID4gPiA+ ID4gaHlwZXJ2aXNvcg0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+IGludGVyZmFjZS4NCj4gPiA+ID4g PiA+ID4gPiA+ID4gPiA+ID4gPg0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+IEdpdmVuIHRo YXQgd2UgbWF5IHdhbnQgdG8gaW1wbGVtZW50IEJFIGFzIGENCj4gYmFyZS0NCj4gPiBtZXRhbA0K PiA+ID4gPiA+ID4gPiA+ID4gYXBwbGljYXRpb24NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4g PiBhcyBJIGRpZCBvbiBaZXBoeXIsIEkgZG9uJ3QgdGhpbmsgdGhhdCB0aGUNCj4gPiB0cmFuc2xh dGlvbg0KPiA+ID4gPiA+ID4gd291bGQgbm90DQo+ID4gPiA+ID4gPiA+ID4gPiBiZQ0KPiA+ID4g PiA+ID4gPiA+ID4gPiA+ID4gPiA+IGEgYmlnIGlzc3VlLCBlc3BlY2lhbGx5IG9uIFJUT1Mncy4N Cj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiBJdCB3aWxsIGJlIHNvbWUga2luZCBvZiBhYnN0 cmFjdGlvbiBsYXllciBvZg0KPiA+IGludGVycnVwdA0KPiA+ID4gPiA+ID4gaGFuZGxpbmcNCj4g PiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiAob3Igbm90aGluZyBidXQgYSBjYWxsYmFjayBtZWNo YW5pc20pLg0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+DQo+ID4gPiA+ID4gPiA+ID4gPiA+ ID4gPiA+ID4gPiBBbHNvLCBldmVudGZkIGlzIHZlcnkgTGludXgtY2VudHJpYyBhbmQgd2UgYXJl DQo+ID4gPiA+IHRyeWluZyB0bw0KPiA+ID4gPiA+ID4gPiA+ID4gZGVzaWduIGFuDQo+ID4gPiA+ ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiBpbnRlcmZhY2UgdGhhdCBjb3VsZCB3b3JrIHdlbGwgZm9y IFJUT1NlcyB0b28uDQo+ID4gSWYgd2UNCj4gPiA+ID4gPiA+IHdhbnQgdG8NCj4gPiA+ID4gPiA+ ID4gPiA+IGRvDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiBzb21ldGhpbmcgZGlmZmVy ZW50LCBib3RoIE9TLWFnbm9zdGljIGFuZA0KPiA+ID4gPiBoeXBlcnZpc29yLQ0KPiA+ID4gPiA+ ID4gYWdub3N0aWMsDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gcGVyaGFwcw0KPiA+ID4gPiA+ID4g PiA+ID4gPiA+ID4gPiA+ID4gd2UgY291bGQgZGVzaWduIGEgbmV3IGludGVyZmFjZS4gT25lIHRo YXQNCj4gY291bGQNCj4gPiBiZQ0KPiA+ID4gPiA+ID4gPiA+ID4gaW1wbGVtZW50YWJsZQ0KPiA+ ID4gPiA+ID4gPiA+ID4gPiA+IGluIHRoZQ0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4g WGVuIGh5cGVydmlzb3IgaXRzZWxmIChsaWtlIElPUkVRKSBhbmQgb2YNCj4gY291cnNlDQo+ID4g YW55DQo+ID4gPiA+ID4gPiBvdGhlcg0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+IGh5cGVydmlzb3IN Cj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+IHRvby4NCj4gPiA+ID4gPiA+ID4gPiA+ID4g PiA+ID4gPiA+DQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPg0KPiA+ID4gPiA+ID4gPiA+ ID4gPiA+ID4gPiA+ID4gVGhlcmUgaXMgYWxzbyBhbm90aGVyIHByb2JsZW0uIElPUkVRIGlzDQo+ IHByb2JhYmx5DQo+ID4gbm90DQo+ID4gPiA+IGJlDQo+ID4gPiA+ID4gPiB0aGUNCj4gPiA+ID4g PiA+ID4gPiA+IG9ubHkNCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+IGludGVyZmFjZSBu ZWVkZWQuIEhhdmUgYSBsb29rIGF0DQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiBodHRw czovL21hcmMuaW5mby8/bD14ZW4tDQo+ID4gZGV2ZWwmbT0xNjIzNzM3NTQ3MDUyMzMmdz0yLg0K PiA+ID4gPiA+ID4gRG9uJ3Qgd2UNCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiBhbHNvIG5lZWQNCj4g PiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+IGFuIGludGVyZmFjZSBmb3IgdGhlIGJhY2tlbmQg dG8gaW5qZWN0DQo+ID4gaW50ZXJydXB0cw0KPiA+ID4gPiBpbnRvDQo+ID4gPiA+ID4gPiB0aGUN Cj4gPiA+ID4gPiA+ID4gPiA+ID4gPiBmcm9udGVuZD8gQW5kDQo+ID4gPiA+ID4gPiA+ID4gPiA+ ID4gPiA+ID4gPiBpZiB0aGUgYmFja2VuZCByZXF1aXJlcyBkeW5hbWljIG1lbW9yeQ0KPiBtYXBw aW5ncw0KPiA+IG9mDQo+ID4gPiA+ID4gPiBmcm9udGVuZA0KPiA+ID4gPiA+ID4gPiA+ID4gcGFn ZXMsDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gdGhlbg0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4g PiA+ID4gd2Ugd291bGQgYWxzbyBuZWVkIGFuIGludGVyZmFjZSB0byBtYXAvdW5tYXANCj4gPiBk b21VDQo+ID4gPiA+IHBhZ2VzLg0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+DQo+ID4gPiA+ ID4gPiA+ID4gPiA+ID4gPiA+ID4gTXkgcHJvcG9zYWwgZG9jdW1lbnQgbWlnaHQgaGVscCBoZXJl OyBBbGwgdGhlDQo+ID4gPiA+IGludGVyZmFjZXMNCj4gPiA+ID4gPiA+ID4gPiA+IHJlcXVpcmVk DQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gZm9yDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4g dmlydGlvLXByb3h5IChvciBoeXBlcnZpc29yLXJlbGF0ZWQgaW50ZXJmYWNlcykNCj4gPiBhcmUN Cj4gPiA+ID4gbGlzdGVkDQo+ID4gPiA+ID4gPiBhcw0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4g PiA+IFJQQyBwcm90b2NvbHMgOikNCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPg0KPiA+ID4g PiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gVGhlc2UgaW50ZXJmYWNlcyBhcmUgYSBsb3QgbW9yZSBw cm9ibGVtYXRpYw0KPiB0aGFuDQo+ID4gPiA+IElPUkVROg0KPiA+ID4gPiA+ID4gSU9SRVENCj4g PiA+ID4gPiA+ID4gPiA+IGlzDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gdGlueQ0KPiA+ID4gPiA+ ID4gPiA+ID4gPiA+ID4gPiA+ID4gYW5kIHNlbGYtY29udGFpbmVkLiBJdCBpcyBlYXN5IHRvIGFk ZCBhbnl3aGVyZS4NCj4gPiBBDQo+ID4gPiA+IG5ldw0KPiA+ID4gPiA+ID4gPiA+ID4gaW50ZXJm YWNlIHRvDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiBpbmplY3QgaW50ZXJydXB0cyBv ciBtYXAgcGFnZXMgaXMgbW9yZQ0KPiBkaWZmaWN1bHQNCj4gPiB0bw0KPiA+ID4gPiA+ID4gbWFu YWdlDQo+ID4gPiA+ID4gPiA+ID4gPiBiZWNhdXNlDQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gaXQN Cj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+IHdvdWxkIHJlcXVpcmUgY2hhbmdlcyBzY2F0 dGVyZWQgYWNyb3NzIHRoZQ0KPiA+IHZhcmlvdXMNCj4gPiA+ID4gPiA+IGVtdWxhdG9ycy4NCj4g PiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPg0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+IEV4 YWN0bHkuIEkgaGF2ZSBubyBjb25maWRlbnQgeWV0IHRoYXQgbXkNCj4gYXBwcm9hY2gNCj4gPiB3 aWxsDQo+ID4gPiA+ID4gPiBhbHNvDQo+ID4gPiA+ID4gPiA+ID4gPiBhcHBseQ0KPiA+ID4gPiA+ ID4gPiA+ID4gPiA+ID4gPiA+IHRvIG90aGVyIGh5cGVydmlzb3JzIHRoYW4gWGVuLg0KPiA+ID4g PiA+ID4gPiA+ID4gPiA+ID4gPiA+IFRlY2huaWNhbGx5LCB5ZXMsIGJ1dCB3aGV0aGVyIHBlb3Bs ZSBjYW4gYWNjZXB0DQo+IGl0DQo+ID4gb3INCj4gPiA+ID4gbm90DQo+ID4gPiA+ID4gPiBpcyBh DQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4gZGlmZmVyZW50DQo+ID4gPiA+ID4gPiA+ID4gPiA+ID4g PiA+ID4gbWF0dGVyLg0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+DQo+ID4gPiA+ID4gPiA+ ID4gPiA+ID4gPiA+ID4gVGhhbmtzLA0KPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+IC1UYWth aGlybyBBa2FzaGkNCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4NCj4gPiA+ID4gPiA+ID4gPiA+ ID4gPiA+ID4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4NCj4gPiA+ID4gPiA+ID4gPiA+ID4g PiA+ID4gLS0NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gUmVnYXJkcywNCj4gPiA+ID4gPiA+ ID4gPiA+ID4gPiA+ID4NCj4gPiA+ID4gPiA+ID4gPiA+ID4gPiA+ID4gT2xla3NhbmRyIFR5c2hj aGVua28NCg0K From xen-devel-bounces@lists.xenproject.org Thu Sep 02 02:08:53 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 02:08:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.176793.321744 (Exim 4.92) (envelope-from ) id 1mLc9m-0002zQ-SJ; Thu, 02 Sep 2021 02:08:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 176793.321744; Thu, 02 Sep 2021 02:08:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLc9m-0002zJ-Mq; Thu, 02 Sep 2021 02:08:46 +0000 Received: by outflank-mailman (input) for mailman id 176793; Thu, 02 Sep 2021 02:08:45 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLc9l-0002zD-Sm for xen-devel@lists.xenproject.org; Thu, 02 Sep 2021 02:08:45 +0000 Received: from outbound.mail.eo.outlook.com (unknown [40.93.3.7]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 8b12e6f6-cf9a-4990-a0f6-441daf1a528f; Thu, 02 Sep 2021 02:08:42 +0000 (UTC) Received: from MWHPR21MB1593.namprd21.prod.outlook.com (2603:10b6:301:7c::11) by CO2PR21MB3009.namprd21.prod.outlook.com (2603:10b6:102:18::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.4; Thu, 2 Sep 2021 02:08:38 +0000 Received: from MWHPR21MB1593.namprd21.prod.outlook.com ([fe80::3c8b:6387:cd5:7d86]) by MWHPR21MB1593.namprd21.prod.outlook.com ([fe80::3c8b:6387:cd5:7d86%8]) with mapi id 15.20.4478.014; Thu, 2 Sep 2021 02:08:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8b12e6f6-cf9a-4990-a0f6-441daf1a528f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IUpSChkKBWMqyiukbEC8IxJNip992xfSXG5TmpQZhkTvCM/aDZMzscsPteLJxO9Z+5nnAwfCHVRJ2W0YK/xFtjDjwHurm+0Uoqtr6zVSPfMdiMi6cSkgOZkktBCMP8rEmFLNUaWJ2Dhp7THgrZYlneAqfo9iUKClaU0aHvP1AmlX3TXvz93tpYlHU/qOF6/hlZFIwPYBV7ek4LskPSoO3CPFQvILuX9vbB3Zbp+hxpChe0+AufmBZ5o6B+FBxq9NEGICdotV83xIIWBC64c6PrUYihGmPpQEwMmJhcJtqBnnwvbmXJY6CGbXFBAY1rdoHC5K+nZ+RhLtZij0t2NT7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=m8Z4zZgDo/ng30TsOukCORL2mWs0iQjFTdzvLSYEXk8=; b=j3uJ/vgN2Svy1/0rRfkdPjkX3676/Ve/pCQkW24hZX2cQlqfjygR2sWm6x9pTpyd/XcmeLGdWLTF+9XdRWXSrHmrmRKXNRiIpyX8sH81E5g2zkeOIQqEanzEwbrslp+dKshg/BmJ/bhCENBW4Vz9E1KcigFSaLX90cGresqjzboZ4X1nTRmGBYJQnQDEfcQbAdE6tGxM1l7KMRhs43sQkkktASolHwV/KUNZ4JC07adFBSl020syB2TBtyEkp/uLGjdjYd5Ds9bgq9aDxTDkXVrAReL86MfBx9lPiT8heE/mPlRzU24k276JY4geouUHknOK91hgN4/lTs/Zk4rzWw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=m8Z4zZgDo/ng30TsOukCORL2mWs0iQjFTdzvLSYEXk8=; b=bd/JOGRzT95HRhvOUNcHOfelq5cct9xFQv9lwJCNx7oSiw34v9MsYGLbyVgS39nixvvJ8lcvmPh920F5WnTGKtg3zCvRIW/DKiesmXiXZ80gITl9JyjYcJHTfA5qIhgnqZS859ZT4dw1V+ArSVbyybPU+uOdhKiAKbZdBI1rOf8= From: Michael Kelley To: Tianyu Lan , KY Srinivasan , Haiyang Zhang , Stephen Hemminger , "wei.liu@kernel.org" , Dexuan Cui , "catalin.marinas@arm.com" , "will@kernel.org" , "tglx@linutronix.de" , "mingo@redhat.com" , "bp@alien8.de" , "x86@kernel.org" , "hpa@zytor.com" , "dave.hansen@linux.intel.com" , "luto@kernel.org" , "peterz@infradead.org" , "konrad.wilk@oracle.com" , "boris.ostrovsky@oracle.com" , "jgross@suse.com" , "sstabellini@kernel.org" , "joro@8bytes.org" , "davem@davemloft.net" , "kuba@kernel.org" , "jejb@linux.ibm.com" , "martin.petersen@oracle.com" , "gregkh@linuxfoundation.org" , "arnd@arndb.de" , "hch@lst.de" , "m.szyprowski@samsung.com" , "robin.murphy@arm.com" , "brijesh.singh@amd.com" , "thomas.lendacky@amd.com" , Tianyu Lan , "pgonda@google.com" , "martin.b.radev@gmail.com" , "akpm@linux-foundation.org" , "kirill.shutemov@linux.intel.com" , "rppt@kernel.org" , "hannes@cmpxchg.org" , "aneesh.kumar@linux.ibm.com" , "krish.sadhukhan@oracle.com" , "saravanand@fb.com" , "linux-arm-kernel@lists.infradead.org" , "xen-devel@lists.xenproject.org" , "rientjes@google.com" , "ardb@kernel.org" CC: "iommu@lists.linux-foundation.org" , "linux-arch@vger.kernel.org" , "linux-hyperv@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-scsi@vger.kernel.org" , "netdev@vger.kernel.org" , vkuznets , "parri.andrea@gmail.com" , "dave.hansen@intel.com" Subject: RE: [PATCH V4 13/13] hv_storvsc: Add Isolation VM support for storvsc driver Thread-Topic: [PATCH V4 13/13] hv_storvsc: Add Isolation VM support for storvsc driver Thread-Index: AQHXm2gLgD2LnlrK1Ui6MWEQREt+OKuIA2QQ Date: Thu, 2 Sep 2021 02:08:38 +0000 Message-ID: References: <20210827172114.414281-1-ltykernel@gmail.com> <20210827172114.414281-14-ltykernel@gmail.com> In-Reply-To: <20210827172114.414281-14-ltykernel@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ActionId=f3fb0eb4-3fe0-4fc3-9520-c93e315d7a42;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=true;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Standard;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=Internal;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2021-08-27T23:41:48Z;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=microsoft.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6ea2dd65-3c0f-43cb-0521-08d96db693fe x-ms-traffictypediagnostic: CO2PR21MB3009: x-ms-exchange-transport-forked: True x-ld-processed: 72f988bf-86f1-41af-91ab-2d7cd011db47,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2449; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ndTLqZdHuCSzY96whS6o3zQp5pWBl/+LPOxouGx7MvdNaYKuKvaFNQwUMEMZfwmHr4jOi6oWBYiz3uNN1AIyg7MhnWomwEL0ihAtK7DvmJFI1pwN23oEItvoA9pfELcTzjHqzto7bCclgTX/tL8m2FVSWS9DznLZ6SL5bED36RZkXCgWoZ61O2xsYrmNK2BYGQJZqTbGKL8JnYl6a1VckOlhVdTcP0kloEzheeMPbCao6ltZge2w3RTnxLv22Ap1BXZKd5XelSzST1sQ2afXyEbqeK+gHzbQeItQFBGpcdjBoy4bU1Ou2Bzw2Ywm9ZmzAgYWhsQCsjwaUgtTmad6fEEO8kOVFKE3mNsXM/zB9yvCObJ1w3dqn7fesYfaweLGMdsWkx80wNt87AjQS+VuaML7txbgbnsj9Sh1pTWE8BQru7dwe3i+e4HyJQSi9RzvoqBvVNbd+n2Wn64j2hrkR7K0QiRW25kzFfeWGwxqIrxhyQ00KRYF8fVPVWDn1zrJUc2GjpQdJuUvR6pQ0ibrmPBeMJgLnb2KDAC0KCTMtEsB1uXDSF1BfkvUnPbYlQv3iq1KsDsPYIHFz7oKMnTKE2KvuGVD8tYcxf/YQdJAN3jNDLQWWp1ORhABKivtbremVstJAU2ihezQYo77y3CPHdlF81y59pgSoKUtaskzqrOzL8EWJtkpNf0UmCBSDzCuYTmwjdSI/nxE35dzdARuaGYoiP+gfuPjhNpq6jMqsI8= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR21MB1593.namprd21.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(82950400001)(82960400001)(4326008)(186003)(76116006)(316002)(8990500004)(110136005)(66476007)(83380400001)(7406005)(7416002)(7366002)(66946007)(66556008)(64756008)(66446008)(54906003)(6506007)(9686003)(55016002)(122000001)(26005)(2906002)(52536014)(921005)(86362001)(71200400001)(5660300002)(38070700005)(7696005)(8676002)(8936002)(38100700002)(508600001)(33656002)(10290500003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?DolnhatuDAmIAaAz1/YX4Nu77VLxLJi5Z5u3+A6UHOQkEZWqwmLzr6hkf5h6?= =?us-ascii?Q?mVAM7sfILM0sb62t/FIdI2R41We7PR+TF1q7yPx6JbgXnRJQjOGD7e6VAlL0?= =?us-ascii?Q?VYlx3oYPMhMWiZoMNmNhSz2nfZTsTT/s8eRHAg5yZtQHCyQJGnBRXvLo2ZT0?= =?us-ascii?Q?zllaDQdkxQxV7ukn+Bt6fJgbkj8n2gr1b/uO4SQXC7NISFP1EyxCgQ6JQ7Fc?= =?us-ascii?Q?jV4VmCJP8+JQNgbqAyardqPmpig/GBcw/1UqOeybTfbfoSVxOsatsZERTnP5?= =?us-ascii?Q?UxSKKL6MuvTM5sTNREAIy2bYLBDu4U0OhiPvTlUJpnYMfyXYNKH267zIFzCM?= =?us-ascii?Q?PldhdohAzJfsYI0h6w2kOSo7q8IBiuWm+zf+aaRpA9PB7MlLaixaNGZcU4lE?= =?us-ascii?Q?gjYWnJJoud5x0cHcwyYxq8sUexK1uweGy3v6UEKjsTVj/m4FyZ2vXqirFf4H?= =?us-ascii?Q?JkbMuFrXswddWR1K8OpAK1204L0MPy5x9yuzN7+maWBfL+enrzX3W+tzdxs4?= =?us-ascii?Q?f/1SdBIJEDEM3OYuR9P/7zhpNhHDIL++WxG8hrWBN7w3IkOCRGlCO0rUW/hX?= =?us-ascii?Q?E1kEuquD99AvKjJK+AGHbABnEfuVNY3viHqFns4Yx0N3O29ES8uVUvwVSY/q?= =?us-ascii?Q?+l3hpQlfW1lBAVS/zySdayy9k4GLK6ubKQfh9vHhnx7ccUqzzuw5w18Pgs3W?= =?us-ascii?Q?VRTWWM2CMj5YA1zbaCKGqvuXdOyY0XYRog8BcGfUdaczLPsyPQCLGNqwQGU2?= =?us-ascii?Q?AqEnxtXliDQDWBFJSrNj/c1k911nSNH4BGyPKYlT4zHgcDL+97I4sJ2OoBp9?= =?us-ascii?Q?KyBj4U1Du4CbFvWCafngd6ltxm1/GKtYyAEZrP7Qya5gxRfabpq2pmyMcAmf?= =?us-ascii?Q?lbXmuOj9wMIO2kVGMbHqdvd2octK5nt3V+7yNs2wI876Xq7lDMRF2Gee7USb?= =?us-ascii?Q?ZpRrKueEWAIPyLJKQ26Kj/f8msXqtX6JMPvdt0iunoCn5X0YJwFET5D9eDn8?= =?us-ascii?Q?GWtR1tpnTxey2vk4daEsB2DBReKe8Hj20zwcaezjVCEwUo7/evMJ4lxdeSv2?= =?us-ascii?Q?9pmAy+NcK9mp0y78xdFmLKyXxk82K2vRtiOA7SxTlAFsleQE4DHwPMte4tfC?= =?us-ascii?Q?kN+9LxsXMpZ8Z1qM7k5Pf/nedS/xTbiRCsjqmXAwwMjgPtQKTgPVY3xLtLjT?= =?us-ascii?Q?bybW5G1aOMa+Vf7yWoRXHxa/Ha4Sans5gAcg2zsEFAIyoTy4qGFChbOT0mGz?= =?us-ascii?Q?CiPjKJ3SsfvxpRmVUTLDus/nOnN6kdsW79nDuLhkSL3No277Wu/5FMMUS18+?= =?us-ascii?Q?+15h35tJ4UXVtGV1HnHg+BNj?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR21MB1593.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6ea2dd65-3c0f-43cb-0521-08d96db693fe X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Sep 2021 02:08:38.0541 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: tXT0bjcyirvjVG/opzOIdPJBrRMiRaNV9Y9VlcCS+iP2p9aRelS7uwRI97sbYAJCtJayrUXtfu+t7qPz3kutGOq/HYyGfA8POko7JlWeOqw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO2PR21MB3009 From: Tianyu Lan Sent: Friday, August 27, 2021 10:21 = AM >=20 Per previous comment, the Subject line tag should be "scsi: storvsc: " > In Isolation VM, all shared memory with host needs to mark visible > to host via hvcall. vmbus_establish_gpadl() has already done it for > storvsc rx/tx ring buffer. The page buffer used by vmbus_sendpacket_ > mpb_desc() still needs to be handled. Use DMA API(dma_map_sg) to map > these memory during sending/receiving packet and return swiotlb bounce > buffer dma address. In Isolation VM, swiotlb bounce buffer is marked > to be visible to host and the swiotlb force mode is enabled. >=20 > Set device's dma min align mask to HV_HYP_PAGE_SIZE - 1 in order to > keep the original data offset in the bounce buffer. >=20 > Signed-off-by: Tianyu Lan > --- > Change since v3: > * Rplace dma_map_page with dma_map_sg() > * Use for_each_sg() to populate payload->range.pfn_array. > * Remove storvsc_dma_map macro > --- > drivers/hv/vmbus_drv.c | 1 + > drivers/scsi/storvsc_drv.c | 41 +++++++++++++++----------------------- > include/linux/hyperv.h | 1 + > 3 files changed, 18 insertions(+), 25 deletions(-) >=20 > diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c > index f068e22a5636..270d526fd9de 100644 > --- a/drivers/hv/vmbus_drv.c > +++ b/drivers/hv/vmbus_drv.c > @@ -2124,6 +2124,7 @@ int vmbus_device_register(struct hv_device *child_d= evice_obj) > hv_debug_add_dev_dir(child_device_obj); >=20 > child_device_obj->device.dma_mask =3D &vmbus_dma_mask; > + child_device_obj->device.dma_parms =3D &child_device_obj->dma_parms; > return 0; >=20 > err_kset_unregister: > diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c > index 328bb961c281..4f1793be1fdc 100644 > --- a/drivers/scsi/storvsc_drv.c > +++ b/drivers/scsi/storvsc_drv.c > @@ -21,6 +21,8 @@ > #include > #include > #include > +#include > + > #include > #include > #include > @@ -1312,6 +1314,9 @@ static void storvsc_on_channel_callback(void *conte= xt) > continue; > } > request =3D (struct storvsc_cmd_request *)scsi_cmd_priv(scmnd); > + if (scsi_sg_count(scmnd)) > + dma_unmap_sg(&device->device, scsi_sglist(scmnd), > + scsi_sg_count(scmnd), scmnd->sc_data_direction); Use scsi_dma_unmap(), which does exactly what you have written above. :-) > } >=20 > storvsc_on_receive(stor_device, packet, request); > @@ -1725,7 +1730,6 @@ static int storvsc_queuecommand(struct Scsi_Host *h= ost, struct scsi_cmnd *scmnd) > struct hv_host_device *host_dev =3D shost_priv(host); > struct hv_device *dev =3D host_dev->dev; > struct storvsc_cmd_request *cmd_request =3D scsi_cmd_priv(scmnd); > - int i; > struct scatterlist *sgl; > unsigned int sg_count; > struct vmscsi_request *vm_srb; > @@ -1807,10 +1811,11 @@ static int storvsc_queuecommand(struct Scsi_Host = *host, struct scsi_cmnd *scmnd) > payload_sz =3D sizeof(cmd_request->mpb); >=20 > if (sg_count) { > - unsigned int hvpgoff, hvpfns_to_add; > unsigned long offset_in_hvpg =3D offset_in_hvpage(sgl->offset); > unsigned int hvpg_count =3D HVPFN_UP(offset_in_hvpg + length); > - u64 hvpfn; > + struct scatterlist *sg; > + unsigned long hvpfn, hvpfns_to_add; > + int j, i =3D 0; >=20 > if (hvpg_count > MAX_PAGE_BUFFER_COUNT) { >=20 > @@ -1824,31 +1829,16 @@ static int storvsc_queuecommand(struct Scsi_Host = *host, struct scsi_cmnd *scmnd) > payload->range.len =3D length; > payload->range.offset =3D offset_in_hvpg; >=20 > + if (dma_map_sg(&dev->device, sgl, sg_count, > + scmnd->sc_data_direction) =3D=3D 0) > + return SCSI_MLQUEUE_DEVICE_BUSY; >=20 > - for (i =3D 0; sgl !=3D NULL; sgl =3D sg_next(sgl)) { > - /* > - * Init values for the current sgl entry. hvpgoff > - * and hvpfns_to_add are in units of Hyper-V size > - * pages. Handling the PAGE_SIZE !=3D HV_HYP_PAGE_SIZE > - * case also handles values of sgl->offset that are > - * larger than PAGE_SIZE. Such offsets are handled > - * even on other than the first sgl entry, provided > - * they are a multiple of PAGE_SIZE. > - */ Any reason not to keep this comment? It's still correct and mentions important cases that must be handled. > - hvpgoff =3D HVPFN_DOWN(sgl->offset); > - hvpfn =3D page_to_hvpfn(sg_page(sgl)) + hvpgoff; > - hvpfns_to_add =3D HVPFN_UP(sgl->offset + sgl->length) - > - hvpgoff; > + for_each_sg(sgl, sg, sg_count, j) { There's a subtle issue here in that the number of entries in the mapped sgl might not be the same as the number of entries prior to the mapping. A change in the count probably never happens for the direct DMA mapping being done here, but let's code to be correct in the general case. Either need to refetch the value of sg_count, or arrange to use something like for_each_sgtable_dma_sg(). > + hvpfns_to_add =3D HVPFN_UP(sg_dma_len(sg)); This simplification in calculating hvpnfs_to_add is not correct. Consider the case of one sgl entry specifying a buffer of 3 Kbytes that starts at a 2K offset in the first page and runs over into the second page. This case can happen when the physical memory for the two pages is contiguous due to random happenstance, due to huge pages, or due to being on an architecture like ARM64 where the guest page size may be larger than the Hyper-V page size. In this case, we need two Hyper-V PFNs because the buffer crosses a Hyper-V page boundary. But the above will calculate only one PFN. The original algorithm handles this case correctly. > + hvpfn =3D HVPFN_DOWN(sg_dma_address(sg)); >=20 > - /* > - * Fill the next portion of the PFN array with > - * sequential Hyper-V PFNs for the continguous physical > - * memory described by the sgl entry. The end of the > - * last sgl should be reached at the same time that > - * the PFN array is filled. > - */ Any reason not to keep this comment? It's still correct. > while (hvpfns_to_add--) > - payload->range.pfn_array[i++] =3D hvpfn++; > + payload->range.pfn_array[i++] =3D hvpfn++; > } > } >=20 > @@ -1992,6 +1982,7 @@ static int storvsc_probe(struct hv_device *device, > stor_device->vmscsi_size_delta =3D sizeof(struct vmscsi_win8_extension)= ; > spin_lock_init(&stor_device->lock); > hv_set_drvdata(device, stor_device); > + dma_set_min_align_mask(&device->device, HV_HYP_PAGE_SIZE - 1); >=20 > stor_device->port_number =3D host->host_no; > ret =3D storvsc_connect_to_vsp(device, storvsc_ringbuffer_size, is_fc); > diff --git a/include/linux/hyperv.h b/include/linux/hyperv.h > index 139a43ad65a1..8f39893f8ccf 100644 > --- a/include/linux/hyperv.h > +++ b/include/linux/hyperv.h > @@ -1274,6 +1274,7 @@ struct hv_device { >=20 > struct vmbus_channel *channel; > struct kset *channels_kset; > + struct device_dma_parameters dma_parms; >=20 > /* place holder to keep track of the dir for hv device in debugfs */ > struct dentry *debug_dir; > -- > 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu Sep 02 02:30:10 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 02:30:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.176799.321754 (Exim 4.92) (envelope-from ) id 1mLcUG-0005lY-Jo; Thu, 02 Sep 2021 02:29:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 176799.321754; Thu, 02 Sep 2021 02:29:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLcUG-0005lR-Ge; Thu, 02 Sep 2021 02:29:56 +0000 Received: by outflank-mailman (input) for mailman id 176799; Thu, 02 Sep 2021 02:29:54 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLcUE-0005lD-Hq; Thu, 02 Sep 2021 02:29:54 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLcUE-0001Ey-BX; Thu, 02 Sep 2021 02:29:54 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLcUE-0002ki-0J; Thu, 02 Sep 2021 02:29:54 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mLcUD-0005cY-WA; Thu, 02 Sep 2021 02:29:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=/eIgvflmIhZhQI4ZIS1OfpAezLcfBg23PY7XRzN7lbw=; b=65x2/tIHhqEoUrTxpWpiJANyJ+ tZoy3bWR0VBs/PMg6TFj7stpspIaOzcaf24+M7njE4wNqDCxaKc0zFox7KXm2x7e6AfaAU8/hmqAO AuZs9/DG/RhRdk8u8qk3FJZq6Eqsk9YARZ6FHSYlNkqTNYdG/cjqQVFDmGrWDaXnbhwU=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.11-testing test] 164693: tolerable FAIL - PUSHED X-Osstest-Failures: xen-4.11-testing:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug xen-4.11-testing:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:debian-hvm-install:fail:nonblocking xen-4.11-testing:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:debian-hvm-install:fail:nonblocking xen-4.11-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.11-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-4.11-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.11-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-4.11-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.11-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.11-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.11-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.11-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.11-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.11-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.11-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.11-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.11-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.11-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.11-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.11-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-4.11-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-4.11-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.11-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.11-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-4.11-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-4.11-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-4.11-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.11-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-4.11-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-4.11-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.11-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-4.11-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-4.11-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-4.11-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.11-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-4.11-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-4.11-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-4.11-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-4.11-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-4.11-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-4.11-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-4.11-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-4.11-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-4.11-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.11-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-4.11-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-4.11-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-4.11-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-4.11-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.11-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.11-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-4.11-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-4.11-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-4.11-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=e9bee143fd4248b004d1235c320bb0180a4c757f X-Osstest-Versions-That: xen=ef32c7afa2731b758226d6e10a1e489b1a15fc41 From: osstest service owner Date: Thu, 02 Sep 2021 02:29:53 +0000 flight 164693 xen-4.11-testing real [real] flight 164735 xen-4.11-testing real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/164693/ http://logs.test-lab.xenproject.org/osstest/logs/164735/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 164735-retest Tests which did not succeed, but are not blocking: test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 12 debian-hvm-install fail like 162548 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 12 debian-hvm-install fail like 162548 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 162548 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 162548 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 162548 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 162548 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 162548 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 162548 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 162548 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 162548 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 162548 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 162548 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 162548 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass version targeted for testing: xen e9bee143fd4248b004d1235c320bb0180a4c757f baseline version: xen ef32c7afa2731b758226d6e10a1e489b1a15fc41 Last test of basis 162548 2021-06-08 18:37:00 Z 85 days Failing since 164486 2021-08-25 14:05:55 Z 7 days 6 attempts Testing same since 164693 2021-09-01 09:36:33 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Anthony PERARD Ian Jackson Jan Beulich Jason Andryuk Roger Pau Monné jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git ef32c7afa2..e9bee143fd e9bee143fd4248b004d1235c320bb0180a4c757f -> stable-4.11 From xen-devel-bounces@lists.xenproject.org Thu Sep 02 02:30:30 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 02:30:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.176805.321769 (Exim 4.92) (envelope-from ) id 1mLcUo-00071Y-4d; Thu, 02 Sep 2021 02:30:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 176805.321769; Thu, 02 Sep 2021 02:30:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLcUo-00071R-0r; Thu, 02 Sep 2021 02:30:30 +0000 Received: by outflank-mailman (input) for mailman id 176805; Thu, 02 Sep 2021 02:30:28 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLcUm-0006w4-IU for xen-devel@lists.xenproject.org; Thu, 02 Sep 2021 02:30:28 +0000 Received: from EUR02-HE1-obe.outbound.protection.outlook.com (unknown [40.107.1.77]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 2acc9a32-9e0f-4a2c-b085-76b2b2909665; Thu, 02 Sep 2021 02:30:20 +0000 (UTC) Received: from DB6PR07CA0112.eurprd07.prod.outlook.com (2603:10a6:6:2c::26) by AS8PR08MB6790.eurprd08.prod.outlook.com (2603:10a6:20b:397::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19; Thu, 2 Sep 2021 02:30:18 +0000 Received: from DB5EUR03FT061.eop-EUR03.prod.protection.outlook.com (2603:10a6:6:2c:cafe::39) by DB6PR07CA0112.outlook.office365.com (2603:10a6:6:2c::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.4 via Frontend Transport; Thu, 2 Sep 2021 02:30:18 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT061.mail.protection.outlook.com (10.152.21.234) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Thu, 2 Sep 2021 02:30:17 +0000 Received: ("Tessian outbound 6ba9ec11d42b:v103"); Thu, 02 Sep 2021 02:30:17 +0000 Received: from 5b88d9df9254.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 337490BF-0A08-4339-9F83-9BC61E732793.1; Thu, 02 Sep 2021 02:30:11 +0000 Received: from EUR02-AM5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 5b88d9df9254.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 02 Sep 2021 02:30:11 +0000 Received: from DB9PR08MB6857.eurprd08.prod.outlook.com (2603:10a6:10:2a2::7) by DBBPR08MB4315.eurprd08.prod.outlook.com (2603:10a6:10:cd::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.17; Thu, 2 Sep 2021 02:30:09 +0000 Received: from DB9PR08MB6857.eurprd08.prod.outlook.com ([fe80::2c28:50cf:49fd:da32]) by DB9PR08MB6857.eurprd08.prod.outlook.com ([fe80::2c28:50cf:49fd:da32%7]) with mapi id 15.20.4457.026; Thu, 2 Sep 2021 02:30:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2acc9a32-9e0f-4a2c-b085-76b2b2909665 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lHGjjLyUt7AJP/HqcDCD570L6Zw4mKyCG8YQ/5AkkyY=; b=FfJ2qPrwiwQ3+qtq7NRaSqak9YBMeFWO5J1KkMmT6RpcQ3L6AW3iXTMZSFcAanmcVwkESbhbT2cL1cs7T1Z/slJajaJAKXTcX4KnyHPAgI8Qx4fh9m2d1lJ5sukro/Q0jOsmXpreyVuM0sKF4ur4tSTN3b6wfBnkiwPymMyE6HU= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ENhPZCgrIZ3NH+4nUwGrgFS4mqKizgTFjS5GrmfodRmtQmp/lhVrFEfkW/MMxQDuhZxZsriS1yuLqC4c0T0PESlLwqOdqJ1TZOelZt8C4xjKzLnXjhKcLZv+wZMa23Xx3nVyuGYixuYGpuP1zJuxTeXseE4PhV/p0YaZgoIBCxWlHQTsCPtukPRP8D+/vwekSCRvNAYFaN43IbAtQxgRxTHz0JtwllqKYDxuM0ytr6PP8eRIRgRPb9T+JXm6Iay/3fkFAHkxiS0AgsiuixF/GlE48o3TPDxMeiQn78QqDRJGHCvFwJPtAEU/C2jX0wPD5QNnxhQqXsHxdz1QN5B2+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=lHGjjLyUt7AJP/HqcDCD570L6Zw4mKyCG8YQ/5AkkyY=; b=VfFjACFhRe1a8A65VkL0AZVQ7Su8gBGFyz70RYHLwdlp/T2cIXcaYGipyG6X8UQD1yTf5Cja9WHIZc7MjazHjkXfNl6W9PPJQelIxFG1Yhw95fsQLKuR/agtqqeIP+4I1+kxrTK0TFdFlsT3QFaJlsgnFjNix6L/EDQJgjUgnZfkyq5kF6NTLtlmgBZ5E467DHkLgRGKJj5Ox+um5atVxo8j67zXs/G6xhqynFkK8JUkoURIHlJD5jKHn3844+TsLsAES8DK5oI4pQxvD4t7Wcd80uy/r6gPuKN3UXTGV/ZI3Jva+A0gaet2YcbLkF4392/WxXLzxzKQltkt83C1bw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lHGjjLyUt7AJP/HqcDCD570L6Zw4mKyCG8YQ/5AkkyY=; b=FfJ2qPrwiwQ3+qtq7NRaSqak9YBMeFWO5J1KkMmT6RpcQ3L6AW3iXTMZSFcAanmcVwkESbhbT2cL1cs7T1Z/slJajaJAKXTcX4KnyHPAgI8Qx4fh9m2d1lJ5sukro/Q0jOsmXpreyVuM0sKF4ur4tSTN3b6wfBnkiwPymMyE6HU= From: Wei Chen To: Stefano Stabellini CC: "xen-devel@lists.xenproject.org" , "julien@xen.org" , Bertrand Marquis Subject: RE: [XEN RFC PATCH 24/40] xen/arm: introduce a helper to parse device tree NUMA distance map Thread-Topic: [XEN RFC PATCH 24/40] xen/arm: introduce a helper to parse device tree NUMA distance map Thread-Index: AQHXjps+iLbrOQu8n06b5z+EtCRt06uM5puAgABnI4CAAPWOAIAA3gOAgABcYACAAKNX0A== Date: Thu, 2 Sep 2021 02:30:08 +0000 Message-ID: References: <20210811102423.28908-1-wei.chen@arm.com> <20210811102423.28908-25-wei.chen@arm.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: D2C81D7069A0E447BB451A1CE27AB9AA.0 x-checkrecipientchecked: true Authentication-Results-Original: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=arm.com; x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: 4e223013-a22e-4343-ffa8-08d96db99a97 x-ms-traffictypediagnostic: DBBPR08MB4315:|AS8PR08MB6790: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:10000;OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: XCbzMCNrezVhusBXHN/aXujP4S0huck0rx+kfxx6PhCiN/ReB1DppPdNWH9Tvey51cgl+r6SfKNEPAd5RoAqi6v3DeWZnhUAvOVc0034KiJzztWkir2KYUmlhZTOE1Nd2SKCP1OSWdrsVJYm0yJPqkc8kdbUsHaX9t7lZUgzjFACzVA9jwFDNxSOGu2wokOcQ/41BdI3uBj/4JVqSBHHk1wGY43gGQM1Na7lF9ZY4tJe+ihHhcX7RJ3T/Frn0VU3zXqii/pm5V8GhCLqjs7fk0CHJdfl+K4L4aXUaeQMw+zz0AT3Y1JzFC1Q1vaoe5NFkHULDl6/iyeb1vPmcd+KuBm02LqLFIPgaI88UuiQHQe5j3EuGpIK/Yxc73iJutmJ3h1WWMMajPiFpfhFsBCXXW58oipbb8W65I7JL1ej4xBl2PjSFpL5bgA2B0MWRxGh3bTsB9WYBe6Y679ihOIvUh/O/j1TU0MFnpeB7uPo2hUMO3IJvHdgEBUW4TUOTBPSXMJmo2uTD5i1hhA63sXvl1biHZkKn2o/1Fb4xqH39HVLUJrHNxL7Ukbr03rPR6z7Muxxeun4MPwUTXbPqF5KP8TiBHr2pOpUs436318WvWgjJk1H/MseY1iZbzM+FTmQkDjJnnRUybRC/h+9nUjtH3iTFSV3hbxYNx7sbToyf0HlZzf0vmfqCHrgRfmqL7Jj/5jwSpaFIeukhYhY0TRbjA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB9PR08MB6857.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(366004)(346002)(136003)(39860400002)(376002)(2906002)(33656002)(6916009)(38100700002)(478600001)(9686003)(55016002)(26005)(122000001)(83380400001)(8676002)(186003)(53546011)(66476007)(6506007)(66446008)(64756008)(66556008)(66946007)(38070700005)(30864003)(86362001)(5660300002)(316002)(71200400001)(8936002)(76116006)(52536014)(7696005)(54906003)(4326008);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB4315 Original-Authentication-Results: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT061.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: e5aa2546-5672-45b8-bd13-08d96db9954d X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: E70hnrVePJUVmKlLXD3zLVd5OzIxhBHC9o4YrQvS3qQ06gqRBfY34MyVfQuMQeF0EkipDNf8s65xNYrC95SNjVs5/O31QPoMFXRfP5Y/qg0i9Zv9NljFTHM0utVkIrpc11CKeuaeZzgffPfHcXSZ0+chioJK7CFxDDZVas6gG69C1bzV0SjcmEPJry0S/jdzRnBmgRFb9CVYKZz7z7YOvDo6Ev0Ncej/wI3NUAUP5jXgbqyi2qCaYO+Exf0J0yhckevh1r5P9SuJHaU4RitPprQSy2gMQupQGgZ8KJrvKaWXojJPiwr1hxrFnuMB20hZe9i4iOvpEOAzTVCKMJEvx/GuJhEAIiQqr+m4dkqZXGZVLrfYml+Jcs+OYNz2q43oMzrAz9I/B4Z61y2DSIlZaSxe5N15sIEOA33ghSKgm8lFRyA856+8lGCSv1qvXbCr+P2L5p3luzGzTY5UM/5Y/T2n59G1pHA3jBxcDdiiz6KemBvhXIFVsOqcYeWRqwF89TuVKsDUz64IEfcMEOeH2YTbsoa/az6dNkRRg0vh/7OwbNUp4lI6LaghmVsaLvl0Rb21GWEYhsEPyPhnXySESPoSRLhGQ7UwrYqGacfy343pP+Hh+0KW0L9Q4YIyiLUrYmdDGVtXEojm0O7M7l6sVWXFUCKHbAWl7Jg8AXXOgLGPi1G0ysb2Vm5fEgtd+ZLYOea3JDDD8kq9uHUX8r1vXg== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(396003)(39860400002)(136003)(346002)(376002)(46966006)(36840700001)(70586007)(4326008)(5660300002)(36860700001)(6862004)(7696005)(70206006)(9686003)(8936002)(55016002)(52536014)(82310400003)(86362001)(53546011)(2906002)(33656002)(47076005)(82740400003)(8676002)(478600001)(356005)(186003)(336012)(316002)(30864003)(81166007)(26005)(83380400001)(54906003)(6506007);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Sep 2021 02:30:17.9585 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4e223013-a22e-4343-ffa8-08d96db99a97 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT061.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6790 SGkgU3RlZmFubywNCg0KPiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBTdGVm YW5vIFN0YWJlbGxpbmkgPHNzdGFiZWxsaW5pQGtlcm5lbC5vcmc+DQo+IFNlbnQ6IDIwMjHlubQ5 5pyIMuaXpSAwOjIyDQo+IFRvOiBXZWkgQ2hlbiA8V2VpLkNoZW5AYXJtLmNvbT4NCj4gQ2M6IFN0 ZWZhbm8gU3RhYmVsbGluaSA8c3N0YWJlbGxpbmlAa2VybmVsLm9yZz47IHhlbi0NCj4gZGV2ZWxA bGlzdHMueGVucHJvamVjdC5vcmc7IGp1bGllbkB4ZW4ub3JnOyBCZXJ0cmFuZCBNYXJxdWlzDQo+ IDxCZXJ0cmFuZC5NYXJxdWlzQGFybS5jb20+DQo+IFN1YmplY3Q6IFJFOiBbWEVOIFJGQyBQQVRD SCAyNC80MF0geGVuL2FybTogaW50cm9kdWNlIGEgaGVscGVyIHRvIHBhcnNlDQo+IGRldmljZSB0 cmVlIE5VTUEgZGlzdGFuY2UgbWFwDQo+IA0KPiBPbiBXZWQsIDEgU2VwIDIwMjEsIFdlaSBDaGVu IHdyb3RlOg0KPiA+IEhpIFN0ZWZhbm8sDQo+ID4NCj4gPiA+IC0tLS0tT3JpZ2luYWwgTWVzc2Fn ZS0tLS0tDQo+ID4gPiBGcm9tOiBYZW4tZGV2ZWwgPHhlbi1kZXZlbC1ib3VuY2VzQGxpc3RzLnhl bnByb2plY3Qub3JnPiBPbiBCZWhhbGYgT2YNCj4gPiA+IFN0ZWZhbm8gU3RhYmVsbGluaQ0KPiA+ ID4gU2VudDogMjAyMeW5tDnmnIgx5pelIDU6MzYNCj4gPiA+IFRvOiBXZWkgQ2hlbiA8V2VpLkNo ZW5AYXJtLmNvbT4NCj4gPiA+IENjOiBTdGVmYW5vIFN0YWJlbGxpbmkgPHNzdGFiZWxsaW5pQGtl cm5lbC5vcmc+OyB4ZW4tDQo+ID4gPiBkZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZzsganVsaWVu QHhlbi5vcmc7IEJlcnRyYW5kIE1hcnF1aXMNCj4gPiA+IDxCZXJ0cmFuZC5NYXJxdWlzQGFybS5j b20+DQo+ID4gPiBTdWJqZWN0OiBSRTogW1hFTiBSRkMgUEFUQ0ggMjQvNDBdIHhlbi9hcm06IGlu dHJvZHVjZSBhIGhlbHBlciB0bw0KPiBwYXJzZQ0KPiA+ID4gZGV2aWNlIHRyZWUgTlVNQSBkaXN0 YW5jZSBtYXANCj4gPiA+DQo+ID4gPiBPbiBUdWUsIDMxIEF1ZyAyMDIxLCBXZWkgQ2hlbiB3cm90 ZToNCj4gPiA+ID4gSGkgU3RlZmFubywNCj4gPiA+ID4NCj4gPiA+ID4gPiAtLS0tLU9yaWdpbmFs IE1lc3NhZ2UtLS0tLQ0KPiA+ID4gPiA+IEZyb206IFN0ZWZhbm8gU3RhYmVsbGluaSA8c3N0YWJl bGxpbmlAa2VybmVsLm9yZz4NCj4gPiA+ID4gPiBTZW50OiAyMDIx5bm0OOaciDMx5pelIDg6NDgN Cj4gPiA+ID4gPiBUbzogV2VpIENoZW4gPFdlaS5DaGVuQGFybS5jb20+DQo+ID4gPiA+ID4gQ2M6 IHhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZzsgc3N0YWJlbGxpbmlAa2VybmVsLm9yZzsN Cj4gPiA+IGp1bGllbkB4ZW4ub3JnOw0KPiA+ID4gPiA+IGpiZXVsaWNoQHN1c2UuY29tOyBCZXJ0 cmFuZCBNYXJxdWlzIDxCZXJ0cmFuZC5NYXJxdWlzQGFybS5jb20+DQo+ID4gPiA+ID4gU3ViamVj dDogUmU6IFtYRU4gUkZDIFBBVENIIDI0LzQwXSB4ZW4vYXJtOiBpbnRyb2R1Y2UgYSBoZWxwZXIg dG8NCj4gPiA+IHBhcnNlDQo+ID4gPiA+ID4gZGV2aWNlIHRyZWUgTlVNQSBkaXN0YW5jZSBtYXAN Cj4gPiA+ID4gPg0KPiA+ID4gPiA+IE9uIFdlZCwgMTEgQXVnIDIwMjEsIFdlaSBDaGVuIHdyb3Rl Og0KPiA+ID4gPiA+ID4gQSBOVU1BIGF3YXJlIGRldmljZSB0cmVlIHdpbGwgcHJvdmlkZSBhICJk aXN0YW5jZS1tYXAiIG5vZGUgdG8NCj4gPiA+ID4gPiA+IGRlc2NyaWJlIGRpc3RhbmNlIGJldHdl ZW4gYW55IHR3byBub2Rlcy4gVGhpcyBwYXRjaCBpbnRyb2R1Y2UgYQ0KPiA+ID4gPiA+ID4gbmV3 IGhlbHBlciB0byBwYXJzZSB0aGlzIGRpc3RhbmNlIG1hcC4NCj4gPiA+ID4gPiA+DQo+ID4gPiA+ ID4gPiBTaWduZWQtb2ZmLWJ5OiBXZWkgQ2hlbiA8d2VpLmNoZW5AYXJtLmNvbT4NCj4gPiA+ID4g PiA+IC0tLQ0KPiA+ID4gPiA+ID4gIHhlbi9hcmNoL2FybS9udW1hX2RldmljZV90cmVlLmMgfCA2 Nw0KPiA+ID4gKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrDQo+ID4gPiA+ID4gPiAg MSBmaWxlIGNoYW5nZWQsIDY3IGluc2VydGlvbnMoKykNCj4gPiA+ID4gPiA+DQo+ID4gPiA+ID4g PiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gvYXJtL251bWFfZGV2aWNlX3RyZWUuYw0KPiA+ID4gPiA+ IGIveGVuL2FyY2gvYXJtL251bWFfZGV2aWNlX3RyZWUuYw0KPiA+ID4gPiA+ID4gaW5kZXggYmJl MDgxZGNkMS4uNmUwZDFkM2Q5ZiAxMDA2NDQNCj4gPiA+ID4gPiA+IC0tLSBhL3hlbi9hcmNoL2Fy bS9udW1hX2RldmljZV90cmVlLmMNCj4gPiA+ID4gPiA+ICsrKyBiL3hlbi9hcmNoL2FybS9udW1h X2RldmljZV90cmVlLmMNCj4gPiA+ID4gPiA+IEBAIC0yMDAsMyArMjAwLDcwIEBAIGRldmljZV90 cmVlX3BhcnNlX251bWFfbWVtb3J5X25vZGUoY29uc3QNCj4gdm9pZA0KPiA+ID4gKmZkdCwNCj4g PiA+ID4gPiBpbnQgbm9kZSwNCj4gPiA+ID4gPiA+DQo+ID4gPiA+ID4gPiAgICAgIHJldHVybiAw Ow0KPiA+ID4gPiA+ID4gIH0NCj4gPiA+ID4gPiA+ICsNCj4gPiA+ID4gPiA+ICsvKiBQYXJzZSBO VU1BIGRpc3RhbmNlIG1hcCB2MSAqLw0KPiA+ID4gPiA+ID4gK2ludCBfX2luaXQNCj4gPiA+ID4g PiA+ICtkZXZpY2VfdHJlZV9wYXJzZV9udW1hX2Rpc3RhbmNlX21hcF92MShjb25zdCB2b2lkICpm ZHQsIGludA0KPiBub2RlKQ0KPiA+ID4gPiA+ID4gK3sNCj4gPiA+ID4gPiA+ICsgICAgY29uc3Qg c3RydWN0IGZkdF9wcm9wZXJ0eSAqcHJvcDsNCj4gPiA+ID4gPiA+ICsgICAgY29uc3QgX19iZTMy ICptYXRyaXg7DQo+ID4gPiA+ID4gPiArICAgIGludCBlbnRyeV9jb3VudCwgbGVuLCBpOw0KPiA+ ID4gPiA+ID4gKw0KPiA+ID4gPiA+ID4gKyAgICBwcmludGsoWEVOTE9HX0lORk8gIk5VTUE6IHBh cnNpbmcgbnVtYS1kaXN0YW5jZS1tYXBcbiIpOw0KPiA+ID4gPiA+ID4gKw0KPiA+ID4gPiA+ID4g KyAgICBwcm9wID0gZmR0X2dldF9wcm9wZXJ0eShmZHQsIG5vZGUsICJkaXN0YW5jZS1tYXRyaXgi LCAmbGVuKTsNCj4gPiA+ID4gPiA+ICsgICAgaWYgKCAhcHJvcCApDQo+ID4gPiA+ID4gPiArICAg IHsNCj4gPiA+ID4gPiA+ICsgICAgICAgIHByaW50ayhYRU5MT0dfV0FSTklORw0KPiA+ID4gPiA+ ID4gKyAgICAgICAgICAgICAgICJOVU1BOiBObyBkaXN0YW5jZS1tYXRyaXggcHJvcGVydHkgaW4g ZGlzdGFuY2UtDQo+ID4gPiBtYXBcbiIpOw0KPiA+ID4gPiA+ID4gKw0KPiA+ID4gPiA+ID4gKyAg ICAgICAgcmV0dXJuIC1FSU5WQUw7DQo+ID4gPiA+ID4gPiArICAgIH0NCj4gPiA+ID4gPiA+ICsN Cj4gPiA+ID4gPiA+ICsgICAgaWYgKCBsZW4gJSBzaXplb2YodWludDMyX3QpICE9IDAgKQ0KPiA+ ID4gPiA+ID4gKyAgICB7DQo+ID4gPiA+ID4gPiArICAgICAgICBwcmludGsoWEVOTE9HX1dBUk5J TkcNCj4gPiA+ID4gPiA+ICsgICAgICAgICAgICAgICAiZGlzdGFuY2UtbWF0cml4IGluIG5vZGUg aXMgbm90IGEgbXVsdGlwbGUgb2YNCj4gPiA+IHUzMlxuIik7DQo+ID4gPiA+ID4gPiArICAgICAg ICByZXR1cm4gLUVJTlZBTDsNCj4gPiA+ID4gPiA+ICsgICAgfQ0KPiA+ID4gPiA+ID4gKw0KPiA+ ID4gPiA+ID4gKyAgICBlbnRyeV9jb3VudCA9IGxlbiAvIHNpemVvZih1aW50MzJfdCk7DQo+ID4g PiA+ID4gPiArICAgIGlmICggZW50cnlfY291bnQgPD0gMCApDQo+ID4gPiA+ID4gPiArICAgIHsN Cj4gPiA+ID4gPiA+ICsgICAgICAgIHByaW50ayhYRU5MT0dfV0FSTklORyAiTlVNQTogSW52YWxp ZCBkaXN0YW5jZS0NCj4gbWF0cml4XG4iKTsNCj4gPiA+ID4gPiA+ICsNCj4gPiA+ID4gPiA+ICsg ICAgICAgIHJldHVybiAtRUlOVkFMOw0KPiA+ID4gPiA+ID4gKyAgICB9DQo+ID4gPiA+ID4gPiAr DQo+ID4gPiA+ID4gPiArICAgIG1hdHJpeCA9IChjb25zdCBfX2JlMzIgKilwcm9wLT5kYXRhOw0K PiA+ID4gPiA+ID4gKyAgICBmb3IgKCBpID0gMDsgaSArIDIgPCBlbnRyeV9jb3VudDsgaSArPSAz ICkNCj4gPiA+ID4gPiA+ICsgICAgew0KPiA+ID4gPiA+ID4gKyAgICAgICAgdWludDMyX3QgZnJv bSwgdG8sIGRpc3RhbmNlOw0KPiA+ID4gPiA+ID4gKw0KPiA+ID4gPiA+ID4gKyAgICAgICAgZnJv bSA9IGR0X3JlYWRfbnVtYmVyKG1hdHJpeCwgMSk7DQo+ID4gPiA+ID4gPiArICAgICAgICBtYXRy aXgrKzsNCj4gPiA+ID4gPiA+ICsgICAgICAgIHRvID0gZHRfcmVhZF9udW1iZXIobWF0cml4LCAx KTsNCj4gPiA+ID4gPiA+ICsgICAgICAgIG1hdHJpeCsrOw0KPiA+ID4gPiA+ID4gKyAgICAgICAg ZGlzdGFuY2UgPSBkdF9yZWFkX251bWJlcihtYXRyaXgsIDEpOw0KPiA+ID4gPiA+ID4gKyAgICAg ICAgbWF0cml4Kys7DQo+ID4gPiA+ID4gPiArDQo+ID4gPiA+ID4gPiArICAgICAgICBpZiAoIChm cm9tID09IHRvICYmIGRpc3RhbmNlICE9IE5VTUFfTE9DQUxfRElTVEFOQ0UpIHx8DQo+ID4gPiA+ ID4gPiArICAgICAgICAgICAgKGZyb20gIT0gdG8gJiYgZGlzdGFuY2UgPD0gTlVNQV9MT0NBTF9E SVNUQU5DRSkgKQ0KPiA+ID4gPiA+ID4gKyAgICAgICAgew0KPiA+ID4gPiA+ID4gKyAgICAgICAg ICAgIHByaW50ayhYRU5MT0dfV0FSTklORw0KPiA+ID4gPiA+ID4gKyAgICAgICAgICAgICAgICAg ICAiSW52YWxpZCBub2RlcycgZGlzdGFuY2UgZnJvbSBub2RlIyVkIHRvDQo+IG5vZGUjJWQNCj4g PiA+ID4gPiA9ICVkXG4iLA0KPiA+ID4gPiA+ID4gKyAgICAgICAgICAgICAgICAgICBmcm9tLCB0 bywgZGlzdGFuY2UpOw0KPiA+ID4gPiA+ID4gKyAgICAgICAgICAgIHJldHVybiAtRUlOVkFMOw0K PiA+ID4gPiA+ID4gKyAgICAgICAgfQ0KPiA+ID4gPiA+ID4gKw0KPiA+ID4gPiA+ID4gKyAgICAg ICAgcHJpbnRrKFhFTkxPR19JTkZPICJOVU1BOiBkaXN0YW5jZSBmcm9tIG5vZGUjJWQgdG8NCj4g bm9kZSMlZA0KPiA+ID4gPiA+ID0gJWRcbiIsDQo+ID4gPiA+ID4gPiArICAgICAgICAgICAgICAg ZnJvbSwgdG8sIGRpc3RhbmNlKTsNCj4gPiA+ID4gPiA+ICsgICAgICAgIG51bWFfc2V0X2Rpc3Rh bmNlKGZyb20sIHRvLCBkaXN0YW5jZSk7DQo+ID4gPiA+ID4gPiArDQo+ID4gPiA+ID4gPiArICAg ICAgICAvKiBTZXQgZGVmYXVsdCBkaXN0YW5jZSBvZiBub2RlIEItPkEgc2FtZSBhcyBBLT5CICov DQo+ID4gPiA+ID4gPiArICAgICAgICBpZiAodG8gPiBmcm9tKQ0KPiA+ID4gPiA+ID4gKyAgICAg ICAgICAgICBudW1hX3NldF9kaXN0YW5jZSh0bywgZnJvbSwgZGlzdGFuY2UpOw0KPiA+ID4gPiA+ DQo+ID4gPiA+ID4gSSBhbSBhIGJpdCB1bnN1cmUgYWJvdXQgdGhpcyBsYXN0IDIgbGluZXM6IHdo eSBjYWxsaW5nDQo+ID4gPiBudW1hX3NldF9kaXN0YW5jZQ0KPiA+ID4gPiA+IGluIHRoZSBvcHBv c2l0ZSBkaXJlY3Rpb24gb25seSB3aGVuIHRvID4gZnJvbT8gV291bGRuJ3QgaXQgYmUgT0sNCj4g dG8NCj4gPiA+ID4gPiBhbHdheXMgZG8gYm90aDoNCj4gPiA+ID4gPg0KPiA+ID4gPiA+IG51bWFf c2V0X2Rpc3RhbmNlKGZyb20sIHRvLCBkaXN0YW5jZSk7DQo+ID4gPiA+ID4gbnVtYV9zZXRfZGlz dGFuY2UodG8sIGZyb20sIGRpc3RhbmNlKTsNCj4gPiA+ID4gPg0KPiA+ID4gPiA+ID8NCj4gPiA+ ID4gPg0KPiA+ID4gPiBJIGJvcnJvd2VkIHRoaXMgY29kZSBmcm9tIExpbnV4LCBidXQgaGVyZSBp cyBteSB1bmRlcnN0YW5kaW5nOg0KPiA+ID4gPg0KPiA+ID4gPiBGaXJzdCwgSSByZWFkIHNvbWUg bm90ZXMgaW4NCj4gRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL251bWEudHh0DQo+ ID4gPiA+IDEuIEVhY2ggZW50cnkgcmVwcmVzZW50cyBkaXN0YW5jZSBmcm9tIGZpcnN0IG5vZGUg dG8gc2Vjb25kIG5vZGUuDQo+ID4gPiA+IFRoZSBkaXN0YW5jZXMgYXJlIGVxdWFsIGluIGVpdGhl ciBkaXJlY3Rpb24uDQo+ID4gPiA+IDIuIGRpc3RhbmNlLW1hdHJpeCBzaG91bGQgaGF2ZSBlbnRy aWVzIGluIGxleGljb2dyYXBoaWNhbCBhc2NlbmRpbmcNCj4gPiA+ID4gb3JkZXIgb2Ygbm9kZXMu DQo+ID4gPiA+DQo+ID4gPiA+IEhlcmUgaXMgYW4gZXhhbXBsZSBvZiBkaXN0YW5jZS1tYXAgbm9k ZSBpbiBEVEI6DQo+ID4gPiA+IFNhbXBsZSMxLCBmdWxsIGxpc3Q6DQo+ID4gPiA+IAkJZGlzdGFu Y2UtbWFwIHsNCj4gPiA+ID4gCQkJIGNvbXBhdGlibGUgPSAibnVtYS1kaXN0YW5jZS1tYXAtdjEi Ow0KPiA+ID4gPiAJCQkgZGlzdGFuY2UtbWF0cml4ID0gPDAgMCAgMTA+LA0KPiA+ID4gPiAJCQkJ CSAgIDwwIDEgIDIwPiwNCj4gPiA+ID4gCQkJCQkgICA8MCAyICA0MD4sDQo+ID4gPiA+IAkJCQkJ ICAgPDAgMyAgMjA+LA0KPiA+ID4gPiAJCQkJCSAgIDwxIDAgIDIwPiwNCj4gPiA+ID4gCQkJCQkg ICA8MSAxICAxMD4sDQo+ID4gPiA+IAkJCQkJICAgPDEgMiAgMjA+LA0KPiA+ID4gPiAJCQkJCSAg IDwxIDMgIDQwPiwNCj4gPiA+ID4gCQkJCQkgICA8MiAwICA0MD4sDQo+ID4gPiA+IAkJCQkJICAg PDIgMSAgMjA+LA0KPiA+ID4gPiAJCQkJCSAgIDwyIDIgIDEwPiwNCj4gPiA+ID4gCQkJCQkgICA8 MiAzICAyMD4sDQo+ID4gPiA+IAkJCQkJICAgPDMgMCAgMjA+LA0KPiA+ID4gPiAJCQkJCSAgIDwz IDEgIDQwPiwNCj4gPiA+ID4gCQkJCQkgICA8MyAyICAyMD4sDQo+ID4gPiA+IAkJCQkJICAgPDMg MyAgMTA+Ow0KPiA+ID4gPiAJCX07DQo+ID4gPiA+DQo+ID4gPiA+IENhbGwgbnVtYV9zZXRfZGlz dGFuY2Ugd2hlbiAidG8gPiBmcm9tIiB3aWxsIHByZXZlbnQgWGVuIHRvIGNhbGwNCj4gPiA+ID4g bnVtYV9zZXRfZGlzdGFuY2UoMCwgMSwgMjApIGFnYWluIHdoZW4gaXQncyBzZXR0aW5nIGRpc3Rh bmNlIGZvciA8MQ0KPiAwDQo+ID4gPiAyMD4uDQo+ID4gPiA+IEJ1dCwgbnVtYV9zZXRfZGlzdGFu Y2UoMSwgMCwgMjApIHdpbGwgYmUgY2FsbCB0d2ljZS4NCj4gPiA+ID4NCj4gPiA+ID4gTm9ybWFs bHksIGRpc3RhbmNlLW1hcCBub2RlIHdpbGwgYmUgb3B0aW1pemVkIGluIGZvbGxvd2luZyBzYW1w bGUjMiwNCj4gPiA+ID4gYWxsIHJlZHVuZGFudCBlbnRyaWVzIGFyZSByZW1vdmVkOg0KPiA+ID4g PiBTYW1wbGUjMiwgcGFydGlhbCBsaXN0Og0KPiA+ID4gPiAJCWRpc3RhbmNlLW1hcCB7DQo+ID4g PiA+IAkJCSBjb21wYXRpYmxlID0gIm51bWEtZGlzdGFuY2UtbWFwLXYxIjsNCj4gPiA+ID4gCQkJ IGRpc3RhbmNlLW1hdHJpeCA9IDwwIDAgIDEwPiwNCj4gPiA+ID4gCQkJCQkgICA8MCAxICAyMD4s DQo+ID4gPiA+IAkJCQkJICAgPDAgMiAgNDA+LA0KPiA+ID4gPiAJCQkJCSAgIDwwIDMgIDIwPiwN Cj4gPiA+ID4gCQkJCQkgICA8MSAxICAxMD4sDQo+ID4gPiA+IAkJCQkJICAgPDEgMiAgMjA+LA0K PiA+ID4gPiAJCQkJCSAgIDwxIDMgIDQwPiwNCj4gPiA+ID4gCQkJCQkgICA8MiAyICAxMD4sDQo+ ID4gPiA+IAkJCQkJICAgPDIgMyAgMjA+LA0KPiA+ID4gPiAJCQkJCSAgIDwzIDMgIDEwPjsNCj4g PiA+ID4gCQl9Ow0KPiA+ID4gPg0KPiA+ID4gPiBUaGVyZSBpcyBub3QgYW55ICJmcm9tID4gdG8i IGVudHJ5IGluIHRoZSBtYXAuIEJ1dCB1c2luZyB0aGlzDQo+IHBhcnRpYWwNCj4gPiA+IG1hcA0K PiA+ID4gPiBzdGlsbCBjYW4gc2V0IGFsbCBkaXN0YW5jZXMgZm9yIGFsbCBwYWlycy4gQW5kIG51 bWFfc2V0X2Rpc3RhbmNlKDEsDQo+IDAsDQo+ID4gPiAyMCkNCj4gPiA+ID4gd2lsbCBiZSBvbmx5 IG9uY2UuDQo+ID4gPg0KPiA+ID4gSSBzZWUuIEkgY2FuJ3QgZmluZCBpbiBEb2N1bWVudGF0aW9u L2RldmljZXRyZWUvYmluZGluZ3MvbnVtYS50eHQNCj4gd2hlcmUNCj4gPiA+IGl0IHNheXMgdGhh dCAiZnJvbSA+IHRvIiBub2RlcyBjYW4gYmUgb21pdHRlZC4gSWYgaXQgaXMgbm90IHdyaXR0ZW4N Cj4gPiA+IGRvd24sIHRoZW4gc29tZWJvZHkgY291bGQgZWFzaWx5IG9wdGltaXplIGl0IHRoZSBv cHBvc2l0ZSB3YXk6DQo+ID4gPg0KPiA+ID4gIAkJCSBkaXN0YW5jZS1tYXRyaXggPSA8MCAwICAx MD4sDQo+ID4gPiAgCQkJCQkgICA8MSAwICAyMD4sDQo+ID4gPiAgCQkJCQkgICA8MiAwICA0MD4s DQo+ID4gPiAgCQkJCQkgICA8MyAwICAyMD4sDQo+ID4gPiAgCQkJCQkgICA8MSAxICAxMD4sDQo+ ID4gPiAgCQkJCQkgICA8MiAxICAyMD4sDQo+ID4gPiAgCQkJCQkgICA8MyAxICA0MD4sDQo+ID4g PiAgCQkJCQkgICA8MiAyICAxMD4sDQo+ID4gPiAgCQkJCQkgICA8MyAyICAyMD4sDQo+ID4gPiAg CQkJCQkgICA8MyAzICAxMD47DQo+ID4gPg0KPiA+DQo+ID4gWWVzLCB5b3UncmUgcmlnaHQuIFNw ZWMgZG9lc24ndCBzYXkgb3Bwb3NpdGUgd2F5IGlzIHVuYWxsb3dlZC4NCj4gPg0KPiA+ID4gSSB0 aGluayB0aGUgY29kZSBpbiBYZW4gc2hvdWxkIGJlIHJlc2lsaWVudCBhbmQgYWJsZSB0byBjb3Bl IHdpdGggYQ0KPiA+ID4gZGV2aWNlIHRyZWUgbGlrZSB0aGUgb25lIHlvdSB3cm90ZSBvciB0aGUg b25lIEkgd3JvdGUuIEZyb20gYSBjb2RlDQo+ID4gPiBwZXJzcGVjdGl2ZSwgaXQgc2hvdWxkIGJl IHZlcnkgZWFzeSB0byBkby4gSWYgbm90aGluZyBlbHNlIGl0IHdvdWxkDQo+IG1ha2UNCj4gPiA+ IFhlbiBtb3JlIHJlc2lsaWVudCBhZ2FpbnN0IGJ1Z2d5IGZpcm13YXJlLg0KPiA+ID4NCj4gPiA+ DQo+ID4NCj4gPiBJIGRvbid0IGRpc2FncmVlIHdpdGggdGhhdC4NCj4gPg0KPiA+ID4gPiA+IEJ1 dCBpbiBhbnkgY2FzZSwgSSBoYXZlIGEgZGlmZmVyZW50IHN1Z2dlc3Rpb24uIFRoZSBiaW5kaW5n IHN0YXRlcw0KPiA+ID4gdGhhdA0KPiA+ID4gPiA+ICJkaXN0YW5jZXMgYXJlIGVxdWFsIGluIGVp dGhlciBkaXJlY3Rpb24iLiBBbHNvIGl0IGhhcyBhbiBleGFtcGxlDQo+ID4gPiB3aGVyZQ0KPiA+ ID4gPiA+IG9ubHkgb25lIGRpcmVjdGlvbiBpcyBleHByZXNzZWQgdW5mb3J0dW5hdGVseSAoYXQg dGhlIGVuZCBvZiB0aGUNCj4gPiA+ID4gPiBkb2N1bWVudCkuDQo+ID4gPiA+ID4NCj4gPiA+ID4N Cj4gPiA+ID4gT2gsIEkgc2hvdWxkIHNlZSB0aGlzIGNvbW1lbnQgZmlyc3QsIHRoZW4gSSB3aWxs IG5vdCBwb3N0IGFib3ZlDQo+ID4gPiA+IGNvbW1lbnQgOiApDQo+ID4gPiA+DQo+ID4gPiA+ID4g U28gbXkgc3VnZ2VzdGlvbiBpcyB0byBwYXJzZSBpdCBhcyBmb2xsb3dzOg0KPiA+ID4gPiA+DQo+ ID4gPiA+ID4gLSBjYWxsIG51bWFfc2V0X2Rpc3RhbmNlIGp1c3Qgb25jZSBmcm9tDQo+ID4gPiA+ ID4gICBkZXZpY2VfdHJlZV9wYXJzZV9udW1hX2Rpc3RhbmNlX21hcF92MQ0KPiA+ID4gPiA+DQo+ ID4gPiA+ID4gLSBpbiBudW1hX3NldF9kaXN0YW5jZToNCj4gPiA+ID4gPiAgICAgLSBzZXQgbm9k ZV9kaXN0YW5jZV9tYXBbZnJvbV1bdG9dID0gZGlzdGFuY2U7DQo+ID4gPiA+ID4gICAgIC0gY2hl Y2sgbm9kZV9kaXN0YW5jZV9tYXBbdG9dW2Zyb21dDQo+ID4gPiA+ID4gICAgICAgICAgIC0gaWYg dW5zZXQsIG5vZGVfZGlzdGFuY2VfbWFwW3RvXVtmcm9tXSA9IGRpc3RhbmNlOw0KPiA+ID4gPiA+ ICAgICAgICAgICAtIGlmIGFscmVhZHkgc2V0IHRvIHRoZSBzYW1lIHZhbHVlLCByZXR1cm4gc3Vj Y2VzczsNCj4gPiA+ID4gPiAgICAgICAgICAgLSBpZiBhbHJlYWR5IHNldCB0byBhIGRpZmZlcmVu dCB2YWx1ZSwgcmV0dXJuIGVycm9yOw0KPiA+ID4gPg0KPiA+ID4gPiBJIGRvbid0IHJlYWxseSBs aWtlIHRoaXMgaW1wbGVtZW50YXRpb24uIEkgd2FudCB0aGUgYmVoYXZpb3Igb2YNCj4gPiA+ID4g bnVtYV9zZXRfZGlzdGFuY2UganVzdCBsaWtlIHRoZSBmdW5jdGlvbiBuYW1lLCBkbyBub3QgaW5j bHVkZQ0KPiA+ID4gPiBpbXBsaWNpdCBvcGVyYXRpb25zLiBPdGhlcndpc2UsIGV4Y2VwdCB0aGUg dXNlciByZWFkIHRoaXMgZnVuY3Rpb24NCj4gPiA+ID4gaW1wbGVtZW50YXRpb24gYmVmb3JlIGhl IHVzZSBpdCwgaGUgcHJvYmFibHkgZG9lc24ndCBrbm93IHRoaXMNCj4gPiA+ID4gZnVuY3Rpb24g aGFzIGRvbmUgc28gbWFueSB0aGluZ3MuDQo+ID4gPg0KPiA+ID4gWW91IGNhbiBsZWF2ZSBudW1h X3NldF9kaXN0YW5jZSBhcy1pcyB3aXRob3V0IGFueSBpbXBsaWNpdCBvcGVyYXRpb25zLg0KPiA+ ID4NCj4gPiA+IEluIHRoYXQgY2FzZSwganVzdCBjYWxsIG51bWFfc2V0X2Rpc3RhbmNlIHR3aWNl IGZyb20gbnVtYV9zZXRfZGlzdGFuY2UNCj4gPiA+IGZvciBib3RoIGZyb20vdG8gYW5kIHRvL2Zy b20uIG51bWFfc2V0X2Rpc3RhbmNlIGNvdWxkIHJldHVybiBlcnJvciBpcw0KPiA+DQo+ID4gSSBh bSBPSyBmb3IgdGhlIGZpcnN0IHNlbnRlbmNlLiBCdXQuLi4NCj4gPg0KPiA+ID4gdGhlIGVudHJ5 IHdhcyBhbHJlYWR5IHNldCB0byBhIGRpZmZlcmVudCB2YWx1ZSBvciBzdWNjZXNzIG90aGVyd2lz ZQ0KPiA+ID4gKGFsc28gaW4gdGhlIGNhc2UgaXQgd2FzIGFscmVhZHkgc2V0IHRvIHRoZSBzYW1l IHZhbHVlKS4gVGhpcyB3b3VsZA0KPiA+DQo+ID4gLi4uIEkgcHJlZmVyIG5vdCB0byBjaGVjayB0 aGUgcHJldmlvdXMgdmFsdWUuIFN1YnNlcXVlbnQNCj4gbnVtYV9zZXRfZGlzdGFuY2UNCj4gPiBj YWxsIHdpbGwgb3ZlcnJpZGUgcHJldmlvdXMgY2FsbHMuIEtlZXAgbnVtYV9zZXRfZGlzdGFuY2Ug YXMgc2ltcGxlIGFzDQo+ID4gaXQgY2FuLiBBbmQgd2hlbiB5b3UgcGFzcyBuZXcgZGF0YSB0byBu dW1hX3NldF9kaXN0YW5jZSwgaXQgZG9lc24ndA0KPiA+IGtub3cgd2hldGhlciB0aGUgcHJldmlv dXMgZGF0YSB3YXMgY29ycmVjdCBvciB0aGUgbmV3IGRhdGEgaXMgY29ycmVjdC4NCj4gPiBPbmx5 IGNhbGxlciBtYXkgaGF2ZSBrbm93bi4NCj4gDQo+IFRoYXQgbWlnaHQgYmUgT0sgYnV0IGlmIG5v dCBudW1hX3NldF9kaXN0YW5jZSB0aGVuIHNvbWVib2R5IGVsc2UgbmVlZHMNCj4gdG8gY2hlY2sg YWdhaW5zdCBvdmVyd3JpdGluZyBwcmV2aW91cyB2YWx1ZXMuIFRoYXQgaXMgdG8gYmUgYWJsZSB0 byBzcG90DQo+IGJhZCBkZXZpY2UgdHJlZSBjYXNlcyBsaWtlOg0KPiANCj4gICAwIDEgMjANCj4g ICAxIDAgNDANCg0KDQpIb3cgYWJvdXQgd2UgY2hlY2sgaXQgc3RpbGwgaW4gTlVNQSBkaXN0YW5j ZSBwYXJzZSBmdW5jdGlvbj8NCkJlZm9yZSBzZXR0aW5nIHRoZSBudW1hX3NldF9kaXN0YW5jZSBm b3Igb25lIHBhaXIgbm9kZXMgKGUuZy4gYSAtPiBiKSwNCndlIGNhbiBnZXQgaXRzIG9wcG9zaXRl IHdheSBkaXN0YW5jZSBmaXJzdC4NCg0KZGlzdGFuY2VfYl9hID0gX19ub2RlX2Rpc3RhbmNlKGIs IGEpOyA9PT4gZ2V0IG9wcG9zaXRlIHdheSBkaXN0YW5jZS4NCmlmIChkaXN0YW5jZV9iX2EgPT0g MCkgPT0+IG9wcG9zaXRlIHdheSBkaXN0YW5jZSBoYXMgbm90IGJlZW4gc2V0DQp7DQogICAgbnVt YV9zZXRfZGlzdGFuY2UoYSwgYiwgMjApOyA9PT4gc2V0IGJvdGgNCiAgICBudW1hX3NldF9kaXN0 YW5jZShiLCBhLCAyMCkNCn0gZWxzZSB7DQogICAgaWYgKGRpc3RhbmNlX2JfYSA9PSAyMCkgPT0+ IG9wcG9zaXRlIHdheSBkaXN0YW5jZSBoYXMgYmVlbiBzZXQNCiAgICAgICBudW1hX3NldF9kaXN0 YW5jZShhLCBiLCAyMCk7ID09PiBzZXQgdGhpcyB3YXkgb25seQ0KICAgIGVsc2UgPT09PiBvcHBv c2l0ZSB3YXkgZGlzdGFuY2UgaGFzIGJlZW4gc2V0LCBidXQgaXMgdW5tYXRjaGVkDQogICAgICAg Ly8gV2hhdCBjYW4gd2UgZG8gaGVyZT8NCiAgICAgICBQYW5pYyB0aGUgc3lzdGVtPyBvciBKdXN0 IHdhcm5pbmcgdXNlcnM/IE9yIGNob29zZSB0aGUgYmlnZ2VyDQogICAgICAgZGlzdGFuY2UgZm9y IGJvdGggd2F5cz8NCiAgICAgICANCiAgICAgICBBbmQgZGlzdGFuY2VfYl9hID09IE5VTUFfTk9f RElTVEFOQ0Ugd291bGQgYmUgYSBzcGVjaWFsIGNhc2UNCiAgICAgICBoZXJlLg0KfQ0KDQoNCg== From xen-devel-bounces@lists.xenproject.org Thu Sep 02 02:34:33 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 02:34:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.176823.321816 (Exim 4.92) (envelope-from ) id 1mLcYj-0008Te-53; Thu, 02 Sep 2021 02:34:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 176823.321816; Thu, 02 Sep 2021 02:34:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLcYj-0008TX-1D; Thu, 02 Sep 2021 02:34:33 +0000 Received: by outflank-mailman (input) for mailman id 176823; Thu, 02 Sep 2021 02:34:31 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLcYg-0008T6-Sd for xen-devel@lists.xenproject.org; Thu, 02 Sep 2021 02:34:31 +0000 Received: from outbound.mail.eo.outlook.com (unknown [40.93.8.3]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id de8bd298-0d55-4c9e-b611-760d29c6a1b8; Thu, 02 Sep 2021 02:34:28 +0000 (UTC) Received: from MWHPR21MB1593.namprd21.prod.outlook.com (2603:10b6:301:7c::11) by CO1PR21MB1313.namprd21.prod.outlook.com (2603:10b6:303:150::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.1; Thu, 2 Sep 2021 02:34:21 +0000 Received: from MWHPR21MB1593.namprd21.prod.outlook.com ([fe80::3c8b:6387:cd5:7d86]) by MWHPR21MB1593.namprd21.prod.outlook.com ([fe80::3c8b:6387:cd5:7d86%8]) with mapi id 15.20.4478.014; Thu, 2 Sep 2021 02:34:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: de8bd298-0d55-4c9e-b611-760d29c6a1b8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jCx04av9Xh77Ekv4nMdxj0EWuugkjJrPzsF+MpmbIaRcQvM+RxnE3gxDGupHQtUqDAwH69IrhLnYRqRtsE0dyrAMuhQbdUUSTCf8jLuL8Y/ajPuKCgslBJYAaOhyjsJ9aAb0woCKZt8knhURMmLjSAgct2Pherw8Q+qZ5AwQ4XRyNOMOU6ODl4lZhnAlBjvNMLGMWnF89eQIt/TcWCU6iRRvm8BpiSy1zsKr/ei4C6rkMxjTJpoqxj2ik0Y5vuPX64oRCvbKgmYgU+y4LGqpA9mu6ASDNNdDh86jFkGm9q+k3Qpy0qXgEB2oztT1+iFxNGuYbKxaQ9du/ld91anWWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=QKy56hNGj4/CPd4BTTIQaQKfTgUrKi7AodsQzErWTDY=; b=iIgSUeLqi9iUloQ1Cc5dm0nvKICmqky/SvABYtH+RfK9BRa8NCOM1G1bcKlpL5O39rmq9UG6FTPeLJWthPU/Yu3V2RXHJBdltqOxmW+RkIur9uNtWcXxLP325q++G7IM1IGslVgaA6ajgXsNlSXYesLJeme/UqaQTgkYmnCxTgp1NRWU5vuGG1m4rdFsjugqQRVOf+6blEBNe/vHPbyFrHE/Gd00tTuCl7CPuN1Bun+hya4bTeD9Gx2Tgv8xySjHvNho2+JzL1C5xisdBEOv6bCNzjFwLv0Q5D3dNaWugkI9uXwjg8SLXNlv/VWVMiCc0eIDUelM3ddYuwFY3Vi16w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QKy56hNGj4/CPd4BTTIQaQKfTgUrKi7AodsQzErWTDY=; b=IpmkJTL5nBImCGGLSxRDJrrQor9sZgWdUpecAJfxBth+eYiOc/0sRoJ+IYAN0DbwJjuStPeTlMIvhX8QXnwhdKMBhr//AjVAPIMo9LeKKWrjwAKUhkp+U7ZPavc14xU/3VaEJ3eGEMjkYoUB9BUAxvdziaUyBK9w7C9Ni1z6AfI= From: Michael Kelley To: Tianyu Lan , KY Srinivasan , Haiyang Zhang , Stephen Hemminger , "wei.liu@kernel.org" , Dexuan Cui , "catalin.marinas@arm.com" , "will@kernel.org" , "tglx@linutronix.de" , "mingo@redhat.com" , "bp@alien8.de" , "x86@kernel.org" , "hpa@zytor.com" , "dave.hansen@linux.intel.com" , "luto@kernel.org" , "peterz@infradead.org" , "konrad.wilk@oracle.com" , "boris.ostrovsky@oracle.com" , "jgross@suse.com" , "sstabellini@kernel.org" , "joro@8bytes.org" , "davem@davemloft.net" , "kuba@kernel.org" , "jejb@linux.ibm.com" , "martin.petersen@oracle.com" , "gregkh@linuxfoundation.org" , "arnd@arndb.de" , "hch@lst.de" , "m.szyprowski@samsung.com" , "robin.murphy@arm.com" , "brijesh.singh@amd.com" , "thomas.lendacky@amd.com" , Tianyu Lan , "pgonda@google.com" , "martin.b.radev@gmail.com" , "akpm@linux-foundation.org" , "kirill.shutemov@linux.intel.com" , "rppt@kernel.org" , "hannes@cmpxchg.org" , "aneesh.kumar@linux.ibm.com" , "krish.sadhukhan@oracle.com" , "saravanand@fb.com" , "linux-arm-kernel@lists.infradead.org" , "xen-devel@lists.xenproject.org" , "rientjes@google.com" , "ardb@kernel.org" CC: "iommu@lists.linux-foundation.org" , "linux-arch@vger.kernel.org" , "linux-hyperv@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-scsi@vger.kernel.org" , "netdev@vger.kernel.org" , vkuznets , "parri.andrea@gmail.com" , "dave.hansen@intel.com" Subject: RE: [PATCH V4 12/13] hv_netvsc: Add Isolation VM support for netvsc driver Thread-Topic: [PATCH V4 12/13] hv_netvsc: Add Isolation VM support for netvsc driver Thread-Index: AQHXm2gP6jy1GRuc+0K7S1qphPLgHKuQCC+w Date: Thu, 2 Sep 2021 02:34:21 +0000 Message-ID: References: <20210827172114.414281-1-ltykernel@gmail.com> <20210827172114.414281-13-ltykernel@gmail.com> In-Reply-To: <20210827172114.414281-13-ltykernel@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ActionId=24c2ad3d-af1e-4524-bef7-f93352ae7e8f;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=true;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Standard;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=Internal;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2021-09-02T02:09:02Z;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=microsoft.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 689d41b7-625c-4abb-a483-08d96dba2bc1 x-ms-traffictypediagnostic: CO1PR21MB1313: x-ms-exchange-transport-forked: True x-ld-processed: 72f988bf-86f1-41af-91ab-2d7cd011db47,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2089; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: DAvZwmqwIU8z/VumI40sOIsAL8kY1QtKrD+eDOHx9Sz3XiadoCQcQobAFINlK3ApTacKo8PgaJfemchgf+GLNMTzHG08fpXiUrfUe4MJhuvMfdnT1kVSw5KOvrIgS3Enl8VZRwxQZlc5eqGhZRrc91vSx4ZB1ndPjIbuTF5x1+aDRwIIpA3GIRUSG8aiY1FFeDoVtrLRXMFBR/btQtBEY0xtLlHSGYC0nrfFdB4IWF+KYdBrF6pNpTZ3X+pY46fkK5md+aPJH6u6vM2TedUR+POIxPEbakPeeEj1/11JEYFI1FsNs87RKncViF2p4tSDV+P1sJ+7kjtVyaWCDS++zFv3/nfIYeay1/CT7rQ1fb9Vf8DZZZ4zBksxwXXtIC4jyWB/waxNHcN0mtI1DW393SpXA4a68MkCFUFk80JrGNfxEpTaC3FDP7hp14VoRMrSBP9sLWrC/hBDa0x8dF0kz3VCtUUlG8RS1ScK7vBzRfVSCPf7NC5niNrBGW09242FijzSE1spD5qKJ/Cod1nM74Rd55ec3fewa5tk2e1rHForKqOY9R6KucRXhvWBSVfkaf1BFKJXBXR/UO6ZMAXgQd7PfZn63JE2JEhrSRa5xjcclApHQTb+dJLtofa4MxMxZFkAS0A1QWKtgGUay2+aPJtmedGp8qa9f8FjG84Nt2Mo3B8CRCJAaSO5tLH92WwiMRVgXAeNrx7eVrHnbv0CiEt1tZGqCXCl6GS6IX3dGoI= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR21MB1593.namprd21.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(26005)(86362001)(76116006)(5660300002)(66946007)(186003)(54906003)(30864003)(921005)(66476007)(66556008)(64756008)(66446008)(7416002)(7366002)(7406005)(52536014)(2906002)(82960400001)(6506007)(316002)(82950400001)(9686003)(55016002)(8936002)(8990500004)(83380400001)(38100700002)(10290500003)(38070700005)(122000001)(8676002)(4326008)(508600001)(33656002)(7696005)(110136005)(71200400001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?xQlDpLVHR5QkNC1X7tRB4TxveZLJaQS1hw8CRJaKaAeeVaMhzp7LecYMifJh?= =?us-ascii?Q?s5wS2OsCPzuMHkmVRyjamNhZzwzDFRCeqRMAR3jtBg35DVJj1poV5cOfp0rd?= =?us-ascii?Q?OaN1z64LV+DT7xaTzo6vwp1wM7tIMQDoQ/YrK4+qjE4kXlRb62jCDIaaMlp9?= =?us-ascii?Q?8Ua0ik61reSOxctXQRuhxfeg2YidtdLKlzQZ+t6pSjN1S+GYNj6pJTcHr28x?= =?us-ascii?Q?9neCEGMaxMdhzndRPEvsqXou36pCHJKKzsGZnqaBxyIZ33ogDCQPqTyQaR0p?= =?us-ascii?Q?PJ/x+dRxTeSEWn8pJG/Hw8ygZVgc/YbqQLnkqBqBx8MjI9rJQMH9i5bcBSKv?= =?us-ascii?Q?AVh5p0g4KtSU54zj5Y4MjEoejzQfRvrdnqc9dCPWoPSCQr+DaKvIlV0Eusqm?= =?us-ascii?Q?VCipJ6alCUyB0ZpoB1AuH/fdqRrDEPoqAg2L/LZS199pA3MKCpjawD0UvIwj?= =?us-ascii?Q?MDwDxXvdfP6fkYJkpOs/xp4juA1fjtK9/Xr00TtC/TCULrcdCZ+a8fgK5DHp?= =?us-ascii?Q?K01HOwCJv608Ei39PuKX7T4v9A66WRGVcPoKDmCFDIqY0B0pVow7DKHCyHcp?= =?us-ascii?Q?61coUmemBmab6FzEIqyl5NACtoTvNJ9EyJP87A25QbCGTQibvQqk2rQM72NV?= =?us-ascii?Q?hDyGrG36RGqhhwoz2x0+pnu9biZOXlPjdnR+vLKN1NnfQl3yndjmPNRPsWyJ?= =?us-ascii?Q?z2yTjCswKMEME9zgqj72S79oxR8MAriVHWa21DSgkEJf5mulLWmK+3VoOhzT?= =?us-ascii?Q?+81GIePqODB1bMvXwzZjcd9Mw9WC5e0nnN9Gdt0g+Cqxz5HhTgCa/QdT8jb6?= =?us-ascii?Q?oMsXTvJ0zSAdhIVaHNMSsQ3r96c70O/EdlfunILaVpe9qV4UiUCnLXqQyqh6?= =?us-ascii?Q?8edXaMRqY6yOVkO6cjqi56xS3yD/wknEDIgPsoGLaJwlkf/lbRYx9M6iEUaH?= =?us-ascii?Q?cPWqL/u5F2i7eTpFSUUr3SfjGml4N/kFgfitpqe+ao0yOICH/K7iBqmg1CR+?= =?us-ascii?Q?Bj31b1hZtq4+AT+CCoq7seB3RTGKm7mKeV2OsOiRIHosYa/YN8adSNOZCNHg?= =?us-ascii?Q?DjiWfF2ofh+FvH0LArOcrWLTEIzJb7m68dvsF+1DeZsC4wTbxvbAFTu55oXy?= =?us-ascii?Q?v0KEB91O0Y8nsNzG9sFdzXT4fhghv6KcBHdWKq3dCbmRKwFqA+VvclfLKu8+?= =?us-ascii?Q?1UPzihMFvB19heOQB3gd20WEVh8tjULPLwtcN0QiejgDUz9oWj6Z+K8cOtyk?= =?us-ascii?Q?aXwtJHgUnv9id+DTfgkwUQ4F8T7W75VIFSTBxSpfPEetmFIFAY+EWrIgzc6c?= =?us-ascii?Q?6l+C3cUDAdMMToQg9hUG9EFd?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR21MB1593.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 689d41b7-625c-4abb-a483-08d96dba2bc1 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Sep 2021 02:34:21.2342 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: g08ziwEqEgDWZKHJyOVnRnVS6cDO5fPg8rfoY4T/qM5/GwGsBOZ+r3nX6j9fGc5D+JukmU5NjK7Zmkh8voCMtGf2u1QtxeKzRuqBo/ZDvrk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR21MB1313 From: Tianyu Lan Sent: Friday, August 27, 2021 10:21 = AM >=20 > In Isolation VM, all shared memory with host needs to mark visible > to host via hvcall. vmbus_establish_gpadl() has already done it for > netvsc rx/tx ring buffer. The page buffer used by vmbus_sendpacket_ > pagebuffer() stills need to be handled. Use DMA API to map/umap > these memory during sending/receiving packet and Hyper-V swiotlb > bounce buffer dma adress will be returned. The swiotlb bounce buffer > has been masked to be visible to host during boot up. >=20 > Signed-off-by: Tianyu Lan > --- > Change since v3: > * Add comment to explain why not to use dma_map_sg() > * Fix some error handle. > --- > arch/x86/hyperv/ivm.c | 1 + > drivers/net/hyperv/hyperv_net.h | 5 ++ > drivers/net/hyperv/netvsc.c | 135 +++++++++++++++++++++++++++++- > drivers/net/hyperv/rndis_filter.c | 2 + > include/linux/hyperv.h | 5 ++ > 5 files changed, 145 insertions(+), 3 deletions(-) >=20 > diff --git a/arch/x86/hyperv/ivm.c b/arch/x86/hyperv/ivm.c > index 84563b3c9f3a..08d8e01de017 100644 > --- a/arch/x86/hyperv/ivm.c > +++ b/arch/x86/hyperv/ivm.c > @@ -317,6 +317,7 @@ void *hv_map_memory(void *addr, unsigned long size) >=20 > return vaddr; > } > +EXPORT_SYMBOL_GPL(hv_map_memory); >=20 > void hv_unmap_memory(void *addr) > { > diff --git a/drivers/net/hyperv/hyperv_net.h b/drivers/net/hyperv/hyperv_= net.h > index aa7c9962dbd8..862419912bfb 100644 > --- a/drivers/net/hyperv/hyperv_net.h > +++ b/drivers/net/hyperv/hyperv_net.h > @@ -164,6 +164,7 @@ struct hv_netvsc_packet { > u32 total_bytes; > u32 send_buf_index; > u32 total_data_buflen; > + struct hv_dma_range *dma_range; > }; >=20 > #define NETVSC_HASH_KEYLEN 40 > @@ -1074,6 +1075,7 @@ struct netvsc_device { >=20 > /* Receive buffer allocated by us but manages by NetVSP */ > void *recv_buf; > + void *recv_original_buf; > u32 recv_buf_size; /* allocated bytes */ > u32 recv_buf_gpadl_handle; > u32 recv_section_cnt; > @@ -1082,6 +1084,7 @@ struct netvsc_device { >=20 > /* Send buffer allocated by us */ > void *send_buf; > + void *send_original_buf; > u32 send_buf_size; > u32 send_buf_gpadl_handle; > u32 send_section_cnt; > @@ -1731,4 +1734,6 @@ struct rndis_message { > #define RETRY_US_HI 10000 > #define RETRY_MAX 2000 /* >10 sec */ >=20 > +void netvsc_dma_unmap(struct hv_device *hv_dev, > + struct hv_netvsc_packet *packet); > #endif /* _HYPERV_NET_H */ > diff --git a/drivers/net/hyperv/netvsc.c b/drivers/net/hyperv/netvsc.c > index f19bffff6a63..edd336b08c2c 100644 > --- a/drivers/net/hyperv/netvsc.c > +++ b/drivers/net/hyperv/netvsc.c > @@ -153,8 +153,21 @@ static void free_netvsc_device(struct rcu_head *head= ) > int i; >=20 > kfree(nvdev->extension); > - vfree(nvdev->recv_buf); > - vfree(nvdev->send_buf); > + > + if (nvdev->recv_original_buf) { > + vunmap(nvdev->recv_buf); In patch 11, you have added a hv_unmap_memory() function as the inverse of hv_map_memory(). Since this buffer was mapped with hv_map_memory() and you have added that function, the cleanup should use hv_unmap_memory() rather than calling vunmap() directly. > + vfree(nvdev->recv_original_buf); > + } else { > + vfree(nvdev->recv_buf); > + } > + > + if (nvdev->send_original_buf) { > + vunmap(nvdev->send_buf); Same here. > + vfree(nvdev->send_original_buf); > + } else { > + vfree(nvdev->send_buf); > + } > + > kfree(nvdev->send_section_map); >=20 > for (i =3D 0; i < VRSS_CHANNEL_MAX; i++) { > @@ -347,6 +360,7 @@ static int netvsc_init_buf(struct hv_device *device, > unsigned int buf_size; > size_t map_words; > int i, ret =3D 0; > + void *vaddr; >=20 > /* Get receive buffer area. */ > buf_size =3D device_info->recv_sections * device_info->recv_section_siz= e; > @@ -382,6 +396,17 @@ static int netvsc_init_buf(struct hv_device *device, > goto cleanup; > } >=20 > + if (hv_isolation_type_snp()) { > + vaddr =3D hv_map_memory(net_device->recv_buf, buf_size); Since the netvsc driver is architecture neutral, this code also needs to compile for ARM64. A stub will be needed for hv_map_memory() on the ARM64 side. Same for hv_unmap_memory() as suggested above. Or better, move hv_map_memory() and hv_unmap_memory() to an architecture neutral module such as hv_common.c. Or if Christop's approach of creating the vmap_phys_addr() helper comes to fruition, that's an even better approach since it will already handle multiple architectures. > + if (!vaddr) { > + ret =3D -ENOMEM; > + goto cleanup; > + } > + > + net_device->recv_original_buf =3D net_device->recv_buf; > + net_device->recv_buf =3D vaddr; > + } > + > /* Notify the NetVsp of the gpadl handle */ > init_packet =3D &net_device->channel_init_pkt; > memset(init_packet, 0, sizeof(struct nvsp_message)); > @@ -485,6 +510,17 @@ static int netvsc_init_buf(struct hv_device *device, > goto cleanup; > } >=20 > + if (hv_isolation_type_snp()) { > + vaddr =3D hv_map_memory(net_device->send_buf, buf_size); > + if (!vaddr) { > + ret =3D -ENOMEM; > + goto cleanup; > + } > + > + net_device->send_original_buf =3D net_device->send_buf; > + net_device->send_buf =3D vaddr; > + } > + > /* Notify the NetVsp of the gpadl handle */ > init_packet =3D &net_device->channel_init_pkt; > memset(init_packet, 0, sizeof(struct nvsp_message)); > @@ -775,7 +811,7 @@ static void netvsc_send_tx_complete(struct net_device= *ndev, >=20 > /* Notify the layer above us */ > if (likely(skb)) { > - const struct hv_netvsc_packet *packet > + struct hv_netvsc_packet *packet > =3D (struct hv_netvsc_packet *)skb->cb; > u32 send_index =3D packet->send_buf_index; > struct netvsc_stats *tx_stats; > @@ -791,6 +827,7 @@ static void netvsc_send_tx_complete(struct net_device= *ndev, > tx_stats->bytes +=3D packet->total_bytes; > u64_stats_update_end(&tx_stats->syncp); >=20 > + netvsc_dma_unmap(ndev_ctx->device_ctx, packet); > napi_consume_skb(skb, budget); > } >=20 > @@ -955,6 +992,87 @@ static void netvsc_copy_to_send_buf(struct netvsc_de= vice *net_device, > memset(dest, 0, padding); > } >=20 > +void netvsc_dma_unmap(struct hv_device *hv_dev, > + struct hv_netvsc_packet *packet) > +{ > + u32 page_count =3D packet->cp_partial ? > + packet->page_buf_cnt - packet->rmsg_pgcnt : > + packet->page_buf_cnt; > + int i; > + > + if (!hv_is_isolation_supported()) > + return; > + > + if (!packet->dma_range) > + return; > + > + for (i =3D 0; i < page_count; i++) > + dma_unmap_single(&hv_dev->device, packet->dma_range[i].dma, > + packet->dma_range[i].mapping_size, > + DMA_TO_DEVICE); > + > + kfree(packet->dma_range); > +} > + > +/* netvsc_dma_map - Map swiotlb bounce buffer with data page of > + * packet sent by vmbus_sendpacket_pagebuffer() in the Isolation > + * VM. > + * > + * In isolation VM, netvsc send buffer has been marked visible to > + * host and so the data copied to send buffer doesn't need to use > + * bounce buffer. The data pages handled by vmbus_sendpacket_pagebuffer(= ) > + * may not be copied to send buffer and so these pages need to be > + * mapped with swiotlb bounce buffer. netvsc_dma_map() is to do > + * that. The pfns in the struct hv_page_buffer need to be converted > + * to bounce buffer's pfn. The loop here is necessary becuase the s/becuase/because/ > + * entries in the page buffer array are not necessarily full > + * pages of data. Each entry in the array has a separate offset and > + * len that may be non-zero, even for entries in the middle of the > + * array. And the entries are not physically contiguous. So each > + * entry must be individually mapped rather than as a contiguous unit. > + * So not use dma_map_sg() here. > + */ > +int netvsc_dma_map(struct hv_device *hv_dev, > + struct hv_netvsc_packet *packet, > + struct hv_page_buffer *pb) > +{ > + u32 page_count =3D packet->cp_partial ? > + packet->page_buf_cnt - packet->rmsg_pgcnt : > + packet->page_buf_cnt; > + dma_addr_t dma; > + int i; > + > + if (!hv_is_isolation_supported()) > + return 0; > + > + packet->dma_range =3D kcalloc(page_count, > + sizeof(*packet->dma_range), > + GFP_KERNEL); > + if (!packet->dma_range) > + return -ENOMEM; > + > + for (i =3D 0; i < page_count; i++) { > + char *src =3D phys_to_virt((pb[i].pfn << HV_HYP_PAGE_SHIFT) > + + pb[i].offset); > + u32 len =3D pb[i].len; > + > + dma =3D dma_map_single(&hv_dev->device, src, len, > + DMA_TO_DEVICE); > + if (dma_mapping_error(&hv_dev->device, dma)) { > + kfree(packet->dma_range); > + return -ENOMEM; > + } > + > + packet->dma_range[i].dma =3D dma; > + packet->dma_range[i].mapping_size =3D len; > + pb[i].pfn =3D dma >> HV_HYP_PAGE_SHIFT; > + pb[i].offset =3D offset_in_hvpage(dma); > + pb[i].len =3D len; > + } Just to confirm, this driver does *not* set the DMA min_align_mask like storvsc does. So after the call to dma_map_single(), the offset in the page could be different. That's why you are updating the pb[i].offset value. Alternatively, you could set the DMA min_align_mask, which would ensure the offset is unchanged. I'm OK with either approach, though perhaps a comment is warranted to explain, as this is a subtle issue. > + > + return 0; > +} > + > static inline int netvsc_send_pkt( > struct hv_device *device, > struct hv_netvsc_packet *packet, > @@ -995,14 +1113,24 @@ static inline int netvsc_send_pkt( >=20 > trace_nvsp_send_pkt(ndev, out_channel, rpkt); >=20 > + packet->dma_range =3D NULL; > if (packet->page_buf_cnt) { > if (packet->cp_partial) > pb +=3D packet->rmsg_pgcnt; >=20 > + ret =3D netvsc_dma_map(ndev_ctx->device_ctx, packet, pb); > + if (ret) { > + ret =3D -EAGAIN; > + goto exit; > + } > + > ret =3D vmbus_sendpacket_pagebuffer(out_channel, > pb, packet->page_buf_cnt, > &nvmsg, sizeof(nvmsg), > req_id); > + > + if (ret) > + netvsc_dma_unmap(ndev_ctx->device_ctx, packet); > } else { > ret =3D vmbus_sendpacket(out_channel, > &nvmsg, sizeof(nvmsg), > @@ -1010,6 +1138,7 @@ static inline int netvsc_send_pkt( > VMBUS_DATA_PACKET_FLAG_COMPLETION_REQUESTED); > } >=20 > +exit: > if (ret =3D=3D 0) { > atomic_inc_return(&nvchan->queue_sends); >=20 > diff --git a/drivers/net/hyperv/rndis_filter.c b/drivers/net/hyperv/rndis= _filter.c > index f6c9c2a670f9..448fcc325ed7 100644 > --- a/drivers/net/hyperv/rndis_filter.c > +++ b/drivers/net/hyperv/rndis_filter.c > @@ -361,6 +361,8 @@ static void rndis_filter_receive_response(struct net_= device *ndev, > } > } >=20 > + netvsc_dma_unmap(((struct net_device_context *) > + netdev_priv(ndev))->device_ctx, &request->pkt); > complete(&request->wait_event); > } else { > netdev_err(ndev, > diff --git a/include/linux/hyperv.h b/include/linux/hyperv.h > index 724a735d722a..139a43ad65a1 100644 > --- a/include/linux/hyperv.h > +++ b/include/linux/hyperv.h > @@ -1596,6 +1596,11 @@ struct hyperv_service_callback { > void (*callback)(void *context); > }; >=20 > +struct hv_dma_range { > + dma_addr_t dma; > + u32 mapping_size; > +}; > + > #define MAX_SRV_VER 0x7ffffff > extern bool vmbus_prep_negotiate_resp(struct icmsg_hdr *icmsghdrp, u8 *b= uf, u32 buflen, > const int *fw_version, int fw_vercnt, > -- > 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu Sep 02 02:38:15 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 02:38:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.176839.321863 (Exim 4.92) (envelope-from ) id 1mLccH-0001CP-5Y; Thu, 02 Sep 2021 02:38:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 176839.321863; Thu, 02 Sep 2021 02:38:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLccH-0001CI-2P; Thu, 02 Sep 2021 02:38:13 +0000 Received: by outflank-mailman (input) for mailman id 176839; Thu, 02 Sep 2021 02:38:12 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLccG-0001C8-7m; Thu, 02 Sep 2021 02:38:12 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLccG-0001S4-1a; Thu, 02 Sep 2021 02:38:12 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLccF-00031Y-R5; Thu, 02 Sep 2021 02:38:11 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mLccF-0005HY-Qc; Thu, 02 Sep 2021 02:38:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=w6hoIB42nMN4YO4CMmTamcddJ9aKSe8e0uneQZYQVqk=; b=pjJWi8F9cNynfOSCLpHhQOvX1X zlxZsywv0XACX/Q5mAqb5NUBWnqJnPMMnrSOLPFNzDJsukYUl2JxonC8Qr/EelaCsSuD0moeLFYTt gYFCv6mzN+G3/Aw8yDeZzWVFzKVpKu6x1t+RElKWSZSz9YIgamY6J2k8deUGHgfqibEs=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 164737: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=12e33dca4c0612a0975265e5ba641c6261a26455 X-Osstest-Versions-That: ovmf=cae735f61328d64e2e8991036707b9e78c0f5f63 From: osstest service owner Date: Thu, 02 Sep 2021 02:38:11 +0000 flight 164737 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/164737/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 164674 build-amd64-xsm 6 xen-build fail REGR. vs. 164674 build-i386-xsm 6 xen-build fail REGR. vs. 164674 build-i386 6 xen-build fail REGR. vs. 164674 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 12e33dca4c0612a0975265e5ba641c6261a26455 baseline version: ovmf cae735f61328d64e2e8991036707b9e78c0f5f63 Last test of basis 164674 2021-08-31 02:56:52 Z 1 days Failing since 164686 2021-09-01 03:03:43 Z 0 days 7 attempts Testing same since 164718 2021-09-01 16:40:02 Z 0 days 4 attempts ------------------------------------------------------------ People who touched revisions under test: Anthony PERARD DunTan Gary Lin Jim Fehlig Lin, Gary (HPS OE-Linux) Loo Tung Lun Loo, Tung Lun Mark Wilson Marvin H?user Wenxing Hou jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit 12e33dca4c0612a0975265e5ba641c6261a26455 Author: Loo, Tung Lun Date: Tue Aug 17 15:43:12 2021 +0800 IntelFsp2Pkg: Support Config File and Binary delta comparison BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3567 This patch is to enable config editor to have a new feature that can spell out the delta between the default configuration files' data, such as YAML and BSF, against the data stored in the binary. This can help users understand and track the difference when modifications are made. Cc: Maurice Ma Cc: Nate DeSimone Cc: Star Zeng Cc: Chasel Chiu Signed-off-by: Loo Tung Lun Reviewed-by: Chasel Chiu commit b170806518c1e414939c8b085866544814e1ce8e Author: Mark Wilson Date: Fri Nov 13 08:05:18 2020 +0800 UefiCpuPkg: Clean up save state boundary checks and comments. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2956 In functions ReadSaveStateRegisterByIndex and WriteSaveStateRegister: * check width > 4 instead of >= 4 when writing upper 32 bytes. - This improves the code but will not affect functionality. Cc: Eric Dong Reviewed-by: Ray Ni Signed-off-by: Mark Wilson commit 3b3f88228812e2c642eea8746858a4dad928ebf7 Author: Marvin H?user Date: Mon Aug 9 14:09:25 2021 +0800 MdeModulePkg/PiSmmCore: Drop deprecated image profiling commands The legacy codebase allowed SMM images to be registered for profiling from DXE. Support for this has been dropped entirely, so remove the remaining handlers. Cc: Jian J Wang Cc: Hao A Wu Cc: Eric Dong Reviewed-by: Ray Ni Cc: Vitaly Cheptsov Signed-off-by: Marvin H?user commit cdda3f74a1327663a5d48cca13507085ba403af7 Author: Marvin H?user Date: Mon Aug 9 03:39:53 2021 +0800 UefiPayloadPkg/UefiPayloadEntry: Fix memory corruption UefiPayloadEntry's AllocatePool() applies the "sizeof" operator to HOB index rather than the HOB header structure. This yields 4 Bytes compared to the 8 Bytes the structure header requires. Fix the call to allocate the required space instead. Reviewed-by: Guo Dong Reviewed-by: Ray Ni Cc: Maurice Ma Cc: Benjamin You Cc: Vitaly Cheptsov Signed-off-by: Marvin H?user commit 5d34cc49d5d348012fe8acf9fb618826bd541a7c Author: Wenxing Hou Date: Tue Aug 24 16:11:11 2021 +0800 UefiCpuPkg/PiSmmCpuDxeSmm: Update mPatchCetSupported set condition REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3584 Function AsmCpuid should first check the value for Basic CPUID Information. The fix is to update the mPatchCetSupported judgment statement. Signed-off-by: Wenxing Hou Reviewed-by: Ray Ni Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Cc: Sheng W Cc: Yao Jiewen commit f0fe55bca4651734abf1752a1d7c69fb5bee00b9 Author: duntan Date: Fri Aug 20 13:04:29 2021 +0800 UefiPayloadPkg: Fix the build error when enable Core ci for UefiPayloadPkg V1: Add quotes when using $(ARCH) in .dsc and .fdf file. The quotes are added due to the way by which Core ci parse the .dsc file. Add UINTN in Hob.c to fix cast from pointer to integer of different size error. V2: Delete lines which reference ShellBinPkg.The pkg doesn't exist in edk2. Cc: Guo Dong Cc: Ray Ni Cc: Maurice Ma Cc: Benjamin You Signed-off-by: DunTan Reviewed-by: Ray Ni commit 9f3eda177a4b2d4a33ff1b0307cad42906396562 Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:29:48 2021 +0800 OvmfPkg/OvmfXen: add QemuKernelLoaderFsDxe Without QemuKernelLoaderFsDxe, QemuLoadKernelImage() couldn't download the kernel, initrd, and kernel command line from QEMU's fw_cfg. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3574 Signed-off-by: Gary Lin Acked-by: Anthony PERARD Reviewed-by: Philippe Mathieu-Daude Reviewed-by: Gerd Hoffmann Tested-by: Jim Fehlig commit 5b5f10d7465004e3e40ec1f50a3b490b4db595e7 Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:31:15 2021 +0800 OvmfPkg/SmmControl2Dxe: use PcdAcpiS3Enable to detect S3 support To avoid the potential inconsistency between PcdAcpiS3Enable and QemuFwCfgS3Enabled(), this commit modifies SmmControl2Dxe to detect S3 support by PcdAcpiS3Enable as modules in MdeModulePkg do. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3573 Signed-off-by: Gary Lin Reviewed-by: Gerd Hoffmann Reviewed-by: Jiewen Yao Tested-by: Jim Fehlig commit 52e2dabc0f8d3af09c213072ce8ba734302f585d Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:31:14 2021 +0800 OvmfPkg/PlatformBootManagerLib: use PcdAcpiS3Enable to detect S3 support To avoid the potential inconsistency between PcdAcpiS3Enable and QemuFwCfgS3Enabled(), this commit modifies PlatformBootManagerLib to detect S3 support by PcdAcpiS3Enable as modules in MdeModulePkg do. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3573 Signed-off-by: Gary Lin Reviewed-by: Gerd Hoffmann Reviewed-by: Jiewen Yao Tested-by: Jim Fehlig commit 28152333bccb778b62e6e97446b28bfa0e92ef82 Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:31:13 2021 +0800 OvmfPkg/LockBoxLib: use PcdAcpiS3Enable to detect S3 support To avoid the potential inconsistency between PcdAcpiS3Enable and QemuFwCfgS3Enabled(), this commit modifies LockBoxLib to detect S3 support by PcdAcpiS3Enable as modules in MdeModulePkg do. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3573 Signed-off-by: Gary Lin Reviewed-by: Philippe Mathieu-Daude Reviewed-by: Gerd Hoffmann Reviewed-by: Jiewen Yao Tested-by: Jim Fehlig commit cb0d24637dfdd869618b9635dfb8e3b0746393a6 Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:31:12 2021 +0800 OvmfPkg/OvmfXen: set PcdAcpiS3Enable at initialization There are several functions in OvmfPkg/Library using QemuFwCfgS3Enabled() to detect the S3 support status. However, in MdeModulePkg, PcdAcpiS3Enable is used to check S3 support. Since InitializeXenPlatform() didn't set PcdAcpiS3Enable as InitializePlatform() did, this made the inconsistency between drivers/functions. For example, S3SaveStateDxe checked PcdAcpiS3Enable and skipped S3BootScript because the default value is FALSE. On the other hand, PlatformBootManagerBeforeConsole() from OvmfPkg/Library called QemuFwCfgS3Enabled() and found it returned TRUE, so it invoked SaveS3BootScript(). However, S3SaveStateDxe skipped S3BootScript, so SaveS3BootScript() asserted due to EFI_NOT_FOUND. This issue mainly affects "HVM Direct Kernel Boot". When used, "fw_cfg" is enabled in QEMU and QemuFwCfgS3Enabled() returns true in that case. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3573 Signed-off-by: Gary Lin Reviewed-by: Anthony PERARD Reviewed-by: Gerd Hoffmann Reviewed-by: Jiewen Yao Tested-by: Jim Fehlig From xen-devel-bounces@lists.xenproject.org Thu Sep 02 02:49:22 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 02:49:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.176848.321882 (Exim 4.92) (envelope-from ) id 1mLcmx-0002uh-AZ; Thu, 02 Sep 2021 02:49:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 176848.321882; Thu, 02 Sep 2021 02:49:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLcmx-0002ua-7S; Thu, 02 Sep 2021 02:49:15 +0000 Received: by outflank-mailman (input) for mailman id 176848; Thu, 02 Sep 2021 02:49:14 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLcmv-0002uU-W6 for xen-devel@lists.xenproject.org; Thu, 02 Sep 2021 02:49:14 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (unknown [2a01:111:f400:fe0c::625]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 4ea214a7-0b2b-42ba-a15c-c2ba08ef346f; Thu, 02 Sep 2021 02:49:11 +0000 (UTC) Received: from AM6P191CA0012.EURP191.PROD.OUTLOOK.COM (2603:10a6:209:8b::25) by VE1PR08MB5741.eurprd08.prod.outlook.com (2603:10a6:800:1b3::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19; Thu, 2 Sep 2021 02:49:07 +0000 Received: from AM5EUR03FT030.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:8b:cafe::5a) by AM6P191CA0012.outlook.office365.com (2603:10a6:209:8b::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.17 via Frontend Transport; Thu, 2 Sep 2021 02:49:07 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT030.mail.protection.outlook.com (10.152.16.117) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Thu, 2 Sep 2021 02:49:05 +0000 Received: ("Tessian outbound 6ba9ec11d42b:v103"); Thu, 02 Sep 2021 02:49:05 +0000 Received: from fe5c61d1ba8d.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id D0BD3C8B-8302-442D-A88F-722B8C8FC3DE.1; Thu, 02 Sep 2021 02:48:58 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id fe5c61d1ba8d.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 02 Sep 2021 02:48:58 +0000 Received: from DB9PR08MB6857.eurprd08.prod.outlook.com (2603:10a6:10:2a2::7) by DB7PR08MB3532.eurprd08.prod.outlook.com (2603:10a6:10:4f::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19; Thu, 2 Sep 2021 02:48:46 +0000 Received: from DB9PR08MB6857.eurprd08.prod.outlook.com ([fe80::2c28:50cf:49fd:da32]) by DB9PR08MB6857.eurprd08.prod.outlook.com ([fe80::2c28:50cf:49fd:da32%7]) with mapi id 15.20.4457.026; Thu, 2 Sep 2021 02:48:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4ea214a7-0b2b-42ba-a15c-c2ba08ef346f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=51bC7OwzeC89ccTfqq5DnigU2oiyXRd0TM+PRBRudxM=; b=wSLtzGuLZNWvxM58rp7NJDBWUCx6PPDfax8JLMBi7tI/iP3ffWxeWmzUGVqQqO3R0WFxFJCf/oa4tJ0KrEizsRibY/gxL2foCTQRiTeKfN25lMHaNryOpTD+zqrxtj6LgUBC2W1yGhNQAfCdNA9KVnAKaabE34pfmN/gPVFTKOQ= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gCB8cAkCmJaEICifainkhzoQRYdCKf5IrnwazooulxHDurnvncQLvs53O0knu7Ew5SrLRSuV7QlrR/Elyg+oO/Ieh4FUysB2RPnMOw1FIhGzrbBaVHwlBJWdj+hNSfBMzfToEUSnraTWGsMYsuPdx63eriaph8lM6Y4Cq1DVqbazU1jMASUoYHtkQw4No6RaAjfufldtFiSXH3B9e359kUgUo2CvgeA5uOa3X8Wwj2srecVrszOy31RhlQfYa5bSKHovD0XcmXWXKn97haYphRVdwhV7nfmctPVxgqwncuxYhC1rc1107e0j3FYoq+T2nbPNBO3ca/bPSbMsFlIs6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=51bC7OwzeC89ccTfqq5DnigU2oiyXRd0TM+PRBRudxM=; b=bPsXPs0mq4II6mza68Knz2YUPD7WgX6g0mAZRvQeJ2PlZ9ihxVT3ZfBAM83gaxnOBqEa8CAyP5UCXbIYyHyXVqWpsH3htDv1kkWQsJR4jV1kR8m4zfUI+02ksqc485hEAd2l0grXpxgPqhw25qNJWiwouApbzAL10Dxy4OUFYrIJgAU7GyFaVbaZnfGEBOXJgk9Dax3wxdHUeXP8OOxVo1idgG6UyopXp6danQxKQCsTVn8yMx4NAXgtVk0N3S1N+fGJNpS5Kvu//i/hRfJa2Z8GKtmJTAAh/dxvGWj6EuZqXhiiXCJfaUU5ITTpWux239B9r9ccYVpXRoBQVQyxUQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=51bC7OwzeC89ccTfqq5DnigU2oiyXRd0TM+PRBRudxM=; b=wSLtzGuLZNWvxM58rp7NJDBWUCx6PPDfax8JLMBi7tI/iP3ffWxeWmzUGVqQqO3R0WFxFJCf/oa4tJ0KrEizsRibY/gxL2foCTQRiTeKfN25lMHaNryOpTD+zqrxtj6LgUBC2W1yGhNQAfCdNA9KVnAKaabE34pfmN/gPVFTKOQ= From: Wei Chen To: Stefano Stabellini , Julien Grall CC: "xen-devel@lists.xenproject.org" , Bertrand Marquis Subject: RE: [XEN RFC PATCH 25/40] xen/arm: unified entry to parse all NUMA data from device tree Thread-Topic: [XEN RFC PATCH 25/40] xen/arm: unified entry to parse all NUMA data from device tree Thread-Index: AQHXjptEfh486q3QYEyqJH3oIGMDv6uM6C8AgAEbO4CAAZ5dgIAAiwHA Date: Thu, 2 Sep 2021 02:48:45 +0000 Message-ID: References: <20210811102423.28908-1-wei.chen@arm.com> <20210811102423.28908-26-wei.chen@arm.com> <088e4b16-afea-8248-55f1-a081bba7f80c@xen.org> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 83BC028FF5AB0541B4E6B989F2FBE67B.0 x-checkrecipientchecked: true Authentication-Results-Original: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=arm.com; x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: b2a6cd65-eeec-49dc-65ed-08d96dbc3af3 x-ms-traffictypediagnostic: DB7PR08MB3532:|VE1PR08MB5741: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:10000;OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: /YhbuRzgEnTa+Ydv3QJkCVdcVamAx0LTRUxPttkUMP+tD+Ic4sx94zgD5pqPkwnIF67CCE89sPdarWXGO1m8PxB0Qf2NIEFsRxOar9g9MvY0t9SVfXoM4Y+84LW4JO0HZXETd8g6TkezKiw+TtQM7fWdrozToNYXWlcdm8s0myHb3ZRKVRIsrX2ED23bHkzZanF1nVg429NMiwiEiAkUZzyfGCEApETN16eVvUq5OMTRp4NkFteEh/OLaRDGn6kTf2g7+sUkP+DmeO9Y6L6FEQORwt/+E8wrTf/8DNa77Ysnlv4jeeQEZxZIxrSNTQiVBQWejsD3+Tz6xRIX63YaAJrMxOEuPvxmQY0SSTwZU5pqYhO8TdFjret8jD9YEjsvL/PdxfCT40iDPkngTAJDnPM8wcVcpvq+hlLDWLPKzuNKzCISbkxnlrBa6/8XG5O2PaprQQVrEN9GMHdKzg7slnMWP4l/QApU/IuD2vIeoey/mM9ljsJWcnj2Wjiz8E54FCv2sU48DNUWqj5Rsr6UOuedPY6bNrYo1YNWfgwnsvkc8nc2Mbjtu89Kbob8MCzNkutMf+hVjtkNBCGgxDc4A50tJMcBggQxtL7S0/jH+sV8dY8crrxADrOg4U98F9uhhntCoRsGqyT07cbEDmr9yKH8o6Q1Qs7UBirkGq0gLxsfNGLSmm+DDtHDlS9HwVDXR23Nvtgo5hPGNjTEUlZ8Rw== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB9PR08MB6857.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(396003)(39860400002)(346002)(136003)(376002)(8936002)(83380400001)(71200400001)(38100700002)(6506007)(53546011)(5660300002)(122000001)(64756008)(26005)(66946007)(38070700005)(76116006)(66476007)(66446008)(66556008)(52536014)(478600001)(4326008)(186003)(2906002)(9686003)(316002)(55016002)(7696005)(54906003)(8676002)(33656002)(86362001)(110136005);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3532 Original-Authentication-Results: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT030.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: b239dab7-fef3-4b94-bf6b-08d96dbc2f26 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: DJHCDxfW0ZJjUtOVIHPJ818s7g+bG4cIP4a6KTrQxNpaj2OgeSqyJ7k8SnM9F0CWJHjgzRq6mswUOdiSu6VVwNY3p06KQUKy/iihtRfNWocxZzQzcNm2DLuh1Xfh1ZjOtHS+sQXQwNYqtnR9hEzwgM7VdRfhiDxk7KLOH1iN+1JARgHi92uYgKay/dXfKuCZ3wUgWV6rrkVq0Nk+UGabibkOh2z9OKFe6a5m11uv+kAwXZkZA9oP7wA9VgGeTIaW3I0S6ruCpT7t3SKtQCyzAvVGQpWDGlbOsNtREjCQUmHydt3MGEFDpQ3NI5Xr1dCSqljW5XGZkASBsIp9oGJLJich712d2BFycH66MvMP9Br8LrKK7IvWozKRhUObtPdB9psaik48jFk3/FYOK4K37bEeaMyMC7nZIWLRD1Sd1smBLYSxssHiBBUBdy10JrucqCEsHABGuWkYyoVHAkiRMFNYlZH9o0PE3IFTOQS8mBkjyn/c49t0hiTCl62VMYzvk2pMVrFsZXv5Tcbp3tNQyW101duXgyi5+aiVO+CzsA7gcL2aC7EuZMfSofejIEzag4eMGUy2kY8WdESOWnyNFouKcM5gwiifjVETy9XIwE0DaHAYJHOpa0sdC2JaW35g7sSfA5cbhpA8Plw20ToTszQuvLO/qxk6pA2NGY/VTrt+3jgLg460Ukw0hyYXp7GSPzL/Rfy5faJsCWy2r3KLgg== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(136003)(396003)(39860400002)(376002)(346002)(46966006)(36840700001)(356005)(9686003)(8676002)(55016002)(8936002)(5660300002)(81166007)(316002)(52536014)(4326008)(33656002)(82740400003)(110136005)(54906003)(478600001)(7696005)(26005)(53546011)(83380400001)(186003)(70206006)(70586007)(336012)(47076005)(86362001)(82310400003)(36860700001)(2906002)(6506007);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Sep 2021 02:49:05.9195 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b2a6cd65-eeec-49dc-65ed-08d96dbc3af3 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT030.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5741 DQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogU3RlZmFubyBTdGFiZWxs aW5pIDxzc3RhYmVsbGluaUBrZXJuZWwub3JnPg0KPiBTZW50OiAyMDIxxOo51MIyyNUgMjozMQ0K PiBUbzogSnVsaWVuIEdyYWxsIDxqdWxpZW5AeGVuLm9yZz4NCj4gQ2M6IFN0ZWZhbm8gU3RhYmVs bGluaSA8c3N0YWJlbGxpbmlAa2VybmVsLm9yZz47IFdlaSBDaGVuDQo+IDxXZWkuQ2hlbkBhcm0u Y29tPjsgeGVuLWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnOyBqYmV1bGljaEBzdXNlLmNvbTsN Cj4gQmVydHJhbmQgTWFycXVpcyA8QmVydHJhbmQuTWFycXVpc0Bhcm0uY29tPg0KPiBTdWJqZWN0 OiBSZTogW1hFTiBSRkMgUEFUQ0ggMjUvNDBdIHhlbi9hcm06IHVuaWZpZWQgZW50cnkgdG8gcGFy c2UgYWxsDQo+IE5VTUEgZGF0YSBmcm9tIGRldmljZSB0cmVlDQo+IA0KPiBPbiBUdWUsIDMxIEF1 ZyAyMDIxLCBKdWxpZW4gR3JhbGwgd3JvdGU6DQo+ID4gSGkgU3RlZmFubywNCj4gPg0KPiA+IE9u IDMxLzA4LzIwMjEgMDE6NTQsIFN0ZWZhbm8gU3RhYmVsbGluaSB3cm90ZToNCj4gPiA+IE9uIFdl ZCwgMTEgQXVnIDIwMjEsIFdlaSBDaGVuIHdyb3RlOg0KPiA+ID4gPiBJbiB0aGlzIEFQSSwgd2Ug c2NhbiB3aG9sZSBkZXZpY2UgdHJlZSB0byBwYXJzZSBDUFUgbm9kZSBpZCwgbWVtb3J5DQo+ID4g PiA+IG5vZGUgaWQgYW5kIGRpc3RhbmNlLW1hcC4gVGhvdWdoIGVhcmx5X3NjYW5fbm9kZSB3aWxs IGludm9rZSBoYXMgYQ0KPiA+ID4gPiBoYW5kbGVyIHRvIHByb2Nlc3MgbWVtb3J5IG5vZGVzLiBJ ZiB3ZSB3YW50IHRvIHBhcnNlIG1lbW9yeSBub2RlIGlkDQo+ID4gPiA+IGluIHRoaXMgaGFuZGxl ciwgd2UgaGF2ZSB0byBlbWJlZGVkIE5VTUEgcGFyc2UgY29kZSBpbiB0aGlzIGhhbmRsZXIuDQo+ ID4gPiA+IEJ1dCB3ZSBzdGlsbCBuZWVkIHRvIHNjYW4gd2hvbGUgZGV2aWNlIHRyZWUgdG8gZmlu ZCBDUFUgTlVNQSBpZCBhbmQNCj4gPiA+ID4gZGlzdGFuY2UtbWFwLiBJbiB0aGlzIGNhc2UsIHdl IGluY2x1ZGUgbWVtb3J5IE5VTUEgaWQgcGFyc2UgaW4gdGhpcw0KPiA+ID4gPiBBUEkgdG9vLiBB bm90aGVyIGJlbmVmaXQgaXMgdGhhdCB3ZSBoYXZlIGEgdW5pcXVlIGVudHJ5IGZvciBkZXZpY2UN Cj4gPiA+ID4gdHJlZSBOVU1BIGRhdGEgcGFyc2UuDQo+ID4gPiA+DQo+ID4gPiA+IFNpZ25lZC1v ZmYtYnk6IFdlaSBDaGVuIDx3ZWkuY2hlbkBhcm0uY29tPg0KPiA+ID4gPiAtLS0NCj4gPiA+ID4g ICB4ZW4vYXJjaC9hcm0vbnVtYV9kZXZpY2VfdHJlZS5jIHwgMzEgKysrKysrKysrKysrKysrKysr KysrKysrKysrKy0NCj4gLS0NCj4gPiA+ID4gICB4ZW4vaW5jbHVkZS9hc20tYXJtL251bWEuaCAg ICAgIHwgIDEgKw0KPiA+ID4gPiAgIDIgZmlsZXMgY2hhbmdlZCwgMjkgaW5zZXJ0aW9ucygrKSwg MyBkZWxldGlvbnMoLSkNCj4gPiA+ID4NCj4gPiA+ID4gZGlmZiAtLWdpdCBhL3hlbi9hcmNoL2Fy bS9udW1hX2RldmljZV90cmVlLmMNCj4gPiA+ID4gYi94ZW4vYXJjaC9hcm0vbnVtYV9kZXZpY2Vf dHJlZS5jDQo+ID4gPiA+IGluZGV4IDZlMGQxZDNkOWYuLjI3ZmZiNzJmN2IgMTAwNjQ0DQo+ID4g PiA+IC0tLSBhL3hlbi9hcmNoL2FybS9udW1hX2RldmljZV90cmVlLmMNCj4gPiA+ID4gKysrIGIv eGVuL2FyY2gvYXJtL251bWFfZGV2aWNlX3RyZWUuYw0KPiA+ID4gPiBAQCAtMTMxLDcgKzEzMSw4 IEBAIHNhdmVfbWVtYmxrOg0KPiA+ID4gPiAgIH0NCj4gPiA+ID4gICAgIC8qIFBhcnNlIENQVSBO VU1BIG5vZGUgaW5mbyAqLw0KPiA+ID4gPiAtaW50IF9faW5pdCBkZXZpY2VfdHJlZV9wYXJzZV9u dW1hX2NwdV9ub2RlKGNvbnN0IHZvaWQgKmZkdCwgaW50DQo+IG5vZGUpDQo+ID4gPiA+ICtzdGF0 aWMgaW50IF9faW5pdA0KPiA+ID4gPiArZGV2aWNlX3RyZWVfcGFyc2VfbnVtYV9jcHVfbm9kZShj b25zdCB2b2lkICpmZHQsIGludCBub2RlKQ0KPiA+ID4gPiAgIHsNCj4gPiA+ID4gICAgICAgdWlu dDMyX3QgbmlkOw0KPiA+ID4gPiAgIEBAIC0xNDcsNyArMTQ4LDcgQEAgaW50IF9faW5pdA0KPiBk ZXZpY2VfdHJlZV9wYXJzZV9udW1hX2NwdV9ub2RlKGNvbnN0DQo+ID4gPiA+IHZvaWQgKmZkdCwg aW50IG5vZGUpDQo+ID4gPiA+ICAgfQ0KPiA+ID4gPiAgICAgLyogUGFyc2UgbWVtb3J5IG5vZGUg TlVNQSBpbmZvICovDQo+ID4gPiA+IC1pbnQgX19pbml0DQo+ID4gPiA+ICtzdGF0aWMgaW50IF9f aW5pdA0KPiA+ID4gPiAgIGRldmljZV90cmVlX3BhcnNlX251bWFfbWVtb3J5X25vZGUoY29uc3Qg dm9pZCAqZmR0LCBpbnQgbm9kZSwNCj4gPiA+ID4gICAgICAgY29uc3QgY2hhciAqbmFtZSwgdWlu dDMyX3QgYWRkcl9jZWxscywgdWludDMyX3Qgc2l6ZV9jZWxscykNCj4gPiA+ID4gICB7DQo+ID4g PiA+IEBAIC0yMDIsNyArMjAzLDcgQEAgZGV2aWNlX3RyZWVfcGFyc2VfbnVtYV9tZW1vcnlfbm9k ZShjb25zdCB2b2lkDQo+ICpmZHQsDQo+ID4gPiA+IGludCBub2RlLA0KPiA+ID4gPiAgIH0NCj4g PiA+ID4gICAgIC8qIFBhcnNlIE5VTUEgZGlzdGFuY2UgbWFwIHYxICovDQo+ID4gPiA+IC1pbnQg X19pbml0DQo+ID4gPiA+ICtzdGF0aWMgaW50IF9faW5pdA0KPiA+ID4gPiAgIGRldmljZV90cmVl X3BhcnNlX251bWFfZGlzdGFuY2VfbWFwX3YxKGNvbnN0IHZvaWQgKmZkdCwgaW50IG5vZGUpDQo+ ID4gPiA+ICAgew0KPiA+ID4gPiAgICAgICBjb25zdCBzdHJ1Y3QgZmR0X3Byb3BlcnR5ICpwcm9w Ow0KPiA+ID4gPiBAQCAtMjY3LDMgKzI2OCwyNyBAQCBkZXZpY2VfdHJlZV9wYXJzZV9udW1hX2Rp c3RhbmNlX21hcF92MShjb25zdA0KPiB2b2lkDQo+ID4gPiA+ICpmZHQsIGludCBub2RlKQ0KPiA+ ID4gPiAgICAgICAgIHJldHVybiAwOw0KPiA+ID4gPiAgIH0NCj4gPiA+ID4gKw0KPiA+ID4gPiAr c3RhdGljIGludCBfX2luaXQgZmR0X3NjYW5fbnVtYV9ub2Rlcyhjb25zdCB2b2lkICpmZHQsDQo+ ID4gPiA+ICsgICAgICAgICAgICAgICAgaW50IG5vZGUsIGNvbnN0IGNoYXIgKnVuYW1lLCBpbnQg ZGVwdGgsDQo+ID4gPiA+ICsgICAgICAgICAgICAgICAgdTMyIGFkZHJlc3NfY2VsbHMsIHUzMiBz aXplX2NlbGxzLCB2b2lkICpkYXRhKQ0KPiA+ID4gPiArew0KPiA+ID4gPiArICAgIGludCByZXQg PSAwOw0KPiA+ID4gPiArDQo+ID4gPiA+ICsgICAgaWYgKCBmZHRfbm9kZV9jaGVja190eXBlKGZk dCwgbm9kZSwgImNwdSIpID09IDAgKQ0KPiA+ID4gPiArICAgICAgICByZXQgPSBkZXZpY2VfdHJl ZV9wYXJzZV9udW1hX2NwdV9ub2RlKGZkdCwgbm9kZSk7DQo+ID4gPiA+ICsgICAgZWxzZSBpZiAo IGZkdF9ub2RlX2NoZWNrX3R5cGUoZmR0LCBub2RlLCAibWVtb3J5IikgPT0gMCApDQo+ID4gPiA+ ICsgICAgICAgIHJldCA9IGRldmljZV90cmVlX3BhcnNlX251bWFfbWVtb3J5X25vZGUoZmR0LCBu b2RlLCB1bmFtZSwNCj4gPiA+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgYWRk cmVzc19jZWxscywgc2l6ZV9jZWxscyk7DQo+ID4gPiA+ICsgICAgZWxzZSBpZiAoIGZkdF9ub2Rl X2NoZWNrX2NvbXBhdGlibGUoZmR0LCBub2RlLA0KPiA+ID4gPiArICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAibnVtYS1kaXN0YW5jZS1tYXAtdjEiKSA9PSAwICkNCj4gPiA+ID4gKyAg ICAgICAgcmV0ID0gZGV2aWNlX3RyZWVfcGFyc2VfbnVtYV9kaXN0YW5jZV9tYXBfdjEoZmR0LCBu b2RlKTsNCj4gPiA+ID4gKw0KPiA+ID4gPiArICAgIHJldHVybiByZXQ7DQo+ID4gPiA+ICt9DQo+ ID4gPg0KPiA+ID4gSnVsaWVuLCBkbyB5b3UgaGF2ZSBhbiBvcGluaW9uIG9uIHdoZXRoZXIgaXQg bWlnaHQgYmUgd29ydGggcmV1c2luZw0KPiB0aGUNCj4gPiA+IGV4aXN0aW5nIGVhcmx5X3NjYW5f bm9kZSBmdW5jdGlvbiBmb3IgdGhpcyB0byBhdm9pZGluZyBhbm90aGVyIGZ1bGwNCj4gRkRUDQo+ ID4gPiBzY2FuICh0byBhdm9pZCBhbm90aGVyIGNhbGwgdG8gZGV2aWNlX3RyZWVfZm9yX2VhY2hf bm9kZSk/DQo+ID4NCj4gPiBJIGRvbid0IGxpa2UgdGhlIGZ1bGwgRkRUIHNjYW4gYW5kIGFjdHVh bGx5IGRyYWZ0ZWQgYW4gZS1tYWlsIGluIHJlcGx5LQ0KPiB0byBbMV0NCj4gPiB0byBzdWdnZXN0 IHBhcnNlIGFsbCB0aGUgTlVNQSBpbmZvcm1hdGlvbiBmcm9tIGVhcmx5X3NjYW5fbm9kZSgpLg0K PiA+DQo+ID4gSG93ZXZlciwgd2UgZG9uJ3Qga25vdyB3aGV0aGVyIEFDUEkgb3IgRFQgd2lsbCBi ZSB1c2VkIGF0IHRoZSB0aW1lDQo+ID4gZWFybHlfc2Nhbl9ub2RlKCkgaXMgY2FsbGVkLiBTbyB3 ZSB3aWxsIG5lZWQgdG8gcmV2ZXJ0IGFueSBjaGFuZ2Ugd2hpY2gNCj4gY2FuDQo+ID4gbWFrZSB0 aGUgY29kZSBhIGxpdHRsZSBtb3JlIGF3a3dhcmQuDQo+ID4NCj4gPiBTbyBJIGRlY2lkZWQgdG8g ZHJvcCBteSBlLW1haWwgYmVjYXVzZSBJIHByZWZlciB0aGUgZnVsbCBEVCBzY2FuIGZvciBub3cu DQo+IFdlDQo+ID4gY2FuIGxvb2sgYXQgb3B0aW1pemluZyBsYXRlciBpZiB0aGlzIGJlY29tZXMg YSBwYWluIHBvaW50Lg0KPiANCj4gVWhtLCB5ZXMgeW91IGFyZSByaWdodC4NCj4gDQo+IFdlIHdv dWxkIGhhdmUgdG8gbW92ZSBzb21lIG9mIHRoZSBsb2dpYyB0byBkZXRlY3QgQUNQSSBlYXJsaWVy IHRvDQo+IGVhcmx5X3NjYW5fbm9kZSAoZS5nLiB4ZW4vYXJjaC9hcm0vYWNwaS9ib290LmM6ZHRf c2Nhbl9kZXB0aDFfbm9kZXMpLg0KPiBUaGF0IGNvdWxkIGFjdHVhbGx5IGJlIGEgZ29vZCBpZGVh LCBidXQgaXQgaXMgdHJ1ZSB0aGF0IGNvdWxkIGJlIGRvbmUNCj4gd2l0aCBhIHNlcGFyYXRlIHBh dGNoIGxhdGVyLg0KDQpTb3VuZHMgZ29vZCB0byBtZS4NCg== From xen-devel-bounces@lists.xenproject.org Thu Sep 02 03:23:14 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 03:23:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.176857.321900 (Exim 4.92) (envelope-from ) id 1mLdJk-0007tE-84; Thu, 02 Sep 2021 03:23:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 176857.321900; Thu, 02 Sep 2021 03:23:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLdJk-0007t7-4b; Thu, 02 Sep 2021 03:23:08 +0000 Received: by outflank-mailman (input) for mailman id 176857; Thu, 02 Sep 2021 03:23:07 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLdJi-0007sx-Vo; Thu, 02 Sep 2021 03:23:06 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLdJi-0002Ds-Mq; Thu, 02 Sep 2021 03:23:06 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLdJi-0004gT-Fz; Thu, 02 Sep 2021 03:23:06 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mLdJi-0003tq-FX; Thu, 02 Sep 2021 03:23:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=kmxWLjMTj8eyU39JWMio7wg43TDTEDDg/N+n27aWTf0=; b=cQoJk3XJaCDOOouQD14B+1VgEa AZdcgisHfSPiXv/FwnV9TPb1wPa+Rsh5o/TK3aYpO11gImEWiVxIhb9yakwpN/p7heDMXv5ZOGgYs d5AWBmbEucTPNW96IGlOpu7jjJKi5yxu1dCac6fDrcwQmZO5I455LDv24DhvUVYSEu8A=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 164740: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=e3ee8c8dbd7a9f7d7905abe17be60354c9f5f9a3 X-Osstest-Versions-That: ovmf=cae735f61328d64e2e8991036707b9e78c0f5f63 From: osstest service owner Date: Thu, 02 Sep 2021 03:23:06 +0000 flight 164740 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/164740/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 164674 build-amd64-xsm 6 xen-build fail REGR. vs. 164674 build-i386-xsm 6 xen-build fail REGR. vs. 164674 build-i386 6 xen-build fail REGR. vs. 164674 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf e3ee8c8dbd7a9f7d7905abe17be60354c9f5f9a3 baseline version: ovmf cae735f61328d64e2e8991036707b9e78c0f5f63 Last test of basis 164674 2021-08-31 02:56:52 Z 2 days Failing since 164686 2021-09-01 03:03:43 Z 1 days 8 attempts Testing same since 164740 2021-09-02 02:41:13 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Anthony PERARD DunTan Gary Lin Jim Fehlig Lin, Gary (HPS OE-Linux) Loo Tung Lun Loo, Tung Lun Mark Wilson Marvin H?user Wenxing Hou jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit e3ee8c8dbd7a9f7d7905abe17be60354c9f5f9a3 Author: duntan Date: Fri Aug 20 14:43:37 2021 +0800 .azurepipelines: Add UefiPayloadPkg in gate-build-job.yml and CISetting.py Add UefiPayloadPkg in gate-build-job.yml to enable Core ci for UefiPayloadPkg. Add UefiPayloadPkg to supported Packages in CISettings. Cc: Sean Brogan Cc: Bret Barkelew Cc: Michael D Kinney Cc: Liming Gao Signed-off-by: DunTan Reviewed-by: Liming Gao commit 63fddc98e06c380e654b1cfbaf24b9fd922adfad Author: duntan Date: Fri Aug 20 14:43:36 2021 +0800 UefiPayloadPkg: Create .yaml file in UefiPayloadPkg Create .yaml file in UefiPayloadPkg to enable Core ci for UefiPayloadPkg Cc: Guo Dong Cc: Ray Ni Cc: Maurice Ma Cc: Benjamin You Signed-off-by: DunTan Reviewed-by: Liming Gao commit 12e33dca4c0612a0975265e5ba641c6261a26455 Author: Loo, Tung Lun Date: Tue Aug 17 15:43:12 2021 +0800 IntelFsp2Pkg: Support Config File and Binary delta comparison BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3567 This patch is to enable config editor to have a new feature that can spell out the delta between the default configuration files' data, such as YAML and BSF, against the data stored in the binary. This can help users understand and track the difference when modifications are made. Cc: Maurice Ma Cc: Nate DeSimone Cc: Star Zeng Cc: Chasel Chiu Signed-off-by: Loo Tung Lun Reviewed-by: Chasel Chiu commit b170806518c1e414939c8b085866544814e1ce8e Author: Mark Wilson Date: Fri Nov 13 08:05:18 2020 +0800 UefiCpuPkg: Clean up save state boundary checks and comments. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2956 In functions ReadSaveStateRegisterByIndex and WriteSaveStateRegister: * check width > 4 instead of >= 4 when writing upper 32 bytes. - This improves the code but will not affect functionality. Cc: Eric Dong Reviewed-by: Ray Ni Signed-off-by: Mark Wilson commit 3b3f88228812e2c642eea8746858a4dad928ebf7 Author: Marvin H?user Date: Mon Aug 9 14:09:25 2021 +0800 MdeModulePkg/PiSmmCore: Drop deprecated image profiling commands The legacy codebase allowed SMM images to be registered for profiling from DXE. Support for this has been dropped entirely, so remove the remaining handlers. Cc: Jian J Wang Cc: Hao A Wu Cc: Eric Dong Reviewed-by: Ray Ni Cc: Vitaly Cheptsov Signed-off-by: Marvin H?user commit cdda3f74a1327663a5d48cca13507085ba403af7 Author: Marvin H?user Date: Mon Aug 9 03:39:53 2021 +0800 UefiPayloadPkg/UefiPayloadEntry: Fix memory corruption UefiPayloadEntry's AllocatePool() applies the "sizeof" operator to HOB index rather than the HOB header structure. This yields 4 Bytes compared to the 8 Bytes the structure header requires. Fix the call to allocate the required space instead. Reviewed-by: Guo Dong Reviewed-by: Ray Ni Cc: Maurice Ma Cc: Benjamin You Cc: Vitaly Cheptsov Signed-off-by: Marvin H?user commit 5d34cc49d5d348012fe8acf9fb618826bd541a7c Author: Wenxing Hou Date: Tue Aug 24 16:11:11 2021 +0800 UefiCpuPkg/PiSmmCpuDxeSmm: Update mPatchCetSupported set condition REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3584 Function AsmCpuid should first check the value for Basic CPUID Information. The fix is to update the mPatchCetSupported judgment statement. Signed-off-by: Wenxing Hou Reviewed-by: Ray Ni Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Cc: Sheng W Cc: Yao Jiewen commit f0fe55bca4651734abf1752a1d7c69fb5bee00b9 Author: duntan Date: Fri Aug 20 13:04:29 2021 +0800 UefiPayloadPkg: Fix the build error when enable Core ci for UefiPayloadPkg V1: Add quotes when using $(ARCH) in .dsc and .fdf file. The quotes are added due to the way by which Core ci parse the .dsc file. Add UINTN in Hob.c to fix cast from pointer to integer of different size error. V2: Delete lines which reference ShellBinPkg.The pkg doesn't exist in edk2. Cc: Guo Dong Cc: Ray Ni Cc: Maurice Ma Cc: Benjamin You Signed-off-by: DunTan Reviewed-by: Ray Ni commit 9f3eda177a4b2d4a33ff1b0307cad42906396562 Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:29:48 2021 +0800 OvmfPkg/OvmfXen: add QemuKernelLoaderFsDxe Without QemuKernelLoaderFsDxe, QemuLoadKernelImage() couldn't download the kernel, initrd, and kernel command line from QEMU's fw_cfg. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3574 Signed-off-by: Gary Lin Acked-by: Anthony PERARD Reviewed-by: Philippe Mathieu-Daude Reviewed-by: Gerd Hoffmann Tested-by: Jim Fehlig commit 5b5f10d7465004e3e40ec1f50a3b490b4db595e7 Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:31:15 2021 +0800 OvmfPkg/SmmControl2Dxe: use PcdAcpiS3Enable to detect S3 support To avoid the potential inconsistency between PcdAcpiS3Enable and QemuFwCfgS3Enabled(), this commit modifies SmmControl2Dxe to detect S3 support by PcdAcpiS3Enable as modules in MdeModulePkg do. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3573 Signed-off-by: Gary Lin Reviewed-by: Gerd Hoffmann Reviewed-by: Jiewen Yao Tested-by: Jim Fehlig commit 52e2dabc0f8d3af09c213072ce8ba734302f585d Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:31:14 2021 +0800 OvmfPkg/PlatformBootManagerLib: use PcdAcpiS3Enable to detect S3 support To avoid the potential inconsistency between PcdAcpiS3Enable and QemuFwCfgS3Enabled(), this commit modifies PlatformBootManagerLib to detect S3 support by PcdAcpiS3Enable as modules in MdeModulePkg do. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3573 Signed-off-by: Gary Lin Reviewed-by: Gerd Hoffmann Reviewed-by: Jiewen Yao Tested-by: Jim Fehlig commit 28152333bccb778b62e6e97446b28bfa0e92ef82 Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:31:13 2021 +0800 OvmfPkg/LockBoxLib: use PcdAcpiS3Enable to detect S3 support To avoid the potential inconsistency between PcdAcpiS3Enable and QemuFwCfgS3Enabled(), this commit modifies LockBoxLib to detect S3 support by PcdAcpiS3Enable as modules in MdeModulePkg do. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3573 Signed-off-by: Gary Lin Reviewed-by: Philippe Mathieu-Daude Reviewed-by: Gerd Hoffmann Reviewed-by: Jiewen Yao Tested-by: Jim Fehlig commit cb0d24637dfdd869618b9635dfb8e3b0746393a6 Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:31:12 2021 +0800 OvmfPkg/OvmfXen: set PcdAcpiS3Enable at initialization There are several functions in OvmfPkg/Library using QemuFwCfgS3Enabled() to detect the S3 support status. However, in MdeModulePkg, PcdAcpiS3Enable is used to check S3 support. Since InitializeXenPlatform() didn't set PcdAcpiS3Enable as InitializePlatform() did, this made the inconsistency between drivers/functions. For example, S3SaveStateDxe checked PcdAcpiS3Enable and skipped S3BootScript because the default value is FALSE. On the other hand, PlatformBootManagerBeforeConsole() from OvmfPkg/Library called QemuFwCfgS3Enabled() and found it returned TRUE, so it invoked SaveS3BootScript(). However, S3SaveStateDxe skipped S3BootScript, so SaveS3BootScript() asserted due to EFI_NOT_FOUND. This issue mainly affects "HVM Direct Kernel Boot". When used, "fw_cfg" is enabled in QEMU and QemuFwCfgS3Enabled() returns true in that case. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3573 Signed-off-by: Gary Lin Reviewed-by: Anthony PERARD Reviewed-by: Gerd Hoffmann Reviewed-by: Jiewen Yao Tested-by: Jim Fehlig From xen-devel-bounces@lists.xenproject.org Thu Sep 02 03:32:28 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 03:32:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.176864.321914 (Exim 4.92) (envelope-from ) id 1mLdSd-00019H-8L; Thu, 02 Sep 2021 03:32:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 176864.321914; Thu, 02 Sep 2021 03:32:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLdSd-00019A-3c; Thu, 02 Sep 2021 03:32:19 +0000 Received: by outflank-mailman (input) for mailman id 176864; Thu, 02 Sep 2021 03:32:18 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLdSc-000191-Ap for xen-devel@lists.xenproject.org; Thu, 02 Sep 2021 03:32:18 +0000 Received: from outbound.mail.eo.outlook.com (unknown [40.93.3.13]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 5c1d418a-0b9e-11ec-ae3a-12813bfff9fa; Thu, 02 Sep 2021 03:32:12 +0000 (UTC) Received: from MWHPR21MB1593.namprd21.prod.outlook.com (2603:10b6:301:7c::11) by MW2PR2101MB1034.namprd21.prod.outlook.com (2603:10b6:302:a::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.5; Thu, 2 Sep 2021 03:32:03 +0000 Received: from MWHPR21MB1593.namprd21.prod.outlook.com ([fe80::3c8b:6387:cd5:7d86]) by MWHPR21MB1593.namprd21.prod.outlook.com ([fe80::3c8b:6387:cd5:7d86%8]) with mapi id 15.20.4478.014; Thu, 2 Sep 2021 03:32:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5c1d418a-0b9e-11ec-ae3a-12813bfff9fa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JQbXSpgvwBAqzskd+XYzXa9qd1ZwoapNxtxzqozS6nQxvzYigLh+evBweV2kRwNBwz7ekzLu2XVsXXi2v7i5ItqEu7BuwK5CdgKyPLq1DcbYN7pVpwDgkTf/UG6qUz7Z9HjWehMaJ3ETymj3b1I+CrfC9x22KDGThi/fUW8hMT/V7cXb3J2EFCGQaXeDqUv/1y0iSIZfwv76cYWZNfg1aCrnC+RGZ1cQ7NrR4ckbQgG9StnsAb+X1FqStW11xRTsVvTttdjrisGXI9dBqy0x/ikW91fE2YbLvlb48ANt13T3TdYHRpB3YtQy/4GCnpBnGVurTLZw71gBiVGIOUNInw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=jphdFbQcqCygNrEGqinmRvb9upDBy+g/qvA+rRnOhP8=; b=SYYxwG0OsrpLcH4Q6CDa18r/qgihczGLjh7H3l0GDkZ+w53MzhVPPYaI5n3cKFjlWv4lOOLOM0uXIjJDG3KriE3w+ot7G4cNolUNacC3bEOdyxLaATCgROOyzrDkpv3/Z77QRHreailtiyGDQENGEwq50ixH/7jz1aF2VNUPinI8FcpcWnckIygsfHfrABHt4INlXI6o9X4MAB3ONKUVaBOkz1FCR7jaz00S7f+edoPhdqPB8ZybkE1Lr+v4Kbe/30fslCM3DNf+jXHGKilq7St6Mzdh6sCvIiWtOC8m/q9axraXxVMu86hH6/HQCvcOYivaQz+rj9e6GWYhI9lY5g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jphdFbQcqCygNrEGqinmRvb9upDBy+g/qvA+rRnOhP8=; b=NYdFsYXX4yDXiFL7Tfpi03UbXXyFUwBxfcu1Ah8CAumhgn+kuBMN3OmR6XtBqEgcVgzUfQ6PZwBKhP0pmzP3DEM9JrHQibw3t2Q7JYVCdeZgNnyZ3uWYG0XFQxR7C6H0Rjm7ulI+IStOpsC8s0xiVm5z/vgnpcAWWAIUA9NoBcE= From: Michael Kelley To: Tianyu Lan , KY Srinivasan , Haiyang Zhang , Stephen Hemminger , "wei.liu@kernel.org" , Dexuan Cui , "catalin.marinas@arm.com" , "will@kernel.org" , "tglx@linutronix.de" , "mingo@redhat.com" , "bp@alien8.de" , "x86@kernel.org" , "hpa@zytor.com" , "dave.hansen@linux.intel.com" , "luto@kernel.org" , "peterz@infradead.org" , "konrad.wilk@oracle.com" , "boris.ostrovsky@oracle.com" , "jgross@suse.com" , "sstabellini@kernel.org" , "joro@8bytes.org" , "davem@davemloft.net" , "kuba@kernel.org" , "jejb@linux.ibm.com" , "martin.petersen@oracle.com" , "gregkh@linuxfoundation.org" , "arnd@arndb.de" , "hch@lst.de" , "m.szyprowski@samsung.com" , "robin.murphy@arm.com" , "brijesh.singh@amd.com" , "thomas.lendacky@amd.com" , Tianyu Lan , "pgonda@google.com" , "martin.b.radev@gmail.com" , "akpm@linux-foundation.org" , "kirill.shutemov@linux.intel.com" , "rppt@kernel.org" , "hannes@cmpxchg.org" , "aneesh.kumar@linux.ibm.com" , "krish.sadhukhan@oracle.com" , "saravanand@fb.com" , "linux-arm-kernel@lists.infradead.org" , "xen-devel@lists.xenproject.org" , "rientjes@google.com" , "ardb@kernel.org" CC: "iommu@lists.linux-foundation.org" , "linux-arch@vger.kernel.org" , "linux-hyperv@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-scsi@vger.kernel.org" , "netdev@vger.kernel.org" , vkuznets , "parri.andrea@gmail.com" , "dave.hansen@intel.com" Subject: RE: [PATCH V4 05/13] hyperv: Add Write/Read MSR registers via ghcb page Thread-Topic: [PATCH V4 05/13] hyperv: Add Write/Read MSR registers via ghcb page Thread-Index: AQHXm2gCMSN7/9Nrs0WqDjRR9LMyqquJGfKw Date: Thu, 2 Sep 2021 03:32:03 +0000 Message-ID: References: <20210827172114.414281-1-ltykernel@gmail.com> <20210827172114.414281-6-ltykernel@gmail.com> In-Reply-To: <20210827172114.414281-6-ltykernel@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ActionId=2fbe6f01-ab97-4a86-a26b-7e5e56e5a33e;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=true;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Standard;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=Internal;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2021-08-28T16:18:47Z;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=microsoft.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c1470254-253b-409a-9a29-08d96dc23b3a x-ms-traffictypediagnostic: MW2PR2101MB1034: x-ms-exchange-transport-forked: True x-ld-processed: 72f988bf-86f1-41af-91ab-2d7cd011db47,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:127; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: qLKUGIr7FLuydpSAU/8sGZ+xE0tOXbhOYJ7JeyuXCj9gMJI28oJ3xLcB4MCazN7HHAvjeS/Ud+l753dD0ZgVT32um1Mx/ZD4d3JGXji6s1KYAk2q/Ky7l1e6RpE4luX4rVOd2gioJu02xeJ1Aykf0gm9CBC1ls0Y7GoMY/fXKZLqb/YDAYTop61raq2HF1DmaR6PWhwR8UBxSKLG3LQIlJRGNyEs/mP+NJ7hLnto3iWe9VOSI2EL4R5MSSvzKnR2sSsTHZiZWAQXwHiYyuANUakgaeMB0W0rg+4e59ukpIrxXPr7LgL5SEJJN51HxfeCeipaQgvmY6AWlaejF0wEqT1AG0D6yBxBgDAYqBH/bXPgz3AmPiDiklOXI3NRciHQB78G480xQhGsxw8dGMOV8M/jIj2ZzM68PRe/LQmFOBvJeXkeYGOcZ84915Gc6x0qWvbabCrcCbTnS/4iPN0/IJJ5QVqMAWDQsdaCVr99YfIEB0caHRVaFroyNOxyl482Pa+ubJDVZh78bkE7u6z4j4OBcAi+RKLbA7AmHVqIFUB4wt4IAJJSu+x/bgltGK/drCUWhD6/7a6NJyOIZ5lwhqPeZDaaXWRgkyrr8JIdkxsAXg1Y/SRnBFF4K/knyXAURiDQQRuJr2+K0HE0bgLFRdZq/RD9voETWt9mSxaikD8NUlZss/nJG6Pxidly8w19YOIChxXKJgnHvYf8YWwekGWryuTPyi7juTWMYD9k9Oc= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR21MB1593.namprd21.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(8990500004)(55016002)(8676002)(186003)(30864003)(26005)(9686003)(82960400001)(82950400001)(71200400001)(83380400001)(38070700005)(8936002)(7406005)(38100700002)(33656002)(52536014)(54906003)(66946007)(4326008)(66446008)(66476007)(64756008)(122000001)(66556008)(76116006)(10290500003)(2906002)(921005)(6506007)(5660300002)(110136005)(7416002)(7696005)(7366002)(508600001)(316002)(86362001)(559001)(579004);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?B5IQac8XXoI6m6n27Qn50J6iupQuKS7E221ZRdCyye0Le6JfVsFtHXomwvMo?= =?us-ascii?Q?XfbrEc7tBAsCxOGO1hqQqFa4AlZEP8weaZ3czpp1mh02Z8NUkto3s+Xb29Q4?= =?us-ascii?Q?f24GPCTtJl1AObkdHjme+sYyrQ4ZylFSkzf3Bowsjh5GWXuzZSh8JCxDTHby?= =?us-ascii?Q?LULMRPrEK+Tr9s3EGYI7C+aYElVfg60PIUOFq2Rl95c95QD4P/1DyTMnL18+?= =?us-ascii?Q?J04O8qCtd3Ka2gIQrVUrXKxzlAPY3yyaIeP96cjbqq1kX5HKRsUfD/PV4BGw?= =?us-ascii?Q?XzQdDuXxmoQ5pVuA56Q52Yat9ut3sXYnBuGQttTrvcQrLZTLKJX7LiuaKXvR?= =?us-ascii?Q?ePMuIBTrjig7U0RXgO7C0Ui5eDHX9BF/PJ7XuopGyQkJ+/8uaz3UcNdu8Gev?= =?us-ascii?Q?aCYwKzLS0+c9lb6CRTZ6x+H2QviqPLPFjdDxKAsEMmBc8z7+Oagif1znE/Ui?= =?us-ascii?Q?VaZ0BezrilepyKsTV6cG4PYN5orWGEmPtq4asC1dT8r9LVcnuuj2xm1e5UTy?= =?us-ascii?Q?ka5Sv5xrAJLHFLMYD7XMWEch4S/yT1nsyySt8p6vq5awiBnaonh3gahObBnl?= =?us-ascii?Q?3jLwlVS4j28w3VfIWQ++wagwye0kXVlGoRdMrm8jDXOiO834heMF8JzTGi7L?= =?us-ascii?Q?RhKApIg8+zs713eMKa7IZWbdQEL41BVLrfj+FsfB9b4HQULQ/fbNwI0ssvAf?= =?us-ascii?Q?DYLP4rZwTkOoy21QOkbNqbEcQzgxC/b7tmQO6QRG7I0FTwLdLwQEWa3x7QgI?= =?us-ascii?Q?7QKeLVa5J19B0vHzKNpJpopoTzgQfDdnUS74fmx56RxYe3hHjZyhruIizOpu?= =?us-ascii?Q?p4DJ5iKvDcs+PC/E7+7cy5Jq3Xl70nR6ahz5k+VI1nx+G5qYg+l6lmuyH7Ey?= =?us-ascii?Q?x00pUuMmo74nxSLcFNm6w5UJ4q+MErjqYtzr7WvsUZX9HJnpAmt9r6rRbVwP?= =?us-ascii?Q?ngtc6ZPwe+mrEVL8ZXGdOEpKEnv/WvbGTD7HQ9eCUjEYLf7nrzjz7tKd5Wcs?= =?us-ascii?Q?gQEUp1h/X7YLNN3rLNozyBSOY0QzQMqXZ/cKb4vn4MKAa+vdcKwDOram6ZED?= =?us-ascii?Q?VBLnoWrEW8zHbwU98vQlAFri+Edn6VozfE79m1W1STEOYqEl5cD9RA/NjE4i?= =?us-ascii?Q?ASPXqecl8/hRFAWwUipQMqEr1fMI/myLPDwR0LAgduOVjsN0WRQTQPMwSCi7?= =?us-ascii?Q?Q7PvBfx5Gp39rfUvbQFxh7Hq8o+wp0JeK+UGuAPFIxjrCwIDKMDvQdmrI//9?= =?us-ascii?Q?Fh1YTE56V03umqHp/K2tB3TQwL+xGPZqqIdb0Aees/ni0+ha6YrW0H7cCq3S?= =?us-ascii?Q?qkVPssI+4XCiw8lC5sntpFL4?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR21MB1593.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c1470254-253b-409a-9a29-08d96dc23b3a X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Sep 2021 03:32:03.1186 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: vPzNSqamS7p5aXRDNKV/5JzW1XO7DWUJFW0QQGcNNAlVGQK0/oQWaD5sx5rOxa0wqmrqVlRCyigO1wAzb/PRDCUXClSEn+7Xor8QiiWC55I= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2PR2101MB1034 From: Tianyu Lan Sent: Friday, August 27, 2021 10:21 = AM >=20 > Hyperv provides GHCB protocol to write Synthetic Interrupt > Controller MSR registers in Isolation VM with AMD SEV SNP > and these registers are emulated by hypervisor directly. > Hyperv requires to write SINTx MSR registers twice. First > writes MSR via GHCB page to communicate with hypervisor > and then writes wrmsr instruction to talk with paravisor > which runs in VMPL0. Guest OS ID MSR also needs to be set > via GHCB page. >=20 > Signed-off-by: Tianyu Lan > --- > Change since v1: > * Introduce sev_es_ghcb_hv_call_simple() and share code > between SEV and Hyper-V code. > Change since v3: > * Pass old_msg_type to hv_signal_eom() as parameter. > * Use HV_REGISTER_* marcro instead of HV_X64_MSR_* > * Add hv_isolation_type_snp() weak function. > * Add maros to set syinc register in ARM code. > --- > arch/arm64/include/asm/mshyperv.h | 23 ++++++ > arch/x86/hyperv/hv_init.c | 36 ++-------- > arch/x86/hyperv/ivm.c | 112 ++++++++++++++++++++++++++++++ > arch/x86/include/asm/mshyperv.h | 80 ++++++++++++++++++++- > arch/x86/include/asm/sev.h | 3 + > arch/x86/kernel/sev-shared.c | 63 ++++++++++------- > drivers/hv/hv.c | 112 ++++++++++++++++++++---------- > drivers/hv/hv_common.c | 6 ++ > include/asm-generic/mshyperv.h | 4 +- > 9 files changed, 345 insertions(+), 94 deletions(-) >=20 > diff --git a/arch/arm64/include/asm/mshyperv.h b/arch/arm64/include/asm/m= shyperv.h > index 20070a847304..ced83297e009 100644 > --- a/arch/arm64/include/asm/mshyperv.h > +++ b/arch/arm64/include/asm/mshyperv.h > @@ -41,6 +41,29 @@ static inline u64 hv_get_register(unsigned int reg) > return hv_get_vpreg(reg); > } >=20 > +#define hv_get_simp(val) { val =3D hv_get_register(HV_REGISTER_SIMP); } > +#define hv_set_simp(val) hv_set_register(HV_REGISTER_SIMP, val) > + > +#define hv_get_siefp(val) { val =3D hv_get_register(HV_REGISTER_SIEFP); = } > +#define hv_set_siefp(val) hv_set_register(HV_REGISTER_SIEFP, val) > + > +#define hv_get_synint_state(int_num, val) { \ > + val =3D hv_get_register(HV_REGISTER_SINT0 + int_num); \ > + } > + > +#define hv_set_synint_state(int_num, val) \ > + hv_set_register(HV_REGISTER_SINT0 + int_num, val) > + > +#define hv_get_synic_state(val) { \ > + val =3D hv_get_register(HV_REGISTER_SCONTROL); \ > + } > + > +#define hv_set_synic_state(val) \ > + hv_set_register(HV_REGISTER_SCONTROL, val) > + > +#define hv_signal_eom(old_msg_type) \ > + hv_set_register(HV_REGISTER_EOM, 0) > + > /* SMCCC hypercall parameters */ > #define HV_SMCCC_FUNC_NUMBER 1 > #define HV_FUNC_ID ARM_SMCCC_CALL_VAL( \ > diff --git a/arch/x86/hyperv/hv_init.c b/arch/x86/hyperv/hv_init.c > index b1aa42f60faa..be6210a3fd2f 100644 > --- a/arch/x86/hyperv/hv_init.c > +++ b/arch/x86/hyperv/hv_init.c > @@ -37,7 +37,7 @@ EXPORT_SYMBOL_GPL(hv_current_partition_id); > void *hv_hypercall_pg; > EXPORT_SYMBOL_GPL(hv_hypercall_pg); >=20 > -void __percpu **hv_ghcb_pg; > +union hv_ghcb __percpu **hv_ghcb_pg; >=20 > /* Storage to save the hypercall page temporarily for hibernation */ > static void *hv_hypercall_pg_saved; > @@ -406,7 +406,7 @@ void __init hyperv_init(void) > } >=20 > if (hv_isolation_type_snp()) { > - hv_ghcb_pg =3D alloc_percpu(void *); > + hv_ghcb_pg =3D alloc_percpu(union hv_ghcb *); > if (!hv_ghcb_pg) > goto free_vp_assist_page; > } > @@ -424,6 +424,9 @@ void __init hyperv_init(void) > guest_id =3D generate_guest_id(0, LINUX_VERSION_CODE, 0); > wrmsrl(HV_X64_MSR_GUEST_OS_ID, guest_id); >=20 > + /* Hyper-V requires to write guest os id via ghcb in SNP IVM. */ > + hv_ghcb_msr_write(HV_X64_MSR_GUEST_OS_ID, guest_id); > + > hv_hypercall_pg =3D __vmalloc_node_range(PAGE_SIZE, 1, VMALLOC_START, > VMALLOC_END, GFP_KERNEL, PAGE_KERNEL_ROX, > VM_FLUSH_RESET_PERMS, NUMA_NO_NODE, > @@ -501,6 +504,7 @@ void __init hyperv_init(void) >=20 > clean_guest_os_id: > wrmsrl(HV_X64_MSR_GUEST_OS_ID, 0); > + hv_ghcb_msr_write(HV_X64_MSR_GUEST_OS_ID, 0); > cpuhp_remove_state(cpuhp); > free_ghcb_page: > free_percpu(hv_ghcb_pg); > @@ -522,6 +526,7 @@ void hyperv_cleanup(void) >=20 > /* Reset our OS id */ > wrmsrl(HV_X64_MSR_GUEST_OS_ID, 0); > + hv_ghcb_msr_write(HV_X64_MSR_GUEST_OS_ID, 0); >=20 > /* > * Reset hypercall page reference before reset the page, > @@ -592,30 +597,3 @@ bool hv_is_hyperv_initialized(void) > return hypercall_msr.enable; > } > EXPORT_SYMBOL_GPL(hv_is_hyperv_initialized); > - > -enum hv_isolation_type hv_get_isolation_type(void) > -{ > - if (!(ms_hyperv.priv_high & HV_ISOLATION)) > - return HV_ISOLATION_TYPE_NONE; > - return FIELD_GET(HV_ISOLATION_TYPE, ms_hyperv.isolation_config_b); > -} > -EXPORT_SYMBOL_GPL(hv_get_isolation_type); > - > -bool hv_is_isolation_supported(void) > -{ > - if (!cpu_feature_enabled(X86_FEATURE_HYPERVISOR)) > - return 0; > - > - if (!hypervisor_is_type(X86_HYPER_MS_HYPERV)) > - return 0; > - > - return hv_get_isolation_type() !=3D HV_ISOLATION_TYPE_NONE; > -} > - > -DEFINE_STATIC_KEY_FALSE(isolation_type_snp); > - > -bool hv_isolation_type_snp(void) > -{ > - return static_branch_unlikely(&isolation_type_snp); > -} > -EXPORT_SYMBOL_GPL(hv_isolation_type_snp); > diff --git a/arch/x86/hyperv/ivm.c b/arch/x86/hyperv/ivm.c > index a069c788ce3c..f56fe4f73000 100644 > --- a/arch/x86/hyperv/ivm.c > +++ b/arch/x86/hyperv/ivm.c > @@ -6,13 +6,125 @@ > * Tianyu Lan > */ >=20 > +#include > +#include > #include > #include > #include > #include > +#include > +#include > #include > #include >=20 > +union hv_ghcb { > + struct ghcb ghcb; > +} __packed __aligned(HV_HYP_PAGE_SIZE); > + > +void hv_ghcb_msr_write(u64 msr, u64 value) > +{ > + union hv_ghcb *hv_ghcb; > + void **ghcb_base; > + unsigned long flags; > + > + if (!hv_ghcb_pg) > + return; > + > + WARN_ON(in_nmi()); > + > + local_irq_save(flags); > + ghcb_base =3D (void **)this_cpu_ptr(hv_ghcb_pg); > + hv_ghcb =3D (union hv_ghcb *)*ghcb_base; > + if (!hv_ghcb) { > + local_irq_restore(flags); > + return; > + } > + > + ghcb_set_rcx(&hv_ghcb->ghcb, msr); > + ghcb_set_rax(&hv_ghcb->ghcb, lower_32_bits(value)); > + ghcb_set_rdx(&hv_ghcb->ghcb, upper_32_bits(value)); > + > + if (sev_es_ghcb_hv_call_simple(&hv_ghcb->ghcb, SVM_EXIT_MSR, 1, 0)) > + pr_warn("Fail to write msr via ghcb %llx.\n", msr); > + > + local_irq_restore(flags); > +} > + > +void hv_ghcb_msr_read(u64 msr, u64 *value) > +{ > + union hv_ghcb *hv_ghcb; > + void **ghcb_base; > + unsigned long flags; > + > + /* Check size of union hv_ghcb here. */ > + BUILD_BUG_ON(sizeof(union hv_ghcb) !=3D HV_HYP_PAGE_SIZE); > + > + if (!hv_ghcb_pg) > + return; > + > + WARN_ON(in_nmi()); > + > + local_irq_save(flags); > + ghcb_base =3D (void **)this_cpu_ptr(hv_ghcb_pg); > + hv_ghcb =3D (union hv_ghcb *)*ghcb_base; > + if (!hv_ghcb) { > + local_irq_restore(flags); > + return; > + } > + > + ghcb_set_rcx(&hv_ghcb->ghcb, msr); > + if (sev_es_ghcb_hv_call_simple(&hv_ghcb->ghcb, SVM_EXIT_MSR, 0, 0)) > + pr_warn("Fail to read msr via ghcb %llx.\n", msr); > + else > + *value =3D (u64)lower_32_bits(hv_ghcb->ghcb.save.rax) > + | ((u64)lower_32_bits(hv_ghcb->ghcb.save.rdx) << 32); > + local_irq_restore(flags); > +} > + > +void hv_sint_rdmsrl_ghcb(u64 msr, u64 *value) > +{ > + hv_ghcb_msr_read(msr, value); > +} > +EXPORT_SYMBOL_GPL(hv_sint_rdmsrl_ghcb); > + > +void hv_sint_wrmsrl_ghcb(u64 msr, u64 value) > +{ > + hv_ghcb_msr_write(msr, value); > + > + /* Write proxy bit vua wrmsrl instruction. */ s/vua/via/ > + if (msr >=3D HV_X64_MSR_SINT0 && msr <=3D HV_X64_MSR_SINT15) > + wrmsrl(msr, value | 1 << 20); > +} > +EXPORT_SYMBOL_GPL(hv_sint_wrmsrl_ghcb); > + > +enum hv_isolation_type hv_get_isolation_type(void) > +{ > + if (!(ms_hyperv.priv_high & HV_ISOLATION)) > + return HV_ISOLATION_TYPE_NONE; > + return FIELD_GET(HV_ISOLATION_TYPE, ms_hyperv.isolation_config_b); > +} > +EXPORT_SYMBOL_GPL(hv_get_isolation_type); > + > +/* > + * hv_is_isolation_supported - Check system runs in the Hyper-V > + * isolation VM. > + */ > +bool hv_is_isolation_supported(void) > +{ > + return hv_get_isolation_type() !=3D HV_ISOLATION_TYPE_NONE; > +} > + > +DEFINE_STATIC_KEY_FALSE(isolation_type_snp); > + > +/* > + * hv_isolation_type_snp - Check system runs in the AMD SEV-SNP based > + * isolation VM. > + */ > +bool hv_isolation_type_snp(void) > +{ > + return static_branch_unlikely(&isolation_type_snp); > +} > + > /* > * hv_mark_gpa_visibility - Set pages visible to host via hvcall. > * > diff --git a/arch/x86/include/asm/mshyperv.h b/arch/x86/include/asm/mshyp= erv.h > index ffb2af079c6b..b77f4caee3ee 100644 > --- a/arch/x86/include/asm/mshyperv.h > +++ b/arch/x86/include/asm/mshyperv.h > @@ -11,6 +11,8 @@ > #include > #include >=20 > +union hv_ghcb; > + > DECLARE_STATIC_KEY_FALSE(isolation_type_snp); >=20 > typedef int (*hyperv_fill_flush_list_func)( > @@ -30,6 +32,61 @@ static inline u64 hv_get_register(unsigned int reg) > return value; > } >=20 > +#define hv_get_sint_reg(val, reg) { \ > + if (hv_isolation_type_snp()) \ > + hv_get_##reg##_ghcb(&val); \ > + else \ > + rdmsrl(HV_REGISTER_##reg, val); \ > + } > + > +#define hv_set_sint_reg(val, reg) { \ > + if (hv_isolation_type_snp()) \ > + hv_set_##reg##_ghcb(val); \ > + else \ > + wrmsrl(HV_REGISTER_##reg, val); \ > + } > + > + > +#define hv_get_simp(val) hv_get_sint_reg(val, SIMP) > +#define hv_get_siefp(val) hv_get_sint_reg(val, SIEFP) > + > +#define hv_set_simp(val) hv_set_sint_reg(val, SIMP) > +#define hv_set_siefp(val) hv_set_sint_reg(val, SIEFP) > + > +#define hv_get_synic_state(val) { \ > + if (hv_isolation_type_snp()) \ > + hv_get_synic_state_ghcb(&val); \ > + else \ > + rdmsrl(HV_REGISTER_SCONTROL, val); \ > + } > +#define hv_set_synic_state(val) { \ > + if (hv_isolation_type_snp()) \ > + hv_set_synic_state_ghcb(val); \ > + else \ > + wrmsrl(HV_REGISTER_SCONTROL, val); \ > + } > + > +#define hv_signal_eom(old_msg_type) { \ > + if (hv_isolation_type_snp() && \ > + old_msg_type !=3D HVMSG_TIMER_EXPIRED) \ > + hv_sint_wrmsrl_ghcb(HV_REGISTER_EOM, 0); \ > + else \ > + wrmsrl(HV_REGISTER_EOM, 0); \ > + } > + > +#define hv_get_synint_state(int_num, val) { \ > + if (hv_isolation_type_snp()) \ > + hv_get_synint_state_ghcb(int_num, &val);\ > + else \ > + rdmsrl(HV_REGISTER_SINT0 + int_num, val);\ > + } > +#define hv_set_synint_state(int_num, val) { \ > + if (hv_isolation_type_snp()) \ > + hv_set_synint_state_ghcb(int_num, val); \ > + else \ > + wrmsrl(HV_REGISTER_SINT0 + int_num, val);\ > + } > + > #define hv_get_raw_timer() rdtsc_ordered() >=20 > void hyperv_vector_handler(struct pt_regs *regs); > @@ -41,7 +98,7 @@ extern void *hv_hypercall_pg; >=20 > extern u64 hv_current_partition_id; >=20 > -extern void __percpu **hv_ghcb_pg; > +extern union hv_ghcb __percpu **hv_ghcb_pg; >=20 > int hv_call_deposit_pages(int node, u64 partition_id, u32 num_pages); > int hv_call_add_logical_proc(int node, u32 lp_index, u32 acpi_id); > @@ -195,6 +252,25 @@ int hv_unmap_ioapic_interrupt(int ioapic_id, struct = hv_interrupt_entry *entry); > int hv_mark_gpa_visibility(u16 count, const u64 pfn[], > enum hv_mem_host_visibility visibility); > int hv_set_mem_host_visibility(unsigned long addr, int numpages, bool vi= sible); > +void hv_sint_wrmsrl_ghcb(u64 msr, u64 value); > +void hv_sint_rdmsrl_ghcb(u64 msr, u64 *value); > +void hv_signal_eom_ghcb(void); > +void hv_ghcb_msr_write(u64 msr, u64 value); > +void hv_ghcb_msr_read(u64 msr, u64 *value); > + > +#define hv_get_synint_state_ghcb(int_num, val) \ > + hv_sint_rdmsrl_ghcb(HV_X64_MSR_SINT0 + int_num, val) > +#define hv_set_synint_state_ghcb(int_num, val) \ > + hv_sint_wrmsrl_ghcb(HV_X64_MSR_SINT0 + int_num, val) > + > +#define hv_get_SIMP_ghcb(val) hv_sint_rdmsrl_ghcb(HV_X64_MSR_SIMP, val) > +#define hv_set_SIMP_ghcb(val) hv_sint_wrmsrl_ghcb(HV_X64_MSR_SIMP, val) > + > +#define hv_get_SIEFP_ghcb(val) hv_sint_rdmsrl_ghcb(HV_X64_MSR_SIEFP, val= ) > +#define hv_set_SIEFP_ghcb(val) hv_sint_wrmsrl_ghcb(HV_X64_MSR_SIEFP, val= ) > + > +#define hv_get_synic_state_ghcb(val) hv_sint_rdmsrl_ghcb(HV_X64_MSR_SCON= TROL, val) > +#define hv_set_synic_state_ghcb(val) hv_sint_wrmsrl_ghcb(HV_X64_MSR_SCON= TROL, val) I'm not seeing the value in the multiple layers of #define to get and set t= he various syinc registers. My thought was a completely different approach, w= hich is to simply implement the hv_get_register() and hv_set_register() functions w= ith=20 a little bit more logic. Here's my proposal. This code is not even compil= e tested, but you get the idea: static bool hv_is_synic_reg(unsigned int reg) { if ((reg >=3D HV_REGISTER_SCONTROL) && (reg <=3D HV_REGISTER_SINT15)) return true; return false; } u64 hv_get_register(unsigned int reg) { u64 value; if (hv_is_synic_reg(reg) && hv_isolation_type_snp()) hv_ghcb_msr_read(reg, &value); else rdmsrl(reg, value); return value; } void hv_set_register(unsigned int reg, u64 value) { if (hv_is_synic_reg(reg) && hv_isolation_type_snp()) { hv_ghcb_msr_write(reg, value); /* Write proxy bit via wrmsl instruction */ if (reg >=3D HV_REGISTER_SINT0 && reg <=3D HV_REGISTER_SINT15) wrmsrl(reg, value | 1 << 20); } else { wrmsrl(reg, value); } } If the above code is implemented in one of the modules under arch/x86 to replace the existing implementations in arch/x86/include/asm/mshyper.h, then it will only be built for x86/x64, and the existing code will just wor= k for ARM64. Architecture neutral code in hv_synic_enable_regs() and hv_synic_disable_regs() will still need check for hv_isolation_type_snp() and take some special actions, but the calls to hv_get_register() and hv_set_register() can remain unchanged. This approach seems a lot simpler to me, but maybe I'm missing something that your current patch is doing. Your code does have a special case for HV_REGISTER_EOM. Is there a reason it needs to do an additional check of the old_msg_type? I'm just not understanding why an SNP isolated VM requires special treatment of this register. A key point: Getting/setting any of the synthetic MSRs requires a trap to the hypervisor. So they already not super-fast. The only code path in Linux that is performance sensitive is setting HV_REGISTER_STIMER0_COUNT in hv_ce_set_next_event(). That's not a synic register, so the only additional burden with the above implementation is checking the MSR value to see if it is in the synic range. The cost of that check is reasonable for something that has to trap to the hypervisor anyway. > #else /* CONFIG_HYPERV */ > static inline void hyperv_init(void) {} > static inline void hyperv_setup_mmu_ops(void) {} > @@ -211,9 +287,9 @@ static inline int hyperv_flush_guest_mapping_range(u6= 4 as, > { > return -1; > } > +static inline void hv_signal_eom_ghcb(void) { }; > #endif /* CONFIG_HYPERV */ >=20 > - > #include >=20 > #endif > diff --git a/arch/x86/include/asm/sev.h b/arch/x86/include/asm/sev.h > index fa5cd05d3b5b..81beb2a8031b 100644 > --- a/arch/x86/include/asm/sev.h > +++ b/arch/x86/include/asm/sev.h > @@ -81,6 +81,9 @@ static __always_inline void sev_es_nmi_complete(void) > __sev_es_nmi_complete(); > } > extern int __init sev_es_efi_map_ghcbs(pgd_t *pgd); > +extern enum es_result sev_es_ghcb_hv_call_simple(struct ghcb *ghcb, > + u64 exit_code, u64 exit_info_1, > + u64 exit_info_2); > #else > static inline void sev_es_ist_enter(struct pt_regs *regs) { } > static inline void sev_es_ist_exit(void) { } > diff --git a/arch/x86/kernel/sev-shared.c b/arch/x86/kernel/sev-shared.c > index 9f90f460a28c..dd7f37de640b 100644 > --- a/arch/x86/kernel/sev-shared.c > +++ b/arch/x86/kernel/sev-shared.c > @@ -94,10 +94,9 @@ static void vc_finish_insn(struct es_em_ctxt *ctxt) > ctxt->regs->ip +=3D ctxt->insn.length; > } >=20 > -static enum es_result sev_es_ghcb_hv_call(struct ghcb *ghcb, > - struct es_em_ctxt *ctxt, > - u64 exit_code, u64 exit_info_1, > - u64 exit_info_2) > +enum es_result sev_es_ghcb_hv_call_simple(struct ghcb *ghcb, > + u64 exit_code, u64 exit_info_1, > + u64 exit_info_2) > { > enum es_result ret; >=20 > @@ -109,29 +108,45 @@ static enum es_result sev_es_ghcb_hv_call(struct gh= cb *ghcb, > ghcb_set_sw_exit_info_1(ghcb, exit_info_1); > ghcb_set_sw_exit_info_2(ghcb, exit_info_2); >=20 > - sev_es_wr_ghcb_msr(__pa(ghcb)); > VMGEXIT(); >=20 > - if ((ghcb->save.sw_exit_info_1 & 0xffffffff) =3D=3D 1) { > - u64 info =3D ghcb->save.sw_exit_info_2; > - unsigned long v; > - > - info =3D ghcb->save.sw_exit_info_2; > - v =3D info & SVM_EVTINJ_VEC_MASK; > - > - /* Check if exception information from hypervisor is sane. */ > - if ((info & SVM_EVTINJ_VALID) && > - ((v =3D=3D X86_TRAP_GP) || (v =3D=3D X86_TRAP_UD)) && > - ((info & SVM_EVTINJ_TYPE_MASK) =3D=3D SVM_EVTINJ_TYPE_EXEPT)) { > - ctxt->fi.vector =3D v; > - if (info & SVM_EVTINJ_VALID_ERR) > - ctxt->fi.error_code =3D info >> 32; > - ret =3D ES_EXCEPTION; > - } else { > - ret =3D ES_VMM_ERROR; > - } > - } else { > + if ((ghcb->save.sw_exit_info_1 & 0xffffffff) =3D=3D 1) > + ret =3D ES_VMM_ERROR; > + else > ret =3D ES_OK; > + > + return ret; > +} > + > +static enum es_result sev_es_ghcb_hv_call(struct ghcb *ghcb, > + struct es_em_ctxt *ctxt, > + u64 exit_code, u64 exit_info_1, > + u64 exit_info_2) > +{ > + unsigned long v; > + enum es_result ret; > + u64 info; > + > + sev_es_wr_ghcb_msr(__pa(ghcb)); > + > + ret =3D sev_es_ghcb_hv_call_simple(ghcb, exit_code, exit_info_1, > + exit_info_2); > + if (ret =3D=3D ES_OK) > + return ret; > + > + info =3D ghcb->save.sw_exit_info_2; > + v =3D info & SVM_EVTINJ_VEC_MASK; > + > + /* Check if exception information from hypervisor is sane. */ > + if ((info & SVM_EVTINJ_VALID) && > + ((v =3D=3D X86_TRAP_GP) || (v =3D=3D X86_TRAP_UD)) && > + ((info & SVM_EVTINJ_TYPE_MASK) =3D=3D SVM_EVTINJ_TYPE_EXEPT)) { > + ctxt->fi.vector =3D v; > + if (info & SVM_EVTINJ_VALID_ERR) > + ctxt->fi.error_code =3D info >> 32; > + ret =3D ES_EXCEPTION; > + } else { > + ret =3D ES_VMM_ERROR; > } >=20 > return ret; > diff --git a/drivers/hv/hv.c b/drivers/hv/hv.c > index e83507f49676..97b21256a9db 100644 > --- a/drivers/hv/hv.c > +++ b/drivers/hv/hv.c > @@ -8,6 +8,7 @@ > */ > #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt >=20 > +#include > #include > #include > #include > @@ -136,17 +137,24 @@ int hv_synic_alloc(void) > tasklet_init(&hv_cpu->msg_dpc, > vmbus_on_msg_dpc, (unsigned long) hv_cpu); >=20 > - hv_cpu->synic_message_page =3D > - (void *)get_zeroed_page(GFP_ATOMIC); > - if (hv_cpu->synic_message_page =3D=3D NULL) { > - pr_err("Unable to allocate SYNIC message page\n"); > - goto err; > - } > + /* > + * Synic message and event pages are allocated by paravisor. > + * Skip these pages allocation here. > + */ > + if (!hv_isolation_type_snp()) { > + hv_cpu->synic_message_page =3D > + (void *)get_zeroed_page(GFP_ATOMIC); > + if (hv_cpu->synic_message_page =3D=3D NULL) { > + pr_err("Unable to allocate SYNIC message page\n"); > + goto err; > + } >=20 > - hv_cpu->synic_event_page =3D (void *)get_zeroed_page(GFP_ATOMIC); > - if (hv_cpu->synic_event_page =3D=3D NULL) { > - pr_err("Unable to allocate SYNIC event page\n"); > - goto err; > + hv_cpu->synic_event_page =3D > + (void *)get_zeroed_page(GFP_ATOMIC); > + if (hv_cpu->synic_event_page =3D=3D NULL) { > + pr_err("Unable to allocate SYNIC event page\n"); > + goto err; > + } > } >=20 > hv_cpu->post_msg_page =3D (void *)get_zeroed_page(GFP_ATOMIC); > @@ -199,26 +207,43 @@ void hv_synic_enable_regs(unsigned int cpu) > union hv_synic_scontrol sctrl; >=20 > /* Setup the Synic's message page */ > - simp.as_uint64 =3D hv_get_register(HV_REGISTER_SIMP); > + hv_get_simp(simp.as_uint64); > simp.simp_enabled =3D 1; > - simp.base_simp_gpa =3D virt_to_phys(hv_cpu->synic_message_page) > - >> HV_HYP_PAGE_SHIFT; >=20 > - hv_set_register(HV_REGISTER_SIMP, simp.as_uint64); > + if (hv_isolation_type_snp()) { > + hv_cpu->synic_message_page > + =3D memremap(simp.base_simp_gpa << HV_HYP_PAGE_SHIFT, > + HV_HYP_PAGE_SIZE, MEMREMAP_WB); > + if (!hv_cpu->synic_message_page) > + pr_err("Fail to map syinc message page.\n"); > + } else { > + simp.base_simp_gpa =3D virt_to_phys(hv_cpu->synic_message_page) > + >> HV_HYP_PAGE_SHIFT; > + } > + > + hv_set_simp(simp.as_uint64); >=20 > /* Setup the Synic's event page */ > - siefp.as_uint64 =3D hv_get_register(HV_REGISTER_SIEFP); > + hv_get_siefp(siefp.as_uint64); > siefp.siefp_enabled =3D 1; > - siefp.base_siefp_gpa =3D virt_to_phys(hv_cpu->synic_event_page) > - >> HV_HYP_PAGE_SHIFT; >=20 > - hv_set_register(HV_REGISTER_SIEFP, siefp.as_uint64); > + if (hv_isolation_type_snp()) { > + hv_cpu->synic_event_page =3D > + memremap(siefp.base_siefp_gpa << HV_HYP_PAGE_SHIFT, > + HV_HYP_PAGE_SIZE, MEMREMAP_WB); > + > + if (!hv_cpu->synic_event_page) > + pr_err("Fail to map syinc event page.\n"); > + } else { > + siefp.base_siefp_gpa =3D virt_to_phys(hv_cpu->synic_event_page) > + >> HV_HYP_PAGE_SHIFT; > + } > + hv_set_siefp(siefp.as_uint64); >=20 > /* Setup the shared SINT. */ > if (vmbus_irq !=3D -1) > enable_percpu_irq(vmbus_irq, 0); > - shared_sint.as_uint64 =3D hv_get_register(HV_REGISTER_SINT0 + > - VMBUS_MESSAGE_SINT); > + hv_get_synint_state(VMBUS_MESSAGE_SINT, shared_sint.as_uint64); >=20 > shared_sint.vector =3D vmbus_interrupt; > shared_sint.masked =3D false; > @@ -233,14 +258,12 @@ void hv_synic_enable_regs(unsigned int cpu) > #else > shared_sint.auto_eoi =3D 0; > #endif > - hv_set_register(HV_REGISTER_SINT0 + VMBUS_MESSAGE_SINT, > - shared_sint.as_uint64); > + hv_set_synint_state(VMBUS_MESSAGE_SINT, shared_sint.as_uint64); >=20 > /* Enable the global synic bit */ > - sctrl.as_uint64 =3D hv_get_register(HV_REGISTER_SCONTROL); > + hv_get_synic_state(sctrl.as_uint64); > sctrl.enable =3D 1; > - > - hv_set_register(HV_REGISTER_SCONTROL, sctrl.as_uint64); > + hv_set_synic_state(sctrl.as_uint64); > } >=20 > int hv_synic_init(unsigned int cpu) > @@ -257,37 +280,50 @@ int hv_synic_init(unsigned int cpu) > */ > void hv_synic_disable_regs(unsigned int cpu) > { > + struct hv_per_cpu_context *hv_cpu > + =3D per_cpu_ptr(hv_context.cpu_context, cpu); > union hv_synic_sint shared_sint; > union hv_synic_simp simp; > union hv_synic_siefp siefp; > union hv_synic_scontrol sctrl; >=20 > - shared_sint.as_uint64 =3D hv_get_register(HV_REGISTER_SINT0 + > - VMBUS_MESSAGE_SINT); > - > + hv_get_synint_state(VMBUS_MESSAGE_SINT, shared_sint.as_uint64); > shared_sint.masked =3D 1; > + hv_set_synint_state(VMBUS_MESSAGE_SINT, shared_sint.as_uint64); > + >=20 > /* Need to correctly cleanup in the case of SMP!!! */ > /* Disable the interrupt */ > - hv_set_register(HV_REGISTER_SINT0 + VMBUS_MESSAGE_SINT, > - shared_sint.as_uint64); > + hv_get_simp(simp.as_uint64); >=20 > - simp.as_uint64 =3D hv_get_register(HV_REGISTER_SIMP); > + /* > + * In Isolation VM, sim and sief pages are allocated by > + * paravisor. These pages also will be used by kdump > + * kernel. So just reset enable bit here and keep page > + * addresses. > + */ > simp.simp_enabled =3D 0; > - simp.base_simp_gpa =3D 0; > + if (hv_isolation_type_snp()) > + memunmap(hv_cpu->synic_message_page); > + else > + simp.base_simp_gpa =3D 0; >=20 > - hv_set_register(HV_REGISTER_SIMP, simp.as_uint64); > + hv_set_simp(simp.as_uint64); >=20 > - siefp.as_uint64 =3D hv_get_register(HV_REGISTER_SIEFP); > + hv_get_siefp(siefp.as_uint64); > siefp.siefp_enabled =3D 0; > - siefp.base_siefp_gpa =3D 0; >=20 > - hv_set_register(HV_REGISTER_SIEFP, siefp.as_uint64); > + if (hv_isolation_type_snp()) > + memunmap(hv_cpu->synic_event_page); > + else > + siefp.base_siefp_gpa =3D 0; > + > + hv_set_siefp(siefp.as_uint64); >=20 > /* Disable the global synic bit */ > - sctrl.as_uint64 =3D hv_get_register(HV_REGISTER_SCONTROL); > + hv_get_synic_state(sctrl.as_uint64); > sctrl.enable =3D 0; > - hv_set_register(HV_REGISTER_SCONTROL, sctrl.as_uint64); > + hv_set_synic_state(sctrl.as_uint64); >=20 > if (vmbus_irq !=3D -1) > disable_percpu_irq(vmbus_irq); > diff --git a/drivers/hv/hv_common.c b/drivers/hv/hv_common.c > index c0d9048a4112..1fc82d237161 100644 > --- a/drivers/hv/hv_common.c > +++ b/drivers/hv/hv_common.c > @@ -249,6 +249,12 @@ bool __weak hv_is_isolation_supported(void) > } > EXPORT_SYMBOL_GPL(hv_is_isolation_supported); >=20 > +bool __weak hv_isolation_type_snp(void) > +{ > + return false; > +} > +EXPORT_SYMBOL_GPL(hv_isolation_type_snp); > + > void __weak hv_setup_vmbus_handler(void (*handler)(void)) > { > } > diff --git a/include/asm-generic/mshyperv.h b/include/asm-generic/mshyper= v.h > index aa55447b9700..04a687d95eac 100644 > --- a/include/asm-generic/mshyperv.h > +++ b/include/asm-generic/mshyperv.h > @@ -24,6 +24,7 @@ > #include > #include > #include > +#include > #include >=20 > struct ms_hyperv_info { > @@ -54,6 +55,7 @@ extern void __percpu **hyperv_pcpu_output_arg; >=20 > extern u64 hv_do_hypercall(u64 control, void *inputaddr, void *outputadd= r); > extern u64 hv_do_fast_hypercall8(u16 control, u64 input8); > +extern bool hv_isolation_type_snp(void); >=20 > /* Helper functions that provide a consistent pattern for checking Hyper= -V hypercall status. */ > static inline int hv_result(u64 status) > @@ -148,7 +150,7 @@ static inline void vmbus_signal_eom(struct hv_message= *msg, u32 old_msg_type) > * possibly deliver another msg from the > * hypervisor > */ > - hv_set_register(HV_REGISTER_EOM, 0); > + hv_signal_eom(old_msg_type); > } > } >=20 > -- > 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu Sep 02 04:29:39 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 04:29:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.176873.321931 (Exim 4.92) (envelope-from ) id 1mLeLz-0007Sm-Qj; Thu, 02 Sep 2021 04:29:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 176873.321931; Thu, 02 Sep 2021 04:29:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLeLz-0007Sf-NE; Thu, 02 Sep 2021 04:29:31 +0000 Received: by outflank-mailman (input) for mailman id 176873; Thu, 02 Sep 2021 04:29:30 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLeLx-0007ST-Ui; Thu, 02 Sep 2021 04:29:29 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLeLx-0003VR-Nd; Thu, 02 Sep 2021 04:29:29 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLeLx-000875-FP; Thu, 02 Sep 2021 04:29:29 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mLeLx-0002ur-Ev; Thu, 02 Sep 2021 04:29:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=pNHNu+7/0kygYYHdfwSaykdtG98avYjjp7p186XenJo=; b=o6vza1WNPHjKgLUrgiQBr2N5OI CRTCJDlErAW14Ux2cSoKz+NEDo1yTqcLofehQLxdsYZpqrnNoEW61b8qma2OHWIxVQZmpIHQYLTRj ToWGOwLXnCvTery80ssEE5oPTg4wUkTH7k7TdqaQOGffjruyMkzkb7gdOuLFB3mvOodk=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 164743: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=e3ee8c8dbd7a9f7d7905abe17be60354c9f5f9a3 X-Osstest-Versions-That: ovmf=cae735f61328d64e2e8991036707b9e78c0f5f63 From: osstest service owner Date: Thu, 02 Sep 2021 04:29:29 +0000 flight 164743 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/164743/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 164674 build-amd64-xsm 6 xen-build fail REGR. vs. 164674 build-i386-xsm 6 xen-build fail REGR. vs. 164674 build-i386 6 xen-build fail REGR. vs. 164674 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf e3ee8c8dbd7a9f7d7905abe17be60354c9f5f9a3 baseline version: ovmf cae735f61328d64e2e8991036707b9e78c0f5f63 Last test of basis 164674 2021-08-31 02:56:52 Z 2 days Failing since 164686 2021-09-01 03:03:43 Z 1 days 9 attempts Testing same since 164740 2021-09-02 02:41:13 Z 0 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Anthony PERARD DunTan Gary Lin Jim Fehlig Lin, Gary (HPS OE-Linux) Loo Tung Lun Loo, Tung Lun Mark Wilson Marvin H?user Wenxing Hou jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit e3ee8c8dbd7a9f7d7905abe17be60354c9f5f9a3 Author: duntan Date: Fri Aug 20 14:43:37 2021 +0800 .azurepipelines: Add UefiPayloadPkg in gate-build-job.yml and CISetting.py Add UefiPayloadPkg in gate-build-job.yml to enable Core ci for UefiPayloadPkg. Add UefiPayloadPkg to supported Packages in CISettings. Cc: Sean Brogan Cc: Bret Barkelew Cc: Michael D Kinney Cc: Liming Gao Signed-off-by: DunTan Reviewed-by: Liming Gao commit 63fddc98e06c380e654b1cfbaf24b9fd922adfad Author: duntan Date: Fri Aug 20 14:43:36 2021 +0800 UefiPayloadPkg: Create .yaml file in UefiPayloadPkg Create .yaml file in UefiPayloadPkg to enable Core ci for UefiPayloadPkg Cc: Guo Dong Cc: Ray Ni Cc: Maurice Ma Cc: Benjamin You Signed-off-by: DunTan Reviewed-by: Liming Gao commit 12e33dca4c0612a0975265e5ba641c6261a26455 Author: Loo, Tung Lun Date: Tue Aug 17 15:43:12 2021 +0800 IntelFsp2Pkg: Support Config File and Binary delta comparison BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3567 This patch is to enable config editor to have a new feature that can spell out the delta between the default configuration files' data, such as YAML and BSF, against the data stored in the binary. This can help users understand and track the difference when modifications are made. Cc: Maurice Ma Cc: Nate DeSimone Cc: Star Zeng Cc: Chasel Chiu Signed-off-by: Loo Tung Lun Reviewed-by: Chasel Chiu commit b170806518c1e414939c8b085866544814e1ce8e Author: Mark Wilson Date: Fri Nov 13 08:05:18 2020 +0800 UefiCpuPkg: Clean up save state boundary checks and comments. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2956 In functions ReadSaveStateRegisterByIndex and WriteSaveStateRegister: * check width > 4 instead of >= 4 when writing upper 32 bytes. - This improves the code but will not affect functionality. Cc: Eric Dong Reviewed-by: Ray Ni Signed-off-by: Mark Wilson commit 3b3f88228812e2c642eea8746858a4dad928ebf7 Author: Marvin H?user Date: Mon Aug 9 14:09:25 2021 +0800 MdeModulePkg/PiSmmCore: Drop deprecated image profiling commands The legacy codebase allowed SMM images to be registered for profiling from DXE. Support for this has been dropped entirely, so remove the remaining handlers. Cc: Jian J Wang Cc: Hao A Wu Cc: Eric Dong Reviewed-by: Ray Ni Cc: Vitaly Cheptsov Signed-off-by: Marvin H?user commit cdda3f74a1327663a5d48cca13507085ba403af7 Author: Marvin H?user Date: Mon Aug 9 03:39:53 2021 +0800 UefiPayloadPkg/UefiPayloadEntry: Fix memory corruption UefiPayloadEntry's AllocatePool() applies the "sizeof" operator to HOB index rather than the HOB header structure. This yields 4 Bytes compared to the 8 Bytes the structure header requires. Fix the call to allocate the required space instead. Reviewed-by: Guo Dong Reviewed-by: Ray Ni Cc: Maurice Ma Cc: Benjamin You Cc: Vitaly Cheptsov Signed-off-by: Marvin H?user commit 5d34cc49d5d348012fe8acf9fb618826bd541a7c Author: Wenxing Hou Date: Tue Aug 24 16:11:11 2021 +0800 UefiCpuPkg/PiSmmCpuDxeSmm: Update mPatchCetSupported set condition REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3584 Function AsmCpuid should first check the value for Basic CPUID Information. The fix is to update the mPatchCetSupported judgment statement. Signed-off-by: Wenxing Hou Reviewed-by: Ray Ni Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Cc: Sheng W Cc: Yao Jiewen commit f0fe55bca4651734abf1752a1d7c69fb5bee00b9 Author: duntan Date: Fri Aug 20 13:04:29 2021 +0800 UefiPayloadPkg: Fix the build error when enable Core ci for UefiPayloadPkg V1: Add quotes when using $(ARCH) in .dsc and .fdf file. The quotes are added due to the way by which Core ci parse the .dsc file. Add UINTN in Hob.c to fix cast from pointer to integer of different size error. V2: Delete lines which reference ShellBinPkg.The pkg doesn't exist in edk2. Cc: Guo Dong Cc: Ray Ni Cc: Maurice Ma Cc: Benjamin You Signed-off-by: DunTan Reviewed-by: Ray Ni commit 9f3eda177a4b2d4a33ff1b0307cad42906396562 Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:29:48 2021 +0800 OvmfPkg/OvmfXen: add QemuKernelLoaderFsDxe Without QemuKernelLoaderFsDxe, QemuLoadKernelImage() couldn't download the kernel, initrd, and kernel command line from QEMU's fw_cfg. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3574 Signed-off-by: Gary Lin Acked-by: Anthony PERARD Reviewed-by: Philippe Mathieu-Daude Reviewed-by: Gerd Hoffmann Tested-by: Jim Fehlig commit 5b5f10d7465004e3e40ec1f50a3b490b4db595e7 Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:31:15 2021 +0800 OvmfPkg/SmmControl2Dxe: use PcdAcpiS3Enable to detect S3 support To avoid the potential inconsistency between PcdAcpiS3Enable and QemuFwCfgS3Enabled(), this commit modifies SmmControl2Dxe to detect S3 support by PcdAcpiS3Enable as modules in MdeModulePkg do. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3573 Signed-off-by: Gary Lin Reviewed-by: Gerd Hoffmann Reviewed-by: Jiewen Yao Tested-by: Jim Fehlig commit 52e2dabc0f8d3af09c213072ce8ba734302f585d Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:31:14 2021 +0800 OvmfPkg/PlatformBootManagerLib: use PcdAcpiS3Enable to detect S3 support To avoid the potential inconsistency between PcdAcpiS3Enable and QemuFwCfgS3Enabled(), this commit modifies PlatformBootManagerLib to detect S3 support by PcdAcpiS3Enable as modules in MdeModulePkg do. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3573 Signed-off-by: Gary Lin Reviewed-by: Gerd Hoffmann Reviewed-by: Jiewen Yao Tested-by: Jim Fehlig commit 28152333bccb778b62e6e97446b28bfa0e92ef82 Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:31:13 2021 +0800 OvmfPkg/LockBoxLib: use PcdAcpiS3Enable to detect S3 support To avoid the potential inconsistency between PcdAcpiS3Enable and QemuFwCfgS3Enabled(), this commit modifies LockBoxLib to detect S3 support by PcdAcpiS3Enable as modules in MdeModulePkg do. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3573 Signed-off-by: Gary Lin Reviewed-by: Philippe Mathieu-Daude Reviewed-by: Gerd Hoffmann Reviewed-by: Jiewen Yao Tested-by: Jim Fehlig commit cb0d24637dfdd869618b9635dfb8e3b0746393a6 Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:31:12 2021 +0800 OvmfPkg/OvmfXen: set PcdAcpiS3Enable at initialization There are several functions in OvmfPkg/Library using QemuFwCfgS3Enabled() to detect the S3 support status. However, in MdeModulePkg, PcdAcpiS3Enable is used to check S3 support. Since InitializeXenPlatform() didn't set PcdAcpiS3Enable as InitializePlatform() did, this made the inconsistency between drivers/functions. For example, S3SaveStateDxe checked PcdAcpiS3Enable and skipped S3BootScript because the default value is FALSE. On the other hand, PlatformBootManagerBeforeConsole() from OvmfPkg/Library called QemuFwCfgS3Enabled() and found it returned TRUE, so it invoked SaveS3BootScript(). However, S3SaveStateDxe skipped S3BootScript, so SaveS3BootScript() asserted due to EFI_NOT_FOUND. This issue mainly affects "HVM Direct Kernel Boot". When used, "fw_cfg" is enabled in QEMU and QemuFwCfgS3Enabled() returns true in that case. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3573 Signed-off-by: Gary Lin Reviewed-by: Anthony PERARD Reviewed-by: Gerd Hoffmann Reviewed-by: Jiewen Yao Tested-by: Jim Fehlig From xen-devel-bounces@lists.xenproject.org Thu Sep 02 04:57:03 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 04:57:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.176883.321951 (Exim 4.92) (envelope-from ) id 1mLemP-00031x-4y; Thu, 02 Sep 2021 04:56:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 176883.321951; Thu, 02 Sep 2021 04:56:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLemP-00031q-1k; Thu, 02 Sep 2021 04:56:49 +0000 Received: by outflank-mailman (input) for mailman id 176883; Thu, 02 Sep 2021 04:56:47 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLemN-00031k-9F for xen-devel@lists.xenproject.org; Thu, 02 Sep 2021 04:56:47 +0000 Received: from outbound.mail.eo.outlook.com (unknown [40.93.8.11]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id ab2f5f11-c20f-41e1-8f83-106d04bbc49e; Thu, 02 Sep 2021 04:56:44 +0000 (UTC) Received: from MWHPR21MB1593.namprd21.prod.outlook.com (2603:10b6:301:7c::11) by MWHPR21MB0704.namprd21.prod.outlook.com (2603:10b6:300:128::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.1; Thu, 2 Sep 2021 04:56:41 +0000 Received: from MWHPR21MB1593.namprd21.prod.outlook.com ([fe80::3c8b:6387:cd5:7d86]) by MWHPR21MB1593.namprd21.prod.outlook.com ([fe80::3c8b:6387:cd5:7d86%8]) with mapi id 15.20.4478.014; Thu, 2 Sep 2021 04:56:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ab2f5f11-c20f-41e1-8f83-106d04bbc49e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=diHzAfLzvHkLnGDBA77CxjILWQ0f4yi16eeG/tktyrNTahSkFhlY4zM/KqPreJW5GvOG5lnHcmdLoGHxu/GnypUBLdOuwXZrB5X5iaY5ZWEAeYUkQ24CYeU4XYbHPPdY087rZ66Koj/CtdHhpbAoLdiv29fYui7rEWaz/E27FLQq4rbC/Hllk84wAkRx508cuEPKqwMTKZ9ljCmxYaY2YO6mP13CeUCYq73ntFtINifFfzfQQOEVAET6RG99JNrSjos94yTmg/FFPHJilJRaADS4sL0ziwKi/JCEUn4vnRovq4pAbFLothJaUzEMLrmrFw6BTPrd4QxTnwBYH+m9hg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=/g+2tfLa4TWsUYnWx7YAfFpKGu7PCDx8XRRyHbecAJY=; b=ISc15lW0YFYaIzGaYZcf7eSaag/OIA6d2PDby2AN03uuws9YkkDRS+BeaCF7hDi7FXbNdZOTM0OfreC8gKqKzWfX72n7NrfVJkN+FO+NSX+QZpPgRCRrzp/FwD12TK9KxuxOlMpaTsdTwoHKRTgr2FH8j8Y7zzTqzjQe6nVTtLjFrs8+Wm+27I5fNZzWXR8yPUJSbfJ1edY2u8maoJ1GatLGyKvvc9eNya/tFT8wmytGJc2cQdEffaAcKbISwnCgxSxNy3F/um/brEfwunRTOYzzOUAta2qrVU9LIMuRmx1daNCem7Pv/NVK7BGArSXRwZFRNbAvhSKwV7BBI4gW0g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/g+2tfLa4TWsUYnWx7YAfFpKGu7PCDx8XRRyHbecAJY=; b=GmQbcuvDU5mYwcbUJ2PC5qkKcAeHuBop+hvo5IULzB7MP/WHRrNX3ze0EQRNBGFccqbV1wj7garo8nxApCLffgPlbZhUM1lgqoD4lOwClaPJmtlvW4qaERy1vXfh3eAXrbLY/sLKD9tYs/o8RhHB94SvVCQcDPRLUSRNJ5CQP9M= From: Michael Kelley To: Tianyu Lan , KY Srinivasan , Haiyang Zhang , Stephen Hemminger , "wei.liu@kernel.org" , Dexuan Cui , "catalin.marinas@arm.com" , "will@kernel.org" , "tglx@linutronix.de" , "mingo@redhat.com" , "bp@alien8.de" , "x86@kernel.org" , "hpa@zytor.com" , "dave.hansen@linux.intel.com" , "luto@kernel.org" , "peterz@infradead.org" , "konrad.wilk@oracle.com" , "boris.ostrovsky@oracle.com" , "jgross@suse.com" , "sstabellini@kernel.org" , "joro@8bytes.org" , "davem@davemloft.net" , "kuba@kernel.org" , "jejb@linux.ibm.com" , "martin.petersen@oracle.com" , "gregkh@linuxfoundation.org" , "arnd@arndb.de" , "hch@lst.de" , "m.szyprowski@samsung.com" , "robin.murphy@arm.com" , "brijesh.singh@amd.com" , "thomas.lendacky@amd.com" , Tianyu Lan , "pgonda@google.com" , "martin.b.radev@gmail.com" , "akpm@linux-foundation.org" , "kirill.shutemov@linux.intel.com" , "rppt@kernel.org" , "hannes@cmpxchg.org" , "aneesh.kumar@linux.ibm.com" , "krish.sadhukhan@oracle.com" , "saravanand@fb.com" , "linux-arm-kernel@lists.infradead.org" , "xen-devel@lists.xenproject.org" , "rientjes@google.com" , "ardb@kernel.org" CC: "iommu@lists.linux-foundation.org" , "linux-arch@vger.kernel.org" , "linux-hyperv@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-scsi@vger.kernel.org" , "netdev@vger.kernel.org" , vkuznets , "parri.andrea@gmail.com" , "dave.hansen@intel.com" Subject: RE: [PATCH V4 12/13] hv_netvsc: Add Isolation VM support for netvsc driver Thread-Topic: [PATCH V4 12/13] hv_netvsc: Add Isolation VM support for netvsc driver Thread-Index: AQHXm2gP6jy1GRuc+0K7S1qphPLgHKuQCC+wgAAtP2A= Date: Thu, 2 Sep 2021 04:56:40 +0000 Message-ID: References: <20210827172114.414281-1-ltykernel@gmail.com> <20210827172114.414281-13-ltykernel@gmail.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ActionId=24c2ad3d-af1e-4524-bef7-f93352ae7e8f;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=true;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Standard;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=Internal;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2021-09-02T02:09:02Z;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=microsoft.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7f4c007b-0072-45e0-73ee-08d96dce0d9d x-ms-traffictypediagnostic: MWHPR21MB0704: x-ms-exchange-transport-forked: True x-ld-processed: 72f988bf-86f1-41af-91ab-2d7cd011db47,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 64n9ZHQNFsz+NZtjmS32VhXFDsqb8zSWHHkpOgEAVkAOEYbK/lXOyJqt83v3+p/qJhmo1s4vtVRa5OFw+A80IEGG56thQ86l8sHgNWJJZzk+y80rlDn3zM74xtFvm0zFR9PXp4daK9ZEV+5x4R12LF0mVAAAh3i5Jx/ncYh1K73KkVgtBS7G0aAgZ33DJ0VLYZixVKxyZgiqIrr4GKstKHTQf7oSCByGiv8ykKVEeRYQ2zzX3FKEJ46WvygnaZWc2/i27ylRxUqCsE3FVujK4swpkfIEBbT3s9hFiufZ/agR0+EuqeuPdnKwDYPZVFxdqm+4yElIMyN4W9TsEXbaHohZHwwJJY/nHZhrJSTEWqDD5Dn4Tk01ukOe4E5rhnh1tQXionIjcAm13RTUZSWBP3ceRArg3r74e/XGA5YEmeZBWoDg79JJJY/GBwB5DtR8C/7RRvG4463rpwlG4oEoEv4WfOeTY77ikav98zTrcOXnUoUbLksknqpkwvAinPOTTEjyJFVNhdtZIZVD1ekXcbgKONHpVy6VLyiRqONqcq9w81ZRlRtw15+42oi4QhLpgK6ve5dokzz7q0iGJRtEWq6ELDLbn5OCOJH7SQEBBvP0iNNOJO0uRpAoYPaYvQTS8fdYfyvLbuoAFRWyyBAK+jOA/k+AyczCL5J1FGCb1Dk7wjVYuBSEnCwmvmwStG7YOfHdthwm2QC9hE9j7GdtYa2fO0PngUipTC7szx/U3Q8= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR21MB1593.namprd21.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(66946007)(9686003)(66476007)(66556008)(10290500003)(76116006)(64756008)(508600001)(186003)(7696005)(66446008)(122000001)(2940100002)(5660300002)(8936002)(316002)(921005)(6506007)(8676002)(33656002)(83380400001)(110136005)(8990500004)(2906002)(38070700005)(26005)(82950400001)(38100700002)(71200400001)(82960400001)(86362001)(52536014)(7416002)(7366002)(7406005)(55016002)(4326008)(54906003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?6EXkemG7X07lxyyEVGMWnZY1RJrvvTxJhOuuA3ahPWNi/QB6p2Fe1JSTWrhL?= =?us-ascii?Q?zNvbAB2OIg6osr5Wcg38XUQKN95LY8icqsTsmNQQMyPhQ4WqC7Pr6I/YnHIY?= =?us-ascii?Q?kAehk0612De9pWwHx2JufPylsK+6aLdZxTS0kOFlVuYHJMfyTZA4QrSdFTRb?= =?us-ascii?Q?l941Wi26kmgYfHho1pRjLJdBU0+3HBfO9MAQ54nGFq+cViyI5WFZO14ywN4P?= =?us-ascii?Q?dkf05ljqyoJeEqKb5ODxUl3MaE1NDDXlwsPTSqPi+YlKhtU3nw7LqFRuPv77?= =?us-ascii?Q?fva9x9vDPH9wRGCJMZExTTl3ffVGILZJtmp48Eowql8wJoTBxp0L6d+ibw7l?= =?us-ascii?Q?yLI5Hicoqgvp1GGDioypge+6qDJMQW3p+06HR1ethl5meh8SS+549sQzSOTh?= =?us-ascii?Q?t7XFV1DVuKl2ZTt6+u3mm3gcCb2vuwWsbSEltgn4Pjgs3zS+U8EPGnNNMckG?= =?us-ascii?Q?dpFxBEq7P3O4xwgINCk80PSIhLFeHsmh55wxSyArjayop2e5MY9fQ0T/7YGn?= =?us-ascii?Q?3o229iwTW5zpedYah+f4zMkX9MQfQ8P9CGN7t4pqXnb/JTSmjwdbPy0L4+A5?= =?us-ascii?Q?aiyR0LAlWMcZhk24zw+TYSBVEbQ36LBikmKzICRL+5TyimSGEXmuVDOxsGyu?= =?us-ascii?Q?zOeylCJ70LTnZPR+0xx+nxTBxhyAnfTpImGYrPiye7uhk11aiVwWbGaxaspe?= =?us-ascii?Q?Dci8Tu62eUS8EUGCGQo/G3x3DqcR7fStDnQ1Fl5pvV9NCC/+ou91D4q4U8yC?= =?us-ascii?Q?GYHb9sAC9MIMG99g7i8RvZ5XArm25QKCu5+tz9pcp3C3so0F5/TPlkgePyf8?= =?us-ascii?Q?bnNPvwFJQrA4h7857rad4qC1K//+ntDXp3mso0Gf4k1NoCs30CW7ha2+MObm?= =?us-ascii?Q?VT+LZay4wDOgoQDEfWO+LRcd0wWHB9ozah3a2RRt7HRdrCbZSFY5Dyu6+hN5?= =?us-ascii?Q?SE4Uo7p0YZyONhi6oLj2T1c8+/ou7hxoNYwTfW/QER5yN6ats56gLjLR9F8e?= =?us-ascii?Q?ycfJhEcfMewHC/123Moiy6lcUUHPmXehUFwNhAaGrnyXPTOOE9LqLAlL8GaC?= =?us-ascii?Q?GpHY00fVHl0FhFa9Zw3mMJ1rBFGi7ysY9atT4KZGRwSt4OaacwO5CJyTvSVu?= =?us-ascii?Q?NXsRm7QwfkenbM9NfewkB8NT8LPagUyTMthGedIdo+kyHF9e4UCwbElo+A3t?= =?us-ascii?Q?lDGdJ07HBcp76BT7Fz2zHC0T/mlvuwEBTdapFc3ts6fOURINtJ5pir67PgHa?= =?us-ascii?Q?oOPkvGdqPu8l5XwHFt1lY0aemWmDCUyFohffPqTqvMLEX0jgNifasxn5Jt3Q?= =?us-ascii?Q?XjnOeVB+bdznBYzrnkKcTU01?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR21MB1593.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7f4c007b-0072-45e0-73ee-08d96dce0d9d X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Sep 2021 04:56:40.6250 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: HQFrIKEO1/7vXPGsi6Dj8gkGAUk2kVTDMG1CDEjqxBoLGRSW2nnJEeXs7PCEgMxxQYhcC5DNiGsb5npNJkcRdevFW1BZIHUZ93h3srjzPa0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR21MB0704 From: Michael Kelley Sent: Wednesday, September 1,= 2021 7:34 PM [snip] > > +int netvsc_dma_map(struct hv_device *hv_dev, > > + struct hv_netvsc_packet *packet, > > + struct hv_page_buffer *pb) > > +{ > > + u32 page_count =3D packet->cp_partial ? > > + packet->page_buf_cnt - packet->rmsg_pgcnt : > > + packet->page_buf_cnt; > > + dma_addr_t dma; > > + int i; > > + > > + if (!hv_is_isolation_supported()) > > + return 0; > > + > > + packet->dma_range =3D kcalloc(page_count, > > + sizeof(*packet->dma_range), > > + GFP_KERNEL); > > + if (!packet->dma_range) > > + return -ENOMEM; > > + > > + for (i =3D 0; i < page_count; i++) { > > + char *src =3D phys_to_virt((pb[i].pfn << HV_HYP_PAGE_SHIFT) > > + + pb[i].offset); > > + u32 len =3D pb[i].len; > > + > > + dma =3D dma_map_single(&hv_dev->device, src, len, > > + DMA_TO_DEVICE); > > + if (dma_mapping_error(&hv_dev->device, dma)) { > > + kfree(packet->dma_range); > > + return -ENOMEM; > > + } > > + > > + packet->dma_range[i].dma =3D dma; > > + packet->dma_range[i].mapping_size =3D len; > > + pb[i].pfn =3D dma >> HV_HYP_PAGE_SHIFT; > > + pb[i].offset =3D offset_in_hvpage(dma); > > + pb[i].len =3D len; > > + } >=20 > Just to confirm, this driver does *not* set the DMA min_align_mask > like storvsc does. So after the call to dma_map_single(), the offset > in the page could be different. That's why you are updating > the pb[i].offset value. Alternatively, you could set the DMA > min_align_mask, which would ensure the offset is unchanged. > I'm OK with either approach, though perhaps a comment is > warranted to explain, as this is a subtle issue. >=20 On second thought, I don't think either approach is OK. The default alignment in the swiotlb is 2K, and if the length of the data in the buffer was 3K, the data could cross a page boundary in the bounce buffer when it originally did not. This would break the above code which can only deal with one page at a time. So I think the netvsc driver also must set the DMA min_align_mask to 4K, which will preserve the offset. Michael From xen-devel-bounces@lists.xenproject.org Thu Sep 02 06:00:49 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 06:00:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.176893.321973 (Exim 4.92) (envelope-from ) id 1mLfm5-0002xr-VE; Thu, 02 Sep 2021 06:00:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 176893.321973; Thu, 02 Sep 2021 06:00:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLfm5-0002xk-S5; Thu, 02 Sep 2021 06:00:33 +0000 Received: by outflank-mailman (input) for mailman id 176893; Thu, 02 Sep 2021 06:00:32 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLfm4-0002xe-31 for xen-devel@lists.xenproject.org; Thu, 02 Sep 2021 06:00:32 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 1391809c-0bb3-11ec-ae3e-12813bfff9fa; Thu, 02 Sep 2021 06:00:30 +0000 (UTC) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04lp2059.outbound.protection.outlook.com [104.47.14.59]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-17-_ZlLMGi5PW2ujws4aoQMqA-1; Thu, 02 Sep 2021 08:00:28 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR04MB6173.eurprd04.prod.outlook.com (2603:10a6:803:ff::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.23; Thu, 2 Sep 2021 06:00:27 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4478.021; Thu, 2 Sep 2021 06:00:27 +0000 Received: from [10.156.60.236] (37.24.206.209) by PR3P193CA0030.EURP193.PROD.OUTLOOK.COM (2603:10a6:102:50::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Thu, 2 Sep 2021 06:00:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1391809c-0bb3-11ec-ae3e-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1630562429; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nC+9HmiyN8tVvvPJOvEBYdkLxGcD03BuhBqwPRC12mQ=; b=Fvkhcpn5ROPnx59kqiGL7ot1nXCPqsYuIH3SmgyXsw+RwA8QPAPR/2DdrrEicu5ggwV4Xh 5u4NDPgZiliSPcNCGLTdEuPKGQp6nLjjRUtTnwUzmYOLNMSK2lAOoiABqM2PiuMhlPoFfR a54t4Zoocz1RV/AriDcv+iTSsXRj44Q= X-MC-Unique: _ZlLMGi5PW2ujws4aoQMqA-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=h/Myo87nMPuu3OvTsQwALPeycrrQFH4n8VvJ5umuLgQzm/sqKIWQq9VKavtwwRJFEJPTo1++E4QSL8KBikHt0eCdXZEUualqniHI2vD7xAzUh/x5RqMTq4PFg2SqbA135NarC3D91c8BENprXecU+ez1C8dlMz6EeLlYK65GcaI1vzdenUywnSypIJcmOXQyQSGlCVuoblPHjc1pnAnz4w+qsky9QYFx2NrCFaDhQ/EyIJdek1leBl4I6ly2ttdWOyIT2kTNPKMmRT39YQn4KceC7EmLijJesNvg6Bv4GXJmvBVEpFDAKfiSSPY2uDGJxH0i++cOptkN/Lq/ql9Zjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TbBGseStlkeOTJ5Gdk2wq00BX9kdOoWEm2+cqRGWZDA=; b=OzTQufgGHLa22yzQDwIw69LRQoouqhuTV2NzaraOWKoLQ49Uhp6Lm8pqRSkUub2RAAE5qibpT/bSWB4aVF6HxvTm4Yz524VNQAiJecOb/vCZ+5pkfquGb3W3Z6WoJ7bwoGt8FR+HurevEvJVR5dpYhGxbpmN4T+tge/BRWECAIBHCxD4xOl6IFXfsprwPw0jLrzkKHIQiMkCEbUIObHefvdDGQEI8eCppIb3Xzmwo/ngoSohNYb7x83pGpB8UwAWsXz5BC4dh1MZ201Fv+530D4ZbHNdr0XhTyDP39QLGjmyn8Cf2NaSyLWW5C1OAsLfJJAK4hQrMeXwbIsG1B597A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=suse.com; Subject: Re: [XEN RFC PATCH 24/40] xen/arm: introduce a helper to parse device tree NUMA distance map To: Stefano Stabellini , Wei Chen CC: "xen-devel@lists.xenproject.org" , "julien@xen.org" , Bertrand Marquis References: <20210811102423.28908-1-wei.chen@arm.com> <20210811102423.28908-25-wei.chen@arm.com> From: Jan Beulich Message-ID: Date: Thu, 2 Sep 2021 08:00:25 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: PR3P193CA0030.EURP193.PROD.OUTLOOK.COM (2603:10a6:102:50::35) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0f228516-5502-423e-f163-08d96dd6f673 X-MS-TrafficTypeDiagnostic: VI1PR04MB6173: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: O2x7S07dpmshUk8wFmgnSyV4xuUJ5+sD8h978JYQAP4mD5kqnVB7DL2VCIUwxISvMX3kfP2hVXtvW/2Yr8uR9/kCwcSEMZiFNabEVI1/C+Kun/lD2Mh0ZpDfTeOv/GRJC65LcCldgJ2F5AelADQ5ugdQhHnnYzEhpTClo377FGhVWQJq3NiLSOUmrEGxnBs/g4lD9wQ/ozjpeBoqY7p2ISyM+gYgEdBgjWjNmmFkeqgyT5k2R/FmXuhRKJC+K4hRH468L3PMR9Z5a1Xi4yTI/6N4RLhUJkUhWNg57GInFeqgbJTJ3ejCoP9w2ZPKh6gV4TQ3mm/jkZ1EZWgZiz9qOgt976bSnO9cMGdquZB5PysYrggmB1SEYqU2LypS+7zEt0doPm+L9Ol17vnEAJpufqbsrsqK2hlyFvY3Y0zSjQN3t3AjUz8hz6IglnFt+S2II4DrALPaFOjLaUm6cceillROoAo6CQ9hMS0LsvgPsNZBWTCGNgJ0/Z6+oTX3mHYhaiDXbC0kxC4vXUFOpo1fokRkq9HBETuCFiYMvperAqDiK8CCY1votnPrs8rIFXpXZ13mN7cWqlTPQzN/8xEr8x7Pl/68dPXmTw0E8fQTQqslocR3rWWfXYFBSRH2R9b1zwv1IsyUg79TkxpjNCin0IKJZww1hFAvK6ZkX2+Sr462fqoyRrZuiPohkkgo9cGAvoeX93vR3CZCSxE90dn8ZdPpJdxXSgjDV+5owlHjqXw= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(39860400002)(366004)(396003)(376002)(346002)(136003)(36756003)(8676002)(2616005)(8936002)(6486002)(956004)(86362001)(26005)(110136005)(66556008)(66476007)(53546011)(54906003)(16576012)(316002)(31696002)(66946007)(478600001)(4326008)(38100700002)(31686004)(186003)(2906002)(5660300002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?aY/riTP+rSmQ6CrbF/9tBbS0He25OlEingMszT5jU8d7dBShRYlVbNVpP381?= =?us-ascii?Q?96e5Erg5treQfk0U8ky7rs6krtp5v0ucrV83a3A9MVbEZW3q6e7DdrFqvdRd?= =?us-ascii?Q?ViR/z1W1Tb7xCBsC5ebrNrN/mPYv/njFBPgpLi3jPaF7IW0WmkGY9+Oij7V/?= =?us-ascii?Q?hFiM3NZI3VJMa2FNXf+0pYYYNpJPSpjlwSTx+CY/k2fFEs0MqcUKMjTTOsCw?= =?us-ascii?Q?yTD2n57sbhrPFW4myHGQ06uYKruNIju+vlnf4+HP82zbHhd4qvkSaBx94O2J?= =?us-ascii?Q?jIxl0kNIFRzOaw9wqP4leEBpg12nS23Ox0m9eWhfW/Zuj71X4cxJMORaNGod?= =?us-ascii?Q?Qo9x7FTQzUDfP0G2FhIaog2ntAW3yM1wygXf9EO0Y62S4+UPB1a7JIGhj0lw?= =?us-ascii?Q?LG0Xw+mh3+RLWtyutEX5ZQzwIZ/Ed7dAuZjd5sLJ4PZ83ni4wCoXzb3QTOV9?= =?us-ascii?Q?rqPupBOOIjPuyvjp4M4WvCMEiu9kz+WxBDojwQ2ev02YSEG2f7nDKmzI5XRY?= =?us-ascii?Q?1LZ6xtZv46gYRXdwjcwdRl0zSwXdSw5q77xkrECNk81nVM+5xcsN9YLWAMLd?= =?us-ascii?Q?GuiGJtspya9MF0UGZGlzOVE7MUslno2LlO4kffoziNiFrC5hdnv8XJwr7O9o?= =?us-ascii?Q?3q3ZRKbMTM3C7qmTE7IT3GOap/47MnklCEjH1/3MOnkilvGSZre4b2stkKle?= =?us-ascii?Q?wqG/T0RJfJsg0g/B2/tH/NlwlQtQf69quY7ILwpQgvXcjCLq5qYMf/bCgAA+?= =?us-ascii?Q?mJ7Zkt5CXhsaicm9VGCpASm7YvbiHqGAUYTROW7nLMTvH4jKknkV6pd8BMwb?= =?us-ascii?Q?2RopmJMXERhN/6fVyId3ZQ7tbtrAot1n+SsNH4Tkgsahmv8RuZBHHBNgct9U?= =?us-ascii?Q?VNpqpAdw8UIsAFjdDHWUt1LrsBQ+FnZRVbxUWMcjXT1jkYs81y1enrmErtok?= =?us-ascii?Q?MbdJJ0wQAZCFYaO48OsjnCvj7M+/0iJm0csfpHf08F1NibqypQaZvfsE8Hix?= =?us-ascii?Q?EQlVOdOLZQqMnVyhN7lUgdi/N6X9G8kMu6QGsqBzajmwb0hjs3g1rpwZdHVj?= =?us-ascii?Q?vEXhbFlAn5UJ3Wz9BgDuF9/L5FY/HTv+zm2+8RzChtykvBcwNSr3EnZtg+9h?= =?us-ascii?Q?jnlyugydMwCLuQ6L0UsTxUSI5Eu7zuYZvMIQMBKa7L+LXY36Hefac0z43A4z?= =?us-ascii?Q?DvdHVopqQGaRDj0XxJxXpZAIe+ZyGxtIWi6eMq06c+/782/Tj565WRLxmTZa?= =?us-ascii?Q?sPLEFTZXA+EJUm31TSUMKI1Q03eF/eL1BK0dkxstmWkDgD/p8q09SRnTZ5V2?= =?us-ascii?Q?SmAaZqTOnFDgteEfoiVvedqt?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0f228516-5502-423e-f163-08d96dd6f673 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Sep 2021 06:00:27.6917 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ojAZtHKtXPbvmBV18kYQwwWXzK5+2ZhSpSLMDwdvfKajnYIXRj76IaWkTEWPvatnKOANlthkfo18EKIXFcAlAA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6173 On 01.09.2021 18:21, Stefano Stabellini wrote: > On Wed, 1 Sep 2021, Wei Chen wrote: >>> Stefano Stabellini >>> Sent: 2021=E5=B9=B49=E6=9C=881=E6=97=A5 5:36 >>> >>> On Tue, 31 Aug 2021, Wei Chen wrote: >>>> I don't really like this implementation. I want the behavior of >>>> numa_set_distance just like the function name, do not include >>>> implicit operations. Otherwise, except the user read this function >>>> implementation before he use it, he probably doesn't know this >>>> function has done so many things. >>> >>> You can leave numa_set_distance as-is without any implicit operations. >>> >>> In that case, just call numa_set_distance twice from numa_set_distance >>> for both from/to and to/from. numa_set_distance could return error is >> >> I am OK for the first sentence. But... >> >>> the entry was already set to a different value or success otherwise >>> (also in the case it was already set to the same value). This would >> >> ... I prefer not to check the previous value. Subsequent numa_set_distan= ce >> call will override previous calls. Keep numa_set_distance as simple as >> it can. And when you pass new data to numa_set_distance, it doesn't >> know whether the previous data was correct or the new data is correct. >> Only caller may have known. =20 >=20 > That might be OK but if not numa_set_distance then somebody else needs > to check against overwriting previous values. That is to be able to spot > bad device tree cases like: >=20 > 0 1 20 > 1 0 40 What's wrong with this? At least the ACPI spec cares to specifically permit this case: "Except for the relative distance from a System Locality to itself, each relative distance is stored twice in the matrix. This provides the capability to describe the scenario where the relative distances for the two directions between System Localities is different." Jan From xen-devel-bounces@lists.xenproject.org Thu Sep 02 06:04:11 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 06:04:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.176901.321985 (Exim 4.92) (envelope-from ) id 1mLfpa-0003vt-L5; Thu, 02 Sep 2021 06:04:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 176901.321985; Thu, 02 Sep 2021 06:04:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLfpa-0003vm-I8; Thu, 02 Sep 2021 06:04:10 +0000 Received: by outflank-mailman (input) for mailman id 176901; Thu, 02 Sep 2021 06:04:09 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLfpZ-0003vc-2d; Thu, 02 Sep 2021 06:04:09 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLfpY-0005U5-SP; Thu, 02 Sep 2021 06:04:08 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLfpY-0004xW-Jz; Thu, 02 Sep 2021 06:04:08 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mLfpY-0001YZ-JV; Thu, 02 Sep 2021 06:04:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=6PHwo3l0jfuI9G8Xy/DtSlE4Hi0bM+BslyfBpaVetrM=; b=WEp1zu7/D9EF8gUevd+sKYRoTX V7MTbvYJQzUN5pCqo4wcyct2qs7sM7iS5W603VN8tLjp5YEyxdLe7wLQR7pvivichthb+bvGLQWNn 95PmCLhDyDe82sgPx1tl/Cj/lMIrvGsfZAfexAeqqJ/arjCde4oH+848eo2nwJr9hXSA=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 164746: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=e3ee8c8dbd7a9f7d7905abe17be60354c9f5f9a3 X-Osstest-Versions-That: ovmf=cae735f61328d64e2e8991036707b9e78c0f5f63 From: osstest service owner Date: Thu, 02 Sep 2021 06:04:08 +0000 flight 164746 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/164746/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 164674 build-amd64-xsm 6 xen-build fail REGR. vs. 164674 build-i386-xsm 6 xen-build fail REGR. vs. 164674 build-i386 6 xen-build fail REGR. vs. 164674 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf e3ee8c8dbd7a9f7d7905abe17be60354c9f5f9a3 baseline version: ovmf cae735f61328d64e2e8991036707b9e78c0f5f63 Last test of basis 164674 2021-08-31 02:56:52 Z 2 days Failing since 164686 2021-09-01 03:03:43 Z 1 days 10 attempts Testing same since 164740 2021-09-02 02:41:13 Z 0 days 3 attempts ------------------------------------------------------------ People who touched revisions under test: Anthony PERARD DunTan Gary Lin Jim Fehlig Lin, Gary (HPS OE-Linux) Loo Tung Lun Loo, Tung Lun Mark Wilson Marvin H?user Wenxing Hou jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit e3ee8c8dbd7a9f7d7905abe17be60354c9f5f9a3 Author: duntan Date: Fri Aug 20 14:43:37 2021 +0800 .azurepipelines: Add UefiPayloadPkg in gate-build-job.yml and CISetting.py Add UefiPayloadPkg in gate-build-job.yml to enable Core ci for UefiPayloadPkg. Add UefiPayloadPkg to supported Packages in CISettings. Cc: Sean Brogan Cc: Bret Barkelew Cc: Michael D Kinney Cc: Liming Gao Signed-off-by: DunTan Reviewed-by: Liming Gao commit 63fddc98e06c380e654b1cfbaf24b9fd922adfad Author: duntan Date: Fri Aug 20 14:43:36 2021 +0800 UefiPayloadPkg: Create .yaml file in UefiPayloadPkg Create .yaml file in UefiPayloadPkg to enable Core ci for UefiPayloadPkg Cc: Guo Dong Cc: Ray Ni Cc: Maurice Ma Cc: Benjamin You Signed-off-by: DunTan Reviewed-by: Liming Gao commit 12e33dca4c0612a0975265e5ba641c6261a26455 Author: Loo, Tung Lun Date: Tue Aug 17 15:43:12 2021 +0800 IntelFsp2Pkg: Support Config File and Binary delta comparison BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3567 This patch is to enable config editor to have a new feature that can spell out the delta between the default configuration files' data, such as YAML and BSF, against the data stored in the binary. This can help users understand and track the difference when modifications are made. Cc: Maurice Ma Cc: Nate DeSimone Cc: Star Zeng Cc: Chasel Chiu Signed-off-by: Loo Tung Lun Reviewed-by: Chasel Chiu commit b170806518c1e414939c8b085866544814e1ce8e Author: Mark Wilson Date: Fri Nov 13 08:05:18 2020 +0800 UefiCpuPkg: Clean up save state boundary checks and comments. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2956 In functions ReadSaveStateRegisterByIndex and WriteSaveStateRegister: * check width > 4 instead of >= 4 when writing upper 32 bytes. - This improves the code but will not affect functionality. Cc: Eric Dong Reviewed-by: Ray Ni Signed-off-by: Mark Wilson commit 3b3f88228812e2c642eea8746858a4dad928ebf7 Author: Marvin H?user Date: Mon Aug 9 14:09:25 2021 +0800 MdeModulePkg/PiSmmCore: Drop deprecated image profiling commands The legacy codebase allowed SMM images to be registered for profiling from DXE. Support for this has been dropped entirely, so remove the remaining handlers. Cc: Jian J Wang Cc: Hao A Wu Cc: Eric Dong Reviewed-by: Ray Ni Cc: Vitaly Cheptsov Signed-off-by: Marvin H?user commit cdda3f74a1327663a5d48cca13507085ba403af7 Author: Marvin H?user Date: Mon Aug 9 03:39:53 2021 +0800 UefiPayloadPkg/UefiPayloadEntry: Fix memory corruption UefiPayloadEntry's AllocatePool() applies the "sizeof" operator to HOB index rather than the HOB header structure. This yields 4 Bytes compared to the 8 Bytes the structure header requires. Fix the call to allocate the required space instead. Reviewed-by: Guo Dong Reviewed-by: Ray Ni Cc: Maurice Ma Cc: Benjamin You Cc: Vitaly Cheptsov Signed-off-by: Marvin H?user commit 5d34cc49d5d348012fe8acf9fb618826bd541a7c Author: Wenxing Hou Date: Tue Aug 24 16:11:11 2021 +0800 UefiCpuPkg/PiSmmCpuDxeSmm: Update mPatchCetSupported set condition REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3584 Function AsmCpuid should first check the value for Basic CPUID Information. The fix is to update the mPatchCetSupported judgment statement. Signed-off-by: Wenxing Hou Reviewed-by: Ray Ni Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Cc: Sheng W Cc: Yao Jiewen commit f0fe55bca4651734abf1752a1d7c69fb5bee00b9 Author: duntan Date: Fri Aug 20 13:04:29 2021 +0800 UefiPayloadPkg: Fix the build error when enable Core ci for UefiPayloadPkg V1: Add quotes when using $(ARCH) in .dsc and .fdf file. The quotes are added due to the way by which Core ci parse the .dsc file. Add UINTN in Hob.c to fix cast from pointer to integer of different size error. V2: Delete lines which reference ShellBinPkg.The pkg doesn't exist in edk2. Cc: Guo Dong Cc: Ray Ni Cc: Maurice Ma Cc: Benjamin You Signed-off-by: DunTan Reviewed-by: Ray Ni commit 9f3eda177a4b2d4a33ff1b0307cad42906396562 Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:29:48 2021 +0800 OvmfPkg/OvmfXen: add QemuKernelLoaderFsDxe Without QemuKernelLoaderFsDxe, QemuLoadKernelImage() couldn't download the kernel, initrd, and kernel command line from QEMU's fw_cfg. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3574 Signed-off-by: Gary Lin Acked-by: Anthony PERARD Reviewed-by: Philippe Mathieu-Daude Reviewed-by: Gerd Hoffmann Tested-by: Jim Fehlig commit 5b5f10d7465004e3e40ec1f50a3b490b4db595e7 Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:31:15 2021 +0800 OvmfPkg/SmmControl2Dxe: use PcdAcpiS3Enable to detect S3 support To avoid the potential inconsistency between PcdAcpiS3Enable and QemuFwCfgS3Enabled(), this commit modifies SmmControl2Dxe to detect S3 support by PcdAcpiS3Enable as modules in MdeModulePkg do. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3573 Signed-off-by: Gary Lin Reviewed-by: Gerd Hoffmann Reviewed-by: Jiewen Yao Tested-by: Jim Fehlig commit 52e2dabc0f8d3af09c213072ce8ba734302f585d Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:31:14 2021 +0800 OvmfPkg/PlatformBootManagerLib: use PcdAcpiS3Enable to detect S3 support To avoid the potential inconsistency between PcdAcpiS3Enable and QemuFwCfgS3Enabled(), this commit modifies PlatformBootManagerLib to detect S3 support by PcdAcpiS3Enable as modules in MdeModulePkg do. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3573 Signed-off-by: Gary Lin Reviewed-by: Gerd Hoffmann Reviewed-by: Jiewen Yao Tested-by: Jim Fehlig commit 28152333bccb778b62e6e97446b28bfa0e92ef82 Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:31:13 2021 +0800 OvmfPkg/LockBoxLib: use PcdAcpiS3Enable to detect S3 support To avoid the potential inconsistency between PcdAcpiS3Enable and QemuFwCfgS3Enabled(), this commit modifies LockBoxLib to detect S3 support by PcdAcpiS3Enable as modules in MdeModulePkg do. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3573 Signed-off-by: Gary Lin Reviewed-by: Philippe Mathieu-Daude Reviewed-by: Gerd Hoffmann Reviewed-by: Jiewen Yao Tested-by: Jim Fehlig commit cb0d24637dfdd869618b9635dfb8e3b0746393a6 Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:31:12 2021 +0800 OvmfPkg/OvmfXen: set PcdAcpiS3Enable at initialization There are several functions in OvmfPkg/Library using QemuFwCfgS3Enabled() to detect the S3 support status. However, in MdeModulePkg, PcdAcpiS3Enable is used to check S3 support. Since InitializeXenPlatform() didn't set PcdAcpiS3Enable as InitializePlatform() did, this made the inconsistency between drivers/functions. For example, S3SaveStateDxe checked PcdAcpiS3Enable and skipped S3BootScript because the default value is FALSE. On the other hand, PlatformBootManagerBeforeConsole() from OvmfPkg/Library called QemuFwCfgS3Enabled() and found it returned TRUE, so it invoked SaveS3BootScript(). However, S3SaveStateDxe skipped S3BootScript, so SaveS3BootScript() asserted due to EFI_NOT_FOUND. This issue mainly affects "HVM Direct Kernel Boot". When used, "fw_cfg" is enabled in QEMU and QemuFwCfgS3Enabled() returns true in that case. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3573 Signed-off-by: Gary Lin Reviewed-by: Anthony PERARD Reviewed-by: Gerd Hoffmann Reviewed-by: Jiewen Yao Tested-by: Jim Fehlig From xen-devel-bounces@lists.xenproject.org Thu Sep 02 06:20:07 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 06:20:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.176938.322005 (Exim 4.92) (envelope-from ) id 1mLg4w-00060H-3C; Thu, 02 Sep 2021 06:20:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 176938.322005; Thu, 02 Sep 2021 06:20:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLg4v-0005zU-VR; Thu, 02 Sep 2021 06:20:01 +0000 Received: by outflank-mailman (input) for mailman id 176938; Thu, 02 Sep 2021 06:20:00 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLg4u-0005t9-4L for xen-devel@lists.xenproject.org; Thu, 02 Sep 2021 06:20:00 +0000 Received: from foss.arm.com (unknown [217.140.110.172]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTP id cc3910cd-0bb5-11ec-ae3e-12813bfff9fa; Thu, 02 Sep 2021 06:19:58 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2F8BB1FB; Wed, 1 Sep 2021 23:19:58 -0700 (PDT) Received: from [10.57.19.246] (unknown [10.57.19.246]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 6CFB03F766; Wed, 1 Sep 2021 23:19:56 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cc3910cd-0bb5-11ec-ae3e-12813bfff9fa Subject: Re: [PATCH] xen/arm: Introduce pmu_access parameter To: Stefano Stabellini , Julien Grall Cc: Bertrand Marquis , "xen-devel@lists.xenproject.org" , Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Wei Liu , Volodymyr Babchuk References: <20210901124308.31573-1-michal.orzel@arm.com> <599515f0-4b8a-3a71-caea-b17ec27c9123@xen.org> <44B48162-EB44-4295-9629-2D95A40D7232@arm.com> <46e36ba5-8b3d-2d43-6297-b92d2654ab72@xen.org> From: Michal Orzel Message-ID: <0c527a57-44f2-d888-3210-644ea3aa940e@arm.com> Date: Thu, 2 Sep 2021 08:19:51 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Hi Stefano, On 01.09.2021 19:54, Stefano Stabellini wrote: > On Wed, 1 Sep 2021, Julien Grall wrote: >> On 01/09/2021 14:10, Bertrand Marquis wrote: >>>> On 1 Sep 2021, at 13:55, Julien Grall wrote: >>>> >>>> Hi, >>>> >>>> On 01/09/2021 13:43, Michal Orzel wrote: >>>>> Introduce new Xen command line parameter called "pmu_access". >>>>> The default value is "trap": Xen traps PMU accesses. >>>>> In case of setting pmu_access to "native", Xen does not trap >>>>> PMU accesses allowing all the guests to access PMU registers. >>>>> However, guests cannot make use of PMU overflow interrupts as >>>>> PMU uses PPI which Xen cannot route to guests. >>>>> This option is only intended for development and testing purposes. >>>>> Do not use this in production system. >>>> I am afraid your option is not safe even in development system as a vCPU >>>> may move between pCPUs. >>>> >>>> However, even if we restricted the use to pinned vCPU *and* dedicated >>>> pCPU, I am not convinced that exposing an half backed PMU (the overflow >>>> interrupt would not work) to the guest is the right solution. This likely >>>> means the guest OS would need to be modified and therefore the usage of >>>> this option is fairly limited. >>>> >>>> So I think the first steps are: >>>> 1) Make the PPI work. There was some attempt in the past for it on >>>> xen-devel. You could have a look. >>>> 2) Provide PMU bindings >>>> >>>> With that in place, we can discuss how to expose the PMU even if it is >>>> unsafe in some conditions. >>> >>> With those limitations, using the PMU to monitor the system performances or >>> on some specific use cases is still really useful. >>> We are using that to do some benchmarks of Xen or of some applications to >>> compare the behaviour to a native system or >>> analyse the performances of Xen itself (hypercalls,context switch …etc) > > I also already had to write a patch almost exactly like this one to > provide to customers a few months back. > > >> I understand this is useful for some setup and I am not trying to say we >> should not have a way to expose the PMU (even unsafely) in upstream. However, >> I think the option as it stands is too wide (this should be a per domain knob) >> and we should properly expose the PMU (interrupts, bindings...). > > I have never used PMU directly myself, only provided a patch similar to > this one. But as far as I could tell the users were fully satisfied > with it and it had no interrupts support either. Could it be that > interrupts are not actually needed to read the perf counters, which is > probably what users care about? > Most of the people using PMU do not need interrupt as PMU can only be programmed to generate overflow interrupt request when a counter overflows. If we want to catch counter overflow without using interrupt, we can check if overflow status bit is set to 1 in PMOVSCLR register. > In regards to "this should be a per domain knob", in reality if you are > doing PMU experiments you don't care if only one or all domains have > access: you are working in a controlled environment trying to figure out > if your setup meets the timing requirements. There are no security or > safety concerns (those are different experiments) and there is no > interference problems in the sense of multiple domains trying to access > PMU at the same time -- you control the domains you decide which one is > accessing them. > > So I am in favor of a patch like this one because it actually satisfy > our requirements. Even if we had per-domain support and interrupts > support, I don't think they would end up being used. > From xen-devel-bounces@lists.xenproject.org Thu Sep 02 06:27:26 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 06:27:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.176944.322016 (Exim 4.92) (envelope-from ) id 1mLgC2-0007Yp-SC; Thu, 02 Sep 2021 06:27:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 176944.322016; Thu, 02 Sep 2021 06:27:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLgC2-0007Yi-Ob; Thu, 02 Sep 2021 06:27:22 +0000 Received: by outflank-mailman (input) for mailman id 176944; Thu, 02 Sep 2021 06:27:20 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLgC0-0007YY-MX; Thu, 02 Sep 2021 06:27:20 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLgC0-0005ud-Hh; Thu, 02 Sep 2021 06:27:20 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLgC0-0005qj-9X; Thu, 02 Sep 2021 06:27:20 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mLgC0-0007Gy-91; Thu, 02 Sep 2021 06:27:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=FT+xdppRgBkZokyT92a/gOctpaZDhag/iLyFbntrcT4=; b=SSPKY0k/xiyN/vdoVbKNpSmjGF nDNQR++YzAcvUEWNtAe6Bo4CvsCScJOPbAbWrIm4DmHB8bbmGkQSKUEGR6hGdFpltoaUx2N7q8uV1 RQWY2hfPv2+iPPih3KXF7twzHvmBUN+fXBQFg2fLmTuJfpKuzt3plyM8WbkTD+La58pA=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 164725: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=4c41a1c595e1ce3fe29f3b7bb22ff7402be9c77d X-Osstest-Versions-That: qemuu=d52dff5d8048d4982437db9606c27bb4127cf9d0 From: osstest service owner Date: Thu, 02 Sep 2021 06:27:20 +0000 flight 164725 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/164725/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 164690 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 164690 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 164690 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 164690 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 164690 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 164690 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 164690 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: qemuu 4c41a1c595e1ce3fe29f3b7bb22ff7402be9c77d baseline version: qemuu d52dff5d8048d4982437db9606c27bb4127cf9d0 Last test of basis 164690 2021-09-01 08:37:55 Z 0 days Testing same since 164725 2021-09-01 21:39:10 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Alexander Bulekov Alistair Francis Bin Meng Cai Huoqing Christian Schoenebeck David Hoppenbrouwers Dongwon Kim Gerd Hoffmann Helge Deller Joe Komlodi Jose R. Ziviani LIU Zhiwei Peter Maydell Philippe Mathieu-Daudé Qiang Liu Richard Henderson Thomas Huth Vijai Kumar K jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git d52dff5d80..4c41a1c595 4c41a1c595e1ce3fe29f3b7bb22ff7402be9c77d -> upstream-tested From xen-devel-bounces@lists.xenproject.org Thu Sep 02 06:31:03 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 06:31:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.176952.322029 (Exim 4.92) (envelope-from ) id 1mLgFZ-0000YN-Ij; Thu, 02 Sep 2021 06:31:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 176952.322029; Thu, 02 Sep 2021 06:31:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLgFZ-0000YG-Fo; Thu, 02 Sep 2021 06:31:01 +0000 Received: by outflank-mailman (input) for mailman id 176952; Thu, 02 Sep 2021 06:31:00 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLgFY-0000YA-Fr for xen-devel@lists.xenproject.org; Thu, 02 Sep 2021 06:31:00 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 55adbe10-0bb7-11ec-ae40-12813bfff9fa; Thu, 02 Sep 2021 06:30:59 +0000 (UTC) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01lp2055.outbound.protection.outlook.com [104.47.0.55]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-16-om1gsGNxM8KXJl3CXTu7yw-1; Thu, 02 Sep 2021 08:30:57 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR0401MB2445.eurprd04.prod.outlook.com (2603:10a6:800:55::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19; Thu, 2 Sep 2021 06:30:55 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4478.021; Thu, 2 Sep 2021 06:30:55 +0000 Received: from [10.156.60.236] (37.24.206.209) by AM0PR07CA0025.eurprd07.prod.outlook.com (2603:10a6:208:ac::38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.16 via Frontend Transport; Thu, 2 Sep 2021 06:30:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 55adbe10-0bb7-11ec-ae40-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1630564258; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NHsd+b8WBTxsiYSoThy12w4xRZWH/jbrxlJXllqH2rw=; b=G05TDj1ZSgpnH/o0ZbW1MbIEzbmGigctWqJPv8ne5cmgLYMolicnmDBJ9LVIuRixYlkxZa E9bTxC/0BujPsIcWS2npw4HBPg0yCNkVQVISriYcIq4W5GLRKf9KjsDbB8zLTHWK+Bh/ai qpR2HAuAg76FwMUYXU2yqFJBWcpHReM= X-MC-Unique: om1gsGNxM8KXJl3CXTu7yw-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=d1IuVKr6MBQlKnf9DNzaw8sZttvukCHtaG6Uzk6vDFvQJ2vyBCiiUCkpBljERlLo29TpzrcPlL4XusU5cmLetH/DtRQ48rYO6mgGhvKpLfP29qfNUXsfIPFzMeqmimFxG7CV9u3eeWsZkSLuu8efFY2qbrBvMijBGb097er8U77MGbCVojaow0ttJvEFvrb4tBneAzB1EbwhX9u91UMJ3VyapFY1qGefNynZLFH/WkFnRJAhTzOWeWROQ3mxyxQkk0hrYUtZPAwM1QRVg5mB7sQS1guEuO2b5rO06r/dOpMjHSoxlz6lFzNgqa8GMZACHka9WL8xvZpq1Qi8cZ6mUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=6yovaqJcbacXnyqAkIzRPSSq5Hm0cSAJGlG1VSsXglM=; b=ISI/b1bm9BmDvdmzNmGaLNnG1uDe5E2QP6swui8siJcOqjKv1Mcrmh8OUquM3CB7XnuQ8PFc4480lOqqyXw3x6NQ8/Cy63h9ErpjopAmKOcr8lx+93DX+WzcI2dGMq+xSWkY3wq+n4rYO5SYOPeNALPDMxK83ctWfbCx9oNWc/t8pbHIFLpazIUJ/44OrJY7DdbxOTPaI2gDEMq9r8Dx9U+N/eHLbX0UEk7hmuEmMen/3IDJhyhmh0qQSeZnhRv0iLQ+JfVryRrTEvbXA1LPi/BeyKvoDrswITyVczr5N1L4arCMhr0/Doq1tySiprSWsbWhCnb7GrkxIG4L61a3cA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=suse.com; Subject: Re: [PATCH 0/4] x86/PVH: Dom0 building adjustments To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= CC: "xen-devel@lists.xenproject.org" , Andrew Cooper , Wei Liu References: <17c5ce48-11e6-ac97-fa67-294cbb8b79b7@suse.com> From: Jan Beulich Message-ID: <1e37d6ef-b96f-cf09-277d-403abd9eecbb@suse.com> Date: Thu, 2 Sep 2021 08:30:53 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AM0PR07CA0025.eurprd07.prod.outlook.com (2603:10a6:208:ac::38) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a8dac602-16aa-48d1-26ab-08d96ddb3817 X-MS-TrafficTypeDiagnostic: VI1PR0401MB2445: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wBXNTn+KClSpf+pJ9VV4QRaKujiY9BasFYv84VSLNLxrcxHqOc+SpfCzVe+1EphoGaxr/9imm8CSJ7lcnW9xYDmEggZLiJV7MwqWfEj0acaqgjc/NcJlzm4LTsrf/XQaP3AGl99gAJ1TwST3Ii7DTJhQdjAReJlx6Y3b851AQQo2gD1J9ywlLNVvIFtq6QydVQnjCs/qibJ00pVYw0RUdgLKOO6Ib3helfdgw3mBZdOV2iV66I6bgDoCogmSWWXF2sSCWFrlTdSPVTMdyPRd0o2YIga66xSBybaSg/oGI+/3lt0OfIxX+7TyiGwDs26kR7Wqmt6z0cx7BtBco58iBIkiTh6R1cxxwmhjB0m/Wgg/O4kOAXNDA2zfeR74dJKa3snHszdKbK0+R7AdS+AtzA90Raw6lYhdfIEtCXJkUYklbE/3e1q7c8WYSHP3wRckhoRb6GyxNVETN1EV47qIUYE8pMrA8sON3f9rq0y6PkscC7GigtngIBPW8m64i540CG0/z83927Ew3RNcfT3czxSKQMyV/ex7caUAuLA/i5k3Nn2HgfziNZ6SetGzgFBKJx93Z7zUbvEHimDFM+ojvP0bBXTAyTGC5qEXwXLSJfFh3PDMbu1wnEHytiw/a2MR5ZFIvfH+GsJvwdnVmjDVPyaJ1apMLBZlKKNnWCFqgmSWodUBqNUjDvUFx1z002WyfL7ZOaVXAQM8hgA5YuQ1eUiXaYzbdymunxBhtbYkNHw= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(346002)(39860400002)(376002)(136003)(366004)(396003)(38100700002)(66476007)(66946007)(316002)(8936002)(31696002)(36756003)(6916009)(66556008)(8676002)(5660300002)(54906003)(16576012)(31686004)(478600001)(86362001)(2906002)(53546011)(26005)(186003)(6486002)(4326008)(956004)(83380400001)(2616005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?y7guap8YjqQXZsDHt7FzG+pd3pJB/bIkHLb+R0Hrh7f86rg+03WVwicywtWM?= =?us-ascii?Q?VYcXFTidtsZHuTVCVv6MrQt/MyxvZhjkK4aNuzbQiSJSGkI4003z6cuNjcji?= =?us-ascii?Q?N+nxHMW6wUxmrNsIxodlR7ysK1p1On2hrH2gCK3Mlizjwjwin+f8I2c69fIS?= =?us-ascii?Q?D6gt/SkWy7O1gGtQb++FaC6YcjjKSPwYXDGIJir1R+QqJvbpyWXHTxs91pkm?= =?us-ascii?Q?CCqinxKRzfoqOq99DjOJNhwi2SFgV8YcRqCk+n6p6/caT2DWYHalNza7+xrN?= =?us-ascii?Q?aD/5huqEqSjiaA5VN9pcNZQXI4PzSmqdOQEeginUiwMeXO33Fy1wkdR2ZLpU?= =?us-ascii?Q?TlKY05NzMIWvyA1Hf5rxzxGmDQsWtpefAQZ6LtvGGO65hp3tZ+kWs5BbBhuk?= =?us-ascii?Q?DFt60DaM54qvijVoPECquPsdQch3CWDw2w6Vhh30KHAZDrKuHL+e/ti9o82I?= =?us-ascii?Q?a6UDGWh8xQcMU8hd7WL2XRec4/Hizt7b9VvJJPTm1QCgaIi8cMY7wfb0OKFw?= =?us-ascii?Q?IQKahR/ylRu9v7NP2gzUeQEmMHSwrdAQGR7Wf/ewLBS50POrJ3NEl7OVa4qr?= =?us-ascii?Q?vga6QP6ReQBGLFmaiDRzmhAoZfHSelfArUlpIB7bYaaFKEqXejT3F2VmANtt?= =?us-ascii?Q?zXWMb6Js9vYNhASMI2EuhMnG1NcpcWP8SJWq7HeNhunddgi9mWrwpfyiZPcd?= =?us-ascii?Q?m6Xwx88bhsIDghZPSmEx9KJN8bFuYaqBlHwOiWXlyFvNzb/ZAslB1SGNoKxk?= =?us-ascii?Q?ZYfVsfZNZoMU376MMGyJdc/tK4CzY17UV88nwm0aBZDi5vtnr1LEjpX3XK7t?= =?us-ascii?Q?cC5DhFdVwScl2rMeY0KgJDOK4baeYe7Bt0Cg6ye48mj8DMRcYPfhotKOqMvc?= =?us-ascii?Q?GLoKzNP/Zd0DU5M1Q14t43kPEWN6D8D5C7pKhgAKQCHCu/HltyvxHzRI1m4t?= =?us-ascii?Q?j60gXEcs+DkqaKMmx6mbdF9LF6J6P4Xh2uM6Acf2smr5eKrNbNql4lunhDEr?= =?us-ascii?Q?LJuRqQBkQisDw1H83Bcc5DK0exUsYY1qPV0XFmQaz+cahoLtik3tmJKsbg0m?= =?us-ascii?Q?xfP8g5EkNQyE+VNtoyL9QoiMkgJISbB5YQe5nmiGrcz87EOFjNgKVvmvQlv2?= =?us-ascii?Q?o0h3+ZZL41Wt3p6LoCToTqw32MRNALdBxAioDStnJ8p35gdqeG4S/SFzP/n6?= =?us-ascii?Q?acSZFQ0+TZkx4hHYJDAUgXVsdxad8aloEf7Ls7vm4hRpPhTxgrTRUhhcySHh?= =?us-ascii?Q?N2ktEwz/DI1dioOMk6+FKIZP+ZhrwlK/jj+Fy+ekjX442jRWyfPZnBI+mrYE?= =?us-ascii?Q?ciXtS3ltCqH1Bwz8hsKjLwZ7?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: a8dac602-16aa-48d1-26ab-08d96ddb3817 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Sep 2021 06:30:55.7351 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +SVbiIU2qnU9407pjy+3OtFTPIRZSO9Hbbf9tuCpzJ1MD/+lWvgJMG6uazJdtA5WcxX3w7ShMtfFjLxtjYxKEQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2445 On 01.09.2021 18:13, Roger Pau Monn=C3=A9 wrote: > On Wed, Sep 01, 2021 at 04:19:40PM +0200, Jan Beulich wrote: >> On 01.09.2021 15:56, Roger Pau Monn=C3=A9 wrote: >>> On Tue, Aug 31, 2021 at 10:53:59AM +0200, Jan Beulich wrote: >>>> On 30.08.2021 15:01, Jan Beulich wrote: >>>>> The code building PVH Dom0 made use of sequences of P2M changes >>>>> which are disallowed as of XSA-378. First of all population of the >>>>> first Mb of memory needs to be redone. Then, largely as a >>>>> workaround, checking introduced by XSA-378 needs to be slightly >>>>> relaxed. >>>>> >>>>> Note that with these adjustments I get Dom0 to start booting on my >>>>> development system, but the Dom0 kernel then gets stuck. Since it >>>>> was the first time for me to try PVH Dom0 in this context (see >>>>> below for why I was hesitant), I cannot tell yet whether this is >>>>> due further fallout from the XSA, or some further unrelated >>>>> problem. >>> >>> Iff you have some time could you check without the XSA applied? I have >>> to admit I haven't been testing staging, so it's possible some >>> breakage as slipped in (however osstest seemed fine with it). >> >> Well, I'd rather try to use the time to find the actual issue. From >> osstest being fine I'm kind of inferring this might be machine >> specific, or this might be due to yet some other of the overly many >> patches I'm carrying. So if I can't infer anything from the stack >> once I can actually dump that, I may indeed need to bisect my pile, >> which would then also include the XSA-378 patches (as I didn't have >> time to re-base so far). >> >>>>> Dom0's BSP is in VPF_blocked state while all APs are >>>>> still in VPF_down. The 'd' debug key, unhelpfully, doesn't produce >>>>> any output, so it's non-trivial to check whether (like PV likes to >>>>> do) Dom0 has panic()ed without leaving any (visible) output. >>> >>> Not sure it would help much, but maybe you can post the Xen+Linux >>> output? >> >> There's no Linux output yet by that point (and either >> "earlyprintk=3Dxen" doesn't work in PVH mode, or it's even too early >> for that). All Xen has to say is >> >> (XEN) Dom0 callback via changed to Direct Vector 0xf3 >> (XEN) vmx.c:3265:d0v0 RDMSR 0x0000064e unimplemented >> (XEN) vmx.c:3265:d0v0 RDMSR 0x00000034 unimplemented >=20 > Weird, I don't see why earlyprintk=3Dxen shouldn't work in PVH mode, > unless it's not properly wired up. Certainly needs checking and > fixing, or else we won't be able to make much progress I think. Right - I'm intending to check this, including whether at least xen_raw_console_write() would work. >>>> Correction: I did mean '0' here, producing merely >>>> >>>> (XEN) '0' pressed -> dumping Dom0's registers >>>> (XEN) *** Dumping Dom0 vcpu#0 state: *** >>>> (XEN) *** Dumping Dom0 vcpu#1 state: *** >>>> (XEN) *** Dumping Dom0 vcpu#2 state: *** >>>> (XEN) *** Dumping Dom0 vcpu#3 state: *** >>>> >>>> 'd' output supports the "system is idle" that was also visible from >>>> 'q' output. >>> >>> Can you dump the state of the VMCS and see where the IP points to in >>> Linux? >> >> Both that and the register dumping I have meanwhile working tell >> me that it's the HLT in default_idle(). IOW Dom0 gives the impression >> of also being idle, at the first glance. The stack pointer, however, >> is farther away from the stack top than I would have expected, so it >> may still have entered default_idle() for other reasons. >> >> The VMCS also told me that the last VM entry was to deliver an >> interrupt at vector 0xf3 (i.e. the "callback" one). >=20 > That's all quite weird. Did dom0 setup the vCPU timer? Ah - I had meant to check active timers, but then forgot. Otoh I thought I could observe vCPU0 waking up from HLT, as RIP in the registers dumped has been pointing either at it or right past it. Now that I write this I'm wondering though whether that's an artifact rather than reflection of something that's really happening, in particular because of this (XEN) RSP =3D 0xffffffff81c03eb8 (0xffffffff81c03eb8) RIP =3D 0xffffffff81= 4be422 (0xffffffff814be423) in the VMCS dump. > What version of Linux are you using? 5.13.2; didn't get around to switching to 5.14 yet, but I also don't expect this to make a difference. > It seems to get stuck very early (or either fail to output anything > while booting), which seems unlikely to be related to your specific > hardware. Well, it can't be extremely early - I see the ACPI IRQ getting set up (from "iommu=3Ddebug" output mentioning GSI 9), and I see PCI device BARs being played with (from debug messages I had added to vPCI to monitor what P2M adjustments are being requested). As said on another sub-thread, I get all the way through start_kernel() and rest_init(), just that apparently some of the steps don't do what they're supposed to do. I'm meanwhile wondering whether I'm using a badly configured kernel, i.e. whether there are any Kconfig settings which I ought to enable, but which aren't "select"-ed nor have proper "depends on". What I did is simply take my XEN_PV=3Dy config, replacing that by XEN_PVH=3Dy. I did observe that this let XEN_DOM0 go off, but according to my checking (at the time) nothing this crucial should have been affected by that. Jan From xen-devel-bounces@lists.xenproject.org Thu Sep 02 06:35:36 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 06:35:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.176958.322041 (Exim 4.92) (envelope-from ) id 1mLgJw-0001Uh-5C; Thu, 02 Sep 2021 06:35:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 176958.322041; Thu, 02 Sep 2021 06:35:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLgJw-0001Ua-1o; Thu, 02 Sep 2021 06:35:32 +0000 Received: by outflank-mailman (input) for mailman id 176958; Thu, 02 Sep 2021 06:35:30 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLgJu-0001UU-9E for xen-devel@lists.xenproject.org; Thu, 02 Sep 2021 06:35:30 +0000 Received: from mail-pl1-x636.google.com (unknown [2607:f8b0:4864:20::636]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 80600cbb-2ca5-4052-96ee-071c6917b238; Thu, 02 Sep 2021 06:35:29 +0000 (UTC) Received: by mail-pl1-x636.google.com with SMTP id u1so553660plq.5 for ; Wed, 01 Sep 2021 23:35:29 -0700 (PDT) Received: from ?IPv6:2404:f801:0:5:8000::50b? ([2404:f801:9000:1a:efea::50b]) by smtp.gmail.com with ESMTPSA id g4sm1018401pjt.56.2021.09.01.23.35.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Sep 2021 23:35:28 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 80600cbb-2ca5-4052-96ee-071c6917b238 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=p4zDh7Zmvhg146z4qnwrQjuDGyGfYeNoi9EXmtV3vCk=; b=D1rnGa8kIjiZ7syMAy++5cDhLy8JHAOLoRVSufAq+d7fBo+t78Ke3s5Yz1uPgVHodR U6y3CPKzBmSzyPUZn2Il5d6T3nJ0NLYayesHqiQlQ4AEq/1OrsdnVq5iF5qtETbh4p6f YgZRdRXpDzg75R4rrFTDxF1Zz1nXCMjG9r/QcQXP8xK1ZctdFRxf6VSwgwv/ubG846BU K739MDCHAYaN+1tdvPFg/QEZ+f5A+dgNahgxMiNjqV+fKo13+NpkXyburB09UGN30GsF XrTtEDpmj/CBGDgU+QPL5YGf1gME4ItHnSLzoIa1FCF+YWcVe+sOEyV7VJxulilpk/4U stQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=p4zDh7Zmvhg146z4qnwrQjuDGyGfYeNoi9EXmtV3vCk=; b=HnOntxY7PPHffI/brxhFU1A2oI6rtw7Vt76QCfjql/e17KC2vdpkAePsfH8Y4JCLy2 +TF5UyZYJg1S0VV8BLvT+NgGRKrPf+EoVOTb91KB06tZrCgqymI2cGK5xFYrHSJ50leE o8jjAWEfUK5KaSVpX5NHwUGh4Jx8OB4hQa3QK7RmusXKr4c4UEcLr4K6Jmi/eVjtwgng FSG5mI9tUMN4pz2P3FVzlUawsDxDIOLCmcPMW/M8SWZKABTbfs/ghPa9wPxIYwQkaRSh S/9qubGj/fmVdgi3ebS3uMLNxHJCb/ROPyDqpqX/Bt9I/Ub4dEudTszqdCDKrfOyYBJw 7cxg== X-Gm-Message-State: AOAM532g7TG6KUCBbbvi/w+iZTF0eWoAm2vMemgzbK4fykFHlWOucCOV BG4S+polr96PH9gmB1311xc= X-Google-Smtp-Source: ABdhPJz4pUoRMJIRNU1Ww7Cq95vazM9v9pAhLPt1toZi1VH9XpEJzie9uEpEa09aj/QIF3t5VvMn8Q== X-Received: by 2002:a17:90a:509:: with SMTP id h9mr2194087pjh.71.1630564528531; Wed, 01 Sep 2021 23:35:28 -0700 (PDT) Subject: Re: [PATCH V4 02/13] x86/hyperv: Initialize shared memory boundary in the Isolation VM. To: Michael Kelley , KY Srinivasan , Haiyang Zhang , Stephen Hemminger , "wei.liu@kernel.org" , Dexuan Cui , "catalin.marinas@arm.com" , "will@kernel.org" , "tglx@linutronix.de" , "mingo@redhat.com" , "bp@alien8.de" , "x86@kernel.org" , "hpa@zytor.com" , "dave.hansen@linux.intel.com" , "luto@kernel.org" , "peterz@infradead.org" , "konrad.wilk@oracle.com" , "boris.ostrovsky@oracle.com" , "jgross@suse.com" , "sstabellini@kernel.org" , "joro@8bytes.org" , "davem@davemloft.net" , "kuba@kernel.org" , "jejb@linux.ibm.com" , "martin.petersen@oracle.com" , "gregkh@linuxfoundation.org" , "arnd@arndb.de" , "hch@lst.de" , "m.szyprowski@samsung.com" , "robin.murphy@arm.com" , "brijesh.singh@amd.com" , "thomas.lendacky@amd.com" , Tianyu Lan , "pgonda@google.com" , "martin.b.radev@gmail.com" , "akpm@linux-foundation.org" , "kirill.shutemov@linux.intel.com" , "rppt@kernel.org" , "hannes@cmpxchg.org" , "aneesh.kumar@linux.ibm.com" , "krish.sadhukhan@oracle.com" , "saravanand@fb.com" , "linux-arm-kernel@lists.infradead.org" , "xen-devel@lists.xenproject.org" , "rientjes@google.com" , "ardb@kernel.org" Cc: "iommu@lists.linux-foundation.org" , "linux-arch@vger.kernel.org" , "linux-hyperv@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-scsi@vger.kernel.org" , "netdev@vger.kernel.org" , vkuznets , "parri.andrea@gmail.com" , "dave.hansen@intel.com" References: <20210827172114.414281-1-ltykernel@gmail.com> <20210827172114.414281-3-ltykernel@gmail.com> From: Tianyu Lan Message-ID: <3162bb35-f047-ddbb-3836-6b048b7358e7@gmail.com> Date: Thu, 2 Sep 2021 14:35:12 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Hi Michael: Thanks for your review. On 9/2/2021 8:15 AM, Michael Kelley wrote: > From: Tianyu Lan Sent: Friday, August 27, 2021 10:21 AM >> >> Hyper-V exposes shared memory boundary via cpuid >> HYPERV_CPUID_ISOLATION_CONFIG and store it in the >> shared_gpa_boundary of ms_hyperv struct. This prepares >> to share memory with host for SNP guest. >> >> Signed-off-by: Tianyu Lan >> --- >> Change since v3: >> * user BIT_ULL to get shared_gpa_boundary >> * Rename field Reserved* to reserved >> --- >> arch/x86/kernel/cpu/mshyperv.c | 2 ++ >> include/asm-generic/mshyperv.h | 12 +++++++++++- >> 2 files changed, 13 insertions(+), 1 deletion(-) >> >> diff --git a/arch/x86/kernel/cpu/mshyperv.c b/arch/x86/kernel/cpu/mshyperv.c >> index 20557a9d6e25..8bb001198316 100644 >> --- a/arch/x86/kernel/cpu/mshyperv.c >> +++ b/arch/x86/kernel/cpu/mshyperv.c >> @@ -313,6 +313,8 @@ static void __init ms_hyperv_init_platform(void) >> if (ms_hyperv.priv_high & HV_ISOLATION) { >> ms_hyperv.isolation_config_a = cpuid_eax(HYPERV_CPUID_ISOLATION_CONFIG); >> ms_hyperv.isolation_config_b = cpuid_ebx(HYPERV_CPUID_ISOLATION_CONFIG); >> + ms_hyperv.shared_gpa_boundary = >> + BIT_ULL(ms_hyperv.shared_gpa_boundary_bits); >> >> pr_info("Hyper-V: Isolation Config: Group A 0x%x, Group B 0x%x\n", >> ms_hyperv.isolation_config_a, ms_hyperv.isolation_config_b); >> diff --git a/include/asm-generic/mshyperv.h b/include/asm-generic/mshyperv.h >> index 0924bbd8458e..7537ae1db828 100644 >> --- a/include/asm-generic/mshyperv.h >> +++ b/include/asm-generic/mshyperv.h >> @@ -35,7 +35,17 @@ struct ms_hyperv_info { >> u32 max_vp_index; >> u32 max_lp_index; >> u32 isolation_config_a; >> - u32 isolation_config_b; >> + union { >> + u32 isolation_config_b; >> + struct { >> + u32 cvm_type : 4; >> + u32 reserved11 : 1; >> + u32 shared_gpa_boundary_active : 1; >> + u32 shared_gpa_boundary_bits : 6; >> + u32 reserved12 : 20; > > I'm still curious about the "11" and "12" in the reserved > field names. Why not just "reserved1" and "reserved2"? > Having the "11" and "12" isn't wrong, but it makes one > wonder why since it's not usual. :-) > Yes, will update. Thanks. From xen-devel-bounces@lists.xenproject.org Thu Sep 02 06:45:43 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 06:45:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.176964.322052 (Exim 4.92) (envelope-from ) id 1mLgTj-0003BG-3h; Thu, 02 Sep 2021 06:45:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 176964.322052; Thu, 02 Sep 2021 06:45:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLgTj-0003B9-0c; Thu, 02 Sep 2021 06:45:39 +0000 Received: by outflank-mailman (input) for mailman id 176964; Thu, 02 Sep 2021 06:45:37 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLgTh-0003B3-OG for xen-devel@lists.xenproject.org; Thu, 02 Sep 2021 06:45:37 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 605c21ce-0bb9-11ec-ae41-12813bfff9fa; Thu, 02 Sep 2021 06:45:36 +0000 (UTC) Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-he1eur02lp2058.outbound.protection.outlook.com [104.47.5.58]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-2-p2y-zJ8XNKKXF2aMxxZt1A-1; Thu, 02 Sep 2021 08:45:34 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR0401MB2605.eurprd04.prod.outlook.com (2603:10a6:800:57::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.20; Thu, 2 Sep 2021 06:45:33 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4478.021; Thu, 2 Sep 2021 06:45:32 +0000 Received: from [10.156.60.236] (37.24.206.209) by PR3P191CA0008.EURP191.PROD.OUTLOOK.COM (2603:10a6:102:54::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.20 via Frontend Transport; Thu, 2 Sep 2021 06:45:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 605c21ce-0bb9-11ec-ae41-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1630565135; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2CCz0N6kirv4Y+bKxgrtsTMCCf7h9FVJy0MMlSYiGu8=; b=ZOpoVuvfvqggUGmfVmiOmmn+lpSJfOY4TG4SBzBF+SJdJzPymQ9DCVfTCdwlQWuvfkV2vr /NR2PONqyBBiL9Y3r1JLSNr2TeBP8aEZtiq730FUE1DRi8DDVyfTv86cqsy6zYDg2nOmEm qI0noTOkkmldhLLMyjFXZx1+OLubiB8= X-MC-Unique: p2y-zJ8XNKKXF2aMxxZt1A-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=H98I8P6tAF8SV0fMbBr7XkMZcpT8SHAdmIPkz+Ze0mQ8iieyAUSEAsWrspYe9MZ8qu2kVEhD0UO8TMXu+RHOWvR2o9iesqrranmdOHMOB6VYl4E40RFQXbJwhgTekIgpV+777kSrT4hTVTT89pV6iSdqab/L7/wDFirM4g/GFy+AU2SFylqjsVGW1VNnCP1DMN+pXLdiVI+006NTKO9xgmyowSgPq58AzdXd3t70vWniTAN1q0xgqtqDsxCROmtH5XFfDFioEMbPdV7KXRXi2bebdOdCwazH3MZh0QR99jjdODRWFbGrNq4Eog2n/9puvNDCAjmM0NINecg/H3lJZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2CCz0N6kirv4Y+bKxgrtsTMCCf7h9FVJy0MMlSYiGu8=; b=V2ssBBQLYaczegaAcnkwCLAqnWV1Zecrq6x12M4GdjjPlh70kcy6kLcHQ0ysEDceE9tVMNoE/Gl91niyR5vvQYaSm4mN2tVRK5ZzBx7NERqKzQDr4gyo+cwoz4WykjGkzYIVRiuRouEQ4kZY40O9mo/CItEXna3O2DAlvMs4tRScaQxOAhZhGTsltxBbrcF2BpIu/pyGUDMX9KPQfeNb2+B7EoYyGCz285nhGQmjVzlY+q/OBzhRxDKQmNjQoyU3WgOqXlXLsQPzm+U7pyzXRBvYn2G/EhM1wN2ZvnVE0/ebQ+QcgDfQcTQI/YgsWjpLNbqyLGqwWyZkZCt+2O+9yA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: citrix.com; dkim=none (message not signed) header.d=none;citrix.com; dmarc=none action=none header.from=suse.com; Subject: Re: vcpu_show_execution_state() difference between Arm and x86 To: Julien Grall Cc: "xen-devel@lists.xenproject.org" , Stefano Stabellini , Andrew Cooper References: <85dc06ff-04df-2148-81c5-26bd25d1142f@suse.com> <8f295eeb-e8f2-a115-3f83-60922d0fe5f9@xen.org> From: Jan Beulich Message-ID: <00457189-6ab5-24e4-b2ec-1050ebec67eb@suse.com> Date: Thu, 2 Sep 2021 08:45:30 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: <8f295eeb-e8f2-a115-3f83-60922d0fe5f9@xen.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PR3P191CA0008.EURP191.PROD.OUTLOOK.COM (2603:10a6:102:54::13) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: beabf8b4-90eb-4380-3141-08d96ddd42ee X-MS-TrafficTypeDiagnostic: VI1PR0401MB2605: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5kw6HmKoGN55MLGtfyJSgIArVfzD0Dkhyz0+32QQq1+wm2S4qH7jOP6QUeY3oNdUNV+ksmO5ME0HARfG2UfixAypqfAdWpaDFShCr1ubs6SFjMX6DMLXmar+xtRyMkg2agggZTNFFxPAhDz/MjygNJsYTDs8tlc6PCgn6A/V/PVRTWSQQffOCKt0iDFc+UEgW8jL1CImUGVDtFT6GTJP90Gd/0gzvrbRgTqkZC2Zs/tIzb0xyObd8K8vuY0OaAkdA9A3DsFekNmoBF+U9wuDwS4504cnGONDZ+5lCEuNM5vDx9C0bu3jKD6gG68EoMwTdJxGVB1CYYEE7QxI4sCttlybEZ9ISJYTLwLTCrM+Tg8N9vLmerM989y/UIKxyrJ/rPKHamU8wqnE6KsUDlsoqbrrA+3R/eQu81LhzvofTVSTnIDTCeLgwqSFEF9SiBoWCP7TNQtjzzRXmMTlejJXyzATMYO7/h9pgXp1N7SU3LyNF8euTzzK69hvIuaLuqHpif6T0CcL/QCM65ZoffMCLl1ucnMdWS3e8xLs+FygMWxUDVHE0U1vjxDeX8o5bPmcOW6iW25AVtPxld4AOI0vRDQJUSQzHvzpph75B4wSPD7wmyHqmI4jwYvGcYpiJOy/1v0m4Voa/7hD+Y3+A0/vdIBHCNjfvNqjQWzeLHjtX2eg4sQLd4rpldTjPrBgsU2+jiD/6hv3fCMR7GiAZqEGSqqH7gzmy0paeiiYfk6vJ5M= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(136003)(39860400002)(376002)(346002)(396003)(366004)(38100700002)(2616005)(2906002)(956004)(16576012)(8936002)(8676002)(316002)(86362001)(6486002)(66946007)(478600001)(26005)(54906003)(6916009)(31686004)(5660300002)(4326008)(31696002)(36756003)(83380400001)(66556008)(53546011)(66476007)(186003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VHcvOElJczAwNUloQnIwQkZqZXBLaGVMMUJnTDVVeVBia2FBME1wM3dtVENM?= =?utf-8?B?VU9XZG1WajdKMU1wUlB2eEI1VWN6T3h3Y05DeG5EckUzejBZaUlMc3ZYRkNY?= =?utf-8?B?Y2hNWlhoOWxVeHJ1NjcxVzRnSGVjUW1zajhSbUd4UFJyNm1pRWVBTjUwUXFt?= =?utf-8?B?azdJK3lQQTdqL25vb28rSVVRTzFWM2laMDl1MWRkVGFjQWlmSE1jaXVocFhr?= =?utf-8?B?c09ua3QvUTIxNUdKK3J4djFNNDl1V05aSWZnTDJTTExTSjIxSU50elp6czlM?= =?utf-8?B?UUhiUXNpZlBzRkFLYjUzekxkZzRkbWxKSE1OL21NTjRYR054bXJ4b1kwQVoz?= =?utf-8?B?VE5ESXl5RTlaclNUN2I4cGpjZGk1UE9laTkvQWdTWlQ4WW5PMjdUUTdnd20y?= =?utf-8?B?NnNUMzcxNGxlSnpicFo5a2x2T3ZYTTRsWEQzMklyREJldGdGVWtXSXB2bDM3?= =?utf-8?B?RjNGUmg5MTlrczJiRUh2VzE5RGlrWllLRzhjYkpiZ3FuWVdKdHNTMVl0dk94?= =?utf-8?B?TzFpNElKdDdTNXBudGF3UmZGOFhiZVpJaXhSUjI3Z2xMQUNUcnFlZkN2czNL?= =?utf-8?B?d2JLaFA4WHhGL0JqMEIvVzh6ZkpwZlB1Y2hzbWpma1VRam1Pc292dDZGODJG?= =?utf-8?B?bE1uNVp0Vm56eStoVzZPZHkzWHR1d0tjRDFyaDB4NlRoT2xWWUY3ZG5EQkI2?= =?utf-8?B?YXRFY2lRUWVGQ2VnaVJheVZ0VXY1em9KaWV1VVZhSkhQWnJaeXAwNXo3R2lz?= =?utf-8?B?WXYxT3FoTUFsNHM5cWl6dTk1dlNlczVMMVFzTWE4ZTRPT3kxdGc1MzllRjk3?= =?utf-8?B?Wm9uTmt5VERZZisxMzlVWWRINXN6Yi8rd3pjMFVlSUdZVVVXUURYTk4rL2Nw?= =?utf-8?B?bEpSeHpJbGlqei9yZEhNTkovUm8vUXcvcWJvOGVtTFAwN2xhd2lDRWdKVHBD?= =?utf-8?B?QWEyY3Vzc0lVbTN2WDVzdFRpQ01sakNjeWVvNmZuU0ROWVlleEZLMDZINWNZ?= =?utf-8?B?ZUp1eFlzMDM3ZEZXYk1YdVB1bGpON2hSMzVMUzlQd1VJT3N3QnFKaTljNGMw?= =?utf-8?B?Z29ZVkVqZ2M0ekpKTXYxOEEwamErS3ZjS01hQVRkcFZ6eFR0QXVKTWthalpU?= =?utf-8?B?V0lDVjNJbUxuZEM5YmxLTGFldDQzQlBYOFVWU1lJcHQ1dEk3U0FYOUxob0lW?= =?utf-8?B?aWRCWHVGL0xFTGEyUmJ1STdjRlU0azlickZPRHNTRldqWElHcktjcTZ6WW1v?= =?utf-8?B?bldDNzRadENZdjZhenNPVUxQVkIwelJkZi9WeGpldHpUZnI1eG1uODdud0pL?= =?utf-8?B?dEMvWHpsTm8wRVRJNit5bzZSSm9UdEFDTkxpWnZJVWprdmI1b240dEEzenJt?= =?utf-8?B?a2JldVViUzdhNStlb0ZURUcxUFdCb3IrTTNsOU5HRTBjdjJXNWYzZ3h2V1BX?= =?utf-8?B?Um41Y082d2Z2UUo5alg3VklvTTArSjlaZTZoTmNQa2c2THk5UUtlTnIzZU1y?= =?utf-8?B?WTdCOGdueWZ5QTFkRUZha3NlNmh0cHBGUlVSZjREdEM3QzNBcW1ZMXF3ZFRn?= =?utf-8?B?d2dZcG1hbW16R2V5UzBBTUxZZVNCT3l6NXBkSWlYQ0puTGpLb2RWZVEvZWMv?= =?utf-8?B?MnVlc2JyQ3J5a1pvc29CWjhMalRxZTh6YjBpRHFabFpJM1k0cWdMSjBIR3BE?= =?utf-8?B?b1RHL04rZ1pHL2thUHloaiswZzl2U0Q5dFZvdVdaRlU2YTYyTDhXUjBVK3pa?= =?utf-8?Q?yp1WMIhrspLz9ctZusv0t5t3JRjoJaxlbmSjMW7?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: beabf8b4-90eb-4380-3141-08d96ddd42ee X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Sep 2021 06:45:32.8741 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Gl4/yAgtASFgtNl/BHKi+5WXBNQJdo/OoSMDPMiceH7TsA+mLTlBsaod3HREugOFphk8+QlUhBRUasraB3p9Lg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2605 On 01.09.2021 20:11, Julien Grall wrote: > On 01/09/2021 14:39, Jan Beulich wrote: >> back in 2016 Andrew added code to x86'es variant to avoid interleaving >> of output. The same issue ought to exist on Arm. > > Agree. I guess we got away so far because it is pretty rare to have two > CPUs running at the same. I guess you've meant "crashing", not "running"? >> The lock acquired, >> or more importantly the turning off of IRQs while doing so, is now >> getting in the way of having PVH Dom0's state dumped the 2nd time. > > I am not quite too sure to understand the problem with PVH dom0. Do you > have a pointer to the issue? Locking in both cases: For registers it was VMX'es vmx_vmcs_enter() acquiring a (non-IRQ-safe) lock, and for the stack it is the P2M lock. Neither can / should sensibly be made IRQ-safe. >> For >> register state I did find a sufficiently simple (yet not pretty) >> workaround. For the stack, where I can't reasonably avoid using p2m >> functions, this is going to be more difficult. > >> Since I expect Arm to want to also have interleave protection at some >> point, and since Arm also acquires the p2m lock while accessing Dom0's >> stacks, I wonder whether anyone has any clever idea on how to avoid >> the (valid) triggering of check_lock()'s assertion without intrusive >> changes. (As to intrusive changes - acquiring the p2m lock up front in >> recursive mode, plus silencing check_lock() for nested acquires of a >> lock that's already being held by a CPU was my initial idea.) > > At least one Arm, the P2M lock is a rwlock which is not yet recursive. Right; the same is tru on x86. Hence the expected intrusiveness. > But then it feels to me that this solution is only going to cause us > more trouble in the future. Same here - we'd need to be very careful not only when making such a change, but also going forward. Hence my desire to come up with a better approach. > I looked at the original commit to find out the reason to use the > console lock. AFAICT, this was to allow console_force_unlock() to work > properly. But it is not entirely clear why we couldn't get a new lock > (with IRQ enabled) that could be forced unlocked in that function. > > Can either you or Andrew clarify it? AIUI any new lock would need to be IRQ-safe as well, as the lock would be on paths taken to output stuff when the system crashed. Hence it would be pointless to introduce yet another lock when the one we have is already good enough. But I may be missing aspects, in which case I'd have to defer to Andrew. > The other solution I can think off is buffering the output for > show_registers and only print it once at the end. The downside is we may > not get any output if there is an issue in the middle of the dump. Indeed; I'd prefer to avoid that, the more that it may be hard to predict how much output there's going to be. Jan From xen-devel-bounces@lists.xenproject.org Thu Sep 02 06:50:59 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 06:50:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.176921.322112 (Exim 4.92) (envelope-from ) id 1mLgYs-0005Po-JV; Thu, 02 Sep 2021 06:50:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 176921.322112; Thu, 02 Sep 2021 06:50:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLgYs-0005LP-69; Thu, 02 Sep 2021 06:50:58 +0000 Received: by outflank-mailman (input) for mailman id 176921; Thu, 02 Sep 2021 06:07:16 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLfsa-0004fO-NW for xen-devel@lists.xenproject.org; Thu, 02 Sep 2021 06:07:16 +0000 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (unknown [40.107.101.78]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 68a4c72f-d06d-41dc-b586-46d6db34e47a; Thu, 02 Sep 2021 06:07:13 +0000 (UTC) Received: from SA0PR11CA0205.namprd11.prod.outlook.com (2603:10b6:806:1bc::30) by DM6PR02MB4955.namprd02.prod.outlook.com (2603:10b6:5:11::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.23; Thu, 2 Sep 2021 06:07:11 +0000 Received: from SN1NAM02FT0051.eop-nam02.prod.protection.outlook.com (2603:10b6:806:1bc:cafe::14) by SA0PR11CA0205.outlook.office365.com (2603:10b6:806:1bc::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.20 via Frontend Transport; Thu, 2 Sep 2021 06:07:11 +0000 Received: from xsj-pvapexch02.xlnx.xilinx.com (149.199.62.198) by SN1NAM02FT0051.mail.protection.outlook.com (10.97.5.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.4478.19 via Frontend Transport; Thu, 2 Sep 2021 06:07:11 +0000 Received: from xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Wed, 1 Sep 2021 23:06:58 -0700 Received: from smtp.xilinx.com (172.19.127.96) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Wed, 1 Sep 2021 23:06:58 -0700 Received: from [172.19.2.115] (port=56596 helo=xsjfnuv50.xilinx.com) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1mLfsI-000F6q-7C; Wed, 01 Sep 2021 23:06:58 -0700 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 68a4c72f-d06d-41dc-b586-46d6db34e47a ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dTzketYN7Sz9QYVI5TRbaykYekb6lQdCGNL14wDwjJbJvkqKNVRJCetHXBYkG+hsmyd2Ec8byYIh61Gtd2EfhNv6hb1OZQmxvAJFlVSjrJZkajCzIt1gklA0SW5eD820aD3fY4CFtvmf0mHa94SgyWefsoiIGE2omU+sX7X4WRAdIDIj37C6YiSZNFG4wRBfqpdnLOqg8LqpIaElCJoPa4kc5jt69+btV+7MVARN50Zx3Vu9rB8/QzHdYkNWb1GzlmiZqCF5xKw4iScINXD4X6ROBD6N+iyo4cEObCCVMxtuUlz2qPvNKTSiqusuDCEyPbJEKHNJd6j+Xn2+B36tjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=odPD3Pqm1GqjPKTu4SCQEahFowuxrRf5d2NDi//Xqhc=; b=b7t7Q08EDV9jbIAi9YacfuBNdYe5UT9DpmdR6zksyt/pmhLaGS2kRte8K2x4uJaEm1NWO9Op5HQKZ91pulo2xbQKc2MWcAy0iyGt0rNlJOvfWNZ1gfqN+kcnNhhAQx8niMQQNIUPx8MelvpDp/Fd3bftwrhxpk4quWX3He2RBQ5nXzbYfFQFv9e0fJitZRMvba7N4Y3o7tz2NiL25fwOOuTTo05iHtxSl4xZmQlB3eZTdGSssp9UAawVn9G00bkhmYYy9U/CihHVRADRV0qxkhHQEixrShWiwoU8Yqm8S+8kOvxPM8/FNRzvu7pMOFbq6E8hdCZ68Zl+zjWVxdZn7A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.62.198) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=odPD3Pqm1GqjPKTu4SCQEahFowuxrRf5d2NDi//Xqhc=; b=ptPq88z/q1iJFHOMrdxAUhpYrrVwcYiB+PwZY66JsKYHwoqXy9IQ133PTfzXon9J80oEQU/sriailXFqa2EXkeJeejxPwYvTGTU1IemAuXExyfpRgWL+DL4VVKHZNNKqgRhkx+94la5pgFnFq/6i2nBjTrj/mRXo0cPoqY1nW4w= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.62.198) smtp.mailfrom=xilinx.com; lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.62.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.62.198; helo=xsj-pvapexch02.xlnx.xilinx.com; From: Vikram Garhwal To: CC: , , Vikram Garhwal Subject: [XEN][RFC PATCH 04/13] libfdt: Copy required libfdt functions from Linux Date: Wed, 1 Sep 2021 23:05:54 -0700 Message-ID: <1630562763-390068-5-git-send-email-fnu.vikram@xilinx.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1630562763-390068-1-git-send-email-fnu.vikram@xilinx.com> References: <1630562763-390068-1-git-send-email-fnu.vikram@xilinx.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8327c211-e114-4ee9-c4a0-08d96dd7e711 X-MS-TrafficTypeDiagnostic: DM6PR02MB4955: X-Microsoft-Antispam-PRVS: X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: cnMudUiEYwg/DRZQQkVkoNMDqoPlKtpzwpPFJo7zR8JLQKmfQrcYbRsNCvbg5qnJkg+uaCcQwgsriP26Jxf2LXmVRuAYzfbj4Z/29wGNs0lLrQyqoJ+5zzUa693okFFhTgRSmPx3BmfeU14ssAhxNHLtwAzZyG5vLj5xVkiT3SyLaH5Zdhy5V6u+uni9bxXwxgR2RxqhgooqPAjciVrZGBSemg0bOlZyncSpCBfICq5SaIGN9WMJI+Z/GlWCQAgjK4Az3DcemyaqG9+vmIaQdWj4+crR+/P62B8QW58x9pCy2yuyFR647M43LHE6xXMwJDuf306VPsCITNoSYfD1UPK4Tv8wifiCrwDMkIgpVtR6IDJ5W4MOviwPdbQrjRwXOCmm4yWKqRVaZwjt2xGhaqRx2fL1IPLggcodKjr1nUN4IlsvdXPRtHXWubnPufa2NBth9VoYgZfKV/ccIqfqL1xhCePueVMrFBlc3G/EERsFKIqjS0JKygrwHqDCu17zmug8CRjf1/28MPDeO91F9bbAfPgQNxdiXH4yrCUveMJRy9KRCDuwEDd8bh1z+TJfrBsFm5i35botvPmsX3jLVxv7a4EjPNr1YQU1/5TkRbj7HmOOpgh6Ivmu6xQam2X7fAIBmCSUrTmj8S5YbyvBH1ZE5jYHC1gmojKwzCKjy4MB7jkNKU2xVGSKnYnpNIGk551FBZi2fpc28QysuVyu1qmgVEiKnhr11zBwZMf4euM= X-Forefront-Antispam-Report: CIP:149.199.62.198;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:xsj-pvapexch02.xlnx.xilinx.com;PTR:unknown-62-198.xilinx.com;CAT:NONE;SFS:(4636009)(39860400002)(136003)(346002)(396003)(376002)(36840700001)(46966006)(47076005)(426003)(186003)(36756003)(107886003)(6666004)(8676002)(2616005)(7636003)(2906002)(70586007)(6916009)(70206006)(82310400003)(83380400001)(82740400003)(26005)(36906005)(336012)(356005)(316002)(478600001)(5660300002)(7696005)(4326008)(9786002)(54906003)(36860700001)(30864003)(8936002)(102446001);DIR:OUT;SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Sep 2021 06:07:11.0913 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8327c211-e114-4ee9-c4a0-08d96dd7e711 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.62.198];Helo=[xsj-pvapexch02.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: SN1NAM02FT0051.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR02MB4955 fdt_overlay.c uses a number of functions. Below is the list of functions copied from Linux tree(commid: 6e9c9686d826564f44c93cdd6f111b1c0a9dc224) to compile the fdt_overlay.c(): libfdt_internal.h: FDT_RO_PROBE() and can_assume(). libfdt.h: fdt_for_each_subnode(), fdt_get_max_phandle(), fdt_for_each_property_offset() and fdt_getprop_namelen_w(). fdt.c: fdt_ro_probe_(). fdt_ro.c: fdt_find_max_phandle(), fdt_path_offset_namelen() and fdt_path_offset(). fdt_rw.c: fdt_rw_probe_(), FDT_RW_PROBE(), fdt_del_last_string_(), fdt_setprop_placeholder() and fdt_setprop(). fdt_wip.c: fdt_setprop_inplace_namelen_partial(). Updated fdt_rw.c: _fdt_find_add_string() with required changes from Linux fdt_rw.c:fdt_find_add_string_(). Updated fdt_rw.c: _fdt_add_property() with required changes from Linux fdt_rw.c:fdt_find_add_string_(). Replaced strtoul() with simple_strtoull(). Signed-off-by: Vikram Garhwal --- xen/common/libfdt/Makefile.libfdt | 2 +- xen/common/libfdt/fdt.c | 35 ++++++ xen/common/libfdt/fdt_overlay.c | 6 +- xen/common/libfdt/fdt_ro.c | 52 ++++++-- xen/common/libfdt/fdt_rw.c | 81 +++++++++++-- xen/common/libfdt/fdt_wip.c | 20 ++++ xen/common/libfdt/libfdt_internal.h | 130 ++++++++++++++++++++ xen/include/xen/libfdt/libfdt.h | 230 +++++++++++++++++++++++++++++++++++- 8 files changed, 536 insertions(+), 20 deletions(-) diff --git a/xen/common/libfdt/Makefile.libfdt b/xen/common/libfdt/Makefile.libfdt index 91126c0..aea9d9b 100644 --- a/xen/common/libfdt/Makefile.libfdt +++ b/xen/common/libfdt/Makefile.libfdt @@ -6,5 +6,5 @@ LIBFDT_soname = libfdt.$(SHAREDLIB_EXT).1 LIBFDT_INCLUDES = fdt.h libfdt.h libfdt_env.h LIBFDT_VERSION = version.lds -LIBFDT_SRCS = fdt.c fdt_ro.c fdt_wip.c fdt_sw.c fdt_rw.c fdt_strerror.c fdt_empty_tree.c +LIBFDT_SRCS = fdt.c fdt_ro.c fdt_wip.c fdt_sw.c fdt_rw.c fdt_strerror.c fdt_empty_tree.c fdt_overlay.c LIBFDT_OBJS = $(LIBFDT_SRCS:%.c=%.o) diff --git a/xen/common/libfdt/fdt.c b/xen/common/libfdt/fdt.c index bbc7717..55a9de6 100644 --- a/xen/common/libfdt/fdt.c +++ b/xen/common/libfdt/fdt.c @@ -53,6 +53,41 @@ #include "libfdt_internal.h" +/* + * Minimal sanity check for a read-only tree. fdt_ro_probe_() checks + * that the given buffer contains what appears to be a flattened + * device tree with sane information in its header. + */ +int32_t fdt_ro_probe_(const void *fdt) +{ + uint32_t totalsize = fdt_totalsize(fdt); + + if (can_assume(VALID_DTB)) + return totalsize; + + if (fdt_magic(fdt) == FDT_MAGIC) { + /* Complete tree */ + if (!can_assume(LATEST)) { + if (fdt_version(fdt) < FDT_FIRST_SUPPORTED_VERSION) + return -FDT_ERR_BADVERSION; + if (fdt_last_comp_version(fdt) > + FDT_LAST_SUPPORTED_VERSION) + return -FDT_ERR_BADVERSION; + } + } else if (fdt_magic(fdt) == FDT_SW_MAGIC) { + /* Unfinished sequential-write blob */ + if (!can_assume(VALID_INPUT) && fdt_size_dt_struct(fdt) == 0) + return -FDT_ERR_BADSTATE; + } else { + return -FDT_ERR_BADMAGIC; + } + + if (totalsize < INT32_MAX) + return totalsize; + else + return -FDT_ERR_TRUNCATED; +} + int fdt_check_header(const void *fdt) { if (fdt_magic(fdt) == FDT_MAGIC) { diff --git a/xen/common/libfdt/fdt_overlay.c b/xen/common/libfdt/fdt_overlay.c index d217e79..15a8cdb 100644 --- a/xen/common/libfdt/fdt_overlay.c +++ b/xen/common/libfdt/fdt_overlay.c @@ -9,6 +9,7 @@ #include #include +#include #include "libfdt_internal.h" /** @@ -446,7 +447,8 @@ static int overlay_fixup_phandle(void *fdt, void *fdto, int symbols_off, const char *fixup_str = value; uint32_t path_len, name_len; uint32_t fixup_len; - char *sep, *endptr; + char *sep; + const char *endptr; int poffset, ret; fixup_end = memchr(value, '\0', len); @@ -476,7 +478,7 @@ static int overlay_fixup_phandle(void *fdt, void *fdto, int symbols_off, if (!name_len) return -FDT_ERR_BADOVERLAY; - poffset = strtoul(sep + 1, &endptr, 10); + poffset = simple_strtoull(sep + 1, &endptr, 10); if ((*endptr != '\0') || (endptr <= (sep + 1))) return -FDT_ERR_BADOVERLAY; diff --git a/xen/common/libfdt/fdt_ro.c b/xen/common/libfdt/fdt_ro.c index 36f9b48..383791d 100644 --- a/xen/common/libfdt/fdt_ro.c +++ b/xen/common/libfdt/fdt_ro.c @@ -86,6 +86,34 @@ static int _fdt_string_eq(const void *fdt, int stroffset, return (strlen(p) == len) && (memcmp(p, s, len) == 0); } +int fdt_find_max_phandle(const void *fdt, uint32_t *phandle) +{ + uint32_t max = 0; + int offset = -1; + + while (true) { + uint32_t value; + + offset = fdt_next_node(fdt, offset, NULL); + if (offset < 0) { + if (offset == -FDT_ERR_NOTFOUND) + break; + + return offset; + } + + value = fdt_get_phandle(fdt, offset); + + if (value > max) + max = value; + } + + if (phandle) + *phandle = max; + + return 0; +} + int fdt_get_mem_rsv(const void *fdt, int n, uint64_t *address, uint64_t *size) { FDT_CHECK_HEADER(fdt); @@ -152,17 +180,17 @@ int fdt_subnode_offset(const void *fdt, int parentoffset, return fdt_subnode_offset_namelen(fdt, parentoffset, name, strlen(name)); } -int fdt_path_offset(const void *fdt, const char *path) +int fdt_path_offset_namelen(const void *fdt, const char *path, int namelen) { - const char *end = path + strlen(path); + const char *end = path + namelen; const char *p = path; int offset = 0; - FDT_CHECK_HEADER(fdt); + FDT_RO_PROBE(fdt); /* see if we have an alias */ if (*path != '/') { - const char *q = strchr(path, '/'); + const char *q = memchr(path, '/', end - p); if (!q) q = end; @@ -175,14 +203,15 @@ int fdt_path_offset(const void *fdt, const char *path) p = q; } - while (*p) { + while (p < end) { const char *q; - while (*p == '/') + while (*p == '/') { p++; - if (! *p) - return offset; - q = strchr(p, '/'); + if (p == end) + return offset; + } + q = memchr(p, '/', end - p); if (! q) q = end; @@ -196,6 +225,11 @@ int fdt_path_offset(const void *fdt, const char *path) return offset; } +int fdt_path_offset(const void *fdt, const char *path) +{ + return fdt_path_offset_namelen(fdt, path, strlen(path)); +} + const char *fdt_get_name(const void *fdt, int nodeoffset, int *len) { const struct fdt_node_header *nh = _fdt_offset_ptr(fdt, nodeoffset); diff --git a/xen/common/libfdt/fdt_rw.c b/xen/common/libfdt/fdt_rw.c index 8b8cd25..fc53644 100644 --- a/xen/common/libfdt/fdt_rw.c +++ b/xen/common/libfdt/fdt_rw.c @@ -65,6 +65,30 @@ static int _fdt_blocks_misordered(const void *fdt, (fdt_off_dt_strings(fdt) + fdt_size_dt_strings(fdt))); } +static int fdt_rw_probe_(void *fdt) +{ + if (can_assume(VALID_DTB)) + return 0; + FDT_RO_PROBE(fdt); + + if (!can_assume(LATEST) && fdt_version(fdt) < 17) + return -FDT_ERR_BADVERSION; + if (_fdt_blocks_misordered(fdt, sizeof(struct fdt_reserve_entry), + fdt_size_dt_struct(fdt))) + return -FDT_ERR_BADLAYOUT; + if (!can_assume(LATEST) && fdt_version(fdt) > 17) + fdt_set_version(fdt, 17); + + return 0; +} + +#define FDT_RW_PROBE(fdt) \ + { \ + int err_; \ + if ((err_ = fdt_rw_probe_(fdt)) != 0) \ + return err_; \ + } + static int _fdt_rw_check_header(void *fdt) { FDT_CHECK_HEADER(fdt); @@ -133,6 +157,14 @@ static int _fdt_splice_struct(void *fdt, void *p, return 0; } +/* Must only be used to roll back in case of error */ +static void fdt_del_last_string_(void *fdt, const char *s) +{ + int newlen = strlen(s) + 1; + + fdt_set_size_dt_strings(fdt, fdt_size_dt_strings(fdt) - newlen); +} + static int _fdt_splice_string(void *fdt, int newlen) { void *p = (char *)fdt @@ -146,7 +178,16 @@ static int _fdt_splice_string(void *fdt, int newlen) return 0; } -static int _fdt_find_add_string(void *fdt, const char *s) +/** + * New _fdt_find_add_string() - Find or allocate a string + * + * @fdt: pointer to the device tree to check/adjust + * @s: string to find/add + * @allocated: Set to 0 if the string was found, 1 if not found and so + * allocated. Ignored if can_assume(NO_ROLLBACK) + * @return offset of string in the string table (whether found or added) + */ +static int _fdt_find_add_string(void *fdt, const char *s, int *allocated) { char *strtab = (char *)fdt + fdt_off_dt_strings(fdt); const char *p; @@ -154,6 +195,9 @@ static int _fdt_find_add_string(void *fdt, const char *s) int len = strlen(s) + 1; int err; + if (!can_assume(NO_ROLLBACK)) + *allocated = 0; + p = _fdt_find_string(strtab, fdt_size_dt_strings(fdt), s); if (p) /* found it */ @@ -164,6 +208,9 @@ static int _fdt_find_add_string(void *fdt, const char *s) if (err) return err; + if (!can_assume(NO_ROLLBACK)) + *allocated = 1; + memcpy(new, s, len); return (new - strtab); } @@ -226,11 +273,12 @@ static int _fdt_add_property(void *fdt, int nodeoffset, const char *name, int nextoffset; int namestroff; int err; + int allocated; if ((nextoffset = _fdt_check_node_offset(fdt, nodeoffset)) < 0) return nextoffset; - namestroff = _fdt_find_add_string(fdt, name); + namestroff = _fdt_find_add_string(fdt, name, &allocated); if (namestroff < 0) return namestroff; @@ -238,8 +286,12 @@ static int _fdt_add_property(void *fdt, int nodeoffset, const char *name, proplen = sizeof(**prop) + FDT_TAGALIGN(len); err = _fdt_splice_struct(fdt, *prop, 0, proplen); - if (err) + if (err) { + /* Delete the string if we failed to add it */ + if (!can_assume(NO_ROLLBACK) && allocated) + fdt_del_last_string_(fdt, name); return err; + } (*prop)->tag = cpu_to_fdt32(FDT_PROP); (*prop)->nameoff = cpu_to_fdt32(namestroff); @@ -270,13 +322,13 @@ int fdt_set_name(void *fdt, int nodeoffset, const char *name) return 0; } -int fdt_setprop(void *fdt, int nodeoffset, const char *name, - const void *val, int len) +int fdt_setprop_placeholder(void *fdt, int nodeoffset, const char *name, + int len, void **prop_data) { struct fdt_property *prop; int err; - FDT_RW_CHECK_HEADER(fdt); + FDT_RW_PROBE(fdt); err = _fdt_resize_property(fdt, nodeoffset, name, len, &prop); if (err == -FDT_ERR_NOTFOUND) @@ -284,7 +336,22 @@ int fdt_setprop(void *fdt, int nodeoffset, const char *name, if (err) return err; - memcpy(prop->data, val, len); + *prop_data = prop->data; + return 0; +} + +int fdt_setprop(void *fdt, int nodeoffset, const char *name, + const void *val, int len) +{ + void *prop_data; + int err; + + err = fdt_setprop_placeholder(fdt, nodeoffset, name, len, &prop_data); + if (err) + return err; + + if (len) + memcpy(prop_data, val, len); return 0; } diff --git a/xen/common/libfdt/fdt_wip.c b/xen/common/libfdt/fdt_wip.c index 2d1cac0..3f61085 100644 --- a/xen/common/libfdt/fdt_wip.c +++ b/xen/common/libfdt/fdt_wip.c @@ -53,6 +53,26 @@ #include "libfdt_internal.h" +int fdt_setprop_inplace_namelen_partial(void *fdt, int nodeoffset, + const char *name, int namelen, + uint32_t idx, const void *val, + int len) +{ + void *propval; + int proplen; + + propval = fdt_getprop_namelen_w(fdt, nodeoffset, name, namelen, + &proplen); + if (!propval) + return proplen; + + if ((unsigned)proplen < (len + idx)) + return -FDT_ERR_NOSPACE; + + memcpy((char *)propval + idx, val, len); + return 0; +} + int fdt_setprop_inplace(void *fdt, int nodeoffset, const char *name, const void *val, int len) { diff --git a/xen/common/libfdt/libfdt_internal.h b/xen/common/libfdt/libfdt_internal.h index d50c4e1..523bcee 100644 --- a/xen/common/libfdt/libfdt_internal.h +++ b/xen/common/libfdt/libfdt_internal.h @@ -60,6 +60,14 @@ return err; \ } +int32_t fdt_ro_probe_(const void *fdt); +#define FDT_RO_PROBE(fdt) \ + { \ + int32_t totalsize_; \ + if ((totalsize_ = fdt_ro_probe_(fdt)) < 0) \ + return totalsize_; \ + } + int _fdt_check_node_offset(const void *fdt, int offset); int _fdt_check_prop_offset(const void *fdt, int offset); const char *_fdt_find_string(const char *strtab, int tabsize, const char *s); @@ -90,4 +98,126 @@ static inline struct fdt_reserve_entry *_fdt_mem_rsv_w(void *fdt, int n) #define FDT_SW_MAGIC (~FDT_MAGIC) +/**********************************************************************/ +/* Checking controls */ +/**********************************************************************/ + +#ifndef FDT_ASSUME_MASK +#define FDT_ASSUME_MASK 0 +#endif + +/* + * Defines assumptions which can be enabled. Each of these can be enabled + * individually. For maximum safety, don't enable any assumptions! + * + * For minimal code size and no safety, use ASSUME_PERFECT at your own risk. + * You should have another method of validating the device tree, such as a + * signature or hash check before using libfdt. + * + * For situations where security is not a concern it may be safe to enable + * ASSUME_SANE. + */ +enum { + /* + * This does essentially no checks. Only the latest device-tree + * version is correctly handled. Inconsistencies or errors in the device + * tree may cause undefined behaviour or crashes. Invalid parameters + * passed to libfdt may do the same. + * + * If an error occurs when modifying the tree it may leave the tree in + * an intermediate (but valid) state. As an example, adding a property + * where there is insufficient space may result in the property name + * being added to the string table even though the property itself is + * not added to the struct section. + * + * Only use this if you have a fully validated device tree with + * the latest supported version and wish to minimise code size. + */ + ASSUME_PERFECT = 0xff, + + /* + * This assumes that the device tree is sane. i.e. header metadata + * and basic hierarchy are correct. + * + * With this assumption enabled, normal device trees produced by libfdt + * and the compiler should be handled safely. Malicious device trees and + * complete garbage may cause libfdt to behave badly or crash. Truncated + * device trees (e.g. those only partially loaded) can also cause + * problems. + * + * Note: Only checks that relate exclusively to the device tree itself + * (not the parameters passed to libfdt) are disabled by this + * assumption. This includes checking headers, tags and the like. + */ + ASSUME_VALID_DTB = 1 << 0, + + /* + * This builds on ASSUME_VALID_DTB and further assumes that libfdt + * functions are called with valid parameters, i.e. not trigger + * FDT_ERR_BADOFFSET or offsets that are out of bounds. It disables any + * extensive checking of parameters and the device tree, making various + * assumptions about correctness. + * + * It doesn't make sense to enable this assumption unless + * ASSUME_VALID_DTB is also enabled. + */ + ASSUME_VALID_INPUT = 1 << 1, + + /* + * This disables checks for device-tree version and removes all code + * which handles older versions. + * + * Only enable this if you know you have a device tree with the latest + * version. + */ + ASSUME_LATEST = 1 << 2, + + /* + * This assumes that it is OK for a failed addition to the device tree, + * due to lack of space or some other problem, to skip any rollback + * steps (such as dropping the property name from the string table). + * This is safe to enable in most circumstances, even though it may + * leave the tree in a sub-optimal state. + */ + ASSUME_NO_ROLLBACK = 1 << 3, + + /* + * This assumes that the device tree components appear in a 'convenient' + * order, i.e. the memory reservation block first, then the structure + * block and finally the string block. + * + * This order is not specified by the device-tree specification, + * but is expected by libfdt. The device-tree compiler always created + * device trees with this order. + * + * This assumption disables a check in fdt_open_into() and removes the + * ability to fix the problem there. This is safe if you know that the + * device tree is correctly ordered. See fdt_blocks_misordered_(). + */ + ASSUME_LIBFDT_ORDER = 1 << 4, + + /* + * This assumes that libfdt itself does not have any internal bugs. It + * drops certain checks that should never be needed unless libfdt has an + * undiscovered bug. + * + * This can generally be considered safe to enable. + */ + ASSUME_LIBFDT_FLAWLESS = 1 << 5, +}; + +/** + * can_assume_() - check if a particular assumption is enabled + * + * @mask: Mask to check (ASSUME_...) + * @return true if that assumption is enabled, else false + */ +static inline bool can_assume_(int mask) +{ + return FDT_ASSUME_MASK & mask; +} + +/** helper macros for checking assumptions */ +#define can_assume(_assume) can_assume_(ASSUME_ ## _assume) + #endif /* _LIBFDT_INTERNAL_H */ diff --git a/xen/include/xen/libfdt/libfdt.h b/xen/include/xen/libfdt/libfdt.h index 7c75688..b6c8b67 100644 --- a/xen/include/xen/libfdt/libfdt.h +++ b/xen/include/xen/libfdt/libfdt.h @@ -114,7 +114,30 @@ * Should never be returned, if it is, it indicates a bug in * libfdt itself. */ -#define FDT_ERR_MAX 13 +/* Errors in device tree content */ +#define FDT_ERR_BADNCELLS 14 + /* FDT_ERR_BADNCELLS: Device tree has a #address-cells, #size-cells + * or similar property with a bad format or value */ + +#define FDT_ERR_BADVALUE 15 + /* FDT_ERR_BADVALUE: Device tree has a property with an unexpected + * value. For example: a property expected to contain a string list + * is not NUL-terminated within the length of its value. */ + +#define FDT_ERR_BADOVERLAY 16 + /* FDT_ERR_BADOVERLAY: The device tree overlay, while + * correctly structured, cannot be applied due to some + * unexpected or missing value, property or node. */ + +#define FDT_ERR_NOPHANDLES 17 + /* FDT_ERR_NOPHANDLES: The device tree doesn't have any + * phandle available anymore without causing an overflow */ + +#define FDT_ERR_BADFLAGS 18 + /* FDT_ERR_BADFLAGS: The function was passed a flags field that + * contains invalid flags or an invalid combination of flags. */ + +#define FDT_ERR_MAX 18 /**********************************************************************/ /* Low-level functions (you probably don't need these) */ @@ -156,6 +179,33 @@ int fdt_first_subnode(const void *fdt, int offset); */ int fdt_next_subnode(const void *fdt, int offset); +/** + * fdt_for_each_subnode - iterate over all subnodes of a parent + * + * @node: child node (int, lvalue) + * @fdt: FDT blob (const void *) + * @parent: parent node (int) + * + * This is actually a wrapper around a for loop and would be used like so: + * + * fdt_for_each_subnode(node, fdt, parent) { + * Use node + * ... + * } + * + * if ((node < 0) && (node != -FDT_ERR_NOTFOUND)) { + * Error handling + * } + * + * Note that this is implemented as a macro and @node is used as + * iterator in the loop. The parent variable be constant or even a + * literal. + */ +#define fdt_for_each_subnode(node, fdt, parent) \ + for (node = fdt_first_subnode(fdt, parent); \ + node >= 0; \ + node = fdt_next_subnode(fdt, node)) + /**********************************************************************/ /* General functions */ /**********************************************************************/ @@ -247,6 +297,47 @@ int fdt_move(const void *fdt, void *buf, int bufsize); const char *fdt_string(const void *fdt, int stroffset); /** + * fdt_find_max_phandle - find and return the highest phandle in a tree + * @fdt: pointer to the device tree blob + * @phandle: return location for the highest phandle value found in the tree + * + * fdt_find_max_phandle() finds the highest phandle value in the given device + * tree. The value returned in @phandle is only valid if the function returns + * success. + * + * returns: + * 0 on success or a negative error code on failure + */ +int fdt_find_max_phandle(const void *fdt, uint32_t *phandle); + +/** + * fdt_get_max_phandle - retrieves the highest phandle in a tree + * @fdt: pointer to the device tree blob + * + * fdt_get_max_phandle retrieves the highest phandle in the given + * device tree. This will ignore badly formatted phandles, or phandles + * with a value of 0 or -1. + * + * This function is deprecated in favour of fdt_find_max_phandle(). + * + * returns: + * the highest phandle on success + * 0, if no phandle was found in the device tree + * -1, if an error occurred + */ +static inline uint32_t fdt_get_max_phandle(const void *fdt) +{ + uint32_t phandle; + int err; + + err = fdt_find_max_phandle(fdt, &phandle); + if (err < 0) + return (uint32_t)-1; + + return phandle; +} + +/** * fdt_num_mem_rsv - retrieve the number of memory reserve map entries * @fdt: pointer to the device tree blob * @@ -316,6 +407,21 @@ int fdt_subnode_offset_namelen(const void *fdt, int parentoffset, int fdt_subnode_offset(const void *fdt, int parentoffset, const char *name); /** + * fdt_path_offset_namelen - find a tree node by its full path + * @fdt: pointer to the device tree blob + * @path: full path of the node to locate + * @namelen: number of characters of path to consider + * + * Identical to fdt_path_offset(), but only consider the first namelen + * characters of path as the path name. + * + * Return: offset of the node or negative libfdt error value otherwise + */ +#ifndef SWIG /* Not available in Python */ +int fdt_path_offset_namelen(const void *fdt, const char *path, int namelen); +#endif + +/** * fdt_path_offset - find a tree node by its full path * @fdt: pointer to the device tree blob * @path: full path of the node to locate @@ -404,6 +510,33 @@ int fdt_first_property_offset(const void *fdt, int nodeoffset); int fdt_next_property_offset(const void *fdt, int offset); /** + * fdt_for_each_property_offset - iterate over all properties of a node + * + * @property: property offset (int, lvalue) + * @fdt: FDT blob (const void *) + * @node: node offset (int) + * + * This is actually a wrapper around a for loop and would be used like so: + * + * fdt_for_each_property_offset(property, fdt, node) { + * Use property + * ... + * } + * + * if ((property < 0) && (property != -FDT_ERR_NOTFOUND)) { + * Error handling + * } + * + * Note that this is implemented as a macro and property is used as + * iterator in the loop. The node variable can be constant or even a + * literal. + */ +#define fdt_for_each_property_offset(property, fdt, node) \ + for (property = fdt_first_property_offset(fdt, node); \ + property >= 0; \ + property = fdt_next_property_offset(fdt, property)) + +/** * fdt_get_property_by_offset - retrieve the property at a given offset * @fdt: pointer to the device tree blob * @offset: offset of the property to retrieve @@ -532,6 +665,14 @@ const void *fdt_getprop_by_offset(const void *fdt, int offset, const void *fdt_getprop_namelen(const void *fdt, int nodeoffset, const char *name, int namelen, int *lenp); +static inline void *fdt_getprop_namelen_w(void *fdt, int nodeoffset, + const char *name, int namelen, + int *lenp) +{ + return (void *)(uintptr_t)fdt_getprop_namelen(fdt, nodeoffset, name, + namelen, lenp); +} + /** * fdt_getprop - retrieve the value of a given property * @fdt: pointer to the device tree blob @@ -993,6 +1134,31 @@ static inline int fdt_setprop_inplace_cell(void *fdt, int nodeoffset, int fdt_nop_property(void *fdt, int nodeoffset, const char *name); /** + * fdt_setprop_inplace_namelen_partial - change a property's value, + * but not its size + * @fdt: pointer to the device tree blob + * @nodeoffset: offset of the node whose property to change + * @name: name of the property to change + * @namelen: number of characters of name to consider + * @idx: index of the property to change in the array + * @val: pointer to data to replace the property value with + * @len: length of the property value + * + * Identical to fdt_setprop_inplace(), but modifies the given property + * starting from the given index, and using only the first characters + * of the name. It is useful when you want to manipulate only one value of + * an array and you have a string that doesn't end with \0. + * + * Return: 0 on success, negative libfdt error value otherwise + */ +#ifndef SWIG /* Not available in Python */ +int fdt_setprop_inplace_namelen_partial(void *fdt, int nodeoffset, + const char *name, int namelen, + uint32_t idx, const void *val, + int len); +#endif + +/** * fdt_nop_node - replace a node (subtree) with nop tags * @fdt: pointer to the device tree blob * @nodeoffset: offset of the node to nop @@ -1158,6 +1324,37 @@ int fdt_setprop(void *fdt, int nodeoffset, const char *name, const void *val, int len); /** + * fdt_setprop_placeholder - allocate space for a property + * @fdt: pointer to the device tree blob + * @nodeoffset: offset of the node whose property to change + * @name: name of the property to change + * @len: length of the property value + * @prop_data: return pointer to property data + * + * fdt_setprop_placeholer() allocates the named property in the given node. + * If the property exists it is resized. In either case a pointer to the + * property data is returned. + * + * This function may insert or delete data from the blob, and will + * therefore change the offsets of some existing nodes. + * + * returns: + * 0, on success + * -FDT_ERR_NOSPACE, there is insufficient free space in the blob to + * contain the new property value + * -FDT_ERR_BADOFFSET, nodeoffset did not point to FDT_BEGIN_NODE tag + * -FDT_ERR_BADLAYOUT, + * -FDT_ERR_BADMAGIC, + * -FDT_ERR_BADVERSION, + * -FDT_ERR_BADSTATE, + * -FDT_ERR_BADSTRUCTURE, + * -FDT_ERR_BADLAYOUT, + * -FDT_ERR_TRUNCATED, standard meanings + */ +int fdt_setprop_placeholder(void *fdt, int nodeoffset, const char *name, + int len, void **prop_data); + +/** * fdt_setprop_u32 - set a property to a 32-bit integer * @fdt: pointer to the device tree blob * @nodeoffset: offset of the node whose property to change @@ -1503,6 +1700,37 @@ int fdt_add_subnode(void *fdt, int parentoffset, const char *name); */ int fdt_del_node(void *fdt, int nodeoffset); +/** + * fdt_overlay_apply - Applies a DT overlay on a base DT + * @fdt: pointer to the base device tree blob + * @fdto: pointer to the device tree overlay blob + * + * fdt_overlay_apply() will apply the given device tree overlay on the + * given base device tree. + * + * Expect the base device tree to be modified, even if the function + * returns an error. + * + * returns: + * 0, on success + * -FDT_ERR_NOSPACE, there's not enough space in the base device tree + * -FDT_ERR_NOTFOUND, the overlay points to some inexistant nodes or + * properties in the base DT + * -FDT_ERR_BADPHANDLE, + * -FDT_ERR_BADOVERLAY, + * -FDT_ERR_NOPHANDLES, + * -FDT_ERR_INTERNAL, + * -FDT_ERR_BADLAYOUT, + * -FDT_ERR_BADMAGIC, + * -FDT_ERR_BADOFFSET, + * -FDT_ERR_BADPATH, + * -FDT_ERR_BADVERSION, + * -FDT_ERR_BADSTRUCTURE, + * -FDT_ERR_BADSTATE, + * -FDT_ERR_TRUNCATED, standard meanings + */ +int fdt_overlay_apply(void *fdt, void *fdto); + /**********************************************************************/ /* Debugging / informational functions */ /**********************************************************************/ -- 2.7.4 From xen-devel-bounces@lists.xenproject.org Thu Sep 02 06:50:59 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 06:50:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.176912.322080 (Exim 4.92) (envelope-from ) id 1mLgYq-0004la-JG; Thu, 02 Sep 2021 06:50:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 176912.322080; Thu, 02 Sep 2021 06:50:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLgYq-0004l5-DG; Thu, 02 Sep 2021 06:50:56 +0000 Received: by outflank-mailman (input) for mailman id 176912; Thu, 02 Sep 2021 06:07:04 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLfsO-0004aE-Nu for xen-devel@lists.xenproject.org; Thu, 02 Sep 2021 06:07:04 +0000 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (unknown [40.107.236.63]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id fd80c276-0bb3-11ec-ae3e-12813bfff9fa; Thu, 02 Sep 2021 06:07:02 +0000 (UTC) Received: from DM3PR12CA0089.namprd12.prod.outlook.com (2603:10b6:0:57::33) by BN7PR02MB4211.namprd02.prod.outlook.com (2603:10b6:406:fc::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.23; Thu, 2 Sep 2021 06:06:59 +0000 Received: from DM3NAM02FT042.eop-nam02.prod.protection.outlook.com (2603:10b6:0:57:cafe::58) by DM3PR12CA0089.outlook.office365.com (2603:10b6:0:57::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.17 via Frontend Transport; Thu, 2 Sep 2021 06:06:59 +0000 Received: from xsj-pvapexch01.xlnx.xilinx.com (149.199.62.198) by DM3NAM02FT042.mail.protection.outlook.com (10.13.4.213) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.4478.19 via Frontend Transport; Thu, 2 Sep 2021 06:06:58 +0000 Received: from xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) by xsj-pvapexch01.xlnx.xilinx.com (172.19.86.40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Wed, 1 Sep 2021 23:06:56 -0700 Received: from smtp.xilinx.com (172.19.127.96) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Wed, 1 Sep 2021 23:06:56 -0700 Received: from [172.19.2.115] (port=56596 helo=xsjfnuv50.xilinx.com) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1mLfsG-000F6q-6V; Wed, 01 Sep 2021 23:06:56 -0700 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fd80c276-0bb3-11ec-ae3e-12813bfff9fa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=R6Vc4VFGnNuCCjRMR92oBl1bAZff2gHkQsaMvWJXlyY7ssCfoaZvdezkRw+D+7ISyeq/qMDSjl7kbYmvkJzBkz9SdCRIJwyPEe/NjbMCZ9veKiS1a5mJYM2wkeS/RdoA+Hapri/rlW/dwjOYfbA7Q1aNIsJi82YWAflviuIxk2K4r0XAaR/ECDp/MxCXtPNHwOphzdcG8lj60/Ir862yHzu+nj3KRU+LT8AsbDpS3dBRcV/2gE0Vw3mg3Lms/odAE2WpZBOpPpjfpFIjRY6HbXHOLoF2ry7/Nl6Eolf/EC3+iEwf1FXuoc5oqxHiO+NAtj/9lRmp2l0nRbp7Y+CH0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FBIDlGqTHEriiyE7H+BVFfcsrCknmNO0E31FG6ZulT4=; b=Sun1v8s7rdBMypKl7wq30b8gHJPwCCBjAd+LZIlTy5RKSVCuQ+JFQUIrpkfuO3iPgIKo06YrM7jJcPj6d+htlJ5SBc8kZ4l9awvjC5pJy7PWXsQzPDiwIJS3CPH3h7BRc7FnaIDyA/ioFmpXjRIDCL68LDNSE/xzeq1fwhyxLf1q5rLqT/8DR2U57jvH2ZBl+RkXaFPK6vxPToe/YimCwGOBmc/hQYvwFQgc+BO+/LViin+qP14BwoDINaaBOfeUOuwlDJddA/WK+bNzaD5IGBpuXUCu9+VFwADGytv7ARragyJwe0gb7GxbyyCT0aDt1geqC2C/NwMo+70THM5xPQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.62.198) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FBIDlGqTHEriiyE7H+BVFfcsrCknmNO0E31FG6ZulT4=; b=FLUVpOfTD/W41h3mRIDt6XCQPHQ/wBHdw8Bikj2+6WL57PbHWKTUgLJ0gE0kEgvb3ankE03JYrvY2bsnHXLb5TTv0dYxcGvRPbOa/v1jI/zZneHcpAM+rFK5HCWkhfPQX54SPftiqiT0jO6BbNS3PpGYAC6o71QPgXc6+kOZuMU= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.62.198) smtp.mailfrom=xilinx.com; lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.62.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.62.198; helo=xsj-pvapexch01.xlnx.xilinx.com; From: Vikram Garhwal To: CC: , , Vikram Garhwal Subject: [XEN][RFC PATCH 03/13] libfdt: import fdt_overlay from Linux Date: Wed, 1 Sep 2021 23:05:53 -0700 Message-ID: <1630562763-390068-4-git-send-email-fnu.vikram@xilinx.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1630562763-390068-1-git-send-email-fnu.vikram@xilinx.com> References: <1630562763-390068-1-git-send-email-fnu.vikram@xilinx.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 89b30686-b128-471c-dc4a-08d96dd7df9f X-MS-TrafficTypeDiagnostic: BN7PR02MB4211: X-Microsoft-Antispam-PRVS: X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-Oob-TLC-OOBClassifiers: OLM:130; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yjqvN7lSYivxzQcNipLCYLIXc4ae1BOoYUmYeHnmYIX8DTF6TSc1F/EjcJYyBj0RClsoXswFmP1pYPOntxMIa/Hf38w7L2LRjfd2YgMKITmooPwKbBANrmeAuC0fkkRDfcfVwwbQvDcXxUTsj965VFj/Q2uqV81ebBusq/wlnH9iL0WjRpyGzDBhwriBTlENWG0K5/o5C3p/q6OKvCSn/euwvLHrcuTeO8WN8zruf2HbHEUqAEJvVmerEGAJ5Qv0z/TbdVRWZk/fZ9aybpC7SoXTUeZo4+VpqC79c14An8H1XdVyphz3f0uhjdBezhfsuQ+nyqd1YiftQQfhtaf3N9BIWJVoZfnwid0IshabO6fhIhhPDdr5dcnF8rr7DB13AJz3fasHb3l2+msrHuU1piCpLfe+Z3uEhCK0TfEmAuucqXUDPet+OUf19iAlx2lgDlF4oAtThVTbj4k8V/yDUOUmxsA88S+WMwxTqKJEyJcJDF4x/6SRG/gdHPNIr/PTmSDoeubHZw2q6jbIz4Qo/ADLGEFxyMyJVgMw6cv42042qrUvMuMNaKZhVYR3ElLt/FPUX7lhiiFYMXkjuOjfpGtp/6/GvTIpbNCBo7zfeDx98cB2lLvbSDu9z57yFzfWocbGA5/sP2Pjxw+lradx5EOpTiXWEZabxIYujNTRt2mKwALw27u1neemjh8bKWA9E62myncgQcz75B9GOfuoc1mpn+DgoKdKIZrBYp6LA84= X-Forefront-Antispam-Report: CIP:149.199.62.198;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:xsj-pvapexch01.xlnx.xilinx.com;PTR:unknown-62-198.xilinx.com;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(83380400001)(2906002)(426003)(186003)(82310400003)(54906003)(508600001)(7636003)(6916009)(7696005)(30864003)(70206006)(5660300002)(316002)(47076005)(36906005)(36860700001)(9786002)(8676002)(2616005)(70586007)(336012)(4326008)(8936002)(356005)(6666004)(26005)(36756003)(107886003)(102446001);DIR:OUT;SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Sep 2021 06:06:58.5918 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 89b30686-b128-471c-dc4a-08d96dd7df9f X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.62.198];Helo=[xsj-pvapexch01.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: DM3NAM02FT042.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR02MB4211 Xen is missing fdt overlay functionalities. FDT overlay is required for changing the device tree nodes during run-time. fdt_overlay.c file is copied from Linux tree's following patch: commit: 6e9c9686d826564f44c93cdd6f111b1c0a9dc224 scripts/dtc: Update to upstream version v1.6.0-31-gcbca977ea121 Signed-off-by: Vikram Garhwal --- xen/common/libfdt/fdt_overlay.c | 882 ++++++++++++++++++++++++++++++++++++++++ 1 file changed, 882 insertions(+) create mode 100644 xen/common/libfdt/fdt_overlay.c diff --git a/xen/common/libfdt/fdt_overlay.c b/xen/common/libfdt/fdt_overlay.c new file mode 100644 index 0000000..d217e79 --- /dev/null +++ b/xen/common/libfdt/fdt_overlay.c @@ -0,0 +1,882 @@ +// SPDX-License-Identifier: (GPL-2.0-or-later OR BSD-2-Clause) +/* + * libfdt - Flat Device Tree manipulation + * Copyright (C) 2016 Free Electrons + * Copyright (C) 2016 NextThing Co. + */ +#include "libfdt_env.h" + +#include +#include + +#include "libfdt_internal.h" + +/** + * overlay_get_target_phandle - retrieves the target phandle of a fragment + * @fdto: pointer to the device tree overlay blob + * @fragment: node offset of the fragment in the overlay + * + * overlay_get_target_phandle() retrieves the target phandle of an + * overlay fragment when that fragment uses a phandle (target + * property) instead of a path (target-path property). + * + * returns: + * the phandle pointed by the target property + * 0, if the phandle was not found + * -1, if the phandle was malformed + */ +static uint32_t overlay_get_target_phandle(const void *fdto, int fragment) +{ + const fdt32_t *val; + int len; + + val = fdt_getprop(fdto, fragment, "target", &len); + if (!val) + return 0; + + if ((len != sizeof(*val)) || (fdt32_to_cpu(*val) == (uint32_t)-1)) + return (uint32_t)-1; + + return fdt32_to_cpu(*val); +} + +/** + * overlay_get_target - retrieves the offset of a fragment's target + * @fdt: Base device tree blob + * @fdto: Device tree overlay blob + * @fragment: node offset of the fragment in the overlay + * @pathp: pointer which receives the path of the target (or NULL) + * + * overlay_get_target() retrieves the target offset in the base + * device tree of a fragment, no matter how the actual targeting is + * done (through a phandle or a path) + * + * returns: + * the targeted node offset in the base device tree + * Negative error code on error + */ +static int overlay_get_target(const void *fdt, const void *fdto, + int fragment, char const **pathp) +{ + uint32_t phandle; + const char *path = NULL; + int path_len = 0, ret; + + /* Try first to do a phandle based lookup */ + phandle = overlay_get_target_phandle(fdto, fragment); + if (phandle == (uint32_t)-1) + return -FDT_ERR_BADPHANDLE; + + /* no phandle, try path */ + if (!phandle) { + /* And then a path based lookup */ + path = fdt_getprop(fdto, fragment, "target-path", &path_len); + if (path) + ret = fdt_path_offset(fdt, path); + else + ret = path_len; + } else + ret = fdt_node_offset_by_phandle(fdt, phandle); + + /* + * If we haven't found either a target or a + * target-path property in a node that contains a + * __overlay__ subnode (we wouldn't be called + * otherwise), consider it a improperly written + * overlay + */ + if (ret < 0 && path_len == -FDT_ERR_NOTFOUND) + ret = -FDT_ERR_BADOVERLAY; + + /* return on error */ + if (ret < 0) + return ret; + + /* return pointer to path (if available) */ + if (pathp) + *pathp = path ? path : NULL; + + return ret; +} + +/** + * overlay_phandle_add_offset - Increases a phandle by an offset + * @fdt: Base device tree blob + * @node: Device tree overlay blob + * @name: Name of the property to modify (phandle or linux,phandle) + * @delta: offset to apply + * + * overlay_phandle_add_offset() increments a node phandle by a given + * offset. + * + * returns: + * 0 on success. + * Negative error code on error + */ +static int overlay_phandle_add_offset(void *fdt, int node, + const char *name, uint32_t delta) +{ + const fdt32_t *val; + uint32_t adj_val; + int len; + + val = fdt_getprop(fdt, node, name, &len); + if (!val) + return len; + + if (len != sizeof(*val)) + return -FDT_ERR_BADPHANDLE; + + adj_val = fdt32_to_cpu(*val); + if ((adj_val + delta) < adj_val) + return -FDT_ERR_NOPHANDLES; + + adj_val += delta; + if (adj_val == (uint32_t)-1) + return -FDT_ERR_NOPHANDLES; + + return fdt_setprop_inplace_u32(fdt, node, name, adj_val); +} + +/** + * overlay_adjust_node_phandles - Offsets the phandles of a node + * @fdto: Device tree overlay blob + * @node: Offset of the node we want to adjust + * @delta: Offset to shift the phandles of + * + * overlay_adjust_node_phandles() adds a constant to all the phandles + * of a given node. This is mainly use as part of the overlay + * application process, when we want to update all the overlay + * phandles to not conflict with the overlays of the base device tree. + * + * returns: + * 0 on success + * Negative error code on failure + */ +static int overlay_adjust_node_phandles(void *fdto, int node, + uint32_t delta) +{ + int child; + int ret; + + ret = overlay_phandle_add_offset(fdto, node, "phandle", delta); + if (ret && ret != -FDT_ERR_NOTFOUND) + return ret; + + ret = overlay_phandle_add_offset(fdto, node, "linux,phandle", delta); + if (ret && ret != -FDT_ERR_NOTFOUND) + return ret; + + fdt_for_each_subnode(child, fdto, node) { + ret = overlay_adjust_node_phandles(fdto, child, delta); + if (ret) + return ret; + } + + return 0; +} + +/** + * overlay_adjust_local_phandles - Adjust the phandles of a whole overlay + * @fdto: Device tree overlay blob + * @delta: Offset to shift the phandles of + * + * overlay_adjust_local_phandles() adds a constant to all the + * phandles of an overlay. This is mainly use as part of the overlay + * application process, when we want to update all the overlay + * phandles to not conflict with the overlays of the base device tree. + * + * returns: + * 0 on success + * Negative error code on failure + */ +static int overlay_adjust_local_phandles(void *fdto, uint32_t delta) +{ + /* + * Start adjusting the phandles from the overlay root + */ + return overlay_adjust_node_phandles(fdto, 0, delta); +} + +/** + * overlay_update_local_node_references - Adjust the overlay references + * @fdto: Device tree overlay blob + * @tree_node: Node offset of the node to operate on + * @fixup_node: Node offset of the matching local fixups node + * @delta: Offset to shift the phandles of + * + * overlay_update_local_nodes_references() update the phandles + * pointing to a node within the device tree overlay by adding a + * constant delta. + * + * This is mainly used as part of a device tree application process, + * where you want the device tree overlays phandles to not conflict + * with the ones from the base device tree before merging them. + * + * returns: + * 0 on success + * Negative error code on failure + */ +static int overlay_update_local_node_references(void *fdto, + int tree_node, + int fixup_node, + uint32_t delta) +{ + int fixup_prop; + int fixup_child; + int ret; + + fdt_for_each_property_offset(fixup_prop, fdto, fixup_node) { + const fdt32_t *fixup_val; + const char *tree_val; + const char *name; + int fixup_len; + int tree_len; + int i; + + fixup_val = fdt_getprop_by_offset(fdto, fixup_prop, + &name, &fixup_len); + if (!fixup_val) + return fixup_len; + + if (fixup_len % sizeof(uint32_t)) + return -FDT_ERR_BADOVERLAY; + fixup_len /= sizeof(uint32_t); + + tree_val = fdt_getprop(fdto, tree_node, name, &tree_len); + if (!tree_val) { + if (tree_len == -FDT_ERR_NOTFOUND) + return -FDT_ERR_BADOVERLAY; + + return tree_len; + } + + for (i = 0; i < fixup_len; i++) { + fdt32_t adj_val; + uint32_t poffset; + + poffset = fdt32_to_cpu(fixup_val[i]); + + /* + * phandles to fixup can be unaligned. + * + * Use a memcpy for the architectures that do + * not support unaligned accesses. + */ + memcpy(&adj_val, tree_val + poffset, sizeof(adj_val)); + + adj_val = cpu_to_fdt32(fdt32_to_cpu(adj_val) + delta); + + ret = fdt_setprop_inplace_namelen_partial(fdto, + tree_node, + name, + strlen(name), + poffset, + &adj_val, + sizeof(adj_val)); + if (ret == -FDT_ERR_NOSPACE) + return -FDT_ERR_BADOVERLAY; + + if (ret) + return ret; + } + } + + fdt_for_each_subnode(fixup_child, fdto, fixup_node) { + const char *fixup_child_name = fdt_get_name(fdto, fixup_child, + NULL); + int tree_child; + + tree_child = fdt_subnode_offset(fdto, tree_node, + fixup_child_name); + if (tree_child == -FDT_ERR_NOTFOUND) + return -FDT_ERR_BADOVERLAY; + if (tree_child < 0) + return tree_child; + + ret = overlay_update_local_node_references(fdto, + tree_child, + fixup_child, + delta); + if (ret) + return ret; + } + + return 0; +} + +/** + * overlay_update_local_references - Adjust the overlay references + * @fdto: Device tree overlay blob + * @delta: Offset to shift the phandles of + * + * overlay_update_local_references() update all the phandles pointing + * to a node within the device tree overlay by adding a constant + * delta to not conflict with the base overlay. + * + * This is mainly used as part of a device tree application process, + * where you want the device tree overlays phandles to not conflict + * with the ones from the base device tree before merging them. + * + * returns: + * 0 on success + * Negative error code on failure + */ +static int overlay_update_local_references(void *fdto, uint32_t delta) +{ + int fixups; + + fixups = fdt_path_offset(fdto, "/__local_fixups__"); + if (fixups < 0) { + /* There's no local phandles to adjust, bail out */ + if (fixups == -FDT_ERR_NOTFOUND) + return 0; + + return fixups; + } + + /* + * Update our local references from the root of the tree + */ + return overlay_update_local_node_references(fdto, 0, fixups, + delta); +} + +/** + * overlay_fixup_one_phandle - Set an overlay phandle to the base one + * @fdt: Base Device Tree blob + * @fdto: Device tree overlay blob + * @symbols_off: Node offset of the symbols node in the base device tree + * @path: Path to a node holding a phandle in the overlay + * @path_len: number of path characters to consider + * @name: Name of the property holding the phandle reference in the overlay + * @name_len: number of name characters to consider + * @poffset: Offset within the overlay property where the phandle is stored + * @label: Label of the node referenced by the phandle + * + * overlay_fixup_one_phandle() resolves an overlay phandle pointing to + * a node in the base device tree. + * + * This is part of the device tree overlay application process, when + * you want all the phandles in the overlay to point to the actual + * base dt nodes. + * + * returns: + * 0 on success + * Negative error code on failure + */ +static int overlay_fixup_one_phandle(void *fdt, void *fdto, + int symbols_off, + const char *path, uint32_t path_len, + const char *name, uint32_t name_len, + int poffset, const char *label) +{ + const char *symbol_path; + uint32_t phandle; + fdt32_t phandle_prop; + int symbol_off, fixup_off; + int prop_len; + + if (symbols_off < 0) + return symbols_off; + + symbol_path = fdt_getprop(fdt, symbols_off, label, + &prop_len); + if (!symbol_path) + return prop_len; + + symbol_off = fdt_path_offset(fdt, symbol_path); + if (symbol_off < 0) + return symbol_off; + + phandle = fdt_get_phandle(fdt, symbol_off); + if (!phandle) + return -FDT_ERR_NOTFOUND; + + fixup_off = fdt_path_offset_namelen(fdto, path, path_len); + if (fixup_off == -FDT_ERR_NOTFOUND) + return -FDT_ERR_BADOVERLAY; + if (fixup_off < 0) + return fixup_off; + + phandle_prop = cpu_to_fdt32(phandle); + return fdt_setprop_inplace_namelen_partial(fdto, fixup_off, + name, name_len, poffset, + &phandle_prop, + sizeof(phandle_prop)); +}; + +/** + * overlay_fixup_phandle - Set an overlay phandle to the base one + * @fdt: Base Device Tree blob + * @fdto: Device tree overlay blob + * @symbols_off: Node offset of the symbols node in the base device tree + * @property: Property offset in the overlay holding the list of fixups + * + * overlay_fixup_phandle() resolves all the overlay phandles pointed + * to in a __fixups__ property, and updates them to match the phandles + * in use in the base device tree. + * + * This is part of the device tree overlay application process, when + * you want all the phandles in the overlay to point to the actual + * base dt nodes. + * + * returns: + * 0 on success + * Negative error code on failure + */ +static int overlay_fixup_phandle(void *fdt, void *fdto, int symbols_off, + int property) +{ + const char *value; + const char *label; + int len; + + value = fdt_getprop_by_offset(fdto, property, + &label, &len); + if (!value) { + if (len == -FDT_ERR_NOTFOUND) + return -FDT_ERR_INTERNAL; + + return len; + } + + do { + const char *path, *name, *fixup_end; + const char *fixup_str = value; + uint32_t path_len, name_len; + uint32_t fixup_len; + char *sep, *endptr; + int poffset, ret; + + fixup_end = memchr(value, '\0', len); + if (!fixup_end) + return -FDT_ERR_BADOVERLAY; + fixup_len = fixup_end - fixup_str; + + len -= fixup_len + 1; + value += fixup_len + 1; + + path = fixup_str; + sep = memchr(fixup_str, ':', fixup_len); + if (!sep || *sep != ':') + return -FDT_ERR_BADOVERLAY; + + path_len = sep - path; + if (path_len == (fixup_len - 1)) + return -FDT_ERR_BADOVERLAY; + + fixup_len -= path_len + 1; + name = sep + 1; + sep = memchr(name, ':', fixup_len); + if (!sep || *sep != ':') + return -FDT_ERR_BADOVERLAY; + + name_len = sep - name; + if (!name_len) + return -FDT_ERR_BADOVERLAY; + + poffset = strtoul(sep + 1, &endptr, 10); + if ((*endptr != '\0') || (endptr <= (sep + 1))) + return -FDT_ERR_BADOVERLAY; + + ret = overlay_fixup_one_phandle(fdt, fdto, symbols_off, + path, path_len, name, name_len, + poffset, label); + if (ret) + return ret; + } while (len > 0); + + return 0; +} + +/** + * overlay_fixup_phandles - Resolve the overlay phandles to the base + * device tree + * @fdt: Base Device Tree blob + * @fdto: Device tree overlay blob + * + * overlay_fixup_phandles() resolves all the overlay phandles pointing + * to nodes in the base device tree. + * + * This is one of the steps of the device tree overlay application + * process, when you want all the phandles in the overlay to point to + * the actual base dt nodes. + * + * returns: + * 0 on success + * Negative error code on failure + */ +static int overlay_fixup_phandles(void *fdt, void *fdto) +{ + int fixups_off, symbols_off; + int property; + + /* We can have overlays without any fixups */ + fixups_off = fdt_path_offset(fdto, "/__fixups__"); + if (fixups_off == -FDT_ERR_NOTFOUND) + return 0; /* nothing to do */ + if (fixups_off < 0) + return fixups_off; + + /* And base DTs without symbols */ + symbols_off = fdt_path_offset(fdt, "/__symbols__"); + if ((symbols_off < 0 && (symbols_off != -FDT_ERR_NOTFOUND))) + return symbols_off; + + fdt_for_each_property_offset(property, fdto, fixups_off) { + int ret; + + ret = overlay_fixup_phandle(fdt, fdto, symbols_off, property); + if (ret) + return ret; + } + + return 0; +} + +/** + * overlay_apply_node - Merges a node into the base device tree + * @fdt: Base Device Tree blob + * @target: Node offset in the base device tree to apply the fragment to + * @fdto: Device tree overlay blob + * @node: Node offset in the overlay holding the changes to merge + * + * overlay_apply_node() merges a node into a target base device tree + * node pointed. + * + * This is part of the final step in the device tree overlay + * application process, when all the phandles have been adjusted and + * resolved and you just have to merge overlay into the base device + * tree. + * + * returns: + * 0 on success + * Negative error code on failure + */ +static int overlay_apply_node(void *fdt, int target, + void *fdto, int node) +{ + int property; + int subnode; + + fdt_for_each_property_offset(property, fdto, node) { + const char *name; + const void *prop; + int prop_len; + int ret; + + prop = fdt_getprop_by_offset(fdto, property, &name, + &prop_len); + if (prop_len == -FDT_ERR_NOTFOUND) + return -FDT_ERR_INTERNAL; + if (prop_len < 0) + return prop_len; + + ret = fdt_setprop(fdt, target, name, prop, prop_len); + if (ret) + return ret; + } + + fdt_for_each_subnode(subnode, fdto, node) { + const char *name = fdt_get_name(fdto, subnode, NULL); + int nnode; + int ret; + + nnode = fdt_add_subnode(fdt, target, name); + if (nnode == -FDT_ERR_EXISTS) { + nnode = fdt_subnode_offset(fdt, target, name); + if (nnode == -FDT_ERR_NOTFOUND) + return -FDT_ERR_INTERNAL; + } + + if (nnode < 0) + return nnode; + + ret = overlay_apply_node(fdt, nnode, fdto, subnode); + if (ret) + return ret; + } + + return 0; +} + +/** + * overlay_merge - Merge an overlay into its base device tree + * @fdt: Base Device Tree blob + * @fdto: Device tree overlay blob + * + * overlay_merge() merges an overlay into its base device tree. + * + * This is the next to last step in the device tree overlay application + * process, when all the phandles have been adjusted and resolved and + * you just have to merge overlay into the base device tree. + * + * returns: + * 0 on success + * Negative error code on failure + */ +static int overlay_merge(void *fdt, void *fdto) +{ + int fragment; + + fdt_for_each_subnode(fragment, fdto, 0) { + int overlay; + int target; + int ret; + + /* + * Each fragments will have an __overlay__ node. If + * they don't, it's not supposed to be merged + */ + overlay = fdt_subnode_offset(fdto, fragment, "__overlay__"); + if (overlay == -FDT_ERR_NOTFOUND) + continue; + + if (overlay < 0) + return overlay; + + target = overlay_get_target(fdt, fdto, fragment, NULL); + if (target < 0) + return target; + + ret = overlay_apply_node(fdt, target, fdto, overlay); + if (ret) + return ret; + } + + return 0; +} + +static int get_path_len(const void *fdt, int nodeoffset) +{ + int len = 0, namelen; + const char *name; + + FDT_RO_PROBE(fdt); + + for (;;) { + name = fdt_get_name(fdt, nodeoffset, &namelen); + if (!name) + return namelen; + + /* root? we're done */ + if (namelen == 0) + break; + + nodeoffset = fdt_parent_offset(fdt, nodeoffset); + if (nodeoffset < 0) + return nodeoffset; + len += namelen + 1; + } + + /* in case of root pretend it's "/" */ + if (len == 0) + len++; + return len; +} + +/** + * overlay_symbol_update - Update the symbols of base tree after a merge + * @fdt: Base Device Tree blob + * @fdto: Device tree overlay blob + * + * overlay_symbol_update() updates the symbols of the base tree with the + * symbols of the applied overlay + * + * This is the last step in the device tree overlay application + * process, allowing the reference of overlay symbols by subsequent + * overlay operations. + * + * returns: + * 0 on success + * Negative error code on failure + */ +static int overlay_symbol_update(void *fdt, void *fdto) +{ + int root_sym, ov_sym, prop, path_len, fragment, target; + int len, frag_name_len, ret, rel_path_len; + const char *s, *e; + const char *path; + const char *name; + const char *frag_name; + const char *rel_path; + const char *target_path; + char *buf; + void *p; + + ov_sym = fdt_subnode_offset(fdto, 0, "__symbols__"); + + /* if no overlay symbols exist no problem */ + if (ov_sym < 0) + return 0; + + root_sym = fdt_subnode_offset(fdt, 0, "__symbols__"); + + /* it no root symbols exist we should create them */ + if (root_sym == -FDT_ERR_NOTFOUND) + root_sym = fdt_add_subnode(fdt, 0, "__symbols__"); + + /* any error is fatal now */ + if (root_sym < 0) + return root_sym; + + /* iterate over each overlay symbol */ + fdt_for_each_property_offset(prop, fdto, ov_sym) { + path = fdt_getprop_by_offset(fdto, prop, &name, &path_len); + if (!path) + return path_len; + + /* verify it's a string property (terminated by a single \0) */ + if (path_len < 1 || memchr(path, '\0', path_len) != &path[path_len - 1]) + return -FDT_ERR_BADVALUE; + + /* keep end marker to avoid strlen() */ + e = path + path_len; + + if (*path != '/') + return -FDT_ERR_BADVALUE; + + /* get fragment name first */ + s = strchr(path + 1, '/'); + if (!s) { + /* Symbol refers to something that won't end + * up in the target tree */ + continue; + } + + frag_name = path + 1; + frag_name_len = s - path - 1; + + /* verify format; safe since "s" lies in \0 terminated prop */ + len = sizeof("/__overlay__/") - 1; + if ((e - s) > len && (memcmp(s, "/__overlay__/", len) == 0)) { + /* //__overlay__/ */ + rel_path = s + len; + rel_path_len = e - rel_path - 1; + } else if ((e - s) == len + && (memcmp(s, "/__overlay__", len - 1) == 0)) { + /* //__overlay__ */ + rel_path = ""; + rel_path_len = 0; + } else { + /* Symbol refers to something that won't end + * up in the target tree */ + continue; + } + + /* find the fragment index in which the symbol lies */ + ret = fdt_subnode_offset_namelen(fdto, 0, frag_name, + frag_name_len); + /* not found? */ + if (ret < 0) + return -FDT_ERR_BADOVERLAY; + fragment = ret; + + /* an __overlay__ subnode must exist */ + ret = fdt_subnode_offset(fdto, fragment, "__overlay__"); + if (ret < 0) + return -FDT_ERR_BADOVERLAY; + + /* get the target of the fragment */ + ret = overlay_get_target(fdt, fdto, fragment, &target_path); + if (ret < 0) + return ret; + target = ret; + + /* if we have a target path use */ + if (!target_path) { + ret = get_path_len(fdt, target); + if (ret < 0) + return ret; + len = ret; + } else { + len = strlen(target_path); + } + + ret = fdt_setprop_placeholder(fdt, root_sym, name, + len + (len > 1) + rel_path_len + 1, &p); + if (ret < 0) + return ret; + + if (!target_path) { + /* again in case setprop_placeholder changed it */ + ret = overlay_get_target(fdt, fdto, fragment, &target_path); + if (ret < 0) + return ret; + target = ret; + } + + buf = p; + if (len > 1) { /* target is not root */ + if (!target_path) { + ret = fdt_get_path(fdt, target, buf, len + 1); + if (ret < 0) + return ret; + } else + memcpy(buf, target_path, len + 1); + + } else + len--; + + buf[len] = '/'; + memcpy(buf + len + 1, rel_path, rel_path_len); + buf[len + 1 + rel_path_len] = '\0'; + } + + return 0; +} + +int fdt_overlay_apply(void *fdt, void *fdto) +{ + uint32_t delta; + int ret; + + FDT_RO_PROBE(fdt); + FDT_RO_PROBE(fdto); + + ret = fdt_find_max_phandle(fdt, &delta); + if (ret) + goto err; + + ret = overlay_adjust_local_phandles(fdto, delta); + if (ret) + goto err; + + ret = overlay_update_local_references(fdto, delta); + if (ret) + goto err; + + ret = overlay_fixup_phandles(fdt, fdto); + if (ret) + goto err; + + ret = overlay_merge(fdt, fdto); + if (ret) + goto err; + + ret = overlay_symbol_update(fdt, fdto); + if (ret) + goto err; + + /* + * The overlay has been damaged, erase its magic. + */ + fdt_set_magic(fdto, ~0); + + return 0; + +err: + /* + * The overlay might have been damaged, erase its magic. + */ + fdt_set_magic(fdto, ~0); + + /* + * The base device tree might have been damaged, erase its + * magic. + */ + fdt_set_magic(fdt, ~0); + + return ret; +} -- 2.7.4 From xen-devel-bounces@lists.xenproject.org Thu Sep 02 06:50:59 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 06:50:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.176917.322095 (Exim 4.92) (envelope-from ) id 1mLgYr-00051E-Bb; Thu, 02 Sep 2021 06:50:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 176917.322095; Thu, 02 Sep 2021 06:50:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLgYr-0004z1-2e; Thu, 02 Sep 2021 06:50:57 +0000 Received: by outflank-mailman (input) for mailman id 176917; Thu, 02 Sep 2021 06:07:10 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLfsU-0004aK-4w for xen-devel@lists.xenproject.org; Thu, 02 Sep 2021 06:07:10 +0000 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (unknown [40.107.223.42]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 6b740e9e-d45e-48aa-a9e2-50634644e3d4; Thu, 02 Sep 2021 06:07:07 +0000 (UTC) Received: from DM3PR12CA0077.namprd12.prod.outlook.com (2603:10b6:0:57::21) by SN1PR02MB3678.namprd02.prod.outlook.com (2603:10b6:802:24::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.17; Thu, 2 Sep 2021 06:07:05 +0000 Received: from DM3NAM02FT042.eop-nam02.prod.protection.outlook.com (2603:10b6:0:57:cafe::6f) by DM3PR12CA0077.outlook.office365.com (2603:10b6:0:57::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Thu, 2 Sep 2021 06:07:05 +0000 Received: from xsj-pvapexch01.xlnx.xilinx.com (149.199.62.198) by DM3NAM02FT042.mail.protection.outlook.com (10.13.4.213) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.4478.19 via Frontend Transport; Thu, 2 Sep 2021 06:07:04 +0000 Received: from xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) by xsj-pvapexch01.xlnx.xilinx.com (172.19.86.40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Wed, 1 Sep 2021 23:07:03 -0700 Received: from smtp.xilinx.com (172.19.127.96) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Wed, 1 Sep 2021 23:07:03 -0700 Received: from [172.19.2.115] (port=56596 helo=xsjfnuv50.xilinx.com) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1mLfsN-000F6q-2G; Wed, 01 Sep 2021 23:07:03 -0700 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6b740e9e-d45e-48aa-a9e2-50634644e3d4 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Rl4T92K7Fut2IIfUEKMpAEcvU69Hlgw4vqQXXLOgTc3QCZhwAtKznHM+TT77SjKpL+8iKTZV2if0Bq/ogNoqrBwsnX7T+oOrGxG1rbCro0PrhpjawwTpzdeBpYxyF8pFoSA8bhG6RNxLmNgcHcJqhwUOHtpXYTE5d7BEcp/IB/yk86gbUorlTmdYZOlojDET28UlZT690kpdDD3VfYUij/LnPcb8jzDYxm0DRKGaLQ+7rAt4fbjbDLdxSer+q2udMdkxk2XMxpKZ3MBC96zMq02TYTMLr+lB8uCgdSpxM/OMIzc6Gr/KGn2/sYQdAt/r7Cx334uckbIt9vi7ng5kpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=98AtMQVzaAHOwKKFvylID8GyFmwvLo9S59QnYCd+rzM=; b=G5j+giD11VwxA/+WjkeuVgz1IKhyT5QrsNZcBBg+HfzHOPGvK/TD4n7zzgbwieSfiw4kuHNN9SSUShmjvL3fFvF/XTkyFEh77acor6VGTtm+4yrkk9YtndmWIsmziVD+9N0h2HJBuY+blFa+BaC+pRWxKsXIqLopX95qgKk18I30pa0cVtKvhdm9TJRtFqr0KO3pWnGFshhN+8GaNrCrygYYZ3vzjyJVHUu/+i3ToFA5NZCr2QPw75PVVdPZpmBrGCZbFdh3Cxr6vb7zaM4pFOlh67bWMwgl9hjzGVGvELRG7XKcoh2R3/F0r7t6A26MW0VFDRWh6yIborcIqxESXQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.62.198) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=98AtMQVzaAHOwKKFvylID8GyFmwvLo9S59QnYCd+rzM=; b=fEWmNfRVw1Iw8SEg1ZJOVObVMv/9iTTh6owNYcdnonI8ZYPCJGVNVTb8SUJJmGVD8VH+egahPgwdubShCsrwZwyHUKeYy87EnMpegIxRJW4PJxce9p3oQh06ta2cXK5iJUM+w4SRa5AFroCrtqfEIv2zBOn67BqTh1F8aoAkQkE= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.62.198) smtp.mailfrom=xilinx.com; lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.62.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.62.198; helo=xsj-pvapexch01.xlnx.xilinx.com; From: Vikram Garhwal To: CC: , , Vikram Garhwal Subject: [XEN][RFC PATCH 05/13] libfdt: Change overlay_get_target() type Date: Wed, 1 Sep 2021 23:05:55 -0700 Message-ID: <1630562763-390068-6-git-send-email-fnu.vikram@xilinx.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1630562763-390068-1-git-send-email-fnu.vikram@xilinx.com> References: <1630562763-390068-1-git-send-email-fnu.vikram@xilinx.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0f9a09cc-64e5-4749-23cf-08d96dd7e370 X-MS-TrafficTypeDiagnostic: SN1PR02MB3678: X-Microsoft-Antispam-PRVS: X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-Oob-TLC-OOBClassifiers: OLM:3968; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Ckx58VpUs6M3WyHg9+f3TqPbipbP2X8Vt1GQIVqSNAERsgzKnshwp3cxb9Nns37n+s5ns0VbNIB544kPvP5jy0tLHvh7SMNMggeLtvftBKBZBqEEL5SJ1yi/CKgXDuQjuzekuB5+fr+LKGPVnlNhcBmRU+bl7V69dfXqFUkzjXp6ic0Znws3VNTV3NYqcXatPYo4s472WDu/hQXjofqak6d22e/tgeFGX4el0eIRH9Z8+pADwfxVXpkrXQpCQfWN47nPcFQrIKTN+ItqgIHv7VSpvr7cNvns4K7tPEXVAVZbIlvLO+6QEv+4qsSZdQ0IWrW53dOZuxPBTNGOulf/EoITBmfrO7n7nC42oqCU8HCFwCiqEjI8r25ATcrhSvAG69J6Ro9sOfLlueIHT+8BoFWHaHR4yjbC+F+8DzwQefiGtc1bhE9a9X0ysfRYHDxzY2qNzyUyf+PBvut6oMDmfQZndm5O5UaijpHnCzB0lXwW0fMJpUCQzedaNBHmHypWBwhYibwKLQbVbfdYS93wbc+iNOfWJeTmX8533vx+SRAz1bLSlbLCMiQmYjyZCAydXqcrK+ckVgopGap6iDzd7kwuBW3Mlu8RWa1cnsXeYmBXsiJKDdl+/gdKBYoqT9cHy3NYUUAUBsZfSJgcTCFg5JCtdgKL2f1PBl6vrsJmSnrvH9/Yrhwjxke23jXA6uUY/evD5iFC2yvEpoT/aHEF4c1sSn7IAYVKKzyvtNZsb0A= X-Forefront-Antispam-Report: CIP:149.199.62.198;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:xsj-pvapexch01.xlnx.xilinx.com;PTR:unknown-62-198.xilinx.com;CAT:NONE;SFS:(4636009)(376002)(396003)(346002)(136003)(39860400002)(46966006)(36840700001)(82310400003)(47076005)(36756003)(70586007)(2616005)(336012)(6666004)(426003)(186003)(26005)(478600001)(2906002)(83380400001)(8936002)(316002)(70206006)(9786002)(8676002)(7696005)(5660300002)(36906005)(82740400003)(7636003)(356005)(54906003)(36860700001)(4326008)(107886003)(6916009)(102446001);DIR:OUT;SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Sep 2021 06:07:04.9759 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0f9a09cc-64e5-4749-23cf-08d96dd7e370 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.62.198];Helo=[xsj-pvapexch01.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: DM3NAM02FT042.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR02MB3678 Remove static function type from overlay_get_target(). Signed-off-by: Vikram Garhwal --- xen/common/libfdt/fdt_overlay.c | 2 +- xen/include/xen/libfdt/libfdt.h | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/xen/common/libfdt/fdt_overlay.c b/xen/common/libfdt/fdt_overlay.c index 15a8cdb..1ffb669 100644 --- a/xen/common/libfdt/fdt_overlay.c +++ b/xen/common/libfdt/fdt_overlay.c @@ -56,7 +56,7 @@ static uint32_t overlay_get_target_phandle(const void *fdto, int fragment) * the targeted node offset in the base device tree * Negative error code on error */ -static int overlay_get_target(const void *fdt, const void *fdto, +int overlay_get_target(const void *fdt, const void *fdto, int fragment, char const **pathp) { uint32_t phandle; diff --git a/xen/include/xen/libfdt/libfdt.h b/xen/include/xen/libfdt/libfdt.h index b6c8b67..e1cc6f2 100644 --- a/xen/include/xen/libfdt/libfdt.h +++ b/xen/include/xen/libfdt/libfdt.h @@ -1737,4 +1737,6 @@ int fdt_overlay_apply(void *fdt, void *fdto); const char *fdt_strerror(int errval); +int overlay_get_target(const void *fdt, const void *fdto, int fragment, + char const **pathp); #endif /* _LIBFDT_H */ -- 2.7.4 From xen-devel-bounces@lists.xenproject.org Thu Sep 02 06:50:59 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 06:50:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.176924.322120 (Exim 4.92) (envelope-from ) id 1mLgYt-0005dZ-AL; Thu, 02 Sep 2021 06:50:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 176924.322120; Thu, 02 Sep 2021 06:50:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLgYs-0005aj-Rl; Thu, 02 Sep 2021 06:50:58 +0000 Received: by outflank-mailman (input) for mailman id 176924; Thu, 02 Sep 2021 06:07:36 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLfsu-0004hL-Fg for xen-devel@lists.xenproject.org; Thu, 02 Sep 2021 06:07:36 +0000 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (unknown [40.107.220.65]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 10ba58f3-0bb4-11ec-ae3e-12813bfff9fa; Thu, 02 Sep 2021 06:07:35 +0000 (UTC) Received: from BN8PR12CA0025.namprd12.prod.outlook.com (2603:10b6:408:60::38) by MWHPR02MB3245.namprd02.prod.outlook.com (2603:10b6:301:6b::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.24; Thu, 2 Sep 2021 06:07:31 +0000 Received: from BN1NAM02FT008.eop-nam02.prod.protection.outlook.com (2603:10b6:408:60:cafe::92) by BN8PR12CA0025.outlook.office365.com (2603:10b6:408:60::38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.17 via Frontend Transport; Thu, 2 Sep 2021 06:07:31 +0000 Received: from xsj-pvapexch01.xlnx.xilinx.com (149.199.62.198) by BN1NAM02FT008.mail.protection.outlook.com (10.13.2.126) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.4478.19 via Frontend Transport; Thu, 2 Sep 2021 06:07:30 +0000 Received: from xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) by xsj-pvapexch01.xlnx.xilinx.com (172.19.86.40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Wed, 1 Sep 2021 23:07:08 -0700 Received: from smtp.xilinx.com (172.19.127.96) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Wed, 1 Sep 2021 23:07:08 -0700 Received: from [172.19.2.115] (port=56596 helo=xsjfnuv50.xilinx.com) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1mLfsS-000F6q-2P; Wed, 01 Sep 2021 23:07:08 -0700 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 10ba58f3-0bb4-11ec-ae3e-12813bfff9fa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SYzw5n/WzHl182B+tAIvwfDyBmQvwX19sQvk72oOM9gOO9pzTW5DcD4zRUZysYkRyMrGBsT0kUqeVsB3T0HQmB/lC8Qnb/7fQNEaeGSQp/Vu5fow0E46fi/E/RWVcs0Us3ArSspm0y5n3+upKgeo4of4OUsGXkJi3tuUfLlaQGwK664iUDUMrdw/71qdgOqYXufRwXESfV2ez7gwnABVT6OmXmucUdzOTYBh54RwWW7lOv2yRXdDhYYz6sA60QIoFna9SS5JmplJ/25wLpAVyAUDsvMNpj0s9B/zH1DlUFpdJyBBV05H1+ipjYqSoz2S9yw6xGkk93Ovg+4P/Ky87Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=02lvqIFeq5ueMXlcG0MgTjXHnFIspvYKtsnJlaQoi8I=; b=VmAPSp6bs7xh91+LR0Ait+pq78OmwpFJ1L1fdgJW39/e4zIba+z+k8HdNdsJ9GCBUOnKnog+A0eu8d0PBf+j9rVpSHpHm/0Orh/PhZkfYSjZf23sLtyW7nRtCuDJmh7UO0P0FHSNVQQyOlnNc3T7MtOXwfrGCjhdoV/MVFSAeyXMlwnqrPRUk4Kse69kEJGk2hETXFH15/JoKZUyhsRcsCjPsiGsM84GgWCVpnADsa7HijwP6nGHmHL8HoJ7OB/LlPGqghRc+b3KOHE9LYQKyqKI63Ldl6j5dObSwLkDmS7ne8nvu3RAgF1E2Pud6Ig1k704DWPyTzc6yfvrirfplg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.62.198) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=02lvqIFeq5ueMXlcG0MgTjXHnFIspvYKtsnJlaQoi8I=; b=lLuKWj6CBelA+oFhxzhOFkaU5QhzYs/lLiXHL53JnI+IJuh6JBqKImZkJ4rUunsLnPKwyxCufvVDnnujlGHT296ZVtj29/KUiy2fwsg/Pn8IrwKZWVjFgLrcl4mH1A3JpSleBEDJbbLB5z5wi7sIEAU2RIHZXy10nlCyE/hz5bs= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.62.198) smtp.mailfrom=xilinx.com; lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.62.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.62.198; helo=xsj-pvapexch01.xlnx.xilinx.com; From: Vikram Garhwal To: CC: , , Vikram Garhwal Subject: [XEN][RFC PATCH 07/13] device tree: Add _dt_find_node_by_path() to find nodes in device tree Date: Wed, 1 Sep 2021 23:05:57 -0700 Message-ID: <1630562763-390068-8-git-send-email-fnu.vikram@xilinx.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1630562763-390068-1-git-send-email-fnu.vikram@xilinx.com> References: <1630562763-390068-1-git-send-email-fnu.vikram@xilinx.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3d13ac05-bd98-4b27-6ce7-08d96dd7f2d7 X-MS-TrafficTypeDiagnostic: MWHPR02MB3245: X-Microsoft-Antispam-PRVS: X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: tIH8MefcwcRpvihGrdXSfRE9v6Hh/IeHlbfK0/zW9GVbZG02tTx7mx2WfKTl1kS27XrYGS++2+AbkpfEUxznalv9QcGNa9Xw4ATLF+8X8eWrrJ6OjM1PzkTMc55rJ2mspgTgI8Abc4Lxf2Z1aba7EgnEzQsF1TzasW/+uW32vq2jDAwJGtOJu2NrVA5TjoehMMc8+xjln7mQKtICIzp/vJLCjNAxpzAOlDcRQDJBLrmUtA6T6IufcGRc0acDgammV7QwrNoK3ZbLRqtUVQJue3Q24ZPpDiB/JrvXLASyaa+tZdK8zBpjLF3Rzf332cZE+5QRPt3uNbnioYymlGJ9iVUExJfYzbBGlCVPsVnwHK5FwHm9h8TSTB9ysGBUYj1VjHfeMI9ARGpgUT/TkVzqqffUf1Xa6MqaX43uEyD6HARRLOiv5/7KzBsxIXZdUJc5OqWWWCJwTxD1JHwh9J+uzsQ0sz3nD32KS8pivxqlIH6Y+oXgsJORcXLmLTYhSelNKaWSgHgPKrnDWFCbi58qM3obS9rrG+apG8PMtYf6147KYreB9Y86VyekTnm875mKseajHfXIaxMHXR4A7j+ZVtnFRYivHOhx0X2HUyT5nTX+hNJuvc34XHaPbD8C2ADR7Sn5urTeU0KSsvb4FKapaph+Tyunhlwu+906YXgP05fzz41bOY8ahI26oXBnVH8l7ZEoV+IKV6IrTDPVEc2DvvK0AcJPXpnbTKWd8V6GguhNBWG9P7kHyZVb9ZmNUJRO X-Forefront-Antispam-Report: CIP:149.199.62.198;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:xsj-pvapexch01.xlnx.xilinx.com;PTR:unknown-62-198.xilinx.com;CAT:NONE;SFS:(4636009)(396003)(39860400002)(346002)(136003)(376002)(46966006)(36840700001)(26005)(9786002)(426003)(36860700001)(47076005)(478600001)(82310400003)(2616005)(6916009)(70206006)(7696005)(6666004)(7636003)(8676002)(70586007)(186003)(107886003)(8936002)(2906002)(4326008)(54906003)(5660300002)(36756003)(336012)(356005)(316002)(36906005)(82740400003)(83380400001)(102446001)(37363002);DIR:OUT;SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Sep 2021 06:07:30.7817 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3d13ac05-bd98-4b27-6ce7-08d96dd7f2d7 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.62.198];Helo=[xsj-pvapexch01.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: BN1NAM02FT008.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR02MB3245 Add _dt_find_by_path() to find a matching node with path for a dt_device_node. Signed-off-by: Vikram Garhwal --- xen/common/device_tree.c | 10 ++++++++-- xen/include/xen/device_tree.h | 9 +++++++++ 2 files changed, 17 insertions(+), 2 deletions(-) diff --git a/xen/common/device_tree.c b/xen/common/device_tree.c index bfe3191..4946e83 100644 --- a/xen/common/device_tree.c +++ b/xen/common/device_tree.c @@ -297,17 +297,23 @@ struct dt_device_node *dt_find_node_by_type(struct dt_device_node *from, return np; } -struct dt_device_node *dt_find_node_by_path(const char *path) +struct dt_device_node *_dt_find_node_by_path(struct dt_device_node *dt, + const char *path) { struct dt_device_node *np; - dt_for_each_device_node(dt_host, np) + dt_for_each_device_node(dt, np) if ( np->full_name && (dt_node_cmp(np->full_name, path) == 0) ) break; return np; } +struct dt_device_node *dt_find_node_by_path(const char *path) +{ + return _dt_find_node_by_path(dt_host, path); +} + void dt_print_node_names(struct dt_device_node *dt) { struct dt_device_node *np; diff --git a/xen/include/xen/device_tree.h b/xen/include/xen/device_tree.h index dcd96b4..7cc6093 100644 --- a/xen/include/xen/device_tree.h +++ b/xen/include/xen/device_tree.h @@ -469,6 +469,15 @@ struct dt_device_node *dt_find_node_by_alias(const char *alias); */ struct dt_device_node *dt_find_node_by_path(const char *path); +/** + * _dt_find_node_by_path - Find a node matching a full DT path + * @dt_node: The device tree to search + * @path: The full path to match + * + * Returns a node pointer. + */ +struct dt_device_node *_dt_find_node_by_path(struct dt_device_node *dt, + const char *path); /** * dt_find_node_by_gpath - Same as dt_find_node_by_path but retrieve the -- 2.7.4 From xen-devel-bounces@lists.xenproject.org Thu Sep 02 06:51:00 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 06:51:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.176918.322102 (Exim 4.92) (envelope-from ) id 1mLgYr-0005C1-T7; Thu, 02 Sep 2021 06:50:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 176918.322102; Thu, 02 Sep 2021 06:50:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLgYr-00058P-Ij; Thu, 02 Sep 2021 06:50:57 +0000 Received: by outflank-mailman (input) for mailman id 176918; Thu, 02 Sep 2021 06:07:10 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLfsU-0004ds-5y for xen-devel@lists.xenproject.org; Thu, 02 Sep 2021 06:07:10 +0000 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (unknown [40.107.100.73]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 01ae88ce-0bb4-11ec-ae3e-12813bfff9fa; Thu, 02 Sep 2021 06:07:09 +0000 (UTC) Received: from DM3PR12CA0074.namprd12.prod.outlook.com (2603:10b6:0:57::18) by PH0PR02MB8501.namprd02.prod.outlook.com (2603:10b6:510:100::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.23; Thu, 2 Sep 2021 06:07:08 +0000 Received: from DM3NAM02FT042.eop-nam02.prod.protection.outlook.com (2603:10b6:0:57:cafe::8) by DM3PR12CA0074.outlook.office365.com (2603:10b6:0:57::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Thu, 2 Sep 2021 06:07:08 +0000 Received: from xsj-pvapexch01.xlnx.xilinx.com (149.199.62.198) by DM3NAM02FT042.mail.protection.outlook.com (10.13.4.213) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.4478.19 via Frontend Transport; Thu, 2 Sep 2021 06:07:07 +0000 Received: from xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) by xsj-pvapexch01.xlnx.xilinx.com (172.19.86.40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Wed, 1 Sep 2021 23:07:05 -0700 Received: from smtp.xilinx.com (172.19.127.96) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Wed, 1 Sep 2021 23:07:04 -0700 Received: from [172.19.2.115] (port=56596 helo=xsjfnuv50.xilinx.com) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1mLfsO-000F6q-Ug; Wed, 01 Sep 2021 23:07:04 -0700 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 01ae88ce-0bb4-11ec-ae3e-12813bfff9fa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gQLsUwitGlfNT7El7H4B/XS7vcpOlCuP/nodYDXRqQkXDeLL04P0W7cYSfDMKGPtH0AbUkmZFOX5nWIdLeZy6vWnUNESCqlg6nQzfS4ht43yxzw2uTaYy9KN1e88ohU+8r0KfXBxfqfxo97N1fcCiJAsl1nvZOzEiFxz1nZyzg6WLGQPOZrg35nUqc84G3fsTGCMoagz1SDvySFGmu875Brmw6ZgRgooquKEXkZUdDUaW737wPQjEzy5QO5Jpluxd6IPhCoJAeIhUVn5nQH81XdrXf3T5jtxMe0WszjetHKnjU+cuqGb5d5rJPNN1y6gaDkZeCNIewxuaMq3I346kA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qQqiWML3nRBgAmoYFeaXNgx+nXTK27DqgxYrbIIxS+4=; b=Fw8d6SeJXhmuguBjdLmY99Wwotpio0YOuUCFzzVbWSn+WsIQaw4+4/CeKH2+ruwASa4t4P2CBfm1eWis+A9Uy1jITMljZaBBxM0on3nZYre/UuU2+fHY/s3FJouDH7ZhcAfVxHURiBjTSmwlqfJsEzuuCSrEwe5Sb8RwckxRINNhzAo217+b8dQrxL8N4chvAg7CYjGXuJT97QB8GHRd3D9mAudWhgDyeJuEMfHAqcwkFiH2TTGsIicLmuKHlHKZqoBa/YP2b3l54n27o6ORY8ZHItHEsS/LB0NAxaMsXrldiyT0spy8UxYr0LrxHGt81H3kEHWLZtul+7voG8uHCw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.62.198) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qQqiWML3nRBgAmoYFeaXNgx+nXTK27DqgxYrbIIxS+4=; b=bYD62rRraU3PKWxLybe0b2QGpjErYChmHJwCmVGwIkmBM1E5XlYWcgzaj4e6pWT0oyrKQvWRm5ulz7DQcSUDue0+HedEjxHDd2px7TTkm05+bMLBB/Gg/DRY5pc/2PvDEAHU4ILDqEEqgV8WBUOV9ljDcTwJMYLi3ESjdZxo5T8= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.62.198) smtp.mailfrom=xilinx.com; lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.62.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.62.198; helo=xsj-pvapexch01.xlnx.xilinx.com; From: Vikram Garhwal To: CC: , , Vikram Garhwal Subject: [XEN][RFC PATCH 06/13] device tree: Add dt_print_node_names() Date: Wed, 1 Sep 2021 23:05:56 -0700 Message-ID: <1630562763-390068-7-git-send-email-fnu.vikram@xilinx.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1630562763-390068-1-git-send-email-fnu.vikram@xilinx.com> References: <1630562763-390068-1-git-send-email-fnu.vikram@xilinx.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3613ec78-5dcd-4519-f133-08d96dd7e514 X-MS-TrafficTypeDiagnostic: PH0PR02MB8501: X-Microsoft-Antispam-PRVS: X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-Oob-TLC-OOBClassifiers: OLM:154; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: zthyOMV3KedVnyLP35/3+eY38V0CwfqIzFmRHxK9tLY7wM6M9jxmRgrxqR8NzYhhIMkWg//XpjuzbLt1AepqGZi73OonoWXkDmTiXW27iFtgSZJVIeukVxIZlqHA/uynne6XkDwNOgniVQwpicQmOJDJwF3UjPsihvA3wXR+bZpR3cyoOgX5HKMkC14zVquC8H+xLO1OTJlBEuGZHBrtTMaH/+kzXLJYVXfCwIyf/LZswVXemlEA+zcCboGZKoFm54BAGYXe7APBk0K1L6nokdbBjNXfaE2VRYgt9fD0ddcpNqEOLvAejQdjP11hjPgdPR2LB6Z2IpjSQ1SqmryNOv4xvmvuxCWwjFzvupbrTwNJGXOyVG2J5mWeVaz3vKTOOFUnb6wGtfe4SRNC+9eHM36uUamS/k6KP+VJtbbKdixrW2ZZ0BLU72nvNINHeiFmYY7kspSOjwKPmmdqq3saD1jPQC2V67BPzILD+Lzqt1AtOlwJOax1nPF6eNFAq99Kk5wocNO2CImmhvhxuAshcJYeWTj1zhpYjL3uQa4wxlGOoCBT+mnaWE1xFsVtMlZVbbHzFbqmHiwc2iTXXugYkH9ZJm2l1R9cZNdm6eG493rQzXm5r0Y6KQRLzTJff9wknn8ON58geKCJSTQJAJ0Faf9AfLrc8/cA1BTAmqa6rR15lHk85dQdlE2P7WEHcHMY1Sah9XkS5lFRCm9E3fBBuvbMLeGfHwPMwwYd5KgErs0= X-Forefront-Antispam-Report: CIP:149.199.62.198;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:xsj-pvapexch01.xlnx.xilinx.com;PTR:unknown-62-198.xilinx.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(426003)(186003)(2616005)(6666004)(8676002)(107886003)(36756003)(7636003)(2906002)(26005)(6916009)(82310400003)(70206006)(70586007)(336012)(47076005)(316002)(36906005)(36860700001)(508600001)(7696005)(5660300002)(9786002)(4326008)(8936002)(356005)(54906003)(102446001);DIR:OUT;SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Sep 2021 06:07:07.7477 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3613ec78-5dcd-4519-f133-08d96dd7e514 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.62.198];Helo=[xsj-pvapexch01.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: DM3NAM02FT042.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR02MB8501 Add dt_print_node_names() to print all nodes under a dt_device_node. dt_print_node_names() takes a dt_device_node type input and prints the node name of all the subsequent nodes. This is added for debugging purpose for device tree overlays. Signed-off-by: Vikram Garhwal --- xen/common/device_tree.c | 10 ++++++++++ xen/include/xen/device_tree.h | 5 +++++ 2 files changed, 15 insertions(+) diff --git a/xen/common/device_tree.c b/xen/common/device_tree.c index cda21be..bfe3191 100644 --- a/xen/common/device_tree.c +++ b/xen/common/device_tree.c @@ -308,6 +308,16 @@ struct dt_device_node *dt_find_node_by_path(const char *path) return np; } +void dt_print_node_names(struct dt_device_node *dt) +{ + struct dt_device_node *np; + + dt_for_each_device_node(dt, np) + dt_dprintk("Node name: %s Full name %s\n", np->name, np->full_name); + + return; +} + int dt_find_node_by_gpath(XEN_GUEST_HANDLE(char) u_path, uint32_t u_plen, struct dt_device_node **node) { diff --git a/xen/include/xen/device_tree.h b/xen/include/xen/device_tree.h index a4e98a7..dcd96b4 100644 --- a/xen/include/xen/device_tree.h +++ b/xen/include/xen/device_tree.h @@ -483,6 +483,11 @@ struct dt_device_node *dt_find_node_by_path(const char *path); int dt_find_node_by_gpath(XEN_GUEST_HANDLE(char) u_path, uint32_t u_plen, struct dt_device_node **node); +/* + * Prints all node names. + */ +void dt_print_node_names(struct dt_device_node *dt); + /** * dt_get_parent - Get a node's parent if any * @node: Node to get parent -- 2.7.4 From xen-devel-bounces@lists.xenproject.org Thu Sep 02 06:51:00 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 06:51:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.176908.322068 (Exim 4.92) (envelope-from ) id 1mLgYp-0004dP-Tp; Thu, 02 Sep 2021 06:50:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 176908.322068; Thu, 02 Sep 2021 06:50:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLgYp-0004dI-Qn; Thu, 02 Sep 2021 06:50:55 +0000 Received: by outflank-mailman (input) for mailman id 176908; Thu, 02 Sep 2021 06:06:29 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLfro-0004YX-UW for xen-devel@lists.xenproject.org; Thu, 02 Sep 2021 06:06:29 +0000 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (unknown [40.107.95.82]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 30620bd6-43c4-461f-960f-858df19fd544; Thu, 02 Sep 2021 06:06:27 +0000 (UTC) Received: from SN1PR12CA0061.namprd12.prod.outlook.com (2603:10b6:802:20::32) by MWHPR02MB2302.namprd02.prod.outlook.com (2603:10b6:300:5b::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.17; Thu, 2 Sep 2021 06:06:25 +0000 Received: from SN1NAM02FT0022.eop-nam02.prod.protection.outlook.com (2603:10b6:802:20:cafe::27) by SN1PR12CA0061.outlook.office365.com (2603:10b6:802:20::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Thu, 2 Sep 2021 06:06:25 +0000 Received: from xsj-pvapexch02.xlnx.xilinx.com (149.199.62.198) by SN1NAM02FT0022.mail.protection.outlook.com (10.97.5.0) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.4478.19 via Frontend Transport; Thu, 2 Sep 2021 06:06:25 +0000 Received: from xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Wed, 1 Sep 2021 23:06:24 -0700 Received: from smtp.xilinx.com (172.19.127.96) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Wed, 1 Sep 2021 23:06:24 -0700 Received: from [172.19.2.115] (port=56596 helo=xsjfnuv50.xilinx.com) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1mLfrk-000F6q-6e; Wed, 01 Sep 2021 23:06:24 -0700 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 30620bd6-43c4-461f-960f-858df19fd544 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WdCUJjGX/U02no8M7aGRhNE8QGABZTwSibiGs5cryOzgLs/kXrwATPn3lxBnVgWbHy4YnkhNmJ9vi/Gw3iu1IsoRYZsyeYb88ks0uKzBAt1lo4InLlE3PJeyS2EoVae1ANmls8Zw0c8vlLwW21sCyoAjk5QpKoPbJ7NpssUqWSeT+BNHCIYOnkutkulJmrGnlcLle5auY29SvpQryqRjEYhbwOgARKEKhcE8xG9NVZ/sjY+TvlgqaOLmPjK305sXho5T3N9JJ1SCKGn+biqwgrlph9Gad4tiTM+0yi7X8whS1V2tRbZXfBEod8YrgMbjlzP1QN3WXH1wHDXh5RrymQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ubn0KOlNn2bGNNG4KibjKy56O3QZHfvA/XdfMZxo38c=; b=eHfV1Jun6/Y9BR7EOwH5D65neWPrYr2/plZLf6dfkn8VqY9EqaoI7UpYieURbUNWeKPnBfKWYuOwZY4t+wwKPEvWXy6lhh/xI8Wl17RjSoe4fEBR5FM56EhY7EvBfuufa9FfbqzYFlSbtZNMxir3XTXNjC4nkynMFnbfhgK2hIGB9LwFIVB5Bzo+Ufwukdy4vZIZaTrWvtd4DdaLkUJXFEbfVzwr8dHbaqS2w+aNJaxglqldaTOy6LsFEZYFhv4w+Hoh8Hg3v56hsn+gDX8Gtpp/zO30yh4uYPV0RwrK8K5Un5P4eO6etcL/8PT9tIwGdWyhgvMgb7pwqeJ2e2KOOQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.62.198) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ubn0KOlNn2bGNNG4KibjKy56O3QZHfvA/XdfMZxo38c=; b=cGnM3y0zqxRiK5jg0p2ffdAPvgKnhADdF8GbGtARgl8WKKjA5b1Nvccpg3yY0Ty8kTzwMcKLzL54YEKWMFGUg0jstqk18gDp+9VhG4s9Bd3qDSC3+XfB08KqT5yXIbY/R16nXbSi73MjN8sZpcIFaVYWtW9Rqsh2yqwU+5X7A1I= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.62.198) smtp.mailfrom=xilinx.com; lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.62.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.62.198; helo=xsj-pvapexch02.xlnx.xilinx.com; From: Vikram Garhwal To: CC: , , Vikram Garhwal , Volodymyr Babchuk , Jan Beulich , Paul Durrant , Andrew Cooper , George Dunlap , Ian Jackson , Wei Liu , Juergen Gross , Anthony PERARD Subject: [XEN][RFC PATCH 00/13] Add Support for dynamic Programming Date: Wed, 1 Sep 2021 23:05:50 -0700 Message-ID: <1630562763-390068-1-git-send-email-fnu.vikram@xilinx.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c9207777-2281-4bf2-ad36-08d96dd7cba0 X-MS-TrafficTypeDiagnostic: MWHPR02MB2302: X-Microsoft-Antispam-PRVS: X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: w5KHpqXz4mYyBcpsuTSzM1/Vs0D8q4a4ugCmQ4Zt5HjOK7r74D79y6at2F9MD4tBfQgGX5ah0FsXMIfbtFaQf2g75IyayA3OF4DQNNikPdermzCZqejLTtU1UOrQzGksKF7yxZNfw4d1+xH0YgZ77lVwm7CxgJ8hpL8qQDVHQye58WByKUYwueqlUUBKcWieni8oGElTYoqFD5vxl3F/5FX4vhHm4DtrJ/WQc0rgp5HSCmTxWBqLE4qGH0gU4OZxqIIi8RIxSRHOeuL7mtJtVFD+d7mV4RkmFpCvIS99PIu5z8I2Es/kbkbBz59vf/ie8JP1KH+C2XYsSJinyPcUjQR/JiHqPunqWQatusp9ytnuhwXEixL4VmrUndUsZE60LQRZ5PgBv0rihWIEyc1bzZ3ZXcR+yA69aGJ2kuzOIdkJgN/pSZv5PhpshX9HL9TNDEJYq++8iTkHijXnbKlsXMSZ7cUtyXsr6H8T+5Bg4VQSNdc4yW2wnBLyT2rSDrx1GvHEVKKg81b4g3NGSGYergvwLsWJAPkk1w813t8xFRuqIenU7CEJfI0f0zMs4sxgP6GAuy2OY3YRIkvUMVFHc3APFX4qVdO/wTCOUSn7yDMPBpeGETqRIT1kcGAv5qyF5Ygigf7nci+HRCbg9+2dE8I/fHmgmw6oZjBHHSlvoxBWHNXiTqNJTSsoTlWlmqA6Vkn7PyCrR7ZF25zXvQCgdcPnZ+4RJ+MRtbKO+ankrak= X-Forefront-Antispam-Report: CIP:149.199.62.198;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:xsj-pvapexch02.xlnx.xilinx.com;PTR:unknown-62-198.xilinx.com;CAT:NONE;SFS:(4636009)(136003)(376002)(39860400002)(396003)(346002)(46966006)(36840700001)(82310400003)(4326008)(2616005)(426003)(2906002)(356005)(186003)(82740400003)(8676002)(36860700001)(6666004)(36756003)(70586007)(70206006)(83380400001)(7636003)(478600001)(336012)(5660300002)(7696005)(47076005)(36906005)(54906003)(7416002)(316002)(9786002)(26005)(8936002)(6916009)(102446001);DIR:OUT;SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Sep 2021 06:06:25.0547 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c9207777-2281-4bf2-ad36-08d96dd7cba0 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.62.198];Helo=[xsj-pvapexch02.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: SN1NAM02FT0022.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR02MB2302 Hi, This RFC patch series is for introducing dynamic programming i.e. add/remove the devices during run time. Using "xl fpga-add" a device can be added with dtbo. fdt_overlay.c file is taken from Linux and other existing fdt files are modified to accommodate the fdt_overlay. The changes w.r.t. existing fdt are kept minimal i.e. only the required library file/functions from Linux fdt are pulled in. For adding a node using dynamic programming: 1. flatten device tree overlay node will be added to a fdt 2. Updated fdt will be unflattened to a new dt_host_new 3. Extract the newly added node information from dt_host_new 4. Add the added node under correct parent in original dt_host. 3. Map interrupt and iomem region as required. For removing a node: 1. Find the node with given path. 2. Check if the node is used by any of dom0 or domus. Removes the node only when it's not used by any domain. 3. Removes IRQ permissions and MMIO access. 5. Find the node in dt_host and delete the device node entry from dt_host. 6. Free the overlay_tracker entry which means free dt_host_new also(created in adding node step). fpga-add and fpga-del are probably not the best names for these commands. This was done initially for xilinx FPGA programmable logic block dynamic programming. I am okay with replacing fpga-add and fpga-del with better names if there are any suggestions. Regards, Vikram Vikram Garhwal (13): device tree: Remove __init from function type libfdt: Keep fdt functions after init. libfdt: import fdt_overlay from Linux libfdt: Copy required libfdt functions from Linux libfdt: Change overlay_get_target() type device tree: Add dt_print_node_names() device tree: Add _dt_find_node_by_path() to find nodes in device tree xen/iommu: Introduce iommu_remove_dt_devices function xen/arm: Implement device tree node removal functionalities xen/arm: Implement device tree node addition functionalities tools/libs/ctrl: Implement new xc interfaces for fpga-add and fpga-del tools/libs/light: Implement new libxl functions for fpga-add and fpga-del tools/xl: Add new xl commands fpga-add and fpga-del tools/include/libxl.h | 5 + tools/include/xenctrl.h | 4 + tools/libs/ctrl/Makefile | 1 + tools/libs/ctrl/xc_fpga.c | 82 ++++ tools/libs/light/Makefile | 1 + tools/libs/light/libxl_fpga.c | 73 +++ tools/xl/xl.h | 2 + tools/xl/xl_cmdtable.c | 12 + tools/xl/xl_vmcontrol.c | 51 ++ xen/arch/arm/Makefile | 2 +- xen/arch/arm/domain_build.c | 15 +- xen/arch/arm/domctl.c | 445 +++++++++++++++++ xen/common/device_tree.c | 143 +++++- xen/common/libfdt/Makefile | 1 - xen/common/libfdt/Makefile.libfdt | 2 +- xen/common/libfdt/fdt.c | 35 ++ xen/common/libfdt/fdt_overlay.c | 884 ++++++++++++++++++++++++++++++++++ xen/common/libfdt/fdt_ro.c | 52 +- xen/common/libfdt/fdt_rw.c | 81 +++- xen/common/libfdt/fdt_wip.c | 20 + xen/common/libfdt/libfdt_internal.h | 130 +++++ xen/drivers/passthrough/arm/smmu.c | 53 ++ xen/drivers/passthrough/device_tree.c | 30 ++ xen/include/asm-arm/domain_build.h | 10 + xen/include/public/domctl.h | 16 + xen/include/xen/device_tree.h | 21 + xen/include/xen/iommu.h | 2 + xen/include/xen/libfdt/libfdt.h | 232 ++++++++- 28 files changed, 2363 insertions(+), 42 deletions(-) create mode 100644 tools/libs/ctrl/xc_fpga.c create mode 100644 tools/libs/light/libxl_fpga.c create mode 100644 xen/common/libfdt/fdt_overlay.c -- 2.7.4 From xen-devel-bounces@lists.xenproject.org Thu Sep 02 06:51:00 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 06:51:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.176913.322087 (Exim 4.92) (envelope-from ) id 1mLgYr-0004t7-0L; Thu, 02 Sep 2021 06:50:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 176913.322087; Thu, 02 Sep 2021 06:50:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLgYq-0004qA-Mm; Thu, 02 Sep 2021 06:50:56 +0000 Received: by outflank-mailman (input) for mailman id 176913; Thu, 02 Sep 2021 06:07:05 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLfsP-0004aK-62 for xen-devel@lists.xenproject.org; Thu, 02 Sep 2021 06:07:05 +0000 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (unknown [2a01:111:f400:7ea9::620]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 8dbdcee9-9b09-417a-9938-75d68b68fcde; Thu, 02 Sep 2021 06:07:04 +0000 (UTC) Received: from SN6PR08CA0015.namprd08.prod.outlook.com (2603:10b6:805:66::28) by DM6PR02MB5963.namprd02.prod.outlook.com (2603:10b6:5:150::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.17; Thu, 2 Sep 2021 06:07:01 +0000 Received: from SN1NAM02FT0033.eop-nam02.prod.protection.outlook.com (2603:10b6:805:66:cafe::27) by SN6PR08CA0015.outlook.office365.com (2603:10b6:805:66::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Thu, 2 Sep 2021 06:07:01 +0000 Received: from xsj-pvapexch02.xlnx.xilinx.com (149.199.62.198) by SN1NAM02FT0033.mail.protection.outlook.com (10.97.5.40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.4478.19 via Frontend Transport; Thu, 2 Sep 2021 06:07:00 +0000 Received: from xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Wed, 1 Sep 2021 23:06:53 -0700 Received: from smtp.xilinx.com (172.19.127.96) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Wed, 1 Sep 2021 23:06:53 -0700 Received: from [172.19.2.115] (port=56596 helo=xsjfnuv50.xilinx.com) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1mLfsD-000F6q-LT; Wed, 01 Sep 2021 23:06:53 -0700 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8dbdcee9-9b09-417a-9938-75d68b68fcde ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kjYN5gRN41ONS/9py890LcpPZatY8XZoRIXzL4G1r2Fv+MDCZ6TA1BJpViPe9TMa95LQq249H/uWXqzYGBca1ndVn8vRQslgXx68qicKNWOFYiB9gclZjFvJu+2s+eOkpDIKc8cZfRjaiz3KGHNZmHag77JSio/RziVaNqnUrxpVUgCiGVdbvjBvFdT9iIyDPEhdfCzZtmWNj8otE0U/t3MEHxHLHjuyGo/lLTvAFZ6vTDAOp1+nfWbzCUUeo7jzEgqAX0C15cEec9fEUtmmJobhXxkDaJVI+U7jqv7tIgC99xpi+fW5dBEZtVZkT/jIJRSbw+HqxBuXCvxU6QbglA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=ZeeTflOXr2fLy1zXz1tSECVgWqlU5geTYJsntNlox3s=; b=OF+IgvEhO5Y5P+PZkSDmLjnOguHEuvAr7js1bLekz+GPSoYqZS4ZvstfYo+XHHrB2pSiX9z9pgRmuw3UBl8w9n5tZ9rINAG1Md+0QpyQBh64B+rdbFxcmD3j1Ata26vC9AOzbNI7XeBEGcQeliqMrX6qYB/FCgzv3luuvIbfLy4kfnC1jAUcwtw/H5w9jcnbeIllWoQDN0PPiHWt+afr/AWdfz5el+im+AEc0ZraXq9vafa6zLhGWOmysMMFRFHsZkvMl6XMZqFqJiAMFp7bfpLAJwLSZ/1+qIMJCNZnEPQEJNJVGZ/KSfkfO9g7Y1gMWyXNYu+Z6DKy74qMI0QoQA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.62.198) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZeeTflOXr2fLy1zXz1tSECVgWqlU5geTYJsntNlox3s=; b=eo4dZRj8Dg/W/uPTz4yYReeQwF2MlpnkcUwpSlWoSbdvtIdY2FQoM9GT3vHowOSGar5hcJNf8m1nxWchrO/Ih7Pf1LJr5rlO6WyVJEwxpox5N5MDDGe5B54r9T7YSKdrE3dHCwNwZS3CbXh0REORFjjw7Uy2jflkVIeDcko72PU= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.62.198) smtp.mailfrom=xilinx.com; lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.62.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.62.198; helo=xsj-pvapexch02.xlnx.xilinx.com; From: Vikram Garhwal To: CC: , , Vikram Garhwal Subject: [XEN][RFC PATCH 02/13] libfdt: Keep fdt functions after init. Date: Wed, 1 Sep 2021 23:05:52 -0700 Message-ID: <1630562763-390068-3-git-send-email-fnu.vikram@xilinx.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1630562763-390068-1-git-send-email-fnu.vikram@xilinx.com> References: <1630562763-390068-1-git-send-email-fnu.vikram@xilinx.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2b4bb6bb-5988-4c66-fc7d-08d96dd7e0bc X-MS-TrafficTypeDiagnostic: DM6PR02MB5963: X-Microsoft-Antispam-PRVS: X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-Oob-TLC-OOBClassifiers: OLM:162; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: BMAij+jdIAVuLQQq++CAx7Fjpjid4kCxlOJKB2jkx8H22EVbZIYETpXZY/UCpQf/T2eT7XXOTWRRjj8OF2mjIeVhcDSjAXf2TXVcDU2nWjOBSl4tDRrZQfm6q7mAIxfBzj4zFCy4zmpKJfisMkJPsQPL4MIAs8c04MIszjuOfyeCALzoSLlpUy5gGw88m6lLR0wgiuFFNGj42Cpfe8kB98CAheKbvbTFYNIrTE84nFqeftyoDOzR02CYdRR+ddYaf5EfOoOMRHrsgOSSBoORg2sF67apzaLYJ1tpCb/Z8xO3Bnomk3rNqcVkcqCvV78T0bKwskjGuJutelYrTPIdUohIe1FdNCeGsKrHwCeEDTM9fveL5mYqHR+eur7B0iqImCEreEFDz/uS9/x74uzGUeAZ3dgTnCNq0XPc5WiBEYXSQeIIBNFxZxuD9uy/yvp+bLCeVvjsTcZUvWRq9BO4CTj2yISC+0KAdAa5Xun7PlWMHnbRje3B2iLunyjgLwI+4CuVXa4lSAArDotueBp0wsy4sUia65pDcBvPZkeqQP1jA5ymA5daNrjsvW7Npq61RMRGUWVeDyX5hjatss6JDfroF2Kp4jXwhlI3xmMB0FJxCwulIZWvQo/dx8oEssY92/wNy1h8FraBUd7oO9qDIRGsoxCrhJ6x84O5jAlATBkOmsXWEOqwihkB1J+aJLRSAdVZISWikNhQ5mj+tO7dhxHgvVbObyCnivnsMsMeIYo= X-Forefront-Antispam-Report: CIP:149.199.62.198;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:xsj-pvapexch02.xlnx.xilinx.com;PTR:unknown-62-198.xilinx.com;CAT:NONE;SFS:(4636009)(346002)(396003)(39860400002)(376002)(136003)(46966006)(36840700001)(4326008)(356005)(70586007)(336012)(107886003)(426003)(478600001)(82310400003)(70206006)(36860700001)(6916009)(2616005)(47076005)(186003)(7636003)(26005)(83380400001)(82740400003)(5660300002)(9786002)(54906003)(7696005)(8936002)(36756003)(2906002)(8676002)(36906005)(316002)(4744005)(102446001);DIR:OUT;SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Sep 2021 06:07:00.4714 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2b4bb6bb-5988-4c66-fc7d-08d96dd7e0bc X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.62.198];Helo=[xsj-pvapexch02.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: SN1NAM02FT0033.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR02MB5963 Keep libfdt library functionalities after boot of hw_domain. This is done to access fdt library function which are required for adding device tree overlay nodes for dynamic programming of nodes. Signed-off-by: Vikram Garhwal --- xen/common/libfdt/Makefile | 1 - 1 file changed, 1 deletion(-) diff --git a/xen/common/libfdt/Makefile b/xen/common/libfdt/Makefile index 6bd207c..8002f8c 100644 --- a/xen/common/libfdt/Makefile +++ b/xen/common/libfdt/Makefile @@ -1,7 +1,6 @@ include Makefile.libfdt SECTIONS := text data $(SPECIAL_DATA_SECTIONS) -OBJCOPYFLAGS := $(foreach s,$(SECTIONS),--rename-section .$(s)=.init.$(s)) obj-y += libfdt.o nocov-y += libfdt.o -- 2.7.4 From xen-devel-bounces@lists.xenproject.org Thu Sep 02 06:51:00 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 06:51:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.176910.322072 (Exim 4.92) (envelope-from ) id 1mLgYq-0004ff-7B; Thu, 02 Sep 2021 06:50:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 176910.322072; Thu, 02 Sep 2021 06:50:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLgYq-0004f4-3V; Thu, 02 Sep 2021 06:50:56 +0000 Received: by outflank-mailman (input) for mailman id 176910; Thu, 02 Sep 2021 06:06:48 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLfs8-0004ZP-Ju for xen-devel@lists.xenproject.org; Thu, 02 Sep 2021 06:06:48 +0000 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (unknown [40.107.92.53]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id f479392f-0bb3-11ec-ae3e-12813bfff9fa; Thu, 02 Sep 2021 06:06:47 +0000 (UTC) Received: from DM5PR07CA0167.namprd07.prod.outlook.com (2603:10b6:3:ee::33) by DM6PR02MB4218.namprd02.prod.outlook.com (2603:10b6:5:a0::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4436.22; Thu, 2 Sep 2021 06:06:45 +0000 Received: from DM3NAM02FT050.eop-nam02.prod.protection.outlook.com (2603:10b6:3:ee:cafe::29) by DM5PR07CA0167.outlook.office365.com (2603:10b6:3:ee::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Thu, 2 Sep 2021 06:06:45 +0000 Received: from xsj-pvapexch01.xlnx.xilinx.com (149.199.62.198) by DM3NAM02FT050.mail.protection.outlook.com (10.13.5.53) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.4478.19 via Frontend Transport; Thu, 2 Sep 2021 06:06:45 +0000 Received: from xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) by xsj-pvapexch01.xlnx.xilinx.com (172.19.86.40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Wed, 1 Sep 2021 23:06:44 -0700 Received: from smtp.xilinx.com (172.19.127.96) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Wed, 1 Sep 2021 23:06:44 -0700 Received: from [172.19.2.115] (port=56596 helo=xsjfnuv50.xilinx.com) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1mLfs4-000F6q-1L; Wed, 01 Sep 2021 23:06:44 -0700 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f479392f-0bb3-11ec-ae3e-12813bfff9fa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=W9cc6jUikAlp+4tIMYtHViI3oxKr/q1xm+LoyryDZHotnMiUXsZgpfvUIHty6EejDMZNwtXqhJ4BzJnBD6K5nNAmAqrk9sTOElDdhpOYjgcohynI6CCOkXXzBYScsJAuXa2CVB3U6mQD5XbQql66mkorGckbhNeOU3mjNbNIeNQke9JP1vUyJSbQVZEctoLMoAqeumBjLgBNgYB63xhURgjNno9VkV5gTJRbfg6vfXG1qFbG4vrL50If1CPtKfkIitJj0JHTgqOO6Yh+aB0P8m2vBB0CyS3LtGyNnheKWa3Uxhpm+8hbCbCsruwx/aHDLp7k4ms0dh1xcjiMwnsZEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=p0sULzvu56yUkRR8j2QyEg/IiWAf0h/83PzvUjdhg/o=; b=mPdDmT3Baq+YiuR8uzEKBZhOsWrbumyFJsNnoIyMcvi0YQbxAdwVPtm00y9H40s7hz0zmfqtFyw7W/uyr6se3CD0xoafNwty2IuJ5rhCn9oe1kce/lI+kqxLGhvnROdoaVygFtThXelxQ/72qCSSM/R8ZmkHsZdeb/q3mFZ3YwMcPc83A64ReGEjREV5o+U3BmqrA3KRAXFDWlyLzJ7PL6nfGEmXCks8KtbINCmOwG2SC5JVbb1mw5pVNk1Z9OBSpQH+mtPE+zhsIX5fP60GE8mrxD+Ct6/mT+1GlOMIkVdlMG4RAFp2duNGaJnYxYKpw3x/UlRzsOXCGabQJU4C8A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.62.198) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=p0sULzvu56yUkRR8j2QyEg/IiWAf0h/83PzvUjdhg/o=; b=TiuU8dH4jgG+X2FlI0nGaDbqiNe+3eB17iIgiAudaWv47XmqislETrrLTz1wKXNThHGL0Jc4aCKMr+LI+L4lpEy4DEwj/TFVQmJCkQax8Dz0rhWqm9aEM/KVzmnn3D1dx5pz+rLxqrZLLwhBfN0oU3pt5UWQgndjjWPmbHhdUaQ= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.62.198) smtp.mailfrom=xilinx.com; lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.62.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.62.198; helo=xsj-pvapexch01.xlnx.xilinx.com; From: Vikram Garhwal To: CC: , , Vikram Garhwal , Volodymyr Babchuk Subject: [XEN][RFC PATCH 01/13] device tree: Remove __init from function type Date: Wed, 1 Sep 2021 23:05:51 -0700 Message-ID: <1630562763-390068-2-git-send-email-fnu.vikram@xilinx.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1630562763-390068-1-git-send-email-fnu.vikram@xilinx.com> References: <1630562763-390068-1-git-send-email-fnu.vikram@xilinx.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2b402bf5-966b-4cbd-aa4a-08d96dd7d797 X-MS-TrafficTypeDiagnostic: DM6PR02MB4218: X-Microsoft-Antispam-PRVS: X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-Oob-TLC-OOBClassifiers: OLM:5516; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0HMU2JX5WpfuP5g1RAWmdCLTpQ2YBrd+IW8uYGBCTUstQQxgphy0rUMYUt6hGkyZyazn4d/7zTjiT6Qs9aBLxgrUa1osuklJGTortSVQXmNa2Fk1PSvTS5UZ7XopWxT9ACqkIQ3QmUrWlONzxiztbYVJyAUzffYwkSfPxq9ylwe7eebs5mpWjHQ2md5gsBGbmuYeuZ6UXogEiNyruqJvRmJ9B9wW61t5hkmjSZZac8CBSicVuKJxF81n3gO73wrmUMgpDwrqah9ZOoUGPj12ng8p9163AHDUA18F3OzYihHUMDpOxjbzQ035AUO8q8SDDmer1bzZOR94FLB2IeZ9VxOx47Vb+bH+/7g5SJRpKlK2vl9XMeaOVSvkp3vLoegbmPx2ECrc3JNdsd1nCYyso95LMSI4+nqXCjRdoeJs3U28xgo1xxfy0mBJwgF1seqyGds8TOOp1NIZKQymAFlQ3cO3oSollbCjTlUJtwRgqRRZljP1yvcPFckjTJoih728lyyHXZkjd3GiDAh+WE338kkxxmJNZAUGmjrI57OGqXLgosygNdf+ILmpSHOnT0L4HWczSOZ0843VoMjjJVzpmS4M7QXJriz5w/fIyG6xhZG9y92GXLLzYoRgbhspZpV8gFj3jPhEoBOTSVTvY8Nv9RplCal5xwO844n62nAyeOX3+p/Gy6IHbfhKGK2x7pzUYBrOYaq9M2DM1DnXcP2pITiYQM4+Ef5fVAQuiqVuJk8= X-Forefront-Antispam-Report: CIP:149.199.62.198;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:xsj-pvapexch01.xlnx.xilinx.com;PTR:unknown-62-198.xilinx.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(6666004)(2906002)(54906003)(508600001)(8936002)(8676002)(2616005)(70206006)(426003)(6916009)(36756003)(5660300002)(7696005)(36860700001)(83380400001)(36906005)(82310400003)(26005)(336012)(316002)(4326008)(70586007)(356005)(9786002)(186003)(47076005)(7636003)(102446001);DIR:OUT;SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Sep 2021 06:06:45.1163 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2b402bf5-966b-4cbd-aa4a-08d96dd7d797 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.62.198];Helo=[xsj-pvapexch01.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: DM3NAM02FT050.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR02MB4218 Change function type of following function to access during runtime: 1. handle_device_interrupt() 2. map_irq_to_domain() 3. map_range_to_domain() 4. unflatten_dt_node() 5. unflatten_device_tree() Remove .init from domain_build.o and move map_range_data declaration to domain_build.h. These changes are done to support the dynamic programming of a nodes where an overlay node will be added to fdt and unflattened node will be added to dt_host. Furthermore, irq and mmio mapping will be done for the added node. Signed-off-by: Vikram Garhwal --- xen/arch/arm/Makefile | 2 +- xen/arch/arm/domain_build.c | 15 ++++----------- xen/common/device_tree.c | 18 +++++++++--------- xen/include/asm-arm/domain_build.h | 10 ++++++++++ xen/include/xen/device_tree.h | 5 +++++ 5 files changed, 29 insertions(+), 21 deletions(-) diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile index 3d3b97b..bef4517 100644 --- a/xen/arch/arm/Makefile +++ b/xen/arch/arm/Makefile @@ -15,7 +15,7 @@ obj-y += decode.o obj-y += device.o obj-$(CONFIG_IOREQ_SERVER) += dm.o obj-y += domain.o -obj-y += domain_build.init.o +obj-y += domain_build.o obj-y += domctl.o obj-$(CONFIG_EARLY_PRINTK) += early_printk.o obj-y += gic.o diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index 206038d..3a457d3 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -47,12 +47,6 @@ static int __init parse_dom0_mem(const char *s) } custom_param("dom0_mem", parse_dom0_mem); -struct map_range_data -{ - struct domain *d; - p2m_type_t p2mt; -}; - /* Override macros from asm/page.h to make them work with mfn_t */ #undef virt_to_mfn #define virt_to_mfn(va) _mfn(__virt_to_mfn(va)) @@ -1144,7 +1138,7 @@ int __init make_chosen_node(const struct kernel_info *kinfo) return res; } -int __init map_irq_to_domain(struct domain *d, unsigned int irq, +int map_irq_to_domain(struct domain *d, unsigned int irq, bool need_mapping, const char *devname) { int res; @@ -1210,7 +1204,7 @@ static int __init map_dt_irq_to_domain(const struct dt_device_node *dev, return 0; } -static int __init map_range_to_domain(const struct dt_device_node *dev, +int map_range_to_domain(const struct dt_device_node *dev, u64 addr, u64 len, void *data) { @@ -1300,9 +1294,8 @@ static int __init map_device_children(struct domain *d, * < 0 error * 0 success */ -static int __init handle_device_interrupts(struct domain *d, - struct dt_device_node *dev, - bool need_mapping) +int handle_device_interrupts(struct domain *d, struct dt_device_node *dev, + bool need_mapping) { unsigned int i, nirq; int res; diff --git a/xen/common/device_tree.c b/xen/common/device_tree.c index 03d25a8..cda21be 100644 --- a/xen/common/device_tree.c +++ b/xen/common/device_tree.c @@ -1750,12 +1750,12 @@ int dt_count_phandle_with_args(const struct dt_device_node *np, * @allnextpp: pointer to ->allnext from last allocated device_node * @fpsize: Size of the node path up at the current depth. */ -static unsigned long __init unflatten_dt_node(const void *fdt, - unsigned long mem, - unsigned long *p, - struct dt_device_node *dad, - struct dt_device_node ***allnextpp, - unsigned long fpsize) +static unsigned long unflatten_dt_node(const void *fdt, + unsigned long mem, + unsigned long *p, + struct dt_device_node *dad, + struct dt_device_node ***allnextpp, + unsigned long fpsize) { struct dt_device_node *np; struct dt_property *pp, **prev_pp = NULL; @@ -1986,7 +1986,7 @@ static unsigned long __init unflatten_dt_node(const void *fdt, } /** - * __unflatten_device_tree - create tree of device_nodes from flat blob + * unflatten_device_tree - create tree of device_nodes from flat blob * * unflattens a device-tree, creating the * tree of struct device_node. It also fills the "name" and "type" @@ -1995,7 +1995,7 @@ static unsigned long __init unflatten_dt_node(const void *fdt, * @fdt: The fdt to expand * @mynodes: The device_node tree created by the call */ -static void __init __unflatten_device_tree(const void *fdt, +void unflatten_device_tree(const void *fdt, struct dt_device_node **mynodes) { unsigned long start, mem, size; @@ -2118,7 +2118,7 @@ dt_find_interrupt_controller(const struct dt_device_match *matches) void __init dt_unflatten_host_device_tree(void) { - __unflatten_device_tree(device_tree_flattened, &dt_host); + unflatten_device_tree(device_tree_flattened, &dt_host); dt_alias_scan(); } diff --git a/xen/include/asm-arm/domain_build.h b/xen/include/asm-arm/domain_build.h index 34ceddc..17449b1 100644 --- a/xen/include/asm-arm/domain_build.h +++ b/xen/include/asm-arm/domain_build.h @@ -4,10 +4,20 @@ #include #include +struct map_range_data +{ + struct domain *d; + p2m_type_t p2mt; +}; + int map_irq_to_domain(struct domain *d, unsigned int irq, bool need_mapping, const char *devname); int make_chosen_node(const struct kernel_info *kinfo); void evtchn_allocate(struct domain *d); +int handle_device_interrupts(struct domain *d, struct dt_device_node *dev, + bool need_mapping); +int map_range_to_domain(const struct dt_device_node *dev, u64 addr, u64 len, + void *data); #ifndef CONFIG_ACPI static inline int prepare_acpi(struct domain *d, struct kernel_info *kinfo) diff --git a/xen/include/xen/device_tree.h b/xen/include/xen/device_tree.h index b02696b..a4e98a7 100644 --- a/xen/include/xen/device_tree.h +++ b/xen/include/xen/device_tree.h @@ -177,6 +177,11 @@ int device_tree_for_each_node(const void *fdt, int node, */ void dt_unflatten_host_device_tree(void); +/* + * unflatten any device tree. + */ +void unflatten_device_tree(const void *fdt, struct dt_device_node **mynodes); + /** * IRQ translation callback * TODO: For the moment we assume that we only have ONE -- 2.7.4 From xen-devel-bounces@lists.xenproject.org Thu Sep 02 06:51:00 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 06:51:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.176926.322132 (Exim 4.92) (envelope-from ) id 1mLgYu-0005n8-5L; Thu, 02 Sep 2021 06:51:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 176926.322132; Thu, 02 Sep 2021 06:50:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLgYt-0005kp-Co; Thu, 02 Sep 2021 06:50:59 +0000 Received: by outflank-mailman (input) for mailman id 176926; Thu, 02 Sep 2021 06:07:38 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLfsv-0004hX-Ty for xen-devel@lists.xenproject.org; Thu, 02 Sep 2021 06:07:37 +0000 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (unknown [40.107.243.58]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id d71d7a5a-f0b0-458d-8457-d905d920e6b9; Thu, 02 Sep 2021 06:07:36 +0000 (UTC) Received: from SA0PR11CA0187.namprd11.prod.outlook.com (2603:10b6:806:1bc::12) by MWHPR02MB2606.namprd02.prod.outlook.com (2603:10b6:300:44::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.17; Thu, 2 Sep 2021 06:07:35 +0000 Received: from SN1NAM02FT0051.eop-nam02.prod.protection.outlook.com (2603:10b6:806:1bc:cafe::47) by SA0PR11CA0187.outlook.office365.com (2603:10b6:806:1bc::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.17 via Frontend Transport; Thu, 2 Sep 2021 06:07:35 +0000 Received: from xsj-pvapexch02.xlnx.xilinx.com (149.199.62.198) by SN1NAM02FT0051.mail.protection.outlook.com (10.97.5.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.4478.19 via Frontend Transport; Thu, 2 Sep 2021 06:07:34 +0000 Received: from xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Wed, 1 Sep 2021 23:07:13 -0700 Received: from smtp.xilinx.com (172.19.127.96) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Wed, 1 Sep 2021 23:07:13 -0700 Received: from [172.19.2.115] (port=56596 helo=xsjfnuv50.xilinx.com) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1mLfsX-000F6q-F6; Wed, 01 Sep 2021 23:07:13 -0700 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d71d7a5a-f0b0-458d-8457-d905d920e6b9 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PwWMyGPlBKtFHj1zM/gtcQiLwDgH+yShnsoTOJSsSbOnxUVjkYii203fAKF2tfN3J0iRBuAX9wx2as5wSlKlDt7V+FZrd5iC0gVGQmYWWG6l1u2+ald2Ldc28FAhqxaxOqHB95/lLOX0PQ6w9Uf+eziftZfbnhPOZPC4nlsOK8vd6eHFz2IGUuP2CYDoC7lqInZ7kIp9FnGC+b2SqJCkMEoYcQjlpokiCL4h7ppC7IrStudyGvXuVfRJ1OuYls8OmMwPwoS/unmsvEVPgF+rhyFN00spTN9ZDa1lN8WsIyt7iDsLSrm/KNbWnGNkaRbrpvr2JtRAxwcQcOOwNzZZpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=EVas2kXYqY8J1i69hD1pnLTQnzKqbS4jKsdjLz6x97c=; b=baGfgKv6wfpslNLcyv4rKCbR3vhTEl/V+OdFy+IgivH9xZIn3/bMExf23cMh7y5/jpnd9xauUSY+AQopw3w2txn1uXKketaIOsJ9OE96cbKG8aOyLa+/RvbFZ33Uoa7wfbcWnx3buXcylsfn7L8sElihGqZIUKiUn+imUsnMxQcuvuTBjh1wWN6YaOXhpaCkf2vvWBC0PXRpMOd5b1OwiUMgmRyVdYf2DpvDx325qbPUsd2ZieSnwbQp6m/NYoDF90spKygJvB4ITpEYVyGH8hwE4+3SlbWGxcCjRbVdCNbrnCuFGFQk50cJvNXa6LFZxpPRXK7uYgoB2G1ntl4guA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.62.198) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EVas2kXYqY8J1i69hD1pnLTQnzKqbS4jKsdjLz6x97c=; b=OhDJ97JWnZlQmoCvp1jgfKBkXfc7CTrXRjx9a1itEgWqm+nvR8rkYqPd8FEVw2kYPd3cEUQhMrGgpdT85MROte2W9HmBJLrRE6QRIrg35hC2a3+dMECG4dqdsnbXG30TvYW1g4f8/V9tmF/jQQc2SBdGJdPfTKe99GV9/AcniQ8= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.62.198) smtp.mailfrom=xilinx.com; lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.62.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.62.198; helo=xsj-pvapexch02.xlnx.xilinx.com; From: Vikram Garhwal To: CC: , , Vikram Garhwal , Volodymyr Babchuk , Jan Beulich , Paul Durrant Subject: [XEN][RFC PATCH 08/13] xen/iommu: Introduce iommu_remove_dt_devices function Date: Wed, 1 Sep 2021 23:05:58 -0700 Message-ID: <1630562763-390068-9-git-send-email-fnu.vikram@xilinx.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1630562763-390068-1-git-send-email-fnu.vikram@xilinx.com> References: <1630562763-390068-1-git-send-email-fnu.vikram@xilinx.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e9508a7b-7601-4ec8-4fbb-08d96dd7f529 X-MS-TrafficTypeDiagnostic: MWHPR02MB2606: X-Microsoft-Antispam-PRVS: X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-Oob-TLC-OOBClassifiers: OLM:6108; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: TMQQTZIpkWWv10Ikt+KPGzuRQXvsobuI7WlcFc7zHglAU7EPq34TwwLc8REM6x9UCzfA+OIWUlUkYBJPchPItU4BduToxXXwNtLikwy+i7xfVo7EBHiKkws/1TqNsdPhOjOeeIU4/db7oS1GreqCl1UXP0bSnlLzYoKVeaQJcWRxIWK3OO8dN0xWFGzZDiNNDOZavcS6X4K6iaKtE7loInF61Q2w+ETeuV2N5+GfUytah1iE3bB5GlQE+0G5k4eYfJpVHh1lj/GMfiKHvfJOEgpPSVRIslaa6SaVTOlidGQGcRd/E59DAmBJYDB+dOvMh0IMoxSIYMMge3QPEq9XwmUFiQMcB0gowseVr41IVhhO74seru+ixoSQZAiF4vQmR83rQ2Z66odrEQPai81dJBE9LMr6stnG5nya1WpvLFLMUVjzXWAgcl2p73NIeUjaz6xVHoDqgkJvayixjJz9K6oKBsvaimIBnHgBmo9EZuMf/fKiZMhLfCdAxzKp856xouT9IuQDMHBRiAp9LC8+wLaFFt0QgvW4seVVdPaTqKshfyFW0HghGsv2ChgU0zWonNdP/KXYv14FP+4LKIwm+HnpUKyxycO2gGqCnKjeqyMVTRrxRUKuv5DRkb+wDyVapCTNoWkgaIo5OGoUchKQhTvO2tKEC8thALJM8DI8adV44qAHjuUdRh4SwMc9JbRWtA4N4i9tD9nUU1S3CwiHfSUsqE3SfXHG7yvIsw6KMJU= X-Forefront-Antispam-Report: CIP:149.199.62.198;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:xsj-pvapexch02.xlnx.xilinx.com;PTR:unknown-62-198.xilinx.com;CAT:NONE;SFS:(4636009)(376002)(39860400002)(346002)(136003)(396003)(46966006)(36840700001)(36860700001)(186003)(336012)(36906005)(2906002)(9786002)(26005)(82740400003)(316002)(4326008)(426003)(54906003)(70206006)(70586007)(7636003)(47076005)(5660300002)(7696005)(8936002)(356005)(36756003)(82310400003)(6916009)(2616005)(478600001)(8676002)(6666004)(102446001);DIR:OUT;SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Sep 2021 06:07:34.7337 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e9508a7b-7601-4ec8-4fbb-08d96dd7f529 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.62.198];Helo=[xsj-pvapexch02.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: SN1NAM02FT0051.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR02MB2606 iommu_remove_dt_device function is introduced for supporting dynamic programming i.e. adding and removing a node during runtime. When user removes the device node, iommu_remove_dt_device() removes the device entry from smmu-masters too using following steps: 1. Find if SMMU master exists for the device node. 2. Remove the SMMU master. Signed-off-by: Vikram Garhwal --- xen/drivers/passthrough/arm/smmu.c | 53 +++++++++++++++++++++++++++++++++++ xen/drivers/passthrough/device_tree.c | 30 ++++++++++++++++++++ xen/include/xen/iommu.h | 2 ++ 3 files changed, 85 insertions(+) diff --git a/xen/drivers/passthrough/arm/smmu.c b/xen/drivers/passthrough/arm/smmu.c index c9dfc4c..7b615bc 100644 --- a/xen/drivers/passthrough/arm/smmu.c +++ b/xen/drivers/passthrough/arm/smmu.c @@ -816,6 +816,17 @@ static int insert_smmu_master(struct arm_smmu_device *smmu, return 0; } +static int remove_smmu_master(struct arm_smmu_device *smmu, + struct arm_smmu_master *master) +{ + if (!(smmu->masters.rb_node)) + return -ENOENT; + + rb_erase(&master->node, &smmu->masters); + + return 0; +} + static int arm_smmu_dt_add_device_legacy(struct arm_smmu_device *smmu, struct device *dev, struct iommu_fwspec *fwspec) @@ -853,6 +864,31 @@ static int arm_smmu_dt_add_device_legacy(struct arm_smmu_device *smmu, return insert_smmu_master(smmu, master); } +static int arm_smmu_dt_remove_device_legacy(struct arm_smmu_device *smmu, + struct device *dev) +{ + struct arm_smmu_master *master; + struct device_node *dev_node = dev_get_dev_node(dev); + int ret; + + master = find_smmu_master(smmu, dev_node); + if (master == NULL) { + dev_err(dev, + "No registrations found for master device %s\n", + dev_node->name); + return -EINVAL; + } + + ret = remove_smmu_master(smmu, master); + + if (ret) + return ret; + + master->of_node = NULL; + kfree(master); + return 0; +} + static int register_smmu_master(struct arm_smmu_device *smmu, struct device *dev, struct of_phandle_args *masterspec) @@ -876,6 +912,22 @@ static int register_smmu_master(struct arm_smmu_device *smmu, fwspec); } +static int arm_smmu_dt_remove_device_generic(u8 devfn, struct device *dev) +{ + struct arm_smmu_device *smmu; + struct iommu_fwspec *fwspec; + + fwspec = dev_iommu_fwspec_get(dev); + if (fwspec == NULL) + return -ENXIO; + + smmu = find_smmu(fwspec->iommu_dev); + if (smmu == NULL) + return -ENXIO; + + return arm_smmu_dt_remove_device_legacy(smmu, dev); +} + static int arm_smmu_dt_add_device_generic(u8 devfn, struct device *dev) { struct arm_smmu_device *smmu; @@ -2876,6 +2928,7 @@ static const struct iommu_ops arm_smmu_iommu_ops = { .init = arm_smmu_iommu_domain_init, .hwdom_init = arm_smmu_iommu_hwdom_init, .add_device = arm_smmu_dt_add_device_generic, + .remove_device = arm_smmu_dt_remove_device_generic, .teardown = arm_smmu_iommu_domain_teardown, .iotlb_flush = arm_smmu_iotlb_flush, .iotlb_flush_all = arm_smmu_iotlb_flush_all, diff --git a/xen/drivers/passthrough/device_tree.c b/xen/drivers/passthrough/device_tree.c index 98f2aa0..37f4945 100644 --- a/xen/drivers/passthrough/device_tree.c +++ b/xen/drivers/passthrough/device_tree.c @@ -127,6 +127,36 @@ int iommu_release_dt_devices(struct domain *d) return 0; } +int iommu_remove_dt_device(struct dt_device_node *np) +{ + const struct iommu_ops *ops = iommu_get_ops(); + struct device *dev = dt_to_dev(np); + int rc = 1; + + if ( !ops ) + return -EINVAL; + + if ( iommu_dt_device_is_assigned(np) ) + return -EPERM; + + /* + * The driver which supports generic IOMMU DT bindings must have + * these callback implemented. + */ + if ( !ops->remove_device ) + return -EINVAL; + + /* + * Remove master device from the IOMMU if latter is present and available. + */ + rc = ops->remove_device(0, dev); + + if ( rc == 0 ) + iommu_fwspec_free(dev); + + return rc; +} + int iommu_add_dt_device(struct dt_device_node *np) { const struct iommu_ops *ops = iommu_get_ops(); diff --git a/xen/include/xen/iommu.h b/xen/include/xen/iommu.h index 6b2cdff..c4d5d12 100644 --- a/xen/include/xen/iommu.h +++ b/xen/include/xen/iommu.h @@ -215,6 +215,8 @@ int iommu_release_dt_devices(struct domain *d); */ int iommu_add_dt_device(struct dt_device_node *np); +int iommu_remove_dt_device(struct dt_device_node *np); + int iommu_do_dt_domctl(struct xen_domctl *, struct domain *, XEN_GUEST_HANDLE_PARAM(xen_domctl_t)); -- 2.7.4 From xen-devel-bounces@lists.xenproject.org Thu Sep 02 06:51:01 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 06:51:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.176928.322136 (Exim 4.92) (envelope-from ) id 1mLgYu-0005wr-NY; Thu, 02 Sep 2021 06:51:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 176928.322136; Thu, 02 Sep 2021 06:51:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLgYt-0005sp-VH; Thu, 02 Sep 2021 06:50:59 +0000 Received: by outflank-mailman (input) for mailman id 176928; Thu, 02 Sep 2021 06:07:41 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLfsz-0004hL-EG for xen-devel@lists.xenproject.org; Thu, 02 Sep 2021 06:07:41 +0000 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (unknown [40.107.236.55]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 13554a0e-0bb4-11ec-ae3e-12813bfff9fa; Thu, 02 Sep 2021 06:07:38 +0000 (UTC) Received: from SN4PR0501CA0080.namprd05.prod.outlook.com (2603:10b6:803:22::18) by CY4PR02MB2181.namprd02.prod.outlook.com (2603:10b6:903:e::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.23; Thu, 2 Sep 2021 06:07:35 +0000 Received: from SN1NAM02FT0029.eop-nam02.prod.protection.outlook.com (2603:10b6:803:22:cafe::39) by SN4PR0501CA0080.outlook.office365.com (2603:10b6:803:22::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.6 via Frontend Transport; Thu, 2 Sep 2021 06:07:35 +0000 Received: from xsj-pvapexch02.xlnx.xilinx.com (149.199.62.198) by SN1NAM02FT0029.mail.protection.outlook.com (10.97.4.175) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.4478.19 via Frontend Transport; Thu, 2 Sep 2021 06:07:34 +0000 Received: from xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Wed, 1 Sep 2021 23:07:14 -0700 Received: from smtp.xilinx.com (172.19.127.96) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Wed, 1 Sep 2021 23:07:14 -0700 Received: from [172.19.2.115] (port=56596 helo=xsjfnuv50.xilinx.com) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1mLfsY-000F6q-R6; Wed, 01 Sep 2021 23:07:14 -0700 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 13554a0e-0bb4-11ec-ae3e-12813bfff9fa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DqkxgLDre73op25XKcR7jwvLLzEuiKnjoIesQcZcYYRcePW/Wczl6JfiC9Uir3gQK8nM3zNoTtErqKygYvEy1dkmH4H9s4dfeAcxub7lv7x/8yGC94r71oG++PKDB7197eywaey815bCUl1WDPiL8AKZgQForTwgwTew6DltJlL/GvTk59TdUROA7meHHXL0d3lvAienNWYmBxeeNvKJEwzNCesJMfJkCd0wPd22bYrW0rpilKaP9Dp0YrOpwS27MpaU4WA3ZWmtN2KLkmXp00ruvPiNHODynhRfxIUs5VHSzlRewe7EzZa2eajXfdcANqW+hcYQsQEiO2yS8zjMAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Bk58T2PdmP0MpUXqDTQL+WHaYdm6dJQvCtJfKGAwTtY=; b=Gr3IkqVkZ3nbcF2g6AmzHCrwhD7TpaUL/J623YInRRQQwNuMt0oEvfHv5RSjQtxp3YhARmZ3vE0TTPOP7MKObZb4/07WxGKA915Kle7tovwA9WvaGcIFyFQvFp9h1oKBBd6PbzfsfeI5r+XzZjGW8aPlErba6h9U94tvttjLgmLyrV3+26LieVWrzMbj6GESn/dMMgvM3MLMeCxsanApdfTAgNQVUrVt8r8O+4U0He9qiA7a0XfqalW14nCi+lmvZ/Bf53OgWkHqnfDfsAGh5qEsg6TmhfOoJaiV9vHZzNYkARYxCAWTRmSj2JRtpbVSVKNX/B5QhCDefVSLvqeucg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.62.198) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Bk58T2PdmP0MpUXqDTQL+WHaYdm6dJQvCtJfKGAwTtY=; b=mUirYEvbfTT77RlG81HQUzD6LadetmXz6xk4ERMiEy5FuyPHTdnz0h7q3CYy64U9pEAsjH9zCIHJfLSN+Tf/FuyXJKY8tprwYgxI8skLWFuHgbteNYu+lx/BMF59auKMGQqsEbFfG7K76I6T6OL/axyftPGhkQgq2eKeJDyjlQY= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.62.198) smtp.mailfrom=xilinx.com; lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.62.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.62.198; helo=xsj-pvapexch02.xlnx.xilinx.com; From: Vikram Garhwal To: CC: , , Vikram Garhwal , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Wei Liu Subject: [XEN][RFC PATCH 09/13] xen/arm: Implement device tree node removal functionalities Date: Wed, 1 Sep 2021 23:05:59 -0700 Message-ID: <1630562763-390068-10-git-send-email-fnu.vikram@xilinx.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1630562763-390068-1-git-send-email-fnu.vikram@xilinx.com> References: <1630562763-390068-1-git-send-email-fnu.vikram@xilinx.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: dce2cf17-de68-461f-9cf7-08d96dd7f531 X-MS-TrafficTypeDiagnostic: CY4PR02MB2181: X-Microsoft-Antispam-PRVS: X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-Oob-TLC-OOBClassifiers: OLM:199; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: IO8yxi2Y5dHAysq/2g414+Sg8E//eFoQU44RCwtQOiZRJ45iK2Z11EfoBqD38MwB5c6tln/ETy+B1062kNw8CAcMX+uISjGSF9J6aqN8Q/cchBpHfbvaiMQe+2zh8wDXcMXvcZDymRr3GnCkTFw1RcMAr0kR6mVqN9hz14BV3TVHAI+FJzjJTKlgWUYcVxBGecl7a+V/yWwBFEr9nJOqmRQpsPDbQGPhekageHEsJnBOKmMP181lmd1EPdHnk4E9L4ewggaOV2RbyoAkdh7Ke0nGgc6Ry+Fdle8lS2aAI1jzykBKyt0lctPLi/rRbw9VawYyEPmcLZ6/CnAEYbOTSZMboVV/lyGXSInFazTxOO4TV5O6PABU5BSj77jglhKQ7y+xZWgUk/qDeb2ReM/fEsUPW14IqA54VxYG0y+Ur+5phrSPCwu5bZEi997EHmThvGM9xWqK3lYZ/PCO4tqWn3dZaFobHt0jjwLGAEV3X0fkLc0thkUcT0YLmdw1fD2GWrMGdKSWxwH34Mziy2AlrtAba1hCoK5PJJ/sTwprTIld2ergybfXEc7IG+jdTrQiTpLrG51Ubu+yT54ov+p3J0K6RtBGfIN48j1wEXmCgtegRnQvPMf3b0i//posj6G+nNCMIVLT9wLAbDnITeaR+Z2AeRiE4sgemxCKg/m4LF0AVj8Jc5ecC/2IUqfyZXVjzYjGnk2fPxxEvohGqPshaojBjpLFjTKVIorgzprAnXjDGnZ/GSCPLlnDmOssbvQO4Q2+d2Uc5oZOPOHV6l5Ntw== X-Forefront-Antispam-Report: CIP:149.199.62.198;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:xsj-pvapexch02.xlnx.xilinx.com;PTR:unknown-62-198.xilinx.com;CAT:NONE;SFS:(4636009)(346002)(39860400002)(396003)(136003)(376002)(36840700001)(46966006)(82740400003)(36860700001)(36756003)(4326008)(6916009)(316002)(2616005)(36906005)(83380400001)(7636003)(8676002)(54906003)(47076005)(2906002)(70206006)(70586007)(6666004)(9786002)(5660300002)(7696005)(186003)(82310400003)(356005)(8936002)(26005)(478600001)(426003)(336012)(102446001)(403724002);DIR:OUT;SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Sep 2021 06:07:34.7861 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: dce2cf17-de68-461f-9cf7-08d96dd7f531 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.62.198];Helo=[xsj-pvapexch02.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: SN1NAM02FT0029.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR02MB2181 Introduce domctl XEN_DOMCTL_delfpga to remove a device-tree node added through device tree overlay. Currently, this supports removing one node at a time. DT node removal works with the following steps: 1. finds a node with given path. 2. Check if the node is used by any of dom0 or domus. It removes the node only when it's not used by any domain. 3. Removes IRQ permissions. 4. Remove MMIO access. 5. Find the node in dt_host and delete the device node entry from dt_host. 6. Free the overlay_tracker node. Also, added overlay_track struct to keep the track of added node through device tree overlay. overlay_track has dt_host_new which is unflattened form of updated fdt and name of overlay node. When a node is removed, we also free the memory used by overlay_track for the particular overlay node. Signed-off-by: Vikram Garhwal --- xen/arch/arm/domctl.c | 183 ++++++++++++++++++++++++++++++++++++++++++ xen/common/device_tree.c | 51 ++++++++++++ xen/include/public/domctl.h | 9 +++ xen/include/xen/device_tree.h | 1 + 4 files changed, 244 insertions(+) diff --git a/xen/arch/arm/domctl.c b/xen/arch/arm/domctl.c index b7d27f3..5986934 100644 --- a/xen/arch/arm/domctl.c +++ b/xen/arch/arm/domctl.c @@ -9,11 +9,34 @@ #include #include #include +#include #include #include #include #include #include +#include +#include +#include + +/* + * overlay_node_track describes information about added nodes through dtbo. + * @dt_host_new: Pointer to the updated dt_host_new unflattened 'updated fdt'. + * @node_fullname: Store the name of nodes. + * @entry: List pointer. + */ +struct overlay_track { + struct list_head entry; + struct dt_device_node *dt_host_new; + /* + * TODO: We keep max nodes to 10 in an overlay. But for now we will be + * adding one node only. + */ + char *node_fullname; +}; + +static LIST_HEAD(overlay_tracker); +static DEFINE_SPINLOCK(overlay_lock); void arch_get_domain_info(const struct domain *d, struct xen_domctl_getdomaininfo *info) @@ -45,6 +68,132 @@ static int handle_vuart_init(struct domain *d, return rc; } +/* + * First finds the device node to remove. Check if the device is being used by + * any dom and finally remove it from dt_host. IOMMU is already being taken care + * while destroying the domain. + */ +static long handle_del_fpga_nodes(char *full_dt_node_path) +{ + struct domain *d = hardware_domain; + int rc = 0; + uint32_t ret = 0; + struct dt_device_node *fpga_device; + struct overlay_track *entry, *temp; + unsigned int naddr; + unsigned int i, nirq; + struct dt_raw_irq rirq; + u64 addr, size; + + fpga_device = dt_find_node_by_path(full_dt_node_path); + + if ( fpga_device == NULL ) + { + printk(XENLOG_G_ERR "Device %s is not present in the tree\n", + full_dt_node_path); + return -EINVAL; + } + + ret = dt_device_used_by(fpga_device); + + if ( ret != 0 && ret != DOMID_IO ) + { + printk(XENLOG_G_ERR "Cannot remove the device as it is being used by" + "domain %d\n", ret); + return -EPERM; + } + + spin_lock(&overlay_lock); + + nirq = dt_number_of_irq(fpga_device); + + /* Remove IRQ permission */ + for ( i = 0; i < nirq; i++ ) + { + rc = dt_device_get_raw_irq(fpga_device, i, &rirq); + if ( rc ) + { + printk(XENLOG_ERR "Unable to retrieve irq %u for %s\n", + i, dt_node_full_name(fpga_device)); + goto out; + } + + rc = platform_get_irq(fpga_device, i); + if ( rc < 0 ) + { + printk(XENLOG_ERR "Unable to get irq %u for %s\n", + i, dt_node_full_name(fpga_device)); + goto out; + } + + rc = irq_deny_access(d, rc); + + if ( rc ) + { + printk(XENLOG_ERR "unable to revoke access for irq %u for %s\n", + i, dt_node_full_name(fpga_device)); + goto out; + } + } + + rc = iommu_remove_dt_device(fpga_device); + + if ( rc ) + goto out; + + naddr = dt_number_of_address(fpga_device); + + /* Remove mmio access. */ + for ( i = 0; i < naddr; i++ ) + { + rc = dt_device_get_address(fpga_device, i, &addr, &size); + + if ( rc ) + { + printk(XENLOG_ERR "Unable to retrieve address %u for %s\n", + i, dt_node_full_name(fpga_device)); + goto out; + } + + rc = iomem_deny_access(d, paddr_to_pfn(addr), + paddr_to_pfn(PAGE_ALIGN(addr + size - 1))); + + if ( rc ) + { + printk(XENLOG_ERR "Unable to remove dom%d access to" + " 0x%"PRIx64" - 0x%"PRIx64"\n", + d->domain_id, + addr & PAGE_MASK, PAGE_ALIGN(addr + size) - 1); + goto out; + } + } + + rc = fpga_del_node(fpga_device); + + if ( rc ) + goto out; + + list_for_each_entry_safe( entry, temp, &overlay_tracker, entry ) + { + if ( (strcmp(full_dt_node_path, entry->node_fullname) == 0) ) + { + list_del(&entry->entry); + xfree(entry->node_fullname); + xfree(entry->dt_host_new); + xfree(entry); + goto out; + } + } + + printk(XENLOG_G_ERR "Cannot find the node in tracker. Memory will not" + "be freed\n"); + rc = -ENOENT; + +out: + spin_unlock(&overlay_lock); + return rc; +} + long arch_do_domctl(struct xen_domctl *domctl, struct domain *d, XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl) { @@ -173,6 +322,40 @@ long arch_do_domctl(struct xen_domctl *domctl, struct domain *d, return rc; } + + case XEN_DOMCTL_delfpga: + { + char *full_dt_node_path; + int rc; + + if ( domctl->u.fpga_del_dt.size > 0 ) + full_dt_node_path = xmalloc_bytes(domctl->u.fpga_del_dt.size); + else + return -EINVAL; + + if ( full_dt_node_path == NULL ) + return -ENOMEM; + + rc = copy_from_guest(full_dt_node_path, + domctl->u.fpga_del_dt.full_dt_node_path, + domctl->u.fpga_del_dt.size); + if ( rc ) + { + gprintk(XENLOG_ERR, "copy from guest failed\n"); + xfree(full_dt_node_path); + + return -EFAULT; + } + + full_dt_node_path[domctl->u.fpga_del_dt.size - 1] = '\0'; + + rc = handle_del_fpga_nodes(full_dt_node_path); + + xfree(full_dt_node_path); + + return rc; + } + default: { int rc; diff --git a/xen/common/device_tree.c b/xen/common/device_tree.c index 4946e83..04f2578 100644 --- a/xen/common/device_tree.c +++ b/xen/common/device_tree.c @@ -324,6 +324,57 @@ void dt_print_node_names(struct dt_device_node *dt) return; } +int fpga_del_node(struct dt_device_node *device_node) +{ + struct dt_device_node *np; + struct dt_device_node *parent_node; + struct dt_device_node *current_node; + + parent_node = device_node->parent; + + current_node = parent_node; + + if ( parent_node == NULL ) + { + dt_dprintk("%s's parent node not found\n", device_node->name); + return -EFAULT; + } + + np = parent_node->child; + + if ( np == NULL ) + { + dt_dprintk("parent node %s's not found\n", parent_node->name); + return -EFAULT; + } + + /* If node to be removed is only child node or first child. */ + if ( np->name == device_node->name ) + { + current_node->allnext = np->next; + return 0; + } + + for ( np = parent_node->child; np->sibling != NULL; np = np->sibling ) + { + current_node = np; + if ( np->sibling->name == device_node->name ) + { + /* Found the node. Now we remove it. */ + current_node->allnext = np->allnext->allnext; + + if ( np->sibling->sibling ) + current_node->sibling = np->sibling->sibling; + else + current_node->sibling = NULL; + + break; + } + } + + return 0; +} + int dt_find_node_by_gpath(XEN_GUEST_HANDLE(char) u_path, uint32_t u_plen, struct dt_device_node **node) { diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h index 96696e3..b1b8efd 100644 --- a/xen/include/public/domctl.h +++ b/xen/include/public/domctl.h @@ -1169,6 +1169,13 @@ struct xen_domctl_vmtrace_op { typedef struct xen_domctl_vmtrace_op xen_domctl_vmtrace_op_t; DEFINE_XEN_GUEST_HANDLE(xen_domctl_vmtrace_op_t); +/* XEN_DOMCTL_fpga_del. */ +struct xen_domctl_fpga_del_dt { + XEN_GUEST_HANDLE_64(char) full_dt_node_path; + uint32_t size; +}; + + struct xen_domctl { uint32_t cmd; #define XEN_DOMCTL_createdomain 1 @@ -1254,6 +1261,7 @@ struct xen_domctl { #define XEN_DOMCTL_get_cpu_policy 82 #define XEN_DOMCTL_set_cpu_policy 83 #define XEN_DOMCTL_vmtrace_op 84 +#define XEN_DOMCTL_delfpga 86 #define XEN_DOMCTL_gdbsx_guestmemio 1000 #define XEN_DOMCTL_gdbsx_pausevcpu 1001 #define XEN_DOMCTL_gdbsx_unpausevcpu 1002 @@ -1315,6 +1323,7 @@ struct xen_domctl { struct xen_domctl_psr_alloc psr_alloc; struct xen_domctl_vuart_op vuart_op; struct xen_domctl_vmtrace_op vmtrace_op; + struct xen_domctl_fpga_del_dt fpga_del_dt; uint8_t pad[128]; } u; }; diff --git a/xen/include/xen/device_tree.h b/xen/include/xen/device_tree.h index 7cc6093..eb7f645 100644 --- a/xen/include/xen/device_tree.h +++ b/xen/include/xen/device_tree.h @@ -496,6 +496,7 @@ int dt_find_node_by_gpath(XEN_GUEST_HANDLE(char) u_path, uint32_t u_plen, * Prints all node names. */ void dt_print_node_names(struct dt_device_node *dt); +int fpga_del_node(struct dt_device_node *device_node); /** * dt_get_parent - Get a node's parent if any -- 2.7.4 From xen-devel-bounces@lists.xenproject.org Thu Sep 02 06:51:01 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 06:51:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.176930.322145 (Exim 4.92) (envelope-from ) id 1mLgYv-0006BB-CL; Thu, 02 Sep 2021 06:51:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 176930.322145; Thu, 02 Sep 2021 06:51:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLgYu-000669-Pc; Thu, 02 Sep 2021 06:51:00 +0000 Received: by outflank-mailman (input) for mailman id 176930; Thu, 02 Sep 2021 06:07:46 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLft4-0004hL-EK for xen-devel@lists.xenproject.org; Thu, 02 Sep 2021 06:07:46 +0000 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (unknown [40.107.93.85]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 1425e966-0bb4-11ec-ae3e-12813bfff9fa; Thu, 02 Sep 2021 06:07:40 +0000 (UTC) Received: from SN4PR0501CA0073.namprd05.prod.outlook.com (2603:10b6:803:22::11) by BL0PR02MB4721.namprd02.prod.outlook.com (2603:10b6:208:59::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.23; Thu, 2 Sep 2021 06:07:38 +0000 Received: from SN1NAM02FT0029.eop-nam02.prod.protection.outlook.com (2603:10b6:803:22:cafe::e9) by SN4PR0501CA0073.outlook.office365.com (2603:10b6:803:22::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.11 via Frontend Transport; Thu, 2 Sep 2021 06:07:38 +0000 Received: from xsj-pvapexch02.xlnx.xilinx.com (149.199.62.198) by SN1NAM02FT0029.mail.protection.outlook.com (10.97.4.175) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.4478.19 via Frontend Transport; Thu, 2 Sep 2021 06:07:38 +0000 Received: from xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Wed, 1 Sep 2021 23:07:17 -0700 Received: from smtp.xilinx.com (172.19.127.96) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Wed, 1 Sep 2021 23:07:17 -0700 Received: from [172.19.2.115] (port=56596 helo=xsjfnuv50.xilinx.com) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1mLfsb-000F6q-4A; Wed, 01 Sep 2021 23:07:17 -0700 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1425e966-0bb4-11ec-ae3e-12813bfff9fa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Te3CLIQwSSYtGGBlbzgNjB+UBGrhjIq38k9KB7AOSVEw/gPnlTGnHTH852/N/X7gaX5SG46VL9qkBWskLRdlMgk22CMaN3nSRlw7vY7agl7h69FaIdZx0l3BNIy6IDFC7AycymdJKo/B9SA8AS2xj45WLx7C4bCRQdXWGvwPezaeHxgIzQDBA7cz+YOENgQTuF4ywnBRySDg5jdP3feB4i44GkxbpiJAsJEQ8tYdLNorCfzutV6G9Lxp4GsdMimRQu41Bvj2iaIwRmmiY08u1OYaY1puN/yBaQzUrSbHA0hRtvja/Pp7xR0LPKiUWlm/FKB+OZAhGqP6bxsEPmIR/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PuN2b2H12aJwTeXjwq0M4sE74WKCTLZyi/JgSK4cHCM=; b=EaqN0tOBrpnsA6ddF4D8tgIRkFZgE0U6CGwWzSSAdleOzxyTKEsVTzNTcDIhC+k/atll/tzLaeAOEkZErvNO1kfaT70ONMdPGCCTzAeyZuHl7+z8RLUDZaC8MWURa7hMdelENdcF1cC7RxJukQUDIsBW8xJNWD41ERi7i2KNgeOTGOeeIaBpoeD4W+/wD941V2PVoWwRgIK/sBqxnUOOjAz0DPmGEL+cqnnaDAAzYbO8hJw2g7A8NMdio8Ud/Xmq2VmlgR72RvAgg9DMNxmaofCvLrJBU71ZYARIAffj+ngE5VQ3bGZuKz6dmYj8DMb+mDHbHEO2KsK2HxSigj26UA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.62.198) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PuN2b2H12aJwTeXjwq0M4sE74WKCTLZyi/JgSK4cHCM=; b=hkwddA76I8tqtEvqpBsYNlYYwVHbCraLiYVXg6Z7D79GDPw64Q1cKYMKkaN+vov4YExUUlIsMTb3JA9kZuSJ6Soz3OaM1TN+M8NpV6ns5XBLEsYtJe02khQd+bV4ywA8luHBgFVNInkX8sLDh6Xpv5pFTFer8bnXSA07NolVq3U= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.62.198) smtp.mailfrom=xilinx.com; lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.62.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.62.198; helo=xsj-pvapexch02.xlnx.xilinx.com; From: Vikram Garhwal To: CC: , , Vikram Garhwal , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Wei Liu Subject: [XEN][RFC PATCH 10/13] xen/arm: Implement device tree node addition functionalities Date: Wed, 1 Sep 2021 23:06:00 -0700 Message-ID: <1630562763-390068-11-git-send-email-fnu.vikram@xilinx.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1630562763-390068-1-git-send-email-fnu.vikram@xilinx.com> References: <1630562763-390068-1-git-send-email-fnu.vikram@xilinx.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 291affca-15c1-4473-a81f-08d96dd7f72b X-MS-TrafficTypeDiagnostic: BL0PR02MB4721: X-Microsoft-Antispam-PRVS: X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-Oob-TLC-OOBClassifiers: OLM:366; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0h6eZwWpeRoOmH8M/+P3RMble3LIBuH/jz0oYTE0UXq7ZqgCDd2SyiFG/EBxNy4duillUNfdkMFi4VLSZFB8BjkRTMvfQFkHifKB0UnEqgLnlFOwz7x5FFSzIyyL5kBxDIcAeQ8Efx8bfzJa9FqTQO1b3tFqyP0JCk0OJjzFnAJzqYI0CIHVxmnIcfyRhqisSunIOo1BFSc6Ys3A9Fo/XgL6cf1LvpGjCsDHiGxp8QKwIPCdIbrjinno3sxVvrDFjoEOhDV62ng9IZffiZib1QnUICSNoLB+mMSpBxY/pGyxKs0OLxc8oD6kEoybh8z4QED8bo8jXJ+SGQ8pFPCV/M1DsHAcdltf7qAMxL5tBfZYFnHG+o+LgVsn+PDhHYjD/GcfExjDka/u3wq7TQIUQPvZ2u0C9bgMYfyInrJKTk7ng4G0/BcG5Qj1yYNILcV/z33/AdwNowahz2Zd0rsPw+kwAAFhT+Y87j9pqr+EU8bfSFCGiuBtfCVe2Cpdy4GP43vN2AoArGDhIiA+JzcuCOmRYH3loNGHXK8bm50xae7BqOb2/2pNpyacj7tjPbFQxvemvT2ebzM1x0aGmqip0PqDHGHwSVsEfwpd5htY/yTm9w9ka66IEvVxgVVv17mLUKMfmUGKoPQ//JtWUIZFVwDa0XL0WCkrGdE7TBrHp9lK8zJC+sVYCtJhY6ZXfLaQFmyoUG8qyQExTC1VjK5M/WCeGCH9qzdW1/nu621QgmM89h19U6ug4UQruy5SeKSieeBOITb5Iu3VJgHh3WcI3w== X-Forefront-Antispam-Report: CIP:149.199.62.198;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:xsj-pvapexch02.xlnx.xilinx.com;PTR:unknown-62-198.xilinx.com;CAT:NONE;SFS:(4636009)(39860400002)(376002)(136003)(346002)(396003)(46966006)(36840700001)(4326008)(7696005)(2616005)(186003)(478600001)(36860700001)(356005)(83380400001)(7636003)(47076005)(30864003)(5660300002)(6666004)(36906005)(6916009)(54906003)(8676002)(2906002)(36756003)(8936002)(426003)(70586007)(82740400003)(70206006)(9786002)(316002)(336012)(82310400003)(26005)(102446001)(403724002);DIR:OUT;SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Sep 2021 06:07:38.1075 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 291affca-15c1-4473-a81f-08d96dd7f72b X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.62.198];Helo=[xsj-pvapexch02.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: SN1NAM02FT0029.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR02MB4721 Introduce domctl XEN_DOMCTL_addfpga to add a device-tree node through device tree overlay. This works with a device tree overlay(.dtbo) as input. Add check_pfdt() to do sanity check on the dtbo. Also, added overlay_get_node_info() to get the node's full name with path. This comes handy when checking node for duplication. Each time a overlay node is added, a new fdt(memcpy of device_tree_flattened) is created and updated with overlay node. This updated fdt is further unflattened to a dt_host_new. Next, it checks if overlay node already exists in the dt_host. If overlay node doesn't exist then find the overlay node in dt_host_new, find the overlay node's parent in dt_host and add the node as child under parent in the dt_host. The node is attached as the last node under target parent. Finally, add IRQs, add device to IOMMUs, set permissions and map MMIO for the overlay node. When a node is added using overlay, a new entry is allocated in the overlay_track to keep the track of memory allocation due to addition of overlay node. This is helpful for freeing the memory allocated when a device tree node is removed with domctl XEN_DOMCTL_delfpga domctl. Signed-off-by: Vikram Garhwal --- xen/arch/arm/domctl.c | 262 ++++++++++++++++++++++++++++++++++++++++++ xen/common/device_tree.c | 54 +++++++++ xen/include/public/domctl.h | 7 ++ xen/include/xen/device_tree.h | 1 + 4 files changed, 324 insertions(+) diff --git a/xen/arch/arm/domctl.c b/xen/arch/arm/domctl.c index 5986934..0ac635f 100644 --- a/xen/arch/arm/domctl.c +++ b/xen/arch/arm/domctl.c @@ -15,6 +15,8 @@ #include #include #include +/* Included for FPGA dt add. */ +#include #include #include #include @@ -68,6 +70,61 @@ static int handle_vuart_init(struct domain *d, return rc; } +static int check_pfdt(void *pfdt, uint32_t pfdt_size) +{ + if ( fdt_totalsize(pfdt) != pfdt_size ) + { + printk(XENLOG_ERR "Partial FDT is not a valid Flat Device Tree\n"); + return -EFAULT; + } + + if ( fdt_check_header(pfdt) ) + { + printk(XENLOG_ERR "Partial FDT is not a valid Flat Device Tree\n"); + return -EFAULT; + } + + return 0; +} + +static void overlay_get_node_info(void *fdto, char *node_full_path) +{ + int fragment; + + /* + * Handle overlay nodes. But for now we are just handling one node. + */ + fdt_for_each_subnode(fragment, fdto, 0) + { + int target; + int overlay; + int subnode; + const char *target_path; + + target = overlay_get_target(device_tree_flattened, fdto, fragment, + &target_path); + overlay = fdt_subnode_offset(fdto, fragment, "__overlay__"); + + fdt_for_each_subnode(subnode, fdto, overlay) + { + const char *node_name = fdt_get_name(fdto, subnode, NULL); + int node_name_len = strlen(node_name); + int target_path_len = strlen(target_path); + + memcpy(node_full_path, target_path, target_path_len); + + node_full_path[target_path_len] = '/'; + + memcpy(node_full_path + target_path_len + 1, node_name, + node_name_len); + + node_full_path[target_path_len + 1 + node_name_len] = '\0'; + + return; + } + } +} + /* * First finds the device node to remove. Check if the device is being used by * any dom and finally remove it from dt_host. IOMMU is already being taken care @@ -194,6 +251,181 @@ out: return rc; } +/* + * Adds only one device node at a time under target node. + * We use dt_host_new to unflatten the updated device_tree_flattened. This is + * done to avoid the removal of device_tree generation, iomem regions mapping to + * DOM0 done by handle_node(). + */ +static long handle_add_fpga_overlay(void *pfdt, uint32_t pfdt_size) +{ + int rc = 0; + struct dt_device_node *fpga_node; + char node_full_path[128]; + void *fdt = xmalloc_bytes(fdt_totalsize(device_tree_flattened)); + struct dt_device_node *dt_host_new; + struct domain *d = hardware_domain; + struct overlay_track *tr = NULL; + int node_full_path_namelen; + unsigned int naddr; + unsigned int i; + u64 addr, size; + + if ( fdt == NULL ) + return ENOMEM; + + spin_lock(&overlay_lock); + + memcpy(fdt, device_tree_flattened, fdt_totalsize(device_tree_flattened)); + + rc = check_pfdt(pfdt, pfdt_size); + + if ( rc ) + goto err; + + overlay_get_node_info(pfdt, node_full_path); + + rc = fdt_overlay_apply(fdt, pfdt); + + if ( rc ) + { + printk(XENLOG_ERR "Adding overlay node %s failed with error %d\n", + node_full_path, rc); + goto err; + } + + /* Check if node already exists in dt_host. */ + fpga_node = dt_find_node_by_path(node_full_path); + + if ( fpga_node != NULL ) + { + printk(XENLOG_ERR "node %s exists in device tree\n", node_full_path); + rc = -EINVAL; + goto err; + } + + /* Unflatten the fdt into a new dt_host. */ + unflatten_device_tree(fdt, &dt_host_new); + + /* Find the newly added node in dt_host_new by it's full path. */ + fpga_node = _dt_find_node_by_path(dt_host_new, node_full_path); + + if ( fpga_node == NULL ) + { + dt_dprintk("%s node not found\n", node_full_path); + rc = -EFAULT; + xfree(dt_host_new); + goto err; + } + + /* Just keep the node we intend to add. Remove every other node in list. */ + fpga_node->allnext = NULL; + fpga_node->sibling = NULL; + + /* Add the node to dt_host. */ + rc = fpga_add_node(fpga_node, fpga_node->parent->full_name); + + if ( rc ) + { + /* Node not added in dt_host. Safe to free dt_host_new. */ + xfree(dt_host_new); + goto err; + } + + /* Get the node from dt_host and add interrupt and IOMMUs. */ + fpga_node = dt_find_node_by_path(fpga_node->full_name); + + if ( fpga_node == NULL ) + { + /* Sanity check. But code will never come in this loop. */ + printk(XENLOG_ERR "Cannot find %s node under updated dt_host\n", + fpga_node->name); + goto remove_node; + } + + /* First let's handle the interrupts. */ + rc = handle_device_interrupts(d, fpga_node, false); + + if ( rc ) + { + printk(XENLOG_G_ERR "Interrupt failed\n"); + goto remove_node; + } + + /* Add device to IOMMUs */ + rc = iommu_add_dt_device(fpga_node); + + if ( rc < 0 ) + { + printk(XENLOG_G_ERR "Failed to add %s to the IOMMU\n", + dt_node_full_name(fpga_node)); + goto remove_node; + } + + /* Set permissions. */ + naddr = dt_number_of_address(fpga_node); + + dt_dprintk("%s passthrough = %d naddr = %u\n", + dt_node_full_name(fpga_node), false, naddr); + + /* Give permission and map MMIOs */ + for ( i = 0; i < naddr; i++ ) + { + struct map_range_data mr_data = { .d = d, .p2mt = p2m_mmio_direct_c }; + rc = dt_device_get_address(fpga_node, i, &addr, &size); + if ( rc ) + { + printk(XENLOG_ERR "Unable to retrieve address %u for %s\n", + i, dt_node_full_name(fpga_node)); + goto remove_node; + } + + rc = map_range_to_domain(fpga_node, addr, size, &mr_data); + if ( rc ) + goto remove_node; + } + + /* This will happen if everything above goes right. */ + tr = xzalloc(struct overlay_track); + tr->dt_host_new = dt_host_new; + node_full_path_namelen = strlen(node_full_path); + tr->node_fullname = xmalloc_bytes(node_full_path_namelen + 1); + + if ( tr->node_fullname == NULL ) + { + rc = -ENOMEM; + goto remove_node; + } + + memcpy(tr->node_fullname, node_full_path, node_full_path_namelen); + tr->node_fullname[node_full_path_namelen] = '\0'; + + INIT_LIST_HEAD(&tr->entry); + list_add_tail(&tr->entry, &overlay_tracker); + +err: + spin_unlock(&overlay_lock); + xfree(fdt); + return rc; + +/* + * Failure case. We need to remove the node, free tracker(if tr exists) and + * dt_host_new. As the tracker is not in list yet so it doesn't get freed in + * handle_del_fpga_nodes() and due to that dt_host_new will not get freed so we + * we free tracker and dt_host_new here. + */ +remove_node: + spin_unlock(&overlay_lock); + handle_del_fpga_nodes(node_full_path); + xfree(dt_host_new); + + if ( tr ) + xfree(tr); + + xfree(fdt); + return rc; +} + long arch_do_domctl(struct xen_domctl *domctl, struct domain *d, XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl) { @@ -323,6 +555,36 @@ long arch_do_domctl(struct xen_domctl *domctl, struct domain *d, return rc; } + case XEN_DOMCTL_addfpga: + { + void *pfdt; + int rc; + + if ( domctl->u.fpga_add_dt.pfdt_size > 0 ) + pfdt = xmalloc_bytes(domctl->u.fpga_add_dt.pfdt_size); + else + return -EINVAL; + + if ( pfdt == NULL ) + return -ENOMEM; + + rc = copy_from_guest(pfdt, domctl->u.fpga_add_dt.pfdt, + domctl->u.fpga_add_dt.pfdt_size); + if ( rc ) + { + gprintk(XENLOG_ERR, "copy from guest failed\n"); + xfree(pfdt); + + return -EFAULT; + } + + rc = handle_add_fpga_overlay(pfdt, domctl->u.fpga_add_dt.pfdt_size); + + xfree(pfdt); + + return rc; + } + case XEN_DOMCTL_delfpga: { char *full_dt_node_path; diff --git a/xen/common/device_tree.c b/xen/common/device_tree.c index 04f2578..d062c17 100644 --- a/xen/common/device_tree.c +++ b/xen/common/device_tree.c @@ -324,6 +324,60 @@ void dt_print_node_names(struct dt_device_node *dt) return; } +int fpga_add_node(struct dt_device_node *fpga_node, + const char *parent_node_path) +{ + struct dt_device_node *parent_node; + struct dt_device_node *np; + struct dt_device_node *next_node; + struct dt_device_node *new_node; + + parent_node = dt_find_node_by_path(parent_node_path); + + new_node = fpga_node; + + if ( new_node == NULL ) + return -EINVAL; + + if ( parent_node == NULL ) + { + dt_dprintk("Node not found. Partial dtb will not be added"); + return -EINVAL; + } + + /* + * If node is found. We can attach the fpga_node as a child of the + * parent node. + */ + + for ( np = parent_node->child; np->sibling != NULL; np = np->sibling ) + { + } + + /* + * Before attaching also check if the parent node of fpga_node is also + * same named as parent. + */ + next_node = np->allnext; + + new_node->parent = parent_node; + np->sibling = new_node; + np->allnext = new_node; + + /* + * Reach at the end of fpga_node. + * TODO: Remove this loop as we are just adding one node for now. + */ + for ( np = new_node; np->allnext != NULL; np = np->allnext ) + { + } + + /* Now plug next_node at the end of fpga_node. */ + np->allnext = next_node; + + return 0; +} + int fpga_del_node(struct dt_device_node *device_node) { struct dt_device_node *np; diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h index b1b8efd..ce4667e 100644 --- a/xen/include/public/domctl.h +++ b/xen/include/public/domctl.h @@ -1175,6 +1175,11 @@ struct xen_domctl_fpga_del_dt { uint32_t size; }; +/* XEN_DOMCTL_fpga_add. */ +struct xen_domctl_fpga_add_dt { + XEN_GUEST_HANDLE_64(void) pfdt; + uint32_t pfdt_size; /* Partial dtb size. */ +}; struct xen_domctl { uint32_t cmd; @@ -1261,6 +1266,7 @@ struct xen_domctl { #define XEN_DOMCTL_get_cpu_policy 82 #define XEN_DOMCTL_set_cpu_policy 83 #define XEN_DOMCTL_vmtrace_op 84 +#define XEN_DOMCTL_addfpga 85 #define XEN_DOMCTL_delfpga 86 #define XEN_DOMCTL_gdbsx_guestmemio 1000 #define XEN_DOMCTL_gdbsx_pausevcpu 1001 @@ -1323,6 +1329,7 @@ struct xen_domctl { struct xen_domctl_psr_alloc psr_alloc; struct xen_domctl_vuart_op vuart_op; struct xen_domctl_vmtrace_op vmtrace_op; + struct xen_domctl_fpga_add_dt fpga_add_dt; struct xen_domctl_fpga_del_dt fpga_del_dt; uint8_t pad[128]; } u; diff --git a/xen/include/xen/device_tree.h b/xen/include/xen/device_tree.h index eb7f645..4c8dec6 100644 --- a/xen/include/xen/device_tree.h +++ b/xen/include/xen/device_tree.h @@ -496,6 +496,7 @@ int dt_find_node_by_gpath(XEN_GUEST_HANDLE(char) u_path, uint32_t u_plen, * Prints all node names. */ void dt_print_node_names(struct dt_device_node *dt); +int fpga_add_node(struct dt_device_node *fpga_node, const char *parent_node); int fpga_del_node(struct dt_device_node *device_node); /** -- 2.7.4 From xen-devel-bounces@lists.xenproject.org Thu Sep 02 06:51:03 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 06:51:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.176932.322158 (Exim 4.92) (envelope-from ) id 1mLgYw-0006WX-IT; Thu, 02 Sep 2021 06:51:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 176932.322158; Thu, 02 Sep 2021 06:51:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLgYv-0006R6-Rs; Thu, 02 Sep 2021 06:51:01 +0000 Received: by outflank-mailman (input) for mailman id 176932; Thu, 02 Sep 2021 06:07:51 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLft9-0004hL-Ea for xen-devel@lists.xenproject.org; Thu, 02 Sep 2021 06:07:51 +0000 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (unknown [40.107.96.81]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 17559226-0bb4-11ec-ae3e-12813bfff9fa; Thu, 02 Sep 2021 06:07:45 +0000 (UTC) Received: from SN4PR0501CA0083.namprd05.prod.outlook.com (2603:10b6:803:22::21) by DM6PR02MB6716.namprd02.prod.outlook.com (2603:10b6:5:218::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.24; Thu, 2 Sep 2021 06:07:43 +0000 Received: from SN1NAM02FT0029.eop-nam02.prod.protection.outlook.com (2603:10b6:803:22:cafe::de) by SN4PR0501CA0083.outlook.office365.com (2603:10b6:803:22::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.12 via Frontend Transport; Thu, 2 Sep 2021 06:07:42 +0000 Received: from xsj-pvapexch02.xlnx.xilinx.com (149.199.62.198) by SN1NAM02FT0029.mail.protection.outlook.com (10.97.4.175) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.4478.19 via Frontend Transport; Thu, 2 Sep 2021 06:07:42 +0000 Received: from xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Wed, 1 Sep 2021 23:07:22 -0700 Received: from smtp.xilinx.com (172.19.127.96) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Wed, 1 Sep 2021 23:07:22 -0700 Received: from [172.19.2.115] (port=56596 helo=xsjfnuv50.xilinx.com) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1mLfsg-000F6q-Dd; Wed, 01 Sep 2021 23:07:22 -0700 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 17559226-0bb4-11ec-ae3e-12813bfff9fa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LnC/zNap3NmjyBziOpMvDWQXaPdOpD89oEQX+ubKVltND/+dxXMhbCEef2RIk5fspdbgiS9gDPtZQq3zCITQVgOVF1uZiVBRGPBF7wpnaJTpPeHrFM6OkggsLyVJXDrhtYW2hrXmePDB4S66IzUgNe1UyNA2WdXvOQQLI4APdUegOtGSTURqS7M+l4rabkrgmWs2KasRCUHP8uTwnNkhmUMw8levOdkR+5/ef3tXxyRGteEuIiiPxpHccPEQ0mrrxSu5Lf1S0P9rmY1nIWJnpDRWxnOupSWTCQf0yuuFfW6LcczPQwRCjIjtYlwpFaunZxeeisESEJ6n96k94KLBag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=U7bgcXdJTXoKYKNKTamQfYEjcYOoItL0nadg/TeJWjc=; b=mCyKJMgU9KJR2RtMojV/Nq0IeDvxGu8cciiDV6vgXxXvjrWj2YRRx7I2AzY38N1UdzdvOgh4xi6nk9LpDA+IMz7IU+v6u2krT0D5+nlafEs9Mlc/thIRB9/f+HueuSPg/MzfghNoCoH0BQXn+HvbqziYrlX7dBED9WI6WNok43sUhExApe4rGUy5ruW0DJcToXlawTIBdQDNJOZ6pNpuml+IciSWp+0ITRqq2I6lQBShh0erdZVReobp6e9oRS8JH0PCdrz9jxTXADdWK/DuvCe9dt2eO2pZm51SeD2FwORtIOlMoj07k1gPrdl9ZkfVklibdDbwKiS/FzLqT9VnPQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.62.198) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=U7bgcXdJTXoKYKNKTamQfYEjcYOoItL0nadg/TeJWjc=; b=ZG9hLXS8uar1ahAzaZbhU+0vOk/tGHggI3e0eGYbEHfIYivRIYEWMUhYiJ9hbCFMovIqQCluPtHSXTRMAzhns7Vc8PT+WQtJ+jrN1lll1hYQl2ifrGQIHF+Z3W+pE3/s0ztIMnMN5dMMaoDB8xO7KnPWrDnWmzMjC2PiSCYk87c= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.62.198) smtp.mailfrom=xilinx.com; lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.62.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.62.198; helo=xsj-pvapexch02.xlnx.xilinx.com; From: Vikram Garhwal To: CC: , , Vikram Garhwal , Ian Jackson , Wei Liu , Anthony PERARD , Juergen Gross Subject: [XEN][RFC PATCH 12/13] tools/libs/light: Implement new libxl functions for fpga-add and fpga-del Date: Wed, 1 Sep 2021 23:06:02 -0700 Message-ID: <1630562763-390068-13-git-send-email-fnu.vikram@xilinx.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1630562763-390068-1-git-send-email-fnu.vikram@xilinx.com> References: <1630562763-390068-1-git-send-email-fnu.vikram@xilinx.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 486282e8-4a79-441f-0264-08d96dd7f9cd X-MS-TrafficTypeDiagnostic: DM6PR02MB6716: X-Microsoft-Antispam-PRVS: X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7da38gZlNn3e0k98mCCgPkePjD0Y6Mmg0n0YzpnVhA0UlfuB5PtLftDi2EmxPx5t2ro6pNFEXqnNkkCuwKgzDXPCcxuP1NQyaLEa8ErqZ9iRkiuY3Ru/vGcOe9xBKTySCWC2jPD8fVxCnIejAHeTXFhe5Zu7LhTJPAslvMCEOMpCuiqF02LrUaQFBAc06+i5E8dtctC7wPCXS2VMh0HOcpkloSw7Zov9gZFEYKc5ZtjpC8YJ5OhFVHPu/n0fkee9oel19yvc/bWYJQ8bOJwaJRRmrkDu5aQTERE+/0ujwxzwhs/OO97SWl4ryH5dgZfiDB6/iwxsDtMi2BtK1mzxH/Ri91eBsA1UUY7NC6ZiBySz30zgJJznLRtqvX0CPlWKLfE/vl8NqfWnoJUioVY9Ya6PSfz8VhsRByWdoF6B9PtbyDzEGL5eeMNaPyGC7LZwq/PKJkM1+DPNyUInV1dWmmteoA6KmE1g8Cv0DQSgjd0iAstUEPIgJQIH6K8JJCb74AlYyaP4QTpJgXq1j0F9e/vyJbavJaZBGsYQbzMpSn9cSvIeao19phWmnSuthBGWkPTRWHbjMuhFJldRoo/hjmn2xPT1bHJ5TbmTVFyINAGBDRa+cLHf6wE7gJL/8QbP+q2edzuWDNuHBamFm2RKM9eTGDaWXqJMImXayVfl8p6iYd/UZDAo/GPZw0F4IFtifKL+xW3y56Ldghk2SNF8Q62oJmzgOArPmE1rQTWg0D2NpE3qqGoclTPp1VXZ6V2X X-Forefront-Antispam-Report: CIP:149.199.62.198;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:xsj-pvapexch02.xlnx.xilinx.com;PTR:unknown-62-198.xilinx.com;CAT:NONE;SFS:(4636009)(39860400002)(346002)(396003)(376002)(136003)(36840700001)(46966006)(82310400003)(70206006)(70586007)(5660300002)(36756003)(8676002)(9786002)(36860700001)(8936002)(47076005)(478600001)(4326008)(54906003)(82740400003)(316002)(2906002)(36906005)(356005)(7636003)(336012)(186003)(2616005)(426003)(6666004)(7696005)(26005)(6916009)(102446001)(2004002);DIR:OUT;SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Sep 2021 06:07:42.5194 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 486282e8-4a79-441f-0264-08d96dd7f9cd X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.62.198];Helo=[xsj-pvapexch02.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: SN1NAM02FT0029.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR02MB6716 Signed-off-by: Vikram Garhwal --- tools/include/libxl.h | 5 +++ tools/libs/light/Makefile | 1 + tools/libs/light/libxl_fpga.c | 73 +++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 79 insertions(+) create mode 100644 tools/libs/light/libxl_fpga.c diff --git a/tools/include/libxl.h b/tools/include/libxl.h index b9ba16d..896cbcf 100644 --- a/tools/include/libxl.h +++ b/tools/include/libxl.h @@ -2386,6 +2386,11 @@ libxl_device_pci *libxl_device_pci_list(libxl_ctx *ctx, uint32_t domid, int *num); void libxl_device_pci_list_free(libxl_device_pci* list, int num); +/* FPGA device add. */ +int libxl_add_fpga_node(libxl_ctx *ctx, void *pfdt, int pfdt_size); +/* FPGA device remove. */ +int libxl_del_fpga_node(libxl_ctx *ctx, char *full_dt_node_path); + /* * Turns the current process into a backend device service daemon * for a driver domain. diff --git a/tools/libs/light/Makefile b/tools/libs/light/Makefile index 7d8c51d..b17d4a6 100644 --- a/tools/libs/light/Makefile +++ b/tools/libs/light/Makefile @@ -115,6 +115,7 @@ SRCS-y += libxl_genid.c SRCS-y += _libxl_types.c SRCS-y += libxl_flask.c SRCS-y += _libxl_types_internal.c +SRCS-y += libxl_fpga.o ifeq ($(CONFIG_LIBNL),y) CFLAGS_LIBXL += $(LIBNL3_CFLAGS) diff --git a/tools/libs/light/libxl_fpga.c b/tools/libs/light/libxl_fpga.c new file mode 100644 index 0000000..a33d00f --- /dev/null +++ b/tools/libs/light/libxl_fpga.c @@ -0,0 +1,73 @@ +/* + * Copyright (C) 2021 Xilinx Inc. + * Author Vikram Garhwal + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU Lesser General Public License as published + * by the Free Software Foundation; version 2.1 only. with the special + * exception on linking described in file LICENSE. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Lesser General Public License for more details. + */ + +#include "libxl_osdeps.h" /* must come before any other headers */ +#include "libxl_internal.h" +#include +#include +#include + +static int check_partial_fdt(libxl__gc *gc, void *fdt, size_t size) +{ + int r; + + if (fdt_magic(fdt) != FDT_MAGIC) { + LOG(ERROR, "Partial FDT is not a valid Flat Device Tree"); + return ERROR_FAIL; + } + + r = fdt_check_header(fdt); + if (r) { + LOG(ERROR, "Failed to check the partial FDT (%d)", r); + return ERROR_FAIL; + } + + if (fdt_totalsize(fdt) > size) { + LOG(ERROR, "Partial FDT totalsize is too big"); + return ERROR_FAIL; + } + + return 0; +} + +int libxl_add_fpga_node(libxl_ctx *ctx, void *pfdt, int pfdt_size) +{ + int rc = 0; + GC_INIT(ctx); + + if (check_partial_fdt(gc, pfdt, pfdt_size)) { + LOG(ERROR, "Partial DTB check failed\n"); + return ERROR_FAIL; + } else + LOG(DEBUG, "Partial DTB check passed\n"); + + /* We don't need to do xc_interface_open here. */ + rc = xc_domain_add_fpga(ctx->xch, pfdt, pfdt_size); + + if (rc) + LOG(ERROR, "%s: Adding partial dtb failed.\n", __func__); + + return rc; +} + +int libxl_del_fpga_node(libxl_ctx *ctx, char *device_path) +{ + int rc = 0; + + /* We don't need to do xc_interface_open here. */ + rc = xc_domain_del_fpga(ctx->xch, device_path); + + return rc; +} -- 2.7.4 From xen-devel-bounces@lists.xenproject.org Thu Sep 02 06:51:04 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 06:51:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.176934.322169 (Exim 4.92) (envelope-from ) id 1mLgYx-0006nJ-Pj; Thu, 02 Sep 2021 06:51:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 176934.322169; Thu, 02 Sep 2021 06:51:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLgYw-0006gN-R6; Thu, 02 Sep 2021 06:51:02 +0000 Received: by outflank-mailman (input) for mailman id 176934; Thu, 02 Sep 2021 06:08:03 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLftL-0004km-3p for xen-devel@lists.xenproject.org; Thu, 02 Sep 2021 06:08:03 +0000 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (unknown [40.107.236.50]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 21108f96-0bb4-11ec-ae3e-12813bfff9fa; Thu, 02 Sep 2021 06:08:01 +0000 (UTC) Received: from BN1PR14CA0017.namprd14.prod.outlook.com (2603:10b6:408:e3::22) by DM6PR02MB4043.namprd02.prod.outlook.com (2603:10b6:5:9f::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.23; Thu, 2 Sep 2021 06:08:00 +0000 Received: from BN1NAM02FT024.eop-nam02.prod.protection.outlook.com (2603:10b6:408:e3:cafe::64) by BN1PR14CA0017.outlook.office365.com (2603:10b6:408:e3::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Thu, 2 Sep 2021 06:08:00 +0000 Received: from xsj-pvapexch01.xlnx.xilinx.com (149.199.62.198) by BN1NAM02FT024.mail.protection.outlook.com (10.13.2.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.4478.19 via Frontend Transport; Thu, 2 Sep 2021 06:07:59 +0000 Received: from xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) by xsj-pvapexch01.xlnx.xilinx.com (172.19.86.40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Wed, 1 Sep 2021 23:07:21 -0700 Received: from smtp.xilinx.com (172.19.127.96) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Wed, 1 Sep 2021 23:07:21 -0700 Received: from [172.19.2.115] (port=56596 helo=xsjfnuv50.xilinx.com) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1mLfsf-000F6q-32; Wed, 01 Sep 2021 23:07:21 -0700 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 21108f96-0bb4-11ec-ae3e-12813bfff9fa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Wha1qfH0ZPATby9Q4mskRJHLQuUFsgYuFwayM2JLL9kFOEi6UTuLqfGD7h0DHAwEvM25P+v7FwjXuyf8LxrWZm+lLPC/JyxnMaLUs45BrdupAe0jyBpmKlBjoSuJWsik/UbiO+vbYwJ0hek69GpbGuFMtormyMIFSRCXRsMJhGspWj5k+2+KICf2Kx5bW+PxLfEjejhWYExkrM/y+r5acvQ/WI+lVWYzKSlwypNrCqMsJ9euHDgfCUbxaQwpTwrHqqdBhaaZcfaJAJmDJGz3SuJqxM+JSuQUYvKvQwdfL+6RRmaIMp7/hSd5tJqjJRd4FkSXYzwT5AHjn6L7OefJxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6vRNUT8x84jkmg4e61wPSC8IbP4rdyDEfRG2ff/C/Jw=; b=JBGHCjEfJN7w/dKGMVnu9wvudHVio860healWWmpFiTxuP0vQ8rclTzp3VqJrrIluzImVYGDwVm8+ENZCeQtJ9LJktWjDSmJ65qSD/3tJ6ETgjEpIoyDUuqv3zPOglf2fpSWz7N7bNe8boXWH98nR1bVLSg1ZdRyyTm7qoGiWAdzNEyJxOnS1upCl3WuhptAsGsxq+jxW/skkfjLog2CCuPY1YyN7OqVEXca5FUULzEUr3lsCOYJRKCbSoqq4xM/1XPYPajy/Ba4OTYwyINvv7KsIxkVuv9QOL9FtJ8lnz9ZzWzYZzYCsKaRn8rB60+kIrld0xEhbpIAmP9CRa0lgQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.62.198) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6vRNUT8x84jkmg4e61wPSC8IbP4rdyDEfRG2ff/C/Jw=; b=D7zaaaYViPL0cynA6mP7xFHD5UMNWK19BWJoTPyo4QVUQovhGIpQmJT0Ckg1aJwVQxS2U7kPrTTZRbHpgVM7eCNnBe1hytLGalfNRyYYkfp+HXu/qBirtZznZuDsQyhglo6zq1pBjvcCPgxocRHUrQXOFMIw56X2OQ+z0sO2v50= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.62.198) smtp.mailfrom=xilinx.com; lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.62.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.62.198; helo=xsj-pvapexch01.xlnx.xilinx.com; From: Vikram Garhwal To: CC: , , Vikram Garhwal , Ian Jackson , Wei Liu , Juergen Gross Subject: [XEN][RFC PATCH 11/13] tools/libs/ctrl: Implement new xc interfaces for fpga-add and fpga-del Date: Wed, 1 Sep 2021 23:06:01 -0700 Message-ID: <1630562763-390068-12-git-send-email-fnu.vikram@xilinx.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1630562763-390068-1-git-send-email-fnu.vikram@xilinx.com> References: <1630562763-390068-1-git-send-email-fnu.vikram@xilinx.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: becd6285-e0dd-4a35-7bf2-08d96dd80433 X-MS-TrafficTypeDiagnostic: DM6PR02MB4043: X-Microsoft-Antispam-PRVS: X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-Oob-TLC-OOBClassifiers: OLM:1468; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: u+EdAWF8Cc9fzd1XrneN/sHZ+iXJv8tDOsLWUoefmZO87ab09jnLPwNvpTIrdRuyfJ8yiVlSwU387RfV53S3f8AnPgHqed9e0SxF3idUHXTl2LnuLB9AS73NSST9YDr8mriSWDu/+lGUB83RTkfB2ZafObA1jk8Z9ucKCyfMmlmkJFNPF/fuOyykc4t2uC1+TQJim2D+QP+UYH6kONTgaKelrjNAmGFlJXDbiaEMraCQQqAAZOdBhd/61P/mf1i8UbWktvzArgodv9Bae6HNw5/h5TK6WkgbMvksl2MAEst/KgzzW4AtNPxo0ZhHAXsLFk6tEIckc3qVCaXpMEVBL/8F/ca0Kaqyd+6gOUC9hTe1QLZfpe19vNQSjuE8R280yO6J2ZWShVYeHpVU2ZL4FVI9p0mk0f1SStGX8z98SQaNkLVqG9Lqw7y6HeimywkEApQIvwYG6vvWNHF/e/+gQiwbatYrcoIC5pY4u3m20RI2ARhBqLWTHp2THuGUacTDXFW+G3BHoHb6tmMyXQRk9v4uRHPkKKMaqmb0+B3WkXGUaYTM0ansGwfup+m33drd5WU+Y+75XtoSV0bO/6K5YeBLmIsqEidFRcb5tTa+PT9uUEC4vv9CMQlE4LXJ+9W1oPK8IqUAqSZoIti85EZlzN/q/skqWfkEUAi0x/vup2QenryjPDemBN5PA0N9ofLyrtZn8ItZSZzclp2yoEogRDYHRmF1QjbUs9A7o6kwNrmVtEcmdFAAwQpK/ZzIynuKUdAnWMymH2Tu1hZbHzOWsFeB659FH7F6bIDo+R798gxude+KJ1GxwNjRlCLZdH/mnt8R3LA1JM6zGBXNTADcdg== X-Forefront-Antispam-Report: CIP:149.199.62.198;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:xsj-pvapexch01.xlnx.xilinx.com;PTR:unknown-62-198.xilinx.com;CAT:NONE;SFS:(4636009)(136003)(396003)(39860400002)(376002)(346002)(36840700001)(46966006)(478600001)(82740400003)(47076005)(36756003)(8676002)(70206006)(82310400003)(6666004)(36906005)(26005)(8936002)(36860700001)(2616005)(186003)(7636003)(336012)(426003)(2906002)(4326008)(7696005)(5660300002)(316002)(70586007)(9786002)(356005)(6916009)(54906003)(102446001)(2004002);DIR:OUT;SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Sep 2021 06:07:59.9152 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: becd6285-e0dd-4a35-7bf2-08d96dd80433 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.62.198];Helo=[xsj-pvapexch01.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: BN1NAM02FT024.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR02MB4043 xc_domain_add_fpga() sends the device tree binary overlay and size of .dtbo to xen. xc_domain_del_fpga() sends full path for the node to be removed. Signed-off-by: Vikram Garhwal --- tools/include/xenctrl.h | 4 +++ tools/libs/ctrl/Makefile | 1 + tools/libs/ctrl/xc_fpga.c | 82 +++++++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 87 insertions(+) create mode 100644 tools/libs/ctrl/xc_fpga.c diff --git a/tools/include/xenctrl.h b/tools/include/xenctrl.h index b77726e..d14b3df 100644 --- a/tools/include/xenctrl.h +++ b/tools/include/xenctrl.h @@ -2679,6 +2679,10 @@ int xc_livepatch_replace(xc_interface *xch, char *name, uint32_t timeout, uint32 int xc_domain_cacheflush(xc_interface *xch, uint32_t domid, xen_pfn_t start_pfn, xen_pfn_t nr_pfns); +int xc_domain_add_fpga(xc_interface *xch, void *pfdt, int pdft_size); +int xc_domain_del_fpga(xc_interface *xch, char *full_dt_node_path); + + /* Compat shims */ #include "xenctrl_compat.h" diff --git a/tools/libs/ctrl/Makefile b/tools/libs/ctrl/Makefile index 519246b..95021b9 100644 --- a/tools/libs/ctrl/Makefile +++ b/tools/libs/ctrl/Makefile @@ -3,6 +3,7 @@ include $(XEN_ROOT)/tools/Rules.mk SRCS-y += xc_altp2m.c SRCS-y += xc_cpupool.c +SRCS-$(CONFIG_ARM) += xc_fpga.c SRCS-y += xc_domain.c SRCS-y += xc_evtchn.c SRCS-y += xc_gnttab.c diff --git a/tools/libs/ctrl/xc_fpga.c b/tools/libs/ctrl/xc_fpga.c new file mode 100644 index 0000000..41c37b5 --- /dev/null +++ b/tools/libs/ctrl/xc_fpga.c @@ -0,0 +1,82 @@ +/* + * + * FPGA control functions. + * Copyright (C) 2021 Xilinx Inc. + * Author Vikram Garhwal + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; + * version 2.1 of the License. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library; If not, see . + */ + +#include "xc_bitops.h" +#include "xc_private.h" +#include +#include + +int xc_domain_add_fpga(xc_interface *xch, void *pfdt, int pfdt_size) +{ + int err; + DECLARE_DOMCTL; + + DECLARE_HYPERCALL_BOUNCE(pfdt, pfdt_size, XC_HYPERCALL_BUFFER_BOUNCE_IN); + + if ( (err = xc_hypercall_bounce_pre(xch, pfdt)) ) + goto err; + + domctl.cmd = XEN_DOMCTL_addfpga; + /* Adding the device to hardware domain by default. */ + domctl.domain = 0; + domctl.u.fpga_add_dt.pfdt_size = pfdt_size; + + set_xen_guest_handle(domctl.u.fpga_add_dt.pfdt, pfdt); + + if ( (err = do_domctl(xch, &domctl)) != 0 ) + PERROR("%s failed\n", __func__); + +err: + xc_hypercall_bounce_post(xch, pfdt); + + return err; +} + +int xc_domain_del_fpga(xc_interface *xch, char *full_dt_node_path) +{ + int err; + DECLARE_DOMCTL; + size_t size = strlen(full_dt_node_path) + 1; + + DECLARE_HYPERCALL_BOUNCE(full_dt_node_path, size, + XC_HYPERCALL_BUFFER_BOUNCE_IN); + + if ( (err = xc_hypercall_bounce_pre(xch, full_dt_node_path)) ) + goto err; + + domctl.cmd = XEN_DOMCTL_delfpga; + /* + * Remove the device from the dt_host, setting hardware domain by + * default. + */ + domctl.domain = 0; + domctl.u.fpga_del_dt.size = size; + + set_xen_guest_handle(domctl.u.fpga_del_dt.full_dt_node_path, + full_dt_node_path); + + if ( (err = do_domctl(xch, &domctl)) != 0 ) + PERROR("%s failed\n", __func__); + +err: + xc_hypercall_bounce_post(xch, full_dt_node_path); + + return err; +} -- 2.7.4 From xen-devel-bounces@lists.xenproject.org Thu Sep 02 06:51:06 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 06:51:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.176935.322181 (Exim 4.92) (envelope-from ) id 1mLgYz-00078B-Ia; Thu, 02 Sep 2021 06:51:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 176935.322181; Thu, 02 Sep 2021 06:51:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLgYy-00071s-7R; Thu, 02 Sep 2021 06:51:04 +0000 Received: by outflank-mailman (input) for mailman id 176935; Thu, 02 Sep 2021 06:08:04 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLftM-0004km-9P for xen-devel@lists.xenproject.org; Thu, 02 Sep 2021 06:08:04 +0000 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (unknown [40.107.236.89]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 22069f30-0bb4-11ec-ae3e-12813bfff9fa; Thu, 02 Sep 2021 06:08:03 +0000 (UTC) Received: from BN1PR14CA0026.namprd14.prod.outlook.com (2603:10b6:408:e3::31) by SA0PR02MB7500.namprd02.prod.outlook.com (2603:10b6:806:e9::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.17; Thu, 2 Sep 2021 06:08:02 +0000 Received: from BN1NAM02FT024.eop-nam02.prod.protection.outlook.com (2603:10b6:408:e3:cafe::fd) by BN1PR14CA0026.outlook.office365.com (2603:10b6:408:e3::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.17 via Frontend Transport; Thu, 2 Sep 2021 06:08:02 +0000 Received: from xsj-pvapexch01.xlnx.xilinx.com (149.199.62.198) by BN1NAM02FT024.mail.protection.outlook.com (10.13.2.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.4478.19 via Frontend Transport; Thu, 2 Sep 2021 06:08:01 +0000 Received: from xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) by xsj-pvapexch01.xlnx.xilinx.com (172.19.86.40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Wed, 1 Sep 2021 23:07:23 -0700 Received: from smtp.xilinx.com (172.19.127.96) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Wed, 1 Sep 2021 23:07:23 -0700 Received: from [172.19.2.115] (port=56596 helo=xsjfnuv50.xilinx.com) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1mLfsh-000F6q-AB; Wed, 01 Sep 2021 23:07:23 -0700 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 22069f30-0bb4-11ec-ae3e-12813bfff9fa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PqXc9nZHuBVpovZhtd88HvzHVB8dah0yQfDIGTWKMs+Vv+T5UAMeNAT5E/D6uYfZvEm2uWuuW82J0pjvKifUUNzrwm8/+Skpdi4AgJYGFABnVQlR1QgqiMShDXODKmneMn0YfQ7HenSe8ZdVbg0X9CbRUUoQ58IXoSIVM4kcEwfMGBD8ZHvQGiV9a1oRl/njSUh56tAgKvZ0Z9VmjL7B63ywm2zS46nBMW61TPi9YYsSgCIOKhuJfFrtbgoFyEMWiDRv8iDnNrPZtzBQDaDYMbyJtGdWXnpsWvarRn7AgaWu1S4r7vT+UjOGUWcAE0JFsM8Uc/4twb5JwWjyCZYPUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=ykNwRHO6V8HwcABuxYp6Pws7yb5pYX82KhqW7gTX5nc=; b=CgY1gDga71hBm89KMbDdD2WJPWR2lnb/Xx0NUtEGdx/Aw+gXSQYIMeiDGyLL7+PNgMeIfowbOOSaH7E5JSBSbypdS0/VXeSh3BEKcwaHOYfuDe/st6iirOvHFrBBabzMUaKQ0Jnuvfy6lRliYhPAgAO+LgwPb05j7ix8uy4Sg+u63jMr8JgSS4eXOkeM54EVt75XTLeTsRPwhnqKsZwEwqct5IDv7ZZWoWvRQ1rk36RitMlitsv4YO81ODiL8BBmXC33L7k8CRYvUXpzkiy6QmiiPJuJvbXM3uSM/Si5wJuctlwhhH5H5QvOYTfR6QvCOIWw7JlroSUjWv05IEXO2A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.62.198) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ykNwRHO6V8HwcABuxYp6Pws7yb5pYX82KhqW7gTX5nc=; b=G6+822z/VzQ5VXb3CZJGI+vF84PpPixiKHazT8usadnJUJV3GNk1pVcE09e/4/lWTYLrRrqJANikEdGS8Q7HDuOaeJf0OAsaoKBMNTKKIdKqsz910P17k8I65eu3sITtESFZsvSLWPYJWbHL6S82yLDzUN3R2VCtNwLPBI9cy6c= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.62.198) smtp.mailfrom=xilinx.com; lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.62.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.62.198; helo=xsj-pvapexch01.xlnx.xilinx.com; From: Vikram Garhwal To: CC: , , Vikram Garhwal , Ian Jackson , Wei Liu , Anthony PERARD Subject: [XEN][RFC PATCH 13/13] tools/xl: Add new xl commands fpga-add and fpga-del Date: Wed, 1 Sep 2021 23:06:03 -0700 Message-ID: <1630562763-390068-14-git-send-email-fnu.vikram@xilinx.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1630562763-390068-1-git-send-email-fnu.vikram@xilinx.com> References: <1630562763-390068-1-git-send-email-fnu.vikram@xilinx.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c76b6324-d7df-4ebd-1549-08d96dd8056b X-MS-TrafficTypeDiagnostic: SA0PR02MB7500: X-Microsoft-Antispam-PRVS: X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-Oob-TLC-OOBClassifiers: OLM:580; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: X4ERjSdA+RWK/hy0b42uEAoSAyrO4UpkaYB7WUQ0Tf+YwDLtoSbqoAuTzatAkj6FhC8rhHhQGKykX/auKQywlj/5IU8rd8cbCIY5D35NXs671zs+GEb6yMwqBcw3jqL2CiAmal8ElmIacC1yg4j2ZBgTZeI5Pan+W85+dlZrw96rE3WFvLZVmy40X+U5EjfL2gvYzbN4XTJXyxSs4X/D9dhZM9Vcp0n62NU+cdvbrCs8zq/h20wNOHmjvXdi2X7UPyNx0/HOLcaRX0FuU3CBAaY38n4XRK2xUh8jCShiMoKV3Fux49PWP9fJOFviHMCTxOWGfxSqLm2JcQ3rz36dWUWmLRBjij8P3NFW7XTyvy+1vm7QP4AlMOIqZVEOzmS9ovfOroBuVdPvb47lY945NumWVBscmwakiIbHieNIfHd33rI5tB6VokevY0nh4DBQ1yuVvIi2utIE5hE4oQcm5kw89FKpZ2rJL2TyisKW21MwN+fJi3JWEsXluiWYrpw7RBPQTstRe3aGMISukcWxV2jpynYMMRoDT/kgQyWB+8YSekOQKARDNKYGzhhZ4qcdKY+jrL5Sehx/poY9pIE6sn65lrLGy9B25mj3p7EG2PFMazDrzFMJjG4eUvtOZnY7ly712XLFUptEP+WlAo4K+E/FvFBmIRW1kqRvkSfqnzfHVhoIM+vlQjHMUHLdzZ8RUHKKyan5BSFtOyKMhIkbucxxenwgKbY5F3olGZtBoQI= X-Forefront-Antispam-Report: CIP:149.199.62.198;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:xsj-pvapexch01.xlnx.xilinx.com;PTR:unknown-62-198.xilinx.com;CAT:NONE;SFS:(4636009)(396003)(376002)(346002)(39860400002)(136003)(36840700001)(46966006)(316002)(7696005)(36906005)(426003)(83380400001)(478600001)(36756003)(54906003)(26005)(2906002)(36860700001)(9786002)(8936002)(336012)(82310400003)(5660300002)(4326008)(2616005)(82740400003)(356005)(7636003)(8676002)(6916009)(70586007)(6666004)(70206006)(186003)(47076005)(102446001);DIR:OUT;SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Sep 2021 06:08:01.9563 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c76b6324-d7df-4ebd-1549-08d96dd8056b X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.62.198];Helo=[xsj-pvapexch01.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: BN1NAM02FT024.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR02MB7500 Signed-off-by: Vikram Garhwal --- tools/xl/xl.h | 2 ++ tools/xl/xl_cmdtable.c | 12 ++++++++++++ tools/xl/xl_vmcontrol.c | 51 +++++++++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 65 insertions(+) diff --git a/tools/xl/xl.h b/tools/xl/xl.h index 7e23f30..63be31e 100644 --- a/tools/xl/xl.h +++ b/tools/xl/xl.h @@ -140,6 +140,8 @@ int main_shutdown(int argc, char **argv); int main_reboot(int argc, char **argv); int main_list(int argc, char **argv); int main_vm_list(int argc, char **argv); +int main_fpga_add(int argc, char **argv); +int main_fpga_del(int argc, char **argv); int main_create(int argc, char **argv); int main_config_update(int argc, char **argv); int main_button_press(int argc, char **argv); diff --git a/tools/xl/xl_cmdtable.c b/tools/xl/xl_cmdtable.c index 661323d..135fe6a 100644 --- a/tools/xl/xl_cmdtable.c +++ b/tools/xl/xl_cmdtable.c @@ -20,6 +20,18 @@ #include "xl.h" const struct cmd_spec cmd_table[] = { + { "fpga-add", + &main_fpga_add, 1, 1, + "Add a PL block", + "<.dtbo>" + "-h print this help\n" + }, + { "fpga-del", + &main_fpga_del, 1, 1, + "Remove a PL block", + "" + "-h print this help\n" + }, { "create", &main_create, 1, 1, "Create a domain from config file ", diff --git a/tools/xl/xl_vmcontrol.c b/tools/xl/xl_vmcontrol.c index 435155a..f5bfdbc 100644 --- a/tools/xl/xl_vmcontrol.c +++ b/tools/xl/xl_vmcontrol.c @@ -1262,6 +1262,57 @@ int main_create(int argc, char **argv) return 0; } +int main_fpga_add(int argc, char **argv) +{ + const char *fpga_config_file = argv[1]; + void *pfdt = NULL; + int rc; + int pfdt_size = 0; + + if (fpga_config_file) { + rc = libxl_read_file_contents(ctx, fpga_config_file, + &pfdt, &pfdt_size); + + if (rc) { + fprintf(stderr, "failed to read the fpga-partial device file %s\n", + fpga_config_file); + free(pfdt); + return ERROR_FAIL; + } + } else { + fprintf(stderr, "FPGA config file is not provided\n"); + return ERROR_FAIL; + } + + rc = libxl_add_fpga_node(ctx, pfdt, pfdt_size); + if (rc) + fprintf(stderr, "Adding FPGA node failed\n"); + + free(pfdt); + return rc; +} + +int main_fpga_del(int argc, char **argv) +{ + char *full_dt_node_path = argv[1]; + int rc = 0; + + if (full_dt_node_path) { + rc = libxl_del_fpga_node(ctx, full_dt_node_path); + + fprintf(stdout, "fpga-del called for device = %s\n", full_dt_node_path); + + if (rc) + fprintf(stderr, "Removing FPGA node failed\n"); + + } else { + fprintf(stderr, "No device node path provided\n"); + return ERROR_FAIL; + } + + return rc; +} + /* * Local variables: * mode: C -- 2.7.4 From xen-devel-bounces@lists.xenproject.org Thu Sep 02 07:00:32 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 07:00:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177039.322229 (Exim 4.92) (envelope-from ) id 1mLgi3-00063H-7a; Thu, 02 Sep 2021 07:00:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177039.322229; Thu, 02 Sep 2021 07:00:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLgi3-00063A-3e; Thu, 02 Sep 2021 07:00:27 +0000 Received: by outflank-mailman (input) for mailman id 177039; Thu, 02 Sep 2021 07:00:26 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLgi2-000634-GK for xen-devel@lists.xenproject.org; Thu, 02 Sep 2021 07:00:26 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 72228770-0bbb-11ec-ae41-12813bfff9fa; Thu, 02 Sep 2021 07:00:25 +0000 (UTC) Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-he1eur02lp2050.outbound.protection.outlook.com [104.47.5.50]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-15-VH_ELK56Nlm_85o7wd7EDw-1; Thu, 02 Sep 2021 09:00:23 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR04MB2959.eurprd04.prod.outlook.com (2603:10a6:802:8::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.21; Thu, 2 Sep 2021 07:00:20 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4478.021; Thu, 2 Sep 2021 07:00:20 +0000 Received: from [10.156.60.236] (37.24.206.209) by PR3P192CA0008.EURP192.PROD.OUTLOOK.COM (2603:10a6:102:56::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.20 via Frontend Transport; Thu, 2 Sep 2021 07:00:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 72228770-0bbb-11ec-ae41-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1630566024; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kHyfyd4gEvYSCBmF+GcFJVNB691mgc2xHZaGZWzVAvU=; b=PJ7bBsaAUQth3+ZaFzcZIhmrlbbUE++4/LBKOWk/usOuvxuXYUZo7hj8WuJPzlChX1TpU2 XkhCV/SS70kYdPZ8opvLmmNZoyDFe9mA44Q5P64NyQ4D/p8hfPEG0F0u3h6LBICmrHYgtX rawW/sEd//clM5C2H9K88p5efGsbV9E= X-MC-Unique: VH_ELK56Nlm_85o7wd7EDw-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UlP1RISFv3UfrAUtTSxlXQ4IYloSQULwD6SZE/1E+Im4fflCi6MjkjLMXY10ia1jUxi1+q0k3265Cl4LxNpCXbwI+C+HDRUjMnGjFoKRjEsvMq+30IK1myP7c1LOdwmVpkSGmb4jDwu9pDKboyo4gwqH66Y2qSwJ2p+4ijDF6kbJaOkpI/WjZb6mAcK42xugWllIg5sTYXATQLrQtxo9ffWr7EBMOi4ve9X6Pn8UIPRqR6GwIjVwSmK3UkShYFUlwuZ8TQL89y3czIrpHLDKI0avaS2CB7DgZ+aEdYcZhS/oQ8uksyiPkc0rNy0JQKd/CV09KlHpmugdigTOB6kP5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=Du1n8tHvw2rKWfhNlde3mS2ais71qjhr//pscVaPcMY=; b=C/fWVH+ZsZzQaLVwa1JdOvT5CmkAbiYGUGbt9f8V1qlKSyNGCGrvlOnYznquIj8+Vg2CLTxPNpotNjS8cL62EXWsEkRrN+qiZ7JsleI9Y5V4ydv9CkO+XNm++lMtOvr8nBiJObIbEbytueZ1eDce8gpucl8FJ+pXdDAGra+XwEs0xBdkoFk4u/wOJ0J9yXTZrMPt7OQbt7pbyxZ+oduyzilKUjUeGmvkZeFSMLu/gDp1zF4JJnmcD144hBLzEtpGiYvpQEKhQwE3x3gk9t29+B29rPlwjOYfGHJza+4kU//0mn/SWCMuMOGz/mYeuDDd+uCQ2nrReMk+6Sf2bsxVyw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com; Subject: Re: [PATCH] common: guest_physmap_add_page()'s return value needs checking To: Andrew Cooper CC: George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , "xen-devel@lists.xenproject.org" References: <601d46e2-5c08-3948-85bc-1e027358700b@citrix.com> From: Jan Beulich Message-ID: Date: Thu, 2 Sep 2021 09:00:17 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: <601d46e2-5c08-3948-85bc-1e027358700b@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: PR3P192CA0008.EURP192.PROD.OUTLOOK.COM (2603:10a6:102:56::13) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 50850b0e-bddc-4423-4431-08d96ddf5400 X-MS-TrafficTypeDiagnostic: VI1PR04MB2959: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ajOC5YbxyrAjr3artB7TyVqDX0NBsY04+jrVNIyT8YSPyd4j8gbNE9znkT/+gSweUNMfg4fagRkwJgV9DJlOHhC8BXfqUANMf1Mj6arnPHEbZW68quhBMSg/WPNl0TP3DDc6QLGJWyENbyRfJcI/CnPDGFiLfPRKrCIEwoxJObPFKknQflyuRmu4tT25LV1u4jWc0GrULi3E58ZAYYuutQZnMPi7mm8WGp9/jl/N+DC4OaqiJCayNpZyAhNwnkSwsV3Ag8JINMnQizcxry/bI0Te+09ZnNtAXEsN/zWskTdIGXK6fVNyrZ/IfYLFgb8rRbN3FMxaoDk+gfycID60MuB4b6o82Flh+Pe3jtSBw4tkJd/365EY38j8HU9Q8U7Px0TrK2TU0zQ2uJL37QRr0RqBQecswvgdQmChTjTfYt2Pop5o0G6mb7OI6ppfEsFVzIj1ZUAupqKK4UrXI6I3UNjXUIKJk0iA5tr7t90wOm+YctpwPuAmEl/WvhYesvzaidn2tnMo2j1rt26QzPkiWU3zAJaF1WIxQr1pZyLqGEI8wBpE+ohklzghJgTP6Q/yuh/XYW+APpr1ZM/nnBclqP8KUTxCwYpvEDLXpm7BLMKMjV7yHkcgsadu9qE0ZYCRijE40If3X35DJgf1qt7N6rhK77lTOROVCSXMG/42SzRhVUB3Fi6r2emfciqG4XpWsD7DdHuFKci+ZokCjgfdX5fFhwhb8AbtgZgm1Ymj46Y= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(8676002)(956004)(2616005)(86362001)(83380400001)(66556008)(66476007)(66946007)(6916009)(6486002)(38100700002)(54906003)(4326008)(26005)(53546011)(16576012)(186003)(31696002)(8936002)(2906002)(5660300002)(508600001)(36756003)(31686004)(316002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?VcQFa+Smcz0/DkvbGOXNA2y96oLOBmYt8eyDjdxHNDnKOd4NTu8OuvHkwdMc?= =?us-ascii?Q?dKlIGSvjqxgtAj0Nwk/H/NKztLs1tRokpw1aiHvKtA+OC6swi/T/P6+qHbfb?= =?us-ascii?Q?gPqW8P2GC3D9JElgTPIi45OI24t6PeWPLNSek93k5LXrW5iBhI1uMyDDskKW?= =?us-ascii?Q?W6+cy+k9LQwR5VCL9J+q3bL+98X4inzR5A79vw+NrZfOyEWUoeuUQsrQuZOD?= =?us-ascii?Q?4Mgu5pjiTVkh1uMxq1ceiQu3LgSVFumdvpVZO+Mm3WCdyEfGW+XbV1IozK3K?= =?us-ascii?Q?KPyVcRd/KbcxFfghlvAZCKRAO7ILS3W15xGZn11UDHIghF9LqMBPquq8Wc/J?= =?us-ascii?Q?JmYSd75Fz4T6S1FXOoV8K0WHdDwyV+/KrXcCPqOpJDWNzMPg2I3JQfzhWMsT?= =?us-ascii?Q?OORgGACJybHZ7YYPtSrIRW6aE45TXDp0TUZEPr46iInT3ujBcGbeg2fU41Sv?= =?us-ascii?Q?Y1etoQvahtrtOKZo90GnXHBjaWoItH+1se9VOm5gjm45FCximU6mii5b/A+M?= =?us-ascii?Q?2TxpZkWfTsZdXId9kDRnCCC5ymBvcSHPwEtXcmyxm2VFVxBRfMLSo2ZCAbFf?= =?us-ascii?Q?8zZkPaHFCjlosIgPDvMpN3z1pYf919vE/nv4Y/kDx8NTDQ/IzLKC3AHIaQCw?= =?us-ascii?Q?KL8LrKmNhmmL2Qamef4MnJ6jWcj6WuCX2KZmwfi7Z46qzPFDTD44aoJ4kJiS?= =?us-ascii?Q?HBJPzSwXjMglKsfAK/rt2g3WffYDuHAFIFTouLXRU9D+6QF3H0ZtkW4L1Vcx?= =?us-ascii?Q?aDeMEoK3/Q32mU/TRlATdwZoYGKtoDRgBJ7VP1tNM4Q5Pyd5V5F7S4cPxIb3?= =?us-ascii?Q?6bLcJ6iDcmwXgI3hLzxtGxCqV3aRiK7Ie5ezoi/MFQXHV8dQSioRmknjZZNa?= =?us-ascii?Q?QkQnCds/kXogIZ4TZaLYXf5P9t9QlNs6wmFv68Y1tqRpLNoqK967ww2O+apP?= =?us-ascii?Q?aaLV/teVrhxAlxsBeC4vOZ/a3JfP7UGY5DF3dECuewAMEeMeUohTPc7YXXC1?= =?us-ascii?Q?eU3Gsfs/7H+tpdlo3IRh9SHMw4Kbc7an2n8MTHlcoH3MNaDer7pSUuM6MvM6?= =?us-ascii?Q?8tUJHhGf/DwCYiHdnIymTjoXT7FKJOCroJlHx/hlaXWMeau5lE6E+FtqDgqP?= =?us-ascii?Q?pWJndGv/tG7yt4nPiDuHms6VuWIs2raty50do2QCQupBwwx9xKxzr1aE205t?= =?us-ascii?Q?4i/NTxo3c9fSJPwnGjSZeCK6o1b6PBqjOv4GwV2TnT5qsO8BE9rRLQkTCSU7?= =?us-ascii?Q?LyEh08nM6U444bQx/7WY82euh3pDG5cmePFzzSRSECw1j89PoVQOjkK2YgYx?= =?us-ascii?Q?viNgC0Q7REVrg16NV4s3a9Qu?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 50850b0e-bddc-4423-4431-08d96ddf5400 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Sep 2021 07:00:20.5313 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: DxvZLK+3wbulOW9nm26/HNyejGgufW5bh0DK93kwApz798waMVFtvqQdftR3VES4GtnTZrbpXL5v/Bi55rNdFg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB2959 On 01.09.2021 22:02, Andrew Cooper wrote: > On 01/09/2021 17:06, Jan Beulich wrote: >> The function may fail; it is not correct to indicate "success" in this >> case up the call stack. Mark the function must-check to prove all >> cases have been caught (and no new ones will get introduced). >> >> Signed-off-by: Jan Beulich >> --- >> In the grant-transfer case it is not really clear to me whether we can >> stick to setting GTF_transfer_completed in the error case. Since a guest >> may spin-wait for the flag to become set, simply not setting the flag is >> not an option either. I was wondering whether we may want to slightly >> alter (extend) the ABI and allow for a GTF_transfer_committed -> >> GTF_transfer_completed transition (i.e. clearing GTF_transfer_committed >> at the same time as setting GTF_transfer_completed). >=20 > Considering there are no production users of gnttab_transfer(), we can > do what we want.=C2=A0 It was introduced for (IIRC) netlink2 and never go= t > into production, and then we clobbered it almost entirely in an XSA > several years ago by restricting steal_page() to PV guests only. >=20 > As a consequence, we can do anything which seems sensible, and does not > necessarily need to be bound by a guest spinning on the bit. Is this a "yes, let's go that route" then? Or rather leaving it to me, i.e. translating "we can do anything which seems sensible" to "feel free to do anything which seems sensible"? Which might as well be what is there right now, and hence there could be the implied question of whether your reply could be translated to an ack. > The concept of gnttab_transfer() alone is crazy from an in-guest memory > management point of view.=C2=A0 We could alternatively save our future se= lves > more trouble by just Kconfig'ing it out now, deleting it in several > releases time, and fogetting about the problem as nothing will break in > practice. I might ack such an initial patch. I might even consider making one myself as long as it's agreed that the option will need to default to y. I might also ack such a subsequent patch. But I would not want to be the one to propose a patch removing functionality. I think I did say more than once in the past that I don't think we can validly remove anything from the public interface, as we will never be able to _prove_ there's no user anywhere. An exception might only be in cases where we can prove certain functionality could never have been used successfully for its intended or any other purpose. (For example, recently I've [again] been considering to fully disable XENMEM_increase_reservation for translated guests, rather than just leaving it useless by not reporting back the allocated MFNs.) Jan From xen-devel-bounces@lists.xenproject.org Thu Sep 02 07:01:56 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 07:01:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177056.322240 (Exim 4.92) (envelope-from ) id 1mLgjM-00075L-M1; Thu, 02 Sep 2021 07:01:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177056.322240; Thu, 02 Sep 2021 07:01:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLgjM-00075E-IB; Thu, 02 Sep 2021 07:01:48 +0000 Received: by outflank-mailman (input) for mailman id 177056; Thu, 02 Sep 2021 07:01:47 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLgjL-000756-GI for xen-devel@lists.xenproject.org; Thu, 02 Sep 2021 07:01:47 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id a2d0c698-0bbb-11ec-ae41-12813bfff9fa; Thu, 02 Sep 2021 07:01:46 +0000 (UTC) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05lp2105.outbound.protection.outlook.com [104.47.17.105]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-1-OLV-JV4COwOG_7GeAIMqYQ-1; Thu, 02 Sep 2021 09:01:44 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR04MB7151.eurprd04.prod.outlook.com (2603:10a6:800:129::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.17; Thu, 2 Sep 2021 07:01:43 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4478.021; Thu, 2 Sep 2021 07:01:43 +0000 Received: from [10.156.60.236] (37.24.206.209) by AM0PR03CA0012.eurprd03.prod.outlook.com (2603:10a6:208:14::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.17 via Frontend Transport; Thu, 2 Sep 2021 07:01:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a2d0c698-0bbb-11ec-ae41-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1630566105; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=27WMxhXQJYDK8zBJxq3wqZWYbPIQe9ZgUpLtLbNSdZo=; b=A3qlVHgvffdkiGTZ/azdUis9J0mJNJul+Pong685ScUO69AC/9rzl48r2jFiy7uUrgGzGk J2fDAv3oFvGU/aCiNr5SXMp1JZE25HP2W68lJC689UdnrZOGvgvWM4DDMHTed7NlSDD7kW 0gkD/ka9Jgf4KQlFGFpLzOF/QXtbloQ= X-MC-Unique: OLV-JV4COwOG_7GeAIMqYQ-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nHEnISrcHdZrmeEhjciMwCW7JIRW3f0n2KvAxSRbtZII+QfpNvzbT/1mnXRYPve6+raQpdkpr5DsdYF79HjCGSs5U0d9Y8/gcSBquK8t+m5VJEy26R3Aoguh1M+zF8rP+CmQQXWev6sv2CH02F+YsXc7Y7Z5KTxgt8EzGJm3wdp5Qaz5KcPbwfnXu7VuaBfzf1onlo3A20NuhzJEusn/H1nVz87uksPG9YD4oefzeP2MMAp7vb0YJFLk+KIfENJNdbTgijsDYN/FVBh6/cC5LYRQHGOSXYDilO8Y1dNFKipObTrFYvvqarIUGWrvqAf9Z5TvpScN/RxxFQhO1oE6PA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=27WMxhXQJYDK8zBJxq3wqZWYbPIQe9ZgUpLtLbNSdZo=; b=k+vYz7XkeCgxv0UA8VqD72xKzK2oYkw5izLtTAyYeAuEf4SMSrSOfTL0ZngxdzFOtnw6Ftbi6n8K8i/20YgUJqqBWmhGRSE837k+MMvrZc1P32elvt67ptuyaOoUyYhCAVsv2o7eaq8BGJudYL6BkIEXOUdq0JGi/jyyE4GQ01iSr9qyJyLyj1oFVjl1F+Ah8+hmYYVZ4mFTmdcBqyocW7+jaOXnQSSdQIqxz/V7PcbweZf78dSp9yApQxwBC7TwvOiB4z8/cTATGZHeU8dasTRmS259JsMZ5pmFWL89RFs8BhwKVMZBZYPrvv01SlcRaT0+qFjXvcP4pmTeRcSzoA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: citrix.com; dkim=none (message not signed) header.d=none;citrix.com; dmarc=none action=none header.from=suse.com; To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , George Dunlap From: Jan Beulich Subject: [PATCH] x86/p2m-pt: fix p2m_flags_to_access() Message-ID: <2ec3fb93-5b91-15d0-4769-adf414af86b9@suse.com> Date: Thu, 2 Sep 2021 09:01:41 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM0PR03CA0012.eurprd03.prod.outlook.com (2603:10a6:208:14::25) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: cd5acd9f-2fb4-4565-b91c-08d96ddf85a0 X-MS-TrafficTypeDiagnostic: VI1PR04MB7151: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: N9Rmf4qgpAwGvEOWd0pbMrv85qMp/QOUoLk0i/IsWjLIY7Mu14hvufIYYsIff0HYZ3+wW7UL9rM8HNd0hzHiakjz1KINuP9uJktc21yOR4Eve5riUQff4r5aBEhesAeNzGH5SReLNTvwahb1YPEhbW9hx5qQczrko4wKAMKqQRUWWaZuprLKfTgT5wol+0mAwbptBPU91Da/KdU+kj5KmykWx8ORIzECAQOUgy4qxO1kSpS8pnIZrJyCXVqiDbmZe4k4jEyJwmWFDLejeDDAL/y3ZGyED2U6fyXFKtb68AfhnUrDzpr20x+byMGbiGLq4DOqOBwPTiOLgCzPkFSpJMRK+zPv+BVgi21FPmffndYOvIFOusaUjXbtzl0V6g/kzq6mDFV6Ck7r1lygOkVOWcVGSoOg7Bxtty2z83R11DFHUcRKOf5DyF3U+0Gh3VhClJTFFGQfMx58TS6YvfuxbU8+mXv+fyW3CaiPhmZLktCQYuSEP5U46DTMWZDzOo6xwrMc9/MiTiE0snTmkl2YTLdOzrrSkXGZfxbmM3prOj/aRppRpKF8EDwMgOarWiHSw+J/DRDZziK8ZsHTPDRPcTrTyIgbiqkprcC1uQgFI6HJMQY7fVInF+c1PKeDKmu2DeoaMr8vAUy7eCyBNXLNm1EaWxm8ohwxEZXJSnXyYC9lj0QyQLCBat0Bsvs7LLgxEOpbXWiQjwv5Qjzp1X2MjNIshOW4/Ep40eIo3iEJGxg= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(39860400002)(366004)(136003)(396003)(346002)(376002)(6486002)(5660300002)(83380400001)(86362001)(956004)(2616005)(54906003)(31696002)(31686004)(6916009)(36756003)(478600001)(316002)(16576012)(66556008)(66946007)(66476007)(38100700002)(186003)(26005)(4326008)(8936002)(2906002)(8676002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?azB0YlpoQm91WThOQ2hPRHZmVTh1VE5uMFJjempNOGpwL3BpbUxUOUlaMmcv?= =?utf-8?B?LzI5NlFPSTBEejZqemR3bDB4d1BKa1dQME9TdVA5dTFZRXNuWEMrR21tSVFH?= =?utf-8?B?anNQZkJPMXRja01TeHNEWktmTjgyQnRGQ3VEN3hSZ2VPWm9NZmc0NCtscUVx?= =?utf-8?B?VEV4ZmpuNDRqb1dWUEp0c0FCcTNuTy9iMDNBb01DcHJQWmpEVFZvTi9sN0Fj?= =?utf-8?B?UmVtRTdZa0tSdE45L3lQdGxqSDRpUUNBSDVFbTl4c0ZBb0UwRkZoaThSVmtv?= =?utf-8?B?MFcwRHFUQllCcmZlN2g0c0diNXFadjJlM2kxMEJvb0RFdjZteW81L0s3dUVE?= =?utf-8?B?K0t5M0lhbllFNmhHZlNwenc1NnQ5UWJwWG9zZkJkSVBMSzJZQlJ0UW5RbXVS?= =?utf-8?B?RngwZnhDUHRCVVBzTlVOSDJ0elE5UW0vVm5MN3Y4U0Q3dkI3UmZHb0VyUVd6?= =?utf-8?B?S3UxVDRXZEt5RHhpWTlQRkVrV3dpWURmbzk5R2dxNTNSc2lROGtDbXNJRHVY?= =?utf-8?B?bEVrU2FmZ3lWMjd0UzRTRGxMd0IvOVlCN1JFWDJNckFTZm1FV0pMT1ZCVHQr?= =?utf-8?B?Zzh6aWtuM3I5cktsdHZzandQT21pV2ZkU2duL1QzTWhnUERaZExaTzl4NnNQ?= =?utf-8?B?QlpPVHowcUNjbndyT1BwZzFyV0ppTjhZUnUvdjVjb0p6bGxUN2ZENGZwaG9r?= =?utf-8?B?TUZ1Z2tlM0pRTEFYQ3JlVkpHTWhRdEtFNWdmVjE5TS9STTRiMnRTcjBqaTJ2?= =?utf-8?B?bUFZbXJOVlRIanFXZ1l3VmYrSituejlLbWFJOUErM1BlODlmVzFNc1liUWpu?= =?utf-8?B?QmVMQkxvQ3AwTEV5UUw0VXp6L0FEVDJ0RzJsOUFKNm1zS3NYVHIxYmF0VzR5?= =?utf-8?B?SUEwMjNlRXVoVzF5NGtrdkNJM0hocUNXTzVlMVp1aHBNVnk0cmJOMDB5MXJV?= =?utf-8?B?OU9QTGVsVW5VQkx1YnMyUElJYzYvbkxBaTVwQWpia0dWam0wZGcya3hwM2Qy?= =?utf-8?B?K1NoRnB1VGtyVmRBV3JzOEVGWmtQRnJ6ekdTSlF0b2N3eWc2TVJSOCt6c0hy?= =?utf-8?B?MU5pdWtQbENpdG1YZzBYWXgraGhIVEh4NXdFOE85QWJreGl4eC9XbkhzU3Yv?= =?utf-8?B?blAzWkFLSlBOV2FkL2p6a2RmR1orYU9pR205QVgxbTNBL1hGNXB3V2padGFM?= =?utf-8?B?Q2JZUzdCd2s1ZTRmbmcwL3p0cm5Yd2FFUjFGTU1WQVVZQ3JxLzZlNzdGV3Jx?= =?utf-8?B?S0ZYVkdFdnk0TWorbDVnR1BMMUFTK1REeXAvdFpPa3lrUDdMSFJsUFFKME1y?= =?utf-8?B?OFZsbzNaSE4xVEhma1ZZWkVQTk9mQ2pQR3cxLy9aWW9tM2NZVkp1bTUvQUJO?= =?utf-8?B?T2ZTN2VRVEh2T2xxYUxxZnp4aHJDTFkvL1ZET1R6SEE3eklkRXBkVkQzVnN2?= =?utf-8?B?amxXWmUxMUcrYXd4SG1OeXNyZHV2c0lqUVFTSi9QdDd3Tjd2M0o2cEpmbkVJ?= =?utf-8?B?QWpyNC9Ca3NNaWNCOXNaZXg4MlowdTBTWVpXNWszY0MwNHhOYUlVTWlyUVM0?= =?utf-8?B?dXlZK0I4clhQSGl0WmpYYjlpbmtXQW1maGxmMHJzNlNKMGlHUENBQ05NMzhm?= =?utf-8?B?eHZpaVpPNFA0Smc0dHhkU0JBOWNSTGs1TDd3aVBHdWFpQytTQlJlMnNhcmY4?= =?utf-8?B?dFFLdVZpTkJ4ZHFEZjRMVVlaUStSUWZRT3ZjUlRBa2FmMmM0Q0tNMUhhenB2?= =?utf-8?Q?4S3ob/DlcQOh1LqZRns70TEGq+qG13/O8WY5rdI?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: cd5acd9f-2fb4-4565-b91c-08d96ddf85a0 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Sep 2021 07:01:43.7642 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9RIxMwgIb1xSBrHgKfR2il+Ua6kz7tlEfwDWWrxlQNY9xBjo97EMDWwzH+z60sdiJHzlysMMm5OdVt1R4Gpfow== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7151 The initial if() was inverted, invalidating all output from this function. Which in turn means the mirroring of P2M mappings into the IOMMU didn't always work as intended: Mappings may have got updated when there was no need to. There would not have been too few (un)mappings; what saves us is that alongside the flags comparison MFNs also get compared, with non-present entries always having an MFN of 0 or INVALID_MFN while present entries always have MFNs different from these two (0 in the table also meant to cover INVALID_MFN): OLD NEW P W access MFN P W access MFN 0 0 r 0 0 0 n 0 0 1 rw 0 0 1 n 0 1 0 n non-0 1 0 r non-0 1 1 n non-0 1 1 rw non-0 present <-> non-present transitions are fine because the MFNs differ. present -> present transitions as well as non-present -> non-present ones are potentially causing too many map/unmap operations, but never too few, because in that case old (bogus) and new access differ. Fixes: d1bb6c97c31e ("IOMMU: also pass p2m_access_t to p2m_get_iommu_flags()) Signed-off-by: Jan Beulich --- a/xen/arch/x86/mm/p2m-pt.c +++ b/xen/arch/x86/mm/p2m-pt.c @@ -548,7 +548,7 @@ int p2m_pt_handle_deferred_changes(uint6 /* Reconstruct a fake p2m_access_t from stored PTE flags. */ static p2m_access_t p2m_flags_to_access(unsigned int flags) { - if ( flags & _PAGE_PRESENT ) + if ( !(flags & _PAGE_PRESENT) ) return p2m_access_n; /* No need to look at _PAGE_NX for now. */ From xen-devel-bounces@lists.xenproject.org Thu Sep 02 07:19:36 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 07:19:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177062.322251 (Exim 4.92) (envelope-from ) id 1mLh0M-0000WO-Vi; Thu, 02 Sep 2021 07:19:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177062.322251; Thu, 02 Sep 2021 07:19:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLh0M-0000WH-Rz; Thu, 02 Sep 2021 07:19:22 +0000 Received: by outflank-mailman (input) for mailman id 177062; Thu, 02 Sep 2021 07:19:22 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLh0L-0000WB-Tc for xen-devel@lists.xen.org; Thu, 02 Sep 2021 07:19:21 +0000 Received: from mail-pg1-x52f.google.com (unknown [2607:f8b0:4864:20::52f]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id b1a972a6-c42a-43dd-8b2e-5bf38f908459; Thu, 02 Sep 2021 07:19:13 +0000 (UTC) Received: by mail-pg1-x52f.google.com with SMTP id f129so1004812pgc.1 for ; Thu, 02 Sep 2021 00:19:13 -0700 (PDT) Received: from laputa (p784a44f4.tkyea130.ap.so-net.ne.jp. [120.74.68.244]) by smtp.gmail.com with ESMTPSA id a1sm1355173pgt.47.2021.09.02.00.19.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Sep 2021 00:19:11 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b1a972a6-c42a-43dd-8b2e-5bf38f908459 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=2lOwlOf92xRQZ27XUHLa6fDJUvFnDxY8HtJzSHF0QdM=; b=AoRoz7WdNEuSMcu3bkrghr0jyxkFc0ZM7XiodMFBjs5shG6pEI5HFWEHU0Lp/eTJ/d Np89iwjpE4kGLpa2BFxahcbIbpKs8aZN/ag5M35NO/j9CtJP6vltBV3Il/L/0Bp/8wHL ErqdtsIKDAzs+NAqrMZLgC4MccXy9gRg0SVuJ0UCvwmrxjk/i4C+g8E49Qz0usShYdWv CNK+DGPQJ9ddd67R2iJzJwUEBIae5XhXt2UadZ6D2zHR4CoM7UbJiX0UklV0ADyjVxqU L0RrD/yErltWETAUIBATXWLgVQkLhQbQpHEWEicfRgq1me9DDNNriInz/qTy3q7ISCJy e9uQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=2lOwlOf92xRQZ27XUHLa6fDJUvFnDxY8HtJzSHF0QdM=; b=UMxHXQLftBEJvRVJSLV6tsL06VElwlc8bdvJMPaHs9209JtTxLda6rQBHaxnZXwag9 P/kcPqr5X4lS4holHlIauEy7AZjBoTd0sOHcFL6Y/gLak+XjqgmqsDyZwu7/wmQ8f70M gJpKvHibW6ueRgNGomRG2gzNhU8lXs2anOlNrhqG8S1ilQC/kFim30NlW5qPeLHN3rPF cl9Dz/uTuecVWcOWUQWCa0aWVwMrWZum1hnQYnBlptuKk/XLQ5pu6aIBa7QsHbsYXCxM yPi1T5OmUg79XwxfHBZ//2WPJfVZ7/dohpQLIeEiRXWGtkFaN0tU14kRbRD45aJdyBSM sseg== X-Gm-Message-State: AOAM532amTXTPVqwGwnmLBTKbAdIxwXx0aFipfO7lW9zAVU2INilBqPq 4NTEuiA2Kin6oMAdpMnNeuqY2w== X-Google-Smtp-Source: ABdhPJy4a+nNN6RWBSYKYShbk20muC5dtgGesXq8wgcPokrFdgcwMQx+4CpQChDoPxIV+vfk9ilkTA== X-Received: by 2002:a62:1453:0:b0:3fd:ffd5:35cf with SMTP id 80-20020a621453000000b003fdffd535cfmr1977907pfu.34.1630567152430; Thu, 02 Sep 2021 00:19:12 -0700 (PDT) Date: Thu, 2 Sep 2021 16:19:02 +0900 From: AKASHI Takahiro To: Christopher Clark Cc: Wei Chen , Oleksandr Tyshchenko , Stefano Stabellini , Alex Benn??e , Kaly Xin , Stratos Mailing List , "virtio-dev@lists.oasis-open.org" , Arnd Bergmann , Viresh Kumar , Stefano Stabellini , "stefanha@redhat.com" , Jan Kiszka , Carl van Schaik , "pratikp@quicinc.com" , Srivatsa Vaddagiri , Jean-Philippe Brucker , Mathieu Poirier , Oleksandr Tyshchenko , Bertrand Marquis , Artem Mygaiev , Julien Grall , Juergen Gross , Paul Durrant , Xen Devel , Rich Persaud , Daniel Smith Subject: Re: Enabling hypervisor agnosticism for VirtIO backends Message-ID: <20210902071902.GC71098@laputa> References: <20210817080757.GC43203@laputa> <20210818053840.GE39588@laputa> <20210820064150.GC13452@laputa> <20210826094047.GA55218@laputa> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Hi Christopher, Thank you for your feedback. On Mon, Aug 30, 2021 at 12:53:00PM -0700, Christopher Clark wrote: > [ resending message to ensure delivery to the CCd mailing lists > post-subscription ] > > Apologies for being late to this thread, but I hope to be able to > contribute to > this discussion in a meaningful way. I am grateful for the level of > interest in > this topic. I would like to draw your attention to Argo as a suitable > technology for development of VirtIO's hypervisor-agnostic interfaces. > > * Argo is an interdomain communication mechanism in Xen (on x86 and Arm) > that > can send and receive hypervisor-mediated notifications and messages > between > domains (VMs). [1] The hypervisor can enforce Mandatory Access Control > over > all communication between domains. It is derived from the earlier v4v, > which > has been deployed on millions of machines with the HP/Bromium uXen > hypervisor > and with OpenXT. > > * Argo has a simple interface with a small number of operations that was > designed for ease of integration into OS primitives on both Linux > (sockets) > and Windows (ReadFile/WriteFile) [2]. > - A unikernel example of using it has also been developed for XTF. [3] > > * There has been recent discussion and support in the Xen community for > making > revisions to the Argo interface to make it hypervisor-agnostic, and > support > implementations of Argo on other hypervisors. This will enable a single > interface for an OS kernel binary to use for inter-VM communication that > will > work on multiple hypervisors -- this applies equally to both backends and > frontend implementations. [4] Regarding virtio-over-Argo, let me ask a few questions: (In figure "Virtual device buffer access:Virtio+Argo" in [4]) 1) How the configuration is managed? On either virtio-mmio or virtio-pci, there always takes place some negotiation between the FE and BE through the "configuration" space. How can this be done in virtio-over-Argo? 2) Do there physically exist virtio's available/used vrings as well as descriptors, or are they virtually emulated over Argo (rings)? 3) The payload in a request will be copied into the receiver's Argo ring. What does the address in a descriptor mean? Address/offset in a ring buffer? 4) Estimate of performance or latency? It appears that, on FE side, at least three hypervisor calls (and data copying) need to be invoked at every request, right? Thanks, -Takahiro Akashi > * Here are the design documents for building VirtIO-over-Argo, to support a > hypervisor-agnostic frontend VirtIO transport driver using Argo. > > The Development Plan to build VirtIO virtual device support over Argo > transport: > https://openxt.atlassian.net/wiki/spaces/DC/pages/1696169985/VirtIO-Argo+Development+Phase+1 > > A design for using VirtIO over Argo, describing how VirtIO data structures > and communication is handled over the Argo transport: > https://openxt.atlassian.net/wiki/spaces/DC/pages/1348763698/VirtIO+Argo > > Diagram (from the above document) showing how VirtIO rings are synchronized > between domains without using shared memory: > https://openxt.atlassian.net/46e1c93b-2b87-4cb2-951e-abd4377a1194#media-blob-url=true&id=01f7d0e1-7686-4f0b-88e1-457c1d30df40&collection=contentId-1348763698&contextId=1348763698&mimeType=image%2Fpng&name=device-buffer-access-virtio-argo.png&size=243175&width=1106&height=1241 > > Please note that the above design documents show that the existing VirtIO > device drivers, and both vring and virtqueue data structures can be > preserved > while interdomain communication can be performed with no shared memory > required > for most drivers; (the exceptions where further design is required are those > such as virtual framebuffer devices where shared memory regions are > intentionally > added to the communication structure beyond the vrings and virtqueues). > > An analysis of VirtIO and Argo, informing the design: > https://openxt.atlassian.net/wiki/spaces/DC/pages/1333428225/Analysis+of+Argo+as+a+transport+medium+for+VirtIO > > * Argo can be used for a communication path for configuration between the > backend > and the toolstack, avoiding the need for a dependency on XenStore, which > is an > advantage for any hypervisor-agnostic design. It is also amenable to a > notification > mechanism that is not based on Xen event channels. > > * Argo does not use or require shared memory between VMs and provides an > alternative > to the use of foreign shared memory mappings. It avoids some of the > complexities > involved with using grants (eg. XSA-300). > > * Argo supports Mandatory Access Control by the hypervisor, satisfying a > common > certification requirement. > > * The Argo headers are BSD-licensed and the Xen hypervisor implementation > is GPLv2 but > accessible via the hypercall interface. The licensing should not present > an obstacle > to adoption of Argo in guest software or implementation by other > hypervisors. > > * Since the interface that Argo presents to a guest VM is similar to DMA, a > VirtIO-Argo > frontend transport driver should be able to operate with a physical > VirtIO-enabled > smart-NIC if the toolstack and an Argo-aware backend provide support. > > The next Xen Community Call is next week and I would be happy to answer > questions > about Argo and on this topic. I will also be following this thread. > > Christopher > (Argo maintainer, Xen Community) > > -------------------------------------------------------------------------------- > [1] > An introduction to Argo: > https://static.sched.com/hosted_files/xensummit19/92/Argo%20and%20HMX%20-%20OpenXT%20-%20Christopher%20Clark%20-%20Xen%20Summit%202019.pdf > https://www.youtube.com/watch?v=cnC0Tg3jqJQ > Xen Wiki page for Argo: > https://wiki.xenproject.org/wiki/Argo:_Hypervisor-Mediated_Exchange_(HMX)_for_Xen > > [2] > OpenXT Linux Argo driver and userspace library: > https://github.com/openxt/linux-xen-argo > > Windows V4V at OpenXT wiki: > https://openxt.atlassian.net/wiki/spaces/DC/pages/14844007/V4V > Windows v4v driver source: > https://github.com/OpenXT/xc-windows/tree/master/xenv4v > > HP/Bromium uXen V4V driver: > https://github.com/uxen-virt/uxen/tree/ascara/windows/uxenv4vlib > > [3] > v2 of the Argo test unikernel for XTF: > https://lists.xenproject.org/archives/html/xen-devel/2021-01/msg02234.html > > [4] > Argo HMX Transport for VirtIO meeting minutes: > https://lists.xenproject.org/archives/html/xen-devel/2021-02/msg01422.html > > VirtIO-Argo Development wiki page: > https://openxt.atlassian.net/wiki/spaces/DC/pages/1696169985/VirtIO-Argo+Development+Phase+1 > > > > On Thu, Aug 26, 2021 at 5:11 AM Wei Chen wrote: > > > >> Hi Akashi, > >> > >> > -----Original Message----- > >> > From: AKASHI Takahiro > >> > Sent: 2021年8月26日 17:41 > >> > To: Wei Chen > >> > Cc: Oleksandr Tyshchenko ; Stefano Stabellini > >> > ; Alex Benn??e ; Kaly > >> Xin > >> > ; Stratos Mailing List < > >> stratos-dev@op-lists.linaro.org>; > >> > virtio-dev@lists.oasis-open.org; Arnd Bergmann < > >> arnd.bergmann@linaro.org>; > >> > Viresh Kumar ; Stefano Stabellini > >> > ; stefanha@redhat.com; Jan Kiszka > >> > ; Carl van Schaik ; > >> > pratikp@quicinc.com; Srivatsa Vaddagiri ; Jean- > >> > Philippe Brucker ; Mathieu Poirier > >> > ; Oleksandr Tyshchenko > >> > ; Bertrand Marquis > >> > ; Artem Mygaiev ; > >> Julien > >> > Grall ; Juergen Gross ; Paul Durrant > >> > ; Xen Devel > >> > Subject: Re: Enabling hypervisor agnosticism for VirtIO backends > >> > > >> > Hi Wei, > >> > > >> > On Fri, Aug 20, 2021 at 03:41:50PM +0900, AKASHI Takahiro wrote: > >> > > On Wed, Aug 18, 2021 at 08:35:51AM +0000, Wei Chen wrote: > >> > > > Hi Akashi， > >> > > > > >> > > > > -----Original Message----- > >> > > > > From: AKASHI Takahiro > >> > > > > Sent: 2021年8月18日 13:39 > >> > > > > To: Wei Chen > >> > > > > Cc: Oleksandr Tyshchenko ; Stefano > >> Stabellini > >> > > > > ; Alex Benn??e ; > >> > Stratos > >> > > > > Mailing List ; virtio- > >> > dev@lists.oasis- > >> > > > > open.org; Arnd Bergmann ; Viresh Kumar > >> > > > > ; Stefano Stabellini > >> > > > > ; stefanha@redhat.com; Jan Kiszka > >> > > > > ; Carl van Schaik > >> > ; > >> > > > > pratikp@quicinc.com; Srivatsa Vaddagiri ; > >> > Jean- > >> > > > > Philippe Brucker ; Mathieu Poirier > >> > > > > ; Oleksandr Tyshchenko > >> > > > > ; Bertrand Marquis > >> > > > > ; Artem Mygaiev >> >; > >> > Julien > >> > > > > Grall ; Juergen Gross ; Paul > >> > Durrant > >> > > > > ; Xen Devel > >> > > > > Subject: Re: Enabling hypervisor agnosticism for VirtIO backends > >> > > > > > >> > > > > On Tue, Aug 17, 2021 at 08:39:09AM +0000, Wei Chen wrote: > >> > > > > > Hi Akashi, > >> > > > > > > >> > > > > > > -----Original Message----- > >> > > > > > > From: AKASHI Takahiro > >> > > > > > > Sent: 2021年8月17日 16:08 > >> > > > > > > To: Wei Chen > >> > > > > > > Cc: Oleksandr Tyshchenko ; Stefano > >> > Stabellini > >> > > > > > > ; Alex Benn??e < > >> alex.bennee@linaro.org>; > >> > > > > Stratos > >> > > > > > > Mailing List ; virtio- > >> > > > > dev@lists.oasis- > >> > > > > > > open.org; Arnd Bergmann ; Viresh > >> Kumar > >> > > > > > > ; Stefano Stabellini > >> > > > > > > ; stefanha@redhat.com; Jan > >> Kiszka > >> > > > > > > ; Carl van Schaik > >> > ; > >> > > > > > > pratikp@quicinc.com; Srivatsa Vaddagiri >> >; > >> > Jean- > >> > > > > > > Philippe Brucker ; Mathieu Poirier > >> > > > > > > ; Oleksandr Tyshchenko > >> > > > > > > ; Bertrand Marquis > >> > > > > > > ; Artem Mygaiev > >> > ; > >> > > > > Julien > >> > > > > > > Grall ; Juergen Gross ; Paul > >> > Durrant > >> > > > > > > ; Xen Devel > >> > > > > > > Subject: Re: Enabling hypervisor agnosticism for VirtIO > >> backends > >> > > > > > > > >> > > > > > > Hi Wei, Oleksandr, > >> > > > > > > > >> > > > > > > On Mon, Aug 16, 2021 at 10:04:03AM +0000, Wei Chen wrote: > >> > > > > > > > Hi All, > >> > > > > > > > > >> > > > > > > > Thanks for Stefano to link my kvmtool for Xen proposal here. > >> > > > > > > > This proposal is still discussing in Xen and KVM > >> communities. > >> > > > > > > > The main work is to decouple the kvmtool from KVM and make > >> > > > > > > > other hypervisors can reuse the virtual device > >> implementations. > >> > > > > > > > > >> > > > > > > > In this case, we need to introduce an intermediate > >> hypervisor > >> > > > > > > > layer for VMM abstraction, Which is, I think it's very close > >> > > > > > > > to stratos' virtio hypervisor agnosticism work. > >> > > > > > > > >> > > > > > > # My proposal[1] comes from my own idea and doesn't always > >> > represent > >> > > > > > > # Linaro's view on this subject nor reflect Alex's concerns. > >> > > > > Nevertheless, > >> > > > > > > > >> > > > > > > Your idea and my proposal seem to share the same background. > >> > > > > > > Both have the similar goal and currently start with, at first, > >> > Xen > >> > > > > > > and are based on kvm-tool. (Actually, my work is derived from > >> > > > > > > EPAM's virtio-disk, which is also based on kvm-tool.) > >> > > > > > > > >> > > > > > > In particular, the abstraction of hypervisor interfaces has a > >> > same > >> > > > > > > set of interfaces (for your "struct vmm_impl" and my "RPC > >> > interfaces"). > >> > > > > > > This is not co-incident as we both share the same origin as I > >> > said > >> > > > > above. > >> > > > > > > And so we will also share the same issues. One of them is a > >> way > >> > of > >> > > > > > > "sharing/mapping FE's memory". There is some trade-off between > >> > > > > > > the portability and the performance impact. > >> > > > > > > So we can discuss the topic here in this ML, too. > >> > > > > > > (See Alex's original email, too). > >> > > > > > > > >> > > > > > Yes, I agree. > >> > > > > > > >> > > > > > > On the other hand, my approach aims to create a > >> "single-binary" > >> > > > > solution > >> > > > > > > in which the same binary of BE vm could run on any > >> hypervisors. > >> > > > > > > Somehow similar to your "proposal-#2" in [2], but in my > >> solution, > >> > all > >> > > > > > > the hypervisor-specific code would be put into another entity > >> > (VM), > >> > > > > > > named "virtio-proxy" and the abstracted operations are served > >> > via RPC. > >> > > > > > > (In this sense, BE is hypervisor-agnostic but might have OS > >> > > > > dependency.) > >> > > > > > > But I know that we need discuss if this is a requirement even > >> > > > > > > in Stratos project or not. (Maybe not) > >> > > > > > > > >> > > > > > > >> > > > > > Sorry, I haven't had time to finish reading your virtio-proxy > >> > completely > >> > > > > > (I will do it ASAP). But from your description, it seems we > >> need a > >> > > > > > 3rd VM between FE and BE? My concern is that, if my assumption > >> is > >> > right, > >> > > > > > will it increase the latency in data transport path? Even if > >> we're > >> > > > > > using some lightweight guest like RTOS or Unikernel, > >> > > > > > >> > > > > Yes, you're right. But I'm afraid that it is a matter of degree. > >> > > > > As far as we execute 'mapping' operations at every fetch of > >> payload, > >> > > > > we will see latency issue (even in your case) and if we have some > >> > solution > >> > > > > for it, we won't see it neither in my proposal :) > >> > > > > > >> > > > > >> > > > Oleksandr has sent a proposal to Xen mailing list to reduce this > >> kind > >> > > > of "mapping/unmapping" operations. So the latency caused by this > >> > behavior > >> > > > on Xen may eventually be eliminated, and Linux-KVM doesn't have that > >> > problem. > >> > > > >> > > Obviously, I have not yet caught up there in the discussion. > >> > > Which patch specifically? > >> > > >> > Can you give me the link to the discussion or patch, please? > >> > > >> > >> It's a RFC discussion. We have tested this RFC patch internally. > >> https://lists.xenproject.org/archives/html/xen-devel/2021-07/msg01532.html > >> > >> > Thanks, > >> > -Takahiro Akashi > >> > > >> > > -Takahiro Akashi > >> > > > >> > > > > > > Specifically speaking about kvm-tool, I have a concern about > >> its > >> > > > > > > license term; Targeting different hypervisors and different > >> OSs > >> > > > > > > (which I assume includes RTOS's), the resultant library should > >> > be > >> > > > > > > license permissive and GPL for kvm-tool might be an issue. > >> > > > > > > Any thoughts? > >> > > > > > > > >> > > > > > > >> > > > > > Yes. If user want to implement a FreeBSD device model, but the > >> > virtio > >> > > > > > library is GPL. Then GPL would be a problem. If we have another > >> > good > >> > > > > > candidate, I am open to it. > >> > > > > > >> > > > > I have some candidates, particularly for vq/vring, in my mind: > >> > > > > * Open-AMP, or > >> > > > > * corresponding Free-BSD code > >> > > > > > >> > > > > >> > > > Interesting, I will look into them : ) > >> > > > > >> > > > Cheers, > >> > > > Wei Chen > >> > > > > >> > > > > -Takahiro Akashi > >> > > > > > >> > > > > > >> > > > > > > -Takahiro Akashi > >> > > > > > > > >> > > > > > > > >> > > > > > > [1] https://op-lists.linaro.org/pipermail/stratos-dev/2021- > >> > > > > > > August/000548.html > >> > > > > > > [2] https://marc.info/?l=xen-devel&m=162373754705233&w=2 > >> > > > > > > > >> > > > > > > > > >> > > > > > > > > From: Oleksandr Tyshchenko > >> > > > > > > > > Sent: 2021年8月14日 23:38 > >> > > > > > > > > To: AKASHI Takahiro ; Stefano > >> > > > > Stabellini > >> > > > > > > > >> > > > > > > > > Cc: Alex Benn??e ; Stratos > >> Mailing > >> > List > >> > > > > > > ; virtio-dev@lists.oasis- > >> > open.org; > >> > > > > Arnd > >> > > > > > > Bergmann ; Viresh Kumar > >> > > > > > > ; Stefano Stabellini > >> > > > > > > ; stefanha@redhat.com; Jan > >> Kiszka > >> > > > > > > ; Carl van Schaik > >> > ; > >> > > > > > > pratikp@quicinc.com; Srivatsa Vaddagiri >> >; > >> > Jean- > >> > > > > > > Philippe Brucker ; Mathieu Poirier > >> > > > > > > ; Wei Chen ; > >> > Oleksandr > >> > > > > > > Tyshchenko ; Bertrand Marquis > >> > > > > > > ; Artem Mygaiev > >> > ; > >> > > > > Julien > >> > > > > > > Grall ; Juergen Gross ; Paul > >> > Durrant > >> > > > > > > ; Xen Devel > >> > > > > > > > > Subject: Re: Enabling hypervisor agnosticism for VirtIO > >> > backends > >> > > > > > > > > > >> > > > > > > > > Hello, all. > >> > > > > > > > > > >> > > > > > > > > Please see some comments below. And sorry for the possible > >> > format > >> > > > > > > issues. > >> > > > > > > > > > >> > > > > > > > > > On Wed, Aug 11, 2021 at 9:27 AM AKASHI Takahiro > >> > > > > > > wrote: > >> > > > > > > > > > On Wed, Aug 04, 2021 at 12:20:01PM -0700, Stefano > >> > Stabellini > >> > > > > wrote: > >> > > > > > > > > > > CCing people working on Xen+VirtIO and IOREQs. Not > >> > trimming > >> > > > > the > >> > > > > > > original > >> > > > > > > > > > > email to let them read the full context. > >> > > > > > > > > > > > >> > > > > > > > > > > My comments below are related to a potential Xen > >> > > > > implementation, > >> > > > > > > not > >> > > > > > > > > > > because it is the only implementation that matters, > >> but > >> > > > > because it > >> > > > > > > is > >> > > > > > > > > > > the one I know best. > >> > > > > > > > > > > >> > > > > > > > > > Please note that my proposal (and hence the working > >> > prototype)[1] > >> > > > > > > > > > is based on Xen's virtio implementation (i.e. IOREQ) and > >> > > > > > > particularly > >> > > > > > > > > > EPAM's virtio-disk application (backend server). > >> > > > > > > > > > It has been, I believe, well generalized but is still a > >> > bit > >> > > > > biased > >> > > > > > > > > > toward this original design. > >> > > > > > > > > > > >> > > > > > > > > > So I hope you like my approach :) > >> > > > > > > > > > > >> > > > > > > > > > [1] https://op-lists.linaro.org/pipermail/stratos- > >> > dev/2021- > >> > > > > > > August/000546.html > >> > > > > > > > > > > >> > > > > > > > > > Let me take this opportunity to explain a bit more about > >> > my > >> > > > > approach > >> > > > > > > below. > >> > > > > > > > > > > >> > > > > > > > > > > Also, please see this relevant email thread: > >> > > > > > > > > > > https://marc.info/?l=xen-devel&m=162373754705233&w=2 > >> > > > > > > > > > > > >> > > > > > > > > > > > >> > > > > > > > > > > On Wed, 4 Aug 2021, Alex Bennée wrote: > >> > > > > > > > > > > > Hi, > >> > > > > > > > > > > > > >> > > > > > > > > > > > One of the goals of Project Stratos is to enable > >> > hypervisor > >> > > > > > > agnostic > >> > > > > > > > > > > > backends so we can enable as much re-use of code as > >> > possible > >> > > > > and > >> > > > > > > avoid > >> > > > > > > > > > > > repeating ourselves. This is the flip side of the > >> > front end > >> > > > > > > where > >> > > > > > > > > > > > multiple front-end implementations are required - > >> one > >> > per OS, > >> > > > > > > assuming > >> > > > > > > > > > > > you don't just want Linux guests. The resultant > >> guests > >> > are > >> > > > > > > trivially > >> > > > > > > > > > > > movable between hypervisors modulo any abstracted > >> > paravirt > >> > > > > type > >> > > > > > > > > > > > interfaces. > >> > > > > > > > > > > > > >> > > > > > > > > > > > In my original thumb nail sketch of a solution I > >> > envisioned > >> > > > > > > vhost-user > >> > > > > > > > > > > > daemons running in a broadly POSIX like environment. > >> > The > >> > > > > > > interface to > >> > > > > > > > > > > > the daemon is fairly simple requiring only some > >> mapped > >> > > > > memory > >> > > > > > > and some > >> > > > > > > > > > > > sort of signalling for events (on Linux this is > >> > eventfd). > >> > > > > The > >> > > > > > > idea was a > >> > > > > > > > > > > > stub binary would be responsible for any hypervisor > >> > specific > >> > > > > > > setup and > >> > > > > > > > > > > > then launch a common binary to deal with the actual > >> > > > > virtqueue > >> > > > > > > requests > >> > > > > > > > > > > > themselves. > >> > > > > > > > > > > > > >> > > > > > > > > > > > Since that original sketch we've seen an expansion > >> in > >> > the > >> > > > > sort > >> > > > > > > of ways > >> > > > > > > > > > > > backends could be created. There is interest in > >> > > > > encapsulating > >> > > > > > > backends > >> > > > > > > > > > > > in RTOSes or unikernels for solutions like SCMI. > >> There > >> > > > > interest > >> > > > > > > in Rust > >> > > > > > > > > > > > has prompted ideas of using the trait interface to > >> > abstract > >> > > > > > > differences > >> > > > > > > > > > > > away as well as the idea of bare-metal Rust > >> backends. > >> > > > > > > > > > > > > >> > > > > > > > > > > > We have a card (STR-12) called "Hypercall > >> > Standardisation" > >> > > > > which > >> > > > > > > > > > > > calls for a description of the APIs needed from the > >> > > > > hypervisor > >> > > > > > > side to > >> > > > > > > > > > > > support VirtIO guests and their backends. However we > >> > are > >> > > > > some > >> > > > > > > way off > >> > > > > > > > > > > > from that at the moment as I think we need to at > >> least > >> > > > > > > demonstrate one > >> > > > > > > > > > > > portable backend before we start codifying > >> > requirements. To > >> > > > > that > >> > > > > > > end I > >> > > > > > > > > > > > want to think about what we need for a backend to > >> > function. > >> > > > > > > > > > > > > >> > > > > > > > > > > > Configuration > >> > > > > > > > > > > > ============= > >> > > > > > > > > > > > > >> > > > > > > > > > > > In the type-2 setup this is typically fairly simple > >> > because > >> > > > > the > >> > > > > > > host > >> > > > > > > > > > > > system can orchestrate the various modules that make > >> > up the > >> > > > > > > complete > >> > > > > > > > > > > > system. In the type-1 case (or even type-2 with > >> > delegated > >> > > > > > > service VMs) > >> > > > > > > > > > > > we need some sort of mechanism to inform the backend > >> > VM > >> > > > > about > >> > > > > > > key > >> > > > > > > > > > > > details about the system: > >> > > > > > > > > > > > > >> > > > > > > > > > > > - where virt queue memory is in it's address space > >> > > > > > > > > > > > - how it's going to receive (interrupt) and > >> trigger > >> > (kick) > >> > > > > > > events > >> > > > > > > > > > > > - what (if any) resources the backend needs to > >> > connect to > >> > > > > > > > > > > > > >> > > > > > > > > > > > Obviously you can elide over configuration issues by > >> > having > >> > > > > > > static > >> > > > > > > > > > > > configurations and baking the assumptions into your > >> > guest > >> > > > > images > >> > > > > > > however > >> > > > > > > > > > > > this isn't scalable in the long term. The obvious > >> > solution > >> > > > > seems > >> > > > > > > to be > >> > > > > > > > > > > > extending a subset of Device Tree data to user space > >> > but > >> > > > > perhaps > >> > > > > > > there > >> > > > > > > > > > > > are other approaches? > >> > > > > > > > > > > > > >> > > > > > > > > > > > Before any virtio transactions can take place the > >> > > > > appropriate > >> > > > > > > memory > >> > > > > > > > > > > > mappings need to be made between the FE guest and > >> the > >> > BE > >> > > > > guest. > >> > > > > > > > > > > > >> > > > > > > > > > > > Currently the whole of the FE guests address space > >> > needs to > >> > > > > be > >> > > > > > > visible > >> > > > > > > > > > > > to whatever is serving the virtio requests. I can > >> > envision 3 > >> > > > > > > approaches: > >> > > > > > > > > > > > > >> > > > > > > > > > > > * BE guest boots with memory already mapped > >> > > > > > > > > > > > > >> > > > > > > > > > > > This would entail the guest OS knowing where in > >> it's > >> > Guest > >> > > > > > > Physical > >> > > > > > > > > > > > Address space is already taken up and avoiding > >> > clashing. I > >> > > > > > > would assume > >> > > > > > > > > > > > in this case you would want a standard interface to > >> > > > > userspace > >> > > > > > > to then > >> > > > > > > > > > > > make that address space visible to the backend > >> daemon. > >> > > > > > > > > > > >> > > > > > > > > > Yet another way here is that we would have well known > >> > "shared > >> > > > > > > memory" between > >> > > > > > > > > > VMs. I think that Jailhouse's ivshmem gives us good > >> > insights on > >> > > > > this > >> > > > > > > matter > >> > > > > > > > > > and that it can even be an alternative for hypervisor- > >> > agnostic > >> > > > > > > solution. > >> > > > > > > > > > > >> > > > > > > > > > (Please note memory regions in ivshmem appear as a PCI > >> > device > >> > > > > and > >> > > > > > > can be > >> > > > > > > > > > mapped locally.) > >> > > > > > > > > > > >> > > > > > > > > > I want to add this shared memory aspect to my > >> virtio-proxy, > >> > but > >> > > > > > > > > > the resultant solution would eventually look similar to > >> > ivshmem. > >> > > > > > > > > > > >> > > > > > > > > > > > * BE guests boots with a hypervisor handle to > >> memory > >> > > > > > > > > > > > > >> > > > > > > > > > > > The BE guest is then free to map the FE's memory to > >> > where > >> > > > > it > >> > > > > > > wants in > >> > > > > > > > > > > > the BE's guest physical address space. > >> > > > > > > > > > > > >> > > > > > > > > > > I cannot see how this could work for Xen. There is no > >> > "handle" > >> > > > > to > >> > > > > > > give > >> > > > > > > > > > > to the backend if the backend is not running in dom0. > >> So > >> > for > >> > > > > Xen I > >> > > > > > > think > >> > > > > > > > > > > the memory has to be already mapped > >> > > > > > > > > > > >> > > > > > > > > > In Xen's IOREQ solution (virtio-blk), the following > >> > information > >> > > > > is > >> > > > > > > expected > >> > > > > > > > > > to be exposed to BE via Xenstore: > >> > > > > > > > > > (I know that this is a tentative approach though.) > >> > > > > > > > > > - the start address of configuration space > >> > > > > > > > > > - interrupt number > >> > > > > > > > > > - file path for backing storage > >> > > > > > > > > > - read-only flag > >> > > > > > > > > > And the BE server have to call a particular hypervisor > >> > interface > >> > > > > to > >> > > > > > > > > > map the configuration space. > >> > > > > > > > > > >> > > > > > > > > Yes, Xenstore was chosen as a simple way to pass > >> > configuration > >> > > > > info to > >> > > > > > > the backend running in a non-toolstack domain. > >> > > > > > > > > I remember, there was a wish to avoid using Xenstore in > >> > Virtio > >> > > > > backend > >> > > > > > > itself if possible, so for non-toolstack domain, this could > >> done > >> > with > >> > > > > > > adjusting devd (daemon that listens for devices and launches > >> > backends) > >> > > > > > > > > to read backend configuration from the Xenstore anyway and > >> > pass it > >> > > > > to > >> > > > > > > the backend via command line arguments. > >> > > > > > > > > > >> > > > > > > > > >> > > > > > > > Yes, in current PoC code we're using xenstore to pass device > >> > > > > > > configuration. > >> > > > > > > > We also designed a static device configuration parse method > >> > for > >> > > > > Dom0less > >> > > > > > > or > >> > > > > > > > other scenarios don't have xentool. yes, it's from device > >> > model > >> > > > > command > >> > > > > > > line > >> > > > > > > > or a config file. > >> > > > > > > > > >> > > > > > > > > But, if ... > >> > > > > > > > > > >> > > > > > > > > > > >> > > > > > > > > > In my approach (virtio-proxy), all those Xen (or > >> > hypervisor)- > >> > > > > > > specific > >> > > > > > > > > > stuffs are contained in virtio-proxy, yet another VM, to > >> > hide > >> > > > > all > >> > > > > > > details. > >> > > > > > > > > > >> > > > > > > > > ... the solution how to overcome that is already found and > >> > proven > >> > > > > to > >> > > > > > > work then even better. > >> > > > > > > > > > >> > > > > > > > > > >> > > > > > > > > > >> > > > > > > > > > # My point is that a "handle" is not mandatory for > >> > executing > >> > > > > mapping. > >> > > > > > > > > > > >> > > > > > > > > > > and the mapping probably done by the > >> > > > > > > > > > > toolstack (also see below.) Or we would have to > >> invent a > >> > new > >> > > > > Xen > >> > > > > > > > > > > hypervisor interface and Xen virtual machine > >> privileges > >> > to > >> > > > > allow > >> > > > > > > this > >> > > > > > > > > > > kind of mapping. > >> > > > > > > > > > > >> > > > > > > > > > > If we run the backend in Dom0 that we have no problems > >> > of > >> > > > > course. > >> > > > > > > > > > > >> > > > > > > > > > One of difficulties on Xen that I found in my approach > >> is > >> > that > >> > > > > > > calling > >> > > > > > > > > > such hypervisor intefaces (registering IOREQ, mapping > >> > memory) is > >> > > > > > > only > >> > > > > > > > > > allowed on BE servers themselvies and so we will have to > >> > extend > >> > > > > > > those > >> > > > > > > > > > interfaces. > >> > > > > > > > > > This, however, will raise some concern on security and > >> > privilege > >> > > > > > > distribution > >> > > > > > > > > > as Stefan suggested. > >> > > > > > > > > > >> > > > > > > > > We also faced policy related issues with Virtio backend > >> > running in > >> > > > > > > other than Dom0 domain in a "dummy" xsm mode. In our target > >> > system we > >> > > > > run > >> > > > > > > the backend in a driver > >> > > > > > > > > domain (we call it DomD) where the underlying H/W resides. > >> > We > >> > > > > trust it, > >> > > > > > > so we wrote policy rules (to be used in "flask" xsm mode) to > >> > provide > >> > > > > it > >> > > > > > > with a little bit more privileges than a simple DomU had. > >> > > > > > > > > Now it is permitted to issue device-model, resource and > >> > memory > >> > > > > > > mappings, etc calls. > >> > > > > > > > > > >> > > > > > > > > > > > >> > > > > > > > > > > > >> > > > > > > > > > > > To activate the mapping will > >> > > > > > > > > > > > require some sort of hypercall to the hypervisor. I > >> > can see > >> > > > > two > >> > > > > > > options > >> > > > > > > > > > > > at this point: > >> > > > > > > > > > > > > >> > > > > > > > > > > > - expose the handle to userspace for daemon/helper > >> > to > >> > > > > trigger > >> > > > > > > the > >> > > > > > > > > > > > mapping via existing hypercall interfaces. If > >> > using a > >> > > > > helper > >> > > > > > > you > >> > > > > > > > > > > > would have a hypervisor specific one to avoid > >> the > >> > daemon > >> > > > > > > having to > >> > > > > > > > > > > > care too much about the details or push that > >> > complexity > >> > > > > into > >> > > > > > > a > >> > > > > > > > > > > > compile time option for the daemon which would > >> > result in > >> > > > > > > different > >> > > > > > > > > > > > binaries although a common source base. > >> > > > > > > > > > > > > >> > > > > > > > > > > > - expose a new kernel ABI to abstract the > >> hypercall > >> > > > > > > differences away > >> > > > > > > > > > > > in the guest kernel. In this case the userspace > >> > would > >> > > > > > > essentially > >> > > > > > > > > > > > ask for an abstract "map guest N memory to > >> > userspace > >> > > > > ptr" > >> > > > > > > and let > >> > > > > > > > > > > > the kernel deal with the different hypercall > >> > interfaces. > >> > > > > > > This of > >> > > > > > > > > > > > course assumes the majority of BE guests would > >> be > >> > Linux > >> > > > > > > kernels and > >> > > > > > > > > > > > leaves the bare-metal/unikernel approaches to > >> > their own > >> > > > > > > devices. > >> > > > > > > > > > > > > >> > > > > > > > > > > > Operation > >> > > > > > > > > > > > ========= > >> > > > > > > > > > > > > >> > > > > > > > > > > > The core of the operation of VirtIO is fairly > >> simple. > >> > Once > >> > > > > the > >> > > > > > > > > > > > vhost-user feature negotiation is done it's a case > >> of > >> > > > > receiving > >> > > > > > > update > >> > > > > > > > > > > > events and parsing the resultant virt queue for > >> data. > >> > The > >> > > > > vhost- > >> > > > > > > user > >> > > > > > > > > > > > specification handles a bunch of setup before that > >> > point, > >> > > > > mostly > >> > > > > > > to > >> > > > > > > > > > > > detail where the virt queues are set up FD's for > >> > memory and > >> > > > > > > event > >> > > > > > > > > > > > communication. This is where the envisioned stub > >> > process > >> > > > > would > >> > > > > > > be > >> > > > > > > > > > > > responsible for getting the daemon up and ready to > >> run. > >> > This > >> > > > > is > >> > > > > > > > > > > > currently done inside a big VMM like QEMU but I > >> > suspect a > >> > > > > modern > >> > > > > > > > > > > > approach would be to use the rust-vmm vhost crate. > >> It > >> > would > >> > > > > then > >> > > > > > > either > >> > > > > > > > > > > > communicate with the kernel's abstracted ABI or be > >> re- > >> > > > > targeted > >> > > > > > > as a > >> > > > > > > > > > > > build option for the various hypervisors. > >> > > > > > > > > > > > >> > > > > > > > > > > One thing I mentioned before to Alex is that Xen > >> doesn't > >> > have > >> > > > > VMMs > >> > > > > > > the > >> > > > > > > > > > > way they are typically envisioned and described in > >> other > >> > > > > > > environments. > >> > > > > > > > > > > Instead, Xen has IOREQ servers. Each of them connects > >> > > > > > > independently to > >> > > > > > > > > > > Xen via the IOREQ interface. E.g. today multiple QEMUs > >> > could > >> > > > > be > >> > > > > > > used as > >> > > > > > > > > > > emulators for a single Xen VM, each of them connecting > >> > to Xen > >> > > > > > > > > > > independently via the IOREQ interface. > >> > > > > > > > > > > > >> > > > > > > > > > > The component responsible for starting a daemon and/or > >> > setting > >> > > > > up > >> > > > > > > shared > >> > > > > > > > > > > interfaces is the toolstack: the xl command and the > >> > > > > libxl/libxc > >> > > > > > > > > > > libraries. > >> > > > > > > > > > > >> > > > > > > > > > I think that VM configuration management (or > >> orchestration > >> > in > >> > > > > > > Startos > >> > > > > > > > > > jargon?) is a subject to debate in parallel. > >> > > > > > > > > > Otherwise, is there any good assumption to avoid it > >> right > >> > now? > >> > > > > > > > > > > >> > > > > > > > > > > Oleksandr and others I CCed have been working on ways > >> > for the > >> > > > > > > toolstack > >> > > > > > > > > > > to create virtio backends and setup memory mappings. > >> > They > >> > > > > might be > >> > > > > > > able > >> > > > > > > > > > > to provide more info on the subject. I do think we > >> miss > >> > a way > >> > > > > to > >> > > > > > > provide > >> > > > > > > > > > > the configuration to the backend and anything else > >> that > >> > the > >> > > > > > > backend > >> > > > > > > > > > > might require to start doing its job. > >> > > > > > > > > > >> > > > > > > > > Yes, some work has been done for the toolstack to handle > >> > Virtio > >> > > > > MMIO > >> > > > > > > devices in > >> > > > > > > > > general and Virtio block devices in particular. However, > >> it > >> > has > >> > > > > not > >> > > > > > > been upstreaned yet. > >> > > > > > > > > Updated patches on review now: > >> > > > > > > > > https://lore.kernel.org/xen-devel/1621626361-29076-1-git- > >> > send- > >> > > > > email- > >> > > > > > > olekstysh@gmail.com/ > >> > > > > > > > > > >> > > > > > > > > There is an additional (also important) activity to > >> > improve/fix > >> > > > > > > foreign memory mapping on Arm which I am also involved in. > >> > > > > > > > > The foreign memory mapping is proposed to be used for > >> Virtio > >> > > > > backends > >> > > > > > > (device emulators) if there is a need to run guest OS > >> completely > >> > > > > > > unmodified. > >> > > > > > > > > Of course, the more secure way would be to use grant > >> memory > >> > > > > mapping. > >> > > > > > > Brietly, the main difference between them is that with foreign > >> > mapping > >> > > > > the > >> > > > > > > backend > >> > > > > > > > > can map any guest memory it wants to map, but with grant > >> > mapping > >> > > > > it is > >> > > > > > > allowed to map only what was previously granted by the > >> frontend. > >> > > > > > > > > > >> > > > > > > > > So, there might be a problem if we want to pre-map some > >> > guest > >> > > > > memory > >> > > > > > > in advance or to cache mappings in the backend in order to > >> > improve > >> > > > > > > performance (because the mapping/unmapping guest pages every > >> > request > >> > > > > > > requires a lot of back and forth to Xen + P2M updates). In a > >> > nutshell, > >> > > > > > > currently, in order to map a guest page into the backend > >> address > >> > space > >> > > > > we > >> > > > > > > need to steal a real physical page from the backend domain. > >> So, > >> > with > >> > > > > the > >> > > > > > > said optimizations we might end up with no free memory in the > >> > backend > >> > > > > > > domain (see XSA-300). And what we try to achieve is to not > >> waste > >> > a > >> > > > > real > >> > > > > > > domain memory at all by providing safe non-allocated-yet (so > >> > unused) > >> > > > > > > address space for the foreign (and grant) pages to be mapped > >> > into, > >> > > > > this > >> > > > > > > enabling work implies Xen and Linux (and likely DTB bindings) > >> > changes. > >> > > > > > > However, as it turned out, for this to work in a proper and > >> safe > >> > way > >> > > > > some > >> > > > > > > prereq work needs to be done. > >> > > > > > > > > You can find the related Xen discussion at: > >> > > > > > > > > https://lore.kernel.org/xen-devel/1627489110-25633-1-git- > >> > send- > >> > > > > email- > >> > > > > > > olekstysh@gmail.com/ > >> > > > > > > > > > >> > > > > > > > > > >> > > > > > > > > > > > >> > > > > > > > > > > > >> > > > > > > > > > > > One question is how to best handle notification and > >> > kicks. > >> > > > > The > >> > > > > > > existing > >> > > > > > > > > > > > vhost-user framework uses eventfd to signal the > >> daemon > >> > > > > (although > >> > > > > > > QEMU > >> > > > > > > > > > > > is quite capable of simulating them when you use > >> TCG). > >> > Xen > >> > > > > has > >> > > > > > > it's own > >> > > > > > > > > > > > IOREQ mechanism. However latency is an important > >> > factor and > >> > > > > > > having > >> > > > > > > > > > > > events go through the stub would add quite a lot. > >> > > > > > > > > > > > >> > > > > > > > > > > Yeah I think, regardless of anything else, we want the > >> > > > > backends to > >> > > > > > > > > > > connect directly to the Xen hypervisor. > >> > > > > > > > > > > >> > > > > > > > > > In my approach, > >> > > > > > > > > > a) BE -> FE: interrupts triggered by BE calling a > >> > hypervisor > >> > > > > > > interface > >> > > > > > > > > > via virtio-proxy > >> > > > > > > > > > b) FE -> BE: MMIO to config raises events (in event > >> > channels), > >> > > > > > > which is > >> > > > > > > > > > converted to a callback to BE via virtio- > >> > proxy > >> > > > > > > > > > (Xen's event channel is internnally > >> > implemented by > >> > > > > > > interrupts.) > >> > > > > > > > > > > >> > > > > > > > > > I don't know what "connect directly" means here, but > >> > sending > >> > > > > > > interrupts > >> > > > > > > > > > to the opposite side would be best efficient. > >> > > > > > > > > > Ivshmem, I suppose, takes this approach by utilizing > >> PCI's > >> > msi-x > >> > > > > > > mechanism. > >> > > > > > > > > > >> > > > > > > > > Agree that MSI would be more efficient than SPI... > >> > > > > > > > > At the moment, in order to notify the frontend, the > >> backend > >> > issues > >> > > > > a > >> > > > > > > specific device-model call to query Xen to inject a > >> > corresponding SPI > >> > > > > to > >> > > > > > > the guest. > >> > > > > > > > > > >> > > > > > > > > > >> > > > > > > > > > >> > > > > > > > > > > > >> > > > > > > > > > > > Could we consider the kernel internally converting > >> > IOREQ > >> > > > > > > messages from > >> > > > > > > > > > > > the Xen hypervisor to eventfd events? Would this > >> scale > >> > with > >> > > > > > > other kernel > >> > > > > > > > > > > > hypercall interfaces? > >> > > > > > > > > > > > > >> > > > > > > > > > > > So any thoughts on what directions are worth > >> > experimenting > >> > > > > with? > >> > > > > > > > > > > > >> > > > > > > > > > > One option we should consider is for each backend to > >> > connect > >> > > > > to > >> > > > > > > Xen via > >> > > > > > > > > > > the IOREQ interface. We could generalize the IOREQ > >> > interface > >> > > > > and > >> > > > > > > make it > >> > > > > > > > > > > hypervisor agnostic. The interface is really trivial > >> and > >> > easy > >> > > > > to > >> > > > > > > add. > >> > > > > > > > > > > >> > > > > > > > > > As I said above, my proposal does the same thing that > >> you > >> > > > > mentioned > >> > > > > > > here :) > >> > > > > > > > > > The difference is that I do call hypervisor interfaces > >> via > >> > > > > virtio- > >> > > > > > > proxy. > >> > > > > > > > > > > >> > > > > > > > > > > The only Xen-specific part is the notification > >> mechanism, > >> > > > > which is > >> > > > > > > an > >> > > > > > > > > > > event channel. If we replaced the event channel with > >> > something > >> > > > > > > else the > >> > > > > > > > > > > interface would be generic. See: > >> > > > > > > > > > > https://gitlab.com/xen-project/xen/- > >> > > > > > > /blob/staging/xen/include/public/hvm/ioreq.h#L52 > >> > > > > > > > > > > > >> > > > > > > > > > > I don't think that translating IOREQs to eventfd in > >> the > >> > kernel > >> > > > > is > >> > > > > > > a > >> > > > > > > > > > > good idea: if feels like it would be extra complexity > >> > and that > >> > > > > the > >> > > > > > > > > > > kernel shouldn't be involved as this is a backend- > >> > hypervisor > >> > > > > > > interface. > >> > > > > > > > > > > >> > > > > > > > > > Given that we may want to implement BE as a bare-metal > >> > > > > application > >> > > > > > > > > > as I did on Zephyr, I don't think that the translation > >> > would not > >> > > > > be > >> > > > > > > > > > a big issue, especially on RTOS's. > >> > > > > > > > > > It will be some kind of abstraction layer of interrupt > >> > handling > >> > > > > > > > > > (or nothing but a callback mechanism). > >> > > > > > > > > > > >> > > > > > > > > > > Also, eventfd is very Linux-centric and we are trying > >> to > >> > > > > design an > >> > > > > > > > > > > interface that could work well for RTOSes too. If we > >> > want to > >> > > > > do > >> > > > > > > > > > > something different, both OS-agnostic and hypervisor- > >> > agnostic, > >> > > > > > > perhaps > >> > > > > > > > > > > we could design a new interface. One that could be > >> > > > > implementable > >> > > > > > > in the > >> > > > > > > > > > > Xen hypervisor itself (like IOREQ) and of course any > >> > other > >> > > > > > > hypervisor > >> > > > > > > > > > > too. > >> > > > > > > > > > > > >> > > > > > > > > > > > >> > > > > > > > > > > There is also another problem. IOREQ is probably not > >> be > >> > the > >> > > > > only > >> > > > > > > > > > > interface needed. Have a look at > >> > > > > > > > > > > https://marc.info/?l=xen-devel&m=162373754705233&w=2. > >> > Don't we > >> > > > > > > also need > >> > > > > > > > > > > an interface for the backend to inject interrupts into > >> > the > >> > > > > > > frontend? And > >> > > > > > > > > > > if the backend requires dynamic memory mappings of > >> > frontend > >> > > > > pages, > >> > > > > > > then > >> > > > > > > > > > > we would also need an interface to map/unmap domU > >> pages. > >> > > > > > > > > > > >> > > > > > > > > > My proposal document might help here; All the interfaces > >> > > > > required > >> > > > > > > for > >> > > > > > > > > > virtio-proxy (or hypervisor-related interfaces) are > >> listed > >> > as > >> > > > > > > > > > RPC protocols :) > >> > > > > > > > > > > >> > > > > > > > > > > These interfaces are a lot more problematic than > >> IOREQ: > >> > IOREQ > >> > > > > is > >> > > > > > > tiny > >> > > > > > > > > > > and self-contained. It is easy to add anywhere. A new > >> > > > > interface to > >> > > > > > > > > > > inject interrupts or map pages is more difficult to > >> > manage > >> > > > > because > >> > > > > > > it > >> > > > > > > > > > > would require changes scattered across the various > >> > emulators. > >> > > > > > > > > > > >> > > > > > > > > > Exactly. I have no confident yet that my approach will > >> > also > >> > > > > apply > >> > > > > > > > > > to other hypervisors than Xen. > >> > > > > > > > > > Technically, yes, but whether people can accept it or > >> not > >> > is a > >> > > > > > > different > >> > > > > > > > > > matter. > >> > > > > > > > > > > >> > > > > > > > > > Thanks, > >> > > > > > > > > > -Takahiro Akashi > >> > > > > > > > > > >> > > > > > > > > > >> > > > > > > > > > >> > > > > > > > > -- > >> > > > > > > > > Regards, > >> > > > > > > > > > >> > > > > > > > > Oleksandr Tyshchenko > >> > > > > > > > IMPORTANT NOTICE: The contents of this email and any > >> > attachments are > >> > > > > > > confidential and may also be privileged. If you are not the > >> > intended > >> > > > > > > recipient, please notify the sender immediately and do not > >> > disclose > >> > > > > the > >> > > > > > > contents to any other person, use it for any purpose, or store > >> > or copy > >> > > > > the > >> > > > > > > information in any medium. Thank you. > >> > > > > > IMPORTANT NOTICE: The contents of this email and any attachments > >> > are > >> > > > > confidential and may also be privileged. If you are not the > >> intended > >> > > > > recipient, please notify the sender immediately and do not > >> disclose > >> > the > >> > > > > contents to any other person, use it for any purpose, or store or > >> > copy the > >> > > > > information in any medium. Thank you. > >> > > > IMPORTANT NOTICE: The contents of this email and any attachments are > >> > confidential and may also be privileged. If you are not the intended > >> > recipient, please notify the sender immediately and do not disclose the > >> > contents to any other person, use it for any purpose, or store or copy > >> the > >> > information in any medium. Thank you. > >> IMPORTANT NOTICE: The contents of this email and any attachments are > >> confidential and may also be privileged. If you are not the intended > >> recipient, please notify the sender immediately and do not disclose the > >> contents to any other person, use it for any purpose, or store or copy the > >> information in any medium. Thank you. > >> > > From xen-devel-bounces@lists.xenproject.org Thu Sep 02 07:20:34 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 07:20:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177071.322261 (Exim 4.92) (envelope-from ) id 1mLh1W-0001sI-Dq; Thu, 02 Sep 2021 07:20:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177071.322261; Thu, 02 Sep 2021 07:20:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLh1W-0001sB-Aj; Thu, 02 Sep 2021 07:20:34 +0000 Received: by outflank-mailman (input) for mailman id 177071; Thu, 02 Sep 2021 07:20:32 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLh1U-0001rz-Qf; Thu, 02 Sep 2021 07:20:32 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLh1U-0006vP-I7; Thu, 02 Sep 2021 07:20:32 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLh1U-0007uA-AK; Thu, 02 Sep 2021 07:20:32 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mLh1U-0006L6-9o; Thu, 02 Sep 2021 07:20:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=YSNsVfVLlDuPuXFPyaS0xSlkqQuUylt5HxzY4lfpp8I=; b=m3FBUxCpj1fPD6kv20wZC2ODVe XASfeswHH5O94ajXGVoaYFtdFOJ3YgEtv4aZgOo1YTFnkaoT3wtbSwfkEcQhCgosnGifx3UNZJn5f AuBgbM+h4Z5ldknkRBaltKtWkttd+FNTeCh2f7326kLSMa8qXMUKWKA1rJOg/ZWqBkz4=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 164745: regressions - FAIL X-Osstest-Failures: libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=345996c6208b281233074362a8d81295e2e711d4 X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Thu, 02 Sep 2021 07:20:32 +0000 flight 164745 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/164745/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a version targeted for testing: libvirt 345996c6208b281233074362a8d81295e2e711d4 baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 419 days Failing since 151818 2020-07-11 04:18:52 Z 418 days 409 attempts Testing same since 164745 2021-09-02 04:18:58 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Andika Triwidada Andrea Bolognani Balázs Meskó Barrett Schonefeld Bastian Germann Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Bjoern Walk Boris Fiuczynski Brian Turek Bruno Haible Chris Mayo Christian Ehrhardt Christian Kirbach Christian Schoenebeck Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé Didik Supriadi Dmytro Linkin Eiichi Tsukata Eric Farman Erik Skultety Fabian Affolter Fabian Freyer Fabiano Fidêncio Fangge Jin Farhan Ali Fedora Weblate Translation gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Hela Basa Helmut Grohne Ian Wienand Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen Jean-Baptiste Holcroft Jia Zhou Jianan Gao Jim Fehlig Jin Yan Jinsheng Zhang Jiri Denemark John Ferlan Jonathan Watt Jonathon Jongsma Julio Faracco Justin Gatzen Ján Tomko Kashyap Chamarthy Kevin Locke Kristina Hanicova Laine Stump Laszlo Ersek Lee Yarwood Liao Pingfang Lin Ma Lin Ma Lin Ma Liu Yiding Luke Yue Luyao Zhong Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Markus Schade Martin Kletzander Masayoshi Mizuma Matej Cepl Matt Coleman Matt Coleman Mauro Matteo Cascella Meina Li Michal Privoznik Michał Smyk Milo Casagrande Moshe Levi Muha Aliss Nathan Neal Gompa Nick Shyrokovskiy Nickys Music Group Nico Pache Nikolay Shirokovskiy Olaf Hering Olesya Gerasimenko Orion Poplawski Pany Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Richard W.M. Jones Ricky Tigg Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Shambarger Sebastian Mitterle SeongHyun Jo Shalini Chellathurai Saroja Shaojun Yang Shi Lei simmon Simon Chopin Simon Gaiser Simon Rowe Stefan Bader Stefan Berger Stefan Berger Stefan Hajnoczi Szymon Scholz Thomas Huth Tim Wiederhake Tomáš Golembiovský Tomáš Janoušek Tuguoyi Ville Skyttä Vinayak Kale Wang Xin WangJian Weblate Wei Liu Wei Liu William Douglas Yalei Li <274268859@qq.com> Yalei Li Yang Fei Yang Hang Yanqiu Zhang Yaroslav Kargin Yi Li Yi Wang Yuri Chornoivan Zbigniew Jędrzejewski-Szmek zhangjl02 Zheng Chuan zhenwei pi Zhenyu Ye Zhenyu Zheng Zhenzhong Duan jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 71488 lines long.) From xen-devel-bounces@lists.xenproject.org Thu Sep 02 07:29:29 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 07:29:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177079.322275 (Exim 4.92) (envelope-from ) id 1mLhA5-0002wN-8E; Thu, 02 Sep 2021 07:29:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177079.322275; Thu, 02 Sep 2021 07:29:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLhA5-0002wG-5M; Thu, 02 Sep 2021 07:29:25 +0000 Received: by outflank-mailman (input) for mailman id 177079; Thu, 02 Sep 2021 07:29:24 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLhA4-0002wA-0E for xen-devel@lists.xenproject.org; Thu, 02 Sep 2021 07:29:24 +0000 Received: from smtp-out2.suse.de (unknown [195.135.220.29]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 7e147abc-0bbf-11ec-ae41-12813bfff9fa; Thu, 02 Sep 2021 07:29:23 +0000 (UTC) Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 18F7720312; Thu, 2 Sep 2021 07:29:22 +0000 (UTC) Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap1.suse-dmz.suse.de (Postfix) with ESMTPS id DE1D813887; Thu, 2 Sep 2021 07:29:21 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap1.suse-dmz.suse.de with ESMTPSA id am2SNFF9MGH1OQAAGKfGzw (envelope-from ); Thu, 02 Sep 2021 07:29:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7e147abc-0bbf-11ec-ae41-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1630567762; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=IhcUjy8QGji2IABo6zcQqKi+1URPttsD+rMluhzr+U0=; b=gmK9k6utB4XDKQvE7yRgd7hk0/UUoy/oSRCveEWBBA12IccGUhOvjxNCVAqE7Hv9LWIwzf RfboEvRXeWHC5aZvw5Ej+gSD+W065MgGPNiCDNnnWXjNWBjs38EK8644ge/S3VHdKXlmfT f8HsXXPLRLgwX4qF6ZXJoXm+7xmJI1I= From: Juergen Gross To: torvalds@linux-foundation.org Cc: linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, boris.ostrovsky@oracle.com Subject: [GIT PULL] xen: branch for v5.15-rc1 Date: Thu, 2 Sep 2021 09:29:21 +0200 Message-Id: <20210902072921.27763-1-jgross@suse.com> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Linus, Please git pull the following tag: git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git for-linus-5.15-rc1-tag xen: branch for v5.15-rc1 It contains the following changes: - some small cleanups - a fix for a bug when running as Xen PV guest which could result in not all memory being transferred in case of a migration of the guest - a small series for getting rid of code for supporting very old Xen hypervisor versions nobody should be using since many years now - a series for hardening the Xen block frontend driver - a fix for Xen PV boot code issuing warning messages due to a stray preempt_disable() on the non-boot processors Thanks. Juergen arch/x86/xen/enlighten_pv.c | 12 +--- arch/x86/xen/mmu_pv.c | 4 +- arch/x86/xen/p2m.c | 4 +- arch/x86/xen/platform-pci-unplug.c | 16 ++--- arch/x86/xen/smp_pv.c | 1 - drivers/block/xen-blkfront.c | 126 ++++++++++++++++++++++++------------- drivers/pci/xen-pcifront.c | 30 +++++---- drivers/xen/features.c | 18 ++++++ drivers/xen/gntdev.c | 36 +---------- drivers/xen/xenbus/xenbus_client.c | 9 +-- 10 files changed, 141 insertions(+), 115 deletions(-) Jing Yangyang (1): drivers/xen/xenbus/xenbus_client.c: fix bugon.cocci warnings Juergen Gross (9): xen: fix setting of max_pfn in shared_info xen: check required Xen features xen: assume XENFEAT_mmu_pt_update_preserve_ad being set for pv guests xen: assume XENFEAT_gnttab_map_avail_bits being set for pv guests xen/blkfront: read response from backend only once xen/blkfront: don't take local copy of a request from the ring page xen/blkfront: don't trust the backend response data blindly xen: remove stray preempt_disable() from PV AP startup code Sergio Miguéns Iglesias (1): xen/pcifront: Removed unnecessary __ref annotation zhaoxiao (1): x86: xen: platform-pci-unplug: use pr_err() and pr_warn() instead of raw printk() From xen-devel-bounces@lists.xenproject.org Thu Sep 02 07:36:28 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 07:36:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177085.322287 (Exim 4.92) (envelope-from ) id 1mLhGn-0004eG-Vc; Thu, 02 Sep 2021 07:36:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177085.322287; Thu, 02 Sep 2021 07:36:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLhGn-0004e9-SZ; Thu, 02 Sep 2021 07:36:21 +0000 Received: by outflank-mailman (input) for mailman id 177085; Thu, 02 Sep 2021 07:36:20 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLhGm-0004dx-F3; Thu, 02 Sep 2021 07:36:20 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLhGm-0007B8-9S; Thu, 02 Sep 2021 07:36:20 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLhGm-0008LC-13; Thu, 02 Sep 2021 07:36:20 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mLhGm-0007oK-0W; Thu, 02 Sep 2021 07:36:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Message-Id:Subject:To; bh=t3gwX6ivxTbp46ew6HRNNt4ACR+5Slw7ptLrr4N2toM=; b=tXV+dnD0TSMasm62gfFZ1ar6qs uq/fLlUa+q+96IryyDmezZ7iDk1FuIqA1a20pXPf23WgM98W38yKKrCg5AqMggTTTeFeqled1sOFu I267Ij/Ol2PcHIpK1x09V0d0j25RESymlv+1GKtxCzikDKtmVPbta+hVDNZsoKmIh0EQ=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Subject: [ovmf bisection] complete build-i386-xsm Message-Id: From: osstest service owner Date: Thu, 02 Sep 2021 07:36:20 +0000 branch xen-unstable xenbranch xen-unstable job build-i386-xsm testid xen-build Tree: ovmf https://github.com/tianocore/edk2.git Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git Tree: qemuu git://xenbits.xen.org/qemu-xen.git Tree: seabios git://xenbits.xen.org/osstest/seabios.git Tree: xen git://xenbits.xen.org/xen.git *** Found and reproduced problem changeset *** Bug is in tree: ovmf https://github.com/tianocore/edk2.git Bug introduced: 9f3eda177a4b2d4a33ff1b0307cad42906396562 Bug not present: 5b5f10d7465004e3e40ec1f50a3b490b4db595e7 Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/164753/ commit 9f3eda177a4b2d4a33ff1b0307cad42906396562 Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:29:48 2021 +0800 OvmfPkg/OvmfXen: add QemuKernelLoaderFsDxe Without QemuKernelLoaderFsDxe, QemuLoadKernelImage() couldn't download the kernel, initrd, and kernel command line from QEMU's fw_cfg. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3574 Signed-off-by: Gary Lin Acked-by: Anthony PERARD Reviewed-by: Philippe Mathieu-Daude Reviewed-by: Gerd Hoffmann Tested-by: Jim Fehlig For bisection revision-tuple graph see: http://logs.test-lab.xenproject.org/osstest/results/bisect/ovmf/build-i386-xsm.xen-build.html Revision IDs in each graph node refer, respectively, to the Trees above. ---------------------------------------- Running cs-bisection-step --graph-out=/home/logs/results/bisect/ovmf/build-i386-xsm.xen-build --summary-out=tmp/164753.bisection-summary --basis-template=164674 --blessings=real,real-bisect,real-retry ovmf build-i386-xsm xen-build Searching for failure / basis pass: 164746 fail [host=huxelrebe1] / 164674 [host=fiano1] 164630 [host=albana0] 164556 [host=elbling1] 164513 [host=albana1] 164461 [host=huxelrebe0] 164406 [host=albana0] 164229 [host=huxelrebe0] 164173 [host=albana0] 164166 [host=albana1] 164160 ok. Failure / basis pass flights: 164746 / 164160 (tree with no url: minios) Tree: ovmf https://github.com/tianocore/edk2.git Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git Tree: qemuu git://xenbits.xen.org/qemu-xen.git Tree: seabios git://xenbits.xen.org/osstest/seabios.git Tree: xen git://xenbits.xen.org/xen.git Latest e3ee8c8dbd7a9f7d7905abe17be60354c9f5f9a3 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 54082c81d96028ba8c76fbe6784085cf1df76b20 96607a8e680e7f965ca868d11f8b0636317d2618 Basis pass a776bbabd9e8f370feb089cdc016324b1d6a37c7 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 136c34c9bc4179dc64b15b2bb5f0c54ca4ddf823 54082c81d96028ba8c76fbe6784085cf1df76b20 25da9455f1bb8a6d33039575a7b28bdfc4e3fcfe Generating revisions with ./adhoc-revtuple-generator https://github.com/tianocore/edk2.git#a776bbabd9e8f370feb089cdc016324b1d6a37c7-e3ee8c8dbd7a9f7d7905abe17be60354c9f5f9a3 git://xenbits.xen.org/qemu-xen-traditional.git#3d273dd05e51e5a1ffba3d98c7437ee84e8f8764-3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 git://xenbits.xen.org/qemu-xen.git#136c34c9bc4179dc64b15b2bb5f0c54ca4ddf823-b6e539830bf45e2d7a6bd86ddfdf003088b173b0 git://xenbits.xen.org/osstest/seabios.git#54082c81d96028ba8c76fbe6784085cf1df76b\ 20-54082c81d96028ba8c76fbe6784085cf1df76b20 git://xenbits.xen.org/xen.git#25da9455f1bb8a6d33039575a7b28bdfc4e3fcfe-96607a8e680e7f965ca868d11f8b0636317d2618 Loaded 76357 nodes in revision graph Searching for test results: 164160 pass a776bbabd9e8f370feb089cdc016324b1d6a37c7 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 136c34c9bc4179dc64b15b2bb5f0c54ca4ddf823 54082c81d96028ba8c76fbe6784085cf1df76b20 25da9455f1bb8a6d33039575a7b28bdfc4e3fcfe 164166 [host=albana1] 164173 [host=albana0] 164229 [host=huxelrebe0] 164406 [host=albana0] 164461 [host=huxelrebe0] 164513 [host=albana1] 164556 [host=elbling1] 164630 [host=albana0] 164674 [host=fiano1] 164686 [host=huxelrebe0] 164695 fail irrelevant 164704 fail irrelevant 164723 pass a776bbabd9e8f370feb089cdc016324b1d6a37c7 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 136c34c9bc4179dc64b15b2bb5f0c54ca4ddf823 54082c81d96028ba8c76fbe6784085cf1df76b20 25da9455f1bb8a6d33039575a7b28bdfc4e3fcfe 164726 fail irrelevant 164718 fail irrelevant 164727 pass 8dd4fc5be6189666b37e5b00131a4173c6a2b085 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 136c34c9bc4179dc64b15b2bb5f0c54ca4ddf823 54082c81d96028ba8c76fbe6784085cf1df76b20 93713f444b3f29d6848527506db69cf78976b32d 164729 fail irrelevant 164728 fail 12e33dca4c0612a0975265e5ba641c6261a26455 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 54082c81d96028ba8c76fbe6784085cf1df76b20 96607a8e680e7f965ca868d11f8b0636317d2618 164730 pass irrelevant 164732 pass a776bbabd9e8f370feb089cdc016324b1d6a37c7 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 136c34c9bc4179dc64b15b2bb5f0c54ca4ddf823 54082c81d96028ba8c76fbe6784085cf1df76b20 25da9455f1bb8a6d33039575a7b28bdfc4e3fcfe 164734 fail 12e33dca4c0612a0975265e5ba641c6261a26455 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 54082c81d96028ba8c76fbe6784085cf1df76b20 96607a8e680e7f965ca868d11f8b0636317d2618 164733 fail 12e33dca4c0612a0975265e5ba641c6261a26455 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 54082c81d96028ba8c76fbe6784085cf1df76b20 96607a8e680e7f965ca868d11f8b0636317d2618 164736 pass a82bad9730178a1e3a67c9bfc83412b87a8ad734 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 136c34c9bc4179dc64b15b2bb5f0c54ca4ddf823 54082c81d96028ba8c76fbe6784085cf1df76b20 8064488062641ae505b2a7369611c38057a7788b 164737 fail 12e33dca4c0612a0975265e5ba641c6261a26455 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 54082c81d96028ba8c76fbe6784085cf1df76b20 96607a8e680e7f965ca868d11f8b0636317d2618 164738 pass cae735f61328d64e2e8991036707b9e78c0f5f63 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 0e95e1df345bce95ac4d6b15c6ed1bf07659fac1 54082c81d96028ba8c76fbe6784085cf1df76b20 daaf007eb3467f900a2e20fadbc4c6f3bfcaa356 164741 fail 9f3eda177a4b2d4a33ff1b0307cad42906396562 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 54082c81d96028ba8c76fbe6784085cf1df76b20 305c2c3abf8228989f7a6f6d8e698ca088c8dc42 164740 [host=huxelrebe0] 164742 pass 28152333bccb778b62e6e97446b28bfa0e92ef82 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 54082c81d96028ba8c76fbe6784085cf1df76b20 daaf007eb3467f900a2e20fadbc4c6f3bfcaa356 164743 fail e3ee8c8dbd7a9f7d7905abe17be60354c9f5f9a3 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 54082c81d96028ba8c76fbe6784085cf1df76b20 96607a8e680e7f965ca868d11f8b0636317d2618 164744 [host=huxelrebe0] 164747 pass 5b5f10d7465004e3e40ec1f50a3b490b4db595e7 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 54082c81d96028ba8c76fbe6784085cf1df76b20 daaf007eb3467f900a2e20fadbc4c6f3bfcaa356 164748 fail 9f3eda177a4b2d4a33ff1b0307cad42906396562 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 54082c81d96028ba8c76fbe6784085cf1df76b20 daaf007eb3467f900a2e20fadbc4c6f3bfcaa356 164746 fail e3ee8c8dbd7a9f7d7905abe17be60354c9f5f9a3 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 54082c81d96028ba8c76fbe6784085cf1df76b20 96607a8e680e7f965ca868d11f8b0636317d2618 164749 pass 5b5f10d7465004e3e40ec1f50a3b490b4db595e7 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 54082c81d96028ba8c76fbe6784085cf1df76b20 daaf007eb3467f900a2e20fadbc4c6f3bfcaa356 164750 fail 9f3eda177a4b2d4a33ff1b0307cad42906396562 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 54082c81d96028ba8c76fbe6784085cf1df76b20 daaf007eb3467f900a2e20fadbc4c6f3bfcaa356 164752 pass 5b5f10d7465004e3e40ec1f50a3b490b4db595e7 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 54082c81d96028ba8c76fbe6784085cf1df76b20 daaf007eb3467f900a2e20fadbc4c6f3bfcaa356 164753 fail 9f3eda177a4b2d4a33ff1b0307cad42906396562 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 54082c81d96028ba8c76fbe6784085cf1df76b20 daaf007eb3467f900a2e20fadbc4c6f3bfcaa356 Searching for interesting versions Result found: flight 164160 (pass), for basis pass For basis failure, parent search stopping at 5b5f10d7465004e3e40ec1f50a3b490b4db595e7 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 54082c81d96028ba8c76fbe6784085cf1df76b20 daaf007eb3467f900a2e20fadbc4c6f3bfcaa356, results HASH(0x5635eef165c0) HASH(0x5635f42f0720) HASH(0x5635eef0f138) For basis failure, parent search stopping at 28152333bccb778b62e6e97446b28bfa0e92ef82 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 54082c81d\ 96028ba8c76fbe6784085cf1df76b20 daaf007eb3467f900a2e20fadbc4c6f3bfcaa356, results HASH(0x5635eef0f228) For basis failure, parent search stopping at cae735f61328d64e2e8991036707b9e78c0f5f63 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 0e95e1df345bce95ac4d6b15c6ed1bf07659fac1 54082c81d96028ba8c76fbe6784085cf1df76b20 daaf007eb3467f900a2e20fadbc4c6f3bfcaa356, results HASH(0x5635f42f1c88) Result found: flight 164728 (fail), for basis failure (at ancestor ~17) Repro found: flight 164732 (pass), for basis pass Repro found: flight 164743 (fail), for basis failure 0 revisions at 5b5f10d7465004e3e40ec1f50a3b490b4db595e7 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 54082c81d96028ba8c76fbe6784085cf1df76b20 daaf007eb3467f900a2e20fadbc4c6f3bfcaa356 No revisions left to test, checking graph state. Result found: flight 164747 (pass), for last pass Result found: flight 164748 (fail), for first failure Repro found: flight 164749 (pass), for last pass Repro found: flight 164750 (fail), for first failure Repro found: flight 164752 (pass), for last pass Repro found: flight 164753 (fail), for first failure *** Found and reproduced problem changeset *** Bug is in tree: ovmf https://github.com/tianocore/edk2.git Bug introduced: 9f3eda177a4b2d4a33ff1b0307cad42906396562 Bug not present: 5b5f10d7465004e3e40ec1f50a3b490b4db595e7 Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/164753/ commit 9f3eda177a4b2d4a33ff1b0307cad42906396562 Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:29:48 2021 +0800 OvmfPkg/OvmfXen: add QemuKernelLoaderFsDxe Without QemuKernelLoaderFsDxe, QemuLoadKernelImage() couldn't download the kernel, initrd, and kernel command line from QEMU's fw_cfg. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3574 Signed-off-by: Gary Lin Acked-by: Anthony PERARD Reviewed-by: Philippe Mathieu-Daude Reviewed-by: Gerd Hoffmann Tested-by: Jim Fehlig Revision graph left in /home/logs/results/bisect/ovmf/build-i386-xsm.xen-build.{dot,ps,png,html,svg}. ---------------------------------------- 164753: tolerable ALL FAIL flight 164753 ovmf real-bisect [real] http://logs.test-lab.xenproject.org/osstest/logs/164753/ Failures :-/ but no regressions. Tests which did not succeed, including tests which could not be run: build-i386-xsm 6 xen-build fail baseline untested jobs: build-i386-xsm fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary From xen-devel-bounces@lists.xenproject.org Thu Sep 02 07:51:50 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 07:51:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177095.322304 (Exim 4.92) (envelope-from ) id 1mLhVc-0007bd-Fa; Thu, 02 Sep 2021 07:51:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177095.322304; Thu, 02 Sep 2021 07:51:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLhVc-0007bW-Ca; Thu, 02 Sep 2021 07:51:40 +0000 Received: by outflank-mailman (input) for mailman id 177095; Thu, 02 Sep 2021 07:51:39 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLhVb-0007bQ-39 for xen-devel@lists.xenproject.org; Thu, 02 Sep 2021 07:51:39 +0000 Received: from verein.lst.de (unknown [213.95.11.211]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 999aa22c-0bc2-11ec-ae45-12813bfff9fa; Thu, 02 Sep 2021 07:51:37 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id A78796736F; Thu, 2 Sep 2021 09:51:31 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 999aa22c-0bc2-11ec-ae45-12813bfff9fa Date: Thu, 2 Sep 2021 09:51:31 +0200 From: Christoph Hellwig To: Tianyu Lan Cc: Christoph Hellwig , kys@microsoft.com, haiyangz@microsoft.com, sthemmin@microsoft.com, wei.liu@kernel.org, decui@microsoft.com, catalin.marinas@arm.com, will@kernel.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, x86@kernel.org, hpa@zytor.com, dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org, konrad.wilk@oracle.com, boris.ostrovsky@oracle.com, jgross@suse.com, sstabellini@kernel.org, joro@8bytes.org, davem@davemloft.net, kuba@kernel.org, jejb@linux.ibm.com, martin.petersen@oracle.com, gregkh@linuxfoundation.org, arnd@arndb.de, m.szyprowski@samsung.com, robin.murphy@arm.com, brijesh.singh@amd.com, thomas.lendacky@amd.com, Tianyu.Lan@microsoft.com, pgonda@google.com, martin.b.radev@gmail.com, akpm@linux-foundation.org, kirill.shutemov@linux.intel.com, rppt@kernel.org, hannes@cmpxchg.org, aneesh.kumar@linux.ibm.com, krish.sadhukhan@oracle.com, saravanand@fb.com, linux-arm-kernel@lists.infradead.org, xen-devel@lists.xenproject.org, rientjes@google.com, ardb@kernel.org, michael.h.kelley@microsoft.com, iommu@lists.linux-foundation.org, linux-arch@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, netdev@vger.kernel.org, vkuznets@redhat.com, parri.andrea@gmail.com, dave.hansen@intel.com Subject: Re: [PATCH V4 00/13] x86/Hyper-V: Add Hyper-V Isolation VM support Message-ID: <20210902075131.GA14986@lst.de> References: <20210827172114.414281-1-ltykernel@gmail.com> <20210830120036.GA22005@lst.de> <91b5e997-8d44-77f0-6519-f574b541ba9f@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <91b5e997-8d44-77f0-6519-f574b541ba9f@gmail.com> User-Agent: Mutt/1.5.17 (2007-11-01) On Tue, Aug 31, 2021 at 11:20:06PM +0800, Tianyu Lan wrote: >> If so I suspect the best way to allocate them is by not using vmalloc >> but just discontiguous pages, and then use kmap_local_pfn where the >> PFN includes the share_gpa offset when actually copying from/to the >> skbs. >> > When netvsc needs to copy packet data to send buffer, it needs to caculate > position with section_index and send_section_size. > Please seee netvsc_copy_to_send_buf() detail. So the contiguous virtual > address of send buffer is necessary to copy data and batch packets. Actually that makes the kmap approach much easier. The phys_to_virt can just be replaced with a kmap_local_pfn and the unmap needs to be added. I've been mostly focussing on the receive path, which would need a similar treatment. From xen-devel-bounces@lists.xenproject.org Thu Sep 02 07:57:40 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 07:57:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177104.322320 (Exim 4.92) (envelope-from ) id 1mLhbH-0008Ll-5p; Thu, 02 Sep 2021 07:57:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177104.322320; Thu, 02 Sep 2021 07:57:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLhbH-0008Le-2r; Thu, 02 Sep 2021 07:57:31 +0000 Received: by outflank-mailman (input) for mailman id 177104; Thu, 02 Sep 2021 07:57:29 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLhbF-0008LW-Ha for xen-devel@lists.xenproject.org; Thu, 02 Sep 2021 07:57:29 +0000 Received: from EUR02-HE1-obe.outbound.protection.outlook.com (unknown [40.107.1.88]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 0b8d669d-1468-457d-96e2-40290352b25a; Thu, 02 Sep 2021 07:57:28 +0000 (UTC) Received: from AM5PR1001CA0041.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:206:15::18) by PAXPR08MB6861.eurprd08.prod.outlook.com (2603:10a6:102:138::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.17; Thu, 2 Sep 2021 07:57:24 +0000 Received: from AM5EUR03FT063.eop-EUR03.prod.protection.outlook.com (2603:10a6:206:15:cafe::cb) by AM5PR1001CA0041.outlook.office365.com (2603:10a6:206:15::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Thu, 2 Sep 2021 07:57:24 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT063.mail.protection.outlook.com (10.152.16.226) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Thu, 2 Sep 2021 07:57:24 +0000 Received: ("Tessian outbound 6ba9ec11d42b:v103"); Thu, 02 Sep 2021 07:57:23 +0000 Received: from 510daa24c306.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 3ECF3DD2-E246-461E-B55B-2672DFBCCA53.1; Thu, 02 Sep 2021 07:57:17 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 510daa24c306.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 02 Sep 2021 07:57:17 +0000 Received: from PAXPR08MB6446.eurprd08.prod.outlook.com (2603:10a6:102:12d::10) by PAXPR08MB6477.eurprd08.prod.outlook.com (2603:10a6:102:12d::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.17; Thu, 2 Sep 2021 07:57:16 +0000 Received: from PAXPR08MB6446.eurprd08.prod.outlook.com ([fe80::c029:ed0:82e7:3c2f]) by PAXPR08MB6446.eurprd08.prod.outlook.com ([fe80::c029:ed0:82e7:3c2f%6]) with mapi id 15.20.4457.024; Thu, 2 Sep 2021 07:57:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0b8d669d-1468-457d-96e2-40290352b25a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ntSFR6cfOCTWWDlTYNXDpalfdTw+y4oUqcYj51r9iZM=; b=KVgBj6vFozjH9e0m+YA5LxmqvI+6fu/bXc8cpcpJULzGePhqDvotMk1us0B1xmM77NGQJ0mtzraXTNMSVvtI+Oh2DEDCDQ6EocO5ClNlOpPbbaRallj0N/CP+I1DtWxFlTfIXik0cSstAzU/4By+cf1gfI2GBAFZ8kSDNEt9wl8= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: 8e29bfe8e8ce2551 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GeeGDSltJszWaKXDmZwH5KbhHf3NaUrpTjIb/Mkpmm6zv1k7y3WUCh1ElJ4d6i52903iWiKpKY385/iVUnB97+KmWEUtBQbg9fUtl2XgNztpa7G+bfML5Ira3eNO361K8qbuGVXryR03/FI44DKWUWH/O5M55CNNA68xdSEJj0vjwGqnJOQj9+JWC8+N7Eey+wAqWtLIxUws4Kq8WbtBXvxHTr08dVsTmrLexYgV+1jMK02ZIabhCBduRCJjq1YvDVaAU2k4bgSyOf7mS6zh6JjEjP9uL7n/2DsS7Y0oDgOE45IUNOUzyVT8CQjMjXBnl1pK/3NYRbdAg5GZ6jD04w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=ntSFR6cfOCTWWDlTYNXDpalfdTw+y4oUqcYj51r9iZM=; b=PPeSkPxbHwHnyQLOdZdvZrPejRcX20+zhf9lxLISbXz/YCtVbd1BSSh+QJ97rNIFrP0zqE7PxF8xxWieQOpseC/dtAu8gr/d4SnupPC7W3PkZqZBT9mfQYrTHONetW/KUe1MhO0YXcDs8HKzjkKlXzjle2VGYk2uFUO2ZDQNF4dQMDUywzo8RPlTn7bpabmclYLrbNVN8Vv5woE35u0FUxZ5o9oPQ+MDVsDx8az3a8XYo9ZkR1f88iuG97KudZUIxIq5XDyqEecYE0u+zwmO3x+BxxRe6Zo4mLZwbF0SmM/5xVDwB9OYTutcM/jBm9gHkZhqP/XZChBi253jZS+BCQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ntSFR6cfOCTWWDlTYNXDpalfdTw+y4oUqcYj51r9iZM=; b=KVgBj6vFozjH9e0m+YA5LxmqvI+6fu/bXc8cpcpJULzGePhqDvotMk1us0B1xmM77NGQJ0mtzraXTNMSVvtI+Oh2DEDCDQ6EocO5ClNlOpPbbaRallj0N/CP+I1DtWxFlTfIXik0cSstAzU/4By+cf1gfI2GBAFZ8kSDNEt9wl8= From: Bertrand Marquis To: Julien Grall CC: Stefano Stabellini , Michal Orzel , "xen-devel@lists.xenproject.org" , Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Wei Liu , Volodymyr Babchuk Subject: Re: [PATCH] xen/arm: Introduce pmu_access parameter Thread-Topic: [PATCH] xen/arm: Introduce pmu_access parameter Thread-Index: AQHXny72/ET98Hho/USYtlrYv98fUauPIugAgAAENgCAABSIgIAAOtOAgAAK3QCAAOCVgA== Date: Thu, 2 Sep 2021 07:57:16 +0000 Message-ID: <5B7B9C01-FF1D-44F9-8815-A422E51916A0@arm.com> References: <20210901124308.31573-1-michal.orzel@arm.com> <599515f0-4b8a-3a71-caea-b17ec27c9123@xen.org> <44B48162-EB44-4295-9629-2D95A40D7232@arm.com> <46e36ba5-8b3d-2d43-6297-b92d2654ab72@xen.org> <0e72fb05-a477-ef79-c26f-bc011393a403@xen.org> In-Reply-To: <0e72fb05-a477-ef79-c26f-bc011393a403@xen.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3654.120.0.1.13) Authentication-Results-Original: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com; x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: 3fa7285f-14a1-42b9-96b6-08d96de74cc7 x-ms-traffictypediagnostic: PAXPR08MB6477:|PAXPR08MB6861: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:10000;OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: JxM2BR8EKGesiIpWcr2WI4Gzz97N2CMbXBa0g66NCj1EGjajJnY1VkV/ulWDs20FL45eoonRgOD7T2PuAAH63MUqfOGS9iAI2J9ztelOAjSCNDCmkps7hULL8ZA+eemPFSvWlTwQDkPHVKcXbjmx8uIYjiS4ygEr0WU9g0jA0gVmqNJchUQ29rLAXtr7X34b9dXxTdaT9bNbAmTBNjVhfFifs/zDeRUAx7TBsZ9rCfrInxL4Qq8NqRFGIV+A66iNVjOLKDmTszbHc15C0OVR5SAmWKsjUPb0WECeZ6WWbWikmekNNUjjCGP3gUG9qhua78uUiyCx6TZT0MaRrWTlsMZB0uQ2AipsX7mg9QMzgi49w1Nu7dhvalPcj4FELda+e79JX1qFvjUeQfxsm9+72r0v4yem64qAHBtRgRb3a10BlWDtllWRzIk4hCn4OgD0MB9WmF1WmMO50CDJPDQqNDKMlcoNY0xA1TFZq8zInx4guqKUpNxfbkzUn+3pCvBkLK2tXrqf871lGE/s1H0Cv4SOF4Y6DF7+0BVG5jhXFi0ZDusXUsMDE4rDaoUMbXMSAe3dqWXJNsH4SUAzQXxKVeA04xiGI/baITsC54DHrk//wtS8rbdCp2R/AV1WLZtRLXc7YRvma1/5EnLrh/99S9ealuVa7/GMN4KWp8jVpnFuid1T3TFNb1VWO6SctASBfuFu78Kuj8pSJUPHbMxi6uUb6Tky2dK6NLkox2c6P3AAT6E4BxqknNDos35QWsKz X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB6446.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(39860400002)(366004)(136003)(396003)(376002)(346002)(26005)(6506007)(86362001)(478600001)(53546011)(38070700005)(6512007)(33656002)(6916009)(2616005)(36756003)(66476007)(66556008)(64756008)(66446008)(6486002)(2906002)(186003)(91956017)(76116006)(8676002)(8936002)(71200400001)(4326008)(38100700002)(54906003)(316002)(5660300002)(83380400001)(122000001)(66946007)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: <867EF41F77E3234C88AFCA1BDAE35D46@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6477 Original-Authentication-Results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT063.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: c1e4dcca-8f65-4b19-7459-08d96de747f7 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 656ATI06FYh8EQeTYkgRV2lC1edRwuxgQic7RMeeBTVVz0gklXqYnLmCwjVmutYLM3ta6kzY8m4Fe0yMpMY7mHNXVbI0BvGFmZ8RhNETV10go8Zq0F7CrsiIYuOcy1oqyv0nUZm+x1TPP+ntiFlaycVugBxUBxK7tYO5Ny5n6DqVjad9NXR659GUAEcoFgeoflf+RmZiuQ9mPKTDaOEx4GekBy51E7wL1rr1ouTlNzRf7rAzbAZezbJU/kaLp9VyxjMGyi3C4L8sd3dAeGRGnOYIn0RQRieqsiOsJ+kXm8aoGgZ26oLjxui3Loil92QPPG51i28ubEpo2aipKfMf9ehU7znSnRxZTS3rszlmw8wCMRhME2YEWLb9Xk7CCKVswMZ0eQYhV4lLVzhCJhP2P1K6sAMgSV7VNxMS4Bb0VqWqw8dWv5QwDX/CdIiWsm9r7odrAHHcE4LO67eaeRcL2n+1PH46WLF5yHe0RMXm0h0dRJTRtTsSbOr6wXp1s6KW46kEKcAayjI5qshb1MVix0B3ScLgHCJ3Q00kXX8Xave5E3DNW8jxKfEzO7wv4Pwtu/N2k8VaEzYDGa5+c31pPrVMWA3ytKUzw7PuUh5P7IyUVaqM1zucWcRzrTFodXxjfFETJD2Uz8TppGLkEXW3hv55JIWok5Q+kVnEdex9TtiShvvu/y8JFnTkMQOj104w6+4Q2fJJW9amm++bKXFDyg== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(376002)(396003)(346002)(39860400002)(136003)(36840700001)(46966006)(83380400001)(8676002)(478600001)(6512007)(81166007)(6486002)(4326008)(6862004)(2616005)(107886003)(54906003)(86362001)(356005)(316002)(36756003)(47076005)(36860700001)(53546011)(6506007)(70206006)(26005)(8936002)(186003)(70586007)(336012)(33656002)(5660300002)(82740400003)(82310400003)(2906002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Sep 2021 07:57:24.1927 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3fa7285f-14a1-42b9-96b6-08d96de74cc7 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT063.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6861 SGkgSnVsaWVuLA0KDQo+IE9uIDEgU2VwIDIwMjEsIGF0IDE5OjMzLCBKdWxpZW4gR3JhbGwgPGp1 bGllbkB4ZW4ub3JnPiB3cm90ZToNCj4gDQo+IEhpIFN0ZWZhbm8sDQo+IA0KPiBPbiAwMS8wOS8y MDIxIDE4OjU0LCBTdGVmYW5vIFN0YWJlbGxpbmkgd3JvdGU6DQo+PiBPbiBXZWQsIDEgU2VwIDIw MjEsIEp1bGllbiBHcmFsbCB3cm90ZToNCj4+PiBPbiAwMS8wOS8yMDIxIDE0OjEwLCBCZXJ0cmFu ZCBNYXJxdWlzIHdyb3RlOg0KPj4+Pj4gT24gMSBTZXAgMjAyMSwgYXQgMTM6NTUsIEp1bGllbiBH cmFsbCA8anVsaWVuQHhlbi5vcmc+IHdyb3RlOg0KPj4+Pj4gDQo+Pj4+PiBIaSwNCj4+Pj4+IA0K Pj4+Pj4gT24gMDEvMDkvMjAyMSAxMzo0MywgTWljaGFsIE9yemVsIHdyb3RlOg0KPj4+Pj4+IElu dHJvZHVjZSBuZXcgWGVuIGNvbW1hbmQgbGluZSBwYXJhbWV0ZXIgY2FsbGVkICJwbXVfYWNjZXNz Ii4NCj4+Pj4+PiBUaGUgZGVmYXVsdCB2YWx1ZSBpcyAidHJhcCI6IFhlbiB0cmFwcyBQTVUgYWNj ZXNzZXMuDQo+Pj4+Pj4gSW4gY2FzZSBvZiBzZXR0aW5nIHBtdV9hY2Nlc3MgdG8gIm5hdGl2ZSIs IFhlbiBkb2VzIG5vdCB0cmFwDQo+Pj4+Pj4gUE1VIGFjY2Vzc2VzIGFsbG93aW5nIGFsbCB0aGUg Z3Vlc3RzIHRvIGFjY2VzcyBQTVUgcmVnaXN0ZXJzLg0KPj4+Pj4+IEhvd2V2ZXIsIGd1ZXN0cyBj YW5ub3QgbWFrZSB1c2Ugb2YgUE1VIG92ZXJmbG93IGludGVycnVwdHMgYXMNCj4+Pj4+PiBQTVUg dXNlcyBQUEkgd2hpY2ggWGVuIGNhbm5vdCByb3V0ZSB0byBndWVzdHMuDQo+Pj4+Pj4gVGhpcyBv cHRpb24gaXMgb25seSBpbnRlbmRlZCBmb3IgZGV2ZWxvcG1lbnQgYW5kIHRlc3RpbmcgcHVycG9z ZXMuDQo+Pj4+Pj4gRG8gbm90IHVzZSB0aGlzIGluIHByb2R1Y3Rpb24gc3lzdGVtLg0KPj4+Pj4g SSBhbSBhZnJhaWQgeW91ciBvcHRpb24gaXMgbm90IHNhZmUgZXZlbiBpbiBkZXZlbG9wbWVudCBz eXN0ZW0gYXMgYSB2Q1BVDQo+Pj4+PiBtYXkgbW92ZSBiZXR3ZWVuIHBDUFVzLg0KPj4+Pj4gDQo+ Pj4+PiBIb3dldmVyLCBldmVuIGlmIHdlIHJlc3RyaWN0ZWQgdGhlIHVzZSB0byBwaW5uZWQgdkNQ VSAqYW5kKiBkZWRpY2F0ZWQNCj4+Pj4+IHBDUFUsIEkgYW0gbm90IGNvbnZpbmNlZCB0aGF0IGV4 cG9zaW5nIGFuIGhhbGYgYmFja2VkIFBNVSAodGhlIG92ZXJmbG93DQo+Pj4+PiBpbnRlcnJ1cHQg d291bGQgbm90IHdvcmspIHRvIHRoZSBndWVzdCBpcyB0aGUgcmlnaHQgc29sdXRpb24uIFRoaXMg bGlrZWx5DQo+Pj4+PiBtZWFucyB0aGUgZ3Vlc3QgT1Mgd291bGQgbmVlZCB0byBiZSBtb2RpZmll ZCBhbmQgdGhlcmVmb3JlIHRoZSB1c2FnZSBvZg0KPj4+Pj4gdGhpcyBvcHRpb24gaXMgZmFpcmx5 IGxpbWl0ZWQuDQo+Pj4+PiANCj4+Pj4+IFNvIEkgdGhpbmsgdGhlIGZpcnN0IHN0ZXBzIGFyZToN Cj4+Pj4+ICAgMSkgTWFrZSB0aGUgUFBJIHdvcmsuIFRoZXJlIHdhcyBzb21lIGF0dGVtcHQgaW4g dGhlIHBhc3QgZm9yIGl0IG9uDQo+Pj4+PiB4ZW4tZGV2ZWwuIFlvdSBjb3VsZCBoYXZlIGEgbG9v ay4NCj4+Pj4+ICAgMikgUHJvdmlkZSBQTVUgYmluZGluZ3MNCj4+Pj4+IA0KPj4+Pj4gV2l0aCB0 aGF0IGluIHBsYWNlLCB3ZSBjYW4gZGlzY3VzcyBob3cgdG8gZXhwb3NlIHRoZSBQTVUgZXZlbiBp ZiBpdCBpcw0KPj4+Pj4gdW5zYWZlIGluIHNvbWUgY29uZGl0aW9ucy4NCj4+Pj4gDQo+Pj4+IFdp dGggdGhvc2UgbGltaXRhdGlvbnMsIHVzaW5nIHRoZSBQTVUgdG8gbW9uaXRvciB0aGUgc3lzdGVt IHBlcmZvcm1hbmNlcyBvcg0KPj4+PiBvbiBzb21lIHNwZWNpZmljIHVzZSBjYXNlcyBpcyBzdGls bCByZWFsbHkgdXNlZnVsLg0KPj4+PiBXZSBhcmUgdXNpbmcgdGhhdCB0byBkbyBzb21lIGJlbmNo bWFya3Mgb2YgWGVuIG9yIG9mIHNvbWUgYXBwbGljYXRpb25zIHRvDQo+Pj4+IGNvbXBhcmUgdGhl IGJlaGF2aW91ciB0byBhIG5hdGl2ZSBzeXN0ZW0gb3INCj4+Pj4gYW5hbHlzZSB0aGUgcGVyZm9y bWFuY2VzIG9mIFhlbiBpdHNlbGYgKGh5cGVyY2FsbHMsY29udGV4dCBzd2l0Y2gg4oCmZXRjKQ0K Pj4gSSBhbHNvIGFscmVhZHkgaGFkIHRvIHdyaXRlIGEgcGF0Y2ggYWxtb3N0IGV4YWN0bHkgbGlr ZSB0aGlzIG9uZSB0bw0KPj4gcHJvdmlkZSB0byBjdXN0b21lcnMgYSBmZXcgbW9udGhzIGJhY2su DQo+Pj4gSSB1bmRlcnN0YW5kIHRoaXMgaXMgdXNlZnVsIGZvciBzb21lIHNldHVwIGFuZCBJIGFt IG5vdCB0cnlpbmcgdG8gc2F5IHdlDQo+Pj4gc2hvdWxkIG5vdCBoYXZlIGEgd2F5IHRvIGV4cG9z ZSB0aGUgUE1VIChldmVuIHVuc2FmZWx5KSBpbiB1cHN0cmVhbS4gSG93ZXZlciwNCj4+PiBJIHRo aW5rIHRoZSBvcHRpb24gYXMgaXQgc3RhbmRzIGlzIHRvbyB3aWRlICh0aGlzIHNob3VsZCBiZSBh IHBlciBkb21haW4ga25vYikNCj4+PiBhbmQgd2Ugc2hvdWxkIHByb3Blcmx5IGV4cG9zZSB0aGUg UE1VIChpbnRlcnJ1cHRzLCBiaW5kaW5ncy4uLikuDQo+PiBJIGhhdmUgbmV2ZXIgdXNlZCBQTVUg ZGlyZWN0bHkgbXlzZWxmLCBvbmx5IHByb3ZpZGVkIGEgcGF0Y2ggc2ltaWxhciB0bw0KPj4gdGhp cyBvbmUuICBCdXQgYXMgZmFyIGFzIEkgY291bGQgdGVsbCB0aGUgdXNlcnMgd2VyZSBmdWxseSBz YXRpc2ZpZWQNCj4+IHdpdGggaXQgYW5kIGl0IGhhZCBubyBpbnRlcnJ1cHRzIHN1cHBvcnQgZWl0 aGVyLiBDb3VsZCBpdCBiZSB0aGF0DQo+PiBpbnRlcnJ1cHRzIGFyZSBub3QgYWN0dWFsbHkgbmVl ZGVkIHRvIHJlYWQgdGhlIHBlcmYgY291bnRlcnMsIHdoaWNoIGlzDQo+PiBwcm9iYWJseSB3aGF0 IHVzZXJzIGNhcmUgYWJvdXQ/DQo+IA0KPiBZb3UgZG9uJ3QgbmVlZCB0aGUgaW50ZXJydXB0cyB0 byByZWFkIHRoZSBwZXJmIGNvdW50ZXJzLiBCdXQgQUZBSVUsIHlvdSB3b3VsZCBoYXZlIHRvIHBv bGwgYXQgYSByZWd1bGFyIGludGVydmFsIHlvdXJzZWxmLiBUaGVyZSBpcyBhbHNvIHRoZSBxdWVz dGlvbiBvbiBob3cgdG8gY2F0Y2ggdGhlIG92ZXJmbG93Pw0KPiANCj4+IEluIHJlZ2FyZHMgdG8g InRoaXMgc2hvdWxkIGJlIGEgcGVyIGRvbWFpbiBrbm9iIiwgaW4gcmVhbGl0eSBpZiB5b3UgYXJl DQo+PiBkb2luZyBQTVUgZXhwZXJpbWVudHMgeW91IGRvbid0IGNhcmUgaWYgb25seSBvbmUgb3Ig YWxsIGRvbWFpbnMgaGF2ZQ0KPj4gYWNjZXNzOiB5b3UgYXJlIHdvcmtpbmcgaW4gYSBjb250cm9s bGVkIGVudmlyb25tZW50IHRyeWluZyB0byBmaWd1cmUgb3V0DQo+PiBpZiB5b3VyIHNldHVwIG1l ZXRzIHRoZSB0aW1pbmcgcmVxdWlyZW1lbnRzLiBUaGVyZSBhcmUgbm8gc2VjdXJpdHkgb3INCj4+ IHNhZmV0eSBjb25jZXJucyAodGhvc2UgYXJlIGRpZmZlcmVudCBleHBlcmltZW50cykgYW5kIHRo ZXJlIGlzIG5vDQo+PiBpbnRlcmZlcmVuY2UgcHJvYmxlbXMgaW4gdGhlIHNlbnNlIG9mIG11bHRp cGxlIGRvbWFpbnMgdHJ5aW5nIHRvIGFjY2Vzcw0KPj4gUE1VIGF0IHRoZSBzYW1lIHRpbWUgLS0g eW91IGNvbnRyb2wgdGhlIGRvbWFpbnMgeW91IGRlY2lkZSB3aGljaCBvbmUgaXMNCj4+IGFjY2Vz c2luZyB0aGVtLiA+DQo+PiBTbyBJIGFtIGluIGZhdm9yIG9mIGEgcGF0Y2ggbGlrZSB0aGlzIG9u ZSBiZWNhdXNlIGl0IGFjdHVhbGx5IHNhdGlzZnkNCj4+IG91ciByZXF1aXJlbWVudHMuIEV2ZW4g aWYgd2UgaGFkIHBlci1kb21haW4gc3VwcG9ydCBhbmQgaW50ZXJydXB0cw0KPj4gc3VwcG9ydCwg SSBkb24ndCB0aGluayB0aGV5IHdvdWxkIGVuZCB1cCBiZWluZyB1c2VkLg0KPiANCj4gSSBoYXZl IHRvIGRpc2FncmVlIHdpdGggdGhhdC4gVGhlcmUgYXJlIHZhbGlkIHVzZS1jYXNlcyB3aGVyZSB5 b3UgbWF5IHdhbnQgdG8gZXhwb3NlIHRoZSBQTVUgZm9yIHVzaW5nIHBlcmYgdG8gYSBzaW5nbGUg ZG9tYWluIGJlY2F1c2UgeW91IGtub3cgaXQgaXMgc2FmZSB0byBkbyBzby4gSSBhcHByZWNpYXRl IHRoaXMgaXMgbWF5IG5vdCBiZSB0aGUgdXNlIGNhc2UgZm9yIHlvdXIgdXNlcnMgKHlldCksIGJ1 dCBJIGhhdmUgc2VlbiAoYW5kIHVzZWQpIGl0IG9uIHg4Ni4gU28gdG8gbWUgdGhpcyBhcHByb2Fj aCBpcyBzaG9ydC1zaWdoZWQuDQo+IA0KPiBUQkgsIHRoaXMgaXMgbm90IHRoZSBmaXJzdCB0aW1l IEkgaGF2ZSBzZWVuIHBhdGNoIGZvciAibGV0J3MgZXhwb3NlIHRoZSBzYW1lIGZlYXR1cmUgdG8g ZXZlcnlvbmUgYmVjYXVzZSB0aGlzIGlzIGVhc3kgdG8gZG8iIGFuZCByZWFsbHkgZGlzbGlrZSBp dC4gRXhwb3NpbmcgYSBuZXcgZmVhdHVyZSBmcm9tIHRoZSB0b29sc3RhY2sgaXMgZWFzaWVyIHRo YW4geW91IHRoaW5rIChiYXJpbmcgdGhlIGxhY2sgb2YgcmV2aWV3cyksIHRoaXMgaXMgYSBtYXR0 ZXIgb2YgY3JlYXRpbmcgYSBuZXcgZmxhZyBhIG5ldyBvcHRpb24uIFRoaXMgd291bGQgbWFrZSBY ZW4gYSBsb3QgbW9yZSBmbGV4aWJsZSBhbmQgZW5hYmxlIG1vcmUgdXNlcnMuLi4NCg0KSWYgSSB1 bmRlcnN0YW5kIGl0IHJpZ2h0LCB5b3Ugd2FudCBhIHBlciBndWVzdCBwYXJhbWV0ZXIgdG8gYmUg YWJsZSB0byBhbGxvdyBQTVUgYWNjZXNzZXMuDQpUaGlzIHdvdWxkIHJlcXVpcmU6DQotIHRvIHNh dmUvcmVzdG9yZSBNRENSIG9uIGNvbnRleHQgc3dpdGNoDQotIGludHJvZHVjZSBhIG5ldyBjb25m aWcgcGFyYW1ldGVyIGZvciBndWVzdHMgKG1pZ2h0IG9yIG1pZ2h0IG5vdCBuZWVkIGEgdG9vbCBj aGFuZ2UpDQotIGhhdmUgYSB4ZW4gY29tbWFuZCBsaW5lIHBhcmFtZXRlciB0byBoYXZlIGEgc29s dXRpb24gdG8gQWxsb3cgUE1VIGZvciBkb20wIChvciBtYXliZSBhIERUQiBvbmUpDQoNCkJ1dCB0 aGlzIHdvdWxkIE5PVCBpbmNsdWRlOg0KLSBpbnRlcnJ1cHQgc3VwcG9ydCAob25seSBuZWVkZWQg dG8gZ2V0IGluZm9ybWVkIG9mIG92ZXJmbG93KQ0KLSBwcm92aWRlIFBNVSB2aXJ0dWFsaXphdGlv biAobm90IGV2ZW4gc3VyZSBzb21ldGhpbmcgbGlrZSB0aGF0IGNvdWxkIG1ha2UgbXVjaCBzZW5z ZSkNCg0KSSBhbSBub3Qgc2F5aW5nIHRoYXQgd2Ugd2lsbCBkbyB0aGF0IG5vdyBidXQgYXMgSSBu ZWVkIHRvIHVuYmxvY2sgdGhpcyBJIGNvdWxkIGV2YWx1YXRlIHRoZSBlZmZvcnQgYW5kIHNlZSBp ZiBpdCBjb3VsZCBiZSBwb3NzaWJsZSB0byBkbyB0aGlzIGluIHRoZSBmdXR1cmUuDQpJbiB0aGUg bWVhbnRpbWUgd2Ugd2lsbCBzdGFydCBtYWludGFpbmluZyBhbiBpbnRlcm5hbCBicmFuY2ggd2l0 aCBwYXRjaGVzIHJlZnVzZWQgdXBzdHJlYW0gYXMgdGhpcyBpcyBibG9ja2luZyB1cy4NCg0KS2lu ZCByZWdhcmRzDQpCZXJ0cmFuZA0KDQo+IA0KPiBTbyBhcyBpdCBzdGFuZHM6DQo+IA0KPiBOQWNr ZWQtYnk6IEp1bGllbiBHcmFsbCA8amdyYWxsQGFtYXpvbi5jb20+DQo+IA0KPiBDaGVlcnMsDQo+ IA0KPiAtLSANCj4gSnVsaWVuIEdyYWxsDQoNCg== From xen-devel-bounces@lists.xenproject.org Thu Sep 02 07:59:48 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 07:59:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177110.322332 (Exim 4.92) (envelope-from ) id 1mLhdT-0000Wi-JZ; Thu, 02 Sep 2021 07:59:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177110.322332; Thu, 02 Sep 2021 07:59:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLhdT-0000Wb-Gf; Thu, 02 Sep 2021 07:59:47 +0000 Received: by outflank-mailman (input) for mailman id 177110; Thu, 02 Sep 2021 07:59:46 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLhdS-0000WV-HP for xen-devel@lists.xenproject.org; Thu, 02 Sep 2021 07:59:46 +0000 Received: from verein.lst.de (unknown [213.95.11.211]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id c2a8d726-d574-48be-9489-4c37a4850615; Thu, 02 Sep 2021 07:59:44 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 4E9586736F; Thu, 2 Sep 2021 09:59:39 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c2a8d726-d574-48be-9489-4c37a4850615 Date: Thu, 2 Sep 2021 09:59:39 +0200 From: Christoph Hellwig To: Michael Kelley Cc: Christoph Hellwig , Tianyu Lan , KY Srinivasan , Haiyang Zhang , Stephen Hemminger , "wei.liu@kernel.org" , Dexuan Cui , "catalin.marinas@arm.com" , "will@kernel.org" , "tglx@linutronix.de" , "mingo@redhat.com" , "bp@alien8.de" , "x86@kernel.org" , "hpa@zytor.com" , "dave.hansen@linux.intel.com" , "luto@kernel.org" , "peterz@infradead.org" , "konrad.wilk@oracle.com" , "boris.ostrovsky@oracle.com" , "jgross@suse.com" , "sstabellini@kernel.org" , "joro@8bytes.org" , "davem@davemloft.net" , "kuba@kernel.org" , "jejb@linux.ibm.com" , "martin.petersen@oracle.com" , "gregkh@linuxfoundation.org" , "arnd@arndb.de" , "m.szyprowski@samsung.com" , "robin.murphy@arm.com" , "brijesh.singh@amd.com" , "thomas.lendacky@amd.com" , Tianyu Lan , "pgonda@google.com" , "martin.b.radev@gmail.com" , "akpm@linux-foundation.org" , "kirill.shutemov@linux.intel.com" , "rppt@kernel.org" , "hannes@cmpxchg.org" , "aneesh.kumar@linux.ibm.com" , "krish.sadhukhan@oracle.com" , "saravanand@fb.com" , "linux-arm-kernel@lists.infradead.org" , "xen-devel@lists.xenproject.org" , "rientjes@google.com" , "ardb@kernel.org" , "iommu@lists.linux-foundation.org" , "linux-arch@vger.kernel.org" , "linux-hyperv@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-scsi@vger.kernel.org" , "netdev@vger.kernel.org" , vkuznets , "parri.andrea@gmail.com" , "dave.hansen@intel.com" Subject: Re: [PATCH V4 00/13] x86/Hyper-V: Add Hyper-V Isolation VM support Message-ID: <20210902075939.GB14986@lst.de> References: <20210827172114.414281-1-ltykernel@gmail.com> <20210830120036.GA22005@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) On Tue, Aug 31, 2021 at 05:16:19PM +0000, Michael Kelley wrote: > As a quick overview, I think there are four places where the > shared_gpa_boundary must be applied to adjust the guest physical > address that is used. Each requires mapping a corresponding > virtual address range. Here are the four places: > > 1) The so-called "monitor pages" that are a core communication > mechanism between the guest and Hyper-V. These are two single > pages, and the mapping is handled by calling memremap() for > each of the two pages. See Patch 7 of Tianyu's series. Ah, interesting. > 3) The network driver send and receive buffers. vmap_phys_range() > should work here. Actually it won't. The problem with these buffers is that they are physically non-contiguous allocations. We really have two sensible options: 1) use vmap_pfn as in the current series. But in that case I think we should get rid of the other mapping created by vmalloc. I though a bit about finding a way to apply the offset in vmalloc itself, but I think it would be too invasive to the normal fast path. So the other sub-option would be to allocate the pages manually (maybe even using high order allocations to reduce TLB pressure) and then remap them 2) do away with the contiguous kernel mapping entirely. This means the simple memcpy calls become loops over kmap_local_pfn. As I just found out for the send side that would be pretty easy, but the receive side would be more work. We'd also need to check the performance implications. > 4) The swiotlb memory used for bounce buffers. vmap_phys_range() > should work here as well. Or memremap if it works for 1. > Case #2 above does unusual mapping. The ring buffer consists of a ring > buffer header page, followed by one or more pages that are the actual > ring buffer. The pages making up the actual ring buffer are mapped > twice in succession. For example, if the ring buffer has 4 pages > (one header page and three ring buffer pages), the contiguous > virtual mapping must cover these seven pages: 0, 1, 2, 3, 1, 2, 3. > The duplicate contiguous mapping allows the code that is reading > or writing the actual ring buffer to not be concerned about wrap-around > because writing off the end of the ring buffer is automatically > wrapped-around by the mapping. The amount of data read or > written in one batch never exceeds the size of the ring buffer, and > after a batch is read or written, the read or write indices are adjusted > to put them back into the range of the first mapping of the actual > ring buffer pages. So there's method to the madness, and the > technique works pretty well. But this kind of mapping is not > amenable to using vmap_phys_range(). Hmm. Can you point me to where this is mapped? Especially for the classic non-isolated case where no vmap/vmalloc mapping is involved at all? From xen-devel-bounces@lists.xenproject.org Thu Sep 02 08:06:47 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 08:06:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177125.322348 (Exim 4.92) (envelope-from ) id 1mLhjy-0002s7-Tf; Thu, 02 Sep 2021 08:06:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177125.322348; Thu, 02 Sep 2021 08:06:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLhjy-0002s0-Qj; Thu, 02 Sep 2021 08:06:30 +0000 Received: by outflank-mailman (input) for mailman id 177125; Thu, 02 Sep 2021 08:06:29 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLhjx-0002rn-0H; Thu, 02 Sep 2021 08:06:29 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLhjw-0008E9-SZ; Thu, 02 Sep 2021 08:06:28 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLhjw-0000tX-Ij; Thu, 02 Sep 2021 08:06:28 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mLhjw-0005JT-ID; Thu, 02 Sep 2021 08:06:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=HATam6E7o9YxcybleTMWpz3Qj92MPFuUIzS59hO2zaA=; b=qMLyFr+qOHYk0chz+LJK//Onqg J6sNXaXXCmcpGXGapVwvgJHT7k7G0Ur2leWY9QqV/WUrW3qc+Koy0AZ8GnwzEihwK0a6lQCfh/+PO s7iWEOVwhuXn/ig6U6M30IY83LIetk5scFSbV91DubgDDEJIeVjMR+pob/EKHMu20CfM=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 164751: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=e3ee8c8dbd7a9f7d7905abe17be60354c9f5f9a3 X-Osstest-Versions-That: ovmf=cae735f61328d64e2e8991036707b9e78c0f5f63 From: osstest service owner Date: Thu, 02 Sep 2021 08:06:28 +0000 flight 164751 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/164751/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 164674 build-amd64-xsm 6 xen-build fail REGR. vs. 164674 build-i386-xsm 6 xen-build fail REGR. vs. 164674 build-i386 6 xen-build fail REGR. vs. 164674 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf e3ee8c8dbd7a9f7d7905abe17be60354c9f5f9a3 baseline version: ovmf cae735f61328d64e2e8991036707b9e78c0f5f63 Last test of basis 164674 2021-08-31 02:56:52 Z 2 days Failing since 164686 2021-09-01 03:03:43 Z 1 days 11 attempts Testing same since 164740 2021-09-02 02:41:13 Z 0 days 4 attempts ------------------------------------------------------------ People who touched revisions under test: Anthony PERARD DunTan Gary Lin Jim Fehlig Lin, Gary (HPS OE-Linux) Loo Tung Lun Loo, Tung Lun Mark Wilson Marvin H?user Wenxing Hou jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit e3ee8c8dbd7a9f7d7905abe17be60354c9f5f9a3 Author: duntan Date: Fri Aug 20 14:43:37 2021 +0800 .azurepipelines: Add UefiPayloadPkg in gate-build-job.yml and CISetting.py Add UefiPayloadPkg in gate-build-job.yml to enable Core ci for UefiPayloadPkg. Add UefiPayloadPkg to supported Packages in CISettings. Cc: Sean Brogan Cc: Bret Barkelew Cc: Michael D Kinney Cc: Liming Gao Signed-off-by: DunTan Reviewed-by: Liming Gao commit 63fddc98e06c380e654b1cfbaf24b9fd922adfad Author: duntan Date: Fri Aug 20 14:43:36 2021 +0800 UefiPayloadPkg: Create .yaml file in UefiPayloadPkg Create .yaml file in UefiPayloadPkg to enable Core ci for UefiPayloadPkg Cc: Guo Dong Cc: Ray Ni Cc: Maurice Ma Cc: Benjamin You Signed-off-by: DunTan Reviewed-by: Liming Gao commit 12e33dca4c0612a0975265e5ba641c6261a26455 Author: Loo, Tung Lun Date: Tue Aug 17 15:43:12 2021 +0800 IntelFsp2Pkg: Support Config File and Binary delta comparison BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3567 This patch is to enable config editor to have a new feature that can spell out the delta between the default configuration files' data, such as YAML and BSF, against the data stored in the binary. This can help users understand and track the difference when modifications are made. Cc: Maurice Ma Cc: Nate DeSimone Cc: Star Zeng Cc: Chasel Chiu Signed-off-by: Loo Tung Lun Reviewed-by: Chasel Chiu commit b170806518c1e414939c8b085866544814e1ce8e Author: Mark Wilson Date: Fri Nov 13 08:05:18 2020 +0800 UefiCpuPkg: Clean up save state boundary checks and comments. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2956 In functions ReadSaveStateRegisterByIndex and WriteSaveStateRegister: * check width > 4 instead of >= 4 when writing upper 32 bytes. - This improves the code but will not affect functionality. Cc: Eric Dong Reviewed-by: Ray Ni Signed-off-by: Mark Wilson commit 3b3f88228812e2c642eea8746858a4dad928ebf7 Author: Marvin H?user Date: Mon Aug 9 14:09:25 2021 +0800 MdeModulePkg/PiSmmCore: Drop deprecated image profiling commands The legacy codebase allowed SMM images to be registered for profiling from DXE. Support for this has been dropped entirely, so remove the remaining handlers. Cc: Jian J Wang Cc: Hao A Wu Cc: Eric Dong Reviewed-by: Ray Ni Cc: Vitaly Cheptsov Signed-off-by: Marvin H?user commit cdda3f74a1327663a5d48cca13507085ba403af7 Author: Marvin H?user Date: Mon Aug 9 03:39:53 2021 +0800 UefiPayloadPkg/UefiPayloadEntry: Fix memory corruption UefiPayloadEntry's AllocatePool() applies the "sizeof" operator to HOB index rather than the HOB header structure. This yields 4 Bytes compared to the 8 Bytes the structure header requires. Fix the call to allocate the required space instead. Reviewed-by: Guo Dong Reviewed-by: Ray Ni Cc: Maurice Ma Cc: Benjamin You Cc: Vitaly Cheptsov Signed-off-by: Marvin H?user commit 5d34cc49d5d348012fe8acf9fb618826bd541a7c Author: Wenxing Hou Date: Tue Aug 24 16:11:11 2021 +0800 UefiCpuPkg/PiSmmCpuDxeSmm: Update mPatchCetSupported set condition REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3584 Function AsmCpuid should first check the value for Basic CPUID Information. The fix is to update the mPatchCetSupported judgment statement. Signed-off-by: Wenxing Hou Reviewed-by: Ray Ni Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Cc: Sheng W Cc: Yao Jiewen commit f0fe55bca4651734abf1752a1d7c69fb5bee00b9 Author: duntan Date: Fri Aug 20 13:04:29 2021 +0800 UefiPayloadPkg: Fix the build error when enable Core ci for UefiPayloadPkg V1: Add quotes when using $(ARCH) in .dsc and .fdf file. The quotes are added due to the way by which Core ci parse the .dsc file. Add UINTN in Hob.c to fix cast from pointer to integer of different size error. V2: Delete lines which reference ShellBinPkg.The pkg doesn't exist in edk2. Cc: Guo Dong Cc: Ray Ni Cc: Maurice Ma Cc: Benjamin You Signed-off-by: DunTan Reviewed-by: Ray Ni commit 9f3eda177a4b2d4a33ff1b0307cad42906396562 Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:29:48 2021 +0800 OvmfPkg/OvmfXen: add QemuKernelLoaderFsDxe Without QemuKernelLoaderFsDxe, QemuLoadKernelImage() couldn't download the kernel, initrd, and kernel command line from QEMU's fw_cfg. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3574 Signed-off-by: Gary Lin Acked-by: Anthony PERARD Reviewed-by: Philippe Mathieu-Daude Reviewed-by: Gerd Hoffmann Tested-by: Jim Fehlig commit 5b5f10d7465004e3e40ec1f50a3b490b4db595e7 Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:31:15 2021 +0800 OvmfPkg/SmmControl2Dxe: use PcdAcpiS3Enable to detect S3 support To avoid the potential inconsistency between PcdAcpiS3Enable and QemuFwCfgS3Enabled(), this commit modifies SmmControl2Dxe to detect S3 support by PcdAcpiS3Enable as modules in MdeModulePkg do. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3573 Signed-off-by: Gary Lin Reviewed-by: Gerd Hoffmann Reviewed-by: Jiewen Yao Tested-by: Jim Fehlig commit 52e2dabc0f8d3af09c213072ce8ba734302f585d Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:31:14 2021 +0800 OvmfPkg/PlatformBootManagerLib: use PcdAcpiS3Enable to detect S3 support To avoid the potential inconsistency between PcdAcpiS3Enable and QemuFwCfgS3Enabled(), this commit modifies PlatformBootManagerLib to detect S3 support by PcdAcpiS3Enable as modules in MdeModulePkg do. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3573 Signed-off-by: Gary Lin Reviewed-by: Gerd Hoffmann Reviewed-by: Jiewen Yao Tested-by: Jim Fehlig commit 28152333bccb778b62e6e97446b28bfa0e92ef82 Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:31:13 2021 +0800 OvmfPkg/LockBoxLib: use PcdAcpiS3Enable to detect S3 support To avoid the potential inconsistency between PcdAcpiS3Enable and QemuFwCfgS3Enabled(), this commit modifies LockBoxLib to detect S3 support by PcdAcpiS3Enable as modules in MdeModulePkg do. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3573 Signed-off-by: Gary Lin Reviewed-by: Philippe Mathieu-Daude Reviewed-by: Gerd Hoffmann Reviewed-by: Jiewen Yao Tested-by: Jim Fehlig commit cb0d24637dfdd869618b9635dfb8e3b0746393a6 Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:31:12 2021 +0800 OvmfPkg/OvmfXen: set PcdAcpiS3Enable at initialization There are several functions in OvmfPkg/Library using QemuFwCfgS3Enabled() to detect the S3 support status. However, in MdeModulePkg, PcdAcpiS3Enable is used to check S3 support. Since InitializeXenPlatform() didn't set PcdAcpiS3Enable as InitializePlatform() did, this made the inconsistency between drivers/functions. For example, S3SaveStateDxe checked PcdAcpiS3Enable and skipped S3BootScript because the default value is FALSE. On the other hand, PlatformBootManagerBeforeConsole() from OvmfPkg/Library called QemuFwCfgS3Enabled() and found it returned TRUE, so it invoked SaveS3BootScript(). However, S3SaveStateDxe skipped S3BootScript, so SaveS3BootScript() asserted due to EFI_NOT_FOUND. This issue mainly affects "HVM Direct Kernel Boot". When used, "fw_cfg" is enabled in QEMU and QemuFwCfgS3Enabled() returns true in that case. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3573 Signed-off-by: Gary Lin Reviewed-by: Anthony PERARD Reviewed-by: Gerd Hoffmann Reviewed-by: Jiewen Yao Tested-by: Jim Fehlig From xen-devel-bounces@lists.xenproject.org Thu Sep 02 08:31:24 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 08:31:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177132.322363 (Exim 4.92) (envelope-from ) id 1mLi7l-0006Va-Ul; Thu, 02 Sep 2021 08:31:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177132.322363; Thu, 02 Sep 2021 08:31:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLi7l-0006VT-R2; Thu, 02 Sep 2021 08:31:05 +0000 Received: by outflank-mailman (input) for mailman id 177132; Thu, 02 Sep 2021 08:31:04 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLi7k-0006VN-D1 for xen-devel@lists.xenproject.org; Thu, 02 Sep 2021 08:31:04 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 7f51fa1d-6613-41a3-9899-677809f43e6d; Thu, 02 Sep 2021 08:31:01 +0000 (UTC) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05lp2175.outbound.protection.outlook.com [104.47.17.175]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-35-nYqOpu4tOfSFDLmcRm-NOQ-1; Thu, 02 Sep 2021 10:31:00 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR04MB4189.eurprd04.prod.outlook.com (2603:10a6:803:3d::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19; Thu, 2 Sep 2021 08:30:57 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4478.021; Thu, 2 Sep 2021 08:30:55 +0000 Received: from [10.156.60.236] (37.24.206.209) by PR2P264CA0023.FRAP264.PROD.OUTLOOK.COM (2603:10a6:101::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Thu, 2 Sep 2021 08:30:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7f51fa1d-6613-41a3-9899-677809f43e6d DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1630571460; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=k4ggceMNvf4IRPKEMkkUaFmoZHmRsMaw7LT5S9Zt76I=; b=mLQHJxW/8r4d8ZJyMdCJONtumbTxG8k9KCGMt8810MPppKDctjRBIVSE3DlQRiwSZTLXLK LyhsskIwk2iMP6vsevNw+ucox4YO1ruszMpwmFFfgy9/ZEnmZJ5vyBwpigSiQf4jN6NpLP h4xXoiSXSwLqx5YzTwc+1B0clv7tCgk= X-MC-Unique: nYqOpu4tOfSFDLmcRm-NOQ-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hSZ/CGTR841tgVVIFefnw7W1STvHB8Y87QlEZlFUrN8b/VY2Joq+qHPMM6OsnLGTa0pgaJvHatxUYNdLs7ar7S+232d9+pmJ02owC62nT+Xrep0QopFG7cmgtBX/MNCXpKxUot6I1HK6zswfJ2W2tOXrqKeSyFrtdx6sGjKkNF0bgqjqS+6/l6/CB5i34Y80BnOBYcoctX3lz9880439HgbYpOplHIuY5p1+ovkWl6tWjVpO2TCy9fh+Uumw+OgSY33gdRu1gPbnzDJVh+pX5ihJUEfB5muaq30ZPFAUiVuTJw00IvynV10wYC/HS4BHgfXhVP4s3Lw06LQ6hfQ+Dw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=k4ggceMNvf4IRPKEMkkUaFmoZHmRsMaw7LT5S9Zt76I=; b=V9kYmAZo3wOL90yX3vpomujPPRJ8OpE9lwj3O9TihoZCU//Vfn+ZQRpFtfhEv6Dp1DVjuTUNvsDIdjgJX1Ysj2bn4SXEQQuvV/wvsFS1IiMpDZuYfMpUXXRLiymz+n4Os/a4pc5Zoz4Mo3H9gJi5BobmloNQbfC5+riM0ZKmKrnAnEe4PimJJnkxgh1udZwF8wCeaSLXplMfA2hFwiTvxxd89GgHDJ0Vva2N/aJb+FKBNdU3moCzoqjjNGIc7LsPedukr9Pbi/Qk26sXWfl3amMwxJXh4a0vyFaHH6f7nxJpqssWJw5PFlj5iDfM6mVNIU/n1HCHG4ehI1KVdxy+ew== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: citrix.com; dkim=none (message not signed) header.d=none;citrix.com; dmarc=none action=none header.from=suse.com; From: Jan Beulich Subject: [PATCH v2 0/6] x86/PVH: Dom0 building adjustments To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Message-ID: <5972ce4c-bdb0-6d07-afad-cf4dd5615488@suse.com> Date: Thu, 2 Sep 2021 10:30:53 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PR2P264CA0023.FRAP264.PROD.OUTLOOK.COM (2603:10a6:101::35) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1ce5d787-71a9-4a44-7abb-08d96debfbb0 X-MS-TrafficTypeDiagnostic: VI1PR04MB4189: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:5236; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0uSdjd5vYEr33F7X5LJOgQobq3EsVDtEBtUCq0tj2aJSoBKjmfmSB9B6u0M0i5rvkWYiaTHGOnM+8o/rFdqCnxHJRkGSliJPt/ZrxEcZwzO9YBF1IU89A4LJAdljbHLY+QqbZCMt9B4gnR84CrYndTEwO+XOQuRAPPA1rXg1dAiFI6HtsqoSmqsaxMw7juAU/a5j1k2TCzOaPert9ILCTb36wv+S7kq3iqjtEyz9HZGukwVhTiIJVhpuH7LIOSd4i9xHso3JqCf+OpdN3eWqqAKeqaLaTfons+H2DDvrAKQaCVHyOI9O1Y0hT3XHnBWcS2EMBelUpzD/EysGo0RmUpLJML4t2BNOFuofVWtxDhULPr3p/S2jkfFY8+RZwd7AFseyFdVwp5cfJlZnhpfro+dmuZYeVNig5Grr3rncLxstvEPdTeS8agcveO+Fd561rVmlFUtVLEovtEfW8eKdE05Lp9GqW8d4XXGLgwESynwLNOXDaUPdBm6aJZ34nFZpotD4rjkqM5/0i3snRw8z/j+FGneVW0Ws/rdALfJJPs1V/RA11ISTzqLG/P0Vah7dB/bj1e70wsQgjHKXv8RTcleiRpM3ilAXC/15Rl6EIfKxeQABGRrXrnJ7hY/l9UYajTFVWTxWmN+j8Kqdu+mKy9rMJ9JC8CfOYCV6eY8nFua4ojVjT5XaKOpSNKquiQr97H6hcWY6nC+voBTtRbbyu6S3o03zeBCY/VEuwkCLKY0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(6916009)(2906002)(4326008)(508600001)(36756003)(5660300002)(31696002)(31686004)(8676002)(54906003)(38100700002)(956004)(86362001)(2616005)(6486002)(8936002)(66946007)(83380400001)(66556008)(66476007)(316002)(16576012)(186003)(26005)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MGo0dUhJZHFqZ0tZTGs5bnExbUFOVFFMUzJCakx0czk1bWhQTENOQWdDSjVL?= =?utf-8?B?STlNdWt2elNWYnFQUnVDYnZKWmMzNHUrRzVKZ3pzc0lTcmQ4ZGNMOG1DNWk0?= =?utf-8?B?b04xUG5HdHdVOSt3N2xDbGlWWWF1empyTGcySEh3Y0xNTVM0d1VOb2ppdUVP?= =?utf-8?B?dG9HRFFRbWRhZEg2T0ZMSExKN0NYQTdudTJlUWFWQU9rSnZzTm5ZaDZGZVBr?= =?utf-8?B?cktOYlpZckc3Q0Q3cUFYamllQUtCUHFFSWQ1UWZYc2xhSThHQXN0aEZVRnpz?= =?utf-8?B?Q0NKVmVkd0xzZmpwa3FRcHVBUHdnYUMwc3dBcGtJM1JhVnBYV1g1YkpLZ3Zn?= =?utf-8?B?V2ZLYnB3UlZNa0V3SmhIY0owalAzRTJPVStFTkhKd2VsU0I5WFBYTnhOTGFS?= =?utf-8?B?cGgveEp0akJJSVR0STBaV0ViR3hMQ1p5R2F5VHk1MUhjUTI4cE1GSUcxUVp0?= =?utf-8?B?NHM2STBMd0E4QWZvd1VWSTdVazA2QmI0R2U3d3VKazFyV0VKM0ZyT0F1anBx?= =?utf-8?B?Rm1NNDRKU2tIeDluUXVMcUwyWjF2bDZrY0NsUFZQcHozTzJPRm5naTFRNGE3?= =?utf-8?B?ZlQyeVdKVFloR0p6T2RWdEIyNU55aUw4dHdXUGxHNE56SENTczM1S0krVnhU?= =?utf-8?B?Y09XbGNSbWxZbUZyOE5seEVQNzNQdFlNc21kNkV2T241YytHR0JDa3krbDMz?= =?utf-8?B?TUVTeVFKcTBIR0RGZEE0RDg3cXpiNmpUNXEvTXhMSjkzWmtCSExraUhlQUEw?= =?utf-8?B?dkpNMkRVdmZzTGZvZWRmMUdYajBHNCt6Qzlud1pVK3ArOUZLSlZKZUMvK3NG?= =?utf-8?B?Q1dFTUVIeHRLK0NEMVhFdXMrWUFnelVOL2pnNUtHSHIvRGppVXlaM1N5RUZx?= =?utf-8?B?ZU84VXJ3V3RTM01Dd01BcTBTRkE4RnlXQkpJbTNmVmtWQStzek14ZE1hU2hB?= =?utf-8?B?VjNTblladlhDMkxXUTUwN2V4VDhaN2VYaGpHeW4wN0FMc2ZPWFIzdHU0dkJn?= =?utf-8?B?V1RvcGF5Mkl0YTZxcUJqUkNxa0VlZTl1Uk5zU2pvZ3R5dWhMdlV0bk8rSUhk?= =?utf-8?B?aUU0MTVMNzlWKzlrS000YVZjL2F1Z1hiU3h3VDQrSW45NWhaRG0rbmVmTk11?= =?utf-8?B?RXdhR241SUdHRjhWNnVXd1FudlBJaGZJdFNHOFpyV3h6S3hWMGord2VaVVlq?= =?utf-8?B?ekxZUFpGRFYwZis1NWk0ZS9SOFpDYzlndEJKTHRQVFdNdExaNTJJd2lwYm5j?= =?utf-8?B?UTZxYWlZNFg2ZkFIcjA4bi9MdFFQQjFMbUhjM3I5czg4VGxJK1VVMmxPVHVP?= =?utf-8?B?V1NnK1Jjc0Ntak5iWm9OVlAxMDV1TUZPdmlLMjl4UE44RkhjaEFYWUQrbnVS?= =?utf-8?B?OGlwdDFQQjZyNU5uUmpWczM5M0p3Mi9QbmthdnUyalI0alRCbW4vVmZ6ZEdT?= =?utf-8?B?K0hnM2NSam9tci9zbjFFOUlLaDB1SzljcHZhVG94UGhGbDBwVEwvQnM1a05L?= =?utf-8?B?b0UrYXNDVU9pVWxnSGNHQUQwZTlRTzdRQnpvTEVMM0J3RDBqa3h6ZVhTbmRr?= =?utf-8?B?NXZ1K2dNbzVETldGQWk2QnpFZG10STMxRmFtYWxxd2hLOE1VODJ1aUdKT1pO?= =?utf-8?B?OVhEbUJvOThBZXFCaVd2SDVvSHMxeEhoL1QwN1FMbE84TldKOUVHQkxFN0RW?= =?utf-8?B?azRxaVFPSU1JRFBRWU1kdmxoWWtTajRUYm96U3RxdXBDeEI5VThSTFlzSGND?= =?utf-8?Q?Q5tzl4rNQ71g5RGrPnION4UxC73S5sgLWC2tQvf?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1ce5d787-71a9-4a44-7abb-08d96debfbb0 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Sep 2021 08:30:55.8544 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: u7AZYy9lWD23se5Xc7Bkhdkb2YayuXgUtI3BGPbHnnjjIaie4psptz7UenHTFi4jjlS8pHCQM4zMK0JBc/QAKA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4189 The code building PVH Dom0 made use of sequences of P2M changes which are disallowed as of XSA-378. First of all population of the first Mb of memory needs to be redone. Then, largely as a workaround, checking introduced by XSA-378 needs to be slightly relaxed. Note that with these adjustments I get Dom0 to start booting on my development system, but the Dom0 kernel then gets stuck. Since it was the first time for me to try PVH Dom0 in this context (see below for why I was hesitant), I cannot tell yet whether this is due further fallout from the XSA, or some further unrelated problem. Dom0's BSP makes it all the way through to entering the idle loop while all APs are still in VPF_down. [And there was another rather basic issue to fight first (patch was submitted separately as RFC): vPCI wasn't aware of hidden PCI devices, hitting an ASSERT(). Obviously I couldn't afford not having a functioning serial console.] In the course I ran into an oom condition while populating Dom0's RAM. Hence next some re-work of dom0_compute_nr_pages(). In turn in the course of putting that together I did notice that PV Dom0, when run in shadow mode, wouldn't have its shadow allocation properly set. Finally make debug key '0' work at least partially for PVH Dom0 and limit the amount of log output for offline (down) vCPU-s. 1: P2M: relax guarding of MMIO entries 2: P2M: relax permissions of PVH Dom0's MMIO entries 3: PVH: improve Dom0 memory size calculation 4: PV: properly set shadow allocation for Dom0 5: PVH: actually show Dom0's register state from debug key '0' 6: HVM: skip offline vCPU-s when dumping VMCBs/VMCSes Jan From xen-devel-bounces@lists.xenproject.org Thu Sep 02 08:32:20 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 08:32:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177138.322373 (Exim 4.92) (envelope-from ) id 1mLi8y-0007OC-8K; Thu, 02 Sep 2021 08:32:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177138.322373; Thu, 02 Sep 2021 08:32:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLi8y-0007O5-5F; Thu, 02 Sep 2021 08:32:20 +0000 Received: by outflank-mailman (input) for mailman id 177138; Thu, 02 Sep 2021 08:32:19 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLi8x-0007Nz-MB for xen-devel@lists.xenproject.org; Thu, 02 Sep 2021 08:32:19 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id b54a0351-d668-400f-9754-8cb4883e52f5; Thu, 02 Sep 2021 08:32:18 +0000 (UTC) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05lp2175.outbound.protection.outlook.com [104.47.17.175]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-16-8rI5qsy5Ot-aOx5yvDc6Lg-1; Thu, 02 Sep 2021 10:32:16 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR04MB4189.eurprd04.prod.outlook.com (2603:10a6:803:3d::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19; Thu, 2 Sep 2021 08:32:12 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4478.021; Thu, 2 Sep 2021 08:32:12 +0000 Received: from [10.156.60.236] (37.24.206.209) by PR0P264CA0084.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:18::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Thu, 2 Sep 2021 08:32:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b54a0351-d668-400f-9754-8cb4883e52f5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1630571537; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FuErrn7dPOKk18p14Eqqw0Ug5qQHJVZRhPNfvjkAXCc=; b=L94RNv+6FlEjlgqvSwvSNstDsWDSyMyRbG69/F/2G3hwkGiz7CL6wz4XOAQFJtexf0gLSI JMjLtEE9DrYwRRD9aKcwT+yig234ilgbDK05hmv4kKHIS6bWn9nG0EKBLRwa9Ux82KylSp 892ol2c0NK2OfCKXuICW8QIFODNWZn4= X-MC-Unique: 8rI5qsy5Ot-aOx5yvDc6Lg-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=esop9D2vOOSfKjxkqZ2QTy/dXVlj+3dCmsXtOrdkgM9Xd04dHZP1kfcLV5luhYvDUSA5pF8SG+oBfVk/uAmFTICChATsNPEZKNpCCALNnzQYiGYIOyWeMAYGoWFE77PGivScaWBk2vEil2SkqeE/wKZh+7T732+gtWPwfT/zkQwWVmxAP/CYHtsN/br42smHMGCieMO85HTfiReerk8mqA0rDKxSpDeO0khv8QJC0OcUk6K4gJtr+iQboeXhNsRb4ua2vggiPVpcmnx4vMnkw1CwRGbuQy+Mf1kWvp9r5Nvbp8Orom/+IDXPWSg3I5ySyqza17cEG5VAW3EQxqFlDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=FuErrn7dPOKk18p14Eqqw0Ug5qQHJVZRhPNfvjkAXCc=; b=QqHhhd6RNunR/gm9IEcERf6hsRrZ91u49seIlwSyduy/tgvlyY9L98qBJVFOaKS2JIEkvEVJiHfmWBnqArM4yK+Er4Ub9eTn/0mjgKStW7AHEhberdHR3XraM6cmUPuPDDY5LA60qLszeodZqMhtpmwxNc3jxslCrWbMBOcthES5KwTbsp0FasEx46tvfPRR98w98OITl+F8utSupwpVPSU0F16swNPILpDJANAg4OWbzi3nyGUDGTmnTRj6f/4DYl/OHhXBaZ9cX9F8MEePiYiaDxRbw7anKMMu+X2BXdGq2b+RyJpR65p9rzVg551Kinho6UJrzSn8V71iiDGL6w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: citrix.com; dkim=none (message not signed) header.d=none;citrix.com; dmarc=none action=none header.from=suse.com; Subject: [PATCH v2 1/6] x86/P2M: relax guarding of MMIO entries From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , George Dunlap References: <5972ce4c-bdb0-6d07-afad-cf4dd5615488@suse.com> Message-ID: <9ab471d8-877c-b569-96c3-c3145800adcf@suse.com> Date: Thu, 2 Sep 2021 10:32:10 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: <5972ce4c-bdb0-6d07-afad-cf4dd5615488@suse.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PR0P264CA0084.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:18::24) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 45c4cfa0-5137-4660-cee9-08d96dec296a X-MS-TrafficTypeDiagnostic: VI1PR04MB4189: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:5516; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: SkzESaDIGIt8nj7pKgXEjA05Kg+86BAjcW2RYiEawFWSTTDVrX/jSD9X1x1ktOkTveqImF2eOieqMJ4Bpu413IdjI6y6vsMGfAah7BnHMXSlIkV/Zemr1f776d1Pcy5SyD2/plKhIwOnMRL75DUCuuu9cE54ce3NS0swsnmy3BxYnRNHXTdbeneu0LgdF3v6EoivRCJptvWjY39wPmfHwRLdR23vn8y7opqLYe5m+vLCC/HFM6yy0Tl6Hatl4o6mgM//ObQNO4PgnujK+03/wqmCWsn7iGP99ETPASC2mBhLCUNvmA8tFsciRjJIXhxBalfwGLmVzF/x1u2OPnTw9KTxXe/M2vsqwtjH0tkN+JCn/1USL/Sxr8TRB+eZy7ZbCFkA8wcSPWdTQUvrMu4VLHQBoPQjkR/13KihYCxe3FYhp9fkdwRdhRM+PfEHdWtZH+Tylr9ydY4qvaxx0iUrSs6T7H94/SMfpQb9a8qarLtN8l6nY29YUeTJrrRR2ipeT8YaBckvJiwTOKaTTfotM8rlvFhEFGsoREU/cSv5P/Rey9PYaxzfwpNV1EiBO9XA/VkGEeTv2W6G5MKNEExRFJvIGbszNtIvcMfR/4xIqNzoUBSpeL4xnpda7Xq+qHg4w5R9WqUuSk9WxsgCstxhoRqmTF5htOYXvzn7FwdcMcXuyY1MTda73NrLPgkO0UfO9cSHbrqaRDYk6Z9r3d6iJqRRdzBycGozfHux/Yggbvg= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(6916009)(2906002)(4326008)(508600001)(36756003)(5660300002)(31696002)(31686004)(8676002)(54906003)(38100700002)(956004)(86362001)(2616005)(6486002)(8936002)(66946007)(83380400001)(66556008)(66476007)(316002)(16576012)(186003)(26005)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cGJ1ZVNZSytLZ1VLSnFWdXM2WWxsbWdpcmNoZ2lRT3g3Nit5c2Y0V3FUTy9P?= =?utf-8?B?ZmtUNlR3NGhzK01wajE0c0tJWEt2MWp6WUhVb2pWVmswR3NQRllrb2pVVWpD?= =?utf-8?B?dFVoSXB1WXhkY083cHg5Z3FtMkg2SmFhVDJzeS9PN1ZkQ2VUSzYwRnlOTFQy?= =?utf-8?B?T2MwNGlHd09HS3djNG52enl5RjF4UkRYT0puYTFtRlN6enJxTFFnUjQ1eVB1?= =?utf-8?B?WVUrZVNsek52MXZ6ZFFYUm5aU3RsbG5QUnBVNzF2UlNJazNwRXdTQ2xyQ05O?= =?utf-8?B?YjUyZUZ3UFRSYVFQdG1lMXhJZWJtcDVZb2ZWQTMvZFhUYjQyODRnS0dmSmh4?= =?utf-8?B?b1ErcTdTOEVNMmNZeTZicjFpNFMwTERXZFdBZjBXekRqNi9Malo0cUxiQ3Vr?= =?utf-8?B?dXNBT2pDbFJIa3VXbmpHN1lIaFRkQlplZjNEaTFMZDQ5NUJVNXA3aWpQMFhp?= =?utf-8?B?Vk11dEh3UVVJbHRJdmJId1JjSVBpdFFwSXU1OEk1WGMrOG1zOW1aZC9pOUhh?= =?utf-8?B?ZXJVRjBFT2RsUWdzY1pSbzRoUHh6RHQ4YVQxRVo5UngvWUxSWmFubEg0TXRW?= =?utf-8?B?TU9acWg2cDRFejVUMTBqV3VPOHUwSHZaOW4wcThRNUp4SFY5ZG9hNUdCWkF0?= =?utf-8?B?MEt4SzNtaVc0ZHpiYXJERGRaQTlSTXk2RlVHcFFabGYwL29XaUpXSmlqa3NC?= =?utf-8?B?OE5TanZNSEdFRUhUenFBRjZkNmJ2UUdNaWQrWXpldjRJbVc2REk2VDBCdW0x?= =?utf-8?B?RzZPYUR0RDhmRGR2b0l2MzFVTHNzT3lVQ2lwWFRnU3JTbUtzT00xNGVZbTd6?= =?utf-8?B?Z21KZTd1VUo4UFA2WVN3ZGpnS1FvTXVzKzQ0YURNT0ZVUFA5Y3pDRWl6ak9R?= =?utf-8?B?OC9pOUdzdE8xTHpiZGRHYXBqT0ZWZ1kvU0dsUzlOV3dwcnNtNU90ZUZOZTdR?= =?utf-8?B?Q2F5TnV4cncwOFU1dlp0V1pRbGkyYlNCbW1HWkNNNDcvT2lZQWtYNUo2dDNt?= =?utf-8?B?UEhJREdaQUJINjBiZkFHei9MOHU5dmhkVFBUWXBCbXBVTU5kcU1GdU92Q0NB?= =?utf-8?B?eE5aNXFnZmhRNElpQTRqazR5dE9xSEc0TEdzdy9sQ1VCeVdNZk5KTzdKWjZx?= =?utf-8?B?VnB1a1EwajMyd1dIRWtQRWl4ajk1VmwzQ0ZZOFlnKy9IblpBU3FscnVDTHZt?= =?utf-8?B?dkxFY0VNZlRuOWJwaWdUTWFoUzB6S3VEMkV6eXN0RDdSOTJJVENua1p3NFBB?= =?utf-8?B?VUdaVnJDZ1h2bmpKVERuZHRObVdNeCtxZzF3QU1iU2lRZHdJQmdJNTAzempj?= =?utf-8?B?UnBwcGlwdFVXbWtNbytqTm41ZU90UFpjYkFxUkJLb3NKQnhmNmxCYUdYODJr?= =?utf-8?B?Q0JmVnBtTUJkdXN1SDVlcXljVXBSaExRNENqWVI3QThFQmRPVUJmNG9iZ0Rp?= =?utf-8?B?eDhlZVBHaEtuS21JbDIrTHAySjFOSU1jOHVQc2hOcGpPT2I2RW5mdDJWUVRB?= =?utf-8?B?dXpiQkJRdmd6UitxM2s0QmFib0VHanBoZGs5bTQ0Z1VlZTNyeUlZeWFOSzhw?= =?utf-8?B?T25sMXB2SEdJRU9pMkc5MEhxU1JCNDRkY2hrMW5XSitrSHozaXBLdENkOWZV?= =?utf-8?B?cWVmcVlWaGEwWjBweThOOXo0dlNrbVNPVzdaeVdyZ05iZlpPMmxZSERuLzQ2?= =?utf-8?B?ZWVMaE92eGorblVJMzZTNHA5eUFScXNXMDc4NnBiRkpTR3Nsd3c0R2tnR3VB?= =?utf-8?Q?LOoB/m6LOyENjS5F6O1LWLoKb5oy6g5nVMc+Mrh?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 45c4cfa0-5137-4660-cee9-08d96dec296a X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Sep 2021 08:32:12.5660 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: iE6TS2myTByzrqwPsYAy2o/vaqD1rHTAnFsHPyhCBGF25NAY+v5+1iD6JG/zBJizAnixdGooglWxiGFbxHTLvg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4189 One of the changes comprising the fixes for XSA-378 disallows replacing MMIO mappings by code paths not intended for this purpose. At least in the case of PVH Dom0 hitting an RMRR covered by an E820 ACPI region, this is too strict. Generally short-circuit requests establishing the same kind of mapping that's already in place, while otherwise adjusting permissions without - as before - allowing MFN or type to change. While there, also add a log message to the other domain_crash() invocation that did prevent PVH Dom0 from coming up after the XSA-378 changes. Fixes: 753cb68e6530 ("x86/p2m: guard (in particular) identity mapping entries") Signed-off-by: Jan Beulich --- I may have gone too far by allowing "access" to change for all special types now. --- v2: Format string and comment adjustments. Split off access accumulation. --- a/xen/arch/x86/mm/p2m.c +++ b/xen/arch/x86/mm/p2m.c @@ -958,9 +958,13 @@ guest_physmap_add_entry(struct domain *d if ( p2m_is_special(ot) ) { /* Don't permit unmapping grant/foreign/direct-MMIO this way. */ - domain_crash(d); p2m_unlock(p2m); - + printk(XENLOG_G_ERR + "%pd: GFN %#lx (%#lx,%u,%u) -> (%#lx,%u,%u) not permitted\n", + d, gfn_x(gfn) + i, + mfn_x(omfn), ot, a, + mfn_x(mfn) + i, t, p2m->default_access); + domain_crash(d); return -EPERM; } else if ( p2m_is_ram(ot) && !p2m_is_paged(ot) ) @@ -1302,9 +1306,24 @@ static int set_typed_p2m_entry(struct do } if ( p2m_is_special(ot) ) { - gfn_unlock(p2m, gfn, order); - domain_crash(d); - return -EPERM; + /* Special-case (almost) identical mappings. */ + if ( !mfn_eq(mfn, omfn) || gfn_p2mt != ot ) + { + gfn_unlock(p2m, gfn, order); + printk(XENLOG_G_ERR + "%pd: GFN %#lx (%#lx,%u,%u,%u) -> (%#lx,%u,%u,%u) not permitted\n", + d, gfn_l, + mfn_x(omfn), cur_order, ot, a, + mfn_x(mfn), order, gfn_p2mt, access); + domain_crash(d); + return -EPERM; + } + + if ( access == a ) + { + gfn_unlock(p2m, gfn, order); + return 0; + } } else if ( p2m_is_ram(ot) ) { From xen-devel-bounces@lists.xenproject.org Thu Sep 02 08:33:12 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 08:33:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177145.322385 (Exim 4.92) (envelope-from ) id 1mLi9n-00082X-N9; Thu, 02 Sep 2021 08:33:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177145.322385; Thu, 02 Sep 2021 08:33:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLi9n-00082Q-Jn; Thu, 02 Sep 2021 08:33:11 +0000 Received: by outflank-mailman (input) for mailman id 177145; Thu, 02 Sep 2021 08:33:10 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLi9m-00082K-JB for xen-devel@lists.xenproject.org; Thu, 02 Sep 2021 08:33:10 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 66e249ba-0bc8-11ec-ae46-12813bfff9fa; Thu, 02 Sep 2021 08:33:09 +0000 (UTC) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05lp2109.outbound.protection.outlook.com [104.47.17.109]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-28-HQDKnutlP9Km-SFC1oMmNw-1; Thu, 02 Sep 2021 10:33:07 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR04MB6862.eurprd04.prod.outlook.com (2603:10a6:803:130::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.24; Thu, 2 Sep 2021 08:33:06 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4478.021; Thu, 2 Sep 2021 08:33:06 +0000 Received: from [10.156.60.236] (37.24.206.209) by PR0P264CA0075.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:18::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Thu, 2 Sep 2021 08:33:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 66e249ba-0bc8-11ec-ae46-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1630571588; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QGrOOS+VJ3eASvPOqSojyeVdMYBWoCT8pMRR8J+S6bQ=; b=SVBPpEgrtnX1KUYJqZY2JwSJUnF4mUAbNzM6nsOt0d10pmYgHKRTm35RIenERIk9HMpP9j a98zUH/+5ZzqVrrmJHY9/Zs+EAzyyseFYEW0IM5986p2xlJms1kZTU0YmlWy+osVq2AuBy D2A13sM7On93SO9yyCkTD+Jhwheg3qg= X-MC-Unique: HQDKnutlP9Km-SFC1oMmNw-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Rh+lzgizB+Oaq/xwxm81ndeEY5ORQ+As9I0bSFEGtmWiwqTD7aW04BhDWaDWCaEm6Vsm7DvzaKDWtJEXBKfWn8tG8PP6MJobsDPyvZ+oi5idAarrhvsb0YXL47BIsVDvJSjp7H0nOpuvWP7yc4k2IsjCrxLS4icROuBzBtdFzNKjQmkw7xOJwExf2M25ruCDpQZEZ5iQSH7b6HOq/O9rKowuy6r7Kt5ui61Is1GIRgF4WGd6wz0eoP2XlPw9Z7PwDjxhUUVfsLtkDazVD0PLuasQ1zwj7EjbM2gOijfR6rtQkSSAYQr7VB6Ii/BP/gJxi0wFD6C8TrUuTT1b2eQsLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QGrOOS+VJ3eASvPOqSojyeVdMYBWoCT8pMRR8J+S6bQ=; b=UVGP2pIZ9hKKbLUDr8rzSB9KEcyrOzfHAHCDn1SbpjIX/hhqQ6rw5sz6Tfkq7umAVGlUkXXryl0NgCFWFfkwCD5RA1xCciaPGNgmJlhLyalDZ/jSgnsi6DEA9SmH/mqkNZHj7AijtHgA0to8DyO+WssVG7f7NWN+TYIWB+nT8DSqHMmyEoRGpOG2z+03c1UpyKzLJr2uTBbehqHovGTul+mMvGDd+kdbc4sRe8RhZv0hh6YrCoA9OvOM02LhdoXE1CLzbE6eEdtOzo562DLh7y17nwCD/cS+JhNhCnhIT3ro/wOiOy9hbv84PKl2lI1B8RuFbQ7qWR5BM4JAEagrKA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: citrix.com; dkim=none (message not signed) header.d=none;citrix.com; dmarc=none action=none header.from=suse.com; Subject: [PATCH v2 2/6] x86/P2M: relax permissions of PVH Dom0's MMIO entries From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , George Dunlap References: <5972ce4c-bdb0-6d07-afad-cf4dd5615488@suse.com> Message-ID: <457637e2-d35c-18d0-ead8-0b513b257927@suse.com> Date: Thu, 2 Sep 2021 10:33:04 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: <5972ce4c-bdb0-6d07-afad-cf4dd5615488@suse.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PR0P264CA0075.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:18::15) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e20ac382-f2fa-4d49-97f6-08d96dec4958 X-MS-TrafficTypeDiagnostic: VI1PR04MB6862: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lFdn9aPOLdawBoXCVdE4Nz9eCCGK+Q5syenMA6zgtSACw4CgOMZ/YufsaCugC9GOgE2yxUHiwvmrRLjJIpk7SrJfRxEjeDYuMize4YXW3cr7buL3Iop6z5OORouZtj5vN5SDgzMpvhwdkM1cFhXAkVdp3a5yF9OZfAQYkwk5Iy/PKjsdbKxq3Vz/kDgaJftsgdaGFfbQvaUAOPMqGXFGijiYa7CYxqmEANfMq+IxiC88ZIya9tVp4RsXDLL/XDUwG23NcBJXFXssQJAxZ9AynQnv1MZJ5tmDG5zMW0s0qEIKZHWnn8E2N1sjBTIozZ0cYeJjXmEzTVAtDruTVXhnnesUSpbpwNHm7SFXt2dAzd8EirLE+wvdWQH42Sr5FpPzUTrEU+btt2GhXMC7nXekxP7f1SlfLK21nlsPzLtphBTjzxaaZaIeAhFQ1sAIdGUnI8A/Duh2rhzKscRjSms9IGsNOM9Tb+EUwbQpCKSvllI/18ZYSzikFa1w+VuVfgtH6hWalvV/heF34sZVoDaFYsuCwcPzNh35vsOlqDyFfVk2ZDe/+yLoHI4J2fyGYp6QcU+9poP6zFLQlWLhpGAH0pMjXPXLApdgmSXM49WjFZcYxdeAfzq/oGr5yiW1MvcEjxOLYNUXBLAqRebxyuc7pV8Zs86Q4YRrhCla4j07UdHckR6+sWpQ9mXZ/wFqWa9aNmVX4GMdlXPkRkxOmdC5kuR9q6z97KYTyw1GTqOhcJc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(136003)(376002)(39860400002)(366004)(396003)(346002)(2906002)(8676002)(5660300002)(2616005)(83380400001)(8936002)(478600001)(54906003)(316002)(36756003)(16576012)(38100700002)(956004)(31696002)(66946007)(186003)(31686004)(66556008)(6916009)(66476007)(4326008)(6486002)(26005)(86362001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bVZmZGxYOVBhZUpKZ00zbDhpS0dTakNNbjNYL3hXdis0T3BZZDhnWEhXN01w?= =?utf-8?B?aVIxS25pbGdLUlFyTHdieEhkSDlvcHBjV3JyVmdQQXh2ZVQvVGdOTDV2V3hI?= =?utf-8?B?Sy9zTmpDbjRBbEVIdVVRc1QrUGlWU1k5c2huQnFucWt0S2xKS1ZPbmZEM0Uv?= =?utf-8?B?cmpoSlgyNUJwV1RMaHcxL0RYV0ViOHNuT0NHR0IzUHZpUUZLZ21HOWQwTjVl?= =?utf-8?B?ZWtCRWRZZnkva3J0M1Q1Y1lqMmw4eW05WHBUckZwdHU5VklISUMxcFhEeWRr?= =?utf-8?B?dXFwWkZGUDFyUDM1Z2VkeVE1a1NMdVNHNW8vWWhFTncwcTdFN3FoQndjUk5l?= =?utf-8?B?V2UyMVAyMnVGZnp5Y3NkaFBIeFhGTFdCRXV6SjRKWHNhOU14VVBiR3dHc3ZQ?= =?utf-8?B?TVJRWXdtWlgxVVdCSUZ5NmJTdnFKMHErK2lZbjZLSGthN3ZIQStWZi9kcDBQ?= =?utf-8?B?NlBuZVVaaTBwSHRHVWdMVXI4dGVzelA1OEhuazE3bkM3TXhwNi9YK2JHK3dU?= =?utf-8?B?enFhNWNaS0F0eGhFUUw4VmJnWmR1YXZmYXpEY3NLTTRPY1BvRGs4S0ZSN3hP?= =?utf-8?B?V0dVV0ozTVZ3c0R6eEVnRG55WitiZFZZV2xRMnVZVWo2V2R2L0kwTXl4SEtz?= =?utf-8?B?ZVVFT0E0VXhUemp1UWQ4NjgyVFo4NW1RQkR2QUkrb2FGVUVsRWJnWGVZVDFH?= =?utf-8?B?dm1DWG9xa1B4akpUVTlIREJCN2FhVjZib29mM09jK09NcFFobmtXTm9zZnJ3?= =?utf-8?B?TllaTm5TdWFSY1o5aUdNckpPdnZBalFGa2xENnZaa1l5QzQyQjFqVEVhbTBP?= =?utf-8?B?SzlwblM3ZFQ1aWNLMDNVa1ArUWFTaTZCQ29qYS9JU01UTjVmN1pxd0s1YkJy?= =?utf-8?B?Qk5HaEtCWkhQb1F2ZkRJNWU0K2h4Z1NwcllJcWxMaUg3NHpURGZIUWp0RE54?= =?utf-8?B?WDBLalQ1QTlCcnJOMld6SFBDNzN0QVpxVVhKczI0YWxwdWo5Q0tyV2JwWElp?= =?utf-8?B?UnRhS2MxODVNUGk5M0NGUjV3MEVRVGFDdGlwY1NwQ2lnWFJkZWg1MEQ4QzVM?= =?utf-8?B?aWpENGF3MmpoVERLaGdidndMTCtsNlhGa1F0OEFaUWtFb2lJcy83aTZkakl1?= =?utf-8?B?ZHd5elp3UGhHZXIxMVlZaWhXTjNsWmxia3VIZkN3b01SbTN2V1p3Z2tuWkFp?= =?utf-8?B?eXlrSC9uZTdwVFZVU2g4WjREL3lQclZwWkd2NElCbUphMDIvUUh4TTE4OXl3?= =?utf-8?B?YTRwb05pS2t2WGRGcENZQ0tQaUdTU2hOeUVDVUlqZWFrMENvWkdsTUIvdGxi?= =?utf-8?B?d2xTcEZ6NVRnOU5Pakt1U1k0ZGF6Tkp0ZmpJMHYzQzJYNGhyVGxzWXZDeExs?= =?utf-8?B?V2JscGtja2k5YzZrajJCTGRkcDBoOTdESWR6eVFKZGoxQ3VFWW1NMUlMVDhj?= =?utf-8?B?ODdpNmVZMHNSZGowL1hVMkYxU2Rob0cvUDNlV3hHRE1Ld1RJOUdOOVBkb09S?= =?utf-8?B?TldkNGZRN0MxL0hxenNCeFNSMnZuREZ1QkRzbnYyVEx6b3BuaGtPS2JZZkQ4?= =?utf-8?B?YUIvK0doZ1JoU0pUVWFWc25jV1lsVWZIVzJpTVZTUHV0QlBWdEh0YXZQdm1W?= =?utf-8?B?ak9kYU5uS25QaWNjclJwNW42RStTL0hiWllNTEhpVkRoSGp3eWlDYmZuaUR6?= =?utf-8?B?WTBtbEl4aFpjRGZQbjE2M3pseElBYWEyaEJyNElqV0pCQWZpbDhmMWJVaHd1?= =?utf-8?Q?xPb68Wz7OitJcxLikf7f3Pb2bAjFz5e+VFtj2a6?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: e20ac382-f2fa-4d49-97f6-08d96dec4958 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Sep 2021 08:33:06.1307 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: CdqcVrJ/MlU3FZzJXiIeI4nU2pwKHFML8YKsvPkMmdLQ7NWSPpTIA/IW5Iv1WT+ch2RGs5a8DF4tOaleKOlJRQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6862 To become independent of the sequence of mapping operations, permit "access" to accumulate for Dom0, noting that there's not going to be an introspection agent for it which this might interfere with. While e.g. ideally only ROM regions would get mapped with X set, getting there is quite a bit of work. Plus the use of p2m_access_* here is abusive in the first place. Signed-off-by: Jan Beulich --- v2: Split off from original patch. --- a/xen/arch/x86/mm/p2m.c +++ b/xen/arch/x86/mm/p2m.c @@ -1319,6 +1319,18 @@ static int set_typed_p2m_entry(struct do return -EPERM; } + /* + * Gross bodge, to go away again rather sooner than later: + * + * For MMIO allow access permissions to accumulate, but only for Dom0. + * Since set_identity_p2m_entry() and set_mmio_p2m_entry() differ in + * the way they specify "access", this will allow the ultimate result + * be independent of the sequence of operations. + */ + if ( is_hardware_domain(d) && gfn_p2mt == p2m_mmio_direct && + access <= p2m_access_rwx && a <= p2m_access_rwx ) + access |= a; + if ( access == a ) { gfn_unlock(p2m, gfn, order); From xen-devel-bounces@lists.xenproject.org Thu Sep 02 08:33:51 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 08:33:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177151.322395 (Exim 4.92) (envelope-from ) id 1mLiAR-0000Bk-0h; Thu, 02 Sep 2021 08:33:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177151.322395; Thu, 02 Sep 2021 08:33:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLiAQ-0000BU-Tx; Thu, 02 Sep 2021 08:33:50 +0000 Received: by outflank-mailman (input) for mailman id 177151; Thu, 02 Sep 2021 08:33:49 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLiAP-0000BK-Kj for xen-devel@lists.xenproject.org; Thu, 02 Sep 2021 08:33:49 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 7e10e197-0bc8-11ec-ae46-12813bfff9fa; Thu, 02 Sep 2021 08:33:48 +0000 (UTC) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01lp2057.outbound.protection.outlook.com [104.47.0.57]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-25-U9UFGGm3PHCgDY-C_PZclA-1; Thu, 02 Sep 2021 10:33:46 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR04MB4382.eurprd04.prod.outlook.com (2603:10a6:803:73::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.17; Thu, 2 Sep 2021 08:33:45 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4478.021; Thu, 2 Sep 2021 08:33:45 +0000 Received: from [10.156.60.236] (37.24.206.209) by AM0PR02CA0213.eurprd02.prod.outlook.com (2603:10a6:20b:28f::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Thu, 2 Sep 2021 08:33:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7e10e197-0bc8-11ec-ae46-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1630571627; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4Vo4Dkwt5tDPO7OINdISKIs97Cf1OIMtewg4ko0cXdk=; b=nN9SvvOIay6vC30EvNHJtrgaqAJUmMe2KpBr8+d+DbjQ80RtRAeBbokhnvLMK7omu6yIJZ gH2rBnJ/owZXsdJC5rmFx/R5jzJ0BZAMnEeWSMDJ/5D/RoxM+LgTutZF2dxhYDKMqE1+F3 4Ky64GnFDn7C4LBQ+JvyUlZnxNBByWE= X-MC-Unique: U9UFGGm3PHCgDY-C_PZclA-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cJCmyBG9TXdvHXI8t+c3lNnbSqceaqc/oOMmaeofSybpK6E/5MjKHD2pdmGbWfOXAtECd2yY6lh0x1XnnrIVjqpuVaZa6W3iiI+sjf35WBRrxRFTO8ZmqHb9D9YMngnamdvJgXIxgoyEauGVpuvcK+eqgNUX2mFQb/JZO33gKuXlGvQqy0Lyx50iBjHiKenyXSnBd8QKR60sbV4Uv/SgimXVvCyj/SiIKnbAC59sL/Zmjo1X0BgRJp6LGyo/GD9o0AeAx61hkMXo9hHvQDmikiTd/oUlXNfTH6jjRAbzl2MAtcudNTH8jrid/0hWKqjaBdg0kRCKSOx6lKkkO/Oecw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4Vo4Dkwt5tDPO7OINdISKIs97Cf1OIMtewg4ko0cXdk=; b=YkvDIDmpb4098GeRj2v/7Ht7iK4JAghUIsJipMxpDiFxVpPhc4z0XEhYJq3Le/JSsQ9ojRYweSH7ymUa6MT2UZkFeXKdxeky/6g2PEjwjJUanhUvIUBROrM9/ORs3mIh4da0Db28x85gM66mUOODF0vG/lBbE1iRaHiSbUa2as9pAVPe+1gOUgkJknp4tLDKqIxf9ZFl+7vksZluI0Q1SgblexiJNwlMkgeF64bopcbzNCSsH5blMXZ16O8s7lA0Txh+QNEtj5jP0AQ2t5SIG+X4g5yg+2vDhC3gLI24dX0mh1rKA60HtjHOavHvgLYVwMie116I3O91Vn74M/MQgQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: citrix.com; dkim=none (message not signed) header.d=none;citrix.com; dmarc=none action=none header.from=suse.com; Subject: [PATCH v2 3/6] x86/PVH: improve Dom0 memory size calculation From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <5972ce4c-bdb0-6d07-afad-cf4dd5615488@suse.com> Message-ID: <98d4f692-5287-fe40-c8b7-4d8bea933d50@suse.com> Date: Thu, 2 Sep 2021 10:33:43 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: <5972ce4c-bdb0-6d07-afad-cf4dd5615488@suse.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM0PR02CA0213.eurprd02.prod.outlook.com (2603:10a6:20b:28f::20) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 526246b0-1ff0-4e2c-3d5e-08d96dec60d9 X-MS-TrafficTypeDiagnostic: VI1PR04MB4382: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2276; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: PLhfQ33scBgxDMfhItDtpr+1CdlEEg74uAtdMIiLxDFiO5dqJGnF29DzuukX/pXEqhjKPVuAQ6Ec94oFLHBUFFINr30hGL6dNDpmJYsr5XQB4rykjrLAWv13uwivMXcqsJo2pWPIT3QYySqGTKQahuTetOGCADZwokMc4qGpMtAh2Nf1NtzSQVlJ5V0M1zwvzmQz2ZGUWrCYbn3Y3+mPnyMy4GiWv6/CKnqo60GdjaptkSKfcv/V8Sgel/ZPUzxsjnSxUT4uw+guVg78mHaT8+PcYdi4Gm9EWEs4WWFjVKg+L/iRfQ24O9pEdP3MeHy3F47rPHGHU9pJUxmK9AV3rlukeHPkwW789r+8koQHMJZhbqHtfaiObLJs//B3HyD2vzIQONy2xjt3ni45KDug4ayqsCn9YeRRdVFKDluPJoK8x5qrzFiPUMqpcxFdpdG0CtPmn3RUd1c6n8unYHRGDFsNrnkgEBcuesw7jZr2JEXp9rIDlDvil8xdW0D71gGekLdvu2D/d/1dlSvtIe35YXucwMxMpkXpF7mIVmh5lkkGazMNQ2CTwZ835IxQKp5Of3z90YA/jrqCUgktgk9kpVAWdp5nQsC22WtD0PPX+wcd4Gp9vWDXo3HymetIswAd1+eyQsgdujNew0B8VnBnbf78ZSsSORtbASPJv/5f8hr+ucpfjcqBLHhuK/Uqj0hNmJhtQYU3WiRjvXJUQ14N/qZRzylNG14n/zLfRPw6rBpXOw61rNO/hlMKoVZ99JvQ X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(39860400002)(136003)(366004)(396003)(376002)(346002)(31696002)(66476007)(2906002)(186003)(66946007)(38100700002)(26005)(66556008)(5660300002)(478600001)(4326008)(31686004)(36756003)(8676002)(6486002)(316002)(16576012)(6916009)(8936002)(54906003)(956004)(2616005)(83380400001)(86362001)(25903002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WG1rVUdOZHRHYlc4TTBiZHBNSkIzVGsxWk9ONlVwdUpneGttSi9HemJKbVY2?= =?utf-8?B?OXVqSVRsVGpzTHQ4aElpR1Rhbnp0QUtTa0FJK0xlN0UvK3JvQUh4eCtCb2gy?= =?utf-8?B?SkJFdmxia2Z6R3lvMlR0dy96VFdRaVBVbUpLZ21uYmNVM29DTUNZRmZoWDBK?= =?utf-8?B?MStleWhaTFFpTUhOY2duUmllUWlyd1orQzdYQm9LblRaZW9vLzQ5WVJ1dStQ?= =?utf-8?B?MWNkSTlIUERIbGswblBTSFNGeFpzbnhnQUt1VGV2T1VpYzR6VkVITGkrejdY?= =?utf-8?B?d3I2STJyMS95Y0lZUFVmZENqVVlrUkI5TXh0TmZkaTRmdkJYMEoxRkRSUEVw?= =?utf-8?B?aGl3UndrUnJ4NTZtQWVKTjA4YWlJcFBrMnZKYXBDVGF5QXlpMVF1ZlloemZI?= =?utf-8?B?Tlgxa3Y5SzVVVmhzb08xMzZIY3Z2ZDVERDU5VmRWSU1Gd1ArZTRQTWthejlp?= =?utf-8?B?ZzM0TVhkYnNSMnl2bzZuMWFyM0pER3EwSzJwY2NyT1RTUEczaUpUVUs1VytQ?= =?utf-8?B?aitadmJKNWZ3cStjTjBEalFJVDg0clIyV0RDcVVRUWlpdVEraGJEaHUrb3Zq?= =?utf-8?B?NlBMcGxJZysyMkJMelJoZVQwM2pVSkVvSUI5V0o3b0hnbGZLWlZ2anpmaHdr?= =?utf-8?B?UWpqaitmNGJNTHZBbkMxbFRDUUh4M2tyeVY2S3l3aEZ0TXJnZzZjNUc1elRw?= =?utf-8?B?YiswSWFvbGpMekRqUUNNeVllR0l6RXpaakYyNTZvc0F2QVIzWEdKQ20yeWs0?= =?utf-8?B?MEFqMS9YZWJreU1uS001L0NMMFZ4THpsRHFOTnRaMjV0MEwwU3FyTGFNalZN?= =?utf-8?B?a2ZZV3BPUUtMeUlZbVdrc3dJREdYM0pVNDRKZ09HTWQyTDlhWFFFUHVsNnEv?= =?utf-8?B?ckEvbWtobjB2ZE81U3Q4M1BVZjgxVHNDSk9UWFpteTVUVkpPSk9QZ0lqTk9W?= =?utf-8?B?QzZwcXUxU1RJSWR5OG1MSU9LNnhyeDFDL21ZT3NncHl2d0RGaVB2VFQzOFhv?= =?utf-8?B?blNVZTV1a0RzaG9RUjhnK1MrZkRoZ2FiUkg5a0craktHWUdLaGhUY0tFekJ0?= =?utf-8?B?eFdrZmlZOXdIYVQxL0krUUZnREtySUdPNnNobi9tSEYwbUZvazkyMVJzYUhr?= =?utf-8?B?V00zek9SbDRQc0p5aWdkaUtpaUppWmpVN3BBdjBhdS9lUktDUms5SjVONXFS?= =?utf-8?B?VXZoYjR6NWhwSGhSUGNVUFBRdVkzU2w2RjRPa1Y5blQ1Ujk2Y0tkSk9FT00z?= =?utf-8?B?czUyMit4eUdNQll0M3Vjb1A4NDBxdzVYMnNJUEpCRk9lUTdmWHEwOTRNdlpm?= =?utf-8?B?dDRiMnpERjRkb2QzY3lrYUNkYWdpcUxvNkVSV0JXcXFONHVFUkUzYXIxRHJY?= =?utf-8?B?b1VsaXYxdkFCOXNqQjRzdGdGV0VYbDUrUDJjK2ZRcU5yczR1VWRvWDA0QWdP?= =?utf-8?B?NEo3VmxSTW00ckFkbkRkVjZLMy93YVRPMFJtYVo1QWUzK1pCZHlSZWtKMVkz?= =?utf-8?B?VUtpUXF4c3VIUzZ2S1lNd25abkc3TTdlMU84SS9EU3ZWS2tJYzg0VGlXWTA3?= =?utf-8?B?RER6TTd5K292NTkvcWhnYkRHNzdqYmtTdTFnMkkxWkdsdkt4N0NjYlltaDFE?= =?utf-8?B?WTJQVnJGQUpUZ1IwWGFXb2dLTFZ3RVVNUExKenozRGJuT04veHV0aURvQ3Nw?= =?utf-8?B?d0laK0tEam5qN3g1b3kzc2xBQXVOakNxaWREQlBQYzZZSGJKdTRaSlgxcEhm?= =?utf-8?Q?MKIvYa6UBm20vqyImMoTq8mRrwaWX2ePzIu1fP3?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 526246b0-1ff0-4e2c-3d5e-08d96dec60d9 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Sep 2021 08:33:45.5974 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: F1EGcA3cNjCnedJ3cetZGVH+d9QpKSas/7Uwo/r0EmOXbFG3P20VITadmjfLNd8Luy8EWmK1W3h7ayY3YYxRdA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4382 Assuming that the accounting for IOMMU page tables will also take care of the P2M needs was wrong: dom0_paging_pages() can determine a far higher value, high enough for the system to run out of memory while setting up Dom0. Hence in the case of shared page tables the larger of the two values needs to be used (without shared page tables the sum of both continues to be applicable). While there also account for two further aspects in the PV case: With "iommu=dom0-passthrough" no IOMMU page tables would get allocated, so none need accounting for. And if shadow mode is to be enabled, setting aside a suitable amount for the P2M pool to get populated is also necessary (i.e. similar to the non-shared-page-tables case of PVH). Signed-off-by: Jan Beulich --- a/xen/arch/x86/dom0_build.c +++ b/xen/arch/x86/dom0_build.c @@ -318,7 +318,7 @@ unsigned long __init dom0_compute_nr_pag struct domain *d, struct elf_dom_parms *parms, unsigned long initrd_len) { nodeid_t node; - unsigned long avail = 0, nr_pages, min_pages, max_pages; + unsigned long avail = 0, nr_pages, min_pages, max_pages, iommu_pages = 0; bool need_paging; /* The ordering of operands is to work around a clang5 issue. */ @@ -337,18 +337,23 @@ unsigned long __init dom0_compute_nr_pag avail -= d->max_vcpus - 1; /* Reserve memory for iommu_dom0_init() (rough estimate). */ - if ( is_iommu_enabled(d) ) + if ( is_iommu_enabled(d) && !iommu_hwdom_passthrough ) { unsigned int s; for ( s = 9; s < BITS_PER_LONG; s += 9 ) - avail -= max_pdx >> s; + iommu_pages += max_pdx >> s; + + avail -= iommu_pages; } - need_paging = is_hvm_domain(d) && - (!iommu_use_hap_pt(d) || !paging_mode_hap(d)); + need_paging = is_hvm_domain(d) + ? !iommu_use_hap_pt(d) || !paging_mode_hap(d) + : opt_dom0_shadow; for ( ; ; need_paging = false ) { + unsigned long paging_pages; + nr_pages = get_memsize(&dom0_size, avail); min_pages = get_memsize(&dom0_min_size, avail); max_pages = get_memsize(&dom0_max_size, avail); @@ -377,11 +382,20 @@ unsigned long __init dom0_compute_nr_pag nr_pages = min(nr_pages, max_pages); nr_pages = min(nr_pages, avail); - if ( !need_paging ) - break; + paging_pages = paging_mode_enabled(d) || need_paging + ? dom0_paging_pages(d, nr_pages) : 0; /* Reserve memory for shadow or HAP. */ - avail -= dom0_paging_pages(d, nr_pages); + if ( !need_paging ) + { + if ( paging_pages <= iommu_pages ) + break; + + avail -= paging_pages - iommu_pages; + } + else + avail -= paging_pages; + iommu_pages = paging_pages; } if ( is_pv_domain(d) && From xen-devel-bounces@lists.xenproject.org Thu Sep 02 08:34:24 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 08:34:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177157.322407 (Exim 4.92) (envelope-from ) id 1mLiAy-0000lU-Ad; Thu, 02 Sep 2021 08:34:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177157.322407; Thu, 02 Sep 2021 08:34:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLiAy-0000lN-7R; Thu, 02 Sep 2021 08:34:24 +0000 Received: by outflank-mailman (input) for mailman id 177157; Thu, 02 Sep 2021 08:34:22 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLiAw-0000jF-Gv for xen-devel@lists.xenproject.org; Thu, 02 Sep 2021 08:34:22 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 91cebf8c-0bc8-11ec-ae46-12813bfff9fa; Thu, 02 Sep 2021 08:34:21 +0000 (UTC) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01lp2051.outbound.protection.outlook.com [104.47.0.51]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-26-mV4NjS7ZPO6kVHAaWD_-qA-1; Thu, 02 Sep 2021 10:34:19 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR04MB4382.eurprd04.prod.outlook.com (2603:10a6:803:73::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.17; Thu, 2 Sep 2021 08:34:18 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4478.021; Thu, 2 Sep 2021 08:34:18 +0000 Received: from [10.156.60.236] (37.24.206.209) by AM0PR03CA0054.eurprd03.prod.outlook.com (2603:10a6:208::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Thu, 2 Sep 2021 08:34:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 91cebf8c-0bc8-11ec-ae46-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1630571660; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MFNiMXoiKa06wTzVJFs8SMvmLCcjsyrCF6I15nLpdgY=; b=Q8mz+ZAeCT+gw/PXiBqkk2rX86/MVDlLmBcq/5ennSLm0lNsVVIXwEnj6jYOqPIk/wcYBG BqMhYH/HLvG7zPpUMJUtYneipSzkXQE0wHxH1MODQQRZO3iBLT4K6kcAUZRIn2C4eisbwb n+8wncth7wpaaOMpxZiW2TuP8Ucqi+0= X-MC-Unique: mV4NjS7ZPO6kVHAaWD_-qA-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BRlP2XFEfmByhwI/5Jf+T8woCrmkt8PDBZQUnFGG1RT+wj9ZnW2niRp5wFisVcrdH6rOdX9pGqJNIjCvztOFUEQtiqCyIJ2crF9k9Iu6s0o90FfXVDwJDY2IjewBuS05SMGeHPOTRATkC0cTINUxHkY7LfUM5NuRel1AU8mboDs+FgMn+xLmzJJOTMSrbw3vrYYkznPQfQ6Zy2RGPeQb5fzk7prlGyZA2KKT77uaTojfquY0joDihX8NA189LHmBcEGdufjUqKgymI+IPrhGjrAhfHU3NdbETz0UemsKUVkS0KPTCTHOaW97xbRTy9LJJ3WTWs6P6U1PdQjGUzn24w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MFNiMXoiKa06wTzVJFs8SMvmLCcjsyrCF6I15nLpdgY=; b=Nd3+D0GZyx9wHfGziRufm/aqTed9mhjaXx5K/e1jT0P4o5R6Qi8Zkm3fu17mQ1D75l3mRx7Xu0nAPcUI3TqCF06j/rXkWEO8r9nBSiCcb8s+EqoUrMPuaR0KO2BZRL+QjgtQzE8GmFZseEwmYe4b1FdJC99PWhMCKUA4E0hrnD5frM/k8mWG3U6EDtuvXv6RpdP2M9oxsTbADTru0ndZBj5ZHKhVhH4q7GUpbIU9NQPTQIeFm6kGae63oNDMSE9nO+hW0q4y3LE2Ta+VRwmdKDEbwkJTOUBKqWCOzTmEF3M2TOU3Cg03N2MpwWaVY31OFXNJ3Cs5j7wpk7vXS/L9pw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=suse.com; Subject: [PATCH v2 4/6] x86/PV: properly set shadow allocation for Dom0 From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Tim Deegan References: <5972ce4c-bdb0-6d07-afad-cf4dd5615488@suse.com> Message-ID: <1a916bf0-cf23-c2cf-eb18-07f8cea27850@suse.com> Date: Thu, 2 Sep 2021 10:34:15 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: <5972ce4c-bdb0-6d07-afad-cf4dd5615488@suse.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM0PR03CA0054.eurprd03.prod.outlook.com (2603:10a6:208::31) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2200fa26-af8c-4f75-d3c6-08d96dec7440 X-MS-TrafficTypeDiagnostic: VI1PR04MB4382: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6430; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MthWaVx89Qa+jwjD9+9vfDYthol0POTKtKJPBdsoOIKmYxGjEJKKrgOIg8z5Y4Owf2zYJj0/fdc9+hgh1SnlMvCu2g3COA2YLPy1PH8U2wJXzplLUqXT4JsnEIEGy/nDc+CCoY3U+saSo1oBYj0X9U1TVnjzRQi3WMEKvWazEedhxl5M7oALKsG0mC3bKXH2ra0u8FomBmzkm608HHcBXbZMNwCC1oD+m8kwu5W+jC0u7N/g+Ns/BvEb2uhRhQPpWlrlglO01x7+Icxa0X9pNYM4oxJfZUuxsGxYa1p0uN1rPrriljUbWZlTe3ABacjVzZrCJSlkkHpSnTclSgmLbNIdjOkPZzmwd43PXVQkeD2j1wRxM1ExVoYWaq/jjjaScgVXhKXBx5m4fA+tjf9V87sJjEHTlX1Tm3uEPFAUIo68ri7RsYoLxSCfwb3+h440S0dEXD2hm+tGYMUJUrFnYpouGItJ7VNgxwDlksfCHsRtm9dDKnrocU+3WuZwBFz/x3U+FYkX3TdW1nlsBRGpti6cIhqXL012+QYTm0QZpEpySAb/XrGpO6sQg+N1UmiADU1o5EeGtuQyupSYYb9rZ6zSqDfGgO8CtPkgZK++hGmIDZZAV5quUe7k0E3eGnkXhxKgd482TNg9GYlibLJEQgLdPD4sGClevToFw0cmv3Q7St3aZ9IRS2kc0/JphHbI//6vrEyJmCIi6+Xb22X23wFJ3+bQEr5W8In2InL72Lo= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(39860400002)(136003)(366004)(396003)(376002)(346002)(31696002)(66476007)(2906002)(186003)(66946007)(38100700002)(26005)(66556008)(5660300002)(478600001)(4326008)(31686004)(36756003)(8676002)(6486002)(316002)(16576012)(6916009)(8936002)(54906003)(956004)(2616005)(83380400001)(86362001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R3djZk0vczdoZmZZTWxqL04vSFVxTHNyYzFRLy9MTllidThKWFgxQTl0cElP?= =?utf-8?B?OENKckRaRk5Jem1BSDQ5cjVDZ2QxYlVLS2hwUkFQSDhGYTY0Rkw5dGtwNkxE?= =?utf-8?B?Y3dwWWdpSWZFeUM1UW00ZWJUU3BpQ2JMSGgraUpVUmJRWGdPcm9CeTY5T3c5?= =?utf-8?B?WklDRFQ2VXA1a1dsVUJrbVdLZjNqek80M3lVeUVrdWhmTGp2VzZmaFZZOHAy?= =?utf-8?B?SjloUnlEWDQ5aWk1cVduU3VOVVpDZVI5K0RJVjJJR2VnTVFrbmtab2dvbXdB?= =?utf-8?B?MzVqeVRLNjRHZWlvdCs0WXp4dEowdk5ZcGJtdlIxOURjTUw5VXV5VXVycy9v?= =?utf-8?B?R0ZlcVRMcDAwUmY3d3lFbE13QWxQV3M0Y3lDQkNJd2NGdkV1N2ZJS0Q0bXIw?= =?utf-8?B?cGp4T2dsL2FBd203b3RQVjlML1dMem5FMWx3anJpNTZkeVhORk81QVFRTHlR?= =?utf-8?B?MTNsUUhmODRVSlRtUThHQjhVZDAwSXRnTjllTzZwUGgxZXB6NU8vZ3p1TG1u?= =?utf-8?B?WGNwVVR3NHpSNTduR0dIeUVBYnF3UERrTXpGQnJQcVF5dFAyY05wY1lrdmYx?= =?utf-8?B?Zi9ES1p2NEFPZTUzanNpQ1RMTDVyQzdWdDRFYnVYcTVyZHkyQ0p0WHZCWHlm?= =?utf-8?B?WDBUcVFmMzFUUFNRRUZNQUhkZmFFTFVXOGJKcXpEYmlGaFVyTWZuekdJWjl5?= =?utf-8?B?V1dLUVcwamt3aDROQUwvS2RDYlRuOGMxYURzSElWRmpvV1FUNmIycFdCQURO?= =?utf-8?B?MXlrNWowMDJ6dCtWK1BOR3pGdUFVNi8xWFErSURmdWF4SE1ydXJEOU5uNVdT?= =?utf-8?B?RXR0dll0dGkzc3kvZGlkdkxDRVphU05HSjlVYm8xMFpSUTJPeEFSejlQQWpQ?= =?utf-8?B?RU1sMjB5ZUxnM2Jhbk9veG5NUnh3R1BienBNUXFpZ0R3ZXc4N0hOdFhWSVk2?= =?utf-8?B?UlBPT2c4R3ZYZjFzVUFtOUg3elkvY2Z1Z2dJamt1MTlIdXR2cDVNN0RHRU5K?= =?utf-8?B?ZHJEUkFhVE9pZm9DTnpEYjFjMmJYeUhGUHJFODFrSER4QTBOUVA3SWJTZXFm?= =?utf-8?B?TjFESHNNVFJHVXNWRFJibEpaUkNsVjFxbno4bHJwNkFmU09kZkpxZUxXVFNX?= =?utf-8?B?eU1DTkRzdk5KNjVPUUVlZUNEaWk2LzNtQmdIZTVLUmZhYjRWaFpjY3V6ZTNy?= =?utf-8?B?RTNVZTRCZFdMRWczbERKTG9TbHVKdklvdDBhaXQyZ0luTHhWM2c0WkJ4ZE5I?= =?utf-8?B?VzhrOUpjdVVHeGtGcnQxckRneWlrWVBoczJENWF0QkNMRVU4NGRCN1dYd2dK?= =?utf-8?B?dTFvVGtQN1hxUGppUDhzem1GSWFRdy9ZM3dPMm9XSlQrUVVKRXhaNkQvd0Fx?= =?utf-8?B?KzdUdU1rMkhqa2p1Z0c2KzFHcXdJeEpXUnloUTMyeFY5cW80dG1vK3ZjTGtt?= =?utf-8?B?RzNNOXhZcTRneTlINFZmVlZNaU5Cc1B2ei9nbjIzL1R3bzN3SVlmdTJ5bm5H?= =?utf-8?B?QlkvcmZtTHZMZC9HWWJSblFCWHlNSzFXMHdCWFQ2Z3ZjK1ZGRUNBOVNDdWlS?= =?utf-8?B?OGZybksrY3ZRemloQ1JLWmNNbE01dmdWUWdSMXh5VkQ0UkpBQmIvZ1gzbSsy?= =?utf-8?B?UmRFUzdKU1dkQ011UmY3eEJIdUlEZzl6NEsvM3pxODljM2tLQndYL3hwUDda?= =?utf-8?B?RjJadFcvNHI3aHJ2Q1Bzenl0NS9ieU54eEdZLzdEUWpCMDhZQmkvemR3Vnow?= =?utf-8?Q?Q/Os+aEgRb74BhFKUqdpNBIpNQNL/1KM6gbts70?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2200fa26-af8c-4f75-d3c6-08d96dec7440 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Sep 2021 08:34:18.0900 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: mcEMG2vgLKJ+r/fnn2mjT4ZguMdZtK43BX69hBl8YK0RRCh12jcUMsSGqfjfC4oEERJsSna2vVhba8UV+c0GPw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4382 Leaving shadow setup just to the L1TF tasklet means running Dom0 on a minimally acceptable shadow memory pool, rather than what normally would be used (also, for example, for PVH). Populate the pool before triggering the tasklet, on a best effort basis (again like done for PVH). Signed-off-by: Jan Beulich Acked-by: Tim Deegan --- v2: Latch dom0_paging_pages() result. --- a/xen/arch/x86/mm/shadow/common.c +++ b/xen/arch/x86/mm/shadow/common.c @@ -1298,7 +1298,7 @@ int shadow_set_allocation(struct domain { struct page_info *sp; - ASSERT(paging_locked_by_me(d)); + ASSERT(paging_locked_by_me(d) || system_state < SYS_STATE_active); if ( pages > 0 ) { --- a/xen/arch/x86/pv/dom0_build.c +++ b/xen/arch/x86/pv/dom0_build.c @@ -21,6 +21,7 @@ #include #include #include +#include /* Allow ring-3 access in long mode as guest cannot use ring 1 ... */ #define BASE_PROT (_PAGE_PRESENT|_PAGE_RW|_PAGE_ACCESSED|_PAGE_USER) @@ -933,7 +934,18 @@ int __init dom0_construct_pv(struct doma #ifdef CONFIG_SHADOW_PAGING if ( opt_dom0_shadow ) { + bool preempted; + printk("Switching dom0 to using shadow paging\n"); + + nr_pt_pages = dom0_paging_pages(d, nr_pages); + + do { + preempted = false; + shadow_set_allocation(d, nr_pt_pages, &preempted); + process_pending_softirqs(); + } while ( preempted ); + tasklet_schedule(&d->arch.paging.shadow.pv_l1tf_tasklet); } #endif From xen-devel-bounces@lists.xenproject.org Thu Sep 02 08:35:41 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 08:35:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177164.322418 (Exim 4.92) (envelope-from ) id 1mLiCC-0001Vi-QS; Thu, 02 Sep 2021 08:35:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177164.322418; Thu, 02 Sep 2021 08:35:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLiCC-0001Vb-NB; Thu, 02 Sep 2021 08:35:40 +0000 Received: by outflank-mailman (input) for mailman id 177164; Thu, 02 Sep 2021 08:35:39 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLiCB-0001VV-MD for xen-devel@lists.xenproject.org; Thu, 02 Sep 2021 08:35:39 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 61649c31-d848-4c36-a8cb-50d2e2728f10; Thu, 02 Sep 2021 08:35:38 +0000 (UTC) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01lp2056.outbound.protection.outlook.com [104.47.0.56]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-40-WLfgfpoDObGdH1pRwezw8Q-1; Thu, 02 Sep 2021 10:35:32 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR04MB4382.eurprd04.prod.outlook.com (2603:10a6:803:73::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.17; Thu, 2 Sep 2021 08:35:30 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4478.021; Thu, 2 Sep 2021 08:35:30 +0000 Received: from [10.156.60.236] (37.24.206.209) by AM0PR01CA0113.eurprd01.prod.exchangelabs.com (2603:10a6:208:168::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Thu, 2 Sep 2021 08:35:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 61649c31-d848-4c36-a8cb-50d2e2728f10 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1630571737; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WA1KAMRckXvuUXmqZbyvq0j4l0CKS5BjF16pVyrhqnE=; b=l0KzgmUbnDjAa4c0c92ZIOG9cY8Js3XZN98MiqVOQXq4ylEH3DG1UtjjBbDltGZbAUAzUO a2thv3prkpIb6bSg5Ovkz1SGdvXsbfdhznMZ7XHkStQR1jLWwY4dcd8c3AMfU3yCvU+pKQ RrrLl+leruAHEGbmMdkKNNESUQDti8Y= X-MC-Unique: WLfgfpoDObGdH1pRwezw8Q-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FgeD+kR1iFq0fUzJG7/zgifj1bz42Y7p2u26lBTkipvySMyy5MAhDAlCFtnvxt/asK6FwWehwRf8Grv4pDJc6ncyO8acE8UxX7LPyvJbL8C/KkQ2bRlW/lldNU5x20k3CYrSQtaxtCHm5eGyt9xwv5bdJpiNxqUAfMhsVmVhhzEd/RjnsHnxEvkdGYZeaQkGwb4acj5vwPaWtbWYDyjDtr4PrZgxwVDrNQi775M9li80jbYBqYM2/Z1zoY+tl4Dheea4n/je4nMxHGtMWneMqmbtMjA2AT7aZxfDFz0Iui5mZMROfVkXg6Si3JXrXAOFallipkqWaGfrTWh7QxTKAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WA1KAMRckXvuUXmqZbyvq0j4l0CKS5BjF16pVyrhqnE=; b=LlDIJJzGwrLpIejPSQto09A+luKjSqvO85sFz+h9Ae5jsLWPqQXx8xdRj+oHCA4dOXD7W+Yedx0oQ74T+x5LFEYfRPiJZ7suc+gfRraWS0jr8E3GXODBAHpqrQpQlbhG4yNO34j8Pc+MHGh/NYaRAd4MlJfsqtOdIXPDXVDktUWDhPD79lRka8DYsWZ4vxunmS+onSQJiWIlpkwxGgJDNQRwXOurIQWtv4yguUS1AKyXQ0rBXrBcaNdDB4JTCyFJghe842o9FfAjv+DoZAqUeFJfoSXRQ13vbYTORfuODqfUs5gOxz4uzoPMcY8VNp5PRyLBXu5P3/ga1Ch4NFHsaA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=suse.com; Subject: [PATCH v2 5/6] x86/PVH: actually show Dom0's register state from debug key '0' From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Kevin Tian , Jun Nakajima References: <5972ce4c-bdb0-6d07-afad-cf4dd5615488@suse.com> Message-ID: Date: Thu, 2 Sep 2021 10:35:27 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: <5972ce4c-bdb0-6d07-afad-cf4dd5615488@suse.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM0PR01CA0113.eurprd01.prod.exchangelabs.com (2603:10a6:208:168::18) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f1203fff-04e3-4fb5-3320-08d96dec9f9c X-MS-TrafficTypeDiagnostic: VI1PR04MB4382: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1kujJhewmYX+Uw+noRoRi+x+Ilvv0mAPF2HIKZBEKac22XkThkOwvpReFnTUKEqZPO/15SCA5Y3Pui0aG7O7Lr5+jCkAxL+IvDZmUAuGB5CrHXUYcM99Il3kKpfEZW97x92aAz5mcnAUtE3BYWQbHSOaGhdTpaFBV5yWJN+7NScuHTgRQS/th/qbBWKXmU0NP1F7pGf4jbInKUOLCegKl6/1CgOTqBRV3wy39vVbp/JpN3dtWv5eQzueLKkoHQJZkbP7yiKwoV/x7SFPp1lY3chMepyjd28Z1Fn1zFLSPNDavx9T1tu/2dvD/YemhntkLV7uiyzvzFKZLSCRMYsIoUcWM063GhaFycO5IKzTT5hd+dNWhGGqM3V57UIRlQQh0OfVypemmB7s6REen1tpILPNOPDehPTsMsVWdXOR+lJzuv4fGEd8cLJV0v8uvrNoZY2JG2VuEsF/1/VEZ5QPYx4Ofj9gPqMB0VdfoOPTVMpTUf0cyRGEemm7G3iuxlsCaLWZ+efjpuvRo3ix/G1cA7baPq20/NV6Wsgo4wAuy/cKuB8zj4ShIaYKz8OTzBlLqN1ot9CYOlYyo7o8B6ZG1/JP+ghhPvSqqjY+uZGXwhxqkh2eY/xAXPzur1hwj53yGyy7BsaLhL+URaYMjVjxqLoqF7XWrMgcUSYUV7OiH2HglqdyDOP5jnSfhk0sDg7eNHJU+CwtxhW4mymai2OUZg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(39860400002)(136003)(366004)(396003)(376002)(346002)(31696002)(66476007)(2906002)(186003)(66946007)(38100700002)(26005)(66556008)(5660300002)(478600001)(4326008)(31686004)(36756003)(8676002)(6486002)(316002)(16576012)(6916009)(8936002)(54906003)(956004)(2616005)(83380400001)(86362001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YW1xb01rVExQNTZqVk12TjlKaURVTlRYUVVlNTFTeEdha2M0QXlydlFHaFdr?= =?utf-8?B?ZmcrRFZLam1mTGNNdkllZlppQlZvTXBQRzdOTUJVNmZmVzArdXllUnA4K2RH?= =?utf-8?B?Z2wvUUp5UmlXT1Zod0JWZmhyemV1L3hhZTJlaHFQU0UyVHlNUnZHL3ErR0VS?= =?utf-8?B?L0RsRkdaK2xEdDBNS29qeVdIWlZjKzNpbjA5Qk5ZTHh4SzZDdEdQZWlJLzk4?= =?utf-8?B?aWxJdnJteUFYaHhTeFlOOUxPZHJyeWJ1T05MWFRxemRORlpCSHByaWZkSmpY?= =?utf-8?B?SGhQMEFzRGYvQmdrOWswdmRYcEppWE9QalAzM281ZGJodEFMSHUzYzJ4a3FF?= =?utf-8?B?Mm1YOTd4REJxWFdsMzFheEVMNFNnMjU4NUgxRHZNRWNRYUNPNG5jTENaNlVO?= =?utf-8?B?dk04UEZDTHo3ZmxmREdGYjJ4TFRDVGYva3VlWkczdzdGVW9hblFTRmVTYnNY?= =?utf-8?B?dC9PTjlyaDNoNjZwdlJScmExeHI4WEppQ2s0MHBvdmJ6SDFzR2hIS3lIak8w?= =?utf-8?B?MVpBWnJ3REo0bFFPNFlEZ2s2UTgwK2FOTGRDbTcvUU9rNVVLTmZqNGF1WFlD?= =?utf-8?B?NnFxejBZb2owU1MvaEJuNCtSUWZDQ3Q5Z3NXUHFpYUZ4cm8rYWt1RTNNUUx6?= =?utf-8?B?cncyZGdXRnlRZU5hazNVdUFBMzVzMVBlUExpUzllMW9VL1d5OUl0UVVDZ1p5?= =?utf-8?B?VjgveWw0WlhLbmIrbTFsb0RTU2dCZmNLcld1VHE1UENKeXlGR0FWQldENGsy?= =?utf-8?B?RFBmTW9HQWs2QS9wSzA0c3NvU3RyekFnQkN4L0NFZmtjZ0xiOWJHbjlDWkdL?= =?utf-8?B?Rjdrc1ZHTGJOazRiL3kvWXhGRm9TTFcyTEcxekt4MGE0UjhKRElDc09kaUlP?= =?utf-8?B?UzJKU1FWTllSdW4zU1hVVEpOUUxoVEpIek5mck4yNHA5cFFQVWJidFplT0Vw?= =?utf-8?B?T2tuVmZoTVBIUmY3RkczNDRPT0xWZ3hCei9tTVJKb1I1eFVjY2lOVW81a2FX?= =?utf-8?B?VUZ0elhqL3M0NERyTlFIUExwY3d3Y1pZc0VPK0F2NTR1SS9Qdm5YWFgvKzdB?= =?utf-8?B?aE1ldjFKTVY5bEYyYTlpc21HL0pjVjNOVDJOYnFqZGREcjRoaHhoQjh4Q250?= =?utf-8?B?aCswM25PM2l1TDlPbDNzeDl1ZkVVUjFyUXdNMi9ZcnNPellucVJmWFRkUTFo?= =?utf-8?B?Q2dScVdubGxJWVU1eDB0eTZuRzRQaE1ubTcwWEhjNkNoek9Lbk9nMGxReExI?= =?utf-8?B?NkhrMGg2U1VqMHZNVzRvbEFDLzNpck5vSlRnWnNwS3NuRndlaWVsWHFXMmpV?= =?utf-8?B?dXJqWG1vaWFVdmc4c2dFSkVUUDFMcmdNMnFMbFEvc2hXMmk2eDRIUmUycmFm?= =?utf-8?B?Tys0R01seHB5OFoxQkQzaHQ5RTFkT2F3YzdvMnBKS0dBcEhvenB5bG52UzZq?= =?utf-8?B?K01sSURVUGRVMS9Kd2Qvb1FpNFdEZjhpUnI5SUZtN3RpN3dmM09IWXY3ODk4?= =?utf-8?B?V0dTV0Zac20vN3k0U0l6dW16c1plWmsvelllK3FHV05oa1FDY0V4NzZ1NXY1?= =?utf-8?B?cXlCZytJT1FzQkl4T1o1ZFVaTDZieXpzdEdZRmNkT3cvMFdRaGxsclY2Z1NS?= =?utf-8?B?RDFSK2g0OXFidlIva01PZVRMR2RxZXlsL0ozK3A1WEFVRDZ5N3RDN1hrNHVL?= =?utf-8?B?ckprL1gyaWdJT3U5WnFjOTdUMWYwSmlOTTEwWVg5MTNuL3FLWVAzTGtGZndN?= =?utf-8?Q?JrH28oUtXR9viFbSvsubGlI8eLp5WgE+okcIgK9?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: f1203fff-04e3-4fb5-3320-08d96dec9f9c X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Sep 2021 08:35:30.8818 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: gcQ/uPgMGbWDlFY+ZF5tk7X9RMxD/7loktpn1QcPD/55qFIiyM6jj3egHPLRy7v5hyUtWM2r5B3O3CL/x5GbqQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4382 vcpu_show_registers() didn't do anything for HVM so far. Note though that some extra hackery is needed for VMX - see the code comment. Note further that the show_guest_stack() invocation is left alone here: While strictly speaking guest_kernel_mode() should be predicated by a PV / !HVM check, show_guest_stack() itself will bail immediately for HVM. While there and despite not being PVH-specific, take the opportunity and filter offline vCPU-s: There's not really any register state associated with them, so avoid spamming the log with useless information while still leaving an indication of the fact. Signed-off-by: Jan Beulich --- I was pondering whether to also have the VMCS/VMCB dumped for every vCPU, to present full state. The downside is that for larger systems this would be a lot of output. --- v2: New. --- a/xen/arch/x86/x86_64/traps.c +++ b/xen/arch/x86/x86_64/traps.c @@ -49,6 +49,39 @@ static void read_registers(struct cpu_us crs[7] = read_gs_shadow(); } +static void get_hvm_registers(struct vcpu *v, struct cpu_user_regs *regs, + unsigned long crs[8]) +{ + struct segment_register sreg; + + crs[0] = v->arch.hvm.guest_cr[0]; + crs[2] = v->arch.hvm.guest_cr[2]; + crs[3] = v->arch.hvm.guest_cr[3]; + crs[4] = v->arch.hvm.guest_cr[4]; + + hvm_get_segment_register(v, x86_seg_cs, &sreg); + regs->cs = sreg.sel; + + hvm_get_segment_register(v, x86_seg_ds, &sreg); + regs->ds = sreg.sel; + + hvm_get_segment_register(v, x86_seg_es, &sreg); + regs->es = sreg.sel; + + hvm_get_segment_register(v, x86_seg_fs, &sreg); + regs->fs = sreg.sel; + crs[5] = sreg.base; + + hvm_get_segment_register(v, x86_seg_gs, &sreg); + regs->gs = sreg.sel; + crs[6] = sreg.base; + + hvm_get_segment_register(v, x86_seg_ss, &sreg); + regs->ss = sreg.sel; + + crs[7] = hvm_get_shadow_gs_base(v); +} + static void _show_registers( const struct cpu_user_regs *regs, unsigned long crs[8], enum context context, const struct vcpu *v) @@ -99,27 +132,8 @@ void show_registers(const struct cpu_use if ( guest_mode(regs) && is_hvm_vcpu(v) ) { - struct segment_register sreg; + get_hvm_registers(v, &fault_regs, fault_crs); context = CTXT_hvm_guest; - fault_crs[0] = v->arch.hvm.guest_cr[0]; - fault_crs[2] = v->arch.hvm.guest_cr[2]; - fault_crs[3] = v->arch.hvm.guest_cr[3]; - fault_crs[4] = v->arch.hvm.guest_cr[4]; - hvm_get_segment_register(v, x86_seg_cs, &sreg); - fault_regs.cs = sreg.sel; - hvm_get_segment_register(v, x86_seg_ds, &sreg); - fault_regs.ds = sreg.sel; - hvm_get_segment_register(v, x86_seg_es, &sreg); - fault_regs.es = sreg.sel; - hvm_get_segment_register(v, x86_seg_fs, &sreg); - fault_regs.fs = sreg.sel; - fault_crs[5] = sreg.base; - hvm_get_segment_register(v, x86_seg_gs, &sreg); - fault_regs.gs = sreg.sel; - fault_crs[6] = sreg.base; - hvm_get_segment_register(v, x86_seg_ss, &sreg); - fault_regs.ss = sreg.sel; - fault_crs[7] = hvm_get_shadow_gs_base(v); } else { @@ -159,24 +173,35 @@ void show_registers(const struct cpu_use void vcpu_show_registers(const struct vcpu *v) { const struct cpu_user_regs *regs = &v->arch.user_regs; - bool kernel = guest_kernel_mode(v, regs); + struct cpu_user_regs aux_regs; + enum context context; unsigned long crs[8]; - /* Only handle PV guests for now */ - if ( !is_pv_vcpu(v) ) - return; - - crs[0] = v->arch.pv.ctrlreg[0]; - crs[2] = arch_get_cr2(v); - crs[3] = pagetable_get_paddr(kernel ? - v->arch.guest_table : - v->arch.guest_table_user); - crs[4] = v->arch.pv.ctrlreg[4]; - crs[5] = v->arch.pv.fs_base; - crs[6 + !kernel] = v->arch.pv.gs_base_kernel; - crs[7 - !kernel] = v->arch.pv.gs_base_user; + if ( is_hvm_vcpu(v) ) + { + aux_regs = *regs; + get_hvm_registers(v->domain->vcpu[v->vcpu_id], &aux_regs, crs); + regs = &aux_regs; + context = CTXT_hvm_guest; + } + else + { + bool kernel = guest_kernel_mode(v, regs); + + crs[0] = v->arch.pv.ctrlreg[0]; + crs[2] = arch_get_cr2(v); + crs[3] = pagetable_get_paddr(kernel ? + v->arch.guest_table : + v->arch.guest_table_user); + crs[4] = v->arch.pv.ctrlreg[4]; + crs[5] = v->arch.pv.fs_base; + crs[6 + !kernel] = v->arch.pv.gs_base_kernel; + crs[7 - !kernel] = v->arch.pv.gs_base_user; + + context = CTXT_pv_guest; + } - _show_registers(regs, crs, CTXT_pv_guest, v); + _show_registers(regs, crs, context, v); } void show_page_walk(unsigned long addr) --- a/xen/arch/x86/traps.c +++ b/xen/arch/x86/traps.c @@ -631,6 +631,12 @@ void vcpu_show_execution_state(struct vc { unsigned long flags; + if ( test_bit(_VPF_down, &v->pause_flags) ) + { + printk("*** %pv is offline ***\n", v); + return; + } + printk("*** Dumping Dom%d vcpu#%d state: ***\n", v->domain->domain_id, v->vcpu_id); @@ -642,6 +648,21 @@ void vcpu_show_execution_state(struct vc vcpu_pause(v); /* acceptably dangerous */ +#ifdef CONFIG_HVM + /* + * For VMX special care is needed: Reading some of the register state will + * require VMCS accesses. Engaging foreign VMCSes involves acquiring of a + * lock, which check_lock() would object to when done from an IRQs-disabled + * region. Despite this being a layering violation, engage the VMCS right + * here. This then also avoids doing so several times in close succession. + */ + if ( cpu_has_vmx && is_hvm_vcpu(v) ) + { + ASSERT(!in_irq()); + vmx_vmcs_enter(v); + } +#endif + /* Prevent interleaving of output. */ flags = console_lock_recursive_irqsave(); @@ -651,6 +672,11 @@ void vcpu_show_execution_state(struct vc console_unlock_recursive_irqrestore(flags); +#ifdef CONFIG_HVM + if ( cpu_has_vmx && is_hvm_vcpu(v) ) + vmx_vmcs_exit(v); +#endif + vcpu_unpause(v); } From xen-devel-bounces@lists.xenproject.org Thu Sep 02 08:36:38 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 08:36:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177170.322429 (Exim 4.92) (envelope-from ) id 1mLiCw-00026I-4y; Thu, 02 Sep 2021 08:36:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177170.322429; Thu, 02 Sep 2021 08:36:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLiCw-00026B-1O; Thu, 02 Sep 2021 08:36:26 +0000 Received: by outflank-mailman (input) for mailman id 177170; Thu, 02 Sep 2021 08:36:24 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLiCu-000261-El for xen-devel@lists.xenproject.org; Thu, 02 Sep 2021 08:36:24 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id da8f42fa-0bc8-11ec-ae48-12813bfff9fa; Thu, 02 Sep 2021 08:36:23 +0000 (UTC) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05lp2106.outbound.protection.outlook.com [104.47.18.106]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-21-h7Kl6CexN6K9du2Ae_-NoA-2; Thu, 02 Sep 2021 10:36:21 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR0402MB3774.eurprd04.prod.outlook.com (2603:10a6:803:1f::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.23; Thu, 2 Sep 2021 08:36:21 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4478.021; Thu, 2 Sep 2021 08:36:21 +0000 Received: from [10.156.60.236] (37.24.206.209) by AM0PR01CA0142.eurprd01.prod.exchangelabs.com (2603:10a6:208:168::47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Thu, 2 Sep 2021 08:36:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: da8f42fa-0bc8-11ec-ae48-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1630571782; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3HFchKadupoYKtpNV3JYrysgf0xXI5YrxKsF7FnzFzY=; b=cER4fy4euTrxYJt6cNuZ4nrq7Fj7i0suLo17RUdAUdCV9ImGEH2zJUBcEM90+FiEBwC7fT 8BnIl1mrtb9eVDdXE/hs9PUyf8aMUO6BLPsYBjO1HKVUwIf/HI2xIOyCMYrNufz6q82thK FDoWmWFfgNrcjHka2EySYVtsrTOo5T8= X-MC-Unique: h7Kl6CexN6K9du2Ae_-NoA-2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ENAuNW26oOVoUlaUGTBVtchjUH19yEzgBRSRLdxfPOPmQvDWcd0xq3ixkf3UHAZ3aDGnJmJ/stubckZ0KW7kes2Kbr1t2/A1mrLu2WBmAJIBEiFrvh5q5TQdnI8rzBn31UHP3tlbA412BHUc9c3euIFIoYU2A4ebtkh31J01+mYw1Alb9VwXGpa/QvRsjp0WBtgs6V8/3eKzRXTUDuhUtwseJSCUQ15ndw2OqEBtpa1m1qS+iaXaANK/4H70ZBOeK2+ysQs/DM+s+q+EeSDQjgnbEDPQvnzpdA9LaohrwHUp3pQHm7bSarx3ZIVzm/7uWjEtWUlMIO2rz/DNx3moFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3HFchKadupoYKtpNV3JYrysgf0xXI5YrxKsF7FnzFzY=; b=HnwuMz2pbxBhJcat1k1iXydYwGElHcWwFXQ14FJnWWm601UzLOYzOEWI0Rx6fFj83kKn4wyfkdLYjE/R+Nie3d4wufAIyV2+wnoaY4WhrT0CHBbs0cyxVQm7SqTa//e1VHygXC7Fv66mTz0rWFctK578yXqPXcaQ/p0ZFxTLdoisjDGcw74KlYDiuTxQqub1St2fz3aJDV8Oc9ESN7abL2TRzu6bDReeWtDYxQH/EbWHrkhPgqHVf5pmLxOKDFJSdVo9ahubKYTGKkoHbOJ9f9QEHKM6eABCn8FHlRm8i48YIuLjZUhQ8KNdpTghrmQ4hSgBtDYetEFbCV0BzzsbzA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=suse.com; Subject: [PATCH v2 6/6] x86/HVM: skip offline vCPU-s when dumping VMCBs/VMCSes From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Kevin Tian , Jun Nakajima References: <5972ce4c-bdb0-6d07-afad-cf4dd5615488@suse.com> Message-ID: <332739d2-be0d-fe8f-9ae7-a34916f4eab6@suse.com> Date: Thu, 2 Sep 2021 10:36:19 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: <5972ce4c-bdb0-6d07-afad-cf4dd5615488@suse.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM0PR01CA0142.eurprd01.prod.exchangelabs.com (2603:10a6:208:168::47) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0668c48c-5c43-402a-9a7e-08d96decbda0 X-MS-TrafficTypeDiagnostic: VI1PR0402MB3774: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:457; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5rBBEvOhR7faCZjTzNU50BXFN68nDasGZ3jlg0KO6SjhlL5TykJJbwZB/CyohboKMnUO/nslnlgub068PBCWIWWfI40fKCO+T+Hr52k6a+wjRni+zPWhUhLIN3zP83pOCGUYLBpYM6OCKTXYfSxLPSVaMgcZlX47JKARUJ6hpgEnXq5soW+PcBKtKEA9I6J9QbgW/ZJd8RIoYUOEIdPWu1yG/qF7hpRCPK8mXJFi3FXBUTZ2rAn0ZP8ju0bJfWS/4+4bbhhzEtk2/QzbjrpRBIfPeHBb0OXTZ1yCJxPTUKfQwIkAav2ZoglzjfSgDoji4pvxcT9vc4sBl/3u8Rizq8go2OSyHS8tIs4TklTnZwkkFFoplyM8336FYhoTDsaZSpyYYssi/Bl7fMBNzxKM6GYGxVNufb8qFPD1HWd+m/IzOCkFtsezeKE54oIHod2A0kna6EpLJAv2VZEEtz8TCKmdcvPxauwc5RSHXwAU1jiFB9LISvyeUN4aYBS/GI4aCbmRXpsfu6zVZGZPnRGuVsXe+rPX/fkZhxs+Ywx/u8zHcsWzxSRd2CvdqyYToZswGxZqUWlAO6t0wS4w5+3RMGF1wPC863rcd/3RzDEfqzNEcXM4t5RL+kE8Z20IA0EYYsCIY1M7kBbelcH/jGRhDfEdpgtgpO1MUCxX000bUFWilely20YKIIo5t7buSxaixk5n/VDHUFsSUYEEH4NdLA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(136003)(346002)(366004)(396003)(39860400002)(376002)(36756003)(956004)(54906003)(6486002)(6916009)(478600001)(16576012)(38100700002)(66946007)(4326008)(316002)(66556008)(2906002)(26005)(66476007)(86362001)(31696002)(186003)(8676002)(8936002)(31686004)(2616005)(5660300002)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?djZHK21UVmVpaEFnQUFyeWxLMDVaVG84RDRkOThWUFhpdGdaZGhWaWFFWjFj?= =?utf-8?B?Qi9NaWpOdysvTkVuVE1VTnBJWDNxdEErNnowSnlycnZWZTBUSEdwUWxjcFg4?= =?utf-8?B?NWJJTTBiRnFzdmh3OU82VzZHeXpoQ3BKK3ZWMk80cTJWcGdaeEdyUWZXTnhp?= =?utf-8?B?bTAxNGtsa3dVbUg4a3dTWExzUVJuT29xVk5lK0wyUnQ3TThJWEhWUFhnTldp?= =?utf-8?B?emtOWnRBaDRDOHpvK0VSN1I2VjhYVC9HN1lzUE1FMU1XU3lQdDNwNzBDcldr?= =?utf-8?B?WDRKZDFqSG1TZk9rdmxqSmY3UXo2VHhKRG9VY0MwMXJraWhqbGdMOGhJNnFn?= =?utf-8?B?SCtJYVVmYm1tYStUSzJMQWp4NFNDc2dtUkRjTEVYb01YOVJ5dmdwYXFoVGVD?= =?utf-8?B?YnkybnZaZnUweUdTaWxHMSt2MEo0OHhsSmF6dkpONlpzTWlFTmoxd09IeVRt?= =?utf-8?B?R21aV29jT3VuMUYyOHhPMVdqL3RqTWF0MlVLcjd4WDE3LzR3Wm5kK1RVd1RP?= =?utf-8?B?aFJkUkorU1kxWEpFTkxUOXVaZ2ZGekd3amZhWlpZZGRpVk5ObGdBSUZFbEdK?= =?utf-8?B?NG52SW5CeEZ4MFAyRjBNVlhFWXUrcTN6OGlNYzZyVnZCcjVnWENDUk95VjlX?= =?utf-8?B?MTJwejQwN0gyY0dEMUF2S3o0dmtGZDZkQVJKRmF2MEU5WkErZUpwd0JiUmRX?= =?utf-8?B?b2JEVUNKSW1tMy91NE16VTVvQ1RYdXhWRFVrZ05CVE5NT0RYOXpaSGV0YWVs?= =?utf-8?B?eGJnMjkvcmRWTEpkaHdNM2tUVkdIcE54RHlMV2hwV3pjU2x6NXFsSDhnMnZ6?= =?utf-8?B?S0pZc3BMNm85L2xPdWgwMi9ERlVjbjFteUtHaVFERkNiSDJXUXVXbzBla1BR?= =?utf-8?B?V2xzQmJyRVlhbEkvdEtuVXpaQlo3YmZCV2RmWEpERllzKzFNTDZNT0lNSFJL?= =?utf-8?B?Y1VDcmYvdml6cmpmenVxbk9CdytCcVo4QmRxNDZ5aEhDWVRsTS9Ed0M4TENH?= =?utf-8?B?MXBvSXU5R2VURkliaEVXYmFoaStrbnRzY2VqcWNiV1FRS2lwM3VUTlFlT0dn?= =?utf-8?B?T3cxSjN1YUY3RFRrZGJqcGVEeVozdGpObUFybVFpWDBqcWFjeThrT1Nqb3U0?= =?utf-8?B?YmxZTWZWV2JWWmVLUTB6c1VQQWIrdkpMOHVjajdPUHcxa3RaRFVTdFkxcnpF?= =?utf-8?B?Qk9tSEdhNWtuNXFiQWJlWmF1c0ZVWXlIZmVLa2E5bkFMajRNNHVGSys1Tzd1?= =?utf-8?B?M2xzdUFsWnV4Wk5MbGx3SktBbEFtK3lDZGUzcldmSXlic3JKeEl2NUZqMWgy?= =?utf-8?B?TkJvaEswZ285bUgzSUdNZTlkVHVVbGpSazZTampXbU1VeHF4N0ZFaTFnek1h?= =?utf-8?B?MzY4WWNiQm80LzlqUlh0OFk5LzVUN0E3bWF3WTFyTGFWeGszcE9TWVlkL2Za?= =?utf-8?B?akR2d1B2VXkxL2dld3EvUUJTbnBOL25VN2JRUW0rd3FtcXRWZW1BMnN2dzJU?= =?utf-8?B?c054YnBZRHdpN2g4dVZ5SFN1dDM2YjdMUFFWQ05mNXVqMU9YYVVaMFhhVi9o?= =?utf-8?B?QzFTSm9OODBsYUdnUnUwNXdvZW5ZTVlLTC9RWlBtdDkxNjJmTVQwcjRrOVhi?= =?utf-8?B?N1A4YkVNQ01aMGhvNE9tYjZxWk5tWjA4dXdmRUlETmowM3ArVWx3NTBRL0Er?= =?utf-8?B?UTQwQ29nZS9sVEYrd0JWa0NoWmZZTlg3S3BFYVpSTEFQRk80Rm9ybVdoMEJw?= =?utf-8?Q?ZtMhKvRL5RZit2oyUbt/l6ZZuqpE+JCOUVyH10q?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0668c48c-5c43-402a-9a7e-08d96decbda0 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Sep 2021 08:36:21.1863 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Z3HeDrcO2NcmV0MsIdjnSmiC5l8AtPoOEBrEOyMQ3ojFJN/4VbgudW6OEh1AzWG99uZsTyJYiJ/ri9Ylqqyy/A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3774 There's not really any register state associated with offline vCPU-s, so avoid spamming the log with largely useless information while still leaving an indication of the fact. Signed-off-by: Jan Beulich --- v2: New. --- a/xen/arch/x86/hvm/svm/vmcb.c +++ b/xen/arch/x86/hvm/svm/vmcb.c @@ -241,6 +241,11 @@ static void vmcb_dump(unsigned char ch) printk("\n>>> Domain %d <<<\n", d->domain_id); for_each_vcpu ( d, v ) { + if ( test_bit(_VPF_down, &v->pause_flags) ) + { + printk("\tVCPU %u: offline\n", v->vcpu_id); + continue; + } printk("\tVCPU %d\n", v->vcpu_id); svm_vmcb_dump("key_handler", v->arch.hvm.svm.vmcb); } --- a/xen/arch/x86/hvm/vmx/vmcs.c +++ b/xen/arch/x86/hvm/vmx/vmcs.c @@ -2133,6 +2133,11 @@ static void vmcs_dump(unsigned char ch) printk("\n>>> Domain %d <<<\n", d->domain_id); for_each_vcpu ( d, v ) { + if ( test_bit(_VPF_down, &v->pause_flags) ) + { + printk("\tVCPU %u: offline\n", v->vcpu_id); + continue; + } printk("\tVCPU %d\n", v->vcpu_id); vmcs_dump_vcpu(v); } From xen-devel-bounces@lists.xenproject.org Thu Sep 02 08:59:56 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 08:59:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177178.322445 (Exim 4.92) (envelope-from ) id 1mLiZY-00054u-4F; Thu, 02 Sep 2021 08:59:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177178.322445; Thu, 02 Sep 2021 08:59:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLiZY-00054n-1I; Thu, 02 Sep 2021 08:59:48 +0000 Received: by outflank-mailman (input) for mailman id 177178; Thu, 02 Sep 2021 08:59:46 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLiZW-00054h-2F for xen-devel@lists.xenproject.org; Thu, 02 Sep 2021 08:59:46 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLiZS-0000gz-9G; Thu, 02 Sep 2021 08:59:42 +0000 Received: from 54-240-197-224.amazon.com ([54.240.197.224] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1mLiZS-0001SW-1B; Thu, 02 Sep 2021 08:59:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=AZFZoEmGVV9n+CJDtxX6UCmu2LESlsmMlXLemu/qy0c=; b=faZWoWpkJwZTY5H72pvskTMuuC lMzemWpbgKHYSfD4HcyWFy3LLmGqfNKx92KSTLkqie+UAU8e7gwzAdn8dtgyDTCHIK3bgLlOf+X+u IVi8zkEGayJIwEaUa2yKTkS6XbCuKsTZeahcLblGfEoj0KNpeSASX43BHTaX1ji9Rsao=; Subject: Re: [PATCH] xen/arm: Introduce pmu_access parameter To: Bertrand Marquis Cc: Stefano Stabellini , Michal Orzel , "xen-devel@lists.xenproject.org" , Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Wei Liu , Volodymyr Babchuk References: <20210901124308.31573-1-michal.orzel@arm.com> <599515f0-4b8a-3a71-caea-b17ec27c9123@xen.org> <44B48162-EB44-4295-9629-2D95A40D7232@arm.com> <46e36ba5-8b3d-2d43-6297-b92d2654ab72@xen.org> <0e72fb05-a477-ef79-c26f-bc011393a403@xen.org> <5B7B9C01-FF1D-44F9-8815-A422E51916A0@arm.com> From: Julien Grall Message-ID: Date: Thu, 2 Sep 2021 09:59:39 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <5B7B9C01-FF1D-44F9-8815-A422E51916A0@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit On 02/09/2021 08:57, Bertrand Marquis wrote: > Hi Julien, Hi Bertrand, > If I understand it right, you want a per guest parameter to be able to allow PMU accesses. > This would require: > - to save/restore MDCR on context switch > - introduce a new config parameter for guests (might or might not need a tool change) > - have a xen command line parameter to have a solution to Allow PMU for dom0 (or maybe a DTB one) Yes. > > But this would NOT include: > - interrupt support (only needed to get informed of overflow) > - provide PMU virtualization (not even sure something like that could make much sense) I am guessing the following is also included here: - provide a PMU node in the DTB for the domain. Without those 3, I feel we are exposing an half backed PMU to the guest. But this would still be a good first step, so I would be OK if they are not implemented in the first shot. > > I am not saying that we will do that now but as I need to unblock this I could evaluate the effort and see if it could be possible to do this in the future. Well... Below the patch I wrote during my breakfast this morning. This has not been tested and miss some documentation. From 690a92cffed82451dcbd8b966e8dee31c1dce5fc Mon Sep 17 00:00:00 2001 From: Julien Grall Date: Thu, 2 Sep 2021 08:46:12 +0000 Subject: [PATCH] xen/arm: Expose the PMU to the guest There are requests to expose the PMU (even in a hackish/non-secure way) to the guests. This is taking the first steps by adding a per-domain flag to disable the PMU traps. Long term, we will want to at least expose the PMU interrupts, device-tree binding. For more use cases, we will also need to save/restore the PMU context. Signed-off-by: Julien Grall --- tools/include/libxl.h | 2 ++ tools/libs/light/libxl_arm.c | 3 +++ tools/libs/light/libxl_types.idl | 2 ++ tools/xl/xl_parse.c | 3 +++ xen/arch/arm/domain.c | 10 ++++++++-- xen/include/asm-arm/domain.h | 1 + xen/include/public/domctl.h | 4 ++++ 7 files changed, 23 insertions(+), 2 deletions(-) diff --git a/tools/include/libxl.h b/tools/include/libxl.h index b9ba16d69869..d3e795a38670 100644 --- a/tools/include/libxl.h +++ b/tools/include/libxl.h @@ -502,6 +502,8 @@ */ #define LIBXL_HAVE_X86_MSR_RELAXED 1 +#define LIBXL_HAVE_ARM_VPMU 1 + /* * libxl ABI compatibility * diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c index e3140a6e0039..89865a90dd3e 100644 --- a/tools/libs/light/libxl_arm.c +++ b/tools/libs/light/libxl_arm.c @@ -29,6 +29,9 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc, uint32_t vuart_irq; bool vuart_enabled = false; + if (d_config->b_info.arch.vpmu) + config->flags |= XEN_DOMCTL_CDF_PMU; + /* * If pl011 vuart is enabled then increment the nr_spis to allow allocation * of SPI VIRQ for pl011. diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_types.idl index 3f9fff653a4a..daf768cba568 100644 --- a/tools/libs/light/libxl_types.idl +++ b/tools/libs/light/libxl_types.idl @@ -644,6 +644,8 @@ libxl_domain_build_info = Struct("domain_build_info",[ ("arch_arm", Struct(None, [("gic_version", libxl_gic_version), ("vuart", libxl_vuart_type), + # XXX: Can this be common? + ("vpmu", boolean) ])), ("arch_x86", Struct(None, [("msr_relaxed", libxl_defbool), ])), diff --git a/tools/xl/xl_parse.c b/tools/xl/xl_parse.c index 17dddb4cd534..6e497cc0b67e 100644 --- a/tools/xl/xl_parse.c +++ b/tools/xl/xl_parse.c @@ -2729,6 +2729,9 @@ skip_usbdev: } } + /* XXX: This probably want to be common or #ifdef-ed */ + xlu_cfg_get_defbool(config, "vpmu", &b_info->arch_arm.vpmu, 0); + if (!xlu_cfg_get_string (config, "tee", &buf, 1)) { e = libxl_tee_type_from_string(buf, &b_info->tee); if (e) { diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c index 19c756ac3d46..a0e2321008ab 100644 --- a/xen/arch/arm/domain.c +++ b/xen/arch/arm/domain.c @@ -276,6 +276,9 @@ static void ctxt_switch_to(struct vcpu *n) * timer. The interrupt needs to be injected into the guest. */ WRITE_SYSREG(n->arch.cntkctl, CNTKCTL_EL1); virt_timer_restore(n); + + /* XXX: Check the position and synchronization requirement */ + WRITE_SYSREG(n->arch.mdcr_el2, MDCR_EL2); } /* Update per-VCPU guest runstate shared memory area (if registered). */ @@ -585,6 +588,9 @@ int arch_vcpu_create(struct vcpu *v) v->arch.vmpidr = MPIDR_SMP | vcpuid_to_vaffinity(v->vcpu_id); v->arch.hcr_el2 = get_default_hcr_flags(); + v->arch.mdcr_el2 = HDCR_TDRA|HDCR_TDOSA|HDCR_TDA; + if ( !(v->domain->options & XEN_DOMCTL_CDF_PMU) ) + v->arch.mdcr_el2 |= HDCR_TPM|HDCR_TPMCR; if ( (rc = vcpu_vgic_init(v)) != 0 ) goto fail; @@ -622,8 +628,8 @@ int arch_sanitise_domain_config(struct xen_domctl_createdomain *config) { unsigned int max_vcpus; - /* HVM and HAP must be set. IOMMU may or may not be */ - if ( (config->flags & ~XEN_DOMCTL_CDF_iommu) != + /* HVM and HAP must be set. IOMMU and PMU may or may not be */ + if ( (config->flags & ~(XEN_DOMCTL_CDF_iommu | XEN_DOMCTL_CDF_pmu)) != (XEN_DOMCTL_CDF_hvm | XEN_DOMCTL_CDF_hap) ) { dprintk(XENLOG_INFO, "Unsupported configuration %#x\n", diff --git a/xen/include/asm-arm/domain.h b/xen/include/asm-arm/domain.h index c9277b5c6d94..14e575288f77 100644 --- a/xen/include/asm-arm/domain.h +++ b/xen/include/asm-arm/domain.h @@ -166,6 +166,7 @@ struct arch_vcpu /* HYP configuration */ register_t hcr_el2; + register_t mdcr_el2; uint32_t teecr, teehbr; /* ThumbEE, 32-bit guests only */ #ifdef CONFIG_ARM_32 diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h index 96696e3842da..db9539ddd579 100644 --- a/xen/include/public/domctl.h +++ b/xen/include/public/domctl.h @@ -71,6 +71,10 @@ struct xen_domctl_createdomain { #define _XEN_DOMCTL_CDF_nested_virt 6 #define XEN_DOMCTL_CDF_nested_virt (1U << _XEN_DOMCTL_CDF_nested_virt) +/* Should we expose the vPMU to the guest? */ +#define _XEN_DOMCTL_CDF_pmu 6 +#define XEN_DOMCTL_CDF_pmu (1U<<_XEN_DOMCTL_CDF_pmu) + /* Max XEN_DOMCTL_CDF_* constant. Used for ABI checking. */ #define XEN_DOMCTL_CDF_MAX XEN_DOMCTL_CDF_nested_virt > In the meantime we will start maintaining an internal branch with patches refused upstream as this is blocking us. For the future, please consider a per-domain option from the beginning. This is not much extra effort (see the patch above) and would make the acceptance of a patch more likely. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Sep 02 09:06:50 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 09:06:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177185.322456 (Exim 4.92) (envelope-from ) id 1mLigA-0006rt-0U; Thu, 02 Sep 2021 09:06:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177185.322456; Thu, 02 Sep 2021 09:06:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLig9-0006rm-To; Thu, 02 Sep 2021 09:06:37 +0000 Received: by outflank-mailman (input) for mailman id 177185; Thu, 02 Sep 2021 09:06:36 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLig8-0006rc-OZ; Thu, 02 Sep 2021 09:06:36 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLig8-0000rX-Dt; Thu, 02 Sep 2021 09:06:36 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLig8-0002g2-3j; Thu, 02 Sep 2021 09:06:36 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mLig8-0000Iy-3D; Thu, 02 Sep 2021 09:06:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=pXBTzorr5Q2J+UyjMbNLPDqtGFYOWLYYZGBHxKHAM+8=; b=audqGzQxEbyXfgwgwUVKGlreAC XzPr3tuyeftb4dAXnKupEQ4CKZhWfUejS1ALpyTfxgQ1eRWjNbKwuMw40F4Z6GH0Mu5HTqYSgOBsR ocnb5ftzvb44Rwly6ZOqWpkc8uQ5e+Kza9J38LaiRTgDBiShnWl23V+eccyUnzq0KNDI=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 164731: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-i386-xl-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-examine:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-i386-xl-raw:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-pvshim:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-i386:xen-install:fail:regression linux-linus:test-amd64-i386-xl-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ovmf-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-coresched-i386-xl:xen-install:fail:regression linux-linus:test-arm64-arm64-xl-credit1:debian-fixup:fail:regression linux-linus:test-arm64-arm64-xl-thunderx:debian-fixup:fail:regression linux-linus:test-arm64-arm64-xl-credit2:debian-fixup:fail:regression linux-linus:test-arm64-arm64-xl:debian-fixup:fail:regression linux-linus:test-arm64-arm64-xl-xsm:debian-fixup:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:debian-fixup:fail:regression linux-linus:test-amd64-amd64-xl:guest-start/debian.repeat:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=7c636d4d20f8c5acfbfbc60f326fddb0e1cf5daa X-Osstest-Versions-That: linux=deacdb3e3979979016fcd0ffd518c320a62ad166 From: osstest service owner Date: Thu, 02 Sep 2021 09:06:36 +0000 flight 164731 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/164731/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-examine 6 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-i386-xl-raw 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-pvshim 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-i386 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ovmf-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-coresched-i386-xl 7 xen-install fail REGR. vs. 152332 test-arm64-arm64-xl-credit1 13 debian-fixup fail REGR. vs. 152332 test-arm64-arm64-xl-thunderx 13 debian-fixup fail REGR. vs. 152332 test-arm64-arm64-xl-credit2 13 debian-fixup fail REGR. vs. 152332 test-arm64-arm64-xl 13 debian-fixup fail REGR. vs. 152332 test-arm64-arm64-xl-xsm 13 debian-fixup fail REGR. vs. 152332 test-arm64-arm64-libvirt-xsm 13 debian-fixup fail REGR. vs. 152332 test-amd64-amd64-xl 22 guest-start/debian.repeat fail REGR. vs. 152332 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 152332 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 152332 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152332 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152332 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 152332 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152332 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152332 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux 7c636d4d20f8c5acfbfbc60f326fddb0e1cf5daa baseline version: linux deacdb3e3979979016fcd0ffd518c320a62ad166 Last test of basis 152332 2020-07-31 19:41:23 Z 397 days Failing since 152366 2020-08-01 20:49:34 Z 396 days 686 attempts Testing same since 164731 2021-09-02 00:11:48 Z 0 days 1 attempts ------------------------------------------------------------ 7128 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl fail test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl fail test-armhf-armhf-xl pass test-amd64-i386-xl fail test-amd64-coresched-i386-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm fail test-amd64-i386-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm fail test-amd64-i386-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine fail test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel fail test-amd64-i386-qemuu-rhel6hvm-intel fail test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair fail test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow fail test-arm64-arm64-xl-thunderx fail test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2174137 lines long.) From xen-devel-bounces@lists.xenproject.org Thu Sep 02 09:12:17 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 09:12:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177192.322471 (Exim 4.92) (envelope-from ) id 1mLilY-000083-My; Thu, 02 Sep 2021 09:12:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177192.322471; Thu, 02 Sep 2021 09:12:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLilY-00007w-Jd; Thu, 02 Sep 2021 09:12:12 +0000 Received: by outflank-mailman (input) for mailman id 177192; Thu, 02 Sep 2021 09:12:11 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLilX-00007p-L9 for xen-devel@lists.xen.org; Thu, 02 Sep 2021 09:12:11 +0000 Received: from us-smtp-delivery-124.mimecast.com (unknown [216.205.24.124]) by us1-rack-iad1.inumbo.com (Halon) with ESMTP id 2a1271a1-7667-42ff-ad86-b09dcbcb361b; Thu, 02 Sep 2021 09:12:10 +0000 (UTC) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-483-b6o_pRY-Nx-21DG1pghVNQ-1; Thu, 02 Sep 2021 05:12:06 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id AE1DD1005D70; Thu, 2 Sep 2021 09:12:02 +0000 (UTC) Received: from localhost (unknown [10.39.194.169]) by smtp.corp.redhat.com (Postfix) with ESMTP id C51215C3DF; Thu, 2 Sep 2021 09:12:01 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2a1271a1-7667-42ff-ad86-b09dcbcb361b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1630573929; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=kF1K6NnmCiy6sVyUFnUfFMOScUNqa4i7qai+pdkjbOE=; b=PCm2Ip3UzPjOf90TT1Uy6L1zPDrWkozzkKvlArryuXu3+uUNq5Ounk7TOtnJT3ZLqkWOY2 98+LYPfqhvdDK2XV/Dwam+SwbUVAdHvjhDbIMt3Le7zJGz1Ss3ozNyGIvoEBLIqSTShZQ9 0iX1IjWiAQsPanhjSh1heS0NBWqKQCE= X-MC-Unique: b6o_pRY-Nx-21DG1pghVNQ-1 Date: Thu, 2 Sep 2021 10:12:00 +0100 From: Stefan Hajnoczi To: Alex =?iso-8859-1?Q?Benn=E9e?= Cc: Stefano Stabellini , Stratos Mailing List , virtio-dev@lists.oasis-open.org, Arnd Bergmann , Viresh Kumar , AKASHI Takahiro , Stefano Stabellini , Jan Kiszka , Carl van Schaik , pratikp@quicinc.com, Srivatsa Vaddagiri , Jean-Philippe Brucker , Mathieu Poirier , Wei.Chen@arm.com, olekstysh@gmail.com, Oleksandr_Tyshchenko@epam.com, Bertrand.Marquis@arm.com, Artem_Mygaiev@epam.com, julien@xen.org, jgross@suse.com, paul@xen.org, xen-devel@lists.xen.org, Elena Afanasova Subject: Re: Enabling hypervisor agnosticism for VirtIO backends Message-ID: References: <87v94ldrqq.fsf@linaro.org> <875yvkh1p1.fsf@linaro.org> MIME-Version: 1.0 In-Reply-To: <875yvkh1p1.fsf@linaro.org> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=stefanha@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="wqq+Rojkn7jctvdi" Content-Disposition: inline --wqq+Rojkn7jctvdi Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Sep 01, 2021 at 01:53:34PM +0100, Alex Benn=E9e wrote: >=20 > Stefan Hajnoczi writes: >=20 > > [[PGP Signed Part:Undecided]] > > On Wed, Aug 04, 2021 at 12:20:01PM -0700, Stefano Stabellini wrote: > >> > Could we consider the kernel internally converting IOREQ messages fr= om > >> > the Xen hypervisor to eventfd events? Would this scale with other ke= rnel > >> > hypercall interfaces? > >> >=20 > >> > So any thoughts on what directions are worth experimenting with? > >> =20 > >> One option we should consider is for each backend to connect to Xen vi= a > >> the IOREQ interface. We could generalize the IOREQ interface and make = it > >> hypervisor agnostic. The interface is really trivial and easy to add. > >> The only Xen-specific part is the notification mechanism, which is an > >> event channel. If we replaced the event channel with something else th= e > >> interface would be generic. See: > >> https://gitlab.com/xen-project/xen/-/blob/staging/xen/include/public/h= vm/ioreq.h#L52 > > > > There have been experiments with something kind of similar in KVM > > recently (see struct ioregionfd_cmd): > > https://lore.kernel.org/kvm/dad3d025bcf15ece11d9df0ff685e8ab0a4f2edd.16= 13828727.git.eafanasova@gmail.com/ >=20 > Reading the cover letter was very useful in showing how this provides a > separate channel for signalling IO events to userspace instead of using > the normal type-2 vmexit type event. I wonder how deeply tied the > userspace facing side of this is to KVM? Could it provide a common FD > type interface to IOREQ? I wondered this too after reading Stefano's link to Xen's ioreq. They seem to be quite similar. ioregionfd is closer to have PIO/MMIO vmexits are handled in KVM while I guess ioreq is closer to how Xen handles them, but those are small details. It may be possible to use the ioreq struct instead of ioregionfd in KVM, but I haven't checked each field. > As I understand IOREQ this is currently a direct communication between > userspace and the hypervisor using the existing Xen message bus. My > worry would be that by adding knowledge of what the underlying > hypervisor is we'd end up with excess complexity in the kernel. For one > thing we certainly wouldn't want an API version dependency on the kernel > to understand which version of the Xen hypervisor it was running on. >=20 > >> There is also another problem. IOREQ is probably not be the only > >> interface needed. Have a look at > >> https://marc.info/?l=3Dxen-devel&m=3D162373754705233&w=3D2. Don't we a= lso need > >> an interface for the backend to inject interrupts into the frontend? A= nd > >> if the backend requires dynamic memory mappings of frontend pages, the= n > >> we would also need an interface to map/unmap domU pages. > >>=20 > >> These interfaces are a lot more problematic than IOREQ: IOREQ is tiny > >> and self-contained. It is easy to add anywhere. A new interface to > >> inject interrupts or map pages is more difficult to manage because it > >> would require changes scattered across the various emulators. > > > > Something like ioreq is indeed necessary to implement arbitrary devices= , > > but if you are willing to restrict yourself to VIRTIO then other > > interfaces are possible too because the VIRTIO device model is differen= t > > from the general purpose x86 PIO/MMIO that Xen's ioreq seems to > > support. >=20 > It's true our focus is just VirtIO which does support alternative > transport options however most implementations seem to be targeting > virtio-mmio for it's relative simplicity and understood semantics > (modulo a desire for MSI to reduce round trip latency handling > signalling). Okay. Stefan --wqq+Rojkn7jctvdi Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhpWov9P5fNqsNXdanKSrs4Grc8gFAmEwlWAACgkQnKSrs4Gr c8iywwf/UbbZqAAwRx5aV+yxn3NfXRbvDky1X190RHTAps3WhO8yK2JbKJD8iKbQ rshIvCjdE8gtVEBLo1T+73NCbrLFablTajILJ6OZXpKvUb2Q4xp2v2fowVz49ggv 07MKYC7J+AkIXEIxZ5vocByUaaF150FWIyU8Anb5GDLnF7BVFXF1mM0iqtgELgS7 0/UOVvjXSs63QNWRqIkGNuCsb9E7+cD9Rnn805nrwxi3A1Mr2qJXprgDHOIdc8DZ GfH+4OCe2sfLjXDg8UD586JC81vR1MR/8XDS7Ojv1/WOwZFvcpboOHp/WBxaxOLU 1VbgmtZyWDa51CFJZBkzq+DRQe8aEw== =LPa3 -----END PGP SIGNATURE----- --wqq+Rojkn7jctvdi-- From xen-devel-bounces@lists.xenproject.org Thu Sep 02 09:57:05 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 09:57:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177202.322488 (Exim 4.92) (envelope-from ) id 1mLjSk-0005X1-AL; Thu, 02 Sep 2021 09:56:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177202.322488; Thu, 02 Sep 2021 09:56:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLjSk-0005Wu-6q; Thu, 02 Sep 2021 09:56:50 +0000 Received: by outflank-mailman (input) for mailman id 177202; Thu, 02 Sep 2021 09:56:48 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLjSi-0005Wl-F0 for xen-devel@lists.xenproject.org; Thu, 02 Sep 2021 09:56:48 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id e37a3955-8d92-44b4-85b9-c9d90503737a; Thu, 02 Sep 2021 09:56:46 +0000 (UTC) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04lp2054.outbound.protection.outlook.com [104.47.13.54]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-33-5S3dmyduOmedLylCb4vH8w-1; Thu, 02 Sep 2021 11:56:44 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VE1PR04MB6480.eurprd04.prod.outlook.com (2603:10a6:803:11d::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19; Thu, 2 Sep 2021 09:56:39 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4478.021; Thu, 2 Sep 2021 09:56:39 +0000 Received: from [10.156.60.236] (37.24.206.209) by AM0PR02CA0192.eurprd02.prod.outlook.com (2603:10a6:20b:28e::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Thu, 2 Sep 2021 09:56:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e37a3955-8d92-44b4-85b9-c9d90503737a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1630576605; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vgtEOi+Tk+N1Qhq1ZjjXcboumpOXjoDLgESCBpFZp68=; b=eC9Lau+U+rDtM+tkCWN/Rqh3kSuqC14DFGAo2R2zVOPsMHzIQAgXeAECHZQvhK/AjFfdKr lsQRpWqeFQ3EZJgf1ZOlq7OrIknfOkAFIbVSmeVIem3jc8xYjT0GbyBgr6aL8yrnC5/NSO L2kDKGMXcNIu4gtWPyiR4/NCQiKYP8o= X-MC-Unique: 5S3dmyduOmedLylCb4vH8w-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DphjXKh/tuw+Tw+JeXFFe+06FkWazd/Hb6rKuH8qQZY7gObzhmlvNB8oJkzs6wx+xpq5/6f6dIYiAM6ZBv5QrL4GcAvTguGWMKxIkez4FEizSLoykWy1EJDqZsbHKRbmXdbBVK8BYid+J4WIKzMcb7TkRj3KK3+MjZPUJXORURdsCTF1RAY2zOMo1eb/3O0kBhA5yFvJGclwkhGAgSlmE3SZRIi3EId3jiXo5tkXyh/rVufLaHglK7Hw+ImqI/3i8zSQCCOmGCgPk2sV2VXT3q9rEXAjoFOLeQFnD+ze9Wa6xKXneTOREMtwDWLz9lN/6scGR+eALsaoKyOGk+Ycig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=vgtEOi+Tk+N1Qhq1ZjjXcboumpOXjoDLgESCBpFZp68=; b=bjqUCXNF+C5eHhPK7u5tG0SbwsPcL4z5LJ7ozNCnIqL7VgpW9TBON1HL4+hQSxf2t7k9mr7vQZYEXKbysuHkdTJH65pWuXqrer7C2ZoowJAJzCpI5OgYsOzzwLZ69YT+DsFD2Hle2nbtsFgofIIZNTNyHWBmb8GLxOAGbGxfbJQi654GB0Wr/Qt9unJQlzTGDy1YUWyH9K1RowkanTK47b3ix4Ic83ryMAJAn4B44bD08WT3ej/BwS/qYq+9B7/Nf1uYSfQ78BsrcGmCzZH6eeSlcEh6lSYMySHiAvssx73QOehzl9KLF7cn5Id2qMpzKRn8aOlZUtdryeD5DLUK1A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com; Subject: Re: [PATCH] Grab the EFI System Reference Table and check it To: Demi Marie Obenour Cc: Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Ian Jackson , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , xen-devel@lists.xenproject.org References: From: Jan Beulich Message-ID: Date: Thu, 2 Sep 2021 11:56:36 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM0PR02CA0192.eurprd02.prod.outlook.com (2603:10a6:20b:28e::29) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 73c167e8-17b4-4a2a-1237-08d96df7f5a2 X-MS-TrafficTypeDiagnostic: VE1PR04MB6480: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2733; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: PwSnTndDfRlEZSTHreSGL1vE/F5g7LaFIDdN1yXDC+fHdV+TCWuz0z4xlu9sGIqlFwWuGwb/astUy0TtKPWgsmlYw8nHSu78teev3fvsIfcKrpS7ZUCRB3uvjN1mO24wASf4X9JKt0MiC+QICpjn4g5jv6K1Mza2YFZDXZbGfV+8whdeimNhWdYfM5594lJ2BU6Ou8AQ09987Rfv/tgAAGFip+OtqpAyiK9xgIW6pbC3GBvAMbGwdqMKGPK0D9obYcHOJD0qMaPULgZ9OIQNcjU3thIduV6kQo0J4+hd6B4dDIw4rDPoEZXmB2nl6Tz2NEA4ia6JeqebldPNl2gAufgb2q9WfzPnCtGgDBFZHZ1pvBtHT9xZX/EyfbGAu7yFm4w+P4VdkiBGWdmvKye3fW74+7Nh1laj/lWYKZBwza2jT497Ay/7yCG7c8ZGslPBFCAkSmWcqJT4SuTpJ2QQDDFMvh/IHUbR2S+QQnHiqHx1QP7+tjqLt5S1fuyDSatD+vg4kQTNfbgCf6/83YNcxNk3wYlNaxx6mJX0wcWE/dN5FcRVeLPlOObtOSa7wnrffIBnxjH4OUuu4QK5cUWUr86vG1qefyf8u+8OFOyp5YGbMPM3iA4M6kJwdfLhVGl+7/3fIX50/GD/avkPiui56Ud0zhCEmrlVhAsNMLycgy8f+eiAMPxWmMusdV/sa1SD8swf901HTqb6G1tOK7dwDLFkXwP6vXTLa+aF2mA5pxg= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(39860400002)(346002)(136003)(396003)(366004)(376002)(54906003)(53546011)(2616005)(16576012)(31686004)(316002)(956004)(86362001)(8936002)(186003)(31696002)(36756003)(38100700002)(8676002)(2906002)(83380400001)(6486002)(5660300002)(66946007)(66556008)(66476007)(6916009)(7416002)(478600001)(4326008)(26005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?Windows-1252?Q?Vg5sufvTDInRUQKy3fm5myKiOVueIk5seUpjp+vk7zthd9aYSTfCl4K8?= =?Windows-1252?Q?EUD3civvNXl7PjEQCj7LQXigP+8qKzrz8ansQUqcDYoKl8fpx9MbF8Je?= =?Windows-1252?Q?S8dTe0ziPHBJRzGkYsjkSLvEwBTZdhzYNMlC33eOGgFOwavektjNugXy?= =?Windows-1252?Q?DX3l9F2sh1G/MH4MhQUojZHy1E1g26EgIe644PjcaJrFg14XYE/dDEnC?= =?Windows-1252?Q?LqdS2zHJVrMC2ynPQm1hDLzVCITIJp4XjS0bcrFnD6fBCmFLYJcKB7/a?= =?Windows-1252?Q?5lvKoTtI8GHPQfqjhRhNRycG44Up501ulCJuvhK7kd8OtMTuuzEgU5gp?= =?Windows-1252?Q?V2UtQm9TShHfWAEFDpb6+xG19XCuOOctnxNe5nrMv0PIV5ihUDOFXDVw?= =?Windows-1252?Q?R68Bww0Sx8qBPdxD0TqzbZGVH3haOm6/jqkWzZrhKZyBaHoYzOPVoJA5?= =?Windows-1252?Q?VQ1z9iRDoThEx/ghPERq8zW4ExuttbAzLSRz6NphoYpLjRwUj4Zq2inQ?= =?Windows-1252?Q?bZsZarP3bdXqhkuoUQKTW7cfZ78Q3qokW6+QdS5ZBUkuoGsSKVM5B7Ai?= =?Windows-1252?Q?P2m5e8ldgdbQ+oHZcszFeMddAqFHo6RlPZRsBQqDSzpaJZ3u3rG+lQAk?= =?Windows-1252?Q?+p1JQ81Nt3cJ0W8DvQbkLSVlSGNXBOeTHimOWYV2al5iDeV6u7oVhtea?= =?Windows-1252?Q?1sxgoDF4cMYAwJP9zBlpIffnYC4GDa/uof1g03riroyvHnyW/6nA6uHr?= =?Windows-1252?Q?9x9cmzri9DbDMLHjES2B2cRjhW0PWuACP5jlr/unSHxnrwxJu6BRyxAX?= =?Windows-1252?Q?Oy7mBxvQEEScJO0/nJZVQH9z6OGho8jH47O0einJMul+YNz+kzJ1R2DI?= =?Windows-1252?Q?roJgF0rIMn+rWy9Tq2SL8H2hhQWqth4DrVAyZF7DMt6ZAFtuLFxVJC7T?= =?Windows-1252?Q?T5ueHSkMkHby3lWztFN9G91rPRUvONuo5H4pWXXMihfHYPr0c+71LKRS?= =?Windows-1252?Q?CNUU15EeOsY4CTna++lLh+p9Ho6bKgQcfteJBRyYYUCOxtuUoQ5gifhK?= =?Windows-1252?Q?8hdQJRWpvRJDa7N5fmKVUflUny89k6rgwtCg7In5gZSDP0lDmyMD4Zn6?= =?Windows-1252?Q?TYeugOGyI334vnwJmKyvaHRoMgCDhG6RJePIcKYyz9UG73cMmDhn+SUC?= =?Windows-1252?Q?BAZZ9eGvnauLVm24NNw4Sf3W74SBWPEKypjOBwcFAdqvFwbwWZqztHfq?= =?Windows-1252?Q?yO16S97MkgCK+armTkgeG89PEGsDcDXfsbHdyYA8I09vWMXCeMVqLSOq?= =?Windows-1252?Q?ywFpivYCKn2GAsWgVjXM/nWrWCzvIOXHwGt8ylCv5t6uRRb3ocGv8Esb?= =?Windows-1252?Q?Q55+dt6V43QbSOaQBGBFhWlKhEQfLc/NMliOI+xtQ6f6QYCZhkqdWakG?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 73c167e8-17b4-4a2a-1237-08d96df7f5a2 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Sep 2021 09:56:39.6444 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 76jU/swXVLyo8tN/JEWV/8Kguexxaxw/HhshhM54VOsXl380TX+Z8P664cD4ROIqGyszd/Skv9LugAMB36JXTA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6480 On 29.08.2021 14:18, Demi Marie Obenour wrote: > The EFI System Reference Table (ESRT) is necessary for fwupd to identify To properly match the UEFI spec, both here and in the subject I suppose you mean "Resource" instead of "Reference"? > @@ -171,7 +172,7 @@ static void __init efi_arch_process_memory_map(EFI_SYSTEM_TABLE *SystemTable, > { > case EfiBootServicesCode: > case EfiBootServicesData: > - if ( map_bs ) > + if ( map_bs || desc == esrt_desc ) > { > default: > type = E820_RESERVED; Elsewhere you also permit ESRT to live in EfiRuntimeServicesData. The code addition here looks to contradict that. Furthermore you're potentially making a large chunk of data unavailable just because it contains a small piece of data which needs to be preserved. > --- a/xen/common/efi/boot.c > +++ b/xen/common/efi/boot.c > @@ -93,6 +93,23 @@ typedef struct _EFI_LOAD_OPTION { > CHAR16 Description[]; > } EFI_LOAD_OPTION; > > +struct esrt_entry { > + EFI_GUID fw_class; > + uint32_t fw_type; > + uint32_t fw_version; > + uint32_t fw_lowest_supported_version; > + uint32_t fw_capsule_flags; > + uint32_t fw_last_attempt_version; > + uint32_t fw_last_attempt_status; > +}; > + > +struct esrt { > + uint32_t esrt_count; > + uint32_t esrt_max; > + uint64_t esrt_version; > + struct esrt_entry esrt_entries[]; > +}; These don't match the gnu-efi style (where we're generally taking pieces from), but since I can't spot that package supporting ESRT at all, we have to roll our own, so the style inconsistency is perhaps okay. But at least - alongside EFI_GUID - I think you want to use EFI types (UINT). > @@ -166,6 +183,41 @@ static void __init PrintErr(const CHAR16 *s) > StdErr->OutputString(StdErr, (CHAR16 *)s ); > } > > +enum esrt_status { > + ESRT_NOTFOUND = 0, > + ESRT_GOOD, > + ESRT_BAD, > +}; I think we generally try to limit all-caps identifiers to macros. > +static enum esrt_status __init is_esrt_valid( > + const EFI_MEMORY_DESCRIPTOR *const desc) { Style nit: Brace goes on it own line. > + size_t available_len, esrt_len, len; > + const uintptr_t physical_start = desc->PhysicalStart; > + const uintptr_t esrt = efi.esrt; Like said above and to match other code in this file, EFI types (UINTN in particular) should be preferred. > + const struct esrt *esrt_ptr; > + > + len = desc->NumberOfPages << EFI_PAGE_SHIFT; > + if ( esrt == EFI_INVALID_TABLE_ADDR ) > + return ESRT_BAD; I think this is rather ESRT_NOTFOUND, too? But see also below. > + if ( physical_start > esrt || esrt - physical_start >= len ) > + return ESRT_NOTFOUND; > + if ( ! ( desc->Attribute & EFI_MEMORY_RUNTIME ) && > + ( desc->Type != EfiRuntimeServicesData ) && > + ( desc->Type != EfiBootServicesData ) ) As you say in the description, the spec mandates the latter. I can accept you also wanting to cover other plausible types, but then please add a brief comment mentioning the intentional diverging from what the spec says. This would then hopefully also clarify the curious redundancy between checking EFI_MEMORY_RUNTIME and EfiRuntimeServicesData. As to style - there are quite a few too many blanks here. > + return ESRT_BAD; > + available_len = len - (esrt - physical_start); > + if ( available_len < offsetof(struct esrt, esrt_entries) ) Iirc both gcc and clang allow sizeof(*estr_ptr) despite the flexible array member - please prefer that form (also again further down). > + return ESRT_BAD; > + esrt_ptr = (const struct esrt *) esrt; For this and the sizeof() below to be applicable, you need to check the version to be 1. Also, as to style, there's not supposed to be any blank after the closing parenthesis. > + if ( esrt_ptr->esrt_count <= 0 || > + __builtin_mul_overflow(esrt_ptr->esrt_count, > + sizeof(struct esrt_entry), sizeof(esrt_ptr->esrt_entries[0]) or alike please. Also - is __builtin_mul_overflow() supported by all gcc versions we support building this code with? And is this overflow check needed in the first place? After all we build EFI code only for 64-bit hypervisors, and a 32-bit quantity times the sizeof() can't overflow in 64 bits. > + &esrt_len) || > + esrt_len > available_len - offsetof(struct esrt, esrt_entries) ) > + return ESRT_BAD; > + return ESRT_GOOD; > +} Style nit: Please put a blank line ahead of the function's main "return" statement. > @@ -835,6 +887,10 @@ static void __init efi_tables(void) > { > unsigned int i; > > + BUILD_BUG_ON(sizeof(struct esrt_entry) != 40); > + BUILD_BUG_ON(_Alignof(struct esrt_entry) != 4); > + BUILD_BUG_ON(offsetof(struct esrt, esrt_entries) != 16); Why? We're not doing this for other types declared locally in this source file afaics. Plus - did you check that all gcc versions we support for building this code can actually deal with the C99 _Alignof()? I would generally have expected you to use __alignof(), as we do elsewhere. > @@ -1042,9 +1101,7 @@ static void __init efi_exit_boot(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE *Syste > EFI_STATUS status; > UINTN info_size = 0, map_key; > bool retry; > -#ifdef CONFIG_EFI_SET_VIRTUAL_ADDRESS_MAP > unsigned int i; > -#endif > > efi_bs->GetMemoryMap(&info_size, NULL, &map_key, > &efi_mdesc_size, &mdesc_ver); > @@ -1055,6 +1112,10 @@ static void __init efi_exit_boot(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE *Syste > > for ( retry = false; ; retry = true ) > { > + enum esrt_status esrt_status = ESRT_NOTFOUND; > + const EFI_MEMORY_DESCRIPTOR *esrt_desc = > + (const EFI_MEMORY_DESCRIPTOR*) EFI_INVALID_TABLE_ADDR; Style: Misplaced blank. > @@ -1063,8 +1124,31 @@ static void __init efi_exit_boot(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE *Syste > if ( EFI_ERROR(status) ) > PrintErrMesg(L"Cannot obtain memory map", status); > > + for ( i = 0; i < efi_memmap_size; i += efi_mdesc_size ) > + { > + EFI_MEMORY_DESCRIPTOR *desc = efi_memmap + i; > + switch ( is_esrt_valid(desc) ) Style: Blank line please between declaration(s) and statement(s). I question the need for the local variable though - you only need it ... > + { > + case ESRT_NOTFOUND: > + break; > + case ESRT_GOOD: > + esrt_status = ESRT_GOOD; > + esrt_desc = desc; ... here. > + break; > + case ESRT_BAD: > + esrt_status = ESRT_BAD; > + break; > + } > + } > + if ( esrt_status != ESRT_GOOD ) > + efi.esrt = EFI_INVALID_TABLE_ADDR; In the end you don't distinguish ESRT_BAD from ESRT_NOTFOUND, so I don't see the need for the enum. The function can simply return bool then. > + /* > + * We cannot pass efi.esrt because we need to explicitly compare the > + * descriptor pointers for equality. > + */ > efi_arch_process_memory_map(SystemTable, efi_memmap, efi_memmap_size, > - efi_mdesc_size, mdesc_ver); > + efi_mdesc_size, mdesc_ver, esrt_desc); I'm not convinced this is "need" (as the comment says), but at best "want", for being an implementation choice. But the model itself is suspect to me in the first place, as said above. > --- a/xen/include/xen/efi.h > +++ b/xen/include/xen/efi.h > @@ -19,6 +19,7 @@ struct efi { > unsigned long acpi20; /* ACPI table (ACPI 2.0) */ > unsigned long smbios; /* SM BIOS table */ > unsigned long smbios3; /* SMBIOS v3 table */ > + unsigned long esrt; /* EFI System Reference Table */ > }; I have to admit that I'm having difficulty spotting why this field needs adding here: No other component in Xen wants to use it. Yet that's what the struct is for. Jan From xen-devel-bounces@lists.xenproject.org Thu Sep 02 10:09:18 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 10:09:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177209.322499 (Exim 4.92) (envelope-from ) id 1mLjec-0007XW-CB; Thu, 02 Sep 2021 10:09:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177209.322499; Thu, 02 Sep 2021 10:09:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLjec-0007XP-8Y; Thu, 02 Sep 2021 10:09:06 +0000 Received: by outflank-mailman (input) for mailman id 177209; Thu, 02 Sep 2021 10:09:05 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLjeb-0007XJ-KY for xen-devel@lists.xenproject.org; Thu, 02 Sep 2021 10:09:05 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 3b460bf3-d7f4-4a85-8e74-5a068b0940e0; Thu, 02 Sep 2021 10:09:04 +0000 (UTC) Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-ve1eur02lp2052.outbound.protection.outlook.com [104.47.6.52]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-10-1w7TI-zcNQWOKAlYaIRzgQ-1; Thu, 02 Sep 2021 12:09:02 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR0401MB2605.eurprd04.prod.outlook.com (2603:10a6:800:57::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.20; Thu, 2 Sep 2021 10:09:01 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4478.021; Thu, 2 Sep 2021 10:09:01 +0000 Received: from [10.156.60.236] (37.24.206.209) by PR1P264CA0008.FRAP264.PROD.OUTLOOK.COM (2603:10a6:102:19e::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.20 via Frontend Transport; Thu, 2 Sep 2021 10:09:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3b460bf3-d7f4-4a85-8e74-5a068b0940e0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1630577343; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9yxvLHW7DrlOt3aGmZBGtc6h5E1gB+AHZW+4J/6Z/sQ=; b=Zgl9xpmYjbqXHET/JW1W6JRCm9RpG9smaBaLXKfoCX2ubxjnJ1fgFI2omVTSxMSSJC/xIT Svgmt7S1PuPe54FfjaImFp9ZuVbD5hWWeh0D0wW8ZpoYN/FtuG7MJk3FjVLuI0X4+F4J2B oVwUJxhoR4aBm4tl8ZBW1nv06s4ZIEc= X-MC-Unique: 1w7TI-zcNQWOKAlYaIRzgQ-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YE3kKwatrUCoCXOglCwjuP8j/DwoQdsN5AQpaHp6x5JNm0bVrvI+8umQIsPmCs9Rw9AQjZ7EGifkEohiZCeX02SD+iYM70WFMyHfSoevDPrKpIAq9a0oiyhhDElTclNNgcbf54UbO+lGehCheW2IRDLYOaaCwV7EVpcaRHYx2BAAGrrRZviCYkjOnUJFPxHPLKqMHYklUpAhzsWY3cn1u+X7ViTTNwr0lbduK7A+wzLic05ZKBJzPQ/mjZkCh97SUHpCfgQkwmhDOEut0rSYgGO33RdVWeGlvg78XOsGZ/m6k5G04NKHJAg19AaHnXfZocaCSGpLwIT2CMd+1Ltb1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9yxvLHW7DrlOt3aGmZBGtc6h5E1gB+AHZW+4J/6Z/sQ=; b=XYc3Fza8SrSazbCb5uIgrFDMvUSw6QODoR0TQQulR1fvY4XJ2x1fN1xD0nTwD8adzlAm4kblSLKmhi5sxoLxj8TNPHdmshsSOdEw2ly64V4mOlxO3gPcQThi1vglUqac+QyT+6XIduiKHytlL44Do+ewW3tAToPWP770MNAwONJiCyxqgF/LAE9BFCEAiRJl6FY4tv/c1XyoMrFn3mGsfA0FMmQ2ViOHLSwwDknnBO3yPib3Z1FrUssf1Sa17+keYSAM1Wuj7A6r3KEctVxl2908VeiOE0hfSCQNyyhCbIrecOPNkw8tv+zqWc88VGMPU/s5/1WteEjoxHJykHg9sw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com; Subject: Re: [XEN PATCH v7 01/51] build: introduce cpp_flags macro To: Anthony PERARD Cc: Andrew Cooper , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Tim Deegan , xen-devel@lists.xenproject.org References: <20210824105038.1257926-1-anthony.perard@citrix.com> <20210824105038.1257926-2-anthony.perard@citrix.com> From: Jan Beulich Message-ID: Date: Thu, 2 Sep 2021 12:08:58 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: <20210824105038.1257926-2-anthony.perard@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PR1P264CA0008.FRAP264.PROD.OUTLOOK.COM (2603:10a6:102:19e::13) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 108c2e8b-c526-470e-b675-08d96df9afa5 X-MS-TrafficTypeDiagnostic: VI1PR0401MB2605: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2043; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: d+30HUtBcErhi5zzCKeaK66+xLt/mMlwF92UDt1wXWKN07pCI8WqWRBs39k/yeWjYo8wpaadHJ84zlwmX35ioUvaSNMwa5DKVZAjJIKT7fxvvyVIJKaM/nHyO0sDAtAMaG1Kz4IPiwVa2sXVKxwyMqcuoD7qDpcZid9gcoNF75O6c0Max72Gopda9bVVaHJOeGdstA5DqKe2yLPP0+p+Z9hL7s0QzyFM/m8ru9k56+mt/KhLV8BEjJyYFoEYlFuZDdbwzchKjXePa8QG++7ONDuaw33he4lYYC5yECdcjaWDot2Qydph5TJW0Z4U+wP5vx+o179HfyL+OqxU3h2kwYX8ql1oZ8brwwdnZ+G3Slo/p13b439V45H0Kni59tooy19mJWCi3MxTvNExGloah4Py2dtoWYyB73BWn7dHqC0mVNgHUpMGd7zPJcaffulZMLDjr8yRnjs1WiqfOxGW8GxdO+voifx13D6NG5TxQMlcJXPNLQO+7GMQTcXN1bgszYEAbj8UA13/aESwbKK8dI4ziCMya7FMWItmMa9QhpoLQiZgLfseVxdcrLb+vxv/4K4a2AfoKkZHpNPIANGiACwmUWriRqLeSJkWfJUENGw983gJhcCiDecA2aJcasDjkIAEWRuQHuZOto+rs1Q4868jbjsI0pDIbltvvpVa1erZkjbtA0WlNheQcA5DeYYmpq12HrJpj1Tb5DCCD9jqNDjpxuQVJYx2HDUA8ItPiEg= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(346002)(396003)(366004)(376002)(39860400002)(136003)(6916009)(31686004)(54906003)(86362001)(26005)(478600001)(6486002)(66946007)(66556008)(53546011)(186003)(66476007)(31696002)(5660300002)(4326008)(7416002)(36756003)(8676002)(956004)(38100700002)(2616005)(2906002)(16576012)(8936002)(316002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N3lTNEF6SHprZXMrOW9vL0xiWFI1TXVWVGY3VEZlODE3UlhQUTdCQStvRTVU?= =?utf-8?B?bjB4U0hZMmRFY2ZZb3dBbHdHUXRtdHpLSDJxajZ0YnlTdDRiZStjSGJpeGFu?= =?utf-8?B?bGs5MVBDZ2RYUVB6WGpSWWcrQkZldU1KdysvcXlwbjcvK25teVB5VE5paU12?= =?utf-8?B?NXBoT2R3YUxQY25PUzVralA5a3gyNW1oRWV1NUxqcGxERFJKclpiVWVNWG5p?= =?utf-8?B?TUtyS09SMkN0OExZeU5HeEIxMTVKeUFJeVluQ2JyeVRTdFdtdFJ1OXRRZEdU?= =?utf-8?B?RThZSTVDeEMvWXFhNDJDNCt6RmNrckg1VFhGRzJkazB3Wk53NXZnQjkya1ZG?= =?utf-8?B?WElITWZkZ25YRTJBaWNkY2N1emJqUS9FN0s5OWtMeGVvWHh2Qmh3WVEyNExn?= =?utf-8?B?TmVsbHFxb3FIcmxCNmtSVUowYm9NVFQrRDF5ZTkxdStaOWdPdVJkSEp0THJR?= =?utf-8?B?YjhIdmVCL0dwN0ZpeGR3US80a1NpVXpESFRSdzRYMU1JT2NTSjcxL3BzSnZ5?= =?utf-8?B?Qk1tbC9iSE5TWVlwMEpXUEd4dHZoTWNYb0VWOWk5b1VKblhIRDIvR3JBUXJ6?= =?utf-8?B?ZXNPQ1hmR0huQjFkb0YvZ21UVmtIZlV1NUpoek15eGtBMWYxaWgrbk9WTHhN?= =?utf-8?B?U3VnWjFESEpLUGE0VUdkMFFDUWlEQkNySXBNVEZNR2kxZ0dXelh1Rm5admhi?= =?utf-8?B?N2Nuak9iWWRsR095TmVQRE9yOWh2RkFLaXU4dHEzQzRJWFpFbnFERUd3NVR6?= =?utf-8?B?b0MzMkFyOG1YTlNmcWtqWVhYb2RyeGxHOS9PSDR1QiszNTYyS2w4S3lDWCtC?= =?utf-8?B?dVhlV2pZWnV2M01qSW0vUi9ncy9UQTE0U0U0WHc5T2dCMndXZ1AyYjZqQk5M?= =?utf-8?B?WUV5MzQzV01pTVI4RCt0cTkwZG9LU3dYamNYalFsVjNkV05sVFdUUEpXTlF2?= =?utf-8?B?OXpFNWFxd3hGTkErMlNuZUJMUDIxa3Q0ZUEyVksyMlFvdGRoTnpXQkFRWTNQ?= =?utf-8?B?NUQrcGtGdE9BbXliUVY5WHFBUEI5WXJFaFdVaFJUT0tiWjdEN0ptTlJkV0lu?= =?utf-8?B?YUVYM1JnMXNHdXNxcjAzVk01ak9NU0hHQnJZR0U5TWN1YjBBSWlFcDZ6ZlJy?= =?utf-8?B?ZTNkZTdpNGdWRVFweG4wOXo1UmdxT0RyY0hZTjBZMnY3RVovOWtlTlRuOGo4?= =?utf-8?B?cFZsWlVpR1Z5cmxIUUZlUE15YysyN3FWSFlwQzZkTVpoMDBEMkRLVzFUbEt6?= =?utf-8?B?RFJDdWpUbWpOVlRRNThqc3NOUms2VnZGbjZlMFpnR1R0RlZGSXNaeVlXc3lK?= =?utf-8?B?MitvOThCSjBONmNHMW5zMUhVZktEZHRXUDhETGJUM2hURmNZU08yRXRLdkl5?= =?utf-8?B?cUlFT2Q1dUhoOHoyOG1JQ1FkL0pMQXF2SHJnMzk2WDRIY0M2WGI1ZWU0Y1BW?= =?utf-8?B?YzZCclQyUDVPcGt1N21ZaFF4bCtOZGRWOVYwN29sZzYraDFGMDdteTZiZ3R4?= =?utf-8?B?eDVNSlNOTFovRElBU1VQb2ZHOXdOWStneHhuWjV5T0lZRWh1WDFmYWhwMmNP?= =?utf-8?B?YmExUlk1RFZGRzZOYzZMSTYrTUF3MElPZEpDWUgyYTZoaEJQSXNyVUhSV3k2?= =?utf-8?B?TmZ6U0dCN0hUbGxqcENDaWZYTTRvWHJLcmhYbkxDZ3lHVURmL3NteGpkeDZT?= =?utf-8?B?Q1ljUWtLbStFRzBQWGVsVm9RNXZaS3pjc0wrVjc5YnU4ai9SbmZoaU5NMHEr?= =?utf-8?Q?mTo6uhe/UDj4Xk6gYX3AzhYXDqf7yVXBwztvRsv?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 108c2e8b-c526-470e-b675-08d96df9afa5 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Sep 2021 10:09:01.1902 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: IRcsMZ+U8vy+B2jwfLlQl9282gxGOwKu5OHovyjj0eXQ+zr9NWp74UJe8d3DZZB51mxfNS8TD6CaBjAUkRAAPA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2605 On 24.08.2021 12:49, Anthony PERARD wrote: > Signed-off-by: Anthony PERARD Reviewed-by: Jan Beulich albeit with a remark: > --- a/xen/Rules.mk > +++ b/xen/Rules.mk > @@ -133,6 +133,9 @@ endif > # Always build obj-bin files as binary even if they come from C source. > $(obj-bin-y): XEN_CFLAGS := $(filter-out -flto,$(XEN_CFLAGS)) > > +# To be use with $(a_flags) or $(c_flags) to produce CPP flags > +cpp_flags = $(filter-out -Wa$(comma)% -flto,$(1)) Afaics this has nothing to do with Linux'es cpp_flags, so what we do here is entirely up to us. If this is strictly intended to be used the another macro, wouldn't it make sense to have cpp_flags = $(filter-out -Wa$(comma)% -flto,$($(1))) here and then e.g. ... > @@ -222,13 +225,13 @@ $(filter %.init.o,$(obj-y) $(obj-bin-y) $(extra-y)): %.init.o: %.o FORCE > $(call if_changed,obj_init_o) > > quiet_cmd_cpp_i_c = CPP $@ > -cmd_cpp_i_c = $(CPP) $(filter-out -Wa$(comma)%,$(c_flags)) -MQ $@ -o $@ $< > +cmd_cpp_i_c = $(CPP) $(call cpp_flags,$(c_flags)) -MQ $@ -o $@ $< ... the slightly simpler / easier to read cmd_cpp_i_c = $(CPP) $(call cpp_flags,c_flags) -MQ $@ -o $@ $< here? Jan From xen-devel-bounces@lists.xenproject.org Thu Sep 02 10:17:37 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 10:17:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177215.322509 (Exim 4.92) (envelope-from ) id 1mLjmm-0000gl-6f; Thu, 02 Sep 2021 10:17:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177215.322509; Thu, 02 Sep 2021 10:17:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLjmm-0000ge-3k; Thu, 02 Sep 2021 10:17:32 +0000 Received: by outflank-mailman (input) for mailman id 177215; Thu, 02 Sep 2021 10:17:30 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLjmk-0000gY-O2 for xen-devel@lists.xenproject.org; Thu, 02 Sep 2021 10:17:30 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 8d40e283-a67f-4ec0-a9ee-6d6ef7aba0df; Thu, 02 Sep 2021 10:17:29 +0000 (UTC) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04lp2052.outbound.protection.outlook.com [104.47.14.52]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-8-nJlk4btgPE6_MAMJj49RPg-1; Thu, 02 Sep 2021 12:17:27 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR0401MB2447.eurprd04.prod.outlook.com (2603:10a6:800:53::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19; Thu, 2 Sep 2021 10:17:26 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4478.021; Thu, 2 Sep 2021 10:17:26 +0000 Received: from [10.156.60.236] (37.24.206.209) by AM0PR04CA0041.eurprd04.prod.outlook.com (2603:10a6:208:1::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.17 via Frontend Transport; Thu, 2 Sep 2021 10:17:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8d40e283-a67f-4ec0-a9ee-6d6ef7aba0df DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1630577848; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lwOFmKTMA/e7SRGI2xHrMSVxtHkhekdm0cD8fSrNIQA=; b=iIY6eQghJnCL8z6dVx5wJKVWHxOXZqxv6dZkCBGhXuku/4z0eiKOF0+4drdJbzZ1a4edY6 c9AHdNvGMqtM+skEHpNg/LnFJsDHM9PT4lMJSXM+kHNo46sjxK1JDmpuZLsuJ4NhjqCq9W 170jhOMSaT5J5/R//gRt/SZRYa2Sysk= X-MC-Unique: nJlk4btgPE6_MAMJj49RPg-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=V7RlemlW1Qeb+inu6gcupbATM4QtP+OXD6SNIa5hSQnlaw5hlVSjSo45OYQHNuMQSqRVjhgwfRgAZVVQIqnf+sxd2dYCp/RSEVqIkw4AjDQmjpdDgvRlWfC9s7SVG80cP+wN9NmFA9OFyoR6NlHiPVCxZR91uT6dtmrUfQN6nJa4EGe6ckEYxsaprsv2i+2BeXjpCGwa3QaV0O//Dhoatki1wqefOygoqO9Lau2sB/ULxGG3Sl13YasXQQQqeKU/+I+nD6rl3leuEJVPLYyr9/KKUU++T+S23BM2fXC/SK9GV1E2Xw/HCxVva4VQhbTuQQ7t9x3wdZ547osrfPuSRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=lwOFmKTMA/e7SRGI2xHrMSVxtHkhekdm0cD8fSrNIQA=; b=TY+aLBGKiS2Fnry1kuMHmbimQGrxqBXLfVF26Wb/ZCftu/BjkijJdqv26iYZkW69m+7bMB8IF6rWPJUFtpY1ewZPGjIsB51ZM+dd1cfHgLVcojAO99om9KI1OVZ+p620lQztP7uyAbeg1SIVYdVxw3l7kO3V58Jrk+J8vyL8HYwsHcYv1fgEueamGH4HdTLjss7sXa74CDUFyn8eoSNVvUX6AesnWmlMgoJi6288j5NKdAKI9zw/uvvjIDlUgs7wkR2e/Ja6LHjrHTSV7DZrLqoWiXt2pbPh4LdYVP0DuECVAxJNBqM0lkqiLQvqLnRl2VqNeQA4N39dreoZrmVcqg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com; Subject: Re: [XEN PATCH v7 09/51] build: use subdir-y in test/Makefile To: Anthony PERARD Cc: Andrew Cooper , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20210824105038.1257926-1-anthony.perard@citrix.com> <20210824105038.1257926-10-anthony.perard@citrix.com> From: Jan Beulich Message-ID: Date: Thu, 2 Sep 2021 12:17:23 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: <20210824105038.1257926-10-anthony.perard@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM0PR04CA0041.eurprd04.prod.outlook.com (2603:10a6:208:1::18) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 41f397d4-c271-4e20-67df-08d96dfadc85 X-MS-TrafficTypeDiagnostic: VI1PR0401MB2447: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:506; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4d/4YNm4x7CiabuWhktC1I7t+CpJaWtNHjEsypw2yX68rU3ATMX1CBo4gi52lG+ZT+GDwCacthUDAW4joDOHnSHbrdsSlt2veCZK+RGSQPWwEnqOxh+MrYaeCUMQFq0q+sUMsn1tUs3Xx9wr/6t92v5KnO9AfpEr3qnK0PtoXjapxJBLCZZPHWzriZKcNbm7tHSWFHC3FgFDMbXDKMpbjfJ0T4w4tTKFjZXOd1RA6wA4xbT4P9o7hejfp/Em8lqDko7THYvJAvKtsS+1T/kM9wNVSB6eyM2CTuFMj39BHKs7Nh0XYElV41K7lKptCfeubEQnFTEzIoC62Dwf5e5yL0+kNEIAsusoZYjxtV5D9VhopW2zYZ2ubqwAopswzjjKaW3lTW5IWificx7lAEUZUEti2VL5fWYGRXhA1u2dhTsqSccq81gqF2uBAjRwl8C/1rqtZ/xehaxwiaADnNFdKE6iYJkzi5WN+eoT86zqKaOGFj6XQEWhusl9y3+5wAp/PaWuOsIiCPf5oPKAdqWYFm3oAcTFx9XlmdpdrJNUNMwpj8rdISQSkhxidMBCUUgbd2Fnvfbz5YmjJb2ygltvL5RJQUYwalIkID8OCBcUn2UMfq8n7b2z51ZQLQQQHQTlekwmxz0LQPvzswX+R2E/eNNug4xZ8Py4tv8sbyAkz9KcABccpV5KGFX8WMCdlFicyLEcR8tQTzTACczEP23kPfumDGmJe2Ivfg5Aesn8JUc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(376002)(136003)(366004)(39860400002)(396003)(346002)(6916009)(2906002)(4326008)(5660300002)(478600001)(36756003)(31696002)(31686004)(8676002)(38100700002)(54906003)(956004)(86362001)(2616005)(6486002)(8936002)(66946007)(66556008)(66476007)(316002)(16576012)(186003)(26005)(558084003)(53546011)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?S0owYXhtbDFvWGJIcTMwdmZwbFpwSFJmY2xUa0U5MjNQRTkrcUZrTDhEbkor?= =?utf-8?B?TXh0bUxvWnZiVjFkTk9lNWRZdVM3M0xrOGFySjQwbmVqUFpLSDJkZm9oN1Ny?= =?utf-8?B?YmNsTHRmZmEvUDB4Q013VXAyNWVpWjRCM2tTWGdSbGt2bVF1Z3AxYkErTjNr?= =?utf-8?B?cjFodE9XeXJ2N2hoelU4dkE1dWxwb0cyam1vOUpEWjJFODlUaVpUaG5PYWZw?= =?utf-8?B?M0Fad1hMa2FibWtCbHo1UnRqQlF6aEJzSjkwbjdmaDFCVXdDOTh6a3NnRlpL?= =?utf-8?B?NXRrU0M5NFg3YzNJT09CWUJudWhSLyt1MWRwM1VRUXd4bnVwditRYkk5cGZ1?= =?utf-8?B?K1ltZHo2ajFoMVN6ajdxUWx5VGxGQngzcG9RYmpzY1RUTlBaTlJVVFRjV1ho?= =?utf-8?B?aTJGcnNYMUVXMTJSM0dILy84WnFQTFpSaStiU3NxdGtXWTV3NEk4bVZid1J1?= =?utf-8?B?YW9TeHA0N3dqTEdMTGR2c1hSQnF4L0dFVDZ6STBEQTNRNzFGVHMraGxsdERq?= =?utf-8?B?dVoyWlpBdjF5d3JZa2dYUzlmMXBzQk02NjdXcDhTWHZpMnRmdk1DQmxZVWpv?= =?utf-8?B?QnJaNVNNRzV1SkYzS0ZoQkRNWFdQdm5tWVVRSmxEYjk0ek9HMlRWK1dXbC95?= =?utf-8?B?cURXd1dSSnE2K1RYS1JJWTRBWFlMMy9DRi81dGd3M2pJdTA4dG5OcStsQ1px?= =?utf-8?B?dFp0RjkwdnpqWWF6VnlHeFY0SWlhQWZUd2RISnlJSDA3eHJoaEFvN1JRQVFy?= =?utf-8?B?WUMwS0tHK1J2NzkrejZzY3lnOXVuS0RsL1NjSVVMNG1scjNyclRhUExBT3Qv?= =?utf-8?B?M2pVMDFCblhvNDFjVzV3N1NuOVR5cXhZK25WTjJkSUFMV2ZabWVBSFZNbkN4?= =?utf-8?B?d2QvNTE1ZmFPMXlpbDJYem5ZaW4zYWh0QUViTmJnNXV1eDByNnVlcUhqZXlS?= =?utf-8?B?VkxocFVQQTM0cXJLMjFObVgrYkl1NlQvRDBMSmNnTGlhTUsrQTlmRlpraTRl?= =?utf-8?B?VkxweTBhWVlqMVFhMDgzcHd2M1BTNXFvdXAxb0hORTk4QlBRekpNWDl0SnhZ?= =?utf-8?B?K044aVBKUEtwbkxhZjltTWlsUkwzQk8vMDdIaVJWbWFEMExobmxPWTdJQUM0?= =?utf-8?B?WFpsVlduNUdWL1lxaEVQa2lSOUE5WnBDZ1NETXJSK20zTnN5VUpJV0I2NWpH?= =?utf-8?B?dzBDdG55M0tqZzN2ZWVBZ3YvNG9TalRBRERSYWZHVW9xcHZDUmdJbUt5cXRy?= =?utf-8?B?TkZBaW9VTnlLOFR5ZjNvb1JEU01UclRyZ2lFcG5vUllIK1E2L3NHeVgxWG5x?= =?utf-8?B?V1RqWTFiMDc0OXl1NFM4eVdPRG9wVC90Y2VkMVBIdjRVc0JXWG1KSXJhNWt4?= =?utf-8?B?SVl2eGU4d2Fxdk9uN3NaWXRKczNOS2Z0UDBDbUYxWmU3a2NBUzNzd0NNZHZN?= =?utf-8?B?SzBFVFJpRktuR3RDR2RpUDFYQzJGTzR0di9SNG1wQVMySityTHB5ZkZmUGFw?= =?utf-8?B?NXhjSzJJallLVlNPQ21oTm0vU2VJRGpiNlhCNUdzdUJYYlBxWXpScTZlMk9s?= =?utf-8?B?ZmlrN1pkZnFiNDhJTWIwYnFGb3hVRmV4cW5YS2pmRmIzMW5vb2pXK0tSV0Q2?= =?utf-8?B?dUhPdjZ3NDBoTXhibmwycmZ0THFWTjB0ZVByLzJBdVVrYmkyTVJwbTI0ZWNz?= =?utf-8?B?UU5xL1pBZ28yWWhacUdzVzByVlZpcWk3QUhMQVdSRlBqWjZpVk44QnVlQXZZ?= =?utf-8?Q?tdr1yx6IoUbBn2OzSsstbOTEHXY6KkzIAfi0Hg3?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 41f397d4-c271-4e20-67df-08d96dfadc85 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Sep 2021 10:17:26.0007 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: OBnDfa0ge7derCedYuGkDbNGhwrCcr5dXwEg9NuPKOB3nJBZiswfGdfpjkucGt8T9vl0oj1uDMGvzj0oH+f45A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2447 On 24.08.2021 12:49, Anthony PERARD wrote: > This allows Makefile.clean to recurse into livepatch without help. > > Signed-off-by: Anthony PERARD Acked-by: Jan Beulich From xen-devel-bounces@lists.xenproject.org Thu Sep 02 10:19:17 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 10:19:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177222.322520 (Exim 4.92) (envelope-from ) id 1mLjoR-0001LF-Nr; Thu, 02 Sep 2021 10:19:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177222.322520; Thu, 02 Sep 2021 10:19:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLjoR-0001L8-Kq; Thu, 02 Sep 2021 10:19:15 +0000 Received: by outflank-mailman (input) for mailman id 177222; Thu, 02 Sep 2021 10:19:14 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLjoQ-0001L0-6E for xen-devel@lists.xenproject.org; Thu, 02 Sep 2021 10:19:14 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (unknown [40.107.21.61]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 3817619c-0bd7-11ec-ae51-12813bfff9fa; Thu, 02 Sep 2021 10:19:13 +0000 (UTC) Received: from AM5PR0301CA0029.eurprd03.prod.outlook.com (2603:10a6:206:14::42) by AM0PR08MB5362.eurprd08.prod.outlook.com (2603:10a6:208:180::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19; Thu, 2 Sep 2021 10:19:01 +0000 Received: from AM5EUR03FT062.eop-EUR03.prod.protection.outlook.com (2603:10a6:206:14:cafe::80) by AM5PR0301CA0029.outlook.office365.com (2603:10a6:206:14::42) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Thu, 2 Sep 2021 10:19:01 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT062.mail.protection.outlook.com (10.152.17.120) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Thu, 2 Sep 2021 10:19:00 +0000 Received: ("Tessian outbound f11f34576ce3:v103"); Thu, 02 Sep 2021 10:18:59 +0000 Received: from d07b1656b146.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id D95FE19C-E716-48ED-95B2-C1F361DBC423.1; Thu, 02 Sep 2021 10:18:53 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id d07b1656b146.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 02 Sep 2021 10:18:53 +0000 Received: from PAXPR08MB6446.eurprd08.prod.outlook.com (2603:10a6:102:12d::10) by PR3PR08MB5609.eurprd08.prod.outlook.com (2603:10a6:102:81::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19; Thu, 2 Sep 2021 10:18:52 +0000 Received: from PAXPR08MB6446.eurprd08.prod.outlook.com ([fe80::c029:ed0:82e7:3c2f]) by PAXPR08MB6446.eurprd08.prod.outlook.com ([fe80::c029:ed0:82e7:3c2f%6]) with mapi id 15.20.4457.024; Thu, 2 Sep 2021 10:18:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3817619c-0bd7-11ec-ae51-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tw0iUjtKkLEHPRfdJHIx0kRvdubuEIfM3/VmTTJDH0E=; b=pIxoocTFccO3R5idc6ai9owoztQn/16d+Jzrx3AZaG0vlt5pudj3Avkjro6+JCVJl/XQQq1ZOQzRRbraqsqCqpV6eWPVT7dTc3JckYZPEZp5Z0NioeaKSrsWM28T1g0o/JzAPY/R3TwVahdBntrbG2uGAKMYIzD3Ud2Ph7TuCUE= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: dc87c5284b92ed52 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ndCVH+jAGAx+eRStRkwsQR+B/x0NyUKClrH5eqMnlKMPxGDZdbsl7yuWdVG2Kz/sHwKZlkLKvgqVV4FFcmc0I+PNdY1cEVeL5Z56vlIvOnoksuKYzkcgFufZANnfUboKtMxglh+RFff1sGNEe3AxHCGeMV73F+nikE+uyI/i91kqbe3m77L0yZN9LWUFzqbqBJNohX1KT9FMJ4jHqNipj5OwFs09hYuu/yu/idnXCxxXn5AuX2jgxF/KTowOOqPRZkkYcdFVFbdXh4oFBdlLZH+9oXNQSbzo2guT+v9HGYPlvPPR1Vy03/MrLgF9Guc7+T3kTXrRdC1/5ksNgujjKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=tw0iUjtKkLEHPRfdJHIx0kRvdubuEIfM3/VmTTJDH0E=; b=D9ZA2XDmD0KPb0VrJdkBm6igUQGAHhF4oqY+CeVvynWliKuuV+gY5sKVE/WimiwYzXUPyoPr2M4v8pylxElmR6DyjSy17rfpNRctp1WbrynpJH9w1ZwFhNhtPgy5TlBADlVol4nF+DhHSwNW/p2dNs46URXba8wJVPdPVJXd27t1B+voTL12yPqFCe5mTkqEZM/ptt4L/ixqHmN6AMtt4VgBOh/n9t9/okoJPXpS3/vbqqykY6bD0D8wd3moPHvnpGAgGELsGkTJjdrMOQGJfb932OJtm4xQtIURGmqQY/GaV1F90pBG7piMPZswr+dizlF0feEXI2i3ShziPt9fpA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tw0iUjtKkLEHPRfdJHIx0kRvdubuEIfM3/VmTTJDH0E=; b=pIxoocTFccO3R5idc6ai9owoztQn/16d+Jzrx3AZaG0vlt5pudj3Avkjro6+JCVJl/XQQq1ZOQzRRbraqsqCqpV6eWPVT7dTc3JckYZPEZp5Z0NioeaKSrsWM28T1g0o/JzAPY/R3TwVahdBntrbG2uGAKMYIzD3Ud2Ph7TuCUE= From: Bertrand Marquis To: Julien Grall CC: Stefano Stabellini , Michal Orzel , "xen-devel@lists.xenproject.org" , Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Wei Liu , Volodymyr Babchuk Subject: Re: [PATCH] xen/arm: Introduce pmu_access parameter Thread-Topic: [PATCH] xen/arm: Introduce pmu_access parameter Thread-Index: AQHXny72/ET98Hho/USYtlrYv98fUauPIugAgAAENgCAABSIgIAAOtOAgAAK3QCAAOCVgIAAEW+AgAAWIYA= Date: Thu, 2 Sep 2021 10:18:51 +0000 Message-ID: <8B5CFAFE-FB9E-40EE-B162-35554B71EE68@arm.com> References: <20210901124308.31573-1-michal.orzel@arm.com> <599515f0-4b8a-3a71-caea-b17ec27c9123@xen.org> <44B48162-EB44-4295-9629-2D95A40D7232@arm.com> <46e36ba5-8b3d-2d43-6297-b92d2654ab72@xen.org> <0e72fb05-a477-ef79-c26f-bc011393a403@xen.org> <5B7B9C01-FF1D-44F9-8815-A422E51916A0@arm.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3654.120.0.1.13) Authentication-Results-Original: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com; x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: a756ad49-82f9-45a8-9fd0-08d96dfb14fa x-ms-traffictypediagnostic: PR3PR08MB5609:|AM0PR08MB5362: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:10000;OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: UYW4hFDjfb3a7zWLI/JLtDJNG25czlp28CopXaYChrWMKGJnoBLyNPvG2hMbEoTi7vflQrqrvp/1dWH5+G5rbaQIb0amIA/qUCLCLlsgawtq92ODTa6tcEI2973Ivh+CNVYqTMywIh8iZGZ/P48TGSSVYX/n5ftZ82U1lIc/qENGWU9DLZRr8MVUSPX7PgQV9FkkocPLlAB3MTi9o3BwZiUAtXJTBrVio18kWZnd1naT07RmdDxKA+0+zJZViPdMTiptApCukK9Snk0h0AXht/Go3NIUrmQy9L241csQsitZVUZCGcYnbFSlFIEAHj1rPHtLmdhZANqEDJbhlUVkUGlLW8hfjLAtZtAv9z2UNwa+tHsTEjnhaGKLDKSwGtl/5NL7ss+/t5RzrA2scp55ePw7GCjrOVcChT2u6n1VT5xb+53g3yY7TzItBe/BH9T1F/U25k3y90Tk8H+qYVqvmKFusB8RPAt+A+nWJatAZM/ADuSbjGffyjJesB2L/mMjWPen4PE5I0zbsClem034toacp8Syai5NGeFnqEJEGX4ZeFmGRzZTP3MQBgjXl9caVjeYWX043eMl1vhKIfg9iGx4aiTuV2ySCI7bWsKqmvtyoNZWuC5cgWUQA6Qv52xl7PPQlqxB/Qb7nzJH5oKwk7qq16gkahNpLSTyjcwBrgh6iQ+1N2gsbTfUkldhXapcUSHr/tRk9d5xJUBQqDJ7WQUyzxR5X/CL8biZA+4rnIkkXwe2bIlBu+aqe7hWlGH1IMBjIzeWuMbAcDpAyuk/ZA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB6446.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(366004)(376002)(39860400002)(396003)(136003)(2906002)(83380400001)(6486002)(5660300002)(8676002)(76116006)(91956017)(38070700005)(4326008)(26005)(6512007)(478600001)(64756008)(66556008)(66476007)(6916009)(66446008)(33656002)(66946007)(316002)(6506007)(54906003)(53546011)(2616005)(36756003)(186003)(71200400001)(38100700002)(122000001)(8936002)(86362001)(21314003)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR08MB5609 Original-Authentication-Results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT062.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: f2252119-6265-4c78-bf74-08d96dfb0fd8 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dQ2DjelHeRHZVrg7zwS+YIdP4sY2qy8UQ+J+jrq66N4WJvzjyBOhvxiV4HbKuP4qAQHhfxlC3q8/lJOItk27f1ySscJL+bz5kLPu9KD9DeOpXrFWsAjEqABmxEvAhOOwTcvN3PXt5kvSAZdsTeb/uIZVT5o4o6HruheQ5YATxMcQfsI0SGVF0LlUBY3x/aZgjM/iLuIMrZkM7g+2A76iCuH4h8qP7orsvDDYtKStD4MR1pJwEdn8qO7RteCMHH4lB0WtgqllIjBCBvzv4s4tek8sj/IoifURTq2xAXLnPmsOh2vxrLLW8X9phB3OzNmor65ZhEPXyTNkDg8wmK0UARUf4dviICqaqth273yqHnOYr3AruituQBwLM+MYQZEwZ7xHGhGg1KEj7Ok6mBI26HPDySJ0h+Nds9nb24LnKpnxbB9WelFsO/pFwf4laWmsxhY/3PK9bCOVP9mB6thnpjDJZwDIRdiR8BfRXMRRCWPgW21y19UjUm5Xn8C52BtRU01U6g68Gnhe/aiZODLMbRRNlNzCMVSEuz1FVY/68qgRyfKIuhTAdnXaUFBsEOIfRhI3EGlsalTsE07vwwpT1b2yFBzFw+w8tF6TzYjM3nTPXXTY0HIKdSfyfPmwflks5D7tZi3XdmB8nHvLplPFPEe+z42ipHEPl4nY7SpTecPr5yqQcJncB90t0CGaNRA8shHMd2mzj7iL00VPQLQ5+Emku9l7yBAXYe1XtMhwxjE= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(136003)(39860400002)(346002)(376002)(396003)(36840700001)(46966006)(6486002)(5660300002)(8676002)(33656002)(70586007)(8936002)(6512007)(82310400003)(81166007)(82740400003)(356005)(70206006)(36860700001)(47076005)(6862004)(83380400001)(4326008)(86362001)(107886003)(478600001)(36756003)(2906002)(54906003)(2616005)(336012)(6506007)(316002)(26005)(186003)(53546011)(21314003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Sep 2021 10:19:00.4954 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a756ad49-82f9-45a8-9fd0-08d96dfb14fa X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT062.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB5362 Hi, > On 2 Sep 2021, at 09:59, Julien Grall wrote: >=20 >=20 >=20 > On 02/09/2021 08:57, Bertrand Marquis wrote: >> Hi Julien, >=20 > Hi Bertrand, >=20 >> If I understand it right, you want a per guest parameter to be able to a= llow PMU accesses. >> This would require: >> - to save/restore MDCR on context switch >> - introduce a new config parameter for guests (might or might not need a= tool change) >> - have a xen command line parameter to have a solution to Allow PMU for = dom0 (or maybe a DTB one) > Yes. >=20 >> But this would NOT include: >> - interrupt support (only needed to get informed of overflow) >> - provide PMU virtualization (not even sure something like that could ma= ke much sense) >=20 > I am guessing the following is also included here: >=20 > - provide a PMU node in the DTB for the domain. >=20 > Without those 3, I feel we are exposing an half backed PMU to the guest. = But this would still be a good first step, so I would be OK if they are not= implemented in the first shot. >=20 >> I am not saying that we will do that now but as I need to unblock this I= could evaluate the effort and see if it could be possible to do this in th= e future. >=20 > Well... Below the patch I wrote during my breakfast this morning. This ha= s not been tested and miss some documentation. Impressive but be careful not to put jam on your keyboard :-) We are clearly not at your level of expertise and this would have taken us = a lot more time, even if we tried without eating in parallel. >=20 > From 690a92cffed82451dcbd8b966e8dee31c1dce5fc Mon Sep 17 00:00:00 2001 > From: Julien Grall > Date: Thu, 2 Sep 2021 08:46:12 +0000 > Subject: [PATCH] xen/arm: Expose the PMU to the guest >=20 > There are requests to expose the PMU (even in a hackish/non-secure way) > to the guests. This is taking the first steps by adding a per-domain > flag to disable the PMU traps. >=20 > Long term, we will want to at least expose the PMU interrupts, device-tre= e > binding. For more use cases, we will also need to save/restore the > PMU context. >=20 > Signed-off-by: Julien Grall > --- > tools/include/libxl.h | 2 ++ > tools/libs/light/libxl_arm.c | 3 +++ > tools/libs/light/libxl_types.idl | 2 ++ > tools/xl/xl_parse.c | 3 +++ > xen/arch/arm/domain.c | 10 ++++++++-- > xen/include/asm-arm/domain.h | 1 + > xen/include/public/domctl.h | 4 ++++ > 7 files changed, 23 insertions(+), 2 deletions(-) >=20 > diff --git a/tools/include/libxl.h b/tools/include/libxl.h > index b9ba16d69869..d3e795a38670 100644 > --- a/tools/include/libxl.h > +++ b/tools/include/libxl.h > @@ -502,6 +502,8 @@ > */ > #define LIBXL_HAVE_X86_MSR_RELAXED 1 >=20 > +#define LIBXL_HAVE_ARM_VPMU 1 > + > /* > * libxl ABI compatibility > * > diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c > index e3140a6e0039..89865a90dd3e 100644 > --- a/tools/libs/light/libxl_arm.c > +++ b/tools/libs/light/libxl_arm.c > @@ -29,6 +29,9 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc, > uint32_t vuart_irq; > bool vuart_enabled =3D false; >=20 > + if (d_config->b_info.arch.vpmu) > + config->flags |=3D XEN_DOMCTL_CDF_PMU; > + > /* > * If pl011 vuart is enabled then increment the nr_spis to allow allo= cation > * of SPI VIRQ for pl011. > diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_ty= pes.idl > index 3f9fff653a4a..daf768cba568 100644 > --- a/tools/libs/light/libxl_types.idl > +++ b/tools/libs/light/libxl_types.idl > @@ -644,6 +644,8 @@ libxl_domain_build_info =3D Struct("domain_build_info= ",[ >=20 > ("arch_arm", Struct(None, [("gic_version", libxl_gic_version), > ("vuart", libxl_vuart_type), > + # XXX: Can this be common? > + ("vpmu", boolean) > ])), > ("arch_x86", Struct(None, [("msr_relaxed", libxl_defbool), > ])), > diff --git a/tools/xl/xl_parse.c b/tools/xl/xl_parse.c > index 17dddb4cd534..6e497cc0b67e 100644 > --- a/tools/xl/xl_parse.c > +++ b/tools/xl/xl_parse.c > @@ -2729,6 +2729,9 @@ skip_usbdev: > } > } >=20 > + /* XXX: This probably want to be common or #ifdef-ed */ > + xlu_cfg_get_defbool(config, "vpmu", &b_info->arch_arm.vpmu, 0); > + > if (!xlu_cfg_get_string (config, "tee", &buf, 1)) { > e =3D libxl_tee_type_from_string(buf, &b_info->tee); > if (e) { > diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c > index 19c756ac3d46..a0e2321008ab 100644 > --- a/xen/arch/arm/domain.c > +++ b/xen/arch/arm/domain.c > @@ -276,6 +276,9 @@ static void ctxt_switch_to(struct vcpu *n) > * timer. The interrupt needs to be injected into the guest. */ > WRITE_SYSREG(n->arch.cntkctl, CNTKCTL_EL1); > virt_timer_restore(n); > + > + /* XXX: Check the position and synchronization requirement */ > + WRITE_SYSREG(n->arch.mdcr_el2, MDCR_EL2); > } >=20 > /* Update per-VCPU guest runstate shared memory area (if registered). */ > @@ -585,6 +588,9 @@ int arch_vcpu_create(struct vcpu *v) > v->arch.vmpidr =3D MPIDR_SMP | vcpuid_to_vaffinity(v->vcpu_id); >=20 > v->arch.hcr_el2 =3D get_default_hcr_flags(); > + v->arch.mdcr_el2 =3D HDCR_TDRA|HDCR_TDOSA|HDCR_TDA; > + if ( !(v->domain->options & XEN_DOMCTL_CDF_PMU) ) > + v->arch.mdcr_el2 |=3D HDCR_TPM|HDCR_TPMCR; >=20 > if ( (rc =3D vcpu_vgic_init(v)) !=3D 0 ) > goto fail; > @@ -622,8 +628,8 @@ int arch_sanitise_domain_config(struct xen_domctl_cre= atedomain *config) > { > unsigned int max_vcpus; >=20 > - /* HVM and HAP must be set. IOMMU may or may not be */ > - if ( (config->flags & ~XEN_DOMCTL_CDF_iommu) !=3D > + /* HVM and HAP must be set. IOMMU and PMU may or may not be */ > + if ( (config->flags & ~(XEN_DOMCTL_CDF_iommu | XEN_DOMCTL_CDF_pmu)) = !=3D > (XEN_DOMCTL_CDF_hvm | XEN_DOMCTL_CDF_hap) ) > { > dprintk(XENLOG_INFO, "Unsupported configuration %#x\n", > diff --git a/xen/include/asm-arm/domain.h b/xen/include/asm-arm/domain.h > index c9277b5c6d94..14e575288f77 100644 > --- a/xen/include/asm-arm/domain.h > +++ b/xen/include/asm-arm/domain.h > @@ -166,6 +166,7 @@ struct arch_vcpu >=20 > /* HYP configuration */ > register_t hcr_el2; > + register_t mdcr_el2; >=20 > uint32_t teecr, teehbr; /* ThumbEE, 32-bit guests only */ > #ifdef CONFIG_ARM_32 > diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h > index 96696e3842da..db9539ddd579 100644 > --- a/xen/include/public/domctl.h > +++ b/xen/include/public/domctl.h > @@ -71,6 +71,10 @@ struct xen_domctl_createdomain { > #define _XEN_DOMCTL_CDF_nested_virt 6 > #define XEN_DOMCTL_CDF_nested_virt (1U << _XEN_DOMCTL_CDF_nested_virt) >=20 > +/* Should we expose the vPMU to the guest? */ > +#define _XEN_DOMCTL_CDF_pmu 6 > +#define XEN_DOMCTL_CDF_pmu (1U<<_XEN_DOMCTL_CDF_pmu) > + > /* Max XEN_DOMCTL_CDF_* constant. Used for ABI checking. */ > #define XEN_DOMCTL_CDF_MAX XEN_DOMCTL_CDF_nested_virt >=20 >> In the meantime we will start maintaining an internal branch with patche= s refused upstream as this is blocking us. >=20 > For the future, please consider a per-domain option from the beginning. T= his is not much extra effort (see the patch above) and would make the accep= tance of a patch more likely. We wanted to share something we did internally which we thought could be us= eful for others. We will be more careful in the future. Cheers Bertrand >=20 > Cheers, >=20 > --=20 > Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Sep 02 10:22:33 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 10:22:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177230.322537 (Exim 4.92) (envelope-from ) id 1mLjrc-0002tz-8c; Thu, 02 Sep 2021 10:22:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177230.322537; Thu, 02 Sep 2021 10:22:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLjrc-0002ts-5i; Thu, 02 Sep 2021 10:22:32 +0000 Received: by outflank-mailman (input) for mailman id 177230; Thu, 02 Sep 2021 10:22:31 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLjrb-0002tm-6A for xen-devel@lists.xenproject.org; Thu, 02 Sep 2021 10:22:31 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 581489b4-254d-40ab-baaa-f40e8832e8ed; Thu, 02 Sep 2021 10:22:30 +0000 (UTC) Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-he1eur02lp2051.outbound.protection.outlook.com [104.47.5.51]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-24-O7RvBVukNHCZhA4CO9IjYA-1; Thu, 02 Sep 2021 12:22:28 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR04MB5599.eurprd04.prod.outlook.com (2603:10a6:803:de::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.20; Thu, 2 Sep 2021 10:22:26 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4478.021; Thu, 2 Sep 2021 10:22:26 +0000 Received: from [10.156.60.236] (37.24.206.209) by PR2P264CA0041.FRAP264.PROD.OUTLOOK.COM (2603:10a6:101:1::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.17 via Frontend Transport; Thu, 2 Sep 2021 10:22:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 581489b4-254d-40ab-baaa-f40e8832e8ed DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1630578149; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jBvMBrv4oxvPPQ9EqN0vykb5XJjI42SfMRO3gMpCVf0=; b=UkmyJ8Ao5+zN8J1NZgK3F6n/sYhSVmoFqJj+pBsHqx+YtnlGKoLJKULoJlWmtDgVyQvxek HWbTBupWDmGgYQoEGlbfjZq9u84iih3KeL2e3KgEg/j/UoclmqW9uZ/BIH10QDK6+BOJ76 QYTGcin+gSSQ0RHioa9eJxFsT+dZfnk= X-MC-Unique: O7RvBVukNHCZhA4CO9IjYA-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MrBGUGX1ckyFBe9DdcIzX3NPXIBIw4JmrF8NFZ3aW2PPLu2rw557PfQTjfSUV90XGHWZl966YI4GX8t4PLzFkx2kJRJx98rIsC72kW26ioVMDH+MYnLnsgG0i0NYtEC7741+pvB/L9gf7NEm8jboOR2DsECSxliM8uGPaJB+ggTu8icqj2GY+9z7Xlebky9HjG8cEkliBe6TWwU5ESLKyRiC3w4L+soRAZk57GxWismzr2XJvJRrgd1CxBUj87WOPjZHyKg/EJ85trn1WTFLjPxBjwiBbcFH8w5BOKIXOP36Idvz8Qogg0IRras0hSu5krmurBO5YNsayifZJSQ6XA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=jBvMBrv4oxvPPQ9EqN0vykb5XJjI42SfMRO3gMpCVf0=; b=HzF1B2dtd5VX/tZmm8JXo11T1DORvuGHI+k1j8ckqKdviuW+LmZoZH8y1F95jQ5Ck69Qh0X0ygdg+0+rhbKynMAYvV8mlKryN7v7aBGt4gTkBDlHrcYEZcMfYRFlQwN3tU62OFHELeABYyo+EM7UCDrckDBJHea2JIC3ljSofi34HABCkuffpdIDljYMcTahQF4moJhK6o2jW9abSw81KYWrmxX+6RnEaBmXbfOAaN91XUUTIRIPUWxoYpytg2IeST1OzYPkKs7FO2TpVAVNKIclaxO7FxXHl/uqo43HkeRvz+/xtwNad5L58oIebISSTG2co9XLgkPO+Fgreg1K+A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com; Subject: Re: [XEN PATCH v7 00/51] xen: Build system improvements, now with out-of-tree build! To: Anthony PERARD Cc: xen-devel@lists.xenproject.org References: <20210824105038.1257926-1-anthony.perard@citrix.com> From: Jan Beulich Message-ID: Date: Thu, 2 Sep 2021 12:22:24 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: <20210824105038.1257926-1-anthony.perard@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PR2P264CA0041.FRAP264.PROD.OUTLOOK.COM (2603:10a6:101:1::29) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 73adc729-ea34-4779-e5ee-08d96dfb8f7c X-MS-TrafficTypeDiagnostic: VI1PR04MB5599: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9uT1Wpnj60xmtKnpwLM4Y/jDGk4CYf9UpxsHsdPgHuPKelDTeGF+FetqGeDY+INlMPsB/4Q6foGCJSes3B39/doNqrY5Bn8PDjyvv6UFLCZB8dk4B/1kSfm5m1AvgBoPsiWwaxVeyPwqFHtNQE1pq4K7SJvX9bktmkB2uZa5nGtblzZaFmGX0VrB5yVLVrgfzJtQoEDVUaE+/KyzMkufw8b9G4wXOATFymmQxIOr7Yay/zgzC7eRW4nPmV92WoguyHNKXi4hNgKF4q3Gby/3aYFJGv0+9QPTaR74+7vaPL4rliNYloDIaH7Bmax4YnvqQfTXTy73WFJ3KgZUcTjRktbMhWi80/MRAaJg24DmaUJOddcrwOzt4zOWMA9VD/5BCjyo0ah+oB++2a+ANUbmPXIPEOcNTVfR0CqIAiaou/Gp8PcuJtQMcxs/kQGynTVGuyBLJGPky/XGispaoVCZ3bWznd70G3CgzUbmZ+aSpvV/WigOxRjKJXRd1GMfDvUKANhc1lyd9QLoFAuWUkakKS7BmXOEImuJgHWN5hvBBlQvbC1cjSnXAw+tGMcu9espftBUE8UUDNJejSYKIhjrLjJJadmHFqYuXTusErzZYuMC3k2EMaEZwg0GbWpzKFFFUbVIxMLqjaTFGp4qGiRpFUMt1zjr2TkIStJrwbR/X2PStwkdPSbd3MS8ppkRmXRlgAxerpyzCvWgXmNJhnh1nyBUFEQTl9XK7Wdy+dmOF7c= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(39860400002)(136003)(376002)(366004)(396003)(346002)(66476007)(4326008)(26005)(53546011)(66946007)(8936002)(5660300002)(316002)(186003)(16576012)(31686004)(8676002)(38100700002)(4744005)(2906002)(66556008)(36756003)(6916009)(31696002)(956004)(2616005)(86362001)(478600001)(6486002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dHkwOUlZQjVLeFZGdklFby9JQmJ1a0ZGcm15LzhVN1BkdmFLd0ZhQ2NtWGc1?= =?utf-8?B?Q3gwR2xlT0RkVTZRelFUTmQ2M3Viem12YkVJZ0xMckM5alRDeEtwSUQzcFhX?= =?utf-8?B?MDRrWVlJZ1RWRW90NnlqQS96WjUrbXNyN25rNUFnaUZiU1BvVDJXZ2lKckxB?= =?utf-8?B?OHNLNGtnTFFLVUZMQVozT0g3cnBwQVdodE9waDU5eXlpdDRvWWt6WTI4VHZG?= =?utf-8?B?Mjg0UnFhTFZySWUveEVmaURyZjVDMWM3MmkzQUFMSTdoNzhIVGlZaFFZZmtT?= =?utf-8?B?cE1PRVE5aUFndFhEMzNlTWF4N1FLZjRwU2JqQWZDYkJMbW9DSlBOczdNbWoz?= =?utf-8?B?VVpPMG5JSzBKdEZZKy9WSlUxNGJreElydlVraUc4ZGk4Q0czbit6R3ZjVUJu?= =?utf-8?B?UCtINUN5R2tDUWlLSWdLSmYwb3M4SWx3SVFwcHJ4MVRDNXlUMVV5Ly90UmZ0?= =?utf-8?B?anN5RU4rTmFOUFJmOGlXQ1pCbDYxQjNtaHFkcGU1T0ZSUXBYZ3BZdDBvTUJQ?= =?utf-8?B?SmZIM3BUbGpwYXVvSGNYcU5FY3dkRkkvaEUwelNlaW95bXp3WDhpV0o4bFE5?= =?utf-8?B?ZjJTKzg4ckM2SlhITjVscXFMUVB1VDU3Y0p1RkpRWlpvRlJQME1hSGJaNlNh?= =?utf-8?B?cG53eitMT3BEcUdqZUxtTHk0bzV6U3l0VTJEQ0RVMkdicVc5ZFRjS3c5VGtH?= =?utf-8?B?ZG9sRlJGZ3hpTjNJajJuUWNpbjBYY2hPUWN1TzZvYkVaUnJqdzBKWXRGOW9Q?= =?utf-8?B?REROanNReXljU1R3V1JldGZHeTJKS2dMRHFUc3h2MFRwaGk5N1dHZkJDUFkv?= =?utf-8?B?TzV5R2VUWllaWUh5dStLbWpINmtqV1NIVlNKaDRGOUc4TlZRaGkvNEZob25t?= =?utf-8?B?Q2kxWE5HSmdhR2V3ZHU5MTdGMFI4SkFPUlBkcFJQYit5N2wrT2pEMCtGWGRV?= =?utf-8?B?cjZNUEVLV3FQd3hMRGIzbU9vdFd5VHV2M0R4YkpUaDhtM0I3M3pMc1cwVDJj?= =?utf-8?B?UlRDUkdFRTcvU1FMUnkzYlhpZmd2cGpkYVVLZTYvQlBjSEZwZEpTRlZjaVRa?= =?utf-8?B?MDdRemhhLzVobHpoTElVeUVpRzVCOTNRcGdkYzJjaU91N2s4aXliYll5MXJs?= =?utf-8?B?MWpRcnFPQ1pvMTd3YUxNYy8zVXJGblYreGxwUllUdjlsbU1hUzN3a2I2akVk?= =?utf-8?B?dkZIUFFRdVJISVVxajEwcHhRbzFheDNrZU5wbGxjRnZOaDZrZlhDQXBXOFlM?= =?utf-8?B?amRXNGdmUE5EUm1yL0Jad0R1THJZbkhLbFVGY1RMTjlpWkR0ZFVYVEZlckpZ?= =?utf-8?B?S0JCVHBBNmlyMllDMTRkYm5xYU5LS2tRdVR6MmVQTkVBODdKMXhKTlNmdVdG?= =?utf-8?B?QnphQ0pkTjVXZUNTMjArL1ZMR3p2MGhWZnRGRkU3YlVVdjVBN1JmWXN1aWha?= =?utf-8?B?TTFCRUZFU3hqTDNtb3I2cFlLc1dsWit5RWRFclEvUU1XMm8xTDJ1SkZLVGZk?= =?utf-8?B?TG8vNVQyNmxNTU12V2NtQy9UQmhCOTF3NUpQYTE3UVhuWkNwLzR1T2swMTMr?= =?utf-8?B?dXdvUkxzZU9FZUQ1RFNDUFQ3OURsZEN0b3VQK0NSeVo4ckd6SlE3YmREMG5j?= =?utf-8?B?R3U1a1JPQTB3eG5rVmNrdXpJcm40a3pCSHZtY3RsSGN3WW8vdEF0Z0JNckJ6?= =?utf-8?B?YW5vYmRBcTdDdlUrNENHTWJWYUROcitVNDFhYlF6R2hFYitVbWhiOXVDK1pO?= =?utf-8?Q?Ji2qhSSfKyj0Yn0A+i7LdHtnFFmRdoqanacr7yQ?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 73adc729-ea34-4779-e5ee-08d96dfb8f7c X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Sep 2021 10:22:26.4659 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: yBB8pcU8XU7U+BXmep6BjcTMGJ33aNM/Hbavpa+rWk0/6gHXuliQN3Hj6AI2jnSrIiqteR6mS86BfMQeYlSoDg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5599 (trimming Cc list) On 24.08.2021 12:49, Anthony PERARD wrote: > Anthony PERARD (51): > build: introduce cpp_flags macro > build: use if_changed on built_in.o > build: use if_changed_rules with %.o:%.c targets > build: factorise generation of the linker scripts > x86/mm: avoid building multiple .o from a single .c file > build,include: rework compat-build-source.py > build,include: rework compat-build-header.py > build: fix clean targets when subdir-y is used > build: use subdir-y in test/Makefile > build,arm: move LDFLAGS change to arch.mk Having gone through to here while skipping patch 5 for the moment, I wonder in how far there are dependencies among the above (and, looking forward, also for others further down on earlier ones). I don't think it can reasonably be expected for the entire series to go in all at the same time, so I'd consider it useful to put in whatever is ready and independent of earlier changes perhaps still under discussion. Jan From xen-devel-bounces@lists.xenproject.org Thu Sep 02 11:21:49 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 11:21:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177236.322549 (Exim 4.92) (envelope-from ) id 1mLkml-0000yg-Mj; Thu, 02 Sep 2021 11:21:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177236.322549; Thu, 02 Sep 2021 11:21:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLkml-0000yZ-IL; Thu, 02 Sep 2021 11:21:35 +0000 Received: by outflank-mailman (input) for mailman id 177236; Thu, 02 Sep 2021 11:21:34 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLkmk-0000yT-RT for xen-devel@lists.xenproject.org; Thu, 02 Sep 2021 11:21:34 +0000 Received: from mail-pg1-x533.google.com (unknown [2607:f8b0:4864:20::533]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 5cf3ac59-f97e-4c73-b1a8-67856855a759; Thu, 02 Sep 2021 11:21:33 +0000 (UTC) Received: by mail-pg1-x533.google.com with SMTP id w8so1559841pgf.5 for ; Thu, 02 Sep 2021 04:21:33 -0700 (PDT) Received: from ?IPv6:2404:f801:0:5:8000::50b? ([2404:f801:9000:1a:efea::50b]) by smtp.gmail.com with ESMTPSA id j6sm2394666pgq.0.2021.09.02.04.21.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Sep 2021 04:21:32 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5cf3ac59-f97e-4c73-b1a8-67856855a759 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=uvXbklsYzxIxtTfrV32ffa9Nuwizcf2v49dwd36P0II=; b=l3pHshNaH16SxCRdn9z7Xh25o4zr254bVE4gj2gcLe03eGaxqkakkGTJFxJqfTpw1V mgl7jhuQxVjIwW/UeX7ktsAfn4KtTM1QiXhueAKmpi1umldFhOhm/opbthWUVENXfmXz sByuEIse1tA9cQPTkGsfIdaE+UkFVQTBoS0K+F+XP4S1/PfM9AjDF1PXXeVM/2D0/+Wg GFVcsUwXqGqAsvdSyylORw5dpuBcJnKleE7Htyj6/Iy7J3TtLZUSPSx2JgomTUK9XCbK tkwtRAK0M+aqYoU4ijzQ2mRPYIgBubcVFek78cQ2L31j1R5JU4P5nO/87EvlyqPdofPx bNug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=uvXbklsYzxIxtTfrV32ffa9Nuwizcf2v49dwd36P0II=; b=VSLSz44j9gbLP9LfnFDgvpVj01pIiVl1f+nNM4SyaiuEflwGru/9w/nrI6P4y0xmgd ymAc0AY5rePz94CB/emFygLOr0ANhLHXJ4Q4F/0AXwWloZYvQWXl2N4Z5ozr/mPoUEUJ npYOLpmwj71tx4iFGE6MX01W9e+O8hXo6uE8+OHh4LcNJAs+T98YUMh2zU1nItlqkzKG NOU4xKQU5+m7oRrjIkF+kQE+110wjip1eMihJDEwObRX93qyMm0EldKEgtTvCiMuj3Pa wt1c1sayFiYwfyP3JxZXUrmb5H6SAOFWiYwJ2p9wcCjDfCwoQA3Ds6pntZO6/6PG/grP axxg== X-Gm-Message-State: AOAM5305KrCOzkHNogix1pGZ60xRKpMjinfhCfu8M5mUrhExApcKDuJw G2JWPPy9gtayxvfB6DvPSVo= X-Google-Smtp-Source: ABdhPJxldFu1U8M2V5yK1yTHMDs9K9anELSSV02bNY0qtLdwF/4+Etf8R4JVmeL3O1gUAcLcNnmdKQ== X-Received: by 2002:a63:5b08:: with SMTP id p8mr2815838pgb.28.1630581692705; Thu, 02 Sep 2021 04:21:32 -0700 (PDT) Subject: Re: [PATCH V4 00/13] x86/Hyper-V: Add Hyper-V Isolation VM support To: Christoph Hellwig , Michael Kelley Cc: KY Srinivasan , Haiyang Zhang , Stephen Hemminger , "wei.liu@kernel.org" , Dexuan Cui , "catalin.marinas@arm.com" , "will@kernel.org" , "tglx@linutronix.de" , "mingo@redhat.com" , "bp@alien8.de" , "x86@kernel.org" , "hpa@zytor.com" , "dave.hansen@linux.intel.com" , "luto@kernel.org" , "peterz@infradead.org" , "konrad.wilk@oracle.com" , "boris.ostrovsky@oracle.com" , "jgross@suse.com" , "sstabellini@kernel.org" , "joro@8bytes.org" , "davem@davemloft.net" , "kuba@kernel.org" , "jejb@linux.ibm.com" , "martin.petersen@oracle.com" , "gregkh@linuxfoundation.org" , "arnd@arndb.de" , "m.szyprowski@samsung.com" , "robin.murphy@arm.com" , "brijesh.singh@amd.com" , "thomas.lendacky@amd.com" , Tianyu Lan , "pgonda@google.com" , "martin.b.radev@gmail.com" , "akpm@linux-foundation.org" , "kirill.shutemov@linux.intel.com" , "rppt@kernel.org" , "hannes@cmpxchg.org" , "aneesh.kumar@linux.ibm.com" , "krish.sadhukhan@oracle.com" , "saravanand@fb.com" , "linux-arm-kernel@lists.infradead.org" , "xen-devel@lists.xenproject.org" , "rientjes@google.com" , "ardb@kernel.org" , "iommu@lists.linux-foundation.org" , "linux-arch@vger.kernel.org" , "linux-hyperv@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-scsi@vger.kernel.org" , "netdev@vger.kernel.org" , vkuznets , "parri.andrea@gmail.com" , "dave.hansen@intel.com" References: <20210827172114.414281-1-ltykernel@gmail.com> <20210830120036.GA22005@lst.de> <20210902075939.GB14986@lst.de> From: Tianyu Lan Message-ID: Date: Thu, 2 Sep 2021 19:21:18 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210902075939.GB14986@lst.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 9/2/2021 3:59 PM, Christoph Hellwig wrote: > On Tue, Aug 31, 2021 at 05:16:19PM +0000, Michael Kelley wrote: >> As a quick overview, I think there are four places where the >> shared_gpa_boundary must be applied to adjust the guest physical >> address that is used. Each requires mapping a corresponding >> virtual address range. Here are the four places: >> >> 1) The so-called "monitor pages" that are a core communication >> mechanism between the guest and Hyper-V. These are two single >> pages, and the mapping is handled by calling memremap() for >> each of the two pages. See Patch 7 of Tianyu's series. > > Ah, interesting. > >> 3) The network driver send and receive buffers. vmap_phys_range() >> should work here. > > Actually it won't. The problem with these buffers is that they are > physically non-contiguous allocations. We really have two sensible > options: > > 1) use vmap_pfn as in the current series. But in that case I think > we should get rid of the other mapping created by vmalloc. I > though a bit about finding a way to apply the offset in vmalloc > itself, but I think it would be too invasive to the normal fast > path. So the other sub-option would be to allocate the pages > manually (maybe even using high order allocations to reduce TLB > pressure) and then remap them Agree. In such case, the map for memory below shared_gpa_boundary is not necessary. allocate_pages() is limited by MAX_ORDER and needs to be called repeatedly to get enough memory. > 2) do away with the contiguous kernel mapping entirely. This means > the simple memcpy calls become loops over kmap_local_pfn. As > I just found out for the send side that would be pretty easy, > but the receive side would be more work. We'd also need to check > the performance implications. kmap_local_pfn() requires pfn with backing struct page and this doesn't work pfn above shared_gpa_boundary. > >> 4) The swiotlb memory used for bounce buffers. vmap_phys_range() >> should work here as well. > > Or memremap if it works for 1. Now use vmap_pfn() and the hv map function is reused in the netvsc driver. > >> Case #2 above does unusual mapping. The ring buffer consists of a ring >> buffer header page, followed by one or more pages that are the actual >> ring buffer. The pages making up the actual ring buffer are mapped >> twice in succession. For example, if the ring buffer has 4 pages >> (one header page and three ring buffer pages), the contiguous >> virtual mapping must cover these seven pages: 0, 1, 2, 3, 1, 2, 3. >> The duplicate contiguous mapping allows the code that is reading >> or writing the actual ring buffer to not be concerned about wrap-around >> because writing off the end of the ring buffer is automatically >> wrapped-around by the mapping. The amount of data read or >> written in one batch never exceeds the size of the ring buffer, and >> after a batch is read or written, the read or write indices are adjusted >> to put them back into the range of the first mapping of the actual >> ring buffer pages. So there's method to the madness, and the >> technique works pretty well. But this kind of mapping is not >> amenable to using vmap_phys_range(). > > Hmm. Can you point me to where this is mapped? Especially for the > classic non-isolated case where no vmap/vmalloc mapping is involved > at all? > This is done via vmap() in the hv_ringbuffer_init() 182/* Initialize the ring buffer. */ 183int hv_ringbuffer_init(struct hv_ring_buffer_info *ring_info, 184 struct page *pages, u32 page_cnt, u32 max_pkt_size) 185{ 186 int i; 187 struct page **pages_wraparound; 188 189 BUILD_BUG_ON((sizeof(struct hv_ring_buffer) != PAGE_SIZE)); 190 191 /* 192 * First page holds struct hv_ring_buffer, do wraparound mapping for 193 * the rest. 194 */ 195 pages_wraparound = kcalloc(page_cnt * 2 - 1, sizeof(struct page *), 196 GFP_KERNEL); 197 if (!pages_wraparound) 198 return -ENOMEM; 199 /* prepare to wrap page array */ 200 pages_wraparound[0] = pages; 201 for (i = 0; i < 2 * (page_cnt - 1); i++) 202 pages_wraparound[i + 1] = &pages[i % (page_cnt - 1) + 1]; 203 /* map */ 204 ring_info->ring_buffer = (struct hv_ring_buffer *) 205 vmap(pages_wraparound, page_cnt * 2 - 1, VM_MAP, PAGE_KERNEL); 206 207 kfree(pages_wraparound); 208 209 210 if (!ring_info->ring_buffer) 211 return -ENOMEM; 212 213 ring_info->ring_buffer->read_index = 214 ring_info->ring_buffer->write_index = 0; From xen-devel-bounces@lists.xenproject.org Thu Sep 02 11:42:24 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 11:42:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177244.322560 (Exim 4.92) (envelope-from ) id 1mLl6o-0003f6-GB; Thu, 02 Sep 2021 11:42:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177244.322560; Thu, 02 Sep 2021 11:42:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLl6o-0003ez-Cy; Thu, 02 Sep 2021 11:42:18 +0000 Received: by outflank-mailman (input) for mailman id 177244; Thu, 02 Sep 2021 11:42:17 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLl6n-0003eo-0v for xen-devel@lists.xenproject.org; Thu, 02 Sep 2021 11:42:17 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 521b01a8-d630-469f-aa7d-b44328f3c1b3; Thu, 02 Sep 2021 11:42:16 +0000 (UTC) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04lp2051.outbound.protection.outlook.com [104.47.13.51]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-36-HyzUUVwYNDeDBuR0TCYHUQ-1; Thu, 02 Sep 2021 13:42:13 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR04MB7024.eurprd04.prod.outlook.com (2603:10a6:800:124::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19; Thu, 2 Sep 2021 11:42:12 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4478.021; Thu, 2 Sep 2021 11:42:12 +0000 Received: from [10.156.60.236] (37.24.206.209) by PR3P189CA0014.EURP189.PROD.OUTLOOK.COM (2603:10a6:102:52::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.20 via Frontend Transport; Thu, 2 Sep 2021 11:42:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 521b01a8-d630-469f-aa7d-b44328f3c1b3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1630582935; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xXFVZSaYK4b8AaJ5+/aIrMW00hZGanLVCMXLN49C26c=; b=HWerCo+7Od7FvhkYA/FmgjjAN+LldpW923YIMwfkRXFSpfrV1uur+t5q7WTZBE7wh2ftqk ds2tmGoLbfYWX5oX0KnWocFK24lYNP9R+S9DYiPAkcr98kusmPvYzjKxkhtq2NkcqIoLw3 v37SmVZjDufBzT/ctadTZ/GVPWtQe2A= X-MC-Unique: HyzUUVwYNDeDBuR0TCYHUQ-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=edCBtRt22ezlv7rHVOgEMFSMVN86J+T7rDIgTPuWyB/1evYcATdlzTB+jNmy874LwZ8DgOYw1nPYb4iF5byKwdNjQosP+vnfk3MOHKXODRayJtUnIU/jCdnM/t/hZ5a3UeZZB6GuLVpGJKzetaXwownOfcWyt35Bgf6m/nnifKZ/fqwM5X33AhK7HdPS15vjIMLZYxUwSGZuMRo1PzClKviPd7KlRJo4cohVwkafeLwSZNp0aCLHjZXlh4rbLBAiNIH8Qg3sFjb0Dp0CMuS2TirbUzTR238W10lbPBCXs7bljh6YdC/KtHRn+kZzkQIMIwsyQnig9sRu3ZRdcnLRVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=xXFVZSaYK4b8AaJ5+/aIrMW00hZGanLVCMXLN49C26c=; b=jheRC3phtRpE6pRTliRKpNp2eiLqNm+qEh/9spIiBXkVfdh5oyawuFdOf/y5aPdKzFORt7zzlqL73zoF/aET9nZ2RusvotCakhJFgTYUAJbuU8Mn+fwW0I9kC9AwErNnzztaaxvebrX7beKuxvYI1B1sZqqwarCNy8opF+0dCNL81XMaYazkNuaLtTIEpNNm7LHLrBVZkbU3Gi/PHpUc1cCatdoLzOvD0+KTt8cuEOxsvep+OiqTGLpOIf+2UtEvOBZWwmpDbcgKJNCv7gvVTn1ghxr33GOzMFcgIosKZWaFzOmRZRB9117vTjqV/elGb0vI8WI3ml+yvOiWYz4C/A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: citrix.com; dkim=none (message not signed) header.d=none;citrix.com; dmarc=none action=none header.from=suse.com; Subject: Re: [PATCH v2 0/6] x86/PVH: Dom0 building adjustments From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <5972ce4c-bdb0-6d07-afad-cf4dd5615488@suse.com> Message-ID: <2cd2d15a-01f7-6bbf-86a8-85437991da7d@suse.com> Date: Thu, 2 Sep 2021 13:42:09 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: <5972ce4c-bdb0-6d07-afad-cf4dd5615488@suse.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PR3P189CA0014.EURP189.PROD.OUTLOOK.COM (2603:10a6:102:52::19) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2090ac4f-4ccd-45ed-db01-08d96e06b419 X-MS-TrafficTypeDiagnostic: VI1PR04MB7024: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Z5dG3a6giBK5ITZ3af/pUPNv5609L+ZerUQVpIgDI0UHTHjHiKz/ZMjKglUvcHfRwT2XAke/i9yroruz4YC6QXHIIdzizYGCBdyFrgFKkFCIb9T2PI09dXpgv1pjl4uCQOBD8ZHWGC7XjEhWy61tjBIKTQU2UviOA5AUJpcN05cFoh1LZai+xu77J2H8EFnzRZZPyy/OFGFOJ/Hlfn/I85NpqibHc+3Bl9U/UmtB8hAfhMxOYraN4xGFX30KgS7+4Pkw7kkR0wUS7tRvKDTVXIYOFTzsShebp/hwfIjAcOMZR9Ge15X2vO/NWDgakGj4EiQkRymPgkJn0Ta/IlRduuntHi2VuK817MZ1KZfv87visFjqMtv06rSPT74Oui0FikQzCmWOh8bSqfWoa3WUg+AIv6BQQPRekVhJ2vWH6D8xdkMnYRtpPI+zi5IEUqILaLpPa7Q+WGrLwjqM0T1ASFUrkPS43JYZZgJhbGe6zh3SjWSH6veN5ReNWx7fxmYp+Hnee3sqnhIY7xjaK32Fg3zZ5u1GvwKqFTnWkeWCGbvgyVclKNQFl2sZ2YlhbHEbgAVtEbcODlruXSdjhWXTIBWDB+vQBjyFKFt21NMLkiN+84eh4f+Ed3myB+ZmQ1vDyn6DcJMe5m54KW3JStVaoQpr8IkmVe4jguS17HK/PnHfI+ybud0ukjMEajP/w0QvsYewpFEIpJf4f/EwZvXae9grwOAamEY7oAhN+Hxfi2Y= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(136003)(376002)(346002)(396003)(39860400002)(366004)(53546011)(8936002)(38100700002)(31696002)(2616005)(26005)(16576012)(2906002)(5660300002)(6916009)(956004)(36756003)(186003)(54906003)(4326008)(316002)(8676002)(6486002)(83380400001)(66556008)(478600001)(31686004)(86362001)(66476007)(66946007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VDB1azRXZkJUQm53dXRBME9RdWk4SzhiNUlDUmoxdjAvR09ObTQwZDJsbTNZ?= =?utf-8?B?VFRaOFQ0VHBmcGlWdzNSRHROVXZDSW03bE90UkNYdHVMRTlIb294M1gyMEo1?= =?utf-8?B?UjcrRksyQWZWSVpYcjhzemQ4NXhGcG4yL0dTdEU4UytVK05RTTFCU1krL1N1?= =?utf-8?B?QWNOaGErL1ZSMTY3ek9EMjVKa0JoOUI1ZHFMaVI2QlkzbEJvdDREak5vOEc0?= =?utf-8?B?TFRZRnNNZHQ0SWpqWGVMRkhkaWxRVm14VzZ5NW1obHlRblZJN2J4QmptS2J2?= =?utf-8?B?RkhGdnZndGZpUmdLeHduZmhGWWROUmcvWWVJWlRlbkV6QnUyWmFDUXVzZlZj?= =?utf-8?B?b0tscjhveWFmWFc0R243K0RXOW1CaGJPK09TYXpobDF0QUdNSy9ZUzZZRDNF?= =?utf-8?B?MXJrTHc1UEZ1YXR2azhBelhPa0s4T0FqdmVrTEptdXMzTVRtL01LMnZuNzBi?= =?utf-8?B?cnoyWHhyM1VBOHluOW1ES1ZBdjFHcmZ2Tjc3d0FGdElFL1krcFJyUW9yWnZ4?= =?utf-8?B?QXIyaVpOL0JxNU1OaUc4SGl4TGY2UDVXRmlJcElDT0xnTEVpaWdqbHBnRTBm?= =?utf-8?B?c1pXSUovWWlxeVUyZ3RBTXppS3YvT2JuK1g1THVVd21XeXA1aHVDVGxXS1lB?= =?utf-8?B?MngwQU55YnFDdkpBTWlBdzlwVDNKVnZBdmVtaVpYQXpEcEhKcVd3MDRyRm10?= =?utf-8?B?b3k3OXQ4M2V3N0JEUWF6QUZNWEFNeUZoU0UxV2RyaEwvaWllWjcraW95ZzY5?= =?utf-8?B?WW01SkVtWXIvc0pQZFNNMTNIZXFpOHFNaXZaSE9yaEF5ZmcyTWVJNURGNlI5?= =?utf-8?B?R3c0RVNlcGE2ZklabW81Zy9INU1yMWp0bEQxUUFKYVYyWnNqUXMvNDdzTEVz?= =?utf-8?B?WUxtWWYvcEZNSllndVUxeEhhNHpROUpqanZnUDV5Y1lrT1Y3OHM1RzFPTjEz?= =?utf-8?B?RkRUTnFBNzRDcmdrTVdPbld5ZXFnQW9qbFdjZHpicFZRaXkrL3hFdDlNbXc0?= =?utf-8?B?NFFlN0VhR3hvVExuUThIWGhRTFlQNkJMS1BjL2Ixb2E5TkQxMkd5eHJPOER2?= =?utf-8?B?bUlSTWgxeXhhakovdXVFd0ZndmhFY0syQVZrTU9Xak5CU2dUMlpuLytjK0l2?= =?utf-8?B?TlJtVHYyT3lOeTdyM2k2VUU1MXVhS0xqb2FxT3pLY1NCQ1Z0dUpmT2xkQ05L?= =?utf-8?B?RkhTbjlJYURQdHB4UFRwSFd2b2VCNUdXK0l5YXVYWlprdlVaNEl5dGRySHFS?= =?utf-8?B?dEVYL0tYT25WL3ZGRkF0QWJvUjRLWEdJd0lZSS9hRmFna3c0eHJ4bDBRMWNa?= =?utf-8?B?cW5xVFo4bEdvK3FveTNScEdMMTVaL1d6WkgyemZRcjFCeWE5N3NPRWxTMWsz?= =?utf-8?B?SlBHSTN3UnV6VmZycG1rOTFWdG9mSDFOWmxVZWUxNFBLaGVlU0RWOWVhcGlq?= =?utf-8?B?RGtlQWJEKzNBQU0zQjluRHRtOEQ0eE1UU210bXBSU0JWWEE5M2NQUXVZSU1h?= =?utf-8?B?azgwYjZIVkxNUVZHVitXUzh6QU5XSDZzajMrVHhHY29QQkxqb0pHK2JQS3BD?= =?utf-8?B?L2pBOEF2VTViNnpTL0dXeXVVenB4dTVIZCtlK3dkQWVWQm1jdGtzNU1KUEwy?= =?utf-8?B?N0g4aU01QWU1elBMUUpHV0k3WGVISE9CL3JiekNrL0NXZGNhVy9sYTFIbzJB?= =?utf-8?B?YW4zOHVsUUJHUEppQVBnNS9OYnM1eVVqcFZvY1M0a25SYnpMVDZEdmZZRTls?= =?utf-8?Q?syqoUeb8zjXOcbZ4JcGbtjkunB81RnXRzExJlD6?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2090ac4f-4ccd-45ed-db01-08d96e06b419 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Sep 2021 11:42:12.1327 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: XJajRYW0bdEo0ZXOhTGPN7a/VwcgKJToY2qQFBcWnxwLrnv+OQ+gbFxQm+SMNgw5JJlzSO0lzhF1vkoz2Ia6zA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7024 On 02.09.2021 10:30, Jan Beulich wrote: > The code building PVH Dom0 made use of sequences of P2M changes > which are disallowed as of XSA-378. First of all population of the > first Mb of memory needs to be redone. Then, largely as a > workaround, checking introduced by XSA-378 needs to be slightly > relaxed. > > Note that with these adjustments I get Dom0 to start booting on my > development system, but the Dom0 kernel then gets stuck. Since it > was the first time for me to try PVH Dom0 in this context (see > below for why I was hesitant), I cannot tell yet whether this is > due further fallout from the XSA, or some further unrelated > problem. Dom0's BSP makes it all the way through to entering the > idle loop while all APs are still in VPF_down. This last part of the mystery is now solved: By cloning from my PV .config, I've inherited the X86_X2APIC=n that I have there. Yet ACPI's MADT gets populated with only x2APIC entries when building Dom0, which such a kernel would mostly ignore (except for logging). IOW in a way this was indeed a missing select, except that what's needed wouldn't quite work yet: --- a/arch/x86/xen/Kconfig +++ b/arch/x86/xen/Kconfig @@ -83,6 +83,6 @@ config XEN_PVH bool "Xen PVH guest support" depends on XEN && XEN_PVHVM && ACPI select PVH - def_bool n + select X86_X2APIC if XEN_DOM0 help Support for running as a Xen PVH guest. This is because, as mentioned, XEN_DOM0 gets turned off when XEN_PV is off. Whereas x2APIC isn't strictly needed for DomU afaics (MADT gets populated with LAPIC entries only), so the "select" also shouldn't be unconditional. While likely no-one will really care, I'd like to note that this effectively means a 32-bit Linux PVH Dom0 would be impossible, as X86_X2APIC depends on X86_64. This may want reflecting in the eventual adjustment to the XEN_DOM0 dependencies. Btw, I've meanwhile also checked timers: They're active and get updated while Dom0 is in this funny idle state. Jan From xen-devel-bounces@lists.xenproject.org Thu Sep 02 11:48:42 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 11:48:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177252.322577 (Exim 4.92) (envelope-from ) id 1mLlCx-0004MG-8Y; Thu, 02 Sep 2021 11:48:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177252.322577; Thu, 02 Sep 2021 11:48:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLlCx-0004M9-5N; Thu, 02 Sep 2021 11:48:39 +0000 Received: by outflank-mailman (input) for mailman id 177252; Thu, 02 Sep 2021 11:48:37 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLlCv-0004M3-Hu for xen-devel@lists.xenproject.org; Thu, 02 Sep 2021 11:48:37 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLlCt-0003Zn-1W; Thu, 02 Sep 2021 11:48:35 +0000 Received: from 54-240-197-224.amazon.com ([54.240.197.224] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1mLlCs-0002RI-RT; Thu, 02 Sep 2021 11:48:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=L0tCeXQQ0xIWkKx0h3OLF+sIBF+AtFWb5ivng8j3Ihs=; b=u1syOfYhFbWNxBbrx/kqAZuDlZ svczd0Uk+UKljZ/aD9daeMtL98EyjG4z4+hpYojPGi32ObgHlZ80bqXZ+Pw7qt4YvDCqRI3jJxLFP fqO9Oh92i+O+r8TXpdPPQFTpXZm0+WfWlMm+XQ8c/TRxVJxNqc4h30fOjFc0JAzwdhRQ=; Subject: Re: vcpu_show_execution_state() difference between Arm and x86 To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Stefano Stabellini , Andrew Cooper , Bertrand Marquis References: <85dc06ff-04df-2148-81c5-26bd25d1142f@suse.com> <8f295eeb-e8f2-a115-3f83-60922d0fe5f9@xen.org> <00457189-6ab5-24e4-b2ec-1050ebec67eb@suse.com> From: Julien Grall Message-ID: Date: Thu, 2 Sep 2021 12:48:32 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <00457189-6ab5-24e4-b2ec-1050ebec67eb@suse.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Hi Jan, On 02/09/2021 07:45, Jan Beulich wrote: > On 01.09.2021 20:11, Julien Grall wrote: >> On 01/09/2021 14:39, Jan Beulich wrote: >>> back in 2016 Andrew added code to x86'es variant to avoid interleaving >>> of output. The same issue ought to exist on Arm. >> >> Agree. I guess we got away so far because it is pretty rare to have two >> CPUs running at the same. > > I guess you've meant "crashing", not "running"? Yes. > >>> The lock acquired, >>> or more importantly the turning off of IRQs while doing so, is now >>> getting in the way of having PVH Dom0's state dumped the 2nd time. >> >> I am not quite too sure to understand the problem with PVH dom0. Do you >> have a pointer to the issue? > > Locking in both cases: For registers it was VMX'es vmx_vmcs_enter() > acquiring a (non-IRQ-safe) lock, and for the stack it is the P2M lock. > Neither can / should sensibly be made IRQ-safe. > >>> For >>> register state I did find a sufficiently simple (yet not pretty) >>> workaround. For the stack, where I can't reasonably avoid using p2m >>> functions, this is going to be more difficult. > >>> Since I expect Arm to want to also have interleave protection at some >>> point, and since Arm also acquires the p2m lock while accessing Dom0's >>> stacks, I wonder whether anyone has any clever idea on how to avoid >>> the (valid) triggering of check_lock()'s assertion without intrusive >>> changes. (As to intrusive changes - acquiring the p2m lock up front in >>> recursive mode, plus silencing check_lock() for nested acquires of a >>> lock that's already being held by a CPU was my initial idea.) >> >> At least one Arm, the P2M lock is a rwlock which is not yet recursive. > > Right; the same is tru on x86. Hence the expected intrusiveness. > >> But then it feels to me that this solution is only going to cause us >> more trouble in the future. > > Same here - we'd need to be very careful not only when making such > a change, but also going forward. Hence my desire to come up with a > better approach. > >> I looked at the original commit to find out the reason to use the >> console lock. AFAICT, this was to allow console_force_unlock() to work >> properly. But it is not entirely clear why we couldn't get a new lock >> (with IRQ enabled) that could be forced unlocked in that function. >> >> Can either you or Andrew clarify it? > > AIUI any new lock would need to be IRQ-safe as well, as the lock > would be on paths taken to output stuff when the system crashed. Hmmm... Just to confirm, what you are saying is some of the callers of vcpu_show_execution_state() & co may do it with IRQ-disabled. Is that correct? I have tried to play with it on Arm but then I realized that check_lock() is not properly working on Arm because we don't call spin_debug_enable() at boot. :/ So it would make sense why we never saw any issue there... > Hence it would be pointless to introduce yet another lock when the > one we have is already good enough. But I may be missing aspects, > in which case I'd have to defer to Andrew. > >> The other solution I can think off is buffering the output for >> show_registers and only print it once at the end. The downside is we may >> not get any output if there is an issue in the middle of the dump. > > Indeed; I'd prefer to avoid that, the more that it may be hard to > predict how much output there's going to be. And it is not going to work as we couldn't grab the P2M lock with IRQ disabled. On Arm, the only problem is going to be the P2M lock for dump the guest trace. A possible controversial approach for Arm is to just not dump the guest stack or move it outside of the new lock and dump when IRQ is enabled (I am not aware of any places where the guest stack will be dumped and we have IRQ disabled). Bertrand, Stefano? Do you use the guest stack in the dump? If so, what are the cases? Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Sep 02 11:54:53 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 11:54:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177258.322588 (Exim 4.92) (envelope-from ) id 1mLlIu-0005uG-UC; Thu, 02 Sep 2021 11:54:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177258.322588; Thu, 02 Sep 2021 11:54:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLlIu-0005u9-Qs; Thu, 02 Sep 2021 11:54:48 +0000 Received: by outflank-mailman (input) for mailman id 177258; Thu, 02 Sep 2021 11:54:46 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLlIs-0005tz-S3; Thu, 02 Sep 2021 11:54:46 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLlIs-0003fq-LK; Thu, 02 Sep 2021 11:54:46 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLlIs-0003Tz-AZ; Thu, 02 Sep 2021 11:54:46 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mLlIs-0003J4-A1; Thu, 02 Sep 2021 11:54:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=LyYxfqqQ2gxMWPWCVQyIZPsnfImSwNvYkmlDd6f+LbY=; b=pZ08BKNDcY5F1b2k8nlXEKnA/z TJ3YbSfqVbukOJSZS4IcR7I4oQ/hO8YnWNtr0DyA2MmV6ZRNhQ05Gv6jPfwemcDAeiPuuzPscoebm 7dIMnBk7C9S5gAHz1qftRi5qhQeRNpFxCaEJP4ORH49PF/8WhcVST6nTSHwZjOdJpuvc=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 164758: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=e3ee8c8dbd7a9f7d7905abe17be60354c9f5f9a3 X-Osstest-Versions-That: ovmf=cae735f61328d64e2e8991036707b9e78c0f5f63 From: osstest service owner Date: Thu, 02 Sep 2021 11:54:46 +0000 flight 164758 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/164758/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 164674 build-amd64-xsm 6 xen-build fail REGR. vs. 164674 build-i386-xsm 6 xen-build fail REGR. vs. 164674 build-i386 6 xen-build fail REGR. vs. 164674 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf e3ee8c8dbd7a9f7d7905abe17be60354c9f5f9a3 baseline version: ovmf cae735f61328d64e2e8991036707b9e78c0f5f63 Last test of basis 164674 2021-08-31 02:56:52 Z 2 days Failing since 164686 2021-09-01 03:03:43 Z 1 days 12 attempts Testing same since 164740 2021-09-02 02:41:13 Z 0 days 5 attempts ------------------------------------------------------------ People who touched revisions under test: Anthony PERARD DunTan Gary Lin Jim Fehlig Lin, Gary (HPS OE-Linux) Loo Tung Lun Loo, Tung Lun Mark Wilson Marvin H?user Wenxing Hou jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit e3ee8c8dbd7a9f7d7905abe17be60354c9f5f9a3 Author: duntan Date: Fri Aug 20 14:43:37 2021 +0800 .azurepipelines: Add UefiPayloadPkg in gate-build-job.yml and CISetting.py Add UefiPayloadPkg in gate-build-job.yml to enable Core ci for UefiPayloadPkg. Add UefiPayloadPkg to supported Packages in CISettings. Cc: Sean Brogan Cc: Bret Barkelew Cc: Michael D Kinney Cc: Liming Gao Signed-off-by: DunTan Reviewed-by: Liming Gao commit 63fddc98e06c380e654b1cfbaf24b9fd922adfad Author: duntan Date: Fri Aug 20 14:43:36 2021 +0800 UefiPayloadPkg: Create .yaml file in UefiPayloadPkg Create .yaml file in UefiPayloadPkg to enable Core ci for UefiPayloadPkg Cc: Guo Dong Cc: Ray Ni Cc: Maurice Ma Cc: Benjamin You Signed-off-by: DunTan Reviewed-by: Liming Gao commit 12e33dca4c0612a0975265e5ba641c6261a26455 Author: Loo, Tung Lun Date: Tue Aug 17 15:43:12 2021 +0800 IntelFsp2Pkg: Support Config File and Binary delta comparison BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3567 This patch is to enable config editor to have a new feature that can spell out the delta between the default configuration files' data, such as YAML and BSF, against the data stored in the binary. This can help users understand and track the difference when modifications are made. Cc: Maurice Ma Cc: Nate DeSimone Cc: Star Zeng Cc: Chasel Chiu Signed-off-by: Loo Tung Lun Reviewed-by: Chasel Chiu commit b170806518c1e414939c8b085866544814e1ce8e Author: Mark Wilson Date: Fri Nov 13 08:05:18 2020 +0800 UefiCpuPkg: Clean up save state boundary checks and comments. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2956 In functions ReadSaveStateRegisterByIndex and WriteSaveStateRegister: * check width > 4 instead of >= 4 when writing upper 32 bytes. - This improves the code but will not affect functionality. Cc: Eric Dong Reviewed-by: Ray Ni Signed-off-by: Mark Wilson commit 3b3f88228812e2c642eea8746858a4dad928ebf7 Author: Marvin H?user Date: Mon Aug 9 14:09:25 2021 +0800 MdeModulePkg/PiSmmCore: Drop deprecated image profiling commands The legacy codebase allowed SMM images to be registered for profiling from DXE. Support for this has been dropped entirely, so remove the remaining handlers. Cc: Jian J Wang Cc: Hao A Wu Cc: Eric Dong Reviewed-by: Ray Ni Cc: Vitaly Cheptsov Signed-off-by: Marvin H?user commit cdda3f74a1327663a5d48cca13507085ba403af7 Author: Marvin H?user Date: Mon Aug 9 03:39:53 2021 +0800 UefiPayloadPkg/UefiPayloadEntry: Fix memory corruption UefiPayloadEntry's AllocatePool() applies the "sizeof" operator to HOB index rather than the HOB header structure. This yields 4 Bytes compared to the 8 Bytes the structure header requires. Fix the call to allocate the required space instead. Reviewed-by: Guo Dong Reviewed-by: Ray Ni Cc: Maurice Ma Cc: Benjamin You Cc: Vitaly Cheptsov Signed-off-by: Marvin H?user commit 5d34cc49d5d348012fe8acf9fb618826bd541a7c Author: Wenxing Hou Date: Tue Aug 24 16:11:11 2021 +0800 UefiCpuPkg/PiSmmCpuDxeSmm: Update mPatchCetSupported set condition REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3584 Function AsmCpuid should first check the value for Basic CPUID Information. The fix is to update the mPatchCetSupported judgment statement. Signed-off-by: Wenxing Hou Reviewed-by: Ray Ni Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Cc: Sheng W Cc: Yao Jiewen commit f0fe55bca4651734abf1752a1d7c69fb5bee00b9 Author: duntan Date: Fri Aug 20 13:04:29 2021 +0800 UefiPayloadPkg: Fix the build error when enable Core ci for UefiPayloadPkg V1: Add quotes when using $(ARCH) in .dsc and .fdf file. The quotes are added due to the way by which Core ci parse the .dsc file. Add UINTN in Hob.c to fix cast from pointer to integer of different size error. V2: Delete lines which reference ShellBinPkg.The pkg doesn't exist in edk2. Cc: Guo Dong Cc: Ray Ni Cc: Maurice Ma Cc: Benjamin You Signed-off-by: DunTan Reviewed-by: Ray Ni commit 9f3eda177a4b2d4a33ff1b0307cad42906396562 Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:29:48 2021 +0800 OvmfPkg/OvmfXen: add QemuKernelLoaderFsDxe Without QemuKernelLoaderFsDxe, QemuLoadKernelImage() couldn't download the kernel, initrd, and kernel command line from QEMU's fw_cfg. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3574 Signed-off-by: Gary Lin Acked-by: Anthony PERARD Reviewed-by: Philippe Mathieu-Daude Reviewed-by: Gerd Hoffmann Tested-by: Jim Fehlig commit 5b5f10d7465004e3e40ec1f50a3b490b4db595e7 Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:31:15 2021 +0800 OvmfPkg/SmmControl2Dxe: use PcdAcpiS3Enable to detect S3 support To avoid the potential inconsistency between PcdAcpiS3Enable and QemuFwCfgS3Enabled(), this commit modifies SmmControl2Dxe to detect S3 support by PcdAcpiS3Enable as modules in MdeModulePkg do. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3573 Signed-off-by: Gary Lin Reviewed-by: Gerd Hoffmann Reviewed-by: Jiewen Yao Tested-by: Jim Fehlig commit 52e2dabc0f8d3af09c213072ce8ba734302f585d Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:31:14 2021 +0800 OvmfPkg/PlatformBootManagerLib: use PcdAcpiS3Enable to detect S3 support To avoid the potential inconsistency between PcdAcpiS3Enable and QemuFwCfgS3Enabled(), this commit modifies PlatformBootManagerLib to detect S3 support by PcdAcpiS3Enable as modules in MdeModulePkg do. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3573 Signed-off-by: Gary Lin Reviewed-by: Gerd Hoffmann Reviewed-by: Jiewen Yao Tested-by: Jim Fehlig commit 28152333bccb778b62e6e97446b28bfa0e92ef82 Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:31:13 2021 +0800 OvmfPkg/LockBoxLib: use PcdAcpiS3Enable to detect S3 support To avoid the potential inconsistency between PcdAcpiS3Enable and QemuFwCfgS3Enabled(), this commit modifies LockBoxLib to detect S3 support by PcdAcpiS3Enable as modules in MdeModulePkg do. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3573 Signed-off-by: Gary Lin Reviewed-by: Philippe Mathieu-Daude Reviewed-by: Gerd Hoffmann Reviewed-by: Jiewen Yao Tested-by: Jim Fehlig commit cb0d24637dfdd869618b9635dfb8e3b0746393a6 Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:31:12 2021 +0800 OvmfPkg/OvmfXen: set PcdAcpiS3Enable at initialization There are several functions in OvmfPkg/Library using QemuFwCfgS3Enabled() to detect the S3 support status. However, in MdeModulePkg, PcdAcpiS3Enable is used to check S3 support. Since InitializeXenPlatform() didn't set PcdAcpiS3Enable as InitializePlatform() did, this made the inconsistency between drivers/functions. For example, S3SaveStateDxe checked PcdAcpiS3Enable and skipped S3BootScript because the default value is FALSE. On the other hand, PlatformBootManagerBeforeConsole() from OvmfPkg/Library called QemuFwCfgS3Enabled() and found it returned TRUE, so it invoked SaveS3BootScript(). However, S3SaveStateDxe skipped S3BootScript, so SaveS3BootScript() asserted due to EFI_NOT_FOUND. This issue mainly affects "HVM Direct Kernel Boot". When used, "fw_cfg" is enabled in QEMU and QemuFwCfgS3Enabled() returns true in that case. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3573 Signed-off-by: Gary Lin Reviewed-by: Anthony PERARD Reviewed-by: Gerd Hoffmann Reviewed-by: Jiewen Yao Tested-by: Jim Fehlig From xen-devel-bounces@lists.xenproject.org Thu Sep 02 11:55:55 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 11:55:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177266.322602 (Exim 4.92) (envelope-from ) id 1mLlJy-0006XS-EE; Thu, 02 Sep 2021 11:55:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177266.322602; Thu, 02 Sep 2021 11:55:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLlJy-0006XL-Af; Thu, 02 Sep 2021 11:55:54 +0000 Received: by outflank-mailman (input) for mailman id 177266; Thu, 02 Sep 2021 11:55:53 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLlJx-0006XF-4F for xen-devel@lists.xenproject.org; Thu, 02 Sep 2021 11:55:53 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id b8275c86-0be4-11ec-ae59-12813bfff9fa; Thu, 02 Sep 2021 11:55:51 +0000 (UTC) Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-am5eur02lp2055.outbound.protection.outlook.com [104.47.4.55]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-18-RYp2SUa4Ou-VaJC3qdMmzA-1; Thu, 02 Sep 2021 13:55:50 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR04MB2957.eurprd04.prod.outlook.com (2603:10a6:802:4::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.24; Thu, 2 Sep 2021 11:55:48 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4478.021; Thu, 2 Sep 2021 11:55:48 +0000 Received: from [10.156.60.236] (37.24.206.209) by PR0P264CA0175.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:1c::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Thu, 2 Sep 2021 11:55:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b8275c86-0be4-11ec-ae59-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1630583751; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=418HGwJdiDk5kaVjZbCAcJQlFgBBx59CLraGTj8kY8c=; b=O4o1b04w8Scij33BkNOESN6cWKf9fTcu6WIVZer4PBC9ypjhbGxONSvEctwhztHVsvT8Jf PEMxT0ECM/Ib9aCr1gsV62T8xVlZNv53AJj5Fakbq5mR0OBICXnZZsWvcExv4mgtjqWmL8 TOtvfKS2f3Xpc/Rke+7ZeBPMAapJk/8= X-MC-Unique: RYp2SUa4Ou-VaJC3qdMmzA-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aFGRxR7iaqRPWBLUmJ5rm3tv8OOSUL5kCbziQHwnDLcgFFsOhRIus7T2K9jfZzdDbbNPk8BLE7uBXcCbcOT5v2Fd3yvpF4w6EkGEL31Fke5AqYOd3YarUOlHcTE5v049AOK9cqLVGhVOOZzGYFknvwmbFTJyg618n6SV+gtjD3aXhDz0Tm3/pbDu+zL88RKmyxF3WOUubxnMaIrm048E2bZCR7ugCg4PgjlmnREnctsjpVgdFPQr3x1HFRc09slFS35QjbDro+hjaJQkvYfxuLP88Jm1oXo66AvM1qxohC55Fo8oz/4a0yiKGvO3MtlWml5i79Wi0+sWijqgabuysQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=418HGwJdiDk5kaVjZbCAcJQlFgBBx59CLraGTj8kY8c=; b=RkTumLLJ/5Gwjhl6PpE3OZL2+P1ex7wrU+hsi/Kle2d6nNw//5sSwGvr+L8UUjmTNRToeoa/D5BrfdKwwWnORzimetg5Lmhx7+z97+/0iv5UxLzTY62W+oRr0bhZ3ed06vCgu+cWwhuNr0VQNhRdX0Y+yzYkk87lfnahkkd/42hs65TSHVQjM4/fFaHm1al6oounc1nLi/xD46DhIJuo5AveBaD7AmhlXvab4oNsQDyedA0EQS/1SkxSHtj0vvEgTdRtz2MOPhp2DvGecwkhausvSIMCw/kLXP5Md9Y/TWB/hRPGmMD7wZkEn009M1g+IWEqKbI5bmucIrpwxrM9/g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=suse.com; Subject: Re: vcpu_show_execution_state() difference between Arm and x86 To: Julien Grall Cc: "xen-devel@lists.xenproject.org" , Stefano Stabellini , Andrew Cooper , Bertrand Marquis References: <85dc06ff-04df-2148-81c5-26bd25d1142f@suse.com> <8f295eeb-e8f2-a115-3f83-60922d0fe5f9@xen.org> <00457189-6ab5-24e4-b2ec-1050ebec67eb@suse.com> From: Jan Beulich Message-ID: Date: Thu, 2 Sep 2021 13:55:45 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PR0P264CA0175.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:1c::19) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c4b381b0-ea66-45ae-9969-08d96e089a4f X-MS-TrafficTypeDiagnostic: VI1PR04MB2957: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 36UspjKN61wDRsP5MhevNPA13Fytw4OlwbhzrQhHOHoEelmsYTi4wV470Rj0A/maTgHB+JaO98SFarzANhclKEGn10BZ2s+SNeC5GWWUsQpeDynZk54/kVxZtWt6/rJuwZ4Nr8xmDWdImzZjSdpuumSTGiT3LgLyDevAVXJQW0BflnVnvHRGlFTyQIKWcdoRa34Kdh0F9E3oIH4VUkcZdHnJychzgJAWE5JY2kMyHJsyBIp8xpUAL2kUCT0VnXToKcgEjLwDtSiOvpBSbXu3svsqiF6E8sHT20ODZeIS1YYxlCGma5imJxM0YwSt7B08CrPJ6BkDw+m+2illOGgh39TbK7sbEBaM4eq/uphccxWYgIphZzcSUX9BCAlMSHQVWSg+yWeCR4wfWHRwrMtfw1kJa68rBGXLUXO0k8b5DWoNYrdb1oAgmWOBotAKo7mHoOHj8UW+Yex0ey8O4YZ9K1IHQ55kPCMa3VOGcfuQnIx4FtB3IpS8DErDm7X6Nuv2nHq9Ou7xSyJdlYrCndoVvmTYljc59aoD+oIXfg41DalCd9uVG9YUeeVUej5KCVw2IY1YuiuyAt3R5pzCGwzOTfSlE2DUa74vEy9WP7GoZ+T9ub37fdJm02YV6EZbbSSmiYBL5/99qNZQOGC/FEqyQJtiyWJkwv4U/1Mse9snS+vdRm3HNJCHTyy/qgZM9G8wwrM4mpwAU4V91XR+qjVT4/LfHXOMv3Y4M/0ApwoPvIE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(2906002)(38100700002)(6486002)(8676002)(31686004)(66946007)(8936002)(4326008)(26005)(186003)(66476007)(66556008)(53546011)(86362001)(5660300002)(83380400001)(508600001)(16576012)(316002)(6916009)(956004)(36756003)(2616005)(31696002)(54906003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZWczWklPSExhMEQyTm84YXFNMFJTalIwU3FPMjJvNU5kalVDWkpzTFlhMGRH?= =?utf-8?B?NE9RdklDZnZMUUFEZ1RaRU5lYkdPNGJObmc3Q1k1L0tGTHNIOE1UY1BseUlG?= =?utf-8?B?ZXl3Y1dvaS9nOXRvRW02ODBHNmh6MVF2SUVtOFFVcGZqZ0R3Y05oazkvOHkv?= =?utf-8?B?eEk2ei9nWjZiRENMWXYzbHdvR3JKWk1VOXVISER3MFZMRnRyY0pmeUtlY1RF?= =?utf-8?B?NzB1NDQ0dkZCZnN6WU9GQ3ZweS94WkxENU9OdngyUkRYOGM1UlZibzhBSlJ0?= =?utf-8?B?a2hlVnBpby9jbGd2NnJ1RDYwUytzRjkrazVET0dWZ1V1M0ZacmtSQU52d1ZD?= =?utf-8?B?ZVFKYXNaRWJqQVFnL29xbTBmRUpPOTlkekI4dEE3OWdrcThKMnVQVFZaclZW?= =?utf-8?B?TmlHOFlpb3BXUWpNeVBuS2l4aEsrUmxPRVRZL0F0NjVNOHZPMk5EK2tDQjJG?= =?utf-8?B?MlRxZWRvT3VxeWtyR3lmQnpwSkpKd1dQZm5oY1FMUU51OTBMTEVBcGtjM2dm?= =?utf-8?B?WCtVVG1oZzJvR1Ird1paaCtQaE5hRGFGdG9lSXpybEhVTjA5Y1J4SS90dnkz?= =?utf-8?B?LzRsUlF0OSt2bnFjTmNZUDd4SnBleEFTQUZjbWNaSG85MTErNVFzUDR1Smsx?= =?utf-8?B?dlMvcTF0dHRTdVBBR1BrV2xQYkVuK1dGM3hxZlNjQ1MvZGlITFZtSTVmc2Fw?= =?utf-8?B?SUp1bmNiTEtIUTl1d2pyZXZoL3NuZGo3bUE2WlkrcjFndjJ0UG1PaXZWdmpm?= =?utf-8?B?b25lWXVVRlBUaW9QVXRJUy85L3NvSWd5R0Z4WkxYU1dzWWNDMXgvSlZHSEdl?= =?utf-8?B?V1FST2NXWS96RndiN1hhUkVycTdZelIrOTlHOFJvNGlYVWVYVjQ1TVdaRlZB?= =?utf-8?B?TkIvTW5ObjVNK1dUYWh1eThtd215ajNzd2xFUnJUcEtkdWNSL05VUVlQYkYx?= =?utf-8?B?Q0xQallMUno5ak4vZDFWUzJGajhaMmx0Y3pWUC9nemRnVjFlQXJzd1g3Y3Fy?= =?utf-8?B?OTFNdDNKUno4cDJlVU1XNExVdFdIckFFNTFtQ1A0eTQyWjlvRkY3WWtXRFg5?= =?utf-8?B?dzN3dWJuemFkWUl0NUFOYk9RS3ViS0oxRE1KUjNzTzNMejBNYmsxQjhHMFRY?= =?utf-8?B?S0xuWmhqN0Q2NFJWUHhXQ0lGYTJIc1hBaHdtY3dRdzhsU1R3RndXaXUzcHpQ?= =?utf-8?B?a2lHT1dFcTJXMXpWYmVrcHNYWHYvVzVSL1U1MnlndWtxVVF0R1NUZ0NucHVm?= =?utf-8?B?NW5XUGxIcm9obE9BUVVhWjE3TXRQNm1VNHptOSt6blF5Y1FpZ1NQc2NzOVRB?= =?utf-8?B?bGowN0pBem1LSnZ4RU5LYVExcHQ0K2xZNkIrMUJZL1JCNU1yNmo1WFZNby90?= =?utf-8?B?bTVGcmpESkc4cEVZT256cW10cXhjNlRzOUhKd1hLVHJWUTNXNGlBakhWWTJl?= =?utf-8?B?ZTNEVmlzWlNQV0x2WnkvTVZidDdrems4Y3FhQkVxU0FjVkZvVnNqeGlVTXlX?= =?utf-8?B?MWw3RVg0ZlRKVTloREQyRTNMOWtMN0dxMksxdUpqNy9PaUkyQlVPVHJid3FJ?= =?utf-8?B?ZG40NFJ1Q3hRWUEzZGJhTWlBT2hYKzh1NEdOeVpCNGNELzlMSkpwVUZIN3pm?= =?utf-8?B?SUJOSTJoajFkWEJiN0RtMFBQV1hyV0xaK0o0RWd2NkgvcVZidVREdjdaZmhJ?= =?utf-8?B?NDN4L1BZTUdxd3draHZZdXErSjZsNGxXSWU0b0E0VE5PVWE0OXVXMHRIVVVj?= =?utf-8?Q?4k5g4Y07Tmz5Idic8B6TzOTu8SUayNWPfmUAFxp?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: c4b381b0-ea66-45ae-9969-08d96e089a4f X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Sep 2021 11:55:47.9506 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bvfWUH1MUpTW2a9121SkwGm4b1y+LTfkMh4i/kyLAplYJKa5vlAbZhHZ+N5ArkjEjmTZljSYvfncpo5Z+4TGPA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB2957 On 02.09.2021 13:48, Julien Grall wrote: > On 02/09/2021 07:45, Jan Beulich wrote: >> On 01.09.2021 20:11, Julien Grall wrote: >>> I looked at the original commit to find out the reason to use the >>> console lock. AFAICT, this was to allow console_force_unlock() to work >>> properly. But it is not entirely clear why we couldn't get a new lock >>> (with IRQ enabled) that could be forced unlocked in that function. >>> >>> Can either you or Andrew clarify it? >> >> AIUI any new lock would need to be IRQ-safe as well, as the lock >> would be on paths taken to output stuff when the system crashed. > > Hmmm... Just to confirm, what you are saying is some of the callers of > vcpu_show_execution_state() & co may do it with IRQ-disabled. Is that > correct? No, that's not what I was saying. What I was saying is that crash- safety requires an IRQ-safe lock, because the approach taken here should imo match that in show_execution_state(). And _that_ function can be called with IRQs in either state. > I have tried to play with it on Arm but then I realized that > check_lock() is not properly working on Arm because we don't call > spin_debug_enable() at boot. :/ So it would make sense why we never saw > any issue there... Oops. >> Hence it would be pointless to introduce yet another lock when the >> one we have is already good enough. But I may be missing aspects, >> in which case I'd have to defer to Andrew. >> >>> The other solution I can think off is buffering the output for >>> show_registers and only print it once at the end. The downside is we may >>> not get any output if there is an issue in the middle of the dump. >> >> Indeed; I'd prefer to avoid that, the more that it may be hard to >> predict how much output there's going to be. > > And it is not going to work as we couldn't grab the P2M lock with IRQ > disabled. > > On Arm, the only problem is going to be the P2M lock for dump the guest > trace. A possible controversial approach for Arm is to just not dump the > guest stack or move it outside of the new lock and dump when IRQ is > enabled (I am not aware of any places where the guest stack will be > dumped and we have IRQ disabled). Well, you could certainly omit the stack dump on Arm. I for one find it quite useful every now and then. On x86, that is. Jan From xen-devel-bounces@lists.xenproject.org Thu Sep 02 12:16:07 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 12:16:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177278.322612 (Exim 4.92) (envelope-from ) id 1mLldR-00011f-FV; Thu, 02 Sep 2021 12:16:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177278.322612; Thu, 02 Sep 2021 12:16:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLldR-00011Y-CW; Thu, 02 Sep 2021 12:16:01 +0000 Received: by outflank-mailman (input) for mailman id 177278; Thu, 02 Sep 2021 12:16:00 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLldQ-00011S-G5 for xen-devel@lists.xenproject.org; Thu, 02 Sep 2021 12:16:00 +0000 Received: from smtp-out1.suse.de (unknown [195.135.220.28]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id fa0ee40e-376a-44db-94ae-5e5dd74d07e5; Thu, 02 Sep 2021 12:15:59 +0000 (UTC) Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 8C175224E2; Thu, 2 Sep 2021 12:15:58 +0000 (UTC) Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap1.suse-dmz.suse.de (Postfix) with ESMTPS id 5B07813424; Thu, 2 Sep 2021 12:15:58 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap1.suse-dmz.suse.de with ESMTPSA id jFKRFH7AMGGPAgAAGKfGzw (envelope-from ); Thu, 02 Sep 2021 12:15:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fa0ee40e-376a-44db-94ae-5e5dd74d07e5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1630584958; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=nOOWdLJ2NSTnwVkgHcKg56yCR+4F5c9UzSH5e1+2gTo=; b=CbU7IDOjKXbwq5k8Byghe8I5ggchWVyFVWa2h4ZRPOhA3zMTobOgaUEjk/EfjrjYFme12q RIoDNlhXGzcEu8fkM3m9TZV42bB0/yJC/fpxtWF16i2RfgykJLQpbMr7UQ/MK2bgi/KXFP HLS2YH5Abv9S7ejRSuRcxbKisbpRuB4= To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <5972ce4c-bdb0-6d07-afad-cf4dd5615488@suse.com> <2cd2d15a-01f7-6bbf-86a8-85437991da7d@suse.com> From: Juergen Gross Subject: Re: [PATCH v2 0/6] x86/PVH: Dom0 building adjustments Message-ID: Date: Thu, 2 Sep 2021 14:15:57 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <2cd2d15a-01f7-6bbf-86a8-85437991da7d@suse.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="XBwThObvyTg0stESRzAFiEtMk83rbO7Bl" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --XBwThObvyTg0stESRzAFiEtMk83rbO7Bl Content-Type: multipart/mixed; boundary="8Vw3qpsNEgCUuknWaRKx6oCBIYRG4u23m"; protected-headers="v1" From: Juergen Gross To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Message-ID: Subject: Re: [PATCH v2 0/6] x86/PVH: Dom0 building adjustments References: <5972ce4c-bdb0-6d07-afad-cf4dd5615488@suse.com> <2cd2d15a-01f7-6bbf-86a8-85437991da7d@suse.com> In-Reply-To: <2cd2d15a-01f7-6bbf-86a8-85437991da7d@suse.com> --8Vw3qpsNEgCUuknWaRKx6oCBIYRG4u23m Content-Type: multipart/mixed; boundary="------------C99582B477A2C3CE5839A164" Content-Language: en-US This is a multi-part message in MIME format. --------------C99582B477A2C3CE5839A164 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 02.09.21 13:42, Jan Beulich wrote: > On 02.09.2021 10:30, Jan Beulich wrote: >> The code building PVH Dom0 made use of sequences of P2M changes >> which are disallowed as of XSA-378. First of all population of the >> first Mb of memory needs to be redone. Then, largely as a >> workaround, checking introduced by XSA-378 needs to be slightly >> relaxed. >> >> Note that with these adjustments I get Dom0 to start booting on my >> development system, but the Dom0 kernel then gets stuck. Since it >> was the first time for me to try PVH Dom0 in this context (see >> below for why I was hesitant), I cannot tell yet whether this is >> due further fallout from the XSA, or some further unrelated >> problem. Dom0's BSP makes it all the way through to entering the >> idle loop while all APs are still in VPF_down. >=20 > This last part of the mystery is now solved: By cloning from my PV > .config, I've inherited the X86_X2APIC=3Dn that I have there. Yet > ACPI's MADT gets populated with only x2APIC entries when building > Dom0, which such a kernel would mostly ignore (except for logging). > IOW in a way this was indeed a missing select, except that what's > needed wouldn't quite work yet: >=20 > --- a/arch/x86/xen/Kconfig > +++ b/arch/x86/xen/Kconfig > @@ -83,6 +83,6 @@ config XEN_PVH > bool "Xen PVH guest support" > depends on XEN && XEN_PVHVM && ACPI > select PVH > - def_bool n > + select X86_X2APIC if XEN_DOM0 > help > Support for running as a Xen PVH guest. >=20 > This is because, as mentioned, XEN_DOM0 gets turned off when XEN_PV > is off. Whereas x2APIC isn't strictly needed for DomU afaics > (MADT gets populated with LAPIC entries only), so the "select" also > shouldn't be unconditional. Correct. We should rename XEN_DOM0 to XEN_DOM0_PV, and add a "real" XEN_DOM0. > While likely no-one will really care, I'd like to note that this > effectively means a 32-bit Linux PVH Dom0 would be impossible, as > X86_X2APIC depends on X86_64. This may want reflecting in the > eventual adjustment to the XEN_DOM0 dependencies. Indeed. Juergen --------------C99582B477A2C3CE5839A164 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Transfer-Encoding: quoted-printable Content-Description: OpenPGP public key Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy= cWx w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O= f8Z d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y= 9bf IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq= G7/ 377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR= 3Jv c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA= QIe AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT= hpw dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0= MbD 1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv= oPH Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v= 5QL +qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ= 2Vu IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC= QoL BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr= Wf0 teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC= /nu AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh= ITT d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm= XBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz= 80h SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC= AcD AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn= FOX gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1= jnD kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0= N51 N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l= otu fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1= tqS EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA= hsD BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3= g3O ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5= dM7 wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5= D+j LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm= V2x AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N= Eaw QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW= nHI s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR= wgn BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV= bVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk= pEd IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA= QAB wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw= Tbe 8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1= vJz Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8= VGi wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW= svi uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX= zXs ZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------C99582B477A2C3CE5839A164-- --8Vw3qpsNEgCUuknWaRKx6oCBIYRG4u23m-- --XBwThObvyTg0stESRzAFiEtMk83rbO7Bl Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmEwwH0FAwAAAAAACgkQsN6d1ii/Ey/a qAf+JRKKRtXuK5FRDM7fguBvJ+saHnpstIsdg3n0Prq5e8AguDaJnyBcjMM5cAXJa+k34dQbSqVA 85FM/c7n10ZoAjxh8qgiHXTdFOGsuGtugr/qlw5bFd5kA451tLemdZNGqs5VzVPsIK4BXeZACDxA sljFXh9CBoQwCN96BsIST2qvFx4YQ02la4QtFP0qgnOriy05gX0KfThxr1Bf7Tx7tdBHvnK2FmZ5 rR2YfZCvK12OiBgxzvNQeP4QkFc/BAsv5COzG3gTVerS+H7sjmjL+GIAv7vOgXZT9zZarQiLYzYB rUrulqOMBhHN7G3DeA38o0G8OOFiLXVfnxF0beqrbg== =gmi+ -----END PGP SIGNATURE----- --XBwThObvyTg0stESRzAFiEtMk83rbO7Bl-- From xen-devel-bounces@lists.xenproject.org Thu Sep 02 12:40:23 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 12:40:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177285.322624 (Exim 4.92) (envelope-from ) id 1mLm0l-0004UX-CA; Thu, 02 Sep 2021 12:40:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177285.322624; Thu, 02 Sep 2021 12:40:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLm0l-0004UQ-97; Thu, 02 Sep 2021 12:40:07 +0000 Received: by outflank-mailman (input) for mailman id 177285; Thu, 02 Sep 2021 12:40:06 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLm0k-0004TY-4t for xen-devel@lists.xenproject.org; Thu, 02 Sep 2021 12:40:06 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 23508811-42cd-4b50-9756-2a48b320094a; Thu, 02 Sep 2021 12:40:04 +0000 (UTC) Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-he1eur02lp2050.outbound.protection.outlook.com [104.47.5.50]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-14-DHg7L3bDPB-3bMkE29wI7w-1; Thu, 02 Sep 2021 14:40:02 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VE1PR04MB7360.eurprd04.prod.outlook.com (2603:10a6:800:1a3::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19; Thu, 2 Sep 2021 12:40:01 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4478.021; Thu, 2 Sep 2021 12:40:00 +0000 Received: from [10.156.60.236] (37.24.206.209) by AM0PR01CA0148.eurprd01.prod.exchangelabs.com (2603:10a6:208:aa::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Thu, 2 Sep 2021 12:40:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 23508811-42cd-4b50-9756-2a48b320094a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1630586403; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HvglPhIv0cC1gQHqWcWdOwMhFrpQApUA2uzO4pvexEw=; b=nURaxN0MNYy7pATnLGepX7Dm+vdX1wk4lN8snIJYnX0aB6dVdOG/iQb5B0zDkH4xEtlr7W 6+FwkPDuD1pbgo3KXT2RetbS1Z7FCZbicE//+2eTavZjjaaby9UkqtZOdKV22A5dBNQFB2 bIAm7sZxWikVDGjnafzrRvEPJcpZT9c= X-MC-Unique: DHg7L3bDPB-3bMkE29wI7w-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Z6v52/GYwaeFluSAUd4EEcyf5vIktYq0I2ZrFYAhpSENyEXK1mBBzj7bVPKcaERIQ1S2/s0wfEwdsD0/moENd1Mszb85D1Fyy3ozqaxzbKRSnZqUIOMcY+EMuwQU3zFczwUad7q8T12xxKHBmJ2O/wuJ+QY41Htecw69KVqPZDBlRzJMFTUVBU76gciafoClWIt51JuU2OHn2XBy493Ss/5d1Dqydfn6gx7HqmFFtguKji7pMn8ItepvLcLBg81poi8jKh3WagIs/pD0AZNhszyR1h1znpinNCMJbnjg6qD5ImIMmVf0d0TrrNnGqaZOd0szRQ/vUe24HU6FtqJs7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=HvglPhIv0cC1gQHqWcWdOwMhFrpQApUA2uzO4pvexEw=; b=LnsQd33BSrgFGrl4dKFyG4VcUfubkoDGGogpsNuhffHJz4D1VpHxChVV4/2zVswPJmuANp8Y1xgIh4i4PkNKMB1B78nECYFYgWoedTHFD9NLhoElCPVSEP7EkIixq8kQ5M0EA4I7ybymFRhZIpHdwzNf98gkrtTEN+u9roYP9pwWIewj18TZtQJcEUCnRNkFwCWBAZktpTGk1ukKRsRkLE+KBaI4aKaPDd2zxZd2fwc+S6kAG41IKZ2m322AFeCiJ0Wrar3yINw+o+oCyQakPIWpZOgJEEhBMYoCS9CMVG5XjzfPfrodiW/LOOcgJM6S75R7jUtry2QNA5o8LmDZjQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com; Subject: Re: [PATCH v2 0/6] x86/PVH: Dom0 building adjustments To: Juergen Gross Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , "xen-devel@lists.xenproject.org" References: <5972ce4c-bdb0-6d07-afad-cf4dd5615488@suse.com> <2cd2d15a-01f7-6bbf-86a8-85437991da7d@suse.com> From: Jan Beulich Message-ID: <90bad8ba-d816-b449-1c1c-07617ba6147f@suse.com> Date: Thu, 2 Sep 2021 14:39:58 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM0PR01CA0148.eurprd01.prod.exchangelabs.com (2603:10a6:208:aa::17) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c310b6bc-7534-44b0-a76d-08d96e0ec792 X-MS-TrafficTypeDiagnostic: VE1PR04MB7360: X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: rdCB8OrH2mk+bEkctaZ9M6Vri1CfEFipjt+/LnlU2n42tVjQPdwOOu/baiIA4LO0wn4SeLQr/ZKeq0NhzRM/AVnH8zX7b5aehCB6qG9Y8kLjxACw1syY4QJTaiUzalO+ScNlYiGsNFF5g5uzL9/wRGDFzYEBAKjvL03FDi7iGOA2MFc09yznWPeoA+t34wrgeYpk1uUfV8s9PjdxM5vJYiEU+VznJF5JD3X5xT6Einz7gys0LdZpHSjq89Tr65ObEODQpv32PwPrSxaiZKrl4dQ2YerrCpc3mMNzRuXhoKvMfXbdDIAHECtksJTGY56WcK2vHjK9VUBh0dh1RakFmSZ8Zjtpiy8kOr2Ax7Eoo8LE6w7OiMkJ6JWHmY+xfeZhXSNZCN2pr4fb1dXXpsDKvtJBFWxZpN7TzMa8MvG7Un85HZ0gMSsGrndpCciO0oJ0VcOCiPE7M3644kS0hphiRQhiNHv3VCc0O6//skbeW4otNRPXYDblOTq//YSQBYbBj6SVttPPBBFwQasWDHWO1DlFlZ9FhDXO5p1MhheyKb07dKrq5KySTTAzwpUcBJrZbPk5FvteFqLxdhRJjTqNV+Gw3bSIjrRTCs0u36kis8uiIh1ONlqalfkSi9jALlaIYqJXYl5//kyR3VFhaNG5Hv8Kg5FFpyBUXsm3ZrPODIA+AbP+kgq6EFHvNAmtDPfk8QX6Ghvnf3wdqi1l4Dre9A== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(396003)(136003)(346002)(376002)(39860400002)(26005)(186003)(2616005)(4326008)(6862004)(956004)(6636002)(6486002)(54906003)(5660300002)(31686004)(37006003)(38100700002)(66946007)(8936002)(16576012)(8676002)(31696002)(316002)(66556008)(66476007)(36756003)(53546011)(478600001)(2906002)(86362001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NFRZdmF3MjNyR1ZsSmtac0JJTDVoREFYSUlIb0xtNStRNzQwQ1ZPTlFiVnpF?= =?utf-8?B?aDFtVXpFdmFFMnBmcVc5VklCUUhzRHRoSnlDQ0tFYXErbk5pNi9PS2IwNWhS?= =?utf-8?B?K3VsaTVYQnUybDd0cHF4c1lkOXpiNFh4QXgzbTJlY0d5a2NnbHE3QmdrWERk?= =?utf-8?B?SHNza3RMUEFYM0JQQVlMUy80WmpxMm1tbnBvSVcxQk5sMlhPOGhIaFhwVC9z?= =?utf-8?B?OWZsTkpRa1RySG9yb2tzMDFIdlY2SEdXenBjK2VxdGVtSEY4OTB5cXhIV1lx?= =?utf-8?B?L3ZVbVBwaXM1UE5iTVZQVzBMckFVM2xkcGlNbTdXN2tyUGcza05LTW42dytw?= =?utf-8?B?Wmc2TTRMTWZmVFpsd055RDdNS1lNc0tlcVNsMzRWWEtwWTBjVHZNUzRwaXIr?= =?utf-8?B?QXlPUGZLc1laRDd0OWRjNmhWd2lFbkd4dHVlbmtEWVlORER0YjRVWFdXRnpG?= =?utf-8?B?c3k0L011NG5XdDdiaEFlaWYvUTRITWI2TDA2NUl4RmJOL2lmL2U0Q1lUK1NU?= =?utf-8?B?bHRCRkUra0tja0FXMmFXOGNmTkExUE05TlpQWHFUWndBbUJibUxLNjNocGxC?= =?utf-8?B?WjdLQWQrZW5rVEo1bHJZcVBHNTJieE1DeEx1aXVSK0E0MmcrRHJXVCsxVU5n?= =?utf-8?B?UE5HK2U0NTFEN3djTjFZVzNyZVpmM2tKTHFLRS8zQWZnZm8xQ3pNaEd3eXpP?= =?utf-8?B?ZG45ejI0ZDRvamlSTnh1aFhhNjZlUjU1clF1NDdISmZLUXlLZ0hWS0M4bzdP?= =?utf-8?B?RDNGMHhjVUp4OWxUbTYzUlJ5SU01aFk0K0d0b3l3L1hGMXdRR1lSaXE0Y2Vq?= =?utf-8?B?b2NBQmlkSjhRWmdLdm9QTTdxVk4xUnp2dTNBUHNzazU0cTgvdS9LWDgrWmVv?= =?utf-8?B?K0tLT0taVlNZY3I1a2NqOHVCN0EzS2xoQzRpNUE2NGNYSktMSmljbm9NaHcx?= =?utf-8?B?TDZXT0N1RUY2VXp4bmlLejJJQlU2SW9oYkNGVUxEbUF5NFBmcEVBOVdwbDJs?= =?utf-8?B?blVSaUovK1Q1VFNJaHgvU1p0blA5YnMrQ2U3ZERMMlRrVVRqd3E1MGNmMUNF?= =?utf-8?B?Q2NxRWZGeTlzVEczYVdqdkxWa3dWa1hGbElNOUxRYkk5YzNHWmhQYW9Mb2Z6?= =?utf-8?B?ZFM5QnlFakFFanRtbXpDS2RoR21zcDc4eWVkMTBaMEw5NUhRNWlVMHYwVk9u?= =?utf-8?B?TlpldVFhRFZld2ZvNmVjUnVJOENzYms2YmtVSEVpUFVvVExUSWUwQndsL3hu?= =?utf-8?B?OFBXMVl0ZWwwODFSZEF1L1FUSmFQcGhkOHQwWGdQWFpBMmhVdmJseVFZNGRF?= =?utf-8?B?YndZVldudXc4RmlpR2owR09oemRrT213dmFuTnBaNjNaVVBrWXJsMldqY0NK?= =?utf-8?B?NmgzN1draXo4UEI4QVYxUFN3VnkwT1o1RDhPaE5tU2dML1I5K3VqakxmdXJI?= =?utf-8?B?QlpYMXlQSFZBRy9jVDg2dHNXU0xHMkI3SUM4SHZPRnRoOUxpUWdnVW0rR2Jy?= =?utf-8?B?VlF1TTJnRnFpOTcwanUxK2p4WGdxV0hTS3k0UkpyMCtlWWNEL2xEVHYyQjJL?= =?utf-8?B?VTdMSG9WYXhCMVgzeHdybkhabkIvclh0SlZVeVJnRzlpSjVNSTRFdGhJWUoy?= =?utf-8?B?S3VNRkdvd0ZpNHVISFRCZXNiYk1hSXlmckZadDR1VlhXVFFOMjAxYU1uUnBV?= =?utf-8?B?a3hBVVAxNDJmOGt2elA1QkUxYjNDK3gxY3M2YTJkMjhtblVSSlFvcWYyK3Bv?= =?utf-8?Q?hkESyDZF/1hBomtz2sDsD2gRTSDKtg026Jzltu/?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: c310b6bc-7534-44b0-a76d-08d96e0ec792 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Sep 2021 12:40:00.7959 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: poM49VxOng+SzLWmdmziG3BY1ouHjLlrPZ3iv9Hit9WrU0E7Cb+llGzdC6Zgmol0mMubuakT7RLvLJg6nH5VdQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB7360 On 02.09.2021 14:15, Juergen Gross wrote: > On 02.09.21 13:42, Jan Beulich wrote: >> On 02.09.2021 10:30, Jan Beulich wrote: >>> The code building PVH Dom0 made use of sequences of P2M changes >>> which are disallowed as of XSA-378. First of all population of the >>> first Mb of memory needs to be redone. Then, largely as a >>> workaround, checking introduced by XSA-378 needs to be slightly >>> relaxed. >>> >>> Note that with these adjustments I get Dom0 to start booting on my >>> development system, but the Dom0 kernel then gets stuck. Since it >>> was the first time for me to try PVH Dom0 in this context (see >>> below for why I was hesitant), I cannot tell yet whether this is >>> due further fallout from the XSA, or some further unrelated >>> problem. Dom0's BSP makes it all the way through to entering the >>> idle loop while all APs are still in VPF_down. >> >> This last part of the mystery is now solved: By cloning from my PV >> .config, I've inherited the X86_X2APIC=n that I have there. Yet >> ACPI's MADT gets populated with only x2APIC entries when building >> Dom0, which such a kernel would mostly ignore (except for logging). >> IOW in a way this was indeed a missing select, except that what's >> needed wouldn't quite work yet: >> >> --- a/arch/x86/xen/Kconfig >> +++ b/arch/x86/xen/Kconfig >> @@ -83,6 +83,6 @@ config XEN_PVH >> bool "Xen PVH guest support" >> depends on XEN && XEN_PVHVM && ACPI >> select PVH >> - def_bool n >> + select X86_X2APIC if XEN_DOM0 >> help >> Support for running as a Xen PVH guest. >> >> This is because, as mentioned, XEN_DOM0 gets turned off when XEN_PV >> is off. Whereas x2APIC isn't strictly needed for DomU afaics >> (MADT gets populated with LAPIC entries only), so the "select" also >> shouldn't be unconditional. > > Correct. > > We should rename XEN_DOM0 to XEN_DOM0_PV, and add a "real" XEN_DOM0. Actually, as I have just found, the lack of XEN_DOM0 _is_ a problem: xen_initial_domain() gets hardcoded to 0 without it. I'll have to make a(nother) patch along the lines of what you suggest; hvc-xen and "earlyprintk=xen" also don't really work together, because the first thing xenboot_write_console() does is a !xen_pv_domain() check. Jan From xen-devel-bounces@lists.xenproject.org Thu Sep 02 12:50:16 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 12:50:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177291.322635 (Exim 4.92) (envelope-from ) id 1mLmAV-00068L-AS; Thu, 02 Sep 2021 12:50:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177291.322635; Thu, 02 Sep 2021 12:50:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLmAV-00068E-7H; Thu, 02 Sep 2021 12:50:11 +0000 Received: by outflank-mailman (input) for mailman id 177291; Thu, 02 Sep 2021 12:50:10 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLmAU-000688-5z for xen-devel@lists.xenproject.org; Thu, 02 Sep 2021 12:50:10 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLmAR-0004ce-Iz; Thu, 02 Sep 2021 12:50:07 +0000 Received: from 54-240-197-224.amazon.com ([54.240.197.224] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1mLmAR-0008LL-CW; Thu, 02 Sep 2021 12:50:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=Y/sEGRohL9Kj4xLlhQ4GFVhQuLZvKB8nlgyOX3/T2lc=; b=u7CkeW8IlR6UJuC+kaZwH+r2Co OXvkYJ0mzeo/66XfzGgSioiS6duz2zqntjjfXGAHoqukVrImoRyiV8v973rrVHbzUx8kr7hhjTKAH +DfQl0F7TRTTKHe8bKiNLMUBfdheo5KsCg8DKJC8VZrBGh82T7rq49qJcvPG2D4yGi/4=; Subject: Re: [PATCH v2] xen/arm64: Remove vreg_emulate_sysreg32 To: Michal Orzel , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Volodymyr Babchuk , bertrand.marquis@arm.com, Ash Wilding , Ian Jackson References: <20210729104258.6320-1-michal.orzel@arm.com> <4a5ac822-3078-de0e-8f84-6881d47ad3eb@xen.org> <8974fc82-94c1-ef85-153c-0923f5faf331@arm.com> From: Julien Grall Message-ID: Date: Thu, 2 Sep 2021 13:50:05 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <8974fc82-94c1-ef85-153c-0923f5faf331@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit On 01/09/2021 10:38, Michal Orzel wrote: > Hi Julien, Hi Michal, > On 06.08.2021 13:12, Julien Grall wrote: >> >> >> On 29/07/2021 12:47, Michal Orzel wrote: >>> Hi Julien, >> >> Hi Michal, >> >>> On 29.07.2021 13:20, Julien Grall wrote: >>>> Hi Michal, >>>> >>>> On 29/07/2021 11:42, Michal Orzel wrote: >>>>> According to ARMv8A architecture, AArch64 registers >>>>> are 64bit wide even though in many cases the upper >>>>> 32bit is reserved. Therefore there is no need for >>>>> function vreg_emulate_sysreg32 on arm64. This means >>>>> that we can have just one function vreg_emulate_sysreg >>>>> using new function pointer: >>>>> typedef bool (*vreg_reg_fn_t)(struct cpu_user_regs *regs, >>>>>                                 register_t *r, bool read); >>>>> >>>>> Modify vreg_emulate_cp32 to use the new function pointer >>>>> as well. >>>>> >>>>> This change allows to properly use 64bit registers in AArch64 >>>>> state and in case of AArch32 the upper 32 bits of AArch64 >>>>> registers are inaccessible and are ignored(D1.20.1 ARM DDI 0487A.j). >>>> >>>> What you wrote only says that the bits are ignored. It doesn't say whether the bits will be 0. >>>> >>>> They are probably, but as I wrote yesterday, I couldn't confirm it. >>>> >>> Should I then remove this part of the commit or write below?: >>> "We can assume that those bits will be 0 but the architecture >>> reference manual does not clarify this." >> >> There was some back and forth on security@xen.org about this. I will summarizing the discussion here as we considered this was a just a bug. >> >> I wasn't looking at the correct section in the Arm Arm. There is a paragraph clearly describing the expected behavior in a different section (thanks Ash for the pointer!). Per section D1.19.2 in DDI 0487F.c: >> >> " >> If the general-purpose register was accessible from AArch32 state >> >> The upper 32 bits either become zero, or hold the value that the same architectural register held before any AArch32 execution. The choice between these two options is IMPLEMENTATION DEFINED, and might vary dynamically within an implementation. Correspondingly, software must >> regard the value as being a CONSTRAINED UNPREDICTABLE choice between these two values. >> >> This behavior applies regardless of whether any execution occurred at the Exception level that was using AArch32. That is, this behavior applies even if AArch32 state was entered by an exception >> return from AArch64 state, and another exception was immediately taken to AArch64 state without any instruction execution in AArch32 state. >> " >> >> So we can't assume the top 32-bits are zeroed unless the hypervisor ensured they were. Today, we don't have that guarantee in Xen. >> >> This needs to be fixed. The two approachs we discussed are: >>    1) Update set_user_reg() to zero the top 32-bit. We have a couple of places using directly the fields xN. So we would need to switch them to use set_user_reg() >>    2) Only saving/restoring the bottom 32-bit when entering/leaving the hypervisor. >> >> At the moment, my preference goes towards the latter because we don't risk to introduce new place where set_user_reg() is not used. >> >> I have quickly hack the entry path. This would look like: >> >> diff --git a/xen/arch/arm/arm64/entry.S b/xen/arch/arm/arm64/entry.S >> index fc3811ad0ad5..65e24c88b059 100644 >> --- a/xen/arch/arm/arm64/entry.S >> +++ b/xen/arch/arm/arm64/entry.S >> @@ -111,6 +111,11 @@ >>   */ >>          .macro  entry, hyp, compat, save_x0_x1=1 >>          sub     sp, sp, #(UREGS_SPSR_el1 - UREGS_LR) /* CPSR, PC, SP, LR */ >> +        .if \compat == 1 /* AArch32 mode */ >> +        /* Clobber the top 32-bit of the registers */ >> +        mov    w0, w0 >> +        mov    w1, w1 >> +        .endif >>          push    x28, x29 >>          push    x26, x27 >>          push    x24, x25 >> >> I haven't looked whether this can be optimized or the exit path would be easier to modify. >> >> Anyway, this is not a new bug so I would be fine to get this patch merged first. Although, I think this wants to be fixed for xen 4.16 (CCing Ian to track it). >> >> I will try to find sometimes in the next couple of weeks to fix it and have another review of this patch. >> > > As the 4.16 release is getting closer I wanted to ask whether you need help with creating a pre-work patch so that this patch can be merged. Sorry I haven't looked at the bug yet. I don't think the bug I reported necessarily needs to go first. This is not a new bug and AFAICT your patch is not going to make it worse than the current state. Your patch needs to have an updated commit message summarizing what we discussed and a second review. No need to resend a patch for the updated commit message, this can be discussed here and updated on commit (I assuming there is no other comments). > I believe this patch wants to be merged for 4.16 as the other sysreg related patches are merged already, so I'm offering a help. If you have spare time that would be great. There are a few bits I wanted to look other than the entry place: - The DOMCTL that update the context: I believe we may need to zero to top bits - hypercall continuation (see hypercall_create_continuation) - multicall For 4.16, the entry (or exit) is probably going to be a good step. We can look at the rest for 4.17. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Sep 02 13:36:14 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 13:36:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177300.322652 (Exim 4.92) (envelope-from ) id 1mLmsw-0002dq-44; Thu, 02 Sep 2021 13:36:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177300.322652; Thu, 02 Sep 2021 13:36:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLmsw-0002dj-0z; Thu, 02 Sep 2021 13:36:06 +0000 Received: by outflank-mailman (input) for mailman id 177300; Thu, 02 Sep 2021 13:36:05 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLmsv-0002dc-90 for xen-devel@lists.xenproject.org; Thu, 02 Sep 2021 13:36:05 +0000 Received: from mail-pj1-x1034.google.com (unknown [2607:f8b0:4864:20::1034]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id c8100bc7-347c-477d-b54e-1199acc24b65; Thu, 02 Sep 2021 13:36:04 +0000 (UTC) Received: by mail-pj1-x1034.google.com with SMTP id j10-20020a17090a94ca00b00181f17b7ef7so1469364pjw.2 for ; Thu, 02 Sep 2021 06:36:04 -0700 (PDT) Received: from ?IPv6:2404:f801:0:5:8000::50b? ([2404:f801:9000:1a:efea::50b]) by smtp.gmail.com with ESMTPSA id a10sm2447079pja.14.2021.09.02.06.35.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Sep 2021 06:36:03 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c8100bc7-347c-477d-b54e-1199acc24b65 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=3ii/guKHn4LpF03RfgLBF/j9oSVP4qa5E4ECxRbe8hE=; b=SQm9Nj4ysgjXU+46HOkYd8Q+/51pgR0klYtCW81HunVSPpNqA+7K6ET2S66TXtFo5V dUkSrrWmLdz9TgWh/ywwICTIxatEgDnyhnQs5/AiLJGp5rcv9KvBnwyhADMsOmMIBDEE nzezmmPn+wpRYYcADoD+nWE8McbCwOsGC+BH28wlQdSj65Vv6aiEEaIhoTM3yHym8m8M uJ7pUAhfdy9O2NQ1ZT90Jct19BmiUoi4Lm8Un1aHkNzAhPQO1ioDu9bRjpEUheed7PwG NaFORAtAC9wGX5zQ/JUlDZFdP09/92z+FxuN3oVRGo0d4SLQnwGPjmGI7zp0OcLmFhww rJ3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=3ii/guKHn4LpF03RfgLBF/j9oSVP4qa5E4ECxRbe8hE=; b=KnX2E/Np4AaFGmWcTZnpj5S7+b2//nhkYzkEOCE439dEMtQGcr3yGpkHnHReGRt6Hp c4sa9efvf9/LkEoIVY+46XbDTGGprdWXi4T2cHt2J4N0V40GTvn/0ZNQ5kDTWUNGGf9h Nq9a6guLiAYD7N9SDH1rfqvRl/z7ruxKYsg4uM7sJoJ2HyK+i1wSOSLZqmEvI9Axd3QX /uGWA8QKZ2NtEowVaro0tuq4CPR72a9Vu/VqBt5OtFg/D7tjvVG1MKIpkMcshL1BI+Hz aW1e7tm7uUbPDLZvymT+Dad6r2KeNfUEbzjoMCMdhiUz+r5CZxOe05KDq7IP/nkHF4mC BSNA== X-Gm-Message-State: AOAM533eEj4FHOb4Wt3oDCtUDAIWJe10/Xk8l/JQfgjOKKUdEjV/5DvQ rJVRIjeKk7PGyDeVbQBppS4= X-Google-Smtp-Source: ABdhPJxb2ycIjPIdhzbaYk0Qkm84LE40W+f5tgz7hUwm6cNYqkebQcMmosgs/I437B2b32yx0P3oCw== X-Received: by 2002:a17:902:c408:b0:138:e3df:e999 with SMTP id k8-20020a170902c40800b00138e3dfe999mr2981076plk.30.1630589763493; Thu, 02 Sep 2021 06:36:03 -0700 (PDT) Subject: Re: [PATCH V4 08/13] hyperv/vmbus: Initialize VMbus ring buffer for Isolation VM To: Michael Kelley , KY Srinivasan , Haiyang Zhang , Stephen Hemminger , "wei.liu@kernel.org" , Dexuan Cui , "catalin.marinas@arm.com" , "will@kernel.org" , "tglx@linutronix.de" , "mingo@redhat.com" , "bp@alien8.de" , "x86@kernel.org" , "hpa@zytor.com" , "dave.hansen@linux.intel.com" , "luto@kernel.org" , "peterz@infradead.org" , "konrad.wilk@oracle.com" , "boris.ostrovsky@oracle.com" , "jgross@suse.com" , "sstabellini@kernel.org" , "joro@8bytes.org" , "davem@davemloft.net" , "kuba@kernel.org" , "jejb@linux.ibm.com" , "martin.petersen@oracle.com" , "gregkh@linuxfoundation.org" , "arnd@arndb.de" , "hch@lst.de" , "m.szyprowski@samsung.com" , "robin.murphy@arm.com" , "brijesh.singh@amd.com" , "thomas.lendacky@amd.com" , Tianyu Lan , "pgonda@google.com" , "martin.b.radev@gmail.com" , "akpm@linux-foundation.org" , "kirill.shutemov@linux.intel.com" , "rppt@kernel.org" , "hannes@cmpxchg.org" , "aneesh.kumar@linux.ibm.com" , "krish.sadhukhan@oracle.com" , "saravanand@fb.com" , "linux-arm-kernel@lists.infradead.org" , "xen-devel@lists.xenproject.org" , "rientjes@google.com" , "ardb@kernel.org" Cc: "iommu@lists.linux-foundation.org" , "linux-arch@vger.kernel.org" , "linux-hyperv@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-scsi@vger.kernel.org" , "netdev@vger.kernel.org" , vkuznets , "parri.andrea@gmail.com" , "dave.hansen@intel.com" References: <20210827172114.414281-1-ltykernel@gmail.com> <20210827172114.414281-9-ltykernel@gmail.com> From: Tianyu Lan Message-ID: Date: Thu, 2 Sep 2021 21:35:48 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 9/2/2021 8:23 AM, Michael Kelley wrote: >> + } else { >> + pages_wraparound = kcalloc(page_cnt * 2 - 1, >> + sizeof(struct page *), >> + GFP_KERNEL); >> + >> + pages_wraparound[0] = pages; >> + for (i = 0; i < 2 * (page_cnt - 1); i++) >> + pages_wraparound[i + 1] = >> + &pages[i % (page_cnt - 1) + 1]; >> + >> + ring_info->ring_buffer = (struct hv_ring_buffer *) >> + vmap(pages_wraparound, page_cnt * 2 - 1, VM_MAP, >> + PAGE_KERNEL); >> + >> + kfree(pages_wraparound); >> + if (!ring_info->ring_buffer) >> + return -ENOMEM; >> + } > With this patch, the code is a big "if" statement with two halves -- one > when SNP isolation is in effect, and the other when not. The SNP isolation > case does the work using PFNs with the shared_gpa_boundary added, > while the other case does the same work but using struct page. Perhaps > I'm missing something, but can both halves be combined and always > do the work using PFNs? The only difference is whether to add the > shared_gpa_boundary, and whether to zero the memory when done. > So get the starting PFN, then have an "if" statement for whether to > add the shared_gpa_boundary. Then everything else is the same. > At the end, use an "if" statement to decide whether to zero the > memory. It would really be better to have the logic in this algorithm > coded only once. > Hi Michael: I have tried this before. But vmap_pfn() only works for those pfns out of normal memory. Please see vmap_pfn_apply() for detail and return error when the PFN is valid. From xen-devel-bounces@lists.xenproject.org Thu Sep 02 14:15:32 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 14:15:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177307.322662 (Exim 4.92) (envelope-from ) id 1mLnUv-0007OD-3Z; Thu, 02 Sep 2021 14:15:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177307.322662; Thu, 02 Sep 2021 14:15:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLnUv-0007O6-0c; Thu, 02 Sep 2021 14:15:21 +0000 Received: by outflank-mailman (input) for mailman id 177307; Thu, 02 Sep 2021 14:15:19 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLnUt-0007O0-ET for xen-devel@lists.xenproject.org; Thu, 02 Sep 2021 14:15:19 +0000 Received: from EUR03-VE1-obe.outbound.protection.outlook.com (unknown [40.107.5.66]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 32558fec-0bf8-11ec-ae73-12813bfff9fa; Thu, 02 Sep 2021 14:15:17 +0000 (UTC) Received: from PR2PR09CA0011.eurprd09.prod.outlook.com (2603:10a6:101:16::23) by VE1PR08MB5728.eurprd08.prod.outlook.com (2603:10a6:800:1a0::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19; Thu, 2 Sep 2021 14:15:15 +0000 Received: from VE1EUR03FT004.eop-EUR03.prod.protection.outlook.com (2603:10a6:101:16:cafe::c3) by PR2PR09CA0011.outlook.office365.com (2603:10a6:101:16::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Thu, 2 Sep 2021 14:15:15 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT004.mail.protection.outlook.com (10.152.18.106) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Thu, 2 Sep 2021 14:15:14 +0000 Received: ("Tessian outbound 32695b2df2f8:v103"); Thu, 02 Sep 2021 14:15:14 +0000 Received: from 538ca24e630e.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 7C765AFF-7C4E-4C69-A812-4351BC845DCA.1; Thu, 02 Sep 2021 14:14:41 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 538ca24e630e.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 02 Sep 2021 14:14:41 +0000 Received: from DB9PR08MB6857.eurprd08.prod.outlook.com (2603:10a6:10:2a2::7) by DB8PR08MB5338.eurprd08.prod.outlook.com (2603:10a6:10:111::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.23; Thu, 2 Sep 2021 14:14:39 +0000 Received: from DB9PR08MB6857.eurprd08.prod.outlook.com ([fe80::2c28:50cf:49fd:da32]) by DB9PR08MB6857.eurprd08.prod.outlook.com ([fe80::2c28:50cf:49fd:da32%9]) with mapi id 15.20.4478.021; Thu, 2 Sep 2021 14:14:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 32558fec-0bf8-11ec-ae73-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JLCyG1nPoAs2Scph3OKb7y5oaPlFomSVrHudFHc5/fc=; b=WpwIzIXJ2EkBEz40BicJDri6QWkBKr9N4lQiLGICtkCCphNCNGXsGaKI1Cr6hqWzYDl+aRelrj95Rx/KQKYOLuevqAjEptfPBDoluKv5ExVRf3xxqGuZjqNJaRDTShN9DkjxXLKhqR/P/CmMTFIyeiLBJD0Wh7fYcPAQPzs17i0= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: a7981e90009dcd52 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=moCUcvJ5s7tImV10RgKRly2fUr3/fPEx/jpYw5FEcq1PjStFa9HTATLx3SIrSalqFdmg6REV89lDkmAKXKq22MG84i0GI37SA/VJAn9JM9MfsZ8zmzDU21my0sZPhNrxjQVv8mvVeRCdoSFuFIgmUPJultXQ6IA8qKXT3+4S4bQ9LmmbaNqY4YxYwgSY6OqKOFB5zgG/slnsNq+wL64g95OtkqS0nuhLVcu1hATExVOgX7hfbBdJC0Qn1bpayQtrLbxGfcBjhrcxDg8HjCAiL5Yi0RKTKjy6dFxuJRZLGvB42OjY0dcP4UQwvDo1PVDEsqs88gVMJUp0RguZmiVFBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JLCyG1nPoAs2Scph3OKb7y5oaPlFomSVrHudFHc5/fc=; b=K5t81NQeQcE4eW9LoZlPFzwAl+zF+zWaQUlcU4tyC3DmP6cW8lxlc7vMBsHAep6UxZMyxmxrdTlFvr3zbadpWPeJ0WVIX7RZdUDfcJAWVRb3Ei1dlgQKqbkj5jWIPuaJRXNDsANM+yfvjLDrYrg8iYwWDKK44/0BM/FmNPtaiGBBIwvkO+sEHzCNyaZIP11zCWfPV+dEJGSJFnFwdePD7AtJ0KeN1LU876miW6WZiXSlkAVk/mKdM/BIGzUGSenEOAtkcqs3ytgs3kFgJrF7vo287RKgTTWU9pwWHUOjQQ7l9QmkOUW8Uv39/0hpI5IpaM70Coma8Uqfj98i8zByoQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JLCyG1nPoAs2Scph3OKb7y5oaPlFomSVrHudFHc5/fc=; b=WpwIzIXJ2EkBEz40BicJDri6QWkBKr9N4lQiLGICtkCCphNCNGXsGaKI1Cr6hqWzYDl+aRelrj95Rx/KQKYOLuevqAjEptfPBDoluKv5ExVRf3xxqGuZjqNJaRDTShN9DkjxXLKhqR/P/CmMTFIyeiLBJD0Wh7fYcPAQPzs17i0= From: Wei Chen To: Jan Beulich , Stefano Stabellini CC: "xen-devel@lists.xenproject.org" , "julien@xen.org" , Bertrand Marquis Subject: RE: [XEN RFC PATCH 24/40] xen/arm: introduce a helper to parse device tree NUMA distance map Thread-Topic: [XEN RFC PATCH 24/40] xen/arm: introduce a helper to parse device tree NUMA distance map Thread-Index: AQHXjps+iLbrOQu8n06b5z+EtCRt06uM5puAgABnI4CAAPWOAIAA3gOAgABcYACAAOS/gIAAh9fw Date: Thu, 2 Sep 2021 14:14:39 +0000 Message-ID: References: <20210811102423.28908-1-wei.chen@arm.com> <20210811102423.28908-25-wei.chen@arm.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: B1C2CBA5107FD847AC1096268755BBB9.0 Authentication-Results-Original: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=arm.com; x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: e9a6306c-039d-43a2-3ef7-08d96e1c1591 x-ms-traffictypediagnostic: DB8PR08MB5338:|VE1PR08MB5728: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:10000;OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: AU9cInyw5hjhDGKCSUDbvl5Jmyrjowh5uiLTNQj3qfWKOcn47uBsFFlddhEaYBrH4RWrZVeTZyy3gYd0U+n29oUXFO+NxKwijwyypgXk+DTtD0pO4usfeHyBp9Dk9RRsQ9KTC1YlRZY0lUihA7+1Lucl4+DgUZYfaB+SdwJKLZIB1P9r4xk6nIXQ3hoNBYVEE3V9/suO45gGAsV2yGwT2bHIw/RvpDY3XCQPYG42l2huNKNn/ibNkGWnkPwX/3UTR9E/bQufojZMIkYhV6NKV89BJkGNB20TCE64Zg+Gm7KGdqEKgxu/VaAWie+mGqpQeKJTDpraFMZSV7Wx9dMxnt8tJ8z2tVwOz7FTo5A1W/9KephntsHlGkO/ti27AHii8jsX8A11NbsoeC19soPqgR0RFJ3YnuFRRHFWmzLEzXBbFRJBUh+bEgcWjXnYfFoUJ53meskxoXG9Zkbp3RS3I/rH8WZG32A25J/rzYGZ2572wtgUkewDloUbX9ZnyPdEgcQZTmWMIjxrHgfRSlHMQ0dM1/EGjmJcKRByfA/JxXv6Sbc/Q6JKZzZLiRYMeFM/Z1eWFVOYG/lbzyvWWzeYeCmfYLCcXilvjkloVq3TBMCoDj2wIK8iJPmp4VsoUVGt3/FA0BHmU0Vm9n3TcWbrIE1v8bP7ymiaDg27MBwTLbPguET7H6ueVeDQKJv9KZ/cXcTnl4fr8qzxQ8jrcp0I3kTNikJGLzFesZpcDBGk4Fgpiv39HRk/nhUzeUor2SAq0TpQcoVxIsipdGH5AYqdtBRVzBHonTRm1Mqso8a+ONI= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB9PR08MB6857.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(39860400002)(376002)(366004)(136003)(346002)(396003)(66556008)(7696005)(26005)(66446008)(4326008)(8936002)(64756008)(186003)(66476007)(8676002)(2906002)(76116006)(83380400001)(9686003)(38100700002)(71200400001)(66946007)(53546011)(33656002)(6506007)(122000001)(86362001)(966005)(54906003)(38070700005)(478600001)(55016002)(52536014)(110136005)(316002)(5660300002);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB5338 Original-Authentication-Results: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT004.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 97570c57-bd19-4693-31e7-08d96e1c0046 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: vw8ZSKFXU6tuCrSTm8mmzGA/gyPH+swrt8FKGcN8api9LzHseRs3nt6gy+bdG7WuHRLw6e64SHOchze2+knt6XVy4C9tD9E+kVOnN6fv+jxkVrCARzSALYeVXpx049HzKlAIUUy3F/G0VQGkKXB5eceb31cUqBuMmJFArjqLkO+Q15JeEWZlMDK0CeESbcZ3Cc+ewWVVf+N//vOeYtCoh6mH4bzAkBe301mkoEFmd2P+bHonFVh8vIqOTTzKt1mJMlkF3ufT5YL80desO0dBosWRBsAmaB21wOyxB/SLzKzrTczl4ipWRQOAbkoww28gi0cwx9gj2oKSK/GNoypuFNZsQYaQlCgBGs7mKIzhHBOAh/v/hxjx0QHXy2u/5P+IVEzmwE+Y0qFq6436P257FUJddddbo2FhWPytt6RgF+2XLDlAJsWiSWbA2LCw5aimh7jUHSs9AuRixai0CQX8d5PGrvqWJh2ZhEP39ElnSzalaaDCoz3IsGIj+OtN1FRC/QGhBXR+fYwmFN4pe94AXJX03mq5iOoRRUVPGz3p7afvZxbbJ2rqaTnJMpRHsQ+1f7FFR8wHvjbU7IiE3AruH4vjaeVMmsnMxDpLx7KAYt2HjcqTQ06FnzuDsT8T0CRbi47qIX8gPO3kVaN0dyhibC5VInd+Qf3EnTpM76B/6/EjBaT3Ttlcr6K4PLUctFdqfV4moLNp1zy60WnL1JwmdpmfD9PSIkcClu9cWuUZQzQHVvXnoISBcMUA4dR1DtsbiouGYTkvUA1JzJbo8qhPEhOES8gO3C0q0JxOSJ9ChvY= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(136003)(376002)(39860400002)(346002)(396003)(46966006)(36840700001)(966005)(2906002)(81166007)(4326008)(336012)(5660300002)(478600001)(8676002)(356005)(54906003)(55016002)(52536014)(9686003)(86362001)(82740400003)(110136005)(8936002)(70586007)(33656002)(83380400001)(70206006)(47076005)(36860700001)(316002)(6506007)(26005)(186003)(7696005)(82310400003)(53546011);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Sep 2021 14:15:14.8216 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e9a6306c-039d-43a2-3ef7-08d96e1c1591 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT004.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5728 SGkgSmFuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEphbiBCZXVs aWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4gU2VudDogMjAyMeW5tDnmnIgy5pelIDE0OjAwDQo+ IFRvOiBTdGVmYW5vIFN0YWJlbGxpbmkgPHNzdGFiZWxsaW5pQGtlcm5lbC5vcmc+OyBXZWkgQ2hl bg0KPiA8V2VpLkNoZW5AYXJtLmNvbT4NCj4gQ2M6IHhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0 Lm9yZzsganVsaWVuQHhlbi5vcmc7IEJlcnRyYW5kIE1hcnF1aXMNCj4gPEJlcnRyYW5kLk1hcnF1 aXNAYXJtLmNvbT4NCj4gU3ViamVjdDogUmU6IFtYRU4gUkZDIFBBVENIIDI0LzQwXSB4ZW4vYXJt OiBpbnRyb2R1Y2UgYSBoZWxwZXIgdG8gcGFyc2UNCj4gZGV2aWNlIHRyZWUgTlVNQSBkaXN0YW5j ZSBtYXANCj4gDQo+IE9uIDAxLjA5LjIwMjEgMTg6MjEsIFN0ZWZhbm8gU3RhYmVsbGluaSB3cm90 ZToNCj4gPiBPbiBXZWQsIDEgU2VwIDIwMjEsIFdlaSBDaGVuIHdyb3RlOg0KPiA+Pj4gU3RlZmFu byBTdGFiZWxsaW5pDQo+ID4+PiBTZW50OiAyMDIx5bm0OeaciDHml6UgNTozNg0KPiA+Pj4NCj4g Pj4+IE9uIFR1ZSwgMzEgQXVnIDIwMjEsIFdlaSBDaGVuIHdyb3RlOg0KPiA+Pj4+IEkgZG9uJ3Qg cmVhbGx5IGxpa2UgdGhpcyBpbXBsZW1lbnRhdGlvbi4gSSB3YW50IHRoZSBiZWhhdmlvciBvZg0K PiA+Pj4+IG51bWFfc2V0X2Rpc3RhbmNlIGp1c3QgbGlrZSB0aGUgZnVuY3Rpb24gbmFtZSwgZG8g bm90IGluY2x1ZGUNCj4gPj4+PiBpbXBsaWNpdCBvcGVyYXRpb25zLiBPdGhlcndpc2UsIGV4Y2Vw dCB0aGUgdXNlciByZWFkIHRoaXMgZnVuY3Rpb24NCj4gPj4+PiBpbXBsZW1lbnRhdGlvbiBiZWZv cmUgaGUgdXNlIGl0LCBoZSBwcm9iYWJseSBkb2Vzbid0IGtub3cgdGhpcw0KPiA+Pj4+IGZ1bmN0 aW9uIGhhcyBkb25lIHNvIG1hbnkgdGhpbmdzLg0KPiA+Pj4NCj4gPj4+IFlvdSBjYW4gbGVhdmUg bnVtYV9zZXRfZGlzdGFuY2UgYXMtaXMgd2l0aG91dCBhbnkgaW1wbGljaXQgb3BlcmF0aW9ucy4N Cj4gPj4+DQo+ID4+PiBJbiB0aGF0IGNhc2UsIGp1c3QgY2FsbCBudW1hX3NldF9kaXN0YW5jZSB0 d2ljZSBmcm9tIG51bWFfc2V0X2Rpc3RhbmNlDQo+ID4+PiBmb3IgYm90aCBmcm9tL3RvIGFuZCB0 by9mcm9tLiBudW1hX3NldF9kaXN0YW5jZSBjb3VsZCByZXR1cm4gZXJyb3IgaXMNCj4gPj4NCj4g Pj4gSSBhbSBPSyBmb3IgdGhlIGZpcnN0IHNlbnRlbmNlLiBCdXQuLi4NCj4gPj4NCj4gPj4+IHRo ZSBlbnRyeSB3YXMgYWxyZWFkeSBzZXQgdG8gYSBkaWZmZXJlbnQgdmFsdWUgb3Igc3VjY2VzcyBv dGhlcndpc2UNCj4gPj4+IChhbHNvIGluIHRoZSBjYXNlIGl0IHdhcyBhbHJlYWR5IHNldCB0byB0 aGUgc2FtZSB2YWx1ZSkuIFRoaXMgd291bGQNCj4gPj4NCj4gPj4gLi4uIEkgcHJlZmVyIG5vdCB0 byBjaGVjayB0aGUgcHJldmlvdXMgdmFsdWUuIFN1YnNlcXVlbnQNCj4gbnVtYV9zZXRfZGlzdGFu Y2UNCj4gPj4gY2FsbCB3aWxsIG92ZXJyaWRlIHByZXZpb3VzIGNhbGxzLiBLZWVwIG51bWFfc2V0 X2Rpc3RhbmNlIGFzIHNpbXBsZSBhcw0KPiA+PiBpdCBjYW4uIEFuZCB3aGVuIHlvdSBwYXNzIG5l dyBkYXRhIHRvIG51bWFfc2V0X2Rpc3RhbmNlLCBpdCBkb2Vzbid0DQo+ID4+IGtub3cgd2hldGhl ciB0aGUgcHJldmlvdXMgZGF0YSB3YXMgY29ycmVjdCBvciB0aGUgbmV3IGRhdGEgaXMgY29ycmVj dC4NCj4gPj4gT25seSBjYWxsZXIgbWF5IGhhdmUga25vd24uDQo+ID4NCj4gPiBUaGF0IG1pZ2h0 IGJlIE9LIGJ1dCBpZiBub3QgbnVtYV9zZXRfZGlzdGFuY2UgdGhlbiBzb21lYm9keSBlbHNlIG5l ZWRzDQo+ID4gdG8gY2hlY2sgYWdhaW5zdCBvdmVyd3JpdGluZyBwcmV2aW91cyB2YWx1ZXMuIFRo YXQgaXMgdG8gYmUgYWJsZSB0byBzcG90DQo+ID4gYmFkIGRldmljZSB0cmVlIGNhc2VzIGxpa2U6 DQo+ID4NCj4gPiAgIDAgMSAyMA0KPiA+ICAgMSAwIDQwDQo+IA0KPiBXaGF0J3Mgd3Jvbmcgd2l0 aCB0aGlzPyBBdCBsZWFzdCB0aGUgQUNQSSBzcGVjIGNhcmVzIHRvIHNwZWNpZmljYWxseQ0KPiBw ZXJtaXQgdGhpcyBjYXNlOg0KPiANCg0KVGhpcyBpcyBiZWNhdXNlIHNvbWUgbm90ZXMgZGVzY3Jp cHRpb24gaW4gZGV2aWNlIHRyZWUgTlVNQSBiaW5kaW5nOg0KLSBkaXN0YW5jZS1tYXRyaXgNCiAg VGhpcyBwcm9wZXJ0eSBkZWZpbmVzIGEgbWF0cml4IHRvIGRlc2NyaWJlIHRoZSByZWxhdGl2ZSBk aXN0YW5jZXMNCiAgYmV0d2VlbiBhbGwgbnVtYSBub2Rlcy4NCiAgSXQgaXMgcmVwcmVzZW50ZWQg YXMgYSBsaXN0IG9mIG5vZGUgcGFpcnMgYW5kIHRoZWlyIHJlbGF0aXZlIGRpc3RhbmNlLg0KDQog IE5vdGU6DQoJMS4gRWFjaCBlbnRyeSByZXByZXNlbnRzIGRpc3RhbmNlIGZyb20gZmlyc3Qgbm9k ZSB0byBzZWNvbmQgbm9kZS4NCglUaGUgZGlzdGFuY2VzIGFyZSBlcXVhbCBpbiBlaXRoZXIgZGly ZWN0aW9uLg0KaHR0cHM6Ly93d3cua2VybmVsLm9yZy9kb2MvRG9jdW1lbnRhdGlvbi9kZXZpY2V0 cmVlL2JpbmRpbmdzL251bWEudHh0DQoNClNvIHdlIHRyZWF0IHRoaXMgY2FzZSBpcyB3cm9uZyBp biBEVC4gQnV0IGFzIHlvdSBzYWlkIEFDUEkgYWxsb3cgc3VjaA0KY2FzZSwgdGhhdCBtZWFucyBy ZWFsIG1hY2hpbmVzIGFsbG93IGRpZmZlcmVudCBkaXN0YW5jZXMgZm9yIG9uZSBwYWlyDQpub2Rl cyBpbiBkaWZmZXJlbnQgZGlyZWN0aW9ucy4NCg0KPiAiRXhjZXB0IGZvciB0aGUgcmVsYXRpdmUg ZGlzdGFuY2UgZnJvbSBhIFN5c3RlbSBMb2NhbGl0eSB0byBpdHNlbGYsDQo+ICBlYWNoIHJlbGF0 aXZlIGRpc3RhbmNlIGlzIHN0b3JlZCB0d2ljZSBpbiB0aGUgbWF0cml4LiBUaGlzIHByb3ZpZGVz DQo+ICB0aGUgY2FwYWJpbGl0eSB0byBkZXNjcmliZSB0aGUgc2NlbmFyaW8gd2hlcmUgdGhlIHJl bGF0aXZlIGRpc3RhbmNlcw0KPiAgZm9yIHRoZSB0d28gZGlyZWN0aW9ucyBiZXR3ZWVuIFN5c3Rl bSBMb2NhbGl0aWVzIGlzIGRpZmZlcmVudC4iDQo+IA0KPiBKYW4NCg0K From xen-devel-bounces@lists.xenproject.org Thu Sep 02 15:07:22 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 15:07:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177317.322686 (Exim 4.92) (envelope-from ) id 1mLoJ9-0004dB-6E; Thu, 02 Sep 2021 15:07:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177317.322686; Thu, 02 Sep 2021 15:07:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLoJ9-0004d4-39; Thu, 02 Sep 2021 15:07:15 +0000 Received: by outflank-mailman (input) for mailman id 177317; Thu, 02 Sep 2021 15:07:13 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLoJ7-0004cr-L2; Thu, 02 Sep 2021 15:07:13 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLoJ7-00070q-EO; Thu, 02 Sep 2021 15:07:13 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLoJ7-0005Ll-3h; Thu, 02 Sep 2021 15:07:13 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mLoJ7-00031v-36; Thu, 02 Sep 2021 15:07:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=/VKoLjB506Ce5AJiUuydkSylSJThWFxV6MyYfcbA82k=; b=6v+kyJqq6BuQXkKDtInxWuv5Mz K8gglkOZUznGjnASx6OQPUpWOWAIGitTtA11WmcG9Z9rRE3CFnPaYCQFkXY8a3E7JBK6I/wTodUqg jzxjtkcp5o+9Smov4L2EqPNtpoIo1plJ9nqtkaowv45XJwvbZNlwTXLeYmtCW6BJXfxg=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 164739: tolerable FAIL X-Osstest-Failures: xen-unstable:test-arm64-arm64-xl-credit2:xen-boot:fail:heisenbug xen-unstable:test-armhf-armhf-xl-credit2:xen-boot:fail:heisenbug xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=96607a8e680e7f965ca868d11f8b0636317d2618 X-Osstest-Versions-That: xen=96607a8e680e7f965ca868d11f8b0636317d2618 From: osstest service owner Date: Thu, 02 Sep 2021 15:07:13 +0000 flight 164739 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/164739/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-arm64-arm64-xl-credit2 8 xen-boot fail in 164687 pass in 164739 test-armhf-armhf-xl-credit2 8 xen-boot fail pass in 164687 Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-credit2 15 migrate-support-check fail in 164687 never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail in 164687 never pass test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 164687 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 164687 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 164687 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 164687 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 164687 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 164687 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 164687 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 164687 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 164687 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 164687 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 164687 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen 96607a8e680e7f965ca868d11f8b0636317d2618 baseline version: xen 96607a8e680e7f965ca868d11f8b0636317d2618 Last test of basis 164739 2021-09-02 01:51:34 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Thu Sep 02 15:20:20 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 15:20:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177327.322705 (Exim 4.92) (envelope-from ) id 1mLoVY-0006sd-IU; Thu, 02 Sep 2021 15:20:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177327.322705; Thu, 02 Sep 2021 15:20:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLoVY-0006rp-FC; Thu, 02 Sep 2021 15:20:04 +0000 Received: by outflank-mailman (input) for mailman id 177327; Thu, 02 Sep 2021 15:20:03 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLoVW-0006a7-UF for xen-devel@lists.xenproject.org; Thu, 02 Sep 2021 15:20:02 +0000 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 3d1e1c10-0c01-11ec-ae7d-12813bfff9fa; Thu, 02 Sep 2021 15:20:00 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id A9BF96023F; Thu, 2 Sep 2021 15:19:59 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3d1e1c10-0c01-11ec-ae7d-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1630595999; bh=zBOKCPFNms5m2rbidR117XlvEpQMb/G1xiLl/tUDypQ=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=bI6VUHcBYp+Ke4KVgkZXS1diLy7T43k2Z6YTD+AnFAItvVCel2R4Ac4kYHhBFYc/2 LKz3CYU2jiQLSeiBjtU/vIFdC20uvEK+qNB1qkvitDMy4r68FD9rrhaeMZe92YHih1 cS3Qyx9S2imtwS5/YPfdXdOiR+ib0IeTWtAc7CKwS8uUWoVVkQJ0KjKH5vGHMN6P/L MGovG3SyCOL/nDXJ04mpDuzA2/tZRSg20f3jjUC3G9GZRDwMpBqYcQurcfmx4TM0b8 HDxhg4XXygwbhbg6F8dNQz+CDqG/V796vnWSK0Z725xpPOKEGQB0V0MQfPMEiV5FPR sJSWv5s7Yjg4Q== Date: Thu, 2 Sep 2021 08:19:59 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: Wei Chen cc: Stefano Stabellini , "xen-devel@lists.xenproject.org" , "julien@xen.org" , Bertrand Marquis Subject: RE: [XEN RFC PATCH 24/40] xen/arm: introduce a helper to parse device tree NUMA distance map In-Reply-To: Message-ID: References: <20210811102423.28908-1-wei.chen@arm.com> <20210811102423.28908-25-wei.chen@arm.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: multipart/mixed; BOUNDARY="8323329-2029384931-1630595860=:17925" Content-ID: This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-2029384931-1630595860=:17925 Content-Type: text/plain; CHARSET=UTF-8 Content-Transfer-Encoding: 8BIT Content-ID: On Thu, 2 Sep 2021, Wei Chen wrote: > Hi Stefano, > > > -----Original Message----- > > From: Stefano Stabellini > > Sent: 2021年9月2日 0:22 > > To: Wei Chen > > Cc: Stefano Stabellini ; xen- > > devel@lists.xenproject.org; julien@xen.org; Bertrand Marquis > > > > Subject: RE: [XEN RFC PATCH 24/40] xen/arm: introduce a helper to parse > > device tree NUMA distance map > > > > On Wed, 1 Sep 2021, Wei Chen wrote: > > > Hi Stefano, > > > > > > > -----Original Message----- > > > > From: Xen-devel On Behalf Of > > > > Stefano Stabellini > > > > Sent: 2021年9月1日 5:36 > > > > To: Wei Chen > > > > Cc: Stefano Stabellini ; xen- > > > > devel@lists.xenproject.org; julien@xen.org; Bertrand Marquis > > > > > > > > Subject: RE: [XEN RFC PATCH 24/40] xen/arm: introduce a helper to > > parse > > > > device tree NUMA distance map > > > > > > > > On Tue, 31 Aug 2021, Wei Chen wrote: > > > > > Hi Stefano, > > > > > > > > > > > -----Original Message----- > > > > > > From: Stefano Stabellini > > > > > > Sent: 2021年8月31日 8:48 > > > > > > To: Wei Chen > > > > > > Cc: xen-devel@lists.xenproject.org; sstabellini@kernel.org; > > > > julien@xen.org; > > > > > > jbeulich@suse.com; Bertrand Marquis > > > > > > Subject: Re: [XEN RFC PATCH 24/40] xen/arm: introduce a helper to > > > > parse > > > > > > device tree NUMA distance map > > > > > > > > > > > > On Wed, 11 Aug 2021, Wei Chen wrote: > > > > > > > A NUMA aware device tree will provide a "distance-map" node to > > > > > > > describe distance between any two nodes. This patch introduce a > > > > > > > new helper to parse this distance map. > > > > > > > > > > > > > > Signed-off-by: Wei Chen > > > > > > > --- > > > > > > > xen/arch/arm/numa_device_tree.c | 67 > > > > +++++++++++++++++++++++++++++++++ > > > > > > > 1 file changed, 67 insertions(+) > > > > > > > > > > > > > > diff --git a/xen/arch/arm/numa_device_tree.c > > > > > > b/xen/arch/arm/numa_device_tree.c > > > > > > > index bbe081dcd1..6e0d1d3d9f 100644 > > > > > > > --- a/xen/arch/arm/numa_device_tree.c > > > > > > > +++ b/xen/arch/arm/numa_device_tree.c > > > > > > > @@ -200,3 +200,70 @@ device_tree_parse_numa_memory_node(const > > void > > > > *fdt, > > > > > > int node, > > > > > > > > > > > > > > return 0; > > > > > > > } > > > > > > > + > > > > > > > +/* Parse NUMA distance map v1 */ > > > > > > > +int __init > > > > > > > +device_tree_parse_numa_distance_map_v1(const void *fdt, int > > node) > > > > > > > +{ > > > > > > > + const struct fdt_property *prop; > > > > > > > + const __be32 *matrix; > > > > > > > + int entry_count, len, i; > > > > > > > + > > > > > > > + printk(XENLOG_INFO "NUMA: parsing numa-distance-map\n"); > > > > > > > + > > > > > > > + prop = fdt_get_property(fdt, node, "distance-matrix", &len); > > > > > > > + if ( !prop ) > > > > > > > + { > > > > > > > + printk(XENLOG_WARNING > > > > > > > + "NUMA: No distance-matrix property in distance- > > > > map\n"); > > > > > > > + > > > > > > > + return -EINVAL; > > > > > > > + } > > > > > > > + > > > > > > > + if ( len % sizeof(uint32_t) != 0 ) > > > > > > > + { > > > > > > > + printk(XENLOG_WARNING > > > > > > > + "distance-matrix in node is not a multiple of > > > > u32\n"); > > > > > > > + return -EINVAL; > > > > > > > + } > > > > > > > + > > > > > > > + entry_count = len / sizeof(uint32_t); > > > > > > > + if ( entry_count <= 0 ) > > > > > > > + { > > > > > > > + printk(XENLOG_WARNING "NUMA: Invalid distance- > > matrix\n"); > > > > > > > + > > > > > > > + return -EINVAL; > > > > > > > + } > > > > > > > + > > > > > > > + matrix = (const __be32 *)prop->data; > > > > > > > + for ( i = 0; i + 2 < entry_count; i += 3 ) > > > > > > > + { > > > > > > > + uint32_t from, to, distance; > > > > > > > + > > > > > > > + from = dt_read_number(matrix, 1); > > > > > > > + matrix++; > > > > > > > + to = dt_read_number(matrix, 1); > > > > > > > + matrix++; > > > > > > > + distance = dt_read_number(matrix, 1); > > > > > > > + matrix++; > > > > > > > + > > > > > > > + if ( (from == to && distance != NUMA_LOCAL_DISTANCE) || > > > > > > > + (from != to && distance <= NUMA_LOCAL_DISTANCE) ) > > > > > > > + { > > > > > > > + printk(XENLOG_WARNING > > > > > > > + "Invalid nodes' distance from node#%d to > > node#%d > > > > > > = %d\n", > > > > > > > + from, to, distance); > > > > > > > + return -EINVAL; > > > > > > > + } > > > > > > > + > > > > > > > + printk(XENLOG_INFO "NUMA: distance from node#%d to > > node#%d > > > > > > = %d\n", > > > > > > > + from, to, distance); > > > > > > > + numa_set_distance(from, to, distance); > > > > > > > + > > > > > > > + /* Set default distance of node B->A same as A->B */ > > > > > > > + if (to > from) > > > > > > > + numa_set_distance(to, from, distance); > > > > > > > > > > > > I am a bit unsure about this last 2 lines: why calling > > > > numa_set_distance > > > > > > in the opposite direction only when to > from? Wouldn't it be OK > > to > > > > > > always do both: > > > > > > > > > > > > numa_set_distance(from, to, distance); > > > > > > numa_set_distance(to, from, distance); > > > > > > > > > > > > ? > > > > > > > > > > > I borrowed this code from Linux, but here is my understanding: > > > > > > > > > > First, I read some notes in > > Documentation/devicetree/bindings/numa.txt > > > > > 1. Each entry represents distance from first node to second node. > > > > > The distances are equal in either direction. > > > > > 2. distance-matrix should have entries in lexicographical ascending > > > > > order of nodes. > > > > > > > > > > Here is an example of distance-map node in DTB: > > > > > Sample#1, full list: > > > > > distance-map { > > > > > compatible = "numa-distance-map-v1"; > > > > > distance-matrix = <0 0 10>, > > > > > <0 1 20>, > > > > > <0 2 40>, > > > > > <0 3 20>, > > > > > <1 0 20>, > > > > > <1 1 10>, > > > > > <1 2 20>, > > > > > <1 3 40>, > > > > > <2 0 40>, > > > > > <2 1 20>, > > > > > <2 2 10>, > > > > > <2 3 20>, > > > > > <3 0 20>, > > > > > <3 1 40>, > > > > > <3 2 20>, > > > > > <3 3 10>; > > > > > }; > > > > > > > > > > Call numa_set_distance when "to > from" will prevent Xen to call > > > > > numa_set_distance(0, 1, 20) again when it's setting distance for <1 > > 0 > > > > 20>. > > > > > But, numa_set_distance(1, 0, 20) will be call twice. > > > > > > > > > > Normally, distance-map node will be optimized in following sample#2, > > > > > all redundant entries are removed: > > > > > Sample#2, partial list: > > > > > distance-map { > > > > > compatible = "numa-distance-map-v1"; > > > > > distance-matrix = <0 0 10>, > > > > > <0 1 20>, > > > > > <0 2 40>, > > > > > <0 3 20>, > > > > > <1 1 10>, > > > > > <1 2 20>, > > > > > <1 3 40>, > > > > > <2 2 10>, > > > > > <2 3 20>, > > > > > <3 3 10>; > > > > > }; > > > > > > > > > > There is not any "from > to" entry in the map. But using this > > partial > > > > map > > > > > still can set all distances for all pairs. And numa_set_distance(1, > > 0, > > > > 20) > > > > > will be only once. > > > > > > > > I see. I can't find in Documentation/devicetree/bindings/numa.txt > > where > > > > it says that "from > to" nodes can be omitted. If it is not written > > > > down, then somebody could easily optimize it the opposite way: > > > > > > > > distance-matrix = <0 0 10>, > > > > <1 0 20>, > > > > <2 0 40>, > > > > <3 0 20>, > > > > <1 1 10>, > > > > <2 1 20>, > > > > <3 1 40>, > > > > <2 2 10>, > > > > <3 2 20>, > > > > <3 3 10>; > > > > > > > > > > Yes, you're right. Spec doesn't say opposite way is unallowed. > > > > > > > I think the code in Xen should be resilient and able to cope with a > > > > device tree like the one you wrote or the one I wrote. From a code > > > > perspective, it should be very easy to do. If nothing else it would > > make > > > > Xen more resilient against buggy firmware. > > > > > > > > > > > > > > I don't disagree with that. > > > > > > > > > But in any case, I have a different suggestion. The binding states > > > > that > > > > > > "distances are equal in either direction". Also it has an example > > > > where > > > > > > only one direction is expressed unfortunately (at the end of the > > > > > > document). > > > > > > > > > > > > > > > > Oh, I should see this comment first, then I will not post above > > > > > comment : ) > > > > > > > > > > > So my suggestion is to parse it as follows: > > > > > > > > > > > > - call numa_set_distance just once from > > > > > > device_tree_parse_numa_distance_map_v1 > > > > > > > > > > > > - in numa_set_distance: > > > > > > - set node_distance_map[from][to] = distance; > > > > > > - check node_distance_map[to][from] > > > > > > - if unset, node_distance_map[to][from] = distance; > > > > > > - if already set to the same value, return success; > > > > > > - if already set to a different value, return error; > > > > > > > > > > I don't really like this implementation. I want the behavior of > > > > > numa_set_distance just like the function name, do not include > > > > > implicit operations. Otherwise, except the user read this function > > > > > implementation before he use it, he probably doesn't know this > > > > > function has done so many things. > > > > > > > > You can leave numa_set_distance as-is without any implicit operations. > > > > > > > > In that case, just call numa_set_distance twice from numa_set_distance > > > > for both from/to and to/from. numa_set_distance could return error is > > > > > > I am OK for the first sentence. But... > > > > > > > the entry was already set to a different value or success otherwise > > > > (also in the case it was already set to the same value). This would > > > > > > ... I prefer not to check the previous value. Subsequent > > numa_set_distance > > > call will override previous calls. Keep numa_set_distance as simple as > > > it can. And when you pass new data to numa_set_distance, it doesn't > > > know whether the previous data was correct or the new data is correct. > > > Only caller may have known. > > > > That might be OK but if not numa_set_distance then somebody else needs > > to check against overwriting previous values. That is to be able to spot > > bad device tree cases like: > > > > 0 1 20 > > 1 0 40 > > > How about we check it still in NUMA distance parse function? > Before setting the numa_set_distance for one pair nodes (e.g. a -> b), > we can get its opposite way distance first. > > distance_b_a = __node_distance(b, a); ==> get opposite way distance. > if (distance_b_a == 0) ==> opposite way distance has not been set > { > numa_set_distance(a, b, 20); ==> set both > numa_set_distance(b, a, 20) > } else { > if (distance_b_a == 20) ==> opposite way distance has been set > numa_set_distance(a, b, 20); ==> set this way only > else ===> opposite way distance has been set, but is unmatched > // What can we do here? > Panic the system? or Just warning users? Or choose the bigger > distance for both ways? > > And distance_b_a == NUMA_NO_DISTANCE would be a special case > here. > } Yes, I think something like this would work. If we detect an error in device tree I would probably print a warning and disable NUMA. It would also be acceptable to panic. --8323329-2029384931-1630595860=:17925-- From xen-devel-bounces@lists.xenproject.org Thu Sep 02 15:57:53 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 15:57:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177393.322771 (Exim 4.92) (envelope-from ) id 1mLp5x-0005mw-Hk; Thu, 02 Sep 2021 15:57:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177393.322771; Thu, 02 Sep 2021 15:57:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLp5x-0005mp-Dd; Thu, 02 Sep 2021 15:57:41 +0000 Received: by outflank-mailman (input) for mailman id 177393; Thu, 02 Sep 2021 15:57:39 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLp5v-0005mj-Fa for xen-devel@lists.xenproject.org; Thu, 02 Sep 2021 15:57:39 +0000 Received: from outbound.mail.eo.outlook.com (unknown [40.93.3.5]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 7cbaedda-0c06-11ec-ae82-12813bfff9fa; Thu, 02 Sep 2021 15:57:34 +0000 (UTC) Received: from MWHPR21MB1593.namprd21.prod.outlook.com (2603:10b6:301:7c::11) by MWHPR2101MB0729.namprd21.prod.outlook.com (2603:10b6:301:76::39) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.1; Thu, 2 Sep 2021 15:57:25 +0000 Received: from MWHPR21MB1593.namprd21.prod.outlook.com ([fe80::3c8b:6387:cd5:7d86]) by MWHPR21MB1593.namprd21.prod.outlook.com ([fe80::3c8b:6387:cd5:7d86%8]) with mapi id 15.20.4478.014; Thu, 2 Sep 2021 15:57:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7cbaedda-0c06-11ec-ae82-12813bfff9fa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KCAiBFS/0mCgB2qMN5U9gBLvp1U2Cyy92ELkvrC9T80fD4TYG+I/WxS/YPZIKOugn6fTW6Pj1TpRJhi8gbS00Rafsetoy/2Lc/w1ZJMpyW4OumOJrPFbLXen/VOsuYhCh/DUAxmh2ciewoPS3lF5hgJT1D3ot0TXIrZAhfvxqNONTMHKG31ePfmhU8tpvYJfR565aOA5fy6W4F6zaITNPWME2dsxbWFvzFV9oBHuH0cTJtCUSQmDwr29IfWXJb5vplgKPkmMDOvTJUwhljbHlUTQbz1jKcxZhiVsSFojaRwLF9nkpec0Hk8QT0b08MjR9jMcUDbOTp1M1SVh0RIoDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=HuvGa1HIbj6xCIKr0VB/aMjA6tx/V75cyR5Rtnz4Cmo=; b=hX6PpM7beSSZeEmz9DUmaJ9pJyIkwjNdkTKfArPGom7dxrRA1MWEz+4y9+uxPH1xQ/w55bLGHYhFSX8eB7yLOh/u5NoGkyzrihATJth2kpIKd7wgGTrnYPm6XhYWHW3R6dG3+Bczq1WxwxsNMIT2fj8jVNsiYSXTsKBZU4KP0yZJ3/ZNPiweFdkQnQC1sa9fA/hrNf2LbPnbT74N1UwNPm2bPx2k1XgOUhJNsEbGH08/G2BFUfnfJsqUguv0tdXM5VWeaiCWbg/Y4tu0r0A28CTIR+MgpTwTUVZejfrljk9hc+LJMCKPO8t5vcxRvLaT/ZWJ4bBJAyk0vmd44Vs00Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HuvGa1HIbj6xCIKr0VB/aMjA6tx/V75cyR5Rtnz4Cmo=; b=BhPPiDHloa926sA3o5SBOABnbTxqZIOEXuJsLh4eYXVBnNr3+we4lcCH70qJWJ0JCTR7n6Zfsr/aBchdBEGRJnifOfVKLZFJwmT3UcPf2WTgCWs7k+jTugtAj/FRWa6bLqb+AbqkWGkRbtrf1n477usdwrbmPsPiBl92NdaCHys= From: Michael Kelley To: Christoph Hellwig CC: Tianyu Lan , KY Srinivasan , Haiyang Zhang , Stephen Hemminger , "wei.liu@kernel.org" , Dexuan Cui , "catalin.marinas@arm.com" , "will@kernel.org" , "tglx@linutronix.de" , "mingo@redhat.com" , "bp@alien8.de" , "x86@kernel.org" , "hpa@zytor.com" , "dave.hansen@linux.intel.com" , "luto@kernel.org" , "peterz@infradead.org" , "konrad.wilk@oracle.com" , "boris.ostrovsky@oracle.com" , "jgross@suse.com" , "sstabellini@kernel.org" , "joro@8bytes.org" , "davem@davemloft.net" , "kuba@kernel.org" , "jejb@linux.ibm.com" , "martin.petersen@oracle.com" , "gregkh@linuxfoundation.org" , "arnd@arndb.de" , "m.szyprowski@samsung.com" , "robin.murphy@arm.com" , "brijesh.singh@amd.com" , "thomas.lendacky@amd.com" , Tianyu Lan , "pgonda@google.com" , "martin.b.radev@gmail.com" , "akpm@linux-foundation.org" , "kirill.shutemov@linux.intel.com" , "rppt@kernel.org" , "hannes@cmpxchg.org" , "aneesh.kumar@linux.ibm.com" , "krish.sadhukhan@oracle.com" , "saravanand@fb.com" , "linux-arm-kernel@lists.infradead.org" , "xen-devel@lists.xenproject.org" , "rientjes@google.com" , "ardb@kernel.org" , "iommu@lists.linux-foundation.org" , "linux-arch@vger.kernel.org" , "linux-hyperv@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-scsi@vger.kernel.org" , "netdev@vger.kernel.org" , vkuznets , "parri.andrea@gmail.com" , "dave.hansen@intel.com" Subject: RE: [PATCH V4 00/13] x86/Hyper-V: Add Hyper-V Isolation VM support Thread-Topic: [PATCH V4 00/13] x86/Hyper-V: Add Hyper-V Isolation VM support Thread-Index: AQHXm2f20hs45o24pkmChnbOnB/NPKuL9ngAgAHkV3CAAo9WgIAAfS2g Date: Thu, 2 Sep 2021 15:57:24 +0000 Message-ID: References: <20210827172114.414281-1-ltykernel@gmail.com> <20210830120036.GA22005@lst.de> <20210902075939.GB14986@lst.de> In-Reply-To: <20210902075939.GB14986@lst.de> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ActionId=341860f6-2dd3-4e6b-aaea-e3d22051d2db;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=true;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Standard;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=Internal;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2021-09-02T15:27:40Z;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=microsoft.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 29e260fb-9419-416f-e7a1-08d96e2a5b72 x-ms-traffictypediagnostic: MWHPR2101MB0729: x-ms-exchange-transport-forked: True x-ld-processed: 72f988bf-86f1-41af-91ab-2d7cd011db47,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: mrF4oMoXJSuRKL/XGzpZTJvFlKLDUPlBxhocIR348p9dCVr/qB/aSYqavDNWBtQhLYznx6PnBdzPIzuEu8muiihXZRDhc0FVPy5XsTO+p1l7SRkCY+mB0m63qcViFQhmw+6PAzn/E7FipdBaK4AhK5ZQ3dQVtrVE8aPoT4EO1UxWSIixV2cMtArTkpfY/t9Ek37zSyD3LzpQU26GYD7Z54ukfHYYdrSGOtxlDa3/caqm176zYfa21Mm8pcy2zPWa6iAASleD2A19TwfTcmBZRQ8q4SXTcT8o5UbAqeE9OsPy4IBrj4Yx7dfUaDLRdS9lySLGdIKsrcCFQ82KN3/11kJJWQ7GgQr3nl5JYk+5jezIGWSnvD3m+J4xMfPdwdjoBRtFfOnKx35p66gL60qd6WZIftZKspfKOGvaopwP+aBRbYXZIPcS6xvyhimqjR/CIWZZSgZhzSz3ho0/hNZP5IRZyGWU0TUhfzTo779XK5VIkzkHOi/I+wQKABXNOnIAzz4gYMyxGSA8wI4/XXSBH34OTNsHPQ3ufEXjWuwlXD5QLQ66kzcINxj7ivfCDzFL97r6bid/nlSlwuWg7B98nE8K4phLCDpmtLPECZZSRqt2XA4p99Vv24InBJBv5lGKFyTQOnTCY92zkMs3Fybe5w8Kl5GpNBPwECoMT2ofOdySGAqFHos0OzDlHss5FJ/cbS2KYfWc3Lw0lww1z+fA4A== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR21MB1593.namprd21.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(508600001)(9686003)(86362001)(10290500003)(8990500004)(76116006)(26005)(66556008)(33656002)(186003)(55016002)(6916009)(38070700005)(122000001)(54906003)(82960400001)(71200400001)(82950400001)(66476007)(64756008)(316002)(66446008)(4326008)(66946007)(38100700002)(7696005)(7406005)(2906002)(7366002)(5660300002)(8936002)(6506007)(7416002)(52536014)(8676002)(83380400001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?txgEKNhptKnTZhKRFxE9zXxPdblEEya4z3HY9Y9W+T8Go+v0NzILZI6Antk2?= =?us-ascii?Q?0AjU8L6C4+Pdz9J9yNTP3+W6bvhC6KHsZFFftpbRs8qBExE4XF1rEyej6XB6?= =?us-ascii?Q?TF3LP39SbQevIVDByyzHpIGKh0wRn8kGGWsI8RmMHR7duippFZbzzS+u5Omz?= =?us-ascii?Q?a7UpgUKenDyv008SIWttlg1AxbeKp8XDdLs02JClXg/lX55zviivWx25oqLq?= =?us-ascii?Q?h7wlY28mwkatvnzabVvfb+joZ2jgbo4wT4HBae10bX9QJJ2tD3+afv2tXXuE?= =?us-ascii?Q?ZJCBsAw09QlZVcG5X7AlVJP/Z54ztWI7perLhH243k87s00vfSlT6LYscL9r?= =?us-ascii?Q?rc1Nfq3Va8ZBovRoxJrhyMpY9TjA4zYDGKStDrQ0kTEcdGms2WHd1od6G1IW?= =?us-ascii?Q?5eRQoPhVcgWECYRILtl0370PKfMyQ01/zxJ5rOtXMqxuOzo959qRirNoWTbL?= =?us-ascii?Q?CvaUsKCwb81UHtb8QTr5BjfFG9tck0NsyXaB3NbaGN2zgMpZtkqZrKnmsM91?= =?us-ascii?Q?11vggvJNKD4erPN+76nEVLmrNJh7mGpPOfx9xWMwuY/nLbovZtZrAWsJ4i/I?= =?us-ascii?Q?uIJE1RTX1B8Ws09qDeD4AhxVR++baJjCDtKVcCxJd7GzbUR4UKxetYyHnoyW?= =?us-ascii?Q?+YZXn93BjZpK7W+yn8YuX5vlWh0gO1CUOqu9z8nIEJn4PNxo2q7pj9mYbElG?= =?us-ascii?Q?NGJeuXowqYgtxlBeiYiBdXUc1JNo5kpAXE/IEB8iSm8fuF5rE+h+LM1hpI0X?= =?us-ascii?Q?n5Cl5zan+tlWbr1vS9ZLyGUvgFUz8Oku3XCvIUybVz/m9cGbExAnrC0xzM/r?= =?us-ascii?Q?cpR3HBgNuJCQcEBBWv5tXPKrwBdeNwRvHsWwpT56Cjurg8BzAK9bLLXITIp6?= =?us-ascii?Q?KfBprR6CCu0wXbPU6GXdFSOI3R5V5ULB+jlscT8gBDf5vCAx+PlkQ2LLuc8u?= =?us-ascii?Q?gBiCPsLGalJ8FdBPXg7MpCUr51oGQI8SKyWqIkih++ORzKKulnjiNv2L2lO2?= =?us-ascii?Q?FMxdWIvmKSgHezvGgLE7QHJIBmFZvqW3mwOOLxKRJqSIEagN9abdW+cq0gCR?= =?us-ascii?Q?96OMxcP+W0DAtNyS8xUGJZnV5NIoh9fegO4HEWPwT3TRHRfoXI02MnKCLulT?= =?us-ascii?Q?kFe2v/kRAS82Ap2d+DHv9bjTGE/7UoPoxzd2rDZaFQ1rsfKFo5qWlXnjvcHd?= =?us-ascii?Q?nwqm4i88XU1RnK0+YolCKjff+k3PVg0Bk/Z4lvADn0xx80ridOQj2QBEFHyF?= =?us-ascii?Q?aiy4NeMdes3ZbGoZn69+7RlIE9s7Oe4NVOZnzbyJ52agJQbDEAWM5lA5osLb?= =?us-ascii?Q?uVjlCOUPx2PqzbxSIQG8WKYA?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR21MB1593.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 29e260fb-9419-416f-e7a1-08d96e2a5b72 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Sep 2021 15:57:24.8646 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: afQic2r0Oqvq+TKsAMcY2JuSksSLHirOl2XxJoYethj2b0nNTqDhmPNgN8NTmSHtCHvfeYm6BzmB8XhsRqMeI40O8olSiY1StN/gd4EMzMM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR2101MB0729 From: Christoph Hellwig Sent: Thursday, September 2, 2021 1:00= AM >=20 > On Tue, Aug 31, 2021 at 05:16:19PM +0000, Michael Kelley wrote: > > As a quick overview, I think there are four places where the > > shared_gpa_boundary must be applied to adjust the guest physical > > address that is used. Each requires mapping a corresponding > > virtual address range. Here are the four places: > > > > 1) The so-called "monitor pages" that are a core communication > > mechanism between the guest and Hyper-V. These are two single > > pages, and the mapping is handled by calling memremap() for > > each of the two pages. See Patch 7 of Tianyu's series. >=20 > Ah, interesting. >=20 > > 3) The network driver send and receive buffers. vmap_phys_range() > > should work here. >=20 > Actually it won't. The problem with these buffers is that they are > physically non-contiguous allocations. =20 Indeed you are right. These buffers are allocated with vzalloc(). > We really have two sensible options: >=20 > 1) use vmap_pfn as in the current series. But in that case I think > we should get rid of the other mapping created by vmalloc. I > though a bit about finding a way to apply the offset in vmalloc > itself, but I think it would be too invasive to the normal fast > path. So the other sub-option would be to allocate the pages > manually (maybe even using high order allocations to reduce TLB > pressure) and then remap them What's the benefit of getting rid of the other mapping created by vmalloc if it isn't referenced? Just page table space? The default sizes are a 16 Meg receive buffer and a 1 Meg send buffer for each VMbus channel used by netvsc, and usually the max number of channels is 8. So there's 128 Meg of virtual space to be saved on the receive buffers, which could be worth it. Allocating the pages manually is also an option, but we have to be careful about high order allocations. While typically these buffers are allocated during system boot, these synthetic NICs can be hot added and removed while the VM is running. The channel count can also be changed while the VM is running. So multiple 16 Meg receive buffer allocations may need to be done after the system has been running a long time. > 2) do away with the contiguous kernel mapping entirely. This means > the simple memcpy calls become loops over kmap_local_pfn. As > I just found out for the send side that would be pretty easy, > but the receive side would be more work. We'd also need to check > the performance implications. Doing away with the contiguous kernel mapping entirely seems like it would result in fairly messy code to access the buffer. What's the benefit of doing away with the mapping? I'm not an expert on the netvsc driver, but decoding the incoming packets is already fraught with complexities because of the nature of the protocol with Hyper-V. The contiguous kernel mapping at least keeps the basics sane. >=20 > > 4) The swiotlb memory used for bounce buffers. vmap_phys_range() > > should work here as well. >=20 > Or memremap if it works for 1. >=20 > > Case #2 above does unusual mapping. The ring buffer consists of a ring > > buffer header page, followed by one or more pages that are the actual > > ring buffer. The pages making up the actual ring buffer are mapped > > twice in succession. For example, if the ring buffer has 4 pages > > (one header page and three ring buffer pages), the contiguous > > virtual mapping must cover these seven pages: 0, 1, 2, 3, 1, 2, 3. > > The duplicate contiguous mapping allows the code that is reading > > or writing the actual ring buffer to not be concerned about wrap-around > > because writing off the end of the ring buffer is automatically > > wrapped-around by the mapping. The amount of data read or > > written in one batch never exceeds the size of the ring buffer, and > > after a batch is read or written, the read or write indices are adjuste= d > > to put them back into the range of the first mapping of the actual > > ring buffer pages. So there's method to the madness, and the > > technique works pretty well. But this kind of mapping is not > > amenable to using vmap_phys_range(). >=20 > Hmm. Can you point me to where this is mapped? Especially for the > classic non-isolated case where no vmap/vmalloc mapping is involved > at all? The existing code is in hv_ringbuffer_init() in drivers/hv/ring_buffer.c. The code hasn't changed in a while, so any recent upstream code tree is valid to look at. The memory pages are typically allocated in vmbus_alloc_ring() in drivers/hv/channel.c. Michael From xen-devel-bounces@lists.xenproject.org Thu Sep 02 16:14:28 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 16:14:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177402.322788 (Exim 4.92) (envelope-from ) id 1mLpM7-0000Vu-5N; Thu, 02 Sep 2021 16:14:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177402.322788; Thu, 02 Sep 2021 16:14:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLpM7-0000Vn-0q; Thu, 02 Sep 2021 16:14:23 +0000 Received: by outflank-mailman (input) for mailman id 177402; Thu, 02 Sep 2021 16:14:22 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLpM6-0000Vh-Bh for xen-devel@lists.xenproject.org; Thu, 02 Sep 2021 16:14:22 +0000 Received: from outbound.mail.eo.outlook.com (unknown [40.93.3.1]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id d2ae41a4-0c08-11ec-ae8f-12813bfff9fa; Thu, 02 Sep 2021 16:14:17 +0000 (UTC) Received: from MWHPR21MB1593.namprd21.prod.outlook.com (2603:10b6:301:7c::11) by MWHPR21MB0287.namprd21.prod.outlook.com (2603:10b6:300:7a::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.7; Thu, 2 Sep 2021 16:14:04 +0000 Received: from MWHPR21MB1593.namprd21.prod.outlook.com ([fe80::3c8b:6387:cd5:7d86]) by MWHPR21MB1593.namprd21.prod.outlook.com ([fe80::3c8b:6387:cd5:7d86%8]) with mapi id 15.20.4478.014; Thu, 2 Sep 2021 16:14:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d2ae41a4-0c08-11ec-ae8f-12813bfff9fa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FNoAqQoI71meammxhfj/gx/c4tb7ezx8HjYle3+uh/lGS+KUgOHxk2xCR+m9lPzeQ4UqiOR0CNZ6slDBS3fO1CGM202k3dYbdbApMSIGBz9zRY/stncl6btwYCpR2M9FI+YBX9p+V53Lflh6Yhia5ir8QsDONyyw8HGewaV2YIcYSrIAzIRVjiOqtfO1Ul17Bp1IysbZxz5EommUMrNUbtySJg28jD7ZJ/Ja1QLSmGfnJCP5tAYJwuD2O0a/fbrMNvYBaw17RNoPYjyM/ak6B1Yonc7FtOhFvsCIrqVRCKcBrRofVLzQ0AAk47ltrFR24kiplPOhsTY42R6Ey5DJMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=h8kFc9GqemG3bgd5NrDd4yM/37itRP5ArxE57wxbEBg=; b=RIpmuxN6L/mRNY3I47H+xtO3SGaKme1u7YzdHF90Gx6MRF0jLM09QwOS54FQpv3/Cwot/atmlLIYXSqjh7L2cWt/wFJ6Zsas9JyVk2vxiWT8PcOL6/mGBq2abT3tY0oh6phldoRgDtfYLrP4e7tBLYJ6dK0g5BdT/g740+I8tpb71g6hPp7p+Sx6u+ci8pvRiwMEAJ7rT7ZsbzEcMeT8cQdRCQ8nbXULJL7+6RvpifaZIZkYOFTNi2KE/q0oNRXC++y4RWbvQbzyznu4dFkSt4S9xONtE2tP2SH4vDWMPELiBS8KlSacXyUnwf4Gp0kMt6L/u0HdnvCicxBO9QxWWg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=h8kFc9GqemG3bgd5NrDd4yM/37itRP5ArxE57wxbEBg=; b=bxo3sTyL6l/ajEMjZ4L7vv/WZ91eFA0PYD0Qm08JtECVJgnf10eigJ2XiYudU8qhGB/WxQbZ1VqS/az+2znapb61sHQFHw4p0tPsJ2W7y5zXIalp1ombnzzPBaSO8gem6IdwAUO09cIrWmse5A1T5/fqbZiLTw+QCIfkpezMqhg= From: Michael Kelley To: Tianyu Lan , KY Srinivasan , Haiyang Zhang , Stephen Hemminger , "wei.liu@kernel.org" , Dexuan Cui , "catalin.marinas@arm.com" , "will@kernel.org" , "tglx@linutronix.de" , "mingo@redhat.com" , "bp@alien8.de" , "x86@kernel.org" , "hpa@zytor.com" , "dave.hansen@linux.intel.com" , "luto@kernel.org" , "peterz@infradead.org" , "konrad.wilk@oracle.com" , "boris.ostrovsky@oracle.com" , "jgross@suse.com" , "sstabellini@kernel.org" , "joro@8bytes.org" , "davem@davemloft.net" , "kuba@kernel.org" , "jejb@linux.ibm.com" , "martin.petersen@oracle.com" , "gregkh@linuxfoundation.org" , "arnd@arndb.de" , "hch@lst.de" , "m.szyprowski@samsung.com" , "robin.murphy@arm.com" , "brijesh.singh@amd.com" , "thomas.lendacky@amd.com" , Tianyu Lan , "pgonda@google.com" , "martin.b.radev@gmail.com" , "akpm@linux-foundation.org" , "kirill.shutemov@linux.intel.com" , "rppt@kernel.org" , "hannes@cmpxchg.org" , "aneesh.kumar@linux.ibm.com" , "krish.sadhukhan@oracle.com" , "saravanand@fb.com" , "linux-arm-kernel@lists.infradead.org" , "xen-devel@lists.xenproject.org" , "rientjes@google.com" , "ardb@kernel.org" CC: "iommu@lists.linux-foundation.org" , "linux-arch@vger.kernel.org" , "linux-hyperv@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-scsi@vger.kernel.org" , "netdev@vger.kernel.org" , vkuznets , "parri.andrea@gmail.com" , "dave.hansen@intel.com" Subject: RE: [PATCH V4 08/13] hyperv/vmbus: Initialize VMbus ring buffer for Isolation VM Thread-Topic: [PATCH V4 08/13] hyperv/vmbus: Initialize VMbus ring buffer for Isolation VM Thread-Index: AQHXm2gFIWSYU02+UUyReBHQOl5/ZauK4YnAgAXmhwCAACrvQA== Date: Thu, 2 Sep 2021 16:14:04 +0000 Message-ID: References: <20210827172114.414281-1-ltykernel@gmail.com> <20210827172114.414281-9-ltykernel@gmail.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ActionId=ef79cd5e-7331-4c0e-adbb-97b052469058;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=true;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Standard;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=Internal;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2021-09-02T16:09:28Z;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=microsoft.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 1a10f30f-c31a-4b0c-12e9-08d96e2caf25 x-ms-traffictypediagnostic: MWHPR21MB0287: x-ms-exchange-transport-forked: True x-ld-processed: 72f988bf-86f1-41af-91ab-2d7cd011db47,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6790; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: vGOnTAxLePV4piCloHPg0HNrCCKjFqOJ03ruJTD+GCTP4UF1PaIK8gwhHPNNJd14psyj+2zOuqCghmd5/QHhATYperkokL2M12IxevdCyHmBPDh+Qgm6ulnw8OMa5ixVRiPXubatO98NxHkDlLHXQUYyQDkDpwkGuNzcMm0ceaN/LcPSGXJfiqeX56JxG/D/uUS39/B5AuEwZcK6As1J8g4sor69545UO6Zw+KPQgxxsQmYjmqMEJsdmrJCjFXrsx8JqF7WaVkuG80PlsWUK79QEgR3bcQ0nyfBortk07bKMHcZ35skTY6qzrPGorYewMWQgW7ai29WoD38r29USg8yQ3U2bhhWvFl37eFF9YTwinIwhxogysj2bI79io89Y7VyxlN7DU/n8mQJ60i8cjI/FYto8urP0xwEWSp12oOSmIna5dv1Gr7In4RIe6Aw1q0CXcDf9t9h7QQN5ITJWn3nLGev7fAQPS19uuHLBSlg/oUnWlfDmYUGgyet6+vRl1jbMMuoA0ZXO3Ll/QtTH1oVj29pRnpB2uZs9gQXV/nOD5I59sKFWbhIUffkaNQL7wGNZlKoQGOZVi7jO3Qhz4L/dqJKsEHjgAs+24BrkcJmvkQJbqI0aOXolLK/UdCD9mI4IJdtorvhNLuBa5KVLBkiBBNxKYAJcWS5CkREIS4XdcWAKUpOo9I951VnvK0yLIoLqeI6VUItSznjK6B2tuQG/8/7nHfE+YPP3bp8m8U0= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR21MB1593.namprd21.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(10290500003)(186003)(86362001)(76116006)(8936002)(7416002)(7366002)(122000001)(38100700002)(71200400001)(82960400001)(2906002)(82950400001)(38070700005)(8676002)(55016002)(26005)(7406005)(53546011)(4326008)(921005)(64756008)(66446008)(66556008)(66476007)(66946007)(6506007)(316002)(52536014)(33656002)(8990500004)(110136005)(7696005)(9686003)(5660300002)(54906003)(508600001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?SCt0SWxWdDhBK1BQSUR2TUFWS1dNcWpkb2htRDJLT3VSTmp1aEdWaDRFZzFP?= =?utf-8?B?aUtuSW1QTEJSR3AzOTV4bFhWZ0RBOGkveUxzMWk3Q0pKRk52cmpwWW0wTTEz?= =?utf-8?B?MlNMYVFPYVk3bEJ1N1puSXJGSjJvWVZXS1dWL2U0T0RwYWJidmJMMDlEd2xj?= =?utf-8?B?TnJLREpxN2VJWE1vWTlJS1lkWDhMTExzd1BqbjFMRFFLSUQweGZpZmFXZllL?= =?utf-8?B?OStUY3VLc2h0STZFUWt4MG1Rb2F6MDlXdyttT0pHb28yWElzT3lPMEJobnhG?= =?utf-8?B?SjQzWWtVU1FwZkNuSXpvYXkwRWlOMUVFRDBsNG5oQ1FnTi90VXdYSitoQml4?= =?utf-8?B?TkNoZmZDbVpJWS81Q3BVTmxLZ0RpY0JqR1pjUjRPa29vT3RyYnZhcHBZSTJj?= =?utf-8?B?cVZMM2dOU1dmYnJzVFhFUDJETlBoWWdYYVU4Yml0TDFFS21uU094L21CaktI?= =?utf-8?B?dFYrSTkvd0I0dVMxL3JJZE9DRVlCeXNzck1ZRlFjaHBVVHhLaDE2ME5FN2hl?= =?utf-8?B?ZEx4eCtEOXNjcEN4RGFBQnNVSHM1cGMyN2VEajgxdW1ucGNPLzNONXdlRG1m?= =?utf-8?B?MUN1MnE1S2xISmx1bFl0YldCREFEM2UxSFhrM0R1M1IzR3VRSVRaN1czUzlR?= =?utf-8?B?TldwejRPcXNyQWdxNmVWeEdNcHJGcEt4dWRmQWljRFc2WXAxMkJFM2NOU2Mw?= =?utf-8?B?b2ZhdDJHU3gzZ1dLMll4b3JlYlg0NlRMYlV6UW5odVROL2hVdlZIVFdkdnVn?= =?utf-8?B?QUtIODVrTXVhd0hTVFVob0p1N0gycjRvSUJDTjdiWDZVZURUcGFlNkdFYzkz?= =?utf-8?B?R1JEVjRPWDVQa1Z4eVUzNCs2OFlJdWd6UXVyWWR5b2I1T0poWFo4cEZwMXJQ?= =?utf-8?B?YkdRby9pQTczUmdCd1NBcE95Um96SytST1NQWUtQaENwRkRReG1paTF5M3NG?= =?utf-8?B?VFhFSFlvSVAwMUVsUUNPNUF0NStDcGdNWVNvdjVHcWJaV25vdC9WdU4ySkUx?= =?utf-8?B?SFFnMXJZZDFlc01sTGk5YUJ3UWRqbHIvOUYxMXN0MW8xai9SaW5oblVWTXly?= =?utf-8?B?ZGg4cnVYKytXR1BUSVVGdndPL2ZyY1ZUdXFibWdHMkt0QUFBenAxYVZzdnRP?= =?utf-8?B?SmxwOWh5K1p5blQvZlFYZnN5TStHb0dnV3hNVFB3b1JGOEQvbFFzOXpOUlpa?= =?utf-8?B?S1IrTU1ROVZ6U0ExSXhhMTNCM0xyN00zRkN6d0pHUi9LOEl6YlI3VjNKVjdK?= =?utf-8?B?SDE5bnRGa01DQS92dGxET0p0YVJMNCtMYm9OOTVFa3dWZEpFeGtkbHVPQmhw?= =?utf-8?B?cnNVUVNYdFdXWW9SNzQ0ajFQWUpXc2Y5YmdNVUVpWW9QREozVlRyL3YyUHFW?= =?utf-8?B?cU1kVHFFRFJ3QWdZQm1WTFlGeU8rcWM4di9DTUc2dW5qMmJYZFZ6L2h4aVVM?= =?utf-8?B?RUx1VmVuY2VqODB4QjBoTEh3N0ZHUENkWjdHVktmcGVXV3F6TkhmRDNra1ht?= =?utf-8?B?UUtLQ0x5dGFJYVE5ejRaMnlKbVdKUzN4MGh1N3hIV3NVNDRLbEYvT2s1SXE5?= =?utf-8?B?bFVTOG1jQklFZkIrRlNFVkhQeldLeSszMXpUc2xwdk9KMThiYk8xL3ZxTmVR?= =?utf-8?B?bTBkelJ6aDVubW1GcmY2R0ZOSUIrcmJaM21pMFQzcmI1WHQwdUEySzBpUmZR?= =?utf-8?B?ZGJlTFFSdDBaMXlFMlhyZHFQSnhyV1dKUGZpdVBtQUt0Q1IxS1JlaXpQWkJH?= =?utf-8?Q?/KsbFS+FFu/eogW6zR47LkfqSJoFw1GvK9smoaR?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR21MB1593.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1a10f30f-c31a-4b0c-12e9-08d96e2caf25 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Sep 2021 16:14:04.3146 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Yw5Wps3Lv7L2sgCGbAiKeaqoXpEbacvM3u28PlfRsJjUhekwDNXnedm/jETY+2tdzXKwgkE0gULqGhseUsLO+Qp5f6JA9+HASQ+PuOVd7Os= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR21MB0287 RnJvbTogVGlhbnl1IExhbiA8bHR5a2VybmVsQGdtYWlsLmNvbT4gU2VudDogVGh1cnNkYXksIFNl cHRlbWJlciAyLCAyMDIxIDY6MzYgQU0NCj4gDQo+IE9uIDkvMi8yMDIxIDg6MjMgQU0sIE1pY2hh ZWwgS2VsbGV5IHdyb3RlOg0KPiA+PiArCX0gZWxzZSB7DQo+ID4+ICsJCXBhZ2VzX3dyYXBhcm91 bmQgPSBrY2FsbG9jKHBhZ2VfY250ICogMiAtIDEsDQo+ID4+ICsJCQkJCSAgIHNpemVvZihzdHJ1 Y3QgcGFnZSAqKSwNCj4gPj4gKwkJCQkJICAgR0ZQX0tFUk5FTCk7DQo+ID4+ICsNCj4gPj4gKwkJ cGFnZXNfd3JhcGFyb3VuZFswXSA9IHBhZ2VzOw0KPiA+PiArCQlmb3IgKGkgPSAwOyBpIDwgMiAq IChwYWdlX2NudCAtIDEpOyBpKyspDQo+ID4+ICsJCQlwYWdlc193cmFwYXJvdW5kW2kgKyAxXSA9 DQo+ID4+ICsJCQkJJnBhZ2VzW2kgJSAocGFnZV9jbnQgLSAxKSArIDFdOw0KPiA+PiArDQo+ID4+ ICsJCXJpbmdfaW5mby0+cmluZ19idWZmZXIgPSAoc3RydWN0IGh2X3JpbmdfYnVmZmVyICopDQo+ ID4+ICsJCQl2bWFwKHBhZ2VzX3dyYXBhcm91bmQsIHBhZ2VfY250ICogMiAtIDEsIFZNX01BUCwN Cj4gPj4gKwkJCQlQQUdFX0tFUk5FTCk7DQo+ID4+ICsNCj4gPj4gKwkJa2ZyZWUocGFnZXNfd3Jh cGFyb3VuZCk7DQo+ID4+ICsJCWlmICghcmluZ19pbmZvLT5yaW5nX2J1ZmZlcikNCj4gPj4gKwkJ CXJldHVybiAtRU5PTUVNOw0KPiA+PiArCX0NCj4gPiBXaXRoIHRoaXMgcGF0Y2gsIHRoZSBjb2Rl IGlzIGEgYmlnICJpZiIgc3RhdGVtZW50IHdpdGggdHdvIGhhbHZlcyAtLSBvbmUNCj4gPiB3aGVu IFNOUCBpc29sYXRpb24gaXMgaW4gZWZmZWN0LCBhbmQgdGhlIG90aGVyIHdoZW4gbm90LiAgVGhl IFNOUCBpc29sYXRpb24NCj4gPiBjYXNlIGRvZXMgdGhlIHdvcmsgdXNpbmcgUEZOcyB3aXRoIHRo ZSBzaGFyZWRfZ3BhX2JvdW5kYXJ5IGFkZGVkLA0KPiA+IHdoaWxlIHRoZSBvdGhlciBjYXNlIGRv ZXMgdGhlIHNhbWUgd29yayBidXQgdXNpbmcgc3RydWN0IHBhZ2UuICBQZXJoYXBzDQo+ID4gSSdt IG1pc3Npbmcgc29tZXRoaW5nLCBidXQgY2FuIGJvdGggaGFsdmVzIGJlIGNvbWJpbmVkIGFuZCBh bHdheXMNCj4gPiBkbyB0aGUgd29yayB1c2luZyBQRk5zPyAgVGhlIG9ubHkgZGlmZmVyZW5jZSBp cyB3aGV0aGVyIHRvIGFkZCB0aGUNCj4gPiBzaGFyZWRfZ3BhX2JvdW5kYXJ5LCBhbmQgd2hldGhl ciB0byB6ZXJvIHRoZSBtZW1vcnkgd2hlbiBkb25lLg0KPiA+IFNvIGdldCB0aGUgc3RhcnRpbmcg UEZOLCB0aGVuIGhhdmUgYW4gImlmIiBzdGF0ZW1lbnQgZm9yIHdoZXRoZXIgdG8NCj4gPiBhZGQg dGhlIHNoYXJlZF9ncGFfYm91bmRhcnkuICBUaGVuIGV2ZXJ5dGhpbmcgZWxzZSBpcyB0aGUgc2Ft ZS4NCj4gPiBBdCB0aGUgZW5kLCB1c2UgYW4gImlmIiBzdGF0ZW1lbnQgdG8gZGVjaWRlIHdoZXRo ZXIgdG8gemVybyB0aGUNCj4gPiBtZW1vcnkuICBJdCB3b3VsZCByZWFsbHkgYmUgYmV0dGVyIHRv IGhhdmUgdGhlIGxvZ2ljIGluIHRoaXMgYWxnb3JpdGhtDQo+ID4gY29kZWQgb25seSBvbmNlLg0K PiA+DQo+IA0KPiBIaSBNaWNoYWVsOg0KPiAJSSBoYXZlIHRyaWVkIHRoaXMgYmVmb3JlLiBCdXQg dm1hcF9wZm4oKSBvbmx5IHdvcmtzIGZvciB0aG9zZSBwZm5zIG91dA0KPiBvZiBub3JtYWwgbWVt b3J5LiBQbGVhc2Ugc2VlIHZtYXBfcGZuX2FwcGx5KCkgZm9yIGRldGFpbCBhbmQNCj4gcmV0dXJu IGVycm9yIHdoZW4gdGhlIFBGTiBpcyB2YWxpZC4NCj4gDQoNCkluZGVlZC4gIFRoaXMgdGllcyBp bnRvIHRoZSBkaXNjdXNzaW9uIHdpdGggQ2hyaXN0b3BoIGFib3V0IGNvbWluZyB1cA0Kd2l0aCBn ZW5lcmFsaXplZCBoZWxwZXIgZnVuY3Rpb25zIHRvIGFzc2lzdCBpbiBoYW5kbGluZyB0aGUNCnNo YXJlZF9ncGFfYm91bmRhcnkuICAgSGF2aW5nIGEgc2luZ2xlIGltcGxlbWVudGF0aW9uIGhlcmUg aW4NCmh2X3JpbmdidWZmZXJfaW5pdCgpIHdvdWxkIGJlIGEgZ29vZCBnb2FsIGFzIHdlbGwuDQoN Ck1pY2hhZWwNCg0K From xen-devel-bounces@lists.xenproject.org Thu Sep 02 16:15:50 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 16:15:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177409.322798 (Exim 4.92) (envelope-from ) id 1mLpNW-00015z-Fu; Thu, 02 Sep 2021 16:15:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177409.322798; Thu, 02 Sep 2021 16:15:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLpNW-00015s-CW; Thu, 02 Sep 2021 16:15:50 +0000 Received: by outflank-mailman (input) for mailman id 177409; Thu, 02 Sep 2021 16:15:48 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLpNU-00015i-QN for xen-devel@lists.xenproject.org; Thu, 02 Sep 2021 16:15:48 +0000 Received: from mail-wr1-x432.google.com (unknown [2a00:1450:4864:20::432]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id d0586f74-3c3b-45c3-9d4d-5e8b10b51373; Thu, 02 Sep 2021 16:15:47 +0000 (UTC) Received: by mail-wr1-x432.google.com with SMTP id b10so3884094wru.0 for ; Thu, 02 Sep 2021 09:15:47 -0700 (PDT) Received: from x1w.. (163.red-83-52-55.dynamicip.rima-tde.net. [83.52.55.163]) by smtp.gmail.com with ESMTPSA id j18sm2355853wrd.56.2021.09.02.09.15.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Sep 2021 09:15:45 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list X-Inumbo-ID: d0586f74-3c3b-45c3-9d4d-5e8b10b51373 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Cx9tmtcMe/yqb/L4FxX6s6fgCGjzmE2xzXTNn5n4WRY=; b=mcdkcgUkPmIymlgoHwDrJpvE9KHw9dvSG2MlkuM7+LMu3zkIYpqtCeCGgcISYDoKCb 8696YyJt2CPh12bbX7QpwDA8IAMyJN7taR/RiiyUq4y4j+fSACZ5oqQ08yGPg+QlMR0S hitbbr51iTLrvFSzYtCDWEBhD9WU3oObbn7IgCnxkcpgU8/Bpb/PRbBi6oyJFhSCPB/4 T4eJ4wL0xOuOcg0FizPKZv0AhuncICKZC1qKdxIbn5OpaC/dbV050AWnqohvIXKAkBb9 MuFoocUeCUvdcKKf//7Z32DJC9YmwC2EKSjtLp0AMfq+R5Wwnd7FM6PpEyUZ4hvUxjzc 2tig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; bh=Cx9tmtcMe/yqb/L4FxX6s6fgCGjzmE2xzXTNn5n4WRY=; b=OwocEGUbclqWd/677oejQXsrZXjgc5UQ+9J8GvdslFFo/Vtv6tLZ6c5NUFLE3+hImw ckHmp67mWdqSqLEibxLjf5CCDhO51d08PAkBKWlodtkcCQ0GB2mSPb48nuneKm6vORtt Exhc/64bLOIUgZWlHbwUJNQsQoyHXCnD1uvGCHm6i1fR7kwPPq8D/UXNvw6WDySyzofL NMpBhkoZBmXZKK4KrRw2QcfygjvXixEKdshDkMhzMNhVs2fxd5Imgku2XtmrB+zN+DY5 pnKZnG+GpDtQNF6GUT/uoQUiB7gMfj4sYO/5Lju21+VN7uQHq5gDkuNGGNa9514YvSLl MF9A== X-Gm-Message-State: AOAM532VeWCOR6jst8TMpFBX3Crt5lC8mlUjGzbELNXKEFX7FDceZgT+ vAv9dya/i53k0ZwTNDlAuiY= X-Google-Smtp-Source: ABdhPJwMW19l1RT5uyseQGoPrvV+9UXH/fieGpgiPEuYOlcUopWj6VFIU2AjhhvSZ8tr8ff4GeIa0w== X-Received: by 2002:adf:8144:: with SMTP id 62mr4741623wrm.144.1630599347027; Thu, 02 Sep 2021 09:15:47 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Bin Meng , Eduardo Habkost , Greg Kurz , haxm-team@intel.com, Kamil Rytarowski , qemu-ppc@nongnu.org, Anthony Perard , Marcel Apfelbaum , Michael Rolnik , qemu-riscv@nongnu.org, Paolo Bonzini , Jiaxun Yang , Thomas Huth , David Hildenbrand , Chris Wulff , Laurent Vivier , Cameron Esfahani , Sunil Muthuswamy , Max Filippov , Taylor Simpson , qemu-s390x@nongnu.org, Richard Henderson , Bastian Koppelmann , Yoshinori Sato , Artyom Tarasenko , Aurelien Jarno , Paul Durrant , Peter Maydell , David Gibson , Alistair Francis , "Edgar E. Iglesias" , Roman Bolshakov , Laurent Vivier , Cornelia Huck , qemu-arm@nongnu.org, Wenchao Wang , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , xen-devel@lists.xenproject.org, Marek Vasut , Stefano Stabellini , Aleksandar Rikalo , Mark Cave-Ayland , Colin Xu , Claudio Fontana , Palmer Dabbelt , Stafford Horne , Reinoud Zandijk , kvm@vger.kernel.org Subject: [PATCH v3 00/30] accel: Move has_work() from SysemuCPUOps to AccelOpsClass Date: Thu, 2 Sep 2021 18:15:13 +0200 Message-Id: <20210902161543.417092-1-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi,=0D =0D CPU has_work() is a per-accelerator handler. This series=0D - explicit the KVM / WHPX implementations=0D - moves TCG implementations in AccelOpsClass=0D - explicit missing implementations (returning 'false').=0D =0D Since v2:=0D - Full rewrite, no more RFC.=0D =0D Supersedes: <20210304222323.1954755-1-f4bug@amsat.org>=0D "cpu: Move CPUClass::has_work() to TCGCPUOps"=0D =0D Philippe Mathieu-Daud=C3=A9 (30):=0D accel/tcg: Restrict cpu_handle_halt() to sysemu=0D hw/core: Restrict cpu_has_work() to sysemu=0D hw/core: Un-inline cpu_has_work()=0D sysemu: Introduce AccelOpsClass::has_work()=0D accel/kvm: Implement AccelOpsClass::has_work()=0D accel/whpx: Implement AccelOpsClass::has_work()=0D accel/tcg: Implement AccelOpsClass::has_work() as stub=0D target/alpha: Restrict has_work() handler to sysemu and TCG=0D target/arm: Restrict has_work() handler to sysemu and TCG=0D target/avr: Restrict has_work() handler to sysemu and TCG=0D target/cris: Restrict has_work() handler to sysemu and TCG=0D target/hexagon: Remove unused has_work() handler=0D target/hppa: Restrict has_work() handler to sysemu and TCG=0D target/i386: Restrict has_work() handler to sysemu and TCG=0D target/m68k: Restrict has_work() handler to sysemu and TCG=0D target/microblaze: Restrict has_work() handler to sysemu and TCG=0D target/mips: Restrict has_work() handler to sysemu and TCG=0D target/nios2: Restrict has_work() handler to sysemu and TCG=0D target/openrisc: Restrict has_work() handler to sysemu and TCG=0D target/ppc: Restrict has_work() handler to sysemu and TCG=0D target/ppc: Introduce PowerPCCPUClass::has_work()=0D target/ppc: Simplify has_work() handlers=0D target/riscv: Restrict has_work() handler to sysemu and TCG=0D target/rx: Restrict has_work() handler to sysemu and TCG=0D target/s390x: Restrict has_work() handler to sysemu and TCG=0D target/sh4: Restrict has_work() handler to sysemu and TCG=0D target/sparc: Restrict has_work() handler to sysemu and TCG=0D target/tricore: Restrict has_work() handler to sysemu and TCG=0D target/xtensa: Restrict has_work() handler to sysemu and TCG=0D accel: Add missing AccelOpsClass::has_work() and drop SysemuCPUOps one=0D =0D include/hw/core/cpu.h | 28 +--=0D include/hw/core/tcg-cpu-ops.h | 4 +=0D include/sysemu/accel-ops.h | 5 +=0D target/ppc/cpu-qom.h | 3 +=0D accel/hvf/hvf-accel-ops.c | 6 +=0D accel/kvm/kvm-accel-ops.c | 6 +=0D accel/qtest/qtest.c | 6 +=0D accel/tcg/cpu-exec.c | 8 +-=0D accel/tcg/tcg-accel-ops.c | 12 ++=0D accel/xen/xen-all.c | 6 +=0D hw/core/cpu-common.c | 6 -=0D softmmu/cpus.c | 10 +-=0D target/alpha/cpu.c | 4 +-=0D target/arm/cpu.c | 7 +-=0D target/avr/cpu.c | 4 +-=0D target/cris/cpu.c | 4 +-=0D target/hexagon/cpu.c | 6 -=0D target/hppa/cpu.c | 4 +-=0D target/i386/cpu.c | 6 -=0D target/i386/hax/hax-accel-ops.c | 6 +=0D target/i386/nvmm/nvmm-accel-ops.c | 6 +=0D target/i386/tcg/tcg-cpu.c | 8 +-=0D target/i386/whpx/whpx-accel-ops.c | 6 +=0D target/m68k/cpu.c | 4 +-=0D target/microblaze/cpu.c | 10 +-=0D target/mips/cpu.c | 4 +-=0D target/nios2/cpu.c | 4 +-=0D target/openrisc/cpu.c | 4 +-=0D target/ppc/cpu_init.c | 324 +++++++++++++++---------------=0D target/riscv/cpu.c | 8 +-=0D target/rx/cpu.c | 4 +-=0D target/s390x/cpu.c | 4 +-=0D target/sh4/cpu.c | 7 +-=0D target/sparc/cpu.c | 4 +-=0D target/tricore/cpu.c | 6 +-=0D target/xtensa/cpu.c | 16 +-=0D 36 files changed, 321 insertions(+), 239 deletions(-)=0D =0D -- =0D 2.31.1=0D =0D From xen-devel-bounces@lists.xenproject.org Thu Sep 02 16:15:55 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 16:15:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177410.322810 (Exim 4.92) (envelope-from ) id 1mLpNb-0001P0-Om; Thu, 02 Sep 2021 16:15:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177410.322810; Thu, 02 Sep 2021 16:15:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLpNb-0001On-Kk; Thu, 02 Sep 2021 16:15:55 +0000 Received: by outflank-mailman (input) for mailman id 177410; Thu, 02 Sep 2021 16:15:54 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLpNa-0001O1-ER for xen-devel@lists.xenproject.org; Thu, 02 Sep 2021 16:15:54 +0000 Received: from mail-wr1-x434.google.com (unknown [2a00:1450:4864:20::434]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 23b39658-0c63-477d-af8b-3222810181c7; Thu, 02 Sep 2021 16:15:53 +0000 (UTC) Received: by mail-wr1-x434.google.com with SMTP id z4so3826952wrr.6 for ; Thu, 02 Sep 2021 09:15:53 -0700 (PDT) Received: from x1w.. (163.red-83-52-55.dynamicip.rima-tde.net. [83.52.55.163]) by smtp.gmail.com with ESMTPSA id j17sm2187403wrh.67.2021.09.02.09.15.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Sep 2021 09:15:52 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list X-Inumbo-ID: 23b39658-0c63-477d-af8b-3222810181c7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=/9vCQQZfSaTpKBQMegFXjFo179Y+24zi0HZDvs7SgMU=; b=nvF/c2Wc4Z15cqg2fwhp1NDrfdcdFXpuAmJa1KWBtzQQ/EXWFrb73xtrx8OZfbtAYH +ID89t8hrTCsxgu2Z9TktIv56PS86hvs5RilCbo/0PLhtchmK7Btfa7sZb3B2zUVbiHv /HU6lzJWGffGyztr061l6mMVTzRO0XEqa1r0BVkwLvpIuHEZFGdUMQyYCTDsiXNgmkvC mzGCP4B8dDeCO3p+Tu6JIdorMuA2pmQP2RRlgrSmz9a3spLyNyj6mRRUHHOVQRLc9UFi tO8C8CpGWtVF4XqV+ujfpe9fj5HRkBRHkHwyv6P8VevMMXH157Vbk0qwXp550NWCjx06 CBMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=/9vCQQZfSaTpKBQMegFXjFo179Y+24zi0HZDvs7SgMU=; b=WL3BQx8x1N6N3//lKXNlq44llQPFA0y0sZtxbi1fmBnxXbUDjLIEgJINkdGIkSwOwX 3kjySHcaFGGzF8WA/XcdJD0LdyfYFoMQgX1Ysn7IkUwk9/MXQxGf3gDMR6m3e4qUCm4t V5cVeV4WwY4zplXWk503JP05jSo1F6bCe/LEVS7GFn+ibUK5uVug5XqHzZvYtCaAHryt nA9taw61VwhQwkSNP6CxwquPmCOFd9DQnohy+gjzHL+HOzox1hjzspTsF/wF0jUjNXQJ Gy46xURJvwYxfCrErFBZkPQuYQHYTTi7O7GI77ayGenfNAzruqMFd9FnyTv142SsgMyk REOQ== X-Gm-Message-State: AOAM533DWCk/Kz9hxbV9Zt/ADqILugl7KLDKz+/gK44zXFXWnYzj3ltP 48d6crHEjBiKdzK2Ms1AThU= X-Google-Smtp-Source: ABdhPJxxdNDVWzqPqP9AvO+fc8KPo1qKTWTpE1Z3SovcisiYMadm8391Ql4b1VZQyA/+Rjg0YRdLPg== X-Received: by 2002:a05:6000:186:: with SMTP id p6mr4881125wrx.210.1630599352772; Thu, 02 Sep 2021 09:15:52 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Bin Meng , Eduardo Habkost , Greg Kurz , haxm-team@intel.com, Kamil Rytarowski , qemu-ppc@nongnu.org, Anthony Perard , Marcel Apfelbaum , Michael Rolnik , qemu-riscv@nongnu.org, Paolo Bonzini , Jiaxun Yang , Thomas Huth , David Hildenbrand , Chris Wulff , Laurent Vivier , Cameron Esfahani , Sunil Muthuswamy , Max Filippov , Taylor Simpson , qemu-s390x@nongnu.org, Richard Henderson , Bastian Koppelmann , Yoshinori Sato , Artyom Tarasenko , Aurelien Jarno , Paul Durrant , Peter Maydell , David Gibson , Alistair Francis , "Edgar E. Iglesias" , Roman Bolshakov , Laurent Vivier , Cornelia Huck , qemu-arm@nongnu.org, Wenchao Wang , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , xen-devel@lists.xenproject.org, Marek Vasut , Stefano Stabellini , Aleksandar Rikalo , Mark Cave-Ayland , Colin Xu , Claudio Fontana , Palmer Dabbelt , Stafford Horne , Reinoud Zandijk , kvm@vger.kernel.org Subject: [PATCH v3 01/30] accel/tcg: Restrict cpu_handle_halt() to sysemu Date: Thu, 2 Sep 2021 18:15:14 +0200 Message-Id: <20210902161543.417092-2-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210902161543.417092-1-f4bug@amsat.org> References: <20210902161543.417092-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Commit 372579427a5 ("tcg: enable thread-per-vCPU") added the following comment describing EXCP_HALTED in qemu_tcg_cpu_thread_fn(): case EXCP_HALTED: /* during start-up the vCPU is reset and the thread is * kicked several times. If we don't ensure we go back * to sleep in the halted state we won't cleanly * start-up when the vCPU is enabled. * * cpu->halted should ensure we sleep in wait_io_event */ g_assert(cpu->halted); break; qemu_wait_io_event() is sysemu-specific, so we can restrict the cpu_handle_halt() call in cpu_exec() to system emulation. Signed-off-by: Philippe Mathieu-Daudé --- accel/tcg/cpu-exec.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/accel/tcg/cpu-exec.c b/accel/tcg/cpu-exec.c index 7a6dd9049f0..6b61262b151 100644 --- a/accel/tcg/cpu-exec.c +++ b/accel/tcg/cpu-exec.c @@ -586,10 +586,11 @@ static inline void tb_add_jump(TranslationBlock *tb, int n, return; } +#ifndef CONFIG_USER_ONLY static inline bool cpu_handle_halt(CPUState *cpu) { if (cpu->halted) { -#if defined(TARGET_I386) && !defined(CONFIG_USER_ONLY) +#if defined(TARGET_I386) if (cpu->interrupt_request & CPU_INTERRUPT_POLL) { X86CPU *x86_cpu = X86_CPU(cpu); qemu_mutex_lock_iothread(); @@ -597,7 +598,7 @@ static inline bool cpu_handle_halt(CPUState *cpu) cpu_reset_interrupt(cpu, CPU_INTERRUPT_POLL); qemu_mutex_unlock_iothread(); } -#endif +#endif /* TARGET_I386 */ if (!cpu_has_work(cpu)) { return true; } @@ -607,6 +608,7 @@ static inline bool cpu_handle_halt(CPUState *cpu) return false; } +#endif /* !CONFIG_USER_ONLY */ static inline void cpu_handle_debug_exception(CPUState *cpu) { @@ -865,9 +867,11 @@ int cpu_exec(CPUState *cpu) /* replay_interrupt may need current_cpu */ current_cpu = cpu; +#ifndef CONFIG_USER_ONLY if (cpu_handle_halt(cpu)) { return EXCP_HALTED; } +#endif rcu_read_lock(); -- 2.31.1 From xen-devel-bounces@lists.xenproject.org Thu Sep 02 16:16:01 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 16:16:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177411.322820 (Exim 4.92) (envelope-from ) id 1mLpNh-0001kT-6Y; Thu, 02 Sep 2021 16:16:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177411.322820; Thu, 02 Sep 2021 16:16:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLpNh-0001kK-3Z; Thu, 02 Sep 2021 16:16:01 +0000 Received: by outflank-mailman (input) for mailman id 177411; Thu, 02 Sep 2021 16:16:00 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLpNg-0001jd-F9 for xen-devel@lists.xenproject.org; Thu, 02 Sep 2021 16:16:00 +0000 Received: from mail-wr1-x431.google.com (unknown [2a00:1450:4864:20::431]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 3e79055f-777a-4214-9dcd-58dbc5b4c0b9; Thu, 02 Sep 2021 16:15:59 +0000 (UTC) Received: by mail-wr1-x431.google.com with SMTP id z4so3827438wrr.6 for ; Thu, 02 Sep 2021 09:15:59 -0700 (PDT) Received: from x1w.. (163.red-83-52-55.dynamicip.rima-tde.net. [83.52.55.163]) by smtp.gmail.com with ESMTPSA id x9sm1939663wmi.30.2021.09.02.09.15.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Sep 2021 09:15:58 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list X-Inumbo-ID: 3e79055f-777a-4214-9dcd-58dbc5b4c0b9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=IALuJS79v15vDPvWp0gEXOFVB8QcuCBujL3iQm4WVXc=; b=lyX2iDyZ4fZxIDfBFZ3tyjvTVxQHi5/DKPStvMf8XLdWBZf2Z4YEuBxLZ6HKfP2S0S 9fzfqOWFn0kWTui3s6TURapTU3z+GQ8v8hJn1LfoSFOHPkdm35vCxTfT+cYkW1nrugty mCqdxM8mrNR5MLebQDolGLEo/7Lkgdj2gwYMGjuH7g4aAADt1Bq23c52IZGz+2AB+NL8 GZ3E3+ftKA9QL43iXqO6Ak9f9Icd3LYBSFwdaV1YhiiVZy5M0xyjWQ/L7Ym3RUz2AJov QL67c+ediBlqlyYZ/UNrRKxOjNTuB98lMijtK7yEZi/9rGhzXp+Rvgvey6qwTDyAgy4I 6qHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=IALuJS79v15vDPvWp0gEXOFVB8QcuCBujL3iQm4WVXc=; b=jA6rkLNq5onNhK18PKg4Jguw3KjL+xa4I351/p9hYDsaONywvLh2DiMpzoFfqfspym OdHGO7ValOFLZLWo2NdolFakqBxgmXArNPRqupE4g6hXetyFbh8Wzx7Bv35Un/P85jDi Mdpaa+ZLRS0f1ChnINBKNhyP5Zz9Djv9S5ucAocSSdnHLASAxURT8x0CDnzRRd6Tn2JP nh9DEE3HMgj2D8pBYQetxXaQewemPAeGfIYEGdGWe8yNdWYGROhe2NlnFVVsM83bY7Kf m8ybWyQ6BpgbbqwF5vypNql3QBVtm6Jw1+gZasaTQ6pHTSVjg0i8t/O43+CmhZpfu2P0 LuBw== X-Gm-Message-State: AOAM532dP8BsRnishddRUrFIICPTR4zitj2XbhoyxCUtU5ivcuarChxc dSLI/oa3b9uFpPsACSka9QNn9ub3IvE= X-Google-Smtp-Source: ABdhPJy7JEkr/3dMu4L49Lw+gPGY8gHw7yAaZhdIf87oRC7v/4j/f/YWrayp4BQC2KvwiDQbjRMXEg== X-Received: by 2002:adf:dbd0:: with SMTP id e16mr4727843wrj.402.1630599358916; Thu, 02 Sep 2021 09:15:58 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Bin Meng , Eduardo Habkost , Greg Kurz , haxm-team@intel.com, Kamil Rytarowski , qemu-ppc@nongnu.org, Anthony Perard , Marcel Apfelbaum , Michael Rolnik , qemu-riscv@nongnu.org, Paolo Bonzini , Jiaxun Yang , Thomas Huth , David Hildenbrand , Chris Wulff , Laurent Vivier , Cameron Esfahani , Sunil Muthuswamy , Max Filippov , Taylor Simpson , qemu-s390x@nongnu.org, Richard Henderson , Bastian Koppelmann , Yoshinori Sato , Artyom Tarasenko , Aurelien Jarno , Paul Durrant , Peter Maydell , David Gibson , Alistair Francis , "Edgar E. Iglesias" , Roman Bolshakov , Laurent Vivier , Cornelia Huck , qemu-arm@nongnu.org, Wenchao Wang , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , xen-devel@lists.xenproject.org, Marek Vasut , Stefano Stabellini , Aleksandar Rikalo , Mark Cave-Ayland , Colin Xu , Claudio Fontana , Palmer Dabbelt , Stafford Horne , Reinoud Zandijk , kvm@vger.kernel.org Subject: [PATCH v3 02/30] hw/core: Restrict cpu_has_work() to sysemu Date: Thu, 2 Sep 2021 18:15:15 +0200 Message-Id: <20210902161543.417092-3-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210902161543.417092-1-f4bug@amsat.org> References: <20210902161543.417092-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit cpu_has_work() is only called from system emulation code. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/core/cpu.h | 32 ++++++++++++++++---------------- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/include/hw/core/cpu.h b/include/hw/core/cpu.h index bc864564cee..2bd563e221f 100644 --- a/include/hw/core/cpu.h +++ b/include/hw/core/cpu.h @@ -538,6 +538,22 @@ enum CPUDumpFlags { void cpu_dump_state(CPUState *cpu, FILE *f, int flags); #ifndef CONFIG_USER_ONLY +/** + * cpu_has_work: + * @cpu: The vCPU to check. + * + * Checks whether the CPU has work to do. + * + * Returns: %true if the CPU has work, %false otherwise. + */ +static inline bool cpu_has_work(CPUState *cpu) +{ + CPUClass *cc = CPU_GET_CLASS(cpu); + + g_assert(cc->has_work); + return cc->has_work(cpu); +} + /** * cpu_get_phys_page_attrs_debug: * @cpu: The CPU to obtain the physical page address for. @@ -636,22 +652,6 @@ CPUState *cpu_create(const char *typename); */ const char *parse_cpu_option(const char *cpu_option); -/** - * cpu_has_work: - * @cpu: The vCPU to check. - * - * Checks whether the CPU has work to do. - * - * Returns: %true if the CPU has work, %false otherwise. - */ -static inline bool cpu_has_work(CPUState *cpu) -{ - CPUClass *cc = CPU_GET_CLASS(cpu); - - g_assert(cc->has_work); - return cc->has_work(cpu); -} - /** * qemu_cpu_is_self: * @cpu: The vCPU to check against. -- 2.31.1 From xen-devel-bounces@lists.xenproject.org Thu Sep 02 16:16:07 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 16:16:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177413.322832 (Exim 4.92) (envelope-from ) id 1mLpNn-0002Cm-Hz; Thu, 02 Sep 2021 16:16:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177413.322832; Thu, 02 Sep 2021 16:16:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLpNn-0002Ce-Cv; Thu, 02 Sep 2021 16:16:07 +0000 Received: by outflank-mailman (input) for mailman id 177413; Thu, 02 Sep 2021 16:16:06 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLpNm-00029c-8F for xen-devel@lists.xenproject.org; Thu, 02 Sep 2021 16:16:06 +0000 Received: from mail-wm1-x330.google.com (unknown [2a00:1450:4864:20::330]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id a77c98f1-6fdb-4048-93e9-834adadafd23; Thu, 02 Sep 2021 16:16:05 +0000 (UTC) Received: by mail-wm1-x330.google.com with SMTP id u26-20020a05600c441a00b002f66b2d8603so1866829wmn.4 for ; Thu, 02 Sep 2021 09:16:05 -0700 (PDT) Received: from x1w.. (163.red-83-52-55.dynamicip.rima-tde.net. [83.52.55.163]) by smtp.gmail.com with ESMTPSA id p5sm2438468wrd.25.2021.09.02.09.16.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Sep 2021 09:16:04 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list X-Inumbo-ID: a77c98f1-6fdb-4048-93e9-834adadafd23 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=wV14RcZMLIQqRNfbc2l4krY7RhS99j63lxSZtHhlqHE=; b=EKqirEKnM17VK0zDlsK2zMeCBYwgcIwGau/nM2ojAXQ1rvdOXkyoVbGuyEtcnzeBcf xImFuE98afvxno05q0YdC27nz6NANS7cu771VPDYoClXWYNKBPbXOfx9/ySz5LCrUECJ Q4xIJxN/kF3No93cpZwlCIAaJ6XH09BodtAvBDBdkeBdwCBDaphPwkcvpVDIxHiZ6ysU O+OUGJNK0KyuMps/0T4ys/RLGMV8UZ8emOYDNmBvg+JTSjUog7qhAQcBWa/t3lzLUf2T odXtoH2/j2F/4nd8pGQvQwtB64/pnwk36AxB7fddw33eEJVy5u1yikEgzNZHCoqMgJ3i wCuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=wV14RcZMLIQqRNfbc2l4krY7RhS99j63lxSZtHhlqHE=; b=B1/JoJulq2t4OsAb+f+Iwcof8/8nogzJjSsSeYK+ndN9RIbLLv7MqOObXsP3zigJPC QT6sZ7X9Gsx60qQjoIvTtzUllSTGwUxnqlXdrAPEJR9qiMNt7ksMXj72JbHAvkG5mIrG nfQffqdGhX9vmV+2DCvXd+wwYeUWI+geadKt5ZYlmwm7neBWVeXD40smnHAFotR6Iu8A vLWrUsmI/dXI9HAkILlkqCDzZlfemotf4KeC7PfD2izAyKXKnCjsn9dHhtw/epHv/H4J TWk/dOeYDrnaGH9JuKv7IwQ6eyb+YrO193FQE1uX/MyyCKhGGQeKW7HEzEbpdBt+wYMA kDzw== X-Gm-Message-State: AOAM533sKL4jzmZ4JRxrrrQHFzUNx67241OAsPzhJ77CsJ9OPCSuNxaA TYZkGH9xZmE6gd74e2Htb+k= X-Google-Smtp-Source: ABdhPJw7/6UEiBwptJyfAbxmtA0JM7jALL+mTrdaJbBQ6pe56ORuZs2k15EQns1EFPDQ4opAGTbfXw== X-Received: by 2002:a05:600c:2101:: with SMTP id u1mr4147345wml.45.1630599364755; Thu, 02 Sep 2021 09:16:04 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Bin Meng , Eduardo Habkost , Greg Kurz , haxm-team@intel.com, Kamil Rytarowski , qemu-ppc@nongnu.org, Anthony Perard , Marcel Apfelbaum , Michael Rolnik , qemu-riscv@nongnu.org, Paolo Bonzini , Jiaxun Yang , Thomas Huth , David Hildenbrand , Chris Wulff , Laurent Vivier , Cameron Esfahani , Sunil Muthuswamy , Max Filippov , Taylor Simpson , qemu-s390x@nongnu.org, Richard Henderson , Bastian Koppelmann , Yoshinori Sato , Artyom Tarasenko , Aurelien Jarno , Paul Durrant , Peter Maydell , David Gibson , Alistair Francis , "Edgar E. Iglesias" , Roman Bolshakov , Laurent Vivier , Cornelia Huck , qemu-arm@nongnu.org, Wenchao Wang , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , xen-devel@lists.xenproject.org, Marek Vasut , Stefano Stabellini , Aleksandar Rikalo , Mark Cave-Ayland , Colin Xu , Claudio Fontana , Palmer Dabbelt , Stafford Horne , Reinoud Zandijk , kvm@vger.kernel.org Subject: [PATCH v3 03/30] hw/core: Un-inline cpu_has_work() Date: Thu, 2 Sep 2021 18:15:16 +0200 Message-Id: <20210902161543.417092-4-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210902161543.417092-1-f4bug@amsat.org> References: <20210902161543.417092-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit We want to make cpu_has_work() per-accelerator. Only declare its prototype and move its definition to softmmu/cpus.c. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/core/cpu.h | 8 +------- softmmu/cpus.c | 8 ++++++++ 2 files changed, 9 insertions(+), 7 deletions(-) diff --git a/include/hw/core/cpu.h b/include/hw/core/cpu.h index 2bd563e221f..e2dd171a13f 100644 --- a/include/hw/core/cpu.h +++ b/include/hw/core/cpu.h @@ -546,13 +546,7 @@ void cpu_dump_state(CPUState *cpu, FILE *f, int flags); * * Returns: %true if the CPU has work, %false otherwise. */ -static inline bool cpu_has_work(CPUState *cpu) -{ - CPUClass *cc = CPU_GET_CLASS(cpu); - - g_assert(cc->has_work); - return cc->has_work(cpu); -} +bool cpu_has_work(CPUState *cpu); /** * cpu_get_phys_page_attrs_debug: diff --git a/softmmu/cpus.c b/softmmu/cpus.c index 071085f840b..7e2cb2c571b 100644 --- a/softmmu/cpus.c +++ b/softmmu/cpus.c @@ -251,6 +251,14 @@ void cpu_interrupt(CPUState *cpu, int mask) } } +bool cpu_has_work(CPUState *cpu) +{ + CPUClass *cc = CPU_GET_CLASS(cpu); + + g_assert(cc->has_work); + return cc->has_work(cpu); +} + static int do_vm_stop(RunState state, bool send_stop) { int ret = 0; -- 2.31.1 From xen-devel-bounces@lists.xenproject.org Thu Sep 02 16:16:15 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 16:16:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177417.322843 (Exim 4.92) (envelope-from ) id 1mLpNu-0002n1-Qp; Thu, 02 Sep 2021 16:16:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177417.322843; Thu, 02 Sep 2021 16:16:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLpNu-0002mu-LZ; Thu, 02 Sep 2021 16:16:14 +0000 Received: by outflank-mailman (input) for mailman id 177417; Thu, 02 Sep 2021 16:16:13 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLpNt-00029c-Nz for xen-devel@lists.xenproject.org; Thu, 02 Sep 2021 16:16:13 +0000 Received: from mail-wr1-x429.google.com (unknown [2a00:1450:4864:20::429]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id f5586672-609a-4718-a2be-f5eaf5608fba; Thu, 02 Sep 2021 16:16:11 +0000 (UTC) Received: by mail-wr1-x429.google.com with SMTP id n5so3803786wro.12 for ; Thu, 02 Sep 2021 09:16:11 -0700 (PDT) Received: from x1w.. (163.red-83-52-55.dynamicip.rima-tde.net. [83.52.55.163]) by smtp.gmail.com with ESMTPSA id l1sm2293844wrb.15.2021.09.02.09.16.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Sep 2021 09:16:10 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list X-Inumbo-ID: f5586672-609a-4718-a2be-f5eaf5608fba DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=P0fp1qqpF59XMbIIHxComfWKKQIg8VIlTwHVvhBN59A=; b=G8+gv7/l02p+3pIOfkKqyIa3SJNJqqucn0S8o/siAkKaxmFM5RO224iTEbB1+wTzyT yH9VCpxFWBr0t0GXhQxQRUuO0CaUa3ZzEf3celJhLqjAbDckl1E6mqaq2dCEttikPZRW NTgh0ED5VO3rDtoACT4pDd4RK9nfKb9VvyIT09l58j9YQUutJPWiW1YUvmfRQD6MaciO hgQld4iTpFhaM+A7V2MEdU+/ZRnuTgXC5fBFAjpnxBcFkFzPQ9ZRGDj/1+tmyCyow8jw rBfrG9A0yoltXZKggfPRhQMqdG2T5CPTN8x3VdAjvEoK7uauTkkWkCFDPZbLzkrywDXE DO1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=P0fp1qqpF59XMbIIHxComfWKKQIg8VIlTwHVvhBN59A=; b=YfdnRZzuD/d1mvZa5Pw6Ez9HDlUz25GZZwQ6iY9ELsuSSEjPrTq3K3aLH4ylk4YNFf XAsnyJiw6fVLmTxBHI1u262nKJP5mSZ8fE9tvQUZ4ww3aGgcndnghHZ0J0jQpelINN8P cU2PROrYMrxr/tMYDV/NLL7d5Qj+7WrBUkq8xPYqKxGEJCQGRMWQcd14sARcAGB/3TkS keSuD/Ui6puLg2O8T2Yk8v2H4g08jA26HisroQl+kB5tRecU3//yKNYNLbUZeQQLBAwS 9QJNM+zGvoR1W6VJgG3ofMc8gJAmMjv3r/JlxgPN1v4+GPT/84+dt4jk24SrobK4pDgU yjXQ== X-Gm-Message-State: AOAM532osXSa/szmX+gyIMbs0u/RvSaOQlrc+mvqq3+jcnWv9bV95F1Z d5QxbobzSFO4viKllEcdgC4= X-Google-Smtp-Source: ABdhPJxqYVZz8Vtdq+1rVuHAugWlbrJscT37rU3tWfkU/lcfKzRuzJ6gBh5u/Yi5SNrMElUTWFem6A== X-Received: by 2002:adf:d191:: with SMTP id v17mr4847443wrc.345.1630599370860; Thu, 02 Sep 2021 09:16:10 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Bin Meng , Eduardo Habkost , Greg Kurz , haxm-team@intel.com, Kamil Rytarowski , qemu-ppc@nongnu.org, Anthony Perard , Marcel Apfelbaum , Michael Rolnik , qemu-riscv@nongnu.org, Paolo Bonzini , Jiaxun Yang , Thomas Huth , David Hildenbrand , Chris Wulff , Laurent Vivier , Cameron Esfahani , Sunil Muthuswamy , Max Filippov , Taylor Simpson , qemu-s390x@nongnu.org, Richard Henderson , Bastian Koppelmann , Yoshinori Sato , Artyom Tarasenko , Aurelien Jarno , Paul Durrant , Peter Maydell , David Gibson , Alistair Francis , "Edgar E. Iglesias" , Roman Bolshakov , Laurent Vivier , Cornelia Huck , qemu-arm@nongnu.org, Wenchao Wang , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , xen-devel@lists.xenproject.org, Marek Vasut , Stefano Stabellini , Aleksandar Rikalo , Mark Cave-Ayland , Colin Xu , Claudio Fontana , Palmer Dabbelt , Stafford Horne , Reinoud Zandijk , kvm@vger.kernel.org Subject: [PATCH v3 04/30] sysemu: Introduce AccelOpsClass::has_work() Date: Thu, 2 Sep 2021 18:15:17 +0200 Message-Id: <20210902161543.417092-5-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210902161543.417092-1-f4bug@amsat.org> References: <20210902161543.417092-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Introduce an accelerator-specific has_work() handler. Eventually call it from cpu_has_work(). Signed-off-by: Philippe Mathieu-Daudé --- include/sysemu/accel-ops.h | 5 +++++ softmmu/cpus.c | 3 +++ 2 files changed, 8 insertions(+) diff --git a/include/sysemu/accel-ops.h b/include/sysemu/accel-ops.h index 032f6979d76..de83f095f20 100644 --- a/include/sysemu/accel-ops.h +++ b/include/sysemu/accel-ops.h @@ -31,6 +31,11 @@ struct AccelOpsClass { void (*create_vcpu_thread)(CPUState *cpu); /* MANDATORY NON-NULL */ void (*kick_vcpu_thread)(CPUState *cpu); + /** + * @has_work: Callback for checking if there is work to do. + */ + bool (*has_work)(CPUState *cpu); + void (*synchronize_post_reset)(CPUState *cpu); void (*synchronize_post_init)(CPUState *cpu); void (*synchronize_state)(CPUState *cpu); diff --git a/softmmu/cpus.c b/softmmu/cpus.c index 7e2cb2c571b..2a61dfd6287 100644 --- a/softmmu/cpus.c +++ b/softmmu/cpus.c @@ -255,6 +255,9 @@ bool cpu_has_work(CPUState *cpu) { CPUClass *cc = CPU_GET_CLASS(cpu); + if (cpus_accel->has_work) { + return cpus_accel->has_work(cpu); + } g_assert(cc->has_work); return cc->has_work(cpu); } -- 2.31.1 From xen-devel-bounces@lists.xenproject.org Thu Sep 02 16:16:20 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 16:16:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177421.322854 (Exim 4.92) (envelope-from ) id 1mLpO0-0003Hx-5H; Thu, 02 Sep 2021 16:16:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177421.322854; Thu, 02 Sep 2021 16:16:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLpO0-0003Hg-1f; Thu, 02 Sep 2021 16:16:20 +0000 Received: by outflank-mailman (input) for mailman id 177421; Thu, 02 Sep 2021 16:16:18 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLpNy-00029c-O4 for xen-devel@lists.xenproject.org; Thu, 02 Sep 2021 16:16:18 +0000 Received: from mail-wm1-x333.google.com (unknown [2a00:1450:4864:20::333]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 16e7e53f-64ec-4976-bcd4-b2f74f7f94a1; Thu, 02 Sep 2021 16:16:17 +0000 (UTC) Received: by mail-wm1-x333.google.com with SMTP id m25-20020a7bcb99000000b002e751bcb5dbso1731680wmi.5 for ; Thu, 02 Sep 2021 09:16:17 -0700 (PDT) Received: from x1w.. (163.red-83-52-55.dynamicip.rima-tde.net. [83.52.55.163]) by smtp.gmail.com with ESMTPSA id n3sm2097857wmi.0.2021.09.02.09.16.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Sep 2021 09:16:16 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list X-Inumbo-ID: 16e7e53f-64ec-4976-bcd4-b2f74f7f94a1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=RYRVLsfl9Ob+8zW8ulpQWg/n0bsy9p4rFkeC3sRFgzg=; b=cWSYDAq5Jp0McvzKfoJCBhOUKIrlk33QHDkz+m47acNIlb9JOx3tfp5kB+KXf5dDO/ w4+OyKHGR2RiqPyFa7V7bzZyYSy6kLYW49zVrZ6Hy8QBCbCerYOKfrGjd0qNffHf9SpP r/Kq+8mSo19dNZRUfW1WN64ERD6JetVYvf41b1e1tWlJwcOL4P63Z/Mm9sSwkJyaYePZ Jroc0woaa+Fir71b0dp9xMglTvA3smVf5tzo/uq315Y7Ji+qHpf638YaJjs7F9y6JQ5A whXUesQqAhIyuS/27l3cznkFQWzDOa9H8TavWnRll7U6TXlgZEUv2l8XPpV83TA8h9zC OFCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=RYRVLsfl9Ob+8zW8ulpQWg/n0bsy9p4rFkeC3sRFgzg=; b=TIia/RMEQWe6dKwXHmsAI5rbL7+aZx0I+XFNFiWVqv2YHr5C3Ed7xp4daJftkUiXhT xHW+Hkieg+8c2HiMb/mUMtHo09g5wcUlcX9D5qDjS1koHJVAuOhaoKY6RP7Ga/M+9Sbp WUKrL6VhaMlOjpn83iVoPN5E/259NkvFD0fKsQ16Mrs3WGQrdn97B7O0plVKiTWlCmFG KAP3H65Td0huiQgfLw+Y1ImzZhVAl/i7JrTBHbN5wxQTIin+dHcdQxjG4L5rYsOgwsGs Azwxm7Ipb+AO0E9LorFYW/YiaYRuGr44ggo4zPtTPredM+1gGe418ZG6DvmSg8XsmnAr 8ajw== X-Gm-Message-State: AOAM53320BABRTZYX1ET6LNvaWWLO53oMn/deAadm2BUTOfeav3YFi1P nbzt1D9kXVBVP+vKPwzXMNU= X-Google-Smtp-Source: ABdhPJwPjYjbwvv/6b7qFrtZZvNxWFscX+KmwH8SpAbQsTLfx+OHgnzX3KJXi3XGsfieLbi9LeXPtA== X-Received: by 2002:a7b:c0c6:: with SMTP id s6mr3953111wmh.161.1630599376931; Thu, 02 Sep 2021 09:16:16 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Bin Meng , Eduardo Habkost , Greg Kurz , haxm-team@intel.com, Kamil Rytarowski , qemu-ppc@nongnu.org, Anthony Perard , Marcel Apfelbaum , Michael Rolnik , qemu-riscv@nongnu.org, Paolo Bonzini , Jiaxun Yang , Thomas Huth , David Hildenbrand , Chris Wulff , Laurent Vivier , Cameron Esfahani , Sunil Muthuswamy , Max Filippov , Taylor Simpson , qemu-s390x@nongnu.org, Richard Henderson , Bastian Koppelmann , Yoshinori Sato , Artyom Tarasenko , Aurelien Jarno , Paul Durrant , Peter Maydell , David Gibson , Alistair Francis , "Edgar E. Iglesias" , Roman Bolshakov , Laurent Vivier , Cornelia Huck , qemu-arm@nongnu.org, Wenchao Wang , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , xen-devel@lists.xenproject.org, Marek Vasut , Stefano Stabellini , Aleksandar Rikalo , Mark Cave-Ayland , Colin Xu , Claudio Fontana , Palmer Dabbelt , Stafford Horne , Reinoud Zandijk , kvm@vger.kernel.org Subject: [PATCH v3 05/30] accel/kvm: Implement AccelOpsClass::has_work() Date: Thu, 2 Sep 2021 18:15:18 +0200 Message-Id: <20210902161543.417092-6-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210902161543.417092-1-f4bug@amsat.org> References: <20210902161543.417092-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Implement KVM has_work() handler in AccelOpsClass and remove it from cpu_thread_is_idle() since cpu_has_work() is already called. Signed-off-by: Philippe Mathieu-Daudé --- accel/kvm/kvm-accel-ops.c | 6 ++++++ softmmu/cpus.c | 2 +- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/accel/kvm/kvm-accel-ops.c b/accel/kvm/kvm-accel-ops.c index 7516c67a3f5..6f4d5df3a0d 100644 --- a/accel/kvm/kvm-accel-ops.c +++ b/accel/kvm/kvm-accel-ops.c @@ -74,6 +74,11 @@ static void kvm_start_vcpu_thread(CPUState *cpu) cpu, QEMU_THREAD_JOINABLE); } +static bool kvm_cpu_has_work(CPUState *cpu) +{ + return kvm_halt_in_kernel(); +} + static void kvm_accel_ops_class_init(ObjectClass *oc, void *data) { AccelOpsClass *ops = ACCEL_OPS_CLASS(oc); @@ -83,6 +88,7 @@ static void kvm_accel_ops_class_init(ObjectClass *oc, void *data) ops->synchronize_post_init = kvm_cpu_synchronize_post_init; ops->synchronize_state = kvm_cpu_synchronize_state; ops->synchronize_pre_loadvm = kvm_cpu_synchronize_pre_loadvm; + ops->has_work = kvm_cpu_has_work; } static const TypeInfo kvm_accel_ops_type = { diff --git a/softmmu/cpus.c b/softmmu/cpus.c index 2a61dfd6287..3db7bd4eb4d 100644 --- a/softmmu/cpus.c +++ b/softmmu/cpus.c @@ -90,7 +90,7 @@ bool cpu_thread_is_idle(CPUState *cpu) return true; } if (!cpu->halted || cpu_has_work(cpu) || - kvm_halt_in_kernel() || whpx_apic_in_platform()) { + whpx_apic_in_platform()) { return false; } return true; -- 2.31.1 From xen-devel-bounces@lists.xenproject.org Thu Sep 02 16:16:29 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 16:16:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177430.322865 (Exim 4.92) (envelope-from ) id 1mLpO9-00041h-Gt; Thu, 02 Sep 2021 16:16:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177430.322865; Thu, 02 Sep 2021 16:16:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLpO9-00041V-DA; Thu, 02 Sep 2021 16:16:29 +0000 Received: by outflank-mailman (input) for mailman id 177430; Thu, 02 Sep 2021 16:16:28 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLpO8-00029c-OZ for xen-devel@lists.xenproject.org; Thu, 02 Sep 2021 16:16:28 +0000 Received: from mail-wr1-x431.google.com (unknown [2a00:1450:4864:20::431]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id d531d647-1b43-46ab-911b-29dfb596f7ed; Thu, 02 Sep 2021 16:16:23 +0000 (UTC) Received: by mail-wr1-x431.google.com with SMTP id q14so3833090wrp.3 for ; Thu, 02 Sep 2021 09:16:23 -0700 (PDT) Received: from x1w.. (163.red-83-52-55.dynamicip.rima-tde.net. [83.52.55.163]) by smtp.gmail.com with ESMTPSA id k37sm1787439wms.18.2021.09.02.09.16.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Sep 2021 09:16:22 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list X-Inumbo-ID: d531d647-1b43-46ab-911b-29dfb596f7ed DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=TscxpaThIFwXh/P1Ycdn5GNQgbZxc3kDvlQfbrdl29A=; b=qoOL8i+0Y9KqXMdm9wOQ3u/uPCdX/SQlDbKgluqhkScnDC2t1qHTT+2MTI//DWFAUT NEejCit7VB+NanpfXq6Qc1DSyRxFphKWmmaSUCPbUNDcmTFSjm/7IHDyWLstRl23/liL PZvnmlnErsZ1z8G7bMly2o0U/t5YGH3JGm4ZynAQjU//ks9rQoD8imqPSgj5ddgnhNdE jy4fS/nmBse8JHRRQZwgmcXXvfWbpfY46jYzcfi3LWel1xENjZOe87hdj9MZ//4GUVRq cQn36iCUZBXsphDCe0vsC3FLk68GDc7pyonHjq+49CjqDRjeD5GGI1ltJX+qXIdflDGH EuIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=TscxpaThIFwXh/P1Ycdn5GNQgbZxc3kDvlQfbrdl29A=; b=tEbKgKab5rC8PlryeZZ8NVtEze8MqmVaH0z+m003ejx8V66VSyqRNZGD/SWmx7W4ls okxHtY0MNJlrPWTVUb6pKD5ojuzQCU9K8zsk6fv6JPJx0KOQD+efccbo3+Fe3UKNZdpb Xqzc+2O1mWmwQBQpv+V/il1JUUowVM83GGr+bjEJg7TVW7gO13JreeNBlQAdfq/IMISM stwo48fJgaMd91R8NewgH+SAOXuBID4HlSzEw+uMoYXR05fmvrAKxN17EmS8GvTvyhex WszFqLqWs71w9tWoitTRrtVT63FhlXghdimkhhMXKebAYm6mCqlpVRaxQxlC66qXn6g0 17nQ== X-Gm-Message-State: AOAM530gfrH6gWl+jDDehOFXRwPTJoQRX+8692+MxadW1Bm7cQUgt7ui oGK8PyEs36sxl7vRAb/XKFo= X-Google-Smtp-Source: ABdhPJwGGBwl9Y1sjN8okEHWYycyYyvr2xi+NUWJxoO5KxfkCZlVjxWvfmucwDATrcvJW3+aRgOqDw== X-Received: by 2002:adf:b741:: with SMTP id n1mr4708081wre.354.1630599382926; Thu, 02 Sep 2021 09:16:22 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Bin Meng , Eduardo Habkost , Greg Kurz , haxm-team@intel.com, Kamil Rytarowski , qemu-ppc@nongnu.org, Anthony Perard , Marcel Apfelbaum , Michael Rolnik , qemu-riscv@nongnu.org, Paolo Bonzini , Jiaxun Yang , Thomas Huth , David Hildenbrand , Chris Wulff , Laurent Vivier , Cameron Esfahani , Sunil Muthuswamy , Max Filippov , Taylor Simpson , qemu-s390x@nongnu.org, Richard Henderson , Bastian Koppelmann , Yoshinori Sato , Artyom Tarasenko , Aurelien Jarno , Paul Durrant , Peter Maydell , David Gibson , Alistair Francis , "Edgar E. Iglesias" , Roman Bolshakov , Laurent Vivier , Cornelia Huck , qemu-arm@nongnu.org, Wenchao Wang , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , xen-devel@lists.xenproject.org, Marek Vasut , Stefano Stabellini , Aleksandar Rikalo , Mark Cave-Ayland , Colin Xu , Claudio Fontana , Palmer Dabbelt , Stafford Horne , Reinoud Zandijk , kvm@vger.kernel.org Subject: [PATCH v3 06/30] accel/whpx: Implement AccelOpsClass::has_work() Date: Thu, 2 Sep 2021 18:15:19 +0200 Message-Id: <20210902161543.417092-7-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210902161543.417092-1-f4bug@amsat.org> References: <20210902161543.417092-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Implement WHPX has_work() handler in AccelOpsClass and remove it from cpu_thread_is_idle() since cpu_has_work() is already called. Signed-off-by: Philippe Mathieu-Daudé --- softmmu/cpus.c | 4 +--- target/i386/whpx/whpx-accel-ops.c | 6 ++++++ 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/softmmu/cpus.c b/softmmu/cpus.c index 3db7bd4eb4d..6bce52ce561 100644 --- a/softmmu/cpus.c +++ b/softmmu/cpus.c @@ -41,7 +41,6 @@ #include "sysemu/replay.h" #include "sysemu/runstate.h" #include "sysemu/cpu-timers.h" -#include "sysemu/whpx.h" #include "hw/boards.h" #include "hw/hw.h" #include "trace.h" @@ -89,8 +88,7 @@ bool cpu_thread_is_idle(CPUState *cpu) if (cpu_is_stopped(cpu)) { return true; } - if (!cpu->halted || cpu_has_work(cpu) || - whpx_apic_in_platform()) { + if (!cpu->halted || cpu_has_work(cpu)) { return false; } return true; diff --git a/target/i386/whpx/whpx-accel-ops.c b/target/i386/whpx/whpx-accel-ops.c index 6bc47c53098..1f9c6d52c27 100644 --- a/target/i386/whpx/whpx-accel-ops.c +++ b/target/i386/whpx/whpx-accel-ops.c @@ -83,6 +83,11 @@ static void whpx_kick_vcpu_thread(CPUState *cpu) } } +static bool whpx_cpu_has_work(CPUState *cpu) +{ + return whpx_apic_in_platform(); +} + static void whpx_accel_ops_class_init(ObjectClass *oc, void *data) { AccelOpsClass *ops = ACCEL_OPS_CLASS(oc); @@ -94,6 +99,7 @@ static void whpx_accel_ops_class_init(ObjectClass *oc, void *data) ops->synchronize_post_init = whpx_cpu_synchronize_post_init; ops->synchronize_state = whpx_cpu_synchronize_state; ops->synchronize_pre_loadvm = whpx_cpu_synchronize_pre_loadvm; + ops->has_work = whpx_cpu_has_work; } static const TypeInfo whpx_accel_ops_type = { -- 2.31.1 From xen-devel-bounces@lists.xenproject.org Thu Sep 02 16:16:35 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 16:16:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177435.322875 (Exim 4.92) (envelope-from ) id 1mLpOE-0004eH-Sr; Thu, 02 Sep 2021 16:16:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177435.322875; Thu, 02 Sep 2021 16:16:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLpOE-0004dr-Ph; Thu, 02 Sep 2021 16:16:34 +0000 Received: by outflank-mailman (input) for mailman id 177435; Thu, 02 Sep 2021 16:16:33 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLpOD-00029c-Op for xen-devel@lists.xenproject.org; Thu, 02 Sep 2021 16:16:33 +0000 Received: from mail-wr1-x42a.google.com (unknown [2a00:1450:4864:20::42a]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 5ab99782-1fbd-4846-a155-7ff202366422; Thu, 02 Sep 2021 16:16:29 +0000 (UTC) Received: by mail-wr1-x42a.google.com with SMTP id t15so3835538wrg.7 for ; Thu, 02 Sep 2021 09:16:29 -0700 (PDT) Received: from x1w.. (163.red-83-52-55.dynamicip.rima-tde.net. [83.52.55.163]) by smtp.gmail.com with ESMTPSA id g138sm2059442wmg.34.2021.09.02.09.16.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Sep 2021 09:16:28 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list X-Inumbo-ID: 5ab99782-1fbd-4846-a155-7ff202366422 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=gBDJiXTHT9IuEk9FfrTxtULybQQn9dfnXif9nUI7YC4=; b=LsbNjaXg9ZfDPBy35BgL3iTqoeboaHkvnknRwyAU2+xh3Y/GU5flK162rFrVD6PusK Zqye8j5GUtb9gwLuuAwBTaOPWqvSsNMI+LA1B5XlyhQj2OVug2mbnYS/clkuPBIuFEym pP4NuPbllHtklBm3Yk0D0W9rgb1jh68G001/gVtLBxzuFMcKbp53adEKS/t8pLvhfvjr /zEon0LvHHXUsmhiO9rLMnilC4Arm5Crf6gVF6CvpbMBshlkL+4jtharx5Q/STsgQBAC MvKjTe/KtyoK/YH9U42tNMwUXpXFN7GCzVSMFrxoghGcQKddKIXW2rcVsMa4qI3qYUFC llIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=gBDJiXTHT9IuEk9FfrTxtULybQQn9dfnXif9nUI7YC4=; b=kEv3BmFnyeHc6i4NdKXd76NahA4ttP4lhASayAo6lutF9BCJJ2V23iaZEmew8wfarp s2DrZZK6lVinQI6C35XXWmpK8V5SsSBdFz09xsRefLkeXGPOpTd+a1c4ep8VjrnN4K8v qiNWddsx1e2jcsXdgSbXLPIhKCzH0ItGOOPyRNNs0XqgzeEdAaI+gsaMFm5MnUC1OvHY Qyup9znmWkNl/Wm5B05iP1UF+JX6QruPuO/Us1w8yGkZGdtnt++FuGFLdeYfBqo4KZJT 09GHANxeUiXjPnkNbPQU0txQXO/pcEUlPB11dgaGLPfKlKKjk/HgR0sMFIQ9CER1/k1L W00g== X-Gm-Message-State: AOAM532lCxNXmb4vukUiuODmdi3Ztj03b8FOeqTYm7vn+4N0i8GvHLrM AJWr3zKYiNFpsphcvBf6NbI= X-Google-Smtp-Source: ABdhPJxj90aNQOBb3bG354GuN1ofupsCwK8r7Qe99fRLxGQ8aaew/tNKGnIR32ntB4hlx8/hSq93OA== X-Received: by 2002:a05:6000:36e:: with SMTP id f14mr4867472wrf.196.1630599389049; Thu, 02 Sep 2021 09:16:29 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Bin Meng , Eduardo Habkost , Greg Kurz , haxm-team@intel.com, Kamil Rytarowski , qemu-ppc@nongnu.org, Anthony Perard , Marcel Apfelbaum , Michael Rolnik , qemu-riscv@nongnu.org, Paolo Bonzini , Jiaxun Yang , Thomas Huth , David Hildenbrand , Chris Wulff , Laurent Vivier , Cameron Esfahani , Sunil Muthuswamy , Max Filippov , Taylor Simpson , qemu-s390x@nongnu.org, Richard Henderson , Bastian Koppelmann , Yoshinori Sato , Artyom Tarasenko , Aurelien Jarno , Paul Durrant , Peter Maydell , David Gibson , Alistair Francis , "Edgar E. Iglesias" , Roman Bolshakov , Laurent Vivier , Cornelia Huck , qemu-arm@nongnu.org, Wenchao Wang , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , xen-devel@lists.xenproject.org, Marek Vasut , Stefano Stabellini , Aleksandar Rikalo , Mark Cave-Ayland , Colin Xu , Claudio Fontana , Palmer Dabbelt , Stafford Horne , Reinoud Zandijk , kvm@vger.kernel.org Subject: [PATCH v3 07/30] accel/tcg: Implement AccelOpsClass::has_work() as stub Date: Thu, 2 Sep 2021 18:15:20 +0200 Message-Id: <20210902161543.417092-8-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210902161543.417092-1-f4bug@amsat.org> References: <20210902161543.417092-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Add TCG target-specific has_work() handler in TCGCPUOps, and add tcg_cpu_has_work() as AccelOpsClass has_work() implementation. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/core/tcg-cpu-ops.h | 4 ++++ accel/tcg/tcg-accel-ops.c | 12 ++++++++++++ 2 files changed, 16 insertions(+) diff --git a/include/hw/core/tcg-cpu-ops.h b/include/hw/core/tcg-cpu-ops.h index bbec7760f48..919d9006e24 100644 --- a/include/hw/core/tcg-cpu-ops.h +++ b/include/hw/core/tcg-cpu-ops.h @@ -66,6 +66,10 @@ struct TCGCPUOps { void (*do_interrupt)(CPUState *cpu); #endif /* !CONFIG_USER_ONLY || !TARGET_I386 */ #ifdef CONFIG_SOFTMMU + /** + * @has_work: Callback for checking if there is work to do. + */ + bool (*has_work)(CPUState *cpu); /** @cpu_exec_interrupt: Callback for processing interrupts in cpu_exec */ bool (*cpu_exec_interrupt)(CPUState *cpu, int interrupt_request); /** diff --git a/accel/tcg/tcg-accel-ops.c b/accel/tcg/tcg-accel-ops.c index 1a8e8390bd6..ed4ebe735fe 100644 --- a/accel/tcg/tcg-accel-ops.c +++ b/accel/tcg/tcg-accel-ops.c @@ -32,6 +32,7 @@ #include "qemu/main-loop.h" #include "qemu/guest-random.h" #include "exec/exec-all.h" +#include "hw/core/tcg-cpu-ops.h" #include "tcg-accel-ops.h" #include "tcg-accel-ops-mttcg.h" @@ -73,6 +74,16 @@ int tcg_cpus_exec(CPUState *cpu) return ret; } +static bool tcg_cpu_has_work(CPUState *cpu) +{ + CPUClass *cc = CPU_GET_CLASS(cpu); + + if (!cc->tcg_ops->has_work) { + return false; + } + return cc->tcg_ops->has_work(cpu); +} + /* mask must never be zero, except for A20 change call */ void tcg_handle_interrupt(CPUState *cpu, int mask) { @@ -108,6 +119,7 @@ static void tcg_accel_ops_init(AccelOpsClass *ops) ops->kick_vcpu_thread = rr_kick_vcpu_thread; ops->handle_interrupt = tcg_handle_interrupt; } + ops->has_work = tcg_cpu_has_work; } static void tcg_accel_ops_class_init(ObjectClass *oc, void *data) -- 2.31.1 From xen-devel-bounces@lists.xenproject.org Thu Sep 02 16:16:45 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 16:16:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177443.322887 (Exim 4.92) (envelope-from ) id 1mLpOP-0005I1-7V; Thu, 02 Sep 2021 16:16:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177443.322887; Thu, 02 Sep 2021 16:16:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLpOP-0005Hp-3p; Thu, 02 Sep 2021 16:16:45 +0000 Received: by outflank-mailman (input) for mailman id 177443; Thu, 02 Sep 2021 16:16:43 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLpON-00029c-PD for xen-devel@lists.xenproject.org; Thu, 02 Sep 2021 16:16:43 +0000 Received: from mail-wr1-x42f.google.com (unknown [2a00:1450:4864:20::42f]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id fa103d0b-92f2-4ae1-af99-c49ba28658ee; Thu, 02 Sep 2021 16:16:35 +0000 (UTC) Received: by mail-wr1-x42f.google.com with SMTP id t15so3835941wrg.7 for ; Thu, 02 Sep 2021 09:16:35 -0700 (PDT) Received: from x1w.. (163.red-83-52-55.dynamicip.rima-tde.net. [83.52.55.163]) by smtp.gmail.com with ESMTPSA id d9sm2161496wrm.21.2021.09.02.09.16.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Sep 2021 09:16:34 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list X-Inumbo-ID: fa103d0b-92f2-4ae1-af99-c49ba28658ee DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=eXa1glKBQAZuhiqfHx9McrLJH+6vsqw3g1Zly0CLLW4=; b=ae0rJedtnyFXXpMPGaAYczb7D2gf5sAIBD78JSrM21inhCc6oobXicz8ZrAZbwKo+u LWgigyv/HdAEIiac6GDnYpFFEaYaskd9kEYeEtmG6nZ6xqWdpNpJ01xQm8qn97nDsycD JxK3rpivyOqG1ZF86VDCnWe7LDsUSWz4wzcJ/hvTp90Ehm2lEwn32lLuy6xZI/8yyuGo D3grkzcyRTx5k7pQjKg/3FGCaby6/Z3ejv2o7bs/xAAYUcfve3y2UqEM+TGGHH5UOrhG CAAu0Bd2wdhdwYLKumOwKFsEqKQ4OFbQ7TMnB4Cn4EM6ysG1/AHT1p0+QcU+g0Nj2W20 hOjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=eXa1glKBQAZuhiqfHx9McrLJH+6vsqw3g1Zly0CLLW4=; b=jSlQ1lsubY4x8SnJQDWwEF1V/B3FiYRvCN/mPIfLJ0Phs3uhXdgL+JgMnK9C2CvY1y eOTBH+MxWVhBcz9Cm5aRQSmG1wx2xoEjxK9INOwlfTY3fC4ye7KC3fZBql/7gWt+Iaj9 CR7UbXvorQ85//uOPiLlnx4m7yzXDxrpJDXmMY2v+K+suKC1QX591YKxUfhEaZHQj2oV xsYtT7g1MO+Wbv190oSxck92ZR0JFepUG71NeJb5rqsHiZHpoYYwKi6v7mU1qI/UsWFY RGA7qPGk1XaeYlee0xlivr1dazl3lhDVmweGHsOSIe6Cs3Ra9vrOQVJDhd7YGrAFJKfL aVhg== X-Gm-Message-State: AOAM533PQCdY3sgmPxI+SXvBB/iPUafMfqP4MK33eVyAE4qsKFIcfD70 8TozFj0F/mpPuDAU0qANeQU= X-Google-Smtp-Source: ABdhPJzKZc/XQ+fV0m19x1zrzrTnVXlm9/5kK9IV3yDSnB/JNoam4AlRGKu+3WZKYWOwLNVhMsbvNg== X-Received: by 2002:a05:6000:10:: with SMTP id h16mr4754013wrx.24.1630599394935; Thu, 02 Sep 2021 09:16:34 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Bin Meng , Eduardo Habkost , Greg Kurz , haxm-team@intel.com, Kamil Rytarowski , qemu-ppc@nongnu.org, Anthony Perard , Marcel Apfelbaum , Michael Rolnik , qemu-riscv@nongnu.org, Paolo Bonzini , Jiaxun Yang , Thomas Huth , David Hildenbrand , Chris Wulff , Laurent Vivier , Cameron Esfahani , Sunil Muthuswamy , Max Filippov , Taylor Simpson , qemu-s390x@nongnu.org, Richard Henderson , Bastian Koppelmann , Yoshinori Sato , Artyom Tarasenko , Aurelien Jarno , Paul Durrant , Peter Maydell , David Gibson , Alistair Francis , "Edgar E. Iglesias" , Roman Bolshakov , Laurent Vivier , Cornelia Huck , qemu-arm@nongnu.org, Wenchao Wang , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , xen-devel@lists.xenproject.org, Marek Vasut , Stefano Stabellini , Aleksandar Rikalo , Mark Cave-Ayland , Colin Xu , Claudio Fontana , Palmer Dabbelt , Stafford Horne , Reinoud Zandijk , kvm@vger.kernel.org Subject: [PATCH v3 08/30] target/alpha: Restrict has_work() handler to sysemu and TCG Date: Thu, 2 Sep 2021 18:15:21 +0200 Message-Id: <20210902161543.417092-9-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210902161543.417092-1-f4bug@amsat.org> References: <20210902161543.417092-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Restrict has_work() to TCG sysemu. Signed-off-by: Philippe Mathieu-Daudé --- target/alpha/cpu.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/target/alpha/cpu.c b/target/alpha/cpu.c index 93e16a2ffb4..32cf5a2ea9f 100644 --- a/target/alpha/cpu.c +++ b/target/alpha/cpu.c @@ -33,6 +33,7 @@ static void alpha_cpu_set_pc(CPUState *cs, vaddr value) cpu->env.pc = value; } +#if defined(CONFIG_TCG) && !defined(CONFIG_USER_ONLY) static bool alpha_cpu_has_work(CPUState *cs) { /* Here we are checking to see if the CPU should wake up from HALT. @@ -47,6 +48,7 @@ static bool alpha_cpu_has_work(CPUState *cs) | CPU_INTERRUPT_SMP | CPU_INTERRUPT_MCHK); } +#endif /* CONFIG_TCG && !CONFIG_USER_ONLY */ static void alpha_cpu_disas_set_info(CPUState *cpu, disassemble_info *info) { @@ -221,6 +223,7 @@ static const struct TCGCPUOps alpha_tcg_ops = { .tlb_fill = alpha_cpu_tlb_fill, #ifndef CONFIG_USER_ONLY + .has_work = alpha_cpu_has_work, .cpu_exec_interrupt = alpha_cpu_exec_interrupt, .do_interrupt = alpha_cpu_do_interrupt, .do_transaction_failed = alpha_cpu_do_transaction_failed, @@ -238,7 +241,6 @@ static void alpha_cpu_class_init(ObjectClass *oc, void *data) &acc->parent_realize); cc->class_by_name = alpha_cpu_class_by_name; - cc->has_work = alpha_cpu_has_work; cc->dump_state = alpha_cpu_dump_state; cc->set_pc = alpha_cpu_set_pc; cc->gdb_read_register = alpha_cpu_gdb_read_register; -- 2.31.1 From xen-devel-bounces@lists.xenproject.org Thu Sep 02 16:16:49 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 16:16:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177449.322898 (Exim 4.92) (envelope-from ) id 1mLpOT-0005mE-HH; Thu, 02 Sep 2021 16:16:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177449.322898; Thu, 02 Sep 2021 16:16:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLpOT-0005m3-De; Thu, 02 Sep 2021 16:16:49 +0000 Received: by outflank-mailman (input) for mailman id 177449; Thu, 02 Sep 2021 16:16:48 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLpOS-00029c-P7 for xen-devel@lists.xenproject.org; Thu, 02 Sep 2021 16:16:48 +0000 Received: from mail-wm1-x332.google.com (unknown [2a00:1450:4864:20::332]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 4083f8f6-3927-4403-a69c-ad13ed63b36b; Thu, 02 Sep 2021 16:16:41 +0000 (UTC) Received: by mail-wm1-x332.google.com with SMTP id 192-20020a1c04c9000000b002f7a4ab0a49so1447222wme.0 for ; Thu, 02 Sep 2021 09:16:41 -0700 (PDT) Received: from x1w.. (163.red-83-52-55.dynamicip.rima-tde.net. [83.52.55.163]) by smtp.gmail.com with ESMTPSA id s7sm2278245wra.75.2021.09.02.09.16.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Sep 2021 09:16:40 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list X-Inumbo-ID: 4083f8f6-3927-4403-a69c-ad13ed63b36b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=umRcFm5z0yg595NbXyjpfnNGeUl5eK5xZLxoXeUa+qc=; b=pz/nBk0UJK243d6EyhFjqhTq8St+3bylyw8UsBpEg2waosqkIlwbtba8uBILAoIr7Q lNryWY6OK0Yv0ei6QJ6YXdrGJmNPpUHm0iNE4fP7UqEe/h1YNv75NdMU0PYG192jLiEi nT8wtIR6GbLksC5eh0yUWGhRmDBX0INOYd68LwmG3Qv1zsVvvdfXM2Eh93Z4wPStdVNa KE8qNYenYdeo9Hw6npfh1Orrhaz/BR1l28Y8J4uAZJNC+LNfQ5fwkt6laufXunuUNo9o yefdGCG2pUPAo+hQ2RqYEKAbC+KVHHoFEwqvKykz0cg+3b9kRE25Iwy6z1ljbMNpTwU1 QDYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=umRcFm5z0yg595NbXyjpfnNGeUl5eK5xZLxoXeUa+qc=; b=a1MTd6Sr5RuLWZnKxTOu5T/ioG2OW0lRu1s3mNvFLopb/6A4BDgspUA3X3lfPWhv1L tiP2kIUHbhSTV2DdxKIheyJm9CHa+BAky5tc34eXroUJHI9gvLi1WE2VeO3zZ1PtPZcK qaoK0/J1zA/lES8H24PJgw15NEVgDu4m1r2Ib7iaSCrsDpG2rrVlF0fD82/RCKsgGm+H HXZUVAqEWzBqTiaRkLYzOw2PfxB+V3D3vdz/+ToOefkpP/GQ1qKWETg+zDd8JQ6grBPE k5sEWuNpirUPtkNS4ZD4niecwcw+64B+Fw3ZRYoYCWFelY+z4pddcFRYqVO+8/9UweEo 28Aw== X-Gm-Message-State: AOAM533tPHR+YkfVgjDlquJk0Ci0/DyHbYwDpBHZWn+CrGKqfgjr4IOo AriSYN8d7YlwWRwbMHT+8hg= X-Google-Smtp-Source: ABdhPJxG0Ekgmsw86aV3vYz0yeffJLjcyX9LXqOx701gt1hpjlWPvR2zb0A5F6AGLmteTS9Julrfnw== X-Received: by 2002:a1c:4cd:: with SMTP id 196mr4020214wme.10.1630599401061; Thu, 02 Sep 2021 09:16:41 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Bin Meng , Eduardo Habkost , Greg Kurz , haxm-team@intel.com, Kamil Rytarowski , qemu-ppc@nongnu.org, Anthony Perard , Marcel Apfelbaum , Michael Rolnik , qemu-riscv@nongnu.org, Paolo Bonzini , Jiaxun Yang , Thomas Huth , David Hildenbrand , Chris Wulff , Laurent Vivier , Cameron Esfahani , Sunil Muthuswamy , Max Filippov , Taylor Simpson , qemu-s390x@nongnu.org, Richard Henderson , Bastian Koppelmann , Yoshinori Sato , Artyom Tarasenko , Aurelien Jarno , Paul Durrant , Peter Maydell , David Gibson , Alistair Francis , "Edgar E. Iglesias" , Roman Bolshakov , Laurent Vivier , Cornelia Huck , qemu-arm@nongnu.org, Wenchao Wang , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , xen-devel@lists.xenproject.org, Marek Vasut , Stefano Stabellini , Aleksandar Rikalo , Mark Cave-Ayland , Colin Xu , Claudio Fontana , Palmer Dabbelt , Stafford Horne , Reinoud Zandijk , kvm@vger.kernel.org Subject: [PATCH v3 09/30] target/arm: Restrict has_work() handler to sysemu and TCG Date: Thu, 2 Sep 2021 18:15:22 +0200 Message-Id: <20210902161543.417092-10-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210902161543.417092-1-f4bug@amsat.org> References: <20210902161543.417092-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Restrict has_work() to TCG sysemu. Signed-off-by: Philippe Mathieu-Daudé --- target/arm/cpu.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/target/arm/cpu.c b/target/arm/cpu.c index ba0741b20e4..e11aa625a5f 100644 --- a/target/arm/cpu.c +++ b/target/arm/cpu.c @@ -73,8 +73,8 @@ void arm_cpu_synchronize_from_tb(CPUState *cs, env->regs[15] = tb->pc; } } -#endif /* CONFIG_TCG */ +#ifndef CONFIG_USER_ONLY static bool arm_cpu_has_work(CPUState *cs) { ARMCPU *cpu = ARM_CPU(cs); @@ -85,6 +85,9 @@ static bool arm_cpu_has_work(CPUState *cs) | CPU_INTERRUPT_VFIQ | CPU_INTERRUPT_VIRQ | CPU_INTERRUPT_EXITTB); } +#endif /* !CONFIG_USER_ONLY */ + +#endif /* CONFIG_TCG */ void arm_register_pre_el_change_hook(ARMCPU *cpu, ARMELChangeHookFn *hook, void *opaque) @@ -2017,6 +2020,7 @@ static const struct TCGCPUOps arm_tcg_ops = { .debug_excp_handler = arm_debug_excp_handler, #if !defined(CONFIG_USER_ONLY) + .has_work = arm_cpu_has_work, .cpu_exec_interrupt = arm_cpu_exec_interrupt, .do_interrupt = arm_cpu_do_interrupt, .do_transaction_failed = arm_cpu_do_transaction_failed, @@ -2041,7 +2045,6 @@ static void arm_cpu_class_init(ObjectClass *oc, void *data) device_class_set_parent_reset(dc, arm_cpu_reset, &acc->parent_reset); cc->class_by_name = arm_cpu_class_by_name; - cc->has_work = arm_cpu_has_work; cc->dump_state = arm_cpu_dump_state; cc->set_pc = arm_cpu_set_pc; cc->gdb_read_register = arm_cpu_gdb_read_register; -- 2.31.1 From xen-devel-bounces@lists.xenproject.org Thu Sep 02 16:18:13 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 16:18:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177462.322909 (Exim 4.92) (envelope-from ) id 1mLpPn-0007BT-Vq; Thu, 02 Sep 2021 16:18:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177462.322909; Thu, 02 Sep 2021 16:18:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLpPn-0007BM-Qm; Thu, 02 Sep 2021 16:18:11 +0000 Received: by outflank-mailman (input) for mailman id 177462; Thu, 02 Sep 2021 16:18:10 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLpPm-0007B4-Cu for xen-devel@lists.xenproject.org; Thu, 02 Sep 2021 16:18:10 +0000 Received: from mail-wm1-x32b.google.com (unknown [2a00:1450:4864:20::32b]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 01f06e99-8be3-4465-a2f9-a2b4690f76ce; Thu, 02 Sep 2021 16:18:08 +0000 (UTC) Received: by mail-wm1-x32b.google.com with SMTP id m25-20020a7bcb99000000b002e751bcb5dbso1735750wmi.5 for ; Thu, 02 Sep 2021 09:18:08 -0700 (PDT) Received: from x1w.. (163.red-83-52-55.dynamicip.rima-tde.net. [83.52.55.163]) by smtp.gmail.com with ESMTPSA id k14sm2234887wri.46.2021.09.02.09.18.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Sep 2021 09:18:06 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list X-Inumbo-ID: 01f06e99-8be3-4465-a2f9-a2b4690f76ce DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=UWFl0S8+QJmSRfKpaWNU58d5jvI099dEW79c4Eds8Co=; b=qyX0fbK8beMEiA2sBSgl3PW3ky5dGcSVCBtTwKFMLbBLTDoVjxKFiSsk0jDC/pFJh8 EQJ9wt19ZKu7z9D2NO2X1GBhffNKLdpe3QtarXXg5bKru7SgrpNFq7ykSau/rj7BWEMU 1lB3fKoh6dEiYxH/wEudtnGa9nyEo7DeltzASvLMnmAUaT41c/G+J+JRbl3ezoYTAza1 Y+ETvUqkI+1eP+JhGzMn2Azr7F5hdjAx5ZUxT+4ueBQ0CSz4Bd282avi1jucNAchPVMA 9SsBqrFRz0Y5wm79SMIMZa6Daop/L/LafP8vvrGNOlI29+ElFdjMqyjQo9hpcEC0Ade/ GupA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=UWFl0S8+QJmSRfKpaWNU58d5jvI099dEW79c4Eds8Co=; b=qbYB+lHC3517KpzJLBT9MQiKuA4rWUW6Hviyi6tjq3zJ0kJqIV+Ngv9mZCgu9tyj7F faqEg4t7jBJcez6elKSA2n+GqJRlPk0fSy0vZI0EPuBk2vj3fUXRSgLjsE6180FpoU+W aZ/cqMLQWnM44zi32wC46EXZ67bytLm64mExhPw4CL8DhtOavQ1RuRg3O7phsHwAhi+g NUM2WW5A4QR3ojjFua2+pdmkfCosdGNS7CjPZpEV8dSMBTNsYX0XAAo6o/N6fXHxXD1Q nYCOsitfvSh1PaWGaQanJeNxziCMOvqKkhU6STNlbDz8DpmMX86AhRN4K/smuSpoqXhH RX7w== X-Gm-Message-State: AOAM531pyzbwVShzwoh8XUduIFc/Q+p73tE0GjlwpSBVkc0qPHYnFv0D rZ6U6DvmgMRGU0hBaXXIkHk= X-Google-Smtp-Source: ABdhPJxiiVaTYWvAG9DN++m79S0TQSTDr2C/1kQW8ctmk5/+oYLKUYcjyiQjFsrDz4LSrxOSg3eaUA== X-Received: by 2002:a1c:202:: with SMTP id 2mr3928971wmc.122.1630599486805; Thu, 02 Sep 2021 09:18:06 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Bin Meng , Eduardo Habkost , Greg Kurz , haxm-team@intel.com, Kamil Rytarowski , qemu-ppc@nongnu.org, Anthony Perard , Marcel Apfelbaum , Michael Rolnik , qemu-riscv@nongnu.org, Paolo Bonzini , Jiaxun Yang , Thomas Huth , David Hildenbrand , Chris Wulff , Laurent Vivier , Cameron Esfahani , Sunil Muthuswamy , Max Filippov , Taylor Simpson , qemu-s390x@nongnu.org, Richard Henderson , Bastian Koppelmann , Yoshinori Sato , Artyom Tarasenko , Aurelien Jarno , Paul Durrant , Peter Maydell , David Gibson , Alistair Francis , "Edgar E. Iglesias" , Roman Bolshakov , Laurent Vivier , Cornelia Huck , qemu-arm@nongnu.org, Wenchao Wang , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , xen-devel@lists.xenproject.org, Marek Vasut , Stefano Stabellini , Aleksandar Rikalo , Mark Cave-Ayland , Colin Xu , Claudio Fontana , Palmer Dabbelt , Stafford Horne , Reinoud Zandijk , kvm@vger.kernel.org Subject: [PATCH v3 22/30] target/ppc: Simplify has_work() handlers Date: Thu, 2 Sep 2021 18:15:35 +0200 Message-Id: <20210902161543.417092-23-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210902161543.417092-1-f4bug@amsat.org> References: <20210902161543.417092-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The common ppc_cpu_has_work() handler already checks for cs->halted, so we can simplify all callees. Signed-off-by: Philippe Mathieu-Daudé --- target/ppc/cpu_init.c | 294 ++++++++++++++++++++---------------------- 1 file changed, 138 insertions(+), 156 deletions(-) diff --git a/target/ppc/cpu_init.c b/target/ppc/cpu_init.c index bbad16cc1ec..c8ec47d58fa 100644 --- a/target/ppc/cpu_init.c +++ b/target/ppc/cpu_init.c @@ -7589,33 +7589,29 @@ static bool cpu_has_work_POWER7(CPUState *cs) PowerPCCPU *cpu = POWERPC_CPU(cs); CPUPPCState *env = &cpu->env; - if (cs->halted) { - if (!(cs->interrupt_request & CPU_INTERRUPT_HARD)) { - return false; - } - if ((env->pending_interrupts & (1u << PPC_INTERRUPT_EXT)) && - (env->spr[SPR_LPCR] & LPCR_P7_PECE0)) { - return true; - } - if ((env->pending_interrupts & (1u << PPC_INTERRUPT_DECR)) && - (env->spr[SPR_LPCR] & LPCR_P7_PECE1)) { - return true; - } - if ((env->pending_interrupts & (1u << PPC_INTERRUPT_MCK)) && - (env->spr[SPR_LPCR] & LPCR_P7_PECE2)) { - return true; - } - if ((env->pending_interrupts & (1u << PPC_INTERRUPT_HMI)) && - (env->spr[SPR_LPCR] & LPCR_P7_PECE2)) { - return true; - } - if (env->pending_interrupts & (1u << PPC_INTERRUPT_RESET)) { - return true; - } + if (!(cs->interrupt_request & CPU_INTERRUPT_HARD)) { return false; - } else { - return msr_ee && (cs->interrupt_request & CPU_INTERRUPT_HARD); } + if ((env->pending_interrupts & (1u << PPC_INTERRUPT_EXT)) && + (env->spr[SPR_LPCR] & LPCR_P7_PECE0)) { + return true; + } + if ((env->pending_interrupts & (1u << PPC_INTERRUPT_DECR)) && + (env->spr[SPR_LPCR] & LPCR_P7_PECE1)) { + return true; + } + if ((env->pending_interrupts & (1u << PPC_INTERRUPT_MCK)) && + (env->spr[SPR_LPCR] & LPCR_P7_PECE2)) { + return true; + } + if ((env->pending_interrupts & (1u << PPC_INTERRUPT_HMI)) && + (env->spr[SPR_LPCR] & LPCR_P7_PECE2)) { + return true; + } + if (env->pending_interrupts & (1u << PPC_INTERRUPT_RESET)) { + return true; + } + return false; } #endif /* CONFIG_TCG && !CONFIG_USER_ONLY */ @@ -7750,41 +7746,37 @@ static bool cpu_has_work_POWER8(CPUState *cs) PowerPCCPU *cpu = POWERPC_CPU(cs); CPUPPCState *env = &cpu->env; - if (cs->halted) { - if (!(cs->interrupt_request & CPU_INTERRUPT_HARD)) { - return false; - } - if ((env->pending_interrupts & (1u << PPC_INTERRUPT_EXT)) && - (env->spr[SPR_LPCR] & LPCR_P8_PECE2)) { - return true; - } - if ((env->pending_interrupts & (1u << PPC_INTERRUPT_DECR)) && - (env->spr[SPR_LPCR] & LPCR_P8_PECE3)) { - return true; - } - if ((env->pending_interrupts & (1u << PPC_INTERRUPT_MCK)) && - (env->spr[SPR_LPCR] & LPCR_P8_PECE4)) { - return true; - } - if ((env->pending_interrupts & (1u << PPC_INTERRUPT_HMI)) && - (env->spr[SPR_LPCR] & LPCR_P8_PECE4)) { - return true; - } - if ((env->pending_interrupts & (1u << PPC_INTERRUPT_DOORBELL)) && - (env->spr[SPR_LPCR] & LPCR_P8_PECE0)) { - return true; - } - if ((env->pending_interrupts & (1u << PPC_INTERRUPT_HDOORBELL)) && - (env->spr[SPR_LPCR] & LPCR_P8_PECE1)) { - return true; - } - if (env->pending_interrupts & (1u << PPC_INTERRUPT_RESET)) { - return true; - } + if (!(cs->interrupt_request & CPU_INTERRUPT_HARD)) { return false; - } else { - return msr_ee && (cs->interrupt_request & CPU_INTERRUPT_HARD); } + if ((env->pending_interrupts & (1u << PPC_INTERRUPT_EXT)) && + (env->spr[SPR_LPCR] & LPCR_P8_PECE2)) { + return true; + } + if ((env->pending_interrupts & (1u << PPC_INTERRUPT_DECR)) && + (env->spr[SPR_LPCR] & LPCR_P8_PECE3)) { + return true; + } + if ((env->pending_interrupts & (1u << PPC_INTERRUPT_MCK)) && + (env->spr[SPR_LPCR] & LPCR_P8_PECE4)) { + return true; + } + if ((env->pending_interrupts & (1u << PPC_INTERRUPT_HMI)) && + (env->spr[SPR_LPCR] & LPCR_P8_PECE4)) { + return true; + } + if ((env->pending_interrupts & (1u << PPC_INTERRUPT_DOORBELL)) && + (env->spr[SPR_LPCR] & LPCR_P8_PECE0)) { + return true; + } + if ((env->pending_interrupts & (1u << PPC_INTERRUPT_HDOORBELL)) && + (env->spr[SPR_LPCR] & LPCR_P8_PECE1)) { + return true; + } + if (env->pending_interrupts & (1u << PPC_INTERRUPT_RESET)) { + return true; + } + return false; } #endif /* CONFIG_TCG && !CONFIG_USER_ONLY */ @@ -7948,58 +7940,53 @@ static bool cpu_has_work_POWER9(CPUState *cs) { PowerPCCPU *cpu = POWERPC_CPU(cs); CPUPPCState *env = &cpu->env; + uint64_t psscr = env->spr[SPR_PSSCR]; - if (cs->halted) { - uint64_t psscr = env->spr[SPR_PSSCR]; - - if (!(cs->interrupt_request & CPU_INTERRUPT_HARD)) { - return false; - } - - /* If EC is clear, just return true on any pending interrupt */ - if (!(psscr & PSSCR_EC)) { - return true; - } - /* External Exception */ - if ((env->pending_interrupts & (1u << PPC_INTERRUPT_EXT)) && - (env->spr[SPR_LPCR] & LPCR_EEE)) { - bool heic = !!(env->spr[SPR_LPCR] & LPCR_HEIC); - if (heic == 0 || !msr_hv || msr_pr) { - return true; - } - } - /* Decrementer Exception */ - if ((env->pending_interrupts & (1u << PPC_INTERRUPT_DECR)) && - (env->spr[SPR_LPCR] & LPCR_DEE)) { - return true; - } - /* Machine Check or Hypervisor Maintenance Exception */ - if ((env->pending_interrupts & (1u << PPC_INTERRUPT_MCK | - 1u << PPC_INTERRUPT_HMI)) && (env->spr[SPR_LPCR] & LPCR_OEE)) { - return true; - } - /* Privileged Doorbell Exception */ - if ((env->pending_interrupts & (1u << PPC_INTERRUPT_DOORBELL)) && - (env->spr[SPR_LPCR] & LPCR_PDEE)) { - return true; - } - /* Hypervisor Doorbell Exception */ - if ((env->pending_interrupts & (1u << PPC_INTERRUPT_HDOORBELL)) && - (env->spr[SPR_LPCR] & LPCR_HDEE)) { - return true; - } - /* Hypervisor virtualization exception */ - if ((env->pending_interrupts & (1u << PPC_INTERRUPT_HVIRT)) && - (env->spr[SPR_LPCR] & LPCR_HVEE)) { - return true; - } - if (env->pending_interrupts & (1u << PPC_INTERRUPT_RESET)) { - return true; - } + if (!(cs->interrupt_request & CPU_INTERRUPT_HARD)) { return false; - } else { - return msr_ee && (cs->interrupt_request & CPU_INTERRUPT_HARD); } + + /* If EC is clear, just return true on any pending interrupt */ + if (!(psscr & PSSCR_EC)) { + return true; + } + /* External Exception */ + if ((env->pending_interrupts & (1u << PPC_INTERRUPT_EXT)) && + (env->spr[SPR_LPCR] & LPCR_EEE)) { + bool heic = !!(env->spr[SPR_LPCR] & LPCR_HEIC); + if (heic == 0 || !msr_hv || msr_pr) { + return true; + } + } + /* Decrementer Exception */ + if ((env->pending_interrupts & (1u << PPC_INTERRUPT_DECR)) && + (env->spr[SPR_LPCR] & LPCR_DEE)) { + return true; + } + /* Machine Check or Hypervisor Maintenance Exception */ + if ((env->pending_interrupts & (1u << PPC_INTERRUPT_MCK | + 1u << PPC_INTERRUPT_HMI)) && (env->spr[SPR_LPCR] & LPCR_OEE)) { + return true; + } + /* Privileged Doorbell Exception */ + if ((env->pending_interrupts & (1u << PPC_INTERRUPT_DOORBELL)) && + (env->spr[SPR_LPCR] & LPCR_PDEE)) { + return true; + } + /* Hypervisor Doorbell Exception */ + if ((env->pending_interrupts & (1u << PPC_INTERRUPT_HDOORBELL)) && + (env->spr[SPR_LPCR] & LPCR_HDEE)) { + return true; + } + /* Hypervisor virtualization exception */ + if ((env->pending_interrupts & (1u << PPC_INTERRUPT_HVIRT)) && + (env->spr[SPR_LPCR] & LPCR_HVEE)) { + return true; + } + if (env->pending_interrupts & (1u << PPC_INTERRUPT_RESET)) { + return true; + } + return false; } #endif /* CONFIG_TCG && !CONFIG_USER_ONLY */ @@ -8158,58 +8145,53 @@ static bool cpu_has_work_POWER10(CPUState *cs) { PowerPCCPU *cpu = POWERPC_CPU(cs); CPUPPCState *env = &cpu->env; + uint64_t psscr = env->spr[SPR_PSSCR]; - if (cs->halted) { - uint64_t psscr = env->spr[SPR_PSSCR]; - - if (!(cs->interrupt_request & CPU_INTERRUPT_HARD)) { - return false; - } - - /* If EC is clear, just return true on any pending interrupt */ - if (!(psscr & PSSCR_EC)) { - return true; - } - /* External Exception */ - if ((env->pending_interrupts & (1u << PPC_INTERRUPT_EXT)) && - (env->spr[SPR_LPCR] & LPCR_EEE)) { - bool heic = !!(env->spr[SPR_LPCR] & LPCR_HEIC); - if (heic == 0 || !msr_hv || msr_pr) { - return true; - } - } - /* Decrementer Exception */ - if ((env->pending_interrupts & (1u << PPC_INTERRUPT_DECR)) && - (env->spr[SPR_LPCR] & LPCR_DEE)) { - return true; - } - /* Machine Check or Hypervisor Maintenance Exception */ - if ((env->pending_interrupts & (1u << PPC_INTERRUPT_MCK | - 1u << PPC_INTERRUPT_HMI)) && (env->spr[SPR_LPCR] & LPCR_OEE)) { - return true; - } - /* Privileged Doorbell Exception */ - if ((env->pending_interrupts & (1u << PPC_INTERRUPT_DOORBELL)) && - (env->spr[SPR_LPCR] & LPCR_PDEE)) { - return true; - } - /* Hypervisor Doorbell Exception */ - if ((env->pending_interrupts & (1u << PPC_INTERRUPT_HDOORBELL)) && - (env->spr[SPR_LPCR] & LPCR_HDEE)) { - return true; - } - /* Hypervisor virtualization exception */ - if ((env->pending_interrupts & (1u << PPC_INTERRUPT_HVIRT)) && - (env->spr[SPR_LPCR] & LPCR_HVEE)) { - return true; - } - if (env->pending_interrupts & (1u << PPC_INTERRUPT_RESET)) { - return true; - } + if (!(cs->interrupt_request & CPU_INTERRUPT_HARD)) { return false; - } else { - return msr_ee && (cs->interrupt_request & CPU_INTERRUPT_HARD); } + + /* If EC is clear, just return true on any pending interrupt */ + if (!(psscr & PSSCR_EC)) { + return true; + } + /* External Exception */ + if ((env->pending_interrupts & (1u << PPC_INTERRUPT_EXT)) && + (env->spr[SPR_LPCR] & LPCR_EEE)) { + bool heic = !!(env->spr[SPR_LPCR] & LPCR_HEIC); + if (heic == 0 || !msr_hv || msr_pr) { + return true; + } + } + /* Decrementer Exception */ + if ((env->pending_interrupts & (1u << PPC_INTERRUPT_DECR)) && + (env->spr[SPR_LPCR] & LPCR_DEE)) { + return true; + } + /* Machine Check or Hypervisor Maintenance Exception */ + if ((env->pending_interrupts & (1u << PPC_INTERRUPT_MCK | + 1u << PPC_INTERRUPT_HMI)) && (env->spr[SPR_LPCR] & LPCR_OEE)) { + return true; + } + /* Privileged Doorbell Exception */ + if ((env->pending_interrupts & (1u << PPC_INTERRUPT_DOORBELL)) && + (env->spr[SPR_LPCR] & LPCR_PDEE)) { + return true; + } + /* Hypervisor Doorbell Exception */ + if ((env->pending_interrupts & (1u << PPC_INTERRUPT_HDOORBELL)) && + (env->spr[SPR_LPCR] & LPCR_HDEE)) { + return true; + } + /* Hypervisor virtualization exception */ + if ((env->pending_interrupts & (1u << PPC_INTERRUPT_HVIRT)) && + (env->spr[SPR_LPCR] & LPCR_HVEE)) { + return true; + } + if (env->pending_interrupts & (1u << PPC_INTERRUPT_RESET)) { + return true; + } + return false; } #endif /* CONFIG_TCG && !CONFIG_USER_ONLY */ -- 2.31.1 From xen-devel-bounces@lists.xenproject.org Thu Sep 02 16:18:16 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 16:18:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177463.322920 (Exim 4.92) (envelope-from ) id 1mLpPs-0007UK-Ab; Thu, 02 Sep 2021 16:18:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177463.322920; Thu, 02 Sep 2021 16:18:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLpPs-0007UB-6e; Thu, 02 Sep 2021 16:18:16 +0000 Received: by outflank-mailman (input) for mailman id 177463; Thu, 02 Sep 2021 16:18:14 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLpPq-0007B4-Ej for xen-devel@lists.xenproject.org; Thu, 02 Sep 2021 16:18:14 +0000 Received: from mail-wr1-x42a.google.com (unknown [2a00:1450:4864:20::42a]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id dc5d9528-0d0a-4ac3-9ada-94748a1401dd; Thu, 02 Sep 2021 16:18:13 +0000 (UTC) Received: by mail-wr1-x42a.google.com with SMTP id n5so3813844wro.12 for ; Thu, 02 Sep 2021 09:18:13 -0700 (PDT) Received: from x1w.. (163.red-83-52-55.dynamicip.rima-tde.net. [83.52.55.163]) by smtp.gmail.com with ESMTPSA id g1sm2930192wrb.27.2021.09.02.09.18.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Sep 2021 09:18:12 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list X-Inumbo-ID: dc5d9528-0d0a-4ac3-9ada-94748a1401dd DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=NcTQcOUeeehYkPycaMHvSzYk1/JpDe+W3tlOioHt6ec=; b=Qo3n3nT5T2uCxZDbpwI/2fMsolvJt4Y1gOrYSxa05AyniYxnVrYAyAl58E/mePDB+Q mp74y9slo+JHNdNbb124nVsmTrRmSYtRFeXvQ45hmAzQLS7SZdoREJlqjngb5ERIDHOz 8fG18ynHtTwJKTgzScUP5EYAEGDfAkaAdwzs1bs8Mwbkci0fjxZIrzyNblhH2fEmvKn0 14gWvYc8/SbUfS0Y8MjZjc8PX2H+MElpBG7G8YmI1yDXyIqgKhSWIpr7bVwK4JmVtxvW D4kk4tzADto1QBEDwX3w/FLijcMe32GJWkC5PPc+o9liJR70fQ003gNi58OOJ6evLU1W Khjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=NcTQcOUeeehYkPycaMHvSzYk1/JpDe+W3tlOioHt6ec=; b=SYjlQoR/J7tk5xKhuFLbP8mtHn0u5Y58HRYbmKJX6Gh1gn1SFrdvssMT4dRUWG5mOi 0fnxWPaGTE5WY0PvLeUe592iAgIogd5nOkIYUyKCxLAs6R7FJtx+WXIJqwF1G+FUbkRN SzwqRz0bT0M/RlZzeGPKYbt+yyPjD4VTD/I80sjEB8duFb7vUEjXnE5hWDBhv1DTVog+ pWZEPQjTDCu/XfK7aDhNSkjqcLQGNmKKC0RDyB0dQmsJAX4P5CU1KjtGbvARkoDJuazz B/hSezodbuoD//QQtaXv6IXzggdep5DQaRn1p+55k7ZfEvktTIr4ZOFsKzJaKu1yZiZh VGcQ== X-Gm-Message-State: AOAM5318aK6bK+2yl3r5WBdGH4QLX+vA1wZmR1T4AwVVkW9zFPC4Ngy0 LvN1day/ndVD9/dULbd2ac8= X-Google-Smtp-Source: ABdhPJzq4gEgBOzEB6hIFdgS7MM2mMxbBTgou1tfWKrQyw8z4fa5k0Y3IhkCYtobsiFPzwgsy9U7mQ== X-Received: by 2002:adf:c390:: with SMTP id p16mr4949292wrf.105.1630599492959; Thu, 02 Sep 2021 09:18:12 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Bin Meng , Eduardo Habkost , Greg Kurz , haxm-team@intel.com, Kamil Rytarowski , qemu-ppc@nongnu.org, Anthony Perard , Marcel Apfelbaum , Michael Rolnik , qemu-riscv@nongnu.org, Paolo Bonzini , Jiaxun Yang , Thomas Huth , David Hildenbrand , Chris Wulff , Laurent Vivier , Cameron Esfahani , Sunil Muthuswamy , Max Filippov , Taylor Simpson , qemu-s390x@nongnu.org, Richard Henderson , Bastian Koppelmann , Yoshinori Sato , Artyom Tarasenko , Aurelien Jarno , Paul Durrant , Peter Maydell , David Gibson , Alistair Francis , "Edgar E. Iglesias" , Roman Bolshakov , Laurent Vivier , Cornelia Huck , qemu-arm@nongnu.org, Wenchao Wang , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , xen-devel@lists.xenproject.org, Marek Vasut , Stefano Stabellini , Aleksandar Rikalo , Mark Cave-Ayland , Colin Xu , Claudio Fontana , Palmer Dabbelt , Stafford Horne , Reinoud Zandijk , kvm@vger.kernel.org Subject: [PATCH v3 23/30] target/riscv: Restrict has_work() handler to sysemu and TCG Date: Thu, 2 Sep 2021 18:15:36 +0200 Message-Id: <20210902161543.417092-24-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210902161543.417092-1-f4bug@amsat.org> References: <20210902161543.417092-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Restrict has_work() to TCG sysemu. Signed-off-by: Philippe Mathieu-Daudé --- target/riscv/cpu.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c index 13575c14085..abb555a8bdb 100644 --- a/target/riscv/cpu.c +++ b/target/riscv/cpu.c @@ -335,9 +335,9 @@ static void riscv_cpu_synchronize_from_tb(CPUState *cs, env->pc = tb->pc; } +#if defined(CONFIG_TCG) && !defined(CONFIG_USER_ONLY) static bool riscv_cpu_has_work(CPUState *cs) { -#ifndef CONFIG_USER_ONLY RISCVCPU *cpu = RISCV_CPU(cs); CPURISCVState *env = &cpu->env; /* @@ -345,10 +345,8 @@ static bool riscv_cpu_has_work(CPUState *cs) * mode and delegation registers, but respect individual enables */ return (env->mip & env->mie) != 0; -#else - return true; -#endif } +#endif /* CONFIG_TCG && !CONFIG_USER_ONLY */ void restore_state_to_opc(CPURISCVState *env, TranslationBlock *tb, target_ulong *data) @@ -647,6 +645,7 @@ static const struct TCGCPUOps riscv_tcg_ops = { .tlb_fill = riscv_cpu_tlb_fill, #ifndef CONFIG_USER_ONLY + .has_work = riscv_cpu_has_work, .cpu_exec_interrupt = riscv_cpu_exec_interrupt, .do_interrupt = riscv_cpu_do_interrupt, .do_transaction_failed = riscv_cpu_do_transaction_failed, @@ -666,7 +665,6 @@ static void riscv_cpu_class_init(ObjectClass *c, void *data) device_class_set_parent_reset(dc, riscv_cpu_reset, &mcc->parent_reset); cc->class_by_name = riscv_cpu_class_by_name; - cc->has_work = riscv_cpu_has_work; cc->dump_state = riscv_cpu_dump_state; cc->set_pc = riscv_cpu_set_pc; cc->gdb_read_register = riscv_cpu_gdb_read_register; -- 2.31.1 From xen-devel-bounces@lists.xenproject.org Thu Sep 02 16:18:22 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 16:18:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177464.322931 (Exim 4.92) (envelope-from ) id 1mLpPy-0007rZ-Kq; Thu, 02 Sep 2021 16:18:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177464.322931; Thu, 02 Sep 2021 16:18:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLpPy-0007rK-GN; Thu, 02 Sep 2021 16:18:22 +0000 Received: by outflank-mailman (input) for mailman id 177464; Thu, 02 Sep 2021 16:18:20 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLpPw-0007of-Iv for xen-devel@lists.xenproject.org; Thu, 02 Sep 2021 16:18:20 +0000 Received: from mail-wm1-x329.google.com (unknown [2a00:1450:4864:20::329]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id b72cc44c-9d4f-42be-b49a-d342b8f6eda6; Thu, 02 Sep 2021 16:18:19 +0000 (UTC) Received: by mail-wm1-x329.google.com with SMTP id e26so1676496wmk.2 for ; Thu, 02 Sep 2021 09:18:19 -0700 (PDT) Received: from x1w.. (163.red-83-52-55.dynamicip.rima-tde.net. [83.52.55.163]) by smtp.gmail.com with ESMTPSA id l35sm1842816wms.40.2021.09.02.09.18.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Sep 2021 09:18:18 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list X-Inumbo-ID: b72cc44c-9d4f-42be-b49a-d342b8f6eda6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=iBR7XZaVDWa3VEAQfJT4KESDdYv2ZsQvbER1+LPZ/aI=; b=b3oM2a7kfu59T16h1BQOivDnrY/oITcLEbYMDbyYiQhSRpMPPbkow/DjE+1Ih4EQL/ DUMVJOdg0XVJbEcJ79XxMVenCZKrXPuNo4lfReSnNPQpSjZ4YOofjjl3erNURKNYsHtL HEHPXeiHX0YfdcBowdh8WFKOQbcQAU/wfMDvbfu4iq/jPgfcZfFUIVDjHXKT3CRk6R6M vj3MnraM9QYlz2Bf2AIl43yWvEv2b8GLOTUYPYAin5G610qJf8lQsTsudFi4GarHEOkf I84tHwdyec/ClmJMz9FqfnRo+aZy5mZWv4eOOqkltbqaFUUFGtiu6tZ9fx/UuTf496te WjkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=iBR7XZaVDWa3VEAQfJT4KESDdYv2ZsQvbER1+LPZ/aI=; b=XC7H63v/lhUXbDyNEzU8+md8Q33329MaofzYASS1Mq3uAkryDjopPy10l2SFqURquz rypd3uWrS/XI2sdwbefbN5FCw0gPIGnAdQxEACoDsnPFktesRwu/8swgQ9wv/D+abhsA a7vPjgFklBktI90f3R7cO4OinSfwdf8yKneHny/iv3NJrH3vQTFlwZ0DfmQ1AM9jdNVX b2lpKZ81+bYon/Qa50+OqeAfnfdK4Xf7Eh1ihcaMXF3T/WFvSxIL91TeASmRk/uDpED9 RAKjrUZG7VEHFcUcthBdGay2ZruJp3G+9HF7tq6RilzRRwdcFmr0mNVQuBA4KqIJkNPK OVtQ== X-Gm-Message-State: AOAM530T+JziSXzZmMQWBcwGHaNGrFP7TX7pNrSZ1rFAZILHHFsNY26y p2JcI1tMAU+TxdVidVWyYYY= X-Google-Smtp-Source: ABdhPJzOyuZQlMcSsHM1l7m0tMnQ7s93BFuzpn/h6Lj/C0+zH4RsxK7hVpmbT/Jm+TQOVSFAinpu2Q== X-Received: by 2002:a1c:4682:: with SMTP id t124mr4067940wma.168.1630599499125; Thu, 02 Sep 2021 09:18:19 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Bin Meng , Eduardo Habkost , Greg Kurz , haxm-team@intel.com, Kamil Rytarowski , qemu-ppc@nongnu.org, Anthony Perard , Marcel Apfelbaum , Michael Rolnik , qemu-riscv@nongnu.org, Paolo Bonzini , Jiaxun Yang , Thomas Huth , David Hildenbrand , Chris Wulff , Laurent Vivier , Cameron Esfahani , Sunil Muthuswamy , Max Filippov , Taylor Simpson , qemu-s390x@nongnu.org, Richard Henderson , Bastian Koppelmann , Yoshinori Sato , Artyom Tarasenko , Aurelien Jarno , Paul Durrant , Peter Maydell , David Gibson , Alistair Francis , "Edgar E. Iglesias" , Roman Bolshakov , Laurent Vivier , Cornelia Huck , qemu-arm@nongnu.org, Wenchao Wang , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , xen-devel@lists.xenproject.org, Marek Vasut , Stefano Stabellini , Aleksandar Rikalo , Mark Cave-Ayland , Colin Xu , Claudio Fontana , Palmer Dabbelt , Stafford Horne , Reinoud Zandijk , kvm@vger.kernel.org Subject: [PATCH v3 24/30] target/rx: Restrict has_work() handler to sysemu and TCG Date: Thu, 2 Sep 2021 18:15:37 +0200 Message-Id: <20210902161543.417092-25-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210902161543.417092-1-f4bug@amsat.org> References: <20210902161543.417092-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Restrict has_work() to TCG sysemu. Signed-off-by: Philippe Mathieu-Daudé --- target/rx/cpu.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/target/rx/cpu.c b/target/rx/cpu.c index 25a4aa2976d..0d0cf6f9028 100644 --- a/target/rx/cpu.c +++ b/target/rx/cpu.c @@ -41,11 +41,13 @@ static void rx_cpu_synchronize_from_tb(CPUState *cs, cpu->env.pc = tb->pc; } +#if defined(CONFIG_TCG) && !defined(CONFIG_USER_ONLY) static bool rx_cpu_has_work(CPUState *cs) { return cs->interrupt_request & (CPU_INTERRUPT_HARD | CPU_INTERRUPT_FIR); } +#endif /* CONFIG_TCG && !CONFIG_USER_ONLY */ static void rx_cpu_reset(DeviceState *dev) { @@ -189,6 +191,7 @@ static const struct TCGCPUOps rx_tcg_ops = { .tlb_fill = rx_cpu_tlb_fill, #ifndef CONFIG_USER_ONLY + .has_work = rx_cpu_has_work, .cpu_exec_interrupt = rx_cpu_exec_interrupt, .do_interrupt = rx_cpu_do_interrupt, #endif /* !CONFIG_USER_ONLY */ @@ -206,7 +209,6 @@ static void rx_cpu_class_init(ObjectClass *klass, void *data) &rcc->parent_reset); cc->class_by_name = rx_cpu_class_by_name; - cc->has_work = rx_cpu_has_work; cc->dump_state = rx_cpu_dump_state; cc->set_pc = rx_cpu_set_pc; -- 2.31.1 From xen-devel-bounces@lists.xenproject.org Thu Sep 02 16:21:17 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 16:21:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177485.322953 (Exim 4.92) (envelope-from ) id 1mLpSe-0001le-Dr; Thu, 02 Sep 2021 16:21:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177485.322953; Thu, 02 Sep 2021 16:21:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLpSe-0001lX-9k; Thu, 02 Sep 2021 16:21:08 +0000 Received: by outflank-mailman (input) for mailman id 177485; Thu, 02 Sep 2021 16:21:06 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLpPf-00029c-Rf for xen-devel@lists.xenproject.org; Thu, 02 Sep 2021 16:18:03 +0000 Received: from mail-wr1-x431.google.com (unknown [2a00:1450:4864:20::431]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id f94f3479-ee5e-4e24-8010-a4d3fd425a0c; Thu, 02 Sep 2021 16:18:01 +0000 (UTC) Received: by mail-wr1-x431.google.com with SMTP id q11so3831715wrr.9 for ; Thu, 02 Sep 2021 09:18:01 -0700 (PDT) Received: from x1w.. (163.red-83-52-55.dynamicip.rima-tde.net. [83.52.55.163]) by smtp.gmail.com with ESMTPSA id c3sm2411819wrd.34.2021.09.02.09.17.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Sep 2021 09:17:59 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list X-Inumbo-ID: f94f3479-ee5e-4e24-8010-a4d3fd425a0c DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=MUUy/NWyVU2hg662wvWPJPkcXsVUh4rWx1BGsDTs1tA=; b=kEnHldIRSmSDQxyQdugw1Vx8L7xguo0M9caEjgWu9MaZq6gyOqkCAuD92VRjnuFYVu AFC1pCBYhs9ACTTeUQoUMMput3Qpo+G6rdKTIhD095mZXQogsq0uWanMgwmK05q4B113 wHEl+rU0Lu5ECIbKPzs4FN4XtzXbG2tlJtl+zohx+CtLscNoURzNPXzDuLlX3udxNyRV ISqkEHEFnJiqPltUmbvOkyQ8UgtyH8boBBAz3eZMg7gCSDPvog7KSraXXpPQ+P/Y1jP/ dnFgk5Q12dkH0yO8X+tMaBzTnLA6tV2u5dL5oZQj7YYuUZIHbs6Fs72PHNz4exx0IHfr tXUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=MUUy/NWyVU2hg662wvWPJPkcXsVUh4rWx1BGsDTs1tA=; b=LIuKnwEoVAx1nRgbaqjpxz2bR35k1JfN12ITN+9b2bZueszhmsZTZStouMzM0tMHH9 47uuqJnF/oMEKIXpdhuMSHZTHydvxYDZruUSHPMxmDpjUDy15GBXZbZOtm8XkNw2YelO 1mx+1Jyrwve1GbjPp3YHBi1fEwLHDIA/D/WLaQHuv40X7JgKQbd/hCPxUc2XGxvMUsOb H8cqqaG3GkLzx1bZ7fhwcwz5G/8LF3PTb8Ka9QF+gTx8PDKk+t/PdcTYNvWCSmEyXiuK 1bnUd0LpeIRAkEGWkrH0LIBoqRLCrRrAa5v0Nkt+ThuAR6KhM88aSn2GlWVTRij7CvYe B/KA== X-Gm-Message-State: AOAM530PjsfqhLXoEMxioICsu5vnCS9gy3YJxrzCqg1ToA+KtwkRDr8G 24Qxbs5uIfXpdOfVYip+6/U= X-Google-Smtp-Source: ABdhPJwaDZNhw8vo3XF1wL5OY+S/6RqfQvS7pZENs96vrPKDQEeSMVgbBjU4oik0CYAZjXMqLcm/Gg== X-Received: by 2002:a5d:6cca:: with SMTP id c10mr4738535wrc.224.1630599480361; Thu, 02 Sep 2021 09:18:00 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Bin Meng , Eduardo Habkost , Greg Kurz , haxm-team@intel.com, Kamil Rytarowski , qemu-ppc@nongnu.org, Anthony Perard , Marcel Apfelbaum , Michael Rolnik , qemu-riscv@nongnu.org, Paolo Bonzini , Jiaxun Yang , Thomas Huth , David Hildenbrand , Chris Wulff , Laurent Vivier , Cameron Esfahani , Sunil Muthuswamy , Max Filippov , Taylor Simpson , qemu-s390x@nongnu.org, Richard Henderson , Bastian Koppelmann , Yoshinori Sato , Artyom Tarasenko , Aurelien Jarno , Paul Durrant , Peter Maydell , David Gibson , Alistair Francis , "Edgar E. Iglesias" , Roman Bolshakov , Laurent Vivier , Cornelia Huck , qemu-arm@nongnu.org, Wenchao Wang , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , xen-devel@lists.xenproject.org, Marek Vasut , Stefano Stabellini , Aleksandar Rikalo , Mark Cave-Ayland , Colin Xu , Claudio Fontana , Palmer Dabbelt , Stafford Horne , Reinoud Zandijk , kvm@vger.kernel.org Subject: [PATCH v3 21/30] target/ppc: Introduce PowerPCCPUClass::has_work() Date: Thu, 2 Sep 2021 18:15:34 +0200 Message-Id: <20210902161543.417092-22-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210902161543.417092-1-f4bug@amsat.org> References: <20210902161543.417092-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Each POWER cpu has its own has_work() implementation. Instead of overloading CPUClass on each PowerPCCPUClass init, register the generic ppc_cpu_has_work() handler, and have it call the POWER specific has_work(). Signed-off-by: Philippe Mathieu-Daudé --- target/ppc/cpu-qom.h | 3 +++ target/ppc/cpu_init.c | 26 ++++++++++++++++++-------- 2 files changed, 21 insertions(+), 8 deletions(-) diff --git a/target/ppc/cpu-qom.h b/target/ppc/cpu-qom.h index 5800fa324e8..ff2bafcde6f 100644 --- a/target/ppc/cpu-qom.h +++ b/target/ppc/cpu-qom.h @@ -189,6 +189,9 @@ struct PowerPCCPUClass { int bfd_mach; uint32_t l1_dcache_size, l1_icache_size; #ifndef CONFIG_USER_ONLY +#ifdef CONFIG_TCG + bool (*has_work)(CPUState *cpu); +#endif /* CONFIG_TCG */ unsigned int gdb_num_sprs; const char *gdb_spr_xml; #endif diff --git a/target/ppc/cpu_init.c b/target/ppc/cpu_init.c index e2e721c2b81..bbad16cc1ec 100644 --- a/target/ppc/cpu_init.c +++ b/target/ppc/cpu_init.c @@ -7583,6 +7583,7 @@ static bool ppc_pvr_match_power7(PowerPCCPUClass *pcc, uint32_t pvr) return false; } +#if defined(CONFIG_TCG) && !defined(CONFIG_USER_ONLY) static bool cpu_has_work_POWER7(CPUState *cs) { PowerPCCPU *cpu = POWERPC_CPU(cs); @@ -7616,12 +7617,12 @@ static bool cpu_has_work_POWER7(CPUState *cs) return msr_ee && (cs->interrupt_request & CPU_INTERRUPT_HARD); } } +#endif /* CONFIG_TCG && !CONFIG_USER_ONLY */ POWERPC_FAMILY(POWER7)(ObjectClass *oc, void *data) { DeviceClass *dc = DEVICE_CLASS(oc); PowerPCCPUClass *pcc = POWERPC_CPU_CLASS(oc); - CPUClass *cc = CPU_CLASS(oc); dc->fw_name = "PowerPC,POWER7"; dc->desc = "POWER7"; @@ -7630,7 +7631,6 @@ POWERPC_FAMILY(POWER7)(ObjectClass *oc, void *data) pcc->pcr_supported = PCR_COMPAT_2_06 | PCR_COMPAT_2_05; pcc->init_proc = init_proc_POWER7; pcc->check_pow = check_pow_nocheck; - cc->has_work = cpu_has_work_POWER7; pcc->insns_flags = PPC_INSNS_BASE | PPC_ISEL | PPC_STRING | PPC_MFTB | PPC_FLOAT | PPC_FLOAT_FSEL | PPC_FLOAT_FRES | PPC_FLOAT_FSQRT | PPC_FLOAT_FRSQRTE | @@ -7673,6 +7673,7 @@ POWERPC_FAMILY(POWER7)(ObjectClass *oc, void *data) pcc->lpcr_pm = LPCR_P7_PECE0 | LPCR_P7_PECE1 | LPCR_P7_PECE2; pcc->mmu_model = POWERPC_MMU_2_06; #if defined(CONFIG_SOFTMMU) + pcc->has_work = cpu_has_work_POWER7; pcc->hash64_opts = &ppc_hash64_opts_POWER7; pcc->lrg_decr_bits = 32; #endif @@ -7743,6 +7744,7 @@ static bool ppc_pvr_match_power8(PowerPCCPUClass *pcc, uint32_t pvr) return false; } +#if defined(CONFIG_TCG) && !defined(CONFIG_USER_ONLY) static bool cpu_has_work_POWER8(CPUState *cs) { PowerPCCPU *cpu = POWERPC_CPU(cs); @@ -7784,12 +7786,12 @@ static bool cpu_has_work_POWER8(CPUState *cs) return msr_ee && (cs->interrupt_request & CPU_INTERRUPT_HARD); } } +#endif /* CONFIG_TCG && !CONFIG_USER_ONLY */ POWERPC_FAMILY(POWER8)(ObjectClass *oc, void *data) { DeviceClass *dc = DEVICE_CLASS(oc); PowerPCCPUClass *pcc = POWERPC_CPU_CLASS(oc); - CPUClass *cc = CPU_CLASS(oc); dc->fw_name = "PowerPC,POWER8"; dc->desc = "POWER8"; @@ -7798,7 +7800,6 @@ POWERPC_FAMILY(POWER8)(ObjectClass *oc, void *data) pcc->pcr_supported = PCR_COMPAT_2_07 | PCR_COMPAT_2_06 | PCR_COMPAT_2_05; pcc->init_proc = init_proc_POWER8; pcc->check_pow = check_pow_nocheck; - cc->has_work = cpu_has_work_POWER8; pcc->insns_flags = PPC_INSNS_BASE | PPC_ISEL | PPC_STRING | PPC_MFTB | PPC_FLOAT | PPC_FLOAT_FSEL | PPC_FLOAT_FRES | PPC_FLOAT_FSQRT | PPC_FLOAT_FRSQRTE | @@ -7848,6 +7849,7 @@ POWERPC_FAMILY(POWER8)(ObjectClass *oc, void *data) LPCR_P8_PECE3 | LPCR_P8_PECE4; pcc->mmu_model = POWERPC_MMU_2_07; #if defined(CONFIG_SOFTMMU) + pcc->has_work = cpu_has_work_POWER8; pcc->hash64_opts = &ppc_hash64_opts_POWER7; pcc->lrg_decr_bits = 32; pcc->n_host_threads = 8; @@ -7941,6 +7943,7 @@ static bool ppc_pvr_match_power9(PowerPCCPUClass *pcc, uint32_t pvr) return false; } +#if defined(CONFIG_TCG) && !defined(CONFIG_USER_ONLY) static bool cpu_has_work_POWER9(CPUState *cs) { PowerPCCPU *cpu = POWERPC_CPU(cs); @@ -7998,12 +8001,12 @@ static bool cpu_has_work_POWER9(CPUState *cs) return msr_ee && (cs->interrupt_request & CPU_INTERRUPT_HARD); } } +#endif /* CONFIG_TCG && !CONFIG_USER_ONLY */ POWERPC_FAMILY(POWER9)(ObjectClass *oc, void *data) { DeviceClass *dc = DEVICE_CLASS(oc); PowerPCCPUClass *pcc = POWERPC_CPU_CLASS(oc); - CPUClass *cc = CPU_CLASS(oc); dc->fw_name = "PowerPC,POWER9"; dc->desc = "POWER9"; @@ -8013,7 +8016,6 @@ POWERPC_FAMILY(POWER9)(ObjectClass *oc, void *data) PCR_COMPAT_2_05; pcc->init_proc = init_proc_POWER9; pcc->check_pow = check_pow_nocheck; - cc->has_work = cpu_has_work_POWER9; pcc->insns_flags = PPC_INSNS_BASE | PPC_ISEL | PPC_STRING | PPC_MFTB | PPC_FLOAT | PPC_FLOAT_FSEL | PPC_FLOAT_FRES | PPC_FLOAT_FSQRT | PPC_FLOAT_FRSQRTE | @@ -8062,6 +8064,7 @@ POWERPC_FAMILY(POWER9)(ObjectClass *oc, void *data) pcc->lpcr_pm = LPCR_PDEE | LPCR_HDEE | LPCR_EEE | LPCR_DEE | LPCR_OEE; pcc->mmu_model = POWERPC_MMU_3_00; #if defined(CONFIG_SOFTMMU) + pcc->has_work = cpu_has_work_POWER9; /* segment page size remain the same */ pcc->hash64_opts = &ppc_hash64_opts_POWER7; pcc->radix_page_info = &POWER9_radix_page_info; @@ -8150,6 +8153,7 @@ static bool ppc_pvr_match_power10(PowerPCCPUClass *pcc, uint32_t pvr) return false; } +#if defined(CONFIG_TCG) && !defined(CONFIG_USER_ONLY) static bool cpu_has_work_POWER10(CPUState *cs) { PowerPCCPU *cpu = POWERPC_CPU(cs); @@ -8207,12 +8211,12 @@ static bool cpu_has_work_POWER10(CPUState *cs) return msr_ee && (cs->interrupt_request & CPU_INTERRUPT_HARD); } } +#endif /* CONFIG_TCG && !CONFIG_USER_ONLY */ POWERPC_FAMILY(POWER10)(ObjectClass *oc, void *data) { DeviceClass *dc = DEVICE_CLASS(oc); PowerPCCPUClass *pcc = POWERPC_CPU_CLASS(oc); - CPUClass *cc = CPU_CLASS(oc); dc->fw_name = "PowerPC,POWER10"; dc->desc = "POWER10"; @@ -8223,7 +8227,6 @@ POWERPC_FAMILY(POWER10)(ObjectClass *oc, void *data) PCR_COMPAT_2_06 | PCR_COMPAT_2_05; pcc->init_proc = init_proc_POWER10; pcc->check_pow = check_pow_nocheck; - cc->has_work = cpu_has_work_POWER10; pcc->insns_flags = PPC_INSNS_BASE | PPC_ISEL | PPC_STRING | PPC_MFTB | PPC_FLOAT | PPC_FLOAT_FSEL | PPC_FLOAT_FRES | PPC_FLOAT_FSQRT | PPC_FLOAT_FRSQRTE | @@ -8275,6 +8278,7 @@ POWERPC_FAMILY(POWER10)(ObjectClass *oc, void *data) pcc->lpcr_pm = LPCR_PDEE | LPCR_HDEE | LPCR_EEE | LPCR_DEE | LPCR_OEE; pcc->mmu_model = POWERPC_MMU_3_00; #if defined(CONFIG_SOFTMMU) + pcc->has_work = cpu_has_work_POWER10; /* segment page size remain the same */ pcc->hash64_opts = &ppc_hash64_opts_POWER7; pcc->radix_page_info = &POWER10_radix_page_info; @@ -8796,6 +8800,12 @@ static bool ppc_cpu_has_work(CPUState *cs) PowerPCCPU *cpu = POWERPC_CPU(cs); CPUPPCState *env = &cpu->env; + if (cs->halted) { + PowerPCCPUClass *pcc = POWERPC_CPU_GET_CLASS(cpu); + + return pcc->has_work(cs); + } + return msr_ee && (cs->interrupt_request & CPU_INTERRUPT_HARD); } #endif /* CONFIG_TCG && !CONFIG_USER_ONLY */ -- 2.31.1 From xen-devel-bounces@lists.xenproject.org Thu Sep 02 16:21:17 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 16:21:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177483.322942 (Exim 4.92) (envelope-from ) id 1mLpSd-0001VW-4J; Thu, 02 Sep 2021 16:21:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177483.322942; Thu, 02 Sep 2021 16:21:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLpSd-0001VP-10; Thu, 02 Sep 2021 16:21:07 +0000 Received: by outflank-mailman (input) for mailman id 177483; Thu, 02 Sep 2021 16:21:06 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLpOr-00029c-Q7 for xen-devel@lists.xenproject.org; Thu, 02 Sep 2021 16:17:13 +0000 Received: from mail-wr1-x42b.google.com (unknown [2a00:1450:4864:20::42b]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 283a0621-2f95-4c3c-af23-46744b554ad2; Thu, 02 Sep 2021 16:17:00 +0000 (UTC) Received: by mail-wr1-x42b.google.com with SMTP id n5so3807784wro.12 for ; Thu, 02 Sep 2021 09:17:00 -0700 (PDT) Received: from x1w.. (163.red-83-52-55.dynamicip.rima-tde.net. [83.52.55.163]) by smtp.gmail.com with ESMTPSA id m5sm2067398wmi.1.2021.09.02.09.16.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Sep 2021 09:16:59 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list X-Inumbo-ID: 283a0621-2f95-4c3c-af23-46744b554ad2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=FVQ82fA2n+2YkhWVmssVrmq1ZgiebK+OWD8XFPkR2KQ=; b=NTN9poXw36sIQz7tT1cMpoOOwTG/lxJCt9n/hIDHpJ5oAGalZwShWoEdYjhHzzlMVv 8/2soAA7WUYORMTBYBpUDtWNNxUFfDfUYJu04XkeEJLId1oUy0fpWdBO6D7Yyx1272JJ XKOsoC+njj5yavj0Qu1MgGlocXXaIcWXPI9T20BJ6avUCeJwQryVdBqiUkNfXQOnUX19 Ji1BNyPOvloHuZqi99dMvFNWYRhFh5wijABsraMfCS9+BoMw9K93KiX8s+h3u2DNCNBy aYF39Fl9JigWDlhE1ZATlIq1qqUJ331MkmIOX3TRyMSoprNUbK+LRaCdaECy2hoGa1sh /wYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=FVQ82fA2n+2YkhWVmssVrmq1ZgiebK+OWD8XFPkR2KQ=; b=EaR3Us1frMpyXK5YUIWCBwqN+h2rllF1ZkloKOyiioL9daJb+0jiPTmT+RZ98C+cVy vCUhNLaDqoLrZRzBHSR9TI+b3qIFgZ1glTk9BdJbbcMiaZPs2qK0BVRg4hiWVhA8tSMI IZxM3biBTLE0/iVuQoVCTMXvX7P3KmA5VaEYJpwZrIPG/+u24FA9vlIH5/rgfY3HpH6O FKrC2IbMTMnHjmLrH3Jzrbc0mSKS3drTbyE9S9UQDquZ55CHm6w4ZuxVbXc0fdjOHDpT RtWM4Mti/gOXKlkxsUMoqh13CIskX+2J1Cs2edqje7HM8/th0PPA6/TB0TZvn6dkNWZl 1raw== X-Gm-Message-State: AOAM532Drrfvanph0Cnwpn/RhVYIunmNqamzXYkFLb+Jt/0XvFnOJ4A8 0Qre1oKHg/Q7Yez1swhwtGU= X-Google-Smtp-Source: ABdhPJwPHE7SqMAg84hdLm/drHbhhc9Rf1ir7m9E7UwL/bm+2kZWpbUhpR7xKiGkP3mn69DCmtzK4A== X-Received: by 2002:adf:fd8c:: with SMTP id d12mr4712589wrr.21.1630599419723; Thu, 02 Sep 2021 09:16:59 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Bin Meng , Eduardo Habkost , Greg Kurz , haxm-team@intel.com, Kamil Rytarowski , qemu-ppc@nongnu.org, Anthony Perard , Marcel Apfelbaum , Michael Rolnik , qemu-riscv@nongnu.org, Paolo Bonzini , Jiaxun Yang , Thomas Huth , David Hildenbrand , Chris Wulff , Laurent Vivier , Cameron Esfahani , Sunil Muthuswamy , Max Filippov , Taylor Simpson , qemu-s390x@nongnu.org, Richard Henderson , Bastian Koppelmann , Yoshinori Sato , Artyom Tarasenko , Aurelien Jarno , Paul Durrant , Peter Maydell , David Gibson , Alistair Francis , "Edgar E. Iglesias" , Roman Bolshakov , Laurent Vivier , Cornelia Huck , qemu-arm@nongnu.org, Wenchao Wang , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , xen-devel@lists.xenproject.org, Marek Vasut , Stefano Stabellini , Aleksandar Rikalo , Mark Cave-Ayland , Colin Xu , Claudio Fontana , Palmer Dabbelt , Stafford Horne , Reinoud Zandijk , kvm@vger.kernel.org Subject: [PATCH v3 12/30] target/hexagon: Remove unused has_work() handler Date: Thu, 2 Sep 2021 18:15:25 +0200 Message-Id: <20210902161543.417092-13-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210902161543.417092-1-f4bug@amsat.org> References: <20210902161543.417092-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit has_work() is sysemu specific, and Hexagon target only provides a linux-user implementation. Remove the unused hexagon_cpu_has_work(). Signed-off-by: Philippe Mathieu-Daudé --- target/hexagon/cpu.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/target/hexagon/cpu.c b/target/hexagon/cpu.c index 3338365c16e..aa01974807c 100644 --- a/target/hexagon/cpu.c +++ b/target/hexagon/cpu.c @@ -189,11 +189,6 @@ static void hexagon_cpu_synchronize_from_tb(CPUState *cs, env->gpr[HEX_REG_PC] = tb->pc; } -static bool hexagon_cpu_has_work(CPUState *cs) -{ - return true; -} - void restore_state_to_opc(CPUHexagonState *env, TranslationBlock *tb, target_ulong *data) { @@ -287,7 +282,6 @@ static void hexagon_cpu_class_init(ObjectClass *c, void *data) device_class_set_parent_reset(dc, hexagon_cpu_reset, &mcc->parent_reset); cc->class_by_name = hexagon_cpu_class_by_name; - cc->has_work = hexagon_cpu_has_work; cc->dump_state = hexagon_dump_state; cc->set_pc = hexagon_cpu_set_pc; cc->gdb_read_register = hexagon_gdb_read_register; -- 2.31.1 From xen-devel-bounces@lists.xenproject.org Thu Sep 02 16:21:19 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 16:21:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177488.322964 (Exim 4.92) (envelope-from ) id 1mLpSp-0002FW-Rb; Thu, 02 Sep 2021 16:21:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177488.322964; Thu, 02 Sep 2021 16:21:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLpSp-0002FK-NU; Thu, 02 Sep 2021 16:21:19 +0000 Received: by outflank-mailman (input) for mailman id 177488; Thu, 02 Sep 2021 16:21:18 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLpPL-00029c-R8 for xen-devel@lists.xenproject.org; Thu, 02 Sep 2021 16:17:43 +0000 Received: from mail-wm1-x331.google.com (unknown [2a00:1450:4864:20::331]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id c3f37895-51ef-46b8-acb8-c1214b0ea298; Thu, 02 Sep 2021 16:17:36 +0000 (UTC) Received: by mail-wm1-x331.google.com with SMTP id k5-20020a05600c1c8500b002f76c42214bso1866332wms.3 for ; Thu, 02 Sep 2021 09:17:36 -0700 (PDT) Received: from x1w.. (163.red-83-52-55.dynamicip.rima-tde.net. [83.52.55.163]) by smtp.gmail.com with ESMTPSA id z17sm2350022wrh.66.2021.09.02.09.17.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Sep 2021 09:17:33 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list X-Inumbo-ID: c3f37895-51ef-46b8-acb8-c1214b0ea298 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=oNTRH1yoq5af/chfn9I/5bXkTQKwubTn8iozem9IGSY=; b=PGBnfVPTt2uYSxX6RQU1qsSKDWiS62QWAFvPTZETHVyL2OfFEKZZM3g5e9WJ1/HCKp vwU/HD/XAeJVS5v2+My/H3taQ/5KpM2mCEqjy9lZxh2Z/pp5+KxKPIJb09S1d7E1zVbI 3ZIcYz0tlufyP3eqE0RuxgxTothAxpq4vYSqZmx2K/VGuOwYk4ulhhYY34CvxwPWhOkc X6DZRjwitqLAQZOFu87Nxe9lRc1tqhLGZ8hROluYOSSfODd35hNP9l0+ra9n37CT0CeZ tWoQvZtrbSLJKAVJXRMVVda3fXJ9XRtlNf90jVOb68ZvlGwL1VX/T67Jlue0hgDZL0Fm SNZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=oNTRH1yoq5af/chfn9I/5bXkTQKwubTn8iozem9IGSY=; b=iLqjt21ztDRh0OBVs+zX7k+Y0OdTQBSlJb7FqStIUEE1gBcu1a35LnUZWcssJxVemE Uyxafnx9LPaRx7vnD2ZxTprJsQLUycrJ6XreT+gc/xWAaSVqsGRWdSaHHz8ez0gxj2n/ OLsJaZJe+gnan9DYU8shHiFY2wxYHla2jhUZHDTvfjRpx/qnyu1UALXqNbfayovI8I17 5nct1bF7hJWagw6hQw8i7vizDIZlv4kYVbC5h++QLiINBTcG7tMPKqlVLjlK+T3TGiV2 PAABtmx3NDP9O57iCoCds1XNoB5lqTODS6jjpGj+vcX8i3KnV/WdFdFSV+3ef9kKRs9T Um/A== X-Gm-Message-State: AOAM531rrL5wJ+lZJNtEAgYw6XXA5y45Lr74qcpXmavItwb6O+do7XfQ S9ZOY8LzqfVCfwTPacUcNw4= X-Google-Smtp-Source: ABdhPJxVc9r0FTKCTOqW8xIIldm9t05NRFuFTf+Kzcn3sLsTdbmtacHYR3pfbO5B7AXHWSOEzXQpFQ== X-Received: by 2002:a05:600c:19ca:: with SMTP id u10mr3821810wmq.178.1630599453691; Thu, 02 Sep 2021 09:17:33 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Bin Meng , Eduardo Habkost , Greg Kurz , haxm-team@intel.com, Kamil Rytarowski , qemu-ppc@nongnu.org, Anthony Perard , Marcel Apfelbaum , Michael Rolnik , qemu-riscv@nongnu.org, Paolo Bonzini , Jiaxun Yang , Thomas Huth , David Hildenbrand , Chris Wulff , Laurent Vivier , Cameron Esfahani , Sunil Muthuswamy , Max Filippov , Taylor Simpson , qemu-s390x@nongnu.org, Richard Henderson , Bastian Koppelmann , Yoshinori Sato , Artyom Tarasenko , Aurelien Jarno , Paul Durrant , Peter Maydell , David Gibson , Alistair Francis , "Edgar E. Iglesias" , Roman Bolshakov , Laurent Vivier , Cornelia Huck , qemu-arm@nongnu.org, Wenchao Wang , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , xen-devel@lists.xenproject.org, Marek Vasut , Stefano Stabellini , Aleksandar Rikalo , Mark Cave-Ayland , Colin Xu , Claudio Fontana , Palmer Dabbelt , Stafford Horne , Reinoud Zandijk , kvm@vger.kernel.org Subject: [PATCH v3 17/30] target/mips: Restrict has_work() handler to sysemu and TCG Date: Thu, 2 Sep 2021 18:15:30 +0200 Message-Id: <20210902161543.417092-18-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210902161543.417092-1-f4bug@amsat.org> References: <20210902161543.417092-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Restrict has_work() to TCG sysemu. Signed-off-by: Philippe Mathieu-Daudé --- target/mips/cpu.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/target/mips/cpu.c b/target/mips/cpu.c index 00e0c55d0e4..3639c03f8ea 100644 --- a/target/mips/cpu.c +++ b/target/mips/cpu.c @@ -128,6 +128,7 @@ static void mips_cpu_set_pc(CPUState *cs, vaddr value) mips_env_set_pc(&cpu->env, value); } +#if defined(CONFIG_TCG) && !defined(CONFIG_USER_ONLY) static bool mips_cpu_has_work(CPUState *cs) { MIPSCPU *cpu = MIPS_CPU(cs); @@ -172,6 +173,7 @@ static bool mips_cpu_has_work(CPUState *cs) } return has_work; } +#endif /* CONFIG_TCG && !CONFIG_USER_ONLY */ #include "cpu-defs.c.inc" @@ -542,6 +544,7 @@ static const struct TCGCPUOps mips_tcg_ops = { .tlb_fill = mips_cpu_tlb_fill, #if !defined(CONFIG_USER_ONLY) + .has_work = mips_cpu_has_work, .cpu_exec_interrupt = mips_cpu_exec_interrupt, .do_interrupt = mips_cpu_do_interrupt, .do_transaction_failed = mips_cpu_do_transaction_failed, @@ -563,7 +566,6 @@ static void mips_cpu_class_init(ObjectClass *c, void *data) device_class_set_props(dc, mips_cpu_properties); cc->class_by_name = mips_cpu_class_by_name; - cc->has_work = mips_cpu_has_work; cc->dump_state = mips_cpu_dump_state; cc->set_pc = mips_cpu_set_pc; cc->gdb_read_register = mips_cpu_gdb_read_register; -- 2.31.1 From xen-devel-bounces@lists.xenproject.org Thu Sep 02 16:21:26 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 16:21:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177492.322975 (Exim 4.92) (envelope-from ) id 1mLpSw-0002lE-7h; Thu, 02 Sep 2021 16:21:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177492.322975; Thu, 02 Sep 2021 16:21:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLpSw-0002kp-30; Thu, 02 Sep 2021 16:21:26 +0000 Received: by outflank-mailman (input) for mailman id 177492; Thu, 02 Sep 2021 16:21:24 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLpPV-00029c-RN for xen-devel@lists.xenproject.org; Thu, 02 Sep 2021 16:17:53 +0000 Received: from mail-wr1-x436.google.com (unknown [2a00:1450:4864:20::436]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 23c4919f-d8ba-48eb-ada9-6b5f71fd8ae6; Thu, 02 Sep 2021 16:17:49 +0000 (UTC) Received: by mail-wr1-x436.google.com with SMTP id u16so3843166wrn.5 for ; Thu, 02 Sep 2021 09:17:49 -0700 (PDT) Received: from x1w.. (163.red-83-52-55.dynamicip.rima-tde.net. [83.52.55.163]) by smtp.gmail.com with ESMTPSA id s15sm2202811wrb.22.2021.09.02.09.17.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Sep 2021 09:17:47 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list X-Inumbo-ID: 23c4919f-d8ba-48eb-ada9-6b5f71fd8ae6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=wiJyFwIKRQWjRkbu8SvGMr1PDMKMIYamMV7C3BB8oe8=; b=qAtoFIb8zeHmLJ+DXBMGpAdnbrphpEAfuI7XHEPw8NBmRW9/+WQnP+AZelTqnIhAyE XWWklQ0ZgUaW+TjGyBKgrmT5Awe/DhMqWt5iYbHcpZayB/1OpJXxLIVgIBvvvx9tbfbe MhBhX16/hQ/XQpM8/t7IWpZx8Wn0h5lsCbsMip4ljj1E3unFy90cJy4UzhkEFnhbknkU T8DR04fw7m7nWgaHWphfTdeObgKvp0ylXJqEGEN6mGrqmeM1GzS3/abyks0gzOofcGN7 UjU06l66Hvh9mNoLvBN0ewV7GlShfdvdFlG07p47BqES4xriMHGxYVH/Zf/4POrSSA9s 8XQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=wiJyFwIKRQWjRkbu8SvGMr1PDMKMIYamMV7C3BB8oe8=; b=TSgR5ffHhrhHIIW0U9o2qek/e8pXK11HMEHIRuYc4W2x67SZpZ2yWAfSR3x/RK4kZq EVglVcPm2RoTDG8nPxBCmtJAQ97MxJ0p2Uu/h3CDwC2bB/CkKMQScN+ZZFpyANFQOrG0 mv3xejdE1URVO+giLkNaLVPKYAn1wgg8D4pHv7afsN62HFb6fX8bpXfOc/5PWe00NX9y hGFFTF90NUaPC51XgEmGSYp85kZ/0y4pwjTRZFELtka6PbEgZWq538KBwHL61KvgQ2gg gRV47F8SbBmIAGZLbzICiSEfX0orQ4QB03b15ddOa91yLSPWFkbQ4TUby14jmO1moxZj KcDw== X-Gm-Message-State: AOAM533KiT6UL0hOmhezx0HibwF6YCmjW75ODLsITZNb/MlSL8JUWDys 2M9R03qcdJ4CUI/gmgzQeiw= X-Google-Smtp-Source: ABdhPJzK4QdOoxXsApVtGRumuSNyT10qkKd9QeSHbbUEQ3zItVBoCovI95FuxXm2STsnpfXGUzb9Vg== X-Received: by 2002:a5d:4ed0:: with SMTP id s16mr4776030wrv.71.1630599468354; Thu, 02 Sep 2021 09:17:48 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Bin Meng , Eduardo Habkost , Greg Kurz , haxm-team@intel.com, Kamil Rytarowski , qemu-ppc@nongnu.org, Anthony Perard , Marcel Apfelbaum , Michael Rolnik , qemu-riscv@nongnu.org, Paolo Bonzini , Jiaxun Yang , Thomas Huth , David Hildenbrand , Chris Wulff , Laurent Vivier , Cameron Esfahani , Sunil Muthuswamy , Max Filippov , Taylor Simpson , qemu-s390x@nongnu.org, Richard Henderson , Bastian Koppelmann , Yoshinori Sato , Artyom Tarasenko , Aurelien Jarno , Paul Durrant , Peter Maydell , David Gibson , Alistair Francis , "Edgar E. Iglesias" , Roman Bolshakov , Laurent Vivier , Cornelia Huck , qemu-arm@nongnu.org, Wenchao Wang , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , xen-devel@lists.xenproject.org, Marek Vasut , Stefano Stabellini , Aleksandar Rikalo , Mark Cave-Ayland , Colin Xu , Claudio Fontana , Palmer Dabbelt , Stafford Horne , Reinoud Zandijk , kvm@vger.kernel.org Subject: [PATCH v3 19/30] target/openrisc: Restrict has_work() handler to sysemu and TCG Date: Thu, 2 Sep 2021 18:15:32 +0200 Message-Id: <20210902161543.417092-20-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210902161543.417092-1-f4bug@amsat.org> References: <20210902161543.417092-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Restrict has_work() to TCG sysemu. Signed-off-by: Philippe Mathieu-Daudé --- target/openrisc/cpu.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/target/openrisc/cpu.c b/target/openrisc/cpu.c index 27cb04152f9..6544b549f12 100644 --- a/target/openrisc/cpu.c +++ b/target/openrisc/cpu.c @@ -30,11 +30,13 @@ static void openrisc_cpu_set_pc(CPUState *cs, vaddr value) cpu->env.dflag = 0; } +#if defined(CONFIG_TCG) && !defined(CONFIG_USER_ONLY) static bool openrisc_cpu_has_work(CPUState *cs) { return cs->interrupt_request & (CPU_INTERRUPT_HARD | CPU_INTERRUPT_TIMER); } +#endif /* CONFIG_TCG && !CONFIG_USER_ONLY */ static void openrisc_disas_set_info(CPUState *cpu, disassemble_info *info) { @@ -189,6 +191,7 @@ static const struct TCGCPUOps openrisc_tcg_ops = { .tlb_fill = openrisc_cpu_tlb_fill, #ifndef CONFIG_USER_ONLY + .has_work = openrisc_cpu_has_work, .cpu_exec_interrupt = openrisc_cpu_exec_interrupt, .do_interrupt = openrisc_cpu_do_interrupt, #endif /* !CONFIG_USER_ONLY */ @@ -205,7 +208,6 @@ static void openrisc_cpu_class_init(ObjectClass *oc, void *data) device_class_set_parent_reset(dc, openrisc_cpu_reset, &occ->parent_reset); cc->class_by_name = openrisc_cpu_class_by_name; - cc->has_work = openrisc_cpu_has_work; cc->dump_state = openrisc_cpu_dump_state; cc->set_pc = openrisc_cpu_set_pc; cc->gdb_read_register = openrisc_cpu_gdb_read_register; -- 2.31.1 From xen-devel-bounces@lists.xenproject.org Thu Sep 02 16:21:27 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 16:21:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177494.322985 (Exim 4.92) (envelope-from ) id 1mLpSx-00034U-IY; Thu, 02 Sep 2021 16:21:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177494.322985; Thu, 02 Sep 2021 16:21:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLpSx-000341-EA; Thu, 02 Sep 2021 16:21:27 +0000 Received: by outflank-mailman (input) for mailman id 177494; Thu, 02 Sep 2021 16:21:26 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLpP1-00029c-QJ for xen-devel@lists.xenproject.org; Thu, 02 Sep 2021 16:17:23 +0000 Received: from mail-wm1-x32e.google.com (unknown [2a00:1450:4864:20::32e]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 14cb6007-aed5-4a5e-98fd-b0c52838a1a8; Thu, 02 Sep 2021 16:17:16 +0000 (UTC) Received: by mail-wm1-x32e.google.com with SMTP id k20-20020a05600c0b5400b002e87ad6956eso1751511wmr.1 for ; Thu, 02 Sep 2021 09:17:16 -0700 (PDT) Received: from x1w.. (163.red-83-52-55.dynamicip.rima-tde.net. [83.52.55.163]) by smtp.gmail.com with ESMTPSA id c3sm2410025wrd.34.2021.09.02.09.17.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Sep 2021 09:17:11 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list X-Inumbo-ID: 14cb6007-aed5-4a5e-98fd-b0c52838a1a8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=k2G3IfvTSVM9dAo9x5r9x/QXUgni24b97nAmsANOOiA=; b=M+D+zo4/zdtMjYh01av69Zx4I3VwXPivjqKNQQ+G3Cy3iOhT3mTPvnPzXtpAFBC7IC bwDY97okiaHzzYZk/Nr+HJhmQWDbqsmtfcbNHfDxcB+wW5LVOcMLHk2ke6LUzT0b2vAG YqHMZm6pCnZF4sDmb5j0t8leoEPE4luIBbr+2Y/AHejZSaAIPRgw6F1l+RvTfdeQZQ/w KmEHFk+ys6eIeCl+10CsGxJv2WVk1ePshB2QpZEYQ9Rs3vY5QE1eYEOqT+aIoXIw8PR9 WNsdSSeclnt9XXMY/k06ObG6uMJqiNqm40/pEaPsmniXZMMe5CRy4fWye4vqLWV5kU8p n7eA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=k2G3IfvTSVM9dAo9x5r9x/QXUgni24b97nAmsANOOiA=; b=ijz/wdJlkLFKFaCvoEFxFooZHM2zLtUxuCHt2lROYqeORIhVonBTd0qcajoXv50lM3 jjcWcOHFS0R+zWlKbEbHRL0AWX1qFpv+4grQOf4XbUhxOShOKFbaQuhspQQXHuTeJj8M 8SNqDdgc1il6EOYehLaRkRQwy3hWGiorW3czkmcWqbq9EaIzKHggkMRYPH2BQ9xC7uh/ 8RxWx1Dc0B/0KGCNa9XKupfsInZwwKQpiftJ30Ia8qzjjMcRuwVXhr/phs2okAf2755L jht8aAvSUjK2Qc+DkCubPL3x486Ph0DF4Er+7QzlT/FfaL7GsoIwt2wg8myWJnusj9aw f47Q== X-Gm-Message-State: AOAM532utN0xyz6zq8QpT4AxXGsVsge9gIXOU2amkqBHs5sglX8X6GR5 5yqVyn16JULC7FKbKC2wuvA= X-Google-Smtp-Source: ABdhPJxFmnMfDsCiejdGeBE1y8KakVIkNHc7YRKHEHHLvGEXylx3fbGc1JSSwIBZyxQGjwxS5CvgPg== X-Received: by 2002:a05:600c:1d27:: with SMTP id l39mr3986130wms.146.1630599431932; Thu, 02 Sep 2021 09:17:11 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Bin Meng , Eduardo Habkost , Greg Kurz , haxm-team@intel.com, Kamil Rytarowski , qemu-ppc@nongnu.org, Anthony Perard , Marcel Apfelbaum , Michael Rolnik , qemu-riscv@nongnu.org, Paolo Bonzini , Jiaxun Yang , Thomas Huth , David Hildenbrand , Chris Wulff , Laurent Vivier , Cameron Esfahani , Sunil Muthuswamy , Max Filippov , Taylor Simpson , qemu-s390x@nongnu.org, Richard Henderson , Bastian Koppelmann , Yoshinori Sato , Artyom Tarasenko , Aurelien Jarno , Paul Durrant , Peter Maydell , David Gibson , Alistair Francis , "Edgar E. Iglesias" , Roman Bolshakov , Laurent Vivier , Cornelia Huck , qemu-arm@nongnu.org, Wenchao Wang , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , xen-devel@lists.xenproject.org, Marek Vasut , Stefano Stabellini , Aleksandar Rikalo , Mark Cave-Ayland , Colin Xu , Claudio Fontana , Palmer Dabbelt , Stafford Horne , Reinoud Zandijk , kvm@vger.kernel.org Subject: [PATCH v3 14/30] target/i386: Restrict has_work() handler to sysemu and TCG Date: Thu, 2 Sep 2021 18:15:27 +0200 Message-Id: <20210902161543.417092-15-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210902161543.417092-1-f4bug@amsat.org> References: <20210902161543.417092-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Restrict has_work() to TCG sysemu. Signed-off-by: Philippe Mathieu-Daudé --- target/i386/cpu.c | 6 ------ target/i386/tcg/tcg-cpu.c | 8 +++++++- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/target/i386/cpu.c b/target/i386/cpu.c index 04f59043804..b7417d29f44 100644 --- a/target/i386/cpu.c +++ b/target/i386/cpu.c @@ -6548,11 +6548,6 @@ int x86_cpu_pending_interrupt(CPUState *cs, int interrupt_request) return 0; } -static bool x86_cpu_has_work(CPUState *cs) -{ - return x86_cpu_pending_interrupt(cs, cs->interrupt_request) != 0; -} - static void x86_disas_set_info(CPUState *cs, disassemble_info *info) { X86CPU *cpu = X86_CPU(cs); @@ -6757,7 +6752,6 @@ static void x86_cpu_common_class_init(ObjectClass *oc, void *data) cc->class_by_name = x86_cpu_class_by_name; cc->parse_features = x86_cpu_parse_featurestr; - cc->has_work = x86_cpu_has_work; cc->dump_state = x86_cpu_dump_state; cc->set_pc = x86_cpu_set_pc; cc->gdb_read_register = x86_cpu_gdb_read_register; diff --git a/target/i386/tcg/tcg-cpu.c b/target/i386/tcg/tcg-cpu.c index fd86daf93d2..6cde53603ba 100644 --- a/target/i386/tcg/tcg-cpu.c +++ b/target/i386/tcg/tcg-cpu.c @@ -55,6 +55,11 @@ static void x86_cpu_synchronize_from_tb(CPUState *cs, } #ifndef CONFIG_USER_ONLY +static bool x86_cpu_has_work(CPUState *cs) +{ + return x86_cpu_pending_interrupt(cs, cs->interrupt_request) != 0; +} + static bool x86_debug_check_breakpoint(CPUState *cs) { X86CPU *cpu = X86_CPU(cs); @@ -63,7 +68,7 @@ static bool x86_debug_check_breakpoint(CPUState *cs) /* RF disables all architectural breakpoints. */ return !(env->eflags & RF_MASK); } -#endif +#endif /* CONFIG_USER_ONLY */ #include "hw/core/tcg-cpu-ops.h" @@ -76,6 +81,7 @@ static const struct TCGCPUOps x86_tcg_ops = { #ifdef CONFIG_USER_ONLY .fake_user_exception = x86_cpu_do_interrupt, #else + .has_work = x86_cpu_has_work, .do_interrupt = x86_cpu_do_interrupt, .cpu_exec_interrupt = x86_cpu_exec_interrupt, .debug_excp_handler = breakpoint_handler, -- 2.31.1 From xen-devel-bounces@lists.xenproject.org Thu Sep 02 16:21:33 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 16:21:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177497.322997 (Exim 4.92) (envelope-from ) id 1mLpT2-0003eh-SG; Thu, 02 Sep 2021 16:21:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177497.322997; Thu, 02 Sep 2021 16:21:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLpT2-0003eS-Ov; Thu, 02 Sep 2021 16:21:32 +0000 Received: by outflank-mailman (input) for mailman id 177497; Thu, 02 Sep 2021 16:21:31 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLpPa-00029c-Ra for xen-devel@lists.xenproject.org; Thu, 02 Sep 2021 16:17:58 +0000 Received: from mail-wm1-x32c.google.com (unknown [2a00:1450:4864:20::32c]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 59d35fc3-694e-4ea9-a48e-20ca3fdb9051; Thu, 02 Sep 2021 16:17:55 +0000 (UTC) Received: by mail-wm1-x32c.google.com with SMTP id l7-20020a1c2507000000b002e6be5d86b3so1747123wml.3 for ; Thu, 02 Sep 2021 09:17:55 -0700 (PDT) Received: from x1w.. (163.red-83-52-55.dynamicip.rima-tde.net. [83.52.55.163]) by smtp.gmail.com with ESMTPSA id f7sm2089431wmh.20.2021.09.02.09.17.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Sep 2021 09:17:53 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list X-Inumbo-ID: 59d35fc3-694e-4ea9-a48e-20ca3fdb9051 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=KB6w4zAa3ScKbWvcSeRs6nml5mmvjgABbPo/s2Hl9mE=; b=KudZd4akeMvkEQWUbX6szQOXRBHrwcFxsejJsDwXAwrTkhmJGlULM7aiBntpU6DlLD x1G792oH76CFsyLlbuYcUF0GY8rXRo+VR9Hu/GBgHJyiVzTP3OvIC53DxbyFxm7deDsy jywij08/HNg0mFST30fvOpvMZOkJgu6uZtVjcnTVWcKz4cejoxRKoHPRUUanT/GYimTW BuEEvjzL5rlc0uwntqWn8CT2tidHHSSa+1LvLL/36Uq3AShOfMPK6XKiF4/niGHWKMJq 4jkolFQjzFn6TC5LBuIhdKNpLtstdk7EfVBatQiEEjt66rdtDDU/Oqn47gGLe726oHXk a0tw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=KB6w4zAa3ScKbWvcSeRs6nml5mmvjgABbPo/s2Hl9mE=; b=S+ZBgS6+rjjUm7iKZGdfQttyEEVGsKTgcmP2G+1h5fdQB5HhKZfHB+j+3vV74V0vQk CvT3QJabTN8cQxBH6ON5N+1/PgJ9OKQSuHVUvGYkkUENfxm3VN/K7kbi/+q2xIEZh3O6 /AMbcrs1VvKnZbrhLrlMM21JMIZMu7/dzDJcC3Z0v3irj411l+WtgJCVstR87xn2sTnT 8JjisYxcBCIOy9wDWmygwTcLrEUYISYHyUidblw0b7Hpm9WVmjFuF2dChSrus8bWB3tA M0FeD6Su/CH89yvztpsIMcIn81BFMtfE8VTvzlHm4DHPpVvqPjXobS2adkGLM+XN8sfR oIjw== X-Gm-Message-State: AOAM530lRcx6VXovEkQJ9D9jhQBlfovd6E+E1Sa8FAGoYtk5SA2rQY0X vPfvzM14WeSknC2C5DXX0dE= X-Google-Smtp-Source: ABdhPJx3cFt1jrbYXnlPCjqrJf+8cwfXAXn4EeP6vsDC0dCbWo+FdkLPkzBtWW3nLTZkBTFw2ib2sw== X-Received: by 2002:a1c:ed10:: with SMTP id l16mr3994398wmh.8.1630599474350; Thu, 02 Sep 2021 09:17:54 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Bin Meng , Eduardo Habkost , Greg Kurz , haxm-team@intel.com, Kamil Rytarowski , qemu-ppc@nongnu.org, Anthony Perard , Marcel Apfelbaum , Michael Rolnik , qemu-riscv@nongnu.org, Paolo Bonzini , Jiaxun Yang , Thomas Huth , David Hildenbrand , Chris Wulff , Laurent Vivier , Cameron Esfahani , Sunil Muthuswamy , Max Filippov , Taylor Simpson , qemu-s390x@nongnu.org, Richard Henderson , Bastian Koppelmann , Yoshinori Sato , Artyom Tarasenko , Aurelien Jarno , Paul Durrant , Peter Maydell , David Gibson , Alistair Francis , "Edgar E. Iglesias" , Roman Bolshakov , Laurent Vivier , Cornelia Huck , qemu-arm@nongnu.org, Wenchao Wang , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , xen-devel@lists.xenproject.org, Marek Vasut , Stefano Stabellini , Aleksandar Rikalo , Mark Cave-Ayland , Colin Xu , Claudio Fontana , Palmer Dabbelt , Stafford Horne , Reinoud Zandijk , kvm@vger.kernel.org Subject: [PATCH v3 20/30] target/ppc: Restrict has_work() handler to sysemu and TCG Date: Thu, 2 Sep 2021 18:15:33 +0200 Message-Id: <20210902161543.417092-21-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210902161543.417092-1-f4bug@amsat.org> References: <20210902161543.417092-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Restrict has_work() to TCG sysemu. Signed-off-by: Philippe Mathieu-Daudé --- target/ppc/cpu_init.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/target/ppc/cpu_init.c b/target/ppc/cpu_init.c index 6aad01d1d3a..e2e721c2b81 100644 --- a/target/ppc/cpu_init.c +++ b/target/ppc/cpu_init.c @@ -8790,6 +8790,7 @@ static void ppc_cpu_set_pc(CPUState *cs, vaddr value) cpu->env.nip = value; } +#if defined(CONFIG_TCG) && !defined(CONFIG_USER_ONLY) static bool ppc_cpu_has_work(CPUState *cs) { PowerPCCPU *cpu = POWERPC_CPU(cs); @@ -8797,6 +8798,7 @@ static bool ppc_cpu_has_work(CPUState *cs) return msr_ee && (cs->interrupt_request & CPU_INTERRUPT_HARD); } +#endif /* CONFIG_TCG && !CONFIG_USER_ONLY */ static void ppc_cpu_reset(DeviceState *dev) { @@ -9017,6 +9019,7 @@ static const struct TCGCPUOps ppc_tcg_ops = { .tlb_fill = ppc_cpu_tlb_fill, #ifndef CONFIG_USER_ONLY + .has_work = ppc_cpu_has_work, .cpu_exec_interrupt = ppc_cpu_exec_interrupt, .do_interrupt = ppc_cpu_do_interrupt, .cpu_exec_enter = ppc_cpu_exec_enter, @@ -9042,7 +9045,6 @@ static void ppc_cpu_class_init(ObjectClass *oc, void *data) device_class_set_parent_reset(dc, ppc_cpu_reset, &pcc->parent_reset); cc->class_by_name = ppc_cpu_class_by_name; - cc->has_work = ppc_cpu_has_work; cc->dump_state = ppc_cpu_dump_state; cc->set_pc = ppc_cpu_set_pc; cc->gdb_read_register = ppc_cpu_gdb_read_register; -- 2.31.1 From xen-devel-bounces@lists.xenproject.org Thu Sep 02 16:21:46 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 16:21:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177513.323008 (Exim 4.92) (envelope-from ) id 1mLpTG-0004lg-5b; Thu, 02 Sep 2021 16:21:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177513.323008; Thu, 02 Sep 2021 16:21:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLpTG-0004lW-2J; Thu, 02 Sep 2021 16:21:46 +0000 Received: by outflank-mailman (input) for mailman id 177513; Thu, 02 Sep 2021 16:21:44 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLpOc-00029c-PS for xen-devel@lists.xenproject.org; Thu, 02 Sep 2021 16:16:58 +0000 Received: from mail-wm1-x334.google.com (unknown [2a00:1450:4864:20::334]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 3adcf5b9-68b6-4973-9aaf-67106bde2e85; Thu, 02 Sep 2021 16:16:48 +0000 (UTC) Received: by mail-wm1-x334.google.com with SMTP id v20-20020a1cf714000000b002e71f4d2026so1424714wmh.1 for ; Thu, 02 Sep 2021 09:16:48 -0700 (PDT) Received: from x1w.. (163.red-83-52-55.dynamicip.rima-tde.net. [83.52.55.163]) by smtp.gmail.com with ESMTPSA id y24sm2479386wma.9.2021.09.02.09.16.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Sep 2021 09:16:46 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list X-Inumbo-ID: 3adcf5b9-68b6-4973-9aaf-67106bde2e85 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=1uiIX4B4XnBDTSuiPfQ6TXqVM80IFaG7yss59sugPek=; b=KqzWIKJ7D2fRmpGndmFmFNuwslKTxikjGxDMGA2xsPlBUegPAHynuzDusdrr5XjA+x UCJbwBQeZPJQtXG0Xtu7RxwzPdlThK6RVv2DMQ/DDE16jxbu2MLTQ+EKf6s/CZXPXeN6 nzJIGn8UESvClj1N6xIA9j+rSpvqLJiMXVoYewPiMa355LZW9o2GW/afajWJc0/NEar0 Q8DpjYGYUJuF0UC+706nFPlDCV62j7IN2KHM9wzg02+ZUE7+nf9cE7ogevav/S8CwMh4 Jx4C3Bwaygo71B9Uga55OA34fqh3F6hfjdQCFZRtq0AWQ50+fnYTHxBfr074WpLdgF+1 YThQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=1uiIX4B4XnBDTSuiPfQ6TXqVM80IFaG7yss59sugPek=; b=OcR6OYbN3d3+2/g4T4hIfhIUOPuSgrlIYkvMrSCCKVcwHrOzkhyTj27/29v92exeyX 7JPELEhrW92u2JkyyYxEM+0T2A74FrU0I6kwO2v9goJHE4rl8EijW/t/W80Gz8+5ffe5 XL/6yRk1dxlLX8JjN6Hx2z3MVNokbW2k64OTHcgMfPOWhpGvBvjuTOOTEX+RJH0WRYER gFrToV5q5PaGzh7O7eQ6O/M8sjhff6HLSeyLgHLgDjajIsfVPS4/uGqZQu+6Jt8qfK0E b4L8hjAofmc4J7d5ie3NpV5R5y+1fFb4sG+0JxUDgGhwIVcqmWrP8HqKjIwYdf+HJ5ep K7vw== X-Gm-Message-State: AOAM530wdLK2ToSAzMr/x8CGIs4lvGpJNhADcJQV71/gfrit0Y9X73os IgPLuecZ3K8CHNnkONAn/jA= X-Google-Smtp-Source: ABdhPJw3pSsMq4kZKK4hbVaJZjnjyoQFK4vJQiZ4XHFwYg2jDsiLD33cM2YA1HEu8cnvL7L44Mu7XQ== X-Received: by 2002:a1c:44c5:: with SMTP id r188mr4089427wma.9.1630599407288; Thu, 02 Sep 2021 09:16:47 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Bin Meng , Eduardo Habkost , Greg Kurz , haxm-team@intel.com, Kamil Rytarowski , qemu-ppc@nongnu.org, Anthony Perard , Marcel Apfelbaum , Michael Rolnik , qemu-riscv@nongnu.org, Paolo Bonzini , Jiaxun Yang , Thomas Huth , David Hildenbrand , Chris Wulff , Laurent Vivier , Cameron Esfahani , Sunil Muthuswamy , Max Filippov , Taylor Simpson , qemu-s390x@nongnu.org, Richard Henderson , Bastian Koppelmann , Yoshinori Sato , Artyom Tarasenko , Aurelien Jarno , Paul Durrant , Peter Maydell , David Gibson , Alistair Francis , "Edgar E. Iglesias" , Roman Bolshakov , Laurent Vivier , Cornelia Huck , qemu-arm@nongnu.org, Wenchao Wang , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , xen-devel@lists.xenproject.org, Marek Vasut , Stefano Stabellini , Aleksandar Rikalo , Mark Cave-Ayland , Colin Xu , Claudio Fontana , Palmer Dabbelt , Stafford Horne , Reinoud Zandijk , kvm@vger.kernel.org Subject: [PATCH v3 10/30] target/avr: Restrict has_work() handler to sysemu and TCG Date: Thu, 2 Sep 2021 18:15:23 +0200 Message-Id: <20210902161543.417092-11-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210902161543.417092-1-f4bug@amsat.org> References: <20210902161543.417092-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Restrict has_work() to TCG sysemu. Signed-off-by: Philippe Mathieu-Daudé --- target/avr/cpu.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/target/avr/cpu.c b/target/avr/cpu.c index e9fa54c9777..6267cc6d530 100644 --- a/target/avr/cpu.c +++ b/target/avr/cpu.c @@ -32,6 +32,7 @@ static void avr_cpu_set_pc(CPUState *cs, vaddr value) cpu->env.pc_w = value / 2; /* internally PC points to words */ } +#if defined(CONFIG_TCG) && !defined(CONFIG_USER_ONLY) static bool avr_cpu_has_work(CPUState *cs) { AVRCPU *cpu = AVR_CPU(cs); @@ -40,6 +41,7 @@ static bool avr_cpu_has_work(CPUState *cs) return (cs->interrupt_request & (CPU_INTERRUPT_HARD | CPU_INTERRUPT_RESET)) && cpu_interrupts_enabled(env); } +#endif /* CONFIG_TCG && !CONFIG_USER_ONLY */ static void avr_cpu_synchronize_from_tb(CPUState *cs, const TranslationBlock *tb) @@ -198,6 +200,7 @@ static const struct TCGCPUOps avr_tcg_ops = { .tlb_fill = avr_cpu_tlb_fill, #ifndef CONFIG_USER_ONLY + .has_work = avr_cpu_has_work, .cpu_exec_interrupt = avr_cpu_exec_interrupt, .do_interrupt = avr_cpu_do_interrupt, #endif /* !CONFIG_USER_ONLY */ @@ -214,7 +217,6 @@ static void avr_cpu_class_init(ObjectClass *oc, void *data) cc->class_by_name = avr_cpu_class_by_name; - cc->has_work = avr_cpu_has_work; cc->dump_state = avr_cpu_dump_state; cc->set_pc = avr_cpu_set_pc; cc->memory_rw_debug = avr_cpu_memory_rw_debug; -- 2.31.1 From xen-devel-bounces@lists.xenproject.org Thu Sep 02 16:21:47 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 16:21:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177515.323017 (Exim 4.92) (envelope-from ) id 1mLpTH-0004vN-0Y; Thu, 02 Sep 2021 16:21:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177515.323017; Thu, 02 Sep 2021 16:21:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLpTG-0004s5-Kd; Thu, 02 Sep 2021 16:21:46 +0000 Received: by outflank-mailman (input) for mailman id 177515; Thu, 02 Sep 2021 16:21:45 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLpOw-00029c-Q6 for xen-devel@lists.xenproject.org; Thu, 02 Sep 2021 16:17:18 +0000 Received: from mail-wr1-x430.google.com (unknown [2a00:1450:4864:20::430]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id c8146775-0b3e-4bd6-a71e-55562e409a43; Thu, 02 Sep 2021 16:17:06 +0000 (UTC) Received: by mail-wr1-x430.google.com with SMTP id i6so3844396wrv.2 for ; Thu, 02 Sep 2021 09:17:06 -0700 (PDT) Received: from x1w.. (163.red-83-52-55.dynamicip.rima-tde.net. [83.52.55.163]) by smtp.gmail.com with ESMTPSA id y4sm2068566wmi.22.2021.09.02.09.17.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Sep 2021 09:17:05 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list X-Inumbo-ID: c8146775-0b3e-4bd6-a71e-55562e409a43 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Pk3U565FofhMNBdH085OA9aU3aTnCsU54QbFBxwfMI8=; b=NaB65rpK4UK7+XbBO28oZxFusXeQWuGTndzQkKqs4x497OOBypBPU5uctaWGbkSibX gbzbf0uKBllL7IMK9jeerTaWXdNmmwfHar32fZ/NCC0Cj626RXCkU3d8hlfsPo25otel OL/nvXSML0UuV9hTKCtQARxXaxraFStiKn4xGZp+OALpmFXy+6sqXkWFwBJFR6EcXMpL +gEhWt3eW2TEXJjoPvyiNmFQPJOj0yOdhR7ZZu+zEVqND+25gS72HJlWm9AWHklxn9DD TkIjI2aJpOFpKyf44h+zUsWbE/UTizlwAkVSUgam/bJtjGLksKc8rvZbllkWj5mw988x UXUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=Pk3U565FofhMNBdH085OA9aU3aTnCsU54QbFBxwfMI8=; b=MCyUV1oJcs5VGlyrKB6nHbQvPEcHLbkgS6FqfKTM07X9tN4LRSXo2L7t/6v08mYZUM 1zA3wZtlulY5SkwR0bi8iBprxvHtzCEi0PwG3BKJX2isXumCYXpLXFL7pF3riq7jqxCR 7qe8KB9hfcRi69cKyNWYwiz/99jRvXFqvQP78lBKIBkx4oOI/7f9NlGF/jWfHmMtvGTO sFaVIuKwFYythL74Csn0M9z8tdnmVJ9vEKp0zXgrxX9AcGBB0fl/2T66IJVyYlzP0Sox bbzAL8tWjKaRifdEK5Xci94JZBU3EN3XMfV8JGQLiJhLh/QYWzbH1yamHuGlKK8feF3R QomA== X-Gm-Message-State: AOAM530gW0JLHBVyXLlcCjTOjML/xnUvFW8hfrITgPcLZzNxU2WxL6vb /UggOvOqfQ3++rdP8zQTt+E= X-Google-Smtp-Source: ABdhPJxJ0WzmriUMp5BLtv/IKodEKm5HtzrJCRMHsGjbOs/WMzY0lZa1I+orMo+J9P/Vgaj+G+An4w== X-Received: by 2002:adf:f991:: with SMTP id f17mr4751225wrr.56.1630599425756; Thu, 02 Sep 2021 09:17:05 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Bin Meng , Eduardo Habkost , Greg Kurz , haxm-team@intel.com, Kamil Rytarowski , qemu-ppc@nongnu.org, Anthony Perard , Marcel Apfelbaum , Michael Rolnik , qemu-riscv@nongnu.org, Paolo Bonzini , Jiaxun Yang , Thomas Huth , David Hildenbrand , Chris Wulff , Laurent Vivier , Cameron Esfahani , Sunil Muthuswamy , Max Filippov , Taylor Simpson , qemu-s390x@nongnu.org, Richard Henderson , Bastian Koppelmann , Yoshinori Sato , Artyom Tarasenko , Aurelien Jarno , Paul Durrant , Peter Maydell , David Gibson , Alistair Francis , "Edgar E. Iglesias" , Roman Bolshakov , Laurent Vivier , Cornelia Huck , qemu-arm@nongnu.org, Wenchao Wang , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , xen-devel@lists.xenproject.org, Marek Vasut , Stefano Stabellini , Aleksandar Rikalo , Mark Cave-Ayland , Colin Xu , Claudio Fontana , Palmer Dabbelt , Stafford Horne , Reinoud Zandijk , kvm@vger.kernel.org Subject: [PATCH v3 13/30] target/hppa: Restrict has_work() handler to sysemu and TCG Date: Thu, 2 Sep 2021 18:15:26 +0200 Message-Id: <20210902161543.417092-14-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210902161543.417092-1-f4bug@amsat.org> References: <20210902161543.417092-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Restrict has_work() to TCG sysemu. Signed-off-by: Philippe Mathieu-Daudé --- target/hppa/cpu.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/target/hppa/cpu.c b/target/hppa/cpu.c index e8edd189bfc..cf1f656218f 100644 --- a/target/hppa/cpu.c +++ b/target/hppa/cpu.c @@ -60,10 +60,12 @@ static void hppa_cpu_synchronize_from_tb(CPUState *cs, cpu->env.psw_n = (tb->flags & PSW_N) != 0; } +#if defined(CONFIG_TCG) && !defined(CONFIG_USER_ONLY) static bool hppa_cpu_has_work(CPUState *cs) { return cs->interrupt_request & CPU_INTERRUPT_HARD; } +#endif /* CONFIG_TCG && !CONFIG_USER_ONLY */ static void hppa_cpu_disas_set_info(CPUState *cs, disassemble_info *info) { @@ -147,6 +149,7 @@ static const struct TCGCPUOps hppa_tcg_ops = { .tlb_fill = hppa_cpu_tlb_fill, #ifndef CONFIG_USER_ONLY + .has_work = hppa_cpu_has_work, .cpu_exec_interrupt = hppa_cpu_exec_interrupt, .do_interrupt = hppa_cpu_do_interrupt, .do_unaligned_access = hppa_cpu_do_unaligned_access, @@ -163,7 +166,6 @@ static void hppa_cpu_class_init(ObjectClass *oc, void *data) &acc->parent_realize); cc->class_by_name = hppa_cpu_class_by_name; - cc->has_work = hppa_cpu_has_work; cc->dump_state = hppa_cpu_dump_state; cc->set_pc = hppa_cpu_set_pc; cc->gdb_read_register = hppa_cpu_gdb_read_register; -- 2.31.1 From xen-devel-bounces@lists.xenproject.org Thu Sep 02 16:21:48 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 16:21:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177516.323029 (Exim 4.92) (envelope-from ) id 1mLpTI-0005MF-63; Thu, 02 Sep 2021 16:21:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177516.323029; Thu, 02 Sep 2021 16:21:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLpTI-0005M0-19; Thu, 02 Sep 2021 16:21:48 +0000 Received: by outflank-mailman (input) for mailman id 177516; Thu, 02 Sep 2021 16:21:46 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLpOh-00029c-Pg for xen-devel@lists.xenproject.org; Thu, 02 Sep 2021 16:17:03 +0000 Received: from mail-wr1-x434.google.com (unknown [2a00:1450:4864:20::434]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 883c0791-ab03-401b-9eb3-be2241ff3bec; Thu, 02 Sep 2021 16:16:54 +0000 (UTC) Received: by mail-wr1-x434.google.com with SMTP id v10so3835568wrd.4 for ; Thu, 02 Sep 2021 09:16:54 -0700 (PDT) Received: from x1w.. (163.red-83-52-55.dynamicip.rima-tde.net. [83.52.55.163]) by smtp.gmail.com with ESMTPSA id l35sm1840348wms.40.2021.09.02.09.16.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Sep 2021 09:16:52 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list X-Inumbo-ID: 883c0791-ab03-401b-9eb3-be2241ff3bec DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ealGhID5/ZwlyOxoKUyhT8abP5eBfK+uMSNnBQgE1TY=; b=W7wWIRu899u62PiYNAofijA+z0Fl13DLdrj//JnOtB9nuav7HgFA25Nkb7zPP9qx0q V+T6UyuHV8lfYhIsfl6T3reP8G73iXnJAJA0ZI5pdqQK3b2QENsciaKQFL/VhPrWDk3o V9xTH3D7YAWgG+OE8yKD9gO/syxb0LKTwtCgItyeMl0A+kX7M5ZtD+Rg6R+o7Cnq1P8l 69E8lhjYEQcYXk+iNCzjjt0R2+v6w/ULq5UCkJupima5EWr+YrbDz2jjvylypCOx3Xrd ioW7y8oVW/o1/Fd4QRhzX/tp9G+m2C+2tAs7vFR9FJH4g8+0Rq+iX11ED1zseb/+uUtD FA2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=ealGhID5/ZwlyOxoKUyhT8abP5eBfK+uMSNnBQgE1TY=; b=sdqiUu04J8O++JRqkvbqba+MFb5mXzFJUvwx7Yjw2LPEU/mBmB4QCTy5tpYQZTGr5h z3o4cUEFHl56rSKVzxPW80yiS83nRqpDV6J6NgJm3cKAhXh9M76GE6wkQqeaF9XUUM0V P3roardmwRDG+4ccztiKiu5zkp6jigyMBK7mh3xdCiuZ3pD4QtNoiNrHeY5LcJwM8nBw ExFM244J8mbjmXBhXGv+AvHPmRPcRlmLqoNVvjzI017D3wFnIZNe9kZbzf6KgtxM1prE AVkcvkTik8axI+iNci3QtK4VWrGjGAS0BZnHkNqkPKodYNEuaXH+U1xmVW3HgYuo2tPi 0I3w== X-Gm-Message-State: AOAM532TD803QR+83lQ51rGFrC6Wm2eGNV2BkK5aa/sAmeFG80Z45fzZ F+J/sL1sXGupcd8bBlxjhJg= X-Google-Smtp-Source: ABdhPJw8/hywRF+QG+EoxPvaacbpI8TbV6wFHFx7ujXzHTlr6qNAq926vGsYV8Cac2S8ECAaju7k7A== X-Received: by 2002:adf:916f:: with SMTP id j102mr4715417wrj.422.1630599413462; Thu, 02 Sep 2021 09:16:53 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Bin Meng , Eduardo Habkost , Greg Kurz , haxm-team@intel.com, Kamil Rytarowski , qemu-ppc@nongnu.org, Anthony Perard , Marcel Apfelbaum , Michael Rolnik , qemu-riscv@nongnu.org, Paolo Bonzini , Jiaxun Yang , Thomas Huth , David Hildenbrand , Chris Wulff , Laurent Vivier , Cameron Esfahani , Sunil Muthuswamy , Max Filippov , Taylor Simpson , qemu-s390x@nongnu.org, Richard Henderson , Bastian Koppelmann , Yoshinori Sato , Artyom Tarasenko , Aurelien Jarno , Paul Durrant , Peter Maydell , David Gibson , Alistair Francis , "Edgar E. Iglesias" , Roman Bolshakov , Laurent Vivier , Cornelia Huck , qemu-arm@nongnu.org, Wenchao Wang , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , xen-devel@lists.xenproject.org, Marek Vasut , Stefano Stabellini , Aleksandar Rikalo , Mark Cave-Ayland , Colin Xu , Claudio Fontana , Palmer Dabbelt , Stafford Horne , Reinoud Zandijk , kvm@vger.kernel.org Subject: [PATCH v3 11/30] target/cris: Restrict has_work() handler to sysemu and TCG Date: Thu, 2 Sep 2021 18:15:24 +0200 Message-Id: <20210902161543.417092-12-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210902161543.417092-1-f4bug@amsat.org> References: <20210902161543.417092-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Restrict has_work() to TCG sysemu. Signed-off-by: Philippe Mathieu-Daudé --- target/cris/cpu.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/target/cris/cpu.c b/target/cris/cpu.c index c2e7483f5bd..d6e486746be 100644 --- a/target/cris/cpu.c +++ b/target/cris/cpu.c @@ -35,10 +35,12 @@ static void cris_cpu_set_pc(CPUState *cs, vaddr value) cpu->env.pc = value; } +#if defined(CONFIG_TCG) && !defined(CONFIG_USER_ONLY) static bool cris_cpu_has_work(CPUState *cs) { return cs->interrupt_request & (CPU_INTERRUPT_HARD | CPU_INTERRUPT_NMI); } +#endif /* CONFIG_TCG && !CONFIG_USER_ONLY */ static void cris_cpu_reset(DeviceState *dev) { @@ -208,6 +210,7 @@ static const struct TCGCPUOps crisv10_tcg_ops = { .tlb_fill = cris_cpu_tlb_fill, #ifndef CONFIG_USER_ONLY + .has_work = cris_cpu_has_work, .cpu_exec_interrupt = cris_cpu_exec_interrupt, .do_interrupt = crisv10_cpu_do_interrupt, #endif /* !CONFIG_USER_ONLY */ @@ -294,7 +297,6 @@ static void cris_cpu_class_init(ObjectClass *oc, void *data) device_class_set_parent_reset(dc, cris_cpu_reset, &ccc->parent_reset); cc->class_by_name = cris_cpu_class_by_name; - cc->has_work = cris_cpu_has_work; cc->dump_state = cris_cpu_dump_state; cc->set_pc = cris_cpu_set_pc; cc->gdb_read_register = cris_cpu_gdb_read_register; -- 2.31.1 From xen-devel-bounces@lists.xenproject.org Thu Sep 02 16:21:52 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 16:21:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177521.323040 (Exim 4.92) (envelope-from ) id 1mLpTM-0005v4-KJ; Thu, 02 Sep 2021 16:21:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177521.323040; Thu, 02 Sep 2021 16:21:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLpTM-0005um-F1; Thu, 02 Sep 2021 16:21:52 +0000 Received: by outflank-mailman (input) for mailman id 177521; Thu, 02 Sep 2021 16:21:51 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLpPG-00029c-R3 for xen-devel@lists.xenproject.org; Thu, 02 Sep 2021 16:17:38 +0000 Received: from mail-wm1-x329.google.com (unknown [2a00:1450:4864:20::329]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 50d9668c-5273-4f42-b2c0-07276964ddd5; Thu, 02 Sep 2021 16:17:28 +0000 (UTC) Received: by mail-wm1-x329.google.com with SMTP id m25-20020a7bcb99000000b002e751bcb5dbso1734355wmi.5 for ; Thu, 02 Sep 2021 09:17:28 -0700 (PDT) Received: from x1w.. (163.red-83-52-55.dynamicip.rima-tde.net. [83.52.55.163]) by smtp.gmail.com with ESMTPSA id f18sm2080257wmc.6.2021.09.02.09.17.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Sep 2021 09:17:26 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list X-Inumbo-ID: 50d9668c-5273-4f42-b2c0-07276964ddd5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=DdBo63POokH5fIMDIDGd3vZfaCJQwybOZKNS3BGh4nM=; b=SdUILgJd3l3KkosL5d+GJCCbjxa1kuvIi2eQH+QhbRZsxGZZeyT8B45EfAvb4vDqID Hvz12f+uLhG2sxeYjZh1eHobRoGFGmx8Vwc0IlXnnkf2IX5bx+BVhSr1cY3Ej8rlB7KC YO8ak4ncoqL6BecyY/e6YiTBs4ooYjlzwmmJGuU0TYXlpRik+gmohfcoQGfINeBVNh7H gfydQO5CesTCgYv9jzBSAmfhKaEn9YTmVKuXA9R7D2QLLI+i2p5DKESCrSigkULnbdYP q+rTwC0UOLH6fDszBS6ixFPljdENz9/dOQt5v2rlttm82OpvBLF+yYDt5s7Pj/jtLcYS Xgng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=DdBo63POokH5fIMDIDGd3vZfaCJQwybOZKNS3BGh4nM=; b=gscGy/7Izd5tcvChASYjY3Xc46zWncdfnQm4CzL2WrMP8G6U3kt8LJU1buyb08D0Au o8ydrhFGgwqZD86ffkp3iiDYfsplKbZ08Kwz7RhnwlBHn9meO0G972QB2nfY7coC5RIV aBjm1fn1pjlNQXEEFa+RKEzVVplsquUMFITBrqZWqSNpAI2PnMQZkw1vofyv6AP2fmp6 qmA8YEtTIIx2SwFiNT7FPpHBRXokMh4MlPMkZwxIfoHt+dEpe9Jv0Pn1647pAB/FRsUn PlJQGgiFBIi54r4ilFGJ/xa35iETfHoG6TyUrp9f0pnb8JoENVtmF+VzrCSZztxkZZyd DayQ== X-Gm-Message-State: AOAM533+JKAYooPg94eIiSAwa4nfsMEvvY9UbxGn7aKmYtLGHeECTnhx Mj/qOOr1U9TzLJUtnmr8E+0= X-Google-Smtp-Source: ABdhPJxeXOWsxsq5sHAGX+bjrNwp1kbgUUARJY9Fvv8rdRD0ZNZFO5Z6zZ0qv0LrIPXbrhuPF3RRHw== X-Received: by 2002:a1c:a50c:: with SMTP id o12mr4082621wme.4.1630599447661; Thu, 02 Sep 2021 09:17:27 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Bin Meng , Eduardo Habkost , Greg Kurz , haxm-team@intel.com, Kamil Rytarowski , qemu-ppc@nongnu.org, Anthony Perard , Marcel Apfelbaum , Michael Rolnik , qemu-riscv@nongnu.org, Paolo Bonzini , Jiaxun Yang , Thomas Huth , David Hildenbrand , Chris Wulff , Laurent Vivier , Cameron Esfahani , Sunil Muthuswamy , Max Filippov , Taylor Simpson , qemu-s390x@nongnu.org, Richard Henderson , Bastian Koppelmann , Yoshinori Sato , Artyom Tarasenko , Aurelien Jarno , Paul Durrant , Peter Maydell , David Gibson , Alistair Francis , "Edgar E. Iglesias" , Roman Bolshakov , Laurent Vivier , Cornelia Huck , qemu-arm@nongnu.org, Wenchao Wang , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , xen-devel@lists.xenproject.org, Marek Vasut , Stefano Stabellini , Aleksandar Rikalo , Mark Cave-Ayland , Colin Xu , Claudio Fontana , Palmer Dabbelt , Stafford Horne , Reinoud Zandijk , kvm@vger.kernel.org Subject: [PATCH v3 16/30] target/microblaze: Restrict has_work() handler to sysemu and TCG Date: Thu, 2 Sep 2021 18:15:29 +0200 Message-Id: <20210902161543.417092-17-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210902161543.417092-1-f4bug@amsat.org> References: <20210902161543.417092-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Restrict has_work() to TCG sysemu. Signed-off-by: Philippe Mathieu-Daudé --- target/microblaze/cpu.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/target/microblaze/cpu.c b/target/microblaze/cpu.c index 15db277925f..74fbb5d201a 100644 --- a/target/microblaze/cpu.c +++ b/target/microblaze/cpu.c @@ -92,12 +92,15 @@ static void mb_cpu_synchronize_from_tb(CPUState *cs, cpu->env.iflags = tb->flags & IFLAGS_TB_MASK; } +#ifndef CONFIG_USER_ONLY + +#ifdef CONFIG_TCG static bool mb_cpu_has_work(CPUState *cs) { return cs->interrupt_request & (CPU_INTERRUPT_HARD | CPU_INTERRUPT_NMI); } +#endif /* CONFIG_TCG */ -#ifndef CONFIG_USER_ONLY static void mb_cpu_ns_axi_dp(void *opaque, int irq, int level) { MicroBlazeCPU *cpu = opaque; @@ -142,7 +145,7 @@ static void microblaze_cpu_set_irq(void *opaque, int irq, int level) cpu_reset_interrupt(cs, type); } } -#endif +#endif /* !CONFIG_USER_ONLY */ static void mb_cpu_reset(DeviceState *dev) { @@ -368,6 +371,7 @@ static const struct TCGCPUOps mb_tcg_ops = { .tlb_fill = mb_cpu_tlb_fill, #ifndef CONFIG_USER_ONLY + .has_work = mb_cpu_has_work, .cpu_exec_interrupt = mb_cpu_exec_interrupt, .do_interrupt = mb_cpu_do_interrupt, .do_transaction_failed = mb_cpu_transaction_failed, @@ -386,8 +390,6 @@ static void mb_cpu_class_init(ObjectClass *oc, void *data) device_class_set_parent_reset(dc, mb_cpu_reset, &mcc->parent_reset); cc->class_by_name = mb_cpu_class_by_name; - cc->has_work = mb_cpu_has_work; - cc->dump_state = mb_cpu_dump_state; cc->set_pc = mb_cpu_set_pc; cc->gdb_read_register = mb_cpu_gdb_read_register; -- 2.31.1 From xen-devel-bounces@lists.xenproject.org Thu Sep 02 16:21:54 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 16:21:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177522.323051 (Exim 4.92) (envelope-from ) id 1mLpTN-0006EG-Uq; Thu, 02 Sep 2021 16:21:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177522.323051; Thu, 02 Sep 2021 16:21:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLpTN-0006Di-QM; Thu, 02 Sep 2021 16:21:53 +0000 Received: by outflank-mailman (input) for mailman id 177522; Thu, 02 Sep 2021 16:21:52 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLpPQ-00029c-RL for xen-devel@lists.xenproject.org; Thu, 02 Sep 2021 16:17:48 +0000 Received: from mail-wm1-x330.google.com (unknown [2a00:1450:4864:20::330]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 35337728-37d5-4f15-99e8-bf5d5c0bc7c4; Thu, 02 Sep 2021 16:17:42 +0000 (UTC) Received: by mail-wm1-x330.google.com with SMTP id k20-20020a05600c0b5400b002e87ad6956eso1752432wmr.1 for ; Thu, 02 Sep 2021 09:17:42 -0700 (PDT) Received: from x1w.. (163.red-83-52-55.dynamicip.rima-tde.net. [83.52.55.163]) by smtp.gmail.com with ESMTPSA id b10sm2396452wrt.43.2021.09.02.09.17.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Sep 2021 09:17:41 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list X-Inumbo-ID: 35337728-37d5-4f15-99e8-bf5d5c0bc7c4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=zZDEgfpsGMQvs/Uf9L14U8iNfhU1RYAtDHEnPo7PYYM=; b=GULtcfLvxCYjpD88B1lNFiQq0+Fx5WhxaqykU8SQ2CHcFSQ46Oe+PaWfXkceFQ4mZo 9SVUhNZ9o3T9wPipJYMj4yipSNtMQdK9k6FheUrkcj3bklOdIm+96woKK1z756yLjsg/ MhcJnDjB6bDPTEVYbHN4OuhakMfbQHLPwIuQo7fhJI4LnxL+hhUixbbozhsjDk51Ju96 gEVW+K7GtzvK1ZSbUGOUZzNQwoBSJHeiBUhu/bkunqvaYTW0krBKCnLFihT41xPY7/te UIojuKoYb6sy0krnR6uivIpg05XXUq83++TFLX9QNOJMrVv7jBEaRQx/6ic9TCOEtLyT HNGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=zZDEgfpsGMQvs/Uf9L14U8iNfhU1RYAtDHEnPo7PYYM=; b=s/ZlfdL2kPbg27cSacwE2l9+XTd6UgsmCFwLHqX5ZQEBOyLQZ/ih5yVl8LVtOJPBgY pHw6FDTkAyjPcQeCQcbneLIoxnPrTBswd8JJCWURFMLaFpQKDMlyE4lH6g9okWwlhge1 PK/9qqBIjHm70UUj8XTCI0Tll+XqFWPHLUonS2d2vGfK9Jh9GR0V6OhPtHSnc2kVYGk4 ouke6U000KZXsX9cDfD4101o8PlkaBRky+ahJZHOdB53WctZWPGLQIMJHADQtoVqPV0L ZC8iZdviq7Rhk1FxI+1BduhFztCxVXKGcWBeN8Nm7JcxgMieyL4ENl0N0dLivNDXWFjV oS9A== X-Gm-Message-State: AOAM532+81vKHQ8Y6U/8zPktKodLsiFSkERZsoIO4SC4OfAr9ikDjtKG oJlLu2QMYb9U2hSSP+Eps1s= X-Google-Smtp-Source: ABdhPJyVfC2B9mnkyBEM+dhp2QSoSDx2mJAJ4q0c4MKaFScZUxxMUDRDRaRsAykGgf3YQuNS/WTfdA== X-Received: by 2002:a05:600c:3641:: with SMTP id y1mr3991806wmq.181.1630599461974; Thu, 02 Sep 2021 09:17:41 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Bin Meng , Eduardo Habkost , Greg Kurz , haxm-team@intel.com, Kamil Rytarowski , qemu-ppc@nongnu.org, Anthony Perard , Marcel Apfelbaum , Michael Rolnik , qemu-riscv@nongnu.org, Paolo Bonzini , Jiaxun Yang , Thomas Huth , David Hildenbrand , Chris Wulff , Laurent Vivier , Cameron Esfahani , Sunil Muthuswamy , Max Filippov , Taylor Simpson , qemu-s390x@nongnu.org, Richard Henderson , Bastian Koppelmann , Yoshinori Sato , Artyom Tarasenko , Aurelien Jarno , Paul Durrant , Peter Maydell , David Gibson , Alistair Francis , "Edgar E. Iglesias" , Roman Bolshakov , Laurent Vivier , Cornelia Huck , qemu-arm@nongnu.org, Wenchao Wang , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , xen-devel@lists.xenproject.org, Marek Vasut , Stefano Stabellini , Aleksandar Rikalo , Mark Cave-Ayland , Colin Xu , Claudio Fontana , Palmer Dabbelt , Stafford Horne , Reinoud Zandijk , kvm@vger.kernel.org Subject: [PATCH v3 18/30] target/nios2: Restrict has_work() handler to sysemu and TCG Date: Thu, 2 Sep 2021 18:15:31 +0200 Message-Id: <20210902161543.417092-19-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210902161543.417092-1-f4bug@amsat.org> References: <20210902161543.417092-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Restrict has_work() to TCG sysemu. Signed-off-by: Philippe Mathieu-Daudé --- target/nios2/cpu.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/target/nios2/cpu.c b/target/nios2/cpu.c index 947bb09bc1e..f1f976bdad7 100644 --- a/target/nios2/cpu.c +++ b/target/nios2/cpu.c @@ -34,10 +34,12 @@ static void nios2_cpu_set_pc(CPUState *cs, vaddr value) env->regs[R_PC] = value; } +#if defined(CONFIG_TCG) && !defined(CONFIG_USER_ONLY) static bool nios2_cpu_has_work(CPUState *cs) { return cs->interrupt_request & (CPU_INTERRUPT_HARD | CPU_INTERRUPT_NMI); } +#endif /* CONFIG_TCG && !CONFIG_USER_ONLY */ static void nios2_cpu_reset(DeviceState *dev) { @@ -223,6 +225,7 @@ static const struct TCGCPUOps nios2_tcg_ops = { .tlb_fill = nios2_cpu_tlb_fill, #ifndef CONFIG_USER_ONLY + .has_work = nios2_cpu_has_work, .cpu_exec_interrupt = nios2_cpu_exec_interrupt, .do_interrupt = nios2_cpu_do_interrupt, .do_unaligned_access = nios2_cpu_do_unaligned_access, @@ -241,7 +244,6 @@ static void nios2_cpu_class_init(ObjectClass *oc, void *data) device_class_set_parent_reset(dc, nios2_cpu_reset, &ncc->parent_reset); cc->class_by_name = nios2_cpu_class_by_name; - cc->has_work = nios2_cpu_has_work; cc->dump_state = nios2_cpu_dump_state; cc->set_pc = nios2_cpu_set_pc; cc->disas_set_info = nios2_cpu_disas_set_info; -- 2.31.1 From xen-devel-bounces@lists.xenproject.org Thu Sep 02 16:22:00 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 16:22:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177530.323063 (Exim 4.92) (envelope-from ) id 1mLpTU-0006zM-FI; Thu, 02 Sep 2021 16:22:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177530.323063; Thu, 02 Sep 2021 16:22:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLpTU-0006yx-AC; Thu, 02 Sep 2021 16:22:00 +0000 Received: by outflank-mailman (input) for mailman id 177530; Thu, 02 Sep 2021 16:21:58 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLpP6-00029c-QX for xen-devel@lists.xenproject.org; Thu, 02 Sep 2021 16:17:28 +0000 Received: from mail-wm1-x331.google.com (unknown [2a00:1450:4864:20::331]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 9ef57b0c-3db4-49db-ab0a-e88961aeea9d; Thu, 02 Sep 2021 16:17:21 +0000 (UTC) Received: by mail-wm1-x331.google.com with SMTP id o39-20020a05600c512700b002e74638b567so1756535wms.2 for ; Thu, 02 Sep 2021 09:17:21 -0700 (PDT) Received: from x1w.. (163.red-83-52-55.dynamicip.rima-tde.net. [83.52.55.163]) by smtp.gmail.com with ESMTPSA id u26sm2444655wrd.32.2021.09.02.09.17.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Sep 2021 09:17:20 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list X-Inumbo-ID: 9ef57b0c-3db4-49db-ab0a-e88961aeea9d DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=yI9HNtTgyr1D6LnyMBdjwFDJD3B27ntrVyNfg6pObmA=; b=U2uwqAQNdpnlzp+ESr25gYYFRQFiKkwGfbYBdEJEhK8WvNyB3W6SW/d8vS39ShykYt KjW8bmI0A51yksjJsztk3PnbWgrojrKVVqZEuWCXsll7maIHDOE+TUvhByg6eVxV2YO4 Kck+INFoCYRSpbSsv9Whw88dorhpd2Vg3v9+eB5JpbKAbAeW/R5bh44TF5Lf3uEy+zLL RGSPDOO8yKxtK+VZKvOfcEExgvyvZTiR2XR3sSyBG6KljCmSQBYEj0d3C/Q4ABoW/H1Q /jDgwuiymH/q6Oj2C76+I+aEeA3QCh3LaEPc/5XOWBjjrnq8mhBxG0fKOPLpG6nd3yVW dFLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=yI9HNtTgyr1D6LnyMBdjwFDJD3B27ntrVyNfg6pObmA=; b=Xm2kxRf5b4nwVM4gGhWtQqp68SCBHOhTxYxJ8VlHoTytT9r4qqYixLvzReNpDul4Ry 0boISPHQSzecnaQ+rzvjeR+J0+kn2c4KG3LQWRLoLZtO+VsNAVSY4Bg7/WkcMSuAaDGl pjn1ldU4Jlqh64xtbqAwOoU5xjKqzzH9nKReC72Im6YP20DvJ8kl4RimmkihacX7REmV WXkI/+5nR4/poz2kX6cSqRdAmMIVf+b6bEsI95kZ2WHuYaV1hSSvcAm0dwCeyOHtyvgW OL66QDNw+EcrpFGw7/g+brfC9EU5DLqLgGTIUhP5jKOKoMX6XA4q/nLMMiZM4cnltVC/ hIkA== X-Gm-Message-State: AOAM5302pTLxcA5m9/9HpruRKO7jvmNMxMdcrEhqr3iPMGBstRVlvs2/ KDLvX4jzaQq4b57KpD8uW/w= X-Google-Smtp-Source: ABdhPJxszMtpghtVMFzBIiCctVAaFhaKkfegWVJMuLYTNpt1RcE+DF7+wgJu132GyNXvqWu6eKFzOQ== X-Received: by 2002:a05:600c:3397:: with SMTP id o23mr3987673wmp.38.1630599441102; Thu, 02 Sep 2021 09:17:21 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Bin Meng , Eduardo Habkost , Greg Kurz , haxm-team@intel.com, Kamil Rytarowski , qemu-ppc@nongnu.org, Anthony Perard , Marcel Apfelbaum , Michael Rolnik , qemu-riscv@nongnu.org, Paolo Bonzini , Jiaxun Yang , Thomas Huth , David Hildenbrand , Chris Wulff , Laurent Vivier , Cameron Esfahani , Sunil Muthuswamy , Max Filippov , Taylor Simpson , qemu-s390x@nongnu.org, Richard Henderson , Bastian Koppelmann , Yoshinori Sato , Artyom Tarasenko , Aurelien Jarno , Paul Durrant , Peter Maydell , David Gibson , Alistair Francis , "Edgar E. Iglesias" , Roman Bolshakov , Laurent Vivier , Cornelia Huck , qemu-arm@nongnu.org, Wenchao Wang , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , xen-devel@lists.xenproject.org, Marek Vasut , Stefano Stabellini , Aleksandar Rikalo , Mark Cave-Ayland , Colin Xu , Claudio Fontana , Palmer Dabbelt , Stafford Horne , Reinoud Zandijk , kvm@vger.kernel.org Subject: [PATCH v3 15/30] target/m68k: Restrict has_work() handler to sysemu and TCG Date: Thu, 2 Sep 2021 18:15:28 +0200 Message-Id: <20210902161543.417092-16-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210902161543.417092-1-f4bug@amsat.org> References: <20210902161543.417092-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Restrict has_work() to TCG sysemu. Signed-off-by: Philippe Mathieu-Daudé --- target/m68k/cpu.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/target/m68k/cpu.c b/target/m68k/cpu.c index 66d22d11895..94b35cb4a50 100644 --- a/target/m68k/cpu.c +++ b/target/m68k/cpu.c @@ -31,10 +31,12 @@ static void m68k_cpu_set_pc(CPUState *cs, vaddr value) cpu->env.pc = value; } +#if defined(CONFIG_TCG) && !defined(CONFIG_USER_ONLY) static bool m68k_cpu_has_work(CPUState *cs) { return cs->interrupt_request & CPU_INTERRUPT_HARD; } +#endif /* CONFIG_TCG && !CONFIG_USER_ONLY */ static void m68k_set_feature(CPUM68KState *env, int feature) { @@ -518,6 +520,7 @@ static const struct TCGCPUOps m68k_tcg_ops = { .tlb_fill = m68k_cpu_tlb_fill, #ifndef CONFIG_USER_ONLY + .has_work = m68k_cpu_has_work, .cpu_exec_interrupt = m68k_cpu_exec_interrupt, .do_interrupt = m68k_cpu_do_interrupt, .do_transaction_failed = m68k_cpu_transaction_failed, @@ -535,7 +538,6 @@ static void m68k_cpu_class_init(ObjectClass *c, void *data) device_class_set_parent_reset(dc, m68k_cpu_reset, &mcc->parent_reset); cc->class_by_name = m68k_cpu_class_by_name; - cc->has_work = m68k_cpu_has_work; cc->dump_state = m68k_cpu_dump_state; cc->set_pc = m68k_cpu_set_pc; cc->gdb_read_register = m68k_cpu_gdb_read_register; -- 2.31.1 From xen-devel-bounces@lists.xenproject.org Thu Sep 02 16:36:58 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 16:36:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177565.323074 (Exim 4.92) (envelope-from ) id 1mLpht-0001mp-0d; Thu, 02 Sep 2021 16:36:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177565.323074; Thu, 02 Sep 2021 16:36:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLphs-0001mi-Ty; Thu, 02 Sep 2021 16:36:52 +0000 Received: by outflank-mailman (input) for mailman id 177565; Thu, 02 Sep 2021 16:36:51 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLphr-0001mc-M7 for xen-devel@lists.xenproject.org; Thu, 02 Sep 2021 16:36:51 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLphr-0000ar-K7 for xen-devel@lists.xenproject.org; Thu, 02 Sep 2021 16:36:51 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1mLphr-0000hc-JB for xen-devel@lists.xenproject.org; Thu, 02 Sep 2021 16:36:51 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1mLphm-0003SM-KY; Thu, 02 Sep 2021 17:36:46 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=D/t8Q47Sef2DkUJLCWNguQpG5Ves3E3v3+8vkz9f+9w=; b=MUZhn7bLOMouoGQJM3a8D7Xqfi lYx0BAxO1Pa3m4D1asDTOLZWA5qwrJoWXGRv9joHM2p+HuAbOrkWNck4LC+Z6Z7rwrHzgLxpUdt+U rRGLwHCB89pO8FwYcj7/eQcjUsqpSw138WJ94wslW1YjASUOYJv3NgPoX/zsxmeJx2l8=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24880.64926.93632.330726@mariner.uk.xensource.com> Date: Thu, 2 Sep 2021 17:36:46 +0100 To: Juergen Gross Cc: Jan Beulich , "xen-devel\@lists.xenproject.org" , Wei Liu , Julien Grall Subject: Re: [PATCH v2] tests/xenstore: link in librt if necessary In-Reply-To: References: <3efcfc3d-54c8-7308-2288-9f57ed0fca0f@suse.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Juergen Gross writes ("Re: [PATCH v2] tests/xenstore: link in librt if necessary"): > On 17.08.21 16:18, Jan Beulich wrote: > > Old enough glibc has clock_gettime() in librt.so, hence the library > > needs to be specified to the linker. Newer glibc has the symbol > > available in both libraries, so make sure that libc.so is preferred (to > > avoid an unnecessary dependency on librt.so). > > > > Fixes: 93c9edbef51b ("tests/xenstore: Rework Makefile") > > Signed-off-by: Jan Beulich > > Reviewed-by: Juergen Gross Thanks. While I peronally think this is not warranted, the extra Makefile clutter is a very minor wart and I definitely don't want to stand in the way of people dealing with things that are a problem for them. So: Acked-by: Ian Jackson and queued. I will push it today. Ian. From xen-devel-bounces@lists.xenproject.org Thu Sep 02 16:40:54 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 16:40:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177572.323085 (Exim 4.92) (envelope-from ) id 1mLpll-00039F-Hx; Thu, 02 Sep 2021 16:40:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177572.323085; Thu, 02 Sep 2021 16:40:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLpll-000398-Dt; Thu, 02 Sep 2021 16:40:53 +0000 Received: by outflank-mailman (input) for mailman id 177572; Thu, 02 Sep 2021 16:40:52 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLplk-000392-M4 for xen-devel@lists.xenproject.org; Thu, 02 Sep 2021 16:40:52 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLplk-0000fj-LF for xen-devel@lists.xenproject.org; Thu, 02 Sep 2021 16:40:52 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1mLplk-00019p-KT for xen-devel@lists.xenproject.org; Thu, 02 Sep 2021 16:40:52 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1mLplf-0003Tl-VM; Thu, 02 Sep 2021 17:40:47 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=GYDi4db046fx5JmmXElXDDtxBBBEsA4Th0cEYvzm6zg=; b=2LvnozFAb3yNbpSa4d5bY76QSt aKwgZG8n3+bo1Pb0Pusn2VsSSFiPRSTHekGmznA6JKDKyd9z9KlRCFdmoAZh6yc+YghF9/0kc61tc uF+RjQOXzouELYRA9waRq5MPmpqFVYl3tnyU8W7y6jh38UREyGtev43sF0Steb7HyYpw=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24880.65167.715236.551394@mariner.uk.xensource.com> Date: Thu, 2 Sep 2021 17:40:47 +0100 To: Juergen Gross Cc: Jan Beulich , "xen-devel\@lists.xenproject.org" , Wei Liu Subject: Re: [PATCH] tools: ROUNDUP() related adjustments In-Reply-To: References: X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Juergen Gross writes ("Re: [PATCH] tools: ROUNDUP() related adjustments"): > On 10.08.21 12:03, Jan Beulich wrote: > > For one xc_private.h needlessly repeats xen-tools/libs.h's definition. > > > > And then there are two suspicious uses (resulting from the inconsistency > > with the respective 2nd parameter of DIV_ROUNDUP()): While the one in > > tools/console/daemon/io.c - as per the code comment - intentionally uses > > 8 as the second argument (meaning to align to a multiple of 256), the > > one in alloc_magic_pages_hvm() pretty certainly does not: There the goal > > is to align to a uint64_t boundary, for the following module struct to > > end up aligned. This is really quite unpleasnt, to my mind. ROUNDUP taking a bit length is bad enough, but the magic knowledge about alignment is really poor too. It may not be right on all future architectures, although I think your changae is correct on all the ones we support (or which people are working on). So IOW I think your change is correct and warranted, but I really dislike the code here. Therefore: Acked-by: Ian Jackson > > Signed-off-by: Jan Beulich > > Reviewed-by: Juergen Gross Thanks for the review! Ian. From xen-devel-bounces@lists.xenproject.org Thu Sep 02 16:58:05 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 16:58:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177579.323095 (Exim 4.92) (envelope-from ) id 1mLq2J-0005CL-Vx; Thu, 02 Sep 2021 16:57:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177579.323095; Thu, 02 Sep 2021 16:57:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLq2J-0005CE-T3; Thu, 02 Sep 2021 16:57:59 +0000 Received: by outflank-mailman (input) for mailman id 177579; Thu, 02 Sep 2021 16:57:58 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLq2I-0005C6-Me for xen-devel@lists.xenproject.org; Thu, 02 Sep 2021 16:57:58 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLq2I-00015Y-Ku for xen-devel@lists.xenproject.org; Thu, 02 Sep 2021 16:57:58 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1mLq2I-00076K-Jq for xen-devel@lists.xenproject.org; Thu, 02 Sep 2021 16:57:58 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1mLq27-0003Vy-UT; Thu, 02 Sep 2021 17:57:47 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=VQ/pDRqduhH2wpfMLbgaHgM/4ZpTVM/+CEGro1GEMXk=; b=IB5fOPYC0qJdZkqXx8UfY1j0yU aXGHWedIpnm+dgMlrCkTqpOa1R4Wwi1mg0l1ZsB4HNXKdie85Zommd03YJgtweWsONI+XQiucADZI ZCK+KiF9lwpCFCNYee6QGBtJpBZREeY3/8AjuqAxQRZBQxQfggK4sLIfLojIZRQr0054=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24881.651.565806.53730@mariner.uk.xensource.com> Date: Thu, 2 Sep 2021 17:57:47 +0100 To: Jan Beulich Cc: Juergen Gross , Andrew Cooper , Wei Liu , Roger Pau =?iso-8859-1?Q?Monn=E9?= , George Dunlap , "xen-devel\@lists.xenproject.org" Subject: Re: [PATCH v2 03/13] libxenguest: deal with log-dirty op stats overflow In-Reply-To: <6d8b3104-f7e6-494c-30e1-1c06419fbfb0@suse.com> References: <0bebfe8c-6897-dc8b-7fe0-9127d4996eb8@suse.com> <668ef720-389f-4cf1-608e-64aca4f7c73d@suse.com> <347edc1f-a104-1bc3-0cb2-2cfffcb6214a@suse.com> <6d8b3104-f7e6-494c-30e1-1c06419fbfb0@suse.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Jan Beulich writes ("Re: [PATCH v2 03/13] libxenguest: deal with log-dirty op stats overflow"): > And - just to make it very explicit - even if I went this route to > address a controversial point, I'd still like to understand the > reason for the original objection - if only for my own education. I agree with this position. I have reread the discussions with this patch title in the Subject line. I am still unclear on the precise nature of Andrew's objection. All I could find was this from Andrew: > ctx->save.stats = (struct precopy_stats){ > - .dirty_count = ctx->save.p2m_size, > + .dirty_count = -1, This is an external interface, and I'm not sure it will tolerate finding more than p2m_size allegedly dirty. and then the later comment by Andrew: I've already explained why [various things] Unfortunately that message did not contain any links to these previous explanations. Andrew, where were they ? If we are not to go round in circles, we need to write these things down and then refer to them when relevant. We had a conversation on irc today. I found today's IRC conversation rather unsatisfactory. I gleaned from Andrew's comments that this he was saying this callback is used by something in Citrix's product to do with nVidia migration. Obviously we do not wish to break a downstream. But this interface is badly documented and clear explanations are lacking. While I recognise Andrew's expertise in this area, I think that as tools maintainer I need to go with the information I have. The overflow issue is real and Jan has proposed a fix. Andrew: do you have time to engage with Jan here on these API questions ? If not, does anyone else have enough familiarity with Citrix's use of this API to engage in a proper discussion about how the overflow problem can be addressed ? If effort is not available for this, that is of course fine. But as an Open Source project we need to be able to move forwsrd with the available input and contributions. So if no-one is able to explain how this rather poor API is to be used, and help develop a solution to the overflow problem, I should probably ack Jan's patch here. Ian. From xen-devel-bounces@lists.xenproject.org Thu Sep 02 17:04:46 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 17:04:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177585.323106 (Exim 4.92) (envelope-from ) id 1mLq8o-0006ob-MV; Thu, 02 Sep 2021 17:04:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177585.323106; Thu, 02 Sep 2021 17:04:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLq8o-0006oU-Ji; Thu, 02 Sep 2021 17:04:42 +0000 Received: by outflank-mailman (input) for mailman id 177585; Thu, 02 Sep 2021 17:04:40 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLq8m-0006oO-Du for xen-devel@lists.xenproject.org; Thu, 02 Sep 2021 17:04:40 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLq8m-0001Du-Bo for xen-devel@lists.xenproject.org; Thu, 02 Sep 2021 17:04:40 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1mLq8m-0007tR-An for xen-devel@lists.xenproject.org; Thu, 02 Sep 2021 17:04:40 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1mLq8h-0003Xd-Jy; Thu, 02 Sep 2021 18:04:35 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=EwrkcWG+KtHbspcp5DkvRxCnd1eWWHv+1cIErtfTVjg=; b=bDDDwbvXfOyL/MbBT9A/njs4zb em1e437Z8ewV8Lv6fGTbNJIZomyxOWXWYlm//NqfiS7MRZdRoeta/VN1GRMWGndWGkp+Ejq5SVvtT h5YmeOcJJ0DTtUGyR2/0eARjqYU+oV8vVR/yj7yjFffgKAyXKJUB0ro9395wQ1BLQ758=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24881.1059.344754.415908@mariner.uk.xensource.com> Date: Thu, 2 Sep 2021 18:04:35 +0100 To: Juergen Gross Cc: Jan Beulich , "xen-devel\@lists.xenproject.org" , Andrew Cooper , Wei Liu , Roger Pau =?iso-8859-1?Q?Monn=E9?= , George Dunlap , Anthony Perard , Marek Marczykowski Subject: Re: [PATCH v2 02/13] libxc: split xc_logdirty_control() from xc_shadow_control() [and 1 more messages] In-Reply-To: <7284e7d0-99cc-e35d-2d44-46e7a3132498@suse.com>, References: <0bebfe8c-6897-dc8b-7fe0-9127d4996eb8@suse.com> <4b68233b-259c-3308-3292-82e991e1e108@suse.com> <7284e7d0-99cc-e35d-2d44-46e7a3132498@suse.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Juergen Gross writes ("Re: [PATCH v2 02/13] libxc: split xc_logdirty_control() from xc_shadow_control()"): > On 05.07.21 17:12, Jan Beulich wrote: > >>> +long long xc_logdirty_control(xc_interface *xch, > >>> + uint32_t domid, > >>> + unsigned int sop, > >>> + xc_hypercall_buffer_t *dirty_bitmap, > >>> + unsigned long pages, > >>> + unsigned int mode, > >>> + xc_shadow_op_stats_t *stats) > >>> +{ > >>> + int rc; > >>> + struct xen_domctl domctl = { > >>> + .cmd = XEN_DOMCTL_shadow_op, > >>> + .domain = domid, > >>> + .u.shadow_op = { > >>> + .op = sop, > >> > >> And same here the other way round: sop should really only be one of > >> XEN_DOMCTL_SHADOW_OP_CLEAN or XEN_DOMCTL_SHADOW_OP_PEEK. > >> > >> With that fixed you can add my: > >> > >> Reviewed-by: Juergen Gross > > > > Thanks, but I won't take this just yet, awaiting your (and maybe > > others') view(s) on my reply above. > > I'm not feeling really strong in this regard. Either way is fine for > me. OK. My understanding then is that you are happy with Jan's patch and he can add the Reviewed-by even though he's not checking the ops. Is that right ? If so, then Jan, please add my Acked-by: Ian Jackson along with Juergen's review. If I have misunderstood please explain :-). Thanks, Ian. From xen-devel-bounces@lists.xenproject.org Thu Sep 02 17:11:52 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 17:11:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177593.323124 (Exim 4.92) (envelope-from ) id 1mLqFf-0008PQ-HE; Thu, 02 Sep 2021 17:11:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177593.323124; Thu, 02 Sep 2021 17:11:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLqFf-0008PJ-E7; Thu, 02 Sep 2021 17:11:47 +0000 Received: by outflank-mailman (input) for mailman id 177593; Thu, 02 Sep 2021 17:11:46 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLqFe-0008PD-SV for xen-devel@lists.xenproject.org; Thu, 02 Sep 2021 17:11:46 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLqFe-0001Mu-Rg for xen-devel@lists.xenproject.org; Thu, 02 Sep 2021 17:11:46 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1mLqFe-0000MA-Qq for xen-devel@lists.xenproject.org; Thu, 02 Sep 2021 17:11:46 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1mLqFT-0003Zb-3Q; Thu, 02 Sep 2021 18:11:35 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=GeXJrQDQtclWxuJyi9dryyESGh+JES5AlryXjtCzhwo=; b=fVot05xTOOmNdteLjWY4uKKlm0 8/Z6R/YFBUpdHdO18Cqd0KgA3lT12aevbOHftQsqJnw1PumWNigvx5ArAOzInL2u7UjFKNnZWG5Jf uAXlw004OWjPvZ4I1hLLjPwu6+d6bLLVKhI9QLfz4yPYVXTfmz5droqlPBcoGzPponUY=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Message-ID: <24881.1478.795535.377133@mariner.uk.xensource.com> Date: Thu, 2 Sep 2021 18:11:34 +0100 To: Jan Beulich Cc: Andrew Cooper , Wei Liu , Roger Pau =?iso-8859-1?Q?Monn=E9?= , Juergen Gross , George Dunlap , "xen-devel\@lists.xenproject.org" Subject: Re: [PATCH 03/12] libxenguest: short-circuit "all-dirty" handling In-Reply-To: References: <912fa390-f9e9-198a-9aee-39fdb9a28fcc@suse.com> <55875a26-7f1d-a6d9-9384-b03b3b2cb86d@suse.com> <60be051f-7751-f15d-ae4d-2c7e9af82693@citrix.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Jan Beulich writes ("Re: [PATCH 03/12] libxenguest: short-circuit "all-dirty" handling"): > On 25.06.2021 19:02, Andrew Cooper wrote: > > Single all-dirty runs are a debugging technique only. All production > > cases are live, and you don't want to fail midway through because a > > late, large, memory allocation failed. > > I'm afraid I don't understand: I don't move _when_ the allocation > occurs; I only suppress the allocation (altogether) when the allocated > memory remains unused. Thanks for this reply, Jan. I hope it is satisfactory to Andrew; if not, I hope Andrew will be able to explain. I am going to give this a provisional Acked-by: Ian Jackson I may of course withdraw that ack if it is explained to me that this is patch is wrong. > >> + : (void *)-1L; > > > > This is a pointer loaded with a timebomb, which doesn't trigger NULL > > pointer checks, and for which {set,clear}_bit(dirty_bitmap, large_pfn) > > won't fault and will instead corrupt random areas of the address space. > > Yeah, this isn't very nice, and gets done away with again in a later > patch. I'd prefer to keep it like it is (assuming the later change > will also go in), but if really deemed necessary I can move that code > re-arrangement here, such that the use of (void *)-1L wouldn't be > necessary anymore. (You may have noticed that all I did this for is > to be able to pass the !dirty_bitmap later in the function, and that > I deliberately only update the local variable, not the hbuf, making > pretty certain that this pointer isn't going to be de-referenced.) I agree that this -1L is very unpleasant. I'm not going to say that you need to restructure your series, but please make sure you don't commit this patch without the fix. Thanks, Ian. From xen-devel-bounces@lists.xenproject.org Thu Sep 02 17:18:00 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 17:18:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177599.323135 (Exim 4.92) (envelope-from ) id 1mLqLb-0000fi-6b; Thu, 02 Sep 2021 17:17:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177599.323135; Thu, 02 Sep 2021 17:17:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLqLb-0000fb-3Q; Thu, 02 Sep 2021 17:17:55 +0000 Received: by outflank-mailman (input) for mailman id 177599; Thu, 02 Sep 2021 17:17:54 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLqLa-0000fV-8G for xen-devel@lists.xenproject.org; Thu, 02 Sep 2021 17:17:54 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLqLa-0001T6-6O for xen-devel@lists.xenproject.org; Thu, 02 Sep 2021 17:17:54 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1mLqLa-0000rf-5N for xen-devel@lists.xenproject.org; Thu, 02 Sep 2021 17:17:54 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1mLqLP-0003au-9j; Thu, 02 Sep 2021 18:17:43 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=umiEI7GI1ws1A9D4DUyhTQcphKTnzeVma7/jDhfL17Y=; b=u62kLIS/FgD59gVZ9daqK4fLPc XSgGpBGAF3SlzgA8WBEwl9yndpiFnBtpfw4nwNDnq8uPvlFWppzPYSeKoMqRHGUj7D8yRcn+j4oO2 3aHlx4hFMP0TigC2PKqcQSb5JcQ1HdooYxMUpEocyn/+yZTDsdDzHPMwUvPnyACrFcYo=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24881.1846.830472.226170@mariner.uk.xensource.com> Date: Thu, 2 Sep 2021 18:17:42 +0100 To: Jan Beulich Cc: Andrew Cooper , Wei Liu , Roger Pau =?iso-8859-1?Q?Monn=E9?= , Juergen Gross , George Dunlap , "xen-devel\@lists.xenproject.org" Subject: Re: [PATCH 04/12] libxenguest: avoid allocating unused deferred-pages bitmap In-Reply-To: <3aea7472-6c1d-f786-db5f-ead60eb03240@suse.com> References: <912fa390-f9e9-198a-9aee-39fdb9a28fcc@suse.com> <61ff4f26-a9cc-d123-98a0-be6c23f21e9b@suse.com> <44825600-c27b-34ac-01b2-1ffb5e0bf0be@citrix.com> <3aea7472-6c1d-f786-db5f-ead60eb03240@suse.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Jan Beulich writes ("Re: [PATCH 04/12] libxenguest: avoid allocating unused deferred-pages bitmap"): > [stuff] I have read this conversation several times and it is not clear to me whether Andrew was saying Jan's patch is bad, or the existing code is bad. I'm hesitant to give an ack for an optimisation without understanding what the implications might be. Andrew, can you explain what will go wrong if we take Jan's patch ? (I amk not really familiar with this area of the code. If necessary I could go and read it to form my own opinion.) Thanks, Ian. From xen-devel-bounces@lists.xenproject.org Thu Sep 02 18:15:59 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 18:15:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177605.323146 (Exim 4.92) (envelope-from ) id 1mLrFa-0007Q9-Gj; Thu, 02 Sep 2021 18:15:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177605.323146; Thu, 02 Sep 2021 18:15:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLrFa-0007Q2-Df; Thu, 02 Sep 2021 18:15:46 +0000 Received: by outflank-mailman (input) for mailman id 177605; Thu, 02 Sep 2021 18:15:45 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLrFZ-0007Ps-DJ; Thu, 02 Sep 2021 18:15:45 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLrFZ-0002TH-5T; Thu, 02 Sep 2021 18:15:45 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLrFY-00051A-SY; Thu, 02 Sep 2021 18:15:44 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mLrFY-0002Nm-S2; Thu, 02 Sep 2021 18:15:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=SDIcP1OjsiM+oeKet/4l7rZjv861FdN57ePGZ2vAEp8=; b=j/Jg29RwqUnoXvECYRE3vXsLRW LwkPrPdy2LtNsrqecOAibPJQe2sASD4PpgwlPy0nzCvCK4gT/8MF9wE7uabNPJ2I9kHSwzi9y6D62 dLsgkogoAFadgzIYEJe0iuH8uoJel2bCuABLIkTudIfpVnKP8qph0syDehNCs5V63IVg=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 164757: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=079b1252e9de384385c9da910262312ec2e574c8 X-Osstest-Versions-That: qemuu=4c41a1c595e1ce3fe29f3b7bb22ff7402be9c77d From: osstest service owner Date: Thu, 02 Sep 2021 18:15:44 +0000 flight 164757 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/164757/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 164725 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 164725 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 164725 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 164725 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 164725 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 164725 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 164725 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: qemuu 079b1252e9de384385c9da910262312ec2e574c8 baseline version: qemuu 4c41a1c595e1ce3fe29f3b7bb22ff7402be9c77d Last test of basis 164725 2021-09-01 21:39:10 Z 0 days Testing same since 164757 2021-09-02 08:06:50 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Alistair Francis David Gibson Peter Maydell Philippe Mathieu-Daudé Philippe Mathieu-Daudé Shuuichirou Ishii Yanan Wang jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git 4c41a1c595..079b1252e9 079b1252e9de384385c9da910262312ec2e574c8 -> upstream-tested From xen-devel-bounces@lists.xenproject.org Thu Sep 02 18:39:54 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 18:39:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177617.323166 (Exim 4.92) (envelope-from ) id 1mLrcp-0001li-SV; Thu, 02 Sep 2021 18:39:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177617.323166; Thu, 02 Sep 2021 18:39:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLrcp-0001lb-NZ; Thu, 02 Sep 2021 18:39:47 +0000 Received: by outflank-mailman (input) for mailman id 177617; Thu, 02 Sep 2021 18:39:46 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLrco-0001lR-L9; Thu, 02 Sep 2021 18:39:46 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLrco-0002pm-DO; Thu, 02 Sep 2021 18:39:46 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLrco-0005jl-5H; Thu, 02 Sep 2021 18:39:46 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mLrco-0001Q1-4o; Thu, 02 Sep 2021 18:39:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=3oSTTXi2qZQMzCQ8lYQzWt46vZWAp8aVUy5kVV8WMks=; b=VtG0aiReSvAxsi3IH8+Nzu6saw IGZKuo+AI4KOKTudu8eT0mKd4q0eviEM84VmspwHKTgq2hkhEj1TmhgfUJe6gT99zwl7S1vZEKbek xEzDfRxaNAg8mV/9Iz7euV5D431ix8VDQBEavoNWbN1sFYTRyTfeC5SLyvvEj0nmbvhc=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 164764: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=b6bc203375b6efb6822ee4fe4a59be4f1918436b X-Osstest-Versions-That: ovmf=cae735f61328d64e2e8991036707b9e78c0f5f63 From: osstest service owner Date: Thu, 02 Sep 2021 18:39:46 +0000 flight 164764 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/164764/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 164674 build-amd64-xsm 6 xen-build fail REGR. vs. 164674 build-i386-xsm 6 xen-build fail REGR. vs. 164674 build-i386 6 xen-build fail REGR. vs. 164674 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf b6bc203375b6efb6822ee4fe4a59be4f1918436b baseline version: ovmf cae735f61328d64e2e8991036707b9e78c0f5f63 Last test of basis 164674 2021-08-31 02:56:52 Z 2 days Failing since 164686 2021-09-01 03:03:43 Z 1 days 13 attempts Testing same since 164764 2021-09-02 12:11:21 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Anthony PERARD DunTan Gary Lin Jim Fehlig Lin, Gary (HPS OE-Linux) Loo Tung Lun Loo, Tung Lun Mark Wilson Marvin H?user Wenxing Hou Wenyi Xie jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit b6bc203375b6efb6822ee4fe4a59be4f1918436b Author: Wenyi Xie Date: Thu Aug 26 09:16:03 2021 +0800 MdeModulePkg/HiiDatabaseDxe:remove dead code block As the if statement outside has confirmed that BlockData->Name == NULL, so the if statement inside is always false. Cc: Jian J Wang Cc: Hao A Wu Cc: Dandan Bi Cc: Eric Dong Signed-off-by: Wenyi Xie Reviewed-by: Dandan Bi commit e3ee8c8dbd7a9f7d7905abe17be60354c9f5f9a3 Author: duntan Date: Fri Aug 20 14:43:37 2021 +0800 .azurepipelines: Add UefiPayloadPkg in gate-build-job.yml and CISetting.py Add UefiPayloadPkg in gate-build-job.yml to enable Core ci for UefiPayloadPkg. Add UefiPayloadPkg to supported Packages in CISettings. Cc: Sean Brogan Cc: Bret Barkelew Cc: Michael D Kinney Cc: Liming Gao Signed-off-by: DunTan Reviewed-by: Liming Gao commit 63fddc98e06c380e654b1cfbaf24b9fd922adfad Author: duntan Date: Fri Aug 20 14:43:36 2021 +0800 UefiPayloadPkg: Create .yaml file in UefiPayloadPkg Create .yaml file in UefiPayloadPkg to enable Core ci for UefiPayloadPkg Cc: Guo Dong Cc: Ray Ni Cc: Maurice Ma Cc: Benjamin You Signed-off-by: DunTan Reviewed-by: Liming Gao commit 12e33dca4c0612a0975265e5ba641c6261a26455 Author: Loo, Tung Lun Date: Tue Aug 17 15:43:12 2021 +0800 IntelFsp2Pkg: Support Config File and Binary delta comparison BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3567 This patch is to enable config editor to have a new feature that can spell out the delta between the default configuration files' data, such as YAML and BSF, against the data stored in the binary. This can help users understand and track the difference when modifications are made. Cc: Maurice Ma Cc: Nate DeSimone Cc: Star Zeng Cc: Chasel Chiu Signed-off-by: Loo Tung Lun Reviewed-by: Chasel Chiu commit b170806518c1e414939c8b085866544814e1ce8e Author: Mark Wilson Date: Fri Nov 13 08:05:18 2020 +0800 UefiCpuPkg: Clean up save state boundary checks and comments. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2956 In functions ReadSaveStateRegisterByIndex and WriteSaveStateRegister: * check width > 4 instead of >= 4 when writing upper 32 bytes. - This improves the code but will not affect functionality. Cc: Eric Dong Reviewed-by: Ray Ni Signed-off-by: Mark Wilson commit 3b3f88228812e2c642eea8746858a4dad928ebf7 Author: Marvin H?user Date: Mon Aug 9 14:09:25 2021 +0800 MdeModulePkg/PiSmmCore: Drop deprecated image profiling commands The legacy codebase allowed SMM images to be registered for profiling from DXE. Support for this has been dropped entirely, so remove the remaining handlers. Cc: Jian J Wang Cc: Hao A Wu Cc: Eric Dong Reviewed-by: Ray Ni Cc: Vitaly Cheptsov Signed-off-by: Marvin H?user commit cdda3f74a1327663a5d48cca13507085ba403af7 Author: Marvin H?user Date: Mon Aug 9 03:39:53 2021 +0800 UefiPayloadPkg/UefiPayloadEntry: Fix memory corruption UefiPayloadEntry's AllocatePool() applies the "sizeof" operator to HOB index rather than the HOB header structure. This yields 4 Bytes compared to the 8 Bytes the structure header requires. Fix the call to allocate the required space instead. Reviewed-by: Guo Dong Reviewed-by: Ray Ni Cc: Maurice Ma Cc: Benjamin You Cc: Vitaly Cheptsov Signed-off-by: Marvin H?user commit 5d34cc49d5d348012fe8acf9fb618826bd541a7c Author: Wenxing Hou Date: Tue Aug 24 16:11:11 2021 +0800 UefiCpuPkg/PiSmmCpuDxeSmm: Update mPatchCetSupported set condition REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3584 Function AsmCpuid should first check the value for Basic CPUID Information. The fix is to update the mPatchCetSupported judgment statement. Signed-off-by: Wenxing Hou Reviewed-by: Ray Ni Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Cc: Sheng W Cc: Yao Jiewen commit f0fe55bca4651734abf1752a1d7c69fb5bee00b9 Author: duntan Date: Fri Aug 20 13:04:29 2021 +0800 UefiPayloadPkg: Fix the build error when enable Core ci for UefiPayloadPkg V1: Add quotes when using $(ARCH) in .dsc and .fdf file. The quotes are added due to the way by which Core ci parse the .dsc file. Add UINTN in Hob.c to fix cast from pointer to integer of different size error. V2: Delete lines which reference ShellBinPkg.The pkg doesn't exist in edk2. Cc: Guo Dong Cc: Ray Ni Cc: Maurice Ma Cc: Benjamin You Signed-off-by: DunTan Reviewed-by: Ray Ni commit 9f3eda177a4b2d4a33ff1b0307cad42906396562 Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:29:48 2021 +0800 OvmfPkg/OvmfXen: add QemuKernelLoaderFsDxe Without QemuKernelLoaderFsDxe, QemuLoadKernelImage() couldn't download the kernel, initrd, and kernel command line from QEMU's fw_cfg. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3574 Signed-off-by: Gary Lin Acked-by: Anthony PERARD Reviewed-by: Philippe Mathieu-Daude Reviewed-by: Gerd Hoffmann Tested-by: Jim Fehlig commit 5b5f10d7465004e3e40ec1f50a3b490b4db595e7 Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:31:15 2021 +0800 OvmfPkg/SmmControl2Dxe: use PcdAcpiS3Enable to detect S3 support To avoid the potential inconsistency between PcdAcpiS3Enable and QemuFwCfgS3Enabled(), this commit modifies SmmControl2Dxe to detect S3 support by PcdAcpiS3Enable as modules in MdeModulePkg do. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3573 Signed-off-by: Gary Lin Reviewed-by: Gerd Hoffmann Reviewed-by: Jiewen Yao Tested-by: Jim Fehlig commit 52e2dabc0f8d3af09c213072ce8ba734302f585d Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:31:14 2021 +0800 OvmfPkg/PlatformBootManagerLib: use PcdAcpiS3Enable to detect S3 support To avoid the potential inconsistency between PcdAcpiS3Enable and QemuFwCfgS3Enabled(), this commit modifies PlatformBootManagerLib to detect S3 support by PcdAcpiS3Enable as modules in MdeModulePkg do. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3573 Signed-off-by: Gary Lin Reviewed-by: Gerd Hoffmann Reviewed-by: Jiewen Yao Tested-by: Jim Fehlig commit 28152333bccb778b62e6e97446b28bfa0e92ef82 Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:31:13 2021 +0800 OvmfPkg/LockBoxLib: use PcdAcpiS3Enable to detect S3 support To avoid the potential inconsistency between PcdAcpiS3Enable and QemuFwCfgS3Enabled(), this commit modifies LockBoxLib to detect S3 support by PcdAcpiS3Enable as modules in MdeModulePkg do. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3573 Signed-off-by: Gary Lin Reviewed-by: Philippe Mathieu-Daude Reviewed-by: Gerd Hoffmann Reviewed-by: Jiewen Yao Tested-by: Jim Fehlig commit cb0d24637dfdd869618b9635dfb8e3b0746393a6 Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:31:12 2021 +0800 OvmfPkg/OvmfXen: set PcdAcpiS3Enable at initialization There are several functions in OvmfPkg/Library using QemuFwCfgS3Enabled() to detect the S3 support status. However, in MdeModulePkg, PcdAcpiS3Enable is used to check S3 support. Since InitializeXenPlatform() didn't set PcdAcpiS3Enable as InitializePlatform() did, this made the inconsistency between drivers/functions. For example, S3SaveStateDxe checked PcdAcpiS3Enable and skipped S3BootScript because the default value is FALSE. On the other hand, PlatformBootManagerBeforeConsole() from OvmfPkg/Library called QemuFwCfgS3Enabled() and found it returned TRUE, so it invoked SaveS3BootScript(). However, S3SaveStateDxe skipped S3BootScript, so SaveS3BootScript() asserted due to EFI_NOT_FOUND. This issue mainly affects "HVM Direct Kernel Boot". When used, "fw_cfg" is enabled in QEMU and QemuFwCfgS3Enabled() returns true in that case. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3573 Signed-off-by: Gary Lin Reviewed-by: Anthony PERARD Reviewed-by: Gerd Hoffmann Reviewed-by: Jiewen Yao Tested-by: Jim Fehlig From xen-devel-bounces@lists.xenproject.org Thu Sep 02 19:55:09 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 19:55:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177626.323180 (Exim 4.92) (envelope-from ) id 1mLsnT-000235-EP; Thu, 02 Sep 2021 19:54:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177626.323180; Thu, 02 Sep 2021 19:54:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLsnT-00022y-BG; Thu, 02 Sep 2021 19:54:51 +0000 Received: by outflank-mailman (input) for mailman id 177626; Thu, 02 Sep 2021 19:54:50 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLsnR-00022o-Uy; Thu, 02 Sep 2021 19:54:49 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLsnR-00041y-HV; Thu, 02 Sep 2021 19:54:49 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLsnR-0008V9-96; Thu, 02 Sep 2021 19:54:49 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mLsnR-0005pk-8d; Thu, 02 Sep 2021 19:54:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=gE81+iMR+tkr7Ly7/RydKpk8KRxexAegu4xRQUWSBFg=; b=CHDqHaDZf34kuNqA6WQJA1XGq3 NPxPem6gLGKh2dD71T+dxDTY4H77EH8vP4M6HagzvipAuRIF7INj0uf3DyYcCWH33Lrb3G/KxFpEP QATxcfBbFzt5DsnnS32l54ntQS1R/WolYeg7Aup77S14UEB2u8qyr5c65zAeab9GSaQc=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 164773: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=b6bc203375b6efb6822ee4fe4a59be4f1918436b X-Osstest-Versions-That: ovmf=cae735f61328d64e2e8991036707b9e78c0f5f63 From: osstest service owner Date: Thu, 02 Sep 2021 19:54:49 +0000 flight 164773 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/164773/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 164674 build-amd64-xsm 6 xen-build fail REGR. vs. 164674 build-i386-xsm 6 xen-build fail REGR. vs. 164674 build-i386 6 xen-build fail REGR. vs. 164674 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf b6bc203375b6efb6822ee4fe4a59be4f1918436b baseline version: ovmf cae735f61328d64e2e8991036707b9e78c0f5f63 Last test of basis 164674 2021-08-31 02:56:52 Z 2 days Failing since 164686 2021-09-01 03:03:43 Z 1 days 14 attempts Testing same since 164764 2021-09-02 12:11:21 Z 0 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Anthony PERARD DunTan Gary Lin Jim Fehlig Lin, Gary (HPS OE-Linux) Loo Tung Lun Loo, Tung Lun Mark Wilson Marvin H?user Wenxing Hou Wenyi Xie jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit b6bc203375b6efb6822ee4fe4a59be4f1918436b Author: Wenyi Xie Date: Thu Aug 26 09:16:03 2021 +0800 MdeModulePkg/HiiDatabaseDxe:remove dead code block As the if statement outside has confirmed that BlockData->Name == NULL, so the if statement inside is always false. Cc: Jian J Wang Cc: Hao A Wu Cc: Dandan Bi Cc: Eric Dong Signed-off-by: Wenyi Xie Reviewed-by: Dandan Bi commit e3ee8c8dbd7a9f7d7905abe17be60354c9f5f9a3 Author: duntan Date: Fri Aug 20 14:43:37 2021 +0800 .azurepipelines: Add UefiPayloadPkg in gate-build-job.yml and CISetting.py Add UefiPayloadPkg in gate-build-job.yml to enable Core ci for UefiPayloadPkg. Add UefiPayloadPkg to supported Packages in CISettings. Cc: Sean Brogan Cc: Bret Barkelew Cc: Michael D Kinney Cc: Liming Gao Signed-off-by: DunTan Reviewed-by: Liming Gao commit 63fddc98e06c380e654b1cfbaf24b9fd922adfad Author: duntan Date: Fri Aug 20 14:43:36 2021 +0800 UefiPayloadPkg: Create .yaml file in UefiPayloadPkg Create .yaml file in UefiPayloadPkg to enable Core ci for UefiPayloadPkg Cc: Guo Dong Cc: Ray Ni Cc: Maurice Ma Cc: Benjamin You Signed-off-by: DunTan Reviewed-by: Liming Gao commit 12e33dca4c0612a0975265e5ba641c6261a26455 Author: Loo, Tung Lun Date: Tue Aug 17 15:43:12 2021 +0800 IntelFsp2Pkg: Support Config File and Binary delta comparison BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3567 This patch is to enable config editor to have a new feature that can spell out the delta between the default configuration files' data, such as YAML and BSF, against the data stored in the binary. This can help users understand and track the difference when modifications are made. Cc: Maurice Ma Cc: Nate DeSimone Cc: Star Zeng Cc: Chasel Chiu Signed-off-by: Loo Tung Lun Reviewed-by: Chasel Chiu commit b170806518c1e414939c8b085866544814e1ce8e Author: Mark Wilson Date: Fri Nov 13 08:05:18 2020 +0800 UefiCpuPkg: Clean up save state boundary checks and comments. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2956 In functions ReadSaveStateRegisterByIndex and WriteSaveStateRegister: * check width > 4 instead of >= 4 when writing upper 32 bytes. - This improves the code but will not affect functionality. Cc: Eric Dong Reviewed-by: Ray Ni Signed-off-by: Mark Wilson commit 3b3f88228812e2c642eea8746858a4dad928ebf7 Author: Marvin H?user Date: Mon Aug 9 14:09:25 2021 +0800 MdeModulePkg/PiSmmCore: Drop deprecated image profiling commands The legacy codebase allowed SMM images to be registered for profiling from DXE. Support for this has been dropped entirely, so remove the remaining handlers. Cc: Jian J Wang Cc: Hao A Wu Cc: Eric Dong Reviewed-by: Ray Ni Cc: Vitaly Cheptsov Signed-off-by: Marvin H?user commit cdda3f74a1327663a5d48cca13507085ba403af7 Author: Marvin H?user Date: Mon Aug 9 03:39:53 2021 +0800 UefiPayloadPkg/UefiPayloadEntry: Fix memory corruption UefiPayloadEntry's AllocatePool() applies the "sizeof" operator to HOB index rather than the HOB header structure. This yields 4 Bytes compared to the 8 Bytes the structure header requires. Fix the call to allocate the required space instead. Reviewed-by: Guo Dong Reviewed-by: Ray Ni Cc: Maurice Ma Cc: Benjamin You Cc: Vitaly Cheptsov Signed-off-by: Marvin H?user commit 5d34cc49d5d348012fe8acf9fb618826bd541a7c Author: Wenxing Hou Date: Tue Aug 24 16:11:11 2021 +0800 UefiCpuPkg/PiSmmCpuDxeSmm: Update mPatchCetSupported set condition REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3584 Function AsmCpuid should first check the value for Basic CPUID Information. The fix is to update the mPatchCetSupported judgment statement. Signed-off-by: Wenxing Hou Reviewed-by: Ray Ni Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Cc: Sheng W Cc: Yao Jiewen commit f0fe55bca4651734abf1752a1d7c69fb5bee00b9 Author: duntan Date: Fri Aug 20 13:04:29 2021 +0800 UefiPayloadPkg: Fix the build error when enable Core ci for UefiPayloadPkg V1: Add quotes when using $(ARCH) in .dsc and .fdf file. The quotes are added due to the way by which Core ci parse the .dsc file. Add UINTN in Hob.c to fix cast from pointer to integer of different size error. V2: Delete lines which reference ShellBinPkg.The pkg doesn't exist in edk2. Cc: Guo Dong Cc: Ray Ni Cc: Maurice Ma Cc: Benjamin You Signed-off-by: DunTan Reviewed-by: Ray Ni commit 9f3eda177a4b2d4a33ff1b0307cad42906396562 Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:29:48 2021 +0800 OvmfPkg/OvmfXen: add QemuKernelLoaderFsDxe Without QemuKernelLoaderFsDxe, QemuLoadKernelImage() couldn't download the kernel, initrd, and kernel command line from QEMU's fw_cfg. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3574 Signed-off-by: Gary Lin Acked-by: Anthony PERARD Reviewed-by: Philippe Mathieu-Daude Reviewed-by: Gerd Hoffmann Tested-by: Jim Fehlig commit 5b5f10d7465004e3e40ec1f50a3b490b4db595e7 Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:31:15 2021 +0800 OvmfPkg/SmmControl2Dxe: use PcdAcpiS3Enable to detect S3 support To avoid the potential inconsistency between PcdAcpiS3Enable and QemuFwCfgS3Enabled(), this commit modifies SmmControl2Dxe to detect S3 support by PcdAcpiS3Enable as modules in MdeModulePkg do. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3573 Signed-off-by: Gary Lin Reviewed-by: Gerd Hoffmann Reviewed-by: Jiewen Yao Tested-by: Jim Fehlig commit 52e2dabc0f8d3af09c213072ce8ba734302f585d Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:31:14 2021 +0800 OvmfPkg/PlatformBootManagerLib: use PcdAcpiS3Enable to detect S3 support To avoid the potential inconsistency between PcdAcpiS3Enable and QemuFwCfgS3Enabled(), this commit modifies PlatformBootManagerLib to detect S3 support by PcdAcpiS3Enable as modules in MdeModulePkg do. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3573 Signed-off-by: Gary Lin Reviewed-by: Gerd Hoffmann Reviewed-by: Jiewen Yao Tested-by: Jim Fehlig commit 28152333bccb778b62e6e97446b28bfa0e92ef82 Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:31:13 2021 +0800 OvmfPkg/LockBoxLib: use PcdAcpiS3Enable to detect S3 support To avoid the potential inconsistency between PcdAcpiS3Enable and QemuFwCfgS3Enabled(), this commit modifies LockBoxLib to detect S3 support by PcdAcpiS3Enable as modules in MdeModulePkg do. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3573 Signed-off-by: Gary Lin Reviewed-by: Philippe Mathieu-Daude Reviewed-by: Gerd Hoffmann Reviewed-by: Jiewen Yao Tested-by: Jim Fehlig commit cb0d24637dfdd869618b9635dfb8e3b0746393a6 Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:31:12 2021 +0800 OvmfPkg/OvmfXen: set PcdAcpiS3Enable at initialization There are several functions in OvmfPkg/Library using QemuFwCfgS3Enabled() to detect the S3 support status. However, in MdeModulePkg, PcdAcpiS3Enable is used to check S3 support. Since InitializeXenPlatform() didn't set PcdAcpiS3Enable as InitializePlatform() did, this made the inconsistency between drivers/functions. For example, S3SaveStateDxe checked PcdAcpiS3Enable and skipped S3BootScript because the default value is FALSE. On the other hand, PlatformBootManagerBeforeConsole() from OvmfPkg/Library called QemuFwCfgS3Enabled() and found it returned TRUE, so it invoked SaveS3BootScript(). However, S3SaveStateDxe skipped S3BootScript, so SaveS3BootScript() asserted due to EFI_NOT_FOUND. This issue mainly affects "HVM Direct Kernel Boot". When used, "fw_cfg" is enabled in QEMU and QemuFwCfgS3Enabled() returns true in that case. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3573 Signed-off-by: Gary Lin Reviewed-by: Anthony PERARD Reviewed-by: Gerd Hoffmann Reviewed-by: Jiewen Yao Tested-by: Jim Fehlig From xen-devel-bounces@lists.xenproject.org Thu Sep 02 20:55:46 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 20:55:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177639.323199 (Exim 4.92) (envelope-from ) id 1mLtkD-0000WU-C7; Thu, 02 Sep 2021 20:55:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177639.323199; Thu, 02 Sep 2021 20:55:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLtkD-0000WN-9G; Thu, 02 Sep 2021 20:55:33 +0000 Received: by outflank-mailman (input) for mailman id 177639; Thu, 02 Sep 2021 20:55:32 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLtkB-0000WH-Kt for xen-devel@lists.xenproject.org; Thu, 02 Sep 2021 20:55:32 +0000 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 7e829113-e956-4e45-a777-b310a79e131e; Thu, 02 Sep 2021 20:55:30 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPS id EE4D661054; Thu, 2 Sep 2021 20:55:29 +0000 (UTC) Received: from pdx-korg-docbuild-2.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by pdx-korg-docbuild-2.ci.codeaurora.org (Postfix) with ESMTP id E838260A0C; Thu, 2 Sep 2021 20:55:29 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7e829113-e956-4e45-a777-b310a79e131e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1630616130; bh=FL6WX8B1Oxj9domd5qdIRAc3dG4IkXovTWt6/QvWHg4=; h=Subject:From:In-Reply-To:References:Date:To:Cc:From; b=EeI2FcfmIISJKB3YsGYEiGzci0TVG6yeokjQ6hY2PlF7ONujfcPBgPd4rxc2Xnx3v SAzZI+mOgkvzHltRagDkX2J3ESex3rI99S600hqBlOYwxNvvag1AvoHa9rOuJu/pmo zlYT7dfJi6l6kGaIddacWaLS3u1yRjQAyc+ZPmf1DfE9GVnriV3vPnU54Yq/y91M98 6qx/SQRuGg39uC5hGvSAgNzguYBbKTRhcOhsMoMcVQKHKwt01yK3Tfl5002W2Hm3Jn gyy0+eq6L0w0GTPWBWEBjeXPVMJNURAiGORdCsY0WsXmVwwa1mFcAELOJWqS1ozADB 87Y/D0m2pSgDQ== Subject: Re: [GIT PULL] xen: branch for v5.15-rc1 From: pr-tracker-bot@kernel.org In-Reply-To: <20210902072921.27763-1-jgross@suse.com> References: <20210902072921.27763-1-jgross@suse.com> X-PR-Tracked-List-Id: X-PR-Tracked-Message-Id: <20210902072921.27763-1-jgross@suse.com> X-PR-Tracked-Remote: git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git for-linus-5.15-rc1-tag X-PR-Tracked-Commit-Id: 58e636039b512697554b579c2bb23774061877f5 X-PR-Merge-Tree: torvalds/linux.git X-PR-Merge-Refname: refs/heads/master X-PR-Merge-Commit-Id: 9ae5fceb9a20154d74586fe17d1096b981b23e34 Message-Id: <163061612994.4397.10660862212967182115.pr-tracker-bot@kernel.org> Date: Thu, 02 Sep 2021 20:55:29 +0000 To: Juergen Gross Cc: torvalds@linux-foundation.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, boris.ostrovsky@oracle.com The pull request you sent on Thu, 2 Sep 2021 09:29:21 +0200: > git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git for-linus-5.15-rc1-tag has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/9ae5fceb9a20154d74586fe17d1096b981b23e34 Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html From xen-devel-bounces@lists.xenproject.org Thu Sep 02 20:57:19 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 20:57:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177645.323211 (Exim 4.92) (envelope-from ) id 1mLtlu-00018L-Ob; Thu, 02 Sep 2021 20:57:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177645.323211; Thu, 02 Sep 2021 20:57:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLtlu-00018E-LG; Thu, 02 Sep 2021 20:57:18 +0000 Received: by outflank-mailman (input) for mailman id 177645; Thu, 02 Sep 2021 20:57:17 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLtlt-00017w-Tl; Thu, 02 Sep 2021 20:57:17 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLtlt-0005CH-Kc; Thu, 02 Sep 2021 20:57:17 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLtlt-00028W-8j; Thu, 02 Sep 2021 20:57:17 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mLtlt-0000Qd-8F; Thu, 02 Sep 2021 20:57:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Ozfvfgkec4E6NXTtSL2ngHRd6lu22+HqazEtSwgbGso=; b=hoW80vBZQX3yMRJ+29BaAVTEvo mL4489+GFh1HmlKBFMwrLTN18btsA54Vig4RZZKERiitxHlShhevjS3f9fOOTOn3T82Tg9jCxQ80F DIUlu+qUFaWoxNPtsVcZXwfjM+nDWFUYnDyfvHp+p/OK1cIOfsp4UChc+wdF5g+HXmsg=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 164760: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-i386-xl-qemut-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-examine:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-i386-xl-raw:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-pvshim:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-i386:xen-install:fail:regression linux-linus:test-amd64-i386-xl-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ovmf-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-coresched-i386-xl:xen-install:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit1:debian-fixup:fail:regression linux-linus:test-arm64-arm64-xl-thunderx:debian-fixup:fail:regression linux-linus:test-arm64-arm64-xl:debian-fixup:fail:regression linux-linus:test-arm64-arm64-xl-credit2:debian-fixup:fail:regression linux-linus:test-arm64-arm64-xl-xsm:guest-start:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:debian-fixup:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=4ac6d90867a4de2e12117e755dbd76e08d88697f X-Osstest-Versions-That: linux=deacdb3e3979979016fcd0ffd518c320a62ad166 From: osstest service owner Date: Thu, 02 Sep 2021 20:57:17 +0000 flight 164760 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/164760/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemut-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-examine 6 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-i386-xl-raw 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-pvshim 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-i386 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ovmf-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-coresched-i386-xl 7 xen-install fail REGR. vs. 152332 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 152332 test-arm64-arm64-examine 8 reboot fail REGR. vs. 152332 test-armhf-armhf-xl-arndale 8 xen-boot fail REGR. vs. 152332 test-arm64-arm64-xl-credit1 13 debian-fixup fail REGR. vs. 152332 test-arm64-arm64-xl-thunderx 13 debian-fixup fail REGR. vs. 152332 test-arm64-arm64-xl 13 debian-fixup fail REGR. vs. 152332 test-arm64-arm64-xl-credit2 13 debian-fixup fail REGR. vs. 152332 test-arm64-arm64-xl-xsm 14 guest-start fail REGR. vs. 152332 test-arm64-arm64-libvirt-xsm 13 debian-fixup fail REGR. vs. 152332 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 152332 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 152332 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152332 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152332 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 152332 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152332 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152332 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux 4ac6d90867a4de2e12117e755dbd76e08d88697f baseline version: linux deacdb3e3979979016fcd0ffd518c320a62ad166 Last test of basis 152332 2020-07-31 19:41:23 Z 398 days Failing since 152366 2020-08-01 20:49:34 Z 397 days 687 attempts Testing same since 164760 2021-09-02 09:10:05 Z 0 days 1 attempts ------------------------------------------------------------ 7137 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl fail test-armhf-armhf-xl pass test-amd64-i386-xl fail test-amd64-coresched-i386-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm fail test-amd64-i386-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm fail test-amd64-i386-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine pass test-arm64-arm64-examine fail test-armhf-armhf-examine pass test-amd64-i386-examine fail test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel fail test-amd64-i386-qemuu-rhel6hvm-intel fail test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair fail test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow fail test-arm64-arm64-xl-thunderx fail test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2177664 lines long.) From xen-devel-bounces@lists.xenproject.org Thu Sep 02 20:57:57 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 20:57:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177653.323231 (Exim 4.92) (envelope-from ) id 1mLtmX-0001jy-5R; Thu, 02 Sep 2021 20:57:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177653.323231; Thu, 02 Sep 2021 20:57:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLtmX-0001jr-1U; Thu, 02 Sep 2021 20:57:57 +0000 Received: by outflank-mailman (input) for mailman id 177653; Thu, 02 Sep 2021 20:57:55 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLtmV-0001jY-QG; Thu, 02 Sep 2021 20:57:55 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLtmV-0005Cg-MG; Thu, 02 Sep 2021 20:57:55 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLtmV-0002AX-Ei; Thu, 02 Sep 2021 20:57:55 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mLtmV-0000si-EC; Thu, 02 Sep 2021 20:57:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=3Rbgeq0QRqigDgi3xVkRQ6D9OVmfPgX1xpin9VNOD3U=; b=6TRtFH4dFLJ6nQEBDu63koHRY+ d4Msew1kiXTmU2Fgn9ntQX4tLTvWNzgm+5tGGpi7xuRc7Md5zVvYkHBVnTMrldL0hdWxOk6L8L5um lxXCzkyxULjnvWvnTw6fRilqZKt80d2nkAPQE5x+R32OQRujq/q6eorCreHIX/Dm0LWk=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 164775: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=b6bc203375b6efb6822ee4fe4a59be4f1918436b X-Osstest-Versions-That: ovmf=cae735f61328d64e2e8991036707b9e78c0f5f63 From: osstest service owner Date: Thu, 02 Sep 2021 20:57:55 +0000 flight 164775 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/164775/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 164674 build-amd64-xsm 6 xen-build fail REGR. vs. 164674 build-i386-xsm 6 xen-build fail REGR. vs. 164674 build-i386 6 xen-build fail REGR. vs. 164674 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf b6bc203375b6efb6822ee4fe4a59be4f1918436b baseline version: ovmf cae735f61328d64e2e8991036707b9e78c0f5f63 Last test of basis 164674 2021-08-31 02:56:52 Z 2 days Failing since 164686 2021-09-01 03:03:43 Z 1 days 15 attempts Testing same since 164764 2021-09-02 12:11:21 Z 0 days 3 attempts ------------------------------------------------------------ People who touched revisions under test: Anthony PERARD DunTan Gary Lin Jim Fehlig Lin, Gary (HPS OE-Linux) Loo Tung Lun Loo, Tung Lun Mark Wilson Marvin H?user Wenxing Hou Wenyi Xie jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit b6bc203375b6efb6822ee4fe4a59be4f1918436b Author: Wenyi Xie Date: Thu Aug 26 09:16:03 2021 +0800 MdeModulePkg/HiiDatabaseDxe:remove dead code block As the if statement outside has confirmed that BlockData->Name == NULL, so the if statement inside is always false. Cc: Jian J Wang Cc: Hao A Wu Cc: Dandan Bi Cc: Eric Dong Signed-off-by: Wenyi Xie Reviewed-by: Dandan Bi commit e3ee8c8dbd7a9f7d7905abe17be60354c9f5f9a3 Author: duntan Date: Fri Aug 20 14:43:37 2021 +0800 .azurepipelines: Add UefiPayloadPkg in gate-build-job.yml and CISetting.py Add UefiPayloadPkg in gate-build-job.yml to enable Core ci for UefiPayloadPkg. Add UefiPayloadPkg to supported Packages in CISettings. Cc: Sean Brogan Cc: Bret Barkelew Cc: Michael D Kinney Cc: Liming Gao Signed-off-by: DunTan Reviewed-by: Liming Gao commit 63fddc98e06c380e654b1cfbaf24b9fd922adfad Author: duntan Date: Fri Aug 20 14:43:36 2021 +0800 UefiPayloadPkg: Create .yaml file in UefiPayloadPkg Create .yaml file in UefiPayloadPkg to enable Core ci for UefiPayloadPkg Cc: Guo Dong Cc: Ray Ni Cc: Maurice Ma Cc: Benjamin You Signed-off-by: DunTan Reviewed-by: Liming Gao commit 12e33dca4c0612a0975265e5ba641c6261a26455 Author: Loo, Tung Lun Date: Tue Aug 17 15:43:12 2021 +0800 IntelFsp2Pkg: Support Config File and Binary delta comparison BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3567 This patch is to enable config editor to have a new feature that can spell out the delta between the default configuration files' data, such as YAML and BSF, against the data stored in the binary. This can help users understand and track the difference when modifications are made. Cc: Maurice Ma Cc: Nate DeSimone Cc: Star Zeng Cc: Chasel Chiu Signed-off-by: Loo Tung Lun Reviewed-by: Chasel Chiu commit b170806518c1e414939c8b085866544814e1ce8e Author: Mark Wilson Date: Fri Nov 13 08:05:18 2020 +0800 UefiCpuPkg: Clean up save state boundary checks and comments. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2956 In functions ReadSaveStateRegisterByIndex and WriteSaveStateRegister: * check width > 4 instead of >= 4 when writing upper 32 bytes. - This improves the code but will not affect functionality. Cc: Eric Dong Reviewed-by: Ray Ni Signed-off-by: Mark Wilson commit 3b3f88228812e2c642eea8746858a4dad928ebf7 Author: Marvin H?user Date: Mon Aug 9 14:09:25 2021 +0800 MdeModulePkg/PiSmmCore: Drop deprecated image profiling commands The legacy codebase allowed SMM images to be registered for profiling from DXE. Support for this has been dropped entirely, so remove the remaining handlers. Cc: Jian J Wang Cc: Hao A Wu Cc: Eric Dong Reviewed-by: Ray Ni Cc: Vitaly Cheptsov Signed-off-by: Marvin H?user commit cdda3f74a1327663a5d48cca13507085ba403af7 Author: Marvin H?user Date: Mon Aug 9 03:39:53 2021 +0800 UefiPayloadPkg/UefiPayloadEntry: Fix memory corruption UefiPayloadEntry's AllocatePool() applies the "sizeof" operator to HOB index rather than the HOB header structure. This yields 4 Bytes compared to the 8 Bytes the structure header requires. Fix the call to allocate the required space instead. Reviewed-by: Guo Dong Reviewed-by: Ray Ni Cc: Maurice Ma Cc: Benjamin You Cc: Vitaly Cheptsov Signed-off-by: Marvin H?user commit 5d34cc49d5d348012fe8acf9fb618826bd541a7c Author: Wenxing Hou Date: Tue Aug 24 16:11:11 2021 +0800 UefiCpuPkg/PiSmmCpuDxeSmm: Update mPatchCetSupported set condition REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3584 Function AsmCpuid should first check the value for Basic CPUID Information. The fix is to update the mPatchCetSupported judgment statement. Signed-off-by: Wenxing Hou Reviewed-by: Ray Ni Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Cc: Sheng W Cc: Yao Jiewen commit f0fe55bca4651734abf1752a1d7c69fb5bee00b9 Author: duntan Date: Fri Aug 20 13:04:29 2021 +0800 UefiPayloadPkg: Fix the build error when enable Core ci for UefiPayloadPkg V1: Add quotes when using $(ARCH) in .dsc and .fdf file. The quotes are added due to the way by which Core ci parse the .dsc file. Add UINTN in Hob.c to fix cast from pointer to integer of different size error. V2: Delete lines which reference ShellBinPkg.The pkg doesn't exist in edk2. Cc: Guo Dong Cc: Ray Ni Cc: Maurice Ma Cc: Benjamin You Signed-off-by: DunTan Reviewed-by: Ray Ni commit 9f3eda177a4b2d4a33ff1b0307cad42906396562 Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:29:48 2021 +0800 OvmfPkg/OvmfXen: add QemuKernelLoaderFsDxe Without QemuKernelLoaderFsDxe, QemuLoadKernelImage() couldn't download the kernel, initrd, and kernel command line from QEMU's fw_cfg. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3574 Signed-off-by: Gary Lin Acked-by: Anthony PERARD Reviewed-by: Philippe Mathieu-Daude Reviewed-by: Gerd Hoffmann Tested-by: Jim Fehlig commit 5b5f10d7465004e3e40ec1f50a3b490b4db595e7 Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:31:15 2021 +0800 OvmfPkg/SmmControl2Dxe: use PcdAcpiS3Enable to detect S3 support To avoid the potential inconsistency between PcdAcpiS3Enable and QemuFwCfgS3Enabled(), this commit modifies SmmControl2Dxe to detect S3 support by PcdAcpiS3Enable as modules in MdeModulePkg do. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3573 Signed-off-by: Gary Lin Reviewed-by: Gerd Hoffmann Reviewed-by: Jiewen Yao Tested-by: Jim Fehlig commit 52e2dabc0f8d3af09c213072ce8ba734302f585d Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:31:14 2021 +0800 OvmfPkg/PlatformBootManagerLib: use PcdAcpiS3Enable to detect S3 support To avoid the potential inconsistency between PcdAcpiS3Enable and QemuFwCfgS3Enabled(), this commit modifies PlatformBootManagerLib to detect S3 support by PcdAcpiS3Enable as modules in MdeModulePkg do. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3573 Signed-off-by: Gary Lin Reviewed-by: Gerd Hoffmann Reviewed-by: Jiewen Yao Tested-by: Jim Fehlig commit 28152333bccb778b62e6e97446b28bfa0e92ef82 Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:31:13 2021 +0800 OvmfPkg/LockBoxLib: use PcdAcpiS3Enable to detect S3 support To avoid the potential inconsistency between PcdAcpiS3Enable and QemuFwCfgS3Enabled(), this commit modifies LockBoxLib to detect S3 support by PcdAcpiS3Enable as modules in MdeModulePkg do. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3573 Signed-off-by: Gary Lin Reviewed-by: Philippe Mathieu-Daude Reviewed-by: Gerd Hoffmann Reviewed-by: Jiewen Yao Tested-by: Jim Fehlig commit cb0d24637dfdd869618b9635dfb8e3b0746393a6 Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:31:12 2021 +0800 OvmfPkg/OvmfXen: set PcdAcpiS3Enable at initialization There are several functions in OvmfPkg/Library using QemuFwCfgS3Enabled() to detect the S3 support status. However, in MdeModulePkg, PcdAcpiS3Enable is used to check S3 support. Since InitializeXenPlatform() didn't set PcdAcpiS3Enable as InitializePlatform() did, this made the inconsistency between drivers/functions. For example, S3SaveStateDxe checked PcdAcpiS3Enable and skipped S3BootScript because the default value is FALSE. On the other hand, PlatformBootManagerBeforeConsole() from OvmfPkg/Library called QemuFwCfgS3Enabled() and found it returned TRUE, so it invoked SaveS3BootScript(). However, S3SaveStateDxe skipped S3BootScript, so SaveS3BootScript() asserted due to EFI_NOT_FOUND. This issue mainly affects "HVM Direct Kernel Boot". When used, "fw_cfg" is enabled in QEMU and QemuFwCfgS3Enabled() returns true in that case. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3573 Signed-off-by: Gary Lin Reviewed-by: Anthony PERARD Reviewed-by: Gerd Hoffmann Reviewed-by: Jiewen Yao Tested-by: Jim Fehlig From xen-devel-bounces@lists.xenproject.org Thu Sep 02 21:23:54 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 21:23:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177664.323245 (Exim 4.92) (envelope-from ) id 1mLuBZ-0005X6-Dy; Thu, 02 Sep 2021 21:23:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177664.323245; Thu, 02 Sep 2021 21:23:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLuBZ-0005Wz-AB; Thu, 02 Sep 2021 21:23:49 +0000 Received: by outflank-mailman (input) for mailman id 177664; Thu, 02 Sep 2021 21:23:48 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLuBY-0005Wt-95 for xen-devel@lists.xenproject.org; Thu, 02 Sep 2021 21:23:48 +0000 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 0ea52c56-0c34-11ec-aecd-12813bfff9fa; Thu, 02 Sep 2021 21:23:46 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id F27E061074; Thu, 2 Sep 2021 21:23:45 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0ea52c56-0c34-11ec-aecd-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1630617826; bh=R33NS/1KqtwH0usN9pB4gLg6GNUdRpCt3mNX/jS3mZM=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=MEZ7nPh1YPE7bCire3PR2zog3wSb2lf6ddATIHdxyB2iVOvpOx44Z9ZFp/7EroCgC 9ZB/0fnsZPWOa5ZKLNElEoix/w5sJJ/zi59pArg6PtjVZQA1gGzV3d9dOjuvYs5gwn hbtnggg5kB1g4WAneYP1eHdKA0YVtOw1seGp7pSE0xVYN9GSjltypXLq2vPd9IgCaw Yuxii+rZkCFfyVh87Uj0dr429n2YdlVPp5+dZrr5/yHDyurFz3ie3DoP0hxN0zQpdD cG87q2eadWrsYx48OaJZUje5aLmLMPX2f+rxAn4XBrtMHsolRTiHQXpOaMg+WCeE09 LUoGVzi9Z/ibw== Date: Thu, 2 Sep 2021 14:23:39 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: Penny Zheng cc: xen-devel@lists.xenproject.org, sstabellini@kernel.org, julien@xen.org, Bertrand.Marquis@arm.com, Wei.Chen@arm.com, nd@arm.com Subject: Re: [PATCH v5 4/7] xen/arm: static memory initialization In-Reply-To: <20210824095045.2281500-5-penny.zheng@arm.com> Message-ID: References: <20210824095045.2281500-1-penny.zheng@arm.com> <20210824095045.2281500-5-penny.zheng@arm.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Tue, 24 Aug 2021, Penny Zheng wrote: > This patch introduces static memory initialization, during system boot up. > > The new function init_staticmem_pages is responsible for static memory > initialization. > > Helper free_staticmem_pages is the equivalent of free_heap_pages, to free > nr_mfns pages of static memory. > > This commit also introduces new CONFIG_STATIC_MEMORY to wrap all ^ a ^ option > static-allocation-related codes. ^ code > Put asynchronous scrubbing for pages of static memory in TODO list. > > Signed-off-by: Penny Zheng > --- > v5 change: > - make CONFIG_STATIC_MEMORY user selectable and gated by UNSUPPORTED. > - wrap all static-allocation-related codes with CONFIG_STATIC_MEMORY > even in arm-specific file. > - make bank_start/bank_end type of mfn_t, and rename bank_size to > bank_pages. > --- > xen/arch/arm/setup.c | 31 +++++++++++++++++++++++++++++++ > xen/common/Kconfig | 17 +++++++++++++++++ > xen/common/page_alloc.c | 22 +++++++++++++++++++++- > xen/include/xen/mm.h | 6 ++++++ > 4 files changed, 75 insertions(+), 1 deletion(-) > > diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c > index 63a908e325..44aca9f1b9 100644 > --- a/xen/arch/arm/setup.c > +++ b/xen/arch/arm/setup.c > @@ -609,6 +609,29 @@ static void __init init_pdx(void) > } > } > > +#ifdef CONFIG_STATIC_MEMORY > +/* Static memory initialization */ > +static void __init init_staticmem_pages(void) > +{ > + unsigned int bank; > + > + for ( bank = 0 ; bank < bootinfo.reserved_mem.nr_banks; bank++ ) > + { > + if ( bootinfo.reserved_mem.bank[bank].xen_domain ) > + { > + mfn_t bank_start = _mfn(PFN_UP(bootinfo.reserved_mem.bank[bank].start)); > + unsigned long bank_pages = PFN_DOWN(bootinfo.reserved_mem.bank[bank].size); > + mfn_t bank_end = mfn_add(bank_start, bank_pages); > + > + if ( mfn_x(bank_end) <= mfn_x(bank_start) ) > + return; > + > + free_staticmem_pages(mfn_to_page(bank_start), bank_pages, false); > + } > + } > +} > +#endif > + > #ifdef CONFIG_ARM_32 > static void __init setup_mm(void) > { > @@ -736,6 +759,10 @@ static void __init setup_mm(void) > /* Add xenheap memory that was not already added to the boot allocator. */ > init_xenheap_pages(mfn_to_maddr(xenheap_mfn_start), > mfn_to_maddr(xenheap_mfn_end)); > + > +#ifdef CONFIG_STATIC_MEMORY > + init_staticmem_pages(); > +#endif > } > #else /* CONFIG_ARM_64 */ > static void __init setup_mm(void) > @@ -789,6 +816,10 @@ static void __init setup_mm(void) > > setup_frametable_mappings(ram_start, ram_end); > max_page = PFN_DOWN(ram_end); > + > +#ifdef CONFIG_STATIC_MEMORY > + init_staticmem_pages(); > +#endif > } > #endif > > diff --git a/xen/common/Kconfig b/xen/common/Kconfig > index 0ddd18e11a..514a2c9022 100644 > --- a/xen/common/Kconfig > +++ b/xen/common/Kconfig > @@ -67,6 +67,23 @@ config MEM_ACCESS > config NEEDS_LIBELF > bool > > +config STATIC_MEMORY > + bool "Static Allocation Support (UNSUPPORTED)" if UNSUPPORTED > + depends on ARM > + ---help--- > + Static Allocation refers to system or sub-system(domains) for > + which memory areas are pre-defined by configuration using physical > + address ranges. > + > + Those pre-defined memory, -- Static Memory, as parts of RAM reserved > + during system boot-up, shall never go to heap allocator or boot > + allocator for any use. > + > + When enabled, memory can be statically allocated to a domain using > + the property "xen,static-mem" defined in the domain configuration. > + > + If unsure, say Y. I share Jan's comment about indentation, the kconfig message and the little spurious change below. Aside from those, this patch looks fine to me. From xen-devel-bounces@lists.xenproject.org Thu Sep 02 21:30:57 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 21:30:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177670.323255 (Exim 4.92) (envelope-from ) id 1mLuIP-0006uo-4b; Thu, 02 Sep 2021 21:30:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177670.323255; Thu, 02 Sep 2021 21:30:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLuIP-0006uh-1M; Thu, 02 Sep 2021 21:30:53 +0000 Received: by outflank-mailman (input) for mailman id 177670; Thu, 02 Sep 2021 21:30:51 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLuIN-0006ub-3k for xen-devel@lists.xenproject.org; Thu, 02 Sep 2021 21:30:51 +0000 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 0aa8547e-0c35-11ec-aece-12813bfff9fa; Thu, 02 Sep 2021 21:30:49 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id BDEE4610E6; Thu, 2 Sep 2021 21:30:48 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0aa8547e-0c35-11ec-aece-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1630618249; bh=SLLuobHZM2VYjHSWMTHYRwcUffU8KYJOq5ruqibBR64=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=f8FK93V2OYaaKdFvFnGFaHEAexfiuTJGZY97ZPySQ0CYfgMPs5/7QLlJLNCFtGSqr V6rGbaRAlheJA3Abr6uN2DVei8eP3/Ts4SsIttdw7TfJCh/DgO6VbcCW447AUQbvZM ph2xIHLoyjVrwLqPjl2M6tKtsDk8FG8jNq6N/jqnzeg1Svt+KdDWqtC8/16ttbDp9W +b5XgW9bHlUj/dVJvOYZgUOFJt1dkuDJlS5jA2lhV20CbHBAYYj817eKDl01853ukn w9R35gjESE5s3VPcnD96mB8XGlBeEivZVRtRMW9iAbX4pytLLhfLeS4zhV2ON7dkHN cdJMoQML2ULsg== Date: Thu, 2 Sep 2021 14:30:48 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: Penny Zheng cc: xen-devel@lists.xenproject.org, sstabellini@kernel.org, julien@xen.org, Bertrand.Marquis@arm.com, Wei.Chen@arm.com, nd@arm.com Subject: Re: [PATCH v5 2/7] xen/arm: introduce domain on Static Allocation In-Reply-To: <20210824095045.2281500-3-penny.zheng@arm.com> Message-ID: References: <20210824095045.2281500-1-penny.zheng@arm.com> <20210824095045.2281500-3-penny.zheng@arm.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Tue, 24 Aug 2021, Penny Zheng wrote: > Static Allocation refers to system or sub-system(domains) for which memory > areas are pre-defined by configuration using physical address ranges. > Those pre-defined memory, -- Static Memory, as parts of RAM reserved in the > beginning, shall never go to heap allocator or boot allocator for any use. > > Memory can be statically allocated to a domain using the property "xen,static- > mem" defined in the domain configuration. The number of cells for the address > and the size must be defined using respectively the properties > "#xen,static-mem-address-cells" and "#xen,static-mem-size-cells". > > This patch introduces this new `xen,static-mem` feature, and also documents > and parses this new attribute at boot time. > > This patch also introduces a new field "bool xen_domain" in "struct membank" > to tell the difference of one memory bank is reserved as the whole > hardware resource, or bind to one specific xen domain node, through > "xen,static-mem" > > Signed-off-by: Penny Zheng > --- > v5 changes: > - check the node using the Xen domain binding whether contains the property > "xen,static-mem", not the property itself > - add "rc = ..." to get the error propagated > - introduce new field "bool xen_domain", then static memory shall be also stored > as reserved memory(bootinfo.reserved_mem), but being bind to one > specific Xen domain node. > - doc refinement > --- > docs/misc/arm/device-tree/booting.txt | 33 ++++++++++++++++++++++++ > xen/arch/arm/bootfdt.c | 36 +++++++++++++++++++++++++-- > xen/include/asm-arm/setup.h | 1 + > 3 files changed, 68 insertions(+), 2 deletions(-) > > diff --git a/docs/misc/arm/device-tree/booting.txt b/docs/misc/arm/device-tree/booting.txt > index 5243bc7fd3..95b20ddc3a 100644 > --- a/docs/misc/arm/device-tree/booting.txt > +++ b/docs/misc/arm/device-tree/booting.txt > @@ -268,3 +268,36 @@ The DTB fragment is loaded at 0xc000000 in the example above. It should > follow the convention explained in docs/misc/arm/passthrough.txt. The > DTB fragment will be added to the guest device tree, so that the guest > kernel will be able to discover the device. > + > + > +Static Allocation > +============= > + > +Static Allocation refers to system or sub-system(domains) for which memory > +areas are pre-defined by configuration using physical address ranges. > + > +Memory can be statically allocated to a domain using the property "xen,static- > +mem" defined in the domain configuration. The number of cells for the address > +and the size must be defined using respectively the properties > +"#xen,static-mem-address-cells" and "#xen,static-mem-size-cells". > + > +Below is an example on how to specify the static memory region in the > +device-tree: > + > + / { > + chosen { > + domU1 { > + compatible = "xen,domain"; > + #address-cells = <0x2>; > + #size-cells = <0x2>; > + cpus = <2>; > + #xen,static-mem-address-cells = <0x1>; > + #xen,static-mem-size-cells = <0x1>; > + xen,static-mem = <0x30000000 0x20000000>; > + ... > + }; > + }; > + }; > + > +This will reserve a 512MB region starting at the host physical address > +0x30000000 to be exclusively used by DomU1 This binding is OK. We might want to clarify what is the purpose of the "memory" property when "xen,static-mem" is present. I would suggest to write that when "xen,static-mem" is present, the "memory" property becomes optional. Or even better: """ When present, the xen,static-mem property supersedes the memory property. """ In the future when Xen will support direct mapping, I assume that we'll also add a direct-map property to enable it. Something like: domU1 { compatible = "xen,domain"; #address-cells = <0x2>; #size-cells = <0x2>; cpus = <2>; #xen,static-mem-address-cells = <0x1>; #xen,static-mem-size-cells = <0x1>; xen,static-mem = <0x30000000 0x20000000>; direct-map; ... }; Maybe I would add a statement to clarify it that xen,static-mem doesn't automatically imply direct mapping. Something like: """ The static memory will be mapped in the guest at the usual guest memory addresses (GUEST_RAM0_BASE, GUEST_RAM1_BASE) defined by xen/include/public/arch-arm.h. """ The rest of the patch looks OK. One minor NIT below. > diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c > index 8c81be3379..00f34eec58 100644 > --- a/xen/arch/arm/bootfdt.c > +++ b/xen/arch/arm/bootfdt.c > @@ -66,7 +66,7 @@ void __init device_tree_get_reg(const __be32 **cell, u32 address_cells, > static int __init device_tree_get_meminfo(const void *fdt, int node, > const char *prop_name, > u32 address_cells, u32 size_cells, > - void *data) > + void *data, bool xen_domain) > { > const struct fdt_property *prop; > unsigned int i, banks; > @@ -90,6 +90,7 @@ static int __init device_tree_get_meminfo(const void *fdt, int node, > continue; > mem->bank[mem->nr_banks].start = start; > mem->bank[mem->nr_banks].size = size; > + mem->bank[mem->nr_banks].xen_domain = xen_domain; > mem->nr_banks++; > } > > @@ -184,7 +185,8 @@ static int __init process_memory_node(const void *fdt, int node, > return -EINVAL; > } > > - return device_tree_get_meminfo(fdt, node, "reg", address_cells, size_cells, data); > + return device_tree_get_meminfo(fdt, node, "reg", address_cells, size_cells, > + data, false); > } > > static int __init process_reserved_memory_node(const void *fdt, int node, > @@ -338,6 +340,34 @@ static void __init process_chosen_node(const void *fdt, int node, > add_boot_module(BOOTMOD_RAMDISK, start, end-start, false); > } > > +static int __init process_domain_node(const void *fdt, int node, > + const char *name, > + u32 address_cells, u32 size_cells) > +{ > + const struct fdt_property *prop; > + > + printk("Checking for \"xen,static-mem\" in domain node\n"); > + > + prop = fdt_get_property(fdt, node, "xen,static-mem", NULL); > + if ( !prop ) > + /* No "xen,static-mem" present. */ > + return 0; > + > + address_cells = device_tree_get_u32(fdt, node, > + "#xen,static-mem-address-cells", 0); > + size_cells = device_tree_get_u32(fdt, node, > + "#xen,static-mem-size-cells", 0); > + if ( address_cells < 1 || size_cells < 1 ) > + { > + printk("fdt: node `%s': invalid #xen,static-mem-address-cells or #xen,static-mem-size-cells", > + name); > + return -EINVAL; > + } > + > + return device_tree_get_meminfo(fdt, node, "xen,static-mem", address_cells, > + size_cells, &bootinfo.reserved_mem, true); > +} > + > static int __init early_scan_node(const void *fdt, > int node, const char *name, int depth, > u32 address_cells, u32 size_cells, > @@ -356,6 +386,8 @@ static int __init early_scan_node(const void *fdt, > process_multiboot_node(fdt, node, name, address_cells, size_cells); > else if ( depth == 1 && device_tree_node_matches(fdt, node, "chosen") ) > process_chosen_node(fdt, node, name, address_cells, size_cells); > + else if ( depth == 2 && device_tree_node_compatible(fdt, node, "xen,domain") ) > + rc = process_domain_node(fdt, node, name, address_cells, size_cells); > > if ( rc < 0 ) > printk("fdt: node `%s': parsing failed\n", name); > diff --git a/xen/include/asm-arm/setup.h b/xen/include/asm-arm/setup.h > index c4b6af6029..6c3c16294b 100644 > --- a/xen/include/asm-arm/setup.h > +++ b/xen/include/asm-arm/setup.h > @@ -24,6 +24,7 @@ typedef enum { > struct membank { > paddr_t start; > paddr_t size; > + bool xen_domain; /* whether memory bank is bind to Xen domain. */ ^ a or the ^ bound to a > }; > > struct meminfo { > -- > 2.25.1 > From xen-devel-bounces@lists.xenproject.org Thu Sep 02 21:33:01 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 21:33:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177676.323267 (Exim 4.92) (envelope-from ) id 1mLuKS-0007jO-IT; Thu, 02 Sep 2021 21:33:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177676.323267; Thu, 02 Sep 2021 21:33:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLuKS-0007jH-Ee; Thu, 02 Sep 2021 21:33:00 +0000 Received: by outflank-mailman (input) for mailman id 177676; Thu, 02 Sep 2021 21:32:59 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLuKR-0007j9-TD for xen-devel@lists.xenproject.org; Thu, 02 Sep 2021 21:32:59 +0000 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id f6592c34-d9a2-40a2-b6a0-1a0503a3100e; Thu, 02 Sep 2021 21:32:58 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id D407F610CF; Thu, 2 Sep 2021 21:32:57 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f6592c34-d9a2-40a2-b6a0-1a0503a3100e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1630618378; bh=JBVvt8Y6dkmWs3GjjhGwiKm8mGMVJul8P/KSTHyo6b8=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=MtQ63zamEkOawpGx/Bo84fL7I2zWCVpgiF+veZhOMBxGxwGwqIOpOkMFQmZ6TzQcw 7/Wp/PTF6HWYVm8ViHtvpb2c4iqFTrgqM7WtcDgjj6xwMRjxCJr8bbHzFv7Wb682ve 0EvdiZHH3pKRw3AHPQAxcaDXu0JOygek2A4pS5dhjYoCtA/SJQko+oAPNS2GTMSAkm Kj7jQUKfCulYbp3mGmMfnOSGLPvKcJqGIrnz/BPutTKfnmvowWrNtNUKpj6shIvEw0 sQf9UMq7DSMyUHtXa3Yl6EKnhhEz+lVuslC4eyt+KKwehNTlbo9CeFgN4DuKhy1BtT J94VukGA1+Zew== Date: Thu, 2 Sep 2021 14:32:57 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: Penny Zheng cc: xen-devel@lists.xenproject.org, sstabellini@kernel.org, julien@xen.org, Bertrand.Marquis@arm.com, Wei.Chen@arm.com, nd@arm.com Subject: Re: [PATCH v5 7/7] xen/arm: introduce allocate_static_memory In-Reply-To: <20210824095045.2281500-8-penny.zheng@arm.com> Message-ID: References: <20210824095045.2281500-1-penny.zheng@arm.com> <20210824095045.2281500-8-penny.zheng@arm.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Tue, 24 Aug 2021, Penny Zheng wrote: > This commit introduces allocate_static_memory to allocate static memory as > guest RAM for Domain on Static Allocation. > > It uses acquire_domstatic_pages to acquire pre-configured static memory > for this domain, and uses guest_physmap_add_pages to set up P2M table. > These pre-defined static memory banks shall be mapped to the fixed guest RAM > banks. And only when they exhausts the current guest RAM bank, it will seek > to the next one. > > In order to deal with the trouble of count-to-order conversion when page number > is not in a power-of-two, this commit exports p2m_insert_mapping and introduce > a new function guest_physmap_add_pages to cope with adding guest RAM p2m > mapping with nr_pages. > > Signed-off-by: Penny Zheng > --- > v5 changes: > - don't split comment over multi-line (even they are more than 80 characters) > - simply use dt_find_property(node, "xen,static-mem", NULL) to tell > whether using allocate_static_memory, and add error comment when > "xen,static-mem" is used but CONFIG_STATIC_MEMORY is not enabled. > - exporting p2m_insert_mapping() and introduce guest_physmap_add_pages > to cope with adding guest RAM p2m mapping with nr_pages. > - check both pbase and psize are page aligned > - simplify the code in the loops by moving append_static_memory_to_bank() > outside of the if/else. > --- > xen/arch/arm/domain_build.c | 156 +++++++++++++++++++++++++++++++++++- > xen/arch/arm/p2m.c | 7 +- > xen/include/asm-arm/p2m.h | 11 +++ > 3 files changed, 168 insertions(+), 6 deletions(-) > > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c > index 6c86d52781..843b8514c7 100644 > --- a/xen/arch/arm/domain_build.c > +++ b/xen/arch/arm/domain_build.c > @@ -480,6 +480,148 @@ fail: > (unsigned long)kinfo->unassigned_mem >> 10); > } > > +#ifdef CONFIG_STATIC_MEMORY > +static bool __init append_static_memory_to_bank(struct domain *d, > + struct membank *bank, > + mfn_t smfn, > + paddr_t size) > +{ > + int res; > + unsigned int nr_pages = size >> PAGE_SHIFT; ^ PFN_DOWN > + /* Infer next GFN. */ > + gfn_t sgfn = gaddr_to_gfn(bank->start + bank->size); > + > + res = guest_physmap_add_pages(d, sgfn, smfn, nr_pages); > + if ( res ) > + { > + dprintk(XENLOG_ERR, "Failed to map pages to DOMU: %d", res); > + return false; > + } > + > + bank->size = bank->size + size; > + > + return true; > +} > + > +/* Allocate memory from static memory as RAM for one specific domain d. */ > +static void __init allocate_static_memory(struct domain *d, > + struct kernel_info *kinfo, > + const struct dt_device_node *node) > +{ > + const struct dt_property *prop; > + u32 addr_cells, size_cells, reg_cells; > + unsigned int nr_banks, gbank = 0, bank = 0; > + const uint64_t rambase[] = GUEST_RAM_BANK_BASES; > + const uint64_t ramsize[] = GUEST_RAM_BANK_SIZES; > + const __be32 *cell; > + u64 tot_size = 0; > + paddr_t pbase, psize, gsize; > + mfn_t smfn; > + int res; > + > + prop = dt_find_property(node, "xen,static-mem", NULL); > + if ( !dt_property_read_u32(node, "#xen,static-mem-address-cells", > + &addr_cells) ) > + { > + printk(XENLOG_ERR > + "%pd: failed to read \"#xen,static-mem-address-cells\".\n", d); > + goto fail; > + } > + > + if ( !dt_property_read_u32(node, "#xen,static-mem-size-cells", > + &size_cells) ) > + { > + printk(XENLOG_ERR > + "%pd: failed to read \"#xen,static-mem-size-cells\".\n", d); > + goto fail; > + } > + reg_cells = addr_cells + size_cells; > + > + /* Start with GUEST_RAM0. */ > + gsize = ramsize[gbank]; > + kinfo->mem.bank[gbank].start = rambase[gbank]; > + > + cell = (const __be32 *)prop->value; > + nr_banks = (prop->length) / (reg_cells * sizeof (u32)); > + > + for ( ; bank < nr_banks; bank++ ) > + { > + device_tree_get_reg(&cell, addr_cells, size_cells, &pbase, &psize); > + ASSERT(IS_ALIGNED(pbase, PAGE_SIZE) && IS_ALIGNED(psize, PAGE_SIZE)); > + > + smfn = maddr_to_mfn(pbase); > + res = acquire_domstatic_pages(d, smfn, psize >> PAGE_SHIFT, 0); ^ PFN_DOWN(psize) > + if ( res ) > + { > + printk(XENLOG_ERR > + "%pd: failed to acquire static memory: %d.\n", d, res); > + goto fail; > + } > + > + printk(XENLOG_INFO "%pd: STATIC BANK[%u] %#"PRIpaddr"-%#"PRIpaddr"\n", > + d, bank, pbase, pbase + psize); > + > + /* > + * It shall be mapped to the fixed guest RAM banks(GUEST_RAM_BANK_BASES), > + * And only when it exhausts the current guest RAM bank, it will seek > + * to the next. > + */ > + while ( 1 ) > + { > + /* Map as much as possible the static range to the guest bank */ > + if ( !append_static_memory_to_bank(d, &kinfo->mem.bank[gbank], smfn, > + min(psize, gsize)) ) > + goto fail; > + > + /* > + * The current physical bank is fully mapped. > + * Handle the next physical bank. > + */ > + if ( gsize >= psize ) > + { > + gsize = gsize - psize; > + break; > + } > + /* > + * When current guest bank size is not enough to map. > + * Before seeking to the next, check if we still have available > + * guest bank. > + */ > + else if ( (gbank + 1) >= GUEST_RAM_BANKS ) > + { > + printk(XENLOG_ERR "Exhausted all fixed guest banks.\n"); > + goto fail; > + } > + else > + { > + psize = psize - gsize; > + smfn = mfn_add(smfn, gsize >> PAGE_SHIFT); ^ PFN_DOWN > + /* Update to the next guest bank. */ > + gbank++; > + gsize = ramsize[gbank]; > + kinfo->mem.bank[gbank].start = rambase[gbank]; > + } > + } > + > + tot_size += psize; > + } > + > + kinfo->mem.nr_banks = ++gbank; > + kinfo->unassigned_mem -= tot_size; > + if ( kinfo->unassigned_mem ) > + { > + printk(XENLOG_ERR > + "Size of \"memory\" property doesn't match up with the sum-up of \"xen,static-mem\".\n"); > + goto fail; Do we need to make this a fatal failure? I am asking because unassigned_mem comes from the "memory" property of the domain in device tree which is kind of redundant with the introduction of xen,static-mem. In fact, I think it would be better to clarify the role of "memory" when "xen,static-mem" is also present. In that case, we could even make "memory" optional. In any case, even if we don't make "memory" optional, it might still be good to turn this error into a warning and ignore the remaining kinfo->unassigned_mem. > + } > + > + return; > + > +fail: > + panic("Failed to allocate requested static memory for domain %pd.", d); > +} > +#endif > + > static int __init write_properties(struct domain *d, struct kernel_info *kinfo, > const struct dt_device_node *node) > { > @@ -2452,7 +2594,19 @@ static int __init construct_domU(struct domain *d, > /* type must be set before allocate memory */ > d->arch.type = kinfo.type; > #endif > - allocate_memory(d, &kinfo); > + if ( !dt_find_property(node, "xen,static-mem", NULL) ) > + allocate_memory(d, &kinfo); > +#ifdef CONFIG_STATIC_MEMORY > + else > + allocate_static_memory(d, &kinfo, node); > +#else > + else > + { > + printk(XENLOG_ERR > + "CONFIG_STATIC_MEMORY must be enabled to use \"xen,static-mem\".\n"); > + return -EINVAL; > + } > +#endif To avoid the double else in the code, this part could be written like this which is a bit simpler I think: if ( !dt_find_property(node, "xen,static-mem", NULL) ) allocate_memory(d, &kinfo); else { #ifdef CONFIG_STATIC_MEMORY allocate_static_memory(d, &kinfo, node); #else printk(XENLOG_ERR "CONFIG_STATIC_MEMORY must be enabled to use \"xen,static-mem\".\n"); return -EINVAL; #endif } This is just a suggestion to improve readability, I am also OK with what you wrote. (Another alternative would be to provide a stub allocate_static_memory implementation for !CONFIG_STATIC_MEMORY.) From xen-devel-bounces@lists.xenproject.org Thu Sep 02 21:33:34 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 21:33:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177681.323277 (Exim 4.92) (envelope-from ) id 1mLuKz-0008I8-RG; Thu, 02 Sep 2021 21:33:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177681.323277; Thu, 02 Sep 2021 21:33:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLuKz-0008I1-ON; Thu, 02 Sep 2021 21:33:33 +0000 Received: by outflank-mailman (input) for mailman id 177681; Thu, 02 Sep 2021 21:33:32 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLuKy-0008Hr-Qq for xen-devel@lists.xenproject.org; Thu, 02 Sep 2021 21:33:32 +0000 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id d28cab53-46fe-448d-aef2-2bc219758426; Thu, 02 Sep 2021 21:33:32 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 48F6A610CF; Thu, 2 Sep 2021 21:33:31 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d28cab53-46fe-448d-aef2-2bc219758426 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1630618411; bh=iI+f+PiR3CEK6K0nqtCXsTZumkL7k+UZRF03zicNu5I=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=jDOKDKMwyschsIyb505laIpMeD4OziXeu/U7R0ZbkabCj7drfHt/n5Vo8Xn1pFJU0 zxDu8hFfYGoRm2aCVxMgpMTp3HeXeGhU2CMaw69BsCu4QHm8jBhCJtEc/rpkx5pHQ3 u0Wund2RJDa01U1cOfRZxoDKZ5aAOyyUA401+5HnNd+pg6/i1TMUR/BdqYu76d0zGr mlmG7e8nkvrvCuVFtWaVMMJyxDeOSIO8QKxbRjCs9zCFfIm+it9wtxEJFjbvAi6d/u Axs7189/XKBNLDk+F6rPeDZdbUUboDWLH715F78x6ugSLq4nnPAzPuGrH7BSsfuzgB VW38OfvxMIKig== Date: Thu, 2 Sep 2021 14:33:30 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: Penny Zheng cc: xen-devel@lists.xenproject.org, sstabellini@kernel.org, julien@xen.org, Bertrand.Marquis@arm.com, Wei.Chen@arm.com, nd@arm.com Subject: Re: [PATCH v5 0/7] Domain on Static Allocation In-Reply-To: <20210824095045.2281500-1-penny.zheng@arm.com> Message-ID: References: <20210824095045.2281500-1-penny.zheng@arm.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Tue, 24 Aug 2021, Penny Zheng wrote: > Static Allocation refers to system or sub-system(domains) for which memory > areas are pre-defined by configuration using physical address ranges. > Those pre-defined memory, -- Static Memory, as parts of RAM reserved in the > beginning, shall never go to heap allocator or boot allocator for any use. > > Memory can be statically allocated to a domain using the property "xen,static- > mem" defined in the domain configuration. The number of cells for the address > and the size must be defined using respectively the properties > "#xen,static-mem-address-cells" and "#xen,static-mem-size-cells". > > This Patch Serie only talks about Domain on Static Allocation. > > Looking into related [design link]( > https://lists.xenproject.org/archives/html/xen-devel/2021-05/msg00882.html) > for more details. > > The whole design is about Static Allocation and 1:1 direct-map, and this > Patch Serie only covers parts of it, which are Domain on Static Allocation. > Other features will be delievered through different patch series. I reviewed the whole series and I think it is in great shape and really close to be committed. Probably the series only needs one more update and I think we should target the 4.16 release. I haven't replied to all patches because I agree with Julien and Jan's comments and everything else looked fine. From xen-devel-bounces@lists.xenproject.org Thu Sep 02 21:52:48 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 21:52:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177689.323289 (Exim 4.92) (envelope-from ) id 1mLudV-0002dF-LF; Thu, 02 Sep 2021 21:52:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177689.323289; Thu, 02 Sep 2021 21:52:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLudV-0002d8-IG; Thu, 02 Sep 2021 21:52:41 +0000 Received: by outflank-mailman (input) for mailman id 177689; Thu, 02 Sep 2021 21:52:39 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLudT-0002d2-Oy for xen-devel@lists.xenproject.org; Thu, 02 Sep 2021 21:52:39 +0000 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 01f29d1e-e211-4a89-b018-7e9f5ee1dd14; Thu, 02 Sep 2021 21:52:38 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id A1C56610CF; Thu, 2 Sep 2021 21:52:37 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 01f29d1e-e211-4a89-b018-7e9f5ee1dd14 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1630619557; bh=1Qb985OcOh2tmU7a/TZayFbUIxluyDo779n2s/w0LyQ=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=JU397CrVf7uaDaPJVR/aIYQyzKcG16haazs+tJKg0zlTLnZbzoW4U/a4Wnm5kKWnW r6OKKbLLdlpcFBgkTXWVVjlhjaayWukx4z9Qe+pkjb0uSreJB+SzoHPFndxNdACb0s Ho3gvS19ltu6nzqZQJ4dJL71F2VbWIwgqeuyZZlqxoQvHU3anRr0W+9us6dniwmC/I NleDywM/jBOjJKLeRShFw/vNgUNfKLrC8MG9WBpr1PLkroQFHsN9e9M9SVZeo9WMQ+ Ojxnq4FTYZAQ11I71fHPUAdJEaKhfbn40M/oeeR7q9zgvEFQZrGVUYorjkuZHVzfIG hnUFbrwymNnOw== Date: Thu, 2 Sep 2021 14:52:36 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: Stefano Stabellini cc: Penny Zheng , xen-devel@lists.xenproject.org, julien@xen.org, Bertrand.Marquis@arm.com, Wei.Chen@arm.com, nd@arm.com Subject: Re: [PATCH v5 7/7] xen/arm: introduce allocate_static_memory In-Reply-To: Message-ID: References: <20210824095045.2281500-1-penny.zheng@arm.com> <20210824095045.2281500-8-penny.zheng@arm.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Thu, 2 Sep 2021, Stefano Stabellini wrote: > On Tue, 24 Aug 2021, Penny Zheng wrote: > > This commit introduces allocate_static_memory to allocate static memory as > > guest RAM for Domain on Static Allocation. > > > > It uses acquire_domstatic_pages to acquire pre-configured static memory > > for this domain, and uses guest_physmap_add_pages to set up P2M table. > > These pre-defined static memory banks shall be mapped to the fixed guest RAM > > banks. And only when they exhausts the current guest RAM bank, it will seek > > to the next one. > > > > In order to deal with the trouble of count-to-order conversion when page number > > is not in a power-of-two, this commit exports p2m_insert_mapping and introduce > > a new function guest_physmap_add_pages to cope with adding guest RAM p2m > > mapping with nr_pages. > > > > Signed-off-by: Penny Zheng > > --- > > v5 changes: > > - don't split comment over multi-line (even they are more than 80 characters) > > - simply use dt_find_property(node, "xen,static-mem", NULL) to tell > > whether using allocate_static_memory, and add error comment when > > "xen,static-mem" is used but CONFIG_STATIC_MEMORY is not enabled. > > - exporting p2m_insert_mapping() and introduce guest_physmap_add_pages > > to cope with adding guest RAM p2m mapping with nr_pages. > > - check both pbase and psize are page aligned > > - simplify the code in the loops by moving append_static_memory_to_bank() > > outside of the if/else. > > --- > > xen/arch/arm/domain_build.c | 156 +++++++++++++++++++++++++++++++++++- > > xen/arch/arm/p2m.c | 7 +- > > xen/include/asm-arm/p2m.h | 11 +++ > > 3 files changed, 168 insertions(+), 6 deletions(-) > > > > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c > > index 6c86d52781..843b8514c7 100644 > > --- a/xen/arch/arm/domain_build.c > > +++ b/xen/arch/arm/domain_build.c > > @@ -480,6 +480,148 @@ fail: > > (unsigned long)kinfo->unassigned_mem >> 10); > > } > > > > +#ifdef CONFIG_STATIC_MEMORY > > +static bool __init append_static_memory_to_bank(struct domain *d, > > + struct membank *bank, > > + mfn_t smfn, > > + paddr_t size) > > +{ > > + int res; > > + unsigned int nr_pages = size >> PAGE_SHIFT; > ^ PFN_DOWN > > > > + /* Infer next GFN. */ > > + gfn_t sgfn = gaddr_to_gfn(bank->start + bank->size); > > + > > + res = guest_physmap_add_pages(d, sgfn, smfn, nr_pages); > > + if ( res ) > > + { > > + dprintk(XENLOG_ERR, "Failed to map pages to DOMU: %d", res); > > + return false; > > + } > > + > > + bank->size = bank->size + size; > > + > > + return true; > > +} > > + > > +/* Allocate memory from static memory as RAM for one specific domain d. */ > > +static void __init allocate_static_memory(struct domain *d, > > + struct kernel_info *kinfo, > > + const struct dt_device_node *node) > > +{ > > + const struct dt_property *prop; > > + u32 addr_cells, size_cells, reg_cells; > > + unsigned int nr_banks, gbank = 0, bank = 0; > > + const uint64_t rambase[] = GUEST_RAM_BANK_BASES; > > + const uint64_t ramsize[] = GUEST_RAM_BANK_SIZES; > > + const __be32 *cell; > > + u64 tot_size = 0; > > + paddr_t pbase, psize, gsize; > > + mfn_t smfn; > > + int res; > > + > > + prop = dt_find_property(node, "xen,static-mem", NULL); > > + if ( !dt_property_read_u32(node, "#xen,static-mem-address-cells", > > + &addr_cells) ) > > + { > > + printk(XENLOG_ERR > > + "%pd: failed to read \"#xen,static-mem-address-cells\".\n", d); > > + goto fail; > > + } > > + > > + if ( !dt_property_read_u32(node, "#xen,static-mem-size-cells", > > + &size_cells) ) > > + { > > + printk(XENLOG_ERR > > + "%pd: failed to read \"#xen,static-mem-size-cells\".\n", d); > > + goto fail; > > + } > > + reg_cells = addr_cells + size_cells; > > + > > + /* Start with GUEST_RAM0. */ > > + gsize = ramsize[gbank]; > > + kinfo->mem.bank[gbank].start = rambase[gbank]; > > + > > + cell = (const __be32 *)prop->value; > > + nr_banks = (prop->length) / (reg_cells * sizeof (u32)); > > + > > + for ( ; bank < nr_banks; bank++ ) > > + { > > + device_tree_get_reg(&cell, addr_cells, size_cells, &pbase, &psize); > > + ASSERT(IS_ALIGNED(pbase, PAGE_SIZE) && IS_ALIGNED(psize, PAGE_SIZE)); > > + > > + smfn = maddr_to_mfn(pbase); > > + res = acquire_domstatic_pages(d, smfn, psize >> PAGE_SHIFT, 0); > ^ PFN_DOWN(psize) > > > > + if ( res ) > > + { > > + printk(XENLOG_ERR > > + "%pd: failed to acquire static memory: %d.\n", d, res); > > + goto fail; > > + } > > + > > + printk(XENLOG_INFO "%pd: STATIC BANK[%u] %#"PRIpaddr"-%#"PRIpaddr"\n", > > + d, bank, pbase, pbase + psize); > > + > > + /* > > + * It shall be mapped to the fixed guest RAM banks(GUEST_RAM_BANK_BASES), > > + * And only when it exhausts the current guest RAM bank, it will seek > > + * to the next. > > + */ > > + while ( 1 ) > > + { > > + /* Map as much as possible the static range to the guest bank */ > > + if ( !append_static_memory_to_bank(d, &kinfo->mem.bank[gbank], smfn, > > + min(psize, gsize)) ) > > + goto fail; > > + > > + /* > > + * The current physical bank is fully mapped. > > + * Handle the next physical bank. > > + */ > > + if ( gsize >= psize ) > > + { > > + gsize = gsize - psize; > > + break; > > + } > > + /* > > + * When current guest bank size is not enough to map. > > + * Before seeking to the next, check if we still have available > > + * guest bank. > > + */ > > + else if ( (gbank + 1) >= GUEST_RAM_BANKS ) > > + { > > + printk(XENLOG_ERR "Exhausted all fixed guest banks.\n"); > > + goto fail; > > + } > > + else > > + { > > + psize = psize - gsize; > > + smfn = mfn_add(smfn, gsize >> PAGE_SHIFT); > ^ PFN_DOWN > > > > + /* Update to the next guest bank. */ > > + gbank++; > > + gsize = ramsize[gbank]; > > + kinfo->mem.bank[gbank].start = rambase[gbank]; > > + } > > + } > > + > > + tot_size += psize; > > + } > > + > > + kinfo->mem.nr_banks = ++gbank; > > + kinfo->unassigned_mem -= tot_size; > > + if ( kinfo->unassigned_mem ) > > + { > > + printk(XENLOG_ERR > > + "Size of \"memory\" property doesn't match up with the sum-up of \"xen,static-mem\".\n"); > > + goto fail; > > Do we need to make this a fatal failure? > > I am asking because unassigned_mem comes from the "memory" property of > the domain in device tree which is kind of redundant with the > introduction of xen,static-mem. In fact, I think it would be better to > clarify the role of "memory" when "xen,static-mem" is also present. > In that case, we could even make "memory" optional. > > In any case, even if we don't make "memory" optional, it might still be > good to turn this error into a warning and ignore the remaining > kinfo->unassigned_mem. One more thing: if we decide to make "memory" optional, we need to avoid failing if it is not present at the beginning of construct_domU (if xen,static-mem is present). From xen-devel-bounces@lists.xenproject.org Thu Sep 02 22:08:10 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 22:08:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177697.323306 (Exim 4.92) (envelope-from ) id 1mLusH-0004MN-1U; Thu, 02 Sep 2021 22:07:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177697.323306; Thu, 02 Sep 2021 22:07:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLusG-0004MG-UY; Thu, 02 Sep 2021 22:07:56 +0000 Received: by outflank-mailman (input) for mailman id 177697; Thu, 02 Sep 2021 22:07:55 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLusF-0004MA-QJ for xen-devel@lists.xenproject.org; Thu, 02 Sep 2021 22:07:55 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLusF-0006Sq-Kl; Thu, 02 Sep 2021 22:07:55 +0000 Received: from 54-240-197-224.amazon.com ([54.240.197.224] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1mLusF-0001cA-Ek; Thu, 02 Sep 2021 22:07:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=1T4g9ly1aVs9sxccoIF94nJdhxMvrAlrBSd/tuJ7YMc=; b=5Qo9VREyLbEKHxfKO/FkFT8fjG f8YnoVNVvw7ynszXmCX5KwKaPPG/28YVXOZJ5itcab0UFXaAco+j5k3OeK5sWWR1cM6n94izo/HJw qsVqJfP1+LeuWYjPT+PWYovt/m3Djo1YzMdIA5MDvvGU+sA/gt2imSGIBXQjoDdwoELQ=; Subject: Re: [PATCH v5 7/7] xen/arm: introduce allocate_static_memory To: Stefano Stabellini , Penny Zheng Cc: xen-devel@lists.xenproject.org, Bertrand.Marquis@arm.com, Wei.Chen@arm.com, nd@arm.com References: <20210824095045.2281500-1-penny.zheng@arm.com> <20210824095045.2281500-8-penny.zheng@arm.com> From: Julien Grall Message-ID: Date: Thu, 2 Sep 2021 23:07:53 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Hi Stefano, On 02/09/2021 22:32, Stefano Stabellini wrote: > On Tue, 24 Aug 2021, Penny Zheng wrote: >> This commit introduces allocate_static_memory to allocate static memory as >> guest RAM for Domain on Static Allocation. >> >> It uses acquire_domstatic_pages to acquire pre-configured static memory >> for this domain, and uses guest_physmap_add_pages to set up P2M table. >> These pre-defined static memory banks shall be mapped to the fixed guest RAM >> banks. And only when they exhausts the current guest RAM bank, it will seek >> to the next one. >> >> In order to deal with the trouble of count-to-order conversion when page number >> is not in a power-of-two, this commit exports p2m_insert_mapping and introduce >> a new function guest_physmap_add_pages to cope with adding guest RAM p2m >> mapping with nr_pages. >> >> Signed-off-by: Penny Zheng >> --- >> v5 changes: >> - don't split comment over multi-line (even they are more than 80 characters) >> - simply use dt_find_property(node, "xen,static-mem", NULL) to tell >> whether using allocate_static_memory, and add error comment when >> "xen,static-mem" is used but CONFIG_STATIC_MEMORY is not enabled. >> - exporting p2m_insert_mapping() and introduce guest_physmap_add_pages >> to cope with adding guest RAM p2m mapping with nr_pages. >> - check both pbase and psize are page aligned >> - simplify the code in the loops by moving append_static_memory_to_bank() >> outside of the if/else. >> --- >> xen/arch/arm/domain_build.c | 156 +++++++++++++++++++++++++++++++++++- >> xen/arch/arm/p2m.c | 7 +- >> xen/include/asm-arm/p2m.h | 11 +++ >> 3 files changed, 168 insertions(+), 6 deletions(-) >> >> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c >> index 6c86d52781..843b8514c7 100644 >> --- a/xen/arch/arm/domain_build.c >> +++ b/xen/arch/arm/domain_build.c >> @@ -480,6 +480,148 @@ fail: >> (unsigned long)kinfo->unassigned_mem >> 10); >> } >> >> +#ifdef CONFIG_STATIC_MEMORY >> +static bool __init append_static_memory_to_bank(struct domain *d, >> + struct membank *bank, >> + mfn_t smfn, >> + paddr_t size) >> +{ >> + int res; >> + unsigned int nr_pages = size >> PAGE_SHIFT; > ^ PFN_DOWN > > >> + /* Infer next GFN. */ >> + gfn_t sgfn = gaddr_to_gfn(bank->start + bank->size); >> + >> + res = guest_physmap_add_pages(d, sgfn, smfn, nr_pages); >> + if ( res ) >> + { >> + dprintk(XENLOG_ERR, "Failed to map pages to DOMU: %d", res); >> + return false; >> + } >> + >> + bank->size = bank->size + size; >> + >> + return true; >> +} >> + >> +/* Allocate memory from static memory as RAM for one specific domain d. */ >> +static void __init allocate_static_memory(struct domain *d, >> + struct kernel_info *kinfo, >> + const struct dt_device_node *node) >> +{ >> + const struct dt_property *prop; >> + u32 addr_cells, size_cells, reg_cells; >> + unsigned int nr_banks, gbank = 0, bank = 0; >> + const uint64_t rambase[] = GUEST_RAM_BANK_BASES; >> + const uint64_t ramsize[] = GUEST_RAM_BANK_SIZES; >> + const __be32 *cell; >> + u64 tot_size = 0; >> + paddr_t pbase, psize, gsize; >> + mfn_t smfn; >> + int res; >> + >> + prop = dt_find_property(node, "xen,static-mem", NULL); >> + if ( !dt_property_read_u32(node, "#xen,static-mem-address-cells", >> + &addr_cells) ) >> + { >> + printk(XENLOG_ERR >> + "%pd: failed to read \"#xen,static-mem-address-cells\".\n", d); >> + goto fail; >> + } >> + >> + if ( !dt_property_read_u32(node, "#xen,static-mem-size-cells", >> + &size_cells) ) >> + { >> + printk(XENLOG_ERR >> + "%pd: failed to read \"#xen,static-mem-size-cells\".\n", d); >> + goto fail; >> + } >> + reg_cells = addr_cells + size_cells; >> + >> + /* Start with GUEST_RAM0. */ >> + gsize = ramsize[gbank]; >> + kinfo->mem.bank[gbank].start = rambase[gbank]; >> + >> + cell = (const __be32 *)prop->value; >> + nr_banks = (prop->length) / (reg_cells * sizeof (u32)); >> + >> + for ( ; bank < nr_banks; bank++ ) >> + { >> + device_tree_get_reg(&cell, addr_cells, size_cells, &pbase, &psize); >> + ASSERT(IS_ALIGNED(pbase, PAGE_SIZE) && IS_ALIGNED(psize, PAGE_SIZE)); >> + >> + smfn = maddr_to_mfn(pbase); >> + res = acquire_domstatic_pages(d, smfn, psize >> PAGE_SHIFT, 0); > ^ PFN_DOWN(psize) > > >> + if ( res ) >> + { >> + printk(XENLOG_ERR >> + "%pd: failed to acquire static memory: %d.\n", d, res); >> + goto fail; >> + } >> + >> + printk(XENLOG_INFO "%pd: STATIC BANK[%u] %#"PRIpaddr"-%#"PRIpaddr"\n", >> + d, bank, pbase, pbase + psize); >> + >> + /* >> + * It shall be mapped to the fixed guest RAM banks(GUEST_RAM_BANK_BASES), >> + * And only when it exhausts the current guest RAM bank, it will seek >> + * to the next. >> + */ >> + while ( 1 ) >> + { >> + /* Map as much as possible the static range to the guest bank */ >> + if ( !append_static_memory_to_bank(d, &kinfo->mem.bank[gbank], smfn, >> + min(psize, gsize)) ) >> + goto fail; >> + >> + /* >> + * The current physical bank is fully mapped. >> + * Handle the next physical bank. >> + */ >> + if ( gsize >= psize ) >> + { >> + gsize = gsize - psize; >> + break; >> + } >> + /* >> + * When current guest bank size is not enough to map. >> + * Before seeking to the next, check if we still have available >> + * guest bank. >> + */ >> + else if ( (gbank + 1) >= GUEST_RAM_BANKS ) >> + { >> + printk(XENLOG_ERR "Exhausted all fixed guest banks.\n"); >> + goto fail; >> + } >> + else >> + { >> + psize = psize - gsize; >> + smfn = mfn_add(smfn, gsize >> PAGE_SHIFT); > ^ PFN_DOWN > > >> + /* Update to the next guest bank. */ >> + gbank++; >> + gsize = ramsize[gbank]; >> + kinfo->mem.bank[gbank].start = rambase[gbank]; >> + } >> + } >> + >> + tot_size += psize; >> + } >> + >> + kinfo->mem.nr_banks = ++gbank; >> + kinfo->unassigned_mem -= tot_size; >> + if ( kinfo->unassigned_mem ) >> + { >> + printk(XENLOG_ERR >> + "Size of \"memory\" property doesn't match up with the sum-up of \"xen,static-mem\".\n"); >> + goto fail; > > Do we need to make this a fatal failure? > > I am asking because unassigned_mem comes from the "memory" property of > the domain in device tree which is kind of redundant with the > introduction of xen,static-mem. In fact, I think it would be better to > clarify the role of "memory" when "xen,static-mem" is also present. > In that case, we could even make "memory" optional. I requested to make it mandatory. Imagine you have a domU that has 1GB and now you want to switch to static memory. If we make the property optional, then there is a risk for the admin to not correctly pass the amount of memory. This may become unnoticed until late. So I think making it mandatory is cheap for us and an easy way to confirm you properly sized the region. It also has the benefits to easily find out how much memory you gave to the guest (but that's just because I am lazy :)). > In any case, even if we don't make "memory" optional, it might still be > good to turn this error into a warning and ignore the remaining > kinfo->unassigned_mem. The behavior is matching the existing function and I think this is a good idea. If you ask 10MB of memory and we only give you 9MB, then at some point your guest is not going to be happy. It is much better to know it in advance with a failure over discovering hours later when you see an OOM from your domain. > > >> + } >> + >> + return; >> + >> +fail: >> + panic("Failed to allocate requested static memory for domain %pd.", d); >> +} >> +#endif >> + >> static int __init write_properties(struct domain *d, struct kernel_info *kinfo, >> const struct dt_device_node *node) >> { >> @@ -2452,7 +2594,19 @@ static int __init construct_domU(struct domain *d, >> /* type must be set before allocate memory */ >> d->arch.type = kinfo.type; >> #endif >> - allocate_memory(d, &kinfo); >> + if ( !dt_find_property(node, "xen,static-mem", NULL) ) >> + allocate_memory(d, &kinfo); >> +#ifdef CONFIG_STATIC_MEMORY >> + else >> + allocate_static_memory(d, &kinfo, node); >> +#else >> + else >> + { >> + printk(XENLOG_ERR >> + "CONFIG_STATIC_MEMORY must be enabled to use \"xen,static-mem\".\n"); >> + return -EINVAL; >> + } >> +#endif > > To avoid the double else in the code, this part could be written like > this which is a bit simpler I think: > > if ( !dt_find_property(node, "xen,static-mem", NULL) ) > allocate_memory(d, &kinfo); > else > { > #ifdef CONFIG_STATIC_MEMORY > allocate_static_memory(d, &kinfo, node); > #else > printk(XENLOG_ERR > "CONFIG_STATIC_MEMORY must be enabled to use \"xen,static-mem\".\n"); > return -EINVAL; > #endif > } > > This is just a suggestion to improve readability, I am also OK with what > you wrote. > > (Another alternative would be to provide a stub allocate_static_memory > implementation for !CONFIG_STATIC_MEMORY.) My preference is 1) Stub function 2) your #ifdef proposal 3) Penny's approach. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Sep 02 22:52:27 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 02 Sep 2021 22:52:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177707.323329 (Exim 4.92) (envelope-from ) id 1mLvZF-0001fj-LP; Thu, 02 Sep 2021 22:52:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177707.323329; Thu, 02 Sep 2021 22:52:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLvZF-0001fc-Hf; Thu, 02 Sep 2021 22:52:21 +0000 Received: by outflank-mailman (input) for mailman id 177707; Thu, 02 Sep 2021 22:52:20 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLvZE-0001fS-Cn; Thu, 02 Sep 2021 22:52:20 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLvZE-0007HT-7u; Thu, 02 Sep 2021 22:52:20 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLvZE-0007nV-19; Thu, 02 Sep 2021 22:52:20 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mLvZE-0001qR-0d; Thu, 02 Sep 2021 22:52:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=tyQIheUlW3Ycxa0FlnKX+D5iFvAfJahaxYZjV5aGE7k=; b=r6fHYRr85dbb7oSjHEhdNZMcAs CXC1WR6oV4rrtm6scikL19bTnvNEnJ1kKc0V4BWRhEMg2AZ99xOwzD9tIgzCzM53hi2lykt5u4o4E /Epk8diUK7E1y3sFdeaDYgeiu/qrV+GAbjK7ma6HdjftPtbKw3aEgg0mMNohjCJEmTKk=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 164778: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=b6bc203375b6efb6822ee4fe4a59be4f1918436b X-Osstest-Versions-That: ovmf=cae735f61328d64e2e8991036707b9e78c0f5f63 From: osstest service owner Date: Thu, 02 Sep 2021 22:52:20 +0000 flight 164778 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/164778/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 164674 build-amd64-xsm 6 xen-build fail REGR. vs. 164674 build-i386-xsm 6 xen-build fail REGR. vs. 164674 build-i386 6 xen-build fail REGR. vs. 164674 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf b6bc203375b6efb6822ee4fe4a59be4f1918436b baseline version: ovmf cae735f61328d64e2e8991036707b9e78c0f5f63 Last test of basis 164674 2021-08-31 02:56:52 Z 2 days Failing since 164686 2021-09-01 03:03:43 Z 1 days 16 attempts Testing same since 164764 2021-09-02 12:11:21 Z 0 days 4 attempts ------------------------------------------------------------ People who touched revisions under test: Anthony PERARD DunTan Gary Lin Jim Fehlig Lin, Gary (HPS OE-Linux) Loo Tung Lun Loo, Tung Lun Mark Wilson Marvin H?user Wenxing Hou Wenyi Xie jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit b6bc203375b6efb6822ee4fe4a59be4f1918436b Author: Wenyi Xie Date: Thu Aug 26 09:16:03 2021 +0800 MdeModulePkg/HiiDatabaseDxe:remove dead code block As the if statement outside has confirmed that BlockData->Name == NULL, so the if statement inside is always false. Cc: Jian J Wang Cc: Hao A Wu Cc: Dandan Bi Cc: Eric Dong Signed-off-by: Wenyi Xie Reviewed-by: Dandan Bi commit e3ee8c8dbd7a9f7d7905abe17be60354c9f5f9a3 Author: duntan Date: Fri Aug 20 14:43:37 2021 +0800 .azurepipelines: Add UefiPayloadPkg in gate-build-job.yml and CISetting.py Add UefiPayloadPkg in gate-build-job.yml to enable Core ci for UefiPayloadPkg. Add UefiPayloadPkg to supported Packages in CISettings. Cc: Sean Brogan Cc: Bret Barkelew Cc: Michael D Kinney Cc: Liming Gao Signed-off-by: DunTan Reviewed-by: Liming Gao commit 63fddc98e06c380e654b1cfbaf24b9fd922adfad Author: duntan Date: Fri Aug 20 14:43:36 2021 +0800 UefiPayloadPkg: Create .yaml file in UefiPayloadPkg Create .yaml file in UefiPayloadPkg to enable Core ci for UefiPayloadPkg Cc: Guo Dong Cc: Ray Ni Cc: Maurice Ma Cc: Benjamin You Signed-off-by: DunTan Reviewed-by: Liming Gao commit 12e33dca4c0612a0975265e5ba641c6261a26455 Author: Loo, Tung Lun Date: Tue Aug 17 15:43:12 2021 +0800 IntelFsp2Pkg: Support Config File and Binary delta comparison BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3567 This patch is to enable config editor to have a new feature that can spell out the delta between the default configuration files' data, such as YAML and BSF, against the data stored in the binary. This can help users understand and track the difference when modifications are made. Cc: Maurice Ma Cc: Nate DeSimone Cc: Star Zeng Cc: Chasel Chiu Signed-off-by: Loo Tung Lun Reviewed-by: Chasel Chiu commit b170806518c1e414939c8b085866544814e1ce8e Author: Mark Wilson Date: Fri Nov 13 08:05:18 2020 +0800 UefiCpuPkg: Clean up save state boundary checks and comments. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2956 In functions ReadSaveStateRegisterByIndex and WriteSaveStateRegister: * check width > 4 instead of >= 4 when writing upper 32 bytes. - This improves the code but will not affect functionality. Cc: Eric Dong Reviewed-by: Ray Ni Signed-off-by: Mark Wilson commit 3b3f88228812e2c642eea8746858a4dad928ebf7 Author: Marvin H?user Date: Mon Aug 9 14:09:25 2021 +0800 MdeModulePkg/PiSmmCore: Drop deprecated image profiling commands The legacy codebase allowed SMM images to be registered for profiling from DXE. Support for this has been dropped entirely, so remove the remaining handlers. Cc: Jian J Wang Cc: Hao A Wu Cc: Eric Dong Reviewed-by: Ray Ni Cc: Vitaly Cheptsov Signed-off-by: Marvin H?user commit cdda3f74a1327663a5d48cca13507085ba403af7 Author: Marvin H?user Date: Mon Aug 9 03:39:53 2021 +0800 UefiPayloadPkg/UefiPayloadEntry: Fix memory corruption UefiPayloadEntry's AllocatePool() applies the "sizeof" operator to HOB index rather than the HOB header structure. This yields 4 Bytes compared to the 8 Bytes the structure header requires. Fix the call to allocate the required space instead. Reviewed-by: Guo Dong Reviewed-by: Ray Ni Cc: Maurice Ma Cc: Benjamin You Cc: Vitaly Cheptsov Signed-off-by: Marvin H?user commit 5d34cc49d5d348012fe8acf9fb618826bd541a7c Author: Wenxing Hou Date: Tue Aug 24 16:11:11 2021 +0800 UefiCpuPkg/PiSmmCpuDxeSmm: Update mPatchCetSupported set condition REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3584 Function AsmCpuid should first check the value for Basic CPUID Information. The fix is to update the mPatchCetSupported judgment statement. Signed-off-by: Wenxing Hou Reviewed-by: Ray Ni Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Cc: Sheng W Cc: Yao Jiewen commit f0fe55bca4651734abf1752a1d7c69fb5bee00b9 Author: duntan Date: Fri Aug 20 13:04:29 2021 +0800 UefiPayloadPkg: Fix the build error when enable Core ci for UefiPayloadPkg V1: Add quotes when using $(ARCH) in .dsc and .fdf file. The quotes are added due to the way by which Core ci parse the .dsc file. Add UINTN in Hob.c to fix cast from pointer to integer of different size error. V2: Delete lines which reference ShellBinPkg.The pkg doesn't exist in edk2. Cc: Guo Dong Cc: Ray Ni Cc: Maurice Ma Cc: Benjamin You Signed-off-by: DunTan Reviewed-by: Ray Ni commit 9f3eda177a4b2d4a33ff1b0307cad42906396562 Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:29:48 2021 +0800 OvmfPkg/OvmfXen: add QemuKernelLoaderFsDxe Without QemuKernelLoaderFsDxe, QemuLoadKernelImage() couldn't download the kernel, initrd, and kernel command line from QEMU's fw_cfg. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3574 Signed-off-by: Gary Lin Acked-by: Anthony PERARD Reviewed-by: Philippe Mathieu-Daude Reviewed-by: Gerd Hoffmann Tested-by: Jim Fehlig commit 5b5f10d7465004e3e40ec1f50a3b490b4db595e7 Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:31:15 2021 +0800 OvmfPkg/SmmControl2Dxe: use PcdAcpiS3Enable to detect S3 support To avoid the potential inconsistency between PcdAcpiS3Enable and QemuFwCfgS3Enabled(), this commit modifies SmmControl2Dxe to detect S3 support by PcdAcpiS3Enable as modules in MdeModulePkg do. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3573 Signed-off-by: Gary Lin Reviewed-by: Gerd Hoffmann Reviewed-by: Jiewen Yao Tested-by: Jim Fehlig commit 52e2dabc0f8d3af09c213072ce8ba734302f585d Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:31:14 2021 +0800 OvmfPkg/PlatformBootManagerLib: use PcdAcpiS3Enable to detect S3 support To avoid the potential inconsistency between PcdAcpiS3Enable and QemuFwCfgS3Enabled(), this commit modifies PlatformBootManagerLib to detect S3 support by PcdAcpiS3Enable as modules in MdeModulePkg do. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3573 Signed-off-by: Gary Lin Reviewed-by: Gerd Hoffmann Reviewed-by: Jiewen Yao Tested-by: Jim Fehlig commit 28152333bccb778b62e6e97446b28bfa0e92ef82 Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:31:13 2021 +0800 OvmfPkg/LockBoxLib: use PcdAcpiS3Enable to detect S3 support To avoid the potential inconsistency between PcdAcpiS3Enable and QemuFwCfgS3Enabled(), this commit modifies LockBoxLib to detect S3 support by PcdAcpiS3Enable as modules in MdeModulePkg do. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3573 Signed-off-by: Gary Lin Reviewed-by: Philippe Mathieu-Daude Reviewed-by: Gerd Hoffmann Reviewed-by: Jiewen Yao Tested-by: Jim Fehlig commit cb0d24637dfdd869618b9635dfb8e3b0746393a6 Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:31:12 2021 +0800 OvmfPkg/OvmfXen: set PcdAcpiS3Enable at initialization There are several functions in OvmfPkg/Library using QemuFwCfgS3Enabled() to detect the S3 support status. However, in MdeModulePkg, PcdAcpiS3Enable is used to check S3 support. Since InitializeXenPlatform() didn't set PcdAcpiS3Enable as InitializePlatform() did, this made the inconsistency between drivers/functions. For example, S3SaveStateDxe checked PcdAcpiS3Enable and skipped S3BootScript because the default value is FALSE. On the other hand, PlatformBootManagerBeforeConsole() from OvmfPkg/Library called QemuFwCfgS3Enabled() and found it returned TRUE, so it invoked SaveS3BootScript(). However, S3SaveStateDxe skipped S3BootScript, so SaveS3BootScript() asserted due to EFI_NOT_FOUND. This issue mainly affects "HVM Direct Kernel Boot". When used, "fw_cfg" is enabled in QEMU and QemuFwCfgS3Enabled() returns true in that case. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3573 Signed-off-by: Gary Lin Reviewed-by: Anthony PERARD Reviewed-by: Gerd Hoffmann Reviewed-by: Jiewen Yao Tested-by: Jim Fehlig From xen-devel-bounces@lists.xenproject.org Fri Sep 03 00:26:29 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Sep 2021 00:26:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177719.323348 (Exim 4.92) (envelope-from ) id 1mLx28-0003uf-HT; Fri, 03 Sep 2021 00:26:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177719.323348; Fri, 03 Sep 2021 00:26:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLx28-0003uY-EF; Fri, 03 Sep 2021 00:26:16 +0000 Received: by outflank-mailman (input) for mailman id 177719; Fri, 03 Sep 2021 00:26:14 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLx26-0003uO-NU; Fri, 03 Sep 2021 00:26:14 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLx26-00011Y-BA; Fri, 03 Sep 2021 00:26:14 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLx25-0004SC-W2; Fri, 03 Sep 2021 00:26:14 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mLx25-0004oj-VY; Fri, 03 Sep 2021 00:26:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Message-Id:Subject:To; bh=nrh3UH/pvC8HUOwb0DowZNjxIh5jbmJJITk0G8tPb1Q=; b=X0SBcsGZkI9MsRr+UA7Q0K1TQQ 1Sa4AumaMSjvtWweVpC/sIcQOofpfJs+pAx/1/6pV1MFf7A5Vk/eCHRRZknZdd5pfSfVQchSi0SLq +yen51vdLMmkDtOJWU7/ejJnS9JCm5NyN8zWtRp7iM25Gj4szBxUdgZAZDgIQVAf4FG0=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Subject: [ovmf bisection] complete build-i386 Message-Id: From: osstest service owner Date: Fri, 03 Sep 2021 00:26:13 +0000 branch xen-unstable xenbranch xen-unstable job build-i386 testid xen-build Tree: ovmf https://github.com/tianocore/edk2.git Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git Tree: qemuu git://xenbits.xen.org/qemu-xen.git Tree: seabios git://xenbits.xen.org/osstest/seabios.git Tree: xen git://xenbits.xen.org/xen.git *** Found and reproduced problem changeset *** Bug is in tree: ovmf https://github.com/tianocore/edk2.git Bug introduced: 9f3eda177a4b2d4a33ff1b0307cad42906396562 Bug not present: 5b5f10d7465004e3e40ec1f50a3b490b4db595e7 Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/164784/ commit 9f3eda177a4b2d4a33ff1b0307cad42906396562 Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:29:48 2021 +0800 OvmfPkg/OvmfXen: add QemuKernelLoaderFsDxe Without QemuKernelLoaderFsDxe, QemuLoadKernelImage() couldn't download the kernel, initrd, and kernel command line from QEMU's fw_cfg. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3574 Signed-off-by: Gary Lin Acked-by: Anthony PERARD Reviewed-by: Philippe Mathieu-Daude Reviewed-by: Gerd Hoffmann Tested-by: Jim Fehlig For bisection revision-tuple graph see: http://logs.test-lab.xenproject.org/osstest/results/bisect/ovmf/build-i386.xen-build.html Revision IDs in each graph node refer, respectively, to the Trees above. ---------------------------------------- Running cs-bisection-step --graph-out=/home/logs/results/bisect/ovmf/build-i386.xen-build --summary-out=tmp/164784.bisection-summary --basis-template=164674 --blessings=real,real-bisect,real-retry ovmf build-i386 xen-build Searching for failure / basis pass: 164778 fail [host=huxelrebe1] / 164674 [host=albana0] 164630 [host=huxelrebe0] 164556 [host=albana1] 164513 [host=albana1] 164461 [host=fiano0] 164406 [host=albana0] 164229 [host=huxelrebe0] 164173 [host=albana0] 164166 [host=albana1] 164160 ok. Failure / basis pass flights: 164778 / 164160 (tree with no url: minios) Tree: ovmf https://github.com/tianocore/edk2.git Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git Tree: qemuu git://xenbits.xen.org/qemu-xen.git Tree: seabios git://xenbits.xen.org/osstest/seabios.git Tree: xen git://xenbits.xen.org/xen.git Latest b6bc203375b6efb6822ee4fe4a59be4f1918436b 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 54082c81d96028ba8c76fbe6784085cf1df76b20 96607a8e680e7f965ca868d11f8b0636317d2618 Basis pass a776bbabd9e8f370feb089cdc016324b1d6a37c7 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 136c34c9bc4179dc64b15b2bb5f0c54ca4ddf823 54082c81d96028ba8c76fbe6784085cf1df76b20 25da9455f1bb8a6d33039575a7b28bdfc4e3fcfe Generating revisions with ./adhoc-revtuple-generator https://github.com/tianocore/edk2.git#a776bbabd9e8f370feb089cdc016324b1d6a37c7-b6bc203375b6efb6822ee4fe4a59be4f1918436b git://xenbits.xen.org/qemu-xen-traditional.git#3d273dd05e51e5a1ffba3d98c7437ee84e8f8764-3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 git://xenbits.xen.org/qemu-xen.git#136c34c9bc4179dc64b15b2bb5f0c54ca4ddf823-b6e539830bf45e2d7a6bd86ddfdf003088b173b0 git://xenbits.xen.org/osstest/seabios.git#54082c81d96028ba8c76fbe6784085cf1df76b\ 20-54082c81d96028ba8c76fbe6784085cf1df76b20 git://xenbits.xen.org/xen.git#25da9455f1bb8a6d33039575a7b28bdfc4e3fcfe-96607a8e680e7f965ca868d11f8b0636317d2618 Loaded 76351 nodes in revision graph Searching for test results: 164160 pass a776bbabd9e8f370feb089cdc016324b1d6a37c7 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 136c34c9bc4179dc64b15b2bb5f0c54ca4ddf823 54082c81d96028ba8c76fbe6784085cf1df76b20 25da9455f1bb8a6d33039575a7b28bdfc4e3fcfe 164166 [host=albana1] 164173 [host=albana0] 164229 [host=huxelrebe0] 164406 [host=albana0] 164461 [host=fiano0] 164513 [host=albana1] 164556 [host=albana1] 164630 [host=huxelrebe0] 164674 [host=albana0] 164686 fail irrelevant 164695 fail irrelevant 164704 [host=fiano1] 164718 fail irrelevant 164728 fail 12e33dca4c0612a0975265e5ba641c6261a26455 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 54082c81d96028ba8c76fbe6784085cf1df76b20 96607a8e680e7f965ca868d11f8b0636317d2618 164733 fail 12e33dca4c0612a0975265e5ba641c6261a26455 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 54082c81d96028ba8c76fbe6784085cf1df76b20 96607a8e680e7f965ca868d11f8b0636317d2618 164737 fail 12e33dca4c0612a0975265e5ba641c6261a26455 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 54082c81d96028ba8c76fbe6784085cf1df76b20 96607a8e680e7f965ca868d11f8b0636317d2618 164740 [host=huxelrebe0] 164743 fail e3ee8c8dbd7a9f7d7905abe17be60354c9f5f9a3 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 54082c81d96028ba8c76fbe6784085cf1df76b20 96607a8e680e7f965ca868d11f8b0636317d2618 164746 fail e3ee8c8dbd7a9f7d7905abe17be60354c9f5f9a3 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 54082c81d96028ba8c76fbe6784085cf1df76b20 96607a8e680e7f965ca868d11f8b0636317d2618 164754 pass a776bbabd9e8f370feb089cdc016324b1d6a37c7 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 136c34c9bc4179dc64b15b2bb5f0c54ca4ddf823 54082c81d96028ba8c76fbe6784085cf1df76b20 25da9455f1bb8a6d33039575a7b28bdfc4e3fcfe 164755 fail e3ee8c8dbd7a9f7d7905abe17be60354c9f5f9a3 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 54082c81d96028ba8c76fbe6784085cf1df76b20 96607a8e680e7f965ca868d11f8b0636317d2618 164751 fail e3ee8c8dbd7a9f7d7905abe17be60354c9f5f9a3 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 54082c81d96028ba8c76fbe6784085cf1df76b20 96607a8e680e7f965ca868d11f8b0636317d2618 164756 pass 7b4a99be8a39c12d3a7fc4b8db9f0eab4ac688d5 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 136c34c9bc4179dc64b15b2bb5f0c54ca4ddf823 54082c81d96028ba8c76fbe6784085cf1df76b20 b1ee10be5625b7d502cef1e6ee3818610ab0d29c 164759 pass 77d5fa80246e8784f89e109ff9dadfeb7089ff85 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 136c34c9bc4179dc64b15b2bb5f0c54ca4ddf823 54082c81d96028ba8c76fbe6784085cf1df76b20 8064488062641ae505b2a7369611c38057a7788b 164761 pass 52e2dabc0f8d3af09c213072ce8ba734302f585d 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 54082c81d96028ba8c76fbe6784085cf1df76b20 daaf007eb3467f900a2e20fadbc4c6f3bfcaa356 164762 fail 9f3eda177a4b2d4a33ff1b0307cad42906396562 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 54082c81d96028ba8c76fbe6784085cf1df76b20 96607a8e680e7f965ca868d11f8b0636317d2618 164758 [host=huxelrebe0] 164763 fail 9f3eda177a4b2d4a33ff1b0307cad42906396562 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 54082c81d96028ba8c76fbe6784085cf1df76b20 daaf007eb3467f900a2e20fadbc4c6f3bfcaa356 164765 [host=huxelrebe0] 164766 [host=huxelrebe0] 164767 [host=huxelrebe0] 164768 [host=huxelrebe0] 164769 [host=huxelrebe0] 164770 [host=huxelrebe0] 164764 [host=huxelrebe0] 164771 [host=huxelrebe0] 164773 fail b6bc203375b6efb6822ee4fe4a59be4f1918436b 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 54082c81d96028ba8c76fbe6784085cf1df76b20 96607a8e680e7f965ca868d11f8b0636317d2618 164774 pass 5b5f10d7465004e3e40ec1f50a3b490b4db595e7 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 54082c81d96028ba8c76fbe6784085cf1df76b20 daaf007eb3467f900a2e20fadbc4c6f3bfcaa356 164775 fail b6bc203375b6efb6822ee4fe4a59be4f1918436b 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 54082c81d96028ba8c76fbe6784085cf1df76b20 96607a8e680e7f965ca868d11f8b0636317d2618 164776 fail 9f3eda177a4b2d4a33ff1b0307cad42906396562 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 54082c81d96028ba8c76fbe6784085cf1df76b20 daaf007eb3467f900a2e20fadbc4c6f3bfcaa356 164780 pass 5b5f10d7465004e3e40ec1f50a3b490b4db595e7 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 54082c81d96028ba8c76fbe6784085cf1df76b20 daaf007eb3467f900a2e20fadbc4c6f3bfcaa356 164781 fail 9f3eda177a4b2d4a33ff1b0307cad42906396562 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 54082c81d96028ba8c76fbe6784085cf1df76b20 daaf007eb3467f900a2e20fadbc4c6f3bfcaa356 164778 fail b6bc203375b6efb6822ee4fe4a59be4f1918436b 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 54082c81d96028ba8c76fbe6784085cf1df76b20 96607a8e680e7f965ca868d11f8b0636317d2618 164782 pass 5b5f10d7465004e3e40ec1f50a3b490b4db595e7 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 54082c81d96028ba8c76fbe6784085cf1df76b20 daaf007eb3467f900a2e20fadbc4c6f3bfcaa356 164784 fail 9f3eda177a4b2d4a33ff1b0307cad42906396562 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 54082c81d96028ba8c76fbe6784085cf1df76b20 daaf007eb3467f900a2e20fadbc4c6f3bfcaa356 Searching for interesting versions Result found: flight 164160 (pass), for basis pass For basis failure, parent search stopping at 5b5f10d7465004e3e40ec1f50a3b490b4db595e7 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 54082c81d96028ba8c76fbe6784085cf1df76b20 daaf007eb3467f900a2e20fadbc4c6f3bfcaa356, results HASH(0x55576e7a07a0) HASH(0x555773b85a90) HASH(0x555773b87e38) For basis failure, parent search stopping at 52e2dabc0f8d3af09c213072ce8ba734302f585d 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 54082c81d\ 96028ba8c76fbe6784085cf1df76b20 daaf007eb3467f900a2e20fadbc4c6f3bfcaa356, results HASH(0x555773b71480) Result found: flight 164728 (fail), for basis failure (at ancestor ~18) Repro found: flight 164754 (pass), for basis pass Repro found: flight 164773 (fail), for basis failure 0 revisions at 5b5f10d7465004e3e40ec1f50a3b490b4db595e7 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b6e539830bf45e2d7a6bd86ddfdf003088b173b0 54082c81d96028ba8c76fbe6784085cf1df76b20 daaf007eb3467f900a2e20fadbc4c6f3bfcaa356 No revisions left to test, checking graph state. Result found: flight 164774 (pass), for last pass Result found: flight 164776 (fail), for first failure Repro found: flight 164780 (pass), for last pass Repro found: flight 164781 (fail), for first failure Repro found: flight 164782 (pass), for last pass Repro found: flight 164784 (fail), for first failure *** Found and reproduced problem changeset *** Bug is in tree: ovmf https://github.com/tianocore/edk2.git Bug introduced: 9f3eda177a4b2d4a33ff1b0307cad42906396562 Bug not present: 5b5f10d7465004e3e40ec1f50a3b490b4db595e7 Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/164784/ commit 9f3eda177a4b2d4a33ff1b0307cad42906396562 Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:29:48 2021 +0800 OvmfPkg/OvmfXen: add QemuKernelLoaderFsDxe Without QemuKernelLoaderFsDxe, QemuLoadKernelImage() couldn't download the kernel, initrd, and kernel command line from QEMU's fw_cfg. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3574 Signed-off-by: Gary Lin Acked-by: Anthony PERARD Reviewed-by: Philippe Mathieu-Daude Reviewed-by: Gerd Hoffmann Tested-by: Jim Fehlig Revision graph left in /home/logs/results/bisect/ovmf/build-i386.xen-build.{dot,ps,png,html,svg}. ---------------------------------------- 164784: tolerable ALL FAIL flight 164784 ovmf real-bisect [real] http://logs.test-lab.xenproject.org/osstest/logs/164784/ Failures :-/ but no regressions. Tests which did not succeed, including tests which could not be run: build-i386 6 xen-build fail baseline untested jobs: build-i386 fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary From xen-devel-bounces@lists.xenproject.org Fri Sep 03 00:26:37 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Sep 2021 00:26:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177722.323363 (Exim 4.92) (envelope-from ) id 1mLx2T-0004La-QZ; Fri, 03 Sep 2021 00:26:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177722.323363; Fri, 03 Sep 2021 00:26:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLx2T-0004LT-NL; Fri, 03 Sep 2021 00:26:37 +0000 Received: by outflank-mailman (input) for mailman id 177722; Fri, 03 Sep 2021 00:26:36 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLx2S-0004L2-J3; Fri, 03 Sep 2021 00:26:36 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLx2S-00011z-Ct; Fri, 03 Sep 2021 00:26:36 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLx2S-0004T0-23; Fri, 03 Sep 2021 00:26:36 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mLx2S-0007MB-1U; Fri, 03 Sep 2021 00:26:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=VCoF6OPfcN9kIDCgG0MkAQ/GagEHY4yXc/+JO99X2/o=; b=X4KflS1D4sjjH9+a+YOL8SEAGS bWLpAafW82bSO9EkHjYiByVKJ4Iovrqcgy06dkZyLP8m5AB2cXavvOdF80ZyHq0k7veC1DDNOJ+m7 NK+FS2HG8F7NzTfwyPcxipsxa1wQgFSksssmW5lEcVa2mUfd9typ8CCMjsxmRN3dC7ow=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 164783: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=b6bc203375b6efb6822ee4fe4a59be4f1918436b X-Osstest-Versions-That: ovmf=cae735f61328d64e2e8991036707b9e78c0f5f63 From: osstest service owner Date: Fri, 03 Sep 2021 00:26:36 +0000 flight 164783 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/164783/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 164674 build-amd64-xsm 6 xen-build fail REGR. vs. 164674 build-i386-xsm 6 xen-build fail REGR. vs. 164674 build-i386 6 xen-build fail REGR. vs. 164674 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf b6bc203375b6efb6822ee4fe4a59be4f1918436b baseline version: ovmf cae735f61328d64e2e8991036707b9e78c0f5f63 Last test of basis 164674 2021-08-31 02:56:52 Z 2 days Failing since 164686 2021-09-01 03:03:43 Z 1 days 17 attempts Testing same since 164764 2021-09-02 12:11:21 Z 0 days 5 attempts ------------------------------------------------------------ People who touched revisions under test: Anthony PERARD DunTan Gary Lin Jim Fehlig Lin, Gary (HPS OE-Linux) Loo Tung Lun Loo, Tung Lun Mark Wilson Marvin H?user Wenxing Hou Wenyi Xie jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit b6bc203375b6efb6822ee4fe4a59be4f1918436b Author: Wenyi Xie Date: Thu Aug 26 09:16:03 2021 +0800 MdeModulePkg/HiiDatabaseDxe:remove dead code block As the if statement outside has confirmed that BlockData->Name == NULL, so the if statement inside is always false. Cc: Jian J Wang Cc: Hao A Wu Cc: Dandan Bi Cc: Eric Dong Signed-off-by: Wenyi Xie Reviewed-by: Dandan Bi commit e3ee8c8dbd7a9f7d7905abe17be60354c9f5f9a3 Author: duntan Date: Fri Aug 20 14:43:37 2021 +0800 .azurepipelines: Add UefiPayloadPkg in gate-build-job.yml and CISetting.py Add UefiPayloadPkg in gate-build-job.yml to enable Core ci for UefiPayloadPkg. Add UefiPayloadPkg to supported Packages in CISettings. Cc: Sean Brogan Cc: Bret Barkelew Cc: Michael D Kinney Cc: Liming Gao Signed-off-by: DunTan Reviewed-by: Liming Gao commit 63fddc98e06c380e654b1cfbaf24b9fd922adfad Author: duntan Date: Fri Aug 20 14:43:36 2021 +0800 UefiPayloadPkg: Create .yaml file in UefiPayloadPkg Create .yaml file in UefiPayloadPkg to enable Core ci for UefiPayloadPkg Cc: Guo Dong Cc: Ray Ni Cc: Maurice Ma Cc: Benjamin You Signed-off-by: DunTan Reviewed-by: Liming Gao commit 12e33dca4c0612a0975265e5ba641c6261a26455 Author: Loo, Tung Lun Date: Tue Aug 17 15:43:12 2021 +0800 IntelFsp2Pkg: Support Config File and Binary delta comparison BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3567 This patch is to enable config editor to have a new feature that can spell out the delta between the default configuration files' data, such as YAML and BSF, against the data stored in the binary. This can help users understand and track the difference when modifications are made. Cc: Maurice Ma Cc: Nate DeSimone Cc: Star Zeng Cc: Chasel Chiu Signed-off-by: Loo Tung Lun Reviewed-by: Chasel Chiu commit b170806518c1e414939c8b085866544814e1ce8e Author: Mark Wilson Date: Fri Nov 13 08:05:18 2020 +0800 UefiCpuPkg: Clean up save state boundary checks and comments. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2956 In functions ReadSaveStateRegisterByIndex and WriteSaveStateRegister: * check width > 4 instead of >= 4 when writing upper 32 bytes. - This improves the code but will not affect functionality. Cc: Eric Dong Reviewed-by: Ray Ni Signed-off-by: Mark Wilson commit 3b3f88228812e2c642eea8746858a4dad928ebf7 Author: Marvin H?user Date: Mon Aug 9 14:09:25 2021 +0800 MdeModulePkg/PiSmmCore: Drop deprecated image profiling commands The legacy codebase allowed SMM images to be registered for profiling from DXE. Support for this has been dropped entirely, so remove the remaining handlers. Cc: Jian J Wang Cc: Hao A Wu Cc: Eric Dong Reviewed-by: Ray Ni Cc: Vitaly Cheptsov Signed-off-by: Marvin H?user commit cdda3f74a1327663a5d48cca13507085ba403af7 Author: Marvin H?user Date: Mon Aug 9 03:39:53 2021 +0800 UefiPayloadPkg/UefiPayloadEntry: Fix memory corruption UefiPayloadEntry's AllocatePool() applies the "sizeof" operator to HOB index rather than the HOB header structure. This yields 4 Bytes compared to the 8 Bytes the structure header requires. Fix the call to allocate the required space instead. Reviewed-by: Guo Dong Reviewed-by: Ray Ni Cc: Maurice Ma Cc: Benjamin You Cc: Vitaly Cheptsov Signed-off-by: Marvin H?user commit 5d34cc49d5d348012fe8acf9fb618826bd541a7c Author: Wenxing Hou Date: Tue Aug 24 16:11:11 2021 +0800 UefiCpuPkg/PiSmmCpuDxeSmm: Update mPatchCetSupported set condition REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3584 Function AsmCpuid should first check the value for Basic CPUID Information. The fix is to update the mPatchCetSupported judgment statement. Signed-off-by: Wenxing Hou Reviewed-by: Ray Ni Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Cc: Sheng W Cc: Yao Jiewen commit f0fe55bca4651734abf1752a1d7c69fb5bee00b9 Author: duntan Date: Fri Aug 20 13:04:29 2021 +0800 UefiPayloadPkg: Fix the build error when enable Core ci for UefiPayloadPkg V1: Add quotes when using $(ARCH) in .dsc and .fdf file. The quotes are added due to the way by which Core ci parse the .dsc file. Add UINTN in Hob.c to fix cast from pointer to integer of different size error. V2: Delete lines which reference ShellBinPkg.The pkg doesn't exist in edk2. Cc: Guo Dong Cc: Ray Ni Cc: Maurice Ma Cc: Benjamin You Signed-off-by: DunTan Reviewed-by: Ray Ni commit 9f3eda177a4b2d4a33ff1b0307cad42906396562 Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:29:48 2021 +0800 OvmfPkg/OvmfXen: add QemuKernelLoaderFsDxe Without QemuKernelLoaderFsDxe, QemuLoadKernelImage() couldn't download the kernel, initrd, and kernel command line from QEMU's fw_cfg. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3574 Signed-off-by: Gary Lin Acked-by: Anthony PERARD Reviewed-by: Philippe Mathieu-Daude Reviewed-by: Gerd Hoffmann Tested-by: Jim Fehlig commit 5b5f10d7465004e3e40ec1f50a3b490b4db595e7 Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:31:15 2021 +0800 OvmfPkg/SmmControl2Dxe: use PcdAcpiS3Enable to detect S3 support To avoid the potential inconsistency between PcdAcpiS3Enable and QemuFwCfgS3Enabled(), this commit modifies SmmControl2Dxe to detect S3 support by PcdAcpiS3Enable as modules in MdeModulePkg do. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3573 Signed-off-by: Gary Lin Reviewed-by: Gerd Hoffmann Reviewed-by: Jiewen Yao Tested-by: Jim Fehlig commit 52e2dabc0f8d3af09c213072ce8ba734302f585d Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:31:14 2021 +0800 OvmfPkg/PlatformBootManagerLib: use PcdAcpiS3Enable to detect S3 support To avoid the potential inconsistency between PcdAcpiS3Enable and QemuFwCfgS3Enabled(), this commit modifies PlatformBootManagerLib to detect S3 support by PcdAcpiS3Enable as modules in MdeModulePkg do. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3573 Signed-off-by: Gary Lin Reviewed-by: Gerd Hoffmann Reviewed-by: Jiewen Yao Tested-by: Jim Fehlig commit 28152333bccb778b62e6e97446b28bfa0e92ef82 Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:31:13 2021 +0800 OvmfPkg/LockBoxLib: use PcdAcpiS3Enable to detect S3 support To avoid the potential inconsistency between PcdAcpiS3Enable and QemuFwCfgS3Enabled(), this commit modifies LockBoxLib to detect S3 support by PcdAcpiS3Enable as modules in MdeModulePkg do. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3573 Signed-off-by: Gary Lin Reviewed-by: Philippe Mathieu-Daude Reviewed-by: Gerd Hoffmann Reviewed-by: Jiewen Yao Tested-by: Jim Fehlig commit cb0d24637dfdd869618b9635dfb8e3b0746393a6 Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:31:12 2021 +0800 OvmfPkg/OvmfXen: set PcdAcpiS3Enable at initialization There are several functions in OvmfPkg/Library using QemuFwCfgS3Enabled() to detect the S3 support status. However, in MdeModulePkg, PcdAcpiS3Enable is used to check S3 support. Since InitializeXenPlatform() didn't set PcdAcpiS3Enable as InitializePlatform() did, this made the inconsistency between drivers/functions. For example, S3SaveStateDxe checked PcdAcpiS3Enable and skipped S3BootScript because the default value is FALSE. On the other hand, PlatformBootManagerBeforeConsole() from OvmfPkg/Library called QemuFwCfgS3Enabled() and found it returned TRUE, so it invoked SaveS3BootScript(). However, S3SaveStateDxe skipped S3BootScript, so SaveS3BootScript() asserted due to EFI_NOT_FOUND. This issue mainly affects "HVM Direct Kernel Boot". When used, "fw_cfg" is enabled in QEMU and QemuFwCfgS3Enabled() returns true in that case. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3573 Signed-off-by: Gary Lin Reviewed-by: Anthony PERARD Reviewed-by: Gerd Hoffmann Reviewed-by: Jiewen Yao Tested-by: Jim Fehlig From xen-devel-bounces@lists.xenproject.org Fri Sep 03 00:39:20 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Sep 2021 00:39:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177734.323377 (Exim 4.92) (envelope-from ) id 1mLxEi-0006HT-1x; Fri, 03 Sep 2021 00:39:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177734.323377; Fri, 03 Sep 2021 00:39:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLxEh-0006HM-Uv; Fri, 03 Sep 2021 00:39:15 +0000 Received: by outflank-mailman (input) for mailman id 177734; Fri, 03 Sep 2021 00:39:14 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLxEg-0006HG-FY for xen-devel@lists.xenproject.org; Fri, 03 Sep 2021 00:39:14 +0000 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id fad1be8b-f4cb-46f7-9bd6-f67864842b01; Fri, 03 Sep 2021 00:39:13 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 7856860FD7; Fri, 3 Sep 2021 00:39:12 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fad1be8b-f4cb-46f7-9bd6-f67864842b01 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1630629552; bh=y2icUBNg0/9LSlQTIW4ms/VZvVLzZCQ5l/Hx8gsPjFA=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=JbW+IilMz5RIKz2a4HoJk92KHJ3AgT2cFEVw5W2grEqIxPJeVUu7VDf7HXfEaPIu1 /kCNDi+CJnY0fsLdEzQIi8MGfqN2If96vHySwv8SVlkwnJXjaUW089cxAy2Qvwe6JM 41JNGPnCu2rSIaiw2bbiX9FLTPLz/IYqUBtA5NQY/wkz5nZxjtpaxXzQueLAWnMtZg VnXqGdx6tKgcE+m8Kr+k4QMMy2cduN6Mvw9guj43uBGh8ktZzaWT+2PAudCUrjUNfi 0z6yxGkaH6R1YLlXeJ/AsgaWMq7fzicJFF9wjtbOZMDNFDZf0huEtS9QjHDIhzcy0p foBGWbaOzib6A== Date: Thu, 2 Sep 2021 17:39:11 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: Julien Grall cc: Stefano Stabellini , Penny Zheng , xen-devel@lists.xenproject.org, Bertrand.Marquis@arm.com, Wei.Chen@arm.com, nd@arm.com Subject: Re: [PATCH v5 7/7] xen/arm: introduce allocate_static_memory In-Reply-To: Message-ID: References: <20210824095045.2281500-1-penny.zheng@arm.com> <20210824095045.2281500-8-penny.zheng@arm.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Thu, 2 Sep 2021, Julien Grall wrote: > > > + kinfo->mem.nr_banks = ++gbank; > > > + kinfo->unassigned_mem -= tot_size; > > > + if ( kinfo->unassigned_mem ) > > > + { > > > + printk(XENLOG_ERR > > > + "Size of \"memory\" property doesn't match up with the > > > sum-up of \"xen,static-mem\".\n"); > > > + goto fail; > > > > Do we need to make this a fatal failure? > > > > I am asking because unassigned_mem comes from the "memory" property of > > the domain in device tree which is kind of redundant with the > > introduction of xen,static-mem. In fact, I think it would be better to > > clarify the role of "memory" when "xen,static-mem" is also present. > > In that case, we could even make "memory" optional. > > I requested to make it mandatory. Imagine you have a domU that has 1GB and now > you want to switch to static memory. If we make the property optional, then > there is a risk for the admin to not correctly pass the amount of memory. This > may become unnoticed until late. > > So I think making it mandatory is cheap for us and an easy way to confirm you > properly sized the region. It also has the benefits to easily find out how > much memory you gave to the guest (but that's just because I am lazy :)). > > > In any case, even if we don't make "memory" optional, it might still be > > good to turn this error into a warning and ignore the remaining > > kinfo->unassigned_mem. > > The behavior is matching the existing function and I think this is a good > idea. If you ask 10MB of memory and we only give you 9MB, then at some point > your guest is not going to be happy. > > It is much better to know it in advance with a failure over discovering hours > later when you see an OOM from your domain. OK, I didn't realize this was discussed already. Let's not revisit this then. My preference is primarily to make the device tree easier to write, but nowadays nobody I know is writing the device tree by hand anymore (they all use ImageBuilder). So if the device tree is generated then we are fine either way as long as the binding is clear. So I am OK to drop my suggestion of making "memory" optional. Let's think of a way to make "memory" and "xen,static-mem" coexist instead. There are two sides of the issue: - the Xen implementation - the binding The Xen implementation is fine to panic if memory != xen,static-mem. In that regard, the current patch is OK. >From the binding perspective, I think it would be good to add a statement to clarify. The binding doesn't necessarily need to match exactly the implementation as the binding should be as future proof and as flexible as possible. >From the binding perspective two properties should mean different things: memory the total memory amount and xen,static-mem the static memory. If one day we'll have more types of memory, memory will cover the total amount while xen,static-mem will cover a subset. So memory must be greater or equal to xen,static-mem (even if today Xen only supports memory == xen,static-mem). So I would add: """ As the memory property represents the total memory of the domain, hence the amount of memory selected by the memory property must be greater or equal to the total amount specified by xen,static-mem. Other configurations (memory amount less than xen,static-mem amount) are invalid. """ This sentence has the purpose of clarifying that "memory" still need to be populated and have a valid value. Then, it is OK for Xen to error out if memory doesn't match xen,static-mem because that's the only configuration supported. The error message could be: Size of "memory" property doesn't match up with the sum-up of "xen,static-mem". Unsupported configuration. From xen-devel-bounces@lists.xenproject.org Fri Sep 03 00:56:54 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Sep 2021 00:56:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177741.323399 (Exim 4.92) (envelope-from ) id 1mLxVi-0000kN-Nk; Fri, 03 Sep 2021 00:56:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177741.323399; Fri, 03 Sep 2021 00:56:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLxVi-0000kG-KR; Fri, 03 Sep 2021 00:56:50 +0000 Received: by outflank-mailman (input) for mailman id 177741; Fri, 03 Sep 2021 00:56:49 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLxVh-0000U1-DR for xen-devel@lists.xenproject.org; Fri, 03 Sep 2021 00:56:49 +0000 Received: from ozlabs.org (unknown [203.11.71.1]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id cc82b456-0c51-11ec-aee3-12813bfff9fa; Fri, 03 Sep 2021 00:56:43 +0000 (UTC) Received: by ozlabs.org (Postfix, from userid 1007) id 4H0zrk2nScz9sX3; Fri, 3 Sep 2021 10:56:38 +1000 (AEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cc82b456-0c51-11ec-aee3-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=201602; t=1630630598; bh=dYFvOAbI0hzwi7bgHPuL2nISN21A/HVkTWCIarLAldc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DMCqqC7Itikgm2VTUEE5MykJBeTtYQkUaBtP+KuJF/Y5jTcUC2LQWs1ef3S2IMUl3 RysX7Pwh5G3C+1QXEaTzQ5loyPMlyIRqnn+VJrtw1FLSH+R0ynhlUXGg+rbaiWSc1f 53PPEtkqp6WkbUnSX5FiujxAAdGniXO0crpUxZ60= Date: Fri, 3 Sep 2021 10:50:45 +1000 From: David Gibson To: Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= Cc: qemu-devel@nongnu.org, Bin Meng , Eduardo Habkost , Greg Kurz , haxm-team@intel.com, Kamil Rytarowski , qemu-ppc@nongnu.org, Anthony Perard , Marcel Apfelbaum , Michael Rolnik , qemu-riscv@nongnu.org, Paolo Bonzini , Jiaxun Yang , Thomas Huth , David Hildenbrand , Chris Wulff , Laurent Vivier , Cameron Esfahani , Sunil Muthuswamy , Max Filippov , Taylor Simpson , qemu-s390x@nongnu.org, Richard Henderson , Bastian Koppelmann , Yoshinori Sato , Artyom Tarasenko , Aurelien Jarno , Paul Durrant , Peter Maydell , Alistair Francis , "Edgar E. Iglesias" , Roman Bolshakov , Laurent Vivier , Cornelia Huck , qemu-arm@nongnu.org, Wenchao Wang , xen-devel@lists.xenproject.org, Marek Vasut , Stefano Stabellini , Aleksandar Rikalo , Mark Cave-Ayland , Colin Xu , Claudio Fontana , Palmer Dabbelt , Stafford Horne , Reinoud Zandijk , kvm@vger.kernel.org Subject: Re: [PATCH v3 21/30] target/ppc: Introduce PowerPCCPUClass::has_work() Message-ID: References: <20210902161543.417092-1-f4bug@amsat.org> <20210902161543.417092-22-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="iHh9kZyoW/xDyYBn" Content-Disposition: inline In-Reply-To: <20210902161543.417092-22-f4bug@amsat.org> --iHh9kZyoW/xDyYBn Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Sep 02, 2021 at 06:15:34PM +0200, Philippe Mathieu-Daud=E9 wrote: > Each POWER cpu has its own has_work() implementation. Instead of > overloading CPUClass on each PowerPCCPUClass init, register the > generic ppc_cpu_has_work() handler, and have it call the POWER > specific has_work(). I don't quite see the rationale for introducing a second layer of indirection here. What's wrong with switching the base has_work for each cpu variant? >=20 > Signed-off-by: Philippe Mathieu-Daud=E9 > --- > target/ppc/cpu-qom.h | 3 +++ > target/ppc/cpu_init.c | 26 ++++++++++++++++++-------- > 2 files changed, 21 insertions(+), 8 deletions(-) >=20 > diff --git a/target/ppc/cpu-qom.h b/target/ppc/cpu-qom.h > index 5800fa324e8..ff2bafcde6f 100644 > --- a/target/ppc/cpu-qom.h > +++ b/target/ppc/cpu-qom.h > @@ -189,6 +189,9 @@ struct PowerPCCPUClass { > int bfd_mach; > uint32_t l1_dcache_size, l1_icache_size; > #ifndef CONFIG_USER_ONLY > +#ifdef CONFIG_TCG > + bool (*has_work)(CPUState *cpu); > +#endif /* CONFIG_TCG */ > unsigned int gdb_num_sprs; > const char *gdb_spr_xml; > #endif > diff --git a/target/ppc/cpu_init.c b/target/ppc/cpu_init.c > index e2e721c2b81..bbad16cc1ec 100644 > --- a/target/ppc/cpu_init.c > +++ b/target/ppc/cpu_init.c > @@ -7583,6 +7583,7 @@ static bool ppc_pvr_match_power7(PowerPCCPUClass *p= cc, uint32_t pvr) > return false; > } > =20 > +#if defined(CONFIG_TCG) && !defined(CONFIG_USER_ONLY) > static bool cpu_has_work_POWER7(CPUState *cs) > { > PowerPCCPU *cpu =3D POWERPC_CPU(cs); > @@ -7616,12 +7617,12 @@ static bool cpu_has_work_POWER7(CPUState *cs) > return msr_ee && (cs->interrupt_request & CPU_INTERRUPT_HARD); > } > } > +#endif /* CONFIG_TCG && !CONFIG_USER_ONLY */ > =20 > POWERPC_FAMILY(POWER7)(ObjectClass *oc, void *data) > { > DeviceClass *dc =3D DEVICE_CLASS(oc); > PowerPCCPUClass *pcc =3D POWERPC_CPU_CLASS(oc); > - CPUClass *cc =3D CPU_CLASS(oc); > =20 > dc->fw_name =3D "PowerPC,POWER7"; > dc->desc =3D "POWER7"; > @@ -7630,7 +7631,6 @@ POWERPC_FAMILY(POWER7)(ObjectClass *oc, void *data) > pcc->pcr_supported =3D PCR_COMPAT_2_06 | PCR_COMPAT_2_05; > pcc->init_proc =3D init_proc_POWER7; > pcc->check_pow =3D check_pow_nocheck; > - cc->has_work =3D cpu_has_work_POWER7; > pcc->insns_flags =3D PPC_INSNS_BASE | PPC_ISEL | PPC_STRING | PPC_MF= TB | > PPC_FLOAT | PPC_FLOAT_FSEL | PPC_FLOAT_FRES | > PPC_FLOAT_FSQRT | PPC_FLOAT_FRSQRTE | > @@ -7673,6 +7673,7 @@ POWERPC_FAMILY(POWER7)(ObjectClass *oc, void *data) > pcc->lpcr_pm =3D LPCR_P7_PECE0 | LPCR_P7_PECE1 | LPCR_P7_PECE2; > pcc->mmu_model =3D POWERPC_MMU_2_06; > #if defined(CONFIG_SOFTMMU) > + pcc->has_work =3D cpu_has_work_POWER7; > pcc->hash64_opts =3D &ppc_hash64_opts_POWER7; > pcc->lrg_decr_bits =3D 32; > #endif > @@ -7743,6 +7744,7 @@ static bool ppc_pvr_match_power8(PowerPCCPUClass *p= cc, uint32_t pvr) > return false; > } > =20 > +#if defined(CONFIG_TCG) && !defined(CONFIG_USER_ONLY) > static bool cpu_has_work_POWER8(CPUState *cs) > { > PowerPCCPU *cpu =3D POWERPC_CPU(cs); > @@ -7784,12 +7786,12 @@ static bool cpu_has_work_POWER8(CPUState *cs) > return msr_ee && (cs->interrupt_request & CPU_INTERRUPT_HARD); > } > } > +#endif /* CONFIG_TCG && !CONFIG_USER_ONLY */ > =20 > POWERPC_FAMILY(POWER8)(ObjectClass *oc, void *data) > { > DeviceClass *dc =3D DEVICE_CLASS(oc); > PowerPCCPUClass *pcc =3D POWERPC_CPU_CLASS(oc); > - CPUClass *cc =3D CPU_CLASS(oc); > =20 > dc->fw_name =3D "PowerPC,POWER8"; > dc->desc =3D "POWER8"; > @@ -7798,7 +7800,6 @@ POWERPC_FAMILY(POWER8)(ObjectClass *oc, void *data) > pcc->pcr_supported =3D PCR_COMPAT_2_07 | PCR_COMPAT_2_06 | PCR_COMPA= T_2_05; > pcc->init_proc =3D init_proc_POWER8; > pcc->check_pow =3D check_pow_nocheck; > - cc->has_work =3D cpu_has_work_POWER8; > pcc->insns_flags =3D PPC_INSNS_BASE | PPC_ISEL | PPC_STRING | PPC_MF= TB | > PPC_FLOAT | PPC_FLOAT_FSEL | PPC_FLOAT_FRES | > PPC_FLOAT_FSQRT | PPC_FLOAT_FRSQRTE | > @@ -7848,6 +7849,7 @@ POWERPC_FAMILY(POWER8)(ObjectClass *oc, void *data) > LPCR_P8_PECE3 | LPCR_P8_PECE4; > pcc->mmu_model =3D POWERPC_MMU_2_07; > #if defined(CONFIG_SOFTMMU) > + pcc->has_work =3D cpu_has_work_POWER8; > pcc->hash64_opts =3D &ppc_hash64_opts_POWER7; > pcc->lrg_decr_bits =3D 32; > pcc->n_host_threads =3D 8; > @@ -7941,6 +7943,7 @@ static bool ppc_pvr_match_power9(PowerPCCPUClass *p= cc, uint32_t pvr) > return false; > } > =20 > +#if defined(CONFIG_TCG) && !defined(CONFIG_USER_ONLY) > static bool cpu_has_work_POWER9(CPUState *cs) > { > PowerPCCPU *cpu =3D POWERPC_CPU(cs); > @@ -7998,12 +8001,12 @@ static bool cpu_has_work_POWER9(CPUState *cs) > return msr_ee && (cs->interrupt_request & CPU_INTERRUPT_HARD); > } > } > +#endif /* CONFIG_TCG && !CONFIG_USER_ONLY */ > =20 > POWERPC_FAMILY(POWER9)(ObjectClass *oc, void *data) > { > DeviceClass *dc =3D DEVICE_CLASS(oc); > PowerPCCPUClass *pcc =3D POWERPC_CPU_CLASS(oc); > - CPUClass *cc =3D CPU_CLASS(oc); > =20 > dc->fw_name =3D "PowerPC,POWER9"; > dc->desc =3D "POWER9"; > @@ -8013,7 +8016,6 @@ POWERPC_FAMILY(POWER9)(ObjectClass *oc, void *data) > PCR_COMPAT_2_05; > pcc->init_proc =3D init_proc_POWER9; > pcc->check_pow =3D check_pow_nocheck; > - cc->has_work =3D cpu_has_work_POWER9; > pcc->insns_flags =3D PPC_INSNS_BASE | PPC_ISEL | PPC_STRING | PPC_MF= TB | > PPC_FLOAT | PPC_FLOAT_FSEL | PPC_FLOAT_FRES | > PPC_FLOAT_FSQRT | PPC_FLOAT_FRSQRTE | > @@ -8062,6 +8064,7 @@ POWERPC_FAMILY(POWER9)(ObjectClass *oc, void *data) > pcc->lpcr_pm =3D LPCR_PDEE | LPCR_HDEE | LPCR_EEE | LPCR_DEE | LPCR_= OEE; > pcc->mmu_model =3D POWERPC_MMU_3_00; > #if defined(CONFIG_SOFTMMU) > + pcc->has_work =3D cpu_has_work_POWER9; > /* segment page size remain the same */ > pcc->hash64_opts =3D &ppc_hash64_opts_POWER7; > pcc->radix_page_info =3D &POWER9_radix_page_info; > @@ -8150,6 +8153,7 @@ static bool ppc_pvr_match_power10(PowerPCCPUClass *= pcc, uint32_t pvr) > return false; > } > =20 > +#if defined(CONFIG_TCG) && !defined(CONFIG_USER_ONLY) > static bool cpu_has_work_POWER10(CPUState *cs) > { > PowerPCCPU *cpu =3D POWERPC_CPU(cs); > @@ -8207,12 +8211,12 @@ static bool cpu_has_work_POWER10(CPUState *cs) > return msr_ee && (cs->interrupt_request & CPU_INTERRUPT_HARD); > } > } > +#endif /* CONFIG_TCG && !CONFIG_USER_ONLY */ > =20 > POWERPC_FAMILY(POWER10)(ObjectClass *oc, void *data) > { > DeviceClass *dc =3D DEVICE_CLASS(oc); > PowerPCCPUClass *pcc =3D POWERPC_CPU_CLASS(oc); > - CPUClass *cc =3D CPU_CLASS(oc); > =20 > dc->fw_name =3D "PowerPC,POWER10"; > dc->desc =3D "POWER10"; > @@ -8223,7 +8227,6 @@ POWERPC_FAMILY(POWER10)(ObjectClass *oc, void *data) > PCR_COMPAT_2_06 | PCR_COMPAT_2_05; > pcc->init_proc =3D init_proc_POWER10; > pcc->check_pow =3D check_pow_nocheck; > - cc->has_work =3D cpu_has_work_POWER10; > pcc->insns_flags =3D PPC_INSNS_BASE | PPC_ISEL | PPC_STRING | PPC_MF= TB | > PPC_FLOAT | PPC_FLOAT_FSEL | PPC_FLOAT_FRES | > PPC_FLOAT_FSQRT | PPC_FLOAT_FRSQRTE | > @@ -8275,6 +8278,7 @@ POWERPC_FAMILY(POWER10)(ObjectClass *oc, void *data) > pcc->lpcr_pm =3D LPCR_PDEE | LPCR_HDEE | LPCR_EEE | LPCR_DEE | LPCR_= OEE; > pcc->mmu_model =3D POWERPC_MMU_3_00; > #if defined(CONFIG_SOFTMMU) > + pcc->has_work =3D cpu_has_work_POWER10; > /* segment page size remain the same */ > pcc->hash64_opts =3D &ppc_hash64_opts_POWER7; > pcc->radix_page_info =3D &POWER10_radix_page_info; > @@ -8796,6 +8800,12 @@ static bool ppc_cpu_has_work(CPUState *cs) > PowerPCCPU *cpu =3D POWERPC_CPU(cs); > CPUPPCState *env =3D &cpu->env; > =20 > + if (cs->halted) { > + PowerPCCPUClass *pcc =3D POWERPC_CPU_GET_CLASS(cpu); > + > + return pcc->has_work(cs); > + } > + > return msr_ee && (cs->interrupt_request & CPU_INTERRUPT_HARD); > } > #endif /* CONFIG_TCG && !CONFIG_USER_ONLY */ --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --iHh9kZyoW/xDyYBn Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEdfRlhq5hpmzETofcbDjKyiDZs5IFAmExcWUACgkQbDjKyiDZ s5Kd6Q/9ExvXgL0E8gsCJTsKVim2JIFxJm6lfW3Ljf0A7E4onyKybV1Gu4uLlUjF j5ELZ1+AgWr3vOUIhcBT5V1pGKvYXc37CpiQ15Q92DTTfHCcku03DesecGmle2lS SiUQFgxVA88pMj1bzbYdQhrwgNebNJzVUdmeGythMdPbN+U4NwFJ5BYs+hkj3v+U maeTd4I/tJOySTZhNbNsRi+zahzOxt/idmrjbJ/XoT8z9EUCF54IE/Xf9xKvgcbQ YMK+c4PePo2xQXuDozfJNurhJ++J94hysnxH1nihopOegCgBhy8ZyU2LjsXa6hdA GkUnVb7tG//kw3uEYkm2z+0a80ZLmXKuR2M0gkkkGQFEftHLF2ZLNo9ou8HuWEzd 1BeejEEKrUKGb7IoNwAZ3XgXZ2dErbwrvzKEIMNo6e0w7nnLSPpEgkEYQe0c6JEE ZUl0IAd541qcGbI8Ckerg652ymOvv4I3PhG7Rg3GhQhR4+7uByfOkGVAZwf+TPYM /EBZjio3zJrj3j5tl6xuC6y1GBefg601jAXvJUQzTOuQyxsgcujgKtvexCDztUoG fJIX+Pn1j5q54OAE7CRHS1YEiJXlzj58FDBMJ2p/sdqETP2iJ1KhfJQ8Vw9ObJ54 1qMEYGBJIChIYtsBLc2OkVECXoXqJr3yjVJ6wp5a+DW7vgtQtNs= =ay8o -----END PGP SIGNATURE----- --iHh9kZyoW/xDyYBn-- From xen-devel-bounces@lists.xenproject.org Fri Sep 03 00:56:54 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Sep 2021 00:56:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177740.323388 (Exim 4.92) (envelope-from ) id 1mLxVg-0000UE-GS; Fri, 03 Sep 2021 00:56:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177740.323388; Fri, 03 Sep 2021 00:56:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLxVg-0000U7-Cc; Fri, 03 Sep 2021 00:56:48 +0000 Received: by outflank-mailman (input) for mailman id 177740; Fri, 03 Sep 2021 00:56:46 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLxVc-0000U1-JY for xen-devel@lists.xenproject.org; Fri, 03 Sep 2021 00:56:46 +0000 Received: from ozlabs.org (unknown [203.11.71.1]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id cc7b6e30-0c51-11ec-aee3-12813bfff9fa; Fri, 03 Sep 2021 00:56:43 +0000 (UTC) Received: by ozlabs.org (Postfix, from userid 1007) id 4H0zrk2QpHz9sCD; Fri, 3 Sep 2021 10:56:38 +1000 (AEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cc7b6e30-0c51-11ec-aee3-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=201602; t=1630630598; bh=XXRA9E9bkfiMuArjbNTfx+r3Un7G6QIyGWXT2AEimqw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=S/oOJX4wVez+0NVv34NrPleBWRl5YwYrRYxkIYCYr2DBSXFoQW3ujaLS8VYNkCkdh k+y3JMpbgn9tPsrOUDPXq+7t9kf9MvRy3873T3nWL9uuJ/xjlikC8YswJYUk9vfu76 vduXzNxO6Vij/+kbOiSMh1QGiktvH/h6gdwa0iwg= Date: Fri, 3 Sep 2021 10:49:20 +1000 From: David Gibson To: Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= Cc: qemu-devel@nongnu.org, Bin Meng , Eduardo Habkost , Greg Kurz , haxm-team@intel.com, Kamil Rytarowski , qemu-ppc@nongnu.org, Anthony Perard , Marcel Apfelbaum , Michael Rolnik , qemu-riscv@nongnu.org, Paolo Bonzini , Jiaxun Yang , Thomas Huth , David Hildenbrand , Chris Wulff , Laurent Vivier , Cameron Esfahani , Sunil Muthuswamy , Max Filippov , Taylor Simpson , qemu-s390x@nongnu.org, Richard Henderson , Bastian Koppelmann , Yoshinori Sato , Artyom Tarasenko , Aurelien Jarno , Paul Durrant , Peter Maydell , Alistair Francis , "Edgar E. Iglesias" , Roman Bolshakov , Laurent Vivier , Cornelia Huck , qemu-arm@nongnu.org, Wenchao Wang , xen-devel@lists.xenproject.org, Marek Vasut , Stefano Stabellini , Aleksandar Rikalo , Mark Cave-Ayland , Colin Xu , Claudio Fontana , Palmer Dabbelt , Stafford Horne , Reinoud Zandijk , kvm@vger.kernel.org Subject: Re: [PATCH v3 20/30] target/ppc: Restrict has_work() handler to sysemu and TCG Message-ID: References: <20210902161543.417092-1-f4bug@amsat.org> <20210902161543.417092-21-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="6Kw+8nBbrWcu5Nha" Content-Disposition: inline In-Reply-To: <20210902161543.417092-21-f4bug@amsat.org> --6Kw+8nBbrWcu5Nha Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Sep 02, 2021 at 06:15:33PM +0200, Philippe Mathieu-Daud=E9 wrote: > Restrict has_work() to TCG sysemu. >=20 > Signed-off-by: Philippe Mathieu-Daud=E9 Acked-by: David Gibson > --- > target/ppc/cpu_init.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) >=20 > diff --git a/target/ppc/cpu_init.c b/target/ppc/cpu_init.c > index 6aad01d1d3a..e2e721c2b81 100644 > --- a/target/ppc/cpu_init.c > +++ b/target/ppc/cpu_init.c > @@ -8790,6 +8790,7 @@ static void ppc_cpu_set_pc(CPUState *cs, vaddr valu= e) > cpu->env.nip =3D value; > } > =20 > +#if defined(CONFIG_TCG) && !defined(CONFIG_USER_ONLY) > static bool ppc_cpu_has_work(CPUState *cs) > { > PowerPCCPU *cpu =3D POWERPC_CPU(cs); > @@ -8797,6 +8798,7 @@ static bool ppc_cpu_has_work(CPUState *cs) > =20 > return msr_ee && (cs->interrupt_request & CPU_INTERRUPT_HARD); > } > +#endif /* CONFIG_TCG && !CONFIG_USER_ONLY */ > =20 > static void ppc_cpu_reset(DeviceState *dev) > { > @@ -9017,6 +9019,7 @@ static const struct TCGCPUOps ppc_tcg_ops =3D { > .tlb_fill =3D ppc_cpu_tlb_fill, > =20 > #ifndef CONFIG_USER_ONLY > + .has_work =3D ppc_cpu_has_work, > .cpu_exec_interrupt =3D ppc_cpu_exec_interrupt, > .do_interrupt =3D ppc_cpu_do_interrupt, > .cpu_exec_enter =3D ppc_cpu_exec_enter, > @@ -9042,7 +9045,6 @@ static void ppc_cpu_class_init(ObjectClass *oc, voi= d *data) > device_class_set_parent_reset(dc, ppc_cpu_reset, &pcc->parent_reset); > =20 > cc->class_by_name =3D ppc_cpu_class_by_name; > - cc->has_work =3D ppc_cpu_has_work; > cc->dump_state =3D ppc_cpu_dump_state; > cc->set_pc =3D ppc_cpu_set_pc; > cc->gdb_read_register =3D ppc_cpu_gdb_read_register; --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --6Kw+8nBbrWcu5Nha Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEdfRlhq5hpmzETofcbDjKyiDZs5IFAmExcRAACgkQbDjKyiDZ s5IeEBAAv3cpcInuLFJXsDvzVly7wSr5p5Tp9oNaBy8UvvGyoBX2eesw8Om/A3+P S/tu8jqAI/GRfxWwBaE+wNg+Fmpdl3CK+ThR/6t9NA5BhoBwy5rwsM4V32BYkawN NS5jP+L14XMC5MMa9o1IbnrNIPcpSA7kLTxq6sZxP1UaSvLecauVW2a14q630sUN 0mQEVEq0V/dO9bB01U775VN8Nzwxc6khrC8oufvhvSL22oYCjQTvOTslr7LEN5Ro Bb/6zxAXhGR1A8aBLekm7RSlqY767gZjEtIdn1zjx6g/owGyARjDez0rzwhiBL8C WqVsrRndk6jLRe1SJSRpZvgCx0EybrQyITVbeyMM4A/lXZYmDD2HKvOuXpUtnNZg frxhAADG1KW6Y1Ufvklqyz9YGnFpztZL6XevPw1xfXXFvC3jyZpBNYP5XrilV44G Sl7xomR8sRiJqzvJ2fWj475h07KiQ5NjXVvX5NvWy4okv9IphyXh8JoxyQsrA2b5 zIuqvUOy4GNPsunnxcNha90XiMsN6i5ds/ibiTyMwKbllU/hgUI3GEKVICncvbGt LmIo3UFw/vTG7+lqCUxRZUtGBBgDZlsyxpkAGXfiBf+aISLrhsCHQeXxbD18AGBO tECHtorVH7MbCNLHks/1Ey6DsZyaJnMdBoNjA+d4GpSUzASXzxI= =o8a9 -----END PGP SIGNATURE----- --6Kw+8nBbrWcu5Nha-- From xen-devel-bounces@lists.xenproject.org Fri Sep 03 01:50:40 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Sep 2021 01:50:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177753.323410 (Exim 4.92) (envelope-from ) id 1mLyLb-0005xR-K6; Fri, 03 Sep 2021 01:50:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177753.323410; Fri, 03 Sep 2021 01:50:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLyLb-0005xK-FO; Fri, 03 Sep 2021 01:50:27 +0000 Received: by outflank-mailman (input) for mailman id 177753; Fri, 03 Sep 2021 01:50:25 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLyLZ-0005xA-U9; Fri, 03 Sep 2021 01:50:25 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLyLZ-0000Df-Kr; Fri, 03 Sep 2021 01:50:25 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLyLZ-0007ls-D3; Fri, 03 Sep 2021 01:50:25 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mLyLZ-0007dx-Cb; Fri, 03 Sep 2021 01:50:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=1ujK+iTDU59k+1UNmmjPHa/4ecj4ziFwVX6SuXg0gsQ=; b=dcwsrY8OVC9eFEOhhxt0SPtqiJ HWH5HR5gPQNjam/R47Zm2YiImT/EqZpilUVMq4BFaiRKalE1V6MGmuKa4vWSAaaagAuReZ/dzmUHL 3kxto20JZDwKvfq0LQCOUAZwxsvqY1qUE7q1P2fpU5G9UWWHmtE8KsAavjFXvY+Bj+do=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xtf test] 164779: all pass - PUSHED X-Osstest-Versions-This: xtf=0bb720b3c486bd3de62b8c32282eb5fa192b87f3 X-Osstest-Versions-That: xtf=bc26bc260cbfec1c6de1778ef17cf0faa54c0e03 From: osstest service owner Date: Fri, 03 Sep 2021 01:50:25 +0000 flight 164779 xtf real [real] http://logs.test-lab.xenproject.org/osstest/logs/164779/ Perfect :-) All tests in this flight passed as required version targeted for testing: xtf 0bb720b3c486bd3de62b8c32282eb5fa192b87f3 baseline version: xtf bc26bc260cbfec1c6de1778ef17cf0faa54c0e03 Last test of basis 164255 2021-08-19 12:11:19 Z 14 days Testing same since 164779 2021-09-02 21:40:04 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Jan Beulich jobs: build-amd64-xtf pass build-amd64 pass build-amd64-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xtf.git bc26bc2..0bb720b 0bb720b3c486bd3de62b8c32282eb5fa192b87f3 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Fri Sep 03 01:54:26 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Sep 2021 01:54:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177761.323424 (Exim 4.92) (envelope-from ) id 1mLyPS-0006tC-9F; Fri, 03 Sep 2021 01:54:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177761.323424; Fri, 03 Sep 2021 01:54:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLyPS-0006t5-6E; Fri, 03 Sep 2021 01:54:26 +0000 Received: by outflank-mailman (input) for mailman id 177761; Fri, 03 Sep 2021 01:54:25 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLyPR-0006sv-8a; Fri, 03 Sep 2021 01:54:25 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLyPR-0000Gv-2T; Fri, 03 Sep 2021 01:54:25 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLyPQ-0007sr-Qa; Fri, 03 Sep 2021 01:54:24 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mLyPQ-0006FV-Q1; Fri, 03 Sep 2021 01:54:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=jHB5/zQ4SzYASPkgspu/hZZx51XzGV9O2fY/3kBcv5U=; b=Y1nlaSDY2FuHAE47btf8+YTcXt IzKng/TtHKL5S4pv9YuplSVXLU0zXLJOvdDZfZLc1dsTmNahXn60MVe+mP0lHAvFknAB7E+bQi9Fj LX7i3hf/3iHFr0ncSZHGAPdgXjFBzyZ324Qov3wGvZlGJHo76GvbLJfobuIcn+0fIH1k=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 164772: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=9093028dd48c50bc0392791f78aab44afef57ead X-Osstest-Versions-That: qemuu=079b1252e9de384385c9da910262312ec2e574c8 From: osstest service owner Date: Fri, 03 Sep 2021 01:54:24 +0000 flight 164772 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/164772/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail REGR. vs. 164757 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 164757 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 164757 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 164757 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 164757 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 164757 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 164757 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 164757 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass version targeted for testing: qemuu 9093028dd48c50bc0392791f78aab44afef57ead baseline version: qemuu 079b1252e9de384385c9da910262312ec2e574c8 Last test of basis 164757 2021-09-02 08:06:50 Z 0 days Testing same since 164772 2021-09-02 18:37:11 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Emanuele Giuseppe Esposito Fabrice Fontaine Hanna Reitz Helge Konetzka Igor Mammedov John Snow Mao Zhongyi Markus Armbruster Peter Maydell Stefan Berger Stefan Hajnoczi Viktor Prutyanov Vladimir Sementsov-Ogievskiy jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git 079b1252e9..9093028dd4 9093028dd48c50bc0392791f78aab44afef57ead -> upstream-tested From xen-devel-bounces@lists.xenproject.org Fri Sep 03 03:14:29 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Sep 2021 03:14:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177768.323438 (Exim 4.92) (envelope-from ) id 1mLzef-00083G-7l; Fri, 03 Sep 2021 03:14:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177768.323438; Fri, 03 Sep 2021 03:14:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLzef-000839-4R; Fri, 03 Sep 2021 03:14:13 +0000 Received: by outflank-mailman (input) for mailman id 177768; Fri, 03 Sep 2021 03:14:12 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLzee-00082z-21; Fri, 03 Sep 2021 03:14:12 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLzed-00028j-HT; Fri, 03 Sep 2021 03:14:11 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mLzed-0002k4-Af; Fri, 03 Sep 2021 03:14:11 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mLzed-0006Qv-AA; Fri, 03 Sep 2021 03:14:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=WUWEXrQitFnaxbytGCo71zA7joD/Ycj1vPvOweG3KRk=; b=Zk/wflipNCqZMCD04eyEoaYCHm tQfZ9dFH50peqiQafQs+73RQoRKYXd0GZEMEhIEhSSzmQlcoFBx5w7yI8Jxr7m6prm4vGuFgSDZP8 4/2NP1E2NuT2GcRiQaKIEwftreLN+W/ACPJzH8MZJ8pCOqG8K6woSWq6d6enHgHufYQo=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 164785: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=b6bc203375b6efb6822ee4fe4a59be4f1918436b X-Osstest-Versions-That: ovmf=cae735f61328d64e2e8991036707b9e78c0f5f63 From: osstest service owner Date: Fri, 03 Sep 2021 03:14:11 +0000 flight 164785 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/164785/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 164674 build-amd64-xsm 6 xen-build fail REGR. vs. 164674 build-i386-xsm 6 xen-build fail REGR. vs. 164674 build-i386 6 xen-build fail REGR. vs. 164674 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf b6bc203375b6efb6822ee4fe4a59be4f1918436b baseline version: ovmf cae735f61328d64e2e8991036707b9e78c0f5f63 Last test of basis 164674 2021-08-31 02:56:52 Z 3 days Failing since 164686 2021-09-01 03:03:43 Z 2 days 18 attempts Testing same since 164764 2021-09-02 12:11:21 Z 0 days 6 attempts ------------------------------------------------------------ People who touched revisions under test: Anthony PERARD DunTan Gary Lin Jim Fehlig Lin, Gary (HPS OE-Linux) Loo Tung Lun Loo, Tung Lun Mark Wilson Marvin H?user Wenxing Hou Wenyi Xie jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit b6bc203375b6efb6822ee4fe4a59be4f1918436b Author: Wenyi Xie Date: Thu Aug 26 09:16:03 2021 +0800 MdeModulePkg/HiiDatabaseDxe:remove dead code block As the if statement outside has confirmed that BlockData->Name == NULL, so the if statement inside is always false. Cc: Jian J Wang Cc: Hao A Wu Cc: Dandan Bi Cc: Eric Dong Signed-off-by: Wenyi Xie Reviewed-by: Dandan Bi commit e3ee8c8dbd7a9f7d7905abe17be60354c9f5f9a3 Author: duntan Date: Fri Aug 20 14:43:37 2021 +0800 .azurepipelines: Add UefiPayloadPkg in gate-build-job.yml and CISetting.py Add UefiPayloadPkg in gate-build-job.yml to enable Core ci for UefiPayloadPkg. Add UefiPayloadPkg to supported Packages in CISettings. Cc: Sean Brogan Cc: Bret Barkelew Cc: Michael D Kinney Cc: Liming Gao Signed-off-by: DunTan Reviewed-by: Liming Gao commit 63fddc98e06c380e654b1cfbaf24b9fd922adfad Author: duntan Date: Fri Aug 20 14:43:36 2021 +0800 UefiPayloadPkg: Create .yaml file in UefiPayloadPkg Create .yaml file in UefiPayloadPkg to enable Core ci for UefiPayloadPkg Cc: Guo Dong Cc: Ray Ni Cc: Maurice Ma Cc: Benjamin You Signed-off-by: DunTan Reviewed-by: Liming Gao commit 12e33dca4c0612a0975265e5ba641c6261a26455 Author: Loo, Tung Lun Date: Tue Aug 17 15:43:12 2021 +0800 IntelFsp2Pkg: Support Config File and Binary delta comparison BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3567 This patch is to enable config editor to have a new feature that can spell out the delta between the default configuration files' data, such as YAML and BSF, against the data stored in the binary. This can help users understand and track the difference when modifications are made. Cc: Maurice Ma Cc: Nate DeSimone Cc: Star Zeng Cc: Chasel Chiu Signed-off-by: Loo Tung Lun Reviewed-by: Chasel Chiu commit b170806518c1e414939c8b085866544814e1ce8e Author: Mark Wilson Date: Fri Nov 13 08:05:18 2020 +0800 UefiCpuPkg: Clean up save state boundary checks and comments. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2956 In functions ReadSaveStateRegisterByIndex and WriteSaveStateRegister: * check width > 4 instead of >= 4 when writing upper 32 bytes. - This improves the code but will not affect functionality. Cc: Eric Dong Reviewed-by: Ray Ni Signed-off-by: Mark Wilson commit 3b3f88228812e2c642eea8746858a4dad928ebf7 Author: Marvin H?user Date: Mon Aug 9 14:09:25 2021 +0800 MdeModulePkg/PiSmmCore: Drop deprecated image profiling commands The legacy codebase allowed SMM images to be registered for profiling from DXE. Support for this has been dropped entirely, so remove the remaining handlers. Cc: Jian J Wang Cc: Hao A Wu Cc: Eric Dong Reviewed-by: Ray Ni Cc: Vitaly Cheptsov Signed-off-by: Marvin H?user commit cdda3f74a1327663a5d48cca13507085ba403af7 Author: Marvin H?user Date: Mon Aug 9 03:39:53 2021 +0800 UefiPayloadPkg/UefiPayloadEntry: Fix memory corruption UefiPayloadEntry's AllocatePool() applies the "sizeof" operator to HOB index rather than the HOB header structure. This yields 4 Bytes compared to the 8 Bytes the structure header requires. Fix the call to allocate the required space instead. Reviewed-by: Guo Dong Reviewed-by: Ray Ni Cc: Maurice Ma Cc: Benjamin You Cc: Vitaly Cheptsov Signed-off-by: Marvin H?user commit 5d34cc49d5d348012fe8acf9fb618826bd541a7c Author: Wenxing Hou Date: Tue Aug 24 16:11:11 2021 +0800 UefiCpuPkg/PiSmmCpuDxeSmm: Update mPatchCetSupported set condition REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3584 Function AsmCpuid should first check the value for Basic CPUID Information. The fix is to update the mPatchCetSupported judgment statement. Signed-off-by: Wenxing Hou Reviewed-by: Ray Ni Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Cc: Sheng W Cc: Yao Jiewen commit f0fe55bca4651734abf1752a1d7c69fb5bee00b9 Author: duntan Date: Fri Aug 20 13:04:29 2021 +0800 UefiPayloadPkg: Fix the build error when enable Core ci for UefiPayloadPkg V1: Add quotes when using $(ARCH) in .dsc and .fdf file. The quotes are added due to the way by which Core ci parse the .dsc file. Add UINTN in Hob.c to fix cast from pointer to integer of different size error. V2: Delete lines which reference ShellBinPkg.The pkg doesn't exist in edk2. Cc: Guo Dong Cc: Ray Ni Cc: Maurice Ma Cc: Benjamin You Signed-off-by: DunTan Reviewed-by: Ray Ni commit 9f3eda177a4b2d4a33ff1b0307cad42906396562 Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:29:48 2021 +0800 OvmfPkg/OvmfXen: add QemuKernelLoaderFsDxe Without QemuKernelLoaderFsDxe, QemuLoadKernelImage() couldn't download the kernel, initrd, and kernel command line from QEMU's fw_cfg. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3574 Signed-off-by: Gary Lin Acked-by: Anthony PERARD Reviewed-by: Philippe Mathieu-Daude Reviewed-by: Gerd Hoffmann Tested-by: Jim Fehlig commit 5b5f10d7465004e3e40ec1f50a3b490b4db595e7 Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:31:15 2021 +0800 OvmfPkg/SmmControl2Dxe: use PcdAcpiS3Enable to detect S3 support To avoid the potential inconsistency between PcdAcpiS3Enable and QemuFwCfgS3Enabled(), this commit modifies SmmControl2Dxe to detect S3 support by PcdAcpiS3Enable as modules in MdeModulePkg do. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3573 Signed-off-by: Gary Lin Reviewed-by: Gerd Hoffmann Reviewed-by: Jiewen Yao Tested-by: Jim Fehlig commit 52e2dabc0f8d3af09c213072ce8ba734302f585d Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:31:14 2021 +0800 OvmfPkg/PlatformBootManagerLib: use PcdAcpiS3Enable to detect S3 support To avoid the potential inconsistency between PcdAcpiS3Enable and QemuFwCfgS3Enabled(), this commit modifies PlatformBootManagerLib to detect S3 support by PcdAcpiS3Enable as modules in MdeModulePkg do. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3573 Signed-off-by: Gary Lin Reviewed-by: Gerd Hoffmann Reviewed-by: Jiewen Yao Tested-by: Jim Fehlig commit 28152333bccb778b62e6e97446b28bfa0e92ef82 Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:31:13 2021 +0800 OvmfPkg/LockBoxLib: use PcdAcpiS3Enable to detect S3 support To avoid the potential inconsistency between PcdAcpiS3Enable and QemuFwCfgS3Enabled(), this commit modifies LockBoxLib to detect S3 support by PcdAcpiS3Enable as modules in MdeModulePkg do. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3573 Signed-off-by: Gary Lin Reviewed-by: Philippe Mathieu-Daude Reviewed-by: Gerd Hoffmann Reviewed-by: Jiewen Yao Tested-by: Jim Fehlig commit cb0d24637dfdd869618b9635dfb8e3b0746393a6 Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:31:12 2021 +0800 OvmfPkg/OvmfXen: set PcdAcpiS3Enable at initialization There are several functions in OvmfPkg/Library using QemuFwCfgS3Enabled() to detect the S3 support status. However, in MdeModulePkg, PcdAcpiS3Enable is used to check S3 support. Since InitializeXenPlatform() didn't set PcdAcpiS3Enable as InitializePlatform() did, this made the inconsistency between drivers/functions. For example, S3SaveStateDxe checked PcdAcpiS3Enable and skipped S3BootScript because the default value is FALSE. On the other hand, PlatformBootManagerBeforeConsole() from OvmfPkg/Library called QemuFwCfgS3Enabled() and found it returned TRUE, so it invoked SaveS3BootScript(). However, S3SaveStateDxe skipped S3BootScript, so SaveS3BootScript() asserted due to EFI_NOT_FOUND. This issue mainly affects "HVM Direct Kernel Boot". When used, "fw_cfg" is enabled in QEMU and QemuFwCfgS3Enabled() returns true in that case. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3573 Signed-off-by: Gary Lin Reviewed-by: Anthony PERARD Reviewed-by: Gerd Hoffmann Reviewed-by: Jiewen Yao Tested-by: Jim Fehlig From xen-devel-bounces@lists.xenproject.org Fri Sep 03 04:03:34 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Sep 2021 04:03:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177776.323452 (Exim 4.92) (envelope-from ) id 1mM0QH-0005ed-4w; Fri, 03 Sep 2021 04:03:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177776.323452; Fri, 03 Sep 2021 04:03:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mM0QH-0005eW-1e; Fri, 03 Sep 2021 04:03:25 +0000 Received: by outflank-mailman (input) for mailman id 177776; Fri, 03 Sep 2021 04:03:23 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mM0QF-0005eM-PW; Fri, 03 Sep 2021 04:03:23 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mM0QF-00030n-LC; Fri, 03 Sep 2021 04:03:23 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mM0QF-0004SL-DB; Fri, 03 Sep 2021 04:03:23 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mM0QF-0008En-Cg; Fri, 03 Sep 2021 04:03:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=rsXgzcxBi6Xc/X046RMTmmh7ckaC+iGBPRglI2cMeHQ=; b=LIk03MU2GCKpaWKjpwlDuGc4Fj kZncIy089+7AgjjDTMDzGwt+/YhsoKlp42BQBvUWl+tNAn1nfHXhx0NwrjCp31cwmMkX02Qej7wQh rdWqf1oxCT6w80Tndr4ZsbiCeoLtsGAA5aVHdcJ6BXAMumogsPwTwQOz9Pg/buGu3Guk=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 164787: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=c5e805ffe1098601e84fd501d5fa1d45e9d96a62 X-Osstest-Versions-That: ovmf=cae735f61328d64e2e8991036707b9e78c0f5f63 From: osstest service owner Date: Fri, 03 Sep 2021 04:03:23 +0000 flight 164787 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/164787/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 164674 build-amd64-xsm 6 xen-build fail REGR. vs. 164674 build-i386-xsm 6 xen-build fail REGR. vs. 164674 build-i386 6 xen-build fail REGR. vs. 164674 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf c5e805ffe1098601e84fd501d5fa1d45e9d96a62 baseline version: ovmf cae735f61328d64e2e8991036707b9e78c0f5f63 Last test of basis 164674 2021-08-31 02:56:52 Z 3 days Failing since 164686 2021-09-01 03:03:43 Z 2 days 19 attempts Testing same since 164787 2021-09-03 03:15:52 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Anthony PERARD DunTan Gary Lin Jim Fehlig Lin, Gary (HPS OE-Linux) Loo Tung Lun Loo, Tung Lun Mark Wilson Marvin H?user Rebecca Cran Wenxing Hou Wenyi Xie jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit c5e805ffe1098601e84fd501d5fa1d45e9d96a62 Author: Rebecca Cran Date: Tue Aug 31 06:36:36 2021 +0800 MdeModulePkg: Fix typo of "memory" in RamDiskDxe debug message Fix a typo of "memory" in a debug message in RamDiskProtocol.c. Signed-off-by: Rebecca Cran Reviewed-by: Hao A Wu Reviewed-by: Philippe Mathieu-Daude commit b6bc203375b6efb6822ee4fe4a59be4f1918436b Author: Wenyi Xie Date: Thu Aug 26 09:16:03 2021 +0800 MdeModulePkg/HiiDatabaseDxe:remove dead code block As the if statement outside has confirmed that BlockData->Name == NULL, so the if statement inside is always false. Cc: Jian J Wang Cc: Hao A Wu Cc: Dandan Bi Cc: Eric Dong Signed-off-by: Wenyi Xie Reviewed-by: Dandan Bi commit e3ee8c8dbd7a9f7d7905abe17be60354c9f5f9a3 Author: duntan Date: Fri Aug 20 14:43:37 2021 +0800 .azurepipelines: Add UefiPayloadPkg in gate-build-job.yml and CISetting.py Add UefiPayloadPkg in gate-build-job.yml to enable Core ci for UefiPayloadPkg. Add UefiPayloadPkg to supported Packages in CISettings. Cc: Sean Brogan Cc: Bret Barkelew Cc: Michael D Kinney Cc: Liming Gao Signed-off-by: DunTan Reviewed-by: Liming Gao commit 63fddc98e06c380e654b1cfbaf24b9fd922adfad Author: duntan Date: Fri Aug 20 14:43:36 2021 +0800 UefiPayloadPkg: Create .yaml file in UefiPayloadPkg Create .yaml file in UefiPayloadPkg to enable Core ci for UefiPayloadPkg Cc: Guo Dong Cc: Ray Ni Cc: Maurice Ma Cc: Benjamin You Signed-off-by: DunTan Reviewed-by: Liming Gao commit 12e33dca4c0612a0975265e5ba641c6261a26455 Author: Loo, Tung Lun Date: Tue Aug 17 15:43:12 2021 +0800 IntelFsp2Pkg: Support Config File and Binary delta comparison BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3567 This patch is to enable config editor to have a new feature that can spell out the delta between the default configuration files' data, such as YAML and BSF, against the data stored in the binary. This can help users understand and track the difference when modifications are made. Cc: Maurice Ma Cc: Nate DeSimone Cc: Star Zeng Cc: Chasel Chiu Signed-off-by: Loo Tung Lun Reviewed-by: Chasel Chiu commit b170806518c1e414939c8b085866544814e1ce8e Author: Mark Wilson Date: Fri Nov 13 08:05:18 2020 +0800 UefiCpuPkg: Clean up save state boundary checks and comments. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2956 In functions ReadSaveStateRegisterByIndex and WriteSaveStateRegister: * check width > 4 instead of >= 4 when writing upper 32 bytes. - This improves the code but will not affect functionality. Cc: Eric Dong Reviewed-by: Ray Ni Signed-off-by: Mark Wilson commit 3b3f88228812e2c642eea8746858a4dad928ebf7 Author: Marvin H?user Date: Mon Aug 9 14:09:25 2021 +0800 MdeModulePkg/PiSmmCore: Drop deprecated image profiling commands The legacy codebase allowed SMM images to be registered for profiling from DXE. Support for this has been dropped entirely, so remove the remaining handlers. Cc: Jian J Wang Cc: Hao A Wu Cc: Eric Dong Reviewed-by: Ray Ni Cc: Vitaly Cheptsov Signed-off-by: Marvin H?user commit cdda3f74a1327663a5d48cca13507085ba403af7 Author: Marvin H?user Date: Mon Aug 9 03:39:53 2021 +0800 UefiPayloadPkg/UefiPayloadEntry: Fix memory corruption UefiPayloadEntry's AllocatePool() applies the "sizeof" operator to HOB index rather than the HOB header structure. This yields 4 Bytes compared to the 8 Bytes the structure header requires. Fix the call to allocate the required space instead. Reviewed-by: Guo Dong Reviewed-by: Ray Ni Cc: Maurice Ma Cc: Benjamin You Cc: Vitaly Cheptsov Signed-off-by: Marvin H?user commit 5d34cc49d5d348012fe8acf9fb618826bd541a7c Author: Wenxing Hou Date: Tue Aug 24 16:11:11 2021 +0800 UefiCpuPkg/PiSmmCpuDxeSmm: Update mPatchCetSupported set condition REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3584 Function AsmCpuid should first check the value for Basic CPUID Information. The fix is to update the mPatchCetSupported judgment statement. Signed-off-by: Wenxing Hou Reviewed-by: Ray Ni Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Cc: Sheng W Cc: Yao Jiewen commit f0fe55bca4651734abf1752a1d7c69fb5bee00b9 Author: duntan Date: Fri Aug 20 13:04:29 2021 +0800 UefiPayloadPkg: Fix the build error when enable Core ci for UefiPayloadPkg V1: Add quotes when using $(ARCH) in .dsc and .fdf file. The quotes are added due to the way by which Core ci parse the .dsc file. Add UINTN in Hob.c to fix cast from pointer to integer of different size error. V2: Delete lines which reference ShellBinPkg.The pkg doesn't exist in edk2. Cc: Guo Dong Cc: Ray Ni Cc: Maurice Ma Cc: Benjamin You Signed-off-by: DunTan Reviewed-by: Ray Ni commit 9f3eda177a4b2d4a33ff1b0307cad42906396562 Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:29:48 2021 +0800 OvmfPkg/OvmfXen: add QemuKernelLoaderFsDxe Without QemuKernelLoaderFsDxe, QemuLoadKernelImage() couldn't download the kernel, initrd, and kernel command line from QEMU's fw_cfg. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3574 Signed-off-by: Gary Lin Acked-by: Anthony PERARD Reviewed-by: Philippe Mathieu-Daude Reviewed-by: Gerd Hoffmann Tested-by: Jim Fehlig commit 5b5f10d7465004e3e40ec1f50a3b490b4db595e7 Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:31:15 2021 +0800 OvmfPkg/SmmControl2Dxe: use PcdAcpiS3Enable to detect S3 support To avoid the potential inconsistency between PcdAcpiS3Enable and QemuFwCfgS3Enabled(), this commit modifies SmmControl2Dxe to detect S3 support by PcdAcpiS3Enable as modules in MdeModulePkg do. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3573 Signed-off-by: Gary Lin Reviewed-by: Gerd Hoffmann Reviewed-by: Jiewen Yao Tested-by: Jim Fehlig commit 52e2dabc0f8d3af09c213072ce8ba734302f585d Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:31:14 2021 +0800 OvmfPkg/PlatformBootManagerLib: use PcdAcpiS3Enable to detect S3 support To avoid the potential inconsistency between PcdAcpiS3Enable and QemuFwCfgS3Enabled(), this commit modifies PlatformBootManagerLib to detect S3 support by PcdAcpiS3Enable as modules in MdeModulePkg do. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3573 Signed-off-by: Gary Lin Reviewed-by: Gerd Hoffmann Reviewed-by: Jiewen Yao Tested-by: Jim Fehlig commit 28152333bccb778b62e6e97446b28bfa0e92ef82 Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:31:13 2021 +0800 OvmfPkg/LockBoxLib: use PcdAcpiS3Enable to detect S3 support To avoid the potential inconsistency between PcdAcpiS3Enable and QemuFwCfgS3Enabled(), this commit modifies LockBoxLib to detect S3 support by PcdAcpiS3Enable as modules in MdeModulePkg do. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3573 Signed-off-by: Gary Lin Reviewed-by: Philippe Mathieu-Daude Reviewed-by: Gerd Hoffmann Reviewed-by: Jiewen Yao Tested-by: Jim Fehlig commit cb0d24637dfdd869618b9635dfb8e3b0746393a6 Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:31:12 2021 +0800 OvmfPkg/OvmfXen: set PcdAcpiS3Enable at initialization There are several functions in OvmfPkg/Library using QemuFwCfgS3Enabled() to detect the S3 support status. However, in MdeModulePkg, PcdAcpiS3Enable is used to check S3 support. Since InitializeXenPlatform() didn't set PcdAcpiS3Enable as InitializePlatform() did, this made the inconsistency between drivers/functions. For example, S3SaveStateDxe checked PcdAcpiS3Enable and skipped S3BootScript because the default value is FALSE. On the other hand, PlatformBootManagerBeforeConsole() from OvmfPkg/Library called QemuFwCfgS3Enabled() and found it returned TRUE, so it invoked SaveS3BootScript(). However, S3SaveStateDxe skipped S3BootScript, so SaveS3BootScript() asserted due to EFI_NOT_FOUND. This issue mainly affects "HVM Direct Kernel Boot". When used, "fw_cfg" is enabled in QEMU and QemuFwCfgS3Enabled() returns true in that case. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3573 Signed-off-by: Gary Lin Reviewed-by: Anthony PERARD Reviewed-by: Gerd Hoffmann Reviewed-by: Jiewen Yao Tested-by: Jim Fehlig From xen-devel-bounces@lists.xenproject.org Fri Sep 03 04:35:24 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Sep 2021 04:35:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177783.323466 (Exim 4.92) (envelope-from ) id 1mM0v0-0001Hb-Lx; Fri, 03 Sep 2021 04:35:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177783.323466; Fri, 03 Sep 2021 04:35:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mM0v0-0001HU-I0; Fri, 03 Sep 2021 04:35:10 +0000 Received: by outflank-mailman (input) for mailman id 177783; Fri, 03 Sep 2021 04:35:09 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mM0uz-0001HG-QE; Fri, 03 Sep 2021 04:35:09 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mM0uz-0003Wx-I5; Fri, 03 Sep 2021 04:35:09 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mM0uz-0005Kq-6c; Fri, 03 Sep 2021 04:35:09 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mM0uz-00081A-67; Fri, 03 Sep 2021 04:35:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=yHD9xmRM2bbHsYrPGYq/UjbrF8F+/JToPxJjqJQ5w/I=; b=NToEGtHXH3s3WoLyFNdLBBQ1Qo yACDTq9uz2qwjJRckmi73jmvTjiqbO2Jct/ZXnZqFjnqGTNsK9uCG3G5s6TilaQk5gLYVYiO+m/nJ TKAdH1Ay0fIwWh8WfsZ/FSdkBHkYQru6M3fGtpU4KJFWXJJ618UuJAN50e7qf+4mOPHo=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 164788: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=81d71fb86e1ad676e94becb7ffffb403cefd3019 X-Osstest-Versions-That: ovmf=cae735f61328d64e2e8991036707b9e78c0f5f63 From: osstest service owner Date: Fri, 03 Sep 2021 04:35:09 +0000 flight 164788 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/164788/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 164674 build-amd64-xsm 6 xen-build fail REGR. vs. 164674 build-i386-xsm 6 xen-build fail REGR. vs. 164674 build-i386 6 xen-build fail REGR. vs. 164674 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 81d71fb86e1ad676e94becb7ffffb403cefd3019 baseline version: ovmf cae735f61328d64e2e8991036707b9e78c0f5f63 Last test of basis 164674 2021-08-31 02:56:52 Z 3 days Failing since 164686 2021-09-01 03:03:43 Z 2 days 20 attempts Testing same since 164788 2021-09-03 04:12:12 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Anthony PERARD DunTan Gary Lin Hao A Wu Jim Fehlig Lin, Gary (HPS OE-Linux) Loo Tung Lun Loo, Tung Lun Mark Wilson Marvin H?user Rebecca Cran Wenxing Hou Wenyi Xie jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit 81d71fb86e1ad676e94becb7ffffb403cefd3019 Author: Hao A Wu Date: Fri Aug 20 13:36:56 2021 +0800 Maintainers.txt: Update maintainer/reviewer roles in MdeModulePkg Remove Hao A Wu as the MdeModulePkg maintainer. Add Liming Gao as the MdeModulePkg maintainer. Remove Hao A Wu as the MdeModulePkg: Firmware Update modules reviewer. Remove Hao A Wu as the MdeModulePkg: Serial modules reviewer. Cc: Jian J Wang Cc: Liming Gao Cc: Guomin Jiang Cc: Ray Ni Cc: Zhichao Gao Signed-off-by: Hao A Wu Reviewed-by: Liming Gao Reviewed-by: Zhichao Gao commit c5e805ffe1098601e84fd501d5fa1d45e9d96a62 Author: Rebecca Cran Date: Tue Aug 31 06:36:36 2021 +0800 MdeModulePkg: Fix typo of "memory" in RamDiskDxe debug message Fix a typo of "memory" in a debug message in RamDiskProtocol.c. Signed-off-by: Rebecca Cran Reviewed-by: Hao A Wu Reviewed-by: Philippe Mathieu-Daude commit b6bc203375b6efb6822ee4fe4a59be4f1918436b Author: Wenyi Xie Date: Thu Aug 26 09:16:03 2021 +0800 MdeModulePkg/HiiDatabaseDxe:remove dead code block As the if statement outside has confirmed that BlockData->Name == NULL, so the if statement inside is always false. Cc: Jian J Wang Cc: Hao A Wu Cc: Dandan Bi Cc: Eric Dong Signed-off-by: Wenyi Xie Reviewed-by: Dandan Bi commit e3ee8c8dbd7a9f7d7905abe17be60354c9f5f9a3 Author: duntan Date: Fri Aug 20 14:43:37 2021 +0800 .azurepipelines: Add UefiPayloadPkg in gate-build-job.yml and CISetting.py Add UefiPayloadPkg in gate-build-job.yml to enable Core ci for UefiPayloadPkg. Add UefiPayloadPkg to supported Packages in CISettings. Cc: Sean Brogan Cc: Bret Barkelew Cc: Michael D Kinney Cc: Liming Gao Signed-off-by: DunTan Reviewed-by: Liming Gao commit 63fddc98e06c380e654b1cfbaf24b9fd922adfad Author: duntan Date: Fri Aug 20 14:43:36 2021 +0800 UefiPayloadPkg: Create .yaml file in UefiPayloadPkg Create .yaml file in UefiPayloadPkg to enable Core ci for UefiPayloadPkg Cc: Guo Dong Cc: Ray Ni Cc: Maurice Ma Cc: Benjamin You Signed-off-by: DunTan Reviewed-by: Liming Gao commit 12e33dca4c0612a0975265e5ba641c6261a26455 Author: Loo, Tung Lun Date: Tue Aug 17 15:43:12 2021 +0800 IntelFsp2Pkg: Support Config File and Binary delta comparison BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3567 This patch is to enable config editor to have a new feature that can spell out the delta between the default configuration files' data, such as YAML and BSF, against the data stored in the binary. This can help users understand and track the difference when modifications are made. Cc: Maurice Ma Cc: Nate DeSimone Cc: Star Zeng Cc: Chasel Chiu Signed-off-by: Loo Tung Lun Reviewed-by: Chasel Chiu commit b170806518c1e414939c8b085866544814e1ce8e Author: Mark Wilson Date: Fri Nov 13 08:05:18 2020 +0800 UefiCpuPkg: Clean up save state boundary checks and comments. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2956 In functions ReadSaveStateRegisterByIndex and WriteSaveStateRegister: * check width > 4 instead of >= 4 when writing upper 32 bytes. - This improves the code but will not affect functionality. Cc: Eric Dong Reviewed-by: Ray Ni Signed-off-by: Mark Wilson commit 3b3f88228812e2c642eea8746858a4dad928ebf7 Author: Marvin H?user Date: Mon Aug 9 14:09:25 2021 +0800 MdeModulePkg/PiSmmCore: Drop deprecated image profiling commands The legacy codebase allowed SMM images to be registered for profiling from DXE. Support for this has been dropped entirely, so remove the remaining handlers. Cc: Jian J Wang Cc: Hao A Wu Cc: Eric Dong Reviewed-by: Ray Ni Cc: Vitaly Cheptsov Signed-off-by: Marvin H?user commit cdda3f74a1327663a5d48cca13507085ba403af7 Author: Marvin H?user Date: Mon Aug 9 03:39:53 2021 +0800 UefiPayloadPkg/UefiPayloadEntry: Fix memory corruption UefiPayloadEntry's AllocatePool() applies the "sizeof" operator to HOB index rather than the HOB header structure. This yields 4 Bytes compared to the 8 Bytes the structure header requires. Fix the call to allocate the required space instead. Reviewed-by: Guo Dong Reviewed-by: Ray Ni Cc: Maurice Ma Cc: Benjamin You Cc: Vitaly Cheptsov Signed-off-by: Marvin H?user commit 5d34cc49d5d348012fe8acf9fb618826bd541a7c Author: Wenxing Hou Date: Tue Aug 24 16:11:11 2021 +0800 UefiCpuPkg/PiSmmCpuDxeSmm: Update mPatchCetSupported set condition REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3584 Function AsmCpuid should first check the value for Basic CPUID Information. The fix is to update the mPatchCetSupported judgment statement. Signed-off-by: Wenxing Hou Reviewed-by: Ray Ni Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Cc: Sheng W Cc: Yao Jiewen commit f0fe55bca4651734abf1752a1d7c69fb5bee00b9 Author: duntan Date: Fri Aug 20 13:04:29 2021 +0800 UefiPayloadPkg: Fix the build error when enable Core ci for UefiPayloadPkg V1: Add quotes when using $(ARCH) in .dsc and .fdf file. The quotes are added due to the way by which Core ci parse the .dsc file. Add UINTN in Hob.c to fix cast from pointer to integer of different size error. V2: Delete lines which reference ShellBinPkg.The pkg doesn't exist in edk2. Cc: Guo Dong Cc: Ray Ni Cc: Maurice Ma Cc: Benjamin You Signed-off-by: DunTan Reviewed-by: Ray Ni commit 9f3eda177a4b2d4a33ff1b0307cad42906396562 Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:29:48 2021 +0800 OvmfPkg/OvmfXen: add QemuKernelLoaderFsDxe Without QemuKernelLoaderFsDxe, QemuLoadKernelImage() couldn't download the kernel, initrd, and kernel command line from QEMU's fw_cfg. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3574 Signed-off-by: Gary Lin Acked-by: Anthony PERARD Reviewed-by: Philippe Mathieu-Daude Reviewed-by: Gerd Hoffmann Tested-by: Jim Fehlig commit 5b5f10d7465004e3e40ec1f50a3b490b4db595e7 Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:31:15 2021 +0800 OvmfPkg/SmmControl2Dxe: use PcdAcpiS3Enable to detect S3 support To avoid the potential inconsistency between PcdAcpiS3Enable and QemuFwCfgS3Enabled(), this commit modifies SmmControl2Dxe to detect S3 support by PcdAcpiS3Enable as modules in MdeModulePkg do. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3573 Signed-off-by: Gary Lin Reviewed-by: Gerd Hoffmann Reviewed-by: Jiewen Yao Tested-by: Jim Fehlig commit 52e2dabc0f8d3af09c213072ce8ba734302f585d Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:31:14 2021 +0800 OvmfPkg/PlatformBootManagerLib: use PcdAcpiS3Enable to detect S3 support To avoid the potential inconsistency between PcdAcpiS3Enable and QemuFwCfgS3Enabled(), this commit modifies PlatformBootManagerLib to detect S3 support by PcdAcpiS3Enable as modules in MdeModulePkg do. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3573 Signed-off-by: Gary Lin Reviewed-by: Gerd Hoffmann Reviewed-by: Jiewen Yao Tested-by: Jim Fehlig commit 28152333bccb778b62e6e97446b28bfa0e92ef82 Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:31:13 2021 +0800 OvmfPkg/LockBoxLib: use PcdAcpiS3Enable to detect S3 support To avoid the potential inconsistency between PcdAcpiS3Enable and QemuFwCfgS3Enabled(), this commit modifies LockBoxLib to detect S3 support by PcdAcpiS3Enable as modules in MdeModulePkg do. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3573 Signed-off-by: Gary Lin Reviewed-by: Philippe Mathieu-Daude Reviewed-by: Gerd Hoffmann Reviewed-by: Jiewen Yao Tested-by: Jim Fehlig commit cb0d24637dfdd869618b9635dfb8e3b0746393a6 Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:31:12 2021 +0800 OvmfPkg/OvmfXen: set PcdAcpiS3Enable at initialization There are several functions in OvmfPkg/Library using QemuFwCfgS3Enabled() to detect the S3 support status. However, in MdeModulePkg, PcdAcpiS3Enable is used to check S3 support. Since InitializeXenPlatform() didn't set PcdAcpiS3Enable as InitializePlatform() did, this made the inconsistency between drivers/functions. For example, S3SaveStateDxe checked PcdAcpiS3Enable and skipped S3BootScript because the default value is FALSE. On the other hand, PlatformBootManagerBeforeConsole() from OvmfPkg/Library called QemuFwCfgS3Enabled() and found it returned TRUE, so it invoked SaveS3BootScript(). However, S3SaveStateDxe skipped S3BootScript, so SaveS3BootScript() asserted due to EFI_NOT_FOUND. This issue mainly affects "HVM Direct Kernel Boot". When used, "fw_cfg" is enabled in QEMU and QemuFwCfgS3Enabled() returns true in that case. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3573 Signed-off-by: Gary Lin Reviewed-by: Anthony PERARD Reviewed-by: Gerd Hoffmann Reviewed-by: Jiewen Yao Tested-by: Jim Fehlig From xen-devel-bounces@lists.xenproject.org Fri Sep 03 04:52:46 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Sep 2021 04:52:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177791.323479 (Exim 4.92) (envelope-from ) id 1mM1Bv-0004gG-Df; Fri, 03 Sep 2021 04:52:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177791.323479; Fri, 03 Sep 2021 04:52:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mM1Bv-0004g9-AC; Fri, 03 Sep 2021 04:52:39 +0000 Received: by outflank-mailman (input) for mailman id 177791; Fri, 03 Sep 2021 04:52:37 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mM1Bt-0004fz-Jm; Fri, 03 Sep 2021 04:52:37 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mM1Bt-0003wb-Ey; Fri, 03 Sep 2021 04:52:37 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mM1Bt-0005oT-1f; Fri, 03 Sep 2021 04:52:37 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mM1Bt-0006Us-1B; Fri, 03 Sep 2021 04:52:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=h0SzT5xIkDw7uzw4mKAG3bLCJ4DQh7ulANlV/hoOod0=; b=f+0VnqL45Ycgj1fMJfRSpwYGsl ZW0+BPFiuPHm543bjUANn6xVedSJTf/ryaK4pIONj0XUGyfLN1W0DAi82dje/z7urzrmhICXmHUNP MT7wKmZXvppeEFy5AaNeDML3RyTWufyftqqN+vYFUloyA3yafuclMQAEZGu0egfDFDTU=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 164777: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-i386-xl-qemut-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-examine:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-i386-xl-raw:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-pvshim:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-i386:xen-install:fail:regression linux-linus:test-amd64-i386-xl-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ovmf-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-coresched-i386-xl:xen-install:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-arm64-arm64-xl-credit1:debian-fixup:fail:regression linux-linus:test-arm64-arm64-xl-thunderx:debian-fixup:fail:regression linux-linus:test-arm64-arm64-xl:debian-fixup:fail:regression linux-linus:test-arm64-arm64-xl-xsm:debian-fixup:fail:regression linux-linus:test-arm64-arm64-xl-credit2:debian-fixup:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:debian-fixup:fail:regression linux-linus:test-armhf-armhf-xl-credit2:host-ping-check-xen:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=7ba88a2a09f47e2e4f3e34215677a1d78a9e6a73 X-Osstest-Versions-That: linux=deacdb3e3979979016fcd0ffd518c320a62ad166 From: osstest service owner Date: Fri, 03 Sep 2021 04:52:37 +0000 flight 164777 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/164777/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemut-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-examine 6 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-i386-xl-raw 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-pvshim 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-i386 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ovmf-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-coresched-i386-xl 7 xen-install fail REGR. vs. 152332 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 152332 test-arm64-arm64-examine 8 reboot fail REGR. vs. 152332 test-arm64-arm64-xl-credit1 13 debian-fixup fail REGR. vs. 152332 test-arm64-arm64-xl-thunderx 13 debian-fixup fail REGR. vs. 152332 test-arm64-arm64-xl 13 debian-fixup fail REGR. vs. 152332 test-arm64-arm64-xl-xsm 13 debian-fixup fail REGR. vs. 152332 test-arm64-arm64-xl-credit2 13 debian-fixup fail REGR. vs. 152332 test-arm64-arm64-libvirt-xsm 13 debian-fixup fail REGR. vs. 152332 test-armhf-armhf-xl-credit2 10 host-ping-check-xen fail REGR. vs. 152332 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 152332 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 152332 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152332 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152332 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 152332 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152332 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152332 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux 7ba88a2a09f47e2e4f3e34215677a1d78a9e6a73 baseline version: linux deacdb3e3979979016fcd0ffd518c320a62ad166 Last test of basis 152332 2020-07-31 19:41:23 Z 398 days Failing since 152366 2020-08-01 20:49:34 Z 397 days 688 attempts Testing same since 164777 2021-09-02 21:10:06 Z 0 days 1 attempts ------------------------------------------------------------ 7153 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl fail test-armhf-armhf-xl pass test-amd64-i386-xl fail test-amd64-coresched-i386-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm fail test-amd64-i386-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm fail test-amd64-i386-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine pass test-arm64-arm64-examine fail test-armhf-armhf-examine pass test-amd64-i386-examine fail test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel fail test-amd64-i386-qemuu-rhel6hvm-intel fail test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair fail test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow fail test-arm64-arm64-xl-thunderx fail test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2186225 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Sep 03 07:32:05 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Sep 2021 07:32:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177800.323493 (Exim 4.92) (envelope-from ) id 1mM3g0-0005iY-Qy; Fri, 03 Sep 2021 07:31:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177800.323493; Fri, 03 Sep 2021 07:31:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mM3g0-0005iR-O2; Fri, 03 Sep 2021 07:31:52 +0000 Received: by outflank-mailman (input) for mailman id 177800; Fri, 03 Sep 2021 07:31:51 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mM3fz-0005iH-7y; Fri, 03 Sep 2021 07:31:51 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mM3fy-0006vz-Ve; Fri, 03 Sep 2021 07:31:51 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mM3fy-0006Ec-OU; Fri, 03 Sep 2021 07:31:50 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mM3fy-00034A-Nx; Fri, 03 Sep 2021 07:31:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=3mutafMOaoMZwDIbXcKMXrrwEPJnIP3m+SG96J+1lyY=; b=Ln/cv7jkHbT+SqYgiZaNZTJF9O 0jeP/eu8Js0Oc3qjimmmGRUrJYQw0g9LTzHb18yFOG/jPZdj63MR2jMk9d6B8tvIALCpW8c0sjBln YIoJ983Im2I40nB7e1NkpvjPGQ0lJg+NFk4qhTPuAIL3Vd7J3fw09UFr+ahLP6IUkgRM=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 164789: regressions - FAIL X-Osstest-Failures: libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=3dbaaab128fed98e015a938dada2e0824b0870b6 X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Fri, 03 Sep 2021 07:31:50 +0000 flight 164789 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/164789/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a version targeted for testing: libvirt 3dbaaab128fed98e015a938dada2e0824b0870b6 baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 420 days Failing since 151818 2020-07-11 04:18:52 Z 419 days 410 attempts Testing same since 164789 2021-09-03 04:19:06 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Andika Triwidada Andrea Bolognani Balázs Meskó Barrett Schonefeld Bastian Germann Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Bjoern Walk Boris Fiuczynski Brian Turek Bruno Haible Chris Mayo Christian Ehrhardt Christian Kirbach Christian Schoenebeck Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé Didik Supriadi Dmytro Linkin Eiichi Tsukata Eric Farman Erik Skultety Fabian Affolter Fabian Freyer Fabiano Fidêncio Fangge Jin Farhan Ali Fedora Weblate Translation gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Hela Basa Helmut Grohne Ian Wienand Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen jason lee Jean-Baptiste Holcroft Jia Zhou Jianan Gao Jim Fehlig Jin Yan Jinsheng Zhang Jiri Denemark John Ferlan Jonathan Watt Jonathon Jongsma Julio Faracco Justin Gatzen Ján Tomko Kashyap Chamarthy Kevin Locke Kristina Hanicova Laine Stump Laszlo Ersek Lee Yarwood Liao Pingfang Lin Ma Lin Ma Lin Ma Liu Yiding Luke Yue Luyao Zhong Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Markus Schade Martin Kletzander Masayoshi Mizuma Matej Cepl Matt Coleman Matt Coleman Mauro Matteo Cascella Meina Li Michal Privoznik Michał Smyk Milo Casagrande Moshe Levi Muha Aliss Nathan Neal Gompa Nick Shyrokovskiy Nickys Music Group Nico Pache Nikolay Shirokovskiy Olaf Hering Olesya Gerasimenko Orion Poplawski Pany Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Richard W.M. Jones Ricky Tigg Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Shambarger Sebastian Mitterle SeongHyun Jo Shalini Chellathurai Saroja Shaojun Yang Shi Lei simmon Simon Chopin Simon Gaiser Simon Rowe Stefan Bader Stefan Berger Stefan Berger Stefan Hajnoczi Szymon Scholz Thomas Huth Tim Wiederhake Tomáš Golembiovský Tomáš Janoušek Tuguoyi Ville Skyttä Vinayak Kale Wang Xin WangJian Weblate Wei Liu Wei Liu William Douglas Yalei Li <274268859@qq.com> Yalei Li Yang Fei Yang Hang Yanqiu Zhang Yaroslav Kargin Yi Li Yi Wang Yuri Chornoivan Zbigniew Jędrzejewski-Szmek zhangjl02 Zheng Chuan zhenwei pi Zhenyu Ye Zhenyu Zheng Zhenzhong Duan jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 71775 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Sep 03 07:41:44 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Sep 2021 07:41:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177808.323508 (Exim 4.92) (envelope-from ) id 1mM3pU-0007Qj-0A; Fri, 03 Sep 2021 07:41:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177808.323508; Fri, 03 Sep 2021 07:41:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mM3pT-0007Qc-TS; Fri, 03 Sep 2021 07:41:39 +0000 Received: by outflank-mailman (input) for mailman id 177808; Fri, 03 Sep 2021 07:41:38 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mM3pS-0007QW-E1 for xen-devel@lists.xenproject.org; Fri, 03 Sep 2021 07:41:38 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mM3pS-00075t-6C; Fri, 03 Sep 2021 07:41:38 +0000 Received: from 54-240-197-239.amazon.com ([54.240.197.239] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1mM3pR-0002on-VM; Fri, 03 Sep 2021 07:41:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=ksqcf2jF0XIRZewBEItfZVaqUXtATCiTEIw7T76+bxM=; b=0225mFHrUzVqNYOkqlRquTHDE1 Y62bkr4fGbW14yd6FQuHGaeGaNIRet0v/pY5CEX8dq9CPNLHEo4sBMfKfd5P0OyR/mvFVOjcHm47D nLNEDXwNhDKyuiwBcpoPRjGZtPE4rN7Q/UQvzoAuq//LAKqxXEhxMwqjmCLlvEj3hXUw=; Subject: Re: [PATCH v5 7/7] xen/arm: introduce allocate_static_memory To: Stefano Stabellini Cc: Penny Zheng , xen-devel@lists.xenproject.org, Bertrand.Marquis@arm.com, Wei.Chen@arm.com, nd@arm.com References: <20210824095045.2281500-1-penny.zheng@arm.com> <20210824095045.2281500-8-penny.zheng@arm.com> From: Julien Grall Message-ID: <034628a6-5461-f4a9-3339-a0d6f3d68f80@xen.org> Date: Fri, 3 Sep 2021 08:41:36 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit On 03/09/2021 01:39, Stefano Stabellini wrote: > On Thu, 2 Sep 2021, Julien Grall wrote: >>>> + kinfo->mem.nr_banks = ++gbank; >>>> + kinfo->unassigned_mem -= tot_size; >>>> + if ( kinfo->unassigned_mem ) >>>> + { >>>> + printk(XENLOG_ERR >>>> + "Size of \"memory\" property doesn't match up with the >>>> sum-up of \"xen,static-mem\".\n"); >>>> + goto fail; >>> >>> Do we need to make this a fatal failure? >>> >>> I am asking because unassigned_mem comes from the "memory" property of >>> the domain in device tree which is kind of redundant with the >>> introduction of xen,static-mem. In fact, I think it would be better to >>> clarify the role of "memory" when "xen,static-mem" is also present. >>> In that case, we could even make "memory" optional. >> >> I requested to make it mandatory. Imagine you have a domU that has 1GB and now >> you want to switch to static memory. If we make the property optional, then >> there is a risk for the admin to not correctly pass the amount of memory. This >> may become unnoticed until late. >> >> So I think making it mandatory is cheap for us and an easy way to confirm you >> properly sized the region. It also has the benefits to easily find out how >> much memory you gave to the guest (but that's just because I am lazy :)). >> >>> In any case, even if we don't make "memory" optional, it might still be >>> good to turn this error into a warning and ignore the remaining >>> kinfo->unassigned_mem. >> >> The behavior is matching the existing function and I think this is a good >> idea. If you ask 10MB of memory and we only give you 9MB, then at some point >> your guest is not going to be happy. >> >> It is much better to know it in advance with a failure over discovering hours >> later when you see an OOM from your domain. > > OK, I didn't realize this was discussed already. Let's not revisit this > then. > > My preference is primarily to make the device tree easier to write, but > nowadays nobody I know is writing the device tree by hand anymore (they > all use ImageBuilder).So if the device tree is generated then we are > fine either way as long as the binding is clear. So I am OK to drop my > suggestion of making "memory" optional. Let's think of a way to make > "memory" and "xen,static-mem" coexist instead. > > > There are two sides of the issue: > - the Xen implementation > - the binding > > > The Xen implementation is fine to panic if memory != xen,static-mem. In > that regard, the current patch is OK. > > > From the binding perspective, I think it would be good to add a > statement to clarify. The binding doesn't necessarily need to match > exactly the implementation as the binding should be as future proof > and as flexible as possible. So I agree that the binding doesn't have to match the implementation. But... the binding always have be more restrictive than the implementation. Otherwise, someone following the binding may be not able to use it with Xen. > > From the binding perspective two properties should mean different > things: memory the total memory amount and xen,static-mem the static > memory. If one day we'll have more types of memory, memory will cover > the total amount while xen,static-mem will cover a subset. So memory > must be greater or equal to xen,static-mem (even if today Xen only > supports memory == xen,static-mem). > > So I would add: > > """ > As the memory property represents the total memory of the domain, hence > the amount of memory selected by the memory property must be greater or > equal to the total amount specified by xen,static-mem. Other > configurations (memory amount less than xen,static-mem amount) are > invalid. > """ > > This sentence has the purpose of clarifying that "memory" still need to > be populated and have a valid value. Then, it is OK for Xen to error > out if memory doesn't match xen,static-mem because that's the only > configuration supported. How about writing something like "The property 'memory' should match the amount of memory given to the guest. Currently, it is only possible to either allocate static memory or let Xen chose. *Mixing* is not supported'. Then if we add the mixing, we could say 'From Xen XX.YY, mixing will be allowed'. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Sep 03 08:06:28 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Sep 2021 08:06:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177820.323519 (Exim 4.92) (envelope-from ) id 1mM4DN-0002Lb-Ga; Fri, 03 Sep 2021 08:06:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177820.323519; Fri, 03 Sep 2021 08:06:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mM4DN-0002LU-Cr; Fri, 03 Sep 2021 08:06:21 +0000 Received: by outflank-mailman (input) for mailman id 177820; Fri, 03 Sep 2021 08:06:20 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mM4DM-0002LO-7F for xen-devel@lists.xen.org; Fri, 03 Sep 2021 08:06:20 +0000 Received: from mail-pj1-x102f.google.com (unknown [2607:f8b0:4864:20::102f]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id d96f000e-9f50-4c59-b499-15ab5ce0d2d4; Fri, 03 Sep 2021 08:06:19 +0000 (UTC) Received: by mail-pj1-x102f.google.com with SMTP id j10-20020a17090a94ca00b00181f17b7ef7so3322057pjw.2 for ; Fri, 03 Sep 2021 01:06:18 -0700 (PDT) Received: from laputa (p784a44f4.tkyea130.ap.so-net.ne.jp. [120.74.68.244]) by smtp.gmail.com with ESMTPSA id r8sm5109955pgp.30.2021.09.03.01.06.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Sep 2021 01:06:17 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d96f000e-9f50-4c59-b499-15ab5ce0d2d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=VSDI1b+kKShx1vFtwYGy2PerZEjlalFPEQbbPa66J9o=; b=Gorjw3gj2HqBc5LgjLHiFLqx01XeiuFebKz7161NrET5y7DATwcbm57599urNvtfwj Ag9PWaYhiOreAYtCB90WdV1AwXwKbFMtiOXd/XNQ082HRZMqLb50cyYPG/exk9xYjPho ToB0C1NGznEQirewsZZlxFDl6icG8eGgoykh+Q2XqjjI4Jb9AEB7ZJbQ2f7Dm3TrlfDd M7R7aF/Z/kkgxdEhNbnn2K1g/wmnNVAc8K+xA9wUrCHc2UuUy2zoMjWcOEfq6SgFbRKW 6nVyjcbAsw4HDXpWErmzkNRqZlkUfW9y2kInKspLlg/WcSTsDAkpxA/ssSxnonlOH/GE aidA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=VSDI1b+kKShx1vFtwYGy2PerZEjlalFPEQbbPa66J9o=; b=lwc46S5kRapBDek1R+Mz5eJFB1uVMhTQVlvPb7mHVy2T66OMmS1AmPN5QgyiOUjiag Ulv4V1SG7OUt4s+zmTncqlLCYAee2zDsaF2qhT9ybrZgJ6UoY1fYGEypGHt8UXBYnQjB ZERO3lukUlGN50cRQGukNQgd0HMhoXZM6/Qn3VmFqW2a/5XxD0qhP8jG2zC/abb3TlNf MwWOfqPvo2Vn11wFxZh5qRKkRotffRuzAyeP/DjmoIBCUsRy8i/U4pFUy7lH2gmhZ4tD 8f0Gq9IWWIPZI5pjkUAEy8B2Vczv176AakMzmvihCKlE7QWmVCmrvlQEK3nElEHaIMXB yBTA== X-Gm-Message-State: AOAM5316mHk23jJl+F0lJOMr1hCJVo06nUH8MvMdBa47xL/PHjMHMfqf wuPe9jcGYk9EczVLTLl4TV/tJw== X-Google-Smtp-Source: ABdhPJxqaZrzFD1/AwE3AQ1yYzaaKX9bSU33Qt7iVq3Iz0X2S2enbVNdAp2/mMETg7+Q06fRunv4Bg== X-Received: by 2002:a17:90b:1085:: with SMTP id gj5mr2165236pjb.66.1630656377947; Fri, 03 Sep 2021 01:06:17 -0700 (PDT) Date: Fri, 3 Sep 2021 17:06:09 +0900 From: AKASHI Takahiro To: Alex Benn??e Cc: Stefan Hajnoczi , Stefano Stabellini , Stratos Mailing List , virtio-dev@lists.oasis-open.org, Arnd Bergmann , Viresh Kumar , Stefano Stabellini , Jan Kiszka , Carl van Schaik , pratikp@quicinc.com, Srivatsa Vaddagiri , Jean-Philippe Brucker , Mathieu Poirier , Wei.Chen@arm.com, olekstysh@gmail.com, Oleksandr_Tyshchenko@epam.com, Bertrand.Marquis@arm.com, Artem_Mygaiev@epam.com, julien@xen.org, jgross@suse.com, paul@xen.org, xen-devel@lists.xen.org, Elena Afanasova Subject: Re: Enabling hypervisor agnosticism for VirtIO backends Message-ID: <20210903080609.GD47953@laputa> References: <87v94ldrqq.fsf@linaro.org> <875yvkh1p1.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <875yvkh1p1.fsf@linaro.org> Alex, On Wed, Sep 01, 2021 at 01:53:34PM +0100, Alex Benn??e wrote: > > Stefan Hajnoczi writes: > > > [[PGP Signed Part:Undecided]] > > On Wed, Aug 04, 2021 at 12:20:01PM -0700, Stefano Stabellini wrote: > >> > Could we consider the kernel internally converting IOREQ messages from > >> > the Xen hypervisor to eventfd events? Would this scale with other kernel > >> > hypercall interfaces? > >> > > >> > So any thoughts on what directions are worth experimenting with? > >> > >> One option we should consider is for each backend to connect to Xen via > >> the IOREQ interface. We could generalize the IOREQ interface and make it > >> hypervisor agnostic. The interface is really trivial and easy to add. > >> The only Xen-specific part is the notification mechanism, which is an > >> event channel. If we replaced the event channel with something else the > >> interface would be generic. See: > >> https://gitlab.com/xen-project/xen/-/blob/staging/xen/include/public/hvm/ioreq.h#L52 > > > > There have been experiments with something kind of similar in KVM > > recently (see struct ioregionfd_cmd): > > https://lore.kernel.org/kvm/dad3d025bcf15ece11d9df0ff685e8ab0a4f2edd.1613828727.git.eafanasova@gmail.com/ > > Reading the cover letter was very useful in showing how this provides a > separate channel for signalling IO events to userspace instead of using > the normal type-2 vmexit type event. I wonder how deeply tied the > userspace facing side of this is to KVM? Could it provide a common FD > type interface to IOREQ? Why do you stick to a "FD" type interface? > As I understand IOREQ this is currently a direct communication between > userspace and the hypervisor using the existing Xen message bus. My With IOREQ server, IO event occurrences are notified to BE via Xen's event channel, while the actual contexts of IO events (see struct ioreq in ioreq.h) are put in a queue on a single shared memory page which is to be assigned beforehand with xenforeignmemory_map_resource hypervisor call. > worry would be that by adding knowledge of what the underlying > hypervisor is we'd end up with excess complexity in the kernel. For one > thing we certainly wouldn't want an API version dependency on the kernel > to understand which version of the Xen hypervisor it was running on. That's exactly what virtio-proxy in my proposal[1] does; All the hypervisor- specific details of IO event handlings are contained in virtio-proxy and virtio BE will communicate with virtio-proxy through a virtqueue (yes, virtio-proxy is seen as yet another virtio device on BE) and will get IO event-related *RPC* callbacks, either MMIO read or write, from virtio-proxy. See page 8 (protocol flow) and 10 (interfaces) in [1]. If kvm's ioregionfd can fit into this protocol, virtio-proxy for kvm will hopefully be implemented using ioregionfd. -Takahiro Akashi [1] https://op-lists.linaro.org/pipermail/stratos-dev/2021-August/000548.html > >> There is also another problem. IOREQ is probably not be the only > >> interface needed. Have a look at > >> https://marc.info/?l=xen-devel&m=162373754705233&w=2. Don't we also need > >> an interface for the backend to inject interrupts into the frontend? And > >> if the backend requires dynamic memory mappings of frontend pages, then > >> we would also need an interface to map/unmap domU pages. > >> > >> These interfaces are a lot more problematic than IOREQ: IOREQ is tiny > >> and self-contained. It is easy to add anywhere. A new interface to > >> inject interrupts or map pages is more difficult to manage because it > >> would require changes scattered across the various emulators. > > > > Something like ioreq is indeed necessary to implement arbitrary devices, > > but if you are willing to restrict yourself to VIRTIO then other > > interfaces are possible too because the VIRTIO device model is different > > from the general purpose x86 PIO/MMIO that Xen's ioreq seems to > > support. > > It's true our focus is just VirtIO which does support alternative > transport options however most implementations seem to be targeting > virtio-mmio for it's relative simplicity and understood semantics > (modulo a desire for MSI to reduce round trip latency handling > signalling). > > > > > Stefan > > > > [[End of PGP Signed Part]] > > > -- > Alex Bennée From xen-devel-bounces@lists.xenproject.org Fri Sep 03 08:15:44 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Sep 2021 08:15:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177826.323529 (Exim 4.92) (envelope-from ) id 1mM4MP-0003zC-DQ; Fri, 03 Sep 2021 08:15:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177826.323529; Fri, 03 Sep 2021 08:15:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mM4MP-0003z5-AW; Fri, 03 Sep 2021 08:15:41 +0000 Received: by outflank-mailman (input) for mailman id 177826; Fri, 03 Sep 2021 08:15:40 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mM4MO-0003yv-0t; Fri, 03 Sep 2021 08:15:40 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mM4MN-0008Ci-J4; Fri, 03 Sep 2021 08:15:39 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mM4MN-0008Js-BR; Fri, 03 Sep 2021 08:15:39 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mM4MN-0000A2-At; Fri, 03 Sep 2021 08:15:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=z3y13KmUtLWDWt2g8jHJ5FzyJm9gqD8TLgA3Q4+HrX0=; b=2c6OwDooFrzZ/r4CIbZS8wKGGs Z2sL9aWkOEcKtCSujipBpozkjhSbD6Fs5WKk5wsUnoSGj/K7L18sc5dmrsJJbh/zRmTh7Pwo8Fbs7 oMY3Be8WTRZ/QWygZMD1oI1n4gJdLeeEbvJ9WZPt8rUGw9M1/uPPQhzvmrfFO6fJ49H0=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 164790: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=81d71fb86e1ad676e94becb7ffffb403cefd3019 X-Osstest-Versions-That: ovmf=cae735f61328d64e2e8991036707b9e78c0f5f63 From: osstest service owner Date: Fri, 03 Sep 2021 08:15:39 +0000 flight 164790 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/164790/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 164674 build-amd64-xsm 6 xen-build fail REGR. vs. 164674 build-i386-xsm 6 xen-build fail REGR. vs. 164674 build-i386 6 xen-build fail REGR. vs. 164674 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 81d71fb86e1ad676e94becb7ffffb403cefd3019 baseline version: ovmf cae735f61328d64e2e8991036707b9e78c0f5f63 Last test of basis 164674 2021-08-31 02:56:52 Z 3 days Failing since 164686 2021-09-01 03:03:43 Z 2 days 21 attempts Testing same since 164788 2021-09-03 04:12:12 Z 0 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Anthony PERARD DunTan Gary Lin Hao A Wu Jim Fehlig Lin, Gary (HPS OE-Linux) Loo Tung Lun Loo, Tung Lun Mark Wilson Marvin H?user Rebecca Cran Wenxing Hou Wenyi Xie jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit 81d71fb86e1ad676e94becb7ffffb403cefd3019 Author: Hao A Wu Date: Fri Aug 20 13:36:56 2021 +0800 Maintainers.txt: Update maintainer/reviewer roles in MdeModulePkg Remove Hao A Wu as the MdeModulePkg maintainer. Add Liming Gao as the MdeModulePkg maintainer. Remove Hao A Wu as the MdeModulePkg: Firmware Update modules reviewer. Remove Hao A Wu as the MdeModulePkg: Serial modules reviewer. Cc: Jian J Wang Cc: Liming Gao Cc: Guomin Jiang Cc: Ray Ni Cc: Zhichao Gao Signed-off-by: Hao A Wu Reviewed-by: Liming Gao Reviewed-by: Zhichao Gao commit c5e805ffe1098601e84fd501d5fa1d45e9d96a62 Author: Rebecca Cran Date: Tue Aug 31 06:36:36 2021 +0800 MdeModulePkg: Fix typo of "memory" in RamDiskDxe debug message Fix a typo of "memory" in a debug message in RamDiskProtocol.c. Signed-off-by: Rebecca Cran Reviewed-by: Hao A Wu Reviewed-by: Philippe Mathieu-Daude commit b6bc203375b6efb6822ee4fe4a59be4f1918436b Author: Wenyi Xie Date: Thu Aug 26 09:16:03 2021 +0800 MdeModulePkg/HiiDatabaseDxe:remove dead code block As the if statement outside has confirmed that BlockData->Name == NULL, so the if statement inside is always false. Cc: Jian J Wang Cc: Hao A Wu Cc: Dandan Bi Cc: Eric Dong Signed-off-by: Wenyi Xie Reviewed-by: Dandan Bi commit e3ee8c8dbd7a9f7d7905abe17be60354c9f5f9a3 Author: duntan Date: Fri Aug 20 14:43:37 2021 +0800 .azurepipelines: Add UefiPayloadPkg in gate-build-job.yml and CISetting.py Add UefiPayloadPkg in gate-build-job.yml to enable Core ci for UefiPayloadPkg. Add UefiPayloadPkg to supported Packages in CISettings. Cc: Sean Brogan Cc: Bret Barkelew Cc: Michael D Kinney Cc: Liming Gao Signed-off-by: DunTan Reviewed-by: Liming Gao commit 63fddc98e06c380e654b1cfbaf24b9fd922adfad Author: duntan Date: Fri Aug 20 14:43:36 2021 +0800 UefiPayloadPkg: Create .yaml file in UefiPayloadPkg Create .yaml file in UefiPayloadPkg to enable Core ci for UefiPayloadPkg Cc: Guo Dong Cc: Ray Ni Cc: Maurice Ma Cc: Benjamin You Signed-off-by: DunTan Reviewed-by: Liming Gao commit 12e33dca4c0612a0975265e5ba641c6261a26455 Author: Loo, Tung Lun Date: Tue Aug 17 15:43:12 2021 +0800 IntelFsp2Pkg: Support Config File and Binary delta comparison BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3567 This patch is to enable config editor to have a new feature that can spell out the delta between the default configuration files' data, such as YAML and BSF, against the data stored in the binary. This can help users understand and track the difference when modifications are made. Cc: Maurice Ma Cc: Nate DeSimone Cc: Star Zeng Cc: Chasel Chiu Signed-off-by: Loo Tung Lun Reviewed-by: Chasel Chiu commit b170806518c1e414939c8b085866544814e1ce8e Author: Mark Wilson Date: Fri Nov 13 08:05:18 2020 +0800 UefiCpuPkg: Clean up save state boundary checks and comments. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2956 In functions ReadSaveStateRegisterByIndex and WriteSaveStateRegister: * check width > 4 instead of >= 4 when writing upper 32 bytes. - This improves the code but will not affect functionality. Cc: Eric Dong Reviewed-by: Ray Ni Signed-off-by: Mark Wilson commit 3b3f88228812e2c642eea8746858a4dad928ebf7 Author: Marvin H?user Date: Mon Aug 9 14:09:25 2021 +0800 MdeModulePkg/PiSmmCore: Drop deprecated image profiling commands The legacy codebase allowed SMM images to be registered for profiling from DXE. Support for this has been dropped entirely, so remove the remaining handlers. Cc: Jian J Wang Cc: Hao A Wu Cc: Eric Dong Reviewed-by: Ray Ni Cc: Vitaly Cheptsov Signed-off-by: Marvin H?user commit cdda3f74a1327663a5d48cca13507085ba403af7 Author: Marvin H?user Date: Mon Aug 9 03:39:53 2021 +0800 UefiPayloadPkg/UefiPayloadEntry: Fix memory corruption UefiPayloadEntry's AllocatePool() applies the "sizeof" operator to HOB index rather than the HOB header structure. This yields 4 Bytes compared to the 8 Bytes the structure header requires. Fix the call to allocate the required space instead. Reviewed-by: Guo Dong Reviewed-by: Ray Ni Cc: Maurice Ma Cc: Benjamin You Cc: Vitaly Cheptsov Signed-off-by: Marvin H?user commit 5d34cc49d5d348012fe8acf9fb618826bd541a7c Author: Wenxing Hou Date: Tue Aug 24 16:11:11 2021 +0800 UefiCpuPkg/PiSmmCpuDxeSmm: Update mPatchCetSupported set condition REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3584 Function AsmCpuid should first check the value for Basic CPUID Information. The fix is to update the mPatchCetSupported judgment statement. Signed-off-by: Wenxing Hou Reviewed-by: Ray Ni Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Cc: Sheng W Cc: Yao Jiewen commit f0fe55bca4651734abf1752a1d7c69fb5bee00b9 Author: duntan Date: Fri Aug 20 13:04:29 2021 +0800 UefiPayloadPkg: Fix the build error when enable Core ci for UefiPayloadPkg V1: Add quotes when using $(ARCH) in .dsc and .fdf file. The quotes are added due to the way by which Core ci parse the .dsc file. Add UINTN in Hob.c to fix cast from pointer to integer of different size error. V2: Delete lines which reference ShellBinPkg.The pkg doesn't exist in edk2. Cc: Guo Dong Cc: Ray Ni Cc: Maurice Ma Cc: Benjamin You Signed-off-by: DunTan Reviewed-by: Ray Ni commit 9f3eda177a4b2d4a33ff1b0307cad42906396562 Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:29:48 2021 +0800 OvmfPkg/OvmfXen: add QemuKernelLoaderFsDxe Without QemuKernelLoaderFsDxe, QemuLoadKernelImage() couldn't download the kernel, initrd, and kernel command line from QEMU's fw_cfg. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3574 Signed-off-by: Gary Lin Acked-by: Anthony PERARD Reviewed-by: Philippe Mathieu-Daude Reviewed-by: Gerd Hoffmann Tested-by: Jim Fehlig commit 5b5f10d7465004e3e40ec1f50a3b490b4db595e7 Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:31:15 2021 +0800 OvmfPkg/SmmControl2Dxe: use PcdAcpiS3Enable to detect S3 support To avoid the potential inconsistency between PcdAcpiS3Enable and QemuFwCfgS3Enabled(), this commit modifies SmmControl2Dxe to detect S3 support by PcdAcpiS3Enable as modules in MdeModulePkg do. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3573 Signed-off-by: Gary Lin Reviewed-by: Gerd Hoffmann Reviewed-by: Jiewen Yao Tested-by: Jim Fehlig commit 52e2dabc0f8d3af09c213072ce8ba734302f585d Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:31:14 2021 +0800 OvmfPkg/PlatformBootManagerLib: use PcdAcpiS3Enable to detect S3 support To avoid the potential inconsistency between PcdAcpiS3Enable and QemuFwCfgS3Enabled(), this commit modifies PlatformBootManagerLib to detect S3 support by PcdAcpiS3Enable as modules in MdeModulePkg do. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3573 Signed-off-by: Gary Lin Reviewed-by: Gerd Hoffmann Reviewed-by: Jiewen Yao Tested-by: Jim Fehlig commit 28152333bccb778b62e6e97446b28bfa0e92ef82 Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:31:13 2021 +0800 OvmfPkg/LockBoxLib: use PcdAcpiS3Enable to detect S3 support To avoid the potential inconsistency between PcdAcpiS3Enable and QemuFwCfgS3Enabled(), this commit modifies LockBoxLib to detect S3 support by PcdAcpiS3Enable as modules in MdeModulePkg do. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3573 Signed-off-by: Gary Lin Reviewed-by: Philippe Mathieu-Daude Reviewed-by: Gerd Hoffmann Reviewed-by: Jiewen Yao Tested-by: Jim Fehlig commit cb0d24637dfdd869618b9635dfb8e3b0746393a6 Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:31:12 2021 +0800 OvmfPkg/OvmfXen: set PcdAcpiS3Enable at initialization There are several functions in OvmfPkg/Library using QemuFwCfgS3Enabled() to detect the S3 support status. However, in MdeModulePkg, PcdAcpiS3Enable is used to check S3 support. Since InitializeXenPlatform() didn't set PcdAcpiS3Enable as InitializePlatform() did, this made the inconsistency between drivers/functions. For example, S3SaveStateDxe checked PcdAcpiS3Enable and skipped S3BootScript because the default value is FALSE. On the other hand, PlatformBootManagerBeforeConsole() from OvmfPkg/Library called QemuFwCfgS3Enabled() and found it returned TRUE, so it invoked SaveS3BootScript(). However, S3SaveStateDxe skipped S3BootScript, so SaveS3BootScript() asserted due to EFI_NOT_FOUND. This issue mainly affects "HVM Direct Kernel Boot". When used, "fw_cfg" is enabled in QEMU and QemuFwCfgS3Enabled() returns true in that case. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3573 Signed-off-by: Gary Lin Reviewed-by: Anthony PERARD Reviewed-by: Gerd Hoffmann Reviewed-by: Jiewen Yao Tested-by: Jim Fehlig From xen-devel-bounces@lists.xenproject.org Fri Sep 03 08:34:02 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Sep 2021 08:34:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177836.323555 (Exim 4.92) (envelope-from ) id 1mM4e5-00071E-GG; Fri, 03 Sep 2021 08:33:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177836.323555; Fri, 03 Sep 2021 08:33:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mM4e5-000711-Ca; Fri, 03 Sep 2021 08:33:57 +0000 Received: by outflank-mailman (input) for mailman id 177836; Fri, 03 Sep 2021 08:33:56 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mM4e4-0006kQ-CN for xen-devel@lists.xenproject.org; Fri, 03 Sep 2021 08:33:56 +0000 Received: from mail-ed1-x52d.google.com (unknown [2a00:1450:4864:20::52d]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 53a80e4d-17ef-4a2f-8cff-1eaa68946a8d; Fri, 03 Sep 2021 08:33:51 +0000 (UTC) Received: by mail-ed1-x52d.google.com with SMTP id z19so6890788edi.9 for ; Fri, 03 Sep 2021 01:33:51 -0700 (PDT) Received: from a2klaptop.epam.com (host-176-36-245-220.b024.la.net.ua. [176.36.245.220]) by smtp.gmail.com with ESMTPSA id i7sm2311932ejx.73.2021.09.03.01.33.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Sep 2021 01:33:49 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 53a80e4d-17ef-4a2f-8cff-1eaa68946a8d DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=zjlQkuHh6kZKwoZ8mUieXYtJ9esYGLvw5t0GDKDUbQk=; b=Xgp3IkxX/SfY/PfG+BOgIO+ADKUy/5Rb8UIuqEw2MjrDLDSn+HntfDhndHbMQEaScL FjmrDAnyZcW6+xVcPZwu1EP7ndImdZ0KeimUQLoaibXp19/yI5ifx9Mgd4XDHmgSsifl DEvRHIV40w0i9zsWwxea2m9bOGHPSDHt24SoDK7stOg+g1Tdc/9POfAGzlMJ9dfQ3CHs Di8p521g87IwoOeOcp2ltO9kq52QKbjG70LiiCsYOZqXZK9/EjouzbmL5WtPRAbiWcCF lxvSO0V1GfTAsxF6og3u/5lCxROSkhvfw5FJOZueqx+bwmhq+i8/2CAFs7DUgsQ90wSm 4KEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=zjlQkuHh6kZKwoZ8mUieXYtJ9esYGLvw5t0GDKDUbQk=; b=UdVccc3g9rFVrXh81QNyHCPyMbdBIJTX7yfPGXxwB1o5FwwNVs2xqTL7hK2836W9M2 35TtrgD+FzboohBUYt9XoxABD8ZjoRPHnejIO1eFgiyprFBi/mKMOvhy/EYoZWvnPEzj TmdmGEMGmoHoRTynt3ZY7X7jYsON2SrK/6UPq5u9CY39jk6e1KOvOqBu8kKOCiyXP1wX rp/IplvkD4uYtLTDmuwv8m2z9Sqy2mXSqrEplRVV3ZQ29r80+TGdVgMaRuL62IV7YQGC 70QtshEMrGWbHKpTv6hN0Ep04QyFB+AAkgY/tkAbgAiHxNB+dvjIBciiltTAWZwtDKGe k+sg== X-Gm-Message-State: AOAM530+wApQVPgt820BrvHk0yNdDbrcYVAx4xOuJjqbepovzBkHapVl nMDXIPzA7Spq0OXfBKNT+lCyNJPyikI= X-Google-Smtp-Source: ABdhPJwdIkQ8KNRmfmDrpt7oR/v1jpWaKOTo/d+eapgA54xtdvm5mj3qW6yJP5PMshdGxMxg314tWA== X-Received: by 2002:a05:6402:1cb4:: with SMTP id cz20mr2815841edb.0.1630658030445; Fri, 03 Sep 2021 01:33:50 -0700 (PDT) From: Oleksandr Andrushchenko To: xen-devel@lists.xenproject.org Cc: julien@xen.org, sstabellini@kernel.org, oleksandr_tyshchenko@epam.com, volodymyr_babchuk@epam.com, Artem_Mygaiev@epam.com, roger.pau@citrix.com, bertrand.marquis@arm.com, rahul.singh@arm.com, Oleksandr Andrushchenko Subject: [PATCH 01/11] xen/arm: Add new device type for PCI Date: Fri, 3 Sep 2021 11:33:37 +0300 Message-Id: <20210903083347.131786-2-andr2000@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210903083347.131786-1-andr2000@gmail.com> References: <20210903083347.131786-1-andr2000@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Oleksandr Andrushchenko Add new device type (DEV_PCI) to distinguish PCI devices from platform DT devices, so some drivers, like IOMMU, can handle PCI devices differently. While at it fix dev_is_dt macro. Signed-off-by: Oleksandr Andrushchenko --- xen/include/asm-arm/device.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/xen/include/asm-arm/device.h b/xen/include/asm-arm/device.h index 5ecd5e7bd15e..7bf040560363 100644 --- a/xen/include/asm-arm/device.h +++ b/xen/include/asm-arm/device.h @@ -4,6 +4,7 @@ enum device_type { DEV_DT, + DEV_PCI, }; struct dev_archdata { @@ -25,9 +26,8 @@ typedef struct device device_t; #include -/* TODO: Correctly implement dev_is_pci when PCI is supported on ARM */ -#define dev_is_pci(dev) ((void)(dev), 0) -#define dev_is_dt(dev) ((dev->type == DEV_DT) +#define dev_is_pci(dev) ((dev)->type == DEV_PCI) +#define dev_is_dt(dev) ((dev)->type == DEV_DT) enum device_class { -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Sep 03 08:34:02 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Sep 2021 08:34:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177835.323544 (Exim 4.92) (envelope-from ) id 1mM4e1-0006kd-6M; Fri, 03 Sep 2021 08:33:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177835.323544; Fri, 03 Sep 2021 08:33:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mM4e1-0006kW-3I; Fri, 03 Sep 2021 08:33:53 +0000 Received: by outflank-mailman (input) for mailman id 177835; Fri, 03 Sep 2021 08:33:51 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mM4dz-0006kQ-Jc for xen-devel@lists.xenproject.org; Fri, 03 Sep 2021 08:33:51 +0000 Received: from mail-ed1-x529.google.com (unknown [2a00:1450:4864:20::529]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 3764bfc1-031b-4d72-96d0-123a32cca3d1; Fri, 03 Sep 2021 08:33:50 +0000 (UTC) Received: by mail-ed1-x529.google.com with SMTP id j13so6893466edv.13 for ; Fri, 03 Sep 2021 01:33:50 -0700 (PDT) Received: from a2klaptop.epam.com (host-176-36-245-220.b024.la.net.ua. [176.36.245.220]) by smtp.gmail.com with ESMTPSA id i7sm2311932ejx.73.2021.09.03.01.33.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Sep 2021 01:33:48 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3764bfc1-031b-4d72-96d0-123a32cca3d1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=XT9IurSUZ2x5a+pdMA7R9m7eqgBNcFs0ABtEwva/rOk=; b=KH3T7H6XUTIO6kln10N/XlkP8zdINoBf8lwUi0XQJKd3eTct3CAeswZD1DLkoz411o HUui7uH/2IXPivd79xANiGs9dP1FXSRRH6o6HsQ+TGuJ1+wD/UP64P73vzqEovMOD2C2 hyvQaXvyOA9fPsQOtEk69TV4XFur7vWkxPP50YZjReOl7udubtCsEtEx5rmon0ofhDVW qM3QQkgy3BS2RXc5yRPfi/5bUfBCI5mi0RMyXAfKaQ1lmxWDoUVkoIEbOeB5MZb6IxNi 0idRKSrO3nWli6QKp4FxTiIg5+vmqcyzi6Ly8ksc5KOFpTlKK5o05svXNQpHVDStaCUE ynKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=XT9IurSUZ2x5a+pdMA7R9m7eqgBNcFs0ABtEwva/rOk=; b=WtVYx+mcZyc2lCj5KSAt8RZ1LucXX/DjXvq0K7MUtWrg6Iuzj5nDH2C464hBnitVWz FVWkcpZakU6dH7mMJsbHpGEVj7LCGEFU6Jq+CjqWbN5BUvUlTJ18Z1qTRi9jZ0W22unM 0KOgLcPD7Noenn8UwDMrj5aoSeAwWA3QgV7VJRHOQSrwtTVXVu4pB8OH08z1ivmCuKVk EpsGg66GmHORg0aP15GWU/dlaD09PwjypjV7XcS5ZQJnHzuNyAUuQSMLMIRm3Z7REkfk I5eFTKi2jMrBpPmmlhhHcoOkjSYA1EZeKt6vXd6KL2+f2r/olJpX+AoYcrOFdMZpeHfD DWOw== X-Gm-Message-State: AOAM531ISQXsqbWGA4UlIZgZ99+cld125r0qpy2Pc/A8GlqPjLvKC5ta A/49a+E+VMOrwYaF1dxtz0CdNVTJdGE= X-Google-Smtp-Source: ABdhPJwOTG2NN7AeYtisr6AO0pYLJ2YbABVf7/DstvKMpb2rCJEQH5vNugO7k5U5hKNMG3xdF37o5w== X-Received: by 2002:a05:6402:84e:: with SMTP id b14mr2731110edz.260.1630658029127; Fri, 03 Sep 2021 01:33:49 -0700 (PDT) From: Oleksandr Andrushchenko To: xen-devel@lists.xenproject.org Cc: julien@xen.org, sstabellini@kernel.org, oleksandr_tyshchenko@epam.com, volodymyr_babchuk@epam.com, Artem_Mygaiev@epam.com, roger.pau@citrix.com, bertrand.marquis@arm.com, rahul.singh@arm.com, Oleksandr Andrushchenko Subject: [PATCH 00/11] PCI devices passthrough on Arm, part 2 Date: Fri, 3 Sep 2021 11:33:36 +0300 Message-Id: <20210903083347.131786-1-andr2000@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Oleksandr Andrushchenko Hi, all! This is an assorted series of patches which aim is to make some further basis for PCI passthrough on Arm support. The series continues the work published earlier by Arm [1] and adds new helpers and clears the way for vPCI changes which will follow. Thank you, Oleksandr [1] https://patchwork.kernel.org/project/xen-devel/cover/cover.1629366665.git.rahul.singh@arm.com/ Oleksandr Andrushchenko (10): xen/arm: Add new device type for PCI xen/arm: Add dev_to_pci helper xen/arm: Introduce pci_find_host_bridge_node helper xen/device-tree: Make dt_find_node_by_phandle global xen/arm: Mark device as PCI while creating one libxl: Allow removing PCI devices for all types of domains libxl: Only map legacy PCI IRQs if they are supported xen/arm: Setup MMIO range trap handlers for hardware domain xen/arm: Do not map PCI ECAM space to Domain-0's p2m xen/arm: Process pending vPCI map/unmap operations Oleksandr Tyshchenko (1): xen/domain: Call pci_release_devices() when releasing domain resources tools/libs/light/Makefile | 4 +++ tools/libs/light/libxl_pci.c | 15 ++++++-- xen/arch/arm/domain.c | 9 ++++- xen/arch/arm/domain_build.c | 3 ++ xen/arch/arm/pci/ecam.c | 28 +++++++++++++++ xen/arch/arm/pci/pci-host-common.c | 55 ++++++++++++++++++++++++++++++ xen/arch/arm/pci/pci.c | 10 ++++++ xen/arch/arm/traps.c | 6 ++++ xen/arch/arm/vpci.c | 13 +++++++ xen/common/device_tree.c | 2 +- xen/drivers/passthrough/pci.c | 3 ++ xen/include/asm-arm/device.h | 6 ++-- xen/include/asm-arm/pci.h | 30 +++++++++++++++- xen/include/xen/device_tree.h | 2 ++ 14 files changed, 178 insertions(+), 8 deletions(-) -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Sep 03 08:34:02 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Sep 2021 08:34:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177837.323566 (Exim 4.92) (envelope-from ) id 1mM4eA-0007LT-Nx; Fri, 03 Sep 2021 08:34:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177837.323566; Fri, 03 Sep 2021 08:34:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mM4eA-0007LH-KJ; Fri, 03 Sep 2021 08:34:02 +0000 Received: by outflank-mailman (input) for mailman id 177837; Fri, 03 Sep 2021 08:34:01 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mM4e9-0006kQ-Ce for xen-devel@lists.xenproject.org; Fri, 03 Sep 2021 08:34:01 +0000 Received: from mail-ej1-x629.google.com (unknown [2a00:1450:4864:20::629]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 24e6dbd2-53dd-4a2f-b109-cd7d7a4e1bc1; Fri, 03 Sep 2021 08:33:52 +0000 (UTC) Received: by mail-ej1-x629.google.com with SMTP id mf2so10484692ejb.9 for ; Fri, 03 Sep 2021 01:33:52 -0700 (PDT) Received: from a2klaptop.epam.com (host-176-36-245-220.b024.la.net.ua. [176.36.245.220]) by smtp.gmail.com with ESMTPSA id i7sm2311932ejx.73.2021.09.03.01.33.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Sep 2021 01:33:51 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 24e6dbd2-53dd-4a2f-b109-cd7d7a4e1bc1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=e6QStZ2WIeXjyjg6BwJ+X2ETh+SFauYaLcc7bbXleUI=; b=nWqFogticuAbAM8eSH4t1N6ThkVzCw+SXxxF9K1ll2yiZMh1ba0KqHkEcuIICyZxA+ SzrMGymV0AEdKm8ZZ/3WuQ6zOTDzu3Qxl2rYf1kjguYpIH6KYlhCyq4IRG8TfcKBRTEa iMEDEVpEa1K4k9kdeisup0kiYmqigISQlt8BUksAZ9OhIz75hqYC7L9u4YBATeJvnifO b13khRAluSa+dJjLlvArcmT+T3oNHIcHa6lln6cGdZNaR3DGxhgy9yz1WLBpn0CaTKgf JKlqdN0FSVOjxPDLSx+rh4zcWbdqnO+Fq6F81ZteVy6jV9HuhiWHdOcfUqqsdjHTdnlT suoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=e6QStZ2WIeXjyjg6BwJ+X2ETh+SFauYaLcc7bbXleUI=; b=DqfUBp3HYqyVJuvEWaAbOqwC+iP0kKM/BtDXEVHjL6xQ2EfXLT3VuN0ZFMiZ+SAzPs Moa683XQnMe0Xi8Erj6k69B5Pu6kd3hQVL0vD9jcAB4EQ6oK4YdrGWTsJ+3UUyVIazwE Xqgl56ITOKzRi0jItqS/W/TYqs7KWadXopTG5Dx0nrJVFWiEAxQMH3xKU8fsg805fRNV O9mUCJ2o4vAYxzTxCWuaRdUDiD93AVNdlAnPKG/SEzv5GO18QwEGM17T2hR8/G9SVUpp H1/an6zN52wDlP+iAFUudlGDxdULP1maooWYPv/L0au+vpqZJO/8+VJVl/XPVVvzOMZT C1dQ== X-Gm-Message-State: AOAM532EVpJhMEJNMXKgNeiEuN+lD15r3Kf80L4/AiQdmRGklpph2xqw J6gNBPYL4kU14A7sBvyYlg0FOW8cayg= X-Google-Smtp-Source: ABdhPJyTGMDmf4scjKeBebTeFdkThiwTB1tUX8NLSvZRs7ZtFuZfBJOLUJ5uJ8kRB25bkqYfTjUf0g== X-Received: by 2002:a17:907:2721:: with SMTP id d1mr2923277ejl.24.1630658031656; Fri, 03 Sep 2021 01:33:51 -0700 (PDT) From: Oleksandr Andrushchenko To: xen-devel@lists.xenproject.org Cc: julien@xen.org, sstabellini@kernel.org, oleksandr_tyshchenko@epam.com, volodymyr_babchuk@epam.com, Artem_Mygaiev@epam.com, roger.pau@citrix.com, bertrand.marquis@arm.com, rahul.singh@arm.com, Oleksandr Andrushchenko Subject: [PATCH 02/11] xen/arm: Add dev_to_pci helper Date: Fri, 3 Sep 2021 11:33:38 +0300 Message-Id: <20210903083347.131786-3-andr2000@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210903083347.131786-1-andr2000@gmail.com> References: <20210903083347.131786-1-andr2000@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Oleksandr Andrushchenko Add a helper which is when given a struct device returns the corresponding struct pci_dev which this device is a part of. Because of the header cross-dependencies, e.g. we need both struct pci_dev and struct arch_pci_dev at the same time, this cannot be done with an inline. Macro can be implemented, but looks scary: #define dev_to_pci_dev(dev) container_of((container_of((dev), \ struct arch_pci_dev, dev), struct pci_dev, arch) Signed-off-by: Oleksandr Andrushchenko --- xen/arch/arm/pci/pci.c | 10 ++++++++++ xen/include/asm-arm/pci.h | 7 +++++++ 2 files changed, 17 insertions(+) diff --git a/xen/arch/arm/pci/pci.c b/xen/arch/arm/pci/pci.c index dc63bbc2a2c1..6573f179af55 100644 --- a/xen/arch/arm/pci/pci.c +++ b/xen/arch/arm/pci/pci.c @@ -26,6 +26,16 @@ int arch_pci_clean_pirqs(struct domain *d) return 0; } +struct pci_dev *dev_to_pci(struct device *dev) +{ + struct arch_pci_dev *arch_dev; + + ASSERT(dev->type == DEV_PCI); + + arch_dev = container_of((dev), struct arch_pci_dev, dev); + return container_of(arch_dev, struct pci_dev, arch); +} + static int __init dt_pci_init(void) { struct dt_device_node *np; diff --git a/xen/include/asm-arm/pci.h b/xen/include/asm-arm/pci.h index 2d4610a23a25..e1aa05190bda 100644 --- a/xen/include/asm-arm/pci.h +++ b/xen/include/asm-arm/pci.h @@ -27,6 +27,13 @@ struct arch_pci_dev { struct device dev; }; +/* + * Because of the header cross-dependencies, e.g. we need both + * struct pci_dev and struct arch_pci_dev at the same time, this cannot be + * done with an inline here. Macro can be implemented, but looks scary. + */ +struct pci_dev *dev_to_pci(struct device *dev); + /* Arch-specific MSI data for vPCI. */ struct vpci_arch_msi { }; -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Sep 03 08:34:08 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Sep 2021 08:34:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177838.323577 (Exim 4.92) (envelope-from ) id 1mM4eG-0007k4-23; Fri, 03 Sep 2021 08:34:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177838.323577; Fri, 03 Sep 2021 08:34:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mM4eF-0007jr-UN; Fri, 03 Sep 2021 08:34:07 +0000 Received: by outflank-mailman (input) for mailman id 177838; Fri, 03 Sep 2021 08:34:06 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mM4eE-0006kQ-Cm for xen-devel@lists.xenproject.org; Fri, 03 Sep 2021 08:34:06 +0000 Received: from mail-ed1-x529.google.com (unknown [2a00:1450:4864:20::529]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id d791cd72-1871-4ccf-817a-e51d3db5b6c3; Fri, 03 Sep 2021 08:33:53 +0000 (UTC) Received: by mail-ed1-x529.google.com with SMTP id r7so6926076edd.6 for ; Fri, 03 Sep 2021 01:33:53 -0700 (PDT) Received: from a2klaptop.epam.com (host-176-36-245-220.b024.la.net.ua. [176.36.245.220]) by smtp.gmail.com with ESMTPSA id i7sm2311932ejx.73.2021.09.03.01.33.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Sep 2021 01:33:52 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d791cd72-1871-4ccf-817a-e51d3db5b6c3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=LGWgNsGMc39sVj5QGdwU3RC9MH61fd0rOAc+HjnetL4=; b=jzF3nEIJXkuxIUCpc0qM5Oiu8hLlldWQ+Lz0hhNI2Ub1RMF3Qbrij1SFl/emQEQscX OctS5kVKgfSmIlkAEokYDlh7KTdaWXM0wDAYf9/2NdD6neoTsa3t2DKhbRd5ZdUKiPOx S2PsK64LPXN+uZeNXjPPxgQjMJjKSFc6YGWqsQVbMF6xtxnZDnoHezWhH2nT/vwym0Yv 0CNidcd1Mx+4PJKuDXmrq2uXK50XYtdBR/DUdsISNvXiS0MjoUtZx7LKVdsMWZlTQkxu ruWxAhOgTOoVzm1FC+ANk+ZBh3e633gonZWlfdEMs3pAoxm7xgjBcF1AwkgxVuzftbjM lmoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=LGWgNsGMc39sVj5QGdwU3RC9MH61fd0rOAc+HjnetL4=; b=gFEF3vI+84Y3nriEaeUXr/5nOWigp71+vuqb1g44w9QEEMom02M9m8dU9IVlOyNYhN AWRc1uk4LSOfu3GqcZwGnvreAVYrqjp7b1N6Kacs5p3hkVCgNPPtb6JF6d2hk1k9d5iw lYZfj4mx7X4+yEMowDQzY2EeXQYF5XQpuZ66Yw5Gv/9GRf864HTgAOEUbtk+t1AyY//c bvvWAiye7e1aNAQigt4y0UVP/CL/QACcniAUFHLhHZhHtgxDXBdvSATthqFlqO8V8lfy Cn0XzcsvgWI1LYYyBGMmCZqTeSU4/+ZaMw94Az14P/p+jCCc8in/H00i4t0K+jI/TxjW 0JDA== X-Gm-Message-State: AOAM533T29VmwjjdpxeGBjsIw1GF/1YGfe5TF4KSgBNOw6Q+nUGLh3O7 OLuWyYoVesOzLVpY14INbxAW2qVrYXQ= X-Google-Smtp-Source: ABdhPJzoCD96lMsn4O6MjQ9c1RPiG7IXqQPjSOWYZAYm2R5Ns/eebk9CaPXrFjkNmkqhirqr1Rp1sg== X-Received: by 2002:a05:6402:4d:: with SMTP id f13mr2792315edu.275.1630658032768; Fri, 03 Sep 2021 01:33:52 -0700 (PDT) From: Oleksandr Andrushchenko To: xen-devel@lists.xenproject.org Cc: julien@xen.org, sstabellini@kernel.org, oleksandr_tyshchenko@epam.com, volodymyr_babchuk@epam.com, Artem_Mygaiev@epam.com, roger.pau@citrix.com, bertrand.marquis@arm.com, rahul.singh@arm.com, Oleksandr Andrushchenko Subject: [PATCH 03/11] xen/arm: Introduce pci_find_host_bridge_node helper Date: Fri, 3 Sep 2021 11:33:39 +0300 Message-Id: <20210903083347.131786-4-andr2000@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210903083347.131786-1-andr2000@gmail.com> References: <20210903083347.131786-1-andr2000@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Oleksandr Andrushchenko Get host bridge node given a PCI device attached to it. This helper will be re-used for adding PCI devices by the subsequent patches. Signed-off-by: Oleksandr Andrushchenko Signed-off-by: Oleksandr Tyshchenko --- xen/arch/arm/pci/pci-host-common.c | 17 +++++++++++++++++ xen/include/asm-arm/pci.h | 1 + 2 files changed, 18 insertions(+) diff --git a/xen/arch/arm/pci/pci-host-common.c b/xen/arch/arm/pci/pci-host-common.c index 5e34252deb9d..d2fef5476b8e 100644 --- a/xen/arch/arm/pci/pci-host-common.c +++ b/xen/arch/arm/pci/pci-host-common.c @@ -301,6 +301,23 @@ int pci_get_host_bridge_segment(const struct dt_device_node *node, return -EINVAL; } +/* + * Get host bridge node given a device attached to it. + */ +struct dt_device_node *pci_find_host_bridge_node(struct device *dev) +{ + struct pci_host_bridge *bridge; + struct pci_dev *pdev = dev_to_pci(dev); + + bridge = pci_find_host_bridge(pdev->seg, pdev->bus); + if ( unlikely(!bridge) ) + { + printk(XENLOG_ERR "Unable to find PCI bridge for "PRI_pci"\n", + pdev->seg, pdev->bus, pdev->sbdf.dev, pdev->sbdf.fn); + return NULL; + } + return bridge->dt_node; +} /* * Local variables: * mode: C diff --git a/xen/include/asm-arm/pci.h b/xen/include/asm-arm/pci.h index e1aa05190bda..7dc4c8dc9026 100644 --- a/xen/include/asm-arm/pci.h +++ b/xen/include/asm-arm/pci.h @@ -105,6 +105,7 @@ void __iomem *pci_ecam_map_bus(struct pci_host_bridge *bridge, struct pci_host_bridge *pci_find_host_bridge(uint16_t segment, uint8_t bus); int pci_get_host_bridge_segment(const struct dt_device_node *node, uint16_t *segment); +struct dt_device_node *pci_find_host_bridge_node(struct device *dev); #else /*!CONFIG_HAS_PCI*/ -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Sep 03 08:34:13 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Sep 2021 08:34:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177840.323588 (Exim 4.92) (envelope-from ) id 1mM4eL-0008Ff-CR; Fri, 03 Sep 2021 08:34:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177840.323588; Fri, 03 Sep 2021 08:34:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mM4eL-0008FR-82; Fri, 03 Sep 2021 08:34:13 +0000 Received: by outflank-mailman (input) for mailman id 177840; Fri, 03 Sep 2021 08:34:11 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mM4eJ-0006kQ-Cz for xen-devel@lists.xenproject.org; Fri, 03 Sep 2021 08:34:11 +0000 Received: from mail-ed1-x531.google.com (unknown [2a00:1450:4864:20::531]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id abac851f-78b0-46af-ba55-f6067286fe72; Fri, 03 Sep 2021 08:33:55 +0000 (UTC) Received: by mail-ed1-x531.google.com with SMTP id g22so6893686edy.12 for ; Fri, 03 Sep 2021 01:33:55 -0700 (PDT) Received: from a2klaptop.epam.com (host-176-36-245-220.b024.la.net.ua. [176.36.245.220]) by smtp.gmail.com with ESMTPSA id i7sm2311932ejx.73.2021.09.03.01.33.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Sep 2021 01:33:53 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: abac851f-78b0-46af-ba55-f6067286fe72 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=gT/ZFZNUCDilPZAOY4tWpXuhNvzOpcakatBoOBy/O1k=; b=AeeHVvoDQgATpWSZNB/AO4OIyw4Mg9oLVflwbPYmCY/dNrU1qFSQB6Db3RqYWroQIm 7dL4DAlFEW2GS7PnIsgS7gE9t4WMgwHb0M5oO5gEtI/deFPJO4ufJeIIE6jGpdTIuNXv HO3CaROk5N0KkNEEdY7x1NBl3FxGPdgHarce5VLXc0j0PuLaobvKmi3gSljvQcSX+aPc //aaqhRjf3R96XiFwTYuAJ4GXlwIF3VVYkQFUG2Fu1uqXBJPRpNuEPYYXKO2Xf6aeIxP zG8rAY1KwYJ2z5GY75QLpNcSi/kpSMO3mJAHsjUmpyFmB7ff8JMJd20fYfkj258kxD4V PMSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=gT/ZFZNUCDilPZAOY4tWpXuhNvzOpcakatBoOBy/O1k=; b=AKT9Qirdlz2Tnu9mJr/AmWdARIaR25QIApx9cutv45Bb8poD82/RxZ+GlwzIWWK/jN vwH8m6sZI1dOy9tWslgbkcPUfjFkdXf/028gzwqLHU3N8EvrlBeGusD9iRJC4YyaDzYr ibmj6MAF23RwNDdatmZ5QKlYkPnTikZS5jTe3lxS1NFhPLwiT0spVHuhLSbMydSznAA3 y2Nupp/ycyftCrSsBpYimh3hRpN4QPUrfwGmETZo7ldY324LnAeYB6VQbPxDzaORkEfK O+PecLffVpdYBV8Uj+cgaYzP7EtrQZ7KnHLZtm6Y/y1cev/RIbr5pYbGhoDiAy5nKaHK cEsQ== X-Gm-Message-State: AOAM531b95LbkD8D/U3k/TYzb2/vrmJ7a8/LrjtzlF8XrJDv464yiVDU fWc4zqUnUhEkVvt/LHw8+E62ttNAkn4= X-Google-Smtp-Source: ABdhPJwY8ZltlgwVhwjnryt/5IUzAOzh/IBbZ1FvlM/J72PFOBmQxVLdVpjv5yPJL3sHkLXKtBoe/g== X-Received: by 2002:a05:6402:b9c:: with SMTP id cf28mr2924531edb.356.1630658034045; Fri, 03 Sep 2021 01:33:54 -0700 (PDT) From: Oleksandr Andrushchenko To: xen-devel@lists.xenproject.org Cc: julien@xen.org, sstabellini@kernel.org, oleksandr_tyshchenko@epam.com, volodymyr_babchuk@epam.com, Artem_Mygaiev@epam.com, roger.pau@citrix.com, bertrand.marquis@arm.com, rahul.singh@arm.com, Oleksandr Andrushchenko Subject: [PATCH 04/11] xen/device-tree: Make dt_find_node_by_phandle global Date: Fri, 3 Sep 2021 11:33:40 +0300 Message-Id: <20210903083347.131786-5-andr2000@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210903083347.131786-1-andr2000@gmail.com> References: <20210903083347.131786-1-andr2000@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Oleksandr Andrushchenko Make dt_find_node_by_phandle globally visible, so it can be re-used by other frameworks. Signed-off-by: Oleksandr Andrushchenko --- xen/common/device_tree.c | 2 +- xen/include/xen/device_tree.h | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/xen/common/device_tree.c b/xen/common/device_tree.c index 03d25a81cea8..c2e33b99832f 100644 --- a/xen/common/device_tree.c +++ b/xen/common/device_tree.c @@ -986,7 +986,7 @@ int dt_for_each_range(const struct dt_device_node *dev, * * Returns a node pointer. */ -static struct dt_device_node *dt_find_node_by_phandle(dt_phandle handle) +struct dt_device_node *dt_find_node_by_phandle(dt_phandle handle) { struct dt_device_node *np; diff --git a/xen/include/xen/device_tree.h b/xen/include/xen/device_tree.h index b02696be9416..07393da1df90 100644 --- a/xen/include/xen/device_tree.h +++ b/xen/include/xen/device_tree.h @@ -776,6 +776,8 @@ int dt_count_phandle_with_args(const struct dt_device_node *np, const char *list_name, const char *cells_name); +struct dt_device_node *dt_find_node_by_phandle(dt_phandle handle); + #ifdef CONFIG_DEVICE_TREE_DEBUG #define dt_dprintk(fmt, args...) \ printk(XENLOG_DEBUG fmt, ## args) -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Sep 03 08:34:18 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Sep 2021 08:34:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177845.323599 (Exim 4.92) (envelope-from ) id 1mM4eP-0000Nh-Rt; Fri, 03 Sep 2021 08:34:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177845.323599; Fri, 03 Sep 2021 08:34:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mM4eP-0000MS-Lw; Fri, 03 Sep 2021 08:34:17 +0000 Received: by outflank-mailman (input) for mailman id 177845; Fri, 03 Sep 2021 08:34:16 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mM4eO-0006kQ-DJ for xen-devel@lists.xenproject.org; Fri, 03 Sep 2021 08:34:16 +0000 Received: from mail-ej1-x62f.google.com (unknown [2a00:1450:4864:20::62f]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 27e92245-e9a7-4d08-b7db-06c719470729; Fri, 03 Sep 2021 08:33:56 +0000 (UTC) Received: by mail-ej1-x62f.google.com with SMTP id x11so10579940ejv.0 for ; Fri, 03 Sep 2021 01:33:56 -0700 (PDT) Received: from a2klaptop.epam.com (host-176-36-245-220.b024.la.net.ua. [176.36.245.220]) by smtp.gmail.com with ESMTPSA id i7sm2311932ejx.73.2021.09.03.01.33.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Sep 2021 01:33:54 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 27e92245-e9a7-4d08-b7db-06c719470729 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=zEaEEkjSVbLwgqZ2cO/SvSyYHTCsAuDtk1o9tcPz34M=; b=HOEWMOzgAHfhqGy9RD08ptIgiNJDtfBpZENO+7wmukitpCXKU/tg2fBV+y4B5GPbeZ nc617mYgWSgBkpaW4vuo16HZ9MEpN6RQrgWJ6q05CQtakHUM9tZgI3oY9+bCavK6RfvD /Z5kGtwMD+pBzSNmg8rVMzrHjsh3Ac/qSBRoejs561XlEe8rtWJROHH3P8toAYjpOg0u GC5NtpzMwvW+z9I37LMc3EWyZY+bAC5A7dznB6kxyhp8224v3H81NjGIfPkG4Ng//ZK9 jmNQ+aYz/U+d5xKG/+qYldB4flk+vPZS3BIDdQ7TKOzfrfzmsoFflWkGBScLO5yZ2+dc LL0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=zEaEEkjSVbLwgqZ2cO/SvSyYHTCsAuDtk1o9tcPz34M=; b=DdGy+TRLNw447nRDWa8eJGApCfFbQfReNvgW8pH60UiCN/SorZTs60lprwxoqtb4hs rmgP1lGzTtV2swotSG1xTKz9qnrfWW/fDrQ9sj8KSea4C84Jqfm5NdtYq2JGrGbCm8fL fG805Mgc3AUF1E2QTo88vuwvadMZXvX2IQKpZkNYtYobbkYGN90hEL34gJrjxGHgrgAz I8WIIqLWAI2Ii3/BaOZnzSouaSc0YRFQQ3zD9UJF2xMRcDMuooDYCvQG+UFgNI6JwzTW mmApM5Ap2CcM5SZ6RbiO1a/5WKpxT5VRU1rk5mULWN0vjkr3MUQJJt48ANSvqLRzrocA u8eQ== X-Gm-Message-State: AOAM530l5Uu+nBzJSIgtyQkQA41cdnN7ZvTYnI2/5urjS4An/BSc8jhD QrgONB206CkZ7AO4HjjL4+SqUNh3dO8= X-Google-Smtp-Source: ABdhPJwRW77fMud+VU+y2+UHwAx3A+siV93Yru3KtspqID6C5FmqhT1A5wFmO04G72SDTjkT5t52Uw== X-Received: by 2002:a17:906:ff41:: with SMTP id zo1mr2759320ejb.525.1630658035099; Fri, 03 Sep 2021 01:33:55 -0700 (PDT) From: Oleksandr Andrushchenko To: xen-devel@lists.xenproject.org Cc: julien@xen.org, sstabellini@kernel.org, oleksandr_tyshchenko@epam.com, volodymyr_babchuk@epam.com, Artem_Mygaiev@epam.com, roger.pau@citrix.com, bertrand.marquis@arm.com, rahul.singh@arm.com, Oleksandr Andrushchenko Subject: [PATCH 05/11] xen/arm: Mark device as PCI while creating one Date: Fri, 3 Sep 2021 11:33:41 +0300 Message-Id: <20210903083347.131786-6-andr2000@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210903083347.131786-1-andr2000@gmail.com> References: <20210903083347.131786-1-andr2000@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Oleksandr Andrushchenko While adding a PCI device mark it as such, so other frameworks can distinguish it form DT devices. Signed-off-by: Oleksandr Andrushchenko --- xen/drivers/passthrough/pci.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.c index 56e261e9bd08..25304dbe9956 100644 --- a/xen/drivers/passthrough/pci.c +++ b/xen/drivers/passthrough/pci.c @@ -1301,6 +1301,9 @@ static int iommu_add_device(struct pci_dev *pdev) if ( !is_iommu_enabled(pdev->domain) ) return 0; +#ifdef CONFIG_ARM + pci_to_dev(pdev)->type = DEV_PCI; +#endif rc = hd->platform_ops->add_device(pdev->devfn, pci_to_dev(pdev)); if ( rc || !pdev->phantom_stride ) return rc; -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Sep 03 08:34:23 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Sep 2021 08:34:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177848.323610 (Exim 4.92) (envelope-from ) id 1mM4eV-0000uw-AO; Fri, 03 Sep 2021 08:34:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177848.323610; Fri, 03 Sep 2021 08:34:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mM4eV-0000ue-67; Fri, 03 Sep 2021 08:34:23 +0000 Received: by outflank-mailman (input) for mailman id 177848; Fri, 03 Sep 2021 08:34:21 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mM4eT-0006kQ-DN for xen-devel@lists.xenproject.org; Fri, 03 Sep 2021 08:34:21 +0000 Received: from mail-ed1-x52e.google.com (unknown [2a00:1450:4864:20::52e]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id fdf50016-d48a-46db-8d04-c3242be972e1; Fri, 03 Sep 2021 08:33:57 +0000 (UTC) Received: by mail-ed1-x52e.google.com with SMTP id n11so6903634edv.11 for ; Fri, 03 Sep 2021 01:33:57 -0700 (PDT) Received: from a2klaptop.epam.com (host-176-36-245-220.b024.la.net.ua. [176.36.245.220]) by smtp.gmail.com with ESMTPSA id i7sm2311932ejx.73.2021.09.03.01.33.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Sep 2021 01:33:55 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fdf50016-d48a-46db-8d04-c3242be972e1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=/iiGZOLolgjA2ZPldrvDxiQ5Z5+rXkMHlrxZBGQ1V6g=; b=Thp1SViWRIliiAx3L7i8dGQs8jHSK15JDP1ZAcNVhPgnWdIyDDHzN7LnytjXMbIJGT 2aj1NBBC9Fu1xWxM0uHHq4g2BnsU8a/mnvbjF5ljWBOSqkyfveqsDXi0U8D5UwEzaL+c CEj7XN/MJOAGR2zNbfqHuzkpEq2avwghGsdsSVSbRe7N2V4EIwDJsbOWGfI6CSgqlxeb mcHWEL6UK8lF5q/wFWsS0s5Kq9z5yV8KKrpO5t0pufBbczyE4q+Gw2WE96KobfzMF2BS lSpWrUci/mFJPcibc3S1lKaxt7Y7SV2Q08CoJNTxpxXB2eDudckd2zo5dQ76y5qmNNa2 YJEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=/iiGZOLolgjA2ZPldrvDxiQ5Z5+rXkMHlrxZBGQ1V6g=; b=aTKcGwa9+82WQZhK8PxotLTJGD5bJdp/YKJmn6ttLaDFvAPQ/W5PuhrCI5PrXDMD9c 4MLYRzzcs6/2CtCYVWVtTeMNUq2pnVeTRVi01/tbXVAc6n+PITQR3H9fwvCDdq/pwqnU zRJ8q8FTFzxCVmOtKWN3k1GjYVOrOLW6g208FTYnkvjkv1yqaUyFASmtc92slpNrU3S6 GU7DqzvchSdfAyNy3MyRIxHEj9gUPJ0DCpICkXlpNF75piWYIFbTR2G46ec+mZSIURMt zAyOd75zuNEiBDd+ph5429G34WkCIVVl9+/GnDIHUEKD6JAXkvIXbgIqY/W4hhpBGwTF kijA== X-Gm-Message-State: AOAM533j4pWEUlFIHjIEKFwB35po1xJXQZA9VKe1K4XrNP96LOZI5fuN CGi8JjQjg0mRC9nYjKJr3bgCpCoxHag= X-Google-Smtp-Source: ABdhPJy4fYHKLqSsXdIUKB/e5T2+22yYDBhCrp7iQB/x8B/pbhcNDDdtAnMUCrCtYVr2mtO64vRMIA== X-Received: by 2002:aa7:c94c:: with SMTP id h12mr2776075edt.378.1630658036325; Fri, 03 Sep 2021 01:33:56 -0700 (PDT) From: Oleksandr Andrushchenko To: xen-devel@lists.xenproject.org Cc: julien@xen.org, sstabellini@kernel.org, oleksandr_tyshchenko@epam.com, volodymyr_babchuk@epam.com, Artem_Mygaiev@epam.com, roger.pau@citrix.com, bertrand.marquis@arm.com, rahul.singh@arm.com Subject: [PATCH 06/11] xen/domain: Call pci_release_devices() when releasing domain resources Date: Fri, 3 Sep 2021 11:33:42 +0300 Message-Id: <20210903083347.131786-7-andr2000@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210903083347.131786-1-andr2000@gmail.com> References: <20210903083347.131786-1-andr2000@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Oleksandr Tyshchenko This is the very same what we do for DT devices. What is more that x86 already calls pci_release_devices(). Signed-off-by: Oleksandr Tyshchenko --- xen/arch/arm/domain.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c index d99c653626e4..4e40c4098280 100644 --- a/xen/arch/arm/domain.c +++ b/xen/arch/arm/domain.c @@ -985,7 +985,8 @@ static int relinquish_memory(struct domain *d, struct page_list_head *list) * function which may return -ERESTART. */ enum { - PROG_tee = 1, + PROG_pci = 1, + PROG_tee, PROG_xen, PROG_page, PROG_mapping, @@ -1022,6 +1023,12 @@ int domain_relinquish_resources(struct domain *d) #ifdef CONFIG_IOREQ_SERVER ioreq_server_destroy_all(d); #endif +#ifdef CONFIG_HAS_PCI + PROGRESS(pci): + ret = pci_release_devices(d); + if ( ret ) + return ret; +#endif PROGRESS(tee): ret = tee_relinquish_resources(d); -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Sep 03 08:34:27 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Sep 2021 08:34:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177852.323621 (Exim 4.92) (envelope-from ) id 1mM4eZ-0001TH-Kf; Fri, 03 Sep 2021 08:34:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177852.323621; Fri, 03 Sep 2021 08:34:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mM4eZ-0001T7-Gj; Fri, 03 Sep 2021 08:34:27 +0000 Received: by outflank-mailman (input) for mailman id 177852; Fri, 03 Sep 2021 08:34:26 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mM4eY-0006kQ-Df for xen-devel@lists.xenproject.org; Fri, 03 Sep 2021 08:34:26 +0000 Received: from mail-ej1-x62e.google.com (unknown [2a00:1450:4864:20::62e]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 0898630a-f5e4-4ab6-8354-bf16210b9e36; Fri, 03 Sep 2021 08:33:58 +0000 (UTC) Received: by mail-ej1-x62e.google.com with SMTP id me10so10462374ejb.11 for ; Fri, 03 Sep 2021 01:33:58 -0700 (PDT) Received: from a2klaptop.epam.com (host-176-36-245-220.b024.la.net.ua. [176.36.245.220]) by smtp.gmail.com with ESMTPSA id i7sm2311932ejx.73.2021.09.03.01.33.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Sep 2021 01:33:57 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0898630a-f5e4-4ab6-8354-bf16210b9e36 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=kD50gSwDk757eJ2CQu1b9/IhYMvfHenQQYtu99uRv54=; b=G9YXRhru3uNLxB1PDUiun9J9pMrCuA67iL9Y2S0hbpXL6f5CH2X0QxIT5S1a9tUVI0 ngdOqG5buY4ynepqOc4Mqw/59P8H5sjq34iVC/u0iXKce95prSaaImHKqsL0PaYH7vcE D1V6AOs2vm4fw/w3cgP9IhSPze4c2q6V0JyGGMv/a3ElMGbTNF0S7auFCdB0/MVNyqHt MSsg6wqzDA1lelto4azizexS43392uIQej/nGbEwF7OGVlS74cihi3/3uWxljNDqJhHU wFIzTiQMGRpJzgDNE4+dQa/3yv3zMkXoX1BmCUXGm3S/B7/wgbcEBjWuZCJOL6udh3zY kX1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=kD50gSwDk757eJ2CQu1b9/IhYMvfHenQQYtu99uRv54=; b=AP9HIzrCzQkFkZvqieTGE4tmU+0QANe3qh/xgxiywNDWgviFk0YWP8YwbWKO5e0JoX 7VfKO2dAT/dMkoNTCtzWwwdLHfKWWK9qIBrtnVuc1WTKjhyrob7hDBMRVYIXhABpeDui C9bvM3qArCy6hfhVIwyLJUw9EAfE+v1q7JQuFVXI9MX1vQyqzM/lrU8wt+dbj6+sVh7g 6aqrsJZro0owjPWvFQUmw8zcltCArkgxX/pJmMnAXF91fxajQYfnItw2bHbm3S0fzuKi B8cGRUudIGaoFiJC5fUQqCop5n7MuaTYiGmiGPbjEN0EtEHQWASH645RT5eWuhp1ZAVq eKhA== X-Gm-Message-State: AOAM533KzecWeoojC2rWm7Gni1Du+O0rT40VNhGHm+p+LhXB8GYxfmoQ XtAkmYVHree4A9HaC2c44t8VqYf/cMs= X-Google-Smtp-Source: ABdhPJzGKTmhAkRttkjaVwij4GDfdpVmfRmx6aBuBdUijcAaoOwlRu3VoW1BGbNMMqkWyy5d8+/pYQ== X-Received: by 2002:a17:906:9b1:: with SMTP id q17mr2879682eje.546.1630658037434; Fri, 03 Sep 2021 01:33:57 -0700 (PDT) From: Oleksandr Andrushchenko To: xen-devel@lists.xenproject.org Cc: julien@xen.org, sstabellini@kernel.org, oleksandr_tyshchenko@epam.com, volodymyr_babchuk@epam.com, Artem_Mygaiev@epam.com, roger.pau@citrix.com, bertrand.marquis@arm.com, rahul.singh@arm.com, Oleksandr Andrushchenko , Ian Jackson , Juergen Gross Subject: [PATCH 07/11] libxl: Allow removing PCI devices for all types of domains Date: Fri, 3 Sep 2021 11:33:43 +0300 Message-Id: <20210903083347.131786-8-andr2000@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210903083347.131786-1-andr2000@gmail.com> References: <20210903083347.131786-1-andr2000@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Oleksandr Andrushchenko The PCI device remove path may now be used by PVH on ARM, so the assert is no longer valid. Signed-off-by: Oleksandr Andrushchenko Cc: Ian Jackson Cc: Juergen Gross --- tools/libs/light/libxl_pci.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/tools/libs/light/libxl_pci.c b/tools/libs/light/libxl_pci.c index 1a1c2630803b..59f3686fc85e 100644 --- a/tools/libs/light/libxl_pci.c +++ b/tools/libs/light/libxl_pci.c @@ -1947,8 +1947,6 @@ static void do_pci_remove(libxl__egc *egc, pci_remove_state *prs) goto out_fail; } } else { - assert(type == LIBXL_DOMAIN_TYPE_PV); - char *sysfs_path = GCSPRINTF(SYSFS_PCI_DEV"/"PCI_BDF"/resource", pci->domain, pci->bus, pci->dev, pci->func); FILE *f = fopen(sysfs_path, "r"); -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Sep 03 08:34:33 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Sep 2021 08:34:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177859.323632 (Exim 4.92) (envelope-from ) id 1mM4ee-00025Z-WA; Fri, 03 Sep 2021 08:34:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177859.323632; Fri, 03 Sep 2021 08:34:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mM4ee-00025O-S0; Fri, 03 Sep 2021 08:34:32 +0000 Received: by outflank-mailman (input) for mailman id 177859; Fri, 03 Sep 2021 08:34:31 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mM4ed-0006kQ-Dn for xen-devel@lists.xenproject.org; Fri, 03 Sep 2021 08:34:31 +0000 Received: from mail-ej1-x633.google.com (unknown [2a00:1450:4864:20::633]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id fcfff0c5-87bc-448e-bd89-368f58f11371; Fri, 03 Sep 2021 08:33:59 +0000 (UTC) Received: by mail-ej1-x633.google.com with SMTP id jg16so7370339ejc.1 for ; Fri, 03 Sep 2021 01:33:59 -0700 (PDT) Received: from a2klaptop.epam.com (host-176-36-245-220.b024.la.net.ua. [176.36.245.220]) by smtp.gmail.com with ESMTPSA id i7sm2311932ejx.73.2021.09.03.01.33.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Sep 2021 01:33:58 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fcfff0c5-87bc-448e-bd89-368f58f11371 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Hx54vdgUoheVTz/8kdwndGE5xFCEvdbxwnx2M5LV2vg=; b=RdDtLXI6Rg8R+9WLRJYoNMq8UIn9C9UYiKM3atwuaiVC9bWq2G1D1gEb8701s40UoB q3Vkp/Q+AaXXiFaOTz5uyjQxEyJLgSw8QJB7PO+sZnWNbsk2QivJXAbq5fg+Jqbdfysp +QSpl4wnAMWZmYNE5OUiwggYvVyrZQF2WSlhbdngi69rmyZVt6LY3os3UdU+56o7z0Qz aXLK85ahPpB0tLKxrNsEPTzR/jIdjbVD9jnl5/AcTadm4B0eFB/U0iKObJlOH+vNr5El RDPi9bmWAmk9pV5ibKbmzIYJq18buRGok9BqADlAyv9Sraqe2G5UHaYHUFkzWsJQvwxk vQEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Hx54vdgUoheVTz/8kdwndGE5xFCEvdbxwnx2M5LV2vg=; b=ZU935E9As03e8TxEeil25qhW+riYm6XE9eWITrr/ZJ9UU6It0Y8jMfSb27gbCyZYQH 7rVTysvwC+z+PqfePhYlj9jhf8iLKqItd5YCy/pp6AwTvmRxvSNdGRr8bw+AQ09xauuC aOg4wIrhnSUkmfE//8coPTDi1QWx1XoPJCDGAzhgqSsscpeuoyHZM93lvn+7p+tgkGCi tpLceNS3iPxbtrDhEmKVVVO/HGnb84qfctwWpCLdxhnV3eSyXNmGgI264Bg354M5o7g3 KKqrCyHRhrobvkbroh5XCSw5ojMMTlDPWV22YeF7t3kwE3lpR6pbSAwVAN2wMIvsW1KJ aenw== X-Gm-Message-State: AOAM5307TcEyC4GgLUAmz5c86aiXM/0OKVw8x0dRJJCxgTU1kneIREPD tkiVI4TVLaedressSxtb1tk39/tniUM= X-Google-Smtp-Source: ABdhPJxbTzY7zXsW8PjrsejxN3DPMeW22l0e+skzCHi5HgMf4ECl+/PSNQ7TpHFwniDROzLZHbVUSw== X-Received: by 2002:a17:906:a01:: with SMTP id w1mr2947033ejf.117.1630658038658; Fri, 03 Sep 2021 01:33:58 -0700 (PDT) From: Oleksandr Andrushchenko To: xen-devel@lists.xenproject.org Cc: julien@xen.org, sstabellini@kernel.org, oleksandr_tyshchenko@epam.com, volodymyr_babchuk@epam.com, Artem_Mygaiev@epam.com, roger.pau@citrix.com, bertrand.marquis@arm.com, rahul.singh@arm.com, Oleksandr Andrushchenko , Ian Jackson , Juergen Gross Subject: [PATCH 08/11] libxl: Only map legacy PCI IRQs if they are supported Date: Fri, 3 Sep 2021 11:33:44 +0300 Message-Id: <20210903083347.131786-9-andr2000@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210903083347.131786-1-andr2000@gmail.com> References: <20210903083347.131786-1-andr2000@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Oleksandr Andrushchenko Arm's PCI passthrough implementation doesn't support legacy interrupts, but MSI/MSI-X. This can be the case for other platforms too. For that reason introduce a new CONFIG_PCI_SUPP_LEGACY_IRQ and add it to the CFLAGS and compile the relevant code in the toolstack only if applicable. Signed-off-by: Oleksandr Andrushchenko Cc: Ian Jackson Cc: Juergen Gross --- tools/libs/light/Makefile | 4 ++++ tools/libs/light/libxl_pci.c | 13 +++++++++++++ 2 files changed, 17 insertions(+) diff --git a/tools/libs/light/Makefile b/tools/libs/light/Makefile index 7d8c51d49242..bd3f6be2a183 100644 --- a/tools/libs/light/Makefile +++ b/tools/libs/light/Makefile @@ -46,6 +46,10 @@ CFLAGS += -Wno-format-zero-length -Wmissing-declarations \ -Wno-declaration-after-statement -Wformat-nonliteral CFLAGS += -I. +ifeq ($(CONFIG_X86),y) +CFLAGS += -DCONFIG_PCI_SUPP_LEGACY_IRQ +endif + SRCS-$(CONFIG_X86) += libxl_cpuid.c SRCS-$(CONFIG_X86) += libxl_x86.c SRCS-$(CONFIG_X86) += libxl_psr.c diff --git a/tools/libs/light/libxl_pci.c b/tools/libs/light/libxl_pci.c index 59f3686fc85e..cd4fea46c3f7 100644 --- a/tools/libs/light/libxl_pci.c +++ b/tools/libs/light/libxl_pci.c @@ -1434,6 +1434,7 @@ static void pci_add_dm_done(libxl__egc *egc, } } fclose(f); +#ifndef CONFIG_PCI_SUPP_LEGACY_IRQ sysfs_path = GCSPRINTF(SYSFS_PCI_DEV"/"PCI_BDF"/irq", pci->domain, pci->bus, pci->dev, pci->func); f = fopen(sysfs_path, "r"); @@ -1460,6 +1461,7 @@ static void pci_add_dm_done(libxl__egc *egc, } } fclose(f); +#endif /* Don't restrict writes to the PCI config space from this VM */ if (pci->permissive) { @@ -1471,7 +1473,9 @@ static void pci_add_dm_done(libxl__egc *egc, } } +#ifndef CONFIG_PCI_SUPP_LEGACY_IRQ out_no_irq: +#endif if (!isstubdom) { if (pci->rdm_policy == LIBXL_RDM_RESERVE_POLICY_STRICT) { flag &= ~XEN_DOMCTL_DEV_RDM_RELAXED; @@ -1951,7 +1955,9 @@ static void do_pci_remove(libxl__egc *egc, pci_remove_state *prs) pci->bus, pci->dev, pci->func); FILE *f = fopen(sysfs_path, "r"); unsigned int start = 0, end = 0, flags = 0, size = 0; +#ifndef CONFIG_PCI_SUPP_LEGACY_IRQ int irq = 0; +#endif int i; if (f == NULL) { @@ -1983,6 +1989,7 @@ static void do_pci_remove(libxl__egc *egc, pci_remove_state *prs) } fclose(f); skip1: +#ifndef CONFIG_PCI_SUPP_LEGACY_IRQ sysfs_path = GCSPRINTF(SYSFS_PCI_DEV"/"PCI_BDF"/irq", pci->domain, pci->bus, pci->dev, pci->func); f = fopen(sysfs_path, "r"); @@ -2001,8 +2008,14 @@ skip1: } } fclose(f); +#else + /* Silence error: label at end of compound statement */ + ; +#endif } +#ifndef CONFIG_PCI_SUPP_LEGACY_IRQ skip_irq: +#endif rc = 0; out_fail: pci_remove_detached(egc, prs, rc); /* must be last */ -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Sep 03 08:34:38 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Sep 2021 08:34:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177865.323642 (Exim 4.92) (envelope-from ) id 1mM4ek-0002hQ-B6; Fri, 03 Sep 2021 08:34:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177865.323642; Fri, 03 Sep 2021 08:34:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mM4ek-0002hH-7X; Fri, 03 Sep 2021 08:34:38 +0000 Received: by outflank-mailman (input) for mailman id 177865; Fri, 03 Sep 2021 08:34:36 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mM4ei-0006kQ-E5 for xen-devel@lists.xenproject.org; Fri, 03 Sep 2021 08:34:36 +0000 Received: from mail-ej1-x630.google.com (unknown [2a00:1450:4864:20::630]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 3bb67d0b-f39f-4b34-9864-f3691fc81bea; Fri, 03 Sep 2021 08:34:00 +0000 (UTC) Received: by mail-ej1-x630.google.com with SMTP id mf2so10485515ejb.9 for ; Fri, 03 Sep 2021 01:34:00 -0700 (PDT) Received: from a2klaptop.epam.com (host-176-36-245-220.b024.la.net.ua. [176.36.245.220]) by smtp.gmail.com with ESMTPSA id i7sm2311932ejx.73.2021.09.03.01.33.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Sep 2021 01:33:59 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3bb67d0b-f39f-4b34-9864-f3691fc81bea DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=/GHtMwVtwcasyb8hly1Zcy56jKyqF6v6oGi9z4wXBlU=; b=mQ3lDyAu7ulppaS1JJy+SWOFwu+RvtpP1zI3cgCUuBtIuinOwyvLCIG9MxewYdI7wb dV/QNQp9gaBilxa1L3saoMIiNAKa4GjxcPpTanA20hGKCzz5QpJAiNHS/6eiO+aEby+f l7w6stPig8p506HVXOzw2BgAPYcOwkZ+OD0tZuyYui/AU5k+tg6rbLKS49n75aRhxpxL FFVTa9P9ikuYd6dbk2C9zfDC/kBVTCpJCMhTRepxDPdAUW12LYD4QcV3R1ooZ2wQyzED /H+subTI7EzgC9RApqZqRkYcedmNM4JZlibRP0m4S+GaRm+tZmLehtpvYwPU05nhGVEk 4LLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=/GHtMwVtwcasyb8hly1Zcy56jKyqF6v6oGi9z4wXBlU=; b=O4lfH5P6mjh536gva7arPTU9Frb1mcd1r2huTLL9NwRMe4CMVErcHhWA1YyUz1Gn8F tWfkw4jaYubWiEFKwx6qq7PfIWMfh3MD4b+gmG5TbpkKLeHzxcAHMD8Elrjo7PNIUkrf H5cMpYSQSQfTGWG2V2unKdAlXz2FgOFAj6TtXZQol9SqCt3ULYAbvE/PYzawRwWMsMvj nrO9aLXEqip9GkQlLsUeqsJ7kojKilNOv3gnZ+7ULWhIniUF9ewwtlG0kNAqCJUjT7Yf c7rucReZ9HOS56umrG5LTZqKfPlceVAGC5FhP7KHWZidf1iVy9oGKU4S3aYtvP7iNLvJ 02+w== X-Gm-Message-State: AOAM532JkJfQzvOgGj6QtsslnH1vxGZEAnffzrJ39RlJGKs5sgjk4mFU wGuCSbTMJ19X/nPsKqJSSQtMf6X5OsU= X-Google-Smtp-Source: ABdhPJzkdXq4/oqy7sAR6jAHLZTgcQFNU12ssgRybTwH6NU5CgLqCQqqVvZtmbSCS+UTenNgcBH03A== X-Received: by 2002:a17:906:2a8e:: with SMTP id l14mr2909109eje.321.1630658039681; Fri, 03 Sep 2021 01:33:59 -0700 (PDT) From: Oleksandr Andrushchenko To: xen-devel@lists.xenproject.org Cc: julien@xen.org, sstabellini@kernel.org, oleksandr_tyshchenko@epam.com, volodymyr_babchuk@epam.com, Artem_Mygaiev@epam.com, roger.pau@citrix.com, bertrand.marquis@arm.com, rahul.singh@arm.com, Oleksandr Andrushchenko Subject: [PATCH 09/11] xen/arm: Setup MMIO range trap handlers for hardware domain Date: Fri, 3 Sep 2021 11:33:45 +0300 Message-Id: <20210903083347.131786-10-andr2000@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210903083347.131786-1-andr2000@gmail.com> References: <20210903083347.131786-1-andr2000@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Oleksandr Andrushchenko In order vPCI to work it needs all access to PCI configuration space (ECAM) to be synchronized among all entities, e.g. hardware domain and guests. For that implement PCI host bridge specific callbacks to properly setup those ranges depending on particular host bridge implementation. Signed-off-by: Oleksandr Andrushchenko --- xen/arch/arm/pci/ecam.c | 11 +++++++++++ xen/arch/arm/pci/pci-host-common.c | 16 ++++++++++++++++ xen/arch/arm/vpci.c | 13 +++++++++++++ xen/include/asm-arm/pci.h | 8 ++++++++ 4 files changed, 48 insertions(+) diff --git a/xen/arch/arm/pci/ecam.c b/xen/arch/arm/pci/ecam.c index 91c691b41fdf..92ecb2e0762b 100644 --- a/xen/arch/arm/pci/ecam.c +++ b/xen/arch/arm/pci/ecam.c @@ -42,6 +42,16 @@ void __iomem *pci_ecam_map_bus(struct pci_host_bridge *bridge, return base + (PCI_DEVFN(sbdf_t.dev, sbdf_t.fn) << devfn_shift) + where; } +static int pci_ecam_register_mmio_handler(struct domain *d, + struct pci_host_bridge *bridge, + const struct mmio_handler_ops *ops) +{ + struct pci_config_window *cfg = bridge->sysdata; + + register_mmio_handler(d, ops, cfg->phys_addr, cfg->size, NULL); + return 0; +} + /* ECAM ops */ const struct pci_ecam_ops pci_generic_ecam_ops = { .bus_shift = 20, @@ -49,6 +59,7 @@ const struct pci_ecam_ops pci_generic_ecam_ops = { .map_bus = pci_ecam_map_bus, .read = pci_generic_config_read, .write = pci_generic_config_write, + .register_mmio_handler = pci_ecam_register_mmio_handler, } }; diff --git a/xen/arch/arm/pci/pci-host-common.c b/xen/arch/arm/pci/pci-host-common.c index d2fef5476b8e..a89112bfbb7c 100644 --- a/xen/arch/arm/pci/pci-host-common.c +++ b/xen/arch/arm/pci/pci-host-common.c @@ -318,6 +318,22 @@ struct dt_device_node *pci_find_host_bridge_node(struct device *dev) } return bridge->dt_node; } + +int pci_host_iterate_bridges(struct domain *d, + int (*clb)(struct domain *d, + struct pci_host_bridge *bridge)) +{ + struct pci_host_bridge *bridge; + int err; + + list_for_each_entry( bridge, &pci_host_bridges, node ) + { + err = clb(d, bridge); + if ( err ) + return err; + } + return 0; +} /* * Local variables: * mode: C diff --git a/xen/arch/arm/vpci.c b/xen/arch/arm/vpci.c index da8b1ca13c07..258134292458 100644 --- a/xen/arch/arm/vpci.c +++ b/xen/arch/arm/vpci.c @@ -74,11 +74,24 @@ static const struct mmio_handler_ops vpci_mmio_handler = { .write = vpci_mmio_write, }; +static int vpci_setup_mmio_handler(struct domain *d, + struct pci_host_bridge *bridge) +{ + if ( bridge->ops->register_mmio_handler ) + return bridge->ops->register_mmio_handler(d, bridge, + &vpci_mmio_handler); + return 0; +} + int domain_vpci_init(struct domain *d) { if ( !has_vpci(d) ) return 0; + if ( is_hardware_domain(d) ) + return pci_host_iterate_bridges(d, vpci_setup_mmio_handler); + + /* Guest domains use what is programmed in their device tree. */ register_mmio_handler(d, &vpci_mmio_handler, GUEST_VPCI_ECAM_BASE, GUEST_VPCI_ECAM_SIZE, NULL); diff --git a/xen/include/asm-arm/pci.h b/xen/include/asm-arm/pci.h index 7dc4c8dc9026..2c7c7649e00f 100644 --- a/xen/include/asm-arm/pci.h +++ b/xen/include/asm-arm/pci.h @@ -17,6 +17,8 @@ #ifndef __ARM_PCI_H__ #define __ARM_PCI_H__ +#include + #ifdef CONFIG_HAS_PCI #define pci_to_dev(pcidev) (&(pcidev)->arch.dev) @@ -77,6 +79,9 @@ struct pci_ops { uint32_t reg, uint32_t len, uint32_t *value); int (*write)(struct pci_host_bridge *bridge, uint32_t sbdf, uint32_t reg, uint32_t len, uint32_t value); + int (*register_mmio_handler)(struct domain *d, + struct pci_host_bridge *bridge, + const struct mmio_handler_ops *ops); }; /* @@ -107,6 +112,9 @@ int pci_get_host_bridge_segment(const struct dt_device_node *node, uint16_t *segment); struct dt_device_node *pci_find_host_bridge_node(struct device *dev); +int pci_host_iterate_bridges(struct domain *d, + int (*clb)(struct domain *d, + struct pci_host_bridge *bridge)); #else /*!CONFIG_HAS_PCI*/ struct arch_pci_dev { }; -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Sep 03 08:41:18 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Sep 2021 08:41:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177892.323653 (Exim 4.92) (envelope-from ) id 1mM4lA-0005HT-4D; Fri, 03 Sep 2021 08:41:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177892.323653; Fri, 03 Sep 2021 08:41:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mM4lA-0005HM-1J; Fri, 03 Sep 2021 08:41:16 +0000 Received: by outflank-mailman (input) for mailman id 177892; Fri, 03 Sep 2021 08:41:14 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mM4es-0006kQ-EK for xen-devel@lists.xenproject.org; Fri, 03 Sep 2021 08:34:46 +0000 Received: from mail-ej1-x631.google.com (unknown [2a00:1450:4864:20::631]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 1d926dc1-80ff-4ebb-a723-1fd24234f40a; Fri, 03 Sep 2021 08:34:02 +0000 (UTC) Received: by mail-ej1-x631.google.com with SMTP id lc21so10503499ejc.7 for ; Fri, 03 Sep 2021 01:34:02 -0700 (PDT) Received: from a2klaptop.epam.com (host-176-36-245-220.b024.la.net.ua. [176.36.245.220]) by smtp.gmail.com with ESMTPSA id i7sm2311932ejx.73.2021.09.03.01.34.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Sep 2021 01:34:01 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1d926dc1-80ff-4ebb-a723-1fd24234f40a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Xy7BJSB6xaM30OyXxkPFQIY2JXEW71Y3R+/OfIHEOBE=; b=pnUw4Mlz8wE01ctr0MxVIgMnhwLnYDb2XDSr3Mz0utU10pdqiieFvIuxCCByexKtyf B06Oyzl54Te+zID2si0YkZIjwWSmkUavw3mR3hfVyzP1prT4JWTQ2NTIK4x6xtbcRpqc KxtBQtIPNwv9OGv7Awvjre3ntebXcDrWFI2SG529YegtLTDoGtS7s1bc/D2jQxUVo3N7 BdhYDhJHI86NLX1Mc5Y1L3MlkT/LPFTYKEkS5Mb0pAz3/VB/Hn65DqjDFmLtvlvBfV5r z6WPuzwT0gYxxiczN3UQkXeeK6u22iH64pxd2K8aSWXJ8LKEUvYiJdgFvuoa8TTDahw0 xKfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Xy7BJSB6xaM30OyXxkPFQIY2JXEW71Y3R+/OfIHEOBE=; b=Tb8crlNetyA6rFLsr9BPepDhb+mT9n9jfsUBW8A0hc7C/6FqN8EkpaSUFDLxZx5Bm0 EFyPIyQ/FBKiqjBTGdcEYbw27nAms0HXXuw4ith3GQIZT8uX8g1CEoOKpjrOVvimfx5H VFMdHmp7LNZHQUWt6F++n7mtvjQ/iZ8tJxutQaf0Kz6YLSq1dX3aT0TA8EMRT1vHN9rG 0SszP9zXs6zXvrFAGNX6T38VwiduYKf+EWML+ycm9J+wssNO5DKunxRWtf/kP9F0INQM XVNDV/9u0aMfmHpyMCkGGxpYEBsyY5xUaq+gFNREXGgYvoPUo+WA5dUXo5WPfPCrtixp oKOw== X-Gm-Message-State: AOAM5308j4Iig0X44JLaWCBB9ZOGEhuPoZvkJFtBcA9wOI/JQwhpGQ33 8s99qzGcnqNjJqAC3WcSHIWGHWQ1amo= X-Google-Smtp-Source: ABdhPJyJcdfQj9c9044SVO6J1UJQYGNr5fMQWFYrfhn9ETnMa9xx30aD81J57K8Jf8DgGximyczXvQ== X-Received: by 2002:a17:907:2174:: with SMTP id rl20mr2987996ejb.199.1630658041886; Fri, 03 Sep 2021 01:34:01 -0700 (PDT) From: Oleksandr Andrushchenko To: xen-devel@lists.xenproject.org Cc: julien@xen.org, sstabellini@kernel.org, oleksandr_tyshchenko@epam.com, volodymyr_babchuk@epam.com, Artem_Mygaiev@epam.com, roger.pau@citrix.com, bertrand.marquis@arm.com, rahul.singh@arm.com, Oleksandr Andrushchenko Subject: [PATCH 11/11] xen/arm: Process pending vPCI map/unmap operations Date: Fri, 3 Sep 2021 11:33:47 +0300 Message-Id: <20210903083347.131786-12-andr2000@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210903083347.131786-1-andr2000@gmail.com> References: <20210903083347.131786-1-andr2000@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Oleksandr Andrushchenko vPCI may map and unmap PCI device memory (BARs) being passed through which may take a lot of time. For this those operations may be deferred to be performed later, so that they can be safely preempted. Run the corresponding vPCI code while switching a vCPU. Signed-off-by: Oleksandr Andrushchenko --- xen/arch/arm/traps.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c index 219ab3c3fbde..1571fb8afd03 100644 --- a/xen/arch/arm/traps.c +++ b/xen/arch/arm/traps.c @@ -34,6 +34,7 @@ #include #include #include +#include #include #include @@ -2304,6 +2305,11 @@ static bool check_for_vcpu_work(void) } #endif + local_irq_enable(); + if ( has_vpci(v->domain) && vpci_process_pending(v) ) + raise_softirq(SCHEDULE_SOFTIRQ); + local_irq_disable(); + if ( likely(!v->arch.need_flush_to_ram) ) return false; -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Sep 03 08:41:42 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Sep 2021 08:41:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177903.323664 (Exim 4.92) (envelope-from ) id 1mM4la-0005z8-Il; Fri, 03 Sep 2021 08:41:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177903.323664; Fri, 03 Sep 2021 08:41:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mM4la-0005z1-Fe; Fri, 03 Sep 2021 08:41:42 +0000 Received: by outflank-mailman (input) for mailman id 177903; Fri, 03 Sep 2021 08:41:41 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mM4en-0006kQ-E9 for xen-devel@lists.xenproject.org; Fri, 03 Sep 2021 08:34:41 +0000 Received: from mail-ed1-x531.google.com (unknown [2a00:1450:4864:20::531]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 3cbf0903-612d-4e40-aaea-917bad9342ef; Fri, 03 Sep 2021 08:34:01 +0000 (UTC) Received: by mail-ed1-x531.google.com with SMTP id v5so1613984edc.2 for ; Fri, 03 Sep 2021 01:34:01 -0700 (PDT) Received: from a2klaptop.epam.com (host-176-36-245-220.b024.la.net.ua. [176.36.245.220]) by smtp.gmail.com with ESMTPSA id i7sm2311932ejx.73.2021.09.03.01.33.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Sep 2021 01:34:00 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3cbf0903-612d-4e40-aaea-917bad9342ef DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=RKj8rEW+uLzxBa1xS9FCgER2pVUMxy97v84H9BueJo8=; b=Cc7VjnWxryLAC/tqYxNfb0Vqq0sB/g3r4rmDDY0lS2y4ND5fCxj+3AtTH0jMf3UD7I lArRxEur0IpiP8IRmM5bMXAd2tDTqstoOHd1vrOJQB+pAYbF+caMEs1aDP0y6JUJoUAC xEaHLm1ca7cVFaDLT1hlicqg/QeFfEAaQY7S1SpqIHJhYw6d6GtxExLoUnpq0E0zuH+m 4NCp+Ya/PMN9z0TzuqE1T/2/rlEnc8XJFLpeu56yU2FZu5xlOk5bPOVjQrgrStQv7HvU TwhRciy77N17AemdAXrbaCnjfawSj07zHK5ot06VaJwpM/HtZHOSN1AfqKhUFuuc/1HO ob5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=RKj8rEW+uLzxBa1xS9FCgER2pVUMxy97v84H9BueJo8=; b=oBLpbapiCNQnIjv9Mo/sSyhL3oVakBxi1XwL1Wi7m4raUtBsNmjtGeWCoq7dTXXeTC KhocmQ1iynUJWKyuksEXh1BgFK/jRTRPbFN9qbQGg3QpeHcER3uNfb0r1fulY1GJFamB 62zgQyF5dXtDweUZgg+/rJfYhR1agFpdUJtTWRgPVyZ8E3dkOV4MxOj72N2h1gVKp5b9 vw15weokEfFftha6EM7IAETNzYpDgpzrZhG6Te4CYpQzeWncKy3llziRgqTWuOUkSF5w +q8Ng9ouUhGTopIjWQh/VhFVLNkp8wFO1HvkvKKBqNBPjPXhP9sPPQc9MbI4DGh/0pTk Kzfg== X-Gm-Message-State: AOAM533uKOsAif0Gr5pPehfRtIiQNwbwfBJWC0recNqto4ZX7hQfZS3k Xjt3APquPw91Bq5Rgk6LA7LYf07qXZs= X-Google-Smtp-Source: ABdhPJwyyY+X4Ff7jtwDvNQrMZN78ZPm6ovgltm1mRQGeZ/mmH2TfThaCYtmDMf1K+WgzeKR4mkDAg== X-Received: by 2002:aa7:c9d6:: with SMTP id i22mr605692edt.307.1630658040780; Fri, 03 Sep 2021 01:34:00 -0700 (PDT) From: Oleksandr Andrushchenko To: xen-devel@lists.xenproject.org Cc: julien@xen.org, sstabellini@kernel.org, oleksandr_tyshchenko@epam.com, volodymyr_babchuk@epam.com, Artem_Mygaiev@epam.com, roger.pau@citrix.com, bertrand.marquis@arm.com, rahul.singh@arm.com, Oleksandr Andrushchenko Subject: [PATCH 10/11] xen/arm: Do not map PCI ECAM space to Domain-0's p2m Date: Fri, 3 Sep 2021 11:33:46 +0300 Message-Id: <20210903083347.131786-11-andr2000@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210903083347.131786-1-andr2000@gmail.com> References: <20210903083347.131786-1-andr2000@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Oleksandr Andrushchenko Host bridge controller's ECAM space is mapped into Domain-0's p2m, thus it is not possible to trap the same for vPCI via MMIO handlers. For this to work we need to not map those while constructing the domain. Note, that during Domain-0 creation there is no pci_dev yet allocated for host bridges, thus we cannot match PCI host and its associated bridge by SBDF. Use dt_device_node field for checks instead. Signed-off-by: Oleksandr Andrushchenko --- xen/arch/arm/domain_build.c | 3 +++ xen/arch/arm/pci/ecam.c | 17 +++++++++++++++++ xen/arch/arm/pci/pci-host-common.c | 22 ++++++++++++++++++++++ xen/include/asm-arm/pci.h | 12 ++++++++++++ 4 files changed, 54 insertions(+) diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index da427f399711..76f5b513280c 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -1257,6 +1257,9 @@ static int __init map_range_to_domain(const struct dt_device_node *dev, } } + if ( need_mapping && (device_get_class(dev) == DEVICE_PCI) ) + need_mapping = pci_host_bridge_need_p2m_mapping(d, dev, addr, len); + if ( need_mapping ) { res = map_regions_p2mt(d, diff --git a/xen/arch/arm/pci/ecam.c b/xen/arch/arm/pci/ecam.c index 92ecb2e0762b..d32efb7fcbd0 100644 --- a/xen/arch/arm/pci/ecam.c +++ b/xen/arch/arm/pci/ecam.c @@ -52,6 +52,22 @@ static int pci_ecam_register_mmio_handler(struct domain *d, return 0; } +static int pci_ecam_need_p2m_mapping(struct domain *d, + struct pci_host_bridge *bridge, + uint64_t addr, uint64_t len) +{ + struct pci_config_window *cfg = bridge->sysdata; + + if ( !is_hardware_domain(d) ) + return true; + + /* + * We do not want ECAM address space to be mapped in domain's p2m, + * so we can trap access to it. + */ + return cfg->phys_addr != addr; +} + /* ECAM ops */ const struct pci_ecam_ops pci_generic_ecam_ops = { .bus_shift = 20, @@ -60,6 +76,7 @@ const struct pci_ecam_ops pci_generic_ecam_ops = { .read = pci_generic_config_read, .write = pci_generic_config_write, .register_mmio_handler = pci_ecam_register_mmio_handler, + .need_p2m_mapping = pci_ecam_need_p2m_mapping, } }; diff --git a/xen/arch/arm/pci/pci-host-common.c b/xen/arch/arm/pci/pci-host-common.c index a89112bfbb7c..c04be636452d 100644 --- a/xen/arch/arm/pci/pci-host-common.c +++ b/xen/arch/arm/pci/pci-host-common.c @@ -334,6 +334,28 @@ int pci_host_iterate_bridges(struct domain *d, } return 0; } + +bool pci_host_bridge_need_p2m_mapping(struct domain *d, + const struct dt_device_node *node, + uint64_t addr, uint64_t len) +{ + struct pci_host_bridge *bridge; + + list_for_each_entry( bridge, &pci_host_bridges, node ) + { + if ( bridge->dt_node != node ) + continue; + + if ( !bridge->ops->need_p2m_mapping ) + return true; + + return bridge->ops->need_p2m_mapping(d, bridge, addr, len); + } + printk(XENLOG_ERR "Unable to find PCI bridge for %s segment %d, addr %lx\n", + node->full_name, bridge->segment, addr); + return true; +} + /* * Local variables: * mode: C diff --git a/xen/include/asm-arm/pci.h b/xen/include/asm-arm/pci.h index 2c7c7649e00f..9c28a4bdc4b7 100644 --- a/xen/include/asm-arm/pci.h +++ b/xen/include/asm-arm/pci.h @@ -82,6 +82,8 @@ struct pci_ops { int (*register_mmio_handler)(struct domain *d, struct pci_host_bridge *bridge, const struct mmio_handler_ops *ops); + int (*need_p2m_mapping)(struct domain *d, struct pci_host_bridge *bridge, + uint64_t addr, uint64_t len); }; /* @@ -115,9 +117,19 @@ struct dt_device_node *pci_find_host_bridge_node(struct device *dev); int pci_host_iterate_bridges(struct domain *d, int (*clb)(struct domain *d, struct pci_host_bridge *bridge)); +bool pci_host_bridge_need_p2m_mapping(struct domain *d, + const struct dt_device_node *node, + uint64_t addr, uint64_t len); #else /*!CONFIG_HAS_PCI*/ struct arch_pci_dev { }; +static inline bool +pci_host_bridge_need_p2m_mapping(struct domain *d, + const struct dt_device_node *node, + uint64_t addr, uint64_t len) +{ + return true; +} #endif /*!CONFIG_HAS_PCI*/ #endif /* __ARM_PCI_H__ */ -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Sep 03 08:49:47 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Sep 2021 08:49:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177911.323676 (Exim 4.92) (envelope-from ) id 1mM4tL-0006nU-EZ; Fri, 03 Sep 2021 08:49:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177911.323676; Fri, 03 Sep 2021 08:49:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mM4tL-0006nN-BR; Fri, 03 Sep 2021 08:49:43 +0000 Received: by outflank-mailman (input) for mailman id 177911; Fri, 03 Sep 2021 08:49:42 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mM4tK-0006nA-39 for xen-devel@lists.xenproject.org; Fri, 03 Sep 2021 08:49:42 +0000 Received: from smtp-out1.suse.de (unknown [195.135.220.28]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 5dadf295-4f13-42fd-b413-aa9abfb9d364; Fri, 03 Sep 2021 08:49:40 +0000 (UTC) Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 0FD5122663; Fri, 3 Sep 2021 08:49:40 +0000 (UTC) Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap1.suse-dmz.suse.de (Postfix) with ESMTPS id 6EBBF1374A; Fri, 3 Sep 2021 08:49:39 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap1.suse-dmz.suse.de with ESMTPSA id YQ4TGaPhMWFjdAAAGKfGzw (envelope-from ); Fri, 03 Sep 2021 08:49:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5dadf295-4f13-42fd-b413-aa9abfb9d364 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1630658980; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=Etfp5KRM0ihxlz1Fzg+3n+yV+gWrXCILk5YBRRiJ4ec=; b=g/xCu4uUEeLNVhfh4hdAtjtyZDkPPqU9rW19W5JYaL63cE3RPFwRsK8D5oSo5RKnUyhZef oRJKvg5r8mEK1qPZy47OOCWYT8N3Ja1dGzT5F+tieQLSPZ2csfGh8mApFEuhAiWEv2KpMv 5oLIfL7iry/5ho/b6+Y9oBZRKXdYVLY= From: Juergen Gross To: xen-devel@lists.xenproject.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, x86@kernel.org Cc: Juergen Gross , "Rafael J. Wysocki" , Len Brown , Pavel Machek , Greg Kroah-Hartman , "Rafael J. Wysocki" , stable@vger.kernel.org, Boris Ostrovsky , Stefano Stabellini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" Subject: [PATCH 0/2] xen: fix illegal rtc device usage of pv guests Date: Fri, 3 Sep 2021 10:49:35 +0200 Message-Id: <20210903084937.19392-1-jgross@suse.com> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit A recent change in mc146818_get_time() resulted in WARN splats when booting a Xen PV guest. The main reason is that there is a code path resulting in accessing a RTC device which is not present, which has been made obvious by a call of WARN() in this case. This small series is fixing this issue by: - avoiding the RTC device access from drivers/base/power/trace.c in cast there is no legacy RTC device available - resetting the availability flag of a legacy RTC device for Xen PV guests Juergen Gross (2): PM: base: power: don't try to use non-existing RTC for storing data xen: reset legacy rtc flag for PV domU arch/x86/xen/enlighten_pv.c | 7 +++++++ drivers/base/power/trace.c | 10 ++++++++++ 2 files changed, 17 insertions(+) -- 2.26.2 From xen-devel-bounces@lists.xenproject.org Fri Sep 03 08:49:47 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Sep 2021 08:49:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177912.323687 (Exim 4.92) (envelope-from ) id 1mM4tM-00073S-MJ; Fri, 03 Sep 2021 08:49:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177912.323687; Fri, 03 Sep 2021 08:49:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mM4tM-00073L-Ir; Fri, 03 Sep 2021 08:49:44 +0000 Received: by outflank-mailman (input) for mailman id 177912; Fri, 03 Sep 2021 08:49:42 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mM4tK-0006nG-Mc for xen-devel@lists.xenproject.org; Fri, 03 Sep 2021 08:49:42 +0000 Received: from smtp-out2.suse.de (unknown [195.135.220.29]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id e0641ded-0c93-11ec-aefe-12813bfff9fa; Fri, 03 Sep 2021 08:49:41 +0000 (UTC) Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id C9E082001B; Fri, 3 Sep 2021 08:49:40 +0000 (UTC) Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap1.suse-dmz.suse.de (Postfix) with ESMTPS id 71D981374A; Fri, 3 Sep 2021 08:49:40 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap1.suse-dmz.suse.de with ESMTPSA id eKY/GqThMWFjdAAAGKfGzw (envelope-from ); Fri, 03 Sep 2021 08:49:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e0641ded-0c93-11ec-aefe-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1630658980; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cDxNZDOT6mQUMNCs/5bHO5A+JEd2XgxBAJXhmBdSbbw=; b=VbpC8r2iK1pOQ9eNi1TouFnvGAEG3Q2l//bLETrWhVa1Mvebnw9WTw+3fU42jh0vUotgsp luWP3rWesmgxuuRQkhvF72sZKVDy7LzQ6MpzomsIjNTl9HKI+OUwVrQXGEPTWdiRmsnWai o6EzteyS0M7u3UJpASPIGqLHXQUgGIo= From: Juergen Gross To: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org Cc: Juergen Gross , Boris Ostrovsky , Stefano Stabellini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , stable@vger.kernel.org Subject: [PATCH 2/2] xen: reset legacy rtc flag for PV domU Date: Fri, 3 Sep 2021 10:49:37 +0200 Message-Id: <20210903084937.19392-3-jgross@suse.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210903084937.19392-1-jgross@suse.com> References: <20210903084937.19392-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit A Xen PV guest doesn't have a legacy RTC device, so reset the legacy RTC flag. Otherwise the following WARN splat will occur at boot: [ 1.333404] WARNING: CPU: 1 PID: 1 at /home/gross/linux/head/drivers/rtc/rtc-mc146818-lib.c:25 mc146818_get_time+0x1be/0x210 [ 1.333404] Modules linked in: [ 1.333404] CPU: 1 PID: 1 Comm: swapper/0 Tainted: G W 5.14.0-rc7-default+ #282 [ 1.333404] RIP: e030:mc146818_get_time+0x1be/0x210 [ 1.333404] Code: c0 64 01 c5 83 fd 45 89 6b 14 7f 06 83 c5 64 89 6b 14 41 83 ec 01 b8 02 00 00 00 44 89 63 10 5b 5d 41 5c 41 5d 41 5e 41 5f c3 <0f> 0b 48 c7 c7 30 0e ef 82 4c 89 e6 e8 71 2a 24 00 48 c7 c0 ff ff [ 1.333404] RSP: e02b:ffffc90040093df8 EFLAGS: 00010002 [ 1.333404] RAX: 00000000000000ff RBX: ffffc90040093e34 RCX: 0000000000000000 [ 1.333404] RDX: 0000000000000001 RSI: 0000000000000000 RDI: 000000000000000d [ 1.333404] RBP: ffffffff82ef0e30 R08: ffff888005013e60 R09: 0000000000000000 [ 1.333404] R10: ffffffff82373e9b R11: 0000000000033080 R12: 0000000000000200 [ 1.333404] R13: 0000000000000000 R14: 0000000000000002 R15: ffffffff82cdc6d4 [ 1.333404] FS: 0000000000000000(0000) GS:ffff88807d440000(0000) knlGS:0000000000000000 [ 1.333404] CS: 10000e030 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 1.333404] CR2: 0000000000000000 CR3: 000000000260a000 CR4: 0000000000050660 [ 1.333404] Call Trace: [ 1.333404] ? wakeup_sources_sysfs_init+0x30/0x30 [ 1.333404] ? rdinit_setup+0x2b/0x2b [ 1.333404] early_resume_init+0x23/0xa4 [ 1.333404] ? cn_proc_init+0x36/0x36 [ 1.333404] do_one_initcall+0x3e/0x200 [ 1.333404] kernel_init_freeable+0x232/0x28e [ 1.333404] ? rest_init+0xd0/0xd0 [ 1.333404] kernel_init+0x16/0x120 [ 1.333404] ret_from_fork+0x1f/0x30 Cc: Signed-off-by: Juergen Gross --- arch/x86/xen/enlighten_pv.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/arch/x86/xen/enlighten_pv.c b/arch/x86/xen/enlighten_pv.c index 753f63734c13..349f780a1567 100644 --- a/arch/x86/xen/enlighten_pv.c +++ b/arch/x86/xen/enlighten_pv.c @@ -1214,6 +1214,11 @@ static void __init xen_dom0_set_legacy_features(void) x86_platform.legacy.rtc = 1; } +static void __init xen_domu_set_legacy_features(void) +{ + x86_platform.legacy.rtc = 0; +} + /* First C function to be called on Xen boot */ asmlinkage __visible void __init xen_start_kernel(void) { @@ -1359,6 +1364,8 @@ asmlinkage __visible void __init xen_start_kernel(void) add_preferred_console("xenboot", 0, NULL); if (pci_xen) x86_init.pci.arch_init = pci_xen_init; + x86_platform.set_legacy_features = + xen_domu_set_legacy_features; } else { const struct dom0_vga_console_info *info = (void *)((char *)xen_start_info + -- 2.26.2 From xen-devel-bounces@lists.xenproject.org Fri Sep 03 08:49:48 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Sep 2021 08:49:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177913.323698 (Exim 4.92) (envelope-from ) id 1mM4tP-0007MH-VH; Fri, 03 Sep 2021 08:49:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177913.323698; Fri, 03 Sep 2021 08:49:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mM4tP-0007M5-Ru; Fri, 03 Sep 2021 08:49:47 +0000 Received: by outflank-mailman (input) for mailman id 177913; Fri, 03 Sep 2021 08:49:47 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mM4tP-0006nG-Gh for xen-devel@lists.xenproject.org; Fri, 03 Sep 2021 08:49:47 +0000 Received: from smtp-out1.suse.de (unknown [195.135.220.28]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id e0641dec-0c93-11ec-aefe-12813bfff9fa; Fri, 03 Sep 2021 08:49:41 +0000 (UTC) Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 67AF722666; Fri, 3 Sep 2021 08:49:40 +0000 (UTC) Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap1.suse-dmz.suse.de (Postfix) with ESMTPS id 1527913754; Fri, 3 Sep 2021 08:49:40 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap1.suse-dmz.suse.de with ESMTPSA id SD+dA6ThMWFjdAAAGKfGzw (envelope-from ); Fri, 03 Sep 2021 08:49:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e0641dec-0c93-11ec-aefe-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1630658980; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2A79ijv44MFRRI4yP9IKOdGZLkyzD6D8f46U5bOTMG8=; b=YaUyhefWzsHHkhY9meNyZ+nn5OZODEbPW68xXVIYL/Z3GsIY0wJ6ADl0f1uKxP/ao0IOzf 7tkHLaKoHp2ra3Mq30rV0xmgUe0Zvl3BHYlchwLyMW2aH5QnXmYyUenSuhEv6x4NLizQQM xQiOoW4Iv3P3Ud7OZuNeMHRCHmstlzk= From: Juergen Gross To: xen-devel@lists.xenproject.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Juergen Gross , "Rafael J. Wysocki" , Len Brown , Pavel Machek , Greg Kroah-Hartman , "Rafael J. Wysocki" , stable@vger.kernel.org Subject: [PATCH 1/2] PM: base: power: don't try to use non-existing RTC for storing data Date: Fri, 3 Sep 2021 10:49:36 +0200 Message-Id: <20210903084937.19392-2-jgross@suse.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210903084937.19392-1-jgross@suse.com> References: <20210903084937.19392-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In there is no legacy RTC device, don't try to use it for storing trace data across suspend/resume. Cc: Signed-off-by: Juergen Gross --- drivers/base/power/trace.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/drivers/base/power/trace.c b/drivers/base/power/trace.c index a97f33d0c59f..b7c80849455c 100644 --- a/drivers/base/power/trace.c +++ b/drivers/base/power/trace.c @@ -13,6 +13,7 @@ #include #include #include +#include #include @@ -165,6 +166,9 @@ void generate_pm_trace(const void *tracedata, unsigned int user) const char *file = *(const char **)(tracedata + 2); unsigned int user_hash_value, file_hash_value; + if (!x86_platform.legacy.rtc) + return 0; + user_hash_value = user % USERHASH; file_hash_value = hash_string(lineno, file, FILEHASH); set_magic_time(user_hash_value, file_hash_value, dev_hash_value); @@ -267,6 +271,9 @@ static struct notifier_block pm_trace_nb = { static int __init early_resume_init(void) { + if (!x86_platform.legacy.rtc) + return 0; + hash_value_early_read = read_magic_time(); register_pm_notifier(&pm_trace_nb); return 0; @@ -277,6 +284,9 @@ static int __init late_resume_init(void) unsigned int val = hash_value_early_read; unsigned int user, file, dev; + if (!x86_platform.legacy.rtc) + return 0; + user = val % USERHASH; val = val / USERHASH; file = val % FILEHASH; -- 2.26.2 From xen-devel-bounces@lists.xenproject.org Fri Sep 03 08:56:39 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Sep 2021 08:56:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177928.323709 (Exim 4.92) (envelope-from ) id 1mM4zz-0001D7-MY; Fri, 03 Sep 2021 08:56:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177928.323709; Fri, 03 Sep 2021 08:56:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mM4zz-0001D0-JQ; Fri, 03 Sep 2021 08:56:35 +0000 Received: by outflank-mailman (input) for mailman id 177928; Fri, 03 Sep 2021 08:56:34 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mM4zy-0001Cu-43 for xen-devel@lists.xenproject.org; Fri, 03 Sep 2021 08:56:34 +0000 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id d610c1c8-0c94-11ec-aefe-12813bfff9fa; Fri, 03 Sep 2021 08:56:33 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id F1B3161051; Fri, 3 Sep 2021 08:56:31 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d610c1c8-0c94-11ec-aefe-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1630659392; bh=SsjjbztlEwoQ2/FB20kOEWlK/4U11FZMfaPIS5UzwPA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=HIACXt/YT6pWCqM1ZXgIK14DP/a+8b2wZJAtH533JTB7bHiNh5hQjPgWr4l844+Hp fsqjfJdlFyq4d5jAQMavIFBifH1me5UlrWLbbRy3fBUFxN2leYC9fYTFblIYrARotV Weq2nXrRWULvKRmXB2e4DIi5A9/LS26+/JVxSY+U= Date: Fri, 3 Sep 2021 10:56:29 +0200 From: Greg Kroah-Hartman To: Juergen Gross Cc: xen-devel@lists.xenproject.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, "Rafael J. Wysocki" , Len Brown , Pavel Machek , "Rafael J. Wysocki" , stable@vger.kernel.org Subject: Re: [PATCH 1/2] PM: base: power: don't try to use non-existing RTC for storing data Message-ID: References: <20210903084937.19392-1-jgross@suse.com> <20210903084937.19392-2-jgross@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210903084937.19392-2-jgross@suse.com> On Fri, Sep 03, 2021 at 10:49:36AM +0200, Juergen Gross wrote: > In there is no legacy RTC device, don't try to use it for storing trace > data across suspend/resume. > > Cc: > Signed-off-by: Juergen Gross > --- > drivers/base/power/trace.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/drivers/base/power/trace.c b/drivers/base/power/trace.c > index a97f33d0c59f..b7c80849455c 100644 > --- a/drivers/base/power/trace.c > +++ b/drivers/base/power/trace.c > @@ -13,6 +13,7 @@ > #include > #include > #include > +#include > > #include > > @@ -165,6 +166,9 @@ void generate_pm_trace(const void *tracedata, unsigned int user) > const char *file = *(const char **)(tracedata + 2); > unsigned int user_hash_value, file_hash_value; > > + if (!x86_platform.legacy.rtc) > + return 0; Why does the driver core code here care about a platform/arch-specific thing at all? Did you just break all other arches? thanks, greg k-h From xen-devel-bounces@lists.xenproject.org Fri Sep 03 09:02:07 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Sep 2021 09:02:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177935.323719 (Exim 4.92) (envelope-from ) id 1mM55G-0002rv-B1; Fri, 03 Sep 2021 09:02:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177935.323719; Fri, 03 Sep 2021 09:02:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mM55G-0002ro-85; Fri, 03 Sep 2021 09:02:02 +0000 Received: by outflank-mailman (input) for mailman id 177935; Fri, 03 Sep 2021 09:02:01 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mM55F-0002rh-1X for xen-devel@lists.xenproject.org; Fri, 03 Sep 2021 09:02:01 +0000 Received: from smtp-out1.suse.de (unknown [195.135.220.28]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id e6886402-fcf2-4f8d-a42a-beb599e3b106; Fri, 03 Sep 2021 09:02:00 +0000 (UTC) Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 5EFA6225F7; Fri, 3 Sep 2021 09:01:59 +0000 (UTC) Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap1.suse-dmz.suse.de (Postfix) with ESMTPS id 0FB0C1374A; Fri, 3 Sep 2021 09:01:59 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap1.suse-dmz.suse.de with ESMTPSA id 2qW5AYfkMWFBdwAAGKfGzw (envelope-from ); Fri, 03 Sep 2021 09:01:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e6886402-fcf2-4f8d-a42a-beb599e3b106 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1630659719; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=y2yOgR7xOsgNe3DptYo2QPyqQttv32W4xVBl15aqNN4=; b=pNNE6BX8asHX6WKrgFgKgJflKWF5Ifavakx2rqMPBZZDZpfs2PgmzaM61GHNjicbucQaA4 gYG1qSy5fMSSHEv6bwSJbR+RVxktEdMYGR5MnqeZ6tCaBOKDNFCE3fMsHRcAyWj+Mm8ben LzQuKW/A7oCAYGQQFM9AdQ5A3LB1+N4= Subject: Re: [PATCH 1/2] PM: base: power: don't try to use non-existing RTC for storing data To: Greg Kroah-Hartman Cc: xen-devel@lists.xenproject.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, "Rafael J. Wysocki" , Len Brown , Pavel Machek , "Rafael J. Wysocki" , stable@vger.kernel.org References: <20210903084937.19392-1-jgross@suse.com> <20210903084937.19392-2-jgross@suse.com> From: Juergen Gross Message-ID: <1b6a8f9c-2a5f-e97e-c89d-5983ceeb20e5@suse.com> Date: Fri, 3 Sep 2021 11:01:58 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="8QrHnFxLhYwW5JVUDZedIeiKcRWLD8jDi" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --8QrHnFxLhYwW5JVUDZedIeiKcRWLD8jDi Content-Type: multipart/mixed; boundary="DDwF9mzVWNkpBGBzATm4O5noHEiM7Qhxi"; protected-headers="v1" From: Juergen Gross To: Greg Kroah-Hartman Cc: xen-devel@lists.xenproject.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, "Rafael J. Wysocki" , Len Brown , Pavel Machek , "Rafael J. Wysocki" , stable@vger.kernel.org Message-ID: <1b6a8f9c-2a5f-e97e-c89d-5983ceeb20e5@suse.com> Subject: Re: [PATCH 1/2] PM: base: power: don't try to use non-existing RTC for storing data References: <20210903084937.19392-1-jgross@suse.com> <20210903084937.19392-2-jgross@suse.com> In-Reply-To: --DDwF9mzVWNkpBGBzATm4O5noHEiM7Qhxi Content-Type: multipart/mixed; boundary="------------7C43D073BE29B721237268B8" Content-Language: en-US This is a multi-part message in MIME format. --------------7C43D073BE29B721237268B8 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 03.09.21 10:56, Greg Kroah-Hartman wrote: > On Fri, Sep 03, 2021 at 10:49:36AM +0200, Juergen Gross wrote: >> In there is no legacy RTC device, don't try to use it for storing trac= e >> data across suspend/resume. >> >> Cc: >> Signed-off-by: Juergen Gross >> --- >> drivers/base/power/trace.c | 10 ++++++++++ >> 1 file changed, 10 insertions(+) >> >> diff --git a/drivers/base/power/trace.c b/drivers/base/power/trace.c >> index a97f33d0c59f..b7c80849455c 100644 >> --- a/drivers/base/power/trace.c >> +++ b/drivers/base/power/trace.c >> @@ -13,6 +13,7 @@ >> #include >> #include >> #include >> +#include >> =20 >> #include >> =20 >> @@ -165,6 +166,9 @@ void generate_pm_trace(const void *tracedata, unsi= gned int user) >> const char *file =3D *(const char **)(tracedata + 2); >> unsigned int user_hash_value, file_hash_value; >> =20 >> + if (!x86_platform.legacy.rtc) >> + return 0; >=20 > Why does the driver core code here care about a platform/arch-specific > thing at all? Did you just break all other arches? This file is only compiled for x86. It depends on CONFIG_PM_TRACE_RTC, which has a "depends on X86" attribute. Juergen --------------7C43D073BE29B721237268B8 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Transfer-Encoding: quoted-printable Content-Description: OpenPGP public key Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy= cWx w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O= f8Z d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y= 9bf IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq= G7/ 377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR= 3Jv c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA= QIe AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT= hpw dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0= MbD 1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv= oPH Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v= 5QL +qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ= 2Vu IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC= QoL BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr= Wf0 teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC= /nu AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh= ITT d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm= XBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz= 80h SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC= AcD AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn= FOX gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1= jnD kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0= N51 N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l= otu fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1= tqS EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA= hsD BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3= g3O ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5= dM7 wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5= D+j LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm= V2x AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N= Eaw QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW= nHI s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR= wgn BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV= bVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk= pEd IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA= QAB wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw= Tbe 8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1= vJz Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8= VGi wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW= svi uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX= zXs ZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------7C43D073BE29B721237268B8-- --DDwF9mzVWNkpBGBzATm4O5noHEiM7Qhxi-- --8QrHnFxLhYwW5JVUDZedIeiKcRWLD8jDi Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmEx5IYFAwAAAAAACgkQsN6d1ii/Ey8Z Ywf+Pq3IKlaBuk34XWwT2ZcLn5H2s4d3HKoC1sokLsNtHiDJAveAMkhzsaIiSP8xfYzC0FKpGsB2 Y9iAFojypHyCF/BVEY1A48vxMFfYVcgqrohKB9MUVOhKDsaB5mzAZ7YeqQR5khtuc5J2B34Rij5c VW0E0QjxjgcPL4O0ZFw9+p+f/BpIBECqUZV1hVoSiEtunFIt9xz+hJFJ9CF5P/ic0lsaNy2aTUos 3sHTrWdrBcHLE8pPN4wYXWz5SBj4HW64jG9C/nO6lw43EJ4JO4tw9KtgQ7VI4oQphdQmiKqk8Vzw m3FWeab8bAWHHq9/MpyGfh+SBea4edJOy/pVI7CKng== =vU83 -----END PGP SIGNATURE----- --8QrHnFxLhYwW5JVUDZedIeiKcRWLD8jDi-- From xen-devel-bounces@lists.xenproject.org Fri Sep 03 09:05:00 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Sep 2021 09:05:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177942.323731 (Exim 4.92) (envelope-from ) id 1mM586-0003ZN-Ty; Fri, 03 Sep 2021 09:04:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177942.323731; Fri, 03 Sep 2021 09:04:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mM586-0003ZG-Qg; Fri, 03 Sep 2021 09:04:58 +0000 Received: by outflank-mailman (input) for mailman id 177942; Fri, 03 Sep 2021 09:04:56 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mM584-0003ZA-Sn for xen-devel@lists.xenproject.org; Fri, 03 Sep 2021 09:04:56 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mM581-0000er-Sf; Fri, 03 Sep 2021 09:04:53 +0000 Received: from 54-240-197-239.amazon.com ([54.240.197.239] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1mM581-0002uw-MR; Fri, 03 Sep 2021 09:04:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=GBrzngP5vJbdy9YlVKO13Ln629Mn55ISUbjkYvuttWo=; b=kcv2bQrhr9WWltUjml2Nfb25yz HWgnrzQwnnlM6x8Q3WujjW7esIL6kVj7aov6pPkAwz7IqXH7Po2kTCn/XVW56erKwwMqr8rTedZ8Y X3jqaAbzis2k7ekcwSeYhQ24qltM2vKDTYAbpnwbjJmc6VCVubc9ks5tqaJunNI8UF3g=; Subject: Re: [PATCH 11/11] xen/arm: Process pending vPCI map/unmap operations To: Oleksandr Andrushchenko , xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, oleksandr_tyshchenko@epam.com, volodymyr_babchuk@epam.com, Artem_Mygaiev@epam.com, roger.pau@citrix.com, bertrand.marquis@arm.com, rahul.singh@arm.com, Oleksandr Andrushchenko References: <20210903083347.131786-1-andr2000@gmail.com> <20210903083347.131786-12-andr2000@gmail.com> From: Julien Grall Message-ID: Date: Fri, 3 Sep 2021 10:04:51 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210903083347.131786-12-andr2000@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Hi Oleksandr, On 03/09/2021 09:33, Oleksandr Andrushchenko wrote: > From: Oleksandr Andrushchenko > > vPCI may map and unmap PCI device memory (BARs) being passed through which > may take a lot of time. For this those operations may be deferred to be > performed later, so that they can be safely preempted. > Run the corresponding vPCI code while switching a vCPU. IIUC, you are talking about the function map_range() in xen/drivers/vpci/header. The function has the following todo for Arm: /* * ARM TODOs: * - On ARM whether the memory is prefetchable or not should be passed * to map_mmio_regions in order to decide which memory attributes * should be used. * * - {un}map_mmio_regions doesn't support preemption. */ This doesn't seem to be addressed in the two series for PCI passthrough sent so far. Do you have any plan to handle it? > > Signed-off-by: Oleksandr Andrushchenko > --- > xen/arch/arm/traps.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c > index 219ab3c3fbde..1571fb8afd03 100644 > --- a/xen/arch/arm/traps.c > +++ b/xen/arch/arm/traps.c > @@ -34,6 +34,7 @@ > #include > #include > #include > +#include > > #include > #include > @@ -2304,6 +2305,11 @@ static bool check_for_vcpu_work(void) > } > #endif > > + local_irq_enable(); > + if ( has_vpci(v->domain) && vpci_process_pending(v) ) Looking at the code of vpci_process_pending(), it looks like there are some rework to do for guest. Do you plan to handle it as part of the vPCI series? > + raise_softirq(SCHEDULE_SOFTIRQ); > + local_irq_disable(); > + From my understanding of vcpi_process_pending(). The function will return true if there are more work to schedule. However, if check_for_vcpu_for_work() return false, then we will return to the guest before any work for vCPI has finished. This is because check_for_vcpu_work() will not be called again. In this case, I think you want to return as soon as you know we need to reschedule. However, looking at the rest of the code, we already have a check for vpci in the common IOREQ code. So we would end up to call twice vpci_process_pending(). Maybe we should move the call from the IOREQ to arch-code. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Sep 03 09:09:07 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Sep 2021 09:09:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177948.323742 (Exim 4.92) (envelope-from ) id 1mM5C4-0004EB-E8; Fri, 03 Sep 2021 09:09:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177948.323742; Fri, 03 Sep 2021 09:09:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mM5C4-0004E4-B9; Fri, 03 Sep 2021 09:09:04 +0000 Received: by outflank-mailman (input) for mailman id 177948; Fri, 03 Sep 2021 09:09:02 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mM5C2-0004Dy-7D for xen-devel@lists.xenproject.org; Fri, 03 Sep 2021 09:09:02 +0000 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 9401bf88-0c96-11ec-aefe-12813bfff9fa; Fri, 03 Sep 2021 09:09:01 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 22EDB60FA0; Fri, 3 Sep 2021 09:08:59 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9401bf88-0c96-11ec-aefe-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1630660140; bh=DcjjJ2WAyz1ejKxh5caZx2UjPxskQXotN1KC+CVTphM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AXVe52q+2qENaWaDMiNqezmL4BsUWssD8bJgO6b/o7VEIMHLNCgzHRygULaFTLwRR oGz0JvrwOuCyWgZZPRJsgjb88aE0JCr9iBHnqDnHyutHvuocaJmuo0+o0dzEvLEmh3 rgQwV9xE7s8/DBL80QGApRESQeCjgwrWCZXPWS2g= Date: Fri, 3 Sep 2021 11:08:58 +0200 From: Greg Kroah-Hartman To: Juergen Gross Cc: xen-devel@lists.xenproject.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, "Rafael J. Wysocki" , Len Brown , Pavel Machek , "Rafael J. Wysocki" , stable@vger.kernel.org Subject: Re: [PATCH 1/2] PM: base: power: don't try to use non-existing RTC for storing data Message-ID: References: <20210903084937.19392-1-jgross@suse.com> <20210903084937.19392-2-jgross@suse.com> <1b6a8f9c-2a5f-e97e-c89d-5983ceeb20e5@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1b6a8f9c-2a5f-e97e-c89d-5983ceeb20e5@suse.com> On Fri, Sep 03, 2021 at 11:01:58AM +0200, Juergen Gross wrote: > On 03.09.21 10:56, Greg Kroah-Hartman wrote: > > On Fri, Sep 03, 2021 at 10:49:36AM +0200, Juergen Gross wrote: > > > In there is no legacy RTC device, don't try to use it for storing trace > > > data across suspend/resume. > > > > > > Cc: > > > Signed-off-by: Juergen Gross > > > --- > > > drivers/base/power/trace.c | 10 ++++++++++ > > > 1 file changed, 10 insertions(+) > > > > > > diff --git a/drivers/base/power/trace.c b/drivers/base/power/trace.c > > > index a97f33d0c59f..b7c80849455c 100644 > > > --- a/drivers/base/power/trace.c > > > +++ b/drivers/base/power/trace.c > > > @@ -13,6 +13,7 @@ > > > #include > > > #include > > > #include > > > +#include > > > #include > > > @@ -165,6 +166,9 @@ void generate_pm_trace(const void *tracedata, unsigned int user) > > > const char *file = *(const char **)(tracedata + 2); > > > unsigned int user_hash_value, file_hash_value; > > > + if (!x86_platform.legacy.rtc) > > > + return 0; > > > > Why does the driver core code here care about a platform/arch-specific > > thing at all? Did you just break all other arches? > > This file is only compiled for x86. It depends on CONFIG_PM_TRACE_RTC, > which has a "depends on X86" attribute. Odd, and not obvious at all :( Ok, I'll let Rafael review this... From xen-devel-bounces@lists.xenproject.org Fri Sep 03 09:17:12 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Sep 2021 09:17:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177954.323752 (Exim 4.92) (envelope-from ) id 1mM5Jr-0005rm-7S; Fri, 03 Sep 2021 09:17:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177954.323752; Fri, 03 Sep 2021 09:17:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mM5Jr-0005rf-4U; Fri, 03 Sep 2021 09:17:07 +0000 Received: by outflank-mailman (input) for mailman id 177954; Fri, 03 Sep 2021 09:17:06 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mM5Jq-0005rZ-1h for xen-devel@lists.xenproject.org; Fri, 03 Sep 2021 09:17:06 +0000 Received: from foss.arm.com (unknown [217.140.110.172]) by us1-rack-iad1.inumbo.com (Halon) with ESMTP id 728e836a-9979-4ee7-9e3e-b594a3f5a662; Fri, 03 Sep 2021 09:17:03 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 348A11FB; Fri, 3 Sep 2021 02:17:03 -0700 (PDT) Received: from [10.57.13.101] (unknown [10.57.13.101]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E59343F694; Fri, 3 Sep 2021 02:17:01 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 728e836a-9979-4ee7-9e3e-b594a3f5a662 Subject: Re: [PATCH v2] xen/arm64: Remove vreg_emulate_sysreg32 To: Julien Grall , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Volodymyr Babchuk , bertrand.marquis@arm.com, Ash Wilding , Ian Jackson References: <20210729104258.6320-1-michal.orzel@arm.com> <4a5ac822-3078-de0e-8f84-6881d47ad3eb@xen.org> <8974fc82-94c1-ef85-153c-0923f5faf331@arm.com> From: Michal Orzel Message-ID: <9502c0fa-3e46-3cd3-7de8-c7adccca1397@arm.com> Date: Fri, 3 Sep 2021 11:16:56 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 02.09.2021 14:50, Julien Grall wrote: > On 01/09/2021 10:38, Michal Orzel wrote: >> Hi Julien, > > Hi Michal, > >> On 06.08.2021 13:12, Julien Grall wrote: >>> >>> >>> On 29/07/2021 12:47, Michal Orzel wrote: >>>> Hi Julien, >>> >>> Hi Michal, >>> >>>> On 29.07.2021 13:20, Julien Grall wrote: >>>>> Hi Michal, >>>>> >>>>> On 29/07/2021 11:42, Michal Orzel wrote: >>>>>> According to ARMv8A architecture, AArch64 registers >>>>>> are 64bit wide even though in many cases the upper >>>>>> 32bit is reserved. Therefore there is no need for >>>>>> function vreg_emulate_sysreg32 on arm64. This means >>>>>> that we can have just one function vreg_emulate_sysreg >>>>>> using new function pointer: >>>>>> typedef bool (*vreg_reg_fn_t)(struct cpu_user_regs *regs, >>>>>>                                  register_t *r, bool read); >>>>>> >>>>>> Modify vreg_emulate_cp32 to use the new function pointer >>>>>> as well. >>>>>> >>>>>> This change allows to properly use 64bit registers in AArch64 >>>>>> state and in case of AArch32 the upper 32 bits of AArch64 >>>>>> registers are inaccessible and are ignored(D1.20.1 ARM DDI 0487A.j). >>>>> >>>>> What you wrote only says that the bits are ignored. It doesn't say whether the bits will be 0. >>>>> >>>>> They are probably, but as I wrote yesterday, I couldn't confirm it. >>>>> >>>> Should I then remove this part of the commit or write below?: >>>> "We can assume that those bits will be 0 but the architecture >>>> reference manual does not clarify this." >>> >>> There was some back and forth on security@xen.org about this. I will summarizing the discussion here as we considered this was a just a bug. >>> >>> I wasn't looking at the correct section in the Arm Arm. There is a paragraph clearly describing the expected behavior in a different section (thanks Ash for the pointer!). Per section D1.19.2 in DDI 0487F.c: >>> >>> " >>> If the general-purpose register was accessible from AArch32 state >>> >>> The upper 32 bits either become zero, or hold the value that the same architectural register held before any AArch32 execution. The choice between these two options is IMPLEMENTATION DEFINED, and might vary dynamically within an implementation. Correspondingly, software must >>> regard the value as being a CONSTRAINED UNPREDICTABLE choice between these two values. >>> >>> This behavior applies regardless of whether any execution occurred at the Exception level that was using AArch32. That is, this behavior applies even if AArch32 state was entered by an exception >>> return from AArch64 state, and another exception was immediately taken to AArch64 state without any instruction execution in AArch32 state. >>> " >>> >>> So we can't assume the top 32-bits are zeroed unless the hypervisor ensured they were. Today, we don't have that guarantee in Xen. >>> >>> This needs to be fixed. The two approachs we discussed are: >>>     1) Update set_user_reg() to zero the top 32-bit. We have a couple of places using directly the fields xN. So we would need to switch them to use set_user_reg() >>>     2) Only saving/restoring the bottom 32-bit when entering/leaving the hypervisor. >>> >>> At the moment, my preference goes towards the latter because we don't risk to introduce new place where set_user_reg() is not used. >>> >>> I have quickly hack the entry path. This would look like: >>> >>> diff --git a/xen/arch/arm/arm64/entry.S b/xen/arch/arm/arm64/entry.S >>> index fc3811ad0ad5..65e24c88b059 100644 >>> --- a/xen/arch/arm/arm64/entry.S >>> +++ b/xen/arch/arm/arm64/entry.S >>> @@ -111,6 +111,11 @@ >>>    */ >>>           .macro  entry, hyp, compat, save_x0_x1=1 >>>           sub     sp, sp, #(UREGS_SPSR_el1 - UREGS_LR) /* CPSR, PC, SP, LR */ >>> +        .if \compat == 1 /* AArch32 mode */ >>> +        /* Clobber the top 32-bit of the registers */ >>> +        mov    w0, w0 >>> +        mov    w1, w1 >>> +        .endif >>>           push    x28, x29 >>>           push    x26, x27 >>>           push    x24, x25 >>> >>> I haven't looked whether this can be optimized or the exit path would be easier to modify. >>> >>> Anyway, this is not a new bug so I would be fine to get this patch merged first. Although, I think this wants to be fixed for xen 4.16 (CCing Ian to track it). >>> >>> I will try to find sometimes in the next couple of weeks to fix it and have another review of this patch. >>> >> >> As the 4.16 release is getting closer I wanted to ask whether you need help with creating a pre-work patch so that this patch can be merged. > > Sorry I haven't looked at the bug yet. I don't think the bug I reported necessarily needs to go first. This is not a new bug and AFAICT your patch is not going to make it worse than the current state. > > Your patch needs to have an updated commit message summarizing what we discussed and a second review. No need to resend a patch for the updated commit message, this can be discussed here and updated on commit (I assuming there is no other comments). > If the following message is ok for you, please update the commit msg after acking this change: " According to ARMv8A architecture, AArch64 registers are 64bit wide even though in many cases the upper 32bit is reserved. Therefore there is no need for function vreg_emulate_sysreg32 on arm64. This means that we can have just one function vreg_emulate_sysreg using new function pointer: typedef bool (*vreg_reg_fn_t)(struct cpu_user_regs *regs, register_t *r, bool read); Modify vreg_emulate_cp32 to use the new function pointer as well. This change allows to properly use 64bit registers in AArch64 state. In case of AArch32 the documantation (D1.20.2, DDI 0487A.j) states that "the upper 32 bits either become zero, or hold the value that the same architectural register held before any AArch32 execution." As the choice between them is IMPLEMENTATION DEFINED we cannot assume they are zeroed. Xen should ensure that but currently it does not. This is not a new bug and must be fixed as agreed during a discussion over this patch. " >> I believe this patch wants to be merged for 4.16 as the other sysreg related patches are merged already, so I'm offering a help. > > If you have spare time that would be great. There are a few bits I wanted to look other than the entry place: >   - The DOMCTL that update the context: I believe we may need to zero to top bits >   - hypercall continuation (see hypercall_create_continuation) >   - multicall > I'll take a look at it. > For 4.16, the entry (or exit) is probably going to be a good step. We can look at the rest for 4.17. > > Cheers, > Cheers, From xen-devel-bounces@lists.xenproject.org Fri Sep 03 09:39:08 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Sep 2021 09:39:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177962.323764 (Exim 4.92) (envelope-from ) id 1mM5ey-0000Dn-35; Fri, 03 Sep 2021 09:38:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177962.323764; Fri, 03 Sep 2021 09:38:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mM5ex-0000Dg-Uc; Fri, 03 Sep 2021 09:38:55 +0000 Received: by outflank-mailman (input) for mailman id 177962; Fri, 03 Sep 2021 09:38:54 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mM5ew-0000DV-JS for xen-devel@lists.xen.org; Fri, 03 Sep 2021 09:38:54 +0000 Received: from mail-wr1-x429.google.com (unknown [2a00:1450:4864:20::429]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id b0ad83b8-e1a1-4018-b8eb-222b928869fe; Fri, 03 Sep 2021 09:38:52 +0000 (UTC) Received: by mail-wr1-x429.google.com with SMTP id q14so7320267wrp.3 for ; Fri, 03 Sep 2021 02:38:52 -0700 (PDT) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id g143sm3863966wme.16.2021.09.03.02.38.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Sep 2021 02:38:50 -0700 (PDT) Received: from zen (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id D1CFC1FF96; Fri, 3 Sep 2021 10:38:49 +0100 (BST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b0ad83b8-e1a1-4018-b8eb-222b928869fe DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=references:user-agent:from:to:cc:subject:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=eglj5ZpXfutr/eGVG8JtkghmoUPw+XxKGQoeUjdoPlo=; b=oYPdVmnHy4majCVmnTP+1CNbmbzW79nSLoTQ13OnPEJvgKek/h2Gi7AnN9hoFNGDJ+ 9oRio4Ppmw1h+mbh1Gaf7tAb7az0AGMNUsV10jA5po4tKmjRAm17aMCgxJjfccEn2hp3 3Tsue8DDRoaE+1qJyZMoPdN9RpbX7ZKGM29rOcRYIGOR40wndTr9e6Mj0sippnBAKLA1 hXmu02EkfOzX4jKVD7Aha6jbZIMl/QYGJtjJmORg59pL5uN+MV/fqh55driLyzThWsdi yfVj7UNlDTtg+5btsSE4yRhA6yb0Q4jY73uiT/bo+KloDFU/IePiG4YYh62qRBQUG/Ou njiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject:date :in-reply-to:message-id:mime-version:content-transfer-encoding; bh=eglj5ZpXfutr/eGVG8JtkghmoUPw+XxKGQoeUjdoPlo=; b=E1EMoo2bCvxxNlYLMh6KH+mziJhtd07q9Jt00KFQj5dyL2uz6eU2sYuifG0qQGkFes QkQssVnoEtl63hk+RvxJeNi2H/UwPzfbQwidLKUGjqzEu6ZJh2AHi2cvEoguQ67qLpVy Gtgjq93vg6ph3HGlVIkL0Q3yONBjBqtoafW6y4C/kz2F6C6oP37NPyRtp5wU/9bZilkL ySgC7Z+7LRIAOZL4ujnDODyWXRAnBvZQ2KjlrIifXsMY9OpShU/LEesRfdS4xLKBDQh0 DmDRcWzNmT9QqYdYD1M6ILo5eIm8vNgQ7Iyt0KeE6BA3yGhKQeArmO6DfRKAcuNFMrRW 9F7g== X-Gm-Message-State: AOAM532Mn0+OK+1BaOhRB1597jN4K7IgYaQZK7xSicnIScJ/O752duPt tVJ4DcFO5RbClQ+btCXafJtLRQ== X-Google-Smtp-Source: ABdhPJx6NdsYfccjIXK3bpXfNCSBcf1+do70OI6kBYhG6UJu6Ret7BmqXZyyO/01ILiNCDYEWnYxTw== X-Received: by 2002:adf:eb02:: with SMTP id s2mr3012989wrn.294.1630661931736; Fri, 03 Sep 2021 02:38:51 -0700 (PDT) References: <87v94ldrqq.fsf@linaro.org> <875yvkh1p1.fsf@linaro.org> <20210903080609.GD47953@laputa> User-agent: mu4e 1.7.0; emacs 28.0.50 From: Alex =?utf-8?Q?Benn=C3=A9e?= To: AKASHI Takahiro Cc: Stefan Hajnoczi , Stefano Stabellini , Stratos Mailing List , virtio-dev@lists.oasis-open.org, Arnd Bergmann , Viresh Kumar , Stefano Stabellini , Jan Kiszka , Carl van Schaik , pratikp@quicinc.com, Srivatsa Vaddagiri , Jean-Philippe Brucker , Mathieu Poirier , Wei.Chen@arm.com, olekstysh@gmail.com, Oleksandr_Tyshchenko@epam.com, Bertrand.Marquis@arm.com, Artem_Mygaiev@epam.com, julien@xen.org, jgross@suse.com, paul@xen.org, xen-devel@lists.xen.org, Elena Afanasova Subject: Re: Enabling hypervisor agnosticism for VirtIO backends Date: Fri, 03 Sep 2021 10:28:06 +0100 In-reply-to: <20210903080609.GD47953@laputa> Message-ID: <87czpqq9qu.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable AKASHI Takahiro writes: > Alex, > > On Wed, Sep 01, 2021 at 01:53:34PM +0100, Alex Benn??e wrote: >>=20 >> Stefan Hajnoczi writes: >>=20 >> > [[PGP Signed Part:Undecided]] >> > On Wed, Aug 04, 2021 at 12:20:01PM -0700, Stefano Stabellini wrote: >> >> > Could we consider the kernel internally converting IOREQ messages f= rom >> >> > the Xen hypervisor to eventfd events? Would this scale with other k= ernel >> >> > hypercall interfaces? >> >> >=20 >> >> > So any thoughts on what directions are worth experimenting with? >> >>=20=20 >> >> One option we should consider is for each backend to connect to Xen v= ia >> >> the IOREQ interface. We could generalize the IOREQ interface and make= it >> >> hypervisor agnostic. The interface is really trivial and easy to add. >> >> The only Xen-specific part is the notification mechanism, which is an >> >> event channel. If we replaced the event channel with something else t= he >> >> interface would be generic. See: >> >> https://gitlab.com/xen-project/xen/-/blob/staging/xen/include/public/= hvm/ioreq.h#L52 >> > >> > There have been experiments with something kind of similar in KVM >> > recently (see struct ioregionfd_cmd): >> > https://lore.kernel.org/kvm/dad3d025bcf15ece11d9df0ff685e8ab0a4f2edd.1= 613828727.git.eafanasova@gmail.com/ >>=20 >> Reading the cover letter was very useful in showing how this provides a >> separate channel for signalling IO events to userspace instead of using >> the normal type-2 vmexit type event. I wonder how deeply tied the >> userspace facing side of this is to KVM? Could it provide a common FD >> type interface to IOREQ? > > Why do you stick to a "FD" type interface? I mean most user space interfaces on POSIX start with a file descriptor and the usual read/write semantics or a series of ioctls. >> As I understand IOREQ this is currently a direct communication between >> userspace and the hypervisor using the existing Xen message bus. My > > With IOREQ server, IO event occurrences are notified to BE via Xen's event > channel, while the actual contexts of IO events (see struct ioreq in iore= q.h) > are put in a queue on a single shared memory page which is to be assigned > beforehand with xenforeignmemory_map_resource hypervisor call. If we abstracted the IOREQ via the kernel interface you would probably just want to put the ioreq structure on a queue rather than expose the shared page to userspace.=20 >> worry would be that by adding knowledge of what the underlying >> hypervisor is we'd end up with excess complexity in the kernel. For one >> thing we certainly wouldn't want an API version dependency on the kernel >> to understand which version of the Xen hypervisor it was running on. > > That's exactly what virtio-proxy in my proposal[1] does; All the hypervis= or- > specific details of IO event handlings are contained in virtio-proxy > and virtio BE will communicate with virtio-proxy through a virtqueue > (yes, virtio-proxy is seen as yet another virtio device on BE) and will > get IO event-related *RPC* callbacks, either MMIO read or write, from > virtio-proxy. > > See page 8 (protocol flow) and 10 (interfaces) in [1]. There are two areas of concern with the proxy approach at the moment. The first is how the bootstrap of the virtio-proxy channel happens and the second is how many context switches are involved in a transaction. Of course with all things there is a trade off. Things involving the very tightest latency would probably opt for a bare metal backend which I think would imply hypervisor knowledge in the backend binary. > > If kvm's ioregionfd can fit into this protocol, virtio-proxy for kvm > will hopefully be implemented using ioregionfd. > > -Takahiro Akashi > > [1] https://op-lists.linaro.org/pipermail/stratos-dev/2021-August/000548.= html --=20 Alex Benn=C3=A9e From xen-devel-bounces@lists.xenproject.org Fri Sep 03 10:08:47 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Sep 2021 10:08:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177969.323775 (Exim 4.92) (envelope-from ) id 1mM67i-0004D4-Ed; Fri, 03 Sep 2021 10:08:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177969.323775; Fri, 03 Sep 2021 10:08:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mM67i-0004Cx-BO; Fri, 03 Sep 2021 10:08:38 +0000 Received: by outflank-mailman (input) for mailman id 177969; Fri, 03 Sep 2021 10:08:36 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mM67g-0004Cr-Lf for xen-devel@lists.xenproject.org; Fri, 03 Sep 2021 10:08:36 +0000 Received: from mail-ej1-x632.google.com (unknown [2a00:1450:4864:20::632]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id c434e2e5-586f-42b8-82f7-85921841c2e5; Fri, 03 Sep 2021 10:08:35 +0000 (UTC) Received: by mail-ej1-x632.google.com with SMTP id t19so10998324ejr.8 for ; Fri, 03 Sep 2021 03:08:35 -0700 (PDT) Received: from a2klaptop.epam.com (host-176-36-245-220.b024.la.net.ua. [176.36.245.220]) by smtp.gmail.com with ESMTPSA id p5sm2427187eju.30.2021.09.03.03.08.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Sep 2021 03:08:33 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c434e2e5-586f-42b8-82f7-85921841c2e5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=7H6Dr6JQKVJd8ZBAOuYHiT1TMijPI9lm94ml0YNkOmU=; b=IBD98SZW9KZZal7dGGuQAEjAduRLEntYcTgOwxwpzaCsJOYStXf09lvZqoqv3d00TR kCiLhDiAKTv4BvLyvjQAIiHzEK/9xxhTGDZbLRLt0sn98m8dMbHTU+GQn5lvI5/sLVUO crCsf6SVRQVa6+1N1/iKw773pDWJO4WSYgvK/Kcfu2dHXevb5j6eMvVAnZ+JAcdDIC3r ZVwlrmkcCshjGiXAg8qINGcNFhxs788QTSSDGBKd9SMDNDL4vGxhHpL6MJMae7Alv6EB agjJfky004dG/SytKYYnXdlBRFNi2AO3cE4bkyfEdYx52MuCc4X2olG0TMBXo/dBNjWU LnXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=7H6Dr6JQKVJd8ZBAOuYHiT1TMijPI9lm94ml0YNkOmU=; b=JeFqIWH9GmpRccQUxSACtUw6gkbPUqcU9JHX2DQVEx5/jiIEjs3a1yw7vVJQ5aaD0J aTPS8kWMtTz24xXfKmsHAT/O3haTliNVTZcWlcu+Zlr4mcjVBGn8ztWQ+zvB+kNFZF3d 9JABiNWBZj785GgHPXXwdHvn0pEU3pk4updKNGDWLEt1c77nnOx393/e3oEtGlhpDFcP aN+6Rg4eZc04Unci4bRyg+oNfz5WGuUUqBA2zijYvN7AxVLZH5jaEXukWSf+QF8mhh7K Ly2n3N3NuFXU0nnv1kFXRwyax2suM6In4+P6uFeoGDW3fAisZ9cQj2/bgIcATTo1i91i ffTQ== X-Gm-Message-State: AOAM533M3ZqklRruXCykiLG4TaLH1E8juc8FXw1WlD0LGTWb+YeCOxLP OLCSmFNDNlzTGWidf4/0403xeNv8D80= X-Google-Smtp-Source: ABdhPJw6mI/4aI/4ceFyYh6bdRsh+uhWebon0bgMPdhmq94GIcgA6dYEPZWF11K+3koGJZRrPc0/OQ== X-Received: by 2002:a17:906:2f15:: with SMTP id v21mr3286141eji.444.1630663714345; Fri, 03 Sep 2021 03:08:34 -0700 (PDT) From: Oleksandr Andrushchenko To: xen-devel@lists.xenproject.org Cc: julien@xen.org, sstabellini@kernel.org, oleksandr_tyshchenko@epam.com, volodymyr_babchuk@epam.com, Artem_Mygaiev@epam.com, roger.pau@citrix.com, jbeulich@suse.com, bertrand.marquis@arm.com, rahul.singh@arm.com, Oleksandr Andrushchenko Subject: [PATCH 0/9] PCI devices passthrough on Arm, part 3 Date: Fri, 3 Sep 2021 13:08:22 +0300 Message-Id: <20210903100831.177748-1-andr2000@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Oleksandr Andrushchenko Hi, all! This patch series is focusing on vPCI and adds support for non-identity PCI BAR mappings which is required while passing through a PCI device to a guest. The highlights are: - Add relevant vpci register handlers when assigning PCI device to a domain and remove those when de-assigning. This allows having different handlers for different domains, e.g. hwdom and other guests. - Emulate guest BAR register values based on physical BAR values. This allows creating a guest view of the registers and emulates size and properties probe as it is done during PCI device enumeration by the guest. - Instead of handling a single range set, that contains all the memory regions of all the BARs and ROM, have them per BAR. - Take into account guest's BAR view and program its p2m accordingly: gfn is guest's view of the BAR and mfn is the physical BAR value as set up by the host bridge in the hardware domain. This way hardware doamin sees physical BAR values and guest sees emulated ones. The series was also tested on x86 PVH Dom0 and doesn't break it. Thank you, Oleksandr Oleksandr Andrushchenko (8): vpci: Make vpci registers removal a dedicated function vpci: Add hooks for PCI device assign/de-assign vpci/header: Move register assignments from init_bars vpci/header: Add and remove register handlers dynamically vpci/header: Implement guest BAR register handlers vpci/header: Handle p2m range sets per BAR vpci/header: program p2m with guest BAR view vpci/header: Reset the command register when adding devices Rahul Singh (1): vpci/header: Use pdev's domain instead of vCPU xen/drivers/passthrough/pci.c | 9 + xen/drivers/vpci/header.c | 431 +++++++++++++++++++++++++++------- xen/drivers/vpci/vpci.c | 28 ++- xen/include/xen/pci_regs.h | 1 + xen/include/xen/vpci.h | 28 ++- 5 files changed, 413 insertions(+), 84 deletions(-) -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Sep 03 10:08:47 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Sep 2021 10:08:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177970.323786 (Exim 4.92) (envelope-from ) id 1mM67m-0004U7-QR; Fri, 03 Sep 2021 10:08:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177970.323786; Fri, 03 Sep 2021 10:08:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mM67m-0004U0-My; Fri, 03 Sep 2021 10:08:42 +0000 Received: by outflank-mailman (input) for mailman id 177970; Fri, 03 Sep 2021 10:08:41 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mM67l-0004Cr-9V for xen-devel@lists.xenproject.org; Fri, 03 Sep 2021 10:08:41 +0000 Received: from mail-ej1-x62d.google.com (unknown [2a00:1450:4864:20::62d]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id a207c60b-2f84-4a2e-8c87-e4da339ca8fd; Fri, 03 Sep 2021 10:08:36 +0000 (UTC) Received: by mail-ej1-x62d.google.com with SMTP id mf2so10990326ejb.9 for ; Fri, 03 Sep 2021 03:08:36 -0700 (PDT) Received: from a2klaptop.epam.com (host-176-36-245-220.b024.la.net.ua. [176.36.245.220]) by smtp.gmail.com with ESMTPSA id p5sm2427187eju.30.2021.09.03.03.08.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Sep 2021 03:08:35 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a207c60b-2f84-4a2e-8c87-e4da339ca8fd DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ZadtWS/HmdzZ6ZB6hMvTOb7/437UPtLCPee6STSCqfE=; b=YhHIT73vy+PVxx26h1vPYEo5XBj3ro3OZ8ijz9+VhFJjzLOVDwpyT4NP5euCOnWr6F sXNIdIdwveV+4JJNloPws1E3n6Qi3ChdN9OgIrXxwDb3quCHFdbymal/0yvXMNj9eLKy rpvYV/4QQUS3mNCN08ose74UFLipgvvzzaThClvTPt6m8yytTwArmYRLrDbwUdlCjlwa Us4A/LRhlNmNfGnBUb+ygPZcwZ46eX0hpKznDPYPRaQBm59/7pFQJhV/aYIUkAeTNmGW YCjjIQo1QPg+2ZCq+OnF2tXhNd9qFuj+CzZ8qJS8zb8SFxw36Od7qiX+H7XIm3NLw3Pg JKjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ZadtWS/HmdzZ6ZB6hMvTOb7/437UPtLCPee6STSCqfE=; b=Uey5oSbYIwQXHH9NMZKn+7cI48afypAEdjXa55LJy1A+9R4MKMFUl49TIEpRjNybEB 13dtLALW21QIbsUBSq6WP1+gdfH3xLAKEV91ac/4OTv8HAiIpIg8TdXFNfcVyUP3iJic L63ds6uBWA3us0EY5o13sTUHj2DhQ0aZYPqDrylJqHO5A2cvntCJr+jYVCxcxs1fBnsy pTIUve6hfQIyPMNxP46vNTsYQZ4SixRVfuft2/YPEa1Oxsmt6rVFFIPIa2Uc6zeB+9/K +q0ig0nEPa2PYN6/vNRpqE/7Abwmo5hbDgrAZCYolMxnVPxLoPDHE+0V1sl8Adn15pkn QV1Q== X-Gm-Message-State: AOAM532yciggjHHlrkznHx4PQ140XKp6WbKSxiBfvBZDLj0Rv2g3sSnQ o7Nccq1vwXUrcAfJJz9Gr//naxT4rws= X-Google-Smtp-Source: ABdhPJwgZPoQj1ss4jKZJbBH8b+YlK07Jv0KEwHZKKBxDLUyLP9WFuc8uyLUXAIwk7Pj5zBg8EBp3Q== X-Received: by 2002:a17:907:362:: with SMTP id rs2mr3352436ejb.17.1630663715405; Fri, 03 Sep 2021 03:08:35 -0700 (PDT) From: Oleksandr Andrushchenko To: xen-devel@lists.xenproject.org Cc: julien@xen.org, sstabellini@kernel.org, oleksandr_tyshchenko@epam.com, volodymyr_babchuk@epam.com, Artem_Mygaiev@epam.com, roger.pau@citrix.com, jbeulich@suse.com, bertrand.marquis@arm.com, rahul.singh@arm.com, Oleksandr Andrushchenko Subject: [PATCH 1/9] vpci: Make vpci registers removal a dedicated function Date: Fri, 3 Sep 2021 13:08:23 +0300 Message-Id: <20210903100831.177748-2-andr2000@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210903100831.177748-1-andr2000@gmail.com> References: <20210903100831.177748-1-andr2000@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Oleksandr Andrushchenko This is in preparation for dynamic assignment of the vpci register handlers depending on the domain: hwdom or guest. Signed-off-by: Oleksandr Andrushchenko --- xen/drivers/vpci/vpci.c | 7 ++++++- xen/include/xen/vpci.h | 2 ++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/xen/drivers/vpci/vpci.c b/xen/drivers/vpci/vpci.c index cbd1bac7fc33..b05530f2a6b0 100644 --- a/xen/drivers/vpci/vpci.c +++ b/xen/drivers/vpci/vpci.c @@ -35,7 +35,7 @@ extern vpci_register_init_t *const __start_vpci_array[]; extern vpci_register_init_t *const __end_vpci_array[]; #define NUM_VPCI_INIT (__end_vpci_array - __start_vpci_array) -void vpci_remove_device(struct pci_dev *pdev) +void vpci_remove_device_registers(struct pci_dev *pdev) { spin_lock(&pdev->vpci->lock); while ( !list_empty(&pdev->vpci->handlers) ) @@ -48,6 +48,11 @@ void vpci_remove_device(struct pci_dev *pdev) xfree(r); } spin_unlock(&pdev->vpci->lock); +} + +void vpci_remove_device(struct pci_dev *pdev) +{ + vpci_remove_device_registers(pdev); xfree(pdev->vpci->msix); xfree(pdev->vpci->msi); xfree(pdev->vpci); diff --git a/xen/include/xen/vpci.h b/xen/include/xen/vpci.h index 9f5b5d52e159..b861f438cc78 100644 --- a/xen/include/xen/vpci.h +++ b/xen/include/xen/vpci.h @@ -28,6 +28,8 @@ int __must_check vpci_add_handlers(struct pci_dev *dev); /* Remove all handlers and free vpci related structures. */ void vpci_remove_device(struct pci_dev *pdev); +/* Remove all handlers for the device given. */ +void vpci_remove_device_registers(struct pci_dev *pdev); /* Add/remove a register handler. */ int __must_check vpci_add_register(struct vpci *vpci, -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Sep 03 10:08:48 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Sep 2021 10:08:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177971.323797 (Exim 4.92) (envelope-from ) id 1mM67s-0004p1-3u; Fri, 03 Sep 2021 10:08:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177971.323797; Fri, 03 Sep 2021 10:08:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mM67r-0004oq-VO; Fri, 03 Sep 2021 10:08:47 +0000 Received: by outflank-mailman (input) for mailman id 177971; Fri, 03 Sep 2021 10:08:46 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mM67q-0004Cr-9p for xen-devel@lists.xenproject.org; Fri, 03 Sep 2021 10:08:46 +0000 Received: from mail-ej1-x62b.google.com (unknown [2a00:1450:4864:20::62b]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id f91edf82-e50f-4cf4-995d-7339dd9df84b; Fri, 03 Sep 2021 10:08:37 +0000 (UTC) Received: by mail-ej1-x62b.google.com with SMTP id ia27so10983815ejc.10 for ; Fri, 03 Sep 2021 03:08:37 -0700 (PDT) Received: from a2klaptop.epam.com (host-176-36-245-220.b024.la.net.ua. [176.36.245.220]) by smtp.gmail.com with ESMTPSA id p5sm2427187eju.30.2021.09.03.03.08.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Sep 2021 03:08:36 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f91edf82-e50f-4cf4-995d-7339dd9df84b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=EU6daQfIrHKFvAQi2eWLYJvBvTorOIHCZnBp6xeFP3g=; b=kcubAD1Yrxu5RXJEbu7bj0a07h2QblbRY+s8jSOmtT8ZkdpKKBQGCcX5WvzOVQxHbS 55eUezgwX9I0TbSWL9LToo0uUqvkN+I7fJZOt84M2creBFDahhPC94vgaafd+kHnigfs DNKtTUFK6Ibxfig4mz9B0SfhATEmqOExjB0cc+qPmEFCZiEZYlKxAY62tn4K5XHA2bm4 DluMJoVFnrYQN3CvNURCZGzNvdnDc+48eMedOJKcKFfHLc/He6w52N5HxvkUmrxcolud 3u9lfiOIhIVkADvUQQalsSwaH9feuKeguOXZ9unsAMQA/IpxrwZ8GvEpMu1xiLdcXTVR oSUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=EU6daQfIrHKFvAQi2eWLYJvBvTorOIHCZnBp6xeFP3g=; b=idmU1+ovw6G5NrPkYssghrV2ChJh/LzPdwy3MG/ApEHrp5GoaavT+I5dNB60eSTktN HgWdygLn0apuTFRpUQpgLekox//f5VAGdeXKMigSq+atohC+MCeABhOcuKlCxi6UV3vr QYfBbn38/lB4r+arfq2OEJMJs3Livvfkgw1CZS6JIvZ8s8FWkaGuQTFhGQBtZuy7ClYT pmDLsu9mHGLUfcG2EYPwmQ+V7kYXqThdbxAtX8MaoTRBAdM4lkzhDqa1HtHdEcN35t97 Oleps0lYHqraC5hK8s3XUf/ZV0JXBRG+goSNiWJu6/SHn/izJln78+dkVr8J7akP0fuS voRQ== X-Gm-Message-State: AOAM531Ff1UH+vuQfiIvWYw/6W2PNoubK9ygdflTG4Or7V5FEJMBi9S/ Psl+wxbjX9KG29GVb75XzcQJgSln75o= X-Google-Smtp-Source: ABdhPJz6mPKOr3Bp3qDr/3iV61C9/zLAySQ2YnRt9O7RgvETUrpMoCcyTRoUbjFWHZd9dkA+8OI+fA== X-Received: by 2002:a17:906:1c8c:: with SMTP id g12mr3370387ejh.186.1630663716639; Fri, 03 Sep 2021 03:08:36 -0700 (PDT) From: Oleksandr Andrushchenko To: xen-devel@lists.xenproject.org Cc: julien@xen.org, sstabellini@kernel.org, oleksandr_tyshchenko@epam.com, volodymyr_babchuk@epam.com, Artem_Mygaiev@epam.com, roger.pau@citrix.com, jbeulich@suse.com, bertrand.marquis@arm.com, rahul.singh@arm.com, Oleksandr Andrushchenko Subject: [PATCH 2/9] vpci: Add hooks for PCI device assign/de-assign Date: Fri, 3 Sep 2021 13:08:24 +0300 Message-Id: <20210903100831.177748-3-andr2000@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210903100831.177748-1-andr2000@gmail.com> References: <20210903100831.177748-1-andr2000@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Oleksandr Andrushchenko When a PCI device gets assigned/de-assigned some work on vPCI side needs to be done for that device. Introduce a pair of hooks so vPCI can handle that. Signed-off-by: Oleksandr Andrushchenko --- xen/drivers/passthrough/pci.c | 9 +++++++++ xen/drivers/vpci/vpci.c | 21 +++++++++++++++++++++ xen/include/xen/vpci.h | 16 ++++++++++++++++ 3 files changed, 46 insertions(+) diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.c index 25304dbe9956..deef986acbb4 100644 --- a/xen/drivers/passthrough/pci.c +++ b/xen/drivers/passthrough/pci.c @@ -864,6 +864,10 @@ static int deassign_device(struct domain *d, uint16_t seg, uint8_t bus, if ( ret ) goto out; + ret = vpci_deassign_device(d, pdev); + if ( ret ) + goto out; + if ( pdev->domain == hardware_domain ) pdev->quarantine = false; @@ -1425,6 +1429,11 @@ static int assign_device(struct domain *d, u16 seg, u8 bus, u8 devfn, u32 flag) rc = hd->platform_ops->assign_device(d, devfn, pci_to_dev(pdev), flag); } + if ( rc ) + goto done; + + rc = vpci_assign_device(d, pdev); + done: if ( rc ) printk(XENLOG_G_WARNING "%pd: assign (%pp) failed (%d)\n", diff --git a/xen/drivers/vpci/vpci.c b/xen/drivers/vpci/vpci.c index b05530f2a6b0..ee0ad63a3c12 100644 --- a/xen/drivers/vpci/vpci.c +++ b/xen/drivers/vpci/vpci.c @@ -86,6 +86,27 @@ int __hwdom_init vpci_add_handlers(struct pci_dev *pdev) return rc; } + +/* Notify vPCI that device is assigned to guest. */ +int vpci_assign_device(struct domain *d, struct pci_dev *dev) +{ + /* It only makes sense to assign for hwdom or guest domain. */ + if ( !has_vpci(d) || (d->domain_id >= DOMID_FIRST_RESERVED) ) + return 0; + + return 0; +} + +/* Notify vPCI that device is de-assigned from guest. */ +int vpci_deassign_device(struct domain *d, struct pci_dev *dev) +{ + /* It only makes sense to de-assign from hwdom or guest domain. */ + if ( !has_vpci(d) || (d->domain_id >= DOMID_FIRST_RESERVED) ) + return 0; + + return 0; +} + #endif /* __XEN__ */ static int vpci_register_cmp(const struct vpci_register *r1, diff --git a/xen/include/xen/vpci.h b/xen/include/xen/vpci.h index b861f438cc78..e7a1a09ab4c9 100644 --- a/xen/include/xen/vpci.h +++ b/xen/include/xen/vpci.h @@ -26,6 +26,12 @@ typedef int vpci_register_init_t(struct pci_dev *dev); /* Add vPCI handlers to device. */ int __must_check vpci_add_handlers(struct pci_dev *dev); +/* Notify vPCI that device is assigned to guest. */ +int __must_check vpci_assign_device(struct domain *d, struct pci_dev *dev); + +/* Notify vPCI that device is de-assigned from guest. */ +int __must_check vpci_deassign_device(struct domain *d, struct pci_dev *dev); + /* Remove all handlers and free vpci related structures. */ void vpci_remove_device(struct pci_dev *pdev); /* Remove all handlers for the device given. */ @@ -220,6 +226,16 @@ static inline int vpci_add_handlers(struct pci_dev *pdev) return 0; } +static inline int vpci_assign_device(struct domain *d, struct pci_dev *dev) +{ + return 0; +}; + +static inline int vpci_deassign_device(struct domain *d, struct pci_dev *dev) +{ + return 0; +}; + static inline void vpci_dump_msi(void) { } static inline uint32_t vpci_read(pci_sbdf_t sbdf, unsigned int reg, -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Sep 03 10:08:53 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Sep 2021 10:08:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177972.323808 (Exim 4.92) (envelope-from ) id 1mM67x-0005DG-De; Fri, 03 Sep 2021 10:08:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177972.323808; Fri, 03 Sep 2021 10:08:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mM67x-0005D5-9t; Fri, 03 Sep 2021 10:08:53 +0000 Received: by outflank-mailman (input) for mailman id 177972; Fri, 03 Sep 2021 10:08:51 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mM67v-0004Cr-9x for xen-devel@lists.xenproject.org; Fri, 03 Sep 2021 10:08:51 +0000 Received: from mail-ej1-x635.google.com (unknown [2a00:1450:4864:20::635]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 89cdb7c8-25df-49a2-9db1-259e6a8e8cb4; Fri, 03 Sep 2021 10:08:38 +0000 (UTC) Received: by mail-ej1-x635.google.com with SMTP id me10so10971791ejb.11 for ; Fri, 03 Sep 2021 03:08:38 -0700 (PDT) Received: from a2klaptop.epam.com (host-176-36-245-220.b024.la.net.ua. [176.36.245.220]) by smtp.gmail.com with ESMTPSA id p5sm2427187eju.30.2021.09.03.03.08.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Sep 2021 03:08:37 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 89cdb7c8-25df-49a2-9db1-259e6a8e8cb4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=3lxrhjHMCKgFgAktbulKfLSKY9SXLgEbqYmkCK+IHbI=; b=Cv6kNVKYxIEVmbcaX8DIKNQHN8wBj6cryOD0sKuPJKv/+o8YHRTdPVgVqD77l1hCb6 vatzSz/C6yHUi7ZQZQ1JJlU9uCyOpq+GVxJBb9jeFDqhIQnX1cbkCtJinWZEU8eqJTQb jio/WmVPkE2k/zzaVXS7GL4dFAA2E0ouwzXpQCTsyFf2pUaDlvQFEaS78sYbu8YIPTXR U0FzaEvsPtV9sf174mXGL7Qw5/UuezecIBC+kpvG2EDzz17a/p2ZqvM6XZnGtCvqk3aL JIFwtBwu3xMljkBTPCWgfBV3fdb37XBeKMLOsqDZpBQznPnsEXb1R1MSjDFX+LUX9qeG nioA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=3lxrhjHMCKgFgAktbulKfLSKY9SXLgEbqYmkCK+IHbI=; b=Ar3aSlPCK0GtA4sCgxbYDimL2lZEujfGD2CTEiPA4eS5hh2KiOr+ahOg/9X58VTFh+ v5lR3rXR1PGqZBPlv6NyAtoXOKwDm/GlvPQORD1cv9rpQng+6BEL/CrL/tjQaIaeOsLx RvUcwQiWdrc86goE79/rqqttWHovaGPNXawkzszYlLSZkzIyloeq+35lhBDgKREonL2E HY7eWCxYx2OJ1YAx3K2dVxroEccnwMuJyEQNYtGy25KnLRTzVJxrF6wWVINKeRkfq28i zk5netoP+L1mM+0e/Z1PeN9DzxSn+js6BPlupxFg73mQJCkXFXuJlL5oMNeuWRUsOoh5 FBug== X-Gm-Message-State: AOAM531FhXhUDauNFwiRD38UU1Lwv98u1OTOwNGaZvrk9+LAgVT1XWyj NZgM9J3TcaXszgvC0eIpF50lRxd6098= X-Google-Smtp-Source: ABdhPJydxNWuh4lL4oZ/Fi+pB8Xp26xfg9TIMj2hvhsDyPP/rb6TmJbYwxmJmWH3EGwe4uJeauyAdQ== X-Received: by 2002:a17:906:ff41:: with SMTP id zo1mr3148886ejb.525.1630663717693; Fri, 03 Sep 2021 03:08:37 -0700 (PDT) From: Oleksandr Andrushchenko To: xen-devel@lists.xenproject.org Cc: julien@xen.org, sstabellini@kernel.org, oleksandr_tyshchenko@epam.com, volodymyr_babchuk@epam.com, Artem_Mygaiev@epam.com, roger.pau@citrix.com, jbeulich@suse.com, bertrand.marquis@arm.com, rahul.singh@arm.com, Oleksandr Andrushchenko Subject: [PATCH 3/9] vpci/header: Move register assignments from init_bars Date: Fri, 3 Sep 2021 13:08:25 +0300 Message-Id: <20210903100831.177748-4-andr2000@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210903100831.177748-1-andr2000@gmail.com> References: <20210903100831.177748-1-andr2000@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Oleksandr Andrushchenko This is in preparation for dynamic assignment of the vpci register handlers depending on the domain: hwdom or guest. Signed-off-by: Oleksandr Andrushchenko --- xen/drivers/vpci/header.c | 83 ++++++++++++++++++++++++++------------- 1 file changed, 56 insertions(+), 27 deletions(-) diff --git a/xen/drivers/vpci/header.c b/xen/drivers/vpci/header.c index f8cd55e7c024..31bca7a12942 100644 --- a/xen/drivers/vpci/header.c +++ b/xen/drivers/vpci/header.c @@ -445,6 +445,55 @@ static void rom_write(const struct pci_dev *pdev, unsigned int reg, rom->addr = val & PCI_ROM_ADDRESS_MASK; } +static int add_bar_handlers(struct pci_dev *pdev) +{ + unsigned int i; + struct vpci_header *header = &pdev->vpci->header; + struct vpci_bar *bars = header->bars; + int rc; + + /* Setup a handler for the command register. */ + rc = vpci_add_register(pdev->vpci, vpci_hw_read16, cmd_write, PCI_COMMAND, + 2, header); + if ( rc ) + return rc; + + if ( pdev->ignore_bars ) + return 0; + + for ( i = 0; i < PCI_HEADER_NORMAL_NR_BARS + 1; i++ ) + { + if ( (bars[i].type == VPCI_BAR_IO) || (bars[i].type == VPCI_BAR_EMPTY) ) + continue; + + if ( bars[i].type == VPCI_BAR_ROM ) + { + unsigned int rom_reg; + uint8_t header_type = pci_conf_read8(pdev->sbdf, + PCI_HEADER_TYPE) & 0x7f; + if ( header_type == PCI_HEADER_TYPE_NORMAL ) + rom_reg = PCI_ROM_ADDRESS; + else + rom_reg = PCI_ROM_ADDRESS1; + rc = vpci_add_register(pdev->vpci, vpci_hw_read32, rom_write, + rom_reg, 4, &bars[i]); + if ( rc ) + return rc; + } + else + { + uint8_t reg = PCI_BASE_ADDRESS_0 + i * 4; + + /* This is either VPCI_BAR_MEM32 or VPCI_BAR_MEM64_{LO|HI}. */ + rc = vpci_add_register(pdev->vpci, vpci_hw_read32, bar_write, reg, + 4, &bars[i]); + if ( rc ) + return rc; + } + } + return 0; +} + static int init_bars(struct pci_dev *pdev) { uint16_t cmd; @@ -470,14 +519,8 @@ static int init_bars(struct pci_dev *pdev) return -EOPNOTSUPP; } - /* Setup a handler for the command register. */ - rc = vpci_add_register(pdev->vpci, vpci_hw_read16, cmd_write, PCI_COMMAND, - 2, header); - if ( rc ) - return rc; - if ( pdev->ignore_bars ) - return 0; + return add_bar_handlers(pdev); /* Disable memory decoding before sizing. */ cmd = pci_conf_read16(pdev->sbdf, PCI_COMMAND); @@ -492,14 +535,6 @@ static int init_bars(struct pci_dev *pdev) if ( i && bars[i - 1].type == VPCI_BAR_MEM64_LO ) { bars[i].type = VPCI_BAR_MEM64_HI; - rc = vpci_add_register(pdev->vpci, vpci_hw_read32, bar_write, reg, - 4, &bars[i]); - if ( rc ) - { - pci_conf_write16(pdev->sbdf, PCI_COMMAND, cmd); - return rc; - } - continue; } @@ -532,14 +567,6 @@ static int init_bars(struct pci_dev *pdev) bars[i].addr = addr; bars[i].size = size; bars[i].prefetchable = val & PCI_BASE_ADDRESS_MEM_PREFETCH; - - rc = vpci_add_register(pdev->vpci, vpci_hw_read32, bar_write, reg, 4, - &bars[i]); - if ( rc ) - { - pci_conf_write16(pdev->sbdf, PCI_COMMAND, cmd); - return rc; - } } /* Check expansion ROM. */ @@ -553,11 +580,13 @@ static int init_bars(struct pci_dev *pdev) rom->addr = addr; header->rom_enabled = pci_conf_read32(pdev->sbdf, rom_reg) & PCI_ROM_ADDRESS_ENABLE; + } - rc = vpci_add_register(pdev->vpci, vpci_hw_read32, rom_write, rom_reg, - 4, rom); - if ( rc ) - rom->type = VPCI_BAR_EMPTY; + rc = add_bar_handlers(pdev); + if ( rc ) + { + pci_conf_write16(pdev->sbdf, PCI_COMMAND, cmd); + return rc; } return (cmd & PCI_COMMAND_MEMORY) ? modify_bars(pdev, cmd, false) : 0; -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Sep 03 10:08:57 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Sep 2021 10:08:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177975.323819 (Exim 4.92) (envelope-from ) id 1mM681-0005gd-Ne; Fri, 03 Sep 2021 10:08:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177975.323819; Fri, 03 Sep 2021 10:08:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mM681-0005gQ-Jh; Fri, 03 Sep 2021 10:08:57 +0000 Received: by outflank-mailman (input) for mailman id 177975; Fri, 03 Sep 2021 10:08:56 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mM680-0004Cr-AA for xen-devel@lists.xenproject.org; Fri, 03 Sep 2021 10:08:56 +0000 Received: from mail-ed1-x533.google.com (unknown [2a00:1450:4864:20::533]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id cfb4143e-4d10-43e8-a103-28cf681063e9; Fri, 03 Sep 2021 10:08:40 +0000 (UTC) Received: by mail-ed1-x533.google.com with SMTP id z19so7227660edi.9 for ; Fri, 03 Sep 2021 03:08:40 -0700 (PDT) Received: from a2klaptop.epam.com (host-176-36-245-220.b024.la.net.ua. [176.36.245.220]) by smtp.gmail.com with ESMTPSA id p5sm2427187eju.30.2021.09.03.03.08.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Sep 2021 03:08:38 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cfb4143e-4d10-43e8-a103-28cf681063e9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=xpLp7pLNUQ/DHxUjEhr/yTY0NKqDW6A0T3pZsizfVtE=; b=aS6tQADQYeExZDhOABC9iBB8GoJc3IuoFCRob+Cctdwhth+nveel2KGxkARVYlU6Jd Qgnsw8axED8hMhxC2pYHQ9oNoSo/Olz1veZ4TZuqbKzQZivPkh6by4D4cHiKbYkHSK91 YRf3tKX+OFy/jc8fvxtX6h9mWPRbWAPECFFsxFE+A6QKglW5XRGmbuMg67a0TGkoDIJw /eSmzbrBWGArGKWd2yxvzNtdGv662yFyuBYuegN1QYkQSgbHkEqDsAUOzpcLfZcumjrq cZ2XfDNZRq17L5VjX+W5pDzGFNH7tT+468gnBCcwp09gPnFouOqA3oPEThxmheEzgx36 8JiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=xpLp7pLNUQ/DHxUjEhr/yTY0NKqDW6A0T3pZsizfVtE=; b=hGnApIAP71TtOCLXUjUKPy4WIrMPkur5k+NPSUeWn7p/Bf8CxvczUWGnlwjKqpPQcP 9Y0eVWNEsj5402YA2Gbn//AJYvDDKoVXzV9QDF/Ps+iNmInd9cB0Cc+SOoFZS8/asqwT tTfsJeeSHJaC2dhpcFjiFNFectWoPuWWPGg0Z7aGKDHciQp/Z5hDb51wcF6vB7kI2N1r o0cFz+f9LWpM7xDisrSAzoVOdv0ooVvwsKGxRdZ2MfEA96Rzwy9NPLeVRX8dmbhQM0j6 ZYj5JkfP2reHEmbEYz3M/2N8AeaN+RpskyCOLs7iDYTcCtetuKAJNg2RtePNh6AlqiEw d1Mw== X-Gm-Message-State: AOAM5334/en9MEUJvPwecu2YmyDa6bOMJinsNafy5DPz5/8RswTn4lXw mt9V6eUOxVENPqJZI0u2GjZF5lc+2Bo= X-Google-Smtp-Source: ABdhPJwZyi4jY7+BYhHRUtcHJ71NsVbFBf7jRjXcdY+sWwfFplhPMgxjOeq7kjOI9krtIeEBDoMxMA== X-Received: by 2002:aa7:da8c:: with SMTP id q12mr3199500eds.380.1630663718806; Fri, 03 Sep 2021 03:08:38 -0700 (PDT) From: Oleksandr Andrushchenko To: xen-devel@lists.xenproject.org Cc: julien@xen.org, sstabellini@kernel.org, oleksandr_tyshchenko@epam.com, volodymyr_babchuk@epam.com, Artem_Mygaiev@epam.com, roger.pau@citrix.com, jbeulich@suse.com, bertrand.marquis@arm.com, rahul.singh@arm.com, Oleksandr Andrushchenko Subject: [PATCH 4/9] vpci/header: Add and remove register handlers dynamically Date: Fri, 3 Sep 2021 13:08:26 +0300 Message-Id: <20210903100831.177748-5-andr2000@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210903100831.177748-1-andr2000@gmail.com> References: <20210903100831.177748-1-andr2000@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Oleksandr Andrushchenko Add relevant vpci register handlers when assigning PCI device to a domain and remove those when de-assigning. This allows having different handlers for different domains, e.g. hwdom and other guests. Use stubs for guest domains for now. Signed-off-by: Oleksandr Andrushchenko --- xen/drivers/vpci/header.c | 78 +++++++++++++++++++++++++++++++++++---- xen/drivers/vpci/vpci.c | 4 +- xen/include/xen/vpci.h | 4 ++ 3 files changed, 76 insertions(+), 10 deletions(-) diff --git a/xen/drivers/vpci/header.c b/xen/drivers/vpci/header.c index 31bca7a12942..5218b1af247e 100644 --- a/xen/drivers/vpci/header.c +++ b/xen/drivers/vpci/header.c @@ -397,6 +397,17 @@ static void bar_write(const struct pci_dev *pdev, unsigned int reg, pci_conf_write32(pdev->sbdf, reg, val); } +static void guest_bar_write(const struct pci_dev *pdev, unsigned int reg, + uint32_t val, void *data) +{ +} + +static uint32_t guest_bar_read(const struct pci_dev *pdev, unsigned int reg, + void *data) +{ + return 0xffffffff; +} + static void rom_write(const struct pci_dev *pdev, unsigned int reg, uint32_t val, void *data) { @@ -445,14 +456,25 @@ static void rom_write(const struct pci_dev *pdev, unsigned int reg, rom->addr = val & PCI_ROM_ADDRESS_MASK; } -static int add_bar_handlers(struct pci_dev *pdev) +static void guest_rom_write(const struct pci_dev *pdev, unsigned int reg, + uint32_t val, void *data) +{ +} + +static uint32_t guest_rom_read(const struct pci_dev *pdev, unsigned int reg, + void *data) +{ + return 0xffffffff; +} + +static int add_bar_handlers(struct pci_dev *pdev, bool is_hwdom) { unsigned int i; struct vpci_header *header = &pdev->vpci->header; struct vpci_bar *bars = header->bars; int rc; - /* Setup a handler for the command register. */ + /* Setup a handler for the command register: same for hwdom and guests. */ rc = vpci_add_register(pdev->vpci, vpci_hw_read16, cmd_write, PCI_COMMAND, 2, header); if ( rc ) @@ -475,8 +497,13 @@ static int add_bar_handlers(struct pci_dev *pdev) rom_reg = PCI_ROM_ADDRESS; else rom_reg = PCI_ROM_ADDRESS1; - rc = vpci_add_register(pdev->vpci, vpci_hw_read32, rom_write, - rom_reg, 4, &bars[i]); + if ( is_hwdom ) + rc = vpci_add_register(pdev->vpci, vpci_hw_read32, rom_write, + rom_reg, 4, &bars[i]); + else + rc = vpci_add_register(pdev->vpci, + guest_rom_read, guest_rom_write, + rom_reg, 4, &bars[i]); if ( rc ) return rc; } @@ -485,8 +512,13 @@ static int add_bar_handlers(struct pci_dev *pdev) uint8_t reg = PCI_BASE_ADDRESS_0 + i * 4; /* This is either VPCI_BAR_MEM32 or VPCI_BAR_MEM64_{LO|HI}. */ - rc = vpci_add_register(pdev->vpci, vpci_hw_read32, bar_write, reg, - 4, &bars[i]); + if ( is_hwdom ) + rc = vpci_add_register(pdev->vpci, vpci_hw_read32, bar_write, + reg, 4, &bars[i]); + else + rc = vpci_add_register(pdev->vpci, + guest_bar_read, guest_bar_write, + reg, 4, &bars[i]); if ( rc ) return rc; } @@ -520,7 +552,7 @@ static int init_bars(struct pci_dev *pdev) } if ( pdev->ignore_bars ) - return add_bar_handlers(pdev); + return add_bar_handlers(pdev, true); /* Disable memory decoding before sizing. */ cmd = pci_conf_read16(pdev->sbdf, PCI_COMMAND); @@ -582,7 +614,7 @@ static int init_bars(struct pci_dev *pdev) PCI_ROM_ADDRESS_ENABLE; } - rc = add_bar_handlers(pdev); + rc = add_bar_handlers(pdev, true); if ( rc ) { pci_conf_write16(pdev->sbdf, PCI_COMMAND, cmd); @@ -593,6 +625,36 @@ static int init_bars(struct pci_dev *pdev) } REGISTER_VPCI_INIT(init_bars, VPCI_PRIORITY_MIDDLE); +int vpci_bar_add_handlers(const struct domain *d, struct pci_dev *pdev) +{ + int rc; + + /* Remove previously added registers. */ + vpci_remove_device_registers(pdev); + + /* It only makes sense to add registers for hwdom or guest domain. */ + if ( d->domain_id >= DOMID_FIRST_RESERVED ) + return 0; + + if ( is_hardware_domain(d) ) + rc = add_bar_handlers(pdev, true); + else + rc = add_bar_handlers(pdev, false); + + if ( rc ) + gprintk(XENLOG_ERR, + "%pp: failed to add BAR handlers for dom%d\n", &pdev->sbdf, + d->domain_id); + return rc; +} + +int vpci_bar_remove_handlers(const struct domain *d, struct pci_dev *pdev) +{ + /* Remove previously added registers. */ + vpci_remove_device_registers(pdev); + return 0; +} + /* * Local variables: * mode: C diff --git a/xen/drivers/vpci/vpci.c b/xen/drivers/vpci/vpci.c index ee0ad63a3c12..4530313f01e7 100644 --- a/xen/drivers/vpci/vpci.c +++ b/xen/drivers/vpci/vpci.c @@ -94,7 +94,7 @@ int vpci_assign_device(struct domain *d, struct pci_dev *dev) if ( !has_vpci(d) || (d->domain_id >= DOMID_FIRST_RESERVED) ) return 0; - return 0; + return vpci_bar_add_handlers(d, dev); } /* Notify vPCI that device is de-assigned from guest. */ @@ -104,7 +104,7 @@ int vpci_deassign_device(struct domain *d, struct pci_dev *dev) if ( !has_vpci(d) || (d->domain_id >= DOMID_FIRST_RESERVED) ) return 0; - return 0; + return vpci_bar_remove_handlers(d, dev); } #endif /* __XEN__ */ diff --git a/xen/include/xen/vpci.h b/xen/include/xen/vpci.h index e7a1a09ab4c9..4aa2941a1081 100644 --- a/xen/include/xen/vpci.h +++ b/xen/include/xen/vpci.h @@ -63,6 +63,10 @@ uint32_t vpci_hw_read32(const struct pci_dev *pdev, unsigned int reg, */ bool __must_check vpci_process_pending(struct vcpu *v); +/* Add/remove BAR handlers for a domain. */ +int vpci_bar_add_handlers(const struct domain *d, struct pci_dev *pdev); +int vpci_bar_remove_handlers(const struct domain *d, struct pci_dev *pdev); + struct vpci { /* List of vPCI handlers for a device. */ struct list_head handlers; -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Sep 03 10:09:02 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Sep 2021 10:09:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177978.323830 (Exim 4.92) (envelope-from ) id 1mM686-0006Ar-8e; Fri, 03 Sep 2021 10:09:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177978.323830; Fri, 03 Sep 2021 10:09:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mM686-0006AD-3I; Fri, 03 Sep 2021 10:09:02 +0000 Received: by outflank-mailman (input) for mailman id 177978; Fri, 03 Sep 2021 10:09:01 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mM685-0004Cr-AL for xen-devel@lists.xenproject.org; Fri, 03 Sep 2021 10:09:01 +0000 Received: from mail-ed1-x535.google.com (unknown [2a00:1450:4864:20::535]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 37d65df0-7563-4c10-bccc-ae1dcb106e2e; Fri, 03 Sep 2021 10:08:40 +0000 (UTC) Received: by mail-ed1-x535.google.com with SMTP id l6so7262298edb.7 for ; Fri, 03 Sep 2021 03:08:40 -0700 (PDT) Received: from a2klaptop.epam.com (host-176-36-245-220.b024.la.net.ua. [176.36.245.220]) by smtp.gmail.com with ESMTPSA id p5sm2427187eju.30.2021.09.03.03.08.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Sep 2021 03:08:39 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 37d65df0-7563-4c10-bccc-ae1dcb106e2e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=s1iI/pfNat4kQKr5zc/XN1JzcSSy61j1M1hI6YBK6Xs=; b=gBoRCW32iLvtnLPg39hDXD7cmyijkqaXRSJbAXbKOPEXyhDl0dgAaIZEz7n/8UZi4w xyP3FtbSUjU/63qIdjQ0mfR/gRCcCNLbo5+ikGBVrFTa2CYIa89ObRAV5x0LVELdz3K0 gMdRG0CMUMNI1PoCqvx9gcF4dXo8MyFy60K9OjUcvHXSWX5viFQP5LDlfcUWYNyGXtIP zNLijBaZRzBMnCN3hJ3eHRipmudvgGiOpZcTXSfGXwt6qisNkUKhee+0WE34G69/e8mr HfTRJZRDqlnW++VApih2L91ZVfsGE+GAThkzBOdxFK99Io93rNBqo/1UlvVCckHjsX+9 O+Wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=s1iI/pfNat4kQKr5zc/XN1JzcSSy61j1M1hI6YBK6Xs=; b=ZH36fSUXi+4e9k9fED+FPhzapioOgKCe7C+6cxPN0UuaFxp4KN4lXQD87Uvbho9dbc ZZx86Su6a9Z8uVYtlcN4+kEjDJCgZ66LjCIPqAbzSjCFy51ucPxamBYSMFI7FJLj8TMS oFcpaTx+5DsPQW5xkXwvU8PHRN9REpyvveUCQtO8eWkMH1qjy05X2+/WO6c4SMpjXVFD zxI/g3d0pl6junt10RLbld6CQNUuUK2yZdwoOe+E11YUqcxfMLjHCIHlway3mXLBNnrk EKO+JALJdLx0ekrKEmzq1zohANVnfEMuKETO5Hrekci6wFI2BUOyMBmsV0fxqJSQNEnb rXUA== X-Gm-Message-State: AOAM5320yZ6ZaDujZgZ7muxVMPZlWCCMjj6PlaSzBYzth8romaK4UiCc VI2SoTl4QY8DO4p+o22aqXANV8JE758= X-Google-Smtp-Source: ABdhPJxrROUzQ4fz2kKiNwMn7jDNiM+KTMqFpM3OJ8BQuHdw/HwgIHYajSQwwLbnO5MBR/YkklXeKg== X-Received: by 2002:a05:6402:424c:: with SMTP id g12mr3162442edb.37.1630663719821; Fri, 03 Sep 2021 03:08:39 -0700 (PDT) From: Oleksandr Andrushchenko To: xen-devel@lists.xenproject.org Cc: julien@xen.org, sstabellini@kernel.org, oleksandr_tyshchenko@epam.com, volodymyr_babchuk@epam.com, Artem_Mygaiev@epam.com, roger.pau@citrix.com, jbeulich@suse.com, bertrand.marquis@arm.com, rahul.singh@arm.com, Oleksandr Andrushchenko Subject: [PATCH 5/9] vpci/header: Implement guest BAR register handlers Date: Fri, 3 Sep 2021 13:08:27 +0300 Message-Id: <20210903100831.177748-6-andr2000@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210903100831.177748-1-andr2000@gmail.com> References: <20210903100831.177748-1-andr2000@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Oleksandr Andrushchenko Emulate guest BAR register values: this allows creating a guest view of the registers and emulates size and properties probe as it is done during PCI device enumeration by the guest. ROM BAR is only handled for the hardware domain and for guest domains there is a stub: at the moment PCI expansion ROM is x86 only, so it might not be used by other architectures without emulating x86. Other use-cases may include using that expansion ROM before Xen boots, hence no emulation is needed in Xen itself. Or when a guest wants to use the ROM code which seems to be rare. Signed-off-by: Oleksandr Andrushchenko --- xen/drivers/vpci/header.c | 69 +++++++++++++++++++++++++++++++++++++- xen/include/xen/pci_regs.h | 1 + xen/include/xen/vpci.h | 3 ++ 3 files changed, 72 insertions(+), 1 deletion(-) diff --git a/xen/drivers/vpci/header.c b/xen/drivers/vpci/header.c index 5218b1af247e..793f79ece831 100644 --- a/xen/drivers/vpci/header.c +++ b/xen/drivers/vpci/header.c @@ -400,12 +400,72 @@ static void bar_write(const struct pci_dev *pdev, unsigned int reg, static void guest_bar_write(const struct pci_dev *pdev, unsigned int reg, uint32_t val, void *data) { + struct vpci_bar *bar = data; + bool hi = false; + + if ( bar->type == VPCI_BAR_MEM64_HI ) + { + ASSERT(reg > PCI_BASE_ADDRESS_0); + bar--; + hi = true; + } + else + val &= PCI_BASE_ADDRESS_MEM_MASK; + bar->guest_addr &= ~(0xffffffffull << (hi ? 32 : 0)); + bar->guest_addr |= (uint64_t)val << (hi ? 32 : 0); } static uint32_t guest_bar_read(const struct pci_dev *pdev, unsigned int reg, void *data) { - return 0xffffffff; + struct vpci_bar *bar = data; + uint32_t val; + bool hi = false; + + switch ( bar->type ) + { + case VPCI_BAR_MEM64_HI: + ASSERT(reg > PCI_BASE_ADDRESS_0); + bar--; + hi = true; + /* fallthrough */ + case VPCI_BAR_MEM64_LO: + { + if ( hi ) + val = bar->guest_addr >> 32; + else + val = bar->guest_addr & 0xffffffff; + if ( (val & PCI_BASE_ADDRESS_MEM_MASK_32) == PCI_BASE_ADDRESS_MEM_MASK_32 ) + { + /* Guests detects BAR's properties and sizes. */ + if ( hi ) + val = bar->size >> 32; + else + val = 0xffffffff & ~(bar->size - 1); + } + if ( !hi ) + { + val |= PCI_BASE_ADDRESS_MEM_TYPE_64; + val |= bar->prefetchable ? PCI_BASE_ADDRESS_MEM_PREFETCH : 0; + } + bar->guest_addr &= ~(0xffffffffull << (hi ? 32 : 0)); + bar->guest_addr |= (uint64_t)val << (hi ? 32 : 0); + break; + } + case VPCI_BAR_MEM32: + { + val = bar->guest_addr; + if ( (val & PCI_BASE_ADDRESS_MEM_MASK_32) == PCI_BASE_ADDRESS_MEM_MASK_32 ) + val = 0xffffffff & ~(bar->size - 1); + val |= PCI_BASE_ADDRESS_MEM_TYPE_32; + val |= bar->prefetchable ? PCI_BASE_ADDRESS_MEM_PREFETCH : 0; + break; + } + default: + val = bar->guest_addr; + break; + } + return val; } static void rom_write(const struct pci_dev *pdev, unsigned int reg, @@ -522,6 +582,13 @@ static int add_bar_handlers(struct pci_dev *pdev, bool is_hwdom) if ( rc ) return rc; } + /* + * It is neither safe nor secure to initialize guest's view of the BARs + * with real values which are used by the hardware domain, so assign + * all zeros to guest's view of the BARs, so the guest can perform + * proper PCI device enumeration and assign BARs on its own. + */ + bars[i].guest_addr = 0; } return 0; } diff --git a/xen/include/xen/pci_regs.h b/xen/include/xen/pci_regs.h index cc4ee3b83e5c..038eb18c5357 100644 --- a/xen/include/xen/pci_regs.h +++ b/xen/include/xen/pci_regs.h @@ -103,6 +103,7 @@ #define PCI_BASE_ADDRESS_MEM_TYPE_64 0x04 /* 64 bit address */ #define PCI_BASE_ADDRESS_MEM_PREFETCH 0x08 /* prefetchable? */ #define PCI_BASE_ADDRESS_MEM_MASK (~0x0fUL) +#define PCI_BASE_ADDRESS_MEM_MASK_32 (~0x0fU) #define PCI_BASE_ADDRESS_IO_MASK (~0x03UL) /* bit 1 is reserved if address_space = 1 */ diff --git a/xen/include/xen/vpci.h b/xen/include/xen/vpci.h index 4aa2941a1081..db86b8e7fa3c 100644 --- a/xen/include/xen/vpci.h +++ b/xen/include/xen/vpci.h @@ -77,7 +77,10 @@ struct vpci { struct vpci_header { /* Information about the PCI BARs of this device. */ struct vpci_bar { + /* Physical view of the BAR. */ uint64_t addr; + /* Guest view of the BAR. */ + uint64_t guest_addr; uint64_t size; enum { VPCI_BAR_EMPTY, -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Sep 03 10:09:07 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Sep 2021 10:09:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177982.323841 (Exim 4.92) (envelope-from ) id 1mM68B-0006or-Lg; Fri, 03 Sep 2021 10:09:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177982.323841; Fri, 03 Sep 2021 10:09:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mM68B-0006od-HV; Fri, 03 Sep 2021 10:09:07 +0000 Received: by outflank-mailman (input) for mailman id 177982; Fri, 03 Sep 2021 10:09:06 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mM68A-0004Cr-Ae for xen-devel@lists.xenproject.org; Fri, 03 Sep 2021 10:09:06 +0000 Received: from mail-ej1-x633.google.com (unknown [2a00:1450:4864:20::633]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 90692ff9-f747-4eed-8a0f-59677580be6d; Fri, 03 Sep 2021 10:08:42 +0000 (UTC) Received: by mail-ej1-x633.google.com with SMTP id a25so11014156ejv.6 for ; Fri, 03 Sep 2021 03:08:42 -0700 (PDT) Received: from a2klaptop.epam.com (host-176-36-245-220.b024.la.net.ua. [176.36.245.220]) by smtp.gmail.com with ESMTPSA id p5sm2427187eju.30.2021.09.03.03.08.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Sep 2021 03:08:40 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 90692ff9-f747-4eed-8a0f-59677580be6d DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=PguLDO+PDisBHZWiq5SMa+3ZkndR3NGesmKLiuatRS8=; b=gvhPjQoucEcq+9aAL21Wr1DWTsBBuSYkSRqt2KCkvaHEiq66AaoEH4VEGm0T6rw7an eNLQMtKsECkxAj541srNzEB+llBTYXQJjMGYBcFjVb7/pNGvYqRgNv42tI5IQJQm63rf oCVEBOpCac6Lbf0xITzzcrfyNtd9pcv5tkjAn5lmD5IZLszS7BGsr2ifeUWBpqzOd4Aq 8NhQxw3gLiIIWNZm1UGUBRrAl+24kJSXnaoRtcC4T59AZnJmalxLd/eSfBP5faMAjwiD tEzMHIJ4CDVHyHqvObg1+rtH46Gc+P/t/PtvGpW1Bds3YAdPHoG13TmR9RNbg+D2kVPZ +PQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=PguLDO+PDisBHZWiq5SMa+3ZkndR3NGesmKLiuatRS8=; b=tSPiQuPMmxsUDFhHlkZ83e/4oPxp4CwtNiMnM4BG0dwQzT/QjwUjq9RHSXdsE4oN6b TJwRwUe5xrRO+fYOxxnryU0Xhf4flVRT/Y42KEhvCnFf29Mv3Oc9uq2u6zqEbRZSUKD7 H4GcNz5ja+bMQgaSSeOYE1UsVMd41V55vXufrVHgPyXSO8nW5vLcNV13MelEKm/RUfrj exwrq75nDzxsYPtfU68V/2K4hJs6w4RpeNfXpSely7PfVLY9ZXeHNukQ5HLOPoWLqcKA dcsT9jAJKx73nG8zLqjSQ8NElrSMrcyczltY/RyYq88mJjW2vH7qt1esatD8rT80YgYz tdsw== X-Gm-Message-State: AOAM533RE6MO9/iDYyOSdcsGsLCM9oRMQuPIHq7jlojE8mv5ZvMiwyCu E4m8LkZBVuXbcMgUqRmTR15VicZvF18= X-Google-Smtp-Source: ABdhPJyl+Tub9JIMSY/l/hoFxplCzEScXDX6jTh8LYN2njGF7bl9ybauJNv5gjjSPitXDu2IPjei+w== X-Received: by 2002:a17:906:4a8e:: with SMTP id x14mr3341520eju.389.1630663720860; Fri, 03 Sep 2021 03:08:40 -0700 (PDT) From: Oleksandr Andrushchenko To: xen-devel@lists.xenproject.org Cc: julien@xen.org, sstabellini@kernel.org, oleksandr_tyshchenko@epam.com, volodymyr_babchuk@epam.com, Artem_Mygaiev@epam.com, roger.pau@citrix.com, jbeulich@suse.com, bertrand.marquis@arm.com, rahul.singh@arm.com, Oleksandr Andrushchenko Subject: [PATCH 6/9] vpci/header: Handle p2m range sets per BAR Date: Fri, 3 Sep 2021 13:08:28 +0300 Message-Id: <20210903100831.177748-7-andr2000@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210903100831.177748-1-andr2000@gmail.com> References: <20210903100831.177748-1-andr2000@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Oleksandr Andrushchenko Instead of handling a single range set, that contains all the memory regions of all the BARs and ROM, have them per BAR. This is in preparation of making non-identity mappings in p2m for the MMIOs/ROM. Signed-off-by: Oleksandr Andrushchenko --- xen/drivers/vpci/header.c | 172 ++++++++++++++++++++++++++------------ xen/include/xen/vpci.h | 3 +- 2 files changed, 122 insertions(+), 53 deletions(-) diff --git a/xen/drivers/vpci/header.c b/xen/drivers/vpci/header.c index 793f79ece831..7f54199a3894 100644 --- a/xen/drivers/vpci/header.c +++ b/xen/drivers/vpci/header.c @@ -131,49 +131,75 @@ static void modify_decoding(const struct pci_dev *pdev, uint16_t cmd, bool vpci_process_pending(struct vcpu *v) { - if ( v->vpci.mem ) + if ( v->vpci.num_mem_ranges ) { struct map_data data = { .d = v->domain, .map = v->vpci.cmd & PCI_COMMAND_MEMORY, }; - int rc = rangeset_consume_ranges(v->vpci.mem, map_range, &data); + struct pci_dev *pdev = v->vpci.pdev; + struct vpci_header *header = &pdev->vpci->header; + unsigned int i; - if ( rc == -ERESTART ) - return true; + for ( i = 0; i < ARRAY_SIZE(header->bars); i++ ) + { + struct vpci_bar *bar = &header->bars[i]; + int rc; - spin_lock(&v->vpci.pdev->vpci->lock); - /* Disable memory decoding unconditionally on failure. */ - modify_decoding(v->vpci.pdev, - rc ? v->vpci.cmd & ~PCI_COMMAND_MEMORY : v->vpci.cmd, - !rc && v->vpci.rom_only); - spin_unlock(&v->vpci.pdev->vpci->lock); + if ( !bar->mem ) + continue; - rangeset_destroy(v->vpci.mem); - v->vpci.mem = NULL; - if ( rc ) - /* - * FIXME: in case of failure remove the device from the domain. - * Note that there might still be leftover mappings. While this is - * safe for Dom0, for DomUs the domain will likely need to be - * killed in order to avoid leaking stale p2m mappings on - * failure. - */ - vpci_remove_device(v->vpci.pdev); + rc = rangeset_consume_ranges(bar->mem, map_range, &data); + + if ( rc == -ERESTART ) + return true; + + spin_lock(&pdev->vpci->lock); + /* Disable memory decoding unconditionally on failure. */ + modify_decoding(pdev, + rc ? v->vpci.cmd & ~PCI_COMMAND_MEMORY : v->vpci.cmd, + !rc && v->vpci.rom_only); + spin_unlock(&pdev->vpci->lock); + + rangeset_destroy(bar->mem); + bar->mem = NULL; + v->vpci.num_mem_ranges--; + if ( rc ) + /* + * FIXME: in case of failure remove the device from the domain. + * Note that there might still be leftover mappings. While this is + * safe for Dom0, for DomUs the domain will likely need to be + * killed in order to avoid leaking stale p2m mappings on + * failure. + */ + vpci_remove_device(pdev); + } } return false; } static int __init apply_map(struct domain *d, const struct pci_dev *pdev, - struct rangeset *mem, uint16_t cmd) + uint16_t cmd) { struct map_data data = { .d = d, .map = true }; - int rc; + struct vpci_header *header = &pdev->vpci->header; + int rc = 0; + unsigned int i; + + for ( i = 0; i < ARRAY_SIZE(header->bars); i++ ) + { + struct vpci_bar *bar = &header->bars[i]; - while ( (rc = rangeset_consume_ranges(mem, map_range, &data)) == -ERESTART ) - process_pending_softirqs(); - rangeset_destroy(mem); + if ( !bar->mem ) + continue; + + while ( (rc = rangeset_consume_ranges(bar->mem, map_range, + &data)) == -ERESTART ) + process_pending_softirqs(); + rangeset_destroy(bar->mem); + bar->mem = NULL; + } if ( !rc ) modify_decoding(pdev, cmd, false); @@ -181,7 +207,7 @@ static int __init apply_map(struct domain *d, const struct pci_dev *pdev, } static void defer_map(struct domain *d, struct pci_dev *pdev, - struct rangeset *mem, uint16_t cmd, bool rom_only) + uint16_t cmd, bool rom_only, uint8_t num_mem_ranges) { struct vcpu *curr = current; @@ -192,9 +218,9 @@ static void defer_map(struct domain *d, struct pci_dev *pdev, * started for the same device if the domain is not well-behaved. */ curr->vpci.pdev = pdev; - curr->vpci.mem = mem; curr->vpci.cmd = cmd; curr->vpci.rom_only = rom_only; + curr->vpci.num_mem_ranges = num_mem_ranges; /* * Raise a scheduler softirq in order to prevent the guest from resuming * execution with pending mapping operations, to trigger the invocation @@ -206,42 +232,47 @@ static void defer_map(struct domain *d, struct pci_dev *pdev, static int modify_bars(const struct pci_dev *pdev, uint16_t cmd, bool rom_only) { struct vpci_header *header = &pdev->vpci->header; - struct rangeset *mem = rangeset_new(NULL, NULL, 0); struct pci_dev *tmp, *dev = NULL; const struct vpci_msix *msix = pdev->vpci->msix; - unsigned int i; + unsigned int i, j; int rc; - - if ( !mem ) - return -ENOMEM; + uint8_t num_mem_ranges; /* - * Create a rangeset that represents the current device BARs memory region + * Create a rangeset per BAR that represents the current device memory region * and compare it against all the currently active BAR memory regions. If * an overlap is found, subtract it from the region to be mapped/unmapped. * - * First fill the rangeset with all the BARs of this device or with the ROM + * First fill the rangesets with all the BARs of this device or with the ROM * BAR only, depending on whether the guest is toggling the memory decode * bit of the command register, or the enable bit of the ROM BAR register. */ for ( i = 0; i < ARRAY_SIZE(header->bars); i++ ) { - const struct vpci_bar *bar = &header->bars[i]; + struct vpci_bar *bar = &header->bars[i]; unsigned long start = PFN_DOWN(bar->addr); unsigned long end = PFN_DOWN(bar->addr + bar->size - 1); + bar->mem = NULL; + if ( !MAPPABLE_BAR(bar) || (rom_only ? bar->type != VPCI_BAR_ROM : (bar->type == VPCI_BAR_ROM && !header->rom_enabled)) ) continue; - rc = rangeset_add_range(mem, start, end); + bar->mem = rangeset_new(NULL, NULL, 0); + if ( !bar->mem ) + { + rc = -ENOMEM; + goto fail; + } + + rc = rangeset_add_range(bar->mem, start, end); if ( rc ) { printk(XENLOG_G_WARNING "Failed to add [%lx, %lx]: %d\n", start, end, rc); - rangeset_destroy(mem); - return rc; + goto fail; } } @@ -252,14 +283,21 @@ static int modify_bars(const struct pci_dev *pdev, uint16_t cmd, bool rom_only) unsigned long end = PFN_DOWN(vmsix_table_addr(pdev->vpci, i) + vmsix_table_size(pdev->vpci, i) - 1); - rc = rangeset_remove_range(mem, start, end); - if ( rc ) + for ( j = 0; j < ARRAY_SIZE(header->bars); j++ ) { - printk(XENLOG_G_WARNING - "Failed to remove MSIX table [%lx, %lx]: %d\n", - start, end, rc); - rangeset_destroy(mem); - return rc; + const struct vpci_bar *bar = &header->bars[j]; + + if ( !bar->mem ) + continue; + + rc = rangeset_remove_range(bar->mem, start, end); + if ( rc ) + { + printk(XENLOG_G_WARNING + "Failed to remove MSIX table [%lx, %lx]: %d\n", + start, end, rc); + goto fail; + } } } @@ -291,7 +329,8 @@ static int modify_bars(const struct pci_dev *pdev, uint16_t cmd, bool rom_only) unsigned long start = PFN_DOWN(bar->addr); unsigned long end = PFN_DOWN(bar->addr + bar->size - 1); - if ( !bar->enabled || !rangeset_overlaps_range(mem, start, end) || + if ( !bar->enabled || + !rangeset_overlaps_range(bar->mem, start, end) || /* * If only the ROM enable bit is toggled check against other * BARs in the same device for overlaps, but not against the @@ -300,13 +339,12 @@ static int modify_bars(const struct pci_dev *pdev, uint16_t cmd, bool rom_only) (rom_only && tmp == pdev && bar->type == VPCI_BAR_ROM) ) continue; - rc = rangeset_remove_range(mem, start, end); + rc = rangeset_remove_range(bar->mem, start, end); if ( rc ) { printk(XENLOG_G_WARNING "Failed to remove [%lx, %lx]: %d\n", start, end, rc); - rangeset_destroy(mem); - return rc; + goto fail; } } } @@ -324,12 +362,42 @@ static int modify_bars(const struct pci_dev *pdev, uint16_t cmd, bool rom_only) * will always be to establish mappings and process all the BARs. */ ASSERT((cmd & PCI_COMMAND_MEMORY) && !rom_only); - return apply_map(pdev->domain, pdev, mem, cmd); + return apply_map(pdev->domain, pdev, cmd); } - defer_map(dev->domain, dev, mem, cmd, rom_only); + /* Find out how many memory ranges has left after MSI and overlaps. */ + num_mem_ranges = 0; + for ( i = 0; i < ARRAY_SIZE(header->bars); i++ ) + { + struct vpci_bar *bar = &header->bars[i]; + + if ( !rangeset_is_empty(bar->mem) ) + num_mem_ranges++; + } + + /* + * There are cases when PCI device, root port for example, has neither + * memory space nor IO. In this case PCI command register write is + * missed resulting in the underlying PCI device not functional, so: + * - if there are no regions write the command register now + * - if there are regions then defer work and write later on + */ + if ( !num_mem_ranges ) + pci_conf_write16(pdev->sbdf, PCI_COMMAND, cmd); + else + defer_map(dev->domain, dev, cmd, rom_only, num_mem_ranges); return 0; + +fail: + for ( i = 0; i < ARRAY_SIZE(header->bars); i++ ) + { + struct vpci_bar *bar = &header->bars[i]; + + rangeset_destroy(bar->mem); + bar->mem = NULL; + } + return rc; } static void cmd_write(const struct pci_dev *pdev, unsigned int reg, diff --git a/xen/include/xen/vpci.h b/xen/include/xen/vpci.h index db86b8e7fa3c..a0cbdb4bf4fd 100644 --- a/xen/include/xen/vpci.h +++ b/xen/include/xen/vpci.h @@ -82,6 +82,7 @@ struct vpci { /* Guest view of the BAR. */ uint64_t guest_addr; uint64_t size; + struct rangeset *mem; enum { VPCI_BAR_EMPTY, VPCI_BAR_IO, @@ -156,9 +157,9 @@ struct vpci { struct vpci_vcpu { /* Per-vcpu structure to store state while {un}mapping of PCI BARs. */ - struct rangeset *mem; struct pci_dev *pdev; uint16_t cmd; + uint8_t num_mem_ranges; bool rom_only : 1; }; -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Sep 03 10:09:12 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Sep 2021 10:09:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177986.323851 (Exim 4.92) (envelope-from ) id 1mM68G-0007KL-0K; Fri, 03 Sep 2021 10:09:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177986.323851; Fri, 03 Sep 2021 10:09:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mM68F-0007K7-Rz; Fri, 03 Sep 2021 10:09:11 +0000 Received: by outflank-mailman (input) for mailman id 177986; Fri, 03 Sep 2021 10:09:11 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mM68F-0004Cr-Ae for xen-devel@lists.xenproject.org; Fri, 03 Sep 2021 10:09:11 +0000 Received: from mail-ej1-x635.google.com (unknown [2a00:1450:4864:20::635]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 574bafea-333f-4458-a85f-9d85f3dc68ab; Fri, 03 Sep 2021 10:08:43 +0000 (UTC) Received: by mail-ej1-x635.google.com with SMTP id a25so11014222ejv.6 for ; Fri, 03 Sep 2021 03:08:43 -0700 (PDT) Received: from a2klaptop.epam.com (host-176-36-245-220.b024.la.net.ua. [176.36.245.220]) by smtp.gmail.com with ESMTPSA id p5sm2427187eju.30.2021.09.03.03.08.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Sep 2021 03:08:41 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 574bafea-333f-4458-a85f-9d85f3dc68ab DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=EsmmWshqcRWEmqQF2VjxxyMLQRhse2D1gTlLi8+uzDk=; b=kYdmRslCs8NTALbXGc7+QzrWmSxEXO8+BDs+NVl9JKDEti73SNG8Bxa30Qe1HIM2o/ XlN/YA1k2fkV4slRcmp6oFpn1xBHxhY1jlkZ1Y/5EYq9OhYgZ58xAhwDlgV61QuuCjyy UZii3Li6tECiunnl+jSszF+5X1YlnUZ9HhEU5Y2gyKLjYGcWaXw8AL7xRlLjh8K9LC+M +4maoZpwsGzHA2FVcxyn/f9WCz+4CdQ3r6f4kt8mNoAuN+GCdEjFEkFTERnznC8Yl17X LuJl09dTX5S6Z5iWPREoG5DbkdNx09ZLnW0hEfhE+vSTnWXUawIhyV5Rq8wX2xSQGD2o HtZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=EsmmWshqcRWEmqQF2VjxxyMLQRhse2D1gTlLi8+uzDk=; b=co2MPdxS2NYgbewPN0EUl+L5yydIua2nKlB3+oeYgTGZ0zPlgzdo1D56PN5tcyFvKJ 4vQHsr+e07uCJbEdCSGdtklVDouMTgTQdtdaYKPMBm3Zs+ScDOdognLMaFA+ASCCXylm TDll1E0DA0d4uH/K2f2ukCOmRNuR3TqlWHvowtNnngrGDANJ08NgjB1HOtpianM6R7XH xC2TrdoRkqloWnkxhmZl/ZTkaOY4WBWv40FlvE856y14PP0EDn1EyRNJI89itn6xiasQ pu+nMJUwSicPHDF0/5sHMtnmX3CQAVlJGz7/dVbGjBF/F6xPGUbelDowCcNNgTXRByq6 vXmg== X-Gm-Message-State: AOAM532pMRFyhTXXnLPAfz6ZVLbUkWDOV8kD/yEfGcqduJjOczZzFvcV 3kseNt3Fkh0dv4TZJ+euQ82rhIJlYDA= X-Google-Smtp-Source: ABdhPJx8SGIw/Qab2uy5z2TUM5bpuiWzlOzdu1ih68KEF3FIN3G+q7L3S9fsjy63kr+jyeFlOUjLhQ== X-Received: by 2002:a17:907:96a2:: with SMTP id hd34mr3270175ejc.113.1630663721926; Fri, 03 Sep 2021 03:08:41 -0700 (PDT) From: Oleksandr Andrushchenko To: xen-devel@lists.xenproject.org Cc: julien@xen.org, sstabellini@kernel.org, oleksandr_tyshchenko@epam.com, volodymyr_babchuk@epam.com, Artem_Mygaiev@epam.com, roger.pau@citrix.com, jbeulich@suse.com, bertrand.marquis@arm.com, rahul.singh@arm.com, Oleksandr Andrushchenko Subject: [PATCH 7/9] vpci/header: program p2m with guest BAR view Date: Fri, 3 Sep 2021 13:08:29 +0300 Message-Id: <20210903100831.177748-8-andr2000@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210903100831.177748-1-andr2000@gmail.com> References: <20210903100831.177748-1-andr2000@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Oleksandr Andrushchenko Take into account guest's BAR view and program its p2m accordingly: gfn is guest's view of the BAR and mfn is the physical BAR value as set up by the host bridge in the hardware domain. This way hardware doamin sees physical BAR values and guest sees emulated ones. Signed-off-by: Oleksandr Andrushchenko --- xen/drivers/vpci/header.c | 35 +++++++++++++++++++++++++++++++++-- 1 file changed, 33 insertions(+), 2 deletions(-) diff --git a/xen/drivers/vpci/header.c b/xen/drivers/vpci/header.c index 7f54199a3894..7416ef1e1e06 100644 --- a/xen/drivers/vpci/header.c +++ b/xen/drivers/vpci/header.c @@ -30,6 +30,10 @@ struct map_data { struct domain *d; + /* Start address of the BAR as seen by the guest. */ + gfn_t start_gfn; + /* Physical start address of the BAR. */ + mfn_t start_mfn; bool map; }; @@ -37,12 +41,28 @@ static int map_range(unsigned long s, unsigned long e, void *data, unsigned long *c) { const struct map_data *map = data; + gfn_t start_gfn; int rc; for ( ; ; ) { unsigned long size = e - s + 1; + /* + * Any BAR may have holes in its memory we want to map, e.g. + * we don't want to map MSI regions which may be a part of that BAR, + * e.g. when a single BAR is used for both MMIO and MSI. + * In this case MSI regions are subtracted from the mapping, but + * map->start_gfn still points to the very beginning of the BAR. + * So if there is a hole present then we need to adjust start_gfn + * to reflect the fact of that substraction. + */ + start_gfn = gfn_add(map->start_gfn, s - mfn_x(map->start_mfn)); + + printk(XENLOG_G_DEBUG + "%smap [%lx, %lx] -> %#"PRI_gfn" for d%d\n", + map->map ? "" : "un", s, e, gfn_x(start_gfn), + map->d->domain_id); /* * ARM TODOs: * - On ARM whether the memory is prefetchable or not should be passed @@ -52,8 +72,10 @@ static int map_range(unsigned long s, unsigned long e, void *data, * - {un}map_mmio_regions doesn't support preemption. */ - rc = map->map ? map_mmio_regions(map->d, _gfn(s), size, _mfn(s)) - : unmap_mmio_regions(map->d, _gfn(s), size, _mfn(s)); + rc = map->map ? map_mmio_regions(map->d, start_gfn, + size, _mfn(s)) + : unmap_mmio_regions(map->d, start_gfn, + size, _mfn(s)); if ( rc == 0 ) { *c += size; @@ -69,6 +91,7 @@ static int map_range(unsigned long s, unsigned long e, void *data, ASSERT(rc < size); *c += rc; s += rc; + gfn_add(map->start_gfn, rc); if ( general_preempt_check() ) return -ERESTART; } @@ -149,6 +172,10 @@ bool vpci_process_pending(struct vcpu *v) if ( !bar->mem ) continue; + data.start_gfn = is_hardware_domain(v->vpci.pdev->domain) ? + _gfn(PFN_DOWN(bar->addr)) : + _gfn(PFN_DOWN(bar->guest_addr)); + data.start_mfn = _mfn(PFN_DOWN(bar->addr)); rc = rangeset_consume_ranges(bar->mem, map_range, &data); if ( rc == -ERESTART ) @@ -194,6 +221,10 @@ static int __init apply_map(struct domain *d, const struct pci_dev *pdev, if ( !bar->mem ) continue; + data.start_gfn = is_hardware_domain(d) ? + _gfn(PFN_DOWN(bar->addr)) : + _gfn(PFN_DOWN(bar->guest_addr)); + data.start_mfn = _mfn(PFN_DOWN(bar->addr)); while ( (rc = rangeset_consume_ranges(bar->mem, map_range, &data)) == -ERESTART ) process_pending_softirqs(); -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Sep 03 10:09:17 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Sep 2021 10:09:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177992.323863 (Exim 4.92) (envelope-from ) id 1mM68L-0007xj-Il; Fri, 03 Sep 2021 10:09:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177992.323863; Fri, 03 Sep 2021 10:09:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mM68L-0007xZ-EE; Fri, 03 Sep 2021 10:09:17 +0000 Received: by outflank-mailman (input) for mailman id 177992; Fri, 03 Sep 2021 10:09:16 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mM68K-0004Cr-An for xen-devel@lists.xenproject.org; Fri, 03 Sep 2021 10:09:16 +0000 Received: from mail-ej1-x635.google.com (unknown [2a00:1450:4864:20::635]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 81dc2936-e1af-40c8-8a27-a24992fd589f; Fri, 03 Sep 2021 10:08:44 +0000 (UTC) Received: by mail-ej1-x635.google.com with SMTP id mf2so10990948ejb.9 for ; Fri, 03 Sep 2021 03:08:43 -0700 (PDT) Received: from a2klaptop.epam.com (host-176-36-245-220.b024.la.net.ua. [176.36.245.220]) by smtp.gmail.com with ESMTPSA id p5sm2427187eju.30.2021.09.03.03.08.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Sep 2021 03:08:42 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 81dc2936-e1af-40c8-8a27-a24992fd589f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=9oZWyDoHrlYE4f9O9pDC/GUYZqq2tbn79VvRAgG5sU8=; b=G0v5SVgVhnp27fzhTFh/t3t6T3ZG3N3FQIFEBpPCV7HbEmNwdwHCsDna9Ka/KxV5FU DxTwEW485P0l8KGipmtwsR4PUeZba5wv3+Fu/ntpk5rL4UwSUtnBWGZYnBKUOM42NxuJ GFgt36WnRDm+PUd1QAGp4A2cQ2ZxqVUvShjebP00K+B1HTsHQQkU3uLmPWxgKL0AJPtb aznDETYoKDAewvu3eFK5aeZmP/KclS4BjcmZC+3sJHmxn1JpWg7lOPN/kWaaXmSgMb8e JqOVncQSXD/xA4F426v3mWQvQi+W2MGFum99JYmvYKVxmw6AeK1htZrltbHDiaSMYs2Q MMmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=9oZWyDoHrlYE4f9O9pDC/GUYZqq2tbn79VvRAgG5sU8=; b=Ul5ha2HbBHeFKU56A9FmD89nbB41SnxF5p4NO3s0lTyS/i2jSY94clHHGBlMRvu5Pb R+FZdRi1AssRf/R98fuBSuQbzexSwpDKH5D6WeWoNYBhRsbKzAFeAQ2dCCHVS3kW48Yr oh0uzN+gzfLxTuVdhpGJruzP39PZlHEXUzNy8YJk85Mh4PVoRco/Nz+SUyOGOaCCJVj/ avBvwXftKBd0+zzkojEUvWHA+q9DBLrqWulwhrs7i+3wKSlOkmleWU4HyPUvssQCH+wi XcGMc3zMlannMfrlUBiW+YDS9TE9i+q50PJ0rEFPBNLxR91oYmCGOxEN986gTtmg2hya f8Kg== X-Gm-Message-State: AOAM530t0rSAulO2Tr5mbpKDyYH5bn482wOLwLHWZUUq6kRc6muezO5m b5RsjRZOtucJLIyYUMYBWvAf0AVt3G8= X-Google-Smtp-Source: ABdhPJwC0I+pj81VPq5Z8aniIDBjWrsyNx1aYeEbgRJViZP4d+n9MV4hh4STMk34EUBwp0NwdeCIrw== X-Received: by 2002:a17:906:748e:: with SMTP id e14mr3277798ejl.152.1630663722931; Fri, 03 Sep 2021 03:08:42 -0700 (PDT) From: Oleksandr Andrushchenko To: xen-devel@lists.xenproject.org Cc: julien@xen.org, sstabellini@kernel.org, oleksandr_tyshchenko@epam.com, volodymyr_babchuk@epam.com, Artem_Mygaiev@epam.com, roger.pau@citrix.com, jbeulich@suse.com, bertrand.marquis@arm.com, rahul.singh@arm.com, Oleksandr Andrushchenko Subject: [PATCH 8/9] vpci/header: Reset the command register when adding devices Date: Fri, 3 Sep 2021 13:08:30 +0300 Message-Id: <20210903100831.177748-9-andr2000@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210903100831.177748-1-andr2000@gmail.com> References: <20210903100831.177748-1-andr2000@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Oleksandr Andrushchenko Reset the command register when passing through a PCI device: it is possible that when passing through a PCI device its memory decoding bits in the command register are already set. Thus, a guest OS may not write to the command register to update memory decoding, so guest mappings (guest's view of the BARs) are left not updated. Signed-off-by: Oleksandr Andrushchenko --- xen/drivers/vpci/header.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/xen/drivers/vpci/header.c b/xen/drivers/vpci/header.c index 7416ef1e1e06..dac973368b1e 100644 --- a/xen/drivers/vpci/header.c +++ b/xen/drivers/vpci/header.c @@ -811,6 +811,16 @@ int vpci_bar_add_handlers(const struct domain *d, struct pci_dev *pdev) gprintk(XENLOG_ERR, "%pp: failed to add BAR handlers for dom%d\n", &pdev->sbdf, d->domain_id); + + /* + * Reset the command register: it is possible that when passing + * through a PCI device its memory decoding bits in the command + * register are already set. Thus, a guest OS may not write to the + * command register to update memory decoding, so guest mappings + * (guest's view of the BARs) are left not updated. + */ + pci_conf_write16(pdev->sbdf, PCI_COMMAND, 0); + return rc; } -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Sep 03 10:09:22 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Sep 2021 10:09:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.177997.323874 (Exim 4.92) (envelope-from ) id 1mM68Q-00006V-RH; Fri, 03 Sep 2021 10:09:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 177997.323874; Fri, 03 Sep 2021 10:09:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mM68Q-00006O-OD; Fri, 03 Sep 2021 10:09:22 +0000 Received: by outflank-mailman (input) for mailman id 177997; Fri, 03 Sep 2021 10:09:21 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mM68P-0004Cr-Aw for xen-devel@lists.xenproject.org; Fri, 03 Sep 2021 10:09:21 +0000 Received: from mail-ej1-x62a.google.com (unknown [2a00:1450:4864:20::62a]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id cfd41a6e-29ed-4f0d-93f2-6a4adb13b1b1; Fri, 03 Sep 2021 10:08:45 +0000 (UTC) Received: by mail-ej1-x62a.google.com with SMTP id jg16so7877055ejc.1 for ; Fri, 03 Sep 2021 03:08:45 -0700 (PDT) Received: from a2klaptop.epam.com (host-176-36-245-220.b024.la.net.ua. [176.36.245.220]) by smtp.gmail.com with ESMTPSA id p5sm2427187eju.30.2021.09.03.03.08.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Sep 2021 03:08:43 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cfd41a6e-29ed-4f0d-93f2-6a4adb13b1b1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=hMt74Ggq0zLuhF8LFxm6cOM3G4Wenq/IlhMP/O3Mgu8=; b=V1tudX9W4mPKN2zjexbubTP4JGF55U3CiWlqiVVH/aom0cJVJ9DzTQIKOt0DiEqdeB gwJsiJ7+KLjAsmewkiv3WjPx0NljKuCC6KIu8e1A/0EQb3tPwt+Iw9O6ttCu1nEbMen9 dPfIoN8NWovGilGVHpkSunNV38UJxPyiT5SWc9gLFIWuF7vISABGFOf/CkkqLy5U8eBT csUbFMOjSPYoczhbwliEbPFTcQ1pEyU+dcCSuBHQlOK/0Jns8dCF/muXfodFaHpq4rue NAmSsaWkuUYPr1nJ+O/wEdrM+g5lWOlPDEU6Ak9vRyYXvYs0OI0MpwfvQwziA7gVjDds pMxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=hMt74Ggq0zLuhF8LFxm6cOM3G4Wenq/IlhMP/O3Mgu8=; b=rqp8P+819hb+Nc5KV1bfSgDPds2Qx4iqwmg8oFFbWh4ZqNIM6qVDcOCq7h6RawDZhd aEE62/tgVWnntBp55OnxsXazmB/MjUwRkpd4jY6duR1cEBqH3vVZuR+hJgW7BZsj4fER rmfXHct7z2ALSi7ZPhVn7iUoSjIX/debzlDvZ2RdKGyAlocz99WlZvuN7w0EVnGyLNw7 S0R1n7VoXVIWzLqA9KtzcLpg/U1QkTQR56MuN7H3uP7CY1Xekbfi1kTc/C+edWW7mscV HowfSkqgG+Tn62lUY4V9ElvWTpBuESqgoibah25qOZY/qr4FkS5erpQHUvtVo+fozXUP CLfA== X-Gm-Message-State: AOAM533PnJkO9S4kWSa0EgNTrODTxnqnnkoX83jVc6wYCeREriRFvzOK Ix1RSv1WQxCWpiQhuhKpoouQfIiBlUU= X-Google-Smtp-Source: ABdhPJypiSxpzvy084GcT4yZmHBhr6SMk1ebVuiTgJuY67izy5QHVzN9Q+8vXBtuc3hYUclLgUGWEQ== X-Received: by 2002:a17:906:e51:: with SMTP id q17mr3408604eji.76.1630663724006; Fri, 03 Sep 2021 03:08:44 -0700 (PDT) From: Oleksandr Andrushchenko To: xen-devel@lists.xenproject.org Cc: julien@xen.org, sstabellini@kernel.org, oleksandr_tyshchenko@epam.com, volodymyr_babchuk@epam.com, Artem_Mygaiev@epam.com, roger.pau@citrix.com, jbeulich@suse.com, bertrand.marquis@arm.com, rahul.singh@arm.com, Oleksandr Andrushchenko Subject: [PATCH 9/9] vpci/header: Use pdev's domain instead of vCPU Date: Fri, 3 Sep 2021 13:08:31 +0300 Message-Id: <20210903100831.177748-10-andr2000@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210903100831.177748-1-andr2000@gmail.com> References: <20210903100831.177748-1-andr2000@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Rahul Singh Fixes: 9c244fdef7e7 ("vpci: add header handlers") Signed-off-by: Rahul Singh Signed-off-by: Oleksandr Andrushchenko --- xen/drivers/vpci/header.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/drivers/vpci/header.c b/xen/drivers/vpci/header.c index dac973368b1e..688c69acbc23 100644 --- a/xen/drivers/vpci/header.c +++ b/xen/drivers/vpci/header.c @@ -157,7 +157,7 @@ bool vpci_process_pending(struct vcpu *v) if ( v->vpci.num_mem_ranges ) { struct map_data data = { - .d = v->domain, + .d = v->vpci.pdev->domain, .map = v->vpci.cmd & PCI_COMMAND_MEMORY, }; struct pci_dev *pdev = v->vpci.pdev; -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Sep 03 10:27:01 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Sep 2021 10:27:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.178035.323885 (Exim 4.92) (envelope-from ) id 1mM6PR-0004BE-BP; Fri, 03 Sep 2021 10:26:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 178035.323885; Fri, 03 Sep 2021 10:26:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mM6PR-0004B7-84; Fri, 03 Sep 2021 10:26:57 +0000 Received: by outflank-mailman (input) for mailman id 178035; Fri, 03 Sep 2021 10:26:56 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mM6PQ-0004B1-IX for xen-devel@lists.xenproject.org; Fri, 03 Sep 2021 10:26:56 +0000 Received: from smtp-out1.suse.de (unknown [195.135.220.28]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id a07fa6b6-d2eb-4ce5-aab4-a59e6090c514; Fri, 03 Sep 2021 10:26:55 +0000 (UTC) Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id AAE21222EF; Fri, 3 Sep 2021 10:26:54 +0000 (UTC) Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap1.suse-dmz.suse.de (Postfix) with ESMTPS id 4A9FC136DE; Fri, 3 Sep 2021 10:26:54 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap1.suse-dmz.suse.de with ESMTPSA id EnE/EG74MWGiDQAAGKfGzw (envelope-from ); Fri, 03 Sep 2021 10:26:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a07fa6b6-d2eb-4ce5-aab4-a59e6090c514 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1630664814; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XQ58Ucgkhc17h4IveJWXEz+P+uprNztu0MOEAIRPeBw=; b=oVz4x9WHA33YqEVhbNS3VUYbt/b23KgSR3YNXd+Ixq2RqytkH0aOz6hzy6TE+yUW95jBf8 liDqdPwCXB64Gy5XsrKlZzYEfqd7kCGOIefuVWzRVJkm0KsDstcrF3PidyL/zgHgtiK223 dlbt9ukmB3542BUT8UVsJq/q0wqR7dk= Subject: Re: [PATCH 08/11] libxl: Only map legacy PCI IRQs if they are supported To: Oleksandr Andrushchenko , xen-devel@lists.xenproject.org Cc: julien@xen.org, sstabellini@kernel.org, oleksandr_tyshchenko@epam.com, volodymyr_babchuk@epam.com, Artem_Mygaiev@epam.com, roger.pau@citrix.com, bertrand.marquis@arm.com, rahul.singh@arm.com, Oleksandr Andrushchenko , Ian Jackson References: <20210903083347.131786-1-andr2000@gmail.com> <20210903083347.131786-9-andr2000@gmail.com> From: Juergen Gross Message-ID: Date: Fri, 3 Sep 2021 12:26:53 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210903083347.131786-9-andr2000@gmail.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="XFWj5qjpdEL7JHWD4ryS1CqPu61GJ7zlH" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --XFWj5qjpdEL7JHWD4ryS1CqPu61GJ7zlH Content-Type: multipart/mixed; boundary="ARBrSBYpYYffIfVLBYOeH4vgLXjV1LrMR"; protected-headers="v1" From: Juergen Gross To: Oleksandr Andrushchenko , xen-devel@lists.xenproject.org Cc: julien@xen.org, sstabellini@kernel.org, oleksandr_tyshchenko@epam.com, volodymyr_babchuk@epam.com, Artem_Mygaiev@epam.com, roger.pau@citrix.com, bertrand.marquis@arm.com, rahul.singh@arm.com, Oleksandr Andrushchenko , Ian Jackson Message-ID: Subject: Re: [PATCH 08/11] libxl: Only map legacy PCI IRQs if they are supported References: <20210903083347.131786-1-andr2000@gmail.com> <20210903083347.131786-9-andr2000@gmail.com> In-Reply-To: <20210903083347.131786-9-andr2000@gmail.com> --ARBrSBYpYYffIfVLBYOeH4vgLXjV1LrMR Content-Type: multipart/mixed; boundary="------------E7B88EB43DA3CCAC89924545" Content-Language: en-US This is a multi-part message in MIME format. --------------E7B88EB43DA3CCAC89924545 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 03.09.21 10:33, Oleksandr Andrushchenko wrote: > From: Oleksandr Andrushchenko >=20 > Arm's PCI passthrough implementation doesn't support legacy interrupts,= > but MSI/MSI-X. This can be the case for other platforms too. > For that reason introduce a new CONFIG_PCI_SUPP_LEGACY_IRQ and add > it to the CFLAGS and compile the relevant code in the toolstack only if= > applicable. >=20 > Signed-off-by: Oleksandr Andrushchenko > Cc: Ian Jackson > Cc: Juergen Gross > --- > tools/libs/light/Makefile | 4 ++++ > tools/libs/light/libxl_pci.c | 13 +++++++++++++ > 2 files changed, 17 insertions(+) >=20 > diff --git a/tools/libs/light/Makefile b/tools/libs/light/Makefile > index 7d8c51d49242..bd3f6be2a183 100644 > --- a/tools/libs/light/Makefile > +++ b/tools/libs/light/Makefile > @@ -46,6 +46,10 @@ CFLAGS +=3D -Wno-format-zero-length -Wmissing-declar= ations \ > -Wno-declaration-after-statement -Wformat-nonliteral > CFLAGS +=3D -I. > =20 > +ifeq ($(CONFIG_X86),y) > +CFLAGS +=3D -DCONFIG_PCI_SUPP_LEGACY_IRQ > +endif > + > SRCS-$(CONFIG_X86) +=3D libxl_cpuid.c > SRCS-$(CONFIG_X86) +=3D libxl_x86.c > SRCS-$(CONFIG_X86) +=3D libxl_psr.c > diff --git a/tools/libs/light/libxl_pci.c b/tools/libs/light/libxl_pci.= c > index 59f3686fc85e..cd4fea46c3f7 100644 > --- a/tools/libs/light/libxl_pci.c > +++ b/tools/libs/light/libxl_pci.c > @@ -1434,6 +1434,7 @@ static void pci_add_dm_done(libxl__egc *egc, > } > } > fclose(f); > +#ifndef CONFIG_PCI_SUPP_LEGACY_IRQ Why #ifndef? Shouldn't this be #ifdef (same below multiple times)? Juergen --------------E7B88EB43DA3CCAC89924545 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Transfer-Encoding: quoted-printable Content-Description: OpenPGP public key Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy= cWx w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O= f8Z d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y= 9bf IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq= G7/ 377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR= 3Jv c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA= QIe AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT= hpw dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0= MbD 1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv= oPH Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v= 5QL +qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ= 2Vu IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC= QoL BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr= Wf0 teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC= /nu AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh= ITT d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm= XBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz= 80h SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC= AcD AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn= FOX gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1= jnD kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0= N51 N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l= otu fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1= tqS EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA= hsD BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3= g3O ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5= dM7 wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5= D+j LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm= V2x AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N= Eaw QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW= nHI s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR= wgn BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV= bVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk= pEd IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA= QAB wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw= Tbe 8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1= vJz Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8= VGi wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW= svi uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX= zXs ZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------E7B88EB43DA3CCAC89924545-- --ARBrSBYpYYffIfVLBYOeH4vgLXjV1LrMR-- --XFWj5qjpdEL7JHWD4ryS1CqPu61GJ7zlH Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmEx+G0FAwAAAAAACgkQsN6d1ii/Ey+Q 1AgAiDNRCWXbfWqmsG3dAif15NqTb2IyU0f4CIK6LL5z+EEDoVnaa1pqds2Cj5xfuh4M/cdzJDKx XV6vrhYvW/tUIVZXMzfg8T5GNGS+yJabgyN7SDYY3LR6WO6sbd2QVS24MxGyUrBvOFarTup1ihNN 4O1ufdl7guKej0CJmWrBz1XDj/KiCQhKyDB8cwK5lYOZkcJwjtMaj9NsfZJb1sOY2vnRo361ogTC kV/dAlYZ2XdzU7Dqc8biLZ6uLqh+56169UtHCSgJXE+64oySto4ljAL2uUZySMwrX6qSj6jKzl38 a3Wpu45mmpd43xFu8YZUYmouhcmZ+6NtljDqKVhbPA== =KWN7 -----END PGP SIGNATURE----- --XFWj5qjpdEL7JHWD4ryS1CqPu61GJ7zlH-- From xen-devel-bounces@lists.xenproject.org Fri Sep 03 10:31:10 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Sep 2021 10:31:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.178041.323895 (Exim 4.92) (envelope-from ) id 1mM6TV-0005cD-T7; Fri, 03 Sep 2021 10:31:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 178041.323895; Fri, 03 Sep 2021 10:31:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mM6TV-0005c6-Q3; Fri, 03 Sep 2021 10:31:09 +0000 Received: by outflank-mailman (input) for mailman id 178041; Fri, 03 Sep 2021 10:31:09 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mM6TU-0005bM-OD for xen-devel@lists.xenproject.org; Fri, 03 Sep 2021 10:31:08 +0000 Received: from mx0a-0039f301.pphosted.com (unknown [148.163.133.242]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 6acf58b6-7e27-4308-a979-c4927b2545f1; Fri, 03 Sep 2021 10:31:05 +0000 (UTC) Received: from pps.filterd (m0174676.ppops.net [127.0.0.1]) by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 183AIQtC008940; Fri, 3 Sep 2021 10:31:02 GMT Received: from eur05-db8-obe.outbound.protection.outlook.com (mail-db8eur05lp2105.outbound.protection.outlook.com [104.47.17.105]) by mx0a-0039f301.pphosted.com with ESMTP id 3auhu681em-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 03 Sep 2021 10:31:02 +0000 Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17) by AM9PR03MB6881.eurprd03.prod.outlook.com (2603:10a6:20b:286::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.17; Fri, 3 Sep 2021 10:31:00 +0000 Received: from AM0PR03MB6324.eurprd03.prod.outlook.com ([fe80::641e:b269:6d21:b7f8]) by AM0PR03MB6324.eurprd03.prod.outlook.com ([fe80::641e:b269:6d21:b7f8%5]) with mapi id 15.20.4478.022; Fri, 3 Sep 2021 10:31:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6acf58b6-7e27-4308-a979-c4927b2545f1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=co8f4AWKsRTST6P4ipuy/UNZ0+L9aX9mgokwvNy1uK9hBCyb+xBuVoqEjpSWeIULAsbASidG+1nQfqA4nm1rQrFEUk8OmEsdgv7sb+O4rgQrJsqJ9o0R8TsA8CWW8AO+hKzj+FRbac14jsitnV1OsQlI3pgOQWvJ0fCH18+PKCbxT6ncDjNtRzt5OTtYcX07M/vdhiEVhZXx77j/WXLb6c9Y0LX22OSuWWzOAuPNnok/Js0Cqe0xu7uHlfM+Rc0810vHVphnBOT6wMr2io/di5plrrG5PU+pbGeteKf4f1f2G5lG1MAuLjAhte5ju5nM5poDfox1c7Sw67db1avQkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=I1JrNBXFqVlvMtY1Qn3q/f0qiRWmgN9ym+/sXuGPkl8=; b=FQRcp0uWYrbOpcOdTD8BrEIn1Fbh4GoQKVerphzb1pk6uU/wMz99+ELzJENI1WRXB45lqWy27STwo6HBqieNRdmsVYc2tMZOl9SfNYfVFxuMBL29KKYDAZWMluWufCDZ9BzSLOYx8DStaYp+YBz/e0GiBv6sqQhMx4ww6eMVqwII3vXj8rCD+MhEfmDmJyIZ5Hn27XLJQmVk/kEmm/xvhnHVoHhssP3qjPdAr0rt3aNr87kWIXKTQ99nxwWPduu80uW6GTxELnx7WTWq3Yo4diPyxZkh/eZT/1ijNoN41bV2nFfDWoWjHI5TqsTR+DXvSAtALx/IR/gnwwnZno9gig== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=I1JrNBXFqVlvMtY1Qn3q/f0qiRWmgN9ym+/sXuGPkl8=; b=04ETNyi+jyv0gOdhh60UZXJlTKT3pz7FAgep46b8OnlZPgJqQfsvx412iJ7g4WPqopKlxu5hXnUEaJCfeE3TOEc+Vn28HLERwzEp5b3j1PZ75Lv+0lK+hsPoMBvGWaPjW7eQrLXBLtzPlq7jhNWQuoUwhIKdSJCCb2vkNf4xQq8aEaCbVxcnYYiskwW6MyiuBAEzXf7/0BYNFqbHo3Mtx5J6psM21Jogt/tMgM3f9IaG3kGe87j5WM5Xem0ISgdRsiADxaruAXdtYLbhdUafV9SObDjqdz32ynbsatZ8WgD40SWj2oCSJ67I0R7X8yOKFEEbGNs9gXQNYQzW/AHOmQ== From: Oleksandr Andrushchenko To: Juergen Gross , Oleksandr Andrushchenko , "xen-devel@lists.xenproject.org" CC: "julien@xen.org" , "sstabellini@kernel.org" , Oleksandr Tyshchenko , Volodymyr Babchuk , Artem Mygaiev , "roger.pau@citrix.com" , Bertrand Marquis , Rahul Singh , Ian Jackson Subject: Re: [PATCH 08/11] libxl: Only map legacy PCI IRQs if they are supported Thread-Topic: [PATCH 08/11] libxl: Only map legacy PCI IRQs if they are supported Thread-Index: AQHXoJ50aOdU36kT/0mQrZPJ6sbBAauSGzCAgAABJYA= Date: Fri, 3 Sep 2021 10:30:59 +0000 Message-ID: References: <20210903083347.131786-1-andr2000@gmail.com> <20210903083347.131786-9-andr2000@gmail.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=epam.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 111e0924-0885-4e37-950a-08d96ec5ec3e x-ms-traffictypediagnostic: AM9PR03MB6881: x-ms-exchange-transport-forked: True x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 4JoyLQJyQVy8el1YBzscb/9jdMy50fcKhWEPxscJbb+Eh8q0dgIZjzIYUIs6nrobEJDlX18wBu4Wzoi1zhvfRIaGn2I6ezD/wDZCu3+O9/ngTWcv1eSFu1nUpwOEPX1flScpcPnkkuFIlYazs836NoOeEAkSHGz7nSf0p/BnIgICpK07vXgJScxG17PqJJCFlsn7J7Eq7Y7dyQ+UbVW9p7cbWgN8J/0rljM7SE7D/bfHXzCKsYLNYB+kEl5xjqurbOiTC6qI+Tnd8RTjv5N33f9x70BEgFhe4jEfUFMJsOsd7z/NaMCed4PColDl/ZFMhzhaDXzmd7+pZk2o0ubooYDcLD951ycQb8u54pWiDuCZGfEdMtvFIsAYMTzFyFR+H0roU+91dMZ99Im8R5Qd8eniGONcZOC/X6ZWnOpjBuYLf4AQkeGKMxEjGdQEA4pYYVkxbP9ZncA66lNZ3nMz0qQDDcgQp63PfoATcGucNjSjxu6egf0U71Y43bBL9etZijBahk29mTyHIbcMgWnFd14WCKdwfxelt+VbOMASybYDF2Vr6orTUqIDl03BAQjpmQhHRpLPqcoSI4kLKJlB+mhpg5/cgNKIKzJIg4xCAQeZB0i05woi+ywC/rlQ/rVLHIGeSKtODhT1amhXoN6XYgye3E0fULrgbaFSluCPjKGAQLMJpXxRwVODCtuih+7pTPHABgE/5mkPZ3gzmkLhC9b4lb8RbnJEqtJZaE2IKnsZ/dYg0pDfoc5Z4PXJsHnC x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(39860400002)(376002)(136003)(346002)(366004)(316002)(110136005)(54906003)(6486002)(71200400001)(6512007)(83380400001)(86362001)(5660300002)(2906002)(2616005)(478600001)(38100700002)(66476007)(122000001)(66556008)(64756008)(66446008)(55236004)(4326008)(8936002)(186003)(26005)(76116006)(31686004)(31696002)(38070700005)(8676002)(6506007)(53546011)(66946007)(36756003)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?alU3aTU4REQvNkdvaEs5ajNZN0cySG5UNFZSdWJTelZxL1VqRXc3alhiTWNN?= =?utf-8?B?dTRIWVJlVEtWYllqeEZhU0dOSC8vaVpCbXlwL0ZKYzllVW0rQ2xlS29uV2Er?= =?utf-8?B?cWh3RDBINjdnbE82cnV3WkFjSkxBQVNKdnN4MkJ1VUxpeksycnY5TnZQcS9U?= =?utf-8?B?WDNVWmw4S0JTa0oyTzR6Mll5TnM0Wko5NDI1S2NoMFBweHQ0NDF4RGpPelB2?= =?utf-8?B?ZHpmK0pxYzdOZDRySFVxSE8vb01ETmNIak54WHFjWWlaV240eHE0MFNaZGJv?= =?utf-8?B?T3BEVTlWOC9mb0tUT29EcUVBZ0Q3VlF0L3VVOEpuTmFtWEMxVEl4aHR2M1dy?= =?utf-8?B?dXVpT3lvSUFwVVE0OWlYN2ZiaHNHdkkxeEpUOGM3aStrSkQxWGovdUozWHZw?= =?utf-8?B?NlNOazJFQnJDSG0rTzlWcHMrbHV6S2JMVTE2WEYxNlhVK3FmNi9lZllRdkF1?= =?utf-8?B?aWtYMnl2bGlma2owbmx5RWVOSVNLQWp4RmtpZ1h0MkdLRzJUSE1MTHJJaEpH?= =?utf-8?B?QndmSXFHSm14TklDK1ZzNnNNcFhMQ3RjWmptY1RkRm5xK2dQZFJOeUN2TUtH?= =?utf-8?B?Wlk3YzRHZFFZcVdndEVLdGszSm5qKzRpTEJXcC80RHowdFRNY3g1QnBxR1Va?= =?utf-8?B?TUVzL3Zsek9tM0s3eEtPV0RzbjRxbmJRSUtLKzJpTDN4N2prbUVNeHI0Ylli?= =?utf-8?B?d3FDUjgvem5LK2dveVlGZDBENzZiODNSOHFIemNjOVc1ZFdGKzJIN0hVZk5H?= =?utf-8?B?d1FFbUVHVnd1M2txMUZjenF1RGpsWDJuOUxkNm1SK3JXVDE4cnBKOU9ncUta?= =?utf-8?B?N3ozQnJ5ZVF5cHBSRnpyZzNQMGE0dG94bXZUT2lxcGl1cnVJOVlHVXB4YmJN?= =?utf-8?B?UjRXejZSUTc2N2dqT0FET2Vic2djMmRrNGg1dUlDYmVud1ZPRGJJNERNSnhi?= =?utf-8?B?blNZOWFpUTM4bXZ5ZDJRZk45c0h3bUVKWTZEbVU3djA3VTRSNUtCaXFoVFRY?= =?utf-8?B?dUJuQ2tUWmtZMHN6L0taTCtDY0VXNzVvbFFrbnJnUnNDRG8wL1JPYW1CL1RB?= =?utf-8?B?TFN0R2xISVlqWUNCeDQyUG9zVDFSKytkQnpSSkErQVM0YjNsajF1dFBVTEZH?= =?utf-8?B?bUthK2lqQVNZSHVLeVUwSUQ3TjF5TkpPa2VHQ3R1SU0rMzllTG96c3ptcWp2?= =?utf-8?B?VTdERHQ4ZnpWZlVWNzl6UFRodkdqQXBSc0Q1SnIxdldZbHU5SGZwL0VDeWJJ?= =?utf-8?B?WUJQMlVYZGJqUmhVb1VOeEtHRnl5V0hubzcvZ1lpdVd1VGplTzhJVC9ZVVpZ?= =?utf-8?B?TUtncjJoQnExRWkwcWRhRFowUDQvUUpweXYrRTlEL05KUlRMWGMxWW9FRDdE?= =?utf-8?B?bWgvQmRvN0JoRjJGdmZyOElPNEs0N0ppZVRYd2R0WmR2a3RCZ0ZJTU02ZTU5?= =?utf-8?B?NVM2TFpRVENXbzZTQVd6am9EQXhiZHdXamxlbnJibmRYc0MxVmdWYjN5Ri90?= =?utf-8?B?QkdmcUVsVUk3NS9YYjBzeTdCUnFPRnJ5QjhaR3lBZ2E5R1RRS3pnYmFodEUw?= =?utf-8?B?am9peGlUWnU4Y1lOQUVkVXpkVVQwNGpLN2xmd21FMWxkTnlJN0g3UjFsNlRL?= =?utf-8?B?WXFIdER4N3pZaEY0QVh3OUhZWGJuME5aQjdaQTQ2Y0NES3RuNGxGZDFNbnla?= =?utf-8?B?ZWRtbTRSbFlRVkZuZ1BCWitOT00yOUF0QWpzSUdXZUQ2T1BYNzZxUUhwK2g3?= =?utf-8?B?UHNOL2c1UXFQcm9lNUhwVjFxV29YR3FibkhOc0FyRTdxZHlFL2JIZTkyVUx0?= =?utf-8?B?bGszY1NzTWZFUWhmdmVHZz09?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: epam.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 111e0924-0885-4e37-950a-08d96ec5ec3e X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Sep 2021 10:30:59.9717 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: dwTTRvMBwtG6wkkUNOPbnQOL1LS6cHGgolcGw9Ye+BxA8vjuMvqMfGpIyESsDk4/SZ1ianZ2LkJTgklmyq9IH9rY+J770KcKDHftkhwE9w/5aypZyLLTDrwe3IiwmUfL X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR03MB6881 X-Proofpoint-ORIG-GUID: -4YD1Sw6CRSks1MY1lcyDuQbmyM8uOXu X-Proofpoint-GUID: -4YD1Sw6CRSks1MY1lcyDuQbmyM8uOXu X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.391,FMLib:17.0.607.475 definitions=2021-09-03_02,2021-09-03_01,2020-04-07_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 phishscore=0 clxscore=1011 mlxscore=0 lowpriorityscore=0 spamscore=0 mlxlogscore=999 malwarescore=0 suspectscore=0 bulkscore=0 priorityscore=1501 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2108310000 definitions=main-2109030064 SGVsbG8sIEp1ZXJnZW4hDQoNCk9uIDAzLjA5LjIxIDEzOjI2LCBKdWVyZ2VuIEdyb3NzIHdyb3Rl Og0KPiBPbiAwMy4wOS4yMSAxMDozMywgT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gd3JvdGU6DQo+ PiBGcm9tOiBPbGVrc2FuZHIgQW5kcnVzaGNoZW5rbyA8b2xla3NhbmRyX2FuZHJ1c2hjaGVua29A ZXBhbS5jb20+DQo+Pg0KPj4gQXJtJ3MgUENJIHBhc3N0aHJvdWdoIGltcGxlbWVudGF0aW9uIGRv ZXNuJ3Qgc3VwcG9ydCBsZWdhY3kgaW50ZXJydXB0cywNCj4+IGJ1dCBNU0kvTVNJLVguIFRoaXMg Y2FuIGJlIHRoZSBjYXNlIGZvciBvdGhlciBwbGF0Zm9ybXMgdG9vLg0KPj4gRm9yIHRoYXQgcmVh c29uIGludHJvZHVjZSBhIG5ldyBDT05GSUdfUENJX1NVUFBfTEVHQUNZX0lSUSBhbmQgYWRkDQo+ PiBpdCB0byB0aGUgQ0ZMQUdTIGFuZCBjb21waWxlIHRoZSByZWxldmFudCBjb2RlIGluIHRoZSB0 b29sc3RhY2sgb25seSBpZg0KPj4gYXBwbGljYWJsZS4NCj4+DQo+PiBTaWduZWQtb2ZmLWJ5OiBP bGVrc2FuZHIgQW5kcnVzaGNoZW5rbyA8b2xla3NhbmRyX2FuZHJ1c2hjaGVua29AZXBhbS5jb20+ DQo+PiBDYzogSWFuIEphY2tzb24gPGl3akB4ZW5wcm9qZWN0Lm9yZz4NCj4+IENjOiBKdWVyZ2Vu IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+DQo+PiAtLS0NCj4+IMKgIHRvb2xzL2xpYnMvbGlnaHQv TWFrZWZpbGXCoMKgwqAgfMKgIDQgKysrKw0KPj4gwqAgdG9vbHMvbGlicy9saWdodC9saWJ4bF9w Y2kuYyB8IDEzICsrKysrKysrKysrKysNCj4+IMKgIDIgZmlsZXMgY2hhbmdlZCwgMTcgaW5zZXJ0 aW9ucygrKQ0KPj4NCj4+IGRpZmYgLS1naXQgYS90b29scy9saWJzL2xpZ2h0L01ha2VmaWxlIGIv dG9vbHMvbGlicy9saWdodC9NYWtlZmlsZQ0KPj4gaW5kZXggN2Q4YzUxZDQ5MjQyLi5iZDNmNmJl MmExODMgMTAwNjQ0DQo+PiAtLS0gYS90b29scy9saWJzL2xpZ2h0L01ha2VmaWxlDQo+PiArKysg Yi90b29scy9saWJzL2xpZ2h0L01ha2VmaWxlDQo+PiBAQCAtNDYsNiArNDYsMTAgQEAgQ0ZMQUdT ICs9IC1Xbm8tZm9ybWF0LXplcm8tbGVuZ3RoIC1XbWlzc2luZy1kZWNsYXJhdGlvbnMgXA0KPj4g wqDCoMKgwqDCoCAtV25vLWRlY2xhcmF0aW9uLWFmdGVyLXN0YXRlbWVudCAtV2Zvcm1hdC1ub25s aXRlcmFsDQo+PiDCoCBDRkxBR1MgKz0gLUkuDQo+PiDCoCAraWZlcSAoJChDT05GSUdfWDg2KSx5 KQ0KPj4gK0NGTEFHUyArPSAtRENPTkZJR19QQ0lfU1VQUF9MRUdBQ1lfSVJRDQo+PiArZW5kaWYN Cj4+ICsNCj4+IMKgIFNSQ1MtJChDT05GSUdfWDg2KSArPSBsaWJ4bF9jcHVpZC5jDQo+PiDCoCBT UkNTLSQoQ09ORklHX1g4NikgKz0gbGlieGxfeDg2LmMNCj4+IMKgIFNSQ1MtJChDT05GSUdfWDg2 KSArPSBsaWJ4bF9wc3IuYw0KPj4gZGlmZiAtLWdpdCBhL3Rvb2xzL2xpYnMvbGlnaHQvbGlieGxf cGNpLmMgYi90b29scy9saWJzL2xpZ2h0L2xpYnhsX3BjaS5jDQo+PiBpbmRleCA1OWYzNjg2ZmM4 NWUuLmNkNGZlYTQ2YzNmNyAxMDA2NDQNCj4+IC0tLSBhL3Rvb2xzL2xpYnMvbGlnaHQvbGlieGxf cGNpLmMNCj4+ICsrKyBiL3Rvb2xzL2xpYnMvbGlnaHQvbGlieGxfcGNpLmMNCj4+IEBAIC0xNDM0 LDYgKzE0MzQsNyBAQCBzdGF0aWMgdm9pZCBwY2lfYWRkX2RtX2RvbmUobGlieGxfX2VnYyAqZWdj LA0KPj4gwqDCoMKgwqDCoMKgwqDCoMKgIH0NCj4+IMKgwqDCoMKgwqAgfQ0KPj4gwqDCoMKgwqDC oCBmY2xvc2UoZik7DQo+PiArI2lmbmRlZiBDT05GSUdfUENJX1NVUFBfTEVHQUNZX0lSUQ0KPg0K PiBXaHkgI2lmbmRlZj8gU2hvdWxkbid0IHRoaXMgYmUgI2lmZGVmIChzYW1lIGJlbG93IG11bHRp cGxlIHRpbWVzKT8NCg0KWWVzLCB5b3UgYXJlIHJpZ2h0LiBJIGhhdmUgdG8gcmV2ZXJ0IHRoZSBs b2dpYywgZS5nLiBzL2lmbmRlZi9pZmRlZg0KDQpPdGhlciB0aGFuIHRoYXQsIGFyZSB5b3Ugb2sg d2l0aCBDT05GSUdfUENJX1NVUFBfTEVHQUNZX0lSUSBuYW1lPw0KDQpUaGFuayB5b3UgYW5kIHNv cnJ5IGZvciB0aGUgbm9pc2UsDQoNCk9sZWtzYW5kcg0KDQo+DQo+DQo+IEp1ZXJnZW4= From xen-devel-bounces@lists.xenproject.org Fri Sep 03 11:22:02 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Sep 2021 11:22:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.178050.323907 (Exim 4.92) (envelope-from ) id 1mM7GU-0003bi-TR; Fri, 03 Sep 2021 11:21:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 178050.323907; Fri, 03 Sep 2021 11:21:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mM7GU-0003bb-PG; Fri, 03 Sep 2021 11:21:46 +0000 Received: by outflank-mailman (input) for mailman id 178050; Fri, 03 Sep 2021 11:21:45 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mM7GT-0003bR-3d; Fri, 03 Sep 2021 11:21:45 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mM7GS-000325-S1; Fri, 03 Sep 2021 11:21:44 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mM7GS-0000v7-Hb; Fri, 03 Sep 2021 11:21:44 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mM7GS-00016h-GI; Fri, 03 Sep 2021 11:21:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=FPlSQJVroworsex5KXf59TIdvnygvElrQN7UTB9YKDI=; b=1qfzVA7SLokIXifEYtVHNcqCx2 /QU4OlxzxEX+IcSDg6V7aM715We4ufVGkUXTVX/9yiqC37ZWxaEkmyEDrF6izzUi4C5yJGuHHGVvN fwqddNGKzNg3uzIr1KMyFGYWwCSfGYnLPkYQ9bTPilm+oiNukVRC8VvWdxiYMJee+smw=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 164786: tolerable FAIL X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=96607a8e680e7f965ca868d11f8b0636317d2618 X-Osstest-Versions-That: xen=96607a8e680e7f965ca868d11f8b0636317d2618 From: osstest service owner Date: Fri, 03 Sep 2021 11:21:44 +0000 flight 164786 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/164786/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 164739 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 164739 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 164739 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 164739 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 164739 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 164739 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 164739 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 164739 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 164739 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 164739 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 164739 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen 96607a8e680e7f965ca868d11f8b0636317d2618 baseline version: xen 96607a8e680e7f965ca868d11f8b0636317d2618 Last test of basis 164786 2021-09-03 01:51:45 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Fri Sep 03 12:41:45 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Sep 2021 12:41:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.178065.323921 (Exim 4.92) (envelope-from ) id 1mM8Vh-0004Xh-0Y; Fri, 03 Sep 2021 12:41:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 178065.323921; Fri, 03 Sep 2021 12:41:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mM8Vg-0004Xa-TG; Fri, 03 Sep 2021 12:41:32 +0000 Received: by outflank-mailman (input) for mailman id 178065; Fri, 03 Sep 2021 12:41:32 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mM8Vf-0004XU-Ui for xen-devel@lists.xenproject.org; Fri, 03 Sep 2021 12:41:31 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 9222c8ea-69bc-4cf3-8606-09a74fbeab7b; Fri, 03 Sep 2021 12:41:30 +0000 (UTC) Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-he1eur02lp2053.outbound.protection.outlook.com [104.47.5.53]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-14-LIyylY2YMj6tMTlQvMVfuw-1; Fri, 03 Sep 2021 14:41:28 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR04MB5903.eurprd04.prod.outlook.com (2603:10a6:803:e0::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.21; Fri, 3 Sep 2021 12:41:26 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4478.021; Fri, 3 Sep 2021 12:41:26 +0000 Received: from [10.156.60.236] (37.24.206.209) by PR3P189CA0063.EURP189.PROD.OUTLOOK.COM (2603:10a6:102:b4::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Fri, 3 Sep 2021 12:41:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9222c8ea-69bc-4cf3-8606-09a74fbeab7b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1630672889; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EbrS5Qs1UIXDzktuDY0e79UHyHoqnt/wbQv5dVhWme4=; b=SA0v1wSI8hF4sjL2hFMBaKgX+jFl4HrmUMoL/2PToXrpOJu6rI/abwIq4cMXu/C4bnaesG kshKrBdhrTORfbfBf+VcQC7G3oU5hoZliqyjBa0R6RI2YfyTiFU5gJ/0a7F4oeq7+agsRs mkS5tY/qZ0++4rIKW6/S+RD2YV8bA1U= X-MC-Unique: LIyylY2YMj6tMTlQvMVfuw-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cjWebvd6BgjtC+0LvqsHTUHOHb8rx5hON3KQeKXN5d2vNjiYgabJWbI3XCx3ST9of4AgwHqLWepzO+7fcWLJ2coIdLG30zWqY/m5rZLB0aEM6+QeEModsU42xiDlzWSDqhU9Zq48IxzorvaEOqSkVCoHs47Qp5d4K9U22jnf/MC40AihSUJuyqmcWfd1CINvv2yMpOI4Sb02IwmXKEoAFwF2DjKZS/lB42W5DS53SIpeukvXKxRbyDAC5GBbQb86LhZBfhURcA9emgOhC3ggtI8RRovtYU1k9rOHeMTEgA3PmBD0bbGY4O2u1MQ+1fUgVoT64BlwmYnBwg+bNYSFpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=EbrS5Qs1UIXDzktuDY0e79UHyHoqnt/wbQv5dVhWme4=; b=MtXi8j+n+Rsyn1wjfYVoO9O2Za/S3EceM7KDmDB1w6r83oMMYODtokGtdh3HC0O+duYYOOZTzleE/ZghupwPRYjRd2y4eI6v6l+ReB1G7Vz3qTFiQ4OnTotR2xx5rX2PsuLf2EbLu48ppEsfONMIvS5APETV91P+zYDZVub/71RAEZggLtRGnWwreGmGiqCxIC4uiaC+h3gDnGIKSAU0nX7Zr+F1HoSYQz86dmHR7XYjx7qRv15zCYk4H3F8VWYriaHwhFAL4Kn2LWi33S0l9wHcddGMjC1IrdIrK0Z7cKvk7qnMqXBPlBKp+6prz708+TKikx7/fI5xBP8ZIdj/jA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com; Subject: Re: [PATCH 05/11] xen/arm: Mark device as PCI while creating one To: Oleksandr Andrushchenko Cc: julien@xen.org, sstabellini@kernel.org, oleksandr_tyshchenko@epam.com, volodymyr_babchuk@epam.com, Artem_Mygaiev@epam.com, roger.pau@citrix.com, bertrand.marquis@arm.com, rahul.singh@arm.com, Oleksandr Andrushchenko , xen-devel@lists.xenproject.org References: <20210903083347.131786-1-andr2000@gmail.com> <20210903083347.131786-6-andr2000@gmail.com> From: Jan Beulich Message-ID: <1b890e67-c907-6678-bc98-d810231d9b50@suse.com> Date: Fri, 3 Sep 2021 14:41:23 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: <20210903083347.131786-6-andr2000@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PR3P189CA0063.EURP189.PROD.OUTLOOK.COM (2603:10a6:102:b4::8) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6a061db7-b876-4ee2-2881-08d96ed82517 X-MS-TrafficTypeDiagnostic: VI1PR04MB5903: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7219; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: I1mDtXKJhnyl/yZHIr8Fa6Ij7nODyJmXEahwicGcdrNx/7jHwW4g7J936zDMdCj8h8h8uysEvYiTj1NL0G/5UBAuMbuQAUms8WOwQD2Ub4PD2oZrOuiZyiGFd6bCB08mC2XtabItvKado6f1SkkQxwjtPPZN7bubbBHbO05eTFgQBq1lqx2tYtCbEeN9a5zaakJYQGqdhOmA9uHaduWxTj55azO3m1yfEOmcb17PUdsk1MOsXVdO+PAgWJuhpCUnhCA3yp3wu/FwQR/UrmplhnNxTLfWH6FT8+rQ6yGd6X0dPIrkrKFtPp/O34XViKLFP+PZ1xNVPzay/Ffgf21k3/K+LuG0BOxO+IiPBJff874c97p+RXN6mEy0+fQAISwSdaJ3E46TmQbdTc2uetgwsZPSuSDaDcP7E/O9sQSo9NXydmYsLkZnNOjmDv9huB5vt8DrrsuzMjXAXIMcLpIc9YPlUZn8QkNqyz7Lib1m9Qk9Szz+INGUSpElYLQgX4cqzArcLDZfrDXbFje/uG+aKtpQz1wZ53LOogpI8UzPjL29Ztw3myuMmafoagHi170Z1Ob7SSxTsUcFtMaart7Mh8gjxskCLqPTztS/ru12bL1zdrQwMOGdk6sk05pI9uR9+UI5XwLA1dMDlFjEgRoHWo8pn9En7nnvNF/tYEKJ2a9VHVWzusIKLMD2muXjM2t4Agl6sAxOwysWo+EvC/lCZi6qWNzZ+F5nNDjK1nk/ugM= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(39860400002)(346002)(396003)(136003)(376002)(366004)(956004)(26005)(16576012)(7416002)(6486002)(478600001)(316002)(2616005)(6916009)(4744005)(5660300002)(4326008)(31686004)(2906002)(66556008)(186003)(66946007)(66476007)(36756003)(31696002)(86362001)(53546011)(38100700002)(8676002)(8936002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VDZJcHVXN2FMZGVQaWpjUlFqeW03RVgwb2ZGN2REcFE4TXRNMFczN0paRmRM?= =?utf-8?B?eTZZUmRGdFg3VENDK3g0SWF3VktUWERubGUzbzRyTGo3cDdMaTBpbnhIUEJS?= =?utf-8?B?a3pXSGJTNHFYU09VazMybm9mZk8xVFU4TVphUWFVTUV5dExtOEVYVXBZZy9N?= =?utf-8?B?ekJmT3JlTFRjRlpZcWFBN0xMNXZ3SVhJbDNSbTMrazMwVWxsUnhEQ2JoaHFx?= =?utf-8?B?RTQ5WUhBLzJWbFRXSVpBU1ZrRXZTVkVGeHdob3N3UGhIRTFOTzJVNllPa016?= =?utf-8?B?WWZzWllZeU9RN284TEswZkpsK1JSdXNhRWRGTnVJZ3VTcEtqdlpqOWRVdU1O?= =?utf-8?B?OG5CY1BXWlUrK1JVZXF5T2NpSzhqeUxhLzd1R3gzR09zSFQ1Q3UxOWhXZ2lO?= =?utf-8?B?RnZ5c0dyR2lFWG94VVpoRDRnTG1IcEhNWDJNcnY2eUoyM2dHZFNaSEt3bit3?= =?utf-8?B?d3BCTTlRajdEL2ZXcUlGVU1vakppTTZSUTVHS0RMa0lVT0F2Z2hHZjJKRTBW?= =?utf-8?B?YVZIOVp5MXFDZitrbnBZV3pjQldNQXJkWWdKUVpMSDAwU0h6RWNJU3k5QWZw?= =?utf-8?B?aFM2b2dpenROUE5wU2g4cW02Tm5SZTFvak9lbVFybklCMkI0ZVp3djMrT2Np?= =?utf-8?B?bFhvVis1SGU2akFwdDNzVXRsVitHeWxkQmg4amlGRVJuNkVZWDNwNWlLeldQ?= =?utf-8?B?eC9RUjFPSlNOMHg2dkxYMVRVZjhSLzQxV0V0Q2tRTCtMbWNYcE1WcWxDY1RJ?= =?utf-8?B?NWlpYTFCa2IzWnF5cGkyVXhaakRPUU80Y1pFWjZaRjJETjNlTlljam1tWkkv?= =?utf-8?B?d0wzRnJwWVdCc0FxUXRXY0R5Qnd0VnRoQmJFdjRkRGJwdUh3cUU3UkpzVHpW?= =?utf-8?B?NW5sRnpVL1MrT2w3MkZoM2xVZHl6UDVvMzhHV0p0MEtMcUpZakNNaFR3WDZK?= =?utf-8?B?VUNVdUpHZ1dsSnY4andMUXRCZ3dSak55UC9wclhoTThaZ0ZDVWtTVXpUdmVi?= =?utf-8?B?NnF4ektKbEN1ZlltZFJjZkpONFRjeHZISUFISllSbjFMU3FXdUlKQlE5VWZJ?= =?utf-8?B?dmhsVFN0YjVXeWlOeXNzcnk2ZmcwT3hVdE9Sbkx4UVZYd1lDR3Y1cUM0RnJy?= =?utf-8?B?UTVxKytBdzIyd0dldWEydlJzL3picjhQYVNrNm0wU21JekQ2RFhzMTdFSWMx?= =?utf-8?B?MzYwZHo3VGR2M0hvQUcxeTIzVGh6Y1RRang4RldhTHZoeXBMTDZaZGpkTHZZ?= =?utf-8?B?aHVjeVpXYkEvVThwUTFaRTdPVmhMQzBBVTFEQjkvMGxEeVFJakV3OW5qdGpz?= =?utf-8?B?MFQzNmI4QlRZeFZubmhGUHhRMU9xWkdrVDVUL3FMWGNqTGk4cWtRcFJOMFoz?= =?utf-8?B?RGl5cEZhb3FDQUllU213c2dveERJc2x3ODV6SVhpclFjVG9JaExpZitRaHg5?= =?utf-8?B?WEN5MU90dytQNk9GQUEzV3hQaFpqOWRrTzUzdVNoYXc0SFI2dm92YURyVXUr?= =?utf-8?B?cGFhK0ZsTVVlcmptRFNrSCt4c0xLZmJiMVoxdytPQ0UyekY1cUJJNDVnWHcv?= =?utf-8?B?R2VZREtqK3JRMDdPSVNya2JWelNqR2hIcXJmNUxibXlZcERFL0Zlby80UkVC?= =?utf-8?B?RDJBcXkzRDBRZ1MzWDEweUhKU2R5aFZ0Z2llNEpjNllDVHl3bEFxK0lFOC9o?= =?utf-8?B?b0NnSm8yeXhhcENnY29RRVg3cVN6T2Rqci95Zk1oVWw3RUcrTTdzMS9lUU10?= =?utf-8?Q?Q3IIIBW0jFzUo8x9h355byMsXgu0HQSr4c5hQ/7?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6a061db7-b876-4ee2-2881-08d96ed82517 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Sep 2021 12:41:26.6250 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: relRL+MFgHFf7TrmdR5q5a+iAf+9damWMM5MiPNccQpaZEy9KMs4NJ/zhSSmFp+1M4yQKQ5Ag36wRckubKQzMg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5903 On 03.09.2021 10:33, Oleksandr Andrushchenko wrote: > --- a/xen/drivers/passthrough/pci.c > +++ b/xen/drivers/passthrough/pci.c > @@ -1301,6 +1301,9 @@ static int iommu_add_device(struct pci_dev *pdev) > if ( !is_iommu_enabled(pdev->domain) ) > return 0; > > +#ifdef CONFIG_ARM > + pci_to_dev(pdev)->type = DEV_PCI; > +#endif Why here instead of in alloc_pdev()? The field should be valid by the time the new item gets inserted into the segment's list of devices, imo. Jan From xen-devel-bounces@lists.xenproject.org Fri Sep 03 13:03:18 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Sep 2021 13:03:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.178072.323932 (Exim 4.92) (envelope-from ) id 1mM8qc-0007IG-Ru; Fri, 03 Sep 2021 13:03:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 178072.323932; Fri, 03 Sep 2021 13:03:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mM8qc-0007I9-Nz; Fri, 03 Sep 2021 13:03:10 +0000 Received: by outflank-mailman (input) for mailman id 178072; Fri, 03 Sep 2021 13:03:09 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mM8qb-0007Hz-O9; Fri, 03 Sep 2021 13:03:09 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mM8qb-0004gd-GB; Fri, 03 Sep 2021 13:03:09 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mM8qb-0004Vc-8W; Fri, 03 Sep 2021 13:03:09 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mM8qb-0004IM-81; Fri, 03 Sep 2021 13:03:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=nVM4epZLBzhC6myYmCTKRg5uCCc6chP9UyZBAGY6Apk=; b=AYNfOLjZzq36GwX69LaYgCuFQ6 ycyMJknIS+ZWo9xx+KCd+eVnVWeNyIjY1cwY7wE2/xsHDoHSoVBrCgW9+ZVm632lv5XREE3j14HTy Dy14Q0eRtJ3Cru9OYyzLyH7hjnx78Pc2giB/bR7FX8syLbCRmSmhS1L3NShtd5lA0zuA=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 164794: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=81d71fb86e1ad676e94becb7ffffb403cefd3019 X-Osstest-Versions-That: ovmf=cae735f61328d64e2e8991036707b9e78c0f5f63 From: osstest service owner Date: Fri, 03 Sep 2021 13:03:09 +0000 flight 164794 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/164794/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 164674 build-amd64-xsm 6 xen-build fail REGR. vs. 164674 build-i386-xsm 6 xen-build fail REGR. vs. 164674 build-i386 6 xen-build fail REGR. vs. 164674 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 81d71fb86e1ad676e94becb7ffffb403cefd3019 baseline version: ovmf cae735f61328d64e2e8991036707b9e78c0f5f63 Last test of basis 164674 2021-08-31 02:56:52 Z 3 days Failing since 164686 2021-09-01 03:03:43 Z 2 days 22 attempts Testing same since 164788 2021-09-03 04:12:12 Z 0 days 3 attempts ------------------------------------------------------------ People who touched revisions under test: Anthony PERARD DunTan Gary Lin Hao A Wu Jim Fehlig Lin, Gary (HPS OE-Linux) Loo Tung Lun Loo, Tung Lun Mark Wilson Marvin H?user Rebecca Cran Wenxing Hou Wenyi Xie jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit 81d71fb86e1ad676e94becb7ffffb403cefd3019 Author: Hao A Wu Date: Fri Aug 20 13:36:56 2021 +0800 Maintainers.txt: Update maintainer/reviewer roles in MdeModulePkg Remove Hao A Wu as the MdeModulePkg maintainer. Add Liming Gao as the MdeModulePkg maintainer. Remove Hao A Wu as the MdeModulePkg: Firmware Update modules reviewer. Remove Hao A Wu as the MdeModulePkg: Serial modules reviewer. Cc: Jian J Wang Cc: Liming Gao Cc: Guomin Jiang Cc: Ray Ni Cc: Zhichao Gao Signed-off-by: Hao A Wu Reviewed-by: Liming Gao Reviewed-by: Zhichao Gao commit c5e805ffe1098601e84fd501d5fa1d45e9d96a62 Author: Rebecca Cran Date: Tue Aug 31 06:36:36 2021 +0800 MdeModulePkg: Fix typo of "memory" in RamDiskDxe debug message Fix a typo of "memory" in a debug message in RamDiskProtocol.c. Signed-off-by: Rebecca Cran Reviewed-by: Hao A Wu Reviewed-by: Philippe Mathieu-Daude commit b6bc203375b6efb6822ee4fe4a59be4f1918436b Author: Wenyi Xie Date: Thu Aug 26 09:16:03 2021 +0800 MdeModulePkg/HiiDatabaseDxe:remove dead code block As the if statement outside has confirmed that BlockData->Name == NULL, so the if statement inside is always false. Cc: Jian J Wang Cc: Hao A Wu Cc: Dandan Bi Cc: Eric Dong Signed-off-by: Wenyi Xie Reviewed-by: Dandan Bi commit e3ee8c8dbd7a9f7d7905abe17be60354c9f5f9a3 Author: duntan Date: Fri Aug 20 14:43:37 2021 +0800 .azurepipelines: Add UefiPayloadPkg in gate-build-job.yml and CISetting.py Add UefiPayloadPkg in gate-build-job.yml to enable Core ci for UefiPayloadPkg. Add UefiPayloadPkg to supported Packages in CISettings. Cc: Sean Brogan Cc: Bret Barkelew Cc: Michael D Kinney Cc: Liming Gao Signed-off-by: DunTan Reviewed-by: Liming Gao commit 63fddc98e06c380e654b1cfbaf24b9fd922adfad Author: duntan Date: Fri Aug 20 14:43:36 2021 +0800 UefiPayloadPkg: Create .yaml file in UefiPayloadPkg Create .yaml file in UefiPayloadPkg to enable Core ci for UefiPayloadPkg Cc: Guo Dong Cc: Ray Ni Cc: Maurice Ma Cc: Benjamin You Signed-off-by: DunTan Reviewed-by: Liming Gao commit 12e33dca4c0612a0975265e5ba641c6261a26455 Author: Loo, Tung Lun Date: Tue Aug 17 15:43:12 2021 +0800 IntelFsp2Pkg: Support Config File and Binary delta comparison BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3567 This patch is to enable config editor to have a new feature that can spell out the delta between the default configuration files' data, such as YAML and BSF, against the data stored in the binary. This can help users understand and track the difference when modifications are made. Cc: Maurice Ma Cc: Nate DeSimone Cc: Star Zeng Cc: Chasel Chiu Signed-off-by: Loo Tung Lun Reviewed-by: Chasel Chiu commit b170806518c1e414939c8b085866544814e1ce8e Author: Mark Wilson Date: Fri Nov 13 08:05:18 2020 +0800 UefiCpuPkg: Clean up save state boundary checks and comments. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2956 In functions ReadSaveStateRegisterByIndex and WriteSaveStateRegister: * check width > 4 instead of >= 4 when writing upper 32 bytes. - This improves the code but will not affect functionality. Cc: Eric Dong Reviewed-by: Ray Ni Signed-off-by: Mark Wilson commit 3b3f88228812e2c642eea8746858a4dad928ebf7 Author: Marvin H?user Date: Mon Aug 9 14:09:25 2021 +0800 MdeModulePkg/PiSmmCore: Drop deprecated image profiling commands The legacy codebase allowed SMM images to be registered for profiling from DXE. Support for this has been dropped entirely, so remove the remaining handlers. Cc: Jian J Wang Cc: Hao A Wu Cc: Eric Dong Reviewed-by: Ray Ni Cc: Vitaly Cheptsov Signed-off-by: Marvin H?user commit cdda3f74a1327663a5d48cca13507085ba403af7 Author: Marvin H?user Date: Mon Aug 9 03:39:53 2021 +0800 UefiPayloadPkg/UefiPayloadEntry: Fix memory corruption UefiPayloadEntry's AllocatePool() applies the "sizeof" operator to HOB index rather than the HOB header structure. This yields 4 Bytes compared to the 8 Bytes the structure header requires. Fix the call to allocate the required space instead. Reviewed-by: Guo Dong Reviewed-by: Ray Ni Cc: Maurice Ma Cc: Benjamin You Cc: Vitaly Cheptsov Signed-off-by: Marvin H?user commit 5d34cc49d5d348012fe8acf9fb618826bd541a7c Author: Wenxing Hou Date: Tue Aug 24 16:11:11 2021 +0800 UefiCpuPkg/PiSmmCpuDxeSmm: Update mPatchCetSupported set condition REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3584 Function AsmCpuid should first check the value for Basic CPUID Information. The fix is to update the mPatchCetSupported judgment statement. Signed-off-by: Wenxing Hou Reviewed-by: Ray Ni Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Cc: Sheng W Cc: Yao Jiewen commit f0fe55bca4651734abf1752a1d7c69fb5bee00b9 Author: duntan Date: Fri Aug 20 13:04:29 2021 +0800 UefiPayloadPkg: Fix the build error when enable Core ci for UefiPayloadPkg V1: Add quotes when using $(ARCH) in .dsc and .fdf file. The quotes are added due to the way by which Core ci parse the .dsc file. Add UINTN in Hob.c to fix cast from pointer to integer of different size error. V2: Delete lines which reference ShellBinPkg.The pkg doesn't exist in edk2. Cc: Guo Dong Cc: Ray Ni Cc: Maurice Ma Cc: Benjamin You Signed-off-by: DunTan Reviewed-by: Ray Ni commit 9f3eda177a4b2d4a33ff1b0307cad42906396562 Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:29:48 2021 +0800 OvmfPkg/OvmfXen: add QemuKernelLoaderFsDxe Without QemuKernelLoaderFsDxe, QemuLoadKernelImage() couldn't download the kernel, initrd, and kernel command line from QEMU's fw_cfg. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3574 Signed-off-by: Gary Lin Acked-by: Anthony PERARD Reviewed-by: Philippe Mathieu-Daude Reviewed-by: Gerd Hoffmann Tested-by: Jim Fehlig commit 5b5f10d7465004e3e40ec1f50a3b490b4db595e7 Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:31:15 2021 +0800 OvmfPkg/SmmControl2Dxe: use PcdAcpiS3Enable to detect S3 support To avoid the potential inconsistency between PcdAcpiS3Enable and QemuFwCfgS3Enabled(), this commit modifies SmmControl2Dxe to detect S3 support by PcdAcpiS3Enable as modules in MdeModulePkg do. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3573 Signed-off-by: Gary Lin Reviewed-by: Gerd Hoffmann Reviewed-by: Jiewen Yao Tested-by: Jim Fehlig commit 52e2dabc0f8d3af09c213072ce8ba734302f585d Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:31:14 2021 +0800 OvmfPkg/PlatformBootManagerLib: use PcdAcpiS3Enable to detect S3 support To avoid the potential inconsistency between PcdAcpiS3Enable and QemuFwCfgS3Enabled(), this commit modifies PlatformBootManagerLib to detect S3 support by PcdAcpiS3Enable as modules in MdeModulePkg do. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3573 Signed-off-by: Gary Lin Reviewed-by: Gerd Hoffmann Reviewed-by: Jiewen Yao Tested-by: Jim Fehlig commit 28152333bccb778b62e6e97446b28bfa0e92ef82 Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:31:13 2021 +0800 OvmfPkg/LockBoxLib: use PcdAcpiS3Enable to detect S3 support To avoid the potential inconsistency between PcdAcpiS3Enable and QemuFwCfgS3Enabled(), this commit modifies LockBoxLib to detect S3 support by PcdAcpiS3Enable as modules in MdeModulePkg do. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3573 Signed-off-by: Gary Lin Reviewed-by: Philippe Mathieu-Daude Reviewed-by: Gerd Hoffmann Reviewed-by: Jiewen Yao Tested-by: Jim Fehlig commit cb0d24637dfdd869618b9635dfb8e3b0746393a6 Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:31:12 2021 +0800 OvmfPkg/OvmfXen: set PcdAcpiS3Enable at initialization There are several functions in OvmfPkg/Library using QemuFwCfgS3Enabled() to detect the S3 support status. However, in MdeModulePkg, PcdAcpiS3Enable is used to check S3 support. Since InitializeXenPlatform() didn't set PcdAcpiS3Enable as InitializePlatform() did, this made the inconsistency between drivers/functions. For example, S3SaveStateDxe checked PcdAcpiS3Enable and skipped S3BootScript because the default value is FALSE. On the other hand, PlatformBootManagerBeforeConsole() from OvmfPkg/Library called QemuFwCfgS3Enabled() and found it returned TRUE, so it invoked SaveS3BootScript(). However, S3SaveStateDxe skipped S3BootScript, so SaveS3BootScript() asserted due to EFI_NOT_FOUND. This issue mainly affects "HVM Direct Kernel Boot". When used, "fw_cfg" is enabled in QEMU and QemuFwCfgS3Enabled() returns true in that case. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3573 Signed-off-by: Gary Lin Reviewed-by: Anthony PERARD Reviewed-by: Gerd Hoffmann Reviewed-by: Jiewen Yao Tested-by: Jim Fehlig From xen-devel-bounces@lists.xenproject.org Fri Sep 03 13:26:17 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Sep 2021 13:26:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.178090.323958 (Exim 4.92) (envelope-from ) id 1mM9Cs-0001iX-U1; Fri, 03 Sep 2021 13:26:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 178090.323958; Fri, 03 Sep 2021 13:26:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mM9Cs-0001iQ-Qv; Fri, 03 Sep 2021 13:26:10 +0000 Received: by outflank-mailman (input) for mailman id 178090; Fri, 03 Sep 2021 13:26:09 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mM9Cr-0001iK-Aj for xen-devel@lists.xenproject.org; Fri, 03 Sep 2021 13:26:09 +0000 Received: from mx0b-0039f301.pphosted.com (unknown [148.163.137.242]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 7f5458c4-0cba-11ec-af16-12813bfff9fa; Fri, 03 Sep 2021 13:26:08 +0000 (UTC) Received: from pps.filterd (m0174682.ppops.net [127.0.0.1]) by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 183DEFG3022979; Fri, 3 Sep 2021 13:26:05 GMT Received: from eur04-vi1-obe.outbound.protection.outlook.com (mail-vi1eur04lp2058.outbound.protection.outlook.com [104.47.14.58]) by mx0b-0039f301.pphosted.com with ESMTP id 3aumdq01ga-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 03 Sep 2021 13:26:05 +0000 Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17) by AM0PR03MB5697.eurprd03.prod.outlook.com (2603:10a6:208:176::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.17; Fri, 3 Sep 2021 13:26:00 +0000 Received: from AM0PR03MB6324.eurprd03.prod.outlook.com ([fe80::641e:b269:6d21:b7f8]) by AM0PR03MB6324.eurprd03.prod.outlook.com ([fe80::641e:b269:6d21:b7f8%5]) with mapi id 15.20.4478.022; Fri, 3 Sep 2021 13:26:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7f5458c4-0cba-11ec-af16-12813bfff9fa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Hj1sS21G0hxhYDsmoxMrwT9Qlg7scEdPifIVtS4F3i1kjyAgNjZaMfEkPZC98nywNJs5ZTNFsQ2LKnaRB7CeC366vj3wxXc7gLe4Nx3afpUKE8OWGDUHQtkLhCkz9JZI/P452D706ok2w1ABtQtNso+BWysdA2HsqpadlPPOnynj6JsiIup+0xEevir8wJDQCvBJTwW3fVtUYl+GfSdrc9dGstZGFjzhYXJKFS7Rj/dUocg8N7bN5/t/4XpWAt+Q0te/cbMQj6ByPQinaTaSUVAifRHoJ6wo5wo+WFw5LVprUEYqJzv8pAUNORGpdQYVlLrFqxZzVWfm3FlQiYxY/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=6rcs18nY5JhoWpG4h295efE9YtJvCF4tu+ICLvI9ne4=; b=Zg1lrU1sJVm30bzA/GuYNC9PKopgFumn/Fx+rN0/sUd3fBVJEPDsvaFm/FE0cy/N8m7yL3Tmr5evelVc4EPvygDUoZeIm/e8rWYVsmQw/LrEV2zREK7cMPSiBPwiRFs+ItnUmJyOaajiEaNfjydOZAx7LYUDHFs7GNOr/1gAKjI7kQgnqR/4p+2yr6mXuW7PgvFif2p6/GgG/D5I1/lrl/984omQUhmSRVZlXLpBwUGgu5pD2gJqmlTspIS0g5wBNsoHqEZSm1Lb4sNbAQYyLdY6T1k5VSB1hBUHmdOQYSYsHnTLvecX2PvtfpFmKc0SFWWfYnoDnCmqNmQKfcwp6Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6rcs18nY5JhoWpG4h295efE9YtJvCF4tu+ICLvI9ne4=; b=s9jGv3LBmF823BNOjmQjtyYOmsotUc2G0F1Io3nvVvh7L4LxIXnfGk43lFxT8OOgiyXAiqr9ZkkuU19V1W0GRVIYnj1qDNiJbJ/DLdjOypbPRee6G9u1BA3CsaxmmJYIG98O3V3gbQ/4AOJLauR9S7yhezMMVoS4/0YOoIUP9r7nf5Ccc1NtcAt5e+MagbfhVfZhQsohihMVqLTvOBKXTdvDG0W16t6HaWz2wM4BnZhM+OKNVDdXuZ/gIRWQTVMw04InLsni8/IJW9D2ADWWmRA+my9/i7TzcJXbD6oVC8G3zhIh6XU7E9Pdtla1MsWtsOh+cHe9U7kaQKfwdK8wVA== From: Oleksandr Andrushchenko To: Jan Beulich , Oleksandr Andrushchenko CC: "julien@xen.org" , "sstabellini@kernel.org" , Oleksandr Tyshchenko , Volodymyr Babchuk , Artem Mygaiev , "roger.pau@citrix.com" , Bertrand Marquis , Rahul Singh , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH 05/11] xen/arm: Mark device as PCI while creating one Thread-Topic: [PATCH 05/11] xen/arm: Mark device as PCI while creating one Thread-Index: AQHXoJ5xoGQK6kA9E0qeGYyDKoX2LquSQMSAgAAMdoA= Date: Fri, 3 Sep 2021 13:26:00 +0000 Message-ID: <44a860ea-a93e-6167-25df-12ac0ae6e134@epam.com> References: <20210903083347.131786-1-andr2000@gmail.com> <20210903083347.131786-6-andr2000@gmail.com> <1b890e67-c907-6678-bc98-d810231d9b50@suse.com> In-Reply-To: <1b890e67-c907-6678-bc98-d810231d9b50@suse.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=epam.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 9a05e2d2-cb2d-4999-e15f-08d96ede5edc x-ms-traffictypediagnostic: AM0PR03MB5697: x-ms-exchange-transport-forked: True x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: WYBZqu6Hzj3obIrFV5DedsBYQDK7BfKPti6sZ2YpeDmiQc2rx4QfO1UsQ0mvtPgbA4JSwbdx8KL18NHgPI+eGC+ggRAwNGBjvA033fM9ptwHPAYpWvIpqufW++YCdHoWih8Ubhr84R/rZas99VwD90AjZwmZfNUCTYqoRyhbcWaC170X2+kRwfAzhYOlH7Fq5D1R30f8NlaKw/oonG+5EJPWp9vbtPh8HJ8eIuVg6utBaqNejkaXpAkQ+1WnN1Gaj+l1W2SDlqclSKBvD4rz1vcPG5vUtF/HToonl6MhclYm60b5n2UEIQV8+sW/dIHj+ZvRX/kimE89Lb191Axs+mYA7od+PeCdrvlm2aZ+aRIwcEzQT5GI6tob0rgPJf4AVn+mrQSA6nsJzu1ngVEBAocEwElI48QFWLnV+eO5Vi9ydLnbYUVnPxhiSumjCfLncAY6kew8iB05O5ciMj/X11v+Fci887qIhZdxMsRe72tmm9OqyrG02MD00FJjdfekUPNrzExGXn7kw8oELohEGW1ja337JHiKH3qDBTY6nvkets361VtR7GgqtTfXdd60DRuIz7hvoHToSMieb2OqOIEOwqvMLk9OaczmBY0c1BN+np3E3sNntrsaOpSqm84o9QoPhJI+MT0qy4Z9Q/UgtalmX/mJC9Hj5oqaFNgqCHtXlI2hjslBarFL7ZTc65RE4KL2JxUGmL096AuNdgsOORiuHnKc3AgoFzQWcgcA8ZdC+N7Fh/61NlknSshS5YdU x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(122000001)(5660300002)(38100700002)(71200400001)(31696002)(8676002)(2616005)(508600001)(38070700005)(86362001)(110136005)(54906003)(2906002)(316002)(8936002)(4744005)(66476007)(66556008)(66446008)(64756008)(26005)(186003)(36756003)(53546011)(55236004)(6486002)(4326008)(6512007)(76116006)(66946007)(31686004)(91956017)(6506007)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?SEJQSXQvM3FtMEpQbm4rUFo1c3pNN0VrbUV3VG8rTnVaYU4rWjFVOCtDZmZJ?= =?utf-8?B?VCtudnVWTEdDNHJ0NmFKdGZidWk2YVpBQUpiRGU3L1U4cnZPQzBYQThkdkNM?= =?utf-8?B?VCs4VExibGM5eEh0bmdTVFJGSXU5dzEwTjRaaUJFZ0FWSTVBOVEyM0V6Y0J6?= =?utf-8?B?Q3Vud2d1d0FCTEZvV0pPekFWQ25oTUQ4UmlvbXhGMXR1N0lZSU1ZOVE1NFNB?= =?utf-8?B?WWJjY2dva1lBRDUwVCtWRzBUeEFXaGFOcjFmM0Y2akJjMUppMTJDUjM3V2ds?= =?utf-8?B?M0pRM3FsRDVFNjBaVDF6VTI0cUg4alF1SzRwMXU1cmpYMmtGZXplMy9pODNY?= =?utf-8?B?ZUtLT2o0MWNrVjh2SFdiNjRLTDF3TmFzSFQrK3dkcE9vSGJkRDdkQmdUcnlU?= =?utf-8?B?SVhRZ01oWjc4YzhMcEVqQWRsbXFmTEJRWXkwaDNGSGF2Q3ZCZmtPUVZpYWRU?= =?utf-8?B?TG1nWXd3Y0JuZkNtQWF3Rk1LeXlaNitKbWt6dHNDKzh6d1FwZzJnem16SHpk?= =?utf-8?B?RHJLblRKVUp3Q2JPKzFNNVZXRHBaR0Y3cXBtc2NIbHErWTRuR1Nuc1Y3elQy?= =?utf-8?B?UDNiQTVGZUJJQ3VEc3pmYkFIcE55RWNLVk5YUDdEanFkblowYjNXUC82M0lR?= =?utf-8?B?N2Fad2JNSTB4Z2w2eG1QR3habWpTWEpWbVpXd083WXMyWHBURzZsZG9ac0tL?= =?utf-8?B?N0lRRzdYY3BESkxZMjVvSmxVMlVjZ0tnU3FGZHZMUXhqajBzNk9JUlVBMlE0?= =?utf-8?B?UXlnSFB2cVlSWEFjRkRyZFFtbWVSRDRvb3ZRR2FVdG5MVVhCdzlBWk8vdlJz?= =?utf-8?B?dWovc0lhTVJ6SVRpU1A2VmZkUXFrUGVwQ3hhdXBXM2lRcmFORHdhN3U5ZUJo?= =?utf-8?B?MXI1akJld2dvY1hTUjRON3plaHZjSmN3OGpCL0tZRDNQNjYrM1JyWS9rU3dO?= =?utf-8?B?TWhTVmZCNURnV0JRcWFOUUp6QTBwQXRWOGlVVVdGaE1nTFo2MWwydDEzNWpE?= =?utf-8?B?WXNrc3ZxNHNTWUo4bXF0ZjFvazVDZXk3NTh3RTNOQ3REQ1N2YmdtbkN6b2tw?= =?utf-8?B?M3FmWGlSaFRRR094cTVxMTM2NGpzME5WalREd2NMT0dPaDg2eHVEUFI3MkNy?= =?utf-8?B?c0RHVVIrRWNvRFBLSVpPcjZLcmJKYzEvOG01bzN1Uno2SDdUZmJkN1EyNWpv?= =?utf-8?B?c2hxQmR4ek9yQW5Ga3FTc3JUdkZLZ2lpc0xsaW5ZQmdaaXQwSkJXOTlEVmhs?= =?utf-8?B?ZzlqSWF5dTNkUFdteld4dm4vNlFtd1hVRDRMSkRhY1U2aUNjRFdadEhSWkJW?= =?utf-8?B?Y1RlYTVQNjdTNU9qYzNkTVBIb3FNR0FQZTdYY0k0STJqS3g3ci9DdjFQa1cy?= =?utf-8?B?Snp4TmQ1cENDOUxpUk5RVHZkRnRWeHAxMFJvZ1pDcThTVTJRRWpEeXhiaXd4?= =?utf-8?B?NUpsa1VXVUFNbnY0d0lyQzEvMWVUejE0VDlDcGdKSlA0bisrTFBNY3NESFdV?= =?utf-8?B?Mlo4ZDE1dFBONzRsYkJvR0pKTHR1TkZra2hhbUF3OTBlTm0zanA4aXFySk1j?= =?utf-8?B?bjdaK3QrWmtGK2txZS9vMmlickZBbGY5cXRGNnNsTU5janZWbWJnVHB0Q1Nm?= =?utf-8?B?c0RuaUNvcndud3NhV3NKQTcxazRmMWtPMWMvdG9JYUpUOWsyVThWWFp1bCsr?= =?utf-8?B?MkRWOGNLV0R1MlI4VGwzVjk1c2U0RDRHQ0ZTaWdvazM0SWEwb1VLZ01RKzhQ?= =?utf-8?B?Sll6bWVhUnFoekc0aUpRM3Qzb0FSejh4NUE5ZEh3cHd0RW9OZjlPNjlDL3R2?= =?utf-8?B?Y3Bmay8xODI3YU1zblphUT09?= Content-Type: text/plain; charset="utf-8" Content-ID: <8393431B4FC6854D8177E3F627909D6B@eurprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: epam.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9a05e2d2-cb2d-4999-e15f-08d96ede5edc X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Sep 2021 13:26:00.1829 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: IqmHj1XaQZUerY+KO1cpz+hYk34BfmcSrDUhSZlxnheGjnhVsCqt6GkXnR3QnahTJMYoxnEEvuR7jwHhgu096VV9VpsqzH76jTHErQo6G2gki5aOxpApEch/iM6iLbjv X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR03MB5697 X-Proofpoint-ORIG-GUID: H4sECB9vG4h-iOsAPH13KUqcJhN9pwlV X-Proofpoint-GUID: H4sECB9vG4h-iOsAPH13KUqcJhN9pwlV X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.391,FMLib:17.0.607.475 definitions=2021-09-03_05,2021-09-03_01,2020-04-07_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 spamscore=0 clxscore=1015 suspectscore=0 phishscore=0 mlxlogscore=999 impostorscore=0 adultscore=0 mlxscore=0 lowpriorityscore=0 priorityscore=1501 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2108310000 definitions=main-2109030082 DQpPbiAwMy4wOS4yMSAxNTo0MSwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDAzLjA5LjIwMjEg MTA6MzMsIE9sZWtzYW5kciBBbmRydXNoY2hlbmtvIHdyb3RlOg0KPj4gLS0tIGEveGVuL2RyaXZl cnMvcGFzc3Rocm91Z2gvcGNpLmMNCj4+ICsrKyBiL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL3Bj aS5jDQo+PiBAQCAtMTMwMSw2ICsxMzAxLDkgQEAgc3RhdGljIGludCBpb21tdV9hZGRfZGV2aWNl KHN0cnVjdCBwY2lfZGV2ICpwZGV2KQ0KPj4gICAgICAgaWYgKCAhaXNfaW9tbXVfZW5hYmxlZChw ZGV2LT5kb21haW4pICkNCj4+ICAgICAgICAgICByZXR1cm4gMDsNCj4+ICAgDQo+PiArI2lmZGVm IENPTkZJR19BUk0NCj4+ICsgICAgcGNpX3RvX2RldihwZGV2KS0+dHlwZSA9IERFVl9QQ0k7DQo+ PiArI2VuZGlmDQo+IFdoeSBoZXJlIGluc3RlYWQgb2YgaW4gYWxsb2NfcGRldigpPyBUaGUgZmll bGQgc2hvdWxkIGJlIHZhbGlkIGJ5IHRoZSB0aW1lDQo+IHRoZSBuZXcgaXRlbSBnZXRzIGluc2Vy dGVkIGludG8gdGhlIHNlZ21lbnQncyBsaXN0IG9mIGRldmljZXMsIGltby4NCg0KWWVzLCBtYWtl cyBzZW5zZS4NCg0KVGhhbmsgeW91LA0KDQpPbGVrc2FuZHINCg0KPg0KPiBKYW4NCj4= From xen-devel-bounces@lists.xenproject.org Fri Sep 03 13:40:00 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Sep 2021 13:40:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.178100.323969 (Exim 4.92) (envelope-from ) id 1mM9QC-0003Tz-8g; Fri, 03 Sep 2021 13:39:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 178100.323969; Fri, 03 Sep 2021 13:39:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mM9QC-0003Ts-5E; Fri, 03 Sep 2021 13:39:56 +0000 Received: by outflank-mailman (input) for mailman id 178100; Fri, 03 Sep 2021 13:39:55 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mM9QB-0003Ti-F6; Fri, 03 Sep 2021 13:39:55 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mM9QA-0005J7-W1; Fri, 03 Sep 2021 13:39:55 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mM9QA-0005gy-If; Fri, 03 Sep 2021 13:39:54 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mM9QA-0002vK-IB; Fri, 03 Sep 2021 13:39:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Gkwxrc440Tl5r1hYdJc5VfuLuzN27s7TC6KzhzIsknM=; b=VKVqfpdFUtQ16UiHbR0kf7b1b+ LY9aNY2EaA5MxJOum5Y3qe41W4UxfuREREQ5Aty5ks0KBAimPucVLnan4coRvR4HZvZjZTB28fi6W izvQsbCT8tFGf9y5nhTiFKux8BaqR8twKdbWwb6PoEptBA9pi3HHplSRO2aruC+JrXUs=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 164791: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-i386-xl-qemut-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-examine:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-i386-xl-raw:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-pvshim:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-i386:xen-install:fail:regression linux-linus:test-amd64-i386-xl-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ovmf-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-coresched-i386-xl:xen-install:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-amd64-amd64-qemuu-freebsd11-amd64:guest-localmigrate/x10:fail:regression linux-linus:test-arm64-arm64-xl-credit1:debian-fixup:fail:regression linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-thunderx:debian-fixup:fail:regression linux-linus:test-arm64-arm64-xl:debian-fixup:fail:regression linux-linus:test-arm64-arm64-xl-xsm:debian-fixup:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:debian-fixup:fail:regression linux-linus:test-amd64-amd64-examine:memdisk-try-append:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=a9c9a6f741cdaa2fa9ba24a790db8d07295761e3 X-Osstest-Versions-That: linux=deacdb3e3979979016fcd0ffd518c320a62ad166 From: osstest service owner Date: Fri, 03 Sep 2021 13:39:54 +0000 flight 164791 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/164791/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemut-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-examine 6 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-i386-xl-raw 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-pvshim 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-i386 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ovmf-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-coresched-i386-xl 7 xen-install fail REGR. vs. 152332 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 152332 test-arm64-arm64-examine 8 reboot fail REGR. vs. 152332 test-amd64-amd64-qemuu-freebsd11-amd64 19 guest-localmigrate/x10 fail REGR. vs. 152332 test-arm64-arm64-xl-credit1 13 debian-fixup fail REGR. vs. 152332 test-armhf-armhf-xl-arndale 8 xen-boot fail REGR. vs. 152332 test-arm64-arm64-xl-thunderx 13 debian-fixup fail REGR. vs. 152332 test-arm64-arm64-xl 13 debian-fixup fail REGR. vs. 152332 test-arm64-arm64-xl-xsm 13 debian-fixup fail REGR. vs. 152332 test-arm64-arm64-libvirt-xsm 13 debian-fixup fail REGR. vs. 152332 test-amd64-amd64-examine 4 memdisk-try-append fail REGR. vs. 152332 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 152332 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 152332 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152332 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152332 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 152332 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152332 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152332 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: linux a9c9a6f741cdaa2fa9ba24a790db8d07295761e3 baseline version: linux deacdb3e3979979016fcd0ffd518c320a62ad166 Last test of basis 152332 2020-07-31 19:41:23 Z 398 days Failing since 152366 2020-08-01 20:49:34 Z 397 days 689 attempts Testing same since 164791 2021-09-03 04:54:46 Z 0 days 1 attempts ------------------------------------------------------------ 7181 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl fail test-armhf-armhf-xl pass test-amd64-i386-xl fail test-amd64-coresched-i386-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm fail test-amd64-i386-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm fail test-amd64-i386-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 fail test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine pass test-arm64-arm64-examine fail test-armhf-armhf-examine pass test-amd64-i386-examine fail test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel fail test-amd64-i386-qemuu-rhel6hvm-intel fail test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair fail test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow fail test-arm64-arm64-xl-thunderx fail test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2197963 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Sep 03 13:53:08 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Sep 2021 13:53:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.178110.323983 (Exim 4.92) (envelope-from ) id 1mM9cn-000650-As; Fri, 03 Sep 2021 13:52:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 178110.323983; Fri, 03 Sep 2021 13:52:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mM9cn-00064t-60; Fri, 03 Sep 2021 13:52:57 +0000 Received: by outflank-mailman (input) for mailman id 178110; Fri, 03 Sep 2021 13:52:56 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mM9cm-00064n-8H for xen-devel@lists.xenproject.org; Fri, 03 Sep 2021 13:52:56 +0000 Received: from mail-il1-x131.google.com (unknown [2607:f8b0:4864:20::131]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id c665ad12-4d74-43bb-9d32-d5cdc038559c; Fri, 03 Sep 2021 13:52:55 +0000 (UTC) Received: by mail-il1-x131.google.com with SMTP id h29so5288303ila.2 for ; Fri, 03 Sep 2021 06:52:55 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c665ad12-4d74-43bb-9d32-d5cdc038559c DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=mime-version:from:date:message-id:subject:to:cc; bh=LcflHDuWnt22drIHcdo3+GFGrkeK5QWOt9ac+oMd6kE=; b=eXkEl7Rm2aiiik4kPHuU4F1OnGGRqiaujgiCkqGXG0cpstYFYWa8wiKzdF0RReoPFJ 8D9vFRc1d2VIkVdGREBEq3UOxb/qRHAhDVT94fPuqr1Q+3f2R6fQ8yy+KR+NxRQFtBme a3toHvO3iNa4cOQf0GChUAxiu3HF9IFfcwHhU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=LcflHDuWnt22drIHcdo3+GFGrkeK5QWOt9ac+oMd6kE=; b=tK/UOLulv7akLzkTJoQusSNUlKQl/DaoI2tS75dXzOWa09tYJ/Q50uoZiBroxWvfTL IQUY9faZ1pB/AmmsA5aNz6aw5uqli1j1g03EGwdrR+qwYFWyzwpFJ2Z+6GvnFt3XIM8/ 7oUN1asr+CP0HPqOrnzwt07Q6iNOEMUFOfyfW85PYx/QcrGv3wF2YCf9XRHPUqq0F+OT 9Cg2jgDsDIZRP9w42dNHCUF+4vBFAwlFrtfcwzLlJ8k2BBdMhUnSsy+5klcraHg6RfRm ZFZhfDK86CtRgUnkcedxKtEJDKKGBQo0fmu9yCT8Dtnv6/BEwFjtZiuWvNQ+E1pd4+l9 Taww== X-Gm-Message-State: AOAM531MFjGaPic4U7v+PpPlcFYmoRwDDixrh3ErG6ui6GEvVlCbuWdT wDUJ2tbgHXTw5CgRDd6jUiYwBKPDDtFSn64UQq13MQ== X-Google-Smtp-Source: ABdhPJx3adAS9hhK6cug5GLkwtGb1nPGLwRZ3S7Xjvj3gZC2aZvuo61R2uUSFjXy5lPujr2imEgnPUxbp5R9ru3PLIU= X-Received: by 2002:a05:6e02:1353:: with SMTP id k19mr2671451ilr.157.1630677174665; Fri, 03 Sep 2021 06:52:54 -0700 (PDT) MIME-Version: 1.0 From: Ashley Weltz Date: Fri, 3 Sep 2021 09:52:43 -0400 Message-ID: Subject: Call for agenda items for September 7th Community Call @ 1500 UTC To: amit@infradead.org, andrew.cooper3@citrix.com, Artem_Mygaiev@epam.com, ash.j.wilding@gmail.com, ben@exotanium.io, bobby.eshleman@gmail.com, brendank310@gmail.com, brian.woods@xilinx.com, cardoe@cardoe.com, christopher.w.clark@gmail.com, Corey Minyard , daniel.kiper@oracle.com, deepthi.m@ltts.com, dpsmith@apertussolutions.com, dwmw@amazon.co.uk, edgar.iglesias@xilinx.com, Ian.Jackson@citrix.com, insurgo@riseup.net, intel-xen@intel.com, Jarvis.Roach@dornerworks.com, Jeff.Kubascik@dornerworks.com, jgross@suse.com, john.ji@intel.com, julien@xen.org, kevin.pearson@ortmanconsulting.com, Matt.Spencer@arm.com, =?UTF-8?Q?Mirela_Simonovi=C4=87?= , oleksandr_andrushchenko@epam.com, oleksandr_tyshchenko@epam.com, olivier.lambert@vates.fr, pdurrant@amazon.com, persaur@gmail.com, piotr.krol@3mdeb.com, Rahul.Singh@arm.com, rianquinn@gmail.com, rob.townley@gmail.com, robin.randhawa@arm.com, roger.pau@citrix.com, scottwd@gmail.com, sergey.dyasli@citrix.com, sstabellini@kernel.org, Stewart.Hildebrand@dornerworks.com, tamas.k.lengyel@gmail.com, varadgautam@gmail.com, volodymyr_babchuk@epam.com, wl@xen.org Cc: xen-devel@lists.xenproject.org Content-Type: multipart/alternative; boundary="000000000000bd5c6605cb179deb" --000000000000bd5c6605cb179deb Content-Type: text/plain; charset="UTF-8" Hi everyone, Our next meeting is this upcoming Tuesday at 1500 UTC. The proposed agenda is in https://cryptpad.fr/pad/#/2/pad/edit/PXjRK6mJfWbUxSNW0Qt8xOqT/. Please add or edit any items to this agenda. Alternatively, please feel free to email me directly with agenda items. Please put your name beside any items if you edit the document. We will plan to start the meeting 5 minutes past the hour. * If you want to be CC'ed please add or remove yourself from the sign-up-sheet at https://cryptpad.fr/pad/#/2/pad/edit/D9vGzihPxxAOe6RFPz0sRCf+/ Again, please let me know if you have any questions. See you on Tuesday! Cheers, Ashley -- Ashley Weltz, Project Coordinator The Linux Foundation aweltz@linuxfoundation.org --000000000000bd5c6605cb179deb Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi everyone,

Our next meetin= g is this upcoming Tuesday at 1500 UTC.=C2=A0

The = proposed agenda is in=C2=A0https://cryptpad.fr/pad/#/2/pad/edit/PXjRK6mJfWb= UxSNW0Qt8xOqT/. Please add or edit any items to this agenda. Alternativ= ely, please feel free to email me directly with agenda items.=C2=A0

Please put your name beside any items if you edit the document.
<= br>We will plan to start the meeting 5 minutes past the hour.=C2=A0

= * If you want to be CC'ed please add or remove yourself from the sign-u= p-sheet at=C2=A0https://cryptpad.fr/pa= d/#/2/pad/edit/D9vGzihPxxAOe6RFPz0sRCf+/

Again= , please let me know if you have any questions. See you on Tuesday!

Cheers,
Ashley

--
Ashley Weltz, Project Coordinator=C2=A0
The Linux Founda= tion
--000000000000bd5c6605cb179deb-- From xen-devel-bounces@lists.xenproject.org Fri Sep 03 15:06:54 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Sep 2021 15:06:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.178120.323994 (Exim 4.92) (envelope-from ) id 1mMAm8-0005l6-P3; Fri, 03 Sep 2021 15:06:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 178120.323994; Fri, 03 Sep 2021 15:06:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMAm8-0005kz-LT; Fri, 03 Sep 2021 15:06:40 +0000 Received: by outflank-mailman (input) for mailman id 178120; Fri, 03 Sep 2021 15:06:40 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMAm7-0005kt-Nt for xen-devel@lists.xenproject.org; Fri, 03 Sep 2021 15:06:39 +0000 Received: from sender4-of-o51.zoho.com (unknown [136.143.188.51]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id c2c0082e-686b-4760-b90e-0f7fdcb53c2d; Fri, 03 Sep 2021 15:06:38 +0000 (UTC) Received: from sisyou.hme. (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1630681592656284.14797840719837; Fri, 3 Sep 2021 08:06:32 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c2c0082e-686b-4760-b90e-0f7fdcb53c2d ARC-Seal: i=1; a=rsa-sha256; t=1630681596; cv=none; d=zohomail.com; s=zohoarc; b=E2oZLva+iHX9+Zc88gM7a7iGmT8mb9EStMMvtU73/v3qRt+V+muRRXZw12qB5H+sNR+05kxZU1rfEd8iEAFhHsJggDyk7PTTFHm/28TIKSEONkZELEVtZ9A+3qHlyjiUvpuqBomYG4ZgaiArsUYBelM6VcAciOvKIGEmv2Z15Nk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1630681596; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:MIME-Version:Message-ID:Subject:To; bh=DY8SumKHy69+y3Ky8ZXpZgjykeZw2efDQnmXyQdCT7I=; b=KzC69ufgi3jJTaSVSrXTOevHYq2d/Sx2ojmKZ3PsXiBsmc5bDjT4GCk6lxtL9j14ALyZ2KhQ9GEpYFsqy2cunu2hT/Zl56eTVasu/I0jIAJW6zHxQwacDJlEEv9lsFczrSfgHqowhzSpCyAH2EoLFR74cMWGpHl8T8xDioQ+ehs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1630681596; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version:Content-Type:Content-Transfer-Encoding; bh=DY8SumKHy69+y3Ky8ZXpZgjykeZw2efDQnmXyQdCT7I=; b=csHVsu2HGGmCXToKfqdM5cZAqNkSdhU0AnJAka7lU2tQX30O9p4ZE5KcnwUzhTfH /yNdQaj8UePYzjJ57chw/dbmLNY1IaRGOxBOtpoUcDilRvIOvW5ccyH2HOj6LNRF6bk zAmhlLuo01z5G+TRTQuitv1iSvRV/YzP7DG4QdeA= From: "Daniel P. Smith" To: xen-devel@lists.xenproject.org Cc: "Daniel P. Smith" Subject: [PATCH v4 00/11] xsm: refactoring xsm hooks Date: Fri, 3 Sep 2021 15:06:18 -0400 Message-Id: <20210903190629.11917-1-dpsmith@apertussolutions.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ZohoMailClient: External Based on feedback from 2021 Xen Developers Summit the xsm-roles RFC patch set is being split into two separate patch sets. This is the first patch set and is focused purely on the clean up and refactoring of the XSM hooks. This patch set refactors the xsm_ops wrapper hooks to use the alternative_call infrastructure. Then proceeds to move and realign the headers to simplify the unnecessarily complicated header inclusions, remove the facad of being able to enable/disable XSM, and simplify the XSM hooks down to a single interface and implementation. The remainder of the changes are clean up and removing no longer necessary abstractions. v2: - restructured the patches, breaking them up as needed - incorporate Andrew Cooper's alternative call common code - change XSM module registration, removing register_xsm - incoporate KConfig recommendations - reworded commit messages - incorporate macro expansion recommendations - misc clean-up fallout from recommendations v3: - renamed struct xsm_operations to struct xsm_ops - flask and silo ops structs made __initconst - fixed misplacement of __init on flask/silo_init - lots of coding style alignment - further clean up from FLASK_DISABLE removal - addressed commit message comments - removed missed guard around alternative-call include - reworked approach to XSM hooks, merging the two interfaces instead of dropping one v4: - make __alt_call_maybe_initdata resolve to __read_mostly when CONFIG_ALTERNATIVE_CALL is not set - removed the masking of void with xsm_op_t - moved all the coding style conformity to an early commit - fixed declaration on real and stub declarations in xsm.h - corrected to __initconstrel - made the xsm_ops global __read_mostly - adjusted blank lines in xsm_ops struct to provide consistent grouping - moved extern references to built in policy to where they are used - Added back in the #ifdef CONFIG_XSM into struct evtchn - split the patch removing the duplicate interface up further Andrew Cooper (1): xen: Implement xen/alternative-call.h for use in common code Daniel P. Smith (10): xsm: remove the ability to disable flask xsm: drop dubious xsm_op_t type xsm: apply coding style xsm: refactor xsm_ops handling xsm: convert xsm_ops hook calls to alternative call xsm: decouple xsm header inclusion selection xsm: drop generic event channel labeling exclusion silo: remove circular xsm hook call kconfig: update xsm config to reflect reality xsm: remove alternate xsm hook interface xen/arch/x86/Kconfig | 1 + xen/common/Kconfig | 52 +- xen/include/public/xsm/flask_op.h | 2 +- xen/include/xen/alternative-call.h | 63 +++ xen/include/xen/hypercall.h | 4 +- xen/include/xen/sched.h | 4 +- xen/include/xsm/dummy.h | 774 --------------------------- xen/include/xsm/xsm-core.h | 273 ++++++++++ xen/include/xsm/xsm.h | 804 +++++++++++++---------------- xen/xsm/Makefile | 4 +- xen/xsm/dummy.c | 7 +- xen/xsm/dummy.h | 739 ++++++++++++++++++++++++++ xen/xsm/flask/flask_op.c | 32 +- xen/xsm/flask/hooks.c | 16 +- xen/xsm/silo.c | 25 +- xen/xsm/xsm_core.c | 94 ++-- 16 files changed, 1535 insertions(+), 1359 deletions(-) create mode 100644 xen/include/xen/alternative-call.h delete mode 100644 xen/include/xsm/dummy.h create mode 100644 xen/include/xsm/xsm-core.h create mode 100644 xen/xsm/dummy.h -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Fri Sep 03 15:06:54 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Sep 2021 15:06:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.178121.324005 (Exim 4.92) (envelope-from ) id 1mMAmF-00062h-7U; Fri, 03 Sep 2021 15:06:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 178121.324005; Fri, 03 Sep 2021 15:06:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMAmF-00062a-4U; Fri, 03 Sep 2021 15:06:47 +0000 Received: by outflank-mailman (input) for mailman id 178121; Fri, 03 Sep 2021 15:06:45 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMAmD-000623-QD for xen-devel@lists.xenproject.org; Fri, 03 Sep 2021 15:06:45 +0000 Received: from sender4-of-o51.zoho.com (unknown [136.143.188.51]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id eb533620-ee78-4d74-8252-62769fbfdca1; Fri, 03 Sep 2021 15:06:44 +0000 (UTC) Received: from sisyou.hme. (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1630681595567909.1171948642584; Fri, 3 Sep 2021 08:06:35 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: eb533620-ee78-4d74-8252-62769fbfdca1 ARC-Seal: i=1; a=rsa-sha256; t=1630681598; cv=none; d=zohomail.com; s=zohoarc; b=W/3McJcH+hgLEXU0Oay4LDpRFo+o9UmyNcl2T52y37Pfk55++hvihDEapiW2fcK3E2TP6aO2L6B0ysCgW2ntpHS23FK7yD6D0vvRfG46mTlgklV4vSQhTN+N8kCvv5POu9lECoMuYUAVPb5PVTIKe0QsIiJsLr69AOZV8oMb0/c= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1630681598; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=FwXfAdIv2IZUMTi0r+WhHxk4n1x2ncGtKlCWXV3sMlc=; b=c8SfnD45zPwJ6Ashw9ih+Res04Da/g3ui7778oLj/rcvHtarNTDK+guDvCpcWar0Ze+kMg4B1BFOZwogPQjBOD5pae4ueq9r/ynCR71sUC5ESWGWIYQ39ogM82A/wbWoWqpY8TYsBsXXTK1G5me+uMt4eRYIuxoFMTkdu2AAkoU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1630681598; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Content-Type:Content-Transfer-Encoding; bh=FwXfAdIv2IZUMTi0r+WhHxk4n1x2ncGtKlCWXV3sMlc=; b=ZJBR/Tr+MzGvXgfIVcXhA7m7rmRYtb8FkKKBuQfAeA0npTHJWgmqWkg5/fe0StER 7+fzsDItRiLRfyqhsp+LIjygyQ2C1b3WjX/9S5TCz+z/eKRbsNv3xvvfRAvTIS3z4/v 64FEX45XVGtrIFqN1D2N7HiJGnoBPbOumzYKF2i0= From: "Daniel P. Smith" To: Wei Liu , xen-devel@lists.xenproject.org Cc: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Bob Eshleman , Alistair Francis , Connor Davis , "Daniel P . Smith" , Jan Beulich , George Dunlap , Ian Jackson Subject: [PATCH v4 01/11] xen: Implement xen/alternative-call.h for use in common code Date: Fri, 3 Sep 2021 15:06:19 -0400 Message-Id: <20210903190629.11917-2-dpsmith@apertussolutions.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210903190629.11917-1-dpsmith@apertussolutions.com> References: <20210903190629.11917-1-dpsmith@apertussolutions.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ZohoMailClient: External From: Andrew Cooper The alternative call infrastructure is x86-only for now, but the common iommu code has a variant and more common code wants to use the infrastructure. Introduce CONFIG_ALTERNATIVE_CALL and a conditional implemetnation so common code can use the optimisation when available, without requiring all architectures to implement no-op stubs. Write some documentation, which was thus far entirely absent, covering the requirements for an architecture to implement this optimsiation, and how to use the infrastructure in general code. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu CC: Stefano Stabellini CC: Julien Grall CC: Volodymyr Babchuk CC: Bob Eshleman CC: Alistair Francis CC: Connor Davis CC: Daniel P. Smith v3: * Drop __alt_call_maybe_initconst This is a pre-requisite to "xsm: refactor xsm_ops handling" to avoid breaking the ARM build. Build test for the XSM code: diff --git a/xen/xsm/xsm_core.c b/xen/xsm/xsm_core.c index 5eab21e1b168..592074e8f41c 100644 --- a/xen/xsm/xsm_core.c +++ b/xen/xsm/xsm_core.c @@ -195,6 +195,16 @@ bool __init has_xsm_magic(paddr_t start) } #endif +#include +struct foo { + int (*bar)(void *); +} foo __alt_call_maybe_initdata; + +int test_alternative_call(void) +{ + return alternative_call(foo.bar, NULL); +} + int __init register_xsm(struct xsm_operations *ops) { if ( verify(ops) ) --- xen/arch/x86/Kconfig | 1 + xen/common/Kconfig | 3 ++ xen/include/xen/alternative-call.h | 63 ++++++++++++++++++++++++++++++ 3 files changed, 67 insertions(+) create mode 100644 xen/include/xen/alternative-call.h diff --git a/xen/arch/x86/Kconfig b/xen/arch/x86/Kconfig index 9b164db641..1f83518ee0 100644 --- a/xen/arch/x86/Kconfig +++ b/xen/arch/x86/Kconfig @@ -6,6 +6,7 @@ config X86 def_bool y select ACPI select ACPI_LEGACY_TABLES_LOOKUP + select ALTERNATIVE_CALL select ARCH_SUPPORTS_INT128 select CORE_PARKING select HAS_ALTERNATIVE diff --git a/xen/common/Kconfig b/xen/common/Kconfig index 0ddd18e11a..ac5491b1cc 100644 --- a/xen/common/Kconfig +++ b/xen/common/Kconfig @@ -22,6 +22,9 @@ config GRANT_TABLE If unsure, say Y. +config ALTERNATIVE_CALL + bool + config HAS_ALTERNATIVE bool diff --git a/xen/include/xen/alternative-call.h b/xen/include/xen/alternative-call.h new file mode 100644 index 0000000000..d10af90b1b --- /dev/null +++ b/xen/include/xen/alternative-call.h @@ -0,0 +1,63 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +#ifndef XEN_ALTERNATIVE_CALL +#define XEN_ALTERNATIVE_CALL + +/* + * Some subsystems in Xen may have multiple implementions, which can be + * resolved to a single implementation at boot time. By default, this will + * result in the use of function pointers. + * + * Some architectures may have mechanisms for dynamically modifying .text. + * Using this mechnaism, function pointers can be converted to direct calls + * which are typically more efficient at runtime. + * + * For architectures to support: + * + * - Implement alternative_{,v}call() in asm/alternative.h. Code generation + * requirements are to emit a function pointer call at build time, and stash + * enough metadata to simplify the call at boot once the implementation has + * been resolved. + * - Select ALTERNATIVE_CALL in Kconfig. + * + * To use: + * + * Consider the following simplified example. + * + * 1) struct foo_ops __alt_call_maybe_initdata ops; + * + * 2) const struct foo_ops __initconst foo_a_ops = { ... }; + * const struct foo_ops __initconst foo_b_ops = { ... }; + * + * void foo_init(void) + * { + * ... + * if ( use_impl_a ) + * ops = *foo_a_ops; + * else if ( use_impl_b ) + * ops = *foo_b_ops; + * ... + * } + * + * 3) alternative_call(ops.bar, ...); + * + * There needs to a single ops object (1) which will eventually contain the + * function pointers. This should be populated in foo's init() function (2) + * by one of the available implementations. To call functions, use + * alternative_{,v}call() referencing the main ops object (3). + */ + +#ifdef CONFIG_ALTERNATIVE_CALL + +#include + +#define __alt_call_maybe_initdata __initdata + +#else + +#define alternative_call(func, args...) (func)(args) +#define alternative_vcall(func, args...) (func)(args) + +#define __alt_call_maybe_initdata __read_mostly + +#endif /* !CONFIG_ALTERNATIVE_CALL */ +#endif /* XEN_ALTERNATIVE_CALL */ -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Fri Sep 03 15:07:02 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Sep 2021 15:07:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.178123.324016 (Exim 4.92) (envelope-from ) id 1mMAmU-0006XF-Gt; Fri, 03 Sep 2021 15:07:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 178123.324016; Fri, 03 Sep 2021 15:07:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMAmU-0006X1-Cb; Fri, 03 Sep 2021 15:07:02 +0000 Received: by outflank-mailman (input) for mailman id 178123; Fri, 03 Sep 2021 15:07:01 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMAmT-0006Uj-CA for xen-devel@lists.xenproject.org; Fri, 03 Sep 2021 15:07:01 +0000 Received: from sender4-of-o51.zoho.com (unknown [136.143.188.51]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 2caff1e1-690e-4e43-9507-43e8276cac68; Fri, 03 Sep 2021 15:06:59 +0000 (UTC) Received: from sisyou.hme. (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1630681598091395.8657927244592; Fri, 3 Sep 2021 08:06:38 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2caff1e1-690e-4e43-9507-43e8276cac68 ARC-Seal: i=1; a=rsa-sha256; t=1630681600; cv=none; d=zohomail.com; s=zohoarc; b=U3YG+tLKobR9wflqy2s9fIoOx+VtYcW5kHkGPVrruLfA5AmQYbCGTZ2kfX5OTEX7QllGconwszVSbOFbPSasY0pkC00SAZgkD2tR/WxR6z6yE/50339vyAAjCNsm41B7ls5bc+D/Z70PJ1SCx/1uF4nro/QKERAvlhU8Mo10DUU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1630681600; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=tSLACVHOio6zEEE9Ar9yJitpL6mvf0UNHFD+1CvJyII=; b=fM9UiAmm8+W9UiDy0mLksHjNJq7t6/45SznVb0C/QO4mS06XgIkHM4g0i1AJ1cW9H14U3QOKj3sJtb6urbfus81OnuOd8Sro1ePhCHcamy7PokGJ5IIhISHIBww5S+qRblyVf9tSuDe/irGwk0QEcRMwiHqumCJ2Gdqmyq1Lmrw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1630681600; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding; bh=tSLACVHOio6zEEE9Ar9yJitpL6mvf0UNHFD+1CvJyII=; b=T7PxN4luxUgXYnC/GptfidDpQ8Qzr0aulBWZJ3lRiJEPb26P727ADdLOugwz77I8 7XQT64jzSaJHgVxziOna40GDQaOyTy7E7oj2FKoofDFGVx4savVmrnSguRUjnlst4xT 18yUymTBZTuvBiKa+t9oIPg4NTYN+Cr7Op/JAMGk= From: "Daniel P. Smith" To: "Daniel P. Smith" , xen-devel@lists.xenproject.org Cc: Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Daniel De Graaf Subject: [PATCH v4 02/11] xsm: remove the ability to disable flask Date: Fri, 3 Sep 2021 15:06:20 -0400 Message-Id: <20210903190629.11917-3-dpsmith@apertussolutions.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210903190629.11917-1-dpsmith@apertussolutions.com> References: <20210903190629.11917-1-dpsmith@apertussolutions.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-ZohoMailClient: External On Linux when SELinux is put into permissive mode the descretionary access controls are still in place. Whereas for Xen when the enforcing state of flask is set to permissive, all operations for all domains would succeed, i.e. it does not fall back to the default access controls. To provide a means to mimic a similar but not equivalent behavior, a flask op is present to allow a one-time switch back to the default access controls, aka the "dummy policy". While this may be desirable for an OS, Xen is a hypervisor and should not allow the switching of which security policy framework is being enforced after boot. This patch removes the flask op to enforce the desired XSM usage model requiring a reboot of Xen to change the XSM policy module in use. Signed-off-by: Daniel P. Smith --- xen/include/public/xsm/flask_op.h | 2 +- xen/xsm/flask/flask_op.c | 30 ------------------------------ 2 files changed, 1 insertion(+), 31 deletions(-) diff --git a/xen/include/public/xsm/flask_op.h b/xen/include/public/xsm/flask_op.h index 16af7bc22f..b41dd6dac8 100644 --- a/xen/include/public/xsm/flask_op.h +++ b/xen/include/public/xsm/flask_op.h @@ -188,7 +188,7 @@ struct xen_flask_op { #define FLASK_SETBOOL 12 #define FLASK_COMMITBOOLS 13 #define FLASK_MLS 14 -#define FLASK_DISABLE 15 +#define FLASK_DISABLE 15 /* No longer implemented */ #define FLASK_GETAVC_THRESHOLD 16 #define FLASK_SETAVC_THRESHOLD 17 #define FLASK_AVC_HASHSTATS 18 diff --git a/xen/xsm/flask/flask_op.c b/xen/xsm/flask/flask_op.c index 01e52138a1..f41c025391 100644 --- a/xen/xsm/flask/flask_op.c +++ b/xen/xsm/flask/flask_op.c @@ -223,32 +223,6 @@ static int flask_security_sid(struct xen_flask_sid_context *arg) #ifndef COMPAT -static int flask_disable(void) -{ - static int flask_disabled = 0; - - if ( ss_initialized ) - { - /* Not permitted after initial policy load. */ - return -EINVAL; - } - - if ( flask_disabled ) - { - /* Only do this once. */ - return -EINVAL; - } - - printk("Flask: Disabled at runtime.\n"); - - flask_disabled = 1; - - /* Reset xsm_ops to the original module. */ - xsm_ops = &dummy_xsm_ops; - - return 0; -} - static int flask_security_setavc_threshold(struct xen_flask_setavc_threshold *arg) { int rv = 0; @@ -698,10 +672,6 @@ ret_t do_flask_op(XEN_GUEST_HANDLE_PARAM(xsm_op_t) u_flask_op) rv = flask_mls_enabled; break; - case FLASK_DISABLE: - rv = flask_disable(); - break; - case FLASK_GETAVC_THRESHOLD: rv = avc_cache_threshold; break; -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Fri Sep 03 15:07:20 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Sep 2021 15:07:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.178134.324027 (Exim 4.92) (envelope-from ) id 1mMAmm-0007IV-PL; Fri, 03 Sep 2021 15:07:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 178134.324027; Fri, 03 Sep 2021 15:07:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMAmm-0007IO-Lz; Fri, 03 Sep 2021 15:07:20 +0000 Received: by outflank-mailman (input) for mailman id 178134; Fri, 03 Sep 2021 15:07:19 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMAml-0006va-Rx for xen-devel@lists.xenproject.org; Fri, 03 Sep 2021 15:07:19 +0000 Received: from sender4-of-o51.zoho.com (unknown [136.143.188.51]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 9fa6f2f5-0cc8-11ec-af2e-12813bfff9fa; Fri, 03 Sep 2021 15:07:16 +0000 (UTC) Received: from sisyou.hme. (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1630681600351351.4561344219063; Fri, 3 Sep 2021 08:06:40 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9fa6f2f5-0cc8-11ec-af2e-12813bfff9fa ARC-Seal: i=1; a=rsa-sha256; t=1630681602; cv=none; d=zohomail.com; s=zohoarc; b=jLx1FP5XMnBmH5Si8hAulIa6JYl7fcmWYjOQ46NGOvzlpYLnRpCNnHR54O68cprM79eWlwviqKpch+ek4arkyUjp0FlMbanY+i8CZCTaX5NjJSP3gbMS4/0Ocov1rY2EWcTzJdOhGHyC8RXr5T+fxH9P6FEYu/pO9GJDqhLLTKA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1630681602; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=6kGTTbjxT8L+j+0w8ftNK7DzfHzYGwCxPp/WOutTjVk=; b=O6Ge//VArCi2Jmd0u/I1nj1a0Q3s8PsCN6GQhl4GE482Vr/4DH1rEqJTjJ/KQgA+hf+MP8+zfC4qVqnoKWx+6vgjHkhimeEdo0z2/WBTnJbdXdzY7Q++wwkUXbQvcIoi/+/FQx7U504KXazryx1F5pLCNQAjmvA5fZGaw6D73QU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1630681602; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding; bh=6kGTTbjxT8L+j+0w8ftNK7DzfHzYGwCxPp/WOutTjVk=; b=dyN+y7sLq+jzU7UE4JdsQTqZvDGIg+bRTTTykR+cDqumvfRvu+M7gZgKxN0fGxns hgOcqVhMn8BpZvEAQNprwiopsv4PcZUwyZL7d/+xsvff3ChSbaIaE+cO2wPrCuZ6B4u AFIbtN6DHIDT5QmucsfDJUrswDdU8mUmJ09TyIhM= From: "Daniel P. Smith" To: "Daniel P. Smith" , xen-devel@lists.xenproject.org Cc: Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Daniel De Graaf Subject: [PATCH v4 03/11] xsm: drop dubious xsm_op_t type Date: Fri, 3 Sep 2021 15:06:21 -0400 Message-Id: <20210903190629.11917-4-dpsmith@apertussolutions.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210903190629.11917-1-dpsmith@apertussolutions.com> References: <20210903190629.11917-1-dpsmith@apertussolutions.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-ZohoMailClient: External The type xsm_op_t masks the use of void pointers. This commit drops the xsm_op_t type and replaces it and all its uses with an explicit void. Signed-off-by: Daniel P. Smith --- xen/include/xen/hypercall.h | 4 ++-- xen/include/xsm/dummy.h | 4 ++-- xen/include/xsm/xsm.h | 11 ++++------- xen/xsm/flask/flask_op.c | 2 +- xen/xsm/flask/hooks.c | 4 ++-- xen/xsm/xsm_core.c | 4 ++-- 6 files changed, 13 insertions(+), 16 deletions(-) diff --git a/xen/include/xen/hypercall.h b/xen/include/xen/hypercall.h index 34b7f1fed6..3771487a30 100644 --- a/xen/include/xen/hypercall.h +++ b/xen/include/xen/hypercall.h @@ -127,7 +127,7 @@ do_kexec_op( extern long do_xsm_op( - XEN_GUEST_HANDLE_PARAM(xsm_op_t) u_xsm_op); + XEN_GUEST_HANDLE_PARAM(void) u_xsm_op); #ifdef CONFIG_ARGO extern long do_argo_op( @@ -198,7 +198,7 @@ compat_set_timer_op( s32 hi); extern int compat_xsm_op( - XEN_GUEST_HANDLE_PARAM(xsm_op_t) op); + XEN_GUEST_HANDLE_PARAM(void) op); extern int compat_kexec_op(unsigned long op, XEN_GUEST_HANDLE_PARAM(void) uarg); diff --git a/xen/include/xsm/dummy.h b/xen/include/xsm/dummy.h index 363c6d7798..214b5408b1 100644 --- a/xen/include/xsm/dummy.h +++ b/xen/include/xsm/dummy.h @@ -442,13 +442,13 @@ static XSM_INLINE int xsm_hypfs_op(XSM_DEFAULT_VOID) return xsm_default_action(action, current->domain, NULL); } -static XSM_INLINE long xsm_do_xsm_op(XEN_GUEST_HANDLE_PARAM(xsm_op_t) op) +static XSM_INLINE long xsm_do_xsm_op(XEN_GUEST_HANDLE_PARAM(void) op) { return -ENOSYS; } #ifdef CONFIG_COMPAT -static XSM_INLINE int xsm_do_compat_op(XEN_GUEST_HANDLE_PARAM(xsm_op_t) op) +static XSM_INLINE int xsm_do_compat_op(XEN_GUEST_HANDLE_PARAM(void) op) { return -ENOSYS; } diff --git a/xen/include/xsm/xsm.h b/xen/include/xsm/xsm.h index ad3cddbf7d..9872bae502 100644 --- a/xen/include/xsm/xsm.h +++ b/xen/include/xsm/xsm.h @@ -18,9 +18,6 @@ #include #include -typedef void xsm_op_t; -DEFINE_XEN_GUEST_HANDLE(xsm_op_t); - /* policy magic number (defined by XSM_MAGIC) */ typedef u32 xsm_magic_t; @@ -129,9 +126,9 @@ struct xsm_operations { int (*page_offline)(uint32_t cmd); int (*hypfs_op)(void); - long (*do_xsm_op) (XEN_GUEST_HANDLE_PARAM(xsm_op_t) op); + long (*do_xsm_op) (XEN_GUEST_HANDLE_PARAM(void) op); #ifdef CONFIG_COMPAT - int (*do_compat_op) (XEN_GUEST_HANDLE_PARAM(xsm_op_t) op); + int (*do_compat_op) (XEN_GUEST_HANDLE_PARAM(void) op); #endif int (*hvm_param) (struct domain *d, unsigned long op); @@ -543,13 +540,13 @@ static inline int xsm_hypfs_op(xsm_default_t def) return xsm_ops->hypfs_op(); } -static inline long xsm_do_xsm_op (XEN_GUEST_HANDLE_PARAM(xsm_op_t) op) +static inline long xsm_do_xsm_op (XEN_GUEST_HANDLE_PARAM(void) op) { return xsm_ops->do_xsm_op(op); } #ifdef CONFIG_COMPAT -static inline int xsm_do_compat_op (XEN_GUEST_HANDLE_PARAM(xsm_op_t) op) +static inline int xsm_do_compat_op (XEN_GUEST_HANDLE_PARAM(void) op) { return xsm_ops->do_compat_op(op); } diff --git a/xen/xsm/flask/flask_op.c b/xen/xsm/flask/flask_op.c index f41c025391..221ff00fd3 100644 --- a/xen/xsm/flask/flask_op.c +++ b/xen/xsm/flask/flask_op.c @@ -607,7 +607,7 @@ static int flask_relabel_domain(struct xen_flask_relabel *arg) #endif /* !COMPAT */ -ret_t do_flask_op(XEN_GUEST_HANDLE_PARAM(xsm_op_t) u_flask_op) +ret_t do_flask_op(XEN_GUEST_HANDLE_PARAM(void) u_flask_op) { xen_flask_op_t op; int rv; diff --git a/xen/xsm/flask/hooks.c b/xen/xsm/flask/hooks.c index f1a1217c98..1465db125a 100644 --- a/xen/xsm/flask/hooks.c +++ b/xen/xsm/flask/hooks.c @@ -1742,8 +1742,8 @@ static int flask_argo_send(const struct domain *d, const struct domain *t) #endif -long do_flask_op(XEN_GUEST_HANDLE_PARAM(xsm_op_t) u_flask_op); -int compat_flask_op(XEN_GUEST_HANDLE_PARAM(xsm_op_t) u_flask_op); +long do_flask_op(XEN_GUEST_HANDLE_PARAM(void) u_flask_op); +int compat_flask_op(XEN_GUEST_HANDLE_PARAM(void) u_flask_op); static struct xsm_operations flask_ops = { .security_domaininfo = flask_security_domaininfo, diff --git a/xen/xsm/xsm_core.c b/xen/xsm/xsm_core.c index 5eab21e1b1..ac553f9c0d 100644 --- a/xen/xsm/xsm_core.c +++ b/xen/xsm/xsm_core.c @@ -213,13 +213,13 @@ int __init register_xsm(struct xsm_operations *ops) #endif -long do_xsm_op (XEN_GUEST_HANDLE_PARAM(xsm_op_t) op) +long do_xsm_op(XEN_GUEST_HANDLE_PARAM(void) op) { return xsm_do_xsm_op(op); } #ifdef CONFIG_COMPAT -int compat_xsm_op (XEN_GUEST_HANDLE_PARAM(xsm_op_t) op) +int compat_xsm_op(XEN_GUEST_HANDLE_PARAM(void) op) { return xsm_do_compat_op(op); } -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Fri Sep 03 15:07:38 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Sep 2021 15:07:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.178143.324038 (Exim 4.92) (envelope-from ) id 1mMAn4-0007uK-1s; Fri, 03 Sep 2021 15:07:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 178143.324038; Fri, 03 Sep 2021 15:07:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMAn3-0007uB-Uz; Fri, 03 Sep 2021 15:07:37 +0000 Received: by outflank-mailman (input) for mailman id 178143; Fri, 03 Sep 2021 15:07:37 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMAn3-0007sS-0Y for xen-devel@lists.xenproject.org; Fri, 03 Sep 2021 15:07:37 +0000 Received: from sender4-of-o51.zoho.com (unknown [136.143.188.51]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id a9ad2160-0cc8-11ec-af2e-12813bfff9fa; Fri, 03 Sep 2021 15:07:32 +0000 (UTC) Received: from sisyou.hme. (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1630681602207418.47399076829913; Fri, 3 Sep 2021 08:06:42 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a9ad2160-0cc8-11ec-af2e-12813bfff9fa ARC-Seal: i=1; a=rsa-sha256; t=1630681605; cv=none; d=zohomail.com; s=zohoarc; b=JVemV5ww9x7Ta5ZnHqAvJfb/QCcrmfwrK/HvnVFgrsgLYQ/KHrwCkGn/jvOac9kDwojSLLeWF2H8UXR+SZ7hk3U1JpWztpzjxVXjU91THB0uaUkkdv0FPmm2sssw3RCWh6odZ8caWGux0aastb2dFphwQVvD14byW8eea2kc5SQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1630681605; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=CDBkvs1fwyjC/r28e2VqrqXOwVPjbuNV/phvRXMPXyE=; b=Jh5ZtrdvP/hSdphEV2n7ZMzPPgeW/71y4Nmh80uvBRwcTbI10hiGn13swNb/OvDncHgH3yxnJWhre9cmv+DNmeufF9WpSFSbF4M6NCtHRE8siEBKpPbe9qBcJtIHm+I6BvV8SEtgwxI2CEwbHk4DbXhMtFwooY/aYUqiyT+oBCM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1630681605; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding; bh=CDBkvs1fwyjC/r28e2VqrqXOwVPjbuNV/phvRXMPXyE=; b=tqtSj6MYX7jOX8YPCzQPXmskymrz5BXh9msg9tXLNUbtAb/0FvUwb+kJRCtSElOB BtrLxiAujtO/OmjgAkz3BQVUHfZ//Y9uhPr2VyVuvPaC/zi27lCggTIZ2uxiGLs1G0Z RBWp18piZOaBxjRN2MrNxdI30pfk/s/1wzjivYPo= From: "Daniel P. Smith" To: "Daniel P. Smith" , xen-devel@lists.xenproject.org Cc: Daniel De Graaf Subject: [PATCH v4 04/11] xsm: apply coding style Date: Fri, 3 Sep 2021 15:06:22 -0400 Message-Id: <20210903190629.11917-5-dpsmith@apertussolutions.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210903190629.11917-1-dpsmith@apertussolutions.com> References: <20210903190629.11917-1-dpsmith@apertussolutions.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-ZohoMailClient: External Instead of intermixing coding style changes with code changes as they are come upon in this patch set, moving all coding style changes into a single commit. The focus of coding style changes here are, - move trailing comments to line above - ensuring line length does not exceed 80 chars - ensuring proper indentation for 80 char wrapping - covert u32 type statements to uint32_t - remove space between closing and opening parens - drop extern on function declarations Signed-off-by: Daniel P. Smith --- xen/include/xsm/dummy.h | 173 +++++++++----- xen/include/xsm/xsm.h | 494 ++++++++++++++++++++++------------------ xen/xsm/xsm_core.c | 4 +- 3 files changed, 389 insertions(+), 282 deletions(-) diff --git a/xen/include/xsm/dummy.h b/xen/include/xsm/dummy.h index 214b5408b1..deaf23035e 100644 --- a/xen/include/xsm/dummy.h +++ b/xen/include/xsm/dummy.h @@ -69,8 +69,9 @@ void __xsm_action_mismatch_detected(void); #endif /* CONFIG_XSM */ -static always_inline int xsm_default_action( - xsm_default_t action, struct domain *src, struct domain *target) +static always_inline int xsm_default_action(xsm_default_t action, + struct domain *src, + struct domain *target) { switch ( action ) { case XSM_HOOK: @@ -99,12 +100,13 @@ static always_inline int xsm_default_action( } static XSM_INLINE void xsm_security_domaininfo(struct domain *d, - struct xen_domctl_getdomaininfo *info) + struct xen_domctl_getdomaininfo *info) { return; } -static XSM_INLINE int xsm_domain_create(XSM_DEFAULT_ARG struct domain *d, u32 ssidref) +static XSM_INLINE int xsm_domain_create(XSM_DEFAULT_ARG struct domain *d, + uint32_t ssidref) { XSM_ASSERT_ACTION(XSM_HOOK); return xsm_default_action(action, current->domain, d); @@ -116,7 +118,8 @@ static XSM_INLINE int xsm_getdomaininfo(XSM_DEFAULT_ARG struct domain *d) return xsm_default_action(action, current->domain, d); } -static XSM_INLINE int xsm_domctl_scheduler_op(XSM_DEFAULT_ARG struct domain *d, int cmd) +static XSM_INLINE int xsm_domctl_scheduler_op(XSM_DEFAULT_ARG struct domain *d, + int cmd) { XSM_ASSERT_ACTION(XSM_HOOK); return xsm_default_action(action, current->domain, d); @@ -128,7 +131,8 @@ static XSM_INLINE int xsm_sysctl_scheduler_op(XSM_DEFAULT_ARG int cmd) return xsm_default_action(action, current->domain, NULL); } -static XSM_INLINE int xsm_set_target(XSM_DEFAULT_ARG struct domain *d, struct domain *e) +static XSM_INLINE int xsm_set_target(XSM_DEFAULT_ARG struct domain *d, + struct domain *e) { XSM_ASSERT_ACTION(XSM_HOOK); return xsm_default_action(action, current->domain, NULL); @@ -173,38 +177,43 @@ static XSM_INLINE void xsm_free_security_domain(struct domain *d) return; } -static XSM_INLINE int xsm_grant_mapref(XSM_DEFAULT_ARG struct domain *d1, struct domain *d2, - uint32_t flags) +static XSM_INLINE int xsm_grant_mapref(XSM_DEFAULT_ARG struct domain *d1, + struct domain *d2, uint32_t flags) { XSM_ASSERT_ACTION(XSM_HOOK); return xsm_default_action(action, d1, d2); } -static XSM_INLINE int xsm_grant_unmapref(XSM_DEFAULT_ARG struct domain *d1, struct domain *d2) +static XSM_INLINE int xsm_grant_unmapref(XSM_DEFAULT_ARG struct domain *d1, + struct domain *d2) { XSM_ASSERT_ACTION(XSM_HOOK); return xsm_default_action(action, d1, d2); } -static XSM_INLINE int xsm_grant_setup(XSM_DEFAULT_ARG struct domain *d1, struct domain *d2) +static XSM_INLINE int xsm_grant_setup(XSM_DEFAULT_ARG struct domain *d1, + struct domain *d2) { XSM_ASSERT_ACTION(XSM_TARGET); return xsm_default_action(action, d1, d2); } -static XSM_INLINE int xsm_grant_transfer(XSM_DEFAULT_ARG struct domain *d1, struct domain *d2) +static XSM_INLINE int xsm_grant_transfer(XSM_DEFAULT_ARG struct domain *d1, + struct domain *d2) { XSM_ASSERT_ACTION(XSM_HOOK); return xsm_default_action(action, d1, d2); } -static XSM_INLINE int xsm_grant_copy(XSM_DEFAULT_ARG struct domain *d1, struct domain *d2) +static XSM_INLINE int xsm_grant_copy(XSM_DEFAULT_ARG struct domain *d1, + struct domain *d2) { XSM_ASSERT_ACTION(XSM_HOOK); return xsm_default_action(action, d1, d2); } -static XSM_INLINE int xsm_grant_query_size(XSM_DEFAULT_ARG struct domain *d1, struct domain *d2) +static XSM_INLINE int xsm_grant_query_size(XSM_DEFAULT_ARG struct domain *d1, + struct domain *d2) { XSM_ASSERT_ACTION(XSM_TARGET); return xsm_default_action(action, d1, d2); @@ -216,14 +225,17 @@ static XSM_INLINE int xsm_memory_exchange(XSM_DEFAULT_ARG struct domain *d) return xsm_default_action(action, current->domain, d); } -static XSM_INLINE int xsm_memory_adjust_reservation(XSM_DEFAULT_ARG struct domain *d1, - struct domain *d2) +static XSM_INLINE int xsm_memory_adjust_reservation(XSM_DEFAULT_ARG + struct domain *d1, + struct domain *d2) { XSM_ASSERT_ACTION(XSM_TARGET); return xsm_default_action(action, d1, d2); } -static XSM_INLINE int xsm_memory_stat_reservation(XSM_DEFAULT_ARG struct domain *d1, struct domain *d2) +static XSM_INLINE int xsm_memory_stat_reservation(XSM_DEFAULT_ARG + struct domain *d1, + struct domain *d2) { XSM_ASSERT_ACTION(XSM_TARGET); return xsm_default_action(action, d1, d2); @@ -253,13 +265,15 @@ static XSM_INLINE int xsm_kexec(XSM_DEFAULT_VOID) return xsm_default_action(action, current->domain, NULL); } -static XSM_INLINE int xsm_schedop_shutdown(XSM_DEFAULT_ARG struct domain *d1, struct domain *d2) +static XSM_INLINE int xsm_schedop_shutdown(XSM_DEFAULT_ARG struct domain *d1, + struct domain *d2) { XSM_ASSERT_ACTION(XSM_DM_PRIV); return xsm_default_action(action, d1, d2); } -static XSM_INLINE int xsm_memory_pin_page(XSM_DEFAULT_ARG struct domain *d1, struct domain *d2, +static XSM_INLINE int xsm_memory_pin_page(XSM_DEFAULT_ARG struct domain *d1, + struct domain *d2, struct page_info *page) { XSM_ASSERT_ACTION(XSM_HOOK); @@ -272,15 +286,17 @@ static XSM_INLINE int xsm_claim_pages(XSM_DEFAULT_ARG struct domain *d) return xsm_default_action(action, current->domain, d); } -static XSM_INLINE int xsm_evtchn_unbound(XSM_DEFAULT_ARG struct domain *d, struct evtchn *chn, - domid_t id2) +static XSM_INLINE int xsm_evtchn_unbound(XSM_DEFAULT_ARG struct domain *d, + struct evtchn *chn, domid_t id2) { XSM_ASSERT_ACTION(XSM_TARGET); return xsm_default_action(action, current->domain, d); } -static XSM_INLINE int xsm_evtchn_interdomain(XSM_DEFAULT_ARG struct domain *d1, struct evtchn - *chan1, struct domain *d2, struct evtchn *chan2) +static XSM_INLINE int xsm_evtchn_interdomain(XSM_DEFAULT_ARG struct domain *d1, + struct evtchn *chan1, + struct domain *d2, + struct evtchn *chan2) { XSM_ASSERT_ACTION(XSM_HOOK); return xsm_default_action(action, d1, d2); @@ -291,37 +307,41 @@ static XSM_INLINE void xsm_evtchn_close_post(struct evtchn *chn) return; } -static XSM_INLINE int xsm_evtchn_send(XSM_DEFAULT_ARG struct domain *d, struct evtchn *chn) +static XSM_INLINE int xsm_evtchn_send(XSM_DEFAULT_ARG struct domain *d, + struct evtchn *chn) { XSM_ASSERT_ACTION(XSM_HOOK); return xsm_default_action(action, d, NULL); } -static XSM_INLINE int xsm_evtchn_status(XSM_DEFAULT_ARG struct domain *d, struct evtchn *chn) +static XSM_INLINE int xsm_evtchn_status(XSM_DEFAULT_ARG struct domain *d, + struct evtchn *chn) { XSM_ASSERT_ACTION(XSM_TARGET); return xsm_default_action(action, current->domain, d); } -static XSM_INLINE int xsm_evtchn_reset(XSM_DEFAULT_ARG struct domain *d1, struct domain *d2) +static XSM_INLINE int xsm_evtchn_reset(XSM_DEFAULT_ARG struct domain *d1, + struct domain *d2) { XSM_ASSERT_ACTION(XSM_TARGET); return xsm_default_action(action, d1, d2); } -static XSM_INLINE int xsm_alloc_security_evtchns( - struct evtchn chn[], unsigned int nr) +static XSM_INLINE int xsm_alloc_security_evtchns(struct evtchn chn[], + unsigned int nr) { return 0; } -static XSM_INLINE void xsm_free_security_evtchns( - struct evtchn chn[], unsigned int nr) +static XSM_INLINE void xsm_free_security_evtchns(struct evtchn chn[], + unsigned int nr) { return; } -static XSM_INLINE char *xsm_show_security_evtchn(struct domain *d, const struct evtchn *chn) +static XSM_INLINE char *xsm_show_security_evtchn(struct domain *d, + const struct evtchn *chn) { return NULL; } @@ -357,13 +377,15 @@ static XSM_INLINE int xsm_get_device_group(XSM_DEFAULT_ARG uint32_t machine_bdf) return xsm_default_action(action, current->domain, NULL); } -static XSM_INLINE int xsm_assign_device(XSM_DEFAULT_ARG struct domain *d, uint32_t machine_bdf) +static XSM_INLINE int xsm_assign_device(XSM_DEFAULT_ARG struct domain *d, + uint32_t machine_bdf) { XSM_ASSERT_ACTION(XSM_HOOK); return xsm_default_action(action, current->domain, d); } -static XSM_INLINE int xsm_deassign_device(XSM_DEFAULT_ARG struct domain *d, uint32_t machine_bdf) +static XSM_INLINE int xsm_deassign_device(XSM_DEFAULT_ARG struct domain *d, + uint32_t machine_bdf) { XSM_ASSERT_ACTION(XSM_HOOK); return xsm_default_action(action, current->domain, d); @@ -400,19 +422,22 @@ static XSM_INLINE int xsm_resource_unplug_core(XSM_DEFAULT_VOID) return xsm_default_action(action, current->domain, NULL); } -static XSM_INLINE int xsm_resource_plug_pci(XSM_DEFAULT_ARG uint32_t machine_bdf) +static XSM_INLINE int xsm_resource_plug_pci(XSM_DEFAULT_ARG + uint32_t machine_bdf) { XSM_ASSERT_ACTION(XSM_PRIV); return xsm_default_action(action, current->domain, NULL); } -static XSM_INLINE int xsm_resource_unplug_pci(XSM_DEFAULT_ARG uint32_t machine_bdf) +static XSM_INLINE int xsm_resource_unplug_pci(XSM_DEFAULT_ARG + uint32_t machine_bdf) { XSM_ASSERT_ACTION(XSM_PRIV); return xsm_default_action(action, current->domain, NULL); } -static XSM_INLINE int xsm_resource_setup_pci(XSM_DEFAULT_ARG uint32_t machine_bdf) +static XSM_INLINE int xsm_resource_setup_pci(XSM_DEFAULT_ARG + uint32_t machine_bdf) { XSM_ASSERT_ACTION(XSM_PRIV); return xsm_default_action(action, current->domain, NULL); @@ -478,13 +503,15 @@ static XSM_INLINE int xsm_unmap_domain_pirq(XSM_DEFAULT_ARG struct domain *d) return xsm_default_action(action, current->domain, d); } -static XSM_INLINE int xsm_bind_pt_irq(XSM_DEFAULT_ARG struct domain *d, struct xen_domctl_bind_pt_irq *bind) +static XSM_INLINE int xsm_bind_pt_irq(XSM_DEFAULT_ARG struct domain *d, + struct xen_domctl_bind_pt_irq *bind) { XSM_ASSERT_ACTION(XSM_HOOK); return xsm_default_action(action, current->domain, d); } -static XSM_INLINE int xsm_unbind_pt_irq(XSM_DEFAULT_ARG struct domain *d, struct xen_domctl_bind_pt_irq *bind) +static XSM_INLINE int xsm_unbind_pt_irq(XSM_DEFAULT_ARG struct domain *d, + struct xen_domctl_bind_pt_irq *bind) { XSM_ASSERT_ACTION(XSM_HOOK); return xsm_default_action(action, current->domain, d); @@ -497,57 +524,68 @@ static XSM_INLINE int xsm_unmap_domain_irq(XSM_DEFAULT_ARG struct domain *d, return xsm_default_action(action, current->domain, d); } -static XSM_INLINE int xsm_irq_permission(XSM_DEFAULT_ARG struct domain *d, int pirq, uint8_t allow) +static XSM_INLINE int xsm_irq_permission(XSM_DEFAULT_ARG struct domain *d, + int pirq, uint8_t allow) { XSM_ASSERT_ACTION(XSM_HOOK); return xsm_default_action(action, current->domain, d); } -static XSM_INLINE int xsm_iomem_permission(XSM_DEFAULT_ARG struct domain *d, uint64_t s, uint64_t e, uint8_t allow) +static XSM_INLINE int xsm_iomem_permission(XSM_DEFAULT_ARG struct domain *d, + uint64_t s, uint64_t e, + uint8_t allow) { XSM_ASSERT_ACTION(XSM_HOOK); return xsm_default_action(action, current->domain, d); } -static XSM_INLINE int xsm_iomem_mapping(XSM_DEFAULT_ARG struct domain *d, uint64_t s, uint64_t e, uint8_t allow) +static XSM_INLINE int xsm_iomem_mapping(XSM_DEFAULT_ARG struct domain *d, + uint64_t s, uint64_t e, uint8_t allow) { XSM_ASSERT_ACTION(XSM_HOOK); return xsm_default_action(action, current->domain, d); } -static XSM_INLINE int xsm_pci_config_permission(XSM_DEFAULT_ARG struct domain *d, uint32_t machine_bdf, - uint16_t start, uint16_t end, - uint8_t access) +static XSM_INLINE int xsm_pci_config_permission(XSM_DEFAULT_ARG + struct domain *d, + uint32_t machine_bdf, + uint16_t start, uint16_t end, + uint8_t access) { XSM_ASSERT_ACTION(XSM_HOOK); return xsm_default_action(action, current->domain, d); } -static XSM_INLINE int xsm_add_to_physmap(XSM_DEFAULT_ARG struct domain *d1, struct domain *d2) +static XSM_INLINE int xsm_add_to_physmap(XSM_DEFAULT_ARG struct domain *d1, + struct domain *d2) { XSM_ASSERT_ACTION(XSM_TARGET); return xsm_default_action(action, d1, d2); } -static XSM_INLINE int xsm_remove_from_physmap(XSM_DEFAULT_ARG struct domain *d1, struct domain *d2) +static XSM_INLINE int xsm_remove_from_physmap(XSM_DEFAULT_ARG struct domain *d1, + struct domain *d2) { XSM_ASSERT_ACTION(XSM_TARGET); return xsm_default_action(action, d1, d2); } -static XSM_INLINE int xsm_map_gmfn_foreign(XSM_DEFAULT_ARG struct domain *d, struct domain *t) +static XSM_INLINE int xsm_map_gmfn_foreign(XSM_DEFAULT_ARG struct domain *d, + struct domain *t) { XSM_ASSERT_ACTION(XSM_TARGET); return xsm_default_action(action, d, t); } -static XSM_INLINE int xsm_hvm_param(XSM_DEFAULT_ARG struct domain *d, unsigned long op) +static XSM_INLINE int xsm_hvm_param(XSM_DEFAULT_ARG struct domain *d, + unsigned long op) { XSM_ASSERT_ACTION(XSM_TARGET); return xsm_default_action(action, current->domain, d); } -static XSM_INLINE int xsm_hvm_control(XSM_DEFAULT_ARG struct domain *d, unsigned long op) +static XSM_INLINE int xsm_hvm_control(XSM_DEFAULT_ARG struct domain *d, + unsigned long op) { XSM_ASSERT_ACTION(XSM_DM_PRIV); return xsm_default_action(action, current->domain, d); @@ -559,7 +597,8 @@ static XSM_INLINE int xsm_hvm_param_altp2mhvm(XSM_DEFAULT_ARG struct domain *d) return xsm_default_action(action, current->domain, d); } -static XSM_INLINE int xsm_hvm_altp2mhvm_op(XSM_DEFAULT_ARG struct domain *d, uint64_t mode, uint32_t op) +static XSM_INLINE int xsm_hvm_altp2mhvm_op(XSM_DEFAULT_ARG struct domain *d, + uint64_t mode, uint32_t op) { XSM_ASSERT_ACTION(XSM_OTHER); @@ -578,7 +617,8 @@ static XSM_INLINE int xsm_hvm_altp2mhvm_op(XSM_DEFAULT_ARG struct domain *d, uin } } -static XSM_INLINE int xsm_vm_event_control(XSM_DEFAULT_ARG struct domain *d, int mode, int op) +static XSM_INLINE int xsm_vm_event_control(XSM_DEFAULT_ARG struct domain *d, + int mode, int op) { XSM_ASSERT_ACTION(XSM_PRIV); return xsm_default_action(action, current->domain, d); @@ -621,13 +661,15 @@ static XSM_INLINE int xsm_do_mca(XSM_DEFAULT_VOID) return xsm_default_action(action, current->domain, NULL); } -static XSM_INLINE int xsm_shadow_control(XSM_DEFAULT_ARG struct domain *d, uint32_t op) +static XSM_INLINE int xsm_shadow_control(XSM_DEFAULT_ARG struct domain *d, + uint32_t op) { XSM_ASSERT_ACTION(XSM_HOOK); return xsm_default_action(action, current->domain, d); } -static XSM_INLINE int xsm_mem_sharing_op(XSM_DEFAULT_ARG struct domain *d, struct domain *cd, int op) +static XSM_INLINE int xsm_mem_sharing_op(XSM_DEFAULT_ARG struct domain *d, + struct domain *cd, int op) { XSM_ASSERT_ACTION(XSM_DM_PRIV); return xsm_default_action(action, current->domain, cd); @@ -651,8 +693,9 @@ static XSM_INLINE int xsm_domain_memory_map(XSM_DEFAULT_ARG struct domain *d) return xsm_default_action(action, current->domain, d); } -static XSM_INLINE int xsm_mmu_update(XSM_DEFAULT_ARG struct domain *d, struct domain *t, - struct domain *f, uint32_t flags) +static XSM_INLINE int xsm_mmu_update(XSM_DEFAULT_ARG struct domain *d, + struct domain *t, struct domain *f, + uint32_t flags) { int rc = 0; XSM_ASSERT_ACTION(XSM_TARGET); @@ -663,38 +706,44 @@ static XSM_INLINE int xsm_mmu_update(XSM_DEFAULT_ARG struct domain *d, struct do return rc; } -static XSM_INLINE int xsm_mmuext_op(XSM_DEFAULT_ARG struct domain *d, struct domain *f) +static XSM_INLINE int xsm_mmuext_op(XSM_DEFAULT_ARG struct domain *d, + struct domain *f) { XSM_ASSERT_ACTION(XSM_TARGET); return xsm_default_action(action, d, f); } -static XSM_INLINE int xsm_update_va_mapping(XSM_DEFAULT_ARG struct domain *d, struct domain *f, - l1_pgentry_t pte) +static XSM_INLINE int xsm_update_va_mapping(XSM_DEFAULT_ARG struct domain *d, + struct domain *f, l1_pgentry_t pte) { XSM_ASSERT_ACTION(XSM_TARGET); return xsm_default_action(action, d, f); } -static XSM_INLINE int xsm_priv_mapping(XSM_DEFAULT_ARG struct domain *d, struct domain *t) +static XSM_INLINE int xsm_priv_mapping(XSM_DEFAULT_ARG struct domain *d, + struct domain *t) { XSM_ASSERT_ACTION(XSM_TARGET); return xsm_default_action(action, d, t); } -static XSM_INLINE int xsm_ioport_permission(XSM_DEFAULT_ARG struct domain *d, uint32_t s, uint32_t e, uint8_t allow) +static XSM_INLINE int xsm_ioport_permission(XSM_DEFAULT_ARG struct domain *d, + uint32_t s, uint32_t e, + uint8_t allow) { XSM_ASSERT_ACTION(XSM_HOOK); return xsm_default_action(action, current->domain, d); } -static XSM_INLINE int xsm_ioport_mapping(XSM_DEFAULT_ARG struct domain *d, uint32_t s, uint32_t e, uint8_t allow) +static XSM_INLINE int xsm_ioport_mapping(XSM_DEFAULT_ARG struct domain *d, + uint32_t s, uint32_t e, uint8_t allow) { XSM_ASSERT_ACTION(XSM_HOOK); return xsm_default_action(action, current->domain, d); } -static XSM_INLINE int xsm_pmu_op (XSM_DEFAULT_ARG struct domain *d, unsigned int op) +static XSM_INLINE int xsm_pmu_op(XSM_DEFAULT_ARG struct domain *d, + unsigned int op) { XSM_ASSERT_ACTION(XSM_OTHER); switch ( op ) @@ -743,7 +792,7 @@ static XSM_INLINE int xsm_argo_send(const struct domain *d, #endif /* CONFIG_ARGO */ #include -static XSM_INLINE int xsm_xen_version (XSM_DEFAULT_ARG uint32_t op) +static XSM_INLINE int xsm_xen_version(XSM_DEFAULT_ARG uint32_t op) { XSM_ASSERT_ACTION(XSM_OTHER); switch ( op ) diff --git a/xen/include/xsm/xsm.h b/xen/include/xsm/xsm.h index 9872bae502..8878281eae 100644 --- a/xen/include/xsm/xsm.h +++ b/xen/include/xsm/xsm.h @@ -19,7 +19,7 @@ #include /* policy magic number (defined by XSM_MAGIC) */ -typedef u32 xsm_magic_t; +typedef uint32_t xsm_magic_t; #ifdef CONFIG_XSM_FLASK #define XSM_MAGIC 0xf97cff8c @@ -31,158 +31,171 @@ typedef u32 xsm_magic_t; * default actions of XSM hooks. They should be compiled out otherwise. */ enum xsm_default { - XSM_HOOK, /* Guests can normally access the hypercall */ - XSM_DM_PRIV, /* Device model can perform on its target domain */ - XSM_TARGET, /* Can perform on self or your target domain */ - XSM_PRIV, /* Privileged - normally restricted to dom0 */ - XSM_XS_PRIV, /* Xenstore domain - can do some privileged operations */ - XSM_OTHER /* Something more complex */ + /* Guests can normally access the hypercall */ + XSM_HOOK, + /* Device model can perform on its target domain */ + XSM_DM_PRIV, + /* Can perform on self or your target domain */ + XSM_TARGET, + /* Privileged - normally restricted to dom0 */ + XSM_PRIV, + /* Xenstore domain - can do some privileged operations */ + XSM_XS_PRIV, + /* Something more complex */ + XSM_OTHER }; typedef enum xsm_default xsm_default_t; struct xsm_operations { - void (*security_domaininfo) (struct domain *d, - struct xen_domctl_getdomaininfo *info); - int (*domain_create) (struct domain *d, u32 ssidref); - int (*getdomaininfo) (struct domain *d); - int (*domctl_scheduler_op) (struct domain *d, int op); - int (*sysctl_scheduler_op) (int op); - int (*set_target) (struct domain *d, struct domain *e); - int (*domctl) (struct domain *d, int cmd); - int (*sysctl) (int cmd); - int (*readconsole) (uint32_t clear); - - int (*evtchn_unbound) (struct domain *d, struct evtchn *chn, domid_t id2); - int (*evtchn_interdomain) (struct domain *d1, struct evtchn *chn1, - struct domain *d2, struct evtchn *chn2); - void (*evtchn_close_post) (struct evtchn *chn); - int (*evtchn_send) (struct domain *d, struct evtchn *chn); - int (*evtchn_status) (struct domain *d, struct evtchn *chn); - int (*evtchn_reset) (struct domain *d1, struct domain *d2); - - int (*grant_mapref) (struct domain *d1, struct domain *d2, uint32_t flags); - int (*grant_unmapref) (struct domain *d1, struct domain *d2); - int (*grant_setup) (struct domain *d1, struct domain *d2); - int (*grant_transfer) (struct domain *d1, struct domain *d2); - int (*grant_copy) (struct domain *d1, struct domain *d2); - int (*grant_query_size) (struct domain *d1, struct domain *d2); - - int (*alloc_security_domain) (struct domain *d); - void (*free_security_domain) (struct domain *d); - int (*alloc_security_evtchns) (struct evtchn chn[], unsigned int nr); - void (*free_security_evtchns) (struct evtchn chn[], unsigned int nr); - char *(*show_security_evtchn) (struct domain *d, const struct evtchn *chn); - int (*init_hardware_domain) (struct domain *d); - - int (*get_pod_target) (struct domain *d); - int (*set_pod_target) (struct domain *d); - int (*memory_exchange) (struct domain *d); - int (*memory_adjust_reservation) (struct domain *d1, struct domain *d2); - int (*memory_stat_reservation) (struct domain *d1, struct domain *d2); - int (*memory_pin_page) (struct domain *d1, struct domain *d2, struct page_info *page); - int (*add_to_physmap) (struct domain *d1, struct domain *d2); - int (*remove_from_physmap) (struct domain *d1, struct domain *d2); - int (*map_gmfn_foreign) (struct domain *d, struct domain *t); - int (*claim_pages) (struct domain *d); - - int (*console_io) (struct domain *d, int cmd); - - int (*profile) (struct domain *d, int op); - - int (*kexec) (void); - int (*schedop_shutdown) (struct domain *d1, struct domain *d2); - - char *(*show_irq_sid) (int irq); - int (*map_domain_pirq) (struct domain *d); - int (*map_domain_irq) (struct domain *d, int irq, const void *data); - int (*unmap_domain_pirq) (struct domain *d); - int (*unmap_domain_irq) (struct domain *d, int irq, const void *data); - int (*bind_pt_irq) (struct domain *d, struct xen_domctl_bind_pt_irq *bind); - int (*unbind_pt_irq) (struct domain *d, struct xen_domctl_bind_pt_irq *bind); - int (*irq_permission) (struct domain *d, int pirq, uint8_t allow); - int (*iomem_permission) (struct domain *d, uint64_t s, uint64_t e, uint8_t allow); - int (*iomem_mapping) (struct domain *d, uint64_t s, uint64_t e, uint8_t allow); - int (*pci_config_permission) (struct domain *d, uint32_t machine_bdf, uint16_t start, uint16_t end, uint8_t access); + void (*security_domaininfo)(struct domain *d, + struct xen_domctl_getdomaininfo *info); + int (*domain_create)(struct domain *d, uint32_t ssidref); + int (*getdomaininfo)(struct domain *d); + int (*domctl_scheduler_op)(struct domain *d, int op); + int (*sysctl_scheduler_op)(int op); + int (*set_target)(struct domain *d, struct domain *e); + int (*domctl)(struct domain *d, int cmd); + int (*sysctl)(int cmd); + int (*readconsole)(uint32_t clear); + + int (*evtchn_unbound)(struct domain *d, struct evtchn *chn, domid_t id2); + int (*evtchn_interdomain)(struct domain *d1, struct evtchn *chn1, + struct domain *d2, struct evtchn *chn2); + void (*evtchn_close_post)(struct evtchn *chn); + int (*evtchn_send)(struct domain *d, struct evtchn *chn); + int (*evtchn_status)(struct domain *d, struct evtchn *chn); + int (*evtchn_reset)(struct domain *d1, struct domain *d2); + + int (*grant_mapref)(struct domain *d1, struct domain *d2, uint32_t flags); + int (*grant_unmapref)(struct domain *d1, struct domain *d2); + int (*grant_setup)(struct domain *d1, struct domain *d2); + int (*grant_transfer)(struct domain *d1, struct domain *d2); + int (*grant_copy)(struct domain *d1, struct domain *d2); + int (*grant_query_size)(struct domain *d1, struct domain *d2); + + int (*alloc_security_domain)(struct domain *d); + void (*free_security_domain)(struct domain *d); + int (*alloc_security_evtchns)(struct evtchn chn[], unsigned int nr); + void (*free_security_evtchns)(struct evtchn chn[], unsigned int nr); + char *(*show_security_evtchn)(struct domain *d, const struct evtchn *chn); + int (*init_hardware_domain)(struct domain *d); + + int (*get_pod_target)(struct domain *d); + int (*set_pod_target)(struct domain *d); + int (*memory_exchange)(struct domain *d); + int (*memory_adjust_reservation)(struct domain *d1, struct domain *d2); + int (*memory_stat_reservation)(struct domain *d1, struct domain *d2); + int (*memory_pin_page)(struct domain *d1, struct domain *d2, + struct page_info *page); + int (*add_to_physmap)(struct domain *d1, struct domain *d2); + int (*remove_from_physmap)(struct domain *d1, struct domain *d2); + int (*map_gmfn_foreign)(struct domain *d, struct domain *t); + int (*claim_pages)(struct domain *d); + + int (*console_io)(struct domain *d, int cmd); + + int (*profile)(struct domain *d, int op); + + int (*kexec)(void); + int (*schedop_shutdown)(struct domain *d1, struct domain *d2); + + char *(*show_irq_sid)(int irq); + int (*map_domain_pirq)(struct domain *d); + int (*map_domain_irq)(struct domain *d, int irq, const void *data); + int (*unmap_domain_pirq)(struct domain *d); + int (*unmap_domain_irq)(struct domain *d, int irq, const void *data); + int (*bind_pt_irq)(struct domain *d, struct xen_domctl_bind_pt_irq *bind); + int (*unbind_pt_irq)(struct domain *d, struct xen_domctl_bind_pt_irq *bind); + int (*irq_permission)(struct domain *d, int pirq, uint8_t allow); + int (*iomem_permission)(struct domain *d, uint64_t s, uint64_t e, + uint8_t allow); + int (*iomem_mapping)(struct domain *d, uint64_t s, uint64_t e, + uint8_t allow); + int (*pci_config_permission)(struct domain *d, uint32_t machine_bdf, + uint16_t start, uint16_t end, uint8_t access); #if defined(CONFIG_HAS_PASSTHROUGH) && defined(CONFIG_HAS_PCI) - int (*get_device_group) (uint32_t machine_bdf); - int (*assign_device) (struct domain *d, uint32_t machine_bdf); - int (*deassign_device) (struct domain *d, uint32_t machine_bdf); + int (*get_device_group)(uint32_t machine_bdf); + int (*assign_device)(struct domain *d, uint32_t machine_bdf); + int (*deassign_device)(struct domain *d, uint32_t machine_bdf); #endif #if defined(CONFIG_HAS_PASSTHROUGH) && defined(CONFIG_HAS_DEVICE_TREE) - int (*assign_dtdevice) (struct domain *d, const char *dtpath); - int (*deassign_dtdevice) (struct domain *d, const char *dtpath); + int (*assign_dtdevice)(struct domain *d, const char *dtpath); + int (*deassign_dtdevice)(struct domain *d, const char *dtpath); #endif - int (*resource_plug_core) (void); - int (*resource_unplug_core) (void); - int (*resource_plug_pci) (uint32_t machine_bdf); - int (*resource_unplug_pci) (uint32_t machine_bdf); - int (*resource_setup_pci) (uint32_t machine_bdf); - int (*resource_setup_gsi) (int gsi); - int (*resource_setup_misc) (void); + int (*resource_plug_core)(void); + int (*resource_unplug_core)(void); + int (*resource_plug_pci)(uint32_t machine_bdf); + int (*resource_unplug_pci)(uint32_t machine_bdf); + int (*resource_setup_pci)(uint32_t machine_bdf); + int (*resource_setup_gsi)(int gsi); + int (*resource_setup_misc)(void); int (*page_offline)(uint32_t cmd); int (*hypfs_op)(void); - long (*do_xsm_op) (XEN_GUEST_HANDLE_PARAM(void) op); + long (*do_xsm_op)(XEN_GUEST_HANDLE_PARAM(void) op); #ifdef CONFIG_COMPAT - int (*do_compat_op) (XEN_GUEST_HANDLE_PARAM(void) op); + int (*do_compat_op)(XEN_GUEST_HANDLE_PARAM(void) op); #endif - int (*hvm_param) (struct domain *d, unsigned long op); - int (*hvm_control) (struct domain *d, unsigned long op); - int (*hvm_param_altp2mhvm) (struct domain *d); - int (*hvm_altp2mhvm_op) (struct domain *d, uint64_t mode, uint32_t op); - int (*get_vnumainfo) (struct domain *d); + int (*hvm_param)(struct domain *d, unsigned long op); + int (*hvm_control)(struct domain *d, unsigned long op); + int (*hvm_param_altp2mhvm)(struct domain *d); + int (*hvm_altp2mhvm_op)(struct domain *d, uint64_t mode, uint32_t op); + int (*get_vnumainfo)(struct domain *d); - int (*vm_event_control) (struct domain *d, int mode, int op); + int (*vm_event_control)(struct domain *d, int mode, int op); #ifdef CONFIG_MEM_ACCESS - int (*mem_access) (struct domain *d); + int (*mem_access)(struct domain *d); #endif #ifdef CONFIG_MEM_PAGING - int (*mem_paging) (struct domain *d); + int (*mem_paging)(struct domain *d); #endif #ifdef CONFIG_MEM_SHARING - int (*mem_sharing) (struct domain *d); + int (*mem_sharing)(struct domain *d); #endif - int (*platform_op) (uint32_t cmd); + int (*platform_op)(uint32_t cmd); #ifdef CONFIG_X86 - int (*do_mca) (void); - int (*shadow_control) (struct domain *d, uint32_t op); - int (*mem_sharing_op) (struct domain *d, struct domain *cd, int op); - int (*apic) (struct domain *d, int cmd); - int (*memtype) (uint32_t access); - int (*machine_memory_map) (void); - int (*domain_memory_map) (struct domain *d); + int (*do_mca)(void); + int (*shadow_control)(struct domain *d, uint32_t op); + int (*mem_sharing_op)(struct domain *d, struct domain *cd, int op); + int (*apic)(struct domain *d, int cmd); + int (*memtype)(uint32_t access); + int (*machine_memory_map)(void); + int (*domain_memory_map)(struct domain *d); #define XSM_MMU_UPDATE_READ 1 #define XSM_MMU_UPDATE_WRITE 2 #define XSM_MMU_NORMAL_UPDATE 4 #define XSM_MMU_MACHPHYS_UPDATE 8 - int (*mmu_update) (struct domain *d, struct domain *t, - struct domain *f, uint32_t flags); - int (*mmuext_op) (struct domain *d, struct domain *f); - int (*update_va_mapping) (struct domain *d, struct domain *f, l1_pgentry_t pte); - int (*priv_mapping) (struct domain *d, struct domain *t); - int (*ioport_permission) (struct domain *d, uint32_t s, uint32_t e, uint8_t allow); - int (*ioport_mapping) (struct domain *d, uint32_t s, uint32_t e, uint8_t allow); - int (*pmu_op) (struct domain *d, unsigned int op); + int (*mmu_update)(struct domain *d, struct domain *t, + struct domain *f, uint32_t flags); + int (*mmuext_op)(struct domain *d, struct domain *f); + int (*update_va_mapping)(struct domain *d, struct domain *f, + l1_pgentry_t pte); + int (*priv_mapping)(struct domain *d, struct domain *t); + int (*ioport_permission)(struct domain *d, uint32_t s, uint32_t e, + uint8_t allow); + int (*ioport_mapping)(struct domain *d, uint32_t s, uint32_t e, + uint8_t allow); + int (*pmu_op)(struct domain *d, unsigned int op); #endif - int (*dm_op) (struct domain *d); - int (*xen_version) (uint32_t cmd); - int (*domain_resource_map) (struct domain *d); + int (*dm_op)(struct domain *d); + int (*xen_version)(uint32_t cmd); + int (*domain_resource_map)(struct domain *d); #ifdef CONFIG_ARGO - int (*argo_enable) (const struct domain *d); - int (*argo_register_single_source) (const struct domain *d, - const struct domain *t); - int (*argo_register_any_source) (const struct domain *d); - int (*argo_send) (const struct domain *d, const struct domain *t); + int (*argo_enable)(const struct domain *d); + int (*argo_register_single_source)(const struct domain *d, + const struct domain *t); + int (*argo_register_any_source)(const struct domain *d); + int (*argo_send)(const struct domain *d, const struct domain *t); #endif }; @@ -192,191 +205,210 @@ extern struct xsm_operations *xsm_ops; #ifndef XSM_NO_WRAPPERS -static inline void xsm_security_domaininfo (struct domain *d, - struct xen_domctl_getdomaininfo *info) +static inline void xsm_security_domaininfo(struct domain *d, + struct xen_domctl_getdomaininfo *info) { xsm_ops->security_domaininfo(d, info); } -static inline int xsm_domain_create (xsm_default_t def, struct domain *d, u32 ssidref) +static inline int xsm_domain_create(xsm_default_t def, struct domain *d, + uint32_t ssidref) { return xsm_ops->domain_create(d, ssidref); } -static inline int xsm_getdomaininfo (xsm_default_t def, struct domain *d) +static inline int xsm_getdomaininfo(xsm_default_t def, struct domain *d) { return xsm_ops->getdomaininfo(d); } -static inline int xsm_domctl_scheduler_op (xsm_default_t def, struct domain *d, int cmd) +static inline int xsm_domctl_scheduler_op(xsm_default_t def, struct domain *d, + int cmd) { return xsm_ops->domctl_scheduler_op(d, cmd); } -static inline int xsm_sysctl_scheduler_op (xsm_default_t def, int cmd) +static inline int xsm_sysctl_scheduler_op(xsm_default_t def, int cmd) { return xsm_ops->sysctl_scheduler_op(cmd); } -static inline int xsm_set_target (xsm_default_t def, struct domain *d, struct domain *e) +static inline int xsm_set_target(xsm_default_t def, struct domain *d, + struct domain *e) { return xsm_ops->set_target(d, e); } -static inline int xsm_domctl (xsm_default_t def, struct domain *d, int cmd) +static inline int xsm_domctl(xsm_default_t def, struct domain *d, int cmd) { return xsm_ops->domctl(d, cmd); } -static inline int xsm_sysctl (xsm_default_t def, int cmd) +static inline int xsm_sysctl(xsm_default_t def, int cmd) { return xsm_ops->sysctl(cmd); } -static inline int xsm_readconsole (xsm_default_t def, uint32_t clear) +static inline int xsm_readconsole(xsm_default_t def, uint32_t clear) { return xsm_ops->readconsole(clear); } -static inline int xsm_evtchn_unbound (xsm_default_t def, struct domain *d1, struct evtchn *chn, - domid_t id2) +static inline int xsm_evtchn_unbound(xsm_default_t def, struct domain *d1, + struct evtchn *chn, domid_t id2) { return xsm_ops->evtchn_unbound(d1, chn, id2); } -static inline int xsm_evtchn_interdomain (xsm_default_t def, struct domain *d1, - struct evtchn *chan1, struct domain *d2, struct evtchn *chan2) +static inline int xsm_evtchn_interdomain(xsm_default_t def, struct domain *d1, + struct evtchn *chan1, + struct domain *d2, + struct evtchn *chan2) { return xsm_ops->evtchn_interdomain(d1, chan1, d2, chan2); } -static inline void xsm_evtchn_close_post (struct evtchn *chn) +static inline void xsm_evtchn_close_post(struct evtchn *chn) { xsm_ops->evtchn_close_post(chn); } -static inline int xsm_evtchn_send (xsm_default_t def, struct domain *d, struct evtchn *chn) +static inline int xsm_evtchn_send(xsm_default_t def, struct domain *d, + struct evtchn *chn) { return xsm_ops->evtchn_send(d, chn); } -static inline int xsm_evtchn_status (xsm_default_t def, struct domain *d, struct evtchn *chn) +static inline int xsm_evtchn_status(xsm_default_t def, struct domain *d, + struct evtchn *chn) { return xsm_ops->evtchn_status(d, chn); } -static inline int xsm_evtchn_reset (xsm_default_t def, struct domain *d1, struct domain *d2) +static inline int xsm_evtchn_reset(xsm_default_t def, struct domain *d1, + struct domain *d2) { return xsm_ops->evtchn_reset(d1, d2); } -static inline int xsm_grant_mapref (xsm_default_t def, struct domain *d1, struct domain *d2, - uint32_t flags) +static inline int xsm_grant_mapref(xsm_default_t def, struct domain *d1, + struct domain *d2, uint32_t flags) { return xsm_ops->grant_mapref(d1, d2, flags); } -static inline int xsm_grant_unmapref (xsm_default_t def, struct domain *d1, struct domain *d2) +static inline int xsm_grant_unmapref(xsm_default_t def, struct domain *d1, + struct domain *d2) { return xsm_ops->grant_unmapref(d1, d2); } -static inline int xsm_grant_setup (xsm_default_t def, struct domain *d1, struct domain *d2) +static inline int xsm_grant_setup(xsm_default_t def, struct domain *d1, + struct domain *d2) { return xsm_ops->grant_setup(d1, d2); } -static inline int xsm_grant_transfer (xsm_default_t def, struct domain *d1, struct domain *d2) +static inline int xsm_grant_transfer(xsm_default_t def, struct domain *d1, + struct domain *d2) { return xsm_ops->grant_transfer(d1, d2); } -static inline int xsm_grant_copy (xsm_default_t def, struct domain *d1, struct domain *d2) +static inline int xsm_grant_copy(xsm_default_t def, struct domain *d1, + struct domain *d2) { return xsm_ops->grant_copy(d1, d2); } -static inline int xsm_grant_query_size (xsm_default_t def, struct domain *d1, struct domain *d2) +static inline int xsm_grant_query_size(xsm_default_t def, struct domain *d1, + struct domain *d2) { return xsm_ops->grant_query_size(d1, d2); } -static inline int xsm_alloc_security_domain (struct domain *d) +static inline int xsm_alloc_security_domain(struct domain *d) { return xsm_ops->alloc_security_domain(d); } -static inline void xsm_free_security_domain (struct domain *d) +static inline void xsm_free_security_domain(struct domain *d) { xsm_ops->free_security_domain(d); } -static inline int xsm_alloc_security_evtchns( - struct evtchn chn[], unsigned int nr) +static inline int xsm_alloc_security_evtchns(struct evtchn chn[], + unsigned int nr) { return xsm_ops->alloc_security_evtchns(chn, nr); } -static inline void xsm_free_security_evtchns( - struct evtchn chn[], unsigned int nr) +static inline void xsm_free_security_evtchns(struct evtchn chn[], + unsigned int nr) { xsm_ops->free_security_evtchns(chn, nr); } -static inline char *xsm_show_security_evtchn (struct domain *d, const struct evtchn *chn) +static inline char *xsm_show_security_evtchn(struct domain *d, + const struct evtchn *chn) { return xsm_ops->show_security_evtchn(d, chn); } -static inline int xsm_init_hardware_domain (xsm_default_t def, struct domain *d) +static inline int xsm_init_hardware_domain(xsm_default_t def, struct domain *d) { return xsm_ops->init_hardware_domain(d); } -static inline int xsm_get_pod_target (xsm_default_t def, struct domain *d) +static inline int xsm_get_pod_target(xsm_default_t def, struct domain *d) { return xsm_ops->get_pod_target(d); } -static inline int xsm_set_pod_target (xsm_default_t def, struct domain *d) +static inline int xsm_set_pod_target(xsm_default_t def, struct domain *d) { return xsm_ops->set_pod_target(d); } -static inline int xsm_memory_exchange (xsm_default_t def, struct domain *d) +static inline int xsm_memory_exchange(xsm_default_t def, struct domain *d) { return xsm_ops->memory_exchange(d); } -static inline int xsm_memory_adjust_reservation (xsm_default_t def, struct domain *d1, struct - domain *d2) +static inline int xsm_memory_adjust_reservation(xsm_default_t def, + struct domain *d1, + struct domain *d2) { return xsm_ops->memory_adjust_reservation(d1, d2); } -static inline int xsm_memory_stat_reservation (xsm_default_t def, struct domain *d1, - struct domain *d2) +static inline int xsm_memory_stat_reservation(xsm_default_t def, + struct domain *d1, + struct domain *d2) { return xsm_ops->memory_stat_reservation(d1, d2); } -static inline int xsm_memory_pin_page(xsm_default_t def, struct domain *d1, struct domain *d2, - struct page_info *page) +static inline int xsm_memory_pin_page(xsm_default_t def, struct domain *d1, + struct domain *d2, struct page_info *page) { return xsm_ops->memory_pin_page(d1, d2, page); } -static inline int xsm_add_to_physmap(xsm_default_t def, struct domain *d1, struct domain *d2) +static inline int xsm_add_to_physmap(xsm_default_t def, struct domain *d1, + struct domain *d2) { return xsm_ops->add_to_physmap(d1, d2); } -static inline int xsm_remove_from_physmap(xsm_default_t def, struct domain *d1, struct domain *d2) +static inline int xsm_remove_from_physmap(xsm_default_t def, struct domain *d1, + struct domain *d2) { return xsm_ops->remove_from_physmap(d1, d2); } -static inline int xsm_map_gmfn_foreign (xsm_default_t def, struct domain *d, struct domain *t) +static inline int xsm_map_gmfn_foreign(xsm_default_t def, struct domain *d, + struct domain *t) { return xsm_ops->map_gmfn_foreign(d, t); } @@ -386,47 +418,50 @@ static inline int xsm_claim_pages(xsm_default_t def, struct domain *d) return xsm_ops->claim_pages(d); } -static inline int xsm_console_io (xsm_default_t def, struct domain *d, int cmd) +static inline int xsm_console_io(xsm_default_t def, struct domain *d, int cmd) { return xsm_ops->console_io(d, cmd); } -static inline int xsm_profile (xsm_default_t def, struct domain *d, int op) +static inline int xsm_profile(xsm_default_t def, struct domain *d, int op) { return xsm_ops->profile(d, op); } -static inline int xsm_kexec (xsm_default_t def) +static inline int xsm_kexec(xsm_default_t def) { return xsm_ops->kexec(); } -static inline int xsm_schedop_shutdown (xsm_default_t def, struct domain *d1, struct domain *d2) +static inline int xsm_schedop_shutdown(xsm_default_t def, struct domain *d1, + struct domain *d2) { return xsm_ops->schedop_shutdown(d1, d2); } -static inline char *xsm_show_irq_sid (int irq) +static inline char *xsm_show_irq_sid(int irq) { return xsm_ops->show_irq_sid(irq); } -static inline int xsm_map_domain_pirq (xsm_default_t def, struct domain *d) +static inline int xsm_map_domain_pirq(xsm_default_t def, struct domain *d) { return xsm_ops->map_domain_pirq(d); } -static inline int xsm_map_domain_irq (xsm_default_t def, struct domain *d, int irq, void *data) +static inline int xsm_map_domain_irq(xsm_default_t def, struct domain *d, + int irq, void *data) { return xsm_ops->map_domain_irq(d, irq, data); } -static inline int xsm_unmap_domain_pirq (xsm_default_t def, struct domain *d) +static inline int xsm_unmap_domain_pirq(xsm_default_t def, struct domain *d) { return xsm_ops->unmap_domain_pirq(d); } -static inline int xsm_unmap_domain_irq (xsm_default_t def, struct domain *d, int irq, void *data) +static inline int xsm_unmap_domain_irq(xsm_default_t def, struct domain *d, + int irq, void *data) { return xsm_ops->unmap_domain_irq(d, irq, data); } @@ -443,22 +478,28 @@ static inline int xsm_unbind_pt_irq(xsm_default_t def, struct domain *d, return xsm_ops->unbind_pt_irq(d, bind); } -static inline int xsm_irq_permission (xsm_default_t def, struct domain *d, int pirq, uint8_t allow) +static inline int xsm_irq_permission(xsm_default_t def, struct domain *d, + int pirq, uint8_t allow) { return xsm_ops->irq_permission(d, pirq, allow); } -static inline int xsm_iomem_permission (xsm_default_t def, struct domain *d, uint64_t s, uint64_t e, uint8_t allow) +static inline int xsm_iomem_permission(xsm_default_t def, struct domain *d, + uint64_t s, uint64_t e, uint8_t allow) { return xsm_ops->iomem_permission(d, s, e, allow); } -static inline int xsm_iomem_mapping (xsm_default_t def, struct domain *d, uint64_t s, uint64_t e, uint8_t allow) +static inline int xsm_iomem_mapping(xsm_default_t def, struct domain *d, + uint64_t s, uint64_t e, uint8_t allow) { return xsm_ops->iomem_mapping(d, s, e, allow); } -static inline int xsm_pci_config_permission (xsm_default_t def, struct domain *d, uint32_t machine_bdf, uint16_t start, uint16_t end, uint8_t access) +static inline int xsm_pci_config_permission(xsm_default_t def, struct domain *d, + uint32_t machine_bdf, + uint16_t start, uint16_t end, + uint8_t access) { return xsm_ops->pci_config_permission(d, machine_bdf, start, end, access); } @@ -469,12 +510,14 @@ static inline int xsm_get_device_group(xsm_default_t def, uint32_t machine_bdf) return xsm_ops->get_device_group(machine_bdf); } -static inline int xsm_assign_device(xsm_default_t def, struct domain *d, uint32_t machine_bdf) +static inline int xsm_assign_device(xsm_default_t def, struct domain *d, + uint32_t machine_bdf) { return xsm_ops->assign_device(d, machine_bdf); } -static inline int xsm_deassign_device(xsm_default_t def, struct domain *d, uint32_t machine_bdf) +static inline int xsm_deassign_device(xsm_default_t def, struct domain *d, + uint32_t machine_bdf) { return xsm_ops->deassign_device(d, machine_bdf); } @@ -495,37 +538,39 @@ static inline int xsm_deassign_dtdevice(xsm_default_t def, struct domain *d, #endif /* HAS_PASSTHROUGH && HAS_DEVICE_TREE */ -static inline int xsm_resource_plug_pci (xsm_default_t def, uint32_t machine_bdf) +static inline int xsm_resource_plug_pci(xsm_default_t def, uint32_t machine_bdf) { return xsm_ops->resource_plug_pci(machine_bdf); } -static inline int xsm_resource_unplug_pci (xsm_default_t def, uint32_t machine_bdf) +static inline int xsm_resource_unplug_pci(xsm_default_t def, + uint32_t machine_bdf) { return xsm_ops->resource_unplug_pci(machine_bdf); } -static inline int xsm_resource_plug_core (xsm_default_t def) +static inline int xsm_resource_plug_core(xsm_default_t def) { return xsm_ops->resource_plug_core(); } -static inline int xsm_resource_unplug_core (xsm_default_t def) +static inline int xsm_resource_unplug_core(xsm_default_t def) { return xsm_ops->resource_unplug_core(); } -static inline int xsm_resource_setup_pci (xsm_default_t def, uint32_t machine_bdf) +static inline int xsm_resource_setup_pci(xsm_default_t def, + uint32_t machine_bdf) { return xsm_ops->resource_setup_pci(machine_bdf); } -static inline int xsm_resource_setup_gsi (xsm_default_t def, int gsi) +static inline int xsm_resource_setup_gsi(xsm_default_t def, int gsi) { return xsm_ops->resource_setup_gsi(gsi); } -static inline int xsm_resource_setup_misc (xsm_default_t def) +static inline int xsm_resource_setup_misc(xsm_default_t def) { return xsm_ops->resource_setup_misc(); } @@ -540,70 +585,74 @@ static inline int xsm_hypfs_op(xsm_default_t def) return xsm_ops->hypfs_op(); } -static inline long xsm_do_xsm_op (XEN_GUEST_HANDLE_PARAM(void) op) +static inline long xsm_do_xsm_op(XEN_GUEST_HANDLE_PARAM(void) op) { return xsm_ops->do_xsm_op(op); } #ifdef CONFIG_COMPAT -static inline int xsm_do_compat_op (XEN_GUEST_HANDLE_PARAM(void) op) +static inline int xsm_do_compat_op(XEN_GUEST_HANDLE_PARAM(void) op) { return xsm_ops->do_compat_op(op); } #endif -static inline int xsm_hvm_param (xsm_default_t def, struct domain *d, unsigned long op) +static inline int xsm_hvm_param(xsm_default_t def, struct domain *d, + unsigned long op) { return xsm_ops->hvm_param(d, op); } -static inline int xsm_hvm_control(xsm_default_t def, struct domain *d, unsigned long op) +static inline int xsm_hvm_control(xsm_default_t def, struct domain *d, + unsigned long op) { return xsm_ops->hvm_control(d, op); } -static inline int xsm_hvm_param_altp2mhvm (xsm_default_t def, struct domain *d) +static inline int xsm_hvm_param_altp2mhvm(xsm_default_t def, struct domain *d) { return xsm_ops->hvm_param_altp2mhvm(d); } -static inline int xsm_hvm_altp2mhvm_op (xsm_default_t def, struct domain *d, uint64_t mode, uint32_t op) +static inline int xsm_hvm_altp2mhvm_op(xsm_default_t def, struct domain *d, + uint64_t mode, uint32_t op) { return xsm_ops->hvm_altp2mhvm_op(d, mode, op); } -static inline int xsm_get_vnumainfo (xsm_default_t def, struct domain *d) +static inline int xsm_get_vnumainfo(xsm_default_t def, struct domain *d) { return xsm_ops->get_vnumainfo(d); } -static inline int xsm_vm_event_control (xsm_default_t def, struct domain *d, int mode, int op) +static inline int xsm_vm_event_control(xsm_default_t def, struct domain *d, + int mode, int op) { return xsm_ops->vm_event_control(d, mode, op); } #ifdef CONFIG_MEM_ACCESS -static inline int xsm_mem_access (xsm_default_t def, struct domain *d) +static inline int xsm_mem_access(xsm_default_t def, struct domain *d) { return xsm_ops->mem_access(d); } #endif #ifdef CONFIG_MEM_PAGING -static inline int xsm_mem_paging (xsm_default_t def, struct domain *d) +static inline int xsm_mem_paging(xsm_default_t def, struct domain *d) { return xsm_ops->mem_paging(d); } #endif #ifdef CONFIG_MEM_SHARING -static inline int xsm_mem_sharing (xsm_default_t def, struct domain *d) +static inline int xsm_mem_sharing(xsm_default_t def, struct domain *d) { return xsm_ops->mem_sharing(d); } #endif -static inline int xsm_platform_op (xsm_default_t def, uint32_t op) +static inline int xsm_platform_op(xsm_default_t def, uint32_t op) { return xsm_ops->platform_op(op); } @@ -614,22 +663,24 @@ static inline int xsm_do_mca(xsm_default_t def) return xsm_ops->do_mca(); } -static inline int xsm_shadow_control (xsm_default_t def, struct domain *d, uint32_t op) +static inline int xsm_shadow_control(xsm_default_t def, struct domain *d, + uint32_t op) { return xsm_ops->shadow_control(d, op); } -static inline int xsm_mem_sharing_op (xsm_default_t def, struct domain *d, struct domain *cd, int op) +static inline int xsm_mem_sharing_op(xsm_default_t def, struct domain *d, + struct domain *cd, int op) { return xsm_ops->mem_sharing_op(d, cd, op); } -static inline int xsm_apic (xsm_default_t def, struct domain *d, int cmd) +static inline int xsm_apic(xsm_default_t def, struct domain *d, int cmd) { return xsm_ops->apic(d, cmd); } -static inline int xsm_memtype (xsm_default_t def, uint32_t access) +static inline int xsm_memtype(xsm_default_t def, uint32_t access) { return xsm_ops->memtype(access); } @@ -644,39 +695,45 @@ static inline int xsm_domain_memory_map(xsm_default_t def, struct domain *d) return xsm_ops->domain_memory_map(d); } -static inline int xsm_mmu_update (xsm_default_t def, struct domain *d, struct domain *t, - struct domain *f, uint32_t flags) +static inline int xsm_mmu_update(xsm_default_t def, struct domain *d, + struct domain *t, struct domain *f, + uint32_t flags) { return xsm_ops->mmu_update(d, t, f, flags); } -static inline int xsm_mmuext_op (xsm_default_t def, struct domain *d, struct domain *f) +static inline int xsm_mmuext_op(xsm_default_t def, struct domain *d, + struct domain *f) { return xsm_ops->mmuext_op(d, f); } -static inline int xsm_update_va_mapping(xsm_default_t def, struct domain *d, struct domain *f, - l1_pgentry_t pte) +static inline int xsm_update_va_mapping(xsm_default_t def, struct domain *d, + struct domain *f, l1_pgentry_t pte) { return xsm_ops->update_va_mapping(d, f, pte); } -static inline int xsm_priv_mapping(xsm_default_t def, struct domain *d, struct domain *t) +static inline int xsm_priv_mapping(xsm_default_t def, struct domain *d, + struct domain *t) { return xsm_ops->priv_mapping(d, t); } -static inline int xsm_ioport_permission (xsm_default_t def, struct domain *d, uint32_t s, uint32_t e, uint8_t allow) +static inline int xsm_ioport_permission(xsm_default_t def, struct domain *d, + uint32_t s, uint32_t e, uint8_t allow) { return xsm_ops->ioport_permission(d, s, e, allow); } -static inline int xsm_ioport_mapping (xsm_default_t def, struct domain *d, uint32_t s, uint32_t e, uint8_t allow) +static inline int xsm_ioport_mapping(xsm_default_t def, struct domain *d, + uint32_t s, uint32_t e, uint8_t allow) { return xsm_ops->ioport_mapping(d, s, e, allow); } -static inline int xsm_pmu_op (xsm_default_t def, struct domain *d, unsigned int op) +static inline int xsm_pmu_op(xsm_default_t def, struct domain *d, + unsigned int op) { return xsm_ops->pmu_op(d, op); } @@ -688,7 +745,7 @@ static inline int xsm_dm_op(xsm_default_t def, struct domain *d) return xsm_ops->dm_op(d); } -static inline int xsm_xen_version (xsm_default_t def, uint32_t op) +static inline int xsm_xen_version(xsm_default_t def, uint32_t op) { return xsm_ops->xen_version(op); } @@ -725,9 +782,9 @@ static inline int xsm_argo_send(const struct domain *d, const struct domain *t) #endif /* XSM_NO_WRAPPERS */ #ifdef CONFIG_MULTIBOOT -extern int xsm_multiboot_init(unsigned long *module_map, +int xsm_multiboot_init(unsigned long *module_map, const multiboot_info_t *mbi); -extern int xsm_multiboot_policy_init(unsigned long *module_map, +int xsm_multiboot_policy_init(unsigned long *module_map, const multiboot_info_t *mbi, void **policy_buffer, size_t *policy_size); @@ -739,18 +796,19 @@ extern int xsm_multiboot_policy_init(unsigned long *module_map, * * On success, return 1 if using SILO mode else 0. */ -extern int xsm_dt_init(void); -extern int xsm_dt_policy_init(void **policy_buffer, size_t *policy_size); -extern bool has_xsm_magic(paddr_t); +int xsm_dt_init(void); +int xsm_dt_policy_init(void **policy_buffer, size_t *policy_size); +bool has_xsm_magic(paddr_t); #endif -extern int register_xsm(struct xsm_operations *ops); +int register_xsm(struct xsm_operations *ops); extern struct xsm_operations dummy_xsm_ops; -extern void xsm_fixup_ops(struct xsm_operations *ops); + +void xsm_fixup_ops(struct xsm_operations *ops); #ifdef CONFIG_XSM_FLASK -extern void flask_init(const void *policy_buffer, size_t policy_size); +void flask_init(const void *policy_buffer, size_t policy_size); #else static inline void flask_init(const void *policy_buffer, size_t policy_size) { @@ -763,7 +821,7 @@ extern const unsigned int xsm_flask_init_policy_size; #endif #ifdef CONFIG_XSM_SILO -extern void silo_init(void); +void silo_init(void); #else static inline void silo_init(void) {} #endif diff --git a/xen/xsm/xsm_core.c b/xen/xsm/xsm_core.c index ac553f9c0d..55483292c5 100644 --- a/xen/xsm/xsm_core.c +++ b/xen/xsm/xsm_core.c @@ -128,8 +128,8 @@ int __init xsm_multiboot_init(unsigned long *module_map, if ( XSM_MAGIC ) { - ret = xsm_multiboot_policy_init(module_map, mbi, - &policy_buffer, &policy_size); + ret = xsm_multiboot_policy_init(module_map, mbi, &policy_buffer, + &policy_size); if ( ret ) { bootstrap_map(NULL); -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Fri Sep 03 15:07:50 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Sep 2021 15:07:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.178150.324048 (Exim 4.92) (envelope-from ) id 1mMAnG-0008Qv-Gx; Fri, 03 Sep 2021 15:07:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 178150.324048; Fri, 03 Sep 2021 15:07:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMAnG-0008Qo-Dl; Fri, 03 Sep 2021 15:07:50 +0000 Received: by outflank-mailman (input) for mailman id 178150; Fri, 03 Sep 2021 15:07:49 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMAnF-0008Ng-0V for xen-devel@lists.xenproject.org; Fri, 03 Sep 2021 15:07:49 +0000 Received: from sender4-of-o51.zoho.com (unknown [136.143.188.51]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id b54bf82a-424d-4da4-8874-e24ba0bfc054; Fri, 03 Sep 2021 15:07:46 +0000 (UTC) Received: from sisyou.hme. (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1630681603149519.7405960574835; Fri, 3 Sep 2021 08:06:43 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b54bf82a-424d-4da4-8874-e24ba0bfc054 ARC-Seal: i=1; a=rsa-sha256; t=1630681606; cv=none; d=zohomail.com; s=zohoarc; b=eIFKDRxScrmARw/p8OWVj6UYH+9U3O5yIrXvnRa08cFoYdq+RvT5pR92aEvueq3tpvbGYI0jYPgxSlTaGLWbqoQTTTxarh1yJ7xFqbbBTS3dh+b+HTiBKYxqw7pBxNEAfJSP/c8X+y/PBYCfLamYzE0aytfL34v5IbGLatfg3WQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1630681606; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=X6+g8YK8ugcXGm10Da/blBL4IQsisq76l+m3qPb65X4=; b=gNH2ChyRgro6MyqW8nJEXxu8GLOuVXGx57dOyP4yCnDrwhKk0Lt9SmW5H6/vonGtIol3mRNOReEFgBGMwM0ZaCCEa9r8mSi9FBlsWuALLxoFmMtgiPK2Pyi78I0gjp+3j11n7HGekBX2oLGgplsCsE9k1+rhWcoJeSwMpICuCJY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1630681606; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding; bh=X6+g8YK8ugcXGm10Da/blBL4IQsisq76l+m3qPb65X4=; b=Y9JeDUu8fY+J7m3/RFW79S1nkc1pVjIcfOvBS7yPevkL6IBYpOiaP0uEChQbd3p8 bx3LXocsuxNUqYmVok5VgqvyeU43bIABNkASSoaoP7dSMb5j+3lDMnxiVSD9fzncfhy 8zR7o4Ljpd70au/OZPJX0YebnuDJyB2ezDIyhTks= From: "Daniel P. Smith" To: "Daniel P. Smith" , xen-devel@lists.xenproject.org Cc: Daniel De Graaf Subject: [PATCH v4 05/11] xsm: refactor xsm_ops handling Date: Fri, 3 Sep 2021 15:06:23 -0400 Message-Id: <20210903190629.11917-6-dpsmith@apertussolutions.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210903190629.11917-1-dpsmith@apertussolutions.com> References: <20210903190629.11917-1-dpsmith@apertussolutions.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-ZohoMailClient: External This renames the `struct xsm_operations` to the shorter `struct xsm_ops` and converts the global xsm_ops from being a pointer to an explicit instance. As part of this conversion, it reworks the XSM modules init function to return their xsm_ops struct which is copied in to the global xsm_ops instance. Signed-off-by: Daniel P. Smith --- xen/include/xsm/xsm.h | 222 +++++++++++++++++++++--------------------- xen/xsm/dummy.c | 4 +- xen/xsm/flask/hooks.c | 12 +-- xen/xsm/silo.c | 7 +- xen/xsm/xsm_core.c | 77 ++++++++------- 5 files changed, 167 insertions(+), 155 deletions(-) diff --git a/xen/include/xsm/xsm.h b/xen/include/xsm/xsm.h index 8878281eae..3888172045 100644 --- a/xen/include/xsm/xsm.h +++ b/xen/include/xsm/xsm.h @@ -46,7 +46,7 @@ enum xsm_default { }; typedef enum xsm_default xsm_default_t; -struct xsm_operations { +struct xsm_ops { void (*security_domaininfo)(struct domain *d, struct xen_domctl_getdomaininfo *info); int (*domain_create)(struct domain *d, uint32_t ssidref); @@ -201,63 +201,63 @@ struct xsm_operations { #ifdef CONFIG_XSM -extern struct xsm_operations *xsm_ops; +extern struct xsm_ops xsm_ops; #ifndef XSM_NO_WRAPPERS static inline void xsm_security_domaininfo(struct domain *d, struct xen_domctl_getdomaininfo *info) { - xsm_ops->security_domaininfo(d, info); + xsm_ops.security_domaininfo(d, info); } static inline int xsm_domain_create(xsm_default_t def, struct domain *d, uint32_t ssidref) { - return xsm_ops->domain_create(d, ssidref); + return xsm_ops.domain_create(d, ssidref); } static inline int xsm_getdomaininfo(xsm_default_t def, struct domain *d) { - return xsm_ops->getdomaininfo(d); + return xsm_ops.getdomaininfo(d); } static inline int xsm_domctl_scheduler_op(xsm_default_t def, struct domain *d, int cmd) { - return xsm_ops->domctl_scheduler_op(d, cmd); + return xsm_ops.domctl_scheduler_op(d, cmd); } static inline int xsm_sysctl_scheduler_op(xsm_default_t def, int cmd) { - return xsm_ops->sysctl_scheduler_op(cmd); + return xsm_ops.sysctl_scheduler_op(cmd); } static inline int xsm_set_target(xsm_default_t def, struct domain *d, struct domain *e) { - return xsm_ops->set_target(d, e); + return xsm_ops.set_target(d, e); } static inline int xsm_domctl(xsm_default_t def, struct domain *d, int cmd) { - return xsm_ops->domctl(d, cmd); + return xsm_ops.domctl(d, cmd); } static inline int xsm_sysctl(xsm_default_t def, int cmd) { - return xsm_ops->sysctl(cmd); + return xsm_ops.sysctl(cmd); } static inline int xsm_readconsole(xsm_default_t def, uint32_t clear) { - return xsm_ops->readconsole(clear); + return xsm_ops.readconsole(clear); } static inline int xsm_evtchn_unbound(xsm_default_t def, struct domain *d1, struct evtchn *chn, domid_t id2) { - return xsm_ops->evtchn_unbound(d1, chn, id2); + return xsm_ops.evtchn_unbound(d1, chn, id2); } static inline int xsm_evtchn_interdomain(xsm_default_t def, struct domain *d1, @@ -265,235 +265,235 @@ static inline int xsm_evtchn_interdomain(xsm_default_t def, struct domain *d1, struct domain *d2, struct evtchn *chan2) { - return xsm_ops->evtchn_interdomain(d1, chan1, d2, chan2); + return xsm_ops.evtchn_interdomain(d1, chan1, d2, chan2); } static inline void xsm_evtchn_close_post(struct evtchn *chn) { - xsm_ops->evtchn_close_post(chn); + xsm_ops.evtchn_close_post(chn); } static inline int xsm_evtchn_send(xsm_default_t def, struct domain *d, struct evtchn *chn) { - return xsm_ops->evtchn_send(d, chn); + return xsm_ops.evtchn_send(d, chn); } static inline int xsm_evtchn_status(xsm_default_t def, struct domain *d, struct evtchn *chn) { - return xsm_ops->evtchn_status(d, chn); + return xsm_ops.evtchn_status(d, chn); } static inline int xsm_evtchn_reset(xsm_default_t def, struct domain *d1, struct domain *d2) { - return xsm_ops->evtchn_reset(d1, d2); + return xsm_ops.evtchn_reset(d1, d2); } static inline int xsm_grant_mapref(xsm_default_t def, struct domain *d1, struct domain *d2, uint32_t flags) { - return xsm_ops->grant_mapref(d1, d2, flags); + return xsm_ops.grant_mapref(d1, d2, flags); } static inline int xsm_grant_unmapref(xsm_default_t def, struct domain *d1, struct domain *d2) { - return xsm_ops->grant_unmapref(d1, d2); + return xsm_ops.grant_unmapref(d1, d2); } static inline int xsm_grant_setup(xsm_default_t def, struct domain *d1, struct domain *d2) { - return xsm_ops->grant_setup(d1, d2); + return xsm_ops.grant_setup(d1, d2); } static inline int xsm_grant_transfer(xsm_default_t def, struct domain *d1, struct domain *d2) { - return xsm_ops->grant_transfer(d1, d2); + return xsm_ops.grant_transfer(d1, d2); } static inline int xsm_grant_copy(xsm_default_t def, struct domain *d1, struct domain *d2) { - return xsm_ops->grant_copy(d1, d2); + return xsm_ops.grant_copy(d1, d2); } static inline int xsm_grant_query_size(xsm_default_t def, struct domain *d1, struct domain *d2) { - return xsm_ops->grant_query_size(d1, d2); + return xsm_ops.grant_query_size(d1, d2); } static inline int xsm_alloc_security_domain(struct domain *d) { - return xsm_ops->alloc_security_domain(d); + return xsm_ops.alloc_security_domain(d); } static inline void xsm_free_security_domain(struct domain *d) { - xsm_ops->free_security_domain(d); + xsm_ops.free_security_domain(d); } static inline int xsm_alloc_security_evtchns(struct evtchn chn[], unsigned int nr) { - return xsm_ops->alloc_security_evtchns(chn, nr); + return xsm_ops.alloc_security_evtchns(chn, nr); } static inline void xsm_free_security_evtchns(struct evtchn chn[], unsigned int nr) { - xsm_ops->free_security_evtchns(chn, nr); + xsm_ops.free_security_evtchns(chn, nr); } static inline char *xsm_show_security_evtchn(struct domain *d, const struct evtchn *chn) { - return xsm_ops->show_security_evtchn(d, chn); + return xsm_ops.show_security_evtchn(d, chn); } static inline int xsm_init_hardware_domain(xsm_default_t def, struct domain *d) { - return xsm_ops->init_hardware_domain(d); + return xsm_ops.init_hardware_domain(d); } static inline int xsm_get_pod_target(xsm_default_t def, struct domain *d) { - return xsm_ops->get_pod_target(d); + return xsm_ops.get_pod_target(d); } static inline int xsm_set_pod_target(xsm_default_t def, struct domain *d) { - return xsm_ops->set_pod_target(d); + return xsm_ops.set_pod_target(d); } static inline int xsm_memory_exchange(xsm_default_t def, struct domain *d) { - return xsm_ops->memory_exchange(d); + return xsm_ops.memory_exchange(d); } static inline int xsm_memory_adjust_reservation(xsm_default_t def, struct domain *d1, struct domain *d2) { - return xsm_ops->memory_adjust_reservation(d1, d2); + return xsm_ops.memory_adjust_reservation(d1, d2); } static inline int xsm_memory_stat_reservation(xsm_default_t def, struct domain *d1, struct domain *d2) { - return xsm_ops->memory_stat_reservation(d1, d2); + return xsm_ops.memory_stat_reservation(d1, d2); } static inline int xsm_memory_pin_page(xsm_default_t def, struct domain *d1, struct domain *d2, struct page_info *page) { - return xsm_ops->memory_pin_page(d1, d2, page); + return xsm_ops.memory_pin_page(d1, d2, page); } static inline int xsm_add_to_physmap(xsm_default_t def, struct domain *d1, struct domain *d2) { - return xsm_ops->add_to_physmap(d1, d2); + return xsm_ops.add_to_physmap(d1, d2); } static inline int xsm_remove_from_physmap(xsm_default_t def, struct domain *d1, struct domain *d2) { - return xsm_ops->remove_from_physmap(d1, d2); + return xsm_ops.remove_from_physmap(d1, d2); } static inline int xsm_map_gmfn_foreign(xsm_default_t def, struct domain *d, struct domain *t) { - return xsm_ops->map_gmfn_foreign(d, t); + return xsm_ops.map_gmfn_foreign(d, t); } static inline int xsm_claim_pages(xsm_default_t def, struct domain *d) { - return xsm_ops->claim_pages(d); + return xsm_ops.claim_pages(d); } static inline int xsm_console_io(xsm_default_t def, struct domain *d, int cmd) { - return xsm_ops->console_io(d, cmd); + return xsm_ops.console_io(d, cmd); } static inline int xsm_profile(xsm_default_t def, struct domain *d, int op) { - return xsm_ops->profile(d, op); + return xsm_ops.profile(d, op); } static inline int xsm_kexec(xsm_default_t def) { - return xsm_ops->kexec(); + return xsm_ops.kexec(); } static inline int xsm_schedop_shutdown(xsm_default_t def, struct domain *d1, struct domain *d2) { - return xsm_ops->schedop_shutdown(d1, d2); + return xsm_ops.schedop_shutdown(d1, d2); } static inline char *xsm_show_irq_sid(int irq) { - return xsm_ops->show_irq_sid(irq); + return xsm_ops.show_irq_sid(irq); } static inline int xsm_map_domain_pirq(xsm_default_t def, struct domain *d) { - return xsm_ops->map_domain_pirq(d); + return xsm_ops.map_domain_pirq(d); } static inline int xsm_map_domain_irq(xsm_default_t def, struct domain *d, int irq, void *data) { - return xsm_ops->map_domain_irq(d, irq, data); + return xsm_ops.map_domain_irq(d, irq, data); } static inline int xsm_unmap_domain_pirq(xsm_default_t def, struct domain *d) { - return xsm_ops->unmap_domain_pirq(d); + return xsm_ops.unmap_domain_pirq(d); } static inline int xsm_unmap_domain_irq(xsm_default_t def, struct domain *d, int irq, void *data) { - return xsm_ops->unmap_domain_irq(d, irq, data); + return xsm_ops.unmap_domain_irq(d, irq, data); } static inline int xsm_bind_pt_irq(xsm_default_t def, struct domain *d, struct xen_domctl_bind_pt_irq *bind) { - return xsm_ops->bind_pt_irq(d, bind); + return xsm_ops.bind_pt_irq(d, bind); } static inline int xsm_unbind_pt_irq(xsm_default_t def, struct domain *d, struct xen_domctl_bind_pt_irq *bind) { - return xsm_ops->unbind_pt_irq(d, bind); + return xsm_ops.unbind_pt_irq(d, bind); } static inline int xsm_irq_permission(xsm_default_t def, struct domain *d, int pirq, uint8_t allow) { - return xsm_ops->irq_permission(d, pirq, allow); + return xsm_ops.irq_permission(d, pirq, allow); } static inline int xsm_iomem_permission(xsm_default_t def, struct domain *d, uint64_t s, uint64_t e, uint8_t allow) { - return xsm_ops->iomem_permission(d, s, e, allow); + return xsm_ops.iomem_permission(d, s, e, allow); } static inline int xsm_iomem_mapping(xsm_default_t def, struct domain *d, uint64_t s, uint64_t e, uint8_t allow) { - return xsm_ops->iomem_mapping(d, s, e, allow); + return xsm_ops.iomem_mapping(d, s, e, allow); } static inline int xsm_pci_config_permission(xsm_default_t def, struct domain *d, @@ -501,25 +501,25 @@ static inline int xsm_pci_config_permission(xsm_default_t def, struct domain *d, uint16_t start, uint16_t end, uint8_t access) { - return xsm_ops->pci_config_permission(d, machine_bdf, start, end, access); + return xsm_ops.pci_config_permission(d, machine_bdf, start, end, access); } #if defined(CONFIG_HAS_PASSTHROUGH) && defined(CONFIG_HAS_PCI) static inline int xsm_get_device_group(xsm_default_t def, uint32_t machine_bdf) { - return xsm_ops->get_device_group(machine_bdf); + return xsm_ops.get_device_group(machine_bdf); } static inline int xsm_assign_device(xsm_default_t def, struct domain *d, uint32_t machine_bdf) { - return xsm_ops->assign_device(d, machine_bdf); + return xsm_ops.assign_device(d, machine_bdf); } static inline int xsm_deassign_device(xsm_default_t def, struct domain *d, uint32_t machine_bdf) { - return xsm_ops->deassign_device(d, machine_bdf); + return xsm_ops.deassign_device(d, machine_bdf); } #endif /* HAS_PASSTHROUGH && HAS_PCI) */ @@ -527,254 +527,254 @@ static inline int xsm_deassign_device(xsm_default_t def, struct domain *d, static inline int xsm_assign_dtdevice(xsm_default_t def, struct domain *d, const char *dtpath) { - return xsm_ops->assign_dtdevice(d, dtpath); + return xsm_ops.assign_dtdevice(d, dtpath); } static inline int xsm_deassign_dtdevice(xsm_default_t def, struct domain *d, const char *dtpath) { - return xsm_ops->deassign_dtdevice(d, dtpath); + return xsm_ops.deassign_dtdevice(d, dtpath); } #endif /* HAS_PASSTHROUGH && HAS_DEVICE_TREE */ static inline int xsm_resource_plug_pci(xsm_default_t def, uint32_t machine_bdf) { - return xsm_ops->resource_plug_pci(machine_bdf); + return xsm_ops.resource_plug_pci(machine_bdf); } static inline int xsm_resource_unplug_pci(xsm_default_t def, uint32_t machine_bdf) { - return xsm_ops->resource_unplug_pci(machine_bdf); + return xsm_ops.resource_unplug_pci(machine_bdf); } static inline int xsm_resource_plug_core(xsm_default_t def) { - return xsm_ops->resource_plug_core(); + return xsm_ops.resource_plug_core(); } static inline int xsm_resource_unplug_core(xsm_default_t def) { - return xsm_ops->resource_unplug_core(); + return xsm_ops.resource_unplug_core(); } static inline int xsm_resource_setup_pci(xsm_default_t def, uint32_t machine_bdf) { - return xsm_ops->resource_setup_pci(machine_bdf); + return xsm_ops.resource_setup_pci(machine_bdf); } static inline int xsm_resource_setup_gsi(xsm_default_t def, int gsi) { - return xsm_ops->resource_setup_gsi(gsi); + return xsm_ops.resource_setup_gsi(gsi); } static inline int xsm_resource_setup_misc(xsm_default_t def) { - return xsm_ops->resource_setup_misc(); + return xsm_ops.resource_setup_misc(); } static inline int xsm_page_offline(xsm_default_t def, uint32_t cmd) { - return xsm_ops->page_offline(cmd); + return xsm_ops.page_offline(cmd); } static inline int xsm_hypfs_op(xsm_default_t def) { - return xsm_ops->hypfs_op(); + return xsm_ops.hypfs_op(); } static inline long xsm_do_xsm_op(XEN_GUEST_HANDLE_PARAM(void) op) { - return xsm_ops->do_xsm_op(op); + return xsm_ops.do_xsm_op(op); } #ifdef CONFIG_COMPAT static inline int xsm_do_compat_op(XEN_GUEST_HANDLE_PARAM(void) op) { - return xsm_ops->do_compat_op(op); + return xsm_ops.do_compat_op(op); } #endif static inline int xsm_hvm_param(xsm_default_t def, struct domain *d, unsigned long op) { - return xsm_ops->hvm_param(d, op); + return xsm_ops.hvm_param(d, op); } static inline int xsm_hvm_control(xsm_default_t def, struct domain *d, unsigned long op) { - return xsm_ops->hvm_control(d, op); + return xsm_ops.hvm_control(d, op); } static inline int xsm_hvm_param_altp2mhvm(xsm_default_t def, struct domain *d) { - return xsm_ops->hvm_param_altp2mhvm(d); + return xsm_ops.hvm_param_altp2mhvm(d); } static inline int xsm_hvm_altp2mhvm_op(xsm_default_t def, struct domain *d, uint64_t mode, uint32_t op) { - return xsm_ops->hvm_altp2mhvm_op(d, mode, op); + return xsm_ops.hvm_altp2mhvm_op(d, mode, op); } static inline int xsm_get_vnumainfo(xsm_default_t def, struct domain *d) { - return xsm_ops->get_vnumainfo(d); + return xsm_ops.get_vnumainfo(d); } static inline int xsm_vm_event_control(xsm_default_t def, struct domain *d, int mode, int op) { - return xsm_ops->vm_event_control(d, mode, op); + return xsm_ops.vm_event_control(d, mode, op); } #ifdef CONFIG_MEM_ACCESS static inline int xsm_mem_access(xsm_default_t def, struct domain *d) { - return xsm_ops->mem_access(d); + return xsm_ops.mem_access(d); } #endif #ifdef CONFIG_MEM_PAGING static inline int xsm_mem_paging(xsm_default_t def, struct domain *d) { - return xsm_ops->mem_paging(d); + return xsm_ops.mem_paging(d); } #endif #ifdef CONFIG_MEM_SHARING static inline int xsm_mem_sharing(xsm_default_t def, struct domain *d) { - return xsm_ops->mem_sharing(d); + return xsm_ops.mem_sharing(d); } #endif static inline int xsm_platform_op(xsm_default_t def, uint32_t op) { - return xsm_ops->platform_op(op); + return xsm_ops.platform_op(op); } #ifdef CONFIG_X86 static inline int xsm_do_mca(xsm_default_t def) { - return xsm_ops->do_mca(); + return xsm_ops.do_mca(); } static inline int xsm_shadow_control(xsm_default_t def, struct domain *d, uint32_t op) { - return xsm_ops->shadow_control(d, op); + return xsm_ops.shadow_control(d, op); } static inline int xsm_mem_sharing_op(xsm_default_t def, struct domain *d, struct domain *cd, int op) { - return xsm_ops->mem_sharing_op(d, cd, op); + return xsm_ops.mem_sharing_op(d, cd, op); } static inline int xsm_apic(xsm_default_t def, struct domain *d, int cmd) { - return xsm_ops->apic(d, cmd); + return xsm_ops.apic(d, cmd); } static inline int xsm_memtype(xsm_default_t def, uint32_t access) { - return xsm_ops->memtype(access); + return xsm_ops.memtype(access); } static inline int xsm_machine_memory_map(xsm_default_t def) { - return xsm_ops->machine_memory_map(); + return xsm_ops.machine_memory_map(); } static inline int xsm_domain_memory_map(xsm_default_t def, struct domain *d) { - return xsm_ops->domain_memory_map(d); + return xsm_ops.domain_memory_map(d); } static inline int xsm_mmu_update(xsm_default_t def, struct domain *d, struct domain *t, struct domain *f, uint32_t flags) { - return xsm_ops->mmu_update(d, t, f, flags); + return xsm_ops.mmu_update(d, t, f, flags); } static inline int xsm_mmuext_op(xsm_default_t def, struct domain *d, struct domain *f) { - return xsm_ops->mmuext_op(d, f); + return xsm_ops.mmuext_op(d, f); } static inline int xsm_update_va_mapping(xsm_default_t def, struct domain *d, struct domain *f, l1_pgentry_t pte) { - return xsm_ops->update_va_mapping(d, f, pte); + return xsm_ops.update_va_mapping(d, f, pte); } static inline int xsm_priv_mapping(xsm_default_t def, struct domain *d, struct domain *t) { - return xsm_ops->priv_mapping(d, t); + return xsm_ops.priv_mapping(d, t); } static inline int xsm_ioport_permission(xsm_default_t def, struct domain *d, uint32_t s, uint32_t e, uint8_t allow) { - return xsm_ops->ioport_permission(d, s, e, allow); + return xsm_ops.ioport_permission(d, s, e, allow); } static inline int xsm_ioport_mapping(xsm_default_t def, struct domain *d, uint32_t s, uint32_t e, uint8_t allow) { - return xsm_ops->ioport_mapping(d, s, e, allow); + return xsm_ops.ioport_mapping(d, s, e, allow); } static inline int xsm_pmu_op(xsm_default_t def, struct domain *d, unsigned int op) { - return xsm_ops->pmu_op(d, op); + return xsm_ops.pmu_op(d, op); } #endif /* CONFIG_X86 */ static inline int xsm_dm_op(xsm_default_t def, struct domain *d) { - return xsm_ops->dm_op(d); + return xsm_ops.dm_op(d); } static inline int xsm_xen_version(xsm_default_t def, uint32_t op) { - return xsm_ops->xen_version(op); + return xsm_ops.xen_version(op); } static inline int xsm_domain_resource_map(xsm_default_t def, struct domain *d) { - return xsm_ops->domain_resource_map(d); + return xsm_ops.domain_resource_map(d); } #ifdef CONFIG_ARGO static inline int xsm_argo_enable(const struct domain *d) { - return xsm_ops->argo_enable(d); + return xsm_ops.argo_enable(d); } static inline int xsm_argo_register_single_source(const struct domain *d, const struct domain *t) { - return xsm_ops->argo_register_single_source(d, t); + return xsm_ops.argo_register_single_source(d, t); } static inline int xsm_argo_register_any_source(const struct domain *d) { - return xsm_ops->argo_register_any_source(d); + return xsm_ops.argo_register_any_source(d); } static inline int xsm_argo_send(const struct domain *d, const struct domain *t) { - return xsm_ops->argo_send(d, t); + return xsm_ops.argo_send(d, t); } #endif /* CONFIG_ARGO */ @@ -801,17 +801,18 @@ int xsm_dt_policy_init(void **policy_buffer, size_t *policy_size); bool has_xsm_magic(paddr_t); #endif -int register_xsm(struct xsm_operations *ops); +extern struct xsm_ops dummy_xsm_ops; -extern struct xsm_operations dummy_xsm_ops; - -void xsm_fixup_ops(struct xsm_operations *ops); +void xsm_fixup_ops(struct xsm_ops *ops); #ifdef CONFIG_XSM_FLASK -void flask_init(const void *policy_buffer, size_t policy_size); +extern const struct xsm_ops *flask_init(const void *policy_buffer, + size_t policy_size); #else -static inline void flask_init(const void *policy_buffer, size_t policy_size) +static const inline struct xsm_ops *flask_init(const void *policy_buffer, + size_t policy_size) { + return NULL; } #endif @@ -821,9 +822,12 @@ extern const unsigned int xsm_flask_init_policy_size; #endif #ifdef CONFIG_XSM_SILO -void silo_init(void); +extern const struct xsm_ops *silo_init(void); #else -static inline void silo_init(void) {} +static const inline struct xsm_ops *silo_init(void) +{ + return NULL; +} #endif #else /* CONFIG_XSM */ diff --git a/xen/xsm/dummy.c b/xen/xsm/dummy.c index de44b10130..d8c935328e 100644 --- a/xen/xsm/dummy.c +++ b/xen/xsm/dummy.c @@ -13,15 +13,13 @@ #define XSM_NO_WRAPPERS #include -struct xsm_operations dummy_xsm_ops; - #define set_to_dummy_if_null(ops, function) \ do { \ if ( !ops->function ) \ ops->function = xsm_##function; \ } while (0) -void __init xsm_fixup_ops (struct xsm_operations *ops) +void __init xsm_fixup_ops (struct xsm_ops *ops) { set_to_dummy_if_null(ops, security_domaininfo); set_to_dummy_if_null(ops, domain_create); diff --git a/xen/xsm/flask/hooks.c b/xen/xsm/flask/hooks.c index 1465db125a..25e87180b4 100644 --- a/xen/xsm/flask/hooks.c +++ b/xen/xsm/flask/hooks.c @@ -1745,7 +1745,7 @@ static int flask_argo_send(const struct domain *d, const struct domain *t) long do_flask_op(XEN_GUEST_HANDLE_PARAM(void) u_flask_op); int compat_flask_op(XEN_GUEST_HANDLE_PARAM(void) u_flask_op); -static struct xsm_operations flask_ops = { +static const struct xsm_ops __initconstrel flask_ops = { .security_domaininfo = flask_security_domaininfo, .domain_create = flask_domain_create, .getdomaininfo = flask_getdomaininfo, @@ -1883,7 +1883,8 @@ static struct xsm_operations flask_ops = { #endif }; -void __init flask_init(const void *policy_buffer, size_t policy_size) +const struct xsm_ops *__init flask_init(const void *policy_buffer, + size_t policy_size) { int ret = -ENOENT; @@ -1891,7 +1892,7 @@ void __init flask_init(const void *policy_buffer, size_t policy_size) { case FLASK_BOOTPARAM_DISABLED: printk(XENLOG_INFO "Flask: Disabled at boot.\n"); - return; + return NULL; case FLASK_BOOTPARAM_PERMISSIVE: flask_enforcing = 0; @@ -1908,9 +1909,6 @@ void __init flask_init(const void *policy_buffer, size_t policy_size) avc_init(); - if ( register_xsm(&flask_ops) ) - panic("Flask: Unable to register with XSM\n"); - if ( policy_size && flask_bootparam != FLASK_BOOTPARAM_LATELOAD ) ret = security_load_policy(policy_buffer, policy_size); @@ -1923,6 +1921,8 @@ void __init flask_init(const void *policy_buffer, size_t policy_size) printk(XENLOG_INFO "Flask: Starting in enforcing mode.\n"); else printk(XENLOG_INFO "Flask: Starting in permissive mode.\n"); + + return &flask_ops; } /* diff --git a/xen/xsm/silo.c b/xen/xsm/silo.c index fc2ca5cd2d..3550dded7b 100644 --- a/xen/xsm/silo.c +++ b/xen/xsm/silo.c @@ -100,7 +100,7 @@ static int silo_argo_send(const struct domain *d1, const struct domain *d2) #endif -static struct xsm_operations silo_xsm_ops = { +static const struct xsm_ops __initconstrel silo_xsm_ops = { .evtchn_unbound = silo_evtchn_unbound, .evtchn_interdomain = silo_evtchn_interdomain, .grant_mapref = silo_grant_mapref, @@ -112,12 +112,11 @@ static struct xsm_operations silo_xsm_ops = { #endif }; -void __init silo_init(void) +const struct xsm_ops *__init silo_init(void) { printk("Initialising XSM SILO mode\n"); - if ( register_xsm(&silo_xsm_ops) ) - panic("SILO: Unable to register with XSM\n"); + return &silo_xsm_ops; } /* diff --git a/xen/xsm/xsm_core.c b/xen/xsm/xsm_core.c index 55483292c5..859af3fe9a 100644 --- a/xen/xsm/xsm_core.c +++ b/xen/xsm/xsm_core.c @@ -28,9 +28,17 @@ #include #endif -#define XSM_FRAMEWORK_VERSION "1.0.0" +#define XSM_FRAMEWORK_VERSION "1.0.1" -struct xsm_operations *xsm_ops; +struct xsm_ops __read_mostly xsm_ops; + +enum xsm_ops_state { + XSM_OPS_UNREGISTERED, + XSM_OPS_REG_FAILED, + XSM_OPS_REGISTERED, +}; + +static enum xsm_ops_state xsm_ops_registered = XSM_OPS_UNREGISTERED; enum xsm_bootparam { XSM_BOOTPARAM_DUMMY, @@ -68,17 +76,10 @@ static int __init parse_xsm_param(const char *s) } custom_param("xsm", parse_xsm_param); -static inline int verify(struct xsm_operations *ops) -{ - /* verify the security_operations structure exists */ - if ( !ops ) - return -EINVAL; - xsm_fixup_ops(ops); - return 0; -} - static int __init xsm_core_init(const void *policy_buffer, size_t policy_size) { + const struct xsm_ops *ops = NULL; + #ifdef CONFIG_XSM_FLASK_POLICY if ( policy_size == 0 ) { @@ -87,25 +88,35 @@ static int __init xsm_core_init(const void *policy_buffer, size_t policy_size) } #endif - if ( verify(&dummy_xsm_ops) ) + if ( xsm_ops_registered != XSM_OPS_UNREGISTERED ) { - printk(XENLOG_ERR "Could not verify dummy_xsm_ops structure\n"); + printk(XENLOG_ERR + "Could not init XSM, xsm_ops register already attempted\n"); return -EIO; } - xsm_ops = &dummy_xsm_ops; - switch ( xsm_bootparam ) { case XSM_BOOTPARAM_DUMMY: + xsm_ops_registered = XSM_OPS_REGISTERED; break; case XSM_BOOTPARAM_FLASK: - flask_init(policy_buffer, policy_size); + ops = flask_init(policy_buffer, policy_size); + if ( ops ) + { + xsm_ops_registered = XSM_OPS_REGISTERED; + xsm_ops = *ops; + } break; case XSM_BOOTPARAM_SILO: - silo_init(); + ops = silo_init(); + if ( ops ) + { + xsm_ops_registered = XSM_OPS_REGISTERED; + xsm_ops = *ops; + } break; default: @@ -113,6 +124,22 @@ static int __init xsm_core_init(const void *policy_buffer, size_t policy_size) break; } + /* + * This handles three cases, + * - dummy policy module was selected + * - a policy module does not provide all handlers + * - a policy module failed to init + */ + xsm_fixup_ops(&xsm_ops); + + if ( xsm_ops_registered != XSM_OPS_REGISTERED ) + { + xsm_ops_registered = XSM_OPS_REG_FAILED; + printk(XENLOG_ERR + "Could not init XSM, xsm_ops register failed\n"); + return -EFAULT; + } + return 0; } @@ -195,22 +222,6 @@ bool __init has_xsm_magic(paddr_t start) } #endif -int __init register_xsm(struct xsm_operations *ops) -{ - if ( verify(ops) ) - { - printk(XENLOG_ERR "Could not verify xsm_operations structure\n"); - return -EINVAL; - } - - if ( xsm_ops != &dummy_xsm_ops ) - return -EAGAIN; - - xsm_ops = ops; - - return 0; -} - #endif long do_xsm_op(XEN_GUEST_HANDLE_PARAM(void) op) -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Fri Sep 03 15:07:59 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Sep 2021 15:07:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.178154.324060 (Exim 4.92) (envelope-from ) id 1mMAnO-0000SB-U2; Fri, 03 Sep 2021 15:07:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 178154.324060; Fri, 03 Sep 2021 15:07:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMAnO-0000S0-Qq; Fri, 03 Sep 2021 15:07:58 +0000 Received: by outflank-mailman (input) for mailman id 178154; Fri, 03 Sep 2021 15:07:57 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMAnN-0000Q7-A6 for xen-devel@lists.xenproject.org; Fri, 03 Sep 2021 15:07:57 +0000 Received: from sender4-of-o51.zoho.com (unknown [136.143.188.51]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id bd47d666-a0d2-4a61-9a1b-0a2108c7308c; Fri, 03 Sep 2021 15:07:54 +0000 (UTC) Received: from sisyou.hme. (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1630681604081256.72926272893255; Fri, 3 Sep 2021 08:06:44 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bd47d666-a0d2-4a61-9a1b-0a2108c7308c ARC-Seal: i=1; a=rsa-sha256; t=1630681607; cv=none; d=zohomail.com; s=zohoarc; b=JbOkoHYCPySdEX9PZGt3yscfuAgkoQX8YqoESAfjPtK/XjQXJRr0QN2zkBpA022dk9IiM6ShQY2g8RKa756W5QjYA5tCGJ6o9engPp/ZdrVJLRCkzK/kG2als3kTLyzJuis5VPdpe6omYy3k0FgTLqITjwJB+hdT6LvHYHNeAXc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1630681607; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=btatsPGI8kHRMfkQ9bgKzedkDOL0m29FjBRocaAF20Y=; b=iXCe3z/Ns0O5dlX2CTpASRHNMIROVr6ELgDq40DXzGbIkXuAj37MfVak0egzD7usDnSj0xRF2MbL6if5JQ/MZAfZfhfBlNb89t8ZoqAyVwzFmawMkexe/F4pwNF1FVQ+By54/VSdao0GtvGVBi3ONZgvj6jQs+kaWw3tmbbCmu8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1630681607; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding; bh=btatsPGI8kHRMfkQ9bgKzedkDOL0m29FjBRocaAF20Y=; b=nUDIe9c7qU4fS8RRNCitcuz818AOYSdaUFb2sDY4KfUmEgevhrnBvH+Xfa3owGu3 ccRNtUEh6COwcG/tF9N8w7y4e1tLzyUrr8qOWpJesGdKvlnZ7m8VNVx5xP3BuMNYP+f nwICN6gbYDcL3eCC4pi8RyZ8cjFTLPiUhKnayYvQ= From: "Daniel P. Smith" To: "Daniel P. Smith" , xen-devel@lists.xenproject.org Cc: Andrew Cooper , Daniel De Graaf Subject: [PATCH v4 06/11] xsm: convert xsm_ops hook calls to alternative call Date: Fri, 3 Sep 2021 15:06:24 -0400 Message-Id: <20210903190629.11917-7-dpsmith@apertussolutions.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210903190629.11917-1-dpsmith@apertussolutions.com> References: <20210903190629.11917-1-dpsmith@apertussolutions.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-ZohoMailClient: External To reduce retpolines convert all the pointer function calls of the xsm_ops hooks over to the alternative_call infrastructure. Signed-off-by: Daniel P. Smith Acked-by: Andrew Cooper --- xen/include/xsm/xsm.h | 193 +++++++++++++++++++++--------------------- 1 file changed, 97 insertions(+), 96 deletions(-) diff --git a/xen/include/xsm/xsm.h b/xen/include/xsm/xsm.h index 3888172045..d7ef412874 100644 --- a/xen/include/xsm/xsm.h +++ b/xen/include/xsm/xsm.h @@ -15,6 +15,7 @@ #ifndef __XSM_H__ #define __XSM_H__ +#include #include #include @@ -208,56 +209,56 @@ extern struct xsm_ops xsm_ops; static inline void xsm_security_domaininfo(struct domain *d, struct xen_domctl_getdomaininfo *info) { - xsm_ops.security_domaininfo(d, info); + alternative_vcall(xsm_ops.security_domaininfo, d, info); } static inline int xsm_domain_create(xsm_default_t def, struct domain *d, uint32_t ssidref) { - return xsm_ops.domain_create(d, ssidref); + return alternative_call(xsm_ops.domain_create, d, ssidref); } static inline int xsm_getdomaininfo(xsm_default_t def, struct domain *d) { - return xsm_ops.getdomaininfo(d); + return alternative_call(xsm_ops.getdomaininfo, d); } static inline int xsm_domctl_scheduler_op(xsm_default_t def, struct domain *d, int cmd) { - return xsm_ops.domctl_scheduler_op(d, cmd); + return alternative_call(xsm_ops.domctl_scheduler_op, d, cmd); } static inline int xsm_sysctl_scheduler_op(xsm_default_t def, int cmd) { - return xsm_ops.sysctl_scheduler_op(cmd); + return alternative_call(xsm_ops.sysctl_scheduler_op, cmd); } static inline int xsm_set_target(xsm_default_t def, struct domain *d, struct domain *e) { - return xsm_ops.set_target(d, e); + return alternative_call(xsm_ops.set_target, d, e); } static inline int xsm_domctl(xsm_default_t def, struct domain *d, int cmd) { - return xsm_ops.domctl(d, cmd); + return alternative_call(xsm_ops.domctl, d, cmd); } static inline int xsm_sysctl(xsm_default_t def, int cmd) { - return xsm_ops.sysctl(cmd); + return alternative_call(xsm_ops.sysctl, cmd); } static inline int xsm_readconsole(xsm_default_t def, uint32_t clear) { - return xsm_ops.readconsole(clear); + return alternative_call(xsm_ops.readconsole, clear); } static inline int xsm_evtchn_unbound(xsm_default_t def, struct domain *d1, struct evtchn *chn, domid_t id2) { - return xsm_ops.evtchn_unbound(d1, chn, id2); + return alternative_call(xsm_ops.evtchn_unbound, d1, chn, id2); } static inline int xsm_evtchn_interdomain(xsm_default_t def, struct domain *d1, @@ -265,235 +266,235 @@ static inline int xsm_evtchn_interdomain(xsm_default_t def, struct domain *d1, struct domain *d2, struct evtchn *chan2) { - return xsm_ops.evtchn_interdomain(d1, chan1, d2, chan2); + return alternative_call(xsm_ops.evtchn_interdomain, d1, chan1, d2, chan2); } static inline void xsm_evtchn_close_post(struct evtchn *chn) { - xsm_ops.evtchn_close_post(chn); + alternative_vcall(xsm_ops.evtchn_close_post, chn); } static inline int xsm_evtchn_send(xsm_default_t def, struct domain *d, struct evtchn *chn) { - return xsm_ops.evtchn_send(d, chn); + return alternative_call(xsm_ops.evtchn_send, d, chn); } static inline int xsm_evtchn_status(xsm_default_t def, struct domain *d, struct evtchn *chn) { - return xsm_ops.evtchn_status(d, chn); + return alternative_call(xsm_ops.evtchn_status, d, chn); } static inline int xsm_evtchn_reset(xsm_default_t def, struct domain *d1, struct domain *d2) { - return xsm_ops.evtchn_reset(d1, d2); + return alternative_call(xsm_ops.evtchn_reset, d1, d2); } static inline int xsm_grant_mapref(xsm_default_t def, struct domain *d1, struct domain *d2, uint32_t flags) { - return xsm_ops.grant_mapref(d1, d2, flags); + return alternative_call(xsm_ops.grant_mapref, d1, d2, flags); } static inline int xsm_grant_unmapref(xsm_default_t def, struct domain *d1, struct domain *d2) { - return xsm_ops.grant_unmapref(d1, d2); + return alternative_call(xsm_ops.grant_unmapref, d1, d2); } static inline int xsm_grant_setup(xsm_default_t def, struct domain *d1, struct domain *d2) { - return xsm_ops.grant_setup(d1, d2); + return alternative_call(xsm_ops.grant_setup, d1, d2); } static inline int xsm_grant_transfer(xsm_default_t def, struct domain *d1, struct domain *d2) { - return xsm_ops.grant_transfer(d1, d2); + return alternative_call(xsm_ops.grant_transfer, d1, d2); } static inline int xsm_grant_copy(xsm_default_t def, struct domain *d1, struct domain *d2) { - return xsm_ops.grant_copy(d1, d2); + return alternative_call(xsm_ops.grant_copy, d1, d2); } static inline int xsm_grant_query_size(xsm_default_t def, struct domain *d1, struct domain *d2) { - return xsm_ops.grant_query_size(d1, d2); + return alternative_call(xsm_ops.grant_query_size, d1, d2); } static inline int xsm_alloc_security_domain(struct domain *d) { - return xsm_ops.alloc_security_domain(d); + return alternative_call(xsm_ops.alloc_security_domain, d); } static inline void xsm_free_security_domain(struct domain *d) { - xsm_ops.free_security_domain(d); + alternative_vcall(xsm_ops.free_security_domain, d); } static inline int xsm_alloc_security_evtchns(struct evtchn chn[], unsigned int nr) { - return xsm_ops.alloc_security_evtchns(chn, nr); + return alternative_call(xsm_ops.alloc_security_evtchns, chn, nr); } static inline void xsm_free_security_evtchns(struct evtchn chn[], unsigned int nr) { - xsm_ops.free_security_evtchns(chn, nr); + alternative_vcall(xsm_ops.free_security_evtchns, chn, nr); } static inline char *xsm_show_security_evtchn(struct domain *d, const struct evtchn *chn) { - return xsm_ops.show_security_evtchn(d, chn); + return alternative_call(xsm_ops.show_security_evtchn, d, chn); } static inline int xsm_init_hardware_domain(xsm_default_t def, struct domain *d) { - return xsm_ops.init_hardware_domain(d); + return alternative_call(xsm_ops.init_hardware_domain, d); } static inline int xsm_get_pod_target(xsm_default_t def, struct domain *d) { - return xsm_ops.get_pod_target(d); + return alternative_call(xsm_ops.get_pod_target, d); } static inline int xsm_set_pod_target(xsm_default_t def, struct domain *d) { - return xsm_ops.set_pod_target(d); + return alternative_call(xsm_ops.set_pod_target, d); } static inline int xsm_memory_exchange(xsm_default_t def, struct domain *d) { - return xsm_ops.memory_exchange(d); + return alternative_call(xsm_ops.memory_exchange, d); } static inline int xsm_memory_adjust_reservation(xsm_default_t def, struct domain *d1, struct domain *d2) { - return xsm_ops.memory_adjust_reservation(d1, d2); + return alternative_call(xsm_ops.memory_adjust_reservation, d1, d2); } static inline int xsm_memory_stat_reservation(xsm_default_t def, struct domain *d1, struct domain *d2) { - return xsm_ops.memory_stat_reservation(d1, d2); + return alternative_call(xsm_ops.memory_stat_reservation, d1, d2); } static inline int xsm_memory_pin_page(xsm_default_t def, struct domain *d1, struct domain *d2, struct page_info *page) { - return xsm_ops.memory_pin_page(d1, d2, page); + return alternative_call(xsm_ops.memory_pin_page, d1, d2, page); } static inline int xsm_add_to_physmap(xsm_default_t def, struct domain *d1, struct domain *d2) { - return xsm_ops.add_to_physmap(d1, d2); + return alternative_call(xsm_ops.add_to_physmap, d1, d2); } static inline int xsm_remove_from_physmap(xsm_default_t def, struct domain *d1, struct domain *d2) { - return xsm_ops.remove_from_physmap(d1, d2); + return alternative_call(xsm_ops.remove_from_physmap, d1, d2); } static inline int xsm_map_gmfn_foreign(xsm_default_t def, struct domain *d, struct domain *t) { - return xsm_ops.map_gmfn_foreign(d, t); + return alternative_call(xsm_ops.map_gmfn_foreign, d, t); } static inline int xsm_claim_pages(xsm_default_t def, struct domain *d) { - return xsm_ops.claim_pages(d); + return alternative_call(xsm_ops.claim_pages, d); } static inline int xsm_console_io(xsm_default_t def, struct domain *d, int cmd) { - return xsm_ops.console_io(d, cmd); + return alternative_call(xsm_ops.console_io, d, cmd); } static inline int xsm_profile(xsm_default_t def, struct domain *d, int op) { - return xsm_ops.profile(d, op); + return alternative_call(xsm_ops.profile, d, op); } static inline int xsm_kexec(xsm_default_t def) { - return xsm_ops.kexec(); + return alternative_call(xsm_ops.kexec); } static inline int xsm_schedop_shutdown(xsm_default_t def, struct domain *d1, struct domain *d2) { - return xsm_ops.schedop_shutdown(d1, d2); + return alternative_call(xsm_ops.schedop_shutdown, d1, d2); } static inline char *xsm_show_irq_sid(int irq) { - return xsm_ops.show_irq_sid(irq); + return alternative_call(xsm_ops.show_irq_sid, irq); } static inline int xsm_map_domain_pirq(xsm_default_t def, struct domain *d) { - return xsm_ops.map_domain_pirq(d); + return alternative_call(xsm_ops.map_domain_pirq, d); } static inline int xsm_map_domain_irq(xsm_default_t def, struct domain *d, int irq, void *data) { - return xsm_ops.map_domain_irq(d, irq, data); + return alternative_call(xsm_ops.map_domain_irq, d, irq, data); } static inline int xsm_unmap_domain_pirq(xsm_default_t def, struct domain *d) { - return xsm_ops.unmap_domain_pirq(d); + return alternative_call(xsm_ops.unmap_domain_pirq, d); } static inline int xsm_unmap_domain_irq(xsm_default_t def, struct domain *d, int irq, void *data) { - return xsm_ops.unmap_domain_irq(d, irq, data); + return alternative_call(xsm_ops.unmap_domain_irq, d, irq, data); } static inline int xsm_bind_pt_irq(xsm_default_t def, struct domain *d, struct xen_domctl_bind_pt_irq *bind) { - return xsm_ops.bind_pt_irq(d, bind); + return alternative_call(xsm_ops.bind_pt_irq, d, bind); } static inline int xsm_unbind_pt_irq(xsm_default_t def, struct domain *d, struct xen_domctl_bind_pt_irq *bind) { - return xsm_ops.unbind_pt_irq(d, bind); + return alternative_call(xsm_ops.unbind_pt_irq, d, bind); } static inline int xsm_irq_permission(xsm_default_t def, struct domain *d, int pirq, uint8_t allow) { - return xsm_ops.irq_permission(d, pirq, allow); + return alternative_call(xsm_ops.irq_permission, d, pirq, allow); } static inline int xsm_iomem_permission(xsm_default_t def, struct domain *d, uint64_t s, uint64_t e, uint8_t allow) { - return xsm_ops.iomem_permission(d, s, e, allow); + return alternative_call(xsm_ops.iomem_permission, d, s, e, allow); } static inline int xsm_iomem_mapping(xsm_default_t def, struct domain *d, uint64_t s, uint64_t e, uint8_t allow) { - return xsm_ops.iomem_mapping(d, s, e, allow); + return alternative_call(xsm_ops.iomem_mapping, d, s, e, allow); } static inline int xsm_pci_config_permission(xsm_default_t def, struct domain *d, @@ -501,25 +502,25 @@ static inline int xsm_pci_config_permission(xsm_default_t def, struct domain *d, uint16_t start, uint16_t end, uint8_t access) { - return xsm_ops.pci_config_permission(d, machine_bdf, start, end, access); + return alternative_call(xsm_ops.pci_config_permission, d, machine_bdf, start, end, access); } #if defined(CONFIG_HAS_PASSTHROUGH) && defined(CONFIG_HAS_PCI) static inline int xsm_get_device_group(xsm_default_t def, uint32_t machine_bdf) { - return xsm_ops.get_device_group(machine_bdf); + return alternative_call(xsm_ops.get_device_group, machine_bdf); } static inline int xsm_assign_device(xsm_default_t def, struct domain *d, uint32_t machine_bdf) { - return xsm_ops.assign_device(d, machine_bdf); + return alternative_call(xsm_ops.assign_device, d, machine_bdf); } static inline int xsm_deassign_device(xsm_default_t def, struct domain *d, uint32_t machine_bdf) { - return xsm_ops.deassign_device(d, machine_bdf); + return alternative_call(xsm_ops.deassign_device, d, machine_bdf); } #endif /* HAS_PASSTHROUGH && HAS_PCI) */ @@ -527,62 +528,62 @@ static inline int xsm_deassign_device(xsm_default_t def, struct domain *d, static inline int xsm_assign_dtdevice(xsm_default_t def, struct domain *d, const char *dtpath) { - return xsm_ops.assign_dtdevice(d, dtpath); + return alternative_call(xsm_ops.assign_dtdevice, d, dtpath); } static inline int xsm_deassign_dtdevice(xsm_default_t def, struct domain *d, const char *dtpath) { - return xsm_ops.deassign_dtdevice(d, dtpath); + return alternative_call(xsm_ops.deassign_dtdevice, d, dtpath); } #endif /* HAS_PASSTHROUGH && HAS_DEVICE_TREE */ static inline int xsm_resource_plug_pci(xsm_default_t def, uint32_t machine_bdf) { - return xsm_ops.resource_plug_pci(machine_bdf); + return alternative_call(xsm_ops.resource_plug_pci, machine_bdf); } static inline int xsm_resource_unplug_pci(xsm_default_t def, uint32_t machine_bdf) { - return xsm_ops.resource_unplug_pci(machine_bdf); + return alternative_call(xsm_ops.resource_unplug_pci, machine_bdf); } static inline int xsm_resource_plug_core(xsm_default_t def) { - return xsm_ops.resource_plug_core(); + return alternative_call(xsm_ops.resource_plug_core); } static inline int xsm_resource_unplug_core(xsm_default_t def) { - return xsm_ops.resource_unplug_core(); + return alternative_call(xsm_ops.resource_unplug_core); } static inline int xsm_resource_setup_pci(xsm_default_t def, uint32_t machine_bdf) { - return xsm_ops.resource_setup_pci(machine_bdf); + return alternative_call(xsm_ops.resource_setup_pci, machine_bdf); } static inline int xsm_resource_setup_gsi(xsm_default_t def, int gsi) { - return xsm_ops.resource_setup_gsi(gsi); + return alternative_call(xsm_ops.resource_setup_gsi, gsi); } static inline int xsm_resource_setup_misc(xsm_default_t def) { - return xsm_ops.resource_setup_misc(); + return alternative_call(xsm_ops.resource_setup_misc); } static inline int xsm_page_offline(xsm_default_t def, uint32_t cmd) { - return xsm_ops.page_offline(cmd); + return alternative_call(xsm_ops.page_offline, cmd); } static inline int xsm_hypfs_op(xsm_default_t def) { - return xsm_ops.hypfs_op(); + return alternative_call(xsm_ops.hypfs_op); } static inline long xsm_do_xsm_op(XEN_GUEST_HANDLE_PARAM(void) op) @@ -600,112 +601,112 @@ static inline int xsm_do_compat_op(XEN_GUEST_HANDLE_PARAM(void) op) static inline int xsm_hvm_param(xsm_default_t def, struct domain *d, unsigned long op) { - return xsm_ops.hvm_param(d, op); + return alternative_call(xsm_ops.hvm_param, d, op); } static inline int xsm_hvm_control(xsm_default_t def, struct domain *d, unsigned long op) { - return xsm_ops.hvm_control(d, op); + return alternative_call(xsm_ops.hvm_control, d, op); } static inline int xsm_hvm_param_altp2mhvm(xsm_default_t def, struct domain *d) { - return xsm_ops.hvm_param_altp2mhvm(d); + return alternative_call(xsm_ops.hvm_param_altp2mhvm, d); } static inline int xsm_hvm_altp2mhvm_op(xsm_default_t def, struct domain *d, uint64_t mode, uint32_t op) { - return xsm_ops.hvm_altp2mhvm_op(d, mode, op); + return alternative_call(xsm_ops.hvm_altp2mhvm_op, d, mode, op); } static inline int xsm_get_vnumainfo(xsm_default_t def, struct domain *d) { - return xsm_ops.get_vnumainfo(d); + return alternative_call(xsm_ops.get_vnumainfo, d); } static inline int xsm_vm_event_control(xsm_default_t def, struct domain *d, int mode, int op) { - return xsm_ops.vm_event_control(d, mode, op); + return alternative_call(xsm_ops.vm_event_control, d, mode, op); } #ifdef CONFIG_MEM_ACCESS static inline int xsm_mem_access(xsm_default_t def, struct domain *d) { - return xsm_ops.mem_access(d); + return alternative_call(xsm_ops.mem_access, d); } #endif #ifdef CONFIG_MEM_PAGING static inline int xsm_mem_paging(xsm_default_t def, struct domain *d) { - return xsm_ops.mem_paging(d); + return alternative_call(xsm_ops.mem_paging, d); } #endif #ifdef CONFIG_MEM_SHARING static inline int xsm_mem_sharing(xsm_default_t def, struct domain *d) { - return xsm_ops.mem_sharing(d); + return alternative_call(xsm_ops.mem_sharing, d); } #endif static inline int xsm_platform_op(xsm_default_t def, uint32_t op) { - return xsm_ops.platform_op(op); + return alternative_call(xsm_ops.platform_op, op); } #ifdef CONFIG_X86 static inline int xsm_do_mca(xsm_default_t def) { - return xsm_ops.do_mca(); + return alternative_call(xsm_ops.do_mca); } static inline int xsm_shadow_control(xsm_default_t def, struct domain *d, uint32_t op) { - return xsm_ops.shadow_control(d, op); + return alternative_call(xsm_ops.shadow_control, d, op); } static inline int xsm_mem_sharing_op(xsm_default_t def, struct domain *d, struct domain *cd, int op) { - return xsm_ops.mem_sharing_op(d, cd, op); + return alternative_call(xsm_ops.mem_sharing_op, d, cd, op); } static inline int xsm_apic(xsm_default_t def, struct domain *d, int cmd) { - return xsm_ops.apic(d, cmd); + return alternative_call(xsm_ops.apic, d, cmd); } static inline int xsm_memtype(xsm_default_t def, uint32_t access) { - return xsm_ops.memtype(access); + return alternative_call(xsm_ops.memtype, access); } static inline int xsm_machine_memory_map(xsm_default_t def) { - return xsm_ops.machine_memory_map(); + return alternative_call(xsm_ops.machine_memory_map); } static inline int xsm_domain_memory_map(xsm_default_t def, struct domain *d) { - return xsm_ops.domain_memory_map(d); + return alternative_call(xsm_ops.domain_memory_map, d); } static inline int xsm_mmu_update(xsm_default_t def, struct domain *d, struct domain *t, struct domain *f, uint32_t flags) { - return xsm_ops.mmu_update(d, t, f, flags); + return alternative_call(xsm_ops.mmu_update, d, t, f, flags); } static inline int xsm_mmuext_op(xsm_default_t def, struct domain *d, struct domain *f) { - return xsm_ops.mmuext_op(d, f); + return alternative_call(xsm_ops.mmuext_op, d, f); } static inline int xsm_update_va_mapping(xsm_default_t def, struct domain *d, @@ -717,64 +718,64 @@ static inline int xsm_update_va_mapping(xsm_default_t def, struct domain *d, static inline int xsm_priv_mapping(xsm_default_t def, struct domain *d, struct domain *t) { - return xsm_ops.priv_mapping(d, t); + return alternative_call(xsm_ops.priv_mapping, d, t); } static inline int xsm_ioport_permission(xsm_default_t def, struct domain *d, uint32_t s, uint32_t e, uint8_t allow) { - return xsm_ops.ioport_permission(d, s, e, allow); + return alternative_call(xsm_ops.ioport_permission, d, s, e, allow); } static inline int xsm_ioport_mapping(xsm_default_t def, struct domain *d, uint32_t s, uint32_t e, uint8_t allow) { - return xsm_ops.ioport_mapping(d, s, e, allow); + return alternative_call(xsm_ops.ioport_mapping, d, s, e, allow); } static inline int xsm_pmu_op(xsm_default_t def, struct domain *d, unsigned int op) { - return xsm_ops.pmu_op(d, op); + return alternative_call(xsm_ops.pmu_op, d, op); } #endif /* CONFIG_X86 */ static inline int xsm_dm_op(xsm_default_t def, struct domain *d) { - return xsm_ops.dm_op(d); + return alternative_call(xsm_ops.dm_op, d); } static inline int xsm_xen_version(xsm_default_t def, uint32_t op) { - return xsm_ops.xen_version(op); + return alternative_call(xsm_ops.xen_version, op); } static inline int xsm_domain_resource_map(xsm_default_t def, struct domain *d) { - return xsm_ops.domain_resource_map(d); + return alternative_call(xsm_ops.domain_resource_map, d); } #ifdef CONFIG_ARGO static inline int xsm_argo_enable(const struct domain *d) { - return xsm_ops.argo_enable(d); + return alternative_call(xsm_ops.argo_enable, d); } static inline int xsm_argo_register_single_source(const struct domain *d, const struct domain *t) { - return xsm_ops.argo_register_single_source(d, t); + return alternative_call(xsm_ops.argo_register_single_source, d, t); } static inline int xsm_argo_register_any_source(const struct domain *d) { - return xsm_ops.argo_register_any_source(d); + return alternative_call(xsm_ops.argo_register_any_source, d); } static inline int xsm_argo_send(const struct domain *d, const struct domain *t) { - return xsm_ops.argo_send(d, t); + return alternative_call(xsm_ops.argo_send, d, t); } #endif /* CONFIG_ARGO */ -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Fri Sep 03 15:08:04 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Sep 2021 15:08:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.178157.324070 (Exim 4.92) (envelope-from ) id 1mMAnU-0000sR-6e; Fri, 03 Sep 2021 15:08:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 178157.324070; Fri, 03 Sep 2021 15:08:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMAnU-0000sK-3N; Fri, 03 Sep 2021 15:08:04 +0000 Received: by outflank-mailman (input) for mailman id 178157; Fri, 03 Sep 2021 15:08:03 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMAnT-0000pX-0h for xen-devel@lists.xenproject.org; Fri, 03 Sep 2021 15:08:03 +0000 Received: from sender4-of-o51.zoho.com (unknown [136.143.188.51]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 2297f24f-9416-4fb5-bc0e-68d572178f48; Fri, 03 Sep 2021 15:08:00 +0000 (UTC) Received: from sisyou.hme. (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1630681605135159.2520943143012; Fri, 3 Sep 2021 08:06:45 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2297f24f-9416-4fb5-bc0e-68d572178f48 ARC-Seal: i=1; a=rsa-sha256; t=1630681608; cv=none; d=zohomail.com; s=zohoarc; b=IQmOrMmsWZWhcfJ9fvxJAdohJmDd40GONJ3M5td8t5OdqcLTbICTt1ALGf6ldTJTBkJNV5gCoN1c6+B+yoEhbVrF+yfEPuRkqbOxWHt6gjeP0Wc7J+mLTG1vY07W658gFV7ttiJQnew4HRc1FQ6pXjLl3TZfkm6DULmW8fM4HUU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1630681608; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=Ck3QWAp7r648NxHUI1GTuSv4TTuwb5biDai25m+bty4=; b=nsi9j5FJcmTMPj2cVVQ6HdXTH5z/865Ykr7IGoh7FUtKc6joz+Gm1pr6uNppNQ6B9IIXtvSX92Sky1CJn1JqWWRhHh/UtqMPdo82CUPN51YIiZRjhcIUxcXMoujDx8UEDZxvVV+Y8F/AHNNQJ08onneexhbu8bSlUKJx1gMFHR8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1630681608; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding; bh=Ck3QWAp7r648NxHUI1GTuSv4TTuwb5biDai25m+bty4=; b=N04u9Idu71mnjJY/MdL8vU0GRbyPX8+G/XWTguSk7mi73yh9b/lLKlhtPKSdokb1 99gfY7JBgQuxmoz/Rv5Xty7HEkl4B0m0S8Tis5mupM/sPR+4JTxVKkXmmoyb9O9JLZ6 QGfADe5hHvXA4B5FiguhKklw4/ZXV1iVKBQmSCbo= From: "Daniel P. Smith" To: "Daniel P. Smith" , xen-devel@lists.xenproject.org Cc: Daniel De Graaf Subject: [PATCH v4 07/11] xsm: decouple xsm header inclusion selection Date: Fri, 3 Sep 2021 15:06:25 -0400 Message-Id: <20210903190629.11917-8-dpsmith@apertussolutions.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210903190629.11917-1-dpsmith@apertussolutions.com> References: <20210903190629.11917-1-dpsmith@apertussolutions.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-ZohoMailClient: External Multiple preprocessor defines were used as a mechanism to selective include parts of the xsm.h header file. This makes it difficult to know which portion is being included at any one time. This commit works to simplify this by separating the core structures and functions of XSM into xsm-core.h away from the wrapper functions which remain in xsm.h and dummy.h. Signed-off-by: Daniel P. Smith --- xen/include/xsm/dummy.h | 2 +- xen/include/xsm/xsm-core.h | 274 +++++++++++++++++++++++++++++++++++++ xen/include/xsm/xsm.h | 255 +--------------------------------- xen/xsm/dummy.c | 1 - xen/xsm/silo.c | 1 - xen/xsm/xsm_core.c | 5 + 6 files changed, 281 insertions(+), 257 deletions(-) create mode 100644 xen/include/xsm/xsm-core.h diff --git a/xen/include/xsm/dummy.h b/xen/include/xsm/dummy.h index deaf23035e..78d0b7d07a 100644 --- a/xen/include/xsm/dummy.h +++ b/xen/include/xsm/dummy.h @@ -16,7 +16,7 @@ */ #include -#include +#include #include /* Cannot use BUILD_BUG_ON here because the expressions we check are not diff --git a/xen/include/xsm/xsm-core.h b/xen/include/xsm/xsm-core.h new file mode 100644 index 0000000000..4555e111dc --- /dev/null +++ b/xen/include/xsm/xsm-core.h @@ -0,0 +1,274 @@ +/* + * This file contains the XSM hook definitions for Xen. + * + * This work is based on the LSM implementation in Linux 2.6.13.4. + * + * Author: George Coker, + * + * Contributors: Michael LeMay, + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2, + * as published by the Free Software Foundation. + */ + +#ifndef __XSM_CORE_H__ +#define __XSM_CORE_H__ + +#include +#include + +/* policy magic number (defined by XSM_MAGIC) */ +typedef uint32_t xsm_magic_t; + +#ifdef CONFIG_XSM_FLASK +#define XSM_MAGIC 0xf97cff8c +#else +#define XSM_MAGIC 0x0 +#endif + +/* These annotations are used by callers and in dummy.h to document the + * default actions of XSM hooks. They should be compiled out otherwise. + */ +enum xsm_default { + /* Guests can normally access the hypercall */ + XSM_HOOK, + /* Device model can perform on its target domain */ + XSM_DM_PRIV, + /* Can perform on self or your target domain */ + XSM_TARGET, + /* Privileged - normally restricted to dom0 */ + XSM_PRIV, + /* Xenstore domain - can do some privileged operations */ + XSM_XS_PRIV, + /* Something more complex */ + XSM_OTHER +}; +typedef enum xsm_default xsm_default_t; + +struct xsm_ops { + void (*security_domaininfo)(struct domain *d, + struct xen_domctl_getdomaininfo *info); + int (*domain_create)(struct domain *d, uint32_t ssidref); + int (*getdomaininfo)(struct domain *d); + int (*domctl_scheduler_op)(struct domain *d, int op); + int (*sysctl_scheduler_op)(int op); + int (*set_target)(struct domain *d, struct domain *e); + int (*domctl)(struct domain *d, int cmd); + int (*sysctl)(int cmd); + int (*readconsole)(uint32_t clear); + + int (*evtchn_unbound)(struct domain *d, struct evtchn *chn, domid_t id2); + int (*evtchn_interdomain)(struct domain *d1, struct evtchn *chn1, + struct domain *d2, struct evtchn *chn2); + void (*evtchn_close_post)(struct evtchn *chn); + int (*evtchn_send)(struct domain *d, struct evtchn *chn); + int (*evtchn_status)(struct domain *d, struct evtchn *chn); + int (*evtchn_reset)(struct domain *d1, struct domain *d2); + + int (*grant_mapref)(struct domain *d1, struct domain *d2, uint32_t flags); + int (*grant_unmapref)(struct domain *d1, struct domain *d2); + int (*grant_setup)(struct domain *d1, struct domain *d2); + int (*grant_transfer)(struct domain *d1, struct domain *d2); + int (*grant_copy)(struct domain *d1, struct domain *d2); + int (*grant_query_size)(struct domain *d1, struct domain *d2); + + int (*alloc_security_domain)(struct domain *d); + void (*free_security_domain)(struct domain *d); + int (*alloc_security_evtchns)(struct evtchn chn[], unsigned int nr); + void (*free_security_evtchns)(struct evtchn chn[], unsigned int nr); + char *(*show_security_evtchn)(struct domain *d, const struct evtchn *chn); + int (*init_hardware_domain)(struct domain *d); + + int (*get_pod_target)(struct domain *d); + int (*set_pod_target)(struct domain *d); + int (*memory_exchange)(struct domain *d); + int (*memory_adjust_reservation)(struct domain *d1, struct domain *d2); + int (*memory_stat_reservation)(struct domain *d1, struct domain *d2); + int (*memory_pin_page)(struct domain *d1, struct domain *d2, + struct page_info *page); + int (*add_to_physmap)(struct domain *d1, struct domain *d2); + int (*remove_from_physmap)(struct domain *d1, struct domain *d2); + int (*map_gmfn_foreign)(struct domain *d, struct domain *t); + int (*claim_pages)(struct domain *d); + + int (*console_io)(struct domain *d, int cmd); + + int (*profile)(struct domain *d, int op); + + int (*kexec)(void); + int (*schedop_shutdown)(struct domain *d1, struct domain *d2); + + char *(*show_irq_sid)(int irq); + int (*map_domain_pirq)(struct domain *d); + int (*map_domain_irq)(struct domain *d, int irq, const void *data); + int (*unmap_domain_pirq)(struct domain *d); + int (*unmap_domain_irq)(struct domain *d, int irq, const void *data); + int (*bind_pt_irq)(struct domain *d, struct xen_domctl_bind_pt_irq *bind); + int (*unbind_pt_irq)(struct domain *d, struct xen_domctl_bind_pt_irq *bind); + int (*irq_permission)(struct domain *d, int pirq, uint8_t allow); + int (*iomem_permission)(struct domain *d, uint64_t s, uint64_t e, + uint8_t allow); + int (*iomem_mapping)(struct domain *d, uint64_t s, uint64_t e, + uint8_t allow); + int (*pci_config_permission)(struct domain *d, uint32_t machine_bdf, + uint16_t start, uint16_t end, uint8_t access); + +#if defined(CONFIG_HAS_PASSTHROUGH) && defined(CONFIG_HAS_PCI) + int (*get_device_group)(uint32_t machine_bdf); + int (*assign_device)(struct domain *d, uint32_t machine_bdf); + int (*deassign_device)(struct domain *d, uint32_t machine_bdf); +#endif + +#if defined(CONFIG_HAS_PASSTHROUGH) && defined(CONFIG_HAS_DEVICE_TREE) + int (*assign_dtdevice)(struct domain *d, const char *dtpath); + int (*deassign_dtdevice)(struct domain *d, const char *dtpath); +#endif + + int (*resource_plug_core)(void); + int (*resource_unplug_core)(void); + int (*resource_plug_pci)(uint32_t machine_bdf); + int (*resource_unplug_pci)(uint32_t machine_bdf); + int (*resource_setup_pci)(uint32_t machine_bdf); + int (*resource_setup_gsi)(int gsi); + int (*resource_setup_misc)(void); + + int (*page_offline)(uint32_t cmd); + int (*hypfs_op)(void); + + long (*do_xsm_op)(XEN_GUEST_HANDLE_PARAM(void) op); +#ifdef CONFIG_COMPAT + int (*do_compat_op)(XEN_GUEST_HANDLE_PARAM(void) op); +#endif + + int (*hvm_param)(struct domain *d, unsigned long op); + int (*hvm_control)(struct domain *d, unsigned long op); + int (*hvm_param_altp2mhvm)(struct domain *d); + int (*hvm_altp2mhvm_op)(struct domain *d, uint64_t mode, uint32_t op); + int (*get_vnumainfo)(struct domain *d); + + int (*vm_event_control)(struct domain *d, int mode, int op); + +#ifdef CONFIG_MEM_ACCESS + int (*mem_access)(struct domain *d); +#endif + +#ifdef CONFIG_MEM_PAGING + int (*mem_paging)(struct domain *d); +#endif + +#ifdef CONFIG_MEM_SHARING + int (*mem_sharing)(struct domain *d); +#endif + + int (*platform_op)(uint32_t cmd); + +#ifdef CONFIG_X86 + int (*do_mca)(void); + int (*shadow_control)(struct domain *d, uint32_t op); + int (*mem_sharing_op)(struct domain *d, struct domain *cd, int op); + int (*apic)(struct domain *d, int cmd); + int (*memtype)(uint32_t access); + int (*machine_memory_map)(void); + int (*domain_memory_map)(struct domain *d); +#define XSM_MMU_UPDATE_READ 1 +#define XSM_MMU_UPDATE_WRITE 2 +#define XSM_MMU_NORMAL_UPDATE 4 +#define XSM_MMU_MACHPHYS_UPDATE 8 + int (*mmu_update)(struct domain *d, struct domain *t, + struct domain *f, uint32_t flags); + int (*mmuext_op)(struct domain *d, struct domain *f); + int (*update_va_mapping)(struct domain *d, struct domain *f, + l1_pgentry_t pte); + int (*priv_mapping)(struct domain *d, struct domain *t); + int (*ioport_permission)(struct domain *d, uint32_t s, uint32_t e, + uint8_t allow); + int (*ioport_mapping)(struct domain *d, uint32_t s, uint32_t e, + uint8_t allow); + int (*pmu_op)(struct domain *d, unsigned int op); +#endif + + int (*dm_op)(struct domain *d); + + int (*xen_version)(uint32_t cmd); + + int (*domain_resource_map)(struct domain *d); + +#ifdef CONFIG_ARGO + int (*argo_enable)(const struct domain *d); + int (*argo_register_single_source)(const struct domain *d, + const struct domain *t); + int (*argo_register_any_source)(const struct domain *d); + int (*argo_send)(const struct domain *d, const struct domain *t); +#endif +}; + +void xsm_fixup_ops(struct xsm_ops *ops); + +#ifdef CONFIG_XSM + +#ifdef CONFIG_MULTIBOOT +int xsm_multiboot_init(unsigned long *module_map, + const multiboot_info_t *mbi); +int xsm_multiboot_policy_init(unsigned long *module_map, + const multiboot_info_t *mbi, + void **policy_buffer, + size_t *policy_size); +#endif + +#ifdef CONFIG_HAS_DEVICE_TREE +/* + * Initialize XSM + * + * On success, return 1 if using SILO mode else 0. + */ +int xsm_dt_init(void); +int xsm_dt_policy_init(void **policy_buffer, size_t *policy_size); +bool has_xsm_magic(paddr_t); +#endif + +#ifdef CONFIG_XSM_FLASK +const struct xsm_ops *flask_init(const void *policy_buffer, + size_t policy_size); +#else +static inline const struct xsm_ops *flask_init(const void *policy_buffer, + size_t policy_size) +{ + return NULL; +} +#endif + +#ifdef CONFIG_XSM_SILO +const struct xsm_ops *silo_init(void); +#else +static const inline struct xsm_ops *silo_init(void) +{ + return NULL; +} +#endif + +#else /* CONFIG_XSM */ + +#ifdef CONFIG_MULTIBOOT +static inline int xsm_multiboot_init(unsigned long *module_map, + const multiboot_info_t *mbi) +{ + return 0; +} +#endif + +#ifdef CONFIG_HAS_DEVICE_TREE +static inline int xsm_dt_init(void) +{ + return 0; +} + +static inline bool has_xsm_magic(paddr_t start) +{ + return false; +} +#endif /* CONFIG_HAS_DEVICE_TREE */ + +#endif /* CONFIG_XSM */ + +#endif /* __XSM_CORE_H */ diff --git a/xen/include/xsm/xsm.h b/xen/include/xsm/xsm.h index d7ef412874..1517443173 100644 --- a/xen/include/xsm/xsm.h +++ b/xen/include/xsm/xsm.h @@ -18,194 +18,12 @@ #include #include #include - -/* policy magic number (defined by XSM_MAGIC) */ -typedef uint32_t xsm_magic_t; - -#ifdef CONFIG_XSM_FLASK -#define XSM_MAGIC 0xf97cff8c -#else -#define XSM_MAGIC 0x0 -#endif - -/* These annotations are used by callers and in dummy.h to document the - * default actions of XSM hooks. They should be compiled out otherwise. - */ -enum xsm_default { - /* Guests can normally access the hypercall */ - XSM_HOOK, - /* Device model can perform on its target domain */ - XSM_DM_PRIV, - /* Can perform on self or your target domain */ - XSM_TARGET, - /* Privileged - normally restricted to dom0 */ - XSM_PRIV, - /* Xenstore domain - can do some privileged operations */ - XSM_XS_PRIV, - /* Something more complex */ - XSM_OTHER -}; -typedef enum xsm_default xsm_default_t; - -struct xsm_ops { - void (*security_domaininfo)(struct domain *d, - struct xen_domctl_getdomaininfo *info); - int (*domain_create)(struct domain *d, uint32_t ssidref); - int (*getdomaininfo)(struct domain *d); - int (*domctl_scheduler_op)(struct domain *d, int op); - int (*sysctl_scheduler_op)(int op); - int (*set_target)(struct domain *d, struct domain *e); - int (*domctl)(struct domain *d, int cmd); - int (*sysctl)(int cmd); - int (*readconsole)(uint32_t clear); - - int (*evtchn_unbound)(struct domain *d, struct evtchn *chn, domid_t id2); - int (*evtchn_interdomain)(struct domain *d1, struct evtchn *chn1, - struct domain *d2, struct evtchn *chn2); - void (*evtchn_close_post)(struct evtchn *chn); - int (*evtchn_send)(struct domain *d, struct evtchn *chn); - int (*evtchn_status)(struct domain *d, struct evtchn *chn); - int (*evtchn_reset)(struct domain *d1, struct domain *d2); - - int (*grant_mapref)(struct domain *d1, struct domain *d2, uint32_t flags); - int (*grant_unmapref)(struct domain *d1, struct domain *d2); - int (*grant_setup)(struct domain *d1, struct domain *d2); - int (*grant_transfer)(struct domain *d1, struct domain *d2); - int (*grant_copy)(struct domain *d1, struct domain *d2); - int (*grant_query_size)(struct domain *d1, struct domain *d2); - - int (*alloc_security_domain)(struct domain *d); - void (*free_security_domain)(struct domain *d); - int (*alloc_security_evtchns)(struct evtchn chn[], unsigned int nr); - void (*free_security_evtchns)(struct evtchn chn[], unsigned int nr); - char *(*show_security_evtchn)(struct domain *d, const struct evtchn *chn); - int (*init_hardware_domain)(struct domain *d); - - int (*get_pod_target)(struct domain *d); - int (*set_pod_target)(struct domain *d); - int (*memory_exchange)(struct domain *d); - int (*memory_adjust_reservation)(struct domain *d1, struct domain *d2); - int (*memory_stat_reservation)(struct domain *d1, struct domain *d2); - int (*memory_pin_page)(struct domain *d1, struct domain *d2, - struct page_info *page); - int (*add_to_physmap)(struct domain *d1, struct domain *d2); - int (*remove_from_physmap)(struct domain *d1, struct domain *d2); - int (*map_gmfn_foreign)(struct domain *d, struct domain *t); - int (*claim_pages)(struct domain *d); - - int (*console_io)(struct domain *d, int cmd); - - int (*profile)(struct domain *d, int op); - - int (*kexec)(void); - int (*schedop_shutdown)(struct domain *d1, struct domain *d2); - - char *(*show_irq_sid)(int irq); - int (*map_domain_pirq)(struct domain *d); - int (*map_domain_irq)(struct domain *d, int irq, const void *data); - int (*unmap_domain_pirq)(struct domain *d); - int (*unmap_domain_irq)(struct domain *d, int irq, const void *data); - int (*bind_pt_irq)(struct domain *d, struct xen_domctl_bind_pt_irq *bind); - int (*unbind_pt_irq)(struct domain *d, struct xen_domctl_bind_pt_irq *bind); - int (*irq_permission)(struct domain *d, int pirq, uint8_t allow); - int (*iomem_permission)(struct domain *d, uint64_t s, uint64_t e, - uint8_t allow); - int (*iomem_mapping)(struct domain *d, uint64_t s, uint64_t e, - uint8_t allow); - int (*pci_config_permission)(struct domain *d, uint32_t machine_bdf, - uint16_t start, uint16_t end, uint8_t access); - -#if defined(CONFIG_HAS_PASSTHROUGH) && defined(CONFIG_HAS_PCI) - int (*get_device_group)(uint32_t machine_bdf); - int (*assign_device)(struct domain *d, uint32_t machine_bdf); - int (*deassign_device)(struct domain *d, uint32_t machine_bdf); -#endif - -#if defined(CONFIG_HAS_PASSTHROUGH) && defined(CONFIG_HAS_DEVICE_TREE) - int (*assign_dtdevice)(struct domain *d, const char *dtpath); - int (*deassign_dtdevice)(struct domain *d, const char *dtpath); -#endif - - int (*resource_plug_core)(void); - int (*resource_unplug_core)(void); - int (*resource_plug_pci)(uint32_t machine_bdf); - int (*resource_unplug_pci)(uint32_t machine_bdf); - int (*resource_setup_pci)(uint32_t machine_bdf); - int (*resource_setup_gsi)(int gsi); - int (*resource_setup_misc)(void); - - int (*page_offline)(uint32_t cmd); - int (*hypfs_op)(void); - - long (*do_xsm_op)(XEN_GUEST_HANDLE_PARAM(void) op); -#ifdef CONFIG_COMPAT - int (*do_compat_op)(XEN_GUEST_HANDLE_PARAM(void) op); -#endif - - int (*hvm_param)(struct domain *d, unsigned long op); - int (*hvm_control)(struct domain *d, unsigned long op); - int (*hvm_param_altp2mhvm)(struct domain *d); - int (*hvm_altp2mhvm_op)(struct domain *d, uint64_t mode, uint32_t op); - int (*get_vnumainfo)(struct domain *d); - - int (*vm_event_control)(struct domain *d, int mode, int op); - -#ifdef CONFIG_MEM_ACCESS - int (*mem_access)(struct domain *d); -#endif - -#ifdef CONFIG_MEM_PAGING - int (*mem_paging)(struct domain *d); -#endif - -#ifdef CONFIG_MEM_SHARING - int (*mem_sharing)(struct domain *d); -#endif - - int (*platform_op)(uint32_t cmd); - -#ifdef CONFIG_X86 - int (*do_mca)(void); - int (*shadow_control)(struct domain *d, uint32_t op); - int (*mem_sharing_op)(struct domain *d, struct domain *cd, int op); - int (*apic)(struct domain *d, int cmd); - int (*memtype)(uint32_t access); - int (*machine_memory_map)(void); - int (*domain_memory_map)(struct domain *d); -#define XSM_MMU_UPDATE_READ 1 -#define XSM_MMU_UPDATE_WRITE 2 -#define XSM_MMU_NORMAL_UPDATE 4 -#define XSM_MMU_MACHPHYS_UPDATE 8 - int (*mmu_update)(struct domain *d, struct domain *t, - struct domain *f, uint32_t flags); - int (*mmuext_op)(struct domain *d, struct domain *f); - int (*update_va_mapping)(struct domain *d, struct domain *f, - l1_pgentry_t pte); - int (*priv_mapping)(struct domain *d, struct domain *t); - int (*ioport_permission)(struct domain *d, uint32_t s, uint32_t e, - uint8_t allow); - int (*ioport_mapping)(struct domain *d, uint32_t s, uint32_t e, - uint8_t allow); - int (*pmu_op)(struct domain *d, unsigned int op); -#endif - int (*dm_op)(struct domain *d); - int (*xen_version)(uint32_t cmd); - int (*domain_resource_map)(struct domain *d); -#ifdef CONFIG_ARGO - int (*argo_enable)(const struct domain *d); - int (*argo_register_single_source)(const struct domain *d, - const struct domain *t); - int (*argo_register_any_source)(const struct domain *d); - int (*argo_send)(const struct domain *d, const struct domain *t); -#endif -}; +#include #ifdef CONFIG_XSM extern struct xsm_ops xsm_ops; -#ifndef XSM_NO_WRAPPERS - static inline void xsm_security_domaininfo(struct domain *d, struct xen_domctl_getdomaininfo *info) { @@ -780,81 +598,10 @@ static inline int xsm_argo_send(const struct domain *d, const struct domain *t) #endif /* CONFIG_ARGO */ -#endif /* XSM_NO_WRAPPERS */ - -#ifdef CONFIG_MULTIBOOT -int xsm_multiboot_init(unsigned long *module_map, - const multiboot_info_t *mbi); -int xsm_multiboot_policy_init(unsigned long *module_map, - const multiboot_info_t *mbi, - void **policy_buffer, - size_t *policy_size); -#endif - -#ifdef CONFIG_HAS_DEVICE_TREE -/* - * Initialize XSM - * - * On success, return 1 if using SILO mode else 0. - */ -int xsm_dt_init(void); -int xsm_dt_policy_init(void **policy_buffer, size_t *policy_size); -bool has_xsm_magic(paddr_t); -#endif - -extern struct xsm_ops dummy_xsm_ops; - -void xsm_fixup_ops(struct xsm_ops *ops); - -#ifdef CONFIG_XSM_FLASK -extern const struct xsm_ops *flask_init(const void *policy_buffer, - size_t policy_size); -#else -static const inline struct xsm_ops *flask_init(const void *policy_buffer, - size_t policy_size) -{ - return NULL; -} -#endif - -#ifdef CONFIG_XSM_FLASK_POLICY -extern const unsigned char xsm_flask_init_policy[]; -extern const unsigned int xsm_flask_init_policy_size; -#endif - -#ifdef CONFIG_XSM_SILO -extern const struct xsm_ops *silo_init(void); -#else -static const inline struct xsm_ops *silo_init(void) -{ - return NULL; -} -#endif - #else /* CONFIG_XSM */ #include -#ifdef CONFIG_MULTIBOOT -static inline int xsm_multiboot_init (unsigned long *module_map, - const multiboot_info_t *mbi) -{ - return 0; -} -#endif - -#ifdef CONFIG_HAS_DEVICE_TREE -static inline int xsm_dt_init(void) -{ - return 0; -} - -static inline bool has_xsm_magic(paddr_t start) -{ - return false; -} -#endif /* CONFIG_HAS_DEVICE_TREE */ - #endif /* CONFIG_XSM */ #endif /* __XSM_H */ diff --git a/xen/xsm/dummy.c b/xen/xsm/dummy.c index d8c935328e..b848580eaa 100644 --- a/xen/xsm/dummy.c +++ b/xen/xsm/dummy.c @@ -10,7 +10,6 @@ * as published by the Free Software Foundation. */ -#define XSM_NO_WRAPPERS #include #define set_to_dummy_if_null(ops, function) \ diff --git a/xen/xsm/silo.c b/xen/xsm/silo.c index 3550dded7b..6db793f35c 100644 --- a/xen/xsm/silo.c +++ b/xen/xsm/silo.c @@ -17,7 +17,6 @@ * You should have received a copy of the GNU General Public License along with * this program; If not, see . */ -#define XSM_NO_WRAPPERS #include /* diff --git a/xen/xsm/xsm_core.c b/xen/xsm/xsm_core.c index 859af3fe9a..112d11fa6a 100644 --- a/xen/xsm/xsm_core.c +++ b/xen/xsm/xsm_core.c @@ -32,6 +32,11 @@ struct xsm_ops __read_mostly xsm_ops; +#ifdef CONFIG_XSM_FLASK_POLICY +extern const unsigned char xsm_flask_init_policy[]; +extern const unsigned int xsm_flask_init_policy_size; +#endif + enum xsm_ops_state { XSM_OPS_UNREGISTERED, XSM_OPS_REG_FAILED, -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Fri Sep 03 15:08:15 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Sep 2021 15:08:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.178164.324082 (Exim 4.92) (envelope-from ) id 1mMAnf-0001eX-N7; Fri, 03 Sep 2021 15:08:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 178164.324082; Fri, 03 Sep 2021 15:08:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMAnf-0001eK-JL; Fri, 03 Sep 2021 15:08:15 +0000 Received: by outflank-mailman (input) for mailman id 178164; Fri, 03 Sep 2021 15:08:14 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMAne-0000pX-09 for xen-devel@lists.xenproject.org; Fri, 03 Sep 2021 15:08:14 +0000 Received: from sender4-of-o51.zoho.com (unknown [136.143.188.51]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id d872ea58-6b0c-4a80-96e7-c4bd4ba6c50b; Fri, 03 Sep 2021 15:08:08 +0000 (UTC) Received: from sisyou.hme. (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1630681606215260.8066699495482; Fri, 3 Sep 2021 08:06:46 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d872ea58-6b0c-4a80-96e7-c4bd4ba6c50b ARC-Seal: i=1; a=rsa-sha256; t=1630681610; cv=none; d=zohomail.com; s=zohoarc; b=lAaLajPmJgFfFXG9/fAvb2ro5HO85Q3nsofHT2js9kIjJLUIcmAEwVnVRByD18B9BbfWzRwjXmHiRQ1NkHqkCAR6baJbqVuXyFDQKewron6VMgyp1EwK0vRuauCP8k7v0/w3eJpo6xNKA1Yg6FnkV3iStlXyd6g2aenWpPZrl4M= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1630681610; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=OgL0twSQXxCO75U01QAyE+snmmbBrwyx4tBfZzhsUPE=; b=jriZcMk0QAlQDwqd9hUmAFmBdN4GJoYRaEmd+YHpKX0SL+UPXmbNtZcqoMhQSCtEyt1kPYe0QYzzE9pdr7wGpidWVQ7jEM4kx+MPlTs4NJxhi84N7kK6LaUKJviuftYYlGwX8nBEU1JwBLrLCELr/mp/Ju0n3Ae8nXv46//zZ5k= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1630681610; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding; bh=OgL0twSQXxCO75U01QAyE+snmmbBrwyx4tBfZzhsUPE=; b=lApT1YGLT1E23o2KEJ6XDdo9IKv1h1NXRUckpo4eBRBVW4gSMl9PBq8GGeC791od A3VugirBc8gh4HsVUaozTDgdsQtcEV7hVDMzE4XkxvlSmbQG/607flA0hM1f6Mc/Spq 3vljexfm5F+I1+JGiPfg0RrmordO6hguPURTRL/Y= From: "Daniel P. Smith" To: xen-devel@lists.xenproject.org Cc: "Daniel P. Smith" , Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH v4 08/11] xsm: drop generic event channel labeling exclusion Date: Fri, 3 Sep 2021 15:06:26 -0400 Message-Id: <20210903190629.11917-9-dpsmith@apertussolutions.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210903190629.11917-1-dpsmith@apertussolutions.com> References: <20210903190629.11917-1-dpsmith@apertussolutions.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-ZohoMailClient: External The internal define flag is not used by any XSM module, removing the #ifdef leaving the generic event channel labeling as always present. Signed-off-by: Daniel P. Smith --- xen/include/xen/sched.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h index 28146ee404..e56690cd2b 100644 --- a/xen/include/xen/sched.h +++ b/xen/include/xen/sched.h @@ -122,13 +122,11 @@ struct evtchn #ifdef CONFIG_XSM union { -#ifdef XSM_NEED_GENERIC_EVTCHN_SSID /* * If an XSM module needs more space for its event channel context, * this pointer stores the necessary data for the security server. */ void *generic; -#endif #ifdef CONFIG_XSM_FLASK /* * Inlining the contents of the structure for FLASK avoids unneeded -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Fri Sep 03 15:08:23 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Sep 2021 15:08:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.178172.324093 (Exim 4.92) (envelope-from ) id 1mMAnn-0002Gp-1L; Fri, 03 Sep 2021 15:08:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 178172.324093; Fri, 03 Sep 2021 15:08:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMAnm-0002Ge-Tm; Fri, 03 Sep 2021 15:08:22 +0000 Received: by outflank-mailman (input) for mailman id 178172; Fri, 03 Sep 2021 15:08:22 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMAnm-00020o-6O for xen-devel@lists.xenproject.org; Fri, 03 Sep 2021 15:08:22 +0000 Received: from sender4-of-o51.zoho.com (unknown [136.143.188.51]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id c49e68bc-0cc8-11ec-af2e-12813bfff9fa; Fri, 03 Sep 2021 15:08:18 +0000 (UTC) Received: from sisyou.hme. (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1630681607871996.5359561303381; Fri, 3 Sep 2021 08:06:47 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c49e68bc-0cc8-11ec-af2e-12813bfff9fa ARC-Seal: i=1; a=rsa-sha256; t=1630681613; cv=none; d=zohomail.com; s=zohoarc; b=AmnjgUxavzvlOgQThsUztE6rwLA9AR1eB9LLbjf1gN6C9YJEpPb01RiYrBLPwTDUqvUcyfBoETtfz+FrM9lGAzjdji/RjUI86EsOCH/2SMRu3MhhtE63l7MfRGbo/gF7Zp82gneuAiP36Etp/u0NPTQH9LMmKPgvOh3kSCJaViA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1630681613; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=DHYiPbkr+NbOPJst4/lduNG0E/MNzNsNVs5R1f5AFDk=; b=J0EIGjS1XMflXx/TZjog1zNaIfzg8OscC2cCqd50CL4ka5IynK+OIcQvt+Hv0dVFHiDFt2riVKSHWXyRDjEJJ2YsX3lTD4xGa+tnHLgH9Y7wJsHTC9JmpZcvfnlvqFLzT001Liu2eUURuPzN3pDcVXc6FpXq3Tfme/8GwKafWMQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1630681613; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding; bh=DHYiPbkr+NbOPJst4/lduNG0E/MNzNsNVs5R1f5AFDk=; b=Brrsy+5tS9Yt7RWJtCGbyKNNj4+oiAse7W5CsQOOu0cqWs+vJD/flMRPYzEEF45K CxCT7RaTtN8LPe06fEy/6YHMs8elfUoHwWS0CCI0qM4VAYIBlc+QAlZtM598UcKZpi5 wKa6SJJi+0qdf8SdhusQ8iixemr3TFZBa8eLMnHE= From: "Daniel P. Smith" To: "Daniel P. Smith" , xen-devel@lists.xenproject.org Cc: Daniel De Graaf Subject: [PATCH v4 09/11] silo: remove circular xsm hook call Date: Fri, 3 Sep 2021 15:06:27 -0400 Message-Id: <20210903190629.11917-10-dpsmith@apertussolutions.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210903190629.11917-1-dpsmith@apertussolutions.com> References: <20210903190629.11917-1-dpsmith@apertussolutions.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-ZohoMailClient: External SILO implements a few XSM hooks to extended the decision logic beyond what is defined in the dummy/default policy. For each of the hooks, it falls back to the dummy/default policy. The fall back is done a slight round-about way. This commit makes the direct call to the default policy's logic, xsm_default_action(). Signed-off-by: Daniel P. Smith --- xen/xsm/silo.c | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/xen/xsm/silo.c b/xen/xsm/silo.c index 6db793f35c..56a330a831 100644 --- a/xen/xsm/silo.c +++ b/xen/xsm/silo.c @@ -17,6 +17,7 @@ * You should have received a copy of the GNU General Public License along with * this program; If not, see . */ +#include #include /* @@ -43,7 +44,7 @@ static int silo_evtchn_unbound(struct domain *d1, struct evtchn *chn, else { if ( silo_mode_dom_check(d1, d2) ) - rc = xsm_evtchn_unbound(d1, chn, id2); + rc = xsm_default_action(XSM_TARGET, current->domain, d1); rcu_unlock_domain(d2); } @@ -54,7 +55,7 @@ static int silo_evtchn_interdomain(struct domain *d1, struct evtchn *chan1, struct domain *d2, struct evtchn *chan2) { if ( silo_mode_dom_check(d1, d2) ) - return xsm_evtchn_interdomain(d1, chan1, d2, chan2); + return xsm_default_action(XSM_HOOK, d1, d2); return -EPERM; } @@ -62,21 +63,21 @@ static int silo_grant_mapref(struct domain *d1, struct domain *d2, uint32_t flags) { if ( silo_mode_dom_check(d1, d2) ) - return xsm_grant_mapref(d1, d2, flags); + return xsm_default_action(XSM_HOOK, d1, d2); return -EPERM; } static int silo_grant_transfer(struct domain *d1, struct domain *d2) { if ( silo_mode_dom_check(d1, d2) ) - return xsm_grant_transfer(d1, d2); + return xsm_default_action(XSM_HOOK, d1, d2); return -EPERM; } static int silo_grant_copy(struct domain *d1, struct domain *d2) { if ( silo_mode_dom_check(d1, d2) ) - return xsm_grant_copy(d1, d2); + return xsm_default_action(XSM_HOOK, d1, d2); return -EPERM; } @@ -86,14 +87,14 @@ static int silo_argo_register_single_source(const struct domain *d1, const struct domain *d2) { if ( silo_mode_dom_check(d1, d2) ) - return xsm_argo_register_single_source(d1, d2); + return 0; return -EPERM; } static int silo_argo_send(const struct domain *d1, const struct domain *d2) { if ( silo_mode_dom_check(d1, d2) ) - return xsm_argo_send(d1, d2); + return 0; return -EPERM; } -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Fri Sep 03 15:08:38 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Sep 2021 15:08:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.178186.324104 (Exim 4.92) (envelope-from ) id 1mMAo2-00036i-CL; Fri, 03 Sep 2021 15:08:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 178186.324104; Fri, 03 Sep 2021 15:08:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMAo2-00036V-8L; Fri, 03 Sep 2021 15:08:38 +0000 Received: by outflank-mailman (input) for mailman id 178186; Fri, 03 Sep 2021 15:08:37 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMAo1-00020o-7E for xen-devel@lists.xenproject.org; Fri, 03 Sep 2021 15:08:37 +0000 Received: from sender4-of-o51.zoho.com (unknown [136.143.188.51]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id c88d6a5e-0cc8-11ec-af2e-12813bfff9fa; Fri, 03 Sep 2021 15:08:24 +0000 (UTC) Received: from sisyou.hme. (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1630681609048555.1692564591247; Fri, 3 Sep 2021 08:06:49 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c88d6a5e-0cc8-11ec-af2e-12813bfff9fa ARC-Seal: i=1; a=rsa-sha256; t=1630681615; cv=none; d=zohomail.com; s=zohoarc; b=gW6P5jBpju7RaplNSLoo/QOOJyGDhIhA3hMpxMZwgliJhH2vQT34hWZXiikGXZIL5myeJE1aywU04Yp67H9v2WXSdHRe0cWzK6H+MYvJ3AvcggaoZW8BULAypKN8lUPSvl+soM5OUANE4FhbXTFcIeTpxM4WQYzUR6qf1ymtwso= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1630681615; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=EWTwq6nNcnfro7pqzmCHy9mDrCWwYOniEdIAUXfrX50=; b=e/fzjYuPWVBzdWlMzbTgVXAMhEFLd+n6Kv38RzMPakdtPYiwd7E9FGXmZgVqe9SC7oRtcFR0N9gO0rrSQ3vm9s1vc6hduEDZ8xCu9t6l8LV+Yktfy6r9z4iqRIfrBSiwsa35kkuV0o30u/5caWiftxxEeN3DvZndmnFgOj7YH5Q= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1630681615; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding; bh=EWTwq6nNcnfro7pqzmCHy9mDrCWwYOniEdIAUXfrX50=; b=t2tWHwtGCWiWfkWZAHE1fPkFWJXbbeiD1drHgc8RnY3cvt5Ntwldy2WRmiDvco48 xM74PJM63Exn/TiIqx4iwiNKetM/ZS5wkQ5ZyD1mPamhulPF3C+3lDl0dOiznQNPSmC vWX13+lZv96YbP69XJpBW/Rk9K0lxqor5aUiTmfM= From: "Daniel P. Smith" To: "Daniel P. Smith" , xen-devel@lists.xenproject.org Cc: Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Daniel De Graaf Subject: [PATCH v4 10/11] kconfig: update xsm config to reflect reality Date: Fri, 3 Sep 2021 15:06:28 -0400 Message-Id: <20210903190629.11917-11-dpsmith@apertussolutions.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210903190629.11917-1-dpsmith@apertussolutions.com> References: <20210903190629.11917-1-dpsmith@apertussolutions.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-ZohoMailClient: External It has been a very long time since XSM Flask was the only XSM module, yet the concenpt of turning XSM on/off continues to be synonymous with enabling and disabling XSM Flask. Even when XSM Flask was the only module, turning XSM on/off did not disable or remove the XSM hooks but simply controlled whether they were implemented as direct inline functions or dispatch calls. This commit updates XSM kconfig to ensure that it is clear in the code as well to the user, via the help messages, that the option is about configuring which XSM policy module(s) are available and which is the default. Signed-off-by: Daniel P. Smith --- xen/common/Kconfig | 49 ++++++++++++++++++-------------------- xen/include/xen/sched.h | 2 +- xen/include/xsm/dummy.h | 23 +++++++++--------- xen/include/xsm/xsm-core.h | 6 ++--- xen/include/xsm/xsm.h | 6 ++--- xen/xsm/Makefile | 4 ++-- xen/xsm/xsm_core.c | 4 ++-- 7 files changed, 46 insertions(+), 48 deletions(-) diff --git a/xen/common/Kconfig b/xen/common/Kconfig index ac5491b1cc..2f85538920 100644 --- a/xen/common/Kconfig +++ b/xen/common/Kconfig @@ -200,23 +200,20 @@ config XENOPROF If unsure, say Y. -config XSM - bool "Xen Security Modules support" +config XSM_CONFIGURABLE + bool "Configure Xen Security Modules" default ARM - ---help--- - Enables the security framework known as Xen Security Modules which - allows administrators fine-grained control over a Xen domain and - its capabilities by defining permissible interactions between domains, - the hypervisor itself, and related resources such as memory and - devices. + help + Allows for configuring the Xen Security Modules (XSM) policy or policies + modules that will be availble and which will be the default. If unsure, say N. config XSM_FLASK - def_bool y - prompt "FLux Advanced Security Kernel support" - depends on XSM - ---help--- + bool "FLux Advanced Security Kernel support" + depends on XSM_CONFIGURABLE + select XSM_EVTCHN_LABELING + help Enables FLASK (FLux Advanced Security Kernel) as the access control mechanism used by the XSM framework. This provides a mandatory access control framework by which security enforcement, isolation, and @@ -226,10 +223,10 @@ config XSM_FLASK If unsure, say Y. config XSM_FLASK_AVC_STATS - def_bool y - prompt "Maintain statistics on the FLASK access vector cache" if EXPERT + bool "Maintain statistics on the FLASK access vector cache" if EXPERT + default y depends on XSM_FLASK - ---help--- + help Maintain counters on the access vector cache that can be viewed using the FLASK_AVC_CACHESTATS sub-op of the xsm_op hypercall. Disabling this will save a tiny amount of memory and time to update the stats. @@ -240,7 +237,7 @@ config XSM_FLASK_POLICY bool "Compile Xen with a built-in FLASK security policy" default y if "$(XEN_HAS_CHECKPOLICY)" = "y" depends on XSM_FLASK - ---help--- + help This includes a default XSM policy in the hypervisor so that the bootloader does not need to load a policy to get sane behavior from an XSM-enabled hypervisor. If this is disabled, a policy must be @@ -253,10 +250,10 @@ config XSM_FLASK_POLICY If unsure, say Y. config XSM_SILO - def_bool y - prompt "SILO support" - depends on XSM - ---help--- + bool "SILO support" + default y if ARM + depends on XSM_CONFIGURABLE + help Enables SILO as the access control mechanism used by the XSM framework. This is not the default module, add boot parameter xsm=silo to choose it. This will deny any unmediated communication channels (grant tables @@ -265,14 +262,14 @@ config XSM_SILO If unsure, say Y. choice - prompt "Default XSM implementation" - depends on XSM + prompt "Default XSM module" + depends on XSM_CONFIGURABLE default XSM_SILO_DEFAULT if XSM_SILO && ARM default XSM_FLASK_DEFAULT if XSM_FLASK default XSM_SILO_DEFAULT if XSM_SILO default XSM_DUMMY_DEFAULT config XSM_DUMMY_DEFAULT - bool "Match non-XSM behavior" + bool "Classic Dom0 behavior" config XSM_FLASK_DEFAULT bool "FLux Advanced Security Kernel" if XSM_FLASK config XSM_SILO_DEFAULT @@ -282,15 +279,15 @@ endchoice config LATE_HWDOM bool "Dedicated hardware domain" default n - depends on XSM && X86 - ---help--- + depends on XSM_FLASK && X86 + help Allows the creation of a dedicated hardware domain distinct from domain 0 that manages devices without needing access to other privileged functionality such as the ability to manage domains. This requires that the actual domain 0 be a stub domain that constructs the actual hardware domain instead of initializing the hardware itself. Because the hardware domain needs access to - hypercalls not available to unprivileged guests, an XSM policy + hypercalls not available to unprivileged guests, an XSM Flask policy is required to properly define the privilege of these domains. This feature does nothing if the "hardware_dom" boot parameter is diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h index e56690cd2b..a61586d8b6 100644 --- a/xen/include/xen/sched.h +++ b/xen/include/xen/sched.h @@ -120,7 +120,7 @@ struct evtchn unsigned short notify_vcpu_id; /* VCPU for local delivery notification */ uint32_t fifo_lastq; /* Data for identifying last queue. */ -#ifdef CONFIG_XSM +#ifdef CONFIG_XSM_CONFIGURABLE union { /* * If an XSM module needs more space for its event channel context, diff --git a/xen/include/xsm/dummy.h b/xen/include/xsm/dummy.h index 78d0b7d07a..d2a005c521 100644 --- a/xen/include/xsm/dummy.h +++ b/xen/include/xsm/dummy.h @@ -42,12 +42,12 @@ static inline void __xsm_action_mismatch_detected(void) void __xsm_action_mismatch_detected(void); #endif -#ifdef CONFIG_XSM +#ifdef CONFIG_XSM_CONFIGURABLE -/* In CONFIG_XSM builds, this header file is included from xsm/dummy.c, and - * contains static (not inline) functions compiled to the dummy XSM module. - * There is no xsm_default_t argument available, so the value from the assertion - * is used to initialize the variable. +/* In CONFIG_XSM_CONFIGURABLE builds, this header file is included from + * xsm/dummy.c, and contains static (not inline) functions compiled to the + * dummy XSM module. There is no xsm_default_t argument available, so the + * value from the assertion is used to initialize the variable. */ #define XSM_INLINE __maybe_unused @@ -55,19 +55,20 @@ void __xsm_action_mismatch_detected(void); #define XSM_DEFAULT_VOID void #define XSM_ASSERT_ACTION(def) xsm_default_t action = def; (void)action -#else /* CONFIG_XSM */ +#else /* CONFIG_XSM_CONFIGURABLE */ -/* In !CONFIG_XSM builds, this header file is included from xsm/xsm.h, and - * contains inline functions for each XSM hook. These functions also perform - * compile-time checks on the xsm_default_t argument to ensure that the behavior - * of the dummy XSM module is the same as the behavior with XSM disabled. +/* In !CONFIG_XSM_CONFIGURABLE builds, this header file is included from + * xsm/xsm.h, and contains inline functions for each XSM hook. These functions + * also perform compile-time checks on the xsm_default_t argument to ensure + * that the behavior of the dummy XSM module is the same as the behavior with + * XSM disabled. */ #define XSM_INLINE always_inline #define XSM_DEFAULT_ARG xsm_default_t action, #define XSM_DEFAULT_VOID xsm_default_t action #define XSM_ASSERT_ACTION(def) LINKER_BUG_ON(def != action) -#endif /* CONFIG_XSM */ +#endif /* CONFIG_XSM_CONFIGURABLE */ static always_inline int xsm_default_action(xsm_default_t action, struct domain *src, diff --git a/xen/include/xsm/xsm-core.h b/xen/include/xsm/xsm-core.h index 4555e111dc..a80d6a981f 100644 --- a/xen/include/xsm/xsm-core.h +++ b/xen/include/xsm/xsm-core.h @@ -205,7 +205,7 @@ struct xsm_ops { void xsm_fixup_ops(struct xsm_ops *ops); -#ifdef CONFIG_XSM +#ifdef CONFIG_XSM_CONFIGURABLE #ifdef CONFIG_MULTIBOOT int xsm_multiboot_init(unsigned long *module_map, @@ -247,7 +247,7 @@ static const inline struct xsm_ops *silo_init(void) } #endif -#else /* CONFIG_XSM */ +#else /* CONFIG_XSM_CONFIGURABLE */ #ifdef CONFIG_MULTIBOOT static inline int xsm_multiboot_init(unsigned long *module_map, @@ -269,6 +269,6 @@ static inline bool has_xsm_magic(paddr_t start) } #endif /* CONFIG_HAS_DEVICE_TREE */ -#endif /* CONFIG_XSM */ +#endif /* CONFIG_XSM_CONFIGURABLE */ #endif /* __XSM_CORE_H */ diff --git a/xen/include/xsm/xsm.h b/xen/include/xsm/xsm.h index 1517443173..4d5f441935 100644 --- a/xen/include/xsm/xsm.h +++ b/xen/include/xsm/xsm.h @@ -20,7 +20,7 @@ #include #include -#ifdef CONFIG_XSM +#ifdef CONFIG_XSM_CONFIGURABLE extern struct xsm_ops xsm_ops; @@ -598,10 +598,10 @@ static inline int xsm_argo_send(const struct domain *d, const struct domain *t) #endif /* CONFIG_ARGO */ -#else /* CONFIG_XSM */ +#else /* CONFIG_XSM_CONFIGURABLE */ #include -#endif /* CONFIG_XSM */ +#endif /* CONFIG_XSM_CONFIGURABLE */ #endif /* __XSM_H */ diff --git a/xen/xsm/Makefile b/xen/xsm/Makefile index cf0a728f1c..09b9311b1d 100644 --- a/xen/xsm/Makefile +++ b/xen/xsm/Makefile @@ -1,6 +1,6 @@ obj-y += xsm_core.o -obj-$(CONFIG_XSM) += xsm_policy.o -obj-$(CONFIG_XSM) += dummy.o +obj-$(CONFIG_XSM_CONFIGURABLE) += xsm_policy.o +obj-$(CONFIG_XSM_CONFIGURABLE) += dummy.o obj-$(CONFIG_XSM_SILO) += silo.o obj-$(CONFIG_XSM_FLASK) += flask/ diff --git a/xen/xsm/xsm_core.c b/xen/xsm/xsm_core.c index 112d11fa6a..87c2980459 100644 --- a/xen/xsm/xsm_core.c +++ b/xen/xsm/xsm_core.c @@ -18,7 +18,7 @@ #include #include -#ifdef CONFIG_XSM +#ifdef CONFIG_XSM_CONFIGURABLE #ifdef CONFIG_MULTIBOOT #include @@ -227,7 +227,7 @@ bool __init has_xsm_magic(paddr_t start) } #endif -#endif +#endif /* CONFIG_XSM_CONFIGURABLE */ long do_xsm_op(XEN_GUEST_HANDLE_PARAM(void) op) { -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Fri Sep 03 15:08:54 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Sep 2021 15:08:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.178194.324115 (Exim 4.92) (envelope-from ) id 1mMAoH-0003kV-Lt; Fri, 03 Sep 2021 15:08:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 178194.324115; Fri, 03 Sep 2021 15:08:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMAoH-0003kO-I3; Fri, 03 Sep 2021 15:08:53 +0000 Received: by outflank-mailman (input) for mailman id 178194; Fri, 03 Sep 2021 15:08:52 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMAoG-00020o-7L for xen-devel@lists.xenproject.org; Fri, 03 Sep 2021 15:08:52 +0000 Received: from sender4-of-o51.zoho.com (unknown [136.143.188.51]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id cfa37400-0cc8-11ec-af2e-12813bfff9fa; Fri, 03 Sep 2021 15:08:36 +0000 (UTC) Received: from sisyou.hme. (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1630681611173769.2077493218004; Fri, 3 Sep 2021 08:06:51 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cfa37400-0cc8-11ec-af2e-12813bfff9fa ARC-Seal: i=1; a=rsa-sha256; t=1630681616; cv=none; d=zohomail.com; s=zohoarc; b=ARTuBemhfHD7PHmg2/V8DzU/9Dn/d49oG7L/TAk/ojBTw+nGjCc7mgzgm19YQF6BcdidPONvz9lYt8ee5WQ1VSmqclPBRtlxbCSOgMB3ufE2FU2Q8o9SQoS/oJl9muE3vU7jnIUGLk3ayNnM28ctnqmIQcDBKvurysbgexTurQY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1630681616; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=u7PRBaKNvpJUcvrNoVjDcU/pRAPQ2hgSBvfk9KJrnqw=; b=XMWdENT0WMuT9rlQokC/uyNTR2hphm6KIUcVn4Ge/wo9Jd+GE25NfTzZBUZ1EHnrn3A/VyZ6Lpj9/pBGGRRkPM5Ne5SoMCE576G2PPp/iuxO+bKLc9piTUuGpqZF2GXTCW4vMVgE2/QhXnuz705WQSfOpHx+wOfuBxhXJm6l9bA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1630681616; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding; bh=u7PRBaKNvpJUcvrNoVjDcU/pRAPQ2hgSBvfk9KJrnqw=; b=OzwCtjbU4kYMAtY1yhSuNuLDvoFFlER0mEE5EWyiXzLJdEQ9PHsEE+HbZ4u+jjKi BYt0KZYp0443rj5w0liaHuP7Z2qXctYh+fDnr0muhUOKbZFKc37Mkzg3xY7PdtsSElF IFX+pQlzGXRki4bhyRbZNZvZKMSVfaVXFntkCGrQ= From: "Daniel P. Smith" To: "Daniel P. Smith" , xen-devel@lists.xenproject.org Cc: Daniel De Graaf Subject: [PATCH v4 11/11] xsm: remove alternate xsm hook interface Date: Fri, 3 Sep 2021 15:06:29 -0400 Message-Id: <20210903190629.11917-12-dpsmith@apertussolutions.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210903190629.11917-1-dpsmith@apertussolutions.com> References: <20210903190629.11917-1-dpsmith@apertussolutions.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-ZohoMailClient: External Hidden behind macro magic is an alternative xsm hook interface dedicated for use when the dummy/default policy is the only one built. This alternative interface increases code complexity and code size in the core security framework of Xen. This results in code requiring additional maintanence and additional risk for securit-relevant bugs. This patch removes this additional interface, making Xen's security framework have a single, consistent interface that works in a single and consistent manner regardless of which XSM policy is in use. Signed-off-by: Daniel P. Smith --- xen/include/xsm/dummy.h | 824 ------------------------------------- xen/include/xsm/xsm-core.h | 51 ++- xen/include/xsm/xsm.h | 279 ++++++++----- xen/xsm/Makefile | 2 +- xen/xsm/dummy.c | 2 +- xen/xsm/dummy.h | 739 +++++++++++++++++++++++++++++++++ xen/xsm/silo.c | 2 +- xen/xsm/xsm_core.c | 4 - 8 files changed, 952 insertions(+), 951 deletions(-) delete mode 100644 xen/include/xsm/dummy.h create mode 100644 xen/xsm/dummy.h diff --git a/xen/include/xsm/dummy.h b/xen/include/xsm/dummy.h deleted file mode 100644 index d2a005c521..0000000000 --- a/xen/include/xsm/dummy.h +++ /dev/null @@ -1,824 +0,0 @@ -/* - * Default XSM hooks - IS_PRIV and IS_PRIV_FOR checks - * - * Author: Daniel De Graaf - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License version 2, - * as published by the Free Software Foundation. - * - * - * Each XSM hook implementing an access check should have its first parameter - * preceded by XSM_DEFAULT_ARG (or use XSM_DEFAULT_VOID if it has no - * arguments). The first non-declaration statement shold be XSM_ASSERT_ACTION - * with the expected type of the hook, which will either define or check the - * value of action. - */ - -#include -#include -#include - -/* Cannot use BUILD_BUG_ON here because the expressions we check are not - * considered constant at compile time. Instead, rely on constant propagation to - * inline out the calls to this invalid function, which will cause linker errors - * if references remain at link time. - */ -#define LINKER_BUG_ON(x) do { if (x) __xsm_action_mismatch_detected(); } while (0) - -#if defined(CONFIG_COVERAGE) && defined(__clang__) -/* - * LLVM coverage support seems to disable some of the optimizations needed in - * order for XSM to compile. Since coverage should not be used in production - * provide an implementation of __xsm_action_mismatch_detected to satisfy the - * linker. - */ -static inline void __xsm_action_mismatch_detected(void) -{ - ASSERT_UNREACHABLE(); -} -#else -/* DO NOT implement this function; it is supposed to trigger link errors */ -void __xsm_action_mismatch_detected(void); -#endif - -#ifdef CONFIG_XSM_CONFIGURABLE - -/* In CONFIG_XSM_CONFIGURABLE builds, this header file is included from - * xsm/dummy.c, and contains static (not inline) functions compiled to the - * dummy XSM module. There is no xsm_default_t argument available, so the - * value from the assertion is used to initialize the variable. - */ -#define XSM_INLINE __maybe_unused - -#define XSM_DEFAULT_ARG /* */ -#define XSM_DEFAULT_VOID void -#define XSM_ASSERT_ACTION(def) xsm_default_t action = def; (void)action - -#else /* CONFIG_XSM_CONFIGURABLE */ - -/* In !CONFIG_XSM_CONFIGURABLE builds, this header file is included from - * xsm/xsm.h, and contains inline functions for each XSM hook. These functions - * also perform compile-time checks on the xsm_default_t argument to ensure - * that the behavior of the dummy XSM module is the same as the behavior with - * XSM disabled. - */ -#define XSM_INLINE always_inline -#define XSM_DEFAULT_ARG xsm_default_t action, -#define XSM_DEFAULT_VOID xsm_default_t action -#define XSM_ASSERT_ACTION(def) LINKER_BUG_ON(def != action) - -#endif /* CONFIG_XSM_CONFIGURABLE */ - -static always_inline int xsm_default_action(xsm_default_t action, - struct domain *src, - struct domain *target) -{ - switch ( action ) { - case XSM_HOOK: - return 0; - case XSM_TARGET: - if ( evaluate_nospec(src == target) ) - { - return 0; - case XSM_XS_PRIV: - if ( evaluate_nospec(is_xenstore_domain(src)) ) - return 0; - } - /* fall through */ - case XSM_DM_PRIV: - if ( target && evaluate_nospec(src->target == target) ) - return 0; - /* fall through */ - case XSM_PRIV: - if ( is_control_domain(src) ) - return 0; - return -EPERM; - default: - LINKER_BUG_ON(1); - return -EPERM; - } -} - -static XSM_INLINE void xsm_security_domaininfo(struct domain *d, - struct xen_domctl_getdomaininfo *info) -{ - return; -} - -static XSM_INLINE int xsm_domain_create(XSM_DEFAULT_ARG struct domain *d, - uint32_t ssidref) -{ - XSM_ASSERT_ACTION(XSM_HOOK); - return xsm_default_action(action, current->domain, d); -} - -static XSM_INLINE int xsm_getdomaininfo(XSM_DEFAULT_ARG struct domain *d) -{ - XSM_ASSERT_ACTION(XSM_HOOK); - return xsm_default_action(action, current->domain, d); -} - -static XSM_INLINE int xsm_domctl_scheduler_op(XSM_DEFAULT_ARG struct domain *d, - int cmd) -{ - XSM_ASSERT_ACTION(XSM_HOOK); - return xsm_default_action(action, current->domain, d); -} - -static XSM_INLINE int xsm_sysctl_scheduler_op(XSM_DEFAULT_ARG int cmd) -{ - XSM_ASSERT_ACTION(XSM_HOOK); - return xsm_default_action(action, current->domain, NULL); -} - -static XSM_INLINE int xsm_set_target(XSM_DEFAULT_ARG struct domain *d, - struct domain *e) -{ - XSM_ASSERT_ACTION(XSM_HOOK); - return xsm_default_action(action, current->domain, NULL); -} - -static XSM_INLINE int xsm_domctl(XSM_DEFAULT_ARG struct domain *d, int cmd) -{ - XSM_ASSERT_ACTION(XSM_OTHER); - switch ( cmd ) - { - case XEN_DOMCTL_ioport_mapping: - case XEN_DOMCTL_memory_mapping: - case XEN_DOMCTL_bind_pt_irq: - case XEN_DOMCTL_unbind_pt_irq: - return xsm_default_action(XSM_DM_PRIV, current->domain, d); - case XEN_DOMCTL_getdomaininfo: - return xsm_default_action(XSM_XS_PRIV, current->domain, d); - default: - return xsm_default_action(XSM_PRIV, current->domain, d); - } -} - -static XSM_INLINE int xsm_sysctl(XSM_DEFAULT_ARG int cmd) -{ - XSM_ASSERT_ACTION(XSM_PRIV); - return xsm_default_action(action, current->domain, NULL); -} - -static XSM_INLINE int xsm_readconsole(XSM_DEFAULT_ARG uint32_t clear) -{ - XSM_ASSERT_ACTION(XSM_HOOK); - return xsm_default_action(action, current->domain, NULL); -} - -static XSM_INLINE int xsm_alloc_security_domain(struct domain *d) -{ - return 0; -} - -static XSM_INLINE void xsm_free_security_domain(struct domain *d) -{ - return; -} - -static XSM_INLINE int xsm_grant_mapref(XSM_DEFAULT_ARG struct domain *d1, - struct domain *d2, uint32_t flags) -{ - XSM_ASSERT_ACTION(XSM_HOOK); - return xsm_default_action(action, d1, d2); -} - -static XSM_INLINE int xsm_grant_unmapref(XSM_DEFAULT_ARG struct domain *d1, - struct domain *d2) -{ - XSM_ASSERT_ACTION(XSM_HOOK); - return xsm_default_action(action, d1, d2); -} - -static XSM_INLINE int xsm_grant_setup(XSM_DEFAULT_ARG struct domain *d1, - struct domain *d2) -{ - XSM_ASSERT_ACTION(XSM_TARGET); - return xsm_default_action(action, d1, d2); -} - -static XSM_INLINE int xsm_grant_transfer(XSM_DEFAULT_ARG struct domain *d1, - struct domain *d2) -{ - XSM_ASSERT_ACTION(XSM_HOOK); - return xsm_default_action(action, d1, d2); -} - -static XSM_INLINE int xsm_grant_copy(XSM_DEFAULT_ARG struct domain *d1, - struct domain *d2) -{ - XSM_ASSERT_ACTION(XSM_HOOK); - return xsm_default_action(action, d1, d2); -} - -static XSM_INLINE int xsm_grant_query_size(XSM_DEFAULT_ARG struct domain *d1, - struct domain *d2) -{ - XSM_ASSERT_ACTION(XSM_TARGET); - return xsm_default_action(action, d1, d2); -} - -static XSM_INLINE int xsm_memory_exchange(XSM_DEFAULT_ARG struct domain *d) -{ - XSM_ASSERT_ACTION(XSM_TARGET); - return xsm_default_action(action, current->domain, d); -} - -static XSM_INLINE int xsm_memory_adjust_reservation(XSM_DEFAULT_ARG - struct domain *d1, - struct domain *d2) -{ - XSM_ASSERT_ACTION(XSM_TARGET); - return xsm_default_action(action, d1, d2); -} - -static XSM_INLINE int xsm_memory_stat_reservation(XSM_DEFAULT_ARG - struct domain *d1, - struct domain *d2) -{ - XSM_ASSERT_ACTION(XSM_TARGET); - return xsm_default_action(action, d1, d2); -} - -static XSM_INLINE int xsm_console_io(XSM_DEFAULT_ARG struct domain *d, int cmd) -{ - XSM_ASSERT_ACTION(XSM_OTHER); - if ( d->is_console ) - return xsm_default_action(XSM_HOOK, d, NULL); -#ifdef CONFIG_VERBOSE_DEBUG - if ( cmd == CONSOLEIO_write ) - return xsm_default_action(XSM_HOOK, d, NULL); -#endif - return xsm_default_action(XSM_PRIV, d, NULL); -} - -static XSM_INLINE int xsm_profile(XSM_DEFAULT_ARG struct domain *d, int op) -{ - XSM_ASSERT_ACTION(XSM_HOOK); - return xsm_default_action(action, d, NULL); -} - -static XSM_INLINE int xsm_kexec(XSM_DEFAULT_VOID) -{ - XSM_ASSERT_ACTION(XSM_PRIV); - return xsm_default_action(action, current->domain, NULL); -} - -static XSM_INLINE int xsm_schedop_shutdown(XSM_DEFAULT_ARG struct domain *d1, - struct domain *d2) -{ - XSM_ASSERT_ACTION(XSM_DM_PRIV); - return xsm_default_action(action, d1, d2); -} - -static XSM_INLINE int xsm_memory_pin_page(XSM_DEFAULT_ARG struct domain *d1, - struct domain *d2, - struct page_info *page) -{ - XSM_ASSERT_ACTION(XSM_HOOK); - return xsm_default_action(action, d1, d2); -} - -static XSM_INLINE int xsm_claim_pages(XSM_DEFAULT_ARG struct domain *d) -{ - XSM_ASSERT_ACTION(XSM_PRIV); - return xsm_default_action(action, current->domain, d); -} - -static XSM_INLINE int xsm_evtchn_unbound(XSM_DEFAULT_ARG struct domain *d, - struct evtchn *chn, domid_t id2) -{ - XSM_ASSERT_ACTION(XSM_TARGET); - return xsm_default_action(action, current->domain, d); -} - -static XSM_INLINE int xsm_evtchn_interdomain(XSM_DEFAULT_ARG struct domain *d1, - struct evtchn *chan1, - struct domain *d2, - struct evtchn *chan2) -{ - XSM_ASSERT_ACTION(XSM_HOOK); - return xsm_default_action(action, d1, d2); -} - -static XSM_INLINE void xsm_evtchn_close_post(struct evtchn *chn) -{ - return; -} - -static XSM_INLINE int xsm_evtchn_send(XSM_DEFAULT_ARG struct domain *d, - struct evtchn *chn) -{ - XSM_ASSERT_ACTION(XSM_HOOK); - return xsm_default_action(action, d, NULL); -} - -static XSM_INLINE int xsm_evtchn_status(XSM_DEFAULT_ARG struct domain *d, - struct evtchn *chn) -{ - XSM_ASSERT_ACTION(XSM_TARGET); - return xsm_default_action(action, current->domain, d); -} - -static XSM_INLINE int xsm_evtchn_reset(XSM_DEFAULT_ARG struct domain *d1, - struct domain *d2) -{ - XSM_ASSERT_ACTION(XSM_TARGET); - return xsm_default_action(action, d1, d2); -} - -static XSM_INLINE int xsm_alloc_security_evtchns(struct evtchn chn[], - unsigned int nr) -{ - return 0; -} - -static XSM_INLINE void xsm_free_security_evtchns(struct evtchn chn[], - unsigned int nr) -{ - return; -} - -static XSM_INLINE char *xsm_show_security_evtchn(struct domain *d, - const struct evtchn *chn) -{ - return NULL; -} - -static XSM_INLINE int xsm_init_hardware_domain(XSM_DEFAULT_ARG struct domain *d) -{ - XSM_ASSERT_ACTION(XSM_HOOK); - return xsm_default_action(action, current->domain, d); -} - -static XSM_INLINE int xsm_get_pod_target(XSM_DEFAULT_ARG struct domain *d) -{ - XSM_ASSERT_ACTION(XSM_PRIV); - return xsm_default_action(action, current->domain, d); -} - -static XSM_INLINE int xsm_set_pod_target(XSM_DEFAULT_ARG struct domain *d) -{ - XSM_ASSERT_ACTION(XSM_PRIV); - return xsm_default_action(action, current->domain, d); -} - -static XSM_INLINE int xsm_get_vnumainfo(XSM_DEFAULT_ARG struct domain *d) -{ - XSM_ASSERT_ACTION(XSM_TARGET); - return xsm_default_action(action, current->domain, d); -} - -#if defined(CONFIG_HAS_PASSTHROUGH) && defined(CONFIG_HAS_PCI) -static XSM_INLINE int xsm_get_device_group(XSM_DEFAULT_ARG uint32_t machine_bdf) -{ - XSM_ASSERT_ACTION(XSM_HOOK); - return xsm_default_action(action, current->domain, NULL); -} - -static XSM_INLINE int xsm_assign_device(XSM_DEFAULT_ARG struct domain *d, - uint32_t machine_bdf) -{ - XSM_ASSERT_ACTION(XSM_HOOK); - return xsm_default_action(action, current->domain, d); -} - -static XSM_INLINE int xsm_deassign_device(XSM_DEFAULT_ARG struct domain *d, - uint32_t machine_bdf) -{ - XSM_ASSERT_ACTION(XSM_HOOK); - return xsm_default_action(action, current->domain, d); -} - -#endif /* HAS_PASSTHROUGH && HAS_PCI */ - -#if defined(CONFIG_HAS_PASSTHROUGH) && defined(CONFIG_HAS_DEVICE_TREE) -static XSM_INLINE int xsm_assign_dtdevice(XSM_DEFAULT_ARG struct domain *d, - const char *dtpath) -{ - XSM_ASSERT_ACTION(XSM_HOOK); - return xsm_default_action(action, current->domain, d); -} - -static XSM_INLINE int xsm_deassign_dtdevice(XSM_DEFAULT_ARG struct domain *d, - const char *dtpath) -{ - XSM_ASSERT_ACTION(XSM_HOOK); - return xsm_default_action(action, current->domain, d); -} - -#endif /* HAS_PASSTHROUGH && HAS_DEVICE_TREE */ - -static XSM_INLINE int xsm_resource_plug_core(XSM_DEFAULT_VOID) -{ - XSM_ASSERT_ACTION(XSM_HOOK); - return xsm_default_action(action, current->domain, NULL); -} - -static XSM_INLINE int xsm_resource_unplug_core(XSM_DEFAULT_VOID) -{ - XSM_ASSERT_ACTION(XSM_HOOK); - return xsm_default_action(action, current->domain, NULL); -} - -static XSM_INLINE int xsm_resource_plug_pci(XSM_DEFAULT_ARG - uint32_t machine_bdf) -{ - XSM_ASSERT_ACTION(XSM_PRIV); - return xsm_default_action(action, current->domain, NULL); -} - -static XSM_INLINE int xsm_resource_unplug_pci(XSM_DEFAULT_ARG - uint32_t machine_bdf) -{ - XSM_ASSERT_ACTION(XSM_PRIV); - return xsm_default_action(action, current->domain, NULL); -} - -static XSM_INLINE int xsm_resource_setup_pci(XSM_DEFAULT_ARG - uint32_t machine_bdf) -{ - XSM_ASSERT_ACTION(XSM_PRIV); - return xsm_default_action(action, current->domain, NULL); -} - -static XSM_INLINE int xsm_resource_setup_gsi(XSM_DEFAULT_ARG int gsi) -{ - XSM_ASSERT_ACTION(XSM_PRIV); - return xsm_default_action(action, current->domain, NULL); -} - -static XSM_INLINE int xsm_resource_setup_misc(XSM_DEFAULT_VOID) -{ - XSM_ASSERT_ACTION(XSM_PRIV); - return xsm_default_action(action, current->domain, NULL); -} - -static XSM_INLINE int xsm_page_offline(XSM_DEFAULT_ARG uint32_t cmd) -{ - XSM_ASSERT_ACTION(XSM_HOOK); - return xsm_default_action(action, current->domain, NULL); -} - -static XSM_INLINE int xsm_hypfs_op(XSM_DEFAULT_VOID) -{ - XSM_ASSERT_ACTION(XSM_PRIV); - return xsm_default_action(action, current->domain, NULL); -} - -static XSM_INLINE long xsm_do_xsm_op(XEN_GUEST_HANDLE_PARAM(void) op) -{ - return -ENOSYS; -} - -#ifdef CONFIG_COMPAT -static XSM_INLINE int xsm_do_compat_op(XEN_GUEST_HANDLE_PARAM(void) op) -{ - return -ENOSYS; -} -#endif - -static XSM_INLINE char *xsm_show_irq_sid(int irq) -{ - return NULL; -} - -static XSM_INLINE int xsm_map_domain_pirq(XSM_DEFAULT_ARG struct domain *d) -{ - XSM_ASSERT_ACTION(XSM_DM_PRIV); - return xsm_default_action(action, current->domain, d); -} - -static XSM_INLINE int xsm_map_domain_irq(XSM_DEFAULT_ARG struct domain *d, - int irq, const void *data) -{ - XSM_ASSERT_ACTION(XSM_HOOK); - return xsm_default_action(action, current->domain, d); -} - -static XSM_INLINE int xsm_unmap_domain_pirq(XSM_DEFAULT_ARG struct domain *d) -{ - XSM_ASSERT_ACTION(XSM_DM_PRIV); - return xsm_default_action(action, current->domain, d); -} - -static XSM_INLINE int xsm_bind_pt_irq(XSM_DEFAULT_ARG struct domain *d, - struct xen_domctl_bind_pt_irq *bind) -{ - XSM_ASSERT_ACTION(XSM_HOOK); - return xsm_default_action(action, current->domain, d); -} - -static XSM_INLINE int xsm_unbind_pt_irq(XSM_DEFAULT_ARG struct domain *d, - struct xen_domctl_bind_pt_irq *bind) -{ - XSM_ASSERT_ACTION(XSM_HOOK); - return xsm_default_action(action, current->domain, d); -} - -static XSM_INLINE int xsm_unmap_domain_irq(XSM_DEFAULT_ARG struct domain *d, - int irq, const void *data) -{ - XSM_ASSERT_ACTION(XSM_HOOK); - return xsm_default_action(action, current->domain, d); -} - -static XSM_INLINE int xsm_irq_permission(XSM_DEFAULT_ARG struct domain *d, - int pirq, uint8_t allow) -{ - XSM_ASSERT_ACTION(XSM_HOOK); - return xsm_default_action(action, current->domain, d); -} - -static XSM_INLINE int xsm_iomem_permission(XSM_DEFAULT_ARG struct domain *d, - uint64_t s, uint64_t e, - uint8_t allow) -{ - XSM_ASSERT_ACTION(XSM_HOOK); - return xsm_default_action(action, current->domain, d); -} - -static XSM_INLINE int xsm_iomem_mapping(XSM_DEFAULT_ARG struct domain *d, - uint64_t s, uint64_t e, uint8_t allow) -{ - XSM_ASSERT_ACTION(XSM_HOOK); - return xsm_default_action(action, current->domain, d); -} - -static XSM_INLINE int xsm_pci_config_permission(XSM_DEFAULT_ARG - struct domain *d, - uint32_t machine_bdf, - uint16_t start, uint16_t end, - uint8_t access) -{ - XSM_ASSERT_ACTION(XSM_HOOK); - return xsm_default_action(action, current->domain, d); -} - -static XSM_INLINE int xsm_add_to_physmap(XSM_DEFAULT_ARG struct domain *d1, - struct domain *d2) -{ - XSM_ASSERT_ACTION(XSM_TARGET); - return xsm_default_action(action, d1, d2); -} - -static XSM_INLINE int xsm_remove_from_physmap(XSM_DEFAULT_ARG struct domain *d1, - struct domain *d2) -{ - XSM_ASSERT_ACTION(XSM_TARGET); - return xsm_default_action(action, d1, d2); -} - -static XSM_INLINE int xsm_map_gmfn_foreign(XSM_DEFAULT_ARG struct domain *d, - struct domain *t) -{ - XSM_ASSERT_ACTION(XSM_TARGET); - return xsm_default_action(action, d, t); -} - -static XSM_INLINE int xsm_hvm_param(XSM_DEFAULT_ARG struct domain *d, - unsigned long op) -{ - XSM_ASSERT_ACTION(XSM_TARGET); - return xsm_default_action(action, current->domain, d); -} - -static XSM_INLINE int xsm_hvm_control(XSM_DEFAULT_ARG struct domain *d, - unsigned long op) -{ - XSM_ASSERT_ACTION(XSM_DM_PRIV); - return xsm_default_action(action, current->domain, d); -} - -static XSM_INLINE int xsm_hvm_param_altp2mhvm(XSM_DEFAULT_ARG struct domain *d) -{ - XSM_ASSERT_ACTION(XSM_PRIV); - return xsm_default_action(action, current->domain, d); -} - -static XSM_INLINE int xsm_hvm_altp2mhvm_op(XSM_DEFAULT_ARG struct domain *d, - uint64_t mode, uint32_t op) -{ - XSM_ASSERT_ACTION(XSM_OTHER); - - switch ( mode ) - { - case XEN_ALTP2M_mixed: - return xsm_default_action(XSM_TARGET, current->domain, d); - case XEN_ALTP2M_external: - return xsm_default_action(XSM_DM_PRIV, current->domain, d); - case XEN_ALTP2M_limited: - if ( HVMOP_altp2m_vcpu_enable_notify == op ) - return xsm_default_action(XSM_TARGET, current->domain, d); - return xsm_default_action(XSM_DM_PRIV, current->domain, d); - default: - return -EPERM; - } -} - -static XSM_INLINE int xsm_vm_event_control(XSM_DEFAULT_ARG struct domain *d, - int mode, int op) -{ - XSM_ASSERT_ACTION(XSM_PRIV); - return xsm_default_action(action, current->domain, d); -} - -#ifdef CONFIG_MEM_ACCESS -static XSM_INLINE int xsm_mem_access(XSM_DEFAULT_ARG struct domain *d) -{ - XSM_ASSERT_ACTION(XSM_DM_PRIV); - return xsm_default_action(action, current->domain, d); -} -#endif - -#ifdef CONFIG_MEM_PAGING -static XSM_INLINE int xsm_mem_paging(XSM_DEFAULT_ARG struct domain *d) -{ - XSM_ASSERT_ACTION(XSM_DM_PRIV); - return xsm_default_action(action, current->domain, d); -} -#endif - -#ifdef CONFIG_MEM_SHARING -static XSM_INLINE int xsm_mem_sharing(XSM_DEFAULT_ARG struct domain *d) -{ - XSM_ASSERT_ACTION(XSM_DM_PRIV); - return xsm_default_action(action, current->domain, d); -} -#endif - -static XSM_INLINE int xsm_platform_op(XSM_DEFAULT_ARG uint32_t op) -{ - XSM_ASSERT_ACTION(XSM_PRIV); - return xsm_default_action(action, current->domain, NULL); -} - -#ifdef CONFIG_X86 -static XSM_INLINE int xsm_do_mca(XSM_DEFAULT_VOID) -{ - XSM_ASSERT_ACTION(XSM_PRIV); - return xsm_default_action(action, current->domain, NULL); -} - -static XSM_INLINE int xsm_shadow_control(XSM_DEFAULT_ARG struct domain *d, - uint32_t op) -{ - XSM_ASSERT_ACTION(XSM_HOOK); - return xsm_default_action(action, current->domain, d); -} - -static XSM_INLINE int xsm_mem_sharing_op(XSM_DEFAULT_ARG struct domain *d, - struct domain *cd, int op) -{ - XSM_ASSERT_ACTION(XSM_DM_PRIV); - return xsm_default_action(action, current->domain, cd); -} - -static XSM_INLINE int xsm_apic(XSM_DEFAULT_ARG struct domain *d, int cmd) -{ - XSM_ASSERT_ACTION(XSM_PRIV); - return xsm_default_action(action, d, NULL); -} - -static XSM_INLINE int xsm_machine_memory_map(XSM_DEFAULT_VOID) -{ - XSM_ASSERT_ACTION(XSM_PRIV); - return xsm_default_action(action, current->domain, NULL); -} - -static XSM_INLINE int xsm_domain_memory_map(XSM_DEFAULT_ARG struct domain *d) -{ - XSM_ASSERT_ACTION(XSM_TARGET); - return xsm_default_action(action, current->domain, d); -} - -static XSM_INLINE int xsm_mmu_update(XSM_DEFAULT_ARG struct domain *d, - struct domain *t, struct domain *f, - uint32_t flags) -{ - int rc = 0; - XSM_ASSERT_ACTION(XSM_TARGET); - if ( f != dom_io ) - rc = xsm_default_action(action, d, f); - if ( evaluate_nospec(t) && !rc ) - rc = xsm_default_action(action, d, t); - return rc; -} - -static XSM_INLINE int xsm_mmuext_op(XSM_DEFAULT_ARG struct domain *d, - struct domain *f) -{ - XSM_ASSERT_ACTION(XSM_TARGET); - return xsm_default_action(action, d, f); -} - -static XSM_INLINE int xsm_update_va_mapping(XSM_DEFAULT_ARG struct domain *d, - struct domain *f, l1_pgentry_t pte) -{ - XSM_ASSERT_ACTION(XSM_TARGET); - return xsm_default_action(action, d, f); -} - -static XSM_INLINE int xsm_priv_mapping(XSM_DEFAULT_ARG struct domain *d, - struct domain *t) -{ - XSM_ASSERT_ACTION(XSM_TARGET); - return xsm_default_action(action, d, t); -} - -static XSM_INLINE int xsm_ioport_permission(XSM_DEFAULT_ARG struct domain *d, - uint32_t s, uint32_t e, - uint8_t allow) -{ - XSM_ASSERT_ACTION(XSM_HOOK); - return xsm_default_action(action, current->domain, d); -} - -static XSM_INLINE int xsm_ioport_mapping(XSM_DEFAULT_ARG struct domain *d, - uint32_t s, uint32_t e, uint8_t allow) -{ - XSM_ASSERT_ACTION(XSM_HOOK); - return xsm_default_action(action, current->domain, d); -} - -static XSM_INLINE int xsm_pmu_op(XSM_DEFAULT_ARG struct domain *d, - unsigned int op) -{ - XSM_ASSERT_ACTION(XSM_OTHER); - switch ( op ) - { - case XENPMU_init: - case XENPMU_finish: - case XENPMU_lvtpc_set: - case XENPMU_flush: - return xsm_default_action(XSM_HOOK, d, current->domain); - default: - return xsm_default_action(XSM_PRIV, d, current->domain); - } -} - -#endif /* CONFIG_X86 */ - -static XSM_INLINE int xsm_dm_op(XSM_DEFAULT_ARG struct domain *d) -{ - XSM_ASSERT_ACTION(XSM_DM_PRIV); - return xsm_default_action(action, current->domain, d); -} - -#ifdef CONFIG_ARGO -static XSM_INLINE int xsm_argo_enable(const struct domain *d) -{ - return 0; -} - -static XSM_INLINE int xsm_argo_register_single_source(const struct domain *d, - const struct domain *t) -{ - return 0; -} - -static XSM_INLINE int xsm_argo_register_any_source(const struct domain *d) -{ - return 0; -} - -static XSM_INLINE int xsm_argo_send(const struct domain *d, - const struct domain *t) -{ - return 0; -} - -#endif /* CONFIG_ARGO */ - -#include -static XSM_INLINE int xsm_xen_version(XSM_DEFAULT_ARG uint32_t op) -{ - XSM_ASSERT_ACTION(XSM_OTHER); - switch ( op ) - { - case XENVER_version: - case XENVER_platform_parameters: - case XENVER_get_features: - /* These sub-ops ignore the permission checks and return data. */ - block_speculation(); - return 0; - case XENVER_extraversion: - case XENVER_compile_info: - case XENVER_capabilities: - case XENVER_changeset: - case XENVER_pagesize: - case XENVER_guest_handle: - /* These MUST always be accessible to any guest by default. */ - return xsm_default_action(XSM_HOOK, current->domain, NULL); - default: - return xsm_default_action(XSM_PRIV, current->domain, NULL); - } -} - -static XSM_INLINE int xsm_domain_resource_map(XSM_DEFAULT_ARG struct domain *d) -{ - XSM_ASSERT_ACTION(XSM_DM_PRIV); - return xsm_default_action(action, current->domain, d); -} diff --git a/xen/include/xsm/xsm-core.h b/xen/include/xsm/xsm-core.h index a80d6a981f..0da625317e 100644 --- a/xen/include/xsm/xsm-core.h +++ b/xen/include/xsm/xsm-core.h @@ -18,6 +18,31 @@ #include #include +/* Cannot use BUILD_BUG_ON here because the expressions we check are not + * considered constant at compile time. Instead, rely on constant propagation to + * inline out the calls to this invalid function, which will cause linker errors + * if references remain at link time. + */ +#define XSM_LINKER_BUG_ON(x) do { if (x) __xsm_action_mismatch_detected(); } while (0) + +#if defined(CONFIG_COVERAGE) && defined(__clang__) +/* + * LLVM coverage support seems to disable some of the optimizations needed in + * order for XSM to compile. Since coverage should not be used in production + * provide an implementation of __xsm_action_mismatch_detected to satisfy the + * linker. + */ +static inline void __xsm_action_mismatch_detected(void) +{ + ASSERT_UNREACHABLE(); +} +#else +/* DO NOT implement this function; it is supposed to trigger link errors */ +void __xsm_action_mismatch_detected(void); +#endif + +#define XSM_ASSERT_ACTION(def) XSM_LINKER_BUG_ON(def != action) + /* policy magic number (defined by XSM_MAGIC) */ typedef uint32_t xsm_magic_t; @@ -205,8 +230,6 @@ struct xsm_ops { void xsm_fixup_ops(struct xsm_ops *ops); -#ifdef CONFIG_XSM_CONFIGURABLE - #ifdef CONFIG_MULTIBOOT int xsm_multiboot_init(unsigned long *module_map, const multiboot_info_t *mbi); @@ -247,28 +270,4 @@ static const inline struct xsm_ops *silo_init(void) } #endif -#else /* CONFIG_XSM_CONFIGURABLE */ - -#ifdef CONFIG_MULTIBOOT -static inline int xsm_multiboot_init(unsigned long *module_map, - const multiboot_info_t *mbi) -{ - return 0; -} -#endif - -#ifdef CONFIG_HAS_DEVICE_TREE -static inline int xsm_dt_init(void) -{ - return 0; -} - -static inline bool has_xsm_magic(paddr_t start) -{ - return false; -} -#endif /* CONFIG_HAS_DEVICE_TREE */ - -#endif /* CONFIG_XSM_CONFIGURABLE */ - #endif /* __XSM_CORE_H */ diff --git a/xen/include/xsm/xsm.h b/xen/include/xsm/xsm.h index 4d5f441935..33bc2570bf 100644 --- a/xen/include/xsm/xsm.h +++ b/xen/include/xsm/xsm.h @@ -20,8 +20,6 @@ #include #include -#ifdef CONFIG_XSM_CONFIGURABLE - extern struct xsm_ops xsm_ops; static inline void xsm_security_domaininfo(struct domain *d, @@ -30,60 +28,72 @@ static inline void xsm_security_domaininfo(struct domain *d, alternative_vcall(xsm_ops.security_domaininfo, d, info); } -static inline int xsm_domain_create(xsm_default_t def, struct domain *d, +static inline int xsm_domain_create(xsm_default_t action, struct domain *d, uint32_t ssidref) { + XSM_ASSERT_ACTION(XSM_HOOK); return alternative_call(xsm_ops.domain_create, d, ssidref); } -static inline int xsm_getdomaininfo(xsm_default_t def, struct domain *d) +static inline int xsm_getdomaininfo(xsm_default_t action, struct domain *d) { + XSM_ASSERT_ACTION(XSM_HOOK); return alternative_call(xsm_ops.getdomaininfo, d); } -static inline int xsm_domctl_scheduler_op(xsm_default_t def, struct domain *d, +static inline int xsm_domctl_scheduler_op(xsm_default_t action, + struct domain *d, int cmd) { + XSM_ASSERT_ACTION(XSM_HOOK); return alternative_call(xsm_ops.domctl_scheduler_op, d, cmd); } -static inline int xsm_sysctl_scheduler_op(xsm_default_t def, int cmd) +static inline int xsm_sysctl_scheduler_op(xsm_default_t action, int cmd) { + XSM_ASSERT_ACTION(XSM_HOOK); return alternative_call(xsm_ops.sysctl_scheduler_op, cmd); } -static inline int xsm_set_target(xsm_default_t def, struct domain *d, +static inline int xsm_set_target(xsm_default_t action, struct domain *d, struct domain *e) { + XSM_ASSERT_ACTION(XSM_HOOK); return alternative_call(xsm_ops.set_target, d, e); } -static inline int xsm_domctl(xsm_default_t def, struct domain *d, int cmd) +static inline int xsm_domctl(xsm_default_t action, struct domain *d, int cmd) { + XSM_ASSERT_ACTION(XSM_OTHER); return alternative_call(xsm_ops.domctl, d, cmd); } -static inline int xsm_sysctl(xsm_default_t def, int cmd) +static inline int xsm_sysctl(xsm_default_t action, int cmd) { + XSM_ASSERT_ACTION(XSM_PRIV); return alternative_call(xsm_ops.sysctl, cmd); } -static inline int xsm_readconsole(xsm_default_t def, uint32_t clear) +static inline int xsm_readconsole(xsm_default_t action, uint32_t clear) { + XSM_ASSERT_ACTION(XSM_HOOK); return alternative_call(xsm_ops.readconsole, clear); } -static inline int xsm_evtchn_unbound(xsm_default_t def, struct domain *d1, +static inline int xsm_evtchn_unbound(xsm_default_t action, struct domain *d1, struct evtchn *chn, domid_t id2) { + XSM_ASSERT_ACTION(XSM_TARGET); return alternative_call(xsm_ops.evtchn_unbound, d1, chn, id2); } -static inline int xsm_evtchn_interdomain(xsm_default_t def, struct domain *d1, +static inline int xsm_evtchn_interdomain(xsm_default_t action, + struct domain *d1, struct evtchn *chan1, struct domain *d2, struct evtchn *chan2) { + XSM_ASSERT_ACTION(XSM_HOOK); return alternative_call(xsm_ops.evtchn_interdomain, d1, chan1, d2, chan2); } @@ -92,57 +102,66 @@ static inline void xsm_evtchn_close_post(struct evtchn *chn) alternative_vcall(xsm_ops.evtchn_close_post, chn); } -static inline int xsm_evtchn_send(xsm_default_t def, struct domain *d, +static inline int xsm_evtchn_send(xsm_default_t action, struct domain *d, struct evtchn *chn) { + XSM_ASSERT_ACTION(XSM_HOOK); return alternative_call(xsm_ops.evtchn_send, d, chn); } -static inline int xsm_evtchn_status(xsm_default_t def, struct domain *d, +static inline int xsm_evtchn_status(xsm_default_t action, struct domain *d, struct evtchn *chn) { + XSM_ASSERT_ACTION(XSM_TARGET); return alternative_call(xsm_ops.evtchn_status, d, chn); } -static inline int xsm_evtchn_reset(xsm_default_t def, struct domain *d1, +static inline int xsm_evtchn_reset(xsm_default_t action, struct domain *d1, struct domain *d2) { + XSM_ASSERT_ACTION(XSM_TARGET); return alternative_call(xsm_ops.evtchn_reset, d1, d2); } -static inline int xsm_grant_mapref(xsm_default_t def, struct domain *d1, +static inline int xsm_grant_mapref(xsm_default_t action, struct domain *d1, struct domain *d2, uint32_t flags) { + XSM_ASSERT_ACTION(XSM_HOOK); return alternative_call(xsm_ops.grant_mapref, d1, d2, flags); } -static inline int xsm_grant_unmapref(xsm_default_t def, struct domain *d1, +static inline int xsm_grant_unmapref(xsm_default_t action, struct domain *d1, struct domain *d2) { + XSM_ASSERT_ACTION(XSM_HOOK); return alternative_call(xsm_ops.grant_unmapref, d1, d2); } -static inline int xsm_grant_setup(xsm_default_t def, struct domain *d1, +static inline int xsm_grant_setup(xsm_default_t action, struct domain *d1, struct domain *d2) { + XSM_ASSERT_ACTION(XSM_TARGET); return alternative_call(xsm_ops.grant_setup, d1, d2); } -static inline int xsm_grant_transfer(xsm_default_t def, struct domain *d1, +static inline int xsm_grant_transfer(xsm_default_t action, struct domain *d1, struct domain *d2) { + XSM_ASSERT_ACTION(XSM_HOOK); return alternative_call(xsm_ops.grant_transfer, d1, d2); } -static inline int xsm_grant_copy(xsm_default_t def, struct domain *d1, +static inline int xsm_grant_copy(xsm_default_t action, struct domain *d1, struct domain *d2) { + XSM_ASSERT_ACTION(XSM_HOOK); return alternative_call(xsm_ops.grant_copy, d1, d2); } -static inline int xsm_grant_query_size(xsm_default_t def, struct domain *d1, +static inline int xsm_grant_query_size(xsm_default_t action, struct domain *d1, struct domain *d2) { + XSM_ASSERT_ACTION(XSM_TARGET); return alternative_call(xsm_ops.grant_query_size, d1, d2); } @@ -174,87 +193,106 @@ static inline char *xsm_show_security_evtchn(struct domain *d, return alternative_call(xsm_ops.show_security_evtchn, d, chn); } -static inline int xsm_init_hardware_domain(xsm_default_t def, struct domain *d) +static inline int xsm_init_hardware_domain(xsm_default_t action, + struct domain *d) { + XSM_ASSERT_ACTION(XSM_HOOK); return alternative_call(xsm_ops.init_hardware_domain, d); } -static inline int xsm_get_pod_target(xsm_default_t def, struct domain *d) +static inline int xsm_get_pod_target(xsm_default_t action, struct domain *d) { + XSM_ASSERT_ACTION(XSM_PRIV); return alternative_call(xsm_ops.get_pod_target, d); } -static inline int xsm_set_pod_target(xsm_default_t def, struct domain *d) +static inline int xsm_set_pod_target(xsm_default_t action, struct domain *d) { + XSM_ASSERT_ACTION(XSM_PRIV); return alternative_call(xsm_ops.set_pod_target, d); } -static inline int xsm_memory_exchange(xsm_default_t def, struct domain *d) +static inline int xsm_memory_exchange(xsm_default_t action, struct domain *d) { + XSM_ASSERT_ACTION(XSM_TARGET); return alternative_call(xsm_ops.memory_exchange, d); } -static inline int xsm_memory_adjust_reservation(xsm_default_t def, +static inline int xsm_memory_adjust_reservation(xsm_default_t action, struct domain *d1, struct domain *d2) { + XSM_ASSERT_ACTION(XSM_TARGET); return alternative_call(xsm_ops.memory_adjust_reservation, d1, d2); } -static inline int xsm_memory_stat_reservation(xsm_default_t def, +static inline int xsm_memory_stat_reservation(xsm_default_t action, struct domain *d1, struct domain *d2) { + XSM_ASSERT_ACTION(XSM_TARGET); return alternative_call(xsm_ops.memory_stat_reservation, d1, d2); } -static inline int xsm_memory_pin_page(xsm_default_t def, struct domain *d1, +static inline int xsm_memory_pin_page(xsm_default_t action, struct domain *d1, struct domain *d2, struct page_info *page) { + XSM_ASSERT_ACTION(XSM_HOOK); return alternative_call(xsm_ops.memory_pin_page, d1, d2, page); } -static inline int xsm_add_to_physmap(xsm_default_t def, struct domain *d1, +static inline int xsm_add_to_physmap(xsm_default_t action, struct domain *d1, struct domain *d2) { + XSM_ASSERT_ACTION(XSM_TARGET); return alternative_call(xsm_ops.add_to_physmap, d1, d2); } -static inline int xsm_remove_from_physmap(xsm_default_t def, struct domain *d1, +static inline int xsm_remove_from_physmap(xsm_default_t action, + struct domain *d1, struct domain *d2) { + XSM_ASSERT_ACTION(XSM_TARGET); return alternative_call(xsm_ops.remove_from_physmap, d1, d2); } -static inline int xsm_map_gmfn_foreign(xsm_default_t def, struct domain *d, +static inline int xsm_map_gmfn_foreign(xsm_default_t action, struct domain *d, struct domain *t) + { + XSM_ASSERT_ACTION(XSM_TARGET); return alternative_call(xsm_ops.map_gmfn_foreign, d, t); } -static inline int xsm_claim_pages(xsm_default_t def, struct domain *d) +static inline int xsm_claim_pages(xsm_default_t action, struct domain *d) { + XSM_ASSERT_ACTION(XSM_PRIV); return alternative_call(xsm_ops.claim_pages, d); } -static inline int xsm_console_io(xsm_default_t def, struct domain *d, int cmd) +static inline int xsm_console_io(xsm_default_t action, struct domain *d, + int cmd) { + XSM_ASSERT_ACTION(XSM_OTHER); return alternative_call(xsm_ops.console_io, d, cmd); } -static inline int xsm_profile(xsm_default_t def, struct domain *d, int op) +static inline int xsm_profile(xsm_default_t action, struct domain *d, int op) { + XSM_ASSERT_ACTION(XSM_HOOK); return alternative_call(xsm_ops.profile, d, op); } -static inline int xsm_kexec(xsm_default_t def) +static inline int xsm_kexec(xsm_default_t action) { + XSM_ASSERT_ACTION(XSM_PRIV); return alternative_call(xsm_ops.kexec); } -static inline int xsm_schedop_shutdown(xsm_default_t def, struct domain *d1, +static inline int xsm_schedop_shutdown(xsm_default_t action, struct domain *d1, struct domain *d2) { + XSM_ASSERT_ACTION(XSM_DM_PRIV); return alternative_call(xsm_ops.schedop_shutdown, d1, d2); } @@ -263,144 +301,172 @@ static inline char *xsm_show_irq_sid(int irq) return alternative_call(xsm_ops.show_irq_sid, irq); } -static inline int xsm_map_domain_pirq(xsm_default_t def, struct domain *d) +static inline int xsm_map_domain_pirq(xsm_default_t action, struct domain *d) { + XSM_ASSERT_ACTION(XSM_DM_PRIV); return alternative_call(xsm_ops.map_domain_pirq, d); } -static inline int xsm_map_domain_irq(xsm_default_t def, struct domain *d, +static inline int xsm_map_domain_irq(xsm_default_t action, struct domain *d, int irq, void *data) { + XSM_ASSERT_ACTION(XSM_HOOK); return alternative_call(xsm_ops.map_domain_irq, d, irq, data); } -static inline int xsm_unmap_domain_pirq(xsm_default_t def, struct domain *d) +static inline int xsm_unmap_domain_pirq(xsm_default_t action, struct domain *d) { + XSM_ASSERT_ACTION(XSM_DM_PRIV); return alternative_call(xsm_ops.unmap_domain_pirq, d); } -static inline int xsm_unmap_domain_irq(xsm_default_t def, struct domain *d, +static inline int xsm_unmap_domain_irq(xsm_default_t action, struct domain *d, int irq, void *data) { + XSM_ASSERT_ACTION(XSM_HOOK); return alternative_call(xsm_ops.unmap_domain_irq, d, irq, data); } -static inline int xsm_bind_pt_irq(xsm_default_t def, struct domain *d, +static inline int xsm_bind_pt_irq(xsm_default_t action, struct domain *d, struct xen_domctl_bind_pt_irq *bind) { + XSM_ASSERT_ACTION(XSM_HOOK); return alternative_call(xsm_ops.bind_pt_irq, d, bind); } -static inline int xsm_unbind_pt_irq(xsm_default_t def, struct domain *d, +static inline int xsm_unbind_pt_irq(xsm_default_t action, struct domain *d, struct xen_domctl_bind_pt_irq *bind) { + XSM_ASSERT_ACTION(XSM_HOOK); return alternative_call(xsm_ops.unbind_pt_irq, d, bind); } -static inline int xsm_irq_permission(xsm_default_t def, struct domain *d, +static inline int xsm_irq_permission(xsm_default_t action, struct domain *d, int pirq, uint8_t allow) { + XSM_ASSERT_ACTION(XSM_HOOK); return alternative_call(xsm_ops.irq_permission, d, pirq, allow); } -static inline int xsm_iomem_permission(xsm_default_t def, struct domain *d, +static inline int xsm_iomem_permission(xsm_default_t action, struct domain *d, uint64_t s, uint64_t e, uint8_t allow) { + XSM_ASSERT_ACTION(XSM_HOOK); return alternative_call(xsm_ops.iomem_permission, d, s, e, allow); } -static inline int xsm_iomem_mapping(xsm_default_t def, struct domain *d, +static inline int xsm_iomem_mapping(xsm_default_t action, struct domain *d, uint64_t s, uint64_t e, uint8_t allow) { + XSM_ASSERT_ACTION(XSM_HOOK); return alternative_call(xsm_ops.iomem_mapping, d, s, e, allow); } -static inline int xsm_pci_config_permission(xsm_default_t def, struct domain *d, +static inline int xsm_pci_config_permission(xsm_default_t action, + struct domain *d, uint32_t machine_bdf, uint16_t start, uint16_t end, uint8_t access) { - return alternative_call(xsm_ops.pci_config_permission, d, machine_bdf, start, end, access); + XSM_ASSERT_ACTION(XSM_HOOK); + return alternative_call(xsm_ops.pci_config_permission, d, machine_bdf, + start, end, access); } #if defined(CONFIG_HAS_PASSTHROUGH) && defined(CONFIG_HAS_PCI) -static inline int xsm_get_device_group(xsm_default_t def, uint32_t machine_bdf) +static inline int xsm_get_device_group(xsm_default_t action, + uint32_t machine_bdf) { + XSM_ASSERT_ACTION(XSM_HOOK); return alternative_call(xsm_ops.get_device_group, machine_bdf); } -static inline int xsm_assign_device(xsm_default_t def, struct domain *d, +static inline int xsm_assign_device(xsm_default_t action, struct domain *d, uint32_t machine_bdf) { + XSM_ASSERT_ACTION(XSM_HOOK); return alternative_call(xsm_ops.assign_device, d, machine_bdf); } -static inline int xsm_deassign_device(xsm_default_t def, struct domain *d, +static inline int xsm_deassign_device(xsm_default_t action, struct domain *d, uint32_t machine_bdf) { + XSM_ASSERT_ACTION(XSM_HOOK); return alternative_call(xsm_ops.deassign_device, d, machine_bdf); } #endif /* HAS_PASSTHROUGH && HAS_PCI) */ #if defined(CONFIG_HAS_PASSTHROUGH) && defined(CONFIG_HAS_DEVICE_TREE) -static inline int xsm_assign_dtdevice(xsm_default_t def, struct domain *d, +static inline int xsm_assign_dtdevice(xsm_default_t action, struct domain *d, const char *dtpath) { + XSM_ASSERT_ACTION(XSM_HOOK); return alternative_call(xsm_ops.assign_dtdevice, d, dtpath); } -static inline int xsm_deassign_dtdevice(xsm_default_t def, struct domain *d, +static inline int xsm_deassign_dtdevice(xsm_default_t action, struct domain *d, const char *dtpath) { + XSM_ASSERT_ACTION(XSM_HOOK); return alternative_call(xsm_ops.deassign_dtdevice, d, dtpath); } #endif /* HAS_PASSTHROUGH && HAS_DEVICE_TREE */ -static inline int xsm_resource_plug_pci(xsm_default_t def, uint32_t machine_bdf) +static inline int xsm_resource_plug_pci(xsm_default_t action, + uint32_t machine_bdf) { + XSM_ASSERT_ACTION(XSM_PRIV); return alternative_call(xsm_ops.resource_plug_pci, machine_bdf); } -static inline int xsm_resource_unplug_pci(xsm_default_t def, +static inline int xsm_resource_unplug_pci(xsm_default_t action, uint32_t machine_bdf) { + XSM_ASSERT_ACTION(XSM_PRIV); return alternative_call(xsm_ops.resource_unplug_pci, machine_bdf); } -static inline int xsm_resource_plug_core(xsm_default_t def) +static inline int xsm_resource_plug_core(xsm_default_t action) { + XSM_ASSERT_ACTION(XSM_HOOK); return alternative_call(xsm_ops.resource_plug_core); } -static inline int xsm_resource_unplug_core(xsm_default_t def) +static inline int xsm_resource_unplug_core(xsm_default_t action) { + XSM_ASSERT_ACTION(XSM_HOOK); return alternative_call(xsm_ops.resource_unplug_core); } -static inline int xsm_resource_setup_pci(xsm_default_t def, +static inline int xsm_resource_setup_pci(xsm_default_t action, uint32_t machine_bdf) { + XSM_ASSERT_ACTION(XSM_PRIV); return alternative_call(xsm_ops.resource_setup_pci, machine_bdf); } -static inline int xsm_resource_setup_gsi(xsm_default_t def, int gsi) +static inline int xsm_resource_setup_gsi(xsm_default_t action, int gsi) { + XSM_ASSERT_ACTION(XSM_PRIV); return alternative_call(xsm_ops.resource_setup_gsi, gsi); } -static inline int xsm_resource_setup_misc(xsm_default_t def) +static inline int xsm_resource_setup_misc(xsm_default_t action) { + XSM_ASSERT_ACTION(XSM_PRIV); return alternative_call(xsm_ops.resource_setup_misc); } -static inline int xsm_page_offline(xsm_default_t def, uint32_t cmd) +static inline int xsm_page_offline(xsm_default_t action, uint32_t cmd) { + XSM_ASSERT_ACTION(XSM_HOOK); return alternative_call(xsm_ops.page_offline, cmd); } -static inline int xsm_hypfs_op(xsm_default_t def) +static inline int xsm_hypfs_op(xsm_default_t action) { + XSM_ASSERT_ACTION(XSM_PRIV); return alternative_call(xsm_ops.hypfs_op); } @@ -416,161 +482,192 @@ static inline int xsm_do_compat_op(XEN_GUEST_HANDLE_PARAM(void) op) } #endif -static inline int xsm_hvm_param(xsm_default_t def, struct domain *d, +static inline int xsm_hvm_param(xsm_default_t action, struct domain *d, unsigned long op) { + XSM_ASSERT_ACTION(XSM_TARGET); return alternative_call(xsm_ops.hvm_param, d, op); } -static inline int xsm_hvm_control(xsm_default_t def, struct domain *d, +static inline int xsm_hvm_control(xsm_default_t action, struct domain *d, unsigned long op) { + XSM_ASSERT_ACTION(XSM_DM_PRIV); return alternative_call(xsm_ops.hvm_control, d, op); } -static inline int xsm_hvm_param_altp2mhvm(xsm_default_t def, struct domain *d) +static inline int xsm_hvm_param_altp2mhvm(xsm_default_t action, + struct domain *d) { + XSM_ASSERT_ACTION(XSM_PRIV); return alternative_call(xsm_ops.hvm_param_altp2mhvm, d); } -static inline int xsm_hvm_altp2mhvm_op(xsm_default_t def, struct domain *d, +static inline int xsm_hvm_altp2mhvm_op(xsm_default_t action, struct domain *d, uint64_t mode, uint32_t op) { + XSM_ASSERT_ACTION(XSM_OTHER); return alternative_call(xsm_ops.hvm_altp2mhvm_op, d, mode, op); } -static inline int xsm_get_vnumainfo(xsm_default_t def, struct domain *d) +static inline int xsm_get_vnumainfo(xsm_default_t action, struct domain *d) { + XSM_ASSERT_ACTION(XSM_TARGET); return alternative_call(xsm_ops.get_vnumainfo, d); } -static inline int xsm_vm_event_control(xsm_default_t def, struct domain *d, +static inline int xsm_vm_event_control(xsm_default_t action, struct domain *d, int mode, int op) { + XSM_ASSERT_ACTION(XSM_PRIV); return alternative_call(xsm_ops.vm_event_control, d, mode, op); } #ifdef CONFIG_MEM_ACCESS -static inline int xsm_mem_access(xsm_default_t def, struct domain *d) +static inline int xsm_mem_access(xsm_default_t action, struct domain *d) { + XSM_ASSERT_ACTION(XSM_DM_PRIV); return alternative_call(xsm_ops.mem_access, d); } #endif #ifdef CONFIG_MEM_PAGING -static inline int xsm_mem_paging(xsm_default_t def, struct domain *d) +static inline int xsm_mem_paging(xsm_default_t action, struct domain *d) { + XSM_ASSERT_ACTION(XSM_DM_PRIV); return alternative_call(xsm_ops.mem_paging, d); } #endif #ifdef CONFIG_MEM_SHARING -static inline int xsm_mem_sharing(xsm_default_t def, struct domain *d) +static inline int xsm_mem_sharing(xsm_default_t action, struct domain *d) { + XSM_ASSERT_ACTION(XSM_DM_PRIV); return alternative_call(xsm_ops.mem_sharing, d); } #endif -static inline int xsm_platform_op(xsm_default_t def, uint32_t op) +static inline int xsm_platform_op(xsm_default_t action, uint32_t op) { + XSM_ASSERT_ACTION(XSM_PRIV); return alternative_call(xsm_ops.platform_op, op); } #ifdef CONFIG_X86 -static inline int xsm_do_mca(xsm_default_t def) +static inline int xsm_do_mca(xsm_default_t action) { + XSM_ASSERT_ACTION(XSM_PRIV); return alternative_call(xsm_ops.do_mca); } -static inline int xsm_shadow_control(xsm_default_t def, struct domain *d, +static inline int xsm_shadow_control(xsm_default_t action, struct domain *d, uint32_t op) { + XSM_ASSERT_ACTION(XSM_HOOK); return alternative_call(xsm_ops.shadow_control, d, op); } -static inline int xsm_mem_sharing_op(xsm_default_t def, struct domain *d, +static inline int xsm_mem_sharing_op(xsm_default_t action, struct domain *d, struct domain *cd, int op) { + XSM_ASSERT_ACTION(XSM_DM_PRIV); return alternative_call(xsm_ops.mem_sharing_op, d, cd, op); } -static inline int xsm_apic(xsm_default_t def, struct domain *d, int cmd) +static inline int xsm_apic(xsm_default_t action, struct domain *d, int cmd) { + XSM_ASSERT_ACTION(XSM_PRIV); return alternative_call(xsm_ops.apic, d, cmd); } -static inline int xsm_memtype(xsm_default_t def, uint32_t access) +#if 0 +/* Could not find any usages */ +static inline int xsm_memtype(xsm_default_t action, uint32_t access) { return alternative_call(xsm_ops.memtype, access); } +#endif -static inline int xsm_machine_memory_map(xsm_default_t def) +static inline int xsm_machine_memory_map(xsm_default_t action) { + XSM_ASSERT_ACTION(XSM_PRIV); return alternative_call(xsm_ops.machine_memory_map); } -static inline int xsm_domain_memory_map(xsm_default_t def, struct domain *d) +static inline int xsm_domain_memory_map(xsm_default_t action, struct domain *d) { + XSM_ASSERT_ACTION(XSM_TARGET); return alternative_call(xsm_ops.domain_memory_map, d); } -static inline int xsm_mmu_update(xsm_default_t def, struct domain *d, +static inline int xsm_mmu_update(xsm_default_t action, struct domain *d, struct domain *t, struct domain *f, uint32_t flags) { + XSM_ASSERT_ACTION(XSM_TARGET); return alternative_call(xsm_ops.mmu_update, d, t, f, flags); } -static inline int xsm_mmuext_op(xsm_default_t def, struct domain *d, +static inline int xsm_mmuext_op(xsm_default_t action, struct domain *d, struct domain *f) { + XSM_ASSERT_ACTION(XSM_TARGET); return alternative_call(xsm_ops.mmuext_op, d, f); } -static inline int xsm_update_va_mapping(xsm_default_t def, struct domain *d, +static inline int xsm_update_va_mapping(xsm_default_t action, struct domain *d, struct domain *f, l1_pgentry_t pte) { + XSM_ASSERT_ACTION(XSM_TARGET); return xsm_ops.update_va_mapping(d, f, pte); } -static inline int xsm_priv_mapping(xsm_default_t def, struct domain *d, +static inline int xsm_priv_mapping(xsm_default_t action, struct domain *d, struct domain *t) { + XSM_ASSERT_ACTION(XSM_TARGET); return alternative_call(xsm_ops.priv_mapping, d, t); } -static inline int xsm_ioport_permission(xsm_default_t def, struct domain *d, +static inline int xsm_ioport_permission(xsm_default_t action, struct domain *d, uint32_t s, uint32_t e, uint8_t allow) { + XSM_ASSERT_ACTION(XSM_HOOK); return alternative_call(xsm_ops.ioport_permission, d, s, e, allow); } -static inline int xsm_ioport_mapping(xsm_default_t def, struct domain *d, +static inline int xsm_ioport_mapping(xsm_default_t action, struct domain *d, uint32_t s, uint32_t e, uint8_t allow) { + XSM_ASSERT_ACTION(XSM_HOOK); return alternative_call(xsm_ops.ioport_mapping, d, s, e, allow); } -static inline int xsm_pmu_op(xsm_default_t def, struct domain *d, +static inline int xsm_pmu_op(xsm_default_t action, struct domain *d, unsigned int op) { + XSM_ASSERT_ACTION(XSM_OTHER); return alternative_call(xsm_ops.pmu_op, d, op); } #endif /* CONFIG_X86 */ -static inline int xsm_dm_op(xsm_default_t def, struct domain *d) +static inline int xsm_dm_op(xsm_default_t action, struct domain *d) { + XSM_ASSERT_ACTION(XSM_DM_PRIV); return alternative_call(xsm_ops.dm_op, d); } -static inline int xsm_xen_version(xsm_default_t def, uint32_t op) +static inline int xsm_xen_version(xsm_default_t action, uint32_t op) { + XSM_ASSERT_ACTION(XSM_OTHER); return alternative_call(xsm_ops.xen_version, op); } -static inline int xsm_domain_resource_map(xsm_default_t def, struct domain *d) +static inline int xsm_domain_resource_map(xsm_default_t action, + struct domain *d) { + XSM_ASSERT_ACTION(XSM_DM_PRIV); return alternative_call(xsm_ops.domain_resource_map, d); } @@ -598,10 +695,4 @@ static inline int xsm_argo_send(const struct domain *d, const struct domain *t) #endif /* CONFIG_ARGO */ -#else /* CONFIG_XSM_CONFIGURABLE */ - -#include - -#endif /* CONFIG_XSM_CONFIGURABLE */ - #endif /* __XSM_H */ diff --git a/xen/xsm/Makefile b/xen/xsm/Makefile index 09b9311b1d..121a0eda7d 100644 --- a/xen/xsm/Makefile +++ b/xen/xsm/Makefile @@ -1,6 +1,6 @@ obj-y += xsm_core.o +obj-y += dummy.o obj-$(CONFIG_XSM_CONFIGURABLE) += xsm_policy.o -obj-$(CONFIG_XSM_CONFIGURABLE) += dummy.o obj-$(CONFIG_XSM_SILO) += silo.o obj-$(CONFIG_XSM_FLASK) += flask/ diff --git a/xen/xsm/dummy.c b/xen/xsm/dummy.c index b848580eaa..e18afe0673 100644 --- a/xen/xsm/dummy.c +++ b/xen/xsm/dummy.c @@ -10,7 +10,7 @@ * as published by the Free Software Foundation. */ -#include +#include "dummy.h" #define set_to_dummy_if_null(ops, function) \ do { \ diff --git a/xen/xsm/dummy.h b/xen/xsm/dummy.h new file mode 100644 index 0000000000..b9a7e8c40f --- /dev/null +++ b/xen/xsm/dummy.h @@ -0,0 +1,739 @@ +/* + * Default XSM hooks - IS_PRIV and IS_PRIV_FOR checks + * + * Author: Daniel De Graaf + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2, + * as published by the Free Software Foundation. + * + * + * Dummy XSM hooks implementing the default access check. Each hook should + * have as its first line XSM_DEFAULT_ACTION declaring the privilege level + * required for this access. + */ + +#ifndef __XSM_DUMMY_H__ +#define __XSM_DUMMY_H__ + +#include +#include +#include + +#define XSM_DEFAULT_ACTION(def) xsm_default_t action = def; (void)action + +static always_inline int xsm_default_action( + xsm_default_t action, struct domain *src, struct domain *target) +{ + switch ( action ) { + case XSM_HOOK: + return 0; + case XSM_TARGET: + if ( evaluate_nospec(src == target) ) + { + return 0; + case XSM_XS_PRIV: + if ( evaluate_nospec(is_xenstore_domain(src)) ) + return 0; + } + /* fall through */ + case XSM_DM_PRIV: + if ( target && evaluate_nospec(src->target == target) ) + return 0; + /* fall through */ + case XSM_PRIV: + if ( is_control_domain(src) ) + return 0; + return -EPERM; + default: + XSM_LINKER_BUG_ON(1); + return -EPERM; + } +} + +static inline void xsm_security_domaininfo(struct domain *d, + struct xen_domctl_getdomaininfo *info) +{ + return; +} + +static inline int xsm_domain_create(struct domain *d, uint32_t ssidref) +{ + XSM_DEFAULT_ACTION(XSM_HOOK); + return xsm_default_action(action, current->domain, d); +} + +static inline int xsm_getdomaininfo(struct domain *d) +{ + XSM_DEFAULT_ACTION(XSM_HOOK); + return xsm_default_action(action, current->domain, d); +} + +static inline int xsm_domctl_scheduler_op(struct domain *d, int cmd) +{ + XSM_DEFAULT_ACTION(XSM_HOOK); + return xsm_default_action(action, current->domain, d); +} + +static inline int xsm_sysctl_scheduler_op(int cmd) +{ + XSM_DEFAULT_ACTION(XSM_HOOK); + return xsm_default_action(action, current->domain, NULL); +} + +static inline int xsm_set_target(struct domain *d, struct domain *e) +{ + XSM_DEFAULT_ACTION(XSM_HOOK); + return xsm_default_action(action, current->domain, NULL); +} + +static inline int xsm_domctl(struct domain *d, int cmd) +{ + XSM_DEFAULT_ACTION(XSM_OTHER); + switch ( cmd ) + { + case XEN_DOMCTL_ioport_mapping: + case XEN_DOMCTL_memory_mapping: + case XEN_DOMCTL_bind_pt_irq: + case XEN_DOMCTL_unbind_pt_irq: + return xsm_default_action(XSM_DM_PRIV, current->domain, d); + case XEN_DOMCTL_getdomaininfo: + return xsm_default_action(XSM_XS_PRIV, current->domain, d); + default: + return xsm_default_action(XSM_PRIV, current->domain, d); + } +} + +static inline int xsm_sysctl(int cmd) +{ + XSM_DEFAULT_ACTION(XSM_PRIV); + return xsm_default_action(action, current->domain, NULL); +} + +static inline int xsm_readconsole(uint32_t clear) +{ + XSM_DEFAULT_ACTION(XSM_HOOK); + return xsm_default_action(action, current->domain, NULL); +} + +static inline int xsm_alloc_security_domain(struct domain *d) +{ + return 0; +} + +static inline void xsm_free_security_domain(struct domain *d) +{ + return; +} + +static inline int xsm_grant_mapref(struct domain *d1, struct domain *d2, + uint32_t flags) +{ + XSM_DEFAULT_ACTION(XSM_HOOK); + return xsm_default_action(action, d1, d2); +} + +static inline int xsm_grant_unmapref(struct domain *d1, struct domain *d2) +{ + XSM_DEFAULT_ACTION(XSM_HOOK); + return xsm_default_action(action, d1, d2); +} + +static inline int xsm_grant_setup(struct domain *d1, struct domain *d2) +{ + XSM_DEFAULT_ACTION(XSM_TARGET); + return xsm_default_action(action, d1, d2); +} + +static inline int xsm_grant_transfer(struct domain *d1, struct domain *d2) +{ + XSM_DEFAULT_ACTION(XSM_HOOK); + return xsm_default_action(action, d1, d2); +} + +static inline int xsm_grant_copy(struct domain *d1, struct domain *d2) +{ + XSM_DEFAULT_ACTION(XSM_HOOK); + return xsm_default_action(action, d1, d2); +} + +static inline int xsm_grant_query_size(struct domain *d1, struct domain *d2) +{ + XSM_DEFAULT_ACTION(XSM_TARGET); + return xsm_default_action(action, d1, d2); +} + +static inline int xsm_memory_exchange(struct domain *d) +{ + XSM_DEFAULT_ACTION(XSM_TARGET); + return xsm_default_action(action, current->domain, d); +} + +static inline int xsm_memory_adjust_reservation(struct domain *d1, + struct domain *d2) +{ + XSM_DEFAULT_ACTION(XSM_TARGET); + return xsm_default_action(action, d1, d2); +} + +static inline int xsm_memory_stat_reservation(struct domain *d1, + struct domain *d2) +{ + XSM_DEFAULT_ACTION(XSM_TARGET); + return xsm_default_action(action, d1, d2); +} + +static inline int xsm_console_io(struct domain *d, int cmd) +{ + XSM_DEFAULT_ACTION(XSM_OTHER); + if ( d->is_console ) + return xsm_default_action(XSM_HOOK, d, NULL); +#ifdef CONFIG_VERBOSE_DEBUG + if ( cmd == CONSOLEIO_write ) + return xsm_default_action(XSM_HOOK, d, NULL); +#endif + return xsm_default_action(XSM_PRIV, d, NULL); +} + +static inline int xsm_profile(struct domain *d, int op) +{ + XSM_DEFAULT_ACTION(XSM_HOOK); + return xsm_default_action(action, d, NULL); +} + +static inline int xsm_kexec(void) +{ + XSM_DEFAULT_ACTION(XSM_PRIV); + return xsm_default_action(action, current->domain, NULL); +} + +static inline int xsm_schedop_shutdown(struct domain *d1, struct domain *d2) +{ + XSM_DEFAULT_ACTION(XSM_DM_PRIV); + return xsm_default_action(action, d1, d2); +} + +static inline int xsm_memory_pin_page(struct domain *d1, struct domain *d2, + struct page_info *page) +{ + XSM_DEFAULT_ACTION(XSM_HOOK); + return xsm_default_action(action, d1, d2); +} + +static inline int xsm_claim_pages(struct domain *d) +{ + XSM_DEFAULT_ACTION(XSM_PRIV); + return xsm_default_action(action, current->domain, d); +} + +static inline int xsm_evtchn_unbound(struct domain *d, struct evtchn *chn, + domid_t id2) +{ + XSM_DEFAULT_ACTION(XSM_TARGET); + return xsm_default_action(action, current->domain, d); +} + +static inline int xsm_evtchn_interdomain(struct domain *d1, + struct evtchn *chan1, + struct domain *d2, + struct evtchn *chan2) +{ + XSM_DEFAULT_ACTION(XSM_HOOK); + return xsm_default_action(action, d1, d2); +} + +static inline void xsm_evtchn_close_post(struct evtchn *chn) +{ + return; +} + +static inline int xsm_evtchn_send(struct domain *d, struct evtchn *chn) +{ + XSM_DEFAULT_ACTION(XSM_HOOK); + return xsm_default_action(action, d, NULL); +} + +static inline int xsm_evtchn_status(struct domain *d, struct evtchn *chn) +{ + XSM_DEFAULT_ACTION(XSM_TARGET); + return xsm_default_action(action, current->domain, d); +} + +static inline int xsm_evtchn_reset(struct domain *d1, struct domain *d2) +{ + XSM_DEFAULT_ACTION(XSM_TARGET); + return xsm_default_action(action, d1, d2); +} + +static inline int xsm_alloc_security_evtchns(struct evtchn chn[], + unsigned int nr) +{ + return 0; +} + +static inline void xsm_free_security_evtchns(struct evtchn chn[], + unsigned int nr) +{ + return; +} + +static inline char *xsm_show_security_evtchn(struct domain *d, + const struct evtchn *chn) +{ + return NULL; +} + +static inline int xsm_init_hardware_domain(struct domain *d) +{ + XSM_DEFAULT_ACTION(XSM_HOOK); + return xsm_default_action(action, current->domain, d); +} + +static inline int xsm_get_pod_target(struct domain *d) +{ + XSM_DEFAULT_ACTION(XSM_PRIV); + return xsm_default_action(action, current->domain, d); +} + +static inline int xsm_set_pod_target(struct domain *d) +{ + XSM_DEFAULT_ACTION(XSM_PRIV); + return xsm_default_action(action, current->domain, d); +} + +static inline int xsm_get_vnumainfo(struct domain *d) +{ + XSM_DEFAULT_ACTION(XSM_TARGET); + return xsm_default_action(action, current->domain, d); +} + +#if defined(CONFIG_HAS_PASSTHROUGH) && defined(CONFIG_HAS_PCI) +static inline int xsm_get_device_group(uint32_t machine_bdf) +{ + XSM_DEFAULT_ACTION(XSM_HOOK); + return xsm_default_action(action, current->domain, NULL); +} + +static inline int xsm_assign_device(struct domain *d, uint32_t machine_bdf) +{ + XSM_DEFAULT_ACTION(XSM_HOOK); + return xsm_default_action(action, current->domain, d); +} + +static inline int xsm_deassign_device(struct domain *d, uint32_t machine_bdf) +{ + XSM_DEFAULT_ACTION(XSM_HOOK); + return xsm_default_action(action, current->domain, d); +} + +#endif /* HAS_PASSTHROUGH && HAS_PCI */ + +#if defined(CONFIG_HAS_PASSTHROUGH) && defined(CONFIG_HAS_DEVICE_TREE) +static inline int xsm_assign_dtdevice(struct domain *d, const char *dtpath) +{ + XSM_DEFAULT_ACTION(XSM_HOOK); + return xsm_default_action(action, current->domain, d); +} + +static inline int xsm_deassign_dtdevice(struct domain *d, const char *dtpath) +{ + XSM_DEFAULT_ACTION(XSM_HOOK); + return xsm_default_action(action, current->domain, d); +} + +#endif /* HAS_PASSTHROUGH && HAS_DEVICE_TREE */ + +static inline int xsm_resource_plug_core(void) +{ + XSM_DEFAULT_ACTION(XSM_HOOK); + return xsm_default_action(action, current->domain, NULL); +} + +static inline int xsm_resource_unplug_core(void) +{ + XSM_DEFAULT_ACTION(XSM_HOOK); + return xsm_default_action(action, current->domain, NULL); +} + +static inline int xsm_resource_plug_pci(uint32_t machine_bdf) +{ + XSM_DEFAULT_ACTION(XSM_PRIV); + return xsm_default_action(action, current->domain, NULL); +} + +static inline int xsm_resource_unplug_pci(uint32_t machine_bdf) +{ + XSM_DEFAULT_ACTION(XSM_PRIV); + return xsm_default_action(action, current->domain, NULL); +} + +static inline int xsm_resource_setup_pci(uint32_t machine_bdf) +{ + XSM_DEFAULT_ACTION(XSM_PRIV); + return xsm_default_action(action, current->domain, NULL); +} + +static inline int xsm_resource_setup_gsi(int gsi) +{ + XSM_DEFAULT_ACTION(XSM_PRIV); + return xsm_default_action(action, current->domain, NULL); +} + +static inline int xsm_resource_setup_misc(void) +{ + XSM_DEFAULT_ACTION(XSM_PRIV); + return xsm_default_action(action, current->domain, NULL); +} + +static inline int xsm_page_offline(uint32_t cmd) +{ + XSM_DEFAULT_ACTION(XSM_HOOK); + return xsm_default_action(action, current->domain, NULL); +} + +static inline int xsm_hypfs_op(void) +{ + XSM_DEFAULT_ACTION(XSM_PRIV); + return xsm_default_action(action, current->domain, NULL); +} + +static inline long xsm_do_xsm_op(XEN_GUEST_HANDLE_PARAM(void) op) +{ + return -ENOSYS; +} + +#ifdef CONFIG_COMPAT +static inline int xsm_do_compat_op(XEN_GUEST_HANDLE_PARAM(void) op) +{ + return -ENOSYS; +} +#endif + +static inline char *xsm_show_irq_sid(int irq) +{ + return NULL; +} + +static inline int xsm_map_domain_pirq(struct domain *d) +{ + XSM_DEFAULT_ACTION(XSM_DM_PRIV); + return xsm_default_action(action, current->domain, d); +} + +static inline int xsm_map_domain_irq(struct domain *d, int irq, + const void *data) +{ + XSM_DEFAULT_ACTION(XSM_HOOK); + return xsm_default_action(action, current->domain, d); +} + +static inline int xsm_unmap_domain_pirq(struct domain *d) +{ + XSM_DEFAULT_ACTION(XSM_DM_PRIV); + return xsm_default_action(action, current->domain, d); +} + +static inline int xsm_bind_pt_irq(struct domain *d, + struct xen_domctl_bind_pt_irq *bind) +{ + XSM_DEFAULT_ACTION(XSM_HOOK); + return xsm_default_action(action, current->domain, d); +} + +static inline int xsm_unbind_pt_irq(struct domain *d, + struct xen_domctl_bind_pt_irq *bind) +{ + XSM_DEFAULT_ACTION(XSM_HOOK); + return xsm_default_action(action, current->domain, d); +} + +static inline int xsm_unmap_domain_irq(struct domain *d, int irq, + const void *data) +{ + XSM_DEFAULT_ACTION(XSM_HOOK); + return xsm_default_action(action, current->domain, d); +} + +static inline int xsm_irq_permission(struct domain *d, int pirq, uint8_t allow) +{ + XSM_DEFAULT_ACTION(XSM_HOOK); + return xsm_default_action(action, current->domain, d); +} + +static inline int xsm_iomem_permission(struct domain *d, uint64_t s, uint64_t e, + uint8_t allow) +{ + XSM_DEFAULT_ACTION(XSM_HOOK); + return xsm_default_action(action, current->domain, d); +} + +static inline int xsm_iomem_mapping(struct domain *d, uint64_t s, uint64_t e, + uint8_t allow) +{ + XSM_DEFAULT_ACTION(XSM_HOOK); + return xsm_default_action(action, current->domain, d); +} + +static inline int xsm_pci_config_permission(struct domain *d, + uint32_t machine_bdf, + uint16_t start, uint16_t end, + uint8_t access) +{ + XSM_DEFAULT_ACTION(XSM_HOOK); + return xsm_default_action(action, current->domain, d); +} + +static inline int xsm_add_to_physmap(struct domain *d1, struct domain *d2) +{ + XSM_DEFAULT_ACTION(XSM_TARGET); + return xsm_default_action(action, d1, d2); +} + +static inline int xsm_remove_from_physmap(struct domain *d1, struct domain *d2) +{ + XSM_DEFAULT_ACTION(XSM_TARGET); + return xsm_default_action(action, d1, d2); +} + +static inline int xsm_map_gmfn_foreign(struct domain *d, struct domain *t) +{ + XSM_DEFAULT_ACTION(XSM_TARGET); + return xsm_default_action(action, d, t); +} + +static inline int xsm_hvm_param(struct domain *d, unsigned long op) +{ + XSM_DEFAULT_ACTION(XSM_TARGET); + return xsm_default_action(action, current->domain, d); +} + +static inline int xsm_hvm_control(struct domain *d, unsigned long op) +{ + XSM_DEFAULT_ACTION(XSM_DM_PRIV); + return xsm_default_action(action, current->domain, d); +} + +static inline int xsm_hvm_param_altp2mhvm(struct domain *d) +{ + XSM_DEFAULT_ACTION(XSM_PRIV); + return xsm_default_action(action, current->domain, d); +} + +static inline int xsm_hvm_altp2mhvm_op(struct domain *d, uint64_t mode, + uint32_t op) +{ + XSM_DEFAULT_ACTION(XSM_OTHER); + + switch ( mode ) + { + case XEN_ALTP2M_mixed: + return xsm_default_action(XSM_TARGET, current->domain, d); + case XEN_ALTP2M_external: + return xsm_default_action(XSM_DM_PRIV, current->domain, d); + case XEN_ALTP2M_limited: + if ( HVMOP_altp2m_vcpu_enable_notify == op ) + return xsm_default_action(XSM_TARGET, current->domain, d); + return xsm_default_action(XSM_DM_PRIV, current->domain, d); + default: + return -EPERM; + } +} + +static inline int xsm_vm_event_control(struct domain *d, int mode, int op) +{ + XSM_DEFAULT_ACTION(XSM_PRIV); + return xsm_default_action(action, current->domain, d); +} + +#ifdef CONFIG_MEM_ACCESS +static inline int xsm_mem_access(struct domain *d) +{ + XSM_DEFAULT_ACTION(XSM_DM_PRIV); + return xsm_default_action(action, current->domain, d); +} +#endif + +#ifdef CONFIG_MEM_PAGING +static inline int xsm_mem_paging(struct domain *d) +{ + XSM_DEFAULT_ACTION(XSM_DM_PRIV); + return xsm_default_action(action, current->domain, d); +} +#endif + +#ifdef CONFIG_MEM_SHARING +static inline int xsm_mem_sharing(struct domain *d) +{ + XSM_DEFAULT_ACTION(XSM_DM_PRIV); + return xsm_default_action(action, current->domain, d); +} +#endif + +static inline int xsm_platform_op(uint32_t op) +{ + XSM_DEFAULT_ACTION(XSM_PRIV); + return xsm_default_action(action, current->domain, NULL); +} + +#ifdef CONFIG_X86 +static inline int xsm_do_mca(void) +{ + XSM_DEFAULT_ACTION(XSM_PRIV); + return xsm_default_action(action, current->domain, NULL); +} + +static inline int xsm_shadow_control(struct domain *d, uint32_t op) +{ + XSM_DEFAULT_ACTION(XSM_HOOK); + return xsm_default_action(action, current->domain, d); +} + +static inline int xsm_mem_sharing_op(struct domain *d, struct domain *cd, + int op) +{ + XSM_DEFAULT_ACTION(XSM_DM_PRIV); + return xsm_default_action(action, current->domain, cd); +} + +static inline int xsm_apic(struct domain *d, int cmd) +{ + XSM_DEFAULT_ACTION(XSM_PRIV); + return xsm_default_action(action, d, NULL); +} + +static inline int xsm_machine_memory_map(void) +{ + XSM_DEFAULT_ACTION(XSM_PRIV); + return xsm_default_action(action, current->domain, NULL); +} + +static inline int xsm_domain_memory_map(struct domain *d) +{ + XSM_DEFAULT_ACTION(XSM_TARGET); + return xsm_default_action(action, current->domain, d); +} + +static inline int xsm_mmu_update(struct domain *d, struct domain *t, + struct domain *f, uint32_t flags) +{ + int rc = 0; + XSM_DEFAULT_ACTION(XSM_TARGET); + if ( f != dom_io ) + rc = xsm_default_action(action, d, f); + if ( evaluate_nospec(t) && !rc ) + rc = xsm_default_action(action, d, t); + return rc; +} + +static inline int xsm_mmuext_op(struct domain *d, struct domain *f) +{ + XSM_DEFAULT_ACTION(XSM_TARGET); + return xsm_default_action(action, d, f); +} + +static inline int xsm_update_va_mapping(struct domain *d, struct domain *f, + l1_pgentry_t pte) +{ + XSM_DEFAULT_ACTION(XSM_TARGET); + return xsm_default_action(action, d, f); +} + +static inline int xsm_priv_mapping(struct domain *d, struct domain *t) +{ + XSM_DEFAULT_ACTION(XSM_TARGET); + return xsm_default_action(action, d, t); +} + +static inline int xsm_ioport_permission(struct domain *d, uint32_t s, + uint32_t e, uint8_t allow) +{ + XSM_DEFAULT_ACTION(XSM_HOOK); + return xsm_default_action(action, current->domain, d); +} + +static inline int xsm_ioport_mapping(struct domain *d, uint32_t s, uint32_t e, + uint8_t allow) +{ + XSM_DEFAULT_ACTION(XSM_HOOK); + return xsm_default_action(action, current->domain, d); +} + +static inline int xsm_pmu_op(struct domain *d, unsigned int op) +{ + XSM_DEFAULT_ACTION(XSM_OTHER); + switch ( op ) + { + case XENPMU_init: + case XENPMU_finish: + case XENPMU_lvtpc_set: + case XENPMU_flush: + return xsm_default_action(XSM_HOOK, d, current->domain); + default: + return xsm_default_action(XSM_PRIV, d, current->domain); + } +} + +#endif /* CONFIG_X86 */ + +static inline int xsm_dm_op(struct domain *d) +{ + XSM_DEFAULT_ACTION(XSM_DM_PRIV); + return xsm_default_action(action, current->domain, d); +} + +#ifdef CONFIG_ARGO +static inline int xsm_argo_enable(const struct domain *d) +{ + return 0; +} + +static inline int xsm_argo_register_single_source(const struct domain *d, + const struct domain *t) +{ + return 0; +} + +static inline int xsm_argo_register_any_source(const struct domain *d) +{ + return 0; +} + +static inline int xsm_argo_send(const struct domain *d, const struct domain *t) +{ + return 0; +} + +#endif /* CONFIG_ARGO */ + +#include +static inline int xsm_xen_version(uint32_t op) +{ + XSM_DEFAULT_ACTION(XSM_OTHER); + switch ( op ) + { + case XENVER_version: + case XENVER_platform_parameters: + case XENVER_get_features: + /* These sub-ops ignore the permission checks and return data. */ + block_speculation(); + return 0; + case XENVER_extraversion: + case XENVER_compile_info: + case XENVER_capabilities: + case XENVER_changeset: + case XENVER_pagesize: + case XENVER_guest_handle: + /* These MUST always be accessible to any guest by default. */ + return xsm_default_action(XSM_HOOK, current->domain, NULL); + default: + return xsm_default_action(XSM_PRIV, current->domain, NULL); + } +} + +static inline int xsm_domain_resource_map(struct domain *d) +{ + XSM_DEFAULT_ACTION(XSM_DM_PRIV); + return xsm_default_action(action, current->domain, d); +} + +#endif /* __XSM_DUMMY_H__ */ diff --git a/xen/xsm/silo.c b/xen/xsm/silo.c index 56a330a831..1bc8277b85 100644 --- a/xen/xsm/silo.c +++ b/xen/xsm/silo.c @@ -18,7 +18,7 @@ * this program; If not, see . */ #include -#include +#include "dummy.h" /* * Check if inter-domain communication is allowed. diff --git a/xen/xsm/xsm_core.c b/xen/xsm/xsm_core.c index 87c2980459..f899950d67 100644 --- a/xen/xsm/xsm_core.c +++ b/xen/xsm/xsm_core.c @@ -18,8 +18,6 @@ #include #include -#ifdef CONFIG_XSM_CONFIGURABLE - #ifdef CONFIG_MULTIBOOT #include #endif @@ -227,8 +225,6 @@ bool __init has_xsm_magic(paddr_t start) } #endif -#endif /* CONFIG_XSM_CONFIGURABLE */ - long do_xsm_op(XEN_GUEST_HANDLE_PARAM(void) op) { return xsm_do_xsm_op(op); -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Fri Sep 03 15:42:10 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Sep 2021 15:42:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.178233.324126 (Exim 4.92) (envelope-from ) id 1mMBKO-0000m9-Cr; Fri, 03 Sep 2021 15:42:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 178233.324126; Fri, 03 Sep 2021 15:42:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMBKO-0000m2-9W; Fri, 03 Sep 2021 15:42:04 +0000 Received: by outflank-mailman (input) for mailman id 178233; Fri, 03 Sep 2021 15:42:03 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMBKM-0000lw-W4 for xen-devel@lists.xenproject.org; Fri, 03 Sep 2021 15:42:03 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (unknown [40.107.7.87]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 13f325b0-82b0-4577-8d40-c31b587b4a9a; Fri, 03 Sep 2021 15:42:01 +0000 (UTC) Received: from DB7PR05CA0008.eurprd05.prod.outlook.com (2603:10a6:10:36::21) by VI1PR08MB3869.eurprd08.prod.outlook.com (2603:10a6:803:bf::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.21; Fri, 3 Sep 2021 15:41:57 +0000 Received: from DB5EUR03FT056.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:36:cafe::55) by DB7PR05CA0008.outlook.office365.com (2603:10a6:10:36::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.17 via Frontend Transport; Fri, 3 Sep 2021 15:41:57 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT056.mail.protection.outlook.com (10.152.21.124) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Fri, 3 Sep 2021 15:41:56 +0000 Received: ("Tessian outbound 5918cb94a4b5:v103"); Fri, 03 Sep 2021 15:41:56 +0000 Received: from 225ad6a0dd7c.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 667FB746-F948-4870-BAF1-10147472F887.1; Fri, 03 Sep 2021 15:41:49 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 225ad6a0dd7c.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 03 Sep 2021 15:41:49 +0000 Received: from PAXPR08MB6446.eurprd08.prod.outlook.com (2603:10a6:102:12d::10) by PAXPR08MB6799.eurprd08.prod.outlook.com (2603:10a6:102:13b::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19; Fri, 3 Sep 2021 15:41:47 +0000 Received: from PAXPR08MB6446.eurprd08.prod.outlook.com ([fe80::c029:ed0:82e7:3c2f]) by PAXPR08MB6446.eurprd08.prod.outlook.com ([fe80::c029:ed0:82e7:3c2f%6]) with mapi id 15.20.4478.022; Fri, 3 Sep 2021 15:41:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 13f325b0-82b0-4577-8d40-c31b587b4a9a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=S/2w3w+Uf621jp6T0BcYnlrni+StxWj3wQqAu2bVjOk=; b=VlcFFBHWdSbfRa/jMXlr9MArzklV7JmpLw4iXSzvbjDqH9oS7CTdlOdkGmUaOkePemZVQkUKPGRlmLYt9YM0udgi4nFA7xS9YpJMHCdEIzVhg6cv2ePmgnak7f1ajA0qJhwAhODooPygtzY9S5aw2MwNHBZc0OHJEHDKNJFWQuA= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: 674871f30fdc51aa X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mAJ//xP/Ak0GYtnAYkTXpGRaapCgREl0F3WrxCOLn3K+eNgdC89Yvsy4vkmQp+TuyJQVjDdoMcynUDK0MOXpt6VcrN23EqgVULtg2ha14CJurPCvcjHzM/qR8pLsWnoSXDZdkXJHYW6C1+OVTA5NXE1qv6zwQZv6yH+GtdT+n1cRvBRYDOoMi9QdoMy2vQP9NMbeMr7tnXBxFPiD8IKyLFTM2kKY1A5aDcBef8H2Vsf83gpe61jNq+SBwY2jJghdjrg5vv8bEVd0p7ixtfkXSrJvihDRHeYX+k0xxfvlY44vYdeXNQkNbDFodgSC2AJD9WK+2zZ2foipzvvV17QJCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=S/2w3w+Uf621jp6T0BcYnlrni+StxWj3wQqAu2bVjOk=; b=jHNuHUXlhPpY9T0jkDt2WRo1n7B1G1ZbhN6mvC1pqJELbXN5Eny8bPjr0ViAUKjwluzNYnPVgoE3rkEz2TP7DW/Yl80dci7svzxcSom/S98NRz9GRWReufPS4q3ixFLKqpEdiCSoC0dGhOd9gJ6Z9YGoZBYLgEp0v/CJyWs5vZtbMBiKvdlBx8T9kIEQrBiKh3hferlWI4B3LpDwK59qymG41bD9krrajJf21XSUqggt4v5YE/reQMJI7S9hUiAmcBdPW/GO7ew+y7kybA2vPRf2laAjgiMDK0AXzE2L2Wuu0YyOqG1EtnBgFxeS9/wxzXpdeXaHj+09FnO72OPwkQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=S/2w3w+Uf621jp6T0BcYnlrni+StxWj3wQqAu2bVjOk=; b=VlcFFBHWdSbfRa/jMXlr9MArzklV7JmpLw4iXSzvbjDqH9oS7CTdlOdkGmUaOkePemZVQkUKPGRlmLYt9YM0udgi4nFA7xS9YpJMHCdEIzVhg6cv2ePmgnak7f1ajA0qJhwAhODooPygtzY9S5aw2MwNHBZc0OHJEHDKNJFWQuA= From: Bertrand Marquis To: Xen-devel CC: Julien Grall , Stefano Stabellini , Juergen Gross , Dario Faggioli Subject: Crash when using cpupools Thread-Topic: Crash when using cpupools Thread-Index: AQHXoNo0buBDGTl+VEiGgPdGr1E/CQ== Date: Fri, 3 Sep 2021 15:41:47 +0000 Message-ID: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3654.120.0.1.13) Authentication-Results-Original: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=arm.com; x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: 136f5789-ccd3-453b-df0a-08d96ef15c98 x-ms-traffictypediagnostic: PAXPR08MB6799:|VI1PR08MB3869: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:8882;OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 7dym35IrXBwamjNRfh7cop5gJF4z4KZ2UiPBiWKXjnuUB3g8lI4r46eREK55+Fw3yPJ4dcLuJo9qii6X+vZ8PwmBLehYkzhZT1dOhsDGRt/9NBfgQnMOX9BgU5oElgupoLDtPfGNVQ1/LB5OsE4jQferXw99AlMZyLtdCsrPi6kTEZMXWIhrRQxb8qDIhCMWs+6guTYQirirAqejcOWw0v/cu6VYxcivJWQG8wR0Z/xSx4O/4JU0Mc5fKehgSiChtPuL1vKHDfQEwTnYDyM4QvAuk4I7uVdpw+2Iirn30QE5mPeNGsanBHQ9Q8sn5jhQ+Pm7HSA5I5NDA088PBAk2qkCiCxZ32XQJQ9RqijlcXdsN4AndDWLQ7LCgrQoQ63xU0lbJBaENYDWZVgMn5+QksND/JqkMnTzWcZ5FHkwBC+h4tCpP/2JmDLPLtlarvgU2OawlB3F6PX73CNaBuS0Kfx0jg8Uu/m/RwMtAfTTkOz+Rnd0CoHsKt72RDdV1fEnVWx7cDb3kXLe6wP8SWGLxbqeaX3hetbD2WpvQ+tuAMc0kqrFtHMXYvGy76UZIsuluHslFazMAxH/+DlVg0JcMOVjT+Y2JKuylZuWdlUGXTrPpcjIEMsyjmToohei5dMuOcfXazm5WzZHoxEkOJQ1FY6j9wAoow5XtONCHlPpt4AWiSbrvCb6y+QE0Wkm/Qm/pwndWcPr9mF9bJ+MQwmdzcPsw8xaMptZnecFjeB2lV428P/sAvF1RMMkR4QTP/Mu X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB6446.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(366004)(39860400002)(376002)(346002)(136003)(83380400001)(2906002)(5660300002)(66476007)(66946007)(66556008)(86362001)(71200400001)(2616005)(8936002)(8676002)(54906003)(478600001)(6506007)(33656002)(38100700002)(6916009)(36756003)(122000001)(6512007)(186003)(26005)(316002)(64756008)(3480700007)(6486002)(4326008)(66446008)(91956017)(76116006)(38070700005)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6799 Original-Authentication-Results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT056.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 6f00d02b-faf6-4da4-fb27-08d96ef15704 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xr+UaOTRAtJTdVTBqZSKnBPROHXpDV7fPSIiN4n3uKEzkCclHsIbHqI6l2kddFAJEfWP0nt7jOPhycN+vcoWTuA/kTZOSEolMPMK1qbfkgJ0WDqVvrBA/YiHY6F9RdaayPY3s4MMuMD5gBlY0mQmTcOLFuMpYX41NWlJBfobapPFrBfxq5DtyMXyeoNKsCNumRY0SVjVOWdOgjQOuSQdwmbNp4SZ67N6UD7j9akq0fJTQgYlRHlYsjlGQfpb37fckwcPPgMZrnRU7D6Kxp0j4pS/pNoyGE0p5qgJXxIOU5/r127/dRlk3KGyvudC19OzYKgleTu2YdSEQ/B2Q84cti/vH9IStt3MG0hRX6A2w8IgGs1GkcVFP3jwzNwrp772v9X3jMvbi7mCbhvimXOtvnhx9TQyNa70TanJziCMlJbZ8wObpf9CrJNmY5LDa6+3LtDHM62oZGjm7ujQzDLVgg/HRB8GKy6L3fcPFlRW8nJZDqk0UQNNWZfY1sMxN9ekYd1+5k3paPaSGMlem3UsELdeHuJ34u997Qb4jVsgIz91lIEMbhJKU7T//MLjhdlk2Uy+Gev1hHPDTn+XA999Qo0LdgaIDtrdavashXb6b55gsYegmjAm0CjdqLJWKTzMdzJ9R630KQtN60oOmlDsAzR7sO1Tnlli/tyeiWb8pAEpHH8XMe3BZDe7u5buWRpy7+gF+jvDM0MvjFlEIymz9w== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(107886003)(508600001)(5660300002)(356005)(26005)(4326008)(8936002)(3480700007)(6512007)(6486002)(186003)(82310400003)(70586007)(86362001)(47076005)(83380400001)(70206006)(36756003)(36860700001)(2906002)(6916009)(8676002)(6506007)(2616005)(54906003)(336012)(316002)(81166007)(33656002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Sep 2021 15:41:56.9242 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 136f5789-ccd3-453b-df0a-08d96ef15c98 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT056.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3869 SGksDQoNCldoaWxlIGRvaW5nIHNvbWUgaW52ZXN0aWdhdGlvbiB3aXRoIGNwdXBvb2xzIEkgZW5j b3VudGVyZWQgYSBjcmFzaCB3aGVuIHRyeWluZyB0byBpc29sYXRlIGEgZ3Vlc3QgdG8gaXRzIG93 biBwaHlzaWNhbCBjcHUuDQoNCkkgYW0gdXNpbmcgY3VycmVudCBzdGFnaW5nIHN0YXR1cy4NCg0K SSBkaWQgdGhlIGZvbGxvd2luZyAob24gRlZQIHdpdGggOCBjb3Jlcyk6DQotIHN0YXJ0IGRvbTAg d2l0aCBkb20wX21heF92Y3B1cz0xDQotIHJlbW92ZSBjb3JlIDEgZnJvbSBkb20wIGNwdXBvb2w6 IHhsIGNwdXBvb2wtY3B1LXJlbW92ZSBQb29sLTAgMQ0KLSBjcmVhdGUgYSBuZXcgcG9vbDogeGwg Y3B1cG9vbC1jcmVhdGUgbmFtZT1cIk5ldFBvb2xc4oCdDQotIGFkZCBjb3JlIDEgdG8gdGhlIHBv b2w6IHhsIGNwdXBvb2wtY3B1LWFkZCBOZXRQb29sIDENCi0gY3JlYXRlIGEgZ3Vlc3QgaW4gTmV0 UG9vbCB1c2luZyB0aGUgZm9sbG93aW5nIGluIHRoZSBndWVzdCBjb25maWc6IHBvb2w94oCcTmV0 UG9vbCINCg0KSSBlbmQgd2l0aCBhIGNyYXNoIHdpdGggdGhlIGZvbGxvd2luZyBjYWxsIHRyYWNl IGR1cmluZyBndWVzdCBjcmVhdGlvbjoNCihYRU4pIFhlbiBjYWxsIHRyYWNlOg0KKFhFTikgICAg WzwwMDAwMDAwMDAwMjM0Y2IwPl0gY3JlZGl0Mi5jI2NzY2hlZDJfYWxsb2NfdWRhdGErMHg1OC8w eGZjIChQQykNCihYRU4pICAgIFs8MDAwMDAwMDAwMDIzNGM4MD5dIGNyZWRpdDIuYyNjc2NoZWQy X2FsbG9jX3VkYXRhKzB4MjgvMHhmYyAoTFIpDQooWEVOKSAgICBbPDAwMDAwMDAwMDAyNDJkMzg+ XSBzY2hlZF9tb3ZlX2RvbWFpbisweDE0NC8weDZjMA0KKFhFTikgICAgWzwwMDAwMDAwMDAwMjJk ZDE4Pl0gY3B1cG9vbC5jI2NwdXBvb2xfbW92ZV9kb21haW5fbG9ja2VkKzB4MzgvMHg3MA0KKFhF TikgICAgWzwwMDAwMDAwMDAwMjJmYWRjPl0gY3B1cG9vbF9kb19zeXNjdGwrMHg3M2MvMHg3ODAN CihYRU4pICAgIFs8MDAwMDAwMDAwMDIyZDhlMD5dIGRvX3N5c2N0bCsweDc4OC8weGE1OA0KKFhF TikgICAgWzwwMDAwMDAwMDAwMjczYjY4Pl0gdHJhcHMuYyNkb190cmFwX2h5cGVyY2FsbCsweDc4 LzB4MTcwDQooWEVOKSAgICBbPDAwMDAwMDAwMDAyNzRmNzA+XSBkb190cmFwX2d1ZXN0X3N5bmMr MHgxMzgvMHg2MTgNCihYRU4pICAgIFs8MDAwMDAwMDAwMDI2MDQ1OD5dIGVudHJ5Lm8jZ3Vlc3Rf c3luY19zbG93cGF0aCsweGE0LzB4ZDQNCg0KQWZ0ZXIgc29tZSBkZWJ1Z2dpbmcgSSBmb3VuZCBv dXQgdGhhdCB1bml0LT52Y3B1X2xpc3QgaXMgTlVMTCBhZnRlciB1bml0LT52Y3B1X2xpc3QgPSBk LT52Y3B1W3VuaXQtPnVuaXRfaWRdOyB3aXRoIHVuaXRfaWQgMCBpbiBjb21tb24vc2NoZWQvY29y ZS5jOjY4OA0KVGhpcyBtYWtlcyB0aGUgY2FsbCB0byBpc19pZGxlX3VuaXQodW5pdCkgaW4gY3Nj aGVkMl9hbGxvY191ZGF0YSB0cmlnZ2VyIHRoZSBjcmFzaC4NCg0KQW0gSSBkb2luZyBzb21ldGhp bmcgd3JvbmcgPw0KSXMgaXQgYSBrbm93IHByb2JsZW0gPw0KRG9lcyBhbnlib2R5IGhhdmUgYSBw b2ludGVyIG9mIHdoZXJlIHRoZSBzb3VyY2Ugb2YgdGhlIGlzc3VlIG1pZ2h0IGJlID8NCg0KSSBo YXZlIGEgd29ya2luZyBzZXR1cCB0byBkZWJ1ZyB0aGlzIGlmIGFueSBvdGhlciBpbmZvIGlzIHJl cXVpcmVkIHRvIHVuZGVyc3RhbmQgdGhlIGlzc3VlLg0KDQpDaGVlcnMNCkJlcnRyYW5kDQoNCg== From xen-devel-bounces@lists.xenproject.org Fri Sep 03 16:32:05 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Sep 2021 16:32:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.178246.324137 (Exim 4.92) (envelope-from ) id 1mMC6V-00076K-1T; Fri, 03 Sep 2021 16:31:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 178246.324137; Fri, 03 Sep 2021 16:31:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMC6U-00076D-Ul; Fri, 03 Sep 2021 16:31:46 +0000 Received: by outflank-mailman (input) for mailman id 178246; Fri, 03 Sep 2021 16:31:46 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMC6U-000767-0P for xen-devel@lists.xenproject.org; Fri, 03 Sep 2021 16:31:46 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMC6R-0000Qk-Ot; Fri, 03 Sep 2021 16:31:43 +0000 Received: from 54-240-197-239.amazon.com ([54.240.197.239] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1mMC6R-000422-I3; Fri, 03 Sep 2021 16:31:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=L890QpMZCiO1y4oZR4rTouOouMUVodQHVV5GineFeIA=; b=UQ0wpUazcNWDt94uph65luMvXT mUTkmLzPCdA6yLy6TQwFKq6nWFU/FF7hRMAz+QTx1SnP6sZQvJfls+wy0Jf5TlcjVQn+q8uoRpkZp 2sSSotRocqXtWs89UhmqShvLTtRJTKqWhxOnjG0WEI4x6jlkOwhFfQnUzuQ0fp90gENM=; Subject: Re: [PATCH] domain: try to address Coverity pointing out a missing "break" in domain_teardown() To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Ian Jackson , Stefano Stabellini , Wei Liu References: <20e28e4b-c794-7435-5f5c-332e9a6c0433@suse.com> From: Julien Grall Message-ID: <9db57ad3-ce25-c753-4f24-ff8396ad5d18@xen.org> Date: Fri, 3 Sep 2021 17:31:41 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20e28e4b-c794-7435-5f5c-332e9a6c0433@suse.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Hi Jan, On 01/09/2021 09:45, Jan Beulich wrote: > Commit 806448806264 ("xen/domain: Fix label position in > domain_teardown()" has caused Coverity to report a _new_ supposedly > un-annotated fall-through in a switch(). I find this (once again) > puzzling; I'm having an increasingly hard time figuring what patterns > the tool is actually after. I would have expected that the tool would > either have spotted an issue also before this change, or not at all. Yet > if it had spotted one before, the statistics report should have included > an eliminated instance alongside the new one (because then the issue > would simply have moved by a few lines). > > Hence the only thing I could guess is that the treatment of comments in > macro expansions might be subtly different. Therefore try whether > switching the comments to the still relatively new "fallthrough" pseudo > keyword actually helps. > > Coverity-ID: 1490865 > Signed-off-by: Jan Beulich Acked-by: Julien Grall > --- > If this doesn't help, I'm afraid I'm lost as to what Coverity means us > to do to silence the reporting. > > --- a/xen/common/domain.c > +++ b/xen/common/domain.c > @@ -401,13 +401,13 @@ static int domain_teardown(struct domain > */ > #define PROGRESS(x) \ > d->teardown.val = PROG_ ## x; \ > - /* Fallthrough */ \ > + fallthrough; \ > case PROG_ ## x > > #define PROGRESS_VCPU(x) \ > d->teardown.val = PROG_vcpu_ ## x; \ > d->teardown.vcpu = v; \ > - /* Fallthrough */ \ > + fallthrough; \ > case PROG_vcpu_ ## x: \ > v = d->teardown.vcpu > > Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Sep 03 17:35:31 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Sep 2021 17:35:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.178293.324183 (Exim 4.92) (envelope-from ) id 1mMD5v-0007ea-Mi; Fri, 03 Sep 2021 17:35:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 178293.324183; Fri, 03 Sep 2021 17:35:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMD5v-0007eT-Jj; Fri, 03 Sep 2021 17:35:15 +0000 Received: by outflank-mailman (input) for mailman id 178293; Fri, 03 Sep 2021 17:35:14 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMD5u-0007eJ-Fu; Fri, 03 Sep 2021 17:35:14 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMD5u-0001UE-5C; Fri, 03 Sep 2021 17:35:14 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMD5t-0001RP-TY; Fri, 03 Sep 2021 17:35:13 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mMD5t-0006Ww-T4; Fri, 03 Sep 2021 17:35:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=3YLQ4d55VlFI+VvAEzCVZUzqI9QqXYuP/0B4u0KPlPo=; b=eiUPv/rB8k26Z1qgWXpfLS7DQB cw0hYPinaCCVr8xIivlatg/qmiUdf2DvTGTGw6bIgU1xmklUfuFcSd04/2AgY4uLNq5iKhyPx1cvb retAjp9DSRQWTym13Dx8PUNnUfmc0S7NBqmYt4+pyJxqnotLEJ3FUDHhQF4diXHXCK/k=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 164796: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=2d4978ead4b98452bc45ebe47952e524b12e2b41 X-Osstest-Versions-That: xen=96607a8e680e7f965ca868d11f8b0636317d2618 From: osstest service owner Date: Fri, 03 Sep 2021 17:35:13 +0000 flight 164796 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/164796/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 2d4978ead4b98452bc45ebe47952e524b12e2b41 baseline version: xen 96607a8e680e7f965ca868d11f8b0636317d2618 Last test of basis 164684 2021-08-31 20:01:34 Z 2 days Testing same since 164796 2021-09-03 14:01:38 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Christian Lindig Ian Jackson Jan Beulich jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 96607a8e68..2d4978ead4 2d4978ead4b98452bc45ebe47952e524b12e2b41 -> smoke From xen-devel-bounces@lists.xenproject.org Fri Sep 03 18:20:05 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Sep 2021 18:20:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.178300.324198 (Exim 4.92) (envelope-from ) id 1mMDnE-0004AW-4c; Fri, 03 Sep 2021 18:20:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 178300.324198; Fri, 03 Sep 2021 18:20:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMDnE-0004AP-0O; Fri, 03 Sep 2021 18:20:00 +0000 Received: by outflank-mailman (input) for mailman id 178300; Fri, 03 Sep 2021 18:19:59 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMDnD-0004AJ-1e for xen-devel@lists.xenproject.org; Fri, 03 Sep 2021 18:19:59 +0000 Received: from mail-wr1-x431.google.com (unknown [2a00:1450:4864:20::431]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id d25ceb54-55f7-4eb0-a243-faf6ec6d229e; Fri, 03 Sep 2021 18:19:57 +0000 (UTC) Received: by mail-wr1-x431.google.com with SMTP id m9so9411815wrb.1 for ; Fri, 03 Sep 2021 11:19:57 -0700 (PDT) Received: from x1w.. (21.red-83-52-55.dynamicip.rima-tde.net. [83.52.55.21]) by smtp.gmail.com with ESMTPSA id u23sm136370wmc.24.2021.09.03.11.19.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Sep 2021 11:19:56 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list X-Inumbo-ID: d25ceb54-55f7-4eb0-a243-faf6ec6d229e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=k3EjGTKaI5g2mQLOHoezT/qbWejrZejERiPKCtXq8gw=; b=ojXrCIeyfH+YVO9iz1+TNZ9ezRMcW6h0jHjOAtJni4y0ai5GgfLbbVKAXjbpWwN84L Wm56dutgcXCYft6ubwqE6izEV7rcqTas8IDw2060mRAfdL2U6dvcLmlcGNbagstYZVSf jve/9McQZrfnans26GBi94oDOXS/nSfcjfw8rvKdqsA1IniKQVKQQbc7TUA0wMVS7nvT TBnmW1VCvwKuQQGF8INVzA1baogQfGV8Cas8UMEOVGUt7odj+mlXP4aVg2IUpEe1kmu8 QYWmHgIkGuFnhk+83UH6zljZXUsTAJP42n6FB7tIoIdWXO+avlqow18bOmY8gb6Phemw R0jQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=k3EjGTKaI5g2mQLOHoezT/qbWejrZejERiPKCtXq8gw=; b=XfF9cAChzRC/MmnQT32mfgNCp8u3lnquqpHa9u8I867G7NBDSL5GpRvvE0HhrVnqFi 5/CR/YW60buIQD9xIkZjtH8MTq23Tg+/0YfQoYQdYoNtl+fEHH5kWfLX9Vxk9N1gQhmN /ur+V6+oazKy5mlOlFY8ataHczTfXu7dAcsYnBx9DBgt/oL4zWO9JQKdh98OJEF3T3o3 Ac50sI3HDLCOkzZESnwvEPWKhs/FEaU8TKWmV9ijzso3JIKqaGsURGZQQ++eait9izdj seEWHNO73G7t/ERwFhMlzjfA8DP9Y1ESudysEG9+bfBzpUaX46sPfMr2+JjiPAkMfzAw mbfg== X-Gm-Message-State: AOAM530JmU7js84t8JMQtmy8G5oRDSq47XBIdl7ZUGmx3JH7RJKQM+Vw XCEPjoTd1EyeaMlnORYioN4= X-Google-Smtp-Source: ABdhPJx0dZCgp0zUQLbWfMU8EmsUBXRCSeLlfDHicQVXCHRyEM3DqNc6Zbv9ZU3Q+HTVaH2wLnC6rg== X-Received: by 2002:a5d:5642:: with SMTP id j2mr433139wrw.264.1630693196710; Fri, 03 Sep 2021 11:19:56 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Richard Henderson , Anthony Perard , Cameron Esfahani , Claudio Fontana , Colin Xu , Eduardo Habkost , haxm-team@intel.com, Kamil Rytarowski , Laurent Vivier , Paolo Bonzini , Paul Durrant , Reinoud Zandijk , Roman Bolshakov , Stefano Stabellini , Thomas Huth , Wenchao Wang , xen-devel@lists.xenproject.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v3 30/30] accel: Add missing AccelOpsClass::has_work() and drop SysemuCPUOps one Date: Fri, 3 Sep 2021 20:19:43 +0200 Message-Id: <20210903181943.763360-1-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210902161543.417092-1-f4bug@amsat.org> References: <20210902161543.417092-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit cpu_common_has_work() is the default has_work() implementation and returns 'false'. Explicit it for the QTest / HAX / HVF / NVMM / Xen accelerators and remove cpu_common_has_work(). Since there are no more implementations of SysemuCPUOps::has_work, remove it along with the assertion in cpu_has_work(). Signed-off-by: Philippe Mathieu-Daudé --- include/hw/core/cpu.h | 2 -- accel/hvf/hvf-accel-ops.c | 6 ++++++ accel/qtest/qtest.c | 6 ++++++ accel/xen/xen-all.c | 6 ++++++ hw/core/cpu-common.c | 6 ------ softmmu/cpus.c | 9 ++------- target/i386/hax/hax-accel-ops.c | 6 ++++++ target/i386/nvmm/nvmm-accel-ops.c | 6 ++++++ 8 files changed, 32 insertions(+), 15 deletions(-) diff --git a/include/hw/core/cpu.h b/include/hw/core/cpu.h index e2dd171a13f..c64709b898c 100644 --- a/include/hw/core/cpu.h +++ b/include/hw/core/cpu.h @@ -89,7 +89,6 @@ struct SysemuCPUOps; * instantiatable CPU type. * @parse_features: Callback to parse command line arguments. * @reset_dump_flags: #CPUDumpFlags to use for reset logging. - * @has_work: Callback for checking if there is work to do. * @memory_rw_debug: Callback for GDB memory access. * @dump_state: Callback for dumping state. * @get_arch_id: Callback for getting architecture-dependent CPU ID. @@ -132,7 +131,6 @@ struct CPUClass { void (*parse_features)(const char *typename, char *str, Error **errp); int reset_dump_flags; - bool (*has_work)(CPUState *cpu); int (*memory_rw_debug)(CPUState *cpu, vaddr addr, uint8_t *buf, int len, bool is_write); void (*dump_state)(CPUState *cpu, FILE *, int flags); diff --git a/accel/hvf/hvf-accel-ops.c b/accel/hvf/hvf-accel-ops.c index d1691be9896..53c427ee42e 100644 --- a/accel/hvf/hvf-accel-ops.c +++ b/accel/hvf/hvf-accel-ops.c @@ -446,6 +446,11 @@ static void hvf_start_vcpu_thread(CPUState *cpu) cpu, QEMU_THREAD_JOINABLE); } +static bool hvf_cpu_has_work(CPUState *cpu) +{ + return false; +} + static void hvf_accel_ops_class_init(ObjectClass *oc, void *data) { AccelOpsClass *ops = ACCEL_OPS_CLASS(oc); @@ -456,6 +461,7 @@ static void hvf_accel_ops_class_init(ObjectClass *oc, void *data) ops->synchronize_post_init = hvf_cpu_synchronize_post_init; ops->synchronize_state = hvf_cpu_synchronize_state; ops->synchronize_pre_loadvm = hvf_cpu_synchronize_pre_loadvm; + ops->has_work = hvf_cpu_has_work; }; static const TypeInfo hvf_accel_ops_type = { .name = ACCEL_OPS_NAME("hvf"), diff --git a/accel/qtest/qtest.c b/accel/qtest/qtest.c index 7e6b8110d52..eb5a17cef18 100644 --- a/accel/qtest/qtest.c +++ b/accel/qtest/qtest.c @@ -47,12 +47,18 @@ static const TypeInfo qtest_accel_type = { }; module_obj(TYPE_QTEST_ACCEL); +static bool qtest_cpu_has_work(CPUState *cpu) +{ + return false; +} + static void qtest_accel_ops_class_init(ObjectClass *oc, void *data) { AccelOpsClass *ops = ACCEL_OPS_CLASS(oc); ops->create_vcpu_thread = dummy_start_vcpu_thread; ops->get_virtual_clock = qtest_get_virtual_clock; + ops->has_work = qtest_cpu_has_work; }; static const TypeInfo qtest_accel_ops_type = { diff --git a/accel/xen/xen-all.c b/accel/xen/xen-all.c index 69aa7d018b2..fe5a37fa2e6 100644 --- a/accel/xen/xen-all.c +++ b/accel/xen/xen-all.c @@ -215,11 +215,17 @@ static const TypeInfo xen_accel_type = { .class_init = xen_accel_class_init, }; +static bool xen_cpu_has_work(CPUState *cpu) +{ + return false; +} + static void xen_accel_ops_class_init(ObjectClass *oc, void *data) { AccelOpsClass *ops = ACCEL_OPS_CLASS(oc); ops->create_vcpu_thread = dummy_start_vcpu_thread; + ops->has_work = xen_cpu_has_work; } static const TypeInfo xen_accel_ops_type = { diff --git a/hw/core/cpu-common.c b/hw/core/cpu-common.c index e2f5a646046..5ed1ccdfdd5 100644 --- a/hw/core/cpu-common.c +++ b/hw/core/cpu-common.c @@ -143,11 +143,6 @@ static void cpu_common_reset(DeviceState *dev) } } -static bool cpu_common_has_work(CPUState *cs) -{ - return false; -} - ObjectClass *cpu_class_by_name(const char *typename, const char *cpu_model) { CPUClass *cc = CPU_CLASS(object_class_by_name(typename)); @@ -279,7 +274,6 @@ static void cpu_class_init(ObjectClass *klass, void *data) k->parse_features = cpu_common_parse_features; k->get_arch_id = cpu_common_get_arch_id; - k->has_work = cpu_common_has_work; k->gdb_read_register = cpu_common_gdb_read_register; k->gdb_write_register = cpu_common_gdb_write_register; set_bit(DEVICE_CATEGORY_CPU, dc->categories); diff --git a/softmmu/cpus.c b/softmmu/cpus.c index 6bce52ce561..e6dad2243c6 100644 --- a/softmmu/cpus.c +++ b/softmmu/cpus.c @@ -251,13 +251,8 @@ void cpu_interrupt(CPUState *cpu, int mask) bool cpu_has_work(CPUState *cpu) { - CPUClass *cc = CPU_GET_CLASS(cpu); - - if (cpus_accel->has_work) { - return cpus_accel->has_work(cpu); - } - g_assert(cc->has_work); - return cc->has_work(cpu); + g_assert(cpus_accel->has_work); + return cpus_accel->has_work(cpu); } static int do_vm_stop(RunState state, bool send_stop) diff --git a/target/i386/hax/hax-accel-ops.c b/target/i386/hax/hax-accel-ops.c index 136630e9b23..5407ba17eaf 100644 --- a/target/i386/hax/hax-accel-ops.c +++ b/target/i386/hax/hax-accel-ops.c @@ -74,6 +74,11 @@ static void hax_start_vcpu_thread(CPUState *cpu) #endif } +static bool hax_cpu_has_work(CPUState *cpu) +{ + return false; +} + static void hax_accel_ops_class_init(ObjectClass *oc, void *data) { AccelOpsClass *ops = ACCEL_OPS_CLASS(oc); @@ -85,6 +90,7 @@ static void hax_accel_ops_class_init(ObjectClass *oc, void *data) ops->synchronize_post_init = hax_cpu_synchronize_post_init; ops->synchronize_state = hax_cpu_synchronize_state; ops->synchronize_pre_loadvm = hax_cpu_synchronize_pre_loadvm; + ops->has_work = hax_cpu_has_work; } static const TypeInfo hax_accel_ops_type = { diff --git a/target/i386/nvmm/nvmm-accel-ops.c b/target/i386/nvmm/nvmm-accel-ops.c index f788f75289f..36296f79ff8 100644 --- a/target/i386/nvmm/nvmm-accel-ops.c +++ b/target/i386/nvmm/nvmm-accel-ops.c @@ -83,6 +83,11 @@ static void nvmm_kick_vcpu_thread(CPUState *cpu) cpus_kick_thread(cpu); } +static bool nvmm_cpu_has_work(CPUState *cpu) +{ + return false; +} + static void nvmm_accel_ops_class_init(ObjectClass *oc, void *data) { AccelOpsClass *ops = ACCEL_OPS_CLASS(oc); @@ -94,6 +99,7 @@ static void nvmm_accel_ops_class_init(ObjectClass *oc, void *data) ops->synchronize_post_init = nvmm_cpu_synchronize_post_init; ops->synchronize_state = nvmm_cpu_synchronize_state; ops->synchronize_pre_loadvm = nvmm_cpu_synchronize_pre_loadvm; + ops->has_work = nvmm_cpu_has_work; } static const TypeInfo nvmm_accel_ops_type = { -- 2.31.1 From xen-devel-bounces@lists.xenproject.org Fri Sep 03 19:18:58 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Sep 2021 19:18:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.178309.324209 (Exim 4.92) (envelope-from ) id 1mMEi7-0002en-Kp; Fri, 03 Sep 2021 19:18:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 178309.324209; Fri, 03 Sep 2021 19:18:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMEi7-0002eg-Hr; Fri, 03 Sep 2021 19:18:47 +0000 Received: by outflank-mailman (input) for mailman id 178309; Fri, 03 Sep 2021 19:18:46 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMEi6-0002eW-OW; Fri, 03 Sep 2021 19:18:46 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMEi6-0003FF-Bg; Fri, 03 Sep 2021 19:18:46 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMEi5-0006JE-Vm; Fri, 03 Sep 2021 19:18:46 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mMEi5-0006pr-VG; Fri, 03 Sep 2021 19:18:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=CYPHhQXpI/icUiou3nYStBOWQ/ZFnJpR6PiaB6dFq8g=; b=f+WX48WlKocIa/4KEEQdwMOWZr 5Hasqd+Z3ZIrq78IuRkNoKdc59udXLuvPUggRcLk7vTb/uVEkBnxBOEGyD0lpWAQ6fOeysd8fDPpA NaWgEwP/MM06roekjKcEyV+FVOGhraR9hEUAD+rGYTwWdz2jntXo4m/7yanqRb9leJFo=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 164792: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=8664d30a30fd676b56b4c29dbcbdd5c5538acfc1 X-Osstest-Versions-That: qemuu=9093028dd48c50bc0392791f78aab44afef57ead From: osstest service owner Date: Fri, 03 Sep 2021 19:18:45 +0000 flight 164792 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/164792/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 164772 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 164772 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 164772 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail like 164772 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 164772 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 164772 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 164772 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 164772 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass version targeted for testing: qemuu 8664d30a30fd676b56b4c29dbcbdd5c5538acfc1 baseline version: qemuu 9093028dd48c50bc0392791f78aab44afef57ead Last test of basis 164772 2021-09-02 18:37:11 Z 1 days Testing same since 164792 2021-09-03 07:39:10 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Alexander Bulekov Darren Kenny Peter Maydell Qiuhao Li jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git 9093028dd4..8664d30a30 8664d30a30fd676b56b4c29dbcbdd5c5538acfc1 -> upstream-tested From xen-devel-bounces@lists.xenproject.org Fri Sep 03 19:31:16 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Sep 2021 19:31:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.178317.324222 (Exim 4.92) (envelope-from ) id 1mMEu7-0005EV-QW; Fri, 03 Sep 2021 19:31:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 178317.324222; Fri, 03 Sep 2021 19:31:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMEu7-0005EO-NY; Fri, 03 Sep 2021 19:31:11 +0000 Received: by outflank-mailman (input) for mailman id 178317; Fri, 03 Sep 2021 19:31:11 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMEu6-0005EI-TY for xen-devel@lists.xenproject.org; Fri, 03 Sep 2021 19:31:10 +0000 Received: from mail-wm1-x335.google.com (unknown [2a00:1450:4864:20::335]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 0b5a6aae-0869-4a71-8c58-ac91c4e78552; Fri, 03 Sep 2021 19:31:09 +0000 (UTC) Received: by mail-wm1-x335.google.com with SMTP id x2-20020a1c7c02000000b002e6f1f69a1eso232852wmc.5 for ; Fri, 03 Sep 2021 12:31:09 -0700 (PDT) Received: from [192.168.8.107] (190.red-2-142-216.dynamicip.rima-tde.net. [2.142.216.190]) by smtp.gmail.com with ESMTPSA id f17sm286460wmf.4.2021.09.03.12.31.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Sep 2021 12:31:08 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0b5a6aae-0869-4a71-8c58-ac91c4e78552 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=5AI83WewnZnYkPXwZnd2Q/eU9eygrBsbivngRE4BXiQ=; b=P4ISVXfvobqG12Z6RoTOI5UGIr/4McKEzBRjkpnJVeCZevklJ/WV/0lQBT+voH2SUY t0dVslctqlM5DOtyjeqjkUvPjGWjj1dhiEdyZQeWioK8rQRoWy5A5NcKlSGuzKW3aWqj t2bT7b9xG9bD7XISjXwWDKsCHqd+100iir2zh/3XRm8EAkGO06KgFLng+vuhbRGyvSoR AObhwaMSw7osyojtzotiYTY7cxvr3JYasdODvCk6KW0vBIVPJ0cpLiVEP0EFP/cmNIcL vTd4VlnM3ebyqP3INvEw9GWo/Z410XL/Oo2itgtLLE/TkG/P7c4oBYv9h2IqwiQYnS7X J5sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=5AI83WewnZnYkPXwZnd2Q/eU9eygrBsbivngRE4BXiQ=; b=B6AfWkm6iJPPwOFjof/JZTbWIte1i/DyMNkXA3zQ4z5Bs8RLa+dPYVfWVe7qIO9UlQ oF70qyOjkOiutCrvn9M4mGZmLZrYM2IZD6gZBr0J6L3Ni+N19G/02cDfpJAP4NAvWsFJ 1xt/z5wmxYI3kdK1UB4Rv7g44yV3D4QuYXCXxiqm+xX4BdQtX7u1AefH4v1HI8Ku00fl bG1hcp/MlrdHt1KTYpViovlsd/pgTSg8NvGAPO4SmpxYtGwb1ChctSQi1IE90UsYnuus d3wvy39SR9P0YpupTi341QCF1UZwAV73/ufV+INEQP6qQ1QMp+2uAqcMQs1hGoR2J3xU 7mgw== X-Gm-Message-State: AOAM5322nGVaKe073evTpjpQww+giObdZ/qboNQv4yqwOjcKDs2PS9p9 cdfA8R/H1eiuAUu54pUjPgcbmQ== X-Google-Smtp-Source: ABdhPJyNPnhhhAtbo2njo6bCAr3WAaEKFNGmuE7LF325krCnfwymK4ah4w6eYAokj7v99c7wD74wnA== X-Received: by 2002:a1c:1c2:: with SMTP id 185mr289419wmb.11.1630697468395; Fri, 03 Sep 2021 12:31:08 -0700 (PDT) Subject: Re: [PATCH v3 01/30] accel/tcg: Restrict cpu_handle_halt() to sysemu To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org Cc: Bin Meng , Eduardo Habkost , Greg Kurz , haxm-team@intel.com, Kamil Rytarowski , qemu-ppc@nongnu.org, Anthony Perard , Marcel Apfelbaum , Michael Rolnik , qemu-riscv@nongnu.org, Paolo Bonzini , Jiaxun Yang , Thomas Huth , David Hildenbrand , Chris Wulff , Laurent Vivier , Cameron Esfahani , Sunil Muthuswamy , Max Filippov , Taylor Simpson , qemu-s390x@nongnu.org, Bastian Koppelmann , Yoshinori Sato , Artyom Tarasenko , Aurelien Jarno , Paul Durrant , Peter Maydell , David Gibson , Alistair Francis , "Edgar E. Iglesias" , Roman Bolshakov , Laurent Vivier , Cornelia Huck , qemu-arm@nongnu.org, Wenchao Wang , xen-devel@lists.xenproject.org, Marek Vasut , Stefano Stabellini , Aleksandar Rikalo , Mark Cave-Ayland , Colin Xu , Claudio Fontana , Palmer Dabbelt , Stafford Horne , Reinoud Zandijk , kvm@vger.kernel.org References: <20210902161543.417092-1-f4bug@amsat.org> <20210902161543.417092-2-f4bug@amsat.org> From: Richard Henderson Message-ID: Date: Fri, 3 Sep 2021 21:31:02 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210902161543.417092-2-f4bug@amsat.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit On 9/2/21 6:15 PM, Philippe Mathieu-Daudé wrote: > +#ifndef CONFIG_USER_ONLY > static inline bool cpu_handle_halt(CPUState *cpu) > { Hmm, slightly better to move the ifdef just inside here, > @@ -607,6 +608,7 @@ static inline bool cpu_handle_halt(CPUState *cpu) > and here, > return false; > } > +#endif /* !CONFIG_USER_ONLY */ > > static inline void cpu_handle_debug_exception(CPUState *cpu) > { > @@ -865,9 +867,11 @@ int cpu_exec(CPUState *cpu) > /* replay_interrupt may need current_cpu */ > current_cpu = cpu; > > +#ifndef CONFIG_USER_ONLY > if (cpu_handle_halt(cpu)) { > return EXCP_HALTED; > } > +#endif which would eliminate this one. r~ From xen-devel-bounces@lists.xenproject.org Fri Sep 03 20:11:39 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Sep 2021 20:11:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.178325.324233 (Exim 4.92) (envelope-from ) id 1mMFX8-0001e0-Vo; Fri, 03 Sep 2021 20:11:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 178325.324233; Fri, 03 Sep 2021 20:11:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMFX8-0001dt-Sv; Fri, 03 Sep 2021 20:11:30 +0000 Received: by outflank-mailman (input) for mailman id 178325; Fri, 03 Sep 2021 20:11:29 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMFX7-0001dk-Mb for xen-devel@lists.xenproject.org; Fri, 03 Sep 2021 20:11:29 +0000 Received: from mail-wr1-x435.google.com (unknown [2a00:1450:4864:20::435]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 437a5473-0e83-4d53-95a7-0d22b3314cfa; Fri, 03 Sep 2021 20:11:28 +0000 (UTC) Received: by mail-wr1-x435.google.com with SMTP id b10so351300wru.0 for ; Fri, 03 Sep 2021 13:11:28 -0700 (PDT) Received: from [192.168.8.107] (190.red-2-142-216.dynamicip.rima-tde.net. [2.142.216.190]) by smtp.gmail.com with ESMTPSA id o26sm331500wmc.17.2021.09.03.13.11.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Sep 2021 13:11:27 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 437a5473-0e83-4d53-95a7-0d22b3314cfa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=EaCWOOldFpTJW/62GNcO8hnd0wqc8elIcEfaX69jVvw=; b=YyrzMqwR7pTY4UVwmQkF/b6/6vs1u7pbVcrnFbJ2IcW6P4fipRJVT8PmaEsbbFpg5m Ymv96X1royzInIGobPF2j09Z1yc16HGEdliJIXhC7BdkL4CkDrSv4ViHU6bzRWnn7dZV qZBXE7dHM+4+DbAAXk77dXGymyVlTIpYSq7C1i3JEZlTfiNoWgj2wqws++sPnSgcptat mA18BowRdXGHFl+/0fRO7ZQ0GtRH00yJ/XcRK/OYqcLDp/RR8ktqw1Cg+Aoha/XNDyBg 8cWnsyWPtksyXCOTBNPJZ0SnF8sr/Z1rLMwoCoGs5MDwwc19FX55U9jh0cE3apvw4e/O +6oQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=EaCWOOldFpTJW/62GNcO8hnd0wqc8elIcEfaX69jVvw=; b=uJPXVZfNjPKYxgmllbDIpsOu6ps0CcCNR6OjRLXaRw30hJ60XI4HtmCYXbPOqOrG1W lh0hLBVg4OmTEgLYbuEGVHBn0cnoSXdkd0UCqfjmehnRZTXBz+gKW2riWE+fwOVmybQK 92M5BFIGWKTtZuSP3aONNYG1v7o3M+03+iglczXGFYxaixsEiHZDogqypLOnFkSgDvP6 NRWL76IBy2xhBR7cQBzjM1s6tlIi0svuuyD632A0DySuzSpkbVFH2Uqjt0hYGJaV2qPr jxKLdGZW+8iMq3N7rQLBiLBhqK71gnzRyniTeVmsYURjC8B7VPNFl+aYptLAuUEYgYVT Lm+Q== X-Gm-Message-State: AOAM532llcgkgH4jDFvLV4vL/OXVJ9Kx0Mj/1rxeh0SDa+TsXt2uGbhR TF8SwLE9bgPE/SeK5LJFSGmAmQ== X-Google-Smtp-Source: ABdhPJwhD7ZLlhNK9IfRlsfSxTpaQWDz0Xn28SyMeYUyzG5cv49AdD3Ojc4LM0ShmrKJ0X1u+d3JqQ== X-Received: by 2002:a5d:5712:: with SMTP id a18mr758059wrv.367.1630699887867; Fri, 03 Sep 2021 13:11:27 -0700 (PDT) Subject: Re: [PATCH v3 02/30] hw/core: Restrict cpu_has_work() to sysemu To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org Cc: Bin Meng , Eduardo Habkost , Greg Kurz , haxm-team@intel.com, Kamil Rytarowski , qemu-ppc@nongnu.org, Anthony Perard , Marcel Apfelbaum , Michael Rolnik , qemu-riscv@nongnu.org, Paolo Bonzini , Jiaxun Yang , Thomas Huth , David Hildenbrand , Chris Wulff , Laurent Vivier , Cameron Esfahani , Sunil Muthuswamy , Max Filippov , Taylor Simpson , qemu-s390x@nongnu.org, Bastian Koppelmann , Yoshinori Sato , Artyom Tarasenko , Aurelien Jarno , Paul Durrant , Peter Maydell , David Gibson , Alistair Francis , "Edgar E. Iglesias" , Roman Bolshakov , Laurent Vivier , Cornelia Huck , qemu-arm@nongnu.org, Wenchao Wang , xen-devel@lists.xenproject.org, Marek Vasut , Stefano Stabellini , Aleksandar Rikalo , Mark Cave-Ayland , Colin Xu , Claudio Fontana , Palmer Dabbelt , Stafford Horne , Reinoud Zandijk , kvm@vger.kernel.org References: <20210902161543.417092-1-f4bug@amsat.org> <20210902161543.417092-3-f4bug@amsat.org> From: Richard Henderson Message-ID: Date: Fri, 3 Sep 2021 22:11:21 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210902161543.417092-3-f4bug@amsat.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit On 9/2/21 6:15 PM, Philippe Mathieu-Daudé wrote: > cpu_has_work() is only called from system emulation code. > > Signed-off-by: Philippe Mathieu-Daudé > --- > include/hw/core/cpu.h | 32 ++++++++++++++++---------------- > 1 file changed, 16 insertions(+), 16 deletions(-) Reviewed-by: Richard Henderson r~ From xen-devel-bounces@lists.xenproject.org Fri Sep 03 20:12:09 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Sep 2021 20:12:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.178329.324245 (Exim 4.92) (envelope-from ) id 1mMFXl-0002BN-9h; Fri, 03 Sep 2021 20:12:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 178329.324245; Fri, 03 Sep 2021 20:12:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMFXl-0002BG-5j; Fri, 03 Sep 2021 20:12:09 +0000 Received: by outflank-mailman (input) for mailman id 178329; Fri, 03 Sep 2021 20:12:07 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMFXj-00027S-M5 for xen-devel@lists.xenproject.org; Fri, 03 Sep 2021 20:12:07 +0000 Received: from mail-wm1-x32d.google.com (unknown [2a00:1450:4864:20::32d]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 6cb8a81b-98a6-42d3-9930-9832eff5d001; Fri, 03 Sep 2021 20:12:02 +0000 (UTC) Received: by mail-wm1-x32d.google.com with SMTP id u26-20020a05600c441a00b002f66b2d8603so297450wmn.4 for ; Fri, 03 Sep 2021 13:12:02 -0700 (PDT) Received: from [192.168.8.107] (190.red-2-142-216.dynamicip.rima-tde.net. [2.142.216.190]) by smtp.gmail.com with ESMTPSA id d24sm273952wmb.35.2021.09.03.13.11.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Sep 2021 13:12:00 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6cb8a81b-98a6-42d3-9930-9832eff5d001 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=mxyctmapl79Ub3Q/zYX+Nkj85YoukkH7BHTHMekfamE=; b=t9RFyV/8T9K6nv3dHRjG1hWQUIpgeAPiWzbli6rc/aUuQ31x1HtnbcmsiJVOb8T6rR m4qiCVH84qQK8xPbNGXOZUpCRPvxDeX7tTBSsZh8M0374UGQg6dF6PLZwyo9ISjfc9bJ CWfpxjGwhMr7vTpK1fPtfwbm1iJ8HnTJdrYosgJK9izgHdZ0ztxg8B2uyepCOhJplxAp prdXjw8n/KT5kuDuS96LqrCZaNEgUC6kDP7SmktLzm+AQ+9mJ5wvgVVAeU25jfhlO6eI BLzbMQN2f0dppbQCTMKOQkiUcLDlvJ+v4vT/tXsEEKXyNLSD/44J84hSUEVubACT1vl5 uKhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=mxyctmapl79Ub3Q/zYX+Nkj85YoukkH7BHTHMekfamE=; b=E3sT4A+kmXTE6nMqoHUQl5zhxL96RMev8hIGOCggNJ2QSdLo7Url16Mo9p+vsDliTQ rmptr9bpz2J42YkLnvEqfGckE7MSMgZsZEz/kR41ReweZoU4Gge6bnC0uK5tk9mqKpqX CG51FgXMNRnMedO6kouwBBxbLakqMUGIpBzgp2E88ImAOjlrGojATYjkhdcPJE2kr/rE dbKyeam8gNx3RLoy4p6JombUm0Jdh9V2dtFNtnUVLzRy4B00i3ZXRqtx9CzfRZP6JiqA T2oxOp6e0gxJxdJYyfls+qYt7QFRhZhzkrZ+mTklF1vDBgw9+54DPjuii5L6/pspAttG lhFQ== X-Gm-Message-State: AOAM53197H9cpRisvnY7JdzdT64DZGPc878/8MCRATPpnOIxgKTZdvnL ubJYnWV14YRExO+DqHGjC7vB/w== X-Google-Smtp-Source: ABdhPJy+MRQgwX4y9J2xsMLOLDvh4kR8c6BOyH1OQWePN8Q6sLyIRNmiAvv2gW9kqjIBssHC4EjXwA== X-Received: by 2002:a1c:23cb:: with SMTP id j194mr455976wmj.1.1630699921311; Fri, 03 Sep 2021 13:12:01 -0700 (PDT) Subject: Re: [PATCH v3 03/30] hw/core: Un-inline cpu_has_work() To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org Cc: Bin Meng , Eduardo Habkost , Greg Kurz , haxm-team@intel.com, Kamil Rytarowski , qemu-ppc@nongnu.org, Anthony Perard , Marcel Apfelbaum , Michael Rolnik , qemu-riscv@nongnu.org, Paolo Bonzini , Jiaxun Yang , Thomas Huth , David Hildenbrand , Chris Wulff , Laurent Vivier , Cameron Esfahani , Sunil Muthuswamy , Max Filippov , Taylor Simpson , qemu-s390x@nongnu.org, Bastian Koppelmann , Yoshinori Sato , Artyom Tarasenko , Aurelien Jarno , Paul Durrant , Peter Maydell , David Gibson , Alistair Francis , "Edgar E. Iglesias" , Roman Bolshakov , Laurent Vivier , Cornelia Huck , qemu-arm@nongnu.org, Wenchao Wang , xen-devel@lists.xenproject.org, Marek Vasut , Stefano Stabellini , Aleksandar Rikalo , Mark Cave-Ayland , Colin Xu , Claudio Fontana , Palmer Dabbelt , Stafford Horne , Reinoud Zandijk , kvm@vger.kernel.org References: <20210902161543.417092-1-f4bug@amsat.org> <20210902161543.417092-4-f4bug@amsat.org> From: Richard Henderson Message-ID: Date: Fri, 3 Sep 2021 22:11:53 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210902161543.417092-4-f4bug@amsat.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit On 9/2/21 6:15 PM, Philippe Mathieu-Daudé wrote: > We want to make cpu_has_work() per-accelerator. Only declare its > prototype and move its definition to softmmu/cpus.c. > > Signed-off-by: Philippe Mathieu-Daudé > --- > include/hw/core/cpu.h | 8 +------- > softmmu/cpus.c | 8 ++++++++ > 2 files changed, 9 insertions(+), 7 deletions(-) Reviewed-by: Richard Henderson r~ From xen-devel-bounces@lists.xenproject.org Fri Sep 03 20:15:02 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Sep 2021 20:15:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.178338.324256 (Exim 4.92) (envelope-from ) id 1mMFaX-0002yl-ST; Fri, 03 Sep 2021 20:15:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 178338.324256; Fri, 03 Sep 2021 20:15:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMFaX-0002ye-PO; Fri, 03 Sep 2021 20:15:01 +0000 Received: by outflank-mailman (input) for mailman id 178338; Fri, 03 Sep 2021 20:15:01 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMFaX-0002yY-6x for xen-devel@lists.xenproject.org; Fri, 03 Sep 2021 20:15:01 +0000 Received: from mail-wr1-x42a.google.com (unknown [2a00:1450:4864:20::42a]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 7aad5d17-db47-491c-9c16-9b1737dfe478; Fri, 03 Sep 2021 20:15:00 +0000 (UTC) Received: by mail-wr1-x42a.google.com with SMTP id q14so322741wrp.3 for ; Fri, 03 Sep 2021 13:15:00 -0700 (PDT) Received: from [192.168.8.107] (190.red-2-142-216.dynamicip.rima-tde.net. [2.142.216.190]) by smtp.gmail.com with ESMTPSA id l124sm343991wml.8.2021.09.03.13.14.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Sep 2021 13:14:59 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7aad5d17-db47-491c-9c16-9b1737dfe478 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=4eHHYFkoRaMsvUTt4qW8qWzKOCRjBx/Npk4Tb094AvQ=; b=cLO22hnYLpEg/1RD0FCiO3YdVJ9j79J1/7mkf4AG2YXIXe2aFGD359ZxjySxf7C/iF tzfinMqq37GvKuJlfgORv3JQsLRcmYumsBYo2QPaZMoawXGhFMbSYBGnHCvKL0IbQik1 45MV1RijIs6tVAHVpo7wuxRVTGnn6P3tAg9pOxmHYSpWbVd9DiYxU9bQGzq/RI9TejCi IuFmIe0QtC8F7fLOeMyaxPg7y3lcT3EAD/GnAD/B9pA4KX7M04jhATDZ7A8/fr7gbEdx fOoED7iAFaPcN+AM1JnCIYtXX45hgsKvOLuQ5XpA+AqILLfo9hIxUKs545+6dSzo6DRU 0nsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=4eHHYFkoRaMsvUTt4qW8qWzKOCRjBx/Npk4Tb094AvQ=; b=f7e9szPaS9KnFo2+8yttE9sm9fN47hliljWAiiqqQDU5JitalRq7TbQD/3b0bZg3a6 uEWXZqMR1o/6MwPSMEtxPWY5c3Q3TLgvU8MNnvmdQ+o4ylHi6j3hwgDoKw4qk8sysEDV DN1gYh9QK8872wFtmQ8GLcF7/oQ6xJOFNRIkSa/JFYvg9z11f8BqJ//h0WvaeFhbMJcK Vqwfdu4Bty7kQa3iqUbfi4aWhSRHdY1W2GsfyWA7P1ouRV7zvA0eztHIxqovr734oRJj 9UWQk+t8jb4IKjfnXFfSmCu92JasIHwIyl8ZKnu6u91wDNwWyrHs0bDIzIhKnlZRxC1p q0gA== X-Gm-Message-State: AOAM533hKAvEA5DEl4zaAF+//4pbkU8TqYOvE7BVC4AUg1nrONuQVjNt /gUR8IYxgeRXLO1UaMGBUy5vTQ== X-Google-Smtp-Source: ABdhPJyHZZGXFXfUxy0q9drjOdzklbpmSyqwplr6BLWUGT4wjUUKjoKaSTakGLOyf3y9u9KCe6dQnw== X-Received: by 2002:a5d:6cc9:: with SMTP id c9mr814056wrc.12.1630700099566; Fri, 03 Sep 2021 13:14:59 -0700 (PDT) Subject: Re: [PATCH v3 04/30] sysemu: Introduce AccelOpsClass::has_work() To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org Cc: Bin Meng , Eduardo Habkost , Greg Kurz , haxm-team@intel.com, Kamil Rytarowski , qemu-ppc@nongnu.org, Anthony Perard , Marcel Apfelbaum , Michael Rolnik , qemu-riscv@nongnu.org, Paolo Bonzini , Jiaxun Yang , Thomas Huth , David Hildenbrand , Chris Wulff , Laurent Vivier , Cameron Esfahani , Sunil Muthuswamy , Max Filippov , Taylor Simpson , qemu-s390x@nongnu.org, Bastian Koppelmann , Yoshinori Sato , Artyom Tarasenko , Aurelien Jarno , Paul Durrant , Peter Maydell , David Gibson , Alistair Francis , "Edgar E. Iglesias" , Roman Bolshakov , Laurent Vivier , Cornelia Huck , qemu-arm@nongnu.org, Wenchao Wang , xen-devel@lists.xenproject.org, Marek Vasut , Stefano Stabellini , Aleksandar Rikalo , Mark Cave-Ayland , Colin Xu , Claudio Fontana , Palmer Dabbelt , Stafford Horne , Reinoud Zandijk , kvm@vger.kernel.org References: <20210902161543.417092-1-f4bug@amsat.org> <20210902161543.417092-5-f4bug@amsat.org> From: Richard Henderson Message-ID: Date: Fri, 3 Sep 2021 22:14:52 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210902161543.417092-5-f4bug@amsat.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit On 9/2/21 6:15 PM, Philippe Mathieu-Daudé wrote: > Introduce an accelerator-specific has_work() handler. > Eventually call it from cpu_has_work(). > > Signed-off-by: Philippe Mathieu-Daudé > --- > include/sysemu/accel-ops.h | 5 +++++ > softmmu/cpus.c | 3 +++ > 2 files changed, 8 insertions(+) Reviewed-by: Richard Henderson r~ From xen-devel-bounces@lists.xenproject.org Fri Sep 03 20:15:54 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Sep 2021 20:15:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.178344.324267 (Exim 4.92) (envelope-from ) id 1mMFbO-0003YE-6g; Fri, 03 Sep 2021 20:15:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 178344.324267; Fri, 03 Sep 2021 20:15:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMFbO-0003Y7-2X; Fri, 03 Sep 2021 20:15:54 +0000 Received: by outflank-mailman (input) for mailman id 178344; Fri, 03 Sep 2021 20:15:53 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMFbN-0003Xg-2u for xen-devel@lists.xenproject.org; Fri, 03 Sep 2021 20:15:53 +0000 Received: from mail-wm1-x329.google.com (unknown [2a00:1450:4864:20::329]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id d5b75ea2-91a8-40bc-9e12-af0037baca71; Fri, 03 Sep 2021 20:15:52 +0000 (UTC) Received: by mail-wm1-x329.google.com with SMTP id o39-20020a05600c512700b002e74638b567so300057wms.2 for ; Fri, 03 Sep 2021 13:15:52 -0700 (PDT) Received: from [192.168.8.107] (190.red-2-142-216.dynamicip.rima-tde.net. [2.142.216.190]) by smtp.gmail.com with ESMTPSA id m4sm353497wml.28.2021.09.03.13.15.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Sep 2021 13:15:51 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d5b75ea2-91a8-40bc-9e12-af0037baca71 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=OIdER+ntU5pnE+dAq/LvT2j6xOcRVpXDcpqShg7WpU0=; b=uxvnHzNv132fzgkc218/R0lqQKuK+t8JtxKc9v7MGrkKPRxDYU93G8sAz5OB0Qa73S HE9cI2H2Z0CH+z6tU7HILrt73xJLER1ScmOcHWVCSynT7na5DZ8aQUWZ73RzZS1vzDMQ vqeZlVUhDraI2JH+QdE7CnrbM86ihr8OahFggiYzaiiPqr9S9Cooveeavxo3806rUBCc wAmH4n70qiWJfcK+7NmYB575D8ru3ANLV2HDRDh0a+ujAxTAi2JXNetHl39JI8em8dQt /MjpEL+5e1BeWhbg4mKgjTybiTcJ5pJVRqEATLrqAPvRDkDzcFl9morqxai4fdjaAREV wsLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=OIdER+ntU5pnE+dAq/LvT2j6xOcRVpXDcpqShg7WpU0=; b=lnmxU22xwuqKs2dy4xF4UdH0u0kpnfuFVONRsTIR//o8WO//Ftp6rGZrRFM4sbArrp 5/I+sdqAFuk+6yLo8tRRozdbOeyz9sekeBeQ8sLnvT127SHfI8ypfugTnNeJENFxTISx L17R8/CGylV0SJ383LKfKpVbTNJPpj4BCsyI/7y4VYCKo7HfuLU3BiOhC8gdPGvfZWqz U6cw1EmKpxVNzSB3j6P62utk+63cAwaqltEaHn34wA2m5W95WdkfkII6KOCKVsw11I3w 3CK7rpNGwHJ+b2ZjNwDzOo+sTb/YIfMX92cmFi2RdrvPkMHiZffEvEo8wxZlw3dwRoPA Jk0Q== X-Gm-Message-State: AOAM5337r3g4K1VYUD8/iY8sv2GeayEbTH6Uh2cmHaeYDIhWXek9iQpk vAUt1xoeqBalQ8AvPVI+wkqfPQ== X-Google-Smtp-Source: ABdhPJyMWwBTg93pyBo5sv0A6QW1ur9FJeS4HTsMD79+WiDYC0sQ7drSYJ0pDX3u+yQQ7riYEaCIGg== X-Received: by 2002:a7b:cc16:: with SMTP id f22mr461323wmh.99.1630700151552; Fri, 03 Sep 2021 13:15:51 -0700 (PDT) Subject: Re: [PATCH v3 05/30] accel/kvm: Implement AccelOpsClass::has_work() To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org Cc: Bin Meng , Eduardo Habkost , Greg Kurz , haxm-team@intel.com, Kamil Rytarowski , qemu-ppc@nongnu.org, Anthony Perard , Marcel Apfelbaum , Michael Rolnik , qemu-riscv@nongnu.org, Paolo Bonzini , Jiaxun Yang , Thomas Huth , David Hildenbrand , Chris Wulff , Laurent Vivier , Cameron Esfahani , Sunil Muthuswamy , Max Filippov , Taylor Simpson , qemu-s390x@nongnu.org, Bastian Koppelmann , Yoshinori Sato , Artyom Tarasenko , Aurelien Jarno , Paul Durrant , Peter Maydell , David Gibson , Alistair Francis , "Edgar E. Iglesias" , Roman Bolshakov , Laurent Vivier , Cornelia Huck , qemu-arm@nongnu.org, Wenchao Wang , xen-devel@lists.xenproject.org, Marek Vasut , Stefano Stabellini , Aleksandar Rikalo , Mark Cave-Ayland , Colin Xu , Claudio Fontana , Palmer Dabbelt , Stafford Horne , Reinoud Zandijk , kvm@vger.kernel.org References: <20210902161543.417092-1-f4bug@amsat.org> <20210902161543.417092-6-f4bug@amsat.org> From: Richard Henderson Message-ID: <27a1a7f4-10f3-e089-6f37-4eed9542a6c6@linaro.org> Date: Fri, 3 Sep 2021 22:15:44 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210902161543.417092-6-f4bug@amsat.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit On 9/2/21 6:15 PM, Philippe Mathieu-Daudé wrote: > Implement KVM has_work() handler in AccelOpsClass and > remove it from cpu_thread_is_idle() since cpu_has_work() > is already called. > > Signed-off-by: Philippe Mathieu-Daudé > --- > accel/kvm/kvm-accel-ops.c | 6 ++++++ > softmmu/cpus.c | 2 +- > 2 files changed, 7 insertions(+), 1 deletion(-) Reviewed-by: Richard Henderson r~ From xen-devel-bounces@lists.xenproject.org Fri Sep 03 20:16:48 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Sep 2021 20:16:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.178350.324278 (Exim 4.92) (envelope-from ) id 1mMFcC-00048t-GE; Fri, 03 Sep 2021 20:16:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 178350.324278; Fri, 03 Sep 2021 20:16:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMFcC-00048m-CG; Fri, 03 Sep 2021 20:16:44 +0000 Received: by outflank-mailman (input) for mailman id 178350; Fri, 03 Sep 2021 20:16:42 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMFcA-00048c-Pj for xen-devel@lists.xenproject.org; Fri, 03 Sep 2021 20:16:42 +0000 Received: from mail-wr1-x433.google.com (unknown [2a00:1450:4864:20::433]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 51c84082-b43f-4e93-b677-905a8c27a938; Fri, 03 Sep 2021 20:16:41 +0000 (UTC) Received: by mail-wr1-x433.google.com with SMTP id q11so303104wrr.9 for ; Fri, 03 Sep 2021 13:16:41 -0700 (PDT) Received: from [192.168.8.107] (190.red-2-142-216.dynamicip.rima-tde.net. [2.142.216.190]) by smtp.gmail.com with ESMTPSA id b18sm201319wrr.89.2021.09.03.13.16.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Sep 2021 13:16:40 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 51c84082-b43f-4e93-b677-905a8c27a938 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ksvR3vXBtwALfl0I6bUYOq6zF1YdgeJMV8dFDRL1P+g=; b=F+LmEPrSCssgf1eqjM+WBloAvOVq2tL7NMyM6LZCHirhU39DXiDO2uLD9ug3iNaHCK qAQxo2bwgbel/l5ZzJa4uPRl/EqjN0sQA7XIe3XklYehe60QyUJs5qg1vnpnfs/LYzJ8 F50mpECSrD9JTS8cWWsDSVPn2dEFp7h2GfA9zAOn6e5EfN/aiCylKqANnhUX+0GyzxMA 5YbCx/uH9oIK3BVZImpikPWK6g5wC7VESYux9bpW/knmD2hNngQDnsSLtz91Hsh54IH+ 4JT7IufJEjtYH/tbJ32xqBZvfx5N5H001O4TnBoFg7L9NuRj3KiL2d3ZfaMPEXO0z6EN fEBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ksvR3vXBtwALfl0I6bUYOq6zF1YdgeJMV8dFDRL1P+g=; b=mEWZqKV/mrsQGoQguwhD752Us+6NTsDddwM82XLeRiFXvXuuFVazp/j+sZSej/NZrR i9+VIMJv04YQy6c9HcDZgdtVKR7v6jBzLEmr1AxhphuJYCKd8QFm7S45yCZX0y3X/9NR qMS1QBqkyEhlqCvGjHvyD2ro1xCCGhPz+jTArVHSkC/UZzXARrfI+josk+RsPehnL0YM dYSgCecPvqRljT1hpCProqgCn0cnS4+Ax8o4R87bITnlEVqXYOlidrmGKkmkdk7fGgNC DBW2hDW92sS3jF1g9Kft/jFhmwXKEgGvsjwNbPRTt7GA5eZq913vKmUpAIWAjGmKSycp kFow== X-Gm-Message-State: AOAM530zwJUITx+Fd6Rupzp4r4RyIQNuNP8GhWnRUIl1hIKOM5voP21/ Dkohf8CsxiwrvVxgTXg9fENyjw== X-Google-Smtp-Source: ABdhPJzV+oCZLVl1R3jywIXOYAACRgU/ouMC2nXN7qXT1ry456hLKIT4YtHfUNsVqaTI8qbV2+dfAA== X-Received: by 2002:adf:eb4a:: with SMTP id u10mr794817wrn.11.1630700201045; Fri, 03 Sep 2021 13:16:41 -0700 (PDT) Subject: Re: [PATCH v3 06/30] accel/whpx: Implement AccelOpsClass::has_work() To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org Cc: Bin Meng , Eduardo Habkost , Greg Kurz , haxm-team@intel.com, Kamil Rytarowski , qemu-ppc@nongnu.org, Anthony Perard , Marcel Apfelbaum , Michael Rolnik , qemu-riscv@nongnu.org, Paolo Bonzini , Jiaxun Yang , Thomas Huth , David Hildenbrand , Chris Wulff , Laurent Vivier , Cameron Esfahani , Sunil Muthuswamy , Max Filippov , Taylor Simpson , qemu-s390x@nongnu.org, Bastian Koppelmann , Yoshinori Sato , Artyom Tarasenko , Aurelien Jarno , Paul Durrant , Peter Maydell , David Gibson , Alistair Francis , "Edgar E. Iglesias" , Roman Bolshakov , Laurent Vivier , Cornelia Huck , qemu-arm@nongnu.org, Wenchao Wang , xen-devel@lists.xenproject.org, Marek Vasut , Stefano Stabellini , Aleksandar Rikalo , Mark Cave-Ayland , Colin Xu , Claudio Fontana , Palmer Dabbelt , Stafford Horne , Reinoud Zandijk , kvm@vger.kernel.org References: <20210902161543.417092-1-f4bug@amsat.org> <20210902161543.417092-7-f4bug@amsat.org> From: Richard Henderson Message-ID: Date: Fri, 3 Sep 2021 22:16:34 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210902161543.417092-7-f4bug@amsat.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit On 9/2/21 6:15 PM, Philippe Mathieu-Daudé wrote: > Implement WHPX has_work() handler in AccelOpsClass and > remove it from cpu_thread_is_idle() since cpu_has_work() > is already called. > > Signed-off-by: Philippe Mathieu-Daudé > --- > softmmu/cpus.c | 4 +--- > target/i386/whpx/whpx-accel-ops.c | 6 ++++++ > 2 files changed, 7 insertions(+), 3 deletions(-) Reviewed-by: Richard Henderson r~ From xen-devel-bounces@lists.xenproject.org Fri Sep 03 20:17:27 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Sep 2021 20:17:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.178356.324289 (Exim 4.92) (envelope-from ) id 1mMFcs-0004kx-PX; Fri, 03 Sep 2021 20:17:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 178356.324289; Fri, 03 Sep 2021 20:17:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMFcs-0004kq-Lw; Fri, 03 Sep 2021 20:17:26 +0000 Received: by outflank-mailman (input) for mailman id 178356; Fri, 03 Sep 2021 20:17:25 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMFcr-0004kg-C8 for xen-devel@lists.xenproject.org; Fri, 03 Sep 2021 20:17:25 +0000 Received: from mail-wr1-x436.google.com (unknown [2a00:1450:4864:20::436]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 84ab1444-2426-4487-9fd3-de92cb7480df; Fri, 03 Sep 2021 20:17:24 +0000 (UTC) Received: by mail-wr1-x436.google.com with SMTP id u16so318827wrn.5 for ; Fri, 03 Sep 2021 13:17:24 -0700 (PDT) Received: from [192.168.8.107] (190.red-2-142-216.dynamicip.rima-tde.net. [2.142.216.190]) by smtp.gmail.com with ESMTPSA id n4sm212131wri.78.2021.09.03.13.17.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Sep 2021 13:17:23 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 84ab1444-2426-4487-9fd3-de92cb7480df DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Q8RRtCMhTGBNat58ZoO2h/0Fc8GkNe0Oprx1Qcmt+DQ=; b=dwmv1KqM52aR7rH3nFosWXsm4FD08tdhGNndv5xGMzStvCDMhzyZVE8JBIwPUqwq2F bCLRGHMXtpcQxrFHLNsfcJ75PuxEZqI9fgeJ+R64/zxYVNYGjwzAkdzQcnV1G0aiGJeW LTJZC1LjtZnsolxgQDMU0UUFNoUHXBPLt2RyL3DgdCqDzCR5fV8RIduiPWvrI4huqI2x 14xoPIKRj+tYSoQLnz+qpU2iP9/qF7o+j2jiFMjWkvX25zBXsZzxhgUCz6Znrep8fiq8 IBBZaGnjNh2PebWfRMYGVTv6N4GT+lZ2aNLKT+f0rlGZl04V61ntDZBBZCMp6HS8v9vZ WEdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Q8RRtCMhTGBNat58ZoO2h/0Fc8GkNe0Oprx1Qcmt+DQ=; b=VMtFp0TDoo0ZYWC8LeXgt9poz3w6LEJFVPi5I6UmFJocA7M9TaZkOZe5FFEDBgFVbD gemmPe+/R/gcckT9RkYz46kzeNZj2YF2CxCAYNkzRbM/WGMwhlDozTysYxCfrHqrFmcj 7LtjM5EsFSmR371xuRZUssqCeF9om3Qlr6dajoPU9aTAzenytxtvY8za3RVnkXdElUBh pzBYY8OCCoP1/xzAbD33hTE6G8AfXIT95hyfOECVfA182S7skSS0IAGQBqfBMPv+VYz1 62TEdW+ikFtS39NVg3TMTbRUFcnKvqdX0Wd9BiId9gkxZdViuFjQyQGt7VtBzXIK86yW elIw== X-Gm-Message-State: AOAM530PP01zreNvSRH6jVgJCxPaCh1Nz2gCgJL98/KKWpyx2zJHg1sV yScAT/9RJrivx9QPx6aWV9ILTg== X-Google-Smtp-Source: ABdhPJymtYq5kcbCfG6OUgkQoqRmbaJKl89J4TFcqlkWTH+OL3rMdlakO2CQQpDxn27LYKv0Y23GMQ== X-Received: by 2002:a5d:53c1:: with SMTP id a1mr784175wrw.209.1630700243751; Fri, 03 Sep 2021 13:17:23 -0700 (PDT) Subject: Re: [PATCH v3 07/30] accel/tcg: Implement AccelOpsClass::has_work() as stub To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org Cc: Bin Meng , Eduardo Habkost , Greg Kurz , haxm-team@intel.com, Kamil Rytarowski , qemu-ppc@nongnu.org, Anthony Perard , Marcel Apfelbaum , Michael Rolnik , qemu-riscv@nongnu.org, Paolo Bonzini , Jiaxun Yang , Thomas Huth , David Hildenbrand , Chris Wulff , Laurent Vivier , Cameron Esfahani , Sunil Muthuswamy , Max Filippov , Taylor Simpson , qemu-s390x@nongnu.org, Bastian Koppelmann , Yoshinori Sato , Artyom Tarasenko , Aurelien Jarno , Paul Durrant , Peter Maydell , David Gibson , Alistair Francis , "Edgar E. Iglesias" , Roman Bolshakov , Laurent Vivier , Cornelia Huck , qemu-arm@nongnu.org, Wenchao Wang , xen-devel@lists.xenproject.org, Marek Vasut , Stefano Stabellini , Aleksandar Rikalo , Mark Cave-Ayland , Colin Xu , Claudio Fontana , Palmer Dabbelt , Stafford Horne , Reinoud Zandijk , kvm@vger.kernel.org References: <20210902161543.417092-1-f4bug@amsat.org> <20210902161543.417092-8-f4bug@amsat.org> From: Richard Henderson Message-ID: <618da04b-c9e4-bd22-d527-412c3fd31386@linaro.org> Date: Fri, 3 Sep 2021 22:17:16 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210902161543.417092-8-f4bug@amsat.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit On 9/2/21 6:15 PM, Philippe Mathieu-Daudé wrote: > Add TCG target-specific has_work() handler in TCGCPUOps, > and add tcg_cpu_has_work() as AccelOpsClass has_work() > implementation. > > Signed-off-by: Philippe Mathieu-Daudé > --- > include/hw/core/tcg-cpu-ops.h | 4 ++++ > accel/tcg/tcg-accel-ops.c | 12 ++++++++++++ > 2 files changed, 16 insertions(+) Reviewed-by: Richard Henderson r~ From xen-devel-bounces@lists.xenproject.org Fri Sep 03 20:18:34 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Sep 2021 20:18:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.178362.324300 (Exim 4.92) (envelope-from ) id 1mMFdy-0005Oi-5S; Fri, 03 Sep 2021 20:18:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 178362.324300; Fri, 03 Sep 2021 20:18:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMFdy-0005Ob-1T; Fri, 03 Sep 2021 20:18:34 +0000 Received: by outflank-mailman (input) for mailman id 178362; Fri, 03 Sep 2021 20:18:32 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMFdw-0005OL-F3; Fri, 03 Sep 2021 20:18:32 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMFdw-0004Iu-82; Fri, 03 Sep 2021 20:18:32 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMFdv-0001Br-UA; Fri, 03 Sep 2021 20:18:31 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mMFdv-0003P3-Te; Fri, 03 Sep 2021 20:18:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=kv18ucImg/AIqQOVrt8p+pQ3jTd/7X6tCx213toIVgU=; b=QooggekwkFbtnz99tY5JP0CZWB KcaljnM8uEPPS0b3l7AW4h553Tne1uSAsS3SNrqlT4KVJYtzTSK8nSaPY6rsafPmV3Hf6G6PqUl3s 6iGLmEix9/zBs0Y8SO3n1mkKynUYTmZEeSHvsdMITcVlRhVXefCD5QoewnRjPdZFYal4=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 164795: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=81d71fb86e1ad676e94becb7ffffb403cefd3019 X-Osstest-Versions-That: ovmf=cae735f61328d64e2e8991036707b9e78c0f5f63 From: osstest service owner Date: Fri, 03 Sep 2021 20:18:31 +0000 flight 164795 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/164795/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 164674 build-amd64-xsm 6 xen-build fail REGR. vs. 164674 build-i386-xsm 6 xen-build fail REGR. vs. 164674 build-i386 6 xen-build fail REGR. vs. 164674 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 81d71fb86e1ad676e94becb7ffffb403cefd3019 baseline version: ovmf cae735f61328d64e2e8991036707b9e78c0f5f63 Last test of basis 164674 2021-08-31 02:56:52 Z 3 days Failing since 164686 2021-09-01 03:03:43 Z 2 days 23 attempts Testing same since 164788 2021-09-03 04:12:12 Z 0 days 4 attempts ------------------------------------------------------------ People who touched revisions under test: Anthony PERARD DunTan Gary Lin Hao A Wu Jim Fehlig Lin, Gary (HPS OE-Linux) Loo Tung Lun Loo, Tung Lun Mark Wilson Marvin H?user Rebecca Cran Wenxing Hou Wenyi Xie jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit 81d71fb86e1ad676e94becb7ffffb403cefd3019 Author: Hao A Wu Date: Fri Aug 20 13:36:56 2021 +0800 Maintainers.txt: Update maintainer/reviewer roles in MdeModulePkg Remove Hao A Wu as the MdeModulePkg maintainer. Add Liming Gao as the MdeModulePkg maintainer. Remove Hao A Wu as the MdeModulePkg: Firmware Update modules reviewer. Remove Hao A Wu as the MdeModulePkg: Serial modules reviewer. Cc: Jian J Wang Cc: Liming Gao Cc: Guomin Jiang Cc: Ray Ni Cc: Zhichao Gao Signed-off-by: Hao A Wu Reviewed-by: Liming Gao Reviewed-by: Zhichao Gao commit c5e805ffe1098601e84fd501d5fa1d45e9d96a62 Author: Rebecca Cran Date: Tue Aug 31 06:36:36 2021 +0800 MdeModulePkg: Fix typo of "memory" in RamDiskDxe debug message Fix a typo of "memory" in a debug message in RamDiskProtocol.c. Signed-off-by: Rebecca Cran Reviewed-by: Hao A Wu Reviewed-by: Philippe Mathieu-Daude commit b6bc203375b6efb6822ee4fe4a59be4f1918436b Author: Wenyi Xie Date: Thu Aug 26 09:16:03 2021 +0800 MdeModulePkg/HiiDatabaseDxe:remove dead code block As the if statement outside has confirmed that BlockData->Name == NULL, so the if statement inside is always false. Cc: Jian J Wang Cc: Hao A Wu Cc: Dandan Bi Cc: Eric Dong Signed-off-by: Wenyi Xie Reviewed-by: Dandan Bi commit e3ee8c8dbd7a9f7d7905abe17be60354c9f5f9a3 Author: duntan Date: Fri Aug 20 14:43:37 2021 +0800 .azurepipelines: Add UefiPayloadPkg in gate-build-job.yml and CISetting.py Add UefiPayloadPkg in gate-build-job.yml to enable Core ci for UefiPayloadPkg. Add UefiPayloadPkg to supported Packages in CISettings. Cc: Sean Brogan Cc: Bret Barkelew Cc: Michael D Kinney Cc: Liming Gao Signed-off-by: DunTan Reviewed-by: Liming Gao commit 63fddc98e06c380e654b1cfbaf24b9fd922adfad Author: duntan Date: Fri Aug 20 14:43:36 2021 +0800 UefiPayloadPkg: Create .yaml file in UefiPayloadPkg Create .yaml file in UefiPayloadPkg to enable Core ci for UefiPayloadPkg Cc: Guo Dong Cc: Ray Ni Cc: Maurice Ma Cc: Benjamin You Signed-off-by: DunTan Reviewed-by: Liming Gao commit 12e33dca4c0612a0975265e5ba641c6261a26455 Author: Loo, Tung Lun Date: Tue Aug 17 15:43:12 2021 +0800 IntelFsp2Pkg: Support Config File and Binary delta comparison BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3567 This patch is to enable config editor to have a new feature that can spell out the delta between the default configuration files' data, such as YAML and BSF, against the data stored in the binary. This can help users understand and track the difference when modifications are made. Cc: Maurice Ma Cc: Nate DeSimone Cc: Star Zeng Cc: Chasel Chiu Signed-off-by: Loo Tung Lun Reviewed-by: Chasel Chiu commit b170806518c1e414939c8b085866544814e1ce8e Author: Mark Wilson Date: Fri Nov 13 08:05:18 2020 +0800 UefiCpuPkg: Clean up save state boundary checks and comments. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2956 In functions ReadSaveStateRegisterByIndex and WriteSaveStateRegister: * check width > 4 instead of >= 4 when writing upper 32 bytes. - This improves the code but will not affect functionality. Cc: Eric Dong Reviewed-by: Ray Ni Signed-off-by: Mark Wilson commit 3b3f88228812e2c642eea8746858a4dad928ebf7 Author: Marvin H?user Date: Mon Aug 9 14:09:25 2021 +0800 MdeModulePkg/PiSmmCore: Drop deprecated image profiling commands The legacy codebase allowed SMM images to be registered for profiling from DXE. Support for this has been dropped entirely, so remove the remaining handlers. Cc: Jian J Wang Cc: Hao A Wu Cc: Eric Dong Reviewed-by: Ray Ni Cc: Vitaly Cheptsov Signed-off-by: Marvin H?user commit cdda3f74a1327663a5d48cca13507085ba403af7 Author: Marvin H?user Date: Mon Aug 9 03:39:53 2021 +0800 UefiPayloadPkg/UefiPayloadEntry: Fix memory corruption UefiPayloadEntry's AllocatePool() applies the "sizeof" operator to HOB index rather than the HOB header structure. This yields 4 Bytes compared to the 8 Bytes the structure header requires. Fix the call to allocate the required space instead. Reviewed-by: Guo Dong Reviewed-by: Ray Ni Cc: Maurice Ma Cc: Benjamin You Cc: Vitaly Cheptsov Signed-off-by: Marvin H?user commit 5d34cc49d5d348012fe8acf9fb618826bd541a7c Author: Wenxing Hou Date: Tue Aug 24 16:11:11 2021 +0800 UefiCpuPkg/PiSmmCpuDxeSmm: Update mPatchCetSupported set condition REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3584 Function AsmCpuid should first check the value for Basic CPUID Information. The fix is to update the mPatchCetSupported judgment statement. Signed-off-by: Wenxing Hou Reviewed-by: Ray Ni Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Cc: Sheng W Cc: Yao Jiewen commit f0fe55bca4651734abf1752a1d7c69fb5bee00b9 Author: duntan Date: Fri Aug 20 13:04:29 2021 +0800 UefiPayloadPkg: Fix the build error when enable Core ci for UefiPayloadPkg V1: Add quotes when using $(ARCH) in .dsc and .fdf file. The quotes are added due to the way by which Core ci parse the .dsc file. Add UINTN in Hob.c to fix cast from pointer to integer of different size error. V2: Delete lines which reference ShellBinPkg.The pkg doesn't exist in edk2. Cc: Guo Dong Cc: Ray Ni Cc: Maurice Ma Cc: Benjamin You Signed-off-by: DunTan Reviewed-by: Ray Ni commit 9f3eda177a4b2d4a33ff1b0307cad42906396562 Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:29:48 2021 +0800 OvmfPkg/OvmfXen: add QemuKernelLoaderFsDxe Without QemuKernelLoaderFsDxe, QemuLoadKernelImage() couldn't download the kernel, initrd, and kernel command line from QEMU's fw_cfg. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3574 Signed-off-by: Gary Lin Acked-by: Anthony PERARD Reviewed-by: Philippe Mathieu-Daude Reviewed-by: Gerd Hoffmann Tested-by: Jim Fehlig commit 5b5f10d7465004e3e40ec1f50a3b490b4db595e7 Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:31:15 2021 +0800 OvmfPkg/SmmControl2Dxe: use PcdAcpiS3Enable to detect S3 support To avoid the potential inconsistency between PcdAcpiS3Enable and QemuFwCfgS3Enabled(), this commit modifies SmmControl2Dxe to detect S3 support by PcdAcpiS3Enable as modules in MdeModulePkg do. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3573 Signed-off-by: Gary Lin Reviewed-by: Gerd Hoffmann Reviewed-by: Jiewen Yao Tested-by: Jim Fehlig commit 52e2dabc0f8d3af09c213072ce8ba734302f585d Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:31:14 2021 +0800 OvmfPkg/PlatformBootManagerLib: use PcdAcpiS3Enable to detect S3 support To avoid the potential inconsistency between PcdAcpiS3Enable and QemuFwCfgS3Enabled(), this commit modifies PlatformBootManagerLib to detect S3 support by PcdAcpiS3Enable as modules in MdeModulePkg do. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3573 Signed-off-by: Gary Lin Reviewed-by: Gerd Hoffmann Reviewed-by: Jiewen Yao Tested-by: Jim Fehlig commit 28152333bccb778b62e6e97446b28bfa0e92ef82 Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:31:13 2021 +0800 OvmfPkg/LockBoxLib: use PcdAcpiS3Enable to detect S3 support To avoid the potential inconsistency between PcdAcpiS3Enable and QemuFwCfgS3Enabled(), this commit modifies LockBoxLib to detect S3 support by PcdAcpiS3Enable as modules in MdeModulePkg do. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3573 Signed-off-by: Gary Lin Reviewed-by: Philippe Mathieu-Daude Reviewed-by: Gerd Hoffmann Reviewed-by: Jiewen Yao Tested-by: Jim Fehlig commit cb0d24637dfdd869618b9635dfb8e3b0746393a6 Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:31:12 2021 +0800 OvmfPkg/OvmfXen: set PcdAcpiS3Enable at initialization There are several functions in OvmfPkg/Library using QemuFwCfgS3Enabled() to detect the S3 support status. However, in MdeModulePkg, PcdAcpiS3Enable is used to check S3 support. Since InitializeXenPlatform() didn't set PcdAcpiS3Enable as InitializePlatform() did, this made the inconsistency between drivers/functions. For example, S3SaveStateDxe checked PcdAcpiS3Enable and skipped S3BootScript because the default value is FALSE. On the other hand, PlatformBootManagerBeforeConsole() from OvmfPkg/Library called QemuFwCfgS3Enabled() and found it returned TRUE, so it invoked SaveS3BootScript(). However, S3SaveStateDxe skipped S3BootScript, so SaveS3BootScript() asserted due to EFI_NOT_FOUND. This issue mainly affects "HVM Direct Kernel Boot". When used, "fw_cfg" is enabled in QEMU and QemuFwCfgS3Enabled() returns true in that case. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3573 Signed-off-by: Gary Lin Reviewed-by: Anthony PERARD Reviewed-by: Gerd Hoffmann Reviewed-by: Jiewen Yao Tested-by: Jim Fehlig From xen-devel-bounces@lists.xenproject.org Fri Sep 03 20:18:53 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Sep 2021 20:18:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.178365.324313 (Exim 4.92) (envelope-from ) id 1mMFeE-0005rB-Jl; Fri, 03 Sep 2021 20:18:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 178365.324313; Fri, 03 Sep 2021 20:18:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMFeE-0005r4-Ga; Fri, 03 Sep 2021 20:18:50 +0000 Received: by outflank-mailman (input) for mailman id 178365; Fri, 03 Sep 2021 20:18:49 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMFeC-0005qI-T9 for xen-devel@lists.xenproject.org; Fri, 03 Sep 2021 20:18:48 +0000 Received: from mail-wm1-x334.google.com (unknown [2a00:1450:4864:20::334]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id cb6e1bf4-0d8b-4b88-9e55-6134c1e51da7; Fri, 03 Sep 2021 20:18:48 +0000 (UTC) Received: by mail-wm1-x334.google.com with SMTP id 192-20020a1c04c9000000b002f7a4ab0a49so274899wme.0 for ; Fri, 03 Sep 2021 13:18:48 -0700 (PDT) Received: from [192.168.8.107] (190.red-2-142-216.dynamicip.rima-tde.net. [2.142.216.190]) by smtp.gmail.com with ESMTPSA id e3sm292523wrv.18.2021.09.03.13.18.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Sep 2021 13:18:46 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cb6e1bf4-0d8b-4b88-9e55-6134c1e51da7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=LqQ2qGQh8nV1ZvT9x+U3BKt+BXWg+vkVFqLIEGHhpMw=; b=V8kfIBCEJT52V1fp3BG4eEUjASX4Rx05CBYVPUwSnXcrpvu9DyPd9YLrQ1EFixujIi lUO2S1zkZF5PG/5VBU6Rk3aTdfu/NohdFpDaoPBTWr2+EAlAEqDrzmgPhi1sQ9/EZI5O sp0T10IQyhYcG2l5hY7SahzlV5/YDV007peO7QbcQiw6uki0FNbyDs+4u092DrKL854h BofPE+Yc042W1WfjRNZgBmoOLdNGI5J41nf004XrJoendGTO+R9LadQCXGvxwYAslhrk awNCuxHsEq//V4tBYb37j34Ybdls/wwtEv1je9PRsUGuN+bp2kKIvMshhTUfobepCiRM Cayg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=LqQ2qGQh8nV1ZvT9x+U3BKt+BXWg+vkVFqLIEGHhpMw=; b=fFS616hdkAZ4xc9P2JiDpTWswMFgmI9g7KUWwZ1NOSshdy+B49z5e7Rc+9lTIFtTSb pdXewz0X/CjPZuH1nThaMyDOVXrDKMtaKLNLotn3UlHFmV6X+cVcE4KXkhU9tIplrwwL 7Tn+b752FQDkC7rvn+5tpfmVLj8cXVO37Oz1+axdh0Kwij57BsTcLfsO6xnE+7SHFVHr FVfDSD1KmZTQWC6aCiJ2PbxHudt6UeN2ywkvZlx6g+vDoBGEvh+y/TfOL5XEe734ziml OiacWeYjn8LhKQ/Qgk7Yga9QsPfSlkGYNT6DuUhmIzxXnZ9JqL6QcQ8AP9iaEdtlsaOS 4L/A== X-Gm-Message-State: AOAM530brx33j1oqyxOludQIFMv/ZSH6rhZd4Rkr/2mZ+0u9iQYJ4hcl Ri3LODKTBASYCDleawJ5HTLiyA== X-Google-Smtp-Source: ABdhPJw3r9Ix8xv+Nu5+AHr+Q3zSVCPcKA2sZb2hwjS2kDrQMzRlRnU83nDo49PObR1jR+RXBXRDHg== X-Received: by 2002:a1c:7c12:: with SMTP id x18mr498453wmc.114.1630700327288; Fri, 03 Sep 2021 13:18:47 -0700 (PDT) Subject: Re: [PATCH v3 08/30] target/alpha: Restrict has_work() handler to sysemu and TCG To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org Cc: Bin Meng , Eduardo Habkost , Greg Kurz , haxm-team@intel.com, Kamil Rytarowski , qemu-ppc@nongnu.org, Anthony Perard , Marcel Apfelbaum , Michael Rolnik , qemu-riscv@nongnu.org, Paolo Bonzini , Jiaxun Yang , Thomas Huth , David Hildenbrand , Chris Wulff , Laurent Vivier , Cameron Esfahani , Sunil Muthuswamy , Max Filippov , Taylor Simpson , qemu-s390x@nongnu.org, Bastian Koppelmann , Yoshinori Sato , Artyom Tarasenko , Aurelien Jarno , Paul Durrant , Peter Maydell , David Gibson , Alistair Francis , "Edgar E. Iglesias" , Roman Bolshakov , Laurent Vivier , Cornelia Huck , qemu-arm@nongnu.org, Wenchao Wang , xen-devel@lists.xenproject.org, Marek Vasut , Stefano Stabellini , Aleksandar Rikalo , Mark Cave-Ayland , Colin Xu , Claudio Fontana , Palmer Dabbelt , Stafford Horne , Reinoud Zandijk , kvm@vger.kernel.org References: <20210902161543.417092-1-f4bug@amsat.org> <20210902161543.417092-9-f4bug@amsat.org> From: Richard Henderson Message-ID: <3cd48aba-a1a1-cde3-3175-e9c462fcb220@linaro.org> Date: Fri, 3 Sep 2021 22:18:39 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210902161543.417092-9-f4bug@amsat.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit On 9/2/21 6:15 PM, Philippe Mathieu-Daudé wrote: > Restrict has_work() to TCG sysemu. > > Signed-off-by: Philippe Mathieu-Daudé > --- > target/alpha/cpu.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/target/alpha/cpu.c b/target/alpha/cpu.c > index 93e16a2ffb4..32cf5a2ea9f 100644 > --- a/target/alpha/cpu.c > +++ b/target/alpha/cpu.c > @@ -33,6 +33,7 @@ static void alpha_cpu_set_pc(CPUState *cs, vaddr value) > cpu->env.pc = value; > } > > +#if defined(CONFIG_TCG) && !defined(CONFIG_USER_ONLY) > static bool alpha_cpu_has_work(CPUState *cs) Drop CONFIG_TCG for alpha; it's always true. Otherwise, Reviewed-by: Richard Henderson r~ From xen-devel-bounces@lists.xenproject.org Fri Sep 03 20:19:28 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Sep 2021 20:19:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.178376.324324 (Exim 4.92) (envelope-from ) id 1mMFem-0006bH-SZ; Fri, 03 Sep 2021 20:19:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 178376.324324; Fri, 03 Sep 2021 20:19:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMFem-0006b8-PS; Fri, 03 Sep 2021 20:19:24 +0000 Received: by outflank-mailman (input) for mailman id 178376; Fri, 03 Sep 2021 20:19:23 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMFel-0006ah-4m for xen-devel@lists.xenproject.org; Fri, 03 Sep 2021 20:19:23 +0000 Received: from mail-wr1-x433.google.com (unknown [2a00:1450:4864:20::433]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id a6511396-d53c-4344-92d3-8d3fd82629ab; Fri, 03 Sep 2021 20:19:22 +0000 (UTC) Received: by mail-wr1-x433.google.com with SMTP id t15so316203wrg.7 for ; Fri, 03 Sep 2021 13:19:22 -0700 (PDT) Received: from [192.168.8.107] (190.red-2-142-216.dynamicip.rima-tde.net. [2.142.216.190]) by smtp.gmail.com with ESMTPSA id i4sm360865wmd.5.2021.09.03.13.19.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Sep 2021 13:19:21 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a6511396-d53c-4344-92d3-8d3fd82629ab DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=hrfT6D6r8NgV0kbWbMFB7eJ0H5Q19iawpNSQkwrO3Zw=; b=UP4L3x90K9R0Xv9kUPD2k1ldA8cppgKzxB41aZwVXYD7x/qndJVah80MG87/CBUxKF TQsp6BHab8hbEiq0EVctWDjgUQRASZHj3+eAB2JftZU4rDgjFNuJfnOUODTXjmvHq+Wb CO5SRo4MZKWNpVLFkz1S9LBbag1wL73cRaGdVxll7VdzLyexwvlp0cZN9dy4/9ct+32O xuGIsIHPC9o6Pv+TjnwbzRCalBEKUw0bgwH95SVmBcNFszNxj5KOrbihoohVlg16IcU/ cuE0LBDTSZg+bzpqf7VDLPEdO9axqPBJ8doVS6whQR+pz75s6Bv4Yx4dkv7Omkpgzy1I 2uGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=hrfT6D6r8NgV0kbWbMFB7eJ0H5Q19iawpNSQkwrO3Zw=; b=TD+tcvo9inebleM+w/QhYd0j/Qx73orif6Y00HgD+awkan/RNyI5c7a9yNqCMZUT9w Y1sp4eQuCP6F7nmZo5VXLZccFRUgudITWdEW8XF07gvHbJ1uDCVs9Dt84s5bFgg6FA6c YVSzoEgbuureyy3qarRu6w1DxanNir2aJ+OtbRw6LQL8sO0Io06W9HGwx7S+7Dpl6KbT heMTfBOuV1fEcyPILM3n2M8z9NJ3v723c4D02OhEFyq2AFU1hreRy2xh/eVvdF+8EPMG arfGIzPFj1oOmdh8TPj6k8s+/59AmVv85LilfOoIUMDea9UAeImRk6b411To9z11COHC 6UMA== X-Gm-Message-State: AOAM531lIpJFfgQA3p4nfXE0p9TEUXB9Kx2Q2gGWPl2tAurvxmeUG71d 5H5mAZD1unlcOT0FZkES5d0p0A== X-Google-Smtp-Source: ABdhPJxOkyr3cz4gxEh2Ke6ki62uWZywliZS86PJZb/UyH5xriM04K4qsIBYKGhxLIpR8DxkeTkVHg== X-Received: by 2002:a5d:5262:: with SMTP id l2mr826597wrc.190.1630700361562; Fri, 03 Sep 2021 13:19:21 -0700 (PDT) Subject: Re: [PATCH v3 09/30] target/arm: Restrict has_work() handler to sysemu and TCG To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org Cc: Bin Meng , Eduardo Habkost , Greg Kurz , haxm-team@intel.com, Kamil Rytarowski , qemu-ppc@nongnu.org, Anthony Perard , Marcel Apfelbaum , Michael Rolnik , qemu-riscv@nongnu.org, Paolo Bonzini , Jiaxun Yang , Thomas Huth , David Hildenbrand , Chris Wulff , Laurent Vivier , Cameron Esfahani , Sunil Muthuswamy , Max Filippov , Taylor Simpson , qemu-s390x@nongnu.org, Bastian Koppelmann , Yoshinori Sato , Artyom Tarasenko , Aurelien Jarno , Paul Durrant , Peter Maydell , David Gibson , Alistair Francis , "Edgar E. Iglesias" , Roman Bolshakov , Laurent Vivier , Cornelia Huck , qemu-arm@nongnu.org, Wenchao Wang , xen-devel@lists.xenproject.org, Marek Vasut , Stefano Stabellini , Aleksandar Rikalo , Mark Cave-Ayland , Colin Xu , Claudio Fontana , Palmer Dabbelt , Stafford Horne , Reinoud Zandijk , kvm@vger.kernel.org References: <20210902161543.417092-1-f4bug@amsat.org> <20210902161543.417092-10-f4bug@amsat.org> From: Richard Henderson Message-ID: <318478f2-6cea-e9ee-dc9d-442589aa8f56@linaro.org> Date: Fri, 3 Sep 2021 22:19:13 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210902161543.417092-10-f4bug@amsat.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit On 9/2/21 6:15 PM, Philippe Mathieu-Daudé wrote: > Restrict has_work() to TCG sysemu. > > Signed-off-by: Philippe Mathieu-Daudé > --- > target/arm/cpu.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) Reviewed-by: Richard Henderson r~ From xen-devel-bounces@lists.xenproject.org Fri Sep 03 20:20:16 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Sep 2021 20:20:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.178382.324335 (Exim 4.92) (envelope-from ) id 1mMFfb-0007xU-7C; Fri, 03 Sep 2021 20:20:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 178382.324335; Fri, 03 Sep 2021 20:20:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMFfb-0007xN-4D; Fri, 03 Sep 2021 20:20:15 +0000 Received: by outflank-mailman (input) for mailman id 178382; Fri, 03 Sep 2021 20:20:13 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMFfZ-0007xD-QQ for xen-devel@lists.xenproject.org; Fri, 03 Sep 2021 20:20:13 +0000 Received: from mail-wr1-x435.google.com (unknown [2a00:1450:4864:20::435]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 42206d79-e52a-438d-9045-ae305ad8bfb6; Fri, 03 Sep 2021 20:20:13 +0000 (UTC) Received: by mail-wr1-x435.google.com with SMTP id z4so322463wrr.6 for ; Fri, 03 Sep 2021 13:20:13 -0700 (PDT) Received: from [192.168.8.107] (190.red-2-142-216.dynamicip.rima-tde.net. [2.142.216.190]) by smtp.gmail.com with ESMTPSA id o8sm266012wmp.42.2021.09.03.13.20.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Sep 2021 13:20:11 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 42206d79-e52a-438d-9045-ae305ad8bfb6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=xsif4pme6nhSpsi7vEWmXFg/Hnrb7mhQtjIRT3kxFkM=; b=muTFofn/yHs0EYKIsGha4ps6z/nsFLgk7o50hQ1bBL3mlCLJN3dqh2EbQA90EnwZiK NECjyG+jXGItzTA4QlZoqJEuj4/2GopLUtjAu+ncqdo/FFyEUWUPbBu236/GFMudcuCK D9DyjDbkUkta9IAKG6+3m2r8+8jv4lYsuurqFUi0rWz/gxe73U7hLmg/mrm5hqKdTbiF Opmfkr9N/UDCqcJTgk0JtowcRFkQ/LeFaRp+RBrZIUFfJTbIekWq6l07SbB0VGTU8eH+ /SKP943AfE5+gEB6opgLoUtMGZRq5vBaEZuA49fASyXmNkP+xk+3PmUF6tFbonUn2CoS 6yWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=xsif4pme6nhSpsi7vEWmXFg/Hnrb7mhQtjIRT3kxFkM=; b=WM1qaP9Nuobmr0ThmP9LOEw7Q6EJK5TgxVAvO6vqYNxWz26yTxi8DfEQBhq8vxoKFO hGG7Y0Os/5zuSpcXwIcSlM5gIgCQL8GIMCGDeYr+Ki+OHq2Hnmz6KDe+Wn2ChIhwIpDD EVlnCQe4l54bOZaxg6v84J4R7mIi8P4niFKAiIh/r9GH/HIG97chxOP4IbJj3FMq7WUN qCSHF6oGhJxT0pOZM6oA9VZTsEF1sTR7zD50T2XUqTjc2VOtDotxWImPs7ubQV7s2V+V zthsXK/D9F0VrWcXgu/WJUeEnSe6UAwrrQioFyhO/BcNt43wQBrvfFhvm8C/8DQHu2Is 9nEw== X-Gm-Message-State: AOAM533xozJkdYOtc7u6dtOZQf1WWA1jVqRrQPmf129hf2vfD9SSZMa2 hqeIovRl0zbygR2uItsAJ+6hKA== X-Google-Smtp-Source: ABdhPJxCxEUNKk9CrXrBQLK7GjqB1EVrT8+iyYBGoXf53+iVgrOG7SDx81iHjmDeuA92Igp3EWy9+w== X-Received: by 2002:adf:dd4f:: with SMTP id u15mr825520wrm.237.1630700412182; Fri, 03 Sep 2021 13:20:12 -0700 (PDT) Subject: Re: [PATCH v3 10/30] target/avr: Restrict has_work() handler to sysemu and TCG To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org Cc: Bin Meng , Eduardo Habkost , Greg Kurz , haxm-team@intel.com, Kamil Rytarowski , qemu-ppc@nongnu.org, Anthony Perard , Marcel Apfelbaum , Michael Rolnik , qemu-riscv@nongnu.org, Paolo Bonzini , Jiaxun Yang , Thomas Huth , David Hildenbrand , Chris Wulff , Laurent Vivier , Cameron Esfahani , Sunil Muthuswamy , Max Filippov , Taylor Simpson , qemu-s390x@nongnu.org, Bastian Koppelmann , Yoshinori Sato , Artyom Tarasenko , Aurelien Jarno , Paul Durrant , Peter Maydell , David Gibson , Alistair Francis , "Edgar E. Iglesias" , Roman Bolshakov , Laurent Vivier , Cornelia Huck , qemu-arm@nongnu.org, Wenchao Wang , xen-devel@lists.xenproject.org, Marek Vasut , Stefano Stabellini , Aleksandar Rikalo , Mark Cave-Ayland , Colin Xu , Claudio Fontana , Palmer Dabbelt , Stafford Horne , Reinoud Zandijk , kvm@vger.kernel.org References: <20210902161543.417092-1-f4bug@amsat.org> <20210902161543.417092-11-f4bug@amsat.org> From: Richard Henderson Message-ID: <1833210b-e250-33f5-be38-9d543539b4aa@linaro.org> Date: Fri, 3 Sep 2021 22:20:03 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210902161543.417092-11-f4bug@amsat.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit On 9/2/21 6:15 PM, Philippe Mathieu-Daudé wrote: > Restrict has_work() to TCG sysemu. > > Signed-off-by: Philippe Mathieu-Daudé > --- > target/avr/cpu.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/target/avr/cpu.c b/target/avr/cpu.c > index e9fa54c9777..6267cc6d530 100644 > --- a/target/avr/cpu.c > +++ b/target/avr/cpu.c > @@ -32,6 +32,7 @@ static void avr_cpu_set_pc(CPUState *cs, vaddr value) > cpu->env.pc_w = value / 2; /* internally PC points to words */ > } > > +#if defined(CONFIG_TCG) && !defined(CONFIG_USER_ONLY) > static bool avr_cpu_has_work(CPUState *cs) No CONFIG_TCG or CONFIG_USER_ONLY test for avr. Otherwise, Reviewed-by: Richard Henderson r~ From xen-devel-bounces@lists.xenproject.org Fri Sep 03 20:21:28 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Sep 2021 20:21:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.178388.324347 (Exim 4.92) (envelope-from ) id 1mMFgl-0000On-HH; Fri, 03 Sep 2021 20:21:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 178388.324347; Fri, 03 Sep 2021 20:21:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMFgl-0000Oe-EN; Fri, 03 Sep 2021 20:21:27 +0000 Received: by outflank-mailman (input) for mailman id 178388; Fri, 03 Sep 2021 20:21:25 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMFgj-0000OJ-Ff for xen-devel@lists.xenproject.org; Fri, 03 Sep 2021 20:21:25 +0000 Received: from mail-wr1-x435.google.com (unknown [2a00:1450:4864:20::435]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id cbb01131-55d6-40e8-aad9-439950fc1951; Fri, 03 Sep 2021 20:21:24 +0000 (UTC) Received: by mail-wr1-x435.google.com with SMTP id t15so322008wrg.7 for ; Fri, 03 Sep 2021 13:21:24 -0700 (PDT) Received: from [192.168.8.107] (190.red-2-142-216.dynamicip.rima-tde.net. [2.142.216.190]) by smtp.gmail.com with ESMTPSA id s15sm232969wrb.22.2021.09.03.13.21.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Sep 2021 13:21:23 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cbb01131-55d6-40e8-aad9-439950fc1951 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=q+SSfq4073OmWN5SjfGpr2ImvdVTltAm2Ap93b1Y88E=; b=PZ2KiViiXR0yMgtsi9ubJd49eXX8m7kgtJ7JWAf0xocPcQ4Oxw4avSPsHVo9QZcW0N BByueunHxBruDfx2gZo+Ix58peWhu5wGIHIMCSjfvS8XdfqDnHodPv7hZLnIQBhld9/a y0lWLp8aIQKnuXGpPmhHwQpf/DGQHqb2SPZDygfQELNsjREPaTcvh71MJU4d2M9P2WuC AZHX/t3lV1bfa8h49PxfG8kq4e5hCt+9BPtVsMQjLzebnh3VaBZTuTGJBK+rNkK7BCfW EvnOQKajlmpMw2NfupoVnEo8oI6UDgZtiqq4mNRFKiSDClkKz+9ZYBjtDFyqInTaIFO/ szhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=q+SSfq4073OmWN5SjfGpr2ImvdVTltAm2Ap93b1Y88E=; b=nMikvhKWxS2K7zDj/loG+pNS1Px6FswKXZQf2k5wujLZwXJp8H4etffh4dhaDKjvMz kHGVfG2okp+j3nboJFp5JTVq+i5mkYINgwSklOOjf+4T572IeJa42E17km1arizjajtZ EvZB9E51EWm+e+Se2wB+Yy6yHYXMGgeNEtwIqZD+4jwyG3iWXgq/lMxmW+m4yR33re3h PXihYd4RYlwMAeXqLZ/GXQ1wejTWJVr4TjypUbEzpfS+6JRTHVDaWMMbYfjjT27r9pEu PACEj2xW7lqsDCZyah4SRdaQ6mg+xEuGk7Dr6Z7ECZe9JUINcxa0YQM4gpK4jz7yh6C0 Lb+w== X-Gm-Message-State: AOAM531UdRIJjPYOd/FZnqD3/tusaBiy6m+sbIhhAmtF9JMc4jz0LsKt BDkNjnYRlNX03vqPeo8mIimRsw== X-Google-Smtp-Source: ABdhPJyd1De7PuFzuLP4i8MhbWXrBu0OhprhhfEXRkHThwdYNyCL8/AmxbAlET5sIL14xwjI9QRBeg== X-Received: by 2002:adf:c149:: with SMTP id w9mr804955wre.127.1630700483905; Fri, 03 Sep 2021 13:21:23 -0700 (PDT) Subject: Re: [PATCH v3 11/30] target/cris: Restrict has_work() handler to sysemu and TCG To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org Cc: Bin Meng , Eduardo Habkost , Greg Kurz , haxm-team@intel.com, Kamil Rytarowski , qemu-ppc@nongnu.org, Anthony Perard , Marcel Apfelbaum , Michael Rolnik , qemu-riscv@nongnu.org, Paolo Bonzini , Jiaxun Yang , Thomas Huth , David Hildenbrand , Chris Wulff , Laurent Vivier , Cameron Esfahani , Sunil Muthuswamy , Max Filippov , Taylor Simpson , qemu-s390x@nongnu.org, Bastian Koppelmann , Yoshinori Sato , Artyom Tarasenko , Aurelien Jarno , Paul Durrant , Peter Maydell , David Gibson , Alistair Francis , "Edgar E. Iglesias" , Roman Bolshakov , Laurent Vivier , Cornelia Huck , qemu-arm@nongnu.org, Wenchao Wang , xen-devel@lists.xenproject.org, Marek Vasut , Stefano Stabellini , Aleksandar Rikalo , Mark Cave-Ayland , Colin Xu , Claudio Fontana , Palmer Dabbelt , Stafford Horne , Reinoud Zandijk , kvm@vger.kernel.org References: <20210902161543.417092-1-f4bug@amsat.org> <20210902161543.417092-12-f4bug@amsat.org> From: Richard Henderson Message-ID: <51e42a3f-6064-be49-26b2-20eafd1106a2@linaro.org> Date: Fri, 3 Sep 2021 22:21:16 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210902161543.417092-12-f4bug@amsat.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit On 9/2/21 6:15 PM, Philippe Mathieu-Daudé wrote: > +#if defined(CONFIG_TCG) && !defined(CONFIG_USER_ONLY) > static bool cris_cpu_has_work(CPUState *cs) No CONFIG_TCG for cris. Otherwise, Reviewed-by: Richard Henderson r~ From xen-devel-bounces@lists.xenproject.org Fri Sep 03 20:21:54 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Sep 2021 20:21:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.178392.324358 (Exim 4.92) (envelope-from ) id 1mMFh8-0000xP-Pw; Fri, 03 Sep 2021 20:21:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 178392.324358; Fri, 03 Sep 2021 20:21:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMFh8-0000xI-Mx; Fri, 03 Sep 2021 20:21:50 +0000 Received: by outflank-mailman (input) for mailman id 178392; Fri, 03 Sep 2021 20:21:49 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMFh7-0000x6-TY for xen-devel@lists.xenproject.org; Fri, 03 Sep 2021 20:21:49 +0000 Received: from mail-wr1-x42a.google.com (unknown [2a00:1450:4864:20::42a]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 76992963-d02d-4d59-9f16-1d9497d94eaf; Fri, 03 Sep 2021 20:21:49 +0000 (UTC) Received: by mail-wr1-x42a.google.com with SMTP id b10so382251wru.0 for ; Fri, 03 Sep 2021 13:21:48 -0700 (PDT) Received: from [192.168.8.107] (190.red-2-142-216.dynamicip.rima-tde.net. [2.142.216.190]) by smtp.gmail.com with ESMTPSA id r15sm402884wmh.27.2021.09.03.13.21.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Sep 2021 13:21:47 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 76992963-d02d-4d59-9f16-1d9497d94eaf DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=mnk5zSmpT/p699xgSKxNbIV/1GCHbsuA6wEF56QNf+E=; b=GhgL9+LGgM+gjslEr/EdoI7/xsxfmmw67TehO/6U7pPlE/OPtA9LjE4SDDmXvYLAmN yZeX0gl3cDixUofaJ53d7PYirmx3VephL7Fp2AHgbYGFY+2vJtFBsCzJiTNZI+nj8zOU lX3C3n2CsiqPN2JfeGez5wPcTov60f+AYR19eDiQGHsrHnbpM5alfslIIIHhsT0nTxma DXlSCsL0edylOOeUn7jofbIz89KxP2tF8ZT5uMLxWfF0tNPmLeVePpEpIaz8SindXxiw pPRklR9Iklk2ipRx/ia9X3h7Q3ffP7aRj506nP6FYfGI6tshEguc/NBqS4OKI2Ci9Ann FGJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=mnk5zSmpT/p699xgSKxNbIV/1GCHbsuA6wEF56QNf+E=; b=ZJ0EbI4yCqYK1W/l2g8S9Hv3xZJiYQGN+YYsJY60GH2xtOIpaKCw14sQCqORs8a81B 5oj0S15wInCjtsHhN6o+89dylxZxuIfoiQROUg4xDzOmr8xLv82nQYH1uM8cCDU0QMD1 kUznd8E1wu56lNhFFzlCszhPe1mqrG7YY3KC0V03SDH971aOHXx5SnpCek0ilHuDekdv hkB/d+man8bZUztrCwLUNUQccX6ZjlC5s1IXKr/n/iAooqkU6ThA/jsHJ/D9IBq2h2Fr ABcdrc8LYeyUMSt15CkT7cfcgvYSONdhI6iecxWAQRbAGkP0TNgp9c+J3eSl7RtruKBq CRuw== X-Gm-Message-State: AOAM532PKoKaqMegNpv10UWyrkslaq61Q8pAac/7ak/eQcjW5uLf7s9w CWf9IGgy+trperHT0wztpu+Xbw== X-Google-Smtp-Source: ABdhPJwPe1mnKhrxerAyhvhbZ2seI44kln/Bm0nN+tszrWb4ThZb+maUMAoke8HDY1589uhlj92r0g== X-Received: by 2002:adf:8b03:: with SMTP id n3mr768062wra.439.1630700508096; Fri, 03 Sep 2021 13:21:48 -0700 (PDT) Subject: Re: [PATCH v3 12/30] target/hexagon: Remove unused has_work() handler To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org Cc: Bin Meng , Eduardo Habkost , Greg Kurz , haxm-team@intel.com, Kamil Rytarowski , qemu-ppc@nongnu.org, Anthony Perard , Marcel Apfelbaum , Michael Rolnik , qemu-riscv@nongnu.org, Paolo Bonzini , Jiaxun Yang , Thomas Huth , David Hildenbrand , Chris Wulff , Laurent Vivier , Cameron Esfahani , Sunil Muthuswamy , Max Filippov , Taylor Simpson , qemu-s390x@nongnu.org, Bastian Koppelmann , Yoshinori Sato , Artyom Tarasenko , Aurelien Jarno , Paul Durrant , Peter Maydell , David Gibson , Alistair Francis , "Edgar E. Iglesias" , Roman Bolshakov , Laurent Vivier , Cornelia Huck , qemu-arm@nongnu.org, Wenchao Wang , xen-devel@lists.xenproject.org, Marek Vasut , Stefano Stabellini , Aleksandar Rikalo , Mark Cave-Ayland , Colin Xu , Claudio Fontana , Palmer Dabbelt , Stafford Horne , Reinoud Zandijk , kvm@vger.kernel.org References: <20210902161543.417092-1-f4bug@amsat.org> <20210902161543.417092-13-f4bug@amsat.org> From: Richard Henderson Message-ID: <5c91731f-a11c-3555-93d8-cd3379fb727e@linaro.org> Date: Fri, 3 Sep 2021 22:21:40 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210902161543.417092-13-f4bug@amsat.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit On 9/2/21 6:15 PM, Philippe Mathieu-Daudé wrote: > has_work() is sysemu specific, and Hexagon target only provides > a linux-user implementation. Remove the unused hexagon_cpu_has_work(). > > Signed-off-by: Philippe Mathieu-Daudé > --- > target/hexagon/cpu.c | 6 ------ > 1 file changed, 6 deletions(-) Reviewed-by: Richard Henderson r~ From xen-devel-bounces@lists.xenproject.org Fri Sep 03 20:22:38 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Sep 2021 20:22:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.178401.324369 (Exim 4.92) (envelope-from ) id 1mMFhu-0001gG-7R; Fri, 03 Sep 2021 20:22:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 178401.324369; Fri, 03 Sep 2021 20:22:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMFhu-0001g7-4N; Fri, 03 Sep 2021 20:22:38 +0000 Received: by outflank-mailman (input) for mailman id 178401; Fri, 03 Sep 2021 20:22:37 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMFhs-0001fz-Uy for xen-devel@lists.xenproject.org; Fri, 03 Sep 2021 20:22:37 +0000 Received: from mail-wm1-x32e.google.com (unknown [2a00:1450:4864:20::32e]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 7adb07b7-15d0-4505-a490-b04c17cc036e; Fri, 03 Sep 2021 20:22:36 +0000 (UTC) Received: by mail-wm1-x32e.google.com with SMTP id u15-20020a05600c19cf00b002f6445b8f55so334024wmq.0 for ; Fri, 03 Sep 2021 13:22:36 -0700 (PDT) Received: from [192.168.8.107] (190.red-2-142-216.dynamicip.rima-tde.net. [2.142.216.190]) by smtp.gmail.com with ESMTPSA id p13sm244311wro.8.2021.09.03.13.22.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Sep 2021 13:22:34 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7adb07b7-15d0-4505-a490-b04c17cc036e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=UnbOiyADd1ZMlxRvNb9HZP0pt1hL83FL8WVZjS8Ogcw=; b=COG3NPL3Vxpz88wlWI3lGdCLg/LDdsQZJexfhJnrghpwFEqcukZveIdAk/fFiP0wKB 7HNAWQIl6rmgV04BpIshszyQzk9qq0Q2NwrgljJCneyfFgOJ0xAXKUZsaU/hrF0B0/AT 3w+VRd6HCQDmcDCjwEVjMOfRX4d+x+Lya4wftnpVkB2KXN3pr43vNkh+vseHQcZijosS Q3FflSz6b5FTlNEGFg6AgPTW3cZ3FSliEWoFoIHYG+zwm5ACts2RQXEeZ5OBwv2FsHiM zzHD5y43SWWwvU4sjxJD/8SKKcD/qNm8NbTssviVjN3cg7xbLdiiJSNeDTXPZ9eqrqkH KpWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=UnbOiyADd1ZMlxRvNb9HZP0pt1hL83FL8WVZjS8Ogcw=; b=sazlLata/lmlAqyxE3LUM1sbHpFP4c2M5QWmnvp2LeDRKFdXoijg/Pn9ksGFWLcjMu lbkiwUujh1xCoSqUCPeQ+3AwNjzMNliB1Q7ovwGDyZBeSerq+EQd1kVQ7qIa58+PhkPn 2KtYWWiS3as1tw741pMCTbQxBsPubTDKlbF+LQmVeXaacMzYrvH9UDIQuhit8Bdzlj0c spVeyo+9SNhuSRWyNCtb28RWrsk91sI8cGQxZ08NikvH4Fw+5JiRWQ5+7C6Qd9cRr3gE fX5XIAGHqwm9sytZxoVUsCT24bCLheNMioj2Ng4bC0EOEuqEasFm/lohvG1k1S4cVaE+ CQbg== X-Gm-Message-State: AOAM533d53cJ9UyoA9ZAfBXLftC7FgXHNJjFnXj32xZt4qyHqEwInrsn arckgeZ4eBvQEVCwQl8gQZujng== X-Google-Smtp-Source: ABdhPJxPwO0cHTUIrMGmZMtVOl8TUayc1aTCNm++vMgNkxvRpyKHD/crU8kG261DTumMzBNsNkV5GA== X-Received: by 2002:a05:600c:19ca:: with SMTP id u10mr432498wmq.178.1630700555348; Fri, 03 Sep 2021 13:22:35 -0700 (PDT) Subject: Re: [PATCH v3 13/30] target/hppa: Restrict has_work() handler to sysemu and TCG To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org Cc: Bin Meng , Eduardo Habkost , Greg Kurz , haxm-team@intel.com, Kamil Rytarowski , qemu-ppc@nongnu.org, Anthony Perard , Marcel Apfelbaum , Michael Rolnik , qemu-riscv@nongnu.org, Paolo Bonzini , Jiaxun Yang , Thomas Huth , David Hildenbrand , Chris Wulff , Laurent Vivier , Cameron Esfahani , Sunil Muthuswamy , Max Filippov , Taylor Simpson , qemu-s390x@nongnu.org, Bastian Koppelmann , Yoshinori Sato , Artyom Tarasenko , Aurelien Jarno , Paul Durrant , Peter Maydell , David Gibson , Alistair Francis , "Edgar E. Iglesias" , Roman Bolshakov , Laurent Vivier , Cornelia Huck , qemu-arm@nongnu.org, Wenchao Wang , xen-devel@lists.xenproject.org, Marek Vasut , Stefano Stabellini , Aleksandar Rikalo , Mark Cave-Ayland , Colin Xu , Claudio Fontana , Palmer Dabbelt , Stafford Horne , Reinoud Zandijk , kvm@vger.kernel.org References: <20210902161543.417092-1-f4bug@amsat.org> <20210902161543.417092-14-f4bug@amsat.org> From: Richard Henderson Message-ID: <1f644d61-92e9-2161-284b-0643edd4892b@linaro.org> Date: Fri, 3 Sep 2021 22:22:27 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210902161543.417092-14-f4bug@amsat.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit On 9/2/21 6:15 PM, Philippe Mathieu-Daudé wrote: > Restrict has_work() to TCG sysemu. > > Signed-off-by: Philippe Mathieu-Daudé > --- > target/hppa/cpu.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/target/hppa/cpu.c b/target/hppa/cpu.c > index e8edd189bfc..cf1f656218f 100644 > --- a/target/hppa/cpu.c > +++ b/target/hppa/cpu.c > @@ -60,10 +60,12 @@ static void hppa_cpu_synchronize_from_tb(CPUState *cs, > cpu->env.psw_n = (tb->flags & PSW_N) != 0; > } > > +#if defined(CONFIG_TCG) && !defined(CONFIG_USER_ONLY) > static bool hppa_cpu_has_work(CPUState *cs) No CONFIG_TCG, otherwise Reviewed-by: Richard Henderson r~ From xen-devel-bounces@lists.xenproject.org Fri Sep 03 20:23:55 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Sep 2021 20:23:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.178407.324379 (Exim 4.92) (envelope-from ) id 1mMFj8-0002LK-Im; Fri, 03 Sep 2021 20:23:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 178407.324379; Fri, 03 Sep 2021 20:23:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMFj8-0002LD-FL; Fri, 03 Sep 2021 20:23:54 +0000 Received: by outflank-mailman (input) for mailman id 178407; Fri, 03 Sep 2021 20:23:53 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMFj7-0002Kk-BJ for xen-devel@lists.xenproject.org; Fri, 03 Sep 2021 20:23:53 +0000 Received: from mail-wr1-x435.google.com (unknown [2a00:1450:4864:20::435]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 76ebf9ff-0cf2-492a-891f-020586c0e0e5; Fri, 03 Sep 2021 20:23:52 +0000 (UTC) Received: by mail-wr1-x435.google.com with SMTP id b10so387887wru.0 for ; Fri, 03 Sep 2021 13:23:52 -0700 (PDT) Received: from [192.168.8.107] (190.red-2-142-216.dynamicip.rima-tde.net. [2.142.216.190]) by smtp.gmail.com with ESMTPSA id j20sm258635wrb.5.2021.09.03.13.23.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Sep 2021 13:23:51 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 76ebf9ff-0cf2-492a-891f-020586c0e0e5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=wXBwe+C96NVMAw/WVJPmEePxSXgR8UnAw4mAKidy+Uc=; b=QHLQ3rMDWNB/26AcEt/tmQB5kk5HXskxmUCeZxjWkZY+/+gmxKxtLYBbUrbEJ9IIVl TXxNm1cMDVlWjjJE1EL8SyZCs1686ubATja87bAh8hUlCMrmrU+p/h2HnsSi4f6M2VVv ZijvBz00fTjJ0Pey6nM7GppsZ7HFYqOWG62UIeKnTBmuInsYh9s3ltuexL+iuerhbSSN uMg0jOQeNSsrtwUY8ODf5A01NMcBOal5Wp3/QlINZyEPfodQvP1VTMgezqqMzuZLU7iB OiJNsnH57C+xyoKu+8wTdisD8sJn3vaHgIGWHGCi7wCCfdTlsvskKx4OEy1NR1/zo36u mnOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=wXBwe+C96NVMAw/WVJPmEePxSXgR8UnAw4mAKidy+Uc=; b=jks338WhTHfECjgtr1U4zauTz6hfppYTkFokgmX5iCtZRvDfN4VJkCCOXRRlLILUAp YlR8Q6LCm5Kl7FKn+KEGJcVnrmY/6bg7uQNRiBwKrQCA2MoWZVbCmevuEPgN33momOnz WVVklKSTZ4K+276yW/Dig0p/uzO5yr620HGz8NoVFEv+uKRawGHjZHWBCo8hh7Ymj+cm Jl+NdqAYcx4Vwn1m68jUYqjculxsJTGuSGxqKK4L4DfMjDuKoHmqJe094KGE9xr1pcUD 3ZqG+XkUf9aPif1go4Mz1YM6g7AG0z5zWFB6hONKaeBUaP89r7YKlN2o2Yp4i2Eusx2a IJnA== X-Gm-Message-State: AOAM530SBEiY0L2QQ8QmU0S3zl/AMtPyKsNnPY6SwyfsMXvTkCM5h07U oxnurNZdY7jz952G0t3pii1VEA== X-Google-Smtp-Source: ABdhPJz826d62i3FadVITpOZWzNuXjQqqxILWUC/72776fLbfHJdkqtyjig/TilRLtZ8efOdunSk1g== X-Received: by 2002:a5d:5262:: with SMTP id l2mr839408wrc.190.1630700631792; Fri, 03 Sep 2021 13:23:51 -0700 (PDT) Subject: Re: [PATCH v3 14/30] target/i386: Restrict has_work() handler to sysemu and TCG To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org Cc: Bin Meng , Eduardo Habkost , Greg Kurz , haxm-team@intel.com, Kamil Rytarowski , qemu-ppc@nongnu.org, Anthony Perard , Marcel Apfelbaum , Michael Rolnik , qemu-riscv@nongnu.org, Paolo Bonzini , Jiaxun Yang , Thomas Huth , David Hildenbrand , Chris Wulff , Laurent Vivier , Cameron Esfahani , Sunil Muthuswamy , Max Filippov , Taylor Simpson , qemu-s390x@nongnu.org, Bastian Koppelmann , Yoshinori Sato , Artyom Tarasenko , Aurelien Jarno , Paul Durrant , Peter Maydell , David Gibson , Alistair Francis , "Edgar E. Iglesias" , Roman Bolshakov , Laurent Vivier , Cornelia Huck , qemu-arm@nongnu.org, Wenchao Wang , xen-devel@lists.xenproject.org, Marek Vasut , Stefano Stabellini , Aleksandar Rikalo , Mark Cave-Ayland , Colin Xu , Claudio Fontana , Palmer Dabbelt , Stafford Horne , Reinoud Zandijk , kvm@vger.kernel.org References: <20210902161543.417092-1-f4bug@amsat.org> <20210902161543.417092-15-f4bug@amsat.org> From: Richard Henderson Message-ID: Date: Fri, 3 Sep 2021 22:23:44 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210902161543.417092-15-f4bug@amsat.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit On 9/2/21 6:15 PM, Philippe Mathieu-Daudé wrote: > Restrict has_work() to TCG sysemu. > > Signed-off-by: Philippe Mathieu-Daudé > --- > target/i386/cpu.c | 6 ------ > target/i386/tcg/tcg-cpu.c | 8 +++++++- > 2 files changed, 7 insertions(+), 7 deletions(-) Reviewed-by: Richard Henderson r~ From xen-devel-bounces@lists.xenproject.org Fri Sep 03 20:24:35 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Sep 2021 20:24:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.178413.324391 (Exim 4.92) (envelope-from ) id 1mMFjm-0002vu-Ry; Fri, 03 Sep 2021 20:24:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 178413.324391; Fri, 03 Sep 2021 20:24:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMFjm-0002vl-OX; Fri, 03 Sep 2021 20:24:34 +0000 Received: by outflank-mailman (input) for mailman id 178413; Fri, 03 Sep 2021 20:24:32 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMFjk-0002vT-Mf for xen-devel@lists.xenproject.org; Fri, 03 Sep 2021 20:24:32 +0000 Received: from mail-wr1-x42a.google.com (unknown [2a00:1450:4864:20::42a]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 3df121d7-77d4-470d-8279-ac0f63c31d72; Fri, 03 Sep 2021 20:24:31 +0000 (UTC) Received: by mail-wr1-x42a.google.com with SMTP id u9so327078wrg.8 for ; Fri, 03 Sep 2021 13:24:31 -0700 (PDT) Received: from [192.168.8.107] (190.red-2-142-216.dynamicip.rima-tde.net. [2.142.216.190]) by smtp.gmail.com with ESMTPSA id l15sm315117wms.38.2021.09.03.13.24.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Sep 2021 13:24:30 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3df121d7-77d4-470d-8279-ac0f63c31d72 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=MUAOnWb7Jr2o1NB8tpwx1E/Lm7U1xeRRhxPNvAXjZbg=; b=vzZJ3StsffaZE2XWFvvqf2xJqEy05bbfJRhtDaeaWq7QuAU52n/TB/ULQ8WeVNs54M UGk4VZfAumjAQ6YHZqLXwehiRMweE/3kJmX4Exi6/vcM0AbVsP9DyQ+kTZSyXOjSTQXE yltj+XKDtFQcrEjs98IbsnvIXwqtEH/TjR8pwEw8KEUkc8NYtmXPjP513FwOCCGUt9wr aStX5sxRH5/5TVq63meFggk5pkY4HjNNTzztQF0zM0dnsU7O4t2Ixsf6lRKnmGoibQxd a4FPgOEbY/12bxwaYsGxLbjms3hn+0Bpm8n2QXKQeM0XRr72OBCjWTcA7StsxwdGykZR MZRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=MUAOnWb7Jr2o1NB8tpwx1E/Lm7U1xeRRhxPNvAXjZbg=; b=JOYTnnJAZUa5Dj7c6hA/CHUvkpGrG6mFHpK0TPc56S07LSbsvxJ4EcyHfA+TxxQCj7 db0HDBeZMwmMJv03cMvNaiqfvtL7RF7u7lJiGQ2k+SzQhDTO+f5L3dauIh/3p3DVu5Bu u+M2vhyV37FGJfvM5vnVeVhBuuCkzXbDl13OFQWtpZAl8skERJegw5Mht+OsSjSNapAo 88CgEx6SWnIWQet5yDugTNMf4p3EomArIiaPmVwAmUR6QL0uTOZ6UsnZ4TpzbNCjG5+T xAyTFZ19W5UOfKErFnAu77Kb+5EyrDqbApLFOQx2dubjSDr6YOoLRGbBUaHNDEoNqoAv Jo/Q== X-Gm-Message-State: AOAM533slL4RzxBXWPC65IwtOhkQpqhRFhuQIqleKkxxqEX1U1TEsX3A Tt54VkVnu76Q3AN/RvtArMIuJA== X-Google-Smtp-Source: ABdhPJzUsw/5kYywwKhFVX1rjFqmUKa3i/mI2bjH4AHQJ6YuS1HfmSJytNGtWbSvomY0u97BFeRM4Q== X-Received: by 2002:adf:d4c2:: with SMTP id w2mr799125wrk.235.1630700671118; Fri, 03 Sep 2021 13:24:31 -0700 (PDT) Subject: Re: [PATCH v3 15/30] target/m68k: Restrict has_work() handler to sysemu and TCG To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org Cc: Bin Meng , Eduardo Habkost , Greg Kurz , haxm-team@intel.com, Kamil Rytarowski , qemu-ppc@nongnu.org, Anthony Perard , Marcel Apfelbaum , Michael Rolnik , qemu-riscv@nongnu.org, Paolo Bonzini , Jiaxun Yang , Thomas Huth , David Hildenbrand , Chris Wulff , Laurent Vivier , Cameron Esfahani , Sunil Muthuswamy , Max Filippov , Taylor Simpson , qemu-s390x@nongnu.org, Bastian Koppelmann , Yoshinori Sato , Artyom Tarasenko , Aurelien Jarno , Paul Durrant , Peter Maydell , David Gibson , Alistair Francis , "Edgar E. Iglesias" , Roman Bolshakov , Laurent Vivier , Cornelia Huck , qemu-arm@nongnu.org, Wenchao Wang , xen-devel@lists.xenproject.org, Marek Vasut , Stefano Stabellini , Aleksandar Rikalo , Mark Cave-Ayland , Colin Xu , Claudio Fontana , Palmer Dabbelt , Stafford Horne , Reinoud Zandijk , kvm@vger.kernel.org References: <20210902161543.417092-1-f4bug@amsat.org> <20210902161543.417092-16-f4bug@amsat.org> From: Richard Henderson Message-ID: <4ac98aaa-ca63-0db6-87ce-a77193044dd1@linaro.org> Date: Fri, 3 Sep 2021 22:24:23 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210902161543.417092-16-f4bug@amsat.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit On 9/2/21 6:15 PM, Philippe Mathieu-Daudé wrote: > Restrict has_work() to TCG sysemu. > > Signed-off-by: Philippe Mathieu-Daudé > --- > target/m68k/cpu.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/target/m68k/cpu.c b/target/m68k/cpu.c > index 66d22d11895..94b35cb4a50 100644 > --- a/target/m68k/cpu.c > +++ b/target/m68k/cpu.c > @@ -31,10 +31,12 @@ static void m68k_cpu_set_pc(CPUState *cs, vaddr value) > cpu->env.pc = value; > } > > +#if defined(CONFIG_TCG) && !defined(CONFIG_USER_ONLY) > static bool m68k_cpu_has_work(CPUState *cs) No CONFIG_TCG, otherwise, Reviewed-by: Richard Henderson r~ From xen-devel-bounces@lists.xenproject.org Fri Sep 03 20:25:39 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Sep 2021 20:25:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.178419.324401 (Exim 4.92) (envelope-from ) id 1mMFko-0003ZG-5N; Fri, 03 Sep 2021 20:25:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 178419.324401; Fri, 03 Sep 2021 20:25:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMFko-0003Z9-2L; Fri, 03 Sep 2021 20:25:38 +0000 Received: by outflank-mailman (input) for mailman id 178419; Fri, 03 Sep 2021 20:25:37 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMFkm-0003Yw-Ua for xen-devel@lists.xenproject.org; Fri, 03 Sep 2021 20:25:36 +0000 Received: from mail-wr1-x42c.google.com (unknown [2a00:1450:4864:20::42c]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 5c79fb02-b334-4c5b-90db-2703ef3efbad; Fri, 03 Sep 2021 20:25:36 +0000 (UTC) Received: by mail-wr1-x42c.google.com with SMTP id x6so306880wrv.13 for ; Fri, 03 Sep 2021 13:25:36 -0700 (PDT) Received: from [192.168.8.107] (190.red-2-142-216.dynamicip.rima-tde.net. [2.142.216.190]) by smtp.gmail.com with ESMTPSA id q13sm324320wmj.46.2021.09.03.13.25.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Sep 2021 13:25:35 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5c79fb02-b334-4c5b-90db-2703ef3efbad DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=W7k4RtqOZy7ya1WayabP+HxNcp5Fq3Mk2ZbTc+R+8wk=; b=Y7PtSwX3LA3cO29hKgEQ0rkI844j3EG/DnwVbuMutIDQuUE90Uvns4x6mk4yf7B+cm Z6Ehutu4130di1yQJkVCvyamcRHY9V7H8+/nW9cFA4cQP7R4+86sspF6SjVkmgr6mnbK taRoXaEV9tG9Hfk01UC455nNMEqk+FHQaJULcihgVHUwNroTfGeteSjAaIcGVZ3lfe7k vWQNvEvJXomiaKpwJ4tHqL+1JgHxOaDk5BcG2O5Ba51DpymToNVYzbCqx9P90GXzyM8j 2b3ZUyaRty9XmOwlTzWm7qEP3nm+1Lkh4CwG0qqunwT4jbB+PrEQJvI5TjsNGJMxJsoD DntA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=W7k4RtqOZy7ya1WayabP+HxNcp5Fq3Mk2ZbTc+R+8wk=; b=AiP9q96TBkyUl2OWBmPi6OqDblElP0cTyrelP6EEQV4z35oD41XPuIWMxg3tqQO+Fo bARSU/8Q4/M/yqHc1psV5XY/u34nxXrXgycZvVhLMiFsmASkLl8RAVsWkPAOoXNjOo4H Lmr4kftJ7Q1vZw3H+BsAQsFdOS1CCNTdMHG5kFmRAbY0LJwIZHtykT14aVIOOPb2WGR6 ysJ0C3FVmM0imHfXhLYnq2Y5o91O0OLCCj15qd5jdodUpTf0vzPNc78O3pswui+Yq8qO gAepvqfHcnZweUqndktduy3GiSp5ycJn9f82MP7AGVZeUNVglttjjrwP+OCrelEt7Puq Egjw== X-Gm-Message-State: AOAM532uIie3Vg+pTseiq5mRuPmnyi4G+xRZ2kEtaWrl+Vfr18qXRPBK sDkxAl8pmjLDvlbQxnUIMaxz5Q== X-Google-Smtp-Source: ABdhPJy/o6kXb1fKJrZGJ7NA/+HnxHPvtkph89J5ZY0ajIZpI/IL3HlrDNTpZbKsJbsJhN5+OKI2UQ== X-Received: by 2002:adf:d239:: with SMTP id k25mr830865wrh.314.1630700735383; Fri, 03 Sep 2021 13:25:35 -0700 (PDT) Subject: Re: [PATCH v3 16/30] target/microblaze: Restrict has_work() handler to sysemu and TCG To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org Cc: Bin Meng , Eduardo Habkost , Greg Kurz , haxm-team@intel.com, Kamil Rytarowski , qemu-ppc@nongnu.org, Anthony Perard , Marcel Apfelbaum , Michael Rolnik , qemu-riscv@nongnu.org, Paolo Bonzini , Jiaxun Yang , Thomas Huth , David Hildenbrand , Chris Wulff , Laurent Vivier , Cameron Esfahani , Sunil Muthuswamy , Max Filippov , Taylor Simpson , qemu-s390x@nongnu.org, Bastian Koppelmann , Yoshinori Sato , Artyom Tarasenko , Aurelien Jarno , Paul Durrant , Peter Maydell , David Gibson , Alistair Francis , "Edgar E. Iglesias" , Roman Bolshakov , Laurent Vivier , Cornelia Huck , qemu-arm@nongnu.org, Wenchao Wang , xen-devel@lists.xenproject.org, Marek Vasut , Stefano Stabellini , Aleksandar Rikalo , Mark Cave-Ayland , Colin Xu , Claudio Fontana , Palmer Dabbelt , Stafford Horne , Reinoud Zandijk , kvm@vger.kernel.org References: <20210902161543.417092-1-f4bug@amsat.org> <20210902161543.417092-17-f4bug@amsat.org> From: Richard Henderson Message-ID: Date: Fri, 3 Sep 2021 22:25:27 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210902161543.417092-17-f4bug@amsat.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit On 9/2/21 6:15 PM, Philippe Mathieu-Daudé wrote: > Restrict has_work() to TCG sysemu. > > Signed-off-by: Philippe Mathieu-Daudé > --- > target/microblaze/cpu.c | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/target/microblaze/cpu.c b/target/microblaze/cpu.c > index 15db277925f..74fbb5d201a 100644 > --- a/target/microblaze/cpu.c > +++ b/target/microblaze/cpu.c > @@ -92,12 +92,15 @@ static void mb_cpu_synchronize_from_tb(CPUState *cs, > cpu->env.iflags = tb->flags & IFLAGS_TB_MASK; > } > > +#ifndef CONFIG_USER_ONLY > + > +#ifdef CONFIG_TCG > static bool mb_cpu_has_work(CPUState *cs) No CONFIG_TCG, otherwise, Reviewed-by: Richard Henderson r~ From xen-devel-bounces@lists.xenproject.org Fri Sep 03 20:26:26 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Sep 2021 20:26:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.178425.324413 (Exim 4.92) (envelope-from ) id 1mMFla-0004AJ-G0; Fri, 03 Sep 2021 20:26:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 178425.324413; Fri, 03 Sep 2021 20:26:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMFla-0004AC-Bq; Fri, 03 Sep 2021 20:26:26 +0000 Received: by outflank-mailman (input) for mailman id 178425; Fri, 03 Sep 2021 20:26:25 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMFlZ-0004A3-Es for xen-devel@lists.xenproject.org; Fri, 03 Sep 2021 20:26:25 +0000 Received: from mail-wm1-x32d.google.com (unknown [2a00:1450:4864:20::32d]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id e4397a1e-e8a3-4803-ac39-0d29a1f114d7; Fri, 03 Sep 2021 20:26:24 +0000 (UTC) Received: by mail-wm1-x32d.google.com with SMTP id k5-20020a05600c1c8500b002f76c42214bso318379wms.3 for ; Fri, 03 Sep 2021 13:26:24 -0700 (PDT) Received: from [192.168.8.107] (190.red-2-142-216.dynamicip.rima-tde.net. [2.142.216.190]) by smtp.gmail.com with ESMTPSA id c24sm245010wrb.57.2021.09.03.13.26.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Sep 2021 13:26:23 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e4397a1e-e8a3-4803-ac39-0d29a1f114d7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=9EhQsb/ACMR+ZUYvfsQ8sm7Iu0dalRztguOzy6Crcdk=; b=QYSXBDXbshWafmBVS2xgefEvLphaKwA0sQfPQhGCg4AdEMozIzMcXqiXVGYB7CIewz jGF6cmCkebhdq+OE+6RWrDO4qTxvTVl4BSUMt65GZglcAtMPB7hoGF8O6DZlqsExbX4s XAzARgy5lmbAjguMkMH9lOvN2ERwa8Zk1z1kUQwdBWqSZWZPNk39la+7ZY1kN/pV4gyV RBRSsHPMZGhaBmnt8AGJWS+r15xgowV56WK1jX05FsVJKFg3NVzyfEkg92ZjiSGXwFOY XPliUy/Mwpe/M5POTE0+dgsKNGe4w2JH0ejOk5iEpYzt1oiH6GsVpGrvEbVnBC4nn0nZ rJzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=9EhQsb/ACMR+ZUYvfsQ8sm7Iu0dalRztguOzy6Crcdk=; b=PCNHejtiT1CLRnZmh45VDJ5OdBHtjmbUE87Q5fZrGu6cn6ACsHiCPYmm516q1mNaEo gPKhXleycghBiLOoHH2HZfBjTYXjqhrOs50lZtc4bJ2T2HICLz90GPw36j7rPnzCbeL8 0fq+CCl42zRREpxaZ2hjMwJz4PbqdJOmSGkmbIETTKsViE9gFl9wpYCHBmzED9VTvmUU XAEooRizrbYVqWi/XgfuHgpuqhVhfouNxRnoRPGhpcWtWK4I/2lqWQEqmOjxZx/Aqtgw 8GF6/hN3NEP7YkalyPJRHxeQvPoimI/1ditnMSrg2Hiegjge47TCfxf4TDGbTAd7tJJ9 Gdng== X-Gm-Message-State: AOAM533an0b6nSzYAGxrtto6QlD/VwAhrujbx40lmqC/WL813iQuHgNd tvcA6j87xT87WZ2BzYCj6jTicA== X-Google-Smtp-Source: ABdhPJxBhvIh1VZtcwLHBRW/mfjmLMhAmkSWajrXDW4E0STizvGidXuGiX92vd10z3qXEwsTB/9ddw== X-Received: by 2002:a1c:202:: with SMTP id 2mr456635wmc.122.1630700783750; Fri, 03 Sep 2021 13:26:23 -0700 (PDT) Subject: Re: [PATCH v3 17/30] target/mips: Restrict has_work() handler to sysemu and TCG To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org Cc: Bin Meng , Eduardo Habkost , Greg Kurz , haxm-team@intel.com, Kamil Rytarowski , qemu-ppc@nongnu.org, Anthony Perard , Marcel Apfelbaum , Michael Rolnik , qemu-riscv@nongnu.org, Paolo Bonzini , Jiaxun Yang , Thomas Huth , David Hildenbrand , Chris Wulff , Laurent Vivier , Cameron Esfahani , Sunil Muthuswamy , Max Filippov , Taylor Simpson , qemu-s390x@nongnu.org, Bastian Koppelmann , Yoshinori Sato , Artyom Tarasenko , Aurelien Jarno , Paul Durrant , Peter Maydell , David Gibson , Alistair Francis , "Edgar E. Iglesias" , Roman Bolshakov , Laurent Vivier , Cornelia Huck , qemu-arm@nongnu.org, Wenchao Wang , xen-devel@lists.xenproject.org, Marek Vasut , Stefano Stabellini , Aleksandar Rikalo , Mark Cave-Ayland , Colin Xu , Claudio Fontana , Palmer Dabbelt , Stafford Horne , Reinoud Zandijk , kvm@vger.kernel.org References: <20210902161543.417092-1-f4bug@amsat.org> <20210902161543.417092-18-f4bug@amsat.org> From: Richard Henderson Message-ID: Date: Fri, 3 Sep 2021 22:26:16 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210902161543.417092-18-f4bug@amsat.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit On 9/2/21 6:15 PM, Philippe Mathieu-Daudé wrote: > Restrict has_work() to TCG sysemu. > > Signed-off-by: Philippe Mathieu-Daudé > --- > target/mips/cpu.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) Reviewed-by: Richard Henderson r~ From xen-devel-bounces@lists.xenproject.org Fri Sep 03 20:31:18 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Sep 2021 20:31:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.178432.324424 (Exim 4.92) (envelope-from ) id 1mMFqC-0005sJ-63; Fri, 03 Sep 2021 20:31:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 178432.324424; Fri, 03 Sep 2021 20:31:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMFqC-0005sC-1S; Fri, 03 Sep 2021 20:31:12 +0000 Received: by outflank-mailman (input) for mailman id 178432; Fri, 03 Sep 2021 20:31:11 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMFqB-0005s6-3E for xen-devel@lists.xenproject.org; Fri, 03 Sep 2021 20:31:11 +0000 Received: from mail-wm1-x330.google.com (unknown [2a00:1450:4864:20::330]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id fe8d4ae7-09e8-4557-aa50-c0513c956a23; Fri, 03 Sep 2021 20:31:10 +0000 (UTC) Received: by mail-wm1-x330.google.com with SMTP id g135so86906wme.5 for ; Fri, 03 Sep 2021 13:31:10 -0700 (PDT) Received: from [192.168.8.107] (190.red-2-142-216.dynamicip.rima-tde.net. [2.142.216.190]) by smtp.gmail.com with ESMTPSA id i21sm232068wrb.62.2021.09.03.13.31.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Sep 2021 13:31:08 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fe8d4ae7-09e8-4557-aa50-c0513c956a23 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=bg/lxOaKgNK7p03NwBu4EagG8gbF3wogDiecV24XpwU=; b=N7Y7UOCwkEiqMP/DA2rhef2OLc1uTSqNeETW5xALwf+2bPM9vLPwLP2mwNJoCACMW9 VGKi6Y2sF5A5a/NW+D+AWWckUMjZ4g3RW+QjWA4qk3jIut3SSJ9spjBUDhjvwevFox5I JxUNi0LSnwXZj39KDzqlWU4jMSwm5sc60TEToEgbjTBaHRQCxznMjmrAUesETWr1pxNW YyW+6rvnEyxw8H9JQrzfuQGZib07c4Ny8cSP8XSD4x2scI1MkvpGzBsmG8mPGMPdfgDz mq9c4Q6tDvPpU/qVPLs0vNhp9EqbjHmLIcoKB7Y3JPSTxJq3EY1M5NeWFCnMB3KfYlPd C/RA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=bg/lxOaKgNK7p03NwBu4EagG8gbF3wogDiecV24XpwU=; b=dyGKD20n76EzEB1MwLfuEDj+jVdAoURheShco0xeoS1L64ZlwZWsX2DozUVJuVReSA yXpqVx9wkrH0jOT7Fm1AaRPDlDzuqvHI6Vz1+E1dbBaJ5iTXQVHJrPjtUVauLAmCrJQo lUR/IfWKnS3udWIXxNNEUcMEnOcOtnCM0IXT/o/n9CSe++yoBsWobf/1LaGViVGiVKta 3RVU2zOP/dtob3mWvSTbrDSyjCnXiG5iBGiM12v82lZTbQ41xQ9eJ2qJGiroYrucmY+r Qi+2zLoXsgXyHVxyfIsZQhuOUyN+TFHoQemSSGB/r/+i2IdzYXLrS+ztbtKqMJXO/Ub5 Laow== X-Gm-Message-State: AOAM533xfFQyNOW/7D6CQoMRdoWUns81cLMZVIGYvddfA2N7d+bW9tEm wRL9EBdtGCup1+Z5ofk7kn/juA== X-Google-Smtp-Source: ABdhPJwzsD1YoBLjkg4zHzKfIgPz4jC9G2HwCKaXpDjC3rpGD+JAqToGSBQB4JeRK7m1b0G3qcn/dw== X-Received: by 2002:a05:600c:35cd:: with SMTP id r13mr538951wmq.24.1630701069292; Fri, 03 Sep 2021 13:31:09 -0700 (PDT) Subject: Re: [PATCH v3 18/30] target/nios2: Restrict has_work() handler to sysemu and TCG To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org Cc: Bin Meng , Eduardo Habkost , Greg Kurz , haxm-team@intel.com, Kamil Rytarowski , qemu-ppc@nongnu.org, Anthony Perard , Marcel Apfelbaum , Michael Rolnik , qemu-riscv@nongnu.org, Paolo Bonzini , Jiaxun Yang , Thomas Huth , David Hildenbrand , Chris Wulff , Laurent Vivier , Cameron Esfahani , Sunil Muthuswamy , Max Filippov , Taylor Simpson , qemu-s390x@nongnu.org, Bastian Koppelmann , Yoshinori Sato , Artyom Tarasenko , Aurelien Jarno , Paul Durrant , Peter Maydell , David Gibson , Alistair Francis , "Edgar E. Iglesias" , Roman Bolshakov , Laurent Vivier , Cornelia Huck , qemu-arm@nongnu.org, Wenchao Wang , xen-devel@lists.xenproject.org, Marek Vasut , Stefano Stabellini , Aleksandar Rikalo , Mark Cave-Ayland , Colin Xu , Claudio Fontana , Palmer Dabbelt , Stafford Horne , Reinoud Zandijk , kvm@vger.kernel.org References: <20210902161543.417092-1-f4bug@amsat.org> <20210902161543.417092-19-f4bug@amsat.org> From: Richard Henderson Message-ID: Date: Fri, 3 Sep 2021 22:31:01 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210902161543.417092-19-f4bug@amsat.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit On 9/2/21 6:15 PM, Philippe Mathieu-Daudé wrote: > Restrict has_work() to TCG sysemu. > > Signed-off-by: Philippe Mathieu-Daudé > --- > target/nios2/cpu.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/target/nios2/cpu.c b/target/nios2/cpu.c > index 947bb09bc1e..f1f976bdad7 100644 > --- a/target/nios2/cpu.c > +++ b/target/nios2/cpu.c > @@ -34,10 +34,12 @@ static void nios2_cpu_set_pc(CPUState *cs, vaddr value) > env->regs[R_PC] = value; > } > > +#if defined(CONFIG_TCG) && !defined(CONFIG_USER_ONLY) > static bool nios2_cpu_has_work(CPUState *cs) No CONFIG_TCG, otherwise, Reviewed-by: Richard Henderson r~ From xen-devel-bounces@lists.xenproject.org Fri Sep 03 20:31:51 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Sep 2021 20:31:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.178437.324434 (Exim 4.92) (envelope-from ) id 1mMFqp-0006QT-Db; Fri, 03 Sep 2021 20:31:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 178437.324434; Fri, 03 Sep 2021 20:31:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMFqp-0006QM-Ae; Fri, 03 Sep 2021 20:31:51 +0000 Received: by outflank-mailman (input) for mailman id 178437; Fri, 03 Sep 2021 20:31:50 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMFqo-0006Ok-6q for xen-devel@lists.xenproject.org; Fri, 03 Sep 2021 20:31:50 +0000 Received: from mail-wm1-x32a.google.com (unknown [2a00:1450:4864:20::32a]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id f49976a1-f222-4986-9403-0fc003c84747; Fri, 03 Sep 2021 20:31:48 +0000 (UTC) Received: by mail-wm1-x32a.google.com with SMTP id m2so118211wmm.0 for ; Fri, 03 Sep 2021 13:31:48 -0700 (PDT) Received: from [192.168.8.107] (190.red-2-142-216.dynamicip.rima-tde.net. [2.142.216.190]) by smtp.gmail.com with ESMTPSA id 129sm315688wmz.26.2021.09.03.13.31.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Sep 2021 13:31:47 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f49976a1-f222-4986-9403-0fc003c84747 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=IuI8V71Jj+hTTxPmLaVm9RgBYo3XervExPJzr/+wck8=; b=BHJmUzDO3YywOUa9sdMc6M7Mu/GQRndqEiNv6lAlw/Rx2vJ69SftU14BI/7FyKvVj9 /uSejEVcW3KrPYDJAJyYChPMo1COohaJL/FXfRq2f06sB0IBPSkSyKXLV8C/rFTDVb7E WjHNSLL5Ss9dhHvBCzA6nwVi4BQ/020CB2mCBU5FNscWowKriFlIsU05ePAcI11HBhBZ 8EJaMt/LSnFNof7n0feMVm2QdfWC+CGhuNk0uCoYDLrGLAXIEX9D0/LRxoU1O0AF4UA4 kzHj1+GLCmB1fy3OyPTx6ajgae2BTAFMx+usPTXWXhBd7mz+rL1Z/GcPM+49esXseeLB SgmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=IuI8V71Jj+hTTxPmLaVm9RgBYo3XervExPJzr/+wck8=; b=oL7TTvZ8MnH3A0eGix+nqMs/+0M2ladZXXM2mXM+78bJziLnCy5Ronv2K2OoX1ulyX +gE4dicmKzCwtC1rXgR0P2c/iv5Q0Q/xAlDCkDypchSRj3DBouDDDNmW+TV1YdTDox1L k48cAtflmOgRHDaUGljjHhFZDj6P0JSPEqa00JS5cO9dx2SxX95/F4VtOXzBDr5rkFWe 2Oj9MlRBcof+S8VHFIh3frOxlUrQ8vHVJ8qS+uykGPAJUUUdd/3VJvEyqlLWcD3aed18 jk3ZXBrTJyYJ1aNaLXiVgEATtzsQMP0nyYtoa9DfrxXIyFWYKbMMbGVaOXbsA7Kap0/R w0HQ== X-Gm-Message-State: AOAM531f55EtLlEgCgnUElBkBWiYtufxN7V3O6cbyMHdTMqNL9xM+z5c fxK4VV/iXY1f5PJNMIIAAcwqDA== X-Google-Smtp-Source: ABdhPJxfq3NlZYeWiDE5W/APiCzDJdzufksHOX18ryVfGevh4sxLdu17AHeHdIzgstpOHsuJ9Y+KsA== X-Received: by 2002:a05:600c:cc:: with SMTP id u12mr440384wmm.182.1630701108006; Fri, 03 Sep 2021 13:31:48 -0700 (PDT) Subject: Re: [PATCH v3 19/30] target/openrisc: Restrict has_work() handler to sysemu and TCG To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org Cc: Bin Meng , Eduardo Habkost , Greg Kurz , haxm-team@intel.com, Kamil Rytarowski , qemu-ppc@nongnu.org, Anthony Perard , Marcel Apfelbaum , Michael Rolnik , qemu-riscv@nongnu.org, Paolo Bonzini , Jiaxun Yang , Thomas Huth , David Hildenbrand , Chris Wulff , Laurent Vivier , Cameron Esfahani , Sunil Muthuswamy , Max Filippov , Taylor Simpson , qemu-s390x@nongnu.org, Bastian Koppelmann , Yoshinori Sato , Artyom Tarasenko , Aurelien Jarno , Paul Durrant , Peter Maydell , David Gibson , Alistair Francis , "Edgar E. Iglesias" , Roman Bolshakov , Laurent Vivier , Cornelia Huck , qemu-arm@nongnu.org, Wenchao Wang , xen-devel@lists.xenproject.org, Marek Vasut , Stefano Stabellini , Aleksandar Rikalo , Mark Cave-Ayland , Colin Xu , Claudio Fontana , Palmer Dabbelt , Stafford Horne , Reinoud Zandijk , kvm@vger.kernel.org References: <20210902161543.417092-1-f4bug@amsat.org> <20210902161543.417092-20-f4bug@amsat.org> From: Richard Henderson Message-ID: Date: Fri, 3 Sep 2021 22:31:40 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210902161543.417092-20-f4bug@amsat.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit On 9/2/21 6:15 PM, Philippe Mathieu-Daudé wrote: > Restrict has_work() to TCG sysemu. > > Signed-off-by: Philippe Mathieu-Daudé > --- > target/openrisc/cpu.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/target/openrisc/cpu.c b/target/openrisc/cpu.c > index 27cb04152f9..6544b549f12 100644 > --- a/target/openrisc/cpu.c > +++ b/target/openrisc/cpu.c > @@ -30,11 +30,13 @@ static void openrisc_cpu_set_pc(CPUState *cs, vaddr value) > cpu->env.dflag = 0; > } > > +#if defined(CONFIG_TCG) && !defined(CONFIG_USER_ONLY) > static bool openrisc_cpu_has_work(CPUState *cs) No CONFIG_TCG, otherwise, Reviewed-by: Richard Henderson r~ From xen-devel-bounces@lists.xenproject.org Fri Sep 03 20:34:37 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Sep 2021 20:34:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.178444.324446 (Exim 4.92) (envelope-from ) id 1mMFtU-00078Y-RE; Fri, 03 Sep 2021 20:34:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 178444.324446; Fri, 03 Sep 2021 20:34:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMFtU-00078R-O8; Fri, 03 Sep 2021 20:34:36 +0000 Received: by outflank-mailman (input) for mailman id 178444; Fri, 03 Sep 2021 20:34:34 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMFtS-00078L-Or for xen-devel@lists.xenproject.org; Fri, 03 Sep 2021 20:34:34 +0000 Received: from mail-wr1-x42e.google.com (unknown [2a00:1450:4864:20::42e]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 34b6fe07-1500-404c-8bd7-17c66be5d3a3; Fri, 03 Sep 2021 20:34:34 +0000 (UTC) Received: by mail-wr1-x42e.google.com with SMTP id u9so356496wrg.8 for ; Fri, 03 Sep 2021 13:34:33 -0700 (PDT) Received: from [192.168.1.36] (21.red-83-52-55.dynamicip.rima-tde.net. [83.52.55.21]) by smtp.gmail.com with ESMTPSA id d7sm258631wrs.39.2021.09.03.13.34.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Sep 2021 13:34:32 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list X-Inumbo-ID: 34b6fe07-1500-404c-8bd7-17c66be5d3a3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=LFeEcrxPmiQ0y9mkjFms4J4GrCvxgbbAZyrEPk3foT8=; b=blhwVscSGxsnvMX9mpwF1WKnN0xyca3wo+jPJrvx7iJfDyuaVBJ0KE2ZZYoLwyB4Qb 4ovLs/5Mxxmi9wMRp2vY8kz61AoNMdOvCCJQ1ezWt/9nx9cQ0hjn+MeBnxsE8IfF+HWm MRXjSCyRODB4tHb2j9tg9SRHAw9DJhbv0/cKEArMyfVM1qOCRF3s4YzT2Dln7MMoqaZq y6iKsF7H+hxlB36Mu4fKWpUJ5EAdcOvfMVCI3XguqcRlT/JRvp5sK6I5Rgfg+ycwLNfj b/WnJWkRX3vTttRdmBA7xpv8BARViFg/xzi1CERUqrSWq87BIGBc2CT5TLVm4/NdQPul vUWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=LFeEcrxPmiQ0y9mkjFms4J4GrCvxgbbAZyrEPk3foT8=; b=Pg/bU+MXW2o8zWwj3yGcyIdnzQQ8i5zPWyxRRKE23dMRuwTVI3ZWtHqtk2XsF/yHqq 4WYpG3mT/I9G3/llBmkMBsaSNqmRUAGUdTRSGmlLRdVnPyH87XXUbq4/BZpqhmnh2rUe mLn40IKquLmJOmSgmuUfWi+qlfDQI7bZFP0xLBCgapPMvh0VSsffWB3apiaIKhUzWd8k COtMXbG1P9WHRHKK4AM2HwS2vzFt3fVnF7HL5VQ/gO83g3TJWzLvMVByVYTBexKabtnu F5Od49oYqPE/wBczIXlE6LAguGS+jA3G5l7TPqrCKE0FoiSUjWWpMGFvESyC+fWs+GFp 33vA== X-Gm-Message-State: AOAM533TKda7709aZDLiRQy4AdGngZTqIbkWIyAkm/nnW9KLBo7Z74Qb FIWnuq58DHT8g5o23+rk2VA= X-Google-Smtp-Source: ABdhPJzlEMbpTMPYknNobW93n1KQ+VYIJEKgvJhtzWFM57YHy480w/4A7Y7tiGaFvSIUZksLBnn7iw== X-Received: by 2002:adf:804a:: with SMTP id 68mr886849wrk.236.1630701273190; Fri, 03 Sep 2021 13:34:33 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Subject: Re: [PATCH v3 08/30] target/alpha: Restrict has_work() handler to sysemu and TCG To: Richard Henderson , qemu-devel@nongnu.org Cc: Peter Maydell , Cornelia Huck , kvm@vger.kernel.org, David Hildenbrand , Bin Meng , Mark Cave-Ayland , Aleksandar Rikalo , Laurent Vivier , Max Filippov , Taylor Simpson , haxm-team@intel.com, Colin Xu , "Edgar E. Iglesias" , Stafford Horne , Marek Vasut , Stefano Stabellini , Yoshinori Sato , Paul Durrant , Kamil Rytarowski , Reinoud Zandijk , Claudio Fontana , Anthony Perard , xen-devel@lists.xenproject.org, Artyom Tarasenko , Laurent Vivier , Thomas Huth , Eduardo Habkost , Greg Kurz , Cameron Esfahani , qemu-s390x@nongnu.org, qemu-arm@nongnu.org, Michael Rolnik , Sunil Muthuswamy , Palmer Dabbelt , David Gibson , qemu-riscv@nongnu.org, Bastian Koppelmann , Chris Wulff , Roman Bolshakov , qemu-ppc@nongnu.org, Wenchao Wang , Alistair Francis , Paolo Bonzini , Aurelien Jarno References: <20210902161543.417092-1-f4bug@amsat.org> <20210902161543.417092-9-f4bug@amsat.org> <3cd48aba-a1a1-cde3-3175-e9c462fcb220@linaro.org> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Message-ID: <740a2e5c-3dad-fc7d-b54a-0c405faa605e@amsat.org> Date: Fri, 3 Sep 2021 22:34:30 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <3cd48aba-a1a1-cde3-3175-e9c462fcb220@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 9/3/21 10:18 PM, Richard Henderson wrote: > On 9/2/21 6:15 PM, Philippe Mathieu-Daudé wrote: >> Restrict has_work() to TCG sysemu. >> >> Signed-off-by: Philippe Mathieu-Daudé >> --- >>   target/alpha/cpu.c | 4 +++- >>   1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/target/alpha/cpu.c b/target/alpha/cpu.c >> index 93e16a2ffb4..32cf5a2ea9f 100644 >> --- a/target/alpha/cpu.c >> +++ b/target/alpha/cpu.c >> @@ -33,6 +33,7 @@ static void alpha_cpu_set_pc(CPUState *cs, vaddr value) >>       cpu->env.pc = value; >>   } >>   +#if defined(CONFIG_TCG) && !defined(CONFIG_USER_ONLY) >>   static bool alpha_cpu_has_work(CPUState *cs) > > Drop CONFIG_TCG for alpha; it's always true. What is the rational? "Old" architectures (with no active / official hw development) are unlikely to add hardware acceleration, so TCG is the single one possible? Thus no need to clutter the code with obvious #ifdef'ry? > Otherwise, > Reviewed-by: Richard Henderson > > r~ > From xen-devel-bounces@lists.xenproject.org Fri Sep 03 20:38:12 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Sep 2021 20:38:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.178450.324457 (Exim 4.92) (envelope-from ) id 1mMFwv-0007oE-AI; Fri, 03 Sep 2021 20:38:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 178450.324457; Fri, 03 Sep 2021 20:38:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMFwv-0007o7-6B; Fri, 03 Sep 2021 20:38:09 +0000 Received: by outflank-mailman (input) for mailman id 178450; Fri, 03 Sep 2021 20:38:08 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMFwu-0007o1-HC for xen-devel@lists.xenproject.org; Fri, 03 Sep 2021 20:38:08 +0000 Received: from mail-wr1-x42e.google.com (unknown [2a00:1450:4864:20::42e]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id d6addfb9-5549-498b-b27b-2b8be1ab465b; Fri, 03 Sep 2021 20:38:07 +0000 (UTC) Received: by mail-wr1-x42e.google.com with SMTP id b10so429128wru.0 for ; Fri, 03 Sep 2021 13:38:07 -0700 (PDT) Received: from [192.168.1.36] (21.red-83-52-55.dynamicip.rima-tde.net. [83.52.55.21]) by smtp.gmail.com with ESMTPSA id d8sm283071wrv.20.2021.09.03.13.38.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Sep 2021 13:38:06 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list X-Inumbo-ID: d6addfb9-5549-498b-b27b-2b8be1ab465b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=fNIhsoAMPvZrQEmEvDEa/ofLQCAFlDFx6OPwYJbakLA=; b=OL7bcNknLzAqSVlHwkuNrFgmHEdJJTT0ywZpM33E+WzKRYLTjn/SmGnREPXGBif/IU PqPcK3SjLG5eogScB3jtfBXh29opHuqZSJGeNZd9Ke+t/AT5Cr5VwhVWY6Gtra5FS44y zIqcsHP71yoBrqPd/tqJ/b53dF7tqywgJ6KeJPrt2jdTFotMdIWIPMYLMJAvvMhlNjSQ H2ILUDze/pO7mpdvET5jz2pXK4k5IhHgCgzK6c3TFxwQ/zgNvWS7KYfj6KO8XO/AjwPO FYIYxhtgYZeXyzLZ3F3EqMh3ogFwJ5iW7yzCb/zV+nhXKNxtMozTPxiBRByP9xmArzZh 7eKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=fNIhsoAMPvZrQEmEvDEa/ofLQCAFlDFx6OPwYJbakLA=; b=cxEMaYPnkonMt3PmJ7YXDzxmVYiP6gVk7XPAa/XOWjX9Kio7bKVs6D4daS3tCm17ti M2urxuU7iXlRVK0KP351lKoXvuQ9YeaO49bYsSQH0+4Xy/IjbKKyVEe74A+W463c5U/M ozf2lYiF6MOqP+CvOalPBsbVdbaeBLdPy5iz+AiDXV00Es0RIvj40HUzOkw6Fzx6k9xj ujcGqcVyMeoZMgE5DeopaCkAgHKXOBsPmprTZu3hHiDV/e3vd9ZOuJax/PgN1zig3sv3 hjLMg1gIXixJvRDquv9RPowK/kWdSxa1wWhhs1Flc0uvDi4X4XdRzJPo1sZTewk5W+9r JDlg== X-Gm-Message-State: AOAM531ppCrPIIweoaqsr7bxac7SuZ+szL0o/6OEmxJgb4oO0E9kWJW+ g5lzCcx3GYs8nd7sebufCDA= X-Google-Smtp-Source: ABdhPJz6x+pWgErAspkEq96cAfi2JjZZYOWbgKHTQiSSXfqb5WO1BMDSjMrLjiY2+IXe9aaRofWxVQ== X-Received: by 2002:adf:80e5:: with SMTP id 92mr881885wrl.300.1630701486851; Fri, 03 Sep 2021 13:38:06 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Subject: Re: [PATCH v3 21/30] target/ppc: Introduce PowerPCCPUClass::has_work() To: David Gibson Cc: Peter Maydell , Cornelia Huck , kvm@vger.kernel.org, David Hildenbrand , Bin Meng , Mark Cave-Ayland , qemu-devel@nongnu.org, Jiaxun Yang , Laurent Vivier , Max Filippov , Taylor Simpson , haxm-team@intel.com, Colin Xu , Stafford Horne , Marek Vasut , Stefano Stabellini , Yoshinori Sato , Paul Durrant , Kamil Rytarowski , Reinoud Zandijk , Claudio Fontana , Marcel Apfelbaum , Anthony Perard , xen-devel@lists.xenproject.org, Artyom Tarasenko , Laurent Vivier , Thomas Huth , Eduardo Habkost , Richard Henderson , Greg Kurz , Cameron Esfahani , qemu-s390x@nongnu.org, qemu-arm@nongnu.org, Michael Rolnik , Sunil Muthuswamy , Palmer Dabbelt , qemu-riscv@nongnu.org, Bastian Koppelmann , Chris Wulff , Roman Bolshakov , qemu-ppc@nongnu.org, Wenchao Wang , Alistair Francis , Paolo Bonzini , Aleksandar Rikalo , Aurelien Jarno References: <20210902161543.417092-1-f4bug@amsat.org> <20210902161543.417092-22-f4bug@amsat.org> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Message-ID: <1d8ea9ea-dda0-bf0e-a2c8-13d36c891d9c@amsat.org> Date: Fri, 3 Sep 2021 22:38:04 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 8bit On 9/3/21 2:50 AM, David Gibson wrote: > On Thu, Sep 02, 2021 at 06:15:34PM +0200, Philippe Mathieu-Daud wrote: >> Each POWER cpu has its own has_work() implementation. Instead of >> overloading CPUClass on each PowerPCCPUClass init, register the >> generic ppc_cpu_has_work() handler, and have it call the POWER >> specific has_work(). > > I don't quite see the rationale for introducing a second layer of > indirection here. What's wrong with switching the base has_work for > each cpu variant? > >> >> Signed-off-by: Philippe Mathieu-Daud >> --- >> target/ppc/cpu-qom.h | 3 +++ >> target/ppc/cpu_init.c | 26 ++++++++++++++++++-------- >> 2 files changed, 21 insertions(+), 8 deletions(-) >> @@ -8796,6 +8800,12 @@ static bool ppc_cpu_has_work(CPUState *cs) >> PowerPCCPU *cpu = POWERPC_CPU(cs); >> CPUPPCState *env = &cpu->env; >> >> + if (cs->halted) { >> + PowerPCCPUClass *pcc = POWERPC_CPU_GET_CLASS(cpu); Maybe I should have kept the 'if (cs->halted)' for the next patch, simply dispatch here, then in the next patch the code simplification is more apparent. I thought this approach would involve less #ifdef'ry but haven't checked the other way around. Will do now. >> + return pcc->has_work(cs); >> + } >> + >> return msr_ee && (cs->interrupt_request & CPU_INTERRUPT_HARD); >> } >> #endif /* CONFIG_TCG && !CONFIG_USER_ONLY */ > From xen-devel-bounces@lists.xenproject.org Fri Sep 03 20:38:50 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Sep 2021 20:38:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.178454.324468 (Exim 4.92) (envelope-from ) id 1mMFxa-0008Me-LS; Fri, 03 Sep 2021 20:38:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 178454.324468; Fri, 03 Sep 2021 20:38:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMFxa-0008MX-Go; Fri, 03 Sep 2021 20:38:50 +0000 Received: by outflank-mailman (input) for mailman id 178454; Fri, 03 Sep 2021 20:38:49 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMFxZ-0008ML-9W for xen-devel@lists.xenproject.org; Fri, 03 Sep 2021 20:38:49 +0000 Received: from mail-wm1-x333.google.com (unknown [2a00:1450:4864:20::333]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id bc088393-fe84-4f62-bef7-11e0480e6a94; Fri, 03 Sep 2021 20:38:48 +0000 (UTC) Received: by mail-wm1-x333.google.com with SMTP id g138so98139wmg.4 for ; Fri, 03 Sep 2021 13:38:48 -0700 (PDT) Received: from [192.168.8.107] (190.red-2-142-216.dynamicip.rima-tde.net. [2.142.216.190]) by smtp.gmail.com with ESMTPSA id w9sm286608wrs.7.2021.09.03.13.38.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Sep 2021 13:38:47 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bc088393-fe84-4f62-bef7-11e0480e6a94 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=GL9M66YPePviEeJIanaWkTBsfl1Vxvfhn+ruVwm7BCY=; b=M/vaAbEmKAIlbeJ47KCqDEuoW1fU8OLbdaCXy0Pvl+0fPEdToeVM22GDpxEzsjWt9v WbAqalwQ/WT+6kAtmN1B0nIOitKaIhJ157SyDHY79vxDGA3ucdaq3AJgPv1Ovs1Fv/aB 1lSLTga+m6SS4hdqpDGzD3Th0/yrB0aZiBPiOV1Y9NoKc6DtcGD50FEYbqTQdUvsRoIH T4tRlzq2k7HSirKjelg2CrSPUYVuJ22AUaoX7n0jXoOTIEfbt+eiTX7puG0QvsvjemoW Tfwd8Zr/L/8FyDF1XuV7Wb/Ws8ZaMEPMWJ3/JlWVrBtMcJoHyoGb+mo3WTtGcH+kKg2w oQuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=GL9M66YPePviEeJIanaWkTBsfl1Vxvfhn+ruVwm7BCY=; b=qKhVfiRINwUR4SOv/yzH2Z5s8oTD+UQbZOcUBILm+Ggn9srTEzYNXaTPv72fhfmujn +R20a5MNP7NATCtlI4IR+rCn7wQa5pZi1gJQBC/Ulz79In4B0WRZODTtvDXd6rzexRaB 5B12Hoa/dlCAwk2n8BuS1vTPB1Gu6VAjjGG5sVVU4YqnqMzipdhGoskDvZMIRlVlB2SQ wbvX9/+Cm5GWFpgLtB9fB+VA0ihdN72HigNg5bY04eb6dfG6fHvnZTZllaqM9D0it3Cm /Eh3dX3EilkqkaAKMgbLEHrp2hPoqZ9D+lMJ19qkLcBL3uTQnNgnFcCfALh+E2ElqOLE Gfww== X-Gm-Message-State: AOAM5302iAA3z3G09/oMnf/b4ouYV6nBjN9rOp/F96B2qz/3NoVjWrmN ga0P0XM3A/u0jkNQU4zlgyBvAg== X-Google-Smtp-Source: ABdhPJyQ/VEZImP2sey8PyCscUHWehgMFHJDN9IuQ3kxtIigmhduRyDKYPM4Bvm1IEM1SgOYGjMY+A== X-Received: by 2002:a1c:2547:: with SMTP id l68mr468593wml.23.1630701527658; Fri, 03 Sep 2021 13:38:47 -0700 (PDT) Subject: Re: [PATCH v3 08/30] target/alpha: Restrict has_work() handler to sysemu and TCG To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org Cc: Peter Maydell , Cornelia Huck , kvm@vger.kernel.org, David Hildenbrand , Bin Meng , Mark Cave-Ayland , Aleksandar Rikalo , Laurent Vivier , Max Filippov , Taylor Simpson , haxm-team@intel.com, Colin Xu , "Edgar E. Iglesias" , Stafford Horne , Marek Vasut , Stefano Stabellini , Yoshinori Sato , Paul Durrant , Kamil Rytarowski , Reinoud Zandijk , Claudio Fontana , Anthony Perard , xen-devel@lists.xenproject.org, Artyom Tarasenko , Laurent Vivier , Thomas Huth , Eduardo Habkost , Greg Kurz , Cameron Esfahani , qemu-s390x@nongnu.org, qemu-arm@nongnu.org, Michael Rolnik , Sunil Muthuswamy , Palmer Dabbelt , David Gibson , qemu-riscv@nongnu.org, Bastian Koppelmann , Chris Wulff , Roman Bolshakov , qemu-ppc@nongnu.org, Wenchao Wang , Alistair Francis , Paolo Bonzini , Aurelien Jarno References: <20210902161543.417092-1-f4bug@amsat.org> <20210902161543.417092-9-f4bug@amsat.org> <3cd48aba-a1a1-cde3-3175-e9c462fcb220@linaro.org> <740a2e5c-3dad-fc7d-b54a-0c405faa605e@amsat.org> From: Richard Henderson Message-ID: <8c70c273-cb11-c6da-a456-c906df86326b@linaro.org> Date: Fri, 3 Sep 2021 22:38:40 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <740a2e5c-3dad-fc7d-b54a-0c405faa605e@amsat.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit On 9/3/21 10:34 PM, Philippe Mathieu-Daudé wrote: >> Drop CONFIG_TCG for alpha; it's always true. > > What is the rational? "Old" architectures (with no active / > official hw development) are unlikely to add hardware > acceleration, so TCG is the single one possible? Thus no > need to clutter the code with obvious #ifdef'ry? Correct. Broadly, if git grep CONFIG_TCG is empty in a subdirectory, don't add the first instance. r~ From xen-devel-bounces@lists.xenproject.org Fri Sep 03 20:42:14 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Sep 2021 20:42:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.178462.324479 (Exim 4.92) (envelope-from ) id 1mMG0r-0001dt-6T; Fri, 03 Sep 2021 20:42:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 178462.324479; Fri, 03 Sep 2021 20:42:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMG0r-0001dm-3T; Fri, 03 Sep 2021 20:42:13 +0000 Received: by outflank-mailman (input) for mailman id 178462; Fri, 03 Sep 2021 20:42:11 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMG0p-0001df-66 for xen-devel@lists.xenproject.org; Fri, 03 Sep 2021 20:42:11 +0000 Received: from mail-wm1-x334.google.com (unknown [2a00:1450:4864:20::334]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id da4756ff-0aeb-4025-b282-098aaafd534c; Fri, 03 Sep 2021 20:42:10 +0000 (UTC) Received: by mail-wm1-x334.google.com with SMTP id k20-20020a05600c0b5400b002e87ad6956eso337030wmr.1 for ; Fri, 03 Sep 2021 13:42:10 -0700 (PDT) Received: from [192.168.8.107] (190.red-2-142-216.dynamicip.rima-tde.net. [2.142.216.190]) by smtp.gmail.com with ESMTPSA id y15sm462739wmi.18.2021.09.03.13.42.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Sep 2021 13:42:09 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: da4756ff-0aeb-4025-b282-098aaafd534c DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=KO1an/5CmjrwEhdc2mhCZ+S9p7TgIYwX9ZNZ9M9TFAE=; b=cu2bS4up1KUaZFvfqZzOd2qoAgEXmB9czyJg7Ld9C9RhrRFPlF7SwFqEwPUxttKJHP I1xS+ex3bHbMetfNUUCLVWvrfESiUFlOEywVjEsNBviabapOnUNOdhvyN9zKTl2NKPkI oFLzpz1YOXk4f6pHR/sY67Y1o2wn+XVbP1qwIi2sdi5BDgf0tM7J6FGdCmto3LcLIaIX PKJGhIKO37mpf5Ce+QN4EnowFcFFR+4AUTl4t3FVeWIkVZSObVUv39QZ23RCI1PJPmoc scHBKkHA2wztn0q+7QOHwGhnRETaGgrejgdp9/upgRUBCHz7lFrOigJB0pB0zh/LJOTn XY+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=KO1an/5CmjrwEhdc2mhCZ+S9p7TgIYwX9ZNZ9M9TFAE=; b=rW5bDh5BEYvzpFSqTiNxiPUrF10e0Glnf1w6pgIG+YyqFBNzDc26ktLQBh7epeATzQ dWedb90fHZdJPAUuggHZwYUzuHaBl7LjZ1eL0c4XwmVibqiraFukMkmyf1XlKIrRsEyw pVcaqBdmpAus5WlPzFlW+QnbruDtzSBUce/g8pTNJrWqajLOfgjW6oOxXcIU++LXhW4C 6tMVQJAmXTx97W+scJg3OBKeUwU8sSy2WLEA782aWIQNVWZiemJE0vGKdGYicFYJnGlz TOG2rwpHOpnro/Qnm4WsPk08Ej2JknrsTzYm5BOnvboI2rGP5TQTspVGnX+ZhR1Thbt5 tKaQ== X-Gm-Message-State: AOAM532aSHLlx8q7bXWkWzTNr3itEXkO6HnFLaKSg9o6OxBfi+qiHq0b SACAoPpZfgWpr9IjAQOFPPuKrw== X-Google-Smtp-Source: ABdhPJwceVbbv7hWOXS37awGetSIGUJik1eFEfP7Dd+3VwgeGBrwgNpP3UDG2KidWTsBePHMk6Y+ng== X-Received: by 2002:a05:600c:a08:: with SMTP id z8mr522391wmp.165.1630701729599; Fri, 03 Sep 2021 13:42:09 -0700 (PDT) Subject: Re: [PATCH v3 21/30] target/ppc: Introduce PowerPCCPUClass::has_work() To: David Gibson , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Cc: qemu-devel@nongnu.org, Bin Meng , Eduardo Habkost , Greg Kurz , haxm-team@intel.com, Kamil Rytarowski , qemu-ppc@nongnu.org, Anthony Perard , Marcel Apfelbaum , Michael Rolnik , qemu-riscv@nongnu.org, Paolo Bonzini , Jiaxun Yang , Thomas Huth , David Hildenbrand , Chris Wulff , Laurent Vivier , Cameron Esfahani , Sunil Muthuswamy , Max Filippov , Taylor Simpson , qemu-s390x@nongnu.org, Bastian Koppelmann , Yoshinori Sato , Artyom Tarasenko , Aurelien Jarno , Paul Durrant , Peter Maydell , Alistair Francis , "Edgar E. Iglesias" , Roman Bolshakov , Laurent Vivier , Cornelia Huck , qemu-arm@nongnu.org, Wenchao Wang , xen-devel@lists.xenproject.org, Marek Vasut , Stefano Stabellini , Aleksandar Rikalo , Mark Cave-Ayland , Colin Xu , Claudio Fontana , Palmer Dabbelt , Stafford Horne , Reinoud Zandijk , kvm@vger.kernel.org References: <20210902161543.417092-1-f4bug@amsat.org> <20210902161543.417092-22-f4bug@amsat.org> From: Richard Henderson Message-ID: Date: Fri, 3 Sep 2021 22:42:02 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit On 9/3/21 2:50 AM, David Gibson wrote: > On Thu, Sep 02, 2021 at 06:15:34PM +0200, Philippe Mathieu-Daudé wrote: >> Each POWER cpu has its own has_work() implementation. Instead of >> overloading CPUClass on each PowerPCCPUClass init, register the >> generic ppc_cpu_has_work() handler, and have it call the POWER >> specific has_work(). > > I don't quite see the rationale for introducing a second layer of > indirection here. What's wrong with switching the base has_work for > each cpu variant? We're moving the hook from CPUState to TCGCPUOps. Phil was trying to avoid creating N versions of static const struct TCGCPUOps ppc_tcg_ops = { ... }; A plausible alternative is to remove the const from this struct and modify it, just as we do for CPUState, on the assumption that we cannot mix and match ppc cpu types in any one machine. r~ From xen-devel-bounces@lists.xenproject.org Fri Sep 03 20:43:23 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Sep 2021 20:43:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.178468.324490 (Exim 4.92) (envelope-from ) id 1mMG1w-0002F5-Fm; Fri, 03 Sep 2021 20:43:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 178468.324490; Fri, 03 Sep 2021 20:43:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMG1w-0002Ey-Cl; Fri, 03 Sep 2021 20:43:20 +0000 Received: by outflank-mailman (input) for mailman id 178468; Fri, 03 Sep 2021 20:43:18 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMG1u-0002Eq-CB for xen-devel@lists.xenproject.org; Fri, 03 Sep 2021 20:43:18 +0000 Received: from mail-wm1-x330.google.com (unknown [2a00:1450:4864:20::330]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 9533dc19-474a-4853-bf2c-4538a46493f5; Fri, 03 Sep 2021 20:43:17 +0000 (UTC) Received: by mail-wm1-x330.google.com with SMTP id k20-20020a05600c0b5400b002e87ad6956eso338365wmr.1 for ; Fri, 03 Sep 2021 13:43:17 -0700 (PDT) Received: from [192.168.8.107] (190.red-2-142-216.dynamicip.rima-tde.net. [2.142.216.190]) by smtp.gmail.com with ESMTPSA id w9sm294701wrs.7.2021.09.03.13.43.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Sep 2021 13:43:16 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9533dc19-474a-4853-bf2c-4538a46493f5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=vBLdwX3ZChNXVS/9UqNF4wJjMelZK55qA391msJX3qU=; b=sz9KbnkkagCr/GFF3OMVQhtS6VhgzaCiOfnUEvPJVL2O8jwbbscHft/H9IJkpP0NsU TGizEk76lcvi8mLRugPLNXDpebTnYO3vqlZQK48MJI9TPSqJFF4fhUuswhN7CqY2Ghwk 3vqpHJ2pzTxkD4Alw5fP1VVDaMLadtQr5cqiT1MBE/uvf9J116rMMc6TMrhbx3UMJdIj /DMhuBGeqgleldVui5C3jsYuqvxxkrLkQtp2u6KAbqe0LNNwZJBYdNlmGqmCrDRJX6/D H9oo/QoelvlvKhE6ZH5vxKSx6LJafL8LYNlCMQZjRXX4mct49OSCXeOxBiNBVInXZevi wD3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=vBLdwX3ZChNXVS/9UqNF4wJjMelZK55qA391msJX3qU=; b=IGpODACODIJ3dZm2I+T70rRofLkXDfd2xpYoMVIFs6gbDugYFXzWCJNXmIz3HRqfbG QXjMkPP3Ftc0MauyCmX3gpWR0ELoUfseqIR0FN/CdFLIB3HnjxSS4Eh62x8PzCQdgSY5 g+TmDiltFFtOYQQJuRj+sZ7M5bq3atmKOD5r74Ns1swHO6v9o9x8NQOWv8PKLP5RXDyU fqtaY01oJ4QyaWiptVMr+SnTy9E1Sa+NwF3oi+WmgvtJa6HtUTzBN24QtQ1w3K9n+G4i boTe96ruzos1hf8ETLkpDAN9xpxe9gVescIyEupNcCQINrbVHUYHJ9IU1jo4bQ/C9ykZ zuTg== X-Gm-Message-State: AOAM532fiBvjkt8ZPHjqNJdwLG9km+wG1O/+kGZSJDeLsN32fTXHLw1f C9zVh8HV+umkfe3YwRz+YJVhPA== X-Google-Smtp-Source: ABdhPJyTwcg40ZXBf0kRQeFkHvEtxWVastgigZVfDdU3EBMLa1vjXC+xX2MEzRyEH8NNNNiGPWLbnA== X-Received: by 2002:a1c:1c2:: with SMTP id 185mr479522wmb.11.1630701796724; Fri, 03 Sep 2021 13:43:16 -0700 (PDT) Subject: Re: [PATCH v3 22/30] target/ppc: Simplify has_work() handlers To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org Cc: Bin Meng , Eduardo Habkost , Greg Kurz , haxm-team@intel.com, Kamil Rytarowski , qemu-ppc@nongnu.org, Anthony Perard , Marcel Apfelbaum , Michael Rolnik , qemu-riscv@nongnu.org, Paolo Bonzini , Jiaxun Yang , Thomas Huth , David Hildenbrand , Chris Wulff , Laurent Vivier , Cameron Esfahani , Sunil Muthuswamy , Max Filippov , Taylor Simpson , qemu-s390x@nongnu.org, Bastian Koppelmann , Yoshinori Sato , Artyom Tarasenko , Aurelien Jarno , Paul Durrant , Peter Maydell , David Gibson , Alistair Francis , "Edgar E. Iglesias" , Roman Bolshakov , Laurent Vivier , Cornelia Huck , qemu-arm@nongnu.org, Wenchao Wang , xen-devel@lists.xenproject.org, Marek Vasut , Stefano Stabellini , Aleksandar Rikalo , Mark Cave-Ayland , Colin Xu , Claudio Fontana , Palmer Dabbelt , Stafford Horne , Reinoud Zandijk , kvm@vger.kernel.org References: <20210902161543.417092-1-f4bug@amsat.org> <20210902161543.417092-23-f4bug@amsat.org> From: Richard Henderson Message-ID: <007f0874-b82f-5853-0c08-00528fb22bcb@linaro.org> Date: Fri, 3 Sep 2021 22:43:03 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210902161543.417092-23-f4bug@amsat.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit On 9/2/21 6:15 PM, Philippe Mathieu-Daudé wrote: > The common ppc_cpu_has_work() handler already checks for cs->halted, > so we can simplify all callees. > > Signed-off-by: Philippe Mathieu-Daudé > --- > target/ppc/cpu_init.c | 294 ++++++++++++++++++++---------------------- > 1 file changed, 138 insertions(+), 156 deletions(-) Well, I'm not actually a fan of this; I'd rather the outer function merely dispatch here, or preferably arrange to arrive here to begin. r~ From xen-devel-bounces@lists.xenproject.org Fri Sep 03 20:43:42 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Sep 2021 20:43:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.178472.324501 (Exim 4.92) (envelope-from ) id 1mMG2I-0002nR-Qh; Fri, 03 Sep 2021 20:43:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 178472.324501; Fri, 03 Sep 2021 20:43:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMG2I-0002nI-Lo; Fri, 03 Sep 2021 20:43:42 +0000 Received: by outflank-mailman (input) for mailman id 178472; Fri, 03 Sep 2021 20:43:42 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMG2I-0002kD-8E for xen-devel@lists.xenproject.org; Fri, 03 Sep 2021 20:43:42 +0000 Received: from mail-wr1-x432.google.com (unknown [2a00:1450:4864:20::432]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 1d463abf-0a47-4652-abe6-62e2ce844bab; Fri, 03 Sep 2021 20:43:37 +0000 (UTC) Received: by mail-wr1-x432.google.com with SMTP id u9so381612wrg.8 for ; Fri, 03 Sep 2021 13:43:37 -0700 (PDT) Received: from [192.168.8.107] (190.red-2-142-216.dynamicip.rima-tde.net. [2.142.216.190]) by smtp.gmail.com with ESMTPSA id d7sm274068wrs.39.2021.09.03.13.43.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Sep 2021 13:43:36 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1d463abf-0a47-4652-abe6-62e2ce844bab DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=OCS3x2IM2IhJ7L7NOzo3OsfaFZSDUFR4VR+0j8dzaJ0=; b=H8ozIcixUveIbw9k7stg4KdS0gx7rTV2e5s41Gx6botMrAh8hYIIWhIu+AvbtT54dW Tl8+brbL8I6gSbmldeLB6TkvxB9mAloeVrSwAdDFUCxAz3A9ONWLJnZnRcf7/3YYCKiI mKw5CM9pdGmfYUyVULTwZdtG4Zo2cC0TJu5c2IH8dI7SsNAjx2c3JA5uxkgkaF3syZYO bS8qs1qwUmnUfdlgL3bsdR1L8kzzDcc0saGHUOJA/DshHL9WLii6vhGNcqmBnmKhwPEJ E/skqUuaJ6aFM7UfknaO/MQDQsX7XIC1JB3/bhICCmdu8qPCP1VV/4dZA8n9iYUOsjZI 4+YQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=OCS3x2IM2IhJ7L7NOzo3OsfaFZSDUFR4VR+0j8dzaJ0=; b=khCrd3B+fHgkXT2gYGCyZ9w9hPNKH7udY4YcW+II0FWD1TvL/RLybLD4wzx+w12gjx CHz1Fm8LD5NCfOsUy5PRpUg7OoJEBNasV1XAtm5TO/8Uy66ysTbXdzZsf5ye2AGWn6lM g8KZKa6VDrYVrZoxcbkFVu56T77s1CosjOLXDAdqiOmVRdY7Pkf4ybOrJv0xoDfYjTwf py+keLyShGyHVBqpinZ6sycMd5obKrc/OylDwyRKRfraRmAEbeOSq86xdAjiXBRbOYUr ehXlE3y4YYxkGARVwluyCX9+wCJVQp9dawNBLAYIkZKlV252bPxSAVOzUymu+A2oq7vK YCkA== X-Gm-Message-State: AOAM531Viow/P47ksqMXyaudtnJPTaK9G14E3xs/cwaOJuihD7C/CLJT 6B2UdmoJw9MbSEnvkxPjuvRvWQ== X-Google-Smtp-Source: ABdhPJzDzA0nqf/Zf1bg1Haee/zHM2hXytKc0QH8nIr2MjWxDRi+4jQmQKWadcbSkZgCEwSPJcyooA== X-Received: by 2002:adf:eac3:: with SMTP id o3mr939918wrn.60.1630701816896; Fri, 03 Sep 2021 13:43:36 -0700 (PDT) Subject: Re: [PATCH v3 23/30] target/riscv: Restrict has_work() handler to sysemu and TCG To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org Cc: Bin Meng , Eduardo Habkost , Greg Kurz , haxm-team@intel.com, Kamil Rytarowski , qemu-ppc@nongnu.org, Anthony Perard , Marcel Apfelbaum , Michael Rolnik , qemu-riscv@nongnu.org, Paolo Bonzini , Jiaxun Yang , Thomas Huth , David Hildenbrand , Chris Wulff , Laurent Vivier , Cameron Esfahani , Sunil Muthuswamy , Max Filippov , Taylor Simpson , qemu-s390x@nongnu.org, Bastian Koppelmann , Yoshinori Sato , Artyom Tarasenko , Aurelien Jarno , Paul Durrant , Peter Maydell , David Gibson , Alistair Francis , "Edgar E. Iglesias" , Roman Bolshakov , Laurent Vivier , Cornelia Huck , qemu-arm@nongnu.org, Wenchao Wang , xen-devel@lists.xenproject.org, Marek Vasut , Stefano Stabellini , Aleksandar Rikalo , Mark Cave-Ayland , Colin Xu , Claudio Fontana , Palmer Dabbelt , Stafford Horne , Reinoud Zandijk , kvm@vger.kernel.org References: <20210902161543.417092-1-f4bug@amsat.org> <20210902161543.417092-24-f4bug@amsat.org> From: Richard Henderson Message-ID: <56180d64-090a-1f6f-5c0a-22387c8a2af5@linaro.org> Date: Fri, 3 Sep 2021 22:43:29 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210902161543.417092-24-f4bug@amsat.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit On 9/2/21 6:15 PM, Philippe Mathieu-Daudé wrote: > Restrict has_work() to TCG sysemu. > > Signed-off-by: Philippe Mathieu-Daudé > --- > target/riscv/cpu.c | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) Reviewed-by: Richard Henderson r~ From xen-devel-bounces@lists.xenproject.org Fri Sep 03 20:44:09 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Sep 2021 20:44:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.178479.324512 (Exim 4.92) (envelope-from ) id 1mMG2j-0003NU-3t; Fri, 03 Sep 2021 20:44:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 178479.324512; Fri, 03 Sep 2021 20:44:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMG2i-0003NN-W7; Fri, 03 Sep 2021 20:44:08 +0000 Received: by outflank-mailman (input) for mailman id 178479; Fri, 03 Sep 2021 20:44:07 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMG2h-0003N3-PF for xen-devel@lists.xenproject.org; Fri, 03 Sep 2021 20:44:07 +0000 Received: from mail-wr1-x42a.google.com (unknown [2a00:1450:4864:20::42a]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id f1d3555d-3435-4062-8bcf-9affcb3d7dc5; Fri, 03 Sep 2021 20:44:07 +0000 (UTC) Received: by mail-wr1-x42a.google.com with SMTP id q11so381219wrr.9 for ; Fri, 03 Sep 2021 13:44:07 -0700 (PDT) Received: from [192.168.8.107] (190.red-2-142-216.dynamicip.rima-tde.net. [2.142.216.190]) by smtp.gmail.com with ESMTPSA id h16sm264457wre.52.2021.09.03.13.44.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Sep 2021 13:44:05 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f1d3555d-3435-4062-8bcf-9affcb3d7dc5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=kHY8X+3WAxrdeSKfSV5cKvDPcFHMSr1zqsSabCFDuj4=; b=y2JE2znGpCHgDzsU2I9wK0RJ8GE2JJWPW9THeKM+zR9sq8qQv438t3kOx206Jt2Fg9 HCBj4K5J9LrMW8VCOyReTekXa1iDDwX12LjR7w51Hp6FgTpMfV7mK57QPRaKgTN+mKSM c4ydaiundmZ/zqYpEcQ7fTBQRpS/g1xvCPjoSorsUTdNxikH8pbFeAJIqDRqkEeBcdOc o6bXO2ZIp6ZGu2T9H1FE0GxSedCTSSR2B/P/X59CRLG9yK22Gt+PLAznez/m/7vmSLM1 nNLeBSmIfDEWuEX2lL68vLI9//wt72neSXBsIxn05T13a5hBYl9JWV1zFbdtz3FU6mYb fpgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=kHY8X+3WAxrdeSKfSV5cKvDPcFHMSr1zqsSabCFDuj4=; b=tnF7QaEAcubsueSkXIe4fv9uWUBpEY9UmErJYaO2zYb8OWuj+KDsHuQXmii6QrV9/p JpXpzn8P2prkRKJt+QoiOcHt7/iX05bkPf0l3QGV0A0UmRTYuAQoubLtlUMfljFLMZcN p2E76z1u7IsjdKawthLGN207k6hvesVwPtM3yjohl3VqBTR3mW0ZH/At6an52bvWNdli gIbtN5JOcbdd3ZLD/UnA01E+sA5YHttbMpzwtuNJ35HsVa91pwSYc+O6j8+yU57rb1+7 NKZ69eXjPzE3c8+FYFAqvz8JDishDve3K4NkqQyBHPBe3isnroJu3cU5nOahUda/k1ut eU7g== X-Gm-Message-State: AOAM5301doh9a0MYtX0WEU7xIN0vtznE2nJ5tUvJqbjYzy/isU8LqdBl Q5nw23gDRcQy+mwGADZJEjekDQ== X-Google-Smtp-Source: ABdhPJwF66mC8rAdAxTJMbRm7Tnb/TmgI1HpOm8MMDv09XxJRL4qVfHzOz4F+luA4Rwup1L4RWjtvA== X-Received: by 2002:a5d:6ac7:: with SMTP id u7mr889163wrw.390.1630701846250; Fri, 03 Sep 2021 13:44:06 -0700 (PDT) Subject: Re: [PATCH v3 20/30] target/ppc: Restrict has_work() handler to sysemu and TCG To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org Cc: Bin Meng , Eduardo Habkost , Greg Kurz , haxm-team@intel.com, Kamil Rytarowski , qemu-ppc@nongnu.org, Anthony Perard , Marcel Apfelbaum , Michael Rolnik , qemu-riscv@nongnu.org, Paolo Bonzini , Jiaxun Yang , Thomas Huth , David Hildenbrand , Chris Wulff , Laurent Vivier , Cameron Esfahani , Sunil Muthuswamy , Max Filippov , Taylor Simpson , qemu-s390x@nongnu.org, Bastian Koppelmann , Yoshinori Sato , Artyom Tarasenko , Aurelien Jarno , Paul Durrant , Peter Maydell , David Gibson , Alistair Francis , "Edgar E. Iglesias" , Roman Bolshakov , Laurent Vivier , Cornelia Huck , qemu-arm@nongnu.org, Wenchao Wang , xen-devel@lists.xenproject.org, Marek Vasut , Stefano Stabellini , Aleksandar Rikalo , Mark Cave-Ayland , Colin Xu , Claudio Fontana , Palmer Dabbelt , Stafford Horne , Reinoud Zandijk , kvm@vger.kernel.org References: <20210902161543.417092-1-f4bug@amsat.org> <20210902161543.417092-21-f4bug@amsat.org> From: Richard Henderson Message-ID: <860bd94b-89ce-3aa1-4c8b-b53e4d83b80f@linaro.org> Date: Fri, 3 Sep 2021 22:43:59 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210902161543.417092-21-f4bug@amsat.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit On 9/2/21 6:15 PM, Philippe Mathieu-Daudé wrote: > Restrict has_work() to TCG sysemu. > > Signed-off-by: Philippe Mathieu-Daudé > --- > target/ppc/cpu_init.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) Reviewed-by: Richard Henderson r~ From xen-devel-bounces@lists.xenproject.org Fri Sep 03 20:44:35 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Sep 2021 20:44:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.178486.324523 (Exim 4.92) (envelope-from ) id 1mMG39-0003y4-Bd; Fri, 03 Sep 2021 20:44:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 178486.324523; Fri, 03 Sep 2021 20:44:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMG39-0003xx-8b; Fri, 03 Sep 2021 20:44:35 +0000 Received: by outflank-mailman (input) for mailman id 178486; Fri, 03 Sep 2021 20:44:33 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMG37-0003vk-PE for xen-devel@lists.xenproject.org; Fri, 03 Sep 2021 20:44:33 +0000 Received: from mail-wr1-x430.google.com (unknown [2a00:1450:4864:20::430]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id f17a0e54-f5d3-418e-ad55-3ab4e9f433c2; Fri, 03 Sep 2021 20:44:30 +0000 (UTC) Received: by mail-wr1-x430.google.com with SMTP id g18so370577wrc.11 for ; Fri, 03 Sep 2021 13:44:30 -0700 (PDT) Received: from [192.168.8.107] (190.red-2-142-216.dynamicip.rima-tde.net. [2.142.216.190]) by smtp.gmail.com with ESMTPSA id c24sm280794wrb.57.2021.09.03.13.44.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Sep 2021 13:44:29 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f17a0e54-f5d3-418e-ad55-3ab4e9f433c2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=KQ6VNEDT2RTSrtudl0wF85JMAcGQkDFdqJ9dexlByDI=; b=j0YbQMDCCUEbh8WfA/4C6tjTCZz5YVgUlnkvm7vBt137y8oCJJCgceYmnd1W45xDsj fH2oliFfUD9c9XqutLEe1u5GTFJ6NAM0xeLY5W7fHmz3N4JrZIxA65d+kOsL2+ohTMMZ pz2NWVSauNgwHAR9TfxgbMUUxFdzWPsbV7R8NCfsWMr3X1UEPkWtchjxP20wvoSCi3RN 2F0iPe5rDeOWIgYfpiwvyG9SdVoyXltSrkbqSEyUhJSapGdh1kKfq26I6utdBnwZlpAN hMZ0E1VMPwkZiA/nmt6T74JUpWM/2vzkg/YXgRLLDqbAk0z+L4XVz0pmGyj5wrmMUf7O sEtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=KQ6VNEDT2RTSrtudl0wF85JMAcGQkDFdqJ9dexlByDI=; b=puG1glLUZzKB8V3FIux5L6bUK8HHumPi9yZ8qzNMK9flFQSP6UIFOlbLX+fs0ljBek QGoew9tq2IsLIIn4RU/5V+YflecudxjS5gMf10K9wyAA16WMCen9RhwZfXA/Wv6/IKZc IfMXNWCE2OJse24oD0GUYpMgOOoCo6u4W/I/R3uq7Wxh3ON7H7WUfEkyyaykPXFjOPIj O4MoKQvAxZ2oT31nUOtPYhmZeNmp2h1AY6wlG47MlO6awvAs71AhDAIjX4drfYaCyuAi 3VE7fTUnN0YAmggDwNg0PCwgmmvWEaEmINo2MGQDQaOHUlJKnYkZQxqm2xTkmv30haDn ir3g== X-Gm-Message-State: AOAM5334zDmhmaeSQZBgD+WRZ4w8o3VJfekJmhfKId0QChVz2B6atj5n mK16K1nwPyUeyFbf/Ig9IJQjTw== X-Google-Smtp-Source: ABdhPJz3eHG2XBUgqkGosMAvUqwA6yjsJz1vhZ/AXgPH+VG7PO6AKFhg7sg0B/HYBLrKSYyiTUNh5w== X-Received: by 2002:adf:b789:: with SMTP id s9mr857553wre.315.1630701869461; Fri, 03 Sep 2021 13:44:29 -0700 (PDT) Subject: Re: [PATCH v3 24/30] target/rx: Restrict has_work() handler to sysemu and TCG To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org Cc: Bin Meng , Eduardo Habkost , Greg Kurz , haxm-team@intel.com, Kamil Rytarowski , qemu-ppc@nongnu.org, Anthony Perard , Marcel Apfelbaum , Michael Rolnik , qemu-riscv@nongnu.org, Paolo Bonzini , Jiaxun Yang , Thomas Huth , David Hildenbrand , Chris Wulff , Laurent Vivier , Cameron Esfahani , Sunil Muthuswamy , Max Filippov , Taylor Simpson , qemu-s390x@nongnu.org, Bastian Koppelmann , Yoshinori Sato , Artyom Tarasenko , Aurelien Jarno , Paul Durrant , Peter Maydell , David Gibson , Alistair Francis , "Edgar E. Iglesias" , Roman Bolshakov , Laurent Vivier , Cornelia Huck , qemu-arm@nongnu.org, Wenchao Wang , xen-devel@lists.xenproject.org, Marek Vasut , Stefano Stabellini , Aleksandar Rikalo , Mark Cave-Ayland , Colin Xu , Claudio Fontana , Palmer Dabbelt , Stafford Horne , Reinoud Zandijk , kvm@vger.kernel.org References: <20210902161543.417092-1-f4bug@amsat.org> <20210902161543.417092-25-f4bug@amsat.org> From: Richard Henderson Message-ID: <5f0e217b-2580-49b5-5cee-61d8ab41d706@linaro.org> Date: Fri, 3 Sep 2021 22:44:22 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210902161543.417092-25-f4bug@amsat.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit On 9/2/21 6:15 PM, Philippe Mathieu-Daudé wrote: > Restrict has_work() to TCG sysemu. > > Signed-off-by: Philippe Mathieu-Daudé > --- > target/rx/cpu.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/target/rx/cpu.c b/target/rx/cpu.c > index 25a4aa2976d..0d0cf6f9028 100644 > --- a/target/rx/cpu.c > +++ b/target/rx/cpu.c > @@ -41,11 +41,13 @@ static void rx_cpu_synchronize_from_tb(CPUState *cs, > cpu->env.pc = tb->pc; > } > > +#if defined(CONFIG_TCG) && !defined(CONFIG_USER_ONLY) > static bool rx_cpu_has_work(CPUState *cs) No CONFIG_TCG, otherwise, Reviewed-by: Richard Henderson r~ From xen-devel-bounces@lists.xenproject.org Fri Sep 03 20:48:44 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Sep 2021 20:48:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.178494.324534 (Exim 4.92) (envelope-from ) id 1mMG74-0004pF-22; Fri, 03 Sep 2021 20:48:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 178494.324534; Fri, 03 Sep 2021 20:48:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMG73-0004p8-Uc; Fri, 03 Sep 2021 20:48:37 +0000 Received: by outflank-mailman (input) for mailman id 178494; Fri, 03 Sep 2021 20:48:36 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMG71-0004ox-Uy for xen-devel@lists.xenproject.org; Fri, 03 Sep 2021 20:48:36 +0000 Received: from mail-wr1-x42a.google.com (unknown [2a00:1450:4864:20::42a]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id cbd8ebd2-f9d7-4f70-b376-9c2795757b2f; Fri, 03 Sep 2021 20:48:34 +0000 (UTC) Received: by mail-wr1-x42a.google.com with SMTP id x6so372036wrv.13 for ; Fri, 03 Sep 2021 13:48:34 -0700 (PDT) Received: from [192.168.8.107] (190.red-2-142-216.dynamicip.rima-tde.net. [2.142.216.190]) by smtp.gmail.com with ESMTPSA id t23sm273507wrb.71.2021.09.03.13.48.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Sep 2021 13:48:33 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cbd8ebd2-f9d7-4f70-b376-9c2795757b2f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=JR2N3hW+DAAOOkmrYLuui81slBAvGFUWkGnERbEB/4A=; b=oIoi1f5ZWFOc0RmycwGdPB1omD0xRAxTNPvzzN59dsRqEHrjnFus9NLUNjhn6i17pj ivO2uKGYQ/5srtBFw7S7dxLFCPr0Dg84Ff6W1/9vJTqoS6LzG+xh4J2hCztqivPqnava u/7bE8JnlgID+82FLwTwyyj/Qz3U6Qik1/Tf5wLbcyLfdBYFCdE7+xNUeGNupoQceOtK DuiPtlLD47X/8EiY6wq+LG78nSM5X+oluNwRPdUvyRQTAk0pPxYuJQ+0FSqNABy+klPa /Gw/OIgSOH/QuL9vGuSTxQAkWanGr1FY2e4K3sb0MB5auKQ+KdAP6aCeWBFl5rG2tuai 4CPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=JR2N3hW+DAAOOkmrYLuui81slBAvGFUWkGnERbEB/4A=; b=R4VRmijr0Yo1qLLJ+affaxnJgfi6/TS8eNggVwo2P2usLW2mAd9Re8ol84KRTjFA5V uQyo9aZ9CPBdVRwFN/5t/nPRRWVidA9k1sFKPUr2YkmmS2C56Jd8xxtq3noEyCFjEL4w tvDTNZaOGXIlDgGbSCuEC4MM3FhAJmQytFTUvfWbFenkZ63UxpXxLnasHB95ESA/bWcu FzOy9BtMws46TEruYQqtATHJVcArlbxzAIYqiuXryf6QOo1GSX4W7KbSFQVPu0uwejEu Vb1+fyu/O52J0aMy7C/zg7OHuV9OlR/uToJLhI2OTltd/OooXRXvh1jXrp5aSRp/qp91 wrVA== X-Gm-Message-State: AOAM533mF7xGV4iAT81N1LiQIwe6oiDubNQ8+PWrxxFdUmengaGTpEgp UsviioydSIKTAO+UYh0KZSRrPoZRGyF8cPxyLXU= X-Google-Smtp-Source: ABdhPJwYxL1wBdNoflELnyXgoIfkyp1X+C47Clew7iV3DpVZ/QyfLSQUi3F7MAdXmgdYugc/uDUBHg== X-Received: by 2002:adf:e6c5:: with SMTP id y5mr908323wrm.198.1630702113942; Fri, 03 Sep 2021 13:48:33 -0700 (PDT) Subject: Re: [PATCH v3 30/30] accel: Add missing AccelOpsClass::has_work() and drop SysemuCPUOps one To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org Cc: Anthony Perard , Cameron Esfahani , Claudio Fontana , Colin Xu , Eduardo Habkost , haxm-team@intel.com, Kamil Rytarowski , Laurent Vivier , Paolo Bonzini , Paul Durrant , Reinoud Zandijk , Roman Bolshakov , Stefano Stabellini , Thomas Huth , Wenchao Wang , xen-devel@lists.xenproject.org References: <20210902161543.417092-1-f4bug@amsat.org> <20210903181943.763360-1-f4bug@amsat.org> From: Richard Henderson Message-ID: <5b1a24c2-cdd6-ec88-d0d8-540bf5f96c38@linaro.org> Date: Fri, 3 Sep 2021 22:48:28 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210903181943.763360-1-f4bug@amsat.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit On 9/3/21 8:19 PM, Philippe Mathieu-Daudé wrote: > cpu_common_has_work() is the default has_work() implementation > and returns 'false'. > > Explicit it for the QTest / HAX / HVF / NVMM / Xen accelerators > and remove cpu_common_has_work(). > > Since there are no more implementations of SysemuCPUOps::has_work, > remove it along with the assertion in cpu_has_work(). > > Signed-off-by: Philippe Mathieu-Daudé > --- > include/hw/core/cpu.h | 2 -- > accel/hvf/hvf-accel-ops.c | 6 ++++++ > accel/qtest/qtest.c | 6 ++++++ > accel/xen/xen-all.c | 6 ++++++ > hw/core/cpu-common.c | 6 ------ > softmmu/cpus.c | 9 ++------- > target/i386/hax/hax-accel-ops.c | 6 ++++++ > target/i386/nvmm/nvmm-accel-ops.c | 6 ++++++ > 8 files changed, 32 insertions(+), 15 deletions(-) Reviewed-by: Richard Henderson r~ From xen-devel-bounces@lists.xenproject.org Fri Sep 03 21:11:57 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Sep 2021 21:11:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.178503.324545 (Exim 4.92) (envelope-from ) id 1mMGTX-0008Vt-Ta; Fri, 03 Sep 2021 21:11:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 178503.324545; Fri, 03 Sep 2021 21:11:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMGTX-0008Vm-QI; Fri, 03 Sep 2021 21:11:51 +0000 Received: by outflank-mailman (input) for mailman id 178503; Fri, 03 Sep 2021 21:11:51 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMGTX-0008Vg-0W for xen-devel@lists.xenproject.org; Fri, 03 Sep 2021 21:11:51 +0000 Received: from mail-wr1-x434.google.com (unknown [2a00:1450:4864:20::434]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id bd593490-6877-4ccb-b84e-dcd243829007; Fri, 03 Sep 2021 21:11:50 +0000 (UTC) Received: by mail-wr1-x434.google.com with SMTP id b6so457037wrh.10 for ; Fri, 03 Sep 2021 14:11:50 -0700 (PDT) Received: from [192.168.1.36] (21.red-83-52-55.dynamicip.rima-tde.net. [83.52.55.21]) by smtp.gmail.com with ESMTPSA id s205sm411532wme.4.2021.09.03.14.11.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Sep 2021 14:11:48 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list X-Inumbo-ID: bd593490-6877-4ccb-b84e-dcd243829007 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=jI43SKJbesP12DNmL3/e0Usr50r2XgSNCcYV6kiyq6k=; b=XH5LRShQJoZBhky3eh03Pmb9SkQ32XBteRsyogRiPstHFr6orcBCJeqTh6+8uA9Ugj hwUHRkbv3Iki29kH6SULZWWaPVeHLm9dOZGMJp/KvL+iV9qeA3IsgO7aPDi6dPOxdM5Q ws2BSkCdqzZ3QGSkRU4XFRPZC9C8RO5eAPwO0xHZyZ51hswyi5ZlgnIK0hazE40GI5Vy pDzx5Z2/NQxO+YOF01K7Wot3MRs8tFcfTdIvEFWt3PL9aHwjDLKgNplb2i8xQwHyzDKi JVFun0OPCzM5tItFSKRVH8Yfw5eizrEfOkYRFD8WnJK9txMG72i4kstdXmKL8/qxt3TH 7oMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=jI43SKJbesP12DNmL3/e0Usr50r2XgSNCcYV6kiyq6k=; b=QaLqBsoiTZipwKiltx1WkeslU9Yq6UFpgzyQKEmB+fEoCphbc271rGkjP2E4uNqdTo vSfOiEFzaBOTrc31aM/n66Q7+Nmu68ezfX9SoK0IPnovXrs8h/5o7D2GA87TBNTmXP+f 1Npht6E1mnD0c0PNNzGtg0WeWcMT/NSLFiEpM6QRw4FXFvmNhBB2lBS5yekOaTKOTOzH LwAdxNCs1Lj1L5Bv6O59FfKGU7byDaUkfvBPehqZz+VxmHbgZc+WycBzBi8RVXgFmGZm RSWfh0RZKj0swin51jmJQCrUzs62UghacP4hicwY4Fg2wXnh1fVgaWGL67wJkRLD33kI y11w== X-Gm-Message-State: AOAM5314DauI7bUhWK3I/wPgPN1hoDv7LxLkE0kxhgHIw3bxLbLARYPF 8jv5tukkhhtsr6fsF9sthfU= X-Google-Smtp-Source: ABdhPJx9z+1i4IwrqpeoM/m67lAEAeVLF6XhWOMCvs9W+7ge742xu6/mLFLJYvAuNvjtGUuedCA5Yg== X-Received: by 2002:a5d:40d1:: with SMTP id b17mr974069wrq.47.1630703509319; Fri, 03 Sep 2021 14:11:49 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Subject: Re: [PATCH v3 21/30] target/ppc: Introduce PowerPCCPUClass::has_work() To: Richard Henderson , David Gibson , =?UTF-8?Q?C=c3=a9dric_Le_Goater?= , Greg Kurz Cc: Peter Maydell , Cornelia Huck , kvm@vger.kernel.org, David Hildenbrand , Bin Meng , Mark Cave-Ayland , qemu-devel@nongnu.org, Jiaxun Yang , Laurent Vivier , Max Filippov , Taylor Simpson , haxm-team@intel.com, Colin Xu , Stafford Horne , Marek Vasut , Stefano Stabellini , Yoshinori Sato , Paul Durrant , Kamil Rytarowski , Reinoud Zandijk , Claudio Fontana , Marcel Apfelbaum , Anthony Perard , xen-devel@lists.xenproject.org, Artyom Tarasenko , Laurent Vivier , Thomas Huth , Eduardo Habkost , Greg Kurz , Cameron Esfahani , qemu-s390x@nongnu.org, qemu-arm@nongnu.org, Michael Rolnik , Sunil Muthuswamy , Palmer Dabbelt , qemu-riscv@nongnu.org, Bastian Koppelmann , Chris Wulff , Roman Bolshakov , qemu-ppc@nongnu.org, Wenchao Wang , Alistair Francis , Paolo Bonzini , Aleksandar Rikalo , Aurelien Jarno References: <20210902161543.417092-1-f4bug@amsat.org> <20210902161543.417092-22-f4bug@amsat.org> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Message-ID: Date: Fri, 3 Sep 2021 23:11:46 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 9/3/21 10:42 PM, Richard Henderson wrote: > On 9/3/21 2:50 AM, David Gibson wrote: >> On Thu, Sep 02, 2021 at 06:15:34PM +0200, Philippe Mathieu-Daudé wrote: >>> Each POWER cpu has its own has_work() implementation. Instead of >>> overloading CPUClass on each PowerPCCPUClass init, register the >>> generic ppc_cpu_has_work() handler, and have it call the POWER >>> specific has_work(). >> >> I don't quite see the rationale for introducing a second layer of >> indirection here.  What's wrong with switching the base has_work for >> each cpu variant? > > We're moving the hook from CPUState to TCGCPUOps. > Phil was trying to avoid creating N versions of > > static const struct TCGCPUOps ppc_tcg_ops = { >     ... > }; Ah yes this is the reason! Too many context switching so I forgot about it. > A plausible alternative is to remove the const from this struct and > modify it, just as we do for CPUState, on the assumption that we cannot > mix and match ppc cpu types in any one machine. I thought about this case and remembered how it works on the ARM arch, i.e. ZynqMP machine uses both Cortex-R5F and Cortex-A53. Even if no similar PPC machine exists, IMHO we should try to generally allow to possibility to experiment machine with different CPUs. Restricting it on PPC goes the other way around. Thoughts? From xen-devel-bounces@lists.xenproject.org Fri Sep 03 21:24:57 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Sep 2021 21:24:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.178509.324556 (Exim 4.92) (envelope-from ) id 1mMGg2-0001mV-4F; Fri, 03 Sep 2021 21:24:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 178509.324556; Fri, 03 Sep 2021 21:24:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMGg2-0001mO-0T; Fri, 03 Sep 2021 21:24:46 +0000 Received: by outflank-mailman (input) for mailman id 178509; Fri, 03 Sep 2021 21:24:45 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMGg1-0001mE-4n; Fri, 03 Sep 2021 21:24:45 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMGg0-0005Wh-To; Fri, 03 Sep 2021 21:24:44 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMGg0-00056A-Ij; Fri, 03 Sep 2021 21:24:44 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mMGg0-0007C3-Ht; Fri, 03 Sep 2021 21:24:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=tiBMzIEwgeeuAYbfzs9FxQCxkvjLao1jbvXSqezZC2s=; b=sXGHIOkIKVwMBdEVYmM03H9ykc wPoqjPOGtQjqH3ugxSa6bOr7yNKL4JdvgQATV1k+hBxH4Zjlaq1eShyLzoX/rSe+HNh23m69OxgZP qwy5DesM8JEi9vGJVmwXy9xenscLMeRVn/JmTsPIKOJYI2iW1lOd/S25Tn/ghYRI0fsw=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 164793: tolerable FAIL - PUSHED X-Osstest-Failures: linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=c6bf0ed9d1a727fcd98f6a52bbdd2afbdfb44924 X-Osstest-Versions-That: linux=fd80923202c6bfd723742fc32426a7aa3632abaa From: osstest service owner Date: Fri, 03 Sep 2021 21:24:44 +0000 flight 164793 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/164793/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 164501 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 164501 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 164501 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 164501 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 164501 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 164501 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 164501 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 164501 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 164501 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 164501 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 164501 test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: linux c6bf0ed9d1a727fcd98f6a52bbdd2afbdfb44924 baseline version: linux fd80923202c6bfd723742fc32426a7aa3632abaa Last test of basis 164501 2021-08-26 13:42:10 Z 8 days Testing same since 164793 2021-09-03 08:40:28 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Adrian Hunter Anand Jain Andrew Morton Andrey Ignatov Andrii Nakryiko Ariel Elior Ben Skeggs Bjorn Andersson Christophe JAILLET Colin Ian King Daniel Borkmann David S. Miller David Sterba DENG Qingfang Denis Efremov Dvora Fuxbrumer Felipe Balbi Filipe Manana Florian Fainelli Florian Westphal Gal Pressman Gerd Rausch Greg Kroah-Hartman Guangbin Huang Guenter Roeck Guojia Liao Hannes Frederic Sowa Helge Deller Hulk Robot Ingo Molnar Jakub Kicinski Jason Gunthorpe Jason Wang Jerome Brunet Johan Hovold John Harrison Jon Hunter Kefeng Wang Li Jinlin Linus Torvalds Linux Kernel Functional Testing Marc Kleine-Budde Mark Yacoub Mark Yacoub Martin K. Petersen Martin KaFai Lau Matthew Brost Maxim Kiselev Michael S. Tsirkin Michal Hocko Michał Mirosław Mike Marciniszyn Miklos Szeredi Naresh Kamboju Naresh Kumar PBS Neeraj Upadhyay Pablo Neira Ayuso Paolo Bonzini Parav Pandit Paul Moore Peter Collingbourne Peter Zijlstra (Intel) Petr Vorel Qiu Laibin Qu Wenruo Rafael David Tinoco Richard Guy Briggs Rodrigo Vivi Salil Mehta Santosh Shilimkar Sasha Levin Sasha Neftin Sean Christopherson Sean Paul Selvin Xavier Shai Malin Shaik Sajida Bhanu Shreyansh Chouhan Shuah Khan Stefan Mätje Sudip Mukherjee Sudip Mukherjee Thinh Nguyen Tony Nguyen Tuo Li Ulf Hansson Vineet Gupta Viresh Kumar Wesley Cheng Xiaolong Huang Yafang Shao Yufeng Mo Zhengjun Zhang jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git fd80923202c6..c6bf0ed9d1a7 c6bf0ed9d1a727fcd98f6a52bbdd2afbdfb44924 -> tested/linux-5.4 From xen-devel-bounces@lists.xenproject.org Fri Sep 03 22:48:24 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Sep 2021 22:48:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.178519.324581 (Exim 4.92) (envelope-from ) id 1mMHyq-0002rF-UN; Fri, 03 Sep 2021 22:48:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 178519.324581; Fri, 03 Sep 2021 22:48:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMHyq-0002r6-R7; Fri, 03 Sep 2021 22:48:16 +0000 Received: by outflank-mailman (input) for mailman id 178519; Fri, 03 Sep 2021 22:48:15 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMHyp-0002qd-Dr for xen-devel@lists.xenproject.org; Fri, 03 Sep 2021 22:48:15 +0000 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id ce82eaaf-8eab-471f-a37c-8c963c90fb6d; Fri, 03 Sep 2021 22:48:14 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 2E3A461056; Fri, 3 Sep 2021 22:48:13 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ce82eaaf-8eab-471f-a37c-8c963c90fb6d DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1630709293; bh=D3TKVtXRF0k7je6UxI5S91fhLgoCCJ2RQ6UxqDcfnA0=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=SkypW8AB/LVsQX17U1lF7SVw119y3enF4tgUOj0R9Ry6KSegHjQD8hwpTTFwdOaUU un4idD6fP73zahznH66T7Ttc4KYexYORWAREKHoUinVaBaTD4N6s9pzlHv0o+q6naS DT7wsA/SfsTq6uAShajW2T/029Oad7O+x53oVLdUBPJvKFtlbxel2L8K96MZRNzrbl ei1etvyU4SHPo06FUYuSPu5RUTzFqgXmoLRsuFEhIJhTuPvJix6yJRIrcynrCZEWXP Wx4yteW+qD7zfaNDvymFB2LbgpiAb784I8xB7Jy3St2jYZDjgJ1xBiE6XI/0CqiNHU 0JF7uH5/SSwHw== Date: Fri, 3 Sep 2021 15:48:12 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: Bertrand Marquis cc: xen-devel@lists.xenproject.org, Stefano Stabellini , Julien Grall , Volodymyr Babchuk Subject: Re: [PATCH v3 3/7] xen/arm: Rename cpu_boot_data to system_cpuinfo In-Reply-To: <588f4cdd02ce3f907c4b97b1513d90f153d127c0.1629897306.git.bertrand.marquis@arm.com> Message-ID: References: <588f4cdd02ce3f907c4b97b1513d90f153d127c0.1629897306.git.bertrand.marquis@arm.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Wed, 25 Aug 2021, Bertrand Marquis wrote: > As we will sanitize the content of boot_cpu_data it will not really > contain the boot cpu information but the system sanitize information. > Rename the structure to system_cpuinfo so the user is informed that this > is the system wide available feature and not anymore the features of the > boot cpu. > The original boot cpu data is still available in cpu_data. > > Signed-off-by: Bertrand Marquis Reviewed-by: Stefano Stabellini > --- > Changes in v3: none > Changes in v2: > - patch introduced in v2 > --- > xen/arch/arm/cpufeature.c | 8 ++------ > xen/arch/arm/setup.c | 34 ++++++++++++++++++-------------- > xen/arch/arm/smpboot.c | 6 +++--- > xen/include/asm-arm/cpufeature.h | 6 +++--- > 4 files changed, 27 insertions(+), 27 deletions(-) > > diff --git a/xen/arch/arm/cpufeature.c b/xen/arch/arm/cpufeature.c > index 1d88783809..f600a611bd 100644 > --- a/xen/arch/arm/cpufeature.c > +++ b/xen/arch/arm/cpufeature.c > @@ -169,12 +169,8 @@ void identify_cpu(struct cpuinfo_arm *c) > */ > static int __init create_guest_cpuinfo(void) > { > - /* > - * TODO: The code is currently using only the features detected on the boot > - * core. In the long term we should try to compute values containing only > - * features supported by all cores. > - */ > - guest_cpuinfo = boot_cpu_data; > + /* Use the sanitized cpuinfo as initial guest cpuinfo */ > + guest_cpuinfo = system_cpuinfo; > > #ifdef CONFIG_ARM_64 > /* Hide MPAM support as xen does not support it */ > diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c > index 63a908e325..3798c5ade0 100644 > --- a/xen/arch/arm/setup.c > +++ b/xen/arch/arm/setup.c > @@ -56,7 +56,11 @@ > > struct bootinfo __initdata bootinfo; > > -struct cpuinfo_arm __read_mostly boot_cpu_data; > +/* > + * Sanitized version of cpuinfo containing only features available on all > + * cores (only on arm64 as there is no sanitization support on arm32). > + */ > +struct cpuinfo_arm __read_mostly system_cpuinfo; > > #ifdef CONFIG_ACPI > bool __read_mostly acpi_disabled; > @@ -100,7 +104,7 @@ static const char * __initdata processor_implementers[] = { > static void __init processor_id(void) > { > const char *implementer = "Unknown"; > - struct cpuinfo_arm *c = &boot_cpu_data; > + struct cpuinfo_arm *c = &system_cpuinfo; > > identify_cpu(c); > current_cpu_data = *c; > @@ -120,7 +124,7 @@ static void __init processor_id(void) > #if defined(CONFIG_ARM_64) > printk("64-bit Execution:\n"); > printk(" Processor Features: %016"PRIx64" %016"PRIx64"\n", > - boot_cpu_data.pfr64.bits[0], boot_cpu_data.pfr64.bits[1]); > + system_cpuinfo.pfr64.bits[0], system_cpuinfo.pfr64.bits[1]); > printk(" Exception Levels: EL3:%s EL2:%s EL1:%s EL0:%s\n", > cpu_has_el3_32 ? "64+32" : cpu_has_el3_64 ? "64" : "No", > cpu_has_el2_32 ? "64+32" : cpu_has_el2_64 ? "64" : "No", > @@ -144,13 +148,13 @@ static void __init processor_id(void) > boot_cpu_feature64(simd)); > > printk(" Debug Features: %016"PRIx64" %016"PRIx64"\n", > - boot_cpu_data.dbg64.bits[0], boot_cpu_data.dbg64.bits[1]); > + system_cpuinfo.dbg64.bits[0], system_cpuinfo.dbg64.bits[1]); > printk(" Auxiliary Features: %016"PRIx64" %016"PRIx64"\n", > - boot_cpu_data.aux64.bits[0], boot_cpu_data.aux64.bits[1]); > + system_cpuinfo.aux64.bits[0], system_cpuinfo.aux64.bits[1]); > printk(" Memory Model Features: %016"PRIx64" %016"PRIx64"\n", > - boot_cpu_data.mm64.bits[0], boot_cpu_data.mm64.bits[1]); > + system_cpuinfo.mm64.bits[0], system_cpuinfo.mm64.bits[1]); > printk(" ISA Features: %016"PRIx64" %016"PRIx64"\n", > - boot_cpu_data.isa64.bits[0], boot_cpu_data.isa64.bits[1]); > + system_cpuinfo.isa64.bits[0], system_cpuinfo.isa64.bits[1]); > #endif > > /* > @@ -161,7 +165,7 @@ static void __init processor_id(void) > { > printk("32-bit Execution:\n"); > printk(" Processor Features: %"PRIregister":%"PRIregister"\n", > - boot_cpu_data.pfr32.bits[0], boot_cpu_data.pfr32.bits[1]); > + system_cpuinfo.pfr32.bits[0], system_cpuinfo.pfr32.bits[1]); > printk(" Instruction Sets:%s%s%s%s%s%s\n", > cpu_has_aarch32 ? " AArch32" : "", > cpu_has_arm ? " A32" : "", > @@ -174,18 +178,18 @@ static void __init processor_id(void) > cpu_has_security ? " Security" : ""); > > printk(" Debug Features: %"PRIregister"\n", > - boot_cpu_data.dbg32.bits[0]); > + system_cpuinfo.dbg32.bits[0]); > printk(" Auxiliary Features: %"PRIregister"\n", > - boot_cpu_data.aux32.bits[0]); > + system_cpuinfo.aux32.bits[0]); > printk(" Memory Model Features: %"PRIregister" %"PRIregister"\n" > " %"PRIregister" %"PRIregister"\n", > - boot_cpu_data.mm32.bits[0], boot_cpu_data.mm32.bits[1], > - boot_cpu_data.mm32.bits[2], boot_cpu_data.mm32.bits[3]); > + system_cpuinfo.mm32.bits[0], system_cpuinfo.mm32.bits[1], > + system_cpuinfo.mm32.bits[2], system_cpuinfo.mm32.bits[3]); > printk(" ISA Features: %"PRIregister" %"PRIregister" %"PRIregister"\n" > " %"PRIregister" %"PRIregister" %"PRIregister"\n", > - boot_cpu_data.isa32.bits[0], boot_cpu_data.isa32.bits[1], > - boot_cpu_data.isa32.bits[2], boot_cpu_data.isa32.bits[3], > - boot_cpu_data.isa32.bits[4], boot_cpu_data.isa32.bits[5]); > + system_cpuinfo.isa32.bits[0], system_cpuinfo.isa32.bits[1], > + system_cpuinfo.isa32.bits[2], system_cpuinfo.isa32.bits[3], > + system_cpuinfo.isa32.bits[4], system_cpuinfo.isa32.bits[5]); > } > else > { > diff --git a/xen/arch/arm/smpboot.c b/xen/arch/arm/smpboot.c > index a1ee3146ef..c9f2827d56 100644 > --- a/xen/arch/arm/smpboot.c > +++ b/xen/arch/arm/smpboot.c > @@ -124,7 +124,7 @@ static void __init dt_smp_init_cpus(void) > bool bootcpu_valid = false; > int rc; > > - mpidr = boot_cpu_data.mpidr.bits & MPIDR_HWID_MASK; > + mpidr = system_cpuinfo.mpidr.bits & MPIDR_HWID_MASK; > > if ( !cpus ) > { > @@ -319,13 +319,13 @@ void start_secondary(void) > * now. > */ > if ( !opt_hmp_unsafe && > - current_cpu_data.midr.bits != boot_cpu_data.midr.bits ) > + current_cpu_data.midr.bits != system_cpuinfo.midr.bits ) > { > printk(XENLOG_ERR > "CPU%u MIDR (0x%"PRIregister") does not match boot CPU MIDR (0x%"PRIregister"),\n" > XENLOG_ERR "disable cpu (see big.LITTLE.txt under docs/).\n", > smp_processor_id(), current_cpu_data.midr.bits, > - boot_cpu_data.midr.bits); > + system_cpuinfo.midr.bits); > stop_cpu(); > } > > diff --git a/xen/include/asm-arm/cpufeature.h b/xen/include/asm-arm/cpufeature.h > index ba48db3eac..8f2b8e7830 100644 > --- a/xen/include/asm-arm/cpufeature.h > +++ b/xen/include/asm-arm/cpufeature.h > @@ -3,7 +3,7 @@ > > #ifdef CONFIG_ARM_64 > #define cpu_feature64(c, feat) ((c)->pfr64.feat) > -#define boot_cpu_feature64(feat) (boot_cpu_data.pfr64.feat) > +#define boot_cpu_feature64(feat) (system_cpuinfo.pfr64.feat) > > #define cpu_feature64_has_el0_32(c) (cpu_feature64(c, el0) == 2) > > @@ -21,7 +21,7 @@ > #endif > > #define cpu_feature32(c, feat) ((c)->pfr32.feat) > -#define boot_cpu_feature32(feat) (boot_cpu_data.pfr32.feat) > +#define boot_cpu_feature32(feat) (system_cpuinfo.pfr32.feat) > > #define cpu_has_arm (boot_cpu_feature32(arm) == 1) > #define cpu_has_thumb (boot_cpu_feature32(thumb) >= 1) > @@ -326,7 +326,7 @@ struct cpuinfo_arm { > } mvfr; > }; > > -extern struct cpuinfo_arm boot_cpu_data; > +extern struct cpuinfo_arm system_cpuinfo; > > extern void identify_cpu(struct cpuinfo_arm *); > > -- > 2.17.1 > From xen-devel-bounces@lists.xenproject.org Fri Sep 03 22:48:24 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Sep 2021 22:48:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.178518.324570 (Exim 4.92) (envelope-from ) id 1mMHym-0002aR-HY; Fri, 03 Sep 2021 22:48:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 178518.324570; Fri, 03 Sep 2021 22:48:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMHym-0002aK-Dx; Fri, 03 Sep 2021 22:48:12 +0000 Received: by outflank-mailman (input) for mailman id 178518; Fri, 03 Sep 2021 22:48:11 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMHyk-0002aC-Rx for xen-devel@lists.xenproject.org; Fri, 03 Sep 2021 22:48:11 +0000 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 017ea770-0d09-11ec-af6a-12813bfff9fa; Fri, 03 Sep 2021 22:48:07 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id BC8D360FA0; Fri, 3 Sep 2021 22:48:06 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 017ea770-0d09-11ec-af6a-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1630709286; bh=x4cpnhoGOcwYa/KDT85UxSjYeA5q7x+4pHkzioVIWUE=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=omdgbZWN7MZn9RXb8n1wdxKN10lRQvX0T5sfAokOgcVw2KiZAS3DT85I9Q/LACyvU RmE/GpyIFQ7ABm7HZVeo7sV7GybnTdZc1jDWSe1JYna3ubRYmOiZhdPWUx1nVP4Q07 GW3jLHMCmMzN8KA/LN2c62RaqVgKNIHCKvWIU7+SZycQV1ejsXnuok+rwQLhEYGKUj vP35gH872y6lYXB5c88tbjRFxhrWNZYz1bqOaXPijY+rm0kstAiD7dwSmWO493bGMQ Hl8bDpu7XRvOhkGCKrLLCx62dEG6euaOHHC2LuZM0ANnoQUkiL6nRWQ8pcSzSTzvSo mjlNDrdGzdrJA== Date: Fri, 3 Sep 2021 15:48:06 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: Bertrand Marquis cc: xen-devel@lists.xenproject.org, Stefano Stabellini , Julien Grall , Volodymyr Babchuk Subject: Re: [PATCH v3 2/7] xen/arm: Import ID features sanitize from linux In-Reply-To: <61de0ae1aaec35cb32f0ec2ead6ce9c4c6ef154e.1629897306.git.bertrand.marquis@arm.com> Message-ID: References: <61de0ae1aaec35cb32f0ec2ead6ce9c4c6ef154e.1629897306.git.bertrand.marquis@arm.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Wed, 25 Aug 2021, Bertrand Marquis wrote: > Import structures declared in Linux file arch/arm64/kernel/cpufeature.c > and the required types from arch/arm64/include/asm/cpufeature.h. > > Current code has been imported from Linux 5.13-rc5 (Commit ID > cd1245d75ce93b8fd206f4b34eb58bcfe156d5e9) and copied into cpufeature.c > in arm64 code and cpufeature.h in arm64 specific headers. > > Those structure will be used to sanitize the cpu features available to > the ones availble on all cores of a system even if we are on an > heterogeneous platform (from example a big/LITTLE). > > For each feature field of all ID registers, those structures define what > is the safest value and if we can allow to have different values in > different cores. > > This patch is introducing Linux code without any changes to it. > > Signed-off-by: Bertrand Marquis Reviewed-by: Stefano Stabellini > --- > Changes in v3: none > Changes in v2: > - Move add to Makefile to following patch to allow bisection > - Remove GPL text as SPDL is there > - Re-add introduction comment from Linux Kernel file > - Rename cpusanitize.c to cpufeature.c to keep Linux file name > - Move structures imported from linux headers into a new cpufeature.h > header in asm-arm/arm64. > - Move comment about imported code origin to the file header > - Remove not needed linux function declarations instead of removing them > in the following patch > - Add original arm64_ftr_safe_value from Linux > - include kernel.h to use max() > - remove unused ftr_single32 as we will not use it > - remove ctr associated structures that we cannot use (keep the one > defining sanitization bits) > --- > xen/arch/arm/arm64/cpufeature.c | 504 +++++++++++++++++++++++++ > xen/include/asm-arm/arm64/cpufeature.h | 104 +++++ > 2 files changed, 608 insertions(+) > create mode 100644 xen/arch/arm/arm64/cpufeature.c > create mode 100644 xen/include/asm-arm/arm64/cpufeature.h > > diff --git a/xen/arch/arm/arm64/cpufeature.c b/xen/arch/arm/arm64/cpufeature.c > new file mode 100644 > index 0000000000..5777e33e5c > --- /dev/null > +++ b/xen/arch/arm/arm64/cpufeature.c > @@ -0,0 +1,504 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/* > + * Contains CPU feature definitions > + * > + * The following structures have been imported directly from Linux kernel and > + * should be kept in sync. > + * The current version has been imported from arch/arm64/kernel/cpufeature.c > + * from kernel version 5.13-rc5 together with the required structures and > + * macros from arch/arm64/include/asm/cpufeature.h which are stored in > + * include/asm-arm/arm64/cpufeature.h > + * > + * Copyright (C) 2021 Arm Ltd. > + * based on code from the Linux kernel, which is: > + * Copyright (C) 2015 ARM Ltd. > + * > + * A note for the weary kernel hacker: the code here is confusing and hard to > + * follow! That's partly because it's solving a nasty problem, but also because > + * there's a little bit of over-abstraction that tends to obscure what's going > + * on behind a maze of helper functions and macros. > + * > + * The basic problem is that hardware folks have started gluing together CPUs > + * with distinct architectural features; in some cases even creating SoCs where > + * user-visible instructions are available only on a subset of the available > + * cores. We try to address this by snapshotting the feature registers of the > + * boot CPU and comparing these with the feature registers of each secondary > + * CPU when bringing them up. If there is a mismatch, then we update the > + * snapshot state to indicate the lowest-common denominator of the feature, > + * known as the "safe" value. This snapshot state can be queried to view the > + * "sanitised" value of a feature register. > + * > + * The sanitised register values are used to decide which capabilities we > + * have in the system. These may be in the form of traditional "hwcaps" > + * advertised to userspace or internal "cpucaps" which are used to configure > + * things like alternative patching and static keys. While a feature mismatch > + * may result in a TAINT_CPU_OUT_OF_SPEC kernel taint, a capability mismatch > + * may prevent a CPU from being onlined at all. > + * > + * Some implementation details worth remembering: > + * > + * - Mismatched features are *always* sanitised to a "safe" value, which > + * usually indicates that the feature is not supported. > + * > + * - A mismatched feature marked with FTR_STRICT will cause a "SANITY CHECK" > + * warning when onlining an offending CPU and the kernel will be tainted > + * with TAINT_CPU_OUT_OF_SPEC. > + * > + * - Features marked as FTR_VISIBLE have their sanitised value visible to > + * userspace. FTR_VISIBLE features in registers that are only visible > + * to EL0 by trapping *must* have a corresponding HWCAP so that late > + * onlining of CPUs cannot lead to features disappearing at runtime. > + * > + * - A "feature" is typically a 4-bit register field. A "capability" is the > + * high-level description derived from the sanitised field value. > + * > + * - Read the Arm ARM (DDI 0487F.a) section D13.1.3 ("Principles of the ID > + * scheme for fields in ID registers") to understand when feature fields > + * may be signed or unsigned (FTR_SIGNED and FTR_UNSIGNED accordingly). > + * > + * - KVM exposes its own view of the feature registers to guest operating > + * systems regardless of FTR_VISIBLE. This is typically driven from the > + * sanitised register values to allow virtual CPUs to be migrated between > + * arbitrary physical CPUs, but some features not present on the host are > + * also advertised and emulated. Look at sys_reg_descs[] for the gory > + * details. > + * > + * - If the arm64_ftr_bits[] for a register has a missing field, then this > + * field is treated as STRICT RES0, including for read_sanitised_ftr_reg(). > + * This is stronger than FTR_HIDDEN and can be used to hide features from > + * KVM guests. > + */ > + > +#include > +#include > +#include > +#include > +#include > + > +#define __ARM64_FTR_BITS(SIGNED, VISIBLE, STRICT, TYPE, SHIFT, WIDTH, SAFE_VAL) \ > + { \ > + .sign = SIGNED, \ > + .visible = VISIBLE, \ > + .strict = STRICT, \ > + .type = TYPE, \ > + .shift = SHIFT, \ > + .width = WIDTH, \ > + .safe_val = SAFE_VAL, \ > + } > + > +/* Define a feature with unsigned values */ > +#define ARM64_FTR_BITS(VISIBLE, STRICT, TYPE, SHIFT, WIDTH, SAFE_VAL) \ > + __ARM64_FTR_BITS(FTR_UNSIGNED, VISIBLE, STRICT, TYPE, SHIFT, WIDTH, SAFE_VAL) > + > +/* Define a feature with a signed value */ > +#define S_ARM64_FTR_BITS(VISIBLE, STRICT, TYPE, SHIFT, WIDTH, SAFE_VAL) \ > + __ARM64_FTR_BITS(FTR_SIGNED, VISIBLE, STRICT, TYPE, SHIFT, WIDTH, SAFE_VAL) > + > +#define ARM64_FTR_END \ > + { \ > + .width = 0, \ > + } > + > +/* > + * NOTE: Any changes to the visibility of features should be kept in > + * sync with the documentation of the CPU feature register ABI. > + */ > +static const struct arm64_ftr_bits ftr_id_aa64isar0[] = { > + ARM64_FTR_BITS(FTR_VISIBLE, FTR_STRICT, FTR_LOWER_SAFE, ID_AA64ISAR0_RNDR_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_AA64ISAR0_TLB_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_VISIBLE, FTR_STRICT, FTR_LOWER_SAFE, ID_AA64ISAR0_TS_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_VISIBLE, FTR_STRICT, FTR_LOWER_SAFE, ID_AA64ISAR0_FHM_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_VISIBLE, FTR_STRICT, FTR_LOWER_SAFE, ID_AA64ISAR0_DP_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_VISIBLE, FTR_STRICT, FTR_LOWER_SAFE, ID_AA64ISAR0_SM4_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_VISIBLE, FTR_STRICT, FTR_LOWER_SAFE, ID_AA64ISAR0_SM3_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_VISIBLE, FTR_STRICT, FTR_LOWER_SAFE, ID_AA64ISAR0_SHA3_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_VISIBLE, FTR_STRICT, FTR_LOWER_SAFE, ID_AA64ISAR0_RDM_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_VISIBLE, FTR_STRICT, FTR_LOWER_SAFE, ID_AA64ISAR0_ATOMICS_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_VISIBLE, FTR_STRICT, FTR_LOWER_SAFE, ID_AA64ISAR0_CRC32_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_VISIBLE, FTR_STRICT, FTR_LOWER_SAFE, ID_AA64ISAR0_SHA2_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_VISIBLE, FTR_STRICT, FTR_LOWER_SAFE, ID_AA64ISAR0_SHA1_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_VISIBLE, FTR_STRICT, FTR_LOWER_SAFE, ID_AA64ISAR0_AES_SHIFT, 4, 0), > + ARM64_FTR_END, > +}; > + > +static const struct arm64_ftr_bits ftr_id_aa64isar1[] = { > + ARM64_FTR_BITS(FTR_VISIBLE, FTR_STRICT, FTR_LOWER_SAFE, ID_AA64ISAR1_I8MM_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_VISIBLE, FTR_STRICT, FTR_LOWER_SAFE, ID_AA64ISAR1_DGH_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_VISIBLE, FTR_STRICT, FTR_LOWER_SAFE, ID_AA64ISAR1_BF16_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_AA64ISAR1_SPECRES_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_VISIBLE, FTR_STRICT, FTR_LOWER_SAFE, ID_AA64ISAR1_SB_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_VISIBLE, FTR_STRICT, FTR_LOWER_SAFE, ID_AA64ISAR1_FRINTTS_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_VISIBLE_IF_IS_ENABLED(CONFIG_ARM64_PTR_AUTH), > + FTR_STRICT, FTR_LOWER_SAFE, ID_AA64ISAR1_GPI_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_VISIBLE_IF_IS_ENABLED(CONFIG_ARM64_PTR_AUTH), > + FTR_STRICT, FTR_LOWER_SAFE, ID_AA64ISAR1_GPA_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_VISIBLE, FTR_STRICT, FTR_LOWER_SAFE, ID_AA64ISAR1_LRCPC_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_VISIBLE, FTR_STRICT, FTR_LOWER_SAFE, ID_AA64ISAR1_FCMA_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_VISIBLE, FTR_STRICT, FTR_LOWER_SAFE, ID_AA64ISAR1_JSCVT_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_VISIBLE_IF_IS_ENABLED(CONFIG_ARM64_PTR_AUTH), > + FTR_STRICT, FTR_EXACT, ID_AA64ISAR1_API_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_VISIBLE_IF_IS_ENABLED(CONFIG_ARM64_PTR_AUTH), > + FTR_STRICT, FTR_EXACT, ID_AA64ISAR1_APA_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_VISIBLE, FTR_STRICT, FTR_LOWER_SAFE, ID_AA64ISAR1_DPB_SHIFT, 4, 0), > + ARM64_FTR_END, > +}; > + > +static const struct arm64_ftr_bits ftr_id_aa64pfr0[] = { > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_NONSTRICT, FTR_LOWER_SAFE, ID_AA64PFR0_CSV3_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_NONSTRICT, FTR_LOWER_SAFE, ID_AA64PFR0_CSV2_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_VISIBLE, FTR_STRICT, FTR_LOWER_SAFE, ID_AA64PFR0_DIT_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_NONSTRICT, FTR_LOWER_SAFE, ID_AA64PFR0_AMU_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_AA64PFR0_MPAM_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_NONSTRICT, FTR_LOWER_SAFE, ID_AA64PFR0_SEL2_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_VISIBLE_IF_IS_ENABLED(CONFIG_ARM64_SVE), > + FTR_STRICT, FTR_LOWER_SAFE, ID_AA64PFR0_SVE_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_AA64PFR0_RAS_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_AA64PFR0_GIC_SHIFT, 4, 0), > + S_ARM64_FTR_BITS(FTR_VISIBLE, FTR_STRICT, FTR_LOWER_SAFE, ID_AA64PFR0_ASIMD_SHIFT, 4, ID_AA64PFR0_ASIMD_NI), > + S_ARM64_FTR_BITS(FTR_VISIBLE, FTR_STRICT, FTR_LOWER_SAFE, ID_AA64PFR0_FP_SHIFT, 4, ID_AA64PFR0_FP_NI), > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_NONSTRICT, FTR_LOWER_SAFE, ID_AA64PFR0_EL3_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_NONSTRICT, FTR_LOWER_SAFE, ID_AA64PFR0_EL2_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_NONSTRICT, FTR_LOWER_SAFE, ID_AA64PFR0_EL1_SHIFT, 4, ID_AA64PFR0_EL1_64BIT_ONLY), > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_NONSTRICT, FTR_LOWER_SAFE, ID_AA64PFR0_EL0_SHIFT, 4, ID_AA64PFR0_EL0_64BIT_ONLY), > + ARM64_FTR_END, > +}; > + > +static const struct arm64_ftr_bits ftr_id_aa64pfr1[] = { > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_AA64PFR1_MPAMFRAC_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_AA64PFR1_RASFRAC_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_VISIBLE_IF_IS_ENABLED(CONFIG_ARM64_MTE), > + FTR_STRICT, FTR_LOWER_SAFE, ID_AA64PFR1_MTE_SHIFT, 4, ID_AA64PFR1_MTE_NI), > + ARM64_FTR_BITS(FTR_VISIBLE, FTR_NONSTRICT, FTR_LOWER_SAFE, ID_AA64PFR1_SSBS_SHIFT, 4, ID_AA64PFR1_SSBS_PSTATE_NI), > + ARM64_FTR_BITS(FTR_VISIBLE_IF_IS_ENABLED(CONFIG_ARM64_BTI), > + FTR_STRICT, FTR_LOWER_SAFE, ID_AA64PFR1_BT_SHIFT, 4, 0), > + ARM64_FTR_END, > +}; > + > +static const struct arm64_ftr_bits ftr_id_aa64zfr0[] = { > + ARM64_FTR_BITS(FTR_VISIBLE_IF_IS_ENABLED(CONFIG_ARM64_SVE), > + FTR_STRICT, FTR_LOWER_SAFE, ID_AA64ZFR0_F64MM_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_VISIBLE_IF_IS_ENABLED(CONFIG_ARM64_SVE), > + FTR_STRICT, FTR_LOWER_SAFE, ID_AA64ZFR0_F32MM_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_VISIBLE_IF_IS_ENABLED(CONFIG_ARM64_SVE), > + FTR_STRICT, FTR_LOWER_SAFE, ID_AA64ZFR0_I8MM_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_VISIBLE_IF_IS_ENABLED(CONFIG_ARM64_SVE), > + FTR_STRICT, FTR_LOWER_SAFE, ID_AA64ZFR0_SM4_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_VISIBLE_IF_IS_ENABLED(CONFIG_ARM64_SVE), > + FTR_STRICT, FTR_LOWER_SAFE, ID_AA64ZFR0_SHA3_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_VISIBLE_IF_IS_ENABLED(CONFIG_ARM64_SVE), > + FTR_STRICT, FTR_LOWER_SAFE, ID_AA64ZFR0_BF16_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_VISIBLE_IF_IS_ENABLED(CONFIG_ARM64_SVE), > + FTR_STRICT, FTR_LOWER_SAFE, ID_AA64ZFR0_BITPERM_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_VISIBLE_IF_IS_ENABLED(CONFIG_ARM64_SVE), > + FTR_STRICT, FTR_LOWER_SAFE, ID_AA64ZFR0_AES_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_VISIBLE_IF_IS_ENABLED(CONFIG_ARM64_SVE), > + FTR_STRICT, FTR_LOWER_SAFE, ID_AA64ZFR0_SVEVER_SHIFT, 4, 0), > + ARM64_FTR_END, > +}; > + > +static const struct arm64_ftr_bits ftr_id_aa64mmfr0[] = { > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_AA64MMFR0_ECV_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_AA64MMFR0_FGT_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_AA64MMFR0_EXS_SHIFT, 4, 0), > + /* > + * Page size not being supported at Stage-2 is not fatal. You > + * just give up KVM if PAGE_SIZE isn't supported there. Go fix > + * your favourite nesting hypervisor. > + * > + * There is a small corner case where the hypervisor explicitly > + * advertises a given granule size at Stage-2 (value 2) on some > + * vCPUs, and uses the fallback to Stage-1 (value 0) for other > + * vCPUs. Although this is not forbidden by the architecture, it > + * indicates that the hypervisor is being silly (or buggy). > + * > + * We make no effort to cope with this and pretend that if these > + * fields are inconsistent across vCPUs, then it isn't worth > + * trying to bring KVM up. > + */ > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_NONSTRICT, FTR_EXACT, ID_AA64MMFR0_TGRAN4_2_SHIFT, 4, 1), > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_NONSTRICT, FTR_EXACT, ID_AA64MMFR0_TGRAN64_2_SHIFT, 4, 1), > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_NONSTRICT, FTR_EXACT, ID_AA64MMFR0_TGRAN16_2_SHIFT, 4, 1), > + /* > + * We already refuse to boot CPUs that don't support our configured > + * page size, so we can only detect mismatches for a page size other > + * than the one we're currently using. Unfortunately, SoCs like this > + * exist in the wild so, even though we don't like it, we'll have to go > + * along with it and treat them as non-strict. > + */ > + S_ARM64_FTR_BITS(FTR_HIDDEN, FTR_NONSTRICT, FTR_LOWER_SAFE, ID_AA64MMFR0_TGRAN4_SHIFT, 4, ID_AA64MMFR0_TGRAN4_NI), > + S_ARM64_FTR_BITS(FTR_HIDDEN, FTR_NONSTRICT, FTR_LOWER_SAFE, ID_AA64MMFR0_TGRAN64_SHIFT, 4, ID_AA64MMFR0_TGRAN64_NI), > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_NONSTRICT, FTR_LOWER_SAFE, ID_AA64MMFR0_TGRAN16_SHIFT, 4, ID_AA64MMFR0_TGRAN16_NI), > + > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_AA64MMFR0_BIGENDEL0_SHIFT, 4, 0), > + /* Linux shouldn't care about secure memory */ > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_NONSTRICT, FTR_LOWER_SAFE, ID_AA64MMFR0_SNSMEM_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_AA64MMFR0_BIGENDEL_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_AA64MMFR0_ASID_SHIFT, 4, 0), > + /* > + * Differing PARange is fine as long as all peripherals and memory are mapped > + * within the minimum PARange of all CPUs > + */ > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_NONSTRICT, FTR_LOWER_SAFE, ID_AA64MMFR0_PARANGE_SHIFT, 4, 0), > + ARM64_FTR_END, > +}; > + > +static const struct arm64_ftr_bits ftr_id_aa64mmfr1[] = { > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_AA64MMFR1_ETS_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_AA64MMFR1_TWED_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_AA64MMFR1_XNX_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_HIGHER_SAFE, ID_AA64MMFR1_SPECSEI_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_AA64MMFR1_PAN_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_AA64MMFR1_LOR_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_AA64MMFR1_HPD_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_AA64MMFR1_VHE_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_AA64MMFR1_VMIDBITS_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_AA64MMFR1_HADBS_SHIFT, 4, 0), > + ARM64_FTR_END, > +}; > + > +static const struct arm64_ftr_bits ftr_id_aa64mmfr2[] = { > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_NONSTRICT, FTR_LOWER_SAFE, ID_AA64MMFR2_E0PD_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_AA64MMFR2_EVT_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_AA64MMFR2_BBM_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_AA64MMFR2_TTL_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_AA64MMFR2_FWB_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_AA64MMFR2_IDS_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_VISIBLE, FTR_STRICT, FTR_LOWER_SAFE, ID_AA64MMFR2_AT_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_AA64MMFR2_ST_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_AA64MMFR2_NV_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_AA64MMFR2_CCIDX_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_AA64MMFR2_LVA_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_NONSTRICT, FTR_LOWER_SAFE, ID_AA64MMFR2_IESB_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_AA64MMFR2_LSM_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_AA64MMFR2_UAO_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_AA64MMFR2_CNP_SHIFT, 4, 0), > + ARM64_FTR_END, > +}; > + > +static const struct arm64_ftr_bits ftr_ctr[] = { > + ARM64_FTR_BITS(FTR_VISIBLE, FTR_STRICT, FTR_EXACT, 31, 1, 1), /* RES1 */ > + ARM64_FTR_BITS(FTR_VISIBLE, FTR_STRICT, FTR_LOWER_SAFE, CTR_DIC_SHIFT, 1, 1), > + ARM64_FTR_BITS(FTR_VISIBLE, FTR_STRICT, FTR_LOWER_SAFE, CTR_IDC_SHIFT, 1, 1), > + ARM64_FTR_BITS(FTR_VISIBLE, FTR_STRICT, FTR_HIGHER_OR_ZERO_SAFE, CTR_CWG_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_VISIBLE, FTR_STRICT, FTR_HIGHER_OR_ZERO_SAFE, CTR_ERG_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_VISIBLE, FTR_STRICT, FTR_LOWER_SAFE, CTR_DMINLINE_SHIFT, 4, 1), > + /* > + * Linux can handle differing I-cache policies. Userspace JITs will > + * make use of *minLine. > + * If we have differing I-cache policies, report it as the weakest - VIPT. > + */ > + ARM64_FTR_BITS(FTR_VISIBLE, FTR_NONSTRICT, FTR_EXACT, CTR_L1IP_SHIFT, 2, ICACHE_POLICY_VIPT), /* L1Ip */ > + ARM64_FTR_BITS(FTR_VISIBLE, FTR_STRICT, FTR_LOWER_SAFE, CTR_IMINLINE_SHIFT, 4, 0), > + ARM64_FTR_END, > +}; > + > +static const struct arm64_ftr_bits ftr_id_mmfr0[] = { > + S_ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_MMFR0_INNERSHR_SHIFT, 4, 0xf), > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_MMFR0_FCSE_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_NONSTRICT, FTR_LOWER_SAFE, ID_MMFR0_AUXREG_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_MMFR0_TCM_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_MMFR0_SHARELVL_SHIFT, 4, 0), > + S_ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_MMFR0_OUTERSHR_SHIFT, 4, 0xf), > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_MMFR0_PMSA_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_MMFR0_VMSA_SHIFT, 4, 0), > + ARM64_FTR_END, > +}; > + > +static const struct arm64_ftr_bits ftr_id_aa64dfr0[] = { > + S_ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_AA64DFR0_DOUBLELOCK_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_NONSTRICT, FTR_LOWER_SAFE, ID_AA64DFR0_PMSVER_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_AA64DFR0_CTX_CMPS_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_AA64DFR0_WRPS_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_AA64DFR0_BRPS_SHIFT, 4, 0), > + /* > + * We can instantiate multiple PMU instances with different levels > + * of support. > + */ > + S_ARM64_FTR_BITS(FTR_HIDDEN, FTR_NONSTRICT, FTR_EXACT, ID_AA64DFR0_PMUVER_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_EXACT, ID_AA64DFR0_DEBUGVER_SHIFT, 4, 0x6), > + ARM64_FTR_END, > +}; > + > +static const struct arm64_ftr_bits ftr_mvfr2[] = { > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, MVFR2_FPMISC_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, MVFR2_SIMDMISC_SHIFT, 4, 0), > + ARM64_FTR_END, > +}; > + > +static const struct arm64_ftr_bits ftr_dczid[] = { > + ARM64_FTR_BITS(FTR_VISIBLE, FTR_STRICT, FTR_EXACT, DCZID_DZP_SHIFT, 1, 1), > + ARM64_FTR_BITS(FTR_VISIBLE, FTR_STRICT, FTR_LOWER_SAFE, DCZID_BS_SHIFT, 4, 0), > + ARM64_FTR_END, > +}; > + > +static const struct arm64_ftr_bits ftr_id_isar0[] = { > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_ISAR0_DIVIDE_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_ISAR0_DEBUG_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_ISAR0_COPROC_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_ISAR0_CMPBRANCH_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_ISAR0_BITFIELD_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_ISAR0_BITCOUNT_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_ISAR0_SWAP_SHIFT, 4, 0), > + ARM64_FTR_END, > +}; > + > +static const struct arm64_ftr_bits ftr_id_isar5[] = { > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_ISAR5_RDM_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_ISAR5_CRC32_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_ISAR5_SHA2_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_ISAR5_SHA1_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_ISAR5_AES_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_ISAR5_SEVL_SHIFT, 4, 0), > + ARM64_FTR_END, > +}; > + > +static const struct arm64_ftr_bits ftr_id_mmfr4[] = { > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_MMFR4_EVT_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_MMFR4_CCIDX_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_MMFR4_LSM_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_MMFR4_HPDS_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_MMFR4_CNP_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_MMFR4_XNX_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_MMFR4_AC2_SHIFT, 4, 0), > + > + /* > + * SpecSEI = 1 indicates that the PE might generate an SError on an > + * external abort on speculative read. It is safe to assume that an > + * SError might be generated than it will not be. Hence it has been > + * classified as FTR_HIGHER_SAFE. > + */ > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_HIGHER_SAFE, ID_MMFR4_SPECSEI_SHIFT, 4, 0), > + ARM64_FTR_END, > +}; > + > +static const struct arm64_ftr_bits ftr_id_isar4[] = { > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_ISAR4_SWP_FRAC_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_ISAR4_PSR_M_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_ISAR4_SYNCH_PRIM_FRAC_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_ISAR4_BARRIER_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_ISAR4_SMC_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_ISAR4_WRITEBACK_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_ISAR4_WITHSHIFTS_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_ISAR4_UNPRIV_SHIFT, 4, 0), > + ARM64_FTR_END, > +}; > + > +static const struct arm64_ftr_bits ftr_id_mmfr5[] = { > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_MMFR5_ETS_SHIFT, 4, 0), > + ARM64_FTR_END, > +}; > + > +static const struct arm64_ftr_bits ftr_id_isar6[] = { > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_ISAR6_I8MM_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_ISAR6_BF16_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_ISAR6_SPECRES_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_ISAR6_SB_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_ISAR6_FHM_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_ISAR6_DP_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_ISAR6_JSCVT_SHIFT, 4, 0), > + ARM64_FTR_END, > +}; > + > +static const struct arm64_ftr_bits ftr_id_pfr0[] = { > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_PFR0_DIT_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_NONSTRICT, FTR_LOWER_SAFE, ID_PFR0_CSV2_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_PFR0_STATE3_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_PFR0_STATE2_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_PFR0_STATE1_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_PFR0_STATE0_SHIFT, 4, 0), > + ARM64_FTR_END, > +}; > + > +static const struct arm64_ftr_bits ftr_id_pfr1[] = { > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_PFR1_GIC_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_PFR1_VIRT_FRAC_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_PFR1_SEC_FRAC_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_PFR1_GENTIMER_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_PFR1_VIRTUALIZATION_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_PFR1_MPROGMOD_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_PFR1_SECURITY_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_PFR1_PROGMOD_SHIFT, 4, 0), > + ARM64_FTR_END, > +}; > + > +static const struct arm64_ftr_bits ftr_id_pfr2[] = { > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_NONSTRICT, FTR_LOWER_SAFE, ID_PFR2_SSBS_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_NONSTRICT, FTR_LOWER_SAFE, ID_PFR2_CSV3_SHIFT, 4, 0), > + ARM64_FTR_END, > +}; > + > +static const struct arm64_ftr_bits ftr_id_dfr0[] = { > + /* [31:28] TraceFilt */ > + S_ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_DFR0_PERFMON_SHIFT, 4, 0xf), > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_DFR0_MPROFDBG_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_DFR0_MMAPTRC_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_DFR0_COPTRC_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_DFR0_MMAPDBG_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_DFR0_COPSDBG_SHIFT, 4, 0), > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_DFR0_COPDBG_SHIFT, 4, 0), > + ARM64_FTR_END, > +}; > + > +static const struct arm64_ftr_bits ftr_id_dfr1[] = { > + S_ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_DFR1_MTPMU_SHIFT, 4, 0), > + ARM64_FTR_END, > +}; > + > +static const struct arm64_ftr_bits ftr_zcr[] = { > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_NONSTRICT, FTR_LOWER_SAFE, > + ZCR_ELx_LEN_SHIFT, ZCR_ELx_LEN_SIZE, 0), /* LEN */ > + ARM64_FTR_END, > +}; > + > +/* > + * Common ftr bits for a 32bit register with all hidden, strict > + * attributes, with 4bit feature fields and a default safe value of > + * 0. Covers the following 32bit registers: > + * id_isar[1-4], id_mmfr[1-3], id_pfr1, mvfr[0-1] > + */ > +static const struct arm64_ftr_bits ftr_generic_32bits[] = { > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, 28, 4, 0), > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, 24, 4, 0), > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, 20, 4, 0), > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, 16, 4, 0), > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, 12, 4, 0), > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, 8, 4, 0), > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, 4, 4, 0), > + ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, 0, 4, 0), > + ARM64_FTR_END, > +}; > + > +static const struct arm64_ftr_bits ftr_raz[] = { > + ARM64_FTR_END, > +}; > + > +static s64 arm64_ftr_safe_value(const struct arm64_ftr_bits *ftrp, s64 new, > + s64 cur) > +{ > + s64 ret = 0; > + > + switch (ftrp->type) { > + case FTR_EXACT: > + ret = ftrp->safe_val; > + break; > + case FTR_LOWER_SAFE: > + ret = min(new, cur); > + break; > + case FTR_HIGHER_OR_ZERO_SAFE: > + if (!cur || !new) > + break; > + fallthrough; > + case FTR_HIGHER_SAFE: > + ret = max(new, cur); > + break; > + default: > + BUG(); > + } > + > + return ret; > +} > + > +/* > + * End of imported linux structures and code > + */ > + > diff --git a/xen/include/asm-arm/arm64/cpufeature.h b/xen/include/asm-arm/arm64/cpufeature.h > new file mode 100644 > index 0000000000..d9b9fa77cb > --- /dev/null > +++ b/xen/include/asm-arm/arm64/cpufeature.h > @@ -0,0 +1,104 @@ > +#ifndef __ASM_ARM_ARM64_CPUFEATURES_H > +#define __ASM_ARM_ARM64_CPUFEATURES_H > + > +/* > + * CPU feature register tracking > + * > + * The safe value of a CPUID feature field is dependent on the implications > + * of the values assigned to it by the architecture. Based on the relationship > + * between the values, the features are classified into 3 types - LOWER_SAFE, > + * HIGHER_SAFE and EXACT. > + * > + * The lowest value of all the CPUs is chosen for LOWER_SAFE and highest > + * for HIGHER_SAFE. It is expected that all CPUs have the same value for > + * a field when EXACT is specified, failing which, the safe value specified > + * in the table is chosen. > + */ > + > +enum ftr_type { > + FTR_EXACT, /* Use a predefined safe value */ > + FTR_LOWER_SAFE, /* Smaller value is safe */ > + FTR_HIGHER_SAFE, /* Bigger value is safe */ > + FTR_HIGHER_OR_ZERO_SAFE, /* Bigger value is safe, but 0 is biggest */ > +}; > + > +#define FTR_STRICT true /* SANITY check strict matching required */ > +#define FTR_NONSTRICT false /* SANITY check ignored */ > + > +#define FTR_SIGNED true /* Value should be treated as signed */ > +#define FTR_UNSIGNED false /* Value should be treated as unsigned */ > + > +#define FTR_VISIBLE true /* Feature visible to the user space */ > +#define FTR_HIDDEN false /* Feature is hidden from the user */ > + > +#define FTR_VISIBLE_IF_IS_ENABLED(config) \ > + (IS_ENABLED(config) ? FTR_VISIBLE : FTR_HIDDEN) > + > +struct arm64_ftr_bits { > + bool sign; /* Value is signed ? */ > + bool visible; > + bool strict; /* CPU Sanity check: strict matching required ? */ > + enum ftr_type type; > + u8 shift; > + u8 width; > + s64 safe_val; /* safe value for FTR_EXACT features */ > +}; > + > +static inline int __attribute_const__ > +cpuid_feature_extract_signed_field_width(u64 features, int field, int width) > +{ > + return (s64)(features << (64 - width - field)) >> (64 - width); > +} > + > +static inline int __attribute_const__ > +cpuid_feature_extract_signed_field(u64 features, int field) > +{ > + return cpuid_feature_extract_signed_field_width(features, field, 4); > +} > + > +static inline unsigned int __attribute_const__ > +cpuid_feature_extract_unsigned_field_width(u64 features, int field, int width) > +{ > + return (u64)(features << (64 - width - field)) >> (64 - width); > +} > + > +static inline unsigned int __attribute_const__ > +cpuid_feature_extract_unsigned_field(u64 features, int field) > +{ > + return cpuid_feature_extract_unsigned_field_width(features, field, 4); > +} > + > +static inline u64 arm64_ftr_mask(const struct arm64_ftr_bits *ftrp) > +{ > + return (u64)GENMASK(ftrp->shift + ftrp->width - 1, ftrp->shift); > +} > + > +static inline int __attribute_const__ > +cpuid_feature_extract_field_width(u64 features, int field, int width, bool sign) > +{ > + return (sign) ? > + cpuid_feature_extract_signed_field_width(features, field, width) : > + cpuid_feature_extract_unsigned_field_width(features, field, width); > +} > + > +static inline int __attribute_const__ > +cpuid_feature_extract_field(u64 features, int field, bool sign) > +{ > + return cpuid_feature_extract_field_width(features, field, 4, sign); > +} > + > +static inline s64 arm64_ftr_value(const struct arm64_ftr_bits *ftrp, u64 val) > +{ > + return (s64)cpuid_feature_extract_field_width(val, ftrp->shift, ftrp->width, ftrp->sign); > +} > + > +#endif /* _ASM_ARM_ARM64_CPUFEATURES_H */ > + > +/* > + * Local variables: > + * mode: C > + * c-file-style: "BSD" > + * c-basic-offset: 4 > + * indent-tabs-mode: nil > + * End: > + */ > -- > 2.17.1 > From xen-devel-bounces@lists.xenproject.org Fri Sep 03 22:48:24 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Sep 2021 22:48:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.178520.324592 (Exim 4.92) (envelope-from ) id 1mMHyy-0003DL-81; Fri, 03 Sep 2021 22:48:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 178520.324592; Fri, 03 Sep 2021 22:48:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMHyy-0003D5-2r; Fri, 03 Sep 2021 22:48:24 +0000 Received: by outflank-mailman (input) for mailman id 178520; Fri, 03 Sep 2021 22:48:22 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMHyw-0003BT-Im for xen-devel@lists.xenproject.org; Fri, 03 Sep 2021 22:48:22 +0000 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id ffaf7407-2dd6-460a-9fe1-af28644ee89c; Fri, 03 Sep 2021 22:48:21 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 716676101A; Fri, 3 Sep 2021 22:48:20 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ffaf7407-2dd6-460a-9fe1-af28644ee89c DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1630709300; bh=L0jZaRecm61EmSsPjf7fpVTRHQ/Ab8AzvN4SzS0bsD8=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=VL+W57e/93aDPPY0itPIQAtj2qj4CAGw6qU/InbYWzei28csxrIeJhKknRalZ4M1z SvIf8fJvqog+D7AlFAAlb94p1Jrso8HtBEKEaUJ/mHAUMlm+FyRMZeyXzkGzR0Ghzw wWFYycWaGRtshNUBcZrnClMWu0EH3LcsEyx7HQfj9lkHUpnQJ8FArjKcQokdxUAPEG LetOBjdfgfE6uB5+OCQY7A4g/N5o6Q2FqpHnSTSU0f+TbOaY32RCh70p6kQhgHsFHu 4Nan2eW59E0G0lzR/E6LFK3y/dD4AIC+qfecpVPwMfRZ9FNK+8eVqagalgkZZNm4Zb rVU2Aqya/KCrg== Date: Fri, 3 Sep 2021 15:48:19 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: Bertrand Marquis cc: xen-devel@lists.xenproject.org, Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Wei Liu Subject: Re: [PATCH v3 4/7] xen/arm: Sanitize cpuinfo ID registers fields In-Reply-To: <6710cc0ac3fbc9c8030dfa3d6dfc3ecb79de4b71.1629897306.git.bertrand.marquis@arm.com> Message-ID: References: <6710cc0ac3fbc9c8030dfa3d6dfc3ecb79de4b71.1629897306.git.bertrand.marquis@arm.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Wed, 25 Aug 2021, Bertrand Marquis wrote: > Define a sanitize_cpu function to be called on secondary cores to > sanitize the system cpuinfo structure. > > The safest value is taken when possible and the system is marked tainted > if we encounter values which are incompatible with each other. > > Call the update_system_features function on all secondary cores that are > kept running and taint the system if different midr are found between > cores but hmp-unsafe=true was passed on Xen command line. > > This is only supported on arm64 so update_system_features is an empty > static inline on arm32. > > The patch is adding a new TAINT_CPU_OUT_OF_SPEC to warn the user if > Xen is running on a system with features differences between cores which > are not supported. > > The patch is disabling CTR_EL0, DCZID_EL0 and ZCRusing #if 0 with a TODO > as this patch is not handling sanitization of those registers. > CTR_EL0/DCZID will be handled in a future patch to properly handle > different cache attributes when possible. > ZCR should be sanitize once we add support for SVE in Xen. > > Signed-off-by: Bertrand Marquis Great patch! It looks good I only have a couple of minor questions below. > --- > Changes in v3: > - in case of different midr but hmp-unsafe passed on the command line, > enable all cores anyway but taint Xen with CPU_OUT_OF_SPEC. > - use current core info to sanitize cpu only if we keep it on > Changes in v2: > - add compilation of cpufeature.c in this patch instead of previous one > - remove functions reused from linux code and moved to header > - rename sanitize_cpu to update_system_features > - change to Linux coding style > - remove dev comments > - surround currently not used Linux structures with #if 0 and adapt the > commit message > - add missing aa64dfr1 register > - add TODO for CTR, DCZID and ZCR > - add CPU_OUT_OF_SPEC support to print_taint > - use system_cpuinfo instead of boot_cpu_data > --- > xen/arch/arm/arm64/Makefile | 1 + > xen/arch/arm/arm64/cpufeature.c | 121 +++++++++++++++++++++++++++++++ > xen/arch/arm/smpboot.c | 34 +++++++-- > xen/common/kernel.c | 6 +- > xen/include/asm-arm/cpufeature.h | 9 +++ > xen/include/xen/lib.h | 1 + > 6 files changed, 162 insertions(+), 10 deletions(-) > > diff --git a/xen/arch/arm/arm64/Makefile b/xen/arch/arm/arm64/Makefile > index 40642ff574..701d66883d 100644 > --- a/xen/arch/arm/arm64/Makefile > +++ b/xen/arch/arm/arm64/Makefile > @@ -1,6 +1,7 @@ > obj-y += lib/ > > obj-y += cache.o > +obj-y += cpufeature.o > obj-$(CONFIG_HARDEN_BRANCH_PREDICTOR) += bpi.o > obj-$(CONFIG_EARLY_PRINTK) += debug.o > obj-y += domctl.o > diff --git a/xen/arch/arm/arm64/cpufeature.c b/xen/arch/arm/arm64/cpufeature.c > index 5777e33e5c..61f629ebaa 100644 > --- a/xen/arch/arm/arm64/cpufeature.c > +++ b/xen/arch/arm/arm64/cpufeature.c > @@ -275,6 +275,9 @@ static const struct arm64_ftr_bits ftr_id_aa64mmfr2[] = { > ARM64_FTR_END, > }; > > +#if 0 > +/* TODO: use this to sanitize the cache line size among cores */ > + > static const struct arm64_ftr_bits ftr_ctr[] = { > ARM64_FTR_BITS(FTR_VISIBLE, FTR_STRICT, FTR_EXACT, 31, 1, 1), /* RES1 */ > ARM64_FTR_BITS(FTR_VISIBLE, FTR_STRICT, FTR_LOWER_SAFE, CTR_DIC_SHIFT, 1, 1), > @@ -291,6 +294,7 @@ static const struct arm64_ftr_bits ftr_ctr[] = { > ARM64_FTR_BITS(FTR_VISIBLE, FTR_STRICT, FTR_LOWER_SAFE, CTR_IMINLINE_SHIFT, 4, 0), > ARM64_FTR_END, > }; > +#endif > > static const struct arm64_ftr_bits ftr_id_mmfr0[] = { > S_ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_MMFR0_INNERSHR_SHIFT, 4, 0xf), > @@ -325,11 +329,14 @@ static const struct arm64_ftr_bits ftr_mvfr2[] = { > ARM64_FTR_END, > }; > > +#if 0 > +/* TODO: handle this when sanitizing cache related registers */ > static const struct arm64_ftr_bits ftr_dczid[] = { > ARM64_FTR_BITS(FTR_VISIBLE, FTR_STRICT, FTR_EXACT, DCZID_DZP_SHIFT, 1, 1), > ARM64_FTR_BITS(FTR_VISIBLE, FTR_STRICT, FTR_LOWER_SAFE, DCZID_BS_SHIFT, 4, 0), > ARM64_FTR_END, > }; > +#endif > > static const struct arm64_ftr_bits ftr_id_isar0[] = { > ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_ISAR0_DIVIDE_SHIFT, 4, 0), > @@ -444,11 +451,15 @@ static const struct arm64_ftr_bits ftr_id_dfr1[] = { > ARM64_FTR_END, > }; > > +#if 0 > +/* TODO: use this to sanitize SVE once we support it */ > + > static const struct arm64_ftr_bits ftr_zcr[] = { > ARM64_FTR_BITS(FTR_HIDDEN, FTR_NONSTRICT, FTR_LOWER_SAFE, > ZCR_ELx_LEN_SHIFT, ZCR_ELx_LEN_SIZE, 0), /* LEN */ > ARM64_FTR_END, > }; > +#endif > > /* > * Common ftr bits for a 32bit register with all hidden, strict > @@ -502,3 +513,113 @@ static s64 arm64_ftr_safe_value(const struct arm64_ftr_bits *ftrp, s64 new, > * End of imported linux structures and code > */ > > +static void sanitize_reg(u64 *cur_reg, u64 new_reg, const char *reg_name, > + const struct arm64_ftr_bits *ftrp) > +{ > + int taint = 0; > + u64 old_reg = *cur_reg; > + > + for (;ftrp->width != 0;ftrp++) > + { > + u64 mask; > + s64 cur_field = arm64_ftr_value(ftrp, *cur_reg); > + s64 new_field = arm64_ftr_value(ftrp, new_reg); > + > + if (cur_field == new_field) > + continue; > + > + if (ftrp->strict) > + taint = 1; > + > + mask = arm64_ftr_mask(ftrp); > + > + *cur_reg &= ~mask; > + *cur_reg |= (arm64_ftr_safe_value(ftrp, new_field, cur_field) > + << ftrp->shift) & mask; I wonder why you haven't also imported arm64_ftr_set_value? This seems to be the open-coded version of it. > + } > + > + if (old_reg != new_reg) > + printk(XENLOG_DEBUG "SANITY DIF: %s 0x%"PRIx64" -> 0x%"PRIx64"\n", > + reg_name, old_reg, new_reg); > + if (old_reg != *cur_reg) > + printk(XENLOG_DEBUG "SANITY FIX: %s 0x%"PRIx64" -> 0x%"PRIx64"\n", > + reg_name, old_reg, *cur_reg); > + > + if (taint) > + { > + printk(XENLOG_WARNING "SANITY CHECK: Unexpected variation in %s.\n", > + reg_name); > + add_taint(TAINT_CPU_OUT_OF_SPEC); > + } > +} > + > + > +/* > + * This function should be called on secondary cores to sanitize the boot cpu > + * cpuinfo. > + */ > +void update_system_features(const struct cpuinfo_arm *new) > +{ > + > +#define SANITIZE_REG(field, num, reg) \ > + sanitize_reg(&system_cpuinfo.field.bits[num], new->field.bits[num], \ > + #reg, ftr_##reg) > + > +#define SANITIZE_ID_REG(field, num, reg) \ > + sanitize_reg(&system_cpuinfo.field.bits[num], new->field.bits[num], \ > + #reg, ftr_id_##reg) > + > +#define SANITIZE_RAZ_REG(field, num, reg) \ > + sanitize_reg(&system_cpuinfo.field.bits[num], new->field.bits[num], \ > + #reg, ftr_raz) > + > +#define SANITIZE_GENERIC_REG(field, num, reg) \ > + sanitize_reg(&system_cpuinfo.field.bits[num], new->field.bits[num], \ > + #reg, ftr_generic_32bits) > + > + SANITIZE_ID_REG(pfr64, 0, aa64pfr0); > + SANITIZE_ID_REG(pfr64, 1, aa64pfr1); > + > + SANITIZE_ID_REG(dbg64, 0, aa64dfr0); > + SANITIZE_RAZ_REG(dbg64, 1, aa64dfr1); > + > + SANITIZE_ID_REG(mm64, 0, aa64mmfr0); > + SANITIZE_ID_REG(mm64, 1, aa64mmfr1); > + SANITIZE_ID_REG(mm64, 2, aa64mmfr2); > + > + SANITIZE_ID_REG(isa64, 0, aa64isar0); > + SANITIZE_ID_REG(isa64, 1, aa64isar1); > + > + SANITIZE_ID_REG(zfr64, 0, aa64zfr0); > + > + if ( cpu_feature64_has_el0_32(&system_cpuinfo) ) > + { > + SANITIZE_ID_REG(pfr32, 0, pfr0); > + SANITIZE_ID_REG(pfr32, 1, pfr1); > + SANITIZE_ID_REG(pfr32, 2, pfr2); > + > + SANITIZE_ID_REG(dbg32, 0, dfr0); > + SANITIZE_ID_REG(dbg32, 1, dfr1); > + > + SANITIZE_ID_REG(mm32, 0, mmfr0); > + SANITIZE_GENERIC_REG(mm32, 1, mmfr1); > + SANITIZE_GENERIC_REG(mm32, 2, mmfr2); > + SANITIZE_GENERIC_REG(mm32, 3, mmfr3); > + SANITIZE_ID_REG(mm32, 4, mmfr4); > + SANITIZE_ID_REG(mm32, 5, mmfr5); > + > + SANITIZE_ID_REG(isa32, 0, isar0); > + SANITIZE_GENERIC_REG(isa32, 1, isar1); > + SANITIZE_GENERIC_REG(isa32, 2, isar2); > + SANITIZE_GENERIC_REG(isa32, 3, isar3); > + SANITIZE_ID_REG(isa32, 4, isar4); > + SANITIZE_ID_REG(isa32, 5, isar5); > + SANITIZE_ID_REG(isa32, 6, isar6); > + > + SANITIZE_GENERIC_REG(mvfr, 0, mvfr0); > + SANITIZE_GENERIC_REG(mvfr, 1, mvfr1); > +#ifndef MVFR2_MAYBE_UNDEFINED > + SANITIZE_REG(mvfr, 2, mvfr2); > +#endif > + } > +} Looking at the list of registers we are sanitizing here we are only missing aux32 and aux64 compared to struct cpuinfo_arm. Is that because there is nothing to sanitize there? From xen-devel-bounces@lists.xenproject.org Fri Sep 03 22:48:28 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Sep 2021 22:48:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.178521.324603 (Exim 4.92) (envelope-from ) id 1mMHz2-0003aX-Gy; Fri, 03 Sep 2021 22:48:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 178521.324603; Fri, 03 Sep 2021 22:48:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMHz2-0003aO-D3; Fri, 03 Sep 2021 22:48:28 +0000 Received: by outflank-mailman (input) for mailman id 178521; Fri, 03 Sep 2021 22:48:27 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMHz1-0003BT-KI for xen-devel@lists.xenproject.org; Fri, 03 Sep 2021 22:48:27 +0000 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id fc5df30c-29ca-4894-a89b-066a0aa2911f; Fri, 03 Sep 2021 22:48:26 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 119826101A; Fri, 3 Sep 2021 22:48:26 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fc5df30c-29ca-4894-a89b-066a0aa2911f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1630709306; bh=jT3rD3kg3gdlzCnptl4+hGg4HVNl2HPkKyI+a61ElnA=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=aEtBse5+IXOr4g/JSLovXb6l/if47EWlzriShx6CzKz1NLZ+t56xxxYeSpGo/eclf +Ky9yqiR2uB7b3KcjClz9JJA6/AIjHR1Y9TpRfF5I/j0QnB9Wnv2LDYYQ07MykpjqP NPpfrwDMfNyTafG+SdN5FcLiYoAI9FdEN87CroTBhBXnlMdH0ii77mU8tPQHhQ/PGU jd+2O5d1+irmcLfvOW0ud187rgh37TxyavhudmVzpgCVSHEH/uav4GeQc8FCMUVeyn uL9G4v8TGebawV2191LY7dhq48tX1LLBUCQJmFOHlnUNtnwSjRKHlhBeAr5KX0QY6+ nkaieVjWOMvDQ== Date: Fri, 3 Sep 2021 15:48:25 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: Bertrand Marquis cc: xen-devel@lists.xenproject.org, Stefano Stabellini , Julien Grall , Volodymyr Babchuk Subject: Re: [PATCH v3 5/7] xen/arm: Use sanitize values for p2m In-Reply-To: Message-ID: References: User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Wed, 25 Aug 2021, Bertrand Marquis wrote: > Replace the code in p2m trying to find a sane value for the VMID size > supported and the PAR to use. We are now using the boot cpuinfo as the > values there are sanitized during boot and the value for those > parameters is now the safest possible value on the system. > > Signed-off-by: Bertrand Marquis Reviewed-by: Stefano Stabellini > --- > Changes in v3: drop arm32 mention in commmit message > Changes in v2: > - use system_cpuinfo > --- > xen/arch/arm/p2m.c | 30 ++++++++++-------------------- > 1 file changed, 10 insertions(+), 20 deletions(-) > > diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c > index eff9a105e7..41b6430c30 100644 > --- a/xen/arch/arm/p2m.c > +++ b/xen/arch/arm/p2m.c > @@ -2045,31 +2045,21 @@ void __init setup_virt_paging(void) > [7] = { 0 } /* Invalid */ > }; > > - unsigned int i, cpu; > + unsigned int i; > unsigned int pa_range = 0x10; /* Larger than any possible value */ > - bool vmid_8_bit = false; > - > - for_each_online_cpu ( cpu ) > - { > - const struct cpuinfo_arm *info = &cpu_data[cpu]; > > - /* > - * Restrict "p2m_ipa_bits" if needed. As P2M table is always configured > - * with IPA bits == PA bits, compare against "pabits". > - */ > - if ( pa_range_info[info->mm64.pa_range].pabits < p2m_ipa_bits ) > - p2m_ipa_bits = pa_range_info[info->mm64.pa_range].pabits; > - > - /* Set a flag if the current cpu does not support 16 bit VMIDs. */ > - if ( info->mm64.vmid_bits != MM64_VMID_16_BITS_SUPPORT ) > - vmid_8_bit = true; > - } > + /* > + * Restrict "p2m_ipa_bits" if needed. As P2M table is always configured > + * with IPA bits == PA bits, compare against "pabits". > + */ > + if ( pa_range_info[system_cpuinfo.mm64.pa_range].pabits < p2m_ipa_bits ) > + p2m_ipa_bits = pa_range_info[system_cpuinfo.mm64.pa_range].pabits; > > /* > - * If the flag is not set then it means all CPUs support 16-bit > - * VMIDs. > + * cpu info sanitization made sure we support 16bits VMID only if all > + * cores are supporting it. > */ > - if ( !vmid_8_bit ) > + if ( system_cpuinfo.mm64.vmid_bits == MM64_VMID_16_BITS_SUPPORT ) > max_vmid = MAX_VMID_16_BIT; > > /* Choose suitable "pa_range" according to the resulted "p2m_ipa_bits". */ > -- > 2.17.1 > From xen-devel-bounces@lists.xenproject.org Fri Sep 03 22:49:10 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Sep 2021 22:49:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.178543.324614 (Exim 4.92) (envelope-from ) id 1mMHzh-0004r7-Sj; Fri, 03 Sep 2021 22:49:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 178543.324614; Fri, 03 Sep 2021 22:49:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMHzh-0004r0-Oy; Fri, 03 Sep 2021 22:49:09 +0000 Received: by outflank-mailman (input) for mailman id 178543; Fri, 03 Sep 2021 22:49:08 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMHzg-0004pW-5x for xen-devel@lists.xenproject.org; Fri, 03 Sep 2021 22:49:08 +0000 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 59256c8a-01da-49cc-a5ab-53bb46601b0c; Fri, 03 Sep 2021 22:49:04 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 9DC7E6101A; Fri, 3 Sep 2021 22:49:03 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 59256c8a-01da-49cc-a5ab-53bb46601b0c DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1630709343; bh=S/hCI4aNd0cSDI8CmUHd0XFH3442g/fhnIUYiVIArNA=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=ZgA3V3osAHiiWa8wy42E9oJxR4wvoMSZDXARPUT8fYpa+9FEPaMH1XtpIXsb2SWVe 7OENlv0thp8D6iYy0RQD9FG15Aa1b6nJut2G5X/eo/QDhTi0z4TNhTNk12ZJOWC25S csVfmz0CpJQ4Eeig3dBQzEIJMdwZOPWLfKCwkzezPmEIRrNvoo2CbsMR2V/2oVOcgB OiIPRxNg1D9PEdDIHMoeV0E0U61qeljMIggl6Ex7Mj2+bfjOHzMz5n7+4bSE7F1z12 1XT5aZJviY3U37+nnYFNFsoP8rC1jMDNxIyeTvO+EDhZ7yiB/BUR1kfmHlraCAKxyG I5bonXuCQUjTA== Date: Fri, 3 Sep 2021 15:49:03 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: Bertrand Marquis cc: xen-devel@lists.xenproject.org, Stefano Stabellini , Julien Grall , Volodymyr Babchuk Subject: Re: [PATCH v3 6/7] xen/arm: Taint Xen on incompatible DCZID values In-Reply-To: Message-ID: References: User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Wed, 25 Aug 2021, Bertrand Marquis wrote: > Use arm64 cpu feature sanitization to TAIN Xen if different DCZID values ^ TAINT > are found (ftr_dczid is using only STRICT method). > In this case actual memory being cleaned by DC ZVA operations would be > different depending on the cores which could make a guest zeroing too > much or too little memory if it is merged between CPUs. > > We could, on processor supporting it, trap access to DCZID_EL0 register ^ processors > using HFGRTR_EL2 register but this would not solve the case where a > process is being migrated during a copy or if it cached the value of the > register. > > Signed-off-by: Bertrand Marquis > --- > Change in v3: none > Change in v2: Patch introduced in v2 > --- > xen/arch/arm/arm64/cpufeature.c | 14 +++++++++++--- > xen/arch/arm/cpufeature.c | 2 ++ > xen/include/asm-arm/cpufeature.h | 8 ++++++++ > 3 files changed, 21 insertions(+), 3 deletions(-) > > diff --git a/xen/arch/arm/arm64/cpufeature.c b/xen/arch/arm/arm64/cpufeature.c > index 61f629ebaa..b1936ef1d6 100644 > --- a/xen/arch/arm/arm64/cpufeature.c > +++ b/xen/arch/arm/arm64/cpufeature.c > @@ -329,14 +329,11 @@ static const struct arm64_ftr_bits ftr_mvfr2[] = { > ARM64_FTR_END, > }; > > -#if 0 > -/* TODO: handle this when sanitizing cache related registers */ > static const struct arm64_ftr_bits ftr_dczid[] = { > ARM64_FTR_BITS(FTR_VISIBLE, FTR_STRICT, FTR_EXACT, DCZID_DZP_SHIFT, 1, 1), > ARM64_FTR_BITS(FTR_VISIBLE, FTR_STRICT, FTR_LOWER_SAFE, DCZID_BS_SHIFT, 4, 0), > ARM64_FTR_END, > }; > -#endif > > static const struct arm64_ftr_bits ftr_id_isar0[] = { > ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_ISAR0_DIVIDE_SHIFT, 4, 0), > @@ -592,6 +589,17 @@ void update_system_features(const struct cpuinfo_arm *new) > > SANITIZE_ID_REG(zfr64, 0, aa64zfr0); > > + /* > + * Comment from Linux: I don't know if I would keep or remove "Comment from Linux" In any case: Reviewed-by: Stefano Stabellini Also I gave a quick test of the series on a ZCU102 and it worked fine. > + * Userspace may perform DC ZVA instructions. Mismatched block sizes > + * could result in too much or too little memory being zeroed if a > + * process is preempted and migrated between CPUs. > + * > + * ftr_dczid is using STRICT comparison so we will taint Xen if different > + * values are found. > + */ > + SANITIZE_REG(dczid, 0, dczid); > + > if ( cpu_feature64_has_el0_32(&system_cpuinfo) ) > { > SANITIZE_ID_REG(pfr32, 0, pfr0); > diff --git a/xen/arch/arm/cpufeature.c b/xen/arch/arm/cpufeature.c > index f600a611bd..113f20f601 100644 > --- a/xen/arch/arm/cpufeature.c > +++ b/xen/arch/arm/cpufeature.c > @@ -125,6 +125,8 @@ void identify_cpu(struct cpuinfo_arm *c) > > c->zfr64.bits[0] = READ_SYSREG(ID_AA64ZFR0_EL1); > > + c->dczid.bits[0] = READ_SYSREG(DCZID_EL0); > + > aarch32_el0 = cpu_feature64_has_el0_32(c); > #endif > > diff --git a/xen/include/asm-arm/cpufeature.h b/xen/include/asm-arm/cpufeature.h > index 52cb3133e0..5219fd3bab 100644 > --- a/xen/include/asm-arm/cpufeature.h > +++ b/xen/include/asm-arm/cpufeature.h > @@ -259,6 +259,14 @@ struct cpuinfo_arm { > register_t bits[1]; > } zfr64; > > + /* > + * DCZID is only used to check for incoherent values between cores > + * and taint Xen in this case > + */ > + struct { > + register_t bits[1]; > + } dczid; > + > #endif > > /* > -- > 2.17.1 > From xen-devel-bounces@lists.xenproject.org Fri Sep 03 22:49:38 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 03 Sep 2021 22:49:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.178547.324624 (Exim 4.92) (envelope-from ) id 1mMI0A-0005Xr-9D; Fri, 03 Sep 2021 22:49:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 178547.324624; Fri, 03 Sep 2021 22:49:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMI0A-0005Xk-5l; Fri, 03 Sep 2021 22:49:38 +0000 Received: by outflank-mailman (input) for mailman id 178547; Fri, 03 Sep 2021 22:49:36 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMI08-0005XF-DJ for xen-devel@lists.xenproject.org; Fri, 03 Sep 2021 22:49:36 +0000 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 92e6d110-16a5-49ea-9fed-1136efe8e605; Fri, 03 Sep 2021 22:49:35 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 6E69C60FA0; Fri, 3 Sep 2021 22:49:34 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 92e6d110-16a5-49ea-9fed-1136efe8e605 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1630709374; bh=MelmbXi6qQvN2rHzNWcwaBtUUsR83J5tHhU/VWOnA1s=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=mcilNlKENYopNymU1GVqplsCs8G0/C4btMrZJGuTed3q3TrBbiG8T3gEGlnzljwVX SUtsli8oSfJiIkWIfRVRxWRGC3HKGIqd9aYs7K4EQCzWqXM9CU8l4dEdGjt2oYKAYi BrHh+LjMyGVhE9yH0oufb0eWPTNoftb9qmiyTagEG4p1GBTV12Z8h9WYVDrHlseIyt HV6Hf5OvsINegFSIlXRHAAErKX0+3zkRUfz2QgFNSiKhwUDCLp8kIUYlqXw7O2fnA9 enW0pUxNRQCJ8rI7q4zLaA9BrUItINft9SpdUgs8WyjEreechqYFS7a1EJPxizLBd+ wPafcGzr9n/Hg== Date: Fri, 3 Sep 2021 15:49:33 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: Bertrand Marquis cc: Julien Grall , "xen-devel@lists.xenproject.org" , Stefano Stabellini , Volodymyr Babchuk Subject: Re: [PATCH v3 7/7] xen/arm: Sanitize CTR_EL0 and emulate it if needed In-Reply-To: Message-ID: References: <14b1639e-c9e4-f8fb-e921-73d7f28681ac@xen.org> <98E8FB9D-3372-47D2-92F7-8AD401AC1092@arm.com> <6705127a-bde2-36cd-0fed-900eb1eace03@xen.org> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Tue, 31 Aug 2021, Bertrand Marquis wrote: > Hi Julien, > > > On 31 Aug 2021, at 15:47, Julien Grall wrote: > > > > > > > > On 31/08/2021 14:17, Bertrand Marquis wrote: > >> Hi Julien, > > > > Hi Bertrand, > > > >>> On 27 Aug 2021, at 16:05, Julien Grall wrote: > >>> > >>> Hi Bertrand, > >>> > >>> On 25/08/2021 14:18, Bertrand Marquis wrote: > >>>> Sanitize CTR_EL0 value between cores. > >>>> In most cases different values will taint Xen but if different > >>>> i-cache policies are found, we choose the one which will be compatible > >>>> between all cores in terms of invalidation/data cache flushing strategy. > >>> > >>> I understand that all the CPUs in Xen needs to agree on the cache flush strategy. However... > >>> > >>>> In this case we need to activate the TID2 bit in HCR to emulate the > >>>> TCR_EL0 register for guests. This patch is not activating TID2 bit all > >>>> the time to limit the overhead when possible. > >>> > >>> as we discussed in an earlier version, a vCPU is unlikely (at least in short/medium) to be able move across pCPU of different type. So the vCPU would be pinned to a set of pCPUs. IOW, the guest would have to be big.LITTLE aware and therefore would be able to do its own strategy decision. > >>> > >>> So I think we should be able to get away from trappings the registers. > >> I do agree that we should be able to get away from that in the long term once > >> we have cpupools properly set but right now this is the only way to have > >> something useable (I will not say right). > >> I will work on finding a way to setup properly cpupools (or something else as > >> we discussed earlier) but in the short term I think this is the best we can do. > > > > My concern is you are making look like Xen will be able to deal nicely with big.LITTLE when in fact there are a lot more potential issue by allow a vCPU moving accross pCPU of different type (the errata is one example). > > I agree and this is why Xen is tainted. > > > > >> An other solution would be to discard this patch from the serie for now until > >> I have worked a proper solution for this case. > >> Should we discard or merge or do you have an other idea ? > > Please correct me if I am wrong, at the moment, it doesn't look like this patch will be part of the longer plan. If so, then I think it should be parked for now. > > Not sure it depends on what the final solution would be but this is highly possible I agree. > > > > > This would also have the advantage to avoid spending too much time on resolving the emulation issue I mentioned in my previous answer. > > > > No need to resend a new version of this series yet. You can wait until the rest of the series get more feedback. > > Ok, I will wait for feedback and next serie will not include this patch anymore. Would it be worth keeping just the part that sanitizes ctr, without any of the emulation stuff? That way we could still detect cases where there is a mismatch between CPUs, print a useful message and taint Xen. For clarity something like the appended. diff --git a/xen/arch/arm/arm64/cpufeature.c b/xen/arch/arm/arm64/cpufeature.c index b1936ef1d6..d2456af2bf 100644 --- a/xen/arch/arm/arm64/cpufeature.c +++ b/xen/arch/arm/arm64/cpufeature.c @@ -275,9 +275,6 @@ static const struct arm64_ftr_bits ftr_id_aa64mmfr2[] = { ARM64_FTR_END, }; -#if 0 -/* TODO: use this to sanitize the cache line size among cores */ - static const struct arm64_ftr_bits ftr_ctr[] = { ARM64_FTR_BITS(FTR_VISIBLE, FTR_STRICT, FTR_EXACT, 31, 1, 1), /* RES1 */ ARM64_FTR_BITS(FTR_VISIBLE, FTR_STRICT, FTR_LOWER_SAFE, CTR_DIC_SHIFT, 1, 1), @@ -294,7 +291,6 @@ static const struct arm64_ftr_bits ftr_ctr[] = { ARM64_FTR_BITS(FTR_VISIBLE, FTR_STRICT, FTR_LOWER_SAFE, CTR_IMINLINE_SHIFT, 4, 0), ARM64_FTR_END, }; -#endif static const struct arm64_ftr_bits ftr_id_mmfr0[] = { S_ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_MMFR0_INNERSHR_SHIFT, 4, 0xf), @@ -600,6 +596,8 @@ void update_system_features(const struct cpuinfo_arm *new) */ SANITIZE_REG(dczid, 0, dczid); + SANITIZE_REG(ctr, 0, ctr); + if ( cpu_feature64_has_el0_32(&system_cpuinfo) ) { SANITIZE_ID_REG(pfr32, 0, pfr0); diff --git a/xen/arch/arm/cpufeature.c b/xen/arch/arm/cpufeature.c index 113f20f601..6e51f530a8 100644 --- a/xen/arch/arm/cpufeature.c +++ b/xen/arch/arm/cpufeature.c @@ -127,6 +127,8 @@ void identify_cpu(struct cpuinfo_arm *c) c->dczid.bits[0] = READ_SYSREG(DCZID_EL0); + c->ctr.bits[0] = READ_SYSREG(CTR_EL0); + aarch32_el0 = cpu_feature64_has_el0_32(c); #endif diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c index 3798c5ade0..33b7bfb59c 100644 --- a/xen/arch/arm/setup.c +++ b/xen/arch/arm/setup.c @@ -627,7 +627,7 @@ static void __init setup_mm(void) panic("No memory bank\n"); /* We only supports instruction caches implementing the IVIPT extension. */ - if ( ((ctr >> CTR_L1Ip_SHIFT) & CTR_L1Ip_MASK) == CTR_L1Ip_AIVIVT ) + if ( ((ctr >> CTR_L1IP_SHIFT) & CTR_L1IP_MASK) == ICACHE_POLICY_AIVIVT ) panic("AIVIVT instruction cache not supported\n"); init_pdx(); diff --git a/xen/include/asm-arm/cpufeature.h b/xen/include/asm-arm/cpufeature.h index 5219fd3bab..ca6e827fcb 100644 --- a/xen/include/asm-arm/cpufeature.h +++ b/xen/include/asm-arm/cpufeature.h @@ -267,6 +267,14 @@ struct cpuinfo_arm { register_t bits[1]; } dczid; + /* + * CTR is only used to check for different cache types or policies and + * taint Xen in this case + */ + struct { + register_t bits[1]; + } ctr; + #endif /* @@ -339,6 +347,9 @@ extern struct cpuinfo_arm system_cpuinfo; extern void identify_cpu(struct cpuinfo_arm *); #ifdef CONFIG_ARM_64 + +extern bool mismatched_cache_type; + extern void update_system_features(const struct cpuinfo_arm *); #else static inline void update_system_features(const struct cpuinfo_arm *cpuinfo) diff --git a/xen/include/asm-arm/processor.h b/xen/include/asm-arm/processor.h index 2577e9a244..8c9843e12b 100644 --- a/xen/include/asm-arm/processor.h +++ b/xen/include/asm-arm/processor.h @@ -7,9 +7,21 @@ #include /* CTR Cache Type Register */ -#define CTR_L1Ip_MASK 0x3 -#define CTR_L1Ip_SHIFT 14 -#define CTR_L1Ip_AIVIVT 0x1 +#define CTR_L1IP_MASK 0x3 +#define CTR_L1IP_SHIFT 14 +#define CTR_DMINLINE_SHIFT 16 +#define CTR_IMINLINE_SHIFT 0 +#define CTR_IMINLINE_MASK 0xf +#define CTR_ERG_SHIFT 20 +#define CTR_CWG_SHIFT 24 +#define CTR_CWG_MASK 15 +#define CTR_IDC_SHIFT 28 +#define CTR_DIC_SHIFT 29 + +#define ICACHE_POLICY_VPIPT 0 +#define ICACHE_POLICY_AIVIVT 1 +#define ICACHE_POLICY_VIPT 2 +#define ICACHE_POLICY_PIPT 3 /* MIDR Main ID Register */ #define MIDR_REVISION_MASK 0xf From xen-devel-bounces@lists.xenproject.org Sat Sep 04 00:47:16 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 04 Sep 2021 00:47:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.178583.324660 (Exim 4.92) (envelope-from ) id 1mMJpl-00042a-Hf; Sat, 04 Sep 2021 00:47:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 178583.324660; Sat, 04 Sep 2021 00:47:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMJpl-00042T-EJ; Sat, 04 Sep 2021 00:47:01 +0000 Received: by outflank-mailman (input) for mailman id 178583; Sat, 04 Sep 2021 00:46:59 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMJpj-00042J-FT; Sat, 04 Sep 2021 00:46:59 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMJpj-00012Y-4V; Sat, 04 Sep 2021 00:46:59 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMJpi-0003T1-Mk; Sat, 04 Sep 2021 00:46:58 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mMJpi-0005cd-MC; Sat, 04 Sep 2021 00:46:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=0bncTkJNzJmmLEieCHFUIGy1mpdW2MYnUjAw5cCSBZI=; b=IenDntL6kuulVAjl/OK5XoEsG+ 4tBwgZNO85bKyk42FZoizfnyYY1qun/eb1GiEtAzcWhbiUpINtT/h3/Qep/PZisOqe6RajHpIa6bO VGFgEbxOVxVbVnlrjzzf6OrN0iXaJRYeMrWNAwFVIbIh/LAQaTKFs5ahfJccbRtC06ic=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 164797: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-i386-xl-qemut-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-examine:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-i386-xl-raw:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-pvshim:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-i386:xen-install:fail:regression linux-linus:test-amd64-i386-xl-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ovmf-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-coresched-i386-xl:xen-install:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-arm64-arm64-xl-credit1:debian-fixup:fail:regression linux-linus:test-arm64-arm64-xl-thunderx:debian-fixup:fail:regression linux-linus:test-arm64-arm64-xl:debian-fixup:fail:regression linux-linus:test-arm64-arm64-xl-xsm:debian-fixup:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:debian-fixup:fail:regression linux-linus:test-amd64-amd64-qemuu-freebsd11-amd64:guest-localmigrate/x10:fail:heisenbug linux-linus:test-armhf-armhf-xl-arndale:xen-boot:fail:heisenbug linux-linus:test-amd64-amd64-examine:memdisk-try-append:fail:heisenbug linux-linus:test-arm64-arm64-xl-credit2:debian-fixup:fail:heisenbug linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=a9c9a6f741cdaa2fa9ba24a790db8d07295761e3 X-Osstest-Versions-That: linux=deacdb3e3979979016fcd0ffd518c320a62ad166 From: osstest service owner Date: Sat, 04 Sep 2021 00:46:58 +0000 flight 164797 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/164797/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemut-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-examine 6 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-i386-xl-raw 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-pvshim 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-i386 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ovmf-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-coresched-i386-xl 7 xen-install fail REGR. vs. 152332 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 152332 test-arm64-arm64-examine 8 reboot fail REGR. vs. 152332 test-arm64-arm64-xl-credit1 13 debian-fixup fail REGR. vs. 152332 test-arm64-arm64-xl-thunderx 13 debian-fixup fail REGR. vs. 152332 test-arm64-arm64-xl 13 debian-fixup fail REGR. vs. 152332 test-arm64-arm64-xl-xsm 13 debian-fixup fail REGR. vs. 152332 test-arm64-arm64-libvirt-xsm 13 debian-fixup fail REGR. vs. 152332 Tests which are failing intermittently (not blocking): test-amd64-amd64-qemuu-freebsd11-amd64 19 guest-localmigrate/x10 fail in 164791 pass in 164797 test-armhf-armhf-xl-arndale 8 xen-boot fail in 164791 pass in 164797 test-amd64-amd64-examine 4 memdisk-try-append fail in 164791 pass in 164797 test-arm64-arm64-xl-credit2 13 debian-fixup fail pass in 164791 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 164791 Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-credit2 15 migrate-support-check fail in 164791 never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail in 164791 never pass test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 152332 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 152332 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152332 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152332 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 152332 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152332 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail like 152332 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152332 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: linux a9c9a6f741cdaa2fa9ba24a790db8d07295761e3 baseline version: linux deacdb3e3979979016fcd0ffd518c320a62ad166 Last test of basis 152332 2020-07-31 19:41:23 Z 399 days Failing since 152366 2020-08-01 20:49:34 Z 398 days 690 attempts Testing same since 164791 2021-09-03 04:54:46 Z 0 days 2 attempts ------------------------------------------------------------ 7181 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl fail test-armhf-armhf-xl pass test-amd64-i386-xl fail test-amd64-coresched-i386-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm fail test-amd64-i386-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm fail test-amd64-i386-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine pass test-arm64-arm64-examine fail test-armhf-armhf-examine pass test-amd64-i386-examine fail test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel fail test-amd64-i386-qemuu-rhel6hvm-intel fail test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair fail test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow fail test-arm64-arm64-xl-thunderx fail test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2197963 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Sep 04 03:44:14 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 04 Sep 2021 03:44:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.178601.324674 (Exim 4.92) (envelope-from ) id 1mMMb3-0005XM-Du; Sat, 04 Sep 2021 03:44:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 178601.324674; Sat, 04 Sep 2021 03:44:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMMb3-0005Wu-74; Sat, 04 Sep 2021 03:44:01 +0000 Received: by outflank-mailman (input) for mailman id 178601; Sat, 04 Sep 2021 03:44:00 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMMb2-0005Wk-0F; Sat, 04 Sep 2021 03:44:00 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMMb1-0002Aw-Qn; Sat, 04 Sep 2021 03:43:59 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMMb1-0005FZ-GF; Sat, 04 Sep 2021 03:43:59 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mMMb1-00055m-Fl; Sat, 04 Sep 2021 03:43:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=DwGiL8QW2xyzCkVDtcNqaKi/z8rH3Mzn6XEREdvRhbg=; b=f++5trXf/rEZMscuCvDXjXDYi0 mitrxmE4VE53/Ptrp7AKg/CbSoQqfl4yQMgGBF9R1TqULU6uVeqdUzfXqE33Mm89mRD3Mm5PoJ5+4 3QnyMt9bXjAmKos8zKfsdEJRLTn6uFGTDiKqLZizAFNaJhhed6J5GCsFBZHiA0vrOo6I=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 164800: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=81d71fb86e1ad676e94becb7ffffb403cefd3019 X-Osstest-Versions-That: ovmf=cae735f61328d64e2e8991036707b9e78c0f5f63 From: osstest service owner Date: Sat, 04 Sep 2021 03:43:59 +0000 flight 164800 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/164800/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 164674 build-amd64-xsm 6 xen-build fail REGR. vs. 164674 build-i386-xsm 6 xen-build fail REGR. vs. 164674 build-i386 6 xen-build fail REGR. vs. 164674 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 81d71fb86e1ad676e94becb7ffffb403cefd3019 baseline version: ovmf cae735f61328d64e2e8991036707b9e78c0f5f63 Last test of basis 164674 2021-08-31 02:56:52 Z 4 days Failing since 164686 2021-09-01 03:03:43 Z 3 days 24 attempts Testing same since 164788 2021-09-03 04:12:12 Z 0 days 5 attempts ------------------------------------------------------------ People who touched revisions under test: Anthony PERARD DunTan Gary Lin Hao A Wu Jim Fehlig Lin, Gary (HPS OE-Linux) Loo Tung Lun Loo, Tung Lun Mark Wilson Marvin H?user Rebecca Cran Wenxing Hou Wenyi Xie jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit 81d71fb86e1ad676e94becb7ffffb403cefd3019 Author: Hao A Wu Date: Fri Aug 20 13:36:56 2021 +0800 Maintainers.txt: Update maintainer/reviewer roles in MdeModulePkg Remove Hao A Wu as the MdeModulePkg maintainer. Add Liming Gao as the MdeModulePkg maintainer. Remove Hao A Wu as the MdeModulePkg: Firmware Update modules reviewer. Remove Hao A Wu as the MdeModulePkg: Serial modules reviewer. Cc: Jian J Wang Cc: Liming Gao Cc: Guomin Jiang Cc: Ray Ni Cc: Zhichao Gao Signed-off-by: Hao A Wu Reviewed-by: Liming Gao Reviewed-by: Zhichao Gao commit c5e805ffe1098601e84fd501d5fa1d45e9d96a62 Author: Rebecca Cran Date: Tue Aug 31 06:36:36 2021 +0800 MdeModulePkg: Fix typo of "memory" in RamDiskDxe debug message Fix a typo of "memory" in a debug message in RamDiskProtocol.c. Signed-off-by: Rebecca Cran Reviewed-by: Hao A Wu Reviewed-by: Philippe Mathieu-Daude commit b6bc203375b6efb6822ee4fe4a59be4f1918436b Author: Wenyi Xie Date: Thu Aug 26 09:16:03 2021 +0800 MdeModulePkg/HiiDatabaseDxe:remove dead code block As the if statement outside has confirmed that BlockData->Name == NULL, so the if statement inside is always false. Cc: Jian J Wang Cc: Hao A Wu Cc: Dandan Bi Cc: Eric Dong Signed-off-by: Wenyi Xie Reviewed-by: Dandan Bi commit e3ee8c8dbd7a9f7d7905abe17be60354c9f5f9a3 Author: duntan Date: Fri Aug 20 14:43:37 2021 +0800 .azurepipelines: Add UefiPayloadPkg in gate-build-job.yml and CISetting.py Add UefiPayloadPkg in gate-build-job.yml to enable Core ci for UefiPayloadPkg. Add UefiPayloadPkg to supported Packages in CISettings. Cc: Sean Brogan Cc: Bret Barkelew Cc: Michael D Kinney Cc: Liming Gao Signed-off-by: DunTan Reviewed-by: Liming Gao commit 63fddc98e06c380e654b1cfbaf24b9fd922adfad Author: duntan Date: Fri Aug 20 14:43:36 2021 +0800 UefiPayloadPkg: Create .yaml file in UefiPayloadPkg Create .yaml file in UefiPayloadPkg to enable Core ci for UefiPayloadPkg Cc: Guo Dong Cc: Ray Ni Cc: Maurice Ma Cc: Benjamin You Signed-off-by: DunTan Reviewed-by: Liming Gao commit 12e33dca4c0612a0975265e5ba641c6261a26455 Author: Loo, Tung Lun Date: Tue Aug 17 15:43:12 2021 +0800 IntelFsp2Pkg: Support Config File and Binary delta comparison BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3567 This patch is to enable config editor to have a new feature that can spell out the delta between the default configuration files' data, such as YAML and BSF, against the data stored in the binary. This can help users understand and track the difference when modifications are made. Cc: Maurice Ma Cc: Nate DeSimone Cc: Star Zeng Cc: Chasel Chiu Signed-off-by: Loo Tung Lun Reviewed-by: Chasel Chiu commit b170806518c1e414939c8b085866544814e1ce8e Author: Mark Wilson Date: Fri Nov 13 08:05:18 2020 +0800 UefiCpuPkg: Clean up save state boundary checks and comments. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2956 In functions ReadSaveStateRegisterByIndex and WriteSaveStateRegister: * check width > 4 instead of >= 4 when writing upper 32 bytes. - This improves the code but will not affect functionality. Cc: Eric Dong Reviewed-by: Ray Ni Signed-off-by: Mark Wilson commit 3b3f88228812e2c642eea8746858a4dad928ebf7 Author: Marvin H?user Date: Mon Aug 9 14:09:25 2021 +0800 MdeModulePkg/PiSmmCore: Drop deprecated image profiling commands The legacy codebase allowed SMM images to be registered for profiling from DXE. Support for this has been dropped entirely, so remove the remaining handlers. Cc: Jian J Wang Cc: Hao A Wu Cc: Eric Dong Reviewed-by: Ray Ni Cc: Vitaly Cheptsov Signed-off-by: Marvin H?user commit cdda3f74a1327663a5d48cca13507085ba403af7 Author: Marvin H?user Date: Mon Aug 9 03:39:53 2021 +0800 UefiPayloadPkg/UefiPayloadEntry: Fix memory corruption UefiPayloadEntry's AllocatePool() applies the "sizeof" operator to HOB index rather than the HOB header structure. This yields 4 Bytes compared to the 8 Bytes the structure header requires. Fix the call to allocate the required space instead. Reviewed-by: Guo Dong Reviewed-by: Ray Ni Cc: Maurice Ma Cc: Benjamin You Cc: Vitaly Cheptsov Signed-off-by: Marvin H?user commit 5d34cc49d5d348012fe8acf9fb618826bd541a7c Author: Wenxing Hou Date: Tue Aug 24 16:11:11 2021 +0800 UefiCpuPkg/PiSmmCpuDxeSmm: Update mPatchCetSupported set condition REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3584 Function AsmCpuid should first check the value for Basic CPUID Information. The fix is to update the mPatchCetSupported judgment statement. Signed-off-by: Wenxing Hou Reviewed-by: Ray Ni Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Cc: Sheng W Cc: Yao Jiewen commit f0fe55bca4651734abf1752a1d7c69fb5bee00b9 Author: duntan Date: Fri Aug 20 13:04:29 2021 +0800 UefiPayloadPkg: Fix the build error when enable Core ci for UefiPayloadPkg V1: Add quotes when using $(ARCH) in .dsc and .fdf file. The quotes are added due to the way by which Core ci parse the .dsc file. Add UINTN in Hob.c to fix cast from pointer to integer of different size error. V2: Delete lines which reference ShellBinPkg.The pkg doesn't exist in edk2. Cc: Guo Dong Cc: Ray Ni Cc: Maurice Ma Cc: Benjamin You Signed-off-by: DunTan Reviewed-by: Ray Ni commit 9f3eda177a4b2d4a33ff1b0307cad42906396562 Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:29:48 2021 +0800 OvmfPkg/OvmfXen: add QemuKernelLoaderFsDxe Without QemuKernelLoaderFsDxe, QemuLoadKernelImage() couldn't download the kernel, initrd, and kernel command line from QEMU's fw_cfg. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3574 Signed-off-by: Gary Lin Acked-by: Anthony PERARD Reviewed-by: Philippe Mathieu-Daude Reviewed-by: Gerd Hoffmann Tested-by: Jim Fehlig commit 5b5f10d7465004e3e40ec1f50a3b490b4db595e7 Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:31:15 2021 +0800 OvmfPkg/SmmControl2Dxe: use PcdAcpiS3Enable to detect S3 support To avoid the potential inconsistency between PcdAcpiS3Enable and QemuFwCfgS3Enabled(), this commit modifies SmmControl2Dxe to detect S3 support by PcdAcpiS3Enable as modules in MdeModulePkg do. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3573 Signed-off-by: Gary Lin Reviewed-by: Gerd Hoffmann Reviewed-by: Jiewen Yao Tested-by: Jim Fehlig commit 52e2dabc0f8d3af09c213072ce8ba734302f585d Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:31:14 2021 +0800 OvmfPkg/PlatformBootManagerLib: use PcdAcpiS3Enable to detect S3 support To avoid the potential inconsistency between PcdAcpiS3Enable and QemuFwCfgS3Enabled(), this commit modifies PlatformBootManagerLib to detect S3 support by PcdAcpiS3Enable as modules in MdeModulePkg do. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3573 Signed-off-by: Gary Lin Reviewed-by: Gerd Hoffmann Reviewed-by: Jiewen Yao Tested-by: Jim Fehlig commit 28152333bccb778b62e6e97446b28bfa0e92ef82 Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:31:13 2021 +0800 OvmfPkg/LockBoxLib: use PcdAcpiS3Enable to detect S3 support To avoid the potential inconsistency between PcdAcpiS3Enable and QemuFwCfgS3Enabled(), this commit modifies LockBoxLib to detect S3 support by PcdAcpiS3Enable as modules in MdeModulePkg do. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3573 Signed-off-by: Gary Lin Reviewed-by: Philippe Mathieu-Daude Reviewed-by: Gerd Hoffmann Reviewed-by: Jiewen Yao Tested-by: Jim Fehlig commit cb0d24637dfdd869618b9635dfb8e3b0746393a6 Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:31:12 2021 +0800 OvmfPkg/OvmfXen: set PcdAcpiS3Enable at initialization There are several functions in OvmfPkg/Library using QemuFwCfgS3Enabled() to detect the S3 support status. However, in MdeModulePkg, PcdAcpiS3Enable is used to check S3 support. Since InitializeXenPlatform() didn't set PcdAcpiS3Enable as InitializePlatform() did, this made the inconsistency between drivers/functions. For example, S3SaveStateDxe checked PcdAcpiS3Enable and skipped S3BootScript because the default value is FALSE. On the other hand, PlatformBootManagerBeforeConsole() from OvmfPkg/Library called QemuFwCfgS3Enabled() and found it returned TRUE, so it invoked SaveS3BootScript(). However, S3SaveStateDxe skipped S3BootScript, so SaveS3BootScript() asserted due to EFI_NOT_FOUND. This issue mainly affects "HVM Direct Kernel Boot". When used, "fw_cfg" is enabled in QEMU and QemuFwCfgS3Enabled() returns true in that case. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3573 Signed-off-by: Gary Lin Reviewed-by: Anthony PERARD Reviewed-by: Gerd Hoffmann Reviewed-by: Jiewen Yao Tested-by: Jim Fehlig From xen-devel-bounces@lists.xenproject.org Sat Sep 04 06:38:21 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 04 Sep 2021 06:38:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.178611.324688 (Exim 4.92) (envelope-from ) id 1mMPJW-0007p9-SN; Sat, 04 Sep 2021 06:38:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 178611.324688; Sat, 04 Sep 2021 06:38:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMPJW-0007p2-Op; Sat, 04 Sep 2021 06:38:06 +0000 Received: by outflank-mailman (input) for mailman id 178611; Sat, 04 Sep 2021 06:38:05 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMPJV-0007oq-Kq; Sat, 04 Sep 2021 06:38:05 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMPJV-0005XQ-Bb; Sat, 04 Sep 2021 06:38:05 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMPJV-0003md-0S; Sat, 04 Sep 2021 06:38:05 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mMPJU-0002YX-WD; Sat, 04 Sep 2021 06:38:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=SrH0xbq8PMwzRBkCG1Z2oCZs1PbIgQc0nT6JJRq59jU=; b=0IHtH+F0eh5l1u39CcfCGtU5Sc cwZFWJYLrSdw2JUA+WIVJD4vkifpqrGCk3UAFn5i3T5l4TmKcu9tmDgpQ8O94xXEy/up+uDwffrvK tQUSP7SuJL6jJZDtJ7JePxhkTQzGeo8meBGie6DnSrVZos43XJW+mMVZQD3FGY5XQ9nM=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 164802: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=81d71fb86e1ad676e94becb7ffffb403cefd3019 X-Osstest-Versions-That: ovmf=cae735f61328d64e2e8991036707b9e78c0f5f63 From: osstest service owner Date: Sat, 04 Sep 2021 06:38:04 +0000 flight 164802 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/164802/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 164674 build-amd64-xsm 6 xen-build fail REGR. vs. 164674 build-i386-xsm 6 xen-build fail REGR. vs. 164674 build-i386 6 xen-build fail REGR. vs. 164674 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 81d71fb86e1ad676e94becb7ffffb403cefd3019 baseline version: ovmf cae735f61328d64e2e8991036707b9e78c0f5f63 Last test of basis 164674 2021-08-31 02:56:52 Z 4 days Failing since 164686 2021-09-01 03:03:43 Z 3 days 25 attempts Testing same since 164788 2021-09-03 04:12:12 Z 1 days 6 attempts ------------------------------------------------------------ People who touched revisions under test: Anthony PERARD DunTan Gary Lin Hao A Wu Jim Fehlig Lin, Gary (HPS OE-Linux) Loo Tung Lun Loo, Tung Lun Mark Wilson Marvin H?user Rebecca Cran Wenxing Hou Wenyi Xie jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit 81d71fb86e1ad676e94becb7ffffb403cefd3019 Author: Hao A Wu Date: Fri Aug 20 13:36:56 2021 +0800 Maintainers.txt: Update maintainer/reviewer roles in MdeModulePkg Remove Hao A Wu as the MdeModulePkg maintainer. Add Liming Gao as the MdeModulePkg maintainer. Remove Hao A Wu as the MdeModulePkg: Firmware Update modules reviewer. Remove Hao A Wu as the MdeModulePkg: Serial modules reviewer. Cc: Jian J Wang Cc: Liming Gao Cc: Guomin Jiang Cc: Ray Ni Cc: Zhichao Gao Signed-off-by: Hao A Wu Reviewed-by: Liming Gao Reviewed-by: Zhichao Gao commit c5e805ffe1098601e84fd501d5fa1d45e9d96a62 Author: Rebecca Cran Date: Tue Aug 31 06:36:36 2021 +0800 MdeModulePkg: Fix typo of "memory" in RamDiskDxe debug message Fix a typo of "memory" in a debug message in RamDiskProtocol.c. Signed-off-by: Rebecca Cran Reviewed-by: Hao A Wu Reviewed-by: Philippe Mathieu-Daude commit b6bc203375b6efb6822ee4fe4a59be4f1918436b Author: Wenyi Xie Date: Thu Aug 26 09:16:03 2021 +0800 MdeModulePkg/HiiDatabaseDxe:remove dead code block As the if statement outside has confirmed that BlockData->Name == NULL, so the if statement inside is always false. Cc: Jian J Wang Cc: Hao A Wu Cc: Dandan Bi Cc: Eric Dong Signed-off-by: Wenyi Xie Reviewed-by: Dandan Bi commit e3ee8c8dbd7a9f7d7905abe17be60354c9f5f9a3 Author: duntan Date: Fri Aug 20 14:43:37 2021 +0800 .azurepipelines: Add UefiPayloadPkg in gate-build-job.yml and CISetting.py Add UefiPayloadPkg in gate-build-job.yml to enable Core ci for UefiPayloadPkg. Add UefiPayloadPkg to supported Packages in CISettings. Cc: Sean Brogan Cc: Bret Barkelew Cc: Michael D Kinney Cc: Liming Gao Signed-off-by: DunTan Reviewed-by: Liming Gao commit 63fddc98e06c380e654b1cfbaf24b9fd922adfad Author: duntan Date: Fri Aug 20 14:43:36 2021 +0800 UefiPayloadPkg: Create .yaml file in UefiPayloadPkg Create .yaml file in UefiPayloadPkg to enable Core ci for UefiPayloadPkg Cc: Guo Dong Cc: Ray Ni Cc: Maurice Ma Cc: Benjamin You Signed-off-by: DunTan Reviewed-by: Liming Gao commit 12e33dca4c0612a0975265e5ba641c6261a26455 Author: Loo, Tung Lun Date: Tue Aug 17 15:43:12 2021 +0800 IntelFsp2Pkg: Support Config File and Binary delta comparison BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3567 This patch is to enable config editor to have a new feature that can spell out the delta between the default configuration files' data, such as YAML and BSF, against the data stored in the binary. This can help users understand and track the difference when modifications are made. Cc: Maurice Ma Cc: Nate DeSimone Cc: Star Zeng Cc: Chasel Chiu Signed-off-by: Loo Tung Lun Reviewed-by: Chasel Chiu commit b170806518c1e414939c8b085866544814e1ce8e Author: Mark Wilson Date: Fri Nov 13 08:05:18 2020 +0800 UefiCpuPkg: Clean up save state boundary checks and comments. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2956 In functions ReadSaveStateRegisterByIndex and WriteSaveStateRegister: * check width > 4 instead of >= 4 when writing upper 32 bytes. - This improves the code but will not affect functionality. Cc: Eric Dong Reviewed-by: Ray Ni Signed-off-by: Mark Wilson commit 3b3f88228812e2c642eea8746858a4dad928ebf7 Author: Marvin H?user Date: Mon Aug 9 14:09:25 2021 +0800 MdeModulePkg/PiSmmCore: Drop deprecated image profiling commands The legacy codebase allowed SMM images to be registered for profiling from DXE. Support for this has been dropped entirely, so remove the remaining handlers. Cc: Jian J Wang Cc: Hao A Wu Cc: Eric Dong Reviewed-by: Ray Ni Cc: Vitaly Cheptsov Signed-off-by: Marvin H?user commit cdda3f74a1327663a5d48cca13507085ba403af7 Author: Marvin H?user Date: Mon Aug 9 03:39:53 2021 +0800 UefiPayloadPkg/UefiPayloadEntry: Fix memory corruption UefiPayloadEntry's AllocatePool() applies the "sizeof" operator to HOB index rather than the HOB header structure. This yields 4 Bytes compared to the 8 Bytes the structure header requires. Fix the call to allocate the required space instead. Reviewed-by: Guo Dong Reviewed-by: Ray Ni Cc: Maurice Ma Cc: Benjamin You Cc: Vitaly Cheptsov Signed-off-by: Marvin H?user commit 5d34cc49d5d348012fe8acf9fb618826bd541a7c Author: Wenxing Hou Date: Tue Aug 24 16:11:11 2021 +0800 UefiCpuPkg/PiSmmCpuDxeSmm: Update mPatchCetSupported set condition REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3584 Function AsmCpuid should first check the value for Basic CPUID Information. The fix is to update the mPatchCetSupported judgment statement. Signed-off-by: Wenxing Hou Reviewed-by: Ray Ni Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Cc: Sheng W Cc: Yao Jiewen commit f0fe55bca4651734abf1752a1d7c69fb5bee00b9 Author: duntan Date: Fri Aug 20 13:04:29 2021 +0800 UefiPayloadPkg: Fix the build error when enable Core ci for UefiPayloadPkg V1: Add quotes when using $(ARCH) in .dsc and .fdf file. The quotes are added due to the way by which Core ci parse the .dsc file. Add UINTN in Hob.c to fix cast from pointer to integer of different size error. V2: Delete lines which reference ShellBinPkg.The pkg doesn't exist in edk2. Cc: Guo Dong Cc: Ray Ni Cc: Maurice Ma Cc: Benjamin You Signed-off-by: DunTan Reviewed-by: Ray Ni commit 9f3eda177a4b2d4a33ff1b0307cad42906396562 Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:29:48 2021 +0800 OvmfPkg/OvmfXen: add QemuKernelLoaderFsDxe Without QemuKernelLoaderFsDxe, QemuLoadKernelImage() couldn't download the kernel, initrd, and kernel command line from QEMU's fw_cfg. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3574 Signed-off-by: Gary Lin Acked-by: Anthony PERARD Reviewed-by: Philippe Mathieu-Daude Reviewed-by: Gerd Hoffmann Tested-by: Jim Fehlig commit 5b5f10d7465004e3e40ec1f50a3b490b4db595e7 Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:31:15 2021 +0800 OvmfPkg/SmmControl2Dxe: use PcdAcpiS3Enable to detect S3 support To avoid the potential inconsistency between PcdAcpiS3Enable and QemuFwCfgS3Enabled(), this commit modifies SmmControl2Dxe to detect S3 support by PcdAcpiS3Enable as modules in MdeModulePkg do. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3573 Signed-off-by: Gary Lin Reviewed-by: Gerd Hoffmann Reviewed-by: Jiewen Yao Tested-by: Jim Fehlig commit 52e2dabc0f8d3af09c213072ce8ba734302f585d Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:31:14 2021 +0800 OvmfPkg/PlatformBootManagerLib: use PcdAcpiS3Enable to detect S3 support To avoid the potential inconsistency between PcdAcpiS3Enable and QemuFwCfgS3Enabled(), this commit modifies PlatformBootManagerLib to detect S3 support by PcdAcpiS3Enable as modules in MdeModulePkg do. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3573 Signed-off-by: Gary Lin Reviewed-by: Gerd Hoffmann Reviewed-by: Jiewen Yao Tested-by: Jim Fehlig commit 28152333bccb778b62e6e97446b28bfa0e92ef82 Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:31:13 2021 +0800 OvmfPkg/LockBoxLib: use PcdAcpiS3Enable to detect S3 support To avoid the potential inconsistency between PcdAcpiS3Enable and QemuFwCfgS3Enabled(), this commit modifies LockBoxLib to detect S3 support by PcdAcpiS3Enable as modules in MdeModulePkg do. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3573 Signed-off-by: Gary Lin Reviewed-by: Philippe Mathieu-Daude Reviewed-by: Gerd Hoffmann Reviewed-by: Jiewen Yao Tested-by: Jim Fehlig commit cb0d24637dfdd869618b9635dfb8e3b0746393a6 Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:31:12 2021 +0800 OvmfPkg/OvmfXen: set PcdAcpiS3Enable at initialization There are several functions in OvmfPkg/Library using QemuFwCfgS3Enabled() to detect the S3 support status. However, in MdeModulePkg, PcdAcpiS3Enable is used to check S3 support. Since InitializeXenPlatform() didn't set PcdAcpiS3Enable as InitializePlatform() did, this made the inconsistency between drivers/functions. For example, S3SaveStateDxe checked PcdAcpiS3Enable and skipped S3BootScript because the default value is FALSE. On the other hand, PlatformBootManagerBeforeConsole() from OvmfPkg/Library called QemuFwCfgS3Enabled() and found it returned TRUE, so it invoked SaveS3BootScript(). However, S3SaveStateDxe skipped S3BootScript, so SaveS3BootScript() asserted due to EFI_NOT_FOUND. This issue mainly affects "HVM Direct Kernel Boot". When used, "fw_cfg" is enabled in QEMU and QemuFwCfgS3Enabled() returns true in that case. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3573 Signed-off-by: Gary Lin Reviewed-by: Anthony PERARD Reviewed-by: Gerd Hoffmann Reviewed-by: Jiewen Yao Tested-by: Jim Fehlig From xen-devel-bounces@lists.xenproject.org Sat Sep 04 07:48:40 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 04 Sep 2021 07:48:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.178644.324720 (Exim 4.92) (envelope-from ) id 1mMQPW-00004r-Mz; Sat, 04 Sep 2021 07:48:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 178644.324720; Sat, 04 Sep 2021 07:48:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMQPW-0008WQ-JV; Sat, 04 Sep 2021 07:48:22 +0000 Received: by outflank-mailman (input) for mailman id 178644; Sat, 04 Sep 2021 07:48:21 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMQPV-0008WG-K8; Sat, 04 Sep 2021 07:48:21 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMQPV-0006hn-Ef; Sat, 04 Sep 2021 07:48:21 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMQPV-000096-3a; Sat, 04 Sep 2021 07:48:21 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mMQPV-0007Kk-36; Sat, 04 Sep 2021 07:48:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=tx6n7jqUgf2Jb8dXbHRt/okq7iZnCXTSEOEJfvDRPMU=; b=yXZ59f9hfrFth4RmqsHW/hKgdP sAAw0StGAvzWFSBKPO2PBtSzyZKb3rZZmng6jU/tc/C19QWqun+SwmtgqPNpFB4syUvEcO1/iELXt xSo9PA8odrF+PUBc65hnY3lw8bwUcgG7yAx6KKOKORmb2R9Bs3Ed/7Ft4t+Fuz29699U=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 164798: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=2d4978ead4b98452bc45ebe47952e524b12e2b41 X-Osstest-Versions-That: xen=96607a8e680e7f965ca868d11f8b0636317d2618 From: osstest service owner Date: Sat, 04 Sep 2021 07:48:21 +0000 flight 164798 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/164798/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 164786 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 164786 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 164786 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 164786 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 164786 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 164786 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 164786 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 164786 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 164786 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 164786 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 164786 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen 2d4978ead4b98452bc45ebe47952e524b12e2b41 baseline version: xen 96607a8e680e7f965ca868d11f8b0636317d2618 Last test of basis 164786 2021-09-03 01:51:45 Z 1 days Testing same since 164798 2021-09-03 17:37:46 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Christian Lindig Ian Jackson Jan Beulich jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 96607a8e68..2d4978ead4 2d4978ead4b98452bc45ebe47952e524b12e2b41 -> master From xen-devel-bounces@lists.xenproject.org Sat Sep 04 09:29:12 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 04 Sep 2021 09:29:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.178669.324746 (Exim 4.92) (envelope-from ) id 1mMRyr-0003UP-Jz; Sat, 04 Sep 2021 09:28:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 178669.324746; Sat, 04 Sep 2021 09:28:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMRyr-0003UI-GP; Sat, 04 Sep 2021 09:28:57 +0000 Received: by outflank-mailman (input) for mailman id 178669; Sat, 04 Sep 2021 09:28:55 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMRyp-0003U8-Lh; Sat, 04 Sep 2021 09:28:55 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMRyp-0000gL-BM; Sat, 04 Sep 2021 09:28:55 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMRyp-0005b2-31; Sat, 04 Sep 2021 09:28:55 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mMRyp-0005v1-2X; Sat, 04 Sep 2021 09:28:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=/Cfieg3LyQJJJNaxExgkYGhHXNGypfCl0VIfHdwXYZA=; b=u4YQ7lGOFYJyhCUKhopCjzJXKi zPrUC5ec3t1+aylIZ5vTl4HPXrGzfn1sb6/zACtuhltTzwx/X7BKFM98XFWWE59CPbkU5Rm6/R/9d 4IM79KIOKG5o1iLQFVQ480p2EaxrclrnMHzSbLxEVW1z6uvRDaHAzNIpt56icMrekSvs=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 164804: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=81d71fb86e1ad676e94becb7ffffb403cefd3019 X-Osstest-Versions-That: ovmf=cae735f61328d64e2e8991036707b9e78c0f5f63 From: osstest service owner Date: Sat, 04 Sep 2021 09:28:55 +0000 flight 164804 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/164804/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 164674 build-amd64-xsm 6 xen-build fail REGR. vs. 164674 build-i386-xsm 6 xen-build fail REGR. vs. 164674 build-i386 6 xen-build fail REGR. vs. 164674 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf 81d71fb86e1ad676e94becb7ffffb403cefd3019 baseline version: ovmf cae735f61328d64e2e8991036707b9e78c0f5f63 Last test of basis 164674 2021-08-31 02:56:52 Z 4 days Failing since 164686 2021-09-01 03:03:43 Z 3 days 26 attempts Testing same since 164788 2021-09-03 04:12:12 Z 1 days 7 attempts ------------------------------------------------------------ People who touched revisions under test: Anthony PERARD DunTan Gary Lin Hao A Wu Jim Fehlig Lin, Gary (HPS OE-Linux) Loo Tung Lun Loo, Tung Lun Mark Wilson Marvin H?user Rebecca Cran Wenxing Hou Wenyi Xie jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit 81d71fb86e1ad676e94becb7ffffb403cefd3019 Author: Hao A Wu Date: Fri Aug 20 13:36:56 2021 +0800 Maintainers.txt: Update maintainer/reviewer roles in MdeModulePkg Remove Hao A Wu as the MdeModulePkg maintainer. Add Liming Gao as the MdeModulePkg maintainer. Remove Hao A Wu as the MdeModulePkg: Firmware Update modules reviewer. Remove Hao A Wu as the MdeModulePkg: Serial modules reviewer. Cc: Jian J Wang Cc: Liming Gao Cc: Guomin Jiang Cc: Ray Ni Cc: Zhichao Gao Signed-off-by: Hao A Wu Reviewed-by: Liming Gao Reviewed-by: Zhichao Gao commit c5e805ffe1098601e84fd501d5fa1d45e9d96a62 Author: Rebecca Cran Date: Tue Aug 31 06:36:36 2021 +0800 MdeModulePkg: Fix typo of "memory" in RamDiskDxe debug message Fix a typo of "memory" in a debug message in RamDiskProtocol.c. Signed-off-by: Rebecca Cran Reviewed-by: Hao A Wu Reviewed-by: Philippe Mathieu-Daude commit b6bc203375b6efb6822ee4fe4a59be4f1918436b Author: Wenyi Xie Date: Thu Aug 26 09:16:03 2021 +0800 MdeModulePkg/HiiDatabaseDxe:remove dead code block As the if statement outside has confirmed that BlockData->Name == NULL, so the if statement inside is always false. Cc: Jian J Wang Cc: Hao A Wu Cc: Dandan Bi Cc: Eric Dong Signed-off-by: Wenyi Xie Reviewed-by: Dandan Bi commit e3ee8c8dbd7a9f7d7905abe17be60354c9f5f9a3 Author: duntan Date: Fri Aug 20 14:43:37 2021 +0800 .azurepipelines: Add UefiPayloadPkg in gate-build-job.yml and CISetting.py Add UefiPayloadPkg in gate-build-job.yml to enable Core ci for UefiPayloadPkg. Add UefiPayloadPkg to supported Packages in CISettings. Cc: Sean Brogan Cc: Bret Barkelew Cc: Michael D Kinney Cc: Liming Gao Signed-off-by: DunTan Reviewed-by: Liming Gao commit 63fddc98e06c380e654b1cfbaf24b9fd922adfad Author: duntan Date: Fri Aug 20 14:43:36 2021 +0800 UefiPayloadPkg: Create .yaml file in UefiPayloadPkg Create .yaml file in UefiPayloadPkg to enable Core ci for UefiPayloadPkg Cc: Guo Dong Cc: Ray Ni Cc: Maurice Ma Cc: Benjamin You Signed-off-by: DunTan Reviewed-by: Liming Gao commit 12e33dca4c0612a0975265e5ba641c6261a26455 Author: Loo, Tung Lun Date: Tue Aug 17 15:43:12 2021 +0800 IntelFsp2Pkg: Support Config File and Binary delta comparison BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3567 This patch is to enable config editor to have a new feature that can spell out the delta between the default configuration files' data, such as YAML and BSF, against the data stored in the binary. This can help users understand and track the difference when modifications are made. Cc: Maurice Ma Cc: Nate DeSimone Cc: Star Zeng Cc: Chasel Chiu Signed-off-by: Loo Tung Lun Reviewed-by: Chasel Chiu commit b170806518c1e414939c8b085866544814e1ce8e Author: Mark Wilson Date: Fri Nov 13 08:05:18 2020 +0800 UefiCpuPkg: Clean up save state boundary checks and comments. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2956 In functions ReadSaveStateRegisterByIndex and WriteSaveStateRegister: * check width > 4 instead of >= 4 when writing upper 32 bytes. - This improves the code but will not affect functionality. Cc: Eric Dong Reviewed-by: Ray Ni Signed-off-by: Mark Wilson commit 3b3f88228812e2c642eea8746858a4dad928ebf7 Author: Marvin H?user Date: Mon Aug 9 14:09:25 2021 +0800 MdeModulePkg/PiSmmCore: Drop deprecated image profiling commands The legacy codebase allowed SMM images to be registered for profiling from DXE. Support for this has been dropped entirely, so remove the remaining handlers. Cc: Jian J Wang Cc: Hao A Wu Cc: Eric Dong Reviewed-by: Ray Ni Cc: Vitaly Cheptsov Signed-off-by: Marvin H?user commit cdda3f74a1327663a5d48cca13507085ba403af7 Author: Marvin H?user Date: Mon Aug 9 03:39:53 2021 +0800 UefiPayloadPkg/UefiPayloadEntry: Fix memory corruption UefiPayloadEntry's AllocatePool() applies the "sizeof" operator to HOB index rather than the HOB header structure. This yields 4 Bytes compared to the 8 Bytes the structure header requires. Fix the call to allocate the required space instead. Reviewed-by: Guo Dong Reviewed-by: Ray Ni Cc: Maurice Ma Cc: Benjamin You Cc: Vitaly Cheptsov Signed-off-by: Marvin H?user commit 5d34cc49d5d348012fe8acf9fb618826bd541a7c Author: Wenxing Hou Date: Tue Aug 24 16:11:11 2021 +0800 UefiCpuPkg/PiSmmCpuDxeSmm: Update mPatchCetSupported set condition REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3584 Function AsmCpuid should first check the value for Basic CPUID Information. The fix is to update the mPatchCetSupported judgment statement. Signed-off-by: Wenxing Hou Reviewed-by: Ray Ni Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Cc: Sheng W Cc: Yao Jiewen commit f0fe55bca4651734abf1752a1d7c69fb5bee00b9 Author: duntan Date: Fri Aug 20 13:04:29 2021 +0800 UefiPayloadPkg: Fix the build error when enable Core ci for UefiPayloadPkg V1: Add quotes when using $(ARCH) in .dsc and .fdf file. The quotes are added due to the way by which Core ci parse the .dsc file. Add UINTN in Hob.c to fix cast from pointer to integer of different size error. V2: Delete lines which reference ShellBinPkg.The pkg doesn't exist in edk2. Cc: Guo Dong Cc: Ray Ni Cc: Maurice Ma Cc: Benjamin You Signed-off-by: DunTan Reviewed-by: Ray Ni commit 9f3eda177a4b2d4a33ff1b0307cad42906396562 Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:29:48 2021 +0800 OvmfPkg/OvmfXen: add QemuKernelLoaderFsDxe Without QemuKernelLoaderFsDxe, QemuLoadKernelImage() couldn't download the kernel, initrd, and kernel command line from QEMU's fw_cfg. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3574 Signed-off-by: Gary Lin Acked-by: Anthony PERARD Reviewed-by: Philippe Mathieu-Daude Reviewed-by: Gerd Hoffmann Tested-by: Jim Fehlig commit 5b5f10d7465004e3e40ec1f50a3b490b4db595e7 Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:31:15 2021 +0800 OvmfPkg/SmmControl2Dxe: use PcdAcpiS3Enable to detect S3 support To avoid the potential inconsistency between PcdAcpiS3Enable and QemuFwCfgS3Enabled(), this commit modifies SmmControl2Dxe to detect S3 support by PcdAcpiS3Enable as modules in MdeModulePkg do. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3573 Signed-off-by: Gary Lin Reviewed-by: Gerd Hoffmann Reviewed-by: Jiewen Yao Tested-by: Jim Fehlig commit 52e2dabc0f8d3af09c213072ce8ba734302f585d Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:31:14 2021 +0800 OvmfPkg/PlatformBootManagerLib: use PcdAcpiS3Enable to detect S3 support To avoid the potential inconsistency between PcdAcpiS3Enable and QemuFwCfgS3Enabled(), this commit modifies PlatformBootManagerLib to detect S3 support by PcdAcpiS3Enable as modules in MdeModulePkg do. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3573 Signed-off-by: Gary Lin Reviewed-by: Gerd Hoffmann Reviewed-by: Jiewen Yao Tested-by: Jim Fehlig commit 28152333bccb778b62e6e97446b28bfa0e92ef82 Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:31:13 2021 +0800 OvmfPkg/LockBoxLib: use PcdAcpiS3Enable to detect S3 support To avoid the potential inconsistency between PcdAcpiS3Enable and QemuFwCfgS3Enabled(), this commit modifies LockBoxLib to detect S3 support by PcdAcpiS3Enable as modules in MdeModulePkg do. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3573 Signed-off-by: Gary Lin Reviewed-by: Philippe Mathieu-Daude Reviewed-by: Gerd Hoffmann Reviewed-by: Jiewen Yao Tested-by: Jim Fehlig commit cb0d24637dfdd869618b9635dfb8e3b0746393a6 Author: Lin, Gary (HPS OE-Linux) Date: Tue Aug 31 09:31:12 2021 +0800 OvmfPkg/OvmfXen: set PcdAcpiS3Enable at initialization There are several functions in OvmfPkg/Library using QemuFwCfgS3Enabled() to detect the S3 support status. However, in MdeModulePkg, PcdAcpiS3Enable is used to check S3 support. Since InitializeXenPlatform() didn't set PcdAcpiS3Enable as InitializePlatform() did, this made the inconsistency between drivers/functions. For example, S3SaveStateDxe checked PcdAcpiS3Enable and skipped S3BootScript because the default value is FALSE. On the other hand, PlatformBootManagerBeforeConsole() from OvmfPkg/Library called QemuFwCfgS3Enabled() and found it returned TRUE, so it invoked SaveS3BootScript(). However, S3SaveStateDxe skipped S3BootScript, so SaveS3BootScript() asserted due to EFI_NOT_FOUND. This issue mainly affects "HVM Direct Kernel Boot". When used, "fw_cfg" is enabled in QEMU and QemuFwCfgS3Enabled() returns true in that case. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3573 Signed-off-by: Gary Lin Reviewed-by: Anthony PERARD Reviewed-by: Gerd Hoffmann Reviewed-by: Jiewen Yao Tested-by: Jim Fehlig From xen-devel-bounces@lists.xenproject.org Sat Sep 04 10:25:32 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 04 Sep 2021 10:25:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.178679.324760 (Exim 4.92) (envelope-from ) id 1mMSrQ-0002B4-2F; Sat, 04 Sep 2021 10:25:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 178679.324760; Sat, 04 Sep 2021 10:25:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMSrP-0002Ax-Te; Sat, 04 Sep 2021 10:25:19 +0000 Received: by outflank-mailman (input) for mailman id 178679; Sat, 04 Sep 2021 10:25:18 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMSrO-0002An-RV; Sat, 04 Sep 2021 10:25:18 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMSrO-0001hL-N7; Sat, 04 Sep 2021 10:25:18 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMSrO-0007uB-Di; Sat, 04 Sep 2021 10:25:18 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mMSrO-0001Be-DA; Sat, 04 Sep 2021 10:25:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=4MAAGzAf8C3aoSrTzXOJZvvCtrTOVf5RkZ8al5VcYIk=; b=pJNxb23TnPq8lqzfNowEMUz2By T4et/y/KCX9KJa/qFOHiJ5jWjJW/uWMNuY0RPzVDITpkRYmKS5u4nXliL+jJY361olsoYQTBQ9t8N 6aWE3fDm3heaEAQsVbHUwSVejIsBhlm6yN04nerxkmsHabOUy6wp9i7qgNJY3vKAUrck=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 164799: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=8880cc4362fde4ecdac0b2092318893118206fcf X-Osstest-Versions-That: qemuu=8664d30a30fd676b56b4c29dbcbdd5c5538acfc1 From: osstest service owner Date: Sat, 04 Sep 2021 10:25:18 +0000 flight 164799 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/164799/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 164792 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 164792 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 164792 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 164792 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 164792 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 164792 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 164792 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass version targeted for testing: qemuu 8880cc4362fde4ecdac0b2092318893118206fcf baseline version: qemuu 8664d30a30fd676b56b4c29dbcbdd5c5538acfc1 Last test of basis 164792 2021-09-03 07:39:10 Z 1 days Testing same since 164799 2021-09-03 19:38:03 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Christian Schoenebeck Peter Maydell jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git 8664d30a30..8880cc4362 8880cc4362fde4ecdac0b2092318893118206fcf -> upstream-tested From xen-devel-bounces@lists.xenproject.org Sat Sep 04 10:29:22 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 04 Sep 2021 10:29:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.178686.324774 (Exim 4.92) (envelope-from ) id 1mMSvD-0002sN-If; Sat, 04 Sep 2021 10:29:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 178686.324774; Sat, 04 Sep 2021 10:29:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMSvD-0002sG-FO; Sat, 04 Sep 2021 10:29:15 +0000 Received: by outflank-mailman (input) for mailman id 178686; Sat, 04 Sep 2021 10:29:13 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMSvB-0002s6-TD; Sat, 04 Sep 2021 10:29:13 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMSvB-0001k2-Pq; Sat, 04 Sep 2021 10:29:13 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMSvB-00084H-GD; Sat, 04 Sep 2021 10:29:13 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mMSvB-0003k2-Fh; Sat, 04 Sep 2021 10:29:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=yjsxcA4NL86rfu6zlr1Qcpmjsacil1hSskvxdkkpu7o=; b=af4XRfQ9HosA1NW6ROZ9vtRlRJ EB8oxnDGD1f0EjPSxK2halFkbXJHvbTZg3dWwZDTvfBqOGES6hOgdid6A/eaI1Id9EcoZrKsM2s5f 3CCBMNxXhNgh7PwtSJ4ARAeXVkELYFbYmgcntaZzJOelf3WkCvC+TOYLX7PF2ZgljZ88=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 164806: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=edf8bc6d24c6f490c27de3144eee88f1ca40ce6a X-Osstest-Versions-That: ovmf=cae735f61328d64e2e8991036707b9e78c0f5f63 From: osstest service owner Date: Sat, 04 Sep 2021 10:29:13 +0000 flight 164806 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/164806/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 164674 build-amd64-xsm 6 xen-build fail REGR. vs. 164674 build-i386-xsm 6 xen-build fail REGR. vs. 164674 build-i386 6 xen-build fail REGR. vs. 164674 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf edf8bc6d24c6f490c27de3144eee88f1ca40ce6a baseline version: ovmf cae735f61328d64e2e8991036707b9e78c0f5f63 Last test of basis 164674 2021-08-31 02:56:52 Z 4 days Failing since 164686 2021-09-01 03:03:43 Z 3 days 27 attempts Testing same since 164806 2021-09-04 09:41:21 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Anthony PERARD DunTan Gary Lin Hao A Wu Jim Fehlig Lin, Gary (HPS OE-Linux) Loo Tung Lun Loo, Tung Lun Mark Wilson Marvin H?user Michael Kubacki Rebecca Cran Wenxing Hou Wenyi Xie jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 302 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Sep 04 12:05:00 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 04 Sep 2021 12:05:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.178699.324788 (Exim 4.92) (envelope-from ) id 1mMUPd-0005m3-RA; Sat, 04 Sep 2021 12:04:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 178699.324788; Sat, 04 Sep 2021 12:04:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMUPd-0005lw-NH; Sat, 04 Sep 2021 12:04:45 +0000 Received: by outflank-mailman (input) for mailman id 178699; Sat, 04 Sep 2021 12:04:44 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMUPc-0005lm-Ni; Sat, 04 Sep 2021 12:04:44 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMUPc-0003GM-HL; Sat, 04 Sep 2021 12:04:44 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMUPc-0003CV-8T; Sat, 04 Sep 2021 12:04:44 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mMUPc-0008N8-80; Sat, 04 Sep 2021 12:04:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=PFMNO0QEM5lG58zh52CPD1s//6Ms9MNrf4aY0nhcpwM=; b=1ViEmBH/EW3vss63NxEVxX/5uq BDU2TBoDoBoJ+bOQYsILfiKz4Z5SjXM/NZB6X1+ys4Ta2dAGLfMYYZD7IdnMAmYc0pVRSn8xwH8IG JK/0tlllm8OZUQ1bFRYGKd3w9fpFiehJFggVKTMZk8mFCr7RQz1ZkVL4ScnBYX8gSXNI=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 164803: regressions - FAIL X-Osstest-Failures: libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=b6ec01b82154c9dc25f18c9c28df30d0c053defe X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Sat, 04 Sep 2021 12:04:44 +0000 flight 164803 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/164803/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a version targeted for testing: libvirt b6ec01b82154c9dc25f18c9c28df30d0c053defe baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 421 days Failing since 151818 2020-07-11 04:18:52 Z 420 days 411 attempts Testing same since 164803 2021-09-04 04:20:08 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Andika Triwidada Andrea Bolognani Balázs Meskó Barrett Schonefeld Bastian Germann Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Bjoern Walk Boris Fiuczynski Brian Turek Bruno Haible Chris Mayo Christian Ehrhardt Christian Kirbach Christian Schoenebeck Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé Didik Supriadi Dmytro Linkin Eiichi Tsukata Eric Farman Erik Skultety Fabian Affolter Fabian Freyer Fabiano Fidêncio Fangge Jin Farhan Ali Fedora Weblate Translation gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Hela Basa Helmut Grohne Ian Wienand Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen jason lee Jean-Baptiste Holcroft Jia Zhou Jianan Gao Jim Fehlig Jin Yan Jinsheng Zhang Jiri Denemark John Ferlan Jonathan Watt Jonathon Jongsma Julio Faracco Justin Gatzen Ján Tomko Kashyap Chamarthy Kevin Locke Kristina Hanicova Laine Stump Laszlo Ersek Lee Yarwood Liao Pingfang Lin Ma Lin Ma Lin Ma Liu Yiding Luke Yue Luyao Zhong Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Markus Schade Martin Kletzander Masayoshi Mizuma Matej Cepl Matt Coleman Matt Coleman Mauro Matteo Cascella Meina Li Michal Privoznik Michał Smyk Milo Casagrande Moshe Levi Muha Aliss Nathan Neal Gompa Nick Shyrokovskiy Nickys Music Group Nico Pache Nikolay Shirokovskiy Olaf Hering Olesya Gerasimenko Orion Poplawski Pany Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Richard W.M. Jones Ricky Tigg Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Shambarger Sebastian Mitterle SeongHyun Jo Shalini Chellathurai Saroja Shaojun Yang Shi Lei simmon Simon Chopin Simon Gaiser Simon Rowe Stefan Bader Stefan Berger Stefan Berger Stefan Hajnoczi Szymon Scholz Thomas Huth Tim Wiederhake Tomáš Golembiovský Tomáš Janoušek Tuguoyi Ville Skyttä Vinayak Kale Wang Xin WangJian Weblate Wei Liu Wei Liu William Douglas Yalei Li <274268859@qq.com> Yalei Li Yang Fei Yang Hang Yanqiu Zhang Yaroslav Kargin Yi Li Yi Wang Yuri Chornoivan Zbigniew Jędrzejewski-Szmek zhangjl02 Zheng Chuan zhenwei pi Zhenyu Ye Zhenyu Zheng Zhenzhong Duan jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 71803 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Sep 04 14:28:53 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 04 Sep 2021 14:28:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.178734.324802 (Exim 4.92) (envelope-from ) id 1mMWet-0004PU-W5; Sat, 04 Sep 2021 14:28:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 178734.324802; Sat, 04 Sep 2021 14:28:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMWet-0004PN-SO; Sat, 04 Sep 2021 14:28:39 +0000 Received: by outflank-mailman (input) for mailman id 178734; Sat, 04 Sep 2021 14:28:38 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMWes-0004PD-6X; Sat, 04 Sep 2021 14:28:38 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMWer-0005eF-Ne; Sat, 04 Sep 2021 14:28:37 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMWer-0000rc-EE; Sat, 04 Sep 2021 14:28:37 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mMWer-0006RF-Dg; Sat, 04 Sep 2021 14:28:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=L4dfjSPnMwfuD0VJbj+aT9SXnk8TfkWrBOjQJNU9DVU=; b=FEVzBDHsRHwcwjylWnpIfHXW5v zsncELZua2UkjhmGVbt4fawgcev851bdyddMe8CjjebxTIymcCw3BVOZhwIOnhcOg6SCz18gzJee6 laefZP2+IlalGIiMYZ02XaDVkdBS4EFy8L9u7x4WQwytwHBW0/vdQ/dx1rz3o4A9uMac=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 164801: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-i386-xl-qemut-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-examine:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-i386-xl-raw:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-pvshim:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-i386:xen-install:fail:regression linux-linus:test-amd64-i386-xl-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ovmf-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-coresched-i386-xl:xen-install:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-arm64-arm64-xl-credit1:debian-fixup:fail:regression linux-linus:test-arm64-arm64-xl-thunderx:debian-fixup:fail:regression linux-linus:test-arm64-arm64-xl:debian-fixup:fail:regression linux-linus:test-arm64-arm64-xl-xsm:debian-fixup:fail:regression linux-linus:test-arm64-arm64-xl-credit2:debian-fixup:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:debian-fixup:fail:regression linux-linus:test-amd64-amd64-xl-shadow:guest-start/debian.repeat:fail:regression linux-linus:test-amd64-amd64-examine:memdisk-try-append:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=f1583cb1be35c23df60b1c39e3e7e6704d749d0b X-Osstest-Versions-That: linux=deacdb3e3979979016fcd0ffd518c320a62ad166 From: osstest service owner Date: Sat, 04 Sep 2021 14:28:37 +0000 flight 164801 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/164801/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemut-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-examine 6 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-i386-xl-raw 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-pvshim 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-i386 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ovmf-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-coresched-i386-xl 7 xen-install fail REGR. vs. 152332 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 152332 test-arm64-arm64-examine 8 reboot fail REGR. vs. 152332 test-arm64-arm64-xl-credit1 13 debian-fixup fail REGR. vs. 152332 test-arm64-arm64-xl-thunderx 13 debian-fixup fail REGR. vs. 152332 test-arm64-arm64-xl 13 debian-fixup fail REGR. vs. 152332 test-arm64-arm64-xl-xsm 13 debian-fixup fail REGR. vs. 152332 test-arm64-arm64-xl-credit2 13 debian-fixup fail REGR. vs. 152332 test-arm64-arm64-libvirt-xsm 13 debian-fixup fail REGR. vs. 152332 test-amd64-amd64-xl-shadow 22 guest-start/debian.repeat fail REGR. vs. 152332 test-amd64-amd64-examine 4 memdisk-try-append fail REGR. vs. 152332 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 152332 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 152332 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152332 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152332 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 152332 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152332 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail like 152332 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152332 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: linux f1583cb1be35c23df60b1c39e3e7e6704d749d0b baseline version: linux deacdb3e3979979016fcd0ffd518c320a62ad166 Last test of basis 152332 2020-07-31 19:41:23 Z 399 days Failing since 152366 2020-08-01 20:49:34 Z 398 days 691 attempts Testing same since 164801 2021-09-04 01:12:40 Z 0 days 1 attempts ------------------------------------------------------------ 7203 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl fail test-armhf-armhf-xl pass test-amd64-i386-xl fail test-amd64-coresched-i386-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm fail test-amd64-i386-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm fail test-amd64-i386-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine pass test-arm64-arm64-examine fail test-armhf-armhf-examine pass test-amd64-i386-examine fail test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel fail test-amd64-i386-qemuu-rhel6hvm-intel fail test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair fail test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow fail test-amd64-i386-xl-shadow fail test-arm64-arm64-xl-thunderx fail test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2211696 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Sep 04 15:12:26 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 04 Sep 2021 15:12:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.178747.324834 (Exim 4.92) (envelope-from ) id 1mMXLA-0002Do-Qz; Sat, 04 Sep 2021 15:12:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 178747.324834; Sat, 04 Sep 2021 15:12:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMXLA-0002Dh-Nq; Sat, 04 Sep 2021 15:12:20 +0000 Received: by outflank-mailman (input) for mailman id 178747; Sat, 04 Sep 2021 15:12:19 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMXL9-0001n1-DE for xen-devel@lists.xenproject.org; Sat, 04 Sep 2021 15:12:19 +0000 Received: from mail-io1-xd2a.google.com (unknown [2607:f8b0:4864:20::d2a]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 02e1509f-60cd-4cfd-943a-dd85528f12ed; Sat, 04 Sep 2021 15:12:13 +0000 (UTC) Received: by mail-io1-xd2a.google.com with SMTP id z1so2674159ioh.7 for ; Sat, 04 Sep 2021 08:12:13 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 02e1509f-60cd-4cfd-943a-dd85528f12ed DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=unixindia.com; s=mail; h=mime-version:from:date:message-id:subject:to; bh=pWt61Hm0SnYMak2zE6TxuNgLfbDZ8EXWGBHuDC9vfNo=; b=g88JVThzb2JAnZfM/5MOidhBsqJY+bJvMZgZqXlMWGinkwCFeq6kzUINkKBYJAYZU7 mYr+f+5Z3gDw+R8VI+K8mdd+Su2OJdYP9clU+oUBjVYw7jyUmY2XBhJe77jtxFoTNOBN u42zDC4CPdplnPvdfsOfplyVgUF5p/OzvORvBNJS1uX2yCjbjevnMc2Su6WhxxBQO9hP loQVTTSEjLS6GHfh0tcsjbuS3oT2yAaC5zrH1SYWiLrl5PY3xs4bUg+j7tBXCuiHuZs2 TYCs7RkwHEyklYsItJ0DaTjznHKhm9pJPypxk+DDmuoA4YLPUeEfG9jT2jYmxtVx4gjZ R/5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=pWt61Hm0SnYMak2zE6TxuNgLfbDZ8EXWGBHuDC9vfNo=; b=fkPPAmN2Bf4JlMwdCXsI3agwEGYMlTb0cq7nRhUMfJu1Uq6mAaYq2z2WhQqeZRjMV3 GSGvAGPs6pDLZvwKvpUEwRqqoayjCaVpRsJFkXRn/oS6xYX/Pf9klouEUFj1wB1d9A8s RD1Y1tJLTowayLUskZGHVx8hUl5iRg5iVpj0G6RWcyfIv7wxMDvWsUMMsJt6bGp/QCBx RIQls3VMJ4cWgnABw5hKavo4AyVvcTPIYGUFPHul5s+iJr/COl2Vw0z5xp2j+i+oGc2q nJgD6mDnxpyfQcILb9f+HK3POPty766s5WG+Er0gy6H1DJ0869pdyD5/yqfbFUZ3EHF6 bi6g== X-Gm-Message-State: AOAM5331kJ12gHtiq8zcB/WKWXphhgrliELyRmu5Ovg65k2V/3ii4P/w wPPHQvZkxozjmPJuvw/hx7lruCUGwY1qY0Cvl8dEX1JwTud3wpVvsfQ= X-Google-Smtp-Source: ABdhPJwSvIUeRvrvCIQfenu9f5WaY1Iqrvp5MotteTEVGvNe+xr2GDWj0n4ors9QO4Fx1DXafKJtLkQjLOyQDeZ51BI= X-Received: by 2002:a05:6638:4195:: with SMTP id az21mr3666596jab.40.1630768332265; Sat, 04 Sep 2021 08:12:12 -0700 (PDT) MIME-Version: 1.0 From: Bhasker C V Date: Sat, 4 Sep 2021 16:12:01 +0100 Message-ID: Subject: Help with Network SR-IOV (PF still in reset state. Is the PF interface up?) To: xen-devel@lists.xenproject.org, xen-users@lists.xenproject.org Content-Type: multipart/alternative; boundary="00000000000027f14e05cb2cd71c" --00000000000027f14e05cb2cd71c Content-Type: text/plain; charset="UTF-8" I run xen-4.14.3-pre from debian I created 6 vfs for my igb card 06:00.0 Ethernet controller: Intel Corporation I350 Gigabit Network Connection (rev 01) I got these 07:10.0 Ethernet controller: Intel Corporation I350 Ethernet Controller Virtual Function (rev 01) 07:10.1 Ethernet controller: Intel Corporation I350 Ethernet Controller Virtual Function (rev 01) 07:10.4 Ethernet controller: Intel Corporation I350 Ethernet Controller Virtual Function (rev 01) 07:10.5 Ethernet controller: Intel Corporation I350 Ethernet Controller Virtual Function (rev 01) 07:11.0 Ethernet controller: Intel Corporation I350 Ethernet Controller Virtual Function (rev 01) 07:11.1 Ethernet controller: Intel Corporation I350 Ethernet Controller Virtual Function (rev 01) bcv@bcvibmb1:~$ sudo xl pci-assignable-list 0000:07:10.1 However the guest is not able to see the link up. bcv@utils:~$ sudo ethtool enp0s0f1 Settings for enp0s0f1: Supported ports: [ ] ... Link detected: no I see this error on the guest [ 6.134890] igbvf 0000:00:00.1: Xen PCI mapped GSI0 to IRQ19 [ 6.149577] igbvf 0000:00:00.1: PF still in reset state. Is the PF interface up? [ 6.149595] igbvf 0000:00:00.1: Assigning random MAC address. [ 6.151552] igbvf 0000:00:00.1: PF still resetting [ 6.153807] igbvf 0000:00:00.1: Intel(R) I350 Virtual Function [ 6.153822] igbvf 0000:00:00.1: Address: 32:91:70:c5:62:bd and thiis on the host: [ 390.776779] xen-blkback: backend/vbd/3/51713: using 1 queues, protocol 1 (x86_64-abi) persistent grants [ 395.849996] pciback 0000:07:10.1: xen-pciback: Driver tried to write to a read-only configuration space field at offset 0x1d6, size 2. This may be harmless, but if you have problems with your device: [ 395.849996] 1) see permissive attribute in sysfs [ 395.849996] 2) report problems to the xen-devel mailing list along with details of your device obtained from lspci. [ 396.103595] pciback 0000:07:10.1: enabling device (0000 -> 0002) However if I pass through 07:10.4 it works fine. The host still reports this above error but all works well in the guest. Please could someone help ? I have been using KVM these years and just moved to xen and hence new to xen. Regards Bhasker C V --00000000000027f14e05cb2cd71c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: base64 PGRpdiBkaXI9Imx0ciI+PGRpdj5JIHJ1bsKgIHhlbi00LjE0LjMtcHJlIGZyb20gZGViaWFuPC9k aXY+PGRpdj48YnI+PC9kaXY+PGRpdj5JIGNyZWF0ZWQgNiB2ZnMgZm9yIG15IGlnYiBjYXJkIDxi cj48L2Rpdj48ZGl2PjA2OjAwLjAgRXRoZXJuZXQgY29udHJvbGxlcjogSW50ZWwgQ29ycG9yYXRp b24gSTM1MCBHaWdhYml0IE5ldHdvcmsgQ29ubmVjdGlvbiAocmV2IDAxKTwvZGl2PjxkaXY+SSBn b3QgdGhlc2U8L2Rpdj48ZGl2PjA3OjEwLjAgRXRoZXJuZXQgY29udHJvbGxlcjogSW50ZWwgQ29y cG9yYXRpb24gSTM1MCBFdGhlcm5ldCBDb250cm9sbGVyIFZpcnR1YWwgRnVuY3Rpb24gKHJldiAw MSk8YnI+MDc6MTAuMSBFdGhlcm5ldCBjb250cm9sbGVyOiBJbnRlbCBDb3Jwb3JhdGlvbiBJMzUw IEV0aGVybmV0IENvbnRyb2xsZXIgVmlydHVhbCBGdW5jdGlvbiAocmV2IDAxKTxicj4wNzoxMC40 IEV0aGVybmV0IGNvbnRyb2xsZXI6IEludGVsIENvcnBvcmF0aW9uIEkzNTAgRXRoZXJuZXQgQ29u dHJvbGxlciBWaXJ0dWFsIEZ1bmN0aW9uIChyZXYgMDEpPGJyPjA3OjEwLjUgRXRoZXJuZXQgY29u dHJvbGxlcjogSW50ZWwgQ29ycG9yYXRpb24gSTM1MCBFdGhlcm5ldCBDb250cm9sbGVyIFZpcnR1 YWwgRnVuY3Rpb24gKHJldiAwMSk8YnI+MDc6MTEuMCBFdGhlcm5ldCBjb250cm9sbGVyOiBJbnRl bCBDb3Jwb3JhdGlvbiBJMzUwIEV0aGVybmV0IENvbnRyb2xsZXIgVmlydHVhbCBGdW5jdGlvbiAo cmV2IDAxKTxicj4wNzoxMS4xIEV0aGVybmV0IGNvbnRyb2xsZXI6IEludGVsIENvcnBvcmF0aW9u IEkzNTAgRXRoZXJuZXQgQ29udHJvbGxlciBWaXJ0dWFsIEZ1bmN0aW9uIChyZXYgMDEpPC9kaXY+ PGRpdj48YnI+PC9kaXY+PGRpdj5iY3ZAYmN2aWJtYjE6fiQgc3VkbyB4bCBwY2ktYXNzaWduYWJs ZS1saXN0PGJyPjAwMDA6MDc6MTAuMTwvZGl2PjxkaXY+PGJyPjwvZGl2PjxkaXY+SG93ZXZlciB0 aGUgZ3Vlc3QgaXMgbm90IGFibGUgdG8gc2VlIHRoZSBsaW5rIHVwLiA8YnI+PC9kaXY+PGRpdj5i Y3ZAdXRpbHM6fiQgc3VkbyBldGh0b29sIMKgZW5wMHMwZjEgwqAgwqAgwqAgwqAgwqAgwqAgwqAg wqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAg wqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAg wqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAg wqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAg wqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAg wqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAg wqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgPGJyPlNldHRpbmdzIGZvciBlbnAwczBmMTogwqAg wqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAg wqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAg wqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAg wqAgwqAgwqAgwqAgwqA8YnI+wqAgwqAgwqAgwqAgU3VwcG9ydGVkIHBvcnRzOiBbIF0gwqAgPGJy PjwvZGl2PjxkaXY+Li4uwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAg wqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAg wqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAg wqAgwqAgwqAgwqDCoCA8YnI+wqAgwqAgwqAgwqAgTGluayBkZXRlY3RlZDogbm8gwqAgwqAgwqAg wqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgPGJyPjwvZGl2PjxkaXY+PGJyPjwvZGl2 PjxkaXY+SSBzZWUgdGhpcyBlcnJvciBvbiB0aGUgZ3Vlc3Q8YnI+PC9kaXY+PGRpdj48YnI+PC9k aXY+PGRpdj5bIMKgIMKgNi4xMzQ4OTBdIGlnYnZmIDAwMDA6MDA6MDAuMTogWGVuIFBDSSBtYXBw ZWQgR1NJMCB0byBJUlExOSDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC oCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC oCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCA8YnI+WyDCoCDCoDYuMTQ5NTc3XSBpZ2J2ZiAw MDAwOjAwOjAwLjE6IFBGIHN0aWxsIGluIHJlc2V0IHN0YXRlLiBJcyB0aGUgUEYgaW50ZXJmYWNl IHVwPyDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC oCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCA8YnI+WyDCoCDCoDYu MTQ5NTk1XSBpZ2J2ZiAwMDAwOjAwOjAwLjE6IEFzc2lnbmluZyByYW5kb20gTUFDIGFkZHJlc3Mu IMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKg IMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKg IMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKg IMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKg IMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKg IMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKg IMKgIMKgPGJyPlsgwqAgwqA2LjE1MTU1Ml0gaWdidmYgMDAwMDowMDowMC4xOiBQRiBzdGlsbCBy ZXNldHRpbmcgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAg wqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAg wqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgPGJyPlsgwqAgwqA2LjE1MzgwN10g aWdidmYgMDAwMDowMDowMC4xOiBJbnRlbChSKSBJMzUwIFZpcnR1YWwgRnVuY3Rpb24gwqAgwqAg wqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAg wqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAg wqAgPGJyPlsgwqAgwqA2LjE1MzgyMl0gaWdidmYgMDAwMDowMDowMC4xOiBBZGRyZXNzOiAzMjo5 MTo3MDpjNTo2MjpiZCDCoCDCoCA8YnI+PC9kaXY+PGRpdj48YnI+PC9kaXY+PGRpdj48YnI+PC9k aXY+PGRpdj5hbmQgdGhpaXMgb24gdGhlIGhvc3Q6PC9kaXY+PGRpdj5bIMKgMzkwLjc3Njc3OV0g eGVuLWJsa2JhY2s6IGJhY2tlbmQvdmJkLzMvNTE3MTM6IHVzaW5nIDEgcXVldWVzLCBwcm90b2Nv bCAxICh4ODZfNjQtYWJpKSBwZXJzaXN0ZW50IGdyYW50cyDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC oCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC oCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC oCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC oCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC oCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoDxicj5bIMKgMzk1Ljg0OTk5Nl0gcGNp YmFjayAwMDAwOjA3OjEwLjE6IHhlbi1wY2liYWNrOiBEcml2ZXIgdHJpZWQgdG8gd3JpdGUgdG8g YSByZWFkLW9ubHkgY29uZmlndXJhdGlvbiBzcGFjZSBmaWVsZCBhdCBvZmZzZXQgMHgxZDYsIHNp emUgMi4gVGhpcyBtYXkgYmUgaGFybWxlc3MsIGJ1dCBpZiB5b3UgaGF2ZSBwcm9ibGVtcyB3aXRo IHlvdXIgZGV2aWNlOiDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC oCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC oCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoDxicj5bIMKgMzk1Ljg0OTk5 Nl0gMSkgc2VlIHBlcm1pc3NpdmUgYXR0cmlidXRlIGluIHN5c2ZzIMKgIMKgIMKgIMKgIMKgIMKg IMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKg IMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKg IMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKg IMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKg IMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKg IMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKg IMKgIMKgIDxicj5bIMKgMzk1Ljg0OTk5Nl0gMikgcmVwb3J0IHByb2JsZW1zIHRvIHRoZSB4ZW4t ZGV2ZWwgbWFpbGluZyBsaXN0IGFsb25nIHdpdGggZGV0YWlscyBvZiB5b3VyIGRldmljZSBvYnRh aW5lZCBmcm9tIGxzcGNpLiDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC oCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC oCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC oCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC oCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoDxi cj5bIMKgMzk2LjEwMzU5NV0gcGNpYmFjayAwMDAwOjA3OjEwLjE6IGVuYWJsaW5nIGRldmljZSAo MDAwMCAtJmd0OyAwMDAyKSDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC oCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC oCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoMKgIDxicj48L2Rpdj48ZGl2 Pjxicj48L2Rpdj48ZGl2Pjxicj48L2Rpdj48ZGl2Pkhvd2V2ZXIgaWYgSSBwYXNzIHRocm91Z2gg MDc6MTAuNCBpdCB3b3JrcyBmaW5lLiBUaGUgaG9zdCBzdGlsbCByZXBvcnRzIHRoaXPCoCBhYm92 ZSBlcnJvciBidXQgYWxsIHdvcmtzIHdlbGwgaW4gdGhlIGd1ZXN0LiA8YnI+PC9kaXY+PGRpdj48 YnI+PC9kaXY+PGRpdj48YnI+PC9kaXY+PGRpdj5QbGVhc2UgY291bGQgc29tZW9uZSBoZWxwID8g SSBoYXZlIGJlZW4gdXNpbmfCoCBLVk0gdGhlc2UgeWVhcnMgYW5kIGp1c3QgbW92ZWQgdG8geGVu IGFuZCBoZW5jZSBuZXcgdG8geGVuLiA8YnI+PC9kaXY+PGRpdj48YnI+PC9kaXY+PGRpdj48YnI+ PC9kaXY+PGRpdj5SZWdhcmRzPC9kaXY+PGRpdj5CaGFza2VyIEMgViA8YnI+PC9kaXY+PC9kaXY+ DQo= --00000000000027f14e05cb2cd71c-- From xen-devel-bounces@lists.xenproject.org Sat Sep 04 16:00:38 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 04 Sep 2021 16:00:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.178774.324845 (Exim 4.92) (envelope-from ) id 1mMY5f-0000TH-JO; Sat, 04 Sep 2021 16:00:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 178774.324845; Sat, 04 Sep 2021 16:00:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMY5f-0000TA-GR; Sat, 04 Sep 2021 16:00:23 +0000 Received: by outflank-mailman (input) for mailman id 178774; Sat, 04 Sep 2021 16:00:22 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMY5e-0000T0-Fa; Sat, 04 Sep 2021 16:00:22 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMY5e-0007hq-9r; Sat, 04 Sep 2021 16:00:22 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMY5d-0006lP-VM; Sat, 04 Sep 2021 16:00:22 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mMY5d-0001HQ-Un; Sat, 04 Sep 2021 16:00:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=q3+FfTdm1kQmBM3m39fmMOD8YsgQcNKDLtjj7gPBDvs=; b=3a3rmehfQtK2K1QINqKzTc8vHA eUNZt1IbkJ7129v0Vvt+EOaUiPjkTEyY9ShSkPOAyoojNXWT9QAWV80BIL7+mpt6FvbHrbSJOhjz8 vxnh6WlnrSsnLwga97kaqLQ6AZb1iwk2JW3kbY9T8EZuGHAvV94G0Lco1b9Btmn60/LQ=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 164807: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64:xen-build:fail:regression ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=edf8bc6d24c6f490c27de3144eee88f1ca40ce6a X-Osstest-Versions-That: ovmf=cae735f61328d64e2e8991036707b9e78c0f5f63 From: osstest service owner Date: Sat, 04 Sep 2021 16:00:21 +0000 flight 164807 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/164807/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 164674 build-amd64-xsm 6 xen-build fail REGR. vs. 164674 build-i386-xsm 6 xen-build fail REGR. vs. 164674 build-i386 6 xen-build fail REGR. vs. 164674 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf edf8bc6d24c6f490c27de3144eee88f1ca40ce6a baseline version: ovmf cae735f61328d64e2e8991036707b9e78c0f5f63 Last test of basis 164674 2021-08-31 02:56:52 Z 4 days Failing since 164686 2021-09-01 03:03:43 Z 3 days 28 attempts Testing same since 164806 2021-09-04 09:41:21 Z 0 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Anthony PERARD DunTan Gary Lin Hao A Wu Jim Fehlig Lin, Gary (HPS OE-Linux) Loo Tung Lun Loo, Tung Lun Mark Wilson Marvin H?user Michael Kubacki Rebecca Cran Wenxing Hou Wenyi Xie jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 302 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Sep 04 16:46:24 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 04 Sep 2021 16:46:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.178782.324859 (Exim 4.92) (envelope-from ) id 1mMYo3-0005T3-5B; Sat, 04 Sep 2021 16:46:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 178782.324859; Sat, 04 Sep 2021 16:46:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMYo3-0005Sw-1Y; Sat, 04 Sep 2021 16:46:15 +0000 Received: by outflank-mailman (input) for mailman id 178782; Sat, 04 Sep 2021 16:46:14 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMYo1-0005Sm-W6; Sat, 04 Sep 2021 16:46:14 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMYo1-0008S1-QY; Sat, 04 Sep 2021 16:46:13 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMYo1-0000Q7-GW; Sat, 04 Sep 2021 16:46:13 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mMYo1-0002ta-Fu; Sat, 04 Sep 2021 16:46:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=AwVyevIkjJoT6zcKO5brXg2C3X9huyq5lS+YkCe8IFk=; b=b6izB5v3G9PsDzQAdmb/ZG48+p DDD+TB0gaChMtWbLMleQRZtJa3ii5wu0uKrptzgZm9pn3nGbTmh7oDddfld+bDzsH7e3UxDOPFVXF +Sy7XJ6fLSSDltwqvJIYb8xCT0PpTS2TwQXnnosC9wzD+7MrDNArM5v3X1sPRJy7rv24=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 164809: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=edf8bc6d24c6f490c27de3144eee88f1ca40ce6a X-Osstest-Versions-That: ovmf=cae735f61328d64e2e8991036707b9e78c0f5f63 From: osstest service owner Date: Sat, 04 Sep 2021 16:46:13 +0000 flight 164809 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/164809/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 164674 build-amd64 6 xen-build fail REGR. vs. 164674 build-i386-xsm 6 xen-build fail REGR. vs. 164674 build-i386 6 xen-build fail REGR. vs. 164674 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf edf8bc6d24c6f490c27de3144eee88f1ca40ce6a baseline version: ovmf cae735f61328d64e2e8991036707b9e78c0f5f63 Last test of basis 164674 2021-08-31 02:56:52 Z 4 days Failing since 164686 2021-09-01 03:03:43 Z 3 days 29 attempts Testing same since 164806 2021-09-04 09:41:21 Z 0 days 3 attempts ------------------------------------------------------------ People who touched revisions under test: Anthony PERARD DunTan Gary Lin Hao A Wu Jim Fehlig Lin, Gary (HPS OE-Linux) Loo Tung Lun Loo, Tung Lun Mark Wilson Marvin H?user Michael Kubacki Rebecca Cran Wenxing Hou Wenyi Xie jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 302 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Sep 04 17:59:10 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 04 Sep 2021 17:59:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.178793.324873 (Exim 4.92) (envelope-from ) id 1mMZwM-00053l-Jp; Sat, 04 Sep 2021 17:58:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 178793.324873; Sat, 04 Sep 2021 17:58:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMZwM-00053e-Gn; Sat, 04 Sep 2021 17:58:54 +0000 Received: by outflank-mailman (input) for mailman id 178793; Sat, 04 Sep 2021 17:58:53 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMZwL-00053T-97; Sat, 04 Sep 2021 17:58:53 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMZwL-0001Ck-4l; Sat, 04 Sep 2021 17:58:53 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMZwK-0003zM-TO; Sat, 04 Sep 2021 17:58:52 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mMZwK-00071R-Sp; Sat, 04 Sep 2021 17:58:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=HB9mNXQmN/WgFWwkPdT9tYaWiu8gr7t+ts0tREWVgRo=; b=1HXsyaJeNgLYtZAjZWewfB/Nm0 ZYTEfn6G/uzd8GBsY7V+VjYoRCAYKnDOK2ZkGpzIAlFepq4TQojdGlQkqQ1PJhMEEKbl8l+OxeKia GojuNRqkhELdilRW5NJFCcQnV1d409HHKoNfcb9xAg50ioHBIvjSmRQgY4yPrMhLtSGU=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 164810: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=edf8bc6d24c6f490c27de3144eee88f1ca40ce6a X-Osstest-Versions-That: ovmf=cae735f61328d64e2e8991036707b9e78c0f5f63 From: osstest service owner Date: Sat, 04 Sep 2021 17:58:52 +0000 flight 164810 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/164810/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 164674 build-amd64 6 xen-build fail REGR. vs. 164674 build-i386-xsm 6 xen-build fail REGR. vs. 164674 build-i386 6 xen-build fail REGR. vs. 164674 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf edf8bc6d24c6f490c27de3144eee88f1ca40ce6a baseline version: ovmf cae735f61328d64e2e8991036707b9e78c0f5f63 Last test of basis 164674 2021-08-31 02:56:52 Z 4 days Failing since 164686 2021-09-01 03:03:43 Z 3 days 30 attempts Testing same since 164806 2021-09-04 09:41:21 Z 0 days 4 attempts ------------------------------------------------------------ People who touched revisions under test: Anthony PERARD DunTan Gary Lin Hao A Wu Jim Fehlig Lin, Gary (HPS OE-Linux) Loo Tung Lun Loo, Tung Lun Mark Wilson Marvin H?user Michael Kubacki Rebecca Cran Wenxing Hou Wenyi Xie jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 302 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Sep 04 18:30:31 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 04 Sep 2021 18:30:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.178801.324887 (Exim 4.92) (envelope-from ) id 1mMaQq-0001CV-2d; Sat, 04 Sep 2021 18:30:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 178801.324887; Sat, 04 Sep 2021 18:30:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMaQp-0001CO-Vj; Sat, 04 Sep 2021 18:30:23 +0000 Received: by outflank-mailman (input) for mailman id 178801; Sat, 04 Sep 2021 18:30:22 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMaQo-0001CE-N4; Sat, 04 Sep 2021 18:30:22 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMaQo-0001q2-ID; Sat, 04 Sep 2021 18:30:22 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMaQo-0004t5-8K; Sat, 04 Sep 2021 18:30:22 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mMaQo-0000fy-7r; Sat, 04 Sep 2021 18:30:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=GDQ5HNgOXvGnGl+eo+lPZdzeyV57exp7uq77fJPi3BA=; b=StZdsILmMtvMvQSJ977nFumLLP xATeaYeL0Bpp7IzFVpQP3jNYK3xWTOtZ+zcLQZuAChGlVN4AaPQDoI+I/dkdPqW+XXCdKEDA7kQk7 j9i9K1jz7mQN0sMJUNo+8fIBk6fcidkrFzqXz3jFOsOUr3or9oV55j0/yX5EWTC6NeS4=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 164811: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=edf8bc6d24c6f490c27de3144eee88f1ca40ce6a X-Osstest-Versions-That: ovmf=cae735f61328d64e2e8991036707b9e78c0f5f63 From: osstest service owner Date: Sat, 04 Sep 2021 18:30:22 +0000 flight 164811 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/164811/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 164674 build-amd64 6 xen-build fail REGR. vs. 164674 build-i386-xsm 6 xen-build fail REGR. vs. 164674 build-i386 6 xen-build fail REGR. vs. 164674 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf edf8bc6d24c6f490c27de3144eee88f1ca40ce6a baseline version: ovmf cae735f61328d64e2e8991036707b9e78c0f5f63 Last test of basis 164674 2021-08-31 02:56:52 Z 4 days Failing since 164686 2021-09-01 03:03:43 Z 3 days 31 attempts Testing same since 164806 2021-09-04 09:41:21 Z 0 days 5 attempts ------------------------------------------------------------ People who touched revisions under test: Anthony PERARD DunTan Gary Lin Hao A Wu Jim Fehlig Lin, Gary (HPS OE-Linux) Loo Tung Lun Loo, Tung Lun Mark Wilson Marvin H?user Michael Kubacki Rebecca Cran Wenxing Hou Wenyi Xie jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 302 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Sep 04 18:45:21 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 04 Sep 2021 18:45:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.178808.324901 (Exim 4.92) (envelope-from ) id 1mMafF-00035K-E5; Sat, 04 Sep 2021 18:45:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 178808.324901; Sat, 04 Sep 2021 18:45:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMafF-00035D-B4; Sat, 04 Sep 2021 18:45:17 +0000 Received: by outflank-mailman (input) for mailman id 178808; Sat, 04 Sep 2021 18:45:16 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMafE-000353-4J; Sat, 04 Sep 2021 18:45:16 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMafD-00024k-Ob; Sat, 04 Sep 2021 18:45:15 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMafD-0005HZ-DQ; Sat, 04 Sep 2021 18:45:15 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mMafD-00058B-D0; Sat, 04 Sep 2021 18:45:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=A7dIeSiEAANhcoTXS32pJzlQXY/UJCootyM8uL/n2ug=; b=Byhock5rhDA36ZiPBD6rHNp8u3 JNNk5CZk7xYl16e8MSm4ZisO879JooajO5KkyuzTARwRsu23OjmNWXP0r9uiqRQKU4G2t9PCSRizi 02cse2n9bJklsSpQovf+COz37oxtjGlFZzChWVG8jjkM45cKSF5khvlGW4fplbxJRsZ0=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 164805: tolerable FAIL X-Osstest-Failures: xen-unstable:test-amd64-amd64-qemuu-freebsd11-amd64:guest-start/freebsd.repeat:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=2d4978ead4b98452bc45ebe47952e524b12e2b41 X-Osstest-Versions-That: xen=2d4978ead4b98452bc45ebe47952e524b12e2b41 From: osstest service owner Date: Sat, 04 Sep 2021 18:45:15 +0000 flight 164805 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/164805/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-qemuu-freebsd11-amd64 21 guest-start/freebsd.repeat fail pass in 164798 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 164798 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 164798 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 164798 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 164798 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 164798 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 164798 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 164798 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 164798 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 164798 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 164798 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 164798 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen 2d4978ead4b98452bc45ebe47952e524b12e2b41 baseline version: xen 2d4978ead4b98452bc45ebe47952e524b12e2b41 Last test of basis 164805 2021-09-04 07:50:13 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 fail test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Sat Sep 04 19:55:45 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 04 Sep 2021 19:55:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.178816.324915 (Exim 4.92) (envelope-from ) id 1mMblF-0002WM-Td; Sat, 04 Sep 2021 19:55:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 178816.324915; Sat, 04 Sep 2021 19:55:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMblF-0002WF-PT; Sat, 04 Sep 2021 19:55:33 +0000 Received: by outflank-mailman (input) for mailman id 178816; Sat, 04 Sep 2021 19:55:32 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMblE-0002W5-Gi; Sat, 04 Sep 2021 19:55:32 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMblE-0003Mm-Bu; Sat, 04 Sep 2021 19:55:32 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMblE-0007YM-3c; Sat, 04 Sep 2021 19:55:32 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mMblE-0007pU-32; Sat, 04 Sep 2021 19:55:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=NKiU4iFKWN+jJqM36rnU6s02nGmpDXUAt9myllV5FdI=; b=28YSqCtezJ6SehNdpYh9D6xyrK E2w7Klo1kyFt7uUBJeAzbMl0NLVP0bIphgMdIgB10Y8TUfjNYXX4Rr4I4t+XveH8XnjFFpX7ugsGP ItuOEEx2advRe2lJ3OiJ7dJPzWmAE4uYfkK6QZ6hS1KkMTZD00Lv0jrybppLopYplQYo=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 164813: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=edf8bc6d24c6f490c27de3144eee88f1ca40ce6a X-Osstest-Versions-That: ovmf=cae735f61328d64e2e8991036707b9e78c0f5f63 From: osstest service owner Date: Sat, 04 Sep 2021 19:55:32 +0000 flight 164813 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/164813/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 164674 build-amd64 6 xen-build fail REGR. vs. 164674 build-i386-xsm 6 xen-build fail REGR. vs. 164674 build-i386 6 xen-build fail REGR. vs. 164674 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf edf8bc6d24c6f490c27de3144eee88f1ca40ce6a baseline version: ovmf cae735f61328d64e2e8991036707b9e78c0f5f63 Last test of basis 164674 2021-08-31 02:56:52 Z 4 days Failing since 164686 2021-09-01 03:03:43 Z 3 days 32 attempts Testing same since 164806 2021-09-04 09:41:21 Z 0 days 6 attempts ------------------------------------------------------------ People who touched revisions under test: Anthony PERARD DunTan Gary Lin Hao A Wu Jim Fehlig Lin, Gary (HPS OE-Linux) Loo Tung Lun Loo, Tung Lun Mark Wilson Marvin H?user Michael Kubacki Rebecca Cran Wenxing Hou Wenyi Xie jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 302 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Sep 04 21:12:39 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 04 Sep 2021 21:12:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.178828.324929 (Exim 4.92) (envelope-from ) id 1mMcxf-00038d-RC; Sat, 04 Sep 2021 21:12:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 178828.324929; Sat, 04 Sep 2021 21:12:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMcxf-00038W-OB; Sat, 04 Sep 2021 21:12:27 +0000 Received: by outflank-mailman (input) for mailman id 178828; Sat, 04 Sep 2021 21:12:27 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMcxf-00038M-84; Sat, 04 Sep 2021 21:12:27 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMcxe-0004jd-Pw; Sat, 04 Sep 2021 21:12:26 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMcxe-0001kF-Gy; Sat, 04 Sep 2021 21:12:26 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mMcxe-0007HK-GR; Sat, 04 Sep 2021 21:12:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=S4QbXQrJ6ct940T99uQdSQC4rlnJHB8hF68DdyRzobw=; b=PE8gZC4L/A5Tf0NlPTjuBxo4LX NYic5TayfoYqX3M86E2Lu2Kh5m/WglkgavcxeiRY8KWXxZISw+Ywm55u7j0rf7vEYEe8Vh4JvjQuV tHoz0y67H60c9V2Lqr7XzGckOsQyX1i1orlDzY0K7qOrLq6dwgGsTLiLLOb5y+mGXiPY=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 164814: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=edf8bc6d24c6f490c27de3144eee88f1ca40ce6a X-Osstest-Versions-That: ovmf=cae735f61328d64e2e8991036707b9e78c0f5f63 From: osstest service owner Date: Sat, 04 Sep 2021 21:12:26 +0000 flight 164814 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/164814/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 164674 build-amd64 6 xen-build fail REGR. vs. 164674 build-i386-xsm 6 xen-build fail REGR. vs. 164674 build-i386 6 xen-build fail REGR. vs. 164674 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf edf8bc6d24c6f490c27de3144eee88f1ca40ce6a baseline version: ovmf cae735f61328d64e2e8991036707b9e78c0f5f63 Last test of basis 164674 2021-08-31 02:56:52 Z 4 days Failing since 164686 2021-09-01 03:03:43 Z 3 days 33 attempts Testing same since 164806 2021-09-04 09:41:21 Z 0 days 7 attempts ------------------------------------------------------------ People who touched revisions under test: Anthony PERARD DunTan Gary Lin Hao A Wu Jim Fehlig Lin, Gary (HPS OE-Linux) Loo Tung Lun Loo, Tung Lun Mark Wilson Marvin H?user Michael Kubacki Rebecca Cran Wenxing Hou Wenyi Xie jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 302 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Sep 04 21:50:16 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 04 Sep 2021 21:50:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.178836.324943 (Exim 4.92) (envelope-from ) id 1mMdYA-0007fP-OV; Sat, 04 Sep 2021 21:50:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 178836.324943; Sat, 04 Sep 2021 21:50:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMdYA-0007fI-LM; Sat, 04 Sep 2021 21:50:10 +0000 Received: by outflank-mailman (input) for mailman id 178836; Sat, 04 Sep 2021 21:50:09 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMdY9-0007ep-Hx; Sat, 04 Sep 2021 21:50:09 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMdY9-0005L6-9J; Sat, 04 Sep 2021 21:50:09 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMdY8-00038R-V6; Sat, 04 Sep 2021 21:50:09 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mMdY8-0003RK-Uc; Sat, 04 Sep 2021 21:50:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=aI51K37+Hebz6ZjITKztpH420BB54RTCivzXOfkg/xE=; b=Iq+0CFIYiHNQjIOHEhnSiqkj2t nqGZbovzElJAuFJOe55PfvehABjmLW3J67+N9bibjMcyeu8HaQCfpz4OF7LMwi4r6qOeRTJj4Xf3M 6IjIXH+Y4d0KyLRP/Fw0MTQdySDLqXjg0f/rWQfc+JLuZNqAz4OPpAm9qd+DAYMbXXR4=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 164808: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-i386-xl-qemut-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-examine:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-i386-xl-raw:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-pvshim:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-i386:xen-install:fail:regression linux-linus:test-amd64-i386-xl-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ovmf-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-coresched-i386-xl:xen-install:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit1:debian-fixup:fail:regression linux-linus:test-arm64-arm64-xl-thunderx:debian-fixup:fail:regression linux-linus:test-arm64-arm64-xl:debian-fixup:fail:regression linux-linus:test-arm64-arm64-xl-xsm:debian-fixup:fail:regression linux-linus:test-arm64-arm64-xl-credit2:debian-fixup:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:debian-fixup:fail:regression linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-amd64-amd64-xl-shadow:guest-start/debian.repeat:fail:heisenbug linux-linus:test-amd64-amd64-examine:memdisk-try-append:fail:heisenbug linux-linus:test-amd64-amd64-xl-credit2:guest-start/debian.repeat:fail:heisenbug linux-linus:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=f1583cb1be35c23df60b1c39e3e7e6704d749d0b X-Osstest-Versions-That: linux=deacdb3e3979979016fcd0ffd518c320a62ad166 From: osstest service owner Date: Sat, 04 Sep 2021 21:50:08 +0000 flight 164808 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/164808/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemut-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-examine 6 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-i386-xl-raw 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-pvshim 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-i386 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ovmf-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-coresched-i386-xl 7 xen-install fail REGR. vs. 152332 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 152332 test-arm64-arm64-xl-credit1 13 debian-fixup fail REGR. vs. 152332 test-arm64-arm64-xl-thunderx 13 debian-fixup fail REGR. vs. 152332 test-arm64-arm64-xl 13 debian-fixup fail REGR. vs. 152332 test-arm64-arm64-xl-xsm 13 debian-fixup fail REGR. vs. 152332 test-arm64-arm64-xl-credit2 13 debian-fixup fail REGR. vs. 152332 test-arm64-arm64-libvirt-xsm 13 debian-fixup fail REGR. vs. 152332 test-arm64-arm64-examine 8 reboot fail REGR. vs. 152332 Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-shadow 22 guest-start/debian.repeat fail in 164801 pass in 164808 test-amd64-amd64-examine 4 memdisk-try-append fail in 164801 pass in 164808 test-amd64-amd64-xl-credit2 22 guest-start/debian.repeat fail pass in 164801 Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail in 164801 like 152332 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 152332 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 152332 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152332 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152332 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 152332 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152332 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152332 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: linux f1583cb1be35c23df60b1c39e3e7e6704d749d0b baseline version: linux deacdb3e3979979016fcd0ffd518c320a62ad166 Last test of basis 152332 2020-07-31 19:41:23 Z 400 days Failing since 152366 2020-08-01 20:49:34 Z 399 days 692 attempts Testing same since 164801 2021-09-04 01:12:40 Z 0 days 2 attempts ------------------------------------------------------------ 7203 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl fail test-armhf-armhf-xl pass test-amd64-i386-xl fail test-amd64-coresched-i386-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm fail test-amd64-i386-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm fail test-amd64-i386-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 fail test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine pass test-arm64-arm64-examine fail test-armhf-armhf-examine pass test-amd64-i386-examine fail test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel fail test-amd64-i386-qemuu-rhel6hvm-intel fail test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair fail test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow fail test-arm64-arm64-xl-thunderx fail test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2211696 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Sep 04 23:33:21 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 04 Sep 2021 23:33:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.178844.324956 (Exim 4.92) (envelope-from ) id 1mMf9n-0002BL-FO; Sat, 04 Sep 2021 23:33:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 178844.324956; Sat, 04 Sep 2021 23:33:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMf9n-0002BE-CQ; Sat, 04 Sep 2021 23:33:07 +0000 Received: by outflank-mailman (input) for mailman id 178844; Sat, 04 Sep 2021 23:33:06 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMf9m-0002B4-00; Sat, 04 Sep 2021 23:33:06 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMf9l-0006zh-Ox; Sat, 04 Sep 2021 23:33:05 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMf9l-0008AY-Hh; Sat, 04 Sep 2021 23:33:05 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mMf9l-00046C-HA; Sat, 04 Sep 2021 23:33:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=HuBX95klywY3zgntBcarUM5bpGmFXwEqmQCoRV4ULL4=; b=g/j26je5Vvs9FKj7Qk2SQWI0PG ynp0a/9WTnMtoVsgxohhIspGX383x+LuYD04l0CjV9MCi/DX2iiGZFi0925wtnGlCCDqoseQvL3Zz Cv8OeQ40syCYqq11J+ED0BQjw8hfoBdMVOJXSoI+kcutQW96Z9FORsr076WTx8eZbiiI=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 164815: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=edf8bc6d24c6f490c27de3144eee88f1ca40ce6a X-Osstest-Versions-That: ovmf=cae735f61328d64e2e8991036707b9e78c0f5f63 From: osstest service owner Date: Sat, 04 Sep 2021 23:33:05 +0000 flight 164815 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/164815/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 164674 build-amd64 6 xen-build fail REGR. vs. 164674 build-i386-xsm 6 xen-build fail REGR. vs. 164674 build-i386 6 xen-build fail REGR. vs. 164674 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf edf8bc6d24c6f490c27de3144eee88f1ca40ce6a baseline version: ovmf cae735f61328d64e2e8991036707b9e78c0f5f63 Last test of basis 164674 2021-08-31 02:56:52 Z 4 days Failing since 164686 2021-09-01 03:03:43 Z 3 days 34 attempts Testing same since 164806 2021-09-04 09:41:21 Z 0 days 8 attempts ------------------------------------------------------------ People who touched revisions under test: Anthony PERARD DunTan Gary Lin Hao A Wu Jim Fehlig Lin, Gary (HPS OE-Linux) Loo Tung Lun Loo, Tung Lun Mark Wilson Marvin H?user Michael Kubacki Rebecca Cran Wenxing Hou Wenyi Xie jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 302 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Sep 05 00:28:29 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 05 Sep 2021 00:28:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.178854.324970 (Exim 4.92) (envelope-from ) id 1mMg1I-0000F7-AO; Sun, 05 Sep 2021 00:28:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 178854.324970; Sun, 05 Sep 2021 00:28:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMg1I-0000F0-7N; Sun, 05 Sep 2021 00:28:24 +0000 Received: by outflank-mailman (input) for mailman id 178854; Sun, 05 Sep 2021 00:28:23 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMg1H-0000Eq-N0; Sun, 05 Sep 2021 00:28:23 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMg1H-0008Vc-I8; Sun, 05 Sep 2021 00:28:23 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMg1H-0003rz-AI; Sun, 05 Sep 2021 00:28:23 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mMg1H-0005ZG-9l; Sun, 05 Sep 2021 00:28:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=VCdKH9Ao3bzA3bm4VVT/EmzYfL0np/NifRsqL2VGpK8=; b=GkMVYYOhUKjJoa/injtdoYqHaa hqlBwy7v57m6B9dpM6hMoeECw669q8E877+NxH728TQgGZd4LLmac0ySg3IjRbMY5r7xazGVRITBI +ba5W9PtxodpuqchMpqt1lr02505mScXhzRgBJADTR9+c4x5baXpG6gvfpAd5qWkBSCo=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 164817: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=edf8bc6d24c6f490c27de3144eee88f1ca40ce6a X-Osstest-Versions-That: ovmf=cae735f61328d64e2e8991036707b9e78c0f5f63 From: osstest service owner Date: Sun, 05 Sep 2021 00:28:23 +0000 flight 164817 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/164817/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 164674 build-amd64 6 xen-build fail REGR. vs. 164674 build-i386-xsm 6 xen-build fail REGR. vs. 164674 build-i386 6 xen-build fail REGR. vs. 164674 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf edf8bc6d24c6f490c27de3144eee88f1ca40ce6a baseline version: ovmf cae735f61328d64e2e8991036707b9e78c0f5f63 Last test of basis 164674 2021-08-31 02:56:52 Z 4 days Failing since 164686 2021-09-01 03:03:43 Z 3 days 35 attempts Testing same since 164806 2021-09-04 09:41:21 Z 0 days 9 attempts ------------------------------------------------------------ People who touched revisions under test: Anthony PERARD DunTan Gary Lin Hao A Wu Jim Fehlig Lin, Gary (HPS OE-Linux) Loo Tung Lun Loo, Tung Lun Mark Wilson Marvin H?user Michael Kubacki Rebecca Cran Wenxing Hou Wenyi Xie jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 302 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Sep 05 01:41:46 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 05 Sep 2021 01:41:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.178861.324985 (Exim 4.92) (envelope-from ) id 1mMhA4-0007PL-SJ; Sun, 05 Sep 2021 01:41:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 178861.324985; Sun, 05 Sep 2021 01:41:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMhA4-0007PE-P2; Sun, 05 Sep 2021 01:41:32 +0000 Received: by outflank-mailman (input) for mailman id 178861; Sun, 05 Sep 2021 01:41:31 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMhA3-0007P4-SE; Sun, 05 Sep 2021 01:41:31 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMhA3-0007Xv-Lr; Sun, 05 Sep 2021 01:41:31 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMhA2-0006C1-K5; Sun, 05 Sep 2021 01:41:30 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mMhA2-00076D-Jd; Sun, 05 Sep 2021 01:41:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=MU8m52ijS5WrhVsxtKKd3HoNjysbbjeIIJhAx9iRDtg=; b=aC5ry0AvVNMke2QVjJkE9ulHom +zJHc86zMcU8gt4w2o32QWQPMK6yceb17CFBV7ZjDnTeOJRwuw4RP48i8E5vtKWnnx5H0hkEUQYYL /JJTnZBTc9VtwckBlgsYNGKcRMJ7B9FaEU6e+gDJfU6GLEF0nOlcMaa3zcK8c3WpIywc=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 164818: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=edf8bc6d24c6f490c27de3144eee88f1ca40ce6a X-Osstest-Versions-That: ovmf=cae735f61328d64e2e8991036707b9e78c0f5f63 From: osstest service owner Date: Sun, 05 Sep 2021 01:41:30 +0000 flight 164818 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/164818/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 164674 build-amd64 6 xen-build fail REGR. vs. 164674 build-i386-xsm 6 xen-build fail REGR. vs. 164674 build-i386 6 xen-build fail REGR. vs. 164674 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf edf8bc6d24c6f490c27de3144eee88f1ca40ce6a baseline version: ovmf cae735f61328d64e2e8991036707b9e78c0f5f63 Last test of basis 164674 2021-08-31 02:56:52 Z 4 days Failing since 164686 2021-09-01 03:03:43 Z 3 days 36 attempts Testing same since 164806 2021-09-04 09:41:21 Z 0 days 10 attempts ------------------------------------------------------------ People who touched revisions under test: Anthony PERARD DunTan Gary Lin Hao A Wu Jim Fehlig Lin, Gary (HPS OE-Linux) Loo Tung Lun Loo, Tung Lun Mark Wilson Marvin H?user Michael Kubacki Rebecca Cran Wenxing Hou Wenyi Xie jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 302 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Sep 05 02:31:06 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 05 Sep 2021 02:31:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.178869.324999 (Exim 4.92) (envelope-from ) id 1mMhvv-0004wK-OG; Sun, 05 Sep 2021 02:30:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 178869.324999; Sun, 05 Sep 2021 02:30:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMhvv-0004vs-Hc; Sun, 05 Sep 2021 02:30:59 +0000 Received: by outflank-mailman (input) for mailman id 178869; Sun, 05 Sep 2021 02:30:57 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMhvt-0004vm-OJ for xen-devel@lists.xenproject.org; Sun, 05 Sep 2021 02:30:57 +0000 Received: from mail-io1-xd30.google.com (unknown [2607:f8b0:4864:20::d30]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 61eaba39-4c97-49ab-9a2d-50a97823c5c7; Sun, 05 Sep 2021 02:30:56 +0000 (UTC) Received: by mail-io1-xd30.google.com with SMTP id b10so4020459ioq.9 for ; Sat, 04 Sep 2021 19:30:56 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 61eaba39-4c97-49ab-9a2d-50a97823c5c7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=unixindia.com; s=mail; h=mime-version:from:date:message-id:subject:to; bh=9GhxT6iwrAUFJk5X6XPrE5T9ku0+A2eEn9VbjHQLQIo=; b=wD34T0Gvd/G8aM6SWzrcuQIBuyaUkEE5aP2179vfJDvOPiIIEYbEniiZSWqCH7VYcy sEE5wMVn1gp7c6rFEiTC7Jd8svNigMfs/8BvnLyFPKvZyYH4iPWu+a2lDcveeMi1NDAX rnGA4JMIeko96oI3krWpHZ2npAQuvw1xzlu14cGNveGMQRcKgGun480dONIzkIc/QS5c NKdPYTApOsFRxDDeLmO2VN4XZotAxi2BcUBX0lm4FpL26dMShXT5CdCxwP4eLz9yI/AD FwWRJ0Ja0iOo4UZPAbZTAMoNJoxW70/ZYcMXz0ZIle06Sosv12kjBjqB7S+A7XbSRz87 abPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=9GhxT6iwrAUFJk5X6XPrE5T9ku0+A2eEn9VbjHQLQIo=; b=WtG97C1xZiMU0klDUrJzDwvj3XEYdhzpCScGsdjhlvVI7LymvqBzwlhWAcml9qI+Uq TnPuJiUyC0J1s71c0jvH4tpSfHEuZYlPy7yMXRWkm562H1pFT9yueYlJ4Mw7ljDzKy5j vcH0D4R8BXsNO1wTNGQExA8YvKYAuZG/iIkVExhzc4maHuyg0x7RKjZElKnuFyQCi1Vt s9PZ73U8lz0ovhTal1iC1txlurLLMvvIfKXtUYsrARYkkgI3h0PB5hGAdW9jPbq10Q8l 1Qt1uvX3l15cdsVq46YznWN1HxgWK74g9lulk0tMazUmlj/ZwdH90+HpmtGZfgoq2JrV bj/Q== X-Gm-Message-State: AOAM532IwbA/LAVoFxYQgkYAgeVn/hqEh1+AMRUp3eY3NQxZxajkF7zi IwSQApI4h/KTblG4LPoflxHt9NWg9HBNklpvnvw3Nv0e8HYBz2CR560= X-Google-Smtp-Source: ABdhPJwdKE+lU/CkGaWvd3SU3J4iNHihj1Pae38TvnF0g7XLrRJhQ9OIpnsmKu6R3H/ZJowz7UtGLPagw3hxNWODII8= X-Received: by 2002:a02:1dc9:: with SMTP id 192mr5354954jaj.92.1630809055894; Sat, 04 Sep 2021 19:30:55 -0700 (PDT) MIME-Version: 1.0 From: Bhasker C V Date: Sun, 5 Sep 2021 03:30:45 +0100 Message-ID: Subject: Pygrub crash when trying to edit kernel commandline To: xen-users@lists.xenproject.org, xen-devel@lists.xenproject.org Content-Type: multipart/mixed; boundary="0000000000007950e905cb36526c" --0000000000007950e905cb36526c Content-Type: multipart/alternative; boundary="0000000000007950e705cb36526a" --0000000000007950e705cb36526a Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi When I try to edit kernel command line of domU, pygrub crashes bcv@bcvibmb1:~$ sudo xl create -c /etc/xen/utils.cfg Parsing config from /etc/xen/utils.cfg Using to parse /boot/grub/menu.lst pyGRUB version 0.6 =E2=94=8C=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80= =E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2= =94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94= =80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80= =E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2= =94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94= =80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80= =E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2= =94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=90 =E2=94=82 root (hd0,0) = =E2=94=82 =E2=94=82 kernel /boot/vmlinuz-4.19.0-17-amd64 root=3D/dev/xvda2 = ro elev> =E2=94=82 =E2=94=82 initrd /boot/initrd.img-4.19.0-17-amd64 = =E2=94=82 =E2=94=82 = =E2=94=82 =E2=94=82 = =E2=94=82 =E2=94=82 = =E2=94=82 =E2=94=82 = =E2=94=82 =E2=94=82 = =E2=94=82 =E2=94=94=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80= =E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2= =94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94= =80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80= =E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2= =94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94= =80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80= =E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2= =94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=98 Use the =E2=86=91 and =E2=86=93 keys to select which entry is highligh= ted. Press 'b' to boot, 'e' to edit the selected command in the boot sequence, 'c' for a command-line, 'o' to open a new line after ('O' for before) the selected line, 'd' to remove the selected line, or escape to go back to the main menu. Traceback (most recent call last): File "/usr/lib/xen-4.14/bin/pygrub", line 884, in raise RuntimeError("Unable to find partition containing kernel") RuntimeError: Unable to find partition containing kernel libxl: error: libxl_bootloader.c:648:bootloader_finished: Domain 4:bootloader failed - consult logfile /var/log/xen/bootloader.4.log libxl: error: libxl_exec.c:117:libxl_report_child_exitstatus: bootloader [1316] exited with error status 1 libxl: error: libxl_create.c:1576:domcreate_rebuild_done: Domain 4:cannot (re-)build domain: -3 libxl: error: libxl_domain.c:1182:libxl__destroy_domid: Domain 4:Non-existant domain libxl: error: libxl_domain.c:1136:domain_destroy_callback: Domain 4:Unable to destroy guest libxl: error: libxl_domain.c:1063:domain_destroy_cb: Domain 4:Destruction of domain failed bcv@bcvibmb1:~$ Attached is the log Am I doing something wrong ? or is this a known issue ? Thanks Bhasker C V --0000000000007950e705cb36526a Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: base64 PGRpdiBkaXI9Imx0ciI+PGRpdj5IaTwvZGl2PjxkaXY+wqBXaGVuIEkgdHJ5IHRvIGVkaXQga2Vy bmVsIGNvbW1hbmQgbGluZSBvZiBkb21VLCBweWdydWIgY3Jhc2hlczwvZGl2PjxkaXY+PHNwYW4g c3R5bGU9ImNvbG9yOnJnYig2MSwxMzMsMTk4KSI+PGJyPjwvc3Bhbj48L2Rpdj48ZGl2PjxzcGFu IHN0eWxlPSJjb2xvcjpyZ2IoNjEsMTMzLDE5OCkiPmJjdkBiY3ZpYm1iMTp+JCBzdWRvIHhsIGNy ZWF0ZSAtYyAvZXRjL3hlbi91dGlscy5jZmc8YnI+UGFyc2luZyBjb25maWcgZnJvbSAvZXRjL3hl bi91dGlscy5jZmc8YnI+VXNpbmcgJmx0O2NsYXNzICYjMzk7Z3J1Yi5HcnViQ29uZi5HcnViQ29u ZmlnRmlsZSYjMzk7Jmd0OyB0byBwYXJzZSAvYm9vdC9ncnViL21lbnUubHN0PGJyPjxicj7CoCDC oCBweUdSVUIgwqB2ZXJzaW9uIDAuNjxicj7CoOKUjOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKU gOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKU gOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKU gOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKU gOKUgOKUgOKUgOKUgOKUgOKUgOKUkDxicj7CoOKUgiByb290IMKgIMKgIMKgIMKgIMKgIMKgKGhk MCwwKSDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC oCDCoCDCoCDCoCDCoCDCoCDCoOKUgjxicj7CoOKUgiBrZXJuZWwgwqAgwqAgwqAgwqAgwqAvYm9v dC92bWxpbnV6LTQuMTkuMC0xNy1hbWQ2NCByb290PS9kZXYveHZkYTIgcm8gZWxldiZndDsg4pSC PGJyPsKg4pSCIGluaXRyZCDCoCDCoCDCoCDCoCDCoC9ib290L2luaXRyZC5pbWctNC4xOS4wLTE3 LWFtZDY0IMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIOKUgjxicj7CoOKUgiDCoCDC oCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC oCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoOKUgjxicj7CoOKU giDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC oCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoOKUgjxi cj7CoOKUgiDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC oCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC oOKUgjxicj7CoOKUgiDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC oCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC oCDCoCDCoOKUgjxicj7CoOKUgiDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC oCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC oCDCoCDCoCDCoCDCoOKUgjxicj7CoOKUlOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKU gOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKU gOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKU gOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKU gOKUgOKUgOKUgOKUgOKUmDxicj7CoCDCoCDCoFVzZSB0aGUg4oaRIGFuZCDihpMga2V5cyB0byBz ZWxlY3Qgd2hpY2ggZW50cnkgaXMgaGlnaGxpZ2h0ZWQuPGJyPsKgIMKgIMKgUHJlc3MgJiMzOTti JiMzOTsgdG8gYm9vdCwgJiMzOTtlJiMzOTsgdG8gZWRpdCB0aGUgc2VsZWN0ZWQgY29tbWFuZCBp biB0aGU8YnI+wqAgwqAgwqBib290IHNlcXVlbmNlLCAmIzM5O2MmIzM5OyBmb3IgYSBjb21tYW5k LWxpbmUsICYjMzk7byYjMzk7IHRvIG9wZW4gYSBuZXcgbGluZTxicj7CoCDCoCDCoGFmdGVyICgm IzM5O08mIzM5OyBmb3IgYmVmb3JlKSB0aGUgc2VsZWN0ZWQgbGluZSwgJiMzOTtkJiMzOTsgdG8g cmVtb3ZlIHRoZTxicj7CoCDCoCDCoHNlbGVjdGVkIGxpbmUsIG9yIGVzY2FwZSB0byBnbyBiYWNr IHRvIHRoZSBtYWluIG1lbnUuPGJyPjxicj48YnI+VHJhY2ViYWNrIChtb3N0IHJlY2VudCBjYWxs IGxhc3QpOjxicj7CoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC oCDCoCDCoCBGaWxlICZxdW90Oy91c3IvbGliL3hlbi00LjE0L2Jpbi9weWdydWImcXVvdDssIGxp bmUgODg0LCBpbiAmbHQ7bW9kdWxlJmd0Ozxicj7CoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC oCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC oCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC oCDCoCByYWlzZSBSdW50aW1lRXJyb3IoJnF1b3Q7VW5hYmxlIHRvIGZpbmQgcGFydGl0aW9uIGNv bnRhaW5pbmcga2VybmVsJnF1b3Q7KTxicj7CoCDCoCDCoCDCoCDCoCDCoCDCoFJ1bnRpbWVFcnJv cjogVW5hYmxlIHRvIGZpbmQgcGFydGl0aW9uIGNvbnRhaW5pbmcga2VybmVsPGJyPsKgIMKgIMKg IMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKg IMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgbGlieGw6IGVycm9yOiBsaWJ4 bF9ib290bG9hZGVyLmM6NjQ4OmJvb3Rsb2FkZXJfZmluaXNoZWQ6IERvbWFpbiA0OmJvb3Rsb2Fk ZXIgZmFpbGVkIC0gY29uc3VsdCBsb2dmaWxlIC92YXIvbG9nL3hlbi9ib290bG9hZGVyLjQubG9n PGJyPsKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKg IMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIGxpYnhsOiBlcnJvcjogbGlieGxfZXhlYy5jOjExNzps aWJ4bF9yZXBvcnRfY2hpbGRfZXhpdHN0YXR1czogYm9vdGxvYWRlciBbMTMxNl0gZXhpdGVkIHdp dGggZXJyb3Igc3RhdHVzIDE8YnI+wqAgwqAgwqAgwqAgwqBsaWJ4bDogZXJyb3I6IGxpYnhsX2Ny ZWF0ZS5jOjE1NzY6ZG9tY3JlYXRlX3JlYnVpbGRfZG9uZTogRG9tYWluIDQ6Y2Fubm90IChyZS0p YnVpbGQgZG9tYWluOiAtMzxicj7CoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC oCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC oCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC oCDCoCBsaWJ4bDogZXJyb3I6IGxpYnhsX2RvbWFpbi5jOjExODI6bGlieGxfX2Rlc3Ryb3lfZG9t aWQ6IERvbWFpbiA0Ok5vbi1leGlzdGFudCBkb21haW48YnI+bGlieGw6IGVycm9yOiBsaWJ4bF9k b21haW4uYzoxMTM2OmRvbWFpbl9kZXN0cm95X2NhbGxiYWNrOiBEb21haW4gNDpVbmFibGUgdG8g ZGVzdHJveSBndWVzdDxicj5saWJ4bDogZXJyb3I6IGxpYnhsX2RvbWFpbi5jOjEwNjM6ZG9tYWlu X2Rlc3Ryb3lfY2I6IERvbWFpbiA0OkRlc3RydWN0aW9uIG9mIGRvbWFpbiBmYWlsZWQ8YnI+YmN2 QGJjdmlibWIxOn4kwqA8L3NwYW4+PC9kaXY+PGRpdj48YnI+PC9kaXY+PGRpdj48YnI+PC9kaXY+ PGRpdj48L2Rpdj48ZGl2PkF0dGFjaGVkIGlzIHRoZSBsb2c8L2Rpdj48ZGl2PkFtIEkgZG9pbmcg c29tZXRoaW5nIHdyb25nID8gb3IgaXMgdGhpcyBhIGtub3duIGlzc3VlID88L2Rpdj48ZGl2Pjxi cj48L2Rpdj48ZGl2PlRoYW5rczwvZGl2PjxkaXY+Qmhhc2tlciBDIFYgPGJyPjwvZGl2PjwvZGl2 Pg0K --0000000000007950e705cb36526a-- --0000000000007950e905cb36526c Content-Type: text/x-log; charset="x-binaryenc"; name="bootloader.4.log" Content-Disposition: attachment; filename="bootloader.4.log" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kt6ll68k0 VXNpbmcgPGNsYXNzICdncnViLkdydWJDb25mLkdydWJDb25maWdGaWxlJz4gdG8gcGFyc2UgL2Jv b3QvZ3J1Yi9tZW51LmxzdAobKEIbKTAbWzE7MjRyG1ttDxtbPzdoG1s/MWgbPRtbSBtbShtbPzFo Gz0bWzFCICAgIHB5R1JVQiAgdmVyc2lvbiAwLjYNG1sxQiAbWzBtDmxxcXFxcXFxcXFxcXFxcXFx cXFxcXFxcXFxcXFxcXFxcXFxcXFxcXFxcXFxcXFxcXFxcXFxcXFxcXFxcXFxcXFxcXFxcXFxcXFr Dw0bWzFCIBtbMG0OeA8gG1swOzdtD0RlYmlhbiBHTlUvTGludXgsIGtlcm5lbCA0LjE5LjAtMTct YW1kNjQgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAbW20PIBtbMG0OeA8NG1sxQiAbWzBt DngPIERlYmlhbiBHTlUvTGludXgsIGtlcm5lbCA0LjE5LjAtMTctYW1kNjQgKHNpbmdsZS11c2Vy IG1vZGUpG1sxMkMbWzBtDngPDRtbMUIgG1swbQ54DyBEZWJpYW4gR05VL0xpbnV4IDEwG1s1MkMb WzBtDngPDRtbMUIgG1swbQ54DyBEZWJpYW4gR05VL0xpbnV4IDEwIChTaW5nbGUtVXNlcikbWzM4 QxtbMG0OeA8NG1sxQiAbWzBtDngPIERlYmlhbiBHTlUvTGludXggMTAgKERlZmF1bHQgS2VybmVs KRtbMzVDG1swbQ54Dw0bWzFCIBtbMG0OeA8gRGViaWFuIEdOVS9MaW51eCAxMCAoRGVmYXVsdCBL ZXJuZWwsIFNpbmdsZS1Vc2VyKRtbMjJDG1swbQ54Dw0bWzFCIBtbMG0OeA8bWzcyQxtbMG0OeA8N G1sxQiAbWzBtDngPG1s3MkMbWzBtDngPDRtbMUIgG1swbQ5tcXFxcXFxcXFxcXFxcXFxcXFxcXFx cXFxcXFxcXFxcXFxcXFxcXFxcXFxcXFxcXFxcXFxcXFxcXFxcXFxcXFxcXFxcXFxcXFxag8bWzFC G1s3MEQbWzBtDg9Vc2UgdGhlIOKGkSBhbmQg4oaTIGtleXMgdG8gc2VsZWN0IHdoaWNoIGVudHJ5 IGlzIGhpZ2hsaWdodGVkLhtbMUIbWzU4RFByZXNzIGVudGVyIHRvIGJvb3QgdGhlIHNlbGVjdGVk IE9TLCAnZScgdG8gZWRpdCB0aGUbWzFCG1s1MkRjb21tYW5kcyBiZWZvcmUgYm9vdGluZywgJ2En IHRvIG1vZGlmeSB0aGUga2VybmVsIGFyZ3VtZW50cxtbMUIbWzU5RGJlZm9yZSBib290aW5nLCBv ciAnYycgZm9yIGEgY29tbWFuZCBsaW5lLhtbN0EbWzI2QxtbMTJCG1s2OERXaWxsIGJvb3Qgc2Vs ZWN0ZWQgZW50cnkgaW4gIDIgc2Vjb25kcxtbPzFoGz0NG1tKG1sxMkEbWzczQxtbMTJCG1s2OERX aWxsIGJvb3Qgc2VsZWN0ZWQgZW50cnkgaW4gIDEgc2Vjb25kcxtbPzFoGz0NG1tKG1sxN0EbWzND RGViaWFuIEdOVS9MaW51eCwga2VybmVsIDQuMTkuMC0xNy1hbWQ2NCAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIBtbMUIbWzcwRBtbMDs3bQ9EZWJpYW4gR05VL0xpbnV4LCBrZXJuZWwgNC4x OS4wLTE3LWFtZDY0IChzaW5nbGUtdXNlciBtb2RlKSAgICAgICAgICAgG1s0QhtbbQ8bWzEzQhtb NjhEG1s/MWgbPRtbMThBCAgbWzA7N20PRGViaWFuIEdOVS9MaW51eCwga2VybmVsIDQuMTkuMC0x Ny1hbWQ2NCAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIBtbMUIbWzcwRBtbbQ9EZWJpYW4g R05VL0xpbnV4LCBrZXJuZWwgNC4xOS4wLTE3LWFtZDY0IChzaW5nbGUtdXNlciBtb2RlKSAgICAg ICAgICAgG1s0QhtbMTNCG1s2OEQbWz8xaBs9G1sxOEEICBtbMDs3bQ9yb290ICAgICAgICAgICAg KGhkMCwwKSAgICAgICAgICAgICAgICAgG1sxQhtbNDBEG1ttD2tlcm5lbCAgICAgICAgICAvYm9v dC92bWxpbnV6LTQuMTkuMC0xNy1hbWQ2NCByb290PS9kZXYveHZkYTIgcm8gZWxldj4bWzFCG1s3 MERpbml0cmQgICAgICAgICAgL2Jvb3QvaW5pdHJkLmltZy00LjE5LjAtMTctYW1kNjQbWzFCG1s0 OEQgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAbWzFCG1szM0QgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAbWzFCG1szNkQgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgG1sxNDsxMkgnYicgdG8gYm9vdCwgJ2UnIHRvIGVkaXQg dGhlIHNlbGVjdGVkIGNvbW1hbmQgaW4gdGhlG1sxQhtbNThEYm9vdCBzZXF1ZW5jZSwgJ2MnIGZv ciBhIGNvbW1hbmQtbGluZSwgJ28nIHRvIG9wZW4gYSBuZXcgbGluZRtbMUIbWzYxRGFmdGVyICgn TycgZm9yIGJlZm9yZSkgdGhlIHNlbGVjdGVkIGxpbmUsICdkJyB0byByZW1vdmUgdGhlG1sxQhtb NTlEc2VsZWN0ZWQgbGluZSwgb3IgZXNjYXBlIHRvIGdvIGJhY2sgdG8gdGhlIG1haW4gbWVudS4b WzExQRtbMTVDG1s/MWgbPRtbMkEbWzcwRHJvb3QgICAgICAgICAgICAoaGQwLDApICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAbWzFCG1s3MEQbWzA7N20Pa2Vy bmVsICAgICAgICAgIC9ib290L3ZtbGludXotNC4xOS4wLTE3LWFtZDY0IHJvb3Q9L2Rldi94dmRh MiBybyBlbGV2PhtbMUIbW20PG1s/MWgbPRtbPzFsGz4bWzI0OzFIDRtbPzFsGz5UcmFjZWJhY2sg KG1vc3QgcmVjZW50IGNhbGwgbGFzdCk6CiAgRmlsZSAiL3Vzci9saWIveGVuLTQuMTQvYmluL3B5 Z3J1YiIsIGxpbmUgODg0LCBpbiA8bW9kdWxlPgogICAgcmFpc2UgUnVudGltZUVycm9yKCJVbmFi bGUgdG8gZmluZCBwYXJ0aXRpb24gY29udGFpbmluZyBrZXJuZWwiKQpSdW50aW1lRXJyb3I6IFVu YWJsZSB0byBmaW5kIHBhcnRpdGlvbiBjb250YWluaW5nIGtlcm5lbAo= --0000000000007950e905cb36526c-- From xen-devel-bounces@lists.xenproject.org Sun Sep 05 02:42:30 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 05 Sep 2021 02:42:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.178893.325028 (Exim 4.92) (envelope-from ) id 1mMi6s-0007so-46; Sun, 05 Sep 2021 02:42:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 178893.325028; Sun, 05 Sep 2021 02:42:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMi6r-0007sg-Te; Sun, 05 Sep 2021 02:42:17 +0000 Received: by outflank-mailman (input) for mailman id 178893; Sun, 05 Sep 2021 02:42:16 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMi6q-0007sW-U6; Sun, 05 Sep 2021 02:42:16 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMi6q-0000XE-MJ; Sun, 05 Sep 2021 02:42:16 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMi6p-00088Q-Bi; Sun, 05 Sep 2021 02:42:15 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mMi6p-0000eU-8o; Sun, 05 Sep 2021 02:42:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=e6oav8WQi/rXmE07hJn8bLGXuRcjUEI0ZGjRpEqCi7c=; b=tvKZKwqaeVWQ8x468VhjgT+H4x kckTKUtizJbhq2lLbAwQEw8BwSsBdgv+0uBpLdjhxCPLMrUdNdrc28ysN2JrW+yPCHHgKQQj3xJo7 myWE1z54QfHUF24wE8OAE7ew2w6IgoajKqMjAO0bT/CxdkTJbSOfBaabG3kWigwWdMSg=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 164820: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=edf8bc6d24c6f490c27de3144eee88f1ca40ce6a X-Osstest-Versions-That: ovmf=cae735f61328d64e2e8991036707b9e78c0f5f63 From: osstest service owner Date: Sun, 05 Sep 2021 02:42:15 +0000 flight 164820 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/164820/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 164674 build-amd64 6 xen-build fail REGR. vs. 164674 build-i386-xsm 6 xen-build fail REGR. vs. 164674 build-i386 6 xen-build fail REGR. vs. 164674 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf edf8bc6d24c6f490c27de3144eee88f1ca40ce6a baseline version: ovmf cae735f61328d64e2e8991036707b9e78c0f5f63 Last test of basis 164674 2021-08-31 02:56:52 Z 4 days Failing since 164686 2021-09-01 03:03:43 Z 3 days 37 attempts Testing same since 164806 2021-09-04 09:41:21 Z 0 days 11 attempts ------------------------------------------------------------ People who touched revisions under test: Anthony PERARD DunTan Gary Lin Hao A Wu Jim Fehlig Lin, Gary (HPS OE-Linux) Loo Tung Lun Loo, Tung Lun Mark Wilson Marvin H?user Michael Kubacki Rebecca Cran Wenxing Hou Wenyi Xie jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 302 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Sep 05 03:01:05 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 05 Sep 2021 03:01:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.178901.325042 (Exim 4.92) (envelope-from ) id 1mMiOx-00021D-Qw; Sun, 05 Sep 2021 03:00:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 178901.325042; Sun, 05 Sep 2021 03:00:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMiOx-00020l-KB; Sun, 05 Sep 2021 03:00:59 +0000 Received: by outflank-mailman (input) for mailman id 178901; Sun, 05 Sep 2021 03:00:58 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMiOw-00020b-9X; Sun, 05 Sep 2021 03:00:58 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMiOw-0000wb-2Q; Sun, 05 Sep 2021 03:00:58 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMiOv-0001AF-M7; Sun, 05 Sep 2021 03:00:57 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mMiOv-00024R-Lc; Sun, 05 Sep 2021 03:00:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=LM0EZtkWk5vBezeciignTkSyJhwR0eboXJm5QcmP/SE=; b=gLoo205Qxy1hag8O8+fd3UaQ2z cGaBxKC3FSH85MWIhKq8opyaah+E9ymolewBc/9kX2A6eo9bI/Fo5MUKFiItqg3aeRp/vv42TvgLc 6HwGQ0Q351oxfeqnMhmQq4N4mAFHwreolDFDY629exOYS/hTMVh0SIsMwXZhxWrfb5iQ=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 164812: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=9c03aa87e52567f6c9a7bf456e5dd94dc84088de X-Osstest-Versions-That: qemuu=8880cc4362fde4ecdac0b2092318893118206fcf From: osstest service owner Date: Sun, 05 Sep 2021 03:00:57 +0000 flight 164812 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/164812/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 164799 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 164799 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 164799 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 164799 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 164799 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 164799 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 164799 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass version targeted for testing: qemuu 9c03aa87e52567f6c9a7bf456e5dd94dc84088de baseline version: qemuu 8880cc4362fde4ecdac0b2092318893118206fcf Last test of basis 164799 2021-09-03 19:38:03 Z 1 days Testing same since 164812 2021-09-04 18:37:54 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Alex Bennée Mahmoud Mandour Paolo Bonzini Peter Maydell Thomas Huth jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git 8880cc4362..9c03aa87e5 9c03aa87e52567f6c9a7bf456e5dd94dc84088de -> upstream-tested From xen-devel-bounces@lists.xenproject.org Sun Sep 05 04:25:55 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 05 Sep 2021 04:25:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.178912.325056 (Exim 4.92) (envelope-from ) id 1mMjiw-000341-6T; Sun, 05 Sep 2021 04:25:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 178912.325056; Sun, 05 Sep 2021 04:25:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMjiv-00033Z-Uq; Sun, 05 Sep 2021 04:25:41 +0000 Received: by outflank-mailman (input) for mailman id 178912; Sun, 05 Sep 2021 04:25:40 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMjiu-00033P-Mm; Sun, 05 Sep 2021 04:25:40 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMjiu-0002cP-C7; Sun, 05 Sep 2021 04:25:40 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMjit-0004a1-Ld; Sun, 05 Sep 2021 04:25:39 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mMjit-0004vb-Ki; Sun, 05 Sep 2021 04:25:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=ONfQiNGc/OJruT+72rIIEEesV5sbIfFZO3OtQmChQps=; b=N60Y8Z/ICGfCsJpibRtDj0VhuE jAh76TvLGUvzw0+UVBp6iCu4VOvBfSBmIo4we2mqIz5RZXc2thGKhQCameGPFjJAhLVSfuWo+GfUj LEH/udUEepiY4oi+xK7OSCCj/UQ4kxCwDdi3A5rvchnT8icNEWytTy5J+jDo/S2jSqng=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 164821: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=edf8bc6d24c6f490c27de3144eee88f1ca40ce6a X-Osstest-Versions-That: ovmf=cae735f61328d64e2e8991036707b9e78c0f5f63 From: osstest service owner Date: Sun, 05 Sep 2021 04:25:39 +0000 flight 164821 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/164821/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 164674 build-amd64 6 xen-build fail REGR. vs. 164674 build-i386-xsm 6 xen-build fail REGR. vs. 164674 build-i386 6 xen-build fail REGR. vs. 164674 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf edf8bc6d24c6f490c27de3144eee88f1ca40ce6a baseline version: ovmf cae735f61328d64e2e8991036707b9e78c0f5f63 Last test of basis 164674 2021-08-31 02:56:52 Z 5 days Failing since 164686 2021-09-01 03:03:43 Z 4 days 38 attempts Testing same since 164806 2021-09-04 09:41:21 Z 0 days 12 attempts ------------------------------------------------------------ People who touched revisions under test: Anthony PERARD DunTan Gary Lin Hao A Wu Jim Fehlig Lin, Gary (HPS OE-Linux) Loo Tung Lun Loo, Tung Lun Mark Wilson Marvin H?user Michael Kubacki Rebecca Cran Wenxing Hou Wenyi Xie jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 302 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Sep 05 07:30:22 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 05 Sep 2021 07:30:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.178921.325070 (Exim 4.92) (envelope-from ) id 1mMmbO-0006ek-Ej; Sun, 05 Sep 2021 07:30:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 178921.325070; Sun, 05 Sep 2021 07:30:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMmbO-0006eC-Al; Sun, 05 Sep 2021 07:30:06 +0000 Received: by outflank-mailman (input) for mailman id 178921; Sun, 05 Sep 2021 07:30:04 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMmbM-0006S5-Rr; Sun, 05 Sep 2021 07:30:04 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMmbM-0005xm-KI; Sun, 05 Sep 2021 07:30:04 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMmbM-0004fR-Ap; Sun, 05 Sep 2021 07:30:04 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mMmbM-0000Fo-AJ; Sun, 05 Sep 2021 07:30:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=tpnnEtsJRkqGl+hesrnpeC+PmZVYwLzwiRajer4BQOE=; b=pAbtapvDagyKG2omxK4ngDciCf nZSQQg0YhTja7l9R7i78adwKGkJ7cOTiuKKfXzUfov+w7COJD5Fay3GBp/Fcqo9lFxcO9KaIZPV/D OWbWnKEpCgHJh2Cth3jIHtljC+jycDJbsZy8GGvnVSFKq+J7NJ9HvdVlhhoRDbSZ5aQY=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 164816: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-i386-xl-qemut-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-examine:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-i386-xl-raw:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-pvshim:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-i386:xen-install:fail:regression linux-linus:test-amd64-i386-xl-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ovmf-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-coresched-i386-xl:xen-install:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit1:debian-fixup:fail:regression linux-linus:test-arm64-arm64-xl:guest-start:fail:regression linux-linus:test-arm64-arm64-xl-thunderx:debian-fixup:fail:regression linux-linus:test-arm64-arm64-xl-xsm:debian-fixup:fail:regression linux-linus:test-arm64-arm64-xl-credit2:debian-fixup:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:debian-fixup:fail:regression linux-linus:test-amd64-amd64-xl-credit2:guest-start/debian.repeat:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:regression linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-amd64-amd64-qemuu-freebsd12-amd64:guest-localmigrate:fail:allowable linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=49624efa65ac9889f4e7c7b2452b2e6ce42ba37d X-Osstest-Versions-That: linux=deacdb3e3979979016fcd0ffd518c320a62ad166 From: osstest service owner Date: Sun, 05 Sep 2021 07:30:04 +0000 flight 164816 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/164816/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemut-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-examine 6 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-i386-xl-raw 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-pvshim 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-i386 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ovmf-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-coresched-i386-xl 7 xen-install fail REGR. vs. 152332 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 152332 test-arm64-arm64-xl-credit1 13 debian-fixup fail REGR. vs. 152332 test-arm64-arm64-xl 14 guest-start fail REGR. vs. 152332 test-arm64-arm64-xl-thunderx 13 debian-fixup fail REGR. vs. 152332 test-arm64-arm64-xl-xsm 13 debian-fixup fail REGR. vs. 152332 test-arm64-arm64-xl-credit2 13 debian-fixup fail REGR. vs. 152332 test-arm64-arm64-libvirt-xsm 13 debian-fixup fail REGR. vs. 152332 test-amd64-amd64-xl-credit2 22 guest-start/debian.repeat fail REGR. vs. 152332 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 152332 test-arm64-arm64-examine 8 reboot fail REGR. vs. 152332 Regressions which are regarded as allowable (not blocking): test-amd64-amd64-qemuu-freebsd12-amd64 17 guest-localmigrate fail REGR. vs. 152332 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 152332 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 152332 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152332 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152332 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 152332 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152332 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152332 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: linux 49624efa65ac9889f4e7c7b2452b2e6ce42ba37d baseline version: linux deacdb3e3979979016fcd0ffd518c320a62ad166 Last test of basis 152332 2020-07-31 19:41:23 Z 400 days Failing since 152366 2020-08-01 20:49:34 Z 399 days 693 attempts Testing same since 164816 2021-09-04 22:09:46 Z 0 days 1 attempts ------------------------------------------------------------ 7209 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl fail test-armhf-armhf-xl pass test-amd64-i386-xl fail test-amd64-coresched-i386-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm fail test-amd64-i386-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm fail test-amd64-i386-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 fail test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine pass test-arm64-arm64-examine fail test-armhf-armhf-examine pass test-amd64-i386-examine fail test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel fail test-amd64-i386-qemuu-rhel6hvm-intel fail test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair fail test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow fail test-arm64-arm64-xl-thunderx fail test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2214305 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Sep 05 08:06:35 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 05 Sep 2021 08:06:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.178935.325083 (Exim 4.92) (envelope-from ) id 1mMnAa-0002qL-Oi; Sun, 05 Sep 2021 08:06:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 178935.325083; Sun, 05 Sep 2021 08:06:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMnAa-0002qE-Lo; Sun, 05 Sep 2021 08:06:28 +0000 Received: by outflank-mailman (input) for mailman id 178935; Sun, 05 Sep 2021 08:06:27 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMnAZ-0002q4-A5; Sun, 05 Sep 2021 08:06:27 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMnAZ-00076l-3s; Sun, 05 Sep 2021 08:06:27 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMnAY-000689-Qd; Sun, 05 Sep 2021 08:06:26 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mMnAY-0005RR-Q3; Sun, 05 Sep 2021 08:06:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=wOGgP2/SIeFwpMxID02PyRrxLC+4tQW6/QvQk4clNyA=; b=bFQYLuKMmYUU9M1foNdZ6+rwMf V1nDbAWbPanNoOthToqZTzochiPMg3KFxwDg5cJ6RFo1VqR81hOYwHKmHQGDEGk+QMQ8YFBs9JCuI 3MpHDnmgiZ81GPBTQFpaOWZNu3LNQh9iHeHDMxqoKiSz1AF0mKeiVOUA0SU252+YbET0=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 164823: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=edf8bc6d24c6f490c27de3144eee88f1ca40ce6a X-Osstest-Versions-That: ovmf=cae735f61328d64e2e8991036707b9e78c0f5f63 From: osstest service owner Date: Sun, 05 Sep 2021 08:06:26 +0000 flight 164823 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/164823/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 164674 build-amd64 6 xen-build fail REGR. vs. 164674 build-i386-xsm 6 xen-build fail REGR. vs. 164674 build-i386 6 xen-build fail REGR. vs. 164674 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf edf8bc6d24c6f490c27de3144eee88f1ca40ce6a baseline version: ovmf cae735f61328d64e2e8991036707b9e78c0f5f63 Last test of basis 164674 2021-08-31 02:56:52 Z 5 days Failing since 164686 2021-09-01 03:03:43 Z 4 days 39 attempts Testing same since 164806 2021-09-04 09:41:21 Z 0 days 13 attempts ------------------------------------------------------------ People who touched revisions under test: Anthony PERARD DunTan Gary Lin Hao A Wu Jim Fehlig Lin, Gary (HPS OE-Linux) Loo Tung Lun Loo, Tung Lun Mark Wilson Marvin H?user Michael Kubacki Rebecca Cran Wenxing Hou Wenyi Xie jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 302 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Sep 05 08:17:10 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 05 Sep 2021 08:17:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.178943.325097 (Exim 4.92) (envelope-from ) id 1mMnKr-0004V7-PB; Sun, 05 Sep 2021 08:17:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 178943.325097; Sun, 05 Sep 2021 08:17:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMnKr-0004V0-La; Sun, 05 Sep 2021 08:17:05 +0000 Received: by outflank-mailman (input) for mailman id 178943; Sun, 05 Sep 2021 08:17:05 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMnKr-0004Uq-0d; Sun, 05 Sep 2021 08:17:05 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMnKq-0007HG-QH; Sun, 05 Sep 2021 08:17:04 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMnKq-0006cG-IF; Sun, 05 Sep 2021 08:17:04 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mMnKq-00062g-EX; Sun, 05 Sep 2021 08:17:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=83xelHTQ+U9uaRN3ZSnabUgjU6rzz35B2j6wDQ9ZiXo=; b=q0PYteCe7+f5l8H0tPzy14Kevu SPC5GbMFnzeNGTMQPEhukOFLovQP7UuDv6omgnsCvSl50WzD8PIyZkjUwbRTA3FGFgXSRp87K2ecE 1rvR3ru5jz6SWY+pT9xk+gVdRHWSNc5JchEEXcHqo31FkgGGgfjFDEZ5s5xnJubTlUjk=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 164822: regressions - FAIL X-Osstest-Failures: libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=b6ec01b82154c9dc25f18c9c28df30d0c053defe X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Sun, 05 Sep 2021 08:17:04 +0000 flight 164822 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/164822/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a version targeted for testing: libvirt b6ec01b82154c9dc25f18c9c28df30d0c053defe baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 422 days Failing since 151818 2020-07-11 04:18:52 Z 421 days 412 attempts Testing same since 164803 2021-09-04 04:20:08 Z 1 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Andika Triwidada Andrea Bolognani Balázs Meskó Barrett Schonefeld Bastian Germann Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Bjoern Walk Boris Fiuczynski Brian Turek Bruno Haible Chris Mayo Christian Ehrhardt Christian Kirbach Christian Schoenebeck Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé Didik Supriadi Dmytro Linkin Eiichi Tsukata Eric Farman Erik Skultety Fabian Affolter Fabian Freyer Fabiano Fidêncio Fangge Jin Farhan Ali Fedora Weblate Translation gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Hela Basa Helmut Grohne Ian Wienand Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen jason lee Jean-Baptiste Holcroft Jia Zhou Jianan Gao Jim Fehlig Jin Yan Jinsheng Zhang Jiri Denemark John Ferlan Jonathan Watt Jonathon Jongsma Julio Faracco Justin Gatzen Ján Tomko Kashyap Chamarthy Kevin Locke Kristina Hanicova Laine Stump Laszlo Ersek Lee Yarwood Liao Pingfang Lin Ma Lin Ma Lin Ma Liu Yiding Luke Yue Luyao Zhong Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Markus Schade Martin Kletzander Masayoshi Mizuma Matej Cepl Matt Coleman Matt Coleman Mauro Matteo Cascella Meina Li Michal Privoznik Michał Smyk Milo Casagrande Moshe Levi Muha Aliss Nathan Neal Gompa Nick Shyrokovskiy Nickys Music Group Nico Pache Nikolay Shirokovskiy Olaf Hering Olesya Gerasimenko Orion Poplawski Pany Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Richard W.M. Jones Ricky Tigg Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Shambarger Sebastian Mitterle SeongHyun Jo Shalini Chellathurai Saroja Shaojun Yang Shi Lei simmon Simon Chopin Simon Gaiser Simon Rowe Stefan Bader Stefan Berger Stefan Berger Stefan Hajnoczi Szymon Scholz Thomas Huth Tim Wiederhake Tomáš Golembiovský Tomáš Janoušek Tuguoyi Ville Skyttä Vinayak Kale Wang Xin WangJian Weblate Wei Liu Wei Liu William Douglas Yalei Li <274268859@qq.com> Yalei Li Yang Fei Yang Hang Yanqiu Zhang Yaroslav Kargin Yi Li Yi Wang Yuri Chornoivan Zbigniew Jędrzejewski-Szmek zhangjl02 Zheng Chuan zhenwei pi Zhenyu Ye Zhenyu Zheng Zhenzhong Duan jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 71803 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Sep 05 08:57:52 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 05 Sep 2021 08:57:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.178956.325112 (Exim 4.92) (envelope-from ) id 1mMny6-0000sA-Sm; Sun, 05 Sep 2021 08:57:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 178956.325112; Sun, 05 Sep 2021 08:57:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMny6-0000s3-PT; Sun, 05 Sep 2021 08:57:38 +0000 Received: by outflank-mailman (input) for mailman id 178956; Sun, 05 Sep 2021 08:57:37 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMny5-0000rt-Mr; Sun, 05 Sep 2021 08:57:37 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMny5-0007wD-Gl; Sun, 05 Sep 2021 08:57:37 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMny5-0007vu-9J; Sun, 05 Sep 2021 08:57:37 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mMny5-0001qo-8p; Sun, 05 Sep 2021 08:57:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=k/RtWgL7Td3zHnT6KXm+B09/We7AL8SG/eAypxaG8W4=; b=Q52P8/95bkUE9gojrKktzhym04 ZGtjWbiSlSIAONi04vVLmesYzNX54AS2I3ESx+wd4ysTlymoVLA/Sv6sEkfgOSa1R3EbXvmhFroNF y6+oqSMeIrtE4fe51OI5Uq/OYnO6GzEpa8MDD/+s3C6ECvmPY7ZkL3mDOkUsgOzXy/aA=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 164825: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=edf8bc6d24c6f490c27de3144eee88f1ca40ce6a X-Osstest-Versions-That: ovmf=cae735f61328d64e2e8991036707b9e78c0f5f63 From: osstest service owner Date: Sun, 05 Sep 2021 08:57:37 +0000 flight 164825 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/164825/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 164674 build-amd64 6 xen-build fail REGR. vs. 164674 build-i386-xsm 6 xen-build fail REGR. vs. 164674 build-i386 6 xen-build fail REGR. vs. 164674 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf edf8bc6d24c6f490c27de3144eee88f1ca40ce6a baseline version: ovmf cae735f61328d64e2e8991036707b9e78c0f5f63 Last test of basis 164674 2021-08-31 02:56:52 Z 5 days Failing since 164686 2021-09-01 03:03:43 Z 4 days 40 attempts Testing same since 164806 2021-09-04 09:41:21 Z 0 days 14 attempts ------------------------------------------------------------ People who touched revisions under test: Anthony PERARD DunTan Gary Lin Hao A Wu Jim Fehlig Lin, Gary (HPS OE-Linux) Loo Tung Lun Loo, Tung Lun Mark Wilson Marvin H?user Michael Kubacki Rebecca Cran Wenxing Hou Wenyi Xie jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 302 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Sep 05 09:49:56 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 05 Sep 2021 09:49:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.178977.325126 (Exim 4.92) (envelope-from ) id 1mMomZ-0006iA-TH; Sun, 05 Sep 2021 09:49:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 178977.325126; Sun, 05 Sep 2021 09:49:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMomZ-0006i3-Q9; Sun, 05 Sep 2021 09:49:47 +0000 Received: by outflank-mailman (input) for mailman id 178977; Sun, 05 Sep 2021 09:49:46 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMomY-0006ht-58; Sun, 05 Sep 2021 09:49:46 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMomX-0000Nw-Vk; Sun, 05 Sep 2021 09:49:45 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMomX-0001T7-La; Sun, 05 Sep 2021 09:49:45 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mMomX-0004mc-L6; Sun, 05 Sep 2021 09:49:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=TLBc9IA7OFUPDy3YXurDMcY26IZLSdZrTOmeh0+afIo=; b=o66Cg3efFsAU6BBlwI3PznuuMx pb8jdeszatq6k85BPSwf7JBq82iWofOew6yXeQdw5evmTBWHK+BktqJxNqJiAZhl5v428K2mNWWc2 EOSHtJwCQqzulCdSr6qAyCSMxUNeHBuN4sK5a8keDA/0Ojb+KGAvd3hqkiwMMhQmR5I0=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 164826: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=edf8bc6d24c6f490c27de3144eee88f1ca40ce6a X-Osstest-Versions-That: ovmf=cae735f61328d64e2e8991036707b9e78c0f5f63 From: osstest service owner Date: Sun, 05 Sep 2021 09:49:45 +0000 flight 164826 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/164826/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 164674 build-amd64 6 xen-build fail REGR. vs. 164674 build-i386-xsm 6 xen-build fail REGR. vs. 164674 build-i386 6 xen-build fail REGR. vs. 164674 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf edf8bc6d24c6f490c27de3144eee88f1ca40ce6a baseline version: ovmf cae735f61328d64e2e8991036707b9e78c0f5f63 Last test of basis 164674 2021-08-31 02:56:52 Z 5 days Failing since 164686 2021-09-01 03:03:43 Z 4 days 41 attempts Testing same since 164806 2021-09-04 09:41:21 Z 1 days 15 attempts ------------------------------------------------------------ People who touched revisions under test: Anthony PERARD DunTan Gary Lin Hao A Wu Jim Fehlig Lin, Gary (HPS OE-Linux) Loo Tung Lun Loo, Tung Lun Mark Wilson Marvin H?user Michael Kubacki Rebecca Cran Wenxing Hou Wenyi Xie jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 302 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Sep 05 10:10:06 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 05 Sep 2021 10:10:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.178989.325140 (Exim 4.92) (envelope-from ) id 1mMp63-0001Ai-Mi; Sun, 05 Sep 2021 10:09:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 178989.325140; Sun, 05 Sep 2021 10:09:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMp63-0001Ab-JY; Sun, 05 Sep 2021 10:09:55 +0000 Received: by outflank-mailman (input) for mailman id 178989; Sun, 05 Sep 2021 10:09:53 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMp61-0001AN-OM; Sun, 05 Sep 2021 10:09:53 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMp61-0000oO-Ih; Sun, 05 Sep 2021 10:09:53 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMp61-000254-A1; Sun, 05 Sep 2021 10:09:53 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mMp61-0004yE-9W; Sun, 05 Sep 2021 10:09:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=3pRFNPLpQv5EN8fsk2irALFSUyUxUI1Oh/3I2qCKr0g=; b=fs12lc+vSecB5Ym2qoWkLibRdY I6NhxezZKgrMhDudxK+c+4plZkxW6vvQy9IIfaHPuNlpmi0Lqy225MOa6ckZJgPLNvGnw2NOvkuwm ZaeMJXTL5osHMtCU1hfUZL5pLpB7e/Nwo5U7xvr1H94jLdVHS50r+QLD1vh/jtcFS0Ew=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-coverity test] 164827: all pass - PUSHED X-Osstest-Versions-This: xen=2d4978ead4b98452bc45ebe47952e524b12e2b41 X-Osstest-Versions-That: xen=96607a8e680e7f965ca868d11f8b0636317d2618 From: osstest service owner Date: Sun, 05 Sep 2021 10:09:53 +0000 flight 164827 xen-unstable-coverity real [real] http://logs.test-lab.xenproject.org/osstest/logs/164827/ Perfect :-) All tests in this flight passed as required version targeted for testing: xen 2d4978ead4b98452bc45ebe47952e524b12e2b41 baseline version: xen 96607a8e680e7f965ca868d11f8b0636317d2618 Last test of basis 164692 2021-09-01 09:18:30 Z 4 days Testing same since 164827 2021-09-05 09:18:31 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Christian Lindig Ian Jackson Jan Beulich jobs: coverity-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 96607a8e68..2d4978ead4 2d4978ead4b98452bc45ebe47952e524b12e2b41 -> coverity-tested/smoke From xen-devel-bounces@lists.xenproject.org Sun Sep 05 10:47:29 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 05 Sep 2021 10:47:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.179000.325154 (Exim 4.92) (envelope-from ) id 1mMpgC-0005uY-L0; Sun, 05 Sep 2021 10:47:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 179000.325154; Sun, 05 Sep 2021 10:47:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMpgC-0005uR-Gd; Sun, 05 Sep 2021 10:47:16 +0000 Received: by outflank-mailman (input) for mailman id 179000; Sun, 05 Sep 2021 10:47:15 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMpgB-0005uH-4i; Sun, 05 Sep 2021 10:47:15 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMpgA-0001Wq-WA; Sun, 05 Sep 2021 10:47:14 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMpgA-00043Y-Mw; Sun, 05 Sep 2021 10:47:14 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mMpgA-0004IA-ML; Sun, 05 Sep 2021 10:47:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=HkLJhTlZb89vRvAC3abpXsxnDMdi4iAQCcx4LQ+zvso=; b=4XCfzITAhIdTvLRr2pzAwF6sBy gW/HeM/KH3oMetB/i7OQyHew7UmHNBS9peKHNBMR5OV1OtARdaDP1lTEthcIKdWHZjbSSh1oiGLsc wVeYzJEhyNS6P8rt2emiJa+sDZitpUr1+qVzMTkTCfrUFZSTBMfEsafElq1UergcFMAo=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 164828: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=edf8bc6d24c6f490c27de3144eee88f1ca40ce6a X-Osstest-Versions-That: ovmf=cae735f61328d64e2e8991036707b9e78c0f5f63 From: osstest service owner Date: Sun, 05 Sep 2021 10:47:14 +0000 flight 164828 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/164828/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 164674 build-amd64 6 xen-build fail REGR. vs. 164674 build-i386-xsm 6 xen-build fail REGR. vs. 164674 build-i386 6 xen-build fail REGR. vs. 164674 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf edf8bc6d24c6f490c27de3144eee88f1ca40ce6a baseline version: ovmf cae735f61328d64e2e8991036707b9e78c0f5f63 Last test of basis 164674 2021-08-31 02:56:52 Z 5 days Failing since 164686 2021-09-01 03:03:43 Z 4 days 42 attempts Testing same since 164806 2021-09-04 09:41:21 Z 1 days 16 attempts ------------------------------------------------------------ People who touched revisions under test: Anthony PERARD DunTan Gary Lin Hao A Wu Jim Fehlig Lin, Gary (HPS OE-Linux) Loo Tung Lun Loo, Tung Lun Mark Wilson Marvin H?user Michael Kubacki Rebecca Cran Wenxing Hou Wenyi Xie jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 302 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Sep 05 11:49:49 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 05 Sep 2021 11:49:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.179009.325168 (Exim 4.92) (envelope-from ) id 1mMqeY-0004Fq-Ai; Sun, 05 Sep 2021 11:49:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 179009.325168; Sun, 05 Sep 2021 11:49:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMqeY-0004Fj-6z; Sun, 05 Sep 2021 11:49:38 +0000 Received: by outflank-mailman (input) for mailman id 179009; Sun, 05 Sep 2021 11:49:36 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMqeW-0004FZ-OE; Sun, 05 Sep 2021 11:49:36 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMqeW-0002aw-Hv; Sun, 05 Sep 2021 11:49:36 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMqeW-0007pv-7D; Sun, 05 Sep 2021 11:49:36 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mMqeW-0000np-6j; Sun, 05 Sep 2021 11:49:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=EPnSfGwbjasYKIcT8A8b0nREtc5NXpVUs4o5vBrwA88=; b=0FHrRgFwZTRGMCE3gembDYUob6 SD5IkChxcW+GUEDhnlpO79zh8JJ9pW9NGemUa7XOOe6N9hkyydB5LHpIRgBrmR/L7jR14jsPSjv8k gK/pM7UWoSDUAyKUFDV9D7qU99vHJQoYYxlzLuMQy5VicrGSPwNX+ClWF/WKHsnUMoNY=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 164819: tolerable FAIL X-Osstest-Failures: xen-unstable:test-amd64-amd64-qemuu-freebsd11-amd64:guest-start/freebsd.repeat:fail:heisenbug xen-unstable:test-amd64-amd64-examine:memdisk-try-append:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=2d4978ead4b98452bc45ebe47952e524b12e2b41 X-Osstest-Versions-That: xen=2d4978ead4b98452bc45ebe47952e524b12e2b41 From: osstest service owner Date: Sun, 05 Sep 2021 11:49:36 +0000 flight 164819 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/164819/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-qemuu-freebsd11-amd64 21 guest-start/freebsd.repeat fail in 164805 pass in 164819 test-amd64-amd64-examine 4 memdisk-try-append fail pass in 164805 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 164805 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 164805 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 164805 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 164805 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 164805 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 164805 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 164805 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 164805 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 164805 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 164805 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 164805 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen 2d4978ead4b98452bc45ebe47952e524b12e2b41 baseline version: xen 2d4978ead4b98452bc45ebe47952e524b12e2b41 Last test of basis 164819 2021-09-05 01:51:58 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Sun Sep 05 11:50:01 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 05 Sep 2021 11:50:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.179011.325182 (Exim 4.92) (envelope-from ) id 1mMqeu-0004he-Nb; Sun, 05 Sep 2021 11:50:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 179011.325182; Sun, 05 Sep 2021 11:50:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMqeu-0004hV-KH; Sun, 05 Sep 2021 11:50:00 +0000 Received: by outflank-mailman (input) for mailman id 179011; Sun, 05 Sep 2021 11:49:59 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMqet-0004eQ-9y; Sun, 05 Sep 2021 11:49:59 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMqet-0002ba-4X; Sun, 05 Sep 2021 11:49:59 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMqes-0007qQ-NZ; Sun, 05 Sep 2021 11:49:58 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mMqes-0000uC-N1; Sun, 05 Sep 2021 11:49:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=aqDfAzm3/tvuHlNVWaYf6KFuVsKB2oDXlhKlIc/Hvco=; b=OixmnyFWEdY+tE6VP+d4bclbBM TizIcwCD6U41zashzirH09buaoNin+hnQprUVEuTVjZcRsva1pJVOWQ5DtXXLz+DMLUt0kolKERNr 8hs4R6Eo9b+sjXlJINVXLjWOUoB0cXrIxGpEpbzq2IE8p/U9X4q7AfSWy//b3bszte5Q=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 164829: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=edf8bc6d24c6f490c27de3144eee88f1ca40ce6a X-Osstest-Versions-That: ovmf=cae735f61328d64e2e8991036707b9e78c0f5f63 From: osstest service owner Date: Sun, 05 Sep 2021 11:49:58 +0000 flight 164829 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/164829/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 164674 build-amd64 6 xen-build fail REGR. vs. 164674 build-i386-xsm 6 xen-build fail REGR. vs. 164674 build-i386 6 xen-build fail REGR. vs. 164674 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf edf8bc6d24c6f490c27de3144eee88f1ca40ce6a baseline version: ovmf cae735f61328d64e2e8991036707b9e78c0f5f63 Last test of basis 164674 2021-08-31 02:56:52 Z 5 days Failing since 164686 2021-09-01 03:03:43 Z 4 days 43 attempts Testing same since 164806 2021-09-04 09:41:21 Z 1 days 17 attempts ------------------------------------------------------------ People who touched revisions under test: Anthony PERARD DunTan Gary Lin Hao A Wu Jim Fehlig Lin, Gary (HPS OE-Linux) Loo Tung Lun Loo, Tung Lun Mark Wilson Marvin H?user Michael Kubacki Rebecca Cran Wenxing Hou Wenyi Xie jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 302 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Sep 05 12:30:31 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 05 Sep 2021 12:30:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.179031.325195 (Exim 4.92) (envelope-from ) id 1mMrI3-0002KO-4Q; Sun, 05 Sep 2021 12:30:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 179031.325195; Sun, 05 Sep 2021 12:30:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMrI3-0002KH-1O; Sun, 05 Sep 2021 12:30:27 +0000 Received: by outflank-mailman (input) for mailman id 179031; Sun, 05 Sep 2021 12:30:25 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMrI1-0002K5-Gm; Sun, 05 Sep 2021 12:30:25 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMrI1-0003PZ-97; Sun, 05 Sep 2021 12:30:25 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMrI1-0000d4-11; Sun, 05 Sep 2021 12:30:25 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mMrI1-0007ub-0V; Sun, 05 Sep 2021 12:30:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=i/tbuT/AcFQ7viktCDHZjqCbnRpSmlO2EGBgXbcAVnQ=; b=dvOs5FQqRLMrUY8XZMjKNz4KBT L/wVUloteamz+wwPAgcEeA1qrbkGJ+SA5e4THRWql77mucK0BY1trDCVZvQAPNyjlkQLTrF5H0sHm mrbN2fw6yCQ4sQ1ZcD0A49PfuEPAoedV+9jtcq4dl8G3oMPgdIHCR67j3fVgV/7B446g=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 164830: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=edf8bc6d24c6f490c27de3144eee88f1ca40ce6a X-Osstest-Versions-That: ovmf=cae735f61328d64e2e8991036707b9e78c0f5f63 From: osstest service owner Date: Sun, 05 Sep 2021 12:30:25 +0000 flight 164830 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/164830/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 164674 build-amd64 6 xen-build fail REGR. vs. 164674 build-i386-xsm 6 xen-build fail REGR. vs. 164674 build-i386 6 xen-build fail REGR. vs. 164674 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf edf8bc6d24c6f490c27de3144eee88f1ca40ce6a baseline version: ovmf cae735f61328d64e2e8991036707b9e78c0f5f63 Last test of basis 164674 2021-08-31 02:56:52 Z 5 days Failing since 164686 2021-09-01 03:03:43 Z 4 days 44 attempts Testing same since 164806 2021-09-04 09:41:21 Z 1 days 18 attempts ------------------------------------------------------------ People who touched revisions under test: Anthony PERARD DunTan Gary Lin Hao A Wu Jim Fehlig Lin, Gary (HPS OE-Linux) Loo Tung Lun Loo, Tung Lun Mark Wilson Marvin H?user Michael Kubacki Rebecca Cran Wenxing Hou Wenyi Xie jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 302 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Sep 05 13:28:44 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 05 Sep 2021 13:28:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.179064.325228 (Exim 4.92) (envelope-from ) id 1mMsC6-00016q-RB; Sun, 05 Sep 2021 13:28:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 179064.325228; Sun, 05 Sep 2021 13:28:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMsC6-00016j-Ny; Sun, 05 Sep 2021 13:28:22 +0000 Received: by outflank-mailman (input) for mailman id 179064; Sun, 05 Sep 2021 13:28:21 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMsC5-00016Z-Qt; Sun, 05 Sep 2021 13:28:21 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMsC5-0004Un-KM; Sun, 05 Sep 2021 13:28:21 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMsC5-0002EA-AV; Sun, 05 Sep 2021 13:28:21 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mMsC5-0006uZ-9v; Sun, 05 Sep 2021 13:28:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=JuLfHvWGucj4lmIkMu+vEhVYSdG+lzX1IdEoOtsfUeM=; b=ifKBuFifi/JgzKN9rIs8gO2yJk RbcddSxDowB211/hy0tzroye1nYTz2Nr7b/wXLKKqZq0KYLi/r6y6659g1MiyuL36pDoaI5yz6wEw mkiqF/GiEtlwrr8TGoxJyERx0Rq5qd0zmO2K/cXZ3GOOOPw3b2w2vdmfITfKXpRNDdhk=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 164831: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=edf8bc6d24c6f490c27de3144eee88f1ca40ce6a X-Osstest-Versions-That: ovmf=cae735f61328d64e2e8991036707b9e78c0f5f63 From: osstest service owner Date: Sun, 05 Sep 2021 13:28:21 +0000 flight 164831 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/164831/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 164674 build-amd64 6 xen-build fail REGR. vs. 164674 build-i386-xsm 6 xen-build fail REGR. vs. 164674 build-i386 6 xen-build fail REGR. vs. 164674 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf edf8bc6d24c6f490c27de3144eee88f1ca40ce6a baseline version: ovmf cae735f61328d64e2e8991036707b9e78c0f5f63 Last test of basis 164674 2021-08-31 02:56:52 Z 5 days Failing since 164686 2021-09-01 03:03:43 Z 4 days 45 attempts Testing same since 164806 2021-09-04 09:41:21 Z 1 days 19 attempts ------------------------------------------------------------ People who touched revisions under test: Anthony PERARD DunTan Gary Lin Hao A Wu Jim Fehlig Lin, Gary (HPS OE-Linux) Loo Tung Lun Loo, Tung Lun Mark Wilson Marvin H?user Michael Kubacki Rebecca Cran Wenxing Hou Wenyi Xie jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 302 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Sep 05 14:23:39 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 05 Sep 2021 14:23:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.179084.325242 (Exim 4.92) (envelope-from ) id 1mMt3U-0007sh-Ti; Sun, 05 Sep 2021 14:23:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 179084.325242; Sun, 05 Sep 2021 14:23:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMt3U-0007sa-QV; Sun, 05 Sep 2021 14:23:32 +0000 Received: by outflank-mailman (input) for mailman id 179084; Sun, 05 Sep 2021 14:23:31 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMt3T-0007sQ-Ne; Sun, 05 Sep 2021 14:23:31 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMt3T-0005SU-HE; Sun, 05 Sep 2021 14:23:31 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMt3T-0003bj-8G; Sun, 05 Sep 2021 14:23:31 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mMt3T-0001sq-7k; Sun, 05 Sep 2021 14:23:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=yVnm4OeAa2CbBkfDWUmlmjJDE0oUKaEjM9tMJvAE1es=; b=LDoN2hFT+rQQ+rHGOvdSBQrl2L zWiX4xeTnVHuSwl4rpn7nqekZTyeSTbfi6TdCMLDD5ouBFQBTMsjV5VwW6IjHexXIR3FDWSMgKh70 LREI9MNSJcLoKdV3xXVPHa+DhhIyZG+nXCOX3F3CIEwYduS6DhzU9+xmiKT3X33jXT+o=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 164832: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=edf8bc6d24c6f490c27de3144eee88f1ca40ce6a X-Osstest-Versions-That: ovmf=cae735f61328d64e2e8991036707b9e78c0f5f63 From: osstest service owner Date: Sun, 05 Sep 2021 14:23:31 +0000 flight 164832 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/164832/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 164674 build-amd64 6 xen-build fail REGR. vs. 164674 build-i386-xsm 6 xen-build fail REGR. vs. 164674 build-i386 6 xen-build fail REGR. vs. 164674 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf edf8bc6d24c6f490c27de3144eee88f1ca40ce6a baseline version: ovmf cae735f61328d64e2e8991036707b9e78c0f5f63 Last test of basis 164674 2021-08-31 02:56:52 Z 5 days Failing since 164686 2021-09-01 03:03:43 Z 4 days 46 attempts Testing same since 164806 2021-09-04 09:41:21 Z 1 days 20 attempts ------------------------------------------------------------ People who touched revisions under test: Anthony PERARD DunTan Gary Lin Hao A Wu Jim Fehlig Lin, Gary (HPS OE-Linux) Loo Tung Lun Loo, Tung Lun Mark Wilson Marvin H?user Michael Kubacki Rebecca Cran Wenxing Hou Wenyi Xie jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 302 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Sep 05 14:58:36 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 05 Sep 2021 14:58:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.179094.325256 (Exim 4.92) (envelope-from ) id 1mMtbE-0003AF-Nc; Sun, 05 Sep 2021 14:58:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 179094.325256; Sun, 05 Sep 2021 14:58:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMtbE-0003A8-Jx; Sun, 05 Sep 2021 14:58:24 +0000 Received: by outflank-mailman (input) for mailman id 179094; Sun, 05 Sep 2021 14:58:23 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMtbD-00039y-C8; Sun, 05 Sep 2021 14:58:23 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMtbD-0005zk-5y; Sun, 05 Sep 2021 14:58:23 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMtbC-0004V7-Sr; Sun, 05 Sep 2021 14:58:22 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mMtbC-0003S2-SQ; Sun, 05 Sep 2021 14:58:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=NzurV4w00HWx/ttMFtefRVC9SXVM94Oq4/BiDm2wB+c=; b=WVKMWu84Ioc4EljMLg2Bpmri0F XMi7cMcO3i4rQ35aQCUfrnf5lfrffcV9OWX9h6Gy9Jq5phJiz0YxJ6rvRZkeGjX1tUbTi8qPUXaUX DdxclgLArM+2kDkTvmxBZ55qn+UdiPXbhuabBv2yLNSMKZtCqreh7Nwo0kzD8cs+sCxk=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 164833: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=edf8bc6d24c6f490c27de3144eee88f1ca40ce6a X-Osstest-Versions-That: ovmf=cae735f61328d64e2e8991036707b9e78c0f5f63 From: osstest service owner Date: Sun, 05 Sep 2021 14:58:22 +0000 flight 164833 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/164833/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 164674 build-amd64 6 xen-build fail REGR. vs. 164674 build-i386-xsm 6 xen-build fail REGR. vs. 164674 build-i386 6 xen-build fail REGR. vs. 164674 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf edf8bc6d24c6f490c27de3144eee88f1ca40ce6a baseline version: ovmf cae735f61328d64e2e8991036707b9e78c0f5f63 Last test of basis 164674 2021-08-31 02:56:52 Z 5 days Failing since 164686 2021-09-01 03:03:43 Z 4 days 47 attempts Testing same since 164806 2021-09-04 09:41:21 Z 1 days 21 attempts ------------------------------------------------------------ People who touched revisions under test: Anthony PERARD DunTan Gary Lin Hao A Wu Jim Fehlig Lin, Gary (HPS OE-Linux) Loo Tung Lun Loo, Tung Lun Mark Wilson Marvin H?user Michael Kubacki Rebecca Cran Wenxing Hou Wenyi Xie jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 302 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Sep 05 16:20:55 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 05 Sep 2021 16:20:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.179106.325270 (Exim 4.92) (envelope-from ) id 1mMusn-0004qi-Rf; Sun, 05 Sep 2021 16:20:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 179106.325270; Sun, 05 Sep 2021 16:20:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMusn-0004qb-NV; Sun, 05 Sep 2021 16:20:37 +0000 Received: by outflank-mailman (input) for mailman id 179106; Sun, 05 Sep 2021 16:20:36 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMusm-0004qR-2w; Sun, 05 Sep 2021 16:20:36 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMusl-0007wJ-O1; Sun, 05 Sep 2021 16:20:35 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMusl-0006Wu-Ew; Sun, 05 Sep 2021 16:20:35 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mMusl-0008EE-EW; Sun, 05 Sep 2021 16:20:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Dm8wP27U53P13eQPZIlId+ZuCVmN3e7RcEsk6ALcYiA=; b=YsJZOFbc+IitoBhc0Q7f/CZe8L YqdaGuB1gUUVMDqlLF+IpR9tzbDFcA4tEQB3FJNDRCt2qUN+UXE7df0XQv5b5na8N8DSquSm1clzF Q7Lx4WvkM13F5nzgq8bgALsYbQmga+HPtVD5fxJewk9Dh8/8DImjaOs+fAPPysNA+wI8=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 164835: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=edf8bc6d24c6f490c27de3144eee88f1ca40ce6a X-Osstest-Versions-That: ovmf=cae735f61328d64e2e8991036707b9e78c0f5f63 From: osstest service owner Date: Sun, 05 Sep 2021 16:20:35 +0000 flight 164835 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/164835/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 164674 build-amd64 6 xen-build fail REGR. vs. 164674 build-i386-xsm 6 xen-build fail REGR. vs. 164674 build-i386 6 xen-build fail REGR. vs. 164674 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf edf8bc6d24c6f490c27de3144eee88f1ca40ce6a baseline version: ovmf cae735f61328d64e2e8991036707b9e78c0f5f63 Last test of basis 164674 2021-08-31 02:56:52 Z 5 days Failing since 164686 2021-09-01 03:03:43 Z 4 days 48 attempts Testing same since 164806 2021-09-04 09:41:21 Z 1 days 22 attempts ------------------------------------------------------------ People who touched revisions under test: Anthony PERARD DunTan Gary Lin Hao A Wu Jim Fehlig Lin, Gary (HPS OE-Linux) Loo Tung Lun Loo, Tung Lun Mark Wilson Marvin H?user Michael Kubacki Rebecca Cran Wenxing Hou Wenyi Xie jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 302 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Sep 05 16:35:17 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 05 Sep 2021 16:35:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.179118.325284 (Exim 4.92) (envelope-from ) id 1mMv6v-0006n9-B9; Sun, 05 Sep 2021 16:35:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 179118.325284; Sun, 05 Sep 2021 16:35:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMv6v-0006n2-7b; Sun, 05 Sep 2021 16:35:13 +0000 Received: by outflank-mailman (input) for mailman id 179118; Sun, 05 Sep 2021 16:35:12 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMv6u-0006ms-6X; Sun, 05 Sep 2021 16:35:12 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMv6t-0008CC-D5; Sun, 05 Sep 2021 16:35:11 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMv6t-0007IQ-1w; Sun, 05 Sep 2021 16:35:11 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mMv6t-0007DB-1T; Sun, 05 Sep 2021 16:35:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=6wwR1sl1hRZSWMwZViDJvKTx0hBICzF65MrZcuoS+hY=; b=5r9hTpjJWR6f4gSaQoh/qphR0d +kRC+si7q02ij/SsDrpz3wG/JGuXt+y8pRJ35YriH/BlTvW1+/2EEjH+0zivoEnosHp1BZT+v83qM +0PjncoUGUSqOZlbZe5Ntfo5FG/HU0FFVMHemMrSODg/8vUBmlAkdUzAdDkuiMfYP/nk=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 164824: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-i386-xl-qemut-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-examine:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-i386-xl-raw:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-pvshim:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-i386:xen-install:fail:regression linux-linus:test-amd64-i386-xl-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ovmf-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-coresched-i386-xl:xen-install:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit1:debian-fixup:fail:regression linux-linus:test-arm64-arm64-xl-thunderx:debian-fixup:fail:regression linux-linus:test-arm64-arm64-xl-xsm:debian-fixup:fail:regression linux-linus:test-arm64-arm64-xl-credit2:debian-fixup:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:debian-fixup:fail:regression linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-arm64-arm64-xl:guest-start:fail:regression linux-linus:test-amd64-amd64-qemuu-freebsd12-amd64:guest-localmigrate:fail:heisenbug linux-linus:test-amd64-amd64-xl-credit2:guest-start/debian.repeat:fail:heisenbug linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug linux-linus:test-amd64-amd64-xl-rtds:guest-saverestore:fail:heisenbug linux-linus:test-arm64-arm64-xl:debian-fixup:fail:heisenbug linux-linus:test-armhf-armhf-xl-vhd:guest-start:fail:heisenbug linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=49624efa65ac9889f4e7c7b2452b2e6ce42ba37d X-Osstest-Versions-That: linux=deacdb3e3979979016fcd0ffd518c320a62ad166 From: osstest service owner Date: Sun, 05 Sep 2021 16:35:11 +0000 flight 164824 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/164824/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemut-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-examine 6 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-i386-xl-raw 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-pvshim 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-i386 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ovmf-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-coresched-i386-xl 7 xen-install fail REGR. vs. 152332 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 152332 test-arm64-arm64-xl-credit1 13 debian-fixup fail REGR. vs. 152332 test-arm64-arm64-xl-thunderx 13 debian-fixup fail REGR. vs. 152332 test-arm64-arm64-xl-xsm 13 debian-fixup fail REGR. vs. 152332 test-arm64-arm64-xl-credit2 13 debian-fixup fail REGR. vs. 152332 test-arm64-arm64-libvirt-xsm 13 debian-fixup fail REGR. vs. 152332 test-arm64-arm64-examine 8 reboot fail REGR. vs. 152332 test-arm64-arm64-xl 14 guest-start fail in 164816 REGR. vs. 152332 Tests which are failing intermittently (not blocking): test-amd64-amd64-qemuu-freebsd12-amd64 17 guest-localmigrate fail in 164816 pass in 164824 test-amd64-amd64-xl-credit2 22 guest-start/debian.repeat fail in 164816 pass in 164824 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail in 164816 pass in 164824 test-amd64-amd64-xl-rtds 17 guest-saverestore fail pass in 164816 test-arm64-arm64-xl 13 debian-fixup fail pass in 164816 test-armhf-armhf-xl-vhd 13 guest-start fail pass in 164816 Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-vhd 14 migrate-support-check fail in 164816 never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail in 164816 never pass test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 152332 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 152332 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152332 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152332 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 152332 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152332 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152332 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: linux 49624efa65ac9889f4e7c7b2452b2e6ce42ba37d baseline version: linux deacdb3e3979979016fcd0ffd518c320a62ad166 Last test of basis 152332 2020-07-31 19:41:23 Z 400 days Failing since 152366 2020-08-01 20:49:34 Z 399 days 694 attempts Testing same since 164816 2021-09-04 22:09:46 Z 0 days 2 attempts ------------------------------------------------------------ 7209 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl fail test-armhf-armhf-xl pass test-amd64-i386-xl fail test-amd64-coresched-i386-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm fail test-amd64-i386-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm fail test-amd64-i386-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine pass test-arm64-arm64-examine fail test-armhf-armhf-examine pass test-amd64-i386-examine fail test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel fail test-amd64-i386-qemuu-rhel6hvm-intel fail test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair fail test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw fail test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow fail test-arm64-arm64-xl-thunderx fail test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2214305 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Sep 05 17:59:48 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 05 Sep 2021 17:59:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.179127.325297 (Exim 4.92) (envelope-from ) id 1mMwQV-0007Cb-O9; Sun, 05 Sep 2021 17:59:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 179127.325297; Sun, 05 Sep 2021 17:59:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMwQV-0007CU-LL; Sun, 05 Sep 2021 17:59:31 +0000 Received: by outflank-mailman (input) for mailman id 179127; Sun, 05 Sep 2021 17:59:30 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMwQU-0007CI-9r; Sun, 05 Sep 2021 17:59:30 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMwQU-00014N-35; Sun, 05 Sep 2021 17:59:30 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMwQT-0001jH-QH; Sun, 05 Sep 2021 17:59:29 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mMwQT-0007ZW-Pk; Sun, 05 Sep 2021 17:59:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=jJVRUsbjxefEH7Vhk+PZK/ZjgQhL0iPYKFrHYg10w2E=; b=Y1kg0Jxbj+QjyOcWxxeewKe2lK zjs0gv4jiwa5ijL6W2HoXkRz0SixV9VKZcVpXuNKVYNE61xTlURkRzFPi4k4YBh+ThA+CJKoCDLBP FyaD0151Iu7B/jPYSs2DG9KB6IIcd1Rp9MBrzQJoCRWgqZ+9kaYPONdsa598dTyXwECw=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 164837: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=edf8bc6d24c6f490c27de3144eee88f1ca40ce6a X-Osstest-Versions-That: ovmf=cae735f61328d64e2e8991036707b9e78c0f5f63 From: osstest service owner Date: Sun, 05 Sep 2021 17:59:29 +0000 flight 164837 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/164837/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 164674 build-amd64 6 xen-build fail REGR. vs. 164674 build-i386-xsm 6 xen-build fail REGR. vs. 164674 build-i386 6 xen-build fail REGR. vs. 164674 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf edf8bc6d24c6f490c27de3144eee88f1ca40ce6a baseline version: ovmf cae735f61328d64e2e8991036707b9e78c0f5f63 Last test of basis 164674 2021-08-31 02:56:52 Z 5 days Failing since 164686 2021-09-01 03:03:43 Z 4 days 49 attempts Testing same since 164806 2021-09-04 09:41:21 Z 1 days 23 attempts ------------------------------------------------------------ People who touched revisions under test: Anthony PERARD DunTan Gary Lin Hao A Wu Jim Fehlig Lin, Gary (HPS OE-Linux) Loo Tung Lun Loo, Tung Lun Mark Wilson Marvin H?user Michael Kubacki Rebecca Cran Wenxing Hou Wenyi Xie jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 302 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Sep 05 18:50:56 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 05 Sep 2021 18:50:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.179139.325312 (Exim 4.92) (envelope-from ) id 1mMxE8-0005Je-Ma; Sun, 05 Sep 2021 18:50:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 179139.325312; Sun, 05 Sep 2021 18:50:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMxE8-0005JX-Ii; Sun, 05 Sep 2021 18:50:48 +0000 Received: by outflank-mailman (input) for mailman id 179139; Sun, 05 Sep 2021 18:50:47 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMxE7-0005JN-BV; Sun, 05 Sep 2021 18:50:47 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMxE7-000221-7Q; Sun, 05 Sep 2021 18:50:47 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMxE6-0003zQ-Tt; Sun, 05 Sep 2021 18:50:46 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mMxE6-0006wb-T1; Sun, 05 Sep 2021 18:50:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=gojIG+khwv6sv7LoG2oNZDn1ZVMShQU+HHsa0a0ABMo=; b=gcPw/ytwoRMwrzY+eiM5d6i0jV XEGegvK9UKPjriFc9IuhClNCHlw/89jbqZ4fQqTwNq6VVq6dUZIu4l5yeJft9wp94riKOKmGWQn6W MKEQecIJy9L/q3FvpENEKorvSYPPi01dRKj6jurf9MdkJRvf9vWDtYJJQsHs5420K1r0=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 164838: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=edf8bc6d24c6f490c27de3144eee88f1ca40ce6a X-Osstest-Versions-That: ovmf=cae735f61328d64e2e8991036707b9e78c0f5f63 From: osstest service owner Date: Sun, 05 Sep 2021 18:50:46 +0000 flight 164838 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/164838/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 164674 build-amd64 6 xen-build fail REGR. vs. 164674 build-i386-xsm 6 xen-build fail REGR. vs. 164674 build-i386 6 xen-build fail REGR. vs. 164674 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf edf8bc6d24c6f490c27de3144eee88f1ca40ce6a baseline version: ovmf cae735f61328d64e2e8991036707b9e78c0f5f63 Last test of basis 164674 2021-08-31 02:56:52 Z 5 days Failing since 164686 2021-09-01 03:03:43 Z 4 days 50 attempts Testing same since 164806 2021-09-04 09:41:21 Z 1 days 24 attempts ------------------------------------------------------------ People who touched revisions under test: Anthony PERARD DunTan Gary Lin Hao A Wu Jim Fehlig Lin, Gary (HPS OE-Linux) Loo Tung Lun Loo, Tung Lun Mark Wilson Marvin H?user Michael Kubacki Rebecca Cran Wenxing Hou Wenyi Xie jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 302 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Sep 05 18:54:36 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 05 Sep 2021 18:54:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.179148.325343 (Exim 4.92) (envelope-from ) id 1mMxHn-0006gD-Pj; Sun, 05 Sep 2021 18:54:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 179148.325343; Sun, 05 Sep 2021 18:54:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMxHn-0006g6-Mk; Sun, 05 Sep 2021 18:54:35 +0000 Received: by outflank-mailman (input) for mailman id 179148; Sun, 05 Sep 2021 18:54:34 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMxHm-0006Ep-4J for xen-devel@lists.xenproject.org; Sun, 05 Sep 2021 18:54:34 +0000 Received: from mail-io1-xd2f.google.com (unknown [2607:f8b0:4864:20::d2f]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 6b2adada-8c5e-499a-811c-e6b2302b1dc4; Sun, 05 Sep 2021 18:54:28 +0000 (UTC) Received: by mail-io1-xd2f.google.com with SMTP id y18so5972885ioc.1 for ; Sun, 05 Sep 2021 11:54:28 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6b2adada-8c5e-499a-811c-e6b2302b1dc4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=unixindia.com; s=mail; h=mime-version:from:date:message-id:subject:to; bh=8EXbD+WXl5NKpRmiVXpJMhwGpvUlCOqYs4PO3k+SXdM=; b=QhVxTKwXCOp/+GRfDwt5AusfMdwcmKgpbXoyasGZkYjJ23jNtJVeH8rNoR5qH8gEp/ XZag0Tc02yo1GV0hDB1CnwQxyDJCe+hoeCwTNsyMCelrbp4RTD6/7mFnay/+uGAgvmuZ 3EbQKfoE2OASvDAOSpy6YvIdZ04pWdnB0GtCtJEfW2OREj+ZGNAU9zHvwhxN1vfbKdx9 hvKOunJ3icZrJ7NIFBgFVuIhBQRlBAr2JlizxbKnjVQXAvEmhqXoBvzJKuCHCZVf6+yc OobrX8cjTJZY2LybdFV+F8GOoZS7D/TGKwtE4hLaZ9DLIrMOgI2YZUU9emVo6KwgxXj4 x45A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=8EXbD+WXl5NKpRmiVXpJMhwGpvUlCOqYs4PO3k+SXdM=; b=Ey4JoLUXXO50gZZpuEcb5KJpSOPgi8bbHZtzTrdBigxLR8HSGMlrxtj5exfiKv/rsL pVqrobjQdqY2CZMcs3WOC2k6/AP11Yw0opSCIGEQvxLuENiPh4dgCSBGuMrCf1x2CTCr bs/m8BwJKmc1CcgczW7Osxs1e/bYGdtu0V5I6urtiFcTFpJLt+qMx9a/WW38HVuHBnpv QUKuhFFLhuXbonDz/4ne34GAQhPr5eRL5BzAe2wBlzre2nPS945oE7YBAl0MC3DLvngH XefmIKdY5JEX4nEfwR0ipODEhja2bMWI8Q1c0A+DeW7m1GjbSFHIGkc9i8c+4rShJ2te mFbQ== X-Gm-Message-State: AOAM530u5ht66i6mcauPnkcZZ2tDYiS16jZBEkuCP61CFDQVvQ+W+VFA mZScULtrulCgECwrqLvnLgZv77i9dbpFBUoOq2DM27mmpDTyxQ== X-Google-Smtp-Source: ABdhPJxqI/bI7DpkdZFdjU9QxRKbM7tokg6OUGG/BLGUIkM3YYpxKmWQKyNu+HR8t3sEf72Lc1pg0f66PC3MmKV2NAo= X-Received: by 2002:a6b:e70f:: with SMTP id b15mr6949747ioh.140.1630868067583; Sun, 05 Sep 2021 11:54:27 -0700 (PDT) MIME-Version: 1.0 From: Bhasker C V Date: Sun, 5 Sep 2021 19:54:16 +0100 Message-ID: Subject: USB passthrough To: xen-users@lists.xenproject.org, xen-devel@lists.xenproject.org Content-Type: multipart/alternative; boundary="000000000000d81cc505cb440f26" --000000000000d81cc505cb440f26 Content-Type: text/plain; charset="UTF-8" Hi all, Sorry if I am starting a well-discussed thread again. I was reading through https://wiki.xenproject.org/wiki/Xen_USB_Passthrough and I understand that a xen_usbfront and xen_usbback.ko is needed. Where do i get these ? I see these provided for k 2.6.18 but that is way old. Is there a new version for these ? I tried this: $ sudo xl usbctrl-attach 14 type=pv version=2 ports=8 libxl: error: libxl_device.c:1103:device_backend_callback: Domain 14:unable to add device with path /local/domain/0/backend/vusb/14/1 libxl: error: libxl_device.c:1402:device_addrm_aocomplete: Domain 14:Unable to add vusb with id 1 libxl_device_usbctrl_add failed. and any attempt to usbdev-attach fails too Please help Thanks and regards Bhasker C V --000000000000d81cc505cb440f26 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi all,
=C2=A0Sorry if I am starting a well= -discussed thread again.
=C2=A0I was reading through=C2=A0 <= a href=3D"https://wiki.xenproject.org/wiki/Xen_USB_Passthrough">https://wik= i.xenproject.org/wiki/Xen_USB_Passthrough and I understand that a xen_u= sbfront and xen_usbback.ko is needed.

Where do i g= et these ? I see these provided for k 2.6.18 but that is way old. Is there = a new version for these ?

I tried this:
=

$ sudo xl usbctrl-attach =C2=A014 =C2=A0type=3D= pv version=3D2 ports=3D8
libxl: error: libxl_device.c:1103:device_backen= d_callback: Domain 14:unable to add device with path /local/domain/0/backen= d/vusb/14/1
libxl: error: libxl_device.c:1402:device_addrm_aocomplete: D= omain 14:Unable to add vusb with id 1
libxl_device_usbctrl_add failed.

and any attempt to usbdev-attach fails too

Please help

Thanks an= d=C2=A0regards
Bhasker C V
--000000000000d81cc505cb440f26-- From xen-devel-bounces@lists.xenproject.org Sun Sep 05 19:58:36 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 05 Sep 2021 19:58:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.179172.325354 (Exim 4.92) (envelope-from ) id 1mMyHV-0005fq-KF; Sun, 05 Sep 2021 19:58:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 179172.325354; Sun, 05 Sep 2021 19:58:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMyHV-0005fj-HL; Sun, 05 Sep 2021 19:58:21 +0000 Received: by outflank-mailman (input) for mailman id 179172; Sun, 05 Sep 2021 19:58:20 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMyHU-0005fZ-TE; Sun, 05 Sep 2021 19:58:20 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMyHU-00039e-Kt; Sun, 05 Sep 2021 19:58:20 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMyHU-000064-Bo; Sun, 05 Sep 2021 19:58:20 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mMyHU-0005LM-BH; Sun, 05 Sep 2021 19:58:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=L9hErdsUzD0R5chV0wNmmm6ai0FxpL2ZYx588iOTh2o=; b=yaSzhbmqGSGyUZOau5gRnE7Grp +hFHuclo76dhKfezRmvLqtlcq0SSpXp3tHbXbCUhNhLpw8v9FgojFxCijmRtBc6g9P/ATy49JTfjG 9Qj14Eaq/RLPQuLDITANuhJxvxfyqveRZjHF7q02xd43vX2nkXiCj1krScl+MPoNKi5Q=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 164839: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=edf8bc6d24c6f490c27de3144eee88f1ca40ce6a X-Osstest-Versions-That: ovmf=cae735f61328d64e2e8991036707b9e78c0f5f63 From: osstest service owner Date: Sun, 05 Sep 2021 19:58:20 +0000 flight 164839 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/164839/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 164674 build-amd64 6 xen-build fail REGR. vs. 164674 build-i386-xsm 6 xen-build fail REGR. vs. 164674 build-i386 6 xen-build fail REGR. vs. 164674 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf edf8bc6d24c6f490c27de3144eee88f1ca40ce6a baseline version: ovmf cae735f61328d64e2e8991036707b9e78c0f5f63 Last test of basis 164674 2021-08-31 02:56:52 Z 5 days Failing since 164686 2021-09-01 03:03:43 Z 4 days 51 attempts Testing same since 164806 2021-09-04 09:41:21 Z 1 days 25 attempts ------------------------------------------------------------ People who touched revisions under test: Anthony PERARD DunTan Gary Lin Hao A Wu Jim Fehlig Lin, Gary (HPS OE-Linux) Loo Tung Lun Loo, Tung Lun Mark Wilson Marvin H?user Michael Kubacki Rebecca Cran Wenxing Hou Wenyi Xie jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 302 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Sep 05 21:22:43 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 05 Sep 2021 21:22:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.179181.325368 (Exim 4.92) (envelope-from ) id 1mMzas-0007EJ-UC; Sun, 05 Sep 2021 21:22:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 179181.325368; Sun, 05 Sep 2021 21:22:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMzas-0007EC-R8; Sun, 05 Sep 2021 21:22:26 +0000 Received: by outflank-mailman (input) for mailman id 179181; Sun, 05 Sep 2021 21:22:25 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMzar-0007Dj-QS; Sun, 05 Sep 2021 21:22:25 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMzar-0004dA-MI; Sun, 05 Sep 2021 21:22:25 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mMzar-0004Le-B3; Sun, 05 Sep 2021 21:22:25 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mMzar-0002RP-AY; Sun, 05 Sep 2021 21:22:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=SgmPazDYXVewKCwkXxNBO2S/4EpW0pWg4M3fhKT3DBU=; b=Jjzo8hQFUnOVD489GicmBGDvFZ t2U+30tPrppFhqFrKKhgGrZb6ixtQWbyHC4aZyAVeEyYbEsrudnJ2rmagMTeFoGfK5nseVTtCU5Ht 6nA/D6PzmkctTaQQKg7LnWn1FH7Qjz8HhhMwd/4p4ity+mv5hXNxuAXydarhdYg78GYI=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 164840: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=edf8bc6d24c6f490c27de3144eee88f1ca40ce6a X-Osstest-Versions-That: ovmf=cae735f61328d64e2e8991036707b9e78c0f5f63 From: osstest service owner Date: Sun, 05 Sep 2021 21:22:25 +0000 flight 164840 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/164840/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 164674 build-amd64 6 xen-build fail REGR. vs. 164674 build-i386-xsm 6 xen-build fail REGR. vs. 164674 build-i386 6 xen-build fail REGR. vs. 164674 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf edf8bc6d24c6f490c27de3144eee88f1ca40ce6a baseline version: ovmf cae735f61328d64e2e8991036707b9e78c0f5f63 Last test of basis 164674 2021-08-31 02:56:52 Z 5 days Failing since 164686 2021-09-01 03:03:43 Z 4 days 52 attempts Testing same since 164806 2021-09-04 09:41:21 Z 1 days 26 attempts ------------------------------------------------------------ People who touched revisions under test: Anthony PERARD DunTan Gary Lin Hao A Wu Jim Fehlig Lin, Gary (HPS OE-Linux) Loo Tung Lun Loo, Tung Lun Mark Wilson Marvin H?user Michael Kubacki Rebecca Cran Wenxing Hou Wenyi Xie jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 302 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Sep 05 21:58:48 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 05 Sep 2021 21:58:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.179188.325383 (Exim 4.92) (envelope-from ) id 1mN09z-0002X1-ND; Sun, 05 Sep 2021 21:58:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 179188.325383; Sun, 05 Sep 2021 21:58:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mN09z-0002Wu-Ju; Sun, 05 Sep 2021 21:58:43 +0000 Received: by outflank-mailman (input) for mailman id 179188; Sun, 05 Sep 2021 21:58:41 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mN09x-0002Wk-Ks; Sun, 05 Sep 2021 21:58:41 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mN09x-0005Ox-E9; Sun, 05 Sep 2021 21:58:41 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mN09x-0005kZ-56; Sun, 05 Sep 2021 21:58:41 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mN09x-0000E3-4f; Sun, 05 Sep 2021 21:58:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=7oRiAF+UuXjwp/zPSmEzgdbT10FCFJ9l346YRH2sggY=; b=o0KwI8Qa0prNNjvVIee7wMF4yU rtBS2AfXUzj6P1L1O70NoEDdlo/tL8wKKUQpovgmuoMzix/cMV/UyfNDgXEnKjU3kDI7YrIV+GLLt 9N2Xrt+7sfiGL2qeJL3VP9+szX+ALEmRhGNRscaRnuS5kgb3M5x91dvC+zYmZfsMeaV4=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 164841: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=edf8bc6d24c6f490c27de3144eee88f1ca40ce6a X-Osstest-Versions-That: ovmf=cae735f61328d64e2e8991036707b9e78c0f5f63 From: osstest service owner Date: Sun, 05 Sep 2021 21:58:41 +0000 flight 164841 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/164841/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 164674 build-amd64 6 xen-build fail REGR. vs. 164674 build-i386-xsm 6 xen-build fail REGR. vs. 164674 build-i386 6 xen-build fail REGR. vs. 164674 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf edf8bc6d24c6f490c27de3144eee88f1ca40ce6a baseline version: ovmf cae735f61328d64e2e8991036707b9e78c0f5f63 Last test of basis 164674 2021-08-31 02:56:52 Z 5 days Failing since 164686 2021-09-01 03:03:43 Z 4 days 53 attempts Testing same since 164806 2021-09-04 09:41:21 Z 1 days 27 attempts ------------------------------------------------------------ People who touched revisions under test: Anthony PERARD DunTan Gary Lin Hao A Wu Jim Fehlig Lin, Gary (HPS OE-Linux) Loo Tung Lun Loo, Tung Lun Mark Wilson Marvin H?user Michael Kubacki Rebecca Cran Wenxing Hou Wenyi Xie jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 302 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Sep 05 22:10:39 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 05 Sep 2021 22:10:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.179195.325397 (Exim 4.92) (envelope-from ) id 1mN0LS-0004uJ-RF; Sun, 05 Sep 2021 22:10:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 179195.325397; Sun, 05 Sep 2021 22:10:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mN0LS-0004uC-Nh; Sun, 05 Sep 2021 22:10:34 +0000 Received: by outflank-mailman (input) for mailman id 179195; Sun, 05 Sep 2021 22:10:33 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mN0LR-0004u6-Bi for xen-devel@lists.xenproject.org; Sun, 05 Sep 2021 22:10:33 +0000 Received: from mailhost.m5p.com (unknown [74.104.188.4]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 162f4d44-0e96-11ec-b06d-12813bfff9fa; Sun, 05 Sep 2021 22:10:32 +0000 (UTC) Received: from m5p.com (mailhost.m5p.com [IPv6:2001:470:1f07:15ff:0:0:0:f7]) by mailhost.m5p.com (8.16.1/8.15.2) with ESMTPS id 185MANtd061312 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO) for ; Sun, 5 Sep 2021 18:10:29 -0400 (EDT) (envelope-from ehem@m5p.com) Received: (from ehem@localhost) by m5p.com (8.16.1/8.15.2/Submit) id 185MANaZ061311 for xen-devel@lists.xenproject.org; Sun, 5 Sep 2021 15:10:23 -0700 (PDT) (envelope-from ehem) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 162f4d44-0e96-11ec-b06d-12813bfff9fa Date: Sun, 5 Sep 2021 15:10:23 -0700 From: Elliott Mitchell To: xen-devel@lists.xenproject.org Subject: HVM/PVH Ballon crash Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=0.4 required=10.0 tests=KHOP_HELO_FCRDNS autolearn=no autolearn_force=no version=3.4.5 X-Spam-Checker-Version: SpamAssassin 3.4.5 (2021-03-20) on mattapan.m5p.com I brought this up a while back, but it still appears to be present and the latest observations appear rather serious. I'm unsure of the entire set of conditions for reproduction. Domain 0 on this machine is PV (I think the BIOS enables the IOMMU, but this is an older AMD IOMMU). This has been confirmed with Xen 4.11 and Xen 4.14. This includes Debian's patches, but those are mostly backports or environment adjustments. Domain 0 is presently using a 4.19 kernel. The trigger is creating a HVM or PVH domain where memory does not equal maxmem. New observations: I discovered this occurs with PVH domains in addition to HVM ones. I got PVH GRUB operational. PVH GRUB appeared at to operate normally and not trigger the crash/panic. The crash/panic occurred some number of seconds after the Linux kernel was loaded. Mitigation by not using ballooning with HVM/PVH is workable, but this is quite a large mine in the configuration. I'm wondering if perhaps it is actually the Linux kernel in Domain 0 which is panicing. The crash/panic occurring AFTER the main kernel loads suggests some action by the user domain is doing is the actual trigger of the crash/panic. That last point is actually rather worrisome. There might be a security hole lurking here. -- (\___(\___(\______ --=> 8-) EHM <=-- ______/)___/)___/) \BS ( | ehem+sigmsg@m5p.com PGP 87145445 | ) / \_CS\ | _____ -O #include O- _____ | / _/ 8A19\___\_|_/58D2 7E3D DDF4 7BA6 <-PGP-> 41D1 B375 37D0 8714\_|_/___/5445 From xen-devel-bounces@lists.xenproject.org Sun Sep 05 22:28:56 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 05 Sep 2021 22:28:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.179201.325407 (Exim 4.92) (envelope-from ) id 1mN0cs-0006pK-Ay; Sun, 05 Sep 2021 22:28:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 179201.325407; Sun, 05 Sep 2021 22:28:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mN0cs-0006pD-81; Sun, 05 Sep 2021 22:28:34 +0000 Received: by outflank-mailman (input) for mailman id 179201; Sun, 05 Sep 2021 22:28:33 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mN0cq-0006p3-UZ; Sun, 05 Sep 2021 22:28:32 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mN0cq-0005v2-MK; Sun, 05 Sep 2021 22:28:32 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mN0cq-0006o8-Ce; Sun, 05 Sep 2021 22:28:32 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mN0cq-00020b-CB; Sun, 05 Sep 2021 22:28:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=axnSHiXodJ9jMEzWBW8wEMbJouerLroLOegMPFJpIQI=; b=lBVraYAqTcJLgH7lY08zF/F3+f CcemINncuAKxF3XqpKs7Ety8B7PT1EUiv/UzjoEYn8iqvZXMihAxHl7OToenTTQqU3BAmqmonxXGb v8jEcHvjxo/kS4XqvuaKV5/RrpeZaHsMzAcqsuFI8IKvEEo02lE4346da8P1lcENh2V4=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 164842: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=edf8bc6d24c6f490c27de3144eee88f1ca40ce6a X-Osstest-Versions-That: ovmf=cae735f61328d64e2e8991036707b9e78c0f5f63 From: osstest service owner Date: Sun, 05 Sep 2021 22:28:32 +0000 flight 164842 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/164842/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 164674 build-amd64 6 xen-build fail REGR. vs. 164674 build-i386-xsm 6 xen-build fail REGR. vs. 164674 build-i386 6 xen-build fail REGR. vs. 164674 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf edf8bc6d24c6f490c27de3144eee88f1ca40ce6a baseline version: ovmf cae735f61328d64e2e8991036707b9e78c0f5f63 Last test of basis 164674 2021-08-31 02:56:52 Z 5 days Failing since 164686 2021-09-01 03:03:43 Z 4 days 54 attempts Testing same since 164806 2021-09-04 09:41:21 Z 1 days 28 attempts ------------------------------------------------------------ People who touched revisions under test: Anthony PERARD DunTan Gary Lin Hao A Wu Jim Fehlig Lin, Gary (HPS OE-Linux) Loo Tung Lun Loo, Tung Lun Mark Wilson Marvin H?user Michael Kubacki Rebecca Cran Wenxing Hou Wenyi Xie jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 302 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Sep 05 22:40:11 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 05 Sep 2021 22:40:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.179209.325421 (Exim 4.92) (envelope-from ) id 1mN0o2-0000pS-Gu; Sun, 05 Sep 2021 22:40:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 179209.325421; Sun, 05 Sep 2021 22:40:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mN0o2-0000pL-Ds; Sun, 05 Sep 2021 22:40:06 +0000 Received: by outflank-mailman (input) for mailman id 179209; Sun, 05 Sep 2021 22:40:04 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mN0o0-0000a2-CT; Sun, 05 Sep 2021 22:40:04 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mN0o0-00066F-5Z; Sun, 05 Sep 2021 22:40:04 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mN0nz-00078M-P6; Sun, 05 Sep 2021 22:40:03 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mN0nz-0003O6-Od; Sun, 05 Sep 2021 22:40:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=5iCv/XOfyeM/UNtavfJ9Ptt0eMd8y392HUbKjkhS4wg=; b=eDh0Iy6dqP78xx9Ya/8fPWL9J7 UaLAYtJundpRvHL8tXrsJwyCRJk6zHeMu9FTRiV8bNPIRfOIfCVAqZGouoDJUsPs8dPIwBeSMC0Y6 QrBMlBVWeghMwu+uVX3D8lS1jZSpamyRWY+OLVN3s3aORFNEhc9D729dDjcWRZ9Bq1Zo=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 164834: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=31ebff513fad11f315377f6b07447169be8d9f86 X-Osstest-Versions-That: qemuu=9c03aa87e52567f6c9a7bf456e5dd94dc84088de From: osstest service owner Date: Sun, 05 Sep 2021 22:40:03 +0000 flight 164834 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/164834/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 164812 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 164812 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 164812 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 164812 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 164812 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 164812 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 164812 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass version targeted for testing: qemuu 31ebff513fad11f315377f6b07447169be8d9f86 baseline version: qemuu 9c03aa87e52567f6c9a7bf456e5dd94dc84088de Last test of basis 164812 2021-09-04 18:37:54 Z 1 days Testing same since 164834 2021-09-05 15:08:59 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Guoyi Tu Markus Armbruster Peter Maydell jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git 9c03aa87e5..31ebff513f 31ebff513fad11f315377f6b07447169be8d9f86 -> upstream-tested From xen-devel-bounces@lists.xenproject.org Sun Sep 05 23:30:38 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 05 Sep 2021 23:30:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.179217.325436 (Exim 4.92) (envelope-from ) id 1mN1ab-0006Yy-CQ; Sun, 05 Sep 2021 23:30:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 179217.325436; Sun, 05 Sep 2021 23:30:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mN1ab-0006Yr-9B; Sun, 05 Sep 2021 23:30:17 +0000 Received: by outflank-mailman (input) for mailman id 179217; Sun, 05 Sep 2021 23:30:16 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mN1aa-0006Yh-8h; Sun, 05 Sep 2021 23:30:16 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mN1aa-0006w2-1W; Sun, 05 Sep 2021 23:30:16 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mN1aZ-0008T9-Po; Sun, 05 Sep 2021 23:30:15 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mN1aZ-0002V9-PH; Sun, 05 Sep 2021 23:30:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=xAyIJmn83P4y4PchSS09I4vJ7w4pd9BHksCIycItHbM=; b=B/wDE+KdQPv3OJetjtl5Y8HCbe rICG0KookFG+Y2PRzUtdIu1iUoq9ZMsk54+8Xd4Uu7OCfZ/HI0UPZ8diTd2fR7YQXSFklNlEyhMmm F31VyUfm5DKK9mZhRByElrs4FCKTimzEZ4+7FamcOSzXeL7WUNGcMpC54EIEGIYekESE=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 164843: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=edf8bc6d24c6f490c27de3144eee88f1ca40ce6a X-Osstest-Versions-That: ovmf=cae735f61328d64e2e8991036707b9e78c0f5f63 From: osstest service owner Date: Sun, 05 Sep 2021 23:30:15 +0000 flight 164843 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/164843/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 164674 build-amd64 6 xen-build fail REGR. vs. 164674 build-i386-xsm 6 xen-build fail REGR. vs. 164674 build-i386 6 xen-build fail REGR. vs. 164674 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf edf8bc6d24c6f490c27de3144eee88f1ca40ce6a baseline version: ovmf cae735f61328d64e2e8991036707b9e78c0f5f63 Last test of basis 164674 2021-08-31 02:56:52 Z 5 days Failing since 164686 2021-09-01 03:03:43 Z 4 days 55 attempts Testing same since 164806 2021-09-04 09:41:21 Z 1 days 29 attempts ------------------------------------------------------------ People who touched revisions under test: Anthony PERARD DunTan Gary Lin Hao A Wu Jim Fehlig Lin, Gary (HPS OE-Linux) Loo Tung Lun Loo, Tung Lun Mark Wilson Marvin H?user Michael Kubacki Rebecca Cran Wenxing Hou Wenyi Xie jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 302 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Sep 05 23:58:43 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 05 Sep 2021 23:58:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.179225.325450 (Exim 4.92) (envelope-from ) id 1mN220-00017g-My; Sun, 05 Sep 2021 23:58:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 179225.325450; Sun, 05 Sep 2021 23:58:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mN220-00017Z-Ju; Sun, 05 Sep 2021 23:58:36 +0000 Received: by outflank-mailman (input) for mailman id 179225; Sun, 05 Sep 2021 23:58:35 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mN21z-00017P-4y; Sun, 05 Sep 2021 23:58:35 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mN21z-0007Mp-0p; Sun, 05 Sep 2021 23:58:35 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mN21y-0000oQ-Pn; Sun, 05 Sep 2021 23:58:34 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mN21y-00024x-PK; Sun, 05 Sep 2021 23:58:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=TN/LJvJsvq8eUTj9KwEtNJ4MqKZ65qSIGifMKhJ8Fao=; b=63erZShl6gvLbeb18AcUE787Js Lo9ZWWzAA8FhMjKyoSEOG8AendzvAgxilzX+d7PWU3YH4XjhcPWUx5tqPJxu5rb2UEtvbNfXMLWKz MaVOdIdwVeAatcK997bhQRV/H2wJUKvIbljtjZuCyhGEMmXW6q5XCjIJ55TyXfiNOu4s=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 164844: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=edf8bc6d24c6f490c27de3144eee88f1ca40ce6a X-Osstest-Versions-That: ovmf=cae735f61328d64e2e8991036707b9e78c0f5f63 From: osstest service owner Date: Sun, 05 Sep 2021 23:58:34 +0000 flight 164844 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/164844/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 164674 build-amd64 6 xen-build fail REGR. vs. 164674 build-i386-xsm 6 xen-build fail REGR. vs. 164674 build-i386 6 xen-build fail REGR. vs. 164674 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf edf8bc6d24c6f490c27de3144eee88f1ca40ce6a baseline version: ovmf cae735f61328d64e2e8991036707b9e78c0f5f63 Last test of basis 164674 2021-08-31 02:56:52 Z 5 days Failing since 164686 2021-09-01 03:03:43 Z 4 days 56 attempts Testing same since 164806 2021-09-04 09:41:21 Z 1 days 30 attempts ------------------------------------------------------------ People who touched revisions under test: Anthony PERARD DunTan Gary Lin Hao A Wu Jim Fehlig Lin, Gary (HPS OE-Linux) Loo Tung Lun Loo, Tung Lun Mark Wilson Marvin H?user Michael Kubacki Rebecca Cran Wenxing Hou Wenyi Xie jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 302 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Sep 06 00:06:18 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Sep 2021 00:06:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.179233.325464 (Exim 4.92) (envelope-from ) id 1mN29O-0003Ke-EI; Mon, 06 Sep 2021 00:06:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 179233.325464; Mon, 06 Sep 2021 00:06:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mN29O-0003KX-AQ; Mon, 06 Sep 2021 00:06:14 +0000 Received: by outflank-mailman (input) for mailman id 179233; Mon, 06 Sep 2021 00:06:12 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mN29M-0003KK-Av for xen-devel@lists.xenproject.org; Mon, 06 Sep 2021 00:06:12 +0000 Received: from mail-il1-x12e.google.com (unknown [2607:f8b0:4864:20::12e]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id a0ebf0cd-8a17-492a-baf9-6cf81701f4d9; Mon, 06 Sep 2021 00:06:11 +0000 (UTC) Received: by mail-il1-x12e.google.com with SMTP id a1so5200397ilj.6 for ; Sun, 05 Sep 2021 17:06:11 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a0ebf0cd-8a17-492a-baf9-6cf81701f4d9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=unixindia.com; s=mail; h=mime-version:from:date:message-id:subject:to; bh=YrSeOqW8u+/b+kn90enjWBIEuYxqEEa6/DzSOYyPeAY=; b=gcldrFazzFF5WFdtYu2jX31ym0BBjR1auHkSXfPsxG96O8W3kkW9MnNMGCjoS8drWX 6jS8oPTp48QV+bW60fft6BFuU8yqSJMAmMwcCE7Qpvjf7MgjMxK5aqvMV1H8pzrH/k8r qA2INpgGQJb19vRncTdl1jj4zsNTSvsH85ttq5L10Nxj3csSuV9T0eRmcXmP6O4boU51 Ri2kSZcSg0ct1b82FEWC6z4LJSxlP/2eMMIFZJp9EkAxx8iiitpo4TrLfa+t1/0ftmpM 7uk4dldo2Am4l4e+JK/rcCKASX+gCs0drZy/EZ8o23RIneSg/zEH1O7cYEeqY25f9KJo tI/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=YrSeOqW8u+/b+kn90enjWBIEuYxqEEa6/DzSOYyPeAY=; b=RpcbtifRF4JBPnP6tq+ekbY5LnkcX0DW+cQHN84ySmH1Hc4c40A8CDAoWdoAQG0o7B +blGfa+0Tb6MZI9cx2rLY1R1JZH1Zc+cP4AltYcP6R4BA+yHmF4bDPWVOaCqsNGNHJWG yCYc5299iGLLG4ZfrkypKZRAZo19dQlSdjoRbV12m8nP8MztFhWv7rlUd5KOyGze4gs2 CNWQrjZqjh+GtUPMB+x16di7UirI2gbClzp3Ltz+vECrilM25K21JP++7mz4bZ2fj+bT wV67q7aZbgOIQDlbf3+Bl8XeRooqe3QWM5CEzkh4cvXjBZ86PNxcLPJIOfqM5HjutC/3 hN3Q== X-Gm-Message-State: AOAM530SzCuNHHAXFz8bfra7G0fLzwBEaBISKAFO+7PoIYicxqjZlPaW p10LnTuCL/aJ/NwhGeNRx+089gMkLsPWBxamkKl8EZZZp6w= X-Google-Smtp-Source: ABdhPJzPn1n3lZMZ0mAzdV/rhaVBfKhWFWOE69Ok0QaASId1ikfXjRzDX3Cey8Kp8fWgoo2qabbpw4FUkkOhE1h4+U0= X-Received: by 2002:a92:c109:: with SMTP id p9mr6578692ile.115.1630886771096; Sun, 05 Sep 2021 17:06:11 -0700 (PDT) MIME-Version: 1.0 From: Bhasker C V Date: Mon, 6 Sep 2021 01:06:00 +0100 Message-ID: Subject: DomU crashes when restored if it has pci passthrough To: xen-users@lists.xenproject.org, xen-devel@lists.xenproject.org Content-Type: multipart/alternative; boundary="000000000000a918c205cb486aff" --000000000000a918c205cb486aff Content-Type: text/plain; charset="UTF-8" Hi, I have a domU and that domU has network vf attached to it. The save and restore leads to crash of the domU after restore. Am I doing anything wrong? Regards Bhasker C V --000000000000a918c205cb486aff Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi,
=C2=A0I have a domU and that domU has n= etwork vf attached to it.
=C2=A0The save and restore leads t= o crash of the domU after restore.
=C2=A0Am I doing anything= wrong?

Regards
Bhasker C V
--000000000000a918c205cb486aff-- From xen-devel-bounces@lists.xenproject.org Mon Sep 06 00:10:35 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Sep 2021 00:10:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.179258.325492 (Exim 4.92) (envelope-from ) id 1mN2DZ-0005oq-Ga; Mon, 06 Sep 2021 00:10:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 179258.325492; Mon, 06 Sep 2021 00:10:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mN2DZ-0005oj-DL; Mon, 06 Sep 2021 00:10:33 +0000 Received: by outflank-mailman (input) for mailman id 179258; Mon, 06 Sep 2021 00:10:31 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mN2DX-0005ob-KC for xen-devel@lists.xenproject.org; Mon, 06 Sep 2021 00:10:31 +0000 Received: from mail-io1-xd2e.google.com (unknown [2607:f8b0:4864:20::d2e]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 69973039-38c7-4729-a02f-b33b902cadbd; Mon, 06 Sep 2021 00:10:30 +0000 (UTC) Received: by mail-io1-xd2e.google.com with SMTP id y18so6627259ioc.1 for ; Sun, 05 Sep 2021 17:10:30 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 69973039-38c7-4729-a02f-b33b902cadbd DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=unixindia.com; s=mail; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=GxF+ayA/gKbFEeVpCODk2PNYX4glvADmxV7Gx3ybgIU=; b=a8NpY+rVtH87EPNsbyAx0M6Um/29TPQMeYPdrsOjv/NqC1UYXo5ZP13tBiVQaI9Fee NRm5yL4TakS2hi/uhoP+BAthc2gxkEioNi+ANZjWV/jiLBMO/oqRDYiiIpnDVJ2gsxmQ 9ToMF7Noge9u6nV/QysfeR25koGJKfRKYwyigATOyBjjmwEOtVHfIpRM294q7TjL01Og dUhSr2ZdosJlyqsPh+cjR3ZnkZz0Zs/iNko3hsVv3NTy5S7OOMQ8CqraDzpAK/3A3fDk xLDhB5QWPPKkX0U0RA+M091QxeE/45HCPVrNMK5RzqJP2KI3+vI4To9CpGYeqLqGWZwT tjmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=GxF+ayA/gKbFEeVpCODk2PNYX4glvADmxV7Gx3ybgIU=; b=WnsZfxIig20zWd1H1pQakq5qoRlIv8BO/E26EboniMAOmNMw4ONumRCXo0nf5Yc4RK qW+iuUS9C8cUyg3gWSFWDhZW91v172/Ru0je7f9cTOgUrszkV/BHBwpw7Wfu6URa/u6f kX3Iw8eojbwKiVuEJJqy3QeHWD/Kt0PB4XbW2bQbn58U0s/zIxlZ+PvI/nHng0Kwt9+t Aph+3CAV0cTF8S5YLqLuGhD5zNlXdQUEu+V350/X5/mdPE5lkx5V5jQzB53zvSn1VR/l +l9kEeQBDFJ7N3tWjemDyiyl5kZ+x1CKwZ0N3JMQ0EbPZSBwhiSFcm5ClH43437l2Oz3 TIFw== X-Gm-Message-State: AOAM530cdVIvUbGhHmMIyBJhjcU6KoGC/pJPA5ECUd9GbRYaTGyx39P+ QGz672a3Gu7yJeE18DDDeostCbcBLLQR04pTzLcKCQ== X-Google-Smtp-Source: ABdhPJzmlGrjP9v8qzWH6l5kaYjSyu5HD1L9QeBkTQuvo0jy1HBRGTcHJYUOCBUpM+mCQagBFP/gvxx7+hS33W+ySPI= X-Received: by 2002:a6b:f203:: with SMTP id q3mr7596862ioh.32.1630887030484; Sun, 05 Sep 2021 17:10:30 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Bhasker C V Date: Mon, 6 Sep 2021 01:10:19 +0100 Message-ID: Subject: Re: DomU crashes when restored if it has pci passthrough To: xen-users@lists.xenproject.org, xen-devel@lists.xenproject.org Content-Type: multipart/alternative; boundary="0000000000001f044005cb487a35" --0000000000001f044005cb487a35 Content-Type: text/plain; charset="UTF-8" Ignore me on this https://wiki.xenproject.org/wiki/Xen_PCI_Passthrough says it is not possible On Mon, Sep 6, 2021 at 1:06 AM Bhasker C V wrote: > Hi, > I have a domU and that domU has network vf attached to it. > The save and restore leads to crash of the domU after restore. > Am I doing anything wrong? > > Regards > Bhasker C V > --0000000000001f044005cb487a35 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Ignore me on this
says it is not possible

On Mo= n, Sep 6, 2021 at 1:06 AM Bhasker C V <bhasker@unixindia.com> wrote:
Hi,
=C2=A0I ha= ve a domU and that domU has network vf attached to it.
=C2= =A0The save and restore leads to crash of the domU after restore.
=C2=A0Am I doing anything wrong?

Regards
Bhasker C V
--0000000000001f044005cb487a35-- From xen-devel-bounces@lists.xenproject.org Mon Sep 06 00:29:38 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Sep 2021 00:29:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.179287.325522 (Exim 4.92) (envelope-from ) id 1mN2Vw-0000RS-I4; Mon, 06 Sep 2021 00:29:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 179287.325522; Mon, 06 Sep 2021 00:29:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mN2Vw-0000RL-Dy; Mon, 06 Sep 2021 00:29:32 +0000 Received: by outflank-mailman (input) for mailman id 179287; Mon, 06 Sep 2021 00:29:31 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mN2Vv-0000R9-KI; Mon, 06 Sep 2021 00:29:31 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mN2Vv-0008Vw-Ee; Mon, 06 Sep 2021 00:29:31 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mN2Vv-0001Wq-43; Mon, 06 Sep 2021 00:29:31 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mN2Vv-00013D-3W; Mon, 06 Sep 2021 00:29:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=t6ACaiYYpsM00TI5pG2Of+1jhHOD/xDwLJkkAPYT35s=; b=FvtEt3xI6Wt+TqsICII2pzsqev 7eGvcsFYdEflDfEuhIsN9mOp35s24ELS/mpGPLXiTQyivplquv1Ae8pHHKuZmnS6R50yPZfGs+nE+ adF1j/Rkc2v0e/qdjmcezRjtG/Akg8J1pzPcpmWnZopdWkKIVPSGDDmKPlVyL2tZrVcI=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 164845: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=edf8bc6d24c6f490c27de3144eee88f1ca40ce6a X-Osstest-Versions-That: ovmf=cae735f61328d64e2e8991036707b9e78c0f5f63 From: osstest service owner Date: Mon, 06 Sep 2021 00:29:31 +0000 flight 164845 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/164845/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 164674 build-amd64 6 xen-build fail REGR. vs. 164674 build-i386-xsm 6 xen-build fail REGR. vs. 164674 build-i386 6 xen-build fail REGR. vs. 164674 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf edf8bc6d24c6f490c27de3144eee88f1ca40ce6a baseline version: ovmf cae735f61328d64e2e8991036707b9e78c0f5f63 Last test of basis 164674 2021-08-31 02:56:52 Z 5 days Failing since 164686 2021-09-01 03:03:43 Z 4 days 57 attempts Testing same since 164806 2021-09-04 09:41:21 Z 1 days 31 attempts ------------------------------------------------------------ People who touched revisions under test: Anthony PERARD DunTan Gary Lin Hao A Wu Jim Fehlig Lin, Gary (HPS OE-Linux) Loo Tung Lun Loo, Tung Lun Mark Wilson Marvin H?user Michael Kubacki Rebecca Cran Wenxing Hou Wenyi Xie jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 302 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Sep 06 01:28:48 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Sep 2021 01:28:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.179296.325536 (Exim 4.92) (envelope-from ) id 1mN3R3-0005bD-2H; Mon, 06 Sep 2021 01:28:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 179296.325536; Mon, 06 Sep 2021 01:28:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mN3R2-0005b6-VB; Mon, 06 Sep 2021 01:28:32 +0000 Received: by outflank-mailman (input) for mailman id 179296; Mon, 06 Sep 2021 01:28:31 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mN3R1-0005aw-DT; Mon, 06 Sep 2021 01:28:31 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mN3R1-0007Iz-5q; Mon, 06 Sep 2021 01:28:31 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mN3R0-000307-U8; Mon, 06 Sep 2021 01:28:30 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mN3R0-0006Eb-Tc; Mon, 06 Sep 2021 01:28:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=IFZLvMtNKtje9Fyc/tk7eFpwGUk3iyCIQIxjcs7WUUo=; b=wFcVcyLAepghwq+PCsiim7GR7a PhJ5ikRzvMuF26wobP2Ri4nh9BvXJl7HFluBSbrPMmzPQ6qRqi+urtzR13i4Ty2646gDXMYCFniy8 korN3qXOEoQ5CW0GYWAGJnvzwKLdB6yeKUmN4/x9ChPrPrdE4AfheyOmSP8Sw6NLnbPs=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 164846: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=edf8bc6d24c6f490c27de3144eee88f1ca40ce6a X-Osstest-Versions-That: ovmf=cae735f61328d64e2e8991036707b9e78c0f5f63 From: osstest service owner Date: Mon, 06 Sep 2021 01:28:30 +0000 flight 164846 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/164846/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 164674 build-amd64 6 xen-build fail REGR. vs. 164674 build-i386-xsm 6 xen-build fail REGR. vs. 164674 build-i386 6 xen-build fail REGR. vs. 164674 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf edf8bc6d24c6f490c27de3144eee88f1ca40ce6a baseline version: ovmf cae735f61328d64e2e8991036707b9e78c0f5f63 Last test of basis 164674 2021-08-31 02:56:52 Z 5 days Failing since 164686 2021-09-01 03:03:43 Z 4 days 58 attempts Testing same since 164806 2021-09-04 09:41:21 Z 1 days 32 attempts ------------------------------------------------------------ People who touched revisions under test: Anthony PERARD DunTan Gary Lin Hao A Wu Jim Fehlig Lin, Gary (HPS OE-Linux) Loo Tung Lun Loo, Tung Lun Mark Wilson Marvin H?user Michael Kubacki Rebecca Cran Wenxing Hou Wenyi Xie jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 302 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Sep 06 01:59:25 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Sep 2021 01:59:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.179306.325550 (Exim 4.92) (envelope-from ) id 1mN3ul-0000t8-IF; Mon, 06 Sep 2021 01:59:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 179306.325550; Mon, 06 Sep 2021 01:59:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mN3ul-0000t1-Do; Mon, 06 Sep 2021 01:59:15 +0000 Received: by outflank-mailman (input) for mailman id 179306; Mon, 06 Sep 2021 01:59:13 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mN3uj-0000sr-8b; Mon, 06 Sep 2021 01:59:13 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mN3uj-0007nO-4R; Mon, 06 Sep 2021 01:59:13 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mN3ui-0003lF-T3; Mon, 06 Sep 2021 01:59:12 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mN3ui-00038E-SY; Mon, 06 Sep 2021 01:59:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=orQPH5E08YAc2dCabRRtT3xNghF7XWfee9MNw3o6ouI=; b=Oh/ftyvOFPSKL818AL/70mLao5 X+43pfOTU65b+2gpDqAoiSzvmGwXShX7FSK2ymA4nymPb2PklNrHLAceWY8UfMtgfl4u5JiwlIdga 9tlSQoJEpEEa8Mv9AFqOMHToDRgH2UvWBNyY0hUKVK5i8+HRaAv9FsLFHpyWYSnJDTTI=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 164847: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=edf8bc6d24c6f490c27de3144eee88f1ca40ce6a X-Osstest-Versions-That: ovmf=cae735f61328d64e2e8991036707b9e78c0f5f63 From: osstest service owner Date: Mon, 06 Sep 2021 01:59:12 +0000 flight 164847 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/164847/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 164674 build-amd64 6 xen-build fail REGR. vs. 164674 build-i386-xsm 6 xen-build fail REGR. vs. 164674 build-i386 6 xen-build fail REGR. vs. 164674 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf edf8bc6d24c6f490c27de3144eee88f1ca40ce6a baseline version: ovmf cae735f61328d64e2e8991036707b9e78c0f5f63 Last test of basis 164674 2021-08-31 02:56:52 Z 5 days Failing since 164686 2021-09-01 03:03:43 Z 4 days 59 attempts Testing same since 164806 2021-09-04 09:41:21 Z 1 days 33 attempts ------------------------------------------------------------ People who touched revisions under test: Anthony PERARD DunTan Gary Lin Hao A Wu Jim Fehlig Lin, Gary (HPS OE-Linux) Loo Tung Lun Loo, Tung Lun Mark Wilson Marvin H?user Michael Kubacki Rebecca Cran Wenxing Hou Wenyi Xie jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 302 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Sep 06 02:24:16 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Sep 2021 02:24:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.179315.325564 (Exim 4.92) (envelope-from ) id 1mN4Iq-0004vk-Mf; Mon, 06 Sep 2021 02:24:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 179315.325564; Mon, 06 Sep 2021 02:24:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mN4Iq-0004vd-JP; Mon, 06 Sep 2021 02:24:08 +0000 Received: by outflank-mailman (input) for mailman id 179315; Mon, 06 Sep 2021 02:24:08 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mN4Ip-0004vX-T6 for xen-devel@lists.xen.org; Mon, 06 Sep 2021 02:24:07 +0000 Received: from mail-pj1-x102d.google.com (unknown [2607:f8b0:4864:20::102d]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id a15e629f-1d3c-455a-8653-b9e4a053d60b; Mon, 06 Sep 2021 02:24:06 +0000 (UTC) Received: by mail-pj1-x102d.google.com with SMTP id n13-20020a17090a4e0d00b0017946980d8dso3340172pjh.5 for ; Sun, 05 Sep 2021 19:24:05 -0700 (PDT) Received: from laputa (p784a2304.tkyea130.ap.so-net.ne.jp. [120.74.35.4]) by smtp.gmail.com with ESMTPSA id b7sm5582312pfl.195.2021.09.05.19.23.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 Sep 2021 19:24:04 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a15e629f-1d3c-455a-8653-b9e4a053d60b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=TIye2OuKCRdKK2inz4e7KcA5V+jm8PQZVNAbxUlcF9M=; b=ugJmyzJYLmTJvdVs2vfCx6yDxQZp2kbg8om7kdStgI1azE3b3NpW5qCcscYjm1HgC7 0S76RUOxRRMB9DW6xpkkbmtB6hDTxL0QtdONXvmwXW3ovHbnhTz9lRi/H0QJElADrgPR VC/oHUaSKizAnxCRfK43xQXtznpVEeV8UGJZXPfFSbCd6nCGKJ8r7lHeX7GeDQ9V+xru ibhLrT25bjKCDD6V1xfNLfN2tkMq9i2ChFJeg1gpFGAEiP+8liY5o3PC3Am56bFvKYb1 X73JlQzIvZ5LtUn8xy3KwwitUu0ZeZko324byhqkUtaO+/fgWzN7py2yQQMBH0jSEU5s yiBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=TIye2OuKCRdKK2inz4e7KcA5V+jm8PQZVNAbxUlcF9M=; b=UngTuoNSphFBxHKHdIk8Vrvhi8eRTxRvxEgLVbNKeFmZ8V0mAXWnlx5SylzHiFwa8O oWmh18gMYQERNQtLwfMrnCnMZWJlXcvsPjMvvXC9c3X7VIVDQ187mL1j6OSXuPJY0YeO t2xm0YJPCOJ1LIU4y1rCwldGf1Tm+qoxh2v2furI/8QEVnWHfrxvDeMaH7JSpj3vxstA EWdsBgF5CTgQS8QBiHP0XrPEFA5AP163S+l7TTlEJ3I19PgIRbJbvlOhu2Ckv87DK6iK ZKMgS0MktntscIRoqCWa2UzSmvluribb3/Oxnq/zLuh0g9N4+wYe6glQbu0gVdYHu+ZM KvUQ== X-Gm-Message-State: AOAM530XvEnXcjATh0kVNWU57oLsECF+u2lbPMyloot1tgpP1LwHuoML b8DG2j9/WzWVdy2wm+MRhyxKgg== X-Google-Smtp-Source: ABdhPJwCO1zSOXyxpTWEILD/F2gLRiZRWkwd2ZxF74/o/wUpG2r2d3jsgevbkR2rmE4PDW1bcWPNoQ== X-Received: by 2002:a17:90a:de04:: with SMTP id m4mr11661221pjv.187.1630895045015; Sun, 05 Sep 2021 19:24:05 -0700 (PDT) Date: Mon, 6 Sep 2021 11:23:56 +0900 From: AKASHI Takahiro To: Alex Benn??e Cc: Stefan Hajnoczi , Stefano Stabellini , Stratos Mailing List , virtio-dev@lists.oasis-open.org, Arnd Bergmann , Viresh Kumar , Stefano Stabellini , Jan Kiszka , Carl van Schaik , pratikp@quicinc.com, Srivatsa Vaddagiri , Jean-Philippe Brucker , Mathieu Poirier , Wei.Chen@arm.com, olekstysh@gmail.com, Oleksandr_Tyshchenko@epam.com, Bertrand.Marquis@arm.com, Artem_Mygaiev@epam.com, julien@xen.org, jgross@suse.com, paul@xen.org, xen-devel@lists.xen.org, Elena Afanasova Subject: Re: Enabling hypervisor agnosticism for VirtIO backends Message-ID: <20210906022356.GD40187@laputa> References: <87v94ldrqq.fsf@linaro.org> <875yvkh1p1.fsf@linaro.org> <20210903080609.GD47953@laputa> <87czpqq9qu.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87czpqq9qu.fsf@linaro.org> Alex, On Fri, Sep 03, 2021 at 10:28:06AM +0100, Alex Benn??e wrote: > > AKASHI Takahiro writes: > > > Alex, > > > > On Wed, Sep 01, 2021 at 01:53:34PM +0100, Alex Benn??e wrote: > >> > >> Stefan Hajnoczi writes: > >> > >> > [[PGP Signed Part:Undecided]] > >> > On Wed, Aug 04, 2021 at 12:20:01PM -0700, Stefano Stabellini wrote: > >> >> > Could we consider the kernel internally converting IOREQ messages from > >> >> > the Xen hypervisor to eventfd events? Would this scale with other kernel > >> >> > hypercall interfaces? > >> >> > > >> >> > So any thoughts on what directions are worth experimenting with? > >> >> > >> >> One option we should consider is for each backend to connect to Xen via > >> >> the IOREQ interface. We could generalize the IOREQ interface and make it > >> >> hypervisor agnostic. The interface is really trivial and easy to add. > >> >> The only Xen-specific part is the notification mechanism, which is an > >> >> event channel. If we replaced the event channel with something else the > >> >> interface would be generic. See: > >> >> https://gitlab.com/xen-project/xen/-/blob/staging/xen/include/public/hvm/ioreq.h#L52 > >> > > >> > There have been experiments with something kind of similar in KVM > >> > recently (see struct ioregionfd_cmd): > >> > https://lore.kernel.org/kvm/dad3d025bcf15ece11d9df0ff685e8ab0a4f2edd.1613828727.git.eafanasova@gmail.com/ > >> > >> Reading the cover letter was very useful in showing how this provides a > >> separate channel for signalling IO events to userspace instead of using > >> the normal type-2 vmexit type event. I wonder how deeply tied the > >> userspace facing side of this is to KVM? Could it provide a common FD > >> type interface to IOREQ? > > > > Why do you stick to a "FD" type interface? > > I mean most user space interfaces on POSIX start with a file descriptor > and the usual read/write semantics or a series of ioctls. Who do you assume is responsible for implementing this kind of fd semantics, OSs on BE or hypervisor itself? I think such interfaces can only be easily implemented on type-2 hypervisors. # In this sense, I don't think rust-vmm, as it is, cannot be # a general solution. > >> As I understand IOREQ this is currently a direct communication between > >> userspace and the hypervisor using the existing Xen message bus. My > > > > With IOREQ server, IO event occurrences are notified to BE via Xen's event > > channel, while the actual contexts of IO events (see struct ioreq in ioreq.h) > > are put in a queue on a single shared memory page which is to be assigned > > beforehand with xenforeignmemory_map_resource hypervisor call. > > If we abstracted the IOREQ via the kernel interface you would probably > just want to put the ioreq structure on a queue rather than expose the > shared page to userspace. Where is that queue? > >> worry would be that by adding knowledge of what the underlying > >> hypervisor is we'd end up with excess complexity in the kernel. For one > >> thing we certainly wouldn't want an API version dependency on the kernel > >> to understand which version of the Xen hypervisor it was running on. > > > > That's exactly what virtio-proxy in my proposal[1] does; All the hypervisor- > > specific details of IO event handlings are contained in virtio-proxy > > and virtio BE will communicate with virtio-proxy through a virtqueue > > (yes, virtio-proxy is seen as yet another virtio device on BE) and will > > get IO event-related *RPC* callbacks, either MMIO read or write, from > > virtio-proxy. > > > > See page 8 (protocol flow) and 10 (interfaces) in [1]. > > There are two areas of concern with the proxy approach at the moment. > The first is how the bootstrap of the virtio-proxy channel happens and As I said, from BE point of view, virtio-proxy would be seen as yet another virtio device by which BE could talk to "virtio proxy" vm or whatever else. This way we guarantee BE's hypervisor-agnosticism instead of having "common" hypervisor interfaces. That is the base of my idea. > the second is how many context switches are involved in a transaction. > Of course with all things there is a trade off. Things involving the > very tightest latency would probably opt for a bare metal backend which > I think would imply hypervisor knowledge in the backend binary. In configuration phase of virtio device, the latency won't be a big matter. In device operations (i.e. read/write to block devices), if we can resolve 'mmap' issue, as Oleksandr is proposing right now, the only issue is how efficiently we can deliver notification to the opposite side. Right? And this is a very common problem whatever approach we would take. Anyhow, if we do care the latency in my approach, most of virtio-proxy- related code can be re-implemented just as a stub (or shim?) library since the protocols are defined as RPCs. In this case, however, we would lose the benefit of providing "single binary" BE. (I know this is is an arguable requirement, though.) # Would we better discuss what "hypervisor-agnosticism" means? -Takahiro Akashi > > > > If kvm's ioregionfd can fit into this protocol, virtio-proxy for kvm > > will hopefully be implemented using ioregionfd. > > > > -Takahiro Akashi > > > > [1] https://op-lists.linaro.org/pipermail/stratos-dev/2021-August/000548.html > > -- > Alex Bennée From xen-devel-bounces@lists.xenproject.org Mon Sep 06 02:32:43 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Sep 2021 02:32:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.179324.325575 (Exim 4.92) (envelope-from ) id 1mN4R0-0006cb-Md; Mon, 06 Sep 2021 02:32:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 179324.325575; Mon, 06 Sep 2021 02:32:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mN4R0-0006cU-Im; Mon, 06 Sep 2021 02:32:34 +0000 Received: by outflank-mailman (input) for mailman id 179324; Mon, 06 Sep 2021 02:32:33 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mN4Qz-0006cK-F4; Mon, 06 Sep 2021 02:32:33 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mN4Qz-0000NZ-5f; Mon, 06 Sep 2021 02:32:33 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mN4Qy-0004Sn-Rn; Mon, 06 Sep 2021 02:32:32 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mN4Qy-0006Gw-Qc; Mon, 06 Sep 2021 02:32:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=eRLYvhcg0uu4eqzt61OkoYUoEs1z3GvbnRQM52xnbEs=; b=H+vxTSfcHkdkGhB5W0OnXkzOyZ pbnsy98Wll2IyIILiQ9iHthhnKyjtLANiQ5HYI6Gya4eihzle65n2YYNjHtyNbAf+ZyJdC9mAvjoy SktDGMwCzwRt2zGWCuWSjI51jKKstn96t6wdvNaZvZE7zQVf2AymiZ9M4tKzfQzJ6ZcA=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 164836: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-i386-xl-qemut-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-examine:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-i386-xl-raw:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-pvshim:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-i386:xen-install:fail:regression linux-linus:test-amd64-i386-xl-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ovmf-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-coresched-i386-xl:xen-install:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit1:debian-fixup:fail:regression linux-linus:test-arm64-arm64-xl-thunderx:debian-fixup:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:debian-fixup:fail:regression linux-linus:test-arm64-arm64-xl-credit2:debian-fixup:fail:regression linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-arm64-arm64-xl:guest-start:fail:regression linux-linus:test-arm64-arm64-xl-xsm:debian-fixup:fail:regression linux-linus:test-amd64-amd64-qemuu-freebsd12-amd64:guest-localmigrate:fail:heisenbug linux-linus:test-amd64-amd64-xl-credit2:guest-start/debian.repeat:fail:heisenbug linux-linus:test-amd64-amd64-xl-rtds:guest-saverestore:fail:heisenbug linux-linus:test-armhf-armhf-xl-vhd:guest-start:fail:heisenbug linux-linus:test-arm64-arm64-xl:debian-fixup:fail:heisenbug linux-linus:test-arm64-arm64-xl-xsm:xen-boot:fail:heisenbug linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=49624efa65ac9889f4e7c7b2452b2e6ce42ba37d X-Osstest-Versions-That: linux=deacdb3e3979979016fcd0ffd518c320a62ad166 From: osstest service owner Date: Mon, 06 Sep 2021 02:32:32 +0000 flight 164836 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/164836/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemut-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-examine 6 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-i386-xl-raw 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-pvshim 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-i386 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ovmf-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-coresched-i386-xl 7 xen-install fail REGR. vs. 152332 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 152332 test-arm64-arm64-xl-credit1 13 debian-fixup fail REGR. vs. 152332 test-arm64-arm64-xl-thunderx 13 debian-fixup fail REGR. vs. 152332 test-arm64-arm64-libvirt-xsm 13 debian-fixup fail REGR. vs. 152332 test-arm64-arm64-xl-credit2 13 debian-fixup fail REGR. vs. 152332 test-arm64-arm64-examine 8 reboot fail REGR. vs. 152332 test-arm64-arm64-xl 14 guest-start fail in 164816 REGR. vs. 152332 test-arm64-arm64-xl-xsm 13 debian-fixup fail in 164824 REGR. vs. 152332 Tests which are failing intermittently (not blocking): test-amd64-amd64-qemuu-freebsd12-amd64 17 guest-localmigrate fail in 164816 pass in 164836 test-amd64-amd64-xl-credit2 22 guest-start/debian.repeat fail in 164816 pass in 164836 test-amd64-amd64-xl-rtds 17 guest-saverestore fail in 164824 pass in 164836 test-armhf-armhf-xl-vhd 13 guest-start fail in 164824 pass in 164836 test-arm64-arm64-xl 13 debian-fixup fail pass in 164816 test-arm64-arm64-xl-xsm 8 xen-boot fail pass in 164824 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 164824 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 152332 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 152332 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152332 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 152332 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152332 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152332 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152332 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: linux 49624efa65ac9889f4e7c7b2452b2e6ce42ba37d baseline version: linux deacdb3e3979979016fcd0ffd518c320a62ad166 Last test of basis 152332 2020-07-31 19:41:23 Z 401 days Failing since 152366 2020-08-01 20:49:34 Z 400 days 695 attempts Testing same since 164816 2021-09-04 22:09:46 Z 1 days 3 attempts ------------------------------------------------------------ 7209 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl fail test-armhf-armhf-xl pass test-amd64-i386-xl fail test-amd64-coresched-i386-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm fail test-amd64-i386-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm fail test-amd64-i386-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine pass test-arm64-arm64-examine fail test-armhf-armhf-examine pass test-amd64-i386-examine fail test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel fail test-amd64-i386-qemuu-rhel6hvm-intel fail test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair fail test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow fail test-arm64-arm64-xl-thunderx fail test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2214305 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Sep 06 03:15:08 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Sep 2021 03:15:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.179334.325589 (Exim 4.92) (envelope-from ) id 1mN564-0003RV-UJ; Mon, 06 Sep 2021 03:15:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 179334.325589; Mon, 06 Sep 2021 03:15:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mN564-0003RO-Qy; Mon, 06 Sep 2021 03:15:00 +0000 Received: by outflank-mailman (input) for mailman id 179334; Mon, 06 Sep 2021 03:15:00 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mN564-0003RE-1d; Mon, 06 Sep 2021 03:15:00 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mN563-0001XE-TT; Mon, 06 Sep 2021 03:14:59 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mN563-0005lU-LO; Mon, 06 Sep 2021 03:14:59 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mN563-0007sz-Kw; Mon, 06 Sep 2021 03:14:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=DC4VoHwFw7nN5BJLNdxU4GM3D/LLQe3DRsqAWhMFWUU=; b=6F4H7HuulC/4+Kh9ounmsAr9uR SMQ7lCR7ao+KhTGxqVxSwlUitE14cY3p+xAZ1GZgPZ+67i+YTA6Pgpt1KMh+xTNqIIDrpRKP3CfnU ATfOEcRFTloIhFwuN/SGZLm27FbhsR0kuso2j4q5MPbC6DcFwN84flN9N1KtAwgtE/Os=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 164849: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=edf8bc6d24c6f490c27de3144eee88f1ca40ce6a X-Osstest-Versions-That: ovmf=cae735f61328d64e2e8991036707b9e78c0f5f63 From: osstest service owner Date: Mon, 06 Sep 2021 03:14:59 +0000 flight 164849 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/164849/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 164674 build-amd64 6 xen-build fail REGR. vs. 164674 build-i386-xsm 6 xen-build fail REGR. vs. 164674 build-i386 6 xen-build fail REGR. vs. 164674 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf edf8bc6d24c6f490c27de3144eee88f1ca40ce6a baseline version: ovmf cae735f61328d64e2e8991036707b9e78c0f5f63 Last test of basis 164674 2021-08-31 02:56:52 Z 6 days Failing since 164686 2021-09-01 03:03:43 Z 5 days 60 attempts Testing same since 164806 2021-09-04 09:41:21 Z 1 days 34 attempts ------------------------------------------------------------ People who touched revisions under test: Anthony PERARD DunTan Gary Lin Hao A Wu Jim Fehlig Lin, Gary (HPS OE-Linux) Loo Tung Lun Loo, Tung Lun Mark Wilson Marvin H?user Michael Kubacki Rebecca Cran Wenxing Hou Wenyi Xie jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 302 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Sep 06 04:55:04 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Sep 2021 04:55:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.179344.325603 (Exim 4.92) (envelope-from ) id 1mN6eh-0006E4-7r; Mon, 06 Sep 2021 04:54:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 179344.325603; Mon, 06 Sep 2021 04:54:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mN6eh-0006Dx-4b; Mon, 06 Sep 2021 04:54:51 +0000 Received: by outflank-mailman (input) for mailman id 179344; Mon, 06 Sep 2021 04:54:49 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mN6ef-0006Dn-AQ; Mon, 06 Sep 2021 04:54:49 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mN6ef-0003Kp-2J; Mon, 06 Sep 2021 04:54:49 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mN6ee-0000oG-OW; Mon, 06 Sep 2021 04:54:48 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mN6ee-0005Uh-Np; Mon, 06 Sep 2021 04:54:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=UVg3TRteyt8KraxQtdIkqzOY247NIzbdDoVLohD1La0=; b=u7Z9Vz5iLgVrfOHQoaSEZTZ7f1 Eaz+RBNVZTMi+qeFaNqIGmjjjhVMoxlU7cjmvzywDdTsAD7PDV1Vw2CSkAwmcXzdpUNnvwei8AZP8 CNSxPPeSqA2N8ADaYVoiaqnd8NDW+vTYHq0xlnbISFxiklGtg1vuMwzl8J1WXuTlwMWg=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 164851: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=edf8bc6d24c6f490c27de3144eee88f1ca40ce6a X-Osstest-Versions-That: ovmf=cae735f61328d64e2e8991036707b9e78c0f5f63 From: osstest service owner Date: Mon, 06 Sep 2021 04:54:48 +0000 flight 164851 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/164851/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 164674 build-amd64 6 xen-build fail REGR. vs. 164674 build-i386-xsm 6 xen-build fail REGR. vs. 164674 build-i386 6 xen-build fail REGR. vs. 164674 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf edf8bc6d24c6f490c27de3144eee88f1ca40ce6a baseline version: ovmf cae735f61328d64e2e8991036707b9e78c0f5f63 Last test of basis 164674 2021-08-31 02:56:52 Z 6 days Failing since 164686 2021-09-01 03:03:43 Z 5 days 61 attempts Testing same since 164806 2021-09-04 09:41:21 Z 1 days 35 attempts ------------------------------------------------------------ People who touched revisions under test: Anthony PERARD DunTan Gary Lin Hao A Wu Jim Fehlig Lin, Gary (HPS OE-Linux) Loo Tung Lun Loo, Tung Lun Mark Wilson Marvin H?user Michael Kubacki Rebecca Cran Wenxing Hou Wenyi Xie jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 302 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Sep 06 06:49:00 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Sep 2021 06:49:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.179360.325616 (Exim 4.92) (envelope-from ) id 1mN8Qw-0001yl-4n; Mon, 06 Sep 2021 06:48:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 179360.325616; Mon, 06 Sep 2021 06:48:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mN8Qw-0001ye-1m; Mon, 06 Sep 2021 06:48:46 +0000 Received: by outflank-mailman (input) for mailman id 179360; Mon, 06 Sep 2021 06:48:44 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mN8Qu-0001yY-DL for xen-devel@lists.xenproject.org; Mon, 06 Sep 2021 06:48:44 +0000 Received: from mail-wm1-x329.google.com (unknown [2a00:1450:4864:20::329]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 71175502-8074-44d1-8cfb-976cad8ddc83; Mon, 06 Sep 2021 06:48:43 +0000 (UTC) Received: by mail-wm1-x329.google.com with SMTP id n39so2055687wms.1 for ; Sun, 05 Sep 2021 23:48:43 -0700 (PDT) Received: from ?IPv6:2a00:23c5:5785:9a01:f581:5504:73aa:6d39? ([2a00:23c5:5785:9a01:f581:5504:73aa:6d39]) by smtp.gmail.com with ESMTPSA id k16sm6930834wrh.24.2021.09.05.23.48.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 05 Sep 2021 23:48:42 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 71175502-8074-44d1-8cfb-976cad8ddc83 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:reply-to:subject:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=d2q96vSBWYolsynVYZ8qCx75g4juhICH/4ouPIjinkI=; b=Jyyedaj9+sm7NqUcI1nGPWdF9/qLNUsEdhKM2iNOsLkMAEpsa+1DRaYXva8ydqaQ2K EbfPLuPpu9rGlxyst45Fa9sTFZ/sR+wMAu0S5CghrRIPSz2lgf0B/qCkEbRf5i4mzviw c7lAAd9Le+RXQn96K0SUv8C5x/ACANaaqjqJunVOleHN4LheJOhKvA9Ndew/VzZ3010T 1bxbCL9e3dI9pVDJFzd/W8H6VhrQCssi6Fp1HiYxjwUycMmgE5fP1Hw4qCSQR6oySAgu TGQTohXJCy331cXN8h6t+jGsBJwTWweeV/oF2scVLMYYNWGpK+GNzJEHKPjDrQByIboF GA3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:reply-to:subject:to:cc:references :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=d2q96vSBWYolsynVYZ8qCx75g4juhICH/4ouPIjinkI=; b=AiPpZwPng5xAwWAPBBkCHbcUbK2+8KkxaQ2LmgnNuMfd4JxXIfDccPfrqrc44sZAGN KZImObD4/sYXEff8/3s0xK9N7Ou6C9SAzUArvFa7MdHk/My1bu9xI5VgwvdX3A9mlkNb j4PjIAQa6IGwBSw6lZfR7v5Ns7raMEoEXQSPTHcFL6ij/x2u9FTtp4AAE2BlQ2m/AjN7 1+hvm4Kn18FRLVHubmFKZl96sZFcAwDpOWGWOqZhH6KChP907WoiDgy3N6WKCw+s8HfP MwisSA6mEZfJaJLHSIxfcrbZXRb3aHcs6UM/b13BIZm6Dv28FhAV3zU/YWSrnVqrtG71 AuYQ== X-Gm-Message-State: AOAM531GVRNO17YvbCfzc7G5dYswnY5n8tf+x76YtS62Y2neQTTF6eLl zPZcNO6YsqPD51oWCAQBbZoz3moOmqY= X-Google-Smtp-Source: ABdhPJz5GXTy42bFINdV+bVQ/4IrI84/Mcf+IJ/fqGcFF/rg1XE+6IOHLmrnlMvlR77t4cVIc38DfA== X-Received: by 2002:a1c:cc13:: with SMTP id h19mr9722348wmb.187.1630910922999; Sun, 05 Sep 2021 23:48:42 -0700 (PDT) From: Paul Durrant X-Google-Original-From: Paul Durrant Reply-To: paul@xen.org Subject: Re: [PATCH v3 30/30] accel: Add missing AccelOpsClass::has_work() and drop SysemuCPUOps one To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org Cc: Richard Henderson , Anthony Perard , Cameron Esfahani , Claudio Fontana , Colin Xu , Eduardo Habkost , haxm-team@intel.com, Kamil Rytarowski , Laurent Vivier , Paolo Bonzini , Reinoud Zandijk , Roman Bolshakov , Stefano Stabellini , Thomas Huth , Wenchao Wang , xen-devel@lists.xenproject.org References: <20210902161543.417092-1-f4bug@amsat.org> <20210903181943.763360-1-f4bug@amsat.org> Message-ID: Date: Mon, 6 Sep 2021 07:48:41 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210903181943.763360-1-f4bug@amsat.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit On 03/09/2021 19:19, Philippe Mathieu-Daudé wrote: > cpu_common_has_work() is the default has_work() implementation > and returns 'false'. > > Explicit it for the QTest / HAX / HVF / NVMM / Xen accelerators > and remove cpu_common_has_work(). > > Since there are no more implementations of SysemuCPUOps::has_work, > remove it along with the assertion in cpu_has_work(). > > Signed-off-by: Philippe Mathieu-Daudé Xen parts... Acked-by: Paul Durrant From xen-devel-bounces@lists.xenproject.org Mon Sep 06 07:03:02 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Sep 2021 07:03:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.179382.325628 (Exim 4.92) (envelope-from ) id 1mN8eg-0004g3-FF; Mon, 06 Sep 2021 07:02:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 179382.325628; Mon, 06 Sep 2021 07:02:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mN8eg-0004fw-Bu; Mon, 06 Sep 2021 07:02:58 +0000 Received: by outflank-mailman (input) for mailman id 179382; Mon, 06 Sep 2021 07:02:57 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mN8ee-0004fq-Rj for xen-devel@lists.xenproject.org; Mon, 06 Sep 2021 07:02:57 +0000 Received: from mx0b-0039f301.pphosted.com (unknown [148.163.137.242]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 75965472-0ee0-11ec-b097-12813bfff9fa; Mon, 06 Sep 2021 07:02:55 +0000 (UTC) Received: from pps.filterd (m0174682.ppops.net [127.0.0.1]) by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 18664srY000909; Mon, 6 Sep 2021 07:02:49 GMT Received: from eur04-vi1-obe.outbound.protection.outlook.com (mail-vi1eur04lp2050.outbound.protection.outlook.com [104.47.14.50]) by mx0b-0039f301.pphosted.com with ESMTP id 3aw28ps0r0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 06 Sep 2021 07:02:49 +0000 Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17) by AM0PR03MB6242.eurprd03.prod.outlook.com (2603:10a6:20b:15c::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19; Mon, 6 Sep 2021 07:02:46 +0000 Received: from AM0PR03MB6324.eurprd03.prod.outlook.com ([fe80::641e:b269:6d21:b7f8]) by AM0PR03MB6324.eurprd03.prod.outlook.com ([fe80::641e:b269:6d21:b7f8%5]) with mapi id 15.20.4478.025; Mon, 6 Sep 2021 07:02:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 75965472-0ee0-11ec-b097-12813bfff9fa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PQk7TwGRFQCFaBgnv0VXOZWWeM6NYZTEkh6Hztv50rc03PEx21G27h6gO1VXNJ06PRc6PYxw2bwcA/TwInJbr9TJpPs3oGK5QmYR4pQLaaQjj4NoDWBZVpEZUMGkwF9a9Hlbin8gGQKkw7LeG0darT46wGL4hEoMn4U0+UHSpAtayS0fr3Hmq++4ZhkGjt3X0GKBa4XC238xuC3A2vCmlTRTE7mRFdUeOeb4XHm1bDOrcAFI+JOOGFKl5rtq4EDNHKjD5Dm2lduHAzkovIILa4T/g7/A+P0gm4co9G7MLveESpusmr8wJYe6Ltsg7StWn0xBX9w1J77CJNyc4Rq7pg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=GDTAVpAbHwGYMZmKPNl2kjdBtJNWPwV7jhug3pQvpwE=; b=WswR/JJ/zS2K7staqMNNw3o7is1s+64X2SOraKIbH33BRxVZIv0IAC7Fp8fQ5aMIlzuOo3RMs/TdD69UEwHhmq7+DssjXr2M1FE2XkcPwlEZs+EMTHr5tL0rJBTWTYKGZqpx3X5i7xg8UUWh1nTe7eDAARRqd1MXUUWAekzTnUbGTBF/MjZKpqeO0PZKabr5zBNiAapDgt3oGbqkCtRgBgD7Emu+lnKu1SemlwUdH/MdkcLhOCeIsxfecz0NkRerFJLCwkA9PBHM4mIwpmAMPihfuBXt7Xieo14yG9EQg0ka6uTHWQtjIjKRLqapAzRX70FnpEkIALw821gVDx8wjg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GDTAVpAbHwGYMZmKPNl2kjdBtJNWPwV7jhug3pQvpwE=; b=4InjGgXhNRt1Td4at2b1KE54GRLJqv7kF93wP/i6v+P6g/fn6Jc7oLPilTQB1+zEn6a3G2JkP7QFXjeb8pw4dOU4A74fmY0IJhK3XwicdBWvRisoAlGaiA2FFb4ZPkmEByoPlhNZ3csVhgJI0WlNGERfR1L417gsajI1fmr29DiamF4wNZNdZ9/zANO+tGHxdwU6YUpTl//+v4v9ftSbx8cMKrNSqwz5ApY0mLH6z7fwuxEpMoLpeUN0W7FuQtnZhkU8R3bn/uByQ+bSMR5L9Rwohfs+JQ1/LqGr3ejxwXr3t0LttFI9s9uA7bwwe3TvbcOhVs6BzSePTp2Xdp02mw== From: Oleksandr Andrushchenko To: Julien Grall , Oleksandr Andrushchenko , "xen-devel@lists.xenproject.org" CC: "sstabellini@kernel.org" , Oleksandr Tyshchenko , Volodymyr Babchuk , Artem Mygaiev , "roger.pau@citrix.com" , Bertrand Marquis , Rahul Singh Subject: Re: [PATCH 11/11] xen/arm: Process pending vPCI map/unmap operations Thread-Topic: [PATCH 11/11] xen/arm: Process pending vPCI map/unmap operations Thread-Index: AQHXoJ51zxJWpxhHEEGXNqYYBqazw6uSBESAgASU4wA= Date: Mon, 6 Sep 2021 07:02:46 +0000 Message-ID: References: <20210903083347.131786-1-andr2000@gmail.com> <20210903083347.131786-12-andr2000@gmail.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=epam.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 12ba1be1-c0e4-4060-655e-08d9710454e5 x-ms-traffictypediagnostic: AM0PR03MB6242: x-ms-exchange-transport-forked: True x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: TRdmlDVjN4rVdMieKN+iJtO+wd13W06nOiyDFtHW/adnlGRDtCofvsYSIs0z1QKYoU9K0/Z86mFFK16oxZQs+49YVw/QxzSgtAYaHD0xyXsZn7vpUizZXZWHqkjZyJOlzmuub4qnOyhtS6SyatYL23U8Z8KKHAUoUncDR1fFR+0NsYvXxeb7VllURkfOgtKXTPi5mCE9ZClKqxASlbEK5BEySy3dIR9j9w7aRP5IlvTD/M1fno0NagKRRGDc9bi7AR6tQNfseJ832AhPkjRjGV5CRjvyqoFy1EbGdAID9qSYIOrnlv3oaE2GRzxeKamCnLOVyl8BuoH8EoBXKa1X5JMUJCkO2hZzO3g1DLaLeBQrXZSLkD2yl26HybfVqXgvE1uPL6MC3mvnKmqjzODDBN5ckQ3ccMo27n8MZeKHURjK9yguv4P9wB7FeFVJR8JDBLkqsfNGJ1QDHk8600bNjFEv8v81jeBWyPw1l8cy28ETXpPndGVd+sfHn1CbaRYHatL9YrAT2Bw1kxUYKDH6eyaXIWQajLfvC1lxgKcSJOBi0qG29NRZA8Fn11kROG/P2ZI76y27eYCfpuqbdcj1GdavrrYSUj1WauaCcm+2Xno/i9+iOQyWteFE1I4uWfeTWUTqUZS8neA/5cZon5onN1IK24kcPrQlVGguo1g4VZ1HFbUpJY4KDnkJapJebGsU/bTxu7eWxJ9UauI/RuA3ZE+tfDPTWD4pE+VPbzYWAopKqIFS/fL3LvqsTVHrRKsu x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(346002)(376002)(396003)(136003)(39860400002)(66556008)(66476007)(4326008)(8936002)(64756008)(6512007)(66946007)(76116006)(66446008)(478600001)(122000001)(26005)(31686004)(71200400001)(38100700002)(54906003)(110136005)(2616005)(5660300002)(8676002)(316002)(38070700005)(36756003)(2906002)(31696002)(6506007)(53546011)(83380400001)(86362001)(186003)(6486002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?SDZ2cmR2RS8xWkFlcHJWOXhnN2ltZ2pmUzNHZWd6bHVlZUJwamlyR2IvQWxt?= =?utf-8?B?WW1mTFRQbGUzWDZPdFdQRzNFWk1kNWdrMzZUbzhtZVB1V2tYRUZWU3VlZ1JM?= =?utf-8?B?TlFvV3hwWWY0azRETmFGNWFDTGl2T0JZbnQ1L0VwU0k0Ykczb29KVTRBQlFa?= =?utf-8?B?R3RFS3hiazgrbS9lTUY3NXZPV2EzY0RDZUpVOTcrZkRKN3FRZzM2ZGcxRmg3?= =?utf-8?B?NldwYWlSdGlYTWtyMWJUY2NYcHJ4bUY4Y0N3UU1PbElGUEtDWHk5eGdDNzFV?= =?utf-8?B?SWxubFRLVXJmcnR1WjV3WHllemZUTitoa0dNb0dYdHgreWhXbU4zR1VjMHJE?= =?utf-8?B?OWJZZERGWHd2US9NT1VHa05hd2loRVEwSDR1UTFGRWdvTjhHVk90c1NsSFkv?= =?utf-8?B?N3pJY2VnWnZiNUlzN1ovU2JqRXN4Yi9maWpRTVcwVEVJcGJyTHpKdEJ1OC9r?= =?utf-8?B?bHFiVzg3SWhuRGw0S2E0WU4rZkFxUUVCNWJRN29WZGJPeFFKWXFNYU4wazdV?= =?utf-8?B?UG9IOWIvZENHWTdYa25kQldyQTB2TFVVU2g1eEtyK1dCbkp0Z0lPOFdHbHlk?= =?utf-8?B?bFE4T29RaDBpNEZXSGFJQi9QRzlFaG90WTJUaU53UHhsSDBiTlJnSDBwLzVh?= =?utf-8?B?bVBGOWFaOGZMelp6c0RVWmZvL3VwaTNjQXhlcS9KSkx5RGZhRE9RUGp3b0c4?= =?utf-8?B?azJoQ2pzMnkycC9lQU5obWR2YWFuVnphOGlSRHJCcEdBOS9QUERCNnVuRTlk?= =?utf-8?B?K2NTRVcyYVY5NUFxeWtRWHRrTWhyUXlMc2ZrcjAxdG9ncDNKdTlPZW1iWWFV?= =?utf-8?B?cFQ0cmFtUFluR1VSK0xDQzZhQUxlNFBGZ2ZHUDJ1YTNLb3FRcS9PeHpxT2dL?= =?utf-8?B?R0N4YkFqZUpsQU5IczF5QjRaQU5MNUM2SDlWMjlYMHJUVmw0RHdnQUw3bW1F?= =?utf-8?B?bk83ZUF6bi8yeS96RVA3ZXJoN0RGZUVSbzZyVVZXUUpOR0k0RWF2bGZMaVJG?= =?utf-8?B?Vm9tR0Zac0txY3FVc08xb2M2MFZxOHh5UWJrNWQ5R2NyNjZtUHkvblBlT2c2?= =?utf-8?B?bzJwVEkxSHp6bFpZNHhGZ1JSZUQwSW5QdUd4RTAreE5BUXI1YzNIcFFKejhB?= =?utf-8?B?cElUMU1YMmJobmpGOE9waE5USk4veUs2SWhDcnBCREcyMXlMTmU0TWc0VGVp?= =?utf-8?B?eHQ3dXVyYllsbWVRcnA4YVc4Y2JlQ2FvNlh3L1FaQmhNMkpzOW1MUjQybGZl?= =?utf-8?B?QjJqQ2s4V3R2SHJFVERSWDBRNFBwMHIyTkp4MVRmRC9Qdzl4YzZwWEtDU0Zn?= =?utf-8?B?bm12ZXJaaGFoZVQxSE5PMm1qd2dZdlY4M3AwQThBS0Z3MnBtTWF2ZzZmRGZk?= =?utf-8?B?VWRaNGl0K2t3MlZOaHFaM0EwMjEremlxWDZmaDRrcUFGeVNSYkhkbm1yU0ov?= =?utf-8?B?YitPb0JSNUFDSm1ScWJYUHJCSC91WGRlcmlxQUtndkxrZXhjRmhLc20zWlI4?= =?utf-8?B?NXllZHZTOHh3YnRCNExIQ2MyQ3JvRityODc4YVR3RmtxRzJFaWFzYytBV0k5?= =?utf-8?B?bkd4TEZHQTQ0ZEtNL1JET1ZiTEdVNEZJbzF6Y1pBQjhMczFLNW9WaldETGs3?= =?utf-8?B?ZlBjQk1FNDN4ckFaVGswelROZFhFSVFQZy81dFpnTUd1QUJpejdTZTZYSG9T?= =?utf-8?B?MDdqUGUvMTVjL3BJK092cFVCZTdrVlVLaklrMFhmNFJPekxaWUpzb3ZlRTNY?= =?utf-8?Q?k3+n6lPi4pIDygo1HWkwSqfkQ/S2PYg5MZ+ZBDt?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: epam.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 12ba1be1-c0e4-4060-655e-08d9710454e5 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Sep 2021 07:02:46.5732 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: NAi5LS3ymOmmbqwzhL+RJL/e7+QtFWPunQcrXqcd1AjHIZLut5SWF8x8zDXDydx4R3Wgp7of7EmB9r0cEZVvmAJhLOCYGQDuziLOhRMAn2BhzeJyMpmvKEK+BPZVW0wU X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR03MB6242 X-Proofpoint-GUID: LtIWBbLKz_VVlkAk4Ee9cQ2XEUi3PdeH X-Proofpoint-ORIG-GUID: LtIWBbLKz_VVlkAk4Ee9cQ2XEUi3PdeH X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.391,FMLib:17.0.607.475 definitions=2021-09-06_02,2021-09-03_01,2020-04-07_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 suspectscore=0 lowpriorityscore=0 spamscore=0 impostorscore=0 adultscore=0 phishscore=0 clxscore=1015 priorityscore=1501 bulkscore=0 mlxscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2108310000 definitions=main-2109060044 SGksIEp1bGllbiENCg0KT24gMDMuMDkuMjEgMTI6MDQsIEp1bGllbiBHcmFsbCB3cm90ZToNCj4g SGkgT2xla3NhbmRyLA0KPg0KPiBPbiAwMy8wOS8yMDIxIDA5OjMzLCBPbGVrc2FuZHIgQW5kcnVz aGNoZW5rbyB3cm90ZToNCj4+IEZyb206IE9sZWtzYW5kciBBbmRydXNoY2hlbmtvIDxvbGVrc2Fu ZHJfYW5kcnVzaGNoZW5rb0BlcGFtLmNvbT4NCj4+DQo+PiB2UENJIG1heSBtYXAgYW5kIHVubWFw IFBDSSBkZXZpY2UgbWVtb3J5IChCQVJzKSBiZWluZyBwYXNzZWQgdGhyb3VnaCB3aGljaA0KPj4g bWF5IHRha2UgYSBsb3Qgb2YgdGltZS4gRm9yIHRoaXMgdGhvc2Ugb3BlcmF0aW9ucyBtYXkgYmUg ZGVmZXJyZWQgdG8gYmUNCj4+IHBlcmZvcm1lZCBsYXRlciwgc28gdGhhdCB0aGV5IGNhbiBiZSBz YWZlbHkgcHJlZW1wdGVkLg0KPj4gUnVuIHRoZSBjb3JyZXNwb25kaW5nIHZQQ0kgY29kZSB3aGls ZSBzd2l0Y2hpbmcgYSB2Q1BVLg0KPg0KPiBJSVVDLCB5b3UgYXJlIHRhbGtpbmcgYWJvdXQgdGhl IGZ1bmN0aW9uIG1hcF9yYW5nZSgpIGluIHhlbi9kcml2ZXJzL3ZwY2kvaGVhZGVyLiBUaGUgZnVu Y3Rpb24gaGFzIHRoZSBmb2xsb3dpbmcgdG9kbyBmb3IgQXJtOg0KPg0KPiDCoMKgwqDCoMKgwqDC oCAvKg0KPiDCoMKgwqDCoMKgwqDCoMKgICogQVJNIFRPRE9zOg0KPiDCoMKgwqDCoMKgwqDCoMKg ICogLSBPbiBBUk0gd2hldGhlciB0aGUgbWVtb3J5IGlzIHByZWZldGNoYWJsZSBvciBub3Qgc2hv dWxkIGJlIHBhc3NlZA0KPiDCoMKgwqDCoMKgwqDCoMKgICrCoMKgIHRvIG1hcF9tbWlvX3JlZ2lv bnMgaW4gb3JkZXIgdG8gZGVjaWRlIHdoaWNoIG1lbW9yeSBhdHRyaWJ1dGVzDQo+IMKgwqDCoMKg wqDCoMKgwqAgKsKgwqAgc2hvdWxkIGJlIHVzZWQuDQo+IMKgwqDCoMKgwqDCoMKgwqAgKg0KPiDC oMKgwqDCoMKgwqDCoMKgICogLSB7dW59bWFwX21taW9fcmVnaW9ucyBkb2Vzbid0IHN1cHBvcnQg cHJlZW1wdGlvbi4NCj4gwqDCoMKgwqDCoMKgwqDCoCAqLw0KPg0KPiBUaGlzIGRvZXNuJ3Qgc2Vl bSB0byBiZSBhZGRyZXNzZWQgaW4gdGhlIHR3byBzZXJpZXMgZm9yIFBDSSBwYXNzdGhyb3VnaCBz ZW50IHNvIGZhci4gRG8geW91IGhhdmUgYW55IHBsYW4gdG8gaGFuZGxlIGl0Pw0KDQpObyBwbGFu IHlldC4NCg0KQWxsIHRoZSBtYXBwaW5ncyBhcmUgaGFwcGVuaW5nIHdpdGggcDJtX21taW9fZGly ZWN0X2RldiBhcyBvZiBub3cuDQoNCj4NCj4+DQo+PiBTaWduZWQtb2ZmLWJ5OiBPbGVrc2FuZHIg QW5kcnVzaGNoZW5rbyA8b2xla3NhbmRyX2FuZHJ1c2hjaGVua29AZXBhbS5jb20+DQo+PiAtLS0N Cj4+IMKgIHhlbi9hcmNoL2FybS90cmFwcy5jIHwgNiArKysrKysNCj4+IMKgIDEgZmlsZSBjaGFu Z2VkLCA2IGluc2VydGlvbnMoKykNCj4+DQo+PiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gvYXJtL3Ry YXBzLmMgYi94ZW4vYXJjaC9hcm0vdHJhcHMuYw0KPj4gaW5kZXggMjE5YWIzYzNmYmRlLi4xNTcx ZmI4YWZkMDMgMTAwNjQ0DQo+PiAtLS0gYS94ZW4vYXJjaC9hcm0vdHJhcHMuYw0KPj4gKysrIGIv eGVuL2FyY2gvYXJtL3RyYXBzLmMNCj4+IEBAIC0zNCw2ICszNCw3IEBADQo+PiDCoCAjaW5jbHVk ZSA8eGVuL3N5bWJvbHMuaD4NCj4+IMKgICNpbmNsdWRlIDx4ZW4vdmVyc2lvbi5oPg0KPj4gwqAg I2luY2x1ZGUgPHhlbi92aXJ0dWFsX3JlZ2lvbi5oPg0KPj4gKyNpbmNsdWRlIDx4ZW4vdnBjaS5o Pg0KPj4gwqAgwqAgI2luY2x1ZGUgPHB1YmxpYy9zY2hlZC5oPg0KPj4gwqAgI2luY2x1ZGUgPHB1 YmxpYy94ZW4uaD4NCj4+IEBAIC0yMzA0LDYgKzIzMDUsMTEgQEAgc3RhdGljIGJvb2wgY2hlY2tf Zm9yX3ZjcHVfd29yayh2b2lkKQ0KPj4gwqDCoMKgwqDCoCB9DQo+PiDCoCAjZW5kaWYNCj4+IMKg ICvCoMKgwqAgbG9jYWxfaXJxX2VuYWJsZSgpOw0KPj4gK8KgwqDCoCBpZiAoIGhhc192cGNpKHYt PmRvbWFpbikgJiYgdnBjaV9wcm9jZXNzX3BlbmRpbmcodikgKQ0KPg0KPiBMb29raW5nIGF0IHRo ZSBjb2RlIG9mIHZwY2lfcHJvY2Vzc19wZW5kaW5nKCksIGl0IGxvb2tzIGxpa2UgdGhlcmUgYXJl IHNvbWUgcmV3b3JrIHRvIGRvIGZvciBndWVzdC4gRG8geW91IHBsYW4gdG8gaGFuZGxlIGl0IGFz IHBhcnQgb2YgdGhlIHZQQ0kgc2VyaWVzPw0KWWVzLCB2UENJIGNvZGUgaXMgaGVhdmlseSB0b3Vj aGVkIHRvIHN1cHBvcnQgZ3Vlc3Qgbm9uLWlkZW50aXR5IG1hcHBpbmdzDQo+DQo+PiArwqDCoMKg wqDCoMKgwqAgcmFpc2Vfc29mdGlycShTQ0hFRFVMRV9TT0ZUSVJRKTsNCj4+ICvCoMKgwqAgbG9j YWxfaXJxX2Rpc2FibGUoKTsNCj4+ICsNCj4NCj4gRnJvbSBteSB1bmRlcnN0YW5kaW5nIG9mIHZj cGlfcHJvY2Vzc19wZW5kaW5nKCkuIFRoZSBmdW5jdGlvbiB3aWxsIHJldHVybiB0cnVlIGlmIHRo ZXJlIGFyZSBtb3JlIHdvcmsgdG8gc2NoZWR1bGUuDQpZZXMNCj4gSG93ZXZlciwgaWYgY2hlY2tf Zm9yX3ZjcHVfZm9yX3dvcmsoKSByZXR1cm4gZmFsc2UsIHRoZW4gd2Ugd2lsbCByZXR1cm4gdG8g dGhlIGd1ZXN0IGJlZm9yZSBhbnkgd29yayBmb3IgdkNQSSBoYXMgZmluaXNoZWQuIFRoaXMgaXMg YmVjYXVzZSBjaGVja19mb3JfdmNwdV93b3JrKCkgd2lsbCBub3QgYmUgY2FsbGVkIGFnYWluLg0K Q29ycmVjdA0KPg0KPiBJbiB0aGlzIGNhc2UsIEkgdGhpbmsgeW91IHdhbnQgdG8gcmV0dXJuIGFz IHNvb24gYXMgeW91IGtub3cgd2UgbmVlZCB0byByZXNjaGVkdWxlLg0KTm90IHN1cmUgSSB1bmRl cnN0YW5kIHRoaXMNCj4NCj4gSG93ZXZlciwgbG9va2luZyBhdCB0aGUgcmVzdCBvZiB0aGUgY29k ZSwgd2UgYWxyZWFkeSBoYXZlIGEgY2hlY2sgZm9yIHZwY2kgaW4gdGhlIGNvbW1vbiBJT1JFUSBj b2RlLg0KDQpXaGljaCBtYXkgbm90IGJlIGVuYWJsZWQgYXMgaXQgZGVwZW5kcyBvbiBDT05GSUdf SU9SRVFfU0VSVkVSLg0KDQpNeSB1bmRlcnN0YW5kaW5nIGlzIHRoYXQgZm9yIHg4NiBpdCBpcyBh bHdheXMgZW5hYmxlZCwgYnV0IHRoaXMgbWlnaHQgbm90IGJlIHRoZSBjYXNlIGZvciBBcm0NCg0K PiBTbyB3ZSB3b3VsZCBlbmQgdXAgdG8gY2FsbCB0d2ljZSB2cGNpX3Byb2Nlc3NfcGVuZGluZygp Lg0KU28sIGlmIENPTkZJR19JT1JFUV9TRVJWRVIgaXMgbm90IGVuYWJsZWQgdGhlbiB3ZSBlbmQg dXAgd2l0aCBvbmx5IGNhbGxpbmcgaXQgZnJvbSB0cmFwcy5jIG9uIEFybQ0KPiBNYXliZSB3ZSBz aG91bGQgbW92ZSB0aGUgY2FsbCBmcm9tIHRoZSBJT1JFUSB0byBhcmNoLWNvZGUuDQoNCkhtLiBJ IHdvdWxkIGJldHRlciB0aGluayBvZiBtb3ZpbmcgaXQgZnJvbSBJT1JFUSB0byBzb21lIG90aGVy IGNvbW1vbiBjb2RlOiBmb3IgeDg2IChpZg0KDQpteSB1bmRlcnN0YW5kaW5nIGNvcnJlY3QgYWJv dXQgQ09ORklHX0lPUkVRX1NFUlZFUikgaXQgaXMgYnkgY29pbmNpZGVuY2UgdGhhdCB3ZSBjYWxs IHZQQ0kNCg0KY29kZSBmcm9tIHRoZXJlIGFuZCBJT1JFUSBpcyBhbHdheXMgZW5hYmxlZC4NCg0K Pg0KPiBDaGVlcnMsDQo+DQpUaGFuayB5b3UsDQoNCk9sZWtzYW5kcg0K From xen-devel-bounces@lists.xenproject.org Mon Sep 06 07:17:17 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Sep 2021 07:17:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.179389.325638 (Exim 4.92) (envelope-from ) id 1mN8sO-0006KX-NM; Mon, 06 Sep 2021 07:17:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 179389.325638; Mon, 06 Sep 2021 07:17:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mN8sO-0006KQ-KP; Mon, 06 Sep 2021 07:17:08 +0000 Received: by outflank-mailman (input) for mailman id 179389; Mon, 06 Sep 2021 07:17:07 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mN8sN-0006KE-G5; Mon, 06 Sep 2021 07:17:07 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mN8sN-00064p-8w; Mon, 06 Sep 2021 07:17:07 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mN8sM-0007yK-UI; Mon, 06 Sep 2021 07:17:06 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mN8sM-00068e-Ti; Mon, 06 Sep 2021 07:17:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=e8OWnnB2XLJmpnd87ePW0WMHjn7FMJMQJMK5jwVzx8o=; b=1a+1sYKSZKgmmhKP7muXbUo9pt CJXXqYpiaOfZfihs8FWRvm6Jdx4oZFSVVnUY9yANHVsa/qDcJN0m47QeYKQDkPhqfCOfK/KIUV6+O UODuMKRI0BDY+4t17ITkBdklX0IC236unA8NwdlWz59u+XqzVsDeVYb0sE4BXa5FrI/A=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 164853: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=edf8bc6d24c6f490c27de3144eee88f1ca40ce6a X-Osstest-Versions-That: ovmf=cae735f61328d64e2e8991036707b9e78c0f5f63 From: osstest service owner Date: Mon, 06 Sep 2021 07:17:06 +0000 flight 164853 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/164853/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 164674 build-amd64 6 xen-build fail REGR. vs. 164674 build-i386-xsm 6 xen-build fail REGR. vs. 164674 build-i386 6 xen-build fail REGR. vs. 164674 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf edf8bc6d24c6f490c27de3144eee88f1ca40ce6a baseline version: ovmf cae735f61328d64e2e8991036707b9e78c0f5f63 Last test of basis 164674 2021-08-31 02:56:52 Z 6 days Failing since 164686 2021-09-01 03:03:43 Z 5 days 62 attempts Testing same since 164806 2021-09-04 09:41:21 Z 1 days 36 attempts ------------------------------------------------------------ People who touched revisions under test: Anthony PERARD DunTan Gary Lin Hao A Wu Jim Fehlig Lin, Gary (HPS OE-Linux) Loo Tung Lun Loo, Tung Lun Mark Wilson Marvin H?user Michael Kubacki Rebecca Cran Wenxing Hou Wenyi Xie jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 302 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Sep 06 07:42:54 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Sep 2021 07:42:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.179400.325653 (Exim 4.92) (envelope-from ) id 1mN9HD-0001YU-Rx; Mon, 06 Sep 2021 07:42:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 179400.325653; Mon, 06 Sep 2021 07:42:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mN9HD-0001YN-OZ; Mon, 06 Sep 2021 07:42:47 +0000 Received: by outflank-mailman (input) for mailman id 179400; Mon, 06 Sep 2021 07:42:46 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mN9HC-0001YH-I2 for xen-devel@lists.xenproject.org; Mon, 06 Sep 2021 07:42:46 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 05e1e3f2-0ee6-11ec-b099-12813bfff9fa; Mon, 06 Sep 2021 07:42:45 +0000 (UTC) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05lp2175.outbound.protection.outlook.com [104.47.17.175]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-6--VJjzU7QPaSfY_f2SYh3PQ-1; Mon, 06 Sep 2021 09:42:43 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR04MB2959.eurprd04.prod.outlook.com (2603:10a6:802:8::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.21; Mon, 6 Sep 2021 07:42:41 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4478.025; Mon, 6 Sep 2021 07:42:41 +0000 Received: from [10.156.60.236] (37.24.206.209) by PR0P264CA0074.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:18::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Mon, 6 Sep 2021 07:42:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 05e1e3f2-0ee6-11ec-b099-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1630914164; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=thr+KWDNBf4RXgukMPAM+yfG2ZtaAJHpOlaYkocEhOU=; b=fOrW/MsJJa7aHe6PBLsb2lnTluUtLDmBz1mcEa0xaA0mBeKjWVu2txQ//ukfdo69vIsjIJ T2PrAT0xoyn+iB+LrkXcph7s5u4+pv0FqQjNUaTTNcMKedE6KvrrbRavV6mR4z8jmcUGg5 goM287RYt87Wx8fJjVyzjR6/bRBXRwg= X-MC-Unique: -VJjzU7QPaSfY_f2SYh3PQ-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oe2ussa7S5SlyO7NRMUHxRj5gFZ3JEo7d7CJFEqPvsM/1Tq2Hi9g+GYatJUOnQqezXs1z6/lAtnXnSmiUM6XuBhWJfcJtGDS8LDhfy1v3kH/7AZ+rWAST+8sQ+6FQwBsBVK9hO6qUNQyasiEglhqT2LnhdK94NRh1zQNBAronCD9imvRkR4kwq4/QrjJ8Cbb9zUMA60LjPGeIYfh+Wm+5FuMMCqcpZryz1qcv8+1cw9A2WGRrUVTBG5rGytq/t91jDcPz+KuNQwQn035IzKWyZK45JznydZLPWA+NSq9HZafYoz/H32kckeQ4f8Ai9K/oi+xt4NDScDI6bgbx+YM7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=thr+KWDNBf4RXgukMPAM+yfG2ZtaAJHpOlaYkocEhOU=; b=Xaall/BESC/SB9UCTlJvcaU0oN/D9ierH/Sp9K0BqZpYEKQlKkYXNnfpsJadA+ouX6WcyyCKPs52GRxdJRVh74Bqy1c+MKGnkCLQc0+tH72Fy36UDQzazaPHt6fav/5j4/K8hrv2LAAyzTUoOTx3+8Jmoa7zIGJk85IkwoZ9bRpiikrRq46IMmlC9r3E7jlQi82SH0Z29gExn8Dpj8s4u/kGbvK9sr+siRSweJwBGQwrYNOTIDW8O85P5VphaUIfMCW6q+ZnpZbEJTF7NUT0Kxfc3ptCzQr+GX+Wik3tr24W5U3OGOB57PQc0N6ZM/4jdbJQMDFdJAckRTm1yPaLsQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com; Subject: Re: Help with Network SR-IOV (PF still in reset state. Is the PF interface up?) To: Bhasker C V References: Cc: xen-devel@lists.xenproject.org From: Jan Beulich Message-ID: <8282a111-0481-410b-4a04-f0edd4bdb326@suse.com> Date: Mon, 6 Sep 2021 09:42:39 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PR0P264CA0074.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:18::14) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f6c020da-8081-4d40-40d9-08d97109e805 X-MS-TrafficTypeDiagnostic: VI1PR04MB2959: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xrg9MqHQZJR0J7R/OFehNXU4zQjtflIUdXKWaP/Hj+t+rovV9SpH4Stjj7S8wzpAH9BTip28SR00HpL/vcPSFdfjQAqSAoSptUge1VC/3RqcwiJnXd63EqbNfOpa5JkX638f/WHc8CA02aGIq09gGoLxquEehOsL+zR84cToxkBoGUbouObLJeSta9RcdOpKTPS1xNsS4GfFx0ckCz4EJ6SncO/1DsSvLb6+iRgk8lWYmAwzRi2T9ip7BYACQJz+fsrUycMSypiqKoc2TXE6RfkH40ox9SsiwNeIwR/BW0IUpKJRfK4FGyguaSCECFMEQIMtiETYjolhh6Fetr1OjjmcDg5nr0SGx/iE4L3OXjwYO8kKdesLfSKRQM5qY/ndFF6ZDLpddOsNPTWWHiNFU3bBwkK+8zERKvIWTjIu0K5YIP6BILR3LRzyAIKDCAx+Fen0Wl2Gj7kY9CDjixlSgoEr+urKKEoaKamti1KqNQ8vNTqBwitpbVp0IiyGHFDdjmMB8pXb6RbtXjmo3WNEwVt6harF4wzgthjWb/wvxJFG/rIlvrTysa4vPLaMcmkT4iFm4qDIHHWGHdzN9EHVXTqYyrd/m4wJ9kvoYHmT9RhaGpleVyzO2FwuNnGq04WOTNCpFObOqeWAAjwsHDaJ7LHDxGucw0CyvpUWaw/tUDmcq3djjfOnsL81UB2V8CZqEeaalWqcdBkozwMAjQlmf446xjHhBSV/rxFF2U+9ckU= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(8936002)(5660300002)(6486002)(186003)(26005)(66946007)(31696002)(8676002)(2906002)(956004)(2616005)(316002)(53546011)(31686004)(83380400001)(508600001)(38100700002)(16576012)(4326008)(66556008)(66476007)(36756003)(86362001)(6916009)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SCt5UkE3cnZRMWFBdHJ5RFBYMUkyazhxWS82d2VKbmVYVHFEOS9RV1RCenpV?= =?utf-8?B?QVFSSlpGUHZDUGFrWklaeUNibk5NVXQ1c3M0RWtBRzh4UzdacTBycVlCVVh5?= =?utf-8?B?WXV6SnRVYWo5MEtoYWZ6UlZVRVA1M2JVRjNSMGFsS3RpQUVDaCtnQ3NQbTVa?= =?utf-8?B?UmkyVmJvUnNJTWoxb0lzeVdmMVZZU2JnNm81b1BZamxOYXlOdUlUZ0tSVTBj?= =?utf-8?B?QXNBMjRtNlZNdWtIMVJDbzdZaFJoYWdka21najZPQUpGWVFhQyt1VWY0dzRS?= =?utf-8?B?VmtmS3VBbTdQRDEvWG9KcCtqRGRkbEVVNGdYNURDdHR4SEw1M1BlL3padEZI?= =?utf-8?B?Rjd4L002ck5UOHB4RWYxL0FpOW1WYytVN1VKaU1ORWxnSy9sZUZDaU96emJu?= =?utf-8?B?aS9iaHQ3WDV1K1hocWpLdDFNY0VaOEFOOWZKaXRWS213VG5TK0VlNHo2bXRh?= =?utf-8?B?dWRJUG5UUVFnTzVPd0tIU2VhQW15ZU4yMkFjV3doUW5DT204SFM2VjE1OTRL?= =?utf-8?B?ZTdZS0FIQjhJOEsxcGczUE1KSzZtbXgvY3RlQ0pBOUEyR1JzZFdjT0trRUg2?= =?utf-8?B?eW01bW9rRnRvcThwWDF5OWdoVVJlb3JFM3RmaTlLbWN5czA2K0lHMWVEWTFE?= =?utf-8?B?Q05IcHhaMjArb1ZwV2JpdjlNSWJoRzlUTkI2aEFwNWM5YXlDbWxHV2NDeWYy?= =?utf-8?B?ckhYY2VnaHAzT2ZSL1haZllrRndXM0JNNFlZYjhqWXB3OE4zUXZydGp6ZjQ1?= =?utf-8?B?TFJRd2lHU0FzWThNM0NzTU8rVnVvRFRqTFF4YnNGT1dzemh4Um05VHZHZlQ2?= =?utf-8?B?ODduclp6TmZ0SFhieVVFSWtRNDBKSkU1Nit4enF6b3ZpZ3lsVEpFUGt0djNr?= =?utf-8?B?cVA1U2xSaGh2RXF6MlczSWk0ZTZDK3NqWUM3OE9VZEgxNUg5QktJc1JRUjEx?= =?utf-8?B?L1NWRVBVcEREejY3UlpZRjFpM3RML0dOMDVYSS9mYkM5aFhUclBQNGtmTXVB?= =?utf-8?B?WlNEY0tBMVhmVjhML0l6NFBueWwrU0psNEdTRzNVOU5RSmY1bFdtYjQ4aE1u?= =?utf-8?B?a2lac3gySFFZd3BCQ2RheGZHbEdsaGQ0d3ZKeHhSK05CU0JTRDg2Zk0zenRt?= =?utf-8?B?UXZCVGs4YU5LNm9XRFBlRE5FVlJVTXRtcTZLN2Jod0tBNlBmdngxV05hcVNK?= =?utf-8?B?MGxQOWduNkNsbFZCUnY0OHBiV29mOSt1VmE5MEppYzd4ZUQ5M3lNSkgrbWJq?= =?utf-8?B?aGlNemVGcGhHSXlpVTJxV3Ayc1lqZUFSTm4rakdWRXkyK1dkNXN3eURRTVAv?= =?utf-8?B?dHhvOUJZWUh6Z0UzZjhQSHU4cVpSK3MzQXc1YmxWTlFSQ0VNd2wyMjFJbDRu?= =?utf-8?B?ZU9RL1hWVzRxd21sMGZwbDF1VVU2OEE3OUk5b0RGQmd3YkxXRHBQVHRuVURn?= =?utf-8?B?TkZ5YUJCU2FYY3BQWk4zN3hvS0JPWWxaYWUzL0V5WEM2RTlyaXVjRHFjM3Fr?= =?utf-8?B?M08rTW1vejFuanBReHFPby9PSytDdmNlRTNSTXpOVVdMR2NSN0hrYmN5TTgx?= =?utf-8?B?QWMrN2lyckhiOFp5R3RORldtcU1pSkRuRVVzc05WckVHZUdveERXSDlkL1Zz?= =?utf-8?B?QWdyUWFYVlNXUEM5dG9zLytLeUhTYjN0M1MxYXpCaTE5L2s3VGhUOXYyRHZG?= =?utf-8?B?K1lOeUMzR0h0WVdHS0kyMjZ6TzlhZ1dnd0VFMGNHblVDSjR4SUk2RVc4K1h3?= =?utf-8?Q?BJ9lgyi8wq4QkjRa4YNxDFT8d5SX039QrQPcjFK?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: f6c020da-8081-4d40-40d9-08d97109e805 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2021 07:42:41.2107 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: XIW1kEQetet1uchw+/4oTYHGZIf6L3rScpXeQ10DsVPAJn6RtvfJ+7yNgu1P8nbUwSGYBChIulLiIorwWXEJnQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB2959 (please don't cross-post; removing xen-users) On 04.09.2021 17:12, Bhasker C V wrote: > I run xen-4.14.3-pre from debian > > I created 6 vfs for my igb card > 06:00.0 Ethernet controller: Intel Corporation I350 Gigabit Network > Connection (rev 01) > I got these > 07:10.0 Ethernet controller: Intel Corporation I350 Ethernet Controller > Virtual Function (rev 01) > 07:10.1 Ethernet controller: Intel Corporation I350 Ethernet Controller > Virtual Function (rev 01) > 07:10.4 Ethernet controller: Intel Corporation I350 Ethernet Controller > Virtual Function (rev 01) > 07:10.5 Ethernet controller: Intel Corporation I350 Ethernet Controller > Virtual Function (rev 01) > 07:11.0 Ethernet controller: Intel Corporation I350 Ethernet Controller > Virtual Function (rev 01) > 07:11.1 Ethernet controller: Intel Corporation I350 Ethernet Controller > Virtual Function (rev 01) > > bcv@bcvibmb1:~$ sudo xl pci-assignable-list > 0000:07:10.1 > > However the guest is not able to see the link up. > bcv@utils:~$ sudo ethtool enp0s0f1 > > > > Settings for enp0s0f1: > > Supported ports: [ ] > ... > > Link detected: no > > I see this error on the guest > > [ 6.134890] igbvf 0000:00:00.1: Xen PCI mapped GSI0 to IRQ19 > > [ 6.149577] igbvf 0000:00:00.1: PF still in reset state. Is the PF > interface up? > > [ 6.149595] igbvf 0000:00:00.1: Assigning random MAC address. > > > > [ 6.151552] igbvf 0000:00:00.1: PF still resetting > > [ 6.153807] igbvf 0000:00:00.1: Intel(R) I350 Virtual Function > > [ 6.153822] igbvf 0000:00:00.1: Address: 32:91:70:c5:62:bd All of this is kernel functionality, which driver maintainers may be in a better position to help with. At the first glance the Xen version in use may be of no relevance here. > and thiis on the host: > [ 390.776779] xen-blkback: backend/vbd/3/51713: using 1 queues, protocol 1 > (x86_64-abi) persistent grants > > > [ 395.849996] pciback 0000:07:10.1: xen-pciback: Driver tried to write to > a read-only configuration space field at offset 0x1d6, size 2. This may be > harmless, but if you have problems with your device: > > [ 395.849996] 1) see permissive attribute in sysfs > > > > [ 395.849996] 2) report problems to the xen-devel mailing list along with > details of your device obtained from lspci. > > > [ 396.103595] pciback 0000:07:10.1: enabling device (0000 -> 0002) > > > > > However if I pass through 07:10.4 it works fine. The host still reports > this above error but all works well in the guest. "This above error" being which one? "PF still resetting" or "Driver tried to write ..."? > Please could someone help ? I have been using KVM these years and just > moved to xen and hence new to xen. Well, if one of the VFs works and the other doesn't, then a close comparison of the various logs (hypervisor, kernels, tool stack) may already provide an indication of the problem. Above you only supply individual lines from logs, which isn't going to be sufficient to derive anything. Jan From xen-devel-bounces@lists.xenproject.org Mon Sep 06 07:52:34 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Sep 2021 07:52:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.179407.325664 (Exim 4.92) (envelope-from ) id 1mN9QX-0003FS-UQ; Mon, 06 Sep 2021 07:52:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 179407.325664; Mon, 06 Sep 2021 07:52:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mN9QX-0003FL-QX; Mon, 06 Sep 2021 07:52:25 +0000 Received: by outflank-mailman (input) for mailman id 179407; Mon, 06 Sep 2021 07:52:24 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mN9QW-0003FF-HI for xen-devel@lists.xenproject.org; Mon, 06 Sep 2021 07:52:24 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id b5d175d5-203b-4096-b9e9-d4f224e47cbd; Mon, 06 Sep 2021 07:52:23 +0000 (UTC) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04lp2058.outbound.protection.outlook.com [104.47.13.58]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-3-J4sBdIofMLyCw3Xre7vYZA-1; Mon, 06 Sep 2021 09:52:21 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR0401MB2607.eurprd04.prod.outlook.com (2603:10a6:800:58::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.17; Mon, 6 Sep 2021 07:52:19 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4478.025; Mon, 6 Sep 2021 07:52:19 +0000 Received: from [10.156.60.236] (37.24.206.209) by AM0PR01CA0169.eurprd01.prod.exchangelabs.com (2603:10a6:208:aa::38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.17 via Frontend Transport; Mon, 6 Sep 2021 07:52:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b5d175d5-203b-4096-b9e9-d4f224e47cbd DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1630914742; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7qfYe0MVEmrcUZ1IysB0i36pFwGoNwanHSmnwKiOeh0=; b=ioffoHOUvvwp7B6rWTm0TLucXCpthR08D+Luu53cmOQQEghIVbcAvfHcB8YyrjI1O3PscG IMdhKAkM35XtQpgYNUzrhQjx5vvikol7OyjjGiw1L3/dXnZl1ktYnPXCfFBGcr3UkQ75yr OE+LCUAVhkgwg97sWs6uyPc3Y3ltYdI= X-MC-Unique: J4sBdIofMLyCw3Xre7vYZA-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kSBZKt7WpvrLaPsX36LVFe2MBkhIPHObVSsG0VaaX/FzPh5DQpIB1A0vhKuxLCqML/unMl/CHGi+LnJsPamYyS59nmUwMFM+kcz8efuuHI3vvrvMr3KVzciQEUg8bWjZPXU+kc1tmfrdmGLAGxnsSwZkUv1UcBali2jeFcv/KmEyRIR433GzfetW15VM/dRqngA1p42dzvDZkIPUAXbUKUX4Kxsh2mYA5qCU8HWs38KE8uhcKIO6o+/ByA1PCE7zROgggoItfoqcfs+R8zQMjB3ooY3glRxTmv8pqXzEpKOel8XQpmcejF6ZziwIUtMq4RnzeDE+8IRnCQ6fU1+O4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=7qfYe0MVEmrcUZ1IysB0i36pFwGoNwanHSmnwKiOeh0=; b=W3oVsyHyxIPcBbqn8IWX4EDYbv2rWkdUDxI4K/3kHQoCx3+W7BPrmy2knvRE1hBjShoQxNx8LxrrFEvV+XJwx6hGEksm/ucHkqfSVRW9wgk2/0x469lOvJBdt49wzMkj8vfrc4M1ir5ylLJ7DlWeVkbtr0HlScdZ9LwJTg/k+C3CFVK3bJXBzsGlc7iaugicQUh3OAtVdZ8pgYmJQERLVJjq9I0dWNE/RF6EDUI0pG+OSlotIHg5vvyzsDsFSqD+VEifX0+R9+36HY/4Vg2ryAQHP/hrpA0fmoNcvnk6Q4RLp2ZZfXk4AZRGT93WV0rceyqXbH9CLRlIxUAauE1C7A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com; Subject: Re: HVM/PVH Ballon crash To: Elliott Mitchell References: Cc: xen-devel@lists.xenproject.org From: Jan Beulich Message-ID: <84d9137e-a268-c3d8-57d2-76fb596e00d3@suse.com> Date: Mon, 6 Sep 2021 09:52:17 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM0PR01CA0169.eurprd01.prod.exchangelabs.com (2603:10a6:208:aa::38) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 330106e2-2405-4fb5-be32-08d9710b4083 X-MS-TrafficTypeDiagnostic: VI1PR0401MB2607: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CUF4WvX9MiLywgBKoR4NXK1izs8+nkW6MmnYvksLWK6v8QH3QfW+nmklUo7uM7qJpEelGSt4m1VI+btS7WmgoDIqmASuCXYiRhz57t+kRImiuUVGbJmng3OeuhJyf17ZjUo6dDvWVoFfSPxido2xxuutLmwN8x1iosxzpyuBS8uZshmHYgSPeGAQPO9fww/whGmGOEcQfDZhOLmj8GAOkkZAYmjKkDxDLNuPUwDq5Jt5j7J90WuX+6I+qWA5oNcG18l4riPkn6emsLi4ReT5Hq7l9Sw5RvGYtlT3+oCS/5ru9P7ITvNM/+yIR2x4ja1sXxDwKeG9T25MH45kf6H/m37s0fN5IkNgcqSzYshHLmFT2R+q5LqPVGregy+mCpYTM7w9o7Er05JtfI8NJ/VkoHw3LeT6OGzvR0CkgmgrT8hZkueb56VbvvvvGYkmQCcjf8HMzo/ko6tVSqbzS+3+xeLQBNsXWMdJyg7IwHXhZWtRLmxbK0D58PkXht6qJvUbkKgyuhv5JHBWCasS4JS/6Sg6lZITiK3hGAjx6jzNUQqnLqxslu+u3dMq5RFqkcRZmtkN2OQDJLBM6a+PDVXyJjVMJ9BX+0jXFmOW7uVI4UKuCBVF34xheBRqkGqoHduqPIm64io544anmmYDC7fayNDHeWZA1xTomx0T5J9qekjdoJWUm6abBpg4c4oUdSOFn8URGxQ2LAxs7SH6ydGN6A== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(346002)(396003)(39860400002)(136003)(376002)(366004)(478600001)(36756003)(31696002)(66476007)(8936002)(66946007)(2616005)(956004)(2906002)(3480700007)(31686004)(53546011)(66556008)(316002)(86362001)(6486002)(16576012)(4326008)(5660300002)(38100700002)(26005)(8676002)(83380400001)(186003)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QTd5eit1Sm9XU0FQTmdHVEdpb0dVV1pHanBaek5HdkUzRDJzUVhyZ2piS3ds?= =?utf-8?B?UytoRDVBbExHUWM5ak9YRUNSYUhNTHU0SUpUa3hKMFlrSXZ1c1lrWXRhRWlV?= =?utf-8?B?S0tNQzczMlBaOXJDUERPK0lISkx3WGxuVFhWUkZHa3luUlB5UFY1eGNYMHF6?= =?utf-8?B?RjZBNlc5ZUZyQ0c4MUsrS09aL2NndyttdWtvOUNYMitOSFNjMEtqNVVHQVVS?= =?utf-8?B?aElHQ2xIU1hMajhtajR5dFIyUEFLYytXeEY1cGI3OHVtRTZwd0xZUGRHYWI3?= =?utf-8?B?WTNQdTJSQ243WHNaWlFSdUVJSUdpa0dab3VqYXdWUGFmcVcrUmZ4WkswT2RR?= =?utf-8?B?UGMrbmdrSnRBMGR1L045SjE5RGxsOHRyV1F3VmVBYStVWjNBZGdiVk8rak9k?= =?utf-8?B?Q3d6eFg3L2wwZkY0bkN1ZkNGaFMvU2RpRVRNa08yMFFXTzIzYzFZdVREdENw?= =?utf-8?B?Sk5BLzNYVUtqREFialQranhoNkFvaUYvZnIzY05DY2ExUVFsZGVlRjhva3hh?= =?utf-8?B?K1lMTlh1dVpCaG9McFQrWDZnWHoxOEVtV1hZUjhEN0ZRTFo0cFJJWHJzUzgy?= =?utf-8?B?QUpRRXB6bnMyNjVnVHVrdWx1WFkweWtmY1R1QXVxTHFBeTNabjFVQVlJRGU3?= =?utf-8?B?UXV1LzRwUzIxOUplWjRtakZWRHIzeTVkWHg5K2dNMS92N3ZHcVErQTA5azRO?= =?utf-8?B?aU1UMnhvRlVsN0Z1Q2UzL2ZEVmZuZGovdU1MdW9qYXZOZFFsWkdIOExVNnNG?= =?utf-8?B?SW5JUDBYUjRCZkVsT1V5UWg3NlNDLzFhN2QxbUZ5OXBKUy9pazBqcTNGWUJ5?= =?utf-8?B?bDBRMDd3T3dwZFJNeTFGdGlVOVpzSGxzcXZIaCtFclNuYjd5eURUT0tSWHZx?= =?utf-8?B?cStXbmdBZ3MzbzRzRkttZTBOcGpaRGNLSXlTL0pHYzRnMXgwQVFQRXJYYlF3?= =?utf-8?B?R2grOWhRaDFQdU1zbGJIbXBjY0E1QmEwc0daSk45VGR5WktRbEpkRE94WDhJ?= =?utf-8?B?K3lIaWFsbmt2djE1Z2I3UHhEa0l0T05BUGxucUcwMWcwZnpUMUQ1UGRualZS?= =?utf-8?B?RHVYcVlldWRDMWJzYWhuSEpxTE81QVJDVmptMmQ2MmYwZTRWOFgrNXBUYXUv?= =?utf-8?B?OGlmK1pFa25KbDhVbE1kMlZlTmRldCtHMjgxSEhQbnVoM1dRaEdORS93eVdm?= =?utf-8?B?MGdYdThiUWpzRittcE5xVVQzTGdWbDV3T2IzRjVkYjRrT0ZVb0R0QlZZRWho?= =?utf-8?B?L1dqeWpxQ01zZHR4VHZGSDJhUW13aVRubVFmRnhpTVVCN0l3NUdGaUJGTUNX?= =?utf-8?B?bkozSWw5NXUzMkY5L1BoZk4xWk5zNnRFZ1ZPUm5YanpFRmdjc1dpTUgwRTZH?= =?utf-8?B?Rjl3WFNaZWNkZXNzM3p5c0N4SFQrZlY1OUp4QTJ1dmxnRFBxS3ZXSDZUSG1j?= =?utf-8?B?QkZPL1NqZXduMHdRVFhYTnlVMUI5aGhwS2FJcDMvNW5wRmJJK05kQzZrdDNF?= =?utf-8?B?akZwQk53RkVXRVc2aHExQ3Rtd2F2VlhxSXQ4WE15NURSNUxHTTNML0xERVgw?= =?utf-8?B?SVMzK2Z2NUUrWHVnMHgzT0wxaTdiaEJSQy8wWC95T1llWnhTZjI0c0NrRm5O?= =?utf-8?B?NmdkWmdCb015OXB3eDJIR1JGZlhXZkFKcnlvbmNoQkFwSmtTejdybWhnMXhH?= =?utf-8?B?MnYzWGF4TU02N1FjdjdWK2VtZjNJR3UxWWJzcXMva2o2U2hUUzZpOVNDNzFT?= =?utf-8?Q?16F+saPMZBsHHN8/V4I7ccIsgzL2RIzFt5yTT1R?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 330106e2-2405-4fb5-be32-08d9710b4083 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2021 07:52:19.2669 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: N4+tzR+CZWYFj46pFiCEM0ItKO4MTF29fJGWUhhcFF2yremcsivMnXVV5zWjErPUPd1goG22F/WxEmx6EtUhMA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2607 On 06.09.2021 00:10, Elliott Mitchell wrote: > I brought this up a while back, but it still appears to be present and > the latest observations appear rather serious. > > I'm unsure of the entire set of conditions for reproduction. > > Domain 0 on this machine is PV (I think the BIOS enables the IOMMU, but > this is an older AMD IOMMU). > > This has been confirmed with Xen 4.11 and Xen 4.14. This includes > Debian's patches, but those are mostly backports or environment > adjustments. > > Domain 0 is presently using a 4.19 kernel. > > The trigger is creating a HVM or PVH domain where memory does not equal > maxmem. I take it you refer to "[PATCH] x86/pod: Do not fragment PoD memory allocations" submitted very early this year? There you said the issue was with a guest's maxmem exceeding host memory size. Here you seem to be talking of PoD in its normal form of use. Personally I uses this all the time (unless enabling PCI pass-through for a guest, for being incompatible). I've not observed any badness as severe as you've described. > New observations: > > I discovered this occurs with PVH domains in addition to HVM ones. > > I got PVH GRUB operational. PVH GRUB appeared at to operate normally > and not trigger the crash/panic. > > The crash/panic occurred some number of seconds after the Linux kernel > was loaded. > > > Mitigation by not using ballooning with HVM/PVH is workable, but this is > quite a large mine in the configuration. > > I'm wondering if perhaps it is actually the Linux kernel in Domain 0 > which is panicing. > > The crash/panic occurring AFTER the main kernel loads suggests some > action by the user domain is doing is the actual trigger of the > crash/panic. All of this is pretty vague: If you don't even know what component it is that crashes / panics, I don't suppose you have any logs. Yet what do you expect us to do without any technical detail? Jan From xen-devel-bounces@lists.xenproject.org Mon Sep 06 07:58:33 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Sep 2021 07:58:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.179415.325674 (Exim 4.92) (envelope-from ) id 1mN9WL-0003vf-K8; Mon, 06 Sep 2021 07:58:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 179415.325674; Mon, 06 Sep 2021 07:58:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mN9WL-0003vY-HC; Mon, 06 Sep 2021 07:58:25 +0000 Received: by outflank-mailman (input) for mailman id 179415; Mon, 06 Sep 2021 07:58:24 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mN9WK-0003vS-7d for xen-devel@lists.xenproject.org; Mon, 06 Sep 2021 07:58:24 +0000 Received: from smtp-out2.suse.de (unknown [195.135.220.29]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 28db596b-d2d7-4fdb-a851-1798376585ed; Mon, 06 Sep 2021 07:58:23 +0000 (UTC) Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 168C920090; Mon, 6 Sep 2021 07:58:22 +0000 (UTC) Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap1.suse-dmz.suse.de (Postfix) with ESMTPS id BD3A31332A; Mon, 6 Sep 2021 07:58:21 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap1.suse-dmz.suse.de with ESMTPSA id vXixLB3KNWElZQAAGKfGzw (envelope-from ); Mon, 06 Sep 2021 07:58:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 28db596b-d2d7-4fdb-a851-1798376585ed DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1630915102; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1Za9VHhRvpXITUKCSZL629zvN/BxLscJdKXjSFiZ2+g=; b=SiROr0rslCXdR3AGf61xOFA29IRHYyXipM6FrpCmTeFR6QzuOwuwIj9O6tGyi4w7IdgpQY rQUKoV6RQUh034xIePoQ9aFy1OPw1hvpPdV677UUuE1v9rvG9YHepYgMnzSgcJQTs7YNN8 Hx2rR3JWdu7uFe9jp0mFaE9gyHnmsgs= Subject: Re: [PATCH] x86: xen: platform-pci-unplug: use pr_err() and pr_warn() instead of raw printk() To: zhaoxiao , tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, x86@kernel.org Cc: hpa@zytor.com, xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, boris.ostrovsky@oracle.com, sstabellini@kernel.org References: <20210906075516.15066-1-long870912@gmail.com> From: Juergen Gross Message-ID: Date: Mon, 6 Sep 2021 09:58:21 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210906075516.15066-1-long870912@gmail.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="0NiT60Arq9oUmIaGGHFc8tMs0HEluEKwq" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --0NiT60Arq9oUmIaGGHFc8tMs0HEluEKwq Content-Type: multipart/mixed; boundary="OnXWnoypXks5k2gkdaUdrAwQMOYsNyAmr"; protected-headers="v1" From: Juergen Gross To: zhaoxiao , tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, x86@kernel.org Cc: hpa@zytor.com, xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, boris.ostrovsky@oracle.com, sstabellini@kernel.org Message-ID: Subject: Re: [PATCH] x86: xen: platform-pci-unplug: use pr_err() and pr_warn() instead of raw printk() References: <20210906075516.15066-1-long870912@gmail.com> In-Reply-To: <20210906075516.15066-1-long870912@gmail.com> --OnXWnoypXks5k2gkdaUdrAwQMOYsNyAmr Content-Type: multipart/mixed; boundary="------------6D93742B032AE25FF0D27A00" Content-Language: en-US This is a multi-part message in MIME format. --------------6D93742B032AE25FF0D27A00 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 06.09.21 09:55, zhaoxiao wrote: > Since we have the nice helpers pr_err() and pr_warn(), use them instead= > of raw printk(). >=20 > Signed-off-by: zhaoxiao Any reason you are sending this patch again? It has already been applied through the Xen tree. Juergen --------------6D93742B032AE25FF0D27A00 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Transfer-Encoding: quoted-printable Content-Description: OpenPGP public key Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy= cWx w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O= f8Z d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y= 9bf IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq= G7/ 377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR= 3Jv c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA= QIe AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT= hpw dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0= MbD 1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv= oPH Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v= 5QL +qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ= 2Vu IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC= QoL BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr= Wf0 teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC= /nu AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh= ITT d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm= XBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz= 80h SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC= AcD AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn= FOX gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1= jnD kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0= N51 N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l= otu fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1= tqS EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA= hsD BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3= g3O ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5= dM7 wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5= D+j LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm= V2x AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N= Eaw QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW= nHI s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR= wgn BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV= bVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk= pEd IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA= QAB wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw= Tbe 8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1= vJz Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8= VGi wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW= svi uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX= zXs ZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------6D93742B032AE25FF0D27A00-- --OnXWnoypXks5k2gkdaUdrAwQMOYsNyAmr-- --0NiT60Arq9oUmIaGGHFc8tMs0HEluEKwq Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmE1yh0FAwAAAAAACgkQsN6d1ii/Ey98 Lwf/QVhNeKbTqGC3/WByP2vXlbyE9+y9YugswvSoksaY4qBNYUsKbey1CU/ZTeZ1rKmzTzKUoh2I Rq/atOQS41km+txxg1iOdLcKotJ8+HSu1oz72cdi5SYXxPDV6PUBtyIzgcgOAmmyn5fImCMZgLYs dMSR6W46ffQ4KEE/Es7shi/MgADXR2H5axMyNaQqqdwvfIxrcLV2RLiEnZIYGHXyvO8WvFk8jZo4 xAyAxcOZ+/RNLl+4XtWYX8VpcHRVawzjDIZAP4o12ei77G2mKXJFhlcLfNpmIb6osbrEXvInK/pR ZIVjJAonB1PpZjTRq0dPqxLAcfa8jI+O1jLoJ/4O5g== =8ISr -----END PGP SIGNATURE----- --0NiT60Arq9oUmIaGGHFc8tMs0HEluEKwq-- From xen-devel-bounces@lists.xenproject.org Mon Sep 06 07:59:15 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Sep 2021 07:59:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.179421.325686 (Exim 4.92) (envelope-from ) id 1mN9X8-0004U7-VK; Mon, 06 Sep 2021 07:59:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 179421.325686; Mon, 06 Sep 2021 07:59:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mN9X8-0004U0-Rd; Mon, 06 Sep 2021 07:59:14 +0000 Received: by outflank-mailman (input) for mailman id 179421; Mon, 06 Sep 2021 07:59:14 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mN9X8-0004Ts-8R for xen-devel@lists.xenproject.org; Mon, 06 Sep 2021 07:59:14 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (unknown [40.107.20.67]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 02416458-7fb2-4eb4-adef-abbbdb4859e6; Mon, 06 Sep 2021 07:59:12 +0000 (UTC) Received: from AM6PR10CA0084.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:209:8c::25) by AM6PR08MB4294.eurprd08.prod.outlook.com (2603:10a6:20b:bd::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.24; Mon, 6 Sep 2021 07:59:10 +0000 Received: from VE1EUR03FT011.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:8c:cafe::6a) by AM6PR10CA0084.outlook.office365.com (2603:10a6:209:8c::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.17 via Frontend Transport; Mon, 6 Sep 2021 07:59:10 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT011.mail.protection.outlook.com (10.152.18.134) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Mon, 6 Sep 2021 07:59:10 +0000 Received: ("Tessian outbound 19a632698c93:v103"); Mon, 06 Sep 2021 07:59:09 +0000 Received: from bf2941014b77.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id EDCB66D2-3E83-4673-962B-47BE55C9FD1B.1; Mon, 06 Sep 2021 07:59:02 +0000 Received: from FRA01-PR2-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id bf2941014b77.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 06 Sep 2021 07:59:02 +0000 Received: from PAXPR08MB6446.eurprd08.prod.outlook.com (2603:10a6:102:12d::10) by PR2PR08MB4874.eurprd08.prod.outlook.com (2603:10a6:101:1d::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19; Mon, 6 Sep 2021 07:59:01 +0000 Received: from PAXPR08MB6446.eurprd08.prod.outlook.com ([fe80::c029:ed0:82e7:3c2f]) by PAXPR08MB6446.eurprd08.prod.outlook.com ([fe80::c029:ed0:82e7:3c2f%6]) with mapi id 15.20.4478.025; Mon, 6 Sep 2021 07:59:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 02416458-7fb2-4eb4-adef-abbbdb4859e6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wqT3OTunmQEuYn/hPnbl+2ZS4xB6pnzJeMCS5J/gFo0=; b=1CigprJlfSjfO99h6CWRiRHI1AL4fV+efrm2/TjS5mCFgzwplQb4yVGvY+CTYFJ1JJZfruCkcigPDIHmurzsL/iYJzioTas0ASTs9q7wPCLIXimt2lPFC2h8hf8EFALoYhVEiKftUDL6u77cximqotCYRsqHKDkBie6uJHTbN4M= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: cbf86ecf56087163 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kOaNrl38Xj3PI4AOCqtzL5SsAYpkh8esndWQhkQ2W5ffZNG84QPmVRJjwCLfMaRU9HFkooDrKoqan7XVLQrQZhV55dbM6/wWPbPA+Nc0wCgrzZG9nrQdybJfxGBGZ+3uZ2fUj+fvzBD3tyV8lsud7BDVdHX6QYmt5h3t1ytwDjA1uFh4BXIi+/RZRUkgrlBzMSDrs7/b+ht3Pu0qUVRM2xw/Jv83EfJD1GGNikJtkSjutN5EkGrqSBKdmOHGjJEVCVU5CIdu9NCiTG5TRTdnKMOpy3YRmjkmj7v5bot59Vb5JN0FGiyjjwqwZJng44GtTNDk4qAVEYi8eWjTXpn86A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=wqT3OTunmQEuYn/hPnbl+2ZS4xB6pnzJeMCS5J/gFo0=; b=HsNcM+Eb2ckqiboIeDKnPVu/CB1TgSWGd2KpPkrAFHm3ljb9XD6287WiXFKLnxLaca8bUQUnz4gQYeO5CSYO18GVIt1dl6sVJI9jTvfXSaDQIE+6U9pgywloq6/ctZ/B4UpZ2iDM/kmmfaEwk18C97bvL9UboAGyDC9CYqx+H3t1T04nJkorMzupdmfSvWwUM8nC5uk3Gu0c19THvcLHGeesUjFOsStMZwKBxXxWN+hUqIk0G62uKNvbB7Qph0nWj9/FTXNiS70fzK+KHFmQcDL76FoTCZgcqw1nVuQdwLjHYb5MAUgeH+yKsitlPXjoIR2zju2P7aQ5b6Hr/Q5RZg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wqT3OTunmQEuYn/hPnbl+2ZS4xB6pnzJeMCS5J/gFo0=; b=1CigprJlfSjfO99h6CWRiRHI1AL4fV+efrm2/TjS5mCFgzwplQb4yVGvY+CTYFJ1JJZfruCkcigPDIHmurzsL/iYJzioTas0ASTs9q7wPCLIXimt2lPFC2h8hf8EFALoYhVEiKftUDL6u77cximqotCYRsqHKDkBie6uJHTbN4M= From: Bertrand Marquis To: Stefano Stabellini CC: "xen-devel@lists.xenproject.org" , Julien Grall , Volodymyr Babchuk Subject: Re: [PATCH v3 6/7] xen/arm: Taint Xen on incompatible DCZID values Thread-Topic: [PATCH v3 6/7] xen/arm: Taint Xen on incompatible DCZID values Thread-Index: AQHXmbPyvc9RSYz5OUKBEYoCXmX0t6uS+GGAgAO+T4A= Date: Mon, 6 Sep 2021 07:59:00 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3654.120.0.1.13) Authentication-Results-Original: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=arm.com; x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: b915c3f8-054c-4e7c-cd21-08d9710c3597 x-ms-traffictypediagnostic: PR2PR08MB4874:|AM6PR08MB4294: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:10000;OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 3kXZxKy3Nxd+lLfGRINpjkMOHc74N/vpeTzhNSMzG6leXwfDMaIeSXQQzDyWioFZtk0fFNGuxC2wdDrvlL4/Tje4L9vZd8NORw0EaVN8JbjoK+oXMh2Q3hHxaIjLIt8p390ZDFL3l1PTdm6gt+vmCzzYAZKyVeHEoAthD70xQMCkwosGN3IfcxiIdhh0NwDFekt7vRYc8fttuwr+pmdFRL9A7Axn3nou2E/LogJxNjDsFBl0oUpYAnn7Ew+Bd7igGnWn4CAL4KjXIZ1JdV3SBl9wrTVN1UXe/VO2+WiVRPPntICtAjStrPyNUN1hoEGrPAwfx3xvdVmpIZwgfYZE54UvuhEuSRzC0RJybXrYAyzpPUm1d+CXzgHLYF1lMn4Usbx+fA6XEjZjLYCdaH0gklpcReLM+JnqgCeLIlMECvniD7wyTwG0y3pwZuPvrEqH9Yx+n7YquwlXDfnrFFmKmg/09/zia0YZx+gFc/nTsbN+jqIPbn0HkxX0csj02mDigdh5+lw7Ekz2Y1L35HjnVIRIdvdhXXchB37kmNXLyVhS+I6Dpb/9JkfNSEUiyfSbUow+K1kYWmgTpp6Z+shKvs9dYRQOJgoJBZFgyG/4AJ5hvVhLy+P8LTKPLjwqnkKOJYS60nMH1sk4+WK/qMWsSo9iNBGyQDTKAuvTzJrwtRI6iHU/AMm9bW0ga/rrfoAd5sn8Ed6LydXF+TzbsZS4mLVbbE8omm28/Y/qdaEKNXRLDNH05hOtCeWW1AkAqa4e X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB6446.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(396003)(39850400004)(366004)(346002)(136003)(54906003)(316002)(5660300002)(2906002)(122000001)(2616005)(38070700005)(64756008)(6506007)(66946007)(53546011)(66446008)(6486002)(76116006)(91956017)(83380400001)(8676002)(66556008)(8936002)(66476007)(38100700002)(26005)(6916009)(86362001)(186003)(71200400001)(36756003)(478600001)(33656002)(6512007)(4326008)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR2PR08MB4874 Original-Authentication-Results: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT011.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: d153bbb4-0551-4513-384b-08d9710c3014 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: e7gteVfGcZkygifGTQs7+6Hjnd8+8eU8mK/kGobYyJRsk6hgL7HGUzxpfWhglH6E3jgwfdPULlsd07A3pLUl81hhEe3w9uLojy9B1rACZYg+LzZoBgQZURTN2Scc2Wv6j5DhDmsmoStIroXRbvCQP3wRj44f2O3lhYICYIjuey93nHzC7VGxl+QUOQsmg6p14w4wsxGOUOeMTVy0aRuDlwTD55JVJb2sIi37MlgM9E6P5qi6oyE1lawegdguyKehMaD0sQB5dtorfUGTFvQnUvdx7aw83dMqQRL9S6IgQT766piwInYqgypSWtExWWMMbxYWktbhFFR7ZTpMegi+MJcOT6YZ23tFt4gFvghZgw9/ZmP+/UTaqayBiuXNyTs4f7Cf+ABKXhEnga6A/4DmoOtQ6V7rCnkqYlYKsrGRi2za06F4RFMOERWR5d+gjKWqtE4eqD/NsAq40aKMf2kUQbUsaUz7F6mYFMARnjbbOwkY5zRWUET95dcPtV+vIH9YewpY3OAMfLnfYe0Nox+5y75qroxG1W49xjQF88Z3uQt6Ozly4fcE+gLuXYHTeuHxFWywuztBQscDWURAC3h+0LAcGrp8wyhJ4Jx8ykLsIeiVEIlp1B/mR/LGr+x2PJAVva2ImPEJ2IiKWZ4sw8X3Q0EvoiMy3ewzZbWi5q9za4seYjPtc4ofprm9PhbWof+4ol19QPlyKr3aHQSXLodvKA== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(346002)(39850400004)(136003)(376002)(396003)(46966006)(36840700001)(5660300002)(82310400003)(8936002)(186003)(6512007)(6862004)(26005)(6506007)(83380400001)(107886003)(54906003)(478600001)(8676002)(356005)(81166007)(4326008)(316002)(36756003)(36860700001)(33656002)(336012)(2616005)(6486002)(82740400003)(70586007)(2906002)(47076005)(70206006)(86362001)(53546011);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2021 07:59:10.0910 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b915c3f8-054c-4e7c-cd21-08d9710c3597 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT011.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4294 > On 3 Sep 2021, at 23:49, Stefano Stabellini wrot= e: >=20 > On Wed, 25 Aug 2021, Bertrand Marquis wrote: >> Use arm64 cpu feature sanitization to TAIN Xen if different DCZID values > ^ TAINT >=20 >=20 >> are found (ftr_dczid is using only STRICT method). >> In this case actual memory being cleaned by DC ZVA operations would be >> different depending on the cores which could make a guest zeroing too >> much or too little memory if it is merged between CPUs. >>=20 >> We could, on processor supporting it, trap access to DCZID_EL0 register > ^ processors Could those typos be fixed during commit ? >=20 >> using HFGRTR_EL2 register but this would not solve the case where a >> process is being migrated during a copy or if it cached the value of the >> register. >>=20 >> Signed-off-by: Bertrand Marquis >> --- >> Change in v3: none >> Change in v2: Patch introduced in v2 >> --- >> xen/arch/arm/arm64/cpufeature.c | 14 +++++++++++--- >> xen/arch/arm/cpufeature.c | 2 ++ >> xen/include/asm-arm/cpufeature.h | 8 ++++++++ >> 3 files changed, 21 insertions(+), 3 deletions(-) >>=20 >> diff --git a/xen/arch/arm/arm64/cpufeature.c b/xen/arch/arm/arm64/cpufea= ture.c >> index 61f629ebaa..b1936ef1d6 100644 >> --- a/xen/arch/arm/arm64/cpufeature.c >> +++ b/xen/arch/arm/arm64/cpufeature.c >> @@ -329,14 +329,11 @@ static const struct arm64_ftr_bits ftr_mvfr2[] =3D= { >> ARM64_FTR_END, >> }; >>=20 >> -#if 0 >> -/* TODO: handle this when sanitizing cache related registers */ >> static const struct arm64_ftr_bits ftr_dczid[] =3D { >> ARM64_FTR_BITS(FTR_VISIBLE, FTR_STRICT, FTR_EXACT, DCZID_DZP_SHIFT, 1, = 1), >> ARM64_FTR_BITS(FTR_VISIBLE, FTR_STRICT, FTR_LOWER_SAFE, DCZID_BS_SHIFT,= 4, 0), >> ARM64_FTR_END, >> }; >> -#endif >>=20 >> static const struct arm64_ftr_bits ftr_id_isar0[] =3D { >> ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_ISAR0_DIVIDE_= SHIFT, 4, 0), >> @@ -592,6 +589,17 @@ void update_system_features(const struct cpuinfo_ar= m *new) >>=20 >> SANITIZE_ID_REG(zfr64, 0, aa64zfr0); >>=20 >> + /* >> + * Comment from Linux: >=20 > I don't know if I would keep or remove "Comment from Linux" I added that because the comment itself does not really apply to Xen. I could have rephrased the comment/ Anyway I have no objection to remove that statement. Do I need to send a v2 for that ? Cheers Bertrand >=20 > In any case: >=20 > Reviewed-by: Stefano Stabellini >=20 >=20 > Also I gave a quick test of the series on a ZCU102 and it worked fine. >=20 >=20 >> + * Userspace may perform DC ZVA instructions. Mismatched block sizes >> + * could result in too much or too little memory being zeroed if a >> + * process is preempted and migrated between CPUs. >> + * >> + * ftr_dczid is using STRICT comparison so we will taint Xen if differ= ent >> + * values are found. >> + */ >> + SANITIZE_REG(dczid, 0, dczid); >> + >> if ( cpu_feature64_has_el0_32(&system_cpuinfo) ) >> { >> SANITIZE_ID_REG(pfr32, 0, pfr0); >> diff --git a/xen/arch/arm/cpufeature.c b/xen/arch/arm/cpufeature.c >> index f600a611bd..113f20f601 100644 >> --- a/xen/arch/arm/cpufeature.c >> +++ b/xen/arch/arm/cpufeature.c >> @@ -125,6 +125,8 @@ void identify_cpu(struct cpuinfo_arm *c) >>=20 >> c->zfr64.bits[0] =3D READ_SYSREG(ID_AA64ZFR0_EL1); >>=20 >> + c->dczid.bits[0] =3D READ_SYSREG(DCZID_EL0); >> + >> aarch32_el0 =3D cpu_feature64_has_el0_32(c); >> #endif >>=20 >> diff --git a/xen/include/asm-arm/cpufeature.h b/xen/include/asm-arm/cpuf= eature.h >> index 52cb3133e0..5219fd3bab 100644 >> --- a/xen/include/asm-arm/cpufeature.h >> +++ b/xen/include/asm-arm/cpufeature.h >> @@ -259,6 +259,14 @@ struct cpuinfo_arm { >> register_t bits[1]; >> } zfr64; >>=20 >> + /* >> + * DCZID is only used to check for incoherent values between cores >> + * and taint Xen in this case >> + */ >> + struct { >> + register_t bits[1]; >> + } dczid; >> + >> #endif >>=20 >> /* >> --=20 >> 2.17.1 From xen-devel-bounces@lists.xenproject.org Mon Sep 06 08:00:40 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Sep 2021 08:00:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.179413.325696 (Exim 4.92) (envelope-from ) id 1mN9YV-0006Sj-Pv; Mon, 06 Sep 2021 08:00:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 179413.325696; Mon, 06 Sep 2021 08:00:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mN9YV-0006Sc-MJ; Mon, 06 Sep 2021 08:00:39 +0000 Received: by outflank-mailman (input) for mailman id 179413; Mon, 06 Sep 2021 07:55:25 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mN9TR-0003rK-3Z for xen-devel@lists.xenproject.org; Mon, 06 Sep 2021 07:55:25 +0000 Received: from mail-pj1-x102b.google.com (unknown [2607:f8b0:4864:20::102b]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 038a7c4b-e7d3-4c03-98ac-9450a760c7b3; Mon, 06 Sep 2021 07:55:24 +0000 (UTC) Received: by mail-pj1-x102b.google.com with SMTP id mj9-20020a17090b368900b001965618d019so3770772pjb.4 for ; Mon, 06 Sep 2021 00:55:24 -0700 (PDT) Received: from localhost.localdomain ([111.207.172.18]) by smtp.gmail.com with ESMTPSA id u10sm6789616pfn.147.2021.09.06.00.55.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Sep 2021 00:55:22 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 038a7c4b-e7d3-4c03-98ac-9450a760c7b3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=2Xf56OLSp+hppzWvWhEGSXjWhxDg/ErT9f349mtnYmE=; b=Tj/b5umNNUQO9OTj3KVUsNndVD9R/+79WMav7vc/xEFnF8t6aarL8lMZq2aqHDGjCK ccCjcuxmO+xSG+V1DpEK/wSnmGUtxvRS7In/KdYAdecRoFxbTVPjHkMJhX1og+8YJtaC OLziIHDZfUChb6k7TVrMezl5ZwtSGzqPzoYTQg4s2nYvNQyXISHO0HeOxBs6f8ad4BLt zQIqvCluOoylVSb2kc/zCJtLB4aF9PnF1gOhDpZ+nCqm2OsEIGsvyInV7GyNTUgoO+X1 h1701OZ+VbZSUDUHA7PgUN50uYWh65fuh9owuw2BMzW/e2BF0BOAevtd8BEoSCpMPMaW f9mA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=2Xf56OLSp+hppzWvWhEGSXjWhxDg/ErT9f349mtnYmE=; b=q+YEqNrje2pq+4BM0nsVB3W8OnKZux099mFCHWIrVmglO7mDvJNJBolSn8dVIMy0ME 41RdbsdOpCW77n0/MQH9Um5qXCQ+gyghn/FxnMVV9EK/mdknDq8DW6jEiIHRtZdauEq4 y3ws8SDyENJnCIGI79SLtLLZD19lf8//M+NJej8Er7/9jL7QrPxCyRJK6xrPuHJ94tC1 2tO7bnWofFQkWb7eMtgW9UXsWfg47SIIJNC1J1t1gc2UAsku37LIz9y/YyHSQO9gO46E BG1pq+SdZOmykjjeCcaKPL2TO8UYuPZG/ue6W/gxBqi01bbiDFk6kouBFJIKB3yQzmO5 JZSw== X-Gm-Message-State: AOAM530Z9oTg09pKxbVCiaL3s1GZzqEAL1OmpIRyWBj9Vp/ZuX6rPJOZ P8HZgRyIf/GL0RaxGze3jPg= X-Google-Smtp-Source: ABdhPJxd0pw9THgbbgqH1OA2JXyGSDCt9tbjRnSLlddXY9HZasP9LDEct/XwtdvVy+oXt3MppnsVUg== X-Received: by 2002:a17:902:a503:b029:12b:2429:385e with SMTP id s3-20020a170902a503b029012b2429385emr9853168plq.64.1630914923382; Mon, 06 Sep 2021 00:55:23 -0700 (PDT) From: zhaoxiao To: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, x86@kernel.org Cc: hpa@zytor.com, xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, boris.ostrovsky@oracle.com, jgross@suse.com, sstabellini@kernel.org, zhaoxiao Subject: [PATCH] x86: xen: platform-pci-unplug: use pr_err() and pr_warn() instead of raw printk() Date: Mon, 6 Sep 2021 15:55:16 +0800 Message-Id: <20210906075516.15066-1-long870912@gmail.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Since we have the nice helpers pr_err() and pr_warn(), use them instead of raw printk(). Signed-off-by: zhaoxiao --- arch/x86/xen/platform-pci-unplug.c | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/arch/x86/xen/platform-pci-unplug.c b/arch/x86/xen/platform-pci-unplug.c index 96d7f7d39cb9..6586eaf59c00 100644 --- a/arch/x86/xen/platform-pci-unplug.c +++ b/arch/x86/xen/platform-pci-unplug.c @@ -19,6 +19,8 @@ #define XEN_PLATFORM_ERR_PROTOCOL -2 #define XEN_PLATFORM_ERR_BLACKLIST -3 +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt + /* store the value of xen_emul_unplug after the unplug is done */ static int xen_platform_pci_unplug; static int xen_emul_unplug; @@ -30,13 +32,13 @@ static int check_platform_magic(void) magic = inw(XEN_IOPORT_MAGIC); if (magic != XEN_IOPORT_MAGIC_VAL) { - printk(KERN_ERR "Xen Platform PCI: unrecognised magic value\n"); + pr_err("Xen Platform PCI: unrecognised magic value\n"); return XEN_PLATFORM_ERR_MAGIC; } protocol = inb(XEN_IOPORT_PROTOVER); - printk(KERN_DEBUG "Xen Platform PCI: I/O protocol version %d\n", + pr_debug("Xen Platform PCI: I/O protocol version %d\n", protocol); switch (protocol) { @@ -44,12 +46,12 @@ static int check_platform_magic(void) outw(XEN_IOPORT_LINUX_PRODNUM, XEN_IOPORT_PRODNUM); outl(XEN_IOPORT_LINUX_DRVVER, XEN_IOPORT_DRVVER); if (inw(XEN_IOPORT_MAGIC) != XEN_IOPORT_MAGIC_VAL) { - printk(KERN_ERR "Xen Platform: blacklisted by host\n"); + pr_err("Xen Platform: blacklisted by host\n"); return XEN_PLATFORM_ERR_BLACKLIST; } break; default: - printk(KERN_WARNING "Xen Platform PCI: unknown I/O protocol version\n"); + pr_warn("Xen Platform PCI: unknown I/O protocol version\n"); return XEN_PLATFORM_ERR_PROTOCOL; } @@ -155,12 +157,12 @@ void xen_unplug_emulated_devices(void) * been compiled for this kernel (modules or built-in are both OK). */ if (!xen_emul_unplug) { if (xen_must_unplug_nics()) { - printk(KERN_INFO "Netfront and the Xen platform PCI driver have " + pr_info("Netfront and the Xen platform PCI driver have " "been compiled for this kernel: unplug emulated NICs.\n"); xen_emul_unplug |= XEN_UNPLUG_ALL_NICS; } if (xen_must_unplug_disks()) { - printk(KERN_INFO "Blkfront and the Xen platform PCI driver have " + pr_info("Blkfront and the Xen platform PCI driver have " "been compiled for this kernel: unplug emulated disks.\n" "You might have to change the root device\n" "from /dev/hd[a-d] to /dev/xvd[a-d]\n" @@ -200,7 +202,7 @@ static int __init parse_xen_emul_unplug(char *arg) else if (!strncmp(p, "never", l)) xen_emul_unplug |= XEN_UNPLUG_NEVER; else - printk(KERN_WARNING "unrecognised option '%s' " + pr_warn("unrecognised option '%s' " "in parameter 'xen_emul_unplug'\n", p); } return 0; -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Mon Sep 06 08:11:52 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Sep 2021 08:11:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.179443.325708 (Exim 4.92) (envelope-from ) id 1mN9jG-0008KG-Qy; Mon, 06 Sep 2021 08:11:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 179443.325708; Mon, 06 Sep 2021 08:11:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mN9jG-0008K9-N8; Mon, 06 Sep 2021 08:11:46 +0000 Received: by outflank-mailman (input) for mailman id 179443; Mon, 06 Sep 2021 08:11:45 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mN9jF-0008K3-Lj for xen-devel@lists.xenproject.org; Mon, 06 Sep 2021 08:11:45 +0000 Received: from mail-ot1-x329.google.com (unknown [2607:f8b0:4864:20::329]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 1060a139-3710-4982-bfd4-ad1603b2a747; Mon, 06 Sep 2021 08:11:44 +0000 (UTC) Received: by mail-ot1-x329.google.com with SMTP id i8-20020a056830402800b0051afc3e373aso7884094ots.5 for ; Mon, 06 Sep 2021 01:11:44 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1060a139-3710-4982-bfd4-ad1603b2a747 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Jqw0MwknMj1RijM4alevMH+POuK2y8El0iNuvJ4Z7sI=; b=fAULSwf4Pj+E1UknxqjuJ/OdTFuiM7YxgvSqmyiVuhepLdtk8HrH3yeP++ilsATvZQ 5uUedwNnU2hl/Gmjit3Ykk/Y3BCHR93wDqaLZ7QJCWw0rAmnccIhKnwv5CdxzmyYq8eS SPKhucRIXtC7Kxli/P/k2eIB8OMVbsEmbEphr3fpvHiAKzPHKETrIG6q5URdo2VIVtXg DWJVQF9BPsQUYDkq//AiIh5sQWLLCqnK+8b1wogRQKfZZ/8dCu6bipeYSjhCz/DtiBFR O59TGtBnYwHvt1PEMtpSZ4fag3sx9r3sJwVlPWzfNthiZ/dNYL4F4HfPEshQFDJcFpVR zsgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Jqw0MwknMj1RijM4alevMH+POuK2y8El0iNuvJ4Z7sI=; b=iliIaYAvbLuHpIS2crv9LTzUuT0M3Ie1IayG7m+CaDwOXgv4/Hr/dfnwSKpGH3RqQp EwXwKtgXQ6e0qelQX498ifCc1g5FE+W5IxE+9AqIBt1mh+47rcGu6BweFI1JsbZPUUaZ oIb8HFx87dXfR910+LfTyilURNS+EAZP9NQfmScakMUlC3+0vnvmc984Qurp4Lc8753d KuxFQLDRrVfvhXvy/N3W4YU/DL7kitippxDnNm163kgpJOmcKFXAWpp4yyrJfe0ru/2t tmKGF6U4bJvI3DnSWbdRufWTTxcEHFlVH9Y6UysLFvvHSFpvkVRoqUNJIK3kUGV/hml+ 2Usw== X-Gm-Message-State: AOAM533z5KL7dsQzF22UoCwEwFOXn2lVO3PNHAIp0HB2AfSrg2SclZZ/ VQFZf+Ak96M28Vsa5VaJmPwDLDim+eCkyKWFNyg= X-Google-Smtp-Source: ABdhPJz++uZDYjY85Lmv2nL7XDUdCXXJBPnGtWjT5ffovBGzVwDowugFqSssiyb2f7K0TOpCH2pam3qeCpee4wMP704= X-Received: by 2002:a9d:6e0d:: with SMTP id e13mr9580893otr.304.1630915904431; Mon, 06 Sep 2021 01:11:44 -0700 (PDT) MIME-Version: 1.0 References: <20210906075516.15066-1-long870912@gmail.com> In-Reply-To: From: xiao zhao Date: Mon, 6 Sep 2021 16:11:33 +0800 Message-ID: Subject: Re: [PATCH] x86: xen: platform-pci-unplug: use pr_err() and pr_warn() instead of raw printk() To: Juergen Gross Cc: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, x86@kernel.org, hpa@zytor.com, xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, boris.ostrovsky@oracle.com, sstabellini@kernel.org Content-Type: multipart/alternative; boundary="00000000000024674305cb4f335e" --00000000000024674305cb4f335e Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sorry, I don't know the patch has already been applied through the Xen tree. Thanks. Juergen Gross =E4=BA=8E2021=E5=B9=B49=E6=9C=886=E6=97=A5= =E5=91=A8=E4=B8=80 =E4=B8=8B=E5=8D=883:58=E5=86=99=E9=81=93=EF=BC=9A > On 06.09.21 09:55, zhaoxiao wrote: > > Since we have the nice helpers pr_err() and pr_warn(), use them instead > > of raw printk(). > > > > Signed-off-by: zhaoxiao > > Any reason you are sending this patch again? It has already been applied > through the Xen tree. > > > Juergen > --00000000000024674305cb4f335e Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Sorry, I don't know the patch=C2=A0has already been ap= plied through the Xen tree. Thanks.

Juergen Gross <jgross@suse.com> =E4=BA=8E2021=E5=B9=B49=E6=9C=886=E6= =97=A5=E5=91=A8=E4=B8=80 =E4=B8=8B=E5=8D=883:58=E5=86=99=E9=81=93=EF=BC=9A<= br>
On 06.09.21 09:5= 5, zhaoxiao wrote:
> Since we have the nice helpers pr_err() and pr_warn(), use them instea= d
> of raw printk().
>
> Signed-off-by: zhaoxiao <long870912@gmail.com>

Any reason you are sending this patch again? It has already been applied through the Xen tree.


Juergen
--00000000000024674305cb4f335e-- From xen-devel-bounces@lists.xenproject.org Mon Sep 06 08:23:56 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Sep 2021 08:23:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.179457.325723 (Exim 4.92) (envelope-from ) id 1mN9uv-0001dN-UJ; Mon, 06 Sep 2021 08:23:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 179457.325723; Mon, 06 Sep 2021 08:23:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mN9uv-0001dG-Ql; Mon, 06 Sep 2021 08:23:49 +0000 Received: by outflank-mailman (input) for mailman id 179457; Mon, 06 Sep 2021 08:23:48 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mN9uu-0001dA-OW for xen-devel@lists.xenproject.org; Mon, 06 Sep 2021 08:23:48 +0000 Received: from smtp-out2.suse.de (unknown [195.135.220.29]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 360c8a42-d7be-4d2a-8c97-c6ef0df8db6d; Mon, 06 Sep 2021 08:23:47 +0000 (UTC) Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id CEC6720097; Mon, 6 Sep 2021 08:23:46 +0000 (UTC) Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap1.suse-dmz.suse.de (Postfix) with ESMTPS id 99F4C1363C; Mon, 6 Sep 2021 08:23:46 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap1.suse-dmz.suse.de with ESMTPSA id bk/6IxLQNWEvbAAAGKfGzw (envelope-from ); Mon, 06 Sep 2021 08:23:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 360c8a42-d7be-4d2a-8c97-c6ef0df8db6d DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1630916626; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=57S1nNH9F/vO+SKTjE94uCVaSzV8n1fOeTrRwN+v1Wc=; b=WgmWKT7pJqmwfIHmJW8QEWohpMCBKo/+GOgmLwAIScLW0Ch5fwHOlR4y19nTTHLslkfbiZ QZi1om9eBKiZ4kMWIAjumO40fHfIY7+bmqJKscIaIXeB1Lhl+RE7Idt0A6NtAKm8Y8kSS5 HikzdsPX62R4jKI5vO2SB4i4kbMMx44= Subject: Re: Crash when using cpupools To: Bertrand Marquis , Xen-devel Cc: Julien Grall , Stefano Stabellini , Dario Faggioli References: From: Juergen Gross Message-ID: <5b0a4530-72df-a186-9bd5-50759b3dd151@suse.com> Date: Mon, 6 Sep 2021 10:23:45 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="wY65b36q0bSXFLeiVc8vg5hcmacMuivLC" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --wY65b36q0bSXFLeiVc8vg5hcmacMuivLC Content-Type: multipart/mixed; boundary="enopubJSFoztANg8vadMnHvwG2acC1EI6"; protected-headers="v1" From: Juergen Gross To: Bertrand Marquis , Xen-devel Cc: Julien Grall , Stefano Stabellini , Dario Faggioli Message-ID: <5b0a4530-72df-a186-9bd5-50759b3dd151@suse.com> Subject: Re: Crash when using cpupools References: In-Reply-To: --enopubJSFoztANg8vadMnHvwG2acC1EI6 Content-Type: multipart/mixed; boundary="------------415838FAAE7F29D92DDEEB04" Content-Language: en-US This is a multi-part message in MIME format. --------------415838FAAE7F29D92DDEEB04 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 03.09.21 17:41, Bertrand Marquis wrote: > Hi, >=20 > While doing some investigation with cpupools I encountered a crash when= trying to isolate a guest to its own physical cpu. >=20 > I am using current staging status. >=20 > I did the following (on FVP with 8 cores): > - start dom0 with dom0_max_vcpus=3D1 > - remove core 1 from dom0 cpupool: xl cpupool-cpu-remove Pool-0 1 > - create a new pool: xl cpupool-create name=3D\"NetPool\=E2=80=9D > - add core 1 to the pool: xl cpupool-cpu-add NetPool 1 > - create a guest in NetPool using the following in the guest config: po= ol=3D=E2=80=9CNetPool" >=20 > I end with a crash with the following call trace during guest creation:= > (XEN) Xen call trace: > (XEN) [<0000000000234cb0>] credit2.c#csched2_alloc_udata+0x58/0xfc (= PC) > (XEN) [<0000000000234c80>] credit2.c#csched2_alloc_udata+0x28/0xfc (= LR) > (XEN) [<0000000000242d38>] sched_move_domain+0x144/0x6c0 > (XEN) [<000000000022dd18>] cpupool.c#cpupool_move_domain_locked+0x38= /0x70 > (XEN) [<000000000022fadc>] cpupool_do_sysctl+0x73c/0x780 > (XEN) [<000000000022d8e0>] do_sysctl+0x788/0xa58 > (XEN) [<0000000000273b68>] traps.c#do_trap_hypercall+0x78/0x170 > (XEN) [<0000000000274f70>] do_trap_guest_sync+0x138/0x618 > (XEN) [<0000000000260458>] entry.o#guest_sync_slowpath+0xa4/0xd4 >=20 > After some debugging I found out that unit->vcpu_list is NULL after uni= t->vcpu_list =3D d->vcpu[unit->unit_id]; with unit_id 0 in common/sched/c= ore.c:688 > This makes the call to is_idle_unit(unit) in csched2_alloc_udata trigge= r the crash. So there is no vcpu 0 in that domain? How is this possible? Juergen --------------415838FAAE7F29D92DDEEB04 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Transfer-Encoding: quoted-printable Content-Description: OpenPGP public key Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy= cWx w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O= f8Z d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y= 9bf IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq= G7/ 377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR= 3Jv c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA= QIe AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT= hpw dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0= MbD 1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv= oPH Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v= 5QL +qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ= 2Vu IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC= QoL BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr= Wf0 teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC= /nu AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh= ITT d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm= XBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz= 80h SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC= AcD AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn= FOX gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1= jnD kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0= N51 N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l= otu fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1= tqS EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA= hsD BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3= g3O ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5= dM7 wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5= D+j LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm= V2x AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N= Eaw QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW= nHI s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR= wgn BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV= bVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk= pEd IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA= QAB wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw= Tbe 8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1= vJz Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8= VGi wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW= svi uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX= zXs ZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------415838FAAE7F29D92DDEEB04-- --enopubJSFoztANg8vadMnHvwG2acC1EI6-- --wY65b36q0bSXFLeiVc8vg5hcmacMuivLC Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmE10BIFAwAAAAAACgkQsN6d1ii/Ey9w dgf/SCez1XZCmBzFoS8n1p7BJfT4ftHXsGBrvPYx12GK2n9lXm2wd8tV3piFR1LLhotDQV7eP0Aj 6g/9oZoi/WiqgVYWivxLTGwAmFJNmUGkErZYywVRUg/AfS/vvSPEyMVwFd0ZWDoXXQZLqN6KBWzF wjULi95YK/P1EhTGFGpLcrDk7Gra2cyOYoHrYfrQ5TK779Sbqr4v2M0B4alTRx8cxNkKIDbL/Lhv K5OfhCvNB3QE+S9Pku6wXklbAevL/iHq8jCS6K9UUN+jpMwITyNhBHXdHgzJRBHmtVRCG7YeuS/X t7BiATwoYkKNj/q3tr0eE8cIP7tl1+mx6iP28vfN7g== =ftUM -----END PGP SIGNATURE----- --wY65b36q0bSXFLeiVc8vg5hcmacMuivLC-- From xen-devel-bounces@lists.xenproject.org Mon Sep 06 08:24:53 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Sep 2021 08:24:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.179463.325734 (Exim 4.92) (envelope-from ) id 1mN9vx-0002CV-8E; Mon, 06 Sep 2021 08:24:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 179463.325734; Mon, 06 Sep 2021 08:24:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mN9vx-0002CO-4I; Mon, 06 Sep 2021 08:24:53 +0000 Received: by outflank-mailman (input) for mailman id 179463; Mon, 06 Sep 2021 08:24:51 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mN9vv-0002CG-N8 for xen-devel@lists.xenproject.org; Mon, 06 Sep 2021 08:24:51 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (unknown [40.107.6.59]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id e7a0ee50-0eeb-11ec-b09b-12813bfff9fa; Mon, 06 Sep 2021 08:24:51 +0000 (UTC) Received: from DU2PR04CA0167.eurprd04.prod.outlook.com (2603:10a6:10:2b0::22) by DB6PR08MB2663.eurprd08.prod.outlook.com (2603:10a6:6:21::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19; Mon, 6 Sep 2021 08:24:39 +0000 Received: from DB5EUR03FT023.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:2b0:cafe::b5) by DU2PR04CA0167.outlook.office365.com (2603:10a6:10:2b0::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.20 via Frontend Transport; Mon, 6 Sep 2021 08:24:39 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT023.mail.protection.outlook.com (10.152.20.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Mon, 6 Sep 2021 08:24:39 +0000 Received: ("Tessian outbound 5918cb94a4b5:v103"); Mon, 06 Sep 2021 08:24:39 +0000 Received: from d993e605fcea.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id BCFFB8A1-1D20-4CD7-827A-2EFA6490215F.1; Mon, 06 Sep 2021 08:24:32 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id d993e605fcea.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 06 Sep 2021 08:24:32 +0000 Received: from PAXPR08MB6446.eurprd08.prod.outlook.com (2603:10a6:102:12d::10) by PR3PR08MB5707.eurprd08.prod.outlook.com (2603:10a6:102:8b::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.22; Mon, 6 Sep 2021 08:24:30 +0000 Received: from PAXPR08MB6446.eurprd08.prod.outlook.com ([fe80::c029:ed0:82e7:3c2f]) by PAXPR08MB6446.eurprd08.prod.outlook.com ([fe80::c029:ed0:82e7:3c2f%6]) with mapi id 15.20.4478.025; Mon, 6 Sep 2021 08:24:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e7a0ee50-0eeb-11ec-b09b-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=r9quR08hWtYNSsdIKzLQ+LhdPucH7fi6yjeXX0EcObI=; b=bGEFN9PQjFtVTa/QYC3EUCsQ9bX1se+s5be+Gz6ls7tM11chJFLa6KHuFkxiEQTtpiZSFDRxrzJkiZr/ZbyYqru/v7Ub1gEyHWJYXYmskX4q2Vy97EnBQVkYTHUUpSw1+VTXEnqYhistEJzXGVzK54BpKmdItPmW1s4RGaXY2VM= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: 35b6929ec9af1a07 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GHZ1tyoVJznr+V/ahN3pJIP6eaykjvYKgIJFUSdHdekqZ2UcUvFqSs7wf+p4CQ2MvwGUU9gaBXdl1s15QKa/RuXRA7dblIeqGMmBt7cMZ3zfrTqKf5Ahc4RRl03/wQ3s/n4Ve34qQ66k9sc6tlxXSIAEiAVO0DdSRjdGhPfTUbsGH1x1L4AY2TztlFTj73HgqbsVukuQGOTUwy2ZoYCqWKnAgKMl8x0BMMCgoMunJojpPqQKrEEPmWum5Q6kecICw5pV2znNL/gWgNmeSPIEhll+R+aZXrzv/vg2LCB3KkL3mlWOQe8ggoGLj9uKbAQfHAOhTMV5A6c7QklFAJg8Rw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=r9quR08hWtYNSsdIKzLQ+LhdPucH7fi6yjeXX0EcObI=; b=kj99V3tP1IAJvjv2e53fRjm6zBLqzsT3zWPWrSJ7uykBlEQlAP2fq5Y0dfJ/zLQb3NUz6MWY88ctWESgX5w8fKfup2XkyaKLosg3ZSaP+FMpFyAXITAFzMmd9VZdN5mlNJQQARMDDFO8f0juHd8JWOdfEx7zpDIe5Ask9CCvW9ZKEJ8abk4EH7a9DEVFEnK/eKqov3HxGmaz45jtc3vpcZKaA1So8oUGd3mTHG8YBy4tfD4gl7KZdOMi5glAEyLzRBQq6u8t3DdpakEBcUI4+Hc9/RNi8VjxpAzBf8iFFMutc1xS4WkxL0BJbphR4X00uhDQX0eh8prrH2hQP4l3Ag== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=r9quR08hWtYNSsdIKzLQ+LhdPucH7fi6yjeXX0EcObI=; b=bGEFN9PQjFtVTa/QYC3EUCsQ9bX1se+s5be+Gz6ls7tM11chJFLa6KHuFkxiEQTtpiZSFDRxrzJkiZr/ZbyYqru/v7Ub1gEyHWJYXYmskX4q2Vy97EnBQVkYTHUUpSw1+VTXEnqYhistEJzXGVzK54BpKmdItPmW1s4RGaXY2VM= From: Bertrand Marquis To: Stefano Stabellini CC: Xen-devel , Julien Grall , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Wei Liu Subject: Re: [PATCH v3 4/7] xen/arm: Sanitize cpuinfo ID registers fields Thread-Topic: [PATCH v3 4/7] xen/arm: Sanitize cpuinfo ID registers fields Thread-Index: AQHXmbPuT8O7GIjNskafsumV8a3YcquS+CyAgAPFowA= Date: Mon, 6 Sep 2021 08:24:29 +0000 Message-ID: <3A692AFD-CFD5-4E90-BEF8-5D29E3A9821B@arm.com> References: <6710cc0ac3fbc9c8030dfa3d6dfc3ecb79de4b71.1629897306.git.bertrand.marquis@arm.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3654.120.0.1.13) Authentication-Results-Original: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=arm.com; x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: e9779a59-db3f-42c4-33cc-08d9710fc4e7 x-ms-traffictypediagnostic: PR3PR08MB5707:|DB6PR08MB2663: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:556;OLM:556; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: c2vy3/kqsm0SFth62usHfZM9sf7Ck197UGqPe0QpHH0uNXnSTxKBuYvB2sXRc84yOXg7WFBP9RCmQu0GMe9HO79JtUhkbZEWKx4ulXMzos7dU0OuE4FiI2DcT3Rzjfz1IsGDRmw+RAzSfQ11Gp/3h/jAz3jLKEPmw04Wpp92Q5+viTKQJCgPPr31Auhv63nk768gGAihHoX+xzAjLUJIvgj0Z9gFgEraAu3TDNOoda/YExL+SC2OW0qFZqDS/lBDosy446/f/orDQ9Jg01Y0LLQg3WVBL2BiBI+OyLINqA0VbyXPcHtwKXyVBu9HJoMiKaegS5Zp6C0c1unV9gYB+UsWzVS+Zs0ERvBoLnEg69D648Ccy71SXwEOK6IH6/S24ZTu46remKanJzjbI67VJ0J1feRJx3SYxR2ptjvKcCud4XKajEQAfS4dbo6ja7Gkui7Nnkf44LVBgKRSpNBA9tE9HJYq09bVTbJSJJpAP9n4+XbAsru5kWTESJeaW6eirdmAHt8Aa1pp7NQIcGG+m9M7c6/LRPk2JA7TYCZUdwAwLGqjdokWESA1CR6WP6qqm+XPrWge6YxZLpsPZEdcWqlQMkeOu9rKf5MI2cPeDEEWdZWPopOs53/nfCFc8AZva5aI+wgWmTtTHKHwyUBlKPWyEz5b/1QaCb7+eY7hj4R0D3AEmJfqLm0OOVE8+LrrwOsWdZ5aF3DGkL4MBqWzhE0tJzzjwSpoyEjrL4X9qMV5GhtK6Dv/WkgfLCSasEZp X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB6446.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(122000001)(33656002)(316002)(6916009)(38100700002)(6486002)(83380400001)(86362001)(2906002)(54906003)(2616005)(8676002)(36756003)(91956017)(76116006)(4326008)(26005)(38070700005)(508600001)(71200400001)(53546011)(8936002)(6506007)(6512007)(66946007)(5660300002)(64756008)(66446008)(66556008)(66476007)(186003)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-ID: <6C9677CDE8FB0741AA53416A35C173E6@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR08MB5707 Original-Authentication-Results: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT023.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 1ae03149-6456-44fb-73e4-08d9710fbf2b X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9azTzZTES3EjOBhFC0hoMX+C5+9GUarXijMq0D5oBzKku2ZsVcQBjfZEJ61gu1Dy+M0GOyyGDOi4jf0yLFxxpGeNhrEGXp5LPk8r5PvdM1nnBqE9X4iODhFQ/dhH2UdwMOaNsWh+GY3DaBZiXyzKrcQNOmP+8mSL8Rt+MrNlkVmrIwcAgAZEqdPE069nXpp+2ULC88UKaVvLt0kmXteDqhM4L30hZRQGIEOldNX94f2a8WU79icrxjeYPNrjltIUgevvi9DQ/0M6//Eu3RrW8Vuxccf2b6mnhWjOiIJeETxQdMygpcHFAWRuF9Lh6wm3g0W/+ETdsSgZKBdCGIF0SWedKkONjTTFp10s8Mt2gqSd5gysPhyHCnbNJpzpFdFxZvgc/ZtFZWv5PDxDYqp7bltifh5NqERhpe1IXaGIaG2Iotxrh0IIl2j17Q8LT7nNqG9t02ssorqvSY69crsrGuojk5JlSxAUDKWGjW0Bpq2ATkssJCqHMHv33zlWXewC1eqYsu6+qtXYz4sx8X2pJg2JWhwopGsZCJ3q93RzssBX3Hw5fq3H6fTo2w5N0SlCCOmZV8QhZ7Z//JGc3eNpiJdajNs9KRuM1KMKU0mF2bFg8qNhPCGIm5MmISpBCyl641rcIx0vvVyQB88r0nOMXpf+IJkW/D3BWKSJk+4OErZEEN2L+OBfcGhta6Vvc7REoX+7XJvAt50i4x9aThyDZA== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(136003)(376002)(39860400002)(396003)(346002)(46966006)(36840700001)(6506007)(53546011)(2616005)(6862004)(4326008)(47076005)(316002)(6512007)(83380400001)(82310400003)(5660300002)(36756003)(6486002)(82740400003)(8676002)(54906003)(186003)(8936002)(36860700001)(26005)(356005)(81166007)(70206006)(70586007)(336012)(478600001)(33656002)(2906002)(86362001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2021 08:24:39.1490 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e9779a59-db3f-42c4-33cc-08d9710fc4e7 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT023.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR08MB2663 Hi Stefano, > On 3 Sep 2021, at 23:48, Stefano Stabellini wrot= e: >=20 > On Wed, 25 Aug 2021, Bertrand Marquis wrote: >> Define a sanitize_cpu function to be called on secondary cores to >> sanitize the system cpuinfo structure. >>=20 >> The safest value is taken when possible and the system is marked tainted >> if we encounter values which are incompatible with each other. >>=20 >> Call the update_system_features function on all secondary cores that are >> kept running and taint the system if different midr are found between >> cores but hmp-unsafe=3Dtrue was passed on Xen command line. >>=20 >> This is only supported on arm64 so update_system_features is an empty >> static inline on arm32. >>=20 >> The patch is adding a new TAINT_CPU_OUT_OF_SPEC to warn the user if >> Xen is running on a system with features differences between cores which >> are not supported. >>=20 >> The patch is disabling CTR_EL0, DCZID_EL0 and ZCRusing #if 0 with a TODO >> as this patch is not handling sanitization of those registers. >> CTR_EL0/DCZID will be handled in a future patch to properly handle >> different cache attributes when possible. >> ZCR should be sanitize once we add support for SVE in Xen. >>=20 >> Signed-off-by: Bertrand Marquis >=20 > Great patch! It looks good I only have a couple of minor questions > below. Thanks >=20 >=20 >> --- >> Changes in v3: >> - in case of different midr but hmp-unsafe passed on the command line, >> enable all cores anyway but taint Xen with CPU_OUT_OF_SPEC. >> - use current core info to sanitize cpu only if we keep it on >> Changes in v2: >> - add compilation of cpufeature.c in this patch instead of previous one >> - remove functions reused from linux code and moved to header >> - rename sanitize_cpu to update_system_features >> - change to Linux coding style >> - remove dev comments >> - surround currently not used Linux structures with #if 0 and adapt the >> commit message >> - add missing aa64dfr1 register >> - add TODO for CTR, DCZID and ZCR >> - add CPU_OUT_OF_SPEC support to print_taint >> - use system_cpuinfo instead of boot_cpu_data >> --- >> xen/arch/arm/arm64/Makefile | 1 + >> xen/arch/arm/arm64/cpufeature.c | 121 +++++++++++++++++++++++++++++++ >> xen/arch/arm/smpboot.c | 34 +++++++-- >> xen/common/kernel.c | 6 +- >> xen/include/asm-arm/cpufeature.h | 9 +++ >> xen/include/xen/lib.h | 1 + >> 6 files changed, 162 insertions(+), 10 deletions(-) >>=20 >> diff --git a/xen/arch/arm/arm64/Makefile b/xen/arch/arm/arm64/Makefile >> index 40642ff574..701d66883d 100644 >> --- a/xen/arch/arm/arm64/Makefile >> +++ b/xen/arch/arm/arm64/Makefile >> @@ -1,6 +1,7 @@ >> obj-y +=3D lib/ >>=20 >> obj-y +=3D cache.o >> +obj-y +=3D cpufeature.o >> obj-$(CONFIG_HARDEN_BRANCH_PREDICTOR) +=3D bpi.o >> obj-$(CONFIG_EARLY_PRINTK) +=3D debug.o >> obj-y +=3D domctl.o >> diff --git a/xen/arch/arm/arm64/cpufeature.c b/xen/arch/arm/arm64/cpufea= ture.c >> index 5777e33e5c..61f629ebaa 100644 >> --- a/xen/arch/arm/arm64/cpufeature.c >> +++ b/xen/arch/arm/arm64/cpufeature.c >> @@ -275,6 +275,9 @@ static const struct arm64_ftr_bits ftr_id_aa64mmfr2[= ] =3D { >> ARM64_FTR_END, >> }; >>=20 >> +#if 0 >> +/* TODO: use this to sanitize the cache line size among cores */ >> + >> static const struct arm64_ftr_bits ftr_ctr[] =3D { >> ARM64_FTR_BITS(FTR_VISIBLE, FTR_STRICT, FTR_EXACT, 31, 1, 1), /* RES1 *= / >> ARM64_FTR_BITS(FTR_VISIBLE, FTR_STRICT, FTR_LOWER_SAFE, CTR_DIC_SHIFT, = 1, 1), >> @@ -291,6 +294,7 @@ static const struct arm64_ftr_bits ftr_ctr[] =3D { >> ARM64_FTR_BITS(FTR_VISIBLE, FTR_STRICT, FTR_LOWER_SAFE, CTR_IMINLINE_SH= IFT, 4, 0), >> ARM64_FTR_END, >> }; >> +#endif >>=20 >> static const struct arm64_ftr_bits ftr_id_mmfr0[] =3D { >> S_ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_MMFR0_INNER= SHR_SHIFT, 4, 0xf), >> @@ -325,11 +329,14 @@ static const struct arm64_ftr_bits ftr_mvfr2[] =3D= { >> ARM64_FTR_END, >> }; >>=20 >> +#if 0 >> +/* TODO: handle this when sanitizing cache related registers */ >> static const struct arm64_ftr_bits ftr_dczid[] =3D { >> ARM64_FTR_BITS(FTR_VISIBLE, FTR_STRICT, FTR_EXACT, DCZID_DZP_SHIFT, 1, = 1), >> ARM64_FTR_BITS(FTR_VISIBLE, FTR_STRICT, FTR_LOWER_SAFE, DCZID_BS_SHIFT,= 4, 0), >> ARM64_FTR_END, >> }; >> +#endif >>=20 >> static const struct arm64_ftr_bits ftr_id_isar0[] =3D { >> ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_ISAR0_DIVIDE_= SHIFT, 4, 0), >> @@ -444,11 +451,15 @@ static const struct arm64_ftr_bits ftr_id_dfr1[] = =3D { >> ARM64_FTR_END, >> }; >>=20 >> +#if 0 >> +/* TODO: use this to sanitize SVE once we support it */ >> + >> static const struct arm64_ftr_bits ftr_zcr[] =3D { >> ARM64_FTR_BITS(FTR_HIDDEN, FTR_NONSTRICT, FTR_LOWER_SAFE, >> ZCR_ELx_LEN_SHIFT, ZCR_ELx_LEN_SIZE, 0), /* LEN */ >> ARM64_FTR_END, >> }; >> +#endif >>=20 >> /* >> * Common ftr bits for a 32bit register with all hidden, strict >> @@ -502,3 +513,113 @@ static s64 arm64_ftr_safe_value(const struct arm64= _ftr_bits *ftrp, s64 new, >> * End of imported linux structures and code >> */ >>=20 >> +static void sanitize_reg(u64 *cur_reg, u64 new_reg, const char *reg_nam= e, >> + const struct arm64_ftr_bits *ftrp) >> +{ >> + int taint =3D 0; >> + u64 old_reg =3D *cur_reg; >> + >> + for (;ftrp->width !=3D 0;ftrp++) >> + { >> + u64 mask; >> + s64 cur_field =3D arm64_ftr_value(ftrp, *cur_reg); >> + s64 new_field =3D arm64_ftr_value(ftrp, new_reg); >> + >> + if (cur_field =3D=3D new_field) >> + continue; >> + >> + if (ftrp->strict) >> + taint =3D 1; >> + >> + mask =3D arm64_ftr_mask(ftrp); >> + >> + *cur_reg &=3D ~mask; >> + *cur_reg |=3D (arm64_ftr_safe_value(ftrp, new_field, cur_field) >> + << ftrp->shift) & mask; >=20 > I wonder why you haven't also imported arm64_ftr_set_value? This seems > to be the open-coded version of it. You are right I could have used it instead (no idea why I did not). I will modify that and send an update. Good finding :-) >=20 >=20 >> + } >> + >> + if (old_reg !=3D new_reg) >> + printk(XENLOG_DEBUG "SANITY DIF: %s 0x%"PRIx64" -> 0x%"PRIx64"\n", >> + reg_name, old_reg, new_reg); >> + if (old_reg !=3D *cur_reg) >> + printk(XENLOG_DEBUG "SANITY FIX: %s 0x%"PRIx64" -> 0x%"PRIx64"\n", >> + reg_name, old_reg, *cur_reg); >> + >> + if (taint) >> + { >> + printk(XENLOG_WARNING "SANITY CHECK: Unexpected variation in %s.\n", >> + reg_name); >> + add_taint(TAINT_CPU_OUT_OF_SPEC); >> + } >> +} >> + >> + >> +/* >> + * This function should be called on secondary cores to sanitize the bo= ot cpu >> + * cpuinfo. >> + */ >> +void update_system_features(const struct cpuinfo_arm *new) >> +{ >> + >> +#define SANITIZE_REG(field, num, reg) \ >> + sanitize_reg(&system_cpuinfo.field.bits[num], new->field.bits[num], \ >> + #reg, ftr_##reg) >> + >> +#define SANITIZE_ID_REG(field, num, reg) \ >> + sanitize_reg(&system_cpuinfo.field.bits[num], new->field.bits[num], \ >> + #reg, ftr_id_##reg) >> + >> +#define SANITIZE_RAZ_REG(field, num, reg) \ >> + sanitize_reg(&system_cpuinfo.field.bits[num], new->field.bits[num], \ >> + #reg, ftr_raz) >> + >> +#define SANITIZE_GENERIC_REG(field, num, reg) \ >> + sanitize_reg(&system_cpuinfo.field.bits[num], new->field.bits[num], \ >> + #reg, ftr_generic_32bits) >> + >> + SANITIZE_ID_REG(pfr64, 0, aa64pfr0); >> + SANITIZE_ID_REG(pfr64, 1, aa64pfr1); >> + >> + SANITIZE_ID_REG(dbg64, 0, aa64dfr0); >> + SANITIZE_RAZ_REG(dbg64, 1, aa64dfr1); >> + >> + SANITIZE_ID_REG(mm64, 0, aa64mmfr0); >> + SANITIZE_ID_REG(mm64, 1, aa64mmfr1); >> + SANITIZE_ID_REG(mm64, 2, aa64mmfr2); >> + >> + SANITIZE_ID_REG(isa64, 0, aa64isar0); >> + SANITIZE_ID_REG(isa64, 1, aa64isar1); >> + >> + SANITIZE_ID_REG(zfr64, 0, aa64zfr0); >> + >> + if ( cpu_feature64_has_el0_32(&system_cpuinfo) ) >> + { >> + SANITIZE_ID_REG(pfr32, 0, pfr0); >> + SANITIZE_ID_REG(pfr32, 1, pfr1); >> + SANITIZE_ID_REG(pfr32, 2, pfr2); >> + >> + SANITIZE_ID_REG(dbg32, 0, dfr0); >> + SANITIZE_ID_REG(dbg32, 1, dfr1); >> + >> + SANITIZE_ID_REG(mm32, 0, mmfr0); >> + SANITIZE_GENERIC_REG(mm32, 1, mmfr1); >> + SANITIZE_GENERIC_REG(mm32, 2, mmfr2); >> + SANITIZE_GENERIC_REG(mm32, 3, mmfr3); >> + SANITIZE_ID_REG(mm32, 4, mmfr4); >> + SANITIZE_ID_REG(mm32, 5, mmfr5); >> + >> + SANITIZE_ID_REG(isa32, 0, isar0); >> + SANITIZE_GENERIC_REG(isa32, 1, isar1); >> + SANITIZE_GENERIC_REG(isa32, 2, isar2); >> + SANITIZE_GENERIC_REG(isa32, 3, isar3); >> + SANITIZE_ID_REG(isa32, 4, isar4); >> + SANITIZE_ID_REG(isa32, 5, isar5); >> + SANITIZE_ID_REG(isa32, 6, isar6); >> + >> + SANITIZE_GENERIC_REG(mvfr, 0, mvfr0); >> + SANITIZE_GENERIC_REG(mvfr, 1, mvfr1); >> +#ifndef MVFR2_MAYBE_UNDEFINED >> + SANITIZE_REG(mvfr, 2, mvfr2); >> +#endif >> + } >> +} >=20 > Looking at the list of registers we are sanitizing here we are only > missing aux32 and aux64 compared to struct cpuinfo_arm. Is that because > there is nothing to sanitize there? Aux registers have no standard bit definition and as such cannot be treated= . Linux is doing the same. Cheers Bertrand From xen-devel-bounces@lists.xenproject.org Mon Sep 06 08:29:33 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Sep 2021 08:29:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.179470.325745 (Exim 4.92) (envelope-from ) id 1mNA0N-0002z3-UZ; Mon, 06 Sep 2021 08:29:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 179470.325745; Mon, 06 Sep 2021 08:29:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNA0N-0002yw-RV; Mon, 06 Sep 2021 08:29:27 +0000 Received: by outflank-mailman (input) for mailman id 179470; Mon, 06 Sep 2021 08:29:26 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNA0M-0002yq-P2 for xen-devel@lists.xenproject.org; Mon, 06 Sep 2021 08:29:26 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (unknown [2a01:111:f400:7d00::621]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 29668a3e-8a1e-4067-a903-58ec13f63491; Mon, 06 Sep 2021 08:29:24 +0000 (UTC) Received: from AS9PR06CA0138.eurprd06.prod.outlook.com (2603:10a6:20b:467::24) by PAXPR08MB7185.eurprd08.prod.outlook.com (2603:10a6:102:207::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.21; Mon, 6 Sep 2021 08:29:19 +0000 Received: from AM5EUR03FT048.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:467:cafe::27) by AS9PR06CA0138.outlook.office365.com (2603:10a6:20b:467::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.20 via Frontend Transport; Mon, 6 Sep 2021 08:29:19 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT048.mail.protection.outlook.com (10.152.17.177) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Mon, 6 Sep 2021 08:29:19 +0000 Received: ("Tessian outbound f11f34576ce3:v103"); Mon, 06 Sep 2021 08:29:19 +0000 Received: from 7268d7fd9e47.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 08D861F5-D650-4DC4-9101-51D0454602AF.1; Mon, 06 Sep 2021 08:29:13 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 7268d7fd9e47.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 06 Sep 2021 08:29:13 +0000 Received: from PAXPR08MB6446.eurprd08.prod.outlook.com (2603:10a6:102:12d::10) by PAXPR08MB6576.eurprd08.prod.outlook.com (2603:10a6:102:15a::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.17; Mon, 6 Sep 2021 08:29:05 +0000 Received: from PAXPR08MB6446.eurprd08.prod.outlook.com ([fe80::c029:ed0:82e7:3c2f]) by PAXPR08MB6446.eurprd08.prod.outlook.com ([fe80::c029:ed0:82e7:3c2f%6]) with mapi id 15.20.4478.025; Mon, 6 Sep 2021 08:29:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 29668a3e-8a1e-4067-a903-58ec13f63491 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mIvUYbF7S8gDAZN+6fmeLMclWA1FIIhVDIW9rAoYCzI=; b=zmMjejXwXcG1V0B8VjDTjLSMvSG5Do4ByGvVk1eifdsqxZjUfmhMA1aBdraH6vbtHdVEZhhXxhzlofRtcoTSqXYmvdFxiTVwtOaZGOefv5Z6qB5YjPNGwpTv3jIM27CcDz9s2uHyeZxGN00WS2cJH4PBKhwWqPKLR1Wb658p9BI= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: fd24a59af78e937c X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mM9kUiyLvgj1Sg+xs0VuwoWaQE9IgxS1fsHVp5dlG5sXl5e03Ixn1iYuIyqlmXJxA7sK13P2NMoOUv0rDscMnepZcRoIwxl0ul46vxsLBLd/I3kl4ECtJ1L5kBIVu56O3PvGKLkdoQfyQVfmqF2cFwYzxC9xPVonN4JlFFVyMNj3DxNWr35YQZAxfLU1dLqyWxQSt6ej9mIieEY/xjYBEAboOVXJvMOIaJjkBfiW0ItJmL1mIv4pqbOyzMMI7ruU4CkkMnhnlv3lOm/rOsAH4XG7pY7A4PZ+yzV21aMJQzfu/AUqFd+fWvTKlID3gmwIwv8DlmHdJ/xKmzlPyUT/hQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=mIvUYbF7S8gDAZN+6fmeLMclWA1FIIhVDIW9rAoYCzI=; b=cQEXMJqmWp2d8+DuQAI77ekdflX15VhPCVZmffopdetamqW1AzflX7+oIOLkunBVVAoiRjRdjlKfmIGSXiPgYneHja4NlvEZNtLZnZpOE3K98rMXPpT6lu9SBBWFUJJ7szt3o1CDFg1s20/v78mtGqPcMZvsVyy8+9YIi7B3gZXVx29ktrn22czo46E6rjY1qN5M33pWeETWn5bdwicgD4YTcNIjKxZLu7gdLI53y0ykmoDvhCyFbbI+nPp9VRLGG55wwBKo9JUtz0zARt5mVfwSROD2wvnH2qfdH555Tf8O0APVGCXoA8YF/GvWknxYwkuACwujEwDMG0yZMc213w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mIvUYbF7S8gDAZN+6fmeLMclWA1FIIhVDIW9rAoYCzI=; b=zmMjejXwXcG1V0B8VjDTjLSMvSG5Do4ByGvVk1eifdsqxZjUfmhMA1aBdraH6vbtHdVEZhhXxhzlofRtcoTSqXYmvdFxiTVwtOaZGOefv5Z6qB5YjPNGwpTv3jIM27CcDz9s2uHyeZxGN00WS2cJH4PBKhwWqPKLR1Wb658p9BI= From: Bertrand Marquis To: Stefano Stabellini CC: Julien Grall , "xen-devel@lists.xenproject.org" , Volodymyr Babchuk Subject: Re: [PATCH v3 7/7] xen/arm: Sanitize CTR_EL0 and emulate it if needed Thread-Topic: [PATCH v3 7/7] xen/arm: Sanitize CTR_EL0 and emulate it if needed Thread-Index: AQHXmbPyaqNt71/0B0WMx26sIln5R6uHdm2AgAYrXACAABkoAIAAGG+AgAUlJICAA8aUAA== Date: Mon, 6 Sep 2021 08:29:04 +0000 Message-ID: References: <14b1639e-c9e4-f8fb-e921-73d7f28681ac@xen.org> <98E8FB9D-3372-47D2-92F7-8AD401AC1092@arm.com> <6705127a-bde2-36cd-0fed-900eb1eace03@xen.org> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3654.120.0.1.13) Authentication-Results-Original: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=arm.com; x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: b188e162-6490-42e4-4141-08d971106bf2 x-ms-traffictypediagnostic: PAXPR08MB6576:|PAXPR08MB7185: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:10000;OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: vS3hw7RjagwvyY0IecFOD5DpcsJs9nAkkBLLaJm60l4V/pfhmGQkWmH7fL5JLixaFSuG+oZDaP5+aNO21zuNNQJcvfMtrbgIsDgS64ZFAQr0aHjDkrXd9dZEh3ndJcnHLRlzDE7N0fiUh00ejayqnuSALwweH6vtdWW/yEffdJQ+kKWGUz2ltsiB/IgF4ZPyaffUTezqEJXPxZWbf6T/QpRt/1RP83aHw8fZw0c53HYzo4qUIJs0YbtMHpmnajBAAlCzfvL5/OmchK4I1EVwPHSkhxJQwHnQxC6wwrTIHUwJHAwtl8XkPLsjYwiIn3tPFMdnQ5r4bBn3QpqQF6VDyTKAlHJvIMqJdWA+OtBcP/UkFnlemSDSKKFclA+P8dEKHUpV86ov9iCbzjxnedxaQsBYCZ3q54ZL+QL/34FUWAcxfxc6mx0UlD/D2E3OsJIs32EApeXg7PLZP3wWtfjJApnZnoWZu1cZ/e5vo1fyNdmNMkQHpT4K/XilC5mQbhXFHgJY8WjsnEbcKWLf+4fPrzINTFMpfMLl5y1+Wxb+sckkf04e0VXNcjgEdd55OlkKuuAqL3l1541OsyS0vX9t2EE4lV7mMVcKFnNky4U0kB5hSNXezj7NZkuEWAEXuCx+55AVsHmEWMOSnSfs650Y8efxuaxs3T7g1kXTZ0rTGJiQ5ZI4Fb54AvyzTILjZbqmJ6x+Si2lQ2SIDVTmG4/21d2GiSv9sXvTzWGAM3iEIenjnIEbQhco16xqXHsljbiW X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB6446.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(39860400002)(376002)(346002)(396003)(136003)(366004)(2906002)(86362001)(4326008)(38100700002)(316002)(122000001)(54906003)(26005)(6916009)(2616005)(5660300002)(38070700005)(33656002)(6486002)(478600001)(186003)(53546011)(6506007)(91956017)(66556008)(66476007)(76116006)(66946007)(66446008)(64756008)(8676002)(36756003)(8936002)(83380400001)(6512007)(71200400001)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="utf-8" Content-ID: <84D31BB05B88A9479F9D79FD63BC079D@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6576 Original-Authentication-Results: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT048.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 5c849654-0661-4f27-89d8-08d97110637a X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: EsKaSiSORlrVwgVHogxGgRANhDMusjrWlT+cKNmXvoAgJTOClfKmFCVYC7wy/B2+oTOWyxleHjYt1U9apUm81Pbz8GMcbjfDpWHZv/v51bX22r1T5yrvrbdImy/ksprQ+QwGXrSnyLi9BbWlTCqK9zE05wExNZgN53IxrRufZKESsgjV68Dt0jNYFDW692HP9VslUlLPgAhapEHcbnWPygDDH7y/bIXd4l5pGk1NpScWJ/X31Cu1pFcUUzWCQkveer4IHzUYRi1fmp6qCU5pzlQTOuBivtlkez7Oy9RhMdurvvu77T1spVIxirNCO6c4P0fKe2KXlwGrKsdxeWWckgwP4w6gpeWl18uuasDyuj2oJnAl2ZIFanBXbt4/P/DnGnozJSvjABloT8fC7oFg+3udtOaQJs/VHfTxVPIaxhOkAroRMgWxLkkA6h5ul7ITtlZH2KA+VONLh64eTN0MKIFGiVoRgusSgrJagRn2LLCR7XSD4TtLOARP6UiLntbQ/Sj7Q1ufeGremmyoJYx/6M8UsrVpXgQQO8lqqhirMc4JvDjzpUVEQDhdrJwncmW6hU6OfwuMIzbiPujeH8p2LTR9p3+0ItlXeecz0whtTUj/pMSZ3xlTpX/CY1DTQXzeuTAWyzBzRZ+KhBAvuBhxpbCPuabvABD4DyQEUq7EwsGhnxlkxfc4urJWuRI/6D8mJAyknLkpfcp7M6iy3fDDvA== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(6506007)(6862004)(53546011)(33656002)(54906003)(83380400001)(2616005)(36860700001)(336012)(8936002)(81166007)(356005)(186003)(26005)(8676002)(4326008)(316002)(107886003)(5660300002)(36756003)(86362001)(6512007)(47076005)(82310400003)(70586007)(70206006)(508600001)(6486002)(2906002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2021 08:29:19.3320 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b188e162-6490-42e4-4141-08d971106bf2 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT048.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB7185 SGkgU3RlZmFubywNCg0KPiBPbiAzIFNlcCAyMDIxLCBhdCAyMzo0OSwgU3RlZmFubyBTdGFiZWxs aW5pIDxzc3RhYmVsbGluaUBrZXJuZWwub3JnPiB3cm90ZToNCj4gDQo+IE9uIFR1ZSwgMzEgQXVn IDIwMjEsIEJlcnRyYW5kIE1hcnF1aXMgd3JvdGU6DQo+PiBIaSBKdWxpZW4sDQo+PiANCj4+PiBP biAzMSBBdWcgMjAyMSwgYXQgMTU6NDcsIEp1bGllbiBHcmFsbCA8anVsaWVuQHhlbi5vcmc+IHdy b3RlOg0KPj4+IA0KPj4+IA0KPj4+IA0KPj4+IE9uIDMxLzA4LzIwMjEgMTQ6MTcsIEJlcnRyYW5k IE1hcnF1aXMgd3JvdGU6DQo+Pj4+IEhpIEp1bGllbiwNCj4+PiANCj4+PiBIaSBCZXJ0cmFuZCwN Cj4+PiANCj4+Pj4+IE9uIDI3IEF1ZyAyMDIxLCBhdCAxNjowNSwgSnVsaWVuIEdyYWxsIDxqdWxp ZW5AeGVuLm9yZz4gd3JvdGU6DQo+Pj4+PiANCj4+Pj4+IEhpIEJlcnRyYW5kLA0KPj4+Pj4gDQo+ Pj4+PiBPbiAyNS8wOC8yMDIxIDE0OjE4LCBCZXJ0cmFuZCBNYXJxdWlzIHdyb3RlOg0KPj4+Pj4+ IFNhbml0aXplIENUUl9FTDAgdmFsdWUgYmV0d2VlbiBjb3Jlcy4NCj4+Pj4+PiBJbiBtb3N0IGNh c2VzIGRpZmZlcmVudCB2YWx1ZXMgd2lsbCB0YWludCBYZW4gYnV0IGlmIGRpZmZlcmVudA0KPj4+ Pj4+IGktY2FjaGUgcG9saWNpZXMgYXJlIGZvdW5kLCB3ZSBjaG9vc2UgdGhlIG9uZSB3aGljaCB3 aWxsIGJlIGNvbXBhdGlibGUNCj4+Pj4+PiBiZXR3ZWVuIGFsbCBjb3JlcyBpbiB0ZXJtcyBvZiBp bnZhbGlkYXRpb24vZGF0YSBjYWNoZSBmbHVzaGluZyBzdHJhdGVneS4NCj4+Pj4+IA0KPj4+Pj4g SSB1bmRlcnN0YW5kIHRoYXQgYWxsIHRoZSBDUFVzIGluIFhlbiBuZWVkcyB0byBhZ3JlZSBvbiB0 aGUgY2FjaGUgZmx1c2ggc3RyYXRlZ3kuIEhvd2V2ZXIuLi4NCj4+Pj4+IA0KPj4+Pj4+IEluIHRo aXMgY2FzZSB3ZSBuZWVkIHRvIGFjdGl2YXRlIHRoZSBUSUQyIGJpdCBpbiBIQ1IgdG8gZW11bGF0 ZSB0aGUNCj4+Pj4+PiBUQ1JfRUwwIHJlZ2lzdGVyIGZvciBndWVzdHMuIFRoaXMgcGF0Y2ggaXMg bm90IGFjdGl2YXRpbmcgVElEMiBiaXQgYWxsDQo+Pj4+Pj4gdGhlIHRpbWUgdG8gbGltaXQgdGhl IG92ZXJoZWFkIHdoZW4gcG9zc2libGUuDQo+Pj4+PiANCj4+Pj4+IGFzIHdlIGRpc2N1c3NlZCBp biBhbiBlYXJsaWVyIHZlcnNpb24sIGEgdkNQVSBpcyB1bmxpa2VseSAoYXQgbGVhc3QgaW4gc2hv cnQvbWVkaXVtKSB0byBiZSBhYmxlIG1vdmUgYWNyb3NzIHBDUFUgb2YgZGlmZmVyZW50IHR5cGUu IFNvIHRoZSB2Q1BVIHdvdWxkIGJlIHBpbm5lZCB0byBhIHNldCBvZiBwQ1BVcy4gSU9XLCB0aGUg Z3Vlc3Qgd291bGQgaGF2ZSB0byBiZSBiaWcuTElUVExFIGF3YXJlIGFuZCB0aGVyZWZvcmUgd291 bGQgYmUgYWJsZSB0byBkbyBpdHMgb3duIHN0cmF0ZWd5IGRlY2lzaW9uLg0KPj4+Pj4gDQo+Pj4+ PiBTbyBJIHRoaW5rIHdlIHNob3VsZCBiZSBhYmxlIHRvIGdldCBhd2F5IGZyb20gdHJhcHBpbmdz IHRoZSByZWdpc3RlcnMuDQo+Pj4+IEkgZG8gYWdyZWUgdGhhdCB3ZSBzaG91bGQgYmUgYWJsZSB0 byBnZXQgYXdheSBmcm9tIHRoYXQgaW4gdGhlIGxvbmcgdGVybSBvbmNlDQo+Pj4+IHdlIGhhdmUg Y3B1cG9vbHMgcHJvcGVybHkgc2V0IGJ1dCByaWdodCBub3cgdGhpcyBpcyB0aGUgb25seSB3YXkg dG8gaGF2ZQ0KPj4+PiBzb21ldGhpbmcgdXNlYWJsZSAoSSB3aWxsIG5vdCBzYXkgcmlnaHQpLg0K Pj4+PiBJIHdpbGwgd29yayBvbiBmaW5kaW5nIGEgd2F5IHRvIHNldHVwIHByb3Blcmx5IGNwdXBv b2xzIChvciBzb21ldGhpbmcgZWxzZSBhcw0KPj4+PiB3ZSBkaXNjdXNzZWQgZWFybGllcikgYnV0 IGluIHRoZSBzaG9ydCB0ZXJtIEkgdGhpbmsgdGhpcyBpcyB0aGUgYmVzdCB3ZSBjYW4gZG8uDQo+ Pj4gDQo+Pj4gTXkgY29uY2VybiBpcyB5b3UgYXJlIG1ha2luZyBsb29rIGxpa2UgWGVuIHdpbGwg YmUgYWJsZSB0byBkZWFsIG5pY2VseSB3aXRoIGJpZy5MSVRUTEUgd2hlbiBpbiBmYWN0IHRoZXJl IGFyZSBhIGxvdCBtb3JlIHBvdGVudGlhbCBpc3N1ZSBieSBhbGxvdyBhIHZDUFUgbW92aW5nIGFj Y3Jvc3MgcENQVSBvZiBkaWZmZXJlbnQgdHlwZSAodGhlIGVycmF0YSBpcyBvbmUgZXhhbXBsZSku DQo+PiANCj4+IEkgYWdyZWUgYW5kIHRoaXMgaXMgd2h5IFhlbiBpcyB0YWludGVkLg0KPj4gDQo+ Pj4gDQo+Pj4+IEFuIG90aGVyIHNvbHV0aW9uIHdvdWxkIGJlIHRvIGRpc2NhcmQgdGhpcyBwYXRj aCBmcm9tIHRoZSBzZXJpZSBmb3Igbm93IHVudGlsDQo+Pj4+IEkgaGF2ZSB3b3JrZWQgYSBwcm9w ZXIgc29sdXRpb24gZm9yIHRoaXMgY2FzZS4NCj4+Pj4gU2hvdWxkIHdlIGRpc2NhcmQgb3IgbWVy Z2Ugb3IgZG8geW91IGhhdmUgYW4gb3RoZXIgaWRlYSA/DQo+Pj4gUGxlYXNlIGNvcnJlY3QgbWUg aWYgSSBhbSB3cm9uZywgYXQgdGhlIG1vbWVudCwgaXQgZG9lc24ndCBsb29rIGxpa2UgdGhpcyBw YXRjaCB3aWxsIGJlIHBhcnQgb2YgdGhlIGxvbmdlciBwbGFuLiBJZiBzbywgdGhlbiBJIHRoaW5r IGl0IHNob3VsZCBiZSBwYXJrZWQgZm9yIG5vdy4NCj4+IA0KPj4gTm90IHN1cmUgaXQgZGVwZW5k cyBvbiB3aGF0IHRoZSBmaW5hbCBzb2x1dGlvbiB3b3VsZCBiZSBidXQgdGhpcyBpcyBoaWdobHkg cG9zc2libGUgSSBhZ3JlZS4NCj4+IA0KPj4+IA0KPj4+IFRoaXMgd291bGQgYWxzbyBoYXZlIHRo ZSBhZHZhbnRhZ2UgdG8gYXZvaWQgc3BlbmRpbmcgdG9vIG11Y2ggdGltZSBvbiByZXNvbHZpbmcg dGhlIGVtdWxhdGlvbiBpc3N1ZSBJIG1lbnRpb25lZCBpbiBteSBwcmV2aW91cyBhbnN3ZXIuDQo+ Pj4gDQo+Pj4gTm8gbmVlZCB0byByZXNlbmQgYSBuZXcgdmVyc2lvbiBvZiB0aGlzIHNlcmllcyB5 ZXQuIFlvdSBjYW4gd2FpdCB1bnRpbCB0aGUgcmVzdCBvZiB0aGUgc2VyaWVzIGdldCBtb3JlIGZl ZWRiYWNrLg0KPj4gDQo+PiBPaywgSSB3aWxsIHdhaXQgZm9yIGZlZWRiYWNrIGFuZCBuZXh0IHNl cmllIHdpbGwgbm90IGluY2x1ZGUgdGhpcyBwYXRjaCBhbnltb3JlLg0KPiANCj4gV291bGQgaXQg YmUgd29ydGgga2VlcGluZyBqdXN0IHRoZSBwYXJ0IHRoYXQgc2FuaXRpemVzIGN0ciwgd2l0aG91 dCBhbnkNCj4gb2YgdGhlIGVtdWxhdGlvbiBzdHVmZj8gVGhhdCB3YXkgd2UgY291bGQgc3RpbGwg ZGV0ZWN0IGNhc2VzIHdoZXJlIHRoZXJlDQo+IGlzIGEgbWlzbWF0Y2ggYmV0d2VlbiBDUFVzLCBw cmludCBhIHVzZWZ1bCBtZXNzYWdlIGFuZCB0YWludCBYZW4uDQoNClRoYXTigJlzIGEgZ29vZCBp ZGVhLCBpdCBtZWFucyByZW1vdmluZyB0aGUgZW11bGF0aW9uIHBhcnQgYW5kIGp1c3Qga2VlcCB0 aGUgc2FuaXRpemF0aW9uLg0KDQpASnVsaWVuOiB3b3VsZCB5b3UgYmUgb2sgd2l0aCB0aGF0ID8N Cg0KU2hvdWxkIEkgc2VuZCBhIHY0IG9yIHNob3VsZCB3ZSB1c2UgU3RlZmFub+KAmXMgcGF0Y2gg ZGlyZWN0bHkgaW5zdGVhZCA/DQoNCkNoZWVycw0KQmVydHJhbmQNCg0KPiANCj4gRm9yIGNsYXJp dHkgc29tZXRoaW5nIGxpa2UgdGhlIGFwcGVuZGVkLg0KPiANCj4gDQo+IGRpZmYgLS1naXQgYS94 ZW4vYXJjaC9hcm0vYXJtNjQvY3B1ZmVhdHVyZS5jIGIveGVuL2FyY2gvYXJtL2FybTY0L2NwdWZl YXR1cmUuYw0KPiBpbmRleCBiMTkzNmVmMWQ2Li5kMjQ1NmFmMmJmIDEwMDY0NA0KPiAtLS0gYS94 ZW4vYXJjaC9hcm0vYXJtNjQvY3B1ZmVhdHVyZS5jDQo+ICsrKyBiL3hlbi9hcmNoL2FybS9hcm02 NC9jcHVmZWF0dXJlLmMNCj4gQEAgLTI3NSw5ICsyNzUsNiBAQCBzdGF0aWMgY29uc3Qgc3RydWN0 IGFybTY0X2Z0cl9iaXRzIGZ0cl9pZF9hYTY0bW1mcjJbXSA9IHsNCj4gCUFSTTY0X0ZUUl9FTkQs DQo+IH07DQo+IA0KPiAtI2lmIDANCj4gLS8qIFRPRE86IHVzZSB0aGlzIHRvIHNhbml0aXplIHRo ZSBjYWNoZSBsaW5lIHNpemUgYW1vbmcgY29yZXMgKi8NCj4gLQ0KPiBzdGF0aWMgY29uc3Qgc3Ry dWN0IGFybTY0X2Z0cl9iaXRzIGZ0cl9jdHJbXSA9IHsNCj4gCUFSTTY0X0ZUUl9CSVRTKEZUUl9W SVNJQkxFLCBGVFJfU1RSSUNULCBGVFJfRVhBQ1QsIDMxLCAxLCAxKSwgLyogUkVTMSAqLw0KPiAJ QVJNNjRfRlRSX0JJVFMoRlRSX1ZJU0lCTEUsIEZUUl9TVFJJQ1QsIEZUUl9MT1dFUl9TQUZFLCBD VFJfRElDX1NISUZULCAxLCAxKSwNCj4gQEAgLTI5NCw3ICsyOTEsNiBAQCBzdGF0aWMgY29uc3Qg c3RydWN0IGFybTY0X2Z0cl9iaXRzIGZ0cl9jdHJbXSA9IHsNCj4gCUFSTTY0X0ZUUl9CSVRTKEZU Ul9WSVNJQkxFLCBGVFJfU1RSSUNULCBGVFJfTE9XRVJfU0FGRSwgQ1RSX0lNSU5MSU5FX1NISUZU LCA0LCAwKSwNCj4gCUFSTTY0X0ZUUl9FTkQsDQo+IH07DQo+IC0jZW5kaWYNCj4gDQo+IHN0YXRp YyBjb25zdCBzdHJ1Y3QgYXJtNjRfZnRyX2JpdHMgZnRyX2lkX21tZnIwW10gPSB7DQo+IAlTX0FS TTY0X0ZUUl9CSVRTKEZUUl9ISURERU4sIEZUUl9TVFJJQ1QsIEZUUl9MT1dFUl9TQUZFLCBJRF9N TUZSMF9JTk5FUlNIUl9TSElGVCwgNCwgMHhmKSwNCj4gQEAgLTYwMCw2ICs1OTYsOCBAQCB2b2lk IHVwZGF0ZV9zeXN0ZW1fZmVhdHVyZXMoY29uc3Qgc3RydWN0IGNwdWluZm9fYXJtICpuZXcpDQo+ IAkgKi8NCj4gCVNBTklUSVpFX1JFRyhkY3ppZCwgMCwgZGN6aWQpOw0KPiANCj4gKwlTQU5JVEla RV9SRUcoY3RyLCAwLCBjdHIpOw0KPiArDQo+IAlpZiAoIGNwdV9mZWF0dXJlNjRfaGFzX2VsMF8z Migmc3lzdGVtX2NwdWluZm8pICkNCj4gCXsNCj4gCQlTQU5JVElaRV9JRF9SRUcocGZyMzIsIDAs IHBmcjApOw0KPiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gvYXJtL2NwdWZlYXR1cmUuYyBiL3hlbi9h cmNoL2FybS9jcHVmZWF0dXJlLmMNCj4gaW5kZXggMTEzZjIwZjYwMS4uNmU1MWY1MzBhOCAxMDA2 NDQNCj4gLS0tIGEveGVuL2FyY2gvYXJtL2NwdWZlYXR1cmUuYw0KPiArKysgYi94ZW4vYXJjaC9h cm0vY3B1ZmVhdHVyZS5jDQo+IEBAIC0xMjcsNiArMTI3LDggQEAgdm9pZCBpZGVudGlmeV9jcHUo c3RydWN0IGNwdWluZm9fYXJtICpjKQ0KPiANCj4gICAgIGMtPmRjemlkLmJpdHNbMF0gPSBSRUFE X1NZU1JFRyhEQ1pJRF9FTDApOw0KPiANCj4gKyAgICBjLT5jdHIuYml0c1swXSA9IFJFQURfU1lT UkVHKENUUl9FTDApOw0KPiArDQo+ICAgICBhYXJjaDMyX2VsMCA9IGNwdV9mZWF0dXJlNjRfaGFz X2VsMF8zMihjKTsNCj4gI2VuZGlmDQo+IA0KPiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gvYXJtL3Nl dHVwLmMgYi94ZW4vYXJjaC9hcm0vc2V0dXAuYw0KPiBpbmRleCAzNzk4YzVhZGUwLi4zM2I3YmZi NTljIDEwMDY0NA0KPiAtLS0gYS94ZW4vYXJjaC9hcm0vc2V0dXAuYw0KPiArKysgYi94ZW4vYXJj aC9hcm0vc2V0dXAuYw0KPiBAQCAtNjI3LDcgKzYyNyw3IEBAIHN0YXRpYyB2b2lkIF9faW5pdCBz ZXR1cF9tbSh2b2lkKQ0KPiAgICAgICAgIHBhbmljKCJObyBtZW1vcnkgYmFua1xuIik7DQo+IA0K PiAgICAgLyogV2Ugb25seSBzdXBwb3J0cyBpbnN0cnVjdGlvbiBjYWNoZXMgaW1wbGVtZW50aW5n IHRoZSBJVklQVCBleHRlbnNpb24uICovDQo+IC0gICAgaWYgKCAoKGN0ciA+PiBDVFJfTDFJcF9T SElGVCkgJiBDVFJfTDFJcF9NQVNLKSA9PSBDVFJfTDFJcF9BSVZJVlQgKQ0KPiArICAgIGlmICgg KChjdHIgPj4gQ1RSX0wxSVBfU0hJRlQpICYgQ1RSX0wxSVBfTUFTSykgPT0gSUNBQ0hFX1BPTElD WV9BSVZJVlQgKQ0KPiAgICAgICAgIHBhbmljKCJBSVZJVlQgaW5zdHJ1Y3Rpb24gY2FjaGUgbm90 IHN1cHBvcnRlZFxuIik7DQo+IA0KPiAgICAgaW5pdF9wZHgoKTsNCj4gZGlmZiAtLWdpdCBhL3hl bi9pbmNsdWRlL2FzbS1hcm0vY3B1ZmVhdHVyZS5oIGIveGVuL2luY2x1ZGUvYXNtLWFybS9jcHVm ZWF0dXJlLmgNCj4gaW5kZXggNTIxOWZkM2JhYi4uY2E2ZTgyN2ZjYiAxMDA2NDQNCj4gLS0tIGEv eGVuL2luY2x1ZGUvYXNtLWFybS9jcHVmZWF0dXJlLmgNCj4gKysrIGIveGVuL2luY2x1ZGUvYXNt LWFybS9jcHVmZWF0dXJlLmgNCj4gQEAgLTI2Nyw2ICsyNjcsMTQgQEAgc3RydWN0IGNwdWluZm9f YXJtIHsNCj4gICAgICAgICByZWdpc3Rlcl90IGJpdHNbMV07DQo+ICAgICB9IGRjemlkOw0KPiAN Cj4gKyAgICAvKg0KPiArICAgICAqIENUUiBpcyBvbmx5IHVzZWQgdG8gY2hlY2sgZm9yIGRpZmZl cmVudCBjYWNoZSB0eXBlcyBvciBwb2xpY2llcyBhbmQNCj4gKyAgICAgKiB0YWludCBYZW4gaW4g dGhpcyBjYXNlDQo+ICsgICAgICovDQo+ICsgICAgc3RydWN0IHsNCj4gKyAgICAgICAgcmVnaXN0 ZXJfdCBiaXRzWzFdOw0KPiArICAgIH0gY3RyOw0KPiArDQo+ICNlbmRpZg0KPiANCj4gICAgIC8q DQo+IEBAIC0zMzksNiArMzQ3LDkgQEAgZXh0ZXJuIHN0cnVjdCBjcHVpbmZvX2FybSBzeXN0ZW1f Y3B1aW5mbzsNCj4gZXh0ZXJuIHZvaWQgaWRlbnRpZnlfY3B1KHN0cnVjdCBjcHVpbmZvX2FybSAq KTsNCj4gDQo+ICNpZmRlZiBDT05GSUdfQVJNXzY0DQo+ICsNCj4gK2V4dGVybiBib29sIG1pc21h dGNoZWRfY2FjaGVfdHlwZTsNCj4gKw0KPiBleHRlcm4gdm9pZCB1cGRhdGVfc3lzdGVtX2ZlYXR1 cmVzKGNvbnN0IHN0cnVjdCBjcHVpbmZvX2FybSAqKTsNCj4gI2Vsc2UNCj4gc3RhdGljIGlubGlu ZSB2b2lkIHVwZGF0ZV9zeXN0ZW1fZmVhdHVyZXMoY29uc3Qgc3RydWN0IGNwdWluZm9fYXJtICpj cHVpbmZvKQ0KPiBkaWZmIC0tZ2l0IGEveGVuL2luY2x1ZGUvYXNtLWFybS9wcm9jZXNzb3IuaCBi L3hlbi9pbmNsdWRlL2FzbS1hcm0vcHJvY2Vzc29yLmgNCj4gaW5kZXggMjU3N2U5YTI0NC4uOGM5 ODQzZTEyYiAxMDA2NDQNCj4gLS0tIGEveGVuL2luY2x1ZGUvYXNtLWFybS9wcm9jZXNzb3IuaA0K PiArKysgYi94ZW4vaW5jbHVkZS9hc20tYXJtL3Byb2Nlc3Nvci5oDQo+IEBAIC03LDkgKzcsMjEg QEANCj4gI2luY2x1ZGUgPHB1YmxpYy9hcmNoLWFybS5oPg0KPiANCj4gLyogQ1RSIENhY2hlIFR5 cGUgUmVnaXN0ZXIgKi8NCj4gLSNkZWZpbmUgQ1RSX0wxSXBfTUFTSyAgICAgICAweDMNCj4gLSNk ZWZpbmUgQ1RSX0wxSXBfU0hJRlQgICAgICAxNA0KPiAtI2RlZmluZSBDVFJfTDFJcF9BSVZJVlQg ICAgIDB4MQ0KPiArI2RlZmluZSBDVFJfTDFJUF9NQVNLICAgICAgIDB4Mw0KPiArI2RlZmluZSBD VFJfTDFJUF9TSElGVCAgICAgIDE0DQo+ICsjZGVmaW5lIENUUl9ETUlOTElORV9TSElGVCAgMTYN Cj4gKyNkZWZpbmUgQ1RSX0lNSU5MSU5FX1NISUZUICAwDQo+ICsjZGVmaW5lIENUUl9JTUlOTElO RV9NQVNLICAgMHhmDQo+ICsjZGVmaW5lIENUUl9FUkdfU0hJRlQgICAgICAgMjANCj4gKyNkZWZp bmUgQ1RSX0NXR19TSElGVCAgICAgICAyNA0KPiArI2RlZmluZSBDVFJfQ1dHX01BU0sgICAgICAg IDE1DQo+ICsjZGVmaW5lIENUUl9JRENfU0hJRlQgICAgICAgMjgNCj4gKyNkZWZpbmUgQ1RSX0RJ Q19TSElGVCAgICAgICAyOQ0KPiArDQo+ICsjZGVmaW5lIElDQUNIRV9QT0xJQ1lfVlBJUFQgIDAN Cj4gKyNkZWZpbmUgSUNBQ0hFX1BPTElDWV9BSVZJVlQgMQ0KPiArI2RlZmluZSBJQ0FDSEVfUE9M SUNZX1ZJUFQgICAyDQo+ICsjZGVmaW5lIElDQUNIRV9QT0xJQ1lfUElQVCAgIDMNCj4gDQo+IC8q IE1JRFIgTWFpbiBJRCBSZWdpc3RlciAqLw0KPiAjZGVmaW5lIE1JRFJfUkVWSVNJT05fTUFTSyAg ICAgIDB4Zg0KDQo= From xen-devel-bounces@lists.xenproject.org Mon Sep 06 08:31:18 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Sep 2021 08:31:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.179476.325756 (Exim 4.92) (envelope-from ) id 1mNA29-0004U6-CP; Mon, 06 Sep 2021 08:31:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 179476.325756; Mon, 06 Sep 2021 08:31:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNA29-0004Tz-88; Mon, 06 Sep 2021 08:31:17 +0000 Received: by outflank-mailman (input) for mailman id 179476; Mon, 06 Sep 2021 08:31:15 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNA27-0004Tt-3W for xen-devel@lists.xenproject.org; Mon, 06 Sep 2021 08:31:15 +0000 Received: from EUR02-AM5-obe.outbound.protection.outlook.com (unknown [2a01:111:f400:fe07::62b]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id d188a28c-ef78-4998-8dea-688d24e0d721; Mon, 06 Sep 2021 08:31:13 +0000 (UTC) Received: from DB9PR05CA0023.eurprd05.prod.outlook.com (2603:10a6:10:1da::28) by DB8PR08MB4955.eurprd08.prod.outlook.com (2603:10a6:10:38::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.23; Mon, 6 Sep 2021 08:31:07 +0000 Received: from DB5EUR03FT010.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:1da:cafe::9e) by DB9PR05CA0023.outlook.office365.com (2603:10a6:10:1da::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Mon, 6 Sep 2021 08:31:07 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT010.mail.protection.outlook.com (10.152.20.96) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Mon, 6 Sep 2021 08:31:07 +0000 Received: ("Tessian outbound 1a0c40aa17d8:v103"); Mon, 06 Sep 2021 08:31:07 +0000 Received: from 2ae092774d4a.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id B08C1D8F-5A14-4DF5-8735-7D1A131F7C4D.1; Mon, 06 Sep 2021 08:30:59 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 2ae092774d4a.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 06 Sep 2021 08:30:59 +0000 Received: from PAXPR08MB6446.eurprd08.prod.outlook.com (2603:10a6:102:12d::10) by PR3PR08MB5788.eurprd08.prod.outlook.com (2603:10a6:102:8b::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19; Mon, 6 Sep 2021 08:30:57 +0000 Received: from PAXPR08MB6446.eurprd08.prod.outlook.com ([fe80::c029:ed0:82e7:3c2f]) by PAXPR08MB6446.eurprd08.prod.outlook.com ([fe80::c029:ed0:82e7:3c2f%6]) with mapi id 15.20.4478.025; Mon, 6 Sep 2021 08:30:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d188a28c-ef78-4998-8dea-688d24e0d721 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9aXBdmofQAsnNEK7ex5fwtBRjD0v15b+Jrmhf2x2xRg=; b=zSXe527rxXA/jU5csRzONoV3jFb+ms7GOEmXE4UGkGhAiOvRJfOHWet8JEihUl01agm55hJJ2a5b1TWzdjOIGttJXPIwaQgwDpwhO3xAVFo/9TCFksuZ6x+EXccRIK+OS79jD224VhG1N4JEidDWWgbU9hBYIajwDFhngs+rtL4= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: 55ccc14e93903f37 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bi9vdWf6Ov5vRQAnSVzECFRi4N7Z9i2F5SS47UpfJCmS/LZ6Z3oz1kN/k4PDlpPzmkVEN0ry2cnRCGN5CZGidk0Otj3zpZtYb9zDn8i3uwMHcGwFg5zR4Jg8GZjzTSwsle98SNKumfHf/gR13ImI+NAn2HoL2DVAGzzNTvTLROgDv42xE07YGglSmUuL/5XfHw0oUWGa8SlUAQsQxZxkrtdlV/KxvO7PkbY6jSB3NSh9wNaY1Fis9mMnpFvuvHmWo/KOPWBTjmCEGj4qZoPjrVHiDnkMdILXnBU5K97uJnDTQ6PQgcgwDWMkb7Ue2yHufC+HaWE8GztMuPP/KiyJrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=9aXBdmofQAsnNEK7ex5fwtBRjD0v15b+Jrmhf2x2xRg=; b=Jrl3DPwPhNUFpzLuD9/TynUeyHLAJVkbo4yCMVVFpBWMiY2n2NhfUo2FOk1/Syr49CrUuSyLGWlNcecu2NDdq1kNH3a4QodoCwvejupt3dQjDKSUmycHz5tRsZAxe+QfR+FMudne0H1oWoo+skt7LGdx/Ux5vcFLArmHcSFh/tR+fpMhY4Q+HXMMD4a+6H5soOOL+cJwAa3Zb1KhMICizw1oRFO/SQ5GrfropCK0BpXwW3QkmTb8L/dVvYYBRp0E8vxFGsAlicb5hb+5YD3rsPB2wa834ZY0DWpH2Z/81T1wTpo41GRWDYmLNZTH9mic8Mq7mfgt3v5vM4F88Fc1OQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9aXBdmofQAsnNEK7ex5fwtBRjD0v15b+Jrmhf2x2xRg=; b=zSXe527rxXA/jU5csRzONoV3jFb+ms7GOEmXE4UGkGhAiOvRJfOHWet8JEihUl01agm55hJJ2a5b1TWzdjOIGttJXPIwaQgwDpwhO3xAVFo/9TCFksuZ6x+EXccRIK+OS79jD224VhG1N4JEidDWWgbU9hBYIajwDFhngs+rtL4= From: Bertrand Marquis To: Juergen Gross CC: Xen-devel , Julien Grall , Stefano Stabellini , Dario Faggioli Subject: Re: Crash when using cpupools Thread-Topic: Crash when using cpupools Thread-Index: AQHXoNo0twqKn1RLAkCotEsfXja8k6uWr0+AgAACAYA= Date: Mon, 6 Sep 2021 08:30:56 +0000 Message-ID: <626655D0-D7C5-457D-A99E-EF5CEDFD188D@arm.com> References: <5b0a4530-72df-a186-9bd5-50759b3dd151@suse.com> In-Reply-To: <5b0a4530-72df-a186-9bd5-50759b3dd151@suse.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3654.120.0.1.13) Authentication-Results-Original: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=arm.com; x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: 996d2d14-9b48-4b1a-2c2b-08d97110ac47 x-ms-traffictypediagnostic: PR3PR08MB5788:|DB8PR08MB4955: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:8882;OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: N8woIjHFwJGhpXrfpGLmo9p40k/Okp0NOcelnIhi1S2atsc+3L0fw1Xk+7UxbVtp4tYOQFfJrCKFzZPMPyN6MweW1ad+bT9LOZOm+4ECPt3PwUGD8QJ6WHzcNmpfHwy+UT7ADUmbep984RnDjStLHX2TlwCmlRNY7h2YY87rNQh5OqC+UkP+KR+Ao8RGjfMan7AqXFRQwpryRk5WA2WJtutyJupYJba6OTiLz5rLkUMXiP8y2yZ7dgN2R5pfmkQUbKUoeL2xkJaW25a99kKE3isLVxc8EMxqNmmWGArM1GOo8+W3mpso2/fAxSuenLDbqN5vZtv8panOwLnOTJMee43jV/Z3nr26pCqGf+gvNYjk8Ong5HdNsN9tx5gGjAhsDKBbyQnxxEdNupUGPKwKjYj59inq1e8vyDVGAMBiYOIS0ThYUekdSAzD1jipFb0PFQe1zCFKgVAFTQHB8/J/d0TVNdwNNEqRt2VUTVD2N4/lJc6V3el8uRAM9D1GPub8mjvTFE+newU/KUvF6WXBcwzB+tdbfHlMFJbTaJR+XdHGhyg6SxFyRyJdpe84HPnNpo2U1NAdha43oaKSq5hYrcf0y8bje6w8W1Jxl8eiYNHHeQlNB5ByXU14LaCQrU/yF5AeHVprspLWLLLkSMoem3NszZxu+Qbf4FB3mrncZo1O2XM4RWTgxBsevZmP1F+LZganvlwEhBiUZgKfopF5UR00mDOo8y7uJXcRjiF+Hu6F3HZvusa0YgjVHWhntu0M X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB6446.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(136003)(366004)(39860400002)(396003)(376002)(71200400001)(6916009)(186003)(4326008)(33656002)(26005)(86362001)(3480700007)(478600001)(36756003)(6512007)(6486002)(2616005)(316002)(5660300002)(54906003)(122000001)(38070700005)(2906002)(83380400001)(8676002)(8936002)(38100700002)(66556008)(66476007)(6506007)(66446008)(64756008)(66946007)(53546011)(91956017)(76116006)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?NjZkd2UvMW04ZUFEOTE2cHFLREtJTWpVTkxpTnVPMDVUMEwzZHFuSzliMFdn?= =?utf-8?B?U1BGVWlFR28vMXMrMXBLUkFaeFpHaDRrOFR0U3Y0VldJQlRmYUNmZDZ0M1Ix?= =?utf-8?B?bXUrK3ZQVTB4bnpDbEh4RTBybVVnQklFTzVnZ3VDZ2poaE1IQTZjemdUbnR3?= =?utf-8?B?T2xUbnJ6VmFBQ3ZwMGtod004cjdraFcyeEpFZGs5eWJxOStmalpzcHo0eVl6?= =?utf-8?B?SnNKcXNLOUVoUWc2Uzl5b2NFaS96TlVpSFg5dUNWTmNHbWRNbkRIL3o5dW1j?= =?utf-8?B?S1o3Qk9QVWtUNTNvOUZ1dEpCOTl4RWh6OVRHd3FRWDh3Z1Z0SFZqTjEwZENn?= =?utf-8?B?SEd6cXB6b28vTU1PeUI4MVVvV2JCZnRVaTBxZGhUaEI4MkprbFZLQzYyNnFl?= =?utf-8?B?MGVlRTM5Q3BaM3hJMDJqS2RsRWRwM1lFbGM5YnpIclFtYUVaZzRvQytiZ0la?= =?utf-8?B?RjE5M3hSZmxVc29LRHltek42WWNraFBBbUE2c0cwWW9BdFBLRVFMdnZncHFi?= =?utf-8?B?WEtVZGlXZUpLWkxPRmppY0UrRHRQbzd2cHptYlZWeUQ2MjBRQnZ1dktobmJB?= =?utf-8?B?ODFCNUdSY0ZJYXFUeXN4KzBvMTE5UUNUYWVMcVVCcU16WTBkN2RidXVjSlQ2?= =?utf-8?B?eVdkbTlhUUVnVGJzMHptNUNlbkR5dW9uTEVTL3Z3Z2V1V0IxYjJsUWx0TS9p?= =?utf-8?B?ODI0L1pSM0lrVzl3a2tKMUkya20xNDVtZTJYcWZYOUVlNzVyOTBZYkJoRWJt?= =?utf-8?B?MGN2THBTUVhqNDR2akc2SWxaOXprVnRXQjA1bGJrbWI2Vll1VktTY2VLelNE?= =?utf-8?B?V1dJMU9aMk9DM2dmRWcyOVFPd3JFdGVrNld5RTRKZ0J2WGNSYlRQK1RoRVNT?= =?utf-8?B?MlMrK3RmckZxaU0zQTMxUzF4dTg1bkpTZnlQdTQ3T2NPQzloaytIa29uT3Fz?= =?utf-8?B?ZThid1RxUVNaTnppSUNabmJUUi9SSUFWWDI4SVdVOUxZbk1QVndIWmVIQnB6?= =?utf-8?B?Z3RJN2RqWGk2aUNDTmNUQTcxbFJoVHkrQzc5cUZQN3JVcVFDNHhkS2l3WHBj?= =?utf-8?B?dit4ZG1Ka3lxZTQraGFyeWpxSUd3YWxtTHYrYmtWMm5LRm1yNFZZN01Ob2RI?= =?utf-8?B?N0x0WDJmeWV0MDRxeWUwelhuY1EvalFzUnpiWTdvaWtoeFl6US9DQlpZQ3h1?= =?utf-8?B?K2ZYOVZzUEZqd292cTIxZTA2RWJiZ1lUeHNCanhsM0ZnU0FGandML0MvemFC?= =?utf-8?B?OGFPZlVjNjBSTTY3b1BaK0MwUjY4Zkh0RGNySHlHOG5EQUh1eko2NTA2d3Rm?= =?utf-8?B?TDBGRUNmbDkzU2ZoZHJ6Zy9Jd2U3WURoeVQ4UXU0dng4emVmQmxZa0VCODEz?= =?utf-8?B?WnFLVTRJbW5rQnFLV3NmcDBWMkZIOXV6VGlPYXJpNGE4Z3V6ZVRnakpvRU5O?= =?utf-8?B?SWI3MDFEeGY4U0pJQmI4NkhSOUlsb2dDWkNMZFZuemVNMjhGTVJuKzYrM1FN?= =?utf-8?B?S3VSUVFmVE1maE9MeTdVUGRKY2xHR1hvWDJvZzZYR2FrYldDa21uMDhGeXdI?= =?utf-8?B?MmVMdk92bk1KdGFnSndydnNKcGpwQVhxL3dqUWxYNm9BQjlUbGpTWkdHSHZU?= =?utf-8?B?ZEt1Y1FkVHBWdnord0lPenBuaXpMK0U0c0hwRnRpd3ZRVzZnQ2JyTndpODRF?= =?utf-8?B?d3BscEpHRUhqZ1B4cWVFMW9SUW5tRGkwNWpJVld2QXBuUjlEaXBsNmpvWnA5?= =?utf-8?Q?lkoLZ0LAJwJ+LwXb2Olp5aRnNUnCL4UbFqc2AUt?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR08MB5788 Original-Authentication-Results: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT010.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: f67df28d-40af-495d-791f-08d97110a61a X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9K++IhcLfoof8o5dj2M2RwbKrPwZc+98zGvANYHwyIYUKlBBR3Fa2QON5gW/+s49ACthN8KLHPGiWyxy15J8b7s3TmguHXSci05aRAKULNHPIRVWh5wqvJYVn/2SQoUp8xTxD6y3r92iEaiUEAjwpnVPRExShdPgJMTbpdHZEIuMvVQhCGJnekwn+DfAQBmCD8fDVHgkwOUAHdC6e4bio72EBNDnLfinbmY4b0k+Ig4OLjCdxBMTeBCDZom0+gnoPZHXYWYGEPhHqEYJ512RQccS4vvyPh2YhQqeg9HOxzc3Msd36hbQ5gWFQJMfHQkiOubrEl0ptRm/7oGv8VNt5ZW78D/zclB5uR1wIPeZUbtwaG7BUme2DXq4EVPaAumd9YW4YwUfNP/ZmAuF3AplCW4D7oqfDhb471DVabd2e8qFeE3LOePUBDRXTeJmsXB8+pCLlc4Msivk8uWwreS+eyEujRZONWUcjlFtKrjVqPSUg4uPSyESY6vILV2VsoePUAlVcxNj0cld/0jQ89tkEseih/A4c4GjV0LLydi1QHemxCqoWQoSJtzA+tJm9X7OCRAtamscgb35wZqCsPvgpJPNjkr312kfLMvlm5qBmeLPSI0RDWHi+GYo4TCOq860xm3RmBmE77Y72HKOJidyWZ0uhDa4FluATPDqaEh/oT3zhjpEsaeYHbXhTl7E0lvtJqj64Nq4c9HCrwCQx0dDUQ== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(346002)(376002)(396003)(136003)(39860400002)(46966006)(36840700001)(26005)(478600001)(70206006)(86362001)(356005)(6506007)(6862004)(316002)(53546011)(54906003)(82310400003)(36756003)(81166007)(82740400003)(47076005)(107886003)(3480700007)(2616005)(83380400001)(2906002)(6512007)(36860700001)(6486002)(8936002)(8676002)(5660300002)(186003)(33656002)(336012)(70586007)(4326008);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2021 08:31:07.3206 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 996d2d14-9b48-4b1a-2c2b-08d97110ac47 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT010.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB4955 SGkgSnVlcmdlbiwNCg0KPiBPbiA2IFNlcCAyMDIxLCBhdCAwOToyMywgSnVlcmdlbiBHcm9zcyA8 amdyb3NzQHN1c2UuY29tPiB3cm90ZToNCj4gDQo+IE9uIDAzLjA5LjIxIDE3OjQxLCBCZXJ0cmFu ZCBNYXJxdWlzIHdyb3RlOg0KPj4gSGksDQo+PiBXaGlsZSBkb2luZyBzb21lIGludmVzdGlnYXRp b24gd2l0aCBjcHVwb29scyBJIGVuY291bnRlcmVkIGEgY3Jhc2ggd2hlbiB0cnlpbmcgdG8gaXNv bGF0ZSBhIGd1ZXN0IHRvIGl0cyBvd24gcGh5c2ljYWwgY3B1Lg0KPj4gSSBhbSB1c2luZyBjdXJy ZW50IHN0YWdpbmcgc3RhdHVzLg0KPj4gSSBkaWQgdGhlIGZvbGxvd2luZyAob24gRlZQIHdpdGgg OCBjb3Jlcyk6DQo+PiAtIHN0YXJ0IGRvbTAgd2l0aCBkb20wX21heF92Y3B1cz0xDQo+PiAtIHJl bW92ZSBjb3JlIDEgZnJvbSBkb20wIGNwdXBvb2w6IHhsIGNwdXBvb2wtY3B1LXJlbW92ZSBQb29s LTAgMQ0KPj4gLSBjcmVhdGUgYSBuZXcgcG9vbDogeGwgY3B1cG9vbC1jcmVhdGUgbmFtZT1cIk5l dFBvb2xc4oCdDQo+PiAtIGFkZCBjb3JlIDEgdG8gdGhlIHBvb2w6IHhsIGNwdXBvb2wtY3B1LWFk ZCBOZXRQb29sIDENCj4+IC0gY3JlYXRlIGEgZ3Vlc3QgaW4gTmV0UG9vbCB1c2luZyB0aGUgZm9s bG93aW5nIGluIHRoZSBndWVzdCBjb25maWc6IHBvb2w94oCcTmV0UG9vbCINCj4+IEkgZW5kIHdp dGggYSBjcmFzaCB3aXRoIHRoZSBmb2xsb3dpbmcgY2FsbCB0cmFjZSBkdXJpbmcgZ3Vlc3QgY3Jl YXRpb246DQo+PiAoWEVOKSBYZW4gY2FsbCB0cmFjZToNCj4+IChYRU4pICAgIFs8MDAwMDAwMDAw MDIzNGNiMD5dIGNyZWRpdDIuYyNjc2NoZWQyX2FsbG9jX3VkYXRhKzB4NTgvMHhmYyAoUEMpDQo+ PiAoWEVOKSAgICBbPDAwMDAwMDAwMDAyMzRjODA+XSBjcmVkaXQyLmMjY3NjaGVkMl9hbGxvY191 ZGF0YSsweDI4LzB4ZmMgKExSKQ0KPj4gKFhFTikgICAgWzwwMDAwMDAwMDAwMjQyZDM4Pl0gc2No ZWRfbW92ZV9kb21haW4rMHgxNDQvMHg2YzANCj4+IChYRU4pICAgIFs8MDAwMDAwMDAwMDIyZGQx OD5dIGNwdXBvb2wuYyNjcHVwb29sX21vdmVfZG9tYWluX2xvY2tlZCsweDM4LzB4NzANCj4+IChY RU4pICAgIFs8MDAwMDAwMDAwMDIyZmFkYz5dIGNwdXBvb2xfZG9fc3lzY3RsKzB4NzNjLzB4Nzgw DQo+PiAoWEVOKSAgICBbPDAwMDAwMDAwMDAyMmQ4ZTA+XSBkb19zeXNjdGwrMHg3ODgvMHhhNTgN Cj4+IChYRU4pICAgIFs8MDAwMDAwMDAwMDI3M2I2OD5dIHRyYXBzLmMjZG9fdHJhcF9oeXBlcmNh bGwrMHg3OC8weDE3MA0KPj4gKFhFTikgICAgWzwwMDAwMDAwMDAwMjc0ZjcwPl0gZG9fdHJhcF9n dWVzdF9zeW5jKzB4MTM4LzB4NjE4DQo+PiAoWEVOKSAgICBbPDAwMDAwMDAwMDAyNjA0NTg+XSBl bnRyeS5vI2d1ZXN0X3N5bmNfc2xvd3BhdGgrMHhhNC8weGQ0DQo+PiBBZnRlciBzb21lIGRlYnVn Z2luZyBJIGZvdW5kIG91dCB0aGF0IHVuaXQtPnZjcHVfbGlzdCBpcyBOVUxMIGFmdGVyIHVuaXQt PnZjcHVfbGlzdCA9IGQtPnZjcHVbdW5pdC0+dW5pdF9pZF07IHdpdGggdW5pdF9pZCAwIGluIGNv bW1vbi9zY2hlZC9jb3JlLmM6Njg4DQo+PiBUaGlzIG1ha2VzIHRoZSBjYWxsIHRvIGlzX2lkbGVf dW5pdCh1bml0KSBpbiBjc2NoZWQyX2FsbG9jX3VkYXRhIHRyaWdnZXIgdGhlIGNyYXNoLg0KPiAN Cj4gU28gdGhlcmUgaXMgbm8gdmNwdSAwIGluIHRoYXQgZG9tYWluPyBIb3cgaXMgdGhpcyBwb3Nz aWJsZT8NCg0KTm8gaWRlYSwgSSB3aWxsIG5lZWQgdG8gZGlnIGRlZXBlciBhcyB0aGUgc3RhdGUg SSBjb21lIHRvIGRvZXMgbm90IG1ha2Ugc2Vuc2UuDQoNCkNvdWxkIHlvdSBqdXN0IGNvbmZpcm0g dGhhdCBteSBvcGVyYXRpb25zIGFyZSByaWdodCBhbmQgdGhpcyBzaG91bGQgd29yayBiZWZvcmUg SSBzdGFydCBkaWdnaW5nID8NCg0KQ2hlZXJzDQpCZXJ0cmFuZA0KDQo+IA0KPiANCj4gSnVlcmdl bg0KPiA8T3BlblBHUF8weEIwREU5REQ2MjhCRjEzMkYuYXNjPg0KDQo= From xen-devel-bounces@lists.xenproject.org Mon Sep 06 08:46:34 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Sep 2021 08:46:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.179491.325767 (Exim 4.92) (envelope-from ) id 1mNAGq-0006HH-Ur; Mon, 06 Sep 2021 08:46:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 179491.325767; Mon, 06 Sep 2021 08:46:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNAGq-0006HA-Pf; Mon, 06 Sep 2021 08:46:28 +0000 Received: by outflank-mailman (input) for mailman id 179491; Mon, 06 Sep 2021 08:46:28 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNAGp-0006H4-U2 for xen-devel@lists.xenproject.org; Mon, 06 Sep 2021 08:46:28 +0000 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id ead0f9aa-0eee-11ec-b09c-12813bfff9fa; Mon, 06 Sep 2021 08:46:26 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ead0f9aa-0eee-11ec-b09c-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1630917986; h=to:cc:references:from:subject:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=YJpL75vOv1uu/c6yyOoRd6o8Efhvw6/U6AAGNgCeSJ0=; b=F/KM+AoXPwZwIC9G/kHJvBQHQX0VfK2KRTstCdtcs5hA4FYoKcujqTVJ IuLI0HebM9DG4GcChA+kzP8rkEatO/F5cRpaccgigxWyB+esElLq9kEkF 1XbkcWwgLNduaCsPCbecYEyshsQM9YtaJfwABVNPals4HUQYGrl5eU4Fu 0=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: 0z+8TH3Pv/VgxCy7RjjW41oHdfRa/etgPAXFg1ex0PctC0AC6QIvnDhavS2YfEVAxw0HUrC2w7 3P6VQDowWhJJMAzL6di+qjBS4vjhFAtkZeysFbAuM0ma50jDOhQfqkCqESqxNkjOEYxKygP1hK 1WLR3IrOiH2bw6GosjdmnSXpoz+/Vn2Tg6vEueVPdmBDHdOMVNdHKpUh+XkijYELUhwPKAxPKl 5aQFVv4fCIO5nc7+67s1rMEUBctBkfFEl9SOsn2Hcuz/qwgPwj6GXlI9kTvg7OkkvhCsfx7yGi B1NLcweEKgHK1UtSxrx17igz X-SBRS: 5.1 X-MesageID: 51680239 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:ByibLqjJ+5mQBR2jh3RrPltxQXBQX0h13DAbv31ZSRFFG/FwyP rBoB1L73DJYWgqNE3I+erhBEGBKUmskaKdkrNhQ4tKOzOWx1dATbsSkbcKpgeAJ8SQzJ8n6U 4NSdkZNDS0NykGsS+Y2njKLz9D+qj+zEnAv463pB0BPGIaCdAT0+46MHf9LqQffng3OXNTLu vk2iMonUvERZ1aVLXAOpFTNNKz1uEj2aiWLSIuNloC0k2jnDmo4Ln1H1yx2QofaSpGxfMH/X LemwL0y62/u7XjoyWsmVP73tBzop/M29FDDMuDhow8LSjtsB+hYMBEV6eZtD44jemz4BIBkc XKoT0nI8NvgkmhMV2dkF/I4U3NwTwu43jtxRuxhmbim9XwQHYAB89IletiA1DkwntlmOs5/L NA3mqfuZYSJwjHhj7B69/BUAwvvlaooFI5+NRjzEB3YM87Uvt8vIYf9ERaHNMrByTh8r0qF+ FoEYX1+OtWS1WHdHrU11MfgOBEZk5DWytuf3Jy/vB8i1Nt7TdEJgojtY0id047hdAAo8Iu3Z WDDkxq/Is+BvP+I5gNXdvpevHHflAldyi8eV56EW6XYZ3vBEi93KIfwI9Frt1CK6Z4gafbpv z6ISVlXCgJChrTNfE= X-IronPort-AV: E=Sophos;i="5.85,271,1624334400"; d="scan'208";a="51680239" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Al5qySRNiilD8T4leYlpt+sy8m8JPRx5uwqCjR2AJ57DH206eyitVZ/yiGF3L1woOVwJMZ9s3GGOsFucXzKWdaU6qIO0jU7vrbvlgpgOndDZvDAVXbpuc09JKLdeOF/UE1XrXQIselVanaUp9lDw50tk5bVt8jR03DTza3tuLTOj1iLB7b5YRiTCocKm18blCQjpoCXewVUdrRU64ZIBnG0nQFeMdDQLahqP9JnFS+xOQEaNKcm/aKypTJ5771s7NZDvGgkwIhPbq6/V8+unoj82iJVbTdfSnAbpkXzxwJjsauDndECmqjdLkRa0zQQO1/Cslfzlm+Sg2Fk+gcrDmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=YJpL75vOv1uu/c6yyOoRd6o8Efhvw6/U6AAGNgCeSJ0=; b=D4M6qXOaR05hOFyZ5mjVUD2Gbqj/SqgLd3O2MQ9C2uhSjzki0U4sKrgakyTovAav9liZxUa1c8nAg6micPXQPPSTUxaqE+i3GTl7JvJDJlT5YlxaG5hrOF5YpRPM7VE5Iy2PcdFMuaKSUBF9eU8A/KORWE6jBgp10mgNuYT/lPGlvcaw7U1aWXNruSA+D0D/7E5KGpwjJssOAKAEK2RkdIkeL7zfgoR2opMkeGdHWZy0b0RUtstToMKX+6UPcNbPfrURSKiWvjpYAjOlywxumeNC14hEu6znZ8MNIa6g8M9vbBR57OtP9kYwZx2Ugi2ztCAVeH+7N6DswuedMeg9Bg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YJpL75vOv1uu/c6yyOoRd6o8Efhvw6/U6AAGNgCeSJ0=; b=CqsTUhvP+CsCJiLGTnc9u0xa585YmgzJRpJaoE0dd1ln0FRX3ZLY/s2czt+rV/mROxBfWJI6zeitHMYp0TeEAatsGtaiohxKl19iYJTNVsoRgvM0aUwZBdCg872wlFOfoxO0UYUcXd9Qsfb7bHaXSXf2SwmgYoWRiaNS5pG8liM= To: Juergen Gross , Bertrand Marquis , Xen-devel CC: Julien Grall , Stefano Stabellini , Dario Faggioli References: <5b0a4530-72df-a186-9bd5-50759b3dd151@suse.com> From: Andrew Cooper Subject: Re: Crash when using cpupools Message-ID: Date: Mon, 6 Sep 2021 09:46:13 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 In-Reply-To: <5b0a4530-72df-a186-9bd5-50759b3dd151@suse.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: en-GB X-ClientProxiedBy: LNXP265CA0072.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:5d::36) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8df172f7-ae1b-45b4-5282-08d97112cc3c X-MS-TrafficTypeDiagnostic: SJ0PR03MB5437: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: DPXAKvFhAiDVtkNA9WklNP1J5rWIiz+Xfwl2ZzT5/9YAdJooeKf1zmOzbBAfrC7oOWYEGc/eOef3XKczWHNaKjvhp8bqDZXib/7rKKwvdpgjMj29pA/Jmd+jQXxmpTZLyd45qI5xveouN2yQDlig2P0CdLuRtfT16guTZVwnJonrY+vvoXCAXu8LGxZxV4UEc4syOkCIYKcS1MM90ujfHjZW24vXgyy2vnIeWjAUk9eqVfD0okDu7COQRl+iHR7j0isHuNuUKCBnC0XSfMtX1ZJFqNS/uOi3VmfZNWi4WE9oZRcRdvr/GFraQ/b0pqAy2tmwQoUPr+FdiTAe+YHHUl7DfLuTLli2vl3E1CvIYFp7knkduRPkXgX0iQw1cpVJZQya5VMyjLlVX1hYs1piXN6tXTptbwhMOcxjDXhGcjOX+De1mx3/9ow/ZNy0XLomRuIoyEihyAy+mNx4SM4kqAtder4dA0PNGAU5hpIBK9/tgslMUS7h13wslR5KbIR16QdnIJ49llNMVW4qV9yRxdL4DiIOVMCuAgZfjU/1eMvU5+U9DHY5pmaF6v60nbxRNyW23+na58LO7Y6iY8kduiwAFp4B1GfksfIBjRhZWGTGwKcMRLVt35THGNeratr+rkJDALPpAOOdS7nAwXdT2kQUDd5MSzt6awE521xZ94qJm0p+7XygGSOYs0gi7RMEow/AbxqUkX7JpMQ9CYiQxCW5k+C7IP694LPKptWWf3M= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(39860400002)(376002)(136003)(366004)(346002)(31696002)(53546011)(26005)(186003)(316002)(38100700002)(86362001)(55236004)(478600001)(4326008)(2616005)(6486002)(2906002)(110136005)(83380400001)(54906003)(956004)(8936002)(6666004)(3480700007)(31686004)(8676002)(66556008)(66476007)(66946007)(16576012)(36756003)(5660300002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Wm9DK0ZFc3h3U0IweHBNM0dPODFjMGJjR29NVU4rWUtqNFJGWkc4VThqWWhK?= =?utf-8?B?OERSK2h3WFFZdWZXV3E1U1FaUWh2NjRKa1piVTk4bXQ3SlBoRGpaUHdxVEtV?= =?utf-8?B?T3E3bm5iTndPQkN5MlQ0TjRKVnpoTXBrTittdU9HTkhrejZOREJmU2JKb1NK?= =?utf-8?B?cUIwUklRb3BDdXdGTW10L2dybnd4eDhNTnBwYktzdGYxZ1VLOWQxek1vN21F?= =?utf-8?B?Rk9VVGZvY1RIRFZYNmtqMWNyTUprSnFBKzlIZGQzU052UWN3MmN0QmJxanlw?= =?utf-8?B?ME1KUms5Sm1xTFNDUWdHaHdxeUF5ZmRvaGJYcXEyUFNRRFI0bjhRTE51eGJW?= =?utf-8?B?L1JOdjFPMysxUEpvVHlDaCtaVittbFkyS29zZkEwaS9UTHk1QWtsVlZIdlNt?= =?utf-8?B?cXBzRlFlL1dVVlNZQVFuYTJQcENadzFNL1ZPMHcxK3BLRlNLNGpqbFBzMSt5?= =?utf-8?B?bzcwSnF1VmxTWHd5OTFLMFp1SW1aRUs0RkdZMzAwQXpGTElIc3dXNUw2Qi96?= =?utf-8?B?TEQ3SHY5d0xVR1VRcWFJSmxXSGF2SVMrT0NZTEZoMmR6ZCt4U0paVVlqSXNB?= =?utf-8?B?TTdtNU5IYVdweXpBcHl6WU9ibzQzUmxybzNpWFltc2o4QkMyT1ZLRHMrTjFZ?= =?utf-8?B?T0ZEa1NXb0cxZkxxb2hxZDgxck1OQ3d0WTZDSEwrT0R2RkgzSkNsb0lTWVVB?= =?utf-8?B?VEYranlZSEtySlJaaWR5Qy9IcG93cElKN3YxbDVySmhndmtNZFJkTnUxaHpj?= =?utf-8?B?cUVhaDNFS3FlMTd1ZlY1V1VJZjBJWUpZQkNiSWVvdVBhT01oSmlRa1pva0NR?= =?utf-8?B?VnkxQ3l6ZjRsQ2IzaklNUTMwSVI1VSsyZmtVNDFjQ3ViUzVBbmFmQVVaTjlN?= =?utf-8?B?UG43UHkrd2JML3VFeG1EdC9LdEVueERoUlpGY3BoK25qdEJqSjZkajZQWERt?= =?utf-8?B?Y0tjdzhiRzlaTjVBNk1WKzhlQVlxZ3RDWXZ2NVo1MEVtNzV6U2JjeGhjR3E5?= =?utf-8?B?cTlBNE5PSjIvYWp1OGRCR3VFa3NYN1Y5YVRSNEt6eG9ZMWlWNWZ4NUdsaGNU?= =?utf-8?B?WnlMQlBWc0YwTXNFRW1ORXNmNVpaYm1ZNEpPV2xORUZKSlB5czhobjUycjlv?= =?utf-8?B?S1lQVlEzOEU1Q3VIL0wrOEZDWmpyemFNYUtZWWhDSkJra1FRN1FnVmdIdzg1?= =?utf-8?B?YktvUm5pT3NkVWlCMEc3MHVzWC9xNHNVbnQ5T1h5cTNBMjFwTmFBVzFXclZj?= =?utf-8?B?RFQxWHE5Z1lFNnRlQXZRNGh3dkZDVW92UDhQSWpSbE5IN1kwQ05ZMjh6N0J6?= =?utf-8?B?VDZNaTRzbVhlSGZlYWdtdUFIejMxL1dpUk9QbURnaHMzeHlWb3cxbkY3bTRJ?= =?utf-8?B?Y0RCWUI1TE1Ca2lLS1NxZkw4Q0pPTWVhS1oxTjkwVUJRRDIrYXg5RkVsMVBT?= =?utf-8?B?azM5di83TnI0Z1NuTWNpZEJmdVNlNGl1TnVVK0hnZnVLblduSHN6THo0eFNE?= =?utf-8?B?RnQzczc2UVcwczR2NDhrNWUwN3NuSHNHZFBITHp0aUs1TXcrYmpvMm84Y0I2?= =?utf-8?B?a2RLWkkxTE1sMXYvNldjZzhDb3YxeWYwcmMrQkVCKzlmTU9kbUE4UUZBUGNw?= =?utf-8?B?ZmJzYkNtbW9weWpxR2ViekVlcldRNDJTWGRkbXZYQXdTeFA3bUtucGk4bm5u?= =?utf-8?B?V2ZtRC90aE5uOXR5aWZVZjlBQ1VwY3BFVzg2T01DK0xLTnllZjVjaVZFY1hF?= =?utf-8?Q?8oa+g9RU4smc6oRsS1tBpuLp2GLMzuv6Tad8e6H?= X-MS-Exchange-CrossTenant-Network-Message-Id: 8df172f7-ae1b-45b4-5282-08d97112cc3c X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2021 08:46:20.1470 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: orid3NBW0Hg8Ay7PiHOLc7tnUUYbIn2KlEV4N/FVr9QdppjX8KRZ0T1txRJPmaXx41a532IZyLZd1REvu4ebevO7u6kbV2UC5mRijClQ2kY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5437 X-OriginatorOrg: citrix.com On 06/09/2021 09:23, Juergen Gross wrote: > On 03.09.21 17:41, Bertrand Marquis wrote: >> Hi, >> >> While doing some investigation with cpupools I encountered a crash >> when trying to isolate a guest to its own physical cpu. >> >> I am using current staging status. >> >> I did the following (on FVP with 8 cores): >> - start dom0 with dom0_max_vcpus=3D1 >> - remove core 1 from dom0 cpupool: xl cpupool-cpu-remove Pool-0 1 >> - create a new pool: xl cpupool-create name=3D\"NetPool\=E2=80=9D >> - add core 1 to the pool: xl cpupool-cpu-add NetPool 1 >> - create a guest in NetPool using the following in the guest config: >> pool=3D=E2=80=9CNetPool" >> >> I end with a crash with the following call trace during guest creation: >> (XEN) Xen call trace: >> (XEN)=C2=A0=C2=A0=C2=A0 [<0000000000234cb0>] credit2.c#csched2_alloc_uda= ta+0x58/0xfc >> (PC) >> (XEN)=C2=A0=C2=A0=C2=A0 [<0000000000234c80>] credit2.c#csched2_alloc_uda= ta+0x28/0xfc >> (LR) >> (XEN)=C2=A0=C2=A0=C2=A0 [<0000000000242d38>] sched_move_domain+0x144/0x6= c0 >> (XEN)=C2=A0=C2=A0=C2=A0 [<000000000022dd18>] >> cpupool.c#cpupool_move_domain_locked+0x38/0x70 >> (XEN)=C2=A0=C2=A0=C2=A0 [<000000000022fadc>] cpupool_do_sysctl+0x73c/0x7= 80 >> (XEN)=C2=A0=C2=A0=C2=A0 [<000000000022d8e0>] do_sysctl+0x788/0xa58 >> (XEN)=C2=A0=C2=A0=C2=A0 [<0000000000273b68>] traps.c#do_trap_hypercall+0= x78/0x170 >> (XEN)=C2=A0=C2=A0=C2=A0 [<0000000000274f70>] do_trap_guest_sync+0x138/0x= 618 >> (XEN)=C2=A0=C2=A0=C2=A0 [<0000000000260458>] entry.o#guest_sync_slowpath= +0xa4/0xd4 >> >> After some debugging I found out that unit->vcpu_list is NULL after >> unit->vcpu_list =3D d->vcpu[unit->unit_id]; with unit_id 0 in >> common/sched/core.c:688 >> This makes the call to is_idle_unit(unit) in csched2_alloc_udata >> trigger the crash. > > So there is no vcpu 0 in that domain? How is this possible? Easy, depending on the order of hypercalls issued by the toolstack. Between DOMCTL_createdomain and DOMCTL_max_vcpus, the domain exists but the vcpus haven't been allocated. ~Andrew From xen-devel-bounces@lists.xenproject.org Mon Sep 06 08:48:23 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Sep 2021 08:48:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.179497.325777 (Exim 4.92) (envelope-from ) id 1mNAIh-0006tu-95; Mon, 06 Sep 2021 08:48:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 179497.325777; Mon, 06 Sep 2021 08:48:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNAIh-0006tk-6B; Mon, 06 Sep 2021 08:48:23 +0000 Received: by outflank-mailman (input) for mailman id 179497; Mon, 06 Sep 2021 08:48:22 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNAIg-0006te-6c for xen-devel@lists.xenproject.org; Mon, 06 Sep 2021 08:48:22 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNAIc-00088p-UG; Mon, 06 Sep 2021 08:48:18 +0000 Received: from 54-240-197-236.amazon.com ([54.240.197.236] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1mNAIc-0001IX-O6; Mon, 06 Sep 2021 08:48:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=qgP+hT12nMxjdDowc+pmDpM6YfKK2qq0BIsypq9S8TQ=; b=f1IymJEEkbNVWgm6AmeL9FLn2R CQNqwFkVqniWLiVKx6jxtsIHtLj3pt45extwmdqpFTEViIEKMGvDxQf6uv82ISB8odz1xU/r1AZTw p8ZZ2ChPVfjMIWp2mhug7KsZarI/nrqr3ZGc8uGr0i4PqXIExgKPsfMGwoPN/YFHKBVY=; Subject: Re: [PATCH 11/11] xen/arm: Process pending vPCI map/unmap operations To: Oleksandr Andrushchenko , Oleksandr Andrushchenko , "xen-devel@lists.xenproject.org" Cc: "sstabellini@kernel.org" , Oleksandr Tyshchenko , Volodymyr Babchuk , Artem Mygaiev , "roger.pau@citrix.com" , Bertrand Marquis , Rahul Singh References: <20210903083347.131786-1-andr2000@gmail.com> <20210903083347.131786-12-andr2000@gmail.com> From: Julien Grall Message-ID: <7da7f759-eab0-5e97-e8e4-980db5db1e79@xen.org> Date: Mon, 6 Sep 2021 09:48:16 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit On 06/09/2021 08:02, Oleksandr Andrushchenko wrote: > Hi, Julien! Hi Oleksandr, > On 03.09.21 12:04, Julien Grall wrote: >> Hi Oleksandr, >> >> On 03/09/2021 09:33, Oleksandr Andrushchenko wrote: >>> From: Oleksandr Andrushchenko >>> >>> vPCI may map and unmap PCI device memory (BARs) being passed through which >>> may take a lot of time. For this those operations may be deferred to be >>> performed later, so that they can be safely preempted. >>> Run the corresponding vPCI code while switching a vCPU. >> >> IIUC, you are talking about the function map_range() in xen/drivers/vpci/header. The function has the following todo for Arm: >> >>         /* >>          * ARM TODOs: >>          * - On ARM whether the memory is prefetchable or not should be passed >>          *   to map_mmio_regions in order to decide which memory attributes >>          *   should be used. >>          * >>          * - {un}map_mmio_regions doesn't support preemption. >>          */ >> >> This doesn't seem to be addressed in the two series for PCI passthrough sent so far. Do you have any plan to handle it? > > No plan yet. > > All the mappings are happening with p2m_mmio_direct_dev as of now. So this address the first TODO but how about the second TODO? It refers to the lack of preemption on Arm but in this patch you suggest there are some and hence we need to call vpci_process_pending(). For a tech preview, the lack of preemption would be OK. However, the commit message should be updated to make clear there are no such preemption yet or avoid to mention it. > >> >>> >>> Signed-off-by: Oleksandr Andrushchenko >>> --- >>>   xen/arch/arm/traps.c | 6 ++++++ >>>   1 file changed, 6 insertions(+) >>> >>> diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c >>> index 219ab3c3fbde..1571fb8afd03 100644 >>> --- a/xen/arch/arm/traps.c >>> +++ b/xen/arch/arm/traps.c >>> @@ -34,6 +34,7 @@ >>>   #include >>>   #include >>>   #include >>> +#include >>>     #include >>>   #include >>> @@ -2304,6 +2305,11 @@ static bool check_for_vcpu_work(void) >>>       } >>>   #endif >>>   +    local_irq_enable(); >>> +    if ( has_vpci(v->domain) && vpci_process_pending(v) ) >> >> Looking at the code of vpci_process_pending(), it looks like there are some rework to do for guest. Do you plan to handle it as part of the vPCI series? > Yes, vPCI code is heavily touched to support guest non-identity mappings I wasn't referring to the non-identity mappings here. I was referring to TODOs such as: /* * FIXME: in case of failure remove the device from the domain. * Note that there might still be leftover mappings. While this is * safe for Dom0, for DomUs the domain will likely need to be * killed in order to avoid leaking stale p2m mappings on * failure. */ You still have them after the series reworking the vPCI. As for the preemption this is OK to ignore it for a tech preview. Although, we want to at least track them. >> >>> +        raise_softirq(SCHEDULE_SOFTIRQ); >>> +    local_irq_disable(); >>> + >> >> From my understanding of vcpi_process_pending(). The function will return true if there are more work to schedule. > Yes >> However, if check_for_vcpu_for_work() return false, then we will return to the guest before any work for vCPI has finished. This is because check_for_vcpu_work() will not be called again. > Correct >> >> In this case, I think you want to return as soon as you know we need to reschedule. > Not sure I understand this The return value of check_for_vcpu_for_work() indicates whether we have more work to do before returning to return to the guest. When vpci_process_pending() returns true, it tells us we need to call the function at least one more time before returning to the guest. In your current implementation, you leave that decision to whoeever is next in the function. It is not safe to return to the guest as long as vpci_process_pending() returns true. So you want to write something like: if ( vpci_process_pending() ) return true; >> >> However, looking at the rest of the code, we already have a check for vpci in the common IOREQ code. > > Which may not be enabled as it depends on CONFIG_IOREQ_SERVER. Right. My point is when CONFIG_IOREQ_SERVER is set then you would end up to call twice vpci_process_pending(). This will have an impact how on long your vCPU is going to running because you are doubling the work. > > My understanding is that for x86 it is always enabled, but this might not be the case for Arm > >> So we would end up to call twice vpci_process_pending(). > So, if CONFIG_IOREQ_SERVER is not enabled then we end up with only calling it from traps.c on Arm >> Maybe we should move the call from the IOREQ to arch-code. > > Hm. I would better think of moving it from IOREQ to some other common code: for x86 (if > > my understanding correct about CONFIG_IOREQ_SERVER) it is by coincidence that we call vPCI > > code from there and IOREQ is always enabled. I am not aware of another suitable common helper that would be called on the return to the guest path. Hence why I suggest to possibly duplicated the code in each arch path. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Sep 06 08:53:03 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Sep 2021 08:53:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.179503.325789 (Exim 4.92) (envelope-from ) id 1mNAN4-0008U1-SI; Mon, 06 Sep 2021 08:52:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 179503.325789; Mon, 06 Sep 2021 08:52:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNAN4-0008Tu-P8; Mon, 06 Sep 2021 08:52:54 +0000 Received: by outflank-mailman (input) for mailman id 179503; Mon, 06 Sep 2021 08:52:52 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNAN2-0008To-LU for xen-devel@lists.xenproject.org; Mon, 06 Sep 2021 08:52:52 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNAN0-0008DW-Rl; Mon, 06 Sep 2021 08:52:50 +0000 Received: from 54-240-197-236.amazon.com ([54.240.197.236] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1mNAN0-0001YF-L9; Mon, 06 Sep 2021 08:52:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=65UVgM6ReCYo2fAUvHxEoeQ5/yGHQxH9PkAc5H3Ip5Q=; b=gi0SGXbJYvZk5BKbGX50do6dsv 5ex6MFpHN6vzZWOx0mCEtr8jIKBDFzM96jZ/eygMua1vDyInBk+m65pscKriVmesU4lfOw9W+ABNu R+t4MuUP2Sc8bPpqPjBRN2PiMVSVhBac1NCOCDNKQ0G5kp0jFjJTTuIdNXuvSeMZiAcY=; Subject: Re: [PATCH v2] xen/arm64: Remove vreg_emulate_sysreg32 To: Michal Orzel , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Volodymyr Babchuk , bertrand.marquis@arm.com, Ash Wilding , Ian Jackson References: <20210729104258.6320-1-michal.orzel@arm.com> <4a5ac822-3078-de0e-8f84-6881d47ad3eb@xen.org> <8974fc82-94c1-ef85-153c-0923f5faf331@arm.com> <9502c0fa-3e46-3cd3-7de8-c7adccca1397@arm.com> From: Julien Grall Message-ID: <71432e6c-1ef6-f2c2-623b-d60df607957d@xen.org> Date: Mon, 6 Sep 2021 09:52:48 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <9502c0fa-3e46-3cd3-7de8-c7adccca1397@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit Hi Michal, On 03/09/2021 10:16, Michal Orzel wrote: > > > On 02.09.2021 14:50, Julien Grall wrote: >> On 01/09/2021 10:38, Michal Orzel wrote: >>> Hi Julien, >> >> Hi Michal, >> >>> On 06.08.2021 13:12, Julien Grall wrote: >>>> >>>> >>>> On 29/07/2021 12:47, Michal Orzel wrote: >>>>> Hi Julien, >>>> >>>> Hi Michal, >>>> >>>>> On 29.07.2021 13:20, Julien Grall wrote: >>>>>> Hi Michal, >>>>>> >>>>>> On 29/07/2021 11:42, Michal Orzel wrote: >>>>>>> According to ARMv8A architecture, AArch64 registers >>>>>>> are 64bit wide even though in many cases the upper >>>>>>> 32bit is reserved. Therefore there is no need for >>>>>>> function vreg_emulate_sysreg32 on arm64. This means >>>>>>> that we can have just one function vreg_emulate_sysreg >>>>>>> using new function pointer: >>>>>>> typedef bool (*vreg_reg_fn_t)(struct cpu_user_regs *regs, >>>>>>>                                  register_t *r, bool read); >>>>>>> >>>>>>> Modify vreg_emulate_cp32 to use the new function pointer >>>>>>> as well. >>>>>>> >>>>>>> This change allows to properly use 64bit registers in AArch64 >>>>>>> state and in case of AArch32 the upper 32 bits of AArch64 >>>>>>> registers are inaccessible and are ignored(D1.20.1 ARM DDI 0487A.j). >>>>>> >>>>>> What you wrote only says that the bits are ignored. It doesn't say whether the bits will be 0. >>>>>> >>>>>> They are probably, but as I wrote yesterday, I couldn't confirm it. >>>>>> >>>>> Should I then remove this part of the commit or write below?: >>>>> "We can assume that those bits will be 0 but the architecture >>>>> reference manual does not clarify this." >>>> >>>> There was some back and forth on security@xen.org about this. I will summarizing the discussion here as we considered this was a just a bug. >>>> >>>> I wasn't looking at the correct section in the Arm Arm. There is a paragraph clearly describing the expected behavior in a different section (thanks Ash for the pointer!). Per section D1.19.2 in DDI 0487F.c: >>>> >>>> " >>>> If the general-purpose register was accessible from AArch32 state >>>> >>>> The upper 32 bits either become zero, or hold the value that the same architectural register held before any AArch32 execution. The choice between these two options is IMPLEMENTATION DEFINED, and might vary dynamically within an implementation. Correspondingly, software must >>>> regard the value as being a CONSTRAINED UNPREDICTABLE choice between these two values. >>>> >>>> This behavior applies regardless of whether any execution occurred at the Exception level that was using AArch32. That is, this behavior applies even if AArch32 state was entered by an exception >>>> return from AArch64 state, and another exception was immediately taken to AArch64 state without any instruction execution in AArch32 state. >>>> " >>>> >>>> So we can't assume the top 32-bits are zeroed unless the hypervisor ensured they were. Today, we don't have that guarantee in Xen. >>>> >>>> This needs to be fixed. The two approachs we discussed are: >>>>     1) Update set_user_reg() to zero the top 32-bit. We have a couple of places using directly the fields xN. So we would need to switch them to use set_user_reg() >>>>     2) Only saving/restoring the bottom 32-bit when entering/leaving the hypervisor. >>>> >>>> At the moment, my preference goes towards the latter because we don't risk to introduce new place where set_user_reg() is not used. >>>> >>>> I have quickly hack the entry path. This would look like: >>>> >>>> diff --git a/xen/arch/arm/arm64/entry.S b/xen/arch/arm/arm64/entry.S >>>> index fc3811ad0ad5..65e24c88b059 100644 >>>> --- a/xen/arch/arm/arm64/entry.S >>>> +++ b/xen/arch/arm/arm64/entry.S >>>> @@ -111,6 +111,11 @@ >>>>    */ >>>>           .macro  entry, hyp, compat, save_x0_x1=1 >>>>           sub     sp, sp, #(UREGS_SPSR_el1 - UREGS_LR) /* CPSR, PC, SP, LR */ >>>> +        .if \compat == 1 /* AArch32 mode */ >>>> +        /* Clobber the top 32-bit of the registers */ >>>> +        mov    w0, w0 >>>> +        mov    w1, w1 >>>> +        .endif >>>>           push    x28, x29 >>>>           push    x26, x27 >>>>           push    x24, x25 >>>> >>>> I haven't looked whether this can be optimized or the exit path would be easier to modify. >>>> >>>> Anyway, this is not a new bug so I would be fine to get this patch merged first. Although, I think this wants to be fixed for xen 4.16 (CCing Ian to track it). >>>> >>>> I will try to find sometimes in the next couple of weeks to fix it and have another review of this patch. >>>> >>> >>> As the 4.16 release is getting closer I wanted to ask whether you need help with creating a pre-work patch so that this patch can be merged. >> >> Sorry I haven't looked at the bug yet. I don't think the bug I reported necessarily needs to go first. This is not a new bug and AFAICT your patch is not going to make it worse than the current state. >> >> Your patch needs to have an updated commit message summarizing what we discussed and a second review. No need to resend a patch for the updated commit message, this can be discussed here and updated on commit (I assuming there is no other comments). >> > If the following message is ok for you, please update the commit msg after acking this change: > " > According to ARMv8A architecture, AArch64 registers > are 64bit wide even though in many cases the upper > 32bit is reserved. Therefore there is no need for > function vreg_emulate_sysreg32 on arm64. This means > that we can have just one function vreg_emulate_sysreg > using new function pointer: > typedef bool (*vreg_reg_fn_t)(struct cpu_user_regs *regs, > register_t *r, bool read); > > Modify vreg_emulate_cp32 to use the new function pointer > as well. > > This change allows to properly use 64bit registers in AArch64 > state. In case of AArch32 the documantation (D1.20.2, DDI 0487A.j) s/documantation/documentation/ > states that "the upper 32 bits either become zero, or hold the value > that the same architectural register held before any AArch32 execution." > As the choice between them is IMPLEMENTATION DEFINED we cannot assume they > are zeroed. Xen should ensure that but currently it does not. This is not > a new bug and must be fixed as agreed during a discussion over this patch. > " THis looks good to me. I will fold it on commit. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Sep 06 09:05:25 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Sep 2021 09:05:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.179510.325800 (Exim 4.92) (envelope-from ) id 1mNAZ4-0001jQ-W3; Mon, 06 Sep 2021 09:05:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 179510.325800; Mon, 06 Sep 2021 09:05:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNAZ4-0001jJ-T4; Mon, 06 Sep 2021 09:05:18 +0000 Received: by outflank-mailman (input) for mailman id 179510; Mon, 06 Sep 2021 09:05:17 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNAZ3-0001jD-Oo for xen-devel@lists.xenproject.org; Mon, 06 Sep 2021 09:05:17 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com (unknown [40.107.2.73]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 8ce56666-0ef1-11ec-b09c-12813bfff9fa; Mon, 06 Sep 2021 09:05:16 +0000 (UTC) Received: from PR0P264CA0140.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:1a::32) by AM0PR08MB5443.eurprd08.prod.outlook.com (2603:10a6:208:183::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.22; Mon, 6 Sep 2021 09:05:14 +0000 Received: from VE1EUR03FT037.eop-EUR03.prod.protection.outlook.com (2603:10a6:100:1a:cafe::2f) by PR0P264CA0140.outlook.office365.com (2603:10a6:100:1a::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Mon, 6 Sep 2021 09:05:14 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT037.mail.protection.outlook.com (10.152.19.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Mon, 6 Sep 2021 09:05:14 +0000 Received: ("Tessian outbound 19a632698c93:v103"); Mon, 06 Sep 2021 09:05:13 +0000 Received: from 0031496d2023.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 06815203-31B7-4BCB-9BBE-677527EA3505.1; Mon, 06 Sep 2021 09:05:02 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 0031496d2023.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 06 Sep 2021 09:05:02 +0000 Received: from VE1PR08MB5677.eurprd08.prod.outlook.com (2603:10a6:800:1ab::17) by VI1PR0801MB1967.eurprd08.prod.outlook.com (2603:10a6:800:8c::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.22; Mon, 6 Sep 2021 09:04:59 +0000 Received: from VE1PR08MB5677.eurprd08.prod.outlook.com ([fe80::d810:52a3:dce3:4d06]) by VE1PR08MB5677.eurprd08.prod.outlook.com ([fe80::d810:52a3:dce3:4d06%5]) with mapi id 15.20.4478.025; Mon, 6 Sep 2021 09:04:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8ce56666-0ef1-11ec-b09c-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VQ8S4ENHD1kcr09LTDYDkrm1ZbBEVK9tOxw2UuxhjNg=; b=nodtvef8gMM28EzyBM6VGGxJXZP1BnfgoFd/TVEta4MlOcRlez8QafyprKrvs/uL9WiNsKzlpL5+M0uzPV4Q7x1Y/wqSZcbFYKXkXT69EQxeTGQ4k6C2H8ne8nmSmnxlzdHxU0rJtpR1V8Yafz6T7WY8yQxP2G+1zpFBfEp8XfQ= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HN0sKJibKDo/blIlWl85ccwtSKNfa2kuygtgrJmfQiE+T5d1za6aU1y0xzhicF3Rfpvr/IXx3ECjuyGUTwxE0AbUBscj5JZZxyLcCYWzIdy4lBP+Alclixdn0sQ8aKppUhLYkHQPOdJ97ggBoj+HGsrwuUFDDCeqwqQ2UG4qAfrEpjoaswDei4ev//dbf3EY5lHoTO/bJXfGcyihP3xBouu3YBOqfg3dVlUgMWW+5/eCrXJirSNYKqo44RQbW6e4oC/Pe0e/WXb7AEvgbIe5hQVKqXJr//Zzsn7KN4yw8W+Yj7gHdMEaf7SUtBh5ci8BEi671KzD1CyPZZJekTASCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=VQ8S4ENHD1kcr09LTDYDkrm1ZbBEVK9tOxw2UuxhjNg=; b=jG804fkFsxTqSXfiks5B1hZUOjQRG4tNZx2i5uj5JH4npXwdJvqM/JyjKjZeNVeZB2sbptaMeWT3Jj6BW2MMFc3jzE2Qx2Ov8WH5FDzgw4FNSfzaYP4dD/ERvE5NA8Jy5gviyO7Ysvc5bU5WP3/G3NL0K1Fu3KGgrvxqIhUYQH950xHnEOc1Or64s4muKcw6RMGup7u4OZ9H2ACihOzFb3aFUQoVBdkYn5z7TXm/4mmYw6E6/427DJDcQhK0jNyWD/NNHN1HlpfCUJUh4Ot12+D/Ki84cMmTMD/lTraS62OiMSZ0iVGGqwK5bSlTe7ILF8P8BmuJKaSqTONjSupPeQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VQ8S4ENHD1kcr09LTDYDkrm1ZbBEVK9tOxw2UuxhjNg=; b=nodtvef8gMM28EzyBM6VGGxJXZP1BnfgoFd/TVEta4MlOcRlez8QafyprKrvs/uL9WiNsKzlpL5+M0uzPV4Q7x1Y/wqSZcbFYKXkXT69EQxeTGQ4k6C2H8ne8nmSmnxlzdHxU0rJtpR1V8Yafz6T7WY8yQxP2G+1zpFBfEp8XfQ= From: Hongda Deng To: "julien@xen.org" , Wei Chen , "xen-devel@lists.xenproject.org" CC: Bertrand Marquis , nd Subject: About Arm guests accessing to GICD_ICPENR Thread-Topic: About Arm guests accessing to GICD_ICPENR Thread-Index: Adei/iBluoJQFkGjReWesRkbibwmOA== Date: Mon, 6 Sep 2021 09:04:59 +0000 Message-ID: Accept-Language: en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 026BE3F40A943F45A19D0F3648C58C6C.0 x-checkrecipientchecked: true Authentication-Results-Original: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com; x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: 644850ed-7d68-47a0-3d83-08d97115706c x-ms-traffictypediagnostic: VI1PR0801MB1967:|AM0PR08MB5443: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:9508;OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: U+JsCEUnT1/WS903E+Wf7RF9MCZRlXBZqeliXiTaLzeNvVqOavKpcd+J1uaAjKIbIhGlZzk5hYncVCqk+rMkumdPcrnalpdlRoSQlRNUPb5z+f9FyiwVxBWCbxV1DNqfpBtPy/wU88fhpEDOMC5atc51UTaFrrgWnU7FRBxWjzkTqKDoAkDB7DJfFTU80NAdC7TU/qlh3d8QGs1YH0oW1yO3x8IXqIg4Pcitt3AEXq4C2r5kr8lGrgoLxi/UjytTERHiVROq+Z+TZz3jP45AuBDh2S/xtrHdaoK2hru/Guy0fhrFoFMYZ8fITjoqO8UkiZu/HBlzHBlazz2mfeupR1Mv4WcVvXmoHzJcSxOdXNmNHlUyButkjP2ggqNjG0mRe5EY8Hwe0jP/TUF8EtVdvIHl9c4TU+vnvIm8GqTRNZdWnxjGTWej3AUVN6BvrHddPcBtcawDBFILzxwpeRbvkzygaraqGakRpGYGOqVEKOS5l/tCts+GoXzH6xjp8pF2maqLYLo0+evURPll75HfaMHPQvlLlsPNgoTnPqrcWoG89/c7tmwxaGPOorI9q2g632IGbXaJScwWuhhGPUbAaZJ5pd2bNrMFl7O8jmz3iR7bajZqKzUPx/i03AcXeFohk98ykvo0zhIuQbjmmQ5ujpFZUkuGWqmLQJDf/Hz7B9vkey7KIi9LWlWVtBg6D8TLN4Q4MHAmNjzD5nnV+9KUg5Ckzvgf7KZluRdCdPM7kJPmm0DzPUOwruZxAmmBd6cgtWJuIivE12K+gCSH1xaSP3+NkuHPolowldy9P8+UM5g= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR08MB5677.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(136003)(376002)(396003)(366004)(39860400002)(346002)(54906003)(186003)(4743002)(26005)(38100700002)(966005)(2906002)(66946007)(478600001)(122000001)(55016002)(316002)(33656002)(9686003)(110136005)(76116006)(86362001)(71200400001)(7696005)(52536014)(66476007)(66556008)(66446008)(64756008)(83380400001)(5660300002)(8936002)(6506007)(4326008)(38070700005)(8676002);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0801MB1967 Original-Authentication-Results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT037.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: abd6a0e2-6da9-4081-2d9c-08d971156796 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: jD1RlvswgEv2o5dgHiAatjNNHTOVujMPHlsC1GTpt6ijl83FLYbZ5uFW9HY+J03/eiQjXiejlnJwZwOH1coZ1S3PakGmdiZQiwZK2xlaRp4kEbgjUmO2LW/HFs9m7BeiQ5PYksUnCQbk7PwKxv3we1GS3wFYeiKYUUXrDgGhO8aOfrntNSnz2IES3nOKFNNNKg3vuh42wuR0Qf4zU8H84QUso8dAKBsajA15FucYO5dPL7dTdCO1lsWZZDpGiptWLvtwAA2XmB0T+8rmIVDUV6T5P+0dLXA6P+DRZx9IsGcqIK8KuqoErN7NTsfncpszRmE5w9vBihJm+4MksBlC5spD0bvckRjavX2K/vFl5ClQRWtC5dNUzTvmz0x65iryP4lheF6Hu2OuWTWcVbvc1tcbF4VYWstmX8JkiDSEViQvk+UC5U7QG2DVEHl9d3qUEeL4vmLvG1jTWwPI1uezzpEWPs9QoX1GcRx9FoDPKcoETdquS7ebo6mEbUCrwqyoHc0Rdd0OsxP57LYmEi7cmax4asdvk6gQsRg/P4Wo33J4u9rCDYKLjYV1Sv+xHYm2bAK4P9acHcwLVOFzPjjumTTU35v9B7WJDDYStlN9Z4gbyDPaVkglZPFbCZK1ImBSLcQMnroI+3a0gT0NiE/DwJeDJUNuywkP5yJ6UW8PQb7NPBO1EWZ7UkFZpFMo2icm+VFqP9RGYirGGbdJyZ7cqpEE6sK34B1+t80w1cqVtJZcBbKRLcLh8pp89m5S9dbf9F0GGCLnf8weiJ5p/hTjNk5jJ8ZSdGw/1KPWzMQn79E= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(376002)(39860400002)(136003)(396003)(346002)(46966006)(36840700001)(70206006)(36860700001)(356005)(5660300002)(52536014)(70586007)(966005)(316002)(33656002)(9686003)(478600001)(8676002)(55016002)(82310400003)(8936002)(110136005)(4326008)(54906003)(83380400001)(81166007)(4743002)(47076005)(2906002)(82740400003)(7696005)(336012)(6506007)(186003)(86362001)(26005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2021 09:05:14.2547 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 644850ed-7d68-47a0-3d83-08d97115706c X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT037.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB5443 Hi Julien, =20 Xen provides vGIC to support Xen guests, and currently xen will return IO=20 unhandled when guests access GICD ICPENRn registers. This works fine with L= inux=20 guests, for Linux won't access these registers. But for Zephyr, this mechan= ism=20 will cause IO dataabort on Zephyr's initialization which makes Zephyr get i= n=20 fatal error. =20 One method to ease this is to let vGIC ignore GICD ICPENRn registers access= . I=20 tested it with Linux guests and Zephyr guests, and both works fine. And I f= ound=20 in this patch[1] that it would be more complex to touch the read part for=20 I{S,C}PENDR and the write part for ICPENDR, so could we ignore GICD ICPENDR= n=20 registers access to ease Zephyr's initialization problem? If Xen wants a complete GICD ICPENDRn emulation to fix it, do you have any= =20 suggestions? [1] https://www.mail-archive.com/search?l=3Dxen-devel@lists.xenproject.org&= q=3D subject:%22Re%5C%3A+%5C%5BPATCH+for%5C-4.15%5C%5D+xen%5C%2Fvgic%5C%3A +Implement+write+to+ISPENDR+in+vGICv%5C%7B2%2C+3%5C%7D%22&o=3Dnewest&f=3D1 Cheers Hongda From xen-devel-bounces@lists.xenproject.org Mon Sep 06 09:07:43 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Sep 2021 09:07:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.179517.325811 (Exim 4.92) (envelope-from ) id 1mNAbO-0002RQ-HO; Mon, 06 Sep 2021 09:07:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 179517.325811; Mon, 06 Sep 2021 09:07:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNAbO-0002RJ-D2; Mon, 06 Sep 2021 09:07:42 +0000 Received: by outflank-mailman (input) for mailman id 179517; Mon, 06 Sep 2021 09:07:41 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNAbM-0002RD-Ur for xen-devel@lists.xenproject.org; Mon, 06 Sep 2021 09:07:40 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNAbL-0008Ud-RK; Mon, 06 Sep 2021 09:07:39 +0000 Received: from 54-240-197-236.amazon.com ([54.240.197.236] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1mNAbL-0003Ez-Ky; Mon, 06 Sep 2021 09:07:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=qDjbz5x+lhQVqDghklbiyW58OCiSPI+82nSf0BsV7VA=; b=OakPuhnoFXchkbRDXMKpxDoRFi aX+BL9NnxJYXfPgvdL5pO8Y5s37h/bctRncqVtK2A0AtwEW3cxXXHHmk3iX/NLB5x5E3vrpRpmkSt fqNgdSR0U//Ot8zjxMFXB01pcYTDKjGEpn20/o+1RI6QZvIxFFKxc8YVM5pFxuFFcddM=; Subject: Re: [PATCH v2] xen/arm64: Remove vreg_emulate_sysreg32 To: Michal Orzel , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Volodymyr Babchuk , bertrand.marquis@arm.com References: <20210729104258.6320-1-michal.orzel@arm.com> From: Julien Grall Message-ID: <24ba08cc-acd4-c64a-1e90-dc4c8efbfe48@xen.org> Date: Mon, 6 Sep 2021 10:07:37 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210729104258.6320-1-michal.orzel@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Hi Michal, On 29/07/2021 11:42, Michal Orzel wrote: > According to ARMv8A architecture, AArch64 registers > are 64bit wide even though in many cases the upper > 32bit is reserved. Therefore there is no need for > function vreg_emulate_sysreg32 on arm64. This means > that we can have just one function vreg_emulate_sysreg > using new function pointer: > typedef bool (*vreg_reg_fn_t)(struct cpu_user_regs *regs, > register_t *r, bool read); > > Modify vreg_emulate_cp32 to use the new function pointer > as well. > > This change allows to properly use 64bit registers in AArch64 > state and in case of AArch32 the upper 32 bits of AArch64 > registers are inaccessible and are ignored(D1.20.1 ARM DDI 0487A.j). > > Signed-off-by: Michal Orzel > --- > xen/arch/arm/arm64/vsysreg.c | 2 +- > xen/arch/arm/vcpreg.c | 16 ++++++++++---- > xen/arch/arm/vgic-v3.c | 2 +- > xen/arch/arm/vtimer.c | 11 +++++----- > xen/include/asm-arm/processor.h | 4 ++-- > xen/include/asm-arm/vreg.h | 38 ++++++--------------------------- > 6 files changed, 29 insertions(+), 44 deletions(-) > > diff --git a/xen/arch/arm/arm64/vsysreg.c b/xen/arch/arm/arm64/vsysreg.c > index caf17174b8..73fa2ca9ae 100644 > --- a/xen/arch/arm/arm64/vsysreg.c > +++ b/xen/arch/arm/arm64/vsysreg.c > @@ -64,7 +64,7 @@ TVM_REG(CONTEXTIDR_EL1) > { \ > bool res; \ > \ > - res = vreg_emulate_sysreg64(regs, hsr, vreg_emulate_##reg); \ > + res = vreg_emulate_sysreg(regs, hsr, vreg_emulate_##reg); \ > ASSERT(res); \ > break; \ > } > diff --git a/xen/arch/arm/vcpreg.c b/xen/arch/arm/vcpreg.c > index e3ce56d875..be1ec08159 100644 > --- a/xen/arch/arm/vcpreg.c > +++ b/xen/arch/arm/vcpreg.c > @@ -57,9 +57,17 @@ > #define WRITE_SYSREG_SZ(sz, val, sysreg...) WRITE_SYSREG##sz(val, sysreg) > #endif > > +/* > + * type32_t is defined as register_t due to the vreg_emulate_cp32 and > + * vreg_emulate_sysreg taking function pointer with register_t type used for > + * passing register's value. > + */ > +typedef register_t type32_t; > +typedef uint64_t type64_t ; NIT: spurious space before ;. > + > /* The name is passed from the upper macro to workaround macro expansion. */ > #define TVM_REG(sz, func, reg...) \ > -static bool func(struct cpu_user_regs *regs, uint##sz##_t *r, bool read) \ > +static bool func(struct cpu_user_regs *regs, type##sz##_t *r, bool read) \ > { \ > struct vcpu *v = current; \ > bool cache_enabled = vcpu_has_cache_enabled(v); \ > @@ -83,7 +91,7 @@ static bool func(struct cpu_user_regs *regs, uint##sz##_t *r, bool read) \ > > #else /* CONFIG_ARM_64 */ > #define TVM_REG32_COMBINED(lowreg, hireg, xreg) \ > -static bool vreg_emulate_##xreg(struct cpu_user_regs *regs, uint32_t *r, \ > +static bool vreg_emulate_##xreg(struct cpu_user_regs *regs, register_t *r, \ > bool read, bool hi) \ > { \ > struct vcpu *v = current; \ > @@ -108,13 +116,13 @@ static bool vreg_emulate_##xreg(struct cpu_user_regs *regs, uint32_t *r, \ > return true; \ > } \ > \ > -static bool vreg_emulate_##lowreg(struct cpu_user_regs *regs, uint32_t *r, \ > +static bool vreg_emulate_##lowreg(struct cpu_user_regs *regs, register_t *r,\ > bool read) \ > { \ > return vreg_emulate_##xreg(regs, r, read, false); \ > } \ > \ > -static bool vreg_emulate_##hireg(struct cpu_user_regs *regs, uint32_t *r, \ > +static bool vreg_emulate_##hireg(struct cpu_user_regs *regs, register_t *r, \ > bool read) \ > { \ > return vreg_emulate_##xreg(regs, r, read, true); \ > diff --git a/xen/arch/arm/vgic-v3.c b/xen/arch/arm/vgic-v3.c > index 613f37abab..cb5a70c42e 100644 > --- a/xen/arch/arm/vgic-v3.c > +++ b/xen/arch/arm/vgic-v3.c > @@ -1531,7 +1531,7 @@ static bool vgic_v3_emulate_sysreg(struct cpu_user_regs *regs, union hsr hsr) > switch ( hsr.bits & HSR_SYSREG_REGS_MASK ) > { > case HSR_SYSREG_ICC_SGI1R_EL1: > - return vreg_emulate_sysreg64(regs, hsr, vgic_v3_emulate_sgi1r); > + return vreg_emulate_sysreg(regs, hsr, vgic_v3_emulate_sgi1r); > > default: > return false; > diff --git a/xen/arch/arm/vtimer.c b/xen/arch/arm/vtimer.c > index 167fc6127a..0196951af4 100644 > --- a/xen/arch/arm/vtimer.c > +++ b/xen/arch/arm/vtimer.c > @@ -162,7 +162,8 @@ void virt_timer_restore(struct vcpu *v) > WRITE_SYSREG(v->arch.virt_timer.ctl, CNTV_CTL_EL0); > } > > -static bool vtimer_cntp_ctl(struct cpu_user_regs *regs, uint32_t *r, bool read) > +static bool vtimer_cntp_ctl(struct cpu_user_regs *regs, register_t *r, > + bool read) > { > struct vcpu *v = current; > s_time_t expires; > @@ -197,7 +198,7 @@ static bool vtimer_cntp_ctl(struct cpu_user_regs *regs, uint32_t *r, bool read) > return true; > } > > -static bool vtimer_cntp_tval(struct cpu_user_regs *regs, uint32_t *r, > +static bool vtimer_cntp_tval(struct cpu_user_regs *regs, register_t *r, > bool read) > { > struct vcpu *v = current; > @@ -316,11 +317,11 @@ static bool vtimer_emulate_sysreg(struct cpu_user_regs *regs, union hsr hsr) > switch ( hsr.bits & HSR_SYSREG_REGS_MASK ) > { > case HSR_SYSREG_CNTP_CTL_EL0: > - return vreg_emulate_sysreg32(regs, hsr, vtimer_cntp_ctl); > + return vreg_emulate_sysreg(regs, hsr, vtimer_cntp_ctl); > case HSR_SYSREG_CNTP_TVAL_EL0: > - return vreg_emulate_sysreg32(regs, hsr, vtimer_cntp_tval); > + return vreg_emulate_sysreg(regs, hsr, vtimer_cntp_tval); > case HSR_SYSREG_CNTP_CVAL_EL0: > - return vreg_emulate_sysreg64(regs, hsr, vtimer_cntp_cval); > + return vreg_emulate_sysreg(regs, hsr, vtimer_cntp_cval); > > default: > return false; > diff --git a/xen/include/asm-arm/processor.h b/xen/include/asm-arm/processor.h > index 2577e9a244..2058b69447 100644 > --- a/xen/include/asm-arm/processor.h > +++ b/xen/include/asm-arm/processor.h > @@ -484,9 +484,9 @@ extern register_t __cpu_logical_map[]; > #define CNTKCTL_EL1_EL0PTEN (1u<<9) /* Expose phys timer registers to EL0 */ > > /* Timer control registers */ > -#define CNTx_CTL_ENABLE (1u<<0) /* Enable timer */ > +#define CNTx_CTL_ENABLE (1ul<<0) /* Enable timer */ > #define CNTx_CTL_MASK (1ul<<1) /* Mask IRQ */ > -#define CNTx_CTL_PENDING (1u<<2) /* IRQ pending */ > +#define CNTx_CTL_PENDING (1ul<<2) /* IRQ pending */ I would suggest to mention in the commit message why this is necessary. AFAICT, it is not strictly necessary because you left ctl defined as a uin32_t. So I am guessing you only keep it for hardening purpose? If so how about adding: "Take the opportunity to switch CNTx_CTL_* to use UL to avoid any surprise with the negation of any bits (as used in vtimer_cntp_ctl)". The rest of the patch looks fine. So I would be happy to deal with the fixes on commit: Reviewed-by: Julien Grall Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Sep 06 09:10:08 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Sep 2021 09:10:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.179523.325822 (Exim 4.92) (envelope-from ) id 1mNAdi-0003lp-VX; Mon, 06 Sep 2021 09:10:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 179523.325822; Mon, 06 Sep 2021 09:10:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNAdi-0003l8-Qc; Mon, 06 Sep 2021 09:10:06 +0000 Received: by outflank-mailman (input) for mailman id 179523; Mon, 06 Sep 2021 09:10:05 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNAdh-0003X8-17 for xen-devel@lists.xenproject.org; Mon, 06 Sep 2021 09:10:05 +0000 Received: from foss.arm.com (unknown [217.140.110.172]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTP id 38aac932-0ef2-11ec-b09c-12813bfff9fa; Mon, 06 Sep 2021 09:10:03 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 65D59D6E; Mon, 6 Sep 2021 02:10:03 -0700 (PDT) Received: from [10.57.15.22] (unknown [10.57.15.22]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1B3143F73D; Mon, 6 Sep 2021 02:10:01 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 38aac932-0ef2-11ec-b09c-12813bfff9fa Subject: Re: [PATCH v2] xen/arm64: Remove vreg_emulate_sysreg32 To: Julien Grall , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Volodymyr Babchuk , bertrand.marquis@arm.com References: <20210729104258.6320-1-michal.orzel@arm.com> <24ba08cc-acd4-c64a-1e90-dc4c8efbfe48@xen.org> From: Michal Orzel Message-ID: Date: Mon, 6 Sep 2021 11:09:56 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <24ba08cc-acd4-c64a-1e90-dc4c8efbfe48@xen.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Hi Julien, On 06.09.2021 11:07, Julien Grall wrote: > Hi Michal, > > On 29/07/2021 11:42, Michal Orzel wrote: >> According to ARMv8A architecture, AArch64 registers >> are 64bit wide even though in many cases the upper >> 32bit is reserved. Therefore there is no need for >> function vreg_emulate_sysreg32 on arm64. This means >> that we can have just one function vreg_emulate_sysreg >> using new function pointer: >> typedef bool (*vreg_reg_fn_t)(struct cpu_user_regs *regs, >>                                register_t *r, bool read); >> >> Modify vreg_emulate_cp32 to use the new function pointer >> as well. >> >> This change allows to properly use 64bit registers in AArch64 >> state and in case of AArch32 the upper 32 bits of AArch64 >> registers are inaccessible and are ignored(D1.20.1 ARM DDI 0487A.j). >> >> Signed-off-by: Michal Orzel >> --- >>   xen/arch/arm/arm64/vsysreg.c    |  2 +- >>   xen/arch/arm/vcpreg.c           | 16 ++++++++++---- >>   xen/arch/arm/vgic-v3.c          |  2 +- >>   xen/arch/arm/vtimer.c           | 11 +++++----- >>   xen/include/asm-arm/processor.h |  4 ++-- >>   xen/include/asm-arm/vreg.h      | 38 ++++++--------------------------- >>   6 files changed, 29 insertions(+), 44 deletions(-) >> >> diff --git a/xen/arch/arm/arm64/vsysreg.c b/xen/arch/arm/arm64/vsysreg.c >> index caf17174b8..73fa2ca9ae 100644 >> --- a/xen/arch/arm/arm64/vsysreg.c >> +++ b/xen/arch/arm/arm64/vsysreg.c >> @@ -64,7 +64,7 @@ TVM_REG(CONTEXTIDR_EL1) >>       {                                                                   \ >>           bool res;                                                       \ >>                                                                           \ >> -        res = vreg_emulate_sysreg64(regs, hsr, vreg_emulate_##reg);     \ >> +        res = vreg_emulate_sysreg(regs, hsr, vreg_emulate_##reg);       \ >>           ASSERT(res);                                                    \ >>           break;                                                          \ >>       } >> diff --git a/xen/arch/arm/vcpreg.c b/xen/arch/arm/vcpreg.c >> index e3ce56d875..be1ec08159 100644 >> --- a/xen/arch/arm/vcpreg.c >> +++ b/xen/arch/arm/vcpreg.c >> @@ -57,9 +57,17 @@ >>   #define WRITE_SYSREG_SZ(sz, val, sysreg...)  WRITE_SYSREG##sz(val, sysreg) >>   #endif >>   +/* >> + * type32_t is defined as register_t due to the vreg_emulate_cp32 and >> + * vreg_emulate_sysreg taking function pointer with register_t type used for >> + * passing register's value. >> + */ >> +typedef register_t type32_t; >> +typedef uint64_t type64_t ; > > NIT: spurious space before ;. > >> + >>   /* The name is passed from the upper macro to workaround macro expansion. */ >>   #define TVM_REG(sz, func, reg...)                                           \ >> -static bool func(struct cpu_user_regs *regs, uint##sz##_t *r, bool read)    \ >> +static bool func(struct cpu_user_regs *regs, type##sz##_t *r, bool read)    \ >>   {                                                                           \ >>       struct vcpu *v = current;                                               \ >>       bool cache_enabled = vcpu_has_cache_enabled(v);                         \ >> @@ -83,7 +91,7 @@ static bool func(struct cpu_user_regs *regs, uint##sz##_t *r, bool read)    \ >>     #else /* CONFIG_ARM_64 */ >>   #define TVM_REG32_COMBINED(lowreg, hireg, xreg)                             \ >> -static bool vreg_emulate_##xreg(struct cpu_user_regs *regs, uint32_t *r,    \ >> +static bool vreg_emulate_##xreg(struct cpu_user_regs *regs, register_t *r,  \ >>                                   bool read, bool hi)                         \ >>   {                                                                           \ >>       struct vcpu *v = current;                                               \ >> @@ -108,13 +116,13 @@ static bool vreg_emulate_##xreg(struct cpu_user_regs *regs, uint32_t *r,    \ >>       return true;                                                            \ >>   }                                                                           \ >>                                                                               \ >> -static bool vreg_emulate_##lowreg(struct cpu_user_regs *regs, uint32_t *r,  \ >> +static bool vreg_emulate_##lowreg(struct cpu_user_regs *regs, register_t *r,\ >>                                     bool read)                                \ >>   {                                                                           \ >>       return vreg_emulate_##xreg(regs, r, read, false);                       \ >>   }                                                                           \ >>                                                                               \ >> -static bool vreg_emulate_##hireg(struct cpu_user_regs *regs, uint32_t *r,   \ >> +static bool vreg_emulate_##hireg(struct cpu_user_regs *regs, register_t *r, \ >>                                    bool read)                                 \ >>   {                                                                           \ >>       return vreg_emulate_##xreg(regs, r, read, true);                        \ >> diff --git a/xen/arch/arm/vgic-v3.c b/xen/arch/arm/vgic-v3.c >> index 613f37abab..cb5a70c42e 100644 >> --- a/xen/arch/arm/vgic-v3.c >> +++ b/xen/arch/arm/vgic-v3.c >> @@ -1531,7 +1531,7 @@ static bool vgic_v3_emulate_sysreg(struct cpu_user_regs *regs, union hsr hsr) >>       switch ( hsr.bits & HSR_SYSREG_REGS_MASK ) >>       { >>       case HSR_SYSREG_ICC_SGI1R_EL1: >> -        return vreg_emulate_sysreg64(regs, hsr, vgic_v3_emulate_sgi1r); >> +        return vreg_emulate_sysreg(regs, hsr, vgic_v3_emulate_sgi1r); >>         default: >>           return false; >> diff --git a/xen/arch/arm/vtimer.c b/xen/arch/arm/vtimer.c >> index 167fc6127a..0196951af4 100644 >> --- a/xen/arch/arm/vtimer.c >> +++ b/xen/arch/arm/vtimer.c >> @@ -162,7 +162,8 @@ void virt_timer_restore(struct vcpu *v) >>       WRITE_SYSREG(v->arch.virt_timer.ctl, CNTV_CTL_EL0); >>   } >>   -static bool vtimer_cntp_ctl(struct cpu_user_regs *regs, uint32_t *r, bool read) >> +static bool vtimer_cntp_ctl(struct cpu_user_regs *regs, register_t *r, >> +                            bool read) >>   { >>       struct vcpu *v = current; >>       s_time_t expires; >> @@ -197,7 +198,7 @@ static bool vtimer_cntp_ctl(struct cpu_user_regs *regs, uint32_t *r, bool read) >>       return true; >>   } >>   -static bool vtimer_cntp_tval(struct cpu_user_regs *regs, uint32_t *r, >> +static bool vtimer_cntp_tval(struct cpu_user_regs *regs, register_t *r, >>                                bool read) >>   { >>       struct vcpu *v = current; >> @@ -316,11 +317,11 @@ static bool vtimer_emulate_sysreg(struct cpu_user_regs *regs, union hsr hsr) >>       switch ( hsr.bits & HSR_SYSREG_REGS_MASK ) >>       { >>       case HSR_SYSREG_CNTP_CTL_EL0: >> -        return vreg_emulate_sysreg32(regs, hsr, vtimer_cntp_ctl); >> +        return vreg_emulate_sysreg(regs, hsr, vtimer_cntp_ctl); >>       case HSR_SYSREG_CNTP_TVAL_EL0: >> -        return vreg_emulate_sysreg32(regs, hsr, vtimer_cntp_tval); >> +        return vreg_emulate_sysreg(regs, hsr, vtimer_cntp_tval); >>       case HSR_SYSREG_CNTP_CVAL_EL0: >> -        return vreg_emulate_sysreg64(regs, hsr, vtimer_cntp_cval); >> +        return vreg_emulate_sysreg(regs, hsr, vtimer_cntp_cval); >>         default: >>           return false; >> diff --git a/xen/include/asm-arm/processor.h b/xen/include/asm-arm/processor.h >> index 2577e9a244..2058b69447 100644 >> --- a/xen/include/asm-arm/processor.h >> +++ b/xen/include/asm-arm/processor.h >> @@ -484,9 +484,9 @@ extern register_t __cpu_logical_map[]; >>   #define CNTKCTL_EL1_EL0PTEN  (1u<<9) /* Expose phys timer registers to EL0 */ >>     /* Timer control registers */ >> -#define CNTx_CTL_ENABLE   (1u<<0)  /* Enable timer */ >> +#define CNTx_CTL_ENABLE   (1ul<<0)  /* Enable timer */ >>   #define CNTx_CTL_MASK     (1ul<<1)  /* Mask IRQ */ >> -#define CNTx_CTL_PENDING  (1u<<2)  /* IRQ pending */ >> +#define CNTx_CTL_PENDING  (1ul<<2)  /* IRQ pending */ > I would suggest to mention in the commit message why this is necessary. AFAICT, it is not strictly necessary because you left ctl defined as a uin32_t. So I am guessing you only keep it for hardening purpose? > > If so how about adding: > > "Take the opportunity to switch CNTx_CTL_* to use UL to avoid any surprise with the negation of any bits (as used in vtimer_cntp_ctl)". > > The rest of the patch looks fine. So I would be happy to deal with the fixes on commit: Please do. Thanks. > > Reviewed-by: Julien Grall > > Cheers, > Cheers, Michal From xen-devel-bounces@lists.xenproject.org Mon Sep 06 09:14:22 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Sep 2021 09:14:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.179530.325833 (Exim 4.92) (envelope-from ) id 1mNAhl-0004dp-Fc; Mon, 06 Sep 2021 09:14:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 179530.325833; Mon, 06 Sep 2021 09:14:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNAhl-0004di-CK; Mon, 06 Sep 2021 09:14:17 +0000 Received: by outflank-mailman (input) for mailman id 179530; Mon, 06 Sep 2021 09:14:15 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNAhj-0004dc-E4 for xen-devel@lists.xenproject.org; Mon, 06 Sep 2021 09:14:15 +0000 Received: from mx0b-0039f301.pphosted.com (unknown [148.163.137.242]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id cd8057ca-0ef2-11ec-b09c-12813bfff9fa; Mon, 06 Sep 2021 09:14:13 +0000 (UTC) Received: from pps.filterd (m0174680.ppops.net [127.0.0.1]) by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 18664TJi010446; Mon, 6 Sep 2021 09:14:10 GMT Received: from eur05-db8-obe.outbound.protection.outlook.com (mail-db8eur05lp2104.outbound.protection.outlook.com [104.47.17.104]) by mx0b-0039f301.pphosted.com with ESMTP id 3awdcp0hpa-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 06 Sep 2021 09:14:10 +0000 Received: from DB8PR03MB6329.eurprd03.prod.outlook.com (2603:10a6:10:13e::9) by DB9PR03MB7243.eurprd03.prod.outlook.com (2603:10a6:10:220::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.21; Mon, 6 Sep 2021 09:14:06 +0000 Received: from DB8PR03MB6329.eurprd03.prod.outlook.com ([fe80::14ca:2f6f:15bd:3470]) by DB8PR03MB6329.eurprd03.prod.outlook.com ([fe80::14ca:2f6f:15bd:3470%7]) with mapi id 15.20.4478.025; Mon, 6 Sep 2021 09:14:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cd8057ca-0ef2-11ec-b09c-12813bfff9fa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dxJo+4xILY1PE3eZqZCVGaGq+uaQznYVxCBenToiXsKsRTzu3ugXq0n+zrztyOQ1D43m9/vCBl3ARXd1m6LHkfI/gr2y/HxeQxVAURGyh73e2bnNaHzmCEFhi10QTJ3RZtxozP/k8KClb4PET7q24ElXrLS+yEvtJBzTTlMSYSzNkdcrtGti1CN18UjuTj2k9VIk/kgrQc+LogGdo5AFsuWgd7c+1+DrjkuPnzw/jF9gg+FTNcfMCQYWiYJw37GtgMiEWhLHBPREkYJ2oOi7Je90N3tp7DREh+syRXfW5vjz2R/qJk3+UTnUZRDfsGmdMidB/TvpJuqrhNp0vnuGCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=6req6beNU/YGZj4m82FSm1lkYHxl5L6WrIjISmnzq9I=; b=JnAad68rzEAwhiClHf6VKuhwnr2kvoYijPnUOadXRysC5mBo4JzEPgj1bkvMD4jQclsYaroXv4EzH+tAw8OqFVT817YLm+b8w8AnsmzAj8W/Mr94/1lojJtwKP6Pi6qWRqT385Jzj3EQO2/nfCxEtybAse6dWX1rQRzL0B1bIBxXICO0cRaVpV62HxiPFIBuw9/M1uK19/7SwkOD2bMws62nAyYhwjF3lTEuC/R3EkZql1g9EWjJKaaS0CPcf7NnWm6OXBK9+JDizQkb85DMiBmqBFNG26T6Ppk3r6sUiN4TvsFdZd2FZZNFkVcPlUQiktWPISkGYnhksodKgfIhIg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6req6beNU/YGZj4m82FSm1lkYHxl5L6WrIjISmnzq9I=; b=3yrcfv8bhJlnIwF7513v/GukUl9eLosHzIoso61ax11LmBE7RF0JJRFMPxyyhJEwAK0I18aZPbshPRqk0a1GJUdkuL+EhhAyam6ujDq9+8bScOWHvzNc5o+BQQIGcxbMMRTJ3K9e49Q/8pAGQs3vi002VVS6U0SdO40E6e++iaM5r6WztUO3s9S4OSSo0Nxx24PNBD1QCHUSv3T7ndDoLYAqekcNq9yywVyQj+XUl6VXauvuEQheOzLn2V4GcZa50AaQrK1g0HgwljGXeYGGQAQjR4Xo4mcp7LmwPhE959NmvMFjFT+o7eYOcq2gAeo+1MyMBvn/U9LP3hviaxS8Pg== From: Oleksandr Andrushchenko To: Julien Grall , Oleksandr Andrushchenko , "xen-devel@lists.xenproject.org" CC: "sstabellini@kernel.org" , Oleksandr Tyshchenko , Volodymyr Babchuk , Artem Mygaiev , "roger.pau@citrix.com" , Bertrand Marquis , Rahul Singh Subject: Re: [PATCH 11/11] xen/arm: Process pending vPCI map/unmap operations Thread-Topic: [PATCH 11/11] xen/arm: Process pending vPCI map/unmap operations Thread-Index: AQHXoJ51zxJWpxhHEEGXNqYYBqazw6uSBESAgASU4wCAAB15AIAABzeA Date: Mon, 6 Sep 2021 09:14:06 +0000 Message-ID: References: <20210903083347.131786-1-andr2000@gmail.com> <20210903083347.131786-12-andr2000@gmail.com> <7da7f759-eab0-5e97-e8e4-980db5db1e79@xen.org> In-Reply-To: <7da7f759-eab0-5e97-e8e4-980db5db1e79@xen.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=epam.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 20f18d5d-4b87-4d45-d5d6-08d97116ad77 x-ms-traffictypediagnostic: DB9PR03MB7243: x-ms-exchange-transport-forked: True x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: MgKIuLBizgFk/yy+aaCHwtitXP0QG48p7ikmTbZlXsQQNRxUZVkifJzOF4cvvIEq3u8nKPbj8x7JY0aX2rbkYmKS1pa2EPpEiAUlbem2xntnEoPz50lZjeJlktH2fcUqAmZsZULCes9DMfySPoQsWyrEtdI9HtiQ/vqVdeXYNgvMncvidzT6i7SSPgtZDLr2iDS7pN/0sWMsH4vhwW5M7+anheMt3JjyQwgsCpmBiazbrrHuW/OGvEBCqUlxJbFi8fBkM8KHQPcBVNOKuetmvB8LhOF6j4ZgOul9vK6AtRQPhn/HItrEBG8nes8081E9liW9vnhylfCTJHuBfBYwqdqNtni38/nnyBquCDFCBf1CPq7hvk8KABw7S1xZtEcHRT4durDenKGTaL0j9/HXdmDNMKvGMVAsHlmaQHqxJZLXWr8EJ1nw1MIIbSVipA+vhCz2pjCXJP6hSZj3wYyGieAf4B2RHxD2ggAytG5PB8f9WnWWRNYJZ54MeBqdrbLqXgvCky1y1TyU2rLVf4AwjRS2JCM1TEkm6e6J0QSxRwYoQRnKV3/KZj25tQA2Aspyu+OAOI+Q5WbIl0BK2s4SentuH7iSeJtMUIwGn3wXIi5RN1yLnWlP77XeCAxspb7xCf2X/z3fdM63C9TjwFDiamG3wiBgD8aeOHG0fJPvW8OYKglUK+V3uxQMrqwaASITAEWPHjlaufdIoa7SfZO/QcU8RWoaWR2vMFIEB4ERtFDqx1ZfXAWHLmlCP4sbaJHd x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB8PR03MB6329.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(39860400002)(136003)(396003)(346002)(376002)(366004)(8676002)(31696002)(64756008)(2906002)(66946007)(66446008)(478600001)(4326008)(76116006)(8936002)(38070700005)(91956017)(71200400001)(316002)(31686004)(54906003)(110136005)(26005)(36756003)(86362001)(53546011)(6512007)(186003)(5660300002)(122000001)(83380400001)(38100700002)(6506007)(6486002)(2616005)(66556008)(66476007)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?UFFudVVDT2JxYVhoTm9YUWVkU2dYWDE3aHZSLzlWRmx0cUdFRUYxOEQ5RTNG?= =?utf-8?B?dDJwVzJobFFmS1UvL0NzV3ZEQ1I3WkVpSFRPdkN1QXowUCt3ZWxzOCtDWG5j?= =?utf-8?B?em9saVgreElQY2lIdGxTL1VGT3NtWXR4NkZOcDBFaFdzeTFBemRJSWMxUHhY?= =?utf-8?B?dUowTkdlc2lLejAvcm1tbGMrVlpONUtTUURzUnVERlFabCtxczFhRTFUS05h?= =?utf-8?B?d3NmUjk3WXJocjg1Q3I4SGdwRTFET3UrV0FyUTJuQ1JFWHdWM3NieHdwOG5L?= =?utf-8?B?MDAwQ2pIVk1YVGFUczI1VEdJdUF1ZVV4SEhXaStBL0JnUXN6N1JCQlZuQzlm?= =?utf-8?B?UGk2Y0dBSm9SVXVOdTRXOVBOejFpQ0xRQW1aTFlkZWdvcTVRTjdYTnNtaGRC?= =?utf-8?B?WGJXREpGZWFiMDdBcmtmQ0FuQ0RCZElJUHZsdjIycWpYdnlrbENuZURYSkRR?= =?utf-8?B?YVdnSnFhcDRpbVV5L3UwL3JqNVgxWERaNWtUa2tCVDlVSFlXay9XWERtdlZ6?= =?utf-8?B?WkI5Rk82SHV3RWVtNWNqa3RuajF0M21INFIzdWpKMERGODBTUnVOckhvQ2lC?= =?utf-8?B?Wk52VjlkNkFFcWxtbEtYRnFqb0p1ejlUZE1xTHJUc0R6MC9BREcwWTZGb2FP?= =?utf-8?B?MFM2N1BLSHhYcGV3cE5kazJpZ1ppVTlLRlFHamRYeWsrRXcvbllwWmlxN1Ez?= =?utf-8?B?UWFYQUZXSUZlSVNLaTlBUjNHMUs3SCsyVnNjSzE1WG00VU5FNHdkMmZBRWZn?= =?utf-8?B?RXZxWEt6RTI2RGQ4dmREYVBoVXhnSEZ3RjJsSWEvRUpsUzhzUTBzSUJHN1Rm?= =?utf-8?B?S21jdTQzRnEzQ0xIYWs4ZmFYUkxZWWZoNWdjMmcreHZWSFlOQWU2cDluUDhK?= =?utf-8?B?NVZybEVBbWt6Q3pVcWRUQzNVOUVNV2k4WXJEUnBsK0IwdEZuWHJHemptRElp?= =?utf-8?B?eitoZDk2OHphSU16UkVkaTVDcU5zN1dxc3pxUjhKanhPZzV0WXNuYyt4SDc3?= =?utf-8?B?RXJnVlFBMGhJY2ZNNDh3cS81MndEenFsRE9MVkFHRTkya2dubFY0RXNoUXlQ?= =?utf-8?B?Y2JDUDJ0MjI5UUo1bnhrbTZqazZqN1Y4TDBMQmhuRWxYU25UOUd2NDBiYXZJ?= =?utf-8?B?QTR1Y1I4T0MwM3R4WGlBL2lOV2l3RTB1VzBDN3MrOUx0ZDVzMlppc0sveThp?= =?utf-8?B?VDdabEhVb0pCaUZGRG1vQ2c5dUIrdG82QnVUNzlVZXZwcUp0ZlBmU3NPTm5o?= =?utf-8?B?UlhBeHl3a2t0SktibEtxU2FiZXNxN3FiTFVjOG9yaDRxaXkzY2V4RGg1NWMr?= =?utf-8?B?enRXMkJNNVB0WjJ0cTJTMWJCWmh2TDRNd1YybHdrOEx0SnBxNjloTU54d2Ra?= =?utf-8?B?Rk4raGp6d0EyQ1I4NGhlQkkrMUJvQlJnbys4MGRXMFFLYXlWUHlQNUd5WTEw?= =?utf-8?B?ZUROZFJ0YzBxWDU2TjlJdHVXTit0WHlBWXJ0OXNQajNOcTgvZFYzYnNLL0dU?= =?utf-8?B?N2JkUkpxQ0VGbzIvTDU3WFpkcEp0dVV5aW44a2NtTmp0c1VXb0dPS2JhSzZp?= =?utf-8?B?YS9rdlNVNmNNRm9ZNGF5b1E1RWV4SU1kRUJSQVhod25mdnJhU3BCVHhYTGpa?= =?utf-8?B?VUJ0T0F2Qm1hejltYzh2NUxUOU9EcGhBNUtjZnlwaDk1WjZZRnAyNDY2dFpt?= =?utf-8?B?L1lKWXNJdWVIREJtVTVKWVRObm5IUXpwcGFXdklMWEU4Tzh4czhsbHUvaXgv?= =?utf-8?Q?/usaBxQ7b5SpCYvzENfJkpOaf05gUa4O8ykePfz?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: epam.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DB8PR03MB6329.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 20f18d5d-4b87-4d45-d5d6-08d97116ad77 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Sep 2021 09:14:06.2041 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: FatD2sSPMF/bjlKo/M2LPmR1YETF4+WMxSv6B/UJFgOHlVNOznciCizzbXEMIvrD5sc7+Nq7ObaAY/Xv4ENYzZMTb3Qkl44S12ThFlK+bZHrDzduox13wDCoeMjlJ4Sy X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR03MB7243 X-Proofpoint-GUID: TRDYvTpmQRXsf1pZnLJxxhhY9FGGApxx X-Proofpoint-ORIG-GUID: TRDYvTpmQRXsf1pZnLJxxhhY9FGGApxx X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.391,FMLib:17.0.607.475 definitions=2021-09-06_04,2021-09-03_01,2020-04-07_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=999 spamscore=0 malwarescore=0 priorityscore=1501 bulkscore=0 suspectscore=0 adultscore=0 mlxscore=0 impostorscore=0 clxscore=1015 lowpriorityscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2108310000 definitions=main-2109060059 DQpPbiAwNi4wOS4yMSAxMTo0OCwgSnVsaWVuIEdyYWxsIHdyb3RlOg0KPiBPbiAwNi8wOS8yMDIx IDA4OjAyLCBPbGVrc2FuZHIgQW5kcnVzaGNoZW5rbyB3cm90ZToNCj4+IEhpLCBKdWxpZW4hDQo+ DQo+IEhpIE9sZWtzYW5kciwNCj4NCj4+IE9uIDAzLjA5LjIxIDEyOjA0LCBKdWxpZW4gR3JhbGwg d3JvdGU6DQo+Pj4gSGkgT2xla3NhbmRyLA0KPj4+DQo+Pj4gT24gMDMvMDkvMjAyMSAwOTozMywg T2xla3NhbmRyIEFuZHJ1c2hjaGVua28gd3JvdGU6DQo+Pj4+IEZyb206IE9sZWtzYW5kciBBbmRy dXNoY2hlbmtvIDxvbGVrc2FuZHJfYW5kcnVzaGNoZW5rb0BlcGFtLmNvbT4NCj4+Pj4NCj4+Pj4g dlBDSSBtYXkgbWFwIGFuZCB1bm1hcCBQQ0kgZGV2aWNlIG1lbW9yeSAoQkFScykgYmVpbmcgcGFz c2VkIHRocm91Z2ggd2hpY2gNCj4+Pj4gbWF5IHRha2UgYSBsb3Qgb2YgdGltZS4gRm9yIHRoaXMg dGhvc2Ugb3BlcmF0aW9ucyBtYXkgYmUgZGVmZXJyZWQgdG8gYmUNCj4+Pj4gcGVyZm9ybWVkIGxh dGVyLCBzbyB0aGF0IHRoZXkgY2FuIGJlIHNhZmVseSBwcmVlbXB0ZWQuDQo+Pj4+IFJ1biB0aGUg Y29ycmVzcG9uZGluZyB2UENJIGNvZGUgd2hpbGUgc3dpdGNoaW5nIGEgdkNQVS4NCj4+Pg0KPj4+ IElJVUMsIHlvdSBhcmUgdGFsa2luZyBhYm91dCB0aGUgZnVuY3Rpb24gbWFwX3JhbmdlKCkgaW4g eGVuL2RyaXZlcnMvdnBjaS9oZWFkZXIuIFRoZSBmdW5jdGlvbiBoYXMgdGhlIGZvbGxvd2luZyB0 b2RvIGZvciBBcm06DQo+Pj4NCj4+PiDCoMKgwqDCoMKgwqDCoMKgIC8qDQo+Pj4gwqDCoMKgwqDC oMKgwqDCoMKgICogQVJNIFRPRE9zOg0KPj4+IMKgwqDCoMKgwqDCoMKgwqDCoCAqIC0gT24gQVJN IHdoZXRoZXIgdGhlIG1lbW9yeSBpcyBwcmVmZXRjaGFibGUgb3Igbm90IHNob3VsZCBiZSBwYXNz ZWQNCj4+PiDCoMKgwqDCoMKgwqDCoMKgwqAgKsKgwqAgdG8gbWFwX21taW9fcmVnaW9ucyBpbiBv cmRlciB0byBkZWNpZGUgd2hpY2ggbWVtb3J5IGF0dHJpYnV0ZXMNCj4+PiDCoMKgwqDCoMKgwqDC oMKgwqAgKsKgwqAgc2hvdWxkIGJlIHVzZWQuDQo+Pj4gwqDCoMKgwqDCoMKgwqDCoMKgICoNCj4+ PiDCoMKgwqDCoMKgwqDCoMKgwqAgKiAtIHt1bn1tYXBfbW1pb19yZWdpb25zIGRvZXNuJ3Qgc3Vw cG9ydCBwcmVlbXB0aW9uLg0KPj4+IMKgwqDCoMKgwqDCoMKgwqDCoCAqLw0KPj4+DQo+Pj4gVGhp cyBkb2Vzbid0IHNlZW0gdG8gYmUgYWRkcmVzc2VkIGluIHRoZSB0d28gc2VyaWVzIGZvciBQQ0kg cGFzc3Rocm91Z2ggc2VudCBzbyBmYXIuIERvIHlvdSBoYXZlIGFueSBwbGFuIHRvIGhhbmRsZSBp dD8NCj4+DQo+PiBObyBwbGFuIHlldC4NCj4+DQo+PiBBbGwgdGhlIG1hcHBpbmdzIGFyZSBoYXBw ZW5pbmcgd2l0aCBwMm1fbW1pb19kaXJlY3RfZGV2IGFzIG9mIG5vdy4NCj4NCj4gU28gdGhpcyBh ZGRyZXNzIHRoZSBmaXJzdCBUT0RPIGJ1dCBob3cgYWJvdXQgdGhlIHNlY29uZCBUT0RPPyBJdCBy ZWZlcnMgdG8gdGhlIGxhY2sgb2YgcHJlZW1wdGlvbiBvbiBBcm0gYnV0IGluIHRoaXMgcGF0Y2gg eW91IHN1Z2dlc3QgdGhlcmUgYXJlIHNvbWUgYW5kIGhlbmNlIHdlIG5lZWQgdG8gY2FsbCB2cGNp X3Byb2Nlc3NfcGVuZGluZygpLg0KPg0KPiBGb3IgYSB0ZWNoIHByZXZpZXcsIHRoZSBsYWNrIG9m IHByZWVtcHRpb24gd291bGQgYmUgT0suIEhvd2V2ZXIsIHRoZSBjb21taXQgbWVzc2FnZSBzaG91 bGQgYmUgdXBkYXRlZCB0byBtYWtlIGNsZWFyIHRoZXJlIGFyZSBubyBzdWNoIHByZWVtcHRpb24g eWV0IG9yIGF2b2lkIHRvIG1lbnRpb24gaXQuDQoNCldlbGwsIHRoZSBjb21tZW50IHdhcyBub3Qg YWRkZWQgYnkgbWUgKGJ5IFJvZ2VyIEkgZ3Vlc3MpLCBJIGp1c3Qga2VlcCBpdC4NCg0KQXMgdG8g dGhlIHByZWVtcHRpb24gYm90aCBtYXAgYW5kIHVubWFwIGFyZSBoYXBwZW5pbmcgdmlhIHZwY2lf cHJvY2Vzc19wZW5kaW5nLCBzbw0KDQp3aGF0IGlzIHRydWUgZm9yIG1hcCBpcyBhbHNvIHRydWUg Zm9yIHVubWFwIHdpdGggdGhpcyByZXNwZWN0DQoNCj4NCj4+DQo+Pj4NCj4+Pj4NCj4+Pj4gU2ln bmVkLW9mZi1ieTogT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gPG9sZWtzYW5kcl9hbmRydXNoY2hl bmtvQGVwYW0uY29tPg0KPj4+PiAtLS0NCj4+Pj4gwqDCoCB4ZW4vYXJjaC9hcm0vdHJhcHMuYyB8 IDYgKysrKysrDQo+Pj4+IMKgwqAgMSBmaWxlIGNoYW5nZWQsIDYgaW5zZXJ0aW9ucygrKQ0KPj4+ Pg0KPj4+PiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gvYXJtL3RyYXBzLmMgYi94ZW4vYXJjaC9hcm0v dHJhcHMuYw0KPj4+PiBpbmRleCAyMTlhYjNjM2ZiZGUuLjE1NzFmYjhhZmQwMyAxMDA2NDQNCj4+ Pj4gLS0tIGEveGVuL2FyY2gvYXJtL3RyYXBzLmMNCj4+Pj4gKysrIGIveGVuL2FyY2gvYXJtL3Ry YXBzLmMNCj4+Pj4gQEAgLTM0LDYgKzM0LDcgQEANCj4+Pj4gwqDCoCAjaW5jbHVkZSA8eGVuL3N5 bWJvbHMuaD4NCj4+Pj4gwqDCoCAjaW5jbHVkZSA8eGVuL3ZlcnNpb24uaD4NCj4+Pj4gwqDCoCAj aW5jbHVkZSA8eGVuL3ZpcnR1YWxfcmVnaW9uLmg+DQo+Pj4+ICsjaW5jbHVkZSA8eGVuL3ZwY2ku aD4NCj4+Pj4gwqDCoCDCoCAjaW5jbHVkZSA8cHVibGljL3NjaGVkLmg+DQo+Pj4+IMKgwqAgI2lu Y2x1ZGUgPHB1YmxpYy94ZW4uaD4NCj4+Pj4gQEAgLTIzMDQsNiArMjMwNSwxMSBAQCBzdGF0aWMg Ym9vbCBjaGVja19mb3JfdmNwdV93b3JrKHZvaWQpDQo+Pj4+IMKgwqDCoMKgwqDCoCB9DQo+Pj4+ IMKgwqAgI2VuZGlmDQo+Pj4+IMKgwqAgK8KgwqDCoCBsb2NhbF9pcnFfZW5hYmxlKCk7DQo+Pj4+ ICvCoMKgwqAgaWYgKCBoYXNfdnBjaSh2LT5kb21haW4pICYmIHZwY2lfcHJvY2Vzc19wZW5kaW5n KHYpICkNCj4+Pg0KPj4+IExvb2tpbmcgYXQgdGhlIGNvZGUgb2YgdnBjaV9wcm9jZXNzX3BlbmRp bmcoKSwgaXQgbG9va3MgbGlrZSB0aGVyZSBhcmUgc29tZSByZXdvcmsgdG8gZG8gZm9yIGd1ZXN0 LiBEbyB5b3UgcGxhbiB0byBoYW5kbGUgaXQgYXMgcGFydCBvZiB0aGUgdlBDSSBzZXJpZXM/DQo+ PiBZZXMsIHZQQ0kgY29kZSBpcyBoZWF2aWx5IHRvdWNoZWQgdG8gc3VwcG9ydCBndWVzdCBub24t aWRlbnRpdHkgbWFwcGluZ3MNCj4NCj4gSSB3YXNuJ3QgcmVmZXJyaW5nIHRvIHRoZSBub24taWRl bnRpdHkgbWFwcGluZ3MgaGVyZS4gSSB3YXMgcmVmZXJyaW5nIHRvIFRPRE9zIHN1Y2ggYXM6DQo+ DQo+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgLyoNCj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg ICogRklYTUU6IGluIGNhc2Ugb2YgZmFpbHVyZSByZW1vdmUgdGhlIGRldmljZSBmcm9tIHRoZSBk b21haW4uDQo+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAqIE5vdGUgdGhhdCB0aGVyZSBtaWdo dCBzdGlsbCBiZSBsZWZ0b3ZlciBtYXBwaW5ncy4gV2hpbGUgdGhpcyBpcw0KPiDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqAgKiBzYWZlIGZvciBEb20wLCBmb3IgRG9tVXMgdGhlIGRvbWFpbiB3aWxs IGxpa2VseSBuZWVkIHRvIGJlDQo+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAqIGtpbGxlZCBp biBvcmRlciB0byBhdm9pZCBsZWFraW5nIHN0YWxlIHAybSBtYXBwaW5ncyBvbg0KPiDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqAgKiBmYWlsdXJlLg0KPiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAg Ki8NCj4NCj4gWW91IHN0aWxsIGhhdmUgdGhlbSBhZnRlciB0aGUgc2VyaWVzIHJld29ya2luZyB0 aGUgdlBDSS4gQXMgZm9yIHRoZSBwcmVlbXB0aW9uIHRoaXMgaXMgT0sgdG8gaWdub3JlIGl0IGZv ciBhIHRlY2ggcHJldmlldy4gQWx0aG91Z2gsIHdlIHdhbnQgdG8gYXQgbGVhc3QgdHJhY2sgdGhl bS4NClBsZWFzZSBzZWUgYWJvdmU6IGJvdGggbWFwIGFuZCB1bm1hcCBhcmUgaGFwcGVuaW5nIHZp YSB2cGNpX3Byb2Nlc3NfcGVuZGluZw0KPg0KPj4+DQo+Pj4+ICsgcmFpc2Vfc29mdGlycShTQ0hF RFVMRV9TT0ZUSVJRKTsNCj4+Pj4gK8KgwqDCoCBsb2NhbF9pcnFfZGlzYWJsZSgpOw0KPj4+PiAr DQo+Pj4NCj4+PiDCoEZyb20gbXkgdW5kZXJzdGFuZGluZyBvZiB2Y3BpX3Byb2Nlc3NfcGVuZGlu ZygpLiBUaGUgZnVuY3Rpb24gd2lsbCByZXR1cm4gdHJ1ZSBpZiB0aGVyZSBhcmUgbW9yZSB3b3Jr IHRvIHNjaGVkdWxlLg0KPj4gWWVzDQo+Pj4gSG93ZXZlciwgaWYgY2hlY2tfZm9yX3ZjcHVfZm9y X3dvcmsoKSByZXR1cm4gZmFsc2UsIHRoZW4gd2Ugd2lsbCByZXR1cm4gdG8gdGhlIGd1ZXN0IGJl Zm9yZSBhbnkgd29yayBmb3IgdkNQSSBoYXMgZmluaXNoZWQuIFRoaXMgaXMgYmVjYXVzZSBjaGVj a19mb3JfdmNwdV93b3JrKCkgd2lsbCBub3QgYmUgY2FsbGVkIGFnYWluLg0KPj4gQ29ycmVjdA0K Pj4+DQo+Pj4gSW4gdGhpcyBjYXNlLCBJIHRoaW5rIHlvdSB3YW50IHRvIHJldHVybiBhcyBzb29u IGFzIHlvdSBrbm93IHdlIG5lZWQgdG8gcmVzY2hlZHVsZS4NCj4+IE5vdCBzdXJlIEkgdW5kZXJz dGFuZCB0aGlzDQo+DQpJIHdhcyBtb3JlIHJlZmVycmluZyB0byAiSSB0aGluayB5b3Ugd2FudCB0 byByZXR1cm4gYXMgc29vbiBhcyB5b3Uga25vdyB3ZSBuZWVkIHRvIHJlc2NoZWR1bGUuIg0KPiBU aGUgcmV0dXJuIHZhbHVlIG9mIGNoZWNrX2Zvcl92Y3B1X2Zvcl93b3JrKCkgaW5kaWNhdGVzIHdo ZXRoZXIgd2UgaGF2ZSBtb3JlIHdvcmsgdG8gZG8gYmVmb3JlIHJldHVybmluZyB0byByZXR1cm4g dG8gdGhlIGd1ZXN0Lg0KPg0KPiBXaGVuIHZwY2lfcHJvY2Vzc19wZW5kaW5nKCkgcmV0dXJucyB0 cnVlLCBpdCB0ZWxscyB1cyB3ZSBuZWVkIHRvIGNhbGwgdGhlIGZ1bmN0aW9uIGF0IGxlYXN0IG9u ZSBtb3JlIHRpbWUgYmVmb3JlIHJldHVybmluZyB0byB0aGUgZ3Vlc3QuDQo+DQo+IEluIHlvdXIg Y3VycmVudCBpbXBsZW1lbnRhdGlvbiwgeW91IGxlYXZlIHRoYXQgZGVjaXNpb24gdG8gd2hvZWV2 ZXIgaXMgbmV4dCBpbiB0aGUgZnVuY3Rpb24uDQo+DQo+IEl0IGlzIG5vdCBzYWZlIHRvIHJldHVy biB0byB0aGUgZ3Vlc3QgYXMgbG9uZyBhcyB2cGNpX3Byb2Nlc3NfcGVuZGluZygpIHJldHVybnMg dHJ1ZS4gU28geW91IHdhbnQgdG8gd3JpdGUgc29tZXRoaW5nIGxpa2U6DQo+DQo+IGlmICggdnBj aV9wcm9jZXNzX3BlbmRpbmcoKSApDQo+IMKgIHJldHVybiB0cnVlOw0KLS0tIGEveGVuL2FyY2gv YXJtL3RyYXBzLmMNCg0KKysrIGIveGVuL2FyY2gvYXJtL3RyYXBzLmMNCkBAIC0yMjkxLDYgKzIy OTEsOSBAQCBzdGF0aWMgYm9vbCBjaGVja19mb3JfdmNwdV93b3JrKHZvaWQpDQogwqB7DQogwqDC oMKgwqAgc3RydWN0IHZjcHUgKnYgPSBjdXJyZW50Ow0KDQorwqDCoMKgIGlmICggdnBjaV9wcm9j ZXNzX3BlbmRpbmcoKSApDQorwqDCoMKgwqDCoCByZXR1cm4gdHJ1ZTsNCisNCiDCoCNpZmRlZiBD T05GSUdfSU9SRVFfU0VSVkVSDQogwqDCoMKgwqAgaWYgKCBkb21haW5faGFzX2lvcmVxX3NlcnZl cih2LT5kb21haW4pICkNCiDCoMKgwqDCoCB7DQpEbyB5b3UgbWVhbiBzb21ldGhpbmcgbGlrZSB0 aGlzPw0KDQoNCj4NCj4+Pg0KPj4+IEhvd2V2ZXIsIGxvb2tpbmcgYXQgdGhlIHJlc3Qgb2YgdGhl IGNvZGUsIHdlIGFscmVhZHkgaGF2ZSBhIGNoZWNrIGZvciB2cGNpIGluIHRoZSBjb21tb24gSU9S RVEgY29kZS4NCj4+DQo+PiBXaGljaCBtYXkgbm90IGJlIGVuYWJsZWQgYXMgaXQgZGVwZW5kcyBv biBDT05GSUdfSU9SRVFfU0VSVkVSLg0KPg0KPiBSaWdodC4gTXkgcG9pbnQgaXMgd2hlbiBDT05G SUdfSU9SRVFfU0VSVkVSIGlzIHNldCB0aGVuIHlvdSB3b3VsZCBlbmQgdXAgdG8gY2FsbCB0d2lj ZSB2cGNpX3Byb2Nlc3NfcGVuZGluZygpLiBUaGlzIHdpbGwgaGF2ZSBhbiBpbXBhY3QgaG93IG9u IGxvbmcgeW91ciB2Q1BVIGlzIGdvaW5nIHRvIHJ1bm5pbmcgYmVjYXVzZSB5b3UgYXJlIGRvdWJs aW5nIHRoZSB3b3JrLg0KDQpTbywgeW91IHN1Z2dlc3QgdGhhdCB3ZSBoYXZlIGluIHRoZSBjb21t b24gSU9SRVEgY29kZSBzb21ldGhpbmcgY2FsbCBsaWtlDQoNCmFyY2hfdnBjaV9wcm9jZXNzX3Bl bmRpbmc/IEluIGNhc2Ugb2YgeDg2IGl0IHdpbGwgaGF2ZSB0aGUgY29kZSBjdXJyZW50bHkgZm91 bmQgaW4gdGhlDQoNCmNvbW1vbiBJT1JFUSBzb3VyY2VzIGFuZCBmb3IgQXJtIGl0IHdpbGwgYmUg bm9wPw0KDQpBbnkgYmV0dGVyIHN1Z2dlc3Rpb24gZm9yIHRoZSBuYW1lPw0KDQo+DQo+Pg0KPj4g TXkgdW5kZXJzdGFuZGluZyBpcyB0aGF0IGZvciB4ODYgaXQgaXMgYWx3YXlzIGVuYWJsZWQsIGJ1 dCB0aGlzIG1pZ2h0IG5vdCBiZSB0aGUgY2FzZSBmb3IgQXJtDQo+Pg0KPj4+IFNvIHdlIHdvdWxk IGVuZCB1cCB0byBjYWxsIHR3aWNlIHZwY2lfcHJvY2Vzc19wZW5kaW5nKCkuDQo+PiBTbywgaWYg Q09ORklHX0lPUkVRX1NFUlZFUiBpcyBub3QgZW5hYmxlZCB0aGVuIHdlIGVuZCB1cCB3aXRoIG9u bHkgY2FsbGluZyBpdCBmcm9tIHRyYXBzLmMgb24gQXJtDQo+Pj4gTWF5YmUgd2Ugc2hvdWxkIG1v dmUgdGhlIGNhbGwgZnJvbSB0aGUgSU9SRVEgdG8gYXJjaC1jb2RlLg0KPj4NCj4+IEhtLiBJIHdv dWxkIGJldHRlciB0aGluayBvZiBtb3ZpbmcgaXQgZnJvbSBJT1JFUSB0byBzb21lIG90aGVyIGNv bW1vbiBjb2RlOiBmb3IgeDg2IChpZg0KPj4NCj4+IG15IHVuZGVyc3RhbmRpbmcgY29ycmVjdCBh Ym91dCBDT05GSUdfSU9SRVFfU0VSVkVSKSBpdCBpcyBieSBjb2luY2lkZW5jZSB0aGF0IHdlIGNh bGwgdlBDSQ0KPj4NCj4+IGNvZGUgZnJvbSB0aGVyZSBhbmQgSU9SRVEgaXMgYWx3YXlzIGVuYWJs ZWQuDQo+DQo+IEkgYW0gbm90IGF3YXJlIG9mIGFub3RoZXIgc3VpdGFibGUgY29tbW9uIGhlbHBl ciB0aGF0IHdvdWxkIGJlIGNhbGxlZCBvbiB0aGUgcmV0dXJuIHRvIHRoZSBndWVzdCBwYXRoLiBI ZW5jZSB3aHkgSSBzdWdnZXN0IHRvIHBvc3NpYmx5IGR1cGxpY2F0ZWQgdGhlIGNvZGUgaW4gZWFj aCBhcmNoIHBhdGguDQpJIHNlZQ0KPg0KPiBDaGVlcnMsDQo+ From xen-devel-bounces@lists.xenproject.org Mon Sep 06 09:28:48 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Sep 2021 09:28:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.179538.325844 (Exim 4.92) (envelope-from ) id 1mNAvg-0006PB-Sc; Mon, 06 Sep 2021 09:28:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 179538.325844; Mon, 06 Sep 2021 09:28:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNAvg-0006P4-Oe; Mon, 06 Sep 2021 09:28:40 +0000 Received: by outflank-mailman (input) for mailman id 179538; Mon, 06 Sep 2021 09:28:40 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNAvg-0006Oy-AQ for xen-devel@lists.xenproject.org; Mon, 06 Sep 2021 09:28:40 +0000 Received: from smtp-out1.suse.de (unknown [195.135.220.28]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 4d9ce224-eeba-4533-aa2a-cb5e95a60e95; Mon, 06 Sep 2021 09:28:38 +0000 (UTC) Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id C14F82211D; Mon, 6 Sep 2021 09:28:37 +0000 (UTC) Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap1.suse-dmz.suse.de (Postfix) with ESMTPS id 8FC3B13942; Mon, 6 Sep 2021 09:28:37 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap1.suse-dmz.suse.de with ESMTPSA id RNmoIUXfNWGLfQAAGKfGzw (envelope-from ); Mon, 06 Sep 2021 09:28:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4d9ce224-eeba-4533-aa2a-cb5e95a60e95 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1630920517; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Fnt3pUFGD23kUHjHSeZH4LhPgNOomRuK/bJBrzAtC5U=; b=GqlRiGZ133bWZD5NWHgpAcBhkIHJJU1TzARdyNIbPiTDYF2U3oDad5bflg1wN1E9ehH8lA 0QTKJq1oM/aB8+r7Rqh+d6mH0xTCUlVhNsNMSagGY6x7/W8SzxAl028c154TgK0tEebBqE KqZplS48RWusqytsxiIZcJz6RkuwixI= Subject: Re: Crash when using cpupools To: Andrew Cooper , Bertrand Marquis , Xen-devel Cc: Julien Grall , Stefano Stabellini , Dario Faggioli References: <5b0a4530-72df-a186-9bd5-50759b3dd151@suse.com> From: Juergen Gross Message-ID: <41b5e46e-daad-82f0-63f0-1efe431ca695@suse.com> Date: Mon, 6 Sep 2021 11:28:36 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="twv2WvE7CpSkqTNbG1UY0sa9JKUBnNFJl" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --twv2WvE7CpSkqTNbG1UY0sa9JKUBnNFJl Content-Type: multipart/mixed; boundary="gZGi62OkMEfsZvlf2YOBXBajlHysrdJnd"; protected-headers="v1" From: Juergen Gross To: Andrew Cooper , Bertrand Marquis , Xen-devel Cc: Julien Grall , Stefano Stabellini , Dario Faggioli Message-ID: <41b5e46e-daad-82f0-63f0-1efe431ca695@suse.com> Subject: Re: Crash when using cpupools References: <5b0a4530-72df-a186-9bd5-50759b3dd151@suse.com> In-Reply-To: --gZGi62OkMEfsZvlf2YOBXBajlHysrdJnd Content-Type: multipart/mixed; boundary="------------7D5E77FB0A544101293057AF" Content-Language: en-US This is a multi-part message in MIME format. --------------7D5E77FB0A544101293057AF Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 06.09.21 10:46, Andrew Cooper wrote: > On 06/09/2021 09:23, Juergen Gross wrote: >> On 03.09.21 17:41, Bertrand Marquis wrote: >>> Hi, >>> >>> While doing some investigation with cpupools I encountered a crash >>> when trying to isolate a guest to its own physical cpu. >>> >>> I am using current staging status. >>> >>> I did the following (on FVP with 8 cores): >>> - start dom0 with dom0_max_vcpus=3D1 >>> - remove core 1 from dom0 cpupool: xl cpupool-cpu-remove Pool-0 1 >>> - create a new pool: xl cpupool-create name=3D\"NetPool\=E2=80=9D >>> - add core 1 to the pool: xl cpupool-cpu-add NetPool 1 >>> - create a guest in NetPool using the following in the guest config: >>> pool=3D=E2=80=9CNetPool" >>> >>> I end with a crash with the following call trace during guest creatio= n: >>> (XEN) Xen call trace: >>> (XEN)=C2=A0=C2=A0=C2=A0 [<0000000000234cb0>] credit2.c#csched2_alloc_= udata+0x58/0xfc >>> (PC) >>> (XEN)=C2=A0=C2=A0=C2=A0 [<0000000000234c80>] credit2.c#csched2_alloc_= udata+0x28/0xfc >>> (LR) >>> (XEN)=C2=A0=C2=A0=C2=A0 [<0000000000242d38>] sched_move_domain+0x144/= 0x6c0 >>> (XEN)=C2=A0=C2=A0=C2=A0 [<000000000022dd18>] >>> cpupool.c#cpupool_move_domain_locked+0x38/0x70 >>> (XEN)=C2=A0=C2=A0=C2=A0 [<000000000022fadc>] cpupool_do_sysctl+0x73c/= 0x780 >>> (XEN)=C2=A0=C2=A0=C2=A0 [<000000000022d8e0>] do_sysctl+0x788/0xa58 >>> (XEN)=C2=A0=C2=A0=C2=A0 [<0000000000273b68>] traps.c#do_trap_hypercal= l+0x78/0x170 >>> (XEN)=C2=A0=C2=A0=C2=A0 [<0000000000274f70>] do_trap_guest_sync+0x138= /0x618 >>> (XEN)=C2=A0=C2=A0=C2=A0 [<0000000000260458>] entry.o#guest_sync_slowp= ath+0xa4/0xd4 >>> >>> After some debugging I found out that unit->vcpu_list is NULL after >>> unit->vcpu_list =3D d->vcpu[unit->unit_id]; with unit_id 0 in >>> common/sched/core.c:688 >>> This makes the call to is_idle_unit(unit) in csched2_alloc_udata >>> trigger the crash. >> >> So there is no vcpu 0 in that domain? How is this possible? >=20 > Easy, depending on the order of hypercalls issued by the toolstack. >=20 > Between DOMCTL_createdomain and DOMCTL_max_vcpus, the domain exists but= > the vcpus haven't been allocated. Oh yes, indeed. Bertrand, does the attached patch fix the issue for you? Juergen --------------7D5E77FB0A544101293057AF Content-Type: text/x-patch; charset=UTF-8; name="0001-xen-sched-fix-sched_move_domain-for-domain-without-v.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename*0="0001-xen-sched-fix-sched_move_domain-for-domain-without-v.pa"; filename*1="tch" =46rom 82af7d22a69a8cac633a6b2a40bc7d52dac5c5e8 Mon Sep 17 00:00:00 2001 From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: George Dunlap Cc: Dario Faggioli Date: Mon, 6 Sep 2021 11:19:12 +0200 Subject: [PATCH] xen/sched: fix sched_move_domain() for domain without vc= pus In case a domain is created with a cpupool other than Pool-0 specified it will be moved to that cpupool before any vcpus are allocated. This will lead to a NULL pointer dereference in sched_move_domain(). Fix that by tolerating vcpus not being allocated yet. Fixes: 61649709421a5a7c1 ("xen/domain: Allocate d->vcpu[] in domain_creat= e()") Reported-by: Bertrand Marquis Signed-off-by: Juergen Gross --- xen/common/sched/core.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/xen/common/sched/core.c b/xen/common/sched/core.c index 8d178baf3d..79c9100680 100644 --- a/xen/common/sched/core.c +++ b/xen/common/sched/core.c @@ -671,6 +671,10 @@ int sched_move_domain(struct domain *d, struct cpupo= ol *c) =20 for ( unit_idx =3D 0; unit_idx < n_units; unit_idx++ ) { + /* Special case for move at domain creation time. */ + if ( !d->vcpu[unit_idx * gran] ) + break; + unit =3D sched_alloc_unit_mem(); if ( unit ) { --=20 2.26.2 --------------7D5E77FB0A544101293057AF Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Transfer-Encoding: quoted-printable Content-Description: OpenPGP public key Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy= cWx w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O= f8Z d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y= 9bf IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq= G7/ 377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR= 3Jv c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA= QIe AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT= hpw dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0= MbD 1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv= oPH Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v= 5QL +qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ= 2Vu IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC= QoL BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr= Wf0 teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC= /nu AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh= ITT d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm= XBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz= 80h SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC= AcD AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn= FOX gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1= jnD kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0= N51 N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l= otu fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1= tqS EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA= hsD BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3= g3O ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5= dM7 wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5= D+j LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm= V2x AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N= Eaw QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW= nHI s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR= wgn BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV= bVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk= pEd IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA= QAB wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw= Tbe 8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1= vJz Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8= VGi wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW= svi uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX= zXs ZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------7D5E77FB0A544101293057AF-- --gZGi62OkMEfsZvlf2YOBXBajlHysrdJnd-- --twv2WvE7CpSkqTNbG1UY0sa9JKUBnNFJl Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmE130UFAwAAAAAACgkQsN6d1ii/Ey+V MQf/ZpNqqtNsdtSCVkQjFcgLGaa53spI7ht9azXcuSTf6KFCXHaeHsQ136jHVRpL/kTUVylGcaZA xSFgHZoIEzecLFgZxD3CxD4yRKjMm/o8CgYeV+Yljvdyn/2TWE9c61iTcbO7t5waMG/D7rmpfQqr YFpl1NvfhuzEK46Fi2jk57anyKsVFHRZnRPykNjwz80+dJ4i1V7FNgP3xiR7jsSslvAqBOkV8unK 2VzVmnxT0LTTDtPT5V3QyQmpqNe0KEhEVZmLRLL84wD36IyiIh1TtpOVV8trPt/2oRrt2zwBux3a Ec5T6/pQBsa2estR75ahTNejHe8VDwlWIhRI+DGUZw== =z1sL -----END PGP SIGNATURE----- --twv2WvE7CpSkqTNbG1UY0sa9JKUBnNFJl-- From xen-devel-bounces@lists.xenproject.org Mon Sep 06 09:46:27 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Sep 2021 09:46:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.179544.325855 (Exim 4.92) (envelope-from ) id 1mNBCn-0000aj-Ds; Mon, 06 Sep 2021 09:46:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 179544.325855; Mon, 06 Sep 2021 09:46:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNBCn-0000ac-8o; Mon, 06 Sep 2021 09:46:21 +0000 Received: by outflank-mailman (input) for mailman id 179544; Mon, 06 Sep 2021 09:46:19 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNBCl-0000aW-Rh for xen-devel@lists.xenproject.org; Mon, 06 Sep 2021 09:46:19 +0000 Received: from smtp-out2.suse.de (unknown [195.135.220.29]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 481c6971-0ef7-11ec-b09c-12813bfff9fa; Mon, 06 Sep 2021 09:46:18 +0000 (UTC) Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 1CAF4200AF; Mon, 6 Sep 2021 09:46:17 +0000 (UTC) Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap1.suse-dmz.suse.de (Postfix) with ESMTPS id DD1911363C; Mon, 6 Sep 2021 09:46:16 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap1.suse-dmz.suse.de with ESMTPSA id YrZZNGjjNWEMBAAAGKfGzw (envelope-from ); Mon, 06 Sep 2021 09:46:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 481c6971-0ef7-11ec-b09c-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1630921577; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=T2wXaDRUM1flFstth7VtHRzmPEa+revKjFjRGmU2dE8=; b=XnnHBEXw5n3TXEe3oGUoKmdCZa8R5XDwq160rFXTUcOJ1qGfJPwHy+Q05UXWv1ea3dyNAV yZdIfR3zsfzdqWO6a1C0xNa7FZMLhpLHkOWekAUaMmgU3DhgEm5ouQXS9L6iygmC6v/a7N gPTsZC3jwvk6dF02CuUU0qFKB9VFbhY= Subject: Re: Crash when using cpupools From: Juergen Gross To: Andrew Cooper , Bertrand Marquis , Xen-devel Cc: Julien Grall , Stefano Stabellini , Dario Faggioli References: <5b0a4530-72df-a186-9bd5-50759b3dd151@suse.com> <41b5e46e-daad-82f0-63f0-1efe431ca695@suse.com> Message-ID: <01dd62b1-db4c-d8a1-b9b6-f80e4fb403cf@suse.com> Date: Mon, 6 Sep 2021 11:46:16 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <41b5e46e-daad-82f0-63f0-1efe431ca695@suse.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="1LWtuK8YRW5IouvXB1ISMO4sEVi2t9yAk" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --1LWtuK8YRW5IouvXB1ISMO4sEVi2t9yAk Content-Type: multipart/mixed; boundary="AFZA3OYofPA9zSLtZxcJqtD5axn1XBhqR"; protected-headers="v1" From: Juergen Gross To: Andrew Cooper , Bertrand Marquis , Xen-devel Cc: Julien Grall , Stefano Stabellini , Dario Faggioli Message-ID: <01dd62b1-db4c-d8a1-b9b6-f80e4fb403cf@suse.com> Subject: Re: Crash when using cpupools References: <5b0a4530-72df-a186-9bd5-50759b3dd151@suse.com> <41b5e46e-daad-82f0-63f0-1efe431ca695@suse.com> In-Reply-To: <41b5e46e-daad-82f0-63f0-1efe431ca695@suse.com> --AFZA3OYofPA9zSLtZxcJqtD5axn1XBhqR Content-Type: multipart/mixed; boundary="------------8D0B8B444F64EA343F4320B7" Content-Language: en-US This is a multi-part message in MIME format. --------------8D0B8B444F64EA343F4320B7 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 06.09.21 11:28, Juergen Gross wrote: > On 06.09.21 10:46, Andrew Cooper wrote: >> On 06/09/2021 09:23, Juergen Gross wrote: >>> On 03.09.21 17:41, Bertrand Marquis wrote: >>>> Hi, >>>> >>>> While doing some investigation with cpupools I encountered a crash >>>> when trying to isolate a guest to its own physical cpu. >>>> >>>> I am using current staging status. >>>> >>>> I did the following (on FVP with 8 cores): >>>> - start dom0 with dom0_max_vcpus=3D1 >>>> - remove core 1 from dom0 cpupool: xl cpupool-cpu-remove Pool-0 1 >>>> - create a new pool: xl cpupool-create name=3D\"NetPool\=E2=80=9D >>>> - add core 1 to the pool: xl cpupool-cpu-add NetPool 1 >>>> - create a guest in NetPool using the following in the guest config:= >>>> pool=3D=E2=80=9CNetPool" >>>> >>>> I end with a crash with the following call trace during guest creati= on: >>>> (XEN) Xen call trace: >>>> (XEN)=C2=A0=C2=A0=C2=A0 [<0000000000234cb0>] credit2.c#csched2_alloc= _udata+0x58/0xfc >>>> (PC) >>>> (XEN)=C2=A0=C2=A0=C2=A0 [<0000000000234c80>] credit2.c#csched2_alloc= _udata+0x28/0xfc >>>> (LR) >>>> (XEN)=C2=A0=C2=A0=C2=A0 [<0000000000242d38>] sched_move_domain+0x144= /0x6c0 >>>> (XEN)=C2=A0=C2=A0=C2=A0 [<000000000022dd18>] >>>> cpupool.c#cpupool_move_domain_locked+0x38/0x70 >>>> (XEN)=C2=A0=C2=A0=C2=A0 [<000000000022fadc>] cpupool_do_sysctl+0x73c= /0x780 >>>> (XEN)=C2=A0=C2=A0=C2=A0 [<000000000022d8e0>] do_sysctl+0x788/0xa58 >>>> (XEN)=C2=A0=C2=A0=C2=A0 [<0000000000273b68>] traps.c#do_trap_hyperca= ll+0x78/0x170 >>>> (XEN)=C2=A0=C2=A0=C2=A0 [<0000000000274f70>] do_trap_guest_sync+0x13= 8/0x618 >>>> (XEN)=C2=A0=C2=A0=C2=A0 [<0000000000260458>] entry.o#guest_sync_slow= path+0xa4/0xd4 >>>> >>>> After some debugging I found out that unit->vcpu_list is NULL after >>>> unit->vcpu_list =3D d->vcpu[unit->unit_id]; with unit_id 0 in >>>> common/sched/core.c:688 >>>> This makes the call to is_idle_unit(unit) in csched2_alloc_udata >>>> trigger the crash. >>> >>> So there is no vcpu 0 in that domain? How is this possible? >> >> Easy, depending on the order of hypercalls issued by the toolstack. >> >> Between DOMCTL_createdomain and DOMCTL_max_vcpus, the domain exists bu= t >> the vcpus haven't been allocated. >=20 > Oh yes, indeed. >=20 > Bertrand, does the attached patch fix the issue for you? Oh, just realized that the "Fixes:" tag is referencing the wrong commit, that should be 70fadc41635b9b62 Juergen --------------8D0B8B444F64EA343F4320B7 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Transfer-Encoding: quoted-printable Content-Description: OpenPGP public key Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy= cWx w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O= f8Z d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y= 9bf IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq= G7/ 377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR= 3Jv c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA= QIe AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT= hpw dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0= MbD 1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv= oPH Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v= 5QL +qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ= 2Vu IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC= QoL BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr= Wf0 teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC= /nu AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh= ITT d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm= XBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz= 80h SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC= AcD AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn= FOX gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1= jnD kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0= N51 N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l= otu fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1= tqS EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA= hsD BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3= g3O ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5= dM7 wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5= D+j LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm= V2x AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N= Eaw QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW= nHI s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR= wgn BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV= bVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk= pEd IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA= QAB wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw= Tbe 8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1= vJz Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8= VGi wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW= svi uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX= zXs ZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------8D0B8B444F64EA343F4320B7-- --AFZA3OYofPA9zSLtZxcJqtD5axn1XBhqR-- --1LWtuK8YRW5IouvXB1ISMO4sEVi2t9yAk Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmE142gFAwAAAAAACgkQsN6d1ii/Ey+2 kgf9GzRyUFgrBGLj3kmwmJhHWBS8/JoO1QBsEys4PQ70rX5qLoXjR5babB02MFLlJhkmDWwFEr9S RHdD3gvLku4HU9aOgdaCIRK/Qt5wRiokVGlcKoQfK9g3mEt+7ITL+RCOQpxpeYD9rsM5iV+JMham uxJsCZLffXD5EAdUM1BPc4lOEd87KUZaDiWZ2sH/XTPQzntPC7kvGWLCK6Y7FoUs7vrpptv5bU5r WCqNPt5i81PF1K7qho0qfmSErIso8uBaJvuo95OZ8GUeQL/6Vg0n6Hkl/ZTsQsIP18WFY/tVZpaX FVKPwO5RjfU3LyqozS24xVSf0Gr7NudxVZwrDiVw2w== =aZBU -----END PGP SIGNATURE----- --1LWtuK8YRW5IouvXB1ISMO4sEVi2t9yAk-- From xen-devel-bounces@lists.xenproject.org Mon Sep 06 09:54:18 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Sep 2021 09:54:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.179550.325865 (Exim 4.92) (envelope-from ) id 1mNBKH-0002Dc-7B; Mon, 06 Sep 2021 09:54:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 179550.325865; Mon, 06 Sep 2021 09:54:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNBKH-0002DV-3A; Mon, 06 Sep 2021 09:54:05 +0000 Received: by outflank-mailman (input) for mailman id 179550; Mon, 06 Sep 2021 09:54:03 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNBKF-0002DP-KK for xen-devel@lists.xenproject.org; Mon, 06 Sep 2021 09:54:03 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNBKD-0000ne-9L; Mon, 06 Sep 2021 09:54:01 +0000 Received: from 54-240-197-236.amazon.com ([54.240.197.236] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1mNBKD-0008FJ-2H; Mon, 06 Sep 2021 09:54:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=WRQ1tyZJg50eo3tR13+7InnQQ2Ofz1ksNdc1tiT75eA=; b=Vl8ZlsqiotCLob4Ffdqc+siYQp gpz1UCO4z6kxuKSXKOTV4sxakDsH7ZZM0N4hF/FeDnnPQ1p/7e3SsIGBC1FcG0RLDmzdoMGdD8AX6 wlvW3l8WvhBrnKLj6zmsSfR5T0U4Zx7aEI5X0MBCFaDxeXIZaFSi89G/me1o1wjNqqxM=; Subject: Re: [PATCH 11/11] xen/arm: Process pending vPCI map/unmap operations To: Oleksandr Andrushchenko , Oleksandr Andrushchenko , "xen-devel@lists.xenproject.org" Cc: "sstabellini@kernel.org" , Oleksandr Tyshchenko , Volodymyr Babchuk , Artem Mygaiev , "roger.pau@citrix.com" , Bertrand Marquis , Rahul Singh References: <20210903083347.131786-1-andr2000@gmail.com> <20210903083347.131786-12-andr2000@gmail.com> <7da7f759-eab0-5e97-e8e4-980db5db1e79@xen.org> From: Julien Grall Message-ID: Date: Mon, 6 Sep 2021 10:53:58 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit Hi Oleksandr, On 06/09/2021 10:14, Oleksandr Andrushchenko wrote: > > On 06.09.21 11:48, Julien Grall wrote: >> On 06/09/2021 08:02, Oleksandr Andrushchenko wrote: >>> Hi, Julien! >> >> Hi Oleksandr, >> >>> On 03.09.21 12:04, Julien Grall wrote: >>>> Hi Oleksandr, >>>> >>>> On 03/09/2021 09:33, Oleksandr Andrushchenko wrote: >>>>> From: Oleksandr Andrushchenko >>>>> >>>>> vPCI may map and unmap PCI device memory (BARs) being passed through which >>>>> may take a lot of time. For this those operations may be deferred to be >>>>> performed later, so that they can be safely preempted. >>>>> Run the corresponding vPCI code while switching a vCPU. >>>> >>>> IIUC, you are talking about the function map_range() in xen/drivers/vpci/header. The function has the following todo for Arm: >>>> >>>>          /* >>>>           * ARM TODOs: >>>>           * - On ARM whether the memory is prefetchable or not should be passed >>>>           *   to map_mmio_regions in order to decide which memory attributes >>>>           *   should be used. >>>>           * >>>>           * - {un}map_mmio_regions doesn't support preemption. >>>>           */ >>>> >>>> This doesn't seem to be addressed in the two series for PCI passthrough sent so far. Do you have any plan to handle it? >>> >>> No plan yet. >>> >>> All the mappings are happening with p2m_mmio_direct_dev as of now. >> >> So this address the first TODO but how about the second TODO? It refers to the lack of preemption on Arm but in this patch you suggest there are some and hence we need to call vpci_process_pending(). >> >> For a tech preview, the lack of preemption would be OK. However, the commit message should be updated to make clear there are no such preemption yet or avoid to mention it. > > Well, the comment was not added by me (by Roger I guess), I just keep it. I don't think it matters to know who added it. What matters is when those comments are going to be handled. If they are already handled, then they should be dropped. If they are not, the two TODOs listed above are probably OK to defer as you only plan a tech preview. But they would need to be handled before vCPI is selected by default and used in production. Note that I specifically wrote "the two TODOs listed above" because I haven't looked at the other TODOs/FIXMEs and figued out they are fine to defer. > > As to the preemption both map and unmap are happening via vpci_process_pending, so Right... this doesn't mean preemption is actually supported on Arm. vpci_process_pending() doesn't do the preemption itself. It relies on map_range() to do it. But even map_range() relies on the arch specific helper {,un}map_mmio_regions() to do it. If you look at the x86 implementation they are adding at max MAX_MMIO_MAX_ITER entries per call. On Arm, there are not such limit. Therefore the function will always do the full {,un}mapping before returning. IOW there are no preemption supported. > > what is true for map is also true for unmap with this respect > >> >>> >>>> >>>>> >>>>> Signed-off-by: Oleksandr Andrushchenko >>>>> --- >>>>>    xen/arch/arm/traps.c | 6 ++++++ >>>>>    1 file changed, 6 insertions(+) >>>>> >>>>> diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c >>>>> index 219ab3c3fbde..1571fb8afd03 100644 >>>>> --- a/xen/arch/arm/traps.c >>>>> +++ b/xen/arch/arm/traps.c >>>>> @@ -34,6 +34,7 @@ >>>>>    #include >>>>>    #include >>>>>    #include >>>>> +#include >>>>>      #include >>>>>    #include >>>>> @@ -2304,6 +2305,11 @@ static bool check_for_vcpu_work(void) >>>>>        } >>>>>    #endif >>>>>    +    local_irq_enable(); >>>>> +    if ( has_vpci(v->domain) && vpci_process_pending(v) ) >>>> >>>> Looking at the code of vpci_process_pending(), it looks like there are some rework to do for guest. Do you plan to handle it as part of the vPCI series? >>> Yes, vPCI code is heavily touched to support guest non-identity mappings >> >> I wasn't referring to the non-identity mappings here. I was referring to TODOs such as: >> >>             /* >>              * FIXME: in case of failure remove the device from the domain. >>              * Note that there might still be leftover mappings. While this is >>              * safe for Dom0, for DomUs the domain will likely need to be >>              * killed in order to avoid leaking stale p2m mappings on >>              * failure. >>              */ >> >> You still have them after the series reworking the vPCI. As for the preemption this is OK to ignore it for a tech preview. Although, we want to at least track them. > Please see above: both map and unmap are happening via vpci_process_pending I am not sure how this is relevant to what I just mentionned. >> >>>> >>>>> + raise_softirq(SCHEDULE_SOFTIRQ); >>>>> +    local_irq_disable(); >>>>> + >>>> >>>>  From my understanding of vcpi_process_pending(). The function will return true if there are more work to schedule. >>> Yes >>>> However, if check_for_vcpu_for_work() return false, then we will return to the guest before any work for vCPI has finished. This is because check_for_vcpu_work() will not be called again. >>> Correct >>>> >>>> In this case, I think you want to return as soon as you know we need to reschedule. >>> Not sure I understand this >> > I was more referring to "I think you want to return as soon as you know we need to reschedule." >> The return value of check_for_vcpu_for_work() indicates whether we have more work to do before returning to return to the guest. >> >> When vpci_process_pending() returns true, it tells us we need to call the function at least one more time before returning to the guest. >> >> In your current implementation, you leave that decision to whoeever is next in the function. >> >> It is not safe to return to the guest as long as vpci_process_pending() returns true. So you want to write something like: >> >> if ( vpci_process_pending() ) >>   return true; > --- a/xen/arch/arm/traps.c > > +++ b/xen/arch/arm/traps.c > @@ -2291,6 +2291,9 @@ static bool check_for_vcpu_work(void) >  { >      struct vcpu *v = current; > > +    if ( vpci_process_pending() ) > +      return true; > + >  #ifdef CONFIG_IOREQ_SERVER >      if ( domain_has_ioreq_server(v->domain) ) >      { > Do you mean something like this? Yes. >>>> However, looking at the rest of the code, we already have a check for vpci in the common IOREQ code. >>> >>> Which may not be enabled as it depends on CONFIG_IOREQ_SERVER. >> >> Right. My point is when CONFIG_IOREQ_SERVER is set then you would end up to call twice vpci_process_pending(). This will have an impact how on long your vCPU is going to running because you are doubling the work. > > So, you suggest that we have in the common IOREQ code something call like > > arch_vpci_process_pending? In case of x86 it will have the code currently found in the > > common IOREQ sources and for Arm it will be nop? No I am suggesting to move the call of the IOREQ code to hvm_do_resume() (on x86) and check_for_vcpu_work() (on Arm). Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Sep 06 10:06:17 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Sep 2021 10:06:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.179558.325877 (Exim 4.92) (envelope-from ) id 1mNBVz-000424-EW; Mon, 06 Sep 2021 10:06:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 179558.325877; Mon, 06 Sep 2021 10:06:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNBVz-00041x-BG; Mon, 06 Sep 2021 10:06:11 +0000 Received: by outflank-mailman (input) for mailman id 179558; Mon, 06 Sep 2021 10:06:09 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNBVx-00041r-Fx for xen-devel@lists.xenproject.org; Mon, 06 Sep 2021 10:06:09 +0000 Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 07395f79-cf56-48d6-84eb-f99b86417c34; Mon, 06 Sep 2021 10:06:05 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 07395f79-cf56-48d6-84eb-f99b86417c34 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1630922765; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=I+fziuhvRpesrSNJ0c58bAv+DQLU4/GtqeroDqk51ko=; b=Txa8Q1FrwWSYqb/7kg10gt9OvL4/smv5v490hv3SJmlSN3zQPZEVPVLr Ij5zWv9IZQQ3hnx5x+IssLtSZl1cD1+/ZKdkhY7eSVssduiwm9B+lmXmg q71FK9u/mKlOQoYEbFlCQSpGOIALn8cjLsP/9AVcJsOSVdOtvRirMNShg c=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: So0UWvXWJbMpiG7Qti2/no7YCzlCG/49Hbao8u9m0kWwGa0lkGO5dvExafKxklAzj6OIWJamLg cp8/WRGR8mmTOnsMmWeFPRem/SIRvIqxXhQlaNtBpdnRTlGed76w2mPf2U5QL0msZnaYmANnsh Bciibf9T7J6C6ZsT/cv4YyO1XNErb0FJvTrKxPQSje3IBPOWRlR9upE5+nzu4vJ21rcZ9c/ywK CizNEtVFksmMTBKez0xygl1B+nroj0HtV5W71BMYJs8AocF9ixeEsMlfJ/LWf0DKPSYXkA3IM4 0FJk65YWwePoNZZvCarQLjN7 X-SBRS: 5.1 X-MesageID: 52079071 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:AGu+uavt4251vxZfbGl7V1O47skDdtV00zEX/kB9WHVpmszxra 6TddAgpHvJYVcqKRQdcL+7VZVoLUmxyXcx2/h3AV7AZniFhILLFuFfBOLZqlWKcREWtNQttp uIG5IObuEYZmIasS+V2maFL+o= X-IronPort-AV: E=Sophos;i="5.85,272,1624334400"; d="scan'208";a="52079071" Date: Mon, 6 Sep 2021 11:06:01 +0100 From: Anthony PERARD To: Jan Beulich CC: Andrew Cooper , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu , Roger Pau =?iso-8859-1?Q?Monn=E9?= , "Tim Deegan" , Subject: Re: [XEN PATCH v7 01/51] build: introduce cpp_flags macro Message-ID: References: <20210824105038.1257926-1-anthony.perard@citrix.com> <20210824105038.1257926-2-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: On Thu, Sep 02, 2021 at 12:08:58PM +0200, Jan Beulich wrote: > On 24.08.2021 12:49, Anthony PERARD wrote: > > Signed-off-by: Anthony PERARD > > Reviewed-by: Jan Beulich > albeit with a remark: > > > --- a/xen/Rules.mk > > +++ b/xen/Rules.mk > > @@ -133,6 +133,9 @@ endif > > # Always build obj-bin files as binary even if they come from C source. > > $(obj-bin-y): XEN_CFLAGS := $(filter-out -flto,$(XEN_CFLAGS)) > > > > +# To be use with $(a_flags) or $(c_flags) to produce CPP flags > > +cpp_flags = $(filter-out -Wa$(comma)% -flto,$(1)) > > Afaics this has nothing to do with Linux'es cpp_flags, so what we do here > is entirely up to us. If this is strictly intended to be used the another > macro, wouldn't it make sense to have > > cpp_flags = $(filter-out -Wa$(comma)% -flto,$($(1))) > > here and then e.g. ... > > > @@ -222,13 +225,13 @@ $(filter %.init.o,$(obj-y) $(obj-bin-y) $(extra-y)): %.init.o: %.o FORCE > > $(call if_changed,obj_init_o) > > > > quiet_cmd_cpp_i_c = CPP $@ > > -cmd_cpp_i_c = $(CPP) $(filter-out -Wa$(comma)%,$(c_flags)) -MQ $@ -o $@ $< > > +cmd_cpp_i_c = $(CPP) $(call cpp_flags,$(c_flags)) -MQ $@ -o $@ $< > > ... the slightly simpler / easier to read > > cmd_cpp_i_c = $(CPP) $(call cpp_flags,c_flags) -MQ $@ -o $@ $< > > here? I don't think this is better or simpler. "cpp_flags" don't need to know the name of the variable to be useful. I think it is better to know that "cpp_flags" act on the value of the variable rather than the variable itself, when reading "$(call cpp_flags, $(a_flags))". But thanks for the suggestion, and for the review, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Mon Sep 06 10:06:28 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Sep 2021 10:06:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.179560.325888 (Exim 4.92) (envelope-from ) id 1mNBWF-0004SN-Nm; Mon, 06 Sep 2021 10:06:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 179560.325888; Mon, 06 Sep 2021 10:06:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNBWF-0004SG-Kn; Mon, 06 Sep 2021 10:06:27 +0000 Received: by outflank-mailman (input) for mailman id 179560; Mon, 06 Sep 2021 10:06:26 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNBWE-0004P7-Fq for xen-devel@lists.xenproject.org; Mon, 06 Sep 2021 10:06:26 +0000 Received: from mx0a-0039f301.pphosted.com (unknown [148.163.133.242]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 17d65e08-0efa-11ec-b09c-12813bfff9fa; Mon, 06 Sep 2021 10:06:25 +0000 (UTC) Received: from pps.filterd (m0174679.ppops.net [127.0.0.1]) by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 1867BWMK005392; Mon, 6 Sep 2021 10:06:22 GMT Received: from eur02-am5-obe.outbound.protection.outlook.com (mail-am5eur02lp2053.outbound.protection.outlook.com [104.47.4.53]) by mx0a-0039f301.pphosted.com with ESMTP id 3aweck0jve-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 06 Sep 2021 10:06:21 +0000 Received: from DB8PR03MB6329.eurprd03.prod.outlook.com (2603:10a6:10:13e::9) by DBBPR03MB5366.eurprd03.prod.outlook.com (2603:10a6:10:f5::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.24; Mon, 6 Sep 2021 10:06:19 +0000 Received: from DB8PR03MB6329.eurprd03.prod.outlook.com ([fe80::14ca:2f6f:15bd:3470]) by DB8PR03MB6329.eurprd03.prod.outlook.com ([fe80::14ca:2f6f:15bd:3470%7]) with mapi id 15.20.4478.025; Mon, 6 Sep 2021 10:06:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 17d65e08-0efa-11ec-b09c-12813bfff9fa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Nki9kBPfoIcBa6pHODa3MDHY7fGTSDiXP1DWGAPLPTRrf1MZO9rcmSUOCT+i7VenlULQNKKy9DmRGC87uwmXyGjSDN46rtJcT0Ix2NcRpD2AFfRYZ51m1DpTVR8WfeL8c3QkgLqnJ3+50iiA9yVd/+240ps0THXrpgk9JXil+fhS8Kc0dRnSbIOvlVaR+qe2wIdGhxe3kkX6ZdTo6HsP0d1NHmmHKpI/E2rdOmyxrNZQiHANaibsybuazQADGaik1qM2BsKkeXKFBlwMZ6HWG5kmEENxAPUub5Ig43kHBBbdNNLfulta9EUNCKgt0hRfwMqQJKmyz7TA+3r4Ea36VA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=GlvqxbD5b03wI0GYjnBPDqAcfMokceyjdbHCD/df8wE=; b=X5SFxg04p/sflxga31oA/OmwDp0ia+WuoiaCMBGSdMhb513W35Kaz5TNMAYnGlUNZeH9wDzuuk1MsHSOpX3VeSUG2cq2ZIJSShAaikaCBjvOaMs3ZZeMV00xcIWK5t03QA2Au3NU6uGYoP1Ks7IqRUogBTcG1TQjxXvsqkIpwyUsxtl6SRwmMbbLP9sA2Bthc6iQTm0eKg3nom5BRt1RYetOReEKCgi45KO+gS4MSgSFrKpazNZNMdDOFXDx/PlRiq0kx+a1PF77D8jvocqEfGPFofWMR3BsY/6/hMN5JPpaMipaAE6gNS347ts2EjiZRp9NDtwRDW4JaUzkPBUdVg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GlvqxbD5b03wI0GYjnBPDqAcfMokceyjdbHCD/df8wE=; b=bOQ8XheyxwU4+FRV4/hXnpJr1ujFkxHLj3lj9RS+k8vYgmgRuFzQhATkLL9imaVzYld4Uws5NXLITjo64cgp1wA0/HUKY+GWdcARPUesxBRz6DBdunBLq0uhghixEuU5gNTaVKwP+uCwrPbYBh345klD0USRQfdolvww+/ehXIRisVXtjnVilQka0Z1a0OMcrfLsL+gIkItmKFfHmJp6PjN7QDudgdFkI3fMIOD9b5ZJNjyyAjJTbUyfC1WEpcQvo0wooRTsuZKS6V+WOAKHpVr4UgnSrSiMrdJap0+2KbrhcywRCiImqvc5CVVNZzAQhLFbxRsJC7Cosy7lL7MOow== From: Oleksandr Andrushchenko To: Julien Grall , Oleksandr Andrushchenko , "xen-devel@lists.xenproject.org" CC: "sstabellini@kernel.org" , Oleksandr Tyshchenko , Volodymyr Babchuk , Artem Mygaiev , "roger.pau@citrix.com" , Bertrand Marquis , Rahul Singh Subject: Re: [PATCH 11/11] xen/arm: Process pending vPCI map/unmap operations Thread-Topic: [PATCH 11/11] xen/arm: Process pending vPCI map/unmap operations Thread-Index: AQHXoJ51zxJWpxhHEEGXNqYYBqazw6uSBESAgASU4wCAAB15AIAABzeAgAALJQCAAANyAA== Date: Mon, 6 Sep 2021 10:06:18 +0000 Message-ID: <71e0a54f-da69-5712-f826-9c38eecfa244@epam.com> References: <20210903083347.131786-1-andr2000@gmail.com> <20210903083347.131786-12-andr2000@gmail.com> <7da7f759-eab0-5e97-e8e4-980db5db1e79@xen.org> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=epam.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8f6b2752-80c3-4351-2437-08d9711df8c6 x-ms-traffictypediagnostic: DBBPR03MB5366: x-ms-exchange-transport-forked: True x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: rH2AO/pSY6cTQPn6n+wtAAItbeiAPYCzlKvw5fXWbGeh+Wpr+DJmjtp4EmLK4eDdQmFWvgZPSbKhTJSrrrl5lP6bFl0nk6Y7UGGYJCCvCoZRPTzSWmVPyVT1me//G8EPsntMwVdiymBS4JcLj/LnI8Ml/1kvmPb5+vErFuNa1NBPYSmgSt0HU3dZYcdebfJopIlnMDmJyXSEsUFumGHG38icPsBK/9aLSniBrwmOORW9CsTFFhq138YkenBvp6i54IXZVFQs18L+BB+rU4ZyBfZfK4Si5cORVj7Hy2NjXSa4PK+gZkQ1BwrtBjwkDbaN6ciL4fDu5e/MSOz0IoPseXfK0TTNTkN/6eA2c7zM8gTT1aBMZMgtjng9BY8VzlkBz8wWRAJ7qviJ06wyO+IqAmCLo1hea2c+OsWvVmy7//j4L+44mKOQKB1p73vOQxrJVYEMW2dJb66d4/MTgumumvl9oO3BlmHXquf1glLYAVSUNbvH9/pIRdbjqiVig1K0xBgjpZQk+T2DwXh3qjO3WtWTPem7ycrTqHSNFw3ldnqgKa4iqjr50kFr6fdq5KGDjJ1NTX+59UXN2NWk4a3Ew8H4K6DLS1AEMXndjmNYJuyskKAxQAIrpN8/VU6ScmJMw9dus9IJCGQt48ZnvoUn8wXmilkgjTBzAS88fpVxUw70C7Nu3y+vGDOT0TkVV70c6/QPnQ9ppW3aOTx4k7oDaeKE2udFOSG4K11IMwXaVG38mmsOb1G/I8H4ip5KmUtV x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB8PR03MB6329.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(508600001)(83380400001)(38070700005)(8936002)(4326008)(2616005)(86362001)(31696002)(8676002)(38100700002)(36756003)(31686004)(122000001)(2906002)(6512007)(71200400001)(6486002)(6506007)(54906003)(5660300002)(316002)(110136005)(66446008)(64756008)(66556008)(66946007)(66476007)(76116006)(91956017)(26005)(53546011)(186003)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?a0N3Rzc4eHRqdFR4WVpsR2gzT3BaUklxS0dzTitNUCt2Tnc0clVRbjRWaEN5?= =?utf-8?B?ekN6K3g0Y01QTVhzaC96NUdjZ1dOeEo2SHBoalkramJOSjhFWmF3ZTJQODk3?= =?utf-8?B?ODJmSUp4UkRXMFNKT1VYVm80MytyUUFXbHlGNGRTNG5tdnFtRDFqNzdzN2tJ?= =?utf-8?B?YmtFa0tzMTQ1UkhUVWtmTlJ3UWJkYlNkdlA0ME4wZ2padSt4ejBhWUl3d0gv?= =?utf-8?B?c2tzbkVkOVl6L1J1QW1PQVpRbGxqOGZlUXBTYjRuOHdneUxWMGtTWm1ickZ1?= =?utf-8?B?LzBWeDdKL0lLb1drT25IS0pzVGt3bUlweUU5c0JQZ3BFb2pHWmFycGx1Q0lj?= =?utf-8?B?SnMrdExldDBTcFRCa01wQ3pkN1B6UXRZMWs2bHY0U0VXMksyK1ZuVU1SU1Ni?= =?utf-8?B?eEp3VXp1bS8rdTB2UmdQMmZKcXFjSkpuT3l6NW5qZi9NclQvanJwQ0JwanA0?= =?utf-8?B?SHlDU0wySEpFc0E4RVNoRGNHUmZXNnV4TnV3QTJsRjJid3pDMk1wRlBqOWE1?= =?utf-8?B?ZW05UVcraHkzT2dCUEYvYXZoUUJVd2E5QkZHR2twek5RWS9PSkZWU1FaUG5X?= =?utf-8?B?d3k4OElvSWRUZHh2R25GNHp0S2F1SWFRMGU2NXUvTEZ3a09TRkx0bE56ZVF3?= =?utf-8?B?bTdGeGxmcWE4ZWFVdENtTWFHbi9idUZiTndtODRZOUYrNnRvNldqbmZGcmZq?= =?utf-8?B?NGMwV2NrRlNRMkJoSUtNWlp3dEMwYVp3MU04U1RKL3JQS2tCV0tVdlJXZUx1?= =?utf-8?B?bk52TUFpRkJ4eFZlaUswYVdiUW1HUGMrN0U2Uk5JemZ5bnZhV1BQN0FyZkdN?= =?utf-8?B?bTFsVlRwWk12YXJqL0crYmtwR3hHMnkyZFpLejlsaVNxRnQvNXlMczY3dmNX?= =?utf-8?B?WGVZTXpFYzRObEc3cmwyZlBtbXVPams1dHFlWkdwVWlFcVBCOEdhK2VJTmVT?= =?utf-8?B?ZzJ1ZTBrcGJPMmplaW5TRHZibmxnaGR3YUFyc3NBTkFBN0xKSis5SjBGdlVw?= =?utf-8?B?NHlEU25jUGZPb1RQTnoxUHNYTHh1VGJZcmt2VTFrNmpmMWpZNWNEK3JySVJm?= =?utf-8?B?Y1F2Zk1ZdXZ5WFFvWHFxMXF6TmFncVJ5OW9INHZBUm1MKzhhYVozOWZSemxx?= =?utf-8?B?Qi9objBnWlBMbCtHd2VsTFJyMHlDSmQ2OXNMZ2tCclcrQUltL3pZeThRL2lB?= =?utf-8?B?WTRPaHV4YktENnZJdVlnUE9LbWRTd3B4OFd0dlhTWkxhYng0OGdYNTNnaVND?= =?utf-8?B?US9TZTd6RzY5RmtwQVltZWx3Y0pBaW1JY0RwVlNDaGhHbHBYRHhhclFJL3py?= =?utf-8?B?dXhKeGhFWDJ4bDJyUFl1Qy8vUW5hSTZoVjVpdGJWVEk3WngrUkgxdURUbXNw?= =?utf-8?B?cmFmN3dWMVZ4aHQ4aEdRTHJaR2NSSjV3UDBkTG1ZT2xoemhoQWl2U2p1aklo?= =?utf-8?B?alRyRXZsdWNCSFZQMU9vTGpEem9OcDJGM2pFcjROZDhCQmhrL2xqekN4c2hD?= =?utf-8?B?MWxtYW93QkVMSHBNYnlLUE9pRFkzZXQrck11TzQvWnhFcTFKdkV5V3pxaGps?= =?utf-8?B?d0Ftb3hzaFJicGNpQ2lRbWUydTBmQXFSNUJTUEsydUZyazNYSVdlN2t4YWl0?= =?utf-8?B?TjlYNE1mRy9tSDBHUDNDQldhN0diM3pTcmU5YjFLNVJZMUtNR2NoRmVmOFdh?= =?utf-8?B?c3k0akVjRHlPUUUrNnZrTW9mcmRmUXQwdUhMRk5vdWc1VzNaR2tMbHVXWUY1?= =?utf-8?Q?RbQq4dqvpEw/OrG7Q4h9z5uMjfps4MGffoSKHjm?= Content-Type: text/plain; charset="utf-8" Content-ID: <10D4F8D17A2DC44C89797B5ED8F2E223@eurprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: epam.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DB8PR03MB6329.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8f6b2752-80c3-4351-2437-08d9711df8c6 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Sep 2021 10:06:18.9738 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: +4jDX0tMJfe32pxZLPB6sD1KiNKqNNY7yTsfZBYPIKqrFrxShzxBcFSjOB8ZD03k2m9ve12KvbxOd8BcQkgwL3BSYveWGyNmvWWUfuPX3uU0BGBVr9KVqbqG69182n2t X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR03MB5366 X-Proofpoint-GUID: vkyPgN_bW_Kr5Lq7MUtFzHKsC0Ni8Sm0 X-Proofpoint-ORIG-GUID: vkyPgN_bW_Kr5Lq7MUtFzHKsC0Ni8Sm0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.391,FMLib:17.0.607.475 definitions=2021-09-06_05,2021-09-03_01,2020-04-07_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 impostorscore=0 suspectscore=0 priorityscore=1501 clxscore=1015 spamscore=0 malwarescore=0 phishscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2108310000 definitions=main-2109060064 DQpPbiAwNi4wOS4yMSAxMjo1MywgSnVsaWVuIEdyYWxsIHdyb3RlOg0KPiBIaSBPbGVrc2FuZHIs DQo+DQo+IE9uIDA2LzA5LzIwMjEgMTA6MTQsIE9sZWtzYW5kciBBbmRydXNoY2hlbmtvIHdyb3Rl Og0KPj4NCj4+IE9uIDA2LjA5LjIxIDExOjQ4LCBKdWxpZW4gR3JhbGwgd3JvdGU6DQo+Pj4gT24g MDYvMDkvMjAyMSAwODowMiwgT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gd3JvdGU6DQo+Pj4+IEhp LCBKdWxpZW4hDQo+Pj4NCj4+PiBIaSBPbGVrc2FuZHIsDQo+Pj4NCj4+Pj4gT24gMDMuMDkuMjEg MTI6MDQsIEp1bGllbiBHcmFsbCB3cm90ZToNCj4+Pj4+IEhpIE9sZWtzYW5kciwNCj4+Pj4+DQo+ Pj4+PiBPbiAwMy8wOS8yMDIxIDA5OjMzLCBPbGVrc2FuZHIgQW5kcnVzaGNoZW5rbyB3cm90ZToN Cj4+Pj4+PiBGcm9tOiBPbGVrc2FuZHIgQW5kcnVzaGNoZW5rbyA8b2xla3NhbmRyX2FuZHJ1c2hj aGVua29AZXBhbS5jb20+DQo+Pj4+Pj4NCj4+Pj4+PiB2UENJIG1heSBtYXAgYW5kIHVubWFwIFBD SSBkZXZpY2UgbWVtb3J5IChCQVJzKSBiZWluZyBwYXNzZWQgdGhyb3VnaCB3aGljaA0KPj4+Pj4+ IG1heSB0YWtlIGEgbG90IG9mIHRpbWUuIEZvciB0aGlzIHRob3NlIG9wZXJhdGlvbnMgbWF5IGJl IGRlZmVycmVkIHRvIGJlDQo+Pj4+Pj4gcGVyZm9ybWVkIGxhdGVyLCBzbyB0aGF0IHRoZXkgY2Fu IGJlIHNhZmVseSBwcmVlbXB0ZWQuDQo+Pj4+Pj4gUnVuIHRoZSBjb3JyZXNwb25kaW5nIHZQQ0kg Y29kZSB3aGlsZSBzd2l0Y2hpbmcgYSB2Q1BVLg0KPj4+Pj4NCj4+Pj4+IElJVUMsIHlvdSBhcmUg dGFsa2luZyBhYm91dCB0aGUgZnVuY3Rpb24gbWFwX3JhbmdlKCkgaW4geGVuL2RyaXZlcnMvdnBj aS9oZWFkZXIuIFRoZSBmdW5jdGlvbiBoYXMgdGhlIGZvbGxvd2luZyB0b2RvIGZvciBBcm06DQo+ Pj4+Pg0KPj4+Pj4gwqDCoMKgwqDCoMKgwqDCoMKgIC8qDQo+Pj4+PiDCoMKgwqDCoMKgwqDCoMKg wqDCoCAqIEFSTSBUT0RPczoNCj4+Pj4+IMKgwqDCoMKgwqDCoMKgwqDCoMKgICogLSBPbiBBUk0g d2hldGhlciB0aGUgbWVtb3J5IGlzIHByZWZldGNoYWJsZSBvciBub3Qgc2hvdWxkIGJlIHBhc3Nl ZA0KPj4+Pj4gwqDCoMKgwqDCoMKgwqDCoMKgwqAgKsKgwqAgdG8gbWFwX21taW9fcmVnaW9ucyBp biBvcmRlciB0byBkZWNpZGUgd2hpY2ggbWVtb3J5IGF0dHJpYnV0ZXMNCj4+Pj4+IMKgwqDCoMKg wqDCoMKgwqDCoMKgICrCoMKgIHNob3VsZCBiZSB1c2VkLg0KPj4+Pj4gwqDCoMKgwqDCoMKgwqDC oMKgwqAgKg0KPj4+Pj4gwqDCoMKgwqDCoMKgwqDCoMKgwqAgKiAtIHt1bn1tYXBfbW1pb19yZWdp b25zIGRvZXNuJ3Qgc3VwcG9ydCBwcmVlbXB0aW9uLg0KPj4+Pj4gwqDCoMKgwqDCoMKgwqDCoMKg wqAgKi8NCj4+Pj4+DQo+Pj4+PiBUaGlzIGRvZXNuJ3Qgc2VlbSB0byBiZSBhZGRyZXNzZWQgaW4g dGhlIHR3byBzZXJpZXMgZm9yIFBDSSBwYXNzdGhyb3VnaCBzZW50IHNvIGZhci4gRG8geW91IGhh dmUgYW55IHBsYW4gdG8gaGFuZGxlIGl0Pw0KPj4+Pg0KPj4+PiBObyBwbGFuIHlldC4NCj4+Pj4N Cj4+Pj4gQWxsIHRoZSBtYXBwaW5ncyBhcmUgaGFwcGVuaW5nIHdpdGggcDJtX21taW9fZGlyZWN0 X2RldiBhcyBvZiBub3cuDQo+Pj4NCj4+PiBTbyB0aGlzIGFkZHJlc3MgdGhlIGZpcnN0IFRPRE8g YnV0IGhvdyBhYm91dCB0aGUgc2Vjb25kIFRPRE8/IEl0IHJlZmVycyB0byB0aGUgbGFjayBvZiBw cmVlbXB0aW9uIG9uIEFybSBidXQgaW4gdGhpcyBwYXRjaCB5b3Ugc3VnZ2VzdCB0aGVyZSBhcmUg c29tZSBhbmQgaGVuY2Ugd2UgbmVlZCB0byBjYWxsIHZwY2lfcHJvY2Vzc19wZW5kaW5nKCkuDQo+ Pj4NCj4+PiBGb3IgYSB0ZWNoIHByZXZpZXcsIHRoZSBsYWNrIG9mIHByZWVtcHRpb24gd291bGQg YmUgT0suIEhvd2V2ZXIsIHRoZSBjb21taXQgbWVzc2FnZSBzaG91bGQgYmUgdXBkYXRlZCB0byBt YWtlIGNsZWFyIHRoZXJlIGFyZSBubyBzdWNoIHByZWVtcHRpb24geWV0IG9yIGF2b2lkIHRvIG1l bnRpb24gaXQuDQo+Pg0KPj4gV2VsbCwgdGhlIGNvbW1lbnQgd2FzIG5vdCBhZGRlZCBieSBtZSAo YnkgUm9nZXIgSSBndWVzcyksIEkganVzdCBrZWVwIGl0Lg0KPg0KPiBJIGRvbid0IHRoaW5rIGl0 IG1hdHRlcnMgdG8ga25vdyB3aG8gYWRkZWQgaXQuIFdoYXQgbWF0dGVycyBpcyB3aGVuIHRob3Nl IGNvbW1lbnRzIGFyZSBnb2luZyB0byBiZSBoYW5kbGVkLiBJZiB0aGV5IGFyZSBhbHJlYWR5IGhh bmRsZWQsIHRoZW4gdGhleSBzaG91bGQgYmUgZHJvcHBlZC4NCj4NCj4gSWYgdGhleSBhcmUgbm90 LCB0aGUgdHdvIFRPRE9zIGxpc3RlZCBhYm92ZSBhcmUgcHJvYmFibHkgT0sgdG8gZGVmZXIgYXMg eW91IG9ubHkgcGxhbiBhIHRlY2ggcHJldmlldy4gQnV0IHRoZXkgd291bGQgbmVlZCB0byBiZSBo YW5kbGVkIGJlZm9yZSB2Q1BJIGlzIHNlbGVjdGVkIGJ5IGRlZmF1bHQgYW5kIHVzZWQgaW4gcHJv ZHVjdGlvbi4NCj4NCj4gTm90ZSB0aGF0IEkgc3BlY2lmaWNhbGx5IHdyb3RlICJ0aGUgdHdvIFRP RE9zIGxpc3RlZCBhYm92ZSIgYmVjYXVzZSBJIGhhdmVuJ3QgbG9va2VkIGF0IHRoZSBvdGhlciBU T0RPcy9GSVhNRXMgYW5kIGZpZ3VlZCBvdXQgdGhleSBhcmUgZmluZSB0byBkZWZlci4NCk9rLCB0 aGVuIEkgbGVhdmUgdGhlIFRPRE9zIGFzIHRoZXkgYXJlDQo+DQo+Pg0KPj4gQXMgdG8gdGhlIHBy ZWVtcHRpb24gYm90aCBtYXAgYW5kIHVubWFwIGFyZSBoYXBwZW5pbmcgdmlhIHZwY2lfcHJvY2Vz c19wZW5kaW5nLCBzbw0KPg0KPiBSaWdodC4uLiB0aGlzIGRvZXNuJ3QgbWVhbiBwcmVlbXB0aW9u IGlzIGFjdHVhbGx5IHN1cHBvcnRlZCBvbiBBcm0uIHZwY2lfcHJvY2Vzc19wZW5kaW5nKCkgZG9l c24ndCBkbyB0aGUgcHJlZW1wdGlvbiBpdHNlbGYuIEl0IHJlbGllcyBvbiBtYXBfcmFuZ2UoKSB0 byBkbyBpdC4NCj4NCj4gQnV0IGV2ZW4gbWFwX3JhbmdlKCkgcmVsaWVzIG9uIHRoZSBhcmNoIHNw ZWNpZmljIGhlbHBlciB7LHVufW1hcF9tbWlvX3JlZ2lvbnMoKSB0byBkbyBpdC4gSWYgeW91IGxv b2sgYXQgdGhlIHg4NiBpbXBsZW1lbnRhdGlvbiB0aGV5IGFyZSBhZGRpbmcgYXQgbWF4IE1BWF9N TUlPX01BWF9JVEVSIGVudHJpZXMgcGVyIGNhbGwuIE9uIEFybSwgdGhlcmUgYXJlIG5vdCBzdWNo IGxpbWl0LiBUaGVyZWZvcmUgdGhlIGZ1bmN0aW9uIHdpbGwgYWx3YXlzIGRvIHRoZSBmdWxsIHss dW59bWFwcGluZyBiZWZvcmUgcmV0dXJuaW5nLiBJT1cgdGhlcmUgYXJlIG5vIHByZWVtcHRpb24g c3VwcG9ydGVkLg0KT2sNCj4NCj4+DQo+PiB3aGF0IGlzIHRydWUgZm9yIG1hcCBpcyBhbHNvIHRy dWUgZm9yIHVubWFwIHdpdGggdGhpcyByZXNwZWN0DQo+Pg0KPj4+DQo+Pj4+DQo+Pj4+Pg0KPj4+ Pj4+DQo+Pj4+Pj4gU2lnbmVkLW9mZi1ieTogT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gPG9sZWtz YW5kcl9hbmRydXNoY2hlbmtvQGVwYW0uY29tPg0KPj4+Pj4+IC0tLQ0KPj4+Pj4+IMKgwqDCoCB4 ZW4vYXJjaC9hcm0vdHJhcHMuYyB8IDYgKysrKysrDQo+Pj4+Pj4gwqDCoMKgIDEgZmlsZSBjaGFu Z2VkLCA2IGluc2VydGlvbnMoKykNCj4+Pj4+Pg0KPj4+Pj4+IGRpZmYgLS1naXQgYS94ZW4vYXJj aC9hcm0vdHJhcHMuYyBiL3hlbi9hcmNoL2FybS90cmFwcy5jDQo+Pj4+Pj4gaW5kZXggMjE5YWIz YzNmYmRlLi4xNTcxZmI4YWZkMDMgMTAwNjQ0DQo+Pj4+Pj4gLS0tIGEveGVuL2FyY2gvYXJtL3Ry YXBzLmMNCj4+Pj4+PiArKysgYi94ZW4vYXJjaC9hcm0vdHJhcHMuYw0KPj4+Pj4+IEBAIC0zNCw2 ICszNCw3IEBADQo+Pj4+Pj4gwqDCoMKgICNpbmNsdWRlIDx4ZW4vc3ltYm9scy5oPg0KPj4+Pj4+ IMKgwqDCoCAjaW5jbHVkZSA8eGVuL3ZlcnNpb24uaD4NCj4+Pj4+PiDCoMKgwqAgI2luY2x1ZGUg PHhlbi92aXJ0dWFsX3JlZ2lvbi5oPg0KPj4+Pj4+ICsjaW5jbHVkZSA8eGVuL3ZwY2kuaD4NCj4+ Pj4+PiDCoMKgwqAgwqAgI2luY2x1ZGUgPHB1YmxpYy9zY2hlZC5oPg0KPj4+Pj4+IMKgwqDCoCAj aW5jbHVkZSA8cHVibGljL3hlbi5oPg0KPj4+Pj4+IEBAIC0yMzA0LDYgKzIzMDUsMTEgQEAgc3Rh dGljIGJvb2wgY2hlY2tfZm9yX3ZjcHVfd29yayh2b2lkKQ0KPj4+Pj4+IMKgwqDCoMKgwqDCoMKg IH0NCj4+Pj4+PiDCoMKgwqAgI2VuZGlmDQo+Pj4+Pj4gwqDCoMKgICvCoMKgwqAgbG9jYWxfaXJx X2VuYWJsZSgpOw0KPj4+Pj4+ICvCoMKgwqAgaWYgKCBoYXNfdnBjaSh2LT5kb21haW4pICYmIHZw Y2lfcHJvY2Vzc19wZW5kaW5nKHYpICkNCj4+Pj4+DQo+Pj4+PiBMb29raW5nIGF0IHRoZSBjb2Rl IG9mIHZwY2lfcHJvY2Vzc19wZW5kaW5nKCksIGl0IGxvb2tzIGxpa2UgdGhlcmUgYXJlIHNvbWUg cmV3b3JrIHRvIGRvIGZvciBndWVzdC4gRG8geW91IHBsYW4gdG8gaGFuZGxlIGl0IGFzIHBhcnQg b2YgdGhlIHZQQ0kgc2VyaWVzPw0KPj4+PiBZZXMsIHZQQ0kgY29kZSBpcyBoZWF2aWx5IHRvdWNo ZWQgdG8gc3VwcG9ydCBndWVzdCBub24taWRlbnRpdHkgbWFwcGluZ3MNCj4+Pg0KPj4+IEkgd2Fz bid0IHJlZmVycmluZyB0byB0aGUgbm9uLWlkZW50aXR5IG1hcHBpbmdzIGhlcmUuIEkgd2FzIHJl ZmVycmluZyB0byBUT0RPcyBzdWNoIGFzOg0KPj4+DQo+Pj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgIC8qDQo+Pj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgKiBGSVhNRTogaW4gY2FzZSBv ZiBmYWlsdXJlIHJlbW92ZSB0aGUgZGV2aWNlIGZyb20gdGhlIGRvbWFpbi4NCj4+PiDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoCAqIE5vdGUgdGhhdCB0aGVyZSBtaWdodCBzdGlsbCBiZSBsZWZ0 b3ZlciBtYXBwaW5ncy4gV2hpbGUgdGhpcyBpcw0KPj4+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgICogc2FmZSBmb3IgRG9tMCwgZm9yIERvbVVzIHRoZSBkb21haW4gd2lsbCBsaWtlbHkgbmVl ZCB0byBiZQ0KPj4+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgICoga2lsbGVkIGluIG9yZGVy IHRvIGF2b2lkIGxlYWtpbmcgc3RhbGUgcDJtIG1hcHBpbmdzIG9uDQo+Pj4gwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqAgKiBmYWlsdXJlLg0KPj4+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg ICovDQo+Pj4NCj4+PiBZb3Ugc3RpbGwgaGF2ZSB0aGVtIGFmdGVyIHRoZSBzZXJpZXMgcmV3b3Jr aW5nIHRoZSB2UENJLiBBcyBmb3IgdGhlIHByZWVtcHRpb24gdGhpcyBpcyBPSyB0byBpZ25vcmUg aXQgZm9yIGEgdGVjaCBwcmV2aWV3LiBBbHRob3VnaCwgd2Ugd2FudCB0byBhdCBsZWFzdCB0cmFj ayB0aGVtLg0KPj4gUGxlYXNlIHNlZSBhYm92ZTogYm90aCBtYXAgYW5kIHVubWFwIGFyZSBoYXBw ZW5pbmcgdmlhIHZwY2lfcHJvY2Vzc19wZW5kaW5nDQo+DQo+IEkgYW0gbm90IHN1cmUgaG93IHRo aXMgaXMgcmVsZXZhbnQgdG8gd2hhdCBJIGp1c3QgbWVudGlvbm5lZC4NCj4NCj4+Pg0KPj4+Pj4N Cj4+Pj4+PiArIHJhaXNlX3NvZnRpcnEoU0NIRURVTEVfU09GVElSUSk7DQo+Pj4+Pj4gK8KgwqDC oCBsb2NhbF9pcnFfZGlzYWJsZSgpOw0KPj4+Pj4+ICsNCj4+Pj4+DQo+Pj4+PiDCoMKgRnJvbSBt eSB1bmRlcnN0YW5kaW5nIG9mIHZjcGlfcHJvY2Vzc19wZW5kaW5nKCkuIFRoZSBmdW5jdGlvbiB3 aWxsIHJldHVybiB0cnVlIGlmIHRoZXJlIGFyZSBtb3JlIHdvcmsgdG8gc2NoZWR1bGUuDQo+Pj4+ IFllcw0KPj4+Pj4gSG93ZXZlciwgaWYgY2hlY2tfZm9yX3ZjcHVfZm9yX3dvcmsoKSByZXR1cm4g ZmFsc2UsIHRoZW4gd2Ugd2lsbCByZXR1cm4gdG8gdGhlIGd1ZXN0IGJlZm9yZSBhbnkgd29yayBm b3IgdkNQSSBoYXMgZmluaXNoZWQuIFRoaXMgaXMgYmVjYXVzZSBjaGVja19mb3JfdmNwdV93b3Jr KCkgd2lsbCBub3QgYmUgY2FsbGVkIGFnYWluLg0KPj4+PiBDb3JyZWN0DQo+Pj4+Pg0KPj4+Pj4g SW4gdGhpcyBjYXNlLCBJIHRoaW5rIHlvdSB3YW50IHRvIHJldHVybiBhcyBzb29uIGFzIHlvdSBr bm93IHdlIG5lZWQgdG8gcmVzY2hlZHVsZS4NCj4+Pj4gTm90IHN1cmUgSSB1bmRlcnN0YW5kIHRo aXMNCj4+Pg0KPj4gSSB3YXMgbW9yZSByZWZlcnJpbmcgdG8gIkkgdGhpbmsgeW91IHdhbnQgdG8g cmV0dXJuIGFzIHNvb24gYXMgeW91IGtub3cgd2UgbmVlZCB0byByZXNjaGVkdWxlLiINCj4+PiBU aGUgcmV0dXJuIHZhbHVlIG9mIGNoZWNrX2Zvcl92Y3B1X2Zvcl93b3JrKCkgaW5kaWNhdGVzIHdo ZXRoZXIgd2UgaGF2ZSBtb3JlIHdvcmsgdG8gZG8gYmVmb3JlIHJldHVybmluZyB0byByZXR1cm4g dG8gdGhlIGd1ZXN0Lg0KPj4+DQo+Pj4gV2hlbiB2cGNpX3Byb2Nlc3NfcGVuZGluZygpIHJldHVy bnMgdHJ1ZSwgaXQgdGVsbHMgdXMgd2UgbmVlZCB0byBjYWxsIHRoZSBmdW5jdGlvbiBhdCBsZWFz dCBvbmUgbW9yZSB0aW1lIGJlZm9yZSByZXR1cm5pbmcgdG8gdGhlIGd1ZXN0Lg0KPj4+DQo+Pj4g SW4geW91ciBjdXJyZW50IGltcGxlbWVudGF0aW9uLCB5b3UgbGVhdmUgdGhhdCBkZWNpc2lvbiB0 byB3aG9lZXZlciBpcyBuZXh0IGluIHRoZSBmdW5jdGlvbi4NCj4+Pg0KPj4+IEl0IGlzIG5vdCBz YWZlIHRvIHJldHVybiB0byB0aGUgZ3Vlc3QgYXMgbG9uZyBhcyB2cGNpX3Byb2Nlc3NfcGVuZGlu ZygpIHJldHVybnMgdHJ1ZS4gU28geW91IHdhbnQgdG8gd3JpdGUgc29tZXRoaW5nIGxpa2U6DQo+ Pj4NCj4+PiBpZiAoIHZwY2lfcHJvY2Vzc19wZW5kaW5nKCkgKQ0KPj4+IMKgwqAgcmV0dXJuIHRy dWU7DQo+PiAtLS0gYS94ZW4vYXJjaC9hcm0vdHJhcHMuYw0KPj4NCj4+ICsrKyBiL3hlbi9hcmNo L2FybS90cmFwcy5jDQo+PiBAQCAtMjI5MSw2ICsyMjkxLDkgQEAgc3RhdGljIGJvb2wgY2hlY2tf Zm9yX3ZjcHVfd29yayh2b2lkKQ0KPj4gwqAgwqB7DQo+PiDCoCDCoMKgwqDCoCBzdHJ1Y3QgdmNw dSAqdiA9IGN1cnJlbnQ7DQo+Pg0KPj4gK8KgwqDCoCBpZiAoIHZwY2lfcHJvY2Vzc19wZW5kaW5n KCkgKQ0KPj4gK8KgwqDCoMKgwqAgcmV0dXJuIHRydWU7DQo+PiArDQo+PiDCoCDCoCNpZmRlZiBD T05GSUdfSU9SRVFfU0VSVkVSDQo+PiDCoCDCoMKgwqDCoCBpZiAoIGRvbWFpbl9oYXNfaW9yZXFf c2VydmVyKHYtPmRvbWFpbikgKQ0KPj4gwqAgwqDCoMKgwqAgew0KPj4gRG8geW91IG1lYW4gc29t ZXRoaW5nIGxpa2UgdGhpcz8NCj4NCj4gWWVzLg0KT2ssIEknbGwgYWRkIHRoaXMgY2hlY2sNCj4N Cj4+Pj4+IEhvd2V2ZXIsIGxvb2tpbmcgYXQgdGhlIHJlc3Qgb2YgdGhlIGNvZGUsIHdlIGFscmVh ZHkgaGF2ZSBhIGNoZWNrIGZvciB2cGNpIGluIHRoZSBjb21tb24gSU9SRVEgY29kZS4NCj4+Pj4N Cj4+Pj4gV2hpY2ggbWF5IG5vdCBiZSBlbmFibGVkIGFzIGl0IGRlcGVuZHMgb24gQ09ORklHX0lP UkVRX1NFUlZFUi4NCj4+Pg0KPj4+IFJpZ2h0LiBNeSBwb2ludCBpcyB3aGVuIENPTkZJR19JT1JF UV9TRVJWRVIgaXMgc2V0IHRoZW4geW91IHdvdWxkIGVuZCB1cCB0byBjYWxsIHR3aWNlIHZwY2lf cHJvY2Vzc19wZW5kaW5nKCkuIFRoaXMgd2lsbCBoYXZlIGFuIGltcGFjdCBob3cgb24gbG9uZyB5 b3VyIHZDUFUgaXMgZ29pbmcgdG8gcnVubmluZyBiZWNhdXNlIHlvdSBhcmUgZG91YmxpbmcgdGhl IHdvcmsuDQo+Pg0KPj4gU28sIHlvdSBzdWdnZXN0IHRoYXQgd2UgaGF2ZSBpbiB0aGUgY29tbW9u IElPUkVRIGNvZGUgc29tZXRoaW5nIGNhbGwgbGlrZQ0KPj4NCj4+IGFyY2hfdnBjaV9wcm9jZXNz X3BlbmRpbmc/IEluIGNhc2Ugb2YgeDg2IGl0IHdpbGwgaGF2ZSB0aGUgY29kZSBjdXJyZW50bHkg Zm91bmQgaW4gdGhlDQo+Pg0KPj4gY29tbW9uIElPUkVRIHNvdXJjZXMgYW5kIGZvciBBcm0gaXQg d2lsbCBiZSBub3A/DQo+DQo+IE5vIEkgYW0gc3VnZ2VzdGluZyB0byBtb3ZlIHRoZSBjYWxsIG9m IHRoZSBJT1JFUSBjb2RlIHRvIGh2bV9kb19yZXN1bWUoKSAob24geDg2KSBhbmQgY2hlY2tfZm9y X3ZjcHVfd29yaygpIChvbiBBcm0pLg0KDQpPaywgSSBjYW4gbW92ZSB2UENJIGNvZGUgdG8gaHZt X2RvX3Jlc3VtZSwgYnV0IHZQQ0kgaXMgb25seSB1c2VkIGZvciB4ODYgUFZIIERvbTAuDQoNCkRv IHlvdSBzdGlsbCB0aGluayBodm1fZG9fcmVzdW1lIGlzIHRoZSByaWdodCBwbGFjZT8NCg0KPg0K PiBDaGVlcnMsDQo+DQpUaGFua3MsDQoNCk9sZWtzYW5kcg0K From xen-devel-bounces@lists.xenproject.org Mon Sep 06 10:11:19 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Sep 2021 10:11:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.179572.325899 (Exim 4.92) (envelope-from ) id 1mNBau-0006DJ-Ay; Mon, 06 Sep 2021 10:11:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 179572.325899; Mon, 06 Sep 2021 10:11:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNBau-0006DC-7l; Mon, 06 Sep 2021 10:11:16 +0000 Received: by outflank-mailman (input) for mailman id 179572; Mon, 06 Sep 2021 10:11:15 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNBat-000682-1A; Mon, 06 Sep 2021 10:11:15 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNBas-0001Cp-GD; Mon, 06 Sep 2021 10:11:14 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNBas-0001Of-6y; Mon, 06 Sep 2021 10:11:14 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mNBas-00019K-6P; Mon, 06 Sep 2021 10:11:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=MJhPdTBfKkaJ1rOsrpkR6ZFKuUZSALrBCC9jR+rOdtc=; b=J4M9uFjRnIbhh9amHbJe48klkE M19CGQmR4PFpHQxKcm/iqeuu7uo7LARAzVu4i9mYT36IBDbOMqJCy5+NYPX5lClTd3QchJ7QtoLiQ IOVF4d6YTPfMJ6x2fpLnRVP8+OcVquPyLu8kvmYCZKqiRJ+AH46rSfHJmcm6XJrHkNf0=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 164852: regressions - FAIL X-Osstest-Failures: libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=b6ec01b82154c9dc25f18c9c28df30d0c053defe X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Mon, 06 Sep 2021 10:11:14 +0000 flight 164852 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/164852/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a version targeted for testing: libvirt b6ec01b82154c9dc25f18c9c28df30d0c053defe baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 423 days Failing since 151818 2020-07-11 04:18:52 Z 422 days 413 attempts Testing same since 164803 2021-09-04 04:20:08 Z 2 days 3 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Andika Triwidada Andrea Bolognani Balázs Meskó Barrett Schonefeld Bastian Germann Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Bjoern Walk Boris Fiuczynski Brian Turek Bruno Haible Chris Mayo Christian Ehrhardt Christian Kirbach Christian Schoenebeck Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé Didik Supriadi Dmytro Linkin Eiichi Tsukata Eric Farman Erik Skultety Fabian Affolter Fabian Freyer Fabiano Fidêncio Fangge Jin Farhan Ali Fedora Weblate Translation gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Hela Basa Helmut Grohne Ian Wienand Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen jason lee Jean-Baptiste Holcroft Jia Zhou Jianan Gao Jim Fehlig Jin Yan Jinsheng Zhang Jiri Denemark John Ferlan Jonathan Watt Jonathon Jongsma Julio Faracco Justin Gatzen Ján Tomko Kashyap Chamarthy Kevin Locke Kristina Hanicova Laine Stump Laszlo Ersek Lee Yarwood Liao Pingfang Lin Ma Lin Ma Lin Ma Liu Yiding Luke Yue Luyao Zhong Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Markus Schade Martin Kletzander Masayoshi Mizuma Matej Cepl Matt Coleman Matt Coleman Mauro Matteo Cascella Meina Li Michal Privoznik Michał Smyk Milo Casagrande Moshe Levi Muha Aliss Nathan Neal Gompa Nick Shyrokovskiy Nickys Music Group Nico Pache Nikolay Shirokovskiy Olaf Hering Olesya Gerasimenko Orion Poplawski Pany Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Richard W.M. Jones Ricky Tigg Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Shambarger Sebastian Mitterle SeongHyun Jo Shalini Chellathurai Saroja Shaojun Yang Shi Lei simmon Simon Chopin Simon Gaiser Simon Rowe Stefan Bader Stefan Berger Stefan Berger Stefan Hajnoczi Szymon Scholz Thomas Huth Tim Wiederhake Tomáš Golembiovský Tomáš Janoušek Tuguoyi Ville Skyttä Vinayak Kale Wang Xin WangJian Weblate Wei Liu Wei Liu William Douglas Yalei Li <274268859@qq.com> Yalei Li Yang Fei Yang Hang Yanqiu Zhang Yaroslav Kargin Yi Li Yi Wang Yuri Chornoivan Zbigniew Jędrzejewski-Szmek zhangjl02 Zheng Chuan zhenwei pi Zhenyu Ye Zhenyu Zheng Zhenzhong Duan jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 71803 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Sep 06 10:14:59 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Sep 2021 10:14:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.179580.325913 (Exim 4.92) (envelope-from ) id 1mNBeT-0006wQ-Vi; Mon, 06 Sep 2021 10:14:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 179580.325913; Mon, 06 Sep 2021 10:14:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNBeT-0006wJ-SS; Mon, 06 Sep 2021 10:14:57 +0000 Received: by outflank-mailman (input) for mailman id 179580; Mon, 06 Sep 2021 10:14:56 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNBeS-0006wC-0Z for xen-devel@lists.xenproject.org; Mon, 06 Sep 2021 10:14:56 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (unknown [40.107.8.71]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 3dd26814-38ef-4cfa-a295-bb1acdd50157; Mon, 06 Sep 2021 10:14:54 +0000 (UTC) Received: from AM5PR0601CA0033.eurprd06.prod.outlook.com (2603:10a6:203:68::19) by DBBPR08MB5899.eurprd08.prod.outlook.com (2603:10a6:10:208::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19; Mon, 6 Sep 2021 10:14:51 +0000 Received: from VE1EUR03FT051.eop-EUR03.prod.protection.outlook.com (2603:10a6:203:68:cafe::e8) by AM5PR0601CA0033.outlook.office365.com (2603:10a6:203:68::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.17 via Frontend Transport; Mon, 6 Sep 2021 10:14:51 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT051.mail.protection.outlook.com (10.152.19.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Mon, 6 Sep 2021 10:14:51 +0000 Received: ("Tessian outbound 620209b93b95:v105"); Mon, 06 Sep 2021 10:14:51 +0000 Received: from f3725336c883.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 8922800A-C75C-4DE7-B23E-14EE9528B054.1; Mon, 06 Sep 2021 10:14:42 +0000 Received: from FRA01-MR2-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id f3725336c883.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 06 Sep 2021 10:14:42 +0000 Received: from PAXPR08MB6446.eurprd08.prod.outlook.com (2603:10a6:102:12d::10) by PR2PR08MB4665.eurprd08.prod.outlook.com (2603:10a6:101:25::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.17; Mon, 6 Sep 2021 10:14:40 +0000 Received: from PAXPR08MB6446.eurprd08.prod.outlook.com ([fe80::c029:ed0:82e7:3c2f]) by PAXPR08MB6446.eurprd08.prod.outlook.com ([fe80::c029:ed0:82e7:3c2f%6]) with mapi id 15.20.4478.025; Mon, 6 Sep 2021 10:14:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3dd26814-38ef-4cfa-a295-bb1acdd50157 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uzHDmyjnh5LGIpbyruutxpYRl2HOE5gt7OKhwpi2jLE=; b=7wzyXKu9xb8dGzDWGVozFOJf5zwm5PpWjQ9IkZ4kBP/IWYs2WMMLZcxxjzcwVEJ1K7/Iyf5+wua2fj9RAE/lI9pM590LHJNoOxd3mgDic/pR8JZOLMHBwVgz4M+Z8uvoPoYtt234SYyLS62Sr0HFRslIsAJcLwkqREr5CS8lrd4= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: c83646bd47ee1174 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dxYMsosEaTZ9CSJ4MU1ItPJz+pLEzyMfBWLzOAtzt27pYkb5Bk5t2inN4O/H59Ah8VnxhXkZAflD63xx0z30rPyXZo4vqxHuS0nYmEKGNu1whZPc6u+e/Ut4sec/UQ+DUhKr6ADWySQFCVM0YbpvdL7BkBj3/lzG7arjDYRnxT5gB2Cn57s6zwCZbBWjjIBq8ynl2gzovo6fVuJhbWH3+b8q91/nFciDFOsGc28wQbgkY7GqKUjWUV27BCe5sIB7DsRW/G2xhieorFX0f6DFowUTIFjMRk8MbGotCM6kFIW581S1yHYsMJztU3DwRMQo5fNsIvN+ngIyDCMG1d1Ptw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=uzHDmyjnh5LGIpbyruutxpYRl2HOE5gt7OKhwpi2jLE=; b=nynDTTETRYYsOgNWHfleHhkmJT7MEihvuZYAPN/8nklf+zEftzYjhsjyJhAyBpIVOlTXkLRUEWQvmWVnv8tRDUbRf5GElm0hikf72zA6CZ6uTZkWDVKPeewuTRxRcsnYvftlBPc7mfqQyhOeMryhEzyb9JqWb6LYS+VaRAX1LUHnFPQWza/stnQ5zT1RjJ9ty3JpcmvJacsxtlmOk9EbTGwwc8lZBNSKw8n2KAZmK1a7TRDa03E+KTTODZ0dxcKTNdkbZ5C+hM2eKbPFxMQqX/ZgQ2r8kFvC1jg9LQ694fhMe+SiVlqPalX5Rl+2kvd/dx86kxP/zgzIHL0Co9hS6Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uzHDmyjnh5LGIpbyruutxpYRl2HOE5gt7OKhwpi2jLE=; b=7wzyXKu9xb8dGzDWGVozFOJf5zwm5PpWjQ9IkZ4kBP/IWYs2WMMLZcxxjzcwVEJ1K7/Iyf5+wua2fj9RAE/lI9pM590LHJNoOxd3mgDic/pR8JZOLMHBwVgz4M+Z8uvoPoYtt234SYyLS62Sr0HFRslIsAJcLwkqREr5CS8lrd4= From: Bertrand Marquis To: Juergen Gross CC: Andrew Cooper , Xen-devel , Julien Grall , Stefano Stabellini , Dario Faggioli Subject: Re: Crash when using cpupools Thread-Topic: Crash when using cpupools Thread-Index: AQHXoNo0twqKn1RLAkCotEsfXja8k6uWr0+AgAAGR4CAAAvYAIAADN6A Date: Mon, 6 Sep 2021 10:14:39 +0000 Message-ID: References: <5b0a4530-72df-a186-9bd5-50759b3dd151@suse.com> <41b5e46e-daad-82f0-63f0-1efe431ca695@suse.com> In-Reply-To: <41b5e46e-daad-82f0-63f0-1efe431ca695@suse.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3654.120.0.1.13) Authentication-Results-Original: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=arm.com; x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: 79cc6872-6e4f-4a59-c34f-08d9711f2a2b x-ms-traffictypediagnostic: PR2PR08MB4665:|DBBPR08MB5899: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:9508;OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: HiGygZbc+05kS2syjfEmYL3TKeGDyJwrUphxidA9Mc5EHCleZOlZOdbEx8heb2Bu5uPhsQDdl47ky23KDLqov8b8p0JDpUllGgvr8mkRHgH+747C3nc6GdO0yUYzEK7YeOs8VNa3l3GoEubxt6JIl44soyTDki3maMNAbbIBxqT8O+HoruRy8RfHi6Zq1frUzqtG2a+qBrTHn0D+GA7KJVp3MVsz+r4WRzdJzBkJY58M5fdzrU4PRxepc41xae25kislEnqG6Fo+0G0ifLfkdqgKkKma9ap8Jj8Cu1DEBV8gOsEY5jFN4XIcswYoJdUjUhvnTPp2iHzceHxATRxUpe4xLTZ24wU7vxCpyjhE3YBRxPa8Ago094+FCRNEp9+KFBzxMzvGTrPiotNtEduI/1+MhhP6HzUq9irebL3Fithz4L6RUsejkIpSHqUsYuer0xo1GqVB71YkLETU+GR1+c9SWSU3tubYZEONtSONvRZXzmFoUGAVdxeK8/UxvN0jONNnpSnQ2sHNUQ47hrmLS9v669B/z+WAnZxrvTu2EmURScXLyWOnUhCx2qz4g1ls7NAxgicoEdTS/lSBsXRjue+QW72FzTaKQfBqQ0T5t/zpsUJTraVupdORDn2bZCzWcFhevnI7rFF3/U0StwdEelpExCU8Pc0OlVuUn40VxQRXkunbj8N6SSxfVAA3vrqAuGJDd/FvEqeZL7Isbsa3T0t35JY1CdVdjkxpukU0z1M= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB6446.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(366004)(39860400002)(136003)(396003)(346002)(8676002)(6512007)(66556008)(478600001)(186003)(66476007)(38070700005)(64756008)(36756003)(6916009)(66446008)(76116006)(91956017)(2906002)(86362001)(83380400001)(6506007)(53546011)(3480700007)(71200400001)(54906003)(5660300002)(2616005)(4326008)(122000001)(316002)(66946007)(38100700002)(8936002)(26005)(6486002)(33656002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR2PR08MB4665 Original-Authentication-Results: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT051.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 6ef4d185-d307-47ee-88dc-08d9711f2341 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lmV0IZJ4pSh8wRUNd26QEZzegHO2z1kxCLV1tDw81hkfUKg8fSte+Zpw8+Zp/GOmG+/i9L2SGTsS4LwJmV42/ofgbh9Gmqb/HO5eJFwhnwpJlycSIuzUy5/uwAlvN2IxmPWMwFujAvMUiPGHhXL3yYtiC4XCE59ZbbuF0EUEWNl1QbEqarUs3Jb4eDz5OaTgSG5msZw5Hr+9jns38exEwebI3HgOVpZCmC38+yKq3S0MPci2jfB3pYAQzKs+1QTHRvRCR+NaSoIsivvO4yofTKkvdlH2/WptPTmmE6r4aidYQj5q+Whr9HdP3vF9AUtqXSIxoEZ2UbD3pJmJZxEviwIrJN3js+K+s8yaiPUOeOhACJbrwlc8kLVSph17gyqmUhdOSBcaOw84kjn9rFlPQGc5STOooonLwJxrTAjJsAXrSoQrXup+sAKtEcB2vEPUfXrVwEc7WrKtX8imYoUGonzj8+qPT8PB0O/978ck/vJnhwX+SoCuyPnj7RjJxtikABfTiSi3io9zcD0PawsEccCeFiX35WDm22TPvNNplFTVoTTbBrP1H90HrnGWhQ8cgocpNqYHejlGQ93Ztk1KgG9bgGYT/fF/sgg2VxROWdUZ9ViFJH8Wn+SJAPf5b+p+8wsSyJWljinaXE6OhygMODY/AclNL5FDmMq3+SnEJYJDwCR1A1DXjWL/rQXUG0wO7J2XSZ4caXGPsRFPuvQf1A== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(396003)(39860400002)(376002)(136003)(346002)(36840700001)(46966006)(26005)(107886003)(356005)(36756003)(3480700007)(86362001)(6486002)(70206006)(70586007)(186003)(8676002)(83380400001)(2906002)(4326008)(53546011)(6506007)(82740400003)(81166007)(6862004)(336012)(5660300002)(47076005)(36860700001)(2616005)(82310400003)(8936002)(316002)(33656002)(478600001)(54906003)(6512007);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2021 10:14:51.3972 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 79cc6872-6e4f-4a59-c34f-08d9711f2a2b X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT051.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB5899 SEkgSnVlcmdlbiwNCg0KPiBPbiA2IFNlcCAyMDIxLCBhdCAxMDoyOCwgSnVlcmdlbiBHcm9zcyA8 amdyb3NzQHN1c2UuY29tPiB3cm90ZToNCj4gDQo+IE9uIDA2LjA5LjIxIDEwOjQ2LCBBbmRyZXcg Q29vcGVyIHdyb3RlOg0KPj4gT24gMDYvMDkvMjAyMSAwOToyMywgSnVlcmdlbiBHcm9zcyB3cm90 ZToNCj4+PiBPbiAwMy4wOS4yMSAxNzo0MSwgQmVydHJhbmQgTWFycXVpcyB3cm90ZToNCj4+Pj4g SGksDQo+Pj4+IA0KPj4+PiBXaGlsZSBkb2luZyBzb21lIGludmVzdGlnYXRpb24gd2l0aCBjcHVw b29scyBJIGVuY291bnRlcmVkIGEgY3Jhc2gNCj4+Pj4gd2hlbiB0cnlpbmcgdG8gaXNvbGF0ZSBh IGd1ZXN0IHRvIGl0cyBvd24gcGh5c2ljYWwgY3B1Lg0KPj4+PiANCj4+Pj4gSSBhbSB1c2luZyBj dXJyZW50IHN0YWdpbmcgc3RhdHVzLg0KPj4+PiANCj4+Pj4gSSBkaWQgdGhlIGZvbGxvd2luZyAo b24gRlZQIHdpdGggOCBjb3Jlcyk6DQo+Pj4+IC0gc3RhcnQgZG9tMCB3aXRoIGRvbTBfbWF4X3Zj cHVzPTENCj4+Pj4gLSByZW1vdmUgY29yZSAxIGZyb20gZG9tMCBjcHVwb29sOiB4bCBjcHVwb29s LWNwdS1yZW1vdmUgUG9vbC0wIDENCj4+Pj4gLSBjcmVhdGUgYSBuZXcgcG9vbDogeGwgY3B1cG9v bC1jcmVhdGUgbmFtZT1cIk5ldFBvb2xc4oCdDQo+Pj4+IC0gYWRkIGNvcmUgMSB0byB0aGUgcG9v bDogeGwgY3B1cG9vbC1jcHUtYWRkIE5ldFBvb2wgMQ0KPj4+PiAtIGNyZWF0ZSBhIGd1ZXN0IGlu IE5ldFBvb2wgdXNpbmcgdGhlIGZvbGxvd2luZyBpbiB0aGUgZ3Vlc3QgY29uZmlnOg0KPj4+PiBw b29sPeKAnE5ldFBvb2wiDQo+Pj4+IA0KPj4+PiBJIGVuZCB3aXRoIGEgY3Jhc2ggd2l0aCB0aGUg Zm9sbG93aW5nIGNhbGwgdHJhY2UgZHVyaW5nIGd1ZXN0IGNyZWF0aW9uOg0KPj4+PiAoWEVOKSBY ZW4gY2FsbCB0cmFjZToNCj4+Pj4gKFhFTikgICAgWzwwMDAwMDAwMDAwMjM0Y2IwPl0gY3JlZGl0 Mi5jI2NzY2hlZDJfYWxsb2NfdWRhdGErMHg1OC8weGZjDQo+Pj4+IChQQykNCj4+Pj4gKFhFTikg ICAgWzwwMDAwMDAwMDAwMjM0YzgwPl0gY3JlZGl0Mi5jI2NzY2hlZDJfYWxsb2NfdWRhdGErMHgy OC8weGZjDQo+Pj4+IChMUikNCj4+Pj4gKFhFTikgICAgWzwwMDAwMDAwMDAwMjQyZDM4Pl0gc2No ZWRfbW92ZV9kb21haW4rMHgxNDQvMHg2YzANCj4+Pj4gKFhFTikgICAgWzwwMDAwMDAwMDAwMjJk ZDE4Pl0NCj4+Pj4gY3B1cG9vbC5jI2NwdXBvb2xfbW92ZV9kb21haW5fbG9ja2VkKzB4MzgvMHg3 MA0KPj4+PiAoWEVOKSAgICBbPDAwMDAwMDAwMDAyMmZhZGM+XSBjcHVwb29sX2RvX3N5c2N0bCsw eDczYy8weDc4MA0KPj4+PiAoWEVOKSAgICBbPDAwMDAwMDAwMDAyMmQ4ZTA+XSBkb19zeXNjdGwr MHg3ODgvMHhhNTgNCj4+Pj4gKFhFTikgICAgWzwwMDAwMDAwMDAwMjczYjY4Pl0gdHJhcHMuYyNk b190cmFwX2h5cGVyY2FsbCsweDc4LzB4MTcwDQo+Pj4+IChYRU4pICAgIFs8MDAwMDAwMDAwMDI3 NGY3MD5dIGRvX3RyYXBfZ3Vlc3Rfc3luYysweDEzOC8weDYxOA0KPj4+PiAoWEVOKSAgICBbPDAw MDAwMDAwMDAyNjA0NTg+XSBlbnRyeS5vI2d1ZXN0X3N5bmNfc2xvd3BhdGgrMHhhNC8weGQ0DQo+ Pj4+IA0KPj4+PiBBZnRlciBzb21lIGRlYnVnZ2luZyBJIGZvdW5kIG91dCB0aGF0IHVuaXQtPnZj cHVfbGlzdCBpcyBOVUxMIGFmdGVyDQo+Pj4+IHVuaXQtPnZjcHVfbGlzdCA9IGQtPnZjcHVbdW5p dC0+dW5pdF9pZF07IHdpdGggdW5pdF9pZCAwIGluDQo+Pj4+IGNvbW1vbi9zY2hlZC9jb3JlLmM6 Njg4DQo+Pj4+IFRoaXMgbWFrZXMgdGhlIGNhbGwgdG8gaXNfaWRsZV91bml0KHVuaXQpIGluIGNz Y2hlZDJfYWxsb2NfdWRhdGENCj4+Pj4gdHJpZ2dlciB0aGUgY3Jhc2guDQo+Pj4gDQo+Pj4gU28g dGhlcmUgaXMgbm8gdmNwdSAwIGluIHRoYXQgZG9tYWluPyBIb3cgaXMgdGhpcyBwb3NzaWJsZT8N Cj4+IEVhc3ksIGRlcGVuZGluZyBvbiB0aGUgb3JkZXIgb2YgaHlwZXJjYWxscyBpc3N1ZWQgYnkg dGhlIHRvb2xzdGFjay4NCj4+IEJldHdlZW4gRE9NQ1RMX2NyZWF0ZWRvbWFpbiBhbmQgRE9NQ1RM X21heF92Y3B1cywgdGhlIGRvbWFpbiBleGlzdHMgYnV0DQo+PiB0aGUgdmNwdXMgaGF2ZW4ndCBi ZWVuIGFsbG9jYXRlZC4NCj4gDQo+IE9oIHllcywgaW5kZWVkLg0KPiANCj4gQmVydHJhbmQsIGRv ZXMgdGhlIGF0dGFjaGVkIHBhdGNoIGZpeCB0aGUgaXNzdWUgZm9yIHlvdT8NCg0KSXQgZG9lcywg bXkgZ3Vlc3QgaXMgbm93IGJvb3RpbmcgcHJvcGVybHkgOi0pDQpTbyB0aGlzIGlzIHNvbHZpbmcg dGhlIGlzc3VlIG9uIGFybSAoYW5kIHByb2JhYmx5IG9uIHg4NiBpZiBpdCB3YXMgcHJlc2VudCBi dXQgdW50ZXN0ZWQgYnkgbWUpLg0KDQpGZWVsIGZyZWUgdG8gYWRkIHRvIHlvdXIgcGF0Y2ggbXk6 DQpSZXZpZXdlZC1ieTogQmVydHJhbmQgTWFycXVpcyA8YmVydHJhbmQubWFycXVpc0Bhcm0uY29t Pg0KDQpUaGFua3MgYSBsb3QgZm9yIHRoZSBxdWljayBmaXgNCkNoZWVycw0KQmVydHJhbmQNCg0K PiANCj4gDQo+IEp1ZXJnZW4NCj4gPDAwMDEteGVuLXNjaGVkLWZpeC1zY2hlZF9tb3ZlX2RvbWFp bi1mb3ItZG9tYWluLXdpdGhvdXQtdi5wYXRjaD48T3BlblBHUF8weEIwREU5REQ2MjhCRjEzMkYu YXNjPg0KDQo= From xen-devel-bounces@lists.xenproject.org Mon Sep 06 10:17:57 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Sep 2021 10:17:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.179586.325923 (Exim 4.92) (envelope-from ) id 1mNBhI-0007aQ-D2; Mon, 06 Sep 2021 10:17:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 179586.325923; Mon, 06 Sep 2021 10:17:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNBhI-0007aJ-A8; Mon, 06 Sep 2021 10:17:52 +0000 Received: by outflank-mailman (input) for mailman id 179586; Mon, 06 Sep 2021 10:17:50 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNBhG-0007aD-7o for xen-devel@lists.xenproject.org; Mon, 06 Sep 2021 10:17:50 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNBhG-0001JG-1F; Mon, 06 Sep 2021 10:17:50 +0000 Received: from 54-240-197-236.amazon.com ([54.240.197.236] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1mNBhF-00030S-R7; Mon, 06 Sep 2021 10:17:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=2AS3K2FbI2bd9Qg1w3F4RKn4dZ2PjVJc8kXf8TTYLZE=; b=DZo8XLD/EXOqvOcc85kZL0s9pa zz4LMwrPN1yu0acKVKzXtdGEgjtridSe1DScoiuanx6fGTjQwMZCdVKK0P3GNeRKI3a7AJgptiWJa Q/Rwihi2aUwpbXRFBApoTkwXm4p/pL8F8AZdIio58CLh7ctUNt0nyX3zfn+HJf09kJyA=; Subject: Re: About Arm guests accessing to GICD_ICPENR To: Hongda Deng , Wei Chen , "xen-devel@lists.xenproject.org" Cc: Bertrand Marquis , nd References: From: Julien Grall Message-ID: <9152003b-87c6-f9ac-1754-db1eba86a6c3@xen.org> Date: Mon, 6 Sep 2021 11:17:48 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit On 06/09/2021 10:04, Hongda Deng wrote: > Hi Julien, Hi Hongda, > Xen provides vGIC to support Xen guests, and currently xen will return IO > unhandled when guests access GICD ICPENRn registers. This works fine with Linux > guests, for Linux won't access these registers. But for Zephyr, this mechanism > will cause IO dataabort on Zephyr's initialization which makes Zephyr get in > fatal error. > > One method to ease this is to let vGIC ignore GICD ICPENRn registers access. I > tested it with Linux guests and Zephyr guests, and both works fine. And I found > in this patch[1] that it would be more complex to touch the read part for > I{S,C}PENDR and the write part for ICPENDR, Read to I{S,C}PENDR should already return. AFAIK, what's left unimplemented is write to ICPENDR. > so could we ignore GICD ICPENDRn > registers access to ease Zephyr's initialization problem? Would you be able to provide more information on how Zephyr is using it? > > If Xen wants a complete GICD ICPENDRn emulation to fix it, do you have any > suggestions. Emulating ICPENDR is not easy with the existing vGIC. It would be great to finally have a vGIC spec compliant, but I also appreciate this is going to take some time. Ignoring the access is probably the best we can do. However, this is also a risky approach because Zephyr (or another OS) may genuinely want to clear an already pending interrupt. So I would suggest to walk the interrupts that are meant to be modified and check whether they are already pending. If they are then print a message. This would make clear to the developper that something may go wrong later on. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Sep 06 10:18:44 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Sep 2021 10:18:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.179592.325935 (Exim 4.92) (envelope-from ) id 1mNBi8-00089t-O6; Mon, 06 Sep 2021 10:18:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 179592.325935; Mon, 06 Sep 2021 10:18:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNBi8-00089m-Kz; Mon, 06 Sep 2021 10:18:44 +0000 Received: by outflank-mailman (input) for mailman id 179592; Mon, 06 Sep 2021 10:18:43 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNBi7-00089a-Dm; Mon, 06 Sep 2021 10:18:43 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNBi7-0001Jz-8d; Mon, 06 Sep 2021 10:18:43 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNBi7-0001dM-03; Mon, 06 Sep 2021 10:18:43 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mNBi6-0002w9-Vn; Mon, 06 Sep 2021 10:18:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=CTYTAy+nlz9uYwpVeMto9bCcMl9eD5MZtSvV6DyBN58=; b=MPAyFi4IQxWudmHZFrT9E77gKG 7vrrHLd3KHsFk0vAeoSkkS8Hx+okBNlPP69LciVBT1/F8xLff0dYwjy3PzCA7eYibyPi52TBPK0Fo wqhFhnQbM94I2aQV+9N7OMaVummHhEL8GWh6UvhqkK0UMYKD95fp5XdyvxQ75kUWyJG8=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 164854: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=edf8bc6d24c6f490c27de3144eee88f1ca40ce6a X-Osstest-Versions-That: ovmf=cae735f61328d64e2e8991036707b9e78c0f5f63 From: osstest service owner Date: Mon, 06 Sep 2021 10:18:42 +0000 flight 164854 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/164854/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 164674 build-amd64 6 xen-build fail REGR. vs. 164674 build-i386-xsm 6 xen-build fail REGR. vs. 164674 build-i386 6 xen-build fail REGR. vs. 164674 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf edf8bc6d24c6f490c27de3144eee88f1ca40ce6a baseline version: ovmf cae735f61328d64e2e8991036707b9e78c0f5f63 Last test of basis 164674 2021-08-31 02:56:52 Z 6 days Failing since 164686 2021-09-01 03:03:43 Z 5 days 63 attempts Testing same since 164806 2021-09-04 09:41:21 Z 2 days 37 attempts ------------------------------------------------------------ People who touched revisions under test: Anthony PERARD DunTan Gary Lin Hao A Wu Jim Fehlig Lin, Gary (HPS OE-Linux) Loo Tung Lun Loo, Tung Lun Mark Wilson Marvin H?user Michael Kubacki Rebecca Cran Wenxing Hou Wenyi Xie jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 302 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Sep 06 10:30:21 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Sep 2021 10:30:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.179601.325949 (Exim 4.92) (envelope-from ) id 1mNBtI-0002CP-SH; Mon, 06 Sep 2021 10:30:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 179601.325949; Mon, 06 Sep 2021 10:30:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNBtI-0002CI-Oa; Mon, 06 Sep 2021 10:30:16 +0000 Received: by outflank-mailman (input) for mailman id 179601; Mon, 06 Sep 2021 10:30:15 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNBtH-0002CC-PY for xen-devel@lists.xenproject.org; Mon, 06 Sep 2021 10:30:15 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 06a6541f-ce3f-4f1a-a113-55bf8351e0b5; Mon, 06 Sep 2021 10:30:14 +0000 (UTC) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04lp2053.outbound.protection.outlook.com [104.47.14.53]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-8-r2swLOZBMM-JLY12322v_A-1; Mon, 06 Sep 2021 12:30:12 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR04MB5470.eurprd04.prod.outlook.com (2603:10a6:803:d6::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.21; Mon, 6 Sep 2021 10:30:10 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4478.025; Mon, 6 Sep 2021 10:30:10 +0000 Received: from [10.156.60.236] (37.24.206.209) by PR2P264CA0046.FRAP264.PROD.OUTLOOK.COM (2603:10a6:101:1::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.17 via Frontend Transport; Mon, 6 Sep 2021 10:30:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 06a6541f-ce3f-4f1a-a113-55bf8351e0b5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1630924213; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ld/f2dx1cE58n/YMzJDEy0DH6VXjkwcYdaqKpjFUdSg=; b=Eb+7ryE+zak+472LJ4pLf1WaaZXc1mAsJDvOOXyt+SNYN1E9i1evQ+HmxuqTtR3XbFBb18 cLjySN9krS3zASj6735P/9pHpAY4FpN81SBcI5jqClT7MTxD3a+NpFmke5BZlN9kgByb/a V5DJdWQjMWDfuVXINnsGbYnJMWJeE9s= X-MC-Unique: r2swLOZBMM-JLY12322v_A-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HKLLUw5OGe9ljUCFPEp1GmutQSR6e5A1oJ6vFxbMgk67g3EUht+39Im0yr5dECSdSH7C0dmCluOojrp4Z3pQl+FqM3mKUA59Iq0+NS7eiS6IYBh7lLnboKG+g/vU/D5YU2ADztMfZ0B8IVWjOgv8DMHuS8QFijFsC+6eXO5apgOWzj7vwC5wfhM6BQureYg9r4MjElcsa0zLypfa7EdVFylar5R5vnu1dwpLHfd4B2A7wsvrjKmetmFErKMqqSe/fMtBpn7FvRXKiuOAYf2YnRrcAQdSoF5p9q1ItA4aspXKdJVPlINvoXySROIawgTm13TkSy+ZAn26bTRHGK8aIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=Ld/f2dx1cE58n/YMzJDEy0DH6VXjkwcYdaqKpjFUdSg=; b=R1PjiE7mdimW/MIqkvFGXBxs52KySlIne9ltnszRY4jj9trvpkYO85rnhuc8x3zZBra4Gnc2pxv4zH5F0vfOAzPICGMRgs8mltWeQI80s0y0Tz9t0yCyGQqZxgGxQtAk8upLIChiREoZuvOVPMr5zcmVoDrx6vK26p5fX87JDIqhAJp71icL0dWCDWZbLSB8f3/ZiD6SwzWXdvUr6j06ngc1tNBwHQu4/i87Agc65pAr00E4ZNpgiSPDpxBcg6a49sBUlLv7UrUVElZi6FCTW5QtENf6+utHYcFUiSLt6A0NJzdaHK4+13gtWswRRTn53bXDH1wLBErFsS311LqfHQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com; Subject: Re: [XEN PATCH v7 01/51] build: introduce cpp_flags macro To: Anthony PERARD Cc: Andrew Cooper , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Tim Deegan , xen-devel@lists.xenproject.org References: <20210824105038.1257926-1-anthony.perard@citrix.com> <20210824105038.1257926-2-anthony.perard@citrix.com> From: Jan Beulich Message-ID: <280c5579-ee62-ed36-1f08-58fe5b9ca34f@suse.com> Date: Mon, 6 Sep 2021 12:30:07 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PR2P264CA0046.FRAP264.PROD.OUTLOOK.COM (2603:10a6:101:1::34) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b42c405e-6058-4ebf-6842-08d971214d69 X-MS-TrafficTypeDiagnostic: VI1PR04MB5470: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: H5tffAjQbLpV02jAOP50qHOcz4dp92GBmz8+6WBT0agGzkjyP8RzNn3o2qxZbsZZ8hSeYt/gZuUNL128utTmaczxJ5qWFaWGil6J4gkREMv4oXfdxm1DQ/9YopVQ1FKu9vaKWMTOv0E4YRZ1D0K+/EYo+2kscBitq8P6f5eOtpCZvjRdrSYwNgxg+L9OzEKUgC4Vu8theYoIgbFLjBM9mbUF34vG5pRtM974eisM+CapuX0nUwLRAVsXPxJndQPSImGKzbed+HtdEPV1IKH40oS/1EXtlajl6v4EVm2qbVyUhr157AKFUI7Izmf8mO5NNELf/04z2AXsBsgOPRqnH0CMqBKNNONlPIAG9FPBbOu2M+ZBuEsi5ec2CUItXhOqmfe2mwEylLkxvCmi4XzZ01Miw2fq0+NXEO6GUJw8LcqGLeFVV/uSmQk/dnGXK+JWe6sZcNjpqi8SKgSWyH395rmxn+2veUiepAGm4pt4C/O5cdcwdS0T7aJtcT3bE+qflZQOuqn3AJuOHyjV/sMqocMy//3MCP9hxbWWE26AH3x6N7c/Sf4XUIAtJxT2utyhwGooFH3g8EvDZeLP1iwHYcD3DH2GKkC32l6WHAFtwN4qteoLTWQvxBKeSDgQGBmrI5Fr/rUEyR/0D2rWyVjpXn6D7Hz65qCfL1l+G6r67gZLIQr8b59JSKxCaAeYgd8lE6EyPMpTaLykpgJNUdqhKdxb6jueQ4NzrV6cL+q/z9I= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(376002)(136003)(39860400002)(366004)(346002)(396003)(66476007)(66556008)(54906003)(478600001)(86362001)(186003)(7416002)(8936002)(956004)(36756003)(53546011)(31696002)(4326008)(2616005)(16576012)(8676002)(2906002)(316002)(66946007)(38100700002)(6916009)(31686004)(6486002)(83380400001)(26005)(5660300002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OFFKK1hlV2Nxc3lZMGFBM2lkZGhHa0xmcU9SZ2JLK0RBL0xURFVlYWFKYVFt?= =?utf-8?B?VlhURHA4Mk9pMTRkRUxMbzIrY3ZUVDZXcTZKL3BRaVo2b2x5dldjZEUwYUpw?= =?utf-8?B?ZTBlKzVVdndhNzcvVzNUZUtXa21YSnVneFNRZ2xRSXhDQkJvT2d3Q1dBdjU0?= =?utf-8?B?ZlgwOHJ1ZUYyR3ZhYVg1TnFtMXp6aW9uYm1RZUZSZHRYL2paLzFCdEtDQVBD?= =?utf-8?B?MXE0dkY5SnJUdG05dTExZEJ1RGk5ZGVrSkNYVC9jQTZnbGhpRXMyUDZBQm15?= =?utf-8?B?SkQvVkcvZWUzMmtQNU8wN2VUUUd3ZUw1NzB1NFFXQ0QxOVAvN2hDbHFvTXNX?= =?utf-8?B?YVhYeFdKMXFJd29uRFVuckl6RENrdHRXVzFxbWxiYTlzNksyYm5LVndRay9l?= =?utf-8?B?ZWVaa2pJYTBMU1BySkttYTJDS0Y3bTVKd2R4b3RaMHpCVDFVbTlOcU4yTXA0?= =?utf-8?B?NGRHcnpkTjNQR01RekMxMEh2M2N1Mitpa0RQMytvMU95M1FGcjVjWFBHWkJJ?= =?utf-8?B?RldWdG16UFc1K2Eza2JheENIOUVMUU5rTHNLTldjK1pET2hHREhCcHZxS3k0?= =?utf-8?B?Q2pWclZzcGtRSDgydFZ0amhMVWxvTU90d2V0TVlxSEptR1VQODNVQWpPenZX?= =?utf-8?B?WTFPRCtKQmgzYUZSR2k1Tzk2cnNUN2QxNmdlSjVOTEhFSHNNZWhoU0RlUzhx?= =?utf-8?B?SlhOVk9ocjlqeVNjK0JEd28rVUZrWmZudGszU0E0V0JVQnZoaEhEUGpzSjJG?= =?utf-8?B?LzBkSUlJdkdWc2dWL1lZbVBOSDllRi9nOHR1Ty9qSnJwcHZVak1aTXhQQkM1?= =?utf-8?B?Ym1mSmJXbmNXakxTRDBRQWM1SlpRUEREaGdMem5WWXBNTnZXdTFNbjdNY2l5?= =?utf-8?B?dmNxa1ZLZGx1RWFpTENubVJFNU5mdnVoSXIxcERTdWIxbjdQb2FTYm1HQTl3?= =?utf-8?B?NVBxaXFSZ00vMG9NbEIwL1Y4Y1VJVVhOaVAxOXh6ZFc4T2k4czdnYnEwUGhI?= =?utf-8?B?bklVcGxWa2w3TThwUTZZaE1EeStWLzVZYkliRjArQWVuWlNjSlAxcGFQMnZk?= =?utf-8?B?dGlHc2UrSVB6akd6ZThmOU1LRUpqUEZJelVjcWM2eUVDakNqREc5aTQ5VC9K?= =?utf-8?B?cXZpMWRNWWN4RUoxNXlqVTIyZnFFaFZOWWVQOHBzY04xT2hXblNNZ05QdE9k?= =?utf-8?B?SVdtd291NnNrYmN4MlptK3JVaDdncXhLemppK2c3YjBTemZBaFg2RkZKQlVC?= =?utf-8?B?czB1T3ZVMFRMVkkvbzlKdnUzR1d2T3BOQnpvMmM4TWRCNFd1dVk0TE1HMTFL?= =?utf-8?B?UWtmd3o2VVRIYjBhMDZla2daR2lnWWpKZ1hjdmhtMFN2Z0liaXBQTlhROStJ?= =?utf-8?B?Y1diY1lWMzBIa3k0SVVWZmRKckk2QXAwNTMzdTU3d0hHUHR4S0NyanpQY29D?= =?utf-8?B?NE16WlRFN2I1b281Ty9YS3pkOEdhT3k5VHkzMGZsWlJLRHpyNjVGcWNVMHM4?= =?utf-8?B?NTkyTHBvTWJ1bmpGcFlTQ2F4dExWM1hPeGdkVFFYTTF3V29aQmx3WHFCVnFl?= =?utf-8?B?eGo5MGVkRk92UWlTa0xWZ3VpdlZNVHlxQWpEaW1aUng1d1l6cVRtUFBKeURV?= =?utf-8?B?ODNmNHNSalhyVUl1bVpOQThiWGdFK2l3T3UyeHF0VUp3U3hzcXF5TElmL3kz?= =?utf-8?B?d3p1SnkyMTh3R2xLTTlqeTRnRjljbk4ra213d2thUGZDdi9RaGEwbnl1T0k5?= =?utf-8?Q?Fptj31m2heZSr06CwIGEEUemStvSo8KZth/aBkf?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: b42c405e-6058-4ebf-6842-08d971214d69 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2021 10:30:09.7937 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: YUfEkUo9myD/ZgFwmDA5yc4uNyaYRrGdU14+FmpWeub1gCbRqRFjj4S0/YyTXbINqQoxuwY+UHKpm1km6DP0wg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5470 On 06.09.2021 12:06, Anthony PERARD wrote: > On Thu, Sep 02, 2021 at 12:08:58PM +0200, Jan Beulich wrote: >> On 24.08.2021 12:49, Anthony PERARD wrote: >>> Signed-off-by: Anthony PERARD >> >> Reviewed-by: Jan Beulich >> albeit with a remark: >> >>> --- a/xen/Rules.mk >>> +++ b/xen/Rules.mk >>> @@ -133,6 +133,9 @@ endif >>> # Always build obj-bin files as binary even if they come from C source. >>> $(obj-bin-y): XEN_CFLAGS := $(filter-out -flto,$(XEN_CFLAGS)) >>> >>> +# To be use with $(a_flags) or $(c_flags) to produce CPP flags >>> +cpp_flags = $(filter-out -Wa$(comma)% -flto,$(1)) >> >> Afaics this has nothing to do with Linux'es cpp_flags, so what we do here >> is entirely up to us. If this is strictly intended to be used the another >> macro, wouldn't it make sense to have >> >> cpp_flags = $(filter-out -Wa$(comma)% -flto,$($(1))) >> >> here and then e.g. ... >> >>> @@ -222,13 +225,13 @@ $(filter %.init.o,$(obj-y) $(obj-bin-y) $(extra-y)): %.init.o: %.o FORCE >>> $(call if_changed,obj_init_o) >>> >>> quiet_cmd_cpp_i_c = CPP $@ >>> -cmd_cpp_i_c = $(CPP) $(filter-out -Wa$(comma)%,$(c_flags)) -MQ $@ -o $@ $< >>> +cmd_cpp_i_c = $(CPP) $(call cpp_flags,$(c_flags)) -MQ $@ -o $@ $< >> >> ... the slightly simpler / easier to read >> >> cmd_cpp_i_c = $(CPP) $(call cpp_flags,c_flags) -MQ $@ -o $@ $< >> >> here? > > I don't think this is better or simpler. "cpp_flags" don't need to know > the name of the variable to be useful. I think it is better to know that > "cpp_flags" act on the value of the variable rather than the variable > itself, when reading "$(call cpp_flags, $(a_flags))". Well, yes. This way one could also pass more than just the expansion of either of these two variables. The thing that made me think of the alternative is the comment: Would you mind if I inserted "e.g." in there, to make clear this isn't limited to these two variables? Jan From xen-devel-bounces@lists.xenproject.org Mon Sep 06 10:38:31 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Sep 2021 10:38:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.179609.325960 (Exim 4.92) (envelope-from ) id 1mNC1C-0003CF-Qq; Mon, 06 Sep 2021 10:38:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 179609.325960; Mon, 06 Sep 2021 10:38:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNC1C-0003C8-NJ; Mon, 06 Sep 2021 10:38:26 +0000 Received: by outflank-mailman (input) for mailman id 179609; Mon, 06 Sep 2021 10:38:25 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNC1B-0003C2-BE for xen-devel@lists.xenproject.org; Mon, 06 Sep 2021 10:38:25 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNC18-0001ey-1b; Mon, 06 Sep 2021 10:38:22 +0000 Received: from 54-240-197-236.amazon.com ([54.240.197.236] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1mNC17-0005RK-R2; Mon, 06 Sep 2021 10:38:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=vRQKbF9dIKn56RN0QBCOcsQEJRISlyCnZKN8myk/D8Q=; b=A2FI9XHsrW4R+hJqG8RLklILc4 +jqR2/HiZZsgEJ7qd5LKq/H+b5zoIkxsdrW9rXAOOMu58TJQ1tAHkJDJR0bJ0EfuvYDMHjL4BxyPI 9g9i6+gMZ+giS19dbtYl/ImncQ9QvLwgUTqQCj/DG6fhI7UDrW2u+i03QWw05rwhcwkY=; Subject: Re: [PATCH 11/11] xen/arm: Process pending vPCI map/unmap operations To: Oleksandr Andrushchenko , Oleksandr Andrushchenko , "xen-devel@lists.xenproject.org" Cc: "sstabellini@kernel.org" , Oleksandr Tyshchenko , Volodymyr Babchuk , Artem Mygaiev , "roger.pau@citrix.com" , Bertrand Marquis , Rahul Singh References: <20210903083347.131786-1-andr2000@gmail.com> <20210903083347.131786-12-andr2000@gmail.com> <7da7f759-eab0-5e97-e8e4-980db5db1e79@xen.org> <71e0a54f-da69-5712-f826-9c38eecfa244@epam.com> From: Julien Grall Message-ID: <9482457a-fae2-eb8e-79dc-b5d7bcf2fa0a@xen.org> Date: Mon, 6 Sep 2021 11:38:19 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <71e0a54f-da69-5712-f826-9c38eecfa244@epam.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Hi Oleksandr, On 06/09/2021 11:06, Oleksandr Andrushchenko wrote: > On 06.09.21 12:53, Julien Grall wrote: >>>>>> However, looking at the rest of the code, we already have a check for vpci in the common IOREQ code. >>>>> >>>>> Which may not be enabled as it depends on CONFIG_IOREQ_SERVER. >>>> >>>> Right. My point is when CONFIG_IOREQ_SERVER is set then you would end up to call twice vpci_process_pending(). This will have an impact how on long your vCPU is going to running because you are doubling the work. >>> >>> So, you suggest that we have in the common IOREQ code something call like >>> >>> arch_vpci_process_pending? In case of x86 it will have the code currently found in the >>> >>> common IOREQ sources and for Arm it will be nop? >> >> No I am suggesting to move the call of the IOREQ code to hvm_do_resume() (on x86) and check_for_vcpu_work() (on Arm). > > Ok, I can move vPCI code to hvm_do_resume, but vPCI is only used for x86 PVH Dom0. AFAIK, Roger is planning to use it for x86 PVH guest. > > Do you still think hvm_do_resume is the right place? I think so. AFAICT, on x86, the only caller of vcpu_ioreq_handle_completion() is hvm_do_resume(). So it makes sense to push one layer up. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Sep 06 10:43:14 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Sep 2021 10:43:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.179615.325970 (Exim 4.92) (envelope-from ) id 1mNC5p-0004ls-Ce; Mon, 06 Sep 2021 10:43:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 179615.325970; Mon, 06 Sep 2021 10:43:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNC5p-0004ll-9k; Mon, 06 Sep 2021 10:43:13 +0000 Received: by outflank-mailman (input) for mailman id 179615; Mon, 06 Sep 2021 10:43:12 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNC5o-0004lf-KT for xen-devel@lists.xenproject.org; Mon, 06 Sep 2021 10:43:12 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNC5m-0001kT-Vu; Mon, 06 Sep 2021 10:43:10 +0000 Received: from 54-240-197-236.amazon.com ([54.240.197.236] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1mNC5m-0005x2-PP; Mon, 06 Sep 2021 10:43:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=ZCb0AKomNjh90Gk0tOHoLBirjLw+JK+7N6jSubaVZtI=; b=GTbTw7PclL7DoJ7msE18HSBIsh jZ4zTIk4BIazeIcE7Y+/WF8agIZibSSD0qhSLNtiQX3qAoQQzGagnIU7Ovk6ZPz5oFx5+r28taVjS fw3+rOD1Uzv3tihlqagvfii8YiXvRUVqfVdoEWQSNvavp9zD5Ti0lA2ZzQYTmCp+IGyM=; Subject: Re: [PATCH v3 1/4] public: Add page related definitions for accessing guests memory To: Jan Beulich , Costin Lupu Cc: Stefano Stabellini , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Ian Jackson , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , xen-devel@lists.xenproject.org References: <22031be8466bb18d1dd891481ccc67d8c2b2dd55.1629737453.git.costin.lupu@cs.pub.ro> From: Julien Grall Message-ID: <9a5e836c-32ae-50e2-1091-086a40beb4b2@xen.org> Date: Mon, 6 Sep 2021 11:43:08 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Hi, On 24/08/2021 07:11, Jan Beulich wrote: > On 23.08.2021 19:02, Costin Lupu wrote: >> These changes introduce the page related definitions needed for mapping and >> accessing guests memory. These values are intended to be used by any toolstack >> component that needs to map guests memory. Until now, the values were defined >> by the xenctrl.h header, therefore whenever a component had to use them it also >> had to add a dependency for the xenctrl library. >> >> This patch also introduces xen_mk_long() macrodefinition for defining long >> constants both for C and assembler code. >> >> Signed-off-by: Costin Lupu > > x86 part: > Acked-by: Jan Beulich > > This extends to the common parts only if the Arm side gets an ack, For Arm: Acked-by: Julien Grall Cheers, > since - as said before - there you're treating use of one unstable > interface (libxc) for another (the ABI) in supposedly stable > libraries, or - if the ABI is to be stable despite being exposed > to the tool stack only - you make it impossible to make the page > size variable down the road. > > Just yesterday we've been (internally) talking about the similar > "maximum vCPU-s" aspect: This shouldn't be taken directly from the > ABI by tool stacks, as imo we ought to allow the upper bounds to > be configurable in the hypervisor (with the present limits merely > becoming limits of what can be configured). This would similarly > require a library function (or two, as HVM and PV limits are > likely different). I wonder whether we shouldn't have a stable > library providing functions to retrieve such limits. Initially the > library would return constants, short of the hypervisor providing > the needed data. > > Jan > -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Sep 06 10:56:32 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Sep 2021 10:56:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.179621.325981 (Exim 4.92) (envelope-from ) id 1mNCIQ-0006Qo-I9; Mon, 06 Sep 2021 10:56:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 179621.325981; Mon, 06 Sep 2021 10:56:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNCIQ-0006Qh-FH; Mon, 06 Sep 2021 10:56:14 +0000 Received: by outflank-mailman (input) for mailman id 179621; Mon, 06 Sep 2021 10:56:13 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNCIP-0006Qb-0b for xen-devel@lists.xenproject.org; Mon, 06 Sep 2021 10:56:13 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNCIN-0001yO-A9; Mon, 06 Sep 2021 10:56:11 +0000 Received: from 54-240-197-236.amazon.com ([54.240.197.236] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1mNCIN-0007KY-1T; Mon, 06 Sep 2021 10:56:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=TbH4O9e020jx0sGPeovPiNA2vcT/yAA6hKIcUQf61zI=; b=t0Fgi76jJkub4DJtwu6u80uIh1 7hbZBfxlc2aDiJ4AuTPrIn+C13Z6tKE2rpTRgun5p7tznUMcaTLWhb2oS+WGKk/1oozXUbfJ0Dlrd wuSVjBtGShHkZCRABV+DKWqCt96HCNge6qGhMdFwdvAv8tF6edwJcdnPbjE3nCRKTsoI=; Subject: Re: [PATCH] gnttab: adjust unmap checking of dev_bus_addr To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Ian Jackson , Stefano Stabellini , Wei Liu References: <1d2d28ac-bcf2-2a96-a6dd-8282fc59a16c@suse.com> From: Julien Grall Message-ID: <79c21c7b-c833-acfb-644a-907707a9fe1d@xen.org> Date: Mon, 6 Sep 2021 11:56:08 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <1d2d28ac-bcf2-2a96-a6dd-8282fc59a16c@suse.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Hi Jan, On 30/08/2021 15:26, Jan Beulich wrote: > There's no point checking ->dev_bus_addr when GNTMAP_device_map isn't > set (and hence the field isn't going to be consumed). And if there is a > mismatch, use the so far unused GNTST_bad_dev_addr error indicator - if > not here, where else would this (so far unused) value be used? > > Signed-off-by: Jan Beulich Acked-by: Julien Grall > > --- a/xen/common/grant_table.c > +++ b/xen/common/grant_table.c > @@ -1450,9 +1450,9 @@ unmap_common( > > op->mfn = act->mfn; > > - if ( op->dev_bus_addr && > + if ( op->dev_bus_addr && (flags & GNTMAP_device_map) && > unlikely(op->dev_bus_addr != mfn_to_maddr(act->mfn)) ) > - PIN_FAIL(act_release_out, GNTST_general_error, > + PIN_FAIL(act_release_out, GNTST_bad_dev_addr, > "Bus address doesn't match gntref (%"PRIx64" != %"PRIpaddr")\n", > op->dev_bus_addr, mfn_to_maddr(act->mfn)); > > Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Sep 06 11:01:07 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Sep 2021 11:01:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.179627.325993 (Exim 4.92) (envelope-from ) id 1mNCN8-00082G-4O; Mon, 06 Sep 2021 11:01:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 179627.325993; Mon, 06 Sep 2021 11:01:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNCN8-000829-1F; Mon, 06 Sep 2021 11:01:06 +0000 Received: by outflank-mailman (input) for mailman id 179627; Mon, 06 Sep 2021 11:01:05 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNCN7-000823-0l for xen-devel@lists.xenproject.org; Mon, 06 Sep 2021 11:01:05 +0000 Received: from smtp-out1.suse.de (unknown [195.135.220.28]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id b655369a-290f-481c-ae76-3e0f87498c2b; Mon, 06 Sep 2021 11:01:04 +0000 (UTC) Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 6D415220EA; Mon, 6 Sep 2021 11:01:03 +0000 (UTC) Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap1.suse-dmz.suse.de (Postfix) with ESMTPS id 3298213942; Mon, 6 Sep 2021 11:01:03 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap1.suse-dmz.suse.de with ESMTPSA id gFtICu/0NWFbGQAAGKfGzw (envelope-from ); Mon, 06 Sep 2021 11:01:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b655369a-290f-481c-ae76-3e0f87498c2b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1630926063; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=BrS40Tf/KPD9CQCWVNVJ4t3+lx1YVOcmmtx8WpJDnlY=; b=bejh5fc5k+w1U6ChtsJEM6gYGML9shAdNIMcvQWDi+PEXtdSQJBOTjexaAnNTUqHjpiSNi VTRoOLFZWRlX8K7yRTmMpcpyPzKYfkpiFOQt4dNDzOGWujkiLaoTiIs//4sRYDI9LHd45i gzOgfWigAns23QVOD9Zgar5PfP5VXfk= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , George Dunlap , Dario Faggioli , Bertrand Marquis Subject: [PATCH] xen/sched: fix sched_move_domain() for domain without vcpus Date: Mon, 6 Sep 2021 13:00:57 +0200 Message-Id: <20210906110057.15384-1-jgross@suse.com> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In case a domain is created with a cpupool other than Pool-0 specified it will be moved to that cpupool before any vcpus are allocated. This will lead to a NULL pointer dereference in sched_move_domain(). Fix that by tolerating vcpus not being allocated yet. Fixes: 70fadc41635b9b6 ("xen/cpupool: support moving domain between cpupools with different granularity") Reported-by: Bertrand Marquis Reviewed-by: Bertrand Marquis Signed-off-by: Juergen Gross --- xen/common/sched/core.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/xen/common/sched/core.c b/xen/common/sched/core.c index 8d178baf3d..79c9100680 100644 --- a/xen/common/sched/core.c +++ b/xen/common/sched/core.c @@ -671,6 +671,10 @@ int sched_move_domain(struct domain *d, struct cpupool *c) for ( unit_idx = 0; unit_idx < n_units; unit_idx++ ) { + /* Special case for move at domain creation time. */ + if ( !d->vcpu[unit_idx * gran] ) + break; + unit = sched_alloc_unit_mem(); if ( unit ) { -- 2.26.2 From xen-devel-bounces@lists.xenproject.org Mon Sep 06 11:05:02 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Sep 2021 11:05:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.179633.326003 (Exim 4.92) (envelope-from ) id 1mNCQs-0000Gu-LR; Mon, 06 Sep 2021 11:04:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 179633.326003; Mon, 06 Sep 2021 11:04:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNCQs-0000Gn-Ic; Mon, 06 Sep 2021 11:04:58 +0000 Received: by outflank-mailman (input) for mailman id 179633; Mon, 06 Sep 2021 11:04:57 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNCQr-0000Gh-2n for xen-devel@lists.xenproject.org; Mon, 06 Sep 2021 11:04:57 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNCQp-00028G-An; Mon, 06 Sep 2021 11:04:55 +0000 Received: from 54-240-197-236.amazon.com ([54.240.197.236] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1mNCQp-0008Lo-46; Mon, 06 Sep 2021 11:04:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=cUUe6zzqW0wvOLi12xZic2f3L00lviKdlvhQ+zAy3fs=; b=0G+ZCTjQWV78luFw20ktNazUe7 pXeAXYqqVsiVHa4xMP7cltFmcw3uKqLxi+Ndlen7GxAH/sznP1zOnzCptX1/bjm/ahZtLZLvgGT+m 6a8k+vHCcYOIbeX2LJikd3ce45UYi2DCnT4gwD5L2HvJ3OecNw/P9bKf//9RV8N8/boM=; Subject: Re: [PATCH] gnttab: maptrack handle shortage is not IOMMU related To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Ian Jackson , Stefano Stabellini , Wei Liu References: From: Julien Grall Message-ID: <29fd1d29-1077-4513-a8b6-5d220b06f4d3@xen.org> Date: Mon, 6 Sep 2021 12:04:53 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Hi Jan, On 30/08/2021 15:27, Jan Beulich wrote: > Both comment and message string associated with GNTST_no_device_space > suggest a connection to the IOMMU. A lack of maptrack handles has > nothing to do with that; it's unclear to me why commit 6213b696ba65 > ("Grant-table interface redone") introduced it this way. Introduce a > new error indicator. > > Signed-off-by: Jan Beulich > --- > Or should this be a more specific one, e.g. GNTST_no_mt_handle? If not, > I would intend to also use GNTST_no_space for -ENOMEM like situations. I guess the guest could use GNTSTS_no_mt_handle to reduce the number of persistent mappings (if there are any). Although, I am not sure how involved it would be in OS like Linux. Anyway, the new error status is better than the previous one. So I am happy with either solutions: Acked-by: Julien Grall Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Sep 06 11:15:06 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Sep 2021 11:15:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.179639.326014 (Exim 4.92) (envelope-from ) id 1mNCaZ-0001vL-KN; Mon, 06 Sep 2021 11:14:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 179639.326014; Mon, 06 Sep 2021 11:14:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNCaZ-0001vE-HR; Mon, 06 Sep 2021 11:14:59 +0000 Received: by outflank-mailman (input) for mailman id 179639; Mon, 06 Sep 2021 11:14:57 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNCaX-0001v8-AA for xen-devel@lists.xenproject.org; Mon, 06 Sep 2021 11:14:57 +0000 Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id aa40d6e8-0f03-11ec-b09e-12813bfff9fa; Mon, 06 Sep 2021 11:14:56 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: aa40d6e8-0f03-11ec-b09e-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1630926896; h=to:cc:references:from:subject:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=oQV7QHWU6OhwydPZsJEIiXObTnGSTwrrzOwsyzrQ4C8=; b=CGCwooLj5I3XYEHoqM8dDeJ4sCXe9n+ZgyAgYC6gyk89HPdbeqa5jkJ5 66ie8t0BcDYJNX0QjB4UpUVwo7ewMD4n7Cv3Q0mDOVTCKssMxTdwzitw2 92sW+ShPcl2Setz3TsC1wJzPidfss4MlFmC2ktb46Xr+N+51j3vSXd491 A=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: yyVzsrerJc31Vq4XhX3BSvdEhgA5sZEjHA742tSj20s9+xubdWoiSaMDCSH6hmbZI400VsWs1B u//yIyX9p9pGYrSjQ5UnJ3vAqAwN7oaS0f1xvAoW2gCzEQunYN0bvunW+9FfV+7Koi27tqAoMJ B4zp6BWdsj/RB8RctWGYdp44K/JkHHmFHrBD1wCv2G+DAzgskNQPbQRfKE1Oat1oc3BPyZXY3J tebEh9AXWiSgOWDriF/pvDEIqCiYXLBk5WB9uptuowsUGq8bKLkvfH8HjRbPDSBeZ7CPoFKF0J Vfy5+SESMhoBns0iUUAMAzNa X-SBRS: 5.1 X-MesageID: 53838646 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:aLpIX60KMs9qunmdlIZzSgqjBSVyeYIsimQD101hICG9Lfb2qy n+ppgmPEHP5Qr5OEtApTiBUJPwJE80hqQFnrX5Wo3SIDUO2VHYUb2KiLGN/9SOIVyHygcw79 YGT0E6MqyLMbEYt7eL3ODbKadY/DDvysnB7o2/vhQdPj2CKZsQizuRYjzrY3GeLzM2Y6bReq DshPav6wDQAkj+Oa+Adwc4tqX41pH2vaOjRSRDKw8s6QGIgz/twLnmEyKA1hNbdz9U278t/U XMjgS8v8yYwr+G4y6Z81WWw4VdmdPnxNcGLMuQivINIjGprgqzfoxuV5CLoThwiuCy71QBls XKvn4bTotOwkKUWlvwjQrm2gHm3jprw3j+yWWAiX+mmsD9TCJSMbsLuatpNj/ir2YwttB116 xGm0iDsYBMMB/GlCPho/DVShBDjCOP0DkfuN9Wq0YafZoVabdXo4Ba1lhSCo08ECXz751iOP VyDfvb+O1dfTqhHjDkV1FUsZmRt0kIb1O7qhBogL3T79EWpgE586Ig/r1cop9an6hNDaWt5I z/Q+xVff91P5YrhQ8UPpZ3fSKNMB25ffv7ChPaHb3WLtB0B5vzke+C3FwU3pDhRHVa9up+pH z+OGkow1LaPXieUfGz4A== X-IronPort-AV: E=Sophos;i="5.85,272,1624334400"; d="scan'208";a="53838646" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jTFVkScVpNPVsclnXnFuj4JvvGK/1s0ApPARsh0d/iWpD8pSSiLkAwf6VIXPHOu3j2aWD0dE4F0hDKP/eRn9xZpaEvT5NUOwsMCMWqVg5CpGAxSbR2fwSTySX16N+KVikuxLzcFEr/u45282oV90Zyyw7Rz2F9O+2qKvB+luH0GeZDtnoeHxQhLRb0Go24e3/2/eQAAaxARPOuWb8hhNGBeL5ehxG76o2n3HibThUIkdMoofuP+kMqr+mFb+kPfvycL0nLECrpLxIRWA0hJgQSZah/EHyMq4ql99iqaxoeApHYSt8hdNKqQdBA1dMBer5ubGvFMHnP1emKCQNVo7TA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=8DIosnqOWGFq84M1MwFZbsweglLBrZR4689wCKGnoEo=; b=WTHfwF0DMLPA753PCnSHlnYAIx01fG8ynSdC2nMEC2hgmfYwhF1IdpJoyHR7sjX6BuoWpDpZyA6EIwwegF/U8dM1Nzg2wYgVoAUtK0vp2s9zMH5FqPIRWFZ/K9LAXUsuuht/bqiqGAsgVBl+ny1q16n6MYKewc3ZFNbrlgO5yD1Q4mycL3s3ex41h+8rH34E+Bvidopp7Fx7tup/P4dXkOZK19E6w3Kfs1mEbcy6Tsw7jdBtvh2O4tCHN5H17kTDxLAYfkbovMRbCNKfZEGj8yPNZMywwDM6lTOiVlL7sqJs5P8xl3d2f87dZdP/yZe3mhXpY77EggI85YcyWasPAw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8DIosnqOWGFq84M1MwFZbsweglLBrZR4689wCKGnoEo=; b=tKS3XzxezhVNWqq8dERxaqZinaSdwFM6ZV9z3GkNvtjlaOiCSyD/nGXf4uvdasoaaHqg7GIAuH/36H6x9n2xEO/ANsZ9g7NtDFVWJ0MeR1u18+WUu0tBGohqwUimPVDJNCEGnadaKWQNxHEYikEVVldlZ12NEXc4eDgtB/XdXBM= To: Juergen Gross , CC: George Dunlap , Dario Faggioli , Bertrand Marquis References: <20210906110057.15384-1-jgross@suse.com> From: Andrew Cooper Subject: Re: [PATCH] xen/sched: fix sched_move_domain() for domain without vcpus Message-ID: <0006eb7d-a9d5-16a3-1418-a1d28c4c9a92@citrix.com> Date: Mon, 6 Sep 2021 12:14:48 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 In-Reply-To: <20210906110057.15384-1-jgross@suse.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: en-GB X-ClientProxiedBy: LO4P123CA0479.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a8::16) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: bf2db25f-b70b-40e5-c3cf-08d971278cc8 X-MS-TrafficTypeDiagnostic: BYAPR03MB3991: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dRMdJT59jD9HEbsbKrDV21D/67nPcMkBsI+56z0WjGfIDNFw7MgVMvf7twq7lmI9hkAPslZnIDy79AhiFxSkeerzWahE7stTGUmaV96GGlqkZgYy4PIXfK8gUUPFQ0Ae9l7Ofm2bH2cBPao3OpcjhjG05eaJZ6dPSTBkKuYpE1VldiqXmv0z52gMeFTObWz5HIfluoViFbBjK3iq/wsCh7jlyisjQaTNcUmpuLTW04j0n6XBJqwPXf4+zQ6F7DtqQS0WQM1HAwbaeQLEZ+6HO75zdyrXFZyT3+1/UgWcvmr+grhCkU5yPht/fWWemGqaXtuA30jIf0SFT2FWYS1PjibV7jYXQ3nsHBND8d1cLTaU2Spvm/AlKaUo45wmN2ECkbWnzmROfAcmkQAd7Hf6wxH2zsMyf6Ik3+an2moUmzfujCj6LYMEu3GMfgxhcor8FvRC1HQ4k9AvEVuEWhaePJpM1NFDK7iLtNlyFJnscuApeJsB9S5/1XEe7HLdaxm0JOvbXQ5FoNL/YWxnpthbfuvU13VNKzIqri8p6wG8EA7/PGVGecz7NyAQanpirPaqG2defy6Gy45v+v8sLVJhHyBII+A3lf3JF9bagp+o0LXF0/iz8gcwEZlUuYSDfcims3kXNIif3DiIQ+PUflmBju2AZX9v+xaDnDYRBlYAiFTHh8qER/4M3/bIRjzk/OWIkOXkwbpKZbJniGhdHWJGBexqjk5tvwR9Pujsdn9UYR4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(136003)(346002)(39860400002)(366004)(396003)(4326008)(86362001)(66476007)(66556008)(66946007)(31686004)(38100700002)(31696002)(16576012)(316002)(2616005)(54906003)(2906002)(956004)(36756003)(5660300002)(478600001)(6486002)(6666004)(26005)(8936002)(8676002)(186003)(55236004)(53546011)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Tlg3T2hYTU5oZGR1Z0dub1UySWZDeXNpSndIRGk3VmVMTndDUDBnQ0l3SmVF?= =?utf-8?B?bmZxVS9JVUFDSzR2MDNoUkt5TnlyQStRbkx4VVV5Mlh6NlYyMUxrUHlZclov?= =?utf-8?B?U29WQWJ2WjlOaDA5WkU1bVJ0c2N3K3lKdGxlNEhKZlZOd0FNWEJNdzlHeUx1?= =?utf-8?B?cjZldy82OVNZNnpvVXlBWS9DQ1VyTFdiWHVTckhrZmthRXBkQm90NVhzZEpm?= =?utf-8?B?RFh5WEo3NVZwQ3d5MnBkVWNWTVA4a1N1OERBVkpxeWpJZ0VvNlRwRWpxem9G?= =?utf-8?B?VjZpb0xEUUhwSGdZVGNmVHRJWkFFM01pOXhETDY3U0F4Sm10YVlXa25jNmR2?= =?utf-8?B?UjQzT0hEQVN1MjY3MGU4a2hFR0RLUk5tV01aZTZVbzQvTE4wQkNYbWMwNXBx?= =?utf-8?B?ZUsvaitHbEFmZzhEdXZ4ZWVBdHowMnVrY1pZdVFxdGp2MzBmT09Nb1RNQmMx?= =?utf-8?B?SGo0TVROckZkS3NRRWxrNjArbEVuQ0NPSUREZFY3L2dBaGxpVmNINUVSWWFW?= =?utf-8?B?bG0yQW5VM1BKU2lCQUZoT09ZQ3JCQXRlREdtV0Y2L0pON0t0eEZmQTZhWUlS?= =?utf-8?B?Tm5qMkJXRTNrUlpzL0pOOFBIaFI5anp0dzFPY3RGZ2g3Ymx4K3R6M0tBMS95?= =?utf-8?B?VkhOeWhKSndITFIxQXlhWkduVnJ5VklyRmNKWmtlamZPMDZHM3lLMzBOVnp4?= =?utf-8?B?RFp1SVJtb1J0NkpKcnpiWDRTNFEwbU5sZHE4SVlDN3FYd010d1duS1hVaGx3?= =?utf-8?B?b1Z3amFJam5LS1YyYUVYWEFXbngvWi91WHhNWURHVis5TEYyeGh1WER1cy8z?= =?utf-8?B?VmFTUUlBQ0dLait6V2g0MEFYQXBMTTM5YjdlYm9qeGJqTlJjN3Irc1VRZDhW?= =?utf-8?B?Uk5GU1RycGN6WlREQ0R3UFJ4NGhrL0dPem9WeWlqK0JZYWo3NUlsYWJoZnYw?= =?utf-8?B?NS9qRGtyWlp3Y1RyYXo5ZUpTMWEvZkNqdTN5UjlQbENPNXJ6WHh0eXB5QzJG?= =?utf-8?B?bkg5ZFJadWh0WWxUN0dLbEhVaHF2U3YxRFBEdnRvcUM0dUV4VFRMOHZ2ZWVu?= =?utf-8?B?c1d3Ulp4Mmh0TW1lTzVIeVI0RGg4RVg5WWVHMzFzWTdoR3YyeFdBcTloN2k3?= =?utf-8?B?VDNvR3ZITy9UYXBJbVRpV25CRHluUjFiWWRiTHZrMi9yOHNReEMxRzIwaytv?= =?utf-8?B?M3orSm9TTUlKaXBzTFJqaUtoVGxHTkdEcE9oWE8ybDRvM2FUNXhsc1hYNmph?= =?utf-8?B?TGp2OG1CSXhKam1PYTNxQVdub0VzMmVCS2d4RC8zQkFnckF0TnFLZkdUcyts?= =?utf-8?B?bjNJNHREd0JiWUUvY2J5SUhLSkVhYU5IUGI3cEJlcWhNR3hqZTJEbXpDNCtT?= =?utf-8?B?YXJHQUhDbWsveHBJM2l5LzZldVgvRy9abG5KR01NVHgrOVhhRTVWMmhENExw?= =?utf-8?B?RElra3Y2cktLTEtwaCsrVmVYWHpmQVgvQlRKdUJaZ2R4Qlg3TTdNMWdvTHNH?= =?utf-8?B?MFBKbDF2clN2TCthKzZIYkFQWmZaOVArVk9wRVNaT3U1N3VDM25oZ1pKMFc1?= =?utf-8?B?U2lUMjBkL2d3VFU0MXpQOFRFN3JHd3hOTkdXZVBoblFjQklKeFMrUyt2Vmta?= =?utf-8?B?V2hVTkNqTlNNMWppbjNLcjI4N3NKOTRrSklKd3NhUE9RenRZRzVHSXVjZG1R?= =?utf-8?B?bC9sTEljbUl0K0QvbkYybDRqcDNMNjhZd2VSQWkybkxwMjBCZFdXcVBVVDMv?= =?utf-8?Q?zBUUJvdpOL/EisBr6qEN0nrQZf2z3ORwgIjAZVd?= X-MS-Exchange-CrossTenant-Network-Message-Id: bf2db25f-b70b-40e5-c3cf-08d971278cc8 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2021 11:14:53.1255 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: fMhuUD/SMf1NFDcp42cw3DqgZen+tXZIJFW8udj0JUiN5rya9nJktGpoElUOeBqcwxmUSY+AaLqChpX6+6wBUG1ZGyE+nSWZgtiPx2+Ln6Q= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB3991 X-OriginatorOrg: citrix.com On 06/09/2021 12:00, Juergen Gross wrote: > In case a domain is created with a cpupool other than Pool-0 specified > it will be moved to that cpupool before any vcpus are allocated. > > This will lead to a NULL pointer dereference in sched_move_domain(). > > Fix that by tolerating vcpus not being allocated yet. > > Fixes: 70fadc41635b9b6 ("xen/cpupool: support moving domain between cpupo= ols with different granularity") > Reported-by: Bertrand Marquis > Reviewed-by: Bertrand Marquis > Signed-off-by: Juergen Gross > --- > xen/common/sched/core.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/xen/common/sched/core.c b/xen/common/sched/core.c > index 8d178baf3d..79c9100680 100644 > --- a/xen/common/sched/core.c > +++ b/xen/common/sched/core.c > @@ -671,6 +671,10 @@ int sched_move_domain(struct domain *d, struct cpupo= ol *c) > =20 > for ( unit_idx =3D 0; unit_idx < n_units; unit_idx++ ) > { > + /* Special case for move at domain creation time. */ > + if ( !d->vcpu[unit_idx * gran] ) > + break; > + > unit =3D sched_alloc_unit_mem(); > if ( unit ) > { I think the logic would be clearer if you wrap the entire for loop in if ( d->max_vcpus ).=C2=A0 This loop is only allocating units in the new scheduler for existing vcpus, so there's no point entering the loop at all during domain creation. Also, this removes a non-speculatively-guarded d->vcpu[] deference. ~Andrew From xen-devel-bounces@lists.xenproject.org Mon Sep 06 11:18:53 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Sep 2021 11:18:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.179646.326026 (Exim 4.92) (envelope-from ) id 1mNCeK-0002eE-9n; Mon, 06 Sep 2021 11:18:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 179646.326026; Mon, 06 Sep 2021 11:18:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNCeK-0002e7-5e; Mon, 06 Sep 2021 11:18:52 +0000 Received: by outflank-mailman (input) for mailman id 179646; Mon, 06 Sep 2021 11:18:50 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNCeI-0002e1-NK for xen-devel@lists.xenproject.org; Mon, 06 Sep 2021 11:18:50 +0000 Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 35136e66-0f04-11ec-b09e-12813bfff9fa; Mon, 06 Sep 2021 11:18:49 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 35136e66-0f04-11ec-b09e-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1630927128; h=subject:from:to:cc:references:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=UGxqvqQGjENugmIZlJdv6hd3iip9nYlhxFfwYqsejpA=; b=O1pZjZRvTM276/T8roanNsFyDFoG4+krJRgHIG+XSDegMVOmoCGKLjMe uVyP7QsojVGfb9KYF8Jkw4V87w1OYl2/Q182Mdh5cuNk+vUPBrr/VJYYM QtehVa9S0QqxVhdk/6qtpYRZmLPpwnXeCFiRF7CUKe2VwE01ibIglJUeU E=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: 9UqJlYe1eqL2Dv9Z2t16LuKYX0yFqSP+7scu9rBlrvCeY3EYfNfMIda9FVfG+YfjFUVBp8VDMt vRRFR3Ealss/X9PCPiDpJs5iKxkEH0ezMAuCDw+Pd5URBhkeYSUpYHKUGS9qiwYYeCWn1JfU06 Pqkfh+6wHTzL5tEOgjBpraWtQxEhPpRJjfaRzz2fdHigUEdyJIJxkLlvVX20ptI9Eqn3XHv70S kw98ZgxjuxdL4RSVnysg/0MZ1TyKl7zOnJ26kJo548hV9m2rbM0fuM8dL9ko3P/CEu8IqOAGxx iZ3K+XuMJbIKlZrgJOI2cLn3 X-SBRS: 5.1 X-MesageID: 52082718 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:1Ym+2KACDVsh0T/lHeglsceALOsnbusQ8zAXPh9KJyC9I/b2qy nxppgmPH/P6Ar4WBkb6La90dq7MA3hHPlOkPYs1NaZLXXbUQ6TTb2KgrGSuAEIdxeOktK1kJ 0QDpSWa+eAfmSS7/yKmDVQeuxIqLLsndHK9IWuvUuFDzsaEp2Ihz0JejpzeXcGITWua6BJc6 Z0qvA33QZJLh8sH7WG7zQ+Lqf+juyOsKijTQ8NBhYh5gXLpTS06ITiGxzd+hsFSTtAzZor7G CAymXCl+SemsD+7iWZ+37Y7pxQltek4txfBPaUgsxQDjn3kA6naKloRrXHljEop+OE7kosjb D30lkdFvU2z0mUUnC+oBPr1QWl+DEy60X6wVvdunfnqdyRfkNxN+NxwaZiNjfJ4Uspu99xlI hR2XiCipZRBRTc2Azg+tnhTXhR5wiJiEtntdRWo21UUIMYZrMUh5cY5llpHJAJGz+/wJw7Ed NpENrX6J9tABCnhkjizy1SKeGXLzMO9k/seDlFhiXV6UkXoJlB9Tpc+CRF9U1wra7USPF/lq /52+pT5elzpmJ/V9MKOA47e7rCNoX6e2OFDIujGyWTKEg5AQO7l3fW2sR52Aj4Qu1F8HMN8K 6xGW+w81RCIH7TNQ== X-IronPort-AV: E=Sophos;i="5.85,272,1624334400"; d="scan'208";a="52082718" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nfjvxeuYzk9xRximLHfT1uCp3BqMPTwM+t1MFhP7VM4LKf4cuYzKWsvXDDp/fsVWsJIYWSzMREH96vwZxb2kNTkh/srzEdU37ZlVkYtFL6KJJ91uCBlZFCg/RS0PuZHaa0OEyf0sz0Rn8UZ3qJbGqan6nBpROCVkmCjMmD+KYUJJBJnRDjQGpoWhB7QGVcQ+TJ54OwTHe51aZ15TjlJRaixe4tPX1KffAVPScdFAyjhpG95GuWPrl0npPB2ZbF05ovnITDtrPF3Z/d0HkfjGp95Trs3AE/B9OtTFajeBVadT9Jky6lvUZjcJscmUNUWbZMacHJCqI7xX10/+cEktRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=PRyRSKeSK8xNzfD/CkdS3fjOL8eQZf6W+On4hkPJgyY=; b=EVZATBHR2QTHRMBDr6eciyk5kLKhOS+R3maEnPpRg+DhwVcU5VV6TZ+1e2D2ntozFc7PbEKPN7IlK1JFghYz9MZGXC6rHLDhA33J9RTC7XwLkexUYqbINpZ9qKQ+55+jSUBjyuB226eGRBM0G9s4ln9ZInYdqkX2C5uio+xHzd/ND3O1iXkaAeRjy8Ywt6jBYtlnzshvMf9iR1qyoOwDUziLuauTjbLdpN/vM5qjm5W4q3jASWD5MasqEihSZS0hVI8BmsKw4AiH+vmIQ2e7U7lF2W3uVi2uOgB8EUaSwLz/x1p1TB4kWDAOeIz8XONpyRuefMJt8fNLJ9PMBF8YZA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PRyRSKeSK8xNzfD/CkdS3fjOL8eQZf6W+On4hkPJgyY=; b=mK6qUL4ivudI9fYpmaG9Uy/AAWlLffwiXIRivkdvlmcU0OBn0bNz5wB2SOhhibADxvbbPIu73iSGtOeRUgu/6ou95Rj99aTt1r18SW8WmfVg2NGawzsxnUCnNfaRTbUBnq5CoqNindzC0jme6r/EvAj5sCOQV7aePu6w5ZqXRco= Subject: Re: [PATCH] xen/sched: fix sched_move_domain() for domain without vcpus From: Andrew Cooper To: Juergen Gross , CC: George Dunlap , Dario Faggioli , Bertrand Marquis References: <20210906110057.15384-1-jgross@suse.com> <0006eb7d-a9d5-16a3-1418-a1d28c4c9a92@citrix.com> Message-ID: <2a42660c-e1ae-c791-784a-da39e64473f3@citrix.com> Date: Mon, 6 Sep 2021 12:18:37 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 In-Reply-To: <0006eb7d-a9d5-16a3-1418-a1d28c4c9a92@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-GB X-ClientProxiedBy: LO2P265CA0167.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:9::35) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3192ee62-46e8-4a02-093f-08d97128162d X-MS-TrafficTypeDiagnostic: BYAPR03MB3669: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: jt4BjobyesaZRW/Oxf4xa/EFF/Ar6/NQ6VO64zIE0xRXa/4CuAMnIcthjTlmFLww5OF3nUPqSx1X9zuB5uFAeER1jD21VpdVE7VuDpD3wsgCRhbXPFQBEJ9EQdfgXLSR0MKXVxZ2Q6MCkYXIdUZm3kHOJSNLv3spKs3L6JHkLm06CksIfhgtE+xiX2BOwYRrkR7EIwS1e4Ghq3zsduo4jDlELPSNqq1js2AioLaN6Kwv++wCi/AKATjbpRzSQKizg9zXqsKGeCICM2Cf8hRY1SY+O4NGdzvVE36Yw66D8LmefaGJxKZ4YSsjTwcrNedevaYhFzmZ2sd3UQrcdX0htAJJEn5R636kE3tkSPCOpeBoGgkC/5ZJeYts5hiC5buXcTZM8jZduv9ckui+dBHRzqoue6rLCaa6d5Qk54Q8K5hLmfbP11N8ochgkHrcZUZALnm4DE1y1V77xPrb2eX7YO6cTpDZrPkEeGh7JumfuqGulZW47eMpma1L7PBsE5v5zTvQYaZoi51DEPIXowOdv1ibAsZtDaaTNSvZwYNuD2NhRCICLVKPPnHxgwV1OFb2LjRvKxGe+ukI1MQIxgPm+TU6VRzEyXqgCUOzL0Mx4f6RZwoYsqZea4ZWb7/iB7A6TIJPtT9ocENehYnS0W5n5LxCVmeigTCA5910ayBSykn2KMb4OxoYWaBJbLJIo49xrG6ktewQv+xAsnnOLWuoIQ3Sy2YtBCkJ1fsjFyVe/EI= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(136003)(376002)(346002)(39860400002)(366004)(66476007)(31686004)(8676002)(36756003)(5660300002)(8936002)(31696002)(86362001)(6666004)(54906003)(16576012)(66946007)(55236004)(66556008)(6486002)(316002)(2616005)(956004)(4326008)(478600001)(186003)(26005)(2906002)(38100700002)(53546011)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aEhtdkpnMTU5WjdNZzRnMUVLYVVhSlhwVjZ3bmZKYW5mQUM4eVRRcTlYTXI4?= =?utf-8?B?ZEprM21pMTREVzlPRExrZjZjQjFsQWl1b0RVNHRkSGR2cS9MemkxdUZHZUQ2?= =?utf-8?B?YXMvSUUyc3k1dnFLVXdqd2s3WTJjUHJqUXBSRTRKTUtsQ1VRVjQ1c1R0ZUw2?= =?utf-8?B?VGJXVzZ5c1V3TUtPTFdYZjllWHAwQlo4eXNRTjNwQ1BPcWwwOG5wbzJFT0Fz?= =?utf-8?B?blV6K3AxdDZCSjU4OWFLSENxNHB3bHNuT2JKVWpnN3ByK0N1UUJvUzBQdlhU?= =?utf-8?B?UG1mV2cwalVkQ3BsVGpocnZmSVQwWndQUEtBOXgzOXdTT1lVeTFYcFplMFp3?= =?utf-8?B?c0Q3bDkvb2NCNzE1eXl5UWVwR0FHWng1MVFKQ1F4dWNPSHYzYTc0aDRPQ1c0?= =?utf-8?B?TUQzeTJrNlNtSG9xN1I3S2FLOU9PeUJsd1l0Q3E4eHZwcWJuT2c2MjFNQk5E?= =?utf-8?B?UWFNN2hTY0ZrUDZXY3Q5cjRCdUdxNVN4QXQ2dCtPZFYyWmhmU0VSdC9yWDZJ?= =?utf-8?B?SmNLTThGa3BWS2Zucm5CWFZUMS9uVXBQWHNlZm9PYm9LdGg5YnJKK0lFVHh2?= =?utf-8?B?aGY4bUFvMll0QjZjWnZGYStJTFRiUVhFbWUrdDZ2SzNWalJVbVpES3QvZ2NK?= =?utf-8?B?WEFybURzN1N2cDU5bjFWQmJHZmFGdFl5OHBYQkJGdDVmTTFKbEV4RXBqUTJx?= =?utf-8?B?VW0rQ2sxY2xpUWQ3b1dTNXVXZG5GT2dIa1hwWUN3bFh3Zis0ZEpQbS9DaUJv?= =?utf-8?B?dkJKbHBjZk5wUEl4TnllNnArbkl0bVdSVXRIS2hQWVZrOGIvMVNaNE90bmVr?= =?utf-8?B?dEkydzZJSG1tbXRVdE9pQ2xNdTFwU3dTWFJTYmRQTTFtd2k5SmhFc1lpdDRX?= =?utf-8?B?aS82bkttK3Rod3c5K3c2UlJmWEk4UlJGdCtkdUl1eGtvTjdCN3d2YlhOYzEw?= =?utf-8?B?dlFJbldGbXdKVmtQZi8rVFNLWmRmNllYSXVPOFF1cHpWdzU0dWtmd29MVUJK?= =?utf-8?B?WkFnOWdGVEJWbnp5eEdITjFjSUcvMExZMmpjZi9UQlA0aHB0bEZoSGRTcENH?= =?utf-8?B?RUtiRHVrb0FoNmlwNWpNSEs4czdyVHBmZnFLM1o4TnB0emd6NlFoL0ZIVHNm?= =?utf-8?B?eWIrMDFzOXc2YjNQdm8zcllPSFRKSW1vdXpMaWl3OG1reWZXRFc4bjJzMm9F?= =?utf-8?B?MnVHeno4aVh0eVN4SmJrdzk5cVlxakRnVGpZUzFDZFFmSGZvYU85dloyS2Zl?= =?utf-8?B?ZDV0cWVLbU1ybnR0SU9RZFFLZ3dHaTkwQldOZ3REcEpiNHlzWlZWYWN2Skl6?= =?utf-8?B?RU10S25JRjhKK1FjeUp1T0h0L090a3ZnZEx1Y0NSbUxwcEx3YWNGc2VmR0dt?= =?utf-8?B?VXhEN0pJTklqM3hZTWVXaVNHc3NkQjRlM3BoMmNiQjJWcm5aa3J3SGpNT1pi?= =?utf-8?B?K0xaelpvdEZwNzVNRVA0NWFNK1lVTVNDVW1yUWZrS0VRdlVRZlBwSnFrUzBU?= =?utf-8?B?WXF0ZmJXUlBNaDQ5d0U5OHg4SmVZQ1VJRTE0dnAyRnc1SE1WOG1teWI4MXlJ?= =?utf-8?B?d283anFFdUhFeUtUamRJdXAyd0RDejdqb0tPZTRzTjZ3SXMrUFRjcFJISzJq?= =?utf-8?B?cnNkWVYvdlNMUGlLMmlsdjY5T3VUbHJ3WmpKYnlsTzBFTmVIRHVCSjBKS2Vi?= =?utf-8?B?S1Vnb0RZaWpJZ2xSKzI0WTgvVlJBbDZvOXZ5cmdBZjZJQlZRbmpjakw0cVk2?= =?utf-8?Q?pVQ0VIgY854DbH4SZBk71eKkHJGJM/HlUryC1NA?= X-MS-Exchange-CrossTenant-Network-Message-Id: 3192ee62-46e8-4a02-093f-08d97128162d X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2021 11:18:43.5795 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: X6kutlrTSiw1q/o0x5sTJaZ4ylVdG1TLZSnRidwCxdf190au1FI7WTdxf/H+bNsLcMQCjVbX4nh+Y1ofy6xc95OQjPLEzNV1CPMq4k+An2g= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB3669 X-OriginatorOrg: citrix.com On 06/09/2021 12:14, Andrew Cooper wrote: > On 06/09/2021 12:00, Juergen Gross wrote: >> In case a domain is created with a cpupool other than Pool-0 specified >> it will be moved to that cpupool before any vcpus are allocated. >> >> This will lead to a NULL pointer dereference in sched_move_domain(). >> >> Fix that by tolerating vcpus not being allocated yet. >> >> Fixes: 70fadc41635b9b6 ("xen/cpupool: support moving domain between cpupools with different granularity") >> Reported-by: Bertrand Marquis >> Reviewed-by: Bertrand Marquis >> Signed-off-by: Juergen Gross >> --- >> xen/common/sched/core.c | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/xen/common/sched/core.c b/xen/common/sched/core.c >> index 8d178baf3d..79c9100680 100644 >> --- a/xen/common/sched/core.c >> +++ b/xen/common/sched/core.c >> @@ -671,6 +671,10 @@ int sched_move_domain(struct domain *d, struct cpupool *c) >> >> for ( unit_idx = 0; unit_idx < n_units; unit_idx++ ) >> { >> + /* Special case for move at domain creation time. */ >> + if ( !d->vcpu[unit_idx * gran] ) >> + break; >> + >> unit = sched_alloc_unit_mem(); >> if ( unit ) >> { > I think the logic would be clearer if you wrap the entire for loop in if > ( d->max_vcpus ). And of course, this is wrong.  Turns out the domain_has_vcpus() predicate still hasn't been committed, but d->vcpu[0] is the correct internal. ~Andrew >   This loop is only allocating units in the new > scheduler for existing vcpus, so there's no point entering the loop at > all during domain creation. > > Also, this removes a non-speculatively-guarded d->vcpu[] deference. > > ~Andrew > > From xen-devel-bounces@lists.xenproject.org Mon Sep 06 11:21:21 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Sep 2021 11:21:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.179652.326037 (Exim 4.92) (envelope-from ) id 1mNCgg-0004Bz-N9; Mon, 06 Sep 2021 11:21:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 179652.326037; Mon, 06 Sep 2021 11:21:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNCgg-0004Bs-JP; Mon, 06 Sep 2021 11:21:18 +0000 Received: by outflank-mailman (input) for mailman id 179652; Mon, 06 Sep 2021 11:21:17 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNCgf-0004Bk-Er for xen-devel@lists.xenproject.org; Mon, 06 Sep 2021 11:21:17 +0000 Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 0bbcb4be-55f2-430d-a5d9-8eb7ee204be3; Mon, 06 Sep 2021 11:21:16 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0bbcb4be-55f2-430d-a5d9-8eb7ee204be3 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1630927276; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=ytoXKKZBgq2BBDO9li+7iEmPK3N6KZ6iFt5jVQxn6DQ=; b=HsWUEmMj5g5K5a0fpfwxhzJXRVOlbEDI6ahyamk9SAP515a4BX7KhCBy otlRaAnNHcekaN2/ORxXymUEgAn9Gc74517r4J+y1OjKPJzdUNMO+Ns70 7EqEOoVFxzzpHUOQu02u2R4LAHW9nBPthonNWavsGGHDQZV9x8eerSVSn w=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: xeB6+cUldNGZTvDItGjVErmqjASTCsTVVfkPWK+6B2Rqqv5Hv4n6V7J9v6Tl/NsoMBR8fdwpuy auNR9FNlKJHExAJ6L3DIz5rfs/gdicgXRM71dDSYfZSu9WF1Nzw8llywlQ+QQ6Cuh2nEzOl/pV yPqQH1MTHF5Gb83QuCrgthhX0dk204VXcoZR8aMWhEw6CHS2x014BFOShN7ncfhqPwAnjr+YVZ Orm2iTV2v7dXFCY2Rr48afLqC40tLiL0bNjHZOjwGJf/rsTOi/EnbStdcnfngtzr9Y7MOaJx7+ 2wyRtrKAUQ4db7TVnTxuUO/F X-SBRS: 5.1 X-MesageID: 52484249 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:Ith7NqFoh3gH0OgxpLqEP8eALOsnbusQ8zAXPhhKOH5om7+j5q WTdZUgpGXJYVkqNk3I9erqBEDEewK+yXcX2/htAV7BZmjbUQKTRelfBMnZowEIcBeSygcp78 hdmt9FZOEYY2IRsS+w2njdLz9p+qjhzIm4werRi2xgQmhRGsddxhY8BwjeCUtsS2B9dOME/F nw3Ls9m9OPQwVuUviG X-IronPort-AV: E=Sophos;i="5.85,272,1624334400"; d="scan'208";a="52484249" Date: Mon, 6 Sep 2021 12:21:06 +0100 From: Anthony PERARD To: Jan Beulich CC: Andrew Cooper , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu , Roger Pau =?iso-8859-1?Q?Monn=E9?= , "Tim Deegan" , Subject: Re: [XEN PATCH v7 01/51] build: introduce cpp_flags macro Message-ID: References: <20210824105038.1257926-1-anthony.perard@citrix.com> <20210824105038.1257926-2-anthony.perard@citrix.com> <280c5579-ee62-ed36-1f08-58fe5b9ca34f@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <280c5579-ee62-ed36-1f08-58fe5b9ca34f@suse.com> On Mon, Sep 06, 2021 at 12:30:07PM +0200, Jan Beulich wrote: > On 06.09.2021 12:06, Anthony PERARD wrote: > > On Thu, Sep 02, 2021 at 12:08:58PM +0200, Jan Beulich wrote: > >> On 24.08.2021 12:49, Anthony PERARD wrote: > >>> +# To be use with $(a_flags) or $(c_flags) to produce CPP flags > >>> +cpp_flags = $(filter-out -Wa$(comma)% -flto,$(1)) [..] > Well, yes. This way one could also pass more than just the expansion of > either of these two variables. The thing that made me think of the > alternative is the comment: Would you mind if I inserted "e.g." in there, > to make clear this isn't limited to these two variables? Adding "e.g." is fine. Thanks. -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Mon Sep 06 11:22:09 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Sep 2021 11:22:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.179658.326047 (Exim 4.92) (envelope-from ) id 1mNChV-0004mD-0J; Mon, 06 Sep 2021 11:22:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 179658.326047; Mon, 06 Sep 2021 11:22:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNChU-0004m6-TA; Mon, 06 Sep 2021 11:22:08 +0000 Received: by outflank-mailman (input) for mailman id 179658; Mon, 06 Sep 2021 11:22:07 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNChT-0004lB-2U for xen-devel@lists.xenproject.org; Mon, 06 Sep 2021 11:22:07 +0000 Received: from smtp-out2.suse.de (unknown [195.135.220.29]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 6da9db43-d88a-499b-b0fd-cecfad644a93; Mon, 06 Sep 2021 11:22:05 +0000 (UTC) Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 0F59A1FEDA; Mon, 6 Sep 2021 11:22:05 +0000 (UTC) Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap1.suse-dmz.suse.de (Postfix) with ESMTPS id D706F1395F; Mon, 6 Sep 2021 11:22:04 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap1.suse-dmz.suse.de with ESMTPSA id vfZkMtz5NWHMHgAAGKfGzw (envelope-from ); Mon, 06 Sep 2021 11:22:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6da9db43-d88a-499b-b0fd-cecfad644a93 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1630927325; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=bZxp9VPY5c6s8wGWdcldGfjpDN2Ri4rZPWfB5DP4AhM=; b=bEaIQLE5MuOXofj7XevBMD0xy+9D6CkEGI6CYk3d3+8iq+g/iihWrHggeKk2q1oegYM5nh CURX71E2d7T1M4vuz5eax8R5OIoub50wNLYiv1z+l+wn5AYA2uuxlnskgfja76+bxCNWMb f0qRM0QDeXn+VI593KSgj6yLSr62CBY= Subject: Re: [PATCH] xen/sched: fix sched_move_domain() for domain without vcpus To: Andrew Cooper , xen-devel@lists.xenproject.org Cc: George Dunlap , Dario Faggioli , Bertrand Marquis References: <20210906110057.15384-1-jgross@suse.com> <0006eb7d-a9d5-16a3-1418-a1d28c4c9a92@citrix.com> From: Juergen Gross Message-ID: <72a7728d-1b30-5cc7-981d-50471e77126b@suse.com> Date: Mon, 6 Sep 2021 13:22:04 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <0006eb7d-a9d5-16a3-1418-a1d28c4c9a92@citrix.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="DqXVcNp9qsxotgnM55gXR6Fc3Gf5QKbfg" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --DqXVcNp9qsxotgnM55gXR6Fc3Gf5QKbfg Content-Type: multipart/mixed; boundary="VzyTPZaAbTyoAKrBL7tBm5kVgPMOxo8kl"; protected-headers="v1" From: Juergen Gross To: Andrew Cooper , xen-devel@lists.xenproject.org Cc: George Dunlap , Dario Faggioli , Bertrand Marquis Message-ID: <72a7728d-1b30-5cc7-981d-50471e77126b@suse.com> Subject: Re: [PATCH] xen/sched: fix sched_move_domain() for domain without vcpus References: <20210906110057.15384-1-jgross@suse.com> <0006eb7d-a9d5-16a3-1418-a1d28c4c9a92@citrix.com> In-Reply-To: <0006eb7d-a9d5-16a3-1418-a1d28c4c9a92@citrix.com> --VzyTPZaAbTyoAKrBL7tBm5kVgPMOxo8kl Content-Type: multipart/mixed; boundary="------------DF3084C52409BDBB90E4E232" Content-Language: en-US This is a multi-part message in MIME format. --------------DF3084C52409BDBB90E4E232 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 06.09.21 13:14, Andrew Cooper wrote: > On 06/09/2021 12:00, Juergen Gross wrote: >> In case a domain is created with a cpupool other than Pool-0 specified= >> it will be moved to that cpupool before any vcpus are allocated. >> >> This will lead to a NULL pointer dereference in sched_move_domain(). >> >> Fix that by tolerating vcpus not being allocated yet. >> >> Fixes: 70fadc41635b9b6 ("xen/cpupool: support moving domain between cp= upools with different granularity") >> Reported-by: Bertrand Marquis >> Reviewed-by: Bertrand Marquis >> Signed-off-by: Juergen Gross >> --- >> xen/common/sched/core.c | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/xen/common/sched/core.c b/xen/common/sched/core.c >> index 8d178baf3d..79c9100680 100644 >> --- a/xen/common/sched/core.c >> +++ b/xen/common/sched/core.c >> @@ -671,6 +671,10 @@ int sched_move_domain(struct domain *d, struct cp= upool *c) >> =20 >> for ( unit_idx =3D 0; unit_idx < n_units; unit_idx++ ) >> { >> + /* Special case for move at domain creation time. */ >> + if ( !d->vcpu[unit_idx * gran] ) >> + break; >> + >> unit =3D sched_alloc_unit_mem(); >> if ( unit ) >> { >=20 > I think the logic would be clearer if you wrap the entire for loop in i= f > ( d->max_vcpus ). No, d->max_vcpus is not 0 here, otherwise n_units would be 0. > This loop is only allocating units in the new > scheduler for existing vcpus, so there's no point entering the loop at > all during domain creation. >=20 > Also, this removes a non-speculatively-guarded d->vcpu[] deference. I don't think this dereference is a real problem. In case you are worried about it we should replace the one further below, too. Juergen --------------DF3084C52409BDBB90E4E232 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Transfer-Encoding: quoted-printable Content-Description: OpenPGP public key Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy= cWx w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O= f8Z d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y= 9bf IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq= G7/ 377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR= 3Jv c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA= QIe AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT= hpw dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0= MbD 1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv= oPH Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v= 5QL +qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ= 2Vu IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC= QoL BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr= Wf0 teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC= /nu AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh= ITT d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm= XBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz= 80h SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC= AcD AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn= FOX gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1= jnD kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0= N51 N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l= otu fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1= tqS EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA= hsD BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3= g3O ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5= dM7 wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5= D+j LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm= V2x AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N= Eaw QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW= nHI s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR= wgn BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV= bVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk= pEd IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA= QAB wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw= Tbe 8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1= vJz Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8= VGi wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW= svi uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX= zXs ZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------DF3084C52409BDBB90E4E232-- --VzyTPZaAbTyoAKrBL7tBm5kVgPMOxo8kl-- --DqXVcNp9qsxotgnM55gXR6Fc3Gf5QKbfg Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmE1+dwFAwAAAAAACgkQsN6d1ii/Ey8T +gf/d689AFSV3hds3y/QXlpXUIPF3DagRR4HOLSSJeQ2q7/NgGTQ9fMDm0p2qMwCP4fIjNzHnsg9 Jb2W9kvV/y7PJ/LyhoXEwSyXc51zFqPgH7lJrCTP59lq2N7n6pxK8GxDOyX4maaIpQNmzDkwvCmz 3vIjbNbKzShLHV+0CZajwxoPEGaLOPcV10gI+VnfWU9Z+GtieDroDm028sqopjiz42yqCyE+eeHW YcDHIPGrlwknjlZnQowcXfadMDvYKBX9Cp397jDP8z0q6a0oxQOeukAG7/tJ3hTv2EE70CUwGt9j GUv6OK3UfK9ujo3fkbBN4kznB/dMJsLrx4g/rIkJWA== =vY95 -----END PGP SIGNATURE----- --DqXVcNp9qsxotgnM55gXR6Fc3Gf5QKbfg-- From xen-devel-bounces@lists.xenproject.org Mon Sep 06 11:23:32 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Sep 2021 11:23:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.179664.326059 (Exim 4.92) (envelope-from ) id 1mNCip-0005PU-C5; Mon, 06 Sep 2021 11:23:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 179664.326059; Mon, 06 Sep 2021 11:23:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNCip-0005PN-7O; Mon, 06 Sep 2021 11:23:31 +0000 Received: by outflank-mailman (input) for mailman id 179664; Mon, 06 Sep 2021 11:23:29 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNCin-0005PC-A8; Mon, 06 Sep 2021 11:23:29 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNCin-0002Ut-5w; Mon, 06 Sep 2021 11:23:29 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNCim-0003d5-PA; Mon, 06 Sep 2021 11:23:28 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mNCim-0005DX-Oi; Mon, 06 Sep 2021 11:23:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=6sEuM6y8dZxSOdmA6FXON8rgpZtbf1M8ejPiOziwm3A=; b=Hu+wiVpMyuGvExkvKEiBthljaE VSAixurXyY0A8hAkkRXcIuamhtA9W3Xmh/dDjy1/8qfb6IJoSMH71ZBlg2Ov0+Xg3JcpxLwWbn+nU 5ArZiGgDc50CvtIX5kK1lC2ybwguPDvtf9dEZPVkquvSitUhZK4V4PGDxvRsPk/B4gpw=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 164848: tolerable FAIL X-Osstest-Failures: xen-unstable:test-amd64-amd64-examine:memdisk-try-append:fail:heisenbug xen-unstable:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=2d4978ead4b98452bc45ebe47952e524b12e2b41 X-Osstest-Versions-That: xen=2d4978ead4b98452bc45ebe47952e524b12e2b41 From: osstest service owner Date: Mon, 06 Sep 2021 11:23:28 +0000 flight 164848 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/164848/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-examine 4 memdisk-try-append fail in 164819 pass in 164848 test-amd64-amd64-xl-rtds 20 guest-localmigrate/x10 fail pass in 164819 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 164819 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 164819 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 164819 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 164819 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 164819 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 164819 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 164819 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 164819 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 164819 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 164819 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 164819 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen 2d4978ead4b98452bc45ebe47952e524b12e2b41 baseline version: xen 2d4978ead4b98452bc45ebe47952e524b12e2b41 Last test of basis 164848 2021-09-06 01:51:30 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Mon Sep 06 11:23:43 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Sep 2021 11:23:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.179666.326073 (Exim 4.92) (envelope-from ) id 1mNCj0-0005np-SN; Mon, 06 Sep 2021 11:23:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 179666.326073; Mon, 06 Sep 2021 11:23:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNCj0-0005ni-OA; Mon, 06 Sep 2021 11:23:42 +0000 Received: by outflank-mailman (input) for mailman id 179666; Mon, 06 Sep 2021 11:23:41 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNCiz-0005ms-Kl for xen-devel@lists.xenproject.org; Mon, 06 Sep 2021 11:23:41 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 79dfadaa-d577-4815-9aab-3aadf84dc4c8; Mon, 06 Sep 2021 11:23:40 +0000 (UTC) Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-am5eur03lp2059.outbound.protection.outlook.com [104.47.8.59]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-30-NqeZ9Tc4NUSIe3A-WzbJOQ-1; Mon, 06 Sep 2021 13:23:38 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR04MB4192.eurprd04.prod.outlook.com (2603:10a6:803:4c::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.24; Mon, 6 Sep 2021 11:23:37 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4478.025; Mon, 6 Sep 2021 11:23:37 +0000 Received: from [10.156.60.236] (37.24.206.209) by AM0PR02CA0176.eurprd02.prod.outlook.com (2603:10a6:20b:28e::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.20 via Frontend Transport; Mon, 6 Sep 2021 11:23:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 79dfadaa-d577-4815-9aab-3aadf84dc4c8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1630927419; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xx0HZQkV4tYv17/m2KPYg7jrcsCcKDrCsNTIkEptX9k=; b=WJCvI7C7nNkLsdRwpOT3a4MAI2JNZijyNRB0sH1Se81kGatKSnIrjnSJVFk/sdhcBqj/EU WgTXeLSeRHZXX5uLCc/KxMiXXngkHFUk9KThewrIZhYi95fXfYb3AZWgSK/suN5PwmrT5w n1SQ0S/Yz/hwDAExs3LFwHsWXbLfPTs= X-MC-Unique: NqeZ9Tc4NUSIe3A-WzbJOQ-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Nv4AqZAEXed4h/4/31nXsI8HDGBgLiqohdxyp7hkBikhUv74YGeNmwk618m+7Z81++uXeQvZSOTdcfQNqU4xqBQfJAaaE3Pk4nu9cvSQg04WG8F6eP3lNG//PxpVcoT3rAJa+2K00b8nz67uI2uS71M4gADgZ7eRE1Xaj4TvB5QVK60SXXvGf8Z/dh6sfHdWYTmVfdX8rQj+fZ1QIUznaUB4uiAkyJlozRHBRuuIvKXFofzhfS5gzokETtGclqLFbZ1TcNQpcyqvjODBnz3mjPpHGLp5qB1bu/1izvywnGE+4zRfon5cYCREjfFOZRecUz31mm6kf5NfhsvsW8DZFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=P10PInH1DfhGLms21QzcUomgnt98pv9+SUigsNNpRbw=; b=ctIUMbPmrAqRPB2SMPfaizx+Dr7nyPBafW3aTN47XsS9fOIzSeciOgSbO3X2/QugePwO0VAp+OVA3OygUEIznoYa8qjcdj6c2vylTo1bA91UHz68TrPpfhO5l+aO+JreUMa8KLhADmGBmvKBYsoUpiAXtBbg4i//t7lQu6j9cigffc7tn06rwD74ED8rKAe70/yh3nxxuUNNfQkhsd5h4EgaaQbJCMyJ8H7KupQhSNHsd/DYbpYDvXaM4sMpG+7rJdqTW0YXfvoZKoDKBKevkCrVwsLui8msaoU8lHbzyQDzdReZlee2PfI669jvkIrNFPbxcKK+7phl0RS5GRuRrA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com; Subject: Re: [PATCH] xen/sched: fix sched_move_domain() for domain without vcpus To: Andrew Cooper , Juergen Gross CC: George Dunlap , Dario Faggioli , Bertrand Marquis , xen-devel@lists.xenproject.org References: <20210906110057.15384-1-jgross@suse.com> <0006eb7d-a9d5-16a3-1418-a1d28c4c9a92@citrix.com> <2a42660c-e1ae-c791-784a-da39e64473f3@citrix.com> From: Jan Beulich Message-ID: <598640b9-758a-5a0c-83cd-38b3e41d7b39@suse.com> Date: Mon, 6 Sep 2021 13:23:35 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: <2a42660c-e1ae-c791-784a-da39e64473f3@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AM0PR02CA0176.eurprd02.prod.outlook.com (2603:10a6:20b:28e::13) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 52483e6e-a830-4d49-26f8-08d97128c51e X-MS-TrafficTypeDiagnostic: VI1PR04MB4192: X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ZSDvWTTR7eQMSLoBbChbX6usSKHGvRClQNok3u/gLQI9UbErC+ymyMkvews1ip1rRARbIKz2SavqwSyqCFbQgtcPOpQm028JNP2307VFw3roPWxjYWt/fyRJX/9HjE4y8SpkcRufemYbw//YWUy1wxb7QE0iZ89IBZRxQoHOIU4h+hCnUuqA//GLXrEl1AitcyERB92DC8fadvLkIFnRmtddTMWMn5wQT5leZvSvN9a86EKVrsqEH6L3UeGAgRQahX+zi2dcqbNaN313kSA3V88+2Sauwuqn4+m79Yta6qiPkSfXI7zkzmY8HPBtIkj7hkV/SAqBj4Wf67ckLW39cP2WhO3cBENoR+5QYqeTO92QZwa5EqysjvCFajV7/9eJvr/6eUt13FJu3T4tre9pZZb1Mp9Q+gv+baB2FFxJM7nybIIsw8rVL+kdXNvQ5kwF8vNjvLgjcNEXlhnqWHAWaPpOThT8BtZcDuOXlGT+v2JnmTrG1CFVC+m6VvW4RXOqDw3dC8jPzjLYtk73/swHi+yOVNJhaJ40Wa3w4zCJx70xbbYpT0tbpk9cB90N0x19Qt6tdNfsPqhGdgr2N46aNISb/Bnl+wMA1k4awJ8E58lGZDCNlujmIIZEaqiXLT/OKJJK6/NKuFF7YM3SwRL6o3m4tZeYcun6zVeRLF8et1RCjzRbssnIriJuHwKwg6RkeiXBsq83plAHx0fg0IcnzuakeYtmtkEb1jauPZcDhNU= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(39860400002)(366004)(396003)(346002)(376002)(136003)(31696002)(2616005)(956004)(110136005)(4326008)(36756003)(2906002)(6486002)(31686004)(66946007)(5660300002)(8676002)(8936002)(478600001)(38100700002)(316002)(54906003)(16576012)(86362001)(6636002)(66556008)(53546011)(26005)(66476007)(186003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?2NCDR6Fz4fI3v9SC516A+ZGD7IPHdRrqnoqV0C7KuIHG0sABTvhWmJJiaSr+?= =?us-ascii?Q?AEp6RGR9VqZtsQlbOhBZZ/BKqMMibEkrfrLj//98rmt64ZUnlip6XhRqiBJM?= =?us-ascii?Q?ltBR0qP18KSpMx6opOaXawGMMgxtkMaEhpbJ0+y6YZq82VOwSywlQ7w6vznE?= =?us-ascii?Q?WJr0Qnau+wuan3uRhj0C84czggxcRPz1GPxuuJ5hTk/gqrsbrCctYO2VOi2D?= =?us-ascii?Q?B+Ml/KYhu7pB6MOWsyCmrFFtG0GkN64W+7vhqOpVMcPD9md2DYOTU1RnkOQP?= =?us-ascii?Q?ARV3hWU6i2/NidB6Vgmeup9JoKB5l+LFzM1k7AG6j6FcQ9jVVSPQukL8MoqU?= =?us-ascii?Q?2kojc4dBLs13mWAJ2vN8Tft9qqJeZQz29tMdc5q6UQ491RJDH4S7rR6By36/?= =?us-ascii?Q?Pbs/n0h4JiNOn+yuJjVgNvXw+7OUav+fQyjTb2F4mWux8tiWVTodQHx+ZOs7?= =?us-ascii?Q?n6nECBsbIbTumj2yhSEDZ4MmmlUMq85qp06W8tCxiTPRsr7ttptlnhHfW+oe?= =?us-ascii?Q?sBsX9ks2eMKrK14X3DlhmuvSKngT1oZSJdk9D5IgA8muomsyIwKD2RZ5cmoI?= =?us-ascii?Q?0OCGgDTjl8oHicvqjB1ykywU0XfLfR/ztxr3YSOv2vzbd3OE6CkQAnVRj3lo?= =?us-ascii?Q?E67deN1VjgOoE6N1Keh6or1ArH7DPQOdLnHrlimusvzb9OTxEzAFk5SVrIx+?= =?us-ascii?Q?PcDwZpmWi0aCm3oc93AeQ6EmRlZox6duXP1ZeGp8MeUfU3+tirLZpxvUyf2i?= =?us-ascii?Q?5GRBIuVf52lWJIjuMAz+LOEEWVXcufHSPQP4h5bUZFJh0F66MzFS4PBHBNGl?= =?us-ascii?Q?iDCs/29195XQmoJ30cBibHebNFbGMFfmicJph3M+U8ZXrrFZJxjGndEVQCGI?= =?us-ascii?Q?I6b8PYkXDyZT/w1XJ4d0bhFAt7Y7XMqyYwZuwq8yyHjHi+7TlD/8asH0HSzu?= =?us-ascii?Q?PYdhn6Z6YYS+JU2HoUf5qLAKujl727nwa5Vb/np4Jre6YCX2LDdsD8HyG9v0?= =?us-ascii?Q?uFwnStE/2/jxxFMoBIY8AJAvBU5u4gNP2keMpqwJVItu2eDO2MsX501CHPCh?= =?us-ascii?Q?Jg2izlXzh4zsRfGn51ynOMJYUwSALn+glif84FOpdOGUS3cmLJbbhnNq56wO?= =?us-ascii?Q?0ugaVF1cPSAK1A50tnZiATkkW9KaPRi0nI/xEOD6pbQqxJLPuFPZB77sQWvi?= =?us-ascii?Q?7Qmk3xGZ3wvDUa95WESOK057MD9+Nje5TN8x9tii/j8/fbkFBSv+F43KLDuB?= =?us-ascii?Q?Cu8iNeIcHd9LfEFVxIdbZ9hrzTOfPZ6z0Z9TYDsweVqIOoCtOqNm9wMAUtVc?= =?us-ascii?Q?AbRQQygqrFLNNK2+9ADR2QNb?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 52483e6e-a830-4d49-26f8-08d97128c51e X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2021 11:23:37.1023 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Fq2+jMR1+ZTo0z/4NiHsmI0dSAg4WalspNEz8xgiQL4ZCOpyjNBrpLjJqcBf8ZscmfYmH9YRvl56TGCeOU++Og== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4192 On 06.09.2021 13:18, Andrew Cooper wrote: > On 06/09/2021 12:14, Andrew Cooper wrote: >> On 06/09/2021 12:00, Juergen Gross wrote: >>> In case a domain is created with a cpupool other than Pool-0 specified >>> it will be moved to that cpupool before any vcpus are allocated. >>> >>> This will lead to a NULL pointer dereference in sched_move_domain(). >>> >>> Fix that by tolerating vcpus not being allocated yet. >>> >>> Fixes: 70fadc41635b9b6 ("xen/cpupool: support moving domain between cpu= pools with different granularity") >>> Reported-by: Bertrand Marquis >>> Reviewed-by: Bertrand Marquis >>> Signed-off-by: Juergen Gross >>> --- >>> xen/common/sched/core.c | 4 ++++ >>> 1 file changed, 4 insertions(+) >>> >>> diff --git a/xen/common/sched/core.c b/xen/common/sched/core.c >>> index 8d178baf3d..79c9100680 100644 >>> --- a/xen/common/sched/core.c >>> +++ b/xen/common/sched/core.c >>> @@ -671,6 +671,10 @@ int sched_move_domain(struct domain *d, struct cpu= pool *c) >>> =20 >>> for ( unit_idx =3D 0; unit_idx < n_units; unit_idx++ ) >>> { >>> + /* Special case for move at domain creation time. */ >>> + if ( !d->vcpu[unit_idx * gran] ) >>> + break; >>> + >>> unit =3D sched_alloc_unit_mem(); >>> if ( unit ) >>> { >> I think the logic would be clearer if you wrap the entire for loop in if >> ( d->max_vcpus ). >=20 > And of course, this is wrong.=C2=A0 Turns out the domain_has_vcpus() > predicate still hasn't been committed, but d->vcpu[0] is the correct > internal. Which in turn might want to be done by setting n_units to zero when d->vcpus[0] is NULL? Jan From xen-devel-bounces@lists.xenproject.org Mon Sep 06 11:34:37 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Sep 2021 11:34:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.179679.326084 (Exim 4.92) (envelope-from ) id 1mNCtT-0007lI-SR; Mon, 06 Sep 2021 11:34:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 179679.326084; Mon, 06 Sep 2021 11:34:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNCtT-0007lB-PI; Mon, 06 Sep 2021 11:34:31 +0000 Received: by outflank-mailman (input) for mailman id 179679; Mon, 06 Sep 2021 11:34:30 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNCtS-0007kz-56; Mon, 06 Sep 2021 11:34:30 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNCtR-0002fx-Pr; Mon, 06 Sep 2021 11:34:29 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNCtR-0003zb-JV; Mon, 06 Sep 2021 11:34:29 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mNCtR-0002ju-J1; Mon, 06 Sep 2021 11:34:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=0eDTU8jfiGc8cMZ4DBxu2q7eVcDUGX1ebfvzaY6rne8=; b=tZcR3BjNMopZvKEQI/mopTV7qm 4M+U1/lxeSaEvJ19xX4z20WdAzWephgl52S77SihPh1ZkQ5BNx8rGKTZtgtzDLc+evPrZ5YS/ogW8 PIPn9vAqMxHgkDPnzcVrWRt1NVqWMiQnlxo1qBNjLPNUvmQZgsYHomPaegWA9M2Vcof0=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 164856: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=edf8bc6d24c6f490c27de3144eee88f1ca40ce6a X-Osstest-Versions-That: ovmf=cae735f61328d64e2e8991036707b9e78c0f5f63 From: osstest service owner Date: Mon, 06 Sep 2021 11:34:29 +0000 flight 164856 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/164856/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 164674 build-amd64 6 xen-build fail REGR. vs. 164674 build-i386-xsm 6 xen-build fail REGR. vs. 164674 build-i386 6 xen-build fail REGR. vs. 164674 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf edf8bc6d24c6f490c27de3144eee88f1ca40ce6a baseline version: ovmf cae735f61328d64e2e8991036707b9e78c0f5f63 Last test of basis 164674 2021-08-31 02:56:52 Z 6 days Failing since 164686 2021-09-01 03:03:43 Z 5 days 64 attempts Testing same since 164806 2021-09-04 09:41:21 Z 2 days 38 attempts ------------------------------------------------------------ People who touched revisions under test: Anthony PERARD DunTan Gary Lin Hao A Wu Jim Fehlig Lin, Gary (HPS OE-Linux) Loo Tung Lun Loo, Tung Lun Mark Wilson Marvin H?user Michael Kubacki Rebecca Cran Wenxing Hou Wenyi Xie jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 302 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Sep 06 12:02:01 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Sep 2021 12:02:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.179699.326101 (Exim 4.92) (envelope-from ) id 1mNDJu-0003H4-Gb; Mon, 06 Sep 2021 12:01:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 179699.326101; Mon, 06 Sep 2021 12:01:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNDJu-0003Gx-DY; Mon, 06 Sep 2021 12:01:50 +0000 Received: by outflank-mailman (input) for mailman id 179699; Mon, 06 Sep 2021 12:01:49 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNDJt-0003Gb-Mz for xen-devel@lists.xenproject.org; Mon, 06 Sep 2021 12:01:49 +0000 Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 35354346-0f0a-11ec-b0a0-12813bfff9fa; Mon, 06 Sep 2021 12:01:47 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 35354346-0f0a-11ec-b0a0-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1630929707; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=Pf01GPhpRixaBcZCDc0yr0gLSvWSydMEpj3W90Q2OU4=; b=QzizcM47aFmngZqVWQQk3jdKDp7o238ck78qOwlmbzxLXCAoptelpLkH n/AZtJHtmheaN/+/OyjPUqeVxqPqwZKRxCgwv9wRl2tG7ScXwuguKKigN UnoeWhyPoAFit14aPsVNWX04hT8KEp9oVtl9NPpUz9d+eThaUtWR0jN5O A=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: KrnqQUvoYQ1Xtnsjv+2HZft3xh1JM5c3Bmix5ZKZyETZzEyfTYCmerJ8fuCQu/RtSp3h39P4/Z CwBl859DY//SyLHaO5NggCnnPmPso640oN4UT5r8dYdl2mYYuriluJZPINeyfUWYth027tHzjv 0+wzl517PfFLpLV38+vcO4SbCU61UuwLKy8K6bcHAxLsaMjZ5WucHIcll3ysKyTtCwZYFsJGAL QibNliFBx9d98Zlbp7kR0XaT/4Lgv/gjSVNlB7yruc96llPuTinH/PvOUicjws91DZBrHxDmvD k62KYAMNFG0OosI7ceSUItSH X-SBRS: 5.1 X-MesageID: 52084907 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:NVjIUKHLX7E6fgoSpLqE5MeALOsnbusQ8zAXP0AYc3Jom6uj5q eTdZUgpHvJYVkqOE3I9ertBEDiewK4yXcW2/hzAV7KZmCP0wHEEGgL1/qF/9SKIUzDH4Bmup uIC5IOauHNMQ== X-IronPort-AV: E=Sophos;i="5.85,272,1624334400"; d="scan'208";a="52084907" From: Jane Malalane To: Xen-devel CC: Jane Malalane Subject: [PATCH v1 0/2] x86/cpuid: Use AMD's NullSelectorClearsBase CPUID bit Date: Mon, 6 Sep 2021 13:00:02 +0100 Message-ID: X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Jane Malalane (2): x86/cpuid: Expose NullSelectorClearsBase CPUID bit to guests x86/cpuid: Detect null segment behaviour on Zen2 CPUs tools/libs/light/libxl_cpuid.c | 1 + tools/misc/xen-cpuid.c | 1 + xen/arch/x86/cpu/amd.c | 18 ++++++++++++++++++ xen/arch/x86/cpu/cpu.h | 1 + xen/arch/x86/cpu/hygon.c | 5 +++++ xen/include/asm-x86/cpufeature.h | 1 + xen/include/public/arch-x86/cpufeatureset.h | 1 + 7 files changed, 28 insertions(+) -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Mon Sep 06 12:02:52 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Sep 2021 12:02:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.179710.326112 (Exim 4.92) (envelope-from ) id 1mNDKt-0003wp-Qh; Mon, 06 Sep 2021 12:02:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 179710.326112; Mon, 06 Sep 2021 12:02:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNDKt-0003wi-Nb; Mon, 06 Sep 2021 12:02:51 +0000 Received: by outflank-mailman (input) for mailman id 179710; Mon, 06 Sep 2021 12:02:51 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNDKs-0003wa-VD for xen-devel@lists.xenproject.org; Mon, 06 Sep 2021 12:02:50 +0000 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 5b13c8b2-0f0a-11ec-b0a0-12813bfff9fa; Mon, 06 Sep 2021 12:02:50 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5b13c8b2-0f0a-11ec-b0a0-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1630929769; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=FkKh25/O7W8PkkcqGWWAdNe03OfrUwvjmG6W/c0Qi7s=; b=W3ElB7tmteFnCQuGFTx74y3yUz8GDGPgoB9yFCsFHVPo9mQGLNc07aPW XymkO45suNTqXWM6cuc6MP4JmgndwHhebvaJYr0vE0siNTBYdWHGmtbN8 G7zOkDZV09Mee+UbftjgiqVP6ONVyX1hTSk6wM4uIJqrApVHAxj6vWIWN M=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: qrKOgZfF7Ems9LLXxm7kvfpwSlebblNmSCRhZv7CySQmC/DPOy38zO5mE/RFli4ZnmRNtzZr9x BWqzRjpQ5BRE+CSMLG6ubqdb+fH+OUZ8fP/RHhoTO+xaQ/ILxhOpSWjm4TuB7jIgZWOBsNJA+c oScgX0tH+LlH1e7V+z0Lh6axejXU7MInsGQ7xpNUr6fb61bjKl31Hp9DRyWvcL0oMNxqC6dsif +doS5jx0t+ejYRH6WwxbbUBcDN72QmFRYnXB2ZPpBc7fadylWDko9p00pVuySuBsTOjV1iYgS3 g2oAW0DYiQQcU71Rb75DvvAs X-SBRS: 5.1 X-MesageID: 51690423 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:B/PZD6/oXBQEQxBtr7Fuk+DgI+orL9Y04lQ7vn2YSXRuHPBw8P re5cjztCWE7gr5N0tBpTntAsW9qDbnhPtICOoqTNCftWvdyQiVxehZhOOIqVDd8m/Fh4pgPM 9bAtBD4bbLbGSS4/yU3ODBKadD/OW6 X-IronPort-AV: E=Sophos;i="5.85,272,1624334400"; d="scan'208";a="51690423" From: Jane Malalane To: Xen-devel CC: Jane Malalane , Wei Liu , "Jan Beulich" , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Pu Wen , Andy Lutomirski Subject: [PATCH v1 1/2] x86/cpuid: Expose NullSelectorClearsBase CPUID bit to guests Date: Mon, 6 Sep 2021 13:00:03 +0100 Message-ID: <239f7624f3ac3793993dc045d451079aa555b90d.1630929059.git.jane.malalane@citrix.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit AMD Zen3 adds the NullSelectorClearsBase bit to indicate that loading a NULL segment selector zeroes the base and limit fields, as well as just attributes. Expose bit to all guests. Suggested-by: Andrew Cooper Signed-off-by: Jane Malalane --- CC: Wei Liu CC: Jan Beulich CC: Andrew Cooper CC: "Roger Pau Monné" CC: Pu Wen CC: Andy Lutomirski --- tools/libs/light/libxl_cpuid.c | 1 + tools/misc/xen-cpuid.c | 1 + xen/include/public/arch-x86/cpufeatureset.h | 1 + 3 files changed, 3 insertions(+) diff --git a/tools/libs/light/libxl_cpuid.c b/tools/libs/light/libxl_cpuid.c index b2c673841a..d667c36f31 100644 --- a/tools/libs/light/libxl_cpuid.c +++ b/tools/libs/light/libxl_cpuid.c @@ -289,6 +289,7 @@ int libxl_cpuid_parse_config(libxl_cpuid_policy_list *cpuid, const char* str) {"svm_pausefilt",0x8000000a, NA, CPUID_REG_EDX, 10, 1}, {"lfence+", 0x80000021, NA, CPUID_REG_EAX, 2, 1}, + {"nscb", 0x80000021, NA, CPUID_REG_EAX, 6, 1}, {"maxhvleaf", 0x40000000, NA, CPUID_REG_EAX, 0, 8}, diff --git a/tools/misc/xen-cpuid.c b/tools/misc/xen-cpuid.c index 735bcf8f0e..d79e67ecfb 100644 --- a/tools/misc/xen-cpuid.c +++ b/tools/misc/xen-cpuid.c @@ -185,6 +185,7 @@ static const char *const str_7a1[32] = static const char *const str_e21a[32] = { [ 2] = "lfence+", + [ 6] = "nscb", }; static const struct { diff --git a/xen/include/public/arch-x86/cpufeatureset.h b/xen/include/public/arch-x86/cpufeatureset.h index 380b51b1b3..e5a7c94c78 100644 --- a/xen/include/public/arch-x86/cpufeatureset.h +++ b/xen/include/public/arch-x86/cpufeatureset.h @@ -285,6 +285,7 @@ XEN_CPUFEATURE(FSRCS, 10*32+12) /*A Fast Short REP CMPSB/SCASB */ /* AMD-defined CPU features, CPUID level 0x80000021.eax, word 11 */ XEN_CPUFEATURE(LFENCE_DISPATCH, 11*32+ 2) /*A LFENCE always serializing */ +XEN_CPUFEATURE(NSCB, 11*32+ 6) /*A Null Selector Clears Base */ #endif /* XEN_CPUFEATURE */ -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Mon Sep 06 12:03:06 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Sep 2021 12:03:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.179711.326124 (Exim 4.92) (envelope-from ) id 1mNDL7-0004Ja-3Q; Mon, 06 Sep 2021 12:03:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 179711.326124; Mon, 06 Sep 2021 12:03:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNDL6-0004JT-Vx; Mon, 06 Sep 2021 12:03:04 +0000 Received: by outflank-mailman (input) for mailman id 179711; Mon, 06 Sep 2021 12:03:03 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNDL5-0004Im-Qs for xen-devel@lists.xenproject.org; Mon, 06 Sep 2021 12:03:03 +0000 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 624bf758-0f0a-11ec-b0a0-12813bfff9fa; Mon, 06 Sep 2021 12:03:02 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 624bf758-0f0a-11ec-b0a0-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1630929782; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=/rO6h35/M0MTFcSt9DOaPPseqG4z+McXNWqLbx32HoQ=; b=J6nhEADilOC8KYSU8QnOO4JAM+JjbszA3b4z2OdKJXLYECgqpwMu36d+ KEGg32OsacZXebRbbFzMpkkgLFjGIcmQfqK+wrVwQtUMXwXrSVI/gftLP IeyZ9lLRJaVpMLiz7Icu3klH9AmPnZEhej4iWjnshovLim/JhjmCSNMT6 I=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: 2yxqHK4UoAn9Tf3hwbH09y0L2oHBa7OhCWCfPCeDayrroAYgWSup1sXhjxISpYkXvgzfxWiQjd Ke24p72vg7DHS4UbxvqUFTVHPU7FGMcSa0xK7uG1Ix3k5T4xLLCTuQzH1oSIdiAC79+wmBHegC YZuYtF6U9NRE2T0Mev4Hc6yayUwOeXKwGfD34t73IptbcztfsESVz4eSO8ZT3gNhBTTX1MfXXI Toi6ePZYTZZvnRTf97k/0nT0RKQmXYMhmccNvmNoM+EHu22R7DNNFvmxTG2y1mlL3O7us3DEfb Al33XHISP2E3tmH7XBRq2XLM X-SBRS: 5.1 X-MesageID: 51690456 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:RtKG1qyMl9JJEBXjb1RrKrPwFL1zdoMgy1knxilNoRw8SKKlfq eV7Y0mPH7P+VAssR4b+exoVJPtfZqYz+8R3WBzB8bEYOCFghrKEGgK1+KLqFeMJ8S9zJ846U 4JSdkHNDSaNzlHZKjBjzVQa+xQouW6zA== X-IronPort-AV: E=Sophos;i="5.85,272,1624334400"; d="scan'208";a="51690456" From: Jane Malalane To: Xen-devel CC: Jane Malalane , Wei Liu , "Jan Beulich" , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Pu Wen , Andy Lutomirski Subject: [PATCH v1 2/2] x86/cpuid: Detect null segment behaviour on Zen2 CPUs Date: Mon, 6 Sep 2021 13:00:04 +0100 Message-ID: X-Mailer: git-send-email 2.11.0 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Zen2 CPUs actually have this behaviour, but the CPUID bit couldn't be introduced into Zen2 due to a lack of leaves. So, it was added in a new leaf in Zen3. Nonetheless, hypervisors can synthesize the CPUID bit in software. So, on Zen2 hardware, Xen probes for NSCB (NullSelectorClearsBit) and synthesizes the bit. Suggested-by: Andrew Cooper Signed-off-by: Jane Malalane --- CC: Wei Liu CC: Jan Beulich CC: Andrew Cooper CC: "Roger Pau Monné" CC: Pu Wen CC: Andy Lutomirski --- xen/arch/x86/cpu/amd.c | 18 ++++++++++++++++++ xen/arch/x86/cpu/cpu.h | 1 + xen/arch/x86/cpu/hygon.c | 5 +++++ xen/include/asm-x86/cpufeature.h | 1 + 4 files changed, 25 insertions(+) diff --git a/xen/arch/x86/cpu/amd.c b/xen/arch/x86/cpu/amd.c index 2260eef3aa..654f82e2cb 100644 --- a/xen/arch/x86/cpu/amd.c +++ b/xen/arch/x86/cpu/amd.c @@ -681,6 +681,19 @@ void amd_init_lfence(struct cpuinfo_x86 *c) c->x86_capability); } +void detect_zen2_null_seg_behaviour(void) +{ + uint64_t base; + + wrmsrl(MSR_FS_BASE, 1); + asm volatile ( "mov %0, %%fs" :: "rm" (0) ); + rdmsrl(MSR_FS_BASE, base); + + if (base == 0) + setup_force_cpu_cap(X86_FEATURE_NSCB); + +} + static void init_amd(struct cpuinfo_x86 *c) { u32 l, h; @@ -731,6 +744,11 @@ static void init_amd(struct cpuinfo_x86 *c) else /* Implicily "== 0x10 || >= 0x12" by being 64bit. */ amd_init_lfence(c); + /* Probe for NSCB on Zen2 CPUs when not virtualised */ + if (!cpu_has_hypervisor && !cpu_has_nscb && c == &boot_cpu_data && + c->x86 == 0x17 && c->x86_model >= 30 && c->x86_model <= 0x5f) + detect_zen2_null_seg_behaviour(); + /* * If the user has explicitly chosen to disable Memory Disambiguation * to mitigiate Speculative Store Bypass, poke the appropriate MSR. diff --git a/xen/arch/x86/cpu/cpu.h b/xen/arch/x86/cpu/cpu.h index 1ac3b2867a..0dd1b762ff 100644 --- a/xen/arch/x86/cpu/cpu.h +++ b/xen/arch/x86/cpu/cpu.h @@ -21,3 +21,4 @@ extern bool detect_extended_topology(struct cpuinfo_x86 *c); void early_init_amd(struct cpuinfo_x86 *c); void amd_log_freq(const struct cpuinfo_x86 *c); void amd_init_lfence(struct cpuinfo_x86 *c); +void detect_zen2_null_seg_behaviour(void); diff --git a/xen/arch/x86/cpu/hygon.c b/xen/arch/x86/cpu/hygon.c index 67e23c5df9..232edb0c4d 100644 --- a/xen/arch/x86/cpu/hygon.c +++ b/xen/arch/x86/cpu/hygon.c @@ -34,6 +34,11 @@ static void init_hygon(struct cpuinfo_x86 *c) amd_init_lfence(c); + /* Probe for NSCB on Zen2 CPUs when not virtualised */ + if (!cpu_has_hypervisor && !cpu_has_nscb && c == &boot_cpu_data && + c->x86 == 0x18 && c->x86_model >= 4) + detect_zen2_null_seg_behaviour(); + /* * If the user has explicitly chosen to disable Memory Disambiguation * to mitigiate Speculative Store Bypass, poke the appropriate MSR. diff --git a/xen/include/asm-x86/cpufeature.h b/xen/include/asm-x86/cpufeature.h index 5f6b83f71c..4faf9bff29 100644 --- a/xen/include/asm-x86/cpufeature.h +++ b/xen/include/asm-x86/cpufeature.h @@ -146,6 +146,7 @@ #define cpu_has_cpuid_faulting boot_cpu_has(X86_FEATURE_CPUID_FAULTING) #define cpu_has_aperfmperf boot_cpu_has(X86_FEATURE_APERFMPERF) #define cpu_has_lfence_dispatch boot_cpu_has(X86_FEATURE_LFENCE_DISPATCH) +#define cpu_has_nscb boot_cpu_has(X86_FEATURE_NSCB) #define cpu_has_xen_lbr boot_cpu_has(X86_FEATURE_XEN_LBR) #define cpu_has_xen_shstk boot_cpu_has(X86_FEATURE_XEN_SHSTK) -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Mon Sep 06 12:19:17 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Sep 2021 12:19:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.179748.326146 (Exim 4.92) (envelope-from ) id 1mNDah-0006YK-KW; Mon, 06 Sep 2021 12:19:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 179748.326146; Mon, 06 Sep 2021 12:19:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNDah-0006YD-HZ; Mon, 06 Sep 2021 12:19:11 +0000 Received: by outflank-mailman (input) for mailman id 179748; Mon, 06 Sep 2021 12:19:11 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNDah-0006Y3-5e; Mon, 06 Sep 2021 12:19:11 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNDag-0003TH-Vg; Mon, 06 Sep 2021 12:19:10 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNDag-0005hY-OP; Mon, 06 Sep 2021 12:19:10 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mNDag-0002TC-Nv; Mon, 06 Sep 2021 12:19:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=L36sy1FnWcaWdqr/FCKX8yMIgrwzydWVdnPZfgZJAco=; b=w1zGB0Sl+myEEwXjky2ciUiVbZ hY1oWDQxL7Jk5lXnrGRa4xP0zvsjFdUmDM/kjC1U9OqxYhc7mZ5m9py7wabmkdwB9lqYNo+1qveT7 ds71xzIdbg7XIMvKeTIBdNjrkYb0MmubY94uPjzzPKgLAAp4NXnlTbBpF01CBN0GYDg8=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 164857: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=edf8bc6d24c6f490c27de3144eee88f1ca40ce6a X-Osstest-Versions-That: ovmf=cae735f61328d64e2e8991036707b9e78c0f5f63 From: osstest service owner Date: Mon, 06 Sep 2021 12:19:10 +0000 flight 164857 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/164857/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 164674 build-amd64 6 xen-build fail REGR. vs. 164674 build-i386-xsm 6 xen-build fail REGR. vs. 164674 build-i386 6 xen-build fail REGR. vs. 164674 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf edf8bc6d24c6f490c27de3144eee88f1ca40ce6a baseline version: ovmf cae735f61328d64e2e8991036707b9e78c0f5f63 Last test of basis 164674 2021-08-31 02:56:52 Z 6 days Failing since 164686 2021-09-01 03:03:43 Z 5 days 65 attempts Testing same since 164806 2021-09-04 09:41:21 Z 2 days 39 attempts ------------------------------------------------------------ People who touched revisions under test: Anthony PERARD DunTan Gary Lin Hao A Wu Jim Fehlig Lin, Gary (HPS OE-Linux) Loo Tung Lun Loo, Tung Lun Mark Wilson Marvin H?user Michael Kubacki Rebecca Cran Wenxing Hou Wenyi Xie jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 302 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Sep 06 12:48:52 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Sep 2021 12:48:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.179791.326177 (Exim 4.92) (envelope-from ) id 1mNE3M-0002Bk-5V; Mon, 06 Sep 2021 12:48:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 179791.326177; Mon, 06 Sep 2021 12:48:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNE3M-0002Bd-1t; Mon, 06 Sep 2021 12:48:48 +0000 Received: by outflank-mailman (input) for mailman id 179791; Mon, 06 Sep 2021 12:48:47 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNE3L-0002BX-0N for xen-devel@lists.xenproject.org; Mon, 06 Sep 2021 12:48:47 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNE3J-0003xM-5w; Mon, 06 Sep 2021 12:48:45 +0000 Received: from 54-240-197-236.amazon.com ([54.240.197.236] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1mNE3I-00010W-VM; Mon, 06 Sep 2021 12:48:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=rwy7AxNwfFwlsMnF38Gr4XwnPq0UVzT9byovRhnT+jY=; b=A4i8Ezp016dum75EUVFwvLVBqg PmENjNsYxSmwhI+J7psgcyB+22jjdZxTK+XfTnlzDVua2bXpMZJEzlrbh4ivrHOPSdC1DdsvwqK0c 8zwubBuX5aXb5TPWIN6vaGwPz3PBOroCJ+JLByoH2oKDG0lFqo4uw1EVJ8+V3B/k/vLs=; Subject: Re: [PATCH] ns16550: MMIO r/o ranges are maintained at page granularity To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Ian Jackson , Stefano Stabellini , Wei Liu References: <05d055aa-2981-8c0f-33c6-62139859aeb2@suse.com> From: Julien Grall Message-ID: Date: Mon, 6 Sep 2021 13:48:42 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <05d055aa-2981-8c0f-33c6-62139859aeb2@suse.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Hi Jan, On 30/08/2021 14:05, Jan Beulich wrote: > Passing byte granular values will not have the intended effect. Address > the immediate issue, but I don't think what we do is actually > sufficient: At least some devices allow access to their registers via > either I/O ports or MMIO. In such aliasing cases we'd need to protect > the MMIO range even when we use I/O port accesses to drive the port. > > Note that this way we may write-protect MMIO ranges of unrelated devices > as well. To deal with this, faults resulting from this would need > handling, to emulate the accesses outside of the protected range. (An > alternative would be to relocate the BAR, but I'm afraid this might end > up even more challenging.) > > Fixes: c9f8e0aee507 ("ns16550: Add support for UART present in Broadcom TruManage capable NetXtreme chips") > Signed-off-by: Jan Beulich Reviewed-by: Julien Grall Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Sep 06 12:58:38 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Sep 2021 12:58:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.179807.326192 (Exim 4.92) (envelope-from ) id 1mNECo-0003v1-5V; Mon, 06 Sep 2021 12:58:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 179807.326192; Mon, 06 Sep 2021 12:58:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNECo-0003uu-2F; Mon, 06 Sep 2021 12:58:34 +0000 Received: by outflank-mailman (input) for mailman id 179807; Mon, 06 Sep 2021 12:58:32 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNECm-0003uo-Nq for xen-devel@lists.xenproject.org; Mon, 06 Sep 2021 12:58:32 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 1394b0de-52ea-462d-b2b3-68937a13ce89; Mon, 06 Sep 2021 12:58:31 +0000 (UTC) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01lp2056.outbound.protection.outlook.com [104.47.2.56]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-30-GtL87o-fNGGo4nSSiBoaVQ-1; Mon, 06 Sep 2021 14:58:29 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR04MB5742.eurprd04.prod.outlook.com (2603:10a6:803:e5::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.21; Mon, 6 Sep 2021 12:58:27 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4478.025; Mon, 6 Sep 2021 12:58:27 +0000 Received: from [10.156.60.236] (37.24.206.209) by AM8P191CA0002.EURP191.PROD.OUTLOOK.COM (2603:10a6:20b:21a::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Mon, 6 Sep 2021 12:58:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1394b0de-52ea-462d-b2b3-68937a13ce89 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1630933110; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=hK3ZJrK7cB1H1je6taAi+GVM+bdxDIHytD92JlsUDMg=; b=Z95Gn8QSa9CEPVo3/8jqxEwwYaQzrCJJbuLSrOd5uRtGO/2RlzAmybNPQrmVGymbVFCyju Z8ZLIuJ5cPtOGJ4HD3aEkW4C+iGyAk7B4/1nWveqlJS5bN2T4Pvz+IxINqI1DiIMUr3aVk H1atRdaf3JsG1+A0r9f+M8pJ+/dpn5Y= X-MC-Unique: GtL87o-fNGGo4nSSiBoaVQ-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XRV38NCOiS6jDyL4h1pGek9xAztpaUckuOPeRr0/1hGFEgqKGBEY8BG7aaLw7ngQZS1cg/UgTwrLcH1L8KQTlFKm+e+Rc2YAcKeoHZRKnJq5o1rvYZqm0yP40VlMmloJW2Gv/vOoBt4KAxEc7enxBu8g/t/PphBNUxylQxwn3ZEhPhgzdXHWulx/SoyQPUs46Kagu2fX0JWkonykNBlPpIp8HcWQyOSe+O2BC2GC8MmX1Pi+09LV2sZCaOWqFAlGEepSGsConMUnJvOVFEuHJyhw5M2h6cD0HXSTeSWLC/CH1y5yuj/0faLi8UEvESIgjV6ExTo6PQOwxEcai2Uz2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=hK3ZJrK7cB1H1je6taAi+GVM+bdxDIHytD92JlsUDMg=; b=KNMe2wfs7S1Ji68YWSY5fjhqcgx3LbrHmr7TTGmfmCckBac2bR9wCeSVly1JNn/4B9td+3VQ8pB4rhw/Pnb0JXjeQE5aVLYtbqGRiraYnqZxIoKnf3tMP/FoYA0MzG/wKT8j3nzcdqC2/xqDDlEOBGO6DKSfBsvQaHYsgTdcHx9LHrvwMiCPEbtvNXGlR09NWC4HCT6fl7kpA9stkTzdp5VtrBAy0XjoSIabIIPnm4gG7OgNj/niSNkP30YvMdWYwPpE6aAR+kUK4oxhbew4DzJpaUe5DcxhNSxO7qC/vdcxT2isjAa5RWP1WT72OD3o+QpBF4xOTMg9qcQJif/2/A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: citrix.com; dkim=none (message not signed) header.d=none;citrix.com; dmarc=none action=none header.from=suse.com; To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= From: Jan Beulich Subject: [PATCH 0/5] x86/mwait-idle: updates from Linux Message-ID: Date: Mon, 6 Sep 2021 14:58:11 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM8P191CA0002.EURP191.PROD.OUTLOOK.COM (2603:10a6:20b:21a::7) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: bbc0d966-9c8d-4ca9-c26e-08d97135fc71 X-MS-TrafficTypeDiagnostic: VI1PR04MB5742: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7219; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: HdR13lwz7wB4w/KpVQmi6z17nnkObvE0lCxl9+lm4ZC+5dip+3B4NB1j2P2ItzPeVF3dhH3Rzz3Bz+wQw+TJxZFk7Xcokuc5fCH+PkgZaIT+rc7xywc96So+gCbMtF4YpR2gTT6DUvl63b6slzA0cC1YEfHovsnf6//as4bB3VRnUiJ9d1eyPzDBpSZ+aRPShSS2zRYHfh0cP/VYeeUMKKq21V+dFnJ/W2/GyjS8qiGLY/vfCaJ/lg1K00sfZhMq9/7IB3ruMpL8sWbZ+bbUN7qMAk2+KxxxlR1CiQY9C8PuWi83MmkaGB1f8U1iaLoFIWfKSc9q33cpdj5MFM8YyrmEhkadO8uzgUHQhn1KlcIMmEZk5UB5Ia9Jd37jGL382cNC1JqQj1+6DztJf1Ru2Azsi3I3Go8YPmOps4EKfDIu7bjFZMgnu+o2+E7VPZuGyueRe9djedIQ9pL3mrwnzahm680DRbbS+S7NTsxYLz4VHvSEbnNFEU1D09PK2frSraABEJmFLJZGqTd3o6FhPjPV8oSCvAscOssgpZiqoBHT7f82fOSujUScI8VNsyD5Akq1RIB2msjk8dOvQrXRHkjdxda4Txj04bb9r2AKr4U0VoCzFW6kn53Iy4lHPtzkASO5qD9h0/R1DrUo6NIwo1Gf1/mNYX+uDiubISEoVVCSHj6/N3OTxHYzoShfuOEk5FlZwCs+y/FLKQu+gpUD5xoUz6a4RrYe9SLJY3Ao1Ik= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(136003)(39860400002)(346002)(396003)(366004)(376002)(31686004)(186003)(36756003)(478600001)(16576012)(8676002)(316002)(66556008)(26005)(86362001)(54906003)(6486002)(31696002)(6916009)(2616005)(5660300002)(956004)(38100700002)(15650500001)(4744005)(66476007)(2906002)(8936002)(83380400001)(66946007)(4326008)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RUZobEt3Mi8xSkpwcTM3aE5aazMxTW9PbU5tcFYyeUFIS2ZQSStpOGw0SE90?= =?utf-8?B?RTFubFl5UlpFRjIxTFBxZjRMeXJOUlBTYTJIb0tUM3htaDR0M3dMa3pBdy9O?= =?utf-8?B?cDFqdk03OWFBRC9WbGpyZ05MWUhJbm44aHgyVEtybGN2a0hiV0V1anBFa241?= =?utf-8?B?dDRuVTN5VGk0UzRubXVVZ2hrY1I4T2pRT1VRNDNIdDhLeW5hQTcvalRGdk9y?= =?utf-8?B?N00xV1VhRmR1akJ6R0dLbWk3MlRRZ1BRclVTTkZ1K1VWdW93K3dGc1VCUU9J?= =?utf-8?B?VDc0NFExajZIcjZlRWx1cno1U0hOYjc0bHJtRzZ0YTVDMSsxQXFIRXIyTGdy?= =?utf-8?B?RkthS3NvUzA2Z3hyUzkwWm9hODVjejFidFZHUzVtbXVER05FaWp5RitubDVy?= =?utf-8?B?N1lHTERKMnBSTDgvOHU4bGZ6bWk1ZCtmZHlXUmZEaTZDM1J1N3R5dHZqMkpW?= =?utf-8?B?Q1BPNTQ5NDRMcWg2Z21rTGlsSVJUZDBOT1NiUmdBNGxCR3gwS1FWdm5jSTBr?= =?utf-8?B?NHZSWkx2NCtPYXNDRUtpbEQ4MXBTQ0NKRlRkTlFmMHc2UlJzNXF4SWE1NXR2?= =?utf-8?B?QnQwMmFqK3dsak5Nc3ZyaEpDRXp4R2l3eFg0cFhJN3NnZjNDZ09RelZuWE5j?= =?utf-8?B?Uzl5dlRqb3Z3SFdwL201M0duVzdNMGRNcjdqdnFEM0YvdUpMOWFJdEUrNXgz?= =?utf-8?B?R2o0MUZmRnB1a2NKMVU1cGg2a2xlSFl1SldxdUVZNm92ckt1dU54ZE44SG1y?= =?utf-8?B?NERPWExOeEdTNlprbkN3YW4wUm1VSHhoYTc1TkxBZnpHb05PTUswNmNvd0NL?= =?utf-8?B?UnM2WjdwbFdMVFVwRWFQbThUR0FOZWVkS3N0MWpNS29XMk5CcnRSUmEzSmcr?= =?utf-8?B?eWVIN2tQdW54UUlVV1IxajdqOTRFUjQ5R2VlbU1DYUJnSVorb3MyRUVBODhD?= =?utf-8?B?LzVua0FKdXJnNm1RdmRvdnl0MTRyQUJ3bjVxeHlBM29IcmJrZUkybjMyUFlL?= =?utf-8?B?R3ZDUHRuOENBRkNoblVYTXF4V1hHRWRGZHR2d2U3d1FLVFdrbWNwa3RTZmp2?= =?utf-8?B?cVB3YnpGazhrL21ma2N2TWVQeDg1cEVNWlcxQ3ZkS2ltY00zbnBneHQwWGdE?= =?utf-8?B?UE5MVkxPM2Rpdm96NUV4ajlhcDh1Z05sY2JlZXl2VWJGUVdCM3RhUG9wQmJx?= =?utf-8?B?cmRRdWxEWngyV0tpQk5ZcVdySDZFQ1B5S3ZqdFYwMWhVbmJLNElvQ2QzSzI1?= =?utf-8?B?YUtsWEJ3cjV2NU12L0doeVhGV2R3Uk94eFE3NE5wREplTUhwMzVxNktqa3JY?= =?utf-8?B?ejJ0RGM1a2kxdjBWTmhVUDMvUEhIanYzNWJTU2pOazVMUjlTWVVLeDVmRGxl?= =?utf-8?B?K0E3bEtOMjNPNEl5ZHFYL3Myc1ZOOS9La2tSUktPMDRzT3Ava29OT0NKTUdo?= =?utf-8?B?bjladVp6N1ZTaDFpRkFQaUs2bktNajB4MXRRWCtDbXRpV0F6QTRvV2JsZGtw?= =?utf-8?B?N0xremMxRjhlZHpkeThhb2loZFZxekJualZ0UHJ1U3NjdEZrNE1ydGhXYVBo?= =?utf-8?B?MjVROSt3RktvOFNiS3Fqb2JIMzBuSS82Q1hyanFCalE4Ujg5TCsrVnlkQURK?= =?utf-8?B?VktpVWM0aVBaNWVmNEFkSkdudXorM1lrU2QwUDc0aDNFbkFndG9TVGY0RU5p?= =?utf-8?B?TWcxK1ZzdmE0UkNVbnQ0SFhkVkNiVnpSN0VqL0NWK0Nxbmh2bnVLMEFNNWNu?= =?utf-8?Q?fVhroLwt4cHSoJkgY3uGcQwafYSscrXtZuwAr0m?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: bbc0d966-9c8d-4ca9-c26e-08d97135fc71 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2021 12:58:25.2466 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 8rsOOt/AiOE88BWUcPA+vKPIyaKTvuvfAL/GSuEKbiE4WNGqfOi3PR3efc1o/fuOUAs8P9vmMOIqmvN7gxwcCg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5742 Before the code freeze I thought I'd check the original driver again, and indeed there were a few changes we want to inherit. 1: mention assumption that WBINVD is not needed 2: add SnowRidge C-state table 3: update ICX C6 data 4: add Icelake-D support 5: adjust the SKX C6 parameters if PC6 is disabled Jan From xen-devel-bounces@lists.xenproject.org Mon Sep 06 12:59:51 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Sep 2021 12:59:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.179814.326203 (Exim 4.92) (envelope-from ) id 1mNEE2-0004ZU-Jm; Mon, 06 Sep 2021 12:59:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 179814.326203; Mon, 06 Sep 2021 12:59:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNEE2-0004ZN-Gi; Mon, 06 Sep 2021 12:59:50 +0000 Received: by outflank-mailman (input) for mailman id 179814; Mon, 06 Sep 2021 12:59:49 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNEE1-0004ZD-TG; Mon, 06 Sep 2021 12:59:49 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNEE1-00048f-Pf; Mon, 06 Sep 2021 12:59:49 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNEE1-0007Ep-FZ; Mon, 06 Sep 2021 12:59:49 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mNEE1-00048p-F8; Mon, 06 Sep 2021 12:59:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=6J93bbgmocMXPLFDfWfU4Rp3VcdHlwIwtC0eij1xjH0=; b=VaCrmG+m8rCX7h6PtvHAjgWbqH bEHbvSn2gqDXjgsYtCFCMcIowdXyqcr3P3Wo/lWu2vyCTKBJcTyNIWaXFBYTioUUh9eK093DI3EQF Bx2VKc0WKFWzSHDY6i+S4gtzsLu0tOGqI2vAp1wPXXIIqY7C9o0pKYwNFp84j39CkVMg=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 164858: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=edf8bc6d24c6f490c27de3144eee88f1ca40ce6a X-Osstest-Versions-That: ovmf=cae735f61328d64e2e8991036707b9e78c0f5f63 From: osstest service owner Date: Mon, 06 Sep 2021 12:59:49 +0000 flight 164858 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/164858/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 164674 build-amd64 6 xen-build fail REGR. vs. 164674 build-i386-xsm 6 xen-build fail REGR. vs. 164674 build-i386 6 xen-build fail REGR. vs. 164674 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf edf8bc6d24c6f490c27de3144eee88f1ca40ce6a baseline version: ovmf cae735f61328d64e2e8991036707b9e78c0f5f63 Last test of basis 164674 2021-08-31 02:56:52 Z 6 days Failing since 164686 2021-09-01 03:03:43 Z 5 days 66 attempts Testing same since 164806 2021-09-04 09:41:21 Z 2 days 40 attempts ------------------------------------------------------------ People who touched revisions under test: Anthony PERARD DunTan Gary Lin Hao A Wu Jim Fehlig Lin, Gary (HPS OE-Linux) Loo Tung Lun Loo, Tung Lun Mark Wilson Marvin H?user Michael Kubacki Rebecca Cran Wenxing Hou Wenyi Xie jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 302 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Sep 06 12:59:54 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Sep 2021 12:59:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.179816.326217 (Exim 4.92) (envelope-from ) id 1mNEE5-0004rA-TO; Mon, 06 Sep 2021 12:59:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 179816.326217; Mon, 06 Sep 2021 12:59:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNEE5-0004r3-PV; Mon, 06 Sep 2021 12:59:53 +0000 Received: by outflank-mailman (input) for mailman id 179816; Mon, 06 Sep 2021 12:59:52 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNEE4-0004qY-Gq for xen-devel@lists.xenproject.org; Mon, 06 Sep 2021 12:59:52 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 52036839-0f12-11ec-b0a4-12813bfff9fa; Mon, 06 Sep 2021 12:59:51 +0000 (UTC) Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-ve1eur02lp2050.outbound.protection.outlook.com [104.47.6.50]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-9-xAUjZGraMhuknGFuXbTleA-1; Mon, 06 Sep 2021 14:59:49 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR0402MB3533.eurprd04.prod.outlook.com (2603:10a6:803:b::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.25; Mon, 6 Sep 2021 12:59:47 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4478.025; Mon, 6 Sep 2021 12:59:47 +0000 Received: from [10.156.60.236] (37.24.206.209) by PR0P264CA0288.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:1::36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Mon, 6 Sep 2021 12:59:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 52036839-0f12-11ec-b0a4-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1630933190; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lYxRIiU55Up939f84d4QmJrnjJ7T0dm9h+/746Rq8MI=; b=TAsfWiHE7FZWYTewzBgpb+QG9gVW3kWFnzbDI6TYQZ4q61WIEVh0JLmWYfqCz7kJjy6nvA 1qLtePpTs+Wnj9fILoNt7kw9GlELIxxNVHIGvBKGLTJsNhYP47HtI9sp3/JMwOheLQWum8 /uC25cCoklG6xZH6UXkaBi6w6stIP9I= X-MC-Unique: xAUjZGraMhuknGFuXbTleA-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZLjHtcBlvctdvTt75iYoXLbCptmC1uoUlrqNiQmQOWmN5NMRBe+ubNquiHZn7Wq5b/C/z67M+RdwyNcjKJKh02ATQmXYOrLkVubin4yYYHIRfRSzSvkoVYatGqs0as1BQP0L+Y97lHeLfoZHK94JsMRT8IrlWfP3wQ2jgihURSI0tk14jvyx/GZ9p78FXtC4g63uV4MhEyoDHahdiEqGvXATD+T+FhreW3qXYUw3+ZaajRM/IfMyzUTDycSGZXgW88Gb2CFkJbNWnzUs08XmUmhZVZitKoQ55psDDzosUvTaLRNcIc80BeFRWQroEalriCgOHyeLqx2fVWiCJZc//Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=lYxRIiU55Up939f84d4QmJrnjJ7T0dm9h+/746Rq8MI=; b=PF+1ThupuWkV23rBEb/AVG9YKXiiGvWzWk8N0RVdNnbRiY8A9Y1xfd0Ys2B6n9B8bIi5+yrhKDP5LlyHid8BZcSECQY5ToTb05h/ieblw7n0uV7xrluquc6TLnGeefGIMyWcvJLD4YPtwWKMfERKsEhykRZ0NCb1HRs3UY+d0sH4dsrTgiBMt7bSutsb4uqPk4cbmG9rhfWQ7CvulLnIJqeo1EOA1JeVxKl+J+t8wUXxcf0yL4fJPYZV6zu2vnAfKaEYcXMbeglndhz4/v5FSKxibFcor1TaHlfRrY1cAtnjJQHwHkvQUhi+InvBm1GMzwe/wH+JNRYImUUulv2h9A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: citrix.com; dkim=none (message not signed) header.d=none;citrix.com; dmarc=none action=none header.from=suse.com; Subject: [PATCH 1/5] x86/mwait-idle: mention assumption that WBINVD is not needed From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: Message-ID: <0ebb0de3-2500-a9a2-8128-64b9d4a27cb7@suse.com> Date: Mon, 6 Sep 2021 14:59:46 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PR0P264CA0288.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:1::36) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7171f000-7582-4922-d127-08d97136349e X-MS-TrafficTypeDiagnostic: VI1PR0402MB3533: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:3044; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wklRinhSRVpDYvJdmegP10VvhuZJ/azd6SK3EM0JRoO+jeONCwEo0dDrPHZIuQDrxm31/i3doby2IO5X3Wz68ierdfXcSEQM2b1PfiWoOmdmpUqO+6Oi03hx01V0Eo6076ekcEruFFs4nxaAbfG5zttp/Y/N4OJSmiY7ON7Z8UlRomzcDiWYsd4cO02iRWeIb0oJEQiAKz3YSsgpkDBoABzVH2N6/OzjzKNjFLnhVPvddGwkOn/Dd8tij4ivx3BaLAmWM+UVlCVgSONrteD0Xertv70pBHzmFKTjmKlyilsJvsnbL1hswMy4m/7yzCahsRflgR0HKzcUii8TplJ501Nwe4EIDsQfYy2tsPWfJZDjEYQKQvvEZBstvNfexOmA1z6O8oqTOPZegnxl2mIkOQNz4B/LU6Q5CvnMfanNE8MmrDOmbejoWYX/dA9YCrjxaKZKjeuUDhkZPS+PTlOs6jRKke0xOy4FkA+c74HRnfIOVYl9RZkoe9SeMhT8ftCWHnYgMcTBbhV8pMtYhtXg8GMdw/5oNRmk1yUFURpWsPN6wL6YyPf9JQ6lqjaS45Skf4pCWP6emhg5ORp4CcytYlwwIF0wfU3w4cmADcR5BKnI8oLy4p0uuLLtKAtK4YIIAzzRzFjdHiGwTYy2ukJpPTBFn9qjiBMS1lyB4S4YK9JRh8pSndGvuwK6PL+fHSpVLmUh/g4RWA5QTvEAJqlS6Bt8ORLpgHHUMVQDcWzSPwc/sudAHLc8DanABn8qZWic X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(136003)(346002)(396003)(39860400002)(376002)(16576012)(54906003)(478600001)(316002)(6916009)(2906002)(31696002)(66476007)(8676002)(186003)(8936002)(26005)(5660300002)(4326008)(6486002)(956004)(31686004)(66946007)(38100700002)(36756003)(86362001)(2616005)(83380400001)(66556008)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WjdKRVdDUHVmT1dlNmlJcW9TekoyUk14eXJOeU1iY1YrK3ZPd3FRUU5KeFRF?= =?utf-8?B?YlpubWpLMWtuaDM3dm1ndVJpVXFQSnRUUzArYUJKVHpiaGRrZkJuM2FyRWhB?= =?utf-8?B?amI3bm16QkYxRmRIY2liVkJHRE5hRkVGNWpuQ3U2SWpLajBQWEJaTG5QRW5M?= =?utf-8?B?TVZZSUxFSU8zcXgzZmJnZU56SWtWaWhiU0hQd0wxZjIycGYvZUZ4ei9zK0FE?= =?utf-8?B?aGRmVVdjSjZQMzY3VGIydFhqTFJmUzc4UDFMVDlIQXN1aEhpRTkrVU00MTUx?= =?utf-8?B?SkxvZ3RtR2Y3Y2FtTTNYYm1FbjFmTklhQnhETC9TdkxIV2xBMSsxenRkWUtz?= =?utf-8?B?ZVlzdVdEQlE4Q2t4clhDYmVsemRLYzZjSFhhYm1VeWx2S0x6TnB0RGg2eUtH?= =?utf-8?B?S1RVRVVPSVA0bVE5NTExTzJ5bWpYUVpzNHhIMHZNVnBCU0ZNS2ppUDZySnkx?= =?utf-8?B?N0dZUFVpSGlNYlMwSEI4QWVzek9lU3Z4OUl1UTd1ckJvRTJNR09PUmtheVdW?= =?utf-8?B?OExReC9nVHliVVArNVNQUVI5dDVRamYzbGd3NXhTRFBNZU1qdy9rZzVTUlFq?= =?utf-8?B?VG9BUGFPeG9BQitHWUtMV3ZjbkF6NHF3K3MydnVOVngzTkZNVVZoNG1jQkxC?= =?utf-8?B?aEFyUUJuY3lEV2oyb1hxTWNxUU95V0YyN2dVRHRTZWh3WE1OOHl0R1dNbkxX?= =?utf-8?B?R29qNWhSTjBBZDQxQWhjSW5kYkhpZXlPY1kyM1FmR2NEeW9SMHpQMi9VSllx?= =?utf-8?B?QXRSWUlBTk52c0JKVDB2S3YxT0VwMkNYOVIzTllZWGtPZmI3VThpMEtabkcr?= =?utf-8?B?ekhjMUJhT1N3OENRRmttcDJFRlZYL0o4bVA1ZVlQVUtyZFhPdGNBcTZZNjFK?= =?utf-8?B?RTN4d29NbDNob1ZqZXBoaE1HR1ZyOUhrMHM0QUNERHhTZ2VidmVqVkt0RUY5?= =?utf-8?B?Y1pCNEsvUUR1RW1mVGFscm5ockNYZVZFQU5QNzB1dCtFWnlXeWR3VDVUWTBB?= =?utf-8?B?SlZjVjRlUEU3bDNnRllnOFRCL0VUUEFnV3N6M1pVNGREa2IyYmF6UzdBeGRv?= =?utf-8?B?Wk5OWGh3QXUyV3Jzb0pIdDhlUDdQaXVSb2Zra1NMbVh1LzNheVZrNnIvaitm?= =?utf-8?B?ajZqcmZOYmNLVzhPb3h0d2M4UkpiOEpxL1VzTTMzRVMzNGVydFBwUEJmam5V?= =?utf-8?B?bGQyWlpGb0VVVTJPd2xLUENPVFcrYStIbUQyN2V0bnVxbXZUbXk5Yko5SXNP?= =?utf-8?B?NXhFejNackpNRUtYQW5HSzNjS2NNRUN0WlRpRERwVXlUUTU5VDdGQ1plYXB0?= =?utf-8?B?U3NVTW9CWGp2b2s0ajdMeTJmRjQ0b3lBZDhzc0Jxc0dzYU12VGhNbCtoOXBT?= =?utf-8?B?dE1GK2Rhb0FiQUJEVHh5TEM1NzJCMUxZWjJSTDl2MDgxdW5ZaU5mMTJiYSty?= =?utf-8?B?ak1Wc2lSU21qSEdDYjZ1bkkxUlM1eHphVHRtbU92RkFtSHFlcHp6ZnV0SVJB?= =?utf-8?B?c2xBQlNQM042aDkrNHU5UzBIdEdtZzljcWFUeDFNVnZaSWFCbG9MeTdhOTU3?= =?utf-8?B?TUszZkFWdmZVQ1RBMmhDcDFETVhvV3RYWUZUT3pHZWtWVTJ3U1dmNHE0dVl4?= =?utf-8?B?Y1hkaTRmNFVNNDhyMm9VSHpUNUJqRWxPTFZYczR2WHpkenRXdk5XRjhmOUtM?= =?utf-8?B?U1p6QWkxL0ErSXZyNkUraFlJUmFQTnY4anczMkVjVUxkUU9MZVQ5TUU1Kzkv?= =?utf-8?Q?PI9XIL1uEwWqncUrWy/aSwU36jrDd1X1UsZNY4Z?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7171f000-7582-4922-d127-08d97136349e X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2021 12:59:47.5361 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: HqSobVfJ3c2p3fXDjWInCq+5ruoGY8x9/vU4bs9CSCmzW2E0UsiD53GkKIhd4o6HQl1fd2aqdwkm16KZmow+PQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3533 From: Alexander Monakov Intel SDM does not explicitly say that entering a C-state via MWAIT will implicitly flush CPU caches as appropriate for that C-state. However, documentation for individual Intel CPU generations does mention this behavior. Since intel_idle binds to any Intel CPU with MWAIT, list this assumption of MWAIT behavior. In passing, reword opening comment to make it clear that the driver can load on any old and future Intel CPU with MWAIT. Signed-off-by: Alexander Monakov Signed-off-by: Rafael J. Wysocki [Linux commit: 8bb2e2a887afdf8a39e68fa0dccf82a168aae655] Dropped "reword opending comment" part - this doesn't apply to our code: First thing mwait_idle_probe() does is call x86_match_cpu(); we do not have a 2nd such call looking for just MWAIT (in order to the use _CST data directly, which we can't get our hands at _CST at this point yet). Signed-off-by: Jan Beulich --- a/xen/arch/x86/cpu/mwait-idle.c +++ b/xen/arch/x86/cpu/mwait-idle.c @@ -31,6 +31,10 @@ * * Chipset BM_STS (bus master status) bit is a NOP * for preventing entry into deep C-states + * + * CPU will flush caches as needed when entering a C-state via MWAIT + * (in contrast to entering ACPI C3, in which case the WBINVD + * instruction needs to be executed to flush the caches) */ /* From xen-devel-bounces@lists.xenproject.org Mon Sep 06 13:00:54 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Sep 2021 13:00:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.179827.326228 (Exim 4.92) (envelope-from ) id 1mNEF3-0006Tj-7k; Mon, 06 Sep 2021 13:00:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 179827.326228; Mon, 06 Sep 2021 13:00:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNEF3-0006Tc-4R; Mon, 06 Sep 2021 13:00:53 +0000 Received: by outflank-mailman (input) for mailman id 179827; Mon, 06 Sep 2021 13:00:52 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNEF2-0006TU-AQ for xen-devel@lists.xenproject.org; Mon, 06 Sep 2021 13:00:52 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id d7f79551-92a2-43cf-8f1d-71134edeb319; Mon, 06 Sep 2021 13:00:51 +0000 (UTC) Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-he1eur02lp2058.outbound.protection.outlook.com [104.47.5.58]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-6-9Bx13LP0PrKwqSeciJeBJQ-2; Mon, 06 Sep 2021 15:00:49 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR04MB4608.eurprd04.prod.outlook.com (2603:10a6:803:72::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.21; Mon, 6 Sep 2021 13:00:47 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4478.025; Mon, 6 Sep 2021 13:00:47 +0000 Received: from [10.156.60.236] (37.24.206.209) by AM0PR02CA0185.eurprd02.prod.outlook.com (2603:10a6:20b:28e::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Mon, 6 Sep 2021 13:00:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d7f79551-92a2-43cf-8f1d-71134edeb319 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1630933250; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dbwG033IYOy80/NWLE0KFiBS2xDM7Ke8HGRpzdh07P8=; b=XgWq3RIqJvoN4psFBGnchKCfQbvC/8Vta8PECiyF1/8RoOfHmaZxWexuxyco2G0CRhjoNd VBmbaz8UpiaZjE8WQIL/NX8NwjqiNsHv2aB/sHDnPoABDalEWCh83pXp5wjVfNE4lyv8aO sOOhlD0Jmf8bXIJNvUdk1iCztpU4CWU= X-MC-Unique: 9Bx13LP0PrKwqSeciJeBJQ-2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iFaY0g6K971tMrHClPEJn3tNCVWy2LI8T2tjRGy6BHgpPB4FB4MKe7Wy6mZI4qifrcH3+S/CnUsN7DuggklVQ+yJCElaEH/lPkKFMxBdIz0Chnu+NtHRVuxhZAGQY2o3JMOvzQc5tdQ9dmJ5RVAgICtYP1UF7nJ1qeNmpJ2PNSXAkJnagNIQkGu8ZyMc8EGwoYIzunBVlJN5cz5lilnI9x8c3pOc9xJLUp9lFJNJ7QAMEo9IWOGgB603EMwqsIFw7DQhgzbcaq7aID9DntCXxF3+bSFWHGMnbK+t0EgMDGl/pIARbRsJVzfo+SwiQClGwjxnZFqwWhHzbKNFmVvm1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=dbwG033IYOy80/NWLE0KFiBS2xDM7Ke8HGRpzdh07P8=; b=QVkNP6lP5NN+6SQIXjVDOKxQpBEn9ySo6Qa4+Gj49AEMyj8RQolBr+S/Oz5m5eLffTMqpjkIPtzOePT/YiJVNltyKwh76oZbFPHrkkQ3Bl2oTVnt4g1+vrCNGleu6ibRZvSJnypAbtL+hOSqYFAMcKBsb5Xd67ukHETiDC8VfyLmwc/GAR/zbKjYHuZHiwOFQufO0w45g8vVI0HWFdoPOyhGaeKaBAsJqpx4ThuoYeiYiLVlMQJsub2qB9+H2Obk0fxFOb7HFAdWg+LC9oD9AUGbK3vtoqVCFnhYfAAPCMlN0aRNJofdosJ5kIhKC9fsLxPEUAJK8fRxcOUp4tco+Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: citrix.com; dkim=none (message not signed) header.d=none;citrix.com; dmarc=none action=none header.from=suse.com; Subject: [PATCH 2/5] x86/mwait-idle: add SnowRidge C-state table From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: Message-ID: Date: Mon, 6 Sep 2021 15:00:46 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM0PR02CA0185.eurprd02.prod.outlook.com (2603:10a6:20b:28e::22) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1a5413c7-79c1-4ce5-2931-08d97136587e X-MS-TrafficTypeDiagnostic: VI1PR04MB4608: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2399; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: UvanncNRt3CVO5T4rfui0iaRvjPOLgPVLYFajDhaE8raOtDWDiFid9eL5OCMnTAPwJPTFEkJ/fVkSd01EZGhsIKu39kgI42aIeeVe6m0Mau29B8Puqd6/JI5TXi3RaLs4T/R2Qw6sGXbWGM5F7qAyBTwh8kO7dgJ0610WFWpo2R+xBtdbY5luhgrAlSsF5dNxOTXJel+XR4vG0K2sKSDvZkOQd/7AroTBsLbCs9VMI1oRBfRWvoFNPST4Q/BnxuUnrPpAip7c/u4CpChdzKSqm3WDkw4G8z7SL+vtRF5bGBP1kIKmiED1/QLuKkEDtCsa0SvdkpzdqHdHTzf/AbqrWlJZjg4XTHp4x/9wU4sUEwLc9UOxYaBhG+1ltjPmoFpA9dOa6lbePFtpx92XFnRf3OHeCMxVFFFuaLMiyhklj7CC/AAhkr6k4FNLAywSSsI0EYz79kscZMb9BgJJ0PksmYTb7EqPk3S0kQyE/brt5HTWFON1YPbOFG9a5NiuHKYZCrqwrsGeKF50r5OLlLxIakCUQcT9+2RgqLmeeb2YCqJ1qHLz9l8Cv+bnmf/ZxOnN7DJwSCCx92GRYOb6rj/KYOcE+8jlsOLCHWLQcIkzBy3XdBx8tXK4dSVMX6Lwg4sxDajZzPK5sysUYN2U52XKwrysxejAkablqoVE8eMc3QPXLt3frMEmvjdkI8LcXxVJrt/aegDYidFiC9A2GPfoP4AYn33NolW8hMXKIrN9lk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(376002)(346002)(366004)(396003)(136003)(39860400002)(66476007)(66946007)(54906003)(478600001)(5660300002)(2616005)(6486002)(16576012)(8936002)(2906002)(31686004)(8676002)(316002)(956004)(4326008)(26005)(6916009)(86362001)(186003)(31696002)(38100700002)(36756003)(66556008)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NGdQazlYVVRFQ2FvcnVYYVRPQndnMUVUelRUSWNFaFdmRWxrcW8vSzJSWGNt?= =?utf-8?B?akdHTXp6bzU5c2lQTjdqelZkcDZrSW4wY1NsRXpwcEpxZlBnTGlTZTVTNWZK?= =?utf-8?B?KzJjb1k5aHY4QWFnOWJGWWhPSXM3THN6b0k5YmRRa0xJUUpqc1R0dWg1VVNl?= =?utf-8?B?cjJpTXZ6cTkzNFhBdlA0NHUyM1FraHJSZ2VabjMvZFZ6azZRK0tybnh1NUVp?= =?utf-8?B?ZU9saE44WkJHclJOQVAwbFNWRjBKb24xK3puMTVHWGJya2xqaVkvQWVDMWJy?= =?utf-8?B?U0k5VXZNNllVUEdmQWJqYWxTUEtmTEVuWlNtSHBIZFVyTCtINEQ2bWJEVFYx?= =?utf-8?B?Q1IwYWF4bkZsbVUxSW13TlpFNEs4NzJKT3Q3OERhaktueU9VM0psYWZLQksx?= =?utf-8?B?VDZiUVo5b0l1TG9UWXhTTmZjYzM0UzhUV0dlNXA3cStJZjlXa21WTHhZUkls?= =?utf-8?B?aFBwU1ZJejRaa05HM014VVMxd3NQbGhpUVd3VHZjS0FnZ2dSVnJCOXVpYXNJ?= =?utf-8?B?aVBKMVNCL055NzRlSVhuQU1zZFpYVFBORDlUUkNWMW03VE9XNFFQdGRURU5C?= =?utf-8?B?SmV4V3VjdWVDM2o1MUg4MVpiVjRNbEYzTmN3UnJScTVTYTQvSDl1aHIvN3Q5?= =?utf-8?B?Vng3d241UDlUU0U2enFLRGlITFdET3hVblNERU9OaVpNSFd1NnlWUEViVzFL?= =?utf-8?B?RGo4ZEdlbndWeVBKbm9jZ1UwaTBnd1U0R2FIM3ljYktOYXNaN3FPR0ZPd0h4?= =?utf-8?B?ZnVJdmVROEFNMzd1TWl3OFV1dGFYaityRDFVcDZnMzByRm9ZeE1UTUVvVDV3?= =?utf-8?B?VENHRjFFaCt0SFpSR3RJQU5JSkxlUlJRblNnVm93dlJWd0lCbTFWdWdhMXhF?= =?utf-8?B?U1VVVTh2eE1mL2ZqTXNBYzlyY1Q0VFBCUS83a0pEdVJzWVhQZDVVeXlxcCtF?= =?utf-8?B?cWl2aUFha0FDcEZET2x0ZzBFYXFXbnhsc0p4dk8rRTlJcDU2ZEJMNSs5K1Zx?= =?utf-8?B?TFY2UERwVGpJNlBrZnMrWmhrVXlQSzEzVzM4NlhKbm9lVUtTNGFsVmE3dGx3?= =?utf-8?B?VkcrL2FLcGZDcjBmMUtkc2dscmpRTUh0NDlSQ3pwY1hZeHh3R2l1Sk4reGNk?= =?utf-8?B?TVhscXk0RHc2VVdBbnMyNnJ6UXVGTXJxSWFvTGlyblBrUnBrYTZOYnF3T0tB?= =?utf-8?B?dWhUU2JIZW5YakV0c29STmpDRmhMNU1KMnh1Rnh4Mk8rZ1kvQkRqU2YzMlFa?= =?utf-8?B?S1J1cVgwczkzc0VXSDZJRHZ3bS94ME5Weks0b00vcEE2dFdMTDBzekRxeVNL?= =?utf-8?B?UFNYaUJObmx2eGFvcEVwSDBkS25CWWZHTUtKTmw0SkR1Tm12QVQ0MGh6Tjlv?= =?utf-8?B?Y21TQ2NIemU5SE0vK1IyenlsOXQyenhVOWFGTVRkTTJ1YWloRWJoTWVucVJC?= =?utf-8?B?U0VOVGdKTXRJZjZWb2VJbW5HQXlHbU84VlB0TE5FOFkrTzRubkdYOGZyQkJT?= =?utf-8?B?bjRKMWU0K1pwc3I2UTc2N1hlMi85WXFpMlg4MWY1VlhOSzJOQ0hnQTVGczl1?= =?utf-8?B?THp3UU9GRWtsVVFPSHI5Sm1pK0dRdmtjbVFpdEMrVzUvcUpSRmJ2QUJTeTZX?= =?utf-8?B?RFNGTVY1VmUrWHZLZTlBVEpWQ3U5aTBaSUVubzRsaE5sNW02UDZTS05GYUFQ?= =?utf-8?B?MHRFeExQcDB4OThkVUwvMGE2MUV5NzVnRmFDRjlLN3hHczYwQjBQUXQ2RlE4?= =?utf-8?Q?WYU2dVH9UHMJXzxfqcdUVpFYl3z8QEef2XWjqF9?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1a5413c7-79c1-4ce5-2931-08d97136587e X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2021 13:00:47.7291 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: LM5RyPaoQrPL30amNzacVtuxbHakgb9YTZUAkyIQJQG2u9hpUvBixHNvhy39UxNHDy8hP0FOPy+s09sEBdP+2A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4608 From: Artem Bityutskiy Add C-state table for the SnowRidge SoC which is found on Intel Jacobsville platforms. The following has been changed. 1. C1E latency changed from 10us to 15us. It was measured using the open source "wult" tool (the "nic" method, 15us is the 99.99th percentile). 2. C1E power break even changed from 20us to 25us, which may result in less C1E residency in some workloads. 3. C6 latency changed from 50us to 130us. Measured the same way as C1E. The C6 C-state is supported only by some SnowRidge revisions, so add a C-state table commentary about this. On SnowRidge, C6 support is enumerated via the usual mechanism: "mwait" leaf of the "cpuid" instruction. The 'intel_idle' driver does check this leaf, so even though C6 is present in the table, the driver will only use it if the CPU does support it. Signed-off-by: Artem Bityutskiy Signed-off-by: Rafael J. Wysocki [Linux commit: 9cf93f056f783f986c19f40d5304d1bcffa0fc0d] Signed-off-by: Jan Beulich --- a/xen/arch/x86/cpu/mwait-idle.c +++ b/xen/arch/x86/cpu/mwait-idle.c @@ -742,6 +742,32 @@ static const struct cpuidle_state dnv_cs {} }; +/* + * Note, depending on HW and FW revision, SnowRidge SoC may or may not support + * C6, and this is indicated in the CPUID mwait leaf. + */ +static const struct cpuidle_state snr_cstates[] = { + { + .name = "C1", + .flags = MWAIT2flg(0x00), + .exit_latency = 2, + .target_residency = 2, + }, + { + .name = "C1E", + .flags = MWAIT2flg(0x01), + .exit_latency = 15, + .target_residency = 25, + }, + { + .name = "C6", + .flags = MWAIT2flg(0x20) | CPUIDLE_FLAG_TLB_FLUSHED, + .exit_latency = 130, + .target_residency = 500, + }, + {} +}; + static void mwait_idle(void) { unsigned int cpu = smp_processor_id(); @@ -954,6 +980,11 @@ static const struct idle_cpu idle_cpu_dn .disable_promotion_to_c1e = 1, }; +static const struct idle_cpu idle_cpu_snr = { + .state_table = snr_cstates, + .disable_promotion_to_c1e = true, +}; + #define ICPU(model, cpu) \ { X86_VENDOR_INTEL, 6, model, X86_FEATURE_ALWAYS, &idle_cpu_##cpu} @@ -995,7 +1026,7 @@ static const struct x86_cpu_id intel_idl ICPU(0x5c, bxt), ICPU(0x7a, bxt), ICPU(0x5f, dnv), - ICPU(0x86, dnv), + ICPU(0x86, snr), {} }; From xen-devel-bounces@lists.xenproject.org Mon Sep 06 13:01:24 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Sep 2021 13:01:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.179831.326239 (Exim 4.92) (envelope-from ) id 1mNEFY-0007F7-Gz; Mon, 06 Sep 2021 13:01:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 179831.326239; Mon, 06 Sep 2021 13:01:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNEFY-0007F0-Dv; Mon, 06 Sep 2021 13:01:24 +0000 Received: by outflank-mailman (input) for mailman id 179831; Mon, 06 Sep 2021 13:01:22 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNEFW-00070n-L8 for xen-devel@lists.xenproject.org; Mon, 06 Sep 2021 13:01:22 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 85213f56-0f12-11ec-b0a4-12813bfff9fa; Mon, 06 Sep 2021 13:01:16 +0000 (UTC) Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-he1eur02lp2054.outbound.protection.outlook.com [104.47.5.54]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-16-4zTxguOhNJyKD5lOYhCkVA-1; Mon, 06 Sep 2021 15:01:14 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR04MB4608.eurprd04.prod.outlook.com (2603:10a6:803:72::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.21; Mon, 6 Sep 2021 13:01:13 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4478.025; Mon, 6 Sep 2021 13:01:13 +0000 Received: from [10.156.60.236] (37.24.206.209) by AM0PR02CA0181.eurprd02.prod.outlook.com (2603:10a6:20b:28e::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Mon, 6 Sep 2021 13:01:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 85213f56-0f12-11ec-b0a4-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1630933275; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gXqC7kdE6vgcxzHsZu6LKPSCCwekAZOdkt0dRfJilCw=; b=Ktcpexp4X1FT3W4pAC7pUsPQzrkGO2TVGTntuRgBWNeIFnI16yoYesiVD+RAxa7GN53VrY shfEaP0flxV2POE8B/TgQsqvVC3o0bYlbIzqzKUOYKSUhWrZYuRenu4Jlo5xtrnun3hVLM YQHEn2bR6i4iXVDjQxSoQXxcJfUxda0= X-MC-Unique: 4zTxguOhNJyKD5lOYhCkVA-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OQ1hhvpzshOWV7M8HGtnj/xEGUliPqE+LcKtpQ9eTUvHV5LNbZzIAHP7dZsySbv1uMF328nXodfDda0OqBvFrE10edK+XIcNXYzvcsBAlNcPkw7Su5JhKA6/J6CQN8eQdpczJC5t2FWtKD9UM33HkaY8aQQem7Yu2nz9zFE8cbBv9ld+4zndlbw/Ag2SSg8PWixxSYFXpK/FI5VrTLGKGAk7BOqcJt6LP/VRRK5v+qpYC1DjfKf+zc1ZcgiEXmQtG0RMdqmY4BgwEPX59Dsvw+khjgvylPJbVeFZ8E3ETDbblvW8+Xka5Qq3P+9fJmwV21rZ5BI+eNuBNtL2REUeFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=gXqC7kdE6vgcxzHsZu6LKPSCCwekAZOdkt0dRfJilCw=; b=Hc02hEB4Ogp1mEAvFDowtjsJA98bTzyr1E/ahMO1JN3d0GewcSEFwl9NeHAvXQboEPS2A6tX1ArvVagrydPWp57slRMa9qYg7NNfCjN7tDCNpSNMRhGZp7F6bCV1sjOvxWUK4CoThYJpFPN7czwXTBZysHYNNweOTmS8vhi40jcmhvDgho9U15zGAR64xcDw9dc74Rhny8deo84Wc+qieTrA+oeHgD29998eZbgVNHth657OcAiC4nt68jvYqupWLZEiqIrF44HDL6EAXxPNU2/oLV6E1iTzvX8FMbvZjRgPs8FnMdUAfuZGf1wFx0+iVHerZMqCSJT5sZl4155ACA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: citrix.com; dkim=none (message not signed) header.d=none;citrix.com; dmarc=none action=none header.from=suse.com; Subject: [PATCH 3/5] x86/mwait-idle: update ICX C6 data From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: Message-ID: Date: Mon, 6 Sep 2021 15:01:12 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM0PR02CA0181.eurprd02.prod.outlook.com (2603:10a6:20b:28e::18) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b5dc565c-0990-49af-0609-08d9713667e4 X-MS-TrafficTypeDiagnostic: VI1PR04MB4608: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1850; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Foml9KDVDTIII9oDRVhzQetiXWAASLxxWUp+CozyqOhQXp3CKUw21a/FoF0QBZ4cW/7cN94Kk27e2OeYJpxFY4oQpBNIlcxjYBytawQ2gZMGxUOppibIuhwHjCqTkvmTs4oNcd4qbbXh8SS77Fdboek8FoTA+ViiB7zytSRsidBGkf3fbtdQczBWZaf0JN/6WRNfi2t9yaLBGXMiW8vL5WPt7e5wPOfvtTZzBGPirM8JCWvckrShRe77ZsUXFuZfm9aqfU/kmflRTD46YLrBq4PA9a3AoQSZtJ47o9dOAF2NL+IvB8IisdX1vAsAU9axU1QJPFhBVqpECboPf2YiTezuUJWRtO2TcMy30w4HY8FKpkU4lpaODbQVUk0U5Hns72JpUBLQkNUGDq0WmmWTZWX2XnHTxjnd1cdHtccJ43cVIEts3fPkGjl12F5zI34nQHlgwofk7m7npf9GOt1axwEVcvogytnH0Mi2zcYPOaO7scaTk4m4bSg1DgnEaCogPItvXFFLGH79Pt+EffDNV4cbz/ZjZFsDzFZJjPhLREA3MX2Rm7Y3fYzl33b+KVxr0ekZR3XcjMQ0JpQSY8xg6iONG2LihnNiFIObnSM/ICu6XiFu8hYFtp2gvQVu38nmDy4bAtJGqF3dJx2BIPcS2VknG5u9rgCFyy4ke/08Av/69IB52+fggWpNzI6hgYkgcd0kVPykHGaRL99my2w2VwMDEqeHY+VJ/QWH8lV9V5Cb36vvHWAT7eZb87kv4hWN X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(376002)(346002)(366004)(396003)(136003)(39860400002)(66476007)(66946007)(54906003)(478600001)(5660300002)(2616005)(6486002)(16576012)(8936002)(2906002)(31686004)(8676002)(316002)(956004)(4326008)(26005)(6916009)(86362001)(186003)(31696002)(38100700002)(36756003)(66556008)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YjFqVWpTdktXT3hJV1RDVmlvMFgrR1JxNWtNd0c3WExQNHpZUE9VZXhObHNL?= =?utf-8?B?UThQaWxrTEdqTG81MzZrTDRKRzNMSk1zM3FVUHNOOGdIcGlBS1VmM2lNTmEy?= =?utf-8?B?TnNoSjdzbWVhbVhWTEFxNU95L3RDWkNrK2UzQnZjVzN6a0xuQnNtMUhkbTRH?= =?utf-8?B?dW1xUlN6VlRTYzJTVy9KdWhVVkpjY2lBSEQ5cGw4SDJjL3gyNnpMbm5OdHdq?= =?utf-8?B?eGJjTnVNT3RWRDlLNTlpMlFhbSttQ3RvMy9OK1dpOHlaVVUzMHBoL1ZBeUc1?= =?utf-8?B?M0ZMRVhtTEdkQUxmQVA4QTlzNTFJOFJxWFFtYXJad09uT0dubGRLTE5nY1Zk?= =?utf-8?B?TXl0OXhYamE0SkpwQkRzVFJxbVJHZUlXRDNKSk1aZDkyTnhwL1YrMWlFdUxY?= =?utf-8?B?d2pEbUNTRy8vQzQyUTRKOVcxdGR0MVhFNVJTNVlMZFhZRy9RSzJ2YWdGSWVj?= =?utf-8?B?c213VG5ycHhpcU1oSlk5ZzQyT3RRYXFWOC9ZN2Jmd2JUM1M0dkl3R0VRS3o3?= =?utf-8?B?MUxHTFNWbko0bit1NlAxczRHVzhsQW5tTktPdWRBME1pQWFzYXNNSHNwamhJ?= =?utf-8?B?SmROOWJhSDU4S2FFRnMzdktjY01nZDg4bWNNRmo4YVZMQjBUejJhZ1BILzBU?= =?utf-8?B?SWtHT29jU0hKMEQycnFVY1MyTDFqUklURmVrcXlqMnRmMmVIVERVR2tuR0Qx?= =?utf-8?B?TlpGN0l2WHIrS1I4Z0lwM0svMGlHa2FpaXRrUFdPaGExQW5lcW1zZml2aGh0?= =?utf-8?B?eHRJbmFnQ0N3Q3NNdjR3U0U3V2ZmMHdBN1dzSlhqc3hKd0g5a2lBWEpHdElP?= =?utf-8?B?SnVqeHg0R0hlUXNuMjExa1ZZa2I0TWVJVXdWNlNIajcyT2s5WG5PRzdmSUky?= =?utf-8?B?Z0ZNNkduMUZpQ01KY0JLZ1YxaTRGUm9aRXlaRDd5blNiSDBqRms4YVRoeTFU?= =?utf-8?B?aU1RbzFiSlpRM2c2Y3hqQVlvY1N3RE1rOVV2NzZEQkU0THI4WnB4aDVCTitm?= =?utf-8?B?cEJLeVpscGs1VHpKWEpxa2FBVWJxRmo0czllYUFPeEM0QU9iVmJoWVpEQUxr?= =?utf-8?B?UE5rOE1sTmhLTk84eExiZ3J4UDhTTktESkMvalA2cm9oQU16b0dnUjdwUTZn?= =?utf-8?B?a0pZbkJMQUNQWkljcTVRcnlLUHc3Q0UwMklQVlJNWXBkcG5TSkVIOGxFNzlr?= =?utf-8?B?bE05MDVHcmxCYS9kU3NCZm9NSWFtWHRrdnM0TFZ5bVJLaWJqc2NpU0hNN2hM?= =?utf-8?B?aktIWmpXVnFnMGM2SjBiNUJFNHdvNUEreXdHaEZPSFJINzE3L2R6aEhDbU0z?= =?utf-8?B?cGlhWHR5TktBVnRNVi9rUmZ2MlJYYnAzYzQ5VFRCNlM0ZE5xSDd3Q1p3OWlE?= =?utf-8?B?SjZjS1NqM3MvbXcrcytNY2xqaWU5d0tZZlBHUjZuZkZiOXlJVVdjamc1UDhI?= =?utf-8?B?TlJmMXdRU0NFLysvSXFGV1hia0t4TVdvN0Y0SUh4ZGM2aDcyeU9iMitHZ3FC?= =?utf-8?B?MHI0UndwTFRUdW9hbTF3VE5sa0JpRE8xVDVQWXpVZm8xKytibHlTTnQ5akdR?= =?utf-8?B?MnZlS3c2TmplN2dBVDYweVFPcEJ4MzBFbnYyMmIrdmFyWWNqK0pYaG83NUtF?= =?utf-8?B?ZXcrQitOamFBUWJsS05BSFpGQ05jaFVQWjd0QVIyZkIxT1hia084UTBRTXE4?= =?utf-8?B?QnpNNWlWUHZGbGRMYm5TRFNpTnJpVExobFlBYmdXMzFOdzRyOU1VYVhaSjB2?= =?utf-8?Q?Rov4S/z/iy3boIpeBy/AWAYbIFGvkp9GjsKV3rQ?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: b5dc565c-0990-49af-0609-08d9713667e4 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2021 13:01:13.5545 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: e86jtHR11cuJbPnyo8CNIznS+QrImzwD0T8IPf+jtAG84+eAbtziWKRHjawtb5uL0JY7IywiZSgCX6HHKrIe5A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4608 From: Artem Bityutskiy Change IceLake Xeon C6 latency from 128 us to 170 us. The latency was measured with the "wult" tool and corresponds to the 99.99th percentile when measuring with the "nic" method. Note, the 128 us figure correspond to the median latency, but in intel_idle we use the "worst case" latency figure instead. C6 target residency was increased from 384 us to 600 us, which may result in less C6 residency in some workloads. This value was tested and compared to values 384, and 1000. Value 600 is a reasonable tradeoff between power and performance. Signed-off-by: Artem Bityutskiy Acked-by: Zhang Rui Signed-off-by: Rafael J. Wysocki [Linux commit: d484b8bfc6fa71a088e4ac85d9ce11aa0385867e] Signed-off-by: Jan Beulich --- a/xen/arch/x86/cpu/mwait-idle.c +++ b/xen/arch/x86/cpu/mwait-idle.c @@ -574,8 +574,8 @@ static const struct cpuidle_state icx_cs { .name = "C6-ICX", .flags = MWAIT2flg(0x20) | CPUIDLE_FLAG_TLB_FLUSHED, - .exit_latency = 128, - .target_residency = 384, + .exit_latency = 170, + .target_residency = 600, }, {} }; From xen-devel-bounces@lists.xenproject.org Mon Sep 06 13:01:55 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Sep 2021 13:01:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.179837.326250 (Exim 4.92) (envelope-from ) id 1mNEG0-0007pb-Vp; Mon, 06 Sep 2021 13:01:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 179837.326250; Mon, 06 Sep 2021 13:01:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNEG0-0007pU-R3; Mon, 06 Sep 2021 13:01:52 +0000 Received: by outflank-mailman (input) for mailman id 179837; Mon, 06 Sep 2021 13:01:52 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNEG0-0007pK-0a for xen-devel@lists.xenproject.org; Mon, 06 Sep 2021 13:01:52 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 994aa0fa-0f12-11ec-b0a4-12813bfff9fa; Mon, 06 Sep 2021 13:01:51 +0000 (UTC) Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-he1eur02lp2054.outbound.protection.outlook.com [104.47.5.54]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-20-A-cj4z9TPxa0qOumc9_p6w-1; Mon, 06 Sep 2021 15:01:49 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR04MB4608.eurprd04.prod.outlook.com (2603:10a6:803:72::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.21; Mon, 6 Sep 2021 13:01:47 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4478.025; Mon, 6 Sep 2021 13:01:47 +0000 Received: from [10.156.60.236] (37.24.206.209) by PR0P264CA0226.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:1e::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Mon, 6 Sep 2021 13:01:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 994aa0fa-0f12-11ec-b0a4-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1630933310; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=C0VetijaR8xkFGTQTUwV6cJiozc54HeEusdPV3iHAi8=; b=UOa/xj8QqxMsM91USdtP/TgHQ3lZcGg68peADaIWNS7N8KIflac2ukZ4SCZwSGbAHJgcsz uZSjEJfZwEg+BlVennC51N3cTkfv43ak/AYdCak5MucW9+8bofx9uCBYnUW5O7a1H0lfmY j//yN4NOCz2bVRDrUV9bzJsgba4a6pA= X-MC-Unique: A-cj4z9TPxa0qOumc9_p6w-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KrsUmg3yW6KZu0bukEOz0NRdeY/4rpJse07BhCHEWkbgLQr8Itr1Kj3+cMcdbccwLiD3Cjj/lDmfUGZpw2rEmwtrOV1o0zwwl6y15Ve02ICKH3cU75wHQyKO5h4hB1oxCtfte6QmpVe9bbpA5EVsEpnZWe4laLDAjRzp2S43QHg5VehRI0mE6oglth8FYbgoQmxQtvbLeo8t7LXLg6pDqLFMWzL0osvGNAAWSWO2SSQY6i7C1gF7ECg3ZFk/54orM+/zxFlF3UX74rkUwIcadlJEiizeLTWFEYZlEEPxcMMSiRF8Do0EYoBCuxn2vjj8kX65t8M/svQG7jWCfEgGZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=C0VetijaR8xkFGTQTUwV6cJiozc54HeEusdPV3iHAi8=; b=JyFs+DCOG0DB8e3UF2xtNB4E5nlICNQquHcqO9YeI21xgUbJt/Vg2TJZxT7hedCORe0uorQL/si889p/Y8+Pmlq7R9/7KLOX8Q/y65xWuwVzBmgGeNt1MfZcfelqoVOha65tP/pfsSaPxhjDjvguhEbalMD3bBwHQBhIWDIsH6xZemzlKH8BMg6U8En7MQWXMRTi4tD6nY5xXHXFOQRcQ8DAgvqLCUAjSMHn5u8eM1Kj40yB3rRbOjdeOzPj+RrfrMMx+3dTPSHKN89QGMWGZbxRZaWhiMYDhCsTZhZ/DjuGBZdUHL847Ae+HmoJO9xzMcCEPtVSjpGSlZQiHd61vQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: citrix.com; dkim=none (message not signed) header.d=none;citrix.com; dmarc=none action=none header.from=suse.com; Subject: [PATCH 4/5] x86/mwait-idle: add Icelake-D support From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: Message-ID: Date: Mon, 6 Sep 2021 15:01:46 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PR0P264CA0226.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:1e::22) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 877498ab-33e6-4fa5-75b7-08d971367c48 X-MS-TrafficTypeDiagnostic: VI1PR04MB4608: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:483; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: txKJ/x3HL6XEsk8VSDAPxfPxRVWf5wotqkw6RHCyU57bMCSD4kCO1DwYDnTOmfMLPxuR/T9ldhGy5bwR8KFQmL15w+2aFnVhdH/PfzBOtse6flTqTTbnkv3trrQ4vmrF4xA/rXpwRRDnYLKCpk9ZbtXtdItZTcwqKs6vEMsLWxE0z0sEdWTStnbe243cFJjFHWY+YmPT2P60mVw6a2Jw9MJZtX9tHOl2neDJ71JulngDDYuDyIHhMvR9rIPk+bvfZH6mOLzl9YxetKjNhPS/tEoyuQcGUthu8KkD0fpFIzbNCdptKyRCsSiPf1uq9UnyBOcVI2wRYDiG0kBrVyEwZ0/QI3zllb3965UANPvZPhGFvKXKWQUJvXcmhs+6XEAmO9neJh6PY6ejTrrDtFjASito7CfCQA0Gut9m9z0gBPHCQtCgOGpaJCgw57WcCOK3Zakrq1v1zAy5mY28+n9Ymj3Oci//GJZ/7qB195xHEfyjoeVrj2cEEBwZFGMFruUwUnIw+JZ7vD/6WJ9aFRjgfdZYfIJJ6bAut+Qh6OysRIAsmbJqKbZgWJAOvs3AYDb7V91PnFCbdbwKEHNs+nXxs320h2xKIp5ddK/6AoSjWg1ynpZzAtHbbtjYgXkardvsqS/YLAEom6AuQp9I6hTsN2hgpteLF8H1r/6zWKOIub7IuoU+qmAypx/cwHe8thwhuTtPK5X3HLmqJi3eAdFmY1IOe93KyoLUPt80W4Vhd/8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(39860400002)(136003)(396003)(366004)(346002)(376002)(26005)(4326008)(86362001)(186003)(6916009)(316002)(956004)(66556008)(4744005)(38100700002)(31696002)(36756003)(5660300002)(2616005)(66946007)(54906003)(66476007)(478600001)(8676002)(31686004)(6486002)(16576012)(8936002)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VWF3UkpMK2hyUmV0M1hTUDNNb3l0ZmRkQm83OEh0VmQyVzJ0dFBqT3pFQVcx?= =?utf-8?B?eDdNSVQ1SE8wWEsxUFRJcFBMYkxOQ0ltTUE3SWRML0wvNk1kQ0VLNU5IR29N?= =?utf-8?B?ZUhMWnJISFhQR1BOR3hSL1JZZURsS3JFNWtNRFRQUUhadlQxL3kxSUVyeEUv?= =?utf-8?B?Z1VrMzcvbHI2SzhYUzY1RzdoTVVmTGphaWpZUHVvM3JUeUoyWW5wdFMxcGJl?= =?utf-8?B?VzdtY0twZkFBR0sxSHdSWk9FamJWS0JGelJNcWI4OExtQXA0WTFIZi9zTmxh?= =?utf-8?B?Z0IxUmhxRDEvclRSOHRHa29DaytUTVV0UG5KbzJ5enpXdXJJeDkrUHkzWmlQ?= =?utf-8?B?Ymc5bktNMzhMbnByZEhWZ2VqNmFGTjRwTTVUM2JjRmN4bVk3Mm5oelFqOWwr?= =?utf-8?B?Wm9SN0FJV0JTS1NQVUROTUQvdEtabWJsYlgvNTJuS2Z2RDMxU0lsRXRMQ2dp?= =?utf-8?B?QmhRL0F3bEJ4aWlvZ0NTcGZ2L3AxVWtqWnRaOVdFU0t4KzFPRWpBRkVyRkM3?= =?utf-8?B?NkZudk5vLy8vdS94eXQ2a1UwVFgrME1LSEhKWklGZVA4TWhJQmdLbEwrMmR0?= =?utf-8?B?WXM5WjVuWEFOSXplczQwR3lwTHo3T3hzeU9zNm9BTzZDTXR5MWlkRnBkbVNS?= =?utf-8?B?RSt6elJzS2tGM0dZK0gyM0FsUU5Fb0hZZ0U1bUhHSmJnNEJ1SWdaNW5IRUEz?= =?utf-8?B?WlNPenhMQ1ZhTTNvU2JaaGVIWFJMdWFLRTEvdjFua0ZBaUFaRUtuYmhxeS9a?= =?utf-8?B?dkRQVGhWL0lvbEdNVUpRbXZGQWsrQ2dhdWV4RURFVGJ6WDlHSi9aR1lwODR2?= =?utf-8?B?NWc5dFdQclNNMXJMamwyKzJBTDlmd2l6S09uMXRVWldsVVB4UkMwT04rMlZB?= =?utf-8?B?MXRwOVpMT2YvS0s1Y3VLanVRYTlZZnhrekhMcklKWGUydGFTK2h0eWhNcWd0?= =?utf-8?B?SU8vTW51SS9lTXFPTnREeCszU0pHbmJVZHhhM1hKcXpMWm5yWXpHTDdyMGFW?= =?utf-8?B?MHRFdWtUR09ld0VhR0owandNY0RBK3J1N1N1SEhIVWNyNUYyQmMwRFpSRHI4?= =?utf-8?B?TzJ5MG5hZ0I3SXRid2VjSmswUUlMN1RRbnN5c3RQcnNkT3JFQUJUMkhBbnVL?= =?utf-8?B?c2pDNG45Y05DOWMvelBTRzgreVJMRi82QlRCbVl6ZnBTTW1ycDJYd0JBaGNU?= =?utf-8?B?THdrcVMxV242MEVuTmdwZ3pJNHd1Wms4TFZFMVJ2TjlTM2lIVGZTT0srMEoz?= =?utf-8?B?MUZLV2l3MjhtcWRlazNmOUVpeW1vdWdIQVQxdWIzYTJvcWd0WEx3VVRmNm16?= =?utf-8?B?RG01dVFvTlphdkgxSHFTQ1pCTEtqSUI1a2RUTDBJMko0WEFmSzBxK0pEeUhH?= =?utf-8?B?UytCejZRU3FidSt2K1dMYjdQOHpjN0RtdVVyYksyNkZ3OEdTdmt4RTd4bWdQ?= =?utf-8?B?OU14MWEvTEFWR0xRdStTRER4VUFjTkNSTWZCNS8rUXZzZXc3NWdBaHQrZndP?= =?utf-8?B?cUpJRzJsL0FhMTNMWW0wRXIxR0h5SHFjWUVwd21iYWkzcWlVRXY1NnE0WFR6?= =?utf-8?B?RG9majhKMjZ6YzZ5WHBMZ3hOOGJKaGdNcC9scHltWmxkOVpZcmEvZlNSdE9r?= =?utf-8?B?dnJ4QXVzUVZTak90U1NEWHA3cXl0WDdqZW0zSmVEYXhSTWY2RmxKeWpTQkZK?= =?utf-8?B?dElrZnNyZ2NsSnl4SzQ3c0FkV0g1S2FDZHJzM1laVVdMQ1B3Yms0R2QzdjVi?= =?utf-8?Q?g6SjCp7nkgPZiibm/vS9jUAWACVYG7MG/lQ8/BP?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 877498ab-33e6-4fa5-75b7-08d971367c48 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2021 13:01:47.7651 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: LG5szUu94mJS1RPw6ilyEDfhU1Gv6yB8pB8NaGL9KMs+Ovb+MB0KUw/FnSh1/nCSAk5xjlXiv2amEQbsUcTMSg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4608 This patch adds Icelake Xeon D support to the intel_idle driver. Since Icelake D and Icelake SP C-state characteristics the same, we use Icelake SP C-states table for Icelake D as well. Signed-off-by: Artem Bityutskiy Acked-by: Chen Yu Signed-off-by: Rafael J. Wysocki [Linux commit: 22141d5f411895bb1b0df2a6b05f702e11e63918] Signed-off-by: Jan Beulich --- a/xen/arch/x86/cpu/mwait-idle.c +++ b/xen/arch/x86/cpu/mwait-idle.c @@ -1021,6 +1021,7 @@ static const struct x86_cpu_id intel_idl ICPU(0x9e, skl), ICPU(0x55, skx), ICPU(0x6a, icx), + ICPU(0x6c, icx), ICPU(0x57, knl), ICPU(0x85, knl), ICPU(0x5c, bxt), From xen-devel-bounces@lists.xenproject.org Mon Sep 06 13:02:25 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Sep 2021 13:02:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.179844.326261 (Exim 4.92) (envelope-from ) id 1mNEGR-0008V2-7s; Mon, 06 Sep 2021 13:02:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 179844.326261; Mon, 06 Sep 2021 13:02:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNEGR-0008Ut-4V; Mon, 06 Sep 2021 13:02:19 +0000 Received: by outflank-mailman (input) for mailman id 179844; Mon, 06 Sep 2021 13:02:18 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNEGQ-0008Ue-FX for xen-devel@lists.xenproject.org; Mon, 06 Sep 2021 13:02:18 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id a92c2aa0-0f12-11ec-b0a4-12813bfff9fa; Mon, 06 Sep 2021 13:02:17 +0000 (UTC) Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-he1eur02lp2050.outbound.protection.outlook.com [104.47.5.50]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-13-QMFLyJeKMY-g26Ww_Z7L6g-2; Mon, 06 Sep 2021 15:02:15 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR04MB4608.eurprd04.prod.outlook.com (2603:10a6:803:72::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.21; Mon, 6 Sep 2021 13:02:14 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4478.025; Mon, 6 Sep 2021 13:02:14 +0000 Received: from [10.156.60.236] (37.24.206.209) by FR3P281CA0042.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4a::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.4 via Frontend Transport; Mon, 6 Sep 2021 13:02:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a92c2aa0-0f12-11ec-b0a4-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1630933336; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=q25vTfg9n5hflZMUVunRhlsx6PeE8kCcVjZSgImDym4=; b=Hil60oNA16WPL7nAR9GmglMgALqsmElPcmp7kYa1e99cTME/rfDrrxEITbHYqgWF4taPnx COm/MrHVqkV3SqXlYOPPhyQHaF+qouiLrLVht3Z/9Fkh+BBNp9jDtRP4ENGGgnZE486WiB AnMAzkBjxOao7l0ShqA1uwv9cFad578= X-MC-Unique: QMFLyJeKMY-g26Ww_Z7L6g-2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Wpk2a+RIrLwrozxDrlSrKSr+lrUEz7Qyzi0XBq5rCfDv1GoM4sHuR4rZFTI3lklQ5wW2FPvQLAJc71WboulW5/qvV94Vb61eHbWOkKEP6u4S/y182aEEumftrSyFyIXUVsGrd+Z6eQTV7eMUQA/8kcPdnDo3CVX4HF+EPRqaMpTWef9lYO+KLFlJQeaTWZYxsMsGtfsqbFljLGmhSW/cLG9dmrqWxtIHKtg6ZDKhLQG1YyKUiUxq5jxPdepKaeYlZpQNsUxUireO6QGkmSUky2RN0ZLilno7H7un/V3sqFTWDS2TIpL2qvB4dFR+AiDPTRO2CosbI1TkhBO9rX1X3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=q25vTfg9n5hflZMUVunRhlsx6PeE8kCcVjZSgImDym4=; b=hYJTTisj4WdVmIQ17WL2uPySfg1kK7K6LElXWrUDjAsXNoXYCNlNO7yYjFKgzEwN3FKA3boWAXwq2nJ6cVdwi6PNtjPKKKMThaxVSt0gyB6RgDmGalP1zpzIU14K5FnO3pIhArPr70TaT1NgCslFBXl3tPZtodqO57L2V/lvJgSJ03omu7gvOav990u28gRUN51F2H2qZkkz11SvfcDMj14cV2yRBt7IijKYcuarT2ZilM8eJO4nByXvs0ajsuI4XySd1Kt9DSnWX4DzdobNZaD6+LnB7HlFT8vqEs1/loegrkDjc5eCIj5LswxMes3b/kP6otqvQ3b6cJUMTcyPUA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: citrix.com; dkim=none (message not signed) header.d=none;citrix.com; dmarc=none action=none header.from=suse.com; Subject: [PATCH 5/5] x86/mwait-idle: adjust the SKX C6 parameters if PC6 is disabled From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: Message-ID: Date: Mon, 6 Sep 2021 15:02:12 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0042.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4a::13) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e6c4a2ae-3b3a-4497-6e39-08d971368be8 X-MS-TrafficTypeDiagnostic: VI1PR04MB4608: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: sOgmmceWZFhjWuATx/r6y2TEs4E0O4koN+SZvZW1sgtpSVSlr+gW88szl4fS/17a6xf2zHUFAoBKtRl6GuIl6qtATTMIYeepIFt+IJy4FqAAplMGMibR/ZRaYSnNtmY0QcVLYrA3udvnmlL4qm3tOqfFhIHmYucLNv278yLxoegEwVwv1N446PKm/JHD8sjtI4E3cd5yKmCZuQU/gvDtk0FwZflk/Q6QTsPjHzxIUNyE6MwnsnDjhfX95Sqq9FQEU/39Uylu74NYVpyp/JXRLv0WOw7yGk7ZsB10fGQmrLg1R9xQcdVe1DzNo7j6XMTNrliiBZwF7m8bfo5bdkyEjlVf689DvmR5aonHh2TfDDg5zE43I05sOY24doNkR5MNkqy6vqYEqtVDNLNxqBFrcvyvuXy8cZaODeli7HZJHK5+9EdrjADOHKfVxpNQLalZ/02XNLlMi7OdSEQd5mCjx7I9x5H1EElUQL33en9XOWa6hrRjo3uw0h56At1BTNHSlAa6csds4KFBT+WqQYESiItiv7TqYK3wphunlJWHJW4ClCzU8tPsl/IhpC166btTw736q6voN+7Xb4x0f2FEkHj1EX8q9EXy66R5e+fyANtw567Xt+H4co4FuNKJkxVh3OCCD9mEKVwsi60riGakBvRuOv/6zuDul08Sl66CUbIkccrvo+t9mHXdr+jJ6uhv8R91JyJBa1PR8C8B2OTMgRYyoYlslVfGNPXhwWEFtOP7U0yBW2gYMHLkhNaO+kU/2REB8YRtvo3pY+8hTLOmc+ehYzPAay3AfBIoM6h/IEVzJ8tuVrGeW1S/hUwxZVuw X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(39860400002)(136003)(396003)(366004)(346002)(376002)(26005)(4326008)(86362001)(186003)(6916009)(316002)(956004)(66556008)(966005)(38100700002)(31696002)(36756003)(5660300002)(83380400001)(2616005)(66946007)(54906003)(66476007)(478600001)(8676002)(31686004)(6486002)(16576012)(8936002)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cTdJZ2ttbGdxNXF0WE9QdVNPQU9nVW1CTGxyamkvUlNsdzZTL04reDhrN2tj?= =?utf-8?B?TFRWaFRBeFF1OEQ0bzhXYzk2UG5WZG0vd21aZk1WK0JSbE1MV00vM1hVWHZM?= =?utf-8?B?WU9lMkp1M25yU3pqZ2hHSUkyZzdYQU1rT203b0YvY2dLQnZzdHEzUE93SEdO?= =?utf-8?B?VDdCU2RwYkdQSTFOMm1aazR4OUh2dzZ3M25xckgwS0JGSlFWcnZ1M1RPWXJu?= =?utf-8?B?Uy9pTUhZRGhHUVU1cWNZSDBSVU9lWkplWEplaTJGU3BXbzR1QmhPUTVpVDhW?= =?utf-8?B?NUZ6THgwQStqRUIxcEZhdEFybklZY1JUdGVvTUhLcG4vRm5sb3h0TG5WSlZE?= =?utf-8?B?ejZ1TjJBelZqcWdtdmdXZHNiQXB0RHVGdkM1Y0xsRmh4MzhIazJnazFnYzA4?= =?utf-8?B?cFBBazBSRGN2SnJ3dGVWQ09FL0Z2T1hjNGgwck5NSVVhU3ZNQ2JBcFlSUjFX?= =?utf-8?B?NHJNYzRlekJBemFnM3F6WXB5ejFFZUlSaHhqUkVWaDRObTNaNHd0bEI0TERk?= =?utf-8?B?dVpSTzJHbDlSczJrZ1o0M3BFWnhoM0VKZzRFUEhIQTNqUDR6V0xVUkFDcUlR?= =?utf-8?B?djZpdnpGSGZCVVh0aVJKUmoxR2lMY3FwemRDeEQwcStoMUpiRSt6NkIxZ3po?= =?utf-8?B?WGhrNTZmQTkrdG9KK1ZKbHF0QUZwYzk0eUJZUTRlbnlRekhJRUZQeG1qUGQ5?= =?utf-8?B?WVozQmtKNTRCaU1wQ1pNR2h1dFd5ekE5MVphQVh1cmF1d0EwekRhYTg3L0dr?= =?utf-8?B?a3E4UUVQMUE3MFlmQldOK2d3TTV0WEtxQWE4ZkVyTnpub0F6ZHc3Q1ZNVGwv?= =?utf-8?B?RVFaRVV3d01UZGE5TktlQ3daVkpxYXRzY0NqMGFBcGhHT0piQkJkeHpRY0Nj?= =?utf-8?B?WE9mU2E2YWZrVEhidkJubXJ2TEZPZktyQnAzcnpWWHJYd2VTWXhZVHBwY3lB?= =?utf-8?B?ek5PT2liVlpHL2RzNzNzK2RXNzlvZ0g2TWQzUVFBS2loTE4xUEs4a09kRFQv?= =?utf-8?B?MXZFMzNQcGZudG1oSjNwSWlHQ0VQTnJmcndsUEl4QWJ5aGFGZjBKazVzMUpH?= =?utf-8?B?Y3c5ZlVsRWg5NVp2TS9lSG9CWDF6VFBHQmxIOFJGK2NGb0Q3RFg2eUFWQ3pO?= =?utf-8?B?eFljTzkwSWRuWEZWek5FUTNsZHRpRVQveEtiSmMxSGxqY0N1aTl3dXR2cjdl?= =?utf-8?B?ZnBXd2VSRnZRSE4wYnRoN1pmb0xrSUc5cjRPVjlWYWJLeGJFT21xTzBYdjRr?= =?utf-8?B?SEdMYkM3em0vNGI2b0NRaWZpb1A1bU04aW1iV0tSWUVlVjlVRHBHNk5sdUo5?= =?utf-8?B?Z0hTamJFSUw5cGpXNnFZK0RjVjgvYVgzMzJaNjBWUGI3UGpmUnZHYWgrSnpE?= =?utf-8?B?djFYcGltYmdHeTBGOHkxSTZvb1lYdmhmZjFCYU5ONzRWK21tendXZytLeElG?= =?utf-8?B?SUc1MkhOOVJpRytaMUtMTWQvV2VmS1lGT3p5Y3orVUNJL3lvdldKY0hSN2c2?= =?utf-8?B?VVhoREY1TjFvdFl3anQ2cFRiZWpPaE9WMzlHM20xOFEwZWtMY0V2alFwRFJt?= =?utf-8?B?Z3lKcEJ6dWRaTHI1M2syN1Yrc25uVjBVMGhDVnVJczFKL053ajZ1LzFuR21B?= =?utf-8?B?S0tnaFZPYmVEM09QQzAvY3pHYk1pY3RPYkx5M1QzMjhqRFRiQzltVHM0T1JP?= =?utf-8?B?eGhPZ2E3VGgvMDdsS3cwcStDVnNTSWlUazFXZTdyRjgyQnBpSEY0QW5DdUVo?= =?utf-8?Q?6orz3kj96UWtAkQqJpg0HdyNl9tp7twDD8UoWyt?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: e6c4a2ae-3b3a-4497-6e39-08d971368be8 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2021 13:02:13.9873 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: qfIPbEufWImrkCsk6wMr8vC8dfpNpdXMi9d95/6Es/JsTHPQD9knzDbeBrYwJWERQZu70yt3oTC6PlFrSeBS8w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4608 From: Chen Yu Because cpuidle assumes worst-case C-state parameters, PC6 parameters are used for describing C6, which is worst-case for requesting CC6. When PC6 is enabled, this is appropriate. But if PC6 is disabled in the BIOS, the exit latency and target residency should be adjusted accordingly. Exit latency: Previously the C6 exit latency was measured as the PC6 exit latency. With PC6 disabled, the C6 exit latency should be the one of CC6. Target residency: With PC6 disabled, the idle duration within [CC6, PC6) would make the idle governor choose C1E over C6. This would cause low energy-efficiency. We should lower the bar to request C6 when PC6 is disabled. To fill this gap, check if PC6 is disabled in the BIOS in the MSR_PKG_CST_CONFIG_CONTROL(0xe2) register. If so, use the CC6 exit latency for C6 and set target_residency to 3 times of the new exit latency. [This is consistent with how intel_idle driver uses _CST to calculate the target_residency.] As a result, the OS would be more likely to choose C6 over C1E when PC6 is disabled, which is reasonable, because if C6 is enabled, it implies that the user cares about energy, so choosing C6 more frequently makes sense. The new CC6 exit latency of 92us was measured with wult[1] on SKX via NIC wakeup as the 99.99th percentile. Also CLX and CPX both have the same CPU model number as SkX, but their CC6 exit latencies are similar to the SKX one, 96us and 89us respectively, so reuse the SKX value for them. There is a concern that it might be better to use a more generic approach instead of optimizing every platform. However, if the required code complexity and different PC6 bit interpretation on different platforms are taken into account, tuning the code per platform seems to be an acceptable tradeoff. Link: https://intel.github.io/wult/ # [1] Suggested-by: Len Brown Signed-off-by: Chen Yu Reviewed-by: Artem Bityutskiy [ rjw: Subject and changelog edits ] Signed-off-by: Rafael J. Wysocki [Linux commit: 64233338499126c5c31e07165735ab5441c7e45a] Pull in Linux'es MSR_PKG_CST_CONFIG_CONTROL. Alongside the dropping of "const" from skx_cstates[] add __read_mostly, and extend that to other similar non-const tables. Signed-off-by: Jan Beulich --- a/xen/arch/x86/cpu/mwait-idle.c +++ b/xen/arch/x86/cpu/mwait-idle.c @@ -484,7 +484,7 @@ static const struct cpuidle_state bdw_cs {} }; -static struct cpuidle_state skl_cstates[] = { +static struct cpuidle_state __read_mostly skl_cstates[] = { { .name = "C1-SKL", .flags = MWAIT2flg(0x00), @@ -536,7 +536,7 @@ static struct cpuidle_state skl_cstates[ {} }; -static const struct cpuidle_state skx_cstates[] = { +static struct cpuidle_state __read_mostly skx_cstates[] = { { .name = "C1-SKX", .flags = MWAIT2flg(0x00), @@ -674,7 +674,7 @@ static const struct cpuidle_state knl_cs {} }; -static struct cpuidle_state bxt_cstates[] = { +static struct cpuidle_state __read_mostly bxt_cstates[] = { { .name = "C1-BXT", .flags = MWAIT2flg(0x00), @@ -870,9 +870,9 @@ static void auto_demotion_disable(void * { u64 msr_bits; - rdmsrl(MSR_NHM_SNB_PKG_CST_CFG_CTL, msr_bits); + rdmsrl(MSR_PKG_CST_CONFIG_CONTROL, msr_bits); msr_bits &= ~(icpu->auto_demotion_disable_flags); - wrmsrl(MSR_NHM_SNB_PKG_CST_CFG_CTL, msr_bits); + wrmsrl(MSR_PKG_CST_CONFIG_CONTROL, msr_bits); } static void byt_auto_demotion_disable(void *dummy) @@ -1141,7 +1141,7 @@ static void __init sklh_idle_state_table if ((mwait_substates & (MWAIT_CSTATE_MASK << 28)) == 0) return; - rdmsrl(MSR_NHM_SNB_PKG_CST_CFG_CTL, msr); + rdmsrl(MSR_PKG_CST_CONFIG_CONTROL, msr); /* PC10 is not enabled in PKG C-state limit */ if ((msr & 0xF) != 8) @@ -1161,6 +1161,36 @@ static void __init sklh_idle_state_table } /* + * skx_idle_state_table_update - Adjust the Sky Lake/Cascade Lake + * idle states table. + */ +static void __init skx_idle_state_table_update(void) +{ + unsigned long long msr; + + rdmsrl(MSR_PKG_CST_CONFIG_CONTROL, msr); + + /* + * 000b: C0/C1 (no package C-state support) + * 001b: C2 + * 010b: C6 (non-retention) + * 011b: C6 (retention) + * 111b: No Package C state limits. + */ + if ((msr & 0x7) < 2) { + /* + * Uses the CC6 + PC0 latency and 3 times of + * latency for target_residency if the PC6 + * is disabled in BIOS. This is consistent + * with how intel_idle driver uses _CST + * to set the target_residency. + */ + skx_cstates[2].exit_latency = 92; + skx_cstates[2].target_residency = 276; + } +} + +/* * mwait_idle_state_table_update() * * Update the default state_table for this CPU-id @@ -1178,6 +1208,9 @@ static void __init mwait_idle_state_tabl case 0x5e: /* SKL-H */ sklh_idle_state_table_update(); break; + case 0x55: /* SKL-X */ + skx_idle_state_table_update(); + break; } } --- a/xen/include/asm-x86/msr-index.h +++ b/xen/include/asm-x86/msr-index.h @@ -45,6 +45,13 @@ #define MSR_CORE_CAPABILITIES 0x000000cf #define CORE_CAPS_SPLITLOCK_DETECT (_AC(1, ULL) << 5) +#define MSR_PKG_CST_CONFIG_CONTROL 0x000000e2 +#define NHM_C3_AUTO_DEMOTE (_AC(1, ULL) << 25) +#define NHM_C1_AUTO_DEMOTE (_AC(1, ULL) << 26) +#define ATM_LNC_C6_AUTO_DEMOTE (_AC(1, ULL) << 25) +#define SNB_C3_AUTO_UNDEMOTE (_AC(1, ULL) << 27) +#define SNB_C1_AUTO_UNDEMOTE (_AC(1, ULL) << 28) + #define MSR_ARCH_CAPABILITIES 0x0000010a #define ARCH_CAPS_RDCL_NO (_AC(1, ULL) << 0) #define ARCH_CAPS_IBRS_ALL (_AC(1, ULL) << 1) @@ -175,11 +182,6 @@ #define MSR_IA32_A_PERFCTR0 0x000004c1 #define MSR_FSB_FREQ 0x000000cd -#define MSR_NHM_SNB_PKG_CST_CFG_CTL 0x000000e2 -#define NHM_C3_AUTO_DEMOTE (1UL << 25) -#define NHM_C1_AUTO_DEMOTE (1UL << 26) -#define ATM_LNC_C6_AUTO_DEMOTE (1UL << 25) - #define MSR_MTRRcap 0x000000fe #define MTRRcap_VCNT 0x000000ff From xen-devel-bounces@lists.xenproject.org Mon Sep 06 13:13:37 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Sep 2021 13:13:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.179860.326276 (Exim 4.92) (envelope-from ) id 1mNERF-00020H-B0; Mon, 06 Sep 2021 13:13:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 179860.326276; Mon, 06 Sep 2021 13:13:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNERF-00020A-7r; Mon, 06 Sep 2021 13:13:29 +0000 Received: by outflank-mailman (input) for mailman id 179860; Mon, 06 Sep 2021 13:13:28 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNERE-000204-A0 for xen-devel@lists.xenproject.org; Mon, 06 Sep 2021 13:13:28 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNERB-0004RC-I9; Mon, 06 Sep 2021 13:13:25 +0000 Received: from 54-240-197-236.amazon.com ([54.240.197.236] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1mNERB-0003Lx-Bb; Mon, 06 Sep 2021 13:13:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=Y12aQVs2B09axgUlZvQNFaktwJQZPR6LaeC5gO9J3Zo=; b=Wr4XyjbkMShdiCiWcLXwSdIOCH fkgKPuhnWJ469AQgsKrVQoZLuuJsY8xSdHNVQjRRoa8YPveSdetCTV2E4r0Qquh/8+xDMGX6uM96E VIgA/NosXJ8i1tZUDtjM7oZCblYewEvXrquYxVobPSOYHkQF9HcvSmV2N22moyt/3sIA=; Subject: Re: [PATCH 1/9] gnttab: defer allocation of maptrack frames table To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Ian Jackson , Stefano Stabellini , Wei Liu References: <062bcbd3-420e-e1c0-3aa0-0dfb229e6ae9@suse.com> From: Julien Grall Message-ID: <7b8fba1a-767e-87f8-d0eb-5af5e5427bb4@xen.org> Date: Mon, 6 Sep 2021 14:13:23 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <062bcbd3-420e-e1c0-3aa0-0dfb229e6ae9@suse.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Hi Jan, On 26/08/2021 11:09, Jan Beulich wrote: > By default all guests are permitted to have up to 1024 maptrack frames, > which on 64-bit means an 8k frame table. Yet except for driver domains > guests normally don't make use of grant mappings. Defer allocating the > table until a map track handle is first requested. > > Signed-off-by: Jan Beulich > --- > I continue to be unconvinced that it is a good idea to allow all DomU-s > 1024 maptrack frames by default. While I'm still of the opinion that a > hypervisor enforced upper bound is okay, I question this upper bound > also getting used as the default value - this is perhaps okay for Dom0, > but not elsewhere. I agree here. I think having a per-domain limit maptrack is a good idea. > > --- a/xen/common/grant_table.c > +++ b/xen/common/grant_table.c > @@ -633,6 +633,34 @@ get_maptrack_handle( > if ( likely(handle != INVALID_MAPTRACK_HANDLE) ) > return handle; > > + if ( unlikely(!read_atomic(&lgt->maptrack)) ) > + { > + struct grant_mapping **maptrack = NULL; > + > + if ( lgt->max_maptrack_frames ) > + maptrack = vzalloc(lgt->max_maptrack_frames * sizeof(*maptrack)); While I understand that allocating with a lock is bad idea, I don't like the fact that multiple vCPUs racing each other would result to temporarily allocate more memory. If moving the call within the lock is not a solution, would using a loop with a cmpxchg() a solution to block the other vCPU? Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Sep 06 13:15:48 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Sep 2021 13:15:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.179876.326290 (Exim 4.92) (envelope-from ) id 1mNETS-0002l4-U1; Mon, 06 Sep 2021 13:15:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 179876.326290; Mon, 06 Sep 2021 13:15:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNETS-0002kx-Qd; Mon, 06 Sep 2021 13:15:46 +0000 Received: by outflank-mailman (input) for mailman id 179876; Mon, 06 Sep 2021 13:15:45 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNETR-0002kp-LG for xen-devel@lists.xenproject.org; Mon, 06 Sep 2021 13:15:45 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNETP-0004V7-U6; Mon, 06 Sep 2021 13:15:43 +0000 Received: from 54-240-197-236.amazon.com ([54.240.197.236] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1mNETP-0003Vs-OG; Mon, 06 Sep 2021 13:15:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=NJgZOIAhM0FRVum0rn4oVDRo/18ADiT0ruigwcfl41Q=; b=XW0IShM2XbHG4wk6yifxpLIXOJ auG9rIrvW9Oldb8T0hnV61Rt299IwvLueOVjPdpa4bDlb9kekT42qOAL/o/ZJFJxembj0fFUudmC9 +VRpfR4Bn7BiakMNDsfQ8+pyuCEf4sJnreGjZPBcb8GeTVJnoOMx9AQRIda6LIxHb/5o=; Subject: Re: [PATCH 2/9] gnttab: drop a redundant expression from gnttab_release_mappings() To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Ian Jackson , Stefano Stabellini , Wei Liu References: <80426a2b-81ac-acc1-db93-077934468b1b@suse.com> From: Julien Grall Message-ID: Date: Mon, 6 Sep 2021 14:15:41 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <80426a2b-81ac-acc1-db93-077934468b1b@suse.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Hi Jan, On 26/08/2021 11:11, Jan Beulich wrote: > This gnttab_host_mapping_get_page_type() invocation sits in the "else" > path of a conditional controlled by "map->flags & GNTMAP_readonly". > > Signed-off-by: Jan Beulich Acked-by: Julien Grall Cheers, > --- a/xen/common/grant_table.c > +++ b/xen/common/grant_table.c > @@ -3816,9 +3816,7 @@ int gnttab_release_mappings(struct domai > if ( gnttab_release_host_mappings(d) && > !is_iomem_page(act->mfn) ) > { > - if ( gnttab_host_mapping_get_page_type((map->flags & > - GNTMAP_readonly), > - d, rd) ) > + if ( gnttab_host_mapping_get_page_type(false, d, rd) ) > put_page_type(pg); > put_page(pg); > } > -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Sep 06 13:19:45 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Sep 2021 13:19:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.179883.326301 (Exim 4.92) (envelope-from ) id 1mNEXF-0003QL-EZ; Mon, 06 Sep 2021 13:19:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 179883.326301; Mon, 06 Sep 2021 13:19:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNEXF-0003QE-BY; Mon, 06 Sep 2021 13:19:41 +0000 Received: by outflank-mailman (input) for mailman id 179883; Mon, 06 Sep 2021 13:19:40 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNEXE-0003Q4-FJ; Mon, 06 Sep 2021 13:19:40 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNEXE-0004YB-6x; Mon, 06 Sep 2021 13:19:40 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNEXD-0008MQ-OU; Mon, 06 Sep 2021 13:19:39 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mNEXD-00012B-O1; Mon, 06 Sep 2021 13:19:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=NO45CK5PSRlWsYOEwHen1TOace1XYi38q9DOoPBe/h0=; b=W6Dux8/uaB3VLdu6YhVNOaK3Rk fe+ZFN6+Nob+v+cKKMnTsU+T2eh/5QRQWYMtroexZekVR0xATzUNeePuu5QwxWysPsGvAIRtNQySw Lhnvj6Ws9pzTtaYcLa6f1o9RecIjmcNqSTldkzpuzxgy8bCC/JgcMkvNUNOzEAlMWCLQ=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 164850: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-i386-xl-qemut-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-examine:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-i386-xl-raw:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-pvshim:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-i386:xen-install:fail:regression linux-linus:test-amd64-i386-xl-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ovmf-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-coresched-i386-xl:xen-install:fail:regression linux-linus:test-amd64-amd64-xl-multivcpu:guest-start:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-xsm:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit1:debian-fixup:fail:regression linux-linus:test-arm64-arm64-xl-thunderx:debian-fixup:fail:regression linux-linus:test-arm64-arm64-xl:debian-fixup:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:debian-fixup:fail:regression linux-linus:test-arm64-arm64-xl-credit2:debian-fixup:fail:regression linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=27151f177827d478508e756c7657273261aaf8a9 X-Osstest-Versions-That: linux=deacdb3e3979979016fcd0ffd518c320a62ad166 From: osstest service owner Date: Mon, 06 Sep 2021 13:19:39 +0000 flight 164850 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/164850/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemut-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-examine 6 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-i386-xl-raw 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-pvshim 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-i386 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ovmf-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-coresched-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-amd64-xl-multivcpu 14 guest-start fail REGR. vs. 152332 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 152332 test-arm64-arm64-xl-xsm 8 xen-boot fail REGR. vs. 152332 test-arm64-arm64-xl-credit1 13 debian-fixup fail REGR. vs. 152332 test-arm64-arm64-xl-thunderx 13 debian-fixup fail REGR. vs. 152332 test-arm64-arm64-xl 13 debian-fixup fail REGR. vs. 152332 test-arm64-arm64-libvirt-xsm 13 debian-fixup fail REGR. vs. 152332 test-arm64-arm64-xl-credit2 13 debian-fixup fail REGR. vs. 152332 test-arm64-arm64-examine 8 reboot fail REGR. vs. 152332 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 152332 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 152332 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152332 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 152332 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152332 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152332 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152332 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: linux 27151f177827d478508e756c7657273261aaf8a9 baseline version: linux deacdb3e3979979016fcd0ffd518c320a62ad166 Last test of basis 152332 2020-07-31 19:41:23 Z 401 days Failing since 152366 2020-08-01 20:49:34 Z 400 days 696 attempts Testing same since 164850 2021-09-06 02:37:34 Z 0 days 1 attempts ------------------------------------------------------------ 7219 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl fail test-armhf-armhf-xl pass test-amd64-i386-xl fail test-amd64-coresched-i386-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm fail test-amd64-i386-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm fail test-amd64-i386-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine pass test-arm64-arm64-examine fail test-armhf-armhf-examine pass test-amd64-i386-examine fail test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel fail test-amd64-i386-qemuu-rhel6hvm-intel fail test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt fail test-amd64-amd64-xl-multivcpu fail test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair fail test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow fail test-arm64-arm64-xl-thunderx fail test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2221077 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Sep 06 13:23:21 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Sep 2021 13:23:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.179890.326316 (Exim 4.92) (envelope-from ) id 1mNEam-00051B-1r; Mon, 06 Sep 2021 13:23:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 179890.326316; Mon, 06 Sep 2021 13:23:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNEal-000514-Uj; Mon, 06 Sep 2021 13:23:19 +0000 Received: by outflank-mailman (input) for mailman id 179890; Mon, 06 Sep 2021 13:23:18 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNEak-00050y-AV for xen-devel@lists.xenproject.org; Mon, 06 Sep 2021 13:23:18 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id a39a1414-ead7-490e-bae0-26b0da986191; Mon, 06 Sep 2021 13:23:17 +0000 (UTC) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01lp2055.outbound.protection.outlook.com [104.47.2.55]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-2-htmKaAk_NEqJWFquy_URbQ-1; Mon, 06 Sep 2021 15:23:14 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR04MB4848.eurprd04.prod.outlook.com (2603:10a6:803:55::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.22; Mon, 6 Sep 2021 13:23:13 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4478.025; Mon, 6 Sep 2021 13:23:13 +0000 Received: from [10.156.60.236] (37.24.206.209) by FR0P281CA0086.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1e::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.4 via Frontend Transport; Mon, 6 Sep 2021 13:23:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a39a1414-ead7-490e-bae0-26b0da986191 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1630934596; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xCq+T/w9za/+vXVmsi/kL7xE4T9zITd+xcOCO9ublJ0=; b=cHkJQa4uDFteIpHTdew1TpIQZKV05vHd2p51n7UaXdViG+/er6VnXPuRdwPTJc/4fia8Tw WCEOKCpEi8nE9o03uOze4xySd/Mmcmy6/q3v1DA4ausJClKBqY2nxzpuDpNlqS/e/IvWsB fqQarpkQ7RSWWKy51lKMz+3kvcBllHw= X-MC-Unique: htmKaAk_NEqJWFquy_URbQ-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HhMlIlDF6bEYB3ozbM+KscYSqqEhkfQN/rd5rXwgBDIpfqg3venWAn+QQsoyonh+drME+6VsMgeLDMmM8s02/6WJs5aeRdhIb/96HbLQg8fnOZmqzoFFwZkGvNH/+JOG54pwmyup4i8hrLYEZlcZ0iisqaMp1B+/iI/SZv3/QesBpuOTcLZMZMLoo6RszDizzfVV4XBnhPfRgIH+lMIjC5aKX5rjd2sAgJd/gCBrPS7ZnkRhbnKyhUn9ZJaSXpIjhVDUt97Tq2cBnIEAtflIdr1lxigIndooVRRpI2816/LyDqgWNTkSglmk9gmarOlrKO9jnVpCHXAdEtPwxfN+6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=xCq+T/w9za/+vXVmsi/kL7xE4T9zITd+xcOCO9ublJ0=; b=JnVGxIU75PhBdciQs+8Efy4TB0uw/Xu+FGQMdZiFVUfdKuWJQ8XCLsNfY3KsuIIKmzkVK2DsBmi/mMZYNFk+Lrb/vjroxCWwmGIYi8wl6C+lfL/YMlreKZzl4pU6zZrrLoatI67UDuTTkUZbuko1/jypEReD0/c4nhOBvXJEgemQjujJ/D+wrfJFO9/6UTy6sEmHNzcXQnKM9xQ72ZmtH+w2rGFvhFE4b9BMbo2OBdLXZ+XX0aSKJKUhWwo223kUO8zBQdlIY0QWVXHEXpqmlDCMcn0pnVJchKNExspfiSgRppyZqpKd/626laliH1ctMby5pKZZhUYXoUBivUhRBA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com; Subject: Re: [PATCH 2/9] vpci: Add hooks for PCI device assign/de-assign To: Oleksandr Andrushchenko Cc: julien@xen.org, sstabellini@kernel.org, oleksandr_tyshchenko@epam.com, volodymyr_babchuk@epam.com, Artem_Mygaiev@epam.com, roger.pau@citrix.com, bertrand.marquis@arm.com, rahul.singh@arm.com, Oleksandr Andrushchenko , xen-devel@lists.xenproject.org References: <20210903100831.177748-1-andr2000@gmail.com> <20210903100831.177748-3-andr2000@gmail.com> From: Jan Beulich Message-ID: <371a403c-adec-f1e1-8887-5664a749b169@suse.com> Date: Mon, 6 Sep 2021 15:23:11 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: <20210903100831.177748-3-andr2000@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0086.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1e::22) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: cfe7cddd-96ee-4935-f6a0-08d971397a59 X-MS-TrafficTypeDiagnostic: VI1PR04MB4848: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4b0nSyWvCjOOkRuuyRE3JhF+USvLjsUZOyiv00TqLcdQ8diaHwqQ+wisziUIKwLb2g+wQGVn5szYrmbciszzjW9C3rUdHsUi/M3ISdTvQIwUmTtK+QesJge9r9IShJTaIVm/fJCgnzFGB9I1+2NY51+Fneu9UqfHxO1s65Ds4FlvEQAUgp1lWyNIeAL4jZCKYBMo/jgQzgUyNZRT7gCttgS4svpiVS+MTZ5SddZCcuu/M5Q6Wg2F+2uLDggHLrW5L0bdJJALk3XvABPM6wdmwNSJ7xqTJ1JBKBYo6N41nupbTuNx//RsxDLhsJrt4vRNarXq56ggIYnNjRSQzEXiBqOUbZzSIfVr+QluohzreIe3RDpKKw2jbzgrC5FiML34UfnoCeLcnrdOr+5yXvkF0noqxeOikkDem1IfIcxoWCl3LnOrxn8OTuSP/y9Ll8CoYUCS9EzkYy0EXRPq3JC4zc912mTG3Er1nX6Pcj83sYs2AhVVxK/VDcAuyDTuuT2hg/X0TLDcPVsbBcen/JRXprPG5sITyFJddMVOF0xIVxJ1AJJShOnUN6vNXjmy2K0e1h6FiHLD25bngcS94pbX4rwpC9IhzWOsBWHq8WyWoxZwRq5AnePZEnje+t+PrcNGKwisBX1/5h4IokXikaKWj0DWkyvbfq8YgNeik8gQS61p9cxMbqSqrT8M229oCifBz5DYgLQMSKZvueBzgcTz7Wh1SLa8wlqLC9QpnJ8cBu4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(39860400002)(376002)(346002)(136003)(396003)(2906002)(53546011)(956004)(5660300002)(8676002)(2616005)(7416002)(8936002)(186003)(38100700002)(478600001)(6486002)(4326008)(36756003)(31686004)(86362001)(6916009)(66556008)(26005)(83380400001)(16576012)(66476007)(31696002)(66946007)(316002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K0ZlcjB5WTR4enlGdlhzNkYxRnREN1czYURoMFFFZHdqYi9MVlFyZXJTTEw2?= =?utf-8?B?bzdEaGp4b3VZU0NZRTZOaEw2aUZHalBqeDIxK2JjNXdrUjRaT2U1aFhnQTdn?= =?utf-8?B?R01vMWhMVno0M0NkckVhZFd5ckd2S2RLQzJkL1BTcXBrdjFGRlFZY3ZSaFFM?= =?utf-8?B?L3dzay9sdGRSV0lISG96Ym00NVE4RUJQOFRFWW55cFEyeHF3VlZnK25tNlRa?= =?utf-8?B?RGhFMjhJS1NmRENtM1BraWpWWGxkeUdrNzA5VW9mbU9xNW16WEVsZG9zMWZB?= =?utf-8?B?aGRXM0huRXlZMGt0WlJoaTM0Wkc0TlhZa3loM3hHVmswOWNEK1NxUVQxWG9o?= =?utf-8?B?RFJCTTdUMmF2YWMySXk3MmJFYkxuOTlvdEswT1ZEaHhpVjNlOFdUQk5xNmNp?= =?utf-8?B?amdIbXBZMGJybVBtNkZ5Tk1BWEVrUWtzVjB6QWJRRjg3NFE3Q1dJWW90YS9B?= =?utf-8?B?Z2wrUmsyNjNrMHl1S1Eyb2VoZnpWV0VjbHZCMDdQVDJGeEZzRlRyYTRVUkto?= =?utf-8?B?SnRDdnhQK0tLSldhalV4dGEydlZWaEs3bXpLZDB5WVdoV2Q2bUc2OUZKU2FZ?= =?utf-8?B?L0tzcWxuZ2xHejNiVm9kRDJQWGNIajJwTWVBZ0xyNjU5SVIyV0p5VkR3MnM2?= =?utf-8?B?cUVsVmxCQjAzdXBJTWVCM3lMaUhhUjFnL05mYWpveGhpaWZqZjRvUm9tell2?= =?utf-8?B?MitUdk1WN2J2ZEZ1ak9pN2NMdjkxTEZkcGFlMUpTK3liWFA0d3hpUGNvVGFs?= =?utf-8?B?OUViaFcrb29pRmRDR3lCTTMrb2FJY2lBTTZmc2VMZisyWWxtUU5yOGJnTWdI?= =?utf-8?B?UkxTNCszenppQUNwV1FEK09HTnk5UnQ3U211WDVHeS9kekpyclpMLzRJd2ha?= =?utf-8?B?Q0pLS3kveWQ2R290VmhEeXBFV3lXMENKdDFkanhaNS85V2hENklzYUw2Tkgx?= =?utf-8?B?UXhoUWgzN090MUNEV2FxclJnNVU0TkpaRHczdzB0REZLKzZwOE0rSEhzK3Zi?= =?utf-8?B?OERCUjRzMHVuYmVyTTFVNHlTVTF6R0FHQVE4RTlpZWdDNWVBMjdtU1lrSWpv?= =?utf-8?B?VER1dDZEUEdKYVVDUXArb3ZscDdHYk4xMjJvWkJKRDEwR0V0V2ZueUFlYzR4?= =?utf-8?B?aG5EaTIzMmE0U0h2ZXVDODZsTkJpVEJhMm0xTzBsZTdQYkRpeDFnR1J5cm5N?= =?utf-8?B?Rm50R1o2bFk1MDFlMlFhbXhzQTBwRUVmRWRBdjUvN3JaQTZJb1l3MjlrUEJE?= =?utf-8?B?MjE5M2ZoeTliOXIzbDdwUG9uc1lXOFZ5SFJJaGJHdlcraHdnVGw1dXNpenI5?= =?utf-8?B?ZUZYeDc2Z010cjJlcVpyUzJHaG8zM201R3VjNHNNRHlWRDd0ekJ2bzA0SVRF?= =?utf-8?B?a3R2VnVvcmNLNysrQzV6TFRLNGMyUjNrM3BMSXlqeVB0S3ZJbW9YQ1ZES1lh?= =?utf-8?B?Y2ZNcFAyQWpla2Evc3N1K085ZGRmdmoza0lyYVlrcVBLWG9CSjhDUkc3Q2Y3?= =?utf-8?B?QTBjeTF4bDYrMTdTZFBudDlVT0RpNjN6R3FCZTVHenZPS1E1Rnl1aUw2NER1?= =?utf-8?B?a1Z0RHpYV3Rtb0NTQkhIWm9LS1p4R1ZWWHhlNFBpNnEwUEw3bWQydUFCc0Jw?= =?utf-8?B?RnI0Ty9DZWkxa3p5YVdyNGtQbi9MdVVRbXRoVFhyMjlZR3J6RkZKbGt5L21j?= =?utf-8?B?eWZEd0taejF6RG41aEhNb3picURIRm4vQkt3NFJzWVRpanBsSUVyam50QmYv?= =?utf-8?Q?AMiuc6YiWdgNPZOf+lt1dhKN79FclEYDKc2gV1k?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: cfe7cddd-96ee-4935-f6a0-08d971397a59 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2021 13:23:13.0436 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: O/zupNZRPlBvBXbEnA36NKl/5hZztPczuA0cIRc9Bi6daTlmcqlABsSDQT1HxIu8kO/bDQXbxV6baQtzpCLy4Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4848 On 03.09.2021 12:08, Oleksandr Andrushchenko wrote: > --- a/xen/drivers/passthrough/pci.c > +++ b/xen/drivers/passthrough/pci.c > @@ -864,6 +864,10 @@ static int deassign_device(struct domain *d, uint16_t seg, uint8_t bus, > if ( ret ) > goto out; > > + ret = vpci_deassign_device(d, pdev); > + if ( ret ) > + goto out; > + > if ( pdev->domain == hardware_domain ) > pdev->quarantine = false; > > @@ -1425,6 +1429,11 @@ static int assign_device(struct domain *d, u16 seg, u8 bus, u8 devfn, u32 flag) > rc = hd->platform_ops->assign_device(d, devfn, pci_to_dev(pdev), flag); > } > > + if ( rc ) > + goto done; > + > + rc = vpci_assign_device(d, pdev); > + > done: > if ( rc ) > printk(XENLOG_G_WARNING "%pd: assign (%pp) failed (%d)\n", I have to admit that I'm worried by the further lack of unwinding in case of error: We're not really good at this, I agree, but it would be quite nice if the problem didn't get worse. At the very least if the device was de-assigned from Dom0 and assignment to a DomU failed, imo you will want to restore Dom0's settings. Also in the latter case don't you need to additionally call vpci_deassign_device() for the prior owner of the device? > --- a/xen/drivers/vpci/vpci.c > +++ b/xen/drivers/vpci/vpci.c > @@ -86,6 +86,27 @@ int __hwdom_init vpci_add_handlers(struct pci_dev *pdev) > > return rc; > } > + > +/* Notify vPCI that device is assigned to guest. */ > +int vpci_assign_device(struct domain *d, struct pci_dev *dev) > +{ > + /* It only makes sense to assign for hwdom or guest domain. */ > + if ( !has_vpci(d) || (d->domain_id >= DOMID_FIRST_RESERVED) ) Please don't open-code is_system_domain(). I also think you want to flip the two sides of the ||, to avoid evaluating whatever has_vcpi() expands to for system domains. (Both again below.) > --- a/xen/include/xen/vpci.h > +++ b/xen/include/xen/vpci.h > @@ -26,6 +26,12 @@ typedef int vpci_register_init_t(struct pci_dev *dev); > /* Add vPCI handlers to device. */ > int __must_check vpci_add_handlers(struct pci_dev *dev); > > +/* Notify vPCI that device is assigned to guest. */ > +int __must_check vpci_assign_device(struct domain *d, struct pci_dev *dev); > + > +/* Notify vPCI that device is de-assigned from guest. */ > +int __must_check vpci_deassign_device(struct domain *d, struct pci_dev *dev); Is the expectation that "dev" may get altered? If not, it may want to become pointer-to-const. (For "d" there might be the need to acquire locks, so I guess it might not be a god idea to constify that one.) I also think that one comment ought to be enough for the two functions. Jan From xen-devel-bounces@lists.xenproject.org Mon Sep 06 13:28:50 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Sep 2021 13:28:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.179898.326327 (Exim 4.92) (envelope-from ) id 1mNEg1-0005l1-QY; Mon, 06 Sep 2021 13:28:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 179898.326327; Mon, 06 Sep 2021 13:28:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNEg1-0005ku-NW; Mon, 06 Sep 2021 13:28:45 +0000 Received: by outflank-mailman (input) for mailman id 179898; Mon, 06 Sep 2021 13:28:44 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNEg0-0005kk-9S; Mon, 06 Sep 2021 13:28:44 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNEfz-0004hY-HC; Mon, 06 Sep 2021 13:28:43 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNEfz-0000oV-6u; Mon, 06 Sep 2021 13:28:43 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mNEfz-0006Vx-6S; Mon, 06 Sep 2021 13:28:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=cVjaJDiCiMn+BDMSqpaPNBryK8K9OTNeYNSswEf6PBA=; b=gW5sQrHGjrxzGn9cryMQZNNVS5 SsvrzqDWhelu60nf1j5et+ODhe9+eVwwN7SuvekqKOEW69C9WpVZ6mIfjQBoEY97JEdwa/9ANkHCk k5twsOZdPUlMZfDcG8jRKAFcMSAWRLCpzg1GAVwTGshPppOYCBIqYBCOJl7lExEBTq+0=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 164859: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=edf8bc6d24c6f490c27de3144eee88f1ca40ce6a X-Osstest-Versions-That: ovmf=cae735f61328d64e2e8991036707b9e78c0f5f63 From: osstest service owner Date: Mon, 06 Sep 2021 13:28:43 +0000 flight 164859 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/164859/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 164674 build-amd64 6 xen-build fail REGR. vs. 164674 build-i386-xsm 6 xen-build fail REGR. vs. 164674 build-i386 6 xen-build fail REGR. vs. 164674 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf edf8bc6d24c6f490c27de3144eee88f1ca40ce6a baseline version: ovmf cae735f61328d64e2e8991036707b9e78c0f5f63 Last test of basis 164674 2021-08-31 02:56:52 Z 6 days Failing since 164686 2021-09-01 03:03:43 Z 5 days 67 attempts Testing same since 164806 2021-09-04 09:41:21 Z 2 days 41 attempts ------------------------------------------------------------ People who touched revisions under test: Anthony PERARD DunTan Gary Lin Hao A Wu Jim Fehlig Lin, Gary (HPS OE-Linux) Loo Tung Lun Loo, Tung Lun Mark Wilson Marvin H?user Michael Kubacki Rebecca Cran Wenxing Hou Wenyi Xie jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 302 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Sep 06 13:29:24 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Sep 2021 13:29:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.179905.326341 (Exim 4.92) (envelope-from ) id 1mNEge-0006JE-4i; Mon, 06 Sep 2021 13:29:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 179905.326341; Mon, 06 Sep 2021 13:29:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNEge-0006J7-1M; Mon, 06 Sep 2021 13:29:24 +0000 Received: by outflank-mailman (input) for mailman id 179905; Mon, 06 Sep 2021 13:29:22 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNEgc-0006Ix-7m for xen-devel@lists.xenproject.org; Mon, 06 Sep 2021 13:29:22 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id cecdbee3-918a-4524-9703-f2dc5c642011; Mon, 06 Sep 2021 13:29:21 +0000 (UTC) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05lp2113.outbound.protection.outlook.com [104.47.18.113]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-4-YjVHstorM1SLv8-ofyYDbw-1; Mon, 06 Sep 2021 15:29:19 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VE1PR04MB6479.eurprd04.prod.outlook.com (2603:10a6:803:11c::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19; Mon, 6 Sep 2021 13:29:17 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4478.025; Mon, 6 Sep 2021 13:29:17 +0000 Received: from [10.156.60.236] (37.24.206.209) by PR3P250CA0029.EURP250.PROD.OUTLOOK.COM (2603:10a6:102:57::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Mon, 6 Sep 2021 13:29:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cecdbee3-918a-4524-9703-f2dc5c642011 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1630934960; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=G3OCOX0BR8N3bNEaVRo41nPsf4k/oWlMETypATXxQfg=; b=ddVWkeYSNY6jZwDbzgb4goYuXhZThyaQGuXVxaeBmzR/dSHC/vutwANf6oQqzddMYbpDWP NqB+eouYkFC7MUdDzhzAntgIlEhcHa+MobSo1b48ZoDwLjjc0cvogGBp/8CWnzAM55vCFD AqoHpAYKabobOMxJLKcOlINxTspS+Bk= X-MC-Unique: YjVHstorM1SLv8-ofyYDbw-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TrwQPq9DNZIcxM2j9SlRty6gLcEdn6aTmreLx2n/ifvO3fFzkC2UGQrnAAnkiagTFMmsDBfjFSwKvWI3kV/GdE+92lokw2uFPoUQCRyikrKQNcxx2ewu8ziEpucyVR2E/W8iE4IZitLcyJfCF8sJX+P1jaHadcrP1nsc8aZMLnsueNdh3ui0EX5sHhwvHFpT85nskDWClXeJ03GPchkYXyizZijAxKzyuojY2ZHqLz5O5YuJxx6fOxOXuNoNsIGnv+Ndn8JoQmYh9hM2kKhvOhXV5pLi49uDHJ8u8cjytuiJLQvIJ+3bZaj/o45MIqQA6MSnequgFhUXQxKgTYsEDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=G3OCOX0BR8N3bNEaVRo41nPsf4k/oWlMETypATXxQfg=; b=diUTTM9UGY6I+wylvSBInV5iPwdi5k/au3IuaEB4r3sT5mzx39mzpF4WR3uzWZkbniKXe0vFCKetzJWuKPWvjLNJUUYRU9Eb3yh5seFekASTg8pFU1jcmLbGfyRsAiqDzJbKaUn4ub8XW5p5EIkHJvAwghx6acHU18Nh4eA63+gMwCrEB2nm3EVl6NigVIhGIlT5/AbsDFr3jbe5P87IQXf+UmlR/gHLE0IXNbjiWGVZ0WMKWXYigIkRC1i3xuAQqq4NpVwiXDefF0nrErO/7wh+fZiw6bFwIzQO4s5dQG48cfIUynFk1Kx6jdomkRr0R7IVo3/RzBfwVafOkJ9SSg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com; Subject: Re: [PATCH 1/9] gnttab: defer allocation of maptrack frames table To: Julien Grall Cc: Andrew Cooper , George Dunlap , Ian Jackson , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" References: <062bcbd3-420e-e1c0-3aa0-0dfb229e6ae9@suse.com> <7b8fba1a-767e-87f8-d0eb-5af5e5427bb4@xen.org> From: Jan Beulich Message-ID: <60acd486-1641-6db4-4451-247edcc11522@suse.com> Date: Mon, 6 Sep 2021 15:29:12 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: <7b8fba1a-767e-87f8-d0eb-5af5e5427bb4@xen.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PR3P250CA0029.EURP250.PROD.OUTLOOK.COM (2603:10a6:102:57::34) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 38cbc938-7c44-4dfa-f8d4-08d9713a53b0 X-MS-TrafficTypeDiagnostic: VE1PR04MB6479: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6108; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yQm0psxsr09FTyI8IrwMoJ1zG7VcnMBxQKPALDMawJ3qlVTZZ+wmhiy3XQXk8ruKpc2YpqzwG1j9pTa7zdS5aj5/AM0vtPGkL7Nz5JZkxoL2jBSE92sYI99kx2duyM37j8XRone7OfVxofrz90y/m5vNoTOP6gY1iqD9b2riYpxuHUIuA9SPPgO5OAVYBZG3qWCbk3GfxmhpMciKy5xT5+ZTm7zhSyoW9myL0g/KpNmwQnhvB1ktB+2SMAqcuuhBWc1bme540MVQbwAxVnkY4dBZSzpQKWwb6OhHD4pJK8zdatG8+E7BOc85USAxxBWgei8AAgtWbUHeQXyLwYpVBVv60VVs4IOSzZPFK8/Vpn7817AkdcedTK5zU1a2vhGE+qy67ViS1D60efgNLtxuC/664wI0wgL5GgeDGRxERbcJPYJDIApjiYXP4429bJUBNSfjyK+GnmjbArBTsmiY4ls4tNdUQzf/1zXjqxBxOuRWeNbah9gQyuEGuuzfgqWpFDxFVJ497bX/VcNo9/dKi+Hfaoc4DTCa8RLkdZlLKWauiyEZPC0Y+Gmv5W//ufPXKZLRLh0TIF3YMClZIBeMLpVHm/Q2DlP5Rf/fV7n70yMu7jZklfcOB4xU2mdTUeIHdKigqUn3gQgoat3X8gsop9oQ7CVthzMH/zbA+zepuTCzWpAaZMczovkxeFPpj1pDqOinpfN6m9uH9PtMlBm6bmjrC+VNS4IOCkKPvjGSzT8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(346002)(366004)(396003)(136003)(39860400002)(376002)(316002)(54906003)(8676002)(38100700002)(66946007)(16576012)(6666004)(2906002)(5660300002)(36756003)(478600001)(956004)(6916009)(4326008)(66476007)(8936002)(31686004)(83380400001)(66556008)(2616005)(31696002)(53546011)(86362001)(186003)(26005)(6486002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Y3c5WUREV1orVnRNUjhyTEQxYkZpakR2bHlDOGpNTyswd05BMW5DSmdZRlA2?= =?utf-8?B?QmhaMEx4Q2I5K1BJS1VtcWV1dERDUHVPMG14T1BBY3IwWUVaYUNmWEFhSXZk?= =?utf-8?B?b000ZnFFbEZwZVEyOTlPVDkwMHNDZHRNcmRvdEhOUyt0Y3NXaEIwelBldUVv?= =?utf-8?B?MlFzcmx2MGFrQXdHTmxSWVNFRElzdUZJWHAzazBnWGY2cEhLa1BjQnFUVDB1?= =?utf-8?B?TEIvNWYrMllqczViYzBJc3U1djhqdTVFWklOSDJzSWhDRGVNaHFhcEZMdy96?= =?utf-8?B?SFcvL1o5bXJ0S2lFWmpRSGxlcWtWU2I2RkVRZEtUeURkVWc0SmtJR0NJUnor?= =?utf-8?B?TmRmL2IyUTZJK1hwd0VlR3N4Vzd1VnhUS1huY1dCZmMya1J4VTIyRG5EeEhU?= =?utf-8?B?SjhVcGptSXdScWRBYzh4aktvNDRhY0grbHZDdVZ5aTVMcU5GYWhnN2I3Q1Mz?= =?utf-8?B?YTlTLzc4VmZZMjZWR0FTOGhWMlB1emlEemtHeXcvcW5WdU9TdUkzS0xSa1pm?= =?utf-8?B?NmVSNmg3NFpvdUc1cW5jYnNIRGFtekJKWXdDeHpYYnpMRHVxaUpxVjQrTXUr?= =?utf-8?B?L2hFTmtnT0x5YVBJd0xYMWVhWnB2djI4N1MrOTdtbkl4bS9FcXNtYXJrc1My?= =?utf-8?B?YlhSallvTEN4OTRWa01QV2tJWWtlaGZvUGx1ZjdhUE1qSmJxRGFxSW93N1ZF?= =?utf-8?B?MEFCSm9SeUR3bWN0VlFhM3QxZmgvc2NkMGU3a0VJZkdEN1oxWFBCc2IzTFZt?= =?utf-8?B?N29aajB6cTVIY1NvZWVGa2xqYTAzM1Z1cE13M251d2FMc2tIUGV4Ny9Vdkl5?= =?utf-8?B?TFk3cmlHZ01ha2p3NjE0SVNicVk1Q2I3c0hnamdMZTU3cnluK09qV29rbHhT?= =?utf-8?B?K1RkNUNFSllqVGhCeHdQVTRTaUlWb3hqRyt3QXVZM0NVN3lKQnJpMlBUQjZR?= =?utf-8?B?RkhlMEtCSjBqSVRBOGp0dlBoeVZHcHdyYis2UWdWd1RiTFcxNkdrNEl1NVhi?= =?utf-8?B?YXpaQ0thRVVjRktNOEYyM2VrbEk2NUFycHNtVVQ4MmdJeHVqQnpPOHk4SndF?= =?utf-8?B?SHJIOS8rTlFwaVlZU29aeXBlYktTbzVsYlhpWTlhVTl5UXBVMlpnanlpbkdo?= =?utf-8?B?QVh3TEswYnRoQ2VVZktBUmx5VVNvdmlGaHdnUEhpMExKUGpTN2Mxc1RXQzNl?= =?utf-8?B?VWQ5ckU2MFU4QlhmTTRES2VBMVZtMDBXSmxWaXU0amlLd3hUck1PMVRnRStC?= =?utf-8?B?VGtJVVVBZUpjakZXZGJpbFdKWEVjSFhkTW5mYk44YVVwSEtzMjlIUVIzRGR3?= =?utf-8?B?MTZvN2ZLSEFKYk5DV1VHcjZ0VEhaOG1nT2dEYzY2V2d0aDBHV2ZtR1Fzb1cy?= =?utf-8?B?WEI3RmdGeHN2dldIaU9zNThlb2ZXcmZadjZpb2g2bnF2RDE1WUw4UmJiSXk2?= =?utf-8?B?dlRkMW0rOTlYb1ZMMDErdnlmM2c5TFRHUG9oSGJUNENJcnZwOHBETk90aHN0?= =?utf-8?B?WDVGUGFsaUFNOTVMWjBEOGVhMkR6VG9wanFiL3d5SHlUUWJTd2IzckpiNDcy?= =?utf-8?B?RkRXeUV6NDFJS2V2WU9mMXdIYVRieC8yeEhEVXNkZUR1NGJ3QmQ2ZGZWTHEr?= =?utf-8?B?T1IvWTY5SUh2dHRNTFIyS1dJR2dTb2IveGZYNzVVMXo3NjZ4VHI1UElsYncr?= =?utf-8?B?RWI1eDFuUWE1d29Rd2dIR0NsTzRmdnhWcDQrdGZYU3NRUDZocWtHNHBCSmpS?= =?utf-8?Q?Pg0a2RA2RZ2QOHbYsdFGUTee+1GM/cewq8prwOP?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 38cbc938-7c44-4dfa-f8d4-08d9713a53b0 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2021 13:29:17.7043 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: HTl/eKVymEaVKobkZkht67y6gbWDqjWy/3aJ+CzL8pIhbox1kixJML9x/KUfQ4tnNx5w1G90TXzyXYeQsFwlnA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6479 On 06.09.2021 15:13, Julien Grall wrote: > On 26/08/2021 11:09, Jan Beulich wrote: >> --- a/xen/common/grant_table.c >> +++ b/xen/common/grant_table.c >> @@ -633,6 +633,34 @@ get_maptrack_handle( >> if ( likely(handle != INVALID_MAPTRACK_HANDLE) ) >> return handle; >> >> + if ( unlikely(!read_atomic(&lgt->maptrack)) ) >> + { >> + struct grant_mapping **maptrack = NULL; >> + >> + if ( lgt->max_maptrack_frames ) >> + maptrack = vzalloc(lgt->max_maptrack_frames * sizeof(*maptrack)); > > While I understand that allocating with a lock is bad idea, I don't like > the fact that multiple vCPUs racing each other would result to > temporarily allocate more memory. > > If moving the call within the lock is not a solution, would using a loop > with a cmpxchg() a solution to block the other vCPU? As with any such loop the question then is for how long to retry. No matter what (static) loop bound you choose, if you exceed it you would return an error to the caller for no reason. As to the value to store by cmpxchg() - were you thinking of some "alloc in progress" marker? You obviously can't store the result of the allocation before actually doing the allocation, yet it is unnecessary allocations that you want to avoid (i.e. to achieve your goal the allocation would need to come after the cmpxchg()). A marker would further complicate the other code here, even if (maybe) just slightly ... Jan From xen-devel-bounces@lists.xenproject.org Mon Sep 06 13:33:31 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Sep 2021 13:33:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.179912.326351 (Exim 4.92) (envelope-from ) id 1mNEkc-0007yL-PA; Mon, 06 Sep 2021 13:33:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 179912.326351; Mon, 06 Sep 2021 13:33:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNEkc-0007yE-MN; Mon, 06 Sep 2021 13:33:30 +0000 Received: by outflank-mailman (input) for mailman id 179912; Mon, 06 Sep 2021 13:33:30 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNEkc-0007y8-1C for xen-devel@lists.xenproject.org; Mon, 06 Sep 2021 13:33:30 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNEka-0004oI-Is; Mon, 06 Sep 2021 13:33:28 +0000 Received: from 54-240-197-236.amazon.com ([54.240.197.236] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1mNEka-00057U-CS; Mon, 06 Sep 2021 13:33:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=APik1CbMbgF6wJTSvB432A/CGZAYI0LBfC+hISwtP1Y=; b=63RDQMgBCf/ln7NWRC2xpZ64S2 KlkhERBFLjEhXiRn5exhoxEEX8ugn8IPls5vlAQxiNgdmUzMQi+aAwsFy8vcvksAtu+6QOpPgbzdC 31yt9Kr4ens/sAyQGPVSjIsZdaRtCyg+veQ5X6JdM68OI9loOmzCh3PCGTkOJfcr7chY=; Subject: Re: [PATCH 1/9] gnttab: defer allocation of maptrack frames table To: Jan Beulich Cc: Andrew Cooper , George Dunlap , Ian Jackson , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" References: <062bcbd3-420e-e1c0-3aa0-0dfb229e6ae9@suse.com> <7b8fba1a-767e-87f8-d0eb-5af5e5427bb4@xen.org> <60acd486-1641-6db4-4451-247edcc11522@suse.com> From: Julien Grall Message-ID: <26669864-09e2-a026-67f6-1f6dc48267db@xen.org> Date: Mon, 6 Sep 2021 14:33:26 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <60acd486-1641-6db4-4451-247edcc11522@suse.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Hi Jan, On 06/09/2021 14:29, Jan Beulich wrote: > On 06.09.2021 15:13, Julien Grall wrote: >> On 26/08/2021 11:09, Jan Beulich wrote: >>> --- a/xen/common/grant_table.c >>> +++ b/xen/common/grant_table.c >>> @@ -633,6 +633,34 @@ get_maptrack_handle( >>> if ( likely(handle != INVALID_MAPTRACK_HANDLE) ) >>> return handle; >>> >>> + if ( unlikely(!read_atomic(&lgt->maptrack)) ) >>> + { >>> + struct grant_mapping **maptrack = NULL; >>> + >>> + if ( lgt->max_maptrack_frames ) >>> + maptrack = vzalloc(lgt->max_maptrack_frames * sizeof(*maptrack)); >> >> While I understand that allocating with a lock is bad idea, I don't like >> the fact that multiple vCPUs racing each other would result to >> temporarily allocate more memory. >> >> If moving the call within the lock is not a solution, would using a loop >> with a cmpxchg() a solution to block the other vCPU? > > As with any such loop the question then is for how long to retry. No matter > what (static) loop bound you choose, if you exceed it you would return an > error to the caller for no reason. I was thinking to have an unbound loop. This would be no better no worth than the current implementation because of the existing lock. > > As to the value to store by cmpxchg() - were you thinking of some "alloc in > progress" marker? Yes. > You obviously can't store the result of the allocation > before actually doing the allocation, yet it is unnecessary allocations > that you want to avoid (i.e. to achieve your goal the allocation would need > to come after the cmpxchg()). A marker would further complicate the other > code here, even if (maybe) just slightly ... Right, the code will be a bit more complicated (although it would not be that bad if moved in a separate function...) but I feel it is better than the multiple vzalloc(). Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Sep 06 13:36:06 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Sep 2021 13:36:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.179918.326362 (Exim 4.92) (envelope-from ) id 1mNEn3-000097-6Q; Mon, 06 Sep 2021 13:36:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 179918.326362; Mon, 06 Sep 2021 13:36:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNEn3-000090-3a; Mon, 06 Sep 2021 13:36:01 +0000 Received: by outflank-mailman (input) for mailman id 179918; Mon, 06 Sep 2021 13:35:59 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNEn1-00008u-Il for xen-devel@lists.xenproject.org; Mon, 06 Sep 2021 13:35:59 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNEmz-0004ro-ES; Mon, 06 Sep 2021 13:35:57 +0000 Received: from 54-240-197-236.amazon.com ([54.240.197.236] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1mNEmz-0005KV-8I; Mon, 06 Sep 2021 13:35:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=DuwvLpcFkRjxKrXDfwsHp4QlfklE89rlmF3HveJUEkA=; b=KxnoRDPGQjSREn2uBbVJS9rOn3 dzXKq1ngXnj3mM1rJbT1VSiwt0XruhakkC770maae9aWNXJW33RkOC/a+JH4DNZN7J8QY9BzSvRnd F8CJnvzqYUGjFU2TVhetf8jyRLJpofcHeJkCnIs2LiiGGoQWLsYnIBY7qzQ//ubpSjK8=; Subject: Re: [PATCH 3/9] gnttab: fold recurring is_iomem_page() To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Ian Jackson , Stefano Stabellini , Wei Liu References: <06eeea76-adf8-4f40-eced-57db1526eba8@suse.com> From: Julien Grall Message-ID: Date: Mon, 6 Sep 2021 14:35:55 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <06eeea76-adf8-4f40-eced-57db1526eba8@suse.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Hi Jan, On 26/08/2021 11:12, Jan Beulich wrote: > In all cases call the function just once instead of up to four times, at extra NIT: It is more like two because there is a else in gnttab_release_mappings() :) > the same time avoiding to store a dangling pointer in a local variable. > > Signed-off-by: Jan Beulich Reviewed-by: Julien Grall > > --- a/xen/common/grant_table.c > +++ b/xen/common/grant_table.c [...] Everything below looks a duplicate. Might be an issue in your tools? > In all cases call the function just once instead of up to four times, at > the same time avoiding to store a dangling pointer in a local variable. > > Signed-off-by: Jan Beulich > > --- a/xen/common/grant_table.c > +++ b/xen/common/grant_table.c > @@ -1587,11 +1587,11 @@ unmap_common_complete(struct gnttab_unma > else > status = &status_entry(rgt, op->ref); > > - pg = mfn_to_page(op->mfn); > + pg = !is_iomem_page(act->mfn) ? mfn_to_page(op->mfn) : NULL; > > if ( op->done & GNTMAP_device_map ) > { > - if ( !is_iomem_page(act->mfn) ) > + if ( pg ) > { > if ( op->done & GNTMAP_readonly ) > put_page(pg); > @@ -1608,7 +1608,7 @@ unmap_common_complete(struct gnttab_unma > > if ( op->done & GNTMAP_host_map ) > { > - if ( !is_iomem_page(op->mfn) ) > + if ( pg ) > { > if ( gnttab_host_mapping_get_page_type(op->done & GNTMAP_readonly, > ld, rd) ) > @@ -3778,7 +3778,7 @@ int gnttab_release_mappings(struct domai > else > status = &status_entry(rgt, ref); > > - pg = mfn_to_page(act->mfn); > + pg = !is_iomem_page(act->mfn) ? mfn_to_page(act->mfn) : NULL; > > if ( map->flags & GNTMAP_readonly ) > { > @@ -3786,7 +3786,7 @@ int gnttab_release_mappings(struct domai > { > BUG_ON(!(act->pin & GNTPIN_devr_mask)); > act->pin -= GNTPIN_devr_inc; > - if ( !is_iomem_page(act->mfn) ) > + if ( pg ) > put_page(pg); > } > > @@ -3794,8 +3794,7 @@ int gnttab_release_mappings(struct domai > { > BUG_ON(!(act->pin & GNTPIN_hstr_mask)); > act->pin -= GNTPIN_hstr_inc; > - if ( gnttab_release_host_mappings(d) && > - !is_iomem_page(act->mfn) ) > + if ( pg && gnttab_release_host_mappings(d) ) > put_page(pg); > } > } > @@ -3805,7 +3804,7 @@ int gnttab_release_mappings(struct domai > { > BUG_ON(!(act->pin & GNTPIN_devw_mask)); > act->pin -= GNTPIN_devw_inc; > - if ( !is_iomem_page(act->mfn) ) > + if ( pg ) > put_page_and_type(pg); > } > > @@ -3813,8 +3812,7 @@ int gnttab_release_mappings(struct domai > { > BUG_ON(!(act->pin & GNTPIN_hstw_mask)); > act->pin -= GNTPIN_hstw_inc; > - if ( gnttab_release_host_mappings(d) && > - !is_iomem_page(act->mfn) ) > + if ( pg && gnttab_release_host_mappings(d) ) > { > if ( gnttab_host_mapping_get_page_type(false, d, rd) ) > put_page_type(pg); > -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Sep 06 13:41:46 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Sep 2021 13:41:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.179925.326374 (Exim 4.92) (envelope-from ) id 1mNEsY-0001ms-Sh; Mon, 06 Sep 2021 13:41:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 179925.326374; Mon, 06 Sep 2021 13:41:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNEsY-0001ml-Od; Mon, 06 Sep 2021 13:41:42 +0000 Received: by outflank-mailman (input) for mailman id 179925; Mon, 06 Sep 2021 13:41:41 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNEsX-0001mf-80 for xen-devel@lists.xenproject.org; Mon, 06 Sep 2021 13:41:41 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNEsV-0004xi-Mb; Mon, 06 Sep 2021 13:41:39 +0000 Received: from 54-240-197-236.amazon.com ([54.240.197.236] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1mNEsV-0005qx-G4; Mon, 06 Sep 2021 13:41:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=Boy2zv/vfXIzRDN1u+uY3cgR2WQrfnHGiF9oilq+fg0=; b=ScdiiQJHlMAIB21htUpL6FgnEf sawNDL3sx2Bu/GhC2DPZU1ZKMGJN+DZeWa+sii/UIor4GnZ/Tw7MomWZUWHAtAJJEuis6TMPU+NJf QeUJ8iRTZM1Fk+IEbezyJzkX57uz3xRjrxBkmVW3l172VIILymcV3AlDc5OrCI+aThVc=; Subject: Re: [PATCH 6/9] gnttab: check handle early in gnttab_get_status_frames() To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Ian Jackson , Stefano Stabellini , Wei Liu References: <049c4f02-2af6-542e-cc51-5c245f33341c@suse.com> From: Julien Grall Message-ID: <194da6a8-5818-fb5f-d3f7-3b374fd3c17f@xen.org> Date: Mon, 6 Sep 2021 14:41:37 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <049c4f02-2af6-542e-cc51-5c245f33341c@suse.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Hi Jan, On 26/08/2021 11:13, Jan Beulich wrote: > Like done in gnttab_setup_table(), check the handle once early in the > function and use the lighter-weight (for PV) copying function in the > loop. > > Signed-off-by: Jan Beulich Reviewed-by: Julien Grall Cheers, > > --- a/xen/common/grant_table.c > +++ b/xen/common/grant_table.c > @@ -3261,6 +3261,9 @@ gnttab_get_status_frames(XEN_GUEST_HANDL > return -EFAULT; > } > > + if ( !guest_handle_okay(op.frame_list, op.nr_frames) ) > + return -EFAULT; > + > d = rcu_lock_domain_by_any_id(op.dom); > if ( d == NULL ) > { > @@ -3301,7 +3304,7 @@ gnttab_get_status_frames(XEN_GUEST_HANDL > for ( i = 0; i < op.nr_frames; i++ ) > { > gmfn = gfn_x(gnttab_status_gfn(d, gt, i)); > - if ( copy_to_guest_offset(op.frame_list, i, &gmfn, 1) ) > + if ( __copy_to_guest_offset(op.frame_list, i, &gmfn, 1) ) > op.status = GNTST_bad_virt_addr; > } > > -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Sep 06 13:42:32 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Sep 2021 13:42:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.179932.326385 (Exim 4.92) (envelope-from ) id 1mNEtM-0002RE-9a; Mon, 06 Sep 2021 13:42:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 179932.326385; Mon, 06 Sep 2021 13:42:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNEtM-0002R7-6F; Mon, 06 Sep 2021 13:42:32 +0000 Received: by outflank-mailman (input) for mailman id 179932; Mon, 06 Sep 2021 13:42:31 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNEtL-0002Qv-PG for xen-devel@lists.xenproject.org; Mon, 06 Sep 2021 13:42:31 +0000 Received: from mail-lf1-x12c.google.com (unknown [2a00:1450:4864:20::12c]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 6f9f0901-a3f0-434a-a066-225fbfd0f79f; Mon, 06 Sep 2021 13:42:30 +0000 (UTC) Received: by mail-lf1-x12c.google.com with SMTP id x27so13602366lfu.5 for ; Mon, 06 Sep 2021 06:42:30 -0700 (PDT) Received: from otyshchenko.router ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id j20sm746556lfr.248.2021.09.06.06.42.29 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 06 Sep 2021 06:42:29 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6f9f0901-a3f0-434a-a066-225fbfd0f79f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id; bh=1Op4eoAO59qaq+mkjX+eiujVM6Ur2TNXFe7+MnMWPAo=; b=h4C3JZ0PaIs5BAjfC12yjm/XbJG+Sg9p+OZEUfx6eyBgaJw16VkFji68h8VfPdxIED P6NK7acmk/yKEkPtyzd8dOEYML8uVsibT46B4+PTyLzRROJ9UOz50n3CKRTwqI4BtZID jYMegg7iXrsRGKkDxwGNXMUZtijc3jxaTR4SDPtzc6IhfF4/RKhw1B+8L7VqCWlFd72a Nw1aOjXB8yydiaSexP00VHw/XHaEC/OsrgKO90QMBaaRZ+NBjerGSvjiOcjwgLYsnxKN 41vUrRQsPxLno+ecJ+ts8wOK7MH7c+2sUWZ35uvbub1655t2VThcR2w8nj7iJLkWrbvY MJSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=1Op4eoAO59qaq+mkjX+eiujVM6Ur2TNXFe7+MnMWPAo=; b=dtplSFlS2iLmP9mfCONq2rU9nXDXoRV8en7BPQgB1K1/Zv+kyugvTEITYW2gK0aExV p3Q3f1e7EijKTDTVroOH+KieAtV+vXNK2z/fZDc4J7/1cbEgjxS1J5BukQN9XCpFGn5s QrdPFq5EyeUXtSiKmVjcf1h4OVXRma9z2KwdmlpslhduhExOoWu76OaRcITbzYx0Kr3J 8zRxEJyKXxW6+jqMoeUqC5YGEcaaqarCiERgmvpgsewDBm6HGakr+kLUHgdM3nBhk2Mm Fm0+tWe0p6XlIIo0vZxhq1s2n8AlimIWcCdZoBk9Vwk+2t/D7NPnX87iHgiSFO4+jaTF B/vQ== X-Gm-Message-State: AOAM531Un2z+GEK1RiKtHeqDwJTLdhla0rIIqSE+iXiZn0EpbsY3p1fN HZn+ZUL71tL95iuM/3f99MZfyVyHbBY= X-Google-Smtp-Source: ABdhPJywLRGtr+1AwJ1jlC5wYfXjRpuRgZv/48wcKg6PKsZfGss8UwtlELHpiu/sosOoKvpQOWBbWQ== X-Received: by 2002:ac2:5f78:: with SMTP id c24mr2880538lfc.554.1630935749687; Mon, 06 Sep 2021 06:42:29 -0700 (PDT) From: Oleksandr Tyshchenko To: xen-devel@lists.xenproject.org Cc: Oleksandr Tyshchenko , Volodymyr Babchuk , Stefano Stabellini , Julien Grall , Julien Grall Subject: [PATCH] xen/arm: optee: Allocate anonymous domheap pages Date: Mon, 6 Sep 2021 16:42:21 +0300 Message-Id: <1630935741-17088-1-git-send-email-olekstysh@gmail.com> X-Mailer: git-send-email 2.7.4 From: Oleksandr Tyshchenko Allocate anonymous domheap pages as there is no strict need to account them to a particular domain. Since XSA-383 "xen/arm: Restrict the amount of memory that dom0less domU and dom0 can allocate" the dom0 cannot allocate memory outside of the pre-allocated region. This means if we try to allocate non-anonymous page to be accounted to dom0 we will get an over-allocation issue when assigning that page to the domain. The anonymous page, in turn, is not assigned to any domain. CC: Julien Grall Signed-off-by: Oleksandr Tyshchenko Acked-by: Volodymyr Babchuk --- xen/arch/arm/tee/optee.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/xen/arch/arm/tee/optee.c b/xen/arch/arm/tee/optee.c index 3453615..83b4994 100644 --- a/xen/arch/arm/tee/optee.c +++ b/xen/arch/arm/tee/optee.c @@ -410,7 +410,7 @@ static struct shm_rpc *allocate_and_pin_shm_rpc(struct optee_domain *ctx, if ( !shm_rpc ) return ERR_PTR(-ENOMEM); - shm_rpc->xen_arg_pg = alloc_domheap_page(current->domain, 0); + shm_rpc->xen_arg_pg = alloc_domheap_page(NULL, 0); if ( !shm_rpc->xen_arg_pg ) { xfree(shm_rpc); @@ -774,7 +774,7 @@ static int translate_noncontig(struct optee_domain *ctx, * - There is a plan to implement preemption in the code below, which * will allow use to increase default MAX_SHM_BUFFER_PG value. */ - xen_pgs = alloc_domheap_pages(current->domain, order, 0); + xen_pgs = alloc_domheap_pages(NULL, order, 0); if ( !xen_pgs ) return -ENOMEM; @@ -938,7 +938,7 @@ static bool copy_std_request(struct cpu_user_regs *regs, BUILD_BUG_ON(OPTEE_MSG_NONCONTIG_PAGE_SIZE > PAGE_SIZE); - call->xen_arg_pg = alloc_domheap_page(current->domain, 0); + call->xen_arg_pg = alloc_domheap_page(NULL, 0); if ( !call->xen_arg_pg ) { set_user_reg(regs, 0, OPTEE_SMC_RETURN_ENOMEM); -- 2.7.4 From xen-devel-bounces@lists.xenproject.org Mon Sep 06 13:53:23 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Sep 2021 13:53:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.179946.326400 (Exim 4.92) (envelope-from ) id 1mNF3i-0004Dp-BG; Mon, 06 Sep 2021 13:53:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 179946.326400; Mon, 06 Sep 2021 13:53:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNF3i-0004Di-7e; Mon, 06 Sep 2021 13:53:14 +0000 Received: by outflank-mailman (input) for mailman id 179946; Mon, 06 Sep 2021 13:53:12 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNF3g-0004Dc-Sk for xen-devel@lists.xenproject.org; Mon, 06 Sep 2021 13:53:12 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id c5e79a4c-0f19-11ec-b0a6-12813bfff9fa; Mon, 06 Sep 2021 13:53:11 +0000 (UTC) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04lp2050.outbound.protection.outlook.com [104.47.14.50]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-19-57hMhSFSMBSVrQVWPxqeDw-1; Mon, 06 Sep 2021 15:53:09 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR04MB2958.eurprd04.prod.outlook.com (2603:10a6:802:a::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.24; Mon, 6 Sep 2021 13:53:09 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4478.025; Mon, 6 Sep 2021 13:53:08 +0000 Received: from [10.156.60.236] (37.24.206.209) by PR0P264CA0271.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:1::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Mon, 6 Sep 2021 13:53:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c5e79a4c-0f19-11ec-b0a6-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1630936390; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GhLZGAONCDDxsmgW/I/T1OjSqyvPMPUBLOx7J8nGXuA=; b=KvsoEaTyXPNlntYJgtfcZcKi7Hs1dPn+z312ZOKTuciFj83jgo8VRuLvgk3iDrqmrWB2pw 9THrqlalj5gz0WAOIwWtuWh+HjkJAmHg2U4+AmAh3mzD4nAg1eq7uCEerHnTcSVrr2CCJe OytdjxyQk638DRn9KFfbJ+RWUogtFvw= X-MC-Unique: 57hMhSFSMBSVrQVWPxqeDw-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iENllwtlBNZr9CQMofON5J4F1V5EhvxRYfNbCvWF8rQqhY/OmjJpkGKR4iz3eIiIkmmUsP82BZglQW6yftOMvW+yE7bK9H0qts0qlHDJBacet+mprGmGY0GkY2xUH+nAtSFghNAo3XqpG9g8YqmY0c5w0UEwzeKVgCnl5OPYhqYWOMq6plL26mbu9+sVb7YZJ0Fv0tdMO3FyVtlBt8JyrdvqRwGGP54H8QXNiJpPA2gmy/PL9fNqaknI8nLq2i9RDgnLb7a/kB3Ubbl4vQgnUY2PuszS3OL7ax0fenMpOtZzKEpiw/QgQQu+GFnktwlZdtKN0eicCN9SDdSMcIXhCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=GhLZGAONCDDxsmgW/I/T1OjSqyvPMPUBLOx7J8nGXuA=; b=BVtoVgWwlfrRM045Nz8GoNGZe6QFWZu7PSgbw+Fq5sFzSzJvSr212bEvmGm13Z/+P3Whhh+e55QBUjCu/6eUxKzyMQP4F5EGiyW+KUR3/SnvZshB0O2KnBwVH36VjV6uO4sbsyhLKXVJE9Q3xMUJ1Ho1QENs3zrXB1YeHnQMmyoGXjX3ytz/2HMcTKXm6XCNLGnhUBLfR54xJrcws1JC/cMQMHlsXIvrozIROk+V5uM8dYgVJs8ELUmuPfMtW5+ItGe60RhFucWWXHXJ4Jh1j4CFbCOyeFMOF0UWiQmyuMzHKyV04a+WcSZWAzicR1kUs8EzsqdHjb2R6vMhVGFWaA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com; Subject: Re: [PATCH 3/9] vpci/header: Move register assignments from init_bars To: Oleksandr Andrushchenko , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: julien@xen.org, sstabellini@kernel.org, oleksandr_tyshchenko@epam.com, volodymyr_babchuk@epam.com, Artem_Mygaiev@epam.com, bertrand.marquis@arm.com, rahul.singh@arm.com, Oleksandr Andrushchenko , xen-devel@lists.xenproject.org References: <20210903100831.177748-1-andr2000@gmail.com> <20210903100831.177748-4-andr2000@gmail.com> From: Jan Beulich Message-ID: <4007d84d-9e76-32df-58f6-af5ff26fdf6e@suse.com> Date: Mon, 6 Sep 2021 15:53:06 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: <20210903100831.177748-4-andr2000@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PR0P264CA0271.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:1::19) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 91454edf-7940-401b-bdf5-08d9713da8b3 X-MS-TrafficTypeDiagnostic: VI1PR04MB2958: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4125; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: w6fRXdngvvZMQEcXFxwtsB+i4DD+N/IBg3k/NuHplPd5zzLk7EPBKx3Qxn4sh2K1Pj2p13e0RVe0I4TPKepL6JdkcQOp71SLNLedR5ys1arHR9NFWtkyRqOjjDB5abfNehBOOek+fd25EWny4xvXJgEg6IS8XHjHjSu8TVH0+lGGABZxuXo66pgqHD6oFLKph+lEBt9sDeFfWKgD2VB93oEsvp5MtG+hHISARCT2Bo+Mq1lVEGL0O8duFRazU2vER73jKXi72NTfq7DWpLrJB4gPOFvo5i8udB5inl/C0FUsopDEvQzqblGtEKFqmkd2xeaHsU2uNEw/dyrD76ETtnDedSnntTX2ItYuaWl1nirNcVX/3D9okZCE05Gtd8CGFvXAXA4w07gOPz4CtuJbkPllwMeajXIDM3YpvGcW+sR/CRmPYEJSZ/Jj2HKrtqXTHs9HIw0cGnGoo5fxXCqIB4WygalYr5BXnH6LCIX8Fdw4Hd0uQ5QZN0gGKfTWM4NMiQSMWfP1bpO1zs63aR7LYYvC7LlWVEWusWnhk5xqZlKC7AfCg8L0292+8fLgwYtr8gpWw3AkbXL1J+1luv7KDifQ40BzUIusbVqIk5tajNEW7AF5+kaF7N4aqJjDQV4Ht2IZPHMIYKBIABUOYgUL8orGGxM6bPFVfVazAnMIKL5CqnqESvh8qHg2omvlzlaavtJipZcW3tBOBM4zXJJPuu2oa3xbXHrNNBoLW0UT5sw= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(396003)(136003)(39860400002)(376002)(346002)(38100700002)(4326008)(26005)(31686004)(53546011)(8936002)(316002)(8676002)(66556008)(956004)(7416002)(186003)(5660300002)(2616005)(66476007)(66946007)(6486002)(110136005)(16576012)(36756003)(86362001)(83380400001)(478600001)(31696002)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OTZZMWRqazhCanBaeTVJeEZQY3dwSXphWk1Ca0ZvQ0FHNktsRUgrM1FMQmZh?= =?utf-8?B?dmZncGR6VXFBdkVvdW96bzZPZ3BSQjFJckJoQnUreGhlVG10bUR3dFRVb1VP?= =?utf-8?B?UUVmRnhxVWo4c2JORVpBTlVBeXhBbnJHOWlIRGp3N1BxWGxzN0g5dnVOQ0J3?= =?utf-8?B?SGgwY2JBQmJVcXBTaHZ5Z0M5a3M3aXdENHB6bnJkWlJVeHlvU2p2aU9FTVRF?= =?utf-8?B?RnVmbndxSmhkSnhrdWVCMnNjVENLcU82d1Y1Zk8rQklwOTZHYWE4VHR4Z1hN?= =?utf-8?B?VGM4Y0lnR1R6cWp4YVVDTjBJbUtIUnJjMUxvb2JsRVB3VkVEWkFHWFNRbG00?= =?utf-8?B?TlZsS2kzeXZGNEoxVm5sSHIrMU00WSttY21JelFJMEpQUEtMamp6Z2hnbnpF?= =?utf-8?B?VnMyTXc5R3lzTnVJQkM4V0l1TW9JQ3BiUWxTM0MvK3E0bWVBd2R1dU5uQUdY?= =?utf-8?B?QThVdDNlM2dVQ3A5bU5LZGV4UnRNbWI2R3h3a1dwdSsyeWQ5cGNaaFVaSEtJ?= =?utf-8?B?cEpPLzRzenQwRjUybWxuVmh0QzNMSk9lOE5rVnpleVczOGdjK2JjRDdyVTRj?= =?utf-8?B?RVIxTHM1TitrTXhqZEM2N0hDZjUzQm5FY0ZYSWFpSlhjR05Zb1pYd2YwWWtX?= =?utf-8?B?TUl6VEh0dTkxb1dWc0x2S25pTUhGRnA4V2RnM0t5V1lGRGpqSGdtdnlxYnpM?= =?utf-8?B?Z3NtSkc1VzFOQ0dzaHJDdmlDSXFicE5zeDJoVWNiUEFjc2h3VmhKQ2hjWWlF?= =?utf-8?B?eXVwWmRVTXpPdDJJSVlFSUl6ZWpsNXV2NDlmUVhqR0tJWFZpOThpVWFzSlNB?= =?utf-8?B?ZjNMUWppTDhPT2VrUFhiaE1jR3U4ZGJqUllNUW5QSlluNndPVEVGVlF6NkR4?= =?utf-8?B?Y00zM0pXaVlzMlJvTDVuckhuU0hzcm1pTlN0WGo3ZmRMSVkydWZnR1hLUWxl?= =?utf-8?B?YnE2VjJoNXI3Q2JmMVVxV2tLQkNNcW05MmNoNzB4RndON2dkZ1g1WVhsTERS?= =?utf-8?B?U2VwWVEzMVJjWEhjT3hYUlJKS2ViNmRSQ2RYTzRhbzJMMEFsdENLRlhQZ0l6?= =?utf-8?B?a3hUT2c1d0VXbGJtMU0xTDgvTzlQc1pQK2pFMit0NFJobGZnYTltandnTDJn?= =?utf-8?B?aGZaNUVYa3pHemFCQnAxWjlvanRvK3UrbnlENTE0d0ZUZEs4cXd6TWVMVmhI?= =?utf-8?B?TlpQTWRLditSanRXdlRKb1pYeDdxNUN4c0FtckladG1XS3o1TGZPMjlBamtz?= =?utf-8?B?aW9tSyt5V0NuU203YkIxNjFXdElSL3FKdUFxQittWGthTElnU1RvMEc1NXZx?= =?utf-8?B?RUp5dE5BRWoxV25Fb2MrcUI5Q1FnUzgzVC9VOGR1QUs2WERBOFhZTnA5MzNL?= =?utf-8?B?Vi9SUzh0Z0FVRk0xc2F5WmUvblREdTVoQnhicU80R09NMUhJa3ZmZG52Y2xy?= =?utf-8?B?ZzBmdUkyd1RMSW5ld3FEdUZBZzNHSldOTUQwc0JwNGhPT2xTTWU5VkVCZlpO?= =?utf-8?B?OWRyTWV6VG1vMTZVOUJPekhiNElxS1QrZWd4WkJCK29wQzV0TXNaYjdjWWRI?= =?utf-8?B?SWtIWmhVMzRjRFhMdERqQ1NjeVZNKzdLN2QxSDk5SFhERzhrQW10UTF4dEEr?= =?utf-8?B?UEtMV0tWekwyUmJPT1E0OEExbnI1VFpQN2RielBXc0h3ZmJQaWlDY0srQ0VV?= =?utf-8?B?MHpHdTlQc1hzenhTVE5NVkd1TnFpVUJBL2Zieko0U0NockdGN2RPTThIb2RW?= =?utf-8?Q?tePr6N0jUStceAZYO+MaSie5g94FaGzszZDWi3N?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 91454edf-7940-401b-bdf5-08d9713da8b3 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2021 13:53:08.8640 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rM3Z4LV21P1n4pwaJlSRTBk9mmlMggVVkpTzzF+6jkJWK5pc+WYyUq6Pp7B3Z3cuAFBc3zf9Tmk2PeLBq9ck2w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB2958 On 03.09.2021 12:08, Oleksandr Andrushchenko wrote: > From: Oleksandr Andrushchenko > > This is in preparation for dynamic assignment of the vpci register > handlers depending on the domain: hwdom or guest. I guess why exactly this is going to help is going to be seen in subsequent patches. To aid review (i.e. to not force reviewers to peek ahead) it would imo be helpful if you outlined how the result is going to help. After all ... > --- a/xen/drivers/vpci/header.c > +++ b/xen/drivers/vpci/header.c > @@ -445,6 +445,55 @@ static void rom_write(const struct pci_dev *pdev, unsigned int reg, > rom->addr = val & PCI_ROM_ADDRESS_MASK; > } > > +static int add_bar_handlers(struct pci_dev *pdev) ... this function name, for example, isn't Dom0-specific, so one might expect the function body to gain conditionals. Yet then the question is why these conditionals can't live in the original function. > +{ > + unsigned int i; > + struct vpci_header *header = &pdev->vpci->header; > + struct vpci_bar *bars = header->bars; > + int rc; > + > + /* Setup a handler for the command register. */ > + rc = vpci_add_register(pdev->vpci, vpci_hw_read16, cmd_write, PCI_COMMAND, > + 2, header); > + if ( rc ) > + return rc; > + > + if ( pdev->ignore_bars ) > + return 0; > + > + for ( i = 0; i < PCI_HEADER_NORMAL_NR_BARS + 1; i++ ) > + { > + if ( (bars[i].type == VPCI_BAR_IO) || (bars[i].type == VPCI_BAR_EMPTY) ) > + continue; > + > + if ( bars[i].type == VPCI_BAR_ROM ) > + { > + unsigned int rom_reg; > + uint8_t header_type = pci_conf_read8(pdev->sbdf, > + PCI_HEADER_TYPE) & 0x7f; > + if ( header_type == PCI_HEADER_TYPE_NORMAL ) > + rom_reg = PCI_ROM_ADDRESS; > + else > + rom_reg = PCI_ROM_ADDRESS1; > + rc = vpci_add_register(pdev->vpci, vpci_hw_read32, rom_write, > + rom_reg, 4, &bars[i]); > + if ( rc ) > + return rc; I'm not the maintainer of this code, but if I was I'd ask for this and ... > + } > + else > + { > + uint8_t reg = PCI_BASE_ADDRESS_0 + i * 4; > + > + /* This is either VPCI_BAR_MEM32 or VPCI_BAR_MEM64_{LO|HI}. */ > + rc = vpci_add_register(pdev->vpci, vpci_hw_read32, bar_write, reg, > + 4, &bars[i]); > + if ( rc ) > + return rc; ... this to be moved ... > + } ... here to reduce redundancy. > @@ -553,11 +580,13 @@ static int init_bars(struct pci_dev *pdev) > rom->addr = addr; > header->rom_enabled = pci_conf_read32(pdev->sbdf, rom_reg) & > PCI_ROM_ADDRESS_ENABLE; > + } > > - rc = vpci_add_register(pdev->vpci, vpci_hw_read32, rom_write, rom_reg, > - 4, rom); > - if ( rc ) > - rom->type = VPCI_BAR_EMPTY; > + rc = add_bar_handlers(pdev); > + if ( rc ) > + { > + pci_conf_write16(pdev->sbdf, PCI_COMMAND, cmd); > + return rc; > } Seeing this moved (hence perhaps more a question to Roger than to you) restoring of the command register - why is it that the error path(s) here care(s) about restoring this, but ... > return (cmd & PCI_COMMAND_MEMORY) ? modify_bars(pdev, cmd, false) : 0; ... ones in modify_bars() (and downwards) don't? I was wondering whether the restore could actually be done prior to the two calls (or, in the original code, the one call), or perhaps even right after the last call to pci_size_mem_bar(). At the very least the comment further up suggests memory decode only gets disabled for sizing BARs, which we're done with at this point. Jan From xen-devel-bounces@lists.xenproject.org Mon Sep 06 13:58:54 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Sep 2021 13:58:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.179960.326414 (Exim 4.92) (envelope-from ) id 1mNF99-0004xO-1Q; Mon, 06 Sep 2021 13:58:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 179960.326414; Mon, 06 Sep 2021 13:58:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNF98-0004xH-Uf; Mon, 06 Sep 2021 13:58:50 +0000 Received: by outflank-mailman (input) for mailman id 179960; Mon, 06 Sep 2021 13:58:49 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNF97-0004xB-Id for xen-devel@lists.xenproject.org; Mon, 06 Sep 2021 13:58:49 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 3c5d87d3-169e-4820-a44f-fba01049b859; Mon, 06 Sep 2021 13:58:48 +0000 (UTC) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05lp2107.outbound.protection.outlook.com [104.47.18.107]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-29-ebv1iwU3NkmyAHjdTbZQbw-1; Mon, 06 Sep 2021 15:58:46 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR04MB2959.eurprd04.prod.outlook.com (2603:10a6:802:8::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.21; Mon, 6 Sep 2021 13:58:44 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4478.025; Mon, 6 Sep 2021 13:58:44 +0000 Received: from [10.156.60.236] (37.24.206.209) by PR3P193CA0006.EURP193.PROD.OUTLOOK.COM (2603:10a6:102:50::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.20 via Frontend Transport; Mon, 6 Sep 2021 13:58:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3c5d87d3-169e-4820-a44f-fba01049b859 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1630936727; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NbkbrBJpOYpfUoH/UPnckwv83IdFu2ZkE2MCOi9Y3VM=; b=Xvht80B43TV1ig1AtxQm6jmmM554MiLTs7KrlmURg5TbLXImbcjfZVj46m8IWWQYqQg+1A FM62FqyYr568RsoBVJzK4Yw9MDuUouw+eITYRkGFq2lZAKS3fBy+hb9cW+Q6fix5YllquE 1OUgUCN+nGh0lReYH3lVa+65QBXWAIU= X-MC-Unique: ebv1iwU3NkmyAHjdTbZQbw-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=W/98m7EE/vaNsWFlRjnTFXQoozQBocGC/8V4/k1orNkAwjibJQRUp1lDNnNb2sM52VEyzBFGnzyx3QmloZCpQ2FFL9p0YfyB3R/Lr/bAJ8SaS3AiUYagria4SHQDKFcH47deVEs9B+8djyjpj7pFxFDkDx64jOYz7vOQiuuprJozH/Q25MwlqCRGfy3rQziH+eEtNuapug0S92GLuSZYEL8M+llktfVwleylnaNUcIyclb3kV13Ep43hHrdsqnTSAklUl5bKCJEl/fjcnal9kdH38HZNQqyZesAXKBSIAX02esRoDIVqrCMKQeFeEWJZ30PyAlRaQ5Y4W2r6H7XaPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=NbkbrBJpOYpfUoH/UPnckwv83IdFu2ZkE2MCOi9Y3VM=; b=LcfZQPEIjveA2wV8SuJFoXoXOTqnZsbfYKCcp8qmggsRYlFe+QntvsRYM83YnWImj+kgqcVWfBL/Z58FEzzce5ym1fpXneVxzQS4xQtwOb5oNAARzr8Wwj6USSs/SbvJ3kKRmE4ALiynacV6TXkBkdqvEX1KEf3UCCt+DYMYKT0tnpEtr5gPTuRog+Q8edCs5c23IM+mRT54/6PfInnmVt/Vur4xBu3H0xy/8b/n5HEpTR7kI9ruGm7cO+DJuGUIYhc3VzoVOwVUKtlz0L249s2B5lWE1y+iIGRh6xDvUrFgWD9OUkivCGor69eVANoAyCKJENV2Kbhg7zzNTKLiXA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com; Subject: Re: [PATCH 1/9] gnttab: defer allocation of maptrack frames table To: Julien Grall Cc: Andrew Cooper , George Dunlap , Ian Jackson , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" References: <062bcbd3-420e-e1c0-3aa0-0dfb229e6ae9@suse.com> <7b8fba1a-767e-87f8-d0eb-5af5e5427bb4@xen.org> <60acd486-1641-6db4-4451-247edcc11522@suse.com> <26669864-09e2-a026-67f6-1f6dc48267db@xen.org> From: Jan Beulich Message-ID: <9fa952e9-086a-559f-bcd6-b1630e3bf5fe@suse.com> Date: Mon, 6 Sep 2021 15:58:42 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: <26669864-09e2-a026-67f6-1f6dc48267db@xen.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PR3P193CA0006.EURP193.PROD.OUTLOOK.COM (2603:10a6:102:50::11) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9f102340-cc8a-43f3-a1ab-08d9713e70a6 X-MS-TrafficTypeDiagnostic: VI1PR04MB2959: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GQpnch5kMXUBIn+0QNlyeh3YgQCxaGY/x8tjjta1c77M+32qhRQ/Q6z82VGuSxHmEmQJPH2xKR436cz4rXUsoDG7wPi545QnWSWH4vCStNC7s/PY5Q/BheJezpMN50tbfFiw4T/A8oXK+LwfLxL4ImwEW3Hz16uSLYoQszaSS9seE8aUypQQivHb2MXjajRvM9zkcU4iyYLMI0bq6oNz6bFymGwauAyRz61K4xfLWsUfzWiwEhFexoGPNrGMYkSgW5Qw56jhg5IIVhi1gRJD/aOKiyZats1Yvx0UEBYsvy7mL2T05fLOzMBu8Utv3gFQF0AVrTOlZ+JK1OC2J+CwCrGeluCrVoA0Y98tvgTXcfrrc/S7raEgw/QasHQ7wbWjgZpksF++COw+uCCd9ywc72wsEE/u7qI+KoJge/FciHpe3lnrYdPrDThMHP06D+FI7UHQuVqxpBJFj4zix06BwzCjQxorgvkK4pN3FWTvlSuYBE3d0uRD9PXIhJIfguyhUbXzriLsJYFYMGIza8m8McsdPTlY1uixq3ydWQMjKKtXq0xD5HPV6tdnpCHBf835nMwazDLZY2mPJwDpceJoPqaeDfx1UWe2lSHtFzYhVfv+d/ugdazig3GEjG+ZzRL/TA5Q0C7zygNTmNbvACfugGaFMAWavnXMe/Bsa5cIywSRs6Iqj/hl9pCiNaEu3FV/6GIUtVTG7DiO03xoMMsgmcUqXFL9/QTR/sjDN5EOBFU= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(4326008)(54906003)(36756003)(38100700002)(16576012)(66556008)(66476007)(508600001)(83380400001)(6916009)(86362001)(2906002)(6486002)(66946007)(8936002)(26005)(5660300002)(186003)(8676002)(31696002)(31686004)(53546011)(956004)(2616005)(316002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UHF3ejdMYlRGOFZ4VzZLbEg0WDRlWEpBZlhzQVNpKzlydXhxdUdJQkl2TXk4?= =?utf-8?B?d0oyUjN4UjhFODlyb0dxSURQazNNQTNLMC9XTGc1dGtKdHA4b09BZnQ2cHZj?= =?utf-8?B?THVoTDRPc3BEYXZTRGI2MkdBK2ZhRnp6OEYwL2NQUHgrZFhMaGl4YVZVTDVn?= =?utf-8?B?Q3F4bDdqbFFCblBsRnhTKzhrZ2RhVXdvVGlwQkREdkVvUmdzVDEycHlXbndP?= =?utf-8?B?dS8zVzhBZUJLZTFBRHVJZHg1RmdTYmF4cS9xbEZGbmFmVVlocVhVSWRLdGxF?= =?utf-8?B?eWNBN1RsbmhJKzNNZTFSdi9wZXZNR0JrbVA0L01oQjJlUm5QcmY3YUYzMzVJ?= =?utf-8?B?dElwNEd1YSthTU12dzlWejdLd3VacllOT0w4c0luNXI5NzI3YWh4NkZtQUZ6?= =?utf-8?B?MUZDZDFXVmV5VXNXWjRTeXU1Wm5HYk1YZVdmRlVoZzQ0bGVKUUo1SUpXeHhU?= =?utf-8?B?ZkdJbkJHbVc2dmFVOWUvdFRVKy9vTGt1ZVlaZzB3RkxzZm1YMnVOVUlpYW1a?= =?utf-8?B?NVoyU08xbnhBaGcvVnNVL0Z3Rmc5RjdXakpTdXc4TUpnck1mZktkNm01VlJn?= =?utf-8?B?MXM0Vkp6REYwOHd4RmI0Z3lBcm8rei9QSTdRY3BvdW05TDFhdEdPa25uVnM3?= =?utf-8?B?NkZtZTJiTjJkSUcvZ1FVYjlUekc0bXpHcnpKT1g1SC9VOFlKMlRvTXN4NFZH?= =?utf-8?B?TlkzUkFmKzZobTNoYUtEYlBjOFpjNFZJNkFXdG5qNEpDWFRUUnZmK3ZNRnlF?= =?utf-8?B?aGhKTDc4ZTZ0RDY0T3E4d0N4Q3NEaU1McmNjdWd4bWdKbFBXN1ZzclF4bytM?= =?utf-8?B?T09ZNnhCcjJ1b2RjVEh2MllIRkhpNGczamFRVThXSzR5OG5PczVkbWIwVXBH?= =?utf-8?B?bzlZUmwrNUdadld1WUxlcUVuYVZTSDdjSWJuV2VHZGhiVU1QbDhvd0hhSmNC?= =?utf-8?B?TTBpci9oQTJDM3VJcEJHV3lwbXB0SGJneXh0V05pZkwwK0l1VHZNdi9PRXN0?= =?utf-8?B?QUFRTXd3RUtYaDM5QWI0U2Q1Qi9PUTc3Sm1NVWhFNnc5TU9EbjViTVdkTlV6?= =?utf-8?B?bVQ0QzNYWjYvL3pqN2R1dVRleFA4TGQycDd1QTBNVEYxSkgxdEdQeG5CNUVD?= =?utf-8?B?M3NGM0Y1akZwODJRT0lESlZmKzRtUWl6TktWUytqUGNVWXdMNUZCMlk4VzJX?= =?utf-8?B?eUtPQ0MxTEt5MmxzREZUUVNWQkUzVDFybDlMWW9icGNwaEdQVmVzNFFEOVpU?= =?utf-8?B?UGJScnhlWVhLNjlsbHRiSVhCOHkwMndDWVROWkY4UW9JNE8yOERQVDNJSHYz?= =?utf-8?B?TTJNVTkxV2VNMVl6RnAyZ0Z3OVRtUGsrRTdDMGpVS1YyMDVGVUozQnlJa243?= =?utf-8?B?ZGRKdUZRbHpWaEwwZUhOVEIvSDcwajgvdXBNV3VkK2pGNkhDdXVRR1NBcHR4?= =?utf-8?B?bUM4dm5oSWxNeC9vMm1wbXE4d2tQSHpCaHJNaGZ5aGdGdFBDWitIdEVKSGtW?= =?utf-8?B?QUhqeEtwdGZINEdxMlhkZjlLbjkzN213OVF1dFFBelA4blZwY09oRVVDL0lZ?= =?utf-8?B?QmpkNjFtb1dqelU4VThiNkgyUE9BN0pVdE5obmhQL2pKbnNMeVp3dDg2Rk9H?= =?utf-8?B?ZXJzajhxekh3V0dXUEFrRkJaTGdvYnhUY3ZlYVRTZE5uUVRVU0cwSElDY0hW?= =?utf-8?B?eElreU51OUkwTFlIaTZrRU93bGJLZHhPT1FVV043Y3pxMXFERXVXaTRCemc4?= =?utf-8?Q?zQP0qNiX4T1HvYfO2LeMOwufv9VXfg/BV3VVvVw?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9f102340-cc8a-43f3-a1ab-08d9713e70a6 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2021 13:58:44.3974 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: A0DeTbpVrGQo58ekRmMSxmp8ivech/v0qGO1a9wCYTEIv44fzj/IXOH4dtofQ653bjYV8mM6DxhGSsf28KOI8Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB2959 On 06.09.2021 15:33, Julien Grall wrote: > On 06/09/2021 14:29, Jan Beulich wrote: >> On 06.09.2021 15:13, Julien Grall wrote: >>> On 26/08/2021 11:09, Jan Beulich wrote: >>>> --- a/xen/common/grant_table.c >>>> +++ b/xen/common/grant_table.c >>>> @@ -633,6 +633,34 @@ get_maptrack_handle( >>>> if ( likely(handle != INVALID_MAPTRACK_HANDLE) ) >>>> return handle; >>>> >>>> + if ( unlikely(!read_atomic(&lgt->maptrack)) ) >>>> + { >>>> + struct grant_mapping **maptrack = NULL; >>>> + >>>> + if ( lgt->max_maptrack_frames ) >>>> + maptrack = vzalloc(lgt->max_maptrack_frames * sizeof(*maptrack)); >>> >>> While I understand that allocating with a lock is bad idea, I don't like >>> the fact that multiple vCPUs racing each other would result to >>> temporarily allocate more memory. >>> >>> If moving the call within the lock is not a solution, would using a loop >>> with a cmpxchg() a solution to block the other vCPU? >> >> As with any such loop the question then is for how long to retry. No matter >> what (static) loop bound you choose, if you exceed it you would return an >> error to the caller for no reason. > > I was thinking to have an unbound loop. This would be no better no worth > than the current implementation because of the existing lock. Not quite: Ticket locks grant access to the locked region in FIFO manner. Such an open-coded loop wouldn't, i.e. there would be a risk of a loop becoming (close to) infinite. Granted this is largely a theoretical risk, but still ... >> As to the value to store by cmpxchg() - were you thinking of some "alloc in >> progress" marker? > > Yes. > >> You obviously can't store the result of the allocation >> before actually doing the allocation, yet it is unnecessary allocations >> that you want to avoid (i.e. to achieve your goal the allocation would need >> to come after the cmpxchg()). A marker would further complicate the other >> code here, even if (maybe) just slightly ... > > Right, the code will be a bit more complicated (although it would not be > that bad if moved in a separate function...) but I feel it is better > than the multiple vzalloc(). It's the other way around here - to me it feels better the way I've coded it. I don't think the risk of an actual race is overly high, the more that this is a one time event for every domain. Jan From xen-devel-bounces@lists.xenproject.org Mon Sep 06 14:02:18 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Sep 2021 14:02:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.179967.326426 (Exim 4.92) (envelope-from ) id 1mNFCQ-0006gp-MB; Mon, 06 Sep 2021 14:02:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 179967.326426; Mon, 06 Sep 2021 14:02:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNFCQ-0006gi-Gy; Mon, 06 Sep 2021 14:02:14 +0000 Received: by outflank-mailman (input) for mailman id 179967; Mon, 06 Sep 2021 14:02:13 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNFCP-0006gZ-33 for xen-devel@lists.xenproject.org; Mon, 06 Sep 2021 14:02:13 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 78630ac1-b7f9-430c-9a05-e82bf196302a; Mon, 06 Sep 2021 14:02:12 +0000 (UTC) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05lp2108.outbound.protection.outlook.com [104.47.17.108]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-6-Eyatc_WFNDCP8D4IV-zIgw-1; Mon, 06 Sep 2021 16:02:10 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR04MB7150.eurprd04.prod.outlook.com (2603:10a6:800:12a::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19; Mon, 6 Sep 2021 14:02:08 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4478.025; Mon, 6 Sep 2021 14:02:07 +0000 Received: from [10.156.60.236] (37.24.206.209) by AM4PR0501CA0060.eurprd05.prod.outlook.com (2603:10a6:200:68::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.17 via Frontend Transport; Mon, 6 Sep 2021 14:02:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 78630ac1-b7f9-430c-9a05-e82bf196302a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1630936931; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cKa39fBdUuKKjVZJgUwDa3lk0XUVFaHOI2TGt9dFD3s=; b=VYuYQG0BsbzWN+jyxdREgeQYRyjpGkkYHbqVYnG6qOIC2anAQKSL8wgN5q7Un5M7QdHm4o IeYrTq4Sn83KvBwahHb2fAq7zEsSdzTw1fS3jk31K91V9dJjt0kNf24UjeMN4BlnI/fD5u 1z2IIhpAvUeUZxOo4v57M+eWxkrYLkg= X-MC-Unique: Eyatc_WFNDCP8D4IV-zIgw-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nBbCop4iwZ/1vJQhPYwnF0RG0nIBJNsg+txUdd9x4e6zVBL6fCgspB9H6NgnFDmYmFQUhKy4CalZLwo3ZmTC7WbE2N1g9e/+tpi8wQLSCMIfb4F1g9CezJCozlIH1zxblftsIKAi4rTBanZhOCTjoqz6h/bkDjithrqfWKWFeC+0Te4NHV4LnDJT9dgAiM0RkAPBbv6itR4MYBYM/z4tOUjYKT6B6vHeuy0YZCPhtPBZghRHw/wQWlWvng8upywK7g79AyUP+hfwtRM9Fsf1Tae8LxluumwgRvi7/+KtK0Wu3OU7QhW89r2RwBfjCaORy9+vNjN/byZnDh2wgTPZOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=cKa39fBdUuKKjVZJgUwDa3lk0XUVFaHOI2TGt9dFD3s=; b=U0FhI7l3QY6+6kb7R8iCDS4voC/A/nkRC/GyVuCOxQp/j7np6B5piRyZ7pZaD9SmnNJPTBEdw0KT/xOh74I75mMvMGbxinWQoP3tDeRQcekSONcetQq4rWQHwJNjH2aRpxi1INUWYMFoVhPKcyYFsG9SJDMFGCaHzWsIqkkQgTktqnrQr765jtC4S2gwgt9ATb5Wnuqexz8npeddnUKFDRijcGqZ1ZIWy+GX7FTpdtzYdfSn8nwSx48wv3H5hZSStcrIAth8w87Lz5nfXJRn9nAvHlMxV/nq36QOtik0A6cuEUPoAePLwYGMDnNNfuqtCIKqOjbZwYUTLmlEIURxCA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com; Subject: Re: [PATCH 3/9] gnttab: fold recurring is_iomem_page() To: Julien Grall Cc: Andrew Cooper , George Dunlap , Ian Jackson , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" References: <06eeea76-adf8-4f40-eced-57db1526eba8@suse.com> From: Jan Beulich Message-ID: <5c960a54-7860-2de4-d3c3-0075740a69e8@suse.com> Date: Mon, 6 Sep 2021 16:02:06 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM4PR0501CA0060.eurprd05.prod.outlook.com (2603:10a6:200:68::28) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 88148904-6c42-46c1-acce-08d9713ee9ff X-MS-TrafficTypeDiagnostic: VI1PR04MB7150: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 906ee7+/RJst/2GwNTTyxZy9QjJaRDNHme48ltmvGZigVpShOcbraNUy1O3fvAVj1IKVZtCT3g1Qdu95cETg4BT5CHcPmNKPy5hBJ+AlRhsopb6CAdEk5WWVjfmWWc8zYn39V0sWhTrNsZpOAOLXZhXPjnxnwsdgzP3gTqcGBm8Cxbc/VKHQTRt84fNgs8y7u/jBiGsw94/IbVR80a2Sn6I9c3R4amdhtXv+OzveS17lLtXrjt/dO4d2oI9zuK/A7fAEJvX+cAmFXMfqmrCtzxDCpfPrzM4YQmBE2yXyefdLGbsyEsFLxUYMjaRrizbSAc4F9oqUqQfQiFVgTQR4gR6PJaBX5dbxJf06a/3UaYDjGDKFNvWFkdflt0bJEu8Mw0KA1gfbFT0fY4PPEBPgLPLpPsh3st46rx381Bpw6wdIxeZHitzG2WZhAZCYDv/jQbWIve5gJoUQaWyqFmRkoptOn/Ed0dUzDQZOQrDCpT+lEtCVZuQzRJ+SPS/zsMjx/gxVoSlkC5kHY0XDcsecZSUTuoumTe10EOrj6pgsiqd7UVlLovATrnn3eCGTX14Vw0QfJevwiPrsmarwPymvyaUl7zoIZo3zT20RmtO4MFYc0e5fdKyzWpzVqzVlJoR4okl3rVcCw/wr+fhwSTkwxk9kq8QcE831QMEvmfCZLcsphev6RTmU29VuHR3LK49Mb2J/Z2sNOwhEPwlRGeUzzWp+oRk9fDKYrVXnSBjF/Cw= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(396003)(39860400002)(376002)(136003)(366004)(346002)(54906003)(5660300002)(2616005)(2906002)(956004)(316002)(53546011)(66946007)(6486002)(66476007)(4744005)(8676002)(66556008)(8936002)(38100700002)(86362001)(26005)(6916009)(16576012)(186003)(31686004)(478600001)(4326008)(31696002)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?enRqRDlxTk1hMzRST0l2cHJxdFlhWXlYWFBDakZGWUowbDFITy94ZG1zelhp?= =?utf-8?B?dTVxQnVKUDBmVEN6Uk9zOWZlQUdZMEdZcG5HQmpsMzlNUmtOUjZiUm4vYmVk?= =?utf-8?B?czhaS2NSS3duYjBEUVRtbnlUWCs4eDNkS1oyV1J1QUNCV012L0ljc3VjMmlN?= =?utf-8?B?NjQzV0UyOGJLUVNQZnJ2ZXdDdDZjcmpqZnFkVlI3Z0M0SXFzWFMzOFZUa2xh?= =?utf-8?B?bHdrSTBXQXVJazcxZVVXZHlxeWFPbm9hUWE1VFhIL3RWb1JHVi91bC9sSU5F?= =?utf-8?B?RDZPN05JVjJ4UlhaMTkvOHQxNHUrWVI0RU02RmtFdllXUWt1RU5aZTQ5UDFR?= =?utf-8?B?bUwybU5UenQvcXpOS0pHeTBCS3AvZWp5ejExcEdFRnhyUnFKUnk4RXMrbXlP?= =?utf-8?B?WEhIRTJUcTlqRUtUamRKcUt1cURkaGdHUU5JdzFERjlpTHpXZ0NtRFZHVUZN?= =?utf-8?B?YXF1ZmJmeFRCY1QxWUtVL1FNVVAxSHQwNnpoUFFLaTBzN1pYYlRCbXV6RDVn?= =?utf-8?B?R3FaK2x5cUZscFRWU3JleEVRNUtyVm9YdWcvQnphZGFPZ3JtRTRMdXYvbldq?= =?utf-8?B?L3BMQWJoRTd2UUdMNVd5TTdlaC9SQnllY0wwb0VWRWtsOWhnYWw0dXZMSlo0?= =?utf-8?B?cDFKRkZ2MWJRZzh1RTdvSHlsdGx6RlhRd2YwVEdRWTM5L3AxMWl6Q2FucE5n?= =?utf-8?B?Z2lLYUdsQUFNSXFKbGRRVldVUmFsalRKc3pRVWtnZ29xR0FtdU1CT1NoRzdl?= =?utf-8?B?ZmxJZ2djSEpoMWR3YXpuWTYrVmpSN3BvSWtuZ2I0TzhsT2ZLbm5qdEt0b1M4?= =?utf-8?B?N09YRGtZbjVKNnZZdUQxT0JicFNmSGNvNmtYSEQ2V2RBbUZVUTMzTEp6TWV3?= =?utf-8?B?QzR1ZWJFNHJtOENCOWNxQ2J4RVFLWEtYT0tOc3hlWGxvNkgzNlA4OVk1MW15?= =?utf-8?B?Zm9sK3F0ZUpBbW9qTG9qN2JsVU9WVzczRTh4MWVQeC9pZG9mUnYzYUhiY3dZ?= =?utf-8?B?VTFWMmdZTDZUelZuYTJSK3AvTlZRaWpTeTFtL3U5Skp4bWh4NDAya3FielZ0?= =?utf-8?B?TG91cmlZNHJrUnFXeHVjZVR2a08yczlrM2VCSmtBdU8yQjNISDhsbkdVVk5U?= =?utf-8?B?Wjk2bXRUcis4ZWV5ZlltenhrR2h6MGVaYk8rSUEvKzhURFhFUnZyZzNTYWJu?= =?utf-8?B?ZHZoNmhrcUt6QnljbUNVdWs4cEhMU3l6SkY2NlFHZTY1czc0UzFwNk13MkhD?= =?utf-8?B?cUZPdnBYZk1UT282NGZWQ2hBYU9rblpVSTBHYjRIaVhXSWFUVXd5N2JvaHpY?= =?utf-8?B?MC82bUdhV0Z5OFd6SGNlRFFPTUxGVWNlQlFWV2tuVzlaUkRWR000bllQeXBL?= =?utf-8?B?VjlJVURzZlpvQkdaN2ZEVGlqdGtvTmxZYVJ2aXdteUFienJUT0NvWVVOdXRD?= =?utf-8?B?dHc1ZVVGdlREYVN4cnNGenNkMVRnODlJSUdNMTJ4Z0xjd2NrbjVRZkZldjdY?= =?utf-8?B?TzNsS0lVTWo4N09Ha3V3RjNSTWcyT3pTckFtcjNBenpiS3YrNGRaSUt5RFVI?= =?utf-8?B?WkF1RzVORm5hSDc2YkorakErdGRkQnZuaURtU0hGNDhWR1Y5dEtWSzdRWkor?= =?utf-8?B?U1AycFM5dFlBNFI2MzBhb3lja0VPQlgyQzlBZWlwZ3U0cUtwUFFsb1ZwcXBv?= =?utf-8?B?WHlYa2JPYzlBaTlkQjBDTUJhMk9HeS9CWXNjUkFhZlRFRmhxUUpvdElqRHpu?= =?utf-8?Q?TtAQiaQZA3C05NtNUwkADiyIWPy/KajbXDF/dOH?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 88148904-6c42-46c1-acce-08d9713ee9ff X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2021 14:02:07.8703 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 42m5QWFXHVwN7qHOwcvb287TO4mTAsGuLYUo9pMGAdzIsoJnI3w3/xZ06T7R5lCZRpDnhiC82D6RGy0/8oR+6g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7150 On 06.09.2021 15:35, Julien Grall wrote: > On 26/08/2021 11:12, Jan Beulich wrote: >> In all cases call the function just once instead of up to four times, at > > extra NIT: It is more like two because there is a else in > gnttab_release_mappings() :) Well, I was viewing things from code gen pov, not so much execution paths. And of course "two" is not wrongly covered by "up to four" ;-) >> the same time avoiding to store a dangling pointer in a local variable. >> >> Signed-off-by: Jan Beulich > > Reviewed-by: Julien Grall Thanks. >> --- a/xen/common/grant_table.c >> +++ b/xen/common/grant_table.c > > [...] > > Everything below looks a duplicate. Might be an issue in your tools? Oops, indeed - some kind of glitch. Odd. Jan From xen-devel-bounces@lists.xenproject.org Mon Sep 06 14:06:17 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Sep 2021 14:06:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.179973.326436 (Exim 4.92) (envelope-from ) id 1mNFGE-0007Jp-4z; Mon, 06 Sep 2021 14:06:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 179973.326436; Mon, 06 Sep 2021 14:06:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNFGE-0007Ji-29; Mon, 06 Sep 2021 14:06:10 +0000 Received: by outflank-mailman (input) for mailman id 179973; Mon, 06 Sep 2021 14:06:09 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNFGD-0007Jc-E4 for xen-devel@lists.xenproject.org; Mon, 06 Sep 2021 14:06:09 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id d0765f5c-35f7-48eb-a7c0-38d7e605088a; Mon, 06 Sep 2021 14:06:08 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d0765f5c-35f7-48eb-a7c0-38d7e605088a DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1630937168; h=to:cc:references:from:subject:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=dP5NkI57FysLi5fpG0vY0d9VkOPvehodDZ8TCsHz7rs=; b=e/lePDMKb88YSVyT1UCF/+7Tsz6RyIvQSpkNsz7uvqaS6JD3xYTpcmvI Nk+0ERwR1I8UiTGRqMSDv3Q6HLC8iU8pug7l2UhFFRCr9XfQx7qoIlrUc vgpxIDU+/vMO/LyZmyCjty6xvj+hveVyWSzmCsRoi07dh4i2ZXEFNlKxD Q=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: i20T5t4R1ZJa3d26qjyEsHMuRn1W1jpNe4yzzfe46ZNz1PT5dGaOdjW3307cp9wLCdOw4PsjMT Xf+0/guVrIPzMESAugdIQKIBmdM2U66COih1hkrU0WpbtXXAbZUXhZSrNX220sdnG4r8j7vkOz OCBo0XShrW146ES54FFx2rj58Cd2Rf2Z/w77Ia1JU00lT0XIkvjIhFOT/dtRgi6RRIeQENoW9s hz1aeWUy8jlnwX5H9WHOYek79JIoZ0K8tNqKWfvKGprgBajCkUsrPJFGMfnuREQBp0zjaUTI4N PNkFfkKktkreKjpiUI/s/Z/V X-SBRS: 5.1 X-MesageID: 52080161 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:xkFLT6h4cUPukwHoDc8dBVSmhHBQX1N13DAbv31ZSRFFG/FwyP rBoB1L73DJYWgqNE3I+erhBEGBKUmskaKdkrNhQ4tKOzOWx1dATbsSkbcKpgeAJ8SQzJ8n6U 4NSdkZNDS0NykGsS+Y2njKLz9D+qj+zEnAv463pB0BPGIaCdAT0+46MHf9LqQffng3OXNTLu vk2iMonUvERZ1aVLXAOpFTNNKz1uEj2aiWLiIuNloC0k2jnDmo4Ln1H1yx2QofaSpGxfMH/X LemwL0y62/u7XjoyWsllP73tBzop/M29FDDMuDhow8LSjtsB+hYMBEV6eZtD44jemz4BIBkc XKoT0nI8NvgkmhMF2dkF/I4U3NwTwu43jtxRuxhmbim9XwQHYAB89IletiA1HkwntlmOs5/L NA3mqfuZYSJwjHhj7B69/BUAwvvlaooFI5+NRjzUB3YM87Uvt8vIYf9ERaHNMrByTh8r0qF+ FoEYX1+OtWS1WHdHrU11Mfg+BEZk5DWituf3Jy/fB8i1Nt7TZEJgojtYwid047hdcAo8Iu3Z WcDkxq/Is+BfP+I5gNXNvo7KOMexrwqCn3QRavyGLcZek60kL22uvKCYoOlZaXkbwzvdYPcc f6IR9lXVBbQTOmNSTJ5uwRzizw X-IronPort-AV: E=Sophos;i="5.85,272,1624334400"; d="scan'208";a="52080161" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oICJRuD1Wix1rzV8+iChMMRYDECxQK+2Bc/XhW4aYl9uyaqm7Rcze38/T2+FhgXuXe4IDcWvfCxS9p39GIrUBjr0zE/0p4Qa8n2pGGQKREeSZJNeFNhqwwkyxXK28Z6UL/g3qfaynMouf97sWhDPy+Q56AnUDcp2yl292zsGxfh5GpIX9WwY0rZgbobu5gDZvuOKhkoZeEhb6q/n0igNMoB+0BPTtjWGDqT5LUTWa94/LNafvaPx80NTsuYpU2IdvwgtdKc/c5hEPLBM/rJ6xGN5fzlruaI6FsamV+vdxEZHJjNCOU9623+XNieUlAIu1xr6aTvXw7E1jic348/Erg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=dP5NkI57FysLi5fpG0vY0d9VkOPvehodDZ8TCsHz7rs=; b=nddb8BYhRQSx//I2snXs91d55aNAE1zhEBSvvabNUc6D+axS7/8Uv2QzNx/32H47YfLM8W0LkzmL0ALnsYJ+3zgKLN6vof+jdDs5LVdBtHePTQxZVRr52NT56HPntKs1nvyG8Js5+kZtMTxNRsHtG362aJLRiO6hMCwGJVypnjKeGEn760z+9W67ZKAEwdpkeWBezg1Plahw6YgJVnSutKKaffizerFDRv8I1HXB3oN93eYYym8QY2Yt65gG40NzrJDNJjoiKZuw0D66wLfOOjvsALFEQR6zBoGXWIIjODFoFEqDJ81OWEvTaZsFtrE7WgDrUrScmGCT7Ql8fhnL2Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dP5NkI57FysLi5fpG0vY0d9VkOPvehodDZ8TCsHz7rs=; b=Xd5F4ABKfnfSk8EoPKzG8+st5IyRaDFwRbWTyWVsweJz34TtrGXwAtvl+YvMvatlomvsfJnJuKjmS6EBnS7frfwaeXlxz6YGxJgU1URm1dgEQFs8R49o0r1oijrIaQ4Ca5+gYjyefed7VoP0PtomVTyygcO+SRtyna0DKQwHNaE= To: Jan Beulich , "xen-devel@lists.xenproject.org" CC: George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu References: <062bcbd3-420e-e1c0-3aa0-0dfb229e6ae9@suse.com> From: Andrew Cooper Subject: Re: [PATCH 1/9] gnttab: defer allocation of maptrack frames table Message-ID: Date: Mon, 6 Sep 2021 15:05:28 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 In-Reply-To: <062bcbd3-420e-e1c0-3aa0-0dfb229e6ae9@suse.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: en-GB X-ClientProxiedBy: LO2P265CA0250.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:8a::22) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a6d49d6d-5b04-40ff-3dce-08d9713f6555 X-MS-TrafficTypeDiagnostic: BYAPR03MB3688: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +La/BxplHFP6Ntc3uPovdy7OBfJnaV2wou+x7wSE7NdYDNU09LhPs7HGQYuJsejafF6EQHpgL1DAH1WCSvj6ut2SLF+h/F3VU9SNTN/q9NJTEh61y5As1SzN7jEGCOR53ol2eNB7bBARFU/bq9JTWHc3bF645btDuE6z9o0SZCxEBOdAd28vS6inaeocCAGTuFX7NQSEN60LNmWAA59ksf6h+wZh+kXbbep5UCAjbCiaviDX1XpXOjjdZH0+PTFi7phgTyn6HCmrdO8s2LewwVYLfz+UP3XAfQPbseMcQty4QE0KLpJ8rrmUyf04gfKp7gqSDbgVCZLXYNG9Mr++1P+CUpEtZSQ9e2+LGVpcI4O7mBWOzxSdFRzA3Svinn2ar58v5XFcl9rmOJTfbsldV0pONNmHLs2rQe/vGd4I4OjeM2m4Yt4Gts7G3zRk6quYEbGIkphPUuwQK/X5bOEYUcv5vsxiaQCDLDjcwLPM8L8ylXCwviMLNIuj979t4mVQWOKM+XJ+yL2+34Uwpmsm/BeD32S/+GRFTVxakuU3qpI1op6zTALa4Vw7ytRH+wP7TxjRGmU3Tm/Ci3onRxxYjVOynvl3cnP2pbcup2AijlDw7m50Qc8LVa0e5wpD7u5bVwKqe8sIfqmnQbDEWcuLwSnSPpCa9nTxFoVaZVleMrcZw5VAb0lIspw/2WaWRUCXjoGujKrbQNeToW/B5B+WegVLITT0XPuXLIgN79g0OmU= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(136003)(376002)(346002)(366004)(39860400002)(6486002)(55236004)(31696002)(86362001)(53546011)(110136005)(2616005)(66476007)(54906003)(66556008)(186003)(956004)(6666004)(8676002)(66946007)(316002)(4326008)(16576012)(5660300002)(8936002)(478600001)(31686004)(2906002)(26005)(36756003)(38100700002)(83380400001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q0NJWHg5K1FrSVpsK0tVRUVLeDlJcG1KU2laY2RhVno3VUhON2ZhdnpXcHdW?= =?utf-8?B?aXcwOXBnVkhyVnZCRkgyU3pCTFhxUjhmRk9iZ1dSMmszRTRJSjhpcFdobDZC?= =?utf-8?B?RGt2WUFTNmZWM0xPT3NuTzdtOFJWdWZTalNCYWxhNWdwWk4xWDB2cXBGSnBl?= =?utf-8?B?eklVQnJHYU9JNGNPdCtLZ3VRR1V0b0l4QU5qUER6WW5ib09mU0srZFBqRnFj?= =?utf-8?B?VkdRMGl6TStuWkh5MEdlWFBIeVlkRUZqaHZucFBBaTVicXBlamVKamV5MmhS?= =?utf-8?B?QitEUk1CTTNhZ0tCb040MVdtWVZFN3d1bExKK05qOENOai9sMUdPdmExNFFD?= =?utf-8?B?NUZtaGtWSXVlTko3aVRob3V3dk1HY2xlNEo4RHRuN3hCbE85RTVlaUtOUTVG?= =?utf-8?B?Z0g2ZklKL09xQjJKY2RmYkJReG1Qb2QyYWl1NEtnT2g3RHM4dDlMZkZrUHhk?= =?utf-8?B?b0JJREpEemFwTTF3OXk4Uk0vWjBVd3E5b2hQVVMzRnVDUUpHN1duU0NZRGlR?= =?utf-8?B?TnRDN3FJRm1Ha0lHUVpSbmtsNVgwRzRwTGoxN1pJd3EzKzUxY29pQ1doV0Qz?= =?utf-8?B?U2VOb01ON2xNVlFUeTBaTnUrYWd5Uk1menU0ZzV5eDg2YzdIVStya3lWcVVh?= =?utf-8?B?eGJtNlRpcW5KUlNPZVkveGJDOTExZFJsQm5sbTJYWklOcHdDWml2S1orVkFG?= =?utf-8?B?OXJ0a1h4RWc3MHlXKy9kc0ovZGozdytCL2JvZE5vdHhJUGZoanZkbUplQUtD?= =?utf-8?B?MlF3SHdVNk9qZFllYjZVWlhsYk5CSHZiUlFTSVNNaUNSMTluYlRWZVBrcXgy?= =?utf-8?B?aXE5ckcyeDZnS0NvYys2a0tsOWJmRnN1QXdLZFVKNGZMZXJUMURFVEZYMDdu?= =?utf-8?B?bkxQcjI0dkRCZGM5cUJ0c2RYb2loR0g5elpzRnVaSjN0R0RxZThrSnlmQnBF?= =?utf-8?B?ck91UWpDdzRLcTl0bGc3RXlobnVPWHRrdjUzSU9mRGczZi9kSlhtMldSSVRn?= =?utf-8?B?bThFZTlqZmZHY2p6WnZmdFY1eXM5NUxUQXFSL0ZIU2Z0dnR2Nk96QWRxM0Rk?= =?utf-8?B?c2hTaGgwb2lLSUhZWVZ2TGRQdlJucVVoQXlROTc4VjQwNlZuV1ZUZXhyRzhD?= =?utf-8?B?VXBXMWI2aHpNWS9jZ0Z6YVQzb3I4Vm1HQ2N0bGdtV0dLUzZCUThzVEYvdXJE?= =?utf-8?B?VGtaajVtSTRpK3E2blk0STZsUWh2Ti9sVlZIMDF4cUdvZmg4bUJsTTY4c1Vq?= =?utf-8?B?ZnpBMlBMNWNZQmllcVQrSldCb1hDUmdON0ZrWjZSTWI1WHNRWjlNUmJpL0Jp?= =?utf-8?B?NkJZY2F3VlRnWTEwRkRNZldMQ2hjckh4K1djVS91NTFvNmlXclZKdnRmSDd5?= =?utf-8?B?ZUxkelo4ZG56aTg0NGJtTFkzTmxsWU12dU40bGUvNHJKM1V0eGJQaUZPQ2Zj?= =?utf-8?B?OGxiQlV1NGZzaWtpb0lZQU1uWDVLU3c0b3Y3Qjh2TlhLTXpRVG93QmRKaFdq?= =?utf-8?B?TlRzMXB0VTkzOEpWazJXcFVkK1JpZ2hSTFR0RXloWGpkVkxYa2gwOWppYnRZ?= =?utf-8?B?eUF4L1lZUDZyUWJyV3V2eVRCbytEeHFCTVphMmV1WThwb21jelhqNXlJOTVI?= =?utf-8?B?R2lxOENKWUkrYVlUbjdmN2lzYlk0WXBVejZ2ZkRhU3F1d0k3bm5oMnFKbGlC?= =?utf-8?B?K2ZrNHdUSDhaWE1aTTRMa044NlhZTUZtTnZLbXpzZDM2eFZ2M29WcDgxYXUw?= =?utf-8?Q?IQmQYD+E9gKEW9Qb9U+n+Zwy/G1S7+V6xjhmKPM?= X-MS-Exchange-CrossTenant-Network-Message-Id: a6d49d6d-5b04-40ff-3dce-08d9713f6555 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2021 14:05:34.7748 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: dX1LEfbM2fED8zEFrlDH58w2WQ/yb/6FfwrLBPjGAtmzn/83luso7XKX/E4Pp2779IsXCeV2TSsNX1C5XoEL/xt4EY59kYzinFjB5pSmYk0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB3688 X-OriginatorOrg: citrix.com On 26/08/2021 11:09, Jan Beulich wrote: > By default all guests are permitted to have up to 1024 maptrack frames, > which on 64-bit means an 8k frame table. Yet except for driver domains > guests normally don't make use of grant mappings. Defer allocating the > table until a map track handle is first requested. > > Signed-off-by: Jan Beulich Nack.=C2=A0 This creates new dynamic failures outside the VM's control, therefore regressing Xen's usability. The maptrack array (and frames for that matter) should be allocated at domain creation time, like we do for most other structures in the hypervisor. Furthermore, seeing as this has come up on multiple community calls, I will remind you that it is not just Citrix as a downstream which is firmly of this opinion. This entire patch should be replaced with one that... > --- > I continue to be unconvinced that it is a good idea to allow all DomU-s > 1024 maptrack frames by default. ... defaults to something smaller for plain domUs, because this improves the general case without leaving VMs more liable to crash at runtime. ~Andrew From xen-devel-bounces@lists.xenproject.org Mon Sep 06 14:11:57 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Sep 2021 14:11:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.179979.326448 (Exim 4.92) (envelope-from ) id 1mNFLk-0000W3-T9; Mon, 06 Sep 2021 14:11:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 179979.326448; Mon, 06 Sep 2021 14:11:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNFLk-0000Vw-OE; Mon, 06 Sep 2021 14:11:52 +0000 Received: by outflank-mailman (input) for mailman id 179979; Mon, 06 Sep 2021 14:11:51 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNFLj-0000Vq-HB for xen-devel@lists.xenproject.org; Mon, 06 Sep 2021 14:11:51 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 60bd661c-0f1c-11ec-b0a8-12813bfff9fa; Mon, 06 Sep 2021 14:11:50 +0000 (UTC) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05lp2107.outbound.protection.outlook.com [104.47.17.107]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-39-g9Zj8tjBNdOf4RIkj_6ArA-1; Mon, 06 Sep 2021 16:11:45 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR04MB6302.eurprd04.prod.outlook.com (2603:10a6:803:102::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19; Mon, 6 Sep 2021 14:11:44 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4478.025; Mon, 6 Sep 2021 14:11:44 +0000 Received: from [10.156.60.236] (37.24.206.209) by PR3P193CA0009.EURP193.PROD.OUTLOOK.COM (2603:10a6:102:50::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Mon, 6 Sep 2021 14:11:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 60bd661c-0f1c-11ec-b0a8-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1630937509; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wk5cxx/2uXDEEOICbmsgCL4++M8We3UgJBTequBverE=; b=PyZimjdsg7KnKY3N6z9iRGAQkkpXopFnR4p01R85vbfIsSeIUYso/JPfzq5kYZErt+R+nw WYKviCGWffwIntw52Go3zhI0NHd0gd1ECS/bmm2iX3jY7ShBpULX+lxSt7Tn2gU6qnp7s6 0KJeVHPdHO7tM1O79VNeJ949sSmbj8Q= X-MC-Unique: g9Zj8tjBNdOf4RIkj_6ArA-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZW2PYW0XbiG3aDIDg+hQ19vOBv4fnmnjGXayQrUFvRkxfZ/FzRDHSblJMs2hrF6flgYnY5THKFjpIn1oPulDbHZl5egkIY3kAtqLEYGCYHtmIBLv/0x6vVjqjwfu76kncEJHUaGonWSyvypMcKa7wh12p7qoWbsUcyBpb62gkAGHow3iJqqPsfTM6XmZe7RgrJxQhLctDlLqjv2jxtmGQ9le2Hyvzlk29J6OIVsaflqTUnqSYYdHXlj5ySx99C9odrGPqSP1Dpsi4bh8DE9oy0/LMv/zIZh4rwg7Cjg0xhKF4o+sVgS5tSWMYIX9Dr6pmE+gkub+LUFu6jzMUMqn7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=wk5cxx/2uXDEEOICbmsgCL4++M8We3UgJBTequBverE=; b=JY++zwrXZ0+4C5WT5U9jIgby+YwDfgNw78aWSOd99wQ89otkjr35/AozkHEcNnOnxjXB4e11e2HcCnfKVOsfSQ6AOnA3vnmQD8kKzSmWYWWdPplKM9U/eiasSsEb7lcy+fwu1cUGJ6W/7mqJQtG6Jn7QeeWsLXHZCEg/cnV0m4Gbwr5C+VGrDpQYhsDss6fcWNKJRLBL/Li5uNO/oaIxaytjemykk12009zqKP+sJpq+YKs2hHzrc66gp9sbw+3m9GC7m6pJmirhwxxx1rmFe5iiVm0yyhvKU58g2HyId9Z8g9YnZBnwdW6dzOTqKfQ8tRspAC0yAdZ65Mi1mZzMKw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com; Subject: Re: [PATCH 4/9] vpci/header: Add and remove register handlers dynamically To: Oleksandr Andrushchenko Cc: julien@xen.org, sstabellini@kernel.org, oleksandr_tyshchenko@epam.com, volodymyr_babchuk@epam.com, Artem_Mygaiev@epam.com, roger.pau@citrix.com, bertrand.marquis@arm.com, rahul.singh@arm.com, Oleksandr Andrushchenko , xen-devel@lists.xenproject.org References: <20210903100831.177748-1-andr2000@gmail.com> <20210903100831.177748-5-andr2000@gmail.com> From: Jan Beulich Message-ID: <8bb58d2d-255b-96e9-50ff-529985c655d5@suse.com> Date: Mon, 6 Sep 2021 16:11:42 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: <20210903100831.177748-5-andr2000@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PR3P193CA0009.EURP193.PROD.OUTLOOK.COM (2603:10a6:102:50::14) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: cf17f6f0-582d-4da6-60a5-08d971404192 X-MS-TrafficTypeDiagnostic: VI1PR04MB6302: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gJbQd3rKPYaaWwN2SXBZhLFsr3D6TNULu2PxXCI4Lj3Jh+b4ZHuNMn9aB7lQdcP0aa77N1BUGsm1kQMN3gAe6SQ+tSZK9d9bVx49kq1F+mAcYUgGrEqtgbbt0sNAwj4YXd7w6a4TqWx0GXBwB1/8SO9WFJ2GSTnPviM/0kpW25D2R78VWuX/y74EIxZsWS2fxCfVQUERpEa7mdYWAbB2LLRbQdmPv7iTguovJ4XLsppI/Q/jbRdlNX3VuuVL5GPzf7jkhmeuFu5hXFcxbjrcAWICbjhuM2aPoVyuydJXkrMsWGtHir84c508w3oVgPkw0ZNRzUDxsWPJA6QrlExw3/Ot0tGr8EvNGGdXWVnVj3WhMyoAZXY7IgiosDteEV7xbS+PyVXrcR7dHyoXU0aGtYeS4hf8WkIQpLoUs6nnGncHkIbHlO3GSyVN4Lq0HYQn8Uq26W5YLATdHm28rvlaQ9FzlI4O/arev8kO3eZ9hQPp4IwtQzfQFjo0r5JSjl1M0tOnGGQ5o5BntJpcxCu6B0K0ii8dGGZkFb/33hZ3E2lvsR0aKaiqESItEY8pX/CdGnu2nH2z2StMVk/cejRynJtHNnQymCXez+Zp5Rsv9ZdZzLNTB1UKQwuzIUFVdxxpQKjbQrfhRnQ+2Jp5XVdhjhTjZAod6jsrU0VhcuPTlkEKoXiSPUnfebg5pOmg5PvPivyRbvypkpvyXOKxkrBqTx+kUcOVqAXl6nzmtzkS2PY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(346002)(136003)(366004)(396003)(376002)(39860400002)(31686004)(86362001)(26005)(16576012)(186003)(6916009)(478600001)(36756003)(31696002)(4326008)(7416002)(5660300002)(2616005)(956004)(316002)(2906002)(8676002)(38100700002)(8936002)(66476007)(66556008)(66946007)(53546011)(83380400001)(6486002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MWpTc0FqdVVTT29EM3R0ZGtLOGNOSUVOOGsvY00vai91MmxSeEdDOWgxYWI0?= =?utf-8?B?T3BqR1p0K3hnaUM3czI1K3E4UWg5ZnowelhCRnQyMVVFeFkxK3ZKdHBPcEFF?= =?utf-8?B?cEw2bEJiVjlUT0djTHczTnFRNWNYd3VuNXFvbVBWb2dKY2Z0anFPYmFYTUsw?= =?utf-8?B?TmJMcVdTYndsbGJrYUQrQ1lvR0k3RjN0Ty9FNTNBT1RCeXUwN2tnQW5IdTNE?= =?utf-8?B?WEJhUVpLeVFVb3lDRnVTeEtSSFNkak0vM1RGcWNYcnJiUnpNUUNnKzNybWhV?= =?utf-8?B?SVM4V0RKbmpDdTltM1V5bW5ScEliL0JvUVhaV1Y0MHB2a1Uzcm42MEltZFZP?= =?utf-8?B?NkRpQzF4S1RNT09qSkNhSGowSTZMUElvUlJHNlRQbHFQZzl0NDNIVHUwa3Zn?= =?utf-8?B?cElqVXV5bDNlMEt5aDE4NnBOaGtpMTNkOTNNVmtXMlNXb2orOUZ0ZXhFeWRX?= =?utf-8?B?ejZNOUpENVBvcUNtRUNQYldIZ3pXSXl1ZU5oZ2ZZTytmU1pWUk4xbkt0VEhs?= =?utf-8?B?V0N6QXp1MWM3QU9QWTBjMExCQTRzd3dSeG0yK1JyNVdkcmVNa09ZMmRpdnpy?= =?utf-8?B?R3Z3UVFldHRoWmxhendsclRkejFaNUZqZno4b3pxZU5hUzM4RUdsbXZvRkFH?= =?utf-8?B?c3JRWnZZdHYzWGljRDQ4Rnp6MlZqb2xHUFdwdG03bHR2dkNCdnFyYSt6eS9P?= =?utf-8?B?ZXZKZHhsNCtGNmdjRjMrQjZPdW03L29OME55SDd0RWQwOEZxS0ZBc05Ob0c2?= =?utf-8?B?N1dDenVOUmQ4VEZPcjNqcmpQVkJPMnZMUElvMnl1WXRVeGt6RGk0Yk9kM2RF?= =?utf-8?B?L1RoT2paTVY1b1BDbTBKZDhJbWdQeEVWR1RDN0Q0c2NlcEJkcEpLOEtPaFFH?= =?utf-8?B?Tk1CRnFUdDhrdzkwMkFVei8yMkRRM3h0TUtESnhEOWpYbVcwTXB5QTlBNk9M?= =?utf-8?B?L3VSUkVGbTJKZXJEbHREZ0oxbGQ2QjhITFFJWGpISkJZVlVybHY3dkc5bHBj?= =?utf-8?B?Z1M1ZzRhU1cvcEF3Mi9FMHlPUEluSWRwMmFwY1NxcldqZm50NURlNlByOVg1?= =?utf-8?B?Q2Z2QkhrbWlWWVlYb2M0SEt4NStheGV3TlBPbmdDNzloVFFGNVNrWFpjSHAr?= =?utf-8?B?Y3ZjUGtGWGl1STNMUlhQNzZsdURSVW5TV0JxY3NkUUZobmFaQWp6R1NKUkZC?= =?utf-8?B?anJ3UDBQVHdPclVjbGJyZjNVOUJhZHMxZFRqTEpISWdIM2poVXo2eEhBR3hC?= =?utf-8?B?ODR5Qk8rWFFRakpaVytsdy9Bc2JxTy9KMVJEMEN5UVQ2Z0Vwb2Y1OTFjYUZa?= =?utf-8?B?ZThkbTE2eGJCYnYxaHZsWVV3UWdQTmhVUTZ3NGpFallNejJLNWtDQ1BqWi9S?= =?utf-8?B?bElGcTRxeTZyenNlZk9NUUtDOXNZV2pNRWc3VndyYllrQ0kweEVaeUVxb1ZU?= =?utf-8?B?WktOeTBuMWxESDlnRTUyQ0NjOE1LOUxVRTJaNHBaSG1wMkFuSDlGOTd4dFFS?= =?utf-8?B?MGtEZWRJWmxLVTF2QkxDUWhlYzZUZEdZZmcvalpLbnZxUlpVbmg2djBoOWp3?= =?utf-8?B?VmUvZmhBZ05VZm9KTnlpYm9xa3QzWUo2VGlIYW44enJPeDQ3TFhEK3ZFaTVz?= =?utf-8?B?eFZLNTgwczQ2LzEyTEdTdjMveDF0cVpscHlkWWFpZkdDcW9GVlB3MHVrYUhS?= =?utf-8?B?c0VROGxPbXRya3NYbStyTG5iY0VYUzFMOEFDaW1pMUpUbWtJSS80bmFXaVNI?= =?utf-8?Q?4q7q/urLMEpl54WfPpEquZYTNFVwPuZ7LLRn8Mq?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: cf17f6f0-582d-4da6-60a5-08d971404192 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2021 14:11:44.3472 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: RlnpXi7VmkqPOlu5/3GlsTfGtmk3snBG/srXujd2aGIKInQvQltI+Ox5S0MrN/kjfxcWULp9otJj+XIkqjiXCg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6302 On 03.09.2021 12:08, Oleksandr Andrushchenko wrote: > @@ -593,6 +625,36 @@ static int init_bars(struct pci_dev *pdev) > } > REGISTER_VPCI_INIT(init_bars, VPCI_PRIORITY_MIDDLE); > > +int vpci_bar_add_handlers(const struct domain *d, struct pci_dev *pdev) > +{ > + int rc; > + > + /* Remove previously added registers. */ > + vpci_remove_device_registers(pdev); > + > + /* It only makes sense to add registers for hwdom or guest domain. */ > + if ( d->domain_id >= DOMID_FIRST_RESERVED ) > + return 0; > + > + if ( is_hardware_domain(d) ) > + rc = add_bar_handlers(pdev, true); > + else > + rc = add_bar_handlers(pdev, false); rc = add_bar_handlers(pdev, is_hardware_domain(d)); > + if ( rc ) > + gprintk(XENLOG_ERR, > + "%pp: failed to add BAR handlers for dom%d\n", &pdev->sbdf, > + d->domain_id); Please use %pd and correct indentation. Logging the error code might also help some in diagnosing issues. Further I'm not sure this is a message we want in release builds - perhaps gdprintk()? > + return rc; > +} > + > +int vpci_bar_remove_handlers(const struct domain *d, struct pci_dev *pdev) > +{ > + /* Remove previously added registers. */ > + vpci_remove_device_registers(pdev); > + return 0; > +} Also - in how far is the goal of your work to also make vPCI work for x86 DomU-s? If that's not a goal, I'd like to ask that you limit the introduction of code that ends up dead there. Jan From xen-devel-bounces@lists.xenproject.org Mon Sep 06 14:32:04 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Sep 2021 14:32:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.179987.326458 (Exim 4.92) (envelope-from ) id 1mNFfA-0003KJ-Lv; Mon, 06 Sep 2021 14:31:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 179987.326458; Mon, 06 Sep 2021 14:31:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNFfA-0003KC-Iy; Mon, 06 Sep 2021 14:31:56 +0000 Received: by outflank-mailman (input) for mailman id 179987; Mon, 06 Sep 2021 14:31:55 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNFf9-0003K6-Fo for xen-devel@lists.xenproject.org; Mon, 06 Sep 2021 14:31:55 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id cbb728e0-af9f-43bc-8888-dc28a429f2c3; Mon, 06 Sep 2021 14:31:54 +0000 (UTC) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04lp2050.outbound.protection.outlook.com [104.47.14.50]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-26-YH-nePbLM0mQl2P3n33QFw-1; Mon, 06 Sep 2021 16:31:52 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR04MB7037.eurprd04.prod.outlook.com (2603:10a6:800:125::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19; Mon, 6 Sep 2021 14:31:50 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4478.025; Mon, 6 Sep 2021 14:31:50 +0000 Received: from [10.156.60.236] (37.24.206.209) by PR2PR09CA0020.eurprd09.prod.outlook.com (2603:10a6:101:16::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.17 via Frontend Transport; Mon, 6 Sep 2021 14:31:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cbb728e0-af9f-43bc-8888-dc28a429f2c3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1630938713; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EoJ9m66Pji9O6SyXYQfehum/FULzvCHrym3EdmuH0a4=; b=BM4hAG9WNwJZ+BCCoBvTO2GKcYgSeDnEILdo8e6/s1I3CocmRFGkN6x0sI8vPI1EnV7nqE 8DgeYleszC2KmKlfSFTnCdmFWEC4Gu5Npaycqjq5AJN+GivZFBVMXiTLdWgbQ4joXfBMp8 VXtdXTjaFnyDRCNtor02GL1k72Vaysk= X-MC-Unique: YH-nePbLM0mQl2P3n33QFw-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ign0+7h1XqoCzh5q+/7D4sRdvuLgoh9mwKAcYADT0Y+A95Oa9Ci4/qgc7Dz/J+ojrKtVoyucvcuRtGC7Eh0jI/Hkuq4eIwERKRe9FrAq4eagoxqSxAIs5eTQTGrt1k9L4xzFyCy6F3spL3UhCKKpwijnkwv52BSYMsh1LGHGgJ57fbVo3Fbq2ZXjnC+QOqPph62wjcL+7IVy2dLGiDspW8ftTZqUhygH5Ff/Y5wZYW11zWHhuu6kqo2JQKwceyoIhz6P+ZUl6fGHyoBiv88G+9xwus1F1wBdfMyEHqPR3lX5IbjMjHeryWvSmNoIbC0DLuMNTXnV1O353ob8rC+M2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=EoJ9m66Pji9O6SyXYQfehum/FULzvCHrym3EdmuH0a4=; b=XQMOnuvXPFYpYBXalxwSPSNNGH0AajrCdJ6ajNR5ELdpSIIlM6MqEfYA9aICGvbKNnjRiiKO5lrvb1iOfIRN0+nktOVkSYOhTDnLgvf3LxduK4/vjKaptOmZrJN6wSowjaqgmhQtfQROfI6UroL5X8ojSMS7n0U3Az+u3hIVrstggjCR5kRDFh34bAFWlJMFwdSP+TKbwgp8L6pM8+4zJ/scfVUSEFXqJ/bZVmMcyKl6KFRYBJZ7FL50vg0tTsAVySw0+IZ/P00456zvMdpQmRQCkKITasjTES/aJRJOOEkFPGZ8DrE388+UhYnvyVZZn5+rCbnnAxGMBmMHHlZhPw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com; Subject: Re: [PATCH 5/9] vpci/header: Implement guest BAR register handlers To: Oleksandr Andrushchenko Cc: julien@xen.org, sstabellini@kernel.org, oleksandr_tyshchenko@epam.com, volodymyr_babchuk@epam.com, Artem_Mygaiev@epam.com, roger.pau@citrix.com, bertrand.marquis@arm.com, rahul.singh@arm.com, Oleksandr Andrushchenko , xen-devel@lists.xenproject.org References: <20210903100831.177748-1-andr2000@gmail.com> <20210903100831.177748-6-andr2000@gmail.com> From: Jan Beulich Message-ID: <1848521d-4179-f5ee-e3af-f4e6738f60e6@suse.com> Date: Mon, 6 Sep 2021 16:31:47 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: <20210903100831.177748-6-andr2000@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PR2PR09CA0020.eurprd09.prod.outlook.com (2603:10a6:101:16::32) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d5f45ac3-d324-499f-354a-08d97143102f X-MS-TrafficTypeDiagnostic: VI1PR04MB7037: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: U7lwUZOpVePGij1GeL+s9zkHgRRcaOStPh7AgLoJTqCMK7ckk1EEOVgb7zp9Q4Lvvmbpz+o8OK7NqqxoMhZPXxZV2F/fJ7SQvEOFfs5Syl53a8oS49DcFR5kGiErAOgYoB1BwcHLm5AeXZc0WPKhl5v1eUBXxdI5nos9AI96FFImKlpEMCRF3LHn2VYb81rXFg5DQbXj1WfQUHl7Fslso7r3qL3J69Uc79a70KG+ZKHN2A10zWyFOtQozCrW0ajKhrm+RRUQ7dJTbdh+HyBiG04yzJH0cLnVJnvOrtAL2KsY7f6Rdf1G+khZNPkeuAEZTQSxcl+q7wJVjh8b32tbo7aMFpLAjYGSJ9WZHu0S+TCQlPFXOJc8JZwAtaMJkTbphVOn2kgCIjNGXATKPssYUX6s/bUDxQghFSiZNwYZUyXg/5M0ZiguDS/IvsHPevRZipS7ayEnIixDyI6ZHP4RXv9NO2R6r7wsH8zzLXmV7cyUodgyBLhE5btmyld1m9V+D7QXZ+N0p+Y2qtf8h2x+J1DebNH/UfMIx7WJBDd60zD4u9K8jCdkAzb9EjEUtDCKhJSZOChwy1Rc7GbbjKgjP24VmdeEojHxGdEyBdxO6iMSVT0R5fBggNYsekR2KqrsleA1RZMlJi5WIDeUsDvVH5dM6wdB/+f+KPTsvCfSqg0KXdk4GuWQMaxfYEptquZYd7XZrhqMtfs3cnF/Pk8NLd2hyvPLvu1PhJTtKGzeCGs= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(136003)(346002)(39860400002)(376002)(396003)(366004)(66556008)(66476007)(8936002)(66946007)(478600001)(2906002)(83380400001)(36756003)(2616005)(186003)(31696002)(5660300002)(53546011)(7416002)(26005)(31686004)(86362001)(38100700002)(316002)(16576012)(6486002)(6916009)(4326008)(956004)(8676002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Z0x2MU9rQjQzakthaHhJVmQ1bk01RGgraVFGMDNJL2ZpVFJyY1JZeGFUdFJX?= =?utf-8?B?RUlONjFpYzlCdW5DcjVnVjBZUUx1dVZTMWQrYlpUNnovSTdWbnpDK2pxYzhz?= =?utf-8?B?RWppWU5hNklFZjMzKzFFLzZWVmNiRldudUQ4M2d6azBWZHJaWW9NZWU4L21r?= =?utf-8?B?NDBuTGxicG9XVlVjY04xVDZGZmVXbzNNTXE1TlgxU21GOHBuRTlWdXBEa1pO?= =?utf-8?B?N2VJNDJzYVQzNjFZUlpvaGR1N1BQRUt1eXNYdThsMktib0FsSVZFMFhyQzhR?= =?utf-8?B?bGZyck1odG82VGxNMGFEd3VXbThjTFFXb2c3bW05SzRYTlMzTUFJM29ma1d5?= =?utf-8?B?a2xSTlNVMVZNQzZoSHo3a3NjTnBQS0xiZDJvejE5Q1lweGk0Y085V1FONHFF?= =?utf-8?B?cFo3WEhRQ2pDMVJsNFRsNTZSZ2xJbmVLVWd5amZCRzdncGJGYnJTajAyOGNJ?= =?utf-8?B?UGtxNHd1Z2dXMkNnVVdvR0RwUVpEa0hETGlWSDAyL0pZV3RWdWRIZ1RnTGV6?= =?utf-8?B?QmdHRDloN3VOQUtFamluYjI0a2RZeGV4Nk0xMW9zNEMrLzN5eUJuRXk1bUtm?= =?utf-8?B?V1FSNEhKSDZjUzlNUjR6b1RWMXp2SHVMTTliZFlSYnY2QWxUWER4Sjh4ZUxC?= =?utf-8?B?SSt5d0o5SkQyeExxRC9JWWJkdXErbEJPbzhtbFZqc3ROZWJhYmk5bkk5czZY?= =?utf-8?B?d0ozSGc1NjdYaTNQU3YybmhUdUpyclk3Nk1Tb2ZzeUxtMkFHZ0lESkhjT3Y1?= =?utf-8?B?WVJsSjQzcUZ3cmprWkpKcFNkL1pJenA4U3BoMVpsYWE0NGpUWnRKcmZKbW9U?= =?utf-8?B?dVVvaURsNGhDMG1lMm9EMFVUK3Y4UEh1ODV1aFh0cC9hNG1aUGkzRjB0c01N?= =?utf-8?B?d1VxQVBWZE5sU0d5cUNOb3Q5RjJubXRvYklxUnV1N0Z6VGUxS1hCMVZtai9W?= =?utf-8?B?WlBtSEZSUWF6N1ZBaUROVnlESUlncFNvYzlyRDg5bzBVN3NNQXBNVVBPZk9p?= =?utf-8?B?TkVLVS95TEgwZUkrS1NiZ2tCaDljY2R6S0xhUUlkZzAvNEZscG1UN3BTN3ZK?= =?utf-8?B?cWlUZkpESHJQOTAydmwwaVdFWlB2T21ocmZFRWNJdUU0cjZ2TUZmVVQ5eWZj?= =?utf-8?B?czVtNGtwc0V4ZDZlSkhXMk13eXRDOWVqQXA2TUxCVjU4Qm1CVGN1NG5JZnNB?= =?utf-8?B?cFFtR3dHZFFCVjgxMVd2TDdCbXFlNGtIYW5QaHNWMC9tRDB3NXdCV2FKL3c2?= =?utf-8?B?SVZYQngrWW9vZElqNTZldG9SWThtQ3RFaEc5ZlUvQ0R5RmNJbzFQVGM1MEg1?= =?utf-8?B?OFJTWlBHeE5SVXB2bE9RbkZRZUc4emZHa0hRbkZhV3FjUWErN0xGWExwWi9M?= =?utf-8?B?TXlwemp5OGlZMWFhaTFzK2IwNzl5RGhpdytMMGtQVk9mMzdjZTdwSjd4eG1J?= =?utf-8?B?WTR6azZjYmUyQytEdXJiOWR3aFNFYUpjVmRrR0h5NitmZjVjNzVFNGN5WTl0?= =?utf-8?B?b0dkUXZZZDI3c2RvN0ZSMWVKSFF1Rk1idFpvOHpnNmpRK2lZajVIMlRON2lr?= =?utf-8?B?ZTQxYjhEYUdVMVhnbGlka1hlS1E1VHAzbzRYTUUxaHhaOWVYdkF3N2FKNTNp?= =?utf-8?B?WGxiTit3Q3A1RUppVXVSWGZ1Z1p1eHdGS1lGcUxNZE1zMVpRbUxCemxpK2dZ?= =?utf-8?B?OURuTVpUSnZINzNxMTl5bk45bzNkQlBuMyt0eUdCaW1MZHBqcngyK3EySG1I?= =?utf-8?Q?Yq50CZLOQ8WxK8vw3a3VJlx/SkcDGlB4KceARx0?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: d5f45ac3-d324-499f-354a-08d97143102f X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2021 14:31:49.9181 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: y82xFa4D+Nygj2ZL8d0b+X9ByfNkhzAcguHgiJvTh5Aw94D9ikVXaHkXad/3Ai/j0Ngb4Je8yP43TYTfy1399g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7037 On 03.09.2021 12:08, Oleksandr Andrushchenko wrote: > --- a/xen/drivers/vpci/header.c > +++ b/xen/drivers/vpci/header.c > @@ -400,12 +400,72 @@ static void bar_write(const struct pci_dev *pdev, unsigned int reg, > static void guest_bar_write(const struct pci_dev *pdev, unsigned int reg, > uint32_t val, void *data) > { > + struct vpci_bar *bar = data; > + bool hi = false; > + > + if ( bar->type == VPCI_BAR_MEM64_HI ) > + { > + ASSERT(reg > PCI_BASE_ADDRESS_0); > + bar--; > + hi = true; > + } > + else > + val &= PCI_BASE_ADDRESS_MEM_MASK; > + bar->guest_addr &= ~(0xffffffffull << (hi ? 32 : 0)); > + bar->guest_addr |= (uint64_t)val << (hi ? 32 : 0); What you store here is not the address that's going to be used, as you don't mask off the low bits (to account for the BAR's size). When a BAR gets written with all ones, all writable bits get these ones stored. The address of the BAR, aiui, really changes to (typically) close below 4Gb (in the case of a 32-bit BAR), which is why memory / I/O decoding should be off while sizing BARs. Therefore you shouldn't look for the specific "all writable bits are ones" pattern (or worse, as you presently do, the "all bits outside of the type specifier are ones" one) on the read path. Instead mask the value appropriately here, and simply return back the stored value from the read path. > } > > static uint32_t guest_bar_read(const struct pci_dev *pdev, unsigned int reg, > void *data) > { > - return 0xffffffff; > + struct vpci_bar *bar = data; > + uint32_t val; > + bool hi = false; > + > + switch ( bar->type ) > + { > + case VPCI_BAR_MEM64_HI: > + ASSERT(reg > PCI_BASE_ADDRESS_0); > + bar--; > + hi = true; > + /* fallthrough */ > + case VPCI_BAR_MEM64_LO: > + { Please don't add braces to case blocks when they're not needed. > + if ( hi ) > + val = bar->guest_addr >> 32; > + else > + val = bar->guest_addr & 0xffffffff; > + if ( (val & PCI_BASE_ADDRESS_MEM_MASK_32) == PCI_BASE_ADDRESS_MEM_MASK_32 ) This is wrong when falling through to here from VPCI_BAR_MEM64_HI: All 32 bits need to be looked at. Yet as per the comment further up I think it isn't right anyway to apply the mask here. Also: Stray double blanks. > + { > + /* Guests detects BAR's properties and sizes. */ > + if ( hi ) > + val = bar->size >> 32; > + else > + val = 0xffffffff & ~(bar->size - 1); > + } > + if ( !hi ) > + { > + val |= PCI_BASE_ADDRESS_MEM_TYPE_64; > + val |= bar->prefetchable ? PCI_BASE_ADDRESS_MEM_PREFETCH : 0; > + } > + bar->guest_addr &= ~(0xffffffffull << (hi ? 32 : 0)); > + bar->guest_addr |= (uint64_t)val << (hi ? 32 : 0); > + break; > + } > + case VPCI_BAR_MEM32: Please separate non-fall-through case blocks by a blank line. > @@ -522,6 +582,13 @@ static int add_bar_handlers(struct pci_dev *pdev, bool is_hwdom) > if ( rc ) > return rc; > } > + /* > + * It is neither safe nor secure to initialize guest's view of the BARs > + * with real values which are used by the hardware domain, so assign > + * all zeros to guest's view of the BARs, so the guest can perform > + * proper PCI device enumeration and assign BARs on its own. > + */ > + bars[i].guest_addr = 0; I'm afraid I don't understand the comment: Without memory decoding enabled, the BARs are simple registers (with a few r/o bits). > --- a/xen/include/xen/pci_regs.h > +++ b/xen/include/xen/pci_regs.h > @@ -103,6 +103,7 @@ > #define PCI_BASE_ADDRESS_MEM_TYPE_64 0x04 /* 64 bit address */ > #define PCI_BASE_ADDRESS_MEM_PREFETCH 0x08 /* prefetchable? */ > #define PCI_BASE_ADDRESS_MEM_MASK (~0x0fUL) > +#define PCI_BASE_ADDRESS_MEM_MASK_32 (~0x0fU) Please don't introduce an identical constant that's merely of different type. (uint32_t)PCI_BASE_ADDRESS_MEM_MASK at the use site (if actually still needed as per the comment above) would seem more clear to me. Jan From xen-devel-bounces@lists.xenproject.org Mon Sep 06 14:44:07 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Sep 2021 14:44:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.179996.326470 (Exim 4.92) (envelope-from ) id 1mNFqs-00052d-Ro; Mon, 06 Sep 2021 14:44:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 179996.326470; Mon, 06 Sep 2021 14:44:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNFqs-00052W-OZ; Mon, 06 Sep 2021 14:44:02 +0000 Received: by outflank-mailman (input) for mailman id 179996; Mon, 06 Sep 2021 14:44:01 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNFqr-00052Q-I2 for xen-devel@lists.xenproject.org; Mon, 06 Sep 2021 14:44:01 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 31cb0069-ef88-4bf1-a74b-5629dadc2d36; Mon, 06 Sep 2021 14:44:00 +0000 (UTC) Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-am5eur03lp2054.outbound.protection.outlook.com [104.47.8.54]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-8-6WtBcZGBPkyJDcJH7aE1_g-1; Mon, 06 Sep 2021 16:43:58 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR0401MB2447.eurprd04.prod.outlook.com (2603:10a6:800:53::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19; Mon, 6 Sep 2021 14:43:57 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4478.025; Mon, 6 Sep 2021 14:43:57 +0000 Received: from [10.156.60.236] (37.24.206.209) by AM0PR02CA0167.eurprd02.prod.outlook.com (2603:10a6:20b:28d::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.20 via Frontend Transport; Mon, 6 Sep 2021 14:43:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 31cb0069-ef88-4bf1-a74b-5629dadc2d36 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1630939439; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=E8XZ4I1QoHTLVYKTUoACejOGqLW+G0EiotA4aZqRjRM=; b=Rqn0F9EPF8fZG/kbo0VZBlfQ8SIU5ysN7+L3VxIlqn7Rhdjla7JdK7Q4DVWUMkPgEH/b2Y TuRMh2hZCCGBKqwT5itDIsapOgJmgVpISXAJb+16hr+z6fzWi1vPPPsB0HwITq3+NyLtgj rOM/1Qj9PpNDbDQpHcQa4uqd80apIzo= X-MC-Unique: 6WtBcZGBPkyJDcJH7aE1_g-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Bv4Dc8/gSdBkB2dl2gTnrBywWW6QecIEz/XpXvU4XJ7Iww6qSKQmalZoKzWYh8LqOd0eL1NMCx31b0m36LW+puVxmm6ziGfk9JT2iTYCs0T7gYH4HTEZYON5aJo42BHezMmXAeuDNk3z7QIklCpUE+66EvrPE8QqqLGvN5UUt6l92n9BczciVbEqRnX/p4hKd0rLk0jaT7sf0ISyLRRra/xeNQOjkL+1ID0DKzc7jukgTdCugmTDCIBQm13Cp+PMDN3fID+oTHlayuy2AqEjGp91GlqxEvMoC+3VxDDz0cPsCIR6armlB2wCM7SMwQUZX3Bi8D45LjO5ApwE3Ba+bw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=Q2f1EWZnO8vB5o8YP7/43ffRbfMbHlhAQBauZVv+dfE=; b=cuwwSlHO44Pu0CtI+5JesZm4ieE08G5ICY7KgXitP/k5l5FTMynXq0COg4IqI6XDbMN4kd8s7ffvYeDTKX7pSz5OWEUO1CEhtKWc2ve2g0roeApN5I8EtQxKilseMmWQRODjZEAbt+iPg/rW0zj85kCE5Nd81vV5GUKMG22FxPm2EgWobVD6hLbBj0B6UIjdvbwBftdL7ufju4sQojIjwL0MT9HcbJKUAnQEHi3gqvMXTbcmI+IAcf3BfIeJFrViGNIJDtkAzlHs7uowZygTM4ZD5xhDDWzQt9CHqrvt4j7m5Aoei9ftcWqRESl7iWJz9jnmTsMPVhrTfM38fa1kxQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com; Subject: Re: [PATCH 1/9] gnttab: defer allocation of maptrack frames table To: Andrew Cooper CC: George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" References: <062bcbd3-420e-e1c0-3aa0-0dfb229e6ae9@suse.com> From: Jan Beulich Message-ID: Date: Mon, 6 Sep 2021 16:43:54 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AM0PR02CA0167.eurprd02.prod.outlook.com (2603:10a6:20b:28d::34) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d3b38919-ea7c-4041-b2fa-08d97144c17d X-MS-TrafficTypeDiagnostic: VI1PR0401MB2447: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: G+slpr7YOPTee+eS13ie60O9wLJm5UCNd5s+ckkPjwLKgs/lUknJVXWeutQrha+puo9k98PSt8gK+lc+cJXp4qhg/T1RozoYrOEKZxMFZbeZ9syX+i8Hj9zu5DS46CNvkLbQwEkxm5V/QE4mHNBTuthV/mNzrAFGdbLtceSkFTZrDUp9Toiqd9U5XY1+xwLuTB2IBt4WpFE/Ar46dgHyyUKjkenM47s45I9cYJ7Q3Y8W2j0yqtJXogMaCamHTCd6oj5QwyKfpofJeHtUR9tSnf621Ztnu6g9GVxLkVGnpNl9LRX5BUJxeMLw0dQPqgUU5NWAitOQ729SXITIHQSRJQHX0fRrtwZkD4+0qe2GL/ghPNCclpLkdfUhzq+5jPl3JiBsJ30H2lYT23U0nhxT+oPtTrOwyfvPdca+eZ9ITaVClCgAt5fopTdjJs/sq5Z9IrPO5pw8/2DEFbVY6lzR9mN75AAu3HCCvw4LL8cWAAqMdRbkMV3vCqX12JPKTcZI3hNRebFGVGD06D7roXfOpH1PErmBGnLmT+Pe3vbSgnKnLCrQqxD8OEoDLr0Rhl5oEemgdGTt9/2Y6UEICeXrd6mVYdvJVtp5n0PgGPrniSGFi5OMZglhx/y0kTo3qjuuWpxpsbIPk0/I6eW1BXm09WQC+TqAVdGi4Uw411b7hzi2ekQYs7u/sRyTrjJtWyedHl7SYyTWnPmvFnq24jS24bDqap1feQRShvYl0Fs6Naw= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(396003)(376002)(136003)(39860400002)(346002)(53546011)(31686004)(26005)(31696002)(2616005)(186003)(5660300002)(4326008)(956004)(54906003)(8676002)(86362001)(38100700002)(316002)(6486002)(6916009)(16576012)(478600001)(66476007)(66556008)(8936002)(66946007)(36756003)(83380400001)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?kIhSJ/OKTAb0u/vlR0jDgW4iPgXZ1+BTzbg5S2QcF9nVeSiChr1noGjccoLe?= =?us-ascii?Q?m239xnQ1XrpLbI06VzLiy5jwJMlx2TlRUWiDr119glblLnaHmNmhJpHIDQgj?= =?us-ascii?Q?KenC3ZtNUyt/q4VAMyQPp/RdNW/FRkJEXJet2Vd6mUN01jcwCJu9hATTxf98?= =?us-ascii?Q?jdOjNBEzGOfa+Y1fFCZFp6Aiw7MfeuSMUdhm6Yr+poZoq8kXXVu2lpcVP+2K?= =?us-ascii?Q?OWvSUo98AAABYDsELHp8Mo6YvV7YYK7x+sCz6L8Kb2uQg6exr+ynHleHD3l4?= =?us-ascii?Q?HMWTWe+/zshDCDMexcpgvAgrDl1wAEHpMOBL4L9DD5NT54vJhNkmZ8VfcJxZ?= =?us-ascii?Q?BHpHAtVKR1pXkOfmGvInmYGRhNDZK7KVYdaMm+nP3teNT5Z4fZpaRPsG561F?= =?us-ascii?Q?eaL2JnFvpg+QHlLNBMl4C+ky3QSevQnt331SRZpoxbcKmJ2vMlHiDtFW4Rki?= =?us-ascii?Q?Tu1tT8yraAcnXV4SyJOtcEhukrOoW7g+ovabH6gjP1553YCewq/4Sj4FGPZA?= =?us-ascii?Q?Ueyt4DX8YX8IRCzCgfUJip1UavNp9v5BYYM07RwaFyPGMUxYbBKdB/4qgJ0J?= =?us-ascii?Q?hB9I7coOcrZBLblLAP+9gZH/mS9GhRMLZfEXvayC674dhdBeD4ycY7VtX2+t?= =?us-ascii?Q?xLAy8d5s8O6ZFfVg45TECuS/oYsB1OPNcYCX63QdcXcxOr3nNrAlZgEDOqwU?= =?us-ascii?Q?uwuSNVTwUqXSRUmk8Re0Ra55F29jUQQIdmH5W/KZqooRI+cXpvvdPndEysEQ?= =?us-ascii?Q?dQhS19WzROS7gBuyRB6RUsee+N6LTPkGQ+nNAeF5evvEt49yafRSliOf0dTa?= =?us-ascii?Q?ur7TFfHxg5kxRt4F2+4sIn9IB1cMBnUqTaCTkvOE/TKAxS0nB00l/V01WZUc?= =?us-ascii?Q?BfZvow9VSmMbLG0xixShyVOEKrvnBKPvtr3FiVvKgOOG9995LX1aGETBc4bv?= =?us-ascii?Q?rZx/gbdAYYjyIEW1ccPgRHuRmld238slGm3n8ItEpKoUJXcOGCvaBv+EOkmj?= =?us-ascii?Q?AkJcZL5BFHvz8sND4PtdUj6svxCqK2/+uFPRtl8twr4NGAl+u14gpC4bxris?= =?us-ascii?Q?4WchkeBDoYPPao4t9dMA1+fglrMvttIH0f8F2QsnYWW04uTnDgkAhLX60Qaz?= =?us-ascii?Q?2DuB+zW4tZ3wj8xUiiABFQ82vfEEb2glHZkC8kicSgchm4NCprR4BTdkXa6o?= =?us-ascii?Q?CPxevhxsUxJ6gLcElivNvDZ4JXgIoALODnqUw0Y5oVRX8vnCgbyZs1/AY9gf?= =?us-ascii?Q?5asPb7NPBNbt16bcDwqEnBJxkkbWRBOGFNi0a/B/iKMsaExpd5rU2IU6Skgc?= =?us-ascii?Q?VQjNsz1veZZkM2kRwrBbr9bQ?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: d3b38919-ea7c-4041-b2fa-08d97144c17d X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2021 14:43:56.8890 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: k7Wtow/z8Ao5wWMkELMANmih4lr7IcDNUhvNOGjV0+45MX6oZJWu+7wG5ybaqoWr5xvkVSy4X4ps4kxClz4arA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2447 On 06.09.2021 16:05, Andrew Cooper wrote: > On 26/08/2021 11:09, Jan Beulich wrote: >> By default all guests are permitted to have up to 1024 maptrack frames, >> which on 64-bit means an 8k frame table. Yet except for driver domains >> guests normally don't make use of grant mappings. Defer allocating the >> table until a map track handle is first requested. >> >> Signed-off-by: Jan Beulich >=20 > Nack.=C2=A0 This creates new dynamic failures outside the VM's control, > therefore regressing Xen's usability. As with the v2 status frames tracking array, the memory demand of the actual table will typically be quite a bit higher than that of the frame tracking table. Therefore guests already are at risk of observing failures from these paths; the increase of that risk from the change here is typically quite small. > The maptrack array (and frames for that matter) should be allocated at > domain creation time, like we do for most other structures in the > hypervisor. Structures we allocate at domain creation time are typically ones which we know will get used (to at least some degree), or where allocation can't be done later because paths this would be needed on have no way to indicate respective failure. Neither of this is true for the maptrack frame table (or the v2 status frame table, for that matter). This said, I could see us _switch_ to a policy like the one you describe, or even allow either behavior depending on some kind of setting. But then this needs to be done consistently for all forms of resources (e.g. also the gnttab v2 frames, not just the frame table). > Furthermore, seeing as this has come up on multiple community calls, I > will remind you that it is not just Citrix as a downstream which is > firmly of this opinion. No-one but you has voiced such an opinion, so far. > This entire patch should be replaced with one that... >=20 >> --- >> I continue to be unconvinced that it is a good idea to allow all DomU-s >> 1024 maptrack frames by default. >=20 > ... defaults to something smaller for plain domUs, because this improves > the general case without leaving VMs more liable to crash at runtime. Just to continue to waste memory? Or to force the admin to know very precisely how many maptrack entries a guest may need to create, such that they will neither cause large amounts of unused memory nor risk the guest running out of handles? Jan From xen-devel-bounces@lists.xenproject.org Mon Sep 06 14:47:56 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Sep 2021 14:47:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180002.326480 (Exim 4.92) (envelope-from ) id 1mNFuc-0005h6-Dr; Mon, 06 Sep 2021 14:47:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180002.326480; Mon, 06 Sep 2021 14:47:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNFuc-0005gz-Ag; Mon, 06 Sep 2021 14:47:54 +0000 Received: by outflank-mailman (input) for mailman id 180002; Mon, 06 Sep 2021 14:47:53 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNFub-0005gt-61 for xen-devel@lists.xenproject.org; Mon, 06 Sep 2021 14:47:53 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 93362bb3-838f-409e-8ef7-20d2ec162293; Mon, 06 Sep 2021 14:47:52 +0000 (UTC) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05lp2111.outbound.protection.outlook.com [104.47.18.111]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-38-ZUAwH7HBNbeAZCKnY8ICBw-1; Mon, 06 Sep 2021 16:47:50 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR04MB4445.eurprd04.prod.outlook.com (2603:10a6:803:6e::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.22; Mon, 6 Sep 2021 14:47:48 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4478.025; Mon, 6 Sep 2021 14:47:48 +0000 Received: from [10.156.60.236] (37.24.206.209) by PR0P264CA0154.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:1b::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.17 via Frontend Transport; Mon, 6 Sep 2021 14:47:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 93362bb3-838f-409e-8ef7-20d2ec162293 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1630939671; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AwH30p3wBzytY59LExMHtIgmcTmt2MaZkmO+Zyddd+c=; b=EwGChiis+7h69KPouAgKmLw9skNB1Pxkx9kvoopuNtlgJgPop5nCxIj4mtrsFf/g7s2C/N N3CWadQ4QJomH+f/9x6A4XKAwEY9hApJzcM5Hzi+UN++O+HKGo2s2UVy7AM+beb7IM6/e7 IbvqGhdlyC4eVDlDlQOKU2GJPgVfchg= X-MC-Unique: ZUAwH7HBNbeAZCKnY8ICBw-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OTfbOVi/et79nELYmQ8BNq5hkBRpCAPpse63+n3f45zLQcO1I8bXM/5C/tzpVawm+6ukcu+FIf0Jc3ix63zkfJDN3UJFSAq9xqsyY/Je2wmkaMzP4pk3aay0x8Y8hYRZOFwrNhfospa9wXWGK+tWUYX/pMhQfYHnQSxfxgc+W1wl/BrNGx/NqXjz2f21B24M+6g68TT64MjV2ls55u+lPGicIwETsMkPznfGKprZs7y2XKThPwamZSvx6TknHxSKXYL59PSKhFSixdjV/VaITlayAzak/SfWeV8Xuu4eYrwVPlV2ahX9eG1XCFLZh/E5fC8CH2gvW73y+t5tClTy9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=AwH30p3wBzytY59LExMHtIgmcTmt2MaZkmO+Zyddd+c=; b=WirNdtYCR68ybkJpUYfjzFTRXSYMd29JPEu5R9tki/RxVVLJSLHmEhlP73I5NI/8ciX3HI4T5LnidemDPT0lU8Zats97XMdLBI+GKseJOjNNg/JL4cR9y74VBi9zZ3GiamfpIEIi3YIrQPCaXx4MJSFkAX3W3psU4vq1gQFB8+Z5RJOl90J2KtndwsVa84gLvIo14t8bYLQPgC+y7inVr1nbkN0eZCm0FCS1qeZ6Mvt6FtqIhf/FndZVlerMcPZzQLTEionSWciiaC6Yi6a/EzeXQOsMHxup4Q/yapY1ZHanmRUq2yOUpsSYYlVyIWhJuRPsqwoImefsrypTsY6M+g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com; Subject: Re: [PATCH 6/9] vpci/header: Handle p2m range sets per BAR To: Oleksandr Andrushchenko Cc: julien@xen.org, sstabellini@kernel.org, oleksandr_tyshchenko@epam.com, volodymyr_babchuk@epam.com, Artem_Mygaiev@epam.com, roger.pau@citrix.com, bertrand.marquis@arm.com, rahul.singh@arm.com, Oleksandr Andrushchenko , xen-devel@lists.xenproject.org References: <20210903100831.177748-1-andr2000@gmail.com> <20210903100831.177748-7-andr2000@gmail.com> From: Jan Beulich Message-ID: <1fb1223e-005d-dc78-cd34-dc97191b316e@suse.com> Date: Mon, 6 Sep 2021 16:47:46 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: <20210903100831.177748-7-andr2000@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PR0P264CA0154.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:1b::22) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4bfab33e-f55e-4ccc-05c6-08d971454b8d X-MS-TrafficTypeDiagnostic: VI1PR04MB4445: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: r5NAMpvGAwb0UtPPZ9NXqtMPLGHTnhpPsw6J4r8lG222Q4qNZybNsgHe3mdvJOb7seTf81dBXqRJ+A21YVmil9opouWWYwnSwIePjohlsucCwDcP8feaSusvmGtnFbPrFjz7wyUJQN/7LKeH+yYziYGs8SUHFxtGnsm2aZAyelLOWyL9eccYH13hA7oQ/VjJv3JtrSL/95xxdPX77YBkUzYpyuGTLyE5O9Kl0i6v+SDrOsZQe5yXlVaq6QpIGehuj7TThVsbC3KgmjzAyThwwXj1zFblnEQHLyX517eXpzJyqxZcHAZiUZHR8A8QFPTcHj3577dGp06lm/vbqI75bEGBk6V/bMc0c+x4LLJlR4X1/WjXllFgTk9fhdTbaK6Yxxoai3lDJ3DrV7FY6aCz38+DZMlHjPa6tuKQn53IODR146nHvFME/PdXFXta+VctOMz2w1mUStFXAZbaxtfkWM6bTIZSNoqcYwoH8DYeKcHFjG9HmLihmSi8hzL7wavQaNMc0DLay6zO2nc8A3r2b2XNtV9IsGUsMHecDl8kINh7MIM1XLiPtrSX0gXSIhDxdJCG6v50A9cKfRAkN2KEDCSjGFQiresGSxPy8BS+9MMCNgtQWBqOg7FKGQ8WXFttVYLbZR8h9Tvtaw4znO36GJPy3OQMdMe2dvPK6C7nDQr4+hkFWCf5riX1fG7idx3z9abwbBL7tCYmHux6WumNT1UNXOsHTFh7k8QnbCd61E4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(83380400001)(956004)(4744005)(6916009)(16576012)(26005)(508600001)(7416002)(86362001)(31686004)(6486002)(36756003)(31696002)(316002)(53546011)(66476007)(66946007)(186003)(4326008)(38100700002)(66556008)(2906002)(5660300002)(8676002)(8936002)(2616005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M3dueGYzYjhtUTZOWjZjY1E2R1pRN0U0TnRISUFTSEl2Q2dZTXpJc2NaeERl?= =?utf-8?B?NWs4bWd0V3VESmVMY242MHBibE9IK1NNa2c5MVk1NDVHeGFmQW41cm0xSmp1?= =?utf-8?B?Mmd5a0g5TUptMGk2ZHJseW1XU1JEWHR2UlJUa2xNczFKeFhobzNVU2l2eVVp?= =?utf-8?B?K1g1Y2xyK1UvaFBueUpTQTNZQnJkVGlGNVpmM1R3WUFNc213K1JqRitzRE1H?= =?utf-8?B?ZTJ4QUZuNFMxRGZmWmE4dlFkdlRCQk54b1JmRUQvMGVoN3NnUTV1WmRxeGZP?= =?utf-8?B?cGU1YVptTDZtNld4THZlVnpuZkViQ2ZiZWZvTVpEYzdGaStMZW4rSkhEQVZq?= =?utf-8?B?KzJLTkUrZFZwOVZQWXdXTW1Eem5PbHZpdm9HUDJVaWlIeGtieU1zNjZnVTMr?= =?utf-8?B?OGFOeWV3c3VkTXhPMDZ1YllvUHpRaE83Uy9WUjB1anBhOGxIYm5mVEViYndX?= =?utf-8?B?cVRJVFZoZ0VpZy9KM0VEVzUzdDNJSjk5QTVBVEEzR2JqOFZjL3hsQXUwWE1i?= =?utf-8?B?TVE0K1NEVmVZd3NSV1pHSDhhY1ZldTFIMG9TM3RXSEYvOThZUm5QMGUwcEIw?= =?utf-8?B?UCs4dFdZSHNGOTZPaVR1VWpWWERCWkdwclk4eksvaVo0NkNQU0ZBcVFEc1o4?= =?utf-8?B?RWFNVVpucDcycHZIVndiUFZNbVNjdlVXZm1CdVk5MENMSG1TQzBjRk9Xenox?= =?utf-8?B?ZlhLbXA1emd3WUpzUXYrMkYzRFg5eDhzVmlSNGsvSmtodkNybjZpT1VEZWZa?= =?utf-8?B?NTdBdUdjSXgydlkwTm94TzZpYlRXWktPbExiamQyd21Ca3luZUpRVjVsNGpS?= =?utf-8?B?WUtaMTNHTk1NN3NHWTVoeXVzMnlTNXBNTDg4dkRHMCs4cjF0TU42UWtBYnNB?= =?utf-8?B?aUx3d1Mzam5xVGR0Q0tyQVJzQzhhMmhhSXFwOEFYMzhWN1E5blM3aW41bjhs?= =?utf-8?B?d1hnSGFudlhQcHNyRjB4MnVJVzBjdzF2ZFlIWFEvc3ZrOEJ3aWZwcjRDQm5w?= =?utf-8?B?dXQxUFJ2OGl4NW9oTHovS3lKd09xSU9QNStOS0Y5YmpSQjRhMXdjZHM4djVX?= =?utf-8?B?SVluOFZnNmc0eGpIbXZuVUV6bWlDM2tIVHNhOEhJaEJuSlIraW12UjNPNHZr?= =?utf-8?B?S09nbXQzalBIc0RaUEcrdnZMY2s1TU9WM2RGRTRUZGthU0x3NUowUGlkZTc2?= =?utf-8?B?OTJESU5WaG0wWjkxcFd4MWNTMkZpM0xPVDl2Y085aEtza3NvTk9aYWU5aWw4?= =?utf-8?B?NEd6QnlWZ2h6ZnZ5WmN2MnVaOXhoUDBlekVlOXRVRTJ1WWxnejhOZTV3Smdm?= =?utf-8?B?aExmUVd3WGFPWExtMHl6S3AraFM0UlpIWjFCWHVyWXpJUWZnSUFQVzBpZm9L?= =?utf-8?B?d1VEUVhBcDBxdEM2aDRGV0hwV2g1Mnh2VFd3SXVueGRndUxJUmRENU9NMHZp?= =?utf-8?B?Q2pLbFVLYkFuVTFoaDZkbVZXd21NT1V1TWU5eGhsZmtGZWxKOGJxaWJEbEla?= =?utf-8?B?RHNIcUFsUHNqNXJiQy9OazFhZW1JQjNsUWU0NkZGWktHcjVIdmVMaHFkYmxW?= =?utf-8?B?UDVndXdBQ2V1TWplbnBxUkFEMG9RNnNPSGtFdTlpa1RZajVJQ1YrUUFaUTgw?= =?utf-8?B?dThIRnNFb3E3Nk1yTnFvcHhVdlN5QTV6cTdrdWlOckEvaFVyUkszUGFEdjZi?= =?utf-8?B?TnljWkpwdndyNjF0V0EyY00rQ1RxU1JhWGxIeUtXQnV3VlZmcGJVVGNBcGty?= =?utf-8?Q?4wmloHMG1g4fagcRWwWVjyXN3Jm4i0iJ7iheFbh?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4bfab33e-f55e-4ccc-05c6-08d971454b8d X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2021 14:47:48.4990 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 67JahmkBh+xlSHPwUvmcVDxQ1vBbKF0GOdcKWUTthT4riqXHbZ1UtbzL7M0Kf0QfUJf+qrHRgFtkuK5rnwBRVQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4445 On 03.09.2021 12:08, Oleksandr Andrushchenko wrote: > From: Oleksandr Andrushchenko > > Instead of handling a single range set, that contains all the memory > regions of all the BARs and ROM, have them per BAR. Without looking at how you carry out this change - this look wrong (as in: wasteful) to me. Despite ... > This is in preparation of making non-identity mappings in p2m for the > MMIOs/ROM. ... the need for this, every individual BAR is still contiguous in both host and guest address spaces, so can be represented as a single (start,end) tuple (or a pair thereof, to account for both host and guest values). No need to use a rangeset for this. Jan From xen-devel-bounces@lists.xenproject.org Mon Sep 06 14:51:07 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Sep 2021 14:51:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180009.326491 (Exim 4.92) (envelope-from ) id 1mNFxe-00075n-1a; Mon, 06 Sep 2021 14:51:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180009.326491; Mon, 06 Sep 2021 14:51:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNFxd-00075g-Uf; Mon, 06 Sep 2021 14:51:01 +0000 Received: by outflank-mailman (input) for mailman id 180009; Mon, 06 Sep 2021 14:51:01 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNFxc-00075W-Uj; Mon, 06 Sep 2021 14:51:00 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNFxc-0006FP-P6; Mon, 06 Sep 2021 14:51:00 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNFxc-0005Zf-Hv; Mon, 06 Sep 2021 14:51:00 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mNFxc-0001of-HN; Mon, 06 Sep 2021 14:51:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Cxe8CFbjk/dvGVcyw1QMza334AQQ56t8EzbCmtg5fhU=; b=KGYImgVvFB0o7e8HRi6sngIiUv uopwabiJ0KBCc/bRMHSwWW45baaFOZPw3LohVGc1vdXw6hcFc8jHkpAO+EntxU2vRyEhYhF14wNGn 3vDQNmBpWY1sBZsmHuPTFUNd3CpygIzQ80p3bi0pyAXr/17dzOXaJX5ByH/m1CY4T0b8=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 164861: regressions - FAIL X-Osstest-Failures: ovmf:build-amd64-xsm:xen-build:fail:regression ovmf:build-amd64:xen-build:fail:regression ovmf:build-i386-xsm:xen-build:fail:regression ovmf:build-i386:xen-build:fail:regression ovmf:build-amd64-libvirt:build-check(1):blocked:nonblocking ovmf:build-i386-libvirt:build-check(1):blocked:nonblocking ovmf:test-amd64-amd64-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking X-Osstest-Versions-This: ovmf=edf8bc6d24c6f490c27de3144eee88f1ca40ce6a X-Osstest-Versions-That: ovmf=cae735f61328d64e2e8991036707b9e78c0f5f63 From: osstest service owner Date: Mon, 06 Sep 2021 14:51:00 +0000 flight 164861 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/164861/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-build fail REGR. vs. 164674 build-amd64 6 xen-build fail REGR. vs. 164674 build-i386-xsm 6 xen-build fail REGR. vs. 164674 build-i386 6 xen-build fail REGR. vs. 164674 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a version targeted for testing: ovmf edf8bc6d24c6f490c27de3144eee88f1ca40ce6a baseline version: ovmf cae735f61328d64e2e8991036707b9e78c0f5f63 Last test of basis 164674 2021-08-31 02:56:52 Z 6 days Failing since 164686 2021-09-01 03:03:43 Z 5 days 68 attempts Testing same since 164806 2021-09-04 09:41:21 Z 2 days 42 attempts ------------------------------------------------------------ People who touched revisions under test: Anthony PERARD DunTan Gary Lin Hao A Wu Jim Fehlig Lin, Gary (HPS OE-Linux) Loo Tung Lun Loo, Tung Lun Mark Wilson Marvin H?user Michael Kubacki Rebecca Cran Wenxing Hou Wenyi Xie jobs: build-amd64-xsm fail build-i386-xsm fail build-amd64 fail build-i386 fail build-amd64-libvirt blocked build-i386-libvirt blocked build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 blocked test-amd64-i386-xl-qemuu-ovmf-amd64 blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 302 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Sep 06 14:51:38 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Sep 2021 14:51:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180016.326506 (Exim 4.92) (envelope-from ) id 1mNFyE-0007tb-Bj; Mon, 06 Sep 2021 14:51:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180016.326506; Mon, 06 Sep 2021 14:51:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNFyE-0007tU-8l; Mon, 06 Sep 2021 14:51:38 +0000 Received: by outflank-mailman (input) for mailman id 180016; Mon, 06 Sep 2021 14:51:36 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNFyC-0007t6-DZ for xen-devel@lists.xenproject.org; Mon, 06 Sep 2021 14:51:36 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id b1779ef4-d67c-425a-bb44-16905e5f7d68; Mon, 06 Sep 2021 14:51:35 +0000 (UTC) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05lp2112.outbound.protection.outlook.com [104.47.18.112]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-21-AicrIZkDPiGpM8Q08cBCzQ-1; Mon, 06 Sep 2021 16:51:33 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR04MB6862.eurprd04.prod.outlook.com (2603:10a6:803:130::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.22; Mon, 6 Sep 2021 14:51:32 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4478.025; Mon, 6 Sep 2021 14:51:32 +0000 Received: from [10.156.60.236] (37.24.206.209) by PR0P264CA0075.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:18::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Mon, 6 Sep 2021 14:51:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b1779ef4-d67c-425a-bb44-16905e5f7d68 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1630939894; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=w+e3TMfIQ3h7vzuGFjSUuI1jlMp8WLtee/hmiATvu5Y=; b=c2bG7a1cDwWAkNrSGeXra5lsf4/OmlcbnychRFXnLmrCMdrf4hlrJewR8DqWaXpgS880sj hule9+7EyVUmOxZzxtLPp5v2rZDgo4P6dRF6/JHIxSeRqSG6hZ0liwrZmpP1kKLjZgNHRo hywICSg21uIZTrfnDL9HibPd6eXracM= X-MC-Unique: AicrIZkDPiGpM8Q08cBCzQ-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=W9oiN8EiXENiLveTSwmZdfT24vfgz83PH9xzFjxOhbZwXRYCSaw/bJez+tY2VYVmbkhHZFpagBLYrMQd8r0wnkhE8YBfX1Rb5a8dFIVhQlW6h1rfy9AM7DNPcv1n4/EzBuKrjNyk2k44DhrtNBzN5AnK97+oysdCSrqlMrEb/y1ifHhs/Y/+J96O1GIKWBwUB5B6w0mHK8kDYgYmMi5dtdgnIKBJZwup9OuFK0ng2AQGWFHLsgMwofgDTTmfwmsx0I9m5w2vxzoV9Gcg5Tc8KAxuJ+UY83lk0oKn6f/Tkk9/e2p6Zf5pu16k0s44amDohPoX0fQlPxIsbIMacZoZ9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=w+e3TMfIQ3h7vzuGFjSUuI1jlMp8WLtee/hmiATvu5Y=; b=mRALFWuwLamhmvp5l5pH8Y6azbeGOcWmYtnlvx2fKnZYlWLk2OKAObp4NBIAgm3pZTOGJkw8jdnEMqJS174U6jGSJ5L/zg1/fy+h8T0XJT3wxxuZSMHB9Z5ITjLVBSkS4PY9kCqHOJbqrsnaAknyly2xEL7KIPPKG4DGawTnCUfUSlBrEm3gCwQtbtR14fVsEIFshCTmKqur5mBgK+IGGH2ITsm0lVAmbadsDAsmr/OGByxdmuchmzoVg9/0Jt3Nz6+wgbju1jOiXTkQvheBXA0noNnVeHdIybsD7Wyl28CJH+Rn/WfBSdo0TWwnM6ZyHFrJQqV9I5sMEk8ZFPioHQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com; Subject: Re: [PATCH 7/9] vpci/header: program p2m with guest BAR view To: Oleksandr Andrushchenko Cc: julien@xen.org, sstabellini@kernel.org, oleksandr_tyshchenko@epam.com, volodymyr_babchuk@epam.com, Artem_Mygaiev@epam.com, roger.pau@citrix.com, bertrand.marquis@arm.com, rahul.singh@arm.com, Oleksandr Andrushchenko , xen-devel@lists.xenproject.org References: <20210903100831.177748-1-andr2000@gmail.com> <20210903100831.177748-8-andr2000@gmail.com> From: Jan Beulich Message-ID: <90813678-d873-d346-5f53-ab97aaedd3e6@suse.com> Date: Mon, 6 Sep 2021 16:51:30 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: <20210903100831.177748-8-andr2000@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PR0P264CA0075.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:18::15) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 55f704b4-e29f-4c46-0d01-08d97145d101 X-MS-TrafficTypeDiagnostic: VI1PR04MB6862: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4303; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: nLHflvI2dgXVcHIKnK5CUAPowX26T6oAB4oD/sgsA4VxGi90Z2QxXfY032buko6GNrKMj7TDVg7m1FlfJCFPEM4t2e40vyeZOqGor6dAHE/R9vHDEOX1EQkcrh4t6I026uy4M+Gp/z7/l9o363ceBb9ryXyuvDVwY3qOxk7kkHqPIj715IIDkz43tYRfYMyZAd5sxuU0yTkyb8dpBwd1lN0qAxFc38LTiH7EMjDTymXaDvC8Ri+H1bu3Hqqu5u+42EkNDspR26B/8hsGmt1C9L+u24lwq8Zqirb+/Ej4mmm9ILfsxURbjTHAyoKopCjZ/B/w6nKIJtcPb8A/8Zs62pfmiZrZDVh4sjNoYWeeqYWmllOzzbfuZj0g6J/cCD9mBsCn2I9qjkzdbyCO+/SXK8GMkBezTa+d9pJIxpfpjY1taIyUD99/tprQgcx7fDN4eHlaZ0luC1OoMYWFE96Jg0ytCGewSclZkmFt94WNPCSBcL99w7Y89WqxbMu6J1/RvIFKXJ+kbQkFfnWhkOsdJttyBqe8ByZGioVFLcGmtkO3UAQx1E2g8XQhqTsO1k551AZRB2zRgFDrls6w77UfAKvXAfEIaKQhAAQsefv+q7Jok6ZgyZSwH5gmX5rhD2lV0Zb/t5gSalsjyJoW6KxDMIcbNR6hkz0A+g6Vkd6brxYkZwjc1DQFCXWf15c+RtSCj7a4lkMI4tOz/9jpH60Wz6JtwqJ6/rHDUiVAjwc+0+c= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(136003)(396003)(346002)(39860400002)(366004)(376002)(186003)(31696002)(26005)(8936002)(956004)(2616005)(6916009)(66946007)(53546011)(36756003)(8676002)(38100700002)(4326008)(66556008)(5660300002)(7416002)(31686004)(16576012)(6486002)(316002)(478600001)(83380400001)(86362001)(2906002)(66476007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RFhBNGFpeXpBck5PNHJaV3B3czc1aWZ1aGZSalhHNk0rdC91dWZzOHNrcVRO?= =?utf-8?B?bU92UkhNbXV6dHVseW1vdlpIdENpT1VhQXZ1K0JtRG5nVmRvNHpReXNEVWI0?= =?utf-8?B?dG1icmsvNWxWZ0dCdExyOU5leU5KM0J5eEdXYnFuQXBHNHlWNk05aWs4U2p0?= =?utf-8?B?UEUwYmRYTm5DVEdNUFFydkp3V3pWbFFBTVdVZVE1dFdHRmdZL05rMWdIUDAv?= =?utf-8?B?cGxxMWtuMEkrTTF5U3hrbldKRXphNVRkVnZrdEpWdldUMzk2V0I5Z3lsMkZu?= =?utf-8?B?bk9Lci9vVXllQ2NaeTZtNjBkaE9LTGYrbEI5RVoxYVhyVGliYXRKNTRmcjRK?= =?utf-8?B?TTRjWUN1STNvSG9oUFByckhoU2I1MDN0OC9sQnF3NzdMckN4N1Y5dDVsWmox?= =?utf-8?B?ZmZoNVNtN0FuSFdib1k1OXg5WkV6VHZmUS8zRlA1b1I0cGxEblJrbk8rRG9p?= =?utf-8?B?UURwMlo4T0hEdmNYdEdaWlRiVWVkR0hGakNTb2FXY1RVUTZkeWQzclcwQ2Rq?= =?utf-8?B?ZTF4Qys5aU9BcS9aQ3VkQllHMXQxNmVBdHo1MTlVdEtBWDh6cWQvU045LzNy?= =?utf-8?B?NEp0S2JsU3B2ZmozVU9YT3hMbEtYeUU2Sm16ZWlHdzRtcXh4VEhDTTZlcEhE?= =?utf-8?B?NzY5cDhDZE1RZzNGNDRQc0FKZkJvWXRJTG1ISFZiWk1mSGlFY2xWMjcwRnNE?= =?utf-8?B?OUd3WHVGbEFBWXc4dkJjeUpLQmVGMzJFdnVoaHh1WllzY0t3UmlFY2I3bll3?= =?utf-8?B?SmhSME5helVOb0IwWThJTUtLY3VnbGl5QU1DQkRzSUJzc3pJS290NGpLSmNL?= =?utf-8?B?Qlg2bU4rSzZpeGU1c3ppbE9kVFo4b1QzQWQxL0NlN3M0eW9QVXhlUng2RE1i?= =?utf-8?B?ZFA5WFZ5TFdwbUUwZDE4K1BVUmNVdVNCbG02cTU4WS9pRGo1RENuS0ZRWHN5?= =?utf-8?B?RllEbGd3OTc4RjZtdXZpcm5zazd2REU0REZNYThOdytCRXZuOXhjZ3RoUnND?= =?utf-8?B?a1NEdjhNS05OM1dJQzVhK1g0UlNBa04xeVJ6OXRxam1NVnAyOGlhSzBaMDFq?= =?utf-8?B?UWRydjN4OWtnU09iNkhXVG9TcUlQSFVIVGZGTk9GbGxLYlZxKzNVM3Q0TkJa?= =?utf-8?B?aWRrakxCZ0pSbzBUS2tZd25oWTdqYnFQTFJTYys1UklIalNxdkczT3hJOXNH?= =?utf-8?B?Y3BkVFVSUk9Va1VDcXJBRzJpQ3Y2bzRwL3lXLyttdDU5SUZiR3FXZmMyNUJR?= =?utf-8?B?WmpseUlXc3M0eTJQVXcxTE1DVW00aW9iQmN1Slh2RGZabForYkJ0Rm9oR2ZQ?= =?utf-8?B?TlFodHpUb2s5MHBqazliSXZheWNiMDRIK2h1UGJlaGw0UTJjOXRPd25ReVVt?= =?utf-8?B?d3lKSTB0NXNuS2FrdTRTTWhCQlVIWGtnQXcwVHRPdzYza0dxaVpFUjlDclBG?= =?utf-8?B?eXc4bDllMllGWWJtalYya3dPSi9SeExROTEyN1NyWjBxS2FMaVpwcjNwUUJV?= =?utf-8?B?QklnbVIyT0ZQMW83WTc3d2JVaWttamMrRjhoWjV1YzA5cER5RGtkVnV6SCsx?= =?utf-8?B?WDl5bXA2N3p2djQzSFJVcVVOVGhtMFRBTmxYaWVsMjAxbFJmQUt4azdyaHJj?= =?utf-8?B?aU41clRNZ2I1MEF2RHAvK0FCZHlJWGdtd21uWTRhYzNTT0gwclErNThPY2Jj?= =?utf-8?B?WlkvY1k2UXV0MHNvMllhVmtQVzR3c2daK2UvaGsyREVaZ2ZmbDRkVG9UNFR1?= =?utf-8?Q?wpsG9PmYRfFLtNOmU4ZrEH4MbazGv0jisGYC750?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 55f704b4-e29f-4c46-0d01-08d97145d101 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2021 14:51:32.3744 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: dRNhdyZN6gjMGRBq5g4cPSOU8ktaGjC96t8cH2x1o9UAqf7xVOjbOrqFZLEYMzWgKlvzJfWcpvx/birmV0jwbg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6862 On 03.09.2021 12:08, Oleksandr Andrushchenko wrote: > @@ -37,12 +41,28 @@ static int map_range(unsigned long s, unsigned long e, void *data, > unsigned long *c) > { > const struct map_data *map = data; > + gfn_t start_gfn; > int rc; > > for ( ; ; ) > { > unsigned long size = e - s + 1; > > + /* > + * Any BAR may have holes in its memory we want to map, e.g. > + * we don't want to map MSI regions which may be a part of that BAR, > + * e.g. when a single BAR is used for both MMIO and MSI. > + * In this case MSI regions are subtracted from the mapping, but > + * map->start_gfn still points to the very beginning of the BAR. > + * So if there is a hole present then we need to adjust start_gfn > + * to reflect the fact of that substraction. > + */ > + start_gfn = gfn_add(map->start_gfn, s - mfn_x(map->start_mfn)); I may be missing something, but don't you need to adjust "size" then as well? And don't you need to account for the "hole" not being at the start? (As an aside - do you mean "MSI-X regions" everywhere you say just "MSI" above?) Jan From xen-devel-bounces@lists.xenproject.org Mon Sep 06 14:55:39 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Sep 2021 14:55:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180022.326517 (Exim 4.92) (envelope-from ) id 1mNG25-00009r-Tn; Mon, 06 Sep 2021 14:55:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180022.326517; Mon, 06 Sep 2021 14:55:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNG25-00009h-QI; Mon, 06 Sep 2021 14:55:37 +0000 Received: by outflank-mailman (input) for mailman id 180022; Mon, 06 Sep 2021 14:55:36 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNG24-00009b-6L for xen-devel@lists.xenproject.org; Mon, 06 Sep 2021 14:55:36 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 7d4867c2-0f22-11ec-b0a9-12813bfff9fa; Mon, 06 Sep 2021 14:55:35 +0000 (UTC) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05lp2113.outbound.protection.outlook.com [104.47.18.113]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-16-EAfCa_UaPdGfC6z9bz9vUQ-1; Mon, 06 Sep 2021 16:55:33 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR04MB4845.eurprd04.prod.outlook.com (2603:10a6:803:51::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.22; Mon, 6 Sep 2021 14:55:31 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4478.025; Mon, 6 Sep 2021 14:55:31 +0000 Received: from [10.156.60.236] (37.24.206.209) by PR0P264CA0219.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:1e::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.17 via Frontend Transport; Mon, 6 Sep 2021 14:55:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7d4867c2-0f22-11ec-b0a9-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1630940134; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Bv9XkP8auOWVn7yNSqj8qEom+vUYrV73C8AOIGJpxcM=; b=j3d2CkaD7MYhW3K+gjo7PPim+vsUgCcXVXWYz06JBY+v/5zxpz+pchuHNVAqHuo2/W3YsM aQbitXNgVg+4j3VnqQEtmyt5oRKSrgCTm+7jV/n4LJ7E4mqsvn49qfV0mKqhJA6cvoRI3+ Pqdltzxge4AIjDjJoatZigs4TbgZrg4= X-MC-Unique: EAfCa_UaPdGfC6z9bz9vUQ-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kOZU9rIc9MSfr+JyiiMZZdYx9pxdnDaE8vCTVMIoxWw5O662f5akmDI+1+obqGcpPFzHGjMol5prvdlfivynaB4a9bZxbFNYQI8IKk+R/UsFDCVzD+BxBc87JdLFnu9+G9/vGlAraaNbWq+0lsPfKgntM4GEkNNTtMW1hdZP35I7R27MZE9urYxUnH3m6P78R0LzMXSglO2vlHy0eEUe71ks7XbAAxr5nxni7nGS1h/5dCXd26UQ/xd5jARRw2TzBCAZ2iS0/l+CbrouIzyHP6BalilaCMwQ9m9WwhUDmNG76/VWlC3uxQFhuGuHfTlIey7rzZl3paE5VpTXmUty6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=Bv9XkP8auOWVn7yNSqj8qEom+vUYrV73C8AOIGJpxcM=; b=TP36ndniocItnaNg5dEvChGUUqU5cgTfXS9RWxHLBmREp76Gh+lMZBHYeD0ZrDUjqYzRopFVEum8cmS7rEhuCT3S1Qf5Zeqf0o8Gi2QzEm86EWs2rbCWotYRLvULIzonL4V/4xnMnlZ45fgRzVVJwcduhlaluvJFq9L6idEJymPOqBlo3G4nPzZ2DzMNIdxM4j68mXPW6EyElD7LFQlwJa53mUBu8bzcqvfFszmvonG3+PcQMsXxQXQU8t17au52RrMGocVEBCnq4qqxe8u/UqjyPUaT8qj3BMs2YYKexxK914/ImHe50WW/lgBMJ2NJunOW3ktFKysMQWMW+kRqjA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com; Subject: Re: [PATCH 8/9] vpci/header: Reset the command register when adding devices To: Oleksandr Andrushchenko Cc: julien@xen.org, sstabellini@kernel.org, oleksandr_tyshchenko@epam.com, volodymyr_babchuk@epam.com, Artem_Mygaiev@epam.com, roger.pau@citrix.com, bertrand.marquis@arm.com, rahul.singh@arm.com, Oleksandr Andrushchenko , xen-devel@lists.xenproject.org References: <20210903100831.177748-1-andr2000@gmail.com> <20210903100831.177748-9-andr2000@gmail.com> From: Jan Beulich Message-ID: Date: Mon, 6 Sep 2021 16:55:29 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: <20210903100831.177748-9-andr2000@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PR0P264CA0219.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:1e::15) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 042c7078-9ffb-435b-057b-08d971465f7b X-MS-TrafficTypeDiagnostic: VI1PR04MB4845: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1284; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: DP6pgYsCEek2J4ubnvlbLXqs2kLl00f0vSO4HSj1pBp3qfNcKiIKpHvd72nIhKd+FmQfHKnrBK9p1IxK/mSHtpNsMdjOm8rBa98oPQ9FkJp9+TVAtZmu6oxkF7iiP5DGdpKP4MAfV1WAEr0di9KQ2Yo3KcUhUwcbcLoh9Yp87QcdQrdkO7sBJHmo3SD2VAypjelmydcDeHtR+VVGUAxOV/aOwIa1uOeeWh9of8sfViDUGykLcJsSa7EAKGym7Q7EI4gZKxR/sygtXppU3Z4oBIUzIpQ0D4hQBkdZ9bayUQOVmY3J3imIlOjFW+c0ioTasm4Y7dCLSy2eNSsMVhOVEoctUIOCTD08g3OEKu5y4xmK6jsGv2D80t3wL4r8PZJzrsbpQM/lpY/1GKFzGyCbmBsA9O7EZPPC3KDegQ5zqEI5CjoN4Xso7hOU9Z7/vc3JxcSIKqcLw7eEb/WgdJMNfrBarx+h6yWhWB6fsQ9WYld1zFMIlgFcxqliN/isjCxahOq8o64spyy35unbYUJzxiwNjtljaRORNX1LxJnIJPu/FWiJ9edZ5tOv6ElDTYbak67Bh4rwrvb1N7UtSQar5/tQB5RZ9nP/8Pw+aLB5YnmJuS/h9iD2HajG5mqTchIgS5+dITiLBCrHzx/q8blEAeV8hM06xNYvfQ+fIvwsq20fHIM6aC07cmiNhwdy+6aR7m/OG4M/0j2yBUbT7Rs0aLG9i94U2vhRzXMHRUnraUU= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(38100700002)(4326008)(31686004)(7416002)(186003)(6486002)(83380400001)(26005)(5660300002)(2616005)(508600001)(8676002)(6916009)(53546011)(66556008)(66476007)(31696002)(66946007)(8936002)(36756003)(2906002)(16576012)(86362001)(316002)(956004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VVlGcGI2LzhDdE80dHBOQk01U1Z4WDQ3OXR1d2Yrc0VCeTY2bCs5NWpCYXBV?= =?utf-8?B?KzJqT1duMlJhRExEcHN5cnVKcE45Y09yL3puLy9OQUFsMU9kMHJ0b21heDlF?= =?utf-8?B?UDJwMFpPVmRja3RDalA5SE9xaGh4aDVzZythRzZ6UkdicG9jRkJzNGxsekdE?= =?utf-8?B?eTVFL0Y2ZmE2ajVzQ2Zlb0toQnZheDcxbkNEeDZZR3hVYWwxSHc1cmtKZ1lE?= =?utf-8?B?eFFGT1ZrZU9LKzczc3FDYVZlU25OdTJTcTZhckJMMGY1d1hZZUtFUFNzSWVZ?= =?utf-8?B?cUd1bmNDN3lrTGlDQktvNVdWTXdFQmdUMHZBZThuMDcvR01ZV09lbjVTRnhG?= =?utf-8?B?cXFheEdSejB1eFgzZExsWEFJQjN6cmZjK2xBSFcvMmtxWjR1SWdxRVhsNGhK?= =?utf-8?B?UXpmVGIySXE4ajZKcGk3R0didnF2R2FPc1JuTUlmelRpa1hEd0cyeE0zeHpV?= =?utf-8?B?MDVXc0ZPRzdXbXJpbzRHYjJVVy9rYXBiZXV0Tk51Yy9sOUpWWnFpdUZzaGQ1?= =?utf-8?B?bGxHUVhnVzFMd1hOd1BOZUg1Myszd0dpUE9zcmZ4eGF3VVVzNExRdUIyLzJw?= =?utf-8?B?TkNlQzZkaEdjRFdUL09sMGFoby9WZnp5enR5eXlPTC9UcTRkaTU1eVhoZUh5?= =?utf-8?B?ckpHcVFYUFkwblhicEd0ZlkxdklSTDdBMHlWaU8vZ1h0VHZ0a0NqMnR2aTI5?= =?utf-8?B?bE1uajdmZ1dKS1dEKzJXbDBJbVlKZXdWRzRzaStSd0REVG9JcndRM2p2bTZn?= =?utf-8?B?ZUpkTlV1K3hZSWF3U1p2V2hjSjJsUzh6NGF6VzRiSkh0eVgzNFpWdnRsYmxq?= =?utf-8?B?ZldXaGFjcnVzekpudm5rdzNCTGlGOFMzK0tlV0o3TFJDN2QxUk1LUm50L2Z6?= =?utf-8?B?d21tb1ljTVR4QUZqR0pwc1NYVHUrZk0zVkVqOEFXSjF6S3EwWFU2c3RNRTcr?= =?utf-8?B?MzJVSXVrcEFkcXBsNzV1Q2VRcXF4WE5HNFI4RzZqZnJ1djlrMFE5YkFGTVVs?= =?utf-8?B?TW1tQUVycTVFNHRXSjR5d0JPK2FsbldaQ2d2OVgyUDY5Z1ZKNnpPYmJXN0cx?= =?utf-8?B?QmZoYklzQ0lGYUhwckZNK01PNXlkQ3dQaXZReVZMUXo2aE43QitiNFVsTmV1?= =?utf-8?B?ekx4RXFIVHNpS0ptSUNLMVZnc1EyUGJqMzd4d2N4M1E1SmpqRVlVV3FBN1di?= =?utf-8?B?RTNIbndwMlE1akpYNTI3Q0VsTVZ2YmY2dEw2bE9iSFlMVzVMOUljS1hFS1kz?= =?utf-8?B?a1c2dDNxOE5yUktsM3U2a3BCVzVYNGhrSldSL1R3aGJzWWROTkJKaXE5RWVj?= =?utf-8?B?R3VqUVBNMnRUQVlLTU4zTGoxeExZbHBVMXBzMlFRSWxjb1B5a2NxV3ZwR2Q2?= =?utf-8?B?cXBWS2EyTXBNQk1IK3M3NE9lVzZIaTRvVjl6QU1rSUxCVjIyQWVsdjgycDNr?= =?utf-8?B?cnRXQS9XbVNydVNoQ3JNNjF5aXUva1YzRjk5S1lIQmVVTFFnUk04b1ZvVm9I?= =?utf-8?B?WmdnaTBSNURRbXYyV1Fka0JPSzQvalVRM0VZdS9UZE9va1FiWTVSM2VVVzR0?= =?utf-8?B?d1B6d29DRlZwTC8rejdzRGpqRDdqU2pSVmIxMmxqWWMzVytDTXVpTXlXTmxB?= =?utf-8?B?REc1RTc1YWNFdUFOakMxeXJ0bnpkRmphbmdNeHhQeGJzUEJFaGdxQllMdU5x?= =?utf-8?B?WEptZmVjYlFhYU1rZENzdzQxUzQra1c3bGgyZGpiZThEamI0eGN6eEhsbE5H?= =?utf-8?Q?/x7L4ZEuuVKQi83GvhbeNQ0m0596ot3hjIg9kR3?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 042c7078-9ffb-435b-057b-08d971465f7b X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2021 14:55:31.4132 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: LQD1tIYNncaNkT3WVx6usSciRqbrmX7p2hVGsGbIzgD42Rc4cBqUrhnkjJJ8CrymCqdulIk3fGOHGsSmWCjyIw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4845 On 03.09.2021 12:08, Oleksandr Andrushchenko wrote: > --- a/xen/drivers/vpci/header.c > +++ b/xen/drivers/vpci/header.c > @@ -811,6 +811,16 @@ int vpci_bar_add_handlers(const struct domain *d, struct pci_dev *pdev) > gprintk(XENLOG_ERR, > "%pp: failed to add BAR handlers for dom%d\n", &pdev->sbdf, > d->domain_id); > + > + /* > + * Reset the command register: it is possible that when passing > + * through a PCI device its memory decoding bits in the command > + * register are already set. Thus, a guest OS may not write to the > + * command register to update memory decoding, so guest mappings > + * (guest's view of the BARs) are left not updated. > + */ > + pci_conf_write16(pdev->sbdf, PCI_COMMAND, 0); Can you really blindly write 0 here? What about bits that have to be under host control, e.g. INTX_DISABLE? I can see that you may want to hand off with I/O and memory decoding off and bus mastering disabled, but for every other bit (including reserved ones) I'd expect separate justification (in the commit message). Jan From xen-devel-bounces@lists.xenproject.org Mon Sep 06 14:57:27 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Sep 2021 14:57:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180028.326528 (Exim 4.92) (envelope-from ) id 1mNG3o-0000oU-9q; Mon, 06 Sep 2021 14:57:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180028.326528; Mon, 06 Sep 2021 14:57:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNG3o-0000oN-6o; Mon, 06 Sep 2021 14:57:24 +0000 Received: by outflank-mailman (input) for mailman id 180028; Mon, 06 Sep 2021 14:57:23 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNG3n-0000oH-56 for xen-devel@lists.xenproject.org; Mon, 06 Sep 2021 14:57:23 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id bd050988-0f22-11ec-b0a9-12813bfff9fa; Mon, 06 Sep 2021 14:57:22 +0000 (UTC) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05lp2174.outbound.protection.outlook.com [104.47.17.174]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-39-xl1GQZ_MNoeOQNhEmmZ5jA-2; Mon, 06 Sep 2021 16:57:20 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR04MB5744.eurprd04.prod.outlook.com (2603:10a6:803:e4::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.17; Mon, 6 Sep 2021 14:57:18 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4478.025; Mon, 6 Sep 2021 14:57:18 +0000 Received: from [10.156.60.236] (37.24.206.209) by PR3P191CA0055.EURP191.PROD.OUTLOOK.COM (2603:10a6:102:55::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.22 via Frontend Transport; Mon, 6 Sep 2021 14:57:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bd050988-0f22-11ec-b0a9-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1630940241; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CNSM9aGdDV9WVXdpSczpiqZ5PzSE+iG54YbevdVOLVA=; b=Aj6JQBDKTboW+LnBDQ1PezGm9DKpiSLxcm/cqghdiPBCgbvjO9EHG4bVvaCtxR6MOyus1d 0MbDiJPnu7NRLmZtpRykwAN02dxbltQ7qcaarQ/RcLiMGsqqk/vfVhKjduXFuJwPtHjm/X 42DSjQwP1j8weRLCQHnqvKtCIFxOjMQ= X-MC-Unique: xl1GQZ_MNoeOQNhEmmZ5jA-2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eoV6waeUU42V5jrePYS3N0ueKaPI4dv65AXSjYxS2ZhBu+8hiHNOY253nED/6BzgH2P+zfCZz+UgCDN4KSoFLRRX5c+JgscgqR6p8cL0ch9nnM4D9h9VstMk8Hcxs3bxk9n9RMsnKr2EdPCYCQSdwQkWctm/s77td4EeAgoTwYhLFa1T8lw9HVkZoFv9SVr6JvaCBV6gb7vQsji/1iG4j5p0d8u0N3lWngN4neynAk0E2f2Fqih7lpNRH9PYPTxPqWI2vjRpyaLWAsUoHga/ngsMyyaJnov7t5nQ7erL3DHxVkMpyO9d7w2eylCeI5Drf2Efcc3ShL4lkp/AvJJlpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=CNSM9aGdDV9WVXdpSczpiqZ5PzSE+iG54YbevdVOLVA=; b=Z1ud5JtNboivYcmO8CltTTEyQOyClvUyMP8C8sCUNkUSdZtYNAd2u4MJ9DY0MtAWkHUG6OFBC5X6+NBC+dSfbeD0fSywd/BiHhK/3aW979Oa2ESbWYJZ0Tp3Gxxdis4vKpxu1NMKOiLXrlwdF/akoP3p8B+iOavDkHUjQ9V17hIKNUwR6TA6wk7biimpUrZBQ/i5+Qr8By6dhTpxvz/0do95RIKfy7NJtRlIEyu9K2XEuDnQ5HfbHgCdC6ik42loGPKw/AuDhOZCH56evbGGyV68NJYbP/X7Fyzgnksx+vvJ8csYUKYw6+zXw6wo83LVYmJeA3Gf+b41G/JGVW6jcw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com; Subject: Re: [PATCH 9/9] vpci/header: Use pdev's domain instead of vCPU To: Oleksandr Andrushchenko , rahul.singh@arm.com Cc: julien@xen.org, sstabellini@kernel.org, oleksandr_tyshchenko@epam.com, volodymyr_babchuk@epam.com, Artem_Mygaiev@epam.com, roger.pau@citrix.com, bertrand.marquis@arm.com, Oleksandr Andrushchenko , xen-devel@lists.xenproject.org References: <20210903100831.177748-1-andr2000@gmail.com> <20210903100831.177748-10-andr2000@gmail.com> From: Jan Beulich Message-ID: <214a8300-e818-321c-7618-185c56684db0@suse.com> Date: Mon, 6 Sep 2021 16:57:16 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: <20210903100831.177748-10-andr2000@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PR3P191CA0055.EURP191.PROD.OUTLOOK.COM (2603:10a6:102:55::30) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ddbb2616-ce5b-4ac1-37b7-08d971469f4c X-MS-TrafficTypeDiagnostic: VI1PR04MB5744: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:3826; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: iCKw+/27HlMB6LnhDHuHC3dHURHfAdhZDdl9u0/8aObUrgGozNPCGLMrjMCKlkRZ+mb16B1Sz5Y4ZtHHBWLF/Em7kGuF1rpXaE9hUaYrMHctw+bY9AXRadVxGw2PioUhAC7PsFy6Nh4pSAZt7xGTyMoC0wJIvYdXD8cGTHGxBGSPciT1F9tWXVdaUF0N/zqjOhzl9QBs8pjWT2xnQRhRbZiUQMdEOHFMXUuTxywqI7LoDTftTgiF0Uc27t+ip1XOIHaGUsfIDS5mQeMnAzf6koRRzDIb4Txtol+qPIIvD4TkJpXQ/HUCYklCaAzcFOC5HdwB0u6fjM14jND14yNJP65Mo4yrQqhsWpdqZTOMDHaK0ox4pZf2+6iUKDP6j0JifZooLKJLhXYr03K5phNdymKouIHJDmoKobeVDEpvQNDq+xS06vtt9cqGEhO2No4+AWhRWEt8jU+f2crCaDaPOmMSIVE2PPyd76s4gLrmGMCbFLrKlnrZFUnjFAs3sBDwxTUkDAwWTWpWBW1uAGBVFSwe2LO5JBQnR/cSNwcz6EAcOOhJJnrzi/nL+SGzaUqWuK0bYXHqhscy+T20i8B7Ts21ni89RiGV8l9/gd3V4ptFC/NyGD/FoJajzERCyP5qGYGZZZgKs/a2m9zshVaM7KmmmX4TAeLSNG3ln0AxeWqo7Tj486q3TkaIF2nSqJZBicoZYkXzf40gk9+6bd3E0Cz0TQRY4KcT0cAtGer37mY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(136003)(376002)(39860400002)(346002)(366004)(396003)(16576012)(5660300002)(186003)(478600001)(316002)(86362001)(7416002)(36756003)(38100700002)(4326008)(6486002)(8936002)(8676002)(2616005)(956004)(31686004)(66556008)(558084003)(2906002)(26005)(53546011)(66476007)(66946007)(31696002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R2QwdHBCdnlzeHJpRHdNWktsU2tzUDA5aDZ2engxT0Nja2c3azI0NEJ3c05K?= =?utf-8?B?NFVmU0pCL2UxOTZKbG9zcGJBR2VxOU5jaWV6SlhQaEJpOE5vT1o1akRuaHNq?= =?utf-8?B?djZnZ2ZXUXd4dnNxcDZaL05nbUIvczVvUU1CYWtxYW9MMjBFUkFhWGRuMlZs?= =?utf-8?B?N05raDl4bk5OYzFtTlZsVWtKTHFSRWt2UUVCS21LQ3FuQTFOdUpOV1N2Q1JM?= =?utf-8?B?SS9xTXZHT1NLVTYwbys0NURiNU13aks3dEhDVTZDbU5PWXdKZWlnWnhydlht?= =?utf-8?B?QUhhRmpDcDVUUjlsdEhPRit3SytldW1sMjkyV3Q3bUI3azBud21TckpvU3JV?= =?utf-8?B?R3lDUk1ia3pvTms0ZEZDTDZQT0Nqa21ISWhPMXRuUDVwSkRmS3lFc0NzQUQ0?= =?utf-8?B?RVZLTkxST1NMSWlRM2lCWUZvdm5tNU9ibFF0WkJoNTJMQWlGSTZnNlZGdjVO?= =?utf-8?B?bExmTzdWUUJnTVpWZEhhNlU3RU9MTnMva1dvbW1JZTFDSEc1bVdGK1dEOVJl?= =?utf-8?B?Y05pOEU3aEFVV0xxM1ZLRVlQK2lhaXJ5aWxvTFhXelQ0TzBiZC9UNXMweHlL?= =?utf-8?B?ZVBqYnFMNHpBQUYyUWp4cExkWm5vcURKWGVNWllGR2NZWTg2dDF1K0xBME91?= =?utf-8?B?Z3JwbnJGMTRsU3EyWVNuYkpsd2pSaTBUUEZhTHVQdlVTOUo4L3BkV3JlcWky?= =?utf-8?B?Yk9Nc1dOSjFTR1N2ZUplNHYxTFlJWW9CSEFvclNnRSsxZEdGVGlCTXkzZE5n?= =?utf-8?B?ckRPdTBaR2dhYXhqSlJaV0c4ZGV5RHMzallEeHIrcGpZbUoyOWRmdE82SzdO?= =?utf-8?B?ZnJZa1ZFc0hEZFcrRllGU2NzS3Z3aVFIZlJNSFUrTWcxcTIyOERTeDVQU1pE?= =?utf-8?B?OHhFUm5PdkRXZi9FRjRod3pjdC9oYnM1Zm5rWC9IaXovM1RwWUZlODZjZVcz?= =?utf-8?B?WWxMdEhNMHl3VUNWWFVXZVo2Z1JIVnJIVnhKTUk3ZmNkTlFFNEhhdkowYW1i?= =?utf-8?B?eTdQR25SbWhwc3JOMVlsTFY2TDZxTTAvS3cxUTNhc2FBVVNqQWpEbHpLUEFk?= =?utf-8?B?OUxmSm5zMjZnc1JpMFZ4KzhMRG93UTFLbzhjQlQwOXVKRkF2SHpGbDFxMVZZ?= =?utf-8?B?cjBUZXptb05vS1M5aGYvbGh1MW5vd05xMGhTNGwwZnFtYW9HYkNnR0VjdE5L?= =?utf-8?B?c3BxZkp3LzBURURBVHVLV1QrWVhWWUQ4VWJjRUEvSWZIaWJQMzl4VUJKT240?= =?utf-8?B?ZWtlM0xTWUxmQzJSN2NKQ3JSYm9wMTdkMGN1VjdxS0xLbkwwQ1hTMDI3bkNM?= =?utf-8?B?aTB0UWtqT3IvTzRqc1lXZko5NXpvRkZSRzZvVHN0UFBxdEs5bjFsdHIxL1FT?= =?utf-8?B?aU1EaTc1Y1JsQUdZU3NRSzVNM3RUOVcwdkNlZHdRa3ZYbkw5aERwYXMxT1pp?= =?utf-8?B?TTRJdlZvUk9zaG1Qek54bE1XNUExUFZ1SjZ0Umg0bEUyTGgrSzhFS2t2dTdS?= =?utf-8?B?OGQvdFJQMkRvRklMcnJkSktuZEtqbHJqUC94alpGL3N4VkpKa3J3V2xGVGVD?= =?utf-8?B?UUV1MkF4N2ZvSjhXV28rc3BWSThpVTJmb3p3SitVYVZHOFUzeForSVc1Y0w3?= =?utf-8?B?REpLSXRBaHVLZURlYXkwOUpVVVpocUtRcFpnMGZrQUF6VTVQcnhaMjdNN0M3?= =?utf-8?B?MkFuZzZHWkw2anI4KzlVL0FFdlpoYkZ4dWx2UGcrM3kwaVRQY0N5a214UnBu?= =?utf-8?Q?vuBAxG3ai6bcByaRbG6P40tfswOobfW97Mn4aRL?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: ddbb2616-ce5b-4ac1-37b7-08d971469f4c X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2021 14:57:18.4797 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: G6/d6yR/MC4L8o+bNxrgNtnQksFbKVdI62Rp8R0sAuZ484tZAMqO0/8L64eqld/PvY88MCg2RbAJC0sR0rbxHw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5744 On 03.09.2021 12:08, Oleksandr Andrushchenko wrote: > From: Rahul Singh > > Fixes: 9c244fdef7e7 ("vpci: add header handlers") In which way is that original change broken? The title doesn't clarify this, and the description is empty ... Jan From xen-devel-bounces@lists.xenproject.org Mon Sep 06 15:04:52 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Sep 2021 15:04:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180035.326538 (Exim 4.92) (envelope-from ) id 1mNGAv-0002Zi-6X; Mon, 06 Sep 2021 15:04:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180035.326538; Mon, 06 Sep 2021 15:04:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNGAv-0002Zb-3G; Mon, 06 Sep 2021 15:04:45 +0000 Received: by outflank-mailman (input) for mailman id 180035; Mon, 06 Sep 2021 15:04:43 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNGAt-0002ZT-Cg for xen-devel@lists.xenproject.org; Mon, 06 Sep 2021 15:04:43 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 97c3c93b-02ee-4ad9-9075-52bebe7f9dd2; Mon, 06 Sep 2021 15:04:42 +0000 (UTC) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04lp2053.outbound.protection.outlook.com [104.47.13.53]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-13-pzqLZhm0Ora2kiQ_tWtLnQ-1; Mon, 06 Sep 2021 17:04:40 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VE1PR04MB6480.eurprd04.prod.outlook.com (2603:10a6:803:11d::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19; Mon, 6 Sep 2021 15:04:38 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4478.025; Mon, 6 Sep 2021 15:04:38 +0000 Received: from [10.156.60.236] (37.24.206.209) by PR0P264CA0226.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:1e::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Mon, 6 Sep 2021 15:04:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 97c3c93b-02ee-4ad9-9075-52bebe7f9dd2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1630940681; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bNdZ6Cx7slUiIr3muINtSAbKCyL8zuOoHJm+tONX/9I=; b=PeiVHg+fd/Fkex+5eLSYxCmkND8DYrY/FS03vOhLrn7nKw02ZUdSqIQZYQBn5/XGIMGXCm B7F43D1CDhK687dWexGsvQDSpgGaIlkeWvZjj4T7B9vbX9OkclrEyLBDdsS7FvXdzMobQa 5/MkWF0T3tg8CEJe5zoK0UmRwkvIHWQ= X-MC-Unique: pzqLZhm0Ora2kiQ_tWtLnQ-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Fd8VZxNT/agSyYAo64p3ultBMpBaZGyDLSDWifE1TJ+DLW/YJspKcqDGtxD47yIWu01jNDMd8nODMoZIYDv8zIklyTPEjq/wIN9pOPhzTmNCLiBKLBbrMAY6Bw5m8IUzq7xF/Z/nacR0356TKarZ9SuNL9/uJAbDlnE2qi1VtvApQoCLU2Q/Po0uXZEl5K4gax/qvZbXOc4n7zEEJpdyxGS105QSAPfnydVSM0WL+zWekaUd0o/wBZrgQ8EPN0BXqLoxgWBVy5p81Hoqgb76yN17AfTLq0t7wkCBVYmPLIp3pnfpw0yJHH7cZscvMJQTcwcrN8KEjMa1InfnT/hUjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=bNdZ6Cx7slUiIr3muINtSAbKCyL8zuOoHJm+tONX/9I=; b=CKssZ+W7EUToHwa/ywYAUUs/vQJIDcaza7LKbvqn8ZHhSZo7J8sxRZtJzKRZAUfXy3JoWDC0+F75pCADtL7SmawcKmCPgdRMCwspfi0RXrhHb8C6wIqRw91OuUTMt97I7IuZSCjlf/Os2duTsVifJFhlzMxZSMrleMW197Ng8NyMbf4voR3Ie+wY0WoEpxpplNLLydHPaCajr2V9Y0D05U0aZ7le5ncBRxxigo+PwQwYH6t6PwuwPJBiv8Gdm07kgumNI1P1ecTX/IoO0TDRCDwp6kSPSc8aE6c2XmRB9cj52TSd7uA9a4MFe/DnCyQYc7CGEjzF5RmsfRMCMIKuig== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com; Subject: Re: [PATCH v1 1/2] x86/cpuid: Expose NullSelectorClearsBase CPUID bit to guests To: Jane Malalane Cc: Wei Liu , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Pu Wen , Andy Lutomirski , Xen-devel References: <239f7624f3ac3793993dc045d451079aa555b90d.1630929059.git.jane.malalane@citrix.com> From: Jan Beulich Message-ID: <203359a1-1f76-70f1-e314-0c65c4413361@suse.com> Date: Mon, 6 Sep 2021 17:04:36 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: <239f7624f3ac3793993dc045d451079aa555b90d.1630929059.git.jane.malalane@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PR0P264CA0226.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:1e::22) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 08b92ff5-2072-44f9-4d29-08d97147a53b X-MS-TrafficTypeDiagnostic: VE1PR04MB6480: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2089; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: jcSSGkWp18dNTu5c+s7GR1YSXcU7SpAu3LHqh3pqF2NMQzWxm2nuVeyh7nxpfhT/VMJF20QtxoJJV4+IwenZuzUkPuJdfm5nhVzJaD4m6ejaxUAsxsdkhLTi5BtTZtYVqBJ6rReNsEtMtuI1GyUSBojAuqm+w6EOYP9WVdahJbkwqMubPC3c6SfNyuX/5uOTdsv00JI1BB/q9d/yrh3x3o4duAZk6FkX7RbB4ohJg5nhbzSE8j5e6cfGq/K8b9ICEGmSYo5BQDQl9u6BQp8waQ1MQL3Vg22vixnobpNnfN1LPgkemkzTf7mWFBe7LobuaFucrjF5TzP70A7F38U9jVI4RPJFZWTn89BRN62rp4um1ZgNEul3MwFkduJke8pIgLEK6LNj8Zq6x4Rj3ACmryoRIP6Oqvsx0ZQgWuL+UW+EOnrbu/L5lSvshmVIJHSQ3hExgUKl/Lxo3GqqXfJ4S7g7Ip8sXeVhB4cg9ZVPjB189JApu5B9gDiJysDDyvtEPB4T9h/mmdWPS4XZvMT9qUygWjs82m3IH/4ZLDhzdf8iAYxNFBqgg/mCD5/HqAJ+2Xz2MHsIxE2X7zu/6Kq9kkSRsEX0qCJVPY/RIiuJHyW/Y5y9oehXggj769TBsE3Sp/6h+ihnkcfRnHIxYa/fufpmCY1X/1ZI/jbS2mpmk/q9WrAW3mdTTDzBOkIt1WWTeTVPK1ML+RoTvQm9gFdwMncMqBg1gKuRo6F8+ALaJdc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(396003)(346002)(376002)(39860400002)(136003)(36756003)(8936002)(8676002)(16576012)(5660300002)(31696002)(38100700002)(54906003)(53546011)(66476007)(4744005)(66556008)(6486002)(86362001)(26005)(186003)(316002)(6916009)(956004)(4326008)(31686004)(2906002)(83380400001)(2616005)(66946007)(478600001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?czRiSmpkWC9PQm41WlZTUzlpR3h5aEpiZVlTUDdhRDhwTG4zdVFKUVppejVq?= =?utf-8?B?TDduaVRQbHJWVzBEa2hta0VodmV5RTZkc01jUFZMSmxnU1RmS3NFZmwrOENv?= =?utf-8?B?QWVacDNxUUFKTTFTbzhPM1c1MTNJak5IRVpoUDl2UTJnY0ZjTzQ3MXozTDlT?= =?utf-8?B?RWdqcWRGVFJYOWw5Tk1nUWo2bXVsd3ZiODlwU3VvcktwUkc0OFVLMEtWbDNS?= =?utf-8?B?ZVVDT2dwd202RThJdGh0SmpYWGxIb0VFM0V3cEcxdlhjRUNaamxvMlVpcytp?= =?utf-8?B?RmszTGpMb0ZpcFVzVnJSSm1ENERrZEtZMTJCSk9vVXJZQzNocWxUTkFSL3h1?= =?utf-8?B?LzBhSWZ2bHVFbDJlSTV5Znh0YUlqU1BTdllXdkNWM0QwdG93dDRwSjhSNmR5?= =?utf-8?B?M3lJeUQwMjdCSDFBWTVQWDgzWi8wZkkyQlo3VUlhMjdlcnQrRm45cE1QWFNn?= =?utf-8?B?OTJXMGVoMlBOTWVDUWF6SlFOcWVVTHU1eGNaMTZyYmI3S0cwaUJGR1lscjZW?= =?utf-8?B?RWIxVkxJazJVUDZWWVEzOTF6aTBKNEdvdmFwL1dSYWhyRGI0TWhDSXB2Q1FT?= =?utf-8?B?bmFzak91TW5wL1BSdUhCODVRZUVTS0NUU2xUeFlSSFBFeU9pQWlhaGU2SWNR?= =?utf-8?B?L1RyVTBEOGx0SzFFVFkxNytCRFlZOWRvYlE3MmE3N2wyT0J6NFloUnM2dk5u?= =?utf-8?B?WEE1NW9PUVhHQXdvRTNla2ZVUkRPTDlBaTBzSmxyT3V0K3U3WkI5eGZEWVAz?= =?utf-8?B?cnJ1aGpoNnJKVUNRK3Nvblh0UmR1Tjc5QW1LbHcxdGtIeW94LzJRM1drWlVN?= =?utf-8?B?SWxNM0thQVA5Ny9leHFUVEFaeFNVY3BLTUZPUi84UG5pYStGbzBlSUswV3p2?= =?utf-8?B?bWJqUTllbHd3c3FYSmxqRW16cEZyZ1o4bjFKNm54b0dNS0NwVDdOT1BuYVdN?= =?utf-8?B?L1ZUWlcycDliRUNiY1BTU05uVVVBYSsveEZvN1dKRTFuRnZRUGpkdmRicURO?= =?utf-8?B?dFN0bW5kdGNEN2pIN0I1RDNKL1NEYmhuNXN2aWlKWW95aGlKNVlUbk9OaFF6?= =?utf-8?B?dTdBZTNoNVJqeXVicXZYZFJFZ2FYN05OWG9rZjNLVDQrblVYYWI5aFl5Smcx?= =?utf-8?B?aVVZYmhOVmtIQ2g2ZHc3Y3dZSVVUeHVmUit2ZVZSYk5SUVFJYzJHQmVTNHhz?= =?utf-8?B?STVHamFtVUlEWDllUm16dkVGY25iem1YWHhsYk5lenhIVkRxT056OVFzcXVJ?= =?utf-8?B?UU9SQWtyWHF2WksvZVlXSHdMaGVoaHMzS0FIMU9kdXdFMUpEUk9KbVdZcllq?= =?utf-8?B?NFB3RU8yYzFuTVQ5R3ZQbm9rYjB3NkgvMGlXbmtiNkZjNE4vcmJ1dERHSkJ6?= =?utf-8?B?c0pjbHR4OTg4eTR2bXJ0OTJ3NGVTVXFmTVZTWTV1YTZuSVNRQjFoY1RkWlFH?= =?utf-8?B?VFJEVUdSMDc4VThwSUxWVTBib0ZvdGE1NTNtaDdmZUF2TkYyZnN3Yko5NUl1?= =?utf-8?B?UzJwY255ZEVyZU1pVTFTanBrNm1oWWt3dmxNUlR3YzNHQ1lOTlc5UWpPM1dw?= =?utf-8?B?Y0RyU1dHaHRvTzZNdFhzNDlNbkY4d2NCUHo5cUh6elRHcXRwTk5mWGd2RTNj?= =?utf-8?B?M2Ntc0h2WklPaEt1YVJXWG1HVE81bGxXaWF6Vm5qcGdlOE8yK0pLV0JLSkN3?= =?utf-8?B?TjhYbnFwUE5US0N0cEluaGFZSmtjbUpJL2dyOE51b0UrSXpkL05ON0o3VzMw?= =?utf-8?Q?QMtA1UU/I0BduqEg838FE1w/QFr9ENloHIyRAyf?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 08b92ff5-2072-44f9-4d29-08d97147a53b X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2021 15:04:37.9299 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ZpTkiRznDRwpQnuMzQHo1QyrMfm/lyaj2LJ/rXetqy4y8YWWimaE4yCSO6OphzSsJtv7p14qvVxpV2AiASwG3w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6480 On 06.09.2021 14:00, Jane Malalane wrote: > AMD Zen3 adds the NullSelectorClearsBase bit to indicate that loading > a NULL segment selector zeroes the base and limit fields, as well as > just attributes. > > Expose bit to all guests. > > Suggested-by: Andrew Cooper > Signed-off-by: Jane Malalane Reviewed-by: Jan Beulich From xen-devel-bounces@lists.xenproject.org Mon Sep 06 15:18:13 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Sep 2021 15:18:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180042.326550 (Exim 4.92) (envelope-from ) id 1mNGNo-0004IJ-Ce; Mon, 06 Sep 2021 15:18:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180042.326550; Mon, 06 Sep 2021 15:18:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNGNo-0004IC-9d; Mon, 06 Sep 2021 15:18:04 +0000 Received: by outflank-mailman (input) for mailman id 180042; Mon, 06 Sep 2021 15:18:02 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNGNm-0004I6-Dr for xen-devel@lists.xenproject.org; Mon, 06 Sep 2021 15:18:02 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id d433e749-219c-45e6-afda-c2433cf10c6c; Mon, 06 Sep 2021 15:18:01 +0000 (UTC) Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-am5eur03lp2051.outbound.protection.outlook.com [104.47.8.51]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-4-LYPiVYPMO4u0kudWfCMQQA-1; Mon, 06 Sep 2021 17:17:59 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR04MB6302.eurprd04.prod.outlook.com (2603:10a6:803:102::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19; Mon, 6 Sep 2021 15:17:57 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4478.025; Mon, 6 Sep 2021 15:17:57 +0000 Received: from [10.156.60.236] (37.24.206.209) by AM4PR0701CA0023.eurprd07.prod.outlook.com (2603:10a6:200:42::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.4 via Frontend Transport; Mon, 6 Sep 2021 15:17:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d433e749-219c-45e6-afda-c2433cf10c6c DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1630941480; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FdCd0JKyDD9QE5Baa1mY81Z0aybW8BdpAIrhBi9YKkA=; b=EnJHLqwQRXkfbqWrR6BABUmC69eWRN/XKDlAt4xKS64iVX5EyYCGwyUGUKfGc5KySKAlyH 1dC+80k0q4MpaVQJaOCNPKRMAYAsSYlswiVwCPu1dUjgCMqCRB7XwZublHbROVNPRi1qE9 Oz+umVYCE5MPh11+9CNEdlyqw3Ym5z0= X-MC-Unique: LYPiVYPMO4u0kudWfCMQQA-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NcH7BRB4QfsE4qI5YLnKnB++J17UcwM358d9O/Han3EoY6zLOSjxMpQgSRY/IRDzIkPKNjeSifekkxJ+6lb8fCJoImhvujMnhGjKbYEx5HLv3OtB40OaLut5ulDaUSAbmxB0yfByS7ndg+jQMe/gA2ADq8ejbZ03XpkGcYg8f7XQ7dpNjSW36ntwtGeDXRLmyrPeyFc/+v9LJV1x0oBYSvAXlSCf7mZL3I3m9WzyEOnOILakMZnXCv4CBpl6iriahfjlOJeglsu49KGXAvfPOtzT4DPN1erquhaRO8xF1X24dfbDv5xyae02QPLJ/nMqiFulVnLxwIXuL5hX5RVFAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=FdCd0JKyDD9QE5Baa1mY81Z0aybW8BdpAIrhBi9YKkA=; b=ik+HONU9/etGr8GuVTVlDtswh3MRn/Za4SCUSOoXAAZ8ra/+nM7jdhpOCp/KL4G0V8LHnEWB2aKtsdgG2U/H2mx17R9YPMsieFFFJl3w6TnLAcw2WHyjOe/7OSed4PnxwIiLybDNHR48wwbUpI4mLKMNsSfX4lwWFHXmaswrTChgVWZ8VV3PcS76uaDw3LLQqg9TE/bUbFi/X+4tJfQji0yj5742RlRpkl448adRS+rotDRFmxM/KJ/NbUKvh2D2S6KDfvXLAh/0acPz6vLJ2JvAwMsw/2Uuw1f4kqo3qANOtXV2SDGKTEfCPxaro+qMDhqjmtDiCrosm+dhT22VcA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com; Subject: Re: [PATCH v1 2/2] x86/cpuid: Detect null segment behaviour on Zen2 CPUs To: Jane Malalane Cc: Wei Liu , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Pu Wen , Andy Lutomirski , Xen-devel References: From: Jan Beulich Message-ID: <26b88d5a-ae6f-0065-7c3f-5eeb6dd80078@suse.com> Date: Mon, 6 Sep 2021 17:17:55 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM4PR0701CA0023.eurprd07.prod.outlook.com (2603:10a6:200:42::33) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5e6f0b92-df84-4f07-0e95-08d9714981e6 X-MS-TrafficTypeDiagnostic: VI1PR04MB6302: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VvmXU54w1o+pBl//WH8iStYC4PNZt5OOgQHEcKvf9JqaVNmpb2vyGp5Vfaik7Au0PwI1em92KHjHLVUuNsRREfS3y7KGvkuYzF+vGOeihhxkWboORVyzb9k2nh7301A3GFcssvtnHGgkfgq/L9EvWrmZIsmif37qIsvEormJS7zOmbU6+q+Vwmv0IZhGK2Mef1bwydgaCGa1F0dbjhd90alwF9nsiWDBU7Ccq4WGLIueMpisyEVNAlyDfADW6XC6xC3V1t5TBvO7MA/TTS+GhrvH4p2qmYWH9jHTH9GxQJAHd0iVCh9pvxMJT7oiEt9NszBDd7A70opKaNRhDEmBlL4UrZQckRblviMZouHyOEHhKxhMuSNt6h6nuIxN5WsD7jFx2gTbyLQZlniXb3fuQkI9wD5lCcACFqJT0rtzzBb7WB0mrh4tYK/pj7ko3OvTau+VBD7B23POgXWhcwnhY7/Ux1YM162uPrtRPisgHEcRNpEY4LA+9M6Q2pW3b2sqGlAAt235snQTyJQTpTA/HF7PZSnk/KjdEtYmVR67Nf+nOM0PzW/+04bSlDQ8GiYCgFvO5URBTBT/423Tgy29LzYklHxfM4uDBacB7F5hCQ4jpgQAH7lR14QOPfRPA/kfoKPPqyLxZi4G9GzVzjO5kTnQNWT8Cle5cIjZ9za4G+cEiZQ2uIei5+Ibw9As3hPCcojvpt8hTSxkGeNIVsF9tXOTt5FD5ZofU3h/UuYmaPo= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(376002)(396003)(346002)(39860400002)(136003)(31686004)(86362001)(26005)(16576012)(186003)(6916009)(478600001)(31696002)(36756003)(4326008)(5660300002)(54906003)(2616005)(956004)(316002)(2906002)(8676002)(38100700002)(8936002)(66476007)(66556008)(66946007)(53546011)(83380400001)(6486002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?LzNoZHEyWXQwQVRhU2N3bXpCUGNjazlXLzYzeUFiL2pEYjhob3JqNStTY1dl?= =?utf-8?B?NU51aVpKa25TS1lUUmpSZWp0ODZETVZsb29lZ3ZhNkhaNk5TaW1ZYzNhZTc1?= =?utf-8?B?SHZPd3ZoaXJrUVZMYUJ0dVBKa0pWNnpBdXgyZC9Va1RTMHM3WXJ3Q1V2enRl?= =?utf-8?B?VStBUUVZdEd0b3ZCTGMva3U2S2ZPTVNTRFBzbENKbkhiVnRoUXhiUFhNR3cr?= =?utf-8?B?TEh5dCszbHdtWjlZeFQzd1hMVTUvaEgwZk9sZUgyTkpQWDkzZzBaSVFUU1p4?= =?utf-8?B?RHRUVjd3QkFNckFydmMxVUl3Y3QwVStnRzJ3QTJKMmUzcDVBdVJGMldTSVY5?= =?utf-8?B?SGZUbnpSM0pCOWsvdHBydnhNSzRKNDZFUVhLSDFScTlJM0I5c1B5Z2tNNFlh?= =?utf-8?B?djIzVnVlZ3l5dnIvTEpQdS90SkxsMG1ZQzV0NG5GYXEvcjM3VUQ2L0NscFhZ?= =?utf-8?B?UWJzTHdFUzRDdkdPYVk4R1ZCTVNjY0hBaXZkS1lxdXd1dzl1M093cjdVU1N2?= =?utf-8?B?UFFPaEIvZnlxY0h3NlZkbGtkc3NaVU96YzNHS2tOS0g5cmZ5eUNzaTdjTk5E?= =?utf-8?B?WGpaWHhNZFgzamxLTlFacURjZ0dUdnZrT3gyd1BuQWJSdjBpa05NRXZ1VGxV?= =?utf-8?B?cHAvY1AvMlYyby92cU9TMEd4TnRWcjFhRTY1OEpuSkpKYWhuR2EwRFpBaEJu?= =?utf-8?B?NzVVWTB6NnU3K0hKUFRsWXBZMXJWOWNOTE8zNy81blU3dWtDMmQ2SjlRV1Va?= =?utf-8?B?TmZvcGdvVUdVWVFSUkhtTzE5aFlyKzQ5NXN1elU2L3dZRGJpZi9MNGRoeTNQ?= =?utf-8?B?bThYZG5DUUdQRHFseXl6QzlIWjl3bTNiTTA5c3REc3JpaHRpYUpNbFBXaytP?= =?utf-8?B?T3ZBUCswbFlsMWxZd1QvNGNZVE9ZY1hqOVd0Y2k5NTVMZWlZdCtPcnFQTE5w?= =?utf-8?B?ZVduZk04dzNCcHRQSUJxU0Z5aENUK3k5WmJPWTNlY1NVNWNXWVluK0swY1Rt?= =?utf-8?B?S1dqc2pDdkNjQU5EeXFkVFZhRHBXblQ5U2ZOYWEvQmdhbmFXK2NDU1dncm84?= =?utf-8?B?cGRDeklEQVJiTW5oaFlUMUJRT2dWcllOUkVrWllGTHJHMzQ2alBwWDJjQmxZ?= =?utf-8?B?QnlESEtTSnlwT2p6dTRodzIxbXJzRktDck9VZ3NoeXc4T2NmRDlJMDNpWXJF?= =?utf-8?B?YUE3QUM2ak1aQVhodFBRK3B4K3lWR1pxYmpTZDhqa3dqQ1laSXBHRzZmVHhj?= =?utf-8?B?T09VRFVPRkhSb2hFUXg4NFVRaVRoVE5QY3I0L3ExWGZWbkl5WGxyeS9jSkRp?= =?utf-8?B?YTNRK1JsL25KYi95dTN2Kzc4RW5IeUlXUXg4NlBwNGxkT3krUEpyNHZLVHJB?= =?utf-8?B?SFVjTDFSNm9EcWZLMVhVOXFPMGs1NVEyc0RFcHZzZFQxbS8zOVkwbHJWT1Yy?= =?utf-8?B?allBbHArNnJoM1hzNnVCcXZsTGoxT3M1V29FbzF6MWN1Z0hhc0RoU0h3bXlZ?= =?utf-8?B?KzhxUGdHdmRvRklGbzl4bS9objR6WVZPVXR5dGtac3YrdDBTbk1GaHFMNzE1?= =?utf-8?B?QWkxcmp4clgxd1Q0emhXeWlIYjFRdjVJSXhzempVNUdsK0MvUVhCcTRFUEFs?= =?utf-8?B?VkhpSEVkQ2tCZmFJdXducWtCQjMrZTRwYmFRLzlCTDhxM1RQbDErZHJhMnha?= =?utf-8?B?TE1oaTkyZFNyS1RzaVVjZ1l0OUV3enQwb3Jtd09aTWI5QnNJakNJeWtzVFhX?= =?utf-8?Q?BAAE8R3oH7Q0/U4tbd6GgLQono/Twy5ZTANsjFP?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5e6f0b92-df84-4f07-0e95-08d9714981e6 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2021 15:17:57.6584 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 21lLh7WhMg4mm5/yIXse6kZU+56GJcq85eFhh77Z/wvErLfnPNnBm0v+dkmHsQHhiA2oqWJPWITthk2W3shkiw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6302 On 06.09.2021 14:00, Jane Malalane wrote: > --- a/xen/arch/x86/cpu/amd.c > +++ b/xen/arch/x86/cpu/amd.c > @@ -681,6 +681,19 @@ void amd_init_lfence(struct cpuinfo_x86 *c) > c->x86_capability); > } > > +void detect_zen2_null_seg_behaviour(void) This can in principle be marked __init. > +{ > + uint64_t base; > + > + wrmsrl(MSR_FS_BASE, 1); > + asm volatile ( "mov %0, %%fs" :: "rm" (0) ); While I don't strictly mind the "m" part of the constraint to remain there (in the hope for compilers actually to support this), iirc it's not useful to have when the value is a constant: Last time I checked, the compiler would not instantiate an anonymous (stack) variable to fulfill this constraint (as can be seen when dropping the "r" part of the constraint). > @@ -731,6 +744,11 @@ static void init_amd(struct cpuinfo_x86 *c) > else /* Implicily "== 0x10 || >= 0x12" by being 64bit. */ > amd_init_lfence(c); > > + /* Probe for NSCB on Zen2 CPUs when not virtualised */ > + if (!cpu_has_hypervisor && !cpu_has_nscb && c == &boot_cpu_data && > + c->x86 == 0x17 && c->x86_model >= 30 && c->x86_model <= 0x5f) DYM 0x30 here? Or 0x1e? In any event 0x5f should be accompanied by another hex constant. And it would also help if in the description you said where these bounds as well as ... > --- a/xen/arch/x86/cpu/hygon.c > +++ b/xen/arch/x86/cpu/hygon.c > @@ -34,6 +34,11 @@ static void init_hygon(struct cpuinfo_x86 *c) > > amd_init_lfence(c); > > + /* Probe for NSCB on Zen2 CPUs when not virtualised */ > + if (!cpu_has_hypervisor && !cpu_has_nscb && c == &boot_cpu_data && > + c->x86 == 0x18 && c->x86_model >= 4) ... this one come from. Jan From xen-devel-bounces@lists.xenproject.org Mon Sep 06 15:48:28 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Sep 2021 15:48:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180058.326561 (Exim 4.92) (envelope-from ) id 1mNGr7-00088h-Qg; Mon, 06 Sep 2021 15:48:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180058.326561; Mon, 06 Sep 2021 15:48:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNGr7-00088a-NZ; Mon, 06 Sep 2021 15:48:21 +0000 Received: by outflank-mailman (input) for mailman id 180058; Mon, 06 Sep 2021 15:48:19 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNGr5-00088U-9s for xen-devel@lists.xenproject.org; Mon, 06 Sep 2021 15:48:19 +0000 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 9d40a1fa-d63f-473a-9c81-61d5e52bc2fa; Mon, 06 Sep 2021 15:48:18 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9d40a1fa-d63f-473a-9c81-61d5e52bc2fa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1630943298; h=subject:to:cc:references:from:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=ZW8rLL2Ju+LwKmfKg28mVm/orxZTxzhvsjw8xsAcAL8=; b=SW3HaML5diHR0KeK+K6mn3ZcUwit83U9Yad6VgeDWo0I1e/LIbY3TxKV TTUCzSwut/Xxz4+vfdZJ3a1DFEdNzbRsLYV6mg6eZZU01fDCxB7nmxIia e0Oyy9sw4paP8ZrJwR5G1xbCjjDP0q6wsWhaIPrsAGuR0NAEEhHS12w4q I=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: szFn5Rx2CcSuwwNQSgdCA4V9pzjhPGxgwYXW4zhWAc8u8kbqhc0/avN1YHIM9EPT+q6qH/K2Xy amKg1jbA77nB6bRwsS7Bw0UL83AJcFIMGRTC177pmGimOmEEjayrapbqPDf6v6wOwp1l09fCUh V9PTFDsiaoXw+wivSubxBvA835Z1c+UE+mBe/G+H23rZyi1zgx89ifsPCsW+2G280kzzYElELp 2Bi23k1lajzKsYwON8W0RXQZU1+968rUpNlqrfVdhMyoASlObHkkg3kLdvSSD7wkeku3/n3ax6 Dt3q/SRhRog2nMUsqBjjNkQ+ X-SBRS: 5.1 X-MesageID: 51703951 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:j2H4TK5mw9yxhWnR3APXwD7XdLJyesId70hD6qkQc3FomwKj9/ xG/c5rsyMc7Qx6ZJhOo7+90cW7L080sKQFg7X5Xo3SOzUO2lHYT72KhLGKq1Hd8m/Fh4tgPM 9bGJSWY+eAaWSS4/ya3OG5eexQv+Vu8sqT9JnjJ6EGd3AaV0lihT0JejpyCidNNXB77QJSLu vg2iJAzQDQAUg/X4CAKVQuefPMnNHPnIKOW297O/Z2gDP+9g9B8dTBYmKl4is= X-IronPort-AV: E=Sophos;i="5.85,272,1624334400"; d="scan'208";a="51703951" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=P4ahkLnBPGH/J6zIrsH2R47SfkgSH3cyayht7Is/8Wt6EdzxP5+9LRaQ6dStqADi2qSZMFYKSLF5vZ8L8ZUDJd6aoAehMDZsGLhNuL2oVum+5Xp7HWx9H38QWW3aQV/rTVe0dMimydRql1+F/tEEnsqSdmoCb7ep6s6SG9oSPDcHkxlH/krBhvbIrDIRp8p97hsp6xWlaf7/cnYSh7WjvN677xbebI3Lj0/bZYtWIgdENNyrJv0QmbYY23nnW18oRoBenfJP0689txVaky24DoZODKc08siJuPq/RRvNLTtCs/Ihux3xykeuok0JRwlozlq2MD4TyBjyMvRAxjrwXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=vLg9oQJLQc4EgCHbSr6T90rQDY6+Gti+7IBwBOjZGbY=; b=SJbpy3EgCZ8UXkgwW3Dhq/zC7VIU5ttzfDwL5Rk5sFJNx3jJcEEOYGAjBxH09hU8kYok5IO3D+glN3oHKtw2p31DIBPf3f17bFL+5QSRs81JwYyLtwfPUtONwUs93pOTKTsXo4ri3YivfpbdqdytfSzHzIaIoEgj/eYqHB/V+SLETTsqIhvOKwDFHf+o4UHyB3gSWb+CSWmpHY3ksGdXr9tarJyQqqz9jK5udCOPzyGWHmCzuAk93Wh6Cj1TykKZcl2ZRxe8z03HQ3tP5jnRZ+ONjZdEp5q391/XsLhD2QU7oi5+dohlZkfcvZnemXBjK6NoS8PiXt7esxY89O6j2Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vLg9oQJLQc4EgCHbSr6T90rQDY6+Gti+7IBwBOjZGbY=; b=fvMhLCeYD61czJreXW+pOAnmpMyj33eXcw7h6FMjlsUGVy2EndwOXFspifROUJkFJp93LbRAsoEmwJ+XHbBXtmncIJrUmGzFYKpCAQaMhndBoUbP79kiAIsxYbP2ryunq2rdKYxUooaa9otDUl2lvLKu3Zk4GrG2SO90u4w5GpU= Subject: Re: [PATCH v2 2/6] x86/P2M: relax permissions of PVH Dom0's MMIO entries To: Jan Beulich , "xen-devel@lists.xenproject.org" CC: Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , George Dunlap References: <5972ce4c-bdb0-6d07-afad-cf4dd5615488@suse.com> <457637e2-d35c-18d0-ead8-0b513b257927@suse.com> From: Andrew Cooper Message-ID: <9b7936fc-f81a-d5e7-5ceb-6e10588503dc@citrix.com> Date: Mon, 6 Sep 2021 16:48:07 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 In-Reply-To: <457637e2-d35c-18d0-ead8-0b513b257927@suse.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-GB X-ClientProxiedBy: LO2P265CA0096.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:8::36) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5a2441a8-bb9e-441e-ec9f-08d9714dbc3d X-MS-TrafficTypeDiagnostic: BY5PR03MB4966: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QxgfqcIIXmpfgh+TmsFMbnCev7yqppudYl2WK9Bh+U62reyc+eGhs/HcyhP/XzeLx97mt4G/aUvuv0etePk+bzkBIpFSTYqhlX8ZzV58pAlYiY27h8JWBa0bFqyCghFRJ+/+VpoVPGCKyaVrmvigXj3FTMwBwQ9zyIhTNREBy5QdKK3pyBHMk9vZoCBMpM/eHNIKIhovKWB9Y++usOHoXO9SySXfzpkz2ef7c4TO/YmbTLatzmXIHOKslh9997Rt4e/y/cyTDPuINv0x/0wOieDWZAM3eW6rrw1WHOPf6eB51gsTcuqleUl8dDNEFUr34dl/D0w8ypcU2lXw2R4xyyvXvXV8Yf1OEpvP1rKlOeDz9V8pb3T8D/EWw7qPHso0ueeOXCzup00K9zAg5rB8zBOnY6gxpbQahZ6bdIzgLy+Uq01mYQyIwBCxs5jSgLMyb2bM7nIvIldJahb5V3Fa3gYveJOkTT/s3mOIpdj63/1mqimMaC16ioC0yT8bvKgQ7Juw7Qu0lyDlERzemf/zbg4Hf+NewcjpMMCFdulLs83jw6evChvXYplF5RJPd3sVdywgOnwGvVp1R7oHcRC/iopySp0CCm7Du3SK8HWCUl4aW2SgOTlTWW43OhoLcQvEaj2Osr2Et5SF2zVUBx1wfPlnVnM+6zZT8Q7b9ZRAC8g1mYL00ZZ9ig4bPPWfxDhP9dcQ7rzox9KDbMJKgnmR676OIBNLgOBhqdMYRy/zNkI= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(5660300002)(86362001)(2906002)(53546011)(2616005)(8936002)(186003)(8676002)(55236004)(6486002)(31696002)(66556008)(36756003)(54906003)(6666004)(26005)(16576012)(4326008)(316002)(66476007)(66946007)(508600001)(83380400001)(956004)(31686004)(38100700002)(107886003)(110136005)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TzF2UDdLTVA4alZweVBaQ25Xcnk1bnd0NUNnTWNWT3BrKzVpWHZhSGkvL3B6?= =?utf-8?B?TkJZYnBBdmpocHNxZnJYSUZ6ZVRpNElwc2lMbEZKbFlMU0ZXNnRLckVjM2Nq?= =?utf-8?B?blJ5eFNUQmFHU0tyeDV4Yk15ZlRwS2J5UTh4c3N1VFE1aE5QNTRvVnJoT2Fk?= =?utf-8?B?THZSZ1hIaUQvYTl4UVY4VXpMdDEzWStpNFFybElOMzBGQm1FVzZ4VWRvRlFK?= =?utf-8?B?bnYzMDRUemFBcWszNjQwYTFaTzZURWM5dWo5eW4rNG8xUlE3V0EzajFYVm5X?= =?utf-8?B?N05WeFgyQkJ6eld3RnlveGlrTnlvbkhpYW5JZUtvdndhbnlaYTBXMVIxNzRK?= =?utf-8?B?UFJjVFdtTElDYnduYi83cGh1MGg5ZjFFdkNpRjdBTmxtY25kN2FOVDc5WFFV?= =?utf-8?B?MC9zV2hhWUxmWVQraWlkVENuYTBPU3hVczRKeGwxMXVvWm43bDZtaTBhcHZv?= =?utf-8?B?MkYrUVR2UGpUYVhEbUxnVXhXZVlQMTBIUDVMc0tzQWFwN1ZPd0FUR01DM0o1?= =?utf-8?B?Rm5nSU5lWFpzRzRqaXFmeHN4WFE1cUlLRWFSVHFManYrWk5HY3AyK1krTkVY?= =?utf-8?B?b2ZndjhiV1BuT21mYzJMQThINzlJRkIzK0NWSkNsZ3ZGditRUFRneDJvVUpm?= =?utf-8?B?TmFsME9wNUl0Y1grRXI0K2VjdE42c250RnRvekRwQUFlaEYvQXhOVFZaWmZW?= =?utf-8?B?S3R0clNLaVlIekk4VlJkbkRQS1FObGoyV21RSTZuNWVjWGhRWXliOG1QVnhm?= =?utf-8?B?UTJIdUduMjJrbEg5SGp2NDM4eklCczZXbUlscEsreks3aURYQXZFcEd1Rmxk?= =?utf-8?B?QVpiM1RZWXYzeGFDaU5JMWNDa2E2Vlcrb2RGTDUvUEJBTi9wZm1CSjhaZWFx?= =?utf-8?B?UVBycGQ0eWVJdXJJU1g1aEZmZHFhUWtJUkpPQVFTcGlORHR1UU14dk5RKzE0?= =?utf-8?B?QXZSa2F3TDJvYStXZmZHVkV0c25xMTFKUDcxdTd2dUt4MU1jemw0YmRoOUh2?= =?utf-8?B?by9VNnA4dGo2amY0ZlhhaTVoeGVSditkMlprQVlOT0c4MHpXSEFSREpkOENX?= =?utf-8?B?RzBRUkI2b0Y5VXJmcTFZN3BNQTVKU1JQemlBbC9yN1BaaDBPZlRZOHdydmxT?= =?utf-8?B?SzB2TWpCNUJYOXlScW9xcVdZaWg4TmlYV3ZkWGhzMHRQTnArOGJobjdnYk9E?= =?utf-8?B?aUowdGRXWmhWeEVLZzNKUmNZdEVyZGpOd0pYaDcxcHFqeXBqcHU5MDRFTjdG?= =?utf-8?B?TEdrUzhFb1ErWmRKZDBLR1V4c1hYK09rWHMzU2JrQUFhWXc1SVA0eFNvMUgy?= =?utf-8?B?WHl3RUdhM2dTdG9XNng3V2xkMHFsbU5mOGxDOW5qRmx6OVc2MmtNUW5TUjdW?= =?utf-8?B?dnIrUDVlMDdYdmVuY3orWkR5ajJmeWVGdTZLYThPaGdidXFSYUc0RDdQYVRk?= =?utf-8?B?REQ1S2YvOWltK0owai9rZ2x6THBxd1paZE9UcE9kMGZDK1doMU9RQWVVUld5?= =?utf-8?B?ZFNqUnVJZ3ROc25EdFdTL2RJaWRzaXFsdlRUcmVRTWF1VnlCcGxCamFuUFdz?= =?utf-8?B?VnhUcUFhVmJ6RTcvWmJlbXQxSEFDQXpIQTRwRnNreldXWExlTUpQTWJ3aytU?= =?utf-8?B?SWpLbGNyU3ZDbGgwcjFzZ0VpS3A2anNsem5KU2hwdlFhQS9WZlc0a09GVlpa?= =?utf-8?B?Y1poa3MwWGtPdkpHVzBFM1IrSTRVTllHMG5XeWNQWWlFbDMyeXFxOXVtSVNL?= =?utf-8?Q?foK6awgck0okiIU/bfleyTi8+RCuzX6oTWozsK5?= X-MS-Exchange-CrossTenant-Network-Message-Id: 5a2441a8-bb9e-441e-ec9f-08d9714dbc3d X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2021 15:48:14.0077 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9EPCwDyiPSVK93v8mLg/Wpa/UwxGc1Yl9Llx0Ew/7Ud+raiHrd/SLQHLITTKETJ7IDYWlIlVoO3wOLFc/1qDmFkdpqfTztMekTjxuRlip6Y= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR03MB4966 X-OriginatorOrg: citrix.com On 02/09/2021 09:33, Jan Beulich wrote: > To become independent of the sequence of mapping operations, permit > "access" to accumulate for Dom0, noting that there's not going to be an > introspection agent for it which this might interfere with. While e.g. > ideally only ROM regions would get mapped with X set, getting there is > quite a bit of work. ? That's literally the opposite of what needs to happen to fix this bug.  Introspection is the only interface which should be restricting X permissions. > Plus the use of p2m_access_* here is abusive in the > first place. > > Signed-off-by: Jan Beulich > --- > v2: Split off from original patch. > > --- a/xen/arch/x86/mm/p2m.c > +++ b/xen/arch/x86/mm/p2m.c > @@ -1319,6 +1319,18 @@ static int set_typed_p2m_entry(struct do > return -EPERM; > } > > + /* > + * Gross bodge, to go away again rather sooner than later: > + * > + * For MMIO allow access permissions to accumulate, but only for Dom0. > + * Since set_identity_p2m_entry() and set_mmio_p2m_entry() differ in > + * the way they specify "access", this will allow the ultimate result > + * be independent of the sequence of operations. "result to be" ~Andrew > + */ > + if ( is_hardware_domain(d) && gfn_p2mt == p2m_mmio_direct && > + access <= p2m_access_rwx && a <= p2m_access_rwx ) > + access |= a; > + > if ( access == a ) > { > gfn_unlock(p2m, gfn, order); > > From xen-devel-bounces@lists.xenproject.org Mon Sep 06 15:52:19 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Sep 2021 15:52:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180065.326572 (Exim 4.92) (envelope-from ) id 1mNGux-0001Oi-HE; Mon, 06 Sep 2021 15:52:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180065.326572; Mon, 06 Sep 2021 15:52:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNGux-0001Ob-DO; Mon, 06 Sep 2021 15:52:19 +0000 Received: by outflank-mailman (input) for mailman id 180065; Mon, 06 Sep 2021 15:52:18 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNGuw-0001OS-DT for xen-devel@lists.xenproject.org; Mon, 06 Sep 2021 15:52:18 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 5917e309-8132-4e59-9e5d-232a1e1460da; Mon, 06 Sep 2021 15:52:17 +0000 (UTC) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01lp2054.outbound.protection.outlook.com [104.47.0.54]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-3-B6XkD3duPKSlItBJVN3VAQ-1; Mon, 06 Sep 2021 17:52:15 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR04MB5325.eurprd04.prod.outlook.com (2603:10a6:803:60::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.21; Mon, 6 Sep 2021 15:52:13 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4478.025; Mon, 6 Sep 2021 15:52:13 +0000 Received: from [10.156.60.236] (37.24.206.209) by FR3P281CA0028.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1c::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.4 via Frontend Transport; Mon, 6 Sep 2021 15:52:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5917e309-8132-4e59-9e5d-232a1e1460da DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1630943536; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=L7UKcM4S9tKAzyGGYNFS3Wo9PSeC76IYZoeIv6naCYk=; b=NP/XvRsOF3kwlIVghVZwNHuFV6xZen329F2RgfzPmeiYtveyYyRaHA1ULTdDn/Akyxfnis MbzJwQDm/D6WaQnOGrFrK2AizLjmRqNJf3C57dDjx8Di1hanwzhLsiXhI/ywIJw3bOY69r trLOANHfUELv5dc8Bfuo/enF/1a6veM= X-MC-Unique: B6XkD3duPKSlItBJVN3VAQ-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eqCdVsoSwNMZymkJeu6shrlDE7askClulZsXxw6Dr03LBi9DhUNYfy1fWuopynjT20WVdRvju2qHrvvI5zwY7H9sNQamNBQRCD1u8UXPaihz9ymBvoMM/iMLzbgEHIxg+QxJt6D2RAnYGmW2iZ/KXe8a0mSpIMOmd9nPz0G0/zM5iwgTFgqG6l32K6u9Ar63MNYCeELtS9gQAxYhoXZxn15Fm6IZ3kruE6u2+i38Mzs1RrbWOGryS6dtuRZKLRoy7W+6ySZ9Aly4bSG3COP2xoWdgF4A9HNFmXP7I5rZgzNvEazHIEi+UVMRjIkz5A76EwROn+OLfnLB5rYADNLZfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=L7UKcM4S9tKAzyGGYNFS3Wo9PSeC76IYZoeIv6naCYk=; b=jkg7Kywyvh3UFDR37yqIl2Z/sJVA21A9MSr4GIA7cmvuhFAV0UHen3NjKkr9ZCy4isqyfyCh9P7EVP5ew7eWfbkEnnykkfpUIpKyp5HuTrjsCSn20uuGQDfZz1DfeE6REZ+3/Gx1el437aaTwoOPf8snj7vmf4dxns6xflKNphUDuxL1MRsuHjrEY4pPFmP6RwylFY8WDQrp2e/AjIRXKePaby6SF2UwV1mjacCLPL1KpFGkyEuMUQDcPQ9u4+e5izcjcS9ouZDeVTF5eNa7utuvBEht3/TKVFnD//Z+/562JmvD75sbnUX1krWdq46upc6YofmGf2nVdiZgRAFoQA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com; Subject: Re: [PATCH v4 01/11] xen: Implement xen/alternative-call.h for use in common code To: "Daniel P. Smith" Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Bob Eshleman , Alistair Francis , Connor Davis , George Dunlap , Ian Jackson , Wei Liu , xen-devel@lists.xenproject.org References: <20210903190629.11917-1-dpsmith@apertussolutions.com> <20210903190629.11917-2-dpsmith@apertussolutions.com> From: Jan Beulich Message-ID: <3a91e4ad-50c4-205f-3d90-f23c996b2938@suse.com> Date: Mon, 6 Sep 2021 17:52:10 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: <20210903190629.11917-2-dpsmith@apertussolutions.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0028.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1c::19) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 70eaedd1-bfd6-462e-d501-08d9714e4ad8 X-MS-TrafficTypeDiagnostic: VI1PR04MB5325: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XPBuEpIZJHXJ/zq749VVD0uO1AyOnXa0eT28Ib65HMWa7fcK2VkJyrpah1baaEPUeMRASbvXalkR3s6RX2RE+1eXwFD0VzC2WQV7jYEK6xTOWnwjd3AwIKqTTuGeHhrSHN5CsiYXRLh394YwWdjI7p8El7cRU6WlAHPlOpxmhhRHfwufZ52xTBzdHsleBThHYAJq7Ykb0ZpZbpNt5vG/O/iEszfea4uw7JO7hucDgHAHbzH0vkLhzmy+6sMgG/mDqfn4q8XujUZ1HYBC6dCppHoXldh69Gz8C5hvGI2SQERXxnDGIWP8pYhEbd3KS1DH2znZqJhQ21rhVTku994y9g/9apy1hIv9WCKBLnU9lzwOtoZj6ham2vphgUF7YYenOrT+jCTxlo7idufc3gZ1Hv3mROzxD4SYJVM7oxvNDbfx3KnXFzOZlCSjTqxMA0PPn971eY4lHxPIJudJh19o2hPtl3cVfmrvL4clioqCwlVbXa26WXbcyGDFMnKeNUMflDJLhdWB6VGmIJvitouYXsL6kosVRmsEe6IPdBVp/OWqKxDrlc1FvkRDfk/JSjws+fLClJmNMioZggCWHC1dohRAitqEQ+B2qVOp0GRopesJiLigPlWbt6Kn+7NHrmG9syBbaYsgooXb7Rg0Zlih7+pVX9x183drs+/BgtyWC0gxu4tkuU18JaD2msYDGcT0Bm0AsSLzflJUj46xdycEWJxP6F2+R7N1o6uRYYj+dJY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(136003)(376002)(346002)(39860400002)(396003)(54906003)(53546011)(5660300002)(4326008)(8936002)(956004)(38100700002)(6486002)(2616005)(83380400001)(31696002)(6916009)(8676002)(86362001)(26005)(316002)(36756003)(66946007)(7416002)(31686004)(2906002)(478600001)(66476007)(66556008)(186003)(16576012)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MEt6Vm9xaEtkRjR1QWZGV3hwdk9JSSt4MDFSOThnUEZtTlZCQnIrWllCTko0?= =?utf-8?B?ZFlFN2N3QUh1b3RQMVV3RmhadmlRd1pWeG8wS0dZRWxNVkM2eTJlZXVyOHRG?= =?utf-8?B?SVc2SklyNEV2Z1ZKMG9Xdm9uYnZ2OERhSWNnMmhBRSticVMyY05JUTdPdEE1?= =?utf-8?B?dWw0ZHA5NU8wNVkzK2hPaCtEMlphT2NDR1IrNVBjeE1MN0l4TUNtdUNyYm9a?= =?utf-8?B?Ty9naXo3L2tFNU1xYVBlalV3VlVaWW10MG40N3djZ05ndXRaRzBrbUFvdDU3?= =?utf-8?B?ckxBbldlRXo5SnhNb09xT1l2WHprZExtdTdXcUp5R2l1Q3l5aHQrakxibXF5?= =?utf-8?B?VWRTanQwTEJpcnRlYVY5VGR5RVRlNUFheG1XWGJwaFk5QkNCUGtZUHZYbldq?= =?utf-8?B?VFBrWi9wL0dkbTZkd3lXS2h4c1h5TkYxSVVqMS9neHFFWmswTmNETnlacW9o?= =?utf-8?B?YlJQNWdzUTB6azFUSzdxOXJTZ1N1UVhET2tJeVcrSlZLRzZaRXdlMlZJem1Z?= =?utf-8?B?aWZTbVdMVHJjUjJhWTY2RGZLem5lS0JSRkJCT0lUUkk4cGY5bk91ZmhDcjlJ?= =?utf-8?B?WTIrcGIwQTZCeXNheEh5Y3lxN0lCOFlyTmZUZHJOcHJUU3ZIMnJLZXQ0bWZa?= =?utf-8?B?bjNpc2ZLUmpzczVYMnlXYWRNMDBnQkVFT2w1cUgwT2N5c2dFY2JpSmFtTkdo?= =?utf-8?B?TWpoUVgzdmo1ZXdwalBZNWNrMmpuWGZZSWFzclpzbnpYWE5JWUJPQzlRMHJ3?= =?utf-8?B?dzRDNktaekxXeVBCWnUvVTFGd1paOUgycVVoeUJ5VCsvV3ZGdE5rWEd1ZjFM?= =?utf-8?B?aHo1LzFSVTNUZjhuZTJ6MFg1SGppNzh5VDZFY1JJOXRsOHhTT1RWOTRkZ0Fn?= =?utf-8?B?ZThTN09wS0YrdEJQa3pWNTdENU1VY2tJN281L1h0czJkekVQajlsR3ZLYXhr?= =?utf-8?B?SE0zSW1LdnBWMmJMa2tsQXpTN0dVVC9QUkJ5S0ZocmthUFNrOXB5WW5SZlBQ?= =?utf-8?B?aGlPOVIzSnN2SkhZaTE1Nm1kRmVhZFN6MUlGTGtOVm5YSWE5UWlEc1oyZko4?= =?utf-8?B?NnRma3F2a1BRM2N6TFlzNUx2dFRoMG9IZ05Ic3BSUU1kWVlzbXJJL0sxdTFo?= =?utf-8?B?UlNXYXFhcmpzellLcGxnbXJsbGlPR3pxNERLcGg3d3VnWWJXam11K3hoQnM3?= =?utf-8?B?R2Rxa1J5M3duYm5oYXBuQ3dBOVJydWRpa040TEJVc2M0d2E3UXl4ME0ybkdo?= =?utf-8?B?QVhSTnphZ3dDZ0d5a1kwcmF6S0RqeTl1YnlBTVp0TVlHRjhIY3B5bWRrcFdZ?= =?utf-8?B?cDg4dUxkOE80MGxnT242Q3dKTFVCZ3RTcWU5RGNkOHRCU0xucGcvZnFjZUJK?= =?utf-8?B?RUtHOWVjV0l2ZFluWGJweUVjYnlGcWM4SE9DU2FQYUFOeWI4TXk1TGIyYUlY?= =?utf-8?B?NkV4WEc4c1pSOG4zcHI0QTlOYnM2b2NxeWRLWUJHbFZUYWxVLzBXRGZYdE54?= =?utf-8?B?SnhvcllaSkNxdW5BQUFXMVNyYUNGamZDM1Q5cUhtSXRwZVB0YjV0dUdIekpT?= =?utf-8?B?a2twQzFCSkpWNjd5UlVTS3R5SXpBZ0dVSTBMZzhWcE1jRVJZSWJyK1pyQUZs?= =?utf-8?B?d3hITnYzK202Skh2TVVIRXB1Q3BvbEt4clIxYnU5QmJMd1g5enhGRThxTVlv?= =?utf-8?B?NWMxc3JlbUI0N0Q5eHVpc0ZCcTFINmcvVDNmaUlnKzloY2R2dTF5aXBsVzl1?= =?utf-8?Q?vQ9KjBXEIKAoFT396tRK/1QLJ+kHwHPzEyibdHx?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 70eaedd1-bfd6-462e-d501-08d9714e4ad8 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2021 15:52:12.8776 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: QVZidnb6RsPIUEX5vXOxm8KwJoii/LRbYbXp1XbivD5BmsJ8hGwPmGT5YBL8hFn4fNKpiipOjwcXE4Qjox+urg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5325 On 03.09.2021 21:06, Daniel P. Smith wrote: > --- /dev/null > +++ b/xen/include/xen/alternative-call.h > @@ -0,0 +1,63 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +#ifndef XEN_ALTERNATIVE_CALL > +#define XEN_ALTERNATIVE_CALL > + > +/* > + * Some subsystems in Xen may have multiple implementions, which can be > + * resolved to a single implementation at boot time. By default, this will > + * result in the use of function pointers. > + * > + * Some architectures may have mechanisms for dynamically modifying .text. > + * Using this mechnaism, function pointers can be converted to direct calls > + * which are typically more efficient at runtime. > + * > + * For architectures to support: > + * > + * - Implement alternative_{,v}call() in asm/alternative.h. Code generation > + * requirements are to emit a function pointer call at build time, and stash > + * enough metadata to simplify the call at boot once the implementation has > + * been resolved. > + * - Select ALTERNATIVE_CALL in Kconfig. > + * > + * To use: > + * > + * Consider the following simplified example. > + * > + * 1) struct foo_ops __alt_call_maybe_initdata ops; > + * > + * 2) const struct foo_ops __initconst foo_a_ops = { ... }; > + * const struct foo_ops __initconst foo_b_ops = { ... }; > + * > + * void foo_init(void) > + * { > + * ... > + * if ( use_impl_a ) > + * ops = *foo_a_ops; > + * else if ( use_impl_b ) > + * ops = *foo_b_ops; > + * ... > + * } > + * > + * 3) alternative_call(ops.bar, ...); > + * > + * There needs to a single ops object (1) which will eventually contain the > + * function pointers. This should be populated in foo's init() function (2) > + * by one of the available implementations. To call functions, use > + * alternative_{,v}call() referencing the main ops object (3). > + */ > + > +#ifdef CONFIG_ALTERNATIVE_CALL > + > +#include > + > +#define __alt_call_maybe_initdata __initdata My v3 comment here was: "I think it wants (needs) clarifying that this may only be used if the ops object is used exclusively in alternative_{,v}call() instances (besides the original assignments to it, of course)." I realize this was slightly too strict, as other uses from .init.* are of course also okay, but I continue to think that - in particular with the example using it - there should be a warning about this possible pitfall. Or am I merely unable to spot the wording change somewhere in the comment? Jan From xen-devel-bounces@lists.xenproject.org Mon Sep 06 15:55:05 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Sep 2021 15:55:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180071.326583 (Exim 4.92) (envelope-from ) id 1mNGxY-00020s-VW; Mon, 06 Sep 2021 15:55:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180071.326583; Mon, 06 Sep 2021 15:55:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNGxY-00020l-SM; Mon, 06 Sep 2021 15:55:00 +0000 Received: by outflank-mailman (input) for mailman id 180071; Mon, 06 Sep 2021 15:54:59 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNGxX-00020d-Dk for xen-devel@lists.xenproject.org; Mon, 06 Sep 2021 15:54:59 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id c8ec2a44-0f2a-11ec-b0ab-12813bfff9fa; Mon, 06 Sep 2021 15:54:58 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c8ec2a44-0f2a-11ec-b0ab-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1630943696; h=from:subject:to:cc:references:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=iFu3zhxevD19T38OTBC4f/Ly8O9/qxuVANg6BKssmGw=; b=MMklRHFLM2DrltER2yO0x7m4s2923mrh/87ERbW6P8nRLKe4FwmsSTR0 yO4t3nkU0PGM6Ji37bHOUMSXRm9OdR6nTgDNnXYFa7bwTRZVR/pikr2QV Bnopb4SJJwmzGk8zmvlLYoI6DXSnWP4sciThw423nGKPvBby4mY/+namF 0=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: 3cgpXJT0NZj5KsX2WolJ0HvD6SNovf9HEoo8OhyUGiOwJXc+C6exDVtoXnZ1RKejOczXPEK59A PAbiECxEFUOAM67eAYix485vlzLBpYiyaZ0KFPdDZhA9SRRytuOs5mNJMW0OBq5F8/uhoYinUL GcEszmLYpGo9S1rmabOj+DFCRz04i/rDi+dp3ljtWyjZOrhmCyVM2WBP9sKfV27tO3muhwWGlr AuWMFncw3Q+UCFWa13pl0AyuXIWX4utryogBaZPVdmOXd0coKZfDn8hme3UF7a9oZPyx4TUElF RALj7WFsUe+DjO7CxoCskDl7 X-SBRS: 5.1 X-MesageID: 52086313 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:lGbq5arUxEKnUT+NoQ7iNocaV5uiL9V00zEX/kB9WHVpm5Oj+f xGzc516farslossREb+expOMG7MBXhHO1OkPcs1NCZLXbbUQqTXf1fBO7ZogEIdBeOjdK1uZ 0QFpSWTeeAcGSS7vyKkzVQcexQuOVvmZrA7Yy1ogYPPGMaGZ2IrT0JczpzencGNDWubqBJcK Z0iPA3wAZINU5nFPhSURI+Lpn+TpDw5d3bSC9DIyRixBiFjDuu5rK/Ox+E3i0GWzcK5bs562 DKnyHw+63m6piAu17h/l6Wy64TtMrqy9NFCsDJos8JKg/0ggLtQIh6QbWNsB08venqwlc3l9 vnpQsmIq1Imj3sV1DwhSGo9xjr0T4o5XOn4ViEgUH7qci8fz4+A9opv/MSTjLpr24b+P1s2q NC2GyU87BNCwnboSj779/UEzl3i0uduxMZ4Kwupk0adbFbRK5arIQZ8k8QOowHBjjG5IcuF/ QrJN3A5cxRbUiRYxnizypSKeSXLzAO9yq9Mw8/UpT/6UkRoJk59TpZ+CUnpAZEyHpnIKM0vt gtMcxT5fpzp4EtHPpA7Epoe7rANoX3e2O5DIulGyWuKEg2AQO5l3fJ2sRD2AiLQu1E8HJgou WMbLtn3VRCMn4GT/f+h6F2zg== X-IronPort-AV: E=Sophos;i="5.85,272,1624334400"; d="scan'208";a="52086313" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Xpord6Lul3uguoS/aSYBYiKyYp8hupYGMY0kTcgsKLDVRe1CNsVhJLOKVw2yPHykxhGcQ6KdXPMVO/koux+BZsFR5/sckE2l7NzSsRpLm2pR1S6cxfX8Jh9laL1HE8fAxJllMJePAapmlocuIa4Og2Yuoes0w07VPToLj5syxBS9uhMqRRtcCVkO70EDQp/K2aSEcuJuO++1yqPC6qGhalBEdgwIBgBfvLzvWBDeyEDlAUukXLO6C94gLUu3ia4hDY5jhzwHn5ncroyTM3A/3jp7Hm2mCckCOemnnWxrTP8ZvRpDcWLCu4kopuhfbRsJVEx2FsLZaoICfOUruW51gA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=iFu3zhxevD19T38OTBC4f/Ly8O9/qxuVANg6BKssmGw=; b=ZUPZ3aRZzzYGKTl3U65UZIA2jKcEB3cxy+Nveyw5s5JyKZa/4noOyzW2FgmoqqwaqzwzNCA4yC7gNQmygh6ly82i33j8QXt9+S3lrI233dtilcZsy9NAqg/kW74YcWVTT0ZNdoSOUSlMWQ+OMuyNLsjbCjYWDIU6YDqG+blF0v6QEysy/yBN+cTa/xLL4MJtd8vFPQS+MLdQPS/y/9ET0PD7RuJQd+B5HbAT1bzFG7/WVDSBgfKC1VFiRQVu+jtAfvavPOKKsTLi6L61+wpMukgQtlLfRYwH2WF650Q5dziu/MuBSnt4pFF/aOF80y06c+EjQTsToNMKVm/sUyBDJQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iFu3zhxevD19T38OTBC4f/Ly8O9/qxuVANg6BKssmGw=; b=qjBPTzVsszUErkfx3PC604fELBLqTiWLRGEJxwa5vhz2zVDe8YjuUqMEo5T03dasgSu1OHVSk8u0zM4HKHxYxzmcyV+xuX4G/5zGWQZo+JKaptNER/Y5yk9lV14P/frTNt7Sz6SCw9LECqFvZxsnjR3aXNbEI7OMp+iVKdlmfRM= From: Andrew Cooper Subject: Re: [PATCH v2 1/6] x86/P2M: relax guarding of MMIO entries To: Jan Beulich , "xen-devel@lists.xenproject.org" CC: Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , George Dunlap References: <5972ce4c-bdb0-6d07-afad-cf4dd5615488@suse.com> <9ab471d8-877c-b569-96c3-c3145800adcf@suse.com> Message-ID: <4f794b1a-b1c9-2612-c3be-4dd710bef73a@citrix.com> Date: Mon, 6 Sep 2021 16:54:44 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 In-Reply-To: <9ab471d8-877c-b569-96c3-c3145800adcf@suse.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-GB X-ClientProxiedBy: LO4P123CA0254.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:194::7) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c140d6c3-d73b-4087-cf4f-08d9714ea906 X-MS-TrafficTypeDiagnostic: BYAPR03MB4805: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: aaATC9MZA1LgM/AAKxeZSEG+Tr2JC32fsa+oWOAYlewJKhnU9yA15ucyZuw3/ljBYMAd1JiNgm08rxqACIPEFRJkBdfKM12cWBEqgxbwQ6i1MeGcDEqaGzQQOy4zA9ZwxtHr2050HzZv8gxbM8Ulg19c0CJge87DwRa0TYHteyq87AB9PRt9DBLQv1foKkA68dAJXPZGjpzYWQ5mfHGOYg3G2KQWvYuwf7KlCJMiE9q+obAl3v2kWP3Q6HO1PibjcUA3JE8bCfYvAxLUb+Crml70YqyIlUiNbzD1A354PliX07fAwierV/umq12Rm/aw0+PQPYf1MxqBEQzpmlBhf8xjgiXOHnML7EZPGwdG+ykhjPXtjyn7Qavm1tHflSGSU74Bj5I8sw/Tg6uYVZpagcdxqOAydbvgJeM4HJXulUPYJ22gwVrwCHcu1Bwjg9jju1zVkq9o7c76sSBQurs/GECJswmkCbtFWp7FNWHrIUqc2Xnr6TvKB3PunqrFllztJ2yij9zrVTSM2dSYbKx7pUu/E+6GvfWB6/PwpSGGgYoLLr4Tib0kBPghY1cyzUuBlUtC5wubtntxKXDgBBzqBdP1QQ+NAdk7JFnSNG96EBe2aVe3GkgNS13LMScCBHY0m8qCL5UTGo7/+bzJx59hM0q4m4OMZ9bbmSZdAWL6arl69IcIBrnmrV4ezIL6UsNOc/DLYZddgcBOacqGtXtdCspYuU0N+ERIgiu4+r7ok8sVEk2Ws0uM0EydDKtuaJej X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(39860400002)(346002)(136003)(396003)(366004)(376002)(16576012)(31686004)(38100700002)(4326008)(316002)(36756003)(54906003)(110136005)(86362001)(66476007)(66556008)(66946007)(5660300002)(6666004)(31696002)(83380400001)(8936002)(8676002)(53546011)(186003)(2906002)(26005)(6486002)(55236004)(956004)(2616005)(478600001)(107886003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WnIwcjBCczdsSXExNVc4WmlCN0lCallFN3RPUjlzQUIwVGRSc1BNcGVUcTJr?= =?utf-8?B?OGJpcWZKd0Y1TXhVWWxBdGlPaGJ4aThVZmhMWjlDMHQvU3lZWlM3ZWgzcG9C?= =?utf-8?B?Lzh1US9EVW5PR1NIaGthd2FaUW9pTXRyTllkbkFGNnF1NEpZblYwTlBKV2pW?= =?utf-8?B?UU9KWjJ5ZkY0WGU2Q1NnbHdINlBUWHhHai9PMjFaMlh5WFNicmVHOTJjUTJS?= =?utf-8?B?czF5TWZMdGZxSU1UMWVMY0VVeUtmSHBHanlPb2xRNXl6ajZlMmVnOTJpVVU2?= =?utf-8?B?akwxcWhZWVp0MFdqU01iRGRIM1I4ektJVTRPYW9KVSt1bWNwcHgzU2cvSW1G?= =?utf-8?B?eENCYkJzdWlHMks5T0xnQnEvMFkzM2VJQmp1a21XUlE3RnVNcU9wckxJQ0Vh?= =?utf-8?B?c205WUpGMS9kam9rN2pZR3V0OFB1MjVuWk50dnV4aFJrNUNVbE9QWHJBTDdB?= =?utf-8?B?eklHRnZBWWxmbVFObll4MWVJUXZUa01PbExXNEFieGlEWmR4N0RSKzN4azdY?= =?utf-8?B?WDVBSFg1TkFxcXZaNDJocThSMEUwRXpIMGxYVjRZQU9tTzJINUtnVEdRc08x?= =?utf-8?B?V1Jka0YvbnY1TXhNblZQRkFZYmovNnVNdDlscEdGQW1wQUIxb3VuRFJobjRp?= =?utf-8?B?QXhOd0JWT1JFYzVTZGpzNithS3ZING9TVVpkcGxKem8wYjArSm5rT09zUXNy?= =?utf-8?B?QUdqSnZVbko2Mjhhblk2UlFJR1NTU2ZiQ2NGN3RyUitUTG9EVjFQMW9JclVE?= =?utf-8?B?US9VV05aVWQyUVJLTXdaMzRoclhsRGR0TkM1NWh1cCtBdWRDejY5TFR1cVJn?= =?utf-8?B?VWlpS0NadWl0ajBBczZkUzRNVG5IZ29mU0dKbmMrc24yLy9HdVpUKzB5SDk1?= =?utf-8?B?ZjFFUTJuY2RJTXBKdjVUMnVmV05xRS8xa2toeE5mRW9aUk5ZMWRPMnpsbmZp?= =?utf-8?B?QTlSS05wTVNIeGF0Mlk2R1VBZC9IL0dmNzl1THJVNWN4N3N2WWdzUXN2VnMz?= =?utf-8?B?Q1lCcWNrLzNJeTNacEtWUE5VSDk4QnZzRENrczl4cEJPeGRCOWt6NUJZTFkr?= =?utf-8?B?SGZ6VEVzaVVISWxPWjFjb0U5dzcvUjFDWXNoL08rZlBlc1gzYTFzT0tLeFda?= =?utf-8?B?QVNxREFadHEyVEJ4Vlo0bE1VZkRvREs0WGtIODNIcTZ4M3ozSm0vbjBON1ho?= =?utf-8?B?NzZSMjNYT0RxTGM3YXNtWDVzVjBiS3FpTWo2MjZFM3Q4RGRMckVkLzczaVVG?= =?utf-8?B?Z00xbk5lcCtodDExS0RaM2ZRalh6YnlKOFYzbGlVV1Nub04xd1lXQmhKTEIr?= =?utf-8?B?YW1IQ2d0ZmNMRVJHQWJyMnFuTi9WL240Y0U4M1hNb2c4N2NMeExIcUs1Y0dm?= =?utf-8?B?ZU9XUHRIZEFUd01EdTg1N09JQmJ2VkYvcG1Qb1Q4Vi9MTDBXM1ByWGxSTTBl?= =?utf-8?B?aDVDM0FTNjhoc2hQdm5mV2FETElmeFdvRkRGb0RQbG4rOXFza25pSFNEZk43?= =?utf-8?B?SVF4VWhDdklBYkNDdnUybHZDSFowTy9FaW05MXBOakE5eUJER1AzbXlPSk5L?= =?utf-8?B?bEpnTFNFK25oSzgzWFlOVDVMY0ZGSVFzU3VnSE9pSzhHVUR4SGttRVVtZmtu?= =?utf-8?B?ZzNKQ2tNTE1qS20vSjhFQWtJejlKamM5WmNrazBSbnV3ci9FNjZndXBJaE5q?= =?utf-8?B?dlpDaGQ1dVdkbEo5cXdKOXJBU2lCTDI5UEdXbGpoNmtPblNTRi9HYWFPZU9K?= =?utf-8?Q?XkWY4NScNXe35bWQvg16/TtQGBWsABp57j/V5yE?= X-MS-Exchange-CrossTenant-Network-Message-Id: c140d6c3-d73b-4087-cf4f-08d9714ea906 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2021 15:54:50.8268 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 7E5OilklUTMU6p1bHGzlaiG9gClfm14WsSVQLxWI6Iz0fdqwzFA6/NePEb7GZtZOfWTTL5vdJvL5qjbmFS8FkJj+GiEoiKJMbLZKw1AKb2Q= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB4805 X-OriginatorOrg: citrix.com On 02/09/2021 09:32, Jan Beulich wrote: > One of the changes comprising the fixes for XSA-378 disallows replacing > MMIO mappings by code paths not intended for this purpose. At least in > the case of PVH Dom0 hitting an RMRR covered by an E820 ACPI region, > this is too strict. Generally short-circuit requests establishing the > same kind of mapping that's already in place, while otherwise adjusting > permissions without - as before - allowing MFN or type to change. "Generally short-circuit requests establishing the same kind of mapping (mfn, type) but allow the permissions to differ". > While there, also add a log message to the other domain_crash() > invocation that did prevent PVH Dom0 from coming up after the XSA-378 > changes. > > Fixes: 753cb68e6530 ("x86/p2m: guard (in particular) identity mapping entries") > Signed-off-by: Jan Beulich > --- > I may have gone too far by allowing "access" to change for all special > types now. I think this is appropriate.  After all, it is the pre-existing behaviour, and the type change is the important thing to restrict. Acked-by: Andrew Cooper From xen-devel-bounces@lists.xenproject.org Mon Sep 06 15:56:07 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Sep 2021 15:56:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180076.326594 (Exim 4.92) (envelope-from ) id 1mNGyd-0002bV-9s; Mon, 06 Sep 2021 15:56:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180076.326594; Mon, 06 Sep 2021 15:56:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNGyd-0002bO-6a; Mon, 06 Sep 2021 15:56:07 +0000 Received: by outflank-mailman (input) for mailman id 180076; Mon, 06 Sep 2021 15:56:05 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNGyb-0002b8-Ro for xen-devel@lists.xenproject.org; Mon, 06 Sep 2021 15:56:05 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id f0b55398-0f2a-11ec-b0ab-12813bfff9fa; Mon, 06 Sep 2021 15:56:05 +0000 (UTC) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01lp2056.outbound.protection.outlook.com [104.47.0.56]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-1-va3uDO4RM2y9I5DnaNZr0A-1; Mon, 06 Sep 2021 17:56:03 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR04MB4190.eurprd04.prod.outlook.com (2603:10a6:803:4b::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.23; Mon, 6 Sep 2021 15:56:01 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4478.025; Mon, 6 Sep 2021 15:56:01 +0000 Received: from [10.156.60.236] (37.24.206.209) by AM0PR05CA0094.eurprd05.prod.outlook.com (2603:10a6:208:136::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.17 via Frontend Transport; Mon, 6 Sep 2021 15:56:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f0b55398-0f2a-11ec-b0ab-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1630943764; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=g3VIIzhR4VPWUylr8MJh6UdRLw6fQBScFUBQK+lSfh4=; b=Y+c/YjHDXnFGZS6F7wHUpPP3RjH7n9hDJZQezId5NEoOxTHvDmZp+5hlkgGnEppu1J5NJd fqSMreL6glZmbstkyWwC9CVb+mUf9w76up56vaShGpMmX1OCMu3+giz098E3OnFJAQ9oug lkusKzhV63UPq6aGGJ92zBCH8V7bALo= X-MC-Unique: va3uDO4RM2y9I5DnaNZr0A-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Sa4U2cSGjzNInatLJPKW4bsGiTjipHz3GBD4+9hjcxgNXYMpX1Ujz77ItvoB69KvGjZEj6rTZ8vqqB7uGtqzWc2RfIrQdMBfNBn7ItH2q0Ya4FE3EVxgMcg727J/7tUQJYp+1U2O9txHEJPEZv3/YIqpV3RBdUHot1GGeIzZ20cbxk5sADfDMjkxKk277aonkZtWtYH7SDas2qWrPYq8Fz7/6VOpGyqq/hl1zfCBgebk+u7aXfLRgDpAD+seGftOs0yu9aG2nCq4+M2nZv3+WuzeMSBiZWVrEbAswp2HwfXVhL0AnnMTPgv2I6qH8hA+hRnRO3xSInDKhH0dhsuJHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0eMpjxEXhNm6omFEl8aBZ2ChtVfNPks2EaXMUmuJAqg=; b=oW2mU8h4+nJF+7gaYSuD086lsqKeg0UyEeQEhKIrVOLWyy3/xqbH8KL91jiQAsCM3picT6K9N0harL+UWaSPC5REiP8k90Qu9LJjNdLs+J09qqUVv6+qdkkPuD0gtJZXTMTBcAAjjHFDsaJX2T67XCL7CnCCbfYrwnRW3u4Owx374Iuvxb84ssXCorTTJ5J9d4H6SqofSXt6WLsEUPepd71TpdgDaS6vuCUSkWXT/XWjYpJGh/n8i3TFDFBfoTTqTPNgBmrtEuwGL42izeARRAIc1zA1wdjwiCiD36O+zwYAM1zUcRAvmHnzngjlSzlS5mASN9Ik9UHktr4hxu8KtA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com; Subject: Re: [PATCH v2 2/6] x86/P2M: relax permissions of PVH Dom0's MMIO entries To: Andrew Cooper CC: Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , George Dunlap , "xen-devel@lists.xenproject.org" References: <5972ce4c-bdb0-6d07-afad-cf4dd5615488@suse.com> <457637e2-d35c-18d0-ead8-0b513b257927@suse.com> <9b7936fc-f81a-d5e7-5ceb-6e10588503dc@citrix.com> From: Jan Beulich Message-ID: <28646a17-420e-bfaf-8f7d-6d109818ffc3@suse.com> Date: Mon, 6 Sep 2021 17:55:59 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: <9b7936fc-f81a-d5e7-5ceb-6e10588503dc@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AM0PR05CA0094.eurprd05.prod.outlook.com (2603:10a6:208:136::34) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7ff10b55-8923-4283-84b1-08d9714ed333 X-MS-TrafficTypeDiagnostic: VI1PR04MB4190: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XCUvxD2aG0bcXQbCaYJIUTp+ZbB9g/stXeR60kRa1vr6hihvPRLyiZq7p612wxmA/KlPBuIqBk3F6m+9g4LJhS6V8+l8mzkzI0WhHTBPis32j/MqzUtySbYUKW4wnffCbcbocABdNmIyKd4kV3hytAt9SrV+TtAZ5qgkYA960GqAANmrWkljwUN7AWahnbfHGje2Ddmj63hTfNKJGbRAecETR8kOJe/O/q2LqrEY8T/T1gm7/hRtW9R2Z1KTfv/NBbu0Lnym3R7hh8e6GUF+OEY47I6rlRlaxCm3MwRFkAfB0m4cmgg8p/37rZaXKg4LWyWI/dQxv5KWbgPaEZ4KbQMv6TYHskJbMHGwdD6nywsXzvwyn+Xxz7Sro1clouyj5wI3lCGDlyySP2UidHfocp8vg3MIHnFwio6p/GqVX5cUOHON/br0zKN2pYPiMnrDfPj/p2zY00vhKTo0NH6iYBhMMSy75Ogi0pAhkmvUZ+Ci9IGRpVJICFVlH6Tbj0hzN6A/QYaO5Km8Y9f+96Xjpz8vQLE4GtxFYRdhC0eFkikLxckosR981Oez2iyOw+Tka2oVnpb6SL9dsZIYuVYJ2NSWVxMN7HosZS+tyod3nqqLBK3QX8A4hNZxiubotrUeD6AYpC1aF/vfVSNS0jYfhuG5d8pj18rdG5LLEFciLBgwbZPgfl9sySc/c/F+ve75S5gOvf2lhpo2n9q3Shj4Ez+UYxYCwgw1iToV0ExYLPo= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(136003)(396003)(376002)(346002)(366004)(39860400002)(36756003)(6486002)(53546011)(66476007)(66946007)(31696002)(6916009)(186003)(4744005)(16576012)(316002)(8676002)(54906003)(86362001)(31686004)(5660300002)(2906002)(4326008)(8936002)(478600001)(83380400001)(26005)(956004)(2616005)(38100700002)(66556008)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?heEbXrQDAcKTe2mtwvp09Q5xqcIgKsXCaSr1gHO/f19hUXxJPOtdTG3yjL4G?= =?us-ascii?Q?Rl8TFZn85zWCdk8FXs4Tqpe+lfEHa8um978Zkd+e585aMDkuiXI1Dh/yeyWG?= =?us-ascii?Q?c+CcGWJD8HtUoWmEelD2gRDltz++lYYomjzTU7ck955hWl9WQgOTHoouFfLe?= =?us-ascii?Q?N+pBHx21wEcrQ9hjjD+vGwATzBxfAV0RCa8idSwusGo958Ql/9rSQIUnNQTt?= =?us-ascii?Q?43YzxQ4sTbAp4ZjkH5MEnap4xVMVpcUPwSw92Z1LNwndSsau+DUPm0WDlLaE?= =?us-ascii?Q?AT+pUHW/+kMWb6UAaoJRsGmN6U/yOvykzRiPYiQiLIavNyGnqrN/ysHmVeOz?= =?us-ascii?Q?je/7h8IWOQ7fO4AYuVnB48295rYysJHNMp53mvj0CS/n7fzDDtzrbjiqCei6?= =?us-ascii?Q?xlHd29A/VROax0zwq0O4h9GTNPoPJ9OlW5XRok2b4qimP/2rmFIcBMm547WF?= =?us-ascii?Q?pNAt2PQkywgCB+A49j89uGOsjl6bQEPmYF/e+K7EW/T1To0eTnAhlD915oRp?= =?us-ascii?Q?BDwkgWyIPM9EfxLNm5GNw/d5xu1h4O2MyCQr5BuTdp3Wets/5RazOC66OtuR?= =?us-ascii?Q?CXbGH4NpfWSdiVC64nw0MocS/sSZcANQ0nrLmJjJ+nZRPfdJb7QkqQkyJr86?= =?us-ascii?Q?uXZB7mQb02J4aj3bOBnOIUH13v8jweFIYUfWMIdQxFTRm5SFLqYGY9CQBHOB?= =?us-ascii?Q?C++jQVi/EdW0+EvhboP1mVwuVTplp0W7Atyz1/s3541WTWjbKnUbj7D0jDns?= =?us-ascii?Q?LWuoKNzbjZQ3MojuOLTnbmq9YETWYSX9qDx7pUMI2Fi22X8WEhpzKZ5nIr34?= =?us-ascii?Q?QEZUZ33tIKJ1DUHDfwZ/60CwNbkV1BKSkhX9t5loTZIy2lq34Nm/ei1YcI1F?= =?us-ascii?Q?Jv5U/IQq/Opvso4NumnlGXeQyurLWRXnYHZmCQqe4TdMaNqWNoJunFcxGTgs?= =?us-ascii?Q?cr/HZQXemGW5heWty/GFrjjOHPGlo3vIp+Ka5Jo1LeC/U6QmAQVsYFXNLUV/?= =?us-ascii?Q?672GvoKZsWJc3y7PS8k2tvwwZlHP/pJopI2cStxRktutI1+gL37unQ350Uyu?= =?us-ascii?Q?Riq/bVb7lKRib8j8+86JfQhWtJxxWz80egFsQvGuMjc41Nrb0bHYWpdvz+d2?= =?us-ascii?Q?lgN0LjoJ2Z+Za+0QMKOMk1Nkuvp63+JTVwE0NDb70jq6W+cc/1ZacmqiBUtv?= =?us-ascii?Q?/7nlGBJPf3Vzb0+ks1O8zdXEcpO1V776ATJrbbbNn0X1CYQY5betv7fWbBG2?= =?us-ascii?Q?3shhpdefCRkb7fuI0CsX+3y07e2CnJ86AWRALnxtmWbhhnRoa9YXWfCBgtw+?= =?us-ascii?Q?1kxNZMrfUbtU/luvoYj6/eAD?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7ff10b55-8923-4283-84b1-08d9714ed333 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2021 15:56:01.5571 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: eS0wVgOD70J+2WIq9vpMJ7GEhlL/Ed0NPhAWtm7ixfCso9bOM/2klZ+IpYMgXJDCYM8l2KdHA66ZYvMgHrlOBA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4190 On 06.09.2021 17:48, Andrew Cooper wrote: > On 02/09/2021 09:33, Jan Beulich wrote: >> To become independent of the sequence of mapping operations, permit >> "access" to accumulate for Dom0, noting that there's not going to be an >> introspection agent for it which this might interfere with. While e.g. >> ideally only ROM regions would get mapped with X set, getting there is >> quite a bit of work. >=20 > ? >=20 > That's literally the opposite of what needs to happen to fix this bug.=C2= =A0 > Introspection is the only interface which should be restricting X > permissions. What agent would be handling access violations in Dom0? The description (now) focuses on entirely Dom0; I agree that DomU wants things the way you describe (provided all p2m_access_t abuses are gone). Jan From xen-devel-bounces@lists.xenproject.org Mon Sep 06 16:14:05 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Sep 2021 16:14:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180085.326604 (Exim 4.92) (envelope-from ) id 1mNHFr-0005xs-VI; Mon, 06 Sep 2021 16:13:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180085.326604; Mon, 06 Sep 2021 16:13:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNHFr-0005xl-SP; Mon, 06 Sep 2021 16:13:55 +0000 Received: by outflank-mailman (input) for mailman id 180085; Mon, 06 Sep 2021 16:13:54 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNHFq-0005xf-Rz for xen-devel@lists.xenproject.org; Mon, 06 Sep 2021 16:13:54 +0000 Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 6dc0a926-0f2d-11ec-b0ab-12813bfff9fa; Mon, 06 Sep 2021 16:13:53 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6dc0a926-0f2d-11ec-b0ab-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1630944833; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=sPS1iR3/1qB/kh7mRnkHpyZCa1OlC8FRIQTogK8xtOU=; b=IOSLeBP5dKMNpqHtA6oyRJZuNh5pCtw9WmIruSVHXuyvlCxcb/BevhcA JR+PVzXxI56LErIQrsnlqrSponcidzUDOMjryeEBdMn/Ua+2le4q9q4uI /LrXYPC2WV5UUuvtrHHMky2iNqqqTvS4oaRnTj8B9yg4T9PaO6HIm6diG M=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: PAneNPwE5aDq+Ll/CpoUPWdhhv9tg4/BUy8AeMc0O2PUU4INBbhv5Kz40Hb/zEJtzX+XAoc7gJ O9ERxtzFxcj6M1tVuvfoztfdcc/8gIo2gvWq/zckgyvjznb38WzOdn374IJDFgw+Aa2XS1OG/V 07XxUl0ltJ0qf6p7fTkzbaA0dH+ZZURnXnyGfBUKg+VSbi5A/gMfk6whFAdXAuDwhl/tngPSp8 Wpq1PdQGMnTgTGZVOf7/6fuMNmlztdlySu217xAvpDov71s9kfSy6u+ulo1g6rW/1+Cmm7O3dR S76Ima7LCUdkkcsCUtYgTuOf X-SBRS: 5.1 X-MesageID: 52111338 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:c23qnKDy7XGChmDlHelo55DYdb4zR+YMi2TDt3oddfU1SL38qy nKpp4mPHDP5wr5NEtPpTniAtjjfZq/z/5ICOAqVN/PYOCPggCVxepZnOjfKlPbehEX9oRmpN 1dm6oVMqyMMbCt5/yKnDVRELwbsaa6GLjDv5a785/0JzsaE52J6W1Ce2GmO3wzfiZqL7wjGq GR48JWzgDQAkj+PqyAdx84t/GonayzqK7b X-IronPort-AV: E=Sophos;i="5.85,272,1624334400"; d="scan'208";a="52111338" Date: Mon, 6 Sep 2021 17:13:48 +0100 From: Anthony PERARD To: Jan Beulich CC: Subject: Re: [XEN PATCH v7 00/51] xen: Build system improvements, now with out-of-tree build! Message-ID: References: <20210824105038.1257926-1-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20210824105038.1257926-1-anthony.perard@citrix.com> I hope this is useful: On Tue, Aug 24, 2021 at 11:49:47AM +0100, Anthony PERARD wrote: > Anthony PERARD (51): > build: introduce cpp_flags macro > build: use if_changed on built_in.o > build: use if_changed_rules with %.o:%.c targets all 3 ready to commit > build: factorise generation of the linker scripts may need a ack from arm maintainers, does it? Otherwise, ready. > x86/mm: avoid building multiple .o from a single .c file > build,include: rework compat-build-source.py > build,include: rework compat-build-header.py > build: fix clean targets when subdir-y is used > build: use subdir-y in test/Makefile all 5 ready to commit > build,arm: move LDFLAGS change to arch.mk need edit commit description, but otherwise ready not needed before [PATCH 21/51] build: set ALL_OBJS to main Makefile; move prelink.o to main Makefile > build: move make option changes check earlier > build: avoid building arm/arm/*/head.o twice both ready So up to here (12/51) all patch seems to be ready to commit. > build: convert binfile use to if_changed > xen: move include/asm-* to arch/*/include/asm both need a ack > build,riscv: tell the build system about riscv64/head.S patch ready but depends on "[PATCH 14/51] xen: move include/asm-* to arch/*/include/asm" for the rune written in the commit message to work. > build: generate "include/xen/compile.h" with if_changed > build: set XEN_BUILD_EFI earlier > build: fix $(TARGET).efi creation in arch/arm patches needs review > build: fix arch/x86/note.o rule ready, standalone The rest of the series needs review. Cheers, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Mon Sep 06 16:23:18 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Sep 2021 16:23:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180113.326615 (Exim 4.92) (envelope-from ) id 1mNHOo-0007fV-Ss; Mon, 06 Sep 2021 16:23:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180113.326615; Mon, 06 Sep 2021 16:23:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNHOo-0007fO-Ps; Mon, 06 Sep 2021 16:23:10 +0000 Received: by outflank-mailman (input) for mailman id 180113; Mon, 06 Sep 2021 16:23:09 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNHOn-0007fI-7T for xen-devel@lists.xenproject.org; Mon, 06 Sep 2021 16:23:09 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id d0a42d75-f702-48f0-996f-eb4c9c6b15d5; Mon, 06 Sep 2021 16:23:08 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d0a42d75-f702-48f0-996f-eb4c9c6b15d5 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1630945388; h=to:cc:references:from:subject:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=u1wCfwPEvija+X5nLmaV5L/jHHDMUlypZ4kYBWYJFLc=; b=UVeHqI3PbgBIWWRqVlPlJ31Wg2bNj4pUzJq9e51VR/Hxfp9Od9/ivGVF 4M1vEyqsyEM4LtZJwCxRBplEki+J32prWw1y/d4ncHZEKCnM8WKnsHZdy keEY4DDPFFpe+4hWImhU9xfQlIfE3+xshbx1B9cXjaOBJbzzcsmaPurV0 U=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: aITdVDxBJwvPSCi6ug98L7fiFhUqZAEmE49LuZRb8tAR+VQHXlYJYu6vDfuMmiDcdZxk7S2VWY 1l6zwaYvqJlHhUOb/8BX9AaRxvZHvSdlZWAyXaNGnTLP/59iSbaB6oQR04NbQJUkMX+g58peyN jIPD8T9zJLxCAjtgSqEPLKuK4lDj+wjb7e2DWVl0MrjATjWYMlXxT102P/DqGcPyNuk60xSGXJ TVGNBm73WHkwzeNY1KkrNreOGkmLc3BZ13QK2AaOhxoGQw/Tho1qzul7gpxLVllFtSZwL47sCm 2ZuJWT1uuiWLInjdkfKuYXjY X-SBRS: 5.1 X-MesageID: 52087671 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:zXrAXKx/Q+h0wKGZ1WfOKrPxu+skLtp133Aq2lEZdPULSKOlfp GV8MjziyWYtN9wYhAdcdDpAtjkfZquz+8L3WB3B8bfYOCGghrUEGgG1+XfKlLbalXDH4JmpM Bdmu1FeafN5DtB/LbHCWuDYq8dKbC8mcjC74eurAYfcegpUdAF0+4QMHfrLqQcfnghOXNWLu v/2iMKnUvaRZxBBf7LeEXtEtKz6+HjpdbDW1orFhQn4A6BgXeB76P7KQGR2lM7XylUybkv3G DZm0ihj5/T/c2T+1v57Sv+/p5WkNzuxp9qA9GNsNEcLnHJhhyzbIpsdrWetHQeof2p6nwtjN 7Qyi1QcPhb2jf0RCWYsBHt0w7v3HIH7GLj80aRhT/ZrcnwVFsBeoF8rLMcViGcx1srvdl63q 4O9XmerYBrARTJmzm4z8TUVjlx/3DE4kYKoKo2tThyQIEeYLheocg050VOCqoNGyr89cQODP RuNsfB//xbGGnqL0wxhlMfheBEY05DWitvGiM5y4uoOnlt7TFEJnIjtY4idixqzuN6d3FGj9 60epiA2os+F/P/wMpGdZA8qPCMexnwqCT3QSuvyGTcZdM60k322urKCZUOlauXkc8zvdYPcK qoaiIviYd1QTO3NfGz X-IronPort-AV: E=Sophos;i="5.85,272,1624334400"; d="scan'208";a="52087671" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KOO1SQlkNfM4CFHZATNIChtWTYk0nmSUW/JPaop/kFLLa3t8LA03ZmrL06/alYXUrmgoiOZlPgValUNeyagmNkDnLrzAd4pcxEerdJ7NGyj2oK6FrLBVUkiG9/4pIJJu3z+YZIar57IvP0009aBjOf7e+OqHOctWTW8hbSVhNnhzjTfHp1szmO3Yw7KkU1zkQOjWvCKghGcgElGfL3/EvhAYTaFwpML0KgDvtZUjUaUecQnGFvr5CD8sIsXNVqU4rYK2NblAKKr5nkcS94G3PC8dRvacbGSxJJ672c1GWBcxxDOJq8/FznaG+hgJ8X7UnMzfqcvEKVYVOQXIjQKtZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=NAWywoEhPXo8wkSkHOONStkbpBdXvcsyCBc2lneyBb8=; b=JY9L4atVHGv4TcCF0173og2a5Jt4HI92+8mWy+xYjUxC6tp5MH/2COBVn63AVApXqr49LmtG+UBjJMN7npXtIl08eoCLjnQ6CziWiubRy2kG7cIIMtvwsNCFGHm/7noK4v1VDK7Dz45qICgD4yoz07TmrqRJICc1hHz0e4lTTNvBKxqgi1KDvxnGFG8cf2VaprdTDRwlrfVJWtSAUczNBucP9JBbEeKdvxON0gh4XuZX63p/hgZ9fvBj3WAYcGabMMDx6jifPoRnGkC//uODfk4gMmdJCRgHy3GJwVQGG8Pb0RAS61tM1Y5lJS1P2txSZtiKgReLjEjmBCIQkFRpBA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NAWywoEhPXo8wkSkHOONStkbpBdXvcsyCBc2lneyBb8=; b=Lvk3Pn0XCfqaIefxTbHUGsKn+aUC3NsmIDeX5NOcNoubMPyZrkHYicQOAJ2CZ6rOoIgCOKNm2mXP/I1zcnLQOL0PqNsA1nQtyfo8dE6PnlwKdY+DZvLku7YMQXvW9do/LYFCh1UKokpbhnXKsjeniGxz0xX7LvZAbvs26wjhf/g= To: Jan Beulich , "Daniel P. Smith" CC: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Bob Eshleman , Alistair Francis , Connor Davis , George Dunlap , Ian Jackson , Wei Liu , References: <20210903190629.11917-1-dpsmith@apertussolutions.com> <20210903190629.11917-2-dpsmith@apertussolutions.com> <3a91e4ad-50c4-205f-3d90-f23c996b2938@suse.com> From: Andrew Cooper Subject: Re: [PATCH v4 01/11] xen: Implement xen/alternative-call.h for use in common code Message-ID: <8c3dfbf5-5c98-c923-ca81-28af3d13c4a4@citrix.com> Date: Mon, 6 Sep 2021 17:22:58 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 In-Reply-To: <3a91e4ad-50c4-205f-3d90-f23c996b2938@suse.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: en-GB X-ClientProxiedBy: LO4P123CA0073.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:190::6) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5ed4c017-7bdb-482c-0433-08d971529a9d X-MS-TrafficTypeDiagnostic: BY5PR03MB4999: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2803; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: S8M8Pzy2Km16DGbI2YEXgFY/yzi/jufCOAVbZw7CZi9T/6st6i5gCw0vTIRSsYEVsEr4RtoWiZqRPhGV63bRIi1QDDAHeuuunQ0d/hZ3NvHEm3hGmXHS0bN4OsVYmMJU4GQGboyljTX+lDF74Qe9ANpJTfttvABUbsT8GAy5k2dFhzfw4DWPxkypv1mRB2xqAlPrJVJCGYv9UADyiv+y/d+wITJES2DRePZPMF1KHmXD+cAUFTXPAiwutcmprWq2JSTSq2cO+Gqe3UjjXvtAJAaerITQ9tX106avc/Ij0XYmOZ3juBrZ+dECfSUS7X21tKTHSLyfPaBefaZuscrvKZDzayF60/Q+SjO0m9n/yRC0XXbaWUaOGO/YjtG7nhtKjQuVP8ymkDjhR3z5i3FqDB3bzIDf+gNU9pWfVZUns3VM4YwXUW9zPWpM17bwJG4JKQU8EeENNVfyFYq843EVg97z3UR5tSNE8BnhskIv8ttF8a4gU+pQXvm95HX88jQm+YW08SEO5K1V7ovvqm/htRw6S4NYjqXt43A4KpsfwCVItGnnqbV5xRZchQxAAisZNiBQOb1/2pFRoJfAvCItL4CymOo7emov9CQch4SBJDO/Qy1dF0PVhHBE0qhhfWDOCuqq+KgZIo0ov/v6uI353UR168YKGbYNgXUvSIPWfw40wXBIrq0BJaS9sWbqb8YKR8cbm73ZKd7MdFutNDk1vFbJfKOpnYLi1DG8oV8ga3rE2pM6+Png7Fe6OvWkiau2yQR+/AnqtKefyXkvzGpn/knDkQFjg2UqMjTxCmkchTtPHG4SaDJdqMm4SDAsySgk X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(39860400002)(136003)(396003)(366004)(346002)(376002)(38100700002)(6666004)(8936002)(4326008)(53546011)(2906002)(6486002)(66946007)(5660300002)(26005)(956004)(966005)(186003)(478600001)(110136005)(66476007)(16576012)(66556008)(2616005)(316002)(36756003)(83380400001)(54906003)(31696002)(31686004)(86362001)(7416002)(55236004)(8676002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TTJuOFNxbklqSzZMZ0Vjc2Q4cVlHNytDbGI2WTlmT0JJVURxVVBYUHBQRVdG?= =?utf-8?B?YTdsWkVtb21yVGdic0tqZ2IyV2M4eFFIL2I4QUs1KzQ1b0xOY1FVMVNsUFEy?= =?utf-8?B?K1hlUHJ2K1RBZmw3RTc3UFRIdWJUUG42SkkwdEN6Wk5raGRBTUFkSCt1OTh1?= =?utf-8?B?QUNub2pLR0VLNm5qcGtQRkpmK2I0aVM4SEZ0YnhDWHFBUUtuWTA3bDVmNGdQ?= =?utf-8?B?NXhXWERVVWZBNFNSQlU5bE1lN2NoMlpaNVBaZEh3c2lLODMyU0wwaS9NbHRL?= =?utf-8?B?bGVzTzVVNjJHTmc5OE5mK3VTVUJmejdrMDZYRE5COGxKWE1tbnNUZWhZQ1Ju?= =?utf-8?B?U2NmSFd0OEZxdG1PQ3Z3c2JyVUJFdi80UXpRSThQbTh4am1BQXZweXJhWE9x?= =?utf-8?B?Qk9saXRSZzFXN3F3NmdOUWlKR096SVVvTWhHS2poZFhMb1JRWldHSFpiREtp?= =?utf-8?B?R3JoV0NUQ1BNZDJ2czNqZDFLRmk3Snh0ZnRocXF1THlIL25iYmhMUXU5NHc2?= =?utf-8?B?TnNzUVhyRVpjOWpQdHNHRUNObFhtbVR6aHE1UEg0aGNCUFVXRVJOMG9wSGw2?= =?utf-8?B?T2RlRE4rM0k3bkRnVkFmRUZXQ3EzQTdMcTJtNEtpK0FCdmo4dzhjZVJmY1A2?= =?utf-8?B?eUs4QlF6L052YUk5dWRKRUZYNFNTbkZUdWZ1TlhEaDhBdjRsaFVTNHI5Yzl3?= =?utf-8?B?U1ZTVnJWZVkxa2Z6cDdqMi8rSjVnYm16TVFBQjA5Y2xzeFJpb1FjUzVUTEt5?= =?utf-8?B?Uk0zTGlnVVZWRHJyaVJFdkVQdmdZczYyY3NtVmlmaUdzeVBKWWs4akxoZk04?= =?utf-8?B?TmFkNDZWNzJlT0E4Z2Zwak9jQ1hZV0tVOUtSaXlxdlBLRHc2NURoV2JrekVI?= =?utf-8?B?b0RzRVVaV1pxZ1ZmMGE4bXgyQ2JDK1R0UzhHMHlVRFowMmdDaWExTERnc3dV?= =?utf-8?B?UTVNN09NeElyL3VZNmd3eXQ3R083dVdtVTJXR2JjZ3VWS3ZCNnJvM3BFVE5G?= =?utf-8?B?citGUkNKNzRaL0svdHN2RGNZQ1RmSm9wSjdIUHMvdElTdEYrSWhDaHZwYlU4?= =?utf-8?B?SGo1RkgwQ0VlaFc1REhTOERGdS9IV1Jrdmg4NitqVXRJY0dNQU5wSFJlUjVC?= =?utf-8?B?KzFDMHpiNFZ3cTlueFRnU3RGbjRzNG5nbjRMZXJqMW9kYnV4azVOR1Z4Yldy?= =?utf-8?B?aWNZc2x4Q2VEeVFhTGJYYm42WG5Xbmg5NU5IT09vYlZIR2hWbW9ibEVHU20v?= =?utf-8?B?VzR0VE5Uc0RSTjRDMFRxVm1FYVpyWi8xSlpISHFEWTVHVmZOemNPQ0RKd3VU?= =?utf-8?B?YzRya243V2VHd01JOE56aC9ZSFJjZzliZUlrckt2QnN2N2U3dGhTbEk2dGhU?= =?utf-8?B?bDcyTDdWcmJHYUZ6L0c4MmtLZUMvUENjNzFqYWdmTHVPMUlEaS9DZE5Vb0pX?= =?utf-8?B?Y0RkQmplWWFVeUF1U0xHMXlxU0xENFgxekUvKzRrL0xZMGJFcXg0RzNFUE5z?= =?utf-8?B?cjRIa2xPeVFNYlkxbit4ayswSVBhNURISXVRSTYyRkhKdXpXZkpybWhwSFVt?= =?utf-8?B?RHhHRzRSNDFEUnVyRUZjSHFaVmE5Y1JXa0w0dEpIN0NVY25GV2JVNmFMRW03?= =?utf-8?B?bWhYMWNwLzA0a1BJY3l6QnhLSkdFbFhwSWtudjRpa1h3ZDZ3bFNSZzZJZW1V?= =?utf-8?B?WldGWGhiNGN2WmZWbloxNFl0ZmFlNE9aQVQwR0EwSVhkYVlwWkJjbXBXOTdE?= =?utf-8?Q?pRr0iqgym/G0s25DznuxOH0eM61WXZ4kRCRwAYD?= X-MS-Exchange-CrossTenant-Network-Message-Id: 5ed4c017-7bdb-482c-0433-08d971529a9d X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2021 16:23:04.6363 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: b8JpsDCd1aPMHBe6+AtHdoddaCrt7jQ8dqi19yI4P5bWk2gA/jBNHnMtBPPaN0pcQsI9BXBdrquNkL4ha5QVNHwCIm8k2LEqK+IiD7IQ+vM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR03MB4999 X-OriginatorOrg: citrix.com On 06/09/2021 16:52, Jan Beulich wrote: > On 03.09.2021 21:06, Daniel P. Smith wrote: >> --- /dev/null >> +++ b/xen/include/xen/alternative-call.h >> @@ -0,0 +1,63 @@ >> +/* SPDX-License-Identifier: GPL-2.0 */ >> +#ifndef XEN_ALTERNATIVE_CALL >> +#define XEN_ALTERNATIVE_CALL >> + >> +/* >> + * Some subsystems in Xen may have multiple implementions, which can be >> + * resolved to a single implementation at boot time. By default, this = will >> + * result in the use of function pointers. >> + * >> + * Some architectures may have mechanisms for dynamically modifying .te= xt. >> + * Using this mechnaism, function pointers can be converted to direct c= alls >> + * which are typically more efficient at runtime. >> + * >> + * For architectures to support: >> + * >> + * - Implement alternative_{,v}call() in asm/alternative.h. Code gener= ation >> + * requirements are to emit a function pointer call at build time, an= d stash >> + * enough metadata to simplify the call at boot once the implementati= on has >> + * been resolved. >> + * - Select ALTERNATIVE_CALL in Kconfig. >> + * >> + * To use: >> + * >> + * Consider the following simplified example. >> + * >> + * 1) struct foo_ops __alt_call_maybe_initdata ops; >> + * >> + * 2) const struct foo_ops __initconst foo_a_ops =3D { ... }; >> + * const struct foo_ops __initconst foo_b_ops =3D { ... }; >> + * >> + * void foo_init(void) >> + * { >> + * ... >> + * if ( use_impl_a ) >> + * ops =3D *foo_a_ops; >> + * else if ( use_impl_b ) >> + * ops =3D *foo_b_ops; >> + * ... >> + * } >> + * >> + * 3) alternative_call(ops.bar, ...); >> + * >> + * There needs to a single ops object (1) which will eventually contain= the >> + * function pointers. This should be populated in foo's init() functio= n (2) >> + * by one of the available implementations. To call functions, use >> + * alternative_{,v}call() referencing the main ops object (3). >> + */ >> + >> +#ifdef CONFIG_ALTERNATIVE_CALL >> + >> +#include >> + >> +#define __alt_call_maybe_initdata __initdata > My v3 comment here was: > > "I think it wants (needs) clarifying that this may only be used if > the ops object is used exclusively in alternative_{,v}call() > instances (besides the original assignments to it, of course)." > > I realize this was slightly too strict, as other uses from .init.* > are of course also okay, but I continue to think that - in > particular with the example using it - there should be a warning > about this possible pitfall. Or am I merely unable to spot the > wording change somewhere in the comment? Such a comment is utterly pointless.=C2=A0 initdata has a well known meanin= g, and a comment warning about the effects of it is just teaching developers to suck eggs[1] ~Andrew [1] For the non-english speakers, https://en.wikipedia.org/wiki/Teaching_grandmother_to_suck_eggs From xen-devel-bounces@lists.xenproject.org Mon Sep 06 17:07:59 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Sep 2021 17:07:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180126.326626 (Exim 4.92) (envelope-from ) id 1mNI64-0004CJ-Bq; Mon, 06 Sep 2021 17:07:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180126.326626; Mon, 06 Sep 2021 17:07:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNI64-0004CC-8w; Mon, 06 Sep 2021 17:07:52 +0000 Received: by outflank-mailman (input) for mailman id 180126; Mon, 06 Sep 2021 17:07:50 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNI62-0004C6-MP for xen-devel@lists.xenproject.org; Mon, 06 Sep 2021 17:07:50 +0000 Received: from mail-ot1-f45.google.com (unknown [209.85.210.45]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id f6eb9e84-0f34-11ec-b0b0-12813bfff9fa; Mon, 06 Sep 2021 17:07:49 +0000 (UTC) Received: by mail-ot1-f45.google.com with SMTP id m7-20020a9d4c87000000b0051875f56b95so9471479otf.6 for ; Mon, 06 Sep 2021 10:07:49 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f6eb9e84-0f34-11ec-b0b0-12813bfff9fa X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=++LIn4BzMT/yfmvrIHegIKxrKLsnvbzGkInouRJvYyc=; b=CokLebOuvCoJE4SwzVfhnpNJLez5olRg6cY8guhMYST2+xtcuOhn9gOrGTmKNBiXYq 2lIUy1t3Qpr9lujq2Ux5CDSV6l/07ylN7DaD8pStMUBwZySwCq38+9pEWKfwtZgZ9Btq LCGiCkOOXozqkUbyH69kTt4wHrQYYuejV2YYvJpT6ZS8K2yfBY8w/BsDaYe0rVngEQAb OlzNE0BpEb0OXqHtUZ0Rgb4Ye56PyvfwUyZlzQEzHyLCSqVPHZUGgxMaVr6ophtvRpyT Ct0LPhOvI3Yasw7bTp2gxAgsybNm9pY5O1RxX8dzFu0GSX27wVSC46bmRqBQzV8Xqn4W 1Gmg== X-Gm-Message-State: AOAM533/DDBU4FFnz44WAx6aYHbFFwl3uPsfBxoUXZRC7T9XxDKH9LVa DDgZJOiNjpkPI8GFk9eOhuyUoG86/bOimuszkps= X-Google-Smtp-Source: ABdhPJxFe+shqvt53iInVBtVbEwgHxwTsvQqM7BZ8tlMMEWr+cag6cxnMCqsopLy1hSSKR9VzP0DVY4VLq48C4xu4fg= X-Received: by 2002:a9d:4d93:: with SMTP id u19mr11579566otk.86.1630948068687; Mon, 06 Sep 2021 10:07:48 -0700 (PDT) MIME-Version: 1.0 References: <20210903084937.19392-1-jgross@suse.com> <20210903084937.19392-2-jgross@suse.com> <1b6a8f9c-2a5f-e97e-c89d-5983ceeb20e5@suse.com> In-Reply-To: <1b6a8f9c-2a5f-e97e-c89d-5983ceeb20e5@suse.com> From: "Rafael J. Wysocki" Date: Mon, 6 Sep 2021 19:07:37 +0200 Message-ID: Subject: Re: [PATCH 1/2] PM: base: power: don't try to use non-existing RTC for storing data To: Juergen Gross Cc: Greg Kroah-Hartman , xen-devel@lists.xenproject.org, Linux PM , Linux Kernel Mailing List , "Rafael J. Wysocki" , Len Brown , Pavel Machek , "Rafael J. Wysocki" , Stable Content-Type: text/plain; charset="UTF-8" On Fri, Sep 3, 2021 at 11:02 AM Juergen Gross wrote: > > On 03.09.21 10:56, Greg Kroah-Hartman wrote: > > On Fri, Sep 03, 2021 at 10:49:36AM +0200, Juergen Gross wrote: > >> In there is no legacy RTC device, don't try to use it for storing trace > >> data across suspend/resume. > >> > >> Cc: > >> Signed-off-by: Juergen Gross > >> --- > >> drivers/base/power/trace.c | 10 ++++++++++ > >> 1 file changed, 10 insertions(+) > >> > >> diff --git a/drivers/base/power/trace.c b/drivers/base/power/trace.c > >> index a97f33d0c59f..b7c80849455c 100644 > >> --- a/drivers/base/power/trace.c > >> +++ b/drivers/base/power/trace.c > >> @@ -13,6 +13,7 @@ > >> #include > >> #include > >> #include > >> +#include > >> > >> #include > >> > >> @@ -165,6 +166,9 @@ void generate_pm_trace(const void *tracedata, unsigned int user) > >> const char *file = *(const char **)(tracedata + 2); > >> unsigned int user_hash_value, file_hash_value; > >> > >> + if (!x86_platform.legacy.rtc) > >> + return 0; > > > > Why does the driver core code here care about a platform/arch-specific > > thing at all? Did you just break all other arches? > > This file is only compiled for x86. It depends on CONFIG_PM_TRACE_RTC, > which has a "depends on X86" attribute. This feature uses the CMOS RTC memory to store data, so if that memory is not present, it's better to avoid using it. Please feel free to add Reviewed-by: Rafael J. Wysocki to this patch or let me know if you want me to take it. From xen-devel-bounces@lists.xenproject.org Mon Sep 06 17:36:59 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Sep 2021 17:36:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180135.326638 (Exim 4.92) (envelope-from ) id 1mNIY1-00084c-Kh; Mon, 06 Sep 2021 17:36:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180135.326638; Mon, 06 Sep 2021 17:36:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNIY1-00084V-Hj; Mon, 06 Sep 2021 17:36:45 +0000 Received: by outflank-mailman (input) for mailman id 180135; Mon, 06 Sep 2021 17:36:44 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNIY0-00084P-NE for xen-devel@lists.xenproject.org; Mon, 06 Sep 2021 17:36:44 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNIY0-00019c-7Y; Mon, 06 Sep 2021 17:36:44 +0000 Received: from 54-240-197-236.amazon.com ([54.240.197.236] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1mNIY0-0003cC-12; Mon, 06 Sep 2021 17:36:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=pfsAuKPr2auWUICkRafD2Xiy/uvIwmtJIwYIY7f4TAk=; b=wJtyMdrzHWQK6ZAa4IRuSE4Z3a SlbWGc8jfPzzDAOFtcZzZtNypBcL9z7GDOolAq8V9GtWQ+ZTQtLlN7TNeAnpCRMyxo2cXgs0l6dTq g/tHed8xO9LW7VqF2ikte83D8D/i3+d8fCc6Itrd0KSvCSZfCbCWeL3Ts9RtgXPXYgH8=; Subject: Re: [PATCH v3 7/7] xen/arm: Sanitize CTR_EL0 and emulate it if needed To: Bertrand Marquis , Stefano Stabellini Cc: "xen-devel@lists.xenproject.org" , Volodymyr Babchuk References: <14b1639e-c9e4-f8fb-e921-73d7f28681ac@xen.org> <98E8FB9D-3372-47D2-92F7-8AD401AC1092@arm.com> <6705127a-bde2-36cd-0fed-900eb1eace03@xen.org> From: Julien Grall Message-ID: <7fc6e6b6-464a-a305-2693-42cba40ad869@xen.org> Date: Mon, 6 Sep 2021 18:36:42 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit Hi Bertrand, On 06/09/2021 09:29, Bertrand Marquis wrote: >> On 3 Sep 2021, at 23:49, Stefano Stabellini wrote: >> >> On Tue, 31 Aug 2021, Bertrand Marquis wrote: >>> Hi Julien, >>> >>>> On 31 Aug 2021, at 15:47, Julien Grall wrote: >>>> >>>> >>>> >>>> On 31/08/2021 14:17, Bertrand Marquis wrote: >>>>> Hi Julien, >>>> >>>> Hi Bertrand, >>>> >>>>>> On 27 Aug 2021, at 16:05, Julien Grall wrote: >>>>>> >>>>>> Hi Bertrand, >>>>>> >>>>>> On 25/08/2021 14:18, Bertrand Marquis wrote: >>>>>>> Sanitize CTR_EL0 value between cores. >>>>>>> In most cases different values will taint Xen but if different >>>>>>> i-cache policies are found, we choose the one which will be compatible >>>>>>> between all cores in terms of invalidation/data cache flushing strategy. >>>>>> >>>>>> I understand that all the CPUs in Xen needs to agree on the cache flush strategy. However... >>>>>> >>>>>>> In this case we need to activate the TID2 bit in HCR to emulate the >>>>>>> TCR_EL0 register for guests. This patch is not activating TID2 bit all >>>>>>> the time to limit the overhead when possible. >>>>>> >>>>>> as we discussed in an earlier version, a vCPU is unlikely (at least in short/medium) to be able move across pCPU of different type. So the vCPU would be pinned to a set of pCPUs. IOW, the guest would have to be big.LITTLE aware and therefore would be able to do its own strategy decision. >>>>>> >>>>>> So I think we should be able to get away from trappings the registers. >>>>> I do agree that we should be able to get away from that in the long term once >>>>> we have cpupools properly set but right now this is the only way to have >>>>> something useable (I will not say right). >>>>> I will work on finding a way to setup properly cpupools (or something else as >>>>> we discussed earlier) but in the short term I think this is the best we can do. >>>> >>>> My concern is you are making look like Xen will be able to deal nicely with big.LITTLE when in fact there are a lot more potential issue by allow a vCPU moving accross pCPU of different type (the errata is one example). >>> >>> I agree and this is why Xen is tainted. >>> >>>> >>>>> An other solution would be to discard this patch from the serie for now until >>>>> I have worked a proper solution for this case. >>>>> Should we discard or merge or do you have an other idea ? >>>> Please correct me if I am wrong, at the moment, it doesn't look like this patch will be part of the longer plan. If so, then I think it should be parked for now. >>> >>> Not sure it depends on what the final solution would be but this is highly possible I agree. >>> >>>> >>>> This would also have the advantage to avoid spending too much time on resolving the emulation issue I mentioned in my previous answer. >>>> >>>> No need to resend a new version of this series yet. You can wait until the rest of the series get more feedback. >>> >>> Ok, I will wait for feedback and next serie will not include this patch anymore. >> >> Would it be worth keeping just the part that sanitizes ctr, without any >> of the emulation stuff? That way we could still detect cases where there >> is a mismatch between CPUs, print a useful message and taint Xen. > > That’s a good idea, it means removing the emulation part and just keep the sanitization. > > @Julien: would you be ok with that ? I actually thought about suggesting it before Stefano did it. So I am OK with that. > > Should I send a v4 or should we use Stefano’s patch directly instead ? I would suggest to send a v4. This needs a signed-off-by from Stefano and a new commit message. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Sep 06 17:46:27 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Sep 2021 17:46:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180141.326649 (Exim 4.92) (envelope-from ) id 1mNIhL-0001Mu-JG; Mon, 06 Sep 2021 17:46:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180141.326649; Mon, 06 Sep 2021 17:46:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNIhL-0001Mn-Fx; Mon, 06 Sep 2021 17:46:23 +0000 Received: by outflank-mailman (input) for mailman id 180141; Mon, 06 Sep 2021 17:46:22 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNIhK-0001Md-D3; Mon, 06 Sep 2021 17:46:22 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNIhK-0001K3-0G; Mon, 06 Sep 2021 17:46:22 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNIhJ-0004T6-O8; Mon, 06 Sep 2021 17:46:21 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mNIhJ-0005RC-Ng; Mon, 06 Sep 2021 17:46:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=4OtFCz7kZQXVcpAkuAPWawUFRMQ35ileKtWaSsqHdCE=; b=aOR4utRrlPLumiky2ipDS3q048 eDNhEjDGDdVnKrmgXkxo9BZVVtAnJaFmRPktmhTD14UQ6bApx6P+W45q6LtcnbRBSONMmYPoJOMpG 6Io3hzztZzQV7glxZh5P1WWAjIw4vu6jZxu/PFkEWKE/OzEsOTdU+6yVcL0KkjGEGiu0=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 164855: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=88afdc92b644120e0182c8567e1b1d236e471b12 X-Osstest-Versions-That: qemuu=31ebff513fad11f315377f6b07447169be8d9f86 From: osstest service owner Date: Mon, 06 Sep 2021 17:46:21 +0000 flight 164855 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/164855/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 164834 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 164834 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 164834 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 164834 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 164834 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 164834 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 164834 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass version targeted for testing: qemuu 88afdc92b644120e0182c8567e1b1d236e471b12 baseline version: qemuu 31ebff513fad11f315377f6b07447169be8d9f86 Last test of basis 164834 2021-09-05 15:08:59 Z 1 days Testing same since 164855 2021-09-06 10:06:44 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Alyssa Ross Ani Sinha David Hildenbrand Denis Plotnikov Eduardo Habkost Eugenio Pérez Gerd Hoffmann Igor Mammedov Jason Wang Jingqi Liu Michael S. Tsirkin Peter Maydell Philippe Mathieu-Daudé Tiberiu Georgescu Yajun Wu Yuwei Zhang jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git 31ebff513f..88afdc92b6 88afdc92b644120e0182c8567e1b1d236e471b12 -> upstream-tested From xen-devel-bounces@lists.xenproject.org Mon Sep 06 17:48:54 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Sep 2021 17:48:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180149.326663 (Exim 4.92) (envelope-from ) id 1mNIjl-00025G-6C; Mon, 06 Sep 2021 17:48:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180149.326663; Mon, 06 Sep 2021 17:48:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNIjl-000259-2b; Mon, 06 Sep 2021 17:48:53 +0000 Received: by outflank-mailman (input) for mailman id 180149; Mon, 06 Sep 2021 17:48:51 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNIjj-000253-9G for xen-devel@lists.xenproject.org; Mon, 06 Sep 2021 17:48:51 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNIji-0001Lg-9S; Mon, 06 Sep 2021 17:48:50 +0000 Received: from 54-240-197-236.amazon.com ([54.240.197.236] helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1mNIji-0005Bv-35; Mon, 06 Sep 2021 17:48:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=4TxAf+1W+KDaf8dtm2znwRRH5Pti4W0MUcRVqefKbqo=; b=3kyYO9DDEwEBE7eT/hbpGJ16Na HcoZWjMalx12VR6nNq0fb+1Lfk05VUBFqPye4/ZV4B9c4O0WwUVughtJUcTviw3CwBwj5cL43dqJ5 a9NMPFOHXedMoOVLPXxP23ljZEaHMFMfrhVkz1F+fAsPwHxEDG99wCXkSWViGD3dgoeo=; Subject: Re: [PATCH v2] xen/arm64: Remove vreg_emulate_sysreg32 To: Michal Orzel , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Volodymyr Babchuk , bertrand.marquis@arm.com References: <20210729104258.6320-1-michal.orzel@arm.com> <24ba08cc-acd4-c64a-1e90-dc4c8efbfe48@xen.org> From: Julien Grall Message-ID: <6ce114f6-ba2b-7262-ee0c-7a339465c9a6@xen.org> Date: Mon, 6 Sep 2021 18:48:48 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit On 06/09/2021 10:09, Michal Orzel wrote: > On 06.09.2021 11:07, Julien Grall wrote: >> The rest of the patch looks fine. So I would be happy to deal with the fixes on commit: > Please do. Thanks. Pushed. I have also re-wrapped the commit message to 72 characters per line. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Sep 06 17:56:18 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Sep 2021 17:56:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180157.326678 (Exim 4.92) (envelope-from ) id 1mNIqr-0003lc-WD; Mon, 06 Sep 2021 17:56:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180157.326678; Mon, 06 Sep 2021 17:56:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNIqr-0003lV-SJ; Mon, 06 Sep 2021 17:56:13 +0000 Received: by outflank-mailman (input) for mailman id 180157; Mon, 06 Sep 2021 17:56:12 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNIqq-0003lK-1j for xen-devel@lists.xenproject.org; Mon, 06 Sep 2021 17:56:12 +0000 Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id b7e7d00c-0f3b-11ec-b0b1-12813bfff9fa; Mon, 06 Sep 2021 17:56:11 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b7e7d00c-0f3b-11ec-b0b1-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1630950970; h=subject:to:cc:references:from:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=nUUgfuP/5TszjZLkwkCThXs/nKbossEJ3ZFdbxVQy/4=; b=VdP9eEEgjfZxZsH8EqLNkzkC8ElqsmQnrFjQ58ZgBTAVvlu4EVt/Fj9R DBx4BifmgQCc1QhGMdPA/WmPvdHFIz69lirh4wKIEcawbQ821RcZWKSuE Ht/2eW/BPy/1vbS2rzjChXxMIi+2tzeIb7rVkYMguMVgp1w1R1bqCsbPb k=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: VTba+8dEPt6A6J6iaSKByEmEkw0aMFkoYtidQv1hRx0YxY5+EnAN7UpcUB5kDVL2JHjW2+26lO XpO/mMUdodxRiegRNk0BDKY0GGZ/Rw6Y+FSuWwSYxAODA8ZGYcraUOiUjW/qkyeqiBLSlnkLlu xO5m7LWenx1qQQX/KWO9CDAV/D8OUFUqzsGavDv8zjCl+FSxj8jVGjxhk3DlFz+OzNJP+33JHK mnAEUzQjty6ag8jF4nhFQPEYNGwR75bVVh5XProTc5HcYuJHrJtl1UK9EJp+oqavx4C3xescs6 ivsGM41ChjMZAGDb4BJj09g9 X-SBRS: 5.1 X-MesageID: 52104379 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:+OsgBaHFsgLfSlk/pLqFf5HXdLJyesId70hD6qkvc3Nom52j+/ xGws536faVslcssHFJo6HlBEDyewKiyXcT2/hsAV7CZniahILMFu9fBOTZskXd8kHFh4hgPO JbAtJD4b7LfChHZKTBkXCF+r8bqbHtmsDY5pas854ud3AMV0gJ1XYJNu/xKDwVeOApP+tdKH PR3Ls9m9L2Ek5nEPhTS0N1E9TrlpnurtbLcBQGDxko5E2nii6p0qfzF1y90g0FWz1C7L8++S yd+jaJqJmLgrWe8FvxxmXT55NZlJ/IzcZCPtWFjowwJi/3ggilSYx9U/mpvSwzosuo9FE2+e O87CsIDoBW0Tf8b2u1qRzi103J1ysv0WbrzRuijX7qsaXCNXkHIvsEobgcXgrS6kImst05+r lMxXilu51eCg6FtDjh5vDTPisa1XackD4Hq6o+nnZfWYwRZPt6tooE5n5YF58GAWbT9J0nKu 9zF8vRjcwmMW9yV0qp+1WH/ebcGkjaRny9Mw8/U42uonlrdUlCvgklLJd1pAZHyHo/I6M0r9 gsfJ4YzY2n46ctHNVA7dw6ML6K41r2MFvx2VKpUCba/Z48SgbwQr7Mkf8IDbKRCdE1JKVbou W2bLofjx9rR37T X-IronPort-AV: E=Sophos;i="5.85,272,1624334400"; d="scan'208";a="52104379" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JB6JAMJ/Pj8vs7eF5ZcC9l8HXHzELkpIKv51WtTu3KsdoJpGSOP4M7Ay1b4euGIXes/QJFSItg9E4r8/wM9zCu3DS75EH8tEiOpFDOaUn6MsnYNf+g+yQZxeLrbBWynXOnRWngo0qj5zZl1Lhp4vMv0V9Ym5iEPUhGnlWlIUGUeJijRAG8uZgerxLlI5KyXO8cLB02hhPNkqyJYuyaRP30VTS5ZjpPIisZCa5UVXiuaMgr7hGj+sm6C5RjNNQzo5eIyA++cHaXg/jmRggeOsHXzjrkVR9YJUViyi0djsye2h3KQRpQVLExFI1mYBy5HfP7T5/bxwWG8RKor85GpO3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=nUUgfuP/5TszjZLkwkCThXs/nKbossEJ3ZFdbxVQy/4=; b=MpLN5pe95YsLzzPIYsAX7svDgN/b3sg0GnV9xye/8v6D7M8RyunHwTSWxYFkWXCn+Fte0dlIyvMdswYArko722r2gDElDFf4WdbdP88sxDJ4DiSiGaYAay6PfYZ30VKbl9jRhaqR2TbY1UyR8XMeysVrzlWWTwi2fOhM08swALeb7IpzPyJEq+pPpsn8UMXGNJNgmb67z2ZEB/mVgzlc75pqwoZW/Ks/F5Oc5hKO51HnCq7GBIT0HhfqeTXavkvfXpEZKUffneQ4+ByOv09B2do+05qFB+hm9cgcyXD37i+mruoYAiALWzJE2K2vo/afjO+IE1gnAjfxeqrbZ2UnXA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nUUgfuP/5TszjZLkwkCThXs/nKbossEJ3ZFdbxVQy/4=; b=jYd7M13FwTE+2ZwIBNvVGapfUtt3pCPVWZ38HXQIqtlNEcyqlX3mw5CPSyM8Ae9tG3r61QqVexu4vF/ecNvdVLLk9Rs7HEsl42TwmRXGUo65AvPeHGHGMBncLYcCC8MMpSbUKPGMV2vOsacyJ/Srvg1d8iwS4IFC341FjCyS4D0= Subject: Re: [PATCH v4 02/11] xsm: remove the ability to disable flask To: "Daniel P. Smith" , CC: George Dunlap , Ian Jackson , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Daniel De Graaf References: <20210903190629.11917-1-dpsmith@apertussolutions.com> <20210903190629.11917-3-dpsmith@apertussolutions.com> From: Andrew Cooper Message-ID: Date: Mon, 6 Sep 2021 18:56:00 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 In-Reply-To: <20210903190629.11917-3-dpsmith@apertussolutions.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-GB X-ClientProxiedBy: LO4P123CA0337.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18c::18) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2cbd5bce-78c7-4ec9-d9a0-08d9715f9a95 X-MS-TrafficTypeDiagnostic: BY5PR03MB5000: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: kVqkyrgTbep0EFVGZSZOxvecFukYG9u1J1AXU824VmPIBVA8XV+4YSS89eFJxCaKZ1l9h2vt5agK98ue1BV4CmkM2F04cB9/kP1pGqbUU0gxA3546/vPDee/r2LAE/ZeojzUz6f4aipBqiiiL/yKuspqaYnJZRL/YO9eNOE5GUTdY4kHT4Bz0fO5/6fkOgeQDFyZEs9R+PcQyRcabVM58SCcpUbgsvYYbBw1UB+5dgeOh9SScGhbz8oXyqx+9uFzpY6mo1OSV7ADhqRiZkDxCCLbVKIHuOitmOXdi6binNInlIZQ28EIL4qbOWSmTswqJdhYEa5o77+MD16C1ozERyLizIzm1dPDJv4POGJVGO+bewqwGtqwYG8VmODNRW+h+0ykNkzaWYvxPzuPEuM3EDaPMPqoL67IvLpqIOlpwOwIb0VTJStt0Ahas3KHpSShSHzoxQDFzBl45zD8FhHxnHon4yniVkgykR1r/FgXtnwg1dtzx5Ht9LfJeFfj/Z1snW8hsoyEh1lM/ZASqsrjPhhlqqKelR+kbj0+RE8hpqS02MhFZ3MMykt/rEkdu9aPpQ4mw8NSXxAUYb4VQY4UjEh2Ytro+6XJlqv+Z5BfzrQzhboGYZUkka2R8WAu2RpgM1PdFV8dU4VW/wvC49cKEqcA/jT4KMDXrHSkjgFf7lsuJj1tzcGQAoYEppTtJf+Yp/YJulUZqXt6EklVdJfTrs7VixxOzw792g3wWAw1Z8A= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(136003)(39860400002)(346002)(376002)(366004)(396003)(4744005)(66476007)(83380400001)(2906002)(31696002)(8676002)(8936002)(66946007)(66556008)(5660300002)(31686004)(16576012)(36756003)(6666004)(2616005)(54906003)(186003)(55236004)(478600001)(316002)(38100700002)(956004)(86362001)(6486002)(26005)(53546011)(4326008)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TXdndnArVThQWHpTM1IwZFZCSCt2Q1RWLy9wNDZ5a0R0L09lWlozT3RydUUx?= =?utf-8?B?TWsrMFk3MVFpMmM0L0dkanV5QXRyY3h6VENRVk1KRmwvMm0zWE5UL3YwTVZJ?= =?utf-8?B?VjdaUTQxOW9VVjczc2RGcG1FcTVOMmFmbVRYNUNBRTFlZUFFYnRYcFY2QU5s?= =?utf-8?B?bE1peFNpMkdDWE9kSWMzN2hYdDFwbTRPd1hUQXg3TisvYWcvT0dtOEtoOGoy?= =?utf-8?B?ZGk1SGJxbkVXUzV0NHpzVWhRVmJYcG9EOHZGMzUvcnBKZXpWTVZTa0ROaFdj?= =?utf-8?B?ZGdWY1E4ZlE0SGIzMkxCV3dLaFk3cW8zQVVwNVFjSmRxNEowNnNkSkprMkpl?= =?utf-8?B?eUpTdFVWWm1LZzJldmxMVG5UTmNBc2dXdTFxeTdwc1JNTlE5THErU2plWjh1?= =?utf-8?B?bWxiSVpESlcwVjlWWUprdmpEMjhuVXRUTWNSdXpXTUtoN3U0citDYWhBc2lZ?= =?utf-8?B?NHVtdmY2eVFlc0NKUDhDQ0lNUUttaDRONys2TmlWWUdqalBJKzRyblJWemhG?= =?utf-8?B?ZVg2MGE5R1VjNU5tUUx0Y0l3aG9vVENQUkExRDlEQ0VWNDIxMk0vNmxuZys1?= =?utf-8?B?Z2RxbGZxQ1VvVGFnOUlxWUVGRkg4WEU2MGxNSktmbGZZeEtDYzZzTjQyQ09h?= =?utf-8?B?RnJuM0lqZFgxNHFVREloZVBVa1dKTExRaEhPNDVCRjY2a3ZqVGlHd2VCa0Rj?= =?utf-8?B?S3JsM2cxeXdwSzJzNkRGZ0lUNnpRa21RU0FzK215eWxia2pkQzhKNW5OWUU0?= =?utf-8?B?TkhyMU1JUnBUTDk2VDJ5TUJkTCt2U0NKYWpsYzY2WEFBelRUZmNoeWU4dTY1?= =?utf-8?B?SzlSV0g5UWI5eCtwdEtibk9jL1BWKzh4R3ZtQ3pvYXJDeCt2N3RtWUJxWDhU?= =?utf-8?B?RFM2bno1ZHNYcWR2cThHdUFkNmVzYW51c1ZWWVFyQnREMEM2RWhPMFlIQmJr?= =?utf-8?B?TkVwZlFzYmsyZ0hna3VCMzd6c1ZuMHRONlVhLzRDemhCOWlGWUZsV3pwdXEw?= =?utf-8?B?YVM0c1k3Rlp4SC92ZVBoejMreWkzS3NqYytKYU5tMERDdEhLTU1ySE9iU2p4?= =?utf-8?B?K3lETWozMG0rNTkvSHA2dHlrdnljQzgzUjFUVFhtVlR3UjJrb1ZFN2l1bnVq?= =?utf-8?B?dGU5amxFTy8zVE9MQ1gramExaEF6d05WU3orazVvajdRQU55WmVnRjdzcW45?= =?utf-8?B?WW96a0tFOE5JNVV3QkZSczY1dDA3MmFQOU1ZRUR1VkdNeWlUUlNWczNnc2Vh?= =?utf-8?B?dmxVbXkxWDF5RkJXRVU2SU9xNnduSkVIdGJlRzRGRlM5NktWLzJrR0Y3Qktj?= =?utf-8?B?KzJEZUFacE9LbnV4dERyMHl3Rk0xTjZrRm9ZaTdOcytXc0U1K0MyRG15S3ht?= =?utf-8?B?bXRXY085NC9YdkVheVBUZS9VWDhobG9yeklTTGZkcXhxMjdiTFFlNDZkditD?= =?utf-8?B?QUdBeElZbDFoZWdRUE5JRjFqQU13RjRBanFtY3dXL2lnUVlaS0M5MmZORDM1?= =?utf-8?B?MmdmSUttUGptTmNqdHk0RkJsZTh2a1I5dWkrQXNUU2JsR1ZDRE11N1VnNmFE?= =?utf-8?B?b0VpaDY5Nlcxd2pkTDhGOHJzUVVVY04yZXlNVENPRWxXVE91R21IMVJGOE51?= =?utf-8?B?Y0I5T3RHcHNrVmc4S1BPZEpWaS8yRmxGWmQwalB6QjUzZjVuak5XcDB2V1hP?= =?utf-8?B?aURRRkhHT2hQVzNyZDlHTVIwdmVEZ29uOFphS2hoNTZ5aXdTdVlFSHhMNTlS?= =?utf-8?Q?pBl7gKf1L6t/vlW3UiSvEVWnAdTZBxQo1C/eNnH?= X-MS-Exchange-CrossTenant-Network-Message-Id: 2cbd5bce-78c7-4ec9-d9a0-08d9715f9a95 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2021 17:56:08.0348 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ntAV3uvyfkLAcTeYHRu8x7TH9y+13DYdQCu4ydXwazvhcZ6aMLw77icvvhntVxD3rc2hV2+4JYmvJTTDQdWaiFWfFm8NfX6pX6qNMWWelZY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR03MB5000 X-OriginatorOrg: citrix.com On 03/09/2021 20:06, Daniel P. Smith wrote: > On Linux when SELinux is put into permissive mode the descretionary access > controls are still in place. Whereas for Xen when the enforcing state of flask > is set to permissive, all operations for all domains would succeed, i.e. it > does not fall back to the default access controls. To provide a means to mimic > a similar but not equivalent behavior, a flask op is present to allow a > one-time switch back to the default access controls, aka the "dummy policy". > > While this may be desirable for an OS, Xen is a hypervisor and should not allow > the switching of which security policy framework is being enforced after boot. > This patch removes the flask op to enforce the desired XSM usage model > requiring a reboot of Xen to change the XSM policy module in use. > > Signed-off-by: Daniel P. Smith Acked-by: Andrew Cooper From xen-devel-bounces@lists.xenproject.org Mon Sep 06 18:00:32 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Sep 2021 18:00:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180163.326689 (Exim 4.92) (envelope-from ) id 1mNIuz-0005D4-Gx; Mon, 06 Sep 2021 18:00:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180163.326689; Mon, 06 Sep 2021 18:00:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNIuz-0005Cx-DY; Mon, 06 Sep 2021 18:00:29 +0000 Received: by outflank-mailman (input) for mailman id 180163; Mon, 06 Sep 2021 18:00:28 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNIuy-0005Cr-5l for xen-devel@lists.xenproject.org; Mon, 06 Sep 2021 18:00:28 +0000 Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 508fddc2-0f3c-11ec-b0b1-12813bfff9fa; Mon, 06 Sep 2021 18:00:27 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 508fddc2-0f3c-11ec-b0b1-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1630951227; h=subject:to:cc:references:from:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=hVReezva1bSFHzc08+Zdr6xsT6LCHgeopJi15GjeCc8=; b=ORcYJxRG/gBeSSFTPSYlVhh6Y/rwgSqVK1IDAXDe6jdzt+Xe598DGJ5z 1a6TBRqnHmhlwxuj4LgLWwszzuJT6NB/II3c5F1wPmKS1ZURIROz+ZS/5 39RGD91Prjx3GkDLxN5uc8Idg6bsJEKIxiUVRjQOdQvU9mgc1YFoJ0aYO c=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: X7eUQp6tuzQ90zkby4zuBFKbzv6oaSOv4wR0xGuSIdaM2RVYJGXuc+gMZSllMEhnhyKD/mTDCz pPo4VLTrZra7G7yeufcb0koKr3XalC57dshSmC71JXivZJJnG6ItRJHNgmqsTuir6l4R58Clim 9cYtRC3dmlXtCvo0qHjU6PvqoLTomD4bl0lJGNdyKfOjNm73a9ab0GBfvVZorz7p5eIwwWEGO1 7zHHW3h/cbYnaTh27qwNdScBDzPpnC/7zj9GKuWmRiwtt8OcYw9AZXNs+uOzBBAcKX2W2hmIhl 989RUCyN48Mxee/xQTi1flVU X-SBRS: 5.1 X-MesageID: 52115295 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:8RiGzK18jX10sI76Q5oOxgqjBSVyeYIsimQD101hICG9Lfb2qy n+ppgmPEHP5Qr5OEtApTiBUJPwJU80hqQFnrX5Wo3SIDUO2VHYUb2KiLGN/9SOIVyHygcw79 YHT0E6MqyLMbEYt7eL3ODbKadY/DDvysnB7o2/vhQdPj2CKZsQiDuRYjzrY3GeLzM2Z6bReq Dsg/av6wDQAkj+Oa+Adwc4tqX41pH2vaOjRSRDKw8s6QGIgz/twLnmEyKA1hNbdz9U278t/U XMjgS8v8yYwr+G4y6Z81WWw4VdmdPnxNcGLMuQivINIjGprgqzfoxuV5CLoThwiuCy71QBls XKvn4bTotOwkKUWlvwjQrm2gHm3jprw3j+yWWAiX+mmsD9TCJSMbsLuatpNj/ir2YwttB116 xGm0iDsYBMMB/GlCPho/DVShBDjCOP0DkfuN9Wq0YafZoVabdXo4Ba1lhSCo08ECXz751iOP VyDfvb+O1dfTqhHjDkV1FUsZmRt0kIb1O7qhBogL3T79EWpgE586Ig/r1cop9an6hNDaWt5I z/Q+xVff91P5YrhQ8UPpZ3fSKNMB25ffv7ChPaHb3WLtB0B5vzke+C3FwU3pDhRHVa9up+pH z+OGkow1LaPXieUfGz4A== X-IronPort-AV: E=Sophos;i="5.85,272,1624334400"; d="scan'208";a="52115295" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=e7TNtoxXe6LCg5dz499W2bhUflsE+gEht+DnQm6UbnptoOp9BbMqJP+R0BhFRu4vtAnB6CPDufjk1AKyApvXc045G52mSyIcBa1NdccHI4HRZSiUknEBRbeV9S9cQxjAvUpNZIyIImi+2mAF/VoeP+LkgfJ2OhhxsInYmyDhrbHEYk3fdeMZZr9AKQ93quoWdjnFygTAoYS3A4GkW2jUsorcHsI4MXDarW4oEum2LMXmeZm+daV+ipYTj7BYI1tI7Tby7Nc3iJ5e1dT/8ZYwmYd+90Oj1CT4VXGseHA0/vdc5yqGKEgrR9TN1wUzaSLuXXJDcmFAZoBCNQyawWVNKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=hVReezva1bSFHzc08+Zdr6xsT6LCHgeopJi15GjeCc8=; b=OhHy/CMhQl2QEGSdLSNbj57wevfGcKZBUbbZRr5Zlbdf/K/ExqgOPgA2c1ir5S43M4uJmxx7ahuTWeMYqJWiC24zLWpqptJJrFH4LBEMQlqKhSHCFKMgZRKzO32UZIvdPslobFygUAHEtZHzgJcu0JUABQKodLe8BNZGvMgvTUMUuG6SIO08SXwFXz5nd0PH1pYim2NKWMZz2CP1PAp5rqHFPZNZ12uQ3meq3+6DbejCavWFMtOAxKPc9sXlSWW/YeBdm1enE1/BxTARPBIat8IQP/GYLmL/MEcRAG4vhYjnGuGbq6E3FWAXCs0LLIIrxu+/NQijUuulIfGkKfEvvg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hVReezva1bSFHzc08+Zdr6xsT6LCHgeopJi15GjeCc8=; b=BM6XOLAvBYZUfwHFbBN9+i8gCufwmmwL0znbbGmvOGK29eGjTuwVw62DUvJ4NuTBbc9sK7goAKtsFANuxFXZZ2Sd1r2OkC48xWdGZmWIko9Cb7d8fiWqNhHWbnSTrotn9K52nBe9YrnUoVjzU1icVSy0t+NKzJbOnOjUnF1MDa8= Subject: Re: [PATCH v4 03/11] xsm: drop dubious xsm_op_t type To: "Daniel P. Smith" , CC: George Dunlap , Ian Jackson , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Daniel De Graaf References: <20210903190629.11917-1-dpsmith@apertussolutions.com> <20210903190629.11917-4-dpsmith@apertussolutions.com> From: Andrew Cooper Message-ID: <923afe88-ac02-77b8-06c5-480ddb2afe43@citrix.com> Date: Mon, 6 Sep 2021 19:00:13 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 In-Reply-To: <20210903190629.11917-4-dpsmith@apertussolutions.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-GB X-ClientProxiedBy: LO2P123CA0078.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:138::11) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 79473da4-3a1c-419a-a61c-08d9716030b4 X-MS-TrafficTypeDiagnostic: BYAPR03MB4741: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1332; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +7fZnZ/lN0p4q6mLzuc+LUICJI+wdXud8CWOQMptCNrXmVqWQiGOyjqGBrVGjttzmK46SjnmiSH0VPQYmSywbJt6FbRiYucpc8xKCEc0OZcKwVHaAFdwzfIM3DAfzknC1ekxJ+SVD6zuqafRtTKcUD0KDEWZieHEy4Ub5QFQWH6l5X3tR1kx/hdeHGFmFj8MuopYFi2zi//CswvGbJK4EWGdrh9kacuPkaMbANhUs5nvucwh+8THvQKL0+aGtz7cAXhyTAvtWBTcpmy9Ydsy52VIxSh6upFOlr6kP4PFKj8uMksnoxCice/ntzC6tonavoSU3RtmPtSQAOenHBg088nmJnTD/L1uOnUBWwtgszTxzV6oiIqqObz1cvXq2P8LwSjctmKg+dn5YQpI5GK6BwFYi6Fp7el+ktAaMSIssrh+VqX5v6NueKoO/eAUyJoYAF/mBXzk+GjFnmrEUHRx3m5uZ9+CBYvAoc6wNIWjkor9zRAbdRcpzv2RqKe5YUhOZjrmmHTG+pAsjvT8rGFbFZWBf+04rfIGWpRsA6QMHGIxqKeO51naZzlX0T0G9nH83ZcrLdZQxE7jDZF/tPH1g4N6ejaJ06jKqJY+sgU+hTYmYZKyPTJqXCFkU0Pd28rh9yCEoMxEZfWD0fnA919Vcy0SfdKYvf/Tr7SxyetEY+0JugNv6PuO9VOeOY1viDh0H4Uj7exo2LWXmxycDTXIZRn0K2PvBGGcdvuBD52pvPURRGAuQTOshKRP8gaIEmfL X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(508600001)(66476007)(66946007)(31686004)(66556008)(5660300002)(16576012)(8936002)(4744005)(2906002)(8676002)(316002)(26005)(2616005)(6486002)(36756003)(55236004)(186003)(53546011)(4326008)(6666004)(54906003)(86362001)(38100700002)(956004)(31696002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Yi9reTE0SVJFL3BqM3BhTjNEc2FsMnZrVGdPL0g0VEFjWk91cDVBTHVQcUlC?= =?utf-8?B?SWJlcE1pYzJiSW1TMCs3dzl4SVprd09sdU5udktteDJwalpPUjJYbDZmdzVM?= =?utf-8?B?cGhuWm5VMU1OczRmUGZJc1B4UEdYTjdxa2lIVEUrb01QeU1DOWR2WC92MjF6?= =?utf-8?B?NHl5Uk1sa29yeGcrRzJsMmhIMVNsV3BuOU1TalF1ZmNUeFNHeS9YWTQ2WWVY?= =?utf-8?B?L3NITXZYd3ZHRGZEZkt6OWZCY0w0dDB5dllFUU9sMlZBWE9pcWZNdVAyd3Ft?= =?utf-8?B?QmxQOERKMVZpT1d3KzBuTG00UWpDaFBWT2M3cWI1TXk4RlZUM0pxcW5LYXZD?= =?utf-8?B?NnRaOTByY1NmbkVjK09GVk9zQzFrNk5OTms3K1g3U2pXMUxzQTdvNm5TdnVz?= =?utf-8?B?YlpDUGpJWWViVG4wSkRKZXkyL2RLV094Uk9RTkk0cmV3Zm1qak5qTDZJbUhT?= =?utf-8?B?QU1sN2plcTJNZkdMQWg2UXRRa0Jta28xZ01hVlNvcXBrS1JWQ2R5MjVIOGVh?= =?utf-8?B?Yk9qYTM5TVFFYWp4OXMxNytpQTIxVWZBdTFvVTNRdGdpZHhkb0NGQjR2NzRn?= =?utf-8?B?cy95em9PY2xuc21qbUcxTXFSVFlVeG9IRk9HeUYwZWl4Y05jTmZHblpkMm1H?= =?utf-8?B?ZjZhSDY5WUxhNXNvTkdqV3BwOG41dmVlbVJIVEJKT05TRnVhUWw2cWNUT1oy?= =?utf-8?B?QVJLQTNiVE9XNEFkYmpKQjh6cUpHUDNjd2FMcGpMaFlZR0sxaFh2b1ExTG5Y?= =?utf-8?B?cHZPb3VxVzNtb000dUdvaXdsWlRlTmFPVlZld1JHQU9KUGdJOUlYOUZBVU9S?= =?utf-8?B?a1RzdmcrUTBsNXp3TllWTVFJZU50RjlGU0pzS01uc0lBRjMrSXh0TzROU2dL?= =?utf-8?B?c2E2ODQvMStVWjBLRDVtTTRSVW00RUdGQlhTekllY2pjTnB1M0JOMnhaWTZ1?= =?utf-8?B?bTFVdDVONUVtd3hJdmxyTXgvUFlWWDVNV2VYVE5yKzlnaGR0Z2FRWHJENVZv?= =?utf-8?B?L2FBeng1a0xkM2V3UVdwNHpTVnlTMjQ3eVQxNWJUN05Ta2U2NFRHODZ0RHUw?= =?utf-8?B?Q1F0YVp2U0VXKzgxVkIxeFl4RDV3eWUwYTVQWVMvRFMyN3M2SHYvVFRad2Ur?= =?utf-8?B?d1AzYmRaeWlUejh3bnhpMUljK0xOZ0dNaXVnUWZXWnQwRnB3M2NJcUU4NXhu?= =?utf-8?B?ZXJSbW5jSnF3WlZiWCt6OEw4M1J1S0JsMlVRYUJKR1MzQWFENitRYXFLRlU5?= =?utf-8?B?NkIyVUx5amFjbi9JWTk1QUtQZTNwK1c0emNjckNCaGNua3J4cVpmM3lwZXUy?= =?utf-8?B?eHdRYkxsNzJaL3JoUTFNOEZReXhiVllKRk9ZWG1haWZWcFZ2MVdpY0VoSEdP?= =?utf-8?B?OXo3dkxNQ3Z6cCtnSk9iM0hIZVoyNHFCYXdxSFo3N3BjeUpXQW4yWEYxSUNm?= =?utf-8?B?bkY2M0NyUTI5VGtHL0RaSzZsS2Vvb0ZIMUpOK0wwQVhJdzM3Wlc0ejJyYW1a?= =?utf-8?B?Z284UGs1VWc5Nm5MU2xQUE9kZUZMMndrY05udDRJQnc4eXlKeFZLWUl1dGxI?= =?utf-8?B?cWZjVXRTeHNhcG1YYTF4eWRHeUgxZTdKVkR5Z1EwcUJkMUJGbUdpNkNsczlF?= =?utf-8?B?QVNlaFNDUndaWjlVVUNIbGh4MnlNOXF0bGw4WFR2bGpOWDJKNHFjbm9DTloy?= =?utf-8?B?VnYvQVdvU1JuOUdHOUhLdDlISlJ0bVJFUjZ2QWlYQnFNbVV1d1RkUHFabG80?= =?utf-8?Q?lcC3Y2+LjhJ84Sq1ANqwlDQSkAG7Vq+0EKtnTe0?= X-MS-Exchange-CrossTenant-Network-Message-Id: 79473da4-3a1c-419a-a61c-08d9716030b4 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2021 18:00:19.9119 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: xBRfsa+IvyMX7SZXZeIY51QvHrjigniW5TS27cgJp6ZCRx0ZRMiJRqnRD10scyjZML+iNYF2qVOVTVndOoLZ9xxItmdE4kV0psXmbbpmA6U= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB4741 X-OriginatorOrg: citrix.com On 03/09/2021 20:06, Daniel P. Smith wrote: > The type xsm_op_t masks the use of void pointers. This commit drops the xsm_op_t type and > replaces it and all its uses with an explicit void. > > Signed-off-by: Daniel P. Smith Acked-by: Andrew Cooper HYPERCALL_xsm_op really ought to be renamed to reflect the reality that it is "flask op" and we cannot possibly reuse it for other XSM modules, but that can be added to the todo list. From xen-devel-bounces@lists.xenproject.org Mon Sep 06 18:07:59 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Sep 2021 18:07:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180169.326699 (Exim 4.92) (envelope-from ) id 1mNJ2B-000696-9h; Mon, 06 Sep 2021 18:07:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180169.326699; Mon, 06 Sep 2021 18:07:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNJ2B-00068z-6j; Mon, 06 Sep 2021 18:07:55 +0000 Received: by outflank-mailman (input) for mailman id 180169; Mon, 06 Sep 2021 18:07:53 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNJ29-00068t-K4 for xen-devel@lists.xenproject.org; Mon, 06 Sep 2021 18:07:53 +0000 Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 5a02463d-0f3d-11ec-b0b3-12813bfff9fa; Mon, 06 Sep 2021 18:07:52 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5a02463d-0f3d-11ec-b0b3-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1630951672; h=to:cc:references:from:subject:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=tatBAklfoTz0IHa6ERQ2r3u844FuxIM8q6wiCalO/oA=; b=UPScWOQ3csiWpfJ+cGBYjScDBO7H/tNvoWYFPxBw8odbS+498NOpU+gP 28OzAPXucHm3l7u8LZcadtJJ6jmZn+6iYgnq33hX4fWc23Edv1Df7B9h6 pK/6UecmXYPf6GOUaWcvbew9Y2FxvrJNqN1Ad/iHyHyGHmJsZPqkyJlAL s=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: dEaSWqBoj63gUhgCCQ+WlgRYldYcv7Eds+6ZAI+mjCtvfQTL5D/hm9//plqEFfMNSkrW713r9J Nj2h1d/9RKP/VTvg3MMyI5Kv/mi62S4M/Qxh1xVqbPO3cF7VYp5vACZ62EbyhbloBBlQ/pDgaM ttE4QrcIYbNb/ugqmIBbLZorthWMk6AHPlyaqo9Jxh3ZO4epj1VSqn+PCWtwbEPFWvW1Slm9H2 NZu/Dr7t4D7zAGj2/LaUErcxvSrHFcK03ZYzWLp4kqZZIXdcRfwseoq66C9NqBV27LLa+Ye15M JLp1yXyebgh0TJFYuo/4UYDa X-SBRS: 5.1 X-MesageID: 53860036 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:6na8C60Dd1DnAUXj3ligFQqjBLYkLtp133Aq2lEZdPUzSL3+qy nOpoV+6faQsl0ssR4b9exoVJPufZq+z/5ICOsqU4tKNTOO0AHEEGgI1+rf6gylNyri9vNMkY dMGpIObeEY1GIK7voSNjPIceod/A== X-IronPort-AV: E=Sophos;i="5.85,272,1624334400"; d="scan'208";a="53860036" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bZ2VpO9mG+T2NomCSkFdTBk6E8i4I2vO52EcQbhCplkCSy+2HGAcXbDxkwlZCdR6NIZtlsDrVQZcxTDJendbn0r4kNmYOUwHRP8gg2I23H6ytuTsIFFiJ+cQsfINESBEfS9gbGg+XAi+fuu7MjXpO4OopXPU5jE6BPnQrXAZBrZDCIVoe9db1d22aq//BCpmRoqFVN0gQCa1OfD1IlZpqmnKnhQX46OpORsLKQcE3OqiBS3aZwdBh6EDjwN/HuGeMOgXdMKEIRH3fwhdXlO0puHo8UJqHoIa0f1jgVx4B0zhgJP4tRhBhwCm3KDY8iJzNrqQJOscH1Gqwwb3sG6fFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=0Mncjb0+JPGtlBvhg0XIVHAc93gaDfzgSaMk3YdIyJU=; b=ae+2/oq0Jzfk8uYwF0/lk1izupG7YWdXafG3G6ll7M5604SJODsMqptpVEGWj056AshtpKW/YqhrFfU0SaN7Q2fVCWJhh1Cnfg8QPSMySInZ+0crvyUUSADKH1Odv4ShQUCrMt/bIQ0QhDytMUGiOIyIM8id/tv8L44LMUuIKLjGwrXjaBYRXvByhOqc/eogob4v8fge2rYAjFL57GDW2xmTE8ODg+UqJobZwroRphA/ORl04/tr3MoShrHJXnxX1blPSC/Lw/wupNtTiVmh46+Ed79Cr43gbt1RiKswHxwQCMjOXfA2wE2Am3PGku1f/KEJVVW8WIo0I6fywClFIw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0Mncjb0+JPGtlBvhg0XIVHAc93gaDfzgSaMk3YdIyJU=; b=xnX6zHR0yZjXHyfBffcjLF41hgf00ZSlykbyFrBJWWbf8pDU00oyA4dH4ZIW/2Ae8UG0TdC5IXBKe7j8RduGK4m8rFcE5iP8SGVFsrzPnQF1zQduoEHc/Fg857AdXjtZb9q9LXBJAvpBHnUnbq5xmyjpFZxNlCzEqw9jgsY+xMA= To: Jan Beulich , Jane Malalane CC: Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Pu Wen , Andy Lutomirski , Xen-devel References: <26b88d5a-ae6f-0065-7c3f-5eeb6dd80078@suse.com> From: Andrew Cooper Subject: Re: [PATCH v1 2/2] x86/cpuid: Detect null segment behaviour on Zen2 CPUs Message-ID: <2972c71a-5fed-0813-8ec0-d179eacff14d@citrix.com> Date: Mon, 6 Sep 2021 19:07:40 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 In-Reply-To: <26b88d5a-ae6f-0065-7c3f-5eeb6dd80078@suse.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: en-GB X-ClientProxiedBy: LNXP265CA0095.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:76::35) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7e97e60b-760e-4a32-97f0-08d971613b65 X-MS-TrafficTypeDiagnostic: BY5PR03MB4997: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yNZHqmSxIatNQYb18rRAi6XBJxigwx3fUFH5MpYv1DDMLgz4oF3irB3mVEMAVEA5546aw62LMASQR9eolrmyq4gvIVsu3yq0KbFE6led3WvGI+SopDLX88iBjoi98tbNAFT8PTT3IGdvGMhm1gcZ1lLd8QQA+ve3toWgTfi7fWu9zB9DMyhNY+H0uu3MDfuHSWgMGav1mgPoHIdq1r1p2VTkVRKbBaLux3YjtRJ9dIEfkXilv/FnzgP+hm2mQDBoCeq+T5FwC0E/CDzRjMZZ9mh9snOgKrrhcvSMWxDsn+fA2xrn+MlOmPLMN5o7FhO8qYOB7diPDVL+eYe/yQ9pEE3+HMmQxYGtzzoZd1sV+G5odnAKYhRPDnP0MDVeSKK7HEAJtrSX3Fh/vskZ6ncy7/yc2qoGOqFnqpDVWkmKly1OrgIGH1C+9PgL0J5qHrcVTn+v8ZFro3rfkKYH27lRl2k8yvg9UEa8Gqk3GHWDo1TMQM9XxGRJFIgzx/5qjj0qjPl7kJsRDLIYn+TzNPTadyxgeaeSO7z2stWm3LSstZa6lqfZFwLjhLTDYG1DybPN/Y7vDQEPyeSmGCYZwhMZk2Yi49NfnHbq2k7mfn1qwGrtWkU6XGpvYKS5XjFwwkZJbK7QHTbaAwvIoA47WSDU8yGIqn/64vlwSPZ2dGxIhjaIo73Bk10U5W7ftASlGzo1+CgnD0os0aNSRvdhuoCSUEc+mZsRQWm9G4KEj4GRL9zHVkIKUfpmHeMInG+oXQGV X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(376002)(136003)(39860400002)(396003)(366004)(55236004)(316002)(53546011)(83380400001)(8676002)(956004)(26005)(2616005)(8936002)(36756003)(31686004)(186003)(16576012)(110136005)(4326008)(478600001)(6666004)(54906003)(2906002)(6636002)(66946007)(66476007)(86362001)(31696002)(5660300002)(66556008)(6486002)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q2J5N3YzWTBIZENDRnJaWVV4NkhUdHFhSlFKdlBBVFRDQW8zemFhV2MxWSs2?= =?utf-8?B?M3E0MXRRTjNqS2x5VzFkbFlBOTc1djZyc0dsWngyNG5QN2p6SjJucGNFbjVH?= =?utf-8?B?Z1BQc1BoWXAyNHR1WkRMeUdGVGp2UnQ5bE5VQ0ZoSmVHWFFEaC9aL3RKcU1w?= =?utf-8?B?NDJ4K2MxeUJxQUQ5YU9IanZITTl2U25wZVh6b1hyekFBZUFOZHNzUFFHN3Y4?= =?utf-8?B?UGJoZitmZk9DakJEL3FScURtWHlYeS82Nko2WW1vZUdxaHFBT1BISWdESWZJ?= =?utf-8?B?bFVJenhNTFp2WmptMTlLSFh5NnNtVlVVb0wxRmhVeHZQUnRWSVdkLzdQOHJr?= =?utf-8?B?cVZ6T3VzRjVwbGFIbTlFbkYvMnN3aG8raTRXWkR2Um9uUDEyYU9wQmcyYUVq?= =?utf-8?B?K2J2Q1dzZnlLSFNDOExsSk5mSDBEdGpGK3dKOXZxTHhNaE8zTGNGQWQzWmVl?= =?utf-8?B?K1ZZOWdRL1plaEZSdnJwcy9xY3RqRFJhR2k5RFBwajhwakVXcmhjTENjRitB?= =?utf-8?B?cFJ0SWd3bEt4ek1pMlZXQmpIMXFPbGdNTitGT29lUkphU1ViZ2ZzS1N1YUJa?= =?utf-8?B?OTVSY3YzSDh3ckFnRCt1TEROL2pOVmZHL0xJcG1iRkxadGEzZEtXNEYzT2th?= =?utf-8?B?SGU3NHNheWx1SWs2Rlo2SVRLbWpCZGQvbzZ2NGRDKy9RNkNNSmJjT3phbzU3?= =?utf-8?B?eitXRW5iWWpxdHdSTEp4K1VyZ25MTlg2MjB5dTNyTWxrQjMzaDh1UG9kZGVn?= =?utf-8?B?REIwNloxYmdiNzFwOFVyT3ZONjBVaHBVZXBEMElxK1hXdzlITjltWU92L1RP?= =?utf-8?B?RGxYODUzcUVkOXYyREtIbUFqZXhIbDhBUXNIK3JpejRVWW02T3dLUnloMzVu?= =?utf-8?B?eDg5K2VFU1ZFc3pVQ0t3OE91R0dkK1RnVS9pd2F4WUx5dGZhWmlLZGNWdEtJ?= =?utf-8?B?L3VYb3Z1S1JBQno5aHhJMWh2M1VTbVpnQlh3dDU1dUhKQ1BZSHlFR2J6Z2gz?= =?utf-8?B?cGpwNUw4QS9jcXdrbFZhSlJ3SkZ0V2NtVy9JbC9Fc0I3aVF2RmNvZVBaWDEr?= =?utf-8?B?R3p4SEJrM1R4dndDZ3RJTjJRbldWbVVXK2NGQ0FxcE5NTXNZSmVRNUs0dzk3?= =?utf-8?B?YjBhSGxpT2doTkwyblllTEJaUEl0SE81bVZLZmVZQ2NzdWhPcjlJSFlTV0tY?= =?utf-8?B?YmNRODJBWDdhaTk4YytyTHV3WGY2NGpEejFxcWxhenhvSmlPTC9neXZ0bXRQ?= =?utf-8?B?T2dZZTg1c0hjMkVwZStiNXFkS1RwcDRXZDQ3b2c3aGMwYjJTMnc2bzRPZ2Fl?= =?utf-8?B?S0hQc1BTeTNIOHpGamcyRFNZSlR0SjViZ0NWZm9NRWswNjUrOEJKbjRxbUpD?= =?utf-8?B?RUkyNlgvZHo4RWYveTZUR25JVE9RYVduaVoyV205UWFnTTNtb0dqWmx6T3RX?= =?utf-8?B?NGQ3VjY5SXVFYkN3SmNBaTZhMTRuYVE5SnRLdlZKN0orSFJhZFNvUSswalB4?= =?utf-8?B?Y0xZWWVZTllHWStPdTI1cTdYbVRYMHJDc0NVWEdDSjduMTAzR0F0OVZsOWZG?= =?utf-8?B?VU5iRGJVaW5sYTVqMk1Gc05veEM0VkRJcExURWRXQ0VZc2prUXdRZ3VDQzkw?= =?utf-8?B?aFhGUkg2V2dHQXNDRElsUUgwYVBSUnl5ekFObm9tOVhpYjQyOUpPLzFtV0xj?= =?utf-8?B?WldteTJaTnRyckV0TVE3TXpVZjk0OVFtZGlJc1pDQXJWMHR2NG1jT3kwK0E3?= =?utf-8?Q?KdTslSsxjAgfCwqCMFhc9rZ9mPUC4izT+EdTWGZ?= X-MS-Exchange-CrossTenant-Network-Message-Id: 7e97e60b-760e-4a32-97f0-08d971613b65 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2021 18:07:47.3045 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1POKSrEGRmFY4zTTBpwp50UhM/6sP/EJq5QlxM7n7uNq34mW+8nkCYSCaz9MQwo5/me1Mezze9qtOC1pvs17wH/JpbD4oED30DOOmtJPBTo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR03MB4997 X-OriginatorOrg: citrix.com On 06/09/2021 16:17, Jan Beulich wrote: > On 06.09.2021 14:00, Jane Malalane wrote: >> --- a/xen/arch/x86/cpu/amd.c >> +++ b/xen/arch/x86/cpu/amd.c >> @@ -681,6 +681,19 @@ void amd_init_lfence(struct cpuinfo_x86 *c) >> c->x86_capability); >> } >> =20 >> +void detect_zen2_null_seg_behaviour(void) > This can in principle be marked __init. > >> +{ >> + uint64_t base; >> + >> + wrmsrl(MSR_FS_BASE, 1); >> + asm volatile ( "mov %0, %%fs" :: "rm" (0) ); > While I don't strictly mind the "m" part of the constraint to remain > there (in the hope for compilers actually to support this), iirc it's > not useful to have when the value is a constant: Last time I checked, > the compiler would not instantiate an anonymous (stack) variable to > fulfill this constraint (as can be seen when dropping the "r" part of > the constraint). This is "rm" because it is what we use elsewhere in Xen for selectors, and because it is the correct constraints based on the legal instruction encodings. If you want to work around what you perceive to be bugs in compilers then submit a independent change yourself. >> @@ -731,6 +744,11 @@ static void init_amd(struct cpuinfo_x86 *c) >> else /* Implicily "=3D=3D 0x10 || >=3D 0x12" by being 64bit. */ >> amd_init_lfence(c); >> =20 >> + /* Probe for NSCB on Zen2 CPUs when not virtualised */ >> + if (!cpu_has_hypervisor && !cpu_has_nscb && c =3D=3D &boot_cpu_data && >> + c->x86 =3D=3D 0x17 && c->x86_model >=3D 30 && c->x86_model <=3D 0x= 5f) > DYM 0x30 here? 0x30, although it turns out that some of the mobile Zen2 CPUs exceed 0x60 in terms of model number. As Zen3 changes the family number to 0x19, I'd just drop the upper bound. > Or 0x1e? In any event 0x5f should be accompanied by > another hex constant. And it would also help if in the description > you said where these bounds >From talking to people at AMD. > as well as ... > >> --- a/xen/arch/x86/cpu/hygon.c >> +++ b/xen/arch/x86/cpu/hygon.c >> @@ -34,6 +34,11 @@ static void init_hygon(struct cpuinfo_x86 *c) >> =20 >> amd_init_lfence(c); >> =20 >> + /* Probe for NSCB on Zen2 CPUs when not virtualised */ >> + if (!cpu_has_hypervisor && !cpu_has_nscb && c =3D=3D &boot_cpu_data && >> + c->x86 =3D=3D 0x18 && c->x86_model >=3D 4) > ... this one come from. >From talking to people at Hygon. ~Andrew From xen-devel-bounces@lists.xenproject.org Mon Sep 06 18:17:24 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Sep 2021 18:17:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180176.326711 (Exim 4.92) (envelope-from ) id 1mNJBF-0007rw-Dk; Mon, 06 Sep 2021 18:17:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180176.326711; Mon, 06 Sep 2021 18:17:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNJBF-0007rp-8S; Mon, 06 Sep 2021 18:17:17 +0000 Received: by outflank-mailman (input) for mailman id 180176; Mon, 06 Sep 2021 18:17:16 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNJBE-0007rj-4y for xen-devel@lists.xenproject.org; Mon, 06 Sep 2021 18:17:16 +0000 Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id a94a317c-0f3e-11ec-b0b4-12813bfff9fa; Mon, 06 Sep 2021 18:17:14 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a94a317c-0f3e-11ec-b0b4-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1630952234; h=to:cc:references:from:subject:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=bC+EJiQzJ/3oT+llAauPcqganhRQKwalHRfyaI9+9Tw=; b=UezwOD+EOtgh0fPRXulGw58z9WTzbDOBqiK5cnkwZvBltQhCdJYZRgog IZJSIPSyf4eGiDUr9rXPb4KJzLrA60CaLiE03QS9CD5WlnTlQ6dbsJFx/ hyjWyeEOtG/2g0B648mibq6hZekbmLGa4ySXBbPDvMCyM7FSvdcgvkfCb Y=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: 3O2i/bW5wEkgN2rYiFXpS6Zu53HhjTcrLQivkUprjMnlCrQboLUGdz9To1FsjgsxmYXi9XU/tZ 9lrTUaoxNa6QwnsJdbfizSk4O7ZdiujrkL/yf5DHpGrYcdaqBeBOwR7aCzWPCGo2NC91LMLnAV 90aSmINcb4Byr0O2vgB3Ysr4PXbBK7x6gLt5I1LA56wM1PTbCGcVC/+vN7emKpFodAhK1phmAK Vbo9UqwtKUJGU8L+9SH6qzrHAs03omVMTut6r3+HtuekjTDpWt3HaFT/Hsl5XD7sDxvFR9t7rT DEHD64zkBYhmCJ7jVAKGr5gv X-SBRS: 5.1 X-MesageID: 52105057 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:DwSEQaxFyy9SLGcW7Pm9KrPxvuskLtp133Aq2lEZdPULSKKlfp GV88jziyWZtN9wYhEdcdDpAtjlfZquz+8K3WB3B8bcYOCGghrVEGgG1+rfKlLbalbDH4JmpM Fdmu1FeaDN5DtB/LXHCWuDYq4dKbC8mcjC74qurAYOPHNXguNbnmBE426gYz1LrWJ9dOME/f Snl696TnabCA4qhpPRPAh1YwGPnayGqLvWJTo9QzI34giHij2lrJb8Dhijxx8bFxdC260r/2 TpmxHwovzLiYD09jbsk0voq7hGktrozdVOQOSKl8guMz3pziKlfp5oVbGutC085Muv9FEput /RpApIBbU911rhOkWO5Tf90Qjp1zgjr1fk1F+jmHPm5ff0QTorYvAxzr5xQ1/80Q4Nrdt82K VE0yayrJxMFy7Nmyz7+pzhSwxqvlDcmwtgrccjy1hkFacOYr5YqoISuGlPFo0bIS784Ic7VM FzEcDn4upMe1/yVQGYgoBW+q3oYp0PJGbDfqBb0fbllAS+3UoJjnfw/fZv3Evpr/kGOt95D+ etCNUhqFgBdL5OUUtHPpZ0fSKAMB2Fffv9ChPmHb3ZLtBxB5vske+83Fxn3pDmRHQ3pKFC7q gpFmko7VIPRw== X-IronPort-AV: E=Sophos;i="5.85,273,1624334400"; d="scan'208";a="52105057" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=chiLBGFVJPSEpysz1lpQqJNjZC43D+rFqTOt+wtJmahEFMd8otEPIfkJjwO3FeX3366vXHQAD18IgSAdq0uFeqSftqhLjtt+qpYSvXpcT7qq1PlDqd4x9n7DYf4psM0Siip4oSokG3bGEjF/egEyjJLGoA3JANBrWOAmsq/3916tGUvLXXsptxKhOIfJCNmaiuc1vv8SL6CK7P21bdME+/dTorlXtwrqLpJJtI8Hop4M6GyFlKnI0FZkbgZler9H4LdTxM6Ov5ztuHeZEHYIWqJP1c/56G66lVxqF/OIoZ6UblJd0Lwg98e63aPhzKhZrctvHyYIoK49L2WuNL5/Iw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=0694yTCPGieLg9B9FN4YDvoVX+IZkzSt6FqWq++RqgQ=; b=jKSvGNIKr0tjVgU6NnrBVv53PlUodnuexs10miwY96ZYLSCOrOl8BmMs38nKN5VkIYcTA7PqNKgBXGBF8hO1TpuHIxDLylMQcDfrNFAD6e+iqaQS/7+Z+D0By+sG8f9DW6UVQTBaLTZov50xESoxh24vawVTTd7FnLTRcI3P+OyylB93PPVp1R217dDyhIpfUAA1OVFHahU4gTh0Pk6LIWpuZ6rx1f63tgpKDPqSAPzCfDNtPo4hurxKwAoIL+FesLTmzq0ZCHUE1gdr2UNOx4czmN8dlXmhg7d86hW9rxsvACAEoaKB/1hYoEIrtN9XVPGLo4EXYEdQ4LvGhAxc1A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0694yTCPGieLg9B9FN4YDvoVX+IZkzSt6FqWq++RqgQ=; b=NuniERP551CZ9ZHg2P4cauD4vyGOCdcuAhy8WQNHD0PcIO4kmV0h1Na0dcA91m6iHIHgWQR7AWPN2QHtzffo/ph4bvUPa5V5+GeMZ9QDkETYMh9bNSojKJDmCx+ou2/CmLTPAfzwjByBaMhOAhnEjtE9vdltM5vvcShY7os4YYg= To: "Daniel P. Smith" , CC: Daniel De Graaf References: <20210903190629.11917-1-dpsmith@apertussolutions.com> <20210903190629.11917-5-dpsmith@apertussolutions.com> From: Andrew Cooper Subject: Re: [PATCH v4 04/11] xsm: apply coding style Message-ID: <01c81885-9ea0-3ecf-66b0-009b9e7ba39b@citrix.com> Date: Mon, 6 Sep 2021 19:17:02 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 In-Reply-To: <20210903190629.11917-5-dpsmith@apertussolutions.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: en-GB X-ClientProxiedBy: LO2P123CA0026.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600::14) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f8e8915a-9a06-4e25-7728-08d9716289e2 X-MS-TrafficTypeDiagnostic: BYAPR03MB3670: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: a6PZ/TDbf344B4JInXfmap5ABOq96iIEUJGbtaM2XsQwKs4iNQmu4G1AvS+Fc7HH2/bZwyERHyYrkTkc/TcVDz0CHHQevCXM0IM7wqIvpVxIeDh8R5MLkdK2mPgWBPDjedmn1mEajFrtUlrGKo38hvgltwuhpFBFz5hPv/Ls+kwHSklX1XU1kaUWeorPaGMs0C36h8G4bplKThg5y834/8IWkS8Sps1NfkRL2ebpdSttlZldzi3+YnSIVxUBHfRfNGhbSlq31SL5hq+hlceDExbadCDBJGaIOzSfMBBidkym5NNIiREMiwwpHRmYa1UkcaQ6fw4QnEe0CxWJqF1EhxV+cwBDJFqiF8Sj7IHBX8TZWYjH+6AArFarlE0avXL6fXlbwH0xa0TiVv40XRSiWS1rfsKG1F8mFHOero+64OxkeJLZbtpEoDomV2X+ZIiOYtzpWORxbV6/gmdKifMSbSlVkDmnAJ+VjepK7ppZj4d7VVr9ufoZW3i+9IC7tIoHCXhTqVP/yAQ8DhEWKTSmIxdNcDwY1X3oaAA1aOErzIgDP5td79dM/nxSTlQqiTOdUZMgTSF3SmwcuO5gvTlETOjCdiIiyQCHtvS4pTkZhxKGhLOdtX+wqXRc8fbcstdwwMcXac6SHSs7Aki2l9naR9c+UT+0LYgdRmcrrL7PXqs7VNldGFAqr/E9ZngvQgj3Ne+ZDCQYZ3qSu4stlnLxH/9ITTWoh1qvSTMpe0jD5PgcWtH1V9QX+9/D97+erB9Y X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(39860400002)(366004)(376002)(136003)(396003)(8936002)(16576012)(5660300002)(4326008)(316002)(66946007)(6666004)(186003)(956004)(8676002)(38100700002)(26005)(83380400001)(36756003)(478600001)(2906002)(31686004)(6486002)(31696002)(55236004)(66556008)(66476007)(2616005)(53546011)(86362001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VkNsV2JtSFBGNUNGN2NmUUtrcXV2aCtTS2dNQVdhZnFESXUwVElwNldtbm9I?= =?utf-8?B?eTZOZDdmNkhhZjJPUDJQRXdsREpreE9NM3JHZXRiUzZzOG9ySnFaUHRaR21p?= =?utf-8?B?aWNoVGtrUXV4TG9EYzQ3N24xVmE0WEFwcmx1N05VVlg0c2lEbmFtMS9qZXVU?= =?utf-8?B?a1ExSzZnZGVtSlkrNkloTmM1dXloaGFNcmVkUWFtcTJEWE41bm1Gd3ZPNy9t?= =?utf-8?B?SGtIdjlXb0Y4L2t4TUVxamlXTGdYcHhlUGo2OTk1RXkrRmIyd0ZNKytNcFBZ?= =?utf-8?B?VUJrNmZ3OTQzanBkMG9YVGFWb1JocXdtZ0d2OUJVTWoxdFJuMklXZ2Fwc25Z?= =?utf-8?B?YnZZSTNqcWVOQjRIcDdld1I1OUM5ZzBqNjFZeTlxVGRNN0IvM1EzR0luTlpJ?= =?utf-8?B?UWV1SnZRWjdUVDdCUVh2VzB3UGxLa0ZtUTJNSm9HRmFCdnUyaVM3aFRXQ2E4?= =?utf-8?B?UEJrWENnK1I0OWsxc0gvcWRNa2QyQTRHcU1jVDJxZG9Ga0FCRm1uYjljWnp0?= =?utf-8?B?NGxLeUZiVHdSUGZ0UU9qeDRvZklldm4zTURIZFFlUXpsRFBZMGZZZkRhTGEz?= =?utf-8?B?YUMrZkErMThXOWpnbnlxM2tRQUF3RTVUZFVreFp3QlFYRmdYRUtyeWZzVU55?= =?utf-8?B?THE5QWl5TjRoRDJybmVBRzhCUnpoaDBRR0pTSGVJVndIRTFCcFVVTmlrT2VT?= =?utf-8?B?RytGR0pITHprTGVLaUwzdjBBT0Q5V0RCUUdTbW1EZU1Hb0kvNXArOXpTZHFW?= =?utf-8?B?MEhUMFZ2MHB5NmlaSjFkSGFjUnMrRjBNck1zaFo3VDg5cGxIMTl0Q1doQyto?= =?utf-8?B?dW1oSEtvU2t3bzRmbmhLejdUK2hxYXR1UjNzZjhKbVRJcUdDMW5nV2toNENV?= =?utf-8?B?UEt2U1QrS01pZGFmcTVCTXh5S1BKSFE5dUhYVGtHQ3RMQ3lMbjZ4WHloWGRq?= =?utf-8?B?aXFlWVBrL1FJRUtFSUJ0WXdjSW1NSkZocFhZVHUvZU9qcVo4UmJ1ZXdGZmxP?= =?utf-8?B?ZHI3RXYrSHRQcGhnbE5ZcjRSM2Vwa0ZFUm01U01uMlpscndFTkhnVHplTGhw?= =?utf-8?B?ZG1aeVlXRnRLVkZpd0d0Vllac0JxWFcxTzl0OFQrcHNuOGZFODJWM0srWC9B?= =?utf-8?B?NElhUlVIcmJxV25XNGNYekxOUzhJd09ZbktQZndWS2Y1WlZWMnNCMmJGem51?= =?utf-8?B?RUZHSHJyUTZ2YzN5anN3MUl0c3pjbldnVndzQ2ZqK2NIYmxIMDc5M29NM2Vv?= =?utf-8?B?b3lIQmQwVWRpbUw4NFNCY3BGYk5XQnpkWVNVR00rMll3d0RBQ1FtQ291SXd6?= =?utf-8?B?NStFbDVJeTdvWUNBWTM2Z3hDakRBQzAwVjcyWHlxc3B3cVA5UnpOR204Zk9S?= =?utf-8?B?WGxTVlZXZ2kvSnBOVnB2UHhxOTRNOUNHZEpna0hFZ1VFcVJUdE9iQVA5NndP?= =?utf-8?B?QkJqQmVDVzdmQVZKamI5d0xCVkxOd3B2U1l3QWlNK2kzbjcwRVBZc2FOdXha?= =?utf-8?B?WjRJQXNUUy9GZWJoM3N2VllkQ0pTR0I4ay9GOWlEZjU5UjlwL25Vdk82S28x?= =?utf-8?B?R1U4TFFObHpjUnF5dmpQVjN3bHJsT2VaZGRIYkNHVHhvZlYrUWRvdE9SdHlP?= =?utf-8?B?MzlCcU9tSGhuS0FDTExDQnhsMlJSSGxXM2ZFMUVuOHNwMFlvSS9qeXlEcm9B?= =?utf-8?B?MndrbGV0L1F5VGFJWlZ4Tkw0OFlpSm9YU0JJL0Vla2pIZXFscStRVzM0S2RL?= =?utf-8?Q?8p6YepYFOofhNmNFv258q0hcK8g3SiBdAiG/uHn?= X-MS-Exchange-CrossTenant-Network-Message-Id: f8e8915a-9a06-4e25-7728-08d9716289e2 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2021 18:17:08.6837 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: OD8QvT/kiWxR2XjqyiYJ7J1flEiq1/2bmjeGNYGj2Ni7HmZCEaZJou5Djnf5JhHhW0QaODNzRPMIVW7USo2V6REvY/S5emjvwjE4Vo/+JsI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB3670 X-OriginatorOrg: citrix.com On 03/09/2021 20:06, Daniel P. Smith wrote: > Instead of intermixing coding style changes with code changes as they > are come upon in this patch set, moving all coding style changes > into a single commit. The focus of coding style changes here are, > > - move trailing comments to line above > - ensuring line length does not exceed 80 chars > - ensuring proper indentation for 80 char wrapping > - covert u32 type statements to uint32_t > - remove space between closing and opening parens > - drop extern on function declarations > > Signed-off-by: Daniel P. Smith > --- > xen/include/xsm/dummy.h | 173 +++++++++----- > xen/include/xsm/xsm.h | 494 ++++++++++++++++++++++------------------ > xen/xsm/xsm_core.c | 4 +- > 3 files changed, 389 insertions(+), 282 deletions(-) > > diff --git a/xen/include/xsm/dummy.h b/xen/include/xsm/dummy.h > index 214b5408b1..deaf23035e 100644 > --- a/xen/include/xsm/dummy.h > +++ b/xen/include/xsm/dummy.h > @@ -69,8 +69,9 @@ void __xsm_action_mismatch_detected(void); > =20 > #endif /* CONFIG_XSM */ > =20 > -static always_inline int xsm_default_action( > - xsm_default_t action, struct domain *src, struct domain *target) > +static always_inline int xsm_default_action(xsm_default_t action, > + struct domain *src, > + struct domain *target) The old code is correct.=C2=A0 We have plenty of examples of this in Xen, a= nd I have been adding new ones when appropriate. It avoids squashing everything on the RHS and ballooning the line count to compensate.=C2=A0 (This isn't a particularly bad example, but we've had worse cases in the past). > { > switch ( action ) { > case XSM_HOOK: > @@ -99,12 +100,13 @@ static always_inline int xsm_default_action( > } > =20 > static XSM_INLINE void xsm_security_domaininfo(struct domain *d, > - struct xen_domctl_getdomaininfo *inf= o) > + struct xen_domctl_getdomaininfo *info) This doesn't match any styles I'm aware of.=C2=A0 Either struct domain on t= he new line, or the two structs vertically aligned. It more obviously highlights why squashing all parameters on the RHS is a bad move. > @@ -291,37 +307,41 @@ static XSM_INLINE void xsm_evtchn_close_post(struct= evtchn *chn) > return; > } > =20 > -static XSM_INLINE int xsm_evtchn_send(XSM_DEFAULT_ARG struct domain *d, = struct evtchn *chn) > +static XSM_INLINE int xsm_evtchn_send(XSM_DEFAULT_ARG struct domain *d, > + struct evtchn *chn) > { > XSM_ASSERT_ACTION(XSM_HOOK); > return xsm_default_action(action, d, NULL); > } > =20 > -static XSM_INLINE int xsm_evtchn_status(XSM_DEFAULT_ARG struct domain *d= , struct evtchn *chn) > +static XSM_INLINE int xsm_evtchn_status(XSM_DEFAULT_ARG struct domain *d= , > + struct evtchn *chn) > { > XSM_ASSERT_ACTION(XSM_TARGET); > return xsm_default_action(action, current->domain, d); > } > =20 > -static XSM_INLINE int xsm_evtchn_reset(XSM_DEFAULT_ARG struct domain *d1= , struct domain *d2) > +static XSM_INLINE int xsm_evtchn_reset(XSM_DEFAULT_ARG struct domain *d1= , > + struct domain *d2) > { > XSM_ASSERT_ACTION(XSM_TARGET); > return xsm_default_action(action, d1, d2); > } > =20 > -static XSM_INLINE int xsm_alloc_security_evtchns( > - struct evtchn chn[], unsigned int nr) > +static XSM_INLINE int xsm_alloc_security_evtchns(struct evtchn chn[], > + unsigned int nr) I maintain that this was correct before. > diff --git a/xen/include/xsm/xsm.h b/xen/include/xsm/xsm.h > index 9872bae502..8878281eae 100644 > --- a/xen/include/xsm/xsm.h > +++ b/xen/include/xsm/xsm.h > @@ -19,7 +19,7 @@ > #include > =20 > /* policy magic number (defined by XSM_MAGIC) */ > -typedef u32 xsm_magic_t; > +typedef uint32_t xsm_magic_t; > =20 > #ifdef CONFIG_XSM_FLASK > #define XSM_MAGIC 0xf97cff8c > @@ -31,158 +31,171 @@ typedef u32 xsm_magic_t; > * default actions of XSM hooks. They should be compiled out otherwise. > */ > enum xsm_default { > - XSM_HOOK, /* Guests can normally access the hypercall */ > - XSM_DM_PRIV, /* Device model can perform on its target domain */ > - XSM_TARGET, /* Can perform on self or your target domain */ > - XSM_PRIV, /* Privileged - normally restricted to dom0 */ > - XSM_XS_PRIV, /* Xenstore domain - can do some privileged operations= */ > - XSM_OTHER /* Something more complex */ > + /* Guests can normally access the hypercall */ > + XSM_HOOK, > + /* Device model can perform on its target domain */ > + XSM_DM_PRIV, > + /* Can perform on self or your target domain */ > + XSM_TARGET, > + /* Privileged - normally restricted to dom0 */ > + XSM_PRIV, > + /* Xenstore domain - can do some privileged operations */ > + XSM_XS_PRIV, > + /* Something more complex */ > + XSM_OTHER > }; Why?=C2=A0 This takes a table which was unambiguous to read, and makes it ambiguous at a glance.=C2=A0 You want either no change at all, or blank lin= es between comment/constant pairs so you don't need to read to either end to figure out how to parse the comments. ~Andrew From xen-devel-bounces@lists.xenproject.org Mon Sep 06 18:27:01 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Sep 2021 18:27:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180183.326722 (Exim 4.92) (envelope-from ) id 1mNJKb-00016Y-8Y; Mon, 06 Sep 2021 18:26:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180183.326722; Mon, 06 Sep 2021 18:26:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNJKb-00016R-5b; Mon, 06 Sep 2021 18:26:57 +0000 Received: by outflank-mailman (input) for mailman id 180183; Mon, 06 Sep 2021 18:26:56 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNJKa-00016H-7J; Mon, 06 Sep 2021 18:26:56 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNJKa-00027m-0y; Mon, 06 Sep 2021 18:26:56 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNJKZ-0005bA-NP; Mon, 06 Sep 2021 18:26:55 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mNJKZ-0004PX-Mt; Mon, 06 Sep 2021 18:26:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=lWdWNKadwgxsJNhNnduT+sZdtFoV9PHBnDpc+LCqw2k=; b=ajhqKq/NWQoPP/2xQukCuNGorP JvA/oNrbcKOz2eu6RcZrB+Iv5dwIdzXiprvVUpPS4nMjHHzUzJ0az9bpGOyEU9VLZvzEIUyzSDl+Q s54tVYptwUsqmG5BHBQyVKgeyIcu+2TsQKAlBXiIMz7gR7nxl0P5NpqV1tc83YBHbIsc=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 164862: all pass - PUSHED X-Osstest-Versions-This: ovmf=4473834e7d49c555eca81f96383a1d6d6f5f4bb2 X-Osstest-Versions-That: ovmf=cae735f61328d64e2e8991036707b9e78c0f5f63 From: osstest service owner Date: Mon, 06 Sep 2021 18:26:55 +0000 flight 164862 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/164862/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 4473834e7d49c555eca81f96383a1d6d6f5f4bb2 baseline version: ovmf cae735f61328d64e2e8991036707b9e78c0f5f63 Last test of basis 164674 2021-08-31 02:56:52 Z 6 days Failing since 164686 2021-09-01 03:03:43 Z 5 days 69 attempts Testing same since 164862 2021-09-06 15:10:03 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Anthony PERARD DunTan Gary Lin Hao A Wu Jim Fehlig Lin, Gary (HPS OE-Linux) Loo Tung Lun Loo, Tung Lun Mark Wilson Marvin H?user Michael Kubacki Rebecca Cran Wenxing Hou Wenyi Xie jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git cae735f613..4473834e7d 4473834e7d49c555eca81f96383a1d6d6f5f4bb2 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Mon Sep 06 18:31:22 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Sep 2021 18:31:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180190.326736 (Exim 4.92) (envelope-from ) id 1mNJOq-0002if-Rm; Mon, 06 Sep 2021 18:31:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180190.326736; Mon, 06 Sep 2021 18:31:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNJOq-0002iY-OS; Mon, 06 Sep 2021 18:31:20 +0000 Received: by outflank-mailman (input) for mailman id 180190; Mon, 06 Sep 2021 18:31:19 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNJOp-0002iS-B7 for xen-devel@lists.xenproject.org; Mon, 06 Sep 2021 18:31:19 +0000 Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id a00a8fe2-0f40-11ec-b0b5-12813bfff9fa; Mon, 06 Sep 2021 18:31:18 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a00a8fe2-0f40-11ec-b0b5-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1630953078; h=to:cc:references:from:subject:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=8cVMSSNJXfkVJJAEzk8daSd7j4AUn+dcJl/UkByNwW4=; b=ILqVKZtmchjMuajH10PxIaNDcKCvA5XhwLsP9aTGG421mzUYyXt6JkxI yV5EnYe7C28URzDQ4KoQnL9d3/LYrtuVhcSOscFRJiHM75QegNpmO3jLA OOdpyERrOOlqbcq2GRS3fz194kjf52DKFAeXcy2a1XUgUDEI2JANl6r9S s=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: f3l083uFU2Pk3PCfh8bZTRZZkEJr1TAghVd2Qds3PcS9aZydkc7hSGIgAfpN+ADcCypXcj6BzB hAFqmkCxg+NWgJaNECHrLiMa2Yy/0EMjzNBd6GAaC9MRXj2HNy9yudc7rXhg3T969k+REy6lCF e0T2PFBG8pDXi38jy3PKWfUftAj6P7em3DY8Bc2nDC9D3Zp85FZjrTIDS23BOHOfweNz/0mY6m 3XvGqfZ+V+xUIiwoM93KMMN88RlcZrnf65ryGZiN9gyErKQLkIE8iGYsEoE2hX/rHq3D114UaS CdXmpda65LNNHIyBLcJK3QBY X-SBRS: 5.1 X-MesageID: 52507244 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:6q6oeaMOWHKamMBcT1P155DYdb4zR+YMi2TDiHoedfUFSKOlfp 6V8MjztSWVtN4QMEtQ/exoS5PwP080kqQFnrX5XI3SIDUO3VHIEGgM1/qY/9SNIVyZygcZ79 YcT0EcMqyCMbEZt7eD3ODQKb9Jq7PrgcPY55at854ud3AMV0gJ1XYINu/xKDwOeOApP+tdKH PR3Ls8m9L2Ek5nH/hTS0N1E9TrlpnurtbLcBQGDxko5E2nii6p0qfzF1y90g0FWz1C7L8++S yd+jaJqJmLgrWe8FvxxmXT55NZlJ/IzcZCPtWFjowwJi/3ggilSYx9U/mpvSwzosuo9FE2+e O87CsIDoBW0Tf8b2u1qRzi103J1ysv0WbrzRuijX7qsaXCNXkHIvsEobgcXgrS6kImst05+r lMxXilu51eCg6FtDjh5vDTPisa1XackD4Hq6o+nnZfWYwRZPt6tooE5n5YF58GAWbT9J0nKu 9zF8vRjcwmMW9yV0qp+1WH/ebcGkjaRny9Mw8/U42uonlrdUlCvgklLJd1pAZHyHo/I6M0r9 gsfJ4YzY2mdfVmGZ6VMt1xCPdfOla9NC4kD1jiVmgPNJt3cU4l+KSHrYnc2omRCeo1Jd0J6c z8bG8= X-IronPort-AV: E=Sophos;i="5.85,273,1624334400"; d="scan'208";a="52507244" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fwa9ylUfSuABZrSS4VpoSNl8yzUqMZFvQLdcnji+e7Z4yYxOTjomuz+gLD8XwjBZUYFLlw6DCM49OWNf7IeIciCrNG7H0YAGHM/5leksFZ4FtmzTiO+ChYA0gRty1tZODKDjcNIHC/LAe9HiqfTxrfnK4EH8ReqSJf0oVurJCDWHRPh9CxPyuvChpZhc74MtAN/RDSQfJPS09HKncGBHM6JXK867EOWFzH3YjwouQKM/5klr66W4+QSKnqVYDmy5Kkv1ETusf7IZJJpJLt07PF0DFFLOL+weG+TRZCE78CM087X5gPgYUdXALNHXsDp7LFbouVccxicmtARACx4Cbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=UygBNLCUMU/3ZqHyK+ayd1mRTwySTUAf+mwn1mECLiE=; b=CSSVsWFQk6N3WwQGZemL4ItwcNOfTYDoPBsq8CK/wiArGQ9xZP85j7XN1QHeo+JkN5TdfVJFE3CWkiBRpNMYPRrH4c8uD9GkLJMpeQmPhNw1E3Rl/rz4pukuXXjfeoIwYbsxHBDB1I/oHfk1z2k2+j3xzHXtPHv0g+8GHLfBqotOlX35tVMVBb8ZwYb714m6TwFJsnr4MGT8Lid0oVVf5GnTX/h/zv4UCO6vvORQoG4yoCNiSz8HdN1bE8ZRWtsFkCEqtckbcNeF4MWWvqn4zsPtM464XYs/1ViQEvSboW7OCbLAAL/3G0JOxIesbcIncyMP9gbxeGSrfkNqsZSsFQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UygBNLCUMU/3ZqHyK+ayd1mRTwySTUAf+mwn1mECLiE=; b=H1L7UWXsM6V4y6upF2osuLaLzEZVcTuD4eyaO0jpF7LE3BwkjyErma9wJiGwKyVJUD3ZVMkvKgPGkRH9Q9FtncARmnWxb2PZQHpgQ6M/H1xKfNzulvc7RV8DEzJLm1jkSZL5wYVKk7GB7TN9mC6t8qTRO809NvTnu8fvd900Odk= To: "Daniel P. Smith" , CC: Daniel De Graaf References: <20210903190629.11917-1-dpsmith@apertussolutions.com> <20210903190629.11917-6-dpsmith@apertussolutions.com> From: Andrew Cooper Subject: Re: [PATCH v4 05/11] xsm: refactor xsm_ops handling Message-ID: <6924c3ea-de14-60e5-d3dc-eaff6c228f1c@citrix.com> Date: Mon, 6 Sep 2021 19:31:06 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 In-Reply-To: <20210903190629.11917-6-dpsmith@apertussolutions.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: en-GB X-ClientProxiedBy: LO2P265CA0189.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a::33) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2dba57e0-6047-412d-26ff-08d971648152 X-MS-TrafficTypeDiagnostic: BYAPR03MB3670: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dT1eH4rIP3aS86VlDkv2x5BJ60C/cH1bVZw+toenIapafmdyTK5v/m6cil3uDwYU0XW7v+Jpms3TWwCKnc0j2G9pJUQt+EMgPV8xwEnKNcEJP2xK8x6IS51rAIxH2gAP1bH9sado7MBTUFatQs9v2PhmOfe/dWwEnqsyH/EpOAs7WO0OIl4M5/7IAbiucc1tOZBxA/pTsw/Jx/NpSaHs0o0CSEgINk3Gu2EP8yOvzCOYF7CZEoRg+gGNbGgdWI3JW2jA+HPrcnlaHi+nnk5vgHbQhWjN3n9ldlA18j4cRUFv+s/eWpQqHUCuDSjUtexJ8/4YskW/OsrKQbzC3WQbiWtj6pYOs4/M+o4teEQuc/L23N+ICVdktLtXZSus5lM3KgvwVp45lr9MUObjLFl/KoCglQ9CAxSGX/geGeAVrQmssUN5FyNxCHAyQ0wFfaLO6JhSbEKKTZdTes/rxQYdqjfosG75cI6UgbR+Ewt2HqM7MoRzDcbaKtG0PfB6no+rcyv+YPWlTjCyGXJfRj0H5ji+UxcWMJqYk48KDVcTAZzk5N3E94U4jIse5Yfn7AxiH5hIiSCG3HzgZkLI1bp1Sw5NI1/Lh5COxnO++IT8dMB8P/pyhIQv1dgQ9TkZSIDcoSFqguV/fe3x++Nnc5jtIGRWUUaPxot1vau5eiTPmuk5PV4o+C9iFB1fANsuGuUR1tURv5JrazOLsvOmDg2BafvmUulwd42Kl2jIyjUG2p8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(396003)(136003)(366004)(39860400002)(346002)(6486002)(55236004)(31696002)(86362001)(53546011)(2616005)(66556008)(66476007)(66946007)(8676002)(6666004)(186003)(956004)(316002)(16576012)(5660300002)(4326008)(8936002)(478600001)(2906002)(31686004)(83380400001)(38100700002)(26005)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MUV0UnRWcVovMWNsalFzQnB3MWhlZ2J5Rlc1cWdSSzBxZWU0aHJjUTBoVFAr?= =?utf-8?B?d21SVjIydXk1QUVWdmgrbGdEYzlDOGROeTJsNDhieXQ5VlgyTnAyRWdsNTJw?= =?utf-8?B?S1owTHRZRmxyMGRlK1dVR2hLM0F2SllGUG9ITDJZZURhaFVJVXo3eVpIOTNs?= =?utf-8?B?c1lsM1pJTUFhQStWZGNGWVRsV2crS1ZkcGJQTUREZ05HeHNMTzNlbUxTd2da?= =?utf-8?B?N1hpaFhPS2tuMURrU1dNMmxpZHVYeWsrajRVZG5KamtzSlNnZmc0SU1mL0tZ?= =?utf-8?B?TzdkaFlpcmFyK2FKa0pXdkpuY2Y2dThnUElwQy9GQjVNQ3pqSS8vR3cwTXVu?= =?utf-8?B?R1RBVFRjTTJqWVQrUlpJbWNVc25hMUpGN0Q4c1lMbVkreUpNZnV3YXNBYnhw?= =?utf-8?B?cy9SeTByb2RHR1VEUUViNGtoRHdyR040SnRxQkRwOTVHNW04SXBnS1N0T0xU?= =?utf-8?B?dDZqMjIzbm5ZSmdDNTdPTGF3S3pWd0JVcXNRS2ZhemNyOVNwdVZDMzlqcGpx?= =?utf-8?B?SE5XM2FId1I5K1BuU0NCZDdlTXhnbVRQS08rUFFJamdkVmR1ckZmNjZkMUlp?= =?utf-8?B?bnBpRm1aWmg2SWJUTUxKb1h1OWc0aUcrY09lQnhLUXlrcjBGRjJzNy9VN0o3?= =?utf-8?B?a1o4SjJ4MDVNS0luR3R2QmtOYlBLeTJDSFV3MU5UQjkyZFB5K1JUVWRMa2Rv?= =?utf-8?B?OUhqTU04VmpYQ05ub0M3aklFaGtYQ01RTUh4c3dpeURydUhxaHpBVkJGVEY0?= =?utf-8?B?eEwvSTBrajQ3dkozcUpvQ1BKQXF1TnBhV3NKVXFkWlZCSTZCbDlCNUtDMTB6?= =?utf-8?B?V2lOc3EwWVRkYzNzZHhIbEhnZ3g1WGNiQnVSMjJGcVBKNzVWS01xaHNWb0xh?= =?utf-8?B?b24rRE5XZTJuZnhlNmJKNEgvMTExODg5aXB1RDBaWVczbFJPREFGcHVwcnIy?= =?utf-8?B?NTVnR2pZeXZyN0xPWWF1andkaGdadEFpSmNRcGlBREVtWHBTYm5jTWk1d3Vk?= =?utf-8?B?bEdHK29DOEcrdEdJdy9ZRS91dk0vQ3pkUXBxQm1yWjFPWVZ5N2lqTlFlKzk1?= =?utf-8?B?ZENsWnhSNFRveDgvaU5DeXpwL3p2ZnRLVE9TL0NTcDV5aHVNY2x5SCtOMmRV?= =?utf-8?B?NVBoMjIrUFRNNDdiZzlSWWJwcEpFQXhVYi9VNjZUcE82OVhnb29ERmJleG53?= =?utf-8?B?Wnloc0JVLy9GVld4SDJTOEprNThVWDByQXgxbDQ1UUxSSGkwRmRCNkJ2M0c1?= =?utf-8?B?dTNsS1RGUEM4TkQrbzBpQlpZYnQrRmRJaVFYUERidGloRkl0TkRTdUFoTkFi?= =?utf-8?B?SXhkN0dXNkVzTjFldlhBeTlkWXgxd0FaM3hFZGY2MzNFSmE2U0ZmZlhSSUl4?= =?utf-8?B?RHNuU0hUL0ZrY21wUEhvYThhYXhuWjU0K29PYmFCcDgrY3orazNEQ2N2QWpo?= =?utf-8?B?aEZoQVJaa3p2V0MybklRbmJ5em5xWGxjaVVHTXh3MVYvTmlRMmU2ckJuU2FK?= =?utf-8?B?ajdWYmtaYk1yQllJaktJR1VhTm9LM29NNDExYXBMbmw5SUpwVjc4QitCUWhI?= =?utf-8?B?Uko3aXZrOXUxM04wd2RQVFR1Z3dTL0VNSEJGMHlkM2VJN01ieWFkMllKb0Rj?= =?utf-8?B?M1FxZGs1TnQyeXEyNm0xV2JRU3VWaVFLR3pGbjkzM0MvVFBXeS9xd1ZxRTJI?= =?utf-8?B?N3JiTm9OUzk5eUVqYmtIaFVJUXYxUVBWdXlLRkE4UENWV3lVZUlFSHlNSCtU?= =?utf-8?Q?PyNVQupjJsp1upH/dTCmWPxOppur4HzznyqVfEX?= X-MS-Exchange-CrossTenant-Network-Message-Id: 2dba57e0-6047-412d-26ff-08d971648152 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2021 18:31:13.3017 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 868MW9CBky2jNc+ruARLvLc5apMjSc72Ah+7sGhQ/frFMy1I92p9jUuAEe1gEtJaSLAnGnBGYF3YeiQp0x/bj/JBREdngnVqFwWQKS63/RA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB3670 X-OriginatorOrg: citrix.com On 03/09/2021 20:06, Daniel P. Smith wrote: > This renames the `struct xsm_operations` to the shorter `struct xsm_ops` = and > converts the global xsm_ops from being a pointer to an explicit instance.= As > part of this conversion, it reworks the XSM modules init function to retu= rn > their xsm_ops struct which is copied in to the global xsm_ops instance. > > Signed-off-by: Daniel P. Smith Acked-by: Andrew Cooper However, some suggestions... > diff --git a/xen/xsm/xsm_core.c b/xen/xsm/xsm_core.c > index 55483292c5..859af3fe9a 100644 > --- a/xen/xsm/xsm_core.c > +++ b/xen/xsm/xsm_core.c > @@ -28,9 +28,17 @@ > #include > #endif > =20 > -#define XSM_FRAMEWORK_VERSION "1.0.0" > +#define XSM_FRAMEWORK_VERSION "1.0.1" > =20 > -struct xsm_operations *xsm_ops; > +struct xsm_ops __read_mostly xsm_ops; > + > +enum xsm_ops_state { > + XSM_OPS_UNREGISTERED, > + XSM_OPS_REG_FAILED, > + XSM_OPS_REGISTERED, > +}; > + > +static enum xsm_ops_state xsm_ops_registered =3D XSM_OPS_UNREGISTERED; __read_mostly, or can this be __initdata ? > @@ -87,25 +88,35 @@ static int __init xsm_core_init(const void *policy_bu= ffer, size_t policy_size) > } > #endif > =20 > - if ( verify(&dummy_xsm_ops) ) > + if ( xsm_ops_registered !=3D XSM_OPS_UNREGISTERED ) > { > - printk(XENLOG_ERR "Could not verify dummy_xsm_ops structure\n"); > + printk(XENLOG_ERR > + "Could not init XSM, xsm_ops register already attempted\n= "); > return -EIO; > } > =20 > - xsm_ops =3D &dummy_xsm_ops; > - > switch ( xsm_bootparam ) > { > case XSM_BOOTPARAM_DUMMY: > + xsm_ops_registered =3D XSM_OPS_REGISTERED; > break; > =20 > case XSM_BOOTPARAM_FLASK: > - flask_init(policy_buffer, policy_size); > + ops =3D flask_init(policy_buffer, policy_size); > + if ( ops ) > + { > + xsm_ops_registered =3D XSM_OPS_REGISTERED; > + xsm_ops =3D *ops; > + } > break; > =20 > case XSM_BOOTPARAM_SILO: > - silo_init(); > + ops =3D silo_init(); > + if ( ops ) > + { > + xsm_ops_registered =3D XSM_OPS_REGISTERED; > + xsm_ops =3D *ops; > + } This if ( ops ) block can be deduplicated by moving after the switch() statement.=C2=A0 It's going to be common to all everything except dummy. ~Andrew From xen-devel-bounces@lists.xenproject.org Mon Sep 06 18:48:15 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Sep 2021 18:48:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180198.326747 (Exim 4.92) (envelope-from ) id 1mNJez-0004Xk-Am; Mon, 06 Sep 2021 18:48:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180198.326747; Mon, 06 Sep 2021 18:48:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNJez-0004Xd-7U; Mon, 06 Sep 2021 18:48:01 +0000 Received: by outflank-mailman (input) for mailman id 180198; Mon, 06 Sep 2021 18:48:00 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNJey-0004XX-3S for xen-devel@lists.xenproject.org; Mon, 06 Sep 2021 18:48:00 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id f40e3060-0f42-11ec-b0b5-12813bfff9fa; Mon, 06 Sep 2021 18:47:58 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f40e3060-0f42-11ec-b0b5-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1630954077; h=to:cc:references:from:subject:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=r6dJB/O4rfn/f1vnVoxveZOWS+xUToPTgwygMcGwfpI=; b=Rsjv8lehegNjo5qlw5lNcflDBVWAr7HOW+jQRK8K6VmmMoR6tzvMUSRS Ua/9cl6ZIlqcKooSGPBqECPnzOs8G0F96YnwB+xcwb0nqrRyRP2riLqjJ 99n6CfJ32ccEpjMmLMIuwP3n7k6ub/qifQvXOTNE8dj6oN3KXUR+OdwmQ k=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: AJXT4rlBSSGvZOOwuOBvuo4L/XXCjH0iB/CLg+0YhgkIHdyZY3o1gHnF7eu8qJCMNB/i9+9TNi HWUy60jzdt5mqsHpu+gAK6OloYu9Wt4aok1lFoZq6xmkU+v6ueyV/1V4UyAyCYloEpQfh3BHKj V9VQGid+3UGlX02V2svaAw1Wty4JfBZVXUXHQ88m6kcKWgxhBtCeWf0nZnXQeSoVneDG14yZmf TqRWTfYXEqjO5jt31PaKcxoxcBgDc4CzDE7pCJjEPYaRzmxyMQRcXYXo7hEdKmsLm3wHi+yGdb zHyNJK98xOp4tw/N/Sp/wbx3 X-SBRS: 5.1 X-MesageID: 52092572 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:krThmqrv7lTshhETEpBGsAQaV5u7L9V00zEX/kB9WHVpm5Oj+P xGzc526farslsssREb+OxpOMG7MBbhHO1OkPYs1NCZLXXbUQqTXfxfBO7ZrQEIdBeOjtK1uZ 0QFJSWTeeAd2SS7vyKkDVQcexQueVvmZrA7Yy1rwYPPHJXguNbnmNE426gYzxLrWJ9dPwE/f Snl6h6TnabCA8qhpPRPAh6YwGPnayHqLvWJTo9QzI34giHij2lrJb8Dhijxx8bFxdC260r/2 TpmxHwovzLiYD19jbsk0voq7hGktrozdVOQOSKl8guMz3pziKlfp5oVbGutC085Muv9FEput /RpApIBbU+11rhOkWO5Tf90Qjp1zgjr1fk1F+jmHPm5ff0QTorYvAxzb5xQ1/80Q4Nrdt82K VE0yayrJxMFy7Nmyz7+pzhSwxqvlDcmwtjrccjy1hkFacOYr5YqoISuGlPFo0bIS784Ic7VM FzEcDn4upMe1/yVQGZgoBW+q3vYp0PJGbCfqBb0fbllwS+3UoJgXfw/fZv3Uvpr/kGOt55D+ etCNUgqFgBdL5RUUtHPpZ1fSKAMB26ffv9ChPhHb3ZLtByB5vske+93Fxn3pDhRHQ3pKFC76 gpFmko7FIPRw== X-IronPort-AV: E=Sophos;i="5.85,273,1624334400"; d="scan'208";a="52092572" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CBKZzdLwZtsB+VXBUp2mxSzyT6moFjPoWyL4WCfVs0n2ntpJe1w9x+Zx8bmXfCUasUiIPXnDqd/ECk3wsYoF4t5n9o/JGxXObv6ri+b/+7DcXaZscSFyyNGNsVjN1admH4bG1n5IZHIbY83Xz2SL3pN4H6J1IYABTTAq/95NSFuqOnsjv/ZSaPWJylLQcMFN/QZPNltDywJ4TBPYxrnucVpADbCBjdUoSwPKzrjdeUhdEj9tKCagi07dLIlrryAZ89EunokQwW3EBz7EaKTDU7Rlpp73dyrc8S3nQuy9F9fOjUsqw/Mbh/IGdMmhP++ho0SZa7UaqGT5BgOV1QLWsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=e4AQjytToAgMKCwoiUEbPXNarq36A5NlNm1hQZ3oCF4=; b=kaEut+8XyJVY9pgOb4iHnBOwttBa0umwAIzZ0SzgRV4SNdVU4xe+Ilec6Fc1rh/wVISRSXn4anfxrdtB0kRpwbqRD0OUZp31wyXt+DlQJXPfwV6IGXKRhwoJLAATlNJWf2dHLa/bWJmr2SiOB/ODT6s42fwnoFHXbO7ZQAVQ0Iz5ggNVU5TUD1UxfHSVXQtdhStx73WXAFE72N/DudbQZK4N0h1aUmAqe6CdVWHoSG/4uOBkUbtMFNj6U+YM6HnsiRQzIQzY1QYnZqcsSfSQZdNLRo2IQhx2mQyfVoKVsQs2ZQHUHcj0o3hDGSJ3HWriiOwSzsv3C8Hssoy6WjMpxQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=e4AQjytToAgMKCwoiUEbPXNarq36A5NlNm1hQZ3oCF4=; b=ZHGKSmrC8P2b22k35rEseaVQq0SD0aukCRAqHAxLz1LZOsdenGFnWWttGeSWUkTu6ZKPvSqnWzD17ci6q296hbAjWup3gTHCX170PQTjWDnUO5EclDXCjxKQ8YSKEpemzYTc7bB5iWwVVUMnAUqzAPXXNye3R/7Vl7sl3LVTL4E= To: "Daniel P. Smith" , CC: Daniel De Graaf References: <20210903190629.11917-1-dpsmith@apertussolutions.com> <20210903190629.11917-8-dpsmith@apertussolutions.com> From: Andrew Cooper Subject: Re: [PATCH v4 07/11] xsm: decouple xsm header inclusion selection Message-ID: <17155620-d091-3205-6af0-65e19dfa1bfb@citrix.com> Date: Mon, 6 Sep 2021 19:47:43 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 In-Reply-To: <20210903190629.11917-8-dpsmith@apertussolutions.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: en-GB X-ClientProxiedBy: LO4P123CA0387.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18f::14) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 63831b78-91ee-4d2c-4469-08d97166d309 X-MS-TrafficTypeDiagnostic: BYAPR03MB4486: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: f9UTy/Dwkc1ycStsa0hSSBSjyk6nDxfVvcaJj2+Ib/xKnvnm9mIOTWRiOmFVjWAj7iFqOKbHEhzDfWVaqOP5EDdEo1QDmSglp3g5T/89TEFf59iGWo7btKfYjIluc49lQbXHgLPnd6+k2MC9HiT4FhgOgeYV7vozUDmYdVJUR19BntOPkyel2RxiC+S0jt6ImspW/nQI1eRpWzpgK8sFxYQao6ngf1ysLZFFV6ff0HUtHAhCtGqOYAIQMXaTH5/oNJsQ5vZD6CwjQMkxJRv4gE+DyulIo+3Ghrm+BB6FBYtaK/QMNTvKKUVyUBR4D9WX7x4zYj4TUUF93RODMcr1+F/LA2ykj0i4KQBzRrknML0o9h79eVu73ulnIqoxfZy7BxTGdPiMcIR/LQeidomd7FS0A/Dft5Tuzqu3O3Zu1k6MvurqQ+P8ReO9aZQ+1iihrqHkmvnlrIuug8JPRHUnEEUQBFrKOKrsSN7xTlBuu5kjezHE3o9mUTc6bkyHWBhfed/yirYwMblX1xynBnqZyc+fVID3W6G9Wxh7uTl4mHNzsEBG7veii9Ta0u07P6HF+CO87kmreW4Z0wnmdHGvxwrTnJp0uEPwks2bmDVaEldpmrFVl22HHfttgnuqGXmjDcm3ukecAuHgdKGo3AFGABbGXj1WgTiXyRxRTKLCqgEcakyJB3qyF2ixv5RY0hqpAROo/QUjGrFL1U8CrdFqEuNWJEbPQdLO2+c1uudLyUWZ44lZ6evLE07LI3hqZzhX6EUuE5ChZMRgQ2K5BqZAhw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(136003)(376002)(366004)(346002)(39860400002)(396003)(36756003)(31696002)(66556008)(8676002)(66476007)(86362001)(2906002)(38100700002)(2616005)(956004)(6486002)(26005)(55236004)(478600001)(31686004)(4326008)(6666004)(53546011)(83380400001)(8936002)(316002)(16576012)(5660300002)(66946007)(186003)(2004002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TXBYYlBZR21mY0ZIMk11Z04vaUk0ZVNZbHd2d3BIUEF6WWxBVXVUNDk4SzJO?= =?utf-8?B?V2xtQU03QlFaMnY5dnZIWUxlZFRGZHJWVnJ1WGk1UWVDbFRKRENSKzJmeUF2?= =?utf-8?B?Z25ueWRKZjRnWnl4Y1VTYUJ3eHVBZmRqbUpBUmhvYTU3ZmJtT1cyL1R6RnhB?= =?utf-8?B?UDdwbWZtdys2eWxXNjdsaTF6cVlZYVUxU2tja3pJM1BMZWlycGxHc0FCSGFX?= =?utf-8?B?NU9CanZGMmgrcitkdUovVS8rdE1QVUo3Y3VOekZ6TkhuM1FWZ09uNERpVmw4?= =?utf-8?B?UDgzS2FFRzRtcUxQekdpYStZVW5GZk02VDVtcWVMY28yL05BL1JiVTNaMFJw?= =?utf-8?B?UDljT3RCZ1FMZXNhOWxNSk0xT0ROd2ZHT3RVWElyUU1UOGhaeldVd1NCblRt?= =?utf-8?B?WElEdm5qeEg3bUlDOW0za3BnSEoxRGNiSnU4YzBMb0JVRGhKaFV0U1JXL3Ix?= =?utf-8?B?K3pLMkpSMkYzMmE3TmVYY3ZaVnFIL0p1SU0xZXVkV05rUGtJODFyUlVMSU16?= =?utf-8?B?NU5ZYWpQaXcxcWZEK0EvVXJtZ1JrWkQydnhQbnZyVW0zR3lOZFRYSjUvNmpN?= =?utf-8?B?RFJIQ0hkVDc4a2xyYSt2cGx1OVdsUzNXU3cya1B1ODNaMDZIcldhVlJZczVB?= =?utf-8?B?Q043WHgvMjhkZ3AyYUZKSHFmNWRMSjBDaXhtMmJXWHpIV3diOTFWaysrV2xa?= =?utf-8?B?K2ozNGYzUXE4THkyQkNPaC9IRjhQdVRoTXNhZWp4aERrYm4yeEVudGxMUUM1?= =?utf-8?B?em5ERWV3OHlDK0NTQmk1SEJTRmpQdTN4bVI4aHBKaXhxS3FvQ3doWlBtVGYr?= =?utf-8?B?UFR2a1BXdEdJb3BjZWQxcmdxTHNsSWlneDYvMFpsdndPMkd4N0dyL2VpcUlU?= =?utf-8?B?cG9VWWVubkh4ak9Md21QaHRWeWpLQTgvNjRJdjlUOUF1Nm5HdUoxc1lRRFhU?= =?utf-8?B?eHpxNEtGeUE2Ui94TWxTbTNRNGRDdWY0N0FReXFJbDBZNlVNV0MzcElYa2dK?= =?utf-8?B?TFlYeFR3Z3I2UFhpcGpYZWkzamttQUdvWXZYUXYyVUVuUDY4M0VkRGxLWVdW?= =?utf-8?B?WmhOS054ckRMSytxR3VWOWNvaGhicHp3eFZRYXplRzFZY2thSE5OVFgreEh3?= =?utf-8?B?M2FDUDRybHByRks2aFM4emhleS81UnV5Vk8rZi9sZlZVWHl3UXRhb0NidDdK?= =?utf-8?B?Z0dSbjdTeS9iSXBYZjlQTEJxTWZTdVZQUEw4Zkp0dHllQ25JUi9RYkgyTWVy?= =?utf-8?B?SU8zM21Ia3RQeitHSGFqLys1WjFPQVlxN0dpdzd3VGZ2UEpkdW5pWDlSZ25I?= =?utf-8?B?UlhxSTJ6RnFyUXRIaGZDcEQwQkU3N3RpWDhqV0YyYTZuRGZ6eU9kaFBCVUVq?= =?utf-8?B?NUVGWlB0S3JMTVU5cTZUOGlwTE5DWXk0S2diMjBjL3FqcHRnUmdMSmZFVEFD?= =?utf-8?B?VGFLZjgxZDNWWVNYKzU3RkhXOTZheG1uL01lWjRGRUlKL2pCa3RIcVZzb3pu?= =?utf-8?B?YXJId0hWaUhueHo4cld0UVJ0Y2J0UTlyQitKZjF3NCt1clZkQ2JvK0YzOVBI?= =?utf-8?B?c28zVk5TVUVNYnNBd1Q3SWpKN3lZczJJb01tNlc3VDNscXJzQm5WT1ZZb3Fv?= =?utf-8?B?RVhNcW5HbVpTRHVhb0VWSDQvSExnelhJdCszWE96cnE5RjVoK29hTnBlL2kx?= =?utf-8?B?ZTM0T2hJSDl6R0p3NVdIU3hSK25LcG5JOUo4QmJqcVBhZndQT2lPbzFIaUF2?= =?utf-8?Q?AxC7FWQIjPZW5IhY7ZZI+ghemaCPZ9YNxy6fCEp?= X-MS-Exchange-CrossTenant-Network-Message-Id: 63831b78-91ee-4d2c-4469-08d97166d309 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2021 18:47:49.2757 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6Ee5h9aRE/tlvyyacY8LXzVAV3io5aOiAho/akPkCD4X9bQo2veBzcMdQd2zHb1eZG7s6KAjFI/pHgZq3kM5EIQqhs/HlP6rWrtMTSrkqWU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB4486 X-OriginatorOrg: citrix.com On 03/09/2021 20:06, Daniel P. Smith wrote: > diff --git a/xen/include/xsm/xsm-core.h b/xen/include/xsm/xsm-core.h > new file mode 100644 > index 0000000000..4555e111dc > --- /dev/null > +++ b/xen/include/xsm/xsm-core.h > @@ -0,0 +1,274 @@ > +/* > + * This file contains the XSM hook definitions for Xen. > + * > + * This work is based on the LSM implementation in Linux 2.6.13.4. > + * > + * Author: George Coker, > + * > + * Contributors: Michael LeMay, > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License version 2, > + * as published by the Free Software Foundation. > + */ > + > +#ifndef __XSM_CORE_H__ > +#define __XSM_CORE_H__ > + > +#include > +#include > + > +/* policy magic number (defined by XSM_MAGIC) */ > +typedef uint32_t xsm_magic_t; > + > +#ifdef CONFIG_XSM_FLASK > +#define XSM_MAGIC 0xf97cff8c > +#else > +#define XSM_MAGIC 0x0 > +#endif Eww.=C2=A0 I know you're only moving code, but this construct is broken (right from XSM's introduction in c/s d046f361dc937), and creates a fairly-severe bug. It causes xsm_multiboot_policy_init() to malfunction and accept a module which starts with 4 zeroes, rather than the flask magic number.=C2=A0 The o= ne caller is suitably guarded so this is only a latent bug right now, but I don't think we could credibly security support the code without this being fixed.=C2=A0 (Again - fine to add to the todo list.=C2=A0 I know ther= e's loads to do) > + > +/* These annotations are used by callers and in dummy.h to document the > + * default actions of XSM hooks. They should be compiled out otherwise. > + */ For the coding style patch, this should be /* =C2=A0* These ... > +#ifdef CONFIG_XSM > + > +#ifdef CONFIG_MULTIBOOT > +int xsm_multiboot_init(unsigned long *module_map, > + const multiboot_info_t *mbi); > +int xsm_multiboot_policy_init(unsigned long *module_map, > + const multiboot_info_t *mbi, > + void **policy_buffer, > + size_t *policy_size); > +#endif > + > +#ifdef CONFIG_HAS_DEVICE_TREE > +/* > + * Initialize XSM > + * > + * On success, return 1 if using SILO mode else 0. > + */ > +int xsm_dt_init(void); > +int xsm_dt_policy_init(void **policy_buffer, size_t *policy_size); > +bool has_xsm_magic(paddr_t); > +#endif > + > +#ifdef CONFIG_XSM_FLASK > +const struct xsm_ops *flask_init(const void *policy_buffer, > + size_t policy_size); > +#else > +static inline const struct xsm_ops *flask_init(const void *policy_buffer= , > + size_t policy_size) > +{ > + return NULL; > +} > +#endif > + > +#ifdef CONFIG_XSM_SILO > +const struct xsm_ops *silo_init(void); > +#else > +static const inline struct xsm_ops *silo_init(void) > +{ > + return NULL; > +} > +#endif > + > +#else /* CONFIG_XSM */ > + > +#ifdef CONFIG_MULTIBOOT > +static inline int xsm_multiboot_init(unsigned long *module_map, > + const multiboot_info_t *mbi) > +{ > + return 0; > +} > +#endif > + > +#ifdef CONFIG_HAS_DEVICE_TREE > +static inline int xsm_dt_init(void) > +{ > + return 0; > +} > + > +static inline bool has_xsm_magic(paddr_t start) > +{ > + return false; > +} > +#endif /* CONFIG_HAS_DEVICE_TREE */ Shouldn't this be an #ifndef CONFIG_HAS_DEVICE_TREE ? And the answer is no because of the #else /* CONFIG_XSM */ higher up, but it is incredibly deceptive to read. I think this logic would be far easier to follow as: #if IS_ENABLED(CONFIG_XSM) && IS_ENABLED(CONFIG_MULTIBOOT) ... #else ... #endif etc. rather than having two separate #ifdef CONFIG_MULTIBOOT blocks doing opposite things due to the position of intermixed #ifdef CONFIG_XSM. ~Andrew From xen-devel-bounces@lists.xenproject.org Mon Sep 06 18:55:24 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Sep 2021 18:55:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180204.326758 (Exim 4.92) (envelope-from ) id 1mNJm5-0006A4-3p; Mon, 06 Sep 2021 18:55:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180204.326758; Mon, 06 Sep 2021 18:55:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNJm5-00069x-0T; Mon, 06 Sep 2021 18:55:21 +0000 Received: by outflank-mailman (input) for mailman id 180204; Mon, 06 Sep 2021 18:55:19 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNJm3-00069r-HC for xen-devel@lists.xenproject.org; Mon, 06 Sep 2021 18:55:19 +0000 Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id fa1f1ec8-0f43-11ec-b0b5-12813bfff9fa; Mon, 06 Sep 2021 18:55:18 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fa1f1ec8-0f43-11ec-b0b5-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1630954517; h=to:cc:references:from:subject:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=78kqkbp/8KkJXYvxGOcNoRYv+d1QDAIOBRdg4h03mHw=; b=eqdXULvlQB3cHWYKjKYra+flJsOVPRhWc0x3VzmighZJd7JtMzofjUqQ 8nX4dl93fO3GtAUMZWIe9IajfJpyKvuO1P70QIdn0WtpPquaKI5mFQlrc nucfuQA06dAF8P4qX6MAhos3832m+gKJqd6YRC2ScP1+9bXgQiA7bDAUS Q=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: o6T8GI+uOEzF3SSOpElMJ/udZGNIFI8HyePgw/f/YFZSp2oJpJpjlynhgU6txRtrYymqVHrqzs 214jrw+V9CyTzY/9FfskEQEqwtXv/pUZV6uOLO2685M3Jm3wfF7qJy1rwU4DDvORR2LBCrBNQT NTblttk4KAwgMcqGMC4HZJKXE1evl+YjzlUevggSPOSZMx7cERQ/ZIqbhYUqasuZinnzDILhEc TKDfscrenrBt5DsVhBS92a7pWwom1MaB6g8qv0nLrMdNqah8p8YM1InxxEqHKB1peFtxnaDC/s mZ6UBolSxBL4l42CS9deU+Kn X-SBRS: 5.1 X-MesageID: 52507810 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:WBgp6KuWThjwJeXCEp1b6VOF7skC5oMji2hC6mlwRA09TyXGra +TdaUguSMc1gx9ZJhBo7G90KnpewK4yXcH2/hvAV7EZnibhILIFvAe0WKG+VPd8kLFh5ZgPM tbAs9D4ZjLfCJHZKXBkXmF+rQbsaC6GcmT7I+0pRcdLnAYV0gj1XYcNu/yKDwGeOAsP+teKH Pz3Lskm9PtQwVtUiztbUN1IdQr6ue72a7OUFojPVoK+QOOhTSn5PrTFAWZ5A4XV3dqza05+W bIvgTl7uH72svLhSP05iv21dB7idHhwtxMCIiljdUUECzljkKNaJ56U7OPkTgpqKWE6Uoskv PLvxA8Vv4Dp0/5TyWQm1/AygPg2DEh5zvLzkKZu2LqpYjDSDczG6N69MpkWyqcz3BlkMB30a pN0W7cnYFQFwn8kCP04MWNfw12l2KvyEBS0dI7vjh6a88zebVRpYsQ8Ad+C5EbBh/374ghDa 1HENzc3vBLalmXBkqp/1WH+ObcHEjbIy32B3Tr4qeuonxrdTFCvgUlLfUk7zQ9HMlXcegC2w zGWp4Y3Y2mAPVmK56VP91xNPdfPFa9Ny4kAFjiU2gPK5t3T04li6SHq4ndt9vaMqDh8vMJ6e P8uRVjxDcPR34= X-IronPort-AV: E=Sophos;i="5.85,273,1624334400"; d="scan'208";a="52507810" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=N01OWPYe/+p9tuJjLX6zqVHoR4i7uIFst9lr62Lcse3ehhx6gblYvA8TofqTZr5Fc9Yy35VQbcrSEiHHUFQmzvq8AEyzyxUvOkcLWM2Oi8lUXMtuM9KJ6UlAT9QqYSlajJ521X2wp1efiZG2QNpgBTuvLRHAjzv4sPR3QSqq7zyPgo65/gnDZjOHiMGtqXO+QQHbx+fFh2lwuEjU1ArymIANV4X5LUDg3WokBw87gKPaDg6IBiVpXAlvI5P0/HGyJ19ONlviIAQXZfQXsth7A14rosVJMqdjE81zfG5l9dVjbEE7H8ls/8t+jCkajLItzyzrw8Nmqxl/p5h8A73RtQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7yWjg6RICr/TwDqra08velTyo7XtSAg1czseNajXQ4w=; b=HtY0uIqk0aBYBSqEF2MiXQ85JB+O2cogloBDo4z3j7VcEYe0fneV9T1ZjOrV/kSmyBnlF+n2kI/1B+rbNXt7Q5SwdOmimEsRzn5WfNhNMRnW/cAhQ/KsDBbjIMoQpnWtkv5LjDFo9CzteVvmNXV5uuyoiABIumTra/oCZCR7Pi5m7x5AMkObv7Lqkkb2fnkvbvEYFCVdk/7zeazEj/KtJ9YsOlf7dIXS81zYB2IHYFpSYmeDf2rJ/m/q0Q6ckEusbx20eVtFnIGmQC7TeJpGQTfgoXHUN8W9A7LiCVvBW2SWd2i1dtFa79WSqt/b1MfBjdw/cazhUBYOtKV3VXmhxw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7yWjg6RICr/TwDqra08velTyo7XtSAg1czseNajXQ4w=; b=R0NXAynlhfI1WS90VlPjd6uvi04adwt6fnXcaTpb3dWrJqE3Sey73H/9G/lT+ST8loMJeasuC3FEGFQ4462nvRZ/jAf8LFFrm7lhMwztbKIrtuv3FXguxSHwsif52YfYq7ySCNWywColj2MKJg6uSEH7VhMR585cDylEGgiSOKM= To: "Daniel P. Smith" , CC: Daniel De Graaf References: <20210903190629.11917-1-dpsmith@apertussolutions.com> <20210903190629.11917-10-dpsmith@apertussolutions.com> From: Andrew Cooper Subject: Re: [PATCH v4 09/11] silo: remove circular xsm hook call Message-ID: Date: Mon, 6 Sep 2021 19:55:07 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 In-Reply-To: <20210903190629.11917-10-dpsmith@apertussolutions.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: en-GB X-ClientProxiedBy: LO4P123CA0168.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18a::11) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f27be822-55ae-4309-3ec5-08d97167db7a X-MS-TrafficTypeDiagnostic: BYAPR03MB3941: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:595; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +zY+YJchn0vKL1shRH3kH5Yat0y9+YgaMqGSumkFkY/F36j4lvyqY5K6n89ub0cUIUhVel8LXe3PxaVOdj/aCMTdzwaYZD7jBKeO8FQ592RSUD4f3Qf66jsI12kqwJINecNRW3VfFFpJ9NxVMUDYNSMil5KU5M5OdPa+SxowpGMacKX1oHQL0kRZaIWOSGFeR//AAtfRgVCQNcLkyqqirMdPCizQk54Fxb6nTqFvHyxHefJovTKjtTgHR/qIr9KPMhHCrKKH/jAHNTGWmbURuT9CDNpagApjaWY+yKp5hdFJpSrS7sCInSzj6Gwy68OynRwcNMWlwAwkx8kzBV7tAsgkiBabxsz0mg5vNwi58knZefJ57NW+ThveWNHI4L0c6Ya1N/dFdv4cO9FSX5yzxu+b+Vi2l1Qt0Htpf2GRFiYF3eqqTEjSK3C3eKqWYBPn7+UzZcX1biNAqeD88ZCqCiDXy68TP7HKaQSmo7gjsVmI1AGknqL/TLju96GLCLLnS7wl/DoatqBlfoCo1y6c5QcnGduHmOfn4TzWRo+je8gg7NXIe1cfmTQ2GLyiVEPlcTHrtdj29uJWRm9933YcMXnPhy8w7EqID3zBe4b+mDaiqwR+hAzcpyddfSou0pw/51WnAM+IyWZxmTD8zUidq43CnxZxoNbWKl6ib6S8vK0eChwhr8UAzKRLt7JsTj73+MLiZEJCCo6NdXQ1Svo97/xYO1hyzfWSgDnvamQyooAVQfF3JgyhNv6XB9GrdfRlHa2sXnyMu6r01YU8zZEqvzPHwzpINq6sbyms7ahMoNH8u7/CTae9manONHYf74qc X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(39860400002)(376002)(346002)(396003)(136003)(53546011)(2616005)(5660300002)(55236004)(36756003)(8936002)(86362001)(26005)(478600001)(956004)(66946007)(66476007)(66556008)(83380400001)(31686004)(186003)(38100700002)(6666004)(2906002)(16576012)(8676002)(4326008)(31696002)(316002)(6486002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VlNWeHNIY0V2UDdXYjEvMVNzN0pTT3dOcHEzd3lPTmpHWGpuL09mTENWa0ZG?= =?utf-8?B?M2tCejE0ODVpYXVwLzV3ZmJuTytXSE1YMU9xaERzU2g4VDdORGdjWm8rVTZV?= =?utf-8?B?c28wV2ZHMDJTN1lpM0pFN3FBNzFiajNXRTVQY2h3ZUpERlM4dGNUbHlGMFZs?= =?utf-8?B?bGJmSkZLejd2KzZXTUtCTXU3cXJMWlRkK1JKUWFxNzRTblp1eFdYN1A0K2cw?= =?utf-8?B?VThIbCtSL3VlMXFFdnVlNVc3S3FXYXdxYTJub1Z2TU80UFh2OFJDRmc5Z0Mz?= =?utf-8?B?dVVjRW5qUWh5bHZJS1pLVUQxZlM5WjVyNndJb2Vrd1JvWFE2TDIyZmc3NHZK?= =?utf-8?B?WTZlU2dudDNQbDNxMEVkT1g3NkcrMGpremRHMEdOVHg0MlB1VVBvNm9jdG5S?= =?utf-8?B?YkEyK1d3NVB2NjF4SG5JczZaTTFIREs1MDhMTGF6dFdGZUNtbVRsZkk4Q2JV?= =?utf-8?B?Vk1IQVk0V04vb3R3cjd6VUlkQ0xvNGc1UDZsN0k2dEZibERHcHVGZHZNeTA2?= =?utf-8?B?K1h5Nm4rdE90OEdmR1ppNWpDMlp6VWt2MGlUMXhlblE4MThpazRNYmd2OVls?= =?utf-8?B?emtWRFliQTRXMERkZlg0ZDhrSlB4MGtwbjBOME9vWWZrRUhkUHkyZTRMTjlQ?= =?utf-8?B?TjVoSlhuNGZqbGNVdUVXL2lESUdubkJFcE9jbUp5L000d0NNUm0xd3dpUFBS?= =?utf-8?B?b0pXcDRIQ0wvRE5Gdmp3b3I4QzZEZUlnSDZDc2JDYmhXQzAxTjlIeW03ejBw?= =?utf-8?B?c3FSVkVraVlxSjVJRDFadTgwcU01Tld6bFdFWXNUYy84S2svbUJTbmdKNGhP?= =?utf-8?B?QUxMaDdQQ2kvV1NPditHT0h0Z1pxWWM5OVdPbGQ0OFp5c2M3b3R0bzdWZlRU?= =?utf-8?B?dFVtWGl4aEZobEVqbjZwQWtrSHZyN1NvRGJlWHM1YlJwc2kyaHcwYkpXTDhi?= =?utf-8?B?Q1ZYMEZLSk5LblZLeWZUcnc4aXJtbEpjbFd4NmMvcmZFcFBieUpCc29PQU94?= =?utf-8?B?N3ViV2EvMEtUbUxkTmZhYkJrYVpoMXBzdkptMmpTRzJvdWZIaHA1ckc1K1Va?= =?utf-8?B?ZTdxckZaWjhCalBxL1huSEg0R3p6ZVRHWmN3ZFZiWHJVRUhvOElQeDAwdTVS?= =?utf-8?B?amtZZGdmYWdvWWtNMitFZm03bTkrSWtFR242dUhBV1VVMit6eDc5dUhSdFk2?= =?utf-8?B?V3orK1BsMmUzREMvTmpwcC9NbjNjemhiRnd0Qmt2TVJTSDVkdnFTRmRYekZI?= =?utf-8?B?WklUUWF2TGpKUC84NWVLeUhya0Z6QnV4QWFiL3p3TUNnNnZncWY5UVVsdnBQ?= =?utf-8?B?QmFYYzFOMk12SEtwdEhPOHZJenNBVlh5czl5MnIxZzlJL2FMeE1VL25ySjVq?= =?utf-8?B?eWZXbEc2azMraXcrUXViZ29pSSszQzF1MUR5MHpUS0FKRVdPT1RKOWZmTVRj?= =?utf-8?B?UFJOcXhwaVJ4WGM0ZS9zZzUzbFF6K1hZNHJYWEpTUkgzVTVVRlZmaEF6eW1S?= =?utf-8?B?ZUVyMVowSlRic25SUUZUekdEazNNT3MyUW9BcFVBTncxL2VRc3JtemN3ZXZY?= =?utf-8?B?OXVxUkR6bnZ1eldzNDlJdlVGK1l3Q2RRbkRtVTRKMC9LYnd5OXd4WTdFS3Zh?= =?utf-8?B?ZDZ5L1h4eTZpT2RtNTBDTDlQa05KZnVrS0JsYlMwSjcrdzFvVGI0SDRsVHRv?= =?utf-8?B?b2F0ck01dEVCNUpKRzdndnY0K3lIdzJnNzkvYTQxWHJpaUMrSEtxK1RXeUQ1?= =?utf-8?Q?8d4wefKVd6ykQd4dB3Om7jWp76lQQM0OFEvFdfk?= X-MS-Exchange-CrossTenant-Network-Message-Id: f27be822-55ae-4309-3ec5-08d97167db7a X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2021 18:55:12.9216 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 3DcxsiQpdNP1ShTxmc1+3JAbpiL0CWoAgBeHyRSoc1JiAS4xbeGPgshMNT8VbjCWtWZNg5hg7JskkwBXn37vkhzuxBA6djmeOoBXnTN87H4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB3941 X-OriginatorOrg: citrix.com On 03/09/2021 20:06, Daniel P. Smith wrote: > SILO implements a few XSM hooks to extended the decision logic beyond > what is defined in the dummy/default policy. For each of the hooks, it > falls back to the dummy/default policy. The fall back is done a slight > round-about way. "done in a slightly" ? > This commit makes the direct call to the default policy's > logic, xsm_default_action(). > > Signed-off-by: Daniel P. Smith > --- > xen/xsm/silo.c | 15 ++++++++------- > 1 file changed, 8 insertions(+), 7 deletions(-) > > diff --git a/xen/xsm/silo.c b/xen/xsm/silo.c > index 6db793f35c..56a330a831 100644 > --- a/xen/xsm/silo.c > +++ b/xen/xsm/silo.c > @@ -17,6 +17,7 @@ > * You should have received a copy of the GNU General Public License alo= ng with > * this program; If not, see . > */ > +#include > #include > =20 > /* > @@ -43,7 +44,7 @@ static int silo_evtchn_unbound(struct domain *d1, struc= t evtchn *chn, > else > { > if ( silo_mode_dom_check(d1, d2) ) > - rc =3D xsm_evtchn_unbound(d1, chn, id2); > + rc =3D xsm_default_action(XSM_TARGET, current->domain, d1); > rcu_unlock_domain(d2); > } > =20 > @@ -54,7 +55,7 @@ static int silo_evtchn_interdomain(struct domain *d1, s= truct evtchn *chan1, > struct domain *d2, struct evtchn *cha= n2) > { > if ( silo_mode_dom_check(d1, d2) ) > - return xsm_evtchn_interdomain(d1, chan1, d2, chan2); > + return xsm_default_action(XSM_HOOK, d1, d2); > return -EPERM; > } > =20 > @@ -62,21 +63,21 @@ static int silo_grant_mapref(struct domain *d1, struc= t domain *d2, > uint32_t flags) > { > if ( silo_mode_dom_check(d1, d2) ) > - return xsm_grant_mapref(d1, d2, flags); > + return xsm_default_action(XSM_HOOK, d1, d2); > return -EPERM; > } > =20 > static int silo_grant_transfer(struct domain *d1, struct domain *d2) > { > if ( silo_mode_dom_check(d1, d2) ) > - return xsm_grant_transfer(d1, d2); > + return xsm_default_action(XSM_HOOK, d1, d2); > return -EPERM; > } > =20 > static int silo_grant_copy(struct domain *d1, struct domain *d2) > { > if ( silo_mode_dom_check(d1, d2) ) > - return xsm_grant_copy(d1, d2); > + return xsm_default_action(XSM_HOOK, d1, d2); > return -EPERM; > } > =20 > @@ -86,14 +87,14 @@ static int silo_argo_register_single_source(const str= uct domain *d1, > const struct domain *d2) > { > if ( silo_mode_dom_check(d1, d2) ) > - return xsm_argo_register_single_source(d1, d2); > + return 0; > return -EPERM; > } > =20 > static int silo_argo_send(const struct domain *d1, const struct domain *= d2) > { > if ( silo_mode_dom_check(d1, d2) ) > - return xsm_argo_send(d1, d2); > + return 0; Shouldn't these be XSM_HOOK too?=C2=A0 Or should all other XSM_HOOK's be short-circuted to 0? The asymmetry here seems weird. ~Andrew From xen-devel-bounces@lists.xenproject.org Mon Sep 06 19:18:31 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Sep 2021 19:18:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180210.326769 (Exim 4.92) (envelope-from ) id 1mNK8M-0000ZC-Vz; Mon, 06 Sep 2021 19:18:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180210.326769; Mon, 06 Sep 2021 19:18:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNK8M-0000Z5-Se; Mon, 06 Sep 2021 19:18:22 +0000 Received: by outflank-mailman (input) for mailman id 180210; Mon, 06 Sep 2021 19:18:21 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNK8L-0000Yz-BF for xen-devel@lists.xenproject.org; Mon, 06 Sep 2021 19:18:21 +0000 Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id aa6e8fd0-f2e3-41cc-83af-cf6374ad21fb; Mon, 06 Sep 2021 19:18:20 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: aa6e8fd0-f2e3-41cc-83af-cf6374ad21fb DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1630955899; h=to:cc:references:from:subject:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=QtUSp3pvvZZv808XCaHgs/kPOkAFV28WuV+5wXilHK0=; b=A5FX0Naz0LBvGYH+HwWbyzi3T+aVfkE1FiQN5k+X8ss28e4w3Etp7Rud FqxwSgh/5XuUhbxfwEVehxNbj/nolurW8wz1e+f7MIHcE1NmKuo5Spn9A SywQplyfvyhSQoV4uQi982h/nbOrZNyJjktE+kaLjMDRkaFOF+/Ne3fzQ s=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: 6B/Tzs0QA46+CNAFqe01cQ9nVn+/Aqt6rO72D7+txkl0ZpJ94XpmeO1Ff8SGxJ2jmDgmhez3AX RZY0EVxnC3G6dHZ56ffxWBATfgDJkqOuZL1DOZwA7yOWHBx1kVMKapM6bMjfVV3uuCHrX73Rqh 4uSu9m0ljuK8n1dv2gs0ENCwQ8CMZfj/hBPgPWLa+fyJomvrHW5on32MwEywbSmjK8NcJKSERD TGwkfUYuqtCji1rAJ0XXRiYtnZqija+1RtPqLADRDDHSq6qAaaAuA9t/lPuhygjy8RNssmp4OX 8JzKtLu3LWwQq9LZDn37bw8I X-SBRS: 5.1 X-MesageID: 52508607 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:XV9dIqHKGLcyP+ESpLqFeJHXdLJyesId70hD6qkvc3Nom52j+/ xGws536faVslcssHFJo6HkBEDyewKiyXcT2/hsAV7CZniahILMFu9fBOTZskXd8kHFh4lgPO JbAtJD4b7LfChHZKTBkXCF+r8bqbHtmsDY5pas854ud3APV0gJ1XYJNu/xKDwReOApP+taKH PR3Ls9m9L2Ek5nEPhTS0N1EtTrlpnurtbLcBQGDxko5E2nii6p0qfzF1y90g0FWz1C7L8++S yd+jaJqZmLgrWe8FvxxmXT55NZlJ/IzcZCPtWFjowwJi/3ggilSYx9U/mpvSwzosuo9FE2+e O87ysIDoBW0Tf8b2u1qRzi103J1ysv0WbrzRuijX7qsaXCNXoHIvsEobgcXgrS6kImst05+r lMxXilu51eCg6FtDjh5vDTPisa1nackD4Hq6o+nnZfWYwRZPt6tooE5n5YF58GAWbT9J0nKu 9zF8vRjcwmMG9yV0qp/FWH/ebcG0jaRny9Mww/U42uonZrdUlCvgglLJd1pAZGyHo/I6M0rt gsfJ4Y0o2mdfVmGJ6VMt1xN/dfOla9My4kD1jiVWgPNJt3cE4l+KSHqonc2omRCes1Jd0J6c 38bG8= X-IronPort-AV: E=Sophos;i="5.85,273,1624334400"; d="scan'208";a="52508607" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dTSxZ79Nmu07vS74qNVRDIamhRusfk2uBEp3y7QnxeCqKXozhxHMDTDxAu708Y7ys4+LTEcEfE7obviTOAoSoo9FGmf8+0E3/WxIHKdHgg/bcBfp9GgF5V6rWzNeTkwJtQGwYD9pXMwsnwS0XLOkkrlBIpFHA/rRILcfv5MvBomBZ6sX4vaTYdKkmFOEud/RCzPhtpAD8qS44a1L93pCTKXWTtTrKPPdrzz/t0h1lUOFD+lGp5gCjiR1SzSjLqkmBTIBEDLIWrQbJRcoCbfVMbBdTNQT9sJi/ZB7XRIKiTHHZoLUgdhCIYcc7LDwJFFgvQLUyMNeiKRYd3JB2UDblg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=gvTsw0FNSL5+s3kxRMn/xBfkLyPZHLX0DVmJG321wyA=; b=h+3P0OgDMcsGTxgrTvp/Voz8nDws28mFvKLPVHWnO7p7vhvzSiBHDLESIMSvkh23N1KC11txf1gHgJw/vXAYOxnBbs/LgouUXi7kNhakVOiuKJ7Jn93OEsABa4CZJfUE5sy0nyUKPbszs4ItUvblH+mULCJt/msdV/Yk1/81vCIXyQSMgvlvAAeXHv3sx+t81ZykqW2X6SBI314gg0DlBTmGz/x5BBCS43UNcAuIIaU+g6+ENFqjy6+WMpaWNsLDdeYT7YxUH8J0qnNcBf0TnnEc1z5KbOL/RWimqxJXa6RXLFf3N1l0D5MPzw919rfPsqDeGXnXALUD/GHLb6jk4w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gvTsw0FNSL5+s3kxRMn/xBfkLyPZHLX0DVmJG321wyA=; b=jZK1tR2Gr+pHvu4O4CTwSEzAnAAEE1EDGdwA+AD6/JdmDCYPy6+BeUe6Dps1JYnrWbDX0s7P+5YzfTfxEI2SYi2hUMqve0EEPlUMFPWeDae9rbkph1oxfmVTxz+sld2O8LdM8kB69RGS4H8UNAVrgMan8Rj6PQ25q8s+GltRVnE= To: "Daniel P. Smith" , CC: Daniel De Graaf References: <20210903190629.11917-1-dpsmith@apertussolutions.com> <20210903190629.11917-12-dpsmith@apertussolutions.com> From: Andrew Cooper Subject: Re: [PATCH v4 11/11] xsm: remove alternate xsm hook interface Message-ID: Date: Mon, 6 Sep 2021 20:18:03 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 In-Reply-To: <20210903190629.11917-12-dpsmith@apertussolutions.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: en-GB X-ClientProxiedBy: LO2P265CA0064.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:60::28) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: fec7ad68-569d-44aa-57fe-08d9716b0fcf X-MS-TrafficTypeDiagnostic: SJ0PR03MB5597: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:5516; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: My09vHhQTv9vimrF9fR6V7n2ANeaRjupRzQa98VxXNOBOUia8rROr7fP9LqIlCn/gxJ4XyjQiTGOh3yp6DqmkdFA/hHw+3q7zD9P8D9zMJff0jWx6prlTMPJ2ANijDRB6MUUTtH3cg8syWHHdxJ6vtRO9pP5ZBuX5YaAztOjVdjtmhS2HwiGMqO7LDITZuKhyibXEQyOZNA0aUsSeTpgW+Vc5ar66sBGFRP5QE3oc3sfCehZZNLTCO0huO11+sBqDqIyTEIqpt+V45Yay5sKja+SwBfHiwPAeuKDq1FmgK4hyejI1WT0tRFZDfvc7ffjrB22tRQ1o9tsK4DXpm8G+k1zLlmRnElEJOTI+F4ycBDMs0Z3R9kygP8EWLeAnOHgAa/oI6RxcCfQ3qLnWb95pg9hsgSUqvXEGpzdU/eCqUqBihDK/jPC97DyDsV+CbPKHoDK2S3buxLwTnqceL/m88EBqYVsZ3iMX03cvv5ZH5Vl2RExU9WE4fnGHIP5GzxDcgsfUSLwYBcPuua1C61tnkODWthn/9SyQgPHgfipzPe4L/c0AZnDYkSYZufwqm5h5EOUquhJouamOQc2/Brgx7UCIopAhqIEQxreOCWAi6G5VK3+NZBOKn+ACpp1UgX8o3nWlgm72SIv49B4DBwOxmY8sE1TnJfqoBxHpnfWPSCNmqwwwBIcyAQy/TE45Ee3ItTbPJcfy9+OvbobTkjOOyV3zaQLSuWEdNLR1qtPTSCZQ5uzRblVdYCovZ79Vgw4Aanuw7MTJCg+EYkS6FbYgQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(136003)(366004)(396003)(39860400002)(376002)(31696002)(2906002)(4326008)(956004)(16576012)(2616005)(55236004)(36756003)(316002)(186003)(26005)(6666004)(31686004)(5660300002)(38100700002)(53546011)(66946007)(66476007)(66556008)(478600001)(86362001)(6486002)(83380400001)(8936002)(8676002)(2004002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TkNBWmhHOURZUkpuWEU2Y3NpNVljWDIvdURWa0ZEWXRwSHJxYnNCQlgydWVa?= =?utf-8?B?WTI4eml4UE1WcHNxYVpDK0tpQ0xwTGs4aG9kR2E2U2FxMk1EQ0lGNUt4ZWxk?= =?utf-8?B?Zy96aklBOGZPcHY3dm4yK3dmUEhROEZla0l4YWROeUFIVzY4ZENaUTlZMkRE?= =?utf-8?B?Vi9kSURNaFZobVNFVXFUbGRLRDFNdDVJWjNHSnZGYy8xNHhGSFUyaVZRa05x?= =?utf-8?B?RTJ2Tm5FcWdoSnpuU0doR3B4Uk5CQ2NldmdtUmYvVmNJYmR2MkNMb2lXdDhy?= =?utf-8?B?WFV6OElxc1hVNHF4b0xVNDEyTldvbnZQWU5OVktGOGlqQ3BRWFJCVkJwZFV2?= =?utf-8?B?cS9CR2MrN0g1RExPaFlGWk1FeWkvMnpXbUdsSzRuMkVXWEpFdmNiZjR5ck5p?= =?utf-8?B?ZzVpYlVOZW02dzYzU21SVVhsZEJlWGhhMVdjUk0xY1VIM0xuNmZHNHdJTE9i?= =?utf-8?B?bnViNXNHTGx1Y0NTZWljUFczSUtBZzhjK2tRbDYvV0x6djhaaXNyeitwdHdR?= =?utf-8?B?SGxpZjVIdG1ZbU5mZWVoUUFpNDFvK3U5Q1VGanBidHhBS1lieFhlbVNKTy91?= =?utf-8?B?b21BYVQ0OFd5T29aaUhacmZEaFhMN0t6RUZja05YWFNMdlpHNlRpZ3JwZmh6?= =?utf-8?B?U3NCZ01PR3p1MkgzeXVnbE9sK2trYVhMaTV5MW9DTU9paDRuRC9mbUtFaEJu?= =?utf-8?B?Wm5zUDJWdHBlVlZXa2E2RzlIcXp0eUlPNVRVc2I5Ti9uQUp6REM3RE1VMDRY?= =?utf-8?B?YXozWHhTVFZZeERSM1ZyREpwQXlHWUVpbXpJVVdVNitTNlJScXBMMGFKaWcv?= =?utf-8?B?elFOVGkxRW1xNlplMndHUXozdFl0cEQwcFNLMjBCTEp2K1RtSEcxVFlTVi9S?= =?utf-8?B?MzJBbEVvYXA1clUrZDhVSStXb0Rwbk91c3dlWm5zQUhWZnlaSklFcmNrbm1R?= =?utf-8?B?RVBvdUlzczA5NTdlY1dpc3pmSEl4UXhqT05vU2FOSUtxSXloYlRybUx1VUxR?= =?utf-8?B?SVFqVUhHQkcxS2NvQ1ZGbE9Vams5Q0VvM1YxeStBRWFCa3A2bnZTaVFIN2VS?= =?utf-8?B?UVZhaFNpMXpIVDNMeXQvUDNLRys3UE1VZmJFWWpIaEtWdkoydkNWQ1VzY3VH?= =?utf-8?B?S3BOUkk4UFdkV3I4Ny80V2llYnBxTEgyaUM4dCtOM3Z1OXZiUGgxekJBSXU4?= =?utf-8?B?STE5ODFjZ2ZwTVRhdjVEUTIrdGxmVmg4WVhGdTJkZjhPOXZRVnd2QkxSZlQy?= =?utf-8?B?ZG5ERkh1RnFIMGhnR2tBWGtZMGhuL2pPd2xDbWU0dUZQVmp3ZkpxWlhLWSto?= =?utf-8?B?UHltUzZ1bEtFaGMzM0h2ZUVPRWRzNFplQk9XZ2g3dmR2dFh0YUF4dkt6bnQx?= =?utf-8?B?ZGc0dDllZ29RR2g4dUdmZ1M2MzhQWE54blpKRDBhWndzeXdrSDlkaExqTjRK?= =?utf-8?B?TWJZei96R0htbTM3eU5UMUtBTkNJenE4OFRVMUk0ZzV2RkpUN3VlNjNQNVNK?= =?utf-8?B?am9pQjZaZUQyRlZsZjlhdEt0aHdtem1XWDN6Vmt5TXIwU21DUk9iRHJqdDE3?= =?utf-8?B?dHVxRG9QejJYVE9hSEhKbXRFdlBEQTVJQ3Evdkt0QU1HMENCWndIL2VCZ1NR?= =?utf-8?B?UUcrSGdpcnBDVTArNUMyWmhSWUk5em1vbmcyUmtvd1hCK3RrUEo3NUpKREhm?= =?utf-8?B?b2Z3Q1JMek1uQzY0VmJJdmNsOThmNnp2WUMrZEdjRW9QU0s3dTRhT3E5TFBa?= =?utf-8?Q?i8OE+E5U/7iu0YTne6nyz0QP0oEHoO3fxy5Vixs?= X-MS-Exchange-CrossTenant-Network-Message-Id: fec7ad68-569d-44aa-57fe-08d9716b0fcf X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2021 19:18:09.2060 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: xNXRHAmPAbFfK2WzzHaJ3muilch85ZR9USj3jpf+/uGB/+w1plrHQfUaNK1+ONnYlS0To7DN6UvK+yZZXEsr/8ChaHsyXK585ik1+V/LPnU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5597 X-OriginatorOrg: citrix.com On 03/09/2021 20:06, Daniel P. Smith wrote: > -static inline int xsm_memtype(xsm_default_t def, uint32_t access) > +#if 0 > +/* Could not find any usages */ > +static inline int xsm_memtype(xsm_default_t action, uint32_t access) > { > return alternative_call(xsm_ops.memtype, access); > } > +#endif There wants to be an earlier patch deleting dead code.=C2=A0 We don't want = to retain this if-0'd out. > diff --git a/xen/xsm/dummy.h b/xen/xsm/dummy.h > new file mode 100644 > index 0000000000..b9a7e8c40f > --- /dev/null > +++ b/xen/xsm/dummy.h > @@ -0,0 +1,739 @@ > +/* > + * Default XSM hooks - IS_PRIV and IS_PRIV_FOR checks > + * > + * Author: Daniel De Graaf > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License version 2, > + * as published by the Free Software Foundation. > + * > + * > + * Dummy XSM hooks implementing the default access check. Each hook sho= uld > + * have as its first line XSM_DEFAULT_ACTION declaring the privilege le= vel > + * required for this access. > + */ > + > +#ifndef __XSM_DUMMY_H__ > +#define __XSM_DUMMY_H__ > + > +#include > +#include > +#include > + > +#define XSM_DEFAULT_ACTION(def) xsm_default_t action =3D def; (void)acti= on > + > +static always_inline int xsm_default_action( > + xsm_default_t action, struct domain *src, struct domain *target) > +{ > + switch ( action ) { Either here (because you're moving code), or in the style fix, the brace wants to be on the next line. ~Andrew From xen-devel-bounces@lists.xenproject.org Mon Sep 06 19:20:48 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Sep 2021 19:20:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180217.326780 (Exim 4.92) (envelope-from ) id 1mNKAh-0001wd-Gn; Mon, 06 Sep 2021 19:20:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180217.326780; Mon, 06 Sep 2021 19:20:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNKAh-0001wW-DU; Mon, 06 Sep 2021 19:20:47 +0000 Received: by outflank-mailman (input) for mailman id 180217; Mon, 06 Sep 2021 19:20:46 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNKAg-0001wO-5F for xen-devel@lists.xenproject.org; Mon, 06 Sep 2021 19:20:46 +0000 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 886da6f6-0f47-11ec-b0b7-12813bfff9fa; Mon, 06 Sep 2021 19:20:45 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 886da6f6-0f47-11ec-b0b7-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1630956045; h=subject:to:cc:references:from:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=H61zcukOsd/RVg3l1xWthoBS5YMimXZXBl98tbnD6FI=; b=Df2OdeIy/91r3qNvShzwS1NF/u6F++BNrhn2vX6knTtpfyNrvdbvlWkB +e3OMrmHWJKonTJzrdC6/HPVluM35t7uVf0lujoFZcoWUeMWU6TysX6bU jfSPch2/3QL+eE3aUxk6B/8uKOAj9t53J1rgEmDfZ7vpCfQBwhonCfb2l I=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: chvutixBMXO4o9wIBt7vAERNdpsTi9K22ZuepRfmz0jbKVhtqmqH1n67h0VE2dHk6G472gBwFd SSa/G/D5zr++T9NkRIt0q4yZbZWL/LherjNmlm9QpJVkKhP94/S/eVXS0uSoWvWSP8ozQCc0WB xN2Kor5HpT3YD63lON/ofI6owo7P1tLYJpvr0s/L4e8szxvPohLATv1L7AHpsActgzL4VoWiDm 4lPHcsCuYpK08ZUutAno1B6KOyeIqRavMcImxDW/4QELluCifYGPiad9USUSi3WDmesU5LQTM5 VSrka9UlwV9tFjJ5BWGkvFlr X-SBRS: 5.1 X-MesageID: 51711369 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:QiVGLaBckZwM40blHeg7sceALOsnbusQ8zAXPh9KJiC9I/b1qy nxppkmPH/P6Qr4WBkb6LS90dq7MAzhHPlOkPUs1NaZLXTbUQ6TQr2KgrGSuwEIdxeOkNK1kJ 0QCZSWa+eAfWSS7/yKmTVQeuxIqLLskNHK9JTjJjVWPGZXgslbnnZE422gYy9LrWd9dP8E/d anl7F6T23KQwVoUi33PAhIY8Hz4/nw0L72ax8PABAqrCGIkDOT8bb/VzyVxA0XXT9jyaortT GtqX222oyT99WAjjPM3W7a6Jpb3PPn19t4HcSJzuwYMC/lhAqEbJloH5eCoDc2iuey70tCqq iCnz4Qe+BIr1/BdGC8phXgnyHmzTYV8nfnjWSVhHPyyPaJDw4SOo5kv8Z0YxHZ400vsJVXy6 RQxV+UsJJREFfpgDn9z8KgbWAoqmOE5V4Z1cIDhX1WVoUTLJVLq5YEwU9TGJAcWArn9YEcFv V0Bs203ocXTbqjVQGdgoBT+q3pYpxqdS32BXTq+/blkgS+pUoJjXfxn6ck7zE9HJFUcegN2w 2LCNUwqFniJvVmGp6VP91xNPdfPFa9CC4kAFjiU2gPK5t3T04li6SHqondt9vaNaDh8vMJ6e L8uRVjxDYPR34= X-IronPort-AV: E=Sophos;i="5.85,273,1624334400"; d="scan'208";a="51711369" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CHw+64Wk2BTMd+YYZFxdW6DqgeYcdyEoeSZwE7ry3VaDncZQ90fPaiWWMDzbzmbVKfAt5Km030hAqFbyR7sbq3PBbhPNFnFlP3uSdK+XYHVy2TU5p80C4sFNq2LEXHFueT15aJy0gDooHRRC3cOgU1vXEPxK9Mx8uspnOR1pvo8gtTctvmXwSsUoUMXyjIiyJ73njzqpuyxOUh2mZ4A2AEklQ5wWqw268mGmUXlGG9sFqo/M832Vsj63WUSncv3Q7kPGdGe54euxKxjN/5xBp8jrql9TmjHe8dPnlQe5YPz4Osr+H++xvXwZ6nT9fDY3lQpdxRhesuNppn8afRvRRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=068ibvkm9tu8zkK4YojlwHtkjfAJ7acXP/CA6lRGMLE=; b=j2t8LqYRK4Wm1KvdTLCxsqQDPhZbmXumtoPKtErpvfP64VyXGfqOo1yHcHEGHEFpf732nGJ2vNtYkCtY9FNWS7+Jc8SazGXTvBFKbc3CODnudTYI/+Z+A6qGlFQ+c4tSaFPZ1q2RGNYxZ896ZHJb4iuDOWWUnJVw6MBPvZ6Us2iwqQs/KL4+R3AqvtbAu9dAz9aVUmr8WJLuW5+uWxweKj1O9bR62AlEY0jqYInuWDx0ZppW5rJPJLDqeCdf2L8LD8qqbM3dhxTV+lvdbocSHL2qBIz6hSTWcgDjRB8VdZT8Cw92RN3db5nlntC/0fHYHgksYW6MgjkjV+U5LAjJMg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=068ibvkm9tu8zkK4YojlwHtkjfAJ7acXP/CA6lRGMLE=; b=X50ZueyKqIDDI6jcm8U+aRaJAxwncZKFyimLHMrsLW4FilmLuVhsOjEaahQeNnat0YRupyZJRsvWXz69grjkYJQn+SIy9Sk9FmLR3vaEtDs1o3xmlecHPyQmdmi+yU59uxbpWaDA4UkIlJBLnhmWdWG9s71h+RZlcKUCBwFrGdw= Subject: Re: [PATCH v1 1/2] x86/cpuid: Expose NullSelectorClearsBase CPUID bit to guests To: Jane Malalane , Xen-devel CC: Wei Liu , Jan Beulich , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Pu Wen , Andy Lutomirski References: <239f7624f3ac3793993dc045d451079aa555b90d.1630929059.git.jane.malalane@citrix.com> From: Andrew Cooper Message-ID: <7a87358a-37b9-0292-b6bd-ef33026426df@citrix.com> Date: Mon, 6 Sep 2021 20:20:34 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 In-Reply-To: <239f7624f3ac3793993dc045d451079aa555b90d.1630929059.git.jane.malalane@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-GB X-ClientProxiedBy: LO2P265CA0298.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a5::22) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 12ed33ea-445c-464f-425d-08d9716b69af X-MS-TrafficTypeDiagnostic: BYAPR03MB4613: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:473; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bHLgaBrnZVAhvZtlQF7KmqGveJTVlUhoml1r8gFhUzKSXgmraMn7osDf1qkAuoM+eoCqV4WqIZn8ujU3OhhHIIBwBaiEi18Qp3hAxmzl3K/Pg9o+/EOatKy0Scb/x6LAvaJPZG6hVLZCRhNFDEXbQhQlovQuFD2oXCsGNFMp49zdMMOmHyrwap5segWk/RVXBpus18yeeli2X+/U6gtAKFZB/bRR0O/MCmC0+3Fmv0fiwPAvT8tF+W8QccK8AHLK8wOUQoOpyfgSCz0VKJ9ALn+FXip7xdAkZk7shbEWJDPcRT87WJLgJMZGzAJfUFC75jySvZJKDLKCzE6h5KnpOQ6UHAXs34lVD25ZIRVy1cfU1pWVKZNvcnJojoEjmZ53kFiRu1lylpCBd7H3tF2fR3cj08LOI+KgA1JcZ2ic4xvoQ7rA+i1tOxr8Chkz+I73r5E3p5gCnUPEWT8mQbvpcOyo3589sc5Tw5L+q/wm80/YltREpLyiFNaAefPdS1/zD2REKpgPK/3aY9urofSB3l+LFYhS3PCk2hzHockacEpOinchZ/81PnSVE8H5mD1CpPvF8lGF9mO56QOLSOaa+r0flSwFXqI+D5c71cIdf4N5ROPPktC0KmZtwTTCXcrIGYODSdy1YVD7II8m3KEA4mzdyt3IsOh9UToAxrVeOz2pxC9eSBTm49cHjJJAoYq4Gf9rEK5H7RyXmzT+QBlHUjtxX5cpuGqYXwvHqqDzSlUTrbsA8nQRkSK0ITEfAFTv X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(366004)(136003)(376002)(39860400002)(396003)(8936002)(110136005)(54906003)(478600001)(66556008)(66476007)(31696002)(316002)(38100700002)(2906002)(16576012)(2616005)(66946007)(31686004)(26005)(956004)(36756003)(6486002)(55236004)(186003)(53546011)(83380400001)(5660300002)(4326008)(8676002)(86362001)(4744005)(6666004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dUNIOTREK1BSZzhwUU0ybW9DYW5NcVZUR1lEOWNOK0JVb3JBeVRLL0g5N1Rm?= =?utf-8?B?OER6WVAyTmsvTm5BaTN4bmRTMXVZUnlRK3V1MVJReGV2VHhvbTlVaDhiaHM2?= =?utf-8?B?UEQ5T2lUVys5QXQvRGZGOHRNOGc1TkNjbnVxRjB1KzVjclRtVlpHOVRoK055?= =?utf-8?B?c2dUZnVOZERqRFYxYk5xelRReXNkZkRHMklCNGtvd3Q1S0dDQStVeGpBV0cy?= =?utf-8?B?NlFWOXhSWFgyY29zZ2NESEEyS0FNbSsxbXFraGhUa01pdWpjM05mOE5zbzdH?= =?utf-8?B?VjIzaUJHTUxxQTUzYm9CRmszd1AyVHBwMWM4WjFrUkRCdmU1Tk52RlUvQ1Jr?= =?utf-8?B?MEFuejd6aUVzK0dDbEpNMHE2c0RQZm9uRUp1N3kyUmozYzIveHU0OFM1dzVI?= =?utf-8?B?TklJN0RRcWVuOHpUTGJZV21WRFZtV0xySGhWd2lBVkdJUGxpZzI5L1crYkM3?= =?utf-8?B?eWxBZnRhdk5OL0VuUUtLcHdnc3dWZUlOL1RYWk1KU3pPOHpJY2tEUTZLNmk3?= =?utf-8?B?MFI3dk9RYmhRM3d4YVAvWDZkbk5NSndFSEp6eGVLZitIMCswclFzdVljNHU2?= =?utf-8?B?V2s0RGx5c3I0dUxZdldRRVNvOGluY1JZOC9sOWNEMTZNK3FKN0FyS1VkbGNM?= =?utf-8?B?V0plM2N1NFBSek9mSCt1aHdmclNTQmpIU0ZmMSs5VzJ2V3FhQm1GZHdGZ28w?= =?utf-8?B?ZkVIUXJiU2taUjVKSjNpMmpMZkZlWmt4UjJHTjlLUlZFSC95WUxvMDBKeEhV?= =?utf-8?B?YXVsR016WkxEY01pTzdxUFFyNkNEUVNJdjZLTWh1ZTZuZTcxVzFsUmtmTUNY?= =?utf-8?B?clF6blJOZzZ0S29PeHNUaEdMWWdGTVNPditqVnF2bXMzL0pJMXpCRm1ZOHZm?= =?utf-8?B?RkNRdnRvMUdBYnViMmNGQXdQR3AvcnFBOTdJQjlvOEtPbkhUZTdIeDZqQTFU?= =?utf-8?B?dTR0UXh2TlQveXdSVDJ0WUNNeEVkMGpUY2Fib3hlNFozSmF6UlRxWHN3R3Nw?= =?utf-8?B?b0JMRDVEdkJTUm5qVDVGSXN5VUpRempKOVJvc01ZdTkzTGxaU1hqWjBmMW1B?= =?utf-8?B?R2dKNGdKVW1taVNOdHZXalhMb0JDdFBOMlhmWGMvMHdUK2Z1WnZtbWpTd0Rl?= =?utf-8?B?ckgzeUFGV3U1U29xVlNBTFZDaEdidEdOb0lSTFErSWF5NDNId3Q3b2U0Qlly?= =?utf-8?B?YUVlWHFFSC9LREh3Vlg1MjZqa3pqcFozUlA4M3dsdllFRVdKNmpUVFVqaTYv?= =?utf-8?B?eUtoekg4Ni9hRXg3R3BwVlhGR1lOeU5QcENkZGRlZUlTeTlGOEZBckxDMUJy?= =?utf-8?B?eEhvQUJjUWRlR3o1Y3dIamJGazdUb1JTNmNNWGdxSi90V1duU3NXNVpzMEE3?= =?utf-8?B?UjlUdWJneVl2aUVqTUFJamdVWTUwNEJTMks0UFNKRDB0dk5FNWdjVzNmZGZi?= =?utf-8?B?cDBhazErOWsxRGZFVjBMZU90dkpjY2JWakhXVUhYTXNDZ0I4SENLNEN1WkJ0?= =?utf-8?B?azc3UDhkNXh4Z3hFRkdWVkRBNEpuM08xU2xDNkI3aGJ0TkVKWVVwNlBiZ1gv?= =?utf-8?B?NHVvVDZzQjN1dFBiTGFXUkhDNUpLTFowVXhxcGdGYUUzTFFPR1MvZXdJUita?= =?utf-8?B?QmxsbTBsMmVNZ0hVNHRUa2FBQ2t0aWNMN1F6dUEvMVRjU09SMFRwL0pqMGky?= =?utf-8?B?Z29ZcVUxb0c2NmxYK09NOGYySjM4SlI2S09UWGp4WEY5NEp3Uy9FbXp1TEZ2?= =?utf-8?Q?IpKHpJl04r1ncYD+FvDL1ie/y2In0JAGSgCP3F3?= X-MS-Exchange-CrossTenant-Network-Message-Id: 12ed33ea-445c-464f-425d-08d9716b69af X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2021 19:20:39.9318 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 86owFCx1sifHqc1llDU1ZFMf6FVCSNdgxChXxjlSdIQBukaXwtwFtio6zacjNiXUMrp3xorTVenO+9iGjv8J57s8axY5JwOylbIqWFVRTDk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB4613 X-OriginatorOrg: citrix.com On 06/09/2021 13:00, Jane Malalane wrote: > diff --git a/xen/include/public/arch-x86/cpufeatureset.h b/xen/include/public/arch-x86/cpufeatureset.h > index 380b51b1b3..e5a7c94c78 100644 > --- a/xen/include/public/arch-x86/cpufeatureset.h > +++ b/xen/include/public/arch-x86/cpufeatureset.h > @@ -285,6 +285,7 @@ XEN_CPUFEATURE(FSRCS, 10*32+12) /*A Fast Short REP CMPSB/SCASB */ > > /* AMD-defined CPU features, CPUID level 0x80000021.eax, word 11 */ > XEN_CPUFEATURE(LFENCE_DISPATCH, 11*32+ 2) /*A LFENCE always serializing */ > +XEN_CPUFEATURE(NSCB, 11*32+ 6) /*A Null Selector Clears Base */ On second thoughts, I'm tempted to add " (and limit too)" to the comment. Can be fixed on commit. ~Andrew From xen-devel-bounces@lists.xenproject.org Mon Sep 06 19:23:45 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Sep 2021 19:23:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180223.326791 (Exim 4.92) (envelope-from ) id 1mNKDT-0002qs-0R; Mon, 06 Sep 2021 19:23:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180223.326791; Mon, 06 Sep 2021 19:23:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNKDS-0002ql-SD; Mon, 06 Sep 2021 19:23:38 +0000 Received: by outflank-mailman (input) for mailman id 180223; Mon, 06 Sep 2021 19:23:37 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNKDR-0002qf-M9 for xen-devel@lists.xenproject.org; Mon, 06 Sep 2021 19:23:37 +0000 Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id eeafac2a-0f47-11ec-b0b7-12813bfff9fa; Mon, 06 Sep 2021 19:23:36 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: eeafac2a-0f47-11ec-b0b7-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1630956216; h=subject:to:cc:references:from:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=HhdcBXvKAHOjeRXnQDNqYRtYE6DpLidMQx5V6Wm9xSg=; b=K8R0nO0A054KveB+MX64tWirwlVFL9uYE7KdIxeU20BXDVk1r6DiAIYD UEl27BA8c49e3N4XxhVeNtN62uZC8aFSx9oHbvcxBIeUxbsbNcSXQ6sH0 ol8n8vC6Yi3RIZTUCdTfFgpApEAW6saciFDpg5dZtrxT7OQbP2rdT08B+ Y=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: 0lMz85qtU7JE6sIzM2Gmge97+Vp5v8v4YaLVP0BLPbmi0Em5JRTSnCV9nd7wsyALhX3Z8hr5Wl DTtwt3x5lS6SLEbGmcPhHZ4i9xRgbt041D7gyd+i4cuj+sUOSlWxgaOYcaLbOV4mNAnMrOp2ko H1yE0pNlElOGBJIVhutncGeIOegC1JCatwM2LLPYW4P7wm3dpzSREwIKO9uk2C3ALhoFWUt5RN ERmcyUbPdx1aLuhHgVjHpPN8Z/D7J1bsrCfsQRkVMDSacfSS4qrPzNw2RZWi1zOUMI9DRxQoix iZymO7lNz4YoQZ1m7k/WMq5n X-SBRS: 5.1 X-MesageID: 52508760 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:OyIpnqCr86S9l/PlHeg7sceALOsnbusQ8zAXPh9KJiC9I/b1qy nxppkmPH/P6Qr4WBkb6LS90dq7MAzhHPlOkPUs1NaZLXTbUQ6TQr2KgrGSuwEIdxeOkNK1kJ 0QCZSWa+eAfWSS7/yKmTVQeuxIqLLskNHK9JTjJjVWPGZXgslbnnZE422gYy9LrWd9dP8E/d anl7F6T23KQwVoUi33PAhIY8Hz4/nw0L72ax8PABAqrCGIkDOT8bb/VzyVxA0XXT9jyaortT GtqX222oyT99WAjjPM3W7a6Jpb3PPn19t4HcSJzuwYMC/lhAqEbJloH5eCoDc2iuey70tCqq iCnz4Qe+BIr1/BdGC8phXgnyHmzTYV8nfnjWSVhHPyyPaJDw4SOo5kv8Z0YxHZ400vsJVXy6 RQxV+UsJJREFfpgDn9z8KgbWAoqmOE5V4Z1cIDhX1WVoUTLJVLq5YEwU9TGJAcWArn9YEcFv V0Bs203ocXTbqjVQGdgoBT+q3pYpxqdS32BXTq+/blkgS+pUoJjXfxn6ck7zE9HJFUcegN2w 2LCNUwqFniJvVmGp6VP91xNPdfPFa9CC4kAFjiU2gPK5t3T04li6SHqondt9vaNaDh8vMJ6e L8uRVjxDYPR34= X-IronPort-AV: E=Sophos;i="5.85,273,1624334400"; d="scan'208";a="52508760" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ag9pRZsMEtDDmFEPfgaiAV78PBfhrV7rpAweLAWjqWYfTBfhzv85CtRCSeE8m3ErB0YKQNja0izaZ55r0rM9R2S22LtR0HuaewiyUVpFCFXbMz+0pW4mYqzpZbqb2SmfN9fPnjf9KurkCGUaE1knUR8ITqq+2q7LY6EHf28iShh5VR4t5ZdqNy0jGTz9J9T71yNGmyqlt3jlL2w3E//Zwp3/2ps5sYTV6DrLhIl3FCXxFn6IkwitAcN8pRRroFEmJcpXtJQyyVCkZ/dMNceXS0PyVBgISu61vzwMLGV5hBdUuMd8JZm0ao/maG7NA4Ct3bDF1H+tPHUtIdfFPaqK2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HhdcBXvKAHOjeRXnQDNqYRtYE6DpLidMQx5V6Wm9xSg=; b=CJEx8dAL9Eqrb4KSQJKYTEy1zeBS6BzZ07/WtWERETKh7ATe8z2VbNxIa+Sr/we6cr6EISTqzsMTn5Xr5n6TDIQLkSnGqkcNeqpgvkQpFV1Stk7p7qVKNjsxKXmTiqpVFsFKFb0eknr4hrT+4iLQJ5deVC3z+CDDpeGXhTyHGyW+UcsQzhC2bWJc8ysYZnCPzmIxhtbAUzLmWGUg4hwcsWP7YPSYSoysU9vVlMncB+RNP9I890FmHCcJgWRTzVz48a4rbjXJCu1tIbn0vF/Rk6TS71JubZnbJU/LSpW83yVUcjgc0DaVzIVM7YPDt6O1MAhEWt6IwxrQ3aeufuYTXQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HhdcBXvKAHOjeRXnQDNqYRtYE6DpLidMQx5V6Wm9xSg=; b=B733muLDt5WehOn24iLdHi2mC+sVGziaf7tVrMqFHRMjpZo65dsSsKdwJpsKYsb4t6Sp10/Q9uvsVvSSo2eB30ecePVdcMFWRaOsbsn3lt04sQWBpKr6QHkG3UK4tybS70fnxBvwVeqOIEw4oOVetLi9+HyD+rc5OEbeh+yczUk= Subject: Re: [PATCH v2 2/6] x86/P2M: relax permissions of PVH Dom0's MMIO entries To: Jan Beulich CC: Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , George Dunlap , "xen-devel@lists.xenproject.org" References: <5972ce4c-bdb0-6d07-afad-cf4dd5615488@suse.com> <457637e2-d35c-18d0-ead8-0b513b257927@suse.com> <9b7936fc-f81a-d5e7-5ceb-6e10588503dc@citrix.com> <28646a17-420e-bfaf-8f7d-6d109818ffc3@suse.com> From: Andrew Cooper Message-ID: <80dc4625-a53e-1f18-2a77-a4e45c690cc2@citrix.com> Date: Mon, 6 Sep 2021 20:23:24 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 In-Reply-To: <28646a17-420e-bfaf-8f7d-6d109818ffc3@suse.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-GB X-ClientProxiedBy: LO2P265CA0100.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:c::16) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 996d6716-c469-434c-54f8-08d9716bcfb5 X-MS-TrafficTypeDiagnostic: BYAPR03MB3735: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Zqpel8VDUBjZRih4xbXby2J2PELVLN9eAGPPtIiGdwhumNXnyxKKg3Os8LUeN5GQSNtRWZ/0WDOub2A+wZLROEB2cZKQkKIMzv4CqzK+BFJ12ztoNUuDi5iZxdABPKw0WUHK5w/xc1dso2yguat+4VO+d/dobcYIM+vp9WmIB6bfp12p7U5qvKATmLRWWsq9+Aadt63Uanb6p61Wk2AGz4ieYfnconzfYcGBA8lUCWBpH6C4/4K6A/1b5KrD6C/Nd6la3BE0rYTA+wZSQKjMVn/sbEwRqUvqY20U5hEDWVtwUaKK4w569MlTHlzUxZvMEl9FWPMRXBNq7267Sqhpdu57mxyzMvLnBMO1Mnxd07OTL8ZOJ+1Qh3FSoZw0I+4eb/ljQHsb6saghtCdSfH1/Qmb8cDwuI4+dNvKE36l3sXQER6o9QFelqRiR4RevJKcPCuyFXtU6Blpv4lUT1ev41PxkolYZQSuILyNOZBKYpBu5K+536NU2YPR/E/504Sfky2fV2GqiezFpghNfXAt8F2zFP88nl7nXxVFbQCOr5afKjewVOdodjNuH+KL5ZKbrwjOFVg2WJhhZwMiTEj+QYMX6GY5irZ0qKeoZOfMJKRrnUtexsUNg1mHY5CuloY38lTPepB5cXfkLwgZFTR9qDIYPvkng8WDvnKE5jT6TFfEQt6ytCdT9rOkk/nFwHhYK+4fkRa1bT3lSRj5F3/uo3p6h1tBcCub9Jdpdo1D7ScjWXXovK8I5HE+8BFRheeN X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(396003)(136003)(376002)(346002)(39860400002)(186003)(53546011)(36756003)(956004)(31686004)(6666004)(38100700002)(66556008)(8936002)(26005)(6486002)(8676002)(54906003)(66476007)(86362001)(83380400001)(4744005)(316002)(2906002)(16576012)(4326008)(6916009)(2616005)(5660300002)(478600001)(55236004)(31696002)(66946007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VEFyOTFsVFZjaTl6Q1JzcmhCbGFnZHpYNnFVbTNEWFBDU1NGeTIvM3NZTTFW?= =?utf-8?B?eUQraWVTQWxJWnlybGZVM0tSNTZaMGlWMWJoa1RYdW5weWxKbW9YallmU3Rq?= =?utf-8?B?TVR1WkRab0swYkQrVytPcnRNdnByNDZtNHU3WklMYmpFR096b3Q3aldzbVh0?= =?utf-8?B?Z2dGNnVFK0xSVWhGOUlKd3lINHBCMkhrYU40N2tzUUNPQTRtckhwblRCVE5Z?= =?utf-8?B?NEVrbytBZzZWcXdDUCtmTkd0M09MNlJZQ0xYcS9UN2NyUExuTjUyQmlXcVlX?= =?utf-8?B?dHdwVDllTkZpSnppa0xaN3FZUVk1THI2aHYwUEtqMDJYYkxvWnRkTURCZkFT?= =?utf-8?B?Zk1saVpVczh3cjJsUy9YdDZ5ekpwcUptc1BRUCsxWUQ0Q3NyKytCTEMyd2do?= =?utf-8?B?a0RCUE1NZjBDQ0pUeUxBWUVJQjB0WnRia1ByRUdxWkYzSjJVUm9WSnp6Rnhm?= =?utf-8?B?cHdOV2NWODVlT2tyOFpDZlRRZWtPZFdEZlA4UGVuVDhReGRtQTBXeDJsZDRV?= =?utf-8?B?TjhjYU1JVi9mUGRIdUdFNnhGbU5SVFQ0K2Y1dXRqRHFWaGE0NEh3bEUwVyt3?= =?utf-8?B?a2tFdFVCMGM3SEdtVlVmRnhZVlllNU1Da1NKMXVySWZiOGJiVDhhUUplRnBJ?= =?utf-8?B?a3AybHNiU051bEwwaVprMmQybkZsa2xVQ2hOZDdpZG9jeE0vSUlYZVNjclkz?= =?utf-8?B?SXZJdGNUYTdZOW40d3llYUpCdk45djZPdWYreHdoY0lGOWRtZW41QUpvTjZo?= =?utf-8?B?RGZ4a1NnOTNWNllzMFdKTGFKeEtZc2hLQVk1T0UxTFltQlVNRzdxbFJaR2tX?= =?utf-8?B?cXFlMThJNEFnajJBWEtKVmhWWFJnQ09DalRPN3J0NC9NMEF6aVlVc3MyaXRw?= =?utf-8?B?WFdKZ2N5RHdTWllSZHZHRmNjNCtsTFJ4YlUrSlU3YXVpSFRnd0JXZWV4dVcz?= =?utf-8?B?U3hOREFnQ2c1bVZ5eno2aWtqU2drSHZ4OEtjc2wxQjE1ZWk0K2VmVHVTejVh?= =?utf-8?B?Vkc3RjJGaDBnV05JOGhhaitDUVNETm94K1hnTEhad1l0NEJDSFVid21QTHNZ?= =?utf-8?B?RmZCZ09KQkROd2lPRkVjRnErcWVFZE9yQzRRSnlWUXMzRGxsdEZ2NFMyVmZT?= =?utf-8?B?WGZJUko5V1IxNU1ackVvY3pDZit0L0lSVjVnUmFFbmRYdHp4Rk9Pemk2SnVF?= =?utf-8?B?cll0elYydjRocHJpR1NNUjJ0dlMrcDlramxQRDdYUUNjWnh5TEkzNGpvZEwz?= =?utf-8?B?MmlGQ2UyZVNPMjZRSEVVR3g1VHFsclFUck91RUtvNU1Bc0x6b2ppaFpWVHRj?= =?utf-8?B?N09zK2JOTGN2ZVUyYXdUQmZyclZ5YXhPRXNUbnBZMWVRc21GUEtiUmlkSmFE?= =?utf-8?B?Rm0yTzZ0amMwWHpQbFpXNEZEd2lSZmxOM0NLVlRCekkrRm1pQ3ZjQThxSi84?= =?utf-8?B?ZVpaUWNKdUE1RUkzd0c5MFZRK1VVeXBzVitpMFhDRXhVTnJVN041Wis5VS9v?= =?utf-8?B?WFROYkpKUE9nV2xDdnNuRExaK2EyNHdKaUQ0YWJDWU9VTCsxMzJZQUZqdjNK?= =?utf-8?B?ZUZQMWNSVG9SMGpsdXR2bm1DU3BWU3doZ05Kdnljb0NRb09ZbTM2VVVHWlkr?= =?utf-8?B?bWlOSE16T2FNUm9LdXYzcktZYjN5MnE2c3dsSDVJNk84dGdMaVplNEhYelk1?= =?utf-8?B?eGlrd0wrdVV6R1dUY3B3U1JvZjBVWHl3ZHhSTDNWRjBEaG5yZGRVckx6YjQx?= =?utf-8?Q?pDvMxIA+3YtgogMEbqMCwGPqUVJrJb/ZXy+X+1U?= X-MS-Exchange-CrossTenant-Network-Message-Id: 996d6716-c469-434c-54f8-08d9716bcfb5 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2021 19:23:31.1002 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: eBGUND6Unvhm42Cnj2nBrod5BhUh8tP3ANN9mI3c9dal8+EoYITZzsqdA8Gn1WB1gXRnVw+IhyNRKXlocQbG/LPA5/T2VhtJhg+7n3F4GE4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB3735 X-OriginatorOrg: citrix.com On 06/09/2021 16:55, Jan Beulich wrote: > On 06.09.2021 17:48, Andrew Cooper wrote: >> On 02/09/2021 09:33, Jan Beulich wrote: >>> To become independent of the sequence of mapping operations, permit >>> "access" to accumulate for Dom0, noting that there's not going to be an >>> introspection agent for it which this might interfere with. While e.g. >>> ideally only ROM regions would get mapped with X set, getting there is >>> quite a bit of work. >> ? >> >> That's literally the opposite of what needs to happen to fix this bug.  >> Introspection is the only interface which should be restricting X >> permissions. > What agent would be handling access violations in Dom0? None.  dom0 really shouldn't have any NX mappings in the first place. ~Andrew From xen-devel-bounces@lists.xenproject.org Mon Sep 06 19:27:33 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Sep 2021 19:27:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180230.326820 (Exim 4.92) (envelope-from ) id 1mNKHE-0003wR-Qe; Mon, 06 Sep 2021 19:27:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180230.326820; Mon, 06 Sep 2021 19:27:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNKHE-0003wK-NN; Mon, 06 Sep 2021 19:27:32 +0000 Received: by outflank-mailman (input) for mailman id 180230; Mon, 06 Sep 2021 19:27:30 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNKHC-0003VO-Rl for xen-devel@lists.xenproject.org; Mon, 06 Sep 2021 19:27:30 +0000 Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 76499510-0f48-11ec-b0b7-12813bfff9fa; Mon, 06 Sep 2021 19:27:24 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 76499510-0f48-11ec-b0b7-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1630956444; h=subject:to:references:cc:from:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=YiUT4mNjlZ92jk3RwIuC/v40/jTL0JJz3cuHc6HT3CE=; b=bqZvMwPik9E/dlI6xjSQhFZ6z/XLBBeAYbgeT4tTZyjFN5pFRl+g5h3Z rLa+h8b4Jsor1gsV6S500phZbsEIUCpjilqowr92Uz7EzH9OCuPxZF/AF wNleulWBv89id2uaz4YL/BobadM+kx3dvKZCD2TmagWbVfL9cfvXrPkN0 M=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: muftSrz5kPvlD9/8HA8ixQ+XB8VqvebWULeKAvwli3Goy1hGAGRhGgS9qyErASdkKDgksYD4tW 3UXeWt4I8W+wHPjc0R/EmDzZlg8THlv9mUUV86YVpKhlGR5yWdvw9BERKagx/hC1GvCgzciHnX Nq+JRGPgDWzvnclp+k1xNxqysOLssoLpbmiT0fAKme1nFwiEGzuEP/3d7LhFiD4vedwv2ZYu9R L+ZZmlJFEdXbPdqPxUcBnyi0vTRu6FppTUEdIVfKvzQxVosCXG9//LYvaqUHl3/0gx+BVPwEfi 3F4X5CoaiBFy9pk81shadGVy X-SBRS: 5.1 X-MesageID: 52117783 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:vFpb9a9FPigGqSG8CoZuk+FPdb1zdoMgy1knxilNoENuHfBwxv rDoB1E73LJYVYqOU3Jmbi7Sc29qADnhOFICO4qTMuftWjdyRaVxeRZg7cKrAeQYxEWmtQts5 uINpIOcuEYbmIK/foSgjPIaurIqePvmMvD5Za8vgRQpENRGsZdBm9Ce3em+yZNNWt77PQCZf +hD4Z81kGdkSN9VLXEOpBJZZmOm/T70LbdJTIWDR8u7weDyRuu9b7BChCdmjMTSSlGz7sO+X XM11WR3NTsj9iLjjvnk0PD5ZVfn9XsjvNFGcy3k8AQbhHhkByhaohNU6CL+Bo1vOaswlA3l8 SkmWZuA+1Dr1fqOk2lqxrk3AftlB4o9n/Z0FedxUDupMToLQhKQPZptMZ8SF/0+kAgtNZz3O ZgxGSCradaChvGgWDU+8XIfwsCrDv2nVMS1cooy1BPW4oXb7Fc6aYF+llOLZsGFCXmrKg6De hVCt3G7vo+SyLbU5nghBgr/DWQZAV2Iv/fKXJy/fB9kgIm3UyR9nFohvD2xRw7hdQAo5ot3Z WNDk0nrsAWcie6BZgNc9vpevHHf1Aldyi8eV56EW6XZp3vBEi936IfwI9Frt1CK6Z4gafbpv z6ISVlXCgJChrTNfE= X-IronPort-AV: E=Sophos;i="5.85,273,1624334400"; d="scan'208";a="52117783" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=I/p6R6dXyjhuqaq8YcR+fIG9mhyXkOUAurGrEy4KswqPdaDfvEC8kU2w0D4PDQXnvrRN1qua4A2xSVzSVZJIkdEe+4nhT+k7KsQ2ygfYXiXSP6dz9oa+/q+67BuTHb9AJYohML78/DP4++KmMUtmqF1+8SjHkBaMtSFy5NjvpmDH8v3XJ5MLnM0OCbWTZYm0thhVfYdy8Hag95jm6NJsLtDMOPoP2M2SiuVgSo/wXxu0030n2XtTFNcfT9bLNdctmZ3EuP732zryuOTG6xTs6avVsFMcUJS4Z95dalICpBD6JZvovZuS0mjTaxWa+pgQZaq2z3C5qZD/K7cAQJ5sqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=YiUT4mNjlZ92jk3RwIuC/v40/jTL0JJz3cuHc6HT3CE=; b=lm83mPmT8xLKC+iEsopt4sfgdY5m3voxhqYD4E1/mulXQ3fy0dJykKotMTbvUatWeZBLpfB2bGAvRYNCzg9gHSXtNE4fW7crPGOBp2r0NxOL1jWrY4QvyhNdPoBgFotXCxvoHjAWiiPdM7D4sL0hqDOfm8yLs6WiG+6OfDTI6tXWT5wjB+z/jDMBOgXhvn70Qnb8tclHxvFMibrWbsvpFdaSjjhbEQBOfbwErN1b+G1SjY+fCoWVgxmioMlfWa/lCSDcrfxEfDPjvIkgMSC3LAJeKsFDI2ces6wCppSd1rz4wyqzNQ81t95WtSuXY7G+MU/vrSFOqIV8nfx7qVAInw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YiUT4mNjlZ92jk3RwIuC/v40/jTL0JJz3cuHc6HT3CE=; b=rK7GqcBhPhf+jCDtJyCMZXbEAWx/r8UrO2FCakqhlgO8XF53exF3VVaB42E29YcVEu8h2hrXoMI2B9L/YXcgNGGjHpsou2Hml8gRLI0FQe3BPzTkk6wdzT1YJfoiOguttz0Bgq1fyOfe1yyRX84mHY7rn+0s0BeayF89CSfsZJs= Subject: Re: DomU crashes when restored if it has pci passthrough To: Bhasker C V , , References: CC: Wei Liu , Ian Jackson , Anthony PERARD From: Andrew Cooper Message-ID: <65f4630f-546e-57e8-7147-b5add37d594e@citrix.com> Date: Mon, 6 Sep 2021 20:27:15 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-GB X-ClientProxiedBy: LO2P265CA0456.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:e::36) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6221555b-8e66-4d15-1bcf-08d9716c590b X-MS-TrafficTypeDiagnostic: BY5PR03MB5000: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:5797; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: eFNOS8bYy2gBtslgL45WsNV7fJjcEwe/qiNHKoXk+07DMLQIjHAxKfapJiRCihaEICAM7amsw7zFKl6dTtwMFkElHe3F0epm3/9PHWlVSsubK1k2yk32UezesoNW4+87dIdBIIC0APWx5U8XffC+/5NuJAZtqzcl2ieIxlcdJQWVmTVp7SZgcegb7z/8XWSbyuBApzGJy3V6TZHFe90fxbsZpr9RL4gE+dOOh77G6e2R3ZjVzsZMEdDTfzoFgih4dhG4f6uoNCNAhgcBGxmrx2ilIL1gBNvwBzVWWzyOHbsTOD6mzMkiAXAjPoeTpGlCdEMx/piTWfUxuL95Q11Xgwu/bgLm7yDa+CaU/BV7Lz1XH97jqeQ6mLYuOALYajWAUQYjL2FpJ8xi9T6YLP5Y1yQPM6uTVeZwCgA0MTbqMJbdzoG9JJAiW7FHblxYkcA2r9T19OL2Wkgq9IoiYTBZNFtSh2S/StU838nkU6KEYPaG1zLLigU/fXZBhkOpzhVJzGMlf/tFAGwECyKMsq0SRFhIG4lzfst4SJJqnzMSw8IAsC0qwJptt5zjN2DMwissbzQwdsEyBoSFAxaOUpsZBMJd9aGkreq9xqExAWwbxLnuSjRTSjoLzvfKGYG0eVIoffgn0oSUB9OBQu+UY3MFk8xeM5s1YztpBzfdnFYC0EVSOPCAur90fwHqlGu7VmAKJvXjxcuJMn2qGInQcLgBoOTuVF5ekDw2wr/pNZADOYUOdGH51p/8eptuu/rKYjcv X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(39860400002)(396003)(346002)(376002)(136003)(4744005)(66476007)(83380400001)(2906002)(8676002)(8936002)(66946007)(66556008)(5660300002)(31686004)(107886003)(16576012)(31696002)(6666004)(36756003)(2616005)(54906003)(55236004)(478600001)(316002)(38100700002)(956004)(186003)(6486002)(86362001)(26005)(53546011)(4326008)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VkFSQjlFMjVOZ1lreVF5Y3ZqQ0lUR0owZVEyUlg3MnpTbDdQM2JYRWdodnlN?= =?utf-8?B?dEh3emtrWVc4OFBwTXhvZ28zcUljdlVQdTV0S0NtaTBmRFo0b3RHbitGaW9m?= =?utf-8?B?S3ZUOVgyNDhueWUyNHBzVDZYZUNadkk5eXNCS3JWQzA1bkxwZmpUbVZtSGdv?= =?utf-8?B?djNyU2lnZ3BUN2xrTVM3Ly9hNXV1SjBPajdJM2RQU1pYWWc2R1ord2g0ZDNj?= =?utf-8?B?YVMwelY4cWdVbEw3elU1N3JvU0taT1RwRk5oWG9tZkFTUFNCTkhUS0E1MlRt?= =?utf-8?B?RDNXRmlrd0N5cjBOMnBoMVVGS2lwZ3ZnZmRoVm5tRkRuVHlFd2QxNDFIWDRV?= =?utf-8?B?Wkw3TUI3Znd0UWJNUHZwbTJia2p4bXZyUTdzcWJlcWRxN1pOZnVwNUREdGt2?= =?utf-8?B?Y1FBU2xmMTBkeU1LcllndnZDS0ZCNUo1Z2I2ejZQcWZoN29pV3Z4YVJVTjNv?= =?utf-8?B?ak9Yd1BzMlpETGlDNWtIT0IrMWkrMUl3SGpkY0FFdHZaYVcyMkdCUW5rS1hT?= =?utf-8?B?QXZaTzdKSFVSZzdSMzlDMXl3UzNuVWxYemsxRnpOREZiQWZtaHgxd290bkV0?= =?utf-8?B?L2hyY3lXZGhzbnJCTDhZREIxN2FwaS90RkNmdzUyVUYvMUVpYXRWK0Q3Q3g2?= =?utf-8?B?d2VraDk0b0dJQktsNkNVakhzdlo1N2orQVIyc1FMWDArQVZCdGpGK0x6b24r?= =?utf-8?B?aDMzWTBkNDNlZytKN2JmUzFmbWdLdVY1NTFDQ25EaWhIblFRKzk0b3V3YjJQ?= =?utf-8?B?cFpwVTJPVnhBSTc1bVVOY2diSU1EcFljWVZ0Y3ZCSWRrcUM1THE0T2N3a0t2?= =?utf-8?B?dmZIM1Zwb3lNZ3VYcHdDN0EwejJ3NzFCRnovZ1hXd25rZk04OVV6OHN5dklj?= =?utf-8?B?RWdZNnZhb3RXN0NRbkNwQS85TGFKQWRyUUxwR1FlODFZK1AzSHlsQnU1N1dl?= =?utf-8?B?azdDcUJaaUc0THNZelpxRFJUSmdwd2JFTm00UnlhK0JNbTgwcy9WY1JNQzIz?= =?utf-8?B?eENsSHBZMjlWZVl1aTQ0Z2pnN2s2R29COHQzL1dVK0pDSWlDdUFHVnFVWi9O?= =?utf-8?B?L2VhblVQaHV2RHRkc0doY05HYW16eHZxejJpMXMxNHlLOEVLcW5mQllyOFVY?= =?utf-8?B?dzNtU3ZGNktlcW5KRVU3SnFsRjQrZ3lZSVhoak85YjIwNXgzckxTMXYxbW1O?= =?utf-8?B?c2xHMGZLTWhiR1h1MlZWRTliS0w1MjdOT0pkbEJ1Nk91aTJ0bloxeTVZSTAr?= =?utf-8?B?b3hUQ2pmWTRtZmhqM0Zyc1I0dTAvbDJMdVNnZmMzekc4ZVVlRVVLdElxcCtn?= =?utf-8?B?RS9BOVl2dDFRcTZJS2x1dUtrcmNrSUN2eFdCSjZENFdNb00rZGR2ZSswaUlY?= =?utf-8?B?UVdFbGpEdVR3MGZSUjJhZVU3dFp2TEZKenFPMW4wYkQwQ3lza3hrOC8vazVF?= =?utf-8?B?NkhYMlk1bWxpMExMb3piM1pZUC9lQ1B3cHpTeENIMUg4Y1F2TnVPTGtUby9H?= =?utf-8?B?eFhCaXN6ck95V2tQV3ZRbkNZM0xwdGJMcWppVFE2dnpDQlg1d3ZaU201aUxX?= =?utf-8?B?SlhIdjZCMTFhemk3enlyUjQ0UXdVSGVqNld4NUlWYm9FR2laUHZYc0h5RVc2?= =?utf-8?B?YmphVE5XR2UvWXoxOTY1eXNQQXlhZDVTcTRCeE9TSlBuTk9uaWNsRzVBM2RS?= =?utf-8?B?VCs0cGx6ZjgwbEwyK2ZyZjY0NitmNUQvTlduSW1yUThXUFlER1R1Qi9mbThv?= =?utf-8?Q?Pr82dw0aXxI4Q+07sRWbh1/o+e/ML6OGVmgTpxc?= X-MS-Exchange-CrossTenant-Network-Message-Id: 6221555b-8e66-4d15-1bcf-08d9716c590b X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2021 19:27:21.5631 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: LXgfyeaaLSrj5imdTwnouNIIU4vfJ/FkHQEhEtoipGOtncKN4khFUcCbJ/dZTeiCBqD9VF42AJn7kJ17McBvxAteXn99IMbrBnVzzpno1Ms= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR03MB5000 X-OriginatorOrg: citrix.com On 06/09/2021 01:06, Bhasker C V wrote: > Hi, >  I have a domU and that domU has network vf attached to it. >  The save and restore leads to crash of the domU after restore. >  Am I doing anything wrong? xl save/restore really ought to give up early and refuse the operation.  CC-ing the toolstack maintainers. It is an error that it continues and creates a corrupt vm image. ~Andrew From xen-devel-bounces@lists.xenproject.org Mon Sep 06 19:54:08 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Sep 2021 19:54:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180255.326831 (Exim 4.92) (envelope-from ) id 1mNKgj-0008QE-4T; Mon, 06 Sep 2021 19:53:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180255.326831; Mon, 06 Sep 2021 19:53:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNKgj-0008Q7-0Q; Mon, 06 Sep 2021 19:53:53 +0000 Received: by outflank-mailman (input) for mailman id 180255; Mon, 06 Sep 2021 19:53:52 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNKgi-0008Q1-1G for xen-devel@lists.xenproject.org; Mon, 06 Sep 2021 19:53:52 +0000 Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 27b88fce-0f4c-11ec-b0b8-12813bfff9fa; Mon, 06 Sep 2021 19:53:50 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 27b88fce-0f4c-11ec-b0b8-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1630958030; h=to:cc:references:from:subject:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=bwrJ/82EidgVnL+FTnzOnWMM8fNlJ/yK8puMT+f780s=; b=KrXajhqxGyp0g8XIpCYkNwcTJi6ju0oK7+cXZv8WebSwOI2D42ewF6RW jhz1FIy6hGJ31PBA+Z25QHd+L30CAU+cBZzn09obS3wBqsnlpa1Y+WzcW 904UzDI6QY1r5cAnbvIO78BKUOQibvxWzuTgakbENuQXIaAPp3q+OGfgb g=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: IOkwJFIQ3Kn6ZeoXcmOr5/oyU+86gutetzvZrJ3XG7s20uOYXKsj8TpuI9E9+MtUzwF8UreioB ZeViExfhPgtal+nt+SAvgEjEr4vgVAKT+cGVLK2l3WE91a38fCP6GWyo+Vj6u+pXJhYxbBrxjl iOBsIAVXJANghcWmTZiSMXVCaBHVIodRGmBV9FjC6XFGbjhtNl5lRIOHMmhvpAqDbgJ7Ji+L3F Id1bvtuBhGUTdnqOxYDugAAdeAcZu8KcvlE33enX8kK2fg1I442PRMjvOttYHv+WrxRMF2tUbV /2d8jgPw3njOIm8R2OKVbXU8 X-SBRS: 5.1 X-MesageID: 52509495 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:kKuF+61PuK2X2RSyQlVg2gqjBTtyeYIsimQD101hICG9Lfb3qy n+ppsmPEHP5Ar5OEtBpTiBUJPwJU80hqQFn7X5Wo3SIzUO2VHYUL2KiLGC/9SOIVyEygcw79 YHT0E6MqyMMbEYt7eI3ODbKadZ/DDvysnB7o2yvhQdL3AZV0gj1XYfNu/yKDwHeOAsP+tBKH Pz3Lsjm9PtQwVsUiztbUN1LtQr6ue7267OUFojPVoK+QOOhTSn5PrTFAWZ5A4XV3dqza05+W bIvgTl7uH72svLiyP05iv21dB7idHhwtxMCIiljdUUECzljkKNaJ56U7OPkTgpqKWE6Uoskv PLvxA8Vv4DpU/5TyWQm1/AygPg2DEh5zvLzkKZu2LqpYjDSDczG6N69MhkWyqcz3BlkMB30a pN0W7cnYFQFwn8kCP04MWNfw12l2KvyEBS09I7vjh6a88zebVRpYsQ8Ad+C5EbBh/374ghDa 1HENzc3vBLalmXBkqp/VWH+ObcGkjbIy32BXTr4qeuon5rdTFCvgslLfUk7zI9HMlXcegc2w zGWp4Y342mAPVmNZ6UqY86ML2K41f2MGbx2VSpUBza/ZE8SgfwQqHMkcIIDcGRCdE1JcgJ6d j8uG0xjx96R6upM7zU4KF2 X-IronPort-AV: E=Sophos;i="5.85,273,1624334400"; d="scan'208";a="52509495" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PzjeqbfEaMkqdKFIf6Z7afvOHn8asoEZvQbT6Rck0lmMWwji3P1hHQhstQDSyuJ6gk+mWx9GyxsPKWGFh1cy8t9rqjSRDCN4KX+E77Yvy9nBb43mZnDEZ6MHSEOwhG2OkdZZth6NO+B0Ml0NVVZjs2IaN7/35yZHYrVSLyeLM3GvKoQJdqm+rfF4SvGW4a94UrUt6SsgES/tuxBAVr6L8JR0fpUwDOyZJ+6Pqe05wu+Xd65z2Iqsxpf7kdn7W1AhsU6tUdR+2Gknym/gLnig6B4M4dkj3d7Cvxl74WOG9z+KS84DY+qTHbtckzxVcXyQlWCI2ibmWiKxivbcfPE06w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=JUF5ZQ9qHhiOdd1nZnSVwMywJawM174/ekfRo7ZYZ6M=; b=F+ngGyUtzO8vsg4gG2Fd07aR9CD/S0N+tGkS0MBeuHEIVagmSm75qcFAkprVXJkiryOK0eAByo94Otc1gaqXAtvr9WIT7fM4VNFtXOhrouxYYhk0BdF6q3iVpSWXoLOAyhdfruQfT9m84eS94S+p1ct1A+r72ziJNzrSenIJ5Na9FmEOcu5sCdj8gI4BSWC+nJRqSxwVXZJFSFdyzlSsUDtgcDnhCT9N1OQxQq5i3kxmT67ts+pxUkCh7P2aeZah2z7KYt7vNleQ2Z3FYgG2fEjVwDjPoNgeg4gnopD19kpm6OKqdGbIqMhojFLKdceonSa0URrNfRcUcAMv+XSsbg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JUF5ZQ9qHhiOdd1nZnSVwMywJawM174/ekfRo7ZYZ6M=; b=WkJtN2bBrw7IT0pRt35GuXahFfBbABdQ3dPOuQHj4B4Bua/yBp6P4aMD+/vXur3YqN56tsnN8bNAapiAKuf610y6zdX2H/NGOQW3D9EGzB26hS1/EUkx1INe88Vd1nVfuDqKFaXuZripmoSovovvFQmYZPG80HRiFj/ux9OhZBY= To: Jan Beulich CC: Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , "xen-devel@lists.xenproject.org" References: <93ecc397-1293-69b1-e70d-3c5f9317229a@suse.com> <7f56c625-eee6-31c4-2d6f-bd7334867d83@citrix.com> <5d69d4c0-7a04-c3da-f971-616363c6d63d@suse.com> <62cb78c9-f4fd-76e7-225d-bc575f10850f@citrix.com> <818cc08e-8372-35c4-935f-86a87cceec75@suse.com> From: Andrew Cooper Subject: Re: [PATCH 2/4] x86/P2M: relax guarding of MMIO entries Message-ID: Date: Mon, 6 Sep 2021 20:53:38 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 In-Reply-To: <818cc08e-8372-35c4-935f-86a87cceec75@suse.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: en-GB X-ClientProxiedBy: LO2P123CA0042.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600::30) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c14ef7f8-3948-48fc-e7e9-08d971700853 X-MS-TrafficTypeDiagnostic: BYAPR03MB4120: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: eBVRbVfcZPgqWF2GZ6GZTrfb2LM9BcDMwWqtR6fjSXyOnHyWaBoCzwAoIDwyY9UY6L2sWPfPkHjpmNpFZnpuUjCibCI/eVfkgnn7q5+lG3uGIK5SEgZXUeKkKhRBtP76ikCAxt9nePVoMsSftJV0xWOhgg2NoPlRWcbI5mjjTAQscQa5A7tkltqT1YEN1G5W9xXUVCAbkxjFzsE1N3v4LJuWLfwOAsLQduv5s23r5qWEmLeM0YUmE2hseSqRiRao12iqB/9czxxuL7AJnfV43Pd6yCM3KSBi0oY/2xCa6ID+qb3gj/Zr3cQwlSzmF8Xj5lP5UpMsRpv7RML3y/sPDNnb3a7HEHiQ4rO9+xvES1eVnZefNpXTqHuQ/6EAjQDinlbgicptONFA37QSytCQMn49WNa11aeQKvIOTi7hHh4Ji50nknmiOAVdYMm+Cvu8r9eux9+8AexNRy5aLrZQZVd/CZ+hHHQPay2V2kHqliNQDgj9YGJiArwZEuDLyMk8gFS5jllWV2LsIphm/zd+Mnfa/cwXviIHtrsVVKps9v7hj8mCoFlFiAtMTv+AD65eV1opkZsMhcLseNv/K2MTtlYREaDNGdy2M4x1rF0UcyicWe0glXF2rMBw4KqeNJk/ts+vIgLUmZsja5C2lTguTmv1CfIuA4bztqGRdlF6fk2On9EebPQHzcpTtVUo/YHGAJT7nEt8Q96gFzWTFxGk4C0BnfqF8jq4Tm6yZMclKdhNMiwDh6ZtnlXif+Zf5Pjl X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(136003)(366004)(346002)(376002)(39860400002)(6666004)(55236004)(2616005)(16576012)(38100700002)(478600001)(26005)(6916009)(2906002)(6486002)(83380400001)(36756003)(5660300002)(86362001)(31686004)(53546011)(66556008)(66476007)(66946007)(31696002)(4326008)(8936002)(186003)(316002)(956004)(8676002)(54906003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dGFWdDhOZG8rVHpvYXFxcVlTeXMxL1QxTGFJS0RGQWVIbW4vUE5COTE2NXFQ?= =?utf-8?B?Wkg3aGsrWkJvclNrRERkU1VkamhrRTIyR09oQ0M3N01TaTh0NEdKTmJpeGZ2?= =?utf-8?B?dTJsMVdNMDhuaXU2V0Y5Y2pUdmkxbWllR3JhM0c0aGZhN01QbHRzYytmY0RK?= =?utf-8?B?WlNmbFA3SklZV2MvbVo2b3dQbXcvQ0liREt5MXNHVUdyNlhJbnBhcXpwSHJS?= =?utf-8?B?TnV1YU1mMXovQmwvZVd4elk2eHFIbVFjRGtBRitidmNHRFp0YlVoZE85WDVK?= =?utf-8?B?NXVQVzFtN3lYc1dqVjhJSTk1SWMzakRwUEFvazVZaXE4R3psc0J3QWRRSEMy?= =?utf-8?B?WmxUVWYwWi9oUXI2K04zbG9VU1dRUWdsUWxlUEhwU0V0M1pIa1VJbDFGc1h2?= =?utf-8?B?Y01YTmExV3NKemlsVVVUQ2ZVc01qQW4zNWdkS3dFZ0Q3K0grdDJ0WS9LNFFz?= =?utf-8?B?bVJJTnVZakc1ZEtCMUE5ZmZ0WHU3N0pKVVcxWU9aZkd6ZXFMMHpwR3VRNGpB?= =?utf-8?B?YjlGblFvajhzcmdZL0tQREx4Qm9tbnpGeW9XRm85YUt3U3hDakVST3Nqc2Vh?= =?utf-8?B?eWFvdm9JbloxZXo4cjdWTVdqYm5ORlUzd1A3anN6TFdHSTR2a1R4akFRZkZ0?= =?utf-8?B?d1k3TUpOTFdTTktrZ1RnbWwxZnZxM1FCZkZJWWR3MlJDNXN0NUZWMkx0T2ZE?= =?utf-8?B?L1I4L1hiOGN5dnZLajlmZDlnMWpDSDNEQnVjU0dvK2w2TFZUNFllNDdjVnV6?= =?utf-8?B?T0J6RVIxMXRQb3Nvd0RPU1hvSzI3ZE9rVlhiU1JrSkhCcmREN2xRRWlYQ1Nv?= =?utf-8?B?MjIxV0JqcEgrdi84NjFiT25tL0UrU0tWRVkyUVhVNFFvakJxdTJzSDMwMkFE?= =?utf-8?B?NnpicW9xTnplSHVYVXFHcEswdmI5dmdlcFBDQi9kSGRwSkNlLzVrSERiV1F3?= =?utf-8?B?NUtsZmpTdjFtZFYyeU1hcG81MG5WVGlvMXlkcHAxQXlEZDN4Z2FNZG9OT08x?= =?utf-8?B?NEQrK1JCQ045bUY0azlpUUFPcUtSa2pFNkpxM1lkVHE0S2R2MEVmdEZNaXZS?= =?utf-8?B?OFVmQUxWNklwbzZ6V0NVSUQzaWdsclpLK0NRdXZ5MzlKbWRHNEVEb3gzUXpM?= =?utf-8?B?R3BqNUZvQlpUUkxWaHZtRU44ZjFTenUrMDh0YzlXNFcrQitxVEJ1eGIweWRm?= =?utf-8?B?UmpUaDVuVXI4eWcwcENiUXFHM0hwRjk0dUlJQW5UZ2JQbjRDL0I3QkVQTmgw?= =?utf-8?B?cXNaSXdGRlA1T2s3RktPcnZocjlMMXpqRmkyUzBROUpNVlRNM2hMTE83YTA4?= =?utf-8?B?UUpXdGVpencxZTMyM0dlcHlrODlES2ZzUkxEVzJlYVVaRjJ1T1BYV2lWOHpv?= =?utf-8?B?dEJCeEtmeS9KSkMvenVpTmJRQVMyay8yQkZIeW1rVmpuK0cya2hWVEhrM2NX?= =?utf-8?B?b21PbThCUXAvZk5XOXNoT3NFWmRMQnBSdmRrOXF1SXFtSlpnWlVDYWZ4RFIy?= =?utf-8?B?YWRCS3oxT0NkbVk0YTNxa0RuR3hkcEM2REo2aWFHbXI0VWlSUTBEYTBKVStT?= =?utf-8?B?OUZOdFZTbGtKWnBucHFWbXBiUWlJaEJ4VHowL3ZGNXhaeDF6V1UzcHFSVnRm?= =?utf-8?B?Kys2bEZGYmIrS0Y3eGRiTk91Qk1hSTJHNWVkc216N1J3VUxOc2hJaHFmRkRH?= =?utf-8?B?ek5mNkZNZkdzK0p5T3RoWlJPKy9iMHdnYW1aZEJ6SlZzZlFHaFNGaUdjUnhG?= =?utf-8?Q?Iwj4mlC7kZS19pPzIHLowvXmVDq6WuOp3Vi6Qko?= X-MS-Exchange-CrossTenant-Network-Message-Id: c14ef7f8-3948-48fc-e7e9-08d971700853 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2021 19:53:44.2056 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: R21Ot0oL9zY59GAHlnBrvjYNmaWlI6fnETb5ACFBroFhixRBjxho9//pCEF6Cl+X5y8fMLnX2hacOdvM6MJwMa71Emr5PYjqOq0lNtD+XpM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB4120 X-OriginatorOrg: citrix.com On 01/09/2021 14:08, Jan Beulich wrote: >>>> Restricting execute permissions is something unique to virt.=C2=A0 It = doesn't >>>> exist in a non-virtualised system, as I and D side reads are >>>> indistinguishable outside of the core. >>>> >>>> Furthermore, it is inexpressible on some systems/configurations. >>>> >>>> Introspection is the only technology which should be restricting execu= te >>>> permissions in the p2m, and only when it takes responsibility for >>>> dealing with the fallout. >>> IOW are you saying that the calls to set_identity_p2m_entry() >>> (pre-dating XSA-378) were wrong to use p2m_access_rw? >> Yes. >> >>> Because that's >>> what's getting the way here. >> On a real machine, you really can write some executable code into an >> E820 reserved region and jump to it.=C2=A0 You can also execute code fro= m >> real BARs is you happen to know that they are prefetchable (or you're a >> glutton for UC reads...) >> >> And there is the WPBT ACPI table which exists specifically to let >> firmware inject drivers/applications into a windows environment, and may >> come out of the SPI ROM in the first place. >> >> >> Is it sensible to execute an E820 reserved region, or unmarked BAR?=C2= =A0 >> Probably not. >> >> Should it work, because that's how real hardware behaves?=C2=A0 Absolute= ly. >> >> Any restrictions beyond that want handling by some kind of introspection >> agent which has a policy of what to do with legal-but-dodgy-looking acti= ons. > IOW you suggest we remove p2m_access_t parameters from various functions, > going with just default access? p2m_access_t was very obviously a bodge when introduced, and I doubt it would pass today's review standards. It is definitely a mis-design, given its ill-specified and overlapping semantics with respect to the p2m type. > Of course, as pointed out in another > reply, we'll need to split p2m_mmio_direct into multiple types then, at > the very least to honor the potential r/o restriction of AMD IOMMU unity > mapped regions. (FAOD all of this isn't a short term plan anyway, at leas= t > afaic.) I don't think that will be necessary. IVMDs are almost non-existent, and given how many other areas of the AMD IOMMU spec are totally unused, I wouldn't be surprised if r/o unity mappings were in that category too.=C2=A0 There's no obvious usecase for r/= o, as anything critical enough in the platform to have an IVMD in the first place will also be non-trivial enough to require bidirectional communication somehow. The unity mapping only says "this device requires read-only access".=C2=A0 = It doesn't say "this must be mapped read-only", and it is legitimate to map a r/o unity mapping as r/w. If such a case actually exists, there's clearly one agent in the system with r/w access into the r/o range, and mapping it r/w is equivalent to the "IOMMU not enabled in the first place" case which is the default case for most software for the past decade-and-a-bit. In other words, I don't think the r/o unit maps on their own are a good enough reasons to split the type.=C2=A0 If we gain other reasons then fine, but this seems like chunk of complexity with no real users. ~Andrew From xen-devel-bounces@lists.xenproject.org Mon Sep 06 20:47:45 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Sep 2021 20:47:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180262.326841 (Exim 4.92) (envelope-from ) id 1mNLWl-00068Z-8F; Mon, 06 Sep 2021 20:47:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180262.326841; Mon, 06 Sep 2021 20:47:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNLWl-00068S-5F; Mon, 06 Sep 2021 20:47:39 +0000 Received: by outflank-mailman (input) for mailman id 180262; Mon, 06 Sep 2021 20:47:38 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNLWj-00068K-VM for xen-devel@lists.xenproject.org; Mon, 06 Sep 2021 20:47:37 +0000 Received: from mailhost.m5p.com (unknown [74.104.188.4]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id e44ad8c3-e821-4c62-9ee6-fe2b280bd656; Mon, 06 Sep 2021 20:47:36 +0000 (UTC) Received: from m5p.com (mailhost.m5p.com [IPv6:2001:470:1f07:15ff:0:0:0:f7]) by mailhost.m5p.com (8.16.1/8.15.2) with ESMTPS id 186KlQcf066300 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Mon, 6 Sep 2021 16:47:32 -0400 (EDT) (envelope-from ehem@m5p.com) Received: (from ehem@localhost) by m5p.com (8.16.1/8.15.2/Submit) id 186KlQdT066299; Mon, 6 Sep 2021 13:47:26 -0700 (PDT) (envelope-from ehem) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e44ad8c3-e821-4c62-9ee6-fe2b280bd656 Date: Mon, 6 Sep 2021 13:47:26 -0700 From: Elliott Mitchell To: Jan Beulich Cc: xen-devel@lists.xenproject.org Subject: Re: HVM/PVH Balloon crash Message-ID: References: <84d9137e-a268-c3d8-57d2-76fb596e00d3@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <84d9137e-a268-c3d8-57d2-76fb596e00d3@suse.com> X-Spam-Status: No, score=0.4 required=10.0 tests=KHOP_HELO_FCRDNS autolearn=no autolearn_force=no version=3.4.5 X-Spam-Checker-Version: SpamAssassin 3.4.5 (2021-03-20) on mattapan.m5p.com On Mon, Sep 06, 2021 at 09:52:17AM +0200, Jan Beulich wrote: > On 06.09.2021 00:10, Elliott Mitchell wrote: > > I brought this up a while back, but it still appears to be present and > > the latest observations appear rather serious. > > > > I'm unsure of the entire set of conditions for reproduction. > > > > Domain 0 on this machine is PV (I think the BIOS enables the IOMMU, but > > this is an older AMD IOMMU). > > > > This has been confirmed with Xen 4.11 and Xen 4.14. This includes > > Debian's patches, but those are mostly backports or environment > > adjustments. > > > > Domain 0 is presently using a 4.19 kernel. > > > > The trigger is creating a HVM or PVH domain where memory does not equal > > maxmem. > > I take it you refer to "[PATCH] x86/pod: Do not fragment PoD memory > allocations" submitted very early this year? There you said the issue > was with a guest's maxmem exceeding host memory size. Here you seem to > be talking of PoD in its normal form of use. Personally I uses this > all the time (unless enabling PCI pass-through for a guest, for being > incompatible). I've not observed any badness as severe as you've > described. I've got very little idea what is occurring as I'm expecting to be doing ARM debugging, not x86 debugging. I was starting to wonder whether this was widespread or not. As such I was reporting the factors which might be different in my environment. The one which sticks out is the computer has an older AMD processor (you a 100% Intel shop?). The processor has the AMD NPT feature, but a very early/limited IOMMU (according to Linux "AMD IOMMUv2 functionality not available"). Xen 4.14 refused to load the Domain 0 kernel as PVH (not enough of an IOMMU). There is also the possibility Debian added a bad patch, but that seems improbable as there aren't enough bug reports. > > New observations: > > > > I discovered this occurs with PVH domains in addition to HVM ones. > > > > I got PVH GRUB operational. PVH GRUB appeared at to operate normally > > and not trigger the crash/panic. > > > > The crash/panic occurred some number of seconds after the Linux kernel > > was loaded. > > > > > > Mitigation by not using ballooning with HVM/PVH is workable, but this is > > quite a large mine in the configuration. > > > > I'm wondering if perhaps it is actually the Linux kernel in Domain 0 > > which is panicing. > > > > The crash/panic occurring AFTER the main kernel loads suggests some > > action by the user domain is doing is the actual trigger of the > > crash/panic. > > All of this is pretty vague: If you don't even know what component it > is that crashes / panics, I don't suppose you have any logs. Yet what > do you expect us to do without any technical detail? Initially this had looked so spectacular as to be easy to reproduce. No logs, I wasn't expecting to be doing hardware-level debugging on x86. I've got several USB to TTL-serial cables (ARM/MIPS debug), I may need to hunt a USB to full voltage EIA-232C cable. -- (\___(\___(\______ --=> 8-) EHM <=-- ______/)___/)___/) \BS ( | ehem+sigmsg@m5p.com PGP 87145445 | ) / \_CS\ | _____ -O #include O- _____ | / _/ 8A19\___\_|_/58D2 7E3D DDF4 7BA6 <-PGP-> 41D1 B375 37D0 8714\_|_/___/5445 From xen-devel-bounces@lists.xenproject.org Mon Sep 06 21:14:59 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Sep 2021 21:14:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180271.326853 (Exim 4.92) (envelope-from ) id 1mNLx2-0001aJ-G9; Mon, 06 Sep 2021 21:14:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180271.326853; Mon, 06 Sep 2021 21:14:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNLx2-0001aC-DA; Mon, 06 Sep 2021 21:14:48 +0000 Received: by outflank-mailman (input) for mailman id 180271; Mon, 06 Sep 2021 21:14:46 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNLx0-0001a2-PB; Mon, 06 Sep 2021 21:14:46 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNLx0-00050h-H5; Mon, 06 Sep 2021 21:14:46 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNLx0-00032T-8G; Mon, 06 Sep 2021 21:14:46 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mNLx0-0003Fd-7m; Mon, 06 Sep 2021 21:14:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=2pzxwQvyzuFHN1hB7tBsMg7NU+mnhOSdl6abd4CKkaY=; b=0XnAZlbfTEX8E203RPF3hjrDyn wv6zEfi3vCqFhx5rpPH3P9Pd4eTzt/s7Rom3tBI1CwZr+vJxpFdth3LM4vrldMIlm34L8NfxBgE1z OGQshb6JwP46JH5sjL6AYDPKmALSlWnqc1qUuRxp5S4AqXJ6CNxItopMCwun4u/r9bkM=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 164860: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-i386-xl-qemut-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-examine:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-i386-xl-raw:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-pvshim:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-i386:xen-install:fail:regression linux-linus:test-amd64-i386-xl-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ovmf-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-coresched-i386-xl:xen-install:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit1:guest-start:fail:regression linux-linus:test-arm64-arm64-xl-thunderx:debian-fixup:fail:regression linux-linus:test-arm64-arm64-xl:debian-fixup:fail:regression linux-linus:test-arm64-arm64-xl-xsm:debian-fixup:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:debian-fixup:fail:regression linux-linus:test-arm64-arm64-xl-credit2:debian-fixup:fail:regression linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-armhf-armhf-xl-rtds:guest-start.2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=27151f177827d478508e756c7657273261aaf8a9 X-Osstest-Versions-That: linux=deacdb3e3979979016fcd0ffd518c320a62ad166 From: osstest service owner Date: Mon, 06 Sep 2021 21:14:46 +0000 flight 164860 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/164860/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemut-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-examine 6 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-i386-xl-raw 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-pvshim 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-i386 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ovmf-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-coresched-i386-xl 7 xen-install fail REGR. vs. 152332 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 152332 test-arm64-arm64-xl-credit1 14 guest-start fail REGR. vs. 152332 test-arm64-arm64-xl-thunderx 13 debian-fixup fail REGR. vs. 152332 test-arm64-arm64-xl 13 debian-fixup fail REGR. vs. 152332 test-arm64-arm64-xl-xsm 13 debian-fixup fail REGR. vs. 152332 test-arm64-arm64-libvirt-xsm 13 debian-fixup fail REGR. vs. 152332 test-arm64-arm64-xl-credit2 13 debian-fixup fail REGR. vs. 152332 test-arm64-arm64-examine 8 reboot fail REGR. vs. 152332 Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-rtds 19 guest-start.2 fail blocked in 152332 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 152332 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 152332 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152332 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 152332 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152332 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152332 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152332 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: linux 27151f177827d478508e756c7657273261aaf8a9 baseline version: linux deacdb3e3979979016fcd0ffd518c320a62ad166 Last test of basis 152332 2020-07-31 19:41:23 Z 402 days Failing since 152366 2020-08-01 20:49:34 Z 401 days 697 attempts Testing same since 164850 2021-09-06 02:37:34 Z 0 days 2 attempts ------------------------------------------------------------ 7219 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl fail test-armhf-armhf-xl pass test-amd64-i386-xl fail test-amd64-coresched-i386-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm fail test-amd64-i386-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm fail test-amd64-i386-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine pass test-arm64-arm64-examine fail test-armhf-armhf-examine pass test-amd64-i386-examine fail test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel fail test-amd64-i386-qemuu-rhel6hvm-intel fail test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair fail test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow fail test-arm64-arm64-xl-thunderx fail test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2221077 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Sep 06 21:35:36 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Sep 2021 21:35:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180281.326867 (Exim 4.92) (envelope-from ) id 1mNMH3-0004Qa-Bi; Mon, 06 Sep 2021 21:35:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180281.326867; Mon, 06 Sep 2021 21:35:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNMH3-0004QT-8K; Mon, 06 Sep 2021 21:35:29 +0000 Received: by outflank-mailman (input) for mailman id 180281; Mon, 06 Sep 2021 21:35:28 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNMH2-0004QN-A6 for xen-devel@lists.xenproject.org; Mon, 06 Sep 2021 21:35:28 +0000 Received: from server.eikelenboom.it (unknown [91.121.65.215]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id d167496c-c553-4b02-b94b-d68a6f126275; Mon, 06 Sep 2021 21:35:25 +0000 (UTC) Received: from 76-24-144-85.ftth.glasoperator.nl ([85.144.24.76]:59648 helo=[172.16.1.50]) by server.eikelenboom.it with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1mNMGn-0003UQ-35 for xen-devel@lists.xenproject.org; Mon, 06 Sep 2021 23:35:13 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d167496c-c553-4b02-b94b-d68a6f126275 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=eikelenboom.it; s=20180706; h=Content-Transfer-Encoding:Content-Type: MIME-Version:Date:Message-ID:To:Subject:From:Sender:Reply-To:Cc:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=p2NdIgEhC3QeQFfY0U3KvL+PnROpHFsvtadWOxPAqvA=; b=RmMZnXucFtIIpaT/DJfQ7pYpcp dbojjmoySx/+QdSwQpAzVMKKElcG6gZ2roHByYsIK2lokmHryAduwES2NXaSn/qet1Bfz/Q3f9jq2 wH83yrlPCcLmjaMLSoMrId+UW1Xek6tq/DPxISb9SnC5Dyy6RHtHge792hQl2gzFgrO0=; From: Sander Eikelenboom Subject: xen-unstable linux-5.14: 1 of 2 multicall(s) failed: cpu 0 To: "xen-devel@lists.xenproject.org" Message-ID: <9c36205e-cc37-ed9a-3408-0cccc4a83115@eikelenboom.it> Date: Mon, 6 Sep 2021 23:35:23 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: nl-NL Content-Transfer-Encoding: 7bit L.S., On my AMD box running: xen-unstable changeset: Fri Sep 3 15:10:43 2021 +0200 git:2d4978ead4 linux kernel: 5.14.1 With this setup I'm encountering some issues in dom0, see below. -- Sander xl dmesg gives: (XEN) [2021-09-06 18:15:04.089] mm.c:3506:d0v0 mfn 63b936 already pinned (XEN) [2021-09-06 18:15:04.089] mm.c:3506:d0v0 mfn 6a0622 already pinned (XEN) [2021-09-06 18:15:04.089] mm.c:3506:d0v0 mfn 6b63da already pinned (XEN) [2021-09-06 18:15:04.089] mm.c:3506:d0v0 mfn 638dd9 already pinned (XEN) [2021-09-06 18:15:04.089] mm.c:3506:d0v0 mfn 68a7bc already pinned (XEN) [2021-09-06 18:15:04.089] mm.c:3506:d0v0 mfn 63c27d already pinned (XEN) [2021-09-06 18:15:04.089] mm.c:3506:d0v0 mfn 6a04f2 already pinned (XEN) [2021-09-06 18:15:04.089] mm.c:3506:d0v0 mfn 690d49 already pinned (XEN) [2021-09-06 18:15:04.089] mm.c:3506:d0v0 mfn 6959a0 already pinned (XEN) [2021-09-06 18:15:04.089] mm.c:3506:d0v0 mfn 6a055e already pinned (XEN) [2021-09-06 18:15:04.090] mm.c:3506:d0v0 mfn 639437 already pinned dmesg gives: [34321.304270] ------------[ cut here ]------------ [34321.304277] WARNING: CPU: 0 PID: 23628 at arch/x86/xen/multicalls.c:102 xen_mc_flush+0x176/0x1a0 [34321.304288] Modules linked in: [34321.304291] CPU: 0 PID: 23628 Comm: apt-get Not tainted 5.14.1-20210906-doflr-mac80211debug+ #1 [34321.304294] Hardware name: MSI MS-7640/890FXA-GD70 (MS-7640) , BIOS V1.8B1 09/13/2010 [34321.304296] RIP: e030:xen_mc_flush+0x176/0x1a0 [34321.304300] Code: 89 45 18 48 c1 e9 3f 48 89 ce e9 20 ff ff ff e8 60 03 00 00 66 90 5b 5d 41 5c 41 5d c3 48 c7 45 18 ea ff ff ff be 01 00 00 00 <0f> 0b 8b 55 00 48 c7 c7 10 97 aa 82 31 db 49 c7 c5 38 97 aa 82 65 [34321.304303] RSP: e02b:ffffc90000a97c90 EFLAGS: 00010002 [34321.304305] RAX: ffff88807d416398 RBX: ffff88807d416350 RCX: ffff88807d416398 [34321.304306] RDX: 0000000000000001 RSI: 0000000000000001 RDI: deadbeefdeadf00d [34321.304308] RBP: ffff88807d416300 R08: aaaaaaaaaaaaaaaa R09: ffff888006160cc0 [34321.304309] R10: deadbeefdeadf00d R11: ffffea000026a600 R12: 0000000000000000 [34321.304310] R13: ffff888012f6b000 R14: 0000000012f6b000 R15: 0000000000000001 [34321.304320] FS: 00007f5071177800(0000) GS:ffff88807d400000(0000) knlGS:0000000000000000 [34321.304322] CS: 10000e030 DS: 0000 ES: 0000 CR0: 0000000080050033 [34321.304323] CR2: 00007f506f542000 CR3: 00000000160cc000 CR4: 0000000000000660 [34321.304326] Call Trace: [34321.304331] xen_alloc_pte+0x294/0x320 [34321.304334] move_pgt_entry+0x165/0x4b0 [34321.304339] move_page_tables+0x6fa/0x8d0 [34321.304342] move_vma.isra.44+0x138/0x500 [34321.304345] __x64_sys_mremap+0x296/0x410 [34321.304348] do_syscall_64+0x3a/0x80 [34321.304352] entry_SYSCALL_64_after_hwframe+0x44/0xae [34321.304355] RIP: 0033:0x7f507196301a [34321.304358] Code: 73 01 c3 48 8b 0d 76 0e 0c 00 f7 d8 64 89 01 48 83 c8 ff c3 66 2e 0f 1f 84 00 00 00 00 00 66 90 49 89 ca b8 19 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d 46 0e 0c 00 f7 d8 64 89 01 48 [34321.304360] RSP: 002b:00007ffda1eecd38 EFLAGS: 00000246 ORIG_RAX: 0000000000000019 [34321.304362] RAX: ffffffffffffffda RBX: 000056205f950f30 RCX: 00007f507196301a [34321.304363] RDX: 0000000001a00000 RSI: 0000000001900000 RDI: 00007f506dc56000 [34321.304364] RBP: 0000000001a00000 R08: 0000000000000010 R09: 0000000000000004 [34321.304365] R10: 0000000000000001 R11: 0000000000000246 R12: 00007f506dc56060 [34321.304367] R13: 00007f506dc56000 R14: 00007f506dc56060 R15: 000056205f950f30 [34321.304368] ---[ end trace a19885b78fe8f33e ]--- [34321.304370] 1 of 2 multicall(s) failed: cpu 0 [34321.304371] call 2: op=12297829382473034410 arg=[aaaaaaaaaaaaaaaa] result=-22 [34321.304398] ------------[ cut here ]------------ [34321.304399] WARNING: CPU: 0 PID: 23628 at arch/x86/xen/multicalls.c:102 xen_mc_flush+0x176/0x1a0 [34321.304403] Modules linked in: [34321.304404] CPU: 0 PID: 23628 Comm: apt-get Tainted: G W 5.14.1-20210906-doflr-mac80211debug+ #1 [34321.304406] Hardware name: MSI MS-7640/890FXA-GD70 (MS-7640) , BIOS V1.8B1 09/13/2010 [34321.304407] RIP: e030:xen_mc_flush+0x176/0x1a0 [34321.304410] Code: 89 45 18 48 c1 e9 3f 48 89 ce e9 20 ff ff ff e8 60 03 00 00 66 90 5b 5d 41 5c 41 5d c3 48 c7 45 18 ea ff ff ff be 01 00 00 00 <0f> 0b 8b 55 00 48 c7 c7 10 97 aa 82 31 db 49 c7 c5 38 97 aa 82 65 [34321.304411] RSP: e02b:ffffc90000a97c90 EFLAGS: 00010002 [34321.304413] RAX: ffff88807d416398 RBX: ffff88807d416350 RCX: ffff88807d416398 [34321.304414] RDX: 0000000000000001 RSI: 0000000000000001 RDI: deadbeefdeadf00d [34321.304415] RBP: ffff88807d416300 R08: aaaaaaaaaaaaaaaa R09: ffff888006160cc0 [34321.304417] R10: deadbeefdeadf00d R11: ffffc90000a97ab8 R12: 0000000000000000 [34321.304418] R13: ffff888009e6a000 R14: 0000000009e6a000 R15: 0000000000000001 [34321.304422] FS: 00007f5071177800(0000) GS:ffff88807d400000(0000) knlGS:0000000000000000 [34321.304423] CS: 10000e030 DS: 0000 ES: 0000 CR0: 0000000080050033 [34321.304425] CR2: 00007f506f542000 CR3: 00000000160cc000 CR4: 0000000000000660 [34321.304427] Call Trace: [34321.304428] xen_alloc_pte+0x294/0x320 [34321.304431] move_pgt_entry+0x165/0x4b0 [34321.304433] move_page_tables+0x6fa/0x8d0 [34321.304436] move_vma.isra.44+0x138/0x500 [34321.304439] __x64_sys_mremap+0x296/0x410 [34321.304442] do_syscall_64+0x3a/0x80 [34321.304444] entry_SYSCALL_64_after_hwframe+0x44/0xae [34321.304446] RIP: 0033:0x7f507196301a [34321.304448] Code: 73 01 c3 48 8b 0d 76 0e 0c 00 f7 d8 64 89 01 48 83 c8 ff c3 66 2e 0f 1f 84 00 00 00 00 00 66 90 49 89 ca b8 19 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d 46 0e 0c 00 f7 d8 64 89 01 48 [34321.304449] RSP: 002b:00007ffda1eecd38 EFLAGS: 00000246 ORIG_RAX: 0000000000000019 [34321.304451] RAX: ffffffffffffffda RBX: 000056205f950f30 RCX: 00007f507196301a [34321.304452] RDX: 0000000001a00000 RSI: 0000000001900000 RDI: 00007f506dc56000 [34321.304453] RBP: 0000000001a00000 R08: 0000000000000010 R09: 0000000000000004 [34321.304455] R10: 0000000000000001 R11: 0000000000000246 R12: 00007f506dc56060 [34321.304456] R13: 00007f506dc56000 R14: 00007f506dc56060 R15: 000056205f950f30 [34321.304457] ---[ end trace a19885b78fe8f33f ]--- [34321.304458] 1 of 2 multicall(s) failed: cpu 0 [34321.304459] call 2: op=12297829382473034410 arg=[aaaaaaaaaaaaaaaa] result=-22 [34321.304477] ------------[ cut here ]------------ [34321.304478] WARNING: CPU: 0 PID: 23628 at arch/x86/xen/multicalls.c:102 xen_mc_flush+0x176/0x1a0 [34321.304482] Modules linked in: [34321.304483] CPU: 0 PID: 23628 Comm: apt-get Tainted: G W 5.14.1-20210906-doflr-mac80211debug+ #1 [34321.304485] Hardware name: MSI MS-7640/890FXA-GD70 (MS-7640) , BIOS V1.8B1 09/13/2010 [34321.304486] RIP: e030:xen_mc_flush+0x176/0x1a0 [34321.304488] Code: 89 45 18 48 c1 e9 3f 48 89 ce e9 20 ff ff ff e8 60 03 00 00 66 90 5b 5d 41 5c 41 5d c3 48 c7 45 18 ea ff ff ff be 01 00 00 00 <0f> 0b 8b 55 00 48 c7 c7 10 97 aa 82 31 db 49 c7 c5 38 97 aa 82 65 [34321.304490] RSP: e02b:ffffc90000a97c90 EFLAGS: 00010002 [34321.304491] RAX: ffff88807d416398 RBX: ffff88807d416350 RCX: ffff88807d416398 [34321.304493] RDX: 0000000000000001 RSI: 0000000000000001 RDI: deadbeefdeadf00d [34321.304494] RBP: ffff88807d416300 R08: aaaaaaaaaaaaaaaa R09: ffff888006160cc0 [34321.304495] R10: deadbeefdeadf00d R11: ffffc90000a97ab8 R12: 0000000000000000 [34321.304496] R13: ffff88801833e000 R14: 000000001833e000 R15: 0000000000000001 [34321.304500] FS: 00007f5071177800(0000) GS:ffff88807d400000(0000) knlGS:0000000000000000 [34321.304502] CS: 10000e030 DS: 0000 ES: 0000 CR0: 0000000080050033 [34321.304503] CR2: 00007f506f542000 CR3: 00000000160cc000 CR4: 0000000000000660 [34321.304505] Call Trace: [34321.304506] xen_alloc_pte+0x294/0x320 [34321.304509] move_pgt_entry+0x165/0x4b0 [34321.304511] move_page_tables+0x6fa/0x8d0 [34321.304514] move_vma.isra.44+0x138/0x500 [34321.304516] __x64_sys_mremap+0x296/0x410 [34321.304519] do_syscall_64+0x3a/0x80 [34321.304521] entry_SYSCALL_64_after_hwframe+0x44/0xae [34321.304523] RIP: 0033:0x7f507196301a [34321.304525] Code: 73 01 c3 48 8b 0d 76 0e 0c 00 f7 d8 64 89 01 48 83 c8 ff c3 66 2e 0f 1f 84 00 00 00 00 00 66 90 49 89 ca b8 19 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d 46 0e 0c 00 f7 d8 64 89 01 48 [34321.304526] RSP: 002b:00007ffda1eecd38 EFLAGS: 00000246 ORIG_RAX: 0000000000000019 [34321.304528] RAX: ffffffffffffffda RBX: 000056205f950f30 RCX: 00007f507196301a [34321.304529] RDX: 0000000001a00000 RSI: 0000000001900000 RDI: 00007f506dc56000 [34321.304530] RBP: 0000000001a00000 R08: 0000000000000010 R09: 0000000000000004 [34321.304531] R10: 0000000000000001 R11: 0000000000000246 R12: 00007f506dc56060 [34321.304533] R13: 00007f506dc56000 R14: 00007f506dc56060 R15: 000056205f950f30 [34321.304534] ---[ end trace a19885b78fe8f340 ]--- [34321.304535] 1 of 2 multicall(s) failed: cpu 0 [34321.304536] call 2: op=12297829382473034410 arg=[aaaaaaaaaaaaaaaa] result=-22 From xen-devel-bounces@lists.xenproject.org Mon Sep 06 22:45:11 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 06 Sep 2021 22:45:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180291.326878 (Exim 4.92) (envelope-from ) id 1mNNMI-0004B3-Di; Mon, 06 Sep 2021 22:44:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180291.326878; Mon, 06 Sep 2021 22:44:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNNMI-0004Aw-Aq; Mon, 06 Sep 2021 22:44:58 +0000 Received: by outflank-mailman (input) for mailman id 180291; Mon, 06 Sep 2021 22:44:57 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNNMH-0004Am-I0; Mon, 06 Sep 2021 22:44:57 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNNMH-0006SZ-AN; Mon, 06 Sep 2021 22:44:57 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNNMH-0007Ow-0E; Mon, 06 Sep 2021 22:44:57 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mNNMG-0000An-Vy; Mon, 06 Sep 2021 22:44:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=L9mpehhOwPie4jfUUdfv7cpPvpbBZ13JSHkykAadb4s=; b=j/ivdFpbgb2T8+IhJOv/nvuqV3 iSwMEkMuXo+ZiiH/YjrcmPCzc6IIfBTyV8oM+8NAPxgK+XAAVME0wJKEhphKc4Vbsk6yIBNGswufp wjVxFyIxLHVuopACJkL/DWTPfc0dy925+qn3Nyq52GS6xmjZ105TLi0dbiAmHsHhxNcE=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 164863: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=6c27a8da8d2024aa78a9ec67bcfb18c123e84a17 X-Osstest-Versions-That: xen=2d4978ead4b98452bc45ebe47952e524b12e2b41 From: osstest service owner Date: Mon, 06 Sep 2021 22:44:56 +0000 flight 164863 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/164863/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 6c27a8da8d2024aa78a9ec67bcfb18c123e84a17 baseline version: xen 2d4978ead4b98452bc45ebe47952e524b12e2b41 Last test of basis 164796 2021-09-03 14:01:38 Z 3 days Testing same since 164863 2021-09-06 18:02:44 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Michal Orzel jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 2d4978ead4..6c27a8da8d 6c27a8da8d2024aa78a9ec67bcfb18c123e84a17 -> smoke From xen-devel-bounces@lists.xenproject.org Tue Sep 07 00:58:15 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 00:58:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180302.326892 (Exim 4.92) (envelope-from ) id 1mNPR5-0002fs-CE; Tue, 07 Sep 2021 00:58:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180302.326892; Tue, 07 Sep 2021 00:58:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNPR5-0002fl-93; Tue, 07 Sep 2021 00:58:03 +0000 Received: by outflank-mailman (input) for mailman id 180302; Tue, 07 Sep 2021 00:58:02 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNPR4-0002ff-1t for xen-devel@lists.xen.org; Tue, 07 Sep 2021 00:58:02 +0000 Received: from mail-oo1-xc2d.google.com (unknown [2607:f8b0:4864:20::c2d]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 6ad94e00-1f18-4281-9f6d-40b1bf59f82f; Tue, 07 Sep 2021 00:57:59 +0000 (UTC) Received: by mail-oo1-xc2d.google.com with SMTP id y3-20020a4ab403000000b00290e2a52c71so2439885oon.2 for ; Mon, 06 Sep 2021 17:57:58 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6ad94e00-1f18-4281-9f6d-40b1bf59f82f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=VUq8hhhVF+UOcOQr157X5bZtPmm1X78HQGLXPKMFzuI=; b=GEJPVWizDy1/cHuxqsGCcbg4TXZyPYnuD2g4BhcY8nN+MtooHN44X6f+M15WWQeELk ZHxS6OcsHF8b1HPdRfPrF0lUe8C581xHWFOWapCJIP8aHnoh2ey9vULULhfumbo7LXAT GDviqgNRWwGILs8ON3yjB8FPK4bq4Hi+rBj1qjbLgkk61ZhZRn1NnD6Nd/KiOCIm5ZTC 9QWRj/+vjWiOpxsKLgEDePZkeYbpkjTc6l36kXMd9zHsHuh1j4C2f5lCraLKARu9LJ1k D1F/za65wIi/G7aKw3Hss9BiMcAXuyaWlgCm51v4c9Oa/kRqeJDe+S0cQ893K3/ePIKq PTsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=VUq8hhhVF+UOcOQr157X5bZtPmm1X78HQGLXPKMFzuI=; b=YgIOaxgppSIFvy/s4gT6nXj1X2pb52KckWwceEN1plRGQCyigxEnkySZunRF/brX9O HV9oybniTOv9xgdadVkKUuCx8w9MSpC2DdpW/tp6RouPSG6lZROf1qkycF7A23DtEeOZ JCZvSYCYX7ZoLTY5HqrWHyK8tWJUW9f6bGV+4m8DziF8VVO3y42sQYD0hrEHJW0YDQNm CXvgsXissc7bPQ/QSoiFe++m+k56zTNWcOhYCDZwwcRYVcgcY1xIkG2vHqi46b0JWxxm HlCxaw5EYgyBPgTgMNnfxAM6iWgnq+4dite4koUDnqT6zd53sSVxyhxD9yD0Xcp01aMd zoLg== X-Gm-Message-State: AOAM531PQAwSMAwFkoa6NyaCl+f6ZlBIEU4AYr7Fyhd/ryOwK8vVwobd yw+d7RrRZnz0CnZshXMWcakddqcNM0UGjq9OQmQ= X-Google-Smtp-Source: ABdhPJzkmVgMjlkimhOnxYqmnzjr8MYlQDbviubm9j0fp6M02lYE+H2P8fCiYO93E0jJO8KWexrxbJ0mIeTaa254QNk= X-Received: by 2002:a4a:e297:: with SMTP id k23mr9231450oot.4.1630976278325; Mon, 06 Sep 2021 17:57:58 -0700 (PDT) MIME-Version: 1.0 References: <20210817080757.GC43203@laputa> <20210818053840.GE39588@laputa> <20210820064150.GC13452@laputa> <20210826094047.GA55218@laputa> <20210902071902.GC71098@laputa> In-Reply-To: <20210902071902.GC71098@laputa> From: Christopher Clark Date: Mon, 6 Sep 2021 17:57:43 -0700 Message-ID: Subject: Re: Enabling hypervisor agnosticism for VirtIO backends To: AKASHI Takahiro Cc: Wei Chen , Oleksandr Tyshchenko , Stefano Stabellini , "Alex Benn??e" , Kaly Xin , Stratos Mailing List , "virtio-dev@lists.oasis-open.org" , Arnd Bergmann , Viresh Kumar , Stefano Stabellini , "stefanha@redhat.com" , Jan Kiszka , Carl van Schaik , "pratikp@quicinc.com" , Srivatsa Vaddagiri , Jean-Philippe Brucker , Mathieu Poirier , Oleksandr Tyshchenko , Bertrand Marquis , Artem Mygaiev , Julien Grall , Juergen Gross , Paul Durrant , Xen Devel , Rich Persaud , Daniel Smith , James McKenzie , Andrew Cooper Content-Type: multipart/alternative; boundary="000000000000b501cf05cb5d41dd" --000000000000b501cf05cb5d41dd Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Sep 2, 2021 at 12:19 AM AKASHI Takahiro wrote: > Hi Christopher, > > Thank you for your feedback. > > On Mon, Aug 30, 2021 at 12:53:00PM -0700, Christopher Clark wrote: > > [ resending message to ensure delivery to the CCd mailing lists > > post-subscription ] > > > > Apologies for being late to this thread, but I hope to be able to > > contribute to > > this discussion in a meaningful way. I am grateful for the level of > > interest in > > this topic. I would like to draw your attention to Argo as a suitable > > technology for development of VirtIO's hypervisor-agnostic interfaces. > > > > * Argo is an interdomain communication mechanism in Xen (on x86 and Arm= ) > > that > > can send and receive hypervisor-mediated notifications and messages > > between > > domains (VMs). [1] The hypervisor can enforce Mandatory Access Contro= l > > over > > all communication between domains. It is derived from the earlier v4v= , > > which > > has been deployed on millions of machines with the HP/Bromium uXen > > hypervisor > > and with OpenXT. > > > > * Argo has a simple interface with a small number of operations that wa= s > > designed for ease of integration into OS primitives on both Linux > > (sockets) > > and Windows (ReadFile/WriteFile) [2]. > > - A unikernel example of using it has also been developed for XTF. > [3] > > > > * There has been recent discussion and support in the Xen community for > > making > > revisions to the Argo interface to make it hypervisor-agnostic, and > > support > > implementations of Argo on other hypervisors. This will enable a sing= le > > interface for an OS kernel binary to use for inter-VM communication > that > > will > > work on multiple hypervisors -- this applies equally to both backends > and > > frontend implementations. [4] > > Regarding virtio-over-Argo, let me ask a few questions: > (In figure "Virtual device buffer access:Virtio+Argo" in [4]) > (for ref, this diagram is from this document: https://openxt.atlassian.net/wiki/spaces/DC/pages/1348763698 ) Takahiro, thanks for reading the Virtio-Argo materials. Some relevant context before answering your questions below: the Argo request interface from the hypervisor to a guest, which is currently exposed only via a dedicated hypercall op, has been discussed within the Xen community and is open to being changed in order to better enable support for guest VM access to Argo functions in a hypervisor-agnostic way. The proposal is to allow hypervisors the option to implement and expose any of multiple access mechanisms for Argo, and then enable a guest device driver to probe the hypervisor for methods that it is aware of and able to use. The hypercall op is likely to be retained (in some form), and complemented at least on x86 with another interface via MSRs presented to the guests. > 1) How the configuration is managed? > On either virtio-mmio or virtio-pci, there always takes place > some negotiation between the FE and BE through the "configuration" > space. How can this be done in virtio-over-Argo? > Just to be clear about my understanding: your question, in the context of a Linux kernel virtio device driver implementation, is about how a virtio-arg= o transport driver would implement the get_features function of the virtio_config_ops, as a parallel to the work that vp_get_features does for virtio-pci, and vm_get_features does for virtio-mmio. The design is still open on this and options have been discussed, including= : * an extension to Argo to allow the system toolstack (which is responsible for managing guest VMs and enabling connections from front-to-backends) to manage a table of "implicit destinations", so a guest can transmit Arg= o messages to eg. "my storage service" port and the hypervisor will deliver it based on a destination table pre-programmed by the toolstack for the VM. [1] - ref: Notes from the December 2019 Xen F2F meeting in Cambridge, UK: [1] https://lists.archive.carbon60.com/xen/devel/577800#577800 So within that feature negotiation function, communication with the backend via that Argo channel will occur. * IOREQ The Xen IOREQ implementation is not currently appropriate for virtio-argo since it requires the use of foreign memory mappings of frontend memory in the backend guest. However, a new HMX interface from the hypervisor could support a new DMA Device Model Op to allow the backend to request the hypervisor to retrieve specified bytes from the frontend guest, which would enable plumbing for device configuration between an IOREQ server (device model backend implementation) and the guest driver. [2] Feature negotiation in the front end in this case would look very similar t= o the virtio-mmio implementation. ref: Argo HMX Transport for VirtIO meeting minutes, from January 2021: [2] https://lists.xenproject.org/archives/html/xen-devel/2021-02/msg01422.html * guest ACPI tables that surface the address of a remote Argo endpoint on behalf of the toolstack, and Argo communication can then negotiate features * emulation of a basic PCI device by the hypervisor (though details not determined) > 2) Do there physically exist virtio's available/used vrings as well as > descriptors, or are they virtually emulated over Argo (rings)? > In short: the latter. In the analysis that I did when looking at this, my observation was that each side (front and backend) should be able to accurately maintain their own local copy of the available/used vrings as well as descriptors, and both be kept synchronized by ensuring that updates are transmitted to the other side whe= n they are written to. eg. As part of this, in the Linux front end implementation the virtqueue_notify function uses a function pointer in the virtqueue that is populated by the transport driver, ie. the virtio-argo driver in this case, which can implement the necessary logic to coordinate with the backend. > 3) The payload in a request will be copied into the receiver's Argo ring. > What does the address in a descriptor mean? > Address/offset in a ring buffer? > Effectively yes. I would treat it as a handle that is used to identify and retrieve data from messages exchanged between frontend transport driver and the backend via Argo rings established for moving data for the data path. In the diagram, those are "Argo ring for reads" and "Argo ring for writes". > 4) Estimate of performance or latency? > Different access methods to Argo (ie. related to my answer to your question '1)' above --) will have different performance characteristics. Data copying will necessarily involved for any Hypervisor-Mediated data eXchange (HMX) mechanism[1], such as Argo, where there is no shared memory between guest VMs, but the performance profile on modern CPUs with sizable caches has bee= n demonstrated to be acceptable for the guest virtual device drivers use case in the HP/Bromium vSentry uXen product. The VirtIO structure is somewhat different though. Further performance profiling and measurement will be valuable for enabling tuning of the implementation and development of additional interfaces (eg. such as an asynchronous send primitive) - some of this has been discussed and described on the VirtIO-Argo-Development-Phase-1 wiki page[2]. [1] https://wiki.xenproject.org/wiki/Argo:_Hypervisor-Mediated_Exchange_(HMX)_f= or_Xen [2] https://openxt.atlassian.net/wiki/spaces/DC/pages/1696169985/VirtIO-Argo+De= velopment%3A+Phase+1 > It appears that, on FE side, at least three hypervisor calls (and data > copying) need to be invoked at every request, right? > For a write, counting FE sendv ops: 1: the write data payload is sent via the "Argo ring for writes" 2: the descriptor is sent via a sync of the available/descriptor ring -- is there a third one that I am missing? Christopher > > Thanks, > -Takahiro Akashi > > > > * Here are the design documents for building VirtIO-over-Argo, to > support a > > hypervisor-agnostic frontend VirtIO transport driver using Argo. > > > > The Development Plan to build VirtIO virtual device support over Argo > > transport: > > > https://openxt.atlassian.net/wiki/spaces/DC/pages/1696169985/VirtIO-Argo+= Development+Phase+1 > > > > A design for using VirtIO over Argo, describing how VirtIO data > structures > > and communication is handled over the Argo transport: > > https://openxt.atlassian.net/wiki/spaces/DC/pages/1348763698/VirtIO+Arg= o > > > > Diagram (from the above document) showing how VirtIO rings are > synchronized > > between domains without using shared memory: > > > https://openxt.atlassian.net/46e1c93b-2b87-4cb2-951e-abd4377a1194#media-b= lob-url=3Dtrue&id=3D01f7d0e1-7686-4f0b-88e1-457c1d30df40&collection=3Dconte= ntId-1348763698&contextId=3D1348763698&mimeType=3Dimage%2Fpng&name=3Ddevice= -buffer-access-virtio-argo.png&size=3D243175&width=3D1106&height=3D1241 > > > > Please note that the above design documents show that the existing Virt= IO > > device drivers, and both vring and virtqueue data structures can be > > preserved > > while interdomain communication can be performed with no shared memory > > required > > for most drivers; (the exceptions where further design is required are > those > > such as virtual framebuffer devices where shared memory regions are > > intentionally > > added to the communication structure beyond the vrings and virtqueues). > > > > An analysis of VirtIO and Argo, informing the design: > > > https://openxt.atlassian.net/wiki/spaces/DC/pages/1333428225/Analysis+of+= Argo+as+a+transport+medium+for+VirtIO > > > > * Argo can be used for a communication path for configuration between t= he > > backend > > and the toolstack, avoiding the need for a dependency on XenStore, > which > > is an > > advantage for any hypervisor-agnostic design. It is also amenable to = a > > notification > > mechanism that is not based on Xen event channels. > > > > * Argo does not use or require shared memory between VMs and provides a= n > > alternative > > to the use of foreign shared memory mappings. It avoids some of the > > complexities > > involved with using grants (eg. XSA-300). > > > > * Argo supports Mandatory Access Control by the hypervisor, satisfying = a > > common > > certification requirement. > > > > * The Argo headers are BSD-licensed and the Xen hypervisor implementati= on > > is GPLv2 but > > accessible via the hypercall interface. The licensing should not > present > > an obstacle > > to adoption of Argo in guest software or implementation by other > > hypervisors. > > > > * Since the interface that Argo presents to a guest VM is similar to > DMA, a > > VirtIO-Argo > > frontend transport driver should be able to operate with a physical > > VirtIO-enabled > > smart-NIC if the toolstack and an Argo-aware backend provide support. > > > > The next Xen Community Call is next week and I would be happy to answer > > questions > > about Argo and on this topic. I will also be following this thread. > > > > Christopher > > (Argo maintainer, Xen Community) > > > > > -------------------------------------------------------------------------= ------- > > [1] > > An introduction to Argo: > > > https://static.sched.com/hosted_files/xensummit19/92/Argo%20and%20HMX%20-= %20OpenXT%20-%20Christopher%20Clark%20-%20Xen%20Summit%202019.pdf > > https://www.youtube.com/watch?v=3DcnC0Tg3jqJQ > > Xen Wiki page for Argo: > > > https://wiki.xenproject.org/wiki/Argo:_Hypervisor-Mediated_Exchange_(HMX)= _for_Xen > > > > [2] > > OpenXT Linux Argo driver and userspace library: > > https://github.com/openxt/linux-xen-argo > > > > Windows V4V at OpenXT wiki: > > https://openxt.atlassian.net/wiki/spaces/DC/pages/14844007/V4V > > Windows v4v driver source: > > https://github.com/OpenXT/xc-windows/tree/master/xenv4v > > > > HP/Bromium uXen V4V driver: > > https://github.com/uxen-virt/uxen/tree/ascara/windows/uxenv4vlib > > > > [3] > > v2 of the Argo test unikernel for XTF: > > > https://lists.xenproject.org/archives/html/xen-devel/2021-01/msg02234.htm= l > > > > [4] > > Argo HMX Transport for VirtIO meeting minutes: > > > https://lists.xenproject.org/archives/html/xen-devel/2021-02/msg01422.htm= l > > > > VirtIO-Argo Development wiki page: > > > https://openxt.atlassian.net/wiki/spaces/DC/pages/1696169985/VirtIO-Argo+= Development+Phase+1 > > > > --000000000000b501cf05cb5d41dd Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Thu, Sep 2, 2021 at 12:19 AM AKASH= I Takahiro <takahiro.akash= i@linaro.org> wrote:
Hi Christopher,

Thank you for your feedback.

On Mon, Aug 30, 2021 at 12:53:00PM -0700, Christopher Clark wrote:
> [ resending message to ensure delivery to the CCd mailing lists
> post-subscription ]
>
> Apologies for being late to this thread, but I hope to be able to
> contribute to
> this discussion in a meaningful way. I am grateful for the level of > interest in
> this topic. I would like to draw your attention to Argo as a suitable<= br> > technology for development of VirtIO's hypervisor-agnostic interfa= ces.
>
> * Argo is an interdomain communication mechanism in Xen (on x86 and Ar= m)
> that
>=C2=A0 =C2=A0can send and receive hypervisor-mediated notifications and= messages
> between
>=C2=A0 =C2=A0domains (VMs). [1] The hypervisor can enforce Mandatory Ac= cess Control
> over
>=C2=A0 =C2=A0all communication between domains. It is derived from the = earlier v4v,
> which
>=C2=A0 =C2=A0has been deployed on millions of machines with the HP/Brom= ium uXen
> hypervisor
>=C2=A0 =C2=A0and with OpenXT.
>
> * Argo has a simple interface with a small number of operations that w= as
>=C2=A0 =C2=A0designed for ease of integration into OS primitives on bot= h Linux
> (sockets)
>=C2=A0 =C2=A0and Windows (ReadFile/WriteFile) [2].
>=C2=A0 =C2=A0 =C2=A0- A unikernel example of using it has also been dev= eloped for XTF. [3]
>
> * There has been recent discussion and support in the Xen community fo= r
> making
>=C2=A0 =C2=A0revisions to the Argo interface to make it hypervisor-agno= stic, and
> support
>=C2=A0 =C2=A0implementations of Argo on other hypervisors. This will en= able a single
>=C2=A0 =C2=A0interface for an OS kernel binary to use for inter-VM comm= unication that
> will
>=C2=A0 =C2=A0work on multiple hypervisors -- this applies equally to bo= th backends and
>=C2=A0 =C2=A0frontend implementations. [4]

Regarding virtio-over-Argo, let me ask a few questions:
(In figure "Virtual device buffer access:Virtio+Argo" in [4])
=

(for ref, this diagram is from this docume= nt:
=C2=A0https://openxt.atlassian.net/wiki/spaces/DC/pages/1348763698= )

Takahiro, thanks for reading the Virtio-Argo materials.

So= me relevant context before answering your questions below: the Argo request=
interface from the hypervisor to a guest, which is currently exposed on= ly via a
dedicated hypercall op, has been discussed within the Xen commu= nity and is open
to being changed in order to better enable support for = guest VM access to Argo
functions in a hypervisor-agnostic way.

T= he proposal is to allow hypervisors the option to implement and expose any = of
multiple access mechanisms for Argo, and then enable a guest device d= river to
probe the hypervisor for methods that it is aware of and able t= o use. The
hypercall op is likely to be retained (in some form), and com= plemented at least
on x86 with another interface via MSRs presented to t= he guests.

=C2=A0
1) How the configuration is managed?
=C2=A0 =C2=A0On either virtio-mmio or virtio-pci, there always takes place<= br> =C2=A0 =C2=A0some negotiation between the FE and BE through the "confi= guration"
=C2=A0 =C2=A0space. How can this be done in virtio-over-Argo?

Just to be clear about my understanding: your questi= on, in the context of a
Linux kernel virtio device driver implementation= , is about how a virtio-argo
transport driver would implement the get_fe= atures function of the
virtio_config_ops, as a parallel to the work that= vp_get_features does for
virtio-pci, and vm_get_features does for virti= o-mmio.

The design is still open on this and options have been discu= ssed, including:

* an extension to Argo to allow the system toolstac= k (which is responsible for
=C2=A0 managing guest VMs and enabling conne= ctions from front-to-backends)
=C2=A0 to manage a table of "implici= t destinations", so a guest can transmit Argo
=C2=A0 messages to eg= . "my storage service" port and the hypervisor will deliver it=C2=A0 based on a destination table pre-programmed by the toolstack for th= e VM.
=C2=A0 [1]
=C2=A0 =C2=A0 =C2=A0- ref: Notes from the December 2= 019 Xen F2F meeting in Cambridge, UK:
=C2=A0 =C2=A0 =C2=A0 =C2=A0[1] https:/= /lists.archive.carbon60.com/xen/devel/577800#577800

=C2=A0 So wi= thin that feature negotiation function, communication with the backend
= =C2=A0 via that Argo channel will occur.

* IOREQ
The Xen IOREQ im= plementation is not currently appropriate for virtio-argo since
it requi= res the use of foreign memory mappings of frontend memory in the backendguest. However, a new HMX interface from the hypervisor could support a ne= w DMA
Device Model Op to allow the backend to request the hypervisor to = retrieve specified
bytes from the frontend guest, which would enable plu= mbing for device configuration
between an IOREQ server (device model bac= kend implementation) and the guest driver.
[2]

Feature negotiatio= n in the front end in this case would look very similar to
the virtio-mm= io implementation.

ref: Argo HMX Transport for VirtIO meeting minute= s, from January 2021:
[2] https://lists.xenproject.org/archi= ves/html/xen-devel/2021-02/msg01422.html

* guest ACPI tables tha= t surface the address of a remote Argo endpoint
=C2=A0 on behalf of the = toolstack, and Argo communication can then negotiate features

* emul= ation of a basic PCI device by the hypervisor (though details not determine= d)

=C2=A0
2) Do there physically exist virtio's available/used vrings as well as<= br> =C2=A0 =C2=A0descriptors, or are they virtually emulated over Argo (rings)?=

In short: the latter.

In the an= alysis that I did when looking at this, my observation was that each
sid= e (front and backend) should be able to accurately maintain their own local=
copy of the available/used vrings as well as descriptors, and both be k= ept
synchronized by ensuring that updates are transmitted to the other s= ide when
they are written to. eg. As part of this, in the Linux front en= d implementation
the virtqueue_notify function uses a function pointer i= n the virtqueue that is
populated by the transport driver, ie. the virti= o-argo driver in this case,
which can implement the necessary logic to c= oordinate with the backend.
=C2=A0
3) The payload in a request will be copied into the receiver's Argo rin= g.
=C2=A0 =C2=A0What does the address in a descriptor mean?
=C2=A0 =C2=A0Address/offset in a ring buffer?

Effectively yes. I would treat it as a handle that is used to identi= fy and
retrieve data from messages exchanged between frontend transport = driver and
the backend via Argo rings established for moving data for th= e data path.
In the diagram, those are "Argo ring for reads" a= nd "Argo ring for writes".
=C2=A0
4) Estimate of performance or latency?

= Different access methods to Argo (ie. related to my answer to your question= '1)'
above --) will have different performance characteristics.=

Data copying will necessarily involved for any Hypervisor-Mediated = data eXchange
(HMX) mechanism[1], such as Argo, where there is no shared= memory between guest
VMs, but the performance profile on modern CPUs wi= th sizable caches has been
demonstrated to be acceptable for the guest v= irtual device drivers use case in
the HP/Bromium vSentry uXen product. T= he VirtIO structure is somewhat different
though.

Further perform= ance profiling and measurement will be valuable for enabling
tuning of t= he implementation and development of additional interfaces (eg. such
as = an asynchronous send primitive) - some of this has been discussed and
de= scribed on the VirtIO-Argo-Development-Phase-1 wiki page[2].

[1]
= https://wiki.xenproject.org/wiki/Argo:_Hypervisor-Mediat= ed_Exchange_(HMX)_for_Xen

[2]
=C2=A0 =C2=A0It appears that, on FE side, at least three hypervisor calls (= and data
=C2=A0 =C2=A0copying) need to be invoked at every request, right?

For a write, counting FE sendv ops:
1: the wr= ite data payload is sent via the "Argo ring for writes"
2: the= descriptor is sent via a sync of the available/descriptor ring
=C2=A0 -= - is there a third one that I am missing?

Christopher
= =C2=A0

Thanks,
-Takahiro Akashi


> * Here are the design documents for building VirtIO-over-Argo, to supp= ort a
>=C2=A0 =C2=A0hypervisor-agnostic frontend VirtIO transport driver using= Argo.
>
> The Development Plan to build VirtIO virtual device support over Argo<= br> > transport:
> htt= ps://openxt.atlassian.net/wiki/spaces/DC/pages/1696169985/VirtIO-Argo+Devel= opment+Phase+1
>
> A design for using VirtIO over Argo, describing how VirtIO data struct= ures
> and communication is handled over the Argo transport:
> https://openxt.atlassia= n.net/wiki/spaces/DC/pages/1348763698/VirtIO+Argo
>
> Diagram (from the above document) showing how VirtIO rings are synchro= nized
> between domains without using shared memory:
> https://openxt.atlassian.net/46e1c93b-2b87-4cb2-951e-abd4377a1194#m= edia-blob-url=3Dtrue&id=3D01f7d0e1-7686-4f0b-88e1-457c1d30df40&coll= ection=3DcontentId-1348763698&contextId=3D1348763698&mimeType=3Dima= ge%2Fpng&name=3Ddevice-buffer-access-virtio-argo.png&size=3D243175&= amp;width=3D1106&height=3D1241
>
> Please note that the above design documents show that the existing Vir= tIO
> device drivers, and both vring and virtqueue data structures can be > preserved
> while interdomain communication can be performed with no shared memory=
> required
> for most drivers; (the exceptions where further design is required are= those
> such as virtual framebuffer devices where shared memory regions are > intentionally
> added to the communication structure beyond the vrings and virtqueues)= .
>
> An analysis of VirtIO and Argo, informing the design:
> https://openxt.atlassian.net/wiki/spaces/DC/pages/1333428225= /Analysis+of+Argo+as+a+transport+medium+for+VirtIO
>
> * Argo can be used for a communication path for configuration between = the
> backend
>=C2=A0 =C2=A0and the toolstack, avoiding the need for a dependency on X= enStore, which
> is an
>=C2=A0 =C2=A0advantage for any hypervisor-agnostic design. It is also a= menable to a
> notification
>=C2=A0 =C2=A0mechanism that is not based on Xen event channels.
>
> * Argo does not use or require shared memory between VMs and provides = an
> alternative
>=C2=A0 =C2=A0to the use of foreign shared memory mappings. It avoids so= me of the
> complexities
>=C2=A0 =C2=A0involved with using grants (eg. XSA-300).
>
> * Argo supports Mandatory Access Control by the hypervisor, satisfying= a
> common
>=C2=A0 =C2=A0certification requirement.
>
> * The Argo headers are BSD-licensed and the Xen hypervisor implementat= ion
> is GPLv2 but
>=C2=A0 =C2=A0accessible via the hypercall interface. The licensing shou= ld not present
> an obstacle
>=C2=A0 =C2=A0to adoption of Argo in guest software or implementation by= other
> hypervisors.
>
> * Since the interface that Argo presents to a guest VM is similar to D= MA, a
> VirtIO-Argo
>=C2=A0 =C2=A0frontend transport driver should be able to operate with a= physical
> VirtIO-enabled
>=C2=A0 =C2=A0smart-NIC if the toolstack and an Argo-aware backend provi= de support.
>
> The next Xen Community Call is next week and I would be happy to answe= r
> questions
> about Argo and on this topic. I will also be following this thread. >
> Christopher
> (Argo maintainer, Xen Community)
>
> ----------------------------------------------------------------------= ----------
> [1]
> An introduction to Argo:
> https://static.sched.com/hosted_= files/xensummit19/92/Argo%20and%20HMX%20-%20OpenXT%20-%20Christopher%20Clar= k%20-%20Xen%20Summit%202019.pdf
> https://www.youtube.com/watch?v=3DcnC0Tg3jqJQ<= br> > Xen Wiki page for Argo:
> https://wiki.x= enproject.org/wiki/Argo:_Hypervisor-Mediated_Exchange_(HMX)_for_Xen
>
> [2]
> OpenXT Linux Argo driver and userspace library:
> https://github.com/openxt/linux-xen-argo
>
> Windows V4V at OpenXT wiki:
> https://openxt.atlassian.net/wiki= /spaces/DC/pages/14844007/V4V
> Windows v4v driver source:
> https://github.com/OpenXT/xc-windows/tre= e/master/xenv4v
>
> HP/Bromium uXen V4V driver:
> https://github.com/uxen-virt/ux= en/tree/ascara/windows/uxenv4vlib
>
> [3]
> v2 of the Argo test unikernel for XTF:
> https://lists.xenproj= ect.org/archives/html/xen-devel/2021-01/msg02234.html
>
> [4]
> Argo HMX Transport for VirtIO meeting minutes:
> https://lists.xenproj= ect.org/archives/html/xen-devel/2021-02/msg01422.html
>
> VirtIO-Argo Development wiki page:
> htt= ps://openxt.atlassian.net/wiki/spaces/DC/pages/1696169985/VirtIO-Argo+Devel= opment+Phase+1
>

--000000000000b501cf05cb5d41dd-- From xen-devel-bounces@lists.xenproject.org Tue Sep 07 01:43:07 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 01:43:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180313.326903 (Exim 4.92) (envelope-from ) id 1mNQ8a-00071y-LO; Tue, 07 Sep 2021 01:43:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180313.326903; Tue, 07 Sep 2021 01:43:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNQ8a-00071r-HG; Tue, 07 Sep 2021 01:43:00 +0000 Received: by outflank-mailman (input) for mailman id 180313; Tue, 07 Sep 2021 01:42:59 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNQ8Y-00071l-VO for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 01:42:59 +0000 Received: from mail-oo1-xc2b.google.com (unknown [2607:f8b0:4864:20::c2b]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id f67aa032-282b-44eb-bc5c-ffc11927bb96; Tue, 07 Sep 2021 01:42:53 +0000 (UTC) Received: by mail-oo1-xc2b.google.com with SMTP id k18-20020a4abd92000000b002915ed21fb8so2468578oop.11 for ; Mon, 06 Sep 2021 18:42:53 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f67aa032-282b-44eb-bc5c-ffc11927bb96 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:from:date:message-id:subject:to:cc; bh=AmTYCsTMxsxUaV+vrl73d/gbiuPrWmazNxtA2VpDiE4=; b=F2cSITu7H6zodAIKEv07Q1UXJNjdAmUHud5D8ZNM4iteDHDTuhTSM1laFUOwcuvo+j GF1VwFDyEBZHMtuv6On3rpsc4EXDSYGet1ZuqppQYR13E/0jxEeDHnr+c5U1Ba7u4Go1 3yMtTxviC1wLPfcXvas1a6xSozLNCorc+hQvj+PeRu88S5p7uW5LqqCBesmmZzsbngbI D0uupFhGHO2oYlw87f7EvTfVn2RrzZ0XPjPj+3KfwYobiLuwzDu10SaO+v3ugsytrWMr FVRl0F8dygQlu9Ao2u5wCPpNN0iuqZKOFOaPOu/2dg3GAQhPjISTLa8iDFpx3snPmkKq yGHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=AmTYCsTMxsxUaV+vrl73d/gbiuPrWmazNxtA2VpDiE4=; b=IGGPibdq2DnKSHyzxBm5b3ciAkCxhfxgPEqPElbNZHsiM+mo201HgKUcw0jk0OwBiV IOaEnqxqlGPJSz25kcmMT2KfUc+9k8AZrBajxTJU9VsVuSBoAlh2AFXmfhR00bUpkt6f vDGBjf7w+1MLQ0d8A5dPt4OYDIX/zQ0kGr/MXebz6NcIRYzbmCsptxkUbKhi61ohVGaa 6GoS+U6/ncuKj0fl5MMJUPAcmPGoV+JIUPV5066fK41VOasDtoXdGZi4kJcghaXtAVXt Db4rNseiBnvVUbvl9KI7VfJS0/OzlJpRDznBUjawRAnskesCwMyJX/BTs5Nk9wfhI62X QSeQ== X-Gm-Message-State: AOAM533lnSdvUEB7c7yXWKJTvpVP6A9npbZZQson7BjQmGQzhcTMnmcm mu7hdKxC4gSd6WbxfBEcNUWjXtpbVmTmw1cCkgC4QnriD159oA== X-Google-Smtp-Source: ABdhPJyqyXvInMjZtKtyVn1MU4FPSFnwbM+SxbhnaCAPYw9c+kHOMzZpytZTtEokXXQMt3YOn814gLY+OvHFIAoi7VI= X-Received: by 2002:a4a:e3cf:: with SMTP id m15mr15993837oov.21.1630978972478; Mon, 06 Sep 2021 18:42:52 -0700 (PDT) MIME-Version: 1.0 From: Christopher Clark Date: Mon, 6 Sep 2021 18:42:36 -0700 Message-ID: Subject: Notes from the Xen Summit 2021: Design Session VirtIO Cross-Project BoF (Birds of a Feather) for Xen and Guest OS (Linux, Windows, FreeBSD) developers To: xen-devel Cc: Juergen Gross , Rich Persaud , stratos-dev@linaro.org, =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Julien Grall , Bertrand Marquis , Daniel Smith , Oleksandr Tyshchenko , Julien Grall , James McKenzie , Andrew Cooper , Paul Durrant , Paul Durrant , Jean-Philippe Ouellet , =?UTF-8?Q?Marek_Marczykowski=2DG=C3=B3recki?= , Jason Andryuk , eric chanudet , Chris Rogers , Rich Turner , Stefano Stabellini , Wei Liu , Artem Mygaiev , demi@invisiblethingslab.com, George Dunlap , damien.thenot@vates.fr, Wei Chen Content-Type: multipart/alternative; boundary="0000000000004a724505cb5de215" --0000000000004a724505cb5de215 Content-Type: text/plain; charset="UTF-8" Design Session notes for: VirtIO Cross-Project BoF (Birds of a Feather) for Xen and Guest OS (Linux, Windows, FreeBSD) developers --------------------------- Xen Design & Developer Summit, 27th May 2021 Session Host: Juergen Gross Notes by: Christopher Clark, with thanks to Rich Persaud Apologies for the delay in posting these, solely my responsibility. - Christopher ============================================================ Session Context: There are three separate recent approaches within the Xen community to enabling use of VirtIO device drivers in guest virtual machines with the Xen hypervisor, and a fourth older completed project. (Placeholder names are assigned to each of these below for ease of reference.) In addition, Linaro has an active project 'Stratos' pursuing: "Establish virtio as the standard interface between hypervisors, freeing a mobile, industrial or automotive platform to migrate between hypervisors and reuse the backend implementation." - https://linaro.atlassian.net/wiki/spaces/STR/overview - https://projects.linaro.org/projects/STR/summary - https://op-lists.linaro.org/mailman/listinfo/stratos-dev -------------------- * 'VirtIO-EPAM': enabling existing VirtIO-MMIO transport on Xen, using foreign mappings and an IOREQ server. by EPAM and others, with focus on Xen on Arm platforms. Enables use of the existing standardized VirtIO-MMIO transport driver, which is present in the mainline Linux kernel, using Xen's IOREQ emulation infrastructure and use of privileged foreign mappings to establish shared memory for access to guest data by the device model backend. Status: Patches are in progress towards Xen on the xen-devel mailing list. The presentation at Linaro Connect 2021 includes a working demonstration. VirtIO on Xen hypervisor (Arm), Oleksandr Tyshchenko, EPAM, Linaro Connect 2021 https://static.linaro.org/connect/lvc21/presentations/lvc21-314.pdf https://www.youtube.com/watch?v=XE5Rn8KFunk -------------------- * 'VirtIO-SuSE': introducing a new VirtIO transport driver that uses Xen grants. by SuSE, presented at this Xen Summit. A new VirtIO transport device driver is added to the guest kernel, to translate guest physical addresses into grant references, enabling VirtIO data path communication over mutually-negociated shared memory regions between the guest virtual machine and the device model backend. Improves isolation as backend does not need privilege over the guest to perform foreign mappings. Grant references are a Xen-specific interface. Design supports driver domains. Status: A prototype is described in the presentation at this Xen Summit 2021. VirtIO and Xen with Full Grant Support: https://static.sched.com/hosted_files/xen2021/bf/Thursday_2021-Xen-Summit-virtio.pdf https://www.youtube.com/watch?v=IrlEdaIUDPk&list=PLYyw7IQjL-zGcRPN6EjiTuFVGo4A6KCNf&index=25 -------------------- * VirtIO-Argo: introducing a new VirtIO transport driver that uses Argo for interdomain communication, supporting isolation and Mandatory Access Control. Design and analysis performed within the OpenXT and Xen communities. A new VirtIO transport device driver is added to the guest kernel to transmit data between the guest domain and the domain hosting the device model via Argo rings: a Hypervisor-Mediated data eXchange protocol where the hypervisor transfers the data, being trusted to strictly adhere to the delivery protocol. Supports stronger isolation properties and enforcement of Mandatory Access Control security policy over interdomain communication. Does not use shared memory between domains. Development of a Hypervisor-agnostic interface for Argo has been proposed and discussed within the Xen community. Design supports driver domains. Status: Design and analysis published; funding required for development to proceed. VirtIO-Argo: Documentation at the OpenXT wiki: https://openxt.atlassian.net/wiki/spaces/DC/pages/1348763698/VirtIO%2BArgo VirtIO-Argo Development: https://openxt.atlassian.net/wiki/spaces/DC/pages/1696169985/VirtIO-Argo%2BDevelopment%2BPhase%2B1 Minutes from the Argo HMX Transport for VirtIO topic call, 14th January 2021: https://lists.xenproject.org/archives/html/xen-devel/2021-02/msg01422.html -------------------- * 'VirtIO-Xen-GSoC': 2011 VirtIO on Xen student project A Google Summer of Code project by Wei Liu investigated enabling VirtIO on Xen. A working prototype was produced for both PV and HVM guests, using XenBus and the Qemu VirtIO backends. PV guests require a guest kernel patch to translate guest physical addresses to machine addresses in VirtIO rings. Status: project completed. https://wiki.xenproject.org/wiki/Virtio_On_Xen ============================================================ Summary of the VirtIO Design Session: xl toolstack guest config file syntax for VirtIO devices: - Recommend: mix of: device-specific config (eg. disk, net) plus support for generic VirtIO device config (eg. esoteric devices) VirtIO spec: - spec change needed? understood as not mandatory - v1.1 has a platform feature for DMA addr translation: enables transport driver to use any of grants, pre-shared memory, Argo in the data path - ie. does not force use of (guest) physical addrs in the ring - open question re: Linux and qemu acceptance of non-standardized driver Guest access to new VirtIO transport - for Argo or grants, add new transport driver (eg. out of tree module) Performance, standardization - different characteristics on different architectures; motivates development and deployment of different transports for separate cases - difficulty of ensuring correctness with shared memory vs. performance achievable with some configurations Atomics in shared memory, Arm, "Fat Virtqueue" development - Arm and RISC-V have challenges with atomic inst in shared memory - VirtIO-SuSE (using grants) useful enough for consideration - Wind River preshared-memory memcpy approach (OpenAMP/kvmtool) - Linaro "Fat Virtqueue" under development: pass data within enlarged rings Data copies with Argo and shared memory transports - discussion of copies made by different transports, different conditions - data copies performed to protect correctness in communication Ecosystems, differentiation - standarization of VirtIO shifted economics for hypervisor developers - Mandatory Access Control with Xen technologies will be a Xen advantage ============================================================ Detailed notes for the Design Session: Rich (OpenXT): introducing session; to talk about: - how any solution will be ratified by the VirtIO/OASIS community - esp automotive use cases: a lot of attention paid to formal acceptance of any VirtIO solution - non-Linux guest VMs - Windows is used in OpenXT, Qubes - FreeBSD is popular for networking and storage Roger (Citrix; x86 maintainer) [chat]: I wanted to ask whether the Linux kernel /QEMU code could be accepted without any spec change? --- topic: xl toolstack guest config file syntax for VirtIO devices Juergen (SUSE; PV interfaces maintainer): shared window with VM config: ------------------------ disk=[ 'file:/home/vm/upstream/image,hda,w', ] vif=[ 'mac:00:16:3e:06:a7:21,bridge=br0', ] vfb=[ 'vnclisten=localhost:0', ] # device_model_args=[ '-drive', 'file=/home/vm/sle15sp3/image,if=virtio,index=1,media=disk,format=raw,cache=writeback' ] device_model_args=[ '-drive', 'file=/home/vm/sle15sp3/image,if=none,id=drive-virtio-disk0,format=raw', '-device', 'virtio-blk-pci,scsi=off,drive=drive-virtio-disk0,id=virtio-disk0,bootindex=0,disable-legacy=on' ] ------------------------ Juergen: Request for input on xl config file syntax for configuring VirtIO devices - see device_model_args in example (force VirtIO block to non-legacy mode) - alt option: add a 'virtio' specifier to the disk line - see recent patch by Artem - need to consider generic devices: non-network, non-disk device classes Q: Should VirtIO disk be added under 'disk', or a new special VirtIO disk? Julien (Amazon; Arm maintainer): - want to avoid having one vif, one framebuffer, one gps, etc. - so instead have generic device options (eg. block, gps) - ie. similar to Qemu Marek (Qubes; Python bindings maintainer): - libvirt bindings perspective: Preference for the other way - don't want duplicated eg. disk handling, for the VirtIO case - unified handling for a device class is more convenient for API users Stefano (Xilinx; Arm maintainer): - Disk is a special case: config already has a line for disk, already have a way to specify different types - network may be similar - alt method is better for other devices, eg. virtio-rng - for those, device_model_arg is probably the best Andy (Citrix, x86 maintainer): - a lot of this is PCI-based, even if non-DMA transport so: - need to preserve support for multi-IOREQ servers - feasible to have VirtIO backends that are not Qemu - so: don't tie the configuration to Qemu OleksandrT (EPAM) [chat]: Initially I created a new "vdisk" property for virto.disk, but was asked to reuse existing "disk" configuration in libxl if possible. https://lists.xenproject.org/archives/html/xen-devel/2021-05/msg01174.html Juergen: ack; esp for Arm, mmio-based config: so we should be flexible. Aiming to determine: 1: Configuration format for VirtIO devices in guests 2: Surfacing VirtIO devices in guest VMs: - tie it to the PCI specification or not? - challenge if guests do not have PCI detection - Responses: - PCI is fairly standard - issue with mmio: hotplugging devices - ranges to be configured => need number of devices in advance - hotplug already requires upfront work, due to grants, events - PCI and mmio are similar; choice depends on guest and ecosystem George (Citrix; Xen Community Manager): - makes sense for a case to standardize on Argo? - Argo vs grant table vs shared memory : why duplicate the extra effort? - how much effort duplicated for multiple? is it pretty easy to swap them out? Rich [chat]: Important for automotive, FuSA, security Christopher (Apertus/Star Lab; Argo maintainer): - Options are not exclusive: VirtIO can use different transports per-device - Transports orthogonal eg. Argo devices enumerable via the VirtIO-Argo driver; Argo enables Mandatory Access Control over the data transport --- topic: VirtIO spec change; addresses on VirtIO rings Concern: requirement for a VirtIO spec change - Discussion re: is spec change mandatory? - may be needed: VirtIO spec says pass guest physical addr on ring - may not be: translation step in the transport layer; enables translation so don't need to change spec - is spec change needed for config negotiation, to announce feature? - response: no; transport driver does enumerations, so up to the driver Stefano: "VirtIO" means different things: spec, transport, drivers - since transports are part of the spec: VirtIO-PCI, VirtIO-MMIO, ..., adding one (VirtIO-Argo) means adding to the spec Daniel: no .. Juergen: VirtIO spec does not demand physical addresses on the ring pages - DMA addresses are allowed - eg. a special DMA mechanism, which happens to be grants, is fine. - ie. We have a special DMA engine. Andy: Yes. DMA addresses != identity map onto physical or guest phys addresses Daniel: there is a spec for the transports: if implementing a PCI transport, or a MMIO transport, has certain characteristics of how those should behave; so the driver-to-transport interface is fixed. It doesn't fix the transport back, which was the analysis that Christopher and I were looking at. Fixed from front-end perspective: interface between the driver and transport. If the transport presents as a PCI device transport, there's an interface that the driver expects that transport to provide. - It doesn't fix how it happens from the transport back. George: Frontend VirtIO driver hands phys addr to frontend transport and the frontend transport can convert it to eg. grant tables to do what it wants Daniel: right - plus more behaviours, esp for PCI: eg. structures expected to be there so the drivers can expect a common behaviour for any PCI transport - transport is translation layer, can handle dealing with actual physical backend mechanism that you're going over Stefano: so plan is to add new transport: would that need to be in the spec? Daniel: no --- topic: Guest access to new VirtIO transport George: VirtIO frontend drivers would work with the new transport. - a current VM image won't have transport implemented - have to update to a new version of kernel, or - a new version of image to get new transport? Daniel: Well, that's one way; for Argo, can present as either a PCI transport or a MMIO transport to the driver, so the driver understands how to interact with the transport; and the transport handles moving data back. For Argo, we move everything onto Argo rings. To gain that on Linux, can do an out of tree kernel module, and load that without having to recompile the entire kernel (unless they don't have loadable module support). - responses: - needs the frontend transport in the guest; - so can't just use an existing image unmodified -- need the compiled kernel driver loaded to make the transport available - objective will be to add it to the upstream Linux kernel Andy: might be able to get a frontend Windows driver somewhere useful Stefano: fewer changes to the spec are better: looks like nothing, fantastic Second is changes to the code; seems limited to transport driver, is a lot better than having to change all the frontend drivers - Christopher: yes; point is to keep all of those and should be able to plug them into backend drivers in the Qemu implementation. - Juergen: Yes. Actual backends unchanged and only lower levels of transport layer need some modifications. - ie. for all implementations of backend infrastructure: - Qemu - the kernel for the vhost backends - vhost-user, all the user daemons implementing the backend - Andy: sounds great overall ---- topic: Performance George: whether to use Argo or grant tables or something else: - Andy: think the answer is that we need both - Juergen: Yes. - Andy: there are people that need to not have shared memory, and Argo is an option there, and there are people who will want shared memory because its faster. - ...: Is it? - Andy: Yes. Damien Thenot [chat]: Shared memory would be interesting for DPU too Stefano: Performance is a good metric; - Able to convince third party proprietary vendor to add a driver? - some sort of shared memory useful as a last resort, fallback: - ie. easier to say "just add a memcpy" and to copy to the pre-shared memory region George: Ian Pratt presentation said: - copying is faster than sharing memory - sharing memory is so difficult that noone is smart enough to do it, and we were all fools back in the 2000s to think we were smart enough to do it Christopher [chat]: https://platformsecuritysummit.com/2018/speaker/pratt Andy: Not using shared memory can get around a lot of common bugs, but if you know how to do shared memory, it is still faster than data copying in enough cases for it to be relevant, for us to care. Marek: if you can avoid mapping and unmapping all the time eg. can use well known regions. Andy: a lot of network performance in XenServer is from not mapping - dom0 constructs a scatter-gather over the guest memory (a granted area, so permissions work) - never actually touched - Can't do that with copying mechanism; would force a memcpy into a zero overhead transmit path Stefano: measurements so far always demonstrated grant table is slower than any memcpy mechanisms - Julien: related to atomic instructions, ref: the previous talk? - Stefano: could be; all my latest measurements are on Arm. - Andy: Different architectures will make massive differences here Jason Andryuk (OpenXT) [chat]: @Andrew, you use netfront/back but your dom0 nic scatter/gathers over the guest's granted network frames directly? Andy [chat]: Yeah. A consequence is that dom0 never touches the mapping, so never sets the A bit, so you can skip the TLB flush on the unmap side and this is great for performance Roger [chat]: Note you need to patch Xen to not do the flush on unmap if the A bit isn't set ---- topic: Atomics in shared memory, Arm, "Fat Virtqueue" development Juergen: regarding Arm and shared pages: how does VirtIO and KVM on Arm work? Julien: don't do atomics in shared page. Lesson learned a while ago. - Xen has many uses of atomics in shared pages, eg. evtchn, etc. For VirtIO, would be nicer to avoid doing the same again. Stefano: Could we require Arm 8.1? (Is 8.1 introduces the new atomics, or 8.2?) Julien: Yes, but limited hardware available today - latest may have it, but not Qemu - looks like RISC-V may have the same issues Demi Marie (Qubes OS) [chat]: RISC-V only has 32-bit atomics Andy: VirtIO-Grant [ie. VirtIO-SuSE in these notes] may not be perfect for all future use cases and other options exist - but still enough cases that it is worth considering Demi Marie [chat]: Long-term fix is probably to change the guest-visible ABI to not require atomics in shared memory Julien: how can it be used with other hypervisors? - eg. for Argo, looking at something that can be used in other hypervisors - not possible with grant table, because of the problems I mentioned. - want to avoid having a Xen-specific driver, ie. tying VirtIO transport to Xen due to use of grant table Stefano: two related activities, both based on shared memory: - one driven by Wind River: memcpy-based approach - presharing memory, and picking addresses off the shared region Stefano [chat]: This is WindRiver KVMtools that does shared memory for Virtio https://github.com/OpenAMP/kvmtool Stefano: second approach is from Linaro: "Fat Virtqueue" - increase the ring size and pick addresses within the ring only - So the shared memory region is only the ring, and the buffers are within the ring. Pointer points to things within the ring. George: summarizing: - on Arm copying might be faster, and there are other advantages as well; - on x86, things may be different so: - SuSE and Citrix may work on the grant table one, and - Epam and Arm, etc. may work on the Argo one and people can understand why they're choosing which one. George: Can you also do driver domain things with Argo? Daniel: Yes --- topic: Data copies with Argo and shared memory transports Stefano: with Argo is there a memcpy, or more than one memcpy? who would do it? Christopher: hypervisor does the copy for the transport. - guest hypercall op to register a ring, allows hypervisor to blit data in; - can think of as a DMA-style operation to deliver data to the guest Juergen: So for each I/O data, there are three copies: - first, into the ring, then by the hypervisor to the other domain, and then out of the ring of the other domain to the target address, right? Andy: That's correct if both the source and destination are buffering the I/O in and out of the transport. Daniel: Right Andy: Buffering is probably because the backend is normally shared memory. If you've got a guarantee that it's not shared memory between frontend and backend, then neither the front or the back VirtIO driver need to buffer in and out of the transport Juergen: ok, for a disk I/O: have user data in the guest, want to write to disk Arbitrary data in memory, needs to be written to the Argo ring buffer, right? That's copy one. Andy: No; only destination has an Argo ring. Source just passes arbitrary addresses, like scatter-gather DMA. Juergen: OK, so like grant copy Andy: Yes. Julien: With Argo, are the pages always mapped in Xen? - Christopher: Yes, for the rings the way that Argo works at the moment is, yes, once you register a ring that mapping is retained so the hypervisor can send to it when a hypercall is invoked. - Julien: OK Demi Marie: is it possible for Argo to copy memory from guest one userspace to the ring in guest two? - re: disk I/O: from ZFS issue tracker: have to take copies because is not safe to operate on data shared with untrusted parties - So most cases you're going to have to have a copy. - Only exception: extremely carefully written data sources, destinations - careful to only make loads exactly once - or tools like everparse, or another tool that generates formally-verified binary parsers, immune to double-fetch bugs - so: prefer to just take the copy - because memcpy on modern processors is very, very fast - especially while it's stayed in cache George: Andy was saying: some people definitely going to want Argo, because it's copying instead of shared memory, and double-fetch issues with shared memory is definitely an issue Andy: Yes. A lot of reasons why using shared memory is hard to do correctly; not impossible but it is hard. --- topic: Configuration syntax (continued) Juergen: choice: generic virtio device configuration, vs individual device-specific stuff, or just mix variants? Roger [chat]: I think both Christopher: good to have generic + allow specialization if you care Marek: Yes; eg. for network devices, might want a different copying mechanism if you can avoid copies for network. Same may not be doable for disk, so might want different mechanisms for disk and network devices. Juergen: Should VirtIO disk be labelled under the disk item of the guest config, or a specific virtio disk item? Or virtio-device type = disk, or whatever. Roger: - keep the old disk options, expand to support VirtIO - add a generic VirtIO option for more esoteric devices that we don't support in any other way. Disks and vifs need a type parameter to select VirtIO as backend. Juergen: then have a transport layer specification: (eg. don't care, or grants, or Argo, or whatever) George: We have the same thing for PCI (strict, relaxed, ...) ie. Set a global default for xl, plus override in specific domain config --- topic: Interface to adapt to platform transport Juergen: spec bit is: VIRTIO_F_ACCESS_PLATFORM feature bit - indicates "the device can be used on a platform where the device access to data memory is limited, and/or translated" Exactly what we want; works for grants, etc. - is a generic bit from newer virtio spec, not a Xen-specific bit - in current impl, assumes running on Xen and means grants, because assumes that everything is done for addresses going into the ring --- topic: Ecosystems, differentiation Rich: On standardization of VirtIO: it commoditized the driver interface - now all hypervisors implement VirtIO because it's too expensive to do otherwise. - using Argo transport to add Mandatory Access Control (needed by many guests) is an advantage for Xen, since only with Xen will you get the strong guarantees from Argo. Especially with Hyperlaunch, and all the other integrity pieces. - Challenging for other hypervisors to do MAC transport for VirtIO. End of session ============================================================ Open Issues / Technical questions: - Method of discovery of available transport drivers, negociation which to use - OASIS/VirtIO Standardization required? (eg. feature bits needed?) - Upstreaming path for different pieces to: Linux kernel, Qemu, elsewhere - including enabling guest support for FreeBSD, Windows, etc. - Development of VirtIO "Fat Virtqueues": how does this affect system design? - Design for interaction with guest virtual IOMMU - ref: VirtIO-iommu - VFIO for device model backends - Support for complex VirtIO drivers: eg. framebuffers (shared memory regions) ============================================================ Areas suitable for investment to support VirtIO on Xen: - Development of the Hypervisor-agnostic interface for Argo Ref: Xen and OpenXT community discussion minutes: https://lists.xenproject.org/archives/html/xen-devel/2021-02/msg01422.html - Development of the VirtIO-Argo system Project analysis and design documentation: https://openxt.atlassian.net/wiki/spaces/DC/pages/1696169985/VirtIO-Argo%2BDevelopment%2BPhase%2B1 - VirtIO-focussed test cases for the Xen Test Framework - to provide coverage of the hypervisor interfaces used by VirtIO transports - extend the framework capabilities to enable new tests (eg. multi-VM cases) https://xenbits.xen.org/docs/xtf/index.html - development of support for Arm platforms with XTF - Rust and Go languages toolstack development for Xen - Investment in the Xen toolstack is needed to support hypervisor feature development. Toolstack support is necessary for enabling VirtIO guests. - Work towards enabling Xen tools in Rust has started: https://github.com/xcp-ng/xenopsd-ng - Work towards enabling Xen tools in Go has started: https://lists.xenproject.org/archives/html/xen-devel/2021-04/msg01744.html - System image test integration with Yocto/Openembedded and Qemu - Xen and the Xen Test Framework can already be run within Qemu for x86 in the standard meta-virtualization environment; Arm platform support needs to be completed, with coverage for VirtIO guests, and Continuous Integration enabled https://lists.yoctoproject.org/g/meta-virtualization/message/6405 - to evaluate: VirtIO as a DISTRO_FEATURE or MACHINE_FEATURE - Creation of documentation for Argo - implementation documentation exists: https://xenbits.xen.org/docs/4.15-testing/designs/argo.html https://static.sched.com/hosted_files/xensummit19/92/Argo%20and%20HMX%20-%20OpenXT%20-%20Christopher%20Clark%20-%20Xen%20Summit%202019.pdf https://www.youtube.com/watch?v=cnC0Tg3jqJQ - user interface / client / kernel developer documentation is needed - Development items for Argo: https://openxt.atlassian.net/wiki/spaces/DC/pages/737345538/Argo+Hypervisor-Mediated+data+eXchange+Development - Performance profiling of VirtIO-on-Xen systems across hardware architectures ============================================================ Additional References: VirtIO Specification v1.1, OASIS, 11th April 2019: https://docs.oasis-open.org/virtio/virtio/v1.1/virtio-v1.1.html VirtIO spec maintainers repository: https://github.com/oasis-tcs/virtio-spec Organization for the Advancement of Structured Information Standards https://www.oasis-open.org ACPI Virtal I/O Translation Table (VIOT) DRAFT v9, December 2020: https://jpbrucker.net/virtio-iommu/viot/viot-v9.pdf https://lore.kernel.org/linux-acpi/20210610075130.67517-2-jean-philippe@linaro.org/T/ Linaro: Stratos Project: Auto / Industrial Demonstrable Milestones https://linaro.atlassian.net/wiki/spaces/STR/pages/28503377401/Demonstrable+artifacts OpenXT: VirtIO and Argo: https://openxt.atlassian.net/wiki/spaces/DC/pages/1348763698/VirtIO%2BArgo OpenXT: VirtIO-Argo Development: https://openxt.atlassian.net/wiki/spaces/DC/pages/1696169985/VirtIO-Argo%2BDevelopment%2BPhase%2B1 OpenXT: Analysis of Argo as a transport medium for VirtIO: https://openxt.atlassian.net/wiki/spaces/DC/pages/1333428225/Analysis+of+Argo+as+a+transport+medium+for+VirtIO Virtio with Argo for Xen, Mandatory Access Control Meeting of Virtualization Experts Group of Automotive Grade Linux, 18th Aug, 2020 https://lists.automotivelinux.org/g/agl-dev-community/attachment/8595/0/Argo%20and%20VirtIO.pdf VirtIO on Xen hypervisor (Arm), Oleksandr Tyshchenko, EPAM, Linaro Connect 2021 https://static.linaro.org/connect/lvc21/presentations/lvc21-314.pdf https://www.youtube.com/watch?v=XE5Rn8KFunk Xen wiki: Argo https://wiki.xenproject.org/wiki/Argo:_Hypervisor-Mediated_Exchange_(HMX)_for_Xen OpenXT: Argo: Hypervisor-Mediated data eXchange: Development: https://openxt.atlassian.net/wiki/spaces/DC/pages/737345538/Argo%2BHypervisor-Mediated%2Bdata%2BeXchange%2BDevelopment Xen wiki: Virtio On Xen https://wiki.xenproject.org/wiki/Virtio_On_Xen XCP-ng: IOREQ Server: Device Emulation in the Xen Hypervisor https://xcp-ng.org/blog/2020/06/03/device-emulation-in-the-xen-hypervisor/ DEMU https://xenbits.xen.org/gitweb/?p=people/pauldu/demu.git Video for this Design Session: https://www.youtube.com/watch?v=Ib0OdpHZ-G0&list=PLYyw7IQjL-zGcRPN6EjiTuFVGo4A6KCNf&index=29 --0000000000004a724505cb5de215 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Design Session notes for: VirtIO Cross-Project BoF (Birds = of a Feather) for Xen and Guest OS (Linux, Windows, FreeBSD) developers
= ---------------------------
Xen Design & Developer Summit, 27th May = 2021
Session Host: Juergen Gross
Notes by: Christopher Clark, with th= anks to Rich Persaud

Apologies for the delay in posting these, solel= y my responsibility.
- Christopher

=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D
Session Context:

There are three separate rece= nt approaches within the Xen community to enabling
use of VirtIO device = drivers in guest virtual machines with the Xen hypervisor,
and a fourth = older completed project.
(Placeholder names are assigned to each of thes= e below for ease of reference.)

In addition, Linaro has an active pr= oject 'Stratos' pursuing:
=C2=A0 =C2=A0 "Establish virtio a= s the standard interface between hypervisors,
=C2=A0 =C2=A0 freeing a mo= bile, industrial or automotive platform to migrate between
=C2=A0 =C2=A0= hypervisors and reuse the backend implementation."

=C2=A0 =C2= =A0 - htt= ps://linaro.atlassian.net/wiki/spaces/STR/overview
=C2=A0 =C2=A0 - <= a href=3D"https://projects.linaro.org/projects/STR/summary">https://project= s.linaro.org/projects/STR/summary
=C2=A0 =C2=A0 - https://op-lists.linaro.= org/mailman/listinfo/stratos-dev

--------------------
* '= VirtIO-EPAM': enabling existing VirtIO-MMIO transport on Xen, using for= eign
mappings and an IOREQ server.
by EPAM and others, with focus on = Xen on Arm platforms.

Enables use of the existing standardized VirtI= O-MMIO transport driver, which is
present in the mainline Linux kernel, = using Xen's IOREQ emulation
infrastructure and use of privileged for= eign mappings to establish shared
memory for access to guest data by the= device model backend.

Status: Patches are in progress towards Xen o= n the xen-devel mailing list.
The presentation at Linaro Connect 2021 in= cludes a working demonstration.

VirtIO on Xen hypervisor (Arm), Olek= sandr Tyshchenko, EPAM, Linaro Connect 2021
https://static.linaro.o= rg/connect/lvc21/presentations/lvc21-314.pdf
https://www.youtube.com/watch?v=3DXE5Rn8= KFunk

--------------------
* 'VirtIO-SuSE': introduci= ng a new VirtIO transport driver that uses Xen grants.
by SuSE, presente= d at this Xen Summit.

A new VirtIO transport device driver is added = to the guest kernel, to
translate guest physical addresses into grant re= ferences, enabling VirtIO data
path communication over mutually-negociat= ed shared memory regions between the
guest virtual machine and the devic= e model backend. Improves isolation as
backend does not need privilege o= ver the guest to perform foreign mappings.
Grant references are a Xen-sp= ecific interface. Design supports driver domains.

Status: A prototyp= e is described in the presentation at this Xen Summit 2021.

VirtIO a= nd Xen with Full Grant Support:
https://static.sch= ed.com/hosted_files/xen2021/bf/Thursday_2021-Xen-Summit-virtio.pdf
<= a href=3D"https://www.youtube.com/watch?v=3DIrlEdaIUDPk&list=3DPLYyw7IQ= jL-zGcRPN6EjiTuFVGo4A6KCNf&index=3D25">https://www.youtube.com/watch?v= =3DIrlEdaIUDPk&list=3DPLYyw7IQjL-zGcRPN6EjiTuFVGo4A6KCNf&index=3D25=

--------------------
* VirtIO-Argo: introducing a new VirtIO= transport driver that uses Argo for
interdomain communication, supporti= ng isolation and Mandatory Access Control.
Design and analysis performed= within the OpenXT and Xen communities.

A new VirtIO transport devic= e driver is added to the guest kernel to transmit
data between the guest= domain and the domain hosting the device model via Argo
rings: a Hyperv= isor-Mediated data eXchange protocol where the hypervisor
transfers the = data, being trusted to strictly adhere to the delivery protocol.
Support= s stronger isolation properties and enforcement of Mandatory Access
Cont= rol security policy over interdomain communication. Does not use shared
= memory between domains.
Development of a Hypervisor-agnostic interface f= or Argo has been proposed
and discussed within the Xen community. Design= supports driver domains.

Status: Design and analysis published; fun= ding required for development to
proceed.

VirtIO-Argo: Documentat= ion at the OpenXT wiki:
https://openxt.atlassian.net/wiki/sp= aces/DC/pages/1348763698/VirtIO%2BArgo
VirtIO-Argo Development:
<= a href=3D"https://openxt.atlassian.net/wiki/spaces/DC/pages/1696169985/Virt= IO-Argo%2BDevelopment%2BPhase%2B1">https://openxt.atlassian.net/wiki/spaces= /DC/pages/1696169985/VirtIO-Argo%2BDevelopment%2BPhase%2B1
Minutes f= rom the Argo HMX Transport for VirtIO topic call, 14th January 2021:
https://lists.xenproject.org/archives/html/xen-devel/2021-02/msg01= 422.html

--------------------
* 'VirtIO-Xen-GSoC': 20= 11 VirtIO on Xen student project
A Google Summer of Code project by Wei = Liu investigated enabling VirtIO on Xen.

A working prototype was pro= duced for both PV and HVM guests, using XenBus and
the Qemu VirtIO backe= nds. PV guests require a guest kernel patch to translate
guest physical = addresses to machine addresses in VirtIO rings.

Status: project comp= leted.

ht= tps://wiki.xenproject.org/wiki/Virtio_On_Xen

=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D
Summary of the VirtIO Design Session:

xl toolstack g= uest config file syntax for VirtIO devices:
=C2=A0 =C2=A0 - Recommend: m= ix of: device-specific config (eg. disk, net) plus support for
=C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0generic VirtIO devic= e config (eg. esoteric devices)

VirtIO spec:
=C2=A0 =C2=A0 - spec= change needed? understood as not mandatory
=C2=A0 =C2=A0 - v1.1 has a p= latform feature for DMA addr translation: enables transport
=C2=A0 =C2= =A0 =C2=A0 driver to use any of grants, pre-shared memory, Argo in the data= path
=C2=A0 =C2=A0 =C2=A0 =C2=A0 - ie. does not force use of (guest) ph= ysical addrs in the ring
=C2=A0 =C2=A0 - open question re: Linux and qem= u acceptance of non-standardized driver

Guest access to new VirtIO t= ransport
=C2=A0 =C2=A0 - for Argo or grants, add new transport driver (e= g. out of tree module)

Performance, standardization
=C2=A0 =C2=A0= - different characteristics on different architectures; motivates
=C2= =A0 =C2=A0 =C2=A0 development and deployment of different transports for se= parate cases
=C2=A0 =C2=A0 - difficulty of ensuring correctness with sha= red memory vs. performance
=C2=A0 =C2=A0 =C2=A0 achievable with some con= figurations

Atomics in shared memory, Arm, "Fat Virtqueue"= development
=C2=A0 =C2=A0 - Arm and RISC-V have challenges with atomic = inst in shared memory
=C2=A0 =C2=A0 - VirtIO-SuSE (using grants) useful = enough for consideration
=C2=A0 =C2=A0 - Wind River preshared-memory mem= cpy approach (OpenAMP/kvmtool)
=C2=A0 =C2=A0 - Linaro "Fat Virtqueu= e" under development: pass data within enlarged rings

Data copi= es with Argo and shared memory transports
=C2=A0 =C2=A0 - discussion of = copies made by different transports, different conditions
=C2=A0 =C2=A0 = - data copies performed to protect correctness in communication

Ecos= ystems, differentiation
=C2=A0 =C2=A0 - standarization of VirtIO shifted= economics for hypervisor developers
=C2=A0 =C2=A0 - Mandatory Access Co= ntrol with Xen technologies will be a Xen advantage


=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D
Detailed notes for the Design Session:

Rich (O= penXT): introducing session; to talk about:
=C2=A0 =C2=A0 - how any solu= tion will be ratified by the VirtIO/OASIS community
=C2=A0 =C2=A0 =C2=A0= =C2=A0 - esp automotive use cases: a lot of attention paid to formal
= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 acceptance of any VirtIO solution
=C2=A0 =C2=A0 - non-Linux guest VMs
=C2=A0 =C2=A0 =C2=A0 =C2=A0 - Windo= ws is used in OpenXT, Qubes
=C2=A0 =C2=A0 =C2=A0 =C2=A0 - FreeBSD is pop= ular for networking and storage

Roger (Citrix; x86 maintainer) [chat= ]: I wanted to ask whether the Linux kernel
/QEMU code could be accepted= without any spec change?

--- topic: xl toolstack guest config file = syntax for VirtIO devices

Juergen (SUSE; PV interfaces maintainer): = shared window with VM config:
------------------------
disk=3D[ '= file:/home/vm/upstream/image,hda,w', ]
vif=3D[ 'mac:00:16:3e:06:= a7:21,bridge=3Dbr0', ]
vfb=3D[ 'vnclisten=3Dlocalhost:0', ]<= br># device_model_args=3D[ '-drive', 'file=3D/home/vm/sle15sp3/= image,if=3Dvirtio,index=3D1,media=3Ddisk,format=3Draw,cache=3Dwriteback'= ; ]
device_model_args=3D[ '-drive', 'file=3D/home/vm/sle15sp= 3/image,if=3Dnone,id=3Ddrive-virtio-disk0,format=3Draw', '-device&#= 39;, 'virtio-blk-pci,scsi=3Doff,drive=3Ddrive-virtio-disk0,id=3Dvirtio-= disk0,bootindex=3D0,disable-legacy=3Don' ]
------------------------<= br>
Juergen: Request for input on xl config file syntax for configuring = VirtIO
devices
=C2=A0 =C2=A0 - see device_model_args in example (forc= e VirtIO block to non-legacy mode)
=C2=A0 =C2=A0 - alt option: add a = 9;virtio' specifier to the disk line
=C2=A0 =C2=A0 =C2=A0 =C2=A0 - s= ee recent patch by Artem
=C2=A0 =C2=A0 - need to consider generic device= s: non-network, non-disk device classes

Q: Should VirtIO disk be add= ed under 'disk', or a new special VirtIO disk?

Julien (Amazo= n; Arm maintainer):
=C2=A0 =C2=A0 - want to avoid having one vif, one fr= amebuffer, one gps, etc.
=C2=A0 =C2=A0 =C2=A0 =C2=A0 - so instead have g= eneric device options (eg. block, gps)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 - ie. similar to Qemu

Marek (Qubes; Python bindings maint= ainer):
=C2=A0 =C2=A0 - libvirt bindings perspective: Preference for the= other way
=C2=A0 =C2=A0 =C2=A0 =C2=A0 - don't want duplicated eg. d= isk handling, for the VirtIO case
=C2=A0 =C2=A0 =C2=A0 =C2=A0 - unified = handling for a device class is more convenient for API users

Stefano= (Xilinx; Arm maintainer):
=C2=A0 =C2=A0 - Disk is a special case: confi= g already has a line for disk,
=C2=A0 =C2=A0 =C2=A0 already have a way t= o specify different types - network may be similar
=C2=A0 =C2=A0 - alt m= ethod is better for other devices, eg. virtio-rng
=C2=A0 =C2=A0 =C2=A0 = =C2=A0 - for those, device_model_arg is probably the best

Andy (Citr= ix, x86 maintainer):
=C2=A0 =C2=A0 - a lot of this is PCI-based, even if= non-DMA transport so:
=C2=A0 =C2=A0 =C2=A0 =C2=A0 - need to preserve su= pport for multi-IOREQ servers
=C2=A0 =C2=A0 =C2=A0 =C2=A0 - feasible to = have VirtIO backends that are not Qemu
=C2=A0 =C2=A0 - so: don't tie= the configuration to Qemu

OleksandrT (EPAM) [chat]: Initially I cre= ated a new "vdisk" property for
virto.disk, but was asked to r= euse existing "disk" configuration in libxl
if possible.
https://lists.xenproject.org/archives/html/xen-devel/2021-05/msg0= 1174.html

Juergen: ack; esp for Arm, mmio-based config: so we sh= ould be flexible.
Aiming to determine:
=C2=A0 1: Configuration format= for VirtIO devices in guests
=C2=A0 2: Surfacing VirtIO devices in gues= t VMs:
=C2=A0 =C2=A0 =C2=A0 =C2=A0 - tie it to the PCI specification or = not?
=C2=A0 =C2=A0 =C2=A0 =C2=A0 - challenge if guests do not have PCI d= etection

=C2=A0 =C2=A0 - Responses:
=C2=A0 =C2=A0 =C2=A0 =C2=A0 -= PCI is fairly standard
=C2=A0 =C2=A0 =C2=A0 =C2=A0 - issue with mmio: h= otplugging devices
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 - ra= nges to be configured =3D> need number of devices in advance
=C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 - hotplug already requires upfron= t work, due to grants, events
=C2=A0 =C2=A0 =C2=A0 =C2=A0 - PCI and mmio= are similar; choice depends on guest and ecosystem

George (Citrix; = Xen Community Manager):
=C2=A0 =C2=A0 - makes sense for a case to standa= rdize on Argo?
=C2=A0 =C2=A0 - Argo vs grant table vs shared memory : w= hy duplicate the extra effort?
=C2=A0 =C2=A0 - how much effort duplicate= d for multiple? is it pretty easy to swap them
=C2=A0 =C2=A0 =C2=A0 out?=

Rich [chat]: Important for automotive, FuSA, security

Christ= opher (Apertus/Star Lab; Argo maintainer):
=C2=A0 =C2=A0 - Options are n= ot exclusive: VirtIO can use different transports per-device
=C2=A0 =C2= =A0 - Transports orthogonal eg. Argo devices enumerable via the VirtIO-Argo=
=C2=A0 =C2=A0 =C2=A0 driver; Argo enables Mandatory Access Control over= the data transport


--- topic: VirtIO spec change; addresses on = VirtIO rings

Concern: requirement for a VirtIO spec change

- = Discussion re: is spec change mandatory?
=C2=A0 =C2=A0 - may be needed: = VirtIO spec says pass guest physical addr on ring
=C2=A0 =C2=A0 - may no= t be: translation step in the transport layer;
=C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 enables translation so don't nee= d to change spec
=C2=A0 =C2=A0 - is spec change needed for config negoti= ation, to announce feature?
=C2=A0 =C2=A0 - response: no; transport driv= er does enumerations, so up to the driver

Stefano: "VirtIO"= ; means different things: spec, transport, drivers
=C2=A0 =C2=A0 - since= transports are part of the spec: VirtIO-PCI, VirtIO-MMIO, ...,
=C2=A0 = =C2=A0 =C2=A0 adding one (VirtIO-Argo) means adding to the spec
Daniel: = no ..

Juergen: VirtIO spec does not demand physical addresses on the= ring pages
=C2=A0 =C2=A0 - DMA addresses are allowed
=C2=A0 =C2=A0 -= eg. a special DMA mechanism, which happens to be grants, is fine.
=C2= =A0 =C2=A0 =C2=A0 =C2=A0 - ie. We have a special DMA engine.
Andy: Yes. = DMA addresses !=3D identity map onto physical or guest phys addresses
Daniel: there is a spec for the transports: if implementing a PCI transpo= rt, or
=C2=A0 a MMIO transport, has certain characteristics of how those= should behave;
=C2=A0 so the driver-to-transport interface is fixed.=C2=A0 It doesn't fix the transport back, which was the analysis that = Christopher and
=C2=A0 I were looking at.
=C2=A0 Fixed from front-end= perspective: interface between the driver and transport.
=C2=A0 If the = transport presents as a PCI device transport, there's an interface that=
=C2=A0 the driver expects that transport to provide.
=C2=A0 =C2=A0 = =C2=A0- It doesn't fix how it happens from the transport back.

G= eorge: Frontend VirtIO driver hands phys addr to frontend transport and the=
=C2=A0 =C2=A0 =C2=A0 =C2=A0frontend transport can convert it to eg. gra= nt tables to do what it wants

Daniel: right
=C2=A0 =C2=A0 - plus = more behaviours, esp for PCI: eg. structures expected to be there
=C2=A0= =C2=A0 =C2=A0 so the drivers can expect a common behaviour for any PCI tra= nsport
=C2=A0 =C2=A0 =C2=A0 =C2=A0 - transport is translation layer, can= handle dealing with actual
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 physical = backend mechanism that you're going over

Stefano: so plan is to = add new transport: would that need to be in the spec?
Daniel: no

=
--- topic: Guest access to new VirtIO transport

George: VirtIO f= rontend drivers would work with the new transport.
=C2=A0 =C2=A0 - a cur= rent VM image won't have transport implemented
=C2=A0 =C2=A0 =C2=A0 = =C2=A0 - have to update to a new version of kernel, or
=C2=A0 =C2=A0 =C2= =A0 =C2=A0 - a new version of image to get new transport?

Daniel: We= ll, that's one way; for Argo, can present as either a PCI transport or<= br>a MMIO transport to the driver, so the driver understands how to interac= t with
the transport; and the transport handles moving data back. For Ar= go, we move
everything onto Argo rings. =C2=A0
To gain that on Linux,= can do an out of tree kernel module, and load that
without having to re= compile the entire kernel (unless they don't have loadable
module su= pport).
- responses:
=C2=A0 =C2=A0 - needs the frontend transport in = the guest;
=C2=A0 =C2=A0 - so can't just use an existing image unmod= ified -- need the compiled
=C2=A0 =C2=A0 =C2=A0 kernel driver loaded to = make the transport available
=C2=A0 =C2=A0 - objective will be to add it= to the upstream Linux kernel

Andy: might be able to get a frontend = Windows driver somewhere useful

Stefano: fewer changes to the spec a= re better: looks like nothing, fantastic
Second is changes to the code; = seems limited to transport driver, is a lot
better than having to change= all the frontend drivers

=C2=A0 =C2=A0 - Christopher: yes; point is= to keep all of those and should be able to
=C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0plug them into backend drivers in = the Qemu implementation.
=C2=A0 =C2=A0 - Juergen: Yes. Actual backends u= nchanged and only lower levels of
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0transport layer need some modifications.
=C2=A0 =C2=A0 = =C2=A0 =C2=A0 - ie. for all implementations of backend infrastructure:
= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 - Qemu
=C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 - the kernel for the vhost backends
=C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 - vhost-user, all the user daemons implementing= the backend
=C2=A0 =C2=A0 - Andy: sounds great overall

---- topi= c: Performance

George: whether to use Argo or grant tables or someth= ing else:
=C2=A0 =C2=A0 - Andy: think the answer is that we need both=C2=A0 =C2=A0 - Juergen: Yes.
=C2=A0 =C2=A0 - Andy: there are people th= at need to not have shared memory, and Argo is an
=C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 option there, and there are people who will want share= d memory
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 because its faster.=C2=A0 =C2=A0 - ...: Is it?
=C2=A0 =C2=A0 - Andy: Yes.

Damien T= henot [chat]: Shared memory would be interesting for DPU too

Stefano= : Performance is a good metric;
- Able to convince third party proprieta= ry vendor to add a driver?
=C2=A0 =C2=A0 - some sort of shared memory us= eful as a last resort, fallback:
=C2=A0 =C2=A0 =C2=A0 =C2=A0 - ie. easie= r to say "just add a memcpy" and to copy to the pre-shared
=C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 memory region

George: Ian Pratt pres= entation said:
=C2=A0 =C2=A0 - copying is faster than sharing memory
= =C2=A0 =C2=A0 - sharing memory is so difficult that noone is smart enough t= o do it, and we
=C2=A0 =C2=A0 =C2=A0 were all fools back in the 2000s to= think we were smart enough to do it

Christopher [chat]: https://platformsecu= ritysummit.com/2018/speaker/pratt

Andy: Not using shared memory = can get around a lot of common bugs, but if you
=C2=A0 =C2=A0 =C2=A0 kno= w how to do shared memory, it is still faster than data copying in
=C2= =A0 =C2=A0 =C2=A0 enough cases for it to be relevant, for us to care.
Ma= rek: if you can avoid mapping and unmapping all the time
=C2=A0 =C2=A0 = =C2=A0 eg. can use well known regions.

Andy: a lot of network perfor= mance in XenServer is from not mapping
=C2=A0 =C2=A0 - dom0 constructs a= scatter-gather over the guest memory
=C2=A0 =C2=A0 =C2=A0 (a granted ar= ea, so permissions work) - never actually touched
=C2=A0 =C2=A0 - Can= 9;t do that with copying mechanism; would force a memcpy into a
=C2=A0 = =C2=A0 =C2=A0 zero overhead transmit path

Stefano: measurements so f= ar always demonstrated grant table is slower than any
=C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0memcpy mechanisms
=C2=A0 =C2=A0 - Julien: related to at= omic instructions, ref: the previous talk?
=C2=A0 =C2=A0 - Stefano: coul= d be; all my latest measurements are on Arm.
=C2=A0 =C2=A0 - Andy: Diffe= rent architectures will make massive differences here

Jason Andryuk = (OpenXT) [chat]: @Andrew, you use netfront/back but your dom0 nic
=C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0scatter/gathers over the guest's granted= network
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0frames directly?
Andy [c= hat]: Yeah. A consequence is that dom0 never touches the mapping, so
=C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0never sets the A bit, so you c= an skip the TLB flush on the unmap
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0side and this is great for performance
Roger [chat]: Note y= ou need to patch Xen to not do the flush on unmap if the A
=C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 bit isn't set


---- topic= : Atomics in shared memory, Arm, "Fat Virtqueue" development
<= br>Juergen: regarding Arm and shared pages: how does VirtIO and KVM on Arm = work?

Julien: don't do atomics in shared page. Lesson learned a = while ago.
- Xen has many uses of atomics in shared pages, eg. evtchn, e= tc.
=C2=A0 For VirtIO, would be nicer to avoid doing the same again.
=
Stefano: Could we require Arm 8.1? (Is 8.1 introduces the new atomics, = or 8.2?)

Julien: Yes, but limited hardware available today
- late= st may have it, but not Qemu
- looks like RISC-V may have the same issue= s

Demi Marie (Qubes OS) [chat]: RISC-V only has 32-bit atomics
Andy: VirtIO-Grant [ie. VirtIO-SuSE in these notes] may not be perfect fo= r all
=C2=A0 =C2=A0 =C2=A0 future use cases and other options exist - bu= t still enough cases that it
=C2=A0 =C2=A0 =C2=A0 is worth considering
Demi Marie [chat]: Long-term fix is probably to change the guest-visi= ble ABI to
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0not require atomics in shared memory

Julien: how can it be= used with other hypervisors?
- eg. for Argo, looking at something that = can be used in other hypervisors
- not possible with grant table, becaus= e of the problems I mentioned.
- want to avoid having a Xen-specific dri= ver, ie. tying VirtIO transport to Xen
=C2=A0 due to use of grant table<= br>
Stefano: two related activities, both based on shared memory:
=C2= =A0 =C2=A0 - one driven by Wind River: memcpy-based approach
=C2=A0 =C2= =A0 =C2=A0 =C2=A0 - presharing memory, and picking addresses off the shared= region

Stefano [chat]: This is WindRiver KVMtools that does shared = memory for Virtio
https:/= /github.com/OpenAMP/kvmtool

Stefano: second approach is from Lin= aro: "Fat Virtqueue"
=C2=A0 =C2=A0 =C2=A0 =C2=A0 - increase th= e ring size and pick addresses within the ring only
=C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 - So the shared memory region is only the ring, and t= he buffers are
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 within t= he ring. Pointer points to things within the ring.

George: summarizi= ng:
- on Arm copying might be faster, and there are other advantages as = well;
- on x86, things may be different
so:
- SuSE and Citrix may = work on the grant table one, and
- Epam and Arm, etc. may work on the A= rgo one
and people can understand why they're choosing which one.
George: Can you also do driver domain things with Argo?
Daniel: Yes=


--- topic: Data copies with Argo and shared memory transports
Stefano: with Argo is there a memcpy, or more than one memcpy? who wo= uld do it?

Christopher: hypervisor does the copy for the transport. =
- guest hypercall op to register a ring, allows hypervisor to blit data= in;
=C2=A0 =C2=A0 - can think of as a DMA-style operation to deliver da= ta to the guest

Juergen: So for each I/O data, there are three copie= s:
=C2=A0 =C2=A0 - first, into the ring, then by the hypervisor to the o= ther domain,
=C2=A0 =C2=A0 =C2=A0 and then out of the ring of the other = domain to the target address, right?
Andy: That's correct if both th= e source and destination are buffering the I/O in
=C2=A0 =C2=A0 =C2=A0 a= nd out of the transport.
Daniel: Right

Andy: Buffering is probabl= y because the backend is normally shared memory.
If you've got a gua= rantee that it's not shared memory between frontend and
backend, the= n neither the front or the back VirtIO driver need to buffer in and
out= of the transport

Juergen: ok, for a disk I/O: have user data in the= guest, want to write to disk
Arbitrary data in memory, needs to be writ= ten to the Argo ring buffer, right?
That's copy one.
Andy: No; on= ly destination has an Argo ring. Source just passes arbitrary
=C2=A0 =C2= =A0 =C2=A0 addresses, like scatter-gather DMA.
Juergen: OK, so like gran= t copy
Andy: Yes.

Julien: With Argo, are the pages always mapped = in Xen?
=C2=A0 =C2=A0 - Christopher: Yes, for the rings the way that Arg= o works at the moment is,
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0yes, once you register a ring that mapping is retai= ned so
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0the hypervisor can send to it when a hypercall is invoked.
=C2=A0 = =C2=A0 - Julien: OK

Demi Marie: is it possible for Argo to copy memo= ry from guest one userspace to
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= the ring in guest two?
=C2=A0 =C2=A0 - re: disk I/O: from ZFS issue tra= cker: have to take copies because is not
=C2=A0 =C2=A0 =C2=A0 safe to o= perate on data shared with untrusted parties
=C2=A0 =C2=A0 - So most cas= es you're going to have to have a copy.
=C2=A0 =C2=A0 =C2=A0 =C2=A0 = - Only exception: extremely carefully written data sources, destinations=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 - careful to only make loads exa= ctly once
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 - or tools like ever= parse, or another tool that generates
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 formally-verified binary parsers, immune to double-fetch bug= s
=C2=A0 =C2=A0 =C2=A0 =C2=A0 - so: prefer to just take the copy
=C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 - because memcpy on modern processor= s is very, very fast
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 - especia= lly while it's stayed in cache

George: Andy was saying: some peo= ple definitely going to want Argo, because
it's copying instead of s= hared memory, and double-fetch issues with shared
memory is definitely a= n issue

Andy: Yes. A lot of reasons why using shared memory is hard = to do correctly;
not impossible but it is hard.


--- topic: Co= nfiguration syntax (continued)

Juergen: choice: generic virtio devic= e configuration, vs individual
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0device-= specific stuff, or just mix variants?

Roger [chat]: I think both
=
Christopher: good to have generic + allow specialization if you care
Marek: Yes; eg. for network devices, might want a different copying me= chanism if
you can avoid copies for network. Same may not be doable for = disk, so might want
different mechanisms for disk and network devices.
Juergen: Should VirtIO disk be labelled under the disk item of the gu= est config,
or a specific virtio disk item? Or virtio-device type =3D di= sk, or whatever.

Roger:
- keep the old disk options, expand to su= pport VirtIO
- add a generic VirtIO option for more esoteric devices tha= t we don't support in
=C2=A0 any other way.
Disks and vifs need a= type parameter to select VirtIO as backend.

Juergen: then have a tr= ansport layer specification:
(eg. don't care, or grants, or Argo, or= whatever)

George: We have the same thing for PCI (strict, relaxed, = ...)
ie. Set a global default for xl, plus override in specific domain c= onfig


--- topic: Interface to adapt to platform transport
Juergen: spec bit is: VIRTIO_F_ACCESS_PLATFORM feature bit
- indicates = "the device can be used on a platform where the device
=C2=A0 acces= s to data memory is limited, and/or translated"
=C2=A0 Exactly what= we want; works for grants, etc.
=C2=A0 =C2=A0 - is a generic bit from n= ewer virtio spec, not a Xen-specific bit
=C2=A0 =C2=A0 - in current impl= , assumes running on Xen and means grants, because
=C2=A0 =C2=A0 =C2=A0 = assumes that everything is done for addresses going into the ring

--- topic: Ecosystems, differentiation

Rich: On standardization of= VirtIO: it commoditized the driver interface - now
all hypervisors impl= ement VirtIO because it's too expensive to do otherwise.
- using Arg= o transport to add Mandatory Access Control (needed by many guests)
=C2= =A0 is an advantage for Xen, since only with Xen will you get the strong=C2=A0 guarantees from Argo. Especially with Hyperlaunch, and all the othe= r
=C2=A0 integrity pieces.
=C2=A0 =C2=A0 - Challenging for other hype= rvisors to do MAC transport for VirtIO.


End of session

= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
Open Issues / Technical questions:
- Method of discovery of available transport drivers, negociation which to= use
=C2=A0 =C2=A0 - OASIS/VirtIO Standardization required? (eg. feature= bits needed?)

- Upstreaming path for different pieces to: Linux ker= nel, Qemu, elsewhere
=C2=A0 =C2=A0 - including enabling guest support fo= r FreeBSD, Windows, etc.

- Development of VirtIO "Fat Virtqueue= s": how does this affect system design?

- Design for interactio= n with guest virtual IOMMU
=C2=A0 =C2=A0 - ref: VirtIO-iommu

- VF= IO for device model backends

- Support for complex VirtIO drivers: e= g. framebuffers (shared memory regions)


=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D
Areas suitable for investment to support VirtIO on Xen:

- = Development of the Hypervisor-agnostic interface for Argo
Ref: Xen and O= penXT community discussion minutes:
https://lists.xenproject= .org/archives/html/xen-devel/2021-02/msg01422.html

- Development= of the VirtIO-Argo system
Project analysis and design documentation:=C2=A0 https://openxt.atlassian.net/wi= ki/spaces/DC/pages/1696169985/VirtIO-Argo%2BDevelopment%2BPhase%2B1
=
- VirtIO-focussed test cases for the Xen Test Framework
=C2=A0 =C2= =A0 - to provide coverage of the hypervisor interfaces used by VirtIO trans= ports
=C2=A0 =C2=A0 - extend the framework capabilities to enable new te= sts (eg. multi-VM cases)
=C2=A0 https://xenbits.xen.org/docs/xtf/index.html
=C2=A0 = =C2=A0 - development of support for Arm platforms with XTF

- Rust an= d Go languages toolstack development for Xen
=C2=A0 =C2=A0 - Investment = in the Xen toolstack is needed to support hypervisor feature
=C2=A0 =C2= =A0 =C2=A0 development. Toolstack support is necessary for enabling VirtIO = guests.
=C2=A0 =C2=A0 - Work towards enabling Xen tools in Rust has star= ted:
=C2=A0 =C2=A0 =C2=A0 =C2=A0 https://github.com/xcp-ng/xenopsd-ng
=C2=A0 =C2=A0 - Work = towards enabling Xen tools in Go has started:
=C2=A0 =C2=A0 =C2=A0 https://lists.xenproject.org/archives/html/xen-devel/2021-04/msg0174= 4.html

- System image test integration with Yocto/Openembedded a= nd Qemu
=C2=A0 =C2=A0 - Xen and the Xen Test Framework can already be ru= n within Qemu for x86
=C2=A0 =C2=A0 =C2=A0 in the standard meta-virtuali= zation environment; Arm platform support
=C2=A0 =C2=A0 =C2=A0 needs to b= e completed, with coverage for VirtIO guests, and Continuous
=C2=A0 =C2= =A0 =C2=A0 Integration enabled
=C2=A0 =C2=A0 https://lists.yoctoproje= ct.org/g/meta-virtualization/message/6405
=C2=A0 =C2=A0 - to evaluat= e: VirtIO as a DISTRO_FEATURE or MACHINE_FEATURE

- Creation of docum= entation for Argo
=C2=A0 =C2=A0 - implementation documentation exists:=C2=A0 =C2=A0 =C2=A0 https://xenbits.xen.org/docs/4.15-testing/designs/argo.= html
=C2=A0 =C2=A0 =C2=A0 https://static.sched.com/hosted_files/xen= summit19/92/Argo%20and%20HMX%20-%20OpenXT%20-%20Christopher%20Clark%20-%20X= en%20Summit%202019.pdf
=C2=A0 =C2=A0 =C2=A0 https://www.youtube.com/watch?v=3DcnC0Tg3= jqJQ
=C2=A0 =C2=A0 - user interface / client / kernel developer docu= mentation is needed

- Development items for Argo:
=C2=A0 https://openxt.atlassian.net/wiki/= spaces/DC/pages/737345538/Argo+Hypervisor-Mediated+data+eXchange+Developmen= t

- Performance profiling of VirtIO-on-Xen systems across hardwa= re architectures

=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
Additional Refere= nces:

VirtIO Specification v1.1, OASIS, 11th April 2019:
https:= //docs.oasis-open.org/virtio/virtio/v1.1/virtio-v1.1.html
VirtIO spe= c maintainers repository:
https://github.com/oasis-tcs/virtio-spec
Organization for the= Advancement of Structured Information Standards
https://www.oasis-open.org
ACPI Virtal I/O Translati= on Table (VIOT) DRAFT v9, December 2020:
https://jpbrucker.net/virtio-iommu/viot/vi= ot-v9.pdf
https://lore.kernel.org/linux-acpi/= 20210610075130.67517-2-jean-philippe@linaro.org/T/

Linaro: Strat= os Project: Auto / Industrial Demonstrable Milestones
https://linaro.atlassian.net/wiki/spaces/STR/pages/28503377401/Demonst= rable+artifacts

OpenXT: VirtIO and Argo:
https://= openxt.atlassian.net/wiki/spaces/DC/pages/1348763698/VirtIO%2BArgo
<= br>OpenXT: VirtIO-Argo Development:
= https://openxt.atlassian.net/wiki/spaces/DC/pages/1696169985/VirtIO-Argo%2B= Development%2BPhase%2B1

OpenXT: Analysis of Argo as a transport = medium for VirtIO:
https= ://openxt.atlassian.net/wiki/spaces/DC/pages/1333428225/Analysis+of+Argo+as= +a+transport+medium+for+VirtIO

Virtio with Argo for Xen, Mandato= ry Access Control
Meeting of Virtualization Experts Group of Automotive = Grade Linux, 18th Aug, 2020
https://lis= ts.automotivelinux.org/g/agl-dev-community/attachment/8595/0/Argo%20and%20V= irtIO.pdf

VirtIO on Xen hypervisor (Arm), Oleksandr Tyshchenko, = EPAM, Linaro Connect 2021
https://static.linaro.org/connect/lvc21/p= resentations/lvc21-314.pdf
https://www.youtube.com/watch?v=3DXE5Rn8KFunk

X= en wiki: Argo
https://wiki.xenproject.org/wiki/Argo:_= Hypervisor-Mediated_Exchange_(HMX)_for_Xen

OpenXT: Argo: Hypervi= sor-Mediated data eXchange: Development:
https://openxt.atlassian.net/wiki/spaces/DC/pages/= 737345538/Argo%2BHypervisor-Mediated%2Bdata%2BeXchange%2BDevelopment
Xen wiki: Virtio On Xen
https://wiki.xenproject.org/wiki/Virtio_On_Xen

X= CP-ng: IOREQ Server: Device Emulation in the Xen Hypervisor
= https://xcp-ng.org/blog/2020/06/03/device-emulation-in-the-xen-hypervisor/<= /a>

DEMU
https://xenbits.xen.org/gitweb/?p=3Dpeople/pauldu/demu.git

Video for this Design Session:
https://www.youtube.com/watch?v=3DIb0OdpHZ-G0&list=3DPLYyw= 7IQjL-zGcRPN6EjiTuFVGo4A6KCNf&index=3D29
--0000000000004a724505cb5de215-- From xen-devel-bounces@lists.xenproject.org Tue Sep 07 02:42:15 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 02:42:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180322.326914 (Exim 4.92) (envelope-from ) id 1mNR3j-00066x-B6; Tue, 07 Sep 2021 02:42:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180322.326914; Tue, 07 Sep 2021 02:42:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNR3j-00066q-86; Tue, 07 Sep 2021 02:42:03 +0000 Received: by outflank-mailman (input) for mailman id 180322; Tue, 07 Sep 2021 02:42:02 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNR3i-00066k-JU for xen-devel@lists.xen.org; Tue, 07 Sep 2021 02:42:02 +0000 Received: from mail-oi1-x22b.google.com (unknown [2607:f8b0:4864:20::22b]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id bacbc3a1-6530-4402-99d4-5ffb8b8e8b8b; Tue, 07 Sep 2021 02:42:00 +0000 (UTC) Received: by mail-oi1-x22b.google.com with SMTP id q39so10977071oiw.12 for ; Mon, 06 Sep 2021 19:42:00 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bacbc3a1-6530-4402-99d4-5ffb8b8e8b8b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=DW9xyVq0VMsOnG7pEIDynSXF5/evQSkaZLzLtVFxop8=; b=MYeiHb2HeVfr6ZyokGIU//eh9yOTOkLkp/PvkD60nIV4JNNddtRjL9TxKpAjVa5tUS T5G0Nhb33f0j6xoP5yIqx8wgfGn5cFoy8zb0JtJ5qYwG1Yp8ao19CH2/UVoPZjHJtz6k SIrMQuNabuaI65bwrtyLZ9A1yHM2rpCNFA+otPGstCW02Zax1VsJd926iy9WVyd/YPoD BaGAxD9WJJf8m188fypJuYTVeeyFMLC0kO+cg5HKuLyPpojsh/pwMM0FC4XgwZbrmQGQ wASM7bwRFAs0iMBvPiNqa4qJ0uNLtZ9+ASyFijT+t9aYMH76u797wCLvu7jKKFI2U325 1A2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=DW9xyVq0VMsOnG7pEIDynSXF5/evQSkaZLzLtVFxop8=; b=YnMpDEpRf8JFVELI4RFrBeb26f2iAYmmedG9kFLRX8gejD+UuSO4YF1teNJWplJVdt +TQkqztBvxrlvo2zbSad9ni0pzfg5XMNb/cgTBkM03db29s4dgJjCc1ndDlqhpDfa5XY 5V1Bc32oaXZndj+E9ZRnm3CRUByx65EDfTUamHBgDRTieVsqDN44hj1ysh5EokTDBYkX IrxXED9sX0T6/14rX5JeHeGUCAWE+rllCWclnx34x+jB5SNKo6QXwgHZoSVvFZ18UMBP 1dzUyFTfzfKeGn1Gd3TSdfwgaas+l9ifbVUT21emrIXuUYe8GZDrVCAwFYsAM0a6ieDk 5tww== X-Gm-Message-State: AOAM532/6U4cR/V9hqj8wq0QIVaghyfNskzBDdI15XE0pt/A1WOSE/Pq z+hJtsd1dpCHSjxtq+SzO4R5q448dHi7ZEiLAE4= X-Google-Smtp-Source: ABdhPJz5qwyNwRm9AtgL03IQFlT0nPkWIPMKhsYmaWd2teMLjVt7RoQQburO6AFCfN6vWU1lbvUjcSX6Rx6V6uTzTMI= X-Received: by 2002:a54:4197:: with SMTP id 23mr1373584oiy.122.1630982520003; Mon, 06 Sep 2021 19:42:00 -0700 (PDT) MIME-Version: 1.0 References: <87v94ldrqq.fsf@linaro.org> <875yvkh1p1.fsf@linaro.org> <20210903080609.GD47953@laputa> <87czpqq9qu.fsf@linaro.org> <20210906022356.GD40187@laputa> In-Reply-To: <20210906022356.GD40187@laputa> From: Christopher Clark Date: Mon, 6 Sep 2021 19:41:48 -0700 Message-ID: Subject: Re: [Stratos-dev] Enabling hypervisor agnosticism for VirtIO backends To: AKASHI Takahiro Cc: "Alex Benn??e" , Wei Chen , Paul Durrant , Stratos Mailing List , virtio-dev@lists.oasis-open.org, Stefano Stabellini , Jan Kiszka , Arnd Bergmann , Juergen Gross , Julien Grall , Carl van Schaik , Bertrand Marquis , Stefan Hajnoczi , Artem Mygaiev , Xen-devel , Oleksandr Tyshchenko , Oleksandr Tyshchenko , Elena Afanasova , James McKenzie , Andrew Cooper , Rich Persaud , Daniel Smith , Jason Andryuk , eric chanudet , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= Content-Type: multipart/alternative; boundary="000000000000bd5eb305cb5eb55e" --000000000000bd5eb305cb5eb55e Content-Type: text/plain; charset="UTF-8" On Sun, Sep 5, 2021 at 7:24 PM AKASHI Takahiro via Stratos-dev < stratos-dev@op-lists.linaro.org> wrote: > Alex, > > On Fri, Sep 03, 2021 at 10:28:06AM +0100, Alex Benn??e wrote: > > > > AKASHI Takahiro writes: > > > > > Alex, > > > > > > On Wed, Sep 01, 2021 at 01:53:34PM +0100, Alex Benn??e wrote: > > >> > > >> Stefan Hajnoczi writes: > > >> > > >> > [[PGP Signed Part:Undecided]] > > >> > On Wed, Aug 04, 2021 at 12:20:01PM -0700, Stefano Stabellini wrote: > > >> >> > Could we consider the kernel internally converting IOREQ > messages from > > >> >> > the Xen hypervisor to eventfd events? Would this scale with > other kernel > > >> >> > hypercall interfaces? > > >> >> > > > >> >> > So any thoughts on what directions are worth experimenting with? > > >> >> > > >> >> One option we should consider is for each backend to connect to > Xen via > > >> >> the IOREQ interface. We could generalize the IOREQ interface and > make it > > >> >> hypervisor agnostic. The interface is really trivial and easy to > add. > > >> >> The only Xen-specific part is the notification mechanism, which is > an > > >> >> event channel. If we replaced the event channel with something > else the > > >> >> interface would be generic. See: > > >> >> > https://gitlab.com/xen-project/xen/-/blob/staging/xen/include/public/hvm/ioreq.h#L52 > > >> > > > >> > There have been experiments with something kind of similar in KVM > > >> > recently (see struct ioregionfd_cmd): > > >> > > https://lore.kernel.org/kvm/dad3d025bcf15ece11d9df0ff685e8ab0a4f2edd.1613828727.git.eafanasova@gmail.com/ > > >> > > >> Reading the cover letter was very useful in showing how this provides > a > > >> separate channel for signalling IO events to userspace instead of > using > > >> the normal type-2 vmexit type event. I wonder how deeply tied the > > >> userspace facing side of this is to KVM? Could it provide a common FD > > >> type interface to IOREQ? > > > > > > Why do you stick to a "FD" type interface? > > > > I mean most user space interfaces on POSIX start with a file descriptor > > and the usual read/write semantics or a series of ioctls. > > Who do you assume is responsible for implementing this kind of > fd semantics, OSs on BE or hypervisor itself? > > I think such interfaces can only be easily implemented on type-2 > hypervisors. > > # In this sense, I don't think rust-vmm, as it is, cannot be > # a general solution. > > > >> As I understand IOREQ this is currently a direct communication between > > >> userspace and the hypervisor using the existing Xen message bus. My > > > > > > With IOREQ server, IO event occurrences are notified to BE via Xen's > event > > > channel, while the actual contexts of IO events (see struct ioreq in > ioreq.h) > > > are put in a queue on a single shared memory page which is to be > assigned > > > beforehand with xenforeignmemory_map_resource hypervisor call. > > > > If we abstracted the IOREQ via the kernel interface you would probably > > just want to put the ioreq structure on a queue rather than expose the > > shared page to userspace. > > Where is that queue? > > > >> worry would be that by adding knowledge of what the underlying > > >> hypervisor is we'd end up with excess complexity in the kernel. For > one > > >> thing we certainly wouldn't want an API version dependency on the > kernel > > >> to understand which version of the Xen hypervisor it was running on. > > > > > > That's exactly what virtio-proxy in my proposal[1] does; All the > hypervisor- > > > specific details of IO event handlings are contained in virtio-proxy > > > and virtio BE will communicate with virtio-proxy through a virtqueue > > > (yes, virtio-proxy is seen as yet another virtio device on BE) and will > > > get IO event-related *RPC* callbacks, either MMIO read or write, from > > > virtio-proxy. > > > > > > See page 8 (protocol flow) and 10 (interfaces) in [1]. > > > > There are two areas of concern with the proxy approach at the moment. > > The first is how the bootstrap of the virtio-proxy channel happens and > > As I said, from BE point of view, virtio-proxy would be seen > as yet another virtio device by which BE could talk to "virtio > proxy" vm or whatever else. > > This way we guarantee BE's hypervisor-agnosticism instead of having > "common" hypervisor interfaces. That is the base of my idea. > > > the second is how many context switches are involved in a transaction. > > Of course with all things there is a trade off. Things involving the > > very tightest latency would probably opt for a bare metal backend which > > I think would imply hypervisor knowledge in the backend binary. > > In configuration phase of virtio device, the latency won't be a big matter. > In device operations (i.e. read/write to block devices), if we can > resolve 'mmap' issue, as Oleksandr is proposing right now, the only issue > is > how efficiently we can deliver notification to the opposite side. Right? > And this is a very common problem whatever approach we would take. > > Anyhow, if we do care the latency in my approach, most of virtio-proxy- > related code can be re-implemented just as a stub (or shim?) library > since the protocols are defined as RPCs. > In this case, however, we would lose the benefit of providing "single > binary" > BE. > (I know this is is an arguable requirement, though.) > > # Would we better discuss what "hypervisor-agnosticism" means? > > Is there a call that you could recommend that we join to discuss this and the topics of this thread? There is definitely interest in pursuing a new interface for Argo that can be implemented in other hypervisors and enable guest binary portability between them, at least on the same hardware architecture, with VirtIO transport as a primary use case. The notes from the Xen Summit Design Session on VirtIO Cross-Project BoF for Xen and Guest OS, which include context about the several separate approaches to VirtIO on Xen, have now been posted here: https://lists.xenproject.org/archives/html/xen-devel/2021-09/msg00472.html Christopher > -Takahiro Akashi > > > --000000000000bd5eb305cb5eb55e Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Sun, Sep 5, 2021 at 7:24 PM AKASHI= Takahiro via Stratos-dev <stratos-dev@op-lists.linaro.org> wrote:
Alex,

On Fri, Sep 03, 2021 at 10:28:06AM +0100, Alex Benn??e wrote:
>
> AKASHI Takahiro <takahiro.akashi@linaro.org> writes:
>
> > Alex,
> >
> > On Wed, Sep 01, 2021 at 01:53:34PM +0100, Alex Benn??e wrote:
> >>
> >> Stefan Hajnoczi <stefanha@redhat.com> writes:
> >>
> >> > [[PGP Signed Part:Undecided]]
> >> > On Wed, Aug 04, 2021 at 12:20:01PM -0700, Stefano Stabel= lini wrote:
> >> >> > Could we consider the kernel internally convert= ing IOREQ messages from
> >> >> > the Xen hypervisor to eventfd events? Would thi= s scale with other kernel
> >> >> > hypercall interfaces?
> >> >> >
> >> >> > So any thoughts on what directions are worth ex= perimenting with?
> >> >>=C2=A0
> >> >> One option we should consider is for each backend to= connect to Xen via
> >> >> the IOREQ interface. We could generalize the IOREQ i= nterface and make it
> >> >> hypervisor agnostic. The interface is really trivial= and easy to add.
> >> >> The only Xen-specific part is the notification mecha= nism, which is an
> >> >> event channel. If we replaced the event channel with= something else the
> >> >> interface would be generic. See:
> >> >> https://gitlab.com/xen-project/xen/-/blob/staging/xen/include/public= /hvm/ioreq.h#L52
> >> >
> >> > There have been experiments with something kind of simil= ar in KVM
> >> > recently (see struct ioregionfd_cmd):
> >> > https://lore.kernel.org/kvm/dad3d025bcf15ece11d9df0= ff685e8ab0a4f2edd.1613828727.git.eafanasova@gmail.com/
> >>
> >> Reading the cover letter was very useful in showing how this = provides a
> >> separate channel for signalling IO events to userspace instea= d of using
> >> the normal type-2 vmexit type event. I wonder how deeply tied= the
> >> userspace facing side of this is to KVM? Could it provide a c= ommon FD
> >> type interface to IOREQ?
> >
> > Why do you stick to a "FD" type interface?
>
> I mean most user space interfaces on POSIX start with a file descripto= r
> and the usual read/write semantics or a series of ioctls.

Who do you assume is responsible for implementing this kind of
fd semantics, OSs on BE or hypervisor itself?

I think such interfaces can only be easily implemented on type-2 hypervisor= s.

# In this sense, I don't think rust-vmm, as it is, cannot be
# a general solution.

> >> As I understand IOREQ this is currently a direct communicatio= n between
> >> userspace and the hypervisor using the existing Xen message b= us. My
> >
> > With IOREQ server, IO event occurrences are notified to BE via Xe= n's event
> > channel, while the actual contexts of IO events (see struct ioreq= in ioreq.h)
> > are put in a queue on a single shared memory page which is to be = assigned
> > beforehand with xenforeignmemory_map_resource hypervisor call. >
> If we abstracted the IOREQ via the kernel interface you would probably=
> just want to put the ioreq structure on a queue rather than expose the=
> shared page to userspace.

Where is that queue?

> >> worry would be that by adding knowledge of what the underlyin= g
> >> hypervisor is we'd end up with excess complexity in the k= ernel. For one
> >> thing we certainly wouldn't want an API version dependenc= y on the kernel
> >> to understand which version of the Xen hypervisor it was runn= ing on.
> >
> > That's exactly what virtio-proxy in my proposal[1] does; All = the hypervisor-
> > specific details of IO event handlings are contained in virtio-pr= oxy
> > and virtio BE will communicate with virtio-proxy through a virtqu= eue
> > (yes, virtio-proxy is seen as yet another virtio device on BE) an= d will
> > get IO event-related *RPC* callbacks, either MMIO read or write, = from
> > virtio-proxy.
> >
> > See page 8 (protocol flow) and 10 (interfaces) in [1].
>
> There are two areas of concern with the proxy approach at the moment.<= br> > The first is how the bootstrap of the virtio-proxy channel happens and=

As I said, from BE point of view, virtio-proxy would be seen
as yet another virtio device by which BE could talk to "virtio
proxy" vm or whatever else.

This way we guarantee BE's hypervisor-agnosticism instead of having
"common" hypervisor interfaces. That is the base of my idea.

> the second is how many context switches are involved in a transaction.=
> Of course with all things there is a trade off. Things involving the > very tightest latency would probably opt for a bare metal backend whic= h
> I think would imply hypervisor knowledge in the backend binary.

In configuration phase of virtio device, the latency won't be a big mat= ter.
In device operations (i.e. read/write to block devices), if we can
resolve 'mmap' issue, as Oleksandr is proposing right now, the only= issue is
how efficiently we can deliver notification to the opposite side. Right? And this is a very common problem whatever approach we would take.

Anyhow, if we do care the latency in my approach, most of virtio-proxy-
related code can be re-implemented just as a stub (or shim?) library
since the protocols are defined as RPCs.
In this case, however, we would lose the benefit of providing "single = binary"
BE.
(I know this is is an arguable requirement, though.)

# Would we better discuss what "hypervisor-agnosticism" means?
Is there a call that you could recommend that we join= to discuss this and the topics of this thread?
There is definite= ly interest in pursuing a new interface for Argo that can be implemented in= other hypervisors and enable guest binary portability between them, at lea= st on the same hardware architecture, with VirtIO transport as a primary us= e case.

The notes from the Xen Summit Design Sessi= on on VirtIO Cross-Project BoF for Xen and Guest OS, which include context = about the several separate approaches to VirtIO on Xen, have now been poste= d here:

Christopher<= /div>

=C2=A0
-Takahiro Akashi


--000000000000bd5eb305cb5eb55e-- From xen-devel-bounces@lists.xenproject.org Tue Sep 07 03:06:27 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 03:06:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180328.326925 (Exim 4.92) (envelope-from ) id 1mNRRF-0000XF-CW; Tue, 07 Sep 2021 03:06:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180328.326925; Tue, 07 Sep 2021 03:06:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNRRF-0000X8-8X; Tue, 07 Sep 2021 03:06:21 +0000 Received: by outflank-mailman (input) for mailman id 180328; Tue, 07 Sep 2021 03:06:19 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNRRD-0000X2-NO for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 03:06:19 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (unknown [2a01:111:f400:7d00::612]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 8ae9452c-2b70-4c21-970a-d27f2542b225; Tue, 07 Sep 2021 03:06:16 +0000 (UTC) Received: from DB6PR0601CA0021.eurprd06.prod.outlook.com (2603:10a6:4:7b::31) by AM8PR08MB6339.eurprd08.prod.outlook.com (2603:10a6:20b:317::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19; Tue, 7 Sep 2021 03:06:15 +0000 Received: from DB5EUR03FT005.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:7b::4) by DB6PR0601CA0021.outlook.office365.com (2603:10a6:4:7b::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Tue, 7 Sep 2021 03:06:14 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT005.mail.protection.outlook.com (10.152.20.122) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Tue, 7 Sep 2021 03:06:14 +0000 Received: ("Tessian outbound 610b9df843d5:v105"); Tue, 07 Sep 2021 03:06:14 +0000 Received: from fa98366dd5e0.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id B5C8ABBC-0598-449B-9455-F5BE0C669D43.1; Tue, 07 Sep 2021 03:06:08 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id fa98366dd5e0.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 07 Sep 2021 03:06:08 +0000 Received: from VE1PR08MB5215.eurprd08.prod.outlook.com (2603:10a6:803:10a::33) by VI1PR08MB4318.eurprd08.prod.outlook.com (2603:10a6:803:f8::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19; Tue, 7 Sep 2021 03:05:50 +0000 Received: from VE1PR08MB5215.eurprd08.prod.outlook.com ([fe80::adf8:8d6f:2a30:b60c]) by VE1PR08MB5215.eurprd08.prod.outlook.com ([fe80::adf8:8d6f:2a30:b60c%5]) with mapi id 15.20.4478.026; Tue, 7 Sep 2021 03:05:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8ae9452c-2b70-4c21-970a-d27f2542b225 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uRCisFhpggo291C6aobRFvXGwFA/5l47T6YR9tpJq30=; b=X6Jg0Q30d77huaZYeQ1swI0vNboAhgy+8r4dLxWetixqgyUlpH58x+Qfq0hjb+mZmeMxCirE1tmu3c01ZxSKc2cXEywbSFo3rlgMkIBC5hfQuzwxX4Dl0194YXNzRqlRteigj/U0CiC5cMunHLb9HmWqX/H7GIGJOnsfoZrm+ec= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nOqDZk45ztnl5sPmS/exIS4JdOkueecBfm903RmYtWQco20jmhz6LrS7zqMgYLucx4bqa9cllGxH9uBePzwk7JNwGt5veEnPBV3Rbx4zq0JWdWmf3QSS8w68nuACF4yHx+1Rsoa0XYq44EEPdXwP3NP0jTRmC/onE5xn721JuM8MnCHQQW4eBdgQkBHLr8CEhkbpBpW4L2sjjcdFqFzPbmyX0y1Suo0fC9h18lO3bJl0zLEj0B4p9NWUYelmQDv9bF3syfx7oyz8XMl4JWEshNVZARtbsVxWqQJzr+mh0y8URnJVmTCGIenMsd9QQdZytPLbnc5cVKpvmDDz2wpktA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=uRCisFhpggo291C6aobRFvXGwFA/5l47T6YR9tpJq30=; b=jUh+OV2HjmuW8aCK9cDCwGrLCQqZtgf8zda0tA5hAj/rfTqN9YRt0ZghuqxaBa4oqscr6R+YmuQzoGKGQuUQYBAgDYHzjbQiZuiG3LG8mjbdZ4Sex0BNoFilzaOrVkJ/yFfsXl8VGBl7Zv1o8jA3t6SockLmxdolES6/JHqrNxuWDp1XFBRmg10UmszTil5tf/0c4LSRTSN1VT0gOo/F+XVCrdoaznLPc3thipnugI9gTr+/g1RPdtzpGUKmnWhDhmL+FI2x+Uh/Pc7xlLg0buVdH/EDBxAQyjLbfFCzJnqEjjosctXu6utHrqQc6LuUngkRZByAPLGDOxkj77CDYg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uRCisFhpggo291C6aobRFvXGwFA/5l47T6YR9tpJq30=; b=X6Jg0Q30d77huaZYeQ1swI0vNboAhgy+8r4dLxWetixqgyUlpH58x+Qfq0hjb+mZmeMxCirE1tmu3c01ZxSKc2cXEywbSFo3rlgMkIBC5hfQuzwxX4Dl0194YXNzRqlRteigj/U0CiC5cMunHLb9HmWqX/H7GIGJOnsfoZrm+ec= From: Penny Zheng To: Julien Grall , "xen-devel@lists.xenproject.org" , "sstabellini@kernel.org" CC: Bertrand Marquis , Wei Chen , nd Subject: RE: [PATCH v5 1/7] xen/arm: introduce new helper device_tree_get_meminfo Thread-Topic: [PATCH v5 1/7] xen/arm: introduce new helper device_tree_get_meminfo Thread-Index: AQHXmM2TtDweULKD40q5wirMZQfui6uO7RIAgAkLAqA= Date: Tue, 7 Sep 2021 03:05:49 +0000 Message-ID: References: <20210824095045.2281500-1-penny.zheng@arm.com> <20210824095045.2281500-2-penny.zheng@arm.com> <06395a17-24fb-35d5-8332-a6ca42dbc183@xen.org> In-Reply-To: <06395a17-24fb-35d5-8332-a6ca42dbc183@xen.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: ECEF68F408207442B32D4A429459FAB8.0 x-checkrecipientchecked: true Authentication-Results-Original: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com; x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: fa26699c-2db9-4240-c0b4-08d971ac742d x-ms-traffictypediagnostic: VI1PR08MB4318:|AM8PR08MB6339: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:1122;OLM:1122; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: AAKiH1ZB7CgwbFK/f4sAXCyZ70wABNBj+O8nlddF+0ANu6neF0Atpo11hF7TSbjDIj5w9nC7x2ki5mObY9laC0MWYxYPyXo4igogiHk0BPESBTmWObM8IehwGdFbIl7Hbycxpv9gj8Y0TyD1HaWKwkyybPyfqKfOIHzcC9mT3fHTYbnA9vAk3PRMgJQKVmUT9b12KlOEdsDo8qH6O8HKLbeqxSWiOvPibKps81c1sUMop0hqnr7dKAhWRD2YYuB2IT2bEKuPYWcvGDAvx/T53vtkOfTRF6snQrv9zWlDVNNCBqWH614itB7yg1CSNMgaPpqrIfeMof2/q1C6sCdfr/i8CJ91E/rLISUptpUrnml26SV/PuhnE7LCTnLu/E+R7Ztwu5kfpvXGwWxqQo9pw/cwa2i28I4/PtBKHYBqjshL5l1hD0jxLfJfOWXpgq/YFQV+fV/YCqk3r7xyZ2fY4CqNegaUH12jzRk+GXLoG/beQr5sy/Pv+mB3mT1M14MtC1Kxb6QFKQj6Ern2CW4dGEGUaXRieoAgj7Yy6cpeQihqrJrnEt3RB9SIoG4OpaQdQ1p/5g+YyJ0M/Z19sBjQ2AAKw8TmOX5snVUs4/y+CHppgv07L3QmdmhN6FRnwTzYFy0MtmLmy0uuzWjFBrwveO1uYoWiThaeuOIetymtfkomK+Q0WoVsrOccYWzeXXpN6um+2u9m+KT985uSuZF1pw== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR08MB5215.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(8936002)(38070700005)(186003)(64756008)(66556008)(66476007)(71200400001)(7696005)(26005)(38100700002)(5660300002)(52536014)(316002)(508600001)(9686003)(86362001)(83380400001)(8676002)(55016002)(76116006)(53546011)(6506007)(4326008)(66946007)(66446008)(33656002)(122000001)(110136005)(54906003)(2906002);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB4318 Original-Authentication-Results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT005.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 8c28562c-8dd3-4b47-da8e-08d971ac657c X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: nj7zY7ECgQL+EsfUWWc3tgMGn41LW1p7lK2hhv5v6ZEsY11/2mcljdtrOVm1tOJozbXbmRB0iSeI7n/9Qe2JvqHDbk/p/4MEWMPyR4qkbMxmCezJk+7Qva+/57/JWWA0CPhwN0xbgPlHWJEJos+s51+np+7U08DtDO5PMuH2LqVKVed0KwNaJXFrJtOtlX3OX0N7wAjG79/vZQOskOF7O7t7oNv+sVGMu1laji4ynPuZ314pE1B0sEH0OyTUo7hGvlVEdkwOVnuaPBS97IghyTw0NUhbiBhVurKR6RRoh+WC6+DhIqHWNMO8kUEnJVuMVTeNAZLh95tA1EeG/J4rxqc4q8OCjGK3MayBRQNOn75UFcFbbKa2cLw45PxP55TQiV4g8h0eE2RZossW2YeIvoGQknWkecZFls/uvl1z5xsGnC/3+su/12Ogsa5sTTdg3y1LrAD5y++J1wnLr8j50wCPu1JsWfrWHajoSA/LkwktcfqI3Gi35P7mNZNntB/o7mjcvCQyYzNk9QnDNZv3UjPvibMR2/nAuzhQCzuuf/pEwcsKZGKHmuxTzLQ6pg796Wg7EOCdjuRnnJ+RaJEDJTI5jtBhyLVyYxyz6dwKzfI3FGxQJMj7YvTnxXRzjKi7AKhtrtT1XM9KkWK8Clh2LzzaZv7usiQjWZ0ry91A56wKTztK5LDrWpBxrQ2Y5u+uWyOIoNsb+2Anuxaz88mthA== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(39860400002)(376002)(136003)(396003)(346002)(46966006)(36840700001)(70206006)(70586007)(5660300002)(53546011)(54906003)(356005)(86362001)(6506007)(81166007)(82310400003)(110136005)(82740400003)(55016002)(8936002)(316002)(8676002)(33656002)(4326008)(478600001)(47076005)(7696005)(2906002)(9686003)(336012)(83380400001)(52536014)(36860700001)(186003)(26005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2021 03:06:14.7014 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: fa26699c-2db9-4240-c0b4-08d971ac742d X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT005.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB6339 SGkgSnVsaWVuDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogSnVsaWVu IEdyYWxsIDxqdWxpZW5AeGVuLm9yZz4NCj4gU2VudDogV2VkbmVzZGF5LCBTZXB0ZW1iZXIgMSwg MjAyMSA0OjU3IFBNDQo+IFRvOiBQZW5ueSBaaGVuZyA8UGVubnkuWmhlbmdAYXJtLmNvbT47IHhl bi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZzsNCj4gc3N0YWJlbGxpbmlAa2VybmVsLm9yZw0K PiBDYzogQmVydHJhbmQgTWFycXVpcyA8QmVydHJhbmQuTWFycXVpc0Bhcm0uY29tPjsgV2VpIENo ZW4NCj4gPFdlaS5DaGVuQGFybS5jb20+OyBuZCA8bmRAYXJtLmNvbT4NCj4gU3ViamVjdDogUmU6 IFtQQVRDSCB2NSAxLzddIHhlbi9hcm06IGludHJvZHVjZSBuZXcgaGVscGVyDQo+IGRldmljZV90 cmVlX2dldF9tZW1pbmZvDQo+IA0KPiBIaSBQZW5ueSwNCj4gDQo+IE9uIDI0LzA4LzIwMjEgMTA6 NTAsIFBlbm55IFpoZW5nIHdyb3RlOg0KPiA+IEEgZmV3IGZ1bmN0aW9ucyBpdGVyYXRlIG92ZXIg dGhlIGRldmljZSB0cmVlIHByb3BlcnR5IHRvIGdldCBtZW1vcnkNCj4gPiBpbmZvLCBsaWtlICJy ZWciIG9yIHRoZSBsYXRlciAieGVuLHN0YXRpYy1tZW0iLCBzbyB0aGlzIGNvbW1pdCBjcmVhdGVz DQo+ID4gYSBuZXcgaGVscGVyIGRldmljZV90cmVlX2dldF9tZW1pbmZvIHRvIGV4dHJhY3QgdGhl IGNvbW1vbiBjb2Rlcy4NCj4gDQo+IFRoZSBjb21taXQgbWVzc2FnZSBuZWVkcyB0byBiZSB1cGRh dGVkIGFzIHRoZSBwYXRjaCBoYXMgYmVlbiByZXNodWZmbGVkLg0KPiANCg0KWWVzISBJJ2xsIHJl Y29uc3RydWN0Lg0KPiA+IFNpZ25lZC1vZmYtYnk6IFBlbm55IFpoZW5nIDxwZW5ueS56aGVuZ0Bh cm0uY29tPg0KPiA+IC0tLQ0KPiA+ICAgeGVuL2FyY2gvYXJtL2Jvb3RmZHQuYyB8IDY4ICsrKysr KysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0tLQ0KPiA+ICAgMSBmaWxlIGNoYW5n ZWQsIDM5IGluc2VydGlvbnMoKyksIDI5IGRlbGV0aW9ucygtKQ0KPiA+DQo+ID4gZGlmZiAtLWdp dCBhL3hlbi9hcmNoL2FybS9ib290ZmR0LmMgYi94ZW4vYXJjaC9hcm0vYm9vdGZkdC5jIGluZGV4 DQo+ID4gNDc2ZTMyZTBmNS4uOGM4MWJlMzM3OSAxMDA2NDQNCj4gPiAtLS0gYS94ZW4vYXJjaC9h cm0vYm9vdGZkdC5jDQo+ID4gKysrIGIveGVuL2FyY2gvYXJtL2Jvb3RmZHQuYw0KPiA+IEBAIC02 Myw2ICs2Myw0NCBAQCB2b2lkIF9faW5pdCBkZXZpY2VfdHJlZV9nZXRfcmVnKGNvbnN0IF9fYmUz MiAqKmNlbGwsDQo+IHUzMiBhZGRyZXNzX2NlbGxzLA0KPiA+ICAgICAgICpzaXplID0gZHRfbmV4 dF9jZWxsKHNpemVfY2VsbHMsIGNlbGwpOw0KPiA+ICAgfQ0KPiA+DQo+ID4gK3N0YXRpYyBpbnQg X19pbml0IGRldmljZV90cmVlX2dldF9tZW1pbmZvKGNvbnN0IHZvaWQgKmZkdCwgaW50IG5vZGUs DQo+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNvbnN0IGNo YXIgKnByb3BfbmFtZSwNCj4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgdTMyIGFkZHJlc3NfY2VsbHMsIHUzMiBzaXplX2NlbGxzLA0KPiA+ICsgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB2b2lkICpkYXRhKSB7DQo+ID4gKyAgICBj b25zdCBzdHJ1Y3QgZmR0X3Byb3BlcnR5ICpwcm9wOw0KPiA+ICsgICAgdW5zaWduZWQgaW50IGks IGJhbmtzOw0KPiA+ICsgICAgY29uc3QgX19iZTMyICpjZWxsOw0KPiA+ICsgICAgdTMyIHJlZ19j ZWxscyA9IGFkZHJlc3NfY2VsbHMgKyBzaXplX2NlbGxzOw0KPiA+ICsgICAgcGFkZHJfdCBzdGFy dCwgc2l6ZTsNCj4gPiArICAgIHN0cnVjdCBtZW1pbmZvICptZW0gPSBkYXRhOw0KPiA+ICsNCj4g PiArICAgIHByb3AgPSBmZHRfZ2V0X3Byb3BlcnR5KGZkdCwgbm9kZSwgcHJvcF9uYW1lLCBOVUxM KTsNCj4gPiArICAgIGlmICggIXByb3AgKQ0KPiA+ICsgICAgICAgIHJldHVybiAtRU5PRU5UOw0K PiA+ICsNCj4gPiArICAgIGNlbGwgPSAoY29uc3QgX19iZTMyICopcHJvcC0+ZGF0YTsNCj4gPiAr ICAgIGJhbmtzID0gZmR0MzJfdG9fY3B1KHByb3AtPmxlbikgLyAocmVnX2NlbGxzICogc2l6ZW9m ICh1MzIpKTsNCj4gPiArDQo+ID4gKyAgICBmb3IgKCBpID0gMDsgaSA8IGJhbmtzICYmIG1lbS0+ bnJfYmFua3MgPCBOUl9NRU1fQkFOS1M7IGkrKyApDQo+ID4gKyAgICB7DQo+ID4gKyAgICAgICAg ZGV2aWNlX3RyZWVfZ2V0X3JlZygmY2VsbCwgYWRkcmVzc19jZWxscywgc2l6ZV9jZWxscywgJnN0 YXJ0LCAmc2l6ZSk7DQo+ID4gKyAgICAgICAgLyogU29tZSBEVCBtYXkgZGVzY3JpYmUgZW1wdHkg YmFuaywgaWdub3JlIHRoZW0gKi8NCj4gPiArICAgICAgICBpZiAoICFzaXplICkNCj4gPiArICAg ICAgICAgICAgY29udGludWU7DQo+ID4gKyAgICAgICAgbWVtLT5iYW5rW21lbS0+bnJfYmFua3Nd LnN0YXJ0ID0gc3RhcnQ7DQo+ID4gKyAgICAgICAgbWVtLT5iYW5rW21lbS0+bnJfYmFua3NdLnNp emUgPSBzaXplOw0KPiA+ICsgICAgICAgIG1lbS0+bnJfYmFua3MrKzsNCj4gPiArICAgIH0NCj4g PiArDQo+ID4gKyAgICBpZiAoIGkgPCBiYW5rcyApDQo+ID4gKyAgICB7DQo+ID4gKyAgICAgICAg cHJpbnRrKCJXYXJuaW5nOiBNYXggbnVtYmVyIG9mIHN1cHBvcnRlZCBtZW1vcnkgcmVnaW9ucw0K PiByZWFjaGVkLlxuIik7DQo+ID4gKyAgICAgICAgcmV0dXJuIC1FTk9TUEM7DQo+ID4gKyAgICB9 DQo+ID4gKyAgICByZXR1cm4gMDsNCj4gPiArfQ0KPiA+ICsNCj4gPiAgIHUzMiBfX2luaXQgZGV2 aWNlX3RyZWVfZ2V0X3UzMihjb25zdCB2b2lkICpmZHQsIGludCBub2RlLA0KPiA+ICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIGNvbnN0IGNoYXIgKnByb3BfbmFtZSwgdTMyIGRmbHQp DQo+ID4gICB7DQo+ID4gQEAgLTEzOSwxNCArMTc3LDYgQEAgc3RhdGljIGludCBfX2luaXQgcHJv Y2Vzc19tZW1vcnlfbm9kZShjb25zdCB2b2lkDQo+ICpmZHQsIGludCBub2RlLA0KPiA+ICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB1MzIgYWRkcmVzc19jZWxscywgdTMy IHNpemVfY2VsbHMsDQo+ID4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IHZvaWQgKmRhdGEpDQo+ID4gICB7DQo+ID4gLSAgICBjb25zdCBzdHJ1Y3QgZmR0X3Byb3BlcnR5 ICpwcm9wOw0KPiA+IC0gICAgaW50IGk7DQo+ID4gLSAgICBpbnQgYmFua3M7DQo+ID4gLSAgICBj b25zdCBfX2JlMzIgKmNlbGw7DQo+ID4gLSAgICBwYWRkcl90IHN0YXJ0LCBzaXplOw0KPiA+IC0g ICAgdTMyIHJlZ19jZWxscyA9IGFkZHJlc3NfY2VsbHMgKyBzaXplX2NlbGxzOw0KPiA+IC0gICAg c3RydWN0IG1lbWluZm8gKm1lbSA9IGRhdGE7DQo+ID4gLQ0KPiA+ICAgICAgIGlmICggYWRkcmVz c19jZWxscyA8IDEgfHwgc2l6ZV9jZWxscyA8IDEgKQ0KPiANCj4gVGhpcyBjaGVjayB3aWxsIGJl IHRoZSBzYW1lIGZvciAieGVuLHN0YXRpYy1tZW0iLiBTbyBjYW4gaXQgYmUgbW92ZWQgdG8NCj4g ZGV2aWNlX3RyZWVfZ2V0X21lbWluZm8oKT8NCj4gDQoNClN1cmUuIEknbGwgbW92ZSBpdC4NCg0K PiA+ICAgICAgIHsNCj4gPiAgICAgICAgICAgcHJpbnRrKCJmZHQ6IG5vZGUgYCVzJzogaW52YWxp ZCAjYWRkcmVzcy1jZWxscyBvcg0KPiA+ICNzaXplLWNlbGxzIiwgQEAgLTE1NCwyNyArMTg0LDcg QEAgc3RhdGljIGludCBfX2luaXQNCj4gcHJvY2Vzc19tZW1vcnlfbm9kZShjb25zdCB2b2lkICpm ZHQsIGludCBub2RlLA0KPiA+ICAgICAgICAgICByZXR1cm4gLUVJTlZBTDsNCj4gPiAgICAgICB9 DQo+ID4NCj4gPiAtICAgIHByb3AgPSBmZHRfZ2V0X3Byb3BlcnR5KGZkdCwgbm9kZSwgInJlZyIs IE5VTEwpOw0KPiA+IC0gICAgaWYgKCAhcHJvcCApDQo+ID4gLSAgICAgICAgcmV0dXJuIC1FTk9F TlQ7DQo+ID4gLQ0KPiA+IC0gICAgY2VsbCA9IChjb25zdCBfX2JlMzIgKilwcm9wLT5kYXRhOw0K PiA+IC0gICAgYmFua3MgPSBmZHQzMl90b19jcHUocHJvcC0+bGVuKSAvIChyZWdfY2VsbHMgKiBz aXplb2YgKHUzMikpOw0KPiA+IC0NCj4gPiAtICAgIGZvciAoIGkgPSAwOyBpIDwgYmFua3MgJiYg bWVtLT5ucl9iYW5rcyA8IE5SX01FTV9CQU5LUzsgaSsrICkNCj4gPiAtICAgIHsNCj4gPiAtICAg ICAgICBkZXZpY2VfdHJlZV9nZXRfcmVnKCZjZWxsLCBhZGRyZXNzX2NlbGxzLCBzaXplX2NlbGxz LCAmc3RhcnQsICZzaXplKTsNCj4gPiAtICAgICAgICAvKiBTb21lIERUIG1heSBkZXNjcmliZSBl bXB0eSBiYW5rLCBpZ25vcmUgdGhlbSAqLw0KPiA+IC0gICAgICAgIGlmICggIXNpemUgKQ0KPiA+ IC0gICAgICAgICAgICBjb250aW51ZTsNCj4gPiAtICAgICAgICBtZW0tPmJhbmtbbWVtLT5ucl9i YW5rc10uc3RhcnQgPSBzdGFydDsNCj4gPiAtICAgICAgICBtZW0tPmJhbmtbbWVtLT5ucl9iYW5r c10uc2l6ZSA9IHNpemU7DQo+ID4gLSAgICAgICAgbWVtLT5ucl9iYW5rcysrOw0KPiA+IC0gICAg fQ0KPiA+IC0NCj4gPiAtICAgIGlmICggaSA8IGJhbmtzICkNCj4gPiAtICAgICAgICByZXR1cm4g LUVOT1NQQzsNCj4gPiAtICAgIHJldHVybiAwOw0KPiA+ICsgICAgcmV0dXJuIGRldmljZV90cmVl X2dldF9tZW1pbmZvKGZkdCwgbm9kZSwgInJlZyIsIGFkZHJlc3NfY2VsbHMsDQo+ID4gKyBzaXpl X2NlbGxzLCBkYXRhKTsNCj4gPiAgIH0NCj4gPg0KPiA+ICAgc3RhdGljIGludCBfX2luaXQgcHJv Y2Vzc19yZXNlcnZlZF9tZW1vcnlfbm9kZShjb25zdCB2b2lkICpmZHQsIGludA0KPiA+IG5vZGUs DQo+ID4NCj4gDQo+IENoZWVycywNCj4gDQo+IC0tDQo+IEp1bGllbiBHcmFsbA0K From xen-devel-bounces@lists.xenproject.org Tue Sep 07 03:13:40 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 03:13:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180335.326936 (Exim 4.92) (envelope-from ) id 1mNRYH-0002Fp-8H; Tue, 07 Sep 2021 03:13:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180335.326936; Tue, 07 Sep 2021 03:13:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNRYH-0002Fi-5B; Tue, 07 Sep 2021 03:13:37 +0000 Received: by outflank-mailman (input) for mailman id 180335; Tue, 07 Sep 2021 03:13:35 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNRYF-0002Fc-R4 for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 03:13:35 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (unknown [2a01:111:f400:7e1b::631]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 645f2ba7-1609-4ee8-a0f3-771b2d8469d7; Tue, 07 Sep 2021 03:13:33 +0000 (UTC) Received: from DB6PR07CA0172.eurprd07.prod.outlook.com (2603:10a6:6:43::26) by AS8PR08MB7208.eurprd08.prod.outlook.com (2603:10a6:20b:407::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.24; Tue, 7 Sep 2021 03:13:24 +0000 Received: from DB5EUR03FT034.eop-EUR03.prod.protection.outlook.com (2603:10a6:6:43:cafe::f3) by DB6PR07CA0172.outlook.office365.com (2603:10a6:6:43::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.4 via Frontend Transport; Tue, 7 Sep 2021 03:13:24 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT034.mail.protection.outlook.com (10.152.20.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Tue, 7 Sep 2021 03:13:23 +0000 Received: ("Tessian outbound 0ec886cb54dd:v105"); Tue, 07 Sep 2021 03:13:23 +0000 Received: from c3af3d769bd7.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id C3890B58-DDC9-4EF5-BA66-F6A0E8520F84.1; Tue, 07 Sep 2021 03:13:17 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id c3af3d769bd7.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 07 Sep 2021 03:13:17 +0000 Received: from VE1PR08MB5215.eurprd08.prod.outlook.com (2603:10a6:803:10a::33) by VI1PR08MB4173.eurprd08.prod.outlook.com (2603:10a6:803:e8::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19; Tue, 7 Sep 2021 03:13:14 +0000 Received: from VE1PR08MB5215.eurprd08.prod.outlook.com ([fe80::adf8:8d6f:2a30:b60c]) by VE1PR08MB5215.eurprd08.prod.outlook.com ([fe80::adf8:8d6f:2a30:b60c%5]) with mapi id 15.20.4478.026; Tue, 7 Sep 2021 03:13:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 645f2ba7-1609-4ee8-a0f3-771b2d8469d7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GxQnPRoj1/mbk5l4OOqDbjtc4ZfJJmMN5bdSpP8ux2w=; b=mx3dccJz0S3p5NwVMRCoJgfTlYTReqEs2VH3mvim4M52de1ZicpyaH6BwWKpN96xwekh7+LsnLh3ewrXt2HPVfqVlL/sR6RuzkuhIiEZ7V5ylt3gRDwrCqZdNJGFdPYsQ8RHNaVhxcljePXH8OwO0K6I3NTXFENFYt4fumaHlxw= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Qk3BT03R+YajOifu6FCKdkdAwUkp6Ps9ohAHZHW9PWOUmh0arMmP0EI+JMIfBlcIPiNDh9fJqVXrGA0DmG9C5UIi3PJzIeJk61qetZihonRaHOm/ghMwhb4LCMvxLrDMtkrlbrwqmq4PoeFNdniCzxY5KmPmQPcBFZDoIzCe2qHcE8ijDG0EjDqFVTnbiCfrp1Hq5zAOi/gXoX2Gr2vQlPTe6wy53gJOFRx6/DFG39CoQPklp7Bc2T9sGpRj2ZvmtDvCOuBSw41MfNWWtp/mFxqQ8L9UYir2J83EhGZpmuqbbilsyMDsGbTzlROFwpsYCm835jEdAlOoiFPWNB4xqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=GxQnPRoj1/mbk5l4OOqDbjtc4ZfJJmMN5bdSpP8ux2w=; b=DTcW97IKgjYtuOeaojgbAEx+p49de08d/hfSb5rDtu8r/GruDrbPxfFdB1T9E8eM3st3s5ynTDwg3NYSa55lgbNGtFLWki4jzCogMQA9Hs+5ts3/0876Vho66CCHB1D6VwExAW9b9cD6bac4XVwWo2PSsQMrPZF2YJAZyEOs4pQzLeoMfJG5hBcJHLXXfFiWBvUV7O4/W67oIcY8psE3LatYhdszyfqAB64lgm5SFPDP0Kvh8wrD+dlJm//e2zmktdY1dW1hmT1bdJw5wFZxIPww1gActOnXkLNLQdvi2Cs5hVgVpPFeEkolyJPB+0S2ygCIR84Cu5EHg32/BNURjg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GxQnPRoj1/mbk5l4OOqDbjtc4ZfJJmMN5bdSpP8ux2w=; b=mx3dccJz0S3p5NwVMRCoJgfTlYTReqEs2VH3mvim4M52de1ZicpyaH6BwWKpN96xwekh7+LsnLh3ewrXt2HPVfqVlL/sR6RuzkuhIiEZ7V5ylt3gRDwrCqZdNJGFdPYsQ8RHNaVhxcljePXH8OwO0K6I3NTXFENFYt4fumaHlxw= From: Penny Zheng To: Julien Grall , Stefano Stabellini CC: "xen-devel@lists.xenproject.org" , Bertrand Marquis , Wei Chen , nd Subject: RE: [PATCH v5 7/7] xen/arm: introduce allocate_static_memory Thread-Topic: [PATCH v5 7/7] xen/arm: introduce allocate_static_memory Thread-Index: AQHXmM2d1FH9kUvkk0y8p4F7V64vPKuRUpWAgAAJw4CAACpGgIAAdgUAgAX8taA= Date: Tue, 7 Sep 2021 03:13:13 +0000 Message-ID: References: <20210824095045.2281500-1-penny.zheng@arm.com> <20210824095045.2281500-8-penny.zheng@arm.com> <034628a6-5461-f4a9-3339-a0d6f3d68f80@xen.org> In-Reply-To: <034628a6-5461-f4a9-3339-a0d6f3d68f80@xen.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 3844190897E13D46905699D8AF8D48F0.0 x-checkrecipientchecked: true Authentication-Results-Original: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com; x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: a7ca33b8-1ad3-4261-9ca9-08d971ad73ce x-ms-traffictypediagnostic: VI1PR08MB4173:|AS8PR08MB7208: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:10000;OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: GGYtz82v59GjVWRW1s3hlQz39B/+tL559MfJVajg2c61fNqmcMFZ+h7VHxkFb+YS6lkx8NuSiDL4a7QcHDI24nEEHt3Dou0pbnnzJVqlseByrTHf4PQqSHqI8wJ0XXSgNyGhilNikSHbs8hhOmJCFQzFUpEjfz88jfAMgvmKeGqBcmQq0s/qpoc/JFNepfzkw9xSawfPPwT3QrKhVujfEMIkCzpTZkC8ct1YVVz+tv1yB76qg7rEDNAgwrVkeZWgPVCPLKxU4+cpR3wQIOgrmQei8WG/ErDfi+PCAgQBrlR5NOVk2i/67L0tUYWswnI7CXbjLgmiMddqKhEdUNNDb2paxKgoVJEsgrwuExba0PFbo78nggPBfhLxGAdlg6Ouq0rydF+U4LM666JUHd80kY8x0tRnNuSdbyEVeT+dM7dIqPjmLNvtt4936rDVIF4Y3WisFvWrfHdnxgTETUC3zhjXia6uZt1Ct37va5rWOGjjBydZIuxjFsuCk78XviGrui0LRmQheUgWr92P4ZyR/eApz98HYi/hOC7vHH5Km+JlrEzrqRlL3AApUHVKA6Exlu/ySgbkil1xtcZeLnTDal0P2gtoPxOlnV+GBTycsOUp64a4KMhJGoShjrPm/H3hc74799PyM0WCqJh/pLAocr+FiUpK3udt7oL27vsHS/FkOeOJA9gxI0LBkfxuUUoiHG1VbBVHRTHAr0J4PHBgSg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR08MB5215.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(39860400002)(136003)(396003)(366004)(346002)(376002)(110136005)(83380400001)(38070700005)(8936002)(9686003)(52536014)(66476007)(76116006)(4326008)(66946007)(478600001)(5660300002)(38100700002)(71200400001)(33656002)(316002)(8676002)(66446008)(66556008)(64756008)(122000001)(26005)(6506007)(54906003)(2906002)(53546011)(186003)(55016002)(7696005)(86362001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB4173 Original-Authentication-Results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT034.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 7e4c8623-abfa-4512-b479-08d971ad6e47 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CgfayPYRC7LdigTivWMEPAEHbQimkfuCOY4UEQcMqL5tkZlvghb6l+lG/iZMGFfkl0L5kTlVVN2pNIeRP8d+fjfSrZtrZlOWfYoWXoUTJQgyZHMbnFKv0BIHAPyaLoNHVXtL7KqumLsYqC6LrYp1ZUhOgttniZBqykYoJ0jiJcrSaKT7YTMEHjDkXkfVxrthYT0gGvO7W3UkytjrbOPGW7H/TVoGadEFQ8kTw6GqOaeQq0cgFqBsYy0IO6f7BQWsboFwTmVnHPWZ3qJeFI44DxoSuKse14P7QGPwRpRv8cOQF3QN1mvW/p44wBAWNJ4rit+QQGwriUgm9Y6+L1Ni6FNmMxxdozI9Zj10WaK712gBAb1TKNsD9iPvfLX271QeMpBYjLQNN+NKwhJ4BmyHJDR2Pa910pYj2s4khE2rqDOauD+UfPReVhvIyWa0RRmyT3iFL9D/a5V4FB2A+3s5wRRCWgM+TqgUPgZoD1L+aaoy/b5lLQfOIgQC5nrSnnTYx7uJiSaDSuyLhU4V0hB+8sBX9hSGlQiBVXor3yw+4qw1OiDmIpGDxosy75ru5qQTQhKYZj4Xng5bzNxGKGdE7Ybl4UzR73pVLk5E/otTZ9OdOFIu/QeM0X41t5ysUlDs5G3T+3SMRR5Ri6AqJKIvjSc8JjiSPRB1q/pZFohT43fl4uz8nY5ggYOkvZ7t41PcGSSR7E6iuXZqotC5RS8JkQ== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(136003)(346002)(376002)(396003)(39860400002)(36840700001)(46966006)(356005)(33656002)(110136005)(55016002)(6506007)(70206006)(336012)(86362001)(8676002)(9686003)(26005)(70586007)(54906003)(5660300002)(186003)(8936002)(82740400003)(81166007)(53546011)(83380400001)(4326008)(478600001)(2906002)(82310400003)(52536014)(316002)(36860700001)(47076005)(7696005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2021 03:13:23.5757 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a7ca33b8-1ad3-4261-9ca9-08d971ad73ce X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT034.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB7208 SGkgSnVsaWVuIGFuZCBTdGVmYW5vDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4g RnJvbTogSnVsaWVuIEdyYWxsIDxqdWxpZW5AeGVuLm9yZz4NCj4gU2VudDogRnJpZGF5LCBTZXB0 ZW1iZXIgMywgMjAyMSAzOjQyIFBNDQo+IFRvOiBTdGVmYW5vIFN0YWJlbGxpbmkgPHNzdGFiZWxs aW5pQGtlcm5lbC5vcmc+DQo+IENjOiBQZW5ueSBaaGVuZyA8UGVubnkuWmhlbmdAYXJtLmNvbT47 IHhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZzsNCj4gQmVydHJhbmQgTWFycXVpcyA8QmVy dHJhbmQuTWFycXVpc0Bhcm0uY29tPjsgV2VpIENoZW4NCj4gPFdlaS5DaGVuQGFybS5jb20+OyBu ZCA8bmRAYXJtLmNvbT4NCj4gU3ViamVjdDogUmU6IFtQQVRDSCB2NSA3LzddIHhlbi9hcm06IGlu dHJvZHVjZSBhbGxvY2F0ZV9zdGF0aWNfbWVtb3J5DQo+IA0KPiANCj4gDQo+IE9uIDAzLzA5LzIw MjEgMDE6MzksIFN0ZWZhbm8gU3RhYmVsbGluaSB3cm90ZToNCj4gPiBPbiBUaHUsIDIgU2VwIDIw MjEsIEp1bGllbiBHcmFsbCB3cm90ZToNCj4gPj4+PiArICAgIGtpbmZvLT5tZW0ubnJfYmFua3Mg PSArK2diYW5rOw0KPiA+Pj4+ICsgICAga2luZm8tPnVuYXNzaWduZWRfbWVtIC09IHRvdF9zaXpl Ow0KPiA+Pj4+ICsgICAgaWYgKCBraW5mby0+dW5hc3NpZ25lZF9tZW0gKQ0KPiA+Pj4+ICsgICAg ew0KPiA+Pj4+ICsgICAgICAgIHByaW50ayhYRU5MT0dfRVJSDQo+ID4+Pj4gKyAgICAgICAgICAg ICAgICJTaXplIG9mIFwibWVtb3J5XCIgcHJvcGVydHkgZG9lc24ndCBtYXRjaCB1cCB3aXRoDQo+ ID4+Pj4gKyB0aGUNCj4gPj4+PiBzdW0tdXAgb2YgXCJ4ZW4sc3RhdGljLW1lbVwiLlxuIik7DQo+ ID4+Pj4gKyAgICAgICAgZ290byBmYWlsOw0KPiA+Pj4NCj4gPj4+IERvIHdlIG5lZWQgdG8gbWFr ZSB0aGlzIGEgZmF0YWwgZmFpbHVyZT8NCj4gPj4+DQo+ID4+PiBJIGFtIGFza2luZyBiZWNhdXNl IHVuYXNzaWduZWRfbWVtIGNvbWVzIGZyb20gdGhlICJtZW1vcnkiIHByb3BlcnR5DQo+ID4+PiBv ZiB0aGUgZG9tYWluIGluIGRldmljZSB0cmVlIHdoaWNoIGlzIGtpbmQgb2YgcmVkdW5kYW50IHdp dGggdGhlDQo+ID4+PiBpbnRyb2R1Y3Rpb24gb2YgeGVuLHN0YXRpYy1tZW0uIEluIGZhY3QsIEkg dGhpbmsgaXQgd291bGQgYmUgYmV0dGVyDQo+ID4+PiB0byBjbGFyaWZ5IHRoZSByb2xlIG9mICJt ZW1vcnkiIHdoZW4gInhlbixzdGF0aWMtbWVtIiBpcyBhbHNvIHByZXNlbnQuDQo+ID4+PiBJbiB0 aGF0IGNhc2UsIHdlIGNvdWxkIGV2ZW4gbWFrZSAibWVtb3J5IiBvcHRpb25hbC4NCj4gPj4NCj4g Pj4gSSByZXF1ZXN0ZWQgdG8gbWFrZSBpdCBtYW5kYXRvcnkuIEltYWdpbmUgeW91IGhhdmUgYSBk b21VIHRoYXQgaGFzDQo+ID4+IDFHQiBhbmQgbm93IHlvdSB3YW50IHRvIHN3aXRjaCB0byBzdGF0 aWMgbWVtb3J5LiBJZiB3ZSBtYWtlIHRoZQ0KPiA+PiBwcm9wZXJ0eSBvcHRpb25hbCwgdGhlbiB0 aGVyZSBpcyBhIHJpc2sgZm9yIHRoZSBhZG1pbiB0byBub3QNCj4gPj4gY29ycmVjdGx5IHBhc3Mg dGhlIGFtb3VudCBvZiBtZW1vcnkuIFRoaXMgbWF5IGJlY29tZSB1bm5vdGljZWQgdW50aWwNCj4g bGF0ZS4NCj4gPj4NCj4gPj4gU28gSSB0aGluayBtYWtpbmcgaXQgbWFuZGF0b3J5IGlzIGNoZWFw IGZvciB1cyBhbmQgYW4gZWFzeSB3YXkgdG8NCj4gPj4gY29uZmlybSB5b3UgcHJvcGVybHkgc2l6 ZWQgdGhlIHJlZ2lvbi4gSXQgYWxzbyBoYXMgdGhlIGJlbmVmaXRzIHRvDQo+ID4+IGVhc2lseSBm aW5kIG91dCBob3cgbXVjaCBtZW1vcnkgeW91IGdhdmUgdG8gdGhlIGd1ZXN0IChidXQgdGhhdCdz IGp1c3QNCj4gYmVjYXVzZSBJIGFtIGxhenkgOikpLg0KPiA+Pg0KPiA+Pj4gSW4gYW55IGNhc2Us IGV2ZW4gaWYgd2UgZG9uJ3QgbWFrZSAibWVtb3J5IiBvcHRpb25hbCwgaXQgbWlnaHQgc3RpbGwN Cj4gPj4+IGJlIGdvb2QgdG8gdHVybiB0aGlzIGVycm9yIGludG8gYSB3YXJuaW5nIGFuZCBpZ25v cmUgdGhlIHJlbWFpbmluZw0KPiA+Pj4ga2luZm8tPnVuYXNzaWduZWRfbWVtLg0KPiA+Pg0KPiA+ PiBUaGUgYmVoYXZpb3IgaXMgbWF0Y2hpbmcgdGhlIGV4aXN0aW5nIGZ1bmN0aW9uIGFuZCBJIHRo aW5rIHRoaXMgaXMgYQ0KPiA+PiBnb29kIGlkZWEuIElmIHlvdSBhc2sgMTBNQiBvZiBtZW1vcnkg YW5kIHdlIG9ubHkgZ2l2ZSB5b3UgOU1CLCB0aGVuDQo+ID4+IGF0IHNvbWUgcG9pbnQgeW91ciBn dWVzdCBpcyBub3QgZ29pbmcgdG8gYmUgaGFwcHkuDQo+ID4+DQo+ID4+IEl0IGlzIG11Y2ggYmV0 dGVyIHRvIGtub3cgaXQgaW4gYWR2YW5jZSB3aXRoIGEgZmFpbHVyZSBvdmVyDQo+ID4+IGRpc2Nv dmVyaW5nIGhvdXJzIGxhdGVyIHdoZW4geW91IHNlZSBhbiBPT00gZnJvbSB5b3VyIGRvbWFpbi4N Cj4gPg0KPiA+IE9LLCBJIGRpZG4ndCByZWFsaXplIHRoaXMgd2FzIGRpc2N1c3NlZCBhbHJlYWR5 LiBMZXQncyBub3QgcmV2aXNpdA0KPiA+IHRoaXMgdGhlbi4NCj4gPg0KPiA+IE15IHByZWZlcmVu Y2UgaXMgcHJpbWFyaWx5IHRvIG1ha2UgdGhlIGRldmljZSB0cmVlIGVhc2llciB0byB3cml0ZSwN Cj4gPiBidXQgbm93YWRheXMgbm9ib2R5IEkga25vdyBpcyB3cml0aW5nIHRoZSBkZXZpY2UgdHJl ZSBieSBoYW5kIGFueW1vcmUNCj4gPiAodGhleSBhbGwgdXNlIEltYWdlQnVpbGRlcikuU28gaWYg dGhlIGRldmljZSB0cmVlIGlzIGdlbmVyYXRlZCB0aGVuIHdlDQo+ID4gYXJlIGZpbmUgZWl0aGVy IHdheSBhcyBsb25nIGFzIHRoZSBiaW5kaW5nIGlzIGNsZWFyLiBTbyBJIGFtIE9LIHRvDQo+ID4g ZHJvcCBteSBzdWdnZXN0aW9uIG9mIG1ha2luZyAibWVtb3J5IiBvcHRpb25hbC4gTGV0J3MgdGhp bmsgb2YgYSB3YXkNCj4gPiB0byBtYWtlICJtZW1vcnkiIGFuZCAieGVuLHN0YXRpYy1tZW0iIGNv ZXhpc3QgaW5zdGVhZC4NCj4gPg0KPiA+DQo+ID4gVGhlcmUgYXJlIHR3byBzaWRlcyBvZiB0aGUg aXNzdWU6DQo+ID4gLSB0aGUgWGVuIGltcGxlbWVudGF0aW9uDQo+ID4gLSB0aGUgYmluZGluZw0K PiA+DQo+ID4NCj4gPiBUaGUgWGVuIGltcGxlbWVudGF0aW9uIGlzIGZpbmUgdG8gcGFuaWMgaWYg bWVtb3J5ICE9IHhlbixzdGF0aWMtbWVtLg0KPiA+IEluIHRoYXQgcmVnYXJkLCB0aGUgY3VycmVu dCBwYXRjaCBpcyBPSy4NCj4gPg0KPiA+DQo+ID4gIEZyb20gdGhlIGJpbmRpbmcgcGVyc3BlY3Rp dmUsIEkgdGhpbmsgaXQgd291bGQgYmUgZ29vZCB0byBhZGQgYQ0KPiA+IHN0YXRlbWVudCB0byBj bGFyaWZ5LiBUaGUgYmluZGluZyBkb2Vzbid0IG5lY2Vzc2FyaWx5IG5lZWQgdG8gbWF0Y2gNCj4g PiBleGFjdGx5IHRoZSBpbXBsZW1lbnRhdGlvbiBhcyB0aGUgYmluZGluZyBzaG91bGQgYmUgYXMg ZnV0dXJlIHByb29mDQo+ID4gYW5kIGFzIGZsZXhpYmxlIGFzIHBvc3NpYmxlLg0KPiANCj4gU28g SSBhZ3JlZSB0aGF0IHRoZSBiaW5kaW5nIGRvZXNuJ3QgaGF2ZSB0byBtYXRjaCB0aGUgaW1wbGVt ZW50YXRpb24uDQo+IEJ1dC4uLiB0aGUgYmluZGluZyBhbHdheXMgaGF2ZSBiZSBtb3JlIHJlc3Ry aWN0aXZlIHRoYW4gdGhlIGltcGxlbWVudGF0aW9uLg0KPiBPdGhlcndpc2UsIHNvbWVvbmUgZm9s bG93aW5nIHRoZSBiaW5kaW5nIG1heSBiZSBub3QgYWJsZSB0byB1c2UgaXQgd2l0aCBYZW4uDQo+ IA0KPiA+DQo+ID4gIEZyb20gdGhlIGJpbmRpbmcgcGVyc3BlY3RpdmUgdHdvIHByb3BlcnRpZXMg c2hvdWxkIG1lYW4gZGlmZmVyZW50DQo+ID4gdGhpbmdzOiBtZW1vcnkgdGhlIHRvdGFsIG1lbW9y eSBhbW91bnQgYW5kIHhlbixzdGF0aWMtbWVtIHRoZSBzdGF0aWMNCj4gPiBtZW1vcnkuIElmIG9u ZSBkYXkgd2UnbGwgaGF2ZSBtb3JlIHR5cGVzIG9mIG1lbW9yeSwgbWVtb3J5IHdpbGwgY292ZXIN Cj4gPiB0aGUgdG90YWwgYW1vdW50IHdoaWxlIHhlbixzdGF0aWMtbWVtIHdpbGwgY292ZXIgYSBz dWJzZXQuIFNvIG1lbW9yeQ0KPiA+IG11c3QgYmUgZ3JlYXRlciBvciBlcXVhbCB0byB4ZW4sc3Rh dGljLW1lbSAoZXZlbiBpZiB0b2RheSBYZW4gb25seQ0KPiA+IHN1cHBvcnRzIG1lbW9yeSA9PSB4 ZW4sc3RhdGljLW1lbSkuDQo+ID4NCj4gPiBTbyBJIHdvdWxkIGFkZDoNCj4gPg0KPiA+ICIiIg0K PiA+IEFzIHRoZSBtZW1vcnkgcHJvcGVydHkgcmVwcmVzZW50cyB0aGUgdG90YWwgbWVtb3J5IG9m IHRoZSBkb21haW4sDQo+ID4gaGVuY2UgdGhlIGFtb3VudCBvZiBtZW1vcnkgc2VsZWN0ZWQgYnkg dGhlIG1lbW9yeSBwcm9wZXJ0eSBtdXN0IGJlDQo+ID4gZ3JlYXRlciBvciBlcXVhbCB0byB0aGUg dG90YWwgYW1vdW50IHNwZWNpZmllZCBieSB4ZW4sc3RhdGljLW1lbS4NCj4gPiBPdGhlciBjb25m aWd1cmF0aW9ucyAobWVtb3J5IGFtb3VudCBsZXNzIHRoYW4geGVuLHN0YXRpYy1tZW0gYW1vdW50 KQ0KPiA+IGFyZSBpbnZhbGlkLg0KPiA+ICIiIg0KPiA+DQo+ID4gVGhpcyBzZW50ZW5jZSBoYXMg dGhlIHB1cnBvc2Ugb2YgY2xhcmlmeWluZyB0aGF0ICJtZW1vcnkiIHN0aWxsIG5lZWQNCj4gPiB0 byBiZSBwb3B1bGF0ZWQgYW5kIGhhdmUgYSB2YWxpZCB2YWx1ZS4gVGhlbiwgaXQgaXMgT0sgZm9y IFhlbiB0bw0KPiA+IGVycm9yIG91dCBpZiBtZW1vcnkgZG9lc24ndCBtYXRjaCB4ZW4sc3RhdGlj LW1lbSBiZWNhdXNlIHRoYXQncyB0aGUNCj4gPiBvbmx5IGNvbmZpZ3VyYXRpb24gc3VwcG9ydGVk Lg0KPiBIb3cgYWJvdXQgd3JpdGluZyBzb21ldGhpbmcgbGlrZSAiVGhlIHByb3BlcnR5ICdtZW1v cnknIHNob3VsZCBtYXRjaCB0aGUNCj4gYW1vdW50IG9mIG1lbW9yeSBnaXZlbiB0byB0aGUgZ3Vl c3QuIEN1cnJlbnRseSwgaXQgaXMgb25seSBwb3NzaWJsZSB0byBlaXRoZXINCj4gYWxsb2NhdGUg c3RhdGljIG1lbW9yeSBvciBsZXQgWGVuIGNob3NlLiAqTWl4aW5nKiBpcyBub3Qgc3VwcG9ydGVk Jy4NCj4gDQo+IFRoZW4gaWYgd2UgYWRkIHRoZSBtaXhpbmcsIHdlIGNvdWxkIHNheSAnRnJvbSBY ZW4gWFguWVksIG1peGluZyB3aWxsIGJlDQo+IGFsbG93ZWQnLg0KPiANCg0KT2suIEknbGwgYWRk IHRoZSBzdGF0ZW1lbnQgdG8gY2xhcmlmeSB0aGUgYmluZGluZy4gDQoNCj4gQ2hlZXJzLA0KPiAN Cj4gLS0NCj4gSnVsaWVuIEdyYWxsDQo= From xen-devel-bounces@lists.xenproject.org Tue Sep 07 03:19:06 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 03:19:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180341.326947 (Exim 4.92) (envelope-from ) id 1mNRdU-0002us-UP; Tue, 07 Sep 2021 03:19:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180341.326947; Tue, 07 Sep 2021 03:19:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNRdU-0002ul-Q6; Tue, 07 Sep 2021 03:19:00 +0000 Received: by outflank-mailman (input) for mailman id 180341; Tue, 07 Sep 2021 03:18:59 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNRdT-0002uf-1v for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 03:18:59 +0000 Received: from EUR02-HE1-obe.outbound.protection.outlook.com (unknown [40.107.1.52]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 0fd35b04-a34b-4e54-a5a4-7a4df8557624; Tue, 07 Sep 2021 03:18:56 +0000 (UTC) Received: from AM6P192CA0105.EURP192.PROD.OUTLOOK.COM (2603:10a6:209:8d::46) by VI1PR0802MB2445.eurprd08.prod.outlook.com (2603:10a6:800:bb::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.21; Tue, 7 Sep 2021 03:18:49 +0000 Received: from AM5EUR03FT047.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:8d:cafe::bf) by AM6P192CA0105.outlook.office365.com (2603:10a6:209:8d::46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Tue, 7 Sep 2021 03:18:49 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT047.mail.protection.outlook.com (10.152.16.197) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Tue, 7 Sep 2021 03:18:49 +0000 Received: ("Tessian outbound cc1d52552731:v105"); Tue, 07 Sep 2021 03:18:48 +0000 Received: from 3016fb1a370b.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id AEB6A185-06C1-4A94-A51E-75245AE3AD0B.1; Tue, 07 Sep 2021 03:18:38 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 3016fb1a370b.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 07 Sep 2021 03:18:38 +0000 Received: from VE1PR08MB5215.eurprd08.prod.outlook.com (2603:10a6:803:10a::33) by VI1PR08MB4173.eurprd08.prod.outlook.com (2603:10a6:803:e8::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19; Tue, 7 Sep 2021 03:18:29 +0000 Received: from VE1PR08MB5215.eurprd08.prod.outlook.com ([fe80::adf8:8d6f:2a30:b60c]) by VE1PR08MB5215.eurprd08.prod.outlook.com ([fe80::adf8:8d6f:2a30:b60c%5]) with mapi id 15.20.4478.026; Tue, 7 Sep 2021 03:18:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0fd35b04-a34b-4e54-a5a4-7a4df8557624 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eAutKulNSqbSaQcjB/rY66Exbgv3sh5ur6/FakAOZtA=; b=b7wZ/vhM196EVRBtO4mY2nJLhxrmiYdDZalLfeItQXXrd/ZQVnCd18Iyz3BhkU+FwG5VRHtF7t5i3u8E1RrajnxoR/0QmnnT8JWk0vlyf2VfxCFL/eFkhWDl/FnpsUsvECT0OijLAorXfvhdSm7WTUIHvuPt/diptz4WrMnEMQk= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=flJU45vtVZWsrH3V/GSEaDRg8d2nZ8E0Fz4+b45WeddQQccdg7RBGaD3v0JLizRhN4d7E8TeHqFoehEdZ2vaySpqNX8WX6kyFsR4hW7k9i1IZPy3gbdByeD7BSuHpkG+oq3Cr3YKeN51S5mM6b8kas8rmFq+kauESOHH87kHCV07VqRqiGCKIYQo5TFHmzuWW7DryQEc0x1a+TnR3/SgU5JHefiCyQ3uDTdgtcgD/+VCt/oVcCkyVYkZdX2KksPYR5yvezxitJWI8skh9mwhoTvFSvM2qSKtH58SAiXam9Ip0lclqKiLx83m0p8SBBEB/bIp91yaxXlA99YCVCDEtw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=eAutKulNSqbSaQcjB/rY66Exbgv3sh5ur6/FakAOZtA=; b=C4YRXHg8qCsbFdjkyOmaU7IcLDX7lEeAV7zgYEooU7xnpRhbOqnNNqWQb2FquARAHBzyjt5/5otDjOCFBl2wufEiT86K4pOGp3sCT6QupPFMiGGFuMlzckxIAwLIDo5YbUiyx8tsXRnwqzOKIvEQJ2KhVxo01eWMtgRjhatgvx74NWDYR3ZMzGbqxkAU4iYtUebvtBujcp3XyBz6GOUFavbRimHNoBO2N6WXMZiLrssqC+koqN6+xMOD0d6A8FwzhuzNh0FzZLjHp+cjeMo0Iv/3tOAlQE44QDw1eQC139+uCsrHc5qBquskqiIEM7hOgDyxVxwaK5OWUcMhZFqadw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eAutKulNSqbSaQcjB/rY66Exbgv3sh5ur6/FakAOZtA=; b=b7wZ/vhM196EVRBtO4mY2nJLhxrmiYdDZalLfeItQXXrd/ZQVnCd18Iyz3BhkU+FwG5VRHtF7t5i3u8E1RrajnxoR/0QmnnT8JWk0vlyf2VfxCFL/eFkhWDl/FnpsUsvECT0OijLAorXfvhdSm7WTUIHvuPt/diptz4WrMnEMQk= From: Penny Zheng To: Stefano Stabellini CC: "xen-devel@lists.xenproject.org" , "julien@xen.org" , Bertrand Marquis , Wei Chen , nd Subject: RE: [PATCH v5 2/7] xen/arm: introduce domain on Static Allocation Thread-Topic: [PATCH v5 2/7] xen/arm: introduce domain on Static Allocation Thread-Index: AQHXmM2YqjVc2LVowEyczFIN0YMASquRUfwAgAapJVA= Date: Tue, 7 Sep 2021 03:18:29 +0000 Message-ID: References: <20210824095045.2281500-1-penny.zheng@arm.com> <20210824095045.2281500-3-penny.zheng@arm.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: EEA958F302EBDA4CB8D1B1C352665A34.0 x-checkrecipientchecked: true Authentication-Results-Original: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=arm.com; x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: 3798125a-0c09-4557-c977-08d971ae360e x-ms-traffictypediagnostic: VI1PR08MB4173:|VI1PR0802MB2445: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:1148;OLM:1148; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: joSyrx2GucuBrj2gtO+eOEiQMgSlcJ9mBxLGV3ZsYNNlDPBvz8AG1CNKBxvPfBR/7QJyJaAPdqJvwR/gsVnfYLqTiC0ZgZV3Bx6ibABQQQFFhLndgWXEBFBRzXepUGbsxOn8i8fGZF0tS+wORcgc17fun6CirM0+7dcGJhYOVgoHkhsGRfMM69fYZvJfTl+tq0cCSWlDaL3YCM79wXPAaqqkVOkYry00oUH/yjUXN7e7LdT0FpocHWkdq5ZuOQmSutiZs97NGK1SdTqkkHnUhAqCTyi4JzFdX0tZMAaUyWeNGbGuC7mVzRWk0bic73oCY57CbxA9OaHyzIIsS3eRw2zI+2zHiTL7D11AA9b2/i1WFlPnEM6I1/ih04Zbv3fOoGMOwo9w3K5YhHCqjY2sjO87rPAKG6jHWvLMnf1DNwSPWB8uL6kP0EKPytoBTILieT0duntDsKIYtClrdw0a+o5R+rRwBHAODNYWJ+xww//1uVR8LUrTMkZu6YADFTZxLIOW3f4kXdnJbFfe2O9HXF0hQedzjmFljdkxSKMXon0buJVoHNnMy8nkg6RrX1opJhWDEyFIEZwydTRsEyKQxButbMvrRBcnyisyJQjh1QlwpElT3Fs/RfLZfokUlxG555Pz64hxdosdyGB+74gFSJOQ1WU/5/7vl1uF1gtIZ/y5SOB3KRxfGhrEPYOaowf+ApeDsq3NW4fqgcy6lruedw== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR08MB5215.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(346002)(366004)(396003)(136003)(39860400002)(186003)(54906003)(2906002)(53546011)(55016002)(26005)(6506007)(7696005)(86362001)(38070700005)(52536014)(6916009)(8936002)(9686003)(83380400001)(8676002)(33656002)(316002)(64756008)(66476007)(122000001)(66446008)(66556008)(71200400001)(66946007)(76116006)(4326008)(5660300002)(38100700002)(478600001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB4173 Original-Authentication-Results: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT047.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 4ce8522d-29ea-41e6-9b9a-08d971ae2a3b X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Vzfy021VVqWWyaWOHxJV67yFO3GIUiLdTICAqZYoy8KaMjFkdlPm+xk18vuilTpOXwNR3F2Lmgc2vZS0rOvXskxYF+lNgNtDokJNBg+VJUAFryBejTtfOX0KQ7tRtnyCsZhWk7zxj9XdwI6MIgNDpZvaPkHV7/uYjfowiy4v081dpTDT1B5Nep/6Nh3PqvYrKgnBXQvdoMNjRTsA7zwd4Xu/rAJlhhvbX7LBbYX48Gn0cwZMFc+uD8r9UujJVuaSfhrxPviWNNN76qjot1Movk7zz8KxmPECpCmiyIWb5Az+VSE9xP92BhcNXHjbzogFpPrkuWLzBe5NsWkI3WmGUBfw/XlYNf1hGXVMu/KOn7T+4fXD2RFAU0ME+q3K0xYxe2klZ+6zonTclxs6zyjvtZWBYrm9tksP1l+JjlQdV2HOwOz13bJUkSsYPyjVKjhstXi1/KEQiEmL+ozGz/hnWPScggJofW5Fl7XuBvipjP7mUo28xKJDLQlTujAQubP6n94670dfyJ3IlgRslzYbF8e02Y4INiCHrdQ9F5EzHKHT6HdORDiDrUYcRrfy87xazw+i0shnx8zWtqmbgsqDbqefiVDxxt4iolpJ7uGVNHOsNibC8i2NwdUNu4wldQ2bLBFvrp8adqccMnRq4P0iqRoBUNqJsq738BsFR2/vtoas0RoIG5TONGl5DO3L4Nv54+BlgHC8awyvxqH1C9Z1GA== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(346002)(376002)(39860400002)(396003)(136003)(46966006)(36840700001)(316002)(26005)(36860700001)(8676002)(5660300002)(6862004)(8936002)(186003)(86362001)(4326008)(83380400001)(55016002)(54906003)(52536014)(70206006)(33656002)(9686003)(47076005)(7696005)(70586007)(478600001)(53546011)(6506007)(82310400003)(82740400003)(356005)(336012)(2906002)(81166007);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2021 03:18:49.4073 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3798125a-0c09-4557-c977-08d971ae360e X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT047.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0802MB2445 Hi Stefano > -----Original Message----- > From: Stefano Stabellini > Sent: Friday, September 3, 2021 5:31 AM > To: Penny Zheng > Cc: xen-devel@lists.xenproject.org; sstabellini@kernel.org; julien@xen.or= g; > Bertrand Marquis ; Wei Chen > ; nd > Subject: Re: [PATCH v5 2/7] xen/arm: introduce domain on Static Allocatio= n >=20 > On Tue, 24 Aug 2021, Penny Zheng wrote: > > Static Allocation refers to system or sub-system(domains) for which > > memory areas are pre-defined by configuration using physical address > ranges. > > Those pre-defined memory, -- Static Memory, as parts of RAM reserved > > in the beginning, shall never go to heap allocator or boot allocator fo= r any > use. > > > > Memory can be statically allocated to a domain using the property > > "xen,static- mem" defined in the domain configuration. The number of > > cells for the address and the size must be defined using respectively > > the properties "#xen,static-mem-address-cells" and "#xen,static-mem-siz= e- > cells". > > > > This patch introduces this new `xen,static-mem` feature, and also > > documents and parses this new attribute at boot time. > > > > This patch also introduces a new field "bool xen_domain" in "struct > membank" > > to tell the difference of one memory bank is reserved as the whole > > hardware resource, or bind to one specific xen domain node, through > > "xen,static-mem" > > > > Signed-off-by: Penny Zheng > > --- > > v5 changes: > > - check the node using the Xen domain binding whether contains the > > property "xen,static-mem", not the property itself > > - add "rc =3D ..." to get the error propagated > > - introduce new field "bool xen_domain", then static memory shall be > > also stored as reserved memory(bootinfo.reserved_mem), but being bind > > to one specific Xen domain node. > > - doc refinement > > --- > > docs/misc/arm/device-tree/booting.txt | 33 ++++++++++++++++++++++++ > > xen/arch/arm/bootfdt.c | 36 +++++++++++++++++++++++++-- > > xen/include/asm-arm/setup.h | 1 + > > 3 files changed, 68 insertions(+), 2 deletions(-) > > > > diff --git a/docs/misc/arm/device-tree/booting.txt > > b/docs/misc/arm/device-tree/booting.txt > > index 5243bc7fd3..95b20ddc3a 100644 > > --- a/docs/misc/arm/device-tree/booting.txt > > +++ b/docs/misc/arm/device-tree/booting.txt > > @@ -268,3 +268,36 @@ The DTB fragment is loaded at 0xc000000 in the > > example above. It should follow the convention explained in > > docs/misc/arm/passthrough.txt. The DTB fragment will be added to the > > guest device tree, so that the guest kernel will be able to discover t= he device. > > + > > + > > +Static Allocation > > +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > + > > +Static Allocation refers to system or sub-system(domains) for which > > +memory areas are pre-defined by configuration using physical address > ranges. > > + > > +Memory can be statically allocated to a domain using the property > > +"xen,static- mem" defined in the domain configuration. The number of > > +cells for the address and the size must be defined using respectively > > +the properties "#xen,static-mem-address-cells" and "#xen,static-mem-si= ze- > cells". > > + > > +Below is an example on how to specify the static memory region in the > > +device-tree: > > + > > + / { > > + chosen { > > + domU1 { > > + compatible =3D "xen,domain"; > > + #address-cells =3D <0x2>; > > + #size-cells =3D <0x2>; > > + cpus =3D <2>; > > + #xen,static-mem-address-cells =3D <0x1>; > > + #xen,static-mem-size-cells =3D <0x1>; > > + xen,static-mem =3D <0x30000000 0x20000000>; > > + ... > > + }; > > + }; > > + }; > > + > > +This will reserve a 512MB region starting at the host physical > > +address > > +0x30000000 to be exclusively used by DomU1 >=20 > This binding is OK. We might want to clarify what is the purpose of the > "memory" property when "xen,static-mem" is present. I would suggest to wr= ite > that when "xen,static-mem" is present, the "memory" property becomes > optional. Or even better: >=20 > """ > When present, the xen,static-mem property supersedes the memory property. > """ >=20 oh, "supersede" learned! ;) >=20 > In the future when Xen will support direct mapping, I assume that we'll a= lso > add a direct-map property to enable it. Something like: >=20 > domU1 { > compatible =3D "xen,domain"; > #address-cells =3D <0x2>; > #size-cells =3D <0x2>; > cpus =3D <2>; > #xen,static-mem-address-cells =3D <0x1>; > #xen,static-mem-size-cells =3D <0x1>; > xen,static-mem =3D <0x30000000 0x20000000>; > direct-map; > ... > }; >=20 > Maybe I would add a statement to clarify it that xen,static-mem doesn't > automatically imply direct mapping. Something like: >=20 > """ > The static memory will be mapped in the guest at the usual guest memory > addresses (GUEST_RAM0_BASE, GUEST_RAM1_BASE) defined by > xen/include/public/arch-arm.h. > """ >=20 Thanks for the detailed suggestion. I'll just take it. > The rest of the patch looks OK. One minor NIT below. >=20 >=20 >=20 > > diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c index > > 8c81be3379..00f34eec58 100644 > > --- a/xen/arch/arm/bootfdt.c > > +++ b/xen/arch/arm/bootfdt.c > > @@ -66,7 +66,7 @@ void __init device_tree_get_reg(const __be32 **cell, > > u32 address_cells, static int __init device_tree_get_meminfo(const voi= d *fdt, > int node, > > const char *prop_name, > > u32 address_cells, u32 size_= cells, > > - void *data) > > + void *data, bool > > + xen_domain) > > { > > const struct fdt_property *prop; > > unsigned int i, banks; > > @@ -90,6 +90,7 @@ static int __init device_tree_get_meminfo(const void > *fdt, int node, > > continue; > > mem->bank[mem->nr_banks].start =3D start; > > mem->bank[mem->nr_banks].size =3D size; > > + mem->bank[mem->nr_banks].xen_domain =3D xen_domain; > > mem->nr_banks++; > > } > > > > @@ -184,7 +185,8 @@ static int __init process_memory_node(const void > *fdt, int node, > > return -EINVAL; > > } > > > > - return device_tree_get_meminfo(fdt, node, "reg", address_cells, > size_cells, data); > > + return device_tree_get_meminfo(fdt, node, "reg", address_cells, > size_cells, > > + data, false); > > } > > > > static int __init process_reserved_memory_node(const void *fdt, int > > node, @@ -338,6 +340,34 @@ static void __init process_chosen_node(const > void *fdt, int node, > > add_boot_module(BOOTMOD_RAMDISK, start, end-start, false); } > > > > +static int __init process_domain_node(const void *fdt, int node, > > + const char *name, > > + u32 address_cells, u32 > > +size_cells) { > > + const struct fdt_property *prop; > > + > > + printk("Checking for \"xen,static-mem\" in domain node\n"); > > + > > + prop =3D fdt_get_property(fdt, node, "xen,static-mem", NULL); > > + if ( !prop ) > > + /* No "xen,static-mem" present. */ > > + return 0; > > + > > + address_cells =3D device_tree_get_u32(fdt, node, > > + "#xen,static-mem-address-cells= ", 0); > > + size_cells =3D device_tree_get_u32(fdt, node, > > + "#xen,static-mem-size-cells", 0); > > + if ( address_cells < 1 || size_cells < 1 ) > > + { > > + printk("fdt: node `%s': invalid #xen,static-mem-address-cells = or > #xen,static-mem-size-cells", > > + name); > > + return -EINVAL; > > + } > > + > > + return device_tree_get_meminfo(fdt, node, "xen,static-mem", > address_cells, > > + size_cells, > > +&bootinfo.reserved_mem, true); } > > + > > static int __init early_scan_node(const void *fdt, > > int node, const char *name, int dept= h, > > u32 address_cells, u32 size_cells, > > @@ -356,6 +386,8 @@ static int __init early_scan_node(const void *fdt, > > process_multiboot_node(fdt, node, name, address_cells, size_ce= lls); > > else if ( depth =3D=3D 1 && device_tree_node_matches(fdt, node, "c= hosen") ) > > process_chosen_node(fdt, node, name, address_cells, > > size_cells); > > + else if ( depth =3D=3D 2 && device_tree_node_compatible(fdt, node, > "xen,domain") ) > > + rc =3D process_domain_node(fdt, node, name, address_cells, > > + size_cells); > > > > if ( rc < 0 ) > > printk("fdt: node `%s': parsing failed\n", name); diff --git > > a/xen/include/asm-arm/setup.h b/xen/include/asm-arm/setup.h index > > c4b6af6029..6c3c16294b 100644 > > --- a/xen/include/asm-arm/setup.h > > +++ b/xen/include/asm-arm/setup.h > > @@ -24,6 +24,7 @@ typedef enum { > > struct membank { > > paddr_t start; > > paddr_t size; > > + bool xen_domain; /* whether memory bank is bind to Xen domain. */ > ^ a or the ^ bound to a >=20 Sure. Will fix it. >=20 > > }; > > > > struct meminfo { > > -- > > 2.25.1 > > From xen-devel-bounces@lists.xenproject.org Tue Sep 07 03:54:25 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 03:54:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180349.326957 (Exim 4.92) (envelope-from ) id 1mNSBZ-0007ve-JU; Tue, 07 Sep 2021 03:54:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180349.326957; Tue, 07 Sep 2021 03:54:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNSBZ-0007vX-GV; Tue, 07 Sep 2021 03:54:13 +0000 Received: by outflank-mailman (input) for mailman id 180349; Tue, 07 Sep 2021 03:54:12 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNSBY-0007vN-AZ; Tue, 07 Sep 2021 03:54:12 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNSBY-00021d-0j; Tue, 07 Sep 2021 03:54:12 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNSBX-0004Yg-Jc; Tue, 07 Sep 2021 03:54:11 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mNSBX-00032x-Ik; Tue, 07 Sep 2021 03:54:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=TJwIEulUiBltS3/OiOSnKXFQSw0k5U3f7zwUaqBCPKQ=; b=ZX9rmJo9WSX/IXtVPVa/sdqKRl 8hCpu4B3Fg2IeYSebpZO1l4Nr+ARPSVeUZ1w1/UDAFXekBAbHmMq0HGhFg4PMXaZusl5Kuwpv8MR1 8yRAB21cuBSGFb1unwtaPWlBnuzuP01JWy1/O/fLBLMvSXu8nWcYwjxxcJih61q/tIkQ=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 164864: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug qemu-mainline:test-armhf-armhf-xl-rtds:guest-start:fail:allowable qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=935efca6c246c108253b0e4e51cc87648fc7ca10 X-Osstest-Versions-That: qemuu=88afdc92b644120e0182c8567e1b1d236e471b12 From: osstest service owner Date: Tue, 07 Sep 2021 03:54:11 +0000 flight 164864 qemu-mainline real [real] flight 164868 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/164864/ http://logs.test-lab.xenproject.org/osstest/logs/164868/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 164868-retest Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 14 guest-start fail REGR. vs. 164855 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 164855 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 164855 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 164855 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 164855 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 164855 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 164855 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 164855 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass version targeted for testing: qemuu 935efca6c246c108253b0e4e51cc87648fc7ca10 baseline version: qemuu 88afdc92b644120e0182c8567e1b1d236e471b12 Last test of basis 164855 2021-09-06 10:06:44 Z 0 days Testing same since 164864 2021-09-06 18:07:55 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Peter Krempa Peter Maydell Philippe Mathieu-Daudé Thomas Huth Willian Rampazzo jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git 88afdc92b6..935efca6c2 935efca6c246c108253b0e4e51cc87648fc7ca10 -> upstream-tested From xen-devel-bounces@lists.xenproject.org Tue Sep 07 04:18:35 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 04:18:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180358.326972 (Exim 4.92) (envelope-from ) id 1mNSZ2-0002Qb-Fi; Tue, 07 Sep 2021 04:18:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180358.326972; Tue, 07 Sep 2021 04:18:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNSZ2-0002QU-Ce; Tue, 07 Sep 2021 04:18:28 +0000 Received: by outflank-mailman (input) for mailman id 180358; Tue, 07 Sep 2021 04:18:27 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNSZ1-0002QO-6k for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 04:18:27 +0000 Received: from smtp-out2.suse.de (unknown [195.135.220.29]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id a545b804-0f92-11ec-b0cc-12813bfff9fa; Tue, 07 Sep 2021 04:18:26 +0000 (UTC) Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 278BE1FF56; Tue, 7 Sep 2021 04:18:25 +0000 (UTC) Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap1.suse-dmz.suse.de (Postfix) with ESMTPS id B8D0612FF9; Tue, 7 Sep 2021 04:18:24 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap1.suse-dmz.suse.de with ESMTPSA id 5CvvKhDoNmE4awAAGKfGzw (envelope-from ); Tue, 07 Sep 2021 04:18:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a545b804-0f92-11ec-b0cc-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1630988305; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=h49ksqWpNBrOpV9ozMeMCOB3BPOEfvBt8DuU3qwVRqc=; b=sZNNeEPwCdCRgkir273n5eFwHDgdw09J9nVsrNWcwRIcB8eB9BEzwnPVCPOPZCdJRaUvtb NxyFo5jPrQPrxrxIirIpNeQ1LSKCvGhkbtLkmmgRNtGv89i+lkQsylxBGUAM4rdp7dydgg ePYUWKRc0W2M5DRpLXYO2RjSjFhzsS0= Subject: Re: [PATCH 1/2] PM: base: power: don't try to use non-existing RTC for storing data To: "Rafael J. Wysocki" Cc: Greg Kroah-Hartman , xen-devel@lists.xenproject.org, Linux PM , Linux Kernel Mailing List , "Rafael J. Wysocki" , Len Brown , Pavel Machek , Stable References: <20210903084937.19392-1-jgross@suse.com> <20210903084937.19392-2-jgross@suse.com> <1b6a8f9c-2a5f-e97e-c89d-5983ceeb20e5@suse.com> From: Juergen Gross Message-ID: <3f08f433-a228-d512-3608-3ed0c797e653@suse.com> Date: Tue, 7 Sep 2021 06:18:23 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="2WDWaUILT1zcTAfwQw13cP6arEOvVJ7NT" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --2WDWaUILT1zcTAfwQw13cP6arEOvVJ7NT Content-Type: multipart/mixed; boundary="40AjFM7hF7VBwEyptUN1cRO8vL4caXhmG"; protected-headers="v1" From: Juergen Gross To: "Rafael J. Wysocki" Cc: Greg Kroah-Hartman , xen-devel@lists.xenproject.org, Linux PM , Linux Kernel Mailing List , "Rafael J. Wysocki" , Len Brown , Pavel Machek , Stable Message-ID: <3f08f433-a228-d512-3608-3ed0c797e653@suse.com> Subject: Re: [PATCH 1/2] PM: base: power: don't try to use non-existing RTC for storing data References: <20210903084937.19392-1-jgross@suse.com> <20210903084937.19392-2-jgross@suse.com> <1b6a8f9c-2a5f-e97e-c89d-5983ceeb20e5@suse.com> In-Reply-To: --40AjFM7hF7VBwEyptUN1cRO8vL4caXhmG Content-Type: multipart/mixed; boundary="------------9B3DCA2E79466DA893357F5F" Content-Language: en-US This is a multi-part message in MIME format. --------------9B3DCA2E79466DA893357F5F Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 06.09.21 19:07, Rafael J. Wysocki wrote: > On Fri, Sep 3, 2021 at 11:02 AM Juergen Gross wrote: >> >> On 03.09.21 10:56, Greg Kroah-Hartman wrote: >>> On Fri, Sep 03, 2021 at 10:49:36AM +0200, Juergen Gross wrote: >>>> In there is no legacy RTC device, don't try to use it for storing tr= ace >>>> data across suspend/resume. >>>> >>>> Cc: >>>> Signed-off-by: Juergen Gross >>>> --- >>>> drivers/base/power/trace.c | 10 ++++++++++ >>>> 1 file changed, 10 insertions(+) >>>> >>>> diff --git a/drivers/base/power/trace.c b/drivers/base/power/trace.c= >>>> index a97f33d0c59f..b7c80849455c 100644 >>>> --- a/drivers/base/power/trace.c >>>> +++ b/drivers/base/power/trace.c >>>> @@ -13,6 +13,7 @@ >>>> #include >>>> #include >>>> #include >>>> +#include >>>> >>>> #include >>>> >>>> @@ -165,6 +166,9 @@ void generate_pm_trace(const void *tracedata, un= signed int user) >>>> const char *file =3D *(const char **)(tracedata + 2); >>>> unsigned int user_hash_value, file_hash_value; >>>> >>>> + if (!x86_platform.legacy.rtc) >>>> + return 0; >>> >>> Why does the driver core code here care about a platform/arch-specifi= c >>> thing at all? Did you just break all other arches? >> >> This file is only compiled for x86. It depends on CONFIG_PM_TRACE_RTC,= >> which has a "depends on X86" attribute. >=20 > This feature uses the CMOS RTC memory to store data, so if that memory > is not present, it's better to avoid using it. >=20 > Please feel free to add >=20 > Reviewed-by: Rafael J. Wysocki Thanks! >=20 > to this patch or let me know if you want me to take it. >=20 No, I can take it with the other patch of this small series, thanks. Juergen --------------9B3DCA2E79466DA893357F5F Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Transfer-Encoding: quoted-printable Content-Description: OpenPGP public key Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy= cWx w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O= f8Z d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y= 9bf IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq= G7/ 377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR= 3Jv c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA= QIe AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT= hpw dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0= MbD 1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv= oPH Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v= 5QL +qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ= 2Vu IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC= QoL BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr= Wf0 teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC= /nu AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh= ITT d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm= XBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz= 80h SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC= AcD AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn= FOX gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1= jnD kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0= N51 N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l= otu fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1= tqS EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA= hsD BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3= g3O ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5= dM7 wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5= D+j LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm= V2x AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N= Eaw QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW= nHI s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR= wgn BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV= bVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk= pEd IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA= QAB wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw= Tbe 8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1= vJz Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8= VGi wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW= svi uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX= zXs ZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------9B3DCA2E79466DA893357F5F-- --40AjFM7hF7VBwEyptUN1cRO8vL4caXhmG-- --2WDWaUILT1zcTAfwQw13cP6arEOvVJ7NT Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmE26BAFAwAAAAAACgkQsN6d1ii/Ey9r Hwf/c5XiAVGxbZw83ONwePCE+bf8D3q8KJTcmCkhNwelw0RK36RQnVYNwSa9bzaSR89Lzi1swmXh Lr82MokgGFWKUx9MPteFyc4i5PyxI2YNuktNKru/bQNoiVjNzBtppdt1N2GozS0vE2SeeAr+VNIf OYYpAWaHOSV0UtyOSbD5pQYD8+dAfs87HJ+1iX3p9RLGNZI+zO0MHdzqVLdTxEaVhOitakKC1sPR WXjVRTPTduUUqcnQUt93kt/1rz4zUcHoO5KdI859qIY4EmLKL4psTa2SEyjU0oB0JrUQxpoceul6 05bb8ymydiOv8M2YIpC1tRIiQMXnSWLYtp7FTgO7bg== =1oDE -----END PGP SIGNATURE----- --2WDWaUILT1zcTAfwQw13cP6arEOvVJ7NT-- From xen-devel-bounces@lists.xenproject.org Tue Sep 07 05:09:18 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 05:09:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180366.326983 (Exim 4.92) (envelope-from ) id 1mNTM0-0000Uy-9c; Tue, 07 Sep 2021 05:09:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180366.326983; Tue, 07 Sep 2021 05:09:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNTM0-0000Ur-6S; Tue, 07 Sep 2021 05:09:04 +0000 Received: by outflank-mailman (input) for mailman id 180366; Tue, 07 Sep 2021 05:09:02 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNTLy-0000Ul-OE for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 05:09:02 +0000 Received: from smtp-out2.suse.de (unknown [195.135.220.29]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id b665aacb-0f99-11ec-b0d1-12813bfff9fa; Tue, 07 Sep 2021 05:09:01 +0000 (UTC) Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 717AB1FD69; Tue, 7 Sep 2021 05:09:00 +0000 (UTC) Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap1.suse-dmz.suse.de (Postfix) with ESMTPS id 3AC84132AB; Tue, 7 Sep 2021 05:09:00 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap1.suse-dmz.suse.de with ESMTPSA id 9xPCDOzzNmHRcgAAGKfGzw (envelope-from ); Tue, 07 Sep 2021 05:09:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b665aacb-0f99-11ec-b0d1-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1630991340; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ULAENWFlyyXXMa0pYWOTC/kHazB6xVrcl7laUjdiR1o=; b=b+DEtPYHQiAp6Pcat+VpwIVL6YlRfsjaqf2YhV+fat/Att9rKkNa70v05Vn2sOIP+nOuDj 9m9g43Vafq9RYst/aUlvpHQwVo8M16n0AnrEUbz8yv7RQ94Z7v5PZ2GpBI2fwCCxe2EdVq XF0d4lBqC3xbXff1QkeRnZc7jO5ytd0= Subject: Re: [PATCH] xen/sched: fix sched_move_domain() for domain without vcpus To: Jan Beulich , Andrew Cooper Cc: George Dunlap , Dario Faggioli , Bertrand Marquis , xen-devel@lists.xenproject.org References: <20210906110057.15384-1-jgross@suse.com> <0006eb7d-a9d5-16a3-1418-a1d28c4c9a92@citrix.com> <2a42660c-e1ae-c791-784a-da39e64473f3@citrix.com> <598640b9-758a-5a0c-83cd-38b3e41d7b39@suse.com> From: Juergen Gross Message-ID: Date: Tue, 7 Sep 2021 07:08:59 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <598640b9-758a-5a0c-83cd-38b3e41d7b39@suse.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="eYCTYiqErDDNw369RivENVePujGNhH1yJ" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --eYCTYiqErDDNw369RivENVePujGNhH1yJ Content-Type: multipart/mixed; boundary="MOnJc8pN4CJCBCSVPPUd7uwGYTUt8x5wY"; protected-headers="v1" From: Juergen Gross To: Jan Beulich , Andrew Cooper Cc: George Dunlap , Dario Faggioli , Bertrand Marquis , xen-devel@lists.xenproject.org Message-ID: Subject: Re: [PATCH] xen/sched: fix sched_move_domain() for domain without vcpus References: <20210906110057.15384-1-jgross@suse.com> <0006eb7d-a9d5-16a3-1418-a1d28c4c9a92@citrix.com> <2a42660c-e1ae-c791-784a-da39e64473f3@citrix.com> <598640b9-758a-5a0c-83cd-38b3e41d7b39@suse.com> In-Reply-To: <598640b9-758a-5a0c-83cd-38b3e41d7b39@suse.com> --MOnJc8pN4CJCBCSVPPUd7uwGYTUt8x5wY Content-Type: multipart/mixed; boundary="------------AB3182B2E1CC8A09D81AD162" Content-Language: en-US This is a multi-part message in MIME format. --------------AB3182B2E1CC8A09D81AD162 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 06.09.21 13:23, Jan Beulich wrote: > On 06.09.2021 13:18, Andrew Cooper wrote: >> On 06/09/2021 12:14, Andrew Cooper wrote: >>> On 06/09/2021 12:00, Juergen Gross wrote: >>>> In case a domain is created with a cpupool other than Pool-0 specifi= ed >>>> it will be moved to that cpupool before any vcpus are allocated. >>>> >>>> This will lead to a NULL pointer dereference in sched_move_domain().= >>>> >>>> Fix that by tolerating vcpus not being allocated yet. >>>> >>>> Fixes: 70fadc41635b9b6 ("xen/cpupool: support moving domain between = cpupools with different granularity") >>>> Reported-by: Bertrand Marquis >>>> Reviewed-by: Bertrand Marquis >>>> Signed-off-by: Juergen Gross >>>> --- >>>> xen/common/sched/core.c | 4 ++++ >>>> 1 file changed, 4 insertions(+) >>>> >>>> diff --git a/xen/common/sched/core.c b/xen/common/sched/core.c >>>> index 8d178baf3d..79c9100680 100644 >>>> --- a/xen/common/sched/core.c >>>> +++ b/xen/common/sched/core.c >>>> @@ -671,6 +671,10 @@ int sched_move_domain(struct domain *d, struct = cpupool *c) >>>> =20 >>>> for ( unit_idx =3D 0; unit_idx < n_units; unit_idx++ ) >>>> { >>>> + /* Special case for move at domain creation time. */ >>>> + if ( !d->vcpu[unit_idx * gran] ) >>>> + break; >>>> + >>>> unit =3D sched_alloc_unit_mem(); >>>> if ( unit ) >>>> { >>> I think the logic would be clearer if you wrap the entire for loop in= if >>> ( d->max_vcpus ). >> >> And of course, this is wrong.=C2=A0 Turns out the domain_has_vcpus() >> predicate still hasn't been committed, but d->vcpu[0] is the correct >> internal. >=20 > Which in turn might want to be done by setting n_units to zero when > d->vcpus[0] is NULL? Yes, this would be possible. OTOH my variant is more robust in case not all vcpus are allocated, but I guess this will explode somewhere else anyway. In case I don't get any other comment today I'll change the patch to set n_units to 0 if d->vcpus[0] is NULL. Juergen --------------AB3182B2E1CC8A09D81AD162 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Transfer-Encoding: quoted-printable Content-Description: OpenPGP public key Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy= cWx w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O= f8Z d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y= 9bf IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq= G7/ 377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR= 3Jv c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA= QIe AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT= hpw dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0= MbD 1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv= oPH Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v= 5QL +qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ= 2Vu IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC= QoL BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr= Wf0 teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC= /nu AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh= ITT d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm= XBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz= 80h SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC= AcD AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn= FOX gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1= jnD kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0= N51 N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l= otu fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1= tqS EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA= hsD BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3= g3O ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5= dM7 wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5= D+j LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm= V2x AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N= Eaw QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW= nHI s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR= wgn BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV= bVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk= pEd IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA= QAB wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw= Tbe 8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1= vJz Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8= VGi wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW= svi uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX= zXs ZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------AB3182B2E1CC8A09D81AD162-- --MOnJc8pN4CJCBCSVPPUd7uwGYTUt8x5wY-- --eYCTYiqErDDNw369RivENVePujGNhH1yJ Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmE28+sFAwAAAAAACgkQsN6d1ii/Ey/7 Awf+I0zzj1zIYNjaDvWvdeVjGMhyk4ecIzDbA1809V1MqDFOY4Iuv8z+WwoM7zg+dGiuDXXT1ZeI RZmU8kjnGX08NGr43NaAghXebsFpwodJ43Jhwnpx6Xng66cNnjYtZcmQfbXGe51lNOTxBT9MyKGu QPeSIN+OWjvr6ER9CXLm9rBzaQzgXtE5EeyQlRbs52gnmwZLQftIyL/MKQ2zaB7QUkzvm59XGWyb vn3RdYQ7DPupE3ECYF0Sy2Ize6J0mdlrQhJgwkcJxa4Crp3chL0wiHtK2Thrji6Steq8tvawHbRB iWG4dOc6IioiZN1roj+ipI4IR3rAe63lZO7mQ7YnNA== =tH3r -----END PGP SIGNATURE----- --eYCTYiqErDDNw369RivENVePujGNhH1yJ-- From xen-devel-bounces@lists.xenproject.org Tue Sep 07 05:16:25 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 05:16:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180373.326994 (Exim 4.92) (envelope-from ) id 1mNTT3-0002CL-4o; Tue, 07 Sep 2021 05:16:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180373.326994; Tue, 07 Sep 2021 05:16:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNTT3-0002CE-1E; Tue, 07 Sep 2021 05:16:21 +0000 Received: by outflank-mailman (input) for mailman id 180373; Tue, 07 Sep 2021 05:16:19 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNTT1-0002C4-3j; Tue, 07 Sep 2021 05:16:19 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNTT0-0003vg-Oc; Tue, 07 Sep 2021 05:16:18 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNTT0-0000Y4-HV; Tue, 07 Sep 2021 05:16:18 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mNTT0-0003Me-Gz; Tue, 07 Sep 2021 05:16:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=maTfaYDWmwiW+WzogC0xfR3utfB9F1Ck0mkDpBgjATE=; b=b6OoRUz6X9ZrOia5P2pmSUAY6y 4vF18/DwyNkdXIbcOnw5FaXIEC1trLdJlL8LZPrIiES93esMZb7pX+Fy6bS3KS5WmNaV4YAfKo177 7k/hg2vOJUfczUd55j9kxC/3CDAWdlC7+eahahqcSrhSR2RXhyCSyi5kzZU1Oa7A3w+Q=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xtf test] 164867: all pass - PUSHED X-Osstest-Versions-This: xtf=91d215a4ed1463ab14d1f68e497117ac1255e05e X-Osstest-Versions-That: xtf=0bb720b3c486bd3de62b8c32282eb5fa192b87f3 From: osstest service owner Date: Tue, 07 Sep 2021 05:16:18 +0000 flight 164867 xtf real [real] http://logs.test-lab.xenproject.org/osstest/logs/164867/ Perfect :-) All tests in this flight passed as required version targeted for testing: xtf 91d215a4ed1463ab14d1f68e497117ac1255e05e baseline version: xtf 0bb720b3c486bd3de62b8c32282eb5fa192b87f3 Last test of basis 164779 2021-09-02 21:40:04 Z 4 days Testing same since 164867 2021-09-07 00:10:12 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Michal Orzel jobs: build-amd64-xtf pass build-amd64 pass build-amd64-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xtf.git 0bb720b..91d215a 91d215a4ed1463ab14d1f68e497117ac1255e05e -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Tue Sep 07 05:48:58 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 05:48:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180380.327008 (Exim 4.92) (envelope-from ) id 1mNTyU-0006K0-I7; Tue, 07 Sep 2021 05:48:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180380.327008; Tue, 07 Sep 2021 05:48:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNTyU-0006Jt-Et; Tue, 07 Sep 2021 05:48:50 +0000 Received: by outflank-mailman (input) for mailman id 180380; Tue, 07 Sep 2021 05:48:48 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNTyS-0006Jj-Sy; Tue, 07 Sep 2021 05:48:48 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNTyS-0004S0-Mr; Tue, 07 Sep 2021 05:48:48 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNTyS-00028l-B3; Tue, 07 Sep 2021 05:48:48 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mNTyS-0005Il-AY; Tue, 07 Sep 2021 05:48:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=m0NPz1K5DqGH2f2fWD7tNhQm6+HJEi1nopP/LaUQsXY=; b=TuI5Sj1tg81gL6wXUBhXQB3Mgh PGMWCL2MTUgFGePDP+d2yM2jAIkvh49TClfvGxG1YSJUHOPmhDezv1D0x1FHFJw5zDnn/l+U4T48z RFRiIvfscYoSbwmu58WW+4mdmDeRmIF9cx7t/LpJhoP0i3OI16/TdBQhqUTkVUZ0mkHs=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 164865: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-i386-xl-qemut-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-examine:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-i386-xl-raw:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-pvshim:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-i386:xen-install:fail:regression linux-linus:test-amd64-i386-xl-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ovmf-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-coresched-i386-xl:xen-install:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit1:debian-fixup:fail:regression linux-linus:test-arm64-arm64-xl-thunderx:debian-fixup:fail:regression linux-linus:test-arm64-arm64-xl:debian-fixup:fail:regression linux-linus:test-arm64-arm64-xl-xsm:debian-fixup:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:debian-fixup:fail:regression linux-linus:test-arm64-arm64-xl-credit2:debian-fixup:fail:regression linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=4b93c544e90e2b28326182d31ee008eb80e02074 X-Osstest-Versions-That: linux=deacdb3e3979979016fcd0ffd518c320a62ad166 From: osstest service owner Date: Tue, 07 Sep 2021 05:48:48 +0000 flight 164865 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/164865/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemut-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-examine 6 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-i386-xl-raw 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-pvshim 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-i386 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ovmf-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-coresched-i386-xl 7 xen-install fail REGR. vs. 152332 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 152332 test-arm64-arm64-xl-credit1 13 debian-fixup fail REGR. vs. 152332 test-arm64-arm64-xl-thunderx 13 debian-fixup fail REGR. vs. 152332 test-arm64-arm64-xl 13 debian-fixup fail REGR. vs. 152332 test-arm64-arm64-xl-xsm 13 debian-fixup fail REGR. vs. 152332 test-arm64-arm64-libvirt-xsm 13 debian-fixup fail REGR. vs. 152332 test-arm64-arm64-xl-credit2 13 debian-fixup fail REGR. vs. 152332 test-arm64-arm64-examine 8 reboot fail REGR. vs. 152332 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 152332 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 152332 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152332 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 152332 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152332 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152332 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152332 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: linux 4b93c544e90e2b28326182d31ee008eb80e02074 baseline version: linux deacdb3e3979979016fcd0ffd518c320a62ad166 Last test of basis 152332 2020-07-31 19:41:23 Z 402 days Failing since 152366 2020-08-01 20:49:34 Z 401 days 698 attempts Testing same since 164865 2021-09-06 21:40:45 Z 0 days 1 attempts ------------------------------------------------------------ 7221 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl fail test-armhf-armhf-xl pass test-amd64-i386-xl fail test-amd64-coresched-i386-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm fail test-amd64-i386-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm fail test-amd64-i386-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine pass test-arm64-arm64-examine fail test-armhf-armhf-examine pass test-amd64-i386-examine fail test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel fail test-amd64-i386-qemuu-rhel6hvm-intel fail test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair fail test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow fail test-arm64-arm64-xl-thunderx fail test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2221825 lines long.) From xen-devel-bounces@lists.xenproject.org Tue Sep 07 06:00:21 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 06:00:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180387.327021 (Exim 4.92) (envelope-from ) id 1mNU9Y-0000Nz-M7; Tue, 07 Sep 2021 06:00:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180387.327021; Tue, 07 Sep 2021 06:00:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNU9Y-0000Ns-Iv; Tue, 07 Sep 2021 06:00:16 +0000 Received: by outflank-mailman (input) for mailman id 180387; Tue, 07 Sep 2021 06:00:11 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNU9T-0000Nm-Fk for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 06:00:11 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 52529593-b699-4746-8d3d-60c68498e07e; Tue, 07 Sep 2021 06:00:08 +0000 (UTC) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04lp2058.outbound.protection.outlook.com [104.47.13.58]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-23-_x-3ZE5wNjy6Jx3_XoJB2w-1; Tue, 07 Sep 2021 08:00:06 +0200 Received: from AM0PR04MB5587.eurprd04.prod.outlook.com (2603:10a6:208:125::12) by AM0PR04MB5905.eurprd04.prod.outlook.com (2603:10a6:208:125::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.22; Tue, 7 Sep 2021 06:00:04 +0000 Received: from AM0PR04MB5587.eurprd04.prod.outlook.com ([fe80::ac:a0be:c26c:908b]) by AM0PR04MB5587.eurprd04.prod.outlook.com ([fe80::ac:a0be:c26c:908b%5]) with mapi id 15.20.4478.026; Tue, 7 Sep 2021 06:00:04 +0000 Received: from [10.156.60.236] (37.24.206.209) by AM4PR0101CA0052.eurprd01.prod.exchangelabs.com (2603:10a6:200:41::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Tue, 7 Sep 2021 06:00:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 52529593-b699-4746-8d3d-60c68498e07e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1630994407; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=w83dYj+PDR5QgdknZkEX8CLqhAE+6ALYyEqWNgI6TFA=; b=hPm1l70O/RipXoriEuaSty5kILEoPs61WyX3P3HcEuYJeFuXliVMuEX07XlqP9PhjdfTLM AvbCfcgRl3P6eRS59+klkadfN88kPyV/iUHd2dukFCgnTNLkTZvbjiPE+ZSjZcKA7rmQSw q2J6871EMckI/Wwa34Y4GsqDzquJQVg= X-MC-Unique: _x-3ZE5wNjy6Jx3_XoJB2w-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Lmsgw4LESNtND2ApvG38Km/fbF2zJCXhgiwJnvUBl5P4TbT4lEzJCD4tMl3j5bySPBXHrJpSDHX49l9MzgGb+MTPX1o4NMfQutgSFllTlH0GoroZVHoQBYD+6CcwDicSCUkrTbmh/hg3AuNgyFfaVfTFKT65/Xg6kRB9U1Q+5VdqgB2CGkj2YPgVr6u4TsfbIVD1ao+TI5z8xBnBn1lPTPHhIdv7PghiQUUFcdtuHMnMGjODr7W6ikDUXjWcW3hHklRF5OxcP91sXJCe9WPYyDDA6NVDDyTPlI1f4aQXje9HpFAf0t0KqoiJVKDASxwa6uVau6Pl9AvvpJwH1eicnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=wdBhc89sJrcmeLMeJkCx0mR3ZXIDHKOAM3UfkYNp9/0=; b=KbkZAH9+YVhOQBmnTvrJSjk+KaLrQZ03RXMP8rwCxnic11rb0VvCx0JNBCISGW/K5Y+35omo8fqPcY3ke9T1arYCwzfuixqa13miilNGqw+s/21s0uQBzEWpgqUTIdB2cmoi4FT/DLzb1KKmYlSYe6KsIu9MoB77D9hBuIVs0gaKLJq6poc3FHLAMcDkQvUE8CmG5zrcbGVAyWVwOdWerqE1KIM/mYpem92zBrrN9Ppo0MBdu6W3Zu2A15frNZySgW1HG/V9/XF2dh836LSlcSB6KDttTi2iVAy6hcr1SXnCzroQ4ldnq//gcbhNsC2cxtAg2khOk+G+QO1xgZEotA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com; Subject: Re: [PATCH v4 01/11] xen: Implement xen/alternative-call.h for use in common code To: Andrew Cooper , "Daniel P. Smith" CC: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Bob Eshleman , Alistair Francis , Connor Davis , George Dunlap , Ian Jackson , Wei Liu , xen-devel@lists.xenproject.org References: <20210903190629.11917-1-dpsmith@apertussolutions.com> <20210903190629.11917-2-dpsmith@apertussolutions.com> <3a91e4ad-50c4-205f-3d90-f23c996b2938@suse.com> <8c3dfbf5-5c98-c923-ca81-28af3d13c4a4@citrix.com> From: Jan Beulich Message-ID: <7e71ce74-dd81-21c3-db78-c37d95d5b239@suse.com> Date: Tue, 7 Sep 2021 08:00:02 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: <8c3dfbf5-5c98-c923-ca81-28af3d13c4a4@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AM4PR0101CA0052.eurprd01.prod.exchangelabs.com (2603:10a6:200:41::20) To AM0PR04MB5587.eurprd04.prod.outlook.com (2603:10a6:208:125::12) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 14001ceb-ff84-4416-7d5a-08d971c4bccc X-MS-TrafficTypeDiagnostic: AM0PR04MB5905: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:3513; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: H7ttFfQ3qWqnMmw99mi5eUcYejrNwksYux9Ys8WEZdMAHfkpUftxRtrl1ijmFmOqgKsMaVLo23hDnqR2sVKYRGx5JqWvJL3hGZsEZJ7xXXvIdET3fIH+0PFdCXSNJSrN6OkCimuKAepqnUR7FVNjsAuKxTQS9Y5IRE2yuDRQOFDOwUJyw8YW9s9MxKMJnAr93LfCWtIUJxduzqvBxr5huJQrAJ9Ab8vNw0c40m26eAufr+pXaG9dRfEJ+HNYF8BFcYcUahRJxozWIH0b/RdsHkL9mnvVm9aP+d5oJIsnuF7bXArERm3r2ZAObEf10LQWwizRpaTk1GRosvcKv5nCu0rRLVJGsvrW5v8Y6G2T7UhC9SEZNuwhcb7ar64bynfp4kB4leFbs/N9qxJ3tOJtu5r3wMNLmZSwkEkloi78DmnpRWdoAK9DbvtivMSHSc4b+GUbYZr9M93GM3ox19Ilc/q+DweykZ9t2CPuQO5RXwgOaSSjVuNVkZgnTPf1H5EEvvvakwnp8UiXZjp24CzIf3sKoYfBi7iXg6aerB0zgjqgYYDqRv0UsCVdsxnRmEbYfsrQS64PyB7vd4mGMmGfv3xYY2q6OGnZYyFfNKtu28UKpG24DZwypha2Q1oOZQ8DqcY51ewq0O8QBjY7P5qzg2K17gb4L9RbqR36cvYQ82kP9C2ximGChMu5IVMbGZsWmS6bJ0uyFyPgSpN12iuE1w== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR04MB5587.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(396003)(39860400002)(136003)(376002)(346002)(366004)(86362001)(8936002)(26005)(38100700002)(5660300002)(53546011)(316002)(110136005)(4326008)(54906003)(186003)(83380400001)(16576012)(31696002)(2906002)(956004)(2616005)(478600001)(7416002)(36756003)(66946007)(66556008)(31686004)(66476007)(6486002)(8676002)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?dzyN9tY8BYalUgFoqgWIGUxwOGT2FrB7VfTjX8O+hAXX6/aekdTj9KOGk67t?= =?us-ascii?Q?VAtLNTLvBXOvx9m0YnsHyDHH8gZk2xjymkEvGKLFP/uS9wSrOHkTJFywjRAa?= =?us-ascii?Q?ySNuTu0SSCK9R2uyELBG7jY30nOF2k7xkkTdkIFCGDA0dAPap8p9a2gp/eUd?= =?us-ascii?Q?4Sk5LGvriljUpAH016ikdtfvtA5HrbIXRVUMtZkrJVa/CJhGkIv1aHK6lo/4?= =?us-ascii?Q?Fwmcu9b/eGHAnL1HHz62O2aCRA+41oMTpurpYCkKE0jkhd0YOklG8bpF0yX0?= =?us-ascii?Q?G1nFpg20I60elkc2Ab+ElNFWkox0ej1JEtaIewhdvZxsPyipt+ITxuugnVSy?= =?us-ascii?Q?uVhQ3I1g3BWAii0zII1Bu+SDXkbTk1JC6gzmmcNBEdskIT/aikjgUh13fbsX?= =?us-ascii?Q?YmVFqEd4Kd3SDsYCdiTiEAzYT5gX3nNx//AZiYccKR07UDM8oOKA2ya8TO0u?= =?us-ascii?Q?lVFOuUbMaLEf2KWJRd3sx+1QDd8WTd3W3OltUSOCKtGvHl/LnZ6m+5p2hUqO?= =?us-ascii?Q?783l0UHSC6reoIJePsuqnO6wkv9Cd/9bYyy23upli1wA7no7verHoJUVEExZ?= =?us-ascii?Q?MUqlYmCku13Nfjr2dNHYJ86z+JMKU0/rtLDOh5Hm0Oi6LJgv8xArGXiw1oAH?= =?us-ascii?Q?62TSWorCVPn78xPR8xPgsaZrcSC3dy/e3rvFSV+oRfd26yWijX+MZZPFwHNr?= =?us-ascii?Q?tZKAk0w9kkIV2a8I5R/psS6t9N3PD3BsZWFbFHVlkCOiFM4c1iwaouocCOrL?= =?us-ascii?Q?WA70SsBH12BB5XbxnBqu1DgkGD5e3d5jCM3gSebaRglyOYJp9KJG7x5maoYL?= =?us-ascii?Q?7c9qivnuoyl9sDyPWJQNl60rfyiJTpokPPtTyT4vfDN8eTu3Bdg/BDCTRO1q?= =?us-ascii?Q?BIKlKVd5njTicuIYa/hCw0b2L7wkwzmUrownAcRtI68eehEnhl5ldPtyRuT+?= =?us-ascii?Q?M51GH2jSkaaMxhTW7JauWA32TuWt1BReWUkNVThhYBKGSFsD+vmYORynU6k4?= =?us-ascii?Q?A399oGrAy+57eyr0DwQtl4yT83lHfj28gYGDhlq0QuBRJypHdpro5o0+nDmQ?= =?us-ascii?Q?WtBa7y//F1WvBK3mOD21n9dwE9kvDbHNl51HwSS9sTkkOpEjbqPbt5jVuhjV?= =?us-ascii?Q?g59+5Qqr7NrFWHkgPWt9QQX+IMcNSK6Rterjf5sMRk1MsXJzOjtD2GLbN2NN?= =?us-ascii?Q?mUu/EdqOOG5RsuO1waWrWvN7MtbEsnVWrAPTj30qKfioHokN+UVMoAtgDYvX?= =?us-ascii?Q?oCfn4fYKYSl97LoHDfNlKu4YDaM0p2cMXGAIVv3BczdsvJBmgdWVvAjpsxTC?= =?us-ascii?Q?u9+hj8Ssyhmuhbv3xrYDokWV?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 14001ceb-ff84-4416-7d5a-08d971c4bccc X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB5587.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2021 06:00:04.6501 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: UNB7QpZ9odRRqHEJQQzmwZcymWzZdUI65i3gN3l2Ijwx2f6qPwS2A9HgJH8NXRwBM8U6XeJgDBsYCdFGXkdyjA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB5905 On 06.09.2021 18:22, Andrew Cooper wrote: > On 06/09/2021 16:52, Jan Beulich wrote: >> On 03.09.2021 21:06, Daniel P. Smith wrote: >>> --- /dev/null >>> +++ b/xen/include/xen/alternative-call.h >>> @@ -0,0 +1,63 @@ >>> +/* SPDX-License-Identifier: GPL-2.0 */ >>> +#ifndef XEN_ALTERNATIVE_CALL >>> +#define XEN_ALTERNATIVE_CALL >>> + >>> +/* >>> + * Some subsystems in Xen may have multiple implementions, which can b= e >>> + * resolved to a single implementation at boot time. By default, this= will >>> + * result in the use of function pointers. >>> + * >>> + * Some architectures may have mechanisms for dynamically modifying .t= ext. >>> + * Using this mechnaism, function pointers can be converted to direct = calls >>> + * which are typically more efficient at runtime. >>> + * >>> + * For architectures to support: >>> + * >>> + * - Implement alternative_{,v}call() in asm/alternative.h. Code gene= ration >>> + * requirements are to emit a function pointer call at build time, a= nd stash >>> + * enough metadata to simplify the call at boot once the implementat= ion has >>> + * been resolved. >>> + * - Select ALTERNATIVE_CALL in Kconfig. >>> + * >>> + * To use: >>> + * >>> + * Consider the following simplified example. >>> + * >>> + * 1) struct foo_ops __alt_call_maybe_initdata ops; >>> + * >>> + * 2) const struct foo_ops __initconst foo_a_ops =3D { ... }; >>> + * const struct foo_ops __initconst foo_b_ops =3D { ... }; >>> + * >>> + * void foo_init(void) >>> + * { >>> + * ... >>> + * if ( use_impl_a ) >>> + * ops =3D *foo_a_ops; >>> + * else if ( use_impl_b ) >>> + * ops =3D *foo_b_ops; >>> + * ... >>> + * } >>> + * >>> + * 3) alternative_call(ops.bar, ...); >>> + * >>> + * There needs to a single ops object (1) which will eventually contai= n the >>> + * function pointers. This should be populated in foo's init() functi= on (2) >>> + * by one of the available implementations. To call functions, use >>> + * alternative_{,v}call() referencing the main ops object (3). >>> + */ >>> + >>> +#ifdef CONFIG_ALTERNATIVE_CALL >>> + >>> +#include >>> + >>> +#define __alt_call_maybe_initdata __initdata >> My v3 comment here was: >> >> "I think it wants (needs) clarifying that this may only be used if >> the ops object is used exclusively in alternative_{,v}call() >> instances (besides the original assignments to it, of course)." >> >> I realize this was slightly too strict, as other uses from .init.* >> are of course also okay, but I continue to think that - in >> particular with the example using it - there should be a warning >> about this possible pitfall. Or am I merely unable to spot the >> wording change somewhere in the comment? >=20 > Such a comment is utterly pointless.=C2=A0 initdata has a well known mean= ing, > and a comment warning about the effects of it is just teaching > developers to suck eggs[1] Well, okay then - at least the definition of __alt_call_maybe_initdata isn't far away from the comment. (What I'm not convinced of is that people knowing __initdata's meaning necessarily need to correctly infer __alt_call_maybe_initdata's.) Two other observations about the comment though, which I'd like to be taken care of (perhaps while committing): - __initconst wants to become __initconstrel. - foo_init(), seeing that there are section annotations elsewhere, wants to be marked __init. Then Acked-by: Jan Beulich Daniel, you having made changes (even if just minor ones) imo requires you S-o-b on the patch alongside Andrew's. Jan From xen-devel-bounces@lists.xenproject.org Tue Sep 07 06:10:04 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 06:10:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180394.327033 (Exim 4.92) (envelope-from ) id 1mNUIo-0001QF-NG; Tue, 07 Sep 2021 06:09:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180394.327033; Tue, 07 Sep 2021 06:09:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNUIo-0001Q8-K9; Tue, 07 Sep 2021 06:09:50 +0000 Received: by outflank-mailman (input) for mailman id 180394; Tue, 07 Sep 2021 06:09:49 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNUIn-0001Q2-Ji for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 06:09:49 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 3422ff0a-0fa2-11ec-b0d5-12813bfff9fa; Tue, 07 Sep 2021 06:09:48 +0000 (UTC) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04lp2055.outbound.protection.outlook.com [104.47.12.55]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-14-I2SFiyC0PHSf8gq9h58a1A-1; Tue, 07 Sep 2021 08:09:46 +0200 Received: from AM0PR04MB5587.eurprd04.prod.outlook.com (2603:10a6:208:125::12) by AM0PR04MB4611.eurprd04.prod.outlook.com (2603:10a6:208:71::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19; Tue, 7 Sep 2021 06:09:44 +0000 Received: from AM0PR04MB5587.eurprd04.prod.outlook.com ([fe80::ac:a0be:c26c:908b]) by AM0PR04MB5587.eurprd04.prod.outlook.com ([fe80::ac:a0be:c26c:908b%5]) with mapi id 15.20.4478.026; Tue, 7 Sep 2021 06:09:44 +0000 Received: from [10.156.60.236] (37.24.206.209) by AM4PR0701CA0002.eurprd07.prod.outlook.com (2603:10a6:200:42::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.4 via Frontend Transport; Tue, 7 Sep 2021 06:09:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3422ff0a-0fa2-11ec-b0d5-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1630994987; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=intlh2v0bqwJEaN4Bk097uOqhuTDV3eIWchBM22Tee4=; b=aV4wV8NhcS1f/dnBgkrI0DM4ytGBv68YsQGT2XISstUDig9eS8fzbXtc6llASR4mN8WkOW MWW61lbUQCbOLtMyDnEBEalc90acpljJV+BRaW9PnXzIctkvbL9EqPcaDtdsZotJwx4j2w AWyWDHjd7ZTGDR2xoqTe4h/PWSuyXiI= X-MC-Unique: I2SFiyC0PHSf8gq9h58a1A-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hcbsu/NNkyMxzR3bZfLME8+s1JV0JyI2Uhr3w4fNcvbXqtGc/uCrJkeSavDumnckzNMCBQ3T1LcfbrkAmrkqR1BzKOZVAVtimIdh0rlnuc96XZ8+VwhvtkrTLIVJpHaXJ5KgrEh33Ul6+FdvysuaVesped2xxWgL6nAPmWNVAXSkbdJmWcQIAmZK+dgH2Sqt7yTNbOOVVunyFRcfhcDqzO0zsh+4ffTJNQmK0EKsapsL32OpzU9FWDI4tok+Ci7EkSxyWAAWtCeXPH2w/yPDbxn9hXDEvpoplGD9zfyiQ4oTzFdtdyNrBWCBpWq21SJblw+VfoGSr6eWLBzd4HSuDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=intlh2v0bqwJEaN4Bk097uOqhuTDV3eIWchBM22Tee4=; b=WbNhEBKMFas0v7so4B4EXMK9VDttK5CrggaDVaZqYQx1XKXr+YTHtmInwHsLFbOIxE0XUGU3swoxoFCi15mYDKRMb9PGa2+ehxPnS8FJmToBtyP9sqcG+DEBg8lXbrN4V6qLsJ5tD1nrAac1QpfXdXnE/7wIAAbpTar39N2+K1Z8/lxcy/LL/Eo3JqOwA+GQ5zamfLgaqfjKu0uCNPQvUccrUp2FrDS0IfNPEiwrfBweBiKlh7N7SUQrDII/Fr7Yb1A1BV53i/dF+VN7hlsMC9gHSXkbntc/35IE9BZaR3sQD5LOsyK4txW306mZhWyzPgvMYotPkjwldPEXK3ZtjQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: citrix.com; dkim=none (message not signed) header.d=none;citrix.com; dmarc=none action=none header.from=suse.com; Subject: Re: [PATCH v1 2/2] x86/cpuid: Detect null segment behaviour on Zen2 CPUs To: Andrew Cooper Cc: Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Pu Wen , Andy Lutomirski , Xen-devel , Jane Malalane References: <26b88d5a-ae6f-0065-7c3f-5eeb6dd80078@suse.com> <2972c71a-5fed-0813-8ec0-d179eacff14d@citrix.com> From: Jan Beulich Message-ID: <70f376c6-eef2-42ce-a8eb-67c1130a41e4@suse.com> Date: Tue, 7 Sep 2021 08:09:43 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: <2972c71a-5fed-0813-8ec0-d179eacff14d@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM4PR0701CA0002.eurprd07.prod.outlook.com (2603:10a6:200:42::12) To AM0PR04MB5587.eurprd04.prod.outlook.com (2603:10a6:208:125::12) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1f42b0e4-3df2-4116-88cd-08d971c61668 X-MS-TrafficTypeDiagnostic: AM0PR04MB4611: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: oLzwCsgJlpWEVEYU8ia0oPbj8WWhy6mWDF4u/iJixc/tU0IECKC+E36AMCdW44Pu6cLxEGThCFvrhq9Qt4a0KbWphiRcLPiotMZjZ/SoCDSNDWCMfB4rLKcMvWlvp5zJosOFJzYaX9s9R+S51dwp5WK8LlkEo+tchDWgBQ6I7QVsG2si85F2Ye+VsovxkiTo++8IECHw6HWdcx4RDmgVe5Gie9CI/6M/AYC/KldiurePOlvDkh+KWWQ9vAlNpSA9Wh7E6nnySubtU7tf44J8goSa50/jt9OQ45FJ8nR8LPAEHckmzx0brCG01SVRlZxnpW3QWUxsnKPTIts6zeUFFZi73AYg1nAVYw3ZvKlhNM6V8/PFVWuvKjue79udDYMmqfiWHoDc9VOdFLarwPNY7WENCXsPKzrP/9L0aZLOFQ2A4jvD0ICSDZLA5YdAeQKQBrYV0f6RtonNvYWulAjI3tPpAnXkQ7dOPj6YEhRAyEoU3Y1c7F1Jv1/Ha1MO7bTvo5gwSPmSTnxpxGfYPcqOL7rBIplvgxCVc7ZaxjqZISeAjPUtLdgnBW7EUv0OG3t/afKHt9ZDDMod6TRlfef5aWR1hoZb3SaIr6af3EXQCEr8VJUC5nGUn4MtCnojFiglDbmj4cB9o2xxdsnLsi7pb92Fzm2vQNHCyT0X1d0FUUB8zd7d0ZzZbxtKvU72RXhSpGjhagZj14BUKfkn4fWzNvdevARVQ3Bc6f1xkBPwDlYtddcTSpVrqt5kL+fswrsi X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR04MB5587.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(136003)(376002)(39860400002)(346002)(366004)(396003)(31696002)(2616005)(478600001)(8936002)(4326008)(66556008)(6916009)(66476007)(66946007)(38100700002)(316002)(16576012)(6486002)(31686004)(54906003)(86362001)(53546011)(83380400001)(36756003)(956004)(26005)(186003)(5660300002)(8676002)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VWhEM1dTQm53Nnh4NGlkN1V5bkN3ck5kaHd3ZFhINlZ5SXIwM0RndUw3alc2?= =?utf-8?B?RlNYZ3hXYWRpY0JLeitsU29peVR5blpqTGU0N0thTnhrdnM5L1NmOGF5OWpK?= =?utf-8?B?djJZVmVOL0EzUlVmdm8rR1hvU1NQUVVtdlZQQWtycFdjZzB2OGhMd04vSUwy?= =?utf-8?B?NVNlbjhGcHI3bDN0aTB3MStRMUdRRC9kbDJtc0xFQnpOQUZBdmpOVHo4Zk5R?= =?utf-8?B?YVNnMytVNEpRTUJNZDk0Nm41RENGS2o0aFVNaFhlMWRsamVVTnJrSUpXWGZv?= =?utf-8?B?ZnVibWlsTGZoN0dPN0dvRUlVbW5EWUMrUTNnM3pHOEwzL0pvcWp1bXFmRUJ5?= =?utf-8?B?bDExSlo3MGJUSmVOU1ZUalhpU3ZkT1drcjRZaWVUc09yVXV4SzZ2cXNtYzhN?= =?utf-8?B?ekQwdm92REdnVHl1OC9GdDIrUlZ6L0hLTXJndWJTZkJXeWV2clg5M2hRdUhy?= =?utf-8?B?eXpIaFFHbnRlem1lc0daWjZRUFpjYTFPZjdabVJkRThHcHFROEJuTkNkejBE?= =?utf-8?B?MHhFaGN5YkY0N2lUS043em1TVzdPeTZKdjJpbUMxQWxyN2Ezdm1vTTNEcXVY?= =?utf-8?B?RldJWGc0bVZ3SXAyWGFuNGJtV0ZNSDFqaVpidm1zOWpZYzRZblFkaUoxaFNO?= =?utf-8?B?N3JiaEdheVZnWXhzdUE0VXhSNzVBVlh1VUJISjFXZnV0a1A5M1ZhSURIODZS?= =?utf-8?B?d0ovOWxueHZjNFU2Z3FDcUw2QlJEVmJoblkrTXZKcjllZTN6OHNXODA3RVZp?= =?utf-8?B?T0Z0bGdlWHY2K3dXcG9EUXlSNEJOU2trbmJkUWt5RmM1RGJKK1ozWm56VXE5?= =?utf-8?B?dWhMVUxXSmMzQjBZSmU3QWZIYS9pSkNMWjdqVko0SGIrRWQ0dnlZdjlYclZj?= =?utf-8?B?RDNMQTRhT1N6V0NOa0FmdlNGVDc2bXUwY2NSR3R5SEpDbGZqazVTNkVJWWJP?= =?utf-8?B?RXpUajliZDJ3Q1NaUlRDWk4yUXRKaHN3b3FUT3pLUlFmVTRyODRvUXNBWXJB?= =?utf-8?B?UDEvQUEydHYyeWVvbE9oUXg4VjVyVWs2ZDB5aGsvT00zY2xUQ3pTcWpwdjVU?= =?utf-8?B?NlRWaDNuZjRXMjFNYmF5UTNNNzRkdGFQWmhmS2F1dTdwU2w3dlVEZmVscnov?= =?utf-8?B?ZHU1bllYbVMrN2pmRG4zQUcrcXBwYktWalhVSkJJWTY1NnJJT20rQVRCb1hh?= =?utf-8?B?RC94UVhZNWF3ZVMzY1NTM2V6M1NPRENzcm96MzV4TW1LK1VQakJ1SFM5MGtE?= =?utf-8?B?ODV5VjV3WkZFdmVSYjBKS0UzREgxWWxyaE1pTGhvUTFaeCtYNldxVGlzUlRR?= =?utf-8?B?OUU2amRRMzRVUmdJbnF6OGZzMDNPc09iRXlqYVErZTRlWEtwbVdERnJkQ3RC?= =?utf-8?B?ZXUwdmFidkwrMHRZNlJlRkdoTm5kMHlRdDFZS3pYV29KbjNpYkc5U0NqRlNN?= =?utf-8?B?OVYwcC9oa2c3L3grM1hhRTFtcmlzdFJwSGN3OUdYa09SMWpEdkE0aFBWQWRl?= =?utf-8?B?TXp4a2I3VytHMTBQUmIvOTZFZTJHRkkwWXZEdVRJaFBRYkRXZDlyTFYvOWZq?= =?utf-8?B?U0tNQ29BOXh3d1Z0aGp2UXFHNzlvRnBDZlVtYmVUbDFITHBEUUpVdk9hV3JB?= =?utf-8?B?amhGN3AveEpyVyt5bmZkbU84VlBLbndhMFBNOXNVQlQzOUNNR0I2TiswM21K?= =?utf-8?B?R0kxNmk5bTRzTEFmeURHNzM3eDNPMmlMbFkycWQwdGZIa2FDRk5iOGxBQlZx?= =?utf-8?Q?frwx11arucvmqtG/L+Z5vi9OjXR9sye0svjP/3Q?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1f42b0e4-3df2-4116-88cd-08d971c61668 X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB5587.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2021 06:09:44.4237 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: zrlXNOH2d3K10CZXYFx7pC+O0tNHhdwiSffOj27flzzms69sKdbMJoU/ZievS9k1nRDdpvbotinVz7WafPficA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB4611 On 06.09.2021 20:07, Andrew Cooper wrote: > On 06/09/2021 16:17, Jan Beulich wrote: >> On 06.09.2021 14:00, Jane Malalane wrote: >>> --- a/xen/arch/x86/cpu/amd.c >>> +++ b/xen/arch/x86/cpu/amd.c >>> @@ -681,6 +681,19 @@ void amd_init_lfence(struct cpuinfo_x86 *c) >>> c->x86_capability); >>> } >>> >>> +void detect_zen2_null_seg_behaviour(void) >> This can in principle be marked __init. >> >>> +{ >>> + uint64_t base; >>> + >>> + wrmsrl(MSR_FS_BASE, 1); >>> + asm volatile ( "mov %0, %%fs" :: "rm" (0) ); >> While I don't strictly mind the "m" part of the constraint to remain >> there (in the hope for compilers actually to support this), iirc it's >> not useful to have when the value is a constant: Last time I checked, >> the compiler would not instantiate an anonymous (stack) variable to >> fulfill this constraint (as can be seen when dropping the "r" part of >> the constraint). > > This is "rm" because it is what we use elsewhere in Xen for selectors, > and because it is the correct constraints based on the legal instruction > encodings. grep-ing for "%%[defgs]s" reveals: efi_arch_post_exit_boot(), svm_ctxt_switch_to(), and do_set_segment_base() all use just "r". This grep has not produced any use of "rm". What are you talking about? > If you want to work around what you perceive to be bugs in compilers > then submit a independent change yourself. I don't perceive this as a bug; perhaps a desirable feature. I also did start my response with "While I don't strictly mind the "m" part ..." - was this not careful enough to indicate I'm not going to insist on the change, but I'd prefer it to be made? >>> @@ -731,6 +744,11 @@ static void init_amd(struct cpuinfo_x86 *c) >>> else /* Implicily "== 0x10 || >= 0x12" by being 64bit. */ >>> amd_init_lfence(c); >>> >>> + /* Probe for NSCB on Zen2 CPUs when not virtualised */ >>> + if (!cpu_has_hypervisor && !cpu_has_nscb && c == &boot_cpu_data && >>> + c->x86 == 0x17 && c->x86_model >= 30 && c->x86_model <= 0x5f) >> DYM 0x30 here? > > 0x30, although it turns out that some of the mobile Zen2 CPUs exceed > 0x60 in terms of model number. > > As Zen3 changes the family number to 0x19, I'd just drop the upper bound. Minor note: Even if it didn't, the !cpu_has_nscb would also be enough to avoid the probing there. >> Or 0x1e? In any event 0x5f should be accompanied by >> another hex constant. And it would also help if in the description >> you said where these bounds > > From talking to people at AMD. > >> as well as ... >> >>> --- a/xen/arch/x86/cpu/hygon.c >>> +++ b/xen/arch/x86/cpu/hygon.c >>> @@ -34,6 +34,11 @@ static void init_hygon(struct cpuinfo_x86 *c) >>> >>> amd_init_lfence(c); >>> >>> + /* Probe for NSCB on Zen2 CPUs when not virtualised */ >>> + if (!cpu_has_hypervisor && !cpu_has_nscb && c == &boot_cpu_data && >>> + c->x86 == 0x18 && c->x86_model >= 4) >> ... this one come from. > > From talking to people at Hygon. Fair enough, but imo this wants mentioning in the description. Jan From xen-devel-bounces@lists.xenproject.org Tue Sep 07 06:14:24 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 06:14:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180400.327044 (Exim 4.92) (envelope-from ) id 1mNUND-00032k-A9; Tue, 07 Sep 2021 06:14:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180400.327044; Tue, 07 Sep 2021 06:14:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNUND-00032d-6z; Tue, 07 Sep 2021 06:14:23 +0000 Received: by outflank-mailman (input) for mailman id 180400; Tue, 07 Sep 2021 06:14:21 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNUNB-00032X-6u for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 06:14:21 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 7ff516a7-4b3d-4c57-8e0a-ffd3c287b952; Tue, 07 Sep 2021 06:14:20 +0000 (UTC) Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-he1eur02lp2051.outbound.protection.outlook.com [104.47.5.51]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-31-V1VvL1hMNVeMrtjdYwZhcw-1; Tue, 07 Sep 2021 08:14:18 +0200 Received: from AM0PR04MB5587.eurprd04.prod.outlook.com (2603:10a6:208:125::12) by AM9PR04MB7569.eurprd04.prod.outlook.com (2603:10a6:20b:2d8::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.17; Tue, 7 Sep 2021 06:14:16 +0000 Received: from AM0PR04MB5587.eurprd04.prod.outlook.com ([fe80::ac:a0be:c26c:908b]) by AM0PR04MB5587.eurprd04.prod.outlook.com ([fe80::ac:a0be:c26c:908b%5]) with mapi id 15.20.4478.026; Tue, 7 Sep 2021 06:14:16 +0000 Received: from [10.156.60.236] (37.24.206.209) by PR3P189CA0023.EURP189.PROD.OUTLOOK.COM (2603:10a6:102:52::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.20 via Frontend Transport; Tue, 7 Sep 2021 06:14:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7ff516a7-4b3d-4c57-8e0a-ffd3c287b952 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1630995259; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lE+pv+2t6gwcK6U4MSVYO6DoEvX4rlBIfkZVESIv7zc=; b=URLymQr+qMErGR58zs0ydrkxAtuFJ6oWB28kCFNV2IM0Jvm26T5G/ZkxOsc+snaOb/a0Vg R2GE3M6htWSJ6BTZJDIgNkxcHylhYSXGJG3Dqa2Iver6tYhw11fM3wc2lt4Sq7tejk/iPU CWF2URwmXNRji8UPhy3j+ZW1GZ4fKKA= X-MC-Unique: V1VvL1hMNVeMrtjdYwZhcw-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hr3DKHK7A9LutM5P9cRMQIn50PlzDY+ZN17mvsB1JAqyMRB1K3u90/sLb4BAVYUrq/cZjr2GCSKjGh4/B62LseCj6HHJ9TCYdjXjSjbFoZfW50d5uzJtbl8qRp2azfeP5zEv/mHSMF0Cfxl8IFhJcg32O7PdFRTsbmB+xrzSocsEvVFp7naLprZDYRVVhGR4G4NXlClc+bIjjSmU4932se8LXS/oGvp4K/x6COdrb8j9wk3663uVNoTrOzz9gSjmP3PGaWRZIsUR8vukObQUk/sDBWrNaQmdrnmN9TJ6Tx/VIA530eBxaTMSm+5iFtrId14CwxRWQs5frSUWs8JufA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=lE+pv+2t6gwcK6U4MSVYO6DoEvX4rlBIfkZVESIv7zc=; b=TPd7QSzH3Xrhv5V4PAzNTasoHSu8826fko0zq4zmw8nIMTcMlAyFMLkTK356baQx6KgrDveeLh4Ril1q2FTeUEJJX5sQYJXRsV+N/4dtXjhxt1pf0U8LYjMpqMT2+djFN5P7tcUT2vVDszXiPIYFf8wKx0UTvo4ReH0KGYLIK+9T11f13AUXzIzB3FQrjaBnLSmPR2ANiyrqjBiEwHrlJR6tL9HqEriQp2x+l7PxQEqFXuiHLjPNLcb8vP+Aoh8AGyLuTMi6QXbfQHtSIkKHtSKDdX+bVrLW8PTskg82ALf+d/tR8Ipf/YSm6iVSLXKO9eo9jP0y2AkyalLgcU6NSA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com; Subject: Re: [XEN PATCH v7 05/51] x86/mm: avoid building multiple .o from a single .c file To: Anthony PERARD Cc: Andrew Cooper , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Tim Deegan , xen-devel@lists.xenproject.org References: <20210824105038.1257926-1-anthony.perard@citrix.com> <20210824105038.1257926-6-anthony.perard@citrix.com> From: Jan Beulich Message-ID: Date: Tue, 7 Sep 2021 08:14:14 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: <20210824105038.1257926-6-anthony.perard@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PR3P189CA0023.EURP189.PROD.OUTLOOK.COM (2603:10a6:102:52::28) To AM0PR04MB5587.eurprd04.prod.outlook.com (2603:10a6:208:125::12) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 85cb63a9-dcdc-418c-f445-08d971c6b876 X-MS-TrafficTypeDiagnostic: AM9PR04MB7569: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7sAxio4bnaBRVvzEcBzNpwkR1auwlW/FZwG/PTFPuyHEC0BYmHbbntGwyh16slzFhEl0MuZ2z/68Mhyx+3VPUoRHvEUJOE0EdxGWtfW1McYnLQu+qPvkjLfORM9BKPfLOBMinTSmXX7Qf6wqt5wwNC1UWJn0imjmRFdxkGXyujX9apHGzx+qoZ238OT0suIMze8+pKyfDa9zaxW1fAVqTVXuzM8QdsByuFkAeDxJnjoslnc5YrVtpCLqhmFVoB3WWtJzepYJyWo/yA7v9ZbYxWC6euSU9BsNkSmPJco0RePG0ogv94Ar3CDuoFV/mBgu0DENm5S1F0tRn8XugiMO5goiQt4xVhcBhuwmlx5y8+awCoFtiKt3i2bC7S0oYc2vbfeDGP7J8drm6DCDswZ3mbnwslUtnH+vKCIBQweUcvpmh+rVL3FADM49tzaY40aVBUYEXJw6vS/77yVyBQiULjtALQFeIcl9nedY0ZzFa2ZEWJtbcR27s3ha0oA3WR1WlzgZgzYJhIoO3QACmMr13Mq/wN6CaEIRDW+r35Kih52INx0377E1IpejQf50qvkOSUt85vYDJP/AaK8hfP/OLJRkC0lDGRR5IUkvk3nkCVICr9py3n78JbwggtjXIaPvDR9op/fBTszu0RHK54IP2zYBmz1pTlB150JWRtXtTFIRED9Rw8CigV5l4+NKO0ksfBifSazPP3b8jeO4rrWq3NbYPRry6XZLB+VQOzppbYVFxlkLnhZwz0gaXtpWZDCaIorpTJSDGY2G8h2tkddXCg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR04MB5587.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(136003)(346002)(396003)(376002)(366004)(39860400002)(4326008)(2906002)(8676002)(66946007)(66556008)(2616005)(5660300002)(186003)(66476007)(956004)(6486002)(53546011)(31686004)(8936002)(26005)(36756003)(38100700002)(86362001)(316002)(31696002)(16576012)(54906003)(7416002)(83380400001)(478600001)(6916009)(142923001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MFNNbDBFSThZZ08yeFNKT3RwaWpYVUkvSGdZWmoySFg1ZnRPU0J6ZVFuL1BS?= =?utf-8?B?ZUVDYjU3Nmo0enFnZFNkSUhyZjFpcnFKeTNMRHV1dnJFQ0Y5YlhUUStsTkhX?= =?utf-8?B?b1JVNnFPNHRxOW8rbDZ6bVVab2FKSmFOTSsvTG1LQThJTjUrTkFzZHJLYlU3?= =?utf-8?B?Vk1VUGpSZjRNdGlZdGNoOFRhdHErLy9PeFNqdGgyQmtPa096dHhXNWw1K1Y0?= =?utf-8?B?Z3oyc3A4eksydnMwNXQ2YkUvMk1PcEFMMG1HSjZzNTJFOHh2M2FoelhpdkEr?= =?utf-8?B?MkhMR1o2azFOdm1Ma3Nrb2hVUlRWQ0J2Q2V0VjMwSmR0T3NQcEJ4ZHQrbFpl?= =?utf-8?B?SXBzMUI2eEE2S1JHWVlHT2NoWkZFTXY5Zm9DY1BoSXRaV25Nc2VlamlvcFBu?= =?utf-8?B?QldMbmw3QnkrREVXT3E3Z0hLNUQ5clM5c3BtNTRHTVYwZVF0b3hzU2dPbHAw?= =?utf-8?B?RFRxK3g5dFpTQ21XZDd3OUlMaUhYdUZ4bHl4U2RlUjNUYmRsODR2NmNSdHE3?= =?utf-8?B?SUhBVGp3TE1zVVI4TVp0OEloYlJtUGJDYWVhVk0wcjhjOVJmWlJvTkdIK2Ni?= =?utf-8?B?eWxFdytVQmU0U05RbjgzYlpFSUpMT0RSZVBPdG5nTGxWOWVMQUp2OFdSSTVW?= =?utf-8?B?ZGtlY0ZES0lpdGRxc0V0MHllQWVBK0RYdXZ5MWswUi9nTXNuTFFSZzh3cGxU?= =?utf-8?B?MUZOdzFFcGpjRzJMS0ZTOXN5WlR3UEUrOWpZTU03US9sUTZ0ZFNlQTJTc3R5?= =?utf-8?B?SEJKY21tRkRLSmxOdWsxaTVFR3JjV0xsMnZRQkZkd0JrTzhMcWo3dnZSWFNk?= =?utf-8?B?RTBBWlgxdFJpbjRISkJPeGVPMzdnaE8zWE11MzFQWnl1SndHUUZQWTRSWWI3?= =?utf-8?B?MnFXTzhzM3RMVDZsQUlDSHNaTjZ0TzF0Sm15YVRycTd4Q2M2S1V1U3BzZUtl?= =?utf-8?B?SWxjN1ZPZk9hZ0RCODZLMlVHelhobm5UU1ZVdFBLRUZiVXE1WGpxQ3Axdytj?= =?utf-8?B?T0NSZHFtRDMzSEhtV09MTWlMSGFiMHdvaDVWMTBnRXNMWDVsb1FDMS8xMzcr?= =?utf-8?B?aWtnSFhDZ3NFVjZNaW45SUl4M1dhdndZQ1kzM3NPZkJBdFE0N0tJSnZMbEMw?= =?utf-8?B?R29YU01VMW1RaDJUNCt4ZGJtUi84WUtMNGY5a1FmYXM5elBtUGVCbS9qWWtt?= =?utf-8?B?dHJVRm1IdmdnZWlUYm5SSm5mck5Kc2dEcmkrMHUyVG5ZSTlJcTQ2Tmp2RnRy?= =?utf-8?B?SWxKNm95Nm5rVUpadXpBNE9xTTBKTDNiMTU3d3NiQVhOSkI4ald6TXVlMEhY?= =?utf-8?B?cFIzUFFyMWVtZ3JEMGh2ekNTZXhJZ0xjcGFUWkl4dW84WUNSd0tHbC9sUkdF?= =?utf-8?B?Qit0OWdWcG1yN20yc2VhYUNjVzdUaVRjbGJxbFpCYmg2am5sNEViS2lkUkhF?= =?utf-8?B?cG1QQlV0Uk5wd3FrVG5CSi91dS83NDloY2NObFBiRzJsdkpxTWxOcWlTcVNu?= =?utf-8?B?YWZEbmdBUUYzVzY0MjA4bWtiQU9XVDc5b3IwTytuL2xreWxsVjVqNDZJWEg0?= =?utf-8?B?bXp4dzdQYTA5QlNnMGhrRFJxMG9UQnE5dlBPa21KYzR5S2JsRFhJZ25qbnNn?= =?utf-8?B?RVYvOG5PZkdrNGJOdWxFWUcybWI2Vll1bmF5MDZwM3UyNlhIMG1OckprREpa?= =?utf-8?B?dHl2Uk8vVzFFem1LWTI1VEIyTHV2WGN2WlRxZnRrOFB4Y3hDRDRTckN4MkI4?= =?utf-8?Q?Bugx0rXrTL2ZYJYSJkCBweGFz/sLNdBooApVy3w?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 85cb63a9-dcdc-418c-f445-08d971c6b876 X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB5587.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2021 06:14:16.2882 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: sJCqVni4EaS7DeOD/h21VrvC8Idlkc9It+rTXHSWS2ckgNKIzLl1HvUdBe8BYfZyuLoxTkKiZwm7sqzkXnBOWQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB7569 On 24.08.2021 12:49, Anthony PERARD wrote: > This replace the use of a single .c file use for multiple .o file by > creating multiple .c file including the first one. > > There's quite a few issues with trying to build more than one object > file from a single source file: there's is a duplication of the make > rules to generate those targets; there is an additional ".file" symbol > added in order to differentiate between the object files; and the > tools/symbols have an heuristic to try to pick up the right ".file". > > This patch adds new .c source file which avoid the need to add a > second ".file" symbol and thus avoid the need to deal with those > issues. > > Also remove __OBJECT_FILE__ from $(CC) command line as it isn't used > anywhere anymore. And remove the macro "build-intermediate" since the > generic rules for single targets can be used. > > And rename the objects in mm/hap/ to remove the extra "level". > > Signed-off-by: Anthony PERARD > Reviewed-by: Jan Beulich Hmm, when replying to 00/51 I didn't recall I gave an R-b for this one already. I'd like to restrict it some: It should be taken to stand for the technical correctness of the change. Nevertheless I'm not really happy with the introduction of the various tiny source files. I've meanwhile been wondering: Can't these be generated (in the build tree, as soon as that's possible to be separate) rather than getting put in the repo? Jan From xen-devel-bounces@lists.xenproject.org Tue Sep 07 06:20:34 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 06:20:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180406.327055 (Exim 4.92) (envelope-from ) id 1mNUT8-0004Qd-0p; Tue, 07 Sep 2021 06:20:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180406.327055; Tue, 07 Sep 2021 06:20:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNUT7-0004QW-U3; Tue, 07 Sep 2021 06:20:29 +0000 Received: by outflank-mailman (input) for mailman id 180406; Tue, 07 Sep 2021 06:20:28 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNUT6-0004QQ-Qo for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 06:20:28 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id b10da5b4-0fa3-11ec-b0d5-12813bfff9fa; Tue, 07 Sep 2021 06:20:27 +0000 (UTC) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04lp2056.outbound.protection.outlook.com [104.47.13.56]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-30-uqOFY_bUNVGWqceMPrDZlQ-1; Tue, 07 Sep 2021 08:20:25 +0200 Received: from AM0PR04MB5587.eurprd04.prod.outlook.com (2603:10a6:208:125::12) by AM8PR04MB8002.eurprd04.prod.outlook.com (2603:10a6:20b:247::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.22; Tue, 7 Sep 2021 06:20:23 +0000 Received: from AM0PR04MB5587.eurprd04.prod.outlook.com ([fe80::ac:a0be:c26c:908b]) by AM0PR04MB5587.eurprd04.prod.outlook.com ([fe80::ac:a0be:c26c:908b%5]) with mapi id 15.20.4478.026; Tue, 7 Sep 2021 06:20:23 +0000 Received: from [10.156.60.236] (37.24.206.209) by FR0P281CA0082.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1e::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.6 via Frontend Transport; Tue, 7 Sep 2021 06:20:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b10da5b4-0fa3-11ec-b0d5-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1630995626; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TSFfFqofenQbMlBfkKFanf9ysGnmn1I9sU3PxpTZ6YM=; b=SIszgxswv6zVjENgiiLb2JiRBX8Hr8gEME5U+xuIbY1bSgXHrnBBiLGfn9PersrzGjS0oz 1XjPeOR9UZr+x/0KkBSWQj1/RQZX4MzEL5z7SKuA5LQYFrXuSgz0TdNIQbCKFKVEqAPS/u hsbQJjzieW0CRPxL6vVBstqxPw6cThs= X-MC-Unique: uqOFY_bUNVGWqceMPrDZlQ-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PTpj4yYzUJYGIZnUY8JOmKpSLkb4CFZSAEteaYSVJJfw5W6a87NlYpB+5CKP9eeng++dJYux5BROo6iXNZv249NLbee233dRCsorY1sTYpc6+4x6sDL2QtAhjYQMdueuL6UvU9Q/vlsDHvOXs9bECVIykE2n4dzO6sDGCdBEoDE1Mp5DqqotERzHz49L5E4BYk1OFI5aK1BFaEY9r4o7RU8wlcnq/ruF7MvC9eUc0C4DXLb9pkVgqHOlJbK0yxqAT8hNNYcFXpvNjoFXK8IBjD1krcLcynidS2BLGAeoago+fkGhyW6G+0LYjsLOuHXzrZtfQFutFjDAFsRYf/J1Iw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=TSFfFqofenQbMlBfkKFanf9ysGnmn1I9sU3PxpTZ6YM=; b=DoZNcrW0AKbLpwpZhBnfeScXCMMbfylW0e0JiTecqpKji29aL0eNqiTp7Gj6vdomVUfPnsGZaSBLMqTB7aY7bAwzI54WQUxRmTi6x+WHEjbOA2SIPTobapef5q4MCbVJfzbNg6KtDKvYuNpb+X7+E3DoYA/rNKZ/aw4J0JgIzdidiEMoo2hegY+sis44o34HEhyys/6SF81oJNfyhXwuSK9b0uDJ8pxHHy2AabrOHOa/tTUtscsqMduUhEac/YmpV2tsz9SB7aVMYP7VGCmgHIt2glMcaQv5ZHqP9DOG6j08/bphzAGExP6cG3j5qfj9c6xJoXIStTNfocIHyahIdw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com; Subject: Re: [XEN PATCH v7 00/51] xen: Build system improvements, now with out-of-tree build! To: Anthony PERARD Cc: xen-devel@lists.xenproject.org References: <20210824105038.1257926-1-anthony.perard@citrix.com> From: Jan Beulich Message-ID: Date: Tue, 7 Sep 2021 08:20:21 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0082.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1e::21) To AM0PR04MB5587.eurprd04.prod.outlook.com (2603:10a6:208:125::12) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0e6a8f8a-ff46-406d-3fdb-08d971c79337 X-MS-TrafficTypeDiagnostic: AM8PR04MB8002: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2449; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8nkkzatVohMxafv5zc5UYs4lvChbT6NKCleWNeENzySayD0QTr1glm6ts291ZDOVc6OYmz12HPl6hoBFpzpipjgslU+tPqfl4fPFOn+oNQLmpmSNUDKAMmv6BiPYKB0d9jjm1k27zqu/hRRhQSZj6vdxZSaJbuyFFwmLFM+0WB5JiKBj+umJmr9+bMAHDsIEbGAIYo+GM3/+y4FHnSqfqYiGZhginphavw2GH/kY0fIPPv7f1TPNsTfmED7eU8gjobKM7qIx9KVz5X6/pkSIgn9+FiU2IimfhRXs7Ob3aXRSqL6ku/7WH9pLBsBqHzPkfOTvs13Yyyub9YmsnLZ6U354dUwOzyftZyFsRdE4EQwb4pzSmBf+Mm2GxtWXVE8Kb0E13NTQQn0TYESNVvnwjKZnP42cuGOL9wmK/RVSZ/lQtDEmRfc/IFhKo9cGFBgZe8snZNUGN2XsbE912I3OBU9USb8ci25cALr7ENzkIcOiYO5douZNzu/lu4loyDTtihhi46BEqQxrTWobAtrL0yd88mOfW2obb5qzLNb/VZP0AZ9ghvT5PWwyM4XFgrhPHvRprgKMJpzuJQ2S/oR2+ogURaYLv16TXOEGvQUkkQIpwtx5iKcInwvaWqXf/Pa9lNyN5dQSckzKRshTOjo0GTf9kr3dBINruJIp3vLlWl8RbA7Vq1QS2x7NS7n6eurqdHvk2hjcVHP7Bmn+On9svI1CK2MFWPxaXaZW3TLWvCk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR04MB5587.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(396003)(136003)(39860400002)(376002)(366004)(346002)(316002)(4326008)(83380400001)(16576012)(478600001)(5660300002)(6916009)(26005)(66476007)(66556008)(53546011)(66946007)(186003)(31696002)(38100700002)(86362001)(6486002)(2616005)(956004)(36756003)(8936002)(2906002)(31686004)(8676002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dHNBOFRQVGVUd2Vlc2tPT0JtT29HYjF4U0N4MVlVNlBFbmJxRTBOTDltZFE0?= =?utf-8?B?c1JUMmZENy94ZHllK0VnUnM1L0wzdXVFd21CUFhJSlprK3ppUEVTejZNeDVY?= =?utf-8?B?Q091bGgwRkdKSmh5cEdwUVhUMUJqTXpjOUxhNUJGeWJKbGJaNHZFY2IreTRR?= =?utf-8?B?WEhoV1grUXFBUVhVeG10MVlDQjYyU3QxNGQ1ODQ0U2hrVS9lWVRidURoWlJ4?= =?utf-8?B?dkJpS0NjU1R0K0luaHpBbmlFRUkyVjU1Ly9HMjlkZXR5djg5RWtaKzQ1ZGpJ?= =?utf-8?B?UGRYdDRvbEZFK2lTOVF1dnFoZWNXbmk1TkhibEZtN2dzWHF2cEkrRjBaWWIx?= =?utf-8?B?c2JkbU8reXpQZytnWEozU2Q2UEVHVWFBWEMzZEdESm5yRVFKbGh1QmZQYm1v?= =?utf-8?B?VXJzZlJGN09tblVzMHdvd1lqRWRucWpza3BLaHIxRmMvdW1SVU0zYjV6SnZE?= =?utf-8?B?VjF1bk1lL0ZDaUEyL1ZlZExYN1VIU0lFNlZ6UTJFbTZMSWtaRmFpNGhNcnpG?= =?utf-8?B?cEpvUW52MTVYMERBM3Q4NFdUVjZzanp4bDNSWlF4QS9SMUxOWFZ4SVROcHpm?= =?utf-8?B?cEQvMDlSZ0xMYkIyMWVwTTh0RENLTkI2KzQ4QUwyUkNFVDJ4YzN6QlZCVEw4?= =?utf-8?B?aFF0cHlhOEdRNkNyWGQwUjFrRFY4S1FxRUdOVVo3ZFFwanNhMEJpaTR1Sjc2?= =?utf-8?B?d2k0QTlJTVdVQUJrMGJHRkE4TWtwSlIvS211aGRvbDBFdkQ2YW5RcHZNV1o4?= =?utf-8?B?QTcveWtVb3RQaVlSUmRBYm5ZN253T2MzTVg1L2VpTGRjdVE2b3FQR3V6T0FC?= =?utf-8?B?TzhPQXJrT3lzVDgxd0tSMW04b1FlNmd5MGl6NEdzRmdIOVVWRzlqTGhUUFRu?= =?utf-8?B?S3l3THRlOGd6ZER4RUREOStiL1F3VWltSnlmcEJzNVRlUTJGQ3UwSGxRL09L?= =?utf-8?B?S2pxdGtFU0Q1bThaNGVQVXVXVGRGd2ZkOGdGSnJiU2M2VWwrdTRMT28zSkUv?= =?utf-8?B?aEJXWXRIZXpOSVJ1SDZha0cyM3RGdk9PQk93M3FIMVRETEc0a0V3bVptOHNm?= =?utf-8?B?MmdoUFYwV0M1ZWpnQ0hYZ1Y5RkhwR0ZHcVdLN1BFUzJBa3A4bXZPak1mc2dv?= =?utf-8?B?OWo4OTJuRTIrSTAvYm8vMk1vTUF0OHAwaDk5d29EQk9kanpVWWFyT0xJMlNj?= =?utf-8?B?d2VLTE92aSsxZlY4UDJjV1BVRGh0dWtVaWY5bXVJYTlZbXcyeHJlREtFUjZ0?= =?utf-8?B?WnB3Z3hyTy9UREp1VDRCNGdSUkpwdDhiYjl6ejdpZU9MMUdOY3Npck5VaGRu?= =?utf-8?B?cmlLWDNJcllBZUJ1SFVId296NU5pS2ZaYUhINTBwdWc2UzRFc2R4K0xaMWJr?= =?utf-8?B?aGRvblkrcHE3c0lLVXlwaDZDWmRQUzBTUW1ya2hjR0dQZFRwMUhpZis0VmY5?= =?utf-8?B?YXBHbHhmZGNYM2tvY3hXdzJRV0lnNHRuL1lyamxTYTg4cEp3MlVFZWF5bmZl?= =?utf-8?B?T2NMdFVPYTdxd0NJLzg5blpuYUx3blUvcnBSTVBZTlFsOEcvbVpmV2RzdG8r?= =?utf-8?B?TkF5ZmdKbGx4TUpZeno2OVFzaHFnWXZiMzdxbS9OU0xWQTZZbmdETzM2Ukd0?= =?utf-8?B?WXcrRGxaRTlkd09ZS3hkOXg2ZXRXTnhWN01ZMmpPdmJYVFVKRWkwWlYyMXd6?= =?utf-8?B?OGNWZ0RCcGtmM2pUSmhLYk1Jc3NvSkFrekk3YjVLSCtiUzZIb3ZkQk5MQ1ow?= =?utf-8?Q?v/Schfsc8f4Ejl3CFoj0d2lu4X55njg1puBQZBb?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0e6a8f8a-ff46-406d-3fdb-08d971c79337 X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB5587.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2021 06:20:23.3177 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: WkCqiiGJ2wYU4lIOUUaqZqN0svwuA1DbSbT6kSOC/As43UeWDtpSwaTFSA6DQ2MV5H/ug1eVwvsNm65C5Jo6wA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB8002 On 06.09.2021 18:13, Anthony PERARD wrote: > I hope this is useful: > > On Tue, Aug 24, 2021 at 11:49:47AM +0100, Anthony PERARD wrote: >> Anthony PERARD (51): >> build: introduce cpp_flags macro >> build: use if_changed on built_in.o >> build: use if_changed_rules with %.o:%.c targets > > all 3 ready to commit > >> build: factorise generation of the linker scripts > > may need a ack from arm maintainers, does it? Otherwise, ready. Ah yes. Will need to wait. Which is the first place pointing out that you answer my question only partly: Does "ready to commit" include "independent of earlier patches in this series"? Same e.g. ... >> x86/mm: avoid building multiple .o from a single .c file >> build,include: rework compat-build-source.py >> build,include: rework compat-build-header.py >> build: fix clean targets when subdir-y is used >> build: use subdir-y in test/Makefile > > all 5 ready to commit ... here: In my reply to this cover letter I did specifically that I've skipped patch 5. As said in a reply just sent there, when writing that I didn't realize I had already given R-b for it. I intend to put in some of this series in a couple of minutes; I'll try to judge what is okay to commit independent of earlier skipped patches. Thanks for the summary nevertheless, Jan >> build,arm: move LDFLAGS change to arch.mk > need edit commit description, but otherwise ready > not needed before [PATCH 21/51] build: set ALL_OBJS to main Makefile; move prelink.o to main Makefile > >> build: move make option changes check earlier >> build: avoid building arm/arm/*/head.o twice > both ready > > So up to here (12/51) all patch seems to be ready to commit. > >> build: convert binfile use to if_changed >> xen: move include/asm-* to arch/*/include/asm > both need a ack > >> build,riscv: tell the build system about riscv64/head.S > patch ready > but depends on "[PATCH 14/51] xen: move include/asm-* to arch/*/include/asm" > for the rune written in the commit message to work. > > >> build: generate "include/xen/compile.h" with if_changed >> build: set XEN_BUILD_EFI earlier >> build: fix $(TARGET).efi creation in arch/arm > patches needs review > >> build: fix arch/x86/note.o rule > ready, standalone > > > The rest of the series needs review. > > Cheers, > From xen-devel-bounces@lists.xenproject.org Tue Sep 07 06:27:40 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 06:27:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180413.327066 (Exim 4.92) (envelope-from ) id 1mNUZy-0005Sh-TE; Tue, 07 Sep 2021 06:27:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180413.327066; Tue, 07 Sep 2021 06:27:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNUZy-0005Sa-PX; Tue, 07 Sep 2021 06:27:34 +0000 Received: by outflank-mailman (input) for mailman id 180413; Tue, 07 Sep 2021 06:27:33 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNUZx-0005SU-8J for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 06:27:33 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id ae3d6b16-0fa4-11ec-b0d6-12813bfff9fa; Tue, 07 Sep 2021 06:27:32 +0000 (UTC) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05lp2110.outbound.protection.outlook.com [104.47.18.110]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-24-FrpMNNnVMK6I20FejC95iQ-1; Tue, 07 Sep 2021 08:27:30 +0200 Received: from AM0PR04MB5587.eurprd04.prod.outlook.com (2603:10a6:208:125::12) by AM9PR04MB7634.eurprd04.prod.outlook.com (2603:10a6:20b:2d5::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.21; Tue, 7 Sep 2021 06:27:29 +0000 Received: from AM0PR04MB5587.eurprd04.prod.outlook.com ([fe80::ac:a0be:c26c:908b]) by AM0PR04MB5587.eurprd04.prod.outlook.com ([fe80::ac:a0be:c26c:908b%5]) with mapi id 15.20.4478.026; Tue, 7 Sep 2021 06:27:29 +0000 Received: from [10.156.60.236] (37.24.206.209) by FR3P281CA0064.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4b::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.6 via Frontend Transport; Tue, 7 Sep 2021 06:27:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ae3d6b16-0fa4-11ec-b0d6-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1630996051; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4X413M352Bz+g6WOu/MmDm2tizrfnb8E3vuzxpYuBgc=; b=BmMXInTDOy5p81/giVQd3TednnXNdaBxj/99my+eCh3W0eB4Xtasu+yO4FXK65j5MuvE2o SdQuRrrvebU8yCPhgcub9RiSa83HkECG9AORPHmeBucH/zNVsqZJ4m4BhHg3hhN3EJP/65 x2CPZudmWVcsmEUMKKhwqYnXHqUH1AE= X-MC-Unique: FrpMNNnVMK6I20FejC95iQ-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JeeNiYH+ScbJodh/gqcrJpJbzdLR1nzFOS6uj5bNaf1TFAyrG7wGfjZuLzMAd8onABRPTLhZrny/En5D4v08IKWJLqNTTexCcIpzXtHd7aHfTVDYRLO+kxSpYHiMqbQpnoIyPsGey5t7mwMgCOCoonxfXrmOgBB0kXlHb+Pe0Jbl5A5E6kAnqrHhrIqSnc4aSp63EJ3jcTf4mHiPdrrx2g8Vb1Au7hkihJzWhZu0RK9k+xFiTJcnFmi3LEDC+7FSJfcPV3JYjhIjQJ6ELWY8zEYQW3Xv341H/TeyzIVXXwmUUcUoB36KEU+BTEixXpogqn5IjoUEU8SKD0dL0ukvlg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=oLQFaWi4QB5p7y9edaTmQxOxvVOecW8XZ9bI4P+cP6Q=; b=YVxfm+fb5paYsyeS1VBZUWKjRkDDM4pjVW0Pnz0G8PFshgrr6KF6CExIS/w8NuGEaH3yhsp4ty1oTJifc75RhQSJ100727l5qfv4B4vGH0iv89kuy39r4ByvkEu3OHjTGXtixqF3XvZaV5PkzpdY5Qy199nTxVW6XHn6fKgrYthW7898NC/7VOZESqXls6K9VG5gN3Z8yZgyxZKP6xuny4T8i89jntqDyl96ejartMxiIV58FJBBk8rfzpgT4vK/IZRECufg0pXe6p8MaZXNls8hky3KqWP/19RPFihdE1T8T460XmMTMtc5Fe6XKABO6XYFBQKupLwlflXsTzOCJQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com; Subject: Re: [PATCH 2/4] x86/P2M: relax guarding of MMIO entries To: Andrew Cooper CC: Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , "xen-devel@lists.xenproject.org" References: <93ecc397-1293-69b1-e70d-3c5f9317229a@suse.com> <7f56c625-eee6-31c4-2d6f-bd7334867d83@citrix.com> <5d69d4c0-7a04-c3da-f971-616363c6d63d@suse.com> <62cb78c9-f4fd-76e7-225d-bc575f10850f@citrix.com> <818cc08e-8372-35c4-935f-86a87cceec75@suse.com> From: Jan Beulich Message-ID: <8a45ba41-e659-c472-dbd0-56bbe92bb5c0@suse.com> Date: Tue, 7 Sep 2021 08:27:27 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: FR3P281CA0064.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4b::12) To AM0PR04MB5587.eurprd04.prod.outlook.com (2603:10a6:208:125::12) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 222932d7-0b7e-4832-27c2-08d971c89116 X-MS-TrafficTypeDiagnostic: AM9PR04MB7634: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5C5wzyRBWgnLYYb/a7R1EJ2jPYH6HVDgTNTHOKgRmrJI9jcv7GI8y/FzSAMxYmA1BoWxdz9UgOH8qJtOLtrp3Ogou31ZeaYfE3Ew5o76UhBGrZ1aOhJ/DvwW8t6MwpW57m2YK9ZLq4IKG1R+up6VgRVmD01+18hqRNkdpa4YA5psB/MdlbBSHRp6+YrbMmaFxQpX7YWOmE+JuRKkwHTtE2KUmJ9pTc+XrGJQjQLdinuAir92nWzit2e8ik9YbPnh0QCLVqYpUn76MGGYQ+9hQAfejC0dA3S1PEUb76WyU9KMiWqLNvHW0LYRxtJYtfdXoQqc1Sr/2945rzgnSL6tQd6ecKVdI3o5jaq+97DEH1UIOFKqaJxATSmjaJYUL7k0snySt9hgHPx7+zlgxXiMnzhhzFrk8tRGpyGQqxuZSAQGA/LoZgjjkoOd9ICXttVqT8NZRZ0nVUYdEKM79OsMq9NNhnFpsu2YIHdPkm6wPPcCVsGWFV3/WqZIMM1hpYdtN2yxcLE+Mnj0BlOhAw25mMutPKbfbTaIIk7FhzGCZ/JXhjMLxrXUIFAD3qiRCv0+wt3oHPvaj5ZaK1rVcztULKi0w22MSrlfIn3vz25Qhw04yQHJpxlPoXj9B40iAu5SgZVx2lLxGWsAN3JHrCKmU4ZGJDykS6hhtCZqy1OKFRQXpis7lSwhi4eGGAGRwkGLGOYxyDnGvjA984wHiwzNoxoxG6bBIGWU3YQ9+9uCeOA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR04MB5587.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(136003)(39860400002)(376002)(396003)(346002)(2616005)(5660300002)(478600001)(66476007)(38100700002)(8676002)(83380400001)(8936002)(31686004)(956004)(6486002)(6916009)(53546011)(26005)(2906002)(316002)(31696002)(4326008)(16576012)(54906003)(36756003)(186003)(66946007)(86362001)(66556008)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?OxAcRGvYer51QZlj8wC/p8tFLFQAqRGQxoJYLjFj1aAPHVNoy0IV6hB911vt?= =?us-ascii?Q?LBSrF9NLqXb3kyZ7gZ0EhANdt28shbwMcnwEU0TFbDJXZOldA2Ww+XZ9JJNm?= =?us-ascii?Q?Y811A6cwA2vExlmULFs4Ln+C30YiSjSWpWpRTGNB5AIb0kEvDgsccx2rkpSl?= =?us-ascii?Q?6EpB+4XGYHnbcAUz2RLPuIKu1vVmzvdc316FYumSP6XaKvCW7OiRw6YK0UBo?= =?us-ascii?Q?Ol61t4UkwEl4GOkRrxJVWndPstnRoG5RaFKOs8/zx9lE7xe9uuRbJPbtkEx4?= =?us-ascii?Q?n3FTtGVr06sRnLU/ak9DGZHjCgbosCoT5KWGKbl0NpIP/ZE8n3CXMlj4eeex?= =?us-ascii?Q?fDEJcrebDfc8cGcK2RgDvMhJh/mH0sAa+N7DoA1PBx5CmjbR8jj1nXEkX8tA?= =?us-ascii?Q?d+MVKofXjH/W1yTZeuOK/9Xcy0tvJHlpbXpCUCSqgrZditPXgisfQ/PcjX18?= =?us-ascii?Q?KkQhcmBYwVZqRWhoHwJ0D9TMK4e1wE6837EiPt/dyYd3gIIBhFsiNPX4CtGy?= =?us-ascii?Q?hfhxH3wwBIb1lf7otxWKvfg5wVBrsWQM4eZqhAlbbAdeQB35wsXW8cl5ZdF6?= =?us-ascii?Q?wKsZu4xG7Puc9nWIXSVScjl9pRDBf9gW7ExTPtEkM3/s6gu29/0KdOVi5wqD?= =?us-ascii?Q?FS6/p/wweUakq14P1BDI5inEDD9cxC3VEyFHgsXbL/Z1CTwUGdGJPOPCA8Zr?= =?us-ascii?Q?EXf5RIBFGT0PY1f9vr2SYr5pA8E5K7cU57TxIRiUoOILABlgild0seH/fskS?= =?us-ascii?Q?zoiV3el4QT7dwNeB3mSE/oBTczmL4R8Hprj4iQrOobLXaQzmciDQeTnkGhwt?= =?us-ascii?Q?zRqoSQLLFxpS/MD8JzaIOIDEfQOBgRwQjPK2ECCnLNZ+f3bKXYUijItsD2pv?= =?us-ascii?Q?/DdgUYdN3rQ+n/ucd6ztMvarP3K9Xv66vp0M7OcjWR8qphA8jMbPLD/JqHy1?= =?us-ascii?Q?FqUqRr9YP/qYze5KextykAxw+SXZ3zZtcLTz7EswtvJsQjUrvCiCgfvV1uqo?= =?us-ascii?Q?AuIR747tNSvoqySOI3zN6nmYLV1fwHM4ullteZaTw9e+EoXub3k0lwjzmICk?= =?us-ascii?Q?LKwNLNq366DvLpOzwiOTCRDCdX2JTccXR6sARx1Zp1mJ6SkLp2uFZ25cjIxH?= =?us-ascii?Q?C8UTsBiCR6pV9CqzYqqDmZ4fCKr9so+xGoVuP6cwPREBy/+zYfMif5KGpt33?= =?us-ascii?Q?oeH9Up++lpw2en5I0bR7iQQtCLA2l3ngpQ0JRRI2Vn1Ee63M4eDF5jo8m+n8?= =?us-ascii?Q?cJQ4NZdtb/1NPU/P09XFpBxq0Qbk/VPVAaJ6mKNhhke3OU2r3Wk+du1GQCeg?= =?us-ascii?Q?L58Z3Cjx/dsotAPkVGd5mt35?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 222932d7-0b7e-4832-27c2-08d971c89116 X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB5587.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2021 06:27:29.2381 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +p2OT2AkhIzDgWeuNVG0v8g6e4TGNpq/hrt8hfNK5Qd2G3uOJbWei7JTwheOSvekvs0IITbZys+72oJxpJgIBw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB7634 On 06.09.2021 21:53, Andrew Cooper wrote: > On 01/09/2021 14:08, Jan Beulich wrote: >>>>> Restricting execute permissions is something unique to virt.=C2=A0 It= doesn't >>>>> exist in a non-virtualised system, as I and D side reads are >>>>> indistinguishable outside of the core. >>>>> >>>>> Furthermore, it is inexpressible on some systems/configurations. >>>>> >>>>> Introspection is the only technology which should be restricting exec= ute >>>>> permissions in the p2m, and only when it takes responsibility for >>>>> dealing with the fallout. >>>> IOW are you saying that the calls to set_identity_p2m_entry() >>>> (pre-dating XSA-378) were wrong to use p2m_access_rw? >>> Yes. >>> >>>> Because that's >>>> what's getting the way here. >>> On a real machine, you really can write some executable code into an >>> E820 reserved region and jump to it.=C2=A0 You can also execute code fr= om >>> real BARs is you happen to know that they are prefetchable (or you're a >>> glutton for UC reads...) >>> >>> And there is the WPBT ACPI table which exists specifically to let >>> firmware inject drivers/applications into a windows environment, and ma= y >>> come out of the SPI ROM in the first place. >>> >>> >>> Is it sensible to execute an E820 reserved region, or unmarked BAR?=C2= =A0 >>> Probably not. >>> >>> Should it work, because that's how real hardware behaves?=C2=A0 Absolut= ely. >>> >>> Any restrictions beyond that want handling by some kind of introspectio= n >>> agent which has a policy of what to do with legal-but-dodgy-looking act= ions. >> IOW you suggest we remove p2m_access_t parameters from various functions= , >> going with just default access? >=20 > p2m_access_t was very obviously a bodge when introduced, and I doubt it > would pass today's review standards. >=20 > It is definitely a mis-design, given its ill-specified and overlapping > semantics with respect to the p2m type. >=20 >> Of course, as pointed out in another >> reply, we'll need to split p2m_mmio_direct into multiple types then, at >> the very least to honor the potential r/o restriction of AMD IOMMU unity >> mapped regions. (FAOD all of this isn't a short term plan anyway, at lea= st >> afaic.) >=20 > I don't think that will be necessary. >=20 > IVMDs are almost non-existent, and given how many other areas of the AMD > IOMMU spec are totally unused, I wouldn't be surprised if r/o unity > mappings were in that category too.=C2=A0 There's no obvious usecase for = r/o, > as anything critical enough in the platform to have an IVMD in the first > place will also be non-trivial enough to require bidirectional > communication somehow. >=20 > The unity mapping only says "this device requires read-only access".=C2= =A0 It > doesn't say "this must be mapped read-only", and it is legitimate to map > a r/o unity mapping as r/w. Well, imo that's extending what "Write permission. 1b=3Dwriteable, 0b=3Dnot writeable" and "Read permission. 1b=3Dreadable, 0b=3Dnot readable" in the spec say. "Permission" to me doesn't mean what you say. Nevertheless I would perhaps not insist (as I've already made clear I don't see a strong need to support w/o mappings), if ... > If such a case actually exists, there's clearly one agent in the system > with r/w access into the r/o range, and mapping it r/w is equivalent to > the "IOMMU not enabled in the first place" case which is the default > case for most software for the past decade-and-a-bit. >=20 > In other words, I don't think the r/o unit maps on their own are a good > enough reasons to split the type.=C2=A0 If we gain other reasons then fin= e, > but this seems like chunk of complexity with no real users. ... there wasn't already a 2nd use for this: The IO-APIC mappings (see my respective pending patch). Jan From xen-devel-bounces@lists.xenproject.org Tue Sep 07 06:34:19 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 06:34:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180419.327076 (Exim 4.92) (envelope-from ) id 1mNUgR-00076e-Ip; Tue, 07 Sep 2021 06:34:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180419.327076; Tue, 07 Sep 2021 06:34:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNUgR-00076X-Fs; Tue, 07 Sep 2021 06:34:15 +0000 Received: by outflank-mailman (input) for mailman id 180419; Tue, 07 Sep 2021 06:34:14 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNUgQ-00076R-Ax for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 06:34:14 +0000 Received: from mx0b-0039f301.pphosted.com (unknown [148.163.137.242]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 14c46350-cb4d-48b5-8944-7fa3ee01311a; Tue, 07 Sep 2021 06:34:13 +0000 (UTC) Received: from pps.filterd (m0174682.ppops.net [127.0.0.1]) by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 1875gv9o008521; Tue, 7 Sep 2021 06:34:10 GMT Received: from eur04-he1-obe.outbound.protection.outlook.com (mail-he1eur04lp2053.outbound.protection.outlook.com [104.47.13.53]) by mx0b-0039f301.pphosted.com with ESMTP id 3aws4h13bn-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 07 Sep 2021 06:34:10 +0000 Received: from AM7PR03MB6325.eurprd03.prod.outlook.com (2603:10a6:20b:13c::18) by AM7PR03MB6548.eurprd03.prod.outlook.com (2603:10a6:20b:1c2::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19; Tue, 7 Sep 2021 06:34:05 +0000 Received: from AM7PR03MB6325.eurprd03.prod.outlook.com ([fe80::d9b7:c0ab:2c2f:5b44]) by AM7PR03MB6325.eurprd03.prod.outlook.com ([fe80::d9b7:c0ab:2c2f:5b44%3]) with mapi id 15.20.4478.025; Tue, 7 Sep 2021 06:34:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 14c46350-cb4d-48b5-8944-7fa3ee01311a ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Io9ggiQeyG7jx0BilvoNnv0Y5zon76kEnRVsj4ppbDCnWrfa+Plo9dSAeKFUXss+H4n/da4IfAqam5QJ9AMTfnBqJEivsX8dtTgRuNc8lQkNBpWOy27183ZZeU5sIeonDDx6jEyi+JgYb7wYQDw66yjuu/ia1Ezi3FNnVunE9DaEVbRa9SwT4XfC/0o6eT0G8GAkE3ESE2ZwwbhO7I64drCZ+Vm1oSA5k7pCBeJ6AiANZJF40VkAqnoJSd+cOhZgz47xSVotJN7xFhLe88sWX/BOKwwGTIPMcTN+QKyZW/yu5lZw0bi/xJwzmah5KELdO6nLESu+AKk+ecEjE/fTDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=OwCGYDqY51fg4A+y0BsNIv4jmEll0CQOVvaIhZYta9U=; b=Lk74jwz1fTs4WBc3ZDudkOkkHKyzaegLlR0dk/7xvuNzaZ7elTi7NJD4rhfHIUNi5tT1SIVVHuxpaTXHuqo7ibULEFB7bxihR5LD51cxGbcF1qH63rE6Qv72Sz2ce4+UXCI32UZNnEqelASe4yVWnpCj0EXXvZC7GN4blafQju8JC0gBC3NzeqTXZB1XMy/AIuwNTgeE0EzVElCoentvXnET0AcI32o6dS/LdiimDrFIGv5Hy2QNrLy2QgS7wPZD2GbtpZ9DWjellhaLZgn0/Sw5lTgVsSFLLuIaFP9hs4ilS+950bNAEL6fedar3ZT6mL2pBu9q9FME+t+9hE07EA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OwCGYDqY51fg4A+y0BsNIv4jmEll0CQOVvaIhZYta9U=; b=xOvwgJkHt0cV+OfD9dZVK8KGHoR6cPAbw1gomM/wPGMA0caYlY2lY9iZWrvurwxaTZ3duXdTKY7vwGtlRnXudaCc/yF2UDpjC0O9JVbKGp+616q+j0QzdhdPaEuRIRnNX1bPdZ04LSfEaErvlaDNkmhl6VGz2fA5ZvPaDH0bPLu126fS1bm+w4yFuGvfUt58lU+RA9Kzk/b6ckkGjiMhnm83QdzQS1jQD8IohTomEq3jNabnTNGTaTpLEAB2BvwTwpYiUsqNvcqKGlc+nGdbYg7quKIsE3gpua9OIKazfQDw9IcKAZJdaVxpeAz7btiahU44Nwl7ewYFWI2puAXGcw== From: Oleksandr Andrushchenko To: Julien Grall , Oleksandr Andrushchenko , "xen-devel@lists.xenproject.org" CC: "sstabellini@kernel.org" , Oleksandr Tyshchenko , Volodymyr Babchuk , Artem Mygaiev , "roger.pau@citrix.com" , Bertrand Marquis , Rahul Singh Subject: Re: [PATCH 11/11] xen/arm: Process pending vPCI map/unmap operations Thread-Topic: [PATCH 11/11] xen/arm: Process pending vPCI map/unmap operations Thread-Index: AQHXoJ51zxJWpxhHEEGXNqYYBqazw6uSBESAgASU4wCAAB15AIAABzeAgAALJQCAAANyAIAACPKAgAFOFwA= Date: Tue, 7 Sep 2021 06:34:05 +0000 Message-ID: <16d93740-1016-19b4-ca58-65a9dc1aadfc@epam.com> References: <20210903083347.131786-1-andr2000@gmail.com> <20210903083347.131786-12-andr2000@gmail.com> <7da7f759-eab0-5e97-e8e4-980db5db1e79@xen.org> <71e0a54f-da69-5712-f826-9c38eecfa244@epam.com> <9482457a-fae2-eb8e-79dc-b5d7bcf2fa0a@xen.org> In-Reply-To: <9482457a-fae2-eb8e-79dc-b5d7bcf2fa0a@xen.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=epam.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8c69a9c5-d084-4531-9f40-08d971c97d3a x-ms-traffictypediagnostic: AM7PR03MB6548: x-ms-exchange-transport-forked: True x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: vI3ioV4HyYVzpt9GBULiZUek3KzInzxGAGp8ytiHZXBetbFhTaXeJkWvzWNae2jSxSQ7n6k2GSDjgGLXZccLFWyyootM7gUai9Qu1XinGptzrcojll8/vMo8msfuFm99bvcZPbIwkmz+/srOJaip5K3oeyje5cUazRjI/5eOARyoDL/hVoI9HIXeSwhIuJ42LdGFoWTJZaPCHKcL528ZrpHG4P6PmPY+UUonqVgNn3470A9Hhg9bncsiJS+V4F6OpE8u8/yC6FzLC3tDrYTxIUFYtYnteaQIyUfIuTPth/yDwMmqgsSEnHcTDSRClX0sY9waPNffA4eKFmJgXxGyfRUUSFAopDZGug6mZ/S0o4n/sSWnAgov+wEQk7qZgMd1lB6WD454F9YWf0xsC1t7wR90wZElSgOcyDFRsjMSs0TgrhpF9m1LI6wlINmWa89Gu8lPyn784NnWmxNWIKO1QUBhqz1jAoq63ElLfRa2vGUVLweixSEycwFVDTK1fRo+Ay/03MKVUucF6CTEfwl0bLRQDnb+fM4+3ey0M+zsm2ARJjjtMaxY5qQZ5J9BCoBaxyGgsOudTTcV/3CVxFcrDpQ/uxXsv9ni1YR2uViwi0S5g7bZgabkg+IVHOEZRXlCP6e0srgcKW7+dK8Kkmu3cKJgEWIRdUS9TlRpoZLJTJiGDxcihQNfSn2nnRNyPavwFq7KqjIoyjGMIT3VI+/ZQ4NjHbI5CMzejrjHxPq2mOXo8Af9/csGcBE5uMSgvBgX x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM7PR03MB6325.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(136003)(396003)(39860400002)(346002)(376002)(6486002)(478600001)(66946007)(66476007)(6512007)(2906002)(5660300002)(53546011)(6506007)(86362001)(38100700002)(186003)(71200400001)(4326008)(26005)(31696002)(36756003)(31686004)(316002)(2616005)(66556008)(122000001)(54906003)(8676002)(64756008)(8936002)(38070700005)(91956017)(66446008)(76116006)(110136005)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?UUozUVY5Y3l2QWcwcS9LOUt0YkNYUTRTRFJZNFM0eWRKNFdMSmlmbXArOWls?= =?utf-8?B?UkJKLzdBTlFGZEkzVkltc0NGQ3FJYmNYcmNrUUVtUWdrSE0zSTVQOTlYaFEr?= =?utf-8?B?ZDhOSUxxWWxUN1Q2c20vdnJTR3JmQmg3WFdtVzAzSFZnUElwYnJSVXZHK3Qz?= =?utf-8?B?OTdEaWZRSDh0L1FhUHB0eXVWVUMyaTR1TDZkbER4R1pBendDTzNrRDJEdXpW?= =?utf-8?B?NzdwZ2plMW9SS29SSElidXRERjVVMVEwa3hrSk9RVllTTXI2bHNWeWxZMkJL?= =?utf-8?B?VStKWVRBSDYzU3BDY3hGUnVLaUk4R0xsN1VnT3BnSmswb2NUL2xySjVqTTJX?= =?utf-8?B?b3BYT2pPdjRFNmgrNDZSbDJaK00wOGNCaU0xQlZqeGlFVnNYL2tTV3d2VFBh?= =?utf-8?B?TFIvNi8rUStuRGlFbCtRd1Mva1plam0vOHZCVHlaL3E0eXhoSWVXUElGcHA1?= =?utf-8?B?WlgwcFdvSkRNdnYzQ1M3K3NQUHBTOU10RlpOUU1OSkNkYStvc2cwY29RU0Qr?= =?utf-8?B?YmtZRDlpb1ZXOUhncVZEZFBIY2xEREUycysrVWVBVHV0Zld0Q1ZwcEJGYVk1?= =?utf-8?B?QnFyUXhVK1RDS0RpNzhLY2JKa1VpcTNuZ0w5N2wxK1RGeklkS01IbXBablVl?= =?utf-8?B?M3FzMXppZW9DREZBcXVXbkNtWmF1NEZEbjZZTzF5MXRHWW5PN1lGeVBXKysy?= =?utf-8?B?TzBkc1RlZHlpNHdXY0Z5NzdWeitDSDM2bXRZck5mWmdiOCtpamttaC9nU3ox?= =?utf-8?B?SldvYWp3OUpEbVU1emRiVXZLQzZoa2grblRZa1BKRlhtODZEM3l3MUFMMXVh?= =?utf-8?B?RUg0V0crblB6aHFoNFRkWW9Pc2hIbzdLUmErcWlvZi9XVWJqTjdWeUxaMkpp?= =?utf-8?B?QkRySEc2blZMSHNaU283ejk5NmN4b2l3RitPWW02bHJlNU9hRWJRRWhHQkZS?= =?utf-8?B?cVp2MTdiendmdjY1MHd1ZEcrV2FMRkxpT01IcGZxdjNGOUFxSytuMkRWRnBS?= =?utf-8?B?NmVvbEw2N3d1VlJMMzBNT0piek9HMURscE5VRWhsOXkxMFN4cS9pU2ZQM2lM?= =?utf-8?B?bmNOZmFmZUE1Y0srMjlTcnREM2VqTTh0U3hxZ1FiaUZVOFZIRC90T2Z3dVBJ?= =?utf-8?B?S0NIWnQydXpZc0NabWRXMmttK0ZGVWgyTFJFck1sc01rVWFFQkk2ekZkNkVR?= =?utf-8?B?Ky82anpncWpFeks0YjRFcnJMS0d3dXR2Ym53SWJjcWl4ZVVIVWQzTVZLNjht?= =?utf-8?B?eGlSMi96VnEwRWZaSk90MlZyMkc1eTRaR3ZmcTVIV2FaaW5wRjRYckJQa2NM?= =?utf-8?B?RnV1Q1lwbzF0OER4WHBaZEtHVW0xMEc3V29yemRVTHh2bk1HODFBcUxIMjQv?= =?utf-8?B?cTRQdUkwM3NpMFNydDEvUXFjZm9rTHYzd0V5dFpNbC82dko3ZTRIUW1LZW5l?= =?utf-8?B?MEVqSm92eXp0dXczWTdQN0M5aVF3cGRwY0llRUk1dEJlNmJ1cjZTUGFlbEdm?= =?utf-8?B?dDF1MFRuOVlGeXJBeTV4dWJPKzNQOXdlRkRsNlJIQjUzODI4RGorZG1CR2dz?= =?utf-8?B?b3RneEYvM0loczJiQXphazJ5eFQ4N0Viekt3Mm1EeWsxeng2TkVMZ3Y0dkJt?= =?utf-8?B?Ym5IaytwRkhXVUtKTEVDaEFsMHduOXFETUh3UWNZZWZKQXFYZEJOQUEwaXRR?= =?utf-8?B?WjJkeGJPNTFKNy92NzVSYk1uM1RwL0gvTnNiZ1pDU3RSdC8wVTZ2SVF6bzRM?= =?utf-8?Q?GgZ/EBXNLx08E7ZS9YAeJluusU+raL4u9vOUBNO?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: epam.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM7PR03MB6325.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8c69a9c5-d084-4531-9f40-08d971c97d3a X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Sep 2021 06:34:05.1610 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 8a9u+qeUiNQ/PImUze2o2BlWgmIHk8XCbhzj5C/Xds48Hy8mG1YVsjf4sX4BcO0MU5chByJyKIeOPlzsrRBlFv87bpOZP7Au2U4ATq+jnZQIbjMHMutA6nwRKHDDwauh X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR03MB6548 X-Proofpoint-GUID: hPkc-jlmIuwvvC_O6sxvj_loaVVUptEu X-Proofpoint-ORIG-GUID: hPkc-jlmIuwvvC_O6sxvj_loaVVUptEu X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.391,FMLib:17.0.607.475 definitions=2021-09-07_02,2021-09-03_01,2020-04-07_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 priorityscore=1501 mlxscore=0 malwarescore=0 suspectscore=0 clxscore=1015 spamscore=0 mlxlogscore=999 adultscore=0 bulkscore=0 impostorscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2108310000 definitions=main-2109070043 DQpPbiAwNi4wOS4yMSAxMzozOCwgSnVsaWVuIEdyYWxsIHdyb3RlOg0KPiBIaSBPbGVrc2FuZHIs DQo+DQo+IE9uIDA2LzA5LzIwMjEgMTE6MDYsIE9sZWtzYW5kciBBbmRydXNoY2hlbmtvIHdyb3Rl Og0KPj4gT24gMDYuMDkuMjEgMTI6NTMsIEp1bGllbiBHcmFsbCB3cm90ZToNCj4+Pj4+Pj4gSG93 ZXZlciwgbG9va2luZyBhdCB0aGUgcmVzdCBvZiB0aGUgY29kZSwgd2UgYWxyZWFkeSBoYXZlIGEg Y2hlY2sgZm9yIHZwY2kgaW4gdGhlIGNvbW1vbiBJT1JFUSBjb2RlLg0KPj4+Pj4+DQo+Pj4+Pj4g V2hpY2ggbWF5IG5vdCBiZSBlbmFibGVkIGFzIGl0IGRlcGVuZHMgb24gQ09ORklHX0lPUkVRX1NF UlZFUi4NCj4+Pj4+DQo+Pj4+PiBSaWdodC4gTXkgcG9pbnQgaXMgd2hlbiBDT05GSUdfSU9SRVFf U0VSVkVSIGlzIHNldCB0aGVuIHlvdSB3b3VsZCBlbmQgdXAgdG8gY2FsbCB0d2ljZSB2cGNpX3By b2Nlc3NfcGVuZGluZygpLiBUaGlzIHdpbGwgaGF2ZSBhbiBpbXBhY3QgaG93IG9uIGxvbmcgeW91 ciB2Q1BVIGlzIGdvaW5nIHRvIHJ1bm5pbmcgYmVjYXVzZSB5b3UgYXJlIGRvdWJsaW5nIHRoZSB3 b3JrLg0KPj4+Pg0KPj4+PiBTbywgeW91IHN1Z2dlc3QgdGhhdCB3ZSBoYXZlIGluIHRoZSBjb21t b24gSU9SRVEgY29kZSBzb21ldGhpbmcgY2FsbCBsaWtlDQo+Pj4+DQo+Pj4+IGFyY2hfdnBjaV9w cm9jZXNzX3BlbmRpbmc/IEluIGNhc2Ugb2YgeDg2IGl0IHdpbGwgaGF2ZSB0aGUgY29kZSBjdXJy ZW50bHkgZm91bmQgaW4gdGhlDQo+Pj4+DQo+Pj4+IGNvbW1vbiBJT1JFUSBzb3VyY2VzIGFuZCBm b3IgQXJtIGl0IHdpbGwgYmUgbm9wPw0KPj4+DQo+Pj4gTm8gSSBhbSBzdWdnZXN0aW5nIHRvIG1v dmUgdGhlIGNhbGwgb2YgdGhlIElPUkVRIGNvZGUgdG8gaHZtX2RvX3Jlc3VtZSgpIChvbiB4ODYp IGFuZCBjaGVja19mb3JfdmNwdV93b3JrKCkgKG9uIEFybSkuDQo+Pg0KPj4gT2ssIEkgY2FuIG1v dmUgdlBDSSBjb2RlIHRvIGh2bV9kb19yZXN1bWUsIGJ1dCB2UENJIGlzIG9ubHkgdXNlZCBmb3Ig eDg2IFBWSCBEb20wLg0KPg0KPiBBRkFJSywgUm9nZXIgaXMgcGxhbm5pbmcgdG8gdXNlIGl0IGZv ciB4ODYgUFZIIGd1ZXN0Lg0KPg0KPj4NCj4+IERvIHlvdSBzdGlsbCB0aGluayBodm1fZG9fcmVz dW1lIGlzIHRoZSByaWdodCBwbGFjZT8NCj4gSSB0aGluayBzby4gQUZBSUNULCBvbiB4ODYsIHRo ZSBvbmx5IGNhbGxlciBvZiB2Y3B1X2lvcmVxX2hhbmRsZV9jb21wbGV0aW9uKCkgaXMgaHZtX2Rv X3Jlc3VtZSgpLiBTbyBpdCBtYWtlcyBzZW5zZSB0byBwdXNoIG9uZSBsYXllciB1cC4NCg0KT2ss IHNvIEkgZW5kZWQgdXAgd2l0aDoNCg0KLS0tIGEveGVuL2FyY2gvYXJtL3RyYXBzLmMNCisrKyBi L3hlbi9hcmNoL2FybS90cmFwcy5jDQpAQCAtMjMwNSwxMCArMjMwNSwxNyBAQCBzdGF0aWMgYm9v bCBjaGVja19mb3JfdmNwdV93b3JrKHZvaWQpDQogwqDCoMKgwqAgfQ0KIMKgI2VuZGlmDQoNCi3C oMKgwqAgbG9jYWxfaXJxX2VuYWJsZSgpOw0KLcKgwqDCoCBpZiAoIGhhc192cGNpKHYtPmRvbWFp bikgJiYgdnBjaV9wcm9jZXNzX3BlbmRpbmcodikgKQ0KLcKgwqDCoMKgwqDCoMKgIHJhaXNlX3Nv ZnRpcnEoU0NIRURVTEVfU09GVElSUSk7DQotwqDCoMKgIGxvY2FsX2lycV9kaXNhYmxlKCk7DQor wqDCoMKgIGlmICggaGFzX3ZwY2kodi0+ZG9tYWluKSApDQorwqDCoMKgIHsNCivCoMKgwqDCoMKg wqDCoCBib29sIHBlbmRpbmc7DQorDQorwqDCoMKgwqDCoMKgwqAgbG9jYWxfaXJxX2VuYWJsZSgp Ow0KK8KgwqDCoMKgwqDCoMKgIHBlbmRpbmcgPSB2cGNpX3Byb2Nlc3NfcGVuZGluZyh2KTsNCivC oMKgwqDCoMKgwqDCoCBsb2NhbF9pcnFfZGlzYWJsZSgpOw0KKw0KK8KgwqDCoMKgwqDCoMKgIGlm ICggcGVuZGluZyApDQorwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCByZXR1cm4gdHJ1ZTsNCivCoMKg wqAgfQ0KVGhpcyBpcyBob3cgaXQgaXMgZG9uZSBmb3IgSU9SRVEuIEl0IHNlZW1zIHRoZXJlIGlz IG5vIG5lZWQgdG8gcmFpc2Ugc29mdGlycS4NCg0KSSBhbHNvIG1vdmVkIHZQQ0kgZnJvbSBjb21t b24gY29kZSB0byBodm1fZG9fcmVzdW1lIGZvciB4ODYNCg0KPg0KPiBDaGVlcnMsDQo+DQpUaGFu a3MsDQoNCk9sZWtzYW5kcg0K From xen-devel-bounces@lists.xenproject.org Tue Sep 07 06:52:47 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 06:52:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180441.327105 (Exim 4.92) (envelope-from ) id 1mNUyI-0002YK-H5; Tue, 07 Sep 2021 06:52:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180441.327105; Tue, 07 Sep 2021 06:52:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNUyI-0002YD-Do; Tue, 07 Sep 2021 06:52:42 +0000 Received: by outflank-mailman (input) for mailman id 180441; Tue, 07 Sep 2021 06:52:41 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNUyH-0002Y7-F7 for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 06:52:41 +0000 Received: from foss.arm.com (unknown [217.140.110.172]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTP id 31791194-0fa8-11ec-b0d7-12813bfff9fa; Tue, 07 Sep 2021 06:52:40 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B06AF31B; Mon, 6 Sep 2021 23:52:39 -0700 (PDT) Received: from e125770.cambridge.arm.com (e125770.cambridge.arm.com [10.1.197.16]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5DA4C3F5A1; Mon, 6 Sep 2021 23:52:38 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 31791194-0fa8-11ec-b0d7-12813bfff9fa From: Luca Fancellu To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, wei.chen@arm.com, Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [RFC PATCH] xen/design: Add design for EFI dom0less system start Date: Tue, 7 Sep 2021 07:52:28 +0100 Message-Id: <20210907065228.21794-1-luca.fancellu@arm.com> X-Mailer: git-send-email 2.17.1 Add a design describing a proposal to improve the EFI configuration file, adding keywords to describe domU guests and allowing to start a dom0less system. Signed-off-by: Luca Fancellu --- docs/designs/efi-arm-dom0less.md | 105 +++++++++++++++++++++++++++++++ 1 file changed, 105 insertions(+) create mode 100644 docs/designs/efi-arm-dom0less.md diff --git a/docs/designs/efi-arm-dom0less.md b/docs/designs/efi-arm-dom0less.md new file mode 100644 index 0000000000..8d8fa2243f --- /dev/null +++ b/docs/designs/efi-arm-dom0less.md @@ -0,0 +1,105 @@ +# Xen EFI configuration file + +The current configuration file used by Xen when it is started as an EFI +application is considering only the dom0 guest and doesn't have any +property to describe and load in memory domU guests. +Hence currently it's impossible to start a dom0less system using EFI. + +# Objective + +This document describes the proposed improvement to the Xen EFI +configuration file to list properly both the dom0 guest and the domU +guests as well. +The final goal is to be able to start a dom0less system using EFI. + +# Current Xen EFI configuration file + +The current configuration file is described by the documentation page +https://xenbits.xenproject.org/docs/unstable/misc/efi.html. + +Here an example: + +``` +[global] +default=section1 + +[section1] +options=console=vga,com1 com1=57600 loglvl=all noreboot +kernel=vmlinuz-3.0.31-0.4-xen [domain 0 command line options] +ramdisk=initrd-3.0.31-0.4-xen +xsm= +dtb=devtree.dtb +``` + +# Proposed improvement + +The proposed improvement to the current configuration file is the +introduction of new keywords to describe additional domUs. + +Here follows the proposed new keywords: + - domu#_kernel= [domU command line options] + - Mandatory kernel file for the domU# + - domu#_ramdisk= + - Optional ramdisk file for the domU# + - domu#_dtb= + - Optional dtb fragment file for the domU#, it is used for device + assignment (passthrough). + - domu#_property=cpus=2 + - Properties that should be added to the dtb in the domU node to + properly describe the domU guest. Refer to the documentation: + https://xenbits.xenproject.org/docs/unstable/misc/arm/device-tree/booting.txt, + section "Creating Multiple Domains directly from Xen". + +For all the keywords above, the # is a number that uniquely identifies +the guest. +The keywords domu#_kernel, domu#_ramdisk, domu#_dtb are unique, therefore there +must not be specified the same keyword twice in a section. +The # number is not enforcing any domid, it is just used to link each property +to the right guest, so there can be domu1_* guests that are started with domid 2 +and so on. + +The domu#_property can appear multiple times and it specifies an additional +property to be listed in the domU node inside the device tree, Xen will +not check if the same content is specified multiple times. + +There are some property whose name starts with an hash symbol (#address-cells, +#size-cells), in this case the line will be considered as a comment, so to +specify them, they have to be listed without the hash symbol, the documentation +will be updated as well to see the implemented handling of these special +properties. + +# Example of a configuration file describing a dom0less system + +The following configuration file is describing a dom0less system starting two +guests. + +``` +[global] +default=xen + +[xen] +# Xen boot arguments +options=noreboot console=dtuart dtuart=serial0 bootscrub=0 +# Xen device tree +dtb=devtree.dtb + +# Guest 1 +domu1_property=address-cells=2 +domu1_property=size-cells=2 +domu1_kernel=Image-domu1.bin console=ttyAMA0 root=/dev/ram0 rw +domu1_property=cpus=1 +domu1_property=memory=0xC0000 +domu1_dtb=domu.dtb + +# Guest 2 +domu2_kernel=Image-domu2.bin console=ttyAMA0 root=/dev/ram0 rw +domu2_property=cpus=2 +domu2_property=memory=0x100000 +domu2_property=vpl011 +``` + +In this example the Guest 1 is loading Image-domu1.bin as kernel and it is using +the passed boot arguments, it is also loading a device tree snippet for device +passthrough. +The second guest, Guest 2, is using another kernel and it will use the vpl011 +device. -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Tue Sep 07 06:54:31 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 06:54:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180450.327117 (Exim 4.92) (envelope-from ) id 1mNV02-0003DZ-2Q; Tue, 07 Sep 2021 06:54:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180450.327117; Tue, 07 Sep 2021 06:54:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNV01-0003DS-Uh; Tue, 07 Sep 2021 06:54:29 +0000 Received: by outflank-mailman (input) for mailman id 180450; Tue, 07 Sep 2021 06:54:29 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNV01-0003DM-1R for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 06:54:29 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 2c4fef43-8188-4913-a64a-d6de9c1a02b7; Tue, 07 Sep 2021 06:54:27 +0000 (UTC) Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-am5eur03lp2058.outbound.protection.outlook.com [104.47.8.58]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-21-Tx5IdKCpMGGYJcqTF6j-Cw-1; Tue, 07 Sep 2021 08:54:26 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR04MB4192.eurprd04.prod.outlook.com (2603:10a6:803:4c::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.24; Tue, 7 Sep 2021 06:54:24 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4500.014; Tue, 7 Sep 2021 06:54:23 +0000 Received: from [10.156.60.236] (37.24.206.209) by PR3P251CA0027.EURP251.PROD.OUTLOOK.COM (2603:10a6:102:b5::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Tue, 7 Sep 2021 06:54:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2c4fef43-8188-4913-a64a-d6de9c1a02b7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1630997667; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hqt8KpC+/cLPQGezf9kbhcn7tWO956T4Rz/kcs8uU+Y=; b=nHEndOrvXG0TETMQaPDvkGsH9YxyEVR7pRXsd5SqzcFMbS9z62K8EDkO+X6ZXpcZw6lcxO sWZFFq7diA0ZQM9vyFrNQBj6Mecuks7RhIY7mshwKszUCgupcIUJirG/iLgiyQ8UgSlzVG OFXl7P3hh7HrZIn+46ypNsAjLhsCmXg= X-MC-Unique: Tx5IdKCpMGGYJcqTF6j-Cw-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IMppmzkvfoDfCDXioiJMvUs3WB4q73YFpeiuLgVf8zOj/qsaIqm8oiBG7h9ad14PdvM/8bBNpQ8uQwRV1Ax6YHJJFsluiZlVkz8sBQoa2LM/iXdwFDmz1iMewNGsU8aDhkVfYprGs5yb4Ed5V5jToGTguu89KsvCxb3wroZeyVFfVdqqTPFC7Z8S+PZuLRBrObMnM0Y9Mxc25pXAogKzOYuoOmLUxdSlsP3KPZQeBJ76OKSx8TKS63vPoKs66Ub+ottIFRotGqgUY8Nfj8/05FDZqoO4A6OId3nnCPzeBjlF6/a7sP8K4l2CWVp/pkM+WU5GdjeWlTMujCxBw0MM0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=hqt8KpC+/cLPQGezf9kbhcn7tWO956T4Rz/kcs8uU+Y=; b=SCDoFaNgwzabALppQMsCmPza1E6jAgogXmAGhjBObvhJ1yiNMvhNUSNfs9j3Z7tRJ7NEcuKJfK5VFB+pkefEpNEjvKVIqRGc8S68RquqjGAT+L7Z6CakNf5sY5JVsQCTEJkG5PTpq5qfRsvg0uoRblRkgqZCsdTYzfWCeqpI8dNLqYd2GSkn3h70mEJJUadBWD+fFladbyrZTpcnq+ZzmVHGasdX9ICNJZpV0W/Tp0bFlrD54LAUr+q0q6/fpp1Ek7veacVQM2ISvisAhXehm9ExpeQbRcoUsA/QCkxDMbeMD66DaZQqcK2ls9rms9sbykyZxwQGlXQyIcXoio3ZnQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com; Subject: Re: xen-unstable linux-5.14: 1 of 2 multicall(s) failed: cpu 0 To: Sander Eikelenboom References: <9c36205e-cc37-ed9a-3408-0cccc4a83115@eikelenboom.it> Cc: "xen-devel@lists.xenproject.org" From: Jan Beulich Message-ID: <468f4d74-d469-51f9-a0a0-3fcbe24d298c@suse.com> Date: Tue, 7 Sep 2021 08:54:21 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: <9c36205e-cc37-ed9a-3408-0cccc4a83115@eikelenboom.it> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PR3P251CA0027.EURP251.PROD.OUTLOOK.COM (2603:10a6:102:b5::13) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a47430a2-5556-4036-3873-08d971cc5316 X-MS-TrafficTypeDiagnostic: VI1PR04MB4192: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Mt28rYVlfml3dEboFw6TkvNRYSiO8CiJZypLeK2Ii1i0qN2hT2XTEQaRrt9jmOn1wCpb2Tg9UbhqJpTCQd6gc4kuln5VBR1+OeuAB6uFHfJJExcecVt11mJI4j/qPJwoeHBSpGSR+Mv4u9MtfxzzIqCAL3MPrBiiEfTP2vuxP1/ORs9536sTTnJWyai4N7UqvOvWDBpBRCk4iK2R6A5aAd5t4VuWpIXO1iQIq0i8/XgUUjpjco5ZBaRyDiEnjGq6NLr4LFaqKBf2h4XBv59T6/RkB9dW375bRie25y+eY6JX9tpVbR9rZkRm9EsU0SroPvPuMrjVZ1pIfWWZ4MgsiMyhTiHrHGlMy29skl+Z6slzPT0X4kV04VjP+AekPJPkcLjUd5r9gkR6unT9iKpWNFHwylmofDePCh+7QEEkZUQj37EYx5oMSORdFWCqcstioYtvW4uitlj5iBQlXawdx0Kty+ltL1GnYB9YPBVrjctIDv65WJUpEkdHiu3D4WncUhn3HPOEHFnQ+uKt7fB6gsLU6ExB2kly1CplEhX7rmEFdepUQaTsf6cpO8/UvfN+0hYVCUa9TCjueDxhQ2v4yxkx5JIdoWR3PjkQtXKubP3zKpcbqTeKgA7hV70bFzx7ba5CQeGW4/Xlkq8krLrcTFn3JjMQYRCI0g/P7VURawlZA3XqoSDtFcDDYiVwVnuzFaqtjhiRGHtk4gLAL/suXi3qoq0+PzcFaJm3Js0ehbU= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(136003)(346002)(39860400002)(376002)(366004)(396003)(31696002)(956004)(36756003)(8936002)(2616005)(6486002)(2906002)(31686004)(4326008)(83380400001)(45080400002)(8676002)(66946007)(86362001)(478600001)(316002)(5660300002)(16576012)(38100700002)(6916009)(66556008)(53546011)(186003)(26005)(66476007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TkVhQ1gzY2NTWjBSUWxKRkY2b0FRK2JySWpVR2hIaGQ5eElKblEydHZ1azgz?= =?utf-8?B?WGFkODRtdkxtdjRkU3EvOXFJcFBPQ2toU1JrcmZQcHV0QUl3Z3ZZbDU0cDh3?= =?utf-8?B?YUdOakNlRFJTZkx3eHBld0N6VHRkYzE1c2xJY2xHcTVKamprTjdJMnpya0w1?= =?utf-8?B?SVliSzZ1NXdnaUVTWWhJeWlzSzBjN2cyTE15dzVPYjdYTnRCamFyUDM2MStB?= =?utf-8?B?b3RGd1ZBMnRUNTZwV0dyNVU1WVNTeXBiN1dRNWY3a3RGbUZodVEzb2dWcE5j?= =?utf-8?B?VWs4ZGp2Tm42M2RXTnQ0d3l3amJTK3VrSWpldUdNa2tsYzc4WUZPdjNUR0dl?= =?utf-8?B?Z3ozaGhPWlVDNG1lWWpFNlRoQXNkNi9FdXptS1phaUwxMmVUMTY4MkZPbkpp?= =?utf-8?B?b3FnNy9xOERrb1V5NXZBTWhNd2JLZ0NVTWlhWlI2VUN1SXY2RzlVdHA2bGtP?= =?utf-8?B?S1ZDdWg5ZDlwQURzdlh1WUJoRnU2dURsbVpwWnM4NkRnYWhmMmFyYTVWUDFi?= =?utf-8?B?TkxlamlYWVZLY01na0UrRjdLMzVISGRTcUtFeE9nYVN2YVRVdzFyaldqYmZr?= =?utf-8?B?WGhCYWVWSktsR0lYZDJ2bEZBSU9XOXNWUS9wY2FLOGNRZ1RXeEpGcGIzeThi?= =?utf-8?B?d09qUzBndG1zaXJMbHU5bVFwcWVoTys0bGl6WHZFOUUyL2FwTGtFRnJ2WG5D?= =?utf-8?B?QUljRG8rem1zZVk4ZjF4UUIzMEVMTjMyb1dZVFBUR2doVk5HVi9JbExJS3lk?= =?utf-8?B?YXhSTEU5TStBdG5zd2tNemxjczY5ZW5NbzFrOVNCb3VzZmZVL0VFM3dva21B?= =?utf-8?B?TjFDaXUveWpSWGZxRjd6VFRhVWJIeUo1NlV6M2xFSzFYSEZBNE5RMWEzMy81?= =?utf-8?B?bGxZR3FoZGI0dzc3NkZpYXdlZnlncTZFa1Frc1VkRnUxem9Cbzd2bFdDci9Z?= =?utf-8?B?QnhaSXMrcUhSc3pUam54NDlmV0lPMmorMVN3bHJiUkVOZkdNSGNQd2wvRWVW?= =?utf-8?B?OG1aaUJrZ2hoZWhWekJIMXI3TXhEaU9ZSmROdXd6OG1ISDhZeWt5OFE1Qk1t?= =?utf-8?B?Qyt3S1o0bk90Y2xiZTBUdlJBT21CaEVoVFJ1Sk8wOUZPcVNpWGlBSnJTb2k3?= =?utf-8?B?OVl2bzNQTDI0OVU3NUZNckxCM1pscmk5OHJDbEVtNlJlMno1QTJSaFZOSzZ5?= =?utf-8?B?S3YzZXRuTGVETk5GWUJRdE5GWW1XWDQyY1dKSUpJQ3VLaTBaTmM2VDdpbXZ0?= =?utf-8?B?U1dEZHlYaGgrWVZiRzJWZEFDNXY3VnM1SzlTa0ViaHZhdFdpdHdUNEtJand6?= =?utf-8?B?clhiRHUzYzNvaklhU3ZYZG9KRkI2MzRReWdUZ2hYSGpOR3dnd0JyZFVFVmFI?= =?utf-8?B?Q1ozNUVaUHhXMFZkMHl5aHE3V2NaaENrSDdqR1dxb1l6WFdWa0I1YkpXditw?= =?utf-8?B?YzE2YmRJWFVLUmxDaVJKWUYyWWJXTWhEdVVqQ3dpQWJSdk5nbkFuamJHZzF6?= =?utf-8?B?Y0R3MFVOWno3RXNZUjdPaUN3endscmlCTEZTMGc3UmM3N0FiV3RRd201TjVu?= =?utf-8?B?a0d6MkE0dDBZeHRQcDRockYrU3pVL1QvaWFhTXVoK0JDUEdKVGw0WGpGZGtj?= =?utf-8?B?Zk9Zd1R4dUI0MmtzdW1TTDVtQmtyWEhjRVczaXUwR2FGY0UrakUvR1crRlY4?= =?utf-8?B?endPTWtpaWJwdCtZazNFbTkzYVdjNW5wMHpOSjMvUnZDbDBiOVkxb0FuZE40?= =?utf-8?Q?ckx4J0UnpUVHkgIrF/mv4j54pP8iIYTDwxVs+SL?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: a47430a2-5556-4036-3873-08d971cc5316 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2021 06:54:23.5775 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: kftMAkS9f9pR2u+l8Wa9sjIRe8wwadWXS6YNx7hl3SXS8fx1TMjQSDecHKRtTyTWlkL/mqRTPa+H80WuN/9+Cw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4192 On 06.09.2021 23:35, Sander Eikelenboom wrote: > L.S., > > On my AMD box running: > xen-unstable changeset: Fri Sep 3 15:10:43 2021 +0200 git:2d4978ead4 > linux kernel: 5.14.1 > > With this setup I'm encountering some issues in dom0, see below. Any indication as to "since when"? Xen update, kernel update, config change, ...? > xl dmesg gives: > > (XEN) [2021-09-06 18:15:04.089] mm.c:3506:d0v0 mfn 63b936 already pinned > (XEN) [2021-09-06 18:15:04.089] mm.c:3506:d0v0 mfn 6a0622 already pinned > (XEN) [2021-09-06 18:15:04.089] mm.c:3506:d0v0 mfn 6b63da already pinned > (XEN) [2021-09-06 18:15:04.089] mm.c:3506:d0v0 mfn 638dd9 already pinned > (XEN) [2021-09-06 18:15:04.089] mm.c:3506:d0v0 mfn 68a7bc already pinned > (XEN) [2021-09-06 18:15:04.089] mm.c:3506:d0v0 mfn 63c27d already pinned > (XEN) [2021-09-06 18:15:04.089] mm.c:3506:d0v0 mfn 6a04f2 already pinned > (XEN) [2021-09-06 18:15:04.089] mm.c:3506:d0v0 mfn 690d49 already pinned > (XEN) [2021-09-06 18:15:04.089] mm.c:3506:d0v0 mfn 6959a0 already pinned > (XEN) [2021-09-06 18:15:04.089] mm.c:3506:d0v0 mfn 6a055e already pinned > (XEN) [2021-09-06 18:15:04.090] mm.c:3506:d0v0 mfn 639437 already pinned This hints more towards a kernel issue, but I wouldn't outright exclude other reasons. > dmesg gives: > > [34321.304270] ------------[ cut here ]------------ > [34321.304277] WARNING: CPU: 0 PID: 23628 at arch/x86/xen/multicalls.c:102 xen_mc_flush+0x176/0x1a0 > [34321.304288] Modules linked in: > [34321.304291] CPU: 0 PID: 23628 Comm: apt-get Not tainted 5.14.1-20210906-doflr-mac80211debug+ #1 > [34321.304294] Hardware name: MSI MS-7640/890FXA-GD70 (MS-7640) , BIOS V1.8B1 09/13/2010 > [34321.304296] RIP: e030:xen_mc_flush+0x176/0x1a0 > [34321.304300] Code: 89 45 18 48 c1 e9 3f 48 89 ce e9 20 ff ff ff e8 60 03 00 00 66 90 5b 5d 41 5c 41 5d c3 48 c7 45 18 ea ff ff ff be 01 00 00 00 <0f> 0b 8b 55 00 48 c7 c7 10 97 aa 82 31 db 49 c7 c5 38 97 aa 82 65 > [34321.304303] RSP: e02b:ffffc90000a97c90 EFLAGS: 00010002 > [34321.304305] RAX: ffff88807d416398 RBX: ffff88807d416350 RCX: ffff88807d416398 > [34321.304306] RDX: 0000000000000001 RSI: 0000000000000001 RDI: deadbeefdeadf00d > [34321.304308] RBP: ffff88807d416300 R08: aaaaaaaaaaaaaaaa R09: ffff888006160cc0 > [34321.304309] R10: deadbeefdeadf00d R11: ffffea000026a600 R12: 0000000000000000 > [34321.304310] R13: ffff888012f6b000 R14: 0000000012f6b000 R15: 0000000000000001 > [34321.304320] FS: 00007f5071177800(0000) GS:ffff88807d400000(0000) knlGS:0000000000000000 > [34321.304322] CS: 10000e030 DS: 0000 ES: 0000 CR0: 0000000080050033 > [34321.304323] CR2: 00007f506f542000 CR3: 00000000160cc000 CR4: 0000000000000660 > [34321.304326] Call Trace: > [34321.304331] xen_alloc_pte+0x294/0x320 > [34321.304334] move_pgt_entry+0x165/0x4b0 > [34321.304339] move_page_tables+0x6fa/0x8d0 > [34321.304342] move_vma.isra.44+0x138/0x500 > [34321.304345] __x64_sys_mremap+0x296/0x410 > [34321.304348] do_syscall_64+0x3a/0x80 > [34321.304352] entry_SYSCALL_64_after_hwframe+0x44/0xae > [34321.304355] RIP: 0033:0x7f507196301a > [34321.304358] Code: 73 01 c3 48 8b 0d 76 0e 0c 00 f7 d8 64 89 01 48 83 c8 ff c3 66 2e 0f 1f 84 00 00 00 00 00 66 90 49 89 ca b8 19 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d 46 0e 0c 00 f7 d8 64 89 01 48 > [34321.304360] RSP: 002b:00007ffda1eecd38 EFLAGS: 00000246 ORIG_RAX: 0000000000000019 > [34321.304362] RAX: ffffffffffffffda RBX: 000056205f950f30 RCX: 00007f507196301a > [34321.304363] RDX: 0000000001a00000 RSI: 0000000001900000 RDI: 00007f506dc56000 > [34321.304364] RBP: 0000000001a00000 R08: 0000000000000010 R09: 0000000000000004 > [34321.304365] R10: 0000000000000001 R11: 0000000000000246 R12: 00007f506dc56060 > [34321.304367] R13: 00007f506dc56000 R14: 00007f506dc56060 R15: 000056205f950f30 > [34321.304368] ---[ end trace a19885b78fe8f33e ]--- > [34321.304370] 1 of 2 multicall(s) failed: cpu 0 > [34321.304371] call 2: op=12297829382473034410 arg=[aaaaaaaaaaaaaaaa] result=-22 Just as an observation: This (decimal) output of course isn't very helpful for investigating issues like this one. But the 0xAA pattern indicates anyway that what is being logged has been clobbered by the hypervisor. For the output to be useful, MC_DEBUG needs to be enabled in the sources. Jan From xen-devel-bounces@lists.xenproject.org Tue Sep 07 07:38:15 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 07:38:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180477.327136 (Exim 4.92) (envelope-from ) id 1mNVg6-0000DK-K0; Tue, 07 Sep 2021 07:37:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180477.327136; Tue, 07 Sep 2021 07:37:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNVg6-0000DD-GC; Tue, 07 Sep 2021 07:37:58 +0000 Received: by outflank-mailman (input) for mailman id 180477; Tue, 07 Sep 2021 07:37:56 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNVg4-0000D7-BP for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 07:37:56 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (unknown [40.107.6.82]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 839a3b3c-0fae-11ec-b0d8-12813bfff9fa; Tue, 07 Sep 2021 07:37:55 +0000 (UTC) Received: from AM5PR04CA0015.eurprd04.prod.outlook.com (2603:10a6:206:1::28) by AM9PR08MB6787.eurprd08.prod.outlook.com (2603:10a6:20b:2fe::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19; Tue, 7 Sep 2021 07:37:53 +0000 Received: from AM5EUR03FT034.eop-EUR03.prod.protection.outlook.com (2603:10a6:206:1:cafe::46) by AM5PR04CA0015.outlook.office365.com (2603:10a6:206:1::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14 via Frontend Transport; Tue, 7 Sep 2021 07:37:53 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT034.mail.protection.outlook.com (10.152.16.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Tue, 7 Sep 2021 07:37:52 +0000 Received: ("Tessian outbound b48d04bf8afd:v105"); Tue, 07 Sep 2021 07:37:52 +0000 Received: from cc337d4a303e.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 5A90B823-E9D3-4480-A8EE-8118E84F0E17.1; Tue, 07 Sep 2021 07:37:45 +0000 Received: from EUR02-AM5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id cc337d4a303e.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 07 Sep 2021 07:37:45 +0000 Received: from PAXPR08MB6446.eurprd08.prod.outlook.com (2603:10a6:102:12d::10) by PAXPR08MB6687.eurprd08.prod.outlook.com (2603:10a6:102:132::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.17; Tue, 7 Sep 2021 07:37:44 +0000 Received: from PAXPR08MB6446.eurprd08.prod.outlook.com ([fe80::c029:ed0:82e7:3c2f]) by PAXPR08MB6446.eurprd08.prod.outlook.com ([fe80::c029:ed0:82e7:3c2f%6]) with mapi id 15.20.4478.025; Tue, 7 Sep 2021 07:37:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 839a3b3c-0fae-11ec-b0d8-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JacijTGwJwH9kAXer4cp3e7Zs95IEF6URsV3LKVTH0g=; b=2xP39ivKE620IZmZc0sPTQb/f02xxJjYGgkbTjbDWF1qg8+jpxXd8Iyz73hCtClrmZvGxwGcTw4s/0IefEB+YG8PkoUx2P1TZp1NXCHavl1N4D6g1KMcCxXP9uDG6FCTVTrzrgYCiKOU50K90Bj1tY4heGCOWDlKx+v+W46rL8w= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: 897d52c3b5177b73 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dh6O08MnqxBafjwLpw3NuWMTa57YVQoKhy1ii6sWKhJRt2jvTEu5dfnftxx1/pgR+O/OMaILp6LnGzB4iuYCqulPGqYqzVqYcdKzR/0uOJoClrp6Ci/L183wDjVHgtBgergHu67ioJdMTM+6UdMh+AjUF8B584eKcBNSdTDvfwdhzV/8FOOhoSWtzvd+tXbN+Sp85H74L1taU92dTVjc8LLv3vZmQ9Ou2wgqmKApXStpw+cWk9YeoBBxOhA+5Ki7Hu4pr8VALfDQmHo55vDf2VyPcmQDjmsbESVuToE3MeJJJoGMW06/9OBtO5YVZONDZk3Q2Ir352PYZh87LJR7MQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=JacijTGwJwH9kAXer4cp3e7Zs95IEF6URsV3LKVTH0g=; b=RuvOj5Clm/Dl0pYzr4N0muh6zTunpCQomv6ax0wGyv+carmfhFa8u48dPx6QeSca4wUr3w1H86qsp74e9tG+fyBBo9sW89DJdnCuatqTh8Nf/pKjYMP0+XoNE0PS/Rjgu3hXNhB7sFuy0mXeJhTkezrbB+Y5f3ALA0xtJbtXMQP3gnjsIlmAypDDbR4elfqG9ho1Y0K7I34PYu64JtyKRk4BrrgN1PadY2Oh+8hQP9iaAtewz3F2T3HcP4SZnPwSVQ5rGaK63pg6swF7afrZEP1iB7fbLIX0AEm8OKaEr78Yytl80LU906jB8oo/Jaw46DoX5PU5jFRwekdi5Sofgg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JacijTGwJwH9kAXer4cp3e7Zs95IEF6URsV3LKVTH0g=; b=2xP39ivKE620IZmZc0sPTQb/f02xxJjYGgkbTjbDWF1qg8+jpxXd8Iyz73hCtClrmZvGxwGcTw4s/0IefEB+YG8PkoUx2P1TZp1NXCHavl1N4D6g1KMcCxXP9uDG6FCTVTrzrgYCiKOU50K90Bj1tY4heGCOWDlKx+v+W46rL8w= From: Bertrand Marquis To: Julien Grall CC: Stefano Stabellini , "xen-devel@lists.xenproject.org" , Volodymyr Babchuk Subject: Re: [PATCH v3 7/7] xen/arm: Sanitize CTR_EL0 and emulate it if needed Thread-Topic: [PATCH v3 7/7] xen/arm: Sanitize CTR_EL0 and emulate it if needed Thread-Index: AQHXmbPyaqNt71/0B0WMx26sIln5R6uHdm2AgAYrXACAABkoAIAAGG+AgAUlJICAA8aUAIAAmQIAgADq+oA= Date: Tue, 7 Sep 2021 07:37:44 +0000 Message-ID: References: <14b1639e-c9e4-f8fb-e921-73d7f28681ac@xen.org> <98E8FB9D-3372-47D2-92F7-8AD401AC1092@arm.com> <6705127a-bde2-36cd-0fed-900eb1eace03@xen.org> <7fc6e6b6-464a-a305-2693-42cba40ad869@xen.org> In-Reply-To: <7fc6e6b6-464a-a305-2693-42cba40ad869@xen.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3654.120.0.1.13) Authentication-Results-Original: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com; x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: 5527bb9c-947b-401a-ad77-08d971d2668e x-ms-traffictypediagnostic: PAXPR08MB6687:|AM9PR08MB6787: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:10000;OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: ibyjGh0gjRbk+LfTaFbfKuH+LE8AkIHTI5lPwvoNVKNO/8+0cfwq5eSuKym7J5IjzxmXTw1HBQD0CDGi83AE0nQjFPV20hnp1YJdAhqhxlmWddCoPyYUC2npo+eT2sjWPFzp+2Hrf6bPyTepUIc8ZC0N4bjPXa5U3wMZSf7YwRWeFfFJ4oTVpmiBpB3VQWAIiw+YroljIamzyOur5Bpmh2ctS/zukOi7tB6yj5ST0T8BQisWtfTGBloyRdLoRfdyyDzxQus/70XOuG+yTAtaS68vGE5dLuBqZ/f+l3IS9Hqz7l0RKqUazEykNUo/oNOeYVUP0zuM4M0xcTbgPLouBv84FIfSLH77Xva8HFpWCzykhTwiTeM8DW1qNBC7vHlI9NTi9g1noCYDN2WrQ6ocljbE0dd54j0EWmWUgflB5gqRudV+pZYaqAtUKSIG/AJ4inBimgAl3g6GLwc9JvpevUaGg9IJ8ZjHD5bdCcYTEYSml5ifhDLhLC8AsMJkpUsJ6UM3YOmrYrBvdwOxhp4DuHqhSLzuihMmsGqkcfnr3LT1H75kSUYvJ0eSqhurbNJ/Db8Yh8IAyhFz18L4ttgyeANc7+xOYq1LHmyybZxEiVbg9I91EZymLyiMrok5UdTOda8oFAsmZbfa7GDQhcFooDvFIlYvwZ+I461IpNKOEpB+LX9pVqO3GoepM1Aq/ejWRYQZ6GbCR5xo4BogrhH4HrL3xULqNatId2ZxSMAvTPaA7QKPPG3UeO6wzznxIn1S X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB6446.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(39860400002)(376002)(396003)(136003)(366004)(346002)(64756008)(66476007)(66556008)(53546011)(66446008)(6506007)(38100700002)(6486002)(26005)(36756003)(6512007)(71200400001)(186003)(66946007)(8676002)(2906002)(5660300002)(2616005)(4326008)(478600001)(54906003)(76116006)(8936002)(91956017)(6916009)(86362001)(38070700005)(122000001)(83380400001)(316002)(33656002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6687 Original-Authentication-Results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT034.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: d15b2021-f01d-48f0-4952-08d971d26191 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: O9ArztvDSpNstsErMxyHEuITQsjYKjpOMuyX3rtMCERTmYu3RZmcgb/PXDzlzD/nXq/R0zfTD1LrPWZWPO0K1CLcoPOzJWIYKzBh/S0a/Jo56wCuABlJTcM8XQMj2gBOSGg0mP6npbeZYcUg6sOFvlCHo6psRVgPTeRQYQoSYmJeltRH4zZJuqE6KBn2Q+v/92s3+jW8/JwFd3vJgkBG1HO8F8AZfMN4kIcnmKl3BRM+MlvnXBQ4WErEJte4NbR4rqpUahsg3OCp/A+sm4hi8K9ouLUKuuXMovCiN2OPISF8A0ww8+5W+Oun29VvcpzsCTDJwqs4zikavkNk/K2WIRQ/Ivgv+ucHtamRruGhHGkGaVLG7JU21PlsH5/Bj2jvor8waGCszkWGho0Cz9JBvDZW+48CUnEHjY/GLb6vnBjuKP3ho14hfdQpSKhXa/sq6a9qOKSutICgHsuYm2RJwMmIHEC5msdrT0nVu7qNB+kUBjqoLu4Y1eWdbS074tvnZgBOMxPs02tKJHOmLqMZyBy62HQyZVcU3RndU8hgJhImRskLAMjbDEBtZVurolwsLLSFDilaYpNz35UKwLnykW9R3yYrls23SFE9j/RfFaNImYSwtsD01neTeVGxlKnagfN72lBMSVYHkuCzQMNxKfdzXBO3hRUdPWjoanFemYmQJP0khCqpvw6potWVQ/PEdHjMnD/fJsV3L4cghpzITg== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(346002)(39860400002)(376002)(396003)(136003)(46966006)(36840700001)(54906003)(107886003)(33656002)(70586007)(36860700001)(4326008)(6486002)(70206006)(2616005)(36756003)(2906002)(53546011)(336012)(6506007)(82310400003)(6862004)(186003)(316002)(5660300002)(26005)(8936002)(8676002)(47076005)(6512007)(81166007)(478600001)(86362001)(83380400001)(82740400003)(356005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2021 07:37:52.6553 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5527bb9c-947b-401a-ad77-08d971d2668e X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT034.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB6787 SGkgSnVsaWVuLA0KDQo+IE9uIDYgU2VwIDIwMjEsIGF0IDE4OjM2LCBKdWxpZW4gR3JhbGwgPGp1 bGllbkB4ZW4ub3JnPiB3cm90ZToNCj4gDQo+IEhpIEJlcnRyYW5kLA0KPiANCj4gT24gMDYvMDkv MjAyMSAwOToyOSwgQmVydHJhbmQgTWFycXVpcyB3cm90ZToNCj4+PiBPbiAzIFNlcCAyMDIxLCBh dCAyMzo0OSwgU3RlZmFubyBTdGFiZWxsaW5pIDxzc3RhYmVsbGluaUBrZXJuZWwub3JnPiB3cm90 ZToNCj4+PiANCj4+PiBPbiBUdWUsIDMxIEF1ZyAyMDIxLCBCZXJ0cmFuZCBNYXJxdWlzIHdyb3Rl Og0KPj4+PiBIaSBKdWxpZW4sDQo+Pj4+IA0KPj4+Pj4gT24gMzEgQXVnIDIwMjEsIGF0IDE1OjQ3 LCBKdWxpZW4gR3JhbGwgPGp1bGllbkB4ZW4ub3JnPiB3cm90ZToNCj4+Pj4+IA0KPj4+Pj4gDQo+ Pj4+PiANCj4+Pj4+IE9uIDMxLzA4LzIwMjEgMTQ6MTcsIEJlcnRyYW5kIE1hcnF1aXMgd3JvdGU6 DQo+Pj4+Pj4gSGkgSnVsaWVuLA0KPj4+Pj4gDQo+Pj4+PiBIaSBCZXJ0cmFuZCwNCj4+Pj4+IA0K Pj4+Pj4+PiBPbiAyNyBBdWcgMjAyMSwgYXQgMTY6MDUsIEp1bGllbiBHcmFsbCA8anVsaWVuQHhl bi5vcmc+IHdyb3RlOg0KPj4+Pj4+PiANCj4+Pj4+Pj4gSGkgQmVydHJhbmQsDQo+Pj4+Pj4+IA0K Pj4+Pj4+PiBPbiAyNS8wOC8yMDIxIDE0OjE4LCBCZXJ0cmFuZCBNYXJxdWlzIHdyb3RlOg0KPj4+ Pj4+Pj4gU2FuaXRpemUgQ1RSX0VMMCB2YWx1ZSBiZXR3ZWVuIGNvcmVzLg0KPj4+Pj4+Pj4gSW4g bW9zdCBjYXNlcyBkaWZmZXJlbnQgdmFsdWVzIHdpbGwgdGFpbnQgWGVuIGJ1dCBpZiBkaWZmZXJl bnQNCj4+Pj4+Pj4+IGktY2FjaGUgcG9saWNpZXMgYXJlIGZvdW5kLCB3ZSBjaG9vc2UgdGhlIG9u ZSB3aGljaCB3aWxsIGJlIGNvbXBhdGlibGUNCj4+Pj4+Pj4+IGJldHdlZW4gYWxsIGNvcmVzIGlu IHRlcm1zIG9mIGludmFsaWRhdGlvbi9kYXRhIGNhY2hlIGZsdXNoaW5nIHN0cmF0ZWd5Lg0KPj4+ Pj4+PiANCj4+Pj4+Pj4gSSB1bmRlcnN0YW5kIHRoYXQgYWxsIHRoZSBDUFVzIGluIFhlbiBuZWVk cyB0byBhZ3JlZSBvbiB0aGUgY2FjaGUgZmx1c2ggc3RyYXRlZ3kuIEhvd2V2ZXIuLi4NCj4+Pj4+ Pj4gDQo+Pj4+Pj4+PiBJbiB0aGlzIGNhc2Ugd2UgbmVlZCB0byBhY3RpdmF0ZSB0aGUgVElEMiBi aXQgaW4gSENSIHRvIGVtdWxhdGUgdGhlDQo+Pj4+Pj4+PiBUQ1JfRUwwIHJlZ2lzdGVyIGZvciBn dWVzdHMuIFRoaXMgcGF0Y2ggaXMgbm90IGFjdGl2YXRpbmcgVElEMiBiaXQgYWxsDQo+Pj4+Pj4+ PiB0aGUgdGltZSB0byBsaW1pdCB0aGUgb3ZlcmhlYWQgd2hlbiBwb3NzaWJsZS4NCj4+Pj4+Pj4g DQo+Pj4+Pj4+IGFzIHdlIGRpc2N1c3NlZCBpbiBhbiBlYXJsaWVyIHZlcnNpb24sIGEgdkNQVSBp cyB1bmxpa2VseSAoYXQgbGVhc3QgaW4gc2hvcnQvbWVkaXVtKSB0byBiZSBhYmxlIG1vdmUgYWNy b3NzIHBDUFUgb2YgZGlmZmVyZW50IHR5cGUuIFNvIHRoZSB2Q1BVIHdvdWxkIGJlIHBpbm5lZCB0 byBhIHNldCBvZiBwQ1BVcy4gSU9XLCB0aGUgZ3Vlc3Qgd291bGQgaGF2ZSB0byBiZSBiaWcuTElU VExFIGF3YXJlIGFuZCB0aGVyZWZvcmUgd291bGQgYmUgYWJsZSB0byBkbyBpdHMgb3duIHN0cmF0 ZWd5IGRlY2lzaW9uLg0KPj4+Pj4+PiANCj4+Pj4+Pj4gU28gSSB0aGluayB3ZSBzaG91bGQgYmUg YWJsZSB0byBnZXQgYXdheSBmcm9tIHRyYXBwaW5ncyB0aGUgcmVnaXN0ZXJzLg0KPj4+Pj4+IEkg ZG8gYWdyZWUgdGhhdCB3ZSBzaG91bGQgYmUgYWJsZSB0byBnZXQgYXdheSBmcm9tIHRoYXQgaW4g dGhlIGxvbmcgdGVybSBvbmNlDQo+Pj4+Pj4gd2UgaGF2ZSBjcHVwb29scyBwcm9wZXJseSBzZXQg YnV0IHJpZ2h0IG5vdyB0aGlzIGlzIHRoZSBvbmx5IHdheSB0byBoYXZlDQo+Pj4+Pj4gc29tZXRo aW5nIHVzZWFibGUgKEkgd2lsbCBub3Qgc2F5IHJpZ2h0KS4NCj4+Pj4+PiBJIHdpbGwgd29yayBv biBmaW5kaW5nIGEgd2F5IHRvIHNldHVwIHByb3Blcmx5IGNwdXBvb2xzIChvciBzb21ldGhpbmcg ZWxzZSBhcw0KPj4+Pj4+IHdlIGRpc2N1c3NlZCBlYXJsaWVyKSBidXQgaW4gdGhlIHNob3J0IHRl cm0gSSB0aGluayB0aGlzIGlzIHRoZSBiZXN0IHdlIGNhbiBkby4NCj4+Pj4+IA0KPj4+Pj4gTXkg Y29uY2VybiBpcyB5b3UgYXJlIG1ha2luZyBsb29rIGxpa2UgWGVuIHdpbGwgYmUgYWJsZSB0byBk ZWFsIG5pY2VseSB3aXRoIGJpZy5MSVRUTEUgd2hlbiBpbiBmYWN0IHRoZXJlIGFyZSBhIGxvdCBt b3JlIHBvdGVudGlhbCBpc3N1ZSBieSBhbGxvdyBhIHZDUFUgbW92aW5nIGFjY3Jvc3MgcENQVSBv ZiBkaWZmZXJlbnQgdHlwZSAodGhlIGVycmF0YSBpcyBvbmUgZXhhbXBsZSkuDQo+Pj4+IA0KPj4+ PiBJIGFncmVlIGFuZCB0aGlzIGlzIHdoeSBYZW4gaXMgdGFpbnRlZC4NCj4+Pj4gDQo+Pj4+PiAN Cj4+Pj4+PiBBbiBvdGhlciBzb2x1dGlvbiB3b3VsZCBiZSB0byBkaXNjYXJkIHRoaXMgcGF0Y2gg ZnJvbSB0aGUgc2VyaWUgZm9yIG5vdyB1bnRpbA0KPj4+Pj4+IEkgaGF2ZSB3b3JrZWQgYSBwcm9w ZXIgc29sdXRpb24gZm9yIHRoaXMgY2FzZS4NCj4+Pj4+PiBTaG91bGQgd2UgZGlzY2FyZCBvciBt ZXJnZSBvciBkbyB5b3UgaGF2ZSBhbiBvdGhlciBpZGVhID8NCj4+Pj4+IFBsZWFzZSBjb3JyZWN0 IG1lIGlmIEkgYW0gd3JvbmcsIGF0IHRoZSBtb21lbnQsIGl0IGRvZXNuJ3QgbG9vayBsaWtlIHRo aXMgcGF0Y2ggd2lsbCBiZSBwYXJ0IG9mIHRoZSBsb25nZXIgcGxhbi4gSWYgc28sIHRoZW4gSSB0 aGluayBpdCBzaG91bGQgYmUgcGFya2VkIGZvciBub3cuDQo+Pj4+IA0KPj4+PiBOb3Qgc3VyZSBp dCBkZXBlbmRzIG9uIHdoYXQgdGhlIGZpbmFsIHNvbHV0aW9uIHdvdWxkIGJlIGJ1dCB0aGlzIGlz IGhpZ2hseSBwb3NzaWJsZSBJIGFncmVlLg0KPj4+PiANCj4+Pj4+IA0KPj4+Pj4gVGhpcyB3b3Vs ZCBhbHNvIGhhdmUgdGhlIGFkdmFudGFnZSB0byBhdm9pZCBzcGVuZGluZyB0b28gbXVjaCB0aW1l IG9uIHJlc29sdmluZyB0aGUgZW11bGF0aW9uIGlzc3VlIEkgbWVudGlvbmVkIGluIG15IHByZXZp b3VzIGFuc3dlci4NCj4+Pj4+IA0KPj4+Pj4gTm8gbmVlZCB0byByZXNlbmQgYSBuZXcgdmVyc2lv biBvZiB0aGlzIHNlcmllcyB5ZXQuIFlvdSBjYW4gd2FpdCB1bnRpbCB0aGUgcmVzdCBvZiB0aGUg c2VyaWVzIGdldCBtb3JlIGZlZWRiYWNrLg0KPj4+PiANCj4+Pj4gT2ssIEkgd2lsbCB3YWl0IGZv ciBmZWVkYmFjayBhbmQgbmV4dCBzZXJpZSB3aWxsIG5vdCBpbmNsdWRlIHRoaXMgcGF0Y2ggYW55 bW9yZS4NCj4+PiANCj4+PiBXb3VsZCBpdCBiZSB3b3J0aCBrZWVwaW5nIGp1c3QgdGhlIHBhcnQg dGhhdCBzYW5pdGl6ZXMgY3RyLCB3aXRob3V0IGFueQ0KPj4+IG9mIHRoZSBlbXVsYXRpb24gc3R1 ZmY/IFRoYXQgd2F5IHdlIGNvdWxkIHN0aWxsIGRldGVjdCBjYXNlcyB3aGVyZSB0aGVyZQ0KPj4+ IGlzIGEgbWlzbWF0Y2ggYmV0d2VlbiBDUFVzLCBwcmludCBhIHVzZWZ1bCBtZXNzYWdlIGFuZCB0 YWludCBYZW4uDQo+PiBUaGF04oCZcyBhIGdvb2QgaWRlYSwgaXQgbWVhbnMgcmVtb3ZpbmcgdGhl IGVtdWxhdGlvbiBwYXJ0IGFuZCBqdXN0IGtlZXAgdGhlIHNhbml0aXphdGlvbi4NCj4+IEBKdWxp ZW46IHdvdWxkIHlvdSBiZSBvayB3aXRoIHRoYXQgPw0KPiANCj4gSSBhY3R1YWxseSB0aG91Z2h0 IGFib3V0IHN1Z2dlc3RpbmcgaXQgYmVmb3JlIFN0ZWZhbm8gZGlkIGl0LiBTbyBJIGFtIE9LIHdp dGggdGhhdC4NCj4gDQo+PiBTaG91bGQgSSBzZW5kIGEgdjQgb3Igc2hvdWxkIHdlIHVzZSBTdGVm YW5v4oCZcyBwYXRjaCBkaXJlY3RseSBpbnN0ZWFkID8NCj4gDQo+IEkgd291bGQgc3VnZ2VzdCB0 byBzZW5kIGEgdjQuIFRoaXMgbmVlZHMgYSBzaWduZWQtb2ZmLWJ5IGZyb20gU3RlZmFubyBhbmQg YSBuZXcgY29tbWl0IG1lc3NhZ2UuDQoNCk9rIEkgd2lsbCBkbyB0aGF0IGJlZ2lubmluZyBvZiBu ZXh0IHdlZWsuDQoNCkNoZWVycw0KQmVydHJhbmQNCg0KPiANCj4gQ2hlZXJzLA0KPiANCj4gLS0g DQo+IEp1bGllbiBHcmFsbA0KDQo= From xen-devel-bounces@lists.xenproject.org Tue Sep 07 07:43:38 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 07:43:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180485.327147 (Exim 4.92) (envelope-from ) id 1mNVlW-0001x3-Ba; Tue, 07 Sep 2021 07:43:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180485.327147; Tue, 07 Sep 2021 07:43:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNVlW-0001ww-8H; Tue, 07 Sep 2021 07:43:34 +0000 Received: by outflank-mailman (input) for mailman id 180485; Tue, 07 Sep 2021 07:43:33 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNVlU-0001wq-R1 for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 07:43:33 +0000 Received: from mx0b-0039f301.pphosted.com (unknown [148.163.137.242]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 4b64b5a2-0faf-11ec-b0d9-12813bfff9fa; Tue, 07 Sep 2021 07:43:30 +0000 (UTC) Received: from pps.filterd (m0174680.ppops.net [127.0.0.1]) by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 1877hF5Q015024; Tue, 7 Sep 2021 07:43:26 GMT Received: from eur05-am6-obe.outbound.protection.outlook.com (mail-am6eur05lp2105.outbound.protection.outlook.com [104.47.18.105]) by mx0b-0039f301.pphosted.com with ESMTP id 3awxwj0rcr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 07 Sep 2021 07:43:26 +0000 Received: from AM7PR03MB6325.eurprd03.prod.outlook.com (2603:10a6:20b:13c::18) by AS8PR03MB7253.eurprd03.prod.outlook.com (2603:10a6:20b:2e8::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.22; Tue, 7 Sep 2021 07:43:24 +0000 Received: from AM7PR03MB6325.eurprd03.prod.outlook.com ([fe80::d9b7:c0ab:2c2f:5b44]) by AM7PR03MB6325.eurprd03.prod.outlook.com ([fe80::d9b7:c0ab:2c2f:5b44%3]) with mapi id 15.20.4478.025; Tue, 7 Sep 2021 07:43:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4b64b5a2-0faf-11ec-b0d9-12813bfff9fa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HuUhm10ZF3UHBEcJP/PqxNGPc81E9ery6yQihapkOwESeMehOhQdYDMMaK3PpUBnMnFGwPD38p9cgKIDnjlblVr79iu8cSmBDvPfcwQWQZbySbW2D/t4NvrDh9UUfA/ojk2Mz35CTGSQ/qIT7GMztwO8alvq8a0miZKdlbtuhBF62RLXUK/M02xj6bUaD4rq+R67xbhNdELJU9EHDXtqNhAj6yGHvcn6p7SbrcdveHM3NjUiOkw192bpeSOylYsbjHNv4G8FheLOwsWJs4JKcKuPiaY1aAxu96O/ExZ4i1nmcsuBsWNJ8iwwB3Emevy8J1GEc+d+1XkNTUXkHHnnbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=H05GsjdJnDqyBr0UhP6j4Tyahjtcs2/I/LUt2RtCWRM=; b=UDiDSFZJ2FzFCuCb+IdodVoJGV7fxWUsHvOiJ3ULHlmJKTPdNCaG6IYfs7ASb2zufAfxMqerGFWTVIanLiBaSWP1n44c28m/KjDvRNdaZIqRsjZPUBTQxT7e0+dK8livQOBs29d1vHi62WzIF6hFpU0Qe3qYyTACB0MGT38xyVWJcERFlbzqZqQDL/Av9w67jaFtRyX1rPleknjqW5TBhQ64R5FmMEhsWUmHCdcGCM34qeEbSIdUN8QqjqGP7zD0UmhplSCMK2lZubHbIBYDSwUo8TmqlIgNmt5Ip6KSEeXKmZbUetvXtiiKQq+jCEoe+Q+0fujRwTv4GhwEruB2xA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=H05GsjdJnDqyBr0UhP6j4Tyahjtcs2/I/LUt2RtCWRM=; b=EdMKpoIjkmB7owIiFFYVf3i+z0xjp4CtJ5cxcOWHrBQJcJJe2+KoA9mgqhHL1nvKb3AnKsjEWhVSEO6ydChFirbSvHILkwMsDzroijKPD1mNfWafSwEKbqSD6cMCt+5RR7klpCxMUxxRRPaBTEEIzf6+vPGDRflVuPnBM/kqmfLO2cRQM25WOy5M41oT4dL0YM9KZg/TgXW1oREVkbiBf5f6uSWOS2UkaShj+Hu2BJutjXE+c+ATLfbxR2/6JHHC5IfuDh2uD+/KVwUXkIRwJGjtM/7IxBNAi8Uo4Xq8Z25+RdGJ+L0X3wrS69lXYsjffP+lh+9LSbcDXF1ShEHtTg== From: Oleksandr Andrushchenko To: Jan Beulich , Oleksandr Andrushchenko CC: "julien@xen.org" , "sstabellini@kernel.org" , Oleksandr Tyshchenko , Volodymyr Babchuk , Artem Mygaiev , "roger.pau@citrix.com" , Bertrand Marquis , Rahul Singh , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH 8/9] vpci/header: Reset the command register when adding devices Thread-Topic: [PATCH 8/9] vpci/header: Reset the command register when adding devices Thread-Index: AQHXoKxjFI8WSqpeJkWkpzZfft/zi6uXHR6AgAEZm4A= Date: Tue, 7 Sep 2021 07:43:24 +0000 Message-ID: <5366265c-d169-041d-f812-1c49260f6499@epam.com> References: <20210903100831.177748-1-andr2000@gmail.com> <20210903100831.177748-9-andr2000@gmail.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=epam.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 855fbb1c-f7c5-4b94-e44a-08d971d32c20 x-ms-traffictypediagnostic: AS8PR03MB7253: x-ms-exchange-transport-forked: True x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 0gSKp3SZyqf4i9b9Ftv/HqXkJf/TT6ZrvgOFkhmR9Ok/p4yVDT+j5fhUfUds/RZfS4n1FBtRaEuTTV4/eAs2X9gbCs1reNIFvbKZGZBcTLRJ5BlxSo7aT1+L5KPo/zcEseLbSmB+BnGWaI6AnuxxdTi7vLR64XhalPBqWdBUg2hhQIKKoJ5j3Km3jykXSreyL5EKeT6g4eObrrcKjRZ0vVvjLzooeV5egrw4jt40YvghjuCqT3XKok0O96aM3TrJvKJDd5praZadegWclnbU3aDt/G52rVtBrpHyL7gryJFBR/GtJSAn1e0sfev+UFbIy0RG1PPq0qy98LvBAGbzDP2YkmLlvprhooZCaplVFStzpWiBCFMepg/RPF+XqdwOZuktcERUi34Uv/ASEWDL4NoxeXm+/My/TrjobXL13/w9ZiUUp1CRGtBlJEFBSFzfqOvsckR4gUvFWTFjXhmxFPNQrCZnsbe0103jSPnvKYxFbp2E8SMGDPwtR/u3m2a4eik8VPDgDwh/z+1xSNcQAGBVDyNwAUABV7lGxq/UFzMRLYWqJEvexRkTzLlWuT85bFFhRRPiZEZhpDksZQAegdzKLwTLYaechlQK6AuYEUkNI1kAWaqDosMGsO6skJaf2R1WfSX9bsjiBZ9heDv6rgTUkp+JwB7S3dv1sdhyK6qkgCz4rFrAdlQkx8rp+1VyUwtZBLhPMjFsAeNFoEa/cdd7uceYqICnocP4py9FfZgS5HWIy0kn9AeKl7Q1LvV4 x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM7PR03MB6325.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(136003)(376002)(39860400002)(366004)(396003)(346002)(31686004)(38100700002)(122000001)(31696002)(316002)(4326008)(26005)(71200400001)(86362001)(66446008)(66476007)(66946007)(66556008)(64756008)(5660300002)(8676002)(186003)(8936002)(38070700005)(91956017)(83380400001)(76116006)(36756003)(54906003)(110136005)(6506007)(53546011)(2906002)(6512007)(6486002)(2616005)(478600001)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?RlVXRmorMW9UMzQ5SDh5SGtNVGQxc2huY2tabk1NSTB2aXJEZkdSbXR3NjJk?= =?utf-8?B?M0c3QXloSW93Q3ZVVGhBRlc3cFNXS25rczQwbHEvNGxnenFhME03TmIycUVE?= =?utf-8?B?bHJNSkNScXNKcm56SnJ1REpsRHpXWkNNNDJEcHJYdHVpdjgzNEoweEhiQ2pF?= =?utf-8?B?K2t5Y0ZVN1FNWlR0M1ZvWXNxa0VCUFg1ZFQ4V1hPbUQ2eEdpZmYrNmJZc2Fo?= =?utf-8?B?bFRtSFozRzJ5K3g3eEVTTUgwNHU3NU1sYTNlMHBhWFF1aXprbU5VRko3R2ZV?= =?utf-8?B?cGRDTDk3RGdmVUszb3pzZGEvS3NrNm1vNnlkdldKR0JGQjRQeEhRc25TVWpx?= =?utf-8?B?cGVqWGR1NklmUzVUUXdMeGNBSFRoZXRJRGpXUjhKUkNWbkQyeGN5RUxTblV1?= =?utf-8?B?bnVTUXY2dUkxaERycTBwaGZJYXp4SEVOVUlHZy9wWk0xOEZxditrSE5aS2d6?= =?utf-8?B?RVRxS1FzK1UxWXkxSFhiaE5aWVNURGZFbDRIb09DQmVGMHJsZno4Zmw2aVR2?= =?utf-8?B?dWZZNVlXTnBkUE5qNnRNcEFPWHQ2R3YzclZWT0EreXhnZmtpWUd6c04yL085?= =?utf-8?B?bzM4RUlDcm1lZE9DMmlIWGJFOGdoaUhXWWMxNFE4aWxJQnArRXJYOWk3b05M?= =?utf-8?B?Y2lRUTNlYkJacmFqRE43bXJoaXIxSEphcE9BeU1iK01IRnlsdThNaTBIeXdV?= =?utf-8?B?aGZpSHlRVnNFYktlV3E4ZERFSFZpeWFDOWN1eE5ESHhnZkhFVkVyTk1ZVk5o?= =?utf-8?B?SDZxMGFPeFE1a0JMVFZRRjZCNkRlNkxzWkU4Q3ZvdUcvYlRhQU9FMlZZWkZo?= =?utf-8?B?ZHptMTFuRHRnK1YwMkVVQlYvNTZIWjdzMk1nR1pKQUVydFgrTFh1REFXMkVn?= =?utf-8?B?VGx3SWxsQUtTWTlRNlJIdDNZdVIvVEVGTjBtNHhqUEN0Z3Y3ZUxzRVI0eFlo?= =?utf-8?B?VlFNKzRaUTZlL0crQWZLME5iQStDdEd5M1EvU2NZMHlvTHQwZkNXSE5odWor?= =?utf-8?B?dExmM09GZUVTY0ZWcTMzc2tyN2JoSm1jbzI2em54alJOVzRtZmNIRFlLZitD?= =?utf-8?B?UDVYMlJqVU9NU2lRc0FDMWU5ZkNqVDhaQjRSMmlkNkluZHliL29nZU10WGth?= =?utf-8?B?bDZBQzZieGhERmpTeUtBUUJuT2EyOW9sMWVNeStWTDR3cFNQeGVYTE1JaWw3?= =?utf-8?B?d21NSmdIbS9wbFU1TGcvWS9kdCt3S1FZSk91c0lkbzk3TFNvU1lVOTM5bFZ4?= =?utf-8?B?NXBXODQ2RWh1Z3ZhMWtFOWQ1K3dNM2JFUkJMMk9GcFRteWs4WERlNW1lc25C?= =?utf-8?B?TVlRQlJSdjVMSmhHWVl6K05UeUc4d1BIbnB4eGVodDdJU0VJQkViY1ZFUHNL?= =?utf-8?B?MGxFZnQvZ3dMcjZ6V2NYT1VCdHNpOXdaMjZ3ODlueUcvalpHUElwWlUwSEJ6?= =?utf-8?B?NStOcGltQ1pKTzcwNjNVTEFNdWc2RDhVaU5TWEJycm9rTWE0UFM2TXhQRFZM?= =?utf-8?B?eGt3S3U0RzZVb2QrV0JsazRXWG8zeitBa1JjdHAzK1NUVGxqZzZMcFYvNmZy?= =?utf-8?B?MUJpaTdxcDNTd016TFhSb212eDNnY2h4QVNnK2xDNnNRTUdtMEEzV3NOcTFk?= =?utf-8?B?ck91R25xM1NPWDJVM0VrS1VpYUJ4SnEyR2NMZTVhRjBvREx2Zi9IOTczdFRX?= =?utf-8?B?Y09PWDFUOEphODROTEYyYVhhaDBUR3g0bVpibWlrQkdjOTlsOXhSK1Bic3Nu?= =?utf-8?Q?lWLyuD2YC5/FHXevnxaItcQsJm6Ik1g5iT+nZ4M?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: epam.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM7PR03MB6325.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 855fbb1c-f7c5-4b94-e44a-08d971d32c20 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Sep 2021 07:43:24.1350 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: kP4aR03bofpX5KhR0/sT1U4h/5/gUw9XaTG3NwTKInipxfNjda43jPU/zSuPIHNz3kJFZZ/R5AWroRU2NqTkzh3BOw2WFi375LYUisZHA23uLplUxC7mPt9/p/z6ho9V X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR03MB7253 X-Proofpoint-ORIG-GUID: ws8YyR2UnlOfJ03RvriM9lie45fON0yU X-Proofpoint-GUID: ws8YyR2UnlOfJ03RvriM9lie45fON0yU X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.391,FMLib:17.0.607.475 definitions=2021-09-07_02,2021-09-03_01,2020-04-07_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 suspectscore=0 mlxscore=0 priorityscore=1501 malwarescore=0 mlxlogscore=782 clxscore=1015 impostorscore=0 lowpriorityscore=0 spamscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2108310000 definitions=main-2109070051 DQpPbiAwNi4wOS4yMSAxNzo1NSwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDAzLjA5LjIwMjEg MTI6MDgsIE9sZWtzYW5kciBBbmRydXNoY2hlbmtvIHdyb3RlOg0KPj4gLS0tIGEveGVuL2RyaXZl cnMvdnBjaS9oZWFkZXIuYw0KPj4gKysrIGIveGVuL2RyaXZlcnMvdnBjaS9oZWFkZXIuYw0KPj4g QEAgLTgxMSw2ICs4MTEsMTYgQEAgaW50IHZwY2lfYmFyX2FkZF9oYW5kbGVycyhjb25zdCBzdHJ1 Y3QgZG9tYWluICpkLCBzdHJ1Y3QgcGNpX2RldiAqcGRldikNCj4+ICAgICAgICAgICBncHJpbnRr KFhFTkxPR19FUlIsDQo+PiAgICAgICAgICAgICAgICIlcHA6IGZhaWxlZCB0byBhZGQgQkFSIGhh bmRsZXJzIGZvciBkb20lZFxuIiwgJnBkZXYtPnNiZGYsDQo+PiAgICAgICAgICAgICAgIGQtPmRv bWFpbl9pZCk7DQo+PiArDQo+PiArICAgIC8qDQo+PiArICAgICAqIFJlc2V0IHRoZSBjb21tYW5k IHJlZ2lzdGVyOiBpdCBpcyBwb3NzaWJsZSB0aGF0IHdoZW4gcGFzc2luZw0KPj4gKyAgICAgKiB0 aHJvdWdoIGEgUENJIGRldmljZSBpdHMgbWVtb3J5IGRlY29kaW5nIGJpdHMgaW4gdGhlIGNvbW1h bmQNCj4+ICsgICAgICogcmVnaXN0ZXIgYXJlIGFscmVhZHkgc2V0LiBUaHVzLCBhIGd1ZXN0IE9T IG1heSBub3Qgd3JpdGUgdG8gdGhlDQo+PiArICAgICAqIGNvbW1hbmQgcmVnaXN0ZXIgdG8gdXBk YXRlIG1lbW9yeSBkZWNvZGluZywgc28gZ3Vlc3QgbWFwcGluZ3MNCj4+ICsgICAgICogKGd1ZXN0 J3MgdmlldyBvZiB0aGUgQkFScykgYXJlIGxlZnQgbm90IHVwZGF0ZWQuDQo+PiArICAgICAqLw0K Pj4gKyAgICBwY2lfY29uZl93cml0ZTE2KHBkZXYtPnNiZGYsIFBDSV9DT01NQU5ELCAwKTsNCj4g Q2FuIHlvdSByZWFsbHkgYmxpbmRseSB3cml0ZSAwIGhlcmU/IFdoYXQgYWJvdXQgYml0cyB0aGF0 IGhhdmUgdG8gYmUNCj4gdW5kZXIgaG9zdCBjb250cm9sLCBlLmcuIElOVFhfRElTQUJMRT8gSSBj YW4gc2VlIHRoYXQgeW91IG1heSB3YW50IHRvDQo+IGhhbmQgb2ZmIHdpdGggSS9PIGFuZCBtZW1v cnkgZGVjb2Rpbmcgb2ZmIGFuZCBidXMgbWFzdGVyaW5nIGRpc2FibGVkLA0KPiBidXQgZm9yIGV2 ZXJ5IG90aGVyIGJpdCAoaW5jbHVkaW5nIHJlc2VydmVkIG9uZXMpIEknZCBleHBlY3Qgc2VwYXJh dGUNCj4ganVzdGlmaWNhdGlvbiAoaW4gdGhlIGNvbW1pdCBtZXNzYWdlKS4NCkFjY29yZGluZyB0 byAiUENJIExPQ0FMIEJVUyBTUEVDSUZJQ0FUSU9OLCBSRVYuIDMuMCIgSSBoYXZlIGF0IGhhbmQs DQpzZWN0aW9uICI2LjIuMiBEZXZpY2UgQ29udHJvbCIgc2F5cyB0aGF0IHRoZSByZXNldCBzdGF0 ZSBvZiB0aGUgY29tbWFuZA0KcmVnaXN0ZXIgaXMgdHlwaWNhbGx5IDAsIHNvIHRoaXMgaXMgd2h5 IEkgY2hvc2UgdG8gd3JpdGUgMCBoZXJlLCBlLmcuDQptYWtlIHRoZSBjb21tYW5kIHJlZ2lzdGVy IGFzIGlmIGl0IGlzIGFmdGVyIHRoZSByZXNldC4NCg0KV2l0aCByZXNwZWN0IHRvIGhvc3QgY29u dHJvbDogd2UgY3VycmVudGx5IGRvIG5vdCByZWFsbHkgZW11bGF0ZSBjb21tYW5kDQpyZWdpc3Rl ciB3aGljaCBwcm9iYWJseSB3YXMgb2sgZm9yIHg4NiBQVkggRG9tMCBhbmQgdGhpcyBtaWdodCBu b3QgYmUgdGhlDQpjYXNlIG5vdyBhcyB3ZSBhZGQgRG9tVSdzLiBUaGF0IGJlaW5nIHNhaWQ6IGlu IG15IGltcGxlbWVudGF0aW9uIGd1ZXN0IGNhbg0KYWx0ZXIgY29tbWFuZCByZWdpc3RlciBhcyBp dCB3YW50cyB3aXRob3V0IHJlc3RyaWN0aW9ucy4NCklmIHdlIHNlZSBpdCBkb2VzIG5lZWQgcHJv cGVyIGVtdWxhdGlvbiB0aGVuIHdlIHdvdWxkIG5lZWQgYWRkaW5nIHRoYXQgYXMNCndlbGwgKGlz IG5vdCBwYXJ0IG9mIHRoaXMgc2VyaWVzIHRob3VnaCkuDQoNCk1lYW53aGlsZSwgSSBhZ3JlZSB0 aGF0IHdlIGNhbiBvbmx5IHJlc2V0IElPIHNwYWNlLCBtZW1vcnkgc3BhY2UgYW5kIGJ1cw0KbWFz dGVyIGJpdHMgYW5kIGxlYXZlIHRoZSByZXN0IHVudG91Y2hlZC4gQnV0IGFnYWluLCB3aXRob3V0 IHByb3BlciBjb21tYW5kDQpyZWdpc3RlciBlbXVsYXRpb24gZ3Vlc3RzIGNhbiBzdGlsbCBzZXQg d2hhdCB0aGV5IHdhbnQuDQoNCg0KUGxlYXNlIGxldCBtZSBrbm93IHlvdXIgb3BpbmlvbiBvbiBo b3cgd2UgY2FuIHByb2NlZWQuDQoNCj4NCj4gSmFuDQo+DQpUaGFuayB5b3UsDQoNCk9sZWtzYW5k cg0K From xen-devel-bounces@lists.xenproject.org Tue Sep 07 07:47:04 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 07:47:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180527.327226 (Exim 4.92) (envelope-from ) id 1mNVot-0003P2-Ks; Tue, 07 Sep 2021 07:47:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180527.327226; Tue, 07 Sep 2021 07:47:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNVot-0003Ov-Gv; Tue, 07 Sep 2021 07:47:03 +0000 Received: by outflank-mailman (input) for mailman id 180527; Tue, 07 Sep 2021 07:47:02 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNVos-0003Op-DW for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 07:47:02 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 1e6f59a7-31cc-42c9-b7fd-e76f51f3e32c; Tue, 07 Sep 2021 07:47:01 +0000 (UTC) Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-he1eur02lp2054.outbound.protection.outlook.com [104.47.5.54]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-33-9m-ODolLOeKbciDOBV25xQ-1; Tue, 07 Sep 2021 09:46:59 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR04MB5599.eurprd04.prod.outlook.com (2603:10a6:803:de::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.20; Tue, 7 Sep 2021 07:46:57 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4500.014; Tue, 7 Sep 2021 07:46:57 +0000 Received: from [10.156.60.236] (37.24.206.209) by PR0P264CA0090.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:18::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14 via Frontend Transport; Tue, 7 Sep 2021 07:46:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1e6f59a7-31cc-42c9-b7fd-e76f51f3e32c DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1631000820; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=89Wcxu97YlBjEmvf+rIXeD4kJNc16BNfojpE+slgxM8=; b=VsBQjFhjEZ8Od2Ywenq/rvsk+tign6RYfhR5/rWsKzXR/nNSgwCW3IsR64mGdCWQjOyLmX JJCVR6w3gywpd1dN+4dlaEfMLsxvhPLq+1BC1IoaVOQMEXuVSkyJTD3YicLgxfMA+Jq1A4 4RDfMou8mWcouJFRxlcYZMwT/S4eON4= X-MC-Unique: 9m-ODolLOeKbciDOBV25xQ-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kZHNJIy7H3pI1z1hzTSmbsVUvLU+kwiHA/zEsPFOx+wlQCW/2GCQ3sZbpJVf6Jg+gCTvrfQJBVs5uQYEIOM8kDp0fEUBTl9hM2dJ1T5sfgFHNPWJFZIo3TFAJh8FS8btcxwXgwWFr7PhbElUld7aQlhRTVJEnact7n8zLhtVPiQwlAkkkT1laO3uIikrN/bce5XgRDsUzmHPh1RuGSEJEztVkgTo+FASZwKj38DW2ZwAlMQqMsfytzN/4BfxpKQ0SKFvV7fiIKANxNdtGUH7keT2v0PKHteD/orDNdj+/On/+RYkg0VwwIp7I3umGs8UJ75q9M8HJChdUYM8fv3aSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=89Wcxu97YlBjEmvf+rIXeD4kJNc16BNfojpE+slgxM8=; b=OSz7iR0XVgfTPztoWg4KWq66VC/+YfFIMjBzN9XrVHg5VqwpzybP1j8HhE1qOR5WGCZM9RH3sz+0lO6HrWW4KXr+gAN4p8zkf67LhRXiLahtmSe8aJMbf1qh++FWvC7BXD0l68l6mIWfLxUw7yfCX8wJWAhA435myEPzJwLjvD9Fqe/+5Per/Ah4ePOJ4uCKnyJ5f+qLBbCfa6aFoJ4E6D5hnDrblnHiYdLzZcsn72VQCdx8fmEv23yiAY0wzozYRAhwUZUbdslZog9ZCDDffA9NGoP9+q90Zh1vr7Y6yJBgiOo/7FPiXGxnXk5Nb3ZvPsXsKI2uCgnKJRAGynGzxw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com; Subject: Re: [XEN PATCH v7 00/51] xen: Build system improvements, now with out-of-tree build! To: Anthony PERARD Cc: xen-devel@lists.xenproject.org References: <20210824105038.1257926-1-anthony.perard@citrix.com> From: Jan Beulich Message-ID: <8d23409c-8334-b507-082d-9d6472b9d8d2@suse.com> Date: Tue, 7 Sep 2021 09:46:55 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PR0P264CA0090.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:18::30) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 89f6afc9-8405-4d3f-0aef-08d971d3ab5e X-MS-TrafficTypeDiagnostic: VI1PR04MB5599: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:3383; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1q1CH1tPWWM+nD0vnOByfWeK/W47qo9JrPg2EudA3uFHUURNtt/HycTuRlsl//OBLd/L1NKxB2QFvaPk4PwJKgZ+avi/KpZheESy+nmyYulUXccFRD0rzK/vrRbPntEDLE51YPc8To5+3FhpWX836uueK74zmwx9ltzX99PAeeTQmUXzN58Lm48fHo8XiyMdbGOEqnO5mHD18Y5RsW63nAAxLKeV3bR/aUQgfEV+k1mNEtSEcynXxl1XQqYg7It1oAB6oCXwtCtwKyPq3hGz1xVf80DWOh5YtC3MQq80001RJl5jH5Rm6Rv4YakBKm7/NQmwOWjy27kD8rTHH0L7SVfaAfegELRRdX8NU9Px9SUyM/mm2CRMuzcACqujOudAM17yUtvpqfzc/0rZ6PaiGNnp0TcEjW3cRu3WGGzkuf7kP+4ls0LoccabQCaZneSAVWil18vsBZL3f2ZeMa5eiaNEPoqVYwHxe+Uff4p/4/b6mC3lSlgrKN3mZtBiGf3FvOCJo9NARGoKuhjtZPu2UcwPZaT07u27heDfRE4kMrhyb4P8DewlZWawqGzUVHXyxPlFId9mQxVzUdi1V7calyfzrDiROLqNDBFoMaAb/olXjp4W1uUA/1vfWy2LTVcIPSterxUNzlCsWh8S62tU7+hcFtZeQgbHWJ4nlG0fTj1U5XS/hZBQWFkQfh6SO4vVZughFVDES5DjXzlCSWqmy9Hxka2kf82tDY9Y8ftmnLuy554I/V2QIMQoBemPyb0V X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(346002)(39860400002)(136003)(376002)(366004)(396003)(66476007)(66556008)(186003)(53546011)(6916009)(5660300002)(38100700002)(478600001)(4326008)(6486002)(31686004)(66946007)(16576012)(956004)(8676002)(86362001)(4744005)(36756003)(2616005)(31696002)(316002)(26005)(2906002)(8936002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?U3BqQjJTVWVnL3JjU0RScFFtN1RBTVk3SGxsdlhvOFVrc3A1THByVlBvd2ZQ?= =?utf-8?B?eDlIVzdjQXQxSlEyNjRmZmpvVk45NG9Ld0VzQ1FWNXhHSmF3ZFR4ekFuRk93?= =?utf-8?B?ZFRSWE5HMkswN2IvbC9vQWhzbEt3R3FsZ3VsTHRERkNSUWNaMTdUVG42QUty?= =?utf-8?B?dGIrWlliYndTYWhkcWk2SERJYWZrQnZ4Z2Zrb2dOczZnd2Y4M3MvQjZlRE82?= =?utf-8?B?SkZoTUJrSlE3RDRiaEpoVFpMeExrYndML0p0ZHFENTlPa1lzQ2dnVENFZjNF?= =?utf-8?B?bVUxR2MydEhoalpUYzNxUU9SN3RvME5CK0hyWGZLczhHZlBiWFFUdEtMMDRF?= =?utf-8?B?cnpLVFZydTZMV1FGR0QrcTdib1gwTmJNU3V0a3lpeVJuUUhmWmpCM1dGTld0?= =?utf-8?B?NUhuV0xHUGZPWGp3L2FSL1BMNEVCbDVXUCtsN3E2azh6VDZDUFpSN0wwQzRJ?= =?utf-8?B?T1FZcU1mZnJ5amdtM1JTQ0pHZXNWZDg4VGNxUGkzeHpWYkxoS1pOMHViTldz?= =?utf-8?B?L1ZvcTBJTUIreHR5ZCt6RXJTamNEWjRwa1M1WUZSTElLU1VEZ2Mrb0hadkVi?= =?utf-8?B?VW9CL011SmV2TFh1ZG9ZZDZXZ015c01VSmNWNnBBM1FPWCtiazQwbGgrQTZl?= =?utf-8?B?ei9qcTNNdXd0bWJPSEJRei9vd3JRT2IycmpOdkVZMTNEQzRWOGxDa3JiY1dr?= =?utf-8?B?aEw5SXRqYUFtV3lQYlU5bWs3aURJdUMwcUI4TXhhd0YwR1AvSkNjOTVaNkgx?= =?utf-8?B?VExDSVFVUUMrQkZxZWs3Rm95eFNWUm1QMU9sOHMzYkFQc0xHam9FRk1iNndu?= =?utf-8?B?SU5xclV3V1MyZzBkMjAyUlk2YmFsemhCNFB4TUdnR3BUL1Q4R1pBYytaOUtB?= =?utf-8?B?Q29vSHFPZXY2dWRJVmptSlNaMEtkMTltVUdHMGFHR2JqeUx3TUFZOTJURndh?= =?utf-8?B?NWh1SUVjYW5uTHhYZW9TMlNUN3kvRzZ3QWM1RjNkZ0Y2WWlJVVNlVFJ5b284?= =?utf-8?B?am5pbDFGZWhQZkVMNUpRdTJRVVVhbklsR2svZmFzWnE0VXhMdnpuQnltOS8v?= =?utf-8?B?azVjQXNGcFBGdUFkMk9rdWhqM0Fnd0tZMFQxUGJaV3NYQUlhbkxFQmNxenJI?= =?utf-8?B?UnhEbk1ZdWVpRXA2a1QrSXVLUjdzc2FWeXlTRnAyQlJwZnphcTNvbW5jZ2tJ?= =?utf-8?B?dnlSNjgrUXNBcTlNRDEyZ1REelZYNlRmUWN5OE5icVQrWnBjaUI5TzJsc2VW?= =?utf-8?B?NytsYnNmNjRiRE1NcXhiR0Zjamc2dXNkNFV1OWVnMHdVUnF1M3BOY1hMa1hU?= =?utf-8?B?NHJFMzFqVEZFc1FIUE56QTRkTUw1TUROSFhUY3lraTU4UmVoVURrRm5JVDZx?= =?utf-8?B?anJ2RCtVTnMwOURMNExpOFdSaTN5ZEErNjEwTXVSNFVwV0hST1Fkc0tlWVBa?= =?utf-8?B?M0x4M1E2aHF6NGJSN3lIWTZNT1c3YjZKTjNyWDNHUWdZQVI0WW54S0gyemRU?= =?utf-8?B?VWpxYTFMMktKcXBXS1psRlpRcFZ2Nks2RVNqRXhtVkNDZXhxMGdyajlwWm0r?= =?utf-8?B?RjEyd0ZOWmhZS2VkWUhQMUFORWdlN1p4Nm54ajRpN1ZoR1dYeWJQV1VLcjlB?= =?utf-8?B?eERDUTVHZFUyb29FNFl6b0xQSnFqTzZwRkMrcUtPK0I2VUpLU2poVjBoejdX?= =?utf-8?B?MzFmUkJROU45R0ExNmFOc3dXZUZrVEtNZEppNXhwbkY4M1BCcEtWN3pyODF5?= =?utf-8?Q?7g5pPFfWcuEg/9f6CQDvX2ZIOOxAMnkmAUqJ3NT?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 89f6afc9-8405-4d3f-0aef-08d971d3ab5e X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2021 07:46:57.8010 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bq0+wk9JkVdWlN4fYuHfeGwnQaTanIiuPI3zBO8eMrUdGjemly0v4qnNyaq0uAGUR6NsVBfkNyydNnH1Tk4KKQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5599 On 06.09.2021 18:13, Anthony PERARD wrote: > On Tue, Aug 24, 2021 at 11:49:47AM +0100, Anthony PERARD wrote: >> build,arm: move LDFLAGS change to arch.mk > need edit commit description, but otherwise ready > not needed before [PATCH 21/51] build: set ALL_OBJS to main Makefile; move prelink.o to main Makefile While you did indicate you'd be fine with Julien's suggested edit, he did indicate he would take care of this Arm specific change, so I've left it out. >> build: move make option changes check earlier >> build: avoid building arm/arm/*/head.o twice > both ready The latter didn't apply cleanly for me; I didn't go look specifically why that might have been. Jan From xen-devel-bounces@lists.xenproject.org Tue Sep 07 07:59:02 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 07:59:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180534.327236 (Exim 4.92) (envelope-from ) id 1mNW0O-00059a-LJ; Tue, 07 Sep 2021 07:58:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180534.327236; Tue, 07 Sep 2021 07:58:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNW0O-00059T-ID; Tue, 07 Sep 2021 07:58:56 +0000 Received: by outflank-mailman (input) for mailman id 180534; Tue, 07 Sep 2021 07:58:55 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNW0N-00059N-Af for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 07:58:55 +0000 Received: from smtp-out2.suse.de (unknown [195.135.220.29]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id ed1a5942-98c0-438d-aaa1-09e80813426e; Tue, 07 Sep 2021 07:58:54 +0000 (UTC) Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 2B7291FD3E; Tue, 7 Sep 2021 07:58:53 +0000 (UTC) Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap1.suse-dmz.suse.de (Postfix) with ESMTPS id 035A1132AB; Tue, 7 Sep 2021 07:58:52 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap1.suse-dmz.suse.de with ESMTPSA id ziGrOrwbN2GhGQAAGKfGzw (envelope-from ); Tue, 07 Sep 2021 07:58:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ed1a5942-98c0-438d-aaa1-09e80813426e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1631001533; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=AMcdZLNTncTH+Yy7z6MnCAdXPsgZXnKDxbbM9Ifr0u0=; b=PxeXKKp54XMGPMbkcv7Vx+UZCB2T09V8TQYm2L5sIV+Pxaf8MTDIomVJLReoZltvA0v5TT z4t+q4ijLQK5eWxnBIBTAdxczNQOGajPDXh+xmWjFLsKdH2cGArE1hXJdSKkuw8GdL0+Dh AAzZycC4rnOZt/IhRR4A9yx9jtcpvCk= To: Sander Eikelenboom , "xen-devel@lists.xenproject.org" References: <9c36205e-cc37-ed9a-3408-0cccc4a83115@eikelenboom.it> From: Juergen Gross Subject: Re: xen-unstable linux-5.14: 1 of 2 multicall(s) failed: cpu 0 Message-ID: <0ae9bb1e-dacc-a3d2-ed90-f85cb52c698d@suse.com> Date: Tue, 7 Sep 2021 09:58:52 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <9c36205e-cc37-ed9a-3408-0cccc4a83115@eikelenboom.it> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="nkepnofagqj0Zs3mMsn1mbJe64GyvUYdo" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --nkepnofagqj0Zs3mMsn1mbJe64GyvUYdo Content-Type: multipart/mixed; boundary="8M0QKdzDc7d04oORWPj6gBj8yDHBPi3So"; protected-headers="v1" From: Juergen Gross To: Sander Eikelenboom , "xen-devel@lists.xenproject.org" Message-ID: <0ae9bb1e-dacc-a3d2-ed90-f85cb52c698d@suse.com> Subject: Re: xen-unstable linux-5.14: 1 of 2 multicall(s) failed: cpu 0 References: <9c36205e-cc37-ed9a-3408-0cccc4a83115@eikelenboom.it> In-Reply-To: <9c36205e-cc37-ed9a-3408-0cccc4a83115@eikelenboom.it> --8M0QKdzDc7d04oORWPj6gBj8yDHBPi3So Content-Type: multipart/mixed; boundary="------------26F5A7C1DA5D359581D4BECD" Content-Language: en-US This is a multi-part message in MIME format. --------------26F5A7C1DA5D359581D4BECD Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 06.09.21 23:35, Sander Eikelenboom wrote: > L.S., >=20 > On my AMD box running: > =C2=A0=C2=A0=C2=A0 xen-unstable changeset: Fri Sep 3 15:10:43 2021 +02= 00 git:2d4978ead4 > =C2=A0=C2=A0=C2=A0 linux kernel: 5.14.1 >=20 > With this setup I'm encountering some issues in dom0, see below. >=20 > --=20 > Sander >=20 > xl dmesg gives: >=20 > (XEN) [2021-09-06 18:15:04.089] mm.c:3506:d0v0 mfn 63b936 already pinne= d > (XEN) [2021-09-06 18:15:04.089] mm.c:3506:d0v0 mfn 6a0622 already pinne= d > (XEN) [2021-09-06 18:15:04.089] mm.c:3506:d0v0 mfn 6b63da already pinne= d > (XEN) [2021-09-06 18:15:04.089] mm.c:3506:d0v0 mfn 638dd9 already pinne= d > (XEN) [2021-09-06 18:15:04.089] mm.c:3506:d0v0 mfn 68a7bc already pinne= d > (XEN) [2021-09-06 18:15:04.089] mm.c:3506:d0v0 mfn 63c27d already pinne= d > (XEN) [2021-09-06 18:15:04.089] mm.c:3506:d0v0 mfn 6a04f2 already pinne= d > (XEN) [2021-09-06 18:15:04.089] mm.c:3506:d0v0 mfn 690d49 already pinne= d > (XEN) [2021-09-06 18:15:04.089] mm.c:3506:d0v0 mfn 6959a0 already pinne= d > (XEN) [2021-09-06 18:15:04.089] mm.c:3506:d0v0 mfn 6a055e already pinne= d > (XEN) [2021-09-06 18:15:04.090] mm.c:3506:d0v0 mfn 639437 already pinne= d >=20 >=20 > dmesg gives: >=20 > [34321.304270] ------------[ cut here ]------------ > [34321.304277] WARNING: CPU: 0 PID: 23628 at=20 > arch/x86/xen/multicalls.c:102 xen_mc_flush+0x176/0x1a0 > [34321.304288] Modules linked in: > [34321.304291] CPU: 0 PID: 23628 Comm: apt-get Not tainted=20 > 5.14.1-20210906-doflr-mac80211debug+ #1 > [34321.304294] Hardware name: MSI MS-7640/890FXA-GD70 (MS-7640)=C2=A0 ,= BIOS=20 > V1.8B1 09/13/2010 > [34321.304296] RIP: e030:xen_mc_flush+0x176/0x1a0 > [34321.304300] Code: 89 45 18 48 c1 e9 3f 48 89 ce e9 20 ff ff ff e8 60= =20 > 03 00 00 66 90 5b 5d 41 5c 41 5d c3 48 c7 45 18 ea ff ff ff be 01 00 00= =20 > 00 <0f> 0b 8b 55 00 48 c7 c7 10 97 aa 82 31 db 49 c7 c5 38 97 aa 82 65 > [34321.304303] RSP: e02b:ffffc90000a97c90 EFLAGS: 00010002 > [34321.304305] RAX: ffff88807d416398 RBX: ffff88807d416350 RCX:=20 > ffff88807d416398 > [34321.304306] RDX: 0000000000000001 RSI: 0000000000000001 RDI:=20 > deadbeefdeadf00d > [34321.304308] RBP: ffff88807d416300 R08: aaaaaaaaaaaaaaaa R09:=20 > ffff888006160cc0 > [34321.304309] R10: deadbeefdeadf00d R11: ffffea000026a600 R12:=20 > 0000000000000000 > [34321.304310] R13: ffff888012f6b000 R14: 0000000012f6b000 R15:=20 > 0000000000000001 > [34321.304320] FS:=C2=A0 00007f5071177800(0000) GS:ffff88807d400000(000= 0)=20 > knlGS:0000000000000000 > [34321.304322] CS:=C2=A0 10000e030 DS: 0000 ES: 0000 CR0: 0000000080050= 033 > [34321.304323] CR2: 00007f506f542000 CR3: 00000000160cc000 CR4:=20 > 0000000000000660 > [34321.304326] Call Trace: > [34321.304331]=C2=A0 xen_alloc_pte+0x294/0x320 > [34321.304334]=C2=A0 move_pgt_entry+0x165/0x4b0 > [34321.304339]=C2=A0 move_page_tables+0x6fa/0x8d0 > [34321.304342]=C2=A0 move_vma.isra.44+0x138/0x500 > [34321.304345]=C2=A0 __x64_sys_mremap+0x296/0x410 > [34321.304348]=C2=A0 do_syscall_64+0x3a/0x80 > [34321.304352]=C2=A0 entry_SYSCALL_64_after_hwframe+0x44/0xae > [34321.304355] RIP: 0033:0x7f507196301a I can see why this failure is occurring, but I'm not sure which way is the best to fix it. The problem is that a pinned page table is moved: the pmd entry referencing it is cleared and a new reference is put into the pmd. This is done by getting the old pmd entry, clearing that entry, and then using pmd_populate() to write the new pmd entry. pmd_populate() will lead to a call of xen_pte_alloc() trying to pin the referenced page table, which is failing, as it is already pinned. The problem has been introduced by commit 0881ace292b662d2 in kernel 5.14. Following solutions would be possible: 1. When running as PV guest skip the optimization of move_pgt_entry() by letting arch_supports_page_table_move() return false. This will result in a performance drop in some cases. 2. Unpin the page table before calling pmd_populate(). This adds some unneeded hypercall and without flushing the TLB I'm feeling uneasy to do that. 3. Add a check in xen_pte_alloc() if the page table is pinned already and if this is the case, don't do the pinning. This is a rather clean= solution, but will result in other failures if a page table is used multiple times (this case would be caught today as in the failure above). My tendency is towards solution 3 as it is local to Xen code and has the best performance. Any thoughts? Juergen --------------26F5A7C1DA5D359581D4BECD Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Transfer-Encoding: quoted-printable Content-Description: OpenPGP public key Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy= cWx w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O= f8Z d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y= 9bf IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq= G7/ 377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR= 3Jv c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA= QIe AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT= hpw dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0= MbD 1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv= oPH Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v= 5QL +qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ= 2Vu IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC= QoL BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr= Wf0 teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC= /nu AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh= ITT d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm= XBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz= 80h SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC= AcD AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn= FOX gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1= jnD kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0= N51 N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l= otu fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1= tqS EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA= hsD BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3= g3O ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5= dM7 wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5= D+j LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm= V2x AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N= Eaw QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW= nHI s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR= wgn BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV= bVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk= pEd IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA= QAB wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw= Tbe 8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1= vJz Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8= VGi wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW= svi uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX= zXs ZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------26F5A7C1DA5D359581D4BECD-- --8M0QKdzDc7d04oORWPj6gBj8yDHBPi3So-- --nkepnofagqj0Zs3mMsn1mbJe64GyvUYdo Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmE3G7wFAwAAAAAACgkQsN6d1ii/Ey+E TQf/fpxzZlRXgmKEMF/OYUVa6cmBJ/w1lRjz5L9orGtjrbsGzCFW1VTwTimiaEhvR1fyy6gWxfr0 6QNHpmx1SRIlNDtTq09z48Vcq2sx3l394mv7cdiTnrSa2z7gZb2197VmLfT6DfCf1eb97QCsQeXQ q9JtoPHHaMoXfqnPkga1CurulKm3yGebk4Ecl1c/EWx0T5XVdBrLhZRpWlLbo2UD/UutA4MDina0 YimVdc1TasQXd6KCBQG0H9+Q50vJVGcgluFXDVOrf1mB+nWvsemb0svCklBU6+ZQe0w/SeFEGdhT b92x+mApf2/awQd6erf5XXaoF4/LR3NphJnJ5mi8pw== =bYZD -----END PGP SIGNATURE----- --nkepnofagqj0Zs3mMsn1mbJe64GyvUYdo-- From xen-devel-bounces@lists.xenproject.org Tue Sep 07 08:00:18 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 08:00:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180546.327248 (Exim 4.92) (envelope-from ) id 1mNW1h-0006wk-DA; Tue, 07 Sep 2021 08:00:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180546.327248; Tue, 07 Sep 2021 08:00:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNW1h-0006wd-9i; Tue, 07 Sep 2021 08:00:17 +0000 Received: by outflank-mailman (input) for mailman id 180546; Tue, 07 Sep 2021 08:00:15 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNW1f-0006wN-8v for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 08:00:15 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 1be4cc95-5834-47be-bbd0-023698e99f46; Tue, 07 Sep 2021 08:00:14 +0000 (UTC) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04lp2053.outbound.protection.outlook.com [104.47.14.53]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-38-RbVMblSFOeGXKIM1TETcQg-1; Tue, 07 Sep 2021 10:00:12 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (20.178.127.208) by VI1PR0401MB2605.eurprd04.prod.outlook.com (10.168.65.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.22; Tue, 7 Sep 2021 08:00:10 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4500.014; Tue, 7 Sep 2021 08:00:10 +0000 Received: from [10.156.60.236] (37.24.206.209) by PR0P264CA0158.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:1b::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Tue, 7 Sep 2021 08:00:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1be4cc95-5834-47be-bbd0-023698e99f46 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1631001613; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qGYW5LYytLbES3ZLTz8QqvgRsEvCsh8vaEda5ensums=; b=BJEwoJ7Yb+YOMp0EvEWTyvVtwrVqKMfVw4/SesvqB6zHsc4AZffJMYgwoHe1VW/2MmydEW LRl4m7kGQWZroGSXkiR/OhsDFH/+A87nbSoERVz+oFf0c7qsHFVEnHQrQPRWMbzu6x2gFz KfuCkeDZHFrULCVjHUNDzBsbzyBKFok= X-MC-Unique: RbVMblSFOeGXKIM1TETcQg-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=G8JOlJDb8Lp2O8VHnfiauI8z86sTs4NWpdicP7UfTonCKu2NQ+wNuDxjMavY2Hq+ePXzoJH0DQxBSxy9A1ZipOmlaV2qI2IYiwe2ug38Pvn1J3LyW3Gx5LHBkxE2NVwFIuI3m9fw/8f0STgZcetX4g5sV/9pNRAymZkLzVTCnmYrOiJw8Hut417aV3UB/PLu9Ih4nuuqjcxpdExEHUqPmndXqNACcukm5OVZBe9/0jmoMu0e7kuJK8hdM2iJwRv7vCgjXohoaimUMCBL9Vq6X47MhTaNuNqmm85f63bNLqXrOvkLsJUfnmCVrRg1zIqRafrT22/l9zE82KJv18OHig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=qGYW5LYytLbES3ZLTz8QqvgRsEvCsh8vaEda5ensums=; b=iNFLr6hdUFsDa+uDTSAjoA3I44L5iYlpo7TWelAH77Xd/cdo0V81fVYuS/BiB2ZVlfnPLopCRjzHVFIWIKMi4yc7vJMZzcNnbGriwKP+xu/wc9IPgw+WQcfGdbYupBx5HcOPJbymCgFPAbPNitwjT7lcAvNa/RC4BwIgPy2TuXQ24JsebwkRsPnIIqK5NR6jIN5kH9TlGxQrVEC4TeYe4qUB9z68isEgx12DbF1brlVk+o/9kX/bFg9kEqLVDXY1phI0BnEy2LTUws1l2u1ZxGza4Oplez/wYny8tOiKWiGCvJ4H+uABam2qrediKAKNGlemJrO2S3Am/sUMsruoYw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com; Subject: Re: [PATCH 8/9] vpci/header: Reset the command register when adding devices To: Oleksandr Andrushchenko , Oleksandr Andrushchenko Cc: "julien@xen.org" , "sstabellini@kernel.org" , Oleksandr Tyshchenko , Volodymyr Babchuk , Artem Mygaiev , "roger.pau@citrix.com" , Bertrand Marquis , Rahul Singh , "xen-devel@lists.xenproject.org" References: <20210903100831.177748-1-andr2000@gmail.com> <20210903100831.177748-9-andr2000@gmail.com> <5366265c-d169-041d-f812-1c49260f6499@epam.com> From: Jan Beulich Message-ID: <8f1816db-798b-15d9-7343-2199eb8f39e0@suse.com> Date: Tue, 7 Sep 2021 10:00:07 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: <5366265c-d169-041d-f812-1c49260f6499@epam.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PR0P264CA0158.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:1b::26) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 223bb35e-1efb-4fb7-3dd7-08d971d583c2 X-MS-TrafficTypeDiagnostic: VI1PR0401MB2605: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: W44jmgzxr1Bqfl5Ur/sgExxDR1isKpyvDiD/S1Nj9ebyDjNkIFg5zmvJR8RzhLuQKyWoZCADr+eemcZsXbPvxeS7Zyg/D2JQD9py+QGuleF3ylSNU9dzEjVOrUuOlvhnaVnI1pwLSLFyxetDCi6u7u6l8pgZw9ZI/aCZNXfHDv66Qv+8J25ACejM+PvD6oBIheXdOO42QEEGxnyYbNKS3+JWNDGWGdAcWtHb2eTtYR3XPmRdns6UMbxz4S+qV9Qpd7pT2QiZ3ifJvOgD45N/o4cTDjJdsfzT7NYC1St3IpQa8OmRpEYLIaxqsrjYsug+CZdlTWudOMBFCBO7iN3U9R/gf1bZzZV08LE9MsmbkQ69dJ6kkLOHWl3kzC1TgZZPmrPwS88Hi2tcmyVfybxBCBVXDFiWsi6i8xdTvw78NE1tfKNPXkjJ8TrelGCh8BctJgNadZul5UVW2NLVvJSalTAQasKfIBVzpKIMDsjarZGonuVt7WKETkAEh9a2Q5byePxacRUIw4RuEUHDy/1AKF8BTI3SlLJWrIimJAovYNkjkufstZoozjhsYJ/VhgicSLIu6iMQNg5y5NaxNAT9QC9DMI5DRQmhhXJtAJl78n6qfCMqmGOfH3G8g3tChiBqu2Kw+y8q70FvS0i1w/5ocj0euHEZZxg5CICjl1yD1ZS1NgwKVr0rldFlOQdtehW4oi40u61aLFliqe0OLlL9IVIMrmriAdCeiqr9kknE5855TY33sLwpEJEgMONwcvyM X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(346002)(396003)(39860400002)(376002)(366004)(136003)(5660300002)(7416002)(53546011)(31686004)(36756003)(316002)(16576012)(66946007)(83380400001)(6486002)(66476007)(66556008)(186003)(2906002)(26005)(956004)(38100700002)(31696002)(2616005)(478600001)(8936002)(8676002)(4326008)(86362001)(54906003)(110136005)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VlpPMitNdi80enhCTTlhemxDSTVVK1dwNEJQdm5zMXBqcDR1MWhIb29hVTdY?= =?utf-8?B?RUxEV3JCRzJ1RW1KUjJLbWxLTTR3N3FmNXpwQm5ZdXgxWjAvbmNzYS9hY3E5?= =?utf-8?B?Z3pYZEw0UG8xUWdhRVdUaTZqaGNybzkxU1RzQW4vb3pXQ2Y2VmQ1MjU4U3VF?= =?utf-8?B?ZlBTd3V2UE9DeDNiMk9relArbTE1ZEJ1M1RhVnFTV2VWeVJYOThxb2g5alJh?= =?utf-8?B?S1daZkV0NnBLYXVPSXZYejRSY2dxNGpQNmhLVjlHVWVWWlRQdktBWC8zOFpE?= =?utf-8?B?cXdTUmxWaCt1VC9LbHVVUmI3Qy9zNDZDSUlQdE54TWVXU0ZHRlhyNHQ1QjRu?= =?utf-8?B?L3BLSWNoME1lUk1laWJ2ekVCbnNua0c5ZUhOK1NCbVh4VmdKQkdDNFUyK2dj?= =?utf-8?B?dzdiQ25FNWlCZE1mcGg2NjdSbnBDSDdxNlZ2Rk1uNHp6NGJaV3lsRHpBblZG?= =?utf-8?B?UjAwYnhKbmY2N3JSVmJMcE1kcE9wVkhCNEg2VDYrNEE0dDJ6c3Vud0xlbWR3?= =?utf-8?B?OWxEaEhBODlNZEQ2NlpvNDBYZEd2M1Rka3o0djU3cWJ2YmhzVXF4RUpVSjdC?= =?utf-8?B?NUtaVCsycm1tZVVKWTdUYzBXcEpMNU5scUUrZTdZSmJGK3lhZEV3Yk9lYnBG?= =?utf-8?B?NFlFQll6QXFiZTBVYmdSSFBtYjJHUU1nZFBUWWQyOEM0djdTdllnR0hvZE0v?= =?utf-8?B?Y2pVcnd5Q2tLOVVKU2JETSsrVEoyakxBL0tQekVLOWhaUFZsS1p2Mzlta3Mz?= =?utf-8?B?ZkQ3SVJQcDI3STVwVmYwN1ZZcnVCNTVPaGtjUXdNWGl4NTIyTElUQUQwU21Z?= =?utf-8?B?QnJTM2RHelNocVduOWl2aFRybVgzQ2ZLVGE3eGljMUptWk1zeTZLODE5VXpz?= =?utf-8?B?eGRvdEl4OG9tbFlNaUhLZmRMN3d3M1o0T3RUdkR4S3EzeStMOUpVMFJaazdW?= =?utf-8?B?bHIwZ0twbi92M0dLQTVKYVNTMXB2eE15bkkvOFpRRkg2emlpRUh0VzBIejFj?= =?utf-8?B?VFBGa3hrdjRQTFp3eUl1bTI2RXhXSm9RR3lRNDkrSGJ5Q05Ec1lsb1VMd3Rp?= =?utf-8?B?TmxpamFJaWRIaXE2YmtwbHJFb2RXaUlnUldtdGRMcE1wUVF3T2lFcE9pd0hy?= =?utf-8?B?RnVnRzV4VTAvbWlyT2UvdExkakhJOHNVeWhHbkJVUTdMZERPZWVYVHZuR3hZ?= =?utf-8?B?d2dXbEd3a0pIOE8xbk9jcHdIcXV5VTZhWU1iWThFRUI4K0lGL1JvQmlYOVdM?= =?utf-8?B?c0FiNVMycG1rViswa0g4TVhCN3BFR2RtU2MzS2ZObmJuaXV5ckFFL0V1L2VF?= =?utf-8?B?eVpnQ3g4VHg0UmZsdjN0elBmR3lSZTlTZkJ1bVVSdnBEdFR5K2hsOUNlQWdB?= =?utf-8?B?a1JyMDJMNGhpd1lXdUdhdzl5TzQzWTUzYVpaejV1SlVmT0d3S24xMXVRSEhD?= =?utf-8?B?Uk5KN29zWWU2YTV6dVc1WHJJL3JEalgzVVdBK3RhcmFhdlJjZUJkQWhVN2Jy?= =?utf-8?B?SWVPeE5Wa05rdzVMUkVRVnViVjA2V1lSS0Yzc0lJRUExczdXM3plTmowZ3c5?= =?utf-8?B?WlIwaDNDVkgrVkhseStYMTZnZVJKNGtvTXdPWE9LT1dzYjhlY0QvQWhTaVJr?= =?utf-8?B?VDVvYTBjUk1CYlJhcUhzazZFd1lKNlN1UWdEMUpDZ0lmeXdSR09KV2hFVmgr?= =?utf-8?B?YlIyZUZHSGFjVjVLMFpUMGowQ1RsamV5RldXRjFvd3l3NU1zKzVKMFk0NDJs?= =?utf-8?Q?PqKd+raBG1YqgM2IKrDake8vGx9V5fO7H/0mO4L?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 223bb35e-1efb-4fb7-3dd7-08d971d583c2 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2021 08:00:10.3273 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: CppwKVVBl30tD5wgR07UVvKzn08D8WT+tB8mfkilSOW19cqXFMMHgDGSWBWtU7gt7Zb6n3XTAaRoFzaEhVc6dw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2605 On 07.09.2021 09:43, Oleksandr Andrushchenko wrote: > > On 06.09.21 17:55, Jan Beulich wrote: >> On 03.09.2021 12:08, Oleksandr Andrushchenko wrote: >>> --- a/xen/drivers/vpci/header.c >>> +++ b/xen/drivers/vpci/header.c >>> @@ -811,6 +811,16 @@ int vpci_bar_add_handlers(const struct domain *d, struct pci_dev *pdev) >>> gprintk(XENLOG_ERR, >>> "%pp: failed to add BAR handlers for dom%d\n", &pdev->sbdf, >>> d->domain_id); >>> + >>> + /* >>> + * Reset the command register: it is possible that when passing >>> + * through a PCI device its memory decoding bits in the command >>> + * register are already set. Thus, a guest OS may not write to the >>> + * command register to update memory decoding, so guest mappings >>> + * (guest's view of the BARs) are left not updated. >>> + */ >>> + pci_conf_write16(pdev->sbdf, PCI_COMMAND, 0); >> Can you really blindly write 0 here? What about bits that have to be >> under host control, e.g. INTX_DISABLE? I can see that you may want to >> hand off with I/O and memory decoding off and bus mastering disabled, >> but for every other bit (including reserved ones) I'd expect separate >> justification (in the commit message). > According to "PCI LOCAL BUS SPECIFICATION, REV. 3.0" I have at hand, > section "6.2.2 Device Control" says that the reset state of the command > register is typically 0, so this is why I chose to write 0 here, e.g. > make the command register as if it is after the reset. > > With respect to host control: we currently do not really emulate command > register which probably was ok for x86 PVH Dom0 and this might not be the > case now as we add DomU's. That being said: in my implementation guest can > alter command register as it wants without restrictions. > If we see it does need proper emulation then we would need adding that as > well (is not part of this series though). > > Meanwhile, I agree that we can only reset IO space, memory space and bus > master bits and leave the rest untouched. But again, without proper command > register emulation guests can still set what they want. Yes, writes to the register will need emulating for DomU. Reporting the emulated register as zero initially is probably also quite fine (to match, as you say, mandated reset state). Jan From xen-devel-bounces@lists.xenproject.org Tue Sep 07 08:04:01 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 08:04:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180552.327259 (Exim 4.92) (envelope-from ) id 1mNW5G-00081E-S1; Tue, 07 Sep 2021 08:03:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180552.327259; Tue, 07 Sep 2021 08:03:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNW5G-000817-Oo; Tue, 07 Sep 2021 08:03:58 +0000 Received: by outflank-mailman (input) for mailman id 180552; Tue, 07 Sep 2021 08:03:58 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNW5G-000811-4P for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 08:03:58 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id ecd9df2c-25d5-407c-a70e-980aed8a372c; Tue, 07 Sep 2021 08:03:57 +0000 (UTC) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05lp2112.outbound.protection.outlook.com [104.47.18.112]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-35-s4LotqQnP-2KPd2_f5FqLQ-1; Tue, 07 Sep 2021 10:03:55 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR04MB6301.eurprd04.prod.outlook.com (2603:10a6:803:f1::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.21; Tue, 7 Sep 2021 08:03:53 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4500.014; Tue, 7 Sep 2021 08:03:53 +0000 Received: from [10.156.60.236] (37.24.206.209) by FR0P281CA0017.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:15::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.4 via Frontend Transport; Tue, 7 Sep 2021 08:03:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ecd9df2c-25d5-407c-a70e-980aed8a372c DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1631001836; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=A5EGaKlsiNTjnRo/nw/nllmUB/AG6tuR/OJmZarPtZ8=; b=Ut+xOJaWeQ6Gy92qgJ/Agv2UB4D4XHi7I7fPmac4sdf/j15duaVnNDC0qnMYIfHpdLEN5J ViuLCTUJiiCKceyJKVA5isSr3wWWgxsUEXbYSmIzPHYrejvVDg4PSD3wGMfpqNWNzXwJpU Rzz9LKbVJZECgHltKo6ExgiubVn+Hkk= X-MC-Unique: s4LotqQnP-2KPd2_f5FqLQ-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=L3AmYJCtUZXOyyhLbTMQcllVPOL+RGMhLZqx8fi+HiIbQ7hszKWMV822/82ivYBTynjVI24R7QhNt3cJy/4dnxkapIEPRyzyQgUxpuVJLbcepjBynz3nGbLV8LaYw8XMnRvE7dVkxQ1ymZZ/j10UMQDa3HM6nvVzrawuxhhVcCABZ6Gb6/2VcCIwvM7WQZqGz5WQ6CfXPOc9izHIJ8M1N1oDI0cB1PZZ9k3hECDKP9ibOglpE/m/fxm9vvFdtiCB+EDF5pmjSxzYOXPPR5O32PKJg8AKN1vQ/HmVK0zmwpRDDcNkbOxWkwK4gqkAgjSS5PjKAUsFH3ijAHqrF6O2Og== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=A5EGaKlsiNTjnRo/nw/nllmUB/AG6tuR/OJmZarPtZ8=; b=djq5Vmyc4BHPYuA68x5tizrkd6sAmZL1lZURsRrI7kXeP30BnpU0q6wDLkv47dxMYrVhD10sf4i/UKj7nP52RSnFED+ZiDbyoiYg/wSdkb4yb5hykgVpeZqwzkEdU6wiDu6aqlxarvw1M6Be0kB/0/bVSM3PkO2RFqoETED/O9B82yIHwjgns7WS3PehcIqURdIRo2vrcoUCc0k/+RpVWT4AYVel/TJ5EM0Mugl8Ua3Pg09zYgmFU9WkzlEZuiaB3RsAI60eF36Q1DXfGLju3BvrXLoiUwYdOOiiQuvAZR16jPRxcSaEd42wvndtru/2qYtS6REkfwxdtA8+N3S9kQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com; Subject: Re: HVM/PVH Balloon crash To: Elliott Mitchell Cc: xen-devel@lists.xenproject.org References: <84d9137e-a268-c3d8-57d2-76fb596e00d3@suse.com> From: Jan Beulich Message-ID: <1b3d4cb1-ba61-0f61-5097-9978462a2401@suse.com> Date: Tue, 7 Sep 2021 10:03:51 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0017.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:15::22) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8977a94f-4175-4f22-c12c-08d971d60880 X-MS-TrafficTypeDiagnostic: VI1PR04MB6301: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: POxqRJaYlTUXSV0JGrUwU3LlydJJ+rNpo5ScsLwUJpqfacPlUPYMapOLkNZXpwlcwnVZNTxMtJhse69k38FGoZsS/5ZFHW+xm3CIldKz0m+tlXIRvMT8ParDN5WVoox5NC8KBa3G7qnnN+iyl2PypzCsBYkI2snlmBsnlOW7d57mbt4mimwGpwREY0cs0hxQsdbGhXO5CRifmpFCvm+Eo+AdYuTdwInDfA+JfJlUUEHaEZ0BMUbWaS/kbDHc1GnX9bGxth3y+GjeyoVN/afmQsYmn20J+JENsTmws+JUMSHzLPMzyGG1RHZwn81JdCvGpzbxfY06gD4KnSVWHtD8YgD2D4dmZaY61AHlTl9+n5dBV5xcwNcH1mGlp8Wx7+qh8CEvcBrpWmOfKmU2fTtIvaeeYTLXGdayxNDkT0ztLxoTjvDla+yh/TE1SW8QuguIKDL3T7XYxs5ztuxBI8LPCnsEFBIEHT9ZT06VpvIUH1aHKctSOQUZGVpcX3EjNHyy/iUX3xOeLHGEpZKQh7FcdfU+qtSNpAS8crdHHWX3H6yhJXm8alNoHh5oDcCw29PGogztS+hZpX7boDGHcBXg0nXJt2FWF6W5u6cO6+4N6W/D1L8fmurbyQHVS7A0YSvhd35iDalq+gBbK/auOJsarKcFpWvZ+vF4FpuXgjO8/+WeDS2zqLeKHGC+ydE4iUR0Y8/MRVEfkZ/ZrMirqWzsh8eXQqA/ZAmV52xu3t1bxCZTa/hFebPU9NCzLFl2yXJ3 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(376002)(136003)(346002)(396003)(39860400002)(31696002)(86362001)(186003)(2906002)(26005)(8936002)(8676002)(4326008)(53546011)(316002)(956004)(38100700002)(2616005)(16576012)(3480700007)(83380400001)(6486002)(66946007)(66476007)(66556008)(36756003)(5660300002)(31686004)(478600001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?enREKzFIK3BFKzl3ckluRXM5T2hVNnhpaG1nSGxwZFlQUkh1Z0JMZXA1K3BJ?= =?utf-8?B?eTZXemw3NGxsSUd2MlpOdDEreDBtTGRoOFk3eG9qaGR6Vy9EbkxqWVYzaFkx?= =?utf-8?B?UE40bHNUQTJqNStGUkliZERVNm9tT01oY01kakZxYThEYUJVclk4WmJVekU1?= =?utf-8?B?TmdCL1VlMmJrZG9CY1hUS2drRnhFNzBaNzBkTjd0SVJyK25PenVWV1U0ZnIv?= =?utf-8?B?cHNCckJldklrUXFYemVNNTBhMUtwaWxvZWxZREtXUkU2ZHMwNVdrWG1ac25j?= =?utf-8?B?LzNYR3EzRHhKL1BQSS9JK2NRRjZHTkxseTNZQzBRSWcxL2xUdGljTXM3NnA0?= =?utf-8?B?WWlPaDJyM3lPT1luUjBnRk02MmxmVWhBNSt2cDVMUE9PeExQTVhPWVEyKzQ5?= =?utf-8?B?REFGL1FNeWVEMnJiMTFWVTNxWExtRXhKVzVZV3RCTklvRGVxMVVDNGFaTzc5?= =?utf-8?B?Zlk5Umk1YjF3OVhaK0dvSHYyL2taVFVQRUhYWDhIVHdmVFlQbmtrTEpqWXNt?= =?utf-8?B?L05ET1lzSkxyQ1RTOHo0U0IrcjNQbm5uWDNOTzRnWklqd0dKWHhrRjBQY2FS?= =?utf-8?B?czN1WkRiWm1hWXdBSzY2ekZHQkplU0hMczV3RHpKUkQ1Z2R1Z0RSOE9Dekd6?= =?utf-8?B?UFZEN2pKMjBQazVDTmtmandtTUhZejNFZTE4aUhMZzlNS3QwMElvY0RjTjBQ?= =?utf-8?B?M2JnRU91TXBHSktTS2NhcTd1RFFzR01BSEd5UWdCY3Y4WjdUOHl0dFB4bThS?= =?utf-8?B?bmNtUjN2TmpKSHRVN1NwR1JZODhhSzFlSmNGYno1aEk3Vitid1Rla25LbjQ0?= =?utf-8?B?SjV2N2xKS0xPTXR1YStReW1XKzYxR0ptZHU5cXFJUzRWcHYva2t2dTNWa1F1?= =?utf-8?B?RjZwYkxmNmlFb1pHeWFCTlZCZzdsSElJOTBxV0VnWVVSM3JvQytTMmpydDVE?= =?utf-8?B?WmNIdjI3bmtxWW5xOXljK3p6VG9zTEF2ajNrdExFenpIQWNDZStHT1NIWjFz?= =?utf-8?B?RDFCb3NjSHBURjdJNk5HbzR6VmxOMElKd3F4QjVVS2s4YjNnTGVFSERrRGFQ?= =?utf-8?B?R3VWUDNEbnc1RVBQZ2xaVE9vYjk4OEtNNGdaSzZWb3lWRm9qeFBHeCtKQkFv?= =?utf-8?B?MnhpZkdoQ0ZIQ0xSdU0rNEhlUEROdEpLRHVvU3hHVFVqTGZ6T1VpeHk1OXRk?= =?utf-8?B?MHhUVkxLOHRobnUwcWdwUlpaOUhOUHFsN0dwS1pyWnpqZDNHMnpBUGd2MkZy?= =?utf-8?B?STRCWmJyR25CZ0lmMTlZWGhnQmcxR2YycFM5VGNvWFFhVGc4Q2w1UWZ6OVhu?= =?utf-8?B?WCtTVW51YWd5REdWblNFUTA0RDdrT3pTVmRxUzdiYlg3WkJOTjhpeFpKc3hW?= =?utf-8?B?dUNrV0ZJZHoweWxyZk4zSEEzcnlyTGV2R3hRdm5ib0FxdC9wUGxNbHhRYzFj?= =?utf-8?B?WjZWUmdYRXRDVlJKcGtoUS92c0JScFhFVUpyK2lVVDZ5OHZOQ1JpL1laY0xP?= =?utf-8?B?aS93SVJydldwRHQwN1ZveisvcDBKL1dlTWJua1NtWVEzNTVlbHFidmlLZ09X?= =?utf-8?B?dTBkVk5oeWV2bENPV253WTBFNDJLN3hEUlRDY1pwODdjOEVUeVhEUGRYSUVv?= =?utf-8?B?UG1xUzlsVlNhQUxiT0xpemlxR0RjaE1wSzNNUVQ4YU1VY0ZNd0U3OGVpNkNW?= =?utf-8?B?MTVFSkM4MHFRRnduTHJkUDBJV1AyUE1LQjJqdUhlRXY5YWppU1RGOERBdW1p?= =?utf-8?Q?mhFC+fbTYs4nEm/YvK1xiuMntWC7eVoAt80CWua?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8977a94f-4175-4f22-c12c-08d971d60880 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2021 08:03:53.0520 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: hu1TXXxQgUX4yQAGIMWGiU4KgfBJPrRgpDHHA/N4HonWQ+5VX3Qc76VmIPJM98sFlCaOG+piGbGNKzSKuFvDOA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6301 On 06.09.2021 22:47, Elliott Mitchell wrote: > On Mon, Sep 06, 2021 at 09:52:17AM +0200, Jan Beulich wrote: >> On 06.09.2021 00:10, Elliott Mitchell wrote: >>> I brought this up a while back, but it still appears to be present and >>> the latest observations appear rather serious. >>> >>> I'm unsure of the entire set of conditions for reproduction. >>> >>> Domain 0 on this machine is PV (I think the BIOS enables the IOMMU, but >>> this is an older AMD IOMMU). >>> >>> This has been confirmed with Xen 4.11 and Xen 4.14. This includes >>> Debian's patches, but those are mostly backports or environment >>> adjustments. >>> >>> Domain 0 is presently using a 4.19 kernel. >>> >>> The trigger is creating a HVM or PVH domain where memory does not equal >>> maxmem. >> >> I take it you refer to "[PATCH] x86/pod: Do not fragment PoD memory >> allocations" submitted very early this year? There you said the issue >> was with a guest's maxmem exceeding host memory size. Here you seem to >> be talking of PoD in its normal form of use. Personally I uses this >> all the time (unless enabling PCI pass-through for a guest, for being >> incompatible). I've not observed any badness as severe as you've >> described. > > I've got very little idea what is occurring as I'm expecting to be doing > ARM debugging, not x86 debugging. > > I was starting to wonder whether this was widespread or not. As such I > was reporting the factors which might be different in my environment. > > The one which sticks out is the computer has an older AMD processor (you > a 100% Intel shop?). No, AMD is as relevant to us as is Intel. > The processor has the AMD NPT feature, but a very > early/limited IOMMU (according to Linux "AMD IOMMUv2 functionality not > available"). > > Xen 4.14 refused to load the Domain 0 kernel as PVH (not enough of an > IOMMU). That sounds odd at the first glance - PVH simply requires that there be an (enabled) IOMMU. Hence the only thing I could imagine is that Xen doesn't enable the IOMMU in the first place for some reason. Jan From xen-devel-bounces@lists.xenproject.org Tue Sep 07 08:05:55 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 08:05:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180558.327270 (Exim 4.92) (envelope-from ) id 1mNW76-0000BA-9r; Tue, 07 Sep 2021 08:05:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180558.327270; Tue, 07 Sep 2021 08:05:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNW76-0000B3-5c; Tue, 07 Sep 2021 08:05:52 +0000 Received: by outflank-mailman (input) for mailman id 180558; Tue, 07 Sep 2021 08:05:51 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNW75-0000Av-7L for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 08:05:51 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com (unknown [2a01:111:f400:fe1e::619]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 292e35d6-c6f2-425d-8dec-2a84e5adcba3; Tue, 07 Sep 2021 08:05:48 +0000 (UTC) Received: from DB6PR07CA0175.eurprd07.prod.outlook.com (2603:10a6:6:43::29) by AM9PR08MB5985.eurprd08.prod.outlook.com (2603:10a6:20b:286::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.17; Tue, 7 Sep 2021 08:05:46 +0000 Received: from DB5EUR03FT011.eop-EUR03.prod.protection.outlook.com (2603:10a6:6:43:cafe::fa) by DB6PR07CA0175.outlook.office365.com (2603:10a6:6:43::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.6 via Frontend Transport; Tue, 7 Sep 2021 08:05:46 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT011.mail.protection.outlook.com (10.152.20.95) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Tue, 7 Sep 2021 08:05:46 +0000 Received: ("Tessian outbound 610b9df843d5:v105"); Tue, 07 Sep 2021 08:05:46 +0000 Received: from 66fdde6d019e.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 3E15A6A9-9FC5-49EC-A7C7-AC7D04436CE8.1; Tue, 07 Sep 2021 08:05:39 +0000 Received: from EUR03-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 66fdde6d019e.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 07 Sep 2021 08:05:39 +0000 Received: from VE1PR08MB5677.eurprd08.prod.outlook.com (2603:10a6:800:1ab::17) by VI1PR08MB4190.eurprd08.prod.outlook.com (2603:10a6:803:eb::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14; Tue, 7 Sep 2021 08:05:33 +0000 Received: from VE1PR08MB5677.eurprd08.prod.outlook.com ([fe80::d810:52a3:dce3:4d06]) by VE1PR08MB5677.eurprd08.prod.outlook.com ([fe80::d810:52a3:dce3:4d06%5]) with mapi id 15.20.4478.026; Tue, 7 Sep 2021 08:05:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 292e35d6-c6f2-425d-8dec-2a84e5adcba3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QV8b/SNLW0Tjhqdk11/RrqSAJCoIZ01fAAKzO7ivC+4=; b=Llu9plT9+lgVEzSlrojJUGwGwaI5QRZTkxTJkfoa5QbN7uDYqNCTDhA5FJGLLIOU4suO0j5cns+va0KmqeoXF90Nj0GNmT/rDr5RNjw/17jhtagamC5Km6j0AQ7zlCdff7B4JGJL3CxHKNpypPGhhgGmEbrhfjeEcwL6NXVt6qc= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QMRYR7P8r53exVm7qnHJMIZp3PJQPhNaNQCa9oxXrU0CaR8ohsxdtewRTm2WKt6vnJRCYTXMDBJcws7KK8k9eKGzH2xys34utm2CDCYuFWWt7NXyGgyGYm+Gaqagx3451yTe4qoOG2086NbAtl343OLEPmz2dWuXRtNkbd50HSh3FKlv6nJ+D7I2543PUVKMsuAEcVUInLep3mChy0jSQk2LmcAKI3BIQzAdlAmFa+vDKi3kplYZHmba3/b2HVx/hUnqj6FNW9FkePmT2j6/sOPiF7ODnlgdqNnreQuUndr8tN6DTa/zQ7h0LdopXH5jWDSG0qMkSFqCiVQhh5p0ig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=QV8b/SNLW0Tjhqdk11/RrqSAJCoIZ01fAAKzO7ivC+4=; b=PDxu0c5eqWgrZuvPAVWn4NdCZ6ytlBPiZKsOTxlz3sY4aMxwNXW7nZuzbkhhgMoEX05SnguB7b0zFG27MrS1rF9yiLcgIxURQTe1/gG3Gu3faCT2pNdEoK+20U1e29h55CdW+T9k1X6rShGxHrDDdcinL1WmCu/jJsyzdSST4KvUGYVHCRH6uGNSQuzdeOsWoT6GfLUF+7Ljh8y4E4dFgbB7f7/bR7RbO5//FfrUoMIBEHkOo+IHXbwTIQTh295zc2hcU3SuU7b3aSFpP5mxLLG3AR54LaeQCdKAEd6kVRKwRIS80SfQ/UE+52bNADmBG/3aAIMMeyPthfeI2aZA7g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QV8b/SNLW0Tjhqdk11/RrqSAJCoIZ01fAAKzO7ivC+4=; b=Llu9plT9+lgVEzSlrojJUGwGwaI5QRZTkxTJkfoa5QbN7uDYqNCTDhA5FJGLLIOU4suO0j5cns+va0KmqeoXF90Nj0GNmT/rDr5RNjw/17jhtagamC5Km6j0AQ7zlCdff7B4JGJL3CxHKNpypPGhhgGmEbrhfjeEcwL6NXVt6qc= From: Hongda Deng To: Julien Grall , Wei Chen , "xen-devel@lists.xenproject.org" CC: Bertrand Marquis , nd Subject: RE: About Arm guests accessing to GICD_ICPENR Thread-Topic: About Arm guests accessing to GICD_ICPENR Thread-Index: AdejvyF8C7fiPQEXRRSQQzNI/V0p1g== Date: Tue, 7 Sep 2021 08:05:33 +0000 Message-ID: Accept-Language: en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 3A117852C6EAA740B0A5374012329AE5.0 x-checkrecipientchecked: true Authentication-Results-Original: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com; x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: fbca13c2-b529-4a44-5c46-08d971d64c2f x-ms-traffictypediagnostic: VI1PR08MB4190:|AM9PR08MB5985: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:10000;OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: NYCTz5HY7d7u6eKzrsty7ns6ESFZArVEhYi4/34rmo7sWqQPaPlvdFExUqajvAcQwVT9B4Q+mNegtD0TtJ9VQn/OeAdNsB+ZHQyJdw4EPUT05qhd1ShGsYCvSmgUqeJA67c4gbnUk1QZDRPb8FFAuJratTkWyp2qIV1Pc/tIYOTonDf/b7+xl6ytM6EWaJqaS5oytedaOL+0KiM2LEGoazkmWndSHOkGyLsxUZgsc4cnMsYwv/7bueXuZKVSnR8QqKkgKrTU9GXSxNGTWvFowjbaimINtF+ARmgVyLK0ZQGLRIvn0lyrlJC5umivqRA48z4m3v9TMROXxHV5VInhsdOIq/OdEVjttD4Au1ywC2N5A3OHrhDh+2JPbO4nSm+1lTa/8K7z0dySzzI4TUzaR5Hz7owMxRQsa/BWbfENyFa4RpAYgzWhr2JRdvv+CM7Px+LimO9UApTrX+NTFgbtURUtrusJYdYpEPSIVio3FXw6jQhhAB9Ometgnz9q9YFNRTMJaIMUkG+WdtAuTqB8ZQbvV96OkOORDRBLk8FoDzsqJMQX2DaebJXpseM38Km/0wW2qCVUGtq6rjn0vu9W8kIJ474Zdn6KNRLTpdUBojj3GxHlRAb4WNdEydwzfkpMY4FazGSa9ubW9u3MgqEVp9KXuYMG+hC5fXAKa4Euzk50conuNqyzgy7mqm0drE57xJGdRrckd6eYHu864aYH9AEzxnosKiSh8iYPPgQNhFWu1gX+MFlC/dGG9P6xjulXDqKuV483cu3i2iQ/taOaBGdeMz6rBnx2+Hin3GQU/S4= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR08MB5677.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(39860400002)(346002)(136003)(366004)(376002)(52536014)(66446008)(66556008)(66476007)(5660300002)(66946007)(33656002)(64756008)(122000001)(76116006)(38100700002)(7696005)(478600001)(2906002)(186003)(8676002)(26005)(83380400001)(54906003)(316002)(8936002)(38070700005)(55016002)(86362001)(71200400001)(4326008)(966005)(110136005)(6506007)(9686003)(53546011);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB4190 Original-Authentication-Results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT011.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: da997a58-c9b1-4fa1-10a5-08d971d64480 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: NjFyaEp0ZKDtV0TSlR54FyaOyuysWTsrLU8k2m1exzMsxeoZEtZ3/2Be6Ku7IWQfavD7rinXN0JYtmZ3ydyIRefL5Dw1jJ0b9A+kI3eQIzxGoqrk8bQszfZl8x0p2Dc4oDYQp4mornSQmmqQcnU8YmLhssLzTq6t1RIGu1Ary5qztpUk0DyE/OLD4AW7yVSP+ycV48aF6GOCL0f6j64zZgxwUmvk6PQ4x8iI5tQvkWupVTod8sGxdmN3st/mMRYrRVEnKo5EruqSmO/GkPMj2N3vn1jiZTNwl2iAyv5xgN3a7PxcuG8InwavqCEVwbSSYh1dZSWBrCnPZj7ZU3C2zKCedJQN7hnlejF5Oi2VNCOkiCkxhzZG4LTOn39X550P/6QSaknbG2VIBDGhwMf1HMhiwfHLOS9KFqlGORZzGIArxrx7uP+aAN5o9AV7r5xd32ZoNNM5OFdx2t5nPUduqlWk/B61/QHR7VhvFiaynNLLVZF6cHBVErU6fdwdKePYafYkohT05f/M9rc/1hB8CiuG/ds1MFdJVHowdRU7ED1xlBORr3MOaQGy0avLmqc9AhWMvvMMLwgxgKyNFU0gKAbi2sRbOwF47Pu39Bk/ddgWs4GfmVW1xxybTwo+LwYatnDhZq1Gs86AB3xluNL6h2Krr7UIvf3fP8OY+e9sLy8l9qlBueWnqFbVpAJSijXAl3fUAuireIkXmH77Jr//NQitmICsXTtexs5on2DqK/FDNDFgcUaB9Ksnc/nA4ZJOvBXMlsHmU8AxTH8ZVK85zr36/dkAZBa4vt7rFN/I7z4= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(346002)(39860400002)(376002)(136003)(396003)(46966006)(36840700001)(7696005)(82740400003)(52536014)(82310400003)(8676002)(47076005)(54906003)(33656002)(53546011)(6506007)(81166007)(336012)(356005)(5660300002)(36860700001)(70206006)(83380400001)(2906002)(110136005)(9686003)(966005)(316002)(26005)(186003)(86362001)(4326008)(55016002)(478600001)(8936002)(70586007);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2021 08:05:46.4678 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: fbca13c2-b529-4a44-5c46-08d971d64c2f X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT011.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB5985 SGkgSnVsaWVuLA0KDQo+IE9uIDA2LzA5LzIwMjEgMTA6MDQsIEhvbmdkYSBEZW5nIHdyb3RlOg0K PiA+IEhpIEp1bGllbiwNCj4gDQo+IEhpIEhvbmdkYSwNCj4gDQo+ID4gWGVuIHByb3ZpZGVzIHZH SUMgdG8gc3VwcG9ydCBYZW4gZ3Vlc3RzLCBhbmQgY3VycmVudGx5IHhlbiB3aWxsIHJldHVybiBJ Tw0KPiA+IHVuaGFuZGxlZCB3aGVuIGd1ZXN0cyBhY2Nlc3MgR0lDRCBJQ1BFTlJuIHJlZ2lzdGVy cy4gVGhpcyB3b3JrcyBmaW5lIHdpdGgNCj4gTGludXgNCj4gPiBndWVzdHMsIGZvciBMaW51eCB3 b24ndCBhY2Nlc3MgdGhlc2UgcmVnaXN0ZXJzLiBCdXQgZm9yIFplcGh5ciwgdGhpcyBtZWNoYW5p c20NCj4gPiB3aWxsIGNhdXNlIElPIGRhdGFhYm9ydCBvbiBaZXBoeXIncyBpbml0aWFsaXphdGlv biB3aGljaCBtYWtlcyBaZXBoeXIgZ2V0IGluDQo+ID4gZmF0YWwgZXJyb3IuDQo+ID4NCj4gPiBP bmUgbWV0aG9kIHRvIGVhc2UgdGhpcyBpcyB0byBsZXQgdkdJQyBpZ25vcmUgR0lDRCBJQ1BFTlJu IHJlZ2lzdGVycyBhY2Nlc3MuIEkNCj4gPiB0ZXN0ZWQgaXQgd2l0aCBMaW51eCBndWVzdHMgYW5k IFplcGh5ciBndWVzdHMsIGFuZCBib3RoIHdvcmtzIGZpbmUuIEFuZCBJIGZvdW5kDQo+ID4gaW4g dGhpcyBwYXRjaFsxXSB0aGF0IGl0IHdvdWxkIGJlIG1vcmUgY29tcGxleCB0byB0b3VjaCB0aGUg cmVhZCBwYXJ0IGZvcg0KPiA+IEl7UyxDfVBFTkRSIGFuZCB0aGUgd3JpdGUgcGFydCBmb3IgSUNQ RU5EUiwNCj4gDQo+IFJlYWQgdG8gSXtTLEN9UEVORFIgc2hvdWxkIGFscmVhZHkgcmV0dXJuLiBB RkFJSywgd2hhdCdzIGxlZnQNCj4gdW5pbXBsZW1lbnRlZCBpcyB3cml0ZSB0byBJQ1BFTkRSLg0K PiANCj4gPiBzbyBjb3VsZCB3ZSBpZ25vcmUgR0lDRCBJQ1BFTkRSbg0KPiA+IHJlZ2lzdGVycyBh Y2Nlc3MgdG8gZWFzZSBaZXBoeXIncyBpbml0aWFsaXphdGlvbiBwcm9ibGVtPw0KPiBXb3VsZCB5 b3UgYmUgYWJsZSB0byBwcm92aWRlIG1vcmUgaW5mb3JtYXRpb24gb24gaG93IFplcGh5ciBpcyB1 c2luZyBpdD8NCg0KWmVwaHlyIHdpbGwgdHJ5IHRvIGNsZWFyIHBlbmRpbmcgc3RhdGUgYXQgaXRz IGluaXRpYWxpemF0aW9uLCBhbmQgdGhlIGNvZGUgY2FuIGJlDQpmb3VuZCBoZXJlWzFdLg0KDQo+ IA0KPiA+DQo+ID4gSWYgWGVuIHdhbnRzIGEgY29tcGxldGUgR0lDRCBJQ1BFTkRSbiBlbXVsYXRp b24gdG8gZml4IGl0LCBkbyB5b3UgaGF2ZSBhbnkNCj4gPiBzdWdnZXN0aW9ucy4NCj4gDQo+IEVt dWxhdGluZyBJQ1BFTkRSIGlzIG5vdCBlYXN5IHdpdGggdGhlIGV4aXN0aW5nIHZHSUMuIEl0IHdv dWxkIGJlIGdyZWF0DQo+IHRvIGZpbmFsbHkgaGF2ZSBhIHZHSUMgc3BlYyBjb21wbGlhbnQsIGJ1 dCBJIGFsc28gYXBwcmVjaWF0ZSB0aGlzIGlzDQo+IGdvaW5nIHRvIHRha2Ugc29tZSB0aW1lLg0K DQpZZXMsIEkgYWdyZWUgd2l0aCB0aGF0Lg0KDQo+IA0KPiBJZ25vcmluZyB0aGUgYWNjZXNzIGlz IHByb2JhYmx5IHRoZSBiZXN0IHdlIGNhbiBkby4gSG93ZXZlciwgdGhpcyBpcw0KPiBhbHNvIGEg cmlza3kgYXBwcm9hY2ggYmVjYXVzZSBaZXBoeXIgKG9yIGFub3RoZXIgT1MpIG1heSBnZW51aW5l bHkgd2FudA0KPiB0byBjbGVhciBhbiBhbHJlYWR5IHBlbmRpbmcgaW50ZXJydXB0LiBTbyBJIHdv dWxkIHN1Z2dlc3QgdG8gd2FsayB0aGUNCj4gaW50ZXJydXB0cyB0aGF0IGFyZSBtZWFudCB0byBi ZSBtb2RpZmllZCBhbmQgY2hlY2sgd2hldGhlciB0aGV5IGFyZQ0KPiBhbHJlYWR5IHBlbmRpbmcu IElmIHRoZXkgYXJlIHRoZW4gcHJpbnQgYSBtZXNzYWdlLg0KDQpPSywgSSB3b3VsZCBhZGQgdGhp cyBjaGVjayBhbmQgd2FybmluZyBtZXNzYWdlIHRvIG15IGN1cnJlbnQgcGF0Y2ggdG8gZml4IGl0 IA0KaW4gY3VycmVudCBzdGFnZS4gSXMgaXQgT0s/DQoNCj4gDQo+IFRoaXMgd291bGQgbWFrZSBj bGVhciB0byB0aGUgZGV2ZWxvcHBlciB0aGF0IHNvbWV0aGluZyBtYXkgZ28gd3JvbmcNCj4gbGF0 ZXIgb24uDQo+IA0KPiBDaGVlcnMsDQo+IA0KPiAtLQ0KPiBKdWxpZW4gR3JhbGwNCg0KWzFdIGh0 dHBzOi8vZ2l0aHViLmNvbS96ZXBoeXJwcm9qZWN0LXJ0b3MvemVwaHlyL2Jsb2IvZWFmNmNmNzQ1 ZGYzODA3ZTZlDQpjYzk0MWMzYTMwZGU2YzE3OWFlMzU5L2RyaXZlcnMvaW50ZXJydXB0X2NvbnRy b2xsZXIvaW50Y19naWN2My5jI0wyNzQNCg0KQ2hlZXJzDQpIb25nZGENCg0K From xen-devel-bounces@lists.xenproject.org Tue Sep 07 08:11:38 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 08:11:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180566.327280 (Exim 4.92) (envelope-from ) id 1mNWCc-0001ui-0l; Tue, 07 Sep 2021 08:11:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180566.327280; Tue, 07 Sep 2021 08:11:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNWCb-0001ub-Tw; Tue, 07 Sep 2021 08:11:33 +0000 Received: by outflank-mailman (input) for mailman id 180566; Tue, 07 Sep 2021 08:11:32 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNWCa-0001uV-3l for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 08:11:32 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 0fd28f35-4acf-4b82-a357-48ad7d4a734c; Tue, 07 Sep 2021 08:11:30 +0000 (UTC) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04lp2054.outbound.protection.outlook.com [104.47.13.54]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-32-WNOwULU5P1-pdkk2dJTp-Q-2; Tue, 07 Sep 2021 10:11:29 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR04MB4848.eurprd04.prod.outlook.com (2603:10a6:803:55::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.22; Tue, 7 Sep 2021 08:11:26 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4500.014; Tue, 7 Sep 2021 08:11:26 +0000 Received: from [10.156.60.236] (37.24.206.209) by PR0P264CA0107.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:19::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14 via Frontend Transport; Tue, 7 Sep 2021 08:11:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0fd28f35-4acf-4b82-a357-48ad7d4a734c DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1631002289; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NL5+XZXMZuyGIIbtbG3QIPRva4YiO/MGTh6ZA1O4+5Q=; b=LZHnLs+0psfwctVP47zmDYmB6CBiSh5PeGQwksJZ6J1VyK7FBMEK+F61DJaChXXzF//Pyk AwhEvnMgiIVwYq8c22Jsg+2JhEsH2XObER7L6IhNcwp3JnEIs+ZNNkhV81vdg88+e6XLt6 UsPqY4LBPfcgJGXdgSSQMjp8nZ/PAHs= X-MC-Unique: WNOwULU5P1-pdkk2dJTp-Q-2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HYDgMW6ar0nnsQeWaPyczkp4e9EnuxWFXNZYiYnE/o+cKh5jTEVXZ+cLWFB9AO+D80I1GVKLijyrNA0fX7rMfehTgegpgmhntQ+FW3qmj77BEg8vkHh7fVS99Qj86oo8PsXRs35N0rXLI+A6waZ4qeTJAVwmM4QdchYrCl5JnFhYD9J8h84YMxbBGAtgKYiIwoPN1jmz6OOCeSVNLnJLWWeHEZQuAkwYOn1PvsQyL6yG7iudk2hoyCOGaoaftvmzU6x3mwaOoejsUGKtf+NuyKhtszYG3QU1XJh5UoM7I21W5ZF2Bl4L3v8cuei7wDFF4kQSaiN3fLRH9POuJ4ZLOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=95mzxOnnCf3gr5z3HF9NfKZisG77yTQkq6d66SJJ3zc=; b=hShkfj+tuwxIFAK3UUaOvGm0sMKwF9RJqGCjFst8IoXM3pi76pihBz6hBNEoh0FkO1DoYX3SbIRuYyfctrpDqMtnpl8MgUyhGnBMKWQ4ZX5TiK0YTd6fNyO7TFCVShdg0jgDh3wc9zsqrCNQADMrjkD+j913l1nCXmP2ioUs56z2G71lUzyGzE1MUflD/6CJGHx+SZomRN+9dFVBPKF94QnoCGc4yUymj3o7RELQPj8l8Lj8X7AtXi7IK+vTRtfXdH7a+BoSC7zdPR/O7U0Y/dwWA1AO/b4NG58DriIirkOAViXJNejY/b+IPqP566m4hRIA0cARLMJQjJnlcoGmsw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: eikelenboom.it; dkim=none (message not signed) header.d=none;eikelenboom.it; dmarc=none action=none header.from=suse.com; Subject: Re: xen-unstable linux-5.14: 1 of 2 multicall(s) failed: cpu 0 To: Juergen Gross References: <9c36205e-cc37-ed9a-3408-0cccc4a83115@eikelenboom.it> <0ae9bb1e-dacc-a3d2-ed90-f85cb52c698d@suse.com> CC: "xen-devel@lists.xenproject.org" , Sander Eikelenboom From: Jan Beulich Message-ID: <36e8dec0-e777-a4d1-de8a-8991d95407cb@suse.com> Date: Tue, 7 Sep 2021 10:11:24 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: <0ae9bb1e-dacc-a3d2-ed90-f85cb52c698d@suse.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: PR0P264CA0107.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:19::23) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e3344e7c-dcb5-468a-6cc6-08d971d716c3 X-MS-TrafficTypeDiagnostic: VI1PR04MB4848: X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: YKAV0qSviyZeu0E2pe6klOFT9CbT8K8sTd8snsUZIdQ3VAEM1hvwWQfacymFxlDHSsW18TT0tYSOycySklJjPwJ+Sfz+9TuWx4Kbbt1awzT9RtVpd6eSYe/Yj1Y9Jv/MmOYkYN5hf8QU78sSJ6iA2iaMZ0IttvnpF3pRAYzVu4+rbR2FvRG8ZwYMhV2lBEdO8S61MII9lYUCWBZoyghJpPcUE1cmn6ogAXSKv6tgw7vlyofTEmKCTuCn0rw0xnbCsZ5S8/au00jA8kqqEl4wDany8Us/QFIsanbQuAVuMornBE2eUtCTiddWtlxfNzsQRABsoyzhu9oNTdEIzlhCPXuhVV+qTY76PIvS5oSg2lcElx6ihWPeDTXDH768Pnll0bBQBKZRg1SgA44wtrjxUdW60qP/uTZYm4R2VqIKaAcX+mnE12K+tqJyviO0DSlFIbY6YW0IzeCNRDXA8GVSrqDsygqp3ume/Jp+ohyLXwZr/GmBkvqxKi+oBw/6PixnMfY8PQwiXQlEopi/xcPGDw0aH7I6TWHcpSILvwpaob4zl/M868j9EdqRHzXNl+5n9AOxSpQMQMYRxb9C3pJbuHRIlJU6GsrZVdANW43fBR69b9UxrKmQtDDqDs3HJrVBv6knWaVoixTzO7n9SbVWI8aV+R4Sf5O0kp2lMozur91GoxOwo9fY1oB+6/byeNuONellYK+sYuyobN2RWb8TEU88pYGm80jGUsKWb1MOAK6rP8i4KlNfR7MiXSmQgbOt X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(136003)(366004)(346002)(376002)(396003)(39860400002)(6636002)(31686004)(26005)(8676002)(53546011)(4326008)(2906002)(186003)(38100700002)(5660300002)(6862004)(478600001)(86362001)(66946007)(66476007)(66556008)(83380400001)(54906003)(956004)(6486002)(16576012)(31696002)(45080400002)(37006003)(36756003)(316002)(8936002)(2616005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?334//3fKJiwriJdtQBrBaZTrLKEkUyDtivoQuwpw/KB8Yues/I4IhDab6xaQ?= =?us-ascii?Q?2UYYpIIGVqxiDL8xaRKiesqYxCqvv2Lutohikoce6VlLmCqSiWYgTbS1iaB3?= =?us-ascii?Q?I+iXdOMqsx+C4fKcKUrs9cFHpXFYED2Eyl/VoM/c5BFg5dMTigUtTGq5h7NL?= =?us-ascii?Q?9z9T+HQGFvCly/RZKEPFGyAzbi1n14qmM8tz6ecgYl5rOfUBgmk6WeENIxld?= =?us-ascii?Q?ac3TFQSA+GXv3jFI9U8u4Oix3izdrKDXXxcPNQtAZkbmKlp9+0adztLCiKLg?= =?us-ascii?Q?GTW6eWqrMEKffZsMJV9ntWQpl22Guyh8VtZ6TJDjdf/rMTqNBbt6+77vuLgz?= =?us-ascii?Q?TeFrtgIIMnrE+sMCHKLnt07JgYTjtI4lCqMr0fo++pLg8yk7g+c4m8Rfuy1x?= =?us-ascii?Q?W9KHDhnT+WSwBcU1Qx6CK1v36QlqDcDBn6qNTfYk7/VBLzbNyTMtaKRfovHr?= =?us-ascii?Q?Vyhi6p98enDK4GgKu6yjXAMKsBzJNhB8fFDxsuhWI6FV6pqje5C1fMuzSq/p?= =?us-ascii?Q?W1ATr8bTiG+7y8e6OR9wlFypw5rT5Bvmzy/BPvnL1kincBgPffl3Ov7WO80/?= =?us-ascii?Q?WkECkUBUk0EbiFAbx7/Sz0m0M6BUHI38isZNR+BSzZ8mu/wYYraZ5j+jige3?= =?us-ascii?Q?zxqoEtsJHIQl71rqKkalOGsWZpLqrsGJkJ4WBalEM8Hf/ME5LdcMHZ82Vedn?= =?us-ascii?Q?floygQPq20r8YJHAplendf3zIm+fPLGAQbvet3J69AcQz+fDBXLOEgwq8ReY?= =?us-ascii?Q?VmnzRpoFie6SXMgVz/yRl00fF4aI0vgKdmAjMduXZju7YfSu9ay/P/QDPQQx?= =?us-ascii?Q?THfsbx9iCORpfwyPrFY0ouWHZptwhAgeUP8rtlO58SXrxyMeIFjzQPdVVgQr?= =?us-ascii?Q?6Bg17upT/X+388HUsOA5rL3y5zft+MyMP3hvk7ueQuEQ54Vp8nWGYEgbQDxO?= =?us-ascii?Q?Pd6LrZVp/Hcgk+TkUawmnp9H/Qq/BtG54qds4ax5hRzlgZv1/gQnOnYei0LM?= =?us-ascii?Q?waPxh3YYq4ffwaTPpYo5b4WK0K6gBEoNlcPKJrttGrF3LUUok6//qmOFb6S1?= =?us-ascii?Q?FOOrdXtW8YY5RYgRgS3DxMgpg22UYKsOj2rWpMnZSdvrDg/S8auIfaRoH2n3?= =?us-ascii?Q?rl/TaIDdVSJDhVEyp08P/MWoAcfbSFXYy2NG8+enyRtWQlwDaymGuzkhOztA?= =?us-ascii?Q?88jBwHZdlDT/QQReLVwwdEIqrzfANNdH8F9qYVuCa/KIRavWtpR4P0P0UcYZ?= =?us-ascii?Q?6y+rEW9YvbH0tGML0lH4HlYDfHwcRwk0WPNwhk+pf1d21/J1W1rpp4qR+WeV?= =?us-ascii?Q?ItZtnDGFyUx8Wic9x5KjYTZA?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: e3344e7c-dcb5-468a-6cc6-08d971d716c3 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2021 08:11:26.5288 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +aPmfOsaRHhEX/E8tYL8pmiotLzZVpmxU1L3DBNTepnZvNmOVdB7vgOrPbhPQozXuVSWn6ZTRmCJpvQqc9yhTg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4848 On 07.09.2021 09:58, Juergen Gross wrote: > On 06.09.21 23:35, Sander Eikelenboom wrote: >> L.S., >> >> On my AMD box running: >> =C2=A0=C2=A0=C2=A0 xen-unstable changeset: Fri Sep 3 15:10:43 2021 +020= 0 git:2d4978ead4 >> =C2=A0=C2=A0=C2=A0 linux kernel: 5.14.1 >> >> With this setup I'm encountering some issues in dom0, see below. >> >> --=20 >> Sander >> >> xl dmesg gives: >> >> (XEN) [2021-09-06 18:15:04.089] mm.c:3506:d0v0 mfn 63b936 already pinned >> (XEN) [2021-09-06 18:15:04.089] mm.c:3506:d0v0 mfn 6a0622 already pinned >> (XEN) [2021-09-06 18:15:04.089] mm.c:3506:d0v0 mfn 6b63da already pinned >> (XEN) [2021-09-06 18:15:04.089] mm.c:3506:d0v0 mfn 638dd9 already pinned >> (XEN) [2021-09-06 18:15:04.089] mm.c:3506:d0v0 mfn 68a7bc already pinned >> (XEN) [2021-09-06 18:15:04.089] mm.c:3506:d0v0 mfn 63c27d already pinned >> (XEN) [2021-09-06 18:15:04.089] mm.c:3506:d0v0 mfn 6a04f2 already pinned >> (XEN) [2021-09-06 18:15:04.089] mm.c:3506:d0v0 mfn 690d49 already pinned >> (XEN) [2021-09-06 18:15:04.089] mm.c:3506:d0v0 mfn 6959a0 already pinned >> (XEN) [2021-09-06 18:15:04.089] mm.c:3506:d0v0 mfn 6a055e already pinned >> (XEN) [2021-09-06 18:15:04.090] mm.c:3506:d0v0 mfn 639437 already pinned >> >> >> dmesg gives: >> >> [34321.304270] ------------[ cut here ]------------ >> [34321.304277] WARNING: CPU: 0 PID: 23628 at=20 >> arch/x86/xen/multicalls.c:102 xen_mc_flush+0x176/0x1a0 >> [34321.304288] Modules linked in: >> [34321.304291] CPU: 0 PID: 23628 Comm: apt-get Not tainted=20 >> 5.14.1-20210906-doflr-mac80211debug+ #1 >> [34321.304294] Hardware name: MSI MS-7640/890FXA-GD70 (MS-7640)=C2=A0 , = BIOS=20 >> V1.8B1 09/13/2010 >> [34321.304296] RIP: e030:xen_mc_flush+0x176/0x1a0 >> [34321.304300] Code: 89 45 18 48 c1 e9 3f 48 89 ce e9 20 ff ff ff e8 60= =20 >> 03 00 00 66 90 5b 5d 41 5c 41 5d c3 48 c7 45 18 ea ff ff ff be 01 00 00= =20 >> 00 <0f> 0b 8b 55 00 48 c7 c7 10 97 aa 82 31 db 49 c7 c5 38 97 aa 82 65 >> [34321.304303] RSP: e02b:ffffc90000a97c90 EFLAGS: 00010002 >> [34321.304305] RAX: ffff88807d416398 RBX: ffff88807d416350 RCX:=20 >> ffff88807d416398 >> [34321.304306] RDX: 0000000000000001 RSI: 0000000000000001 RDI:=20 >> deadbeefdeadf00d >> [34321.304308] RBP: ffff88807d416300 R08: aaaaaaaaaaaaaaaa R09:=20 >> ffff888006160cc0 >> [34321.304309] R10: deadbeefdeadf00d R11: ffffea000026a600 R12:=20 >> 0000000000000000 >> [34321.304310] R13: ffff888012f6b000 R14: 0000000012f6b000 R15:=20 >> 0000000000000001 >> [34321.304320] FS:=C2=A0 00007f5071177800(0000) GS:ffff88807d400000(0000= )=20 >> knlGS:0000000000000000 >> [34321.304322] CS:=C2=A0 10000e030 DS: 0000 ES: 0000 CR0: 00000000800500= 33 >> [34321.304323] CR2: 00007f506f542000 CR3: 00000000160cc000 CR4:=20 >> 0000000000000660 >> [34321.304326] Call Trace: >> [34321.304331]=C2=A0 xen_alloc_pte+0x294/0x320 >> [34321.304334]=C2=A0 move_pgt_entry+0x165/0x4b0 >> [34321.304339]=C2=A0 move_page_tables+0x6fa/0x8d0 >> [34321.304342]=C2=A0 move_vma.isra.44+0x138/0x500 >> [34321.304345]=C2=A0 __x64_sys_mremap+0x296/0x410 >> [34321.304348]=C2=A0 do_syscall_64+0x3a/0x80 >> [34321.304352]=C2=A0 entry_SYSCALL_64_after_hwframe+0x44/0xae >> [34321.304355] RIP: 0033:0x7f507196301a >=20 > I can see why this failure is occurring, but I'm not sure which way is > the best to fix it. >=20 > The problem is that a pinned page table is moved: the pmd entry > referencing it is cleared and a new reference is put into the pmd. > This is done by getting the old pmd entry, clearing that entry, and then > using pmd_populate() to write the new pmd entry. pmd_populate() will > lead to a call of xen_pte_alloc() trying to pin the referenced page > table, which is failing, as it is already pinned. >=20 > The problem has been introduced by commit 0881ace292b662d2 in kernel > 5.14. >=20 > Following solutions would be possible: >=20 > 1. When running as PV guest skip the optimization of move_pgt_entry() > by letting arch_supports_page_table_move() return false. This will > result in a performance drop in some cases. >=20 > 2. Unpin the page table before calling pmd_populate(). This adds some > unneeded hypercall and without flushing the TLB I'm feeling uneasy > to do that. I agree as far as the "unneeded hypercall" aspect goes, but I don't see any connection to the TLB (or a need to flush it): Pinning has nothing to do with insertion into a live page table; a pinned page table can be entirely free floating. It's the removal from a (possibly) live page table which would require a flush. > 3. Add a check in xen_pte_alloc() if the page table is pinned already > and if this is the case, don't do the pinning. This is a rather clean > solution, but will result in other failures if a page table is used > multiple times (this case would be caught today as in the failure > above). >=20 > My tendency is towards solution 3 as it is local to Xen code and has the > best performance. I agree 3 looks most promising. I can't judge how big of a risk there is for a page table to get used in more than one place, and hence how important it is to be able to detect that case. Jan From xen-devel-bounces@lists.xenproject.org Tue Sep 07 08:16:04 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 08:16:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180572.327292 (Exim 4.92) (envelope-from ) id 1mNWGw-0002ZH-Jx; Tue, 07 Sep 2021 08:16:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180572.327292; Tue, 07 Sep 2021 08:16:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNWGw-0002ZA-EA; Tue, 07 Sep 2021 08:16:02 +0000 Received: by outflank-mailman (input) for mailman id 180572; Tue, 07 Sep 2021 08:16:01 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNWGv-0002Yy-86 for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 08:16:01 +0000 Received: from smtp-out2.suse.de (unknown [195.135.220.29]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id d545c744-0fb3-11ec-b0da-12813bfff9fa; Tue, 07 Sep 2021 08:15:59 +0000 (UTC) Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 02C2B1FD3E; Tue, 7 Sep 2021 08:15:59 +0000 (UTC) Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap1.suse-dmz.suse.de (Postfix) with ESMTPS id D17FB132AB; Tue, 7 Sep 2021 08:15:58 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap1.suse-dmz.suse.de with ESMTPSA id zpc8L74fN2FKHgAAGKfGzw (envelope-from ); Tue, 07 Sep 2021 08:15:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d545c744-0fb3-11ec-b0da-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1631002559; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=f6zXc+LSbfebUefAjRoXqLW7t85EtxUizUQ2aQ73x/0=; b=gzbyRSyonhBjA+jvjd6JqRiJKCTbqKUWaChVq35WHoHLjJpnUn7x7SM//07TPvom7T2Jx8 zaRVytzbgMBHNS/pf/1LvLEqs0+Y1aTZ/CAdNLDl9HksxD7b0oJVeC3z/1knuk2VVacpKe yDeDwJ+/jZs/Y+xulyUPyitGkMdxsY8= Subject: Re: xen-unstable linux-5.14: 1 of 2 multicall(s) failed: cpu 0 To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Sander Eikelenboom References: <9c36205e-cc37-ed9a-3408-0cccc4a83115@eikelenboom.it> <0ae9bb1e-dacc-a3d2-ed90-f85cb52c698d@suse.com> <36e8dec0-e777-a4d1-de8a-8991d95407cb@suse.com> From: Juergen Gross Message-ID: <96b25976-4109-8aa2-b763-f00cfb1c20f7@suse.com> Date: Tue, 7 Sep 2021 10:15:58 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <36e8dec0-e777-a4d1-de8a-8991d95407cb@suse.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="rkLvAjn7JyDnXoy3ThW9ioqDZPHBBuMI3" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --rkLvAjn7JyDnXoy3ThW9ioqDZPHBBuMI3 Content-Type: multipart/mixed; boundary="s002Bm9I1HUjHEKtUbAXCiPi5Qbn6KY6W"; protected-headers="v1" From: Juergen Gross To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Sander Eikelenboom Message-ID: <96b25976-4109-8aa2-b763-f00cfb1c20f7@suse.com> Subject: Re: xen-unstable linux-5.14: 1 of 2 multicall(s) failed: cpu 0 References: <9c36205e-cc37-ed9a-3408-0cccc4a83115@eikelenboom.it> <0ae9bb1e-dacc-a3d2-ed90-f85cb52c698d@suse.com> <36e8dec0-e777-a4d1-de8a-8991d95407cb@suse.com> In-Reply-To: <36e8dec0-e777-a4d1-de8a-8991d95407cb@suse.com> --s002Bm9I1HUjHEKtUbAXCiPi5Qbn6KY6W Content-Type: multipart/mixed; boundary="------------D51AD51E6B56470FE6CB0F0C" Content-Language: en-US This is a multi-part message in MIME format. --------------D51AD51E6B56470FE6CB0F0C Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 07.09.21 10:11, Jan Beulich wrote: > On 07.09.2021 09:58, Juergen Gross wrote: >> On 06.09.21 23:35, Sander Eikelenboom wrote: >>> L.S., >>> >>> On my AMD box running: >>> =C2=A0=C2=A0=C2=A0 xen-unstable changeset: Fri Sep 3 15:10:43 2021 = +0200 git:2d4978ead4 >>> =C2=A0=C2=A0=C2=A0 linux kernel: 5.14.1 >>> >>> With this setup I'm encountering some issues in dom0, see below. >>> >>> --=20 >>> Sander >>> >>> xl dmesg gives: >>> >>> (XEN) [2021-09-06 18:15:04.089] mm.c:3506:d0v0 mfn 63b936 already pin= ned >>> (XEN) [2021-09-06 18:15:04.089] mm.c:3506:d0v0 mfn 6a0622 already pin= ned >>> (XEN) [2021-09-06 18:15:04.089] mm.c:3506:d0v0 mfn 6b63da already pin= ned >>> (XEN) [2021-09-06 18:15:04.089] mm.c:3506:d0v0 mfn 638dd9 already pin= ned >>> (XEN) [2021-09-06 18:15:04.089] mm.c:3506:d0v0 mfn 68a7bc already pin= ned >>> (XEN) [2021-09-06 18:15:04.089] mm.c:3506:d0v0 mfn 63c27d already pin= ned >>> (XEN) [2021-09-06 18:15:04.089] mm.c:3506:d0v0 mfn 6a04f2 already pin= ned >>> (XEN) [2021-09-06 18:15:04.089] mm.c:3506:d0v0 mfn 690d49 already pin= ned >>> (XEN) [2021-09-06 18:15:04.089] mm.c:3506:d0v0 mfn 6959a0 already pin= ned >>> (XEN) [2021-09-06 18:15:04.089] mm.c:3506:d0v0 mfn 6a055e already pin= ned >>> (XEN) [2021-09-06 18:15:04.090] mm.c:3506:d0v0 mfn 639437 already pin= ned >>> >>> >>> dmesg gives: >>> >>> [34321.304270] ------------[ cut here ]------------ >>> [34321.304277] WARNING: CPU: 0 PID: 23628 at >>> arch/x86/xen/multicalls.c:102 xen_mc_flush+0x176/0x1a0 >>> [34321.304288] Modules linked in: >>> [34321.304291] CPU: 0 PID: 23628 Comm: apt-get Not tainted >>> 5.14.1-20210906-doflr-mac80211debug+ #1 >>> [34321.304294] Hardware name: MSI MS-7640/890FXA-GD70 (MS-7640)=C2=A0= , BIOS >>> V1.8B1 09/13/2010 >>> [34321.304296] RIP: e030:xen_mc_flush+0x176/0x1a0 >>> [34321.304300] Code: 89 45 18 48 c1 e9 3f 48 89 ce e9 20 ff ff ff e8 = 60 >>> 03 00 00 66 90 5b 5d 41 5c 41 5d c3 48 c7 45 18 ea ff ff ff be 01 00 = 00 >>> 00 <0f> 0b 8b 55 00 48 c7 c7 10 97 aa 82 31 db 49 c7 c5 38 97 aa 82 6= 5 >>> [34321.304303] RSP: e02b:ffffc90000a97c90 EFLAGS: 00010002 >>> [34321.304305] RAX: ffff88807d416398 RBX: ffff88807d416350 RCX: >>> ffff88807d416398 >>> [34321.304306] RDX: 0000000000000001 RSI: 0000000000000001 RDI: >>> deadbeefdeadf00d >>> [34321.304308] RBP: ffff88807d416300 R08: aaaaaaaaaaaaaaaa R09: >>> ffff888006160cc0 >>> [34321.304309] R10: deadbeefdeadf00d R11: ffffea000026a600 R12: >>> 0000000000000000 >>> [34321.304310] R13: ffff888012f6b000 R14: 0000000012f6b000 R15: >>> 0000000000000001 >>> [34321.304320] FS:=C2=A0 00007f5071177800(0000) GS:ffff88807d400000(0= 000) >>> knlGS:0000000000000000 >>> [34321.304322] CS:=C2=A0 10000e030 DS: 0000 ES: 0000 CR0: 00000000800= 50033 >>> [34321.304323] CR2: 00007f506f542000 CR3: 00000000160cc000 CR4: >>> 0000000000000660 >>> [34321.304326] Call Trace: >>> [34321.304331]=C2=A0 xen_alloc_pte+0x294/0x320 >>> [34321.304334]=C2=A0 move_pgt_entry+0x165/0x4b0 >>> [34321.304339]=C2=A0 move_page_tables+0x6fa/0x8d0 >>> [34321.304342]=C2=A0 move_vma.isra.44+0x138/0x500 >>> [34321.304345]=C2=A0 __x64_sys_mremap+0x296/0x410 >>> [34321.304348]=C2=A0 do_syscall_64+0x3a/0x80 >>> [34321.304352]=C2=A0 entry_SYSCALL_64_after_hwframe+0x44/0xae >>> [34321.304355] RIP: 0033:0x7f507196301a >> >> I can see why this failure is occurring, but I'm not sure which way is= >> the best to fix it. >> >> The problem is that a pinned page table is moved: the pmd entry >> referencing it is cleared and a new reference is put into the pmd. >> This is done by getting the old pmd entry, clearing that entry, and th= en >> using pmd_populate() to write the new pmd entry. pmd_populate() will >> lead to a call of xen_pte_alloc() trying to pin the referenced page >> table, which is failing, as it is already pinned. >> >> The problem has been introduced by commit 0881ace292b662d2 in kernel >> 5.14. >> >> Following solutions would be possible: >> >> 1. When running as PV guest skip the optimization of move_pgt_entry() >> by letting arch_supports_page_table_move() return false. This wil= l >> result in a performance drop in some cases. >> >> 2. Unpin the page table before calling pmd_populate(). This adds some >> unneeded hypercall and without flushing the TLB I'm feeling uneas= y >> to do that. >=20 > I agree as far as the "unneeded hypercall" aspect goes, but I don't > see any connection to the TLB (or a need to flush it): Pinning has > nothing to do with insertion into a live page table; a pinned page > table can be entirely free floating. It's the removal from a > (possibly) live page table which would require a flush. And this removal is happening: /* Clear the pmd */ pmd =3D *old_pmd; pmd_clear(old_pmd); VM_BUG_ON(!pmd_none(*new_pmd)); pmd_populate(mm, new_pmd, pmd_pgtable(pmd)); So unpinning after calling pmd_clear() seems to be risky. >=20 >> 3. Add a check in xen_pte_alloc() if the page table is pinned already >> and if this is the case, don't do the pinning. This is a rather c= lean >> solution, but will result in other failures if a page table is us= ed >> multiple times (this case would be caught today as in the failure= >> above). >> >> My tendency is towards solution 3 as it is local to Xen code and has t= he >> best performance. >=20 > I agree 3 looks most promising. I can't judge how big of a risk > there is for a page table to get used in more than one place, and > hence how important it is to be able to detect that case. Thanks. I'm going that route then. Juergen --------------D51AD51E6B56470FE6CB0F0C Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Transfer-Encoding: quoted-printable Content-Description: OpenPGP public key Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy= cWx w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O= f8Z d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y= 9bf IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq= G7/ 377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR= 3Jv c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA= QIe AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT= hpw dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0= MbD 1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv= oPH Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v= 5QL +qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ= 2Vu IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC= QoL BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr= Wf0 teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC= /nu AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh= ITT d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm= XBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz= 80h SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC= AcD AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn= FOX gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1= jnD kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0= N51 N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l= otu fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1= tqS EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA= hsD BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3= g3O ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5= dM7 wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5= D+j LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm= V2x AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N= Eaw QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW= nHI s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR= wgn BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV= bVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk= pEd IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA= QAB wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw= Tbe 8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1= vJz Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8= VGi wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW= svi uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX= zXs ZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------D51AD51E6B56470FE6CB0F0C-- --s002Bm9I1HUjHEKtUbAXCiPi5Qbn6KY6W-- --rkLvAjn7JyDnXoy3ThW9ioqDZPHBBuMI3 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmE3H74FAwAAAAAACgkQsN6d1ii/Ey+R 2wf/T8k4DXCL0IjMFs5iazUnq4wLJn+r9VvSXMFGOPepylzZ6ZLtnB7VqXksgOtoz62aIVt0LUHC rxR662Mno0CP4jbyONfxh+fxC3ijHsIylXp7bctAtEoEUTbrqdFDZGIaFadzUiGFGrvNr5H/2bUA fwzqoF6wmKwmpb3vMYu/SaRS3x8Lfu6LgkZLby78LFfi34oVE/vTrHmo3TSVeygtIBA2kPgjd74g wqfKoILPxujt4bYrR0Z4e6FzySLugxpJX3g2a207sJheF7IOyHPX0gzVjRyrM33PySLelNpOI4Pi iSVHCVXafnfVcMebQBY6FM4ImjEi0p2vDMOJhb64bg== =IP9j -----END PGP SIGNATURE----- --rkLvAjn7JyDnXoy3ThW9ioqDZPHBBuMI3-- From xen-devel-bounces@lists.xenproject.org Tue Sep 07 08:18:46 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 08:18:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180585.327307 (Exim 4.92) (envelope-from ) id 1mNWJX-0003HQ-1i; Tue, 07 Sep 2021 08:18:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180585.327307; Tue, 07 Sep 2021 08:18:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNWJW-0003HJ-UF; Tue, 07 Sep 2021 08:18:42 +0000 Received: by outflank-mailman (input) for mailman id 180585; Tue, 07 Sep 2021 08:18:40 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNWJU-0003H6-Mf for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 08:18:40 +0000 Received: from mx0b-0039f301.pphosted.com (unknown [148.163.137.242]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 34d25f74-0fb4-11ec-b0da-12813bfff9fa; Tue, 07 Sep 2021 08:18:39 +0000 (UTC) Received: from pps.filterd (m0174681.ppops.net [127.0.0.1]) by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 1877hJUh002674; Tue, 7 Sep 2021 08:18:37 GMT Received: from eur05-db8-obe.outbound.protection.outlook.com (mail-db8eur05lp2111.outbound.protection.outlook.com [104.47.17.111]) by mx0b-0039f301.pphosted.com with ESMTP id 3ax2jngdvj-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 07 Sep 2021 08:18:37 +0000 Received: from AM7PR03MB6325.eurprd03.prod.outlook.com (2603:10a6:20b:13c::18) by AM6PR03MB4695.eurprd03.prod.outlook.com (2603:10a6:20b:11::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.24; Tue, 7 Sep 2021 08:18:34 +0000 Received: from AM7PR03MB6325.eurprd03.prod.outlook.com ([fe80::d9b7:c0ab:2c2f:5b44]) by AM7PR03MB6325.eurprd03.prod.outlook.com ([fe80::d9b7:c0ab:2c2f:5b44%3]) with mapi id 15.20.4478.025; Tue, 7 Sep 2021 08:18:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 34d25f74-0fb4-11ec-b0da-12813bfff9fa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lTSnc8k0z9+pblZq22nD0t1fgXmhduQuhih1IY1gGEZl9W/2EI1a8b5PJVRc5N5tw2dVx6UrWE7xqxcy7pm/glHLya2OP2+3XlSVSIwRZxhLbJrt6SQIO6xjmPOltCfVOFp1hyf7QZ1P4T4M/pts5B5A8QR0oVrh62VlsW31zT2l6nZsU3raScdiRO9Si8qKGyi6mrdhzJoleqWxJwYBA2lWl5Hsdz0QXboq5wPml3FNjwZSdcKwRfRX+h3F5/94tXNsBryoXomC9uUMBFYRnEIdPunBYzAt2YwN2IhdNSEizzSiFEa7iqrCoWAcQo/9qG6SchK0FylxksP+91t9Mw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=g9FL1dpPHRZyfhmVFJHfBWM1lqcz7ec+X2EeUF80IHM=; b=GFtRRX5L56B5MHIbu7t5W6adWjo5EgbAd3N9xb5AbiCijZGEsPbLm1bg90xzukZAYXZhkHtNTQvQfpyKfEwUQHAQc1SQpFpVNPsZnfRri4bWLpRmXxxKfPGZjOZUsoJzTa4gGX8WFv8GIMalsdAXYHDHDRAC6s6ds3W7fXhyzssyA4g3nXu/EiWqwzEHuI45rDSEWTNErHvFy2gHf/P00akRtDMD8aDJLpQWiF4dAwVdYiu76bgDQfc+z2D32hRnHCbxB5VeMWYdvwCPP27Yh5GnK1XoCgcYQutkYNCsnVIrLxwgxVRA9Ll01oRojey2DlmUfxSgfmxQXEqAt776gA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=g9FL1dpPHRZyfhmVFJHfBWM1lqcz7ec+X2EeUF80IHM=; b=wuW6nht+sO8HhQhW0txFhOjracm/au/xYy4QuwiYu5XyZQDfsn+Q7pbF0H9qTUDRhzc68e39PUZhWApXTKkdOTRHp1ZVM7IRq7Nn8faFmYiUl1aktMh4OXvBC/X6YYMyVp9oFJzUVJLPd4Fk5Q2aO9fuSrZ7cZQOXPx4PjvxIl5K4oB/X4NXgv9ZMHNxC+zBhtZGVJFhIoggxXz2P7FoBnVdFqlbe61PCBk/wvPfYW/ilUiU0dfFqEV/jbGrZ4oF7E2LwV+t+/1mjvgBZ8r13YJR0UilwnBzepfHLxuJklO4IlRjOf4u/179geYNk0iv9PPfc15Vmn2FWHYUh0OBgQ== From: Oleksandr Andrushchenko To: Jan Beulich , Oleksandr Andrushchenko CC: "julien@xen.org" , "sstabellini@kernel.org" , Oleksandr Tyshchenko , Volodymyr Babchuk , Artem Mygaiev , "roger.pau@citrix.com" , Bertrand Marquis , Rahul Singh , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH 8/9] vpci/header: Reset the command register when adding devices Thread-Topic: [PATCH 8/9] vpci/header: Reset the command register when adding devices Thread-Index: AQHXoKxjFI8WSqpeJkWkpzZfft/zi6uXHR6AgAEZm4CAAASsgIAABSgA Date: Tue, 7 Sep 2021 08:18:34 +0000 Message-ID: <0e3942a5-9105-c99e-f15e-dcf35aae142a@epam.com> References: <20210903100831.177748-1-andr2000@gmail.com> <20210903100831.177748-9-andr2000@gmail.com> <5366265c-d169-041d-f812-1c49260f6499@epam.com> <8f1816db-798b-15d9-7343-2199eb8f39e0@suse.com> In-Reply-To: <8f1816db-798b-15d9-7343-2199eb8f39e0@suse.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=epam.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 80ec8ef6-7e8b-4b10-3570-08d971d8160d x-ms-traffictypediagnostic: AM6PR03MB4695: x-ms-exchange-transport-forked: True x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: /EailDQw6DYN+N3MSDGmyX3V9KS1+MFivTTkztG2iC4uwDH7ch+fnvwO+9XzJvREChYRNDRC+DImLJuJLX7B+7IpX7F93mJd0QShSXktMhhK/BQTtylX+3CMvF4nBMjp6Cg0no6ol2AqRDC5SwaHpNj4EEUSHMI2wtjO2VGXEMEDVAEQTeFJ7gY/w0q69atHRxR1ov4hTgN3GApF+UjStkPexrol6tfLrFKd7oXUHW4q9cj2cc3wq14kEHzr+6QOYQ9IfW3f2he/mt12Vkrxeup5Wo8/R1rkYFv4ZBp/HcFdPMTL0YtjyfUheAXpvMxhV4RYN2h9A+ZNlUV7KED+AJO9TUPOhAec3SWFJ/x2ib5VwVS3OCyGOcQuzVJcPPsB6w18bPzp893fl74EdTKvqZKNPg4YCZlsnIWG1KLYH5WMFR6n7/xFiiHFqEt+KXXduketbUNM5iIbJuQLKQk9oIDHCu2DUdgeQJK7/rFxoB9EMHi1iZEtRjiL21s4+uZ1fQzJsh7leqIGH5gj26KvMgictdZA4XSpnPgTHiwmTo0rn7kK68jeyXHLvE2psY/CXosrOwIStIKh8JqYUGeUHTcMcnNERG7ydE3dxObD5cBdYRZdl1vhz3IeBW2+IGAx8oOKCFXUfJDVbwb/J6jBvs/Mh4Scby9BJNYyPbQySscZZfr2eafKIhmHpmTFXWU3RX+PwUUpjgXR4KBHcatwxVFoaGonV5/D0kNoqT4sOBRRFKx5lTmVBF/ZC7dfXMqi x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM7PR03MB6325.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(39860400002)(136003)(366004)(376002)(346002)(396003)(36756003)(66446008)(66556008)(31686004)(83380400001)(2616005)(66476007)(2906002)(76116006)(110136005)(66946007)(122000001)(38070700005)(38100700002)(91956017)(86362001)(31696002)(8936002)(6486002)(8676002)(64756008)(316002)(71200400001)(54906003)(478600001)(6506007)(5660300002)(53546011)(186003)(26005)(4326008)(6512007)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?RDZpK2JhYjNqRFpOVVNHT2J3N2JlWndVVW1KN2sxeE9NRTFOSnY3ZkYyNXFm?= =?utf-8?B?VVlhSVFLT3VPSjI4U0I0OVArbDBNUFVwRXJRWGtnUXJ2dkROZzh5RlpOSTlR?= =?utf-8?B?Yyt1SGlab0pkR1hKa1JQQzJ6UnlSM1llNU1XZ05FVnF5dk8ram9Zb2g4MG9F?= =?utf-8?B?Y2dGMkszd01KQkdNdEd5eTcwQWorZ0UxK1pCUEswUUVyd3JvcmlVSnVHTWEy?= =?utf-8?B?UGRIR1Ztc2tpMHY5Qmk3aFFLc0c2R2syNVlyR3BpU0lFYVhFaStRRlR6aTdh?= =?utf-8?B?Y2ZNaElCdThsY09pVzViL2JuMzVYOXBncld2V0ZTMFJ2a1FrZFhpZlBHWXEw?= =?utf-8?B?RkxHUmR2L0twSGRPNk5SL1c0SXhGUURWcEhwZHRyNzlPLytoMm45UHl1TTNr?= =?utf-8?B?c2RqZmF5MkE4Zjd3c1pkYjYvWEFvYVdZdmx2eHpnWUJLY2Z2V3FBWjlSbDdi?= =?utf-8?B?dXA4ZUZvamZ1alJ4bHFXcmZHaEk0MVlyWEZnWmhYcy80NWU0a3FKWThRQk5K?= =?utf-8?B?MXZZYXd3YktnNEtUY0QzTDhqQzBRcTdBRC96MU9OeVlWV2tnSWttQzVIMUlt?= =?utf-8?B?ZjFSa0xvaWhTSHRzL1ZJZzgrdTZjM1g4NjREOVMyLzRFNHdWNXFUb3VPWmJF?= =?utf-8?B?QjkxQkN6WEVmK1dGY3BRNzRpQWlRamsvdUZ5T29zVW5zTTJNWW1NZzN5elly?= =?utf-8?B?Q0FKUHB2NGEwZWFBZUlOWDBCbXpxUG1HWnNNc1BaS2g2NFpUSHZVdFlxazRP?= =?utf-8?B?UThKSk9ybUdza28vT2c4azhpSm9tQW1SK2czRDlTYkxZYW5DWXh4WTJjWW1n?= =?utf-8?B?Y2p3N3hXZmIzL2hTa2ZyZ09kOXpPTDZxQVBBVVBvMWsxU3B2S3ZFa2JnWWNK?= =?utf-8?B?aTMzQUxuWG1VRVU4U1NnRkMvVkYxZ0JLMWFNbHJwYnlsQ1NUVnQyQ2ZUcWpt?= =?utf-8?B?dS9vbjNhcUZaWHVRek53RGRET2lic2JSSjJHZkFERUVkOHNST1dZNFRwS0ZB?= =?utf-8?B?cTl5RUp2VlVPNVVpdWF1NWlESWpLVTF5a1dSenNEOXgrNWtJSGExSk92MVBp?= =?utf-8?B?TVdBQU5Ra2FKMG5KWERXMTZZeFNlUkM5bUo1VlJMY0JRNEdkYTQvMW5oQW9t?= =?utf-8?B?RWhIREtubVFEV1NXMnlmdjF3bkZmTUNrbmluYWI0YmxrMkpGTjVxYU9UbUhs?= =?utf-8?B?Qy9wdlQwL2dKZW1sMTdvZkIzVlRGTzIzdXJGQUtHOXZLWDBmWUV1anlKYk5Y?= =?utf-8?B?dTFCdm5vYTExWEtFVHA0Wk1qT3pDTlV0SCtLN0NaL1JPay8zL1NJVy83cE0v?= =?utf-8?B?YUNEa0ZqbU5RRWtGM2JWcCtWems1QldFd0JaNDZwL3d5OFdSUFFRb1hDSjJQ?= =?utf-8?B?ZVlYSkxMMEQ0UWxVdmlhVVRGL01tRWpWSnZUbEVmbjBwUThKaXhIN0NUQWl1?= =?utf-8?B?MlcyUHkrZFAwSmRFdkNEaUVWV2JtZ2xJNmFJdWtwTFdvZU1FQTJtOUhKT3Ev?= =?utf-8?B?M3B0OVRjZUgyOHBhSHQyT21WNUJJYnYxd3hVOEpRQ3NYRWd5am5saHk5Qk0y?= =?utf-8?B?R09JbHFEcXlHaVpBakZWYzlkRXprdmwwQ0NWd1BKVGpUMExncVZ0TENnRHRi?= =?utf-8?B?LzVLREs3V3pNL05Wa1VqMXRBdFBCL2F2MkpEZGRhSWt6VXdjSkdHSFVSSGd4?= =?utf-8?B?VFlzd1IzRDUwVFZWUGRlQWtvTE8vQ1pBSCtPQ1NhZkNOSzFWSm4wTlUxWHVY?= =?utf-8?Q?1fvXBoHJYZ6GRDY91VkUcbbo2YolLRGRAk36uOD?= Content-Type: text/plain; charset="utf-8" Content-ID: <5EF03F4C88D4E44E810E69FA9E17AFE9@eurprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: epam.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM7PR03MB6325.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 80ec8ef6-7e8b-4b10-3570-08d971d8160d X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Sep 2021 08:18:34.5608 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: s8t+v7+sps+QIUclH28VBXhcdovCSRxu0gIXEqxa3rmqjtbexIDWfYjLC+O/Mgsnzp80JCXWPnKNxA0LvmpvXaa2d5R0kjrUo3DkIcVAblVEH5l1oOgUIMK2c71GKM8B X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR03MB4695 X-Proofpoint-ORIG-GUID: MOPuO5Nv1ur17sk8Con6XVQ1JhWNLWkG X-Proofpoint-GUID: MOPuO5Nv1ur17sk8Con6XVQ1JhWNLWkG X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.391,FMLib:17.0.607.475 definitions=2021-09-07_02,2021-09-03_01,2020-04-07_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 adultscore=0 clxscore=1015 priorityscore=1501 impostorscore=0 phishscore=0 spamscore=0 suspectscore=0 lowpriorityscore=0 mlxlogscore=999 bulkscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2108310000 definitions=main-2109070055 DQpPbiAwNy4wOS4yMSAxMTowMCwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDA3LjA5LjIwMjEg MDk6NDMsIE9sZWtzYW5kciBBbmRydXNoY2hlbmtvIHdyb3RlOg0KPj4gT24gMDYuMDkuMjEgMTc6 NTUsIEphbiBCZXVsaWNoIHdyb3RlOg0KPj4+IE9uIDAzLjA5LjIwMjEgMTI6MDgsIE9sZWtzYW5k ciBBbmRydXNoY2hlbmtvIHdyb3RlOg0KPj4+PiAtLS0gYS94ZW4vZHJpdmVycy92cGNpL2hlYWRl ci5jDQo+Pj4+ICsrKyBiL3hlbi9kcml2ZXJzL3ZwY2kvaGVhZGVyLmMNCj4+Pj4gQEAgLTgxMSw2 ICs4MTEsMTYgQEAgaW50IHZwY2lfYmFyX2FkZF9oYW5kbGVycyhjb25zdCBzdHJ1Y3QgZG9tYWlu ICpkLCBzdHJ1Y3QgcGNpX2RldiAqcGRldikNCj4+Pj4gICAgICAgICAgICBncHJpbnRrKFhFTkxP R19FUlIsDQo+Pj4+ICAgICAgICAgICAgICAgICIlcHA6IGZhaWxlZCB0byBhZGQgQkFSIGhhbmRs ZXJzIGZvciBkb20lZFxuIiwgJnBkZXYtPnNiZGYsDQo+Pj4+ICAgICAgICAgICAgICAgIGQtPmRv bWFpbl9pZCk7DQo+Pj4+ICsNCj4+Pj4gKyAgICAvKg0KPj4+PiArICAgICAqIFJlc2V0IHRoZSBj b21tYW5kIHJlZ2lzdGVyOiBpdCBpcyBwb3NzaWJsZSB0aGF0IHdoZW4gcGFzc2luZw0KPj4+PiAr ICAgICAqIHRocm91Z2ggYSBQQ0kgZGV2aWNlIGl0cyBtZW1vcnkgZGVjb2RpbmcgYml0cyBpbiB0 aGUgY29tbWFuZA0KPj4+PiArICAgICAqIHJlZ2lzdGVyIGFyZSBhbHJlYWR5IHNldC4gVGh1cywg YSBndWVzdCBPUyBtYXkgbm90IHdyaXRlIHRvIHRoZQ0KPj4+PiArICAgICAqIGNvbW1hbmQgcmVn aXN0ZXIgdG8gdXBkYXRlIG1lbW9yeSBkZWNvZGluZywgc28gZ3Vlc3QgbWFwcGluZ3MNCj4+Pj4g KyAgICAgKiAoZ3Vlc3QncyB2aWV3IG9mIHRoZSBCQVJzKSBhcmUgbGVmdCBub3QgdXBkYXRlZC4N Cj4+Pj4gKyAgICAgKi8NCj4+Pj4gKyAgICBwY2lfY29uZl93cml0ZTE2KHBkZXYtPnNiZGYsIFBD SV9DT01NQU5ELCAwKTsNCj4+PiBDYW4geW91IHJlYWxseSBibGluZGx5IHdyaXRlIDAgaGVyZT8g V2hhdCBhYm91dCBiaXRzIHRoYXQgaGF2ZSB0byBiZQ0KPj4+IHVuZGVyIGhvc3QgY29udHJvbCwg ZS5nLiBJTlRYX0RJU0FCTEU/IEkgY2FuIHNlZSB0aGF0IHlvdSBtYXkgd2FudCB0bw0KPj4+IGhh bmQgb2ZmIHdpdGggSS9PIGFuZCBtZW1vcnkgZGVjb2Rpbmcgb2ZmIGFuZCBidXMgbWFzdGVyaW5n IGRpc2FibGVkLA0KPj4+IGJ1dCBmb3IgZXZlcnkgb3RoZXIgYml0IChpbmNsdWRpbmcgcmVzZXJ2 ZWQgb25lcykgSSdkIGV4cGVjdCBzZXBhcmF0ZQ0KPj4+IGp1c3RpZmljYXRpb24gKGluIHRoZSBj b21taXQgbWVzc2FnZSkuDQo+PiBBY2NvcmRpbmcgdG8gIlBDSSBMT0NBTCBCVVMgU1BFQ0lGSUNB VElPTiwgUkVWLiAzLjAiIEkgaGF2ZSBhdCBoYW5kLA0KPj4gc2VjdGlvbiAiNi4yLjIgRGV2aWNl IENvbnRyb2wiIHNheXMgdGhhdCB0aGUgcmVzZXQgc3RhdGUgb2YgdGhlIGNvbW1hbmQNCj4+IHJl Z2lzdGVyIGlzIHR5cGljYWxseSAwLCBzbyB0aGlzIGlzIHdoeSBJIGNob3NlIHRvIHdyaXRlIDAg aGVyZSwgZS5nLg0KPj4gbWFrZSB0aGUgY29tbWFuZCByZWdpc3RlciBhcyBpZiBpdCBpcyBhZnRl ciB0aGUgcmVzZXQuDQo+Pg0KPj4gV2l0aCByZXNwZWN0IHRvIGhvc3QgY29udHJvbDogd2UgY3Vy cmVudGx5IGRvIG5vdCByZWFsbHkgZW11bGF0ZSBjb21tYW5kDQo+PiByZWdpc3RlciB3aGljaCBw cm9iYWJseSB3YXMgb2sgZm9yIHg4NiBQVkggRG9tMCBhbmQgdGhpcyBtaWdodCBub3QgYmUgdGhl DQo+PiBjYXNlIG5vdyBhcyB3ZSBhZGQgRG9tVSdzLiBUaGF0IGJlaW5nIHNhaWQ6IGluIG15IGlt cGxlbWVudGF0aW9uIGd1ZXN0IGNhbg0KPj4gYWx0ZXIgY29tbWFuZCByZWdpc3RlciBhcyBpdCB3 YW50cyB3aXRob3V0IHJlc3RyaWN0aW9ucy4NCj4+IElmIHdlIHNlZSBpdCBkb2VzIG5lZWQgcHJv cGVyIGVtdWxhdGlvbiB0aGVuIHdlIHdvdWxkIG5lZWQgYWRkaW5nIHRoYXQgYXMNCj4+IHdlbGwg KGlzIG5vdCBwYXJ0IG9mIHRoaXMgc2VyaWVzIHRob3VnaCkuDQo+Pg0KPj4gTWVhbndoaWxlLCBJ IGFncmVlIHRoYXQgd2UgY2FuIG9ubHkgcmVzZXQgSU8gc3BhY2UsIG1lbW9yeSBzcGFjZSBhbmQg YnVzDQo+PiBtYXN0ZXIgYml0cyBhbmQgbGVhdmUgdGhlIHJlc3QgdW50b3VjaGVkLiBCdXQgYWdh aW4sIHdpdGhvdXQgcHJvcGVyIGNvbW1hbmQNCj4+IHJlZ2lzdGVyIGVtdWxhdGlvbiBndWVzdHMg Y2FuIHN0aWxsIHNldCB3aGF0IHRoZXkgd2FudC4NCj4gWWVzLCB3cml0ZXMgdG8gdGhlIHJlZ2lz dGVyIHdpbGwgbmVlZCBlbXVsYXRpbmcgZm9yIERvbVUuDQoNCkJ1dCB0aGVuIEkgYW0gd29uZGVy aW5nIHRvIHdoYXQgZXh0ZW50IHdlIG5lZWQgdG8gZW11bGF0ZSB0aGUgY29tbWFuZA0KDQpyZWdp c3Rlcj8gV2UgaGF2ZSB0aGUgZm9sbG93aW5nIGJpdHMgaW4gdGhlIGNvbW1hbmQgcmVnaXN0ZXI6 DQoNCiNkZWZpbmXCoCBQQ0lfQ09NTUFORF9JT8KgwqDCoCDCoMKgwqAgMHgxwqDCoMKgIC8qIEVu YWJsZSByZXNwb25zZSBpbiBJL08gc3BhY2UgKi8NCiNkZWZpbmXCoCBQQ0lfQ09NTUFORF9NRU1P UlnCoMKgwqAgMHgywqDCoMKgIC8qIEVuYWJsZSByZXNwb25zZSBpbiBNZW1vcnkgc3BhY2UgKi8N CiNkZWZpbmXCoCBQQ0lfQ09NTUFORF9NQVNURVLCoMKgwqAgMHg0wqDCoMKgIC8qIEVuYWJsZSBi dXMgbWFzdGVyaW5nICovDQojZGVmaW5lwqAgUENJX0NPTU1BTkRfU1BFQ0lBTMKgwqDCoCAweDjC oMKgwqAgLyogRW5hYmxlIHJlc3BvbnNlIHRvIHNwZWNpYWwgY3ljbGVzICovDQojZGVmaW5lwqAg UENJX0NPTU1BTkRfSU5WQUxJREFURcKgwqDCoCAweDEwwqDCoMKgIC8qIFVzZSBtZW1vcnkgd3Jp dGUgYW5kIGludmFsaWRhdGUgKi8NCiNkZWZpbmXCoCBQQ0lfQ09NTUFORF9WR0FfUEFMRVRURSAw eDIwwqDCoMKgIC8qIEVuYWJsZSBwYWxldHRlIHNub29waW5nICovDQojZGVmaW5lwqAgUENJX0NP TU1BTkRfUEFSSVRZwqDCoMKgIDB4NDDCoMKgwqAgLyogRW5hYmxlIHBhcml0eSBjaGVja2luZyAq Lw0KI2RlZmluZcKgIFBDSV9DT01NQU5EX1dBSVQgwqDCoMKgIDB4ODDCoMKgwqAgLyogRW5hYmxl IGFkZHJlc3MvZGF0YSBzdGVwcGluZyAqLw0KI2RlZmluZcKgIFBDSV9DT01NQU5EX1NFUlLCoMKg wqAgMHgxMDDCoMKgwqAgLyogRW5hYmxlIFNFUlIgKi8NCiNkZWZpbmXCoCBQQ0lfQ09NTUFORF9G QVNUX0JBQ0vCoMKgwqAgMHgyMDDCoMKgwqAgLyogRW5hYmxlIGJhY2stdG8tYmFjayB3cml0ZXMg Ki8NCiNkZWZpbmXCoCBQQ0lfQ09NTUFORF9JTlRYX0RJU0FCTEUgMHg0MDAgLyogSU5UeCBFbXVs YXRpb24gRGlzYWJsZSAqLw0KDQpXZSB3YW50IHRoZSBndWVzdCB0byBhY2Nlc3MgZGlyZWN0bHkg YXQgbGVhc3QgSS9PIGFuZCBtZW1vcnkgZGVjb2RpbmcgYW5kIGJ1cyBtYXN0ZXJpbmcNCg0KYml0 cywgYnV0IGhvdyBkbyB3ZSBlbXVsYXRlIHRoZSByZXN0PyBEbyB5b3UgbWVhbiB3ZSBjYW4gbWF0 Y2ggdGhlIHJlc3QgdG8gd2hhdCBob3N0DQoNCnVzZXMgZm9yIHRoZSBkZXZpY2UsIGxpa2UgUENJ X0NPTU1BTkRfSU5UWF9ESVNBQkxFIGJpdD8gSWYgc28sIGFzIHBlciBteSB1bmRlcnN0YW5kaW5n LA0KDQp0aG9zZSBiaXRzIGdldCBzZXQvY2xlYXJlZCB3aGVuIGEgZGV2aWNlIGlzIGVuYWJsZWQs IGUuZy4gYnkgTGludXgga2VybmVsL2RldmljZSBkcml2ZXIgZm9yIGV4YW1wbGUuDQoNClNvLCBp ZiB3ZSBoYXZlIGEgaGlkZGVuIFBDSSBkZXZpY2Ugd2hpY2ggY2FuIGJlIGFzc2lnbmVkIHRvIGEg Z3Vlc3QgYW5kIGl0IGlzIGxpdGVyYWxseSB1bnRvdWNoZWQNCg0KKG5vdCBlbmFibGVkIGluIERv bTApIHRoZW4gSSB0aGluayB0aGVyZSB3aWxsIGJlIG5vIHN1Y2ggcmVmZXJlbmNlIGFzICJob3N0 IGFzc2lnbmVkIHZhbHVlcyIgYXMNCg0KbW9zdCBwcm9iYWJseSB0aGUgY29tbWFuZCByZWdpc3Rl ciB3aWxsIHJlbWFpbiBpbiBpdHMgYWZ0ZXIgcmVzZXQgc3RhdGUuDQoNClRodXMsIEkgYW0gbm90 IHF1aXRlIHN1cmUgdGhlIGNvbW1hbmQgcmVnaXN0ZXIgY2FuIGVhc2lseSBiZSBlbXVsYXRlZC4N Cg0KUGxlYXNlIGNvcnJlY3QgbWUgaWYgbXkgdW5kZXJzdGFuZGluZyBpcyB3cm9uZyBoZXJlLg0K DQo+ICAgUmVwb3J0aW5nIHRoZQ0KPiBlbXVsYXRlZCByZWdpc3RlciBhcyB6ZXJvIGluaXRpYWxs eSBpcyBwcm9iYWJseSBhbHNvIHF1aXRlIGZpbmUgKHRvDQo+IG1hdGNoLCBhcyB5b3Ugc2F5LCBt YW5kYXRlZCByZXNldCBzdGF0ZSkuDQo+DQo+IEphbg0KPg0KVGhhbmsgeW91LA0KDQpPbGVrc2Fu ZHINCg== From xen-devel-bounces@lists.xenproject.org Tue Sep 07 08:20:34 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 08:20:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180593.327318 (Exim 4.92) (envelope-from ) id 1mNWLJ-0004eu-HA; Tue, 07 Sep 2021 08:20:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180593.327318; Tue, 07 Sep 2021 08:20:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNWLJ-0004en-E1; Tue, 07 Sep 2021 08:20:33 +0000 Received: by outflank-mailman (input) for mailman id 180593; Tue, 07 Sep 2021 08:20:32 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNWLI-0004eh-Bo for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 08:20:32 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNWLH-0007kv-9O; Tue, 07 Sep 2021 08:20:31 +0000 Received: from [54.239.6.187] (helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1mNWLH-0000GH-2C; Tue, 07 Sep 2021 08:20:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=iPUVsAG9/4VmfVlRTjN/f3rMxYdXOSMmyOhnkZw4B9g=; b=bkNFcR2gBy2HkDwApzOo5UBl7S qMIgQzSHz22C3kvVFaGNDiLQzVKvbhLm2dG4P/AHWi6v7dxynbT6OcI0bPHtbagYD4S8efYzvkIJf GcCYNIoLXvzCwrIzOReI/u0WDjvCjk8BizmtY6KPU3dioXOWSiWgH01AXRTvw+oCH2c4=; Subject: Re: [PATCH v1 04/14] xen/arm: Add support for PCI init to initialize the PCI driver. To: Rahul Singh , xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, Stefano Stabellini , Volodymyr Babchuk References: <999887f9b4b2ea06ae99e1e003f9e43aa272a19c.1629366665.git.rahul.singh@arm.com> From: Julien Grall Message-ID: <9bbf553c-80ff-7a1a-a87e-e2162085caca@xen.org> Date: Tue, 7 Sep 2021 09:20:29 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <999887f9b4b2ea06ae99e1e003f9e43aa272a19c.1629366665.git.rahul.singh@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Hi Rahul, On 19/08/2021 13:02, Rahul Singh wrote: > pci_init(..) will be called during xen startup to initialize and probe > the PCI host-bridge driver. > > Signed-off-by: Rahul Singh > --- > xen/arch/arm/pci/pci.c | 54 ++++++++++++++++++++++++++++++++++++ > xen/include/asm-arm/device.h | 1 + > 2 files changed, 55 insertions(+) > > diff --git a/xen/arch/arm/pci/pci.c b/xen/arch/arm/pci/pci.c > index dc55d23778..d1c9cf997d 100644 > --- a/xen/arch/arm/pci/pci.c > +++ b/xen/arch/arm/pci/pci.c > @@ -14,13 +14,67 @@ > * along with this program. If not, see . > */ > > +#include > +#include > +#include > +#include > #include > +#include This include doesn't look to be necessary (yet?). > > int arch_pci_clean_pirqs(struct domain *d) > { > return 0; > } > > +static int __init dt_pci_init(void) > +{ > + struct dt_device_node *np; > + int rc; > + > + dt_for_each_device_node(dt_host, np) > + { > + rc = device_init(np, DEVICE_PCI, NULL); > + if( !rc ) > + continue; > + /* > + * Ignore the following error codes: > + * - EBADF: Indicate the current is not an pci > + * - ENODEV: The pci device is not present or cannot be used by > + * Xen. > + */ > + else if ( rc != -EBADF && rc != -ENODEV ) > + { > + printk(XENLOG_ERR "No driver found in XEN or driver init error.\n"); > + return rc; > + } > + } > + > + return 0; > +} > + > +#ifdef CONFIG_ACPI > +static void __init acpi_pci_init(void) > +{ > + printk(XENLOG_ERR "ACPI pci init not supported \n"); > + return; > +} > +#else > +static inline void __init acpi_pci_init(void) { } > +#endif > + > +static int __init pci_init(void) > +{ > + if ( acpi_disabled ) > + dt_pci_init(); > + else > + acpi_pci_init(); > + > + pci_segments_init(); Shouldn't this happen before the PCI initialization? > + > + return 0; > +} > +__initcall(pci_init); > + > /* > * Local variables: > * mode: C > diff --git a/xen/include/asm-arm/device.h b/xen/include/asm-arm/device.h > index ee7cff2d44..5ecd5e7bd1 100644 > --- a/xen/include/asm-arm/device.h > +++ b/xen/include/asm-arm/device.h > @@ -34,6 +34,7 @@ enum device_class > DEVICE_SERIAL, > DEVICE_IOMMU, > DEVICE_GIC, > + DEVICE_PCI, > /* Use for error */ > DEVICE_UNKNOWN, > }; > Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Sep 07 08:33:39 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 08:33:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180608.327333 (Exim 4.92) (envelope-from ) id 1mNWXt-0006oj-O3; Tue, 07 Sep 2021 08:33:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180608.327333; Tue, 07 Sep 2021 08:33:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNWXt-0006oc-Ke; Tue, 07 Sep 2021 08:33:33 +0000 Received: by outflank-mailman (input) for mailman id 180608; Tue, 07 Sep 2021 08:33:32 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNWXs-0006oW-5o for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 08:33:32 +0000 Received: from mx0b-0039f301.pphosted.com (unknown [148.163.137.242]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 2e865283-6a99-4ed7-bedd-169b92d7e73d; Tue, 07 Sep 2021 08:33:31 +0000 (UTC) Received: from pps.filterd (m0174680.ppops.net [127.0.0.1]) by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 1877mgC7024165; Tue, 7 Sep 2021 08:33:28 GMT Received: from eur04-db3-obe.outbound.protection.outlook.com (mail-db3eur04lp2055.outbound.protection.outlook.com [104.47.12.55]) by mx0b-0039f301.pphosted.com with ESMTP id 3ax413r56p-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 07 Sep 2021 08:33:28 +0000 Received: from AM7PR03MB6325.eurprd03.prod.outlook.com (2603:10a6:20b:13c::18) by AS8PR03MB6981.eurprd03.prod.outlook.com (2603:10a6:20b:299::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.24; Tue, 7 Sep 2021 08:33:26 +0000 Received: from AM7PR03MB6325.eurprd03.prod.outlook.com ([fe80::d9b7:c0ab:2c2f:5b44]) by AM7PR03MB6325.eurprd03.prod.outlook.com ([fe80::d9b7:c0ab:2c2f:5b44%3]) with mapi id 15.20.4478.025; Tue, 7 Sep 2021 08:33:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2e865283-6a99-4ed7-bedd-169b92d7e73d ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JDy87PHSNQYi95Ze6iPaEQuNglrE13n+PSqy4ugqUQkDwI7OBG7DHq4700Y0H90DB9eRvMh7qxLK9N9/dgvekH88y4WcThESRdaiT5eKR/Ga+7WXxFsqAOGoFahvny42mMPbRmjX/SUqnbIkTbrd7cJhRRZgdnYgOiNdwB2DFUWfrkq2VR0Z3agQJVQ7zBfug6l4rSZEa/RXB5XSisrmo9nN27bnGwq8hZy9j5DUZ8Tw938if8CoMubDuBkwTpzNAf0KCsDuEo8SwTAL0rThOSATLzEVZJGqxkuDsh0n8xzhEgWB1Xxqdt/DAMB9G+bHXoeT8x9k2cGBeEq50JAsNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=rY4+RI5kbn/YbnzJ+0E6KYuPaJLPUxjFO5sxV5cpIII=; b=LZHIPId4CZTACxlfYQ9jjNtyuTQHhsk+v9NmfXOqK5KYTfFAbGgdWiDB2o3aj+p0Dhmm3eljWrdMF9mlqChMB3EfVpOLPFWBdlQBL3MvZZhXrbAa5HKW/y62h4A3msyZ4KuWnbnOJhjAYJVyof17arkEf7JIgAPUJsVhqa7EpUF2YrcS/g29IiGvzHmr1EfnVxRyfL5FH4SVsJfYOKvn7ipyntU23jAUw9bFAk7Ax7Xnjo0xoLPDQ9bq0p75DFPc2+TLjY3qRRim6KDdOIZK2ZJ+ZbdkQjtSSdiqErZc0vhY9C6OBIFhKW1Hu8KF9vpJKLn7B/0URPilxRT0yYQw3Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rY4+RI5kbn/YbnzJ+0E6KYuPaJLPUxjFO5sxV5cpIII=; b=E4AUFXCC24F7y/pKbrN8Fvm8ivJ+SQ1l1mod79jikW8u7bimg8hGUr7TbEv5ZK1S482pIDWuUd4xkADRnxKkWA5/IpNWkXDcuL/oXSkUEtnOIIJ8Zx/40jNcpz74fSGX+rEeYaCURL2WoTnJVpKdpNtT2p2WvKjW+tXQNELww4sAcF420nwOlFc6WOZ/7c5HHVMFgS4IlxYoTid8fzxrV1cgbTLU9SzwzjbBbEMaO0WA4ULdIZGXDN/QcgY2gX2J9pLZgDHvTdK4h1apuYe9e14dXTuzKEPRecBqObTjzHPnmphmAQttFCWWxN2ybxD63ko5Cc8H9nVQdngxJCuKSA== From: Oleksandr Andrushchenko To: Jan Beulich , Oleksandr Andrushchenko CC: "julien@xen.org" , "sstabellini@kernel.org" , Oleksandr Tyshchenko , Volodymyr Babchuk , Artem Mygaiev , "roger.pau@citrix.com" , Bertrand Marquis , Rahul Singh , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH 2/9] vpci: Add hooks for PCI device assign/de-assign Thread-Topic: [PATCH 2/9] vpci: Add hooks for PCI device assign/de-assign Thread-Index: AQHXoKuuObg1egaUxUKTttuKCAaWP6uXA1aAgAFBYAA= Date: Tue, 7 Sep 2021 08:33:26 +0000 Message-ID: References: <20210903100831.177748-1-andr2000@gmail.com> <20210903100831.177748-3-andr2000@gmail.com> <371a403c-adec-f1e1-8887-5664a749b169@suse.com> In-Reply-To: <371a403c-adec-f1e1-8887-5664a749b169@suse.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=epam.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b34e9d35-644b-44f9-999f-08d971da29c2 x-ms-traffictypediagnostic: AS8PR03MB6981: x-ms-exchange-transport-forked: True x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: VrFiOUWqRn48ftTr1w5Ey/OMqWTFeNzPZM0252d6VzJdFNmDYR4mtAzXYuHroK0L+vfX+jU+xxlwvsyf9itbJh+oxBEA2MxLaDHqAxFP8kBz5/rbsi136j4lAd82UYR1eWUEsw22PksFJoVrXzSV1xclBj8rrAfcnWV3F0cXzXjF2BDWuNVfgdkFWAUGeYIxUinUIOJeq3CumpMrfQuvkc3/KoMy0e0wQ75Au9kUJT9+YEn4R1PN+a9BCoiJIhslEw75RddnhKmezHDdEEVUnvoC/9poMXedJie5gVhYZNluDUkou1+ygH2La0wouV+8vQ4/js9fhl3Ofqf7gjbDI1O0Xt1Ggbms5gVzeoBnirzMDF2vUxZqkfnZFo6ZthGpIQXVXKcb2VhWDTET+zLhh+31TMpux76NNP8wuEiGOl6rjI5vSTFlM9qhNs5RrpkC4p+4OQuY2XWO+iYBm67Pa7ITFrwKT+H5Q1w4HdPoa8hjUIyLO5VRl6b5zAduR3UV0j6kd42uYnzFDHp5jF1WuxEZI/SeJLYqPHE4Mmff1B1ZdaAKx0PZ5L+wOxMFMXHrBJx2403lOpZc08VzoVe95v2i/d5sqSEtNO1BDZbIyOf6QpjehkoP6KIJRWZWzXQ61CosIKzQYwpPlGVu5RAAc3fa7Ixr/Dxq3ps3wTfm9K9dJgaNBi18U+xzkIpb6m6GprIpIuz6ly+T+2orQ/c1l32LF+okZ+GWtlIsxprcau60eq3GKgSsI5GJtZiNaYSj x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM7PR03MB6325.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(376002)(366004)(136003)(396003)(39860400002)(76116006)(66946007)(36756003)(66476007)(2906002)(6506007)(66446008)(110136005)(316002)(54906003)(83380400001)(31696002)(5660300002)(31686004)(86362001)(38070700005)(186003)(64756008)(91956017)(66556008)(6486002)(122000001)(38100700002)(6512007)(2616005)(478600001)(8936002)(71200400001)(4326008)(8676002)(53546011)(26005)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?aDIwTS9UMS9wWHZ5SXRmUW9SU2RLbkphcWN1VVVPQ1M4LzZzQnJ1dExtVTZY?= =?utf-8?B?M29lNWdwRHVRYzFabEhndHhhQXNTRzNkajFaWDErbkJqMmZML0Yrdm5YT0Fr?= =?utf-8?B?QWFGblZxV05tRE5UUUxTUkpDcmlrU2hNWmJMT09tdEFXZEVZNEVkZnRUTzBC?= =?utf-8?B?aEJRQVlpa2J1RGJoWkRCNkNlMXZNZWg5dnl1L0FySVlJMlkxRW1NU3B3TUZJ?= =?utf-8?B?WHpiRFo1bjhlL1Rlb0x5aGF4MVEzZHI4UkFrY2V0L2R6QUFmeHlBYVZMNzRy?= =?utf-8?B?S0trWGRtYmJhUUJ1WVgvTnFrNk4xbkxuWUV6T1ZXZzM1bG1ibDQvQi9GZXBw?= =?utf-8?B?c3RJN2dzUi94UDRkc0tERW4vcUxMM1NTcFdUOE1zU1p4VTlVUitabVdjQlR4?= =?utf-8?B?b2ZDc29IdFZKZ1RZOEozd3Evdzd3MVU1RG9aNnJNODhkckRBeVlNYS9sa3R4?= =?utf-8?B?bUNvK3lETitybCtpb0hSRUd3QnJQUjJtS1dpVkJGRmdoQVRXTkhoZDI4Wld6?= =?utf-8?B?c0dzeUFpRnNqcGJqS0ZUb0MyNmI3eEg0bUUrc0kyYjVhc081TVg5VGpMK0Rn?= =?utf-8?B?WHI4MlZYa0MvdU1aRTlGQUJHMndmbjY1QjhmKzU2aDlpTFlsNnRlVTNxMzE2?= =?utf-8?B?RXJWUm9lUUhtMEQ2dDZoY0svRVhjN2NxdDJoaGhSOVdGbGZFUkd2NndyWWZj?= =?utf-8?B?d2c4SnUrUlNIZ04yNFpBNE1pUThleS8yVjJKajRyU0tiM2daZitHM3l1b3Az?= =?utf-8?B?bzlHMy9PSzZadVpuOTZvTWJseCtpV01lV1loKzM4TFpPOVppb0RwUGIzdXI3?= =?utf-8?B?VStWeEZIRVpaOWIxL1hZemY2ajlESGduTllLclc4alUwRXF6V0lJdlo4VWdp?= =?utf-8?B?MGp2Q2pLa0I5akJrS1hkQTZCczlOSG5GU3Y1Y0VjN1RUazhPa1d3dll6MFU5?= =?utf-8?B?M1NiSmxVTXNxSmVBbDFmWi9tbWFlcS9JNWxMVFlVRWl2SUNFUy9TeVBvRmRi?= =?utf-8?B?Qk5rSkdTUkR0YnpLekxpckNHS2JxaG1sUEs2aEdnTVVOeUx6UDlKZ3NDWnJq?= =?utf-8?B?eVdSVGNLNWMvMEtPOEZJTS9kRXN0U1p2c2RpT2FVMmlUUDRDV2dRQkRPditU?= =?utf-8?B?TjBTcjJRdW5FdDEva01FTkk5MWZFOUIzdXFZWjJRbXM2TkFDQW9GV29rZXZG?= =?utf-8?B?Z1pXcU1MMjhkVVJYL0F6R0Y4OFNaQjNhUW5qSklwNzErVjIzN1BsY2VjU0xs?= =?utf-8?B?c2IxZlBoNDY3NzRWdU1VOFpoV2psTHFhNHdHdjJ1c2RUczQ4N0tpc0Y1TW9R?= =?utf-8?B?SFVmdWVBWTBXQ2tlVmFxZGRpYmFBL2R5NlloZkx0ZlR3Ymc2ck5YSHc3bE5j?= =?utf-8?B?cHU5RGJqZHYwcVY5TXJqYUNZUmdzN1ppWnJ4VllydnJIby9RWithRWNsT21F?= =?utf-8?B?c2svSWNwa2JPN0g0U0VoTjk2WU9jYkRmd0krNC9YSitLYTQySDNMdkhDL0tn?= =?utf-8?B?Z0JUSTdNSEV5Mm1sRmpBamxLeTBEMXNLLzZyZE5xNG9zZTcvSWI3R3AyaFNo?= =?utf-8?B?OGpEV3RsNDArb0piakRPcVlBOW9EdHZJbXV4cHhXOEl5Z3JBR2hlTkhSakwy?= =?utf-8?B?Ym9RVk1IZ2pnTzRSbUNyYTN1SktFZTBWd2hxd3l2ZWhLMFN5NVd1RGg3SVBR?= =?utf-8?B?N0dnQlUwcGR5L2I2d2psbkI0VkNPNzlIcjFkeUd1cWhZQlgxN3ppMVBwbXJ6?= =?utf-8?Q?t23m5DQ1MbLQNoPWQ2Nc7W2pnr2gJQfum9nbyHc?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: epam.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM7PR03MB6325.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b34e9d35-644b-44f9-999f-08d971da29c2 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Sep 2021 08:33:26.5998 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: vp3q+I2AJF8IYZinVhlwMlGfbHRWvFxLPEnI/e4Mx0tOZeoMCq8Hns/WG1Wutj/Qpz9t/NtsC15XUpQHbfqw8Hp+CH/3DiXjp74qfuLnhRFqPpqu+bp6Mn60eMvoFm3m X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR03MB6981 X-Proofpoint-ORIG-GUID: yzRev8ctFvb79gzde9I-IYo0tvpgGNoK X-Proofpoint-GUID: yzRev8ctFvb79gzde9I-IYo0tvpgGNoK X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.391,FMLib:17.0.607.475 definitions=2021-09-07_02,2021-09-03_01,2020-04-07_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 lowpriorityscore=0 priorityscore=1501 clxscore=1015 spamscore=0 malwarescore=0 suspectscore=0 adultscore=0 impostorscore=0 bulkscore=0 mlxlogscore=999 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2108310000 definitions=main-2109070056 SGVsbG8sIEphbiENCg0KT24gMDYuMDkuMjEgMTY6MjMsIEphbiBCZXVsaWNoIHdyb3RlOg0KPiBP biAwMy4wOS4yMDIxIDEyOjA4LCBPbGVrc2FuZHIgQW5kcnVzaGNoZW5rbyB3cm90ZToNCj4+IC0t LSBhL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL3BjaS5jDQo+PiArKysgYi94ZW4vZHJpdmVycy9w YXNzdGhyb3VnaC9wY2kuYw0KPj4gQEAgLTg2NCw2ICs4NjQsMTAgQEAgc3RhdGljIGludCBkZWFz c2lnbl9kZXZpY2Uoc3RydWN0IGRvbWFpbiAqZCwgdWludDE2X3Qgc2VnLCB1aW50OF90IGJ1cywN Cj4+ICAgICAgIGlmICggcmV0ICkNCj4+ICAgICAgICAgICBnb3RvIG91dDsNCj4+ICAgDQo+PiAr ICAgIHJldCA9IHZwY2lfZGVhc3NpZ25fZGV2aWNlKGQsIHBkZXYpOw0KPj4gKyAgICBpZiAoIHJl dCApDQo+PiArICAgICAgICBnb3RvIG91dDsNCj4+ICsNCj4+ICAgICAgIGlmICggcGRldi0+ZG9t YWluID09IGhhcmR3YXJlX2RvbWFpbiAgKQ0KPj4gICAgICAgICAgIHBkZXYtPnF1YXJhbnRpbmUg PSBmYWxzZTsNCj4+ICAgDQo+PiBAQCAtMTQyNSw2ICsxNDI5LDExIEBAIHN0YXRpYyBpbnQgYXNz aWduX2RldmljZShzdHJ1Y3QgZG9tYWluICpkLCB1MTYgc2VnLCB1OCBidXMsIHU4IGRldmZuLCB1 MzIgZmxhZykNCj4+ICAgICAgICAgICByYyA9IGhkLT5wbGF0Zm9ybV9vcHMtPmFzc2lnbl9kZXZp Y2UoZCwgZGV2Zm4sIHBjaV90b19kZXYocGRldiksIGZsYWcpOw0KPj4gICAgICAgfQ0KPj4gICAN Cj4+ICsgICAgaWYgKCByYyApDQo+PiArICAgICAgICBnb3RvIGRvbmU7DQo+PiArDQo+PiArICAg IHJjID0gdnBjaV9hc3NpZ25fZGV2aWNlKGQsIHBkZXYpOw0KPj4gKw0KPj4gICAgZG9uZToNCj4+ ICAgICAgIGlmICggcmMgKQ0KPj4gICAgICAgICAgIHByaW50ayhYRU5MT0dfR19XQVJOSU5HICIl cGQ6IGFzc2lnbiAoJXBwKSBmYWlsZWQgKCVkKVxuIiwNCj4gSSBoYXZlIHRvIGFkbWl0IHRoYXQg SSdtIHdvcnJpZWQgYnkgdGhlIGZ1cnRoZXIgbGFjayBvZiB1bndpbmRpbmcgaW4NCj4gY2FzZSBv ZiBlcnJvcjogV2UncmUgbm90IHJlYWxseSBnb29kIGF0IHRoaXMsIEkgYWdyZWUsIGJ1dCBpdCB3 b3VsZA0KPiBiZSBxdWl0ZSBuaWNlIGlmIHRoZSBwcm9ibGVtIGRpZG4ndCBnZXQgd29yc2UuIEF0 IHRoZSB2ZXJ5IGxlYXN0IGlmDQo+IHRoZSBkZXZpY2Ugd2FzIGRlLWFzc2lnbmVkIGZyb20gRG9t MCBhbmQgYXNzaWdubWVudCB0byBhIERvbVUgZmFpbGVkLA0KPiBpbW8geW91IHdpbGwgd2FudCB0 byByZXN0b3JlIERvbTAncyBzZXR0aW5ncy4NCg0KSW4gdGhlIGN1cnJlbnQgZGVzaWduIHRoZSBl cnJvciBwYXRoIGlzIGhhbmRsZWQgYnkgdGhlIHRvb2xzdGFjaw0KDQp2aWEgWEVOX0RPTUNUTF9h c3NpZ25fZGV2aWNlL1hFTl9ET01DVExfZGVhc3NpZ25fZGV2aWNlLA0KDQpzbyB0aGlzIGlzIHdo eSBpdCBpcyAib2siIHRvIGhhdmUgdGhlIGNvZGUgc3RydWN0dXJlZCBpbiB0aGUNCg0KYXNzaWdu X2RldmljZSBhcyBpdCBpcywgZS5nLiByb2xsIGJhY2sgd2lsbCBiZSBoYW5kbGVkIG9uIGRlYXNz aWduX2RldmljZS4NCg0KU28sIGl0IGlzIHVwIHRvIHRoZSB0b29sc3RhY2sgdG8gcmUtYXNzaWdu IHRoZSBkZXZpY2UgdG8gRG9tMCBvciBEb21JTyg/KQ0KDQppbiBjYXNlIG9mIGVycm9yIGFuZCB3 ZSBkbyByZWx5IG9uIHRoZSB0b29sc3RhY2sgaW4gWGVuLg0KDQo+DQo+IEFsc28gaW4gdGhlIGxh dHRlciBjYXNlIGRvbid0IHlvdSBuZWVkIHRvIGFkZGl0aW9uYWxseSBjYWxsDQo+IHZwY2lfZGVh c3NpZ25fZGV2aWNlKCkgZm9yIHRoZSBwcmlvciBvd25lciBvZiB0aGUgZGV2aWNlPw0KDQpFdmVu IGlmIHdlIHdhbnRlZCB0byBoZWxwIHRoZSB0b29sc3RhY2sgd2l0aCB0aGUgcm9sbC1iYWNrIGlu IGNhc2Ugb2YgYW4gZXJyb3INCg0KdGhpcyB3b3VsZCBJTU8gbWFrZSB0aGluZ3MgZXZlbiB3b3J0 aCwgZS5nLiB3ZSB3aWxsIGRlLWFzc2lnbiBmb3IgdlBDSSwgYnV0IHdpbGwNCg0KbGVhdmUgSU9N TVUgcGF0aCB1bnRvdWNoZWQgd2hpY2ggd291bGQgcmVzdWx0IGluIHNvbWUgbWVzcy4NCg0KU28s IG15IG9ubHkgZ3Vlc3MgaGVyZSBpcyB0aGF0IHdlIHNob3VsZCByZWx5IG9uIHRoZSB0b29sc3Rh Y2sgY29tcGxldGVseSBhcw0KDQppdCB3YXMgYmVmb3JlIFBDSSBwYXNzdGhyb3VnaCBvbiBBcm0u DQoNCj4NCj4+IC0tLSBhL3hlbi9kcml2ZXJzL3ZwY2kvdnBjaS5jDQo+PiArKysgYi94ZW4vZHJp dmVycy92cGNpL3ZwY2kuYw0KPj4gQEAgLTg2LDYgKzg2LDI3IEBAIGludCBfX2h3ZG9tX2luaXQg dnBjaV9hZGRfaGFuZGxlcnMoc3RydWN0IHBjaV9kZXYgKnBkZXYpDQo+PiAgIA0KPj4gICAgICAg cmV0dXJuIHJjOw0KPj4gICB9DQo+PiArDQo+PiArLyogTm90aWZ5IHZQQ0kgdGhhdCBkZXZpY2Ug aXMgYXNzaWduZWQgdG8gZ3Vlc3QuICovDQo+PiAraW50IHZwY2lfYXNzaWduX2RldmljZShzdHJ1 Y3QgZG9tYWluICpkLCBzdHJ1Y3QgcGNpX2RldiAqZGV2KQ0KPj4gK3sNCj4+ICsgICAgLyogSXQg b25seSBtYWtlcyBzZW5zZSB0byBhc3NpZ24gZm9yIGh3ZG9tIG9yIGd1ZXN0IGRvbWFpbi4gKi8N Cj4+ICsgICAgaWYgKCAhaGFzX3ZwY2koZCkgfHwgKGQtPmRvbWFpbl9pZCA+PSBET01JRF9GSVJT VF9SRVNFUlZFRCkgKQ0KPiBQbGVhc2UgZG9uJ3Qgb3Blbi1jb2RlIGlzX3N5c3RlbV9kb21haW4o KS4gSSBhbHNvIHRoaW5rIHlvdSB3YW50IHRvDQo+IGZsaXAgdGhlIHR3byBzaWRlcyBvZiB0aGUg fHwsIHRvIGF2b2lkIGV2YWx1YXRpbmcgd2hhdGV2ZXIgaGFzX3ZjcGkoKQ0KPiBleHBhbmRzIHRv IGZvciBzeXN0ZW0gZG9tYWlucy4gKEJvdGggYWdhaW4gYmVsb3cuKQ0KR29vZCBjYXRjaCwgSSBt aXNzZWQgaXNfc3lzdGVtX2RvbWFpbiBjb21wbGV0ZWx5LCB0aGFuayB5b3UhDQo+DQo+PiAtLS0g YS94ZW4vaW5jbHVkZS94ZW4vdnBjaS5oDQo+PiArKysgYi94ZW4vaW5jbHVkZS94ZW4vdnBjaS5o DQo+PiBAQCAtMjYsNiArMjYsMTIgQEAgdHlwZWRlZiBpbnQgdnBjaV9yZWdpc3Rlcl9pbml0X3Qo c3RydWN0IHBjaV9kZXYgKmRldik7DQo+PiAgIC8qIEFkZCB2UENJIGhhbmRsZXJzIHRvIGRldmlj ZS4gKi8NCj4+ICAgaW50IF9fbXVzdF9jaGVjayB2cGNpX2FkZF9oYW5kbGVycyhzdHJ1Y3QgcGNp X2RldiAqZGV2KTsNCj4+ICAgDQo+PiArLyogTm90aWZ5IHZQQ0kgdGhhdCBkZXZpY2UgaXMgYXNz aWduZWQgdG8gZ3Vlc3QuICovDQo+PiAraW50IF9fbXVzdF9jaGVjayB2cGNpX2Fzc2lnbl9kZXZp Y2Uoc3RydWN0IGRvbWFpbiAqZCwgc3RydWN0IHBjaV9kZXYgKmRldik7DQo+PiArDQo+PiArLyog Tm90aWZ5IHZQQ0kgdGhhdCBkZXZpY2UgaXMgZGUtYXNzaWduZWQgZnJvbSBndWVzdC4gKi8NCj4+ ICtpbnQgX19tdXN0X2NoZWNrIHZwY2lfZGVhc3NpZ25fZGV2aWNlKHN0cnVjdCBkb21haW4gKmQs IHN0cnVjdCBwY2lfZGV2ICpkZXYpOw0KPiBJcyB0aGUgZXhwZWN0YXRpb24gdGhhdCAiZGV2IiBt YXkgZ2V0IGFsdGVyZWQ/IElmIG5vdCwgaXQgbWF5IHdhbnQgdG8NCj4gYmVjb21lIHBvaW50ZXIt dG8tY29uc3QuIChGb3IgImQiIHRoZXJlIG1pZ2h0IGJlIHRoZSBuZWVkIHRvIGFjcXVpcmUNCj4g bG9ja3MsIHNvIEkgZ3Vlc3MgaXQgbWlnaHQgbm90IGJlIGEgZ29kIGlkZWEgdG8gY29uc3RpZnkg dGhhdCBvbmUuKQ0KSnVzdCBjaGVja2VkIHRoYXQgYW5kIGl0IGlzIGluZGVlZCBwb3NzaWJsZSB0 byBjb25zdGlmeS4gV2lsbCBkbw0KPg0KPiBJIGFsc28gdGhpbmsgdGhhdCBvbmUgY29tbWVudCBv dWdodCB0byBiZSBlbm91Z2ggZm9yIHRoZSB0d28gZnVuY3Rpb25zLg0KU3VyZQ0KPg0KPiBKYW4N Cj4NClRoYW5rIHlvdSwNCg0KT2xla3NhbmRyDQo= From xen-devel-bounces@lists.xenproject.org Tue Sep 07 08:33:39 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 08:33:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180609.327344 (Exim 4.92) (envelope-from ) id 1mNWXz-00075w-0Y; Tue, 07 Sep 2021 08:33:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180609.327344; Tue, 07 Sep 2021 08:33:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNWXy-00075p-TU; Tue, 07 Sep 2021 08:33:38 +0000 Received: by outflank-mailman (input) for mailman id 180609; Tue, 07 Sep 2021 08:33:37 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNWXx-00075D-HM for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 08:33:37 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 4a0cac9e-0fb6-11ec-b0da-12813bfff9fa; Tue, 07 Sep 2021 08:33:35 +0000 (UTC) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04lp2054.outbound.protection.outlook.com [104.47.13.54]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-3-mD_xAjpyMvmvUX887eO22A-1; Tue, 07 Sep 2021 10:33:32 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR04MB4349.eurprd04.prod.outlook.com (2603:10a6:803:40::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.21; Tue, 7 Sep 2021 08:33:30 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4500.014; Tue, 7 Sep 2021 08:33:30 +0000 Received: from [10.156.60.236] (37.24.206.209) by FR0P281CA0089.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1e::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.6 via Frontend Transport; Tue, 7 Sep 2021 08:33:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4a0cac9e-0fb6-11ec-b0da-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1631003614; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xY1dQKa7ru5yIZJ5fPY1MRo8fV5l6mrUGhuHVi2kSps=; b=augjI1XbJAnmw05LPgJpySd5LUqiChPmO/YpM9Otk6VHFnsqydDE3b+bN2JZEB28PDxc7w nRoVKk7I1CJqd1ZvFSS/AdX3fBsGSV8ubffUaSyWR6ej9fZZ+AuUDDj0Bt/xJwBjbf8LCN EjO/7RTSiMq17kORABOTzc4WE2iYXNo= X-MC-Unique: mD_xAjpyMvmvUX887eO22A-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MLYeF5LjiBVT25/PCBJSed9tqDmEokCY8QzemNAa6ddp6XL1iu27Q58zsmZBy8VU3twu30ATUzeSB1oLoJDNkv4HTDuxKVZFCesSmHAPRWU0BwswRe+eEvtKEzRX98zI+ayXjISrpXLpQzjjM8K6zZRR/szvGKi2v5v+AAzgv1v6gck7y2SLjcWV88XlIOibAeXgspJEK+DoXZUoEygTaHkeJ4z+X+/PTS9zb0Bm4PlunZz9zlfy+SpZUVggz5pSPHKhWsj/NRr6PwApEa5UIRwWXlhdK08qzlypLNT/sva5aYr7VlgABURAVQ44/KCj6dIr1v43ugFsJZwyxkx7gg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=xY1dQKa7ru5yIZJ5fPY1MRo8fV5l6mrUGhuHVi2kSps=; b=KrwPTgezsbvUJ4Ehm9vrdSFKOyD9R8N/KkcIYtUsoVN5PwdwEBY1nYkqej+NON8LZPmcv2Uah7F1cbjAyD84ixI+8gkRlbqrSx0MwgsDQQT8yC2oesTlCJjZf0Koc+kFLdsfcCfDsG4KaU52jJBPVuliL6HMt2np2byKS19i93Qc9nt6FmFWLGa0nAfOkV1iC/NyiOL5yL7mq+gzsF1F/ONjKGxMqDFTS367YMLNEh2KWn56oyJl+3TpMpO1uN11AHP6HEPcQ05McKkbIiKQPvuSdAPzMdcMHuqy0F2DsgJ7sHsE/ZE50hV0uDOVAsGEg0ZxfwVZsulckCWbWbJSyA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com; Subject: Re: [RFC PATCH] xen/design: Add design for EFI dom0less system start To: Luca Fancellu Cc: bertrand.marquis@arm.com, wei.chen@arm.com, Andrew Cooper , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20210907065228.21794-1-luca.fancellu@arm.com> From: Jan Beulich Message-ID: Date: Tue, 7 Sep 2021 10:33:28 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: <20210907065228.21794-1-luca.fancellu@arm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0089.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1e::11) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6e312c61-01f0-4ad5-3803-08d971da2bf4 X-MS-TrafficTypeDiagnostic: VI1PR04MB4349: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: kWB/Pj/5Cgl0Qc2/VcsHEfof8G7vwurxa1QGmnIgMe99GhCdoWA0xyOowLhWef3rOpeHnV3Cn5lXzqGzcVHYqw9NgoAUFu/A4s/I/XCAGPSs8+an5NJ+ykvjsl3E20zSekYCH+kjeuqK4L02pSHpi2OjnVy2MqjA5b84kF4w5VCMaZ3jp+il2WHgfPYpK6e/xSvLRs1nXhBpW0dkFluArhEBSOWKdaWOgGzIY0R8XzsuMicjg1sjxYqIEPe+NtAM2urC1eu4OeelybjzzW9mQVC7z6INHps4qR6WcF/CjnG7NHULeutRKFREVeHlFXtubXkYzWvGn1eTGR+iy0eK295Uz+xHluV/vdudwcfKuigX4TODP5/pJQ4jpy8BDt8d/XWJ1PZ3sTC5TwLlRsE33O2OQN1ywKn1KXmWZ1I/LwqmSZxV2nBkzeUrVjuGc27Tk+UbIM+9buz917BEM7CCMGqUHlYbf/e9YNbYabv1TeQha+qXgCaJRUmUXQbtM2+E7dieacNk8dTZ+tGAKlfuyry3EFt/L+A4q779gV7DD6716vty2vst7Z2h0hyOKUM8gKktvOn1XojWg9TX1l59gfx4vrscpeH5AoLkdO52L/5A1P3k3/Q9RkRATgXUFJZEc3famdXE1xwiAgRbr7ghHhM3IWC2FcpmR1o+Rp7SKH3PdlOg3excc8EzVdjBvgKdOCHLMYJOduM/2jAhSxYoSl+7kCt9dZaGaLAn9BgFvt5ExFlmubxYxxEJIpO7IcPwR9ycA4C0wpp/Ti4Luo0NfG/PfqDatN9PcQiVzA0uGhPOjImNb0tNULiNF+SlbY6b/aXSL00awXME5uylrV0kcOp30wWwn1WceB7MgVN615Y= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(39860400002)(396003)(136003)(376002)(346002)(6486002)(478600001)(2906002)(38100700002)(186003)(36756003)(6916009)(316002)(16576012)(31686004)(5660300002)(966005)(26005)(54906003)(31696002)(86362001)(53546011)(2616005)(956004)(66946007)(7416002)(8936002)(83380400001)(66556008)(66476007)(4326008)(8676002)(32563001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?a0tsTHFUcldYV243bnhpMVl6YzY5WU9DUnFmZ1N0NG9KNzlzOVpqWEtON0VX?= =?utf-8?B?OEJsQjI1bGU2K2w2TVZvRytTeVNXZ0ZqRkJNVjU3NC9QNUI2NEFlNmd1NUhx?= =?utf-8?B?dDFLM1lKdUxrbmMyWXpwR0pjYlQxN3dZaXNrcjhiKy9sck8zZEZzN3VDdnNF?= =?utf-8?B?RkV6VnEyd2RyWUtvQzQvMitkN2ZiRUxIVGlRc1UxaVJ0MGdEOXVVM0F3d0Y4?= =?utf-8?B?WXI3MWdkQzJEa1JBelBMOGR6aFhCUkZ0R1lHcmw4enQ3aHYyNkZMQTdNbmlk?= =?utf-8?B?WFdFcjdQVGNWbDVYcXRreDBTajlrYUdqSTQ2WGxjSFVZMWNSWGd2QUJ0dFY1?= =?utf-8?B?TGkwQ055aU1vTU5sa1JCQXBrakVKaDRhK2xXWEtWM1VJZFdiNEQzNmxoQTBG?= =?utf-8?B?Zno0S0JCWjV5bzJVS2RZT2lySXdlNkdRWUlyY2FRWmVxNmpFY1ZXQ015bHVZ?= =?utf-8?B?MGpnWjIvTkFZWm5JZllNS016SWdRTlZFR29YbmthY1RVcC9TeUUwN1dabTdJ?= =?utf-8?B?cVBJWUFSWlRIdHh4VFU2d0kxTUdwL1M3aVoycnoxVytNWk1MbzJRTiticGww?= =?utf-8?B?K3hGNkZCU3RQWC9WenhLM0xSMFlNVlBMS2RiUnN6K3VmY2lvSS94MmdRWjc4?= =?utf-8?B?RlFJSmpoajhNUU4zVkxLc25VbVBXREh5Mkp2azdwVTV1U29VK3I1dzQ1MXl6?= =?utf-8?B?c0E0Q3R2Y2JjYks1ZkFpS05aa25hUFYwc2hnaHlaNml6NCtTSG81RWdCRm5k?= =?utf-8?B?aDQ2NURJUGVWZGUzaGlycmdjUEg5aU5rOVdwbnJLMWpUc1RrTWc2RElEd1Nx?= =?utf-8?B?TnNoRVZOUWZNa2w1WkVuVHFyRkZZaHBSL2hUcms2U1pERllYRUtzRndaOXJZ?= =?utf-8?B?VGdTZy91MFptbHMxV1pNU3U5eFYrM2FwSnllYWd1ZTdMSGJpVjZJM1BKRUFJ?= =?utf-8?B?TXp5dzU3b2tXQ0dMNW1OdG5uWmJhZDUyVnNZcXczNXMyb1JJL2dsZXE0bHlQ?= =?utf-8?B?UUI3N0Z5T2NBanV4RU5vaTAyOU9SR3UwdWVVZTVjT3ZuTTRUaTZNQ3dmUEk4?= =?utf-8?B?eittRGtQVFBGVTVGQ1Q0K1ZUZm9nZWdFc0ptNFJFVHEvM3RqanRHWEFxcG1N?= =?utf-8?B?YmlMdGhSeUw1SnVOY21lMDlhQjF6NzNXTGllM0pLZnlCdDdQd3k3b2VtdDJs?= =?utf-8?B?VWpmNmJlMlkydlJYaytudjVYbVFRbmVaMWRXeDhYc2FRY1FacExuK2t6UFhG?= =?utf-8?B?M3dzdCtDbG56TU40UzZlSTIyOHlxTUdCWFdwNkxIYzgva3g2NVhKQWtWRWxm?= =?utf-8?B?NS9lK2FnRjUwZUZvYmRCc1ZyaFhQT3IrckI3dXV4bWxxdFpGZjBOWTdOSkov?= =?utf-8?B?S2NLWDdqcGdBNDBBYVZpdnlMOVV5OU1ENy9GV2tSbGVvb1IwclgzVTdKNjJ3?= =?utf-8?B?WTBnWlkwWFNsT3llbWRqTjlQbUVXMWY1MWhBeXNDT2pxZUxyYkxlQjh4MFV0?= =?utf-8?B?QWVSSVprdHk0NVhyczJEclo4Z1VkSkJpWE1uRk91UDA5UGlrRUJuRk9ndU00?= =?utf-8?B?dkxyT0F0NVZoZXpoYVNCOGJaVnl2WENmTktIa2d1NVVjMHZralhCRG5TY3VK?= =?utf-8?B?YmIwejRqYmVwTlh3cy9SdFFkWkVha3hnZVNoMS9ldEFkMlBkZDROMFh2Q3VB?= =?utf-8?B?cmNyUHMrNU1aTy9WcjhGa0p5Rng0eHdrL05XZXlER0hoL0o3VVZwaHZNVW1O?= =?utf-8?Q?CY1OR7JZJ/bDorqS3XjTQcVL94Hkr5RKwjt+2P9?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6e312c61-01f0-4ad5-3803-08d971da2bf4 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2021 08:33:30.5029 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2lSh2h1WW40Igaz0NBp81Oei5QcOM9qOHMvazOVgN0i/on/mn5anHZjSYiwJRtt7HAgbBK5JkgE0EK6B7q3Vlg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4349 On 07.09.2021 08:52, Luca Fancellu wrote: > Add a design describing a proposal to improve the EFI > configuration file, adding keywords to describe domU > guests and allowing to start a dom0less system. > > Signed-off-by: Luca Fancellu > --- > docs/designs/efi-arm-dom0less.md | 105 +++++++++++++++++++++++++++++++ > 1 file changed, 105 insertions(+) > create mode 100644 docs/designs/efi-arm-dom0less.md > > diff --git a/docs/designs/efi-arm-dom0less.md b/docs/designs/efi-arm-dom0less.md > new file mode 100644 > index 0000000000..8d8fa2243f > --- /dev/null > +++ b/docs/designs/efi-arm-dom0less.md > @@ -0,0 +1,105 @@ > +# Xen EFI configuration file > + > +The current configuration file used by Xen when it is started as an EFI > +application is considering only the dom0 guest and doesn't have any > +property to describe and load in memory domU guests. > +Hence currently it's impossible to start a dom0less system using EFI. > + > +# Objective > + > +This document describes the proposed improvement to the Xen EFI > +configuration file to list properly both the dom0 guest and the domU > +guests as well. > +The final goal is to be able to start a dom0less system using EFI. > + > +# Current Xen EFI configuration file > + > +The current configuration file is described by the documentation page > +https://xenbits.xenproject.org/docs/unstable/misc/efi.html. > + > +Here an example: > + > +``` > +[global] > +default=section1 > + > +[section1] > +options=console=vga,com1 com1=57600 loglvl=all noreboot > +kernel=vmlinuz-3.0.31-0.4-xen [domain 0 command line options] > +ramdisk=initrd-3.0.31-0.4-xen > +xsm= > +dtb=devtree.dtb > +``` > + > +# Proposed improvement > + > +The proposed improvement to the current configuration file is the > +introduction of new keywords to describe additional domUs. > + > +Here follows the proposed new keywords: > + - domu#_kernel= [domU command line options] > + - Mandatory kernel file for the domU# > + - domu#_ramdisk= > + - Optional ramdisk file for the domU# > + - domu#_dtb= > + - Optional dtb fragment file for the domU#, it is used for device > + assignment (passthrough). > + - domu#_property=cpus=2 > + - Properties that should be added to the dtb in the domU node to > + properly describe the domU guest. Refer to the documentation: > + https://xenbits.xenproject.org/docs/unstable/misc/arm/device-tree/booting.txt, > + section "Creating Multiple Domains directly from Xen". > + > +For all the keywords above, the # is a number that uniquely identifies > +the guest. > +The keywords domu#_kernel, domu#_ramdisk, domu#_dtb are unique, therefore there > +must not be specified the same keyword twice in a section. > +The # number is not enforcing any domid, it is just used to link each property > +to the right guest, so there can be domu1_* guests that are started with domid 2 > +and so on. > + > +The domu#_property can appear multiple times and it specifies an additional > +property to be listed in the domU node inside the device tree, Xen will > +not check if the same content is specified multiple times. > + > +There are some property whose name starts with an hash symbol (#address-cells, > +#size-cells), in this case the line will be considered as a comment, so to > +specify them, they have to be listed without the hash symbol, the documentation > +will be updated as well to see the implemented handling of these special > +properties. > + > +# Example of a configuration file describing a dom0less system > + > +The following configuration file is describing a dom0less system starting two > +guests. > + > +``` > +[global] > +default=xen > + > +[xen] > +# Xen boot arguments > +options=noreboot console=dtuart dtuart=serial0 bootscrub=0 > +# Xen device tree > +dtb=devtree.dtb > + > +# Guest 1 > +domu1_property=address-cells=2 > +domu1_property=size-cells=2 > +domu1_kernel=Image-domu1.bin console=ttyAMA0 root=/dev/ram0 rw > +domu1_property=cpus=1 > +domu1_property=memory=0xC0000 > +domu1_dtb=domu.dtb > + > +# Guest 2 > +domu2_kernel=Image-domu2.bin console=ttyAMA0 root=/dev/ram0 rw > +domu2_property=cpus=2 > +domu2_property=memory=0x100000 > +domu2_property=vpl011 > +``` I'd like to suggest a different scheme, not the least because I expect the individual domains being independent of e.g. hypervisor command line options or Dom0 kernel versions. Yet varying sets of these are, for example, a reason to have multiple sections in the current scheme. Every dom0less guest would then require spelling out in every such section. Hence I think we'd be better off having a section per guest: [guest1] kernel=Image-domu1.bin console=ttyAMA0 root=/dev/ram0 rw property=cpus=1 property=memory=0xC0000 dtb=domu.dtb These sections would then be referenced by other sections, e.g. by a new "guests" (or "domus", but this ends up looking a little odd for its matching of an unrelated latin word) keyword: guests=guest1,guest2 If it is deemed necessary to make sure such a section can't be (mistakenly) used to create Dom0, such sections would need identifying in some way. Presence of property= (or, as per below, properties=) could be one means (allowing an empty setting would then be desirable). As to the properties, is there anything wrong with having them all on one line: [guest1] kernel=Image-domu1.bin console=ttyAMA0 root=/dev/ram0 rw dtb=domu.dtb properties=cpus=1 memory=0xC0000 (just like is the case for options=)? Jan From xen-devel-bounces@lists.xenproject.org Tue Sep 07 08:37:23 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 08:37:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180621.327354 (Exim 4.92) (envelope-from ) id 1mNWba-00088Q-Kg; Tue, 07 Sep 2021 08:37:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180621.327354; Tue, 07 Sep 2021 08:37:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNWba-00088J-Hc; Tue, 07 Sep 2021 08:37:22 +0000 Received: by outflank-mailman (input) for mailman id 180621; Tue, 07 Sep 2021 08:37:21 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNWbZ-000889-Pj; Tue, 07 Sep 2021 08:37:21 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNWbZ-00081q-L0; Tue, 07 Sep 2021 08:37:21 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNWbZ-0002pt-By; Tue, 07 Sep 2021 08:37:21 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mNWbZ-0001cQ-BS; Tue, 07 Sep 2021 08:37:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=GpezyJmmiaztqkYLkEph0l5QPZZXhnLxPiQKIpkd1fM=; b=lwh5daN8GfWxPj0ZjrOENzMH+3 A4MRCG5iFU0b/H0RXmohO7CliwmucvYGoArO/xUzrxvJrYgcQSZOuuJoe/rJU2j/CcyKuhh3V1R9W ewDzoTL6Rkmp+k+Ix+Ldj7gGX1ZLr1haOAgM9uFmF0AF4tPNzhhIC74tDpOxgsCOAVNo=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 164869: all pass - PUSHED X-Osstest-Versions-This: ovmf=a7cf2c5664b9605162b20ab6b51c7bdcab3e14f0 X-Osstest-Versions-That: ovmf=4473834e7d49c555eca81f96383a1d6d6f5f4bb2 From: osstest service owner Date: Tue, 07 Sep 2021 08:37:21 +0000 flight 164869 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/164869/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf a7cf2c5664b9605162b20ab6b51c7bdcab3e14f0 baseline version: ovmf 4473834e7d49c555eca81f96383a1d6d6f5f4bb2 Last test of basis 164862 2021-09-06 15:10:03 Z 0 days Testing same since 164869 2021-09-07 04:11:11 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Abner Chang Cheng Zhou jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 4473834e7d..a7cf2c5664 a7cf2c5664b9605162b20ab6b51c7bdcab3e14f0 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Tue Sep 07 08:44:36 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 08:44:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180639.327369 (Exim 4.92) (envelope-from ) id 1mNWiO-0001O1-DE; Tue, 07 Sep 2021 08:44:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180639.327369; Tue, 07 Sep 2021 08:44:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNWiO-0001Nu-A0; Tue, 07 Sep 2021 08:44:24 +0000 Received: by outflank-mailman (input) for mailman id 180639; Tue, 07 Sep 2021 08:44:23 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNWiN-0001No-Io for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 08:44:23 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id cc12e3ba-0fb7-11ec-b0da-12813bfff9fa; Tue, 07 Sep 2021 08:44:22 +0000 (UTC) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05lp2172.outbound.protection.outlook.com [104.47.17.172]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-17-oBpkjDe3M9inU-ss14bDRA-1; Tue, 07 Sep 2021 10:44:20 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VE1PR04MB6478.eurprd04.prod.outlook.com (2603:10a6:803:12a::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.22; Tue, 7 Sep 2021 08:44:19 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4500.014; Tue, 7 Sep 2021 08:44:19 +0000 Received: from [10.156.60.236] (37.24.206.209) by PR3P191CA0059.EURP191.PROD.OUTLOOK.COM (2603:10a6:102:55::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.21 via Frontend Transport; Tue, 7 Sep 2021 08:44:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cc12e3ba-0fb7-11ec-b0da-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1631004261; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=y4e7cPHUvDvUZfKXDaQ86Rvpo//kr0KR6cJuZ42srw8=; b=YdMmxJB6LCzBqyjr+DM5N/SKAO3o7KNK6zUW8qkEMnfnrOiIz5X1OQ2ktnzRUwkH0d8HAz w9sdMQaDQrZ6d7PNsRfHq0ogbzjXXItdbAVBlymFazNkZgpftm1ZKKExRaXiPjzEWlDnnx 6S3+tMkTaL8Z6Uou5HOHwRzAZHhQURM= X-MC-Unique: oBpkjDe3M9inU-ss14bDRA-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gOow3NjjInyVCfxS9vqeqY63pJ0KBiESWjsfyp+1ATipzvH2igUzh11pjTShd2KncD7rR/ayi3gTvIomuKNu0I6Y2mxGdFpQadArg3Y1+BmmL8jknM0cAsmHWUO5/j1Xkx0yZn4thNgYX5/6ypI9XZBNZ7pbj/PnlPprdgnnMaCwvMELkITT61+N0MtyYAHQE/okgKKkgCB88CEujXNlwJDW0FUUR7lbdkH3iybMe24zZsrBS1D00FekTjdR+KzXdCvYgYm2yDDXH84RmRRrYMylwAHLlPo8NUA9Pn9jArRndw0YjX1MV/ajdjx1YjhCZJgG3PBJEBkB7FOpTNdP8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=y4e7cPHUvDvUZfKXDaQ86Rvpo//kr0KR6cJuZ42srw8=; b=DUY8S9+3T4PqbPkfbNPukhp/vXabM3oi+pV5oxCLfJLWJMbsu/FbVEBZerI+OB6tzwZNcQTxZSo+lPjkrK2ZcPJLZCJx1q4lJLQbtbhBh190aakPZBYPi5jVjQdimTsKVXwCGFgOuP28uz4R5RENQhyd6/VzwvrI9XK+JSXxlnzV3DyfbdAUu2Xisx8FZX4B/lOfx+HD7icfHKhSJw0/AYp+IHXiMvfq9bSHjULMDaPY7J52Tuqko0xGkE1Aiw6n0nbLLBbq1mz1eNkjUZUyX/AMSClxc+u+aLkOShZ40b4AMfcPBXyea67SWwRCWvhaC3eql7A+391cL06fLToCGg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com; Subject: Re: [PATCH 2/9] vpci: Add hooks for PCI device assign/de-assign To: Oleksandr Andrushchenko , Oleksandr Andrushchenko Cc: "julien@xen.org" , "sstabellini@kernel.org" , Oleksandr Tyshchenko , Volodymyr Babchuk , Artem Mygaiev , "roger.pau@citrix.com" , Bertrand Marquis , Rahul Singh , "xen-devel@lists.xenproject.org" References: <20210903100831.177748-1-andr2000@gmail.com> <20210903100831.177748-3-andr2000@gmail.com> <371a403c-adec-f1e1-8887-5664a749b169@suse.com> From: Jan Beulich Message-ID: Date: Tue, 7 Sep 2021 10:44:17 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PR3P191CA0059.EURP191.PROD.OUTLOOK.COM (2603:10a6:102:55::34) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c996cd76-f1d4-41ad-3d7d-08d971dbaecc X-MS-TrafficTypeDiagnostic: VE1PR04MB6478: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VF2FFk0KGCV3MQlxoEH+MsOlzoP1NcNWFOgje6DRluLaRJaeMdnvbI2PwFUkbvPeoSrwDZ3iegVl6iIVZBqguzRlI/h2VBvn1dgakh4VOI2+9EvkKnON5Co+6lPf6CmZQd4aftwx89hbu0zzKVM3xhwet3gDpxHd0SWM6Jme9YUVZTLw6zeEMpskmYAUY//QxB67njQAE56fNaWKTcVaUELa/izF9Mx5qO69TxZL0XfCu6rRyAeVY6Ie9u72wj8cvcfgoDSGBvaNhhCPXnVda4X+aVn1z/oO5Kxw0RdsUsyrW74WnzNBuOpL4eRskbJOVzD70kGOrUSg7uXRR7IfyMTM69LnfeGQSMGav02SV+MH0jRa1GNzKF3YSAJOEy5jAyZzYwiM7hXXw5Jr+F9+nq+r3ZGzS5sgvt5yaZ07OVkwo1e0t2DwcgYdLMNI9H+bcq5oM0G8fn0goHQoYzUToy8UR8ZbkgYuE2uQO0zwTxYwkkKXQpWfBoXkpJkO9UocTQGJOJonddXlKC5JPTDm2OLcMgJfsQ9TCM6qA/IcGTucxnvE3OPDRMH/dfwFJ68Vfjy3rv9W1mx/6Kn6LW4eQWvrU3AyV/PkZlY1fd162XtFWNEcDZhPAco3zvgTEa41zV7sc8Cff+KvUUlkcLUrcGBpGNUwbryPGBZwIDxj03SoQx1EAWNymVVj+um0hU/+frLAI+fCOaCGu7xU25DXniaWnBfA/0x9zu/PG1L68tQ= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(396003)(39860400002)(136003)(376002)(366004)(346002)(316002)(16576012)(110136005)(54906003)(4326008)(83380400001)(5660300002)(478600001)(26005)(7416002)(66556008)(53546011)(66476007)(66946007)(186003)(38100700002)(86362001)(31696002)(6486002)(2616005)(956004)(31686004)(2906002)(36756003)(8936002)(8676002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SXdaMHcxNVN3VzJ5a0VoUG5Md04wNHBPcWZmckI2c3gycVE3Z29rVW9USDNB?= =?utf-8?B?WjRzQ2pYMFNPR0REd09zUDhLWmdIWWJjVHRLUEhwNDVROWNnakJhcU9OSXNj?= =?utf-8?B?aTNBSml1MW1qWnp0cDlBZmp2cy8zQW44TkZ5QW9IbFpJQnpqYmVoNUJPUk80?= =?utf-8?B?d0hqTTZZN2ZrTlkvYzJPeDI1Ly9MYk5lM0twOEdWRHozbW9kQ2VpcDE3KzEy?= =?utf-8?B?U0lwMmlqVVdDYWova2J5T0EvZzFsMndhQXM0RXNOVkM0WnNNNzUrNG9hSWh4?= =?utf-8?B?M2Jab2hsZkVFczdQOHQ1cUxiVWVUa3VBY202VWRReTNpL0oxM254cWNXak56?= =?utf-8?B?ajVabmdyWDNvOHF5KzNvY3Q2dlBBUUVDRHl5d29OVDhRemNJL20xZjZRUmlG?= =?utf-8?B?SFA3dHB1TmVpMWE1ei9lSE9BaWdMNkU2aGdFZTF2bXk4UUl5T2t6YTZUN0Rj?= =?utf-8?B?dUVZWlBaM0lZQTV4bVhpMWdCY2cxdkx1MWRjVmlYbTZxMVExVkRlVnhrcVZp?= =?utf-8?B?cVlWeWc1STBlOHRDV1RJcmYzeWJVVjdwY0ZhRi9lVldMWDlUS3lLUTI1YW5w?= =?utf-8?B?TlZvbmJJckc1TnpIQzM5NDNKS2paZDNPMXBJR3k3dzRsa3hjblAveHUwMEV2?= =?utf-8?B?K2RZMzFqeXZQUU5zT214OHozck5XbE5EMitkc0p3MmI3ZmUySzdLTGVqUHZQ?= =?utf-8?B?M3F3azZVL1hDYU55T1d5NnBSeFVhenRqVEZXeTM2a3FIdmtVTDRnL0hzb2M1?= =?utf-8?B?K0JlTHJPVDgxYWlRcUhFbk9xTGpSb29veiszRVpLaFRhbVpDMlhzSWp0Wjhm?= =?utf-8?B?ZitPb3FVeXYrTVgydlUxWG9NbnFQZTZXMzFMRlNTVTF2WnNDQlNrWnZSVnRS?= =?utf-8?B?bzZjRU55Ylpaa0xrR0hCNDVTSC9Oa1dRZlIrWHgxQnVxNERkZEtocVBwTGMw?= =?utf-8?B?T1VqTHY4cGRON3VsbEFBMlhXbFVseFpHN0lzRnE4Rm1NVjJSSHZId3JFVWYz?= =?utf-8?B?NkxReks5d1N1VGZpNlhGeVBXbXFXWFg2c21weFBZVU9jSVJGbmpJL3Rzdko5?= =?utf-8?B?ZjYrOE9NMlJycFoyQTNiY25XN1NoQlliMXNhaDdWNHZxZXY1emhiNHhXbDFi?= =?utf-8?B?bmJIV1d3SWt0Vm54amVNRm1MdUk3M20rUUhrb2N1c3JhNTRlOW5RbXZZMlZC?= =?utf-8?B?Ym5taGdzUjVDYXRVdnBGVnkxWEg3SWRhOVk4UU5pOUhyZUd6ZjlDZ1ovWHFH?= =?utf-8?B?aElsSHJQTmgxVFV1SzNaRmltMUlGY0hwa3NWMy91RTZNc3MzNGtnOUVEcFlk?= =?utf-8?B?SVNCNG5aU1dmaGkwQXFxM3BuSGx6bVFZVnMxMWt0SkpaRUl3QlF2MUw5eG9Y?= =?utf-8?B?NXJ6L2dldFN4WXdNNnBOYXJveDQrNGNDbkEzYkpEaVlCQ3c0alBLRSsyMEd0?= =?utf-8?B?RkxKYVIxaEo5U0xtbzhFN1Z0c0VnTUo4OEp6dVRmeUFlYmFJdEdQbVdWUTFq?= =?utf-8?B?aEF6T3FVb0FCc0JLTW5qUEE1TmY2c3MzNzF2bzNMTmkyRHpVUWFyQjVCcGJm?= =?utf-8?B?RHNQNE9VaWMyUXFCenVFaEt0QmZ2aURtVFB6WUZuTEw3K2hoTllYRGFWeTBE?= =?utf-8?B?Q290NnRkeW4rQnZEeHpST3ZPVVVpTUNpWW1Bd1ZvQ2xYVE1vK1B2WUZQeklX?= =?utf-8?B?TUxySEVJa3FrLzFRSTB6UG9ydEVuM3F4bkNSYW1nSDNDQXA2QmZzNGNCODA3?= =?utf-8?Q?tK61S0zdo1rRJMkw2vquIRETKrJH6w0eQ9ifkMC?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: c996cd76-f1d4-41ad-3d7d-08d971dbaecc X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2021 08:44:19.5302 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: HchVqPhG4yzsYm02HKtDhZNhZiHstDe+4WMddXT/g3GBiLb+MLl899LV++udI191a/RB5Vdzt5ttPYDx7c7vCw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6478 On 07.09.2021 10:33, Oleksandr Andrushchenko wrote: > On 06.09.21 16:23, Jan Beulich wrote: >> On 03.09.2021 12:08, Oleksandr Andrushchenko wrote: >>> --- a/xen/drivers/passthrough/pci.c >>> +++ b/xen/drivers/passthrough/pci.c >>> @@ -864,6 +864,10 @@ static int deassign_device(struct domain *d, uint16_t seg, uint8_t bus, >>> if ( ret ) >>> goto out; >>> >>> + ret = vpci_deassign_device(d, pdev); >>> + if ( ret ) >>> + goto out; >>> + >>> if ( pdev->domain == hardware_domain ) >>> pdev->quarantine = false; >>> >>> @@ -1425,6 +1429,11 @@ static int assign_device(struct domain *d, u16 seg, u8 bus, u8 devfn, u32 flag) >>> rc = hd->platform_ops->assign_device(d, devfn, pci_to_dev(pdev), flag); >>> } >>> >>> + if ( rc ) >>> + goto done; >>> + >>> + rc = vpci_assign_device(d, pdev); >>> + >>> done: >>> if ( rc ) >>> printk(XENLOG_G_WARNING "%pd: assign (%pp) failed (%d)\n", >> I have to admit that I'm worried by the further lack of unwinding in >> case of error: We're not really good at this, I agree, but it would >> be quite nice if the problem didn't get worse. At the very least if >> the device was de-assigned from Dom0 and assignment to a DomU failed, >> imo you will want to restore Dom0's settings. > > In the current design the error path is handled by the toolstack > via XEN_DOMCTL_assign_device/XEN_DOMCTL_deassign_device, > so this is why it is "ok" to have the code structured in the > assign_device as it is, e.g. roll back will be handled on deassign_device. > So, it is up to the toolstack to re-assign the device to Dom0 or DomIO(?) > in case of error and we do rely on the toolstack in Xen. > >> >> Also in the latter case don't you need to additionally call >> vpci_deassign_device() for the prior owner of the device? > > Even if we wanted to help the toolstack with the roll-back in case of an error > this would IMO make things even worth, e.g. we will de-assign for vPCI, but will > leave IOMMU path untouched which would result in some mess. > So, my only guess here is that we should rely on the toolstack completely as > it was before PCI passthrough on Arm. Well, okay, but please make this explicit in the description then. Jan From xen-devel-bounces@lists.xenproject.org Tue Sep 07 08:49:56 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 08:49:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180645.327380 (Exim 4.92) (envelope-from ) id 1mNWnd-00022u-3C; Tue, 07 Sep 2021 08:49:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180645.327380; Tue, 07 Sep 2021 08:49:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNWnc-00022n-V2; Tue, 07 Sep 2021 08:49:48 +0000 Received: by outflank-mailman (input) for mailman id 180645; Tue, 07 Sep 2021 08:49:47 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNWnb-00022h-5C for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 08:49:47 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 8cca3e32-0fb8-11ec-b0dd-12813bfff9fa; Tue, 07 Sep 2021 08:49:46 +0000 (UTC) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04lp2050.outbound.protection.outlook.com [104.47.13.50]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-17-_uOl7SUxNhK_wGlpSXP27Q-1; Tue, 07 Sep 2021 10:49:43 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VE1PR04MB6669.eurprd04.prod.outlook.com (2603:10a6:803:125::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.24; Tue, 7 Sep 2021 08:49:42 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4500.014; Tue, 7 Sep 2021 08:49:42 +0000 Received: from [10.156.60.236] (37.24.206.209) by AM0PR02CA0120.eurprd02.prod.outlook.com (2603:10a6:20b:28c::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Tue, 7 Sep 2021 08:49:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8cca3e32-0fb8-11ec-b0dd-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1631004585; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+USiVCtL27+QQVariAoWrWCDUJ0hi/rb0UFRwLTlaow=; b=SYDMJFrpR7gpCRgiYpYjofoYikWKfk9roc1lp9retPps7XGuA9L8ftdsbC50vJovjCgYAK VOLq/cM7rm5qIb8anrvQSMGM5V0kLjskLrph/hFBaiIJun6tio/pszBr6q/aDnxHdxafM+ 9sKSngbhuTW6hJKncBURWVbyXp1kZE8= X-MC-Unique: _uOl7SUxNhK_wGlpSXP27Q-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ec6JgUnFhyybd6anCfRarEA/03/sBMUfW9BG0eSLitlfHjvZeWUBhENH43rjKmwrG+W7+SW0v1Bg1PKN6na16IkTHiUSOUB6yQ3bbtQ9z+0gwdFlTEhBkCfFhwiePCwUrI0vEYsoriCd34mLHFpqvSWgyyFLGxcIDx51JRpi3WhJ5eOgk9sp9zrrcZZrCC4SNY5dmtXoCFVkr5o65Rcpqd4WBevNRugpJ58iOgB6KXK7NSJuWmQhszq5p0S75kuPy43gUmNVEmpiiBGwpkReuD+0T1jbjNZFpOJgybkhpxjjuVq7KFuUSC6TyrmanmtV+Z2bl39lKbFAQLj31UUPaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=m0kuWnlTREyx4UISZpn1Ak+Ryu5Www7B1hzmyh1mIPU=; b=O+LzsgfB8sER4uDHJ7yGBhX6Fw3VX80mmKc8HnCIB6BS9ZfZdMrxE+WyAfoUhN9udpbo+ejDNylk9FJUCZLGeiMUJg2P9L+MZKbyBguyoBSLf2wj8GCZzBSDr33r0DVskdAt+xXPAB3dtFQGPezAOhSGVNQtww/hHqS72jlmmB89srWmAsXeSHr25J9WkjLHgAe0FngmZ2bTGdx6Sx2jAj1pU0UZ2p2ZvsIM6bkf9i9IIOhOT9/jRuf9+blcFi+hNNRoaAzmPbsFctDjm8jcAMEKVmouBlc3UMO0AlSBVqV9LZpKwaKWAp3p1fXg5dX5ZieAAr05eyv0Bk0NETa6Fg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com; Subject: Re: [PATCH 8/9] vpci/header: Reset the command register when adding devices To: Oleksandr Andrushchenko , Oleksandr Andrushchenko CC: "julien@xen.org" , "sstabellini@kernel.org" , Oleksandr Tyshchenko , Volodymyr Babchuk , Artem Mygaiev , "roger.pau@citrix.com" , Bertrand Marquis , Rahul Singh , "xen-devel@lists.xenproject.org" References: <20210903100831.177748-1-andr2000@gmail.com> <20210903100831.177748-9-andr2000@gmail.com> <5366265c-d169-041d-f812-1c49260f6499@epam.com> <8f1816db-798b-15d9-7343-2199eb8f39e0@suse.com> <0e3942a5-9105-c99e-f15e-dcf35aae142a@epam.com> From: Jan Beulich Message-ID: Date: Tue, 7 Sep 2021 10:49:38 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: <0e3942a5-9105-c99e-f15e-dcf35aae142a@epam.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AM0PR02CA0120.eurprd02.prod.outlook.com (2603:10a6:20b:28c::17) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d6a9fe48-1b83-4bec-108f-08d971dc6e86 X-MS-TrafficTypeDiagnostic: VE1PR04MB6669: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GnOff/IUUpeRC0jvHqH3QlMUKu89A+rAXavLqdve8muAYenIFul/ALNCkWEHgLdObZuA0PjY9u27cQqiDKfrbGeP+ZKS6BnBHAO8q5vXIov9z6Opw1BoadxLsJbwNmtb7uLr6EvnxmXUmJ3q2Ftm3u1oQ+ekk9mad8RR27l6P8oU1Fw3XqdB8U0tKE8Sn3t/a2b6UDuNQfhZlqdVhjzLhi26Z42vaziNvtlUt8eKriK37t5r2p7fLx3FRozGN4QarK5urjo5gE8YPE7+tHp2WK/cXEeCyMoCVM/AmrY9LkRK79FJQoryddF59kKzSrom3+sXhERYmjDEbjkCm6KBYlMb79E2x1VlvNNbbA1yHkDjzv37hfACELAM8mPMlW8OXwoP2KSgBfa/T4wZCYtE9wxb2Dxwm288g4MR/7LHGMQdMBCGiygTfDmX/shWiTwqUZ9UBaJyf1ju145SBIajYzK2I2+dUNtz38+mNqcL+06044bHKwfAMV13R/xIao7rjBWLtzw8EbFysjGxTnbAz6epnJHgNzfUpiqtFo4JPoW3wQFgEwprraKRsbQ+31499xfUjpErE76dMBNVYCyxOxz330P59Pn2qHzUs3pBKHcfW6TzUxV8wcxlwRZOX6QYGLjTjmlunQouakKPB/QdXvTCUEOWZSPQ3kI2NyXWBxUUs02dgJfIbJ8c8InWxj8GM720ITbHSHkoGzhZn9SmuhtybKvWI8OgowoxP1GgkareVWe1f5dp+ZezaVfLbRsz X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(376002)(366004)(396003)(346002)(136003)(39860400002)(54906003)(110136005)(36756003)(38100700002)(53546011)(8936002)(7416002)(186003)(26005)(66946007)(66476007)(8676002)(2616005)(478600001)(956004)(66556008)(5660300002)(2906002)(4326008)(83380400001)(6486002)(16576012)(31696002)(316002)(86362001)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?JJasR3zm8M7Mh6GuhMxIWpP7hL4CS4grKhNx71AcXJMgxezQOePwyM35dU8y?= =?us-ascii?Q?Fn5LFobznt4+XmSAavLgr/TncGgq0W28xDSYmqkM7vou03IMEiunZt82x56I?= =?us-ascii?Q?xZTDzsz7dY9/UwYjJuo3w45RiYGnvzIUAxc7LiD4XQmKE12Y+MnLOqGnghcQ?= =?us-ascii?Q?B7b2qFYZcvbtFXDnOdE2EA3vDbcTO7FieE6Mz2Qh/gDMGBo5YwsuzA0wB2rc?= =?us-ascii?Q?vQCwrmwvhmRyz3T8DDAUeP5w6PF7wl3DXooi5ZzbCHydNNCuqzyL4sDe/93j?= =?us-ascii?Q?43GFfzBp5sm+5+nvfNv4sDHP9+Ur+34ZbC0lCKLaTxXqcbT+ofnVS6vm6yoU?= =?us-ascii?Q?xWP66URUnzs6Wtwg/bcTbyL8WFzfgTiN3s1h8Fm8bqTCVllpxuJgIFqcMY4G?= =?us-ascii?Q?KqfBfPCzsWtsE2/yOEqwgHPi4RNNYxxb4t0YE6zu1BIna74GjfrcsHBFfA24?= =?us-ascii?Q?NL1hBM3VRbTFVbhdD7paPocTX9Z/pYJ2n4hEVDv0MmYM58NdkiJI2LOHvoZp?= =?us-ascii?Q?xiMa2aRCuzAockgGA6gKBXZCyu27RjyeQzCAw5QFvRcdMcbf52QEFL0GOi7p?= =?us-ascii?Q?rWRbfN6z1E+LdE2b+vO0c/ojGkLtsAR0g82m4z3h5GoE6OAZRE45hzkEt6jI?= =?us-ascii?Q?i8Fyy8rjeMHBG5TySf+wDx92KWRfBiTL9AxleGK/FYSMxLjeTUzP3sxLl5bA?= =?us-ascii?Q?EHofjFkmqcIzwJzEtIUazPdnwb8SDD8/PlSRT4MfE8uy0R1owt8h2PDF1TLk?= =?us-ascii?Q?9egnKEyEk1vv2EvUWj6Ukg4XkAH4BOusI18sCrkHeBE/RPTAPRqee8YOYTSM?= =?us-ascii?Q?ZotSMWl8+fxphaXMLkHp6HFwvoEU+hZXH7BQrXJzb70jKTAXMz1LP8mv91xj?= =?us-ascii?Q?F326q6Zhy8VkpPi7qbDTp4GFA2Kbc4Cfl38YYWTNSUVKnqK4dzthkpUrdBed?= =?us-ascii?Q?Ekr4EpK1Nhz+lxYmnnYXPQ/Y/agT/riwO99xda8GCKJt6u1V68nJVBOlTLoW?= =?us-ascii?Q?dTqBiy6UUHO0tQD4sLoy32TYX2AiEB/1yccUgPC9Vs+u5G5U/Ol7EVBEr77Z?= =?us-ascii?Q?tEWc2ny7LQC3SI/OJ0qtrdAZUvEPBYI1loQslZgC5BwVJOxohk/wvbtG5KTO?= =?us-ascii?Q?7PKZUZGK5QManJOLxbkd8FJWqLpjrIMS6FHvmH//OpuiBj1oJR7TnKt3D6wT?= =?us-ascii?Q?iOmiw9LyQ30Ou8xzxD8Pbx0erg//KtU5CXzVnnWrgSvoPjAN+hW3yRqe1d6x?= =?us-ascii?Q?fktusEporvHSbCnw8x0uTXPymY0DMszGjMKRxQcGaLuLsfvmYB/7Nwg8KrM3?= =?us-ascii?Q?lGWJbRtOmEdTXWA8JyxbOem0?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: d6a9fe48-1b83-4bec-108f-08d971dc6e86 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2021 08:49:42.1373 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: iUna6nDs2FsHh1Ppp1OZWQNRynqh1YADuz3Iy2JqGbYHxoR7qelKXsdtZ5VBr0o89arxGqWJuKRHOw8xdq3//A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6669 On 07.09.2021 10:18, Oleksandr Andrushchenko wrote: >=20 > On 07.09.21 11:00, Jan Beulich wrote: >> On 07.09.2021 09:43, Oleksandr Andrushchenko wrote: >>> On 06.09.21 17:55, Jan Beulich wrote: >>>> On 03.09.2021 12:08, Oleksandr Andrushchenko wrote: >>>>> --- a/xen/drivers/vpci/header.c >>>>> +++ b/xen/drivers/vpci/header.c >>>>> @@ -811,6 +811,16 @@ int vpci_bar_add_handlers(const struct domain *d= , struct pci_dev *pdev) >>>>> gprintk(XENLOG_ERR, >>>>> "%pp: failed to add BAR handlers for dom%d\n", &pdev->= sbdf, >>>>> d->domain_id); >>>>> + >>>>> + /* >>>>> + * Reset the command register: it is possible that when passing >>>>> + * through a PCI device its memory decoding bits in the command >>>>> + * register are already set. Thus, a guest OS may not write to t= he >>>>> + * command register to update memory decoding, so guest mappings >>>>> + * (guest's view of the BARs) are left not updated. >>>>> + */ >>>>> + pci_conf_write16(pdev->sbdf, PCI_COMMAND, 0); >>>> Can you really blindly write 0 here? What about bits that have to be >>>> under host control, e.g. INTX_DISABLE? I can see that you may want to >>>> hand off with I/O and memory decoding off and bus mastering disabled, >>>> but for every other bit (including reserved ones) I'd expect separate >>>> justification (in the commit message). >>> According to "PCI LOCAL BUS SPECIFICATION, REV. 3.0" I have at hand, >>> section "6.2.2 Device Control" says that the reset state of the command >>> register is typically 0, so this is why I chose to write 0 here, e.g. >>> make the command register as if it is after the reset. >>> >>> With respect to host control: we currently do not really emulate comman= d >>> register which probably was ok for x86 PVH Dom0 and this might not be t= he >>> case now as we add DomU's. That being said: in my implementation guest = can >>> alter command register as it wants without restrictions. >>> If we see it does need proper emulation then we would need adding that = as >>> well (is not part of this series though). >>> >>> Meanwhile, I agree that we can only reset IO space, memory space and bu= s >>> master bits and leave the rest untouched. But again, without proper com= mand >>> register emulation guests can still set what they want. >> Yes, writes to the register will need emulating for DomU. >=20 > But then I am wondering to what extent we need to emulate the command >=20 > register? We have the following bits in the command register: >=20 > #define=C2=A0 PCI_COMMAND_IO=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 0x1=C2= =A0=C2=A0=C2=A0 /* Enable response in I/O space */ > #define=C2=A0 PCI_COMMAND_MEMORY=C2=A0=C2=A0=C2=A0 0x2=C2=A0=C2=A0=C2=A0 = /* Enable response in Memory space */ > #define=C2=A0 PCI_COMMAND_MASTER=C2=A0=C2=A0=C2=A0 0x4=C2=A0=C2=A0=C2=A0 = /* Enable bus mastering */ > #define=C2=A0 PCI_COMMAND_SPECIAL=C2=A0=C2=A0=C2=A0 0x8=C2=A0=C2=A0=C2=A0= /* Enable response to special cycles */ > #define=C2=A0 PCI_COMMAND_INVALIDATE=C2=A0=C2=A0=C2=A0 0x10=C2=A0=C2=A0= =C2=A0 /* Use memory write and invalidate */ > #define=C2=A0 PCI_COMMAND_VGA_PALETTE 0x20=C2=A0=C2=A0=C2=A0 /* Enable pa= lette snooping */ > #define=C2=A0 PCI_COMMAND_PARITY=C2=A0=C2=A0=C2=A0 0x40=C2=A0=C2=A0=C2=A0= /* Enable parity checking */ > #define=C2=A0 PCI_COMMAND_WAIT =C2=A0=C2=A0=C2=A0 0x80=C2=A0=C2=A0=C2=A0 = /* Enable address/data stepping */ > #define=C2=A0 PCI_COMMAND_SERR=C2=A0=C2=A0=C2=A0 0x100=C2=A0=C2=A0=C2=A0 = /* Enable SERR */ > #define=C2=A0 PCI_COMMAND_FAST_BACK=C2=A0=C2=A0=C2=A0 0x200=C2=A0=C2=A0= =C2=A0 /* Enable back-to-back writes */ > #define=C2=A0 PCI_COMMAND_INTX_DISABLE 0x400 /* INTx Emulation Disable */ >=20 > We want the guest to access directly at least I/O and memory decoding and= bus mastering > bits, but how do we emulate the rest? Do you mean we can match the rest t= o what host > uses for the device, like PCI_COMMAND_INTX_DISABLE bit? If so, as per my = understanding, > those bits get set/cleared when a device is enabled, e.g. by Linux kernel= /device driver for example. I would suggest to take qemu's emulation as a starting point. > So, if we have a hidden PCI device which can be assigned to a guest and i= t is literally untouched > (not enabled in Dom0) then I think there will be no such reference as "ho= st assigned values" as > most probably the command register will remain in its after reset state. What meaning of "hidden" do you imply here? Devices passed to pci_{hide,ro}_device() may not be assigned to guests ... For any other meaning of "hidden", even if the device is completely ignored by Dom0, certain of the properties still cannot be allowed to be DomU-controlled. (I'm therefore not sure in how far Dom0 can actually legitimately "ignore" devices. It may decide to not enable them, but that's not "ignoring".) Jan From xen-devel-bounces@lists.xenproject.org Tue Sep 07 08:54:10 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 08:54:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180656.327391 (Exim 4.92) (envelope-from ) id 1mNWrp-0003lL-O9; Tue, 07 Sep 2021 08:54:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180656.327391; Tue, 07 Sep 2021 08:54:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNWrp-0003lE-L1; Tue, 07 Sep 2021 08:54:09 +0000 Received: by outflank-mailman (input) for mailman id 180656; Tue, 07 Sep 2021 08:54:08 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNWro-0003l8-4g for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 08:54:08 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com (unknown [40.107.2.87]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 656bb1bb-3465-4a4c-a600-cf12a2c49f3a; Tue, 07 Sep 2021 08:54:04 +0000 (UTC) Received: from AM6PR08CA0018.eurprd08.prod.outlook.com (2603:10a6:20b:b2::30) by VI1PR08MB5533.eurprd08.prod.outlook.com (2603:10a6:803:12d::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.21; Tue, 7 Sep 2021 08:54:00 +0000 Received: from AM5EUR03FT035.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:b2:cafe::26) by AM6PR08CA0018.outlook.office365.com (2603:10a6:20b:b2::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Tue, 7 Sep 2021 08:54:00 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT035.mail.protection.outlook.com (10.152.16.119) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Tue, 7 Sep 2021 08:53:59 +0000 Received: ("Tessian outbound b48d04bf8afd:v105"); Tue, 07 Sep 2021 08:53:59 +0000 Received: from 157a9ae1b450.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 4F7A7C14-4190-4850-BC8A-D468F262965C.1; Tue, 07 Sep 2021 08:53:53 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 157a9ae1b450.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 07 Sep 2021 08:53:53 +0000 Received: from PA4PR08MB6253.eurprd08.prod.outlook.com (2603:10a6:102:e4::8) by PA4PR08MB6063.eurprd08.prod.outlook.com (2603:10a6:102:ed::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19; Tue, 7 Sep 2021 08:53:52 +0000 Received: from PA4PR08MB6253.eurprd08.prod.outlook.com ([fe80::e4b3:8a19:4478:2f6e]) by PA4PR08MB6253.eurprd08.prod.outlook.com ([fe80::e4b3:8a19:4478:2f6e%7]) with mapi id 15.20.4478.025; Tue, 7 Sep 2021 08:53:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 656bb1bb-3465-4a4c-a600-cf12a2c49f3a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YL8Pk4V+1+v3exfGE2oOhB0Xp/3yEFdKkhD+1Klxtig=; b=zPYfCHsrM4Rs27JP3pM/HrNedV1T+IzxAwRjYZ2bTWONiz8UXclKDYg3IiR7+mKdGhVCvmL7bS4lIlYNxro0EC2tDKRz7gU2avYQ8RYURZZX4VYOGSGkibBE2nTZja4XUfoIM22ARy5hDoVuUSlNSdtICdASJTWOh3t6ENbh4jw= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=e84oTZfk8Zcl52z7i4r7VtQBj4cOzj1kxmwZgyG+uJVoblQHNkfOeETP7+wccaonACmwpxXl1lZVqZVtA8x7a/fKiLCfNGKFo+P8VlNwLH9MKncFMoCADEcSfSFxL53TFPGAiXKfvMLZ2LzRv7U4rIuB/Nlb5VCV3O7wnsYNwc60Mb+WijLpxhF6GtrtDVssdtjw+W1+PkjRdL9Pt+LMeZiaBxTKe3PFETDmFXrx3UE107VCcnUrZE6qf3KPmXaL3x4PJS9LR6BJbBiai0kT8FDqaESKlNzr9HWYlhZziHF60tXdobsNk+hueCmRNCReWkHeUOznCw4u+b1v+8TxQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=YL8Pk4V+1+v3exfGE2oOhB0Xp/3yEFdKkhD+1Klxtig=; b=hooCY5EuNb25T0NPUd+eF++yCaNNNYH/xqruKxWv8p+siSd9U4xX9MX2REOfg5umSltAPEmqOoRWb7BhBWfKJ9C9tgJ2Iu++dzjVcmThgyVfLBqW6Q0899LOpJayQtWdaYReXyHTRKZMs72UPe7xrqRXfEDMrGb5r+QFLFzj5YSh3SdqHeF7Z5Y3vM85zvELBjR64rkq2MwtjzAxGRMCqdL4aXvABPS5GrGX/l6OPJ0S/mlnFaEuBzkS02SvLnob/Rl39cqT/U22MNtNQ0YEHJoCtWBTuxw2ptDU1hyGtfbqP0XwgOdm0Eet5wACS2HSQ7eb0POVM58le+alLVGWew== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YL8Pk4V+1+v3exfGE2oOhB0Xp/3yEFdKkhD+1Klxtig=; b=zPYfCHsrM4Rs27JP3pM/HrNedV1T+IzxAwRjYZ2bTWONiz8UXclKDYg3IiR7+mKdGhVCvmL7bS4lIlYNxro0EC2tDKRz7gU2avYQ8RYURZZX4VYOGSGkibBE2nTZja4XUfoIM22ARy5hDoVuUSlNSdtICdASJTWOh3t6ENbh4jw= From: Henry Wang To: Oleksandr Tyshchenko , "xen-devel@lists.xenproject.org" CC: Oleksandr Tyshchenko , Daniel De Graaf , "Daniel P. Smith" , Ian Jackson , Wei Liu , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Volodymyr Babchuk , =?iso-8859-1?Q?Roger_Pau_Monn=E9?= , Bertrand Marquis , Wei Chen Subject: RE: [RFC PATCH] xen/memory: Introduce a hypercall to provide unallocated space Thread-Topic: [RFC PATCH] xen/memory: Introduce a hypercall to provide unallocated space Thread-Index: AQHXg8xFOJw2l6FsN06730YVyibR0auYgwfg Date: Tue, 7 Sep 2021 08:53:52 +0000 Message-ID: References: <1627489110-25633-1-git-send-email-olekstysh@gmail.com> In-Reply-To: <1627489110-25633-1-git-send-email-olekstysh@gmail.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: C01E3F5F0E5BE947987B72EC078054FB.0 x-checkrecipientchecked: true Authentication-Results-Original: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=arm.com; x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: 998654e2-1ebe-4345-80a6-08d971dd08d6 x-ms-traffictypediagnostic: PA4PR08MB6063:|VI1PR08MB5533: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:3513;OLM:3513; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: HfcNRZBTiqINTCcQVCKSjPv3AncExrg0PDIFEbSqqqbWcmhk9FJGydA1HNy8vNJ5mvg0MDO+dtOhKLOGoQGP/GHhXNBwFmzLk/fRcXpwD96QRBcqSQYiGc3qP/JLavW81FkSj539fDw6Xh6+hzqthmS7BvGTTYfgN3M55HurKb+Ybe1nY7E6dKJ3L4PtRJC5Ta1J7RhkT+MKIGzn2dpxf9fuTIpORA7VU3u9LNyzD0kRvzQ21ZxzeS/P012dd8/lA26EG2fuPmTDbzAsWSVnpuFYSzzu9b1i4neLn0iyuWKU7L+th721P8DhzOSc2UuIuQGkH1jAPleKdW15Icbq8WgqTP5MVjhsRit34eLY93MT40iVjkf2b0rxYPwGUZyLIwniGHt5V+P2c1mGh+Ecssh3I24/6rglQdOORUdHk6eM1i+2cNqmc5WVj5+MR1vzTMfCUexQvHJALAVeaENm7wtGT/jRU0ptE7eS26VoYhRYqb2TFBRbIHhCWqYuoelgtR35G2SNFVv0O8fmzVBiTPcJ1MMPIIXC9/aQbFU6lVgQCauLzZuNcNUbyoZi+36jb/p/GsQC7SfBu3AK4hluGn2deFl+2x5T/wJaS2c/oL46Y+pijv/yRPeto2bnh3pdcatT0v1Y9QdVip7rniSERXVRBkzssBtBp/iVZ7emBVFAhs88F8Y8XyboFvfcW0DQpYdxg9ejdQ50k9WvUUwkrVFiMurfzWt1l1JVCW9EbgBZsOjrBv0WN/FRz87D1DsCbG6mrO+igoBnwOFk/KC9BbzcJFPp5bmf32QFflaFH7cvzKk30p7mEvY0RET58cvx40Yh9lfVnTXWQ9eVBM3Zdg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR08MB6253.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(136003)(366004)(396003)(346002)(39860400002)(6506007)(53546011)(8676002)(316002)(5660300002)(83380400001)(7696005)(8936002)(7416002)(33656002)(55016002)(26005)(86362001)(2906002)(38100700002)(71200400001)(122000001)(30864003)(52536014)(966005)(4326008)(9686003)(64756008)(66446008)(186003)(66556008)(478600001)(54906003)(66476007)(38070700005)(76116006)(66946007)(110136005);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB6063 Original-Authentication-Results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT035.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 8da9d086-81a9-473e-071e-08d971dd0442 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9Yjuy6o/733GvZGxuCCoMVUP2Gr9cpzdEvggx+fkOv7AmH5RdCfQVP9Yb3M/hEaFHr2GGZJKhFGHyLnFqHoju+TVYe7xfSuO7Lw6Te3+b5aI+GsA4GmN3yyYZfJbEa2tKRJM0azMC3raQczmIZhcVslNWNwtBzEHL56l6XfmkfE5aTgrqdu2RbVu82c/S6I2ZaZkFYTC4Kq7hfm6kfkIaHvqRm/JO7kJGaFPQ78q18DSTjhTlZ+FXhebfr2aqi716+E/bO5pLRrxzUn1mrbNG/xLbi1B7QdL80jf5pu1ELv3yUGem1XYqXPyVWIi5h33+wwq2ljnHWatm3TFDenot3wdWF9c7GmA1u6c02jZRhvG26MuasgM2D8a+pj1/wQxjmPIlW0rZmR2YJuRmyURebWkaWCIj3p2/+gux9Ch/X0EV+VeAEGZrZ7semvO6+sKhIp74WmuahKpRgET2FOcL4a1sMT9LJaU6uC5OWQaptvGYzwbXu07mNGUj/olWqFhmVhkhXSFj4S7UJIMie/z5dJlmEO92n46eR2CaWEBejIY0nXl42JD4xvGF7HU8ChuA4HeHF/deRJqt0xGWIAiAvWsgz/+mITOsRR6n2ft22IcWRASfZMHXex0wqkPJh43cJ7GEMHhMPPCLzIYW/KgB1JETtJwwhhPm6KrmP8ZrGpnqW1FRx6myV+fKASD90W9GqZZwxw1Zgqff7Sc40ANS/XymoaYluygqFCQ7jvSkK+ZdqxzYodoRXbKH7YP87ItQe/sZ/L2SEX2ptpb0rf7CoKTerQPmJlVnBiZZ62LPKFxmc1ieLpdlhqvUCrHDGvBXu6I0SfpyxUQleBjw3p3Rg== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(376002)(396003)(136003)(39860400002)(346002)(36840700001)(46966006)(83380400001)(7696005)(86362001)(316002)(4326008)(70206006)(70586007)(82310400003)(81166007)(54906003)(966005)(186003)(26005)(33656002)(53546011)(478600001)(336012)(8676002)(47076005)(82740400003)(52536014)(110136005)(8936002)(356005)(6506007)(5660300002)(55016002)(2906002)(36860700001)(30864003)(9686003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2021 08:53:59.8852 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 998654e2-1ebe-4345-80a6-08d971dd08d6 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT035.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB5533 Hi Oleksandr, > -----Original Message----- > From: Xen-devel On Behalf Of > Oleksandr Tyshchenko > Sent: Thursday, July 29, 2021 12:19 AM > To: xen-devel@lists.xenproject.org > Cc: Oleksandr Tyshchenko ; Daniel De > Graaf ; Daniel P. Smith > ; Ian Jackson ; Wei > Liu ; Andrew Cooper ; George > Dunlap ; Jan Beulich ; > Julien Grall ; Stefano Stabellini ; > Volodymyr Babchuk ; Roger Pau Monn=E9 > ; Bertrand Marquis ; > Wei Chen > Subject: [RFC PATCH] xen/memory: Introduce a hypercall to provide > unallocated space >=20 > From: Oleksandr Tyshchenko >=20 > Add XENMEM_get_unallocated_space hypercall which purpose is to > query hypervisor to find regions of guest physical address space > which are unused and can be used to create grant/foreign mappings > instead of wasting real pages from the domain memory for > establishing these mappings. The problem with the current Linux > on Xen on Arm behaviour is if we want to map some guest memory > regions in advance or to perform cache mappings in the backend > we might run out of memory in the host (see XSA-300). > This of course, depends on the both host and guest memory sizes. >=20 > The "unallocated space" can't be figured out precisely by > the domain on Arm without hypervisor involvement: > - not all device I/O regions are known by the time domain starts > creating grant/foreign mappings > - the Dom0 is not aware of memory regions used for the identity > mappings needed for the PV drivers to work > In both cases we might end up re-using these regions by > a mistake. So, the hypervisor which maintains the P2M for the domain > is in the best position to provide "unallocated space". >=20 > The arch code is in charge of finding these regions and filling > in corresponding array in new helper arch_get_unallocated_space(). >=20 > This patch implements common and Arm parts, the x86 specific bits > are left uniplemented for now. >=20 > Signed-off-by: Oleksandr Tyshchenko Tested-by: Henry Wang Kind regards, Henry > --- > Current patch is based on the latest staging branch: > 73c932d tools/libxc: use uint32_t for pirq in xc_domain_irq_permission > and also available at: > https://github.com/otyshchenko1/xen/commits/map_opt_ml1 >=20 > The corresponding Linux changes you can find at: > https://github.com/otyshchenko1/linux/commits/map_opt_ml1 > I am going to publish them soon. > --- > tools/flask/policy/modules/dom0.te | 2 +- > xen/arch/arm/mm.c | 18 ++++++++++++ > xen/common/memory.c | 56 > +++++++++++++++++++++++++++++++++++++ > xen/include/asm-arm/mm.h | 4 +++ > xen/include/asm-x86/mm.h | 8 ++++++ > xen/include/public/memory.h | 37 +++++++++++++++++++++++- > xen/include/xsm/dummy.h | 6 ++++ > xen/include/xsm/xsm.h | 6 ++++ > xen/xsm/dummy.c | 1 + > xen/xsm/flask/hooks.c | 6 ++++ > xen/xsm/flask/policy/access_vectors | 2 ++ > 11 files changed, 144 insertions(+), 2 deletions(-) >=20 > diff --git a/tools/flask/policy/modules/dom0.te > b/tools/flask/policy/modules/dom0.te > index 0a63ce1..b40091f 100644 > --- a/tools/flask/policy/modules/dom0.te > +++ b/tools/flask/policy/modules/dom0.te > @@ -39,7 +39,7 @@ allow dom0_t dom0_t:domain { > }; > allow dom0_t dom0_t:domain2 { > set_cpu_policy gettsc settsc setscheduler set_vnumainfo > - get_vnumainfo psr_cmt_op psr_alloc get_cpu_policy > + get_vnumainfo psr_cmt_op psr_alloc get_cpu_policy > get_unallocated_space > }; > allow dom0_t dom0_t:resource { add remove }; >=20 > diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c > index 0e07335..8a70fe0 100644 > --- a/xen/arch/arm/mm.c > +++ b/xen/arch/arm/mm.c > @@ -1635,6 +1635,24 @@ unsigned long get_upper_mfn_bound(void) > return max_page - 1; > } >=20 > +#define GPFN_ALIGN_TO_GB(x) (((x) + (1UL << 18) - 1) & (~((1UL << 18) - = 1))) > + > +int arch_get_unallocated_space(struct domain *d, > + struct xen_unallocated_region *regions, > + unsigned int *nr_regions) > +{ > + /* > + * Everything not mapped into P2M could be treated as unused. Taking > into > + * the account that we have a lot of unallocated space above > max_mapped_gfn > + * and in order to simplify things, just provide a single 8GB memory > + * region aligned to 1GB boundary for now. > + */ > + regions->start_gpfn =3D > GPFN_ALIGN_TO_GB(domain_get_maximum_gpfn(d) + 1); > + regions->nr_gpfns =3D (1UL << 18) * 8; > + *nr_regions =3D 1; > + > + return 0; > +} > /* > * Local variables: > * mode: C > diff --git a/xen/common/memory.c b/xen/common/memory.c > index e07bd9a..3f9b816 100644 > --- a/xen/common/memory.c > +++ b/xen/common/memory.c > @@ -1811,6 +1811,62 @@ long do_memory_op(unsigned long cmd, > XEN_GUEST_HANDLE_PARAM(void) arg) > start_extent); > break; >=20 > + case XENMEM_get_unallocated_space: > + { > + struct xen_get_unallocated_space xgus; > + struct xen_unallocated_region *regions; > + > + if ( unlikely(start_extent) ) > + return -EINVAL; > + > + if ( copy_from_guest(&xgus, arg, 1) || > + !guest_handle_okay(xgus.buffer, xgus.nr_regions) ) > + return -EFAULT; > + > + d =3D rcu_lock_domain_by_any_id(xgus.domid); > + if ( d =3D=3D NULL ) > + return -ESRCH; > + > + rc =3D xsm_get_unallocated_space(XSM_HOOK, d); > + if ( rc ) > + { > + rcu_unlock_domain(d); > + return rc; > + } > + > + if ( !xgus.nr_regions || xgus.nr_regions > > XEN_MAX_UNALLOCATED_REGIONS ) > + { > + rcu_unlock_domain(d); > + return -EINVAL; > + } > + > + regions =3D xzalloc_array(struct xen_unallocated_region, > xgus.nr_regions); > + if ( !regions ) > + { > + rcu_unlock_domain(d); > + return -ENOMEM; > + } > + > + rc =3D arch_get_unallocated_space(d, regions, &xgus.nr_regions); > + if ( rc ) > + goto unallocated_out; > + > + if ( __copy_to_guest(xgus.buffer, regions, xgus.nr_regions) ) > + { > + rc =3D -EFAULT; > + goto unallocated_out; > + } > + > + if ( __copy_to_guest(arg, &xgus, 1) ) > + rc =3D -EFAULT; > + > +unallocated_out: > + rcu_unlock_domain(d); > + xfree(regions); > + > + break; > + } > + > default: > rc =3D arch_memory_op(cmd, arg); > break; > diff --git a/xen/include/asm-arm/mm.h b/xen/include/asm-arm/mm.h > index ded74d2..99a2824 100644 > --- a/xen/include/asm-arm/mm.h > +++ b/xen/include/asm-arm/mm.h > @@ -359,6 +359,10 @@ void clear_and_clean_page(struct page_info *page); >=20 > unsigned int arch_get_dma_bitsize(void); >=20 > +int arch_get_unallocated_space(struct domain *d, > + struct xen_unallocated_region *regions, > + unsigned int *nr_regions); > + > #endif /* __ARCH_ARM_MM__ */ > /* > * Local variables: > diff --git a/xen/include/asm-x86/mm.h b/xen/include/asm-x86/mm.h > index cb90527..6244bc4 100644 > --- a/xen/include/asm-x86/mm.h > +++ b/xen/include/asm-x86/mm.h > @@ -652,4 +652,12 @@ static inline bool arch_mfn_in_directmap(unsigned > long mfn) > return mfn <=3D (virt_to_mfn(eva - 1) + 1); > } >=20 > +static inline > +int arch_get_unallocated_space(struct domain *d, > + struct xen_unallocated_region *regions, > + unsigned int *nr_regions) > +{ > + return -EOPNOTSUPP; > +} > + > #endif /* __ASM_X86_MM_H__ */ > diff --git a/xen/include/public/memory.h b/xen/include/public/memory.h > index 383a946..040201b 100644 > --- a/xen/include/public/memory.h > +++ b/xen/include/public/memory.h > @@ -739,7 +739,42 @@ struct xen_vnuma_topology_info { > typedef struct xen_vnuma_topology_info xen_vnuma_topology_info_t; > DEFINE_XEN_GUEST_HANDLE(xen_vnuma_topology_info_t); >=20 > -/* Next available subop number is 29 */ > +/* > + * Get the unallocated space (regions of guest physical address space wh= ich > + * are unused) and can be used to create grant/foreign mappings. > + */ > +#define XENMEM_get_unallocated_space 29 > +struct xen_unallocated_region { > + xen_pfn_t start_gpfn; > + xen_ulong_t nr_gpfns; > +}; > +typedef struct xen_unallocated_region xen_unallocated_region_t; > +DEFINE_XEN_GUEST_HANDLE(xen_unallocated_region_t); > + > +#define XEN_MAX_UNALLOCATED_REGIONS 32 > + > +struct xen_get_unallocated_space { > + /* IN - Which domain to provide unallocated space for */ > + domid_t domid; > + > + /* > + * IN/OUT - As an IN parameter number of memory regions which > + * can be written to the buffer (maximum size of the array) > + * As OUT parameter number of memory regions which > + * have been written to the buffer > + */ > + unsigned int nr_regions; > + > + /* > + * OUT - An array of memory regions, the regions must be placed in > + * ascending order, there must be no overlap between them. > + */ > + XEN_GUEST_HANDLE(xen_unallocated_region_t) buffer; > +}; > +typedef struct xen_get_unallocated_space xen_get_unallocated_space_t; > +DEFINE_XEN_GUEST_HANDLE(xen_get_unallocated_space_t); > + > +/* Next available subop number is 30 */ >=20 > #endif /* __XEN_PUBLIC_MEMORY_H__ */ >=20 > diff --git a/xen/include/xsm/dummy.h b/xen/include/xsm/dummy.h > index 363c6d7..2761fbd 100644 > --- a/xen/include/xsm/dummy.h > +++ b/xen/include/xsm/dummy.h > @@ -772,3 +772,9 @@ static XSM_INLINE int > xsm_domain_resource_map(XSM_DEFAULT_ARG struct domain *d) > XSM_ASSERT_ACTION(XSM_DM_PRIV); > return xsm_default_action(action, current->domain, d); > } > + > +static XSM_INLINE int xsm_get_unallocated_space(XSM_DEFAULT_ARG > struct domain *d) > +{ > + XSM_ASSERT_ACTION(XSM_HOOK); > + return xsm_default_action(action, current->domain, d); > +} > diff --git a/xen/include/xsm/xsm.h b/xen/include/xsm/xsm.h > index ad3cddb..b01619c 100644 > --- a/xen/include/xsm/xsm.h > +++ b/xen/include/xsm/xsm.h > @@ -180,6 +180,7 @@ struct xsm_operations { > int (*dm_op) (struct domain *d); > int (*xen_version) (uint32_t cmd); > int (*domain_resource_map) (struct domain *d); > + int (*get_unallocated_space) (struct domain *d); > #ifdef CONFIG_ARGO > int (*argo_enable) (const struct domain *d); > int (*argo_register_single_source) (const struct domain *d, > @@ -701,6 +702,11 @@ static inline int > xsm_domain_resource_map(xsm_default_t def, struct domain *d) > return xsm_ops->domain_resource_map(d); > } >=20 > +static inline int xsm_get_unallocated_space(xsm_default_t def, struct > domain *d) > +{ > + return xsm_ops->get_unallocated_space(d); > +} > + > #ifdef CONFIG_ARGO > static inline int xsm_argo_enable(const struct domain *d) > { > diff --git a/xen/xsm/dummy.c b/xen/xsm/dummy.c > index de44b10..45efadb 100644 > --- a/xen/xsm/dummy.c > +++ b/xen/xsm/dummy.c > @@ -151,6 +151,7 @@ void __init xsm_fixup_ops (struct xsm_operations > *ops) > set_to_dummy_if_null(ops, dm_op); > set_to_dummy_if_null(ops, xen_version); > set_to_dummy_if_null(ops, domain_resource_map); > + set_to_dummy_if_null(ops, get_unallocated_space); > #ifdef CONFIG_ARGO > set_to_dummy_if_null(ops, argo_enable); > set_to_dummy_if_null(ops, argo_register_single_source); > diff --git a/xen/xsm/flask/hooks.c b/xen/xsm/flask/hooks.c > index f1a1217..38a9b20 100644 > --- a/xen/xsm/flask/hooks.c > +++ b/xen/xsm/flask/hooks.c > @@ -1715,6 +1715,11 @@ static int flask_domain_resource_map(struct > domain *d) > return current_has_perm(d, SECCLASS_DOMAIN2, > DOMAIN2__RESOURCE_MAP); > } >=20 > +static int flask_get_unallocated_space(struct domain *d) > +{ > + return current_has_perm(d, SECCLASS_DOMAIN2, > DOMAIN2__GET_UNALLOCATED_SPACE); > +} > + > #ifdef CONFIG_ARGO > static int flask_argo_enable(const struct domain *d) > { > @@ -1875,6 +1880,7 @@ static struct xsm_operations flask_ops =3D { > .dm_op =3D flask_dm_op, > .xen_version =3D flask_xen_version, > .domain_resource_map =3D flask_domain_resource_map, > + .get_unallocated_space =3D flask_get_unallocated_space, > #ifdef CONFIG_ARGO > .argo_enable =3D flask_argo_enable, > .argo_register_single_source =3D flask_argo_register_single_source, > diff --git a/xen/xsm/flask/policy/access_vectors > b/xen/xsm/flask/policy/access_vectors > index 6359c7f..3cbdc19 100644 > --- a/xen/xsm/flask/policy/access_vectors > +++ b/xen/xsm/flask/policy/access_vectors > @@ -245,6 +245,8 @@ class domain2 > resource_map > # XEN_DOMCTL_get_cpu_policy > get_cpu_policy > +# XENMEM_get_unallocated_space > + get_unallocated_space > } >=20 > # Similar to class domain, but primarily contains domctls related to HVM > domains > -- > 2.7.4 >=20 From xen-devel-bounces@lists.xenproject.org Tue Sep 07 09:05:24 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 09:05:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180663.327402 (Exim 4.92) (envelope-from ) id 1mNX2d-0005Wl-RM; Tue, 07 Sep 2021 09:05:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180663.327402; Tue, 07 Sep 2021 09:05:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNX2d-0005We-Nq; Tue, 07 Sep 2021 09:05:19 +0000 Received: by outflank-mailman (input) for mailman id 180663; Tue, 07 Sep 2021 09:05:18 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNX2c-0005WY-QM for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 09:05:18 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNX2b-00005T-PO; Tue, 07 Sep 2021 09:05:17 +0000 Received: from [54.239.6.187] (helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1mNX2b-0004Qi-Eu; Tue, 07 Sep 2021 09:05:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=o9uZx/FtwTATu6iK2Vt8bQFkyHvBw8HnDgDM6Gd6PC0=; b=T6r3AcXHqiT1ZEsFp6ljuOmC43 Kk/cA7SpQCm0UrvFCRIWFB68miptBD4zmrLgkFZYciCMpnEAJn5sVRlMRdI3g4jq/V34ftAe0AxOG bZ2dx2nM9JBxxUG0yyoeELg3U7KZO90h4mTjFPpBK88DS+kt89E7ybntIOTcWmXj5gzk=; Subject: Re: [PATCH v1 05/14] xen/arm: PCI host bridge discovery within XEN on ARM To: Rahul Singh , xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, Stefano Stabellini , Volodymyr Babchuk References: <412b6574170d96d6fc4196fab4bb2b9286a770c8.1629366665.git.rahul.singh@arm.com> From: Julien Grall Message-ID: <1f4a0284-302e-47e9-6958-47dca449d580@xen.org> Date: Tue, 7 Sep 2021 10:05:15 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <412b6574170d96d6fc4196fab4bb2b9286a770c8.1629366665.git.rahul.singh@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit Hi Rahul, On 19/08/2021 13:02, Rahul Singh wrote: > XEN during boot will read the PCI device tree node “reg” property > and will map the PCI config space to the XEN memory. > > As of now "pci-host-ecam-generic" compatible board is supported. I think the word "only" is missing. > > "linux,pci-domain" device tree property assigns a fixed PCI domain > number to a host bridge, otherwise an unstable (across boots) unique > number will be assigned by Linux.This property has to be in sync with Typo: missing space after the '.' > XEN to access the PCI devices. I would expand a little bit the last sentence to explain why the need to be sync-ed. > > XEN will read the “linux,pci-domain” property from the device tree node > and configure the host bridge segment number accordingly. If this > property is not available XEN will allocate the unique segment number > to the host bridge. > > dt_get_pci_domain_nr(..) and dt_pci_bus_find_domain_nr(..) are directly > imported from the Linux source tree. What was the Linux commit used? I also read "directly imported" as a verbartim copy but AFAICT the implementation has been slightly reworked. > > Signed-off-by: Rahul Singh > --- > xen/arch/arm/pci/Makefile | 2 + > xen/arch/arm/pci/pci-host-common.c | 261 ++++++++++++++++++++++++++++ > xen/arch/arm/pci/pci-host-generic.c | 55 ++++++ > xen/include/asm-arm/pci.h | 28 +++ > 4 files changed, 346 insertions(+) > create mode 100644 xen/arch/arm/pci/pci-host-common.c > create mode 100644 xen/arch/arm/pci/pci-host-generic.c > > diff --git a/xen/arch/arm/pci/Makefile b/xen/arch/arm/pci/Makefile > index a9ee0b9b44..f3d97f859e 100644 > --- a/xen/arch/arm/pci/Makefile > +++ b/xen/arch/arm/pci/Makefile > @@ -1,2 +1,4 @@ > obj-y += pci.o > obj-y += pci-access.o > +obj-y += pci-host-generic.o > +obj-y += pci-host-common.o > diff --git a/xen/arch/arm/pci/pci-host-common.c b/xen/arch/arm/pci/pci-host-common.c > new file mode 100644 > index 0000000000..9dd9b02271 > --- /dev/null > +++ b/xen/arch/arm/pci/pci-host-common.c > @@ -0,0 +1,261 @@ > +/* > + * Copyright (C) 2021 Arm Ltd. > + * > + * Based on Linux drivers/pci/ecam.c > + * Copyright 2016 Broadcom. > + * > + * Based on Linux drivers/pci/controller/pci-host-common.c > + * Based on Linux drivers/pci/controller/pci-host-generic.c > + * Copyright (C) 2014 ARM Limited Will Deacon > + * > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License version 2 as > + * published by the Free Software Foundation. > + * > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + * > + * You should have received a copy of the GNU General Public License > + * along with this program. If not, see . > + */ > + > +#include > +#include > +#include AFAICT, already includes . So this looks unneccessary. > +#include > +#include > +#include > + > +/* > + * List for all the pci host bridges. > + */ > + > +static LIST_HEAD(pci_host_bridges); > + > +static atomic_t domain_nr = ATOMIC_INIT(-1); > + > +bool dt_pci_parse_bus_range(struct dt_device_node *dev, > + struct pci_config_window *cfg) Aside, "pci_config_window", the function is not Arm specific. Would it be possible to consider to introduce "struct resource" in Xen so this function can be moved in common/device_tree.c? > +{ > + const __be32 *cells; > + uint32_t len; > + > + cells = dt_get_property(dev, "bus-range", &len); > + /* bus-range should at least be 2 cells */ > + if ( !cells || (len < (sizeof(*cells) * 2)) ) > + return false; How about introducing dt_property_read_u32_array()? > + > + cfg->busn_start = dt_next_cell(1, &cells); > + cfg->busn_end = dt_next_cell(1, &cells); > + > + return true; > +} > + > +static inline void __iomem *pci_remap_cfgspace(paddr_t start, size_t len) > +{ > + return ioremap_nocache(start, len); > +} > + > +static void pci_ecam_free(struct pci_config_window *cfg) > +{ > + if ( cfg->win ) > + iounmap(cfg->win); > + > + xfree(cfg); > +} > + > +static struct pci_config_window *gen_pci_init(struct dt_device_node *dev, > + int ecam_reg_idx) > +{ > + int err; > + struct pci_config_window *cfg; > + paddr_t addr, size; > + > + cfg = xzalloc(struct pci_config_window); > + if ( !cfg ) > + return NULL; > + > + err = dt_pci_parse_bus_range(dev, cfg); > + if ( !err ) { > + cfg->busn_start = 0; > + cfg->busn_end = 0xff; > + printk(XENLOG_ERR "%s:No bus range found for pci controller\n", Typo: Missing space after ':'. > + dt_node_full_name(dev)); > + } else { > + if ( cfg->busn_end > cfg->busn_start + 0xff ) > + cfg->busn_end = cfg->busn_start + 0xff; > + } > + > + /* Parse our PCI ecam register address*/ > + err = dt_device_get_address(dev, ecam_reg_idx, &addr, &size); > + if ( err ) > + goto err_exit; > + > + cfg->phys_addr = addr; > + cfg->size = size; > + > + /* > + * On 64-bit systems, we do a single ioremap for the whole config space > + * since we have enough virtual address range available. On 32-bit, we In Xen on Arm64, the VMAP is actually only 1GB. So it is not that big and this will compete with other mapping like ITS, global domain mapping... So I think the vMAP area will need to increase to cater to increase usage. > + * ioremap the config space for each bus individually. > + * > + * As of now only 64-bit is supported 32-bit is not supported. > + */ > + cfg->win = pci_remap_cfgspace(cfg->phys_addr, cfg->size); > + if ( !cfg->win ) > + goto err_exit_remap; > + > + printk("ECAM at [mem %lx-%lx] for [bus %x-%x] \n",cfg->phys_addr, The physical address is a paddr_t. So this needs to use PRIpaddr. Also, please use preprent hexadecimal with 0x. This makes a lot easier to differentiate hexa vs decimal in the log. > + cfg->phys_addr + cfg->size - 1, cfg->busn_start, cfg->busn_end); > + > + return cfg; > + > +err_exit_remap: > + printk(XENLOG_ERR "ECAM ioremap failed\n"); > +err_exit: > + pci_ecam_free(cfg); Coding style: Please add a new line before return. > + return NULL; > +} > + > +struct pci_host_bridge *pci_alloc_host_bridge(void) > +{ > + struct pci_host_bridge *bridge = xzalloc(struct pci_host_bridge); > + > + if ( !bridge ) > + return NULL; > + > + INIT_LIST_HEAD(&bridge->node); > + bridge->bus_start = ~0; > + bridge->bus_end = ~0; Coding style: Please add a new line before return. > + return bridge; > +} > + > +void pci_add_host_bridge(struct pci_host_bridge *bridge) > +{ > + list_add_tail(&bridge->node, &pci_host_bridges); > +} > + > +static int pci_get_new_domain_nr(void) > +{ > + return atomic_inc_return(&domain_nr); > +} > + > +/* > + * This function will try to obtain the host bridge domain number by > + * finding a property called "linux,pci-domain" of the given device node. > + * > + * @node: device tree node with the domain information > + * > + * Returns the associated domain number from DT in the range [0-0xffff], or > + * a negative value if the required property is not found. > + */ > +static int dt_get_pci_domain_nr(struct dt_device_node *node) Nothing looks Arm specific for this function. Can you move it in device_tree.c? > +{ > + u32 domain; > + int error; > + > + error = dt_property_read_u32(node, "linux,pci-domain", &domain); > + if ( !error ) > + return -EINVAL; > + > + return (u16)domain; > +} > + > +static int pci_bus_find_domain_nr(struct dt_device_node *dev) > +{ > + static int use_dt_domains = -1; > + int domain; > + > + domain = dt_get_pci_domain_nr(dev); > + > + /* > + * Check DT domain and use_dt_domains values. > + * > + * If DT domain property is valid (domain >= 0) and > + * use_dt_domains != 0, the DT assignment is valid since this means > + * we have not previously allocated a domain number by using > + * pci_get_new_domain_nr(); we should also update use_dt_domains to > + * 1, to indicate that we have just assigned a domain number from > + * DT. > + * > + * If DT domain property value is not valid (ie domain < 0), and we > + * have not previously assigned a domain number from DT > + * (use_dt_domains != 1) we should assign a domain number by > + * using the: > + * > + * pci_get_new_domain_nr() > + * > + * API and update the use_dt_domains value to keep track of method we > + * are using to assign domain numbers (use_dt_domains = 0). > + * > + * All other combinations imply we have a platform that is trying > + * to mix domain numbers obtained from DT and pci_get_new_domain_nr(), > + * which is a recipe for domain mishandling and it is prevented by > + * invalidating the domain value (domain = -1) and printing a > + * corresponding error. > + */ > + if ( domain >= 0 && use_dt_domains ) > + { > + use_dt_domains = 1; > + } > + else if ( domain < 0 && use_dt_domains != 1 ) > + { > + use_dt_domains = 0; > + domain = pci_get_new_domain_nr(); > + } > + else > + { > + printk(XENLOG_ERR "Inconsistent \"linux,pci-domain\" property in DT\n"); > + BUG(); I don't think pci_bus_find_domain_nr() should be the function that crashes Xen. Instead, this should be propagated to the highest possible callers and let it decide what to do. > + } > + > + return domain; > +} > + > +int pci_host_common_probe(struct dt_device_node *dev, > + int ecam_reg_idx) > +{ > + struct pci_host_bridge *bridge; > + struct pci_config_window *cfg; > + int err; > + > + bridge = pci_alloc_host_bridge(); > + if ( !bridge ) > + return -ENOMEM; > + > + /* Parse and map our Configuration Space windows */ > + cfg = gen_pci_init(dev, ecam_reg_idx); > + if ( !cfg ) > + { > + err = -ENOMEM; > + goto err_exit; > + } > + > + bridge->dt_node = dev; > + bridge->sysdata = cfg; > + bridge->bus_start = cfg->busn_start; > + bridge->bus_end = cfg->busn_end; > + > + bridge->segment = pci_bus_find_domain_nr(dev); > + > + pci_add_host_bridge(bridge); > + > + return 0; > + > +err_exit: > + xfree(bridge); > + return err; > +} > + > +/* > + * Local variables: > + * mode: C > + * c-file-style: "BSD" > + * c-basic-offset: 4 > + * tab-width: 4 > + * indent-tabs-mode: nil > + * End: > + */ > diff --git a/xen/arch/arm/pci/pci-host-generic.c b/xen/arch/arm/pci/pci-host-generic.c > new file mode 100644 > index 0000000000..13d0f7f999 > --- /dev/null > +++ b/xen/arch/arm/pci/pci-host-generic.c > @@ -0,0 +1,55 @@ > +/* > + * Copyright (C) 2021 Arm Ltd. > + * > + * Based on Linux drivers/pci/controller/pci-host-common.c > + * Based on Linux drivers/pci/controller/pci-host-generic.c > + * Copyright (C) 2014 ARM Limited Will Deacon > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License version 2 as > + * published by the Free Software Foundation. > + * > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + * > + * You should have received a copy of the GNU General Public License > + * along with this program. If not, see . > + */ > + > +#include > +#include > +#include > + > +static const struct dt_device_match gen_pci_dt_match[] = { > + { .compatible = "pci-host-ecam-generic" }, > + { }, > +}; > + > +static int gen_pci_dt_init(struct dt_device_node *dev, const void *data) > +{ > + const struct dt_device_match *of_id; > + > + of_id = dt_match_node(gen_pci_dt_match, dev->dev.of_node); This seems to be a bit pointless to me as you already know the compatible (there is only one possible...). > + > + printk(XENLOG_INFO "Found PCI host bridge %s compatible:%s \n", > + dt_node_full_name(dev), of_id->compatible); > + > + return pci_host_common_probe(dev, 0); > +} > + > +DT_DEVICE_START(pci_gen, "PCI HOST GENERIC", DEVICE_PCI) > +.dt_match = gen_pci_dt_match, > +.init = gen_pci_dt_init, > +DT_DEVICE_END > + > +/* > + * Local variables: > + * mode: C > + * c-file-style: "BSD" > + * c-basic-offset: 4 > + * tab-width: 4 > + * indent-tabs-mode: nil > + * End: > + */ > diff --git a/xen/include/asm-arm/pci.h b/xen/include/asm-arm/pci.h > index 61e43da088..58a51e724e 100644 > --- a/xen/include/asm-arm/pci.h > +++ b/xen/include/asm-arm/pci.h > @@ -26,6 +26,34 @@ struct arch_pci_dev { > struct device dev; > }; > > +/* > + * struct to hold the mappings of a config space window. This > + * is expected to be used as sysdata for PCI controllers that > + * use ECAM. > + */ > +struct pci_config_window { > + paddr_t phys_addr; > + paddr_t size; > + uint8_t busn_start; > + uint8_t busn_end; > + void __iomem *win; > +}; > + > +/* > + * struct to hold pci host bridge information > + * for a PCI controller. > + */ > +struct pci_host_bridge { > + struct dt_device_node *dt_node; /* Pointer to the associated DT node */ > + struct list_head node; /* Node in list of host bridges */ > + uint16_t segment; /* Segment number */ > + u8 bus_start; /* Bus start of this bridge. */ > + u8 bus_end; /* Bus end of this bridge. */ Please use uint8_t rather than u8. > + void *sysdata; /* Pointer to the config space window*/ > +}; > + > +int pci_host_common_probe(struct dt_device_node *dev, > + int ecam_reg_idx); > #else /*!CONFIG_HAS_PCI*/ > > struct arch_pci_dev { }; > Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Sep 07 09:07:44 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 09:07:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180670.327413 (Exim 4.92) (envelope-from ) id 1mNX4x-0006Dl-Dh; Tue, 07 Sep 2021 09:07:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180670.327413; Tue, 07 Sep 2021 09:07:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNX4x-0006De-9Z; Tue, 07 Sep 2021 09:07:43 +0000 Received: by outflank-mailman (input) for mailman id 180670; Tue, 07 Sep 2021 09:07:41 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNX4v-0006DW-Cn for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 09:07:41 +0000 Received: from mx0a-0039f301.pphosted.com (unknown [148.163.133.242]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 0a95279b-1286-4476-a61b-23b964065993; Tue, 07 Sep 2021 09:07:40 +0000 (UTC) Received: from pps.filterd (m0174678.ppops.net [127.0.0.1]) by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 1877hNKW015205; Tue, 7 Sep 2021 09:07:36 GMT Received: from eur02-he1-obe.outbound.protection.outlook.com (mail-he1eur02lp2057.outbound.protection.outlook.com [104.47.5.57]) by mx0a-0039f301.pphosted.com with ESMTP id 3awwwf94hj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 07 Sep 2021 09:07:36 +0000 Received: from AM7PR03MB6325.eurprd03.prod.outlook.com (2603:10a6:20b:13c::18) by AS8PR03MB6982.eurprd03.prod.outlook.com (2603:10a6:20b:290::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.22; Tue, 7 Sep 2021 09:07:27 +0000 Received: from AM7PR03MB6325.eurprd03.prod.outlook.com ([fe80::d9b7:c0ab:2c2f:5b44]) by AM7PR03MB6325.eurprd03.prod.outlook.com ([fe80::d9b7:c0ab:2c2f:5b44%3]) with mapi id 15.20.4478.025; Tue, 7 Sep 2021 09:07:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0a95279b-1286-4476-a61b-23b964065993 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=f+ta1QLp89UHIR9J/cwaHW0np4ecTqJ4FmG/2+AAujQ2YteC6/Frx0oEQIH4103DAQWCSKTGpg83FOa4Y+eHBmel26nkFoVuLQPyp+yTyit6g1+u1ZFco/ClGoI51SakDu/LYnRogjibxvy+lcjdj/YRYdAMY2BW1+wJNlCrhcBUHyznVCZo80JHBuAtSO/M1U6hqZqmpmKj4Tfsu/dhmlVZL1NfGFNkhZ2KSXvSxhqyz+TFfVlpyZUL6SaXVraieFXxIxk2ZTN4bdbt7XU5dcpvnybr3uPGN4dZU+Zw+2AAP4rPyfJ2OhHFlmr/E31Dsbk4JE2AJ7aQpN+jgaD0NQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=iU06uG9UQghA0xEp3Kzkgh9kVYDqeW2pkTfpg5vmOdM=; b=eL3KyX+GJhjuPeIG96P/qSrdMTxvxsQ6grnVshpgnAjyNeqWYj+egtBO7AexJCKhMvpUws2rW4hLAN6KnR0kJbSFhjcXEilq9kwRorisKULGBvvFUhwZE1AOnD3ibm8pLQelAyilOhL9H9UIfASmNlYOe+WOfwnpM1gBKdZFD0vOyOXKmY+q1Km2GvqRafZjJ2RRvaIXr7yDhpNp9gtlPqhfr57bIHTdnhxMfX/UFSRbgRc0SloAdsU65Gazp5iDBAXncLGhPm+qOZzsl73mHL2q6kbAs6o6BDMWK/NNtw82BvTLewVEvINcpSVlXO3jbdRBVP0QGKv/6QbtLio6qA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iU06uG9UQghA0xEp3Kzkgh9kVYDqeW2pkTfpg5vmOdM=; b=yRDwwYuhb8aPYAHqWR4lpaCDun7U7me78zYKjU8giykZZeH/bCC5Fp5Bvu+LsszkRGjrmu/8ebFsYyEPJRY6MS4vO4tJeMCvR6M0VVtfAzohEpCj9ox6rYuCuzlmkffsjk8/DBHEfUTVWGv/6m1LJETFOf/jZq23lHPolFWbxBj7JuIRcMcPzRjYfKEB97zcCF1ruO/qSrskiaLq6Y0AYiMHvm6cILCQ5JxTw8MDmXqIuCk1N9OsB18xrIljvfcdvPL+wVwTpmDGTE05/7+zmTcvpZmR0s3DWn5xGcqk5hf64H6zLXFYGtDsJSkZQ4ppk7cL7iq4e3wZDweD1qtDcw== From: Oleksandr Andrushchenko To: Jan Beulich , Oleksandr Andrushchenko CC: "julien@xen.org" , "sstabellini@kernel.org" , Oleksandr Tyshchenko , Volodymyr Babchuk , Artem Mygaiev , "roger.pau@citrix.com" , Bertrand Marquis , Rahul Singh , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH 8/9] vpci/header: Reset the command register when adding devices Thread-Topic: [PATCH 8/9] vpci/header: Reset the command register when adding devices Thread-Index: AQHXoKxjFI8WSqpeJkWkpzZfft/zi6uXHR6AgAEZm4CAAASsgIAABSgAgAAIrgCAAAT5AA== Date: Tue, 7 Sep 2021 09:07:27 +0000 Message-ID: <5d0d345d-db16-f0c5-9a78-4ad5f4733886@epam.com> References: <20210903100831.177748-1-andr2000@gmail.com> <20210903100831.177748-9-andr2000@gmail.com> <5366265c-d169-041d-f812-1c49260f6499@epam.com> <8f1816db-798b-15d9-7343-2199eb8f39e0@suse.com> <0e3942a5-9105-c99e-f15e-dcf35aae142a@epam.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=epam.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 92bba6b3-6a9c-491e-e1b7-08d971deea26 x-ms-traffictypediagnostic: AS8PR03MB6982: x-ms-exchange-transport-forked: True x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: CLqJcsRE6v6umDppl37yYDWl3klabIMmmbDDF/+Wxd5fGGlVe3zaAamXHl6P+dHPY7gWDLjqr7wV2lbaFNvkL/riiDyHvb7XdtYDiSzcCZNoJ259/F9QlflOvdJRIn2djFC/T9kGixgbE/P9bKzsnjWR6A25bjL5eqVIiZ0nJecWuTghtBrurU8IBYWgYIzQ41IQn5knDMW/ZgJGZmf82BYmZiOJ2GJLWXo2fJkc61RcfzcaGb17X86gbEmHiaXK35/nv8POAO2UlXPeVRcRp3NgZV6A9WGiA8kpmN7mwJS45+0N07fpwzePE9WWRInZpsvg4ElbWGA1GNAi/zSDb90vY4jEv8PEEoR5crJCbDXPgAEacSKC5MyH/vGe8E8poFoIy4/HdfXrI9oxExZDzXTFnyo6Pe0r426JWvA10cf8X614tH0Zs2nE/ldCmZySiiI+ZhpvLf/aTY4mOyGrsnDSjMdJqHAjRGt9nzXlt6bo/blt4wWYhE3DHwe7DHu6RDtGKiiqRLO25ETxkgLhgzvz1wpW3geGYL1shYqlCbIDdna2EFjrW9dOJEMmK0mowVwyXULdjSsv+0tgSBRvwqvt7YDDkvrml00/u3BNNIZtaT6nVWL9XeNSW1hn0ODhqL3JugGFTcdUAPOhbxRYtLI2hx8vAxAIPwskHR1l96uwub/THpw/rx83QJ7nu/eKnU2TLcKBB0WYt/6bLOJ+iwrW5/oShWyxQDjB5bZYZnh67tGRW7ack4+SSNVwi9eD x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM7PR03MB6325.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(396003)(136003)(39860400002)(376002)(346002)(8936002)(2616005)(66556008)(66446008)(66476007)(8676002)(66946007)(26005)(36756003)(64756008)(316002)(2906002)(4326008)(6486002)(76116006)(71200400001)(91956017)(31686004)(53546011)(110136005)(54906003)(122000001)(5660300002)(478600001)(38100700002)(186003)(6512007)(38070700005)(86362001)(83380400001)(31696002)(6506007)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?UExGMWdDeE1VTld2RHhzOGVvRjlHRkVDVVp0U3FlcFhTUzI5UWtJNW5TdDNn?= =?utf-8?B?VWcyRkR5NmJodHdtdGk0YVFGSXM0T0J1MG5iMzVmYTNkQmc2d0dRYXpwK1pB?= =?utf-8?B?UjYvZDNpSi9LYXgxNCtNaTdpL2pERnZKYzZIa0Y4WHNzSHBGVGdjNGt1WXJP?= =?utf-8?B?N205eDYzVnFkTmNSOEhQSlN1UXR2RzFXYzVGeTlvSkpWcWZXY2ZJWW92T0lo?= =?utf-8?B?Q29MZ25iRHdtTitGUHhSMjJIK1FCWjhwWFV5QjlJZFJwSVp3ODEydG5NL2JK?= =?utf-8?B?RzMzRzZwYmUyY3lkRkx4MW9nTUYrNzJ6aFVHOGRORHh2bkhxWFdLT2E2R3d5?= =?utf-8?B?SE00RzRUSUJqOWtJRzNvSWFGTTA0QmxGdmk2NEl0Nmt5bEVROXpGakszVGUw?= =?utf-8?B?ZityTW00dTN4OXRuY2wrTVFERFI1R1VodFFkNDRGc240UVJxVkpJN290TGVG?= =?utf-8?B?Sk5NU1pCcDF5cWI1aGFTTHd1MlpGck1DY1ZNN0ZzamZVcTNCTUJORU1aSWpB?= =?utf-8?B?YTVKOW03dzRDNk0wcWMwdS9SSzA3TXZPVCtTUk5uMFh6Y3Z3cTVnNnB3WGNt?= =?utf-8?B?Y3pqdUxSQkcwQmVNcVBSRlFYQUY5aDc2SDNuaVVzT1hzK2NvbHVJNkNQRm4r?= =?utf-8?B?dEFOZmZwY0ZTMGVRVitkeFVPMTNxVXRrRHEvRXBkb1ZMckFWT0dBeE5PMkk3?= =?utf-8?B?TVhhamVIbzZTOHVVUjJRbFl3RFNWYzZiTWlCQTVocjB5VFNFSzdTUXp4cVlC?= =?utf-8?B?azdrZzBKU1IxT2hJSkNZZGJqeGpwZDlXZTJXaGNFL3QrUHZXNi9xeStlVzZW?= =?utf-8?B?RTBJTm02Rkh4S3lQSHBSVldqQ2dRUmxhKzB0SzVkNUI3c21wNU1mbFJhdjM1?= =?utf-8?B?NUJYTWJOVUUrMzVtMTFkYmZtYVQxZUlmOG1KdnRoSWZ1bldpTzdwY2xBNmRh?= =?utf-8?B?aFh3cXppUkR4b3dRSS9wbWVsN1RYUzRHMXBVWWw4ZStoTk1BOEpqdVdmRlhU?= =?utf-8?B?NVV2cDFzT3BWcjR2bG1GTFI2aTlHelhwcWtaUG8vbHJ6YW9acEdsR2Ztclhr?= =?utf-8?B?N0tON1Q4cFc3MEMyeGRDL3FBQTdkVllKdXpISlNrdVhrZDRFbE82NWpQdXVF?= =?utf-8?B?NHl5Z25PcHp2OXk0MlNjNmNIcENsTXFOdmxZQWQ4WnowTGtWR3RYMWRlaFg1?= =?utf-8?B?amxEWkZERjVyVWlzT3NKSjZWQjBKejZUVkJNbW9rSjhvemlpQ1FjQVFDSjF0?= =?utf-8?B?b0VMUWZyZVN6TkZYSWwyd2ZmRjlqNDFQd3RNMXB3VG5uYkEvRUdRV1A3VEk1?= =?utf-8?B?ZzJucktMWVBkYmVveE5KZlJPalBCcEhOOENTZW1zalVxTXpGSklJTXFFelBQ?= =?utf-8?B?ZzVPTkc0R3dvLzVseHhQeUNZNFF0MjMySS9IMnlZb0Vvdy9SYk1LNGI0WnJp?= =?utf-8?B?NEZsSFI0bVgyUDBkbE5CZ2pwRHhrbTVoemFiMlk5Q1Bodk1WSW1zNzBhVW00?= =?utf-8?B?VUZFcWFTeWliQkJoN25zRll5S2pMQVliUDY2bEx2RkViQUNwK2U0MS9lZ0tX?= =?utf-8?B?dlE4Z3VNNm9UK21mdnZvVHhyalBYVlhZcVVrbm5TTmFveVord01uUzc3aGdK?= =?utf-8?B?N0VxVXI4cG0vSUNhc24wOHg5VFhuejgzOUNpMDJEWk9yRDFxV3YzU3ZYNTgw?= =?utf-8?B?amIyeTd2bTFoZ2lCY0dUdG5aWU9WR1pTcjBXRklCS0ViOGlkdmFmb3AweHF1?= =?utf-8?Q?Q9pPfwWuiDm0Lk9DPtCvyyEIv6gJmtqxVa76iLF?= Content-Type: text/plain; charset="utf-8" Content-ID: <5294CDD42335214FA71A1334D7A6EDD8@eurprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: epam.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM7PR03MB6325.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 92bba6b3-6a9c-491e-e1b7-08d971deea26 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Sep 2021 09:07:27.3924 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: sWMAApXv0ofYfZSHYR7IdbA5Dr24P3Ssd/xx55njutynxSFuw13PnM9e16YiXhOJzbu2J2dvXHcllfkQMLKMxgzf96yrj/SeJEGKKeIpEzpEpJ+XFOM0Gy+PN4NvZoQw X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR03MB6982 X-Proofpoint-GUID: fHIcg41XHYZlkLIiiZ7b4H4uxl28MIOu X-Proofpoint-ORIG-GUID: fHIcg41XHYZlkLIiiZ7b4H4uxl28MIOu X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.391,FMLib:17.0.607.475 definitions=2021-09-07_03,2021-09-03_01,2020-04-07_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 suspectscore=0 bulkscore=0 phishscore=0 clxscore=1015 lowpriorityscore=0 malwarescore=0 spamscore=0 mlxscore=0 mlxlogscore=999 impostorscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2108310000 definitions=main-2109070060 DQpPbiAwNy4wOS4yMSAxMTo0OSwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDA3LjA5LjIwMjEg MTA6MTgsIE9sZWtzYW5kciBBbmRydXNoY2hlbmtvIHdyb3RlOg0KPj4gT24gMDcuMDkuMjEgMTE6 MDAsIEphbiBCZXVsaWNoIHdyb3RlOg0KPj4+IE9uIDA3LjA5LjIwMjEgMDk6NDMsIE9sZWtzYW5k ciBBbmRydXNoY2hlbmtvIHdyb3RlOg0KPj4+PiBPbiAwNi4wOS4yMSAxNzo1NSwgSmFuIEJldWxp Y2ggd3JvdGU6DQo+Pj4+PiBPbiAwMy4wOS4yMDIxIDEyOjA4LCBPbGVrc2FuZHIgQW5kcnVzaGNo ZW5rbyB3cm90ZToNCj4+Pj4+PiAtLS0gYS94ZW4vZHJpdmVycy92cGNpL2hlYWRlci5jDQo+Pj4+ Pj4gKysrIGIveGVuL2RyaXZlcnMvdnBjaS9oZWFkZXIuYw0KPj4+Pj4+IEBAIC04MTEsNiArODEx LDE2IEBAIGludCB2cGNpX2Jhcl9hZGRfaGFuZGxlcnMoY29uc3Qgc3RydWN0IGRvbWFpbiAqZCwg c3RydWN0IHBjaV9kZXYgKnBkZXYpDQo+Pj4+Pj4gICAgICAgICAgICAgZ3ByaW50ayhYRU5MT0df RVJSLA0KPj4+Pj4+ICAgICAgICAgICAgICAgICAiJXBwOiBmYWlsZWQgdG8gYWRkIEJBUiBoYW5k bGVycyBmb3IgZG9tJWRcbiIsICZwZGV2LT5zYmRmLA0KPj4+Pj4+ICAgICAgICAgICAgICAgICBk LT5kb21haW5faWQpOw0KPj4+Pj4+ICsNCj4+Pj4+PiArICAgIC8qDQo+Pj4+Pj4gKyAgICAgKiBS ZXNldCB0aGUgY29tbWFuZCByZWdpc3RlcjogaXQgaXMgcG9zc2libGUgdGhhdCB3aGVuIHBhc3Np bmcNCj4+Pj4+PiArICAgICAqIHRocm91Z2ggYSBQQ0kgZGV2aWNlIGl0cyBtZW1vcnkgZGVjb2Rp bmcgYml0cyBpbiB0aGUgY29tbWFuZA0KPj4+Pj4+ICsgICAgICogcmVnaXN0ZXIgYXJlIGFscmVh ZHkgc2V0LiBUaHVzLCBhIGd1ZXN0IE9TIG1heSBub3Qgd3JpdGUgdG8gdGhlDQo+Pj4+Pj4gKyAg ICAgKiBjb21tYW5kIHJlZ2lzdGVyIHRvIHVwZGF0ZSBtZW1vcnkgZGVjb2RpbmcsIHNvIGd1ZXN0 IG1hcHBpbmdzDQo+Pj4+Pj4gKyAgICAgKiAoZ3Vlc3QncyB2aWV3IG9mIHRoZSBCQVJzKSBhcmUg bGVmdCBub3QgdXBkYXRlZC4NCj4+Pj4+PiArICAgICAqLw0KPj4+Pj4+ICsgICAgcGNpX2NvbmZf d3JpdGUxNihwZGV2LT5zYmRmLCBQQ0lfQ09NTUFORCwgMCk7DQo+Pj4+PiBDYW4geW91IHJlYWxs eSBibGluZGx5IHdyaXRlIDAgaGVyZT8gV2hhdCBhYm91dCBiaXRzIHRoYXQgaGF2ZSB0byBiZQ0K Pj4+Pj4gdW5kZXIgaG9zdCBjb250cm9sLCBlLmcuIElOVFhfRElTQUJMRT8gSSBjYW4gc2VlIHRo YXQgeW91IG1heSB3YW50IHRvDQo+Pj4+PiBoYW5kIG9mZiB3aXRoIEkvTyBhbmQgbWVtb3J5IGRl Y29kaW5nIG9mZiBhbmQgYnVzIG1hc3RlcmluZyBkaXNhYmxlZCwNCj4+Pj4+IGJ1dCBmb3IgZXZl cnkgb3RoZXIgYml0IChpbmNsdWRpbmcgcmVzZXJ2ZWQgb25lcykgSSdkIGV4cGVjdCBzZXBhcmF0 ZQ0KPj4+Pj4ganVzdGlmaWNhdGlvbiAoaW4gdGhlIGNvbW1pdCBtZXNzYWdlKS4NCj4+Pj4gQWNj b3JkaW5nIHRvICJQQ0kgTE9DQUwgQlVTIFNQRUNJRklDQVRJT04sIFJFVi4gMy4wIiBJIGhhdmUg YXQgaGFuZCwNCj4+Pj4gc2VjdGlvbiAiNi4yLjIgRGV2aWNlIENvbnRyb2wiIHNheXMgdGhhdCB0 aGUgcmVzZXQgc3RhdGUgb2YgdGhlIGNvbW1hbmQNCj4+Pj4gcmVnaXN0ZXIgaXMgdHlwaWNhbGx5 IDAsIHNvIHRoaXMgaXMgd2h5IEkgY2hvc2UgdG8gd3JpdGUgMCBoZXJlLCBlLmcuDQo+Pj4+IG1h a2UgdGhlIGNvbW1hbmQgcmVnaXN0ZXIgYXMgaWYgaXQgaXMgYWZ0ZXIgdGhlIHJlc2V0Lg0KPj4+ Pg0KPj4+PiBXaXRoIHJlc3BlY3QgdG8gaG9zdCBjb250cm9sOiB3ZSBjdXJyZW50bHkgZG8gbm90 IHJlYWxseSBlbXVsYXRlIGNvbW1hbmQNCj4+Pj4gcmVnaXN0ZXIgd2hpY2ggcHJvYmFibHkgd2Fz IG9rIGZvciB4ODYgUFZIIERvbTAgYW5kIHRoaXMgbWlnaHQgbm90IGJlIHRoZQ0KPj4+PiBjYXNl IG5vdyBhcyB3ZSBhZGQgRG9tVSdzLiBUaGF0IGJlaW5nIHNhaWQ6IGluIG15IGltcGxlbWVudGF0 aW9uIGd1ZXN0IGNhbg0KPj4+PiBhbHRlciBjb21tYW5kIHJlZ2lzdGVyIGFzIGl0IHdhbnRzIHdp dGhvdXQgcmVzdHJpY3Rpb25zLg0KPj4+PiBJZiB3ZSBzZWUgaXQgZG9lcyBuZWVkIHByb3BlciBl bXVsYXRpb24gdGhlbiB3ZSB3b3VsZCBuZWVkIGFkZGluZyB0aGF0IGFzDQo+Pj4+IHdlbGwgKGlz IG5vdCBwYXJ0IG9mIHRoaXMgc2VyaWVzIHRob3VnaCkuDQo+Pj4+DQo+Pj4+IE1lYW53aGlsZSwg SSBhZ3JlZSB0aGF0IHdlIGNhbiBvbmx5IHJlc2V0IElPIHNwYWNlLCBtZW1vcnkgc3BhY2UgYW5k IGJ1cw0KPj4+PiBtYXN0ZXIgYml0cyBhbmQgbGVhdmUgdGhlIHJlc3QgdW50b3VjaGVkLiBCdXQg YWdhaW4sIHdpdGhvdXQgcHJvcGVyIGNvbW1hbmQNCj4+Pj4gcmVnaXN0ZXIgZW11bGF0aW9uIGd1 ZXN0cyBjYW4gc3RpbGwgc2V0IHdoYXQgdGhleSB3YW50Lg0KPj4+IFllcywgd3JpdGVzIHRvIHRo ZSByZWdpc3RlciB3aWxsIG5lZWQgZW11bGF0aW5nIGZvciBEb21VLg0KPj4gQnV0IHRoZW4gSSBh bSB3b25kZXJpbmcgdG8gd2hhdCBleHRlbnQgd2UgbmVlZCB0byBlbXVsYXRlIHRoZSBjb21tYW5k DQo+Pg0KPj4gcmVnaXN0ZXI/IFdlIGhhdmUgdGhlIGZvbGxvd2luZyBiaXRzIGluIHRoZSBjb21t YW5kIHJlZ2lzdGVyOg0KPj4NCj4+ICNkZWZpbmXCoCBQQ0lfQ09NTUFORF9JT8KgwqDCoCDCoMKg wqAgMHgxwqDCoMKgIC8qIEVuYWJsZSByZXNwb25zZSBpbiBJL08gc3BhY2UgKi8NCj4+ICNkZWZp bmXCoCBQQ0lfQ09NTUFORF9NRU1PUlnCoMKgwqAgMHgywqDCoMKgIC8qIEVuYWJsZSByZXNwb25z ZSBpbiBNZW1vcnkgc3BhY2UgKi8NCj4+ICNkZWZpbmXCoCBQQ0lfQ09NTUFORF9NQVNURVLCoMKg wqAgMHg0wqDCoMKgIC8qIEVuYWJsZSBidXMgbWFzdGVyaW5nICovDQo+PiAjZGVmaW5lwqAgUENJ X0NPTU1BTkRfU1BFQ0lBTMKgwqDCoCAweDjCoMKgwqAgLyogRW5hYmxlIHJlc3BvbnNlIHRvIHNw ZWNpYWwgY3ljbGVzICovDQo+PiAjZGVmaW5lwqAgUENJX0NPTU1BTkRfSU5WQUxJREFURcKgwqDC oCAweDEwwqDCoMKgIC8qIFVzZSBtZW1vcnkgd3JpdGUgYW5kIGludmFsaWRhdGUgKi8NCj4+ICNk ZWZpbmXCoCBQQ0lfQ09NTUFORF9WR0FfUEFMRVRURSAweDIwwqDCoMKgIC8qIEVuYWJsZSBwYWxl dHRlIHNub29waW5nICovDQo+PiAjZGVmaW5lwqAgUENJX0NPTU1BTkRfUEFSSVRZwqDCoMKgIDB4 NDDCoMKgwqAgLyogRW5hYmxlIHBhcml0eSBjaGVja2luZyAqLw0KPj4gI2RlZmluZcKgIFBDSV9D T01NQU5EX1dBSVQgwqDCoMKgIDB4ODDCoMKgwqAgLyogRW5hYmxlIGFkZHJlc3MvZGF0YSBzdGVw cGluZyAqLw0KPj4gI2RlZmluZcKgIFBDSV9DT01NQU5EX1NFUlLCoMKgwqAgMHgxMDDCoMKgwqAg LyogRW5hYmxlIFNFUlIgKi8NCj4+ICNkZWZpbmXCoCBQQ0lfQ09NTUFORF9GQVNUX0JBQ0vCoMKg wqAgMHgyMDDCoMKgwqAgLyogRW5hYmxlIGJhY2stdG8tYmFjayB3cml0ZXMgKi8NCj4+ICNkZWZp bmXCoCBQQ0lfQ09NTUFORF9JTlRYX0RJU0FCTEUgMHg0MDAgLyogSU5UeCBFbXVsYXRpb24gRGlz YWJsZSAqLw0KPj4NCj4+IFdlIHdhbnQgdGhlIGd1ZXN0IHRvIGFjY2VzcyBkaXJlY3RseSBhdCBs ZWFzdCBJL08gYW5kIG1lbW9yeSBkZWNvZGluZyBhbmQgYnVzIG1hc3RlcmluZw0KPj4gYml0cywg YnV0IGhvdyBkbyB3ZSBlbXVsYXRlIHRoZSByZXN0PyBEbyB5b3UgbWVhbiB3ZSBjYW4gbWF0Y2gg dGhlIHJlc3QgdG8gd2hhdCBob3N0DQo+PiB1c2VzIGZvciB0aGUgZGV2aWNlLCBsaWtlIFBDSV9D T01NQU5EX0lOVFhfRElTQUJMRSBiaXQ/IElmIHNvLCBhcyBwZXIgbXkgdW5kZXJzdGFuZGluZywN Cj4+IHRob3NlIGJpdHMgZ2V0IHNldC9jbGVhcmVkIHdoZW4gYSBkZXZpY2UgaXMgZW5hYmxlZCwg ZS5nLiBieSBMaW51eCBrZXJuZWwvZGV2aWNlIGRyaXZlciBmb3IgZXhhbXBsZS4NCj4gSSB3b3Vs ZCBzdWdnZXN0IHRvIHRha2UgcWVtdSdzIGVtdWxhdGlvbiBhcyBhIHN0YXJ0aW5nIHBvaW50Lg0K DQpTdXJlLCBJJ2xsIHRha2UgYSBsb29rIHdoYXQgUUVNVSBkb2VzLiBCdXQgSSBndWVzcyB0aGF0 IGVtdWxhdGlvbiBtYXkgZGVwZW5kDQoNCm9uIGhvc3QgYnJpZGdlIGVtdWxhdGlvbiBldGMuIHdo aWNoIG1heSBub3QgYmUgYXBwbGljYWJsZSBmb3Igb3VyIGNhc2Ugd2l0aG91dA0KDQpzZXJpb3Vz IGNvbXBsaWNhdGlvbnMuDQoNCj4NCj4+IFNvLCBpZiB3ZSBoYXZlIGEgaGlkZGVuIFBDSSBkZXZp Y2Ugd2hpY2ggY2FuIGJlIGFzc2lnbmVkIHRvIGEgZ3Vlc3QgYW5kIGl0IGlzIGxpdGVyYWxseSB1 bnRvdWNoZWQNCj4+IChub3QgZW5hYmxlZCBpbiBEb20wKSB0aGVuIEkgdGhpbmsgdGhlcmUgd2ls bCBiZSBubyBzdWNoIHJlZmVyZW5jZSBhcyAiaG9zdCBhc3NpZ25lZCB2YWx1ZXMiIGFzDQo+PiBt b3N0IHByb2JhYmx5IHRoZSBjb21tYW5kIHJlZ2lzdGVyIHdpbGwgcmVtYWluIGluIGl0cyBhZnRl ciByZXNldCBzdGF0ZS4NCj4gV2hhdCBtZWFuaW5nIG9mICJoaWRkZW4iIGRvIHlvdSBpbXBseSBo ZXJlPyBEZXZpY2VzIHBhc3NlZCB0bw0KPiBwY2lfe2hpZGUscm99X2RldmljZSgpIG1heSBub3Qg YmUgYXNzaWduZWQgdG8gZ3Vlc3RzIC4uLg0KWW91IGFyZSBjb21wbGV0ZWx5IHJpZ2h0IGhlcmUu DQo+DQo+IEZvciBhbnkgb3RoZXIgbWVhbmluZyBvZiAiaGlkZGVuIiwgZXZlbiBpZiB0aGUgZGV2 aWNlIGlzIGNvbXBsZXRlbHkNCj4gaWdub3JlZCBieSBEb20wLA0KDQpEb20wbGVzcyBpcyBzdWNo IGEgY2FzZSB3aGVuIGEgZGV2aWNlIGlzIGFzc2lnbmVkIHRvIHRoZSBndWVzdA0KDQp3aXRob3V0 IERvbTAgYXQgYWxsPw0KDQo+ICAgY2VydGFpbiBvZiB0aGUgcHJvcGVydGllcyBzdGlsbCBjYW5u b3QgYmUgYWxsb3dlZA0KPiB0byBiZSBEb21VLWNvbnRyb2xsZWQuDQoNClRoZSBsaXN0IGlzIG5v dCB0aGF0IGJpZywgY291bGQgeW91IHBsZWFzZSBuYW1lIGEgZmV3IHlvdSB0aGluayBjYW5ub3QN Cg0KYmUgY29udHJvbGxlZCBieSBhIGd1ZXN0PyBJIGNhbiB0aGluayBvZiBQQ0lfQ09NTUFORF9T UEVDSUFMKD8pLA0KDQpQQ0lfQ09NTUFORF9JTlZBTElEQVRFKD8pLCBQQ0lfQ09NTUFORF9QQVJJ VFksIFBDSV9DT01NQU5EX1dBSVQsDQoNClBDSV9DT01NQU5EX1NFUlIsIFBDSV9DT01NQU5EX0lO VFhfRElTQUJMRSB3aGljaCB3ZSBtYXkgd2FudCB0bw0KDQpiZSBhbGlnbmVkIHdpdGggdGhlICJo b3N0IHJlZmVyZW5jZSIgdmFsdWVzLCBlLmcuIHdlIG9ubHkgYWxsb3cgdGhvc2UgYml0cw0KDQp0 byBiZSBzZXQgYXMgdGhleSBhcmUgaW4gRG9tMC4NCg0KPiAgIChJJ20gdGhlcmVmb3JlIG5vdCBz dXJlIGluIGhvdyBmYXIgRG9tMCBjYW4NCj4gYWN0dWFsbHkgbGVnaXRpbWF0ZWx5ICJpZ25vcmUi IGRldmljZXMuIEl0IG1heSBkZWNpZGUgdG8gbm90IGVuYWJsZQ0KPiB0aGVtLCBidXQgdGhhdCdz IG5vdCAiaWdub3JpbmciLikNCj4NCj4gSmFuDQo+DQpUaGFuayB5b3UsDQoNCk9sZWtzYW5kcg0K From xen-devel-bounces@lists.xenproject.org Tue Sep 07 09:18:00 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 09:18:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180679.327424 (Exim 4.92) (envelope-from ) id 1mNXEp-0007wb-Bz; Tue, 07 Sep 2021 09:17:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180679.327424; Tue, 07 Sep 2021 09:17:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNXEp-0007wU-98; Tue, 07 Sep 2021 09:17:55 +0000 Received: by outflank-mailman (input) for mailman id 180679; Tue, 07 Sep 2021 09:17:53 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNXEn-0007wO-Qd for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 09:17:53 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNXEn-0000JL-0s; Tue, 07 Sep 2021 09:17:53 +0000 Received: from [54.239.6.187] (helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1mNXEm-0005Iv-QG; Tue, 07 Sep 2021 09:17:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=xaPEDbTrlEdxGiPgvs3r61r+qm7NtTnC/Clpi0CTVhs=; b=twy/ZRMOwHvl1PKqlHGOecN0VG EcNXYeGjhtAstKYZwwpqW8Os7RIjOTnrgap5Tbb8/Algg4NyE54DKRtU8mRUAN+kgEB5UAIxn8i9F O8GHOtDfguExvTn7bUggb641ILmDYUCFhSiEzgjyztcgDZ7M76YRNPX4Zr0fhLbKzW70=; Subject: Re: [RFC PATCH] xen/design: Add design for EFI dom0less system start To: Jan Beulich , Luca Fancellu Cc: bertrand.marquis@arm.com, wei.chen@arm.com, Andrew Cooper , George Dunlap , Ian Jackson , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20210907065228.21794-1-luca.fancellu@arm.com> From: Julien Grall Message-ID: <3222722f-b12e-3991-d0de-b455b9fca063@xen.org> Date: Tue, 7 Sep 2021 10:17:50 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Hi, On 07/09/2021 09:33, Jan Beulich wrote: > On 07.09.2021 08:52, Luca Fancellu wrote: >> Add a design describing a proposal to improve the EFI >> configuration file, adding keywords to describe domU >> guests and allowing to start a dom0less system. >> >> Signed-off-by: Luca Fancellu >> --- >> docs/designs/efi-arm-dom0less.md | 105 +++++++++++++++++++++++++++++++ >> 1 file changed, 105 insertions(+) >> create mode 100644 docs/designs/efi-arm-dom0less.md >> >> diff --git a/docs/designs/efi-arm-dom0less.md b/docs/designs/efi-arm-dom0less.md >> new file mode 100644 >> index 0000000000..8d8fa2243f >> --- /dev/null >> +++ b/docs/designs/efi-arm-dom0less.md >> @@ -0,0 +1,105 @@ >> +# Xen EFI configuration file >> + >> +The current configuration file used by Xen when it is started as an EFI >> +application is considering only the dom0 guest and doesn't have any >> +property to describe and load in memory domU guests. >> +Hence currently it's impossible to start a dom0less system using EFI. >> + >> +# Objective >> + >> +This document describes the proposed improvement to the Xen EFI >> +configuration file to list properly both the dom0 guest and the domU >> +guests as well. >> +The final goal is to be able to start a dom0less system using EFI. >> + >> +# Current Xen EFI configuration file >> + >> +The current configuration file is described by the documentation page >> +https://xenbits.xenproject.org/docs/unstable/misc/efi.html. >> + >> +Here an example: >> + >> +``` >> +[global] >> +default=section1 >> + >> +[section1] >> +options=console=vga,com1 com1=57600 loglvl=all noreboot >> +kernel=vmlinuz-3.0.31-0.4-xen [domain 0 command line options] >> +ramdisk=initrd-3.0.31-0.4-xen >> +xsm= >> +dtb=devtree.dtb >> +``` >> + >> +# Proposed improvement >> + >> +The proposed improvement to the current configuration file is the >> +introduction of new keywords to describe additional domUs. >> + >> +Here follows the proposed new keywords: >> + - domu#_kernel= [domU command line options] >> + - Mandatory kernel file for the domU# >> + - domu#_ramdisk= >> + - Optional ramdisk file for the domU# >> + - domu#_dtb= >> + - Optional dtb fragment file for the domU#, it is used for device >> + assignment (passthrough). >> + - domu#_property=cpus=2 >> + - Properties that should be added to the dtb in the domU node to >> + properly describe the domU guest. Refer to the documentation: >> + https://xenbits.xenproject.org/docs/unstable/misc/arm/device-tree/booting.txt, >> + section "Creating Multiple Domains directly from Xen". >> + >> +For all the keywords above, the # is a number that uniquely identifies >> +the guest. >> +The keywords domu#_kernel, domu#_ramdisk, domu#_dtb are unique, therefore there >> +must not be specified the same keyword twice in a section. >> +The # number is not enforcing any domid, it is just used to link each property >> +to the right guest, so there can be domu1_* guests that are started with domid 2 >> +and so on. >> + >> +The domu#_property can appear multiple times and it specifies an additional >> +property to be listed in the domU node inside the device tree, Xen will >> +not check if the same content is specified multiple times. >> + >> +There are some property whose name starts with an hash symbol (#address-cells, >> +#size-cells), in this case the line will be considered as a comment, so to >> +specify them, they have to be listed without the hash symbol, the documentation >> +will be updated as well to see the implemented handling of these special >> +properties. >> + >> +# Example of a configuration file describing a dom0less system >> + >> +The following configuration file is describing a dom0less system starting two >> +guests. >> + >> +``` >> +[global] >> +default=xen >> + >> +[xen] >> +# Xen boot arguments >> +options=noreboot console=dtuart dtuart=serial0 bootscrub=0 >> +# Xen device tree >> +dtb=devtree.dtb >> + >> +# Guest 1 >> +domu1_property=address-cells=2 >> +domu1_property=size-cells=2 >> +domu1_kernel=Image-domu1.bin console=ttyAMA0 root=/dev/ram0 rw >> +domu1_property=cpus=1 >> +domu1_property=memory=0xC0000 >> +domu1_dtb=domu.dtb >> + >> +# Guest 2 >> +domu2_kernel=Image-domu2.bin console=ttyAMA0 root=/dev/ram0 rw >> +domu2_property=cpus=2 >> +domu2_property=memory=0x100000 >> +domu2_property=vpl011 >> +``` > > I'd like to suggest a different scheme, not the least because I expect > the individual domains being independent of e.g. hypervisor command > line options or Dom0 kernel versions. Yet varying sets of these are, > for example, a reason to have multiple sections in the current scheme. > Every dom0less guest would then require spelling out in every such > section. Hence I think we'd be better off having a section per guest: > > [guest1] > kernel=Image-domu1.bin console=ttyAMA0 root=/dev/ram0 rw > property=cpus=1 > property=memory=0xC0000 > dtb=domu.dtb I much prefer the idea of the section. This is going to be easier to parse the configuration file as we would not have to look for "domuX_" and then distinguishing X. > > These sections would then be referenced by other sections, e.g. by a > new "guests" (or "domus", but this ends up looking a little odd for > its matching of an unrelated latin word) keyword: > > guests=guest1,guest2 > > If it is deemed necessary to make sure such a section can't be > (mistakenly) used to create Dom0, such sections would need identifying > in some way. Presence of property= (or, as per below, properties=) > could be one means (allowing an empty setting would then be desirable). I would expect dom0 to be described in the similar fashion at some point. So maybe we should name the property "domains=...". > > As to the properties, is there anything wrong with having them all on > one line: > > [guest1] > kernel=Image-domu1.bin console=ttyAMA0 root=/dev/ram0 rw > dtb=domu.dtb > properties=cpus=1 memory=0xC0000 It depends on the number of properties for the domain, this may become quickly unreadable. But... if we use sections, then I think it would be better to have: kernel=.. dtb=... cpu=1 memory=0xC0000 This would also allow us to create more complex setup (such as for the static memory allocation). Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Sep 07 09:19:27 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 09:19:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180685.327435 (Exim 4.92) (envelope-from ) id 1mNXGI-00004t-Ob; Tue, 07 Sep 2021 09:19:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180685.327435; Tue, 07 Sep 2021 09:19:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNXGI-0008WR-Ka; Tue, 07 Sep 2021 09:19:26 +0000 Received: by outflank-mailman (input) for mailman id 180685; Tue, 07 Sep 2021 09:19:25 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNXGG-0008WJ-Vv for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 09:19:25 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id b0a2198e-0fbc-11ec-b0dd-12813bfff9fa; Tue, 07 Sep 2021 09:19:24 +0000 (UTC) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05lp2173.outbound.protection.outlook.com [104.47.17.173]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-16-5Pj7idR_M5Kp9voGTPgQmQ-1; Tue, 07 Sep 2021 11:19:22 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR0402MB3392.eurprd04.prod.outlook.com (2603:10a6:803:7::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19; Tue, 7 Sep 2021 09:19:21 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4500.014; Tue, 7 Sep 2021 09:19:20 +0000 Received: from [10.156.60.236] (37.24.206.209) by AM0PR01CA0111.eurprd01.prod.exchangelabs.com (2603:10a6:208:168::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Tue, 7 Sep 2021 09:19:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b0a2198e-0fbc-11ec-b0dd-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1631006363; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AfkubQ/XUUoMzWb4P1EI2bnBghkZcRYqwXc3h2OW3OA=; b=Qk+wryJM5YTr4Bk8yzj35R+D58lI71PKCzQR1iSia+rxare/P8j94hu2ovL4nhza7ybCUt 6tE8A8g9/ikbuhiHNA5RP24IAwiPUQph3yEdTLhzV0CltJG416o6BuACyxNjhNJCWeeusX J5N6ktVFY3t1SJ3mjdZ108AUV8wIjFE= X-MC-Unique: 5Pj7idR_M5Kp9voGTPgQmQ-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=O4eV2BFg8QDjioBXGlM5Vy2DM1xW+mlurUUvHt85SNQfbFXjHyACG7r1Alu6ZhymIBZQvtX8V0yepjUKuUHKmjrD4Cw/mvq7gI4b5mpzFldZrRfArZ2xOzP5TH+IeN8hIix4yKLmbPBT+hYCxJ4dH8JKMAQhghZunPNIZeiH2QkF112rCT+NxuluI8XinayV0wyly6XUzyBL9pBHyU3f+eBE6Dq3/49MbQNAA3i+UpnFtFYJxcgKSKKAz8olK4fa8UXEGmEZLDcp6MqYTA0fxahOZIX1xh8Wr1B4/Tex7T+iGXEwNSlmWHebzhuhhdl7NnXh+9fGkcbQYD6txH9bkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=AfkubQ/XUUoMzWb4P1EI2bnBghkZcRYqwXc3h2OW3OA=; b=IhGbeBi7cOP3SKgUw7wqyvgpb40L93xtaPgw4WapCflni583Wg7jOv6IlV0t1JYELj3kfVykM0JCFBPayDdYa2ANMHEbtOPmgX3MO8BC9C9dUGQIxotfgDjMQw/a5ihBIT7pusWIuWivMBS7uj1oZqu2vdVskADi4GNFTBRY7+ioPaUtelEo3IhR7p39rs5HIap+T7eVKO2UhBJUYOH0y/sanzTszxtNYD/vJ+sJy5stFiW08/DfAh1UQE+BHfRhxi5IZngi4nS5aAxu0Hz2oQpZWxHSsFzXScASYzz8EtoqEgeYXnNZe2fu3JxK03Q8NA0bqW06WcBC3nBSmUvuYA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com; Subject: Re: [PATCH 8/9] vpci/header: Reset the command register when adding devices To: Oleksandr Andrushchenko , Oleksandr Andrushchenko Cc: "julien@xen.org" , "sstabellini@kernel.org" , Oleksandr Tyshchenko , Volodymyr Babchuk , Artem Mygaiev , "roger.pau@citrix.com" , Bertrand Marquis , Rahul Singh , "xen-devel@lists.xenproject.org" References: <20210903100831.177748-1-andr2000@gmail.com> <20210903100831.177748-9-andr2000@gmail.com> <5366265c-d169-041d-f812-1c49260f6499@epam.com> <8f1816db-798b-15d9-7343-2199eb8f39e0@suse.com> <0e3942a5-9105-c99e-f15e-dcf35aae142a@epam.com> <5d0d345d-db16-f0c5-9a78-4ad5f4733886@epam.com> From: Jan Beulich Message-ID: <5ffbd0a6-b34f-4de4-b316-2376211039f1@suse.com> Date: Tue, 7 Sep 2021 11:19:18 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: <5d0d345d-db16-f0c5-9a78-4ad5f4733886@epam.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM0PR01CA0111.eurprd01.prod.exchangelabs.com (2603:10a6:208:168::16) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9e2c8330-1659-4126-a703-08d971e09349 X-MS-TrafficTypeDiagnostic: VI1PR0402MB3392: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: cDx2KHKtTSgILVVDEBk3Mfl3GJS1uQUPx8fUietNRl56XBmQg0QzKYjplxTdOs7JqB8PIEwGLc6CWeFFJD1KFjxd1Yl7/GXBqeQK54+UcE4Xj0Yo0GyesDKQs3H1FvR2vWHmgoI0Nr6QVLFYtv8nXtXIOrSxyYEJwbp49mWfnitqjGJ8uswYpVNDL9LADv/lPH7L08nyCELL716j0wc/TJVTZG+CkjOYT2IHVkCTCKuy8Cr3o22N+iixsojD2d0UQ8lgPAEWLyGuQx2jON37D1IkCSqBw0cr45nfKsEGuv+l/nmO0lCY/cOUTCnTRyyw9tCuKtvmC4tOMElzBk/R1hoKYsW9yOV7p4QM8FnYiOr5NosKeWzKU4UJvtU72I/12g61YtEgv0GGFYQ9W9ZzVQoJXME5zABoIXvogWGyUUa5CvZKseo4l0r2y6ddZuCCLkCHwFCWW1mDe8Ilg6BfsmrHJ3Mj4+tZCzYF+h3Sk72XwdtAuJ13Ky5Dv74xKWZVqumTddhCyhAIPLOyvcES565UOtTh3yVJ9169ngGIvReXXOCHIAi449ErhTExNSrNOtY3C2K05sge/8NBwB9kC0YVc+voTaoyF+O6M+AGO1moxA5UttflFEoDz3RFKuLyJw/MJwNHA5grEP2bvAwnmQ4tNQjoCBsDmkZab9Xnthd5nNhCBoyHW9y+NWMEfGjFy8TnTrFFMATm2vFtymjfMA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(110136005)(38100700002)(31696002)(508600001)(956004)(31686004)(7416002)(26005)(54906003)(4326008)(186003)(83380400001)(6486002)(66476007)(66946007)(8936002)(53546011)(2906002)(66556008)(316002)(5660300002)(2616005)(16576012)(8676002)(36756003)(86362001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MFA5QjNRcHlyT05vMEN0TzdUYjBtK21FcGszUDRsVVFiZzJWK3pGcjQ5ODI5?= =?utf-8?B?dWtzMU1pTFlYQXZ2SE9XdCtKTTVyMHBaTW9EcjBKeUhXZzdzMlNRdzlzT1cr?= =?utf-8?B?SUtGdGE0dnA5MUdXeGdya3JOeTUwdmVBZm1qYkUybFJ2RVdjbGtFY2pYRGY5?= =?utf-8?B?SHUxUjFaK1IydGJsK0xBbDZmRHduT0JTM0xRamVTU3pJSE41SFZoMWl1Ui83?= =?utf-8?B?UDgxcGFGbGlnMnRNaGJxcEhUUTd0NjFaZ1JrMFlwMlpyVmJlRkY3MlZyVzlF?= =?utf-8?B?WG1LMy9FeHBYaWRMbkszWmcvZExCOXdYclF1K2VScVhmQ2p2S1RrWDU4OHo4?= =?utf-8?B?QTlyVVl4QmZseEVnZHE2TXQwc05Vd1hYbWdackkvaDU1NFpBL05saWpWZS9W?= =?utf-8?B?QjV3cTJtMDdIVTVIYndOS29keTlIUHlPbGpmcXF4RStHUlJ0RkNiRW0wNDYy?= =?utf-8?B?UzI2bXRvMVl3RzJVc3MxamFuRzVaSGdpTHdrMGhvNS9QMkdhV2YzZGoyYUY0?= =?utf-8?B?VkpDZTZOYy9BdE5SRW8yc3ZJM09vZUVvS3NwQVUyQ2wvMGkvK3hKN0lEWGhv?= =?utf-8?B?NGZoakdmM0EzNU5hblFaNUs2UVFkRHYwMGQ1c3lsekdXSmJBTERZazh6ck9r?= =?utf-8?B?QWhZWlI3alFrd1kweVI0d2czUC9JdnE2c2NHcFBramVyMjhsTkhscEsvb3lm?= =?utf-8?B?TnFpYnpqZUY3L2x0U29PWlg3akxZOC8rVVBNNlRSWnBZZTVvZ3R6VjkrWUIy?= =?utf-8?B?eU0zN0UwYnpXclZFOHVwY1JsRUI5bjJNMSs4eFUrbEcyRE1aUXJQckNzL1Zq?= =?utf-8?B?UHRsWUdyQ1N4ODhuVld3YzFwcHViVHovZjd5ZFNQdktXWEZvSkdGVTI3L1Yy?= =?utf-8?B?d0xNdFY4N0QzcWVUK01HdWJpS0FPbXhadDVHZlNvQzBCQW1GZVB5bEZMeVRp?= =?utf-8?B?b1pJVHZpUU9XdERJS3AyVzBWRi9aQ2pDQllXK3NINGczTzJmTXN3Q1lpbTls?= =?utf-8?B?LzNJYzVjMk9CVTg3cWJFc3EycFlJdE55cG9OdnpKRmhSelNzdWJ2RXhVWVRh?= =?utf-8?B?ZGlWWDA4YWZqRXQwT3hSQXhuOGErc0NPalN3SW9vRjZrTXRpbVpmZ011KzYv?= =?utf-8?B?YVNScG9wSlNMQ0RiL2pVT2Fjdk1rZ2JQUEhyNnZlTXRhT3NCMk53bFlhVGF0?= =?utf-8?B?UkdJcDBVNzlOeXZXcVlkempzNXBmYjVWY3Q5QW5QZDdYOEpPTWtUNU0rbUxn?= =?utf-8?B?Q3ZDbzJKZjVxdVdmUXpqTENxd0NmWUJpcURESVczSmZsWFNVRDdKWFNvNXpZ?= =?utf-8?B?S3kyU1lEQXBwbG1mTXVqcWZxOFNxZDJWYTBqaDlkYzZVSVE3WmMrS1JVcmVy?= =?utf-8?B?OHF6bTdXVHVmU3QyN0NlL3NUT1dSdjk5ZEMzZHp6REgwN0hZcjhlZlpZTElG?= =?utf-8?B?dkRZNWNYQ2lzbzJrUEFoKzhwMW91WWx2WW54VVZJWDJRUVdjcEhOa3pzK1Jj?= =?utf-8?B?aGZ6ZWJkNCtYUzFXaHlGL0dQQkQrQllKNWtyYkV2VHB2QXpOdWd2ZEs2S3N5?= =?utf-8?B?Y2FBY25CcXhUem96NHk4dDlldEg3V3hJMmFLRjZ4cTdiQ1Y5OWtlbUpWYzBG?= =?utf-8?B?M21nWXpwMVVNQWxnQURDbXFSNkdWK3p1eGxHY1lJdjdRZnVOY2NkdnA1YW93?= =?utf-8?B?NjNpZWU4M2ZaTDJ4VFhJbjdxQ2VnZ2crQzRUZVJ5R3VncC9lTmhzVVBsOG11?= =?utf-8?Q?Dts3p59VenTxTH4+Rb4/g/rsvDEMtTnNq98C5y2?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9e2c8330-1659-4126-a703-08d971e09349 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2021 09:19:20.8335 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6aNQ9eM1WTM/qW4MT2A4VS29LIj/1w8MRlpvMvz5WrnPDNSTwVD549G5jJ5VHzJKUq1u8JyTltj8K2E9amceZQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3392 On 07.09.2021 11:07, Oleksandr Andrushchenko wrote: > On 07.09.21 11:49, Jan Beulich wrote: >> On 07.09.2021 10:18, Oleksandr Andrushchenko wrote: >>> So, if we have a hidden PCI device which can be assigned to a guest and it is literally untouched >>> (not enabled in Dom0) then I think there will be no such reference as "host assigned values" as >>> most probably the command register will remain in its after reset state. >> What meaning of "hidden" do you imply here? Devices passed to >> pci_{hide,ro}_device() may not be assigned to guests ... > You are completely right here. >> >> For any other meaning of "hidden", even if the device is completely >> ignored by Dom0, > > Dom0less is such a case when a device is assigned to the guest > without Dom0 at all? In this case it is entirely unclear to me what entity it is to have a global view on the PCI subsystem. >> certain of the properties still cannot be allowed >> to be DomU-controlled. > > The list is not that big, could you please name a few you think cannot > be controlled by a guest? I can think of PCI_COMMAND_SPECIAL(?), > PCI_COMMAND_INVALIDATE(?), PCI_COMMAND_PARITY, PCI_COMMAND_WAIT, > PCI_COMMAND_SERR, PCI_COMMAND_INTX_DISABLE which we may want to > be aligned with the "host reference" values, e.g. we only allow those bits > to be set as they are in Dom0. Well, you've compile a list already, and I did say so before as well: Everything except I/O and memory decoding as well as bus mastering needs at least closely looking at. INTX_DISABLE, for example, is something I don't think a guest should be able to directly control. It may still be the case that the host permits it control, but then only indirectly, allowing the host to appropriately adjust its internals. Note that even for I/O and memory decoding as well as bus mastering it may be necessary to limit guest control: In case the host wants to disable any of these (perhaps transiently) despite the guest wanting them enabled. Jan From xen-devel-bounces@lists.xenproject.org Tue Sep 07 09:24:51 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 09:24:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180693.327446 (Exim 4.92) (envelope-from ) id 1mNXLS-0001pi-GM; Tue, 07 Sep 2021 09:24:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180693.327446; Tue, 07 Sep 2021 09:24:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNXLS-0001pb-D7; Tue, 07 Sep 2021 09:24:46 +0000 Received: by outflank-mailman (input) for mailman id 180693; Tue, 07 Sep 2021 09:24:45 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNXLR-0001pV-PT for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 09:24:45 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 6f73a761-0fbd-11ec-b0dd-12813bfff9fa; Tue, 07 Sep 2021 09:24:44 +0000 (UTC) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05lp2111.outbound.protection.outlook.com [104.47.18.111]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-25-cfbypJ0_Nrq764JVaelNew-2; Tue, 07 Sep 2021 11:24:42 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR04MB7152.eurprd04.prod.outlook.com (2603:10a6:800:12b::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.21; Tue, 7 Sep 2021 09:24:39 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4500.014; Tue, 7 Sep 2021 09:24:39 +0000 Received: from [10.156.60.236] (37.24.206.209) by PR3P191CA0047.EURP191.PROD.OUTLOOK.COM (2603:10a6:102:55::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.22 via Frontend Transport; Tue, 7 Sep 2021 09:24:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6f73a761-0fbd-11ec-b0dd-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1631006683; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=92ya5n/p8bGdMWSZW+gUJtmHj66H2FVO1aSkxTQSLw4=; b=QzJJVhKi/BbrifPvFvsjTgC2Y0ncm0cfJZUMoUwXXHA+HnziDTkSefGwt2u1q6R7SDNOAk ozYFMudZfjxymSf4GAZjO06BTnxgYTS/Gid4yzwlEeU80LZ7IIQXcYvav+7D6GcaDVGL58 iQjiESJEsSn8gcO45g/dlgzYwVrHNQw= X-MC-Unique: cfbypJ0_Nrq764JVaelNew-2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SoCUmH7KES2lcCuH28BWCZKl6vv2eWfI4HT8dr0g/0nO7odmgcFf73a1vWyY/QFbloxiHlu/o+d0vlQSBVX4LZEvflsPxUpmlwl/0uC51RhmDyLKqUeQuI7BCEebM6t9EgdP41pRPXSxYj30li/EUSHICh5qiCp9JU+OXpaIdcU5yEGCaXDgNtjrSApw0cV5lZ8EgdilziI3rLLqn5ZpQxBg8BhDyZSqRTmwT78tx6qIagR0zevvkKpqAC39hG2wpguJRw3nmnA/HMYh/TIVDXZlJwFFVOvby/dxCyzB3mrcpensH3ChPuU6tpjpF8l+7brB+f+4FzfPK1Iehy9Ffg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=92ya5n/p8bGdMWSZW+gUJtmHj66H2FVO1aSkxTQSLw4=; b=h7S+x70DHmBh76ah0GwTyHqR+dRxkrb1+iJZBBYadrJTUly4NEMHQV1ARKb75e/hcUAkTt2TkuTh03PnvuaXrbULUCWVEIa4zZaMf+h3kWsqCIAybCCOxKqQfSw25BugGDZCxvuR+tWoRKqfEhBB+qMv8KMa4C5zMp91KF4TVXeaulCWc3NPNRCgk7+ksg0s3J5nsXTKNlZ6qOZwpsFHdcT6WESKaf4L/q7XiKwMBw4/XFfm/JHefzdFKryRIe3UEbdiVB1DIsC0gMd4wqj+jjLDlh1imh+842GF/BC659oLPxtrJnVWh+CL9gLCUXcOopoFjlG2YQ+BG9aJyaUqXw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=suse.com; Subject: Re: [RFC PATCH] xen/design: Add design for EFI dom0less system start To: Julien Grall Cc: bertrand.marquis@arm.com, wei.chen@arm.com, Andrew Cooper , George Dunlap , Ian Jackson , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org, Luca Fancellu References: <20210907065228.21794-1-luca.fancellu@arm.com> <3222722f-b12e-3991-d0de-b455b9fca063@xen.org> From: Jan Beulich Message-ID: <1b4eef88-78cb-7201-c326-551261f9e9ad@suse.com> Date: Tue, 7 Sep 2021 11:24:37 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: <3222722f-b12e-3991-d0de-b455b9fca063@xen.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PR3P191CA0047.EURP191.PROD.OUTLOOK.COM (2603:10a6:102:55::22) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c45b6758-e959-49a3-d3c9-08d971e15136 X-MS-TrafficTypeDiagnostic: VI1PR04MB7152: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: T4Nz5BsL4QGfoQ9urWOtzoRhB8eKZYHxT3Wrc2gHfWtx7WzBfYsnhJ5NaCN0s6NFKtpYCsKP99HK+fCJKtscsuDFiVMwgE0efAKpk7ZcdlaPGAqsMXUZRc2LKNCksens/v9ieFiliwOB0U0kEWN+JKDe+hrJEukSwnDYe3hD+jArlaWDSI1UqK1illwgwiIIfIyKgqx1sTTLOGTp5CA6V0xywsx8sYBcco6UV5sGzA5CoZHsOwqUGqVN28VkyBoqQOew3xIBdS/434fQAJBAxagKPk40lWPbT5ysTCRDecIhR97vSxmj6hNZmkElwHzCzn3J96yG3GTGmn3smDCVCbB2nYwGlNs0PeM1MbA0ozHKVLXp5edX4xBxckNf+NtSNoJy0x4t8XoD/Q6BbbEpFY8ig5oeEKYcUmvUs894JTY57LcUKNWe2jn1txBPB2Rvw+ixvzrMVpb1rAeJtomCtPhqrrNjCJq7QEXj72Up3mWDrMcq7kgl944a9rhv6aBj+3uZhyNK4MsNwIK0oluJyDxmY1/bW+CncwDMJp9oOAplEedRMhIeJJcLMRx93T5f7JzudC3Osiui1OGP81npXi3nzVkdpYrFeog43ymEE1vmuV6JfgC1+ccnUoUPwv/1gLYWHRxue2oPUdY/dolVakrp0uBHEkIXk0WmTDqnwPZKBnCCjzEBundkwbVTXYZMvKX8hq8JEKa0t4vNOqfefd24tdljXpHX2Rw043HWid/O3qT3lB/QS8Sy6tIf4TzG X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(396003)(376002)(346002)(136003)(366004)(39860400002)(66946007)(6486002)(66476007)(66556008)(83380400001)(478600001)(31686004)(36756003)(5660300002)(7416002)(86362001)(31696002)(6916009)(54906003)(316002)(956004)(38100700002)(2616005)(16576012)(2906002)(186003)(26005)(53546011)(8936002)(4326008)(8676002)(32563001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SDR3NFJFVUsraW9XZTd3N2paYjByL2xqUDBHcis2b2x0YklJNXFZR2JuTFdF?= =?utf-8?B?RlhDalhkUmhtQjlUZkVhWmN4djJ3NzY3T1dVSmNBdXlEdUNibDV2SjZTRUw5?= =?utf-8?B?OG9heEo3M1NnUzVJeWwzRGgwS1JxZ0FrdUFnaWVvSG5wUVRQSHVHNW96Q0dI?= =?utf-8?B?WldkNncva1JoVXMrZDkwbGRvZy9yeHNPMW9QUVRuNVdnbHQ4TWZNTEhVUFYw?= =?utf-8?B?ZXpuU3ZrUENSTXE1UVQ1Ynk2WllnNkM4Vi8zekEraytBTlRMNTlzMjVraDdJ?= =?utf-8?B?c0JPaG0yQnpxaHg5VGFmZjJiRGVaMUMyRGlYTy9HenBHY2UyUDJhenlsSWg3?= =?utf-8?B?ZHN5ejhVQ1VYVU9OeThVRHRvbmdESWxLMUU1RmFSUXUyb1hDaWRoQ2Z2bXdn?= =?utf-8?B?V1VSRm1tU0FnMTFIUFZkazd0anRmd3dkMlJvN09ENDNrZ1BncmtIRTIwWXNQ?= =?utf-8?B?bEFKUEdRQzhFK2UyYk5DYnpwQ2c3NU92L2FxTGFxWERmUm5rYkkzRVRITXZ0?= =?utf-8?B?QnIrWlEycURYNitnTU1CejVxbFVHYUpZWlRYWmd0OVBzZUVqTWQ2UHBZV3ZP?= =?utf-8?B?MDVDa1FVaEtuUUlidGNXRm8yT1gxcnFmN3QyM1RWUERYcFJqcU5SUWYzR3dm?= =?utf-8?B?dTdJaklVYmxQREFwMnZqU0R5dWJMc3dwUk9OUmh3NXREZ1NCM1NtdlU2R01B?= =?utf-8?B?RHNiMDg5Zk1CWklRYzZoNFRjakM1SWxzbjlYU0E5Rno1bmxnN0VONkgxY3ZM?= =?utf-8?B?VThCbTRXYXUzSm5GL0NJcTQySlQwMENxWHY0U1dGVnl3cHljWURVU0g2cGJE?= =?utf-8?B?d3lnL2w5cFJRMDR6R3orUUNyWFIvNEF4TGZSZFgvalAyMkhEYVVrUVJCbWdp?= =?utf-8?B?am52RnVCcFl2dU9WTkhISG5OSnpIdFQ1VGZMUlZod2V3U09RZVd1Y0pva2pF?= =?utf-8?B?aFpia1JVMGQ2dVUwR2ZHY0g4R3BYLzBTYStJcTgxbXZGdzJYZGFYYlMyVll5?= =?utf-8?B?ejFNUy9aSVkvQjVzRXVFOEJNQk4yT3J2QjF4Y2JVbHRJdTRSUG8xYzF5eUd0?= =?utf-8?B?U01USXlkdUpYYml3TFRmc0lpelhORnRnMVNWMmF3SVBLSWQwandrVU9FL0d1?= =?utf-8?B?Nnp5UzBrUm8ycXJjLzNsUy8rSTFvbnc0ZE92dmpTQnVDemhuYkppeDlGSmY0?= =?utf-8?B?eFNjNEhSMGNEa0Z5YUJDem9HcVBTbzZpTnRhME44NUR0cEVOU2Z1dWxmQk5M?= =?utf-8?B?WWloSGliZklEV1lld21HOEo3K3ZQamQ3U1FLUmxkWktNc1B3ZGg3MEpiYmdu?= =?utf-8?B?dnRBNDc5WXN1U2ZQZXdnTmx3QkdWY0hIZlpiUUYrMExGZEZDS2NSMlZuZkJZ?= =?utf-8?B?TXlwdjgwOEVtY2Y1MlpoUVZmR25jTlNzWTc2VTRPeE9ISG1QME5MZWlTRjZ2?= =?utf-8?B?TFBaMzUwQ0pLOUpERXNURmIwNnByeWxwL3lMN3EySHdPSjMvYWdYanJpdEVE?= =?utf-8?B?YVgxRXZ5YzJKN0JSUlAwOVRHSjk2T0RNaEtoUFhiZS9qZGxRa3RBWFM4SXNP?= =?utf-8?B?R1hSK0FqUjJCOWhzeis0cUxFckFjdFZ3aDUvcllxS3lZUkNuU2toOXlwOUZx?= =?utf-8?B?c0hnUEJDTmNUQXJ6a3lYZUc2Q2cvWVBUUnVab3d4SVlSOTlKY0dUZ0RIYTBa?= =?utf-8?B?QmpSeEVHaFd3RVQzb1Q3RnNWNnEwSmE5YjFQSTE1SWVJdnI0MzFpU2p1emla?= =?utf-8?Q?NMGkA7AfmeB1l8lUbX3a15/OIHd+Ra4oeDBFGLY?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: c45b6758-e959-49a3-d3c9-08d971e15136 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2021 09:24:39.5312 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: PNgdy4r1gZD2LWgrT6GFIy+FwTuDdZ48xSCbYQ9RBzK0hv1tKrfhWtzqHScbPblez7R8jpkePLvoBsaTpoZXLg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7152 On 07.09.2021 11:17, Julien Grall wrote: > On 07/09/2021 09:33, Jan Beulich wrote: >> I'd like to suggest a different scheme, not the least because I expect >> the individual domains being independent of e.g. hypervisor command >> line options or Dom0 kernel versions. Yet varying sets of these are, >> for example, a reason to have multiple sections in the current scheme. >> Every dom0less guest would then require spelling out in every such >> section. Hence I think we'd be better off having a section per guest: >> >> [guest1] >> kernel=Image-domu1.bin console=ttyAMA0 root=/dev/ram0 rw >> property=cpus=1 >> property=memory=0xC0000 >> dtb=domu.dtb > > I much prefer the idea of the section. This is going to be easier to > parse the configuration file as we would not have to look for "domuX_" > and then distinguishing X. > >> >> These sections would then be referenced by other sections, e.g. by a >> new "guests" (or "domus", but this ends up looking a little odd for >> its matching of an unrelated latin word) keyword: >> >> guests=guest1,guest2 >> >> If it is deemed necessary to make sure such a section can't be >> (mistakenly) used to create Dom0, such sections would need identifying >> in some way. Presence of property= (or, as per below, properties=) >> could be one means (allowing an empty setting would then be desirable). > > I would expect dom0 to be described in the similar fashion at some > point. So maybe we should name the property "domains=...". Not sure - the order above doesn't mandate domain IDs, yet Dom0 needs creating with ID 0. IOW I was deliberately suggesting "guests=". >> As to the properties, is there anything wrong with having them all on >> one line: >> >> [guest1] >> kernel=Image-domu1.bin console=ttyAMA0 root=/dev/ram0 rw >> dtb=domu.dtb >> properties=cpus=1 memory=0xC0000 > > It depends on the number of properties for the domain, this may become > quickly unreadable. > > But... if we use sections, then I think it would be better to have: > > kernel=.. > dtb=... > cpu=1 > memory=0xC0000 > > This would also allow us to create more complex setup (such as for the > static memory allocation). If that's feasible parsing-wise - sure. I was first thinking to suggest separate keywords, but then decided there was a reason this wasn't done in the original proposal (with respective dom#_ prefixes). Jan From xen-devel-bounces@lists.xenproject.org Tue Sep 07 09:36:07 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 09:36:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180701.327457 (Exim 4.92) (envelope-from ) id 1mNXWL-0003Z5-JF; Tue, 07 Sep 2021 09:36:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180701.327457; Tue, 07 Sep 2021 09:36:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNXWL-0003Yy-G4; Tue, 07 Sep 2021 09:36:01 +0000 Received: by outflank-mailman (input) for mailman id 180701; Tue, 07 Sep 2021 09:36:00 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNXWK-0003Ys-DX for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 09:36:00 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNXWH-0000cW-Ju; Tue, 07 Sep 2021 09:35:57 +0000 Received: from [54.239.6.187] (helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1mNXWH-0006k8-D8; Tue, 07 Sep 2021 09:35:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=zt8g/1egKtbllKcQNJg4DQLiOBnwt0kBFJGt3Sn7rSw=; b=fAU76dfu5dTxcGnb6q78D7EEIf vgLRNFq9OK13HumYIYU8rV4V9Dc3a/EA5lUOZ/1g4NUD9j1WPolP5C/z+uaLAQravuRyKTcowdkG9 wT2w/gpJ33ZqIckMV/iFIheuX4j2h1IgLo9A1veD9Kb+DDfp+kP4lpnw9ZZ/eImULGR4=; Subject: Re: [RFC PATCH] xen/design: Add design for EFI dom0less system start To: Luca Fancellu , xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, wei.chen@arm.com, Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Stefano Stabellini , Wei Liu References: <20210907065228.21794-1-luca.fancellu@arm.com> From: Julien Grall Message-ID: <4bab7902-0268-5705-5462-fcd7571d7492@xen.org> Date: Tue, 7 Sep 2021 10:35:54 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210907065228.21794-1-luca.fancellu@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Hi Luca, On 07/09/2021 07:52, Luca Fancellu wrote: > Add a design describing a proposal to improve the EFI > configuration file, adding keywords to describe domU > guests and allowing to start a dom0less system. > > Signed-off-by: Luca Fancellu > --- > docs/designs/efi-arm-dom0less.md | 105 +++++++++++++++++++++++++++++++ > 1 file changed, 105 insertions(+) > create mode 100644 docs/designs/efi-arm-dom0less.md > > diff --git a/docs/designs/efi-arm-dom0less.md b/docs/designs/efi-arm-dom0less.md > new file mode 100644 > index 0000000000..8d8fa2243f > --- /dev/null > +++ b/docs/designs/efi-arm-dom0less.md > @@ -0,0 +1,105 @@ > +# Xen EFI configuration file > + > +The current configuration file used by Xen when it is started as an EFI > +application is considering only the dom0 guest and doesn't have any > +property to describe and load in memory domU guests. From my understanding, the problem is less about properties (we already have them in the Device-Tree) but more about where are the binaries located in memory as we don't know in advance. So I would like to propose something that build on top of the Device-Tree work we did. Note this is early thoughts. The problematic nodes in the DT are: module@0x4a000000 { compatible = "multiboot,kernel", "multiboot,module"; reg = <0x0 0x4a000000 0xffffff>; bootargs = "console=ttyAMA0 init=/bin/sh"; }; module@0x4b000000 { compatible = "multiboot,ramdisk", "multiboot,module"; reg = <0x0 0x4b000000 0xffffff>; }; In particular the property "reg" cannot be known in advance because the UEFI stub will be responsible to load the binaries in memory. What we could do is providing a list of binaries to load and associate a key for each of them. Something like: binary= binary= .... We can then replace the property "reg" with a new property "uefi,key" that will contain the name of the binary. What do you think? Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Sep 07 09:52:40 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 09:52:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180708.327468 (Exim 4.92) (envelope-from ) id 1mNXmF-0006Mm-1B; Tue, 07 Sep 2021 09:52:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180708.327468; Tue, 07 Sep 2021 09:52:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNXmE-0006Mf-UQ; Tue, 07 Sep 2021 09:52:26 +0000 Received: by outflank-mailman (input) for mailman id 180708; Tue, 07 Sep 2021 09:52:25 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNXmD-0006MZ-9e for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 09:52:25 +0000 Received: from mx0a-0039f301.pphosted.com (unknown [148.163.133.242]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id ac617ce9-c16b-4a33-9cd1-aeeaca2b86fe; Tue, 07 Sep 2021 09:52:24 +0000 (UTC) Received: from pps.filterd (m0174677.ppops.net [127.0.0.1]) by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 1879h5nS030224; Tue, 7 Sep 2021 09:52:21 GMT Received: from eur04-he1-obe.outbound.protection.outlook.com (mail-he1eur04lp2059.outbound.protection.outlook.com [104.47.13.59]) by mx0a-0039f301.pphosted.com with ESMTP id 3ax3d2rker-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 07 Sep 2021 09:52:20 +0000 Received: from AM7PR03MB6325.eurprd03.prod.outlook.com (2603:10a6:20b:13c::18) by AM7PR03MB6327.eurprd03.prod.outlook.com (2603:10a6:20b:137::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.22; Tue, 7 Sep 2021 09:52:17 +0000 Received: from AM7PR03MB6325.eurprd03.prod.outlook.com ([fe80::d9b7:c0ab:2c2f:5b44]) by AM7PR03MB6325.eurprd03.prod.outlook.com ([fe80::d9b7:c0ab:2c2f:5b44%3]) with mapi id 15.20.4478.025; Tue, 7 Sep 2021 09:52:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ac617ce9-c16b-4a33-9cd1-aeeaca2b86fe ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jK7A8sAL19CiTLD3ZU6JXJHyA2iHkaS+uQeSNQi0nDL/oyZSmdhku4rxDffaQyY/EcxelDcXiE7h0DU8H+6m1I3HvzXvbbMPsucKSUt3WwbWz+KiFojcErDaOTnDZw5yBPnD+rFWfmtTUNQU4DlbFty7ok2XJSjqHBEIt2P1MCq2o8rezPzapNlwgc7GFK3lA9Dt+P/S/y5CSLSOtU+tiv5/K9YzhT8UKicyNo/iwUsv+WfmMGUqGbu38DyoZqgjAae9/N6U/JUinPkrg6xP5MoDWY7wlwwGRIES4bx9D5cXh7PtaUiOrGZgZo1DVtXh8soyGIqInh/IJ6mjxFIyfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=+ol761Dc91+0hUI/Jo1B4DDOAwiNGaIXzUP1n4/xJDE=; b=Sd2oFJsoJrYc6fz9/hrKGBWkdnTvscWMMZ6dPyztpbqnZmImNdwxjm4LEbbRBsQYOgke7W0ndt9p6ZmCS+uff+SG8cuYzMTVOK7Hlz/+A4cP3xcMQJQZu0o1DVYbZtU2GFA6o8AkKfLM7oAQW+W5DVlO5gC4kAxbUmzpGGKAbHiE9LSEhiYdXRuS5bZ6IwIrU5Xb/dsLHbKYmC1m3gFreN5aXpBWkOxKmGj2vGThNsSKz0wKB5RnyCVbYiUR1akSFiFLPTFH5i1bm40bUZkhW707oWDCGimO9du1SIAj/T27heUYOsjqY4RCrmRhaAOT95UAE0f919zm/YA/TRvqfA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+ol761Dc91+0hUI/Jo1B4DDOAwiNGaIXzUP1n4/xJDE=; b=NSnbO4ohcGGbWE+3TOU1Gqlv4LAnWL2jt2px9mYqCXsyXyAYlnlIszf+Ct3wBfJz3QXLmJFO8YmbV1w6bddBMX8f48sKllLuEwMFmf5JKkK44SSOvtnvenmuDp6UM/GCy7TkrAmhFxb5QD6WPtNdo8sjd+/obczV/Okp0omiIlhYZ+84IIESm9VImoKDBO37n8BdiHr4UF123XmWBYoZKBCQHvqOoNfXFao60hIScKDOreKoaBeelj5tfHUh+mLceGn5wFa8tMHfBE5H0MD7he+FfaBob+1WAPJN4DCg26oZUS5hEVicFoX8k3rRUsfZHSiy6e0G69ae3QIb/31Nhg== From: Oleksandr Andrushchenko To: Jan Beulich , Oleksandr Andrushchenko CC: "julien@xen.org" , "sstabellini@kernel.org" , Oleksandr Tyshchenko , Volodymyr Babchuk , Artem Mygaiev , "roger.pau@citrix.com" , Bertrand Marquis , Rahul Singh , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH 8/9] vpci/header: Reset the command register when adding devices Thread-Topic: [PATCH 8/9] vpci/header: Reset the command register when adding devices Thread-Index: AQHXoKxjFI8WSqpeJkWkpzZfft/zi6uXHR6AgAEZm4CAAASsgIAABSgAgAAIrgCAAAT5AIAAA1EAgAAJNYA= Date: Tue, 7 Sep 2021 09:52:16 +0000 Message-ID: <6db7c55c-93c6-7901-6097-687287463c78@epam.com> References: <20210903100831.177748-1-andr2000@gmail.com> <20210903100831.177748-9-andr2000@gmail.com> <5366265c-d169-041d-f812-1c49260f6499@epam.com> <8f1816db-798b-15d9-7343-2199eb8f39e0@suse.com> <0e3942a5-9105-c99e-f15e-dcf35aae142a@epam.com> <5d0d345d-db16-f0c5-9a78-4ad5f4733886@epam.com> <5ffbd0a6-b34f-4de4-b316-2376211039f1@suse.com> In-Reply-To: <5ffbd0a6-b34f-4de4-b316-2376211039f1@suse.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=epam.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 47fbaf89-b629-4a2c-c6c6-08d971e52cfd x-ms-traffictypediagnostic: AM7PR03MB6327: x-ms-exchange-transport-forked: True x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: PYuXB+pwgV16n1NQeQQHDt2Kc1yitg8csf0lx4VNEaLkXosO5IzY8yAHr12wvtVEgC985gkUG/iFdVVozG6EV4dnKkKboLze6IsQb6BTHJiiOcQnAFzhZkepTef8QAkslMqqv7cXGaUK2/0TPzppWFYX+JLTg9/dOA7nkHjcadagzm8s33q73kPmdzU6dEjjPE7uhp6acHe8lhgI+Ce2vkWnr4/2fORMv0pXn6lYDIfdlRf+S7gtUWLRoveCYqiUllM8BqwTbTaM1ncWvFwB2FAkQgrK/+kREaIRWQXW4BaYjyjhY02BcVqsSJtJVIcjIOWTXdifanzXsh4Rz7tsFcbRuUBacFGKV0uhh/5yoE/yEbfy8uACeC1YrOogNEyccoIsn0uraIDa9lXqsmv2qvotHd/CcU1Bl+QAu+tDLDL8ufc1Cg/GMBnQLAsfkICnyFseTKQI2tyHQ+VMdUJJs+WfGPqWBGyN9NmC161kVZ5b89mR1DYYO4gjHN1ge7i4qEbwYaAc6Beqi6usBZNYtAX0l7JfGnZ6BtoxLKU10sb3aH7MuMO/krvnUzl9OvuHZjCyicSKr2FBzxJ6PIwcL3j77wpmdq6LTBbegsOElmbc/tnhiKhqT5Ti5LfPp4Z5JCSKXv/Jh0p44B2FylrXCQY7PDNtDVSuKFqBfcZT5Gokhf3tShD1YVpFJzA0jdOJzxzQJh2Gt7eh3xIacNoDbe4N+FpH2428HCAvu0XCAf8HsKztIvt/CKp7plgj1eRu x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM7PR03MB6325.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(346002)(376002)(39860400002)(136003)(396003)(86362001)(91956017)(6512007)(26005)(31686004)(66556008)(76116006)(66446008)(36756003)(4326008)(31696002)(66946007)(66476007)(6506007)(54906003)(110136005)(316002)(83380400001)(53546011)(122000001)(2906002)(71200400001)(38100700002)(478600001)(8936002)(186003)(6486002)(38070700005)(5660300002)(8676002)(64756008)(2616005)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?SEVJcTNFV0V5bTBOSDgrOFlMOXk3Y0ViN1BzMTI3Rm5FeUF3dE43UzZ1WXRp?= =?utf-8?B?MEpYLzY0VGozMGxlelVzNEI0dGtObTdQUEVySnR2ZTFBYlIvbXVHUUhVRUtP?= =?utf-8?B?VDUyeldabWlUMkRqdXB0L0dIcjlYOHZnUzJRK1BVSjlLVkJ5S2VBQTdwcm85?= =?utf-8?B?L1lDWllLWW02V0svYjZjenlQQzIzYm5CdkgwL1ZwRlVzMU9DWC9vbEUrQ2hS?= =?utf-8?B?cGZkUHBsT0pRaWtsZWptWDZ3dCtINTNyVmVCb0R6YkdXcE05dzYxeFNmcjhS?= =?utf-8?B?L2RubDU4aGlRWEdIU2N3N3puNGNGRFZMa1d6N1gwbTRVWUVWM1J5SlVtSTM0?= =?utf-8?B?RnF3ai8wUUJvUjI5SysrSlYyV29teFN6UUlLaXNnbUpnVjJucVQ1MjdwdFps?= =?utf-8?B?RTdwZGFkN2Y0cWE5ZFlvbE02YlZHd2JVWjNkUnZrdlZWaWJuZ1JDWW9zTGhT?= =?utf-8?B?dGFQYS9UVCtXZjJkL1BvZzRJYitrODgvM0N4RkdqOXNlVnhQWnV2NFRpT2hR?= =?utf-8?B?RlBEVjIwRzRrK0hIYmhNckFoWnFvcGtyZndDaTY5Y1Q4aFRzQUxERkFzVnR6?= =?utf-8?B?RytFZC9lNnJmcHdYY3Z5aFdSMXBqUG1Hdlk0bTcxeXh5UlNMby8rNUlTUGtC?= =?utf-8?B?MXFTS2xFcFV2N1BzazNtR1dFWm96STRRU3g5UDRBeWwyeklyejdIVG5PMzND?= =?utf-8?B?K3Z1c1I4bHFrYjdWdm56Nm40ckFVSFBwOW5oVDNhSW9RemNTWitmTnVhL01w?= =?utf-8?B?MzBPUGEvQ0FxYnV3dDVNMFBGOTg5OWRCTHZRT1I2V0FsOUxHblA5a3hzektk?= =?utf-8?B?aGgxUkw5enJaYlZrYllMMWtyVWkyQkU5aDdTL3BXTzdlNVFJb1U5Q2gzWlhI?= =?utf-8?B?dnJWMTc4Wmk2dURMZTY5UkxTSjkvSVVudWFOaUM3d1ByMUY5aGpKWGlmT1VJ?= =?utf-8?B?RWU4b1JjOWNhSEN2cUFpdmlBVHdUZERmSDFxcG9jNTZpSS80RFRNNVdPZk9O?= =?utf-8?B?NkVrRjU4NW9wMnh4RTQzcW9YWkZIS2J6YUZkQ080ODJFTmM3MjhRSGR4UVpm?= =?utf-8?B?c1NTR0J0Y3R6dytMZU5JTmFva1Yyci9IVXZRL1QrWFZneSs5QWY3ZlJndDV3?= =?utf-8?B?VzJoQXhiL2gzWTJ2bGNva3g4ZTcvSE1DaWQ4cE43YjZsTDg0WEFRZXFzY2Fm?= =?utf-8?B?cklGZytyT3FVN1VYVnZPZWlUNjBBTFFhTGxsa2M4eENjbzdWdlZaaGcwNHQz?= =?utf-8?B?NE9wNWV5RjVLY0RGc01tYi9wenhxS0w4OG1wRGVOL2I5OW50STEydENidy9y?= =?utf-8?B?bUxtOXdSTDhMNksySUVXQnZpWDc3UXlLTHZRdVpQUmx2SW9zNmxrdlNKRU5j?= =?utf-8?B?aFIyWWpEZ0NNdGJMb2JSOGtDNFJST01QczN6YmFGNHZXSEY0MlVrZ1NhMW16?= =?utf-8?B?RndmVEtzcTcrQ2E1NTJsWXZyaFYxTUloU1dneWJjYjZtRkJrK25sZ2ZTbkZU?= =?utf-8?B?TTlUai9PYmVOaFF4M0JibkF3SzlPRk83clhVOURCZ3ROQ2VvS2FFKzd1S1Bu?= =?utf-8?B?YUJ4UmpOckR1cE5LdnR5QU5SYk5MTHlEeHlsVXUyb3IvQjRiZVlKS2tQWDV1?= =?utf-8?B?M3c4ZEFDUURTQkd3SlN0cERPYmJhV3VQa3Jiem1ZTXNZVnJUcGlYSHZxbWtL?= =?utf-8?B?eFlXTENKdmpWUUhqTVY1WWxlMWsydEhUSkY2ditpQXltcXRPVEtJNzlUcGgv?= =?utf-8?Q?EZnJBRRwOWekLxsQUwU9i5yf58AW3cTMmbz3+v0?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: epam.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM7PR03MB6325.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 47fbaf89-b629-4a2c-c6c6-08d971e52cfd X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Sep 2021 09:52:16.4878 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: T0Aiqn7dKBW2mZoOWh6C0jmvZajLWT1aAjsup6G65xR6duyNsIdJciBjVHD3+bOQh90E0GBMIENqC9hZbyyxu/A8Bf42vrp5vqCD7o/OvvNNJ7W7XaeG0wfMaDTWA5EZ X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR03MB6327 X-Proofpoint-ORIG-GUID: YLtnS5ThGfSCc62F1oTtxLjhQ7D_RJJz X-Proofpoint-GUID: YLtnS5ThGfSCc62F1oTtxLjhQ7D_RJJz X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.391,FMLib:17.0.607.475 definitions=2021-09-07_03,2021-09-03_01,2020-04-07_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 impostorscore=0 malwarescore=0 lowpriorityscore=0 spamscore=0 mlxlogscore=999 suspectscore=0 mlxscore=0 bulkscore=0 priorityscore=1501 phishscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2108310000 definitions=main-2109070065 DQpPbiAwNy4wOS4yMSAxMjoxOSwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDA3LjA5LjIwMjEg MTE6MDcsIE9sZWtzYW5kciBBbmRydXNoY2hlbmtvIHdyb3RlOg0KPj4gT24gMDcuMDkuMjEgMTE6 NDksIEphbiBCZXVsaWNoIHdyb3RlOg0KPj4+IE9uIDA3LjA5LjIwMjEgMTA6MTgsIE9sZWtzYW5k ciBBbmRydXNoY2hlbmtvIHdyb3RlOg0KPj4+PiBTbywgaWYgd2UgaGF2ZSBhIGhpZGRlbiBQQ0kg ZGV2aWNlIHdoaWNoIGNhbiBiZSBhc3NpZ25lZCB0byBhIGd1ZXN0IGFuZCBpdCBpcyBsaXRlcmFs bHkgdW50b3VjaGVkDQo+Pj4+IChub3QgZW5hYmxlZCBpbiBEb20wKSB0aGVuIEkgdGhpbmsgdGhl cmUgd2lsbCBiZSBubyBzdWNoIHJlZmVyZW5jZSBhcyAiaG9zdCBhc3NpZ25lZCB2YWx1ZXMiIGFz DQo+Pj4+IG1vc3QgcHJvYmFibHkgdGhlIGNvbW1hbmQgcmVnaXN0ZXIgd2lsbCByZW1haW4gaW4g aXRzIGFmdGVyIHJlc2V0IHN0YXRlLg0KPj4+IFdoYXQgbWVhbmluZyBvZiAiaGlkZGVuIiBkbyB5 b3UgaW1wbHkgaGVyZT8gRGV2aWNlcyBwYXNzZWQgdG8NCj4+PiBwY2lfe2hpZGUscm99X2Rldmlj ZSgpIG1heSBub3QgYmUgYXNzaWduZWQgdG8gZ3Vlc3RzIC4uLg0KPj4gWW91IGFyZSBjb21wbGV0 ZWx5IHJpZ2h0IGhlcmUuDQo+Pj4gRm9yIGFueSBvdGhlciBtZWFuaW5nIG9mICJoaWRkZW4iLCBl dmVuIGlmIHRoZSBkZXZpY2UgaXMgY29tcGxldGVseQ0KPj4+IGlnbm9yZWQgYnkgRG9tMCwNCj4+ IERvbTBsZXNzIGlzIHN1Y2ggYSBjYXNlIHdoZW4gYSBkZXZpY2UgaXMgYXNzaWduZWQgdG8gdGhl IGd1ZXN0DQo+PiB3aXRob3V0IERvbTAgYXQgYWxsPw0KPiBJbiB0aGlzIGNhc2UgaXQgaXMgZW50 aXJlbHkgdW5jbGVhciB0byBtZSB3aGF0IGVudGl0eSBpdCBpcyB0byBoYXZlDQo+IGEgZ2xvYmFs IHZpZXcgb24gdGhlIFBDSSBzdWJzeXN0ZW0uDQo+DQo+Pj4gICAgY2VydGFpbiBvZiB0aGUgcHJv cGVydGllcyBzdGlsbCBjYW5ub3QgYmUgYWxsb3dlZA0KPj4+IHRvIGJlIERvbVUtY29udHJvbGxl ZC4NCj4+IFRoZSBsaXN0IGlzIG5vdCB0aGF0IGJpZywgY291bGQgeW91IHBsZWFzZSBuYW1lIGEg ZmV3IHlvdSB0aGluayBjYW5ub3QNCj4+IGJlIGNvbnRyb2xsZWQgYnkgYSBndWVzdD8gSSBjYW4g dGhpbmsgb2YgUENJX0NPTU1BTkRfU1BFQ0lBTCg/KSwNCj4+IFBDSV9DT01NQU5EX0lOVkFMSURB VEUoPyksIFBDSV9DT01NQU5EX1BBUklUWSwgUENJX0NPTU1BTkRfV0FJVCwNCj4+IFBDSV9DT01N QU5EX1NFUlIsIFBDSV9DT01NQU5EX0lOVFhfRElTQUJMRSB3aGljaCB3ZSBtYXkgd2FudCB0bw0K Pj4gYmUgYWxpZ25lZCB3aXRoIHRoZSAiaG9zdCByZWZlcmVuY2UiIHZhbHVlcywgZS5nLiB3ZSBv bmx5IGFsbG93IHRob3NlIGJpdHMNCj4+IHRvIGJlIHNldCBhcyB0aGV5IGFyZSBpbiBEb20wLg0K PiBXZWxsLCB5b3UndmUgY29tcGlsZSBhIGxpc3QgYWxyZWFkeSwgYW5kIEkgZGlkIHNheSBzbyBi ZWZvcmUgYXMgd2VsbDoNCj4gRXZlcnl0aGluZyBleGNlcHQgSS9PIGFuZCBtZW1vcnkgZGVjb2Rp bmcgYXMgd2VsbCBhcyBidXMgbWFzdGVyaW5nDQo+IG5lZWRzIGF0IGxlYXN0IGNsb3NlbHkgbG9v a2luZyBhdC4gSU5UWF9ESVNBQkxFLCBmb3IgZXhhbXBsZSwgaXMNCj4gc29tZXRoaW5nIEkgZG9u J3QgdGhpbmsgYSBndWVzdCBzaG91bGQgYmUgYWJsZSB0byBkaXJlY3RseSBjb250cm9sLg0KPiBJ dCBtYXkgc3RpbGwgYmUgdGhlIGNhc2UgdGhhdCB0aGUgaG9zdCBwZXJtaXRzIGl0IGNvbnRyb2ws IGJ1dCB0aGVuDQo+IG9ubHkgaW5kaXJlY3RseSwgYWxsb3dpbmcgdGhlIGhvc3QgdG8gYXBwcm9w cmlhdGVseSBhZGp1c3QgaXRzDQo+IGludGVybmFscy4NCj4NCj4gTm90ZSB0aGF0IGV2ZW4gZm9y IEkvTyBhbmQgbWVtb3J5IGRlY29kaW5nIGFzIHdlbGwgYXMgYnVzIG1hc3RlcmluZw0KPiBpdCBt YXkgYmUgbmVjZXNzYXJ5IHRvIGxpbWl0IGd1ZXN0IGNvbnRyb2w6IEluIGNhc2UgdGhlIGhvc3Qg d2FudHMNCj4gdG8gZGlzYWJsZSBhbnkgb2YgdGhlc2UgKHBlcmhhcHMgdHJhbnNpZW50bHkpIGRl c3BpdGUgdGhlIGd1ZXN0DQo+IHdhbnRpbmcgdGhlbSBlbmFibGVkLg0KDQpPaywgc28gaXQgaXMg bm93IGNsZWFyIHRoYXQgd2UgbmVlZCBhIHlldCBhbm90aGVyIHBhdGNoIHRvIGFkZCBhIHByb3Bl cg0KDQpjb21tYW5kIHJlZ2lzdGVyIGVtdWxhdGlvbi4gV2hhdCBpcyB5b3VyIHByZWZlcmVuY2U6 IGRyb3AgdGhlIGN1cnJlbnQNCg0KcGF0Y2gsIGltcGxlbWVudCBjb21tYW5kIHJlZ2lzdGVyIGVt dWxhdGlvbiBhbmQgYWRkIGEgInJlc2V0IHBhdGNoIg0KDQphZnRlciB0aGF0IG9yIHdlIGNhbiBo YXZlIHRoZSBwYXRjaCBhcyBpcyBub3csIGJ1dCBJJ2xsIG9ubHkgcmVzZXQgSU8vbWVtIGFuZCBi dXMNCg0KbWFzdGVyIGJpdHMsIGUuZy4gcmVhZCB0aGUgcmVhbCB2YWx1ZSwgbWFzayB0aGUgd2Fu dGVkIGJpdHMgYW5kIHdyaXRlIGJhY2s/DQoNCj4NCj4gSmFuDQo+DQpUaGFuayB5b3UsDQoNCk9s ZWtzYW5kcg0K From xen-devel-bounces@lists.xenproject.org Tue Sep 07 10:01:30 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 10:01:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180715.327479 (Exim 4.92) (envelope-from ) id 1mNXuv-0008Av-2H; Tue, 07 Sep 2021 10:01:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180715.327479; Tue, 07 Sep 2021 10:01:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNXuu-0008Ao-Uz; Tue, 07 Sep 2021 10:01:24 +0000 Received: by outflank-mailman (input) for mailman id 180715; Tue, 07 Sep 2021 10:01:24 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNXuu-0008Ai-0M for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 10:01:24 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNXul-00019S-DD; Tue, 07 Sep 2021 10:01:15 +0000 Received: from [54.239.6.187] (helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1mNXul-0000A5-6A; Tue, 07 Sep 2021 10:01:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=PkCgRNrbFPgPtKA37oxT20cFd+oz/vvNiad1HjOCvq0=; b=GV/ghNPTj7NjTiTquDGTwIIuK3 wHp+5s0AAtFICUwV6aX8CXeqpg8pNsNqw6jSWj0C248h9LtaaLOHaGk6rA11l5GW2uzkdB7kYFADy W6efVik1PCy1enFFxYA1QfdowzGGbOLUXpvl8qFaauFHQVxeJq1w2IcaRE35MvORsOTo=; Subject: Re: [PATCH v1 01/14] xen/pci: Refactor MSI code that implements MSI functionality within XEN To: Rahul Singh Cc: xen-devel , Bertrand Marquis , Jan Beulich , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , George Dunlap , Ian Jackson , Stefano Stabellini , Paul Durrant , Daniel De Graaf , "Daniel P. Smith" References: <9022cf38-532f-05bd-d78d-50f46cdbd8f5@xen.org> <4909CE53-15AE-4A6D-A32D-69B5E6AC6DDD@arm.com> From: Julien Grall Message-ID: <10505763-238a-1a9b-88cc-b19312a16e44@xen.org> Date: Tue, 7 Sep 2021 11:01:12 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <4909CE53-15AE-4A6D-A32D-69B5E6AC6DDD@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit On 19/08/2021 15:16, Rahul Singh wrote: > Hi Julien, Hi Rahul, Sorry for the late reply. >> On 19 Aug 2021, at 1:18 pm, Julien Grall wrote: >> >> Hi Rahul, >> >> On 19/08/2021 13:02, Rahul Singh wrote: >>> MSI code that implements MSI functionality to support MSI within XEN is >>> not usable on ARM. Move the code under CONFIG_HAS_PCI_MSI flag to gate >> >> Can you clarify what you mean by not usable? Is it because we lack of support or we have no plan to use it? > > We have no plan to use it. Code moved to CONFIG_HAS_PCI_MSI will only be required for ARM if we I read "not usable", as the code doesn't yet work on Arm. This is quite possible, but from you wrote the main reason is that the code is not necessary yet (see below) on Arm. > decide to support PCI device access (PCI MSI interrupt support) within XEN. As of now, we are planning > to add support for PCI device access for DOM0/DOMU guests not for XEN. This is probably going to happen sooner rather than later as, AFAICT, there are SMMUs out which signals using MSIs. But, AFAICT, this code would also be used if we need to manage the MSIs in Xen on behalf of the guest (such as if the platform is using GICv2m). That said, I would be fine with gating the MSI code behind a new config. However, I think the commit message wants to be clarified into why we don't need the option. Maybe something like: "On Arm, the inital plan is to only support GICv3 ITS which doesn't require us to manage the MSIs because the HW will protect against spoofing. Introduce a new option XXXX to protect the MSI code. " Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Sep 07 10:04:43 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 10:04:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180721.327490 (Exim 4.92) (envelope-from ) id 1mNXy6-0000OC-IB; Tue, 07 Sep 2021 10:04:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180721.327490; Tue, 07 Sep 2021 10:04:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNXy6-0000O5-EM; Tue, 07 Sep 2021 10:04:42 +0000 Received: by outflank-mailman (input) for mailman id 180721; Tue, 07 Sep 2021 10:04:40 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNXy4-0000Nz-Rn for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 10:04:40 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 8c641a18-2079-4ef0-b785-ddea4c9fce01; Tue, 07 Sep 2021 10:04:39 +0000 (UTC) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05lp2110.outbound.protection.outlook.com [104.47.17.110]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-9-hpqGuoH9PGq115orbvAkig-1; Tue, 07 Sep 2021 12:04:37 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR04MB6861.eurprd04.prod.outlook.com (2603:10a6:803:13c::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14; Tue, 7 Sep 2021 10:04:36 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4500.014; Tue, 7 Sep 2021 10:04:36 +0000 Received: from [10.156.60.236] (37.24.206.209) by PR3P189CA0086.EURP189.PROD.OUTLOOK.COM (2603:10a6:102:b4::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14 via Frontend Transport; Tue, 7 Sep 2021 10:04:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8c641a18-2079-4ef0-b785-ddea4c9fce01 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1631009079; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=mESkZMCn3zmsbiDZ07Z3XiuHmv0bzZgcJCIsETD9bV4=; b=f9te18dHO8t7eLXe6jKnWru5DmTbFdpaqOanYQOAK/1Ki+v7RUdsnr6jzD6IlHl+x3cbwW 6nfYDgOasNNen5DFzxQrk0Sj73GVnhAyPWoL/kYIvndiqCoDe2c3rsM51qAh7MEk9+IS07 +7psCLuIGL+JJbr1cJOOHY+FmQ9QANU= X-MC-Unique: hpqGuoH9PGq115orbvAkig-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FBFcSFwxe8k9APKb6ChixWW5QTh3KUK3lQrk/5ZSjQzECd983whDtHVuXV+zVKW3hLWUTZYNZQ9ibCDanbCTJ93aBRVDLYcxCHUlEyOBl8f3ZhZJ2DD8zJ7ijJblnMNH7C25LN3d//X65rooVLtr4ZXBgKbnmuouQh8JQOj1kpinW0Ve9UBRmo/MgYJgSX3TMYiOaloEOclRIW/YnjwAGZUg+4h3bc0adJEKyl92UkdDjUx2eaSSnFoI22Hb/gwaVMYD+x9mPFZFsIWtDZwMqQPD7v7Ys9O6qqZalJlhF39PVdOsVDn9sxR8Oy+A4pQRzHagpwNkYDsMAzRIDCngPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=mESkZMCn3zmsbiDZ07Z3XiuHmv0bzZgcJCIsETD9bV4=; b=OJWnPLAL1KTnRcJZuu48HMMOASP8nA6t5tNHyXgJIZkMuEFwwbiMnLfqz7rWylxbJrNj2HpnhQ9e+gL+f3/4wfsR/rlkPa2erXsW0TCpnevVHY10YH3Nc0Khtgpa+X5ZlqCCGHMDBqrCz0AzFmIDckWUxd6lYysjv3nTHeJLT9U29m2VPikckQ/Gn9TBngC94rXbjWxd3j8NQcV0R55ksXRGcPe8VdIxoVcT17iVvOSfOQ58xr1UbchOBHHfSnCsINO2oYqPYTUjiZk1EaapZLR8ZIxwVLxKlqvNeN3u1f/z6vFQ5Z9x2tZFWHBA6U2YDiuipOnXXTQ1b7Lg2pUsUg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com; To: Juergen Gross , Boris Ostrovsky Cc: Stefano Stabellini , lkml , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , "xen-devel@lists.xenproject.org" From: Jan Beulich Subject: [PATCH 0/9] xen/x86: PVH Dom0 fixes and fallout adjustments Message-ID: <4efa804e-3250-227f-00c7-347581366cd4@suse.com> Date: Tue, 7 Sep 2021 12:04:34 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PR3P189CA0086.EURP189.PROD.OUTLOOK.COM (2603:10a6:102:b4::31) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3f7bf4a6-61b8-4bae-9838-08d971e6e5de X-MS-TrafficTypeDiagnostic: VI1PR04MB6861: X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2HFuW6qjrpDU+nMRA4sqT+UmRulKiRMvir2UGiWWhZJVi+TyTBfaarxs2jLscRYOX5OtsWFqOt7FbB4P0DYcKn9DufThRExjmgt7Qm7vaEUR8A/OhixtQbLZMnp3Ak8n/PLU1U/z1fFfgYKCiqhgHJJQxeqdRg8f5AcX19KkPEw9Ws2AZ0GKrAxnesGTzL9ASdZP60khriLDDb5CI1igK1JHMJ3b5Ub+gKrCUUQ52grVKgsLqKkB9kubmo7d4D+DKC1lYi6j8Z30pW4DCZneL4oroOkFrSZIylgOxiOJlI7yGbYKyo8lJEMSRKCccNyPmRBYFUYxPqtHFLUzVgap5PEARjmd6OfMvtqWQh2Z5iUQuJOiUipIX1WFt3GGBuN3WS1EzZySj4k3ZTj0ZgXDUZjzwb8pjZ8YWMRdrdT3EZuvXq2ci4tt4R4OGLc1wI89PN32cXBq0c06CjKCY0pT0LwIYTsxDb9uhx3Ip+qlj1sEd/AyOO6rkK8dCoO/PrM/a/udwDKVwft+fYsuThECxK1ml9beKZct7g06RzHyTGqktSzoHTB+lmT8Mh0sYUWT6nvSA+g05bKDWgF74YHCVPpPa90mH9o0jMHEbGK4tc8cKWIMAQMYGRLAZ84HdklWRmczRpOMXyqRLamPT2idtD2MtaiQQViYst8nF8Zu8eh3gMTsX14UfN4TAlF7qLfBWu7663XALdWvltHnjoN1gQdfj7A2uhKI5Mgoq5Oa1anf14sfQpYuXs8BB5Oy73ZA X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(39860400002)(136003)(396003)(376002)(366004)(346002)(316002)(16576012)(54906003)(83380400001)(86362001)(2906002)(31696002)(110136005)(6486002)(478600001)(36756003)(38100700002)(4326008)(31686004)(186003)(26005)(66476007)(66556008)(8676002)(66946007)(8936002)(956004)(5660300002)(2616005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VlJSSjlBZ09IbHV2Z0NoZXZzS2M0eGxYb0JLeTlyR0V5QkJZT25RUkcrNDVN?= =?utf-8?B?QjBHUEVOaFIyYVlMT1lWSFBPN2V5MC9wV3EvUUU5MzhSWmpmcmcyakIrck5z?= =?utf-8?B?U25yRE9QbmNIaHRvazYyc1FsUDFaaWR5cUtGdzFmREQzV0pVTWhRVU5lRzV0?= =?utf-8?B?TWlWVmZRMkx0bFNjSzBLdHdWbEZwak55K1Q3czRZWVVpcDl4aGFYUERqUnBw?= =?utf-8?B?dXpuZVJ1S01qZVEwaTdXK0lsUkMyeWwvRHRxbkVLZW96M0Z3N0lsWjdnbG9Z?= =?utf-8?B?NDRiclFMRjRSNjB4NkI4WDJydUUyL3VYOG5hYThHWEZWbUxhQjl2ZlZBeVZX?= =?utf-8?B?QXZHR0VMcHRNR1RRNHl5R2xhbGJqZW1udnJ3ZndleEIvSWlCK2hvUlhTa3dE?= =?utf-8?B?a1FmaWoyTFBMNENRYXRnTVRSNnROTHRkZlY4dnZUVjlQQkZGbTVDeUJTK3Bq?= =?utf-8?B?Q25TZCtJU0RwQTA2cGcxL1JIUnZDUHlsRFV1cW9oTnRwalZnQzZKdUx1aGFj?= =?utf-8?B?N0x2T3RwcmtsbENPQlZrSTBFOS9kNzNQTHBpZ0xubERmc0p6USs0R0duR3d1?= =?utf-8?B?QkZOZWdVSDJoZHZlMnUxKzhwOXZpYjRRNnV1ZVNRU1crVFA5ZS90OTh1SUFU?= =?utf-8?B?cEgvSHVSb21BOHgzM2FlSEdFdHZtSXlKQmFUQVo5NFFQVS9CcWQrRjZ3R2dk?= =?utf-8?B?bmVXelU4UGlIMUVuRTZuQnY2NkNwRzRIUzFpZnc5bWMzdktIMWtQZW9QdHpl?= =?utf-8?B?TFlNNXphT1g0Q2dJTTlqZi9zblk0WEdaTVFsRnVxVThlNDJzaUtVbU1WVnpP?= =?utf-8?B?ZGRqbGhUZjh4YUJ1ZjNERmFiUjl4QjM3cWMrZXFtMXBiZXhPdjg0aWp4OVpB?= =?utf-8?B?cWc0b2tXQ2wvWlV0dEJQcjlxUU5QQ0orVzhmUU1LaldXcXNCQkpjcVNUbDgx?= =?utf-8?B?MVdYSGR6UkNmL2FmYk1vRlFRaHhNTGRjaWpUWTVMUEhENXFZNk02WWlGS2R1?= =?utf-8?B?dVNmVDlwUmFXQTBITUhQZzlzOXE3MStVcXVkRWduYWxNSXpYUUxLMDhBUG5J?= =?utf-8?B?OHROU3RTKzlHa3c4UzVSaUlGQytHOWVXZFFOVnZkQzRQUERjaGsraDFWVnF6?= =?utf-8?B?ZHhpcTZHcWVXbkdrNjFuRmFoY0duODhSTk1xRmtZbTdVWDNhRkxPeUpSczFj?= =?utf-8?B?bzlldTF1em04TnM4VWFNbCtSZktOSzhKck1GWGFHaFMzWXJRc2pBV1ZNaEM5?= =?utf-8?B?TEx0ZjAxS2dFUTJGNDZSRVhsanRFS1hCd1YzdFAvekQvOU5lN0xCcFFTY0t4?= =?utf-8?B?U2JPOC9sVHU3MC9ySXduU2J0SUdMU2wwKzFnZXFmL3hrdWtyWkpkbXBpRTNH?= =?utf-8?B?Qjd2UUMvY3JzQUFhdHU2TUNvdGJQN2VtbkhiZXhPbVBXa1FDeEJQL2hNZkc0?= =?utf-8?B?cDFsejdWd1dPaEFIZnVsbW9CL1ZDOVhhaFRJZVdteUhkeTRQaHhjMTVTaWEv?= =?utf-8?B?dEwydG1Ydjc4M29XZEFFaGxZeG5WendIOFdKUm9admFodllESVJhTDhNRzFZ?= =?utf-8?B?K2dmOXN1SkZ1RjJBRWhBbklvb2oxVStteUN5am8xa0hDRnZvUXYvVVB2TCsy?= =?utf-8?B?ejNJb21XeWV4MzArejRZNHYreEpaZWE5cXFScTlFOUI4VjgyU2hiMU1IQW1y?= =?utf-8?B?MTFWcXRoVC8xUWxWZldZSnI1NzdUaWpySGFta2VjWHFmM2t3RjUvNzdyRGNU?= =?utf-8?Q?t/TZlfT7VPwDUXdKhEkGyH+b5fvEBIJB5aqBUYh?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3f7bf4a6-61b8-4bae-9838-08d971e6e5de X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2021 10:04:36.3542 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: jUdCjTt80pqdIGPC1zPRU8QD1iXXM9sL+g3kvZyTWuaPBXu9MbyA21lMB215uSiHDcysixCMNOPLx3hCRfwWkQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6861 In order to try to debug hypervisor side breakage from XSA-378 I found myself urged to finally give PVH Dom0 a try. Sadly things didn't work quite as expected. In the course of investigating these issues I actually spotted one piece of PV Dom0 breakage as well, a fix for which is also included here. There are two immediate remaining issues (also mentioned in affected patches): 1) It is not clear to me how PCI device reporting is to work. PV Dom0 reports devices as they're discovered, including ones the hypervisor may not have been able to discover itself (ones on segments other than 0 or hotplugged ones). The respective hypercall, however, is inaccessible to PVH Dom0. Depending on the answer to this, either the hypervisor will need changing (to permit the call) or patch 2 here will need further refinement. 2) Dom0, unlike in the PV case, cannot access the screen (to use as a console) when in a non-default mode (i.e. not 80x25 text), as the necessary information (in particular about VESA-bases LFB modes) is not communicated. On the hypervisor side this looks like deliberate behavior, but it is unclear to me what the intentions were towards an alternative model. (X may be able to access the screen depending on whether it has a suitable driver besides the presently unusable /dev/fb based one.) 1: xen/x86: prevent PVH type from getting clobbered 2: xen/x86: allow PVH Dom0 without XEN_PV=y 3: xen/x86: make "earlyprintk=xen" work better for PVH Dom0 4: xen/x86: allow "earlyprintk=xen" to work for PV Dom0 5: xen/x86: make "earlyprintk=xen" work for HVM/PVH DomU 6: xen/x86: generalize preferred console model from PV to PVH Dom0 7: xen/x86: hook up xen_banner() also for PVH 8: x86/PVH: adjust function/data placement 9: xen/x86: adjust data placement Jan From xen-devel-bounces@lists.xenproject.org Tue Sep 07 10:05:07 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 10:05:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180725.327501 (Exim 4.92) (envelope-from ) id 1mNXyV-0000w9-RN; Tue, 07 Sep 2021 10:05:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180725.327501; Tue, 07 Sep 2021 10:05:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNXyV-0000w2-Nk; Tue, 07 Sep 2021 10:05:07 +0000 Received: by outflank-mailman (input) for mailman id 180725; Tue, 07 Sep 2021 10:05:06 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNXyU-0000ue-4w for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 10:05:06 +0000 Received: from mx0b-0039f301.pphosted.com (unknown [148.163.137.242]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 129d972a-0fc3-11ec-b0e1-12813bfff9fa; Tue, 07 Sep 2021 10:05:04 +0000 (UTC) Received: from pps.filterd (m0174681.ppops.net [127.0.0.1]) by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 1879h7RO005781; Tue, 7 Sep 2021 10:05:02 GMT Received: from eur05-db8-obe.outbound.protection.outlook.com (mail-db8eur05lp2106.outbound.protection.outlook.com [104.47.17.106]) by mx0b-0039f301.pphosted.com with ESMTP id 3ax2jngtf4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 07 Sep 2021 10:05:01 +0000 Received: from AM7PR03MB6325.eurprd03.prod.outlook.com (2603:10a6:20b:13c::18) by AS8PR03MB7143.eurprd03.prod.outlook.com (2603:10a6:20b:23e::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.17; Tue, 7 Sep 2021 10:04:59 +0000 Received: from AM7PR03MB6325.eurprd03.prod.outlook.com ([fe80::d9b7:c0ab:2c2f:5b44]) by AM7PR03MB6325.eurprd03.prod.outlook.com ([fe80::d9b7:c0ab:2c2f:5b44%3]) with mapi id 15.20.4478.025; Tue, 7 Sep 2021 10:04:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 129d972a-0fc3-11ec-b0e1-12813bfff9fa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ayg+E8KbkwmM/To98WalRkwreO+Jsd6A+YUrsNzqgMfpfHN1QJnwQArMvKHqhIe0sCOGGBGOPnge+gYWcJNLVS5KA2mMRrMSJMhKF7qtQfEcujPYajHWhaMpdm+mRdspGSb3hsyZNlINjIbyP9a8Sq8mKwf45mydQ+d+Pjw2M22nu2Y4Q6d/N5vsCbiwK0zOmgT0C7gF5Ia9k+emuZFM76IqPrA6Lh/URBYz5LqRGFVv/SEx0fqNUGb+TtSQtPr3qaE9TFYsBaT7fhlJ2fWbu9dLiTi96xfJMOxSiVt1XMSgBeYDoWRE+ZPJ7SFO/vKSAJ5kiPIDNV4fSKbht88RGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=/TQLdNk+Reu+foPLnB0xZnQ6fPvTin+Fuvfe22LzTIA=; b=ogkdl417/AE/+0h6wxo3Nt++pni2qrzHHSPjHPO5hs/39SowMTII0VBv1yDt4Glj68ZN0ZCug5mbz731uEJyjjjUbrMHTLIPX8C534sCTSQSQff7wymIkmWS1mudcvhc/bxSGvBng5ogsVDcwJowfnGHQpw930l144cAGnrlNnQgn+QOesTI7y/XTixafbY4MXnDoUPiSGzlIehsrN/NFxdsNb8x6arJg4T5E/BWMeLslEcRgQzBJeJnu6YOiif2kAVtZy29V8xmlGkEvuhoX+7EkiW7O0NpBCDlTIDIAoJlI3aH5fjdM/tVWVMXwJzUgeEcnyVMdEEN5CH+vKVo4Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/TQLdNk+Reu+foPLnB0xZnQ6fPvTin+Fuvfe22LzTIA=; b=LkiCAsqVH+bGUx7o/BahbNM8k7E1C3mLq9UV/ff4M0pjfR4Bmri0bpuaIhMus4zECeTAkY9FtqsIYPO2k1r+9qpmp3BBEYUyUTtHS9VNOUhpquZdUx0YtF1tGaFLYar/VlHl1ea6SWby8kLLwZ/3crUtAJoFArjdcdm43jUf3xTFEVYqWO0dyDp2w2SYZNSJS1viPhj9pIzMgf9mWzriXIC50ZtZVmN07OSIaVC4DkLvNUJGs8F52G9NrN0rmanEK78KqjKVvX8epkXL/ui6Bkr2EXZ7iatDFemHSHWvZYem5OsNhX3bJUcruzCcCoejL3jr+EFRmkWbM6oRIPYuFQ== From: Oleksandr Andrushchenko To: Jan Beulich , Oleksandr Andrushchenko , =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= CC: "julien@xen.org" , "sstabellini@kernel.org" , Oleksandr Tyshchenko , Volodymyr Babchuk , Artem Mygaiev , Bertrand Marquis , Rahul Singh , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH 3/9] vpci/header: Move register assignments from init_bars Thread-Topic: [PATCH 3/9] vpci/header: Move register assignments from init_bars Thread-Index: AQHXoKwh6IBgDEFZ2k+LKlDV/Oq/mKuXC7EAgAFSlwA= Date: Tue, 7 Sep 2021 10:04:59 +0000 Message-ID: <218da10d-2280-4f15-4ede-b5fadcb8c59d@epam.com> References: <20210903100831.177748-1-andr2000@gmail.com> <20210903100831.177748-4-andr2000@gmail.com> <4007d84d-9e76-32df-58f6-af5ff26fdf6e@suse.com> In-Reply-To: <4007d84d-9e76-32df-58f6-af5ff26fdf6e@suse.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=epam.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 1029a4a1-8877-4620-33e7-08d971e6f3ba x-ms-traffictypediagnostic: AS8PR03MB7143: x-ms-exchange-transport-forked: True x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6790; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: gMV8TXCLUjV5f4GQOCYNGLik8bzWsYRiwSPS0QepALIwMsH6m1WEI0qWiaypF2vX3cjgwwfabjcWaV/qNNX/F70KVQ7V+uFmTODDcTSPAhEBK/hMPN3c+fOTkyeFOTpegojSUF0T1p6+l1kgooJCXDzQNHG7DbDjCgJ3NzqQl7q3aetiigcmkxcer0jQATSnInncnxJn/8V8DtzJsv/yKEO2ZmhbrYvYrfJ5LsYnwkq4Wzfb6i/FENTTMqLnDSXlqJV/8RQMCIdtwAQ81PMi4xbSDZVdYpOSJPUcgftBG0yBJNxQ831SCim0bJkDBu3rholf1u9VmJz5XOmnuWVFcLyRH8VI4ziP+Qu5xR6vzcewvSJg41lUES/7+sObL7Rbmp27fiO0pvDk1gn93+787KJzA7ToaLmzgNC670hcCEdHe6XZqgRv8cRVEdEg+dqveTuQhza4f6llx09lCouPKXyVE0afasuR+3uUpkIM5yxMNA/ASTFBFkykSqKRgahKfNtw1n5oGel5TWjKdIvOTS7zZSOaUBZzgHCL5WtbpjcR0y2XjwtdqDQN4wLt8VfWWSm1f42xfKGJkgoXId3yQOXDsBUaTtIfZ7grKFVlnWSATTsIKMe8IDlaICHMGUTROVn/P7bdtG4BdRhPc6OUFJ+bU2fUegmot+RwvbQo42cA+O7iqKs3QRx2BV9y1dAJUlCWwTNpadebhlu2HWQJRZe5+dOkxTaXPl0gk+/QDErKVbAUDcFWEGN419gUBhUO x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM7PR03MB6325.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(376002)(136003)(346002)(39860400002)(396003)(2906002)(8936002)(478600001)(8676002)(71200400001)(86362001)(38100700002)(2616005)(5660300002)(38070700005)(31696002)(4326008)(122000001)(76116006)(6486002)(91956017)(31686004)(53546011)(66556008)(66946007)(66446008)(64756008)(186003)(83380400001)(66476007)(36756003)(110136005)(54906003)(26005)(6512007)(6506007)(316002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?aFZRa29KbTZxUzNydUlhQ2h2NnJJQ3V0SjNEcURDK1VSVVdUV0VUZDRXb0ZL?= =?utf-8?B?QlpWd1NndlJxeWNuVEhHWnZya294UVlGME52TWxHdE1xYVd4RVowRDJTSUtW?= =?utf-8?B?M010MitmbStpaUtwdmZMOEN1TEhweS9CWERpU1gzRUpWVDN0bk1mTjNWNlAv?= =?utf-8?B?OW1sU2NrbWFnMTljbW15eTcrQWV5ZldWUXRYNlV2Z3B5Q2dWWmwyMXJsT0lt?= =?utf-8?B?QkN6TUc5V3ZXd0xveXlqSFdGMFVLMnNtb2hucEpILzNlSU9DOEdsUHM3S0xI?= =?utf-8?B?eUYraEg0ZTBsLzZWTklxUTZVbnNVUXErWlFGZ3dhTjJIMU1qczRkdmJlUkhZ?= =?utf-8?B?RG5mSk84SDY0bENnOE14RlBXTXVQd3JOeEdNWHdhTHRUVjhRbDhhQUpDZVdJ?= =?utf-8?B?b3NBd213Q3JrNnZsaDRUamhodVZhQmVQTzRNSkJVZUhjVWtpMlFMY0Q0azlK?= =?utf-8?B?SnNnVHRtVXRpNkZ2ZWpFY01GdGtMZmdEaEZjam1vNjRUZm55WnJkcVpBdnly?= =?utf-8?B?Y1FKS3BsZVZRcHdMWkM0b0tTcFl3ZnZmSXlUY05uR2wySHhmWit1V3l5MUJj?= =?utf-8?B?bnB3SGxXSnhPOUd2Z1A4a2pLWFFFKzg0OEFZOXBZMjY4UUpjK3N4MXdyR2Vv?= =?utf-8?B?QjJwU3A2MGVWcVdMN3JubTN1cStxNWtjQkJTVDIvcDZmc1RSc1p0T2NyZVl6?= =?utf-8?B?eDhDOGdkVHhPcVV5b1NYWndpM2M2azIyR3VEWnJrZE9zeXNyc1ZCSGJpR3M5?= =?utf-8?B?d3BEK0h6K2hla2Z1ZGFYK3pLUzBQN05kSmVodFo3NVI5T1R0TDZLWldtaGht?= =?utf-8?B?eDExQ0pHYXBpZW1MZStNS0lQZmpwbW9IZzk4dzV5ZlB1bkdlSUtnRDIrK3dC?= =?utf-8?B?UktHbDRmR3VRVjN3Zyt4TjIvRWlvUlNYZDdiWHZtNlZOL1BwYnkxbXdueEkr?= =?utf-8?B?eFFZTXd5MEhocmVKUDhwVndqTHZ3MXhNdTNGTm1Dc3dEdzBSYjJjNjhIMStm?= =?utf-8?B?RjRYOWlZVy9aYUlHZm9JaUVCSXkxQ3VBbW9ZVm9vK1ZqNVpGSHE2d1pEdm54?= =?utf-8?B?OTZqVTlIZzNRZERJbDB0Z2g1RHVHOTh6TVl2SzJQcmNQTDNjVXNTaCtXbHBF?= =?utf-8?B?UXRJWEorVjdoMit3UFRIdDhqMVF4QlBETHB2WmFEWHJGMEY0azFWZ0pHMDEw?= =?utf-8?B?WG9hS2JUWTFCbzdqTWZKd2s2NjYzaVhTQXNpdDhDY29oUTRwNi8vNDlyVGVN?= =?utf-8?B?Y2FSU01lZm52YkhrQjRVdGorSUl0NzQyRUpNd2hsRXkyY2hseEdlNHU2NDdO?= =?utf-8?B?a01xWVRmQ2c3NEVYMVd1cGNvMk1TNjhSSklydUY4V3RIaUdvZUF3U1hqb0RX?= =?utf-8?B?dG5jbVEyR210bWlLNUE4bFRGL283WWdZT2w3eFJVRS9ZdllleUdnNnY0REh6?= =?utf-8?B?amRjS0ZFeVBoejlhRmpWNW9YU3NLVHVKa0J1YXZtVE1RM2hLZGFJRlhNNnNw?= =?utf-8?B?OVlBVUxLVDhiL0NwSXE3N3R6dk8vSWdlVFRLY0dOWjhtV2xOQitJVmQvN2t3?= =?utf-8?B?Yklmc3VWMkcwWEZ2VHBna2dDd01pbkdDMysvREdQaSthcmY0bWZBOUV3UXEx?= =?utf-8?B?WER6bXFMOWozd2RYK1daMlVLcllsa0ZCblRXM3phdiswTlp3VDQvaDcvSnBu?= =?utf-8?B?dmQ2UFQ3VmlDaWh1UVZpWmE0UGl2SzdRMjlOV00wSHQvdkgrbERmcTc2WVdS?= =?utf-8?Q?HUnwe21BfJs596oqiQACyXFrwm9VA5BahQm3WQa?= Content-Type: text/plain; charset="utf-8" Content-ID: <7DEB72B1234C29479B61DD896A6910AC@eurprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: epam.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM7PR03MB6325.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1029a4a1-8877-4620-33e7-08d971e6f3ba X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Sep 2021 10:04:59.4103 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: JRSmn8T68mW3t0qHf94B3kpILE8lHDnhxYd0bXPvdecV6yqMOKV+o+9qQMd7khxKdLxWelIqml2AKbqBdE9T1vaalR3SfCEsssYv16jq21LuzvSDruqMLTLKmSyNZdgv X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR03MB7143 X-Proofpoint-ORIG-GUID: p4zJE7BS5DzZqRP-HuOsAJv7Lh9KXsnn X-Proofpoint-GUID: p4zJE7BS5DzZqRP-HuOsAJv7Lh9KXsnn X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.391,FMLib:17.0.607.475 definitions=2021-09-07_03,2021-09-03_01,2020-04-07_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 adultscore=0 clxscore=1015 priorityscore=1501 impostorscore=0 phishscore=0 spamscore=0 suspectscore=0 lowpriorityscore=0 mlxlogscore=999 bulkscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2108310000 definitions=main-2109070066 DQpPbiAwNi4wOS4yMSAxNjo1MywgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDAzLjA5LjIwMjEg MTI6MDgsIE9sZWtzYW5kciBBbmRydXNoY2hlbmtvIHdyb3RlOg0KPj4gRnJvbTogT2xla3NhbmRy IEFuZHJ1c2hjaGVua28gPG9sZWtzYW5kcl9hbmRydXNoY2hlbmtvQGVwYW0uY29tPg0KPj4NCj4+ IFRoaXMgaXMgaW4gcHJlcGFyYXRpb24gZm9yIGR5bmFtaWMgYXNzaWdubWVudCBvZiB0aGUgdnBj aSByZWdpc3Rlcg0KPj4gaGFuZGxlcnMgZGVwZW5kaW5nIG9uIHRoZSBkb21haW46IGh3ZG9tIG9y IGd1ZXN0Lg0KPiBJIGd1ZXNzIHdoeSBleGFjdGx5IHRoaXMgaXMgZ29pbmcgdG8gaGVscCBpcyBn b2luZyB0byBiZSBzZWVuIGluDQo+IHN1YnNlcXVlbnQgcGF0Y2hlcy4gVG8gYWlkIHJldmlldyAo aS5lLiB0byBub3QgZm9yY2UgcmV2aWV3ZXJzIHRvDQo+IHBlZWsgYWhlYWQpIGl0IHdvdWxkIGlt byBiZSBoZWxwZnVsIGlmIHlvdSBvdXRsaW5lZCBob3cgdGhlIHJlc3VsdA0KPiBpcyBnb2luZyB0 byBoZWxwLg0KDQpTdXJlLCB3aWxsIGRvIG5leHQgdGltZS4gVGhlIG5lZWQgZm9yIHRoaXMgc3Rl cCBpcyB0aGF0IGlzIGl0IGVhc2llciB0byBoYXZlDQoNCmFsbCByZWxhdGVkIGZ1bmN0aW9uYWxp dHkgKEJBUnMgaGVyZSkgcHV0IGF0IG9uZSBwbGFjZSBhbmQgd2hlbiB0aGUgc3Vic2VxdWVudA0K DQpwYXRjaGVzIGFkZCBkZWNpc2lvbnMgb24gd2hpY2ggaGFuZGxlcnMgdG8gaW5zdGFsbCwgZS5n LiBod2RvbSBvciBndWVzdCBoYW5kbGVycywNCg0KdGhpcyBmdW5jdGlvbiBpcyBleHRlbmRlZCB0 byBhY2NlcHQgYSBvbmUgbW9yZSBwYXJhbWV0ZXIsIGlzX2h3ZG9tLCBhbmQgYWxsDQoNCnRoZSBh c3NpZ25tZW50IGxvZ2ljIGlzIHB1dCBoZXJlLiBPZiBjb3Vyc2UgSSBjb3VsZCBoYXZlIGFsbCB0 aGUgImlmIChpc19od2RvbSkiJ3MNCg0KcHV0IGF0IHRoZSBvcmlnaW5hbCBsb2NhdGlvbiwgYnV0 IGRlZGljYXRlZCBmdW5jdGlvbiBsb29rZWQgY2xlYW5lciB0byBtZS4NCg0KPiAgIEFmdGVyIGFs bCAuLi4NCj4NCj4+IC0tLSBhL3hlbi9kcml2ZXJzL3ZwY2kvaGVhZGVyLmMNCj4+ICsrKyBiL3hl bi9kcml2ZXJzL3ZwY2kvaGVhZGVyLmMNCj4+IEBAIC00NDUsNiArNDQ1LDU1IEBAIHN0YXRpYyB2 b2lkIHJvbV93cml0ZShjb25zdCBzdHJ1Y3QgcGNpX2RldiAqcGRldiwgdW5zaWduZWQgaW50IHJl ZywNCj4+ICAgICAgICAgICByb20tPmFkZHIgPSB2YWwgJiBQQ0lfUk9NX0FERFJFU1NfTUFTSzsN Cj4+ICAgfQ0KPj4gICANCj4+ICtzdGF0aWMgaW50IGFkZF9iYXJfaGFuZGxlcnMoc3RydWN0IHBj aV9kZXYgKnBkZXYpDQo+IC4uLiB0aGlzIGZ1bmN0aW9uIG5hbWUsIGZvciBleGFtcGxlLCBpc24n dCBEb20wLXNwZWNpZmljLCBzbyBvbmUNCj4gbWlnaHQgZXhwZWN0IHRoZSBmdW5jdGlvbiBib2R5 IHRvIGdhaW4gY29uZGl0aW9uYWxzLiBZZXQgdGhlbiB0aGUNCj4gcXVlc3Rpb24gaXMgd2h5IHRo ZXNlIGNvbmRpdGlvbmFscyBjYW4ndCBsaXZlIGluIHRoZSBvcmlnaW5hbA0KPiBmdW5jdGlvbi4N Cg0KQW5zd2VyZWQgYWJvdmUuIEkgdGhpbmsgaXQgbWFrZXMgY29kZSBjbGVhbmVyIGFuZCBlYXNp ZXIgZm9yIG1vZGlmaWNhdGlvbg0KDQphcyBoYW5kbGVycycgYXNzaWdubWVudCBmb3IgQkFScyBi ZWNvbWVzIGdyb3VwZWQgYXMgaXQgaXMgZG9uZSBmb3IgTVNJL01TSS1YLg0KDQoNCj4NCj4+ICt7 DQo+PiArICAgIHVuc2lnbmVkIGludCBpOw0KPj4gKyAgICBzdHJ1Y3QgdnBjaV9oZWFkZXIgKmhl YWRlciA9ICZwZGV2LT52cGNpLT5oZWFkZXI7DQo+PiArICAgIHN0cnVjdCB2cGNpX2JhciAqYmFy cyA9IGhlYWRlci0+YmFyczsNCj4+ICsgICAgaW50IHJjOw0KPj4gKw0KPj4gKyAgICAvKiBTZXR1 cCBhIGhhbmRsZXIgZm9yIHRoZSBjb21tYW5kIHJlZ2lzdGVyLiAqLw0KPj4gKyAgICByYyA9IHZw Y2lfYWRkX3JlZ2lzdGVyKHBkZXYtPnZwY2ksIHZwY2lfaHdfcmVhZDE2LCBjbWRfd3JpdGUsIFBD SV9DT01NQU5ELA0KPj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgIDIsIGhlYWRlcik7DQo+ PiArICAgIGlmICggcmMgKQ0KPj4gKyAgICAgICAgcmV0dXJuIHJjOw0KPj4gKw0KPj4gKyAgICBp ZiAoIHBkZXYtPmlnbm9yZV9iYXJzICkNCj4+ICsgICAgICAgIHJldHVybiAwOw0KPj4gKw0KPj4g KyAgICBmb3IgKCBpID0gMDsgaSA8IFBDSV9IRUFERVJfTk9STUFMX05SX0JBUlMgKyAxOyBpKysg KQ0KPj4gKyAgICB7DQo+PiArICAgICAgICBpZiAoIChiYXJzW2ldLnR5cGUgPT0gVlBDSV9CQVJf SU8pIHx8IChiYXJzW2ldLnR5cGUgPT0gVlBDSV9CQVJfRU1QVFkpICkNCj4+ICsgICAgICAgICAg ICBjb250aW51ZTsNCj4+ICsNCj4+ICsgICAgICAgIGlmICggYmFyc1tpXS50eXBlID09IFZQQ0lf QkFSX1JPTSApDQo+PiArICAgICAgICB7DQo+PiArICAgICAgICAgICAgdW5zaWduZWQgaW50IHJv bV9yZWc7DQo+PiArICAgICAgICAgICAgdWludDhfdCBoZWFkZXJfdHlwZSA9IHBjaV9jb25mX3Jl YWQ4KHBkZXYtPnNiZGYsDQo+PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIFBDSV9IRUFERVJfVFlQRSkgJiAweDdmOw0KPj4gKyAgICAgICAgICAgIGlm ICggaGVhZGVyX3R5cGUgPT0gUENJX0hFQURFUl9UWVBFX05PUk1BTCApDQo+PiArICAgICAgICAg ICAgICAgIHJvbV9yZWcgPSBQQ0lfUk9NX0FERFJFU1M7DQo+PiArICAgICAgICAgICAgZWxzZQ0K Pj4gKyAgICAgICAgICAgICAgICByb21fcmVnID0gUENJX1JPTV9BRERSRVNTMTsNCj4+ICsgICAg ICAgICAgICByYyA9IHZwY2lfYWRkX3JlZ2lzdGVyKHBkZXYtPnZwY2ksIHZwY2lfaHdfcmVhZDMy LCByb21fd3JpdGUsDQo+PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICByb21f cmVnLCA0LCAmYmFyc1tpXSk7DQo+PiArICAgICAgICAgICAgaWYgKCByYyApDQo+PiArICAgICAg ICAgICAgICAgIHJldHVybiByYzsNCj4gSSdtIG5vdCB0aGUgbWFpbnRhaW5lciBvZiB0aGlzIGNv ZGUsIGJ1dCBpZiBJIHdhcyBJJ2QgYXNrIGZvciB0aGlzIGFuZCAuLi4NCj4NCj4+ICsgICAgICAg IH0NCj4+ICsgICAgICAgIGVsc2UNCj4+ICsgICAgICAgIHsNCj4+ICsgICAgICAgICAgICB1aW50 OF90IHJlZyA9IFBDSV9CQVNFX0FERFJFU1NfMCArIGkgKiA0Ow0KPj4gKw0KPj4gKyAgICAgICAg ICAgIC8qIFRoaXMgaXMgZWl0aGVyIFZQQ0lfQkFSX01FTTMyIG9yIFZQQ0lfQkFSX01FTTY0X3tM T3xISX0uICovDQo+PiArICAgICAgICAgICAgcmMgPSB2cGNpX2FkZF9yZWdpc3RlcihwZGV2LT52 cGNpLCB2cGNpX2h3X3JlYWQzMiwgYmFyX3dyaXRlLCByZWcsDQo+PiArICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICA0LCAmYmFyc1tpXSk7DQo+PiArICAgICAgICAgICAgaWYgKCBy YyApDQo+PiArICAgICAgICAgICAgICAgIHJldHVybiByYzsNCj4gLi4uIHRoaXMgdG8gYmUgbW92 ZWQgLi4uDQo+DQo+PiArICAgICAgICB9DQo+IC4uLiBoZXJlIHRvIHJlZHVjZSByZWR1bmRhbmN5 Lg0KPg0KPj4gQEAgLTU1MywxMSArNTgwLDEzIEBAIHN0YXRpYyBpbnQgaW5pdF9iYXJzKHN0cnVj dCBwY2lfZGV2ICpwZGV2KQ0KPj4gICAgICAgICAgIHJvbS0+YWRkciA9IGFkZHI7DQo+PiAgICAg ICAgICAgaGVhZGVyLT5yb21fZW5hYmxlZCA9IHBjaV9jb25mX3JlYWQzMihwZGV2LT5zYmRmLCBy b21fcmVnKSAmDQo+PiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFBDSV9ST01fQURE UkVTU19FTkFCTEU7DQo+PiArICAgIH0NCj4+ICAgDQo+PiAtICAgICAgICByYyA9IHZwY2lfYWRk X3JlZ2lzdGVyKHBkZXYtPnZwY2ksIHZwY2lfaHdfcmVhZDMyLCByb21fd3JpdGUsIHJvbV9yZWcs DQo+PiAtICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIDQsIHJvbSk7DQo+PiAtICAgICAg ICBpZiAoIHJjICkNCj4+IC0gICAgICAgICAgICByb20tPnR5cGUgPSBWUENJX0JBUl9FTVBUWTsN Cj4+ICsgICAgcmMgPSBhZGRfYmFyX2hhbmRsZXJzKHBkZXYpOw0KPj4gKyAgICBpZiAoIHJjICkN Cj4+ICsgICAgew0KPj4gKyAgICAgICAgcGNpX2NvbmZfd3JpdGUxNihwZGV2LT5zYmRmLCBQQ0lf Q09NTUFORCwgY21kKTsNCj4+ICsgICAgICAgIHJldHVybiByYzsNCj4+ICAgICAgIH0NCj4gU2Vl aW5nIHRoaXMgbW92ZWQgKGhlbmNlIHBlcmhhcHMgbW9yZSBhIHF1ZXN0aW9uIHRvIFJvZ2VyIHRo YW4gdG8NCj4geW91KSByZXN0b3Jpbmcgb2YgdGhlIGNvbW1hbmQgcmVnaXN0ZXIgLSB3aHkgaXMg aXQgdGhhdCB0aGUgZXJyb3INCj4gcGF0aChzKSBoZXJlIGNhcmUocykgYWJvdXQgcmVzdG9yaW5n IHRoaXMsIGJ1dCAuLi4NCj4NCj4+ICAgICAgIHJldHVybiAoY21kICYgUENJX0NPTU1BTkRfTUVN T1JZKSA/IG1vZGlmeV9iYXJzKHBkZXYsIGNtZCwgZmFsc2UpIDogMDsNCj4gLi4uIG9uZXMgaW4g bW9kaWZ5X2JhcnMoKSAoYW5kIGRvd253YXJkcykgZG9uJ3Q/IEkgd2FzIHdvbmRlcmluZw0KPiB3 aGV0aGVyIHRoZSByZXN0b3JlIGNvdWxkIGFjdHVhbGx5IGJlIGRvbmUgcHJpb3IgdG8gdGhlIHR3 byBjYWxscw0KPiAob3IsIGluIHRoZSBvcmlnaW5hbCBjb2RlLCB0aGUgb25lIGNhbGwpLCBvciBw ZXJoYXBzIGV2ZW4gcmlnaHQNCj4gYWZ0ZXIgdGhlIGxhc3QgY2FsbCB0byBwY2lfc2l6ZV9tZW1f YmFyKCkuIEF0IHRoZSB2ZXJ5IGxlYXN0IHRoZQ0KPiBjb21tZW50IGZ1cnRoZXIgdXAgc3VnZ2Vz dHMgbWVtb3J5IGRlY29kZSBvbmx5IGdldHMgZGlzYWJsZWQgZm9yDQo+IHNpemluZyBCQVJzLCB3 aGljaCB3ZSdyZSBkb25lIHdpdGggYXQgdGhpcyBwb2ludC4NCg0KRm9yIGFsbCB0aGUgYWJvdmU6 IHdoYXQgdGhpcyBwYXRjaCBkb2VzIGlzIGEgcHVyZSBjb2RlIG1vdmUuDQoNCkkgaGFkIG5vIGlu dGVudGlvbiB0byBhbHRlciBpdCBpbiBhbnkgb3RoZXIgd2F5IHJhdGhlciB0aGFuIHRoYXQuDQoN CklmIHlvdSB0aGluayB0aGUgY29kZSBuZWVkcyB0byBiZSBmdW5jdGlvbmFsbHkgbW9kaWZpZWQg SSB0aGluayB0aGlzDQoNCmRlc2VydmVzIGEgZGVkaWNhdGVkIHdvcmsgdG8gYmUgc3VibWl0dGVk LCBidXQgSU1PIHRoaXMgcGF0Y2gNCg0Kc2hvdWxkbid0IHRvdWNoIGFueXRoaW5nLg0KDQo+DQo+ IEphbg0KPg0KVGhhbmsgeW91LA0KDQpPbGVrc2FuZHINCg== From xen-devel-bounces@lists.xenproject.org Tue Sep 07 10:06:09 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 10:06:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180734.327512 (Exim 4.92) (envelope-from ) id 1mNXzU-0001cL-CA; Tue, 07 Sep 2021 10:06:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180734.327512; Tue, 07 Sep 2021 10:06:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNXzU-0001cE-8q; Tue, 07 Sep 2021 10:06:08 +0000 Received: by outflank-mailman (input) for mailman id 180734; Tue, 07 Sep 2021 10:06:07 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNXzT-0001c5-GY for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 10:06:07 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id ca338be1-7622-4c61-9c6a-b161f093615f; Tue, 07 Sep 2021 10:06:06 +0000 (UTC) Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-am5eur03lp2054.outbound.protection.outlook.com [104.47.8.54]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-40-HT3K6R6bOXiOq4H7_uRxjw-1; Tue, 07 Sep 2021 12:06:04 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR04MB4191.eurprd04.prod.outlook.com (2603:10a6:803:45::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19; Tue, 7 Sep 2021 10:06:03 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4500.014; Tue, 7 Sep 2021 10:06:03 +0000 Received: from [10.156.60.236] (37.24.206.209) by FR3P281CA0047.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4a::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.6 via Frontend Transport; Tue, 7 Sep 2021 10:06:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ca338be1-7622-4c61-9c6a-b161f093615f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1631009165; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oRW46sjfDAt94IjC1ydronO3b2EUU8JpbrPq1APVDwg=; b=ClVIIcFNWKH11waog8tT+45stenI5dgIN7mSHxifl92Okq/7+RYNgQI1vtP4zP79huDQzM 1lPNcNBor3MK0VbYVpaq8H695jEUzKMuoZOWV7vTO12TVTsy5KTt5l8HnZdV5kvqO1C/mT iKhftAjDURz1vkYy6EeCzKFYUrjZMpY= X-MC-Unique: HT3K6R6bOXiOq4H7_uRxjw-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=br/rr9eNNwv2wbxAiQGxT85pEuXCZ3v8ssI/cP3YDJbK9F2aEoPQ8HYTqWLdlSqfnzT57NlKWIm78mk+uGB6Yjw0HoypEwKt5jWl++Jj9Be7QanAHg5N92m5EzdzEyRfMvL7HOFQT0OdmaTR7sJq9a2z1ft4Txp6ljig/MCb+E6ThXRlcfh+9k7gKiybolcGRQzuZPVsB5J3sn74fz0uitodXqyxxLY+JM2dLf+bQU0daD47+pHV0mRpJAo9kJEI8wM2xUWKzyGVZeYihTJWEWemltqnO/W3XG9es0RxWIsWi3nTtFw7LkXz1aTFOk1YD5Q101nJjqcr8LlEXUQPaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=oRW46sjfDAt94IjC1ydronO3b2EUU8JpbrPq1APVDwg=; b=QGw6EeBoZ4+pqvxfQMADsclCJvG13l2hvGE9XCyZsP1A+HGsJ78BFeA9nQjz1Lad0TdQLC+p3JCOcXBjKYgOcnbmC8BET3Tv/LGkgAH5zm39alUg1C4TdhzM7Oo9Mgx8ZMJ0CpkJMDvHHNnONZghdW0seruak8bPTB5jMlzoaI+1dBFh18k9qplq+lT/HqiGAGzjQ9N+tKc8a21ZMv1bGADLDszuNFG4dbJFbnLBi9MbqnkwhhFoYFTIae7n6L+oNeRAGcWtq/ls2GaxrH4Z23ef+ZlAyqMA60PdcrSRLVRDy2Ck0vSXpQiEm1oQol9IAMNd7/Dh5jDSlng1h8/9/Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com; Subject: Re: [PATCH 8/9] vpci/header: Reset the command register when adding devices To: Oleksandr Andrushchenko , Oleksandr Andrushchenko Cc: "julien@xen.org" , "sstabellini@kernel.org" , Oleksandr Tyshchenko , Volodymyr Babchuk , Artem Mygaiev , "roger.pau@citrix.com" , Bertrand Marquis , Rahul Singh , "xen-devel@lists.xenproject.org" References: <20210903100831.177748-1-andr2000@gmail.com> <20210903100831.177748-9-andr2000@gmail.com> <5366265c-d169-041d-f812-1c49260f6499@epam.com> <8f1816db-798b-15d9-7343-2199eb8f39e0@suse.com> <0e3942a5-9105-c99e-f15e-dcf35aae142a@epam.com> <5d0d345d-db16-f0c5-9a78-4ad5f4733886@epam.com> <5ffbd0a6-b34f-4de4-b316-2376211039f1@suse.com> <6db7c55c-93c6-7901-6097-687287463c78@epam.com> From: Jan Beulich Message-ID: Date: Tue, 7 Sep 2021 12:06:01 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: <6db7c55c-93c6-7901-6097-687287463c78@epam.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0047.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4a::10) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1e0e0d22-6bd0-4490-fdd3-08d971e719ae X-MS-TrafficTypeDiagnostic: VI1PR04MB4191: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bJtqs6GaIsi7awptKQzx8l+javLX0++t37nkHEChriL0CaScmgI7uYhMk222VJSh5DEsisZaX8mYisp0JI7Npq1LrrUBkLMSl0hnayaz1pOh+2QCBr7dZPvOIQ0P2JhYW20Lmk378rJCl5ecQG87uBX8KSzHTCa7W4O/R1dTXZw6oJTe7Ds8bhRKx3RAVQLBbW8JoqoLdtbm6/ejPzzGumXtGTiHsMKB+zIe6DeQDJLakEaZyBBctR/bUdSvhDd5JbUjPCDEpSBFg2xuBfyFUOwlvC2C7YrrLO17spg3Wh8pAeWNZ8xzIjtKUvGL/kaCjZOxOoho4jlCJYTBGAHjwArW8rxidm9M/RaZvOzVjdflZn5tbBS5TNeIcJWvinXEOPE72PAnMwR7JYUuoAtFX52PrNGEtdFbm+LOHwk2jhpWXNUKvicMwdMYyLvoGsraXsnvSYBdKnobOYr9wzidCeg+1Gn4XQH7m1I9GuEH9Tkz7CFAQmRy2WWqeRVhDl0avkYN9iblspbDQedjEeXExsaZX8F0eUSC2PV4/ao0LYooZmNOvYvvHfw1gQHIyHEseZ/4Sy7o8jSguKoX4dUaH4ngvJ7ILLtzU43EiSArFEfe9cmU9gpqSHv2c/wPBzKMOw1owe+GddsG3Hmn15uxJJFTNRqDgwL54mDhjin6iK/uT6y/thKxTGmeo2xWWusBmbbTDytCqyF1m+NvgAi8t+xPZxjf06Di7hXyyjJjUhNuDkw8sOWx5JceoA5m2ZZ1 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(36756003)(86362001)(66946007)(26005)(31696002)(54906003)(186003)(5660300002)(8676002)(31686004)(2906002)(66556008)(66476007)(8936002)(7416002)(4326008)(83380400001)(53546011)(16576012)(2616005)(508600001)(6486002)(110136005)(956004)(316002)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UWZ2dEVOa3pUcmIrM3NkaUhZcDhHMzYwbHAzbEJyUkVUak5Fb1pHQWFBOFRZ?= =?utf-8?B?WnMyenJTVW13aVdXWVZqeUJ4VDJ6cEo0UytxQUFzSEtXeis0SnMxbHI5UkhI?= =?utf-8?B?dHJ4eVZuQXBCRTdSZHR0QSsvNEN4eStxQms1czV2R05Qd0d5eXNvandRQjly?= =?utf-8?B?Y2ZMcnFEcW5QWE02ZzE2N1p0TUVlV1hqUCsrdmUyY0RDZVJPdzU1b1RNcXJn?= =?utf-8?B?cS8wQlJWYW5VaCtESm0xQjJEQThXcmNkTGlYYzM4TnBCbllDamJhZlFYR3dz?= =?utf-8?B?eEhJWnhZSGtrMVBBYXpLUUVmQ0pOei9WS2hpU0xHdTRPQ2ljSlo3SU1KZkNK?= =?utf-8?B?NkpldFZPbkxIVndnMUg3S21zWEJIRFRxVTgxLzJOdTJVUCs4QXY4MWo1WVNR?= =?utf-8?B?czZKai9nOUhZR3pGeGtEMW5pRWVaZ1R3NjlPZXFyNTZWZUxQNVJWYURwZFBh?= =?utf-8?B?QWdkWTEyTDVYQkIvR1B0RVZXMmQrRDVMVHhGS2FnMmVCSkxOUDlsOC85VVlK?= =?utf-8?B?cW5vMTJBY0VCQ3dmMHdSdkFrLzA5Mm0rTG5sdS90dC8wMVlSMTVoZ2tHQ2N0?= =?utf-8?B?aXk4cks4U2x5Y1N0R1k2MnZHQ3pVOEw0WTRpV0VVT3Z1S0s5c1k5YUNqMERI?= =?utf-8?B?c0k1QVZIeDRENGhpb3dFK1dZaWVtdyt2NVp5VDBkanJqYm83SWNmbVk1M0tu?= =?utf-8?B?NDFDNmtmemhEYU1ZeEwzNjRZaE4yWGhBR0p5ZnlESWtwUmJ3b1RiTWFkMlcx?= =?utf-8?B?b1NkT3VyR0srUFpYdGdBNmJmUXplbml6VTVGdk91NGV2aVJ4amJSZlBkVVQ1?= =?utf-8?B?N0tOUVJWekxud2dTVm9qNzljMnl4NnphSWt3YUtrL3ZPYlRybEVZM3piejBu?= =?utf-8?B?cjE5a3QreXZNZzJYZWlONWEwZlB3ZlppdWJzV1lzdy9zaUlIMjAxUXRuWmcx?= =?utf-8?B?RG5WWEpNcEhxZ3RnbzUzY1hXRmo3ZlcrUFNkVy8vQk5QeW1rQ2h3cUgrYnBa?= =?utf-8?B?aWlkQWtEeG5VQlVFbVllOTVpTnhsKzZaWThEMUxSV0lWeGhnT1o2a211dlVM?= =?utf-8?B?NEtpSTVxYmlxN3oyWjZuMWRCZ3VvQUM2Vk0rVVFpWEFoWkxpSmtnSUl5Qms5?= =?utf-8?B?MDc4eDFzWkVranVWVFZZMlA0cjE0UmM2bi9zM2dCYzJLSGFDemZCSXBRdDhm?= =?utf-8?B?R2IrV3FBWkRXWVpOSmFLNmdJbWNrdXEzMnV3a0FZVDhjVkFuWEhzYXY1cXZP?= =?utf-8?B?WkhXUE9TYUVsUlVJeUpXa2FmTHNQeFFOcitrLzhSNXlBWVBvcEh0QmxOdmxM?= =?utf-8?B?alZNeFVhTEhMUFhuSkx2bGtqcWJLMnBxWCtQY05kamN3UmprdHRYV21KVEpT?= =?utf-8?B?S3VibGVEOVdGem41RVY2cUZGNUhuRXZPcUtoYm5Hb2tDOG9Rek5RcjEzcE01?= =?utf-8?B?Z2lHZm84VTNvdlM5TDFzZ3M4eVVZT29WdUNQcHA5MWJ5TVpjUERMeTVRNlRR?= =?utf-8?B?QnhKYlFBSzE1TG9GOHhPQnoreEhSWERLK0lNZVRLOHZ6VnI1Z0I4amxTREFw?= =?utf-8?B?UE85ZzJvTVZZSmxqRTE5K0xlOEU1ZjVaTTIzV2w1Y0p1U3g1MFlaa3dTMHRO?= =?utf-8?B?a0w3OEZwMmJyUnlwcEx4NnhFUHNYTzBkSDJERW5vMjBMTXpsOUZRMUUwMkxj?= =?utf-8?B?dGN5Z1FKNFVNaEZJNER4QkdqOW9QbUs1ZnROQVBNaXpDRFhncHZsTElmR2Mw?= =?utf-8?Q?vg+ptef31Ywl+m6kWFVSFhdgxnaeXy1CGy1fzqI?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1e0e0d22-6bd0-4490-fdd3-08d971e719ae X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2021 10:06:03.3007 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: DslmiGuRLtSAxNjuMzS28bs5IhNvYVFg3nNJRxmECWWXq3PnzogdxmKSe5+rv+kx7Yw9gl9AW8V8f+c6b2jz1g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4191 On 07.09.2021 11:52, Oleksandr Andrushchenko wrote: > > On 07.09.21 12:19, Jan Beulich wrote: >> On 07.09.2021 11:07, Oleksandr Andrushchenko wrote: >>> On 07.09.21 11:49, Jan Beulich wrote: >>>> On 07.09.2021 10:18, Oleksandr Andrushchenko wrote: >>>>> So, if we have a hidden PCI device which can be assigned to a guest and it is literally untouched >>>>> (not enabled in Dom0) then I think there will be no such reference as "host assigned values" as >>>>> most probably the command register will remain in its after reset state. >>>> What meaning of "hidden" do you imply here? Devices passed to >>>> pci_{hide,ro}_device() may not be assigned to guests ... >>> You are completely right here. >>>> For any other meaning of "hidden", even if the device is completely >>>> ignored by Dom0, >>> Dom0less is such a case when a device is assigned to the guest >>> without Dom0 at all? >> In this case it is entirely unclear to me what entity it is to have >> a global view on the PCI subsystem. >> >>>> certain of the properties still cannot be allowed >>>> to be DomU-controlled. >>> The list is not that big, could you please name a few you think cannot >>> be controlled by a guest? I can think of PCI_COMMAND_SPECIAL(?), >>> PCI_COMMAND_INVALIDATE(?), PCI_COMMAND_PARITY, PCI_COMMAND_WAIT, >>> PCI_COMMAND_SERR, PCI_COMMAND_INTX_DISABLE which we may want to >>> be aligned with the "host reference" values, e.g. we only allow those bits >>> to be set as they are in Dom0. >> Well, you've compile a list already, and I did say so before as well: >> Everything except I/O and memory decoding as well as bus mastering >> needs at least closely looking at. INTX_DISABLE, for example, is >> something I don't think a guest should be able to directly control. >> It may still be the case that the host permits it control, but then >> only indirectly, allowing the host to appropriately adjust its >> internals. >> >> Note that even for I/O and memory decoding as well as bus mastering >> it may be necessary to limit guest control: In case the host wants >> to disable any of these (perhaps transiently) despite the guest >> wanting them enabled. > > Ok, so it is now clear that we need a yet another patch to add a proper > command register emulation. What is your preference: drop the current > patch, implement command register emulation and add a "reset patch" > after that or we can have the patch as is now, but I'll only reset IO/mem and bus > master bits, e.g. read the real value, mask the wanted bits and write back? Either order is fine with me as long as the result will be claimed to be complete until proper emulation is in place. Jan From xen-devel-bounces@lists.xenproject.org Tue Sep 07 10:07:40 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 10:07:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180740.327523 (Exim 4.92) (envelope-from ) id 1mNY0u-0002Hj-OQ; Tue, 07 Sep 2021 10:07:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180740.327523; Tue, 07 Sep 2021 10:07:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNY0u-0002Hc-LS; Tue, 07 Sep 2021 10:07:36 +0000 Received: by outflank-mailman (input) for mailman id 180740; Tue, 07 Sep 2021 10:07:35 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNY0t-0002HU-EM for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 10:07:35 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 43a92863-ce51-4304-ae2a-921d17555026; Tue, 07 Sep 2021 10:07:34 +0000 (UTC) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05lp2172.outbound.protection.outlook.com [104.47.17.172]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-9-Cy3fR7TTMiqk8fr6zznO7w-2; Tue, 07 Sep 2021 12:07:32 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR04MB6176.eurprd04.prod.outlook.com (2603:10a6:803:f6::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.21; Tue, 7 Sep 2021 10:07:30 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4500.014; Tue, 7 Sep 2021 10:07:29 +0000 Received: from [10.156.60.236] (37.24.206.209) by PR3P189CA0027.EURP189.PROD.OUTLOOK.COM (2603:10a6:102:52::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.21 via Frontend Transport; Tue, 7 Sep 2021 10:07:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 43a92863-ce51-4304-ae2a-921d17555026 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1631009253; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VGr5KaKrPB+ECiV3mI7JH4ZubnK2Jw/FcM9+PIVCR9A=; b=hqRjfrkrRphKiA3n4lLVBEI4pTxvwCvUrlc7+mzk+krKLb60c4bY4mdJS1xathkrVrDikq 6NbsCq7Lpk5eewybHy+osieBqobG/PR770sAgXbNzQO4l6osvoBz7aHfQJmL3D2lCFHhOt Fd2mFSwusz3B/UB0O0kgy7WHo7jo+Tw= X-MC-Unique: Cy3fR7TTMiqk8fr6zznO7w-2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=E7w8LcHGWrntrIYAkeiSiGk55H9JXGxZWhzHMFppR/cRrQdSZv+/igXsqnHTmP0Db4BWfQ3SykDnf9DCNSlASWI78IYAYrGBxrUsI92qSlLC7WOiPER6Ot6kzhw90XiSweJmrg/Q5/zTEg9NkLFa6ZIskZhmAB/qwoykyhZvyZSNOxmDLzfvGmrTTZejD5lDZ0BpYAh/a1F6AEt6A8zJq/4c7vitO2JvcAZAc3Gei1wZCMmRbdnT6DHFc5xuEKUR1bPBy4EK8xK9Hh7P9qhyl7aFHqdZhmoj/YOkM2xOiHThcXDRxuwrPLlrxD5OwKJ1tzyQWIVkWznrpiCei+EsAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=VGr5KaKrPB+ECiV3mI7JH4ZubnK2Jw/FcM9+PIVCR9A=; b=fkAvpHWiBc9h1bqrhaK5I963N+DD6VmjRJlVSZiYOy6sj/8wPjtRuPllCh0S1I58WDZ+0EamhtXYH4+lgXm6+X8D6Vwk5l2f+bvvJC1eGKvv0hWEvotTrer/ve6ZdCEUkJ4bT2GKn9U47on+ZDsb4zzdSW1dC877irj87ABIrhBOJdGkEfDC2Y6aE9fnFKbDodlk+6qeAPOoB6EiM3IJlCVnwxLP80+C61HtcTkPokC7kkprSxBQ75aR+phEqm/5nIEX3WnyF2Z2cZu1znJVmCmYQx5+VbzY+tKrSrPPmV451fQaCEdRwFQkGnqvz3T+6HFszpEShKMzIeBlGBxtnA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com; Subject: [PATCH 1/9] xen/x86: prevent PVH type from getting clobbered From: Jan Beulich To: Juergen Gross , Boris Ostrovsky Cc: Stefano Stabellini , lkml , "xen-devel@lists.xenproject.org" References: <4efa804e-3250-227f-00c7-347581366cd4@suse.com> Message-ID: <46ec0dab-8b5e-f20f-225b-3f4c57f34a61@suse.com> Date: Tue, 7 Sep 2021 12:07:28 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: <4efa804e-3250-227f-00c7-347581366cd4@suse.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PR3P189CA0027.EURP189.PROD.OUTLOOK.COM (2603:10a6:102:52::32) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f341c0ab-13c6-4607-4725-08d971e74d4e X-MS-TrafficTypeDiagnostic: VI1PR04MB6176: X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mSGEp41nFGKSmsQ1+MLYGHCoH7IgpiKvEoU6D4xsANOmdp6UCOt/3I+nOU1vHoWalA6KkS+wA7wqDtHUZIRQBIehvDnx2GlF1+ZewAcb0ozqIt7ieq++7xCeyMIx5pjW55O6XF+fFgqh9bK44aP5DV1P0ntT0AjhQYYnEolvzc1xCQWdv5EmGJ3smF+SPQDZXktIL3GBCrO9Uku3m/OkGizM7S13IW8Tl531sGroXAIWHZRe9TuSm3StKoZBbxglJyHkgfeNrk9vFou7DLmhXlTSksp3e8jo8AMT0+QghHGwEZZf/c8TVBb8lmr4str+sRIYCcnrHKG/7S8TE8zfaP7Hwr45iDEmXBNTO5F+6r2YQ8GgVwnMhEc22HxlMnQV+Ec3cH8yk9Nr/y5q+q/INT4JNLNvpDy0aybhmVZCX0WRM2asjWFG/Gdda4XJf136N8sv1u14ten8vwPTe5Idor9TmvFLOBqv19L4jvEGuzYVLxDIWL32pp2gkfMu77iTTirxGQaV0Rk2EgMa1KmJQhtwEWUshxm/QoJqAdOFj6WiIIdN5amGvyOnZpWrEzPrsxbUSPRrKeihhrcgNv2la0Hi9XYvpK/7RcHrCQUR68EmHJQsVIFdyc0a6gOWCzfXi1o8oVsbP+FUOSNX1EhtFtWXWPhBgMMxhWCDifgVj/bKGAXoOxah13OmLA8enrsR23bHWeay2HdW/YJ5sxh16jGt8PYBFPRy7SnXnmFaSqE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(136003)(39860400002)(346002)(396003)(376002)(54906003)(66476007)(66556008)(2616005)(86362001)(8676002)(66946007)(31696002)(956004)(26005)(38100700002)(6486002)(4326008)(8936002)(186003)(31686004)(36756003)(110136005)(316002)(478600001)(16576012)(2906002)(5660300002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N2dzMlRpR3RYckx2TFFiNFhLWUd2OGZraEd0dmJpUExudTV6b0ZOTThkTXNu?= =?utf-8?B?MVZQMzdCMUFCU3hFTnlucTd3aFhvRmkxUW12VnduWkNneWdmSCsxS3lsZXdK?= =?utf-8?B?Ymo0TVBDbWhLZEhPRW42cVk5YlhTRkJDK3orODlSTjhVeExmNlBVSUl1TDhU?= =?utf-8?B?ZEk3Y0hPYnBCNUkwK3VYcVp5MnRVVjZUYUxpOGZpNFdpUlRzYmtJaWlJdkpl?= =?utf-8?B?NFlwZ0pGcmd1b1dKSWd6RlhnRnhMUXVHT2FoOEgxTWZTRzlCRERCR3FVUncv?= =?utf-8?B?NXhWcGZxUFJQMHNJMmlsSzhDdStHcndiRFFyVnluMVdWdTFabDVvN3ViTWNC?= =?utf-8?B?bnZoTXI0SlMydWs0eXE4ajZOcGFnU3RDZ0NoR0hhcjZoMitoVm0zNzRVamNs?= =?utf-8?B?RmVxYUMzUGxwWDNxQzBMdlJOem1IS3dTWXRseWs5RmdMTEFGbnJoQnJWNUhY?= =?utf-8?B?RHQ5WTdmQlV2Tlp2VjBQeUhTMmlJdmY4ZXRRV3VHQ2phdDBzbTFVUzFjQmQ3?= =?utf-8?B?bDBIVkNKMVJoVVpCM3kvT1dhQmgzZDNpbHlNNGN3L2l0OEVxNlBOYzFUTkVL?= =?utf-8?B?MW1HYzNpWDZJb0RYYlBTY0FIaXRoTzNUdHNjWXBnc2ZwSXVpazgvVkxQV2pi?= =?utf-8?B?N1ZmQi9pK3BIWllzREZsd001cWQyLzhwTjhQOCs4cWVnRjlQa1Q3NnJ6RnpF?= =?utf-8?B?a0Z5bEtXdjFCejI2NlpXWWJIckpuRjVPWGdraURZczM0SHBxQmMzelpMdWRQ?= =?utf-8?B?ekJtSUUyOXQ2cjlTM2VlakhGeTBWQkR1bDE0alI0N1BSNnh0aDBUZjNLaExm?= =?utf-8?B?Y1dCa1JOd0J6OXpXVERaa1F0ZFJRTExCUG1TOUZtRFIxL3pwRnBnbnpPdXV3?= =?utf-8?B?SC81cVhKMSt0NXNuVVlsaTg4akd6eXJTbVN1MnVQKzZOMHhEZUljRXlSSExO?= =?utf-8?B?SlQrVnVZYnlFclJid2tVTTRDckhpMjVMN3BKdXI3dEN2YVROc0Nsc01YN05a?= =?utf-8?B?M05QR0Q4eW16aHV0SWlLQ2FtMUdpMTZFTG9IcUUycGJqVkNmMnYzRE9hNFNE?= =?utf-8?B?UmRXSzYrTFphTnJIOGViNEJDd3pZT0E2SGRObVlPVGc2TnlaUEFQU3gyTVA0?= =?utf-8?B?NkZtdkx4dUtES1RUUGdUazJGWVloUFhUWi9BTmlGRGkrSEdNVDlRUktwb2hV?= =?utf-8?B?aCtqQW9NSzFobEdKRUlTMUNvYkZuQk1UbUZkUVo5YlFRMHVDc1RoRkh6eU5D?= =?utf-8?B?bU5QTDRtLzZVV2FjVnpmenUzYk5ZTnlQbTJlWU1OUG1EaWVKUjZmTTVZOVFG?= =?utf-8?B?YkNDYUp6MmVoWDJ6cytiazVtRUtLSlpKRStlSStOM1ZZOW43RmFRcFdRM2ZG?= =?utf-8?B?emswc054N1dpNnp0dFdvNFZCcXU2cE0yTlBZTmtXMEtRcG1lbGNiWEJkeVgv?= =?utf-8?B?WVZJVi91eTlRV2VFMS9XdktNbVFadE1hcXF6T29vU0xqTWIwSUZob0luTGdo?= =?utf-8?B?ckNFTjRVZVpOeU5XMFBJVVZxenc1T096VGpTSkxBWTRCK0V3YzJkM0JZUUlE?= =?utf-8?B?L0dkcUlINUxkYStoYWc1Umc5cFV5Q1pUMjVBRW94bGdzbGliZFJRSCtHV1lq?= =?utf-8?B?czVHalpSWWRDWXdTaHFIUExrdS85dVB6UFJpanFVNG9Sd2N3Y3UvcVZ6cWNO?= =?utf-8?B?QVk2MWhpZjFuMEEyWndoSjNTdHBHODJEWFlIMkVZbFk4K0NTNmpGQUZ0VkJU?= =?utf-8?Q?HDMt7eyMsTxeoDgm20BozDq9gHtYRZ43Ot0vBJe?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: f341c0ab-13c6-4607-4725-08d971e74d4e X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2021 10:07:29.9054 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: QvS5/u6jIhA5YQ0631sjlbwiEn+yvGE77jAgeJqeSx60mKCJMyT7CZAKFxhZymyjUu4zRhQJG1MeuVMh54jebg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6176 Like xen_start_flags, xen_domain_type gets set before .bss gets cleared. Hence this variable also needs to be prevented from getting put in .bss, which is possible because XEN_NATIVE is an enumerator evaluating to zero. Any use prior to init_hvm_pv_info() setting the variable again would lead to wrong decisions; one such case is xenboot_console_setup() when called as a result of "earlyprintk=xen". Use __ro_after_init as more applicable than either __section(".data") or __read_mostly. Signed-off-by: Jan Beulich --- a/arch/x86/xen/enlighten.c +++ b/arch/x86/xen/enlighten.c @@ -52,9 +52,6 @@ DEFINE_PER_CPU(struct vcpu_info, xen_vcp DEFINE_PER_CPU(uint32_t, xen_vcpu_id); EXPORT_PER_CPU_SYMBOL(xen_vcpu_id); -enum xen_domain_type xen_domain_type = XEN_NATIVE; -EXPORT_SYMBOL_GPL(xen_domain_type); - unsigned long *machine_to_phys_mapping = (void *)MACH2PHYS_VIRT_START; EXPORT_SYMBOL(machine_to_phys_mapping); unsigned long machine_to_phys_nr; @@ -69,9 +66,11 @@ __read_mostly int xen_have_vector_callba EXPORT_SYMBOL_GPL(xen_have_vector_callback); /* - * NB: needs to live in .data because it's used by xen_prepare_pvh which runs - * before clearing the bss. + * NB: These need to live in .data or alike because they're used by + * xen_prepare_pvh() which runs before clearing the bss. */ +enum xen_domain_type __ro_after_init xen_domain_type = XEN_NATIVE; +EXPORT_SYMBOL_GPL(xen_domain_type); uint32_t xen_start_flags __section(".data") = 0; EXPORT_SYMBOL(xen_start_flags); From xen-devel-bounces@lists.xenproject.org Tue Sep 07 10:08:23 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 10:08:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180746.327534 (Exim 4.92) (envelope-from ) id 1mNY1f-0002rF-2S; Tue, 07 Sep 2021 10:08:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180746.327534; Tue, 07 Sep 2021 10:08:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNY1e-0002r8-VF; Tue, 07 Sep 2021 10:08:22 +0000 Received: by outflank-mailman (input) for mailman id 180746; Tue, 07 Sep 2021 10:08:21 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNY1d-0002qr-IW for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 10:08:21 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 86a685aa-0fc3-11ec-b0e1-12813bfff9fa; Tue, 07 Sep 2021 10:08:20 +0000 (UTC) Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-am5eur03lp2052.outbound.protection.outlook.com [104.47.8.52]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-16-anK_6fk6M3OBQzdA10Izag-1; Tue, 07 Sep 2021 12:08:18 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR04MB4191.eurprd04.prod.outlook.com (2603:10a6:803:45::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19; Tue, 7 Sep 2021 10:08:16 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4500.014; Tue, 7 Sep 2021 10:08:16 +0000 Received: from [10.156.60.236] (37.24.206.209) by PR3P189CA0013.EURP189.PROD.OUTLOOK.COM (2603:10a6:102:52::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.20 via Frontend Transport; Tue, 7 Sep 2021 10:08:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 86a685aa-0fc3-11ec-b0e1-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1631009299; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LnFayoVCN7CZqe8/7arRmIOlirGbN3OOPeviniwqFXQ=; b=grRqzC2ACmkqAqP0HE+2Hzjiur/5+ZXIf+rak4xTixfrB1FNS11FwNhIi5IWqnPVIh0VCm XTTdsncwES21Qt3x00Jhr+Vvths6CiCCiL4NGea6BjZ03U3iuyp9FQQiEAw/PhgFfkSs3c CVN9hMjKOwAfRB0hOr4H9if86dypWC8= X-MC-Unique: anK_6fk6M3OBQzdA10Izag-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=F0+xL0CiYwpR+SZ3j9oaPfsOv9j6cOlqC79ZwX5f5ElaKTPUueQPdyNQZFWX9tpCTZNcPk5TpnmeLbR1bVrF7Slv/815OzOS460uNu6j0dxJyrp18s4Tc+0yK9nvgABdL6j6aDOMjbYrsKPdkr7j5p3pesJCVndd7NjqoGSzPVno7PoX5P1ZjrUWI7PFAF+dRBj3NsipSLE394cM8t4IZOMsLhQuz30ZoAK1vmsAF2FLICfTRiJ/RmeevrpCCIsBLKGvgAl/mleMOvDkhaOTOyyNDISYxfzjxIIbx3XhwGXR798/Gz1Tww0UDEFTemRzrsBjjxQky4UcjE+wj/tq/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=LnFayoVCN7CZqe8/7arRmIOlirGbN3OOPeviniwqFXQ=; b=Ea9pNlvlxPmJRrBJKuUKdhKz7cr4B2d9WKCAbvEzqcdycgkAA+AgPKKkwmQ82BbdjE9VZ9aFzcjjctVvtZwDZwMicEyTK8U/HMakHCYbqTil367YGYR4B2VyJytNhX2vKGgfOQF/hoMsLpRbuKaeNfE/OsyetA1T6MKCChYJz0fHBAHl0SSmKgjhXlY3c/4wSq4CBAm9tWJOYa/0tsv3EaaNSQ+uy/u6s5Q+lUdsNMEJIIdl10LTteMWXc6RpG5x0OJsqrThTeblibhVafjHn32Ne1anS/nZkUp9USHAPNh4NmZQwv7Xb4kKRBhbmsj25o03DF3apbqA1i/E9lGglw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: oracle.com; dkim=none (message not signed) header.d=none;oracle.com; dmarc=none action=none header.from=suse.com; Subject: [PATCH 2/9] xen/x86: allow PVH Dom0 without XEN_PV=y From: Jan Beulich To: Juergen Gross , Boris Ostrovsky Cc: Stefano Stabellini , lkml , "xen-devel@lists.xenproject.org" , Konrad Wilk References: <4efa804e-3250-227f-00c7-347581366cd4@suse.com> Message-ID: <2254771e-68ff-e190-15b4-42ed92239712@suse.com> Date: Tue, 7 Sep 2021 12:08:15 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: <4efa804e-3250-227f-00c7-347581366cd4@suse.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PR3P189CA0013.EURP189.PROD.OUTLOOK.COM (2603:10a6:102:52::18) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8c2d98cc-5199-4b44-8a24-08d971e7694b X-MS-TrafficTypeDiagnostic: VI1PR04MB4191: X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4502; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gL9qw5b10QprkHYC3HkJ2vDJS3edQ1xwm1WhPxPxbAWJXJHUN9sTdnOlkkmx66Bm7FT8F0tsIrs22dFAnRl+6BPV4comZ2DnIcBlwTMXiadQtdvusUigfJhD1Y1IZfIO7LdTnaf7NTDD5hZwvOK5md6G9g2YbNlEE8Uhg+5ba8kh4jb4ftLH5Z2FyQnoBbZYbkX4ESOy2Ra4I5ukWBR7oHhUNd7qO+Px1Tz39FYgdSG0vaoA/UFjz7t0ctdHOmQR/Qmoc3zLIxmfeaA8H09j4hglcTAfCjAnL19MYeFdJaKJyMYVABmrOoUEVdr7FMMe9cZsRJJQ+1ZAl1erl/J6pVsUrAjEqKynLN6rsV1HeZj0nvV7aOOrUrL2IzsaLZu7bXFy2HRePjBJIJkOPGalRwx225fnLaiUYb8bbOKHvjMNewpmJbT8/SUIZOj1qtDiSibkkm8dBGFsk5WHukDLWCXrsopKzE8bi6LBit2RhBEcbQr9DoCgPqCwWPLsXlFdZL2AS9PXO6SDIpVB3s5m/JMFfYoyqC5zU9TPZIzZFLYsnG0Vib2TL2LfF9YFMPHiAh4ozNK8PnOyfRJ1vXuqUSJMRfVY+jyecdDVqKcdbs9B/WvmMRq20eTEei2jIoKFgb5C08IT/4UvF9vw3qxBjPHl1nAHrFGflVu+anKmltyQznuYiB1SVQxXuRCTX/U3CpvQf9AWaZb1mGwvZ7diODTeKH9iZrBk04xl0ScGjxo= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(36756003)(86362001)(66946007)(26005)(31696002)(54906003)(186003)(5660300002)(8676002)(31686004)(2906002)(66556008)(66476007)(8936002)(4326008)(83380400001)(16576012)(2616005)(508600001)(6486002)(110136005)(956004)(316002)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NkNYbzFPUnk4ZTc1S1RNMzljMlFkZ2xVaGpwTlpiV0ZYQVYzMU9haGkrdGhB?= =?utf-8?B?ZU1rSWxDWXRFWEhJcm03MFhCa0ZpYVExWWFVbk9yZUJocDU1MFUvZkxWM2dh?= =?utf-8?B?Mm50N3lqcTRYUnVsOEtmS2x3MFRqU29xd1VZQ2l4NWhIbU5sR0g5b1BjcGhG?= =?utf-8?B?RTRDM2ltakNmeTYwRlh2ZzBMYm1FUkUxL2o3WDVnSnp4aFJDYnRPMGFXQVFq?= =?utf-8?B?ZytOeGtsUFpiRnVSc0dGVzhIcDV2UlJ4LzBTcDNDa3pnQlloanllWGZ4ci9U?= =?utf-8?B?SVVSYXZyenFvN1hJa1NNRzJXS3JvNHlHR2JramtwZi9pUGdObHQwVHBhakhx?= =?utf-8?B?a3dXa2RueUV1Z25pYXllRDJXZVphUE8yQnV3NGh1YjBGUzNPQVl4bTBuOHVv?= =?utf-8?B?bitWcytEWHgreEN1dVF0L1ZmWFc1cE0wNmVmZXhzRGtJYmMwc2hMeGVBVDJn?= =?utf-8?B?M05SZ3drQlBQandKNDUwTUtIeE52L0tJQUJvcHkvWDNtL0xvSzZiM2gwQ2Vp?= =?utf-8?B?ZVVOS0RKTlQwQVpZQXg4U3NLbmJTa0EwaGNEdjFiNGFPQlNDQnNsS3Y1S0dq?= =?utf-8?B?QkJYbGhjWFI3R0FBUCsvbjNjWUlMQVBoOExhTWVNOEtYVnk2cTdUZktXem1T?= =?utf-8?B?cHZwU0dCKzVoZHhLSlFubGpRemlkMXNaNjFONmhnRlFLM0ZJU01QVXdKVHV1?= =?utf-8?B?cyt6V2p6eElwVHAyMUY0TEpIQkNBeEdqeEljYVFsenhka1Z4VGhaSWNnanZ5?= =?utf-8?B?S041cFF2UWorTFVReE1lRW9hSTlKQUhHenI1cUdCSnNRZ291eHhHM3NDb2lu?= =?utf-8?B?bG5YOFN2Qit0NHlNczEvVDRWbHJWckY5TTRtM1pNb1BHQUJjU2hpZUEzUFFZ?= =?utf-8?B?VjhNRUtuNzVNTURscU0rWlZDeVNzSVNrQjF2KzE5dXdCTTQ3bytHUTJDaHRF?= =?utf-8?B?TjhDandTT0pjTGUwWE5DblFtQ1VEY2FJQVF1RE1LaWtZNDZxZ3IyaTZZVWJx?= =?utf-8?B?N2J1Z3c4dEh2LzE2azVqVmg1YVRLQVJPcEY2eHZlc0hKTyt0aksxakZRbkpJ?= =?utf-8?B?ZndXU0xjNkFablVHZ2x0bVBnaGlZOGZTYk5DWTZaejdUallHYnlpcElueXBi?= =?utf-8?B?TSthK2tpNEFJUStjZVBkN2puRHhsUzMxK29HdWV6djhhdGpMb2VyNDhTU1hu?= =?utf-8?B?dHhUUmtHa3Nnd2kweXJqbjFteFBYdS9rcHkxUnd6ZGcvQnZRaUloYXN6TDBn?= =?utf-8?B?czhqa2VxSzhxWWE0OG15TytBdmdxcjZiN3JmWHZTNy9RMXlibnBJbWNYZTZM?= =?utf-8?B?WnBDSzYrVXpNcEpORlQyYldPaU1JeklkM0JaSmV6VFJDSUxMRkRZam9sZnN1?= =?utf-8?B?eUkxUGNhTDdrU1RERjB3alhZTCtIYkp0VDVOdS9QOXF0aXlrTXNnbGE5Zjkr?= =?utf-8?B?U0tqUG90aTd0bU5PSGk3VlNNczl0Wmw3UEh2WEFML3Zua1VHQkV0MTlYbEdI?= =?utf-8?B?YWVWeXM2RGR2dXZDVnZYZ2d6b0VaR0hoQTBCV2NFUlNEVjJxNk91ZUVjaTI1?= =?utf-8?B?SGx2ZHFZQ21ndHZPMFEzSk96N2xSUzN0MmUxU0JZamxLQ3FNN012Y3dxSTZz?= =?utf-8?B?dURXUDA0bHJub1RBRHVpYkN0WEVvQ3VuT3JsOUpJSDR6VjNGdHF3RGlkNld0?= =?utf-8?B?dlFxMzQ5UWxLWThPRXJWTmRLOEpMajN6bVFNRjBJMWNLWWlCM2N1bmREUGxh?= =?utf-8?Q?DVphMp1yCy/B2xaqgdE9cJtifskiwCC/hBZCNc8?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8c2d98cc-5199-4b44-8a24-08d971e7694b X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2021 10:08:16.8807 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: hOfTzLFt4eMzjhOo5QNWWlhVrkX29HqCvYHJBxSwYsoLR3PfEc8mYNGJUCUYEw2BuRA7cOeB2dAyYoOdA0nsJQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4191 Decouple XEN_DOM0 from XEN_PV, converting some existing uses of XEN_DOM0 to a new XEN_PV_DOM0. (I'm not convinced all are really / should really be PV-specific, but for starters I've tried to be conservative.) For PVH Dom0 the hypervisor populates MADT with only x2APIC entries, so without x2APIC support enabled in the kernel things aren't going to work very well. (As opposed, DomU-s would only ever see LAPIC entries in MADT as of now.) Note that this then requires PVH Dom0 to be 64-bit, as X86_X2APIC depends on X86_64. In the course of this xen_running_on_version_or_later() needs to be available more broadly. Move it from a PV-specific to a generic file, considering that what it does isn't really PV-specific at all anyway. Note that xen/interface/version.h cannot be included on its own; in enlighten.c, which uses SCHEDOP_* anyway, include xen/interface/sched.h first to resolve the apparently sole missing type (xen_ulong_t). Signed-off-by: Jan Beulich --- For drivers/xen/pci.c it's not clear to me what the intentions are: On one hand I would think this is needed in PVH as well (especially for hotplugged devices), yet otoh the hypervisor's hvm_physdev_op() doesn't let the respective physdev-ops through. As a result with how I have things, a lot of "Failed to add - passthrough or MSI/MSI-X might fail!" can be observed. For arch/x86/xen/vga.c I think it really is needed for PVH Dom0 as well, except that the needed data doesn't get supplied yet by the hypervisor afaict. --- a/arch/x86/xen/enlighten.c +++ b/arch/x86/xen/enlighten.c @@ -10,6 +10,8 @@ #include #include +#include +#include #include #include @@ -257,6 +259,21 @@ int xen_vcpu_setup(int cpu) return ((per_cpu(xen_vcpu, cpu) == NULL) ? -ENODEV : 0); } +/* Check if running on Xen version (major, minor) or later */ +bool xen_running_on_version_or_later(unsigned int major, unsigned int minor) +{ + unsigned int version; + + if (!xen_domain()) + return false; + + version = HYPERVISOR_xen_version(XENVER_version, NULL); + if ((((version >> 16) == major) && ((version & 0xffff) >= minor)) || + ((version >> 16) > major)) + return true; + return false; +} + void xen_reboot(int reason) { struct sched_shutdown r = { .reason = reason }; --- a/arch/x86/xen/enlighten_pv.c +++ b/arch/x86/xen/enlighten_pv.c @@ -142,22 +142,6 @@ static void __init xen_pv_guest_late_ini #endif } -/* Check if running on Xen version (major, minor) or later */ -bool -xen_running_on_version_or_later(unsigned int major, unsigned int minor) -{ - unsigned int version; - - if (!xen_domain()) - return false; - - version = HYPERVISOR_xen_version(XENVER_version, NULL); - if ((((version >> 16) == major) && ((version & 0xffff) >= minor)) || - ((version >> 16) > major)) - return true; - return false; -} - static __read_mostly unsigned int cpuid_leaf5_ecx_val; static __read_mostly unsigned int cpuid_leaf5_edx_val; --- a/arch/x86/include/asm/xen/pci.h +++ b/arch/x86/include/asm/xen/pci.h @@ -14,16 +14,19 @@ static inline int pci_xen_hvm_init(void) return -1; } #endif -#if defined(CONFIG_XEN_DOM0) +#ifdef CONFIG_XEN_PV_DOM0 int __init pci_xen_initial_domain(void); -int xen_find_device_domain_owner(struct pci_dev *dev); -int xen_register_device_domain_owner(struct pci_dev *dev, uint16_t domain); -int xen_unregister_device_domain_owner(struct pci_dev *dev); #else static inline int __init pci_xen_initial_domain(void) { return -1; } +#endif +#ifdef CONFIG_XEN_DOM0 +int xen_find_device_domain_owner(struct pci_dev *dev); +int xen_register_device_domain_owner(struct pci_dev *dev, uint16_t domain); +int xen_unregister_device_domain_owner(struct pci_dev *dev); +#else static inline int xen_find_device_domain_owner(struct pci_dev *dev) { return -1; --- a/arch/x86/pci/xen.c +++ b/arch/x86/pci/xen.c @@ -113,7 +113,7 @@ static int acpi_register_gsi_xen_hvm(str false /* no mapping of GSI to PIRQ */); } -#ifdef CONFIG_XEN_DOM0 +#ifdef CONFIG_XEN_PV_DOM0 static int xen_register_gsi(u32 gsi, int triggering, int polarity) { int rc, irq; @@ -261,7 +261,7 @@ error: return irq; } -#ifdef CONFIG_XEN_DOM0 +#ifdef CONFIG_XEN_PV_DOM0 static bool __read_mostly pci_seg_supported = true; static int xen_initdom_setup_msi_irqs(struct pci_dev *dev, int nvec, int type) @@ -375,10 +375,10 @@ static void xen_initdom_restore_msi_irqs WARN(ret && ret != -ENOSYS, "restore_msi -> %d\n", ret); } } -#else /* CONFIG_XEN_DOM0 */ +#else /* CONFIG_XEN_PV_DOM0 */ #define xen_initdom_setup_msi_irqs NULL #define xen_initdom_restore_msi_irqs NULL -#endif /* !CONFIG_XEN_DOM0 */ +#endif /* !CONFIG_XEN_PV_DOM0 */ static void xen_teardown_msi_irqs(struct pci_dev *dev) { @@ -555,7 +555,7 @@ int __init pci_xen_hvm_init(void) return 0; } -#ifdef CONFIG_XEN_DOM0 +#ifdef CONFIG_XEN_PV_DOM0 int __init pci_xen_initial_domain(void) { int irq; @@ -583,6 +583,9 @@ int __init pci_xen_initial_domain(void) } return 0; } +#endif + +#ifdef CONFIG_XEN_DOM0 struct xen_device_domain_owner { domid_t domain; @@ -656,4 +659,4 @@ int xen_unregister_device_domain_owner(s return 0; } EXPORT_SYMBOL_GPL(xen_unregister_device_domain_owner); -#endif +#endif /* CONFIG_XEN_DOM0 */ --- a/arch/x86/xen/Kconfig +++ b/arch/x86/xen/Kconfig @@ -43,13 +43,9 @@ config XEN_PV_SMP def_bool y depends on XEN_PV && SMP -config XEN_DOM0 - bool "Xen PV Dom0 support" - default y - depends on XEN_PV && PCI_XEN && SWIOTLB_XEN - depends on X86_IO_APIC && ACPI && PCI - help - Support running as a Xen PV Dom0 guest. +config XEN_PV_DOM0 + def_bool y + depends on XEN_PV && XEN_DOM0 config XEN_PVHVM def_bool y @@ -86,3 +82,12 @@ config XEN_PVH def_bool n help Support for running as a Xen PVH guest. + +config XEN_DOM0 + bool "Xen Dom0 support" + default XEN_PV + depends on (XEN_PV && SWIOTLB_XEN) || (XEN_PVH && X86_64) + depends on X86_IO_APIC && ACPI && PCI + select X86_X2APIC if XEN_PVH && X86_64 + help + Support running as a Xen Dom0 guest. --- a/arch/x86/xen/Makefile +++ b/arch/x86/xen/Makefile @@ -45,7 +45,7 @@ obj-$(CONFIG_PARAVIRT_SPINLOCKS)+= spinl obj-$(CONFIG_XEN_DEBUG_FS) += debugfs.o -obj-$(CONFIG_XEN_DOM0) += vga.o +obj-$(CONFIG_XEN_PV_DOM0) += vga.o obj-$(CONFIG_SWIOTLB_XEN) += pci-swiotlb-xen.o --- a/arch/x86/xen/xen-ops.h +++ b/arch/x86/xen/xen-ops.h @@ -109,7 +109,7 @@ static inline void xen_uninit_lock_cpu(i struct dom0_vga_console_info; -#ifdef CONFIG_XEN_DOM0 +#ifdef CONFIG_XEN_PV_DOM0 void __init xen_init_vga(const struct dom0_vga_console_info *, size_t size); #else static inline void __init xen_init_vga(const struct dom0_vga_console_info *info, --- a/drivers/xen/Kconfig +++ b/drivers/xen/Kconfig @@ -240,7 +240,7 @@ config XEN_PRIVCMD config XEN_ACPI_PROCESSOR tristate "Xen ACPI processor" - depends on XEN && XEN_DOM0 && X86 && ACPI_PROCESSOR && CPU_FREQ + depends on XEN && XEN_PV_DOM0 && X86 && ACPI_PROCESSOR && CPU_FREQ default m help This ACPI processor uploads Power Management information to the Xen @@ -258,7 +258,7 @@ config XEN_ACPI_PROCESSOR config XEN_MCE_LOG bool "Xen platform mcelog" - depends on XEN_DOM0 && X86_MCE + depends on XEN_PV_DOM0 && X86_MCE help Allow kernel fetching MCE error from Xen platform and converting it into Linux mcelog format for mcelog tools From xen-devel-bounces@lists.xenproject.org Tue Sep 07 10:09:20 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 10:09:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180753.327545 (Exim 4.92) (envelope-from ) id 1mNY2Z-0003X9-I7; Tue, 07 Sep 2021 10:09:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180753.327545; Tue, 07 Sep 2021 10:09:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNY2Z-0003X2-DA; Tue, 07 Sep 2021 10:09:19 +0000 Received: by outflank-mailman (input) for mailman id 180753; Tue, 07 Sep 2021 10:09:18 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNY2Y-0003Wu-Ag for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 10:09:18 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id a8d6043e-0fc3-11ec-b0e1-12813bfff9fa; Tue, 07 Sep 2021 10:09:17 +0000 (UTC) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05lp2176.outbound.protection.outlook.com [104.47.17.176]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-26-RKsAUFFINoOolmJZdNIdKQ-1; Tue, 07 Sep 2021 12:09:15 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR04MB6176.eurprd04.prod.outlook.com (2603:10a6:803:f6::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.21; Tue, 7 Sep 2021 10:09:13 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4500.014; Tue, 7 Sep 2021 10:09:13 +0000 Received: from [10.156.60.236] (37.24.206.209) by AM0PR10CA0071.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:208:15::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Tue, 7 Sep 2021 10:09:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a8d6043e-0fc3-11ec-b0e1-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1631009356; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0znofO36pU2FD4CJIYFn7aacsI8GwthcODXsjcIpWgA=; b=P+ppK0OrA74NFQM9G9e/qTuREoS7DdeGPF3fmZjyAegAcNtIs2c/yxiJn+K+j7S7RDvN6k 9PSwcNeUyREwBnnxmrDaVo71kI+PvYqCk7YPmcmMYrEs74KRY5U9wOHK4QZ1AguXm048G+ LOkEl8vfKY8eOpL3QLm4ielkSpUlIZY= X-MC-Unique: RKsAUFFINoOolmJZdNIdKQ-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=m+Obh2I+xU/AOuzDzVsCa3QogoiyJWgpxdsjtcqpsayydXyYGSVdx53aa5oEFNnLQWTNr5LIf1Xf9cCMzLOm7jRD0ZqDXrd5FAp0NT1WUmLyQqnb8Dq6gOgP3tfJ7ftAkk6bL63PsxdKHPLGO4raT2qGpOr1xZNsQUh/fA/lnW76GjXV1xzyPbtz6cP+FKqbjFK2qVtkYzQixTKG6EWvRq2aojvD1DOJ4UE0x1SgG1aMt+hZkt8W5hiinkL05Zsm2ID5E92FimUK6/pd30RfgZe3m8d4nIj4auhkkAeGe7e4Ox7DCKqrFWCW4nRBhgvUX3OuX0fCUAA9EK4rLlY6YQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=0znofO36pU2FD4CJIYFn7aacsI8GwthcODXsjcIpWgA=; b=bPEHIaEv9JYVoSbY+gvx5oyBVL1BqnjFPM4qZbZclx5+Qmy7GCDTKEjJDC3kHJ5L5uZ/7CbZ/rk7Q+4Ji9TPj9FWzGPjojIZf6gImmPwTAeTmx9HjcBVfwHHG06pnOeXBFTPDlD+MyodyOXnqEaVAF3ovQP99bcmmk6kyfktKgI70vS0DOnMTBWo+ijj1Si7UAWkCeXjIQyhsIDBxWGHRoEZHEJF7TfnOChTVwH2/NrneIsLzzH6ogEQdBsQbrmeKyqdmNYciOikikmk6ZMsqn6KCi3tzl32lFWXXG3Kiwxio066IUC5Op9h6tczPI7uUZ9bHTYmtafJZdLpG0xv+g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: lists.ozlabs.org; dkim=none (message not signed) header.d=none;lists.ozlabs.org; dmarc=none action=none header.from=suse.com; Subject: [PATCH 3/9] xen/x86: make "earlyprintk=xen" work better for PVH Dom0 From: Jan Beulich To: Juergen Gross , Boris Ostrovsky Cc: Stefano Stabellini , lkml , "xen-devel@lists.xenproject.org" , "linuxppc-dev@lists.ozlabs.org" References: <4efa804e-3250-227f-00c7-347581366cd4@suse.com> Message-ID: Date: Tue, 7 Sep 2021 12:09:12 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: <4efa804e-3250-227f-00c7-347581366cd4@suse.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM0PR10CA0071.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:208:15::24) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2155bbff-726e-4d13-9c57-08d971e78b31 X-MS-TrafficTypeDiagnostic: VI1PR04MB6176: X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: DqSxuuek7MRKqM9FPJxyC3RCob2LpV3j0q4Czc9nWvy5lx1gD2hV6b97MKRao45nN6Rf0ZGl5TIP7GFezJ5VWq6m7SPYwi4bUKd2x8bCZ2cHGspooh86kKm1T+4IW0rL1hySEYgu7V8ATig+QW+LtJLpMtzqHniQvOks5UpWVp4oKc0NyFFGD/v2J8D7HHU/SakxcltURskwnlgIOFAkoHB1Ag3xOHnsfUlkRKupmBtwuWzdjjQVy5uJlkX/V//bBRi/kUDQPXhIZp3I4tCIros3z6E5lpirYVhfIZdxBHDzhMGXrQ10mGK6uUu77sdtNaXSquCijFDf/61E4c9RvSq16xukd0CqtTqwnu7vzQ6aFneL5AKympo2pruHHd8uBbT1i3GVyqlToT6JbLj/VLJ7X1XTcFOJDDrCgR3wBqbAsZdToghOo6HtslSsAUtZ4PGgubRQEhLwsvrcJpTxamf7cCraU2DR3N2aomPbiObPlzpEGVckcl/9Fk3k6zWumLbKhH8bF5n1DS924BdxCfkO1YwZ5yDODuyOlSz8lnHpr5WRFq1WYdL7k5lb2FYfy4IX2AQNirM76DIPvqIdTRRzKsDMDdiVSzhe+Eek+wYIh59PrHyGmouTdfxXWrhFynm183fRx5GM45KeL0QU9RuU35LIFUlRxl3z7f8JFmPrV3Qhk3UCHODjnwH6gMXB+U7JF3aJPFjn8a6flYB63sFsl5+vvBK5MsHhBoMRRqE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(136003)(39860400002)(346002)(396003)(376002)(54906003)(66476007)(66556008)(2616005)(86362001)(8676002)(66946007)(4744005)(31696002)(956004)(26005)(38100700002)(6486002)(4326008)(8936002)(186003)(31686004)(36756003)(110136005)(316002)(478600001)(16576012)(2906002)(5660300002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MkFDS3NmcjJhR1kzSkJGL1dKZHNTUGFnclJLajhBZHo0R0lTOUpiaUxZZHQ3?= =?utf-8?B?b2FISDc0V28wdEx2ZmYxd3hNUGZvYmNJZVpIeHRWcGVMRVh6SGZGUCtMWXd3?= =?utf-8?B?alltUmdXU2hWOWlpQmpXYWVieEdpMkV4MHlDSWJDaEV2MThHbklSaVhTaHBl?= =?utf-8?B?Zlc1Tzg5SVErbzN5YVNkN2ZMNnRUZ3pyT1piUmhTbjZYVkRjOUtSYzJ6MHJR?= =?utf-8?B?aTFuL0FyNVlsSmRFS05SU2hhZmplTVM1NWpub09WNWpnSTBZTmZIMFVkajF5?= =?utf-8?B?MzZlQnJlVjVSZmkxQUFtN0d0S2tLcXNwVE1ib05BenVnV0pKNFBIbGkydm5B?= =?utf-8?B?OHRWSmlKNWJLaW5kRVBCYlJzNkYxZXBmUjdDL2s0Snk3c1V5Q3d6RnZlRThL?= =?utf-8?B?MmdwQ1VXN3V6VUxvQi9aeThhblhzcGlydHFxVkwzWVdiQzVUcE5UNnZIeUVT?= =?utf-8?B?djhQY0Y2dEh0V2JzTHNWcmk3aUpKV2U0M3E2NGRWNG9IY3Nva2ZKZGlGMCtQ?= =?utf-8?B?NHc1UWl0eGNOeG1YK0FUeU5HQWpVYzFPWHk4T3hWNG94N3ozNTBFM0Z6cTVG?= =?utf-8?B?TjdiQSt5cENnYVFEaDFWM0ovaW9kTUxnVktPRFArVnBaSzFzeEphRXIzRkVO?= =?utf-8?B?S2dPbk1ySCswOXk4c0tsMXU5ZHR6Z0U5WnJlQUZTWXRUOVA3SlVacWF4UGpi?= =?utf-8?B?RzBRY251NW1TN0toOTdTcTl1c2xNQzVkTTRscGE3ZkdENnJ0SGd5TTE2OTlK?= =?utf-8?B?bmNlM2lZV2FTVElkaGQySDVVcUIwUXZ0QzVaU2dMQ0NTcElIcHNmVmRyTnox?= =?utf-8?B?Z3BGYThRTmgvdC8rZDMwZ1ZEMXhwRmJxeS9MSk1TZ2ppQjZqd0t5a212MGJW?= =?utf-8?B?dUpKRkdzTmxZd1RrSGpId2tnZkF3ODVFZCtUdytPemx3SmZ3SlIrTzB2Wmc3?= =?utf-8?B?ZHByM0tHaWxkczB6bkl6elcwQjRFVGRCajBwMlVla1ZlaUpETlJhbE44eFhn?= =?utf-8?B?VUhEZVhjS1BKR2VERGRCSDBFMzdwdmEyWjNXdTN4a0xXcklHZ2NhNU5vM0h4?= =?utf-8?B?MDZtWDMvbWtaYU5aRkpHVFhpeVp4bjlteWJiNzUrdHVHbFZsN2RWb0tMaU1s?= =?utf-8?B?d2xEekhaWXI4K2t6MTdVMW5NT2o1VWJZUUxpTkpuQU9jS0NDdjBpUWo4RWRJ?= =?utf-8?B?VytEbzc0TXZ3TzI2ekMxK3pQUkhPNFNsb1QwcTNIQ25FSFJuQStUUUN4LzR4?= =?utf-8?B?eENJdTFnNWVndW1Za3hZdVpWeVczYlVFSzNiZUVJalZ6R21KKzRCYm5qZEpL?= =?utf-8?B?SHZoeHZYd2FlZ1NscjRUNlgwN3ljTnVBVG5sT29pRjhiMi9neVg0SzZTMmIz?= =?utf-8?B?cWRLOVhYZGRqZlFNSFJFN3RRRjl5ZHRHL3hNcWdKVTlJTk9mTThQL09VZE44?= =?utf-8?B?cnF3ZTNtZ3RpWlFJbkJWc3JmMDBjYnNPeFdTSXNOMVArSG0wV24wMnpScHlQ?= =?utf-8?B?bm9KUngvT0FHZStsb0lmZTFCeGZLcHY0UlRSYVd3ZWxqS3ExWTJTbW9BMEsr?= =?utf-8?B?cWlYYlRCSjFCQjhld0dPdkZTQ3NHaXVESVlHSUcwMythaFRuQlZPUWZhTnRu?= =?utf-8?B?V09GOFVPVXNiLzdtbG1OU2N2SmE1RVBTN1h6MUg0MHBxTUpKdHVreTRkYVpX?= =?utf-8?B?VTdyYm1oWlZFL3JKRUlvdEhNcjNhNFNmTTdncWNsbHRiQzN3aWt6dHFPSlpR?= =?utf-8?Q?DjIWeRVkRORIhdVaYHAohA9/jC3HKzFldnfQ1ev?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2155bbff-726e-4d13-9c57-08d971e78b31 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2021 10:09:13.7983 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: jLBaJrGAjz0mRLQNZfUZ7RbXTndV1ys3SY0nFWniw1bduL2b6Kt5dDipo/9yF0nBg4Tk6gqy+zazSQGQxlYGZA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6176 The xen_hvm_early_write() path better wouldn't be taken in this case; while port 0xE9 can be used, the hypercall path is quite a bit more efficient. Put that first, as it may also work for DomU-s (see also xen_raw_console_write()). While there also bail from the function when the first domU_write_console() failed - later ones aren't going to succeed. Signed-off-by: Jan Beulich --- a/drivers/tty/hvc/hvc_xen.c +++ b/drivers/tty/hvc/hvc_xen.c @@ -632,17 +632,16 @@ static void xenboot_write_console(struct unsigned int linelen, off = 0; const char *pos; + if (dom0_write_console(0, string, len) >= 0) + return; + if (!xen_pv_domain()) { xen_hvm_early_write(0, string, len); return; } - dom0_write_console(0, string, len); - - if (xen_initial_domain()) + if (domU_write_console(0, "(early) ", 8) < 0) return; - - domU_write_console(0, "(early) ", 8); while (off < len && NULL != (pos = strchr(string+off, '\n'))) { linelen = pos-string+off; if (off + linelen > len) From xen-devel-bounces@lists.xenproject.org Tue Sep 07 10:09:44 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 10:09:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180756.327555 (Exim 4.92) (envelope-from ) id 1mNY2x-00043L-Px; Tue, 07 Sep 2021 10:09:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180756.327555; Tue, 07 Sep 2021 10:09:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNY2x-00043E-N1; Tue, 07 Sep 2021 10:09:43 +0000 Received: by outflank-mailman (input) for mailman id 180756; Tue, 07 Sep 2021 10:09:42 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNY2w-00042w-PA for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 10:09:42 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 7ff50b4c-2e67-42ba-8d4c-bbc4069e9dbe; Tue, 07 Sep 2021 10:09:42 +0000 (UTC) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05lp2170.outbound.protection.outlook.com [104.47.17.170]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-37-kA07ANcXO0q6nVZZ70NSWA-1; Tue, 07 Sep 2021 12:09:40 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR04MB6176.eurprd04.prod.outlook.com (2603:10a6:803:f6::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.21; Tue, 7 Sep 2021 10:09:39 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4500.014; Tue, 7 Sep 2021 10:09:39 +0000 Received: from [10.156.60.236] (37.24.206.209) by AM0PR06CA0079.eurprd06.prod.outlook.com (2603:10a6:208:fa::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Tue, 7 Sep 2021 10:09:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7ff50b4c-2e67-42ba-8d4c-bbc4069e9dbe DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1631009381; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QT2hWROh4+zHp6bv3m6ZK+pqrsQeBWMYacVPC/7XLFs=; b=MEib/EqnGV9tlL2S/+/2ehd9OhOQt50QhZGXI7Gb3aB5ZEmh8ykRlbjWJdBmY5fUHKUAb1 jyNOfDHxvxF/k8B5ljx1x0ke9ZXgpGFhWDVzBNH6Br0pMp/AgOdIM3Q/GALnPU3omm6l8I OqDXenz9qMkkiot5ZO+JeKkPyCeq+rQ= X-MC-Unique: kA07ANcXO0q6nVZZ70NSWA-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=l98EoNAQvlKjJyr2A5jHqWKX7cUvES+NJe7QjVdKj1aTNx+hJoO4uudM1/uSvdUXsEvl9qMi1QTBsx0VpmBtrirB8PKcJWIPfIKquEpGoZ0O7RWtbcmMOt9VL25ybdrBA25tQfTyYw5HiiTzGN2Yp9JocdzcAi1KrbXZ0n+W0sfxnMWzXA2/BT9+TBSnr5PMfHAlWt0yXgLZFpJFIu1gEyMLrOg0bjOeuIVQHktgpQmEw6cpsnqC2o6POd0EMzPsaPGIjbRIfANBCRi+S7fCK4g9w3exPC7Hde4Y4j4VSMtjpAYFrZDDClF5K/1p0LceFJqPTw9t8Jej1Nelca7bMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=QT2hWROh4+zHp6bv3m6ZK+pqrsQeBWMYacVPC/7XLFs=; b=Qw4APWuQuUQGwr7Uyu252oUDDJAKww7agbTDd/KdF3C4aNvz8pDmhiX88po8S7yA+1G3yV/Esjk0vnKcNirsZ2glNxKzZQF1274mUUryrvV8C8GjvmpxZEmYSpGf8o6YLfXz3nyT6pPBiF6xhGSebtmRQyHblJq2rs5CQw9fYM7dX6BRGZMZyEyMsjQAdinYNT9hoNq96k+Hm7QegZjjyzsuALRBEDN9/ksqCBU7LI/HyHOfTDwqmfBEoaKajpuk+l1FTq+F9v/eIoU3KUXndlDzWtppzV6xD8NAP+US8nT/tw3Sp5188Rr8yUe7rwVw8ZVt/aDbA1eRNdbx1pJTyw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com; Subject: [PATCH 4/9] xen/x86: allow "earlyprintk=xen" to work for PV Dom0 From: Jan Beulich To: Juergen Gross , Boris Ostrovsky Cc: Stefano Stabellini , lkml , "xen-devel@lists.xenproject.org" References: <4efa804e-3250-227f-00c7-347581366cd4@suse.com> Message-ID: Date: Tue, 7 Sep 2021 12:09:37 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: <4efa804e-3250-227f-00c7-347581366cd4@suse.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM0PR06CA0079.eurprd06.prod.outlook.com (2603:10a6:208:fa::20) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: bff94427-b8c0-49da-b1af-08d971e79a59 X-MS-TrafficTypeDiagnostic: VI1PR04MB6176: X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6108; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +N71l0PQEY3row9ZcGXcogF87GxEqAmHLNLg4DKPLKSDngbmLEgNg1jdqwvQLDB9xIJIUR8yxpOao7TiJwpS7CmeEQOOWxjjdAo5Nl29E3KaJp5by7R8EUQDe6LwPfEvRq30GRmK7pZZCgWiBdMDHhcyjakTqS0CmtqF86sogz3TybRqeVWHtMQW7IeKRGSzCGqj0W5Ch6if+/KC0+7tgVF0lRP/fmRz1BeG8jfA8nPO+fNCfVLVPAO0euxBWutCr64Mz4d2Q9LwBeTxgJvh7m2KTZJwn5wlvGq08Cjl0XwnDiXBMzXBMRw2kWiXYVg1vpjZAgVohrCwQqnYwPIYkqVv4YE8wnJGmioI9U2PCyFBLIK71vgJF6DLH7sN1UzQ0vBHPL/3lY8rrdVkE0Lb6KLsqjT6+MLrhytRfuyxXbFoNAZZ/lCdbLtgCMDCFyncI0X/2Ziz7rjTtDd1Ne/aYKbupOMIbKQBr7lyw7M1vakbxY6jih674Bf5Iy/MzcmAjpBSATnA7Wc8WEvJ7FxreXjg0wOJsDi25YI4zzE/C21P/L9toLpp1UPY3Ixn+30HiCJhCSyLrD+Lk+iJfYKxDw1qkvMVKcptREZ2YO6Od7WoKIZk5U7uiQ2k3JnL4t3XH4ZHeyBoCZGLS+dwnfyx0Qnu08A/NYqnrG2y3ybBFIvguuLkonQ2vn/RZ/2fDzOyLWHq1iUOT7Ask6WtzDgYsWpZtLy2NwsURdSJBn9A000= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(136003)(39860400002)(346002)(396003)(376002)(54906003)(66476007)(66556008)(2616005)(86362001)(8676002)(66946007)(4744005)(31696002)(956004)(26005)(38100700002)(6486002)(4326008)(8936002)(186003)(31686004)(36756003)(110136005)(316002)(478600001)(16576012)(2906002)(5660300002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZTkvbFdLU2o5RjJLU0kwelFSOEY2R2s5YkdOMy9YRGduVDM0U2tvZHFjdmZY?= =?utf-8?B?ajdJOXhHUmRNaW02VzM2eDhLVys5RW1ScFJZZnZ1MXE1K2o5YWZDNERGVkN4?= =?utf-8?B?K1BVWVN4M3A4dVd6K21EQS91L085d1lOQ3I5YnlzdEhkUzVMT0ZhdTFWUDd5?= =?utf-8?B?L3NwVHNCdTV0dy8xZU82UlFpQU9IcUYrUGE4MEF4Ynlsd2hwQXV1d2ZjeDln?= =?utf-8?B?dVgzR2FITWhRRlZSZmV1dmsvcU81eUo3U1QzS0w5NXI2L3RXZDdOeUJiMnJO?= =?utf-8?B?bTdZc21UcGdTdzBtd3lKSjR1WldXR25nY3JLeWlNbVdGZFh6Q2lDQit4R1lQ?= =?utf-8?B?ZkZ4RThLT0dhWmd2Z2Y3bjZESTVRN3RKZmE4MmUvcC94cjlBeFFlbGkwNE5p?= =?utf-8?B?TWlFQUxvaUUvWmlhcTZTdmJsVk5CRzV2eU9mb1VVNmp2c0ZYRVdLNFR0R2tY?= =?utf-8?B?UFhLdVUxTC92NkZWcTlWOUtWUjJja1RTb1BrWWdBaHpoazFkVFM0QUkyOHpE?= =?utf-8?B?ckdJYVI3UTZsem45WjV2WGE5Mkx5cUNUS0xEV0dYYmpGeHR5bnpYaHBwOUFT?= =?utf-8?B?czhjM3VxWXc1MDVpeEZXWmlqNEczN05SVWEydGFzQWNTdm9ncU4zQnN0dDlN?= =?utf-8?B?MklEd1lsaGVjTXJONGhlSVpKRU1scWJoSjRmVkdFTlRRTHcwM1NkS1dnNS9q?= =?utf-8?B?YVlML1BJdjIxVEd3MEVCTEVoc0thRXFmQWZZeEpsSm1xb1MrYVRLT3JhTDU4?= =?utf-8?B?KzUyTWhoUDdXeUxZVW40V0tnTW0xUzdzeWVXcXBQc3hJVnNBL1lDVHUwS0dB?= =?utf-8?B?cnoxSTRZR1c5QzVDQzBnQVhQcWtMZFlVNU5ZZE5pK1RQcHVCL2Q0Y2k4SnFt?= =?utf-8?B?eHpDQmsyRmxlcGdyQmlaWDlmbDh5Nkg5QkdLazFPc3h1MnBncTJJZ3dUcTFR?= =?utf-8?B?RDhlQzhhMkdxVU9vdlRqWUVWVjJTTDZFMmlRVlV3eXBxUTlKUlFOZ2JYV0Ja?= =?utf-8?B?WE9MK1YrS0tLbW0xSDhHb083MFNyNU9ELytCU3h5VlVTaFo5WXJ1MnZPaDRp?= =?utf-8?B?R0Rmd3VKSVRWUmNueDBnREphditXL01IREZPOGhncTJiaFVWUVNRdlJxMS9K?= =?utf-8?B?NkgxL25QTFVzbUczTVhQNGNKMjM3Nk1TbFpWcUFveE5YaThWNkhxRUd3TFQ0?= =?utf-8?B?KzA5RUt1bzJOakVtN1Vha2Y3S0pBNkxYOU9sL2dIMjcxaExKeE5FZ013SFVR?= =?utf-8?B?TmRpOXZlUGZKTzVlalRrcnRHNUNwSlNySUVVN2tNRkxoS29IWGIyVHhvcUNG?= =?utf-8?B?Vy9wVCtPMDVyQUZOQU16MTM5VHQvTkMzZW1qRFdJL2NGVE9VZU1nZVk5RWtJ?= =?utf-8?B?bDJ1RFZpZlB0V3M2Q25aL28rN0RlTmV2RCtieGE5bjVteUlrNzdXQTlPWG1n?= =?utf-8?B?WjNkY25PZTAzVHhkOVpacHJ0WlI3eTEvZDRoV0ZFS1g2MWFkUFpXODZIaUc0?= =?utf-8?B?OWFGUmtmOXhPbkFEcnZIM3lMN2ppSG1xSHFLOUhQMm8rdUk2KzlCU3NyL253?= =?utf-8?B?cHhSWC9WRHZiNk1UQklSc1ZQYTdPWk5jZHVvenlzS2h3MjdLRWlSRU5nYzN1?= =?utf-8?B?aE1uUVcycmVEa2ROb0JRbkV2T2UrY0R1cEpnbnJUZEl0ZnZoK25vMHZzQkk0?= =?utf-8?B?eHZvaGROd3doVEFsQ2Y4OXpSN1VNOVo2YVUxUmZJRkRBSTMwTTIwZjV0Wk1q?= =?utf-8?Q?uSGCiFyzaXKMfT/rsEMLHkiw794UOvco+WL125W?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: bff94427-b8c0-49da-b1af-08d971e79a59 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2021 10:09:39.1818 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: VBVGDkfwwg9LGWcuPiA+qVrOJqYU4F+PwRnvfb2cdy8J77FDERQMebOkkdpivuhmHJZ4ZGSsBkNBCZqWnNl1zQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6176 With preferred consoles "tty" and "hvc" announced as preferred, registering "xenboot" early won't result in use of the console: It also needs to be registered as preferred. Generalize this from being DomU- only so far. Signed-off-by: Jan Beulich --- a/arch/x86/xen/enlighten_pv.c +++ b/arch/x86/xen/enlighten_pv.c @@ -1340,7 +1340,6 @@ asmlinkage __visible void __init xen_sta boot_params.hdr.hardware_subarch = X86_SUBARCH_XEN; if (!xen_initial_domain()) { - add_preferred_console("xenboot", 0, NULL); if (pci_xen) x86_init.pci.arch_init = pci_xen_init; } else { @@ -1383,6 +1382,7 @@ asmlinkage __visible void __init xen_sta #endif } + add_preferred_console("xenboot", 0, NULL); if (!boot_params.screen_info.orig_video_isVGA) add_preferred_console("tty", 0, NULL); add_preferred_console("hvc", 0, NULL); From xen-devel-bounces@lists.xenproject.org Tue Sep 07 10:10:24 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 10:10:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180764.327567 (Exim 4.92) (envelope-from ) id 1mNY3c-0005Rm-5P; Tue, 07 Sep 2021 10:10:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180764.327567; Tue, 07 Sep 2021 10:10:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNY3c-0005Rf-1s; Tue, 07 Sep 2021 10:10:24 +0000 Received: by outflank-mailman (input) for mailman id 180764; Tue, 07 Sep 2021 10:10:22 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNY3a-0005RP-RL for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 10:10:22 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id cf551e24-0fc3-11ec-b0e1-12813bfff9fa; Tue, 07 Sep 2021 10:10:22 +0000 (UTC) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04lp2053.outbound.protection.outlook.com [104.47.12.53]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-38-cUzVwyWJPzyir_PQMp-iAQ-1; Tue, 07 Sep 2021 12:10:19 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR04MB6176.eurprd04.prod.outlook.com (2603:10a6:803:f6::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.21; Tue, 7 Sep 2021 10:10:18 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4500.014; Tue, 7 Sep 2021 10:10:18 +0000 Received: from [10.156.60.236] (37.24.206.209) by AM0PR10CA0116.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:208:e6::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Tue, 7 Sep 2021 10:10:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cf551e24-0fc3-11ec-b0e1-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1631009421; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=o+hISsxpZ+6AAFYh011f4JZGbH+OhXY7HGys8HSC9dI=; b=Soz1egwhiiEi3TWcR/5fThZh2goFlKQ0M8cNj1W/z7/3LxqoH+1dXzwK/aiiYKiL2HE5O/ 8F+2pCKAj98CKb9e7Szj8DlBxuDDJiXGQFCSR4uhijZBbEPepIXcxv5gyFcwSb3kc1e1T+ 8EpGXoqoVs4NjVkvUW98aON2yOBRf70= X-MC-Unique: cUzVwyWJPzyir_PQMp-iAQ-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ATFnLEMuoUG33dBh1EVkgXLpr+UCKxnv1vD02ZkkTC5KwfeB5CIuywm/qLzMqpgZKMV3+SA6XX6R7s+8uCdfhv5MyKLawL2/8I+R6KQn1kjRXyopwXVecRe8AYBLIFzzjmTWUBNVCqPFDIEHBsP23qGpV0Jxd4Tbd7jEou+r6Hols9IEiGOinpFEA6xPnoS4qrObp8CraAW3NpDFAofTV2/Jk7CS7bnfHcVDjf02yCM5AhmGPrNEor3TmPP2DIvb/rKamOFl73ZR8cDfBKvPdIAJ3M06Wsrmq2SpPZK0V5KC4T6ymnpKAZqMb+GcWHNThgZJpmASHvOPl+qJMbN13A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=o+hISsxpZ+6AAFYh011f4JZGbH+OhXY7HGys8HSC9dI=; b=gIRBzsqqtWU+N/GewJ1zbE/5dd1xgfelPJp2zbkITX8nu/GdEKkFppfiTWRE6GnR/Zuvpq43fgR1Ddcx2i5PrXAj0lXqzKEkyPnNOAdR1FcMwlUkvxdeWB/F/a7p6QQFpSWwoTa5A1KigGiuO7Wd7OQctW8tGZ7xjjUvPlFOnwfrWuT6c3GY1yWdeccK/Njzy2Rg54rtBFFwz/ExlzY7k4EOGWjuJv+qfFhKSLDzo5aA/lXFK8LCdwgKZl0ShB7vNJjqIMl4OVZxNsvKxVkrDJrhe7KhLyRhod1zpoCOFEyA0hE4dd7oVwtI0fTP7/oZH8zSNOdzvkZIDvkOMZB4Pw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: lists.ozlabs.org; dkim=none (message not signed) header.d=none;lists.ozlabs.org; dmarc=none action=none header.from=suse.com; Subject: [PATCH 5/9] xen/x86: make "earlyprintk=xen" work for HVM/PVH DomU From: Jan Beulich To: Juergen Gross , Boris Ostrovsky Cc: Stefano Stabellini , lkml , "xen-devel@lists.xenproject.org" , "linuxppc-dev@lists.ozlabs.org" References: <4efa804e-3250-227f-00c7-347581366cd4@suse.com> Message-ID: <5e9ff16e-85f0-50ea-f053-37e17351a0cc@suse.com> Date: Tue, 7 Sep 2021 12:10:16 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: <4efa804e-3250-227f-00c7-347581366cd4@suse.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM0PR10CA0116.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:208:e6::33) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: cd14d20f-e8ea-4892-7b34-08d971e7b1ea X-MS-TrafficTypeDiagnostic: VI1PR04MB6176: X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6790; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 52TajtVU4F2tne9oH5kEP8osFd5bqWVTP7F8f3qxwejC1BxWxsF76FC++gQxUqHfO3hx2QQGN2RQW/KclcmZoXyC2fqx3ye/XH5U3QRiTh/C/odpud+qdyeyLDOZzib1Q9A0Hm96Ln4ehWK5hyR7SPQ33nxqKPaTx7bpHzLUO+tO3YBIVgxiwgJ35Sm3RWnTpvFBxFfpO++e8u1/MZziSUATICuYtDZ8arFn2mVF3KjSdEUM9z+Iji9iecXhN5WJ5rk01sgGeaE4phWf2vKAOzrrlrx+6CJpWmJr64AVwbwId12uU1RoyqXWSvnuPIISFwrcY+GNTR63Q6D/a9LG1dZj3XRk13XbiDtrzy4pn6kAB+goqDJ3BuMTyKO557TevmIKG7oRrTmVZs+2ZHeOdptHX3n2xA0atw09NP+OpVqMcIYuGcvxZwbGfZUx2azxv6wu2tVZFOiRPZAMuwqaM5rCQ9mDlI356bOVDc6MSatftE4yo8+W/w2TfJdYQU3Bl14DoOhp5x9C9BySPgJ5o6/8LCB1IUSo3eD1OZhdexHUlrndUUiIEMKBdi0v0ILS0dxVI5RDPs/lKHdg9WtsYgWLXDW96Qg+KA2qkewfp1hb1oYHh3Oe0rCzgygPTmDzdWrDn3D6c5Slfuhp7byXdRXQoIk3NmXRBSAG/v3BWvAzDrpJSzloA9BRxUduZaOKvpRiMmcS+Kn3uNPeaz4FFBrZ75wBwA7g//+/UKYETvM= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(136003)(39860400002)(346002)(396003)(376002)(54906003)(66476007)(66556008)(2616005)(86362001)(8676002)(83380400001)(66946007)(4744005)(31696002)(956004)(26005)(38100700002)(6486002)(4326008)(8936002)(186003)(31686004)(36756003)(110136005)(316002)(478600001)(16576012)(2906002)(5660300002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MStORUI5eDFRY0lZWTRhT21VY3ZkMDM1d0RzaHRFUk8yaGRscEp0NW5TdzZJ?= =?utf-8?B?U2tQNk9UWHM3MFA1ZmNRL2J6S3kzdk16Y0tnamkxUnJWMkEvSGlNSzVNZVRj?= =?utf-8?B?Uy9PZDdndnJ5cktCYUQwODRraWN3WnlzYmVBaHl4TEhyWEJianBGMmxpd1ZJ?= =?utf-8?B?UlRUNUo5TllxSmRpYVlibzhINnRKeE5PMUE3RmRRTmpVUlB6a0VRMEo3WmtW?= =?utf-8?B?a2RIb3M4N294UEQ4QnBDRGx0T3VzbjVTeGp2MGI5MXBrU2svWXdSdCt0Nlg3?= =?utf-8?B?S01TV1NpaGQ1eVMxSkJEbjZCN25TVHRHbWY1ZVVFRnJCSWFaR3BJYTdlbEtK?= =?utf-8?B?bTdHb2ZUNTFNVkY1cmtGRFl5dGJqQ21XRlRTTGU5bnF2Q1VCSmcyM0JCcy8v?= =?utf-8?B?MEV2bW1CLzJLZmtCQVZ1ejVubVBsV3RHWDNOWDBISkM1TmZSSkdyRnpDSDNu?= =?utf-8?B?Njh6RnprK2tGdEIxT1FJY2xYb0VTa0lCVmxUYU9GMndSbmlyTEFaM29PVFNH?= =?utf-8?B?VTZDb2VteFk1bDFRclZNSENROHpHVWwxVHhmSStNK0RWOElXY3V0amF6OWYw?= =?utf-8?B?NVdmRWlQRGpPMWZ0YVgxRkUzOW43eTJLRERsdlNqNXp4dEVWM2hwVFQyZUps?= =?utf-8?B?R3d6UkpQWWM4U0pJbDhHSkkyTGZBOTJjWWNhdlYvS29yTUVDaHZhS2E3Q3Rs?= =?utf-8?B?eFlCM2phRHVqTVhZYzlPaWVsWTMvY21QL0hHc0dVSXpHT2ZTbS9wamJXMk4z?= =?utf-8?B?V2VsaDN4aUFWLzBNWW5Ic1pjMlN6QWpNZ1FPamxYU1RFMEgvSUxsMElQOFdR?= =?utf-8?B?aDhqdVZ3OGUxSHdHOThsQkRFKzFmdmRWOXNGZUtIZVZxM3FVVlR1a01wT25r?= =?utf-8?B?Q2QrQnovRERYQnpxMkFlRnplZ21QdVFHSEJsNmZINVBFSVhzSVJoaVRoVVdo?= =?utf-8?B?aVNSRlZBdXFXc1Y1bzh0SE5jNjF2UGtLUmJYeFJNWDFNK3U3b3QrTHNudWd5?= =?utf-8?B?eVZrWHFvVE1uNkxzcUZCalVzUjRBWVFXZXREN1NmRXRKeGdFNDRHdjBZOXdK?= =?utf-8?B?ZHhOZlJzV1dSVHNoVURQYkZQUG02aC9scGJwMWE5RkZvNGkyVVU1a24zQjUv?= =?utf-8?B?dXE2b2pCL01JKy96RytPbHJJcmZyVDB5a2lyRDRDeDNtL1JnMm9SRjlLWmdH?= =?utf-8?B?eEMwWXZ0UGYvTE8yRjN1QVhDTWp1TWYrNHMzRGhTTEsrSGZZUElXNks0eXJ0?= =?utf-8?B?UktUN1JzTWF1T1VBRk9udWhrbnhGZHN3U2IwZFBKbUdUMjE5RXFrRkpXSUN4?= =?utf-8?B?Z000b04waUsraHVtdjZ0eWUySGVTc3dYc2JFMUNLOGN1OEZIYm9PSUxFWFI2?= =?utf-8?B?VG5wZVFIdHFkLzExeHJzc1BQT25kc1BrbCszV3dwY1JGaWp4bFVaZDcyTmhD?= =?utf-8?B?NkZSV1BSMmh5Y0NGR1EvWlQybittbUhKdHc2RVdqT002dUhzbG12VWhpZlda?= =?utf-8?B?UEtYdUhVdXkwdlhzVkI4UEJ5eEpPYU1jcDRJOXlwZUhDbFhoaXRKZVlWWTVB?= =?utf-8?B?dmpYT1pINTlNajdhcm5Jc3djdU50M1V0ekwrU0h2d1dtNCsvUTZDN1RaOXlv?= =?utf-8?B?Z3ljSzBHM0RzTjh5S1dxL1ZweVphOGVBSmkrSXNEbFdsUE5jSG1rMS9McWY0?= =?utf-8?B?WW10cVBzZjRqTzA3SFY4T0lHVU1ZVngweFBmMDJ4Q2puYjhEVmhCQ0czNHdQ?= =?utf-8?Q?1tPC7FKAW3V1NHHKwVhQsdtEBaB7iwM+9hizwPn?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: cd14d20f-e8ea-4892-7b34-08d971e7b1ea X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2021 10:10:18.7083 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: dBWJ29EHAWW9qhp7K5EU/e3Iy/v4j9mjWX/wsY6QoUje96WZfw6EMlvcnIltHJy6I1tkkKx0FPt4ZaVC4ylsxw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6176 xenboot_write_console() is dealing with these quite fine so I don't see why xenboot_console_setup() would return -ENOENT in this case. Adjust documentation accordingly. Signed-off-by: Jan Beulich --- a/Documentation/admin-guide/kernel-parameters.txt +++ b/Documentation/admin-guide/kernel-parameters.txt @@ -1266,7 +1266,7 @@ The VGA and EFI output is eventually overwritten by the real console. - The xen output can only be used by Xen PV guests. + The xen option can only be used in Xen domains. The sclp output can only be used on s390. --- a/drivers/tty/hvc/hvc_xen.c +++ b/drivers/tty/hvc/hvc_xen.c @@ -618,10 +618,8 @@ static int __init xenboot_console_setup( { static struct xencons_info xenboot; - if (xen_initial_domain()) + if (xen_initial_domain() || !xen_pv_domain()) return 0; - if (!xen_pv_domain()) - return -ENODEV; return xencons_info_pv_init(&xenboot, 0); } From xen-devel-bounces@lists.xenproject.org Tue Sep 07 10:11:06 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 10:11:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180771.327577 (Exim 4.92) (envelope-from ) id 1mNY4I-0006Cb-KI; Tue, 07 Sep 2021 10:11:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180771.327577; Tue, 07 Sep 2021 10:11:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNY4I-0006CU-Gi; Tue, 07 Sep 2021 10:11:06 +0000 Received: by outflank-mailman (input) for mailman id 180771; Tue, 07 Sep 2021 10:11:05 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNY4H-0006CF-4x for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 10:11:05 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 23d633f6-5023-4ef5-bcfe-4b00c1f66bfe; Tue, 07 Sep 2021 10:11:04 +0000 (UTC) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04lp2057.outbound.protection.outlook.com [104.47.13.57]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-11-5mPymMrOOya9GGoIeBAUAg-1; Tue, 07 Sep 2021 12:11:02 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR0401MB2447.eurprd04.prod.outlook.com (2603:10a6:800:53::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19; Tue, 7 Sep 2021 10:10:59 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4500.014; Tue, 7 Sep 2021 10:10:59 +0000 Received: from [10.156.60.236] (37.24.206.209) by PR0P264CA0138.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:1a::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14 via Frontend Transport; Tue, 7 Sep 2021 10:10:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 23d633f6-5023-4ef5-bcfe-4b00c1f66bfe DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1631009463; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Q6KEqQas+q/MIa0vYj9SJ6GpdI6JFmUKlBBr4SWA71o=; b=jaDsxA+kuuK1t5rROA2Q70Us8jenURt3WdCuUsBTHSIJFb5Q8Ee66w2oVvHXuG92ipdet5 ALPMWr3as8dL4IoA2uCAlHvAqfyfR1tCyMqJSICdv609QO0eFFNArEevHJPck4oqeEANwe lcsvFYsqQ5IopjqCY8KW7CKRBzh13cg= X-MC-Unique: 5mPymMrOOya9GGoIeBAUAg-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cPRdsThc5Qow2i5RZl4qOO4M71ZtFK4yWRRzW+MlM9bDjsJ5KczruIAcS5Bd9d3hF93I7wIr1xeRDmHUwNFkYQBKML7CGCSdyMUMG5M3Z902VbQy3POgqT8iFbTtVBCCR9EmvHkwkM5R+jmg+M4QrVK4I8GbS+sFrw5pYPiYvCvP83jqw9wYT8XXaB6LBW7x1+ahl+2bLBrg06/M/ne6J3zoEQTTN4b1Bk4zG/kNdIH1XqECazIcnwHoaPyvX9NLI30pIt/0HqHm8QUKuAbCljTN62T83hkSwiIXoZha2fwiTB+inLVydbK8c3M6JoD6n5ZAcPql1YqwbvoeSFa9Qw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=Q6KEqQas+q/MIa0vYj9SJ6GpdI6JFmUKlBBr4SWA71o=; b=b7ryPUFJJDQTcdvn6o7WTcjmQtJz1NSR/wjHbiGhEnpnmgWKY2mWx6gD/EM2xH9tgLQpZVlpAhgUQPP+x2N+KW9r/MBD0UyMg0YD7KBNHIG2AT6cOyiNIKz6khIzV8uPYvL6TJc9OTzEPTVLJU+F4QCB9zXK5UiNZ90EVEu04I1mmSx+egtABP3bsqKu3X6H+ZKh9yLveeuie/LCAsrbUKb5gtVNCoJPFcUzZOkbUOaWv2Alqaujr+F+sbapBZ9DqZP5KrXOEWmF8Qh2/EcZPNr2uYF35rgi+EPN9uBcnlQhitgAjCgU8zBNNhLiwVMOHq88mN9tp38DM9q23Tv8aQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com; Subject: [PATCH 6/9] xen/x86: generalize preferred console model from PV to PVH Dom0 From: Jan Beulich To: Juergen Gross , Boris Ostrovsky Cc: Stefano Stabellini , lkml , "xen-devel@lists.xenproject.org" References: <4efa804e-3250-227f-00c7-347581366cd4@suse.com> Message-ID: <0b7afef6-1c46-ed74-ca83-f1e29f763f4a@suse.com> Date: Tue, 7 Sep 2021 12:10:57 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: <4efa804e-3250-227f-00c7-347581366cd4@suse.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PR0P264CA0138.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:1a::30) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 72b07e47-2f27-44bf-f601-08d971e7ca3a X-MS-TrafficTypeDiagnostic: VI1PR0401MB2447: X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: C8aD99HGtdAYtLQp4+lfDc7M7B/T49DmW5VZ8Cd88iSkflaJxmNmXU/3R4dXHQwD7mIp/74b3dzv79QkyjzNL5ragb4RGJgn6aiWLmfbL2iw5hYiPhZJtbs1+Jk1QtZ7bWuBDllXU+uFo7ySGbimuVGS1XpcIxv6a2BB2I/OGElmwA/6Uu+J97Mt9jIMEzYjx1c8TMSNOeS5sPIlNir7QIG+L5y6k/fUcBaKPFeZJ6Y4KRiWcyUQIIvYyUkrg780gV/Z1XpqWmfoHUCTyIvHqbM8bIofTf8Um/RvvGrxlE3PFDXhp1eUstwXhS+YageytzDfDLfXtBvuVFdJcJCt9wez/e/aMPfTE1UInnhel5JOtf/1J8aQgmvzMMI5BEkKR1r2axdLEW4iQIvlo1SeRN6+kdJfjH21CV6kpBl2jwWR4ekZLu0PSSdt1ZvZr56CyMYe/DW9p4NYWp/y38cNwGrybI5GQssATqEolCWX1Ip4HEL1aN+khtgvSxM5SJFKxlaSDXugLqzxiamVIhvaGdgYFPWtqSLHLDKXhg30CYwtf868EgYHKmAbnQv97knLyWjcC6akuYDpkRleDMLE8k6FOf4hL6CdJ6+2bCZbxUblQ0Uv9sYkgNYDMZV4o/TraJGP9/wMCMY/WQQDqFCHRMPFQXI6IpujCXPCSqqOkQEc/sZ+XrJ7/svKUbOwCqpLipxkCmjVr6r0rG0rf+sh0kGFR+vlfVmhixl1z4dpFDQ= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(346002)(376002)(136003)(396003)(39860400002)(26005)(31686004)(5660300002)(186003)(2616005)(2906002)(31696002)(83380400001)(54906003)(956004)(4326008)(8676002)(86362001)(316002)(38100700002)(110136005)(6486002)(16576012)(478600001)(66476007)(66556008)(8936002)(66946007)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?emgxVUg0RWtEaE8zWWJ5NlBCdFhQVGRndlBGc1g1VHh4Q0laMllBQ2gxRnJ3?= =?utf-8?B?ZCsxK3d5SXZhQ2htWGVHbnJyRjZDQWl2NlRKcUsrMW9vTjlneno2Y2xOV204?= =?utf-8?B?dnF2M3JuZGRtSWcweXBmYTFhR0V4cHc5M2xRQThrTG9oMjc1d1Z3Nm8wczdD?= =?utf-8?B?dXNqSXNTNEp3YXJoMWt5M1VXa3JDd05ZNEtHREpheTlMZGhVT1ZpekhHakc2?= =?utf-8?B?MUltQWExUEtMSWg5TTJrdVVsdGFXU0FpL1lOYk9ZVXZWWjZQaTF0bjE4Ly8r?= =?utf-8?B?end4Y1lia2wzOEQrUUdQYnM0SHdEbktLWkZSV05QMWc0TGJ1NnpHZEhRbll0?= =?utf-8?B?Y3VwYmlUcEhWc1hPSDVJQkhvQzJqZzNjckZWMjNrNjM3emRYRWFmcjMzbitq?= =?utf-8?B?QTF3eWxOMDFqc2k1QTh4NjV1NlgzWW9jT2tpSkZpbjZldUs1dkUrbTVuRmNq?= =?utf-8?B?Q2V5U3U2aDBxNUVNVFdydWtRVm9RUHc2UHIvSEVHSUY4THNhNlVBZ3hYWHZN?= =?utf-8?B?RUFxNks5SnF5eWw0RmtYOFMxTkluZjFXTE5COWJMZFB3MFViRTJqVHQ0dmdy?= =?utf-8?B?NnRLY3d5c3dmRUg5UWV3bWRZcGlSdDMwb3lReHZoWFF4Smk5L1ROUnkxT0Qz?= =?utf-8?B?WVpRajRtaDM2UXBZQmdHTktFcXh3TDFaUW4rWCtoK3NGR0RYYndZWFovQ2hS?= =?utf-8?B?bWZ0c3M1ZnZjcDE0dHR1emUvRG1pRWlVZnp4SGdQRDZRM1hzR2xBOEQ5S3Y4?= =?utf-8?B?ME9TeElvK1UrU002QVQ1YTVuM21OOEtDMzBoTFdacS9jQUhEbkhaSHZrN3hY?= =?utf-8?B?c2Y5bXBuYU55VEprWWV2Q2ZlWjlvQWp5Tm9XMDlWdFF3VjhQKy8zRzBPbnhN?= =?utf-8?B?ZUV5enhlWlEycGV1cy9TU0dEbTBRTE55OHQrS3NyQ2hPbjRJYlJOQzN0bW1H?= =?utf-8?B?VE9YL2doYVZPYjVaYlhYc1VLN1hxdGRrclZoL0RZcThKL3JtK0xMdHczcStY?= =?utf-8?B?R2p1TnR3VmpxeUVzaFhTcEpJYkZYTW9EMnpIUWU1Tkt4ZFlwZ2lBRStxeDRr?= =?utf-8?B?bWFLdUFvVzFFOW11dHdMakQ1QWZLWDRGd2loQmdCbGZCQXFuMlE0eXJJcmFF?= =?utf-8?B?SVlCWElQakRpWXRmMXdzdFlPV3REZlhUQzcyMFlLY2VHNC9vWGxYVi92YUQr?= =?utf-8?B?NnF0Q2o3QlVid01OYXFEazRpMlArQzJzb21ON1F2UlVUNUZLZWJ4b2Z6LzV0?= =?utf-8?B?UkZ5NjMzUlh2L25iejVDdXRDbUtvNkU0NHRYalRUVG05VERsa0NLNHQ5YVBP?= =?utf-8?B?WEFCTUVnNFVhVCtZN1pDbTVKSmVwaXFFaVJPcjZ6VVhaWlhBbExvczNQZ1Ns?= =?utf-8?B?MWw0a1VFRVZyMTBadlE1bUxzakdJdUY5aWg3WC92emFqM3g5eEw2OUc5ckJ1?= =?utf-8?B?SFp1eHpyVWpLTzZFcEVlZ24vdGJQa0JWQW1wRDIvOTVhMzQzNEd0MkkxMkNI?= =?utf-8?B?NE81UGtrWkpSVkNQSVJRTlJWeWR6VThqK2ppWFpIVUgyVmJBQW8wZnZEREFV?= =?utf-8?B?NVpoK2s3NTlMS25VdWc2MzNUa215bFA5QnJJYXZ1c3NrUVdMTXR2WDJRT09T?= =?utf-8?B?UThlYmhaSWhiNkFtZHRBYXRXbTdjcmdSd1RuNytMZE9CaE15Nk5lbjZvb1o5?= =?utf-8?B?YmtqOTdDRDQ1Q0tmVzFFQkl3WUFEOEo0bm5aNmFEODhQTEY3dVQrUHFCVUIz?= =?utf-8?Q?NXZn1M9Ok0eRAwdR85VGn2MYRU7N4ZWoznLKxK4?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 72b07e47-2f27-44bf-f601-08d971e7ca3a X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2021 10:10:59.5000 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: qzzuSfosyxO1v6cFLml8rZJvZXedtnyd/D0ny8EzQ1y2oUw78132/aj9kLoXedE8XVjo5YwQKiV0h8dr2NoXRQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2447 Without announcing hvc0 as preferred it won't get used as long as tty0 gets registered earlier. This is particularly problematic with there not being any screen output for PVH Dom0 when the screen is in graphics mode, as the necessary information doesn't get conveyed yet from the hypervisor. Follow PV's model, but be conservative and do this for Dom0 only for now. Signed-off-by: Jan Beulich --- Prior to 418492ba40b2 ("x86/virt/xen: Use guest_late_init to detect Xen PVH guest") x86_init.oem.arch_setup was already used by PVH, so I assume the use of this hook is acceptable here. Seeing that change, I wonder in how far setting xen_pvh to true only in xen_hvm_guest_late_init() can really work: This hook, as its name says, gets called pretty late; any decision taken earlier might have been wrong. One such wrong decision is what gets added here - preferred consoles won't be registered when taking that path. While adding a 2nd call there might work, aiui they would better be registered prior to parse_early_param(), i.e. before "earlyprintk=" gets evaluated. I also consider tying "detecting" PVH mode to the no-VGA and no-CMOS-RTC FADT flags as problematic looking forward: There may conceivably be "legacy free" HVM guests down the road, yet they shouldn't be mistaken for being PVH. Most of the XEN_X86_EMU_* controlled functionality would seem unsuitable for the same reason; presence/absence of XENFEAT_hvm_pirqs (tied to XEN_X86_EMU_USE_PIRQ) might be sufficiently reliable an indicator. Question there is whether the separation introduced by Xen commit b96b50004804 ("x86: remove XENFEAT_hvm_pirqs for PVHv2 guests") came early enough in the process of enabling PVHv2. Plus I'm not sure a HVM guest without pass-through enabled couldn't be run with this off (i.e. by relaxing emulation_flags_ok() and having the tool stack not request this emulation in such cases). I think the approach here might be equally applicable for DomU, albeit potentially pointless (i.e. dropping the conditional might make sense even if simply benign there): A PVH DomU ought to never come with a VGA console. Yet even then a dummy one may still get registered and would take precedence over hvc? --- a/arch/x86/xen/enlighten.c +++ b/arch/x86/xen/enlighten.c @@ -3,6 +3,7 @@ #ifdef CONFIG_XEN_BALLOON_MEMORY_HOTPLUG #include #endif +#include #include #include #include @@ -18,6 +19,7 @@ #include #include #include +#include #include "xen-ops.h" #include "smp.h" @@ -274,6 +276,16 @@ bool xen_running_on_version_or_later(uns return false; } +void __init xen_add_preferred_consoles(void) +{ + add_preferred_console("xenboot", 0, NULL); + if (!boot_params.screen_info.orig_video_isVGA) + add_preferred_console("tty", 0, NULL); + add_preferred_console("hvc", 0, NULL); + if (boot_params.screen_info.orig_video_isVGA) + add_preferred_console("tty", 0, NULL); +} + void xen_reboot(int reason) { struct sched_shutdown r = { .reason = reason }; --- a/arch/x86/xen/enlighten_pv.c +++ b/arch/x86/xen/enlighten_pv.c @@ -28,7 +28,6 @@ #include #include #include -#include #include #include #include @@ -1382,12 +1381,7 @@ asmlinkage __visible void __init xen_sta #endif } - add_preferred_console("xenboot", 0, NULL); - if (!boot_params.screen_info.orig_video_isVGA) - add_preferred_console("tty", 0, NULL); - add_preferred_console("hvc", 0, NULL); - if (boot_params.screen_info.orig_video_isVGA) - add_preferred_console("tty", 0, NULL); + xen_add_preferred_consoles(); #ifdef CONFIG_PCI /* PCI BIOS service won't work from a PV guest. */ --- a/arch/x86/xen/enlighten_pvh.c +++ b/arch/x86/xen/enlighten_pvh.c @@ -36,6 +36,9 @@ void __init xen_pvh_init(struct boot_par pfn = __pa(hypercall_page); wrmsr_safe(msr, (u32)pfn, (u32)(pfn >> 32)); + if (xen_initial_domain()) + x86_init.oem.arch_setup = xen_add_preferred_consoles; + xen_efi_init(boot_params); } --- a/arch/x86/xen/xen-ops.h +++ b/arch/x86/xen/xen-ops.h @@ -118,6 +118,8 @@ static inline void __init xen_init_vga(c } #endif +void xen_add_preferred_consoles(void); + void __init xen_init_apic(void); #ifdef CONFIG_XEN_EFI From xen-devel-bounces@lists.xenproject.org Tue Sep 07 10:11:07 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 10:11:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180772.327589 (Exim 4.92) (envelope-from ) id 1mNY4J-0006Tb-St; Tue, 07 Sep 2021 10:11:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180772.327589; Tue, 07 Sep 2021 10:11:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNY4J-0006TN-P5; Tue, 07 Sep 2021 10:11:07 +0000 Received: by outflank-mailman (input) for mailman id 180772; Tue, 07 Sep 2021 10:11:06 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNY4I-0006CT-90 for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 10:11:06 +0000 Received: from mx0b-0039f301.pphosted.com (unknown [148.163.137.242]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id e952aada-0fc3-11ec-b0e1-12813bfff9fa; Tue, 07 Sep 2021 10:11:05 +0000 (UTC) Received: from pps.filterd (m0174680.ppops.net [127.0.0.1]) by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 1879gqdr023812; Tue, 7 Sep 2021 10:11:02 GMT Received: from eur01-ve1-obe.outbound.protection.outlook.com (mail-ve1eur01lp2058.outbound.protection.outlook.com [104.47.1.58]) by mx0b-0039f301.pphosted.com with ESMTP id 3ax413rgxj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 07 Sep 2021 10:11:02 +0000 Received: from AM7PR03MB6325.eurprd03.prod.outlook.com (2603:10a6:20b:13c::18) by AS8PR03MB6981.eurprd03.prod.outlook.com (2603:10a6:20b:299::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.24; Tue, 7 Sep 2021 10:11:00 +0000 Received: from AM7PR03MB6325.eurprd03.prod.outlook.com ([fe80::d9b7:c0ab:2c2f:5b44]) by AM7PR03MB6325.eurprd03.prod.outlook.com ([fe80::d9b7:c0ab:2c2f:5b44%3]) with mapi id 15.20.4478.025; Tue, 7 Sep 2021 10:11:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e952aada-0fc3-11ec-b0e1-12813bfff9fa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VVksJoTbHstAgAfeQGTuaTIT9aTYz4kxR0iSFSePZVbsJfR2Vbq6ZedSm3jACcBA9cWtR0PtZTFnJeEk7FNMzsMdjhCEkr9LaYXiXW+vfXDXZZlagIgwVuQX2RAsY73Oz/2go6EBx7cxAVzLQ7jeCQdm4jB3wAvBDkmmgcpFveIH8uNITWpteXdevt7yow5TMW/8ZZeC40PA2pO0Skx5vUYNjH0H1j069C4x6VKzPb5fMbYOon/71UklYWNh7NIjzy5G8gqVZn98Hk1X9xQEwQuaqAd3FEHbVgOnjUtHv/4IkwXCkVLwvhVxRMzxZ0NiVHYTDsSvLkrRcTAOyRnNSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=kOiM5RsD5xxn92IuFKhIqw2Sf/NDbqDaoMJ/mC9j85M=; b=DQUtEpCZ0CF8enRDwPyWE+B0y3al16aWwMUO/fxnuogthTpmy/lUo9uYUeJCgUuA7SJGMkTtZSwNusvU56Xhtrkyc37OBeEHW21hZekDzr5me93vKwloiK3XF5GSa45klvbamHmSdna30VHbbOvwFlrCZHcZb45hkIH7VOlXtq7g4nm77lO361wTyXzj052mW7Y0ghXqudxtOqjYekcJ0jukxudb1/R+b5peTNnmjjcg8Q8/VN9xfvzNCoY6yfSHmLbMihOF7idwYFyJep4Lh1ShuwxKWIY+4YntO3ZUFZejsDDV1MZpq0Ec30RiRH37Qk3YB51vdT4RSEH1RW2thA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kOiM5RsD5xxn92IuFKhIqw2Sf/NDbqDaoMJ/mC9j85M=; b=YWo8luJZzET9nxoVRZBa/tpCzKxHw3LdiLSo1Cug/asWIWi5LIij4PzgC8PfSnMmvQRaIxVGruQCye2wBFCPjWR3TJP8fQTUZcshKiqesTdCdsU3r+uQ+K1YBP9tRF3Y4iJJoyIs8rmsYQ9XW7q5UEGNXWGTOiNBigfo9wHeWMeW2aQATCAeKxFPjmbaNgYjK/6PeS9mlEsZkjmwJrhGohuZTv4x6Fh7OZXGmsIzyXsXwJXl8joX1idvl+ZKfdiUbF8TWlI1BXgX2zPBH3k97A0zPC4DNp7MbTdB+jfXAXRfYxNer+e2WQMRWOVXTwOP7nHt8THgy8WBpPIZ2Be11w== From: Oleksandr Andrushchenko To: Jan Beulich , Oleksandr Andrushchenko CC: "julien@xen.org" , "sstabellini@kernel.org" , Oleksandr Tyshchenko , Volodymyr Babchuk , Artem Mygaiev , "roger.pau@citrix.com" , Bertrand Marquis , Rahul Singh , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH 4/9] vpci/header: Add and remove register handlers dynamically Thread-Topic: [PATCH 4/9] vpci/header: Add and remove register handlers dynamically Thread-Index: AQHXoKusySJnLVveGkulaWKrBZdXpKuXEOQAgAFPE4A= Date: Tue, 7 Sep 2021 10:11:00 +0000 Message-ID: <16e396be-89f5-4d42-d57b-d91f09b70644@epam.com> References: <20210903100831.177748-1-andr2000@gmail.com> <20210903100831.177748-5-andr2000@gmail.com> <8bb58d2d-255b-96e9-50ff-529985c655d5@suse.com> In-Reply-To: <8bb58d2d-255b-96e9-50ff-529985c655d5@suse.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=epam.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 28d3a7ab-ea58-4f82-915a-08d971e7cac7 x-ms-traffictypediagnostic: AS8PR03MB6981: x-ms-exchange-transport-forked: True x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: aZ7Eo3jg2n99D0rzDxiYTrVrpInJIUhV0EdvcGhVR4GZ9ZVDMh7FMCLk2aWahvzugwRiNi7QhFNDs6zY31PSpsIabhcIwl2a1EeEEUAHI6J5uJ7nui/dWqEILpDZm3p6zABOp3Ji3H4Hd8gxkC/H3haVxwP4+CVc3EymFSIMqw9ECuOB8natCm4361AsMySqHmym81PPslFhI7+DvLIZ6ysbPAuWiYY5Z6s7R7Dk5i/e/U5lK2pg2o2q0P49GjtYl1m0RhVyQv4KgUShAzjAN/bcvwaPBJqn3znJ2yqgL8PDhrKU23GMqEEk3cawklj4GxhbGYJLISlmjdpwdoIrLvThi2el1DSLwMwN+Gm7uY7eiIoxsS3pVSo9vFcOtNy/BXaklsMe/TtCYa4RvoeSQbw8yGY2laRw1Hi0g6wKy+na/oqw1Uc3Y4w0BT+dVgO2v+h/ygtKkz2pI+8Z8hnwtTTW63aZZV5pqZ+4u599sKrjMYPnr37Z2GaI2NnvdUcBojZVhReF0XyqxlQ3/GqVqn383j2jYM75Npw451iEj6FoaQCVVODTSMD9SvGFfSBcpwV08IdSXCtQ5Qc04S6/XoPEuv5C6+HnV/pcC/9tVTM7fhKEOll1I5fTDmhJaWsT2aFTezFiX/OB6rJPd26dO2PvMib/vJpgd8uV73oHbGzB26FOS7IFOb6CzuYE0tpcGC2olVKoPbm489MWQE5ppyRa7NPLLDFmCXrxzs0rG3iMXP1enbRt53wX8x2/El4U x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM7PR03MB6325.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(366004)(136003)(346002)(376002)(39860400002)(2616005)(478600001)(6512007)(186003)(6486002)(122000001)(38100700002)(66556008)(64756008)(91956017)(4326008)(71200400001)(8676002)(26005)(8936002)(110136005)(6506007)(53546011)(66446008)(2906002)(76116006)(66946007)(36756003)(66476007)(5660300002)(31696002)(316002)(31686004)(86362001)(38070700005)(83380400001)(54906003)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?YkhOR0o4MW5DUmg4NHhXNjh0YUcvekdBeTVUNDNyeUY1d3hUSmJiMzVvZnVl?= =?utf-8?B?aEU3VUpHMDNKMzlPS1lHVUNuKzV2SUdtcEVUUFZMUlBoY1NFUDF5UXZwU3Mw?= =?utf-8?B?dVNxamsxZUhKaGwrMUlLMGZHUVhzOUwwMW92TGtJNlhxVkVvOGpBazFIOUJs?= =?utf-8?B?OGIraStCL2hneVJwTk5qQUltazdjNHE4bkRiN0tDOVFFNWsvQVRFZVlWVVRn?= =?utf-8?B?cHpkY1lMNDBiYU8wLzJrcEpBUnNrMkxTZ1Nja3kzd1QxL0IzZ1ltNGNkUjgy?= =?utf-8?B?Q0hZanhoMEpsV0w4aTcrditwSVZwMmcyUFkxR1N4S2tIcGh3L0RlcWNtQzdF?= =?utf-8?B?Y09obUlIdXJHUjZWaWlsdXZuYVhRT2ZTaTZxbE9sdFhVdzhoN1lNVkw4WGVO?= =?utf-8?B?ZlAzZUQxQWE3UXQ0bmNpbUN1cFc3djlhL3U0VDkrU0paRUNGblZnNXBadkdH?= =?utf-8?B?b2JSQkpBTmdZVGNkQVNoRGJwS1pqWUZ1MGpwUHQ2cVY3ZTRIMVMxUEFhRjFv?= =?utf-8?B?d1lDQXNzekI3Zk9PbG4rOTUxaktrMVovWGpPL3ZoUlN2a2s3UjVVK09jZ2d3?= =?utf-8?B?YW95Q0p5NTNPNFJmYktNbDAzWGRiQjM3bjRRaU9YWEJtV1BDWEVRSEdEMDdW?= =?utf-8?B?dUg0N1dCUmhqbHRtS3l1dys1Ky9EQTlKTFU5VS9VWk80MzVMN0ZCR3RxWjVL?= =?utf-8?B?NDk2cWovTWliR3pQeWdJaHFRTitIV0JKVVRUdlRhd3JkeTNLMTJ5aG93NzdY?= =?utf-8?B?dDlsWTVQbXRnVUw1RmtMM21aYXJKYm84QUZUMXZEVEVBQWpzeWhIVkF2WXhX?= =?utf-8?B?ZUJiZFBJU1lweWlJZHRXcWlzRXN5NE1RYm9xV2JUSWdLbnlZaEk4K0dqcm9L?= =?utf-8?B?MmV4K1o3MHJ3cklWa1IxMXZOdThyL2dsclAvRnhkeXpzS3A0RG1FbnhTL01K?= =?utf-8?B?TUNFL2hsSi9MakZKZTBDSG4vcXR1K01mUWIzQlVHZ2tkcVdpRVQxb3JXOEMv?= =?utf-8?B?MEtkeXRUdUhZeGVGcS8yQzBaeEtmdmF2b1lzNlkyUGZsdmoxM0hDNHZuRi8r?= =?utf-8?B?bGJsVXBFZDl6VmlrVWZZUjBlbkZFaTc5S1hOai9KQmxjcjI2ZWN5bVpnZHNx?= =?utf-8?B?SGxyKzJxRGNUbFk2N0lKTGZFNnYvZldLNkNZRXRlMlFLU0V2aVl5NzVveTcx?= =?utf-8?B?elgrTk93aEJ4Znl6ZCtGenZ0NTlrYjVlemVITzArNWZMenhScG5nSmtOWFRS?= =?utf-8?B?dDU5eXVXUDdkeVpZc0p6VUMrMXhYQzFnc1BXVEt6U3huSlpmR0JlNG9ONjI1?= =?utf-8?B?a0FCQWpXc2FvRHUxOGoyN0RLQTk2TjlBd0NpR0ZrSU5GSHFwUUMxMlpGbmR5?= =?utf-8?B?L2s2NmJEcVV3OEV5VDUyZm54cHBGQkNqSUw2SEM5a01VRGlLZDdPMjVGT0l0?= =?utf-8?B?UVNQWGExV0R0eEgrZDR6NngweDJFRnZJZG00MFRtV2psTXFtaXFmUGZUZWo1?= =?utf-8?B?RFRVQkVEZlhoblF3dnkvNjQxVW5keVEveVQ2VEc4elJ6elE5bnhnRXZPSG1M?= =?utf-8?B?elEreEpxUDFzTllMYitEa0d2a2l5Rm5zTytTRWtqVkM1NmVlL0NKVWt3TFk1?= =?utf-8?B?aENZdm13ZytNVlVZZlNvRWNBQTdrbHVFNG5aY2d1VC9oTDcxcjBWOW1hQU5i?= =?utf-8?B?cWl5blI2UisrczdmbURoWVNya0lXekV2SnJDNEhQTTJYdFB1YlNWdWVpejVJ?= =?utf-8?Q?9c5eRYTF/gsayL65DAcStwdDZ3+lY+VzyImETO0?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: epam.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM7PR03MB6325.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 28d3a7ab-ea58-4f82-915a-08d971e7cac7 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Sep 2021 10:11:00.1254 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: BfcU329x42HJVXoj9TyAvhcvrLDGPJ5/YYmN9vzjUeK2ez2DTk8y66W/VNszGsWPEiQW9XWZ5dyg7wC1lqnAfH5mYWr4v2I4yHxK5BCffoZegCES5/ha1rW9s9zWFx8f X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR03MB6981 X-Proofpoint-ORIG-GUID: JnOgF-wPfdCoEbzJHmP_aiLBHCItoqRA X-Proofpoint-GUID: JnOgF-wPfdCoEbzJHmP_aiLBHCItoqRA X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.391,FMLib:17.0.607.475 definitions=2021-09-07_03,2021-09-03_01,2020-04-07_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 lowpriorityscore=0 priorityscore=1501 clxscore=1015 spamscore=0 malwarescore=0 suspectscore=0 adultscore=0 impostorscore=0 bulkscore=0 mlxlogscore=999 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2108310000 definitions=main-2109070066 DQpPbiAwNi4wOS4yMSAxNzoxMSwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDAzLjA5LjIwMjEg MTI6MDgsIE9sZWtzYW5kciBBbmRydXNoY2hlbmtvIHdyb3RlOg0KPj4gQEAgLTU5Myw2ICs2MjUs MzYgQEAgc3RhdGljIGludCBpbml0X2JhcnMoc3RydWN0IHBjaV9kZXYgKnBkZXYpDQo+PiAgIH0N Cj4+ICAgUkVHSVNURVJfVlBDSV9JTklUKGluaXRfYmFycywgVlBDSV9QUklPUklUWV9NSURETEUp Ow0KPj4gICANCj4+ICtpbnQgdnBjaV9iYXJfYWRkX2hhbmRsZXJzKGNvbnN0IHN0cnVjdCBkb21h aW4gKmQsIHN0cnVjdCBwY2lfZGV2ICpwZGV2KQ0KPj4gK3sNCj4+ICsgICAgaW50IHJjOw0KPj4g Kw0KPj4gKyAgICAvKiBSZW1vdmUgcHJldmlvdXNseSBhZGRlZCByZWdpc3RlcnMuICovDQo+PiAr ICAgIHZwY2lfcmVtb3ZlX2RldmljZV9yZWdpc3RlcnMocGRldik7DQo+PiArDQo+PiArICAgIC8q IEl0IG9ubHkgbWFrZXMgc2Vuc2UgdG8gYWRkIHJlZ2lzdGVycyBmb3IgaHdkb20gb3IgZ3Vlc3Qg ZG9tYWluLiAqLw0KPj4gKyAgICBpZiAoIGQtPmRvbWFpbl9pZCA+PSBET01JRF9GSVJTVF9SRVNF UlZFRCApDQo+PiArICAgICAgICByZXR1cm4gMDsNCj4+ICsNCj4+ICsgICAgaWYgKCBpc19oYXJk d2FyZV9kb21haW4oZCkgKQ0KPj4gKyAgICAgICAgcmMgPSBhZGRfYmFyX2hhbmRsZXJzKHBkZXYs IHRydWUpOw0KPj4gKyAgICBlbHNlDQo+PiArICAgICAgICByYyA9IGFkZF9iYXJfaGFuZGxlcnMo cGRldiwgZmFsc2UpOw0KPiAgICAgIHJjID0gYWRkX2Jhcl9oYW5kbGVycyhwZGV2LCBpc19oYXJk d2FyZV9kb21haW4oZCkpOw0KSW5kZWVkLCB0aGFuayB5b3UgOykNCj4NCj4+ICsgICAgaWYgKCBy YyApDQo+PiArICAgICAgICBncHJpbnRrKFhFTkxPR19FUlIsDQo+PiArICAgICAgICAgICAgIiVw cDogZmFpbGVkIHRvIGFkZCBCQVIgaGFuZGxlcnMgZm9yIGRvbSVkXG4iLCAmcGRldi0+c2JkZiwN Cj4+ICsgICAgICAgICAgICBkLT5kb21haW5faWQpOw0KPiBQbGVhc2UgdXNlICVwZCBhbmQgY29y cmVjdCBpbmRlbnRhdGlvbi4gTG9nZ2luZyB0aGUgZXJyb3IgY29kZSBtaWdodA0KPiBhbHNvIGhl bHAgc29tZSBpbiBkaWFnbm9zaW5nIGlzc3Vlcy4NClN1cmUsIEknbGwgY2hhbmdlIGl0IHRvICVw ZA0KPiAgIEZ1cnRoZXIgSSdtIG5vdCBzdXJlIHRoaXMgaXMgYQ0KPiBtZXNzYWdlIHdlIHdhbnQg aW4gcmVsZWFzZSBidWlsZHMNCldoeSBub3Q/DQo+ICAgLSBwZXJoYXBzIGdkcHJpbnRrKCk/DQpJ J2xsIGNoYW5nZSBpZiB3ZSBkZWNpZGUgc28NCj4NCj4+ICsgICAgcmV0dXJuIHJjOw0KPj4gK30N Cj4+ICsNCj4+ICtpbnQgdnBjaV9iYXJfcmVtb3ZlX2hhbmRsZXJzKGNvbnN0IHN0cnVjdCBkb21h aW4gKmQsIHN0cnVjdCBwY2lfZGV2ICpwZGV2KQ0KPj4gK3sNCj4+ICsgICAgLyogUmVtb3ZlIHBy ZXZpb3VzbHkgYWRkZWQgcmVnaXN0ZXJzLiAqLw0KPj4gKyAgICB2cGNpX3JlbW92ZV9kZXZpY2Vf cmVnaXN0ZXJzKHBkZXYpOw0KPj4gKyAgICByZXR1cm4gMDsNCj4+ICt9DQo+IEFsc28gLSBpbiBo b3cgZmFyIGlzIHRoZSBnb2FsIG9mIHlvdXIgd29yayB0byBhbHNvIG1ha2UgdlBDSSB3b3JrIGZv cg0KPiB4ODYgRG9tVS1zPyBJZiB0aGF0J3Mgbm90IGEgZ29hbA0KSXQgaXMgbm90LCB1bmZvcnR1 bmF0ZWx5LiBUaGUgZ29hbCBpcyBub3QgdG8gYnJlYWsgeDg2IGFuZCB0byBlbmFibGUgQXJtDQo+ ICwgSSdkIGxpa2UgdG8gYXNrIHRoYXQgeW91IGxpbWl0IHRoZQ0KPiBpbnRyb2R1Y3Rpb24gb2Yg Y29kZSB0aGF0IGVuZHMgdXAgZGVhZCB0aGVyZS4NCg0KV2hhdCdzIHdyb25nIHdpdGggdGhpcyBm dW5jdGlvbiBldmVuIGlmIGl0IGlzIGEgb25lLWxpbmVyPw0KDQpUaGlzIHdheSB3ZSBoYXZlIGEg cGFpciB2cGNpX2Jhcl9hZGRfaGFuZGxlcnMvdnBjaV9iYXJfcmVtb3ZlX2hhbmRsZXJzDQoNCmFu ZCBpZiBJIHVuZGVyc3Rvb2QgY29ycmVjdGx5IHlvdSBzdWdnZXN0IHZwY2lfYmFyX2FkZF9oYW5k bGVycy92cGNpX3JlbW92ZV9kZXZpY2VfcmVnaXN0ZXJzPw0KDQpXaGF0IHdvdWxkIHdlIGdhaW4g ZnJvbSB0aGF0LCBidXQgeWV0IGFub3RoZXIgc2VjcmV0IGtub3dsZWRnZSB0aGF0IGluIG9yZGVy DQoNCnRvIHJlbW92ZSBCQVIgaGFuZGxlcnMgb25lIG5lZWRzIHRvIGNhbGwgdnBjaV9yZW1vdmVf ZGV2aWNlX3JlZ2lzdGVycw0KDQp3aGlsZSBJIHdvdWxkIHBlcnNvbmFsbHkgZXhwZWN0IHRvIGNh bGwgdnBjaV9iYXJfYWRkX2hhbmRsZXJzJyBjb3VudGVycGFydCwNCg0KdnBjaV9yZW1vdmVfZGV2 aWNlX3JlZ2lzdGVycyBuYW1lbHkuDQoNCj4gSmFuDQo+DQpUaGFuayB5b3UsDQoNCk9sZWtzYW5k cg0K From xen-devel-bounces@lists.xenproject.org Tue Sep 07 10:11:43 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 10:11:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180791.327600 (Exim 4.92) (envelope-from ) id 1mNY4s-0007XR-8r; Tue, 07 Sep 2021 10:11:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180791.327600; Tue, 07 Sep 2021 10:11:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNY4s-0007Ws-3f; Tue, 07 Sep 2021 10:11:42 +0000 Received: by outflank-mailman (input) for mailman id 180791; Tue, 07 Sep 2021 10:11:41 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNY4r-0007VE-Ff for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 10:11:41 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id ec5d5787-3209-4ed2-98a3-fcdd27580d25; Tue, 07 Sep 2021 10:11:40 +0000 (UTC) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04lp2051.outbound.protection.outlook.com [104.47.13.51]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-1-Y5WVL8bmO0iESB8OdgIVFw-2; Tue, 07 Sep 2021 12:11:38 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR0401MB2447.eurprd04.prod.outlook.com (2603:10a6:800:53::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19; Tue, 7 Sep 2021 10:11:36 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4500.014; Tue, 7 Sep 2021 10:11:36 +0000 Received: from [10.156.60.236] (37.24.206.209) by PR0P264CA0236.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:1e::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14 via Frontend Transport; Tue, 7 Sep 2021 10:11:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ec5d5787-3209-4ed2-98a3-fcdd27580d25 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1631009499; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RRrXpYXcTwwQ057nr8ZyUKJTAVb8uMCfo1R65cMzIyc=; b=Zqfh4NKKZ/TdOyE5seIUSid8v/GFn51H5z+NAjHdeSpT9v7b1Mnmj5ikxJi1JKrSevU4vg UbxVqvXNp7UP0TiDGDCU2KS6xEYxo3AD24Sagzb1C3j5ewYZ6Sb5ndGwqkPPEt7r4dAH7Y eHfgm4TODmS5wEVK2Eve9Rfa4VQyGVk= X-MC-Unique: Y5WVL8bmO0iESB8OdgIVFw-2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NAcFQj8m378SmU1rK/4XO+ZvKIIJDUJ7hqH+UezJQm4UrmFmCcXDws8WZs+N9dh6MyQ01SE3yEwMGGGnHkMTqihik2C+pGk0RUPQpSZP5k/X4KJYMCby3PGyE+Rw8Zd5cdAv3zT3Pf+QfBY7zkmy7yREHNQA+KEuZuhe5GFS6hR31h/wrEUp6nZaVCAooLBBIw614dJ9BabmdoF7RD1WCwS++HxImjrpuL8GauEtBUPMnMpRnZW+V7mUZlbgchMii4Z6SdUvhSEsppq2GGXJU1crEpCto/TjGjoHrYgNHl74nDmRChbQhT2na9Xo/NlhmMTBdNnmdYYn5jO6h1+S7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=RRrXpYXcTwwQ057nr8ZyUKJTAVb8uMCfo1R65cMzIyc=; b=DIql3QeGkH+9x2BGcrQqBIPaNPny4Q3YwckzAnQxO1zzO8gYDNoXTUhdfQtuqI/v+mIfBmQKFPCqBvc3m7zq8nV/dzOTuL/BQdEsv4DcgLbAYzxgDN6IhpOFtUCuX4ASt9vHCyO9105GpSGudwLXKNCQeGcg+JoyXGsbHutbITGodHUq+0lc+4y2JLdOAh/1BqMqqW9LlfHAf+zACU/xcnUG3PU2E1D0ecXjdrTpNwNOXdy5N0nY6MbUNaldtG4XNWLdtbz8RbL0jNLvwMR48t0HHPn6Upo25qUOnSK0gp0KSQgVqPdOTOdaMdSC9VZiBkYBR1spiq6/AbmV2bmuUg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com; Subject: [PATCH 7/9] xen/x86: hook up xen_banner() also for PVH From: Jan Beulich To: Juergen Gross , Boris Ostrovsky Cc: Stefano Stabellini , lkml , "xen-devel@lists.xenproject.org" References: <4efa804e-3250-227f-00c7-347581366cd4@suse.com> Message-ID: <5af11027-cf9d-cf78-9f48-b2ce2edd6e62@suse.com> Date: Tue, 7 Sep 2021 12:11:34 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: <4efa804e-3250-227f-00c7-347581366cd4@suse.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PR0P264CA0236.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:1e::32) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5ca94ea6-dec4-4502-a200-08d971e7e046 X-MS-TrafficTypeDiagnostic: VI1PR0401MB2447: X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:635; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: tD+7OUJlsPyQgQWrjEg/VzzGUbE+OtklIEnab7QZzi6SHIjoiuaw6HyBjH9KPMKF2+BepxdfONPto1kdUfqVJrO7T41UKL38HnZf1oAmiQAX/tezGmXS0Q+oEsto7oDXyf5CXDQmDLVi4sztXKPUoreWVRRL/qdtMJATDUFqyP9XAFQugU1FZ1EDIizi3ZPVIsy3Hn+ykACa55inX16DW2zdJe58vUSP79PIjavHn5gwjDr+w6G25fbTH6dtNieIzUDjRQ7gmEKdlYC7s/f0Ki69HzqgTk2LNH0gzYmqQqYmWm0p8IHLQZJEO6fayJNSZ9uSCFTHedFOaEy5IEPWjYL8P4/AgXnNyROhjH2CxebONG0L117ruWSmaohNXxbhYY/9dSfmB9ctyM3myF2z/HWLQgLgPWH4O+xSSgSc+5ZsAFqAXD1kyKwaMq3dRtupYtpFIiO9wlmerkK3IwUMlXDNZer7DExvpAZ/2mRE2IBNVA2j2hO60w6xpmmr043N/WbPXwJ2+UfbV/oTIPYYhgfFDEWdnEXrEYWu+P61JotI+jqPjRUilCTIFBIE+Cdw2ndb8mWlonKFpyrevjKcUGVq6pvzz1ZWdFnHm29MaFGCJn2jUdOYCifV7CINu9/w68sncu/CoSwKe6bkrpIcTeWLJF9sKz1zp50HJ03BFmKlud6JCTrVgLJ8uzwZJO+KrXdGD4WppE9KxG3azkVNREpP+DjUnLt4pweRPPbzcPDj/2m/JmykSud1I1XHY6ChqZGxKX7yS6LGdl78vRHMPcmp12+YtqPS8wDd9vlrlMk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(346002)(376002)(136003)(396003)(39860400002)(26005)(31686004)(5660300002)(186003)(2616005)(2906002)(31696002)(83380400001)(54906003)(956004)(4326008)(8676002)(86362001)(316002)(38100700002)(110136005)(6486002)(16576012)(478600001)(66476007)(66556008)(8936002)(66946007)(36756003)(52103002)(158003001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TVNFSkM0V0I5T1pCRGt2WGdRWit5dmRIdHlmUm80cCtQcTBlY3dZT0hWMkkx?= =?utf-8?B?a0xEQ3NlKzM4OWh4VVpyZnFraGhpaUN5UkdTNU5XT2h4Qi8zRm9YQjR2aDBL?= =?utf-8?B?ejJ3cGFxM0wzcVZjc0RpeStSY2I3TFRielM1djZzeEhlVit0R09QVnlqUXVF?= =?utf-8?B?eXc4TTUxWTRNSWNYSHgzYVZLeGx4ck1wOGtXTGkwb2M3VVJoRjRNT0cvTFNo?= =?utf-8?B?MGEyMlcwb2ZrbVRueHJHN1ZqTFZGdUlLa1QwS09sVXJqQWFkZ3dBMVlvQ1dZ?= =?utf-8?B?MlpDejNRakdLK3BCZlY0eEVWVzhYeUxZNzI5WkFwWUsxWnJuM29jUVdTRFB5?= =?utf-8?B?WDdHR2M4NmVZcnNReU8yS3VSN3ZiZmROY3FMNXRud3ZzU2N5OGtyNE1PM3NM?= =?utf-8?B?WnRRZ3ZhV1Y1YWw4RXZZWUZpNU9PWGRpVXJkcFp2Y2syMUJGZENmdmJJVUto?= =?utf-8?B?QnpCNGhvUVkvVUxGM3dWbzdLQktRUEVEZTVSb2VXV0V4bVRhK1N0VlBEcS9R?= =?utf-8?B?RGYzMFZoazc3eUM3VFdoMEJPeGdIU2lJRGUwYWFoWC82Qk1wQkRUeEQ4TWlP?= =?utf-8?B?VmdaK2lIMzFuQTYydnZPOVFnNUdmKzB6VG9XTi81Z1BkcGhybFhvMXlqR3NP?= =?utf-8?B?dkNOdkRkMGZLTFh6V1dsQzJUTDZiZGVvM0NvbmlLeWI5NjhtSVdBanR4WVlJ?= =?utf-8?B?V2RsWEJoN0FSa2liNDJSVEh5MGNkak5VQm1ieUdoVDFZUU9SNS9zZW9jKy9Q?= =?utf-8?B?YU5zWDZQL1FpYlNhanZTT1pKWTZZTG9zZ2dYNFFYRHBjcW85WXQ5STNHVlBZ?= =?utf-8?B?bzl1cnRRQ0RMTGtzWngzUkFwZE5hZ1ZPWFFsMjhlSjkzakNXT3NJa0ZWaGRD?= =?utf-8?B?a0Y4UkZNRmRYK2pNVXc5L3R3b2xQd0k1T1ZkWCtsejIyWTRSei85dTZWZGNJ?= =?utf-8?B?Q3BOWUJxbncyalNRU2JXMU9LbzFYSXZlMDJWbU03ZGlzYm1vQStmWHpVbzZj?= =?utf-8?B?NmdmU2lxS2dYekJWVzBlQTVIaDVaaU1pNVV0cUJNOWV0K2xhQ2VrMkZua2x6?= =?utf-8?B?NnFuZGZpbVRMOUdMKzlqT1dYbzdZMXNjWkxNcmEwSU5KbG12RytzS3dSMEp4?= =?utf-8?B?bnBKYWNOZjBFNTBFTXNPTFNwNVg2SmFWWXpiaVRKdmdvUDJDWWNSYWdGMjNw?= =?utf-8?B?dldNL3BteVBLcGJxaU8xL1BxZkhoMTAyWHZzbmpZM0lOZlI4Q0pxdXloK1M5?= =?utf-8?B?U29kMVRDb1l5REhhaXhwcStxaGN4YUIxTEJRWVJ0TDdjOEZtYi9mY3VUR082?= =?utf-8?B?c1ZmanROV3Q2R0lDYnZqRDIzQ2poN0Z3b2VNYm5kMEF4QlBxaG43T3RjQ1o1?= =?utf-8?B?N2FaakVvUVorYWY5cEdWVldsV3FmZ3Q5bmROblpNYmJmbTNyd0oyVnAyWlVt?= =?utf-8?B?RXlWVWRub2NnNlMzeVhoNXowb213TEQ1MGMrZithT0s2bWl5bWJzUFgxaHBp?= =?utf-8?B?MWdIVG91TElnMnhVV2t4VE8rNHg4TURUVnJYSG1TY3dqZFpYUHlxRGxHVWtk?= =?utf-8?B?MkZmRVErYzJvRWJxRDF1UittbjJNNkwvdmpPUjJjV0p2OENIT0V4MFo0NEU0?= =?utf-8?B?REhKdHJ1RWRHUCtSNDFZY1RDVU9HanFmQkZXM2JXQndXMFRiTXgrYk5qS1FM?= =?utf-8?B?bEJjV3RJMlMxZ0FtS01BYmh6b3N1cXZraldIWWp0WGMvOHlKY25walUzT3pM?= =?utf-8?Q?QPh6akzVdk4BshLTZQSsUwys3qi5/0E34/gCsst?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5ca94ea6-dec4-4502-a200-08d971e7e046 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2021 10:11:36.4774 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2reX+14OiwDhd1vrHhRx3IWOxAa/HEC9FnvM45xTLk3eSIrMKWurl/lKntmqephyKmY9Pb+kz7cXHCp9Z5nLSw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2447 This was effectively lost while dropping PVHv1 code. Move the function and arrange for it to be called the same way as done in PV mode. Clearly this then needs re-introducing the XENFEAT_mmu_pt_update_preserve_ad check that was recently removed, as that's a PV-only feature. Signed-off-by: Jan Beulich --- a/arch/x86/xen/enlighten.c +++ b/arch/x86/xen/enlighten.c @@ -261,6 +261,18 @@ int xen_vcpu_setup(int cpu) return ((per_cpu(xen_vcpu, cpu) == NULL) ? -ENODEV : 0); } +void __init xen_banner(void) +{ + unsigned version = HYPERVISOR_xen_version(XENVER_version, NULL); + struct xen_extraversion extra; + HYPERVISOR_xen_version(XENVER_extraversion, &extra); + + pr_info("Booting paravirtualized kernel on %s\n", pv_info.name); + pr_info("Xen version: %u.%u%s%s\n", + version >> 16, version & 0xffff, extra.extraversion, + xen_feature(XENFEAT_mmu_pt_update_preserve_ad) ? " (preserve-AD)" : ""); +} + /* Check if running on Xen version (major, minor) or later */ bool xen_running_on_version_or_later(unsigned int major, unsigned int minor) { --- a/arch/x86/xen/enlighten_pv.c +++ b/arch/x86/xen/enlighten_pv.c @@ -108,17 +108,6 @@ struct tls_descs { */ static DEFINE_PER_CPU(struct tls_descs, shadow_tls_desc); -static void __init xen_banner(void) -{ - unsigned version = HYPERVISOR_xen_version(XENVER_version, NULL); - struct xen_extraversion extra; - HYPERVISOR_xen_version(XENVER_extraversion, &extra); - - pr_info("Booting paravirtualized kernel on %s\n", pv_info.name); - pr_info("Xen version: %d.%d%s (preserve-AD)\n", - version >> 16, version & 0xffff, extra.extraversion); -} - static void __init xen_pv_init_platform(void) { populate_extra_pte(fix_to_virt(FIX_PARAVIRT_BOOTMAP)); --- a/arch/x86/xen/enlighten_pvh.c +++ b/arch/x86/xen/enlighten_pvh.c @@ -38,6 +38,7 @@ void __init xen_pvh_init(struct boot_par if (xen_initial_domain()) x86_init.oem.arch_setup = xen_add_preferred_consoles; + x86_init.oem.banner = xen_banner; xen_efi_init(boot_params); } --- a/arch/x86/xen/xen-ops.h +++ b/arch/x86/xen/xen-ops.h @@ -51,6 +51,7 @@ void __init xen_remap_memory(void); phys_addr_t __init xen_find_free_area(phys_addr_t size); char * __init xen_memory_setup(void); void __init xen_arch_setup(void); +void xen_banner(void); void xen_enable_sysenter(void); void xen_enable_syscall(void); void xen_vcpu_restore(void); From xen-devel-bounces@lists.xenproject.org Tue Sep 07 10:12:45 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 10:12:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180800.327611 (Exim 4.92) (envelope-from ) id 1mNY5p-0008KA-MN; Tue, 07 Sep 2021 10:12:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180800.327611; Tue, 07 Sep 2021 10:12:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNY5p-0008K3-J8; Tue, 07 Sep 2021 10:12:41 +0000 Received: by outflank-mailman (input) for mailman id 180800; Tue, 07 Sep 2021 10:12:40 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNY5o-0008Jt-3Z for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 10:12:40 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 20fda39a-0fc4-11ec-b0e1-12813bfff9fa; Tue, 07 Sep 2021 10:12:39 +0000 (UTC) Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-ve1eur02lp2051.outbound.protection.outlook.com [104.47.6.51]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-32--O8Ql131P1-FXDx8m-4q6A-1; Tue, 07 Sep 2021 12:12:37 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR0402MB2703.eurprd04.prod.outlook.com (2603:10a6:800:ae::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14; Tue, 7 Sep 2021 10:12:33 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4500.014; Tue, 7 Sep 2021 10:12:33 +0000 Received: from [10.156.60.236] (37.24.206.209) by PR3P193CA0016.EURP193.PROD.OUTLOOK.COM (2603:10a6:102:50::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14 via Frontend Transport; Tue, 7 Sep 2021 10:12:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 20fda39a-0fc4-11ec-b0e1-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1631009558; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NoqsE6RzeJ63b2XMCTslouLkpUVTdP62+7GdGZP4LU0=; b=i3CHbROn0nt1byhiqZugM7lG3rh7L2nDA/NFS7+5A1HuvYTBClaMvaAd+eKj9yx6sMO1wn qWIhKx7rqORLqf+Evvgm5EGS1Q3DaxzS8xhHePMR+JfuQOrNkr5+N1zY481k2/RQThZiUb pJ3MtXavHgUfjvoVxJAI1Fe9/81r+HY= X-MC-Unique: -O8Ql131P1-FXDx8m-4q6A-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LnMaN/3OzsXcZ3gXFpzLWzvagDaAfbNrTLv5rFJH+hLkrJJjjTQzG4yzs65RgVJUs0Kw8ZpDQkFKsf0y1Vej/7fcgXASh0HgxKWMOh0dF0kx3MyW2C72peug4iX1OJTNoH3d11gHh899NlWXzmDJm4O2aibvvc27dnTNRYfBhI0sYArEEmT+UgOsbY6+IObrrGuTuQFLrYf55n9kr5L+/P++lSxmrxdMYcfuY99z0O/iXUpDRIQCUHZUsbPLe5Vmkim61pWAeqMRiPFJ+R9dZzXu4VJwFdp490rzp0GmwXpszSskNweay3xsXYuPsIWio28a/6MdnzwY7C2BX4JE5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=NoqsE6RzeJ63b2XMCTslouLkpUVTdP62+7GdGZP4LU0=; b=kge3izk4Fd0bUQuG8G+Snz+9pyivcl9ZW/sw4nSkHSnmV88faIA2+UglbW2bhYyrNQIvQ77m1b39Gckw1myUAZAk68xNRT+7ge/TRVeN8WUYOsL4PrMp9wzzM2bhA1VYQV6t055HNu8YwKv5jQSdMtxUZBnZ9Zdm5mUJgzziC7WdanslfaG5JGoPNoU3WEW04T7nEQmBXChqlxAUSuvHd0CsfO3DWhlw/UdDu2ffORiLfpJKKmW4coqxiCh0NV4+IrPnihyMTYvYeiI87zcG9K9/7u2IdrY32k2k94Z9xyyfe9UgmLDa1egWNyu/x6i0pACDjz/dipv7QLZ/WEBlJg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com; Subject: [PATCH 8/9] x86/PVH: adjust function/data placement From: Jan Beulich To: Juergen Gross , Boris Ostrovsky Cc: Stefano Stabellini , lkml , "xen-devel@lists.xenproject.org" References: <4efa804e-3250-227f-00c7-347581366cd4@suse.com> Message-ID: Date: Tue, 7 Sep 2021 12:12:32 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: <4efa804e-3250-227f-00c7-347581366cd4@suse.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PR3P193CA0016.EURP193.PROD.OUTLOOK.COM (2603:10a6:102:50::21) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 68249380-d5a4-4ca9-8f0e-08d971e8026e X-MS-TrafficTypeDiagnostic: VI1PR0402MB2703: X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6790; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: fG3g44J0l6hwlac5jI3G0mfTy/DXJoU+bFuTnoRWmaEf0fUH+NouvKFRCJqleNM3Yb3gjMsn/BozIZAbIZK/3cLVsMMewJC4KlWCjIXWX6IYo7xbUgU7yj9Z7AQFEhtlG3bmJUsr0aLhLj3BK913X/AnehzXCPL50ADvGhxuJCGFj9wj2UJcaMy7ToverXo3VP/SXjRwYjAn4gwFjvo6hrKEu6e4IP3XkRahrn/hzlUSaSf2DhNK2N0hL3FnMHXTQ0WqZ3/yUQES+MY7d9+ymH/rB0fhenJMEeiUnUWKnyt7k34hhJa7W60qg1sWDeiOY40GiktubBvGPNtJjzXR+EkDzeHQFsEuxE3NQxfKkFApH2F/ji2XjnRrzn7PJJl8kAA8qSvpi9gtbfZiFNzz38tYNfBUUG4hhB+7281pXeztqvnPAxe2B7PpYqfy8rLJAgf9I2N3KsjN98u33Aw7mgnLgAnZ1nvHs0P274ITf5K+lc+EGFTMZwIlkUJTVGmueHy5tkAtxibFWUEVYSqnIy4lztJyYnW4QLmufrh1B8n3rVSXI67DBW8ucjrkGvncANLYqpfIh0jZleiD4XotAGmph46ZUGqdgwfMZhlmaaCMW1I50HPPA+p1JgOS7TpdgaMnzYy5SrgV2iU0QrKafPx/P+t95+UBIrnGb1lKJnADd5dEFoXY776y4Xk+yPODEIBtYoQ7ws9EhuuzBp2356BXRhIsdsHtQ1SmdFa2BxI= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(396003)(346002)(39860400002)(366004)(376002)(136003)(4326008)(186003)(86362001)(316002)(16576012)(8936002)(31696002)(478600001)(8676002)(36756003)(2616005)(956004)(31686004)(38100700002)(2906002)(26005)(66476007)(54906003)(66556008)(6486002)(5660300002)(110136005)(66946007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MXRxamZQT3A4WnRGMkRhVDlQYVlqVjFIdjNZUmVXMlQzTFdwRHBIOU5saGJW?= =?utf-8?B?cHprTnNybEVhRXFyY21PVXZOd3duRmJGTDJiUFQvLzErSzFiZ2d0VUJsRUNh?= =?utf-8?B?eGJNaDgrTkpDdnFaMlhBRmNwcVI1aXhCbWJTZlJPNzJRVWt2REl3QkVIK1BX?= =?utf-8?B?SWZPYTl5RUdlWW43TTlHL3Z6Mm5BYWphVVRkMkNsNDJWRmNKZXlWNDNPZGI5?= =?utf-8?B?TGl6dHcwV3ErSm93NDc5cjhQYzZPTklpSWdaeDBOUWZua2FSRlVGdUFCaHla?= =?utf-8?B?aG4zMGxmV2VSalpWOVRzQ013VDZMd0cyVXJHRERFejJ4L1U4Lyt6eitRTUcv?= =?utf-8?B?Wk9HZnBnZ1ZuaUlDUm0yNGJSMFZBNDhNQUtxN3RVTHh5RWlRZWxxTXVRdXFX?= =?utf-8?B?bWYyektmYWhXc3JQNE00TVQ5MjFpdzJiampaeERHM1krcUtKRVl0RlphTng1?= =?utf-8?B?OWtHRW5CYW0ySWJNRHBHVUZIZ21DcXNUV01ZaG1HTWFma0x5NHkrNWpuemJR?= =?utf-8?B?ZU13S2E5SDNSWTYwckVXdkNVaFd6MjJaUkQ0anp1UEFOQ0VzbVkvcjhMSjBp?= =?utf-8?B?VjlmaEFLb2s2V1dyQWs4cGFmcm5HdHJpb1hRL1hOcm1BWHBKMVZ5azRmemlU?= =?utf-8?B?NVd1SU5MVkpnbGl6VTFSMmRCQWFMb3RBZlY0TVkrd0lRSlFxSUl3USs2bndl?= =?utf-8?B?SlZ2U0VqMXNaS05CUFlrbnNtOTZUSXprb1pMbmdRNzVtMmhHZk5neS9HTFI0?= =?utf-8?B?U1N4QlhhTk1KT0pOb1ZqVVRWb0NBODdxZUdOelA4eG5jWXVXZ0pxWGNpSTdW?= =?utf-8?B?RWhrY1V6UlU1angxZWZJNmFNdU9zTmpldjZnSzRVcW14N1hiV2ZWZ3phVWhm?= =?utf-8?B?cEpScVo0M0Z4R01xTGxSS2t2eldJTC9Pb3ZrZGk0Wm8xbFQveko3Zk1Qb25L?= =?utf-8?B?dEs0SXJSODdQUWRES0VpcVdGQ2ZsU0tuT2FqaTQ3T3Bhb2NpTzZPTm02Ky83?= =?utf-8?B?TDB2eHppT1JzZGJ2eHM1YUJmTHplK0RudGIxdnNsWVAzc3Y3c1dleFYwOCtD?= =?utf-8?B?RFdoNk5pQkY1c2FjanRmY2VJUzUrbmpPdWVaeXlnTjd0aDQrNXUyWnFMOFhG?= =?utf-8?B?anpaYk9aRVhtaE80T3NUUnEybVVzYTFzMUFwSjJ5Y3MxZ1VDK0xvSktDcjZl?= =?utf-8?B?RnEyU1d1KzdvUWhRekx5d1RPRW13R25UMTZiOVR4RVNxRWxNUmFHaHg5MXlJ?= =?utf-8?B?cXRDOUs1cXBPMy9LWFE5RjluWWs0V0NwbnpSTFBGbVRadnFBV0k2YWVQS3dS?= =?utf-8?B?V2FESmMxMU9FSlBCTmdGODYwbkpia0c5MHdjWkRjeFZlYjdnZHZ5bVlBYjlx?= =?utf-8?B?aWdKaVkvbG1SYmJheTZxeTZWNUgzdVRrOHpXSzlXZ1hXMHVPK2tzYzBxRmcr?= =?utf-8?B?d09uYXdqamZQRXVOZmFIL0JiZTJkanZVTzhsWkVEZlh4VVladkY2MzlybFhW?= =?utf-8?B?bXhRd05pSUNxeEtnRjZzVVY2Y21jZDJ3aUUrVzN5OFY5bkFSMjU1Lzh3S2h6?= =?utf-8?B?NS90dUEzUkZPT0lRVGhXb3pqeHpHYk8xdGdMbEo3R3RlU2gzSGtnUmZIOFZC?= =?utf-8?B?cjVJNURqWEcvNGRISWlNTHFLVzFvQWVEdUtsZGR2VjFDUjRyVy9IZEx0RjNQ?= =?utf-8?B?aUVRSEo4by9uUjJObFpwRzYzUUlycXJHSjU3czMweWM1ZWhOS2VTc1ExRGZw?= =?utf-8?Q?+y4oKiIhmNMgYHsIJNYXUUj34aPo4GubsUT43LK?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 68249380-d5a4-4ca9-8f0e-08d971e8026e X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2021 10:12:33.8016 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: HYL9YPnNvYfATx1Ct6kT41TdXHkvilXZ+D11gSzDaxvwQ2EmUjX48GJ5ylrJcqA/67UTDyKYc5b+KiXV+Fy+/g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB2703 Two of the variables can live in .init.data, allowing the open-coded placing in .data to go away. Another "variable" is used to communicate a size value only to very early assembly code, which hence can be both const and live in .init.*. Additionally two functions were lacking __init annotations. Signed-off-by: Jan Beulich --- a/arch/x86/platform/pvh/enlighten.c +++ b/arch/x86/platform/pvh/enlighten.c @@ -16,15 +16,15 @@ /* * PVH variables. * - * pvh_bootparams and pvh_start_info need to live in the data segment since + * pvh_bootparams and pvh_start_info need to live in a data segment since * they are used after startup_{32|64}, which clear .bss, are invoked. */ -struct boot_params pvh_bootparams __section(".data"); -struct hvm_start_info pvh_start_info __section(".data"); +struct boot_params __initdata pvh_bootparams; +struct hvm_start_info __initdata pvh_start_info; -unsigned int pvh_start_info_sz = sizeof(pvh_start_info); +const unsigned int __initconst pvh_start_info_sz = sizeof(pvh_start_info); -static u64 pvh_get_root_pointer(void) +static u64 __init pvh_get_root_pointer(void) { return pvh_start_info.rsdp_paddr; } @@ -107,7 +107,7 @@ void __init __weak xen_pvh_init(struct b BUG(); } -static void hypervisor_specific_init(bool xen_guest) +static void __init hypervisor_specific_init(bool xen_guest) { if (xen_guest) xen_pvh_init(&pvh_bootparams); From xen-devel-bounces@lists.xenproject.org Tue Sep 07 10:13:15 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 10:13:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180806.327622 (Exim 4.92) (envelope-from ) id 1mNY6N-0000UB-0N; Tue, 07 Sep 2021 10:13:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180806.327622; Tue, 07 Sep 2021 10:13:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNY6M-0000U4-TT; Tue, 07 Sep 2021 10:13:14 +0000 Received: by outflank-mailman (input) for mailman id 180806; Tue, 07 Sep 2021 10:13:13 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNY6L-0000Tt-6T for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 10:13:13 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 1fa92911-547c-4530-b653-2e4bcc89a973; Tue, 07 Sep 2021 10:13:12 +0000 (UTC) Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-ve1eur02lp2055.outbound.protection.outlook.com [104.47.6.55]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-22-lAzMNj_cNImWjXxDWmK0UQ-1; Tue, 07 Sep 2021 12:13:10 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR0402MB2703.eurprd04.prod.outlook.com (2603:10a6:800:ae::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14; Tue, 7 Sep 2021 10:13:09 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4500.014; Tue, 7 Sep 2021 10:13:09 +0000 Received: from [10.156.60.236] (37.24.206.209) by FR0P281CA0075.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1e::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.6 via Frontend Transport; Tue, 7 Sep 2021 10:13:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1fa92911-547c-4530-b653-2e4bcc89a973 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1631009591; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uHbz7vDnLyWZn+Vx+UcHtoqyEcsa9/5Gh3CvlM0cqI4=; b=KN6HwClin63jXWvTBny/tu4g59X4oqvx6zcXsbmr3lsCenbIbAJEPtapBNLZGue+NLu6du ygPD2OTXBxtxaG+REhtO8u0hPVDWxebunneTgUCiiX5xFLNuiFhALFBGIwc9piF+U3zlfq qQV70aqbPT+ruBcD9irg6DbgRC0RF/8= X-MC-Unique: lAzMNj_cNImWjXxDWmK0UQ-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CO9BcPUPSzL297plkLrfWFu7JBxYVt7I/sm2DxAIRgrmZVbvi88U8qguy6371yqm9kz8qhMwxhMFFLRlhZ5HY82bQayRNOVCOBIm24CVkrvKHw4FftUdWiMOmcgRDpXOHqTYgFxfUNaYU/yIdNnVvBOCkOwEu83JoWaGYeC3Lta0648dZZsaC9Jsu4+BzQRNV2aMnemE7SNIwIxb2Ocnevp/nvLQy2KaClYIll4E7TCpQVczB7ewPfwjulesVAp66T6xc4Qr73ObL8p1dRSa7pqfu0KJVsiwHi7oL0LWJ6hLCaTisVnRvsFdv8JzX5lYTEgGhpxOAFAH579+F0qz2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=uHbz7vDnLyWZn+Vx+UcHtoqyEcsa9/5Gh3CvlM0cqI4=; b=SV1lgHXViEVBZwaxVWq5uFMF/sQPvP/wYSZD0ULY57z+Y/56InsHTil2/lY9qNm6K86QhRH9xPTfYdOL0l61THIgqSgt1OI2bods2dHS3917F/K3IG0PJZo49riBhXU6y0Pfi66Hu0ozpLtWJYRaQjWqib8uI2OUIyhz1ipxhA5woFhokQb2P6ZLdHsqOC5/hXvsqtt0gijogZNeqcdzoHQmK3QJd1PGi0H7oNQokQDLjjY+BxkWNfe9/qU7oA0XzkfOSDZKavbrMZfqUO0k11b9xnvJ72b1q4lJyqNuxzCKUoFuVhMpApnBY0XG3Lhm4ePisABDVehASkMDl+fvQg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com; Subject: [PATCH 9/9] xen/x86: adjust data placement From: Jan Beulich To: Juergen Gross , Boris Ostrovsky Cc: Stefano Stabellini , lkml , "xen-devel@lists.xenproject.org" References: <4efa804e-3250-227f-00c7-347581366cd4@suse.com> Message-ID: Date: Tue, 7 Sep 2021 12:13:07 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: <4efa804e-3250-227f-00c7-347581366cd4@suse.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0075.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1e::10) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b22900b5-8fc6-421e-fa29-08d971e81776 X-MS-TrafficTypeDiagnostic: VI1PR0402MB2703: X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7219; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: uCMHuxX+xBvqr/iRMqO1XJwMYXmryJxG883EB/0M+NJsvlk+2wfaxDxFYjarYaf5aSVvzXW+pAZIIL/8tNo1cHdqWvzHsw3su7eudn8OT+5ARcRu/DqaHB9F4yuBy9UBAetQgm5eLw9OLeJDTe05/2xiVLHTe1KNFmasosWjJaXPWMIiGyHAnmiPD8t+VTIaoT4uHb8rZtG4xehUe6SIVE/b0HUkJM23XtwqLIgp0qX5HRiiyD82W7v814NwKhwZVckgq4umi3P6GukOc0RxMaJBqWY+m1LASLP24cCPPEApKFnso3KAxk9ly3+H3eVj/bhyT56R+1FpxD4elSqVwhTvsatXAUULBDJnBfsnKIbExC8SQ4q+4RNQIdojr5VXnuHnGwlTYWqRDGNX1nEWOiITI/CyBfubhULG6toIKJuyvIYuhl1bHzl3qkq/SVraeeShzupa1Wt4aV7A0rkSimRCzD4WLCVHP898z4I3stH3aJsd2Z9a8u4s7YNPZXyoq1Irnc1UcFDqUFn7u2qiUeN8te5H5pTGSiQDWEAVWSxuODhevEW6fhLW2dwIQaawjfYbEL8H2yCdKP9URsVNPA5QlZVwCWC5VLG1TGwGZHJxsMChbjPHewyU2s8jRijHNOGGNayhC/117DpchPBWi2dpZS0NEkAB7PzMw1pmvUAcUyEfODjNouPq27hACyNU+UbPpCAAIC7iOKqKxD2xXmkbjt5ySfNnYTtrbdclUxE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(396003)(346002)(39860400002)(366004)(376002)(136003)(4326008)(186003)(86362001)(316002)(16576012)(8936002)(31696002)(478600001)(8676002)(36756003)(2616005)(956004)(31686004)(38100700002)(2906002)(26005)(66476007)(54906003)(66556008)(6486002)(5660300002)(110136005)(66946007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WGNlRVk1NHd6cFpWVnIrb3F3bEYxSHJlTmF1ek9DcUYvblUzNWwwZWx2NWo0?= =?utf-8?B?Q3hDcnV5NHA5bW1uekFzNVZqRXlET01yUGJ1WjM0NktmQmJrbkFPQUx6SXhB?= =?utf-8?B?d2p2a2E1ZUdLZG1hUE90d3BaT2RHcm1SM29uM3N5Qjl4UFl0TDFDdmtDZGxW?= =?utf-8?B?bTZ5RmU3MkordlJXL0oxeXBSbmJ0ckNHUHdGU2Rnakg2RElGY0IvUDdGZW4y?= =?utf-8?B?SWMxc0JBVDNrMnMra3ozbkNtMkQyVkVyQXRGTDJwSzBBeXZHaUVBK0VWdFpp?= =?utf-8?B?TU5GTExoaXlCazc0NWhmeiszdDgzaXlUZTlnSzJSdEg4VDF3MzluVHVQa1F3?= =?utf-8?B?YXk1VlJxSUprR254ODBIOXBKcjRqOTducHp3NnBnZFBySzZ6SG9DeXI2clFI?= =?utf-8?B?R2VieUIvVnNMblZkNDNTVEJONEFZbTBEMHpNbmdIQ0FSMjlVOE9vK1B5R0lP?= =?utf-8?B?QkpKRW1MWUNjd28zUmhlV2Q1TWJxQjhzWlg4VWgyYzRPMFd3NlZ3ZS9DN3Yy?= =?utf-8?B?Qk1aZXJKcTQyQThtdnVXaVFid2dKSzUvdmczSlFCWHV3TmUvRlhaYThXODlm?= =?utf-8?B?TGJ4UzdoVEQ1d3B5aHJiNHZ4NmpOV2pOa254T3F0YnpFWlhGSk52OXM4NjNT?= =?utf-8?B?RWFZVFVORlNrbzBjMlovaDlDZWRCVDZWTDQwK0tFclpvaXQ2d21ZeFBWVDUr?= =?utf-8?B?TkRUT2xuaCszVmRlOTdXVUVQb0NGL3o0V2JzTGh5dWkzOWVqTERZRjVmeS9U?= =?utf-8?B?aEFZZWd2WVlIM2RlWmVtYjh5NGNXMlBMWUxvYzhVWU5vTDN0UERPaEozR3Zw?= =?utf-8?B?NHovNVlUS3F0R3NidUFhYTFOWDhJZnJ1ZS8wclArWnMwaUFmNE9YNm91bDcw?= =?utf-8?B?dHBHaUVVdnZOYWNoNGR1Qkd1L0ZHcDdScno1eTFSOE1HVSt5aW1GNU5PY3FD?= =?utf-8?B?Nm1aQS84cnpWQzdzR3VJTlNJcXRlVUhXQXJIN0ZqQnFEdnNmR2VCNnZBSFZa?= =?utf-8?B?bHlCRlBzVDN1eHdHS2VaTFVUa2VMQTg0VldJcXlZcFBRVEZBc2dldHNIa0ti?= =?utf-8?B?QUxHN3NBN0lVNXB0RkN5aVIyOHhMSzBMcG9yWG9QV1RkMk4yZUtrcGIvMStn?= =?utf-8?B?VE8wZk9FSVo1RTA3SmtoREVjSStGQmduTFJiUHdmMHE4MU1hVlVyLzZuV0Nn?= =?utf-8?B?NFJxVDBHeEtHNW1FNi9XTkcwd0JMMFNlTUpzUDdaUDlKSUpEWlg2Q1l0VTB1?= =?utf-8?B?bCtGTUM5cXZCTm9yMnQyTS9vNm1BMElqdE5jZ3RLSVRJUTN0OGg5VTVHWjd2?= =?utf-8?B?ODAzQ21OeFR2ZmdSL1ZRZE93WW1EbWMrNGZwUEk2SDJwejJtbjhrWWVnVlM2?= =?utf-8?B?YXNHNmhjTml3TXBibTlUK1AxSm9zNWhGamduK0V5WUZiakw5UDhxaHBBakcr?= =?utf-8?B?T3Nsd2s1b215SkY0NjFTOTRhRkwwYzg3b2tzQjM2RkdHUEZkMlJSTFBnWlNm?= =?utf-8?B?dlNJUzI1TGV1VEl3eDFxWXZnZlJvelZUVTI2OGM2V0s1VkxmU1EyZzVhYzk1?= =?utf-8?B?TjV5V0RqSEl6cjFGOGxnMXdRNllBRHJISFoyaHZXSWZJQk5oeDZvVmdidnJR?= =?utf-8?B?OE84cmxyNE8xVm0wWkkzVGM1cktvUzVDWVNiVlRnajhqcXBVQ0Z3R0NuNXEz?= =?utf-8?B?Wm1VWlF4U0ZOOFptVVhIMEQrNVR3bEZ5SVhaZHFEemZvblZWTDdZckdHcVhn?= =?utf-8?Q?cwyfKC2l3iJ7Px6KrYVYCJyr9ZtMFFFAVHYvlhg?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: b22900b5-8fc6-421e-fa29-08d971e81776 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2021 10:13:09.0759 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +Uj30H/dxCjL3C4AsS8QjgM6Vtm1xcoiuIO9jw3ooI7NZY1d7mgUvG595wG/XmO773j5EXeiB/LXDbGTSMW65A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB2703 Both xen_pvh and xen_start_flags get written just once aeryl during init. Using the respective annotation then allows the open-coded placing in .data to go away. Additionally the former, like the latter, wants exporting, or else xen_pvh_domain() can't be used from modules. Signed-off-by: Jan Beulich --- I have to admit that it is completely unclear to me which form of exporting I should have used: xen_domain_type is GPL-only while xen_start_flags is not, yet both are used in similar ways, extending to xen_pvh. --- a/arch/x86/xen/enlighten.c +++ b/arch/x86/xen/enlighten.c @@ -75,7 +75,7 @@ EXPORT_SYMBOL_GPL(xen_have_vector_callba */ enum xen_domain_type __ro_after_init xen_domain_type = XEN_NATIVE; EXPORT_SYMBOL_GPL(xen_domain_type); -uint32_t xen_start_flags __section(".data") = 0; +uint32_t __ro_after_init xen_start_flags; EXPORT_SYMBOL(xen_start_flags); /* --- a/arch/x86/xen/enlighten_pvh.c +++ b/arch/x86/xen/enlighten_pvh.c @@ -1,5 +1,6 @@ // SPDX-License-Identifier: GPL-2.0 #include +#include #include @@ -18,10 +19,11 @@ /* * PVH variables. * - * The variable xen_pvh needs to live in the data segment since it is used + * The variable xen_pvh needs to live in a data segment since it is used * after startup_{32|64} is invoked, which will clear the .bss segment. */ -bool xen_pvh __section(".data") = 0; +bool __ro_after_init xen_pvh; +EXPORT_SYMBOL(xen_pvh); void __init xen_pvh_init(struct boot_params *boot_params) { From xen-devel-bounces@lists.xenproject.org Tue Sep 07 10:43:42 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 10:43:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180815.327633 (Exim 4.92) (envelope-from ) id 1mNYZj-0004Wb-Dv; Tue, 07 Sep 2021 10:43:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180815.327633; Tue, 07 Sep 2021 10:43:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNYZj-0004WU-Af; Tue, 07 Sep 2021 10:43:35 +0000 Received: by outflank-mailman (input) for mailman id 180815; Tue, 07 Sep 2021 10:43:34 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNYZi-0004WO-SB for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 10:43:34 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 7173c848-0fc8-11ec-b0e1-12813bfff9fa; Tue, 07 Sep 2021 10:43:33 +0000 (UTC) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04lp2050.outbound.protection.outlook.com [104.47.12.50]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-11-sOfWlC9eM2-V1hDdeaL0tQ-1; Tue, 07 Sep 2021 12:43:31 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR0401MB2448.eurprd04.prod.outlook.com (2603:10a6:800:52::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.22; Tue, 7 Sep 2021 10:43:29 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4500.014; Tue, 7 Sep 2021 10:43:29 +0000 Received: from [10.156.60.236] (37.24.206.209) by PR0P264CA0221.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:1e::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Tue, 7 Sep 2021 10:43:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7173c848-0fc8-11ec-b0e1-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1631011412; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hAQn0uoWIlnVXTNyX1uoYabT8MPDY2xA0mxqdTElNQ0=; b=nf/EzMuQaZe/EuZ4y8PGSEtmg4UGNNXXm9jWVB1x+r9tY1HAkIc0R3TNFPMALiGEeK2dmN RLCs+A78JH1lGq0Mjb9ruxuHhLI7bCroTfdFNlh5cZ6QZmrnzXGpgFnE9LpUO77gIiYimw Q4XUpPWzyF0FZaBilcDX3yvExVwcHTA= X-MC-Unique: sOfWlC9eM2-V1hDdeaL0tQ-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ebS6Ub0ovREellpTEBZnOSodFvX989VljNe8KiBejqk6xLcuJIvQhbaZ7byATllYVCGsVbVpp8GQcSEptt+CbxmzlxWlkboikksCemZC0t19D/UlGXoX23QWJUa7cXPfvDAVjdleLk7zCKoSNUXU4MJGvEb8NMpj37dEPQsv6uwb/maHREMKI/23BpATpwtVvj+3Is3/29SIwkz21e4rcHrtZx7j2jrR+qXOPkBhSyuCj8vJ5TCzaeKjv54OZHVyYRU4dXtFUD8MNdY9DQfjtRQNLSOtXBUC7wis57tegU4pKBI8EYYZTuHC7sbkt2jUkdQ2aLTiuNaKvShnXpi2Rw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=hAQn0uoWIlnVXTNyX1uoYabT8MPDY2xA0mxqdTElNQ0=; b=LPwy3NKCnXoPJVoqLhawWWbs2OKaqWB9NjdrU9SznR60GbBaiYS9Qg7MBkuCN5Sn8hacZ8bvswg0EnXaXYRzBBYufjGRtj2QwBCmYDJfDsRK5xbHXEjqvOYJiD+IjGeM3prKfDlEY2n0kH9Ujue0sk59IZSe3/u23/eKzv7ttgwUG2eVuKdTTWkeHYEEjKlrZJVgmyz7LmdQQNv5E4MrFoo765Jqz4yZGwpNZrVH/Wh9kC8umaREyi5YDEa29Q41feWFhfMFdSeX9FzKaiHQdnwQllOEA5EC5zFhVDkcXivXkWxiKqVQWc+cb8n0Gn+JO7ZN3RRUOTXClHgby3NwKQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com; Subject: Re: [PATCH 4/9] vpci/header: Add and remove register handlers dynamically To: Oleksandr Andrushchenko , Oleksandr Andrushchenko Cc: "julien@xen.org" , "sstabellini@kernel.org" , Oleksandr Tyshchenko , Volodymyr Babchuk , Artem Mygaiev , "roger.pau@citrix.com" , Bertrand Marquis , Rahul Singh , "xen-devel@lists.xenproject.org" References: <20210903100831.177748-1-andr2000@gmail.com> <20210903100831.177748-5-andr2000@gmail.com> <8bb58d2d-255b-96e9-50ff-529985c655d5@suse.com> <16e396be-89f5-4d42-d57b-d91f09b70644@epam.com> From: Jan Beulich Message-ID: <00bbe12b-6a79-e660-c5c1-57ccb200d2eb@suse.com> Date: Tue, 7 Sep 2021 12:43:26 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: <16e396be-89f5-4d42-d57b-d91f09b70644@epam.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PR0P264CA0221.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:1e::17) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e4ad2d90-1138-419b-24c4-08d971ec545f X-MS-TrafficTypeDiagnostic: VI1PR0401MB2448: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Bl9Wt7VdahHDctMw47ZPujEJbZgzQqzqB8HD+02GhHy2Z2nWU76doOtv6y1gXhRsvpaW+4bIrFby2aZ9pgSoFJkXy6PiQZX5Zbpa0z0dZrKdbQix6s3rYCvnSxACDL4u7yqIURQARCGjgjJjZ+ch9IWK/guEveJR8BCBRQ0RtHpX+ppSj4YkozWPbaPvFlO1zLg7H22z2R3Nr+4jUUeGNcGkCiVlvZOPGCt1fNWWmI2BwKfk2R05EsIfGb7fKiK1KlfwvUkQ44DF/oAHOw23wRHbFTPXlfr+tHzkaHvNP2nbLLa7nwRDNV4DzcmMPzCTckK1J+IecrFATD8iNO+gxCGL0Ly5A5aAfu4zmeBCHKJ+tPcN9FpaLCSOCevN58V9VjVMmbxNhGSLroiWZzbvCtsjLuZT6YS6ldM90nRTZCce+kifVa3K4dfkarMombraFctVnep1GHVevTj3yectgwBt/trCUL6QOolVQyQXn9sgmh7tr3/RzNF/48cCXlHZNDBrBi/QN1ELASzpZPDSkRH1WfCTbm9fHDORSPdURjjE6jPZyake0u0tW7eIHueJ5ytWfLpyLNgGGhhxqRJwRExGU/5VL//trPhkXd2dfOAh5eWWEIsBvsbQfL6ddiayHFWMb1Baaa94UeTz6QDVymJm5Ybebq+XtdQIVrWapwsASgh048loPkMnPHAnnOwWvcOCWC7odghxPnEPXaUvLTzRVA5orilOXb2udm/6l4Y= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(346002)(136003)(366004)(396003)(376002)(39860400002)(316002)(478600001)(38100700002)(5660300002)(26005)(31696002)(86362001)(2906002)(53546011)(186003)(6486002)(8676002)(66476007)(66946007)(8936002)(66556008)(31686004)(83380400001)(2616005)(956004)(7416002)(16576012)(36756003)(4326008)(110136005)(54906003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YUtVUmxvMFJtRnhMdk9Zc2duVXhURmtkZkxaREI0ZW51NU9JZDdXYVhGbmRR?= =?utf-8?B?Vit6YnpPb1JQK0EwZXVTcjJxK1I5OWlBaFZlZHh3NkQzaDFFajd4L1g5aFhP?= =?utf-8?B?NWZYbHVIZk1UaDNmcFBzZjJ4RU1hWlF2Q3BBZ1JVV3dtNmtzVmI5NzVVbVNh?= =?utf-8?B?ZWw3ZGxCT2NXS0FNK1VFRm05K0pBRlpvWk5EeW9qa3R6ZjdXalNjTVdHSXVz?= =?utf-8?B?enR5VmVqczdydWRIYnBwMW1VQStYNU4xZ2h6T09scGZpZm4rVEtlQVZCTWd5?= =?utf-8?B?VTVPaHdwWWxwZUVsUmcvclB2UWx6S0ljN2I1TlY3TjRkZ1JpZDlyQSs2clRQ?= =?utf-8?B?QVQzVXZlNHpXUmdsekcrMEJQaXB5cGdpK0taaHRNaVVQWE50MXVadUtOYXZB?= =?utf-8?B?RlNONGJ6ZFVHOUpNbGwyeFp5T0RUcTEyblM3dHE2ZXBOdjN2S2xJanJzdnF4?= =?utf-8?B?WSswUEgyU2x4YkQ4Wlk1MGNLcFFNQm1TRVp6NnVTTGZaV3QrYmwvZ3FKcm1y?= =?utf-8?B?STd3YitWVEFFVXdIQURrTTNHL3dvSWQydXIycWtCUzJJYXNpZklRcmVYSFlh?= =?utf-8?B?eTV3QmNUd3IxbFV4Q2wyS3FSbHFhSmdyVVBzQ1l5a2N6Y1Y5dzhnVWErUlha?= =?utf-8?B?QllJSkdBS0lGemZIMjZuVEExMWdHa0k5TEIzR2h0UE8yQ2YzZmRrdVpPdnUy?= =?utf-8?B?c09mRjdVK3JuMUtCV2FnbG44b25nQWZYTkMxQzVYQlF1TE1UcTVaYTVsQk1Q?= =?utf-8?B?ZjhIS28zbW53NmxsWThtdnlNei9ja0VxMU1RM082ZnpsV2RKVHEyZGxOM2Zt?= =?utf-8?B?L0dUY0NWV2xsdFc4b0tpRWNnamp0ZWozT1BoYmxzOHQ0a1Rpc3U1dEI1RWpq?= =?utf-8?B?TlBWQmhZejg5c1NwTGVTOVRtQnE3ZEE2RXhPUS9IMUQ0YnBPaXhuR2tXZ0hr?= =?utf-8?B?UEdmSnVDS1hVY21PajB3Z2k0S1d6di9IZThMV2pDeml5WktJQVZOdUF5Qzdm?= =?utf-8?B?SDgzd0lkU2JRdHBLTEEwYm9YTHlxU1F6NTZ5UnNmWHAyYVAzOFk5N2F0U2oy?= =?utf-8?B?NFNDRTJxTDJWdHNuS1QrbHJTNUJaT1ZyWG8rYjFCSmhYaDhPR1JucS9qMHcr?= =?utf-8?B?V093UDdBZDluV1FaNlI5dlVzem5GRFFXdDZqbEpRTTVkQnpaSjRKTjZ4L0xJ?= =?utf-8?B?Nnp1U3ZYRUJzcnlwSmpGU0ErSklzTGJrUiswTE92U243UGN6RFFIV29Ta21U?= =?utf-8?B?TUwyck5NUDlYY0t6MWFob0oxbC9pMlAzdFdvUWU1cytBWVpVTUZRRVNEZ3Fh?= =?utf-8?B?eWhSRy9xZnJZanM3Vll4VVoxRkNBN0dPQUROalQ0TmlGbExmbmF0MlU5aXRK?= =?utf-8?B?SDF1S2wrR3poeENKT0xLanRQNlhSRkpacmhjNko2WXRzYmlaU3FtOEZQTDh4?= =?utf-8?B?VDliTEQ0czZ6SnplQnBzbjc0T1lZUTNvVGVjVWhQUDhoSXFkc3BQWTJ4ZFBO?= =?utf-8?B?bWxMdlRIYitSUDFsa2FlUjRNWGE3NmovZHVtTnprTWJvNWhaRTNQTlVpOFRw?= =?utf-8?B?K3BXK3plQ0hZeU5lMGNZTTVocVZuY2FYZks5c2dRQUZIa21wN2p3eVdZSlRZ?= =?utf-8?B?YzlOYkZSejRiT2Z0aFRHbWhHSkNMWjJSYWVYV1VGRyt2TlI5dXczMGl3SlN2?= =?utf-8?B?VWdSZXV3dGUyR1RaUXhKNFpqd1pqS1JaaFVja3NkWCtjRC9QVlBkelo5R0xv?= =?utf-8?Q?Mk6rSMYQSc5pc6DDhFSFgwwyB3vjbZFWgpgbpJ4?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: e4ad2d90-1138-419b-24c4-08d971ec545f X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2021 10:43:29.2427 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: t5VD51ig4A8zNA0EXuPmX1BvK34PiVPm7+HnmoKxJ0i1iACLHUDlBnm9HXl1IW0N9VYwodJzjyj2kxUufLgU5g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2448 On 07.09.2021 12:11, Oleksandr Andrushchenko wrote: > On 06.09.21 17:11, Jan Beulich wrote: >> On 03.09.2021 12:08, Oleksandr Andrushchenko wrote: >>> @@ -593,6 +625,36 @@ static int init_bars(struct pci_dev *pdev) >>> } >>> REGISTER_VPCI_INIT(init_bars, VPCI_PRIORITY_MIDDLE); >>> >>> +int vpci_bar_add_handlers(const struct domain *d, struct pci_dev *pdev) >>> +{ >>> + int rc; >>> + >>> + /* Remove previously added registers. */ >>> + vpci_remove_device_registers(pdev); >>> + >>> + /* It only makes sense to add registers for hwdom or guest domain. */ >>> + if ( d->domain_id >= DOMID_FIRST_RESERVED ) >>> + return 0; >>> + >>> + if ( is_hardware_domain(d) ) >>> + rc = add_bar_handlers(pdev, true); >>> + else >>> + rc = add_bar_handlers(pdev, false); >> rc = add_bar_handlers(pdev, is_hardware_domain(d)); > Indeed, thank you ;) >> >>> + if ( rc ) >>> + gprintk(XENLOG_ERR, >>> + "%pp: failed to add BAR handlers for dom%d\n", &pdev->sbdf, >>> + d->domain_id); >> Please use %pd and correct indentation. Logging the error code might >> also help some in diagnosing issues. > Sure, I'll change it to %pd >> Further I'm not sure this is a >> message we want in release builds > Why not? Excess verbosity: If we have such here, why not elsewhere on error paths? And I hope you agree things will get too verbose if we had such (about) everywhere? >> - perhaps gdprintk()? > I'll change if we decide so >> >>> + return rc; >>> +} >>> + >>> +int vpci_bar_remove_handlers(const struct domain *d, struct pci_dev *pdev) >>> +{ >>> + /* Remove previously added registers. */ >>> + vpci_remove_device_registers(pdev); >>> + return 0; >>> +} >> Also - in how far is the goal of your work to also make vPCI work for >> x86 DomU-s? If that's not a goal > It is not, unfortunately. The goal is not to break x86 and to enable Arm >> , I'd like to ask that you limit the >> introduction of code that ends up dead there. > > What's wrong with this function even if it is a one-liner? The comment is primarily on the earlier function, and then extends to this one. > This way we have a pair vpci_bar_add_handlers/vpci_bar_remove_handlers > and if I understood correctly you suggest vpci_bar_add_handlers/vpci_remove_device_registers? > What would we gain from that, but yet another secret knowledge that in order > to remove BAR handlers one needs to call vpci_remove_device_registers > while I would personally expect to call vpci_bar_add_handlers' counterpart, > vpci_remove_device_registers namely. This is all fine. Yet vpci_bar_{add,remove}_handlers() will, aiui, be dead code on x86. Hence there should be an arrangement allowing the compiler to eliminate this dead code. Whether that's enclosing these by "#ifdef" or adding early "if(!IS_ENABLED(CONFIG_*))" is secondary. This has a knock-on effect on other functions as you certainly realize: The compiler seeing e.g. the 2nd argument to the add-BARs function always being true allows it to instantiate just a clone of the original function with the respective conditionals removed. Jan From xen-devel-bounces@lists.xenproject.org Tue Sep 07 11:02:06 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 11:02:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180823.327644 (Exim 4.92) (envelope-from ) id 1mNYrN-0007QB-UP; Tue, 07 Sep 2021 11:01:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180823.327644; Tue, 07 Sep 2021 11:01:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNYrN-0007Q4-Qe; Tue, 07 Sep 2021 11:01:49 +0000 Received: by outflank-mailman (input) for mailman id 180823; Tue, 07 Sep 2021 11:01:49 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNYrN-0007Pt-0x; Tue, 07 Sep 2021 11:01:49 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNYrM-0002Hu-Ra; Tue, 07 Sep 2021 11:01:48 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNYrM-0007zl-Iq; Tue, 07 Sep 2021 11:01:48 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mNYrM-00069J-IJ; Tue, 07 Sep 2021 11:01:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=U8Tws86ms3G3xPU9BlXML1AV03LC9htzmTEZjqahcwI=; b=BlKy9R1i7OlHVl54yRkzIf/eqA +BqO7xxTfNbidYoBaLifnHZZHMy6/nFfHvYfHEZob0qSANudps8s00hBuLCwzLpdkzho5yFtxV7Zz 6ZkcDw4buxoj0uWk9JLjvv0gvsqyMciYYfAaZQyajXlDiONUHQnOws+rW4VV0bZQ2ZR8=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 164870: regressions - FAIL X-Osstest-Failures: libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=8f8eeb3750ae410e4b6fa96a2a559e0d9960716c X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Tue, 07 Sep 2021 11:01:48 +0000 flight 164870 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/164870/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a version targeted for testing: libvirt 8f8eeb3750ae410e4b6fa96a2a559e0d9960716c baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 424 days Failing since 151818 2020-07-11 04:18:52 Z 423 days 414 attempts Testing same since 164870 2021-09-07 04:20:08 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Andika Triwidada Andrea Bolognani Balázs Meskó Barrett Schonefeld Bastian Germann Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Bjoern Walk Boris Fiuczynski Brian Turek Bruno Haible Chris Mayo Christian Ehrhardt Christian Kirbach Christian Schoenebeck Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé Didik Supriadi Dmytro Linkin Eiichi Tsukata Eric Farman Erik Skultety Fabian Affolter Fabian Freyer Fabiano Fidêncio Fangge Jin Farhan Ali Fedora Weblate Translation gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Hela Basa Helmut Grohne Ian Wienand Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen jason lee Jean-Baptiste Holcroft Jia Zhou Jianan Gao Jim Fehlig Jin Yan Jinsheng Zhang Jiri Denemark John Ferlan Jonathan Watt Jonathon Jongsma Julio Faracco Justin Gatzen Ján Tomko Kashyap Chamarthy Kevin Locke Kristina Hanicova Laine Stump Laszlo Ersek Lee Yarwood Lei Yang Liao Pingfang Lin Ma Lin Ma Lin Ma Liu Yiding Luke Yue Luyao Zhong Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Markus Schade Martin Kletzander Masayoshi Mizuma Matej Cepl Matt Coleman Matt Coleman Mauro Matteo Cascella Meina Li Michal Privoznik Michał Smyk Milo Casagrande Moshe Levi Muha Aliss Nathan Neal Gompa Nick Shyrokovskiy Nickys Music Group Nico Pache Nikolay Shirokovskiy Olaf Hering Olesya Gerasimenko Orion Poplawski Pany Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Richard W.M. Jones Ricky Tigg Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Shambarger Sebastian Mitterle SeongHyun Jo Shalini Chellathurai Saroja Shaojun Yang Shi Lei simmon Simon Chopin Simon Gaiser Simon Rowe Stefan Bader Stefan Berger Stefan Berger Stefan Hajnoczi Szymon Scholz Thomas Huth Tim Wiederhake Tomáš Golembiovský Tomáš Janoušek Tuguoyi Ville Skyttä Vinayak Kale Wang Xin WangJian Weblate Wei Liu Wei Liu William Douglas Yalei Li <274268859@qq.com> Yalei Li Yang Fei Yang Hang Yanqiu Zhang Yaroslav Kargin Yi Li Yi Wang Yuri Chornoivan Zbigniew Jędrzejewski-Szmek zhangjl02 Zheng Chuan zhenwei pi Zhenyu Ye Zhenyu Zheng Zhenzhong Duan jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 71974 lines long.) From xen-devel-bounces@lists.xenproject.org Tue Sep 07 11:07:12 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 11:07:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180830.327658 (Exim 4.92) (envelope-from ) id 1mNYwX-00086V-Hg; Tue, 07 Sep 2021 11:07:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180830.327658; Tue, 07 Sep 2021 11:07:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNYwX-00086O-ER; Tue, 07 Sep 2021 11:07:09 +0000 Received: by outflank-mailman (input) for mailman id 180830; Tue, 07 Sep 2021 11:07:08 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNYwW-00085T-Lk; Tue, 07 Sep 2021 11:07:08 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNYwW-0002NG-Gr; Tue, 07 Sep 2021 11:07:08 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNYwW-000893-6F; Tue, 07 Sep 2021 11:07:08 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mNYwW-0002KJ-5j; Tue, 07 Sep 2021 11:07:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=M63KrIA4eeoRfQIlmBDz/bKKgsssf+hstv0t3aEBzmM=; b=sZ/FfmFSS7NtzYqmsDccsoQzga W9pspFqdrivKlyl5WMYJ+9uszLBF2CVzYsuvWefZuvrx+mmid6MDgQzdwgLYhIxG7KB7j/QVaOyzX YgfvIncIoWOBN96r0+4YtOL2iFMJJnxu3d3bCkRhTwqF74q98ai9wOpI0G8e1y15gWCA=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 164866: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=6c27a8da8d2024aa78a9ec67bcfb18c123e84a17 X-Osstest-Versions-That: xen=2d4978ead4b98452bc45ebe47952e524b12e2b41 From: osstest service owner Date: Tue, 07 Sep 2021 11:07:08 +0000 flight 164866 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/164866/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 164848 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 164848 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 164848 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 164848 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 164848 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 164848 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 164848 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 164848 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 164848 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 164848 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 164848 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen 6c27a8da8d2024aa78a9ec67bcfb18c123e84a17 baseline version: xen 2d4978ead4b98452bc45ebe47952e524b12e2b41 Last test of basis 164848 2021-09-06 01:51:30 Z 1 days Testing same since 164866 2021-09-06 23:07:48 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Michal Orzel jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 2d4978ead4..6c27a8da8d 6c27a8da8d2024aa78a9ec67bcfb18c123e84a17 -> master From xen-devel-bounces@lists.xenproject.org Tue Sep 07 11:10:22 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 11:10:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180838.327671 (Exim 4.92) (envelope-from ) id 1mNYze-000168-6o; Tue, 07 Sep 2021 11:10:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180838.327671; Tue, 07 Sep 2021 11:10:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNYze-000161-2u; Tue, 07 Sep 2021 11:10:22 +0000 Received: by outflank-mailman (input) for mailman id 180838; Tue, 07 Sep 2021 11:10:20 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNYzc-00015t-37 for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 11:10:20 +0000 Received: from mx0a-0039f301.pphosted.com (unknown [148.163.133.242]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id ba463846-66eb-43ae-8be8-af80615d07b8; Tue, 07 Sep 2021 11:10:19 +0000 (UTC) Received: from pps.filterd (m0174677.ppops.net [127.0.0.1]) by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 1879h71j030311; Tue, 7 Sep 2021 11:10:16 GMT Received: from eur03-ve1-obe.outbound.protection.outlook.com (mail-ve1eur03lp2050.outbound.protection.outlook.com [104.47.9.50]) by mx0a-0039f301.pphosted.com with ESMTP id 3ax3d2rtyj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 07 Sep 2021 11:10:15 +0000 Received: from AM7PR03MB6325.eurprd03.prod.outlook.com (2603:10a6:20b:13c::18) by AM6PR03MB3959.eurprd03.prod.outlook.com (2603:10a6:20b:20::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.22; Tue, 7 Sep 2021 11:10:10 +0000 Received: from AM7PR03MB6325.eurprd03.prod.outlook.com ([fe80::d9b7:c0ab:2c2f:5b44]) by AM7PR03MB6325.eurprd03.prod.outlook.com ([fe80::d9b7:c0ab:2c2f:5b44%3]) with mapi id 15.20.4478.025; Tue, 7 Sep 2021 11:10:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ba463846-66eb-43ae-8be8-af80615d07b8 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YR0VHE9EsYK0tB1QbfJwiv/Jjpug1suw4B/TxtXJXKaXrqyi2kh0zbxQoHvXcIE4nlFu68Ou7hK29HGBPl5Ro9/i/wiQ4F3AwNI2dFVXhPRQUEqNF0iT9qR+V2wGoBlwiMJ9rr810YuOShmOtBp8kPT5C8Xzt6wZ9C063Ap3jh1G2EttWwIyKpT41bPMqxNRDUDTU3vwsjGwAwg4YBfRYCmWX0jZDUq3GCQxeOWErVFVb8gmuHT18D9EdtKXv/faBdGIZuQ/WcA9/4hJMxRsykqv56RdUg9Oh9cxKX9LoRO66m3eAdqsp3erkoevrFgtG7gfSIe5Z3iyvZ8bb0AQFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=PV70tGGgugQ0qJ9VluEfc8FUAV6SKKq+W2RYBlTHk04=; b=E/xFVVMyev/eaJxmc+SKnxw4W7mjlBXLl0KSnEY/BYgqbbxUgHsU1bbOTvfdVjjQxGrAaZOH5hkkyAqrToSJQ/NJ86e0FQELXiMqnRENYTm4T2JgFJEjf9gKEMc3Dwp1ArHBpwJ7XnO7DXgw5iG1t+R/K/fsKKxGpNIG0G35VEhQXLxrckb2/JJmCu/z9zYksTplz8d8n1Pe8fW2vQOAhRdaHhq7U284az3etEgVa/R7qGr0y0Qnjrjq+2Q8xQOY5PEJSWx2EPcnVk81BDEE7CMX5cZrO9Nm2js7C4wmHkzsgepylPMuiEnG27tMzlsojrxfUiTXUsOZzvBLYhhy8Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PV70tGGgugQ0qJ9VluEfc8FUAV6SKKq+W2RYBlTHk04=; b=Q2FQuaUUFMlML6OpYGJbUspvS4ImPuAU47cLT9lzkPctJ5yA6SqxvVjTtPOJ1qiO7OztqwIErKE+vvG4S0ZO2/f1bLVeZQ8WgecXrb7CMk8lQgwzaJxrABS4BX9gIfssHrOMYMc00PPqmV/IRvSBc8MhsElYyfYfAgn9VsWU24F/AyR98+OjUrQOf/Ndnt/ebZQApNDKVdVPQrvWaNcf9VaRYyX0hXdPMgCcIQeNTwuHRyLA04uAvOmg2ywfdv8h5Y4bRJw+Gw8GjUEZiTK2qcmFDoCDqOaeVxOI2JqhWwG+uyDEuHVeKKsw9utoFbgV1vGqExyWSYFdFsNTES11yw== From: Oleksandr Andrushchenko To: Jan Beulich , Oleksandr Andrushchenko CC: "julien@xen.org" , "sstabellini@kernel.org" , Oleksandr Tyshchenko , Volodymyr Babchuk , Artem Mygaiev , "roger.pau@citrix.com" , Bertrand Marquis , Rahul Singh , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH 4/9] vpci/header: Add and remove register handlers dynamically Thread-Topic: [PATCH 4/9] vpci/header: Add and remove register handlers dynamically Thread-Index: AQHXoKusySJnLVveGkulaWKrBZdXpKuXEOQAgAFPE4CAAAkRAIAAB3eA Date: Tue, 7 Sep 2021 11:10:10 +0000 Message-ID: <242373cf-9854-74b7-4d54-bbcacc6cb7cb@epam.com> References: <20210903100831.177748-1-andr2000@gmail.com> <20210903100831.177748-5-andr2000@gmail.com> <8bb58d2d-255b-96e9-50ff-529985c655d5@suse.com> <16e396be-89f5-4d42-d57b-d91f09b70644@epam.com> <00bbe12b-6a79-e660-c5c1-57ccb200d2eb@suse.com> In-Reply-To: <00bbe12b-6a79-e660-c5c1-57ccb200d2eb@suse.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=epam.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 5376dc28-8c0c-4ec9-d32b-08d971f00eea x-ms-traffictypediagnostic: AM6PR03MB3959: x-ms-exchange-transport-forked: True x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: zOvJSQ988Ul7tKRw1MAwisz3776VbU6uKa4WOkelhFCH/55bPWKoT8eaFUGyDqjNL0Fn9SmsEoQjsXyndChAYM4ilAz2yWYdr0sDZ1choqFJDxzJEbMO4JRDuo5GWbr8I94gCT/Uw1pVDV3o/uWJfwz5MOubJQxHQ381xJuFz8lEZHVipqmSCmhLjZG7ulRQdT+CbpciVYdnVA6DQXiEGlBCYuIKXJK+UKjGu8vArhAFYJLvT2HxsJ4KmHDcaLGJlbRF2UXNlPERQxr1feSeNVw4606TMSiyjPogtPmlFfg4z6v4EJiEL/jk9UlaUQa4m8+eUA1kOJrC4YPwbXiGgGoGFYmHCiQKZmR0fiozXZ9OEL1iOPK+pg/8DaVez/3G+iV9RmdIxktwpo5Fed1bWO5NM0VG7SaLuRRQqlfmgj6TSrWTCtDQGYztBf6SwTzVUD3XijMN4cADL93kQqVcYl/HXlFZSJDFJew0/P4QHtIrqmAWgC6Coow13ZdhZqSJQlQWYufieF07w0mMAQjMiP6983pnPTMm8t8IjCJdhDsHotWhDWrzF8OqCcPrBXHW8zchbJLselLaaP+YJRNAfgLAln64kflGOGNFjQLK+Tm9QXcQ7S9vD2iDJZ6U/Ju0UJ8luZ2EZgM1ODZEJeM1kWLTrq7lRVHCo3oPOAmyJT27tgHXxNaH6OtvUVUTgwiNVGelcPMlTs2IwB7mkr//D86RLlRB5t9QVGmcAI/Ci4mCiZ+9MstB77PFSnQMhDFr x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM7PR03MB6325.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(366004)(39850400004)(346002)(136003)(396003)(110136005)(38100700002)(86362001)(91956017)(6512007)(66556008)(122000001)(64756008)(66446008)(71200400001)(76116006)(66476007)(66946007)(4326008)(83380400001)(2616005)(31696002)(53546011)(316002)(6506007)(6486002)(8936002)(5660300002)(8676002)(36756003)(26005)(186003)(31686004)(478600001)(54906003)(2906002)(38070700005)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?L1hZV1Y4TWJXU25oRUNaeWJjL2RlVHdTMXVUcm4ySE5pWjlrZXlYQnp1Z0Rj?= =?utf-8?B?aW5jV1hlci82UElhNlN6Sy9SSU4rV1pTZ2FPOEp6T0JnRmxlVlhHTGpkUW9G?= =?utf-8?B?T251RS9EaHV1MHYydU11TFBObVNXQ21DS0F0di9NeVBKNU5OSUtud0Z6aGhk?= =?utf-8?B?aWlKaHBTbVdTYzR0cWFxVXBrbVJBblNIb1hjMzJpV3pabkh0RlRXTTE2MWVa?= =?utf-8?B?cThIM3VVTGVDaEpzUWtMSXJDREp0U09pM29tSU9OZEJNaEd3eHREOU5YbjZp?= =?utf-8?B?TXluV2c4U3lidFdEc0dwdDcrMm0yM1VESGF2NFY4Tm9rUXVUdzFyTHFXUTFM?= =?utf-8?B?bUo1c2J6SnhnekI0VDBLbEo5TlFmRkNualpUd1FxR090czRZYWtiWGVicDQv?= =?utf-8?B?UjNZb1FYZlh3L1pGTWlSK3VFeUdpYm5MQXlhdlI4UVZ6bExmV1BxNHhobDJG?= =?utf-8?B?bDFVRGZ1VjBGcjRsWWhCUEd1aTUvYjY5bEpqeE1IWGpTRDB2SmxpV1kxMm16?= =?utf-8?B?d0tKV3g5V0YwSUVMc0R4UEt5VnFSalBLQ2haZS9FNmxFYlFHWmpTTVo1bDhD?= =?utf-8?B?b3FwYzI4YTNMYmQ4RE1yK2sydTMxVEpOekI0eWdUUTdzQi9lSk84UXFqczUy?= =?utf-8?B?QTVhNytPdnlyK01Wd2lNTlVqdm1JZXpsOFNjdkdyR05xOVdlSGxPT1ltT3hR?= =?utf-8?B?R2hoTnB1Qk5UU2ZDSEdpUW5HV0Zod0tnblhoNkppOTd0a09YVG5yK2Nwajln?= =?utf-8?B?RXU3ZWttQTlrT0dsS1F1cTgrMXA3dlpJUW80WmlXaE9nNzRZWmwramNPT0pF?= =?utf-8?B?Skp1ZWhFcXRyUEN3WGcrbXU5eGFIYWxUWUZDMzBpcXBDcm1ZSmRlRnNET3Zn?= =?utf-8?B?d2xiUmVqaHMwQ2JpSUFhQ3IxNnFkalh5ZktQbGgrRWluaDRRdlRNS1UvTlNp?= =?utf-8?B?MkRNYnVSWVNYQndEZGtTZGZLRFRzUmlOM1RzdjFRUDJ2TmhCRzBkak5BY25X?= =?utf-8?B?Q1hQL3VJV1NIclVGVVVzcHB5eTN3d05KTVI0WHRTY1loVjZpRkxZZmc2RDFF?= =?utf-8?B?ZU83MmFBaERTd2RjQi8rV3FuK0ZSWjlEWnNKMVhGaityN29Fc3UvYlVxZXky?= =?utf-8?B?MmNaVlhBbXZ0bDZBaWRYKzZhQWFKRUFnVXJwQW9HWCtsekdCVWlvbGNyTXF1?= =?utf-8?B?b1ovRjg5WXd6VEtVSi93a2x5cElmRlBVeDFkeWQxSmZqYzMrZXdXaVcrSlJN?= =?utf-8?B?SkFlTkN1MXdtaHovdWFHTlhaVzdIcHJYQmVKdDR4V3Z0U25abmFRVTltWVZU?= =?utf-8?B?RU5MbWNlYTVJMGg0dDdkMGVFak95MjZ0OEh0UUM0TmxHZUR0TkhCSzNrempD?= =?utf-8?B?RFZseCtBbjF1ZUs3RWpBa1dXTVRPTjJoZGxXaVJSOXhtVnh4VStMNEF0Rktw?= =?utf-8?B?TVhLa2dlcGt6MXRWaTc2ZWYxZzc3NVlIc3F3MDB3TWtKRDNtY0tOdnRtc0JI?= =?utf-8?B?UHZhYy9NT0pMTk1ITkdRSjk3VndTcDAzL2dnUVgxVmdpSktpOXdBZDd4OUVo?= =?utf-8?B?NHZORld6RnBNRzR0aW1QOC83czJQM3psOFBwVVc0bUhCd3oyV0lwU3lkcUhN?= =?utf-8?B?c3dqdTVmS28zbFVYa09RY2JRZk55a09Oc3c2ZXRhd2F4Zmc0MGVieFpLNUhD?= =?utf-8?B?aGE5MXlkaHdKUFFxeVBQYXdCRDkvQmdBR0VSSVc0c21KQ2NKZmZNY2E5eGFz?= =?utf-8?Q?3WevrmrXVpPwkoahpIQ105CzsIWOjfe+8llZ8Ki?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: epam.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM7PR03MB6325.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5376dc28-8c0c-4ec9-d32b-08d971f00eea X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Sep 2021 11:10:10.4263 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ThyXFsqRQ7QJ2JkPSwkye3Hx5DumtHH6JyD3ihjbNnbJinfWI8fzjHlkTH1Vu/SP+k4UvtgwP1Wh2/DPL7KfSiAQPbjzKaW6nlQ8RX/In/RsqWaLOnIH+OoHWoFIefxH X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR03MB3959 X-Proofpoint-ORIG-GUID: pCZ4OBDrU4JOeyYAQz9IxTjVYs_UdpQZ X-Proofpoint-GUID: pCZ4OBDrU4JOeyYAQz9IxTjVYs_UdpQZ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.391,FMLib:17.0.607.475 definitions=2021-09-07_03,2021-09-07_01,2020-04-07_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 impostorscore=0 malwarescore=0 lowpriorityscore=0 spamscore=0 mlxlogscore=952 suspectscore=0 mlxscore=0 bulkscore=0 priorityscore=1501 phishscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2108310000 definitions=main-2109070074 DQpPbiAwNy4wOS4yMSAxMzo0MywgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDA3LjA5LjIwMjEg MTI6MTEsIE9sZWtzYW5kciBBbmRydXNoY2hlbmtvIHdyb3RlOg0KPj4gT24gMDYuMDkuMjEgMTc6 MTEsIEphbiBCZXVsaWNoIHdyb3RlOg0KPj4+IE9uIDAzLjA5LjIwMjEgMTI6MDgsIE9sZWtzYW5k ciBBbmRydXNoY2hlbmtvIHdyb3RlOg0KPj4+PiBAQCAtNTkzLDYgKzYyNSwzNiBAQCBzdGF0aWMg aW50IGluaXRfYmFycyhzdHJ1Y3QgcGNpX2RldiAqcGRldikNCj4+Pj4gICAgfQ0KPj4+PiAgICBS RUdJU1RFUl9WUENJX0lOSVQoaW5pdF9iYXJzLCBWUENJX1BSSU9SSVRZX01JRERMRSk7DQo+Pj4+ ICAgIA0KPj4+PiAraW50IHZwY2lfYmFyX2FkZF9oYW5kbGVycyhjb25zdCBzdHJ1Y3QgZG9tYWlu ICpkLCBzdHJ1Y3QgcGNpX2RldiAqcGRldikNCj4+Pj4gK3sNCj4+Pj4gKyAgICBpbnQgcmM7DQo+ Pj4+ICsNCj4+Pj4gKyAgICAvKiBSZW1vdmUgcHJldmlvdXNseSBhZGRlZCByZWdpc3RlcnMuICov DQo+Pj4+ICsgICAgdnBjaV9yZW1vdmVfZGV2aWNlX3JlZ2lzdGVycyhwZGV2KTsNCj4+Pj4gKw0K Pj4+PiArICAgIC8qIEl0IG9ubHkgbWFrZXMgc2Vuc2UgdG8gYWRkIHJlZ2lzdGVycyBmb3IgaHdk b20gb3IgZ3Vlc3QgZG9tYWluLiAqLw0KPj4+PiArICAgIGlmICggZC0+ZG9tYWluX2lkID49IERP TUlEX0ZJUlNUX1JFU0VSVkVEICkNCj4+Pj4gKyAgICAgICAgcmV0dXJuIDA7DQo+Pj4+ICsNCj4+ Pj4gKyAgICBpZiAoIGlzX2hhcmR3YXJlX2RvbWFpbihkKSApDQo+Pj4+ICsgICAgICAgIHJjID0g YWRkX2Jhcl9oYW5kbGVycyhwZGV2LCB0cnVlKTsNCj4+Pj4gKyAgICBlbHNlDQo+Pj4+ICsgICAg ICAgIHJjID0gYWRkX2Jhcl9oYW5kbGVycyhwZGV2LCBmYWxzZSk7DQo+Pj4gICAgICAgcmMgPSBh ZGRfYmFyX2hhbmRsZXJzKHBkZXYsIGlzX2hhcmR3YXJlX2RvbWFpbihkKSk7DQo+PiBJbmRlZWQs IHRoYW5rIHlvdSA7KQ0KPj4+PiArICAgIGlmICggcmMgKQ0KPj4+PiArICAgICAgICBncHJpbnRr KFhFTkxPR19FUlIsDQo+Pj4+ICsgICAgICAgICAgICAiJXBwOiBmYWlsZWQgdG8gYWRkIEJBUiBo YW5kbGVycyBmb3IgZG9tJWRcbiIsICZwZGV2LT5zYmRmLA0KPj4+PiArICAgICAgICAgICAgZC0+ ZG9tYWluX2lkKTsNCj4+PiBQbGVhc2UgdXNlICVwZCBhbmQgY29ycmVjdCBpbmRlbnRhdGlvbi4g TG9nZ2luZyB0aGUgZXJyb3IgY29kZSBtaWdodA0KPj4+IGFsc28gaGVscCBzb21lIGluIGRpYWdu b3NpbmcgaXNzdWVzLg0KPj4gU3VyZSwgSSdsbCBjaGFuZ2UgaXQgdG8gJXBkDQo+Pj4gICAgRnVy dGhlciBJJ20gbm90IHN1cmUgdGhpcyBpcyBhDQo+Pj4gbWVzc2FnZSB3ZSB3YW50IGluIHJlbGVh c2UgYnVpbGRzDQo+PiBXaHkgbm90Pw0KPiBFeGNlc3MgdmVyYm9zaXR5OiBJZiB3ZSBoYXZlIHN1 Y2ggaGVyZSwgd2h5IG5vdCBlbHNld2hlcmUgb24gZXJyb3IgcGF0aHM/DQo+IEFuZCBJIGhvcGUg eW91IGFncmVlIHRoaW5ncyB3aWxsIGdldCB0b28gdmVyYm9zZSBpZiB3ZSBoYWQgc3VjaCAoYWJv dXQpDQo+IGV2ZXJ5d2hlcmU/DQpBZ3JlZSwgd2lsbCBjaGFuZ2UgaXQgdG8gZ2RwcmludGsNCj4N Cj4+PiAgICAtIHBlcmhhcHMgZ2RwcmludGsoKT8NCj4+IEknbGwgY2hhbmdlIGlmIHdlIGRlY2lk ZSBzbw0KPj4+PiArICAgIHJldHVybiByYzsNCj4+Pj4gK30NCj4+Pj4gKw0KPj4+PiAraW50IHZw Y2lfYmFyX3JlbW92ZV9oYW5kbGVycyhjb25zdCBzdHJ1Y3QgZG9tYWluICpkLCBzdHJ1Y3QgcGNp X2RldiAqcGRldikNCj4+Pj4gK3sNCj4+Pj4gKyAgICAvKiBSZW1vdmUgcHJldmlvdXNseSBhZGRl ZCByZWdpc3RlcnMuICovDQo+Pj4+ICsgICAgdnBjaV9yZW1vdmVfZGV2aWNlX3JlZ2lzdGVycyhw ZGV2KTsNCj4+Pj4gKyAgICByZXR1cm4gMDsNCj4+Pj4gK30NCj4+PiBBbHNvIC0gaW4gaG93IGZh ciBpcyB0aGUgZ29hbCBvZiB5b3VyIHdvcmsgdG8gYWxzbyBtYWtlIHZQQ0kgd29yayBmb3INCj4+ PiB4ODYgRG9tVS1zPyBJZiB0aGF0J3Mgbm90IGEgZ29hbA0KPj4gSXQgaXMgbm90LCB1bmZvcnR1 bmF0ZWx5LiBUaGUgZ29hbCBpcyBub3QgdG8gYnJlYWsgeDg2IGFuZCB0byBlbmFibGUgQXJtDQo+ Pj4gLCBJJ2QgbGlrZSB0byBhc2sgdGhhdCB5b3UgbGltaXQgdGhlDQo+Pj4gaW50cm9kdWN0aW9u IG9mIGNvZGUgdGhhdCBlbmRzIHVwIGRlYWQgdGhlcmUuDQo+PiBXaGF0J3Mgd3Jvbmcgd2l0aCB0 aGlzIGZ1bmN0aW9uIGV2ZW4gaWYgaXQgaXMgYSBvbmUtbGluZXI/DQo+IFRoZSBjb21tZW50IGlz IHByaW1hcmlseSBvbiB0aGUgZWFybGllciBmdW5jdGlvbiwgYW5kIHRoZW4gZXh0ZW5kcyB0bw0K PiB0aGlzIG9uZS4NCj4NCj4+IFRoaXMgd2F5IHdlIGhhdmUgYSBwYWlyIHZwY2lfYmFyX2FkZF9o YW5kbGVycy92cGNpX2Jhcl9yZW1vdmVfaGFuZGxlcnMNCj4+IGFuZCBpZiBJIHVuZGVyc3Rvb2Qg Y29ycmVjdGx5IHlvdSBzdWdnZXN0IHZwY2lfYmFyX2FkZF9oYW5kbGVycy92cGNpX3JlbW92ZV9k ZXZpY2VfcmVnaXN0ZXJzPw0KPj4gV2hhdCB3b3VsZCB3ZSBnYWluIGZyb20gdGhhdCwgYnV0IHll dCBhbm90aGVyIHNlY3JldCBrbm93bGVkZ2UgdGhhdCBpbiBvcmRlcg0KPj4gdG8gcmVtb3ZlIEJB UiBoYW5kbGVycyBvbmUgbmVlZHMgdG8gY2FsbCB2cGNpX3JlbW92ZV9kZXZpY2VfcmVnaXN0ZXJz DQo+PiB3aGlsZSBJIHdvdWxkIHBlcnNvbmFsbHkgZXhwZWN0IHRvIGNhbGwgdnBjaV9iYXJfYWRk X2hhbmRsZXJzJyBjb3VudGVycGFydCwNCj4+IHZwY2lfcmVtb3ZlX2RldmljZV9yZWdpc3RlcnMg bmFtZWx5Lg0KPiBUaGlzIGlzIGFsbCBmaW5lLiBZZXQgdnBjaV9iYXJfe2FkZCxyZW1vdmV9X2hh bmRsZXJzKCkgd2lsbCwgYWl1aSwgYmUNCj4gZGVhZCBjb2RlIG9uIHg4Ni4NCnZwY2lfYmFyX2Fk ZF9oYW5kbGVycyB3aWxsIGJlIHVzZWQgYnkgeDg2IFBWSCBEb20wDQo+ICAgSGVuY2UgdGhlcmUg c2hvdWxkIGJlIGFuIGFycmFuZ2VtZW50IGFsbG93aW5nIHRoZQ0KPiBjb21waWxlciB0byBlbGlt aW5hdGUgdGhpcyBkZWFkIGNvZGUuDQoNClNvLCB0aGUgb25seSBkZWFkIGNvZGUgZm9yIHg4NiBo ZXJlIHdpbGwgYmUgdnBjaV9iYXJfcmVtb3ZlX2hhbmRsZXJzLiBZZXQuDQoNCkJlY2F1c2UgSSBo b3BlIHg4NiB0byBnYWluIGd1ZXN0IHN1cHBvcnQgZm9yIFBWSCBEb20wIHNvb25lciBvciBsYXRl ci4NCg0KPiAgIFdoZXRoZXIgdGhhdCdzIGVuY2xvc2luZyB0aGVzZQ0KPiBieSAiI2lmZGVmIiBv ciBhZGRpbmcgZWFybHkgImlmKCFJU19FTkFCTEVEKENPTkZJR18qKSkiIGlzIHNlY29uZGFyeS4N Cj4gVGhpcyBoYXMgYSBrbm9jay1vbiBlZmZlY3Qgb24gb3RoZXIgZnVuY3Rpb25zIGFzIHlvdSBj ZXJ0YWlubHkgcmVhbGl6ZToNCj4gVGhlIGNvbXBpbGVyIHNlZWluZyBlLmcuIHRoZSAybmQgYXJn dW1lbnQgdG8gdGhlIGFkZC1CQVJzIGZ1bmN0aW9uDQo+IGFsd2F5cyBiZWluZyB0cnVlIGFsbG93 cyBpdCB0byBpbnN0YW50aWF0ZSBqdXN0IGEgY2xvbmUgb2YgdGhlIG9yaWdpbmFsDQo+IGZ1bmN0 aW9uIHdpdGggdGhlIHJlc3BlY3RpdmUgY29uZGl0aW9uYWxzIHJlbW92ZWQuDQoNCldpdGggdGhl IGFib3ZlIChlLmcuIGFkZCBpcyBnb2luZyB0byBiZSB1c2VkLCBidXQgbm90IHJlbW92ZSkgZG8g eW91DQoNCnRoaW5rIGl0IGlzIHdvcnRoIHBsYXlpbmcgd2l0aCBpZmRlZidzIHRvIHN0cmlwIHRo YXQgc2luZ2xlIGZ1bmN0aW9uIGFuZCBhZGQNCg0KYSBwaWVjZSBvZiBzcGFnaGV0dGkgY29kZSB0 byBzYXZlIGEgYml0PyBXaGF0IHdvdWxkIHRoYXQgaWZkZWYgbG9vayBsaWtlLA0KDQplLmcuICNp ZmRlZiBDT05GSUdfQVJNIG9yICNpZm5kZWYgQ09ORklHX1g4NiAmJiBhbnkgb3RoZXIgcGxhdGZv cm0sIGJ1dCBBUk0/DQoNCklNTywgaXQgaXMgY2xlYW5lciB0byBsZWF2ZSBpdCBhcyBpcy4gWWV0 IHdlIHdhc3RlIHNvbWUgYml0cyBmb3IgeDg2Lg0KDQo+DQo+IEphbg0KPg0KVGhhbmsgeW91LA0K DQpPbGVrc2FuZHINCg== From xen-devel-bounces@lists.xenproject.org Tue Sep 07 11:34:31 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 11:34:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180848.327687 (Exim 4.92) (envelope-from ) id 1mNZMw-0004Kb-8Q; Tue, 07 Sep 2021 11:34:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180848.327687; Tue, 07 Sep 2021 11:34:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNZMw-0004KU-53; Tue, 07 Sep 2021 11:34:26 +0000 Received: by outflank-mailman (input) for mailman id 180848; Tue, 07 Sep 2021 11:34:24 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNZMu-0004KO-Lu for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 11:34:24 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (unknown [40.107.20.50]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id ccfbc2d0-b984-4a6f-990a-a474e83ec3e9; Tue, 07 Sep 2021 11:34:21 +0000 (UTC) Received: from PR0P264CA0054.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:1d::18) by VE1PR08MB5775.eurprd08.prod.outlook.com (2603:10a6:800:1a0::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19; Tue, 7 Sep 2021 11:34:07 +0000 Received: from VE1EUR03FT007.eop-EUR03.prod.protection.outlook.com (2603:10a6:100:1d:cafe::d4) by PR0P264CA0054.outlook.office365.com (2603:10a6:100:1d::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Tue, 7 Sep 2021 11:34:07 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT007.mail.protection.outlook.com (10.152.18.114) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Tue, 7 Sep 2021 11:34:07 +0000 Received: ("Tessian outbound 0ec886cb54dd:v105"); Tue, 07 Sep 2021 11:34:06 +0000 Received: from eb989c4f2559.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 8711F606-4838-4034-B687-C61EEADCF023.1; Tue, 07 Sep 2021 11:33:56 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id eb989c4f2559.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 07 Sep 2021 11:33:56 +0000 Received: from PAXPR08MB6816.eurprd08.prod.outlook.com (2603:10a6:102:130::10) by PA4PR08MB6270.eurprd08.prod.outlook.com (2603:10a6:102:f3::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.17; Tue, 7 Sep 2021 11:33:54 +0000 Received: from PAXPR08MB6816.eurprd08.prod.outlook.com ([fe80::c1b4:db1c:376f:b697]) by PAXPR08MB6816.eurprd08.prod.outlook.com ([fe80::c1b4:db1c:376f:b697%8]) with mapi id 15.20.4500.014; Tue, 7 Sep 2021 11:33:54 +0000 Received: from smtpclient.apple (82.8.129.65) by LO4P123CA0050.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:152::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14 via Frontend Transport; Tue, 7 Sep 2021 11:33:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ccfbc2d0-b984-4a6f-990a-a474e83ec3e9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MCCMeL6Eftx+YuUav1pGAJzgOA0UT56Kr+WzuuB4RWM=; b=JJj7S3F0et2bfdOwiB5uOWCIPf/d6CAmCWTv9MYT3IrihaFF2lOTeMKYEbRwSmpVq05DLABkolHQn+hBpsSq03+onbb8o7bLDAjyffaCt/Z26xh5zu1DY/cDbjN1xvQsQRxzBu1AyjKrBtndX5SqawSaTq9FK9T28U9CwBqiLzU= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: 35c017e931b65242 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FctFGljTKHwoIn+RkMW29m+bJRD25ctBnAZGlAnZ8q4S0yrH9O3pCruloZuPa1PmiBxzIOwd7nGy4tQi9tsiTcH6CHLwxt3Kof2BYlYvOvTIRjiYHd+tD1T6BkukXuVOF8qVsEFgYU+gbnaz+kF7A7ov4+UEefdat21XGEYeCbV4CHtwlY/lf1iHWEz3crkB7A/v2E4kLFoTOz5NFyzepXNKD1P/OT642Jf7LHAqfVEDB0pY+2l+7SahLRTrYBJrhzdQ3+NTca7LYtpEUSHHSksUHVhMb2kjScypJ1MD0VeAaoiKdTsVMSK/QRuS0fd6IyqnngTujc8qfE8Ub+UtMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=MCCMeL6Eftx+YuUav1pGAJzgOA0UT56Kr+WzuuB4RWM=; b=TxvVrqZSbtTtWbkjFK3Cnay1kB5MTmSqkFKu1BMz37EU4NebkEmeDvsxwY2f0oqRpqKk6lx98rxUOrh2NvEyj9h3L8sFobZTitwq7x24n1bbRA8zBH+t3RD20IJhCXJn5MQBEMCRMtSj0Aa6UnNH3OUgtv3hgjhd1Z3LXz3AwBBS5dQPIWytIHnfMiHu/FA+ZfA7ttDcTBT/DCG/cZAKoXIRfY6dXv1XM0UGwaeqxwYx0v0pa2yspK5vo73Vvf5Afwj3frug1rYZPddHANIGk+W0ncAN1WkOu+vHsJjPS65HXXuh6iMS0Iyq9EJo7QaXkRrOsGBeURwdIGJmCckdtQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MCCMeL6Eftx+YuUav1pGAJzgOA0UT56Kr+WzuuB4RWM=; b=JJj7S3F0et2bfdOwiB5uOWCIPf/d6CAmCWTv9MYT3IrihaFF2lOTeMKYEbRwSmpVq05DLABkolHQn+hBpsSq03+onbb8o7bLDAjyffaCt/Z26xh5zu1DY/cDbjN1xvQsQRxzBu1AyjKrBtndX5SqawSaTq9FK9T28U9CwBqiLzU= Authentication-Results-Original: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=arm.com; Content-Type: text/plain; charset=utf-8 Subject: Re: [RFC PATCH] xen/design: Add design for EFI dom0less system start From: Luca Fancellu In-Reply-To: <1b4eef88-78cb-7201-c326-551261f9e9ad@suse.com> Date: Tue, 7 Sep 2021 12:33:47 +0100 Cc: Julien Grall , Bertrand Marquis , wei.chen@arm.com, Andrew Cooper , George Dunlap , Ian Jackson , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org Content-Transfer-Encoding: quoted-printable Message-Id: <1964F880-98C2-45BF-8CED-C34397F61F4C@arm.com> References: <20210907065228.21794-1-luca.fancellu@arm.com> <3222722f-b12e-3991-d0de-b455b9fca063@xen.org> <1b4eef88-78cb-7201-c326-551261f9e9ad@suse.com> To: Jan Beulich X-Mailer: Apple Mail (2.3654.120.0.1.13) X-ClientProxiedBy: LO4P123CA0050.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:152::19) To PAXPR08MB6816.eurprd08.prod.outlook.com (2603:10a6:102:130::10) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 59b135d2-57d4-42c1-0948-08d971f36755 X-MS-TrafficTypeDiagnostic: PA4PR08MB6270:|VE1PR08MB5775: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:10000;OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: qLZHWkisKTiCF3UoirOvktChV1mbtN1n+e90qMT4ejv+8KMVwGAAHcDn9CmZJ/AB4cE43D2WK+b6VkPXafesx3Lc0ecTPBFOKZZlXAZszx362euaGd25CjYQsDSUtOgY/WIlqdDt3y3/GKuv+FvmbFuBzVzzeV78E26rTq5jfqkDFsA3PvA5kTXKCXuu3lzBFIeZjBP/9k52VFddOxLUGkgxm6iH43pyGvoXaTEDDBYuy37zA8Setxxo+VMEREfPpXR6OZVxG+A3CEf1kaZBbPI8M/84C/t7o0aOSsp7X/m4U3hFeGnzohOIlsc+vkEjQcQgcTMTujC+mUO3wVulSSuIpdNWtE8tyo1JrMcTKT7Mgtf+amI1OHQUiuOe+Px+xl/UZ9abtt/mJcQK1apYbIV7aKopBit8UjnaItomn3vdlU8VtDkHNHoUSn/ZVf8zwmBrgPTKpToNqbPGJfi9Q55Y4s+xgj262pEP4kiYwpb7eER9Y6FMECYryPy6yHXwC1IuMdeL7YLHl7heO3wKpimNZqLSBqvbxqDrtfgRKEccCp0yAb1e7UOuK6wmZwNsmiQTgeJtZMuYHl2tMGyFeW6wCgoBSdCusEM6YE3FuT76Kx7d21MdoLUmGOKqFimVGAQ6iq19qmD5m8xonDESq4Q71yTXYROYINWMRoGN+2AGlOY8QAG4BeMqST9pKAZDcCxVFfOld34PMA38ykYESGvRvF/6ShZ8SCM0gR7kpL/6GHJ8eaw/Pg6Soxm4CSEl X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB6816.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(346002)(136003)(39850400004)(396003)(366004)(6512007)(44832011)(53546011)(26005)(186003)(66556008)(6666004)(6916009)(2906002)(2616005)(66476007)(66946007)(956004)(6486002)(83380400001)(36756003)(33656002)(54906003)(478600001)(8936002)(4326008)(5660300002)(316002)(86362001)(52116002)(38100700002)(6506007)(8676002)(38350700002)(32563001)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB6270 Original-Authentication-Results: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT007.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: f82f01f4-376b-40c8-a761-08d971f35f8b X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XBpNM0Z5UT5rHlSeTQ2/HllZHPA93gNWn+c1caRyE9qykexBfZ0476UQB3aSt8HCMBVARqqB/3ODpKX+hRgau6qNoSB/X8RgbvSbNvgskJMbD3YSfIA6I7GCyp08YEX8J6lm3JYFuk0t1Yk7ZKFLD9I4WR2og+kvrj6tSCUsrq6IztQ+6hN6bemuKpCogtrbzMYxrptKPGSxky3YRu+lBRnlrKSWlR7zTyORHKQvuAC+VCoHrdHah6QgFLjYTn9SYCTPd1GyanYegyXWzQQCpC48JABjFJ7QOe8Bga9qkjThHmI5JaX80Q4aLIYgA2/24ID+jiHA+8rld1i24+OAInhqEH6LHLB4FhqSfBKMPWJkJDNwWBjd8zXd7Fv4S2G96nlcumF2QlcvH5hjodzZWTO4sMWGd7B1e/FjUv4Gt0WfPYlsoGtXGHh5SC0QgoLurfSYRgcxjkklVQs4BzmsRjtCk03ptJeCqprf3ZODxbBPAUociOPmVbPMmYqaMgc78sGrZZBRfwH0EYOcS5c+DqJq63xjnFoBGtmZRayYbLF/wOF0jngk4sHhS4HPw/A1JT3Z7/odKPcBEmHHry/AfX9zv5ti+SCSC8+IrB7UndlvEe8MU8tPYwWk3faAi7pOexyIdvaLw39JMpUuHj1dqXn8mbXhaEpd2D/DE51z26k93Y+fKXrUCFBJzhU7Apwdn/EpDbQzcafOmWL1lL4rcoGxigjAdWTTmw7OWeBZhyc= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(2616005)(6666004)(5660300002)(8676002)(54906003)(83380400001)(44832011)(6512007)(956004)(70206006)(70586007)(26005)(6506007)(316002)(33656002)(53546011)(6486002)(36756003)(8936002)(508600001)(336012)(4326008)(356005)(2906002)(186003)(82310400003)(6862004)(86362001)(36860700001)(47076005)(81166007)(32563001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2021 11:34:07.3144 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 59b135d2-57d4-42c1-0948-08d971f36755 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT007.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5775 > On 7 Sep 2021, at 10:24, Jan Beulich wrote: >=20 > On 07.09.2021 11:17, Julien Grall wrote: >> On 07/09/2021 09:33, Jan Beulich wrote: >>> I'd like to suggest a different scheme, not the least because I expect >>> the individual domains being independent of e.g. hypervisor command >>> line options or Dom0 kernel versions. Yet varying sets of these are, >>> for example, a reason to have multiple sections in the current scheme. >>> Every dom0less guest would then require spelling out in every such >>> section. Hence I think we'd be better off having a section per guest: >>>=20 >>> [guest1] >>> kernel=3DImage-domu1.bin console=3DttyAMA0 root=3D/dev/ram0 rw >>> property=3Dcpus=3D1 >>> property=3Dmemory=3D0xC0000 >>> dtb=3Ddomu.dtb >>=20 >> I much prefer the idea of the section. This is going to be easier to=20 >> parse the configuration file as we would not have to look for "domuX_"=20 >> and then distinguishing X. >>=20 >>>=20 >>> These sections would then be referenced by other sections, e.g. by a >>> new "guests" (or "domus", but this ends up looking a little odd for >>> its matching of an unrelated latin word) keyword: >>>=20 >>> guests=3Dguest1,guest2 >>>=20 >>> If it is deemed necessary to make sure such a section can't be >>> (mistakenly) used to create Dom0, such sections would need identifying >>> in some way. Presence of property=3D (or, as per below, properties=3D) >>> could be one means (allowing an empty setting would then be desirable). >>=20 >> I would expect dom0 to be described in the similar fashion at some=20 >> point. So maybe we should name the property "domains=3D...". >=20 > Not sure - the order above doesn't mandate domain IDs, yet Dom0 needs > creating with ID 0. IOW I was deliberately suggesting "guests=3D". Hi Jan, Julien, Thanks for your feedbacks, really appreciated, I agree with you that sectio= ns are easier to read. I stand with the =E2=80=9Cguests=3D=E2=80=9C or =E2=80=9Cdomus=3D=E2=80=9C = or =E2=80=9Cdomu_guests=3D=E2=80=9C keywords where the references to =E2=80=9Cguest sections=E2=80=9D can be listed, separated= by commas.=20 >=20 >>> As to the properties, is there anything wrong with having them all on >>> one line: >>>=20 >>> [guest1] >>> kernel=3DImage-domu1.bin console=3DttyAMA0 root=3D/dev/ram0 rw >>> dtb=3Ddomu.dtb >>> properties=3Dcpus=3D1 memory=3D0xC0000 >>=20 >> It depends on the number of properties for the domain, this may become=20 >> quickly unreadable. >>=20 >> But... if we use sections, then I think it would be better to have: >>=20 >> kernel=3D.. >> dtb=3D... >> cpu=3D1 >> memory=3D0xC0000 >>=20 >> This would also allow us to create more complex setup (such as for the=20 >> static memory allocation). >=20 > If that's feasible parsing-wise - sure. I was first thinking to suggest > separate keywords, but then decided there was a reason this wasn't done > in the original proposal (with respective dom#_ prefixes). Yes I think it is feasible and easy to read, so given your feedback we can = agree on something like that: [global] default=3Dxen [xen] options=3D[xen command line] kernel=3D[dom0 kernel file] [domain 0 command line options] ramdisk=3D[dom0 ramdisk] xsm=3D[xsm filename] dtb=3D[xen device tree blob] domu_guests=3Dguest1,... [guest1] address-cells=3D2 size-cells=3D2 kernel=3D[domU kernel file] [domU command line options] cpus=3D1 memory=3D0xC0000 dtb=3D[domU passthrough dtb] This won=E2=80=99t break the compatibility because on older version the dom= u_guests keyword Is ignored, the user needs just to check that a guest section is not specif= ied as default=3D argument because in this case it will be loaded as dom0 kernel (and probabl= y won=E2=80=99t work), but I think we can just update the documentation to highlight this thing. Finally this example should load a dom0less system: [global] default=3Dxen [xen] # Xen boot arguments options=3Dnoreboot console=3Ddtuart dtuart=3Dserial0 bootscrub=3D0 # Xen device tree dtb=3Ddevtree.dtb # domus to be started domu_guests=3Dguest1,guest2 [guest1] address-cells=3D2 size-cells=3D2 kernel=3DImage-domu1.bin console=3DttyAMA0 root=3D/dev/ram0 rw cpus=3D1 memory=3D0xC0000 dtb=3Ddomu.dtb [guest2] kernel=3DImage-domu2.bin console=3DttyAMA0 root=3D/dev/ram0 rw cpus=3D2 memory=3D0x100000 vpl011 >=20 > Jan >=20 From xen-devel-bounces@lists.xenproject.org Tue Sep 07 11:49:58 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 11:49:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180856.327698 (Exim 4.92) (envelope-from ) id 1mNZbs-0006C5-Px; Tue, 07 Sep 2021 11:49:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180856.327698; Tue, 07 Sep 2021 11:49:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNZbs-0006By-MI; Tue, 07 Sep 2021 11:49:52 +0000 Received: by outflank-mailman (input) for mailman id 180856; Tue, 07 Sep 2021 11:49:51 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNZbr-0006Bc-6b for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 11:49:51 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 1e9c2f4d-eb57-4274-a466-f4335d13ce44; Tue, 07 Sep 2021 11:49:50 +0000 (UTC) Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-ve1eur03lp2053.outbound.protection.outlook.com [104.47.9.53]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-24-0EYdDkRHO7izB27Zj_Z-RA-1; Tue, 07 Sep 2021 13:49:48 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR04MB5325.eurprd04.prod.outlook.com (2603:10a6:803:60::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.21; Tue, 7 Sep 2021 11:49:45 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4500.014; Tue, 7 Sep 2021 11:49:45 +0000 Received: from [10.156.60.236] (37.24.206.209) by AM4PR0501CA0053.eurprd05.prod.outlook.com (2603:10a6:200:68::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14 via Frontend Transport; Tue, 7 Sep 2021 11:49:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1e9c2f4d-eb57-4274-a466-f4335d13ce44 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1631015389; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uHenRRTyf45+WJBF15XEKH7XjRi3lSRhsGAvltq2EWE=; b=AzoDJmxPKIgCko/Hq/KjLR9Vz4ZY3+jt/+I5yuHD8h3aEGCWnJKzA3/AhbqH3tJbR+ftQn UW/t6G7RA5Qnj2+ZTqyu8ACNzUKwvaVGFgOcV8b5GIdCxGFSOImJTGaZu97lSwFlzd9bSC BTIqlbFKd7XM2saWiAt4CraXKf8b8Gw= X-MC-Unique: 0EYdDkRHO7izB27Zj_Z-RA-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iYj0HIVfm48U+c49s1gTcyPG6K8u+GX8M50bbRawIaTf3nexRPn/W4zGLG0+a5viCkE8g7OZjoQFbGLT5Ez7SVGVT3afJVpJBKKUJvNUv22h+M8pNrzj50Veu5vU1ALhkMX9UZ6cIA0qDNqxI+RDdwto/wOnSxIKK97Uj6uoS+NF+Ht/JEEpd5o1H0OktqzDQywVKV8qsR/LZx4HCtpMREsCvBsq7x382seFYgXLMW3oP9/gKWR9r7rpUR/fn5IeuS7qkkzykUXcqF7eoHYRrWsLFUbUPj0L1mpT+da67yIpTL9AEDGPjq1P5yVuqKRs8CNbOarSI6Yu2RGhSm8kbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=uHenRRTyf45+WJBF15XEKH7XjRi3lSRhsGAvltq2EWE=; b=Er8VV61mSivAevJPngEKURkhnbMXPKJeZ955bhojAnW7QPjH1QfMOV8Tkyy1E0IgfGYE9zjct8FQXwHMjtGnEdE1orhv3S7Cyq3/cJR06BITXXRZoV5aTwuLmpuN0rnN4dOKI+qbGA0Va0Wd+SsG1ytJOQoRy6VBSwiYTwfetHWW3G82N1yuS+jMzCrWQ4Zf7zpowk/rakaNXFrpkGqF8m+LOTTQvXv+R2QmgliAE1VPGSAhQsqAn9z9T0x/Ufa22iqu+jb9B0fFqrTl3uv5/ypABNgRr0LvqyRCOi7xzw/N4O67e5esQwHnPTulasZe9oFy/CqtaV6EcPZAYrr6SQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com; Subject: Re: [PATCH 4/9] vpci/header: Add and remove register handlers dynamically To: Oleksandr Andrushchenko , Oleksandr Andrushchenko Cc: "julien@xen.org" , "sstabellini@kernel.org" , Oleksandr Tyshchenko , Volodymyr Babchuk , Artem Mygaiev , "roger.pau@citrix.com" , Bertrand Marquis , Rahul Singh , "xen-devel@lists.xenproject.org" References: <20210903100831.177748-1-andr2000@gmail.com> <20210903100831.177748-5-andr2000@gmail.com> <8bb58d2d-255b-96e9-50ff-529985c655d5@suse.com> <16e396be-89f5-4d42-d57b-d91f09b70644@epam.com> <00bbe12b-6a79-e660-c5c1-57ccb200d2eb@suse.com> <242373cf-9854-74b7-4d54-bbcacc6cb7cb@epam.com> From: Jan Beulich Message-ID: <938156e7-cbd0-a19e-f09f-a41dce051367@suse.com> Date: Tue, 7 Sep 2021 13:49:42 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: <242373cf-9854-74b7-4d54-bbcacc6cb7cb@epam.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM4PR0501CA0053.eurprd05.prod.outlook.com (2603:10a6:200:68::21) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3d46988d-393e-466e-86a2-08d971f59657 X-MS-TrafficTypeDiagnostic: VI1PR04MB5325: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: YSB3lk8s/QoJO04og4CPCeAHRQLHRS4Qlr64DhwDaDZjbkzEJ+WmdqPGnmS/57/VbXzklXyjlEr5LvFqBEfmJ0bzwBTBNfx6RCp5R7GdyXEXVwCe1rIdA0mJMdUUS/cWz9W9rtcSo6EkvQr5qBjwmhiUFhKg+jZGzhpek5rwVTzVxrrOWcxypcqDByWDt/IgWlPHOGqI/XFVS9YDlbX6emnCD/FSKd7xCXkWPWlagZS+0TGOsSODo+Ea6ajHBXWp3nyiZ1egOQCOM+yMzljnXVfXYK1i6/PxwjmaevIq5lInEmYt7kFg61fxPj+T2uu3Xx00JyOM/yuzAXFHshezHigwOxZZN2bCNji2nhEucTELEWELTfx/4uVtrQE+ICtf4RmKDg9+9fOzrnzRglKJGxfA9iDrCnq28t+clDkLp783cZkHXqWRQwnZ1ZGCDK72rEL37F6Jq3gXJb2TgktSqzZ8aUBA1xg0HDgH1nOukv736yvo/cnlueGVpc5KFhMNKp7E/t+7qF4oXvRyoOLvW18EKehIT7LX2prtPdABnVtD2sQ2p8IRPtCK6nb+b95RxkE5BQQ5PBniEAsvM+hsgCVHFGi2rKNKZO2GbyUGI3sq6hTzX8syuiRWIv2yg6bT2uB7AZ6Xw3FiaDal7CB6rIGWMBInj13HqXkGATOd8blM5xMY/X7/cWxh39wRJua1a3zKvT9UxbqSFmRYb6N8i64jBRuDm6Ezx+WUBOcdvouxT14ajTY/k58iAhHFC6xE X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(396003)(346002)(39860400002)(136003)(366004)(376002)(316002)(2906002)(8936002)(110136005)(186003)(16576012)(31686004)(31696002)(478600001)(956004)(2616005)(5660300002)(4326008)(36756003)(86362001)(6486002)(38100700002)(8676002)(53546011)(83380400001)(26005)(54906003)(7416002)(66946007)(66476007)(66556008)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YVlvZExCeTd5eFhsODhxdnFUWEF6M2ZrVitrOU1pZGVlY0hlVnFPdC9sQVVC?= =?utf-8?B?VEx6eG5vcytIYUVlN21lZVplWFNmc0lJYXpkb0Jwd0diVXJJMVBRRGR4N1ZB?= =?utf-8?B?SS9SR1Z0WjBUVHdrNG95YUxqVmtuZEx2RXVFZURFQjR5LzBaamNaQnM4VUhW?= =?utf-8?B?bHFDYjNhKzNtZld6anZVYXpMWkdlNnRUeXY3LzJISGxlekprOWo0NXR0ZjNG?= =?utf-8?B?QVkxVUx5L3FaYTBuWUwwMDNZWHc4R2FDRG96TkhRQnpJZkRIWUFJVkI0eitM?= =?utf-8?B?S01QQ1NXV29KMmcxSlBRWnBMeDZmL1NvdW5yQUtWUXBITVNLUWJ0dWEveXl2?= =?utf-8?B?NTRlMzg5eHBtd2E3WExCeFdTNzgxOWRTWEFDWFczYWxKbEtPOXRXVldYMVdv?= =?utf-8?B?cHBHOFZhN2JNV1R5ZmRPL1JLUGFScUJZc3FwRnJkL3pxWVA5WjNKd20xLzlF?= =?utf-8?B?ak9UZGN5S29KemVBKzVSRVpoYUtDY0Y5bjB1ZzlJdm1PaUhaL3FhZnVKTEk4?= =?utf-8?B?RGxnM0FIS201RGZBSUZhWWpaYWRQcnJqajJUUFVwcFNUZ01ldVYySW5QZFZB?= =?utf-8?B?RjdLZ3NPYUJTemRLU3c0T3MwemJGK1RJaXJCRDBDemFPZC9kWWEzdU1RTWJ6?= =?utf-8?B?UjdNdGVXYk54MzcyZndDcHVGWlJiZzk0eE9KSTJIdXVkZy9VTmQvdTU3cmE3?= =?utf-8?B?WUxvRmdadUFqQjdxU3YvbTl4a0hPb1cyVlN3VGdFRSt4Ny9EdlFrSDNIa0tL?= =?utf-8?B?emp1UEdZQW9nV3hBMVJTT3lLNk9rcnd4V1VHYzExcmplWUFGc1JEQXlaV1Fu?= =?utf-8?B?Ry95ZHZNQm93dlBlSXRMRmRqd2RmRStreU4vRkZyYkZaTDlIZldqekhCTENZ?= =?utf-8?B?MEI3OVNvRm4rY0JueERHek5PL1R1c0J2dTl6VnlBUjRzZ0lubFpzeDlYY1Bt?= =?utf-8?B?QXRyeEVwcXYwUGFjQlU3QzN6RGRUVGlIQnkxaXNZdkQ5dzRZQ0FqUUlTNzJX?= =?utf-8?B?NE56WlFldWgvRzdyNVF1Q0xKNU8yN3drV2RGZE5ZZ3RVZUxxVDJrSzdLRXRJ?= =?utf-8?B?MVhOR2F0Y2I1U0ZyQmhWRjN0d2w5TGxHYy9pOXY2SU5lN3dvTU5DSmtYUWpF?= =?utf-8?B?UjRQdUpCNlY3d3FVOXVVRXNQSm5Nbk5jMTJTc3ZPa2RKTXpxYUY4anM1U0Ru?= =?utf-8?B?VzY3RkRaZHVxT1A0dmQyUmkrSDRDYXhKTndLTzRVaTlSdlZDSi8xcURvQzRQ?= =?utf-8?B?UnpYMzBEaHpMaHJJMkVzNC9zUG5NdW1ObVB0TjJjaG5LdU5NTFR0UHQ4SGha?= =?utf-8?B?aTZ6UXNpdWhXaFlmcG5QbEl3ZTB2dDYvUWlvUnoxVkhPeHFYNE12eUJldDJM?= =?utf-8?B?azZHTWtnK2ZtSGNMTHNlWlAvNnJrUGk1YjVJbENyc2t4ZFpOWUw1eW1acEU5?= =?utf-8?B?ZEowcVo4LzRQaXk5MTJoVkgrZFVTMFIvQ0poODdMUTQwL1o0SENydXVCemo1?= =?utf-8?B?UW41Z0tsVytodmxHMlM0ZEdYUmNrUVorQjRIcDZEeS9DVnh4QnYwdGsydTJJ?= =?utf-8?B?N3NhK1JoMWFDUXUvYkhhbzYzb2JYNkZmdWZxUUpFNUplNnA3bTNsZU83TUVB?= =?utf-8?B?V0EvMmNQdEYxeGo2UkZZUGg5ZnlQTFFxbURYeTRwWjN4N0cxazJCd0lNTkRO?= =?utf-8?B?SzRMdVFwWXFoT0JLbnZlQ1NkWUFQSU1zZ1VsbklwdVhzS09ZU3Z6cFM3Smdu?= =?utf-8?Q?YJzdIFdFfnpKrxaa12Xo3FxnPR828PYMhI5jxm5?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3d46988d-393e-466e-86a2-08d971f59657 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2021 11:49:45.4129 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: gkQZB7Wq/IXVB1IMrFP9tmvPahQMIIEcr5pWYIEDWIk6PQ5hCHsAnThhHI7M/vedM9B0V0wEZrlCcJiMaRjhxA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5325 On 07.09.2021 13:10, Oleksandr Andrushchenko wrote: > > On 07.09.21 13:43, Jan Beulich wrote: >> On 07.09.2021 12:11, Oleksandr Andrushchenko wrote: >>> On 06.09.21 17:11, Jan Beulich wrote: >>>> On 03.09.2021 12:08, Oleksandr Andrushchenko wrote: >>>>> @@ -593,6 +625,36 @@ static int init_bars(struct pci_dev *pdev) >>>>> } >>>>> REGISTER_VPCI_INIT(init_bars, VPCI_PRIORITY_MIDDLE); >>>>> >>>>> +int vpci_bar_add_handlers(const struct domain *d, struct pci_dev *pdev) >>>>> +{ >>>>> + int rc; >>>>> + >>>>> + /* Remove previously added registers. */ >>>>> + vpci_remove_device_registers(pdev); >>>>> + >>>>> + /* It only makes sense to add registers for hwdom or guest domain. */ >>>>> + if ( d->domain_id >= DOMID_FIRST_RESERVED ) >>>>> + return 0; >>>>> + >>>>> + if ( is_hardware_domain(d) ) >>>>> + rc = add_bar_handlers(pdev, true); >>>>> + else >>>>> + rc = add_bar_handlers(pdev, false); >>>> rc = add_bar_handlers(pdev, is_hardware_domain(d)); >>> Indeed, thank you ;) >>>>> + if ( rc ) >>>>> + gprintk(XENLOG_ERR, >>>>> + "%pp: failed to add BAR handlers for dom%d\n", &pdev->sbdf, >>>>> + d->domain_id); >>>> Please use %pd and correct indentation. Logging the error code might >>>> also help some in diagnosing issues. >>> Sure, I'll change it to %pd >>>> Further I'm not sure this is a >>>> message we want in release builds >>> Why not? >> Excess verbosity: If we have such here, why not elsewhere on error paths? >> And I hope you agree things will get too verbose if we had such (about) >> everywhere? > Agree, will change it to gdprintk >> >>>> - perhaps gdprintk()? >>> I'll change if we decide so >>>>> + return rc; >>>>> +} >>>>> + >>>>> +int vpci_bar_remove_handlers(const struct domain *d, struct pci_dev *pdev) >>>>> +{ >>>>> + /* Remove previously added registers. */ >>>>> + vpci_remove_device_registers(pdev); >>>>> + return 0; >>>>> +} >>>> Also - in how far is the goal of your work to also make vPCI work for >>>> x86 DomU-s? If that's not a goal >>> It is not, unfortunately. The goal is not to break x86 and to enable Arm >>>> , I'd like to ask that you limit the >>>> introduction of code that ends up dead there. >>> What's wrong with this function even if it is a one-liner? >> The comment is primarily on the earlier function, and then extends to >> this one. >> >>> This way we have a pair vpci_bar_add_handlers/vpci_bar_remove_handlers >>> and if I understood correctly you suggest vpci_bar_add_handlers/vpci_remove_device_registers? >>> What would we gain from that, but yet another secret knowledge that in order >>> to remove BAR handlers one needs to call vpci_remove_device_registers >>> while I would personally expect to call vpci_bar_add_handlers' counterpart, >>> vpci_remove_device_registers namely. >> This is all fine. Yet vpci_bar_{add,remove}_handlers() will, aiui, be >> dead code on x86. > vpci_bar_add_handlers will be used by x86 PVH Dom0 Where / when? You add a call from vpci_assign_device(), but besides that also being dead code on x86 (for now), you can't mean that because vpci_deassign_device() also calls vpci_bar_remove_handlers(). >> Hence there should be an arrangement allowing the >> compiler to eliminate this dead code. > > So, the only dead code for x86 here will be vpci_bar_remove_handlers. Yet. > Because I hope x86 to gain guest support for PVH Dom0 sooner or later. > >> Whether that's enclosing these >> by "#ifdef" or adding early "if(!IS_ENABLED(CONFIG_*))" is secondary. >> This has a knock-on effect on other functions as you certainly realize: >> The compiler seeing e.g. the 2nd argument to the add-BARs function >> always being true allows it to instantiate just a clone of the original >> function with the respective conditionals removed. > > With the above (e.g. add is going to be used, but not remove) do you > think it is worth playing with ifdef's to strip that single function and add > a piece of spaghetti code to save a bit? No, that I agree wouldn't be worth it. > What would that ifdef look like, > e.g. #ifdef CONFIG_ARM or #ifndef CONFIG_X86 && any other platform, but ARM? A new setting, preferably; e.g. VCPU_UNPRIVILEGED, to be "select"ed by architectures as functionality gets enabled. Jan From xen-devel-bounces@lists.xenproject.org Tue Sep 07 11:51:03 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 11:51:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180862.327709 (Exim 4.92) (envelope-from ) id 1mNZd1-0007Tj-3j; Tue, 07 Sep 2021 11:51:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180862.327709; Tue, 07 Sep 2021 11:51:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNZd1-0007Tc-0p; Tue, 07 Sep 2021 11:51:03 +0000 Received: by outflank-mailman (input) for mailman id 180862; Tue, 07 Sep 2021 11:51:01 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNZcz-0007TG-GR; Tue, 07 Sep 2021 11:51:01 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNZcz-00036f-CE; Tue, 07 Sep 2021 11:51:01 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNZcz-0000o5-4S; Tue, 07 Sep 2021 11:51:01 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mNZcz-0001nn-3v; Tue, 07 Sep 2021 11:51:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=/mVGIVAAw7cJ3RmytizdZk2OG7wBCRYpWpE1VVNhkp8=; b=cv+VuZy/xo8erch8TpXaUgozsJ RRToRrNHrHuB0BFyu8eBkbH+IINVyM9+aneNUnMxu1T20dnO88i458KLv1BfU9tL2PsaHWiSOmGdC 5lPf3T8p1A4b5caDIBmHa2Tpr+b69w/jqrBGeFxrhQmE9bbeyS21wzImVOgyJSS8M7z4=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 164872: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=5ae4120635ad3cbf6064268162b0fb2c44eb41e3 X-Osstest-Versions-That: xen=6c27a8da8d2024aa78a9ec67bcfb18c123e84a17 From: osstest service owner Date: Tue, 07 Sep 2021 11:51:01 +0000 flight 164872 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/164872/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 5ae4120635ad3cbf6064268162b0fb2c44eb41e3 baseline version: xen 6c27a8da8d2024aa78a9ec67bcfb18c123e84a17 Last test of basis 164863 2021-09-06 18:02:44 Z 0 days Testing same since 164872 2021-09-07 08:01:48 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Anthony PERARD Jan Beulich Jane Malalane Julien Grall Wei Liu jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 6c27a8da8d..5ae4120635 5ae4120635ad3cbf6064268162b0fb2c44eb41e3 -> smoke From xen-devel-bounces@lists.xenproject.org Tue Sep 07 11:51:40 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 11:51:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180869.327723 (Exim 4.92) (envelope-from ) id 1mNZdc-0008L9-FV; Tue, 07 Sep 2021 11:51:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180869.327723; Tue, 07 Sep 2021 11:51:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNZdc-0008L2-Bt; Tue, 07 Sep 2021 11:51:40 +0000 Received: by outflank-mailman (input) for mailman id 180869; Tue, 07 Sep 2021 11:51:39 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNZdb-0008Kd-66 for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 11:51:39 +0000 Received: from EUR02-AM5-obe.outbound.protection.outlook.com (unknown [40.107.0.61]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id f2959572-0fd1-11ec-b0ea-12813bfff9fa; Tue, 07 Sep 2021 11:51:33 +0000 (UTC) Received: from PR0P264CA0251.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100::23) by DB7PR08MB3676.eurprd08.prod.outlook.com (2603:10a6:10:4d::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.21; Tue, 7 Sep 2021 11:51:31 +0000 Received: from VE1EUR03FT055.eop-EUR03.prod.protection.outlook.com (2603:10a6:100:0:cafe::35) by PR0P264CA0251.outlook.office365.com (2603:10a6:100::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.20 via Frontend Transport; Tue, 7 Sep 2021 11:51:31 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT055.mail.protection.outlook.com (10.152.19.158) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Tue, 7 Sep 2021 11:51:30 +0000 Received: ("Tessian outbound cc1d52552731:v105"); Tue, 07 Sep 2021 11:51:30 +0000 Received: from b8a882c627c8.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 79EECCEF-83AE-41BC-B5C3-3921D7D635D9.1; Tue, 07 Sep 2021 11:51:24 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id b8a882c627c8.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 07 Sep 2021 11:51:24 +0000 Received: from PAXPR08MB6816.eurprd08.prod.outlook.com (2603:10a6:102:130::10) by PAXPR08MB6495.eurprd08.prod.outlook.com (2603:10a6:102:dd::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19; Tue, 7 Sep 2021 11:51:23 +0000 Received: from PAXPR08MB6816.eurprd08.prod.outlook.com ([fe80::c1b4:db1c:376f:b697]) by PAXPR08MB6816.eurprd08.prod.outlook.com ([fe80::c1b4:db1c:376f:b697%8]) with mapi id 15.20.4500.014; Tue, 7 Sep 2021 11:51:23 +0000 Received: from smtpclient.apple (82.8.129.65) by LO2P265CA0360.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:d::36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Tue, 7 Sep 2021 11:51:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f2959572-0fd1-11ec-b0ea-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YXbgVi4E/l2ZD/q5CGFs38xQTqeIroaeLOOfdmS8cYs=; b=7WdKlKsnRA7wl/zP/nDSoYJr3eIvmQ39bTIpktYzCbPwSPj5AHZFkvnxFCZMFxQTVph8ziZNLsujmsrdOz4cxe6kX8hBzoui3BEWfTdUIt2/iCKth4s7ZF2kLT0c6IlPxzTaQVdR8MPwRPjyGucGu4/xqdnLTM8/dkltyooXx08= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: 1291435db9ea3fac X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CEtMWMnpKSDwS1L7TybOURvfYta4G4YJGWTL8GuCXdsaZaCMfj8l39w8bKGVmbfGybAy/y4h1qKK875ion+qsFOddbmcV/VghnW6YWSCaeENWE0jWhM5GZEhmChK6q2M1Q9Ls36d2UNICb5M3bHMhYaZtrRqmlaGHx5DPqrJXDDznhdJ6Qis03fYzDM00CwbdsXHucukIle6vogzxnsRQ1GWv7SDDVb3kvtr/yrS9Af4TdxMHxWfTCAs8oRRiRACpMYb/4+aZ7tValP3itIm3CHbqVVGb3lo0pIbONos8OO3z3TWgXWHhczCKQTewHUswsquhhzadhawbdJQD3Aipw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=YXbgVi4E/l2ZD/q5CGFs38xQTqeIroaeLOOfdmS8cYs=; b=HNwMuNHGBr4f2073O/9E13JP+WrZwJgKCHrkjKlETechZbtL+obddVK04Scn8L/bCYcYUah6w0zXUXZtB8PlDHaXJ3B0RyaMMBmHKGNTQoagtxZEwW1rhDboqaakSVZW82Z1vVs0K1jyj0OtffJmHAeMVipSynGjr/5RMbH2+KQ0jCDDKtHaPmmj6HbYpm6nohjswyM5R2QLNTc7Zc1xfSlO+i863XUhChMM7EkkeLfZbfK+hLR/0eMj0WNYUQuGqSqbs4TaPNeP1W6C1ojNr0s+iGikPi0QOyKGJFi7TPG73RAnZNqW9n73Q7aHLGYaS7cuwmmuCB3NF6dbxdPKzw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YXbgVi4E/l2ZD/q5CGFs38xQTqeIroaeLOOfdmS8cYs=; b=7WdKlKsnRA7wl/zP/nDSoYJr3eIvmQ39bTIpktYzCbPwSPj5AHZFkvnxFCZMFxQTVph8ziZNLsujmsrdOz4cxe6kX8hBzoui3BEWfTdUIt2/iCKth4s7ZF2kLT0c6IlPxzTaQVdR8MPwRPjyGucGu4/xqdnLTM8/dkltyooXx08= Authentication-Results-Original: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com; Content-Type: text/plain; charset=utf-8 Subject: Re: [RFC PATCH] xen/design: Add design for EFI dom0less system start From: Luca Fancellu In-Reply-To: <4bab7902-0268-5705-5462-fcd7571d7492@xen.org> Date: Tue, 7 Sep 2021 12:51:16 +0100 Cc: xen-devel@lists.xenproject.org, Bertrand Marquis , wei.chen@arm.com, Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Stefano Stabellini , Wei Liu Content-Transfer-Encoding: quoted-printable Message-Id: <7BD59287-75ED-4D4F-B892-F6B04583A986@arm.com> References: <20210907065228.21794-1-luca.fancellu@arm.com> <4bab7902-0268-5705-5462-fcd7571d7492@xen.org> To: Julien Grall X-Mailer: Apple Mail (2.3654.120.0.1.13) X-ClientProxiedBy: LO2P265CA0360.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:d::36) To PAXPR08MB6816.eurprd08.prod.outlook.com (2603:10a6:102:130::10) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d0f3c566-314d-4f1e-0341-08d971f5d551 X-MS-TrafficTypeDiagnostic: PAXPR08MB6495:|DB7PR08MB3676: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:10000;OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: B6pcdUoi3zrAbyZl01n4VcVjdoctCxnIA6cQDfPj3nmQZiYC0JayfC9WERc1H7XAE14/vN1rL7db54c2TdKhxLbzVKYgBtNE7aY0RYgsNHP2yYOIgPEqYqc2KHbe0wCT84o00tHi2qvpHl6CgBhTGPpNZ1Qp+WfzCZUcYalnAJsOQzEtfDcgb7E/93krsrDHpyb4FRDRgs6ZtPK9LbT1uI5EpYmhNT5IYg6M8pmheYmdreVRV6RWuGzKecTIYdppvUtGWLdbJWOVtkf7+Xwn/C7N3wtEMWqQJRhnqz0lVmpssBm896rfhI6dIWd5z543DlgCFqtuf6qeCSIiZW/Iv66X6xyZWp1xOx4x+WMF65Bo3ATuntDM4yNIytPAD5nkzKzP+YWJWuQ097ZAOxaHTn6yKUQwVPvvLHYtHqNtqC7Y7aNX0YMqM773T/BYktzCxTfgcT9YHILhhn1WrTrysK6XL9+ulQ5+tq8nh4F3Dfr68vBLeq+9BrMbwL+E3t8SrHphtoyQQKCODgoEQGZcGEKpNhsYbkrxh4Jg5UJ3RVQ8RXVAp0UBGbaHLF+l5RSNBbbRML1E8pYolC720y3cbCeiAcVlPT+PfNQT8NsWp23/KczmK/i7/ZCxNUHuUCdPzgwZRJjoqGLCCk9DQYXc3IElaa0K5PztB+w4/hYXZccqzkophR2F+LL/G8WsTmh8Yzj5bwET32Ubjl1OmZA7PaOY9xclSNLeHDtP16i04iGzOIRnFok/qCUNajP3XeflD/c01W0UoWrotUL65p8gDg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB6816.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(366004)(376002)(39860400002)(136003)(396003)(6666004)(26005)(186003)(6916009)(478600001)(36756003)(86362001)(6512007)(4326008)(33656002)(2616005)(956004)(5660300002)(316002)(54906003)(44832011)(2906002)(8676002)(38100700002)(38350700002)(66556008)(66476007)(8936002)(66946007)(53546011)(6506007)(52116002)(6486002)(32563001)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6495 Original-Authentication-Results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT055.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 88256cac-c7e1-4d16-4b29-08d971f5d03a X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 08Q23tub5dfGLpkAAd8Lc+DPNN1iVXOdKI+u1nZ/oAk9kVuPVRVTBUQFU+Pseklt42FpWGE8Q2yya+tOPIKnKuti3n3h6Af2YMl9n3UMlNMz+Ym4E+M7KiBK3HRGqM6/ULuq4OpRqR6lqLrpXKsfN1wv//uAgpSCyEMwi9M2x05X+MQeFXVeYScHSaPPBE7729M3xkc5/T4RznvXkbmk8ryAyoGek5qrkb7pW6IbCeJTAKCaIm2dSt5ylUDOrD5hD78KU58yVwjm76okDPv2iapdoiUwBlqzXUnkQo9qJWL0avPYKW8t10qw/UgwQA5+QERNifOyoXQyQoYDTl68owIr8P/35Cffflj4NaCj7GzMtnUhIPMW5sPrqV7iCZ3GBzQ2PffMZAAuYMNyzV4xTRvaTm2x2tcatr5tfSxHFby8QFDfVj20GZsAoEuAgeEbK48QtPRi+cfuVblhWoH+YbYdZDQBJhPyLXztHzNLAufKPBnsf2KvwYMXfGfGfIZMFDAXfVhLqRwpM7RNFWvRum2t/yW6LO0146KxMzsJ+7j3p0R7CHctZ6A3OssgjvY2DOQOT/89EzYdfVfxURXvhBf8kwsP8ek8eLpI5FZhyt+fn1Pu3pApvJVhhYc9eD6xigiknftFOcBr1gLtn3rYSbVMFtuMwIXIWa2x9Joyniob2hSAdjF3AYWbFprqXv9cj4o4iuXxlUG2QCzydD0AGlFxzzdpXNaGkHY1obBNz30= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(376002)(346002)(136003)(39850400004)(396003)(46966006)(36840700001)(44832011)(956004)(478600001)(336012)(6512007)(33656002)(2616005)(6862004)(8676002)(186003)(6486002)(70586007)(70206006)(82310400003)(26005)(6666004)(53546011)(82740400003)(47076005)(6506007)(86362001)(36756003)(4326008)(54906003)(2906002)(356005)(81166007)(36860700001)(8936002)(5660300002)(316002)(32563001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2021 11:51:30.8328 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d0f3c566-314d-4f1e-0341-08d971f5d551 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT055.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3676 > On 7 Sep 2021, at 10:35, Julien Grall wrote: >=20 > Hi Luca, >=20 > On 07/09/2021 07:52, Luca Fancellu wrote: >> Add a design describing a proposal to improve the EFI >> configuration file, adding keywords to describe domU >> guests and allowing to start a dom0less system. >> Signed-off-by: Luca Fancellu >> --- >> docs/designs/efi-arm-dom0less.md | 105 +++++++++++++++++++++++++++++++ >> 1 file changed, 105 insertions(+) >> create mode 100644 docs/designs/efi-arm-dom0less.md >> diff --git a/docs/designs/efi-arm-dom0less.md b/docs/designs/efi-arm-dom= 0less.md >> new file mode 100644 >> index 0000000000..8d8fa2243f >> --- /dev/null >> +++ b/docs/designs/efi-arm-dom0less.md >> @@ -0,0 +1,105 @@ >> +# Xen EFI configuration file >> + >> +The current configuration file used by Xen when it is started as an EFI >> +application is considering only the dom0 guest and doesn't have any >> +property to describe and load in memory domU guests. >=20 > From my understanding, the problem is less about properties (we already h= ave them in the Device-Tree) but more about where are the binaries located = in memory as we don't know in advance. Hi Julien, I think I used the wrong word there, I meant =E2=80=9Ckeyword=E2=80=9D inst= ead of =E2=80=9Cproperty=E2=80=9D because I was referring about the lack of keywords to describe a domu guest in the Xen EFI configuration file= . I agree with you that on systems with static allocation, the kernel and ram= disk binaries must be at certain locations that are out of control when we use the EFI boot services, the thing we can= do is provide a keyword to specify the addresses and then use the CopyMem() function to relocate the kernel/ramdis= k in the address we want. >=20 > So I would like to propose something that build on top of the Device-Tree= work we did. Note this is early thoughts. >=20 > The problematic nodes in the DT are: >=20 > module@0x4a000000 { > compatible =3D "multiboot,kernel", "multiboot,module"; > reg =3D <0x0 0x4a000000 0xffffff>; > bootargs =3D "console=3DttyAMA0 init=3D/bin/sh"; > }; >=20 > module@0x4b000000 { > compatible =3D "multiboot,ramdisk", "multiboot,module"; > reg =3D <0x0 0x4b000000 0xffffff>; > }; >=20 > In particular the property "reg" cannot be known in advance because the U= EFI stub will be responsible to load the binaries in memory. Yes that=E2=80=99s true, the UEFI stub is using from the UEFI boot service = the AllocatePages function that is giving back an address out of our contro= l, then using another function the binary is read from the disk and copied at = that address, finally the UEFI stub is writing the node in the device tree = that will be used by Xen later. >=20 > What we could do is providing a list of binaries to load and associate a = key for each of them. Something like: >=20 > binary=3D > binary=3D > .... >=20 > We can then replace the property "reg" with a new property "uefi,key" tha= t will contain the name of the binary. >=20 > What do you think? Here I=E2=80=99m lost, because I don=E2=80=99t understand what we are going= to do with the name of the binary. Cheers, Luca >=20 > Cheers, >=20 > --=20 > Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Sep 07 11:55:17 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 11:55:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180876.327733 (Exim 4.92) (envelope-from ) id 1mNZh3-0000hT-VV; Tue, 07 Sep 2021 11:55:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180876.327733; Tue, 07 Sep 2021 11:55:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNZh3-0000hM-Se; Tue, 07 Sep 2021 11:55:13 +0000 Received: by outflank-mailman (input) for mailman id 180876; Tue, 07 Sep 2021 11:55:13 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNZh3-0000hG-6G for xen-devel@lists.xen.org; Tue, 07 Sep 2021 11:55:13 +0000 Received: from mail-pg1-x52e.google.com (unknown [2607:f8b0:4864:20::52e]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id f96934d6-4c9f-4cf9-8d9a-8c1e3d079d13; Tue, 07 Sep 2021 11:55:11 +0000 (UTC) Received: by mail-pg1-x52e.google.com with SMTP id 17so9680300pgp.4 for ; Tue, 07 Sep 2021 04:55:11 -0700 (PDT) Received: from laputa (p784a2304.tkyea130.ap.so-net.ne.jp. [120.74.35.4]) by smtp.gmail.com with ESMTPSA id 73sm11108630pfu.92.2021.09.07.04.55.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Sep 2021 04:55:10 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f96934d6-4c9f-4cf9-8d9a-8c1e3d079d13 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=YGmEUWYy+3Y27wr4j+eiPDJQoM70U3zAZRfNASz1Nxs=; b=sixtt0LE5+rubYhgxQ3gxIafb8BStveV0zCkKP/TTVFMc+wR2FvKIgcx5BMnbVcgkF +kYmg5CpMon18Fyk1Uvz6jjVf0ydAFlhf12YPdTboaCmTCE84wSga+8TcQkeXAxPfBPB xgKEo0Dr5MSNm82QIbNhq6RVWIn7iSjrc46L6pkxQN22Qsu8GSaDDK5Tfl8v4LoOHOiL 3UQZqfxnLQl9KaqXvwt5IF8QBycWnyMBVOmTEOC9sFa55uxxUXvjPFmiP2UYqrGaZ7ZV iTMwctPVRveEqOsMcSJVcZZNt4wJlzqkes0Nkzub72NOv+qqRhyJdjw9mNb4/TbP26LH SkkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=YGmEUWYy+3Y27wr4j+eiPDJQoM70U3zAZRfNASz1Nxs=; b=bMJ16mmDMPBBRs+ZpQiqVuYszyw04l6vpdMi32n/AOOI+nSgOHeZezbzRoHrVAbXsY R6Ms1nZKemnk2Jqr3R72ngo7o4N68jJGhehjsTW6wmor2vtiPPYEq9NQNQHXI9tRqD9F W9Ee5qdLQCdGT2Pu/gspOLPcnJjek2sYuMfJJAa2jYs+5AFuI+r1OFhy3Q+fQ+xQyHyo ilYXE7sLiszgU51k2uYMSKwjFF7WSnWUK8PdJue/EDY/PwKVijo+PsAp7AG0AnqPNEmP K0RZQaDEluvhGYDXQXR9VycZg1ctbZ+63Nah8/wVe9pyRWbST87/12vyihw/poJdyKjQ npJQ== X-Gm-Message-State: AOAM531KtKE6zefo3NfgsCnXtxXsbLouxXUtr1unbibErXd/cgm/IeId wazeozlj79t3RkEhT1crV/lQsQ== X-Google-Smtp-Source: ABdhPJz84h7MB9crcdLnGhrW7TXCZ3clzq/fXzbX64JcR9tazl28nxPVp/iHoLXGuJYQsyneDaM4pg== X-Received: by 2002:a63:36c4:: with SMTP id d187mr12368353pga.205.1631015710887; Tue, 07 Sep 2021 04:55:10 -0700 (PDT) Date: Tue, 7 Sep 2021 20:55:01 +0900 From: AKASHI Takahiro To: Christopher Clark Cc: Wei Chen , Oleksandr Tyshchenko , Stefano Stabellini , Alex Benn??e , Kaly Xin , Stratos Mailing List , "virtio-dev@lists.oasis-open.org" , Arnd Bergmann , Viresh Kumar , Stefano Stabellini , "stefanha@redhat.com" , Jan Kiszka , Carl van Schaik , "pratikp@quicinc.com" , Srivatsa Vaddagiri , Jean-Philippe Brucker , Mathieu Poirier , Oleksandr Tyshchenko , Bertrand Marquis , Artem Mygaiev , Julien Grall , Juergen Gross , Paul Durrant , Xen Devel , Rich Persaud , Daniel Smith , James McKenzie , Andrew Cooper Subject: Re: Enabling hypervisor agnosticism for VirtIO backends Message-ID: <20210907115501.GC49004@laputa> References: <20210818053840.GE39588@laputa> <20210820064150.GC13452@laputa> <20210826094047.GA55218@laputa> <20210902071902.GC71098@laputa> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Hi, I have not covered all your comments below yet. So just one comment: On Mon, Sep 06, 2021 at 05:57:43PM -0700, Christopher Clark wrote: > On Thu, Sep 2, 2021 at 12:19 AM AKASHI Takahiro > wrote: (snip) > > It appears that, on FE side, at least three hypervisor calls (and data > > copying) need to be invoked at every request, right? > > > > For a write, counting FE sendv ops: > 1: the write data payload is sent via the "Argo ring for writes" > 2: the descriptor is sent via a sync of the available/descriptor ring > -- is there a third one that I am missing? In the picture, I can see a) Data transmitted by Argo sendv b) Descriptor written after data sendv c) VirtIO ring sync'd to back-end via separate sendv Oops, (b) is not a hypervisor call, is it? (But I guess that you will have to have yet another call for notification since there is no config register of QueueNotify?) Thanks, -Takahiro Akashi > Christopher > > > > > > Thanks, > > -Takahiro Akashi > > > > > > > * Here are the design documents for building VirtIO-over-Argo, to > > support a > > > hypervisor-agnostic frontend VirtIO transport driver using Argo. > > > > > > The Development Plan to build VirtIO virtual device support over Argo > > > transport: > > > > > https://openxt.atlassian.net/wiki/spaces/DC/pages/1696169985/VirtIO-Argo+Development+Phase+1 > > > > > > A design for using VirtIO over Argo, describing how VirtIO data > > structures > > > and communication is handled over the Argo transport: > > > https://openxt.atlassian.net/wiki/spaces/DC/pages/1348763698/VirtIO+Argo > > > > > > Diagram (from the above document) showing how VirtIO rings are > > synchronized > > > between domains without using shared memory: > > > > > https://openxt.atlassian.net/46e1c93b-2b87-4cb2-951e-abd4377a1194#media-blob-url=true&id=01f7d0e1-7686-4f0b-88e1-457c1d30df40&collection=contentId-1348763698&contextId=1348763698&mimeType=image%2Fpng&name=device-buffer-access-virtio-argo.png&size=243175&width=1106&height=1241 > > > > > > Please note that the above design documents show that the existing VirtIO > > > device drivers, and both vring and virtqueue data structures can be > > > preserved > > > while interdomain communication can be performed with no shared memory > > > required > > > for most drivers; (the exceptions where further design is required are > > those > > > such as virtual framebuffer devices where shared memory regions are > > > intentionally > > > added to the communication structure beyond the vrings and virtqueues). > > > > > > An analysis of VirtIO and Argo, informing the design: > > > > > https://openxt.atlassian.net/wiki/spaces/DC/pages/1333428225/Analysis+of+Argo+as+a+transport+medium+for+VirtIO > > > > > > * Argo can be used for a communication path for configuration between the > > > backend > > > and the toolstack, avoiding the need for a dependency on XenStore, > > which > > > is an > > > advantage for any hypervisor-agnostic design. It is also amenable to a > > > notification > > > mechanism that is not based on Xen event channels. > > > > > > * Argo does not use or require shared memory between VMs and provides an > > > alternative > > > to the use of foreign shared memory mappings. It avoids some of the > > > complexities > > > involved with using grants (eg. XSA-300). > > > > > > * Argo supports Mandatory Access Control by the hypervisor, satisfying a > > > common > > > certification requirement. > > > > > > * The Argo headers are BSD-licensed and the Xen hypervisor implementation > > > is GPLv2 but > > > accessible via the hypercall interface. The licensing should not > > present > > > an obstacle > > > to adoption of Argo in guest software or implementation by other > > > hypervisors. > > > > > > * Since the interface that Argo presents to a guest VM is similar to > > DMA, a > > > VirtIO-Argo > > > frontend transport driver should be able to operate with a physical > > > VirtIO-enabled > > > smart-NIC if the toolstack and an Argo-aware backend provide support. > > > > > > The next Xen Community Call is next week and I would be happy to answer > > > questions > > > about Argo and on this topic. I will also be following this thread. > > > > > > Christopher > > > (Argo maintainer, Xen Community) > > > > > > > > -------------------------------------------------------------------------------- > > > [1] > > > An introduction to Argo: > > > > > https://static.sched.com/hosted_files/xensummit19/92/Argo%20and%20HMX%20-%20OpenXT%20-%20Christopher%20Clark%20-%20Xen%20Summit%202019.pdf > > > https://www.youtube.com/watch?v=cnC0Tg3jqJQ > > > Xen Wiki page for Argo: > > > > > https://wiki.xenproject.org/wiki/Argo:_Hypervisor-Mediated_Exchange_(HMX)_for_Xen > > > > > > [2] > > > OpenXT Linux Argo driver and userspace library: > > > https://github.com/openxt/linux-xen-argo > > > > > > Windows V4V at OpenXT wiki: > > > https://openxt.atlassian.net/wiki/spaces/DC/pages/14844007/V4V > > > Windows v4v driver source: > > > https://github.com/OpenXT/xc-windows/tree/master/xenv4v > > > > > > HP/Bromium uXen V4V driver: > > > https://github.com/uxen-virt/uxen/tree/ascara/windows/uxenv4vlib > > > > > > [3] > > > v2 of the Argo test unikernel for XTF: > > > > > https://lists.xenproject.org/archives/html/xen-devel/2021-01/msg02234.html > > > > > > [4] > > > Argo HMX Transport for VirtIO meeting minutes: > > > > > https://lists.xenproject.org/archives/html/xen-devel/2021-02/msg01422.html > > > > > > VirtIO-Argo Development wiki page: > > > > > https://openxt.atlassian.net/wiki/spaces/DC/pages/1696169985/VirtIO-Argo+Development+Phase+1 > > > > > > > From xen-devel-bounces@lists.xenproject.org Tue Sep 07 11:55:54 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 11:55:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180882.327744 (Exim 4.92) (envelope-from ) id 1mNZhi-0001Fx-8O; Tue, 07 Sep 2021 11:55:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180882.327744; Tue, 07 Sep 2021 11:55:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNZhi-0001Fq-5R; Tue, 07 Sep 2021 11:55:54 +0000 Received: by outflank-mailman (input) for mailman id 180882; Tue, 07 Sep 2021 11:55:53 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNZhh-0001Fe-2m for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 11:55:53 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 5a85566e-690e-437c-8ed7-ea38d3ad4bf0; Tue, 07 Sep 2021 11:55:52 +0000 (UTC) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01lp2059.outbound.protection.outlook.com [104.47.0.59]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-18-Q2S6YrQtPACFdjbFEOxWlQ-2; Tue, 07 Sep 2021 13:55:50 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR04MB6176.eurprd04.prod.outlook.com (2603:10a6:803:f6::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.21; Tue, 7 Sep 2021 11:55:48 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4500.014; Tue, 7 Sep 2021 11:55:48 +0000 Received: from [10.156.60.236] (37.24.206.209) by PR3P251CA0008.EURP251.PROD.OUTLOOK.COM (2603:10a6:102:b5::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Tue, 7 Sep 2021 11:55:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5a85566e-690e-437c-8ed7-ea38d3ad4bf0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1631015751; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=02K8jo5kY9f/H13Wdg3xSQKXDLNPqJIa9jSlnKCW1tU=; b=NYv0fS5he8IRkXNPWvA6fjvumZMr/MMmMZvGybOOHntDisUJgixvhBveDw/6KdfXpwGjtq 2KnM+aSdsYcA2T9/+zvBXwq54U2ps5/g4P7iXMEnGY6qigmDHAE7c3iaLxS7LUQbPdCdBL CbyRKdPQfebLTOXIavtrBHfh9S58PB0= X-MC-Unique: Q2S6YrQtPACFdjbFEOxWlQ-2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SNtz/WSoQrRC2vFAqRm/r0p0w0pmeSD8daRRk8vzoeWxNrv7J7tsSCT2H5AtPrqJQMjyJltfYhSZap01pBZQg1WglzcgJofInP2LnWCGtOCbZT9co6YQQSCLzgHwZdBGhnnDWloBxm0U/70rb7oo+wkbs2BLG3qKUhHv272T4xrbAACMancs4SZR04xM6Mw7scLwdn5h+dRcmEs0QBBfLAwHJZPeVH+HxrFSV3Lg1GhOZfE1x5if3WDzyv08WYDiUfPwC1ZgBN5Nt/4KkKLiSAp9SzC6YvpGWBOz9HbCVqxzVusY6gu2PLT3PjL/BmpvfpqVQDVjsLSMt60ZyiiF9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=El/+PteE+bpQXJfC9/uVNmt0qBNzA8BbA4wrelc4lus=; b=ZTLQm2R56q9GPneKd1KXybi6fdmqRkxgmTxi3UJzLhRXBVJQxKj/wdF55BuNUfs/qKomxV6iRspV4ulSLh9hD0yUgI3IzQ91k6Eq5Ug4iWua26UP0CmFiJ7+V+hH5Sdu8/BkeYI0HrRe0U4LPwKsRz4HQBwWnxQ9J6Uy2kc/1K+OfZueC+I1xZaakpnT4mFM5YRDmgrdthJIbxktvLv2opkk+KD3uEkmQaIrr/y7h6utFoKzlLgMK/molJ2TNkrdp4LZZBJpOO9XIvUTCXak/h4uZuzVhoWZV8oNtFRD5trg0v/k3wfbG0axYKkzEbmADPEXIwfsnzK/HKNSEJKQ7g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=suse.com; Subject: Re: [RFC PATCH] xen/design: Add design for EFI dom0less system start To: Luca Fancellu , Julien Grall CC: xen-devel@lists.xenproject.org, Bertrand Marquis , wei.chen@arm.com, Andrew Cooper , George Dunlap , Ian Jackson , Stefano Stabellini , Wei Liu References: <20210907065228.21794-1-luca.fancellu@arm.com> <4bab7902-0268-5705-5462-fcd7571d7492@xen.org> <7BD59287-75ED-4D4F-B892-F6B04583A986@arm.com> From: Jan Beulich Message-ID: Date: Tue, 7 Sep 2021 13:55:45 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: <7BD59287-75ED-4D4F-B892-F6B04583A986@arm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: PR3P251CA0008.EURP251.PROD.OUTLOOK.COM (2603:10a6:102:b5::11) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6c66c567-e819-4fdc-7aae-08d971f66e6e X-MS-TrafficTypeDiagnostic: VI1PR04MB6176: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CdFi/uHpxDnHVJmp3Q1zeAmg8B6MH4G4Dvc99OlQfLqxIF0h3Jvykold5TBHhuVJxMax68yggwe+pxll52BC7/nZ/ZodtmscZYO/N/vWJT+GzN9FnJYlDjB3hDB9HKfDVznwIJ7mapElhU6s07ApKwf6Aow5hDFaSHdbJbqLuazMgKKUBjtwMJWHndIQ2ji798PQJ+fqwVYGjdIIeggt9g7DqX3VvycQOBYRnw+9vm1puPo4ZJiIYyhYCxl8QpULktJu2CY4M1b5o1AJds10kACb7Sw/Os+yFWNv/HVF29wJVuVVYWG+9mQK+AsYTA7c042ejHWSDUOD5/SVT3eQmBLiB1Tq258ROV/y4NO9iaYAvmO7wWVoCe2s7ReaSRlmKyDhjnO9hCUfsrlJgpo8ay/dbtcNDM927ORa4UpDlIJq6DrFWZoy3g92FWeuBVm9xUGfylOznRCY+jcs0FBq9qKPAwkDCpIIQheP7qD+ZFnxFoGr8685TJAtRFvwue4CC+5aO5ZRnDB2xTuwU8jcf/vaiE0L3yTv9pyyPoVRg1T9sV9VvXYYmmPk2yrY9oF7KFaKIPtbjr3HxhDz8L1ZoqpJ2J7M2qQlf3bpPPDWWN5hlOk4cp4S3NaZe02vnNzngTReC4/yDbiOF9ZqM0vmGL+GHmvaycMkTPMKoILQt4A2m3JMxiY8tqOQAVyhl2cbla/Q6xbG3zh4EnY4K6lWO16V3cuHjsRIWjobDxSBGWw7Qz/gFtLDRX5Fr9kCakSO77XoCyGdMfc50ohT03LRig== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(396003)(346002)(39860400002)(136003)(376002)(366004)(38100700002)(6486002)(8936002)(31696002)(4326008)(186003)(31686004)(66946007)(36756003)(956004)(26005)(5660300002)(2906002)(7416002)(316002)(110136005)(53546011)(16576012)(478600001)(54906003)(86362001)(2616005)(8676002)(66556008)(66476007)(32563001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?SsQ6jAed8bPbD8QH5WQVPr/p5FflCdooBjaFm9LJ7uDaBq//pWNKoGpPCplX?= =?us-ascii?Q?2Cw+hQ+Vy7QD8wC/15xbTZyvxIFDwUoHtQzixp0sNZAK8Y0ZZ29c+T9uA6iC?= =?us-ascii?Q?BFfnT2YrVOLDjGbjdUzKmMb20i5NCh/mNxYOFAItba1ak1qYXSVM7+Akdvxx?= =?us-ascii?Q?SY9d55DOx78Y4y/b2wWzg12I7i0LSf80+Cbqtr9oJvo9OuGpsiSXPK5RSk6b?= =?us-ascii?Q?/yJqGy45FyzO2BiVH/MXiq6ZOlzyMuksgfVWKqBaIw4Fwv1Yj7hZqo/O/wt8?= =?us-ascii?Q?vwI7wEf2JKk8Sm48/A4xEFn1R0WAFr0kzyH9GA4mvDaAKuGzLEUkP6yu/Su/?= =?us-ascii?Q?f5M55aQz9cwGTwl6ce/GGIqQNO8OpU6f+qYMjJBis4yhrTqG+NdUWJnApLVt?= =?us-ascii?Q?nSL2Bp88dKigcK/KXY1kzvH3vx99g0bSeCMnJfxhDs1Ose+7YOA/ZCCOzrfh?= =?us-ascii?Q?eHcIOAX+V13pf8SY5GTFfsuRqVqF47/cZbiM1d9pc7Wigbr/Mz5QmiZFicxN?= =?us-ascii?Q?UOchiaPGi1aEhY16eDDEZW+PatXrvlOPWQC6ue/PDqTXMH8MUD7ZQu4vrmT/?= =?us-ascii?Q?Tw7b62VDg6G5lIdy/D0mgNcS8nkRTRRMkTNiH7kX8IZzbpf9Lo6inr/cghk5?= =?us-ascii?Q?9pPtfZGUPojaY7gs1CFykyucpNlhYizbKLsUh6lVs9TyMJus/40EizPwVp+Q?= =?us-ascii?Q?xBfGswDdPpCEZEQ5mMRg/JEpABayhc9qG95mVpmS80wG8Y6zgn3MDXwlwboF?= =?us-ascii?Q?bXuAhjuiD/gyrnrB6VZfFo9MXWV1PyJbmUn3jPY4BBA963ZwYPn1R7uNyezZ?= =?us-ascii?Q?ZNIEUR23d7iQRkSx/Q2+y3kqDPeXsFVYnHh/5FapumCCPeUIGUsUEkfYUmdQ?= =?us-ascii?Q?nF4ixnK1sSfyprDK/DK8yZslFMTS8RiqhEhEMr7lG2lK0qdOl5INrXykLZ5c?= =?us-ascii?Q?8aDfuWdD7L6gkIERLhboFirDjBcNhM8wFr2hyuxmxItdROT+Q9ahnZXwkrfA?= =?us-ascii?Q?3HcszgszQKReSTH8580A8g+BXwv0wsH0N0fFagAwBPI7fX+3b5Yu2mYRAPtj?= =?us-ascii?Q?iLRquNTCaVczU6gzcvGKlw1zMNoC8IEKCQHGgMYFjDP32UBKADfDrb2FNObg?= =?us-ascii?Q?t623vCadsyjUd5cZhLEKTr5FuVaMPgAkOBu7ZB+OMOSvVENMppsLCXeshDBU?= =?us-ascii?Q?5SEsWvaBkaA/Lab6L9qAYTAYewIVCL/TvRDmjxzT3RIq3pTQXdbgrSqcKu4u?= =?us-ascii?Q?dP8HG7M6PiZua7pGu6qqYozJRsvjNnO5VFikMHNJ+JfNz2I78XSOw0Vf+tPk?= =?us-ascii?Q?xZUnbp9IxMuvqHBmsLsr6PiW?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6c66c567-e819-4fdc-7aae-08d971f66e6e X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2021 11:55:48.0282 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: NSXzZXGr57trJ+4EkwnboSNC0e2kIkQyV3VcdtdTsGZ4QWjMaSP9c1/qM5i2RGWzjZSqhuy/ckxVYgvHpk5dKQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6176 On 07.09.2021 13:51, Luca Fancellu wrote: >> On 7 Sep 2021, at 10:35, Julien Grall wrote: >> On 07/09/2021 07:52, Luca Fancellu wrote: >>> --- /dev/null >>> +++ b/docs/designs/efi-arm-dom0less.md >>> @@ -0,0 +1,105 @@ >>> +# Xen EFI configuration file >>> + >>> +The current configuration file used by Xen when it is started as an EF= I >>> +application is considering only the dom0 guest and doesn't have any >>> +property to describe and load in memory domU guests. >> >> From my understanding, the problem is less about properties (we already = have them in the Device-Tree) but more about where are the binaries located= in memory as we don't know in advance. >=20 > I think I used the wrong word there, I meant =E2=80=9Ckeyword=E2=80=9D in= stead of =E2=80=9Cproperty=E2=80=9D because I was referring about the > lack of keywords to describe a domu guest in the Xen EFI configuration fi= le. >=20 > I agree with you that on systems with static allocation, the kernel and r= amdisk binaries must be at certain locations > that are out of control when we use the EFI boot services, the thing we c= an do is provide a keyword to specify the > addresses and then use the CopyMem() function to relocate the kernel/ramd= isk in the address we want. >=20 >> >> So I would like to propose something that build on top of the Device-Tre= e work we did. Note this is early thoughts. >> >> The problematic nodes in the DT are: >> >> module@0x4a000000 { >> compatible =3D "multiboot,kernel", "multiboot,module"; >> reg =3D <0x0 0x4a000000 0xffffff>; >> bootargs =3D "console=3DttyAMA0 init=3D/bin/sh"; >> }; >> >> module@0x4b000000 { >> compatible =3D "multiboot,ramdisk", "multiboot,module"; >> reg =3D <0x0 0x4b000000 0xffffff>; >> }; >> >> In particular the property "reg" cannot be known in advance because the = UEFI stub will be responsible to load the binaries in memory. >=20 > Yes that=E2=80=99s true, the UEFI stub is using from the UEFI boot servic= e the AllocatePages function that is giving back an address out of our cont= rol, > then using another function the binary is read from the disk and copied a= t that address, finally the UEFI stub is writing the node in the device tre= e that > will be used by Xen later. If you know the intended address is available, AllocatePages() can very wel= l be given a pre-determined address via the AllocateAddress allocation type. Jan From xen-devel-bounces@lists.xenproject.org Tue Sep 07 12:03:49 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 12:03:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180894.327755 (Exim 4.92) (envelope-from ) id 1mNZpC-0003Ig-Eb; Tue, 07 Sep 2021 12:03:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180894.327755; Tue, 07 Sep 2021 12:03:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNZpC-0003IZ-BY; Tue, 07 Sep 2021 12:03:38 +0000 Received: by outflank-mailman (input) for mailman id 180894; Tue, 07 Sep 2021 12:03:37 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNZpB-0003IT-IG for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 12:03:37 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id a0f695b6-0fd3-11ec-b0eb-12813bfff9fa; Tue, 07 Sep 2021 12:03:36 +0000 (UTC) Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-he1eur02lp2052.outbound.protection.outlook.com [104.47.5.52]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-1-Y331f32DNwm2pXv9fgcBiQ-1; Tue, 07 Sep 2021 14:03:34 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR04MB3120.eurprd04.prod.outlook.com (2603:10a6:802:e::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.25; Tue, 7 Sep 2021 12:03:32 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4500.014; Tue, 7 Sep 2021 12:03:32 +0000 Received: from [10.156.60.236] (37.24.206.209) by AM0PR04CA0106.eurprd04.prod.outlook.com (2603:10a6:208:be::47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Tue, 7 Sep 2021 12:03:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a0f695b6-0fd3-11ec-b0eb-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1631016215; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=E2UE+ZRwTyLPZzFoXjrcRBIUg7Nc5I95rFYE+wbcJnA=; b=JMC2l+Lusc8oyAAImD41kO878TdsUUcp2RWjW9hmpJyOaZQEiOT2JORsPKsjl8hwoDXFSj lp422QirQ/wyyJUgQz9oFKiw13ABzy5hN81tlXoOT8CBTdHCgw7SSG0AmEIb1TyoIW4Hx9 1hcEJh4nOhGE/pXtpMb0Se5IRqC/KV8= X-MC-Unique: Y331f32DNwm2pXv9fgcBiQ-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=l28+79zKnHNhBBq9ANnTM17vSuBq/3+UeHInBi1Zso4NXl4KTFTzUVP/MELeiwnhjbI3DWfI9j/mVeFJXFwXfndaaC1XpQBydzAZCyAZpEqX79SB7cAXAZ1/05FoqnXmkG0rxiVvMLgQnaWNBUK0ae91Q436dgJI0ijkqoxjwjfzS4WX9a1HMmF5wDtw1W26qcmQKn9Zt8iTC27muSB2JiR4luMt6je/MciLK4zj7zHZDcExK4OTe4KL4NQ6m85RmmbXqXRvevxgV1UUk7feXHdbMfsy5PrK5n4Z10ceO4eZOEQfFuXgix7KyjYAMhLV9HKfpH1jBHNhrTOT3IAk8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=E2UE+ZRwTyLPZzFoXjrcRBIUg7Nc5I95rFYE+wbcJnA=; b=napd71XSbTlC44/bcrwYDtCTtjZQyUpwbh3kPX79Z7q+jcazdc0LR7YCkS/k/th5BBcayvri6ATOgL9ynHMA9XWLpfJ5rF0vyvaagoffUbwy6YNON/zB54+m+M1mFwf6SHao2Aix/avLapBlCLTZSwxIk7tMqK0exsfCSDwDBT+lTK0lqmY0VooDD2C1CgsgWmd/yhnFNs3Ht/AdOt1UzPTqg75rOmi+aGnGPTJdW2iq/JKfFdjzB11f0L2Y1f+0CIxwqCBqMg+3xwdRFH67LCVnPat2pGwMfarkbbtdtWJ+0U/o6R+c1AVXCsq5RamIAMfvKO/Jp6jqtXisxbsiPg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com; To: Juergen Gross , Boris Ostrovsky Cc: Stefano Stabellini , lkml , "xen-devel@lists.xenproject.org" From: Jan Beulich Subject: [PATCH 00/12] swiotlb-xen: fixes and adjustments Message-ID: <588b3e6d-2682-160c-468e-44ca4867a570@suse.com> Date: Tue, 7 Sep 2021 14:03:31 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM0PR04CA0106.eurprd04.prod.outlook.com (2603:10a6:208:be::47) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d4008ec7-e485-462c-2aa4-08d971f78366 X-MS-TrafficTypeDiagnostic: VI1PR04MB3120: X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:5797; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gXQ3lr0rQ/68oGTucfAwyap3gcxsTliw48mbk0/jbbax99JVMC0WlrbOTSBuEP8IwMrjMisLsrc8YbQ0ygnKPbDlZdThuAtpP1a5KmIiBJi8AXdX7TCeWd4pwfVIKbZgg3AfbdXHeWPXQ2U8xNF4y07Yz6TvAUvA/W5+IyEc9P0oSZmYUqWVLGSmbZMffTD6/0XA+qR4DLqCM6UztCZgCMAWUN4cLIVu0OmYJQ12Ic0t7vRN41WThHHhpaflHlQo99c//7DTCn9oxBdSSxNKd3wchE/FSZ8F0D0uysl7mQ4cvsB2clV4t41unGXtbDjRKmOoPyvu99dRmBJk6d6/AeAnBFh/J9dd2eXlfmhtEp8gQyHRQ6kquFm/aa2ESqLa20DFdKsR6SBkZMmbS0oXztPtFH+vAiTVnhf/DX+FuHt3C7QPj/TQXNidP9RnDSHk3oCMo7TlcbfhTYaSTofirEJf6n9qXdufjazMMbHU03ZU2Sxs1AjyBMYHMjClA0WN+D7ZqR7hFX1BVQ25KQmtNX0Vfv0mRylByI8KjPBKP+C8WyQHHOlXVWDVindEic83q6K7gOCgcHt6v0n4AAwBzI/6LDZOhW5RaTWKw+UBWhf2MQF62ImieNc+wxvLaBr7LgPAs3fqZMAJW3T2WDHbXcoh7Kwc2uTLZAkc27hzCuThiUsaAuCgjlalpR1U8t/UNADRUXX2UNvmhBAwL/i3ycvfYXhTinza3m0Rox4RQ07Y2ZLgEs0M4LYTYN0MI3iI X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(39860400002)(136003)(396003)(376002)(366004)(346002)(6486002)(956004)(38100700002)(2616005)(86362001)(316002)(16576012)(83380400001)(26005)(186003)(36756003)(4326008)(2906002)(66946007)(66476007)(478600001)(66556008)(5660300002)(8676002)(31686004)(110136005)(54906003)(8936002)(4744005)(31696002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aWtNeFdieU0xZUtVSitVTjBPMWRzcy9STTZDMjEyTVoraS95RUtzZEVnRVlm?= =?utf-8?B?UmkxY0ZMeE15NG90cnFISXBSOTUxMWhheVdTMjRraHRlM0ZRUkNCTytNeDFD?= =?utf-8?B?OHJVdmZRRDdtcFpVRS9xam16dTFQR3VxR29JNHlueG1rQjd1TGJhaVlKUTY3?= =?utf-8?B?eFNzbmhDZEwrNlUydFlBN1RnQng4L3dlNzN0UlVORncxZEJtSFp6Z1ZpRWVC?= =?utf-8?B?Um9WREZnUUZXRTJCWldDWjBkcFJYb3dnaTl1ZHVhYXQzbW8yNkVsZUxwbEpy?= =?utf-8?B?VjlVWUhGdHFIY3FGYXlsRFUvcy91MS90Z0VUeVNjd251VHpGVUJQdEk5NzBY?= =?utf-8?B?aWllSG5rZEVzcGNtM2hsTEtKWm9tZm1OZ3V3TkZlWHhDWE90b1VTUVkwZHYz?= =?utf-8?B?MWNuWGJMUVNUbWQwc2NTVnRtamRER1hrV1RYYXpuZ2JBdzJhTkVhMm9kblRx?= =?utf-8?B?VnJGWXJWWXlLdkZJMGJ2WDdGUWpsU2lMUE1VZittRTRhZWM4Y1BISUhkT1dT?= =?utf-8?B?YXkwRlA4Q2JJS0NGUXJ5R1Y3aUtnZW9Zcm12R3phakNFeEREcVRTNHNNNitJ?= =?utf-8?B?eExBdVV6dG1wbFBVRkMyL1VMQmdvd0Z3c2xSNGJnMWcxbHJXNXljQWRZdTFu?= =?utf-8?B?eDN0QXdYb1g2WFFKTXJncXlBc3Qrd3Z2OHNQRlE5RUo3WlJhUHU0bnUwNEJX?= =?utf-8?B?cWUwTnFxM3g0RWFDOTBYTmgySzhmNTc0MTgxeGY3SGFnZkd2U3BVSVJMTzhn?= =?utf-8?B?ZEZ5Q2hTM09EdjVCQ21tUmxXazN2VlBOV2ZJYmdIZUhZYlpoTmF3eGpSSVov?= =?utf-8?B?NHZGbkpJNzFsUi9iemlhZW1ZUXlwdFlBWGtkZWYxU3FEZnRnc2ppUjN4TXky?= =?utf-8?B?d243V0ZIVHY3cTM3QVJDcG9aRnJiRmpIRmRnR2J2NEd4SVBVbVB0U1QybmVP?= =?utf-8?B?alg3eTArUkFpenZsYmhSN1pwKzN4NDhMejRvRWhWYzQ4bTYyUlZQNUM4NnpV?= =?utf-8?B?T29icytlSEpVUW9Zc3h0TmtxZ0ZUS2V3ZkJ0SDVYd1RMdEpoZzQ1cWpzUjkx?= =?utf-8?B?dWZtdGRSUm5jMkU0aWxEdGtRQVNZa3o4RVhaOWhXMlU3WHhlU01oWUcxSzJl?= =?utf-8?B?Y05acGhQTFBaVFZaNXRJTEN4NkxrQkNNaUtXeGgrZERZWmg2ZUw4Mi9BZFQv?= =?utf-8?B?aTcrUHNZeUxuQWNMQ0c0dmZNTDlyRjVvWVRtOFZqQlRRQlprMCs3MXB3Q3ZL?= =?utf-8?B?UDdFZk11ZGJmZ3orSEE2NXppSVRvS3JjOEF6eWFYYjFSYTd5aEUwOUFVQWlu?= =?utf-8?B?MGdnOUR5aGRSOGFzYkZocDhSRFZ5VFhiN0tHSUxiMldaSXkwQlRibTBhS21u?= =?utf-8?B?Q2dyL3I1Q3U0WVVRK0ZYbGRDMms2OTJGazhSVzExdkV6bEFUOXpSZzNvejVD?= =?utf-8?B?UUFJc2hPVmRYVnVRNU4xKzZXNTk0dVI3WVJ2cmFUMWdmRWpFajBzanczcVEy?= =?utf-8?B?OFl5bmRRZlREUHJyMmVsL1hCNldLNVlGckxYYzV5ejhQSFg1a0YxcGZISVhO?= =?utf-8?B?SloweCtGMFdKdVlselEzWENEaDEvaU93UVVHRTJGUEtFVExZRzhCWHpuSFRO?= =?utf-8?B?KytDQXZ6WEtmV2dQMmhiR3doUGp1NTNGTFNQclhTUCt6QUJuWklkT3lBaG82?= =?utf-8?B?djJSTjBMbFdZZm8rS0I1MVNMS29EeDdPVGwyVVNpUEtwdHIwaXNmaE5YMGox?= =?utf-8?Q?X9VF6pViJXIf4J4I5WlrUnSUwWbFxSKHCPQvDvZ?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: d4008ec7-e485-462c-2aa4-08d971f78366 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2021 12:03:32.6076 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: vIovpZJGSULoeQGlwuD0njofzK9Yujr6F8vg8ppn8ZVmS5mQpzu+vXvTl6+0/lsjr+ysyD5eEtwKSWjQaqHK5g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB3120 The primary intention really was the last patch, there you go ... 01: swiotlb-xen: avoid double free 02: swiotlb-xen: fix late init retry 03: swiotlb-xen: maintain slab count properly 04: swiotlb-xen: ensure to issue well-formed XENMEM_exchange requests 05: swiotlb-xen: suppress certain init retries 06: swiotlb-xen: limit init retries 07: swiotlb-xen: drop leftover __ref 08: swiotlb-xen: arrange to have buffer info logged 09: swiotlb-xen: drop DEFAULT_NSLABS 10: xen-pcifront: this module is PV-only 11: xen/pci-swiotlb: reduce visibility of symbols 12: swiotlb-xen: this is PV-only on x86 Jan From xen-devel-bounces@lists.xenproject.org Tue Sep 07 12:04:33 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 12:04:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180902.327766 (Exim 4.92) (envelope-from ) id 1mNZq4-0003rM-PV; Tue, 07 Sep 2021 12:04:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180902.327766; Tue, 07 Sep 2021 12:04:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNZq4-0003rF-MV; Tue, 07 Sep 2021 12:04:32 +0000 Received: by outflank-mailman (input) for mailman id 180902; Tue, 07 Sep 2021 12:04:31 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNZq3-0003r7-AZ for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 12:04:31 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id c166c816-0fd3-11ec-b0eb-12813bfff9fa; Tue, 07 Sep 2021 12:04:30 +0000 (UTC) Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-am5eur03lp2055.outbound.protection.outlook.com [104.47.8.55]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-15-1WTDrmR2MLyfRnbNaWU5jw-1; Tue, 07 Sep 2021 14:04:28 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR04MB3120.eurprd04.prod.outlook.com (2603:10a6:802:e::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.25; Tue, 7 Sep 2021 12:04:27 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4500.014; Tue, 7 Sep 2021 12:04:27 +0000 Received: from [10.156.60.236] (37.24.206.209) by AM0PR04CA0096.eurprd04.prod.outlook.com (2603:10a6:208:be::37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14 via Frontend Transport; Tue, 7 Sep 2021 12:04:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c166c816-0fd3-11ec-b0eb-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1631016269; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YUjiZ+FcARWZPfFdze9B3FWeG4LoDQIbpj7UKsZHujs=; b=Qg/AlsS5lskTedWM7PBZtc1T9M3UnlHNgaXHI5xEZiSzMq4mgEMA/4Tfkd06ub5k7A1nym EzneuDDEenGhF9w9DpmDJBZcWb8yfhEUN98MKruMkhMVJIy3IRs/85Zohq4lhwj2fpqFCn qq0gYMMRPR/L0MyPW66A9eFqRyNkYRI= X-MC-Unique: 1WTDrmR2MLyfRnbNaWU5jw-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hWqVnRoSMtkkKoLxFIHeXIgiaJovVpi2T/C6/AsZB7qDEw+xtIrewTpygFBpQZZoseK8rv/oXPeqB/Kza9pJ90bRay4WbZJj7ouIFUIA8vcb/6Q9ZGxjOThcrIIGWqZGjuqEo7RoLMYwhGcZbyvUu28tXdCKByKfWxZMD8a0CTqjWYKz1pu1b4r42ZD4nZOJy9EdJv+9mAK18zwcpqqbMkYXrwHVoY90wnTudnjsEwyz7cCtferfkASLjI4MFjnMq6vxo7WfJr4FgGcQ+vZyfr0D1iJZv01FvTd2ko959+vhmP6sUAuO3C8hIc/CZB81u+pTlRYutm4XWuZzGmkDJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=YUjiZ+FcARWZPfFdze9B3FWeG4LoDQIbpj7UKsZHujs=; b=P/sUORgtT+v0e8U6tOn4IUxrHCYqaVhHrluOs2tQ+UpS42gjQBgVMNtpDnx9DGQHxpUC0onhjzDLvMQMEXKU4ytjm6SUeW8tcXIEF0azjIWi4sDVwQU67lYxbLsF+m0DrXo5T+8fltnBWNvJzwcnOwroomHg9EGY81/Ygjgb9tWq7BJiXssn3FFbywMjF9Jl7u+BBnrECVbegyPrEUE9vtXVBZzJqDvQmik+bI5pP4wcbvWeNdWKLYnyim7nJTGIbZq+I8lJI1vQ1pz27lm+AnxS6LJ5TO3IRV/dqLadTHtTLOjFwN/Ktxs0sBXMmLdH2IKAUmXxYSYzAmv1NyBeNA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com; Subject: [PATCH 01/12] swiotlb-xen: avoid double free From: Jan Beulich To: Juergen Gross , Boris Ostrovsky Cc: Stefano Stabellini , lkml , "xen-devel@lists.xenproject.org" References: <588b3e6d-2682-160c-468e-44ca4867a570@suse.com> Message-ID: Date: Tue, 7 Sep 2021 14:04:25 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: <588b3e6d-2682-160c-468e-44ca4867a570@suse.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM0PR04CA0096.eurprd04.prod.outlook.com (2603:10a6:208:be::37) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 921de9e7-79f6-4e70-1d37-08d971f7a410 X-MS-TrafficTypeDiagnostic: VI1PR04MB3120: X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4714; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: cTKXp63JMT+BOej5u6mmIeFwoZz5HLopoCNNDmsPAfAJMiZxsA7fw2XDuaefcIvO/z9fhrHpmzco/sPf+qbyEWQg2kNkrv2VEjOuVlrroyMfcvfE2I072EhTZ1sYwOAc1jeqdzuboiL5weYhMRsPIXWe+DIR2ju2+eV2gX4NzVHEYcxK8AkcxTiQh3EWAWkNO8R8vcTAQL/f2fMwEKP4lGofC0XzX/eIOLDHvw/pRPFI2ActBVdpN3zwUA82e26DNpRS8NrPCkA7DK00nB9WbruRgOrp51QMku8GZG1lx0MhjqfqrJKVaQ3b+rTLsh5EoKVGfmNYXAVg2gHNsrHNi0qshYakSNwtE8mIYZxNvmtXSIqEIFYN+/gP9sHzd5Ww0lctLsRQaCuKlXMqNpPC663xQC9eXQstM2YVJ+W4J/Z6n3UbLvecHEpc0gBz/2gOKgBt97MEmkrGnDeIXhlKq6QIKAwxWBJmE0apSNBNLGqGHbfkdTSfJHN9vBPz3LHEg4NhZ5vwOF1+SoOybfIeL4a9wXdbtQUJP7s0WxoU7yHZlpmA/KAvYbnxx4rOJDOh8QTU+NxyXwnN0xWQemY7TAslj8ZaxC+dVtzeDeRk8wBSeKHml5NqiBusXJpiUX5VjwvtW9/D2f01BHWq9iRGvuBywI4/e3nz4tikmbBjWksPB+xjrhKgnvo6msIQwlogf8IsKWSeMjRmMhRHvCFrj/JYibGZmYHfIFLdDz5BGHI= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(39860400002)(136003)(396003)(376002)(366004)(346002)(6486002)(956004)(38100700002)(2616005)(86362001)(316002)(16576012)(83380400001)(26005)(186003)(36756003)(4326008)(2906002)(66946007)(66476007)(478600001)(66556008)(5660300002)(8676002)(31686004)(110136005)(54906003)(8936002)(4744005)(31696002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d3FudDlzTVc5RUZZeWhhMWJyUEx6Rm5IaXAzWUZ0MmgrMUcrYjJNK1VMYUJS?= =?utf-8?B?U3paOGsxT2llZDNNMVBaakdUMEtNTzBzNmJzMTJKNlZmUm5oeXZhS05hWEhk?= =?utf-8?B?VnFZdGNHK1o3cmtIR3pIRzRFQVdjUzc2d0VkdWtIQlpLbDFWOE1WTENQMnRi?= =?utf-8?B?b2pUR3pQc1p1MUpGZ2lZRklKRjliRWdEYkZCZGhuQmpYdVc3SysvQ253aG9P?= =?utf-8?B?d1lHNDdTMXIxVGdOZXIxWUE2STluVjRPTVhoYnQxcnNtUWYzU0N5OWhqTE1a?= =?utf-8?B?VnNlMWNnL1hhT3lJLy94TW9jbzVnY1NnaVlpd1ZCbXJrV3k3ajIyTDRiOVZh?= =?utf-8?B?Q2E0QzJGL3dqVThtWE1UV2pYVTRQUmpqRGZsdkxMa1BDSDR6ZTA1RW1NWjBP?= =?utf-8?B?NWlaMzEvUjNidEpjekpMUmdQMFZkOVZWRnArSTlLNE1MSFdKWXkxekdIcWla?= =?utf-8?B?NElCck5iS0hudjhpcGoyL2FQS3hlVGZhQWEvWnI4L3lVOG5hRU12VVZBeHNN?= =?utf-8?B?RmhoVmlkZjViSUVyaUw1OC8rbGtCTGQzZHJxb3h0NDFTdzlRbCt6K1N5Ylhn?= =?utf-8?B?N1pFNE91ZHJZTGZnS1NqYkRvVWh0Ukx1WEg2M1Z4cC9FT0cycVJiNDFldDJF?= =?utf-8?B?dWJXY0VqVWxQbzF6STZHNHdvZ1U0NTB1dVZiT01sWHpBeXNYbnFpZE9qTXpZ?= =?utf-8?B?Tkk5OTZrVzhCY0JlM2xFVG4zM25xRjVnSncySXIzYjBtdGV6TUhxWFQweVJD?= =?utf-8?B?V0hrMEsxWmN2L3JPTjRIU3VIbldoZTRFT3ZnbW1PckZqZUcxbTBzbG15dWc0?= =?utf-8?B?cUx2T0h3WWQwdDFreUVGMzFMTE1wM3NtQjZ5ZkFuM2NvWWhXN2Q1VDFNV3ow?= =?utf-8?B?ZUp6R3BxOVJnUGVZY3JETnRya3d4WGZXNzRNK0I0VHpEQ1BLWWFiRE5KTkpY?= =?utf-8?B?VzUyZXV0MlBoY2M1VHlTaW8rRWxBbHZmSzhkTHloRFlSS05TQS8yMWxWY3J4?= =?utf-8?B?Y3FaZ1Y3WVZjbWJaOHBsdnlSaFRMTUtIeFd6T1g1WlVDOXRqWURoWGRZc2tt?= =?utf-8?B?a2hjOWtDTDBLaG5LaW1sUWdONnRvWkdSd1R2NVRhalhGMU9PM3ZkRTJoU1Vi?= =?utf-8?B?QWc3OUF6c04wZ1BwQ2EzYWgwRC9HZVY3cmhlOHV3YVJiYnZkcUY5VHhhV2sr?= =?utf-8?B?MFV0L213TXZncU52KzZJeTVncjZHQUtqbWFPdFN6TnVEVTRvQUdBQmh1MFo0?= =?utf-8?B?WmpQdEdOYmM1dE4xMy9OTW5FbVYwTU4yRllvakJvR1B4b29La2dya2FrSUJC?= =?utf-8?B?cjcyZlpVZnB1bVVaVzQ0Nm1rL3QrS0FxbFp6MEpWQ2pOWlA1Q2hkeHNoTVZu?= =?utf-8?B?QzJjQlNJZGZMMU41UUREdTZNalRlRnJycU1IdFVHZFl0MzR0d2ZReEdTTGRa?= =?utf-8?B?L0xpaUJjdDlhQTk3bkE2MkkwMUF2Zm9DMXR2eFZsVFNGVHN5K3dPdTdaQko3?= =?utf-8?B?WDFzTjQ5Z0JOMEZtc25KQnRzZ3BOZUdjTlp1WkZjM1FQSnpoSFhqUGUyVkRs?= =?utf-8?B?YVhObzRQMDV3eTZsRXdsTHE0R255SWtVdVRKbTVNYjQxa2VheTIybXpTM3Y3?= =?utf-8?B?VVNnOWNsRDY5OENWVU8yckxqVVBrY0E0ZUVQUXNDSzdCeU5sNVFwV1JrbjJH?= =?utf-8?B?NWE2TldNR21oVm8yV0R4SHdubTRqZ3RRVEtuR3FOelJBbnlHRkh5MFdFTmpW?= =?utf-8?Q?WAG8SzkZU1bnjyZ9mtOD9I9rNAZYcDqmM+yfsrP?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 921de9e7-79f6-4e70-1d37-08d971f7a410 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2021 12:04:27.4045 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: fxmyLLc2/qK2sEN83kbQC4/qg3WM3+6UGQu1CSP/kkah2+uudkIas1308gmuLjq4QwRWerOTYZ0iL0+NKi/ObQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB3120 Of the two paths leading to the "error" label in xen_swiotlb_init() one didn't allocate anything, while the other did already free what was allocated. Fixes: b82776005369 ("xen/swiotlb: Use the swiotlb_late_init_with_tbl to init Xen-SWIOTLB late when PV PCI is used") Signed-off-by: Jan Beulich Cc: stable@vger.kernel.org --- a/drivers/xen/swiotlb-xen.c +++ b/drivers/xen/swiotlb-xen.c @@ -216,7 +216,6 @@ error: goto retry; } pr_err("%s (rc:%d)\n", xen_swiotlb_error(m_ret), rc); - free_pages((unsigned long)start, order); return rc; } From xen-devel-bounces@lists.xenproject.org Tue Sep 07 12:04:55 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 12:04:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180904.327778 (Exim 4.92) (envelope-from ) id 1mNZqR-0004MB-2K; Tue, 07 Sep 2021 12:04:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180904.327778; Tue, 07 Sep 2021 12:04:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNZqQ-0004M2-VA; Tue, 07 Sep 2021 12:04:54 +0000 Received: by outflank-mailman (input) for mailman id 180904; Tue, 07 Sep 2021 12:04:54 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNZqQ-0004LY-07 for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 12:04:54 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id ceef2456-0fd3-11ec-b0eb-12813bfff9fa; Tue, 07 Sep 2021 12:04:53 +0000 (UTC) Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-he1eur02lp2056.outbound.protection.outlook.com [104.47.5.56]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-20-OVm-SvxQOwytzB7hKxUMTg-1; Tue, 07 Sep 2021 14:04:51 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR04MB3120.eurprd04.prod.outlook.com (2603:10a6:802:e::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.25; Tue, 7 Sep 2021 12:04:50 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4500.014; Tue, 7 Sep 2021 12:04:50 +0000 Received: from [10.156.60.236] (37.24.206.209) by AM8P191CA0025.EURP191.PROD.OUTLOOK.COM (2603:10a6:20b:21a::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14 via Frontend Transport; Tue, 7 Sep 2021 12:04:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ceef2456-0fd3-11ec-b0eb-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1631016292; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SEuCaucOQlDfG0ryFHeKwBYGR4l7zA4FQQ51ni9uTXg=; b=mE8Q40nkht5RRzywnbwG8Em7tR5ztaY36D8bh8eDJx3ti+QNg/2jz3+5aWN90rNG2BWQQ4 JnH2rneP9KzAM2A23f6DuS4njDyndwcSOFnWMijHXVD2IC8PNcmvTEQoERg4DwdDOHxSpo RQI2h8YxC7Lj+bs75fdOvDnrJaLsJaU= X-MC-Unique: OVm-SvxQOwytzB7hKxUMTg-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ab66C7ASTuno/bPzTb+Y8j3ccwUmyogXm6TzavZcrj3O1j2UW3/wnCZ2nP7GBM07+2VMSttopQsZL3M1bHVqu7tYUEc+WDliNoW3BEUNO1f3gSgOCS0+r4X8aR1pqBDedp6HXO5lezubR1Qv4MoVNJ6U5m66mAh9u5rwABNHjN97tTcsImXOvOGMxQaL0G6vppdK9UXiit4v+bsC+xZTNqamqSnLFR4NX24Sp1wQagy2O/N3o2z1rjcO/G9h81mXo6cqOaPKhdeaM9qWKHn+7FcGNJ4XIwWNYOOY4i9Cu7iIXKsoLRk2/feUE6vaX/DozkY0GVkKtbtO3ctu0PuZwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=SEuCaucOQlDfG0ryFHeKwBYGR4l7zA4FQQ51ni9uTXg=; b=SnzjV8laz/8YNs2cwweqzy/rW8YYs7YM4WCrzowBIoCakPCYY+0oeCSI7xq3kRikMLDC3MrN+iQMP1/pdCtPr68kh09M70foN3neAhMkreiYVR/1OFnmjH19h/svH8ThHFvZnlKn0YSAsKZUO5UZKV0Tg6pgOqY8uQJcg0Nwud0p1ODIupEDs0jXE9JVcJV9hWLf6CqgtfTn7euXlaaCN/apVUgPzGzAFdNQ47YtHGlfTRnTEYpttBBeWdJn/V2wdxmD4hKGUJersUgoS7PBpVV9JzP7GxyIgkGKUSyV0IAy2+rET1Mwh6R1diHaZTeBPLsRM2mCXAQPm8K3Of0uEw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com; Subject: [PATCH 02/12] swiotlb-xen: fix late init retry From: Jan Beulich To: Juergen Gross , Boris Ostrovsky Cc: Stefano Stabellini , lkml , "xen-devel@lists.xenproject.org" References: <588b3e6d-2682-160c-468e-44ca4867a570@suse.com> Message-ID: <778299d6-9cfd-1c13-026e-25ee5d14ecb3@suse.com> Date: Tue, 7 Sep 2021 14:04:47 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: <588b3e6d-2682-160c-468e-44ca4867a570@suse.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM8P191CA0025.EURP191.PROD.OUTLOOK.COM (2603:10a6:20b:21a::30) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3b9b8ee7-e96f-4f6f-ef01-08d971f7b176 X-MS-TrafficTypeDiagnostic: VI1PR04MB3120: X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:901; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gHKbMa/EKtBsFLeDT/7oxzcuXl2CWZ7i5ag6WT3vzfBLj/BZf/2wiynVdBsFfwBjFR8lQyxcbcVHC6zaa5fEomBY28TpP9BkKol0kSN2t05LNKCBlzRCQHnpkqdZNfUgrB92kN+ecLHTh0c/sKEB+zzLxg/SdGpLLNLzv05WUAH664MZ2+mjagQjxzpIqoT+ex3jeN4FoV4HI1iraFb+h+vkXDcQ0aAlK1qnOwLlINYy5m8bk0a+Rey0hL1ZCPNZsPOsF3FWqNsBegKdzu8In7CBbf9+4M/gw+qeHApI9IdCOxZEcvupHWonzSDqCt3Ux6tVNuHtsmfCwRqN9gPtBmRGhWf2YcXJU+o3mPkEqnDaQqC9HTQ4MWEo8RoEMNMT9e+E+TCC54PZ0F2oZS7n1WMOiwt1dja85SH0tgpW4H76/S5R7YmkzNrqWu7LJX9ELS6BELc576RDYpNThRd5/wPznTRkg31Nkfl8/H6VEm7yvcvzwuKAGJAjSzPMldSlV6Pook/oYzXJTgAciuqe12AVk2/OkTetVci1y4EYys/V31S2h3OCNkDIrSjuXS0OBgSAjhZfsFeHd6sLR60RQTGUBIW0CXsB0nq2gaNRKed11EBrqj+D9eI5LL5jw9Sqg5orY35MkRgJLb7thjlFxctCQr2sHBrOi2lstKm0ndzy693fT0/f5ccUvZ4kGTzsHI+mVYQQpcXzTT3CwbC7T+58N4IXA6aSlcEBVqXjYwE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(39860400002)(136003)(396003)(376002)(366004)(346002)(6486002)(956004)(38100700002)(2616005)(86362001)(316002)(16576012)(26005)(186003)(36756003)(4326008)(2906002)(66946007)(66476007)(478600001)(66556008)(5660300002)(8676002)(31686004)(110136005)(54906003)(8936002)(4744005)(31696002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VVBUeXI3d1htc1BlYVJ6dHlDdVZlT1hOeFVXODN5UUdhTDBQU3NlNVdRVE1G?= =?utf-8?B?c0hxbkxpclNmR2h0dkd1RlhDSkpVSXdPY3pLclRNZlJWWDI4MXAzM3pqK1d2?= =?utf-8?B?eU9jcVNVN2FGSjg0NTZ4b04zdXFEODIzeWxpbEQyd0JiVWx3Q1lRTnVGSlFW?= =?utf-8?B?N3h2TTRyM2R0ekFVc2RraTJxRjNybDZjRzhBejNyNFQzSmJtWEYzVUJCWHFn?= =?utf-8?B?NjVTUzg1WitVVFc3akRUVFU2dlBVMVlBdUtTcS9sT1Z2MWRwcnd1aHNFRW04?= =?utf-8?B?V2g1Z2FhdUxaRUpGa3JmZEc0bWNPMVp5MDhYWjZqYmxQT2FuTW5zVmRTTVp0?= =?utf-8?B?MXBEbzNVR0RCZFI3eFE1TWVzeUh5UU5IWW9MRzJtMzRBbHRkSjI4M0NLc3hQ?= =?utf-8?B?b2YzN24ydjUreTIrQVF0TGdhM2syQ0NWSWVCa0hMQlREQkl2dGZTOVJ4d1ov?= =?utf-8?B?NVJXNnNZRXdBTDQ5RExkdVp3bElDdEdOczdBU0xZT01jQ0JpN0JpYWxzdGpn?= =?utf-8?B?TkRVWXVabmJQVCs2a2hDbUk4Q0xFODViU0srbGpOVVNMUGJvRW5NazJ4NW5N?= =?utf-8?B?TVdEclFsYXhEMUtBaks4YXpnVCtqVmhuM3hzcDZwUHN3akRKNkFNTnBVbklK?= =?utf-8?B?YU1JdlRyNWc1cFNVRTBFSldhajl3cGJaeEVLRVhURElzK3FienF0NG1yWHRs?= =?utf-8?B?bEZFeGw2Zml5Z2QxUmVlQkhRclJBU0Jxa1dGNm41UWxZbXNVellWRzdOTjg2?= =?utf-8?B?UUZRMitxZHFrNWhrS3dJNDlWRCs3VDg5NS9wZTJXQ0hFTzgzWEljUlRtcTZy?= =?utf-8?B?Wm1qWjUra29zeGM4KzhEdHArMExYaGJMS0ZsbnF3RWtDUjVnNXJaVmRBNHFp?= =?utf-8?B?SXZIMk00MDFWMlRCYzdPczZQd083TVRiYWhHT1RjOG11MkdQU2UyYkpLc1lT?= =?utf-8?B?YlplWGx5bUNuTnhxYkk0YVNvKzJtSEZFeFlnSWhyRHNzNlNQdjVmMDJ6VVNQ?= =?utf-8?B?Y1lHSDF1ZytaWlR4TnlyTWNXd2xuTU5pT2VXTjNiMGRaSE1NbTJvM2lLWkhx?= =?utf-8?B?dml5TmE0TzR2bEM4cHpDNUwrTUZrSXVoSlFXd3B2QnpqY2NoVnM1dHMxa2pR?= =?utf-8?B?V0p3c05Hc3pidGhWZnFHVTBJT295enBSRm1XNVZlbytHSEo0SlI5a3VIZUNT?= =?utf-8?B?Z05BSkFlRThSTDJvb2V0d0RmRFNjc245dE1QSFRFSXlBZHBhSzNwYmRPUmg5?= =?utf-8?B?Y0N6d0g5RHVTUFFMeDEvNWhLc3kxNmhGZUhZNHJ2YWp3ZTdyd3VRL2tMZ3V3?= =?utf-8?B?OHRvMjJ2N1c5MENuYUtqNk4rL1NiTURNSWk3alBlTE9KbzZEK1dVMHY3Yy8y?= =?utf-8?B?T3ZLU2VWOEhxbGtHbk85ZnkwMTdUVngrQUg1cE5rbmM3aDhnMTVqdHpyN2JF?= =?utf-8?B?M0sxOFRYY3hpbWNLaVc4aUE2RmNJRHJ1ZFpvRlRYZG1KbzlYb2UzeG9Ic2VK?= =?utf-8?B?WTNNOGo2L3ovMmY3TWV5a2tBQitWd1ltZm5PSjd6N1lqeUVrMFI3RTVFNGhk?= =?utf-8?B?Qk9CODh1R000aitzaVRJK1BIeThKQ3V5NDZZaTQzek9oenNGdit6UnZOeGZ2?= =?utf-8?B?Tkc4QVpmUWVnODZYU2UyblkrQ1BjbndCNWdOY0U3Z29Fb0Yza1JockRxSVNK?= =?utf-8?B?b0h3Y1luMXZmdUlvajhaYzZHUE04UXJxUGY5Tkk0Nk9kRDBrekJjU1JuMTBJ?= =?utf-8?Q?C0FWkfpAGlLfHYZ6v8Q+PHZu5ejZzKVIfyDuDRj?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3b9b8ee7-e96f-4f6f-ef01-08d971f7b176 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2021 12:04:49.8957 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 5ekgPaTEnMDnoeOJ1xNV7KeNLMYISrN0W5UEYEoDo1ZcyumwM/eujCiVHt1UJcgqcmtKVMpXXX7Az4pqdMNEXA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB3120 The commit referenced below removed the assignment of "bytes" from xen_swiotlb_init() without - like done for xen_swiotlb_init_early() - adding an assignment on the retry path, thus leading to excessively sized allocations upon retries. Fixes: 2d29960af0be ("swiotlb: dynamically allocate io_tlb_default_mem") Signed-off-by: Jan Beulich Cc: stable@vger.kernel.org --- a/drivers/xen/swiotlb-xen.c +++ b/drivers/xen/swiotlb-xen.c @@ -211,8 +211,8 @@ error: if (repeat--) { /* Min is 2MB */ nslabs = max(1024UL, (nslabs >> 1)); - pr_info("Lowering to %luMB\n", - (nslabs << IO_TLB_SHIFT) >> 20); + bytes = nslabs << IO_TLB_SHIFT; + pr_info("Lowering to %luMB\n", bytes >> 20); goto retry; } pr_err("%s (rc:%d)\n", xen_swiotlb_error(m_ret), rc); From xen-devel-bounces@lists.xenproject.org Tue Sep 07 12:05:24 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 12:05:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180913.327788 (Exim 4.92) (envelope-from ) id 1mNZqt-00053R-Fk; Tue, 07 Sep 2021 12:05:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180913.327788; Tue, 07 Sep 2021 12:05:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNZqt-00053I-CR; Tue, 07 Sep 2021 12:05:23 +0000 Received: by outflank-mailman (input) for mailman id 180913; Tue, 07 Sep 2021 12:05:21 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNZqr-00052s-Lz for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 12:05:21 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 1f79e998-0a83-4c1e-9023-9908260c0db0; Tue, 07 Sep 2021 12:05:20 +0000 (UTC) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05lp2169.outbound.protection.outlook.com [104.47.17.169]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-29-YepnUYaDOWWKxsgoltrgHw-2; Tue, 07 Sep 2021 14:05:18 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR0401MB2607.eurprd04.prod.outlook.com (2603:10a6:800:58::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.17; Tue, 7 Sep 2021 12:05:14 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4500.014; Tue, 7 Sep 2021 12:05:14 +0000 Received: from [10.156.60.236] (37.24.206.209) by AM4PR0902CA0012.eurprd09.prod.outlook.com (2603:10a6:200:9b::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14 via Frontend Transport; Tue, 7 Sep 2021 12:05:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1f79e998-0a83-4c1e-9023-9908260c0db0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1631016319; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Um9DC69BNNgCMREa9h68z95lfy848yTwNtWb0Y+Y3VA=; b=BLW+c6Ug5Z+zwhNlk/YpH1Q5i3ASw5QY84r1mcs4V6bYiJNU3laJcKVtZIcl9oHP82ScLK D6QboYd6vhvPJmcv3SUaHQRdGWS9Re/r+c1fbB2PtjmXLTcpUhBY0Ybj5wAy3vYlms8A4s /nzD33dXTk8000D6soOGjq/zKYoyX1Q= X-MC-Unique: YepnUYaDOWWKxsgoltrgHw-2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kmPC5szowPAPAcKQtrFxAUEPkIW1vldLPfpE1mITFMGlnxYUxjnG45p7jkouAGh+wah6/yS2nWVTiLx1AcU8Y8RiO7EOptLW3e7FAl4HxRQCc8W3qOn2P5VHL6z+yMvC3Fjh96JzeY2r7pTi3UrAM1Imi4IfPI/BhP48+N2rQ+XGf/aof+O4JoGzWaUL6Wr/50ZmSHR51GyxH4Z8NXmiJPdKnRlctIOc51w2stDm1Hbzpin6FtL9YpAIEllPB9hrUTpkaxxwbCD4vpMW2MNTpXh133deEewqx3wCAmNVt6nQwfeHweNYOrDhppT65RN3EoA+7L/l98bkFdAJAr0tlA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=Um9DC69BNNgCMREa9h68z95lfy848yTwNtWb0Y+Y3VA=; b=B8vpRUnG/Yg1Rfe5G/aeQCNwpoFRYh3m/0Ei3R4L/33fYRBEtoZHj6vQGFmiZnmwCUHPXWkgZXNNKYNuRX07zeIdO+kVlaTLa1LwOfcPIseu4wsmPl1LNI1PFxBCCYstSXlUPQwQoRM9MkjwouML6cO4BB2khl1FyyycQyA6aZMXjC5dCd/HsuXfIxEsxcsPd7HrsPBJ1RuPNdE3HumwE7GXzqAVKqK/KNrqlEw5wFu/NowcBdBOCVH0hQZogcaeQsO6v+yQUioD0e92VgI5piJMLqMDdomrIzBXpi50ZMyUrIRP/ylR6STk2P9AE70SofFB5UaoL6bbxISXih0hUA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com; Subject: [PATCH 03/12] swiotlb-xen: maintain slab count properly From: Jan Beulich To: Juergen Gross , Boris Ostrovsky Cc: Stefano Stabellini , lkml , "xen-devel@lists.xenproject.org" References: <588b3e6d-2682-160c-468e-44ca4867a570@suse.com> Message-ID: Date: Tue, 7 Sep 2021 14:05:12 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: <588b3e6d-2682-160c-468e-44ca4867a570@suse.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM4PR0902CA0012.eurprd09.prod.outlook.com (2603:10a6:200:9b::22) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 79499601-472e-4206-729e-08d971f7c017 X-MS-TrafficTypeDiagnostic: VI1PR0401MB2607: X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6790; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: vHNpV0PXcxqG0FHlMMXWRRspYP4aGcfX0qZtXuA4lZfbuknabNCkJ5tPA1iWVKHTuBhzCg1elOcIHInoUVlhvCh8TDG3yER7hDUDYLfh5B3Bu1B2ARpsO0ZDp5fDZwxQU+4bhDslrr2LVX/rvFvDQ8SXNb4HKjUgF0cvP/IQXq/olNTlFv+Hv4KAHlo03RRwTjx9w+ANl2ZhBZceAZWvqSW2p6IhXqW2o2pTFNERMUboGucFuljw0sMuf8oGrYC7QCsXEJ+i1Aa9lK+iUk6remTJ5x8XqxdyiBC2KF/8WaM1msnuAeYrcozBSFlGNcyxYgDsXHTN3lSGJp+KFGeXQ4wN1+xb7NdTpKaeqXP5kgTTnXnoU75Vw6HQz5ttFj5krhauYFnxmxvmscakJOXCX78IadnivoLvlHxZtqw7vNp3SXrx0swFVxKDOAdFHfJNBRDsd2+dTX+zXoZgKNWmioOCa9U5ySGPpAjkNZNRLijTvPPrSEAHc/0THG1lPeYSZzPKYW7aR79A0v66g/F7yXew239RTf3ev4/hDcdu5o3GCPLIWZOCKBhYj0EbhpoC62ycUUpUsyzcNMHSMopE/2x+jLgpD1CULyLbtlkrrkioe6SwU8S7Qqz75rZNmZkYtLZGkd05mzNYpfuipP6js0a+GQtmDgKnyBuTvcdkbv0wZg/z4un2Q3NTc+QPcYlBQsnHsp8xVWB+SA3gEBbNUdRRv5o2X/+jSRl5WXuIJCA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(39860400002)(366004)(346002)(136003)(376002)(396003)(186003)(83380400001)(66476007)(6486002)(31686004)(66946007)(66556008)(26005)(110136005)(54906003)(316002)(16576012)(36756003)(478600001)(2906002)(8936002)(4326008)(86362001)(2616005)(38100700002)(31696002)(956004)(5660300002)(8676002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Y2V5UkdMRkZKNGxzWTNTMUtQazlybXdicE9DaHMxbHlVL0RYbnEzSmMrTnY1?= =?utf-8?B?ZTlpZWNzVmtiRWl0bSs5UlNndmhiVmp6b2czTkJ2alhtbDdPMVRudVFuTGdG?= =?utf-8?B?eHZ0bTJMVkhvTjE1VkFpQ2l4RXErRVJvbDZFUExKb3k5OVBsS0ZpVzYrenZ2?= =?utf-8?B?TkNlWXBWVUtKUjlZdVl6aHZMbldoR1hranYrWUFZNFMzWHFVNTdHY2JTMjln?= =?utf-8?B?RFE0cjlXTTEzZW45R204NWtsU24yaWh5ZGNVRjlIVkwxVms4Z0tCb3J0aCtY?= =?utf-8?B?d3Bad1F3Zk9JMjdRanczUjE5K1RiMTFIdHR1MldDRlBUV0hwZTRaNFVjSk5u?= =?utf-8?B?MjNJaWdGVVp4OFlLRkpmb2ptRm9CQ1VaMjdwaXhsV2lYWjJ1OHFjTXVMZytm?= =?utf-8?B?c1ZTc3lCaWVuSmFFYkUwWklvYldIeXYrSzlzWlQ2TTFSVlFFWGlURHVIQmNs?= =?utf-8?B?NzBCZU1RUVpXL0RLRjBmVSsxdk9zZE1BSUdITW5Fczl6Zkdac1NLZFlnbExB?= =?utf-8?B?WHVib1UxMnZWdnByOFl3SnVFUDlpMTdKS1BrdkIxNkVvaHExaXBtS2s4Qnlv?= =?utf-8?B?K0NpYVlJWGVGUlpNZldnY2c1SDF6VFdVSFcyVU02SWtIbU9MY2VZSnY0VVBt?= =?utf-8?B?VWJJdFcydHgvWXBlY3JDckc3Z0tEUldRQmZYTXZpdTlZSzZsTkowV3NKNmty?= =?utf-8?B?bEhiMjV6VW1XVSs1MW5LNmZKaFpjZ0xhK2RBdElRZXp0NFd0d05Ocm5QQVdk?= =?utf-8?B?UFVSOFZaalJyb3p2ZUhrWXRDbWhkMlR6bm1xcGF5dDZvT2FLYUNDV1Fidm5R?= =?utf-8?B?Z1JPUzdYVldDQ0wyTmt3NVArNDBCeFh6YWtKdklhK3VIU3dyamZ2UXVPdm13?= =?utf-8?B?NUQyNFdTbnZHUGZ6aE5QVHRxUTFoZ0ZrSmRhTlJ1R0pzN1FUM2NpYmNvZisw?= =?utf-8?B?T2w1YkNibXVKTkQ4RFRzbmw4eUFCNlltUm9BVFdiSHk0anlkc1JMS0g4aW5w?= =?utf-8?B?T3BBNlJrWUIzKzRyd1lwL1FyMU1pQ3ozU2RaSnpLMlltLzkzaFd1eUl2cWxU?= =?utf-8?B?OHY2T1J2SWkzTGErVXpnZ3NzSjlqMmhMZU02ak4vVCs1M0VySjNIUG9oV1pi?= =?utf-8?B?RERhUkZPNVB5R0ZJeis3b0krWlZ2NHpKc2h4c1J4M3NycHFuNWUyQU1QdjRV?= =?utf-8?B?SjQxN0RrSzdGWGlGRFZLRnZ4SlE4MHI1Qk1lb1JQb0l4bjF1UGRUQ1ZRcGFz?= =?utf-8?B?V2hEdnYxejFqallTUjdLTlQraHIybk5CMkg0U1pBUE5NSlorRlBuZTh6WnZS?= =?utf-8?B?OTNaS0g3WFFDYmJrRTNjYzgyS2xQbUlQcnU2QXIwcHZzUENzRVlKMjFac0FP?= =?utf-8?B?aWlKVHMzREZadXpka2doUFNOelN0Sm9PTEkxNHo1dUpOSEQzVXg3Uld2NDNY?= =?utf-8?B?MXJsUDN5dkJjVTBQSUlNZGZqeWtFUTZmUlo4THhKbk1pQnAwSGZGRWZXdTdH?= =?utf-8?B?WjFxRHUyKytvQnR3TzR6UzkyQytwSnFheFNmVWZVTldCcjk0YjVDYTQ1RmFI?= =?utf-8?B?bnlXWWZCM1FtTmNzdkx2RWswcjUzeElLalRZby92cStRSDRxMDl2RUxaVzVH?= =?utf-8?B?MGxDRUs0NXd0SGRnQ2UxbDltUi8ycHBCaFdrNG5DcUt6b0JxSkRkSEo0Z2Nr?= =?utf-8?B?Y2lINlRhdkdmb3BKUk1jcm5UL2UwT3UrVTBGVmRialhnbndkRFdWRFNyNDB1?= =?utf-8?Q?+Hjagl0OfzuLIvLEK6P338Gsiqgyig5RUhpYJUT?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 79499601-472e-4206-729e-08d971f7c017 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2021 12:05:14.5097 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: gc8lOrYo7lU2SoL0ccxfi4KFlLO0RxF1duDS9OWQ17m+Aeln5lzfSr5X8ZswULPYs9TvK/ffQPO5cctfDvWSmQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2607 Generic swiotlb code makes sure to keep the slab count a multiple of the number of slabs per segment. Yet even without checking whether any such assumption is made elsewhere, it is easy to see that xen_swiotlb_fixup() might alter unrelated memory when calling xen_create_contiguous_region() for the last segment, when that's not a full one - the function acts on full order-N regions, not individual pages. Align the slab count suitably when halving it for a retry. Add a build time check and a runtime one. Replace the no longer useful local variable "slabs" by an "order" one calculated just once, outside of the loop. Re-use "order" for calculating "dma_bits", and change the type of the latter as well as the one of "i" while touching this anyway. Signed-off-by: Jan Beulich --- a/drivers/xen/swiotlb-xen.c +++ b/drivers/xen/swiotlb-xen.c @@ -106,27 +106,26 @@ static int is_xen_swiotlb_buffer(struct static int xen_swiotlb_fixup(void *buf, unsigned long nslabs) { - int i, rc; - int dma_bits; + int rc; + unsigned int order = get_order(IO_TLB_SEGSIZE << IO_TLB_SHIFT); + unsigned int i, dma_bits = order + PAGE_SHIFT; dma_addr_t dma_handle; phys_addr_t p = virt_to_phys(buf); - dma_bits = get_order(IO_TLB_SEGSIZE << IO_TLB_SHIFT) + PAGE_SHIFT; + BUILD_BUG_ON(IO_TLB_SEGSIZE & (IO_TLB_SEGSIZE - 1)); + BUG_ON(nslabs % IO_TLB_SEGSIZE); i = 0; do { - int slabs = min(nslabs - i, (unsigned long)IO_TLB_SEGSIZE); - do { rc = xen_create_contiguous_region( - p + (i << IO_TLB_SHIFT), - get_order(slabs << IO_TLB_SHIFT), + p + (i << IO_TLB_SHIFT), order, dma_bits, &dma_handle); } while (rc && dma_bits++ < MAX_DMA_BITS); if (rc) return rc; - i += slabs; + i += IO_TLB_SEGSIZE; } while (i < nslabs); return 0; } @@ -210,7 +209,7 @@ retry: error: if (repeat--) { /* Min is 2MB */ - nslabs = max(1024UL, (nslabs >> 1)); + nslabs = max(1024UL, ALIGN(nslabs >> 1, IO_TLB_SEGSIZE)); bytes = nslabs << IO_TLB_SHIFT; pr_info("Lowering to %luMB\n", bytes >> 20); goto retry; @@ -245,7 +244,7 @@ retry: memblock_free(__pa(start), PAGE_ALIGN(bytes)); if (repeat--) { /* Min is 2MB */ - nslabs = max(1024UL, (nslabs >> 1)); + nslabs = max(1024UL, ALIGN(nslabs >> 1, IO_TLB_SEGSIZE)); bytes = nslabs << IO_TLB_SHIFT; pr_info("Lowering to %luMB\n", bytes >> 20); goto retry; From xen-devel-bounces@lists.xenproject.org Tue Sep 07 12:05:38 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 12:05:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180916.327800 (Exim 4.92) (envelope-from ) id 1mNZr8-0005UP-OX; Tue, 07 Sep 2021 12:05:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180916.327800; Tue, 07 Sep 2021 12:05:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNZr8-0005Tw-LE; Tue, 07 Sep 2021 12:05:38 +0000 Received: by outflank-mailman (input) for mailman id 180916; Tue, 07 Sep 2021 12:05:38 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNZr8-0005SV-3f for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 12:05:38 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id e906bd04-0fd3-11ec-b0eb-12813bfff9fa; Tue, 07 Sep 2021 12:05:37 +0000 (UTC) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05lp2172.outbound.protection.outlook.com [104.47.17.172]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-31-Yget3GjuOLGL9PuuNgD8PA-1; Tue, 07 Sep 2021 14:05:35 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR0401MB2607.eurprd04.prod.outlook.com (2603:10a6:800:58::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.17; Tue, 7 Sep 2021 12:05:34 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4500.014; Tue, 7 Sep 2021 12:05:34 +0000 Received: from [10.156.60.236] (37.24.206.209) by FR0P281CA0015.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:15::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.6 via Frontend Transport; Tue, 7 Sep 2021 12:05:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e906bd04-0fd3-11ec-b0eb-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1631016336; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DxJykJMCxYkJPMtlwaWjGcuTROCQKWVJPc/aqT8Eh6U=; b=Qqu5Oz1sA54M2K4Aae9GH0tQHO4H7xzdoYjjHAnCzWtw7/R4rMbAreS8CdJV6ETbUDhXaj l9w+bJ36CWazF/pfbxaFRz2Dk/noc5Z6iu/i7jHd0PAKnZnoYdddAryOmTzBbiFIFauijf Ghy0HL5p5/FiQKQqmvUi1Y81hwb21W8= X-MC-Unique: Yget3GjuOLGL9PuuNgD8PA-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cKFu6bKu5CqvQSsZeH90PTEjoTPDza5A2H7ptd3U9Ujy947lmUS7J7zarX/yebFT2r5weYEr8lIatS5LGhPg2zOjQwTIZQE8y8YaIGX1dZHIaM/J9joZTKEO9i3dNn/5nk+uzdaIKHEad0GzZmATYPIcpmBg+W2D4adXutXdMNq/2yh+YkWo/m9o0xiKBY00pVH27Oa4MoMze2m5zk9BPcqIwXpl8W40PSkqHrN4WxJcq7MvnjGB+Vl1BPJ6kf0uJwFAGoaUc5dxXC5vwYVnYteO7BLsG6Rk9Cf1XajP9ETMFT2jKq1qKZk9CLnVHuc+KYF2WQkqUsnjSr2agYETcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=DxJykJMCxYkJPMtlwaWjGcuTROCQKWVJPc/aqT8Eh6U=; b=CtXfxloLrJf41/XtEmZDN/7JY/k3ELuF3QgwEngr7bj2W61JXzXipKAJSXG+YqhWSeHRnO9yVVaELJUZ2AdRYhve5uT/0U9cr8Tf/tA+fd/N+WrL1JdEHSfoXd4X0S/64YD1J3/sAVKBOIGVTkHhrdWj0jCzTsj4CiYkqIss/c2XxK9pS2fuxCofiQfaxhOvR97+PK7QVUjaNlskqLyhdZ/nLmRRpRSMuhUfpwzmxYO0EUHjjZpp8sLsbKg+Jpx5PZh9LlmIzrOVfnydcmeHHkp7iVhKQfBrWVKsVQSkiJ7dNNgSE1pnSySVFgIHFYjlyEp1mcgYn+VoP9LygBUMxA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com; Subject: [PATCH 04/12] swiotlb-xen: ensure to issue well-formed XENMEM_exchange requests From: Jan Beulich To: Juergen Gross , Boris Ostrovsky Cc: Stefano Stabellini , lkml , "xen-devel@lists.xenproject.org" References: <588b3e6d-2682-160c-468e-44ca4867a570@suse.com> Message-ID: <397bf325-f81e-e104-6142-e8c9c4955475@suse.com> Date: Tue, 7 Sep 2021 14:05:32 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: <588b3e6d-2682-160c-468e-44ca4867a570@suse.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0015.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:15::20) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2721335c-c207-4d39-3699-08d971f7cbd0 X-MS-TrafficTypeDiagnostic: VI1PR0401MB2607: X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:949; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1AXwpce2ZTGO0h99O41c6qeudTOS+SRO5wPXSIxeSQqn5xKaa/HDMhF7EzO7rOdJPRMv2vJE1sNwkZFL8qbuK8uNsuYMLyJdsfF87d0WYUjUjM9miel40AeQk+cbBAerKT0JKnXLIgPdRTsiipsSTcGPJV9lZN7N3Oe14dMHC/XLleob+6brqFCytjBJrW6A9/yycffL6tDeuxCBHAS0XBzDRKSNdePmn/kDCYYMvubYBHb+6AYctCdtlsC/UeIaC2TStMc37mPlDLv0juBwLbPW7OzIrWUNSJxUvzztahnzfzd43TTmAZaWACfgUSULu7MmBia4ca5AkAWk6M1zXvQ5fa8qbyFKpEM34Opcfh6vtboKa+BUHeUC4Irl7HQdCX++AU6rEie4b8aaSsvSGjUxcJq3dWzCmYf1oalVs61CHP6qcglBAghz4pDtdZdOisHlKtrfhUb+kA2TOzgipqZ19ThXMilurWRYOI4pj9lLVqB0CHYMQjtDKpHibxDoNdWc8zMT+LghZIYcqELm6I9OLL6GVH29IEZi1Bj15pMSxpO60L3aWOXB4bJN26W1xhuMBdWzufo6mGvbs7bdhe2SxpMh2Og0pHiVYPiWkxptBa2ZYSzWofFykcKWPuhnktvSf+obPEBLGBG68hKCiyK3Yb51hz2bRTFKIvYsPKX213vg+HAcIkRjP/7ZENrZaP7ydwuEKG7SMwuD+pYImGcDcZsbI+D0BSySFIZ0Ow8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(39860400002)(366004)(346002)(136003)(376002)(396003)(186003)(83380400001)(66476007)(6486002)(31686004)(66946007)(66556008)(26005)(110136005)(54906003)(316002)(16576012)(36756003)(478600001)(2906002)(8936002)(4326008)(86362001)(2616005)(38100700002)(31696002)(956004)(5660300002)(8676002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UWpXVWZkanNhOERzNlNSV2oxdUJ1dEg5cEdmUm1IbTUzSHF0ckJjTkJXdnR6?= =?utf-8?B?MHRjY2FoTTRXK3ZxM1IxTnUyeXIwSTNtWjlFWjA2T3ErRmF0cEsrSW1rWnpC?= =?utf-8?B?R2c3QnVITitqdlppVkZHV1kzM1hIZjlGV2FZWWVkSlBjcWFPNHFIcEZFRExE?= =?utf-8?B?ODBXNlBqMEZDYnM4MFZSSGlndlZiemsxRVozRmFJb2NUeVF0TTAxeVJiNU9z?= =?utf-8?B?YWxYTE1BV2dBek9STGRMYzhOVjNHZFo5TXNFOGhzeHU4aVN0U0ZObzJNNGUv?= =?utf-8?B?T2pBUGpxaVU1WTArV1RUbkhzdFltdUczcXpPRnkyUlJaeWlnV1V3OHVVUnFT?= =?utf-8?B?aEQ5R2VBQmJaRDNTOXd0UnJFZlNIRVJRQWRVVDQrZkpTZFBUWkFodzFWRFFZ?= =?utf-8?B?Z2VrN3NjZUkwTjluRTlkUHUrKzQvWGVUalZTeFV4NjhXZ1pQbHp5SW1mSlZ1?= =?utf-8?B?S3FwSXdsYzlXMTc2MkdDNmh2cHFqVlNoeTNVeDJRcHNIUkwvRjY3bjM1NTBs?= =?utf-8?B?RXFEUmdrd3c5ckxLWUpPRXFLd2Zhc1EyOWoxbWlaQkIwS3lqdU9XR2N0UVNI?= =?utf-8?B?RmRvTUQ1aVp0WGI0alRZdGF5MUZCaS9RSnBIWmhKR3hPZXBLdjRMMFQ0MWlN?= =?utf-8?B?bnE1ODdqdlVUVzZkakJJSlpQQ0JyWGN1THY2eTVLK2d4dHBReTRrZjd6NWNh?= =?utf-8?B?TnVXTW5TRjRDSzVMeWZ4VjNwaHhHWFJjUTV0WWhwa1BkdzVMSTlxSGNMUVdG?= =?utf-8?B?bVU3NnI0NG01ME43ZU5JSFJQcHhNQzdjbHQ3THpHZlFuOE5IMmloR0J0WENx?= =?utf-8?B?YkVsM2dsbExQRVpaRmhPZnJiYkhxUGR6SFdtazg5QUM1SEY2ZWw5dWJNaWVR?= =?utf-8?B?WHY0NFJ6VC9wNFJxdW02SXM1ZmpzMlhkdWhISEtXT2JaSVRGMFB4U0I5WGZM?= =?utf-8?B?Ly9LRFhCMUVsSVhDOVMzMDgzM0FOY0xWSVUxQ2ZMdGE2cU1oZnE2NFNuNHBn?= =?utf-8?B?bHNNQlJRWWVVKzZuYlQ5YWpOSWVEMGRVV1UzZlcrSGFFL3A1K1FiQWVzU1lW?= =?utf-8?B?ekRyRmIyK0Q5MDBTRk1YYU91VnlMb3hmOGRDN1J2M094aHZSTnpUallwQzAz?= =?utf-8?B?bGNqLzZCODdyUTg0WGJwV1c3dmM0V0FIWlBSV092Ri9JRzZtcVJvbDNKbm1R?= =?utf-8?B?WFhmUXUvR1pBSklyVjIrd1VjOHNKN1RJVFhGVFA5cDZDM1N2WVRldm1ZU2JY?= =?utf-8?B?SHlNOEJ5dXpEcW1jM1lCVTlVamR2Sy9HWDNwNFpvM05Nc3FvVnRMc09DVmxp?= =?utf-8?B?S3Myd0tKNjhUL2hNSTRGdjd2UlRlYzk3TjlsOCtHVWJNT24zV3JINzlkem9X?= =?utf-8?B?QWpURm5CQkNBTVYwWm56SmFPN1B4d2hPdlFTWGcvWEZDWFIxcWVwY2xTNE8w?= =?utf-8?B?M3RoQnNJVnljZUI4QlRncWdIVkM1cHpCNjE4TnBFTWNqVGFSc1Y2VWZvUVMw?= =?utf-8?B?Z3F6NHZmT1pscklGRFA3WC9QbU1pVVhUb01EcWsxazkrTVpKRkNPVHMzRkhw?= =?utf-8?B?ODA1UjhGRlp6UXNwM0IrMUZEeWxQZVVwQndLYXpEdkFMcXNaS1ZkY3JZMXgr?= =?utf-8?B?ek9SZkVSUC9WUVdaSHI0WHNsMEF6Q2R6cmY1VlZ1WllqL0NScmhPeUZOUEdJ?= =?utf-8?B?ZHBxZE5Zdk1oOXBaYnM3QWlOSjZZTHpaUk01bEEvYmsxTnFNT2xBbHk2VDJO?= =?utf-8?Q?FfRMgDCFQ8QOyre1IYTAe5LHqbtM0mrGv1R0ZK6?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2721335c-c207-4d39-3699-08d971f7cbd0 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2021 12:05:34.1086 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9EeDANFU13xO+PQ/cQU5CxtYQasUAhqSGaUyX2pGNe+3fdUmKBirWBvRaL+rEloewYWIohN+bVIM7JdbyIpM1Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2607 While the hypervisor hasn't been enforcing this, we would still better avoid issuing requests with GFNs not aligned to the requested order. Signed-off-by: Jan Beulich --- I wonder how useful it is to include the alignment in the panic() message. I further wonder how useful it is to wrap "bytes" in PAGE_ALIGN(), when it is a multiple of a segment's size anyway (or at least was supposed to be, prior to "swiotlb-xen: maintain slab count properly"). --- a/drivers/xen/swiotlb-xen.c +++ b/drivers/xen/swiotlb-xen.c @@ -231,10 +231,10 @@ retry: /* * Get IO TLB memory from any location. */ - start = memblock_alloc(PAGE_ALIGN(bytes), PAGE_SIZE); + start = memblock_alloc(PAGE_ALIGN(bytes), IO_TLB_SEGSIZE << IO_TLB_SHIFT); if (!start) - panic("%s: Failed to allocate %lu bytes align=0x%lx\n", - __func__, PAGE_ALIGN(bytes), PAGE_SIZE); + panic("%s: Failed to allocate %lu bytes align=%#x\n", + __func__, PAGE_ALIGN(bytes), IO_TLB_SEGSIZE << IO_TLB_SHIFT); /* * And replace that memory with pages under 4GB. From xen-devel-bounces@lists.xenproject.org Tue Sep 07 12:06:04 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 12:06:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180921.327810 (Exim 4.92) (envelope-from ) id 1mNZrY-0006C9-27; Tue, 07 Sep 2021 12:06:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180921.327810; Tue, 07 Sep 2021 12:06:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNZrX-0006C0-V9; Tue, 07 Sep 2021 12:06:03 +0000 Received: by outflank-mailman (input) for mailman id 180921; Tue, 07 Sep 2021 12:06:02 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNZrW-0006BD-A7 for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 12:06:02 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id a7f0c699-b15d-4fbb-909d-2d8db2c1a257; Tue, 07 Sep 2021 12:06:01 +0000 (UTC) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01lp2059.outbound.protection.outlook.com [104.47.0.59]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-2-5mGp0lRPMUSPJGnZU8v3Vg-1; Tue, 07 Sep 2021 14:05:59 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR0401MB2335.eurprd04.prod.outlook.com (2603:10a6:800:2e::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19; Tue, 7 Sep 2021 12:05:56 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4500.014; Tue, 7 Sep 2021 12:05:56 +0000 Received: from [10.156.60.236] (37.24.206.209) by AM4P190CA0023.EURP190.PROD.OUTLOOK.COM (2603:10a6:200:56::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Tue, 7 Sep 2021 12:05:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a7f0c699-b15d-4fbb-909d-2d8db2c1a257 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1631016360; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NjKaEaYjLVTnjJRE9LIByPoKIietul+QbtKOuyICMWI=; b=cUwoMCB0JoLefXLknZuXXBQIJi2/XEdAFclZm/Zcllba9pufqDSwOkqt7B6Z6tDzIFr9Wo lY8bLPEjAe8CE6xWUSU8qbz1dTLBNvcB7o7MgOAiwK40kEPiH7dRZ48efHrTxDjmoJBBrt NrUWPAdnctsWyXyBt+auDKifvhMtPbQ= X-MC-Unique: 5mGp0lRPMUSPJGnZU8v3Vg-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bNH5CqiSQp2WP6YKX8CS01lPsyYKYZT7W5c0oUP9S5nU8vKEtvfKQLRsQBoz7OMNWFWiz6mObGWAbr6J26UOBx5OrdEebihoh+kiAhdSz/NhDUK7SZS978VbN3Y1l+azXLJqgivXL2N/WcsiWyWH72DqZvj8AD2Xudo4VcPxQyVTsFTkEfN+zTfrjuZNmU/dfeWarcNsjWkjOzDozapymktu+CyTRKajKP4lXanUY2r4CjxTJV4G7XAFcyrhKBPs5zVr+QTyQVMi9yP6Mc7If81xBOqpk6e5kQ7VHiyZ+d0Q8cs1nyqVM9ia3jxcUwikI3uElc6m8bUOftFU6i4uuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=NjKaEaYjLVTnjJRE9LIByPoKIietul+QbtKOuyICMWI=; b=Nys53cUyRC4XUlRou/gwDBTvIY3i4CX8U2pwSSON9XCInlyMsBEGQj9YeSpo1MKluf09GQxJvzjxvbtcMCR/Zp6Yl+kOV0hHphSkcwySrlozoJvVq4g/gfQhjj5dC2iY1QgoUgM390KQG3oML5vbCHA4ix95aPI+U0+rLdwEDbspS9ZQleRwtKsDnpQ8sIwq9L8gGtKjY4JJddUn6HcOM+tzifnuOe8MoCUCUOeoDKBHKVtcE46N3yaJ0MKO5gUjXoJQcR3FVD4lqFa0PewzidXcmx9SpVq/M7fk/v1kcq+sMHnLds9ppVZHfI85nlj8boDrfGXDOn4SA2moeAMApg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com; Subject: [PATCH 05/12] swiotlb-xen: suppress certain init retries From: Jan Beulich To: Juergen Gross , Boris Ostrovsky Cc: Stefano Stabellini , lkml , "xen-devel@lists.xenproject.org" References: <588b3e6d-2682-160c-468e-44ca4867a570@suse.com> Message-ID: <56477481-87da-4962-9661-5e1b277efde0@suse.com> Date: Tue, 7 Sep 2021 14:05:54 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: <588b3e6d-2682-160c-468e-44ca4867a570@suse.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM4P190CA0023.EURP190.PROD.OUTLOOK.COM (2603:10a6:200:56::33) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f04244bf-cb78-4275-9e76-08d971f7d90e X-MS-TrafficTypeDiagnostic: VI1PR0401MB2335: X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +XXOKh8+bG+9GNKJSyR8gXikRgeL++Ny28srIttNOVOeijUGZBfzPwMh+z0MLJBFgQQ7kgTuADnedHnaBZL5ahrRWrzf3Wp2r1paBEBVQutU9HOHLX6S/e6DBWJWKyrRPM5KFUY7ihst2GiruxreH0bHM9VWvZUM4QT+asbyJtaRUWZHNNSgrP3IYAEQVjVbUBXWUs4QyNLEU9OhF8i7fuUtQYK2ULLbpG95a0oAaow87Q1aeS1BmXDCB7CYwRN/tpT0fxYGN0jN/HiZ0EZqjF3F9k0PPacX7myFAglxZPcq7/mo7r1sdKTj9XgAHnaSoXewSUYkJOsxf7v184X+uJEhg2j5fNYsLxkBqhmMwpYvt5Xu1O07KxQn5imA6LAIFlQlNvcUqdF1HuPeJ3uZuEqP/VwIVi4glJ8kieRBKFxRxFohcLd/BUhkwE84aQ/AFy6gaAVWAniYnVhRAzvMLbbgLZLuNri2iGsf+pLcuLiXWtR3946qFQKidWdrjv/eD5SAyOCe8ihKlpLQR9cf8Mntt3ktVG7aOK+fH+AURt7gb2KNbFiUFGUEobDyDufRv0pUMbgQHa6sVfZtw7ZkjHQrlqLkn74guDwBDxjsJRn98l850b6F1Cghc9y4XmYCMuEmR+1qAMQPIMTJA+m7d/ANDqXy5tv447enrN1fn65Cdx+jZ1iyIPBOE8TXD3Q/ybzo/UbI11Yog7LitPVnhOtvoFcZtxEiNpmGCzPfnzE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(39860400002)(376002)(366004)(136003)(396003)(346002)(2616005)(8676002)(5660300002)(38100700002)(54906003)(110136005)(83380400001)(956004)(66476007)(66556008)(66946007)(4744005)(26005)(316002)(6486002)(31686004)(8936002)(16576012)(36756003)(4326008)(2906002)(478600001)(186003)(86362001)(31696002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RWJRN0wydFlEbjQ2T2tyOGpBTk4wQnBEOEc4dlBtTzIyZ3Vqa0szVDh3ODZz?= =?utf-8?B?ck1rVWpvTklNVXFPbWwrSUkvN29MeFB0WkVvNUg1MnFOc29VY2V2MGdjV1FZ?= =?utf-8?B?ZzJ1cmZ1RnBnR1lSTWNhNitwQ3p6c0hvRlJHTnBlK2JTV0g5VnhOaWxoZXp3?= =?utf-8?B?clNSSVdjQ3NZMS9MSDh1YzlwRFpQQkZpU2ZnT2xIS081cmlzSHllZjNjTUYv?= =?utf-8?B?VkZ0N21CUlBoamRHcDNzS0dtbHkyTTRDSmFjdHJBN29IM0VMMGR3ZE9kV1pE?= =?utf-8?B?bktYVDJneFBxQjNwbkZLR3EzSzNDOFArN2lLUnFoRHFyNXdJWGhKVEhrZzBR?= =?utf-8?B?Mjh2WDZjV05oWGVEWEJrcCtla1dFZ3VHL3htMDduVU5mcy82Wlc0MnNvUmJx?= =?utf-8?B?OS9UVWlOVHQvZy9Uek8xSXZYVUdQaHBTditXdGZjbTdIV3BZTTJJaHg5RVJG?= =?utf-8?B?UjhlOWRnRzlvcTNlOWt4Z2Z3OWdyVkVvNDBURnluWXVmeEhZSGc0NUdRdUhB?= =?utf-8?B?ekhFckxZZDNNeUpzRHo5RUx5NUFhNFN4djV6bmxiTDBXTmJHOXA5V1NDQkZE?= =?utf-8?B?NjVKUmF6QzBvMVZ4QzdITlBTRDg1UHRxcHpGNTl6QWR3bTk3Z29DM09rNTFU?= =?utf-8?B?V2ZhZlhwZG5lNmhDN3JndVFGY2lFelJGbW4rRFlraFlsbFRvdDRnOWVpbTVY?= =?utf-8?B?c1J4MmxzMm5OVzdxcE03K29kcEUvY0FBcGlIRjBZckQyVk92MGNDcDlLWTBL?= =?utf-8?B?Vjk3SWp0UThENExzby9uNVQzcXNhSTgxSnRDQUwrS0swR1Q3NzRpSU4zWk83?= =?utf-8?B?Mlkya1B1R3R1d3ZJdU5wQ0cvV1RHZENYZEhDeXBvc20yN1I0UkQ4bS9UM0Zk?= =?utf-8?B?YzFFZjV3NWNxbXBpVVd0Yi9CNWFhTW5PSU0wd0VLbmdXWEd6aXNzNEtwcGg3?= =?utf-8?B?YXhiRkc2KzZOZmxZeG9rT0J4WGZ1bENwRkd0SWFmTk9NMnJmcGxDRFdrTm5t?= =?utf-8?B?UVJUajZMMW03S3J1Nkw4VmozUmFlbnVRak54cmszc0Ria0NJYUZaS2pSbzNF?= =?utf-8?B?Uy9XeGxZVWlFQWNGNlVRQXJCK1U0cGNRR2JoTWZxU0xIcjZqS3AvUkozUFNu?= =?utf-8?B?ODk0YjZ0NkxrRmtha0hhNk9JeDQwOUpzWU1YcGxyYTZhMGY4TnZXSzBWcHVH?= =?utf-8?B?ejI5NXllUHZzNzZIWG5zSUZJTytRdjdnUHdiUEdmM2paU2JrcG5jcEJoZWlz?= =?utf-8?B?L2dQWjBPVDVJa2NWZHA5L2svY1pYZVdEcitTVEZzTzRHRHlnVGIza0E3bUM3?= =?utf-8?B?cHplZHVSZ2RIbHdzUmVXWm9xSDhwbmhoRjdnKzByL2U2WC94d0lGUWVXR2Zv?= =?utf-8?B?cVp2S3BUT05xUm9kQ08wSTBDTWw0V25VNFdlczN2dlU4OW5uRkJNRFREM0FX?= =?utf-8?B?OW9KaEc0eDgrOS9YNklCQlFOZVg1aDQxdCtMZG95WVMzVGVXYVphcUZZZGFa?= =?utf-8?B?eDZMRnJlb3djMzc5Rlp1RDZqNDVMSjk1UEdlYTQ2SVJsUzEzZHVDWGZzUFZM?= =?utf-8?B?MlFYRXhFcnYwZ1dPR3E5N3JSbGRtNENPL2p4aVZIVjNUTE42NUlPTXJzNU5z?= =?utf-8?B?Q2FLWXl4dHEzbCtBMjV0M2NwT1R3bzR0Zy94S1Rlbm9VMTNoZVR3MjVUbWRt?= =?utf-8?B?NUlvRTNMNDdVanV1RHQ1V01qMlYxcVBIU1BLckFoaHQ5bW5waDBxWWE4YURQ?= =?utf-8?Q?I3Wn8j4IwfjvVvww4WJllM1ljpGL55qNYjwmzUi?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: f04244bf-cb78-4275-9e76-08d971f7d90e X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2021 12:05:56.3159 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: aanrS8Dgx2smsMpI0qTYptKbqhrbXgSx90Dq+sCf5bekkXCEYkwfljdlYZqNb2Whgr2xX0DrgEcWMDg0QGCsiA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2335 Only on the 2nd of the paths leading to xen_swiotlb_init()'s "error" label it is useful to retry the allocation; the first one did already iterate through all possible order values. Signed-off-by: Jan Beulich --- I'm not convinced of the (lack of) indentation of the label, but I made the new one matzch the existing one. --- a/drivers/xen/swiotlb-xen.c +++ b/drivers/xen/swiotlb-xen.c @@ -184,7 +184,7 @@ retry: order--; } if (!start) - goto error; + goto exit; if (order != get_order(bytes)) { pr_warn("Warning: only able to allocate %ld MB for software IO TLB\n", (PAGE_SIZE << order) >> 20); @@ -214,6 +214,7 @@ error: pr_info("Lowering to %luMB\n", bytes >> 20); goto retry; } +exit: pr_err("%s (rc:%d)\n", xen_swiotlb_error(m_ret), rc); return rc; } From xen-devel-bounces@lists.xenproject.org Tue Sep 07 12:06:49 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 12:06:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180934.327821 (Exim 4.92) (envelope-from ) id 1mNZsH-0006xY-Ei; Tue, 07 Sep 2021 12:06:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180934.327821; Tue, 07 Sep 2021 12:06:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNZsH-0006xR-Bm; Tue, 07 Sep 2021 12:06:49 +0000 Received: by outflank-mailman (input) for mailman id 180934; Tue, 07 Sep 2021 12:06:47 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNZsF-0006wJ-Nn for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 12:06:47 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 0f8a6625-0fd4-11ec-b0eb-12813bfff9fa; Tue, 07 Sep 2021 12:06:42 +0000 (UTC) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01lp2059.outbound.protection.outlook.com [104.47.0.59]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-25-Gwi4fgkDP9eCN2J82GTPhw-1; Tue, 07 Sep 2021 14:06:40 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR0401MB2335.eurprd04.prod.outlook.com (2603:10a6:800:2e::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19; Tue, 7 Sep 2021 12:06:39 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4500.014; Tue, 7 Sep 2021 12:06:38 +0000 Received: from [10.156.60.236] (37.24.206.209) by PR1PR01CA0018.eurprd01.prod.exchangelabs.com (2603:10a6:102::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14 via Frontend Transport; Tue, 7 Sep 2021 12:06:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0f8a6625-0fd4-11ec-b0eb-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1631016401; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YMBMI5yUqKk+WNG37WLHu6TzQ77qqIKUpYH+tOuAlHI=; b=LnltSzSpfkqB1ibig/iG80wXL18RO73FeO25lVZsLxex56VSyOmH4QOhOCVtUDNH6ScK+W SQyvcRT21WXI+N4QkR1CfJsqAa9Gfeo/mpZpB93u/WcGvxLrAe1/WVw07zH01AlTGkc7Ma MeCTxdk/dHUFpg6kdaO30u2aQPj2dIY= X-MC-Unique: Gwi4fgkDP9eCN2J82GTPhw-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=R5vf+Dc/6u6YP3qATr/SVEHIz9bTHZ3VENpfiCtFFWXEH8JhbC3SvAzFgo2AsPHCnSqewi4aCG0TsaossKwDSp4vcwkPZiED6I60CRCdCnz8xe2+9fTkd9FGszqFOno38UG7/3kg5Po47bKu0MzzbDJk1nO+HTBbCYybDfPb8xwOdq1jsX+b2MBCgsMHvCDZH+izbK5C0wBzUshPCtqTlbONfFdfFslSVP++oOywbU8wga++rYbtRgHbVeKFNsR6S+tRH+FBsStCjK2glfGyPOUp7tlJd3ncF3jzDn6pvv5M8lKHYukNiMnPUaDZjg67Bb1+HaGB+4hUjNPW8DM0ww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=YMBMI5yUqKk+WNG37WLHu6TzQ77qqIKUpYH+tOuAlHI=; b=Da6k5Ye+k2Vi9VLypqWRuZSkQeyMNC+cSSE39zUAiLRkduFYRJ3Bx5HXYpzuxn6z/Tk7Gnf/UK4K2r9WKArxDnvYrRrqoMfgPGrPsTvDoRcchKHZCaphgXPD0w+fXVBrx/fgw2JQDHbp0MW5OY87SxLN5sFoiroofFTW7R1E0Vm8KrvWpfbyzjmRXGi2smY9IEx1eE3dDobPr75vbuDhKPLLDN3K1ehhTyeytv/IWfTFIcsnu0TKeDRWia52VdW7I5R8beUl4Tyc/+AucGSR3VPHqVio0yMVJEqMEnzSv7HD2CFLKfI+LCi9w5374GCATCSnxc71nuf/1v0RU2ifdA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com; Subject: [PATCH 06/12] swiotlb-xen: limit init retries From: Jan Beulich To: Juergen Gross , Boris Ostrovsky Cc: Stefano Stabellini , lkml , "xen-devel@lists.xenproject.org" References: <588b3e6d-2682-160c-468e-44ca4867a570@suse.com> Message-ID: <984fa426-2b7b-4b77-5ce8-766619575b7f@suse.com> Date: Tue, 7 Sep 2021 14:06:37 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: <588b3e6d-2682-160c-468e-44ca4867a570@suse.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PR1PR01CA0018.eurprd01.prod.exchangelabs.com (2603:10a6:102::31) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e87e0e46-93b6-442d-684d-08d971f7f265 X-MS-TrafficTypeDiagnostic: VI1PR0401MB2335: X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6p+jxvZNvlchQnDd2qOjDZwFxL66V8vytE1+ZIOz6IgenMe4qgcjUe2VdKNwxqWWpLmxNEO5itjH8OxfIp8DFLXER0IjypKgRhABvRwDn8jh42qUTzm1R+jdDvtBezSvx07I8YMpvzR3kXvZ5VLOu0QfEGNa21xb9gd8Y6brn7Kz1P5EKPdnj2xtXXvF35oHvaWdQV1iy2G94lY8JfW+PIGvRddoJqYS8LHMu+W50VF+IGO+CFdt4bkua/aDTBtnCYoiVrptQR6f8nBqnEP/xgL4ZyXPe2gQ6YaGvb+jhb5ha5eSH+3M9ctVX2ppJ+9twQGNwtEwSPFpWkl/1PDLmcT+ndTFg9Rp4osmZXpd0pF3SQbdp83JFPNST9s8Ik4Tr6xh+YktesFbg6qZNqrec9yBPDqT8PqTByhVzvko9xDAAEhzGtoW+uItXp1fiI6QKxMAaTC9x8C1WhA2DvRew+fNCR04p845+JOSXgpZDB+NmM4aBaKMuHH5lf1vLCkQom3BVDZNn/A3CoXiRLxIjEOQD1ctXk35BEBu2PeIpUxKp5fGXvJe2iw+zLl9DI360OHCsOI8EuubFxDe5bESM9RLe+1EC6xYEgROXhIW64IIcm0VxcfcoJq05iFOt7JSRAyS0GVoWxz+zyaAYe3M/wVcfkmhi6bMYMhxHOofggi0Ej/aKfwNi8cl1eunZJWXFAW4JXx/YSAd+7sxKdz6Kw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(39860400002)(376002)(366004)(136003)(396003)(346002)(2616005)(8676002)(5660300002)(38100700002)(54906003)(110136005)(83380400001)(956004)(66476007)(66556008)(66946007)(4744005)(26005)(316002)(6486002)(31686004)(8936002)(16576012)(36756003)(4326008)(2906002)(478600001)(186003)(86362001)(31696002)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SVR3TXNZeUpyTWZVWGIzdUhYM1E2aUNtTUFSeHdLVy9WMEd5REdBcVM0bkRp?= =?utf-8?B?dW4wc2crNU1xTUFhOVIvcHgwdnJwMWVJSk1sTUJFTW5mY2NMUmZlUWxrYWh2?= =?utf-8?B?SHZtZzFqQndVcjRVWFlLOWY2MGtMUHRFTG05cGF5QTNlekR4U1drT3JycUtL?= =?utf-8?B?WW5ZMXEzekkrK09PNkRaWUZrdTFEb2NVaXR4emhlanV5TFBGYTUzWStuUnFv?= =?utf-8?B?RzgycExKUmgyZ01pZ1N1dW41VDlEQkN6UFlncUFXR3R5U1lkbEw1TThMRmc5?= =?utf-8?B?cGZRMEE3YzdjOGRyQ1VoMWxTQXR1VGtKckJra2dEKzdRNDNtOFJnTUJHTnZv?= =?utf-8?B?M0hBTldBRmdkNUVmbmNGRFZDZlpQQWoyOXR2SldLLytTVmd1WmVBYTRLYTdq?= =?utf-8?B?ZTdkYzhwOWQyOFQraEptdlpVcUNON1cwNFBYcDBXNXR2dGc4V3d5ckwrUDNE?= =?utf-8?B?cksyY040TFAyMnB0cm9BSllvVjl2bFNTVlg2cmx5bUxDUUwrYzAwQ1V6M0xq?= =?utf-8?B?cUVGdXdGS095d2hMUWtCazZJZGJIdWl6V1A1dHc3czBZTkpDb2p2MEVLdHhU?= =?utf-8?B?dndxcndZN1dKTjlnc2k0Vm1vOGFObzBld3BXR3phUDFzMFZzMk1lV1VaRllV?= =?utf-8?B?MmE2L2k5YitjRUNVSnFGc1paRTkwdVZERVQ5a200bzc0dmR4R2pTT3VBTkFn?= =?utf-8?B?K094MStTWjc0TGNUNS8rek5JL3JPdnAvSk1xaHhidHYyNjdQWW9LZ3M5dFRp?= =?utf-8?B?NDU1c3Jzb04zVk9Ud3ZneFZFUWpvdzRvZng3dE9tWVdXd0E3UENRVkFPVmdp?= =?utf-8?B?S0Jqam9zWnYxRUY1Y0hpU2p1THBOTmNKRWc0eHB1Z29NeFVKOWNsY2dieXl5?= =?utf-8?B?cDk0UVF4em9sZks2VGFZZ3pnZDE4bmVHM1o5VDY1b1FEdzMwUkI4VXp1TUhL?= =?utf-8?B?ejJOOUJ6QW9DNUYwSDF3VTNHNnBIcm1wbXlCbXQyQktqRkltZ3I2U0sxTHJT?= =?utf-8?B?aDZkTHVsVFpnMGl3eDhQTFhIS0ZqOHpuZm1TY0xuZDRxdEwxOCs4ZlN0Tkx5?= =?utf-8?B?NjBrSUtzc1h5eWQwSkpXbE5GZHZtekhhajNzWjhWeGFVSGN5emY0Z0tBMlNE?= =?utf-8?B?ZnNOSFVvS3hUdm1wZC9GOWV0MlFVU3dQcThWZ1YwTzVWOEdMWGRqS1BBQVRF?= =?utf-8?B?QzBYRUsxSzZpbERPQkZHdFptSjRWTFlsQ2JDRzdWNkZqZ2UvVllnZEtxbUY2?= =?utf-8?B?UTR1ZGs1RnlwL0FPeUJjeXA4L2ZMN0hoeTc4VFFjcDZ2clIvRHgvUHd1WmdS?= =?utf-8?B?Q1pIMStKRldZRFk0NHM0VHhta2R1R3hrNG1NUHlJbjhYRm9HaGFGczV3OE1T?= =?utf-8?B?UmhLQW1RN2wxeTdFV0VSZmJVNytBZFVTZjlNeVlSYktQWXNvbkFsVENtNzl4?= =?utf-8?B?cXB5NnVaRmJ0aU9lQlJtRUdoQlRYcTlualQ0YmpFVi9KSHhteU10Z040TVo4?= =?utf-8?B?d21PT3duWmp0cUtRUzZvQk95RG1jYmZ3VzZqcUExSjJzNjV4dFY4Qk94K0tt?= =?utf-8?B?T2FoQUQ5c3JjVTh1SWkrcWR2MWdjcFd6NUU5VUdWRW1xZWhjT1N2VFJWWGVN?= =?utf-8?B?MUJlVUxYaURCbUZJajV6SW5tTStLVE1BQ051aDBlSS96Yy9WeXVNN1BBZktq?= =?utf-8?B?Vm1zMEhJbnZqbVd3dCtxZjgyMlkxM2RQTmo1NmtucWJXSzYwUU9iNmQxOFd2?= =?utf-8?Q?ADFcBANdJhD8VY3lNsPOeRWZU7k3yVq0sCVDFF6?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: e87e0e46-93b6-442d-684d-08d971f7f265 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2021 12:06:38.8548 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Ph2AurSgsXAZiupuP2pvXbNulkvCbwBmtN+9q0Zh1ffPH8Wymh+4lbKcDL4jZkQDrkFawmyk3YKAt4Eu+kBM1g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2335 Due to the use of max(1024, ...) there's no point retrying (and issuing bogus log messages) when the number of slabs is already no larger than this minimum value. Signed-off-by: Jan Beulich --- a/drivers/xen/swiotlb-xen.c +++ b/drivers/xen/swiotlb-xen.c @@ -207,7 +207,7 @@ retry: swiotlb_set_max_segment(PAGE_SIZE); return 0; error: - if (repeat--) { + if (nslabs > 1024 && repeat--) { /* Min is 2MB */ nslabs = max(1024UL, ALIGN(nslabs >> 1, IO_TLB_SEGSIZE)); bytes = nslabs << IO_TLB_SHIFT; @@ -243,7 +243,7 @@ retry: rc = xen_swiotlb_fixup(start, nslabs); if (rc) { memblock_free(__pa(start), PAGE_ALIGN(bytes)); - if (repeat--) { + if (nslabs > 1024 && repeat--) { /* Min is 2MB */ nslabs = max(1024UL, ALIGN(nslabs >> 1, IO_TLB_SEGSIZE)); bytes = nslabs << IO_TLB_SHIFT; From xen-devel-bounces@lists.xenproject.org Tue Sep 07 12:07:03 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 12:07:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180935.327833 (Exim 4.92) (envelope-from ) id 1mNZsV-0007MU-OB; Tue, 07 Sep 2021 12:07:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180935.327833; Tue, 07 Sep 2021 12:07:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNZsV-0007MN-Km; Tue, 07 Sep 2021 12:07:03 +0000 Received: by outflank-mailman (input) for mailman id 180935; Tue, 07 Sep 2021 12:07:01 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNZsT-0007LE-GV for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 12:07:01 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id c7167cc5-da60-41dd-964f-0f0b7ed46926; Tue, 07 Sep 2021 12:07:00 +0000 (UTC) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01lp2058.outbound.protection.outlook.com [104.47.0.58]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-6-sqoC9y0uOUmyMVzmjdz1SQ-2; Tue, 07 Sep 2021 14:06:59 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR0401MB2335.eurprd04.prod.outlook.com (2603:10a6:800:2e::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19; Tue, 7 Sep 2021 12:06:56 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4500.014; Tue, 7 Sep 2021 12:06:56 +0000 Received: from [10.156.60.236] (37.24.206.209) by PR0P264CA0063.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:1d::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Tue, 7 Sep 2021 12:06:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c7167cc5-da60-41dd-964f-0f0b7ed46926 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1631016419; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yfSrUDJsXrUgIa8eiGS6wO+C14mV3RvK021zMRjhrHg=; b=Zq8NCV1PhIRAR6RayonpC9+VvN4XjM8PkzIxG6ZLTq09Ggxv3aIn0GWpSISijyvN1/tV3l HmgsHSV/TaB8cXjkuQa49gI27c4OMmcMcp4XDy6wIa2EzsR1mQ6HOIfNsqpZmdRCqVWA6C v8w5wXZUFHxMnb2eLFFE8ubNwGIZBS0= X-MC-Unique: sqoC9y0uOUmyMVzmjdz1SQ-2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jWmrHmi+ZMHC3LYMtzJur7+Dw2pd9sVEpZFYIwzl1En8ZFIaMuvsyXDu46b6O63Xri3ktnl3NG4vEpo2X1NCj+edcilG4n7L8fqrFK3Lg5sPwvvpcEMleoMqsRQXf7gTN8ZR++aOFpoLKWzvFe9WvldIB01WEOVOJOdTLjOGdylsdinh2m88P3Tl9a/wlaN2YtVK2NODSaULwDrGCIaYxaio5NoXg2GOBP+MiTWza1oKNGCbWILjuodfrE0lZsuuVPuT52OOpILXMXlCIKvXLYjOe/8WHc1ruEmLs/SzzlU7GgGNdiOv5UQHlxhqVzNDXXf5vRl9yoShbaCeJwWAkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=yfSrUDJsXrUgIa8eiGS6wO+C14mV3RvK021zMRjhrHg=; b=csNV5nHeNahFGwpU/LYDwy+AT9eP940y29k4YQXmrHVGKLzZG69WDnDPOUtKSLNFRJ45kWRZrH0F0tKhvqFWP9Gsrp4ICQq+I4bxESlQjOfXueGoE5RwmJYVqec3j7dn/11Dj0zuVRnhY4QFIkKGzmwn0A9lGuHrZ7XIwIeQROa9Bou8FpTAsbUaV6ofOsK7OJmI7XiCvHYaqMoQjaS1nHXO57rVItI0QfbN60php0A5+IxAU4M5U93Q6uQmwG8a5AVDmocy4GggdRzdWAF1JbOttbCBfe5hGS26QOEhdyL0HlDQHCwTaYetM3+wE5KmZB7f0hfHMq98EbjQmgqGpw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com; Subject: [PATCH 07/12] swiotlb-xen: drop leftover __ref From: Jan Beulich To: Juergen Gross , Boris Ostrovsky Cc: Stefano Stabellini , lkml , "xen-devel@lists.xenproject.org" References: <588b3e6d-2682-160c-468e-44ca4867a570@suse.com> Message-ID: <7cd163e1-fe13-270b-384c-2708e8273d34@suse.com> Date: Tue, 7 Sep 2021 14:06:55 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: <588b3e6d-2682-160c-468e-44ca4867a570@suse.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PR0P264CA0063.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:1d::27) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6d92d3fb-5473-4882-8cd6-08d971f7fd10 X-MS-TrafficTypeDiagnostic: VI1PR0401MB2335: X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2887; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: X+TnSCKrSsUpHDy62Y4a7n1mHtJ9sHiN2ncLWbETlk/iczTyLciNrb5Q889LTvUlcTFTCatHa/e1EqPzGeQDQpSD+Y1AKhG6Hm24253horOclA2vhn884oXNKEvO9qcIIl8MPmtoatQAbIBjnu9cJRRtb0/ej/lKc5QCx+RcL6RZOQ7+ftwD762dJdvnoSSOeijFyC4Kk6njhHLs+2De3ZLT1GzhybjWv9hupmX9FDFWnRRm7x3D54pT57k3nQt9MqwL2td8mMaX8WPZ8Dpgc1XX2K8BaXZtRu0aMHtBzu8bxWFxTMZUPKCxTZUpqznBthXzUJQ36AdPzD21Jp0CSFz6S+ppSSinkIpVQkWttj+vYttUyddhDV23uNXZws1qy5f6FeLi8cuIrDaxOQwoUFgs4b+X2DYo05kJem9wJeERmpwUMo+GDleGFRqFDXVCbXDug2mEqhBXxifoahtCFOI286Ufw6W7W0+5zytY4VE0bRuHgrAz8LkVRydX3GYHdDIaCxURPWCuHzzbglGi1C5KDTxAXt+qd3q2Qdyp/3wcPAPQOFtloxJJnpeERFIcSVwbxX4oqVJnbddgS61tY+iUGPZZkgupsx4wQ00xAa4Od43WB168COO+sKbqmoa+Gglbu7X0GE2BBtbihFP17xWyzSH5cQFcpVdmVBehNxbioptTeRvXZggT+enSjf2d+31gIvnt7Mi1uN+fqZO0uDIs6NavEMlbVuKnX9ygZ+Y= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(39860400002)(376002)(366004)(136003)(396003)(346002)(2616005)(8676002)(5660300002)(38100700002)(54906003)(110136005)(956004)(66476007)(66556008)(66946007)(4744005)(26005)(316002)(6486002)(31686004)(8936002)(16576012)(36756003)(4326008)(2906002)(478600001)(186003)(86362001)(31696002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Z1c2S2NncjAxVDlZdG9IcmphQXFJNUFlcmlBOW9MT0hCNUJ5YlhVOEJwTkc0?= =?utf-8?B?OTVXc1JUQ083RU5Dc1JTSEd1Z1Y2eG9sZVdEQ0VGTTkzajRlbFgrSXJOM0pt?= =?utf-8?B?dW13Nm4vWHp3R3NLZUl4L0taRTExSE51bXN6NWxQLzljV2d4Q2E3NWUwWVJY?= =?utf-8?B?aHFFQkVMNitXSzdXRWUvRE9RdSthSHNvSURNNXNmUjVDamM2aExKMTVSMUF0?= =?utf-8?B?WXVvUVFwd01pc3Fxa0ZYN3E4MG5ldUh5bFdMM2JqYmNSNmVZUVFRamNoaGJK?= =?utf-8?B?VVA1RXFNa0FlRmcySmVQeWg5YVlpQ2o3dFJRcENoUStsaVhCMXdaR2F0SW0z?= =?utf-8?B?b3FaK2Y3SWxGeGUwMk1zTkl1czNOcGFJZEN3YzNGclVTY0h2eHVONGVOQlE2?= =?utf-8?B?VTBWa0lRSjNKRFF0K3RNUnY5TytRMFFDYXF0c0JTTVd5UmZmK3JRL1IrQ1pZ?= =?utf-8?B?NkJMdVJVcFE0akFBaDNjcWFIazI5eXVEMDlEWnJwMU9kQisyMzNQdlZudGpC?= =?utf-8?B?OTlGZkdlWnRIRDRpdk5ZQlJMSUJid2VSNlhTd2M2RGJzVisvNWRDMUlrTlNR?= =?utf-8?B?ZTBYakxpNHdGUFR0cTB3QTVpMzFxRGF2NWJSK0pSb09aKzdKZG1ZakNjQXF3?= =?utf-8?B?SEFWV3BwTGdwd0Rjd3RsNzlsUFRHdlNSbjE1WUFRMFNpUzBhMXczY3V3aWo0?= =?utf-8?B?bk1KTUl4TGhPVGZ0b3MvTEF5Y1dDbHdYNFFraW9yeDRTMHVEZG96TWFUcnpH?= =?utf-8?B?OGpBTVFRb3VjWWQwQ2lyN2I0a1d3WnJFVGtqSnFRd1B6N0xVY1MzVDdrblVw?= =?utf-8?B?SWoyOS9VcG1kWUk0bHpvcmc3bDkrYTZxWis2bzcwZGU4dk9yQk0zbmFVQ256?= =?utf-8?B?Mnc1bmdZZkNJZzZuRVpvT3hWUnFUTkh1KzlxbGk5YXUreHlERDFWdVJpRUtX?= =?utf-8?B?VitiVlRCOXRuMkV1SU56ZTB2RnFkYnZHK0k4NUJCRkxmZHE3dkEvclVkcHpG?= =?utf-8?B?a1hqK1QrN0hiOGxXTjdqUU1TbUJmNzBwUjQwS3ErL2htLzd4ZnRZbmMxbkVV?= =?utf-8?B?SzZjR1NDb1Z5Uy9ZTm5PQzZDTmJXWmVtM0tvR3lFQWdFMDhXNEt2akl2ZmhO?= =?utf-8?B?RWVoNGFKY0lnMUdHN1VGUFBsV2FndUFTbzNINjk3NUdueStkVEdVUCtzdFhO?= =?utf-8?B?c2VPQ2xsbGFzV01xdURxM2lXaWVDVXNndWJlYWNaejdVR2N5RDRQYnVROGRJ?= =?utf-8?B?bXNGcUIrSU1ZbUxWazRWNkRlazFDbkduL2kyUmVYVGpGS1gxaXZpNlRqVEFy?= =?utf-8?B?SXZMS2tseHlDVnIxa0t0Z0R3ZWpUa21hZlJJVkIzekp4QnpYN1NVc09oWnk4?= =?utf-8?B?endjNlQ1RUNibWxIOEQxRXRoazhTSFh0QitSMGdnZlFmaXhudUNWZXlka1dT?= =?utf-8?B?ZlBVbUpEcmxsNzJ2eVA3T0YyNERpdUZtdnlzNEJKSURSYUFMNFU5SkNlSC9i?= =?utf-8?B?S1hhTW1OZER2QjlnemEyQkQ3NkN3MlltOHY1UnM1WmV3Z0Z2U3E3aEZXbjEy?= =?utf-8?B?ZG1ZZWJWR0gyek5wenM5V3h5YnQreUM3RmhnZ3hLY2hJZTVKZWwvK3hESWxG?= =?utf-8?B?dWVLR1BPc2RtQ21LMWFrSWRvMGl4WGlMWHJueTFWcDdWOXFWdmxqMkJ0Vitu?= =?utf-8?B?RzY4aE1vTGRmTG1zSXM1RXR4UGhqVHhBajNVaCtvRDFBdmcxejhWbkc2MXpU?= =?utf-8?Q?6zpueodSA9C4Hs9FhhGM1mnSgXSbmwbylLEBmaH?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6d92d3fb-5473-4882-8cd6-08d971f7fd10 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2021 12:06:56.7266 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: v3JjegjrSVa7Eyffa0vq6FD1jmgD626Xg9ETA8SXF6JHGDsF+T5u/SkYZ9MAPiV1vclz+c5K8UFXntF15X7vlg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2335 Commit a98f565462f0 ("xen-swiotlb: split xen_swiotlb_init") should not only have added __init to the split off function, but also should have dropped __ref from the one left. Signed-off-by: Jan Beulich --- a/drivers/xen/swiotlb-xen.c +++ b/drivers/xen/swiotlb-xen.c @@ -154,7 +154,7 @@ static const char *xen_swiotlb_error(enu #define DEFAULT_NSLABS ALIGN(SZ_64M >> IO_TLB_SHIFT, IO_TLB_SEGSIZE) -int __ref xen_swiotlb_init(void) +int xen_swiotlb_init(void) { enum xen_swiotlb_err m_ret = XEN_SWIOTLB_UNKNOWN; unsigned long bytes = swiotlb_size_or_default(); From xen-devel-bounces@lists.xenproject.org Tue Sep 07 12:07:31 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 12:07:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180946.327844 (Exim 4.92) (envelope-from ) id 1mNZsx-00088p-0s; Tue, 07 Sep 2021 12:07:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180946.327844; Tue, 07 Sep 2021 12:07:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNZsw-00088i-U3; Tue, 07 Sep 2021 12:07:30 +0000 Received: by outflank-mailman (input) for mailman id 180946; Tue, 07 Sep 2021 12:07:30 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNZsw-00086X-9p for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 12:07:30 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 2a423eb0-0fd4-11ec-b0eb-12813bfff9fa; Tue, 07 Sep 2021 12:07:26 +0000 (UTC) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01lp2054.outbound.protection.outlook.com [104.47.0.54]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-10-wO4pVYOwOfOPYqiRTM-_GQ-1; Tue, 07 Sep 2021 14:07:24 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR0401MB2335.eurprd04.prod.outlook.com (2603:10a6:800:2e::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19; Tue, 7 Sep 2021 12:07:23 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4500.014; Tue, 7 Sep 2021 12:07:23 +0000 Received: from [10.156.60.236] (37.24.206.209) by PR2PR09CA0010.eurprd09.prod.outlook.com (2603:10a6:101:16::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Tue, 7 Sep 2021 12:07:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2a423eb0-0fd4-11ec-b0eb-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1631016445; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=n7mzpWDSKQyeB1Y7K6PB6/ey7zolLxcOfxP5VRC4xpg=; b=SErut9zMOtkNGyzk/89jVwytfHcYzg+NPNOFJpwQ/WeP7lygv3MgD1ZTMW/C1KHGrllcPA k5baRR3ABtSG6pY6EBke79DMgymDIRXYPJnQUYCXlxyYK3JXOxuV9DYpzmaDhDV/Ayzfr3 oIMGYDbPPqwMmWYC0dhhMeBtjakQw5o= X-MC-Unique: wO4pVYOwOfOPYqiRTM-_GQ-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aTIxY8KEDICOriuKX5SuLtaLX8doPexdNM9CYmFxBEanU/cMmnEH74KVzYL39rSFD4cTK9jSwCf4ro+4qMbDkqqBLCOfMNGCux8PMyFvz+3NkZ/exWTw03IZyKMARPSGHmzocZ+YFv8HHvBAAwuxxZbO8mABTODP4EP5WWfk48N/foFbOGqUk0zrhDI3RhKPTgkV79ysNrU+2aYboDr/x9c27H5xTUK3hSOjV8HqIkjw6D2V2cLVL434+YGsBjElA/0ihK3DbZ4gBWofHjC4WAuufdkWFesQopamHg5dOqP/cJsKm6SJZVllpT/O+4hcO70T9szY3ZnX1siBGXbzUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=n7mzpWDSKQyeB1Y7K6PB6/ey7zolLxcOfxP5VRC4xpg=; b=bncueqn56HBLtcSH4vHgtaTxs9jKY+re9pppPYPvwbY4YDfvfW6CztYMvYRehgdwJm+YeuRjF0/y9b/kURFHgknYzLDHx1eYCTWmkrd9srrvXilKQIQI0hMH2Z0Yy1ANZo51f77VNnCNZS2p9CDgbP2m0ImH07hJFBtgxUnyOnpK6r3PhuXXV/WgCLAm5ettm1nm1vudbQ+GDSrBPOYlxALXuDiAYgxlcCNH3Q0cllH6xTyFwlCR66dG1heQVXIuOAt63n22daKJhdmYCaxZY3srkXpYSvqdCeym07RAkvGUMU77E6gjpmoiAUoIE5IFKdw7yYSRtAXn5hFNysynwA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com; Subject: [PATCH 08/12] swiotlb-xen: arrange to have buffer info logged From: Jan Beulich To: Juergen Gross , Boris Ostrovsky Cc: Stefano Stabellini , lkml , "xen-devel@lists.xenproject.org" References: <588b3e6d-2682-160c-468e-44ca4867a570@suse.com> Message-ID: <2e3c8e68-36b2-4ae9-b829-bf7f75d39d47@suse.com> Date: Tue, 7 Sep 2021 14:07:21 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: <588b3e6d-2682-160c-468e-44ca4867a570@suse.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PR2PR09CA0010.eurprd09.prod.outlook.com (2603:10a6:101:16::22) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: aafa5b43-f735-4db3-d08a-08d971f80cd2 X-MS-TrafficTypeDiagnostic: VI1PR0401MB2335: X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4502; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ALtpvWS75rPd7bTQjpiRwarOVxM9LjLzQJ6rf1JxZt1AVwxcvXpcn45dkxiQKB5ZUE+Dfd4K/QpZyDhhp7N+7Zt703ARx9ZdTLUl0hnpDQTsfpdZ8G97B5IP4PAkoN9Zazpzlxligg9aiCWyR4dJmmyvWppWuubxIxPnBHwiACKW+RGTiDLgTr2KBybIb7slboF4jAW+p9+usuzzYMw2fXMnu/835pKx69fVXcNpLFPpFoKrttRnK7WwGgB2G8fSPBZ7oErBw37nJpIiIk8xVCCDlIdPVHbzeiaSJACMLlBlzvM2yobefjCmEnXr+JaYzcAs4PqT5YIbSUGxa/d8LkTMbFNOZ7yhEACe+8oSkfSo0hfDJirqV7Cp4HoZ+xGPkg5rIjaVWJlNripn3uqwSak6XQVF5/MqlFl+nXwE6lXwpmdPPuQOI2FDKPnOYgyhji1HM8NSX+veqqZnFfPBSyZhKk1MEyGZ8dqzk+hJmyhW7MX6KmRSTs/2pRbbrgoJb8AYA9Bs5OjBo8RF1YovTwjE/hXZZb6f3FCwn7pPfa3dgfW8+me43jsnV27UdJCXt1hwCxVyLYIrxd0doxV1bL2eYL3JW/fmJL8knD6+JeSSk5wvmN8Bu+V49zfnznuSnmVTG75b1u/Hj9Gz21QFNvvt5xIUI38olM787kdrmOWXQKp+TyHZZDRHDxtQgbyYbygJHhIBvtPKzgiP6kEaax7UrrxC66jl5eJv1OJfcA0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(39860400002)(376002)(366004)(136003)(396003)(346002)(2616005)(8676002)(5660300002)(38100700002)(54906003)(110136005)(956004)(66476007)(66556008)(66946007)(4744005)(26005)(316002)(6486002)(31686004)(8936002)(16576012)(36756003)(4326008)(2906002)(478600001)(186003)(86362001)(31696002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M3FoUjNGR1NialF6c2owUENPTlFMM3B1d1psYkV6dmlpUU8xK1ZMc1ZJMGZw?= =?utf-8?B?dlZLMHZyWnp2bkpYeFp4STNsV0RPSnpqMFg2WE55MW5wZFZNZ3AyLzdlenpt?= =?utf-8?B?NHFvdFRkMnE2QnYzVkdEMGRhTGVwZWZqZk5MbTc5QVlHZEN5YlFYMnRwTWhs?= =?utf-8?B?Q3hDWXRZQk1MV2hCdmh6Qkw3TTlOMkZaQU93cDRCTzZBWVBFK0JFZm5NVGJL?= =?utf-8?B?ODVMMmF1Tk5DcnpUWHFRa284TzRNaFdiRG1TSEF5dDFWMmdaSVgyaXh6UER3?= =?utf-8?B?WVh2Yk9KbC91VXAyZzNDdFR1MjgrQUZTVGtxdWZsKzJncVdES3c4bkdONE54?= =?utf-8?B?Q0E0by84VWE5SkdhZkg4aG9scmFhc1NnSW9najRGbzlzaWtCdWkzY0toTkNR?= =?utf-8?B?eFRXNGhoMlJpL3hPekRRNCtWM3FoZnpWZklpa2ZLZVVBMUhqZ1V0NGxWd0Ny?= =?utf-8?B?a21OTVRaUEJvZHJFVUNRU0k5WGhFdU5MaDYrSEZzbTM0d1pvSGJSajFGcEVJ?= =?utf-8?B?SWJUWi9RVFBVSlFpNVQ5WlJMamkvQWNBUXRIQUFDUkRVZ1Q3ekZBYjBiakJa?= =?utf-8?B?ckdzRnI2ZXNDbi9td05OWEtZZlpvUDE0YVA5Vkc0bU1zdnlNNTBESDFBcWpi?= =?utf-8?B?eHE3a041Mnd3TXRZNTdyOTVKUTlCQndBRUtLWmpFZkhCU1haWFpwSUhFTkRC?= =?utf-8?B?L3YvMzU4eER2STc5alk5SmR3bTk3aUp0OWpSNTV2eW5hNlROL3dRbmZtczBU?= =?utf-8?B?ZFNkeUswL3JjOU9DSWY4REtDbHA3MCtOMzMrOFpyQVdkcnUrcnByTk5YcGNJ?= =?utf-8?B?bjlzVVcyUGx6UmxUWnFRQ3FVczByRUk3TEt4aHN2aUZlUFVuRXZFNzJhYmh0?= =?utf-8?B?amR4bGp3UTNVb2pNcW9LVWVOSSs2ejBYL09Rek5XRGtJT1NQR25YOXJuMmc3?= =?utf-8?B?MVhSMzVGSUF3SXJrNktuSWVwVUlFRzhCTGF3U3FOZERCTThuVVEvSWxsOTlk?= =?utf-8?B?NlpFYWtjTDdITVN3ZmJrNFk1bzcyOGt6MVRuREFraklYSGQxc1RvTXlZOTJm?= =?utf-8?B?UmNhK2JOTTlyTUFJRzk3aEFNaURITDNtd1VxMURSY0xaWm1JMXNCS3BLODQx?= =?utf-8?B?ck12N1NCcWwvSy9lWllBYzM1YjBjQWQyQVlLSTd2b1J4UFdzN1IrQUlvcnRU?= =?utf-8?B?SlFDdUFnVkR0azNQK2svTFZzZlJkR2xGMUp0RDl2MW9ick03cVpzeXVmS09D?= =?utf-8?B?ZGpFdUdDaC9rcEU5amVaK0VyalhGVDFrWFBmOUE2VVhzWWY5Tng5RTFGaWpl?= =?utf-8?B?d1ZueVl6eU9lZlZ0ZzhXcFQvRXpnbWdQNHJ6V0ZnUjVpZ3BCM0pPK2k5ZDNQ?= =?utf-8?B?Mk5Hdnd2cWhFL3JhMGs0S1QwMFRJSFBYZjUveUFMdzVJZy8yUEs5TElxRmU4?= =?utf-8?B?T1orZ09GZFgwRzZpWjgxYXJqeUR3TG1BYmVHRWZiMVc3cjkrdHI5dDVWc3Zq?= =?utf-8?B?eWFLV01aV1ZQWlIyTmp0L3VidjhYWC8yb0hlOTNHMWVvSGE5a2o3cEYreXRy?= =?utf-8?B?RUZjRnBTSEsyejdBS0phNW5Cc2IweDMxOUxtbjNtMFNoeTc2eXljVjYyTnhy?= =?utf-8?B?aWIzN1I4TXkxQ1FtNy9MMGRScXpIenJXRVRwdGp6Ymp2bUh4R2hWcDJOYmJW?= =?utf-8?B?SkE3anBGL0pUZTlPaGdFSnFUUnlOcFllREk0RkI4ZC92amxhZDJLM2g1VFJv?= =?utf-8?Q?orcBUZhClMFZ0qsoioEpPl5cbx/+29amJxrDzSd?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: aafa5b43-f735-4db3-d08a-08d971f80cd2 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2021 12:07:23.1625 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: mZFC7s4D4ydJmgfgHq1eN5JHKDnRLeCTZaomrg8SF5gCbPA7ZyH/63UPSSxFvPLLe9wPZN3GKpUD02THWyXLHw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2335 I consider it unhelpful that address and size of the buffer aren't put in the log file; it makes diagnosing issues needlessly harder. The majority of callers of swiotlb_init() also passes 1 for the "verbose" parameter. Signed-off-by: Jan Beulich --- a/drivers/xen/swiotlb-xen.c +++ b/drivers/xen/swiotlb-xen.c @@ -253,7 +253,7 @@ retry: panic("%s (rc:%d)", xen_swiotlb_error(XEN_SWIOTLB_EFIXUP), rc); } - if (swiotlb_init_with_tbl(start, nslabs, false)) + if (swiotlb_init_with_tbl(start, nslabs, true)) panic("Cannot allocate SWIOTLB buffer"); swiotlb_set_max_segment(PAGE_SIZE); } From xen-devel-bounces@lists.xenproject.org Tue Sep 07 12:07:59 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 12:07:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180953.327855 (Exim 4.92) (envelope-from ) id 1mNZtP-0000PX-Eu; Tue, 07 Sep 2021 12:07:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180953.327855; Tue, 07 Sep 2021 12:07:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNZtP-0000PQ-Aq; Tue, 07 Sep 2021 12:07:59 +0000 Received: by outflank-mailman (input) for mailman id 180953; Tue, 07 Sep 2021 12:07:57 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNZtN-0000ML-Sa for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 12:07:57 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 38d5356a-0fd4-11ec-b0eb-12813bfff9fa; Tue, 07 Sep 2021 12:07:52 +0000 (UTC) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01lp2050.outbound.protection.outlook.com [104.47.0.50]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-25-mTLXMExqNMKKhs3PsuV5vQ-1; Tue, 07 Sep 2021 14:07:50 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR0401MB2335.eurprd04.prod.outlook.com (2603:10a6:800:2e::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19; Tue, 7 Sep 2021 12:07:49 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4500.014; Tue, 7 Sep 2021 12:07:49 +0000 Received: from [10.156.60.236] (37.24.206.209) by PR0P264CA0247.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14 via Frontend Transport; Tue, 7 Sep 2021 12:07:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 38d5356a-0fd4-11ec-b0eb-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1631016471; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/5oNHcbLsqo9M2lUcfhAAuumf4VaC3DcQDQUojVuRYU=; b=G9E91MBOpVZjxwi18BVIxBH8gw+UsdRqt/pYQuVCDK2SKrJYE14LIndIDn+v9/t5oDx5NV rfJO8Mq6MFvU03WtBz4se15bUdbwPNxKsw66rMm15z4h5AJXHuNNcOEIAKA7MpIyPrSScW vUE4/n0++y/m5L6GfPYpls5wEFCAwWE= X-MC-Unique: mTLXMExqNMKKhs3PsuV5vQ-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nbjHdUoBL+11rFy2gY9B7/5mScKhF6tDW8jzwh1MY89QgITtmyPuTtKBW0xg0Vu5cMuSraCSMBABO1E2hXH+30s+8L6rwE2hVLfRVeNDJx/I/zvguIlsa3RWLK1qaiZf43GUfrhsA+On0iuek9DjDTbnx2mL+TgUGnQPXjw2orNJ3zCLRz1ML/2WdmiyQ3uhws1+F1ngN0cWzsSwnk6uv4+opDLPzCW4OwKNmKTIP42kGvU4XDG5toyu7ES825sr59QPhB+buDuo9v8t8OWS8QbsAcUKg0KNL3ibMPAeblCDggQV3uRWL2ocXD7wyJb1BJOigXbJy5nPdRB3iQHxwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=/5oNHcbLsqo9M2lUcfhAAuumf4VaC3DcQDQUojVuRYU=; b=OYZsiqHbMNHHvzMyUyXzyeazn7kelTM4uQq6MtiiWZxOX6jf2C5kbafG/gmmVLOt0qu2gDfVbiTdyDWPRsrfuBXYTEV1BuHWocO2tolkw2gvouu7XIdzHPaEuS0Vr8Mn3yrx3eQFA6fcNA5lZglT9DtdoZsg3t1gO04cdF/Hu+hjJg++yxteefVe98DrGI6Wm3U4fnVsL4/XjcLDI2HtzFaQ1KR0E9JUVnAISYO/5Y7dj35MUZMpsmnUlcSUrDpC0tvcd1GtzOBglkN0mR2firbjOfEct+BCrCfZR9XJgVCoOj+B1dUKIGIY/UxJtUg6GtvnJwwh0b9Yeqbe4OIYqQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com; Subject: [PATCH 09/12] swiotlb-xen: drop DEFAULT_NSLABS From: Jan Beulich To: Juergen Gross , Boris Ostrovsky Cc: Stefano Stabellini , lkml , "xen-devel@lists.xenproject.org" References: <588b3e6d-2682-160c-468e-44ca4867a570@suse.com> Message-ID: <15259326-209a-1d11-338c-5018dc38abe8@suse.com> Date: Tue, 7 Sep 2021 14:07:47 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: <588b3e6d-2682-160c-468e-44ca4867a570@suse.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PR0P264CA0247.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100::19) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ef7924f7-8733-4ea4-740e-08d971f81c50 X-MS-TrafficTypeDiagnostic: VI1PR0401MB2335: X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:626; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: P0wJiu3kiYlboYr2V/LGfu1A/YJF5KRBBcMhqlGVoTiAr0Vu5FfvfS8TSTyBnK1SyjAtdi3AIWl4NwOE3poSa+zGquSb/JwTvR3yeTkOKcRauRful66g22/Klc4GTLEfGu/VeZqi2Lnrpt04Bywau/h1f874QuFscuwt+0tsKwMeMmmGoBVW3MernkWTi98XvfS8BM0o1rcIWaVrNTZszjhlncLspkrs8fI4dGGy/wbhCdJIHchJN1Ql9o4SvjTX2DAELjMIUcg4euHK/PEMUpSM9b3oZrB8gkozpNyohgHb9HNklrIGGeEDDbwVNHfplXTD/lr1luNtFY9d8a8Pxfzlc9fYiQjcDp+83eZMqvaneoLypJM+WETb86IA6WWN2Rj6fmq+JI0sIPOTTKUbgb/cMKQRY3FFeNRBXj/jcYvaMraRbgQvTrUHpZ/xR3rPdx3LJWLkzzVMx3wy2KoarEzQtBu+oElfcSqxal+hc/HiPhetAFqC2zKml92pyFS6WYS7xEemWZl4GA7eF+AZ6XCOqoUtSzAvlbpNI3GBYb2vMEnal2ltc6IQWncRlaPTjMEUgSkFVhZMqk14pHSyylv5/oLGi86ZrmyqYjl4Bo2M7W/yPaDfhBAR7ILdSp1J21z1qoY0IuVyM1I5OJDsyCQCq0VcNsaIjBL70K7oZ/eqWC3J45us2gxG6eEiohB6YZJGylwRaKCOidfwVcqUAe5sv2Oj/sR2LZNjC1dKCLU= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(39860400002)(376002)(366004)(136003)(396003)(346002)(2616005)(8676002)(5660300002)(38100700002)(54906003)(110136005)(956004)(66476007)(66556008)(66946007)(4744005)(26005)(316002)(6486002)(31686004)(8936002)(16576012)(36756003)(4326008)(2906002)(478600001)(186003)(86362001)(31696002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aTdRcll3RnQvVlhlWElSakw0S2NidjhxQXF5dkVHd1J6bm1KVnM3N3kxclM1?= =?utf-8?B?YzZ6NzNOTHNjYlA0MEMzTy9FK1ZSc1hhZkdJcWw2SG5sdks1cGsrRnlGYjlw?= =?utf-8?B?YzB3UXRrRTBqS3ZiMDIzZ1BNclp3UWo0TG5MS1dIRDBVbE5uNkxUWFpQbVBj?= =?utf-8?B?UG1OVml1NExEQ1JYL0hMdHBjU1UzU3N5RWVQay9yZURjOG4wc09JVG5pdFNa?= =?utf-8?B?VXRCeGxwUnBHYUhaRWNMTEFEWTk3U2hrSzNBZzhEQStVVXVqTk9kaW9MSkJP?= =?utf-8?B?aXN3UENzSHc4ckYvdEREbWdQM1lWVEVBaXI1eEdzRTdvTEQ2SG5MVmVEN2tW?= =?utf-8?B?YXBOYTZhQ1Byc3ZzOUpRU1FQMkZjYkwxaGptdHlpRXFQNDZiMjNSZnFFUVUw?= =?utf-8?B?NElNbHVmeFd0djdRY0tUaTZNdHBqbUxYUzhDaFJ5bmh0M3BnbW9ERXdya2RW?= =?utf-8?B?Y3FGQXFYZ0toM2N5ZlRadTJ4YWhsbXJDaHhrTlB0L3QyQlV5R29Ec0Z0aHVP?= =?utf-8?B?TDZ0SitoeFdZQjhhU0pxZUNRUjhUbEp2WmpIYjJhbEo3MTFOMSt6Nm9IVGxI?= =?utf-8?B?K2xSQ1hGL2trakVaUGNzYVVPSXNibGo0MUNUMDA0MldOa0U2Nmp1VWptMUFa?= =?utf-8?B?cnFwZzVSblEya1VGS3pCd0FtNGRUWUhyMVkrSXdYeFNob2FoNHB5NUlobCtF?= =?utf-8?B?SW90SndlNW4vNEJDcXNiTTR2RTQwMnRxTmpKT2pmRE0yOHBvL3B3cHRyQWI4?= =?utf-8?B?dGZNVUN1VzN5YmkxSU5lY2xmSDI5SEt0NlVmbmwwUjl1TXlvUjdlSHdzM2pU?= =?utf-8?B?Z3k2bkxELzBmZDY0bEVrVVh3bE1taVBYTDZOcExNVUsvaDU0Ti9YV3RhWnJl?= =?utf-8?B?R1ZtbThnSDNDWno0MXVvejFRdm1xN0JtN0Z0VW4rT2MzSlR0RWFTKzFhanlU?= =?utf-8?B?c1ZUeFc4T0Z6bG84eDdkdDV6ZVgxbFpXK2M5cGtJaHpYREg5bVFiYTFPemZj?= =?utf-8?B?TWFucjNXOUJPTkcveERORS9qQitYMHZZak5GMmJSNVpkRnZsYXNDajhDbUJQ?= =?utf-8?B?RlNLZ2loczUvbVdERVU3aHM0SnpwR09NaFBkVFJDbXZmQTMyRjJXT09pRU5o?= =?utf-8?B?Sk9NMDlHMytXMDBBVDVKdjM4U0tUM00rc1JuYVd4Tk5rdTl2Sm93M29icjh0?= =?utf-8?B?MnJmV1ZvY0syLzBnZHdXcG5ZQlBDUFR3V014SUZZMHRialczZFFwVy9NMU9W?= =?utf-8?B?dzVPdVYzS0tnVWE4NUxPVjFVK3B2alpIWWk4eXhkZldHQXBFaU0rVnZOVVZW?= =?utf-8?B?VnhDWDJ5eUtCZEFyU3ZGTE8rWENkcHdJZ1VkZ0JZMzJ5QUNManpSVTNzSTMv?= =?utf-8?B?dW5vNE5EamNyY0RKVXhWeEdVNC9ITkhqOEp3Sk16MkxSVytXamlrWmVjZzM0?= =?utf-8?B?TWVlbWk2ZDBhVzQwVS92RW9wMGtjV2FxVnZrS1UwK0k3dzFiaFNZcGorZ0tN?= =?utf-8?B?TG5oRHFKSS9ycFBiV1J3eDJ6eG5OUDNlVlFGNnlPY1BwejlxallMUU5lM3kv?= =?utf-8?B?MTlINWFvOGtWbWxsR2p3dDBCWXZsN1p5dWRIeU5FT1EzVElyYjlBZlZ0dU5u?= =?utf-8?B?VURUczRiSkRlaGFwVGovc1A3QVhFR3F5aDZjY3FaTHBUNUI2ODA3c2xkSDU3?= =?utf-8?B?QnZLQXBkTHl4L1dDeUI1UlZwY0c5Um5TSWJPSFYrb01TSStXNFoyRVN5S2o3?= =?utf-8?Q?iqC3YEIiT/tUSyh4haYpCigcaQNQuviBwl0CqEP?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: ef7924f7-8733-4ea4-740e-08d971f81c50 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2021 12:07:49.1837 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 8BKWMzefbSY0LRJXWx2Zs2vQu7Is952TijJ4DX9+OI2nh3NvAJsJ3ZUUGA7RR2sYEu0sj7615QNzEj5OnFIiUA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2335 It was introduced by 4035b43da6da ("xen-swiotlb: remove xen_set_nslabs") and then not removed by 2d29960af0be ("swiotlb: dynamically allocate io_tlb_default_mem"). Signed-off-by: Jan Beulich --- a/drivers/xen/swiotlb-xen.c +++ b/drivers/xen/swiotlb-xen.c @@ -152,8 +152,6 @@ static const char *xen_swiotlb_error(enu return ""; } -#define DEFAULT_NSLABS ALIGN(SZ_64M >> IO_TLB_SHIFT, IO_TLB_SEGSIZE) - int xen_swiotlb_init(void) { enum xen_swiotlb_err m_ret = XEN_SWIOTLB_UNKNOWN; From xen-devel-bounces@lists.xenproject.org Tue Sep 07 12:10:55 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 12:10:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180959.327866 (Exim 4.92) (envelope-from ) id 1mNZwA-0001rq-TF; Tue, 07 Sep 2021 12:10:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180959.327866; Tue, 07 Sep 2021 12:10:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNZwA-0001rj-PF; Tue, 07 Sep 2021 12:10:50 +0000 Received: by outflank-mailman (input) for mailman id 180959; Tue, 07 Sep 2021 12:10:49 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNZw9-0001rd-1V for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 12:10:49 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 8d632e29-a0bc-4e46-a45d-add1b6fb1d7f; Tue, 07 Sep 2021 12:10:48 +0000 (UTC) Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-ve1eur02lp2051.outbound.protection.outlook.com [104.47.6.51]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-29-31Ji2ZHLOkaVTUI_6HUsoA-1; Tue, 07 Sep 2021 14:10:46 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VE1PR04MB6670.eurprd04.prod.outlook.com (2603:10a6:803:120::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.21; Tue, 7 Sep 2021 12:10:43 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4500.014; Tue, 7 Sep 2021 12:10:43 +0000 Received: from [10.156.60.236] (37.24.206.209) by PR2P264CA0034.FRAP264.PROD.OUTLOOK.COM (2603:10a6:101:1::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Tue, 7 Sep 2021 12:10:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8d632e29-a0bc-4e46-a45d-add1b6fb1d7f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1631016647; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=buzMPiRLo4X6mtdDWgXjttrreVWYxdvGTL8smO8qNkM=; b=fBP9BQnQq/B2VvsrqCbDJBR75WwH+Yb7QuCUbkRCnCZUBHrxpEKlNUr+xVT3eHQZa5okiX tFWVza7/7ASznenRlGQyjOa8bOUbRopuqgISsibDWZw15hB7MbLJ5qvyLZ3hPO4cMW4Sx+ G8p00F6wdTEgyckR0aIM+/boXZKrWyk= X-MC-Unique: 31Ji2ZHLOkaVTUI_6HUsoA-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lGFfI5pOHudYsCXPNFmYDflsm9wZBoUuRnhxbfea8ryF/O+5IwR8zKXWSRGFWOwt+jw6mGeb/3FK7u7SyNedIIqp0XeK83N/3JWWnnOKlb7tfu0GMQF92SL4KU8XXEj9clG0A5xyBj6PJR21apusrWdeeLfpjh6TO++TkAM1HCL44GXusdnqIXiBAifFj5JF/VmlI2z+qeNLphnP36jIakOheXpdL6PDyNrOxVLBWe1SJeVgYBoqIhPhvLvmyB7c2GCTqp+BG1GQtnVpOzeMUJPjOK7zpbDRlYH/Ny7y5ag1Qo5ER9yWPCs1YRlLR70FALd/WFdiUuXx6kVt81wpVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=buzMPiRLo4X6mtdDWgXjttrreVWYxdvGTL8smO8qNkM=; b=ij9RxK0H9a9ZGFFPKH1dMfbKGuWzcdP5uWCEzVXHlVphkaKNR9maympd/yaX1aG7nP7qMMIetnnELaisC1V7ge/Uy0oBkLk0RNhA9wZKxJJPTK3quY8unFsMBDgJWHWxw5rSZ/iUxFKuXiGoZmVLS94ZHfmdo8WaiEjy9dRghuyH6wWhkG2YHN/iSZu/eU2i0H8GN6a66vZbq9TX0H4Qo19eXQRjGcNaheckmnp0FNCZhDN0yz0zQeFkt8KzzAwnlDpBKdwJ6M1/G3wdKkFOiMgQniG3lEt1MCBNfMTW9/EUe5vqqTKC7IikwPCPmLge9rXzGYQS3aiVZznu3eIXKA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=none action=none header.from=suse.com; Subject: [PATCH 10/12] xen-pcifront: this module is PV-only From: Jan Beulich To: Bjorn Helgaas Cc: Stefano Stabellini , "xen-devel@lists.xenproject.org" , Juergen Gross , Boris Ostrovsky , "linux-pci@vger.kernel.org" References: <588b3e6d-2682-160c-468e-44ca4867a570@suse.com> Message-ID: Date: Tue, 7 Sep 2021 14:10:41 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: <588b3e6d-2682-160c-468e-44ca4867a570@suse.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PR2P264CA0034.FRAP264.PROD.OUTLOOK.COM (2603:10a6:101:1::22) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1227db84-abb6-4da7-c80d-08d971f88451 X-MS-TrafficTypeDiagnostic: VE1PR04MB6670: X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1775; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: m7EAqm6GcEk0ur7TGJ1KZyyN8K3PN89uiz3gqAxJ9J1nOzPj2hc8dOnXprwzfy3gXqZqq5vHI5U4ZazQ5KwdXarQm6nASmvbcN6iTnjqzSOSwJIG5Gjif7Fqh0MuFMptCyiJYlNVci9h7ONjQZUeUkV8MIp4hRs1qAmKdPeoiJEvU6WFVQrvNI/y4aceIRe66/51smGTNj5QgCyu5ddAqGI+s4ocP4aySnEveTPusykjEU4j1khnETIBOt+77m1yVKsh+3FZBIPeQ8asEJZzu4vvDg5ShEdEy4eeJt9pJZcDJkavQih/ADDcO53BX0qJsydcvg1fizVKHSHuI8te0roO22eH68tPlZ/aaGpKhnes9p0IV+7js0K8p+Zoi7rYcbtLbWCN9LB9Cygyg+aCf6rR5Ket8izPO5S6DqaR+XXwZ8iFCQY/qQ/ogoE6Gpk2KQeT4XBeBI296RPD4hD6Q2keaGKze4Hmv2r5DzGgWIr76ofsaRrT8hc1MXfVNgG/SfWpZB1p8cJICfXGbyBQJFRzoVwbTMchqs/reHC8xO4CoqTPL63+DdYNiuQeQGbDxN8xezIRvx8PCngE77q1Y9jneDON/sQb+PtU9cc8/s7e2fLFOtqFdgyL7j/fvmsOBzu+lT0gQeyIxBhQ0tRgzfp0vN8WyP79S/Js8TibzmlICrFcvzxPIrLjn9CbHD3eqG4FHBEY2FX802K/bShGnNJH/EOcTuPiZf5Xg2iOj7g= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(346002)(376002)(396003)(136003)(366004)(39860400002)(31686004)(8676002)(2616005)(316002)(5660300002)(4326008)(6916009)(8936002)(478600001)(31696002)(66556008)(66476007)(38100700002)(66946007)(54906003)(186003)(4744005)(86362001)(2906002)(6486002)(36756003)(26005)(16576012)(956004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M2dEUFBtcjI2ek1vVS83VkNHWXVQL0ZwMFRoRW9rcHBISUMxMXE2MFlVWU1q?= =?utf-8?B?YWpLdjNUcU9YcDJBaVFjZzdjMXREWDdGaUJ1T1h4UUxFNktPM2JybmRsdHZr?= =?utf-8?B?Z3A0bVJjKzdDTUpFVllhYkpoWDJweTlHaEJidzRWdzhYeHU0YXQvY3UrNnUz?= =?utf-8?B?K3haRUd5SVZYZndwaDN3eGRJcmNLd1RuZVFsVGFOTTBiQm81ZmdzOUt6L3ZC?= =?utf-8?B?MGprWU5qeVZZTlBISDd4NnRHMVhFWFZFNzc1eEJWejJqdVA5bjFMZ1VWeHJo?= =?utf-8?B?Tlloa2RQTS9DbzJGMmJDRkE2dWZxdWZ4b3dhRURzYm5oNElOZjlWeTBlMG5Y?= =?utf-8?B?ajlMeHJTeTZ1VFU0ekxIZSs5WXFlUkd1RTVjU012LzBYdTZpU1c4UFVRNFRW?= =?utf-8?B?ZFBVRWM1TW0wcjZPMG9XQzA1cmNMY3ZwNG9URm5JYVNHbzVua1RXOVgwbWpV?= =?utf-8?B?RHZTOTUrWkNzWE9uMzFDQnJad2piVWZoKzRnOUN6dGExWEJxd3JjaWJIMXA1?= =?utf-8?B?c3ZnWHNQcU5TUndTdXovdEJTV1d6UEpjNGR2bGV2Q3FhSVhwampBdERTaHlX?= =?utf-8?B?NnVBUC81QTRWK2s3ZTJWc2NjSUJDa3Q5QlgyTGlYQWdGSzJTdkVqYXk2WmZS?= =?utf-8?B?cUZaOGg1TkZVL2lTMURJNmhpUEQ2OFVwYXZ5a0QyQSt4VU9zOWx6c0pqTEFM?= =?utf-8?B?MmhnQ1FVRHByRHd3N09XMzlOTEcxQUNPU3ZxMXVwdGZXcFhqNTByVGJyVnhX?= =?utf-8?B?NDdVRlo3ZUhnSXFJUkUzSHlvNzZ2eHlFREhTMk5IdFRFYVVDNjhTR0ViWC9Y?= =?utf-8?B?YVo2SWVpTEdHQW0relU5VzNYVGgrRW4ydHdDb3N3V1R5RjhndExHQkUzeDJj?= =?utf-8?B?dmZ3aHZ6RlU3VElkV3RJWmRVNHlzQXU2bURDK2h4ZWNDSnQ4aFU1VnArYXRI?= =?utf-8?B?aElHUUV4KzBiWTBkQ0tkTXNSa2xBelc2U0lxM1YzVTA4OTZ2cHlULzdkYVc0?= =?utf-8?B?RWhhTm5LdWV5QmxsSlJ2aUZ1b28rR2Rja3pqVjRtWWp1K3FsTkVmZk5sQ29r?= =?utf-8?B?d2F0dkhjYzdON2xHMFlaYXA1MlRTSUpkYUpuSjdPUVVZRzB0YUJUdkNnZzc2?= =?utf-8?B?R2FhSk1MTTE1eFgzT0dDUEZ1OU82NGkxQTBNSG1JeFY1WkE0OTFpZTdTdWJW?= =?utf-8?B?a2labmQ2ZEtmY2FDMzBoR0Ztb2JCSWhDSXlGQVhORHNCL1Q3ZEZHc1REVlRi?= =?utf-8?B?bFNOY1luS2FObzVWMVZua3F5d1lSQ20zQkFYdVRhUTUzQzRod3RibzdwQTZs?= =?utf-8?B?bmlYbWN6ZU03K1Vzd2tFMTlSRTR0ZmtoZXVVQkVuNFEvWHFhU292OURuaTl2?= =?utf-8?B?OVJXckZ2MkllcEN1aW5ycWdHaXBZRG1aRThaMk1KVldSQXU5ZkhHamJOY3hJ?= =?utf-8?B?QzZBVHNhb24rdlMxTG1tYkZvWWhYRHhjQkhmTE42RDJKdnlkQ05ORHFBQ0tE?= =?utf-8?B?MTREU0lHWndSK1FldFBKeFR5RlVFVkliYkxNUnhqK1JndDcrWVQrL2VqUWJD?= =?utf-8?B?ejBTRkdHV3N0OHk2K1A5RVpSRHZrTCs3VHdKWlo3Z0RiUGo1TTFFUEM1SE9X?= =?utf-8?B?ejFJYS9zelNhS1lFRWdUQnRmejlwdHoxaXVEWXIvdTRBN0xvRFpsSjhLRDVi?= =?utf-8?B?Ujl0R1B2QUdFMmxKTE83b1BoRmNxR0hib0g2dTVSRnlkUjhMZ3J2b09OSkli?= =?utf-8?Q?Kz5RxVbryVNtDaBh6Im1Twyr3j3aEdy9lofUnsF?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1227db84-abb6-4da7-c80d-08d971f88451 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2021 12:10:43.6715 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: F5oVfv4KKz7Sfl7MsVyluQn1Kj7eJyGUHCjIUpIYyXZBezIo2cWXP/iZ3IgskLgXkzW8iTWz8Tcmd7aQhGvW/w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6670 It's module init function does a xen_pv_domain() check first thing. Hence there's no point building it in non-PV configurations. Signed-off-by: Jan Beulich --- a/drivers/pci/Kconfig +++ b/drivers/pci/Kconfig @@ -110,7 +110,7 @@ config PCI_PF_STUB config XEN_PCIDEV_FRONTEND tristate "Xen PCI Frontend" - depends on X86 && XEN + depends on XEN_PV select PCI_XEN select XEN_XENBUS_FRONTEND default y From xen-devel-bounces@lists.xenproject.org Tue Sep 07 12:11:22 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 12:11:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180963.327877 (Exim 4.92) (envelope-from ) id 1mNZwg-0002fk-5O; Tue, 07 Sep 2021 12:11:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180963.327877; Tue, 07 Sep 2021 12:11:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNZwg-0002fd-26; Tue, 07 Sep 2021 12:11:22 +0000 Received: by outflank-mailman (input) for mailman id 180963; Tue, 07 Sep 2021 12:11:20 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNZwe-0002fQ-18 for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 12:11:20 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 87c36d05-5fb5-4f85-871f-79f0948e0ee3; Tue, 07 Sep 2021 12:11:19 +0000 (UTC) Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-ve1eur02lp2055.outbound.protection.outlook.com [104.47.6.55]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-25-aRu3o9_mMI6z_lWB0iMeiQ-2; Tue, 07 Sep 2021 14:11:17 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VE1PR04MB6670.eurprd04.prod.outlook.com (2603:10a6:803:120::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.21; Tue, 7 Sep 2021 12:11:16 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4500.014; Tue, 7 Sep 2021 12:11:16 +0000 Received: from [10.156.60.236] (37.24.206.209) by PR2P264CA0047.FRAP264.PROD.OUTLOOK.COM (2603:10a6:101:1::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Tue, 7 Sep 2021 12:11:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 87c36d05-5fb5-4f85-871f-79f0948e0ee3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1631016678; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=w/4sgXZWL5TyOKqIEB0uUbPnSshL/83p3qgV1ftBS1M=; b=G5E0+El9twSdJ4JPdIdcA6T7uJI4xcnrZK5TsXLmAxVPKfRIQkejBObU2Nsl/R9ywrZ4gc 9YIgDm/IXnIrq48RFo79xmthC05uop5obhm8MOVFToq4iYByQ2b13VxTVeSuEWc5sd3N2q growQoEhAbP33xGtkECN4tB1ibE5spg= X-MC-Unique: aRu3o9_mMI6z_lWB0iMeiQ-2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=By2MW81/o1kLuXrOUuM8q6oL3Ze9TE5xrmCWM8vczKO7aSWDhmJFL4M24jRQdjpV91rymu43Qyb6txMna7daDikJY5AKBxfzMV1G7lfA3un0sjyNuzyJLkOteTjvD9p4my5SAmsBMNJy3RTDF8Vwnv1CCAKcTd7Nxk13p/8d7sxUP8fb781Nnsuk7u3tFjAjNDv81uFKDQLy9pU3rIRAV8RfGyYO+nyjWHI0GMsEpVbvNGER4PnG6gCuM2DshNeq2+MT+eofI1D3tkdImsxMsngg8eMGasNmRC0oIK2L2t3b5fqJcl+s9fFp1rmbzxhbexhOzcvwb2I3c1y+o0BISQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=w/4sgXZWL5TyOKqIEB0uUbPnSshL/83p3qgV1ftBS1M=; b=lHmvz+NiNzSTlSrLOMxEGmfUSa6GiUMaikp6c9ZxF5uOa+1a8WReH4Xgfh1Ce8K68q4U3nLG+dQf6E9yy7lcD3D4tUMeF9bX2GN5KzgIXNyhx8kdljvnADorvItx1U/+/WxiYMrGNxsMyBVnF0YoHmsxkSlh06YnC1+m9cOmaXCFLiujSwxs7uTnhpytwdpUIHGkI4OroIlZgCq22RNf1h1kfWrF8OZbRGGo4RoTniRC7nhSOjnJfhsFp8ErY6s7Bp7Yizb45IEpc6uKGXLZ0yQOv5/fFB4ZqbY1HI0ZWXcaWBy6Kt351euSCasqdQ+Xzsjpsa9INTXZsDkhAFGSUw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com; Subject: [PATCH 11/12] xen/pci-swiotlb: reduce visibility of symbols From: Jan Beulich To: Juergen Gross , Boris Ostrovsky Cc: Stefano Stabellini , lkml , "xen-devel@lists.xenproject.org" References: <588b3e6d-2682-160c-468e-44ca4867a570@suse.com> Message-ID: <75591cef-95e8-c694-fd11-283800499e4e@suse.com> Date: Tue, 7 Sep 2021 14:11:14 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: <588b3e6d-2682-160c-468e-44ca4867a570@suse.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PR2P264CA0047.FRAP264.PROD.OUTLOOK.COM (2603:10a6:101:1::35) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8b96239a-338c-4c83-a97d-08d971f897c1 X-MS-TrafficTypeDiagnostic: VE1PR04MB6670: X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2582; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: c6jtTYYeSeyA8Xs2NV5x4j7yK4F1HAeNdMSka5OVZXiMXj22vesIRzMd4/kz7xRK7qeOeP5IwQFI6EqYyXPILPJwqNnN9lvRsUYihsVtrICJ3zbM1CULB4bbn+ej5gugNzviDieOLUG10NPU525CzdrHB9Xgrwbo12Joo3JrBLxqB8gHVpmbQK0vxxb6cPjGhZ0urjrYSbApUmM7k7nFp5AMrcvFjIb+hlkDfaC2QxwjWRY09Rxt9fd9knGkaE4B6llaNKYoZ36tIFTvt/VH1OjictbFgOMoRLvPL8ItQacZ4fXVBaHkjk6/da31yp8PrArZi29sw5NmtH1Qv3fXg/5Jic9ogCLi0XwMwuCJ4HI9eded5XtvAEoFu5KyaIrQu5qouKAm9LxV2mmQ+lGUSimCnJZEjMuFu2XLFDR2edH+WLeJOfCvoZV8EOHUEK03r9ediEQSxhQKyffIlJAOJIMuVjgoR/w353zN3BtMKfwLK9x+XNASDwCsWwGL3ddIS8rCDvx/NtW1WFM1aiEvxw2+krqkwgO7Pn1CSXPxf8Gdkye/8CrPALf4gobyMbOYx8PydoDPu9QlLS/IYFae+iTqocbHnl1/8jW17dFiv9ccv7V48YjrvuBjLuUMjjXnM2YxeYcRHnR8XiqzKTr1fPU3PIVfTww9K0AE9Mk/af9ur36LKadfKkqxmlzaAu8DbsT4Wcm3ahbZ5WLgLEUZbxADiaUvu44Tgqi8c7OiSsI= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(346002)(376002)(396003)(136003)(366004)(39860400002)(31686004)(8676002)(2616005)(316002)(5660300002)(4326008)(8936002)(478600001)(31696002)(66556008)(66476007)(38100700002)(66946007)(54906003)(83380400001)(186003)(86362001)(2906002)(110136005)(6486002)(36756003)(26005)(16576012)(956004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YXdSMHNXREh2TFAwUWhyUzc3ZTVJbHFnc0NiMGNwV0RoVFMvTlN5emZUL3k3?= =?utf-8?B?VXdNd3JOeXRXdnIvd3FDYkZqclYyWTZ4VmtaYlhueEZ2bHE2Y1Nicm8yWFBZ?= =?utf-8?B?czQwNjhOK2plMEpLdUwzSURjVmFZK0JKd1VFOTJPNVliWjlzM1NVUjNsdng3?= =?utf-8?B?RVhOc21MeityM0x5WHA5b3NlT1hpanYrblVRNjgvemplbThhWkdDcVVXbjNx?= =?utf-8?B?aU1TajBrTjdSWitNVTZhTERCS2tqMVo3ME9jd2ZvQWUzUlVQQS9hVlRvYVhi?= =?utf-8?B?ZkkyaFNxOGJQckEyZjlCREQrUm02WnFhQnRLN3prT01NNDlPbWhVK0Nha2M1?= =?utf-8?B?aVZudVZMOUQ1TE5PQ0t0bWgxZVpyMjFldmY0OGNEU24weU90K1BBT1V3Wlln?= =?utf-8?B?QVhrRGtMZElVcklDVnpIMWJFVmRMK3lxK0JUWDZ4UnBSSUVHR0N1c1UzM2Nq?= =?utf-8?B?alFIdjB2VDVOOFpvb0J1ZXdNWFJUTGp4L1ptTXpPU2lEdnEvQkNIbmcxa0I4?= =?utf-8?B?VVRTYmM2OVltemhkQ2RXWFZMemtLM1ZnWXh4bm1zWnYwYk1uYzFuSVhsbTJk?= =?utf-8?B?OW02NTVXWVpoeTV3YTVRTUlCeTVBZTQ1U3FKMUU0WSs2ZmU1RjR3ZXhPNVpW?= =?utf-8?B?bWVzYlhRVUhaZU1lVkR6V1EvZG1KUFptc2tJb1pSaGVtM1ZVZHFtV1RSYkhy?= =?utf-8?B?dmlja3gvZENKeXVLTktaMzNMVGI0OU5wbHVnMyt6eHhpMUJjbldxb2M2VUNT?= =?utf-8?B?NHJWejIwN0dRcFlKQ0lCRFFMeldpcGZMMEM1Q3BGbE13V3lBTVBEUCt6OHdO?= =?utf-8?B?a2hWdm54QTJmdVhZcm4zdURaRjdSSnFkQzFoWm5PeHR3WnFwMG9Ub0Rtd3Rn?= =?utf-8?B?Z1ROZmQ1MkZ5SnJORUNuR1Jsb3B1M0thU2tueWRFUWZZQWlQRWU1RlVDUS95?= =?utf-8?B?Q0VITDRDRllGaVllNnc2UXVySVFYNStuRFVYa3I0OWkvOW5XT25wb20yU09k?= =?utf-8?B?YTd5emxwUHEvSndiL2E2VC9RL3ppZk5iMlBHVnpPRDlPVmMvbnBsekxtbWZB?= =?utf-8?B?YU45QjF1em5mSGpzTWVPL0NZSk5uZ1Q1WG80UTVDdEJrOEpCU0huVUs4U2FQ?= =?utf-8?B?ZWdadHU5eU5NcitJdnpGQnNVU0NyeE9YWnpzc0o5NjZ0Z2syK1J3ck1Ualh1?= =?utf-8?B?ZUV3bXZRamp0RUMwbDRmRUYwSy9XeTFiOFJUSEpkVlBOcEhYZHVQOWc1emdD?= =?utf-8?B?Ly8wR1k0YjRnZ2dpbDFodDh0dWc4TFlxNHN3aGx2RVRHOU5VVmF2OEJVZWZp?= =?utf-8?B?aXhkYUN4S3dmVkY0c2sxMWpiUUw1b25mbGJRU1Qvd3VZM2FxS0JFblE4Tm5i?= =?utf-8?B?RWt1THp6b0Z0Rit3VHZDMHJXUnlVNzZ1NG4zU1ZRbU5GTkk2S0NiaUNVN0Zu?= =?utf-8?B?TXVrNWp4dHJ1d2RmSldVMC8zNkZydU1nbEJ3bEtFNmg1ZGJOb2ZLdTlERWs0?= =?utf-8?B?UWU4cU15VGIzbjh0ZTJLMi9laXA1Q0dkam5adTFDRlpDTWhpckdCUW5nVjZh?= =?utf-8?B?Z3BtUnY3THlDbWVhRzlGRFFpWHd2ZDhXeTNhcjEyYlVMN01MRWVERXIwbmpK?= =?utf-8?B?MS9EMHg5MDluUVJQWXBmeDNSVmR5SldLNW5vNTdkenpKWWlRQ05rNlFTTFdE?= =?utf-8?B?U3dOSkZMTlM3amxxWDBVL29mMlROYXRSa0NMWHd3WEprak4wL2JwZjZHTEpn?= =?utf-8?Q?jztJsKC5v6UJGl1hsCBzl5tLH5sz3/K5EI9w1ma?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8b96239a-338c-4c83-a97d-08d971f897c1 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2021 12:11:16.2704 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: qEfTjpzl4JcI18fHOhFc1nlSIL4QhKp3jrj0zwtijI0hb4Whbz4NLgrnIg4zOSGvgSYcNJGY8iOXwgUlRxDadg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6670 xen_swiotlb and pci_xen_swiotlb_init() are only used within the file defining them, so make them static and remove the stubs. Otoh pci_xen_swiotlb_detect() has a use (as function pointer) from the main pci-swiotlb.c file - convert its stub to a #define to NULL. Signed-off-by: Jan Beulich --- a/arch/x86/include/asm/xen/swiotlb-xen.h +++ b/arch/x86/include/asm/xen/swiotlb-xen.h @@ -3,14 +3,10 @@ #define _ASM_X86_SWIOTLB_XEN_H #ifdef CONFIG_SWIOTLB_XEN -extern int xen_swiotlb; extern int __init pci_xen_swiotlb_detect(void); -extern void __init pci_xen_swiotlb_init(void); extern int pci_xen_swiotlb_init_late(void); #else -#define xen_swiotlb (0) -static inline int __init pci_xen_swiotlb_detect(void) { return 0; } -static inline void __init pci_xen_swiotlb_init(void) { } +#define pci_xen_swiotlb_detect NULL static inline int pci_xen_swiotlb_init_late(void) { return -ENXIO; } #endif --- a/arch/x86/xen/pci-swiotlb-xen.c +++ b/arch/x86/xen/pci-swiotlb-xen.c @@ -18,7 +18,7 @@ #endif #include -int xen_swiotlb __read_mostly; +static int xen_swiotlb __read_mostly; /* * pci_xen_swiotlb_detect - set xen_swiotlb to 1 if necessary @@ -56,7 +56,7 @@ int __init pci_xen_swiotlb_detect(void) return xen_swiotlb; } -void __init pci_xen_swiotlb_init(void) +static void __init pci_xen_swiotlb_init(void) { if (xen_swiotlb) { xen_swiotlb_init_early(); From xen-devel-bounces@lists.xenproject.org Tue Sep 07 12:13:29 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 12:13:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180970.327888 (Exim 4.92) (envelope-from ) id 1mNZyi-0003Tx-L1; Tue, 07 Sep 2021 12:13:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180970.327888; Tue, 07 Sep 2021 12:13:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNZyi-0003Tq-I4; Tue, 07 Sep 2021 12:13:28 +0000 Received: by outflank-mailman (input) for mailman id 180970; Tue, 07 Sep 2021 12:13:28 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNZyi-0003Tk-30 for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 12:13:28 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 014c1066-0fd5-11ec-b0eb-12813bfff9fa; Tue, 07 Sep 2021 12:13:27 +0000 (UTC) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04lp2056.outbound.protection.outlook.com [104.47.12.56]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-36-hmssEa00Mkes3R_235iJ3A-1; Tue, 07 Sep 2021 14:13:25 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR04MB4943.eurprd04.prod.outlook.com (2603:10a6:803:51::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.21; Tue, 7 Sep 2021 12:13:23 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4500.014; Tue, 7 Sep 2021 12:13:23 +0000 Received: from [10.156.60.236] (37.24.206.209) by PR2P264CA0039.FRAP264.PROD.OUTLOOK.COM (2603:10a6:101:1::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Tue, 7 Sep 2021 12:13:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 014c1066-0fd5-11ec-b0eb-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1631016806; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Oa3ZLU03Swba0gYvsSEjRU1XJu+IDpj/E8M5qxMYmhM=; b=m/81AvXjwZBlj8QjxuUQXwqF4l1qlxXQC9MUfuQyClDi11QVIQC0sr6VEvsZECn5zSNien 8CR2EnqavAKyN8HSWQ0SzWuMHUwLZEBOCoEda58aoQ92gToAB73+WeBfnRhXI89W7G3zQN dIXuV48KDNbZEEfGxtlEl6jSEg9B230= X-MC-Unique: hmssEa00Mkes3R_235iJ3A-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fNrCjBtaCc9xrRgcZFD6TBodIymGQhEGSbmgii+q0J6PhiCvr9GbbJuWLbKnB3UY3AiS6gQ5Am15OL6bQ72vSLi2Rl1pS8ygiZUy5fMJMJVBNo2vBeKgD6GNJIz3oOyzOaErWXlx6+qgAOHM/xHdcCyoRl6IYlrUuChkpjOj0n5Rj6KfDry0tDdAKzdxfTNdOb6dKDkyJxySSyrIBoIfwxRYutrJtc3Q/aK+iAzkkavz7qe9K0/tLz0FRWkwNU9FG9wpXeT5QPqJdyzA5QyvjxQjYwE6qAKcmugli7NzsvX4mPCPxSOQc5d4354ZWCK25rcy1PWGw0+gBnOwlHiiTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=Oa3ZLU03Swba0gYvsSEjRU1XJu+IDpj/E8M5qxMYmhM=; b=JqLWdpRvPxsIWlGroRzDRKNQZLUS8rpC0Vt0vtXK9VxNpou54LoVMXTNImYpMRQsMha8Rnu0VWQu/QXCRXHObhYJf/5cVSuax64pcn4CdXJvC8tutebA/iyv3dHmt53PcQCAaU9jiVmnmLcTIxGdVKS4MVkkHCNFq/3WKbQqNGwFI2BkvLEbHty+BpXyG+1nyMntSXhfxiMfXt0jNTqAGgeUkzxX0zb8BZMQswUdfkIzmdJEQCuNjT/yjE1W2+Ww9jhD/V42Gy+RZ73oPjffsxbLGy1UoXVyvOK2fmCXIhRkZ9csNBnXLy4ilnn1SM8GGzLCc83VzFDfMlGMHABSwQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: alien8.de; dkim=none (message not signed) header.d=none;alien8.de; dmarc=none action=none header.from=suse.com; Subject: [PATCH 12/12] swiotlb-xen: this is PV-only on x86 From: Jan Beulich To: Juergen Gross , Boris Ostrovsky Cc: Stefano Stabellini , lkml , "xen-devel@lists.xenproject.org" , the arch/x86 maintainers , Thomas Gleixner , Ingo Molnar , Borislav Petkov References: <588b3e6d-2682-160c-468e-44ca4867a570@suse.com> Message-ID: <004feaef-f3bb-e4bb-fb10-f205a9f69f28@suse.com> Date: Tue, 7 Sep 2021 14:13:21 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: <588b3e6d-2682-160c-468e-44ca4867a570@suse.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PR2P264CA0039.FRAP264.PROD.OUTLOOK.COM (2603:10a6:101:1::27) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b7774d84-fc14-4235-a792-08d971f8e396 X-MS-TrafficTypeDiagnostic: VI1PR04MB4943: X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6108; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8vr/cvpjrHj9i7Ab2anwybJQtqfCUkLxrZeWoopggiJjivFTbp2KsRgQ7A2tgPQ4E3dOZgyqMef+rxP0r5Pb/k/MdvSyLCv19bNVwzU3Wav/jqlnxpDcGNZf3oWI1zJ3821MhF2+GsIRFmZ/FRgc5TPAN+qcGGolJ296uFSTODOP4iBS41fSKYHrj0vKL2X+GH7hfLfocq4UG1yP75NCkcuUnP143Qeew0LxdElKLrcDQxoS/xWKZIbYj2Y4C+/R0nnB+NinOvshRjrymlEpD+/SpI3HUe5CU41rLje5eigEnujEG2jzV4ZHmh52GxX1FvrPUjf+I6wc+Ku1mf8MfzLHuT0W5aTkGHbGouuR8v3wfT3wWlsGfvDUwv3lRZv637OQuIIjQUvQHcItHz4iz+Ku+OOZ3QW1NSSBWI2u9rgrpiIMziD6/CXdNzDSSLOHvQ8nS9zDmWKra/zxTOeFyjw/xbxYT+vppVOHSpgnlFuWkvMKlsMUU5tTJ/xAJhPGttvOw4enrLTTEkhBRXyowPNlNQA6FsMcs0Tw1wm9/3QNA50+/aY1IMKRzau7FjZnj9WACrpOg633GLU2QDw/Qm521l1aI5Tyy/Maf0tW5F7gp/P1lPDMv90nJd4Bv6cdIK7hNEBlgIJCEFTYlPX/bkJRjCPs8p3zDNxcMeQ46w65dAX/NcfTtC5Vs+2X4NB9t9aHqIb8A4os50DK35X5H9nqR2plZG9dVJ5LvUOkGkM= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(346002)(396003)(136003)(366004)(376002)(39860400002)(2906002)(110136005)(16576012)(956004)(4326008)(316002)(66556008)(66476007)(66946007)(5660300002)(83380400001)(2616005)(54906003)(478600001)(6486002)(31686004)(86362001)(31696002)(186003)(8936002)(8676002)(26005)(36756003)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?V2FGYmxETys3V1dJemlPY2s4OW5BSEFxcFE4M1N2dzNsdENSRlRES0ZRbEEr?= =?utf-8?B?Qk5ITnlXQ1V5U3RGUFRwbmVFUDdCQ3VsQjRZQ1BEandnRnVGOU5reitQMC9V?= =?utf-8?B?NEltOS9QU1pVTzdqMzlETE5ldVB5Wkk2SXpEZEhveXZKZUdPMDhtcUV4SVln?= =?utf-8?B?QUpjNG12QnFxUlhIem5Qck5NRFoxaGkzd2JldU5FTTNWVWJWNkwxNlVkSGVt?= =?utf-8?B?alpOd2R0dS9WeE1maW84c3lTSHRaY1dFbzFLL2xXdDI0Ri9UY3hGTEhjdWFU?= =?utf-8?B?cGNtWWlCU3hLUnVjcFVvU1lXb3FTaUdiNzlpTnRtRDR3YklnemZUbEdFcGJP?= =?utf-8?B?T3RQb0N4TzArRW5mQis4YzhRWlhiUGJZek5FZHZTaDl0Zm9qdUM4amZWYXls?= =?utf-8?B?N0J6dUJTTmNtOHpjZkNneTcvR2dYMkRBM3ltVzEvQlJVb2lnQjF5cEpHVEx4?= =?utf-8?B?ak43Y0Y2ajl3RmRQZjU3eVdMUGZXVVIwblQ2WDI2eEdKVUp0aXpYVVkzNkZH?= =?utf-8?B?bnU5NUxwOWtWcHVPZ1A4Uy81UWkxOGFJdEhuTklwWXVkVk90UjJHcUJsUlNi?= =?utf-8?B?K3pCNjluWUhYYVNybjJ2c3BhWVczU1N4ZXplanROc1RzU1FuRmYrTWVCSUdy?= =?utf-8?B?bTZaREhydEFaT0VnYUNZb1pHQ1ErQXQvVHh2VUFLWGROZzVMb1RFbjRPUFh1?= =?utf-8?B?TzJIOTZkRkF3WE5mVDVsS1FuMFZwSjJ6cjV1SmZhNjQ2R3Jsc1NpSms0NEUv?= =?utf-8?B?SEJTQ2hyNGhuSnJsQ1FmcXpJUnlZWWpoNThTOGNmWkZDSC8vN1pLUFlVZGlk?= =?utf-8?B?RkNqM0p4UTlscWROUmVyWkQ3Qy9LaUZ0U1huWlhjUS90RmNtOXV1c3M3NWI5?= =?utf-8?B?VWVuRndhbzdNaEYxM212MlV1MXRkQ3dIaTZqQmFEWUxtZnZVVGxydmJrNFIv?= =?utf-8?B?eU8xZEdGSWFyUDlPeEg2MmlGRFVDZk1MZzZBakRrNnN6ZFg5QWVvY3lDWFRq?= =?utf-8?B?VEtrVWIrZGVBU3FzaDV0WE1Qby9RVzdxY0c3SWptbVMvY3A5aG1VNHpxak9p?= =?utf-8?B?VFM5QWwzdVZ6KzdkWUp3SSttdHcwcEZxZVFlYzNnK0RacHRtOGZaTE5OYWNM?= =?utf-8?B?Y05GSFdhbFpWN2kwdGs0aDlCbW41dTNrL2FsSEIvSW0wWmcyekxZRTVrY3NI?= =?utf-8?B?Y01maHJLb3ZJMCtjRmdYbUtzNDdPdGlqc0ZoMjNmZDFuWmtwWVdCUjR6NWNL?= =?utf-8?B?ZjF5VjBaYWladFhtN2J0S3hGWHNqUUVOTHZsRGxKc2ZUUWlnNVVHVWcxVHFs?= =?utf-8?B?RG5JZ2lhK2J6bzhYSkRicm42cGdwQS9jRkJ2UDcvRXVHZ0VqVnlhc1lUdU1a?= =?utf-8?B?dlRtMVZtTUUyRTVFTEE0S1EzMmd0QWorSHE3NWRYVEJxdUh3VWV3alNCQ3Vv?= =?utf-8?B?S0xSN1VueXN4d1l1VDBYWFZJaWJIWjJTVnRRekVVYm83Q2tpbHFRNVhLR1Fa?= =?utf-8?B?Q2hPSWNMU2tLZXhZbnpqbmd0ejVBK2RrZXNtc2tLT1dEb3NaMHVZUU5Ga1ZC?= =?utf-8?B?SVFGZ0tuczh1MXk4T3QybkN1UnQweEtLU3JvVFNicTNJZTI4ekFjOWNrUE5D?= =?utf-8?B?amNwQmJpcnpJZDRvZHBRWnhIYW51eDZKemdJNitZMDdKQVVxL1dUMElsQmpx?= =?utf-8?B?dnZXdnlYaWtUNitkcEp0VmZDZTExKytYVVhJSE9mVUg2OXA2eUp6Slo5Y1pz?= =?utf-8?Q?DkglmFvVEmdbK0RxdTVeJSQptHiGlsOMnlgHSNX?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: b7774d84-fc14-4235-a792-08d971f8e396 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2021 12:13:23.5014 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: XXdSfbCYvgXozurmPaARtxlnRGuVKssWDwgdeKOzKQHuirdoSSd5NUtLJsjbmk5WNeJhUNtDrNo0pK29j9rxJA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4943 The code is unreachable for HVM or PVH, and it also makes little sense in auto-translated environments. On Arm, with xen_{create,destroy}_contiguous_region() both being stubs, I have a hard time seeing what good the Xen specific variant does - the generic one ought to be fine for all purposes there. Still Arm code explicitly references symbols here, so the code will continue to be included there. Instead of making PCI_XEN's "select" conditional, simply drop it - SWIOTLB_XEN will be available unconditionally in the PV case anyway, and is - as explained above - dead code in non-PV environments. This in turn allows dropping the stubs for xen_{create,destroy}_contiguous_region(), the former of which was broken anyway - it failed to set the DMA handle output. Signed-off-by: Jan Beulich --- a/arch/x86/Kconfig +++ b/arch/x86/Kconfig @@ -2605,7 +2605,6 @@ config PCI_OLPC config PCI_XEN def_bool y depends on PCI && XEN - select SWIOTLB_XEN config MMCONF_FAM10H def_bool y --- a/drivers/xen/Kconfig +++ b/drivers/xen/Kconfig @@ -177,6 +177,7 @@ config XEN_GRANT_DMA_ALLOC config SWIOTLB_XEN def_bool y + depends on XEN_PV || ARM || ARM64 select DMA_OPS select SWIOTLB --- a/include/xen/xen-ops.h +++ b/include/xen/xen-ops.h @@ -46,19 +46,7 @@ extern unsigned long *xen_contiguous_bit int xen_create_contiguous_region(phys_addr_t pstart, unsigned int order, unsigned int address_bits, dma_addr_t *dma_handle); - void xen_destroy_contiguous_region(phys_addr_t pstart, unsigned int order); -#else -static inline int xen_create_contiguous_region(phys_addr_t pstart, - unsigned int order, - unsigned int address_bits, - dma_addr_t *dma_handle) -{ - return 0; -} - -static inline void xen_destroy_contiguous_region(phys_addr_t pstart, - unsigned int order) { } #endif #if defined(CONFIG_XEN_PV) From xen-devel-bounces@lists.xenproject.org Tue Sep 07 12:17:00 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 12:17:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180978.327898 (Exim 4.92) (envelope-from ) id 1mNa24-00047Q-56; Tue, 07 Sep 2021 12:16:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180978.327898; Tue, 07 Sep 2021 12:16:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNa24-00047J-24; Tue, 07 Sep 2021 12:16:56 +0000 Received: by outflank-mailman (input) for mailman id 180978; Tue, 07 Sep 2021 12:16:54 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNa22-00047C-7A for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 12:16:54 +0000 Received: from mx0b-0039f301.pphosted.com (unknown [148.163.137.242]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 7c5f5902-0fd5-11ec-b0eb-12813bfff9fa; Tue, 07 Sep 2021 12:16:53 +0000 (UTC) Received: from pps.filterd (m0174681.ppops.net [127.0.0.1]) by mx0b-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 187BgonC004961; Tue, 7 Sep 2021 12:16:50 GMT Received: from eur01-he1-obe.outbound.protection.outlook.com (mail-he1eur01lp2056.outbound.protection.outlook.com [104.47.0.56]) by mx0b-0039f301.pphosted.com with ESMTP id 3ax2jnh7sr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 07 Sep 2021 12:16:50 +0000 Received: from AM7PR03MB6325.eurprd03.prod.outlook.com (2603:10a6:20b:13c::18) by AM7PR03MB6450.eurprd03.prod.outlook.com (2603:10a6:20b:1b2::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.22; Tue, 7 Sep 2021 12:16:46 +0000 Received: from AM7PR03MB6325.eurprd03.prod.outlook.com ([fe80::d9b7:c0ab:2c2f:5b44]) by AM7PR03MB6325.eurprd03.prod.outlook.com ([fe80::d9b7:c0ab:2c2f:5b44%3]) with mapi id 15.20.4478.025; Tue, 7 Sep 2021 12:16:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7c5f5902-0fd5-11ec-b0eb-12813bfff9fa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HaP2QAgMCTDubOczWTEKnaW5lqTzjcYi8TwhpbfZshnhrNitlrieg4079WGTO27jI5vfrZBLfk709ahprnQ4DbfpczejMVD85JnWOYXWEaYCSIYZMVLivaZFVTCQbi7ED4t8/NKf/Yec6NbNu62ozbw8SmB0emavGMcwmeN5MbC3+EbGolxvnMAa01s/B+GMwvji7WqPFJm7ZXoEiLwtIj52ImqsBIJkFCoVlXQ/d2f2phwP1PGmNsLNmCsbDC9B4IbwwjmcmjrmdrFE01gpEBL9g/+/T3DquUTZIpwrGUPiZbapJAPJBAPCvYYH5TqGzNcbMi9WWovKk7XrO7dHYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=ommb9VYJ3nFEfnB9d/KRAz9te3a2pOZjcQ4N2qrkwOA=; b=isoC+O4Br4MGmrAB1wJbozl01Ni9zZ8m7SdnqSsbnS4LdnkFwjSKImIQrEbGQk7rGx+EJz6BWwPGNGhVx5WypTnGgJzFamZyvUordEF7UK7C/ou12hIILfDO0zn1Xhi3Rts4VpFaywZ08fliJxHdUi3428JJ1sSboyNHKxNJe3SWZTSZUrBPAFNZuDu01XjE6a6MX82A/GDx5L8IuNH1+/v1TzmZe7IB64SECadEGkyzgy65qd+7bWEP2vcKZTZqGfiMGzp4lbBObJDIJoEIe+xdGEdrmKAf52zM7AgpWnlRnx0k9jGhcSPdgzN1r+AGMoip21JkbXYqmLrGkPNqEQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ommb9VYJ3nFEfnB9d/KRAz9te3a2pOZjcQ4N2qrkwOA=; b=CBgam0yohhTe01AD5kNOU0JSUKfO8xLbxfX+tlR2C6jK1a086g8GIOLbP4x10tSVUQWMVpDjX237m8UZVKnQ7hq8SSeML5VPmBmRR+fYXLALZRPr3MhQ7VX5fY4JEGUD86qxe0uE9bH7WPF5g9n2n54rjcIoGuy9bE91w495FelY67I+TBbD+INMh/X7W0MMztLYoXmBv4KnVpQOvIDPAJJP1IfO446bO89x0pBxmvoBejxhnvkOn/1MLVT0pVQkbzmEVemragwohKKSHupNO3ONZ90QHI1ZBntHUu3Lz6bc3kbqL2MEkbIbWZy3wTowTLIVIFsogNQrRNOYsGS/aQ== From: Oleksandr Andrushchenko To: Jan Beulich , Oleksandr Andrushchenko CC: "julien@xen.org" , "sstabellini@kernel.org" , Oleksandr Tyshchenko , Volodymyr Babchuk , Artem Mygaiev , "roger.pau@citrix.com" , Bertrand Marquis , Rahul Singh , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH 4/9] vpci/header: Add and remove register handlers dynamically Thread-Topic: [PATCH 4/9] vpci/header: Add and remove register handlers dynamically Thread-Index: AQHXoKusySJnLVveGkulaWKrBZdXpKuXEOQAgAFPE4CAAAkRAIAAB3eAgAALDQCAAAeQAA== Date: Tue, 7 Sep 2021 12:16:46 +0000 Message-ID: References: <20210903100831.177748-1-andr2000@gmail.com> <20210903100831.177748-5-andr2000@gmail.com> <8bb58d2d-255b-96e9-50ff-529985c655d5@suse.com> <16e396be-89f5-4d42-d57b-d91f09b70644@epam.com> <00bbe12b-6a79-e660-c5c1-57ccb200d2eb@suse.com> <242373cf-9854-74b7-4d54-bbcacc6cb7cb@epam.com> <938156e7-cbd0-a19e-f09f-a41dce051367@suse.com> In-Reply-To: <938156e7-cbd0-a19e-f09f-a41dce051367@suse.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=epam.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e21fe2b4-c39e-42c6-c929-08d971f95cd4 x-ms-traffictypediagnostic: AM7PR03MB6450: x-ms-exchange-transport-forked: True x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: tx42NoX7I0FjIqitNk9CCQyO3eUWeaSvuF+pkG6la+FGTviuA3hRvR0lo1TJV+Vnak3jg2waJyf6txgMNAsWK3O5KxcLqQhv+uMH28ihy01Rj3CuNs0FLZ8XXIB57+HvPUE7lbRJ2nsslggYdVbinhEkYUB63PbB/35GPU6CHMNtOdH1oZLxx+kQagdtaweanaQSPTgN6MxK+MbUFy/SrjDDlZJG7H0DtPNUaXntncxg4hIAxRnbX1d+lQ02spoj5IU6sAPty5ZMeBtJiqDaIMMbUUyTLvFF8lBibDfsO1DLDgGScM9vFwEYlQ3omfkrYx6r9OElVdVJ/LWsU44kqE018mGEAp40Vt/haYQjr6cqDTzdYEPLYxnVV1XX27UK7AqMJh8+yK8bdMlj2IMmuY1H4rfSVFUxdveHAXleL+9o6wreJ/ffxSMjz5I41+Ikj1t0v3ONSGaBbVqy8PEx8te2GG+is4k/0NMyajM/bdYrLDHpIidBDB2Wa7GCKfdMEKg3iRL5TBbNoramyF8etsE/GmKNgEHraRLQhnlolpyoNEVW4rpRO22hfAGFQO7o8wbpVc6T1lotLsWgHkjFOypF3fM3YsvAJaxwQ+Wb+sp23lRjTcV8ty+TeCXpeVH29RCqXd5G2iqibBezeGprMrkfK0I6BC5dA2v8Gf6Msjqic2FeLxrSaR58rekzHDW52hOX5TF1SS09VHK0+zbW7EGdM9Cq0tsuixxksRFGz79ceLK+4tMZoDwy0bcm9a1ZPn9buw/WursHEgYcBAZXJg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM7PR03MB6325.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(346002)(376002)(39860400002)(396003)(136003)(91956017)(316002)(122000001)(76116006)(4326008)(83380400001)(36756003)(5660300002)(38070700005)(54906003)(186003)(110136005)(66446008)(64756008)(66946007)(66556008)(38100700002)(6486002)(6506007)(2906002)(66476007)(31696002)(8676002)(6512007)(31686004)(8936002)(71200400001)(86362001)(2616005)(478600001)(26005)(53546011)(21314003)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?K0VLLzJpd1h6bTVPaDRaQTNta1NUajhrTmcvUUFGZ2tLc1g4QWFZUlY5Qm9C?= =?utf-8?B?eklHT3RZVTRRQ2hTY1hzb3NBTHpUeGVTWkIyMkFOdTZ6MEl4c3QxcGhqWWNR?= =?utf-8?B?SHMwcE13RFh3MGw1MG9nVTIxNENjY1c0bEhGUHRoeERiM1grVzJLMUdPUHdt?= =?utf-8?B?dDhlN1ZvWnFGcTZDSFhOSk5vS01TZkVzSVlkTHQ4c3k3TTNheXRsTjREWERk?= =?utf-8?B?NTRUM0Z0aWlWSzBFc2doTDcwb2E2cmtuVmQzV1NQOGhZWW00Y1diU1Vid0x3?= =?utf-8?B?SURlamN6a0wyQlBqWTMvRndPSmVhellRemQyemZhcVJYYTNRcTNXeHlxN3RP?= =?utf-8?B?NVNjbUtYZVBQY1FMUDlzbGh3QnYwNXZ4ZjBGZzZiK0dRZjRtVGZrNWtQMEFy?= =?utf-8?B?WTRkTEtFbDhjb2x2ZGw5MUM4Sm11SXhKRzQvZlZFL3JXa3lPV242T2J2R3o2?= =?utf-8?B?Wjl4MDF3Sml6U3lUbzBFZEJKd2VwVjNYVjFSMHQ5eS9jTTFKRkY2eWEvd2x6?= =?utf-8?B?SmZxMVdqM1NnT0ZGbDRuMm5BWjgramFXZ1FheEx0dU5TMUlDQmhwemwvOUIr?= =?utf-8?B?UHpQVTBKdXg4UW9mU3lhUWMzMXpVaFd0QmVzMCtaZGErQXlFbEV1Z0Q3VzFq?= =?utf-8?B?S0lpQ2NsVTc0Y1c0ajEvbkpFK1J0NnorMStuK3VhNnBRZHFZNWxVQklHNFJa?= =?utf-8?B?TW9TRnk3YkRjYklYWFAvTmJ6ckt1enpKbmw2NXgyS3JUSEZrUzlyb1ArZFRy?= =?utf-8?B?anNZUWRPay83UjlWRGZsZVJ4VFFETDBnKzdxL0EzQXNMbDUvbDZzakllTHps?= =?utf-8?B?V0tpN3p5R2pBQlRROU1EUDNUSEpweVZRMmY2U2NzanVVdzRFYndpVjdYVnlK?= =?utf-8?B?L21BaHVIZGZIZUZxaXp2WjVNQUJra1psMVhwWC9QaDZPODJHWkFTcDlJbGFI?= =?utf-8?B?bjZja2dreGhodENWWUszOE5PdEpwRkFXcjJRdFlMYTc4Qml0c2U1elFWOTJz?= =?utf-8?B?dU9ZMU1qbjJsbkZqbHl6bTl1eWZDemVyYkJJa09UU1NBRHRSS2w4dUFRTXNL?= =?utf-8?B?WWtyakxGZlpQZTNpZzF6WmRVVkVZeDJHOGtqTVNvRmlzbnBFMk1mS2FFUlNR?= =?utf-8?B?emZiS0EzWXRXWDZ6NlhqczU4OWxFU2RCU2dIVlF0TjB1cEw2L0RsNDN1eTgv?= =?utf-8?B?bnV0SU9tRnJocEdvNmtjNFpRQ213NkFtUlZLM1BVdEcvTFhDN2I3ZlJhRys1?= =?utf-8?B?eXBHR2FRMko2TXhESVVHa2d1RCs2YXBVSXJWSnJEWG4weUFJbXdZcjB3TDJo?= =?utf-8?B?S1pGNGpaVjFFNmVOSVNnR1o0MCtEZDFQSnZJdmczVTF4dndEWmZKaTdxd2J5?= =?utf-8?B?VTQ5SjhQcnpCR1F5YWs1b0ZvQ0oxRFEzVEtLMkMySWYxSTZML3JWSkNPaUFz?= =?utf-8?B?TlNCVTBqS2ZNaW1Bbm9kMHd5M0pkTFZGbjIzMDlsUmpNaUV6cW1OQ2IvSWNI?= =?utf-8?B?TWxvR2Vxbk5BaDE5VUZSQUhLYlVFTEZDcDRUeW50dEJwRU5XOGFQQXFocGpV?= =?utf-8?B?WmptMGxuVzF3b3dqRkowWlNvVi9wVStrOFhKcmdQVWFkaEN4TlkrbEV1MVhK?= =?utf-8?B?NXBKNU5NUVpOWkZ0YjFBN0drbjJRZ1NYUTZibUJnWjNxSTlDZ3Z2aUJlc2do?= =?utf-8?B?cWJxaHQzUFByVzN2S2VPVGprK3hPSDVQVmdOU21na1ROWFBqdWtRaWZUV2VX?= =?utf-8?Q?/ANIPw8gohoGNQTNGcTeV92/oCJfZyOlVnbTY5o?= Content-Type: text/plain; charset="utf-8" Content-ID: <11F4B582EC09F64BAB396447186E638B@eurprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: epam.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM7PR03MB6325.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e21fe2b4-c39e-42c6-c929-08d971f95cd4 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Sep 2021 12:16:46.5998 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: EWcZsNY6nGUPyRO1Mr1KmrMl7MH49sFpNwOiRqHqpqp+Yy0zhlmRrGHgxtO7FizL59j6pvPTv5DwERvrpi5MzZ5INMrvV91z2U1KOPnGcZ+nwpSn3N221JHEeTZ/fFFN X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR03MB6450 X-Proofpoint-ORIG-GUID: uHPeS_bhTxsLI5KWF_woXqr_7g0YftxV X-Proofpoint-GUID: uHPeS_bhTxsLI5KWF_woXqr_7g0YftxV X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.391,FMLib:17.0.607.475 definitions=2021-09-07_04,2021-09-07_01,2020-04-07_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 adultscore=0 clxscore=1015 priorityscore=1501 impostorscore=0 phishscore=0 spamscore=0 suspectscore=0 lowpriorityscore=0 mlxlogscore=999 bulkscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2108310000 definitions=main-2109070081 DQpPbiAwNy4wOS4yMSAxNDo0OSwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDA3LjA5LjIwMjEg MTM6MTAsIE9sZWtzYW5kciBBbmRydXNoY2hlbmtvIHdyb3RlOg0KPj4gT24gMDcuMDkuMjEgMTM6 NDMsIEphbiBCZXVsaWNoIHdyb3RlOg0KPj4+IE9uIDA3LjA5LjIwMjEgMTI6MTEsIE9sZWtzYW5k ciBBbmRydXNoY2hlbmtvIHdyb3RlOg0KPj4+PiBPbiAwNi4wOS4yMSAxNzoxMSwgSmFuIEJldWxp Y2ggd3JvdGU6DQo+Pj4+PiBPbiAwMy4wOS4yMDIxIDEyOjA4LCBPbGVrc2FuZHIgQW5kcnVzaGNo ZW5rbyB3cm90ZToNCj4+Pj4+PiBAQCAtNTkzLDYgKzYyNSwzNiBAQCBzdGF0aWMgaW50IGluaXRf YmFycyhzdHJ1Y3QgcGNpX2RldiAqcGRldikNCj4+Pj4+PiAgICAgfQ0KPj4+Pj4+ICAgICBSRUdJ U1RFUl9WUENJX0lOSVQoaW5pdF9iYXJzLCBWUENJX1BSSU9SSVRZX01JRERMRSk7DQo+Pj4+Pj4g ICAgIA0KPj4+Pj4+ICtpbnQgdnBjaV9iYXJfYWRkX2hhbmRsZXJzKGNvbnN0IHN0cnVjdCBkb21h aW4gKmQsIHN0cnVjdCBwY2lfZGV2ICpwZGV2KQ0KPj4+Pj4+ICt7DQo+Pj4+Pj4gKyAgICBpbnQg cmM7DQo+Pj4+Pj4gKw0KPj4+Pj4+ICsgICAgLyogUmVtb3ZlIHByZXZpb3VzbHkgYWRkZWQgcmVn aXN0ZXJzLiAqLw0KPj4+Pj4+ICsgICAgdnBjaV9yZW1vdmVfZGV2aWNlX3JlZ2lzdGVycyhwZGV2 KTsNCj4+Pj4+PiArDQo+Pj4+Pj4gKyAgICAvKiBJdCBvbmx5IG1ha2VzIHNlbnNlIHRvIGFkZCBy ZWdpc3RlcnMgZm9yIGh3ZG9tIG9yIGd1ZXN0IGRvbWFpbi4gKi8NCj4+Pj4+PiArICAgIGlmICgg ZC0+ZG9tYWluX2lkID49IERPTUlEX0ZJUlNUX1JFU0VSVkVEICkNCj4+Pj4+PiArICAgICAgICBy ZXR1cm4gMDsNCj4+Pj4+PiArDQo+Pj4+Pj4gKyAgICBpZiAoIGlzX2hhcmR3YXJlX2RvbWFpbihk KSApDQo+Pj4+Pj4gKyAgICAgICAgcmMgPSBhZGRfYmFyX2hhbmRsZXJzKHBkZXYsIHRydWUpOw0K Pj4+Pj4+ICsgICAgZWxzZQ0KPj4+Pj4+ICsgICAgICAgIHJjID0gYWRkX2Jhcl9oYW5kbGVycyhw ZGV2LCBmYWxzZSk7DQo+Pj4+PiAgICAgICAgcmMgPSBhZGRfYmFyX2hhbmRsZXJzKHBkZXYsIGlz X2hhcmR3YXJlX2RvbWFpbihkKSk7DQo+Pj4+IEluZGVlZCwgdGhhbmsgeW91IDspDQo+Pj4+Pj4g KyAgICBpZiAoIHJjICkNCj4+Pj4+PiArICAgICAgICBncHJpbnRrKFhFTkxPR19FUlIsDQo+Pj4+ Pj4gKyAgICAgICAgICAgICIlcHA6IGZhaWxlZCB0byBhZGQgQkFSIGhhbmRsZXJzIGZvciBkb20l ZFxuIiwgJnBkZXYtPnNiZGYsDQo+Pj4+Pj4gKyAgICAgICAgICAgIGQtPmRvbWFpbl9pZCk7DQo+ Pj4+PiBQbGVhc2UgdXNlICVwZCBhbmQgY29ycmVjdCBpbmRlbnRhdGlvbi4gTG9nZ2luZyB0aGUg ZXJyb3IgY29kZSBtaWdodA0KPj4+Pj4gYWxzbyBoZWxwIHNvbWUgaW4gZGlhZ25vc2luZyBpc3N1 ZXMuDQo+Pj4+IFN1cmUsIEknbGwgY2hhbmdlIGl0IHRvICVwZA0KPj4+Pj4gICAgIEZ1cnRoZXIg SSdtIG5vdCBzdXJlIHRoaXMgaXMgYQ0KPj4+Pj4gbWVzc2FnZSB3ZSB3YW50IGluIHJlbGVhc2Ug YnVpbGRzDQo+Pj4+IFdoeSBub3Q/DQo+Pj4gRXhjZXNzIHZlcmJvc2l0eTogSWYgd2UgaGF2ZSBz dWNoIGhlcmUsIHdoeSBub3QgZWxzZXdoZXJlIG9uIGVycm9yIHBhdGhzPw0KPj4+IEFuZCBJIGhv cGUgeW91IGFncmVlIHRoaW5ncyB3aWxsIGdldCB0b28gdmVyYm9zZSBpZiB3ZSBoYWQgc3VjaCAo YWJvdXQpDQo+Pj4gZXZlcnl3aGVyZT8NCj4+IEFncmVlLCB3aWxsIGNoYW5nZSBpdCB0byBnZHBy aW50aw0KPj4+Pj4gICAgIC0gcGVyaGFwcyBnZHByaW50aygpPw0KPj4+PiBJJ2xsIGNoYW5nZSBp ZiB3ZSBkZWNpZGUgc28NCj4+Pj4+PiArICAgIHJldHVybiByYzsNCj4+Pj4+PiArfQ0KPj4+Pj4+ ICsNCj4+Pj4+PiAraW50IHZwY2lfYmFyX3JlbW92ZV9oYW5kbGVycyhjb25zdCBzdHJ1Y3QgZG9t YWluICpkLCBzdHJ1Y3QgcGNpX2RldiAqcGRldikNCj4+Pj4+PiArew0KPj4+Pj4+ICsgICAgLyog UmVtb3ZlIHByZXZpb3VzbHkgYWRkZWQgcmVnaXN0ZXJzLiAqLw0KPj4+Pj4+ICsgICAgdnBjaV9y ZW1vdmVfZGV2aWNlX3JlZ2lzdGVycyhwZGV2KTsNCj4+Pj4+PiArICAgIHJldHVybiAwOw0KPj4+ Pj4+ICt9DQo+Pj4+PiBBbHNvIC0gaW4gaG93IGZhciBpcyB0aGUgZ29hbCBvZiB5b3VyIHdvcmsg dG8gYWxzbyBtYWtlIHZQQ0kgd29yayBmb3INCj4+Pj4+IHg4NiBEb21VLXM/IElmIHRoYXQncyBu b3QgYSBnb2FsDQo+Pj4+IEl0IGlzIG5vdCwgdW5mb3J0dW5hdGVseS4gVGhlIGdvYWwgaXMgbm90 IHRvIGJyZWFrIHg4NiBhbmQgdG8gZW5hYmxlIEFybQ0KPj4+Pj4gLCBJJ2QgbGlrZSB0byBhc2sg dGhhdCB5b3UgbGltaXQgdGhlDQo+Pj4+PiBpbnRyb2R1Y3Rpb24gb2YgY29kZSB0aGF0IGVuZHMg dXAgZGVhZCB0aGVyZS4NCj4+Pj4gV2hhdCdzIHdyb25nIHdpdGggdGhpcyBmdW5jdGlvbiBldmVu IGlmIGl0IGlzIGEgb25lLWxpbmVyPw0KPj4+IFRoZSBjb21tZW50IGlzIHByaW1hcmlseSBvbiB0 aGUgZWFybGllciBmdW5jdGlvbiwgYW5kIHRoZW4gZXh0ZW5kcyB0bw0KPj4+IHRoaXMgb25lLg0K Pj4+DQo+Pj4+IFRoaXMgd2F5IHdlIGhhdmUgYSBwYWlyIHZwY2lfYmFyX2FkZF9oYW5kbGVycy92 cGNpX2Jhcl9yZW1vdmVfaGFuZGxlcnMNCj4+Pj4gYW5kIGlmIEkgdW5kZXJzdG9vZCBjb3JyZWN0 bHkgeW91IHN1Z2dlc3QgdnBjaV9iYXJfYWRkX2hhbmRsZXJzL3ZwY2lfcmVtb3ZlX2RldmljZV9y ZWdpc3RlcnM/DQo+Pj4+IFdoYXQgd291bGQgd2UgZ2FpbiBmcm9tIHRoYXQsIGJ1dCB5ZXQgYW5v dGhlciBzZWNyZXQga25vd2xlZGdlIHRoYXQgaW4gb3JkZXINCj4+Pj4gdG8gcmVtb3ZlIEJBUiBo YW5kbGVycyBvbmUgbmVlZHMgdG8gY2FsbCB2cGNpX3JlbW92ZV9kZXZpY2VfcmVnaXN0ZXJzDQo+ Pj4+IHdoaWxlIEkgd291bGQgcGVyc29uYWxseSBleHBlY3QgdG8gY2FsbCB2cGNpX2Jhcl9hZGRf aGFuZGxlcnMnIGNvdW50ZXJwYXJ0LA0KPj4+PiB2cGNpX3JlbW92ZV9kZXZpY2VfcmVnaXN0ZXJz IG5hbWVseS4NCj4+PiBUaGlzIGlzIGFsbCBmaW5lLiBZZXQgdnBjaV9iYXJfe2FkZCxyZW1vdmV9 X2hhbmRsZXJzKCkgd2lsbCwgYWl1aSwgYmUNCj4+PiBkZWFkIGNvZGUgb24geDg2Lg0KPj4gdnBj aV9iYXJfYWRkX2hhbmRsZXJzIHdpbGwgYmUgdXNlZCBieSB4ODYgUFZIIERvbTANCj4gV2hlcmUg LyB3aGVuPyBZb3UgYWRkIGEgY2FsbCBmcm9tIHZwY2lfYXNzaWduX2RldmljZSgpLCBidXQgYmVz aWRlcyB0aGF0DQo+IGFsc28gYmVpbmcgZGVhZCBjb2RlIG9uIHg4NiAoZm9yIG5vdyksIHlvdSBj YW4ndCBtZWFuIHRoYXQgYmVjYXVzZQ0KPiB2cGNpX2RlYXNzaWduX2RldmljZSgpIGFsc28gY2Fs bHMgdnBjaV9iYXJfcmVtb3ZlX2hhbmRsZXJzKCkuDQoNCllvdSBhcmUgcmlnaHQgaGVyZSBhbmQg Ym90aCBhZGQvcmVtb3ZlIGFyZSBub3QgdXNlZCBvbiB4ODYgUFZIIERvbTAuDQoNCkkgYW0gc29y cnkgZm9yIHdhc3RpbmcgeW91ciB0aW1lDQoNCj4NCj4+PiAgICBIZW5jZSB0aGVyZSBzaG91bGQg YmUgYW4gYXJyYW5nZW1lbnQgYWxsb3dpbmcgdGhlDQo+Pj4gY29tcGlsZXIgdG8gZWxpbWluYXRl IHRoaXMgZGVhZCBjb2RlLg0KPj4gU28sIHRoZSBvbmx5IGRlYWQgY29kZSBmb3IgeDg2IGhlcmUg d2lsbCBiZSB2cGNpX2Jhcl9yZW1vdmVfaGFuZGxlcnMuIFlldC4NCj4+IEJlY2F1c2UgSSBob3Bl IHg4NiB0byBnYWluIGd1ZXN0IHN1cHBvcnQgZm9yIFBWSCBEb20wIHNvb25lciBvciBsYXRlci4N Cj4+DQo+Pj4gICAgV2hldGhlciB0aGF0J3MgZW5jbG9zaW5nIHRoZXNlDQo+Pj4gYnkgIiNpZmRl ZiIgb3IgYWRkaW5nIGVhcmx5ICJpZighSVNfRU5BQkxFRChDT05GSUdfKikpIiBpcyBzZWNvbmRh cnkuDQo+Pj4gVGhpcyBoYXMgYSBrbm9jay1vbiBlZmZlY3Qgb24gb3RoZXIgZnVuY3Rpb25zIGFz IHlvdSBjZXJ0YWlubHkgcmVhbGl6ZToNCj4+PiBUaGUgY29tcGlsZXIgc2VlaW5nIGUuZy4gdGhl IDJuZCBhcmd1bWVudCB0byB0aGUgYWRkLUJBUnMgZnVuY3Rpb24NCj4+PiBhbHdheXMgYmVpbmcg dHJ1ZSBhbGxvd3MgaXQgdG8gaW5zdGFudGlhdGUganVzdCBhIGNsb25lIG9mIHRoZSBvcmlnaW5h bA0KPj4+IGZ1bmN0aW9uIHdpdGggdGhlIHJlc3BlY3RpdmUgY29uZGl0aW9uYWxzIHJlbW92ZWQu DQo+PiBXaXRoIHRoZSBhYm92ZSAoZS5nLiBhZGQgaXMgZ29pbmcgdG8gYmUgdXNlZCwgYnV0IG5v dCByZW1vdmUpIGRvIHlvdQ0KPj4gdGhpbmsgaXQgaXMgd29ydGggcGxheWluZyB3aXRoIGlmZGVm J3MgdG8gc3RyaXAgdGhhdCBzaW5nbGUgZnVuY3Rpb24gYW5kIGFkZA0KPj4gYSBwaWVjZSBvZiBz cGFnaGV0dGkgY29kZSB0byBzYXZlIGEgYml0Pw0KPiBObywgdGhhdCBJIGFncmVlIHdvdWxkbid0 IGJlIHdvcnRoIGl0Lg0KPg0KPj4gV2hhdCB3b3VsZCB0aGF0IGlmZGVmIGxvb2sgbGlrZSwNCj4+ IGUuZy4gI2lmZGVmIENPTkZJR19BUk0gb3IgI2lmbmRlZiBDT05GSUdfWDg2ICYmIGFueSBvdGhl ciBwbGF0Zm9ybSwgYnV0IEFSTT8NCj4gQSBuZXcgc2V0dGluZywgcHJlZmVyYWJseTsgZS5nLiBW Q1BVX1VOUFJJVklMRUdFRCwgdG8gYmUgInNlbGVjdCJlZCBieQ0KPiBhcmNoaXRlY3R1cmVzIGFz IGZ1bmN0aW9uYWxpdHkgZ2V0cyBlbmFibGVkLg0KDQpTbywgYXMgYWRkL3JlbW92ZSBhcmUgb25s eSBuZWVkZWQgZm9yIEFybSBhdCB0aGUgbW9tZW50DQoNCnlvdSBzdWdnZXN0IEkgYWRkIFZDUFVf VU5QUklWSUxFR0VEIHRvIEFybSdzIEtjb25maWcgdG8gZW5hYmxlDQoNCmNvbXBpbGluZyB2cGNp X2Jhcl9hZGRfaGFuZGxlcnMvdnBjaV9iYXJfcmVtb3ZlX2hhbmRsZXJzPw0KDQpUbyBtZSB0aGlz IGlzIG1vcmUgYWJvdXQgdlBDSSdzIHN1cHBvcnQgZm9yIGd1ZXN0cywgc28gc2hvdWxkIHdlIHBy b2JhYmx5IGNhbGwgaXQNCg0KVlBDSV9YWFggaW5zdGVhZD8gRS5nLiBWUENJX0hBU19HVUVTVF9T VVBQT1JUIG9yIHNvbWV0aGluZyB3aGljaA0KDQp3aWxsIHJlZmxlY3QgdGhlIG5hdHVyZSBvZiB0 aGUgY29kZSBiZWluZyBnYXRlZD8gVkNQVV9VTlBSSVZJTEVHRUQgc291bmRzDQoNCmxpa2Ugbm90 IGNvbm5lY3RlZCB0byB2cGNpIHRvIG1lDQoNCj4NCj4gSmFuDQo+DQpUaGFuayB5b3UsDQoNCk9s ZWtzYW5kcg0K From xen-devel-bounces@lists.xenproject.org Tue Sep 07 12:17:20 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 12:17:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180980.327910 (Exim 4.92) (envelope-from ) id 1mNa2S-0004en-EJ; Tue, 07 Sep 2021 12:17:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180980.327910; Tue, 07 Sep 2021 12:17:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNa2S-0004eg-Aa; Tue, 07 Sep 2021 12:17:20 +0000 Received: by outflank-mailman (input) for mailman id 180980; Tue, 07 Sep 2021 12:17:18 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNa2Q-0004eE-KV for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 12:17:18 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 9d943efb-468f-41e2-b01a-a931ddafbd61; Tue, 07 Sep 2021 12:17:17 +0000 (UTC) Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-am5eur03lp2059.outbound.protection.outlook.com [104.47.8.59]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-5-ynG92t5GMuyY6Ok5QxIYCQ-1; Tue, 07 Sep 2021 14:17:16 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR04MB5167.eurprd04.prod.outlook.com (2603:10a6:803:5b::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.24; Tue, 7 Sep 2021 12:17:14 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4500.014; Tue, 7 Sep 2021 12:17:14 +0000 Received: from [10.156.60.236] (37.24.206.209) by FRYP281CA0016.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.4 via Frontend Transport; Tue, 7 Sep 2021 12:17:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9d943efb-468f-41e2-b01a-a931ddafbd61 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1631017037; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=3ipn8V6nm60M68/u9CKRAsm4Z70Kt+Rd/n32FD4uhi8=; b=PQvM20lBak2oM9lxT10OCWEacoyR54yuXM/tBcOUzxZ717k4qixkoyeL692Fohr/yVhufJ GnVksV4pyRmEGHEvShpeDX2eAEuKOEJll2R9GY1cMRHBAutP3M1dg0aRHDKv2KrZxF+Gkj hV0G1XnG7aYHnKeOae7oXem9CL4DpXQ= X-MC-Unique: ynG92t5GMuyY6Ok5QxIYCQ-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=k2/D0YK4Piymd4IYGSPPnaSuBPsLXM4g+bpydY5WVRFwRZTCR7LHm+1p2LylvxoaxlGKNwYyZn0z+MUI94e01r4pe90eRfBnKILaf3PQW8MRk3cYqhJTyRvv5ormM6lKP6AzXzBDl3RIt1BlEtvA8miVylPzFbttD/ammt1the9WOVCsz6KV/upY39/vvi7TYNPXQnmyGMtee3lGX1qKfOXQIk6ZdEZNDaLT3oTk81X+GeTVYGQzEGlD53+rOWN43kxhYnvLmDn5KGgL9UppBPL54ff7UFVk6IfodGUmL3xb/EniU93Cc5oo6cHrHcy4Tvgh92r/J0xhIHMzME3pog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=3ipn8V6nm60M68/u9CKRAsm4Z70Kt+Rd/n32FD4uhi8=; b=eJ2mb8DH+0p3F8SOxYXO5OJwCi4WWiSAEA6T3NdLKtnNOIzjFJ+1PQbZ96IWhUNWUHQrQTyzngeb5cflatDgoGXuptwj+kzwN2OzAhGtGG+vWIK4dYqtmEkmSwYZt6lkOCu3KRap8P8RoWvYUhkO7mC2pkSjaLvbJQndDlPsxX3Qhf33Nj3Yph2uOXKr2dm0QUDRw7xOigl5EooQH5Zl0bodEfiJ/zyJHeeU1b1wgSi/UXOf1d0UrObSQj0n8EHGTBb1P4veeedQ/6VdKMgt5Fs9ZrVdMtnUCjXG5Hu1cR9HfZh8h1BZ2L5mCg1TDd7vDpXL5wNiay9/w8E2LZV9+A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com; To: Juergen Gross , Boris Ostrovsky Cc: Stefano Stabellini , lkml , "xen-devel@lists.xenproject.org" From: Jan Beulich Subject: [PATCH] xen/pvcalls: backend can be a module Message-ID: <54a6070c-92bb-36a3-2fc0-de9ccca438c5@suse.com> Date: Tue, 7 Sep 2021 14:17:13 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FRYP281CA0016.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10::26) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c6d24a79-3689-461a-4955-08d971f96d81 X-MS-TrafficTypeDiagnostic: VI1PR04MB5167: X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6108; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dKXCZSWhcx7GZDxjf8ctU81O3byUk595YyebVbpiEYxN2DQ/8P8TgUfZfWTLZVAAN1y9cXdW2spc0dLLDGIQE+9lY1RfBAtLeFK6mySywXuBXe34XQvnHmLZLvVGWv09c11npTA6XBrfsdwxVGE56OCANEE4O4s/WyGy8vJC0oiJOtkhcRnzr4vQLdgijsgKDrwxcrqZWiuDYTU8mnQr7/W8WRElBIxBAMtFSwJlKpki04x7Wi2QGOdCbSP+9iwkeX12u+hMdQfLccW66R6QFy3B9ickxSesa7pCNtWItDK7cX4FKWMR0o5vJrlXz+J4Z7VZhsyaz8xB+UNi1e7FuZqWmixsZG9rDag8uEApRlzjR7QF3EpMMe3c/P697CK5Ulx3lGEHStmPdLzzXfWAtDYyl4y7ezL9RlNYVgvOQoqunvtvQgbFQyIZV93JaOcIwlwscPSQM8Od5AdnonpXSMzQCNU6YFuOrEOhzjhCVHLEo4J/v9bADlzo7zTEDQYAkbBN0qV0eWXycDCNFONEnFvaCjLd727+VL+FzG5cY/KDvqLDTdUW1yGTXx7oibePhGmplrjAKBnoTj9HrTHXHPEiVv/F/tbrFl4TSpRk26i7gL+fVtyoCMnKJaKwPNYZ/OH5qb/FEYqZzZzDBQg2x+3jPTH3Qlo9taKxtti4wMaa5Bz/wRwm2aEnSl4AdtYGCNiaRhmRSFiqWZ5XlRyhuMcdLe2TxgfFK+ufUf769EU= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(6486002)(4744005)(66946007)(36756003)(26005)(186003)(31686004)(31696002)(8936002)(86362001)(2616005)(956004)(8676002)(5660300002)(110136005)(66476007)(66556008)(508600001)(16576012)(2906002)(38100700002)(316002)(4326008)(54906003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QzdMNjFBMHY2UzdqbmNuaXJEYXdMUzhXRk42ajBPYTV4cG9CUmlYTTRmNkVu?= =?utf-8?B?WlRSaWtIK3hDZFV0WWxhMjI3YWpiampzZ25NTUpCdmI5RndsUTJ6VENJMkE4?= =?utf-8?B?bzhqWlh5WHB6SDY4UkFYbXkvemxUQ3JKV2ttK1ZPOG4vN05rem1KaERVNk1x?= =?utf-8?B?RHdDYjczTk1TRk50UHZrTVFBT2NuMWZwS0k2WXV5ZzBsOUQ5T3ZLbnBiWExv?= =?utf-8?B?Wi90d241cFJydnNYbXEvNWxEMW12bmlYS0VBUVZhOEhTK0d0TzZ2NFEvN3hn?= =?utf-8?B?TTRxUHJuVFBpZzUrMkw2dkp1YzBZb3BPOUVISmNjcVFvTjFmTjBIUlJ2cEdq?= =?utf-8?B?d0RZS1dDajlUYlFQaThFTTVUKzB3bytzM1J5M1RIaldTeVBGZFprTTN2NlZ4?= =?utf-8?B?cW1IcGxtK1ZGZjhsSFUyek5yUiszampBaW5KaTAvTjJGcGsrYzlkdDA3c2cy?= =?utf-8?B?T2t5b1dxQ3pUbWdqSm1QMVdBbVdkZXZFTTB6UFZuaDBPVmM4dGluSlVrYmpw?= =?utf-8?B?OTVKV3EzdlhFcko0UW5hNkpjZnhKeXZMcEVKTnBCdG53bFUwYW1YV2sxWWNP?= =?utf-8?B?aC8zcGIrT0N2cldZSHJ4bzhZRDV5R3p3V1Q4TnY0aVZoNlJKZlg1bHg2cS9F?= =?utf-8?B?SElpMHlqVVlEVFpXNnlwOUxnVjJENmdDYmJNRFYrRDdYdEU0Q1BEMWNtUzVT?= =?utf-8?B?bUdQVi9FZlVycTJianpBbjE3YkxZeEJvV2pPZThBYXJGSjI5bTlGZ2lJRlgr?= =?utf-8?B?ZFFCaXhEUWx2VXQrL1NkL3NpOFREZkJmVkNUQnRCMTc3eDdXWmdFRmdoL0ht?= =?utf-8?B?a2tkU2RhS3cvVERxRTVEQ1JIUStmMlE1cDJNNVZpQ1BaUW9WQndvNU1TdHE0?= =?utf-8?B?cTA2UlkxbG1jSkt5alh4NFhRdnRGa2U1QVAyakNudlZWT0VzTWdBQ2VIanFC?= =?utf-8?B?bGhtakgwMzQvbXRtbHFRTGZDYW5zdHl4OXdiU2xMMTBjZHRVTm9BZGRpbjI2?= =?utf-8?B?UVpVOG9pcFQ4VDhRQzN5bzdqU2JQcXAxelFEVkJQYkNIeW90SzE2VDJFSEsr?= =?utf-8?B?bGExS01DV3FZR1Q1Mll0UWtwSFR0SXpvVld4enhZSTVvVUFSWGRIQ0Jlc1V1?= =?utf-8?B?RS9ZUWtOVmFTR0NhQlhkcTl3NHNqbThoQ2RVcTRSSm5MZGMzb1drc0MwZ2tT?= =?utf-8?B?d1JPMlRRU1N6S1hNSTB5ZHArNkxWUEhEdHJNcGVKQjJ0dHorTFhpbXh5WXpO?= =?utf-8?B?TVFGdWxzc3llZEhMYkRlZkJINHVXSzBPR1I5RGZZa1cwT2hxVG9UME4xQkF4?= =?utf-8?B?RjhLZ2NrWDFVZ0dDYWRWSjloSnpWTWlTT2EzZ0w1cTBxaXBxZkVVcTZnZ0hy?= =?utf-8?B?Mk5QemF1aVJvMkZ4UGhrQjRodUJiWm90cU1MK213WUJsNnhsVGphNUpYZG12?= =?utf-8?B?RUVVMjlUS05qNi9BU3Z3b3c5K3hMcEIreG1rcG9YUE9CTTFDUGE1eWZWb1Fn?= =?utf-8?B?NmlwOVptYmw0VTVJZE5oZHJjSkhwYWZHdTB6QWQvOStQUE1WSzNpTk9NV293?= =?utf-8?B?TVB0ZktSaE5vcEZEaWxRN0dTaHUyT3l0SUNLTCtrV3BJSFFZa0orZmFiWC91?= =?utf-8?B?YXVyYVpLdWxrUVl6dmJpYVpCNEhIdVlMaE1MNUxUVGV5NnF4S0xkWldrODgw?= =?utf-8?B?bVR1QWRtbDVybjlGTVl3NkRFcXdMUU1ZNlozc2dWb2Q2Q3pvZ3ZkWkFNMzVT?= =?utf-8?Q?dDqB7Jp0rT2zc2ec6e7OtK5PloxE22JlaUo06mW?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: c6d24a79-3689-461a-4955-08d971f96d81 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2021 12:17:14.8640 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: qyYhDfgmVp5Amf3Ybl/g+1qZhBdykNGIiV3Ow3rZUsg7gAAXf4azQIB58EM4UtJrKMb8vmd0isW+P+BgiFTVuQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5167 It's not clear to me why only the frontend has been tristate. Switch the backend to be, too. Signed-off-by: Jan Beulich --- a/drivers/xen/Kconfig +++ b/drivers/xen/Kconfig @@ -214,7 +214,7 @@ config XEN_PVCALLS_FRONTEND implements them. config XEN_PVCALLS_BACKEND - bool "XEN PV Calls backend driver" + tristate "XEN PV Calls backend driver" depends on INET && XEN && XEN_BACKEND help Experimental backend for the Xen PV Calls protocol From xen-devel-bounces@lists.xenproject.org Tue Sep 07 12:20:37 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 12:20:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180991.327921 (Exim 4.92) (envelope-from ) id 1mNa5c-00069q-2X; Tue, 07 Sep 2021 12:20:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180991.327921; Tue, 07 Sep 2021 12:20:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNa5b-00069j-Uf; Tue, 07 Sep 2021 12:20:35 +0000 Received: by outflank-mailman (input) for mailman id 180991; Tue, 07 Sep 2021 12:20:34 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNa5a-00069d-Ly for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 12:20:34 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id ff3fde82-0fd5-11ec-b0ec-12813bfff9fa; Tue, 07 Sep 2021 12:20:33 +0000 (UTC) Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-am5eur03lp2058.outbound.protection.outlook.com [104.47.8.58]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-8-6oMtLmXNOI67S5XH6MHvJg-1; Tue, 07 Sep 2021 14:20:31 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR04MB5167.eurprd04.prod.outlook.com (2603:10a6:803:5b::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.24; Tue, 7 Sep 2021 12:20:30 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4500.014; Tue, 7 Sep 2021 12:20:30 +0000 Received: from [10.156.60.236] (37.24.206.209) by AM0PR04CA0074.eurprd04.prod.outlook.com (2603:10a6:208:be::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Tue, 7 Sep 2021 12:20:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ff3fde82-0fd5-11ec-b0ec-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1631017232; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wOo934swFYPJYytLsLK7LxicndHY3S6qCxAIAYTwKao=; b=BdsFBVHImLm1iUAZU8KtAJYLKE1WiQzIcoUmXgiOKellqhiurPtxMdjMRGQ14a/V3SB3Bf nShNUhY5HMfXb1t+FnI1Uj3JaQUBpnEq4jHylOZ9caXUkgN0VGDtlEWooQG/diP54RfH3a OVYV+mVOqUNh77viXyciTy63SILyL/I= X-MC-Unique: 6oMtLmXNOI67S5XH6MHvJg-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=H0XAC/1buMfHNfuTp6lcySLLCKJ26HRv19rypIzje4uceXbmcIq9nGbHoYuhXpTFJ7wyxxm4KJLmzHglO2f/Y50QSPFE2bbwy9eN2mfF4dS4icuXPesd7/b0EsWd+v4UraFJk8mqAutocwvbkUCwnVFXLON1KBAVdLbVw4j7G79fGPABkDIwR6CWTNI4mu4xLZscR1XYlBKV5kjib0lEOq2lT7sfOOM5BjMr6ZmBPZRQdCMgaDg5f+knGnc/lHxgrxAX7fIgu48FD+N+hdggeFWgDwdXrYoGuPoDHLDacZNGpjyvqhgT1ZspyurYz9p0+Qr6yCHvvMiSqaQFx6jPPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=wOo934swFYPJYytLsLK7LxicndHY3S6qCxAIAYTwKao=; b=oP+AuPA9M+n9XXLVIIxOuyaHCAkc/h+F2qy7316wfmO3jM50MSH6be8pp1MKuLLqyaPHYZ7MpRo5YT2h59Q4tMvIttVcEKbpcVQEKdoMocR8eIsWkKOSh8vrLUukGLO13XFqqnRbCSbjPEZWeShi83gG+JjMWk89g2smdb5I3f13cPRwumbMWesgMcZ/pxQArA7hcIC/A5/frM/pf2eqaV4eDsarbvYNX+FNnPzLPQOsb+sSMPum88VH+8BVm12su70/WiqNEASR+UBehtZgLUk8gqIKrSMd2ExX5FEjanh0V8t/zy3FzqZBt/GSvcKFB7hkvSFIWPs+4gsL5LUMzQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com; Subject: Re: [PATCH 4/9] vpci/header: Add and remove register handlers dynamically To: Oleksandr Andrushchenko , Oleksandr Andrushchenko Cc: "julien@xen.org" , "sstabellini@kernel.org" , Oleksandr Tyshchenko , Volodymyr Babchuk , Artem Mygaiev , "roger.pau@citrix.com" , Bertrand Marquis , Rahul Singh , "xen-devel@lists.xenproject.org" References: <20210903100831.177748-1-andr2000@gmail.com> <20210903100831.177748-5-andr2000@gmail.com> <8bb58d2d-255b-96e9-50ff-529985c655d5@suse.com> <16e396be-89f5-4d42-d57b-d91f09b70644@epam.com> <00bbe12b-6a79-e660-c5c1-57ccb200d2eb@suse.com> <242373cf-9854-74b7-4d54-bbcacc6cb7cb@epam.com> <938156e7-cbd0-a19e-f09f-a41dce051367@suse.com> From: Jan Beulich Message-ID: Date: Tue, 7 Sep 2021 14:20:27 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM0PR04CA0074.eurprd04.prod.outlook.com (2603:10a6:208:be::15) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1a8c0a58-6911-46b3-186b-08d971f9e1e4 X-MS-TrafficTypeDiagnostic: VI1PR04MB5167: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7219; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lt5rPZjmXJgizDDx6O66cYvY4i1eFNfCxwQ5sdT+zeuAvBub4ahGOnjUtHjWMJsmcUV33iU4aNVbjPQELzedL5T2Q2qIfQO8RGvDTRodeUoGghqmrx86P+Bia1y6WDdelxiGvDJebGF0vay0gg2cfznq7vO0Nu5RkdtU1Uv/+7mers+jsAHzUgRIz3SLLxg844Wl330hLtb8YjK4osA1M84ckkkROpMNwgOi/QBillx8POhl5MWTCSgXpHsThU7Q3btr1p7i/+egnRB7t2hk+8ZUjAb13OI2s/BrvPBfLywACBr63ofvPNOlg/0t9MkKsfp22WWTs8FVHcNS8yWM9sOefx7J9U8XSfd1rdcbt2OjSGj3LrFZh1NsVaohheP528V2piVRdnKJsqAXscU+UZ1VEshW30NchqUXYxMAj2T0X4LA0T1+Y8X4AoLMIuHLu03+Wf5NfpvqhXIF4swbYe14XSwI3vkdxJZDzHZfAzB2kV6DCdnwVkcEQCmD1dxT+1jegX+PaaE9kCWUkrGfCkDSo0SCVILogZL1q5OGCfwlMV7cZv6+Lh3Jz0dU9XJpTwxWslAmgQYlrcfxgZeYj0w5AvVBTMy5zPWfhtq4LhspLNtiitHb0366PJGPTE5jXWbJbg7BCLWclMoSjo1S/oNIgA9HYwQOvoabACxhbQdsnayUqM6CgnQ0spnas1EGnyfV5ApyXxXytun/rFJXVkf5ILLngfbXnEq4csaah7MRHt+/CqPqJ19ocZIlQJa4gmD1m501mDs6zHDbZrymaA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(6486002)(66946007)(36756003)(26005)(186003)(31686004)(53546011)(31696002)(8936002)(86362001)(2616005)(956004)(8676002)(5660300002)(83380400001)(110136005)(66476007)(66556008)(7416002)(508600001)(16576012)(2906002)(38100700002)(316002)(4326008)(54906003)(21314003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cjEvcUZhR25NaTU1ekhiN2xFa296bUNoSTZFNWtKaHEyQUltUGgxZzZBL21M?= =?utf-8?B?ODZCNjhKZ2haWUxhSzdiUnIxODk4bVQrZE9iYXpTMlpRT0lKWE5NUXBLejJy?= =?utf-8?B?L3grWWhBK1JxRnBKQXV6WXpEZGNtZkxiN2tueUdBbExkTnFjcXRQcEJQWHNY?= =?utf-8?B?dGplNnBqVUJzWXd5TDhxL2dNQWFXOFRCTldZcnQzVGxOQWdGY3I5QkFYREpz?= =?utf-8?B?bHNaa2VFNWZMN0EwZm5DVkdHOHlnYjFxaWRoOEV3WE0wWUNZc21PbzMvLzh2?= =?utf-8?B?RE5qZlNiSzBjMEtXeEFDWnhiajQyczNFS2ZqUWlXaERHU1E4eTBtSHEvZzkr?= =?utf-8?B?aEJZRmZkUTZOb3lVUVBsZWxCdXNnV0VvL2lySjRjMUVrN25vSnFIZys4VHA0?= =?utf-8?B?R1ZMZERYZUc5OE43QVhuaTJpMGJUNUx3VkE2QTFPUHI3NHBnNjVMa2VPSXNS?= =?utf-8?B?NzBkeW9mWGZwbTdjNXNIS2VQOWNlWHN4Y0xTVXZSWU12ajJwNTlzRm1sWlN0?= =?utf-8?B?YTlGVHQ4WHE1YmVpRG1HSDZ2MCtmMGpLdWd4M3Ezc3c0Y29DTzNiUjk1MEVq?= =?utf-8?B?eVB6bHZ6alJidVptMWhDbXdBcDRrSVVKUFgvTGc0d3VhMnJjL2FqZ1VhcFhN?= =?utf-8?B?Zm1YZVhveExCcnh0d3YwMkpOOTlvaG9hVTRjb3BWeTJ0eS82OFQ3SFBCTU5p?= =?utf-8?B?ckJWVi9lMjV3b2RBL3BMUitpdTlzdWpUaUZ1TitFTkN0WjNoS2FtWWN4ZXVU?= =?utf-8?B?aDkrVldqM0tkT3U4bzZJLzh1T1Rxc09wWE05ZXNRZlI3YVpGTExZSGd4NmEr?= =?utf-8?B?ZUc4Znh3aGhvUUE4cDVzZXJtK1J6eGFsNUFyU1E3UThzV3lPSzNOWHZsVzQ2?= =?utf-8?B?RDBPUHQ3blJYTnZBV1c4RUk0SWpibVJtZVpGQ0ZIUmhaZTVlL3FmSlkxQlpq?= =?utf-8?B?OWl4L1RvVEJEOWV5VVhuanBLY2lldEdjVUI5RngxVGtwWUo3clRwbkVacndU?= =?utf-8?B?aGpmOXF5akliUVlVNXdXWUUwRXNXQS9NQnAzNnpUUkVla09YYmx0OXY2WExk?= =?utf-8?B?YXhnekhXTGd2Mmc3TUtRRVdpZm13TXN1U1poOGM3eEtETUFXb3Y2RlkzNjdU?= =?utf-8?B?eVBGOElYZ0hKV09LcXpaVjA1YWZWeSs5NGI5RjFOWTFrdUFDQUltNzFqK1pj?= =?utf-8?B?UURGVUh2K1lXUlFXeXhYQURZYkJvT1ZwU25CMkRGQnpSMzl6NE9tVXZ2UVFT?= =?utf-8?B?a3huWlhtYnpnZVpCWUxvY2lHSDloMVJBaEVoRFBaSkZBN2gvdmJwL0RkY1d1?= =?utf-8?B?ZWFZcFNneUV2RW9sRnQ1WWpiY3V0bXIreTFmN2x4UC8zd1pDdnhkK29HamZ1?= =?utf-8?B?R0IwS3lEaWVmRUUrYlBaZTJGTThMcWZCZmhxQUxGY3VHZTBjaXllS0JYaHBw?= =?utf-8?B?Vks4ZDdCajJQWjByeDNVNnlieGY0aUlMNWhleHZRRlk4eC9MR3U2QXlPQU1Y?= =?utf-8?B?aHlPbGFUTDlQdExBa2xwQUVTWVI2aURGOVNpRlpmcnZOQ3ZVdHJMVFBuOUhO?= =?utf-8?B?Snk4aTMvT0d4UUx5UkxLSHR1bzgwS210Z015bTdiaWJDWG0xQlV6YklBWUhv?= =?utf-8?B?Z21qZHU4RTZIT0VubE1wa1VhV2VhRVpoS3p2amM4a1lJVXlHVXBUcHUrakRJ?= =?utf-8?B?TGtrUU5aSU5Ja1ZVQ3Z1bWhadW93RDdWMENMaklqNk1UaGozNlZKWjV6Ynh3?= =?utf-8?Q?wkP5PargyR6utdG3vLZqxrGDqlyyt/oYzqIP2RQ?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1a8c0a58-6911-46b3-186b-08d971f9e1e4 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2021 12:20:30.1402 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: swnGz/9p8fsPUvGOyqrBc14O/PWj0wDu1T+seFWUgyc89qHb+UJuIGqzEUHbnyKxJypJf2RTXbC2OT+apmmd2Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5167 On 07.09.2021 14:16, Oleksandr Andrushchenko wrote: > > On 07.09.21 14:49, Jan Beulich wrote: >> On 07.09.2021 13:10, Oleksandr Andrushchenko wrote: >>> On 07.09.21 13:43, Jan Beulich wrote: >>>> On 07.09.2021 12:11, Oleksandr Andrushchenko wrote: >>>>> On 06.09.21 17:11, Jan Beulich wrote: >>>>>> On 03.09.2021 12:08, Oleksandr Andrushchenko wrote: >>>>>>> @@ -593,6 +625,36 @@ static int init_bars(struct pci_dev *pdev) >>>>>>> } >>>>>>> REGISTER_VPCI_INIT(init_bars, VPCI_PRIORITY_MIDDLE); >>>>>>> >>>>>>> +int vpci_bar_add_handlers(const struct domain *d, struct pci_dev *pdev) >>>>>>> +{ >>>>>>> + int rc; >>>>>>> + >>>>>>> + /* Remove previously added registers. */ >>>>>>> + vpci_remove_device_registers(pdev); >>>>>>> + >>>>>>> + /* It only makes sense to add registers for hwdom or guest domain. */ >>>>>>> + if ( d->domain_id >= DOMID_FIRST_RESERVED ) >>>>>>> + return 0; >>>>>>> + >>>>>>> + if ( is_hardware_domain(d) ) >>>>>>> + rc = add_bar_handlers(pdev, true); >>>>>>> + else >>>>>>> + rc = add_bar_handlers(pdev, false); >>>>>> rc = add_bar_handlers(pdev, is_hardware_domain(d)); >>>>> Indeed, thank you ;) >>>>>>> + if ( rc ) >>>>>>> + gprintk(XENLOG_ERR, >>>>>>> + "%pp: failed to add BAR handlers for dom%d\n", &pdev->sbdf, >>>>>>> + d->domain_id); >>>>>> Please use %pd and correct indentation. Logging the error code might >>>>>> also help some in diagnosing issues. >>>>> Sure, I'll change it to %pd >>>>>> Further I'm not sure this is a >>>>>> message we want in release builds >>>>> Why not? >>>> Excess verbosity: If we have such here, why not elsewhere on error paths? >>>> And I hope you agree things will get too verbose if we had such (about) >>>> everywhere? >>> Agree, will change it to gdprintk >>>>>> - perhaps gdprintk()? >>>>> I'll change if we decide so >>>>>>> + return rc; >>>>>>> +} >>>>>>> + >>>>>>> +int vpci_bar_remove_handlers(const struct domain *d, struct pci_dev *pdev) >>>>>>> +{ >>>>>>> + /* Remove previously added registers. */ >>>>>>> + vpci_remove_device_registers(pdev); >>>>>>> + return 0; >>>>>>> +} >>>>>> Also - in how far is the goal of your work to also make vPCI work for >>>>>> x86 DomU-s? If that's not a goal >>>>> It is not, unfortunately. The goal is not to break x86 and to enable Arm >>>>>> , I'd like to ask that you limit the >>>>>> introduction of code that ends up dead there. >>>>> What's wrong with this function even if it is a one-liner? >>>> The comment is primarily on the earlier function, and then extends to >>>> this one. >>>> >>>>> This way we have a pair vpci_bar_add_handlers/vpci_bar_remove_handlers >>>>> and if I understood correctly you suggest vpci_bar_add_handlers/vpci_remove_device_registers? >>>>> What would we gain from that, but yet another secret knowledge that in order >>>>> to remove BAR handlers one needs to call vpci_remove_device_registers >>>>> while I would personally expect to call vpci_bar_add_handlers' counterpart, >>>>> vpci_remove_device_registers namely. >>>> This is all fine. Yet vpci_bar_{add,remove}_handlers() will, aiui, be >>>> dead code on x86. >>> vpci_bar_add_handlers will be used by x86 PVH Dom0 >> Where / when? You add a call from vpci_assign_device(), but besides that >> also being dead code on x86 (for now), you can't mean that because >> vpci_deassign_device() also calls vpci_bar_remove_handlers(). > > You are right here and both add/remove are not used on x86 PVH Dom0. > > I am sorry for wasting your time > >> >>>> Hence there should be an arrangement allowing the >>>> compiler to eliminate this dead code. >>> So, the only dead code for x86 here will be vpci_bar_remove_handlers. Yet. >>> Because I hope x86 to gain guest support for PVH Dom0 sooner or later. >>> >>>> Whether that's enclosing these >>>> by "#ifdef" or adding early "if(!IS_ENABLED(CONFIG_*))" is secondary. >>>> This has a knock-on effect on other functions as you certainly realize: >>>> The compiler seeing e.g. the 2nd argument to the add-BARs function >>>> always being true allows it to instantiate just a clone of the original >>>> function with the respective conditionals removed. >>> With the above (e.g. add is going to be used, but not remove) do you >>> think it is worth playing with ifdef's to strip that single function and add >>> a piece of spaghetti code to save a bit? >> No, that I agree wouldn't be worth it. >> >>> What would that ifdef look like, >>> e.g. #ifdef CONFIG_ARM or #ifndef CONFIG_X86 && any other platform, but ARM? >> A new setting, preferably; e.g. VCPU_UNPRIVILEGED, to be "select"ed by >> architectures as functionality gets enabled. > > So, as add/remove are only needed for Arm at the moment > you suggest I add VCPU_UNPRIVILEGED to Arm's Kconfig to enable > compiling vpci_bar_add_handlers/vpci_bar_remove_handlers? > To me this is more about vPCI's support for guests, so should we probably call it > VPCI_XXX instead? E.g. VPCI_HAS_GUEST_SUPPORT or something which > will reflect the nature of the code being gated? VCPU_UNPRIVILEGED sounds > like not connected to vpci to me And validly so - my fingers didn't type what the brain told them. I've meant VPCI_UNPRIVILEGED. I would also be okay with HAS_VPCI_GUEST_SUPPORT (i.e. not exactly what you've suggested), for example. Jan From xen-devel-bounces@lists.xenproject.org Tue Sep 07 12:23:14 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 12:23:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.180997.327931 (Exim 4.92) (envelope-from ) id 1mNa87-000772-Fz; Tue, 07 Sep 2021 12:23:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 180997.327931; Tue, 07 Sep 2021 12:23:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNa87-00076v-Cn; Tue, 07 Sep 2021 12:23:11 +0000 Received: by outflank-mailman (input) for mailman id 180997; Tue, 07 Sep 2021 12:23:10 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNa86-00076p-Kl for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 12:23:10 +0000 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id dce6d494-7b8c-4768-bfd0-12b0b54173a5; Tue, 07 Sep 2021 12:23:09 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dce6d494-7b8c-4768-bfd0-12b0b54173a5 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1631017389; h=subject:to:cc:references:from:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=5SRy+GkaKSYNYkCp7c5Yrir90YVimONIfq6a0GmK36Y=; b=O3exGyuvoVxoIpeL+Y8IkZzVYAPaDz33DOqNotY5f01VOfClb8T7fiMK O9rggdneKS/4Hqt9sb4fx/Moyw2IPS2/Bi3flYFVy51Bhm+tIlXA61eTf xgBrMdW6gnpdBRx7Bh85HREhG3dn3Q0HJNRpfykI/eqgQvkjA6anMj5Bu 8=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: jgCqq3dw9YpX5Uz6TmLwID2hGPT3wGsY+Pt9XkCfIKmBQxY58vc/UY1hXkCel8SlXLI+jyvYjr fDbl43hkqy8WusXCZv1e8B2uWDyAbKJY2xovtQa/iShlEybzgKCgbfOZl1lvVoDmhtcc5Ol7Dw 4RS3dfKc73sbZnzxjmNGapy9gLedzhKh8v8j6w/ZAgFN8ivoII0DV/PCaN07HpT/Q3DyV+krS1 toxYM7aL2XCogcS4mzA9iYmhhkABxUkUws9ItiHWlq9CWzUGJSP2CFIVM4y1+yVkbHTFaGtJdq 2aHIxuc+i8PIxfecMaP6rIBZ X-SBRS: 5.1 X-MesageID: 52134917 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:cl9QIq4XmHu+TJSn5gPXwAzXdLJyesId70hD6qkQc3Fom62j5q WTdZEgvyMc5wx/ZJhNo7690cq7MBHhHPxOgbX5VI3KNGXbUQOTR72KhrGSoAEIdReeygZcv5 0QCZSXCrfLfCVHZRCR2njFLz4iquP3j5xBnY3lvhNQpZkBUdAZ0+9+YDzrdXFedU19KrcSMo GT3cZDryrIQwVtUizqbkN1OdQqvrfw5evbXSI= X-IronPort-AV: E=Sophos;i="5.85,274,1624334400"; d="scan'208";a="52134917" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DbrTKVl9PF8CCdv0X86WEEyyYY2eoAwUGvtPdhggnbJcDTWb60btkCZJjq+/Hm5N0tPU6+F67ML7X3iZ+kTCA1A8WSz1zXFiyN0C9Nwp+gviBh3sh2KiLHwnN1CP6FRVKUYYl580W+rAkry7DJecJa7+0H9KtiedWZe92eCu4uGtC95ZK1YLAptv4TmBiJKEWWVMBC39yE25xvLy/9dhaW4kBtuqpwpXG2Xxgo+iPHoAzS39BHkW1wvn48jisU5BzYVCT9JTd9PrOM/2MyO/4/oXwfvXSlRZKF5fjYQFm91j6P+HbPr/HrdU5JYSR5NLmIOuuYjX+wRnsFncPZ/2jg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=/89I8PoBYdPweDDXpJU0m/Tu0Qc273nHKnykOHY2riw=; b=N0p9uIBL7STgRCbOjYw/pHLAtSpUvn6pbcTopk8jytCsOGy9eaR06igKBPy49OcC4BOGi4v8s9+BzFSfQQO+hH5R+ZBHdVfsucUDWlTS/uM3wVZpoQ0a0N9JiiV9xJ1eaaLtv3plBYoinR22Oo36082Jcg3+n7PJ/Xm0fDQQqWruxff0Z2jN8GKcyOx8+R3yJkaXJZjr0NR040I64rq9Lc26qYiZP87q6MxjyioT8/k3SGPvKIianSC99Gg7Srcw/6q29mrqaSpy1w6jQFsWSA6PQrmAcx9NCFNBSKZrfdRXZoMMAGAVynR/roUSWBhxCjZILOMDAKwMlnzyTeVefg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/89I8PoBYdPweDDXpJU0m/Tu0Qc273nHKnykOHY2riw=; b=H4grYPRDrmf51qPqwBOf2Y4BH4XzlxHARHZh2pDAn2zYey4Flcvba5JmljPW3HejUTkd2MZIi2EBUhUwASW8Cxp2kSu75ll7pUCEuRgxMwzJ3L+nigF1xPecsaB93b1ZUa3KcXY6OwZcCriSka5yrP6vCKdypmIB02avs/3pW/Q= Subject: Re: [PATCH] x86/p2m-pt: fix p2m_flags_to_access() To: Jan Beulich , "xen-devel@lists.xenproject.org" CC: Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , George Dunlap References: <2ec3fb93-5b91-15d0-4769-adf414af86b9@suse.com> From: Andrew Cooper Message-ID: <5fb0ae14-3838-c0b6-3e1c-ef5b44129186@citrix.com> Date: Tue, 7 Sep 2021 13:22:52 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 In-Reply-To: <2ec3fb93-5b91-15d0-4769-adf414af86b9@suse.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-GB X-ClientProxiedBy: LO2P265CA0427.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a0::31) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: bd312749-5c94-40c6-f67b-08d971fa3a2e X-MS-TrafficTypeDiagnostic: BYAPR03MB3494: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8djyJaybhNVSV1A4J0PLX4ua64QGBCA9kfobzAKBGM86WvawdgU20+Pi+71xnaO0+RlC70rR/7yLWFOlxGqPDrEua+8w56jdZPHVUnvxTbM45rmZi9QLo3Gi9JG6pN5v3kSzlRrtE8dBXn8YtNwvl80ANQ5eUkiOYnBhrzlxs505nrsMsuwbZ5B/GBkuahtiG2YBRxIXl2usLQT4kL6iPbXwP5K3G4dql87YaGs7zlWRA1a6seS5S1sWq6NJN/8R4XCE2v00iGID9hQxvaKu9dG0wpbVJQLtMAEhVPbVa10NYhshQWlOoXDzp3CyzXIWX1YHyvAuB76pkVNLUDd9Ja6uwgoaUkbIDik/0WlJvW2+cIF9kT8sW0u+s0OLUwuqmt+13VJPAlIXocl37wjPboQ8oHPfD/kW/1s+WokgmSWOJRbzIiD52TD2d5FierZPOwnq13Gk4mfAqkwZ3q+fmuiTy+dEQNUURhCmQZu/XcprJmtr45rAyYUaEiRWNvk7T1B7WuUleodJrQpbME2JLJ79KKW1NJFvqHMYap7TF414ov+SYEyob9jyU6rWz04haEiqMM2pQo0p0vzf/RFQF4RKHy6fUjJEC8J7puQ9ySnzInfrZ2Gz1dMHrqTS9RGDU4qLBE2eeacYjtZ3Nq4FJwkQ+yqTaW+Ax4lmc5KC1YbRc7qGGaE/1A8QNyS4WoOpn+kmOT9mpbrifh7lxGR9Dx9O8+NuGxVmYdcKistDEjg= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(83380400001)(107886003)(2906002)(86362001)(36756003)(4326008)(53546011)(316002)(38100700002)(55236004)(54906003)(110136005)(956004)(2616005)(31686004)(6666004)(31696002)(8676002)(66476007)(6486002)(508600001)(66946007)(66556008)(16576012)(186003)(26005)(5660300002)(8936002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dmNXbmVYY0VDbEhZUVJmeTZyQ2g0ajlid1RTYnJoNXU4Q0ZaTjhaV2wwYzFw?= =?utf-8?B?d1hqUWpRcjRRS05KZDJmb2FqaWhVWEZmMnJicXZiNk9uV1J5YmFpaVZOSUp0?= =?utf-8?B?VW51QkN5R040UjJuRTYrcUFXT05VWGZKdHQ4WU5JUXRqaGJGVW9yTEw0U2Jp?= =?utf-8?B?V0x2ejR2V29rMGliU2N3NElhYzRkUUk1ZGhpaWV1Q3FBUkxRSjhIa2diMFBq?= =?utf-8?B?R0JNSzE3YmhjY1NleFFWclp3VGpsV0REVjlLL1Vac0t6TnJVWHZPUHdhZ2pE?= =?utf-8?B?Z2luaVpVSDFXVkhHS2cwdSt3eEdVUGgxSFRsNDF1WEtQODBIZUgralpaNnpV?= =?utf-8?B?aU9BQjlWdDlCeVFQSDZIN3l3SHZ4ZEhnc1U0ZFRCNFcyc2lOQTFsQzR6Y0Fw?= =?utf-8?B?ODBnWjBlVHZvZ3k0TlVyVUZUSGM2MU9nNnc2TlJ0RUJtWGtadFNaZG45QW9I?= =?utf-8?B?dElqdXBZRHF4WjFlcGdLVlhITExtRWpnanBNQ1paVGpXMkY0d3R0YndSQ3dE?= =?utf-8?B?cVVzRmFseGxSZ2c1TEZVSkJibThFaXpVMld5T0l2NkMxUUxQVUtLWC9UYmhR?= =?utf-8?B?T3RzRlcvTTlNbHlHaHBIRXNWSHpJYS9ScFF4Qm50djNHc044OEJKcEpzcDFH?= =?utf-8?B?YlZFVEZFWHIzRnpMZi9sOC9HSXF2bldvcHVzQzZ6Vko2YnB0ZXR5YjlOUGpV?= =?utf-8?B?RENoUlFsNUVRUzRLR0NqWnNsbVVYTkFEZFVtREdMR0J4VXVVL1JmMVZabHpl?= =?utf-8?B?NVJwSjJudThOUTVXVVJSR2gyUXZEdUgwZ2hPaGYyVHdVbzJTWC9ZQlNIRW5h?= =?utf-8?B?ZEkreFd6YkVtenNTNlJWSDZtd2RNOVZVSDhFSU9KY2Z5NjZ1NTVYanJmeWF5?= =?utf-8?B?V0hlMVM4Y29sRlU3NnE5TGRQZjNBM256OXpmTXRFdlZKOTU2a1NqRmpERVBI?= =?utf-8?B?bU5USWpjb3RlZmJRWGo1VmVnYXRMSG9DZktCTlMwaUNNR3lmay95M1FVcGVu?= =?utf-8?B?RGllNXVtRWduNUZSZktqaW43SFAyNVNHakdSdXM5aTdHZU13OFBEYkkwaGhQ?= =?utf-8?B?bEtoMXNIZHl6Yk92bGxSN2JFR0FxY0pOK1poOU1nem15Q0RTK3MxV1NlRFVU?= =?utf-8?B?MWt2c2w5VjVMNVNoc3FKc1R0N3hIUW5zWE55WVBHWjZlV05aOWg3VHpzV3lm?= =?utf-8?B?S3c3d1BjcXV1K3BOVnRWNnZVNi8vYVVJOEJnc2VQdEI2Z0tGZ0k4QytkbnZv?= =?utf-8?B?eFlvSVdCNmxrY0NkMXlzaUxrM282RU1TeWs5Z2c0M2cwYVdUT0k5TE43azRX?= =?utf-8?B?NWkzanFSVDd0QXczaytsMWIyRGovY2IzU0RnREdScXF6REZVQVVLYWlyVFJl?= =?utf-8?B?T2Q1dnIyeVVrblB2emh3MUMrYjRucU5OZGNLcXk0RW9VWUllcFM0WnU5VGVI?= =?utf-8?B?VnhBTFNJMFpWNS9YRmEzUXVzSkZHSmJhSnl0T1NBc2xSS1BjbmpjZ1V4M1VN?= =?utf-8?B?bXlrVld5Mm81QkdTQXUzOTZwcU1NMlMyKzdFR1Y0aXVIM1U5UlQraWdCMDZt?= =?utf-8?B?TTBaTHZuNHJydS9kUUlYYVhlVkRZaTZtZGJqOTFlcW94RnF6V2VMR0tyUFBE?= =?utf-8?B?dFdZKy9yOWhwVEsvYmRMeHpjRkx5Y3Mwc0RHRGdJZStNNU1pOGovUkc1Si9s?= =?utf-8?B?RG45VmRKUXRaYVEra3hjUmh3enNuVThka3dyZnFKVk1TdEVJR0FmOGIvWkNX?= =?utf-8?Q?GlENTxOiqcn19kcMir2EVu+8PDAgxpqi9MU7V2A?= X-MS-Exchange-CrossTenant-Network-Message-Id: bd312749-5c94-40c6-f67b-08d971fa3a2e X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2021 12:22:58.3113 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /eeY+2sRbbDASCxnzucwgBZCabBEWqIfDzNmjwbC0DzmiFBmXW7JLrfOafQiXfNQE7fHoixs+cJoHE3uBHb9sW3ym8o4lLEdIAovFLEtpD8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB3494 X-OriginatorOrg: citrix.com On 02/09/2021 08:01, Jan Beulich wrote: > The initial if() was inverted, invalidating all output from this > function. Which in turn means the mirroring of P2M mappings into the > IOMMU didn't always work as intended: Mappings may have got updated when > there was no need to. There would not have been too few (un)mappings; > what saves us is that alongside the flags comparison MFNs also get > compared, with non-present entries always having an MFN of 0 or > INVALID_MFN while present entries always have MFNs different from these > two (0 in the table also meant to cover INVALID_MFN): > > OLD NEW > P W access MFN P W access MFN > 0 0 r 0 0 0 n 0 > 0 1 rw 0 0 1 n 0 > 1 0 n non-0 1 0 r non-0 > 1 1 n non-0 1 1 rw non-0 > > present <-> non-present transitions are fine because the MFNs differ. > present -> present transitions as well as non-present -> non-present > ones are potentially causing too many map/unmap operations, but never > too few, because in that case old (bogus) and new access differ. > > Fixes: d1bb6c97c31e ("IOMMU: also pass p2m_access_t to p2m_get_iommu_flags()) > Signed-off-by: Jan Beulich Acked-by: Andrew Cooper > > --- a/xen/arch/x86/mm/p2m-pt.c > +++ b/xen/arch/x86/mm/p2m-pt.c > @@ -548,7 +548,7 @@ int p2m_pt_handle_deferred_changes(uint6 > /* Reconstruct a fake p2m_access_t from stored PTE flags. */ > static p2m_access_t p2m_flags_to_access(unsigned int flags) > { > - if ( flags & _PAGE_PRESENT ) > + if ( !(flags & _PAGE_PRESENT) ) > return p2m_access_n; > > /* No need to look at _PAGE_NX for now. */ > From xen-devel-bounces@lists.xenproject.org Tue Sep 07 12:24:14 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 12:24:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.181003.327943 (Exim 4.92) (envelope-from ) id 1mNa97-0007gn-RH; Tue, 07 Sep 2021 12:24:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 181003.327943; Tue, 07 Sep 2021 12:24:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNa97-0007gg-Ni; Tue, 07 Sep 2021 12:24:13 +0000 Received: by outflank-mailman (input) for mailman id 181003; Tue, 07 Sep 2021 12:24:13 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNa96-0007gY-Uy for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 12:24:13 +0000 Received: from mx0a-0039f301.pphosted.com (unknown [148.163.133.242]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 8167cb72-0fd6-11ec-b0ec-12813bfff9fa; Tue, 07 Sep 2021 12:24:11 +0000 (UTC) Received: from pps.filterd (m0174679.ppops.net [127.0.0.1]) by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 187Bh5dS023794; Tue, 7 Sep 2021 12:24:08 GMT Received: from eur03-am5-obe.outbound.protection.outlook.com (mail-am5eur03lp2058.outbound.protection.outlook.com [104.47.8.58]) by mx0a-0039f301.pphosted.com with ESMTP id 3ax0pd9gv1-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 07 Sep 2021 12:24:08 +0000 Received: from AM7PR03MB6325.eurprd03.prod.outlook.com (2603:10a6:20b:13c::18) by AM6PR03MB4949.eurprd03.prod.outlook.com (2603:10a6:20b:84::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14; Tue, 7 Sep 2021 12:23:59 +0000 Received: from AM7PR03MB6325.eurprd03.prod.outlook.com ([fe80::d9b7:c0ab:2c2f:5b44]) by AM7PR03MB6325.eurprd03.prod.outlook.com ([fe80::d9b7:c0ab:2c2f:5b44%3]) with mapi id 15.20.4478.025; Tue, 7 Sep 2021 12:23:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8167cb72-0fd6-11ec-b0ec-12813bfff9fa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BQzOyFXyiwn7PkXjCS4i5+hsvLQPObhwIj8r21RVL6zrg4bn0EnkiqcJ7eWyoUik8Q25OqVF7MPB6X6FjG8pTRKF1PljTIdbI3BXItU/HozIMixWCI6BG0/Y+jhQCJebRD+UwF3qXFg1bfqCbErW2pIYv/8jcyQUcNJpk1j86LpRe947vqbJyv7I3f9uTquxug+fUaeOMt+5kSeZjV6/NDPjFKnr3WR7oTRITd7DRSR8JsOHjANGMCdVeJWldQxFK13l8hHzADax34TJsVg9tH0DGr0oMMCdyL/KYmUOUGUHtG4Iml3MkkQY1UTtW/2dFwZHX0il9fnFf/98hxLlhg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=8qGrsR7JiIMdJ8qARnR6BCFPDRyxpVUqctH0MnLAb4A=; b=VvjL9WlzXozdtpeyRgI3lTABGgYuA9AmQK3c5xFt3jYu3GxvKt/RNC8luah0UHv0L9pBeE/MvoQFuFf5jgZuhjNatF/GCIDM6sXxfwGkRZ5DpBdN26adn8XaQTM2HHxvORSqQPki8OMfeWR9nMGuHA91PWDMyqQmG4/u6TgF5dEiZrH6Nc0qbMRjKX1QZGO3A4iLbR1DZZgiznDB/FJ9f5jIs+EvPCbV0x48vjlH5437CJ3HE+4D1nxVXpIqoQzoNIA3MijPLlE+6WGOtuDNgMIQP3poyGWEq8s6TnMmJQ/K+UZJbPcJetkNXupy9H7aOKKBUOYn7Oy56bmDP+X1LQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8qGrsR7JiIMdJ8qARnR6BCFPDRyxpVUqctH0MnLAb4A=; b=FyFbW+l0W3d5Bd+k9ybDUicMI13K95s09w5XXFirqrgcEGG8Dd89qGx0m48RcXL/zQs5SRJd5Fg4WzIilfUmMph8h7GiWFGcoU0vbCKvFnrD0NgpvIgpk0/zCcyip30WwHYqYywh3pQ3gVTR2FLfB16bQIfzBurWAsALh9KCwScyT2Tm8G0UCEfZ/q0q3HMcRZu/NLU+FHRE/9z3rVFZq7uj+ST/u0dgwlGKWnCLd7XJO9+iOMLDtsQHb95ZUqUqnidswuMQ0GDsG/hbi8UUYay9ZJR22Tmhml9F+zUiAJlF43InoGOBIDgsP0eYn+6nOU+v4FZGEgPLX/tBAGViNA== From: Oleksandr Andrushchenko To: Jan Beulich , Oleksandr Andrushchenko CC: "julien@xen.org" , "sstabellini@kernel.org" , Oleksandr Tyshchenko , Volodymyr Babchuk , Artem Mygaiev , "roger.pau@citrix.com" , Bertrand Marquis , Rahul Singh , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH 4/9] vpci/header: Add and remove register handlers dynamically Thread-Topic: [PATCH 4/9] vpci/header: Add and remove register handlers dynamically Thread-Index: AQHXoKusySJnLVveGkulaWKrBZdXpKuXEOQAgAFPE4CAAAkRAIAAB3eAgAALDQCAAAeQAIAAAQeAgAAA/AA= Date: Tue, 7 Sep 2021 12:23:58 +0000 Message-ID: <37b08bea-2e0a-1a9e-aa26-8e3f61ddce7f@epam.com> References: <20210903100831.177748-1-andr2000@gmail.com> <20210903100831.177748-5-andr2000@gmail.com> <8bb58d2d-255b-96e9-50ff-529985c655d5@suse.com> <16e396be-89f5-4d42-d57b-d91f09b70644@epam.com> <00bbe12b-6a79-e660-c5c1-57ccb200d2eb@suse.com> <242373cf-9854-74b7-4d54-bbcacc6cb7cb@epam.com> <938156e7-cbd0-a19e-f09f-a41dce051367@suse.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=epam.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: debb9fc1-4a64-4f7c-81d1-08d971fa5e86 x-ms-traffictypediagnostic: AM6PR03MB4949: x-ms-exchange-transport-forked: True x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: BMbD0oZNp93Gkku0wuU9+6c9HEzB/R0f1rt6hAeRi3XPTpYVVzyqqvZvt1n6MVqfQuE7IGyg8L+wiCwP8ojCc7Bm3A99RcEMY0OV0mHX1bSGRvutFTfD1VIohjIOHFQUeoaTFi0SQNJpnRcbyzOL9fBu3hqvxj+0t59WBeL7wwgxQ1m/C7k5cSWCoIVWslBfNdOXn5mDU7zoftl53w9YvC4Hwj4F477yBVNYWHCujHAG7LnZDMohajS+ACIyeHeWSzxXX+cPYamRJQbesfYJ4W1itGSiuHN8/8QxptEfzxYtY1YyPRyRw5VuyevlBBX1YcrYxCDHQ/w5PA/i8mOA7zDNR7aDFPCzNIvpG122AYL2GwzZEUBzDST679mr6h+lrreyc6LWYWpBEYnrchci3kfYZ52l+tU2DrIpR/gfgUoRSOz8Hc7MYFt/50BjBLR8p3xT0c/1adlR/9LLJKJ7ZsmO3TGNa+vaLJvDo7dulqmBHPC/+rtvyb2KGGmXMtA6ak8Gon+iUyO+eDGT6Iv6gPo7QsZWbbpVvgzyV6A6sUbuJqmfL24K6csPI7JCw0fwxXB0t+JY+6YHGEqTEPXubPBn8t2GZLVtH/6MuztzwPml1N02lVHbvwXD/JLoN7PKVjKPHyZ88axnBpPeskpm9tFngVv7dHxFf0gRY366qss2gCVhHipRxtn+v3h9LJ7Hj7Zt5VDr8SpbRtwz8e+4L3lx/R9xInrzB4PDwPC+fZ7hTzxyKuQX4tELyukXiBPLasjknXobCeacD5gxJtwMcw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM7PR03MB6325.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(316002)(83380400001)(86362001)(110136005)(54906003)(31696002)(6486002)(2906002)(38070700005)(122000001)(508600001)(36756003)(6512007)(31686004)(38100700002)(4326008)(71200400001)(26005)(186003)(66476007)(66556008)(8676002)(64756008)(66446008)(66946007)(53546011)(91956017)(76116006)(8936002)(6506007)(5660300002)(2616005)(21314003)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?WTBIUnpNZ3hLNnZBdlBReWMyTENKTTJUeVFHT2J6UW5VWXhJSVVTbFdJeWw1?= =?utf-8?B?OXVaenpaSUQxMHorY2F1elJ5OUNicnJNTnArOVJ5RjZ5VVM0NElkY3dFNi9w?= =?utf-8?B?MVRFZHpLdDJRRUgrWkpLNkVuckVlOGdyZDZvRzROYXVYQnRwQzU5RmxWamFD?= =?utf-8?B?N3Ercko5ZW83YlhlUUVYWkVTSVByT0tkMGxhUncxWnlXTTNNZXVBL2w5THc0?= =?utf-8?B?ZUVoQVpRTk5oSkp4UmxzbUdwNjFsdFc3MFV2QSt4U0NuRzgvanRyMm1IU2xw?= =?utf-8?B?VUd2NXJCWHZmajZ5a0FXTUpjZkhYM0lURDA5T2lWWnBPNXNpTTNUWEVvRU1V?= =?utf-8?B?M3dDZGRMQll4UzhIbWRKWm05RzNibHMyZ3dBcUN4bnBNa0F0eG5RS2RLZGZ2?= =?utf-8?B?ZFFYR1B2VXB2RnI2L05OMnpsTWNzeU5nK0swVWdmWVZUckhMV0NOWlllaWcx?= =?utf-8?B?RlBxSm1nbGlSaDVNWUc1Y2hQTXl4QlUzZHY4YjFEWmtYem8rWHluQWhZUlNk?= =?utf-8?B?RHlicnpwd05Hbm5OTkNnc2F3L2xBTjRUaGRGL3NGclVnTWl1MWdLUWoxcXdo?= =?utf-8?B?QTVvQWRmQ2hqN2xPTC80L29vL0N1SkFOWURSZ1JGVUZNRmc1c09pdld1R1N6?= =?utf-8?B?MVp3STVhYlVWaVl1QnBkUWYxMkFjU2FtdG9SYXF3TzJKM25FM3ozdVd2MEVy?= =?utf-8?B?ZFpVSWpyYXhWRGdGVTh4VlpWb2FlbmcxMWhmTER2c3NxZWVhd3V4OUJXWlBy?= =?utf-8?B?aWxGbnJETWRJbENEU2hqRzcrdEZiRzNDaUk2KzBmRzN6YXB6a3lHemg5SThR?= =?utf-8?B?UW94T3d2T3RnaFlBM2Flc3Z6ZzF6emNkbVBwOGR6T09oUDlFYjJOL29UUG5x?= =?utf-8?B?YVZ4WUdEWkFPQkJ1bWVZR2M4QkRBaHVxRm9yRDBaK0YzWEZQU2Z0RzljMFM0?= =?utf-8?B?TFhRVG1JdmhMMVBkNjZxMzZTMGVlWnhwU2lsREhZUENtSnVVVzFrNEQ2MjV3?= =?utf-8?B?U3p4bTRQcTJGVGxERlRDaTgwMFVjeDYyVXlkNGhtYjRmZWEzVlAwWE1QSUtC?= =?utf-8?B?eVF5bGVPUDhYSGhyT0tHeExvT1pVVlBIekQzOFJUd2RpeVAralhyajZyRzE2?= =?utf-8?B?OS9GVHo0QmR2Qzl2ZGloRHZkU1NJSk5DZlpzUHBwc0VVZEJjZU0vVFlXME02?= =?utf-8?B?OU5HcTJnaXFPcWFQc0Y4ZlBzSGE4ZDhPZUhDS2x3TjdyV1RKR01sSkFCSktm?= =?utf-8?B?MGJUeGhkSHVPaUFkRWJ2OU5kVGtoMmErMGZnRlJReEJBREQxVGtoUVBjWWhL?= =?utf-8?B?VnJ1QWg1aGZUQ3lWNGw2OHJneDZjZWR0clROQlJET3RVUXRVZUp0YSttQWlS?= =?utf-8?B?djN5aUU2a2Q4cTlBanV4N3JmTElBNmdrRy9lYUdnQ1BJUmZnL3BRMUpORTYy?= =?utf-8?B?WGoxZjRrSzRxNlV6aWxIbDE4bHE1bkMrWm1lM2o2ZHdiWG02cjFjcXJTTm9N?= =?utf-8?B?bnkxaXNJVmFhZXhrM2k5bDNFQU10RFdFdE9MUFdrZHN3RFI2TXhCRDhheWNz?= =?utf-8?B?SjFDUCtSaHRCOGZTaUNMWjZ4MWNkYVovZG9zR25pSVpSMk80MCs4RFVTNkdK?= =?utf-8?B?alFMZ0VQVG9KSFlhZWM1M2dZUHZVMzd2am9udFpkSEo4T2xXeGp4bW9OeDBV?= =?utf-8?B?K0FZYnd0QTZWVXBHNGVIeCtaNW5iMVd3NE0zZkgwOWYxRnUzVXQzdmp0d3Rv?= =?utf-8?Q?x041ag8LH5w/2wCbTyxUgteZWcBAJIAhn7k1Tdr?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: epam.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM7PR03MB6325.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: debb9fc1-4a64-4f7c-81d1-08d971fa5e86 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Sep 2021 12:23:58.9897 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: o8RguYEOB9GEeVx5ZJwBvfbeNpSNLEdNUTNTnDyH6im8ZH7S1eJZK5DICIeryHPDS1/sx+uFlDCAgB2u2M518SJ5SUhOW52W1BBTEOajasQYBmeWGCKox6BPdqKRLLlU X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR03MB4949 X-Proofpoint-GUID: dIMHYvigZppWAJf-fJ20Y8gvWPBb3h9W X-Proofpoint-ORIG-GUID: dIMHYvigZppWAJf-fJ20Y8gvWPBb3h9W X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.391,FMLib:17.0.607.475 definitions=2021-09-07_04,2021-09-07_01,2020-04-07_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 mlxlogscore=999 priorityscore=1501 suspectscore=0 bulkscore=0 mlxscore=0 lowpriorityscore=0 impostorscore=0 adultscore=0 phishscore=0 spamscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2108310000 definitions=main-2109070081 DQpPbiAwNy4wOS4yMSAxNToyMCwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDA3LjA5LjIwMjEg MTQ6MTYsIE9sZWtzYW5kciBBbmRydXNoY2hlbmtvIHdyb3RlOg0KPj4gT24gMDcuMDkuMjEgMTQ6 NDksIEphbiBCZXVsaWNoIHdyb3RlOg0KPj4+IE9uIDA3LjA5LjIwMjEgMTM6MTAsIE9sZWtzYW5k ciBBbmRydXNoY2hlbmtvIHdyb3RlOg0KPj4+PiBPbiAwNy4wOS4yMSAxMzo0MywgSmFuIEJldWxp Y2ggd3JvdGU6DQo+Pj4+PiBPbiAwNy4wOS4yMDIxIDEyOjExLCBPbGVrc2FuZHIgQW5kcnVzaGNo ZW5rbyB3cm90ZToNCj4+Pj4+PiBPbiAwNi4wOS4yMSAxNzoxMSwgSmFuIEJldWxpY2ggd3JvdGU6 DQo+Pj4+Pj4+IE9uIDAzLjA5LjIwMjEgMTI6MDgsIE9sZWtzYW5kciBBbmRydXNoY2hlbmtvIHdy b3RlOg0KPj4+Pj4+Pj4gQEAgLTU5Myw2ICs2MjUsMzYgQEAgc3RhdGljIGludCBpbml0X2JhcnMo c3RydWN0IHBjaV9kZXYgKnBkZXYpDQo+Pj4+Pj4+PiAgICAgIH0NCj4+Pj4+Pj4+ICAgICAgUkVH SVNURVJfVlBDSV9JTklUKGluaXRfYmFycywgVlBDSV9QUklPUklUWV9NSURETEUpOw0KPj4+Pj4+ Pj4gICAgICANCj4+Pj4+Pj4+ICtpbnQgdnBjaV9iYXJfYWRkX2hhbmRsZXJzKGNvbnN0IHN0cnVj dCBkb21haW4gKmQsIHN0cnVjdCBwY2lfZGV2ICpwZGV2KQ0KPj4+Pj4+Pj4gK3sNCj4+Pj4+Pj4+ ICsgICAgaW50IHJjOw0KPj4+Pj4+Pj4gKw0KPj4+Pj4+Pj4gKyAgICAvKiBSZW1vdmUgcHJldmlv dXNseSBhZGRlZCByZWdpc3RlcnMuICovDQo+Pj4+Pj4+PiArICAgIHZwY2lfcmVtb3ZlX2Rldmlj ZV9yZWdpc3RlcnMocGRldik7DQo+Pj4+Pj4+PiArDQo+Pj4+Pj4+PiArICAgIC8qIEl0IG9ubHkg bWFrZXMgc2Vuc2UgdG8gYWRkIHJlZ2lzdGVycyBmb3IgaHdkb20gb3IgZ3Vlc3QgZG9tYWluLiAq Lw0KPj4+Pj4+Pj4gKyAgICBpZiAoIGQtPmRvbWFpbl9pZCA+PSBET01JRF9GSVJTVF9SRVNFUlZF RCApDQo+Pj4+Pj4+PiArICAgICAgICByZXR1cm4gMDsNCj4+Pj4+Pj4+ICsNCj4+Pj4+Pj4+ICsg ICAgaWYgKCBpc19oYXJkd2FyZV9kb21haW4oZCkgKQ0KPj4+Pj4+Pj4gKyAgICAgICAgcmMgPSBh ZGRfYmFyX2hhbmRsZXJzKHBkZXYsIHRydWUpOw0KPj4+Pj4+Pj4gKyAgICBlbHNlDQo+Pj4+Pj4+ PiArICAgICAgICByYyA9IGFkZF9iYXJfaGFuZGxlcnMocGRldiwgZmFsc2UpOw0KPj4+Pj4+PiAg ICAgICAgIHJjID0gYWRkX2Jhcl9oYW5kbGVycyhwZGV2LCBpc19oYXJkd2FyZV9kb21haW4oZCkp Ow0KPj4+Pj4+IEluZGVlZCwgdGhhbmsgeW91IDspDQo+Pj4+Pj4+PiArICAgIGlmICggcmMgKQ0K Pj4+Pj4+Pj4gKyAgICAgICAgZ3ByaW50ayhYRU5MT0dfRVJSLA0KPj4+Pj4+Pj4gKyAgICAgICAg ICAgICIlcHA6IGZhaWxlZCB0byBhZGQgQkFSIGhhbmRsZXJzIGZvciBkb20lZFxuIiwgJnBkZXYt PnNiZGYsDQo+Pj4+Pj4+PiArICAgICAgICAgICAgZC0+ZG9tYWluX2lkKTsNCj4+Pj4+Pj4gUGxl YXNlIHVzZSAlcGQgYW5kIGNvcnJlY3QgaW5kZW50YXRpb24uIExvZ2dpbmcgdGhlIGVycm9yIGNv ZGUgbWlnaHQNCj4+Pj4+Pj4gYWxzbyBoZWxwIHNvbWUgaW4gZGlhZ25vc2luZyBpc3N1ZXMuDQo+ Pj4+Pj4gU3VyZSwgSSdsbCBjaGFuZ2UgaXQgdG8gJXBkDQo+Pj4+Pj4+ICAgICAgRnVydGhlciBJ J20gbm90IHN1cmUgdGhpcyBpcyBhDQo+Pj4+Pj4+IG1lc3NhZ2Ugd2Ugd2FudCBpbiByZWxlYXNl IGJ1aWxkcw0KPj4+Pj4+IFdoeSBub3Q/DQo+Pj4+PiBFeGNlc3MgdmVyYm9zaXR5OiBJZiB3ZSBo YXZlIHN1Y2ggaGVyZSwgd2h5IG5vdCBlbHNld2hlcmUgb24gZXJyb3IgcGF0aHM/DQo+Pj4+PiBB bmQgSSBob3BlIHlvdSBhZ3JlZSB0aGluZ3Mgd2lsbCBnZXQgdG9vIHZlcmJvc2UgaWYgd2UgaGFk IHN1Y2ggKGFib3V0KQ0KPj4+Pj4gZXZlcnl3aGVyZT8NCj4+Pj4gQWdyZWUsIHdpbGwgY2hhbmdl IGl0IHRvIGdkcHJpbnRrDQo+Pj4+Pj4+ICAgICAgLSBwZXJoYXBzIGdkcHJpbnRrKCk/DQo+Pj4+ Pj4gSSdsbCBjaGFuZ2UgaWYgd2UgZGVjaWRlIHNvDQo+Pj4+Pj4+PiArICAgIHJldHVybiByYzsN Cj4+Pj4+Pj4+ICt9DQo+Pj4+Pj4+PiArDQo+Pj4+Pj4+PiAraW50IHZwY2lfYmFyX3JlbW92ZV9o YW5kbGVycyhjb25zdCBzdHJ1Y3QgZG9tYWluICpkLCBzdHJ1Y3QgcGNpX2RldiAqcGRldikNCj4+ Pj4+Pj4+ICt7DQo+Pj4+Pj4+PiArICAgIC8qIFJlbW92ZSBwcmV2aW91c2x5IGFkZGVkIHJlZ2lz dGVycy4gKi8NCj4+Pj4+Pj4+ICsgICAgdnBjaV9yZW1vdmVfZGV2aWNlX3JlZ2lzdGVycyhwZGV2 KTsNCj4+Pj4+Pj4+ICsgICAgcmV0dXJuIDA7DQo+Pj4+Pj4+PiArfQ0KPj4+Pj4+PiBBbHNvIC0g aW4gaG93IGZhciBpcyB0aGUgZ29hbCBvZiB5b3VyIHdvcmsgdG8gYWxzbyBtYWtlIHZQQ0kgd29y ayBmb3INCj4+Pj4+Pj4geDg2IERvbVUtcz8gSWYgdGhhdCdzIG5vdCBhIGdvYWwNCj4+Pj4+PiBJ dCBpcyBub3QsIHVuZm9ydHVuYXRlbHkuIFRoZSBnb2FsIGlzIG5vdCB0byBicmVhayB4ODYgYW5k IHRvIGVuYWJsZSBBcm0NCj4+Pj4+Pj4gLCBJJ2QgbGlrZSB0byBhc2sgdGhhdCB5b3UgbGltaXQg dGhlDQo+Pj4+Pj4+IGludHJvZHVjdGlvbiBvZiBjb2RlIHRoYXQgZW5kcyB1cCBkZWFkIHRoZXJl Lg0KPj4+Pj4+IFdoYXQncyB3cm9uZyB3aXRoIHRoaXMgZnVuY3Rpb24gZXZlbiBpZiBpdCBpcyBh IG9uZS1saW5lcj8NCj4+Pj4+IFRoZSBjb21tZW50IGlzIHByaW1hcmlseSBvbiB0aGUgZWFybGll ciBmdW5jdGlvbiwgYW5kIHRoZW4gZXh0ZW5kcyB0bw0KPj4+Pj4gdGhpcyBvbmUuDQo+Pj4+Pg0K Pj4+Pj4+IFRoaXMgd2F5IHdlIGhhdmUgYSBwYWlyIHZwY2lfYmFyX2FkZF9oYW5kbGVycy92cGNp X2Jhcl9yZW1vdmVfaGFuZGxlcnMNCj4+Pj4+PiBhbmQgaWYgSSB1bmRlcnN0b29kIGNvcnJlY3Rs eSB5b3Ugc3VnZ2VzdCB2cGNpX2Jhcl9hZGRfaGFuZGxlcnMvdnBjaV9yZW1vdmVfZGV2aWNlX3Jl Z2lzdGVycz8NCj4+Pj4+PiBXaGF0IHdvdWxkIHdlIGdhaW4gZnJvbSB0aGF0LCBidXQgeWV0IGFu b3RoZXIgc2VjcmV0IGtub3dsZWRnZSB0aGF0IGluIG9yZGVyDQo+Pj4+Pj4gdG8gcmVtb3ZlIEJB UiBoYW5kbGVycyBvbmUgbmVlZHMgdG8gY2FsbCB2cGNpX3JlbW92ZV9kZXZpY2VfcmVnaXN0ZXJz DQo+Pj4+Pj4gd2hpbGUgSSB3b3VsZCBwZXJzb25hbGx5IGV4cGVjdCB0byBjYWxsIHZwY2lfYmFy X2FkZF9oYW5kbGVycycgY291bnRlcnBhcnQsDQo+Pj4+Pj4gdnBjaV9yZW1vdmVfZGV2aWNlX3Jl Z2lzdGVycyBuYW1lbHkuDQo+Pj4+PiBUaGlzIGlzIGFsbCBmaW5lLiBZZXQgdnBjaV9iYXJfe2Fk ZCxyZW1vdmV9X2hhbmRsZXJzKCkgd2lsbCwgYWl1aSwgYmUNCj4+Pj4+IGRlYWQgY29kZSBvbiB4 ODYuDQo+Pj4+IHZwY2lfYmFyX2FkZF9oYW5kbGVycyB3aWxsIGJlIHVzZWQgYnkgeDg2IFBWSCBE b20wDQo+Pj4gV2hlcmUgLyB3aGVuPyBZb3UgYWRkIGEgY2FsbCBmcm9tIHZwY2lfYXNzaWduX2Rl dmljZSgpLCBidXQgYmVzaWRlcyB0aGF0DQo+Pj4gYWxzbyBiZWluZyBkZWFkIGNvZGUgb24geDg2 IChmb3Igbm93KSwgeW91IGNhbid0IG1lYW4gdGhhdCBiZWNhdXNlDQo+Pj4gdnBjaV9kZWFzc2ln bl9kZXZpY2UoKSBhbHNvIGNhbGxzIHZwY2lfYmFyX3JlbW92ZV9oYW5kbGVycygpLg0KPj4gWW91 IGFyZSByaWdodCBoZXJlIGFuZCBib3RoIGFkZC9yZW1vdmUgYXJlIG5vdCB1c2VkIG9uIHg4NiBQ VkggRG9tMC4NCj4+DQo+PiBJIGFtIHNvcnJ5IGZvciB3YXN0aW5nIHlvdXIgdGltZQ0KPj4NCj4+ Pj4+ICAgICBIZW5jZSB0aGVyZSBzaG91bGQgYmUgYW4gYXJyYW5nZW1lbnQgYWxsb3dpbmcgdGhl DQo+Pj4+PiBjb21waWxlciB0byBlbGltaW5hdGUgdGhpcyBkZWFkIGNvZGUuDQo+Pj4+IFNvLCB0 aGUgb25seSBkZWFkIGNvZGUgZm9yIHg4NiBoZXJlIHdpbGwgYmUgdnBjaV9iYXJfcmVtb3ZlX2hh bmRsZXJzLiBZZXQuDQo+Pj4+IEJlY2F1c2UgSSBob3BlIHg4NiB0byBnYWluIGd1ZXN0IHN1cHBv cnQgZm9yIFBWSCBEb20wIHNvb25lciBvciBsYXRlci4NCj4+Pj4NCj4+Pj4+ICAgICBXaGV0aGVy IHRoYXQncyBlbmNsb3NpbmcgdGhlc2UNCj4+Pj4+IGJ5ICIjaWZkZWYiIG9yIGFkZGluZyBlYXJs eSAiaWYoIUlTX0VOQUJMRUQoQ09ORklHXyopKSIgaXMgc2Vjb25kYXJ5Lg0KPj4+Pj4gVGhpcyBo YXMgYSBrbm9jay1vbiBlZmZlY3Qgb24gb3RoZXIgZnVuY3Rpb25zIGFzIHlvdSBjZXJ0YWlubHkg cmVhbGl6ZToNCj4+Pj4+IFRoZSBjb21waWxlciBzZWVpbmcgZS5nLiB0aGUgMm5kIGFyZ3VtZW50 IHRvIHRoZSBhZGQtQkFScyBmdW5jdGlvbg0KPj4+Pj4gYWx3YXlzIGJlaW5nIHRydWUgYWxsb3dz IGl0IHRvIGluc3RhbnRpYXRlIGp1c3QgYSBjbG9uZSBvZiB0aGUgb3JpZ2luYWwNCj4+Pj4+IGZ1 bmN0aW9uIHdpdGggdGhlIHJlc3BlY3RpdmUgY29uZGl0aW9uYWxzIHJlbW92ZWQuDQo+Pj4+IFdp dGggdGhlIGFib3ZlIChlLmcuIGFkZCBpcyBnb2luZyB0byBiZSB1c2VkLCBidXQgbm90IHJlbW92 ZSkgZG8geW91DQo+Pj4+IHRoaW5rIGl0IGlzIHdvcnRoIHBsYXlpbmcgd2l0aCBpZmRlZidzIHRv IHN0cmlwIHRoYXQgc2luZ2xlIGZ1bmN0aW9uIGFuZCBhZGQNCj4+Pj4gYSBwaWVjZSBvZiBzcGFn aGV0dGkgY29kZSB0byBzYXZlIGEgYml0Pw0KPj4+IE5vLCB0aGF0IEkgYWdyZWUgd291bGRuJ3Qg YmUgd29ydGggaXQuDQo+Pj4NCj4+Pj4gV2hhdCB3b3VsZCB0aGF0IGlmZGVmIGxvb2sgbGlrZSwN Cj4+Pj4gZS5nLiAjaWZkZWYgQ09ORklHX0FSTSBvciAjaWZuZGVmIENPTkZJR19YODYgJiYgYW55 IG90aGVyIHBsYXRmb3JtLCBidXQgQVJNPw0KPj4+IEEgbmV3IHNldHRpbmcsIHByZWZlcmFibHk7 IGUuZy4gVkNQVV9VTlBSSVZJTEVHRUQsIHRvIGJlICJzZWxlY3QiZWQgYnkNCj4+PiBhcmNoaXRl Y3R1cmVzIGFzIGZ1bmN0aW9uYWxpdHkgZ2V0cyBlbmFibGVkLg0KPj4gU28sIGFzIGFkZC9yZW1v dmUgYXJlIG9ubHkgbmVlZGVkIGZvciBBcm0gYXQgdGhlIG1vbWVudA0KPj4geW91IHN1Z2dlc3Qg SSBhZGQgVkNQVV9VTlBSSVZJTEVHRUQgdG8gQXJtJ3MgS2NvbmZpZyB0byBlbmFibGUNCj4+IGNv bXBpbGluZyB2cGNpX2Jhcl9hZGRfaGFuZGxlcnMvdnBjaV9iYXJfcmVtb3ZlX2hhbmRsZXJzPw0K Pj4gVG8gbWUgdGhpcyBpcyBtb3JlIGFib3V0IHZQQ0kncyBzdXBwb3J0IGZvciBndWVzdHMsIHNv IHNob3VsZCB3ZSBwcm9iYWJseSBjYWxsIGl0DQo+PiBWUENJX1hYWCBpbnN0ZWFkPyBFLmcuIFZQ Q0lfSEFTX0dVRVNUX1NVUFBPUlQgb3Igc29tZXRoaW5nIHdoaWNoDQo+PiB3aWxsIHJlZmxlY3Qg dGhlIG5hdHVyZSBvZiB0aGUgY29kZSBiZWluZyBnYXRlZD8gVkNQVV9VTlBSSVZJTEVHRUQgc291 bmRzDQo+PiBsaWtlIG5vdCBjb25uZWN0ZWQgdG8gdnBjaSB0byBtZQ0KPiBBbmQgdmFsaWRseSBz byAtIG15IGZpbmdlcnMgZGlkbid0IHR5cGUgd2hhdCB0aGUgYnJhaW4gdG9sZCB0aGVtLiBJJ3Zl DQo+IG1lYW50IFZQQ0lfVU5QUklWSUxFR0VELiBJIHdvdWxkIGFsc28gYmUgb2theSB3aXRoIEhB U19WUENJX0dVRVNUX1NVUFBPUlQNCj4gKGkuZS4gbm90IGV4YWN0bHkgd2hhdCB5b3UndmUgc3Vn Z2VzdGVkKSwgZm9yIGV4YW1wbGUuDQpJJ2xsIHN0aWNrIHRvIEhBU19WUENJX0dVRVNUX1NVUFBP UlQgYXMgaXQgc2VlbXMgdG8gYmUgbW9yZSBkZXNjcmlwdGl2ZQ0KPiBKYW4NCj4NClRoYW5rIHlv dSwNCg0KT2xla3NhbmRyDQo= From xen-devel-bounces@lists.xenproject.org Tue Sep 07 12:31:01 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 12:31:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.181010.327954 (Exim 4.92) (envelope-from ) id 1mNaFa-0000jx-MA; Tue, 07 Sep 2021 12:30:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 181010.327954; Tue, 07 Sep 2021 12:30:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNaFa-0000jq-Iy; Tue, 07 Sep 2021 12:30:54 +0000 Received: by outflank-mailman (input) for mailman id 181010; Tue, 07 Sep 2021 12:30:53 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNaFZ-0000jk-CN for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 12:30:53 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNaFV-0003uY-RY; Tue, 07 Sep 2021 12:30:49 +0000 Received: from [54.239.6.187] (helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1mNaFV-0003Kr-Kj; Tue, 07 Sep 2021 12:30:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=3WWgZmgWXQnQKchVGG3MzV2yIqBwyB+TS5pKQRzF5DY=; b=T8nMCBhO8U7R7fpQOm/3AmZiNy BSjLYkXc2v9mwDZdUqnP3mblMQESiVKe56E4oIqtn/Gqv/ITJYxV7IrWT3G/ypHI35g6Ew0FX8dBo ZTMIxkD3PSnNL2ZoUxaKUg3saHP1Noo+tV4TReHtvezUHSu+vX5X4YCDhL5T4eJQ0ydE=; Subject: Re: [RFC PATCH] xen/design: Add design for EFI dom0less system start To: Luca Fancellu Cc: xen-devel@lists.xenproject.org, Bertrand Marquis , wei.chen@arm.com, Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Stefano Stabellini , Wei Liu References: <20210907065228.21794-1-luca.fancellu@arm.com> <4bab7902-0268-5705-5462-fcd7571d7492@xen.org> <7BD59287-75ED-4D4F-B892-F6B04583A986@arm.com> From: Julien Grall Message-ID: <1efbd9a8-232b-b267-fa8e-7f5f1af7cfed@xen.org> Date: Tue, 7 Sep 2021 13:30:47 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <7BD59287-75ED-4D4F-B892-F6B04583A986@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit On 07/09/2021 12:51, Luca Fancellu wrote: > > >> On 7 Sep 2021, at 10:35, Julien Grall wrote: >> >> Hi Luca, >> >> On 07/09/2021 07:52, Luca Fancellu wrote: >>> Add a design describing a proposal to improve the EFI >>> configuration file, adding keywords to describe domU >>> guests and allowing to start a dom0less system. >>> Signed-off-by: Luca Fancellu >>> --- >>> docs/designs/efi-arm-dom0less.md | 105 +++++++++++++++++++++++++++++++ >>> 1 file changed, 105 insertions(+) >>> create mode 100644 docs/designs/efi-arm-dom0less.md >>> diff --git a/docs/designs/efi-arm-dom0less.md b/docs/designs/efi-arm-dom0less.md >>> new file mode 100644 >>> index 0000000000..8d8fa2243f >>> --- /dev/null >>> +++ b/docs/designs/efi-arm-dom0less.md >>> @@ -0,0 +1,105 @@ >>> +# Xen EFI configuration file >>> + >>> +The current configuration file used by Xen when it is started as an EFI >>> +application is considering only the dom0 guest and doesn't have any >>> +property to describe and load in memory domU guests. >> >> From my understanding, the problem is less about properties (we already have them in the Device-Tree) but more about where are the binaries located in memory as we don't know in advance. > > Hi Julien, Hi Luca, > I think I used the wrong word there, I meant “keyword” instead of “property” because I was referring about the > lack of keywords to describe a domu guest in the Xen EFI configuration file. > > I agree with you that on systems with static allocation, the kernel and ramdisk binaries must be at certain locations > that are out of control when we use the EFI boot services, the thing we can do is provide a keyword to specify the > addresses and then use the CopyMem() function to relocate the kernel/ramdisk in the address we want. I wasn't specifically referring to static allocation here, sorry if this wasn't clear. I was pointing out that most of the information you create in the xen.cfg is going to be similar to what we already provide in the Device-Tree. My main concern is everytime we add a new feature in Dom0less, a developer would need to write code for the DT and UEFI. This will increase the code size and maintenance. The same can be said for the admin as if they want to switch from plain U-boot to UEFI, they would also need to fully rewrite the bindings. AFAICT, most of the information provided in the Device-Tree are usable even when using UEFI. So I would prefer if we try to re-use what's existing. This is what my proposal below was about. > >> >> So I would like to propose something that build on top of the Device-Tree work we did. Note this is early thoughts. >> >> The problematic nodes in the DT are: >> >> module@0x4a000000 { >> compatible = "multiboot,kernel", "multiboot,module"; >> reg = <0x0 0x4a000000 0xffffff>; >> bootargs = "console=ttyAMA0 init=/bin/sh"; >> }; >> >> module@0x4b000000 { >> compatible = "multiboot,ramdisk", "multiboot,module"; >> reg = <0x0 0x4b000000 0xffffff>; >> }; >> >> In particular the property "reg" cannot be known in advance because the UEFI stub will be responsible to load the binaries in memory. > > Yes that’s true, the UEFI stub is using from the UEFI boot service the AllocatePages function that is giving back an address out of our control, > then using another function the binary is read from the disk and copied at that address, finally the UEFI stub is writing the node in the device tree that > will be used by Xen later. I am not sure to follow. Are you saying the UEFI stub will create the dom0less node in the DT based on the xen.cfg? > >> >> What we could do is providing a list of binaries to load and associate a key for each of them. Something like: >> >> binary= >> binary= >> .... >> >> We can then replace the property "reg" with a new property "uefi,key" that will contain the name of the binary. >> >> What do you think? > > Here I’m lost, because I don’t understand what we are going to do with the name of the binary. would be used by the UEFI stub to load the binary in memory. Each binary will have a which helps to refer them in the Device-Tree. To give a concrete example, let say we have two dom0less domains: - DomA: 2 vCPUs, 128MB - DomB: 3 vCPUs, 512MB DomA and DomB will be using the same kernel but a different ramdisk. xen.cfg, would look like: [global] default=section1 [section1] options=console=vga,com1 com1=57600 loglvl=all noreboot kernel=vmlinuz-3.0.31-0.4-xen [domain 0 command line options] ramdisk=initrd-3.0.31-0.4-xen xsm= dtb=devtree.dtb binary=vmlinuz-guest domu-kernel binary=ramdisk-domA.img domA-ramdisk binary=ramdisk-domB.img domB-ramdisk The chosen node in the DT would look like: chosen { domU1 { compatible = "xen,domain"; #address-cells = <0x2>; #size-cells = <0x1>; memory = <0 0x8000000>; cpus = <2>; module@1 { compatible = "multiboot,kernel", "multiboot,module"; uefi,binary = "domu-kernel"; bootargs = "console=ttyAMA0 init=/bin/sh"; }; module@2 { compatible = "multiboot,ramdisk", "multiboot,module"; uefi,binary = "domA-ramdisk"; }; }; domU2 { compatible = "xen,domain"; #address-cells = <0x3>; #size-cells = <0x1>; memory = <0 0x20000000>; cpus = <3>; module@1 { compatible = "multiboot,kernel", "multiboot,module"; uefi,binary = "domu-kernel"; bootargs = "console=ttyAMA0 init=/bin/sh"; }; module@2 { compatible = "multiboot,ramdisk", "multiboot,module"; uefi,binary = "domA-ramdisk"; }; }; }; With this approach, the change is quite minimal to move between an classic U-boot boot and EFI boot. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Sep 07 13:04:23 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 13:04:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.181020.327968 (Exim 4.92) (envelope-from ) id 1mNaln-0005HL-CW; Tue, 07 Sep 2021 13:04:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 181020.327968; Tue, 07 Sep 2021 13:04:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNaln-0005HE-9a; Tue, 07 Sep 2021 13:04:11 +0000 Received: by outflank-mailman (input) for mailman id 181020; Tue, 07 Sep 2021 13:04:09 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNall-0005H8-9C for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 13:04:09 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (unknown [40.107.21.84]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 14d68826-0fdc-11ec-b0ef-12813bfff9fa; Tue, 07 Sep 2021 13:04:06 +0000 (UTC) Received: from DB6PR07CA0194.eurprd07.prod.outlook.com (2603:10a6:6:42::24) by AM9PR08MB6657.eurprd08.prod.outlook.com (2603:10a6:20b:308::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.21; Tue, 7 Sep 2021 13:04:01 +0000 Received: from DB5EUR03FT046.eop-EUR03.prod.protection.outlook.com (2603:10a6:6:42:cafe::fa) by DB6PR07CA0194.outlook.office365.com (2603:10a6:6:42::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.6 via Frontend Transport; Tue, 7 Sep 2021 13:04:01 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT046.mail.protection.outlook.com (10.152.21.230) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Tue, 7 Sep 2021 13:04:01 +0000 Received: ("Tessian outbound cc1d52552731:v105"); Tue, 07 Sep 2021 13:04:01 +0000 Received: from 23a0c5a7b7f6.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id C166E117-6975-49F0-AFC1-CC384A431CF3.1; Tue, 07 Sep 2021 13:03:55 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 23a0c5a7b7f6.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 07 Sep 2021 13:03:55 +0000 Received: from VE1PR08MB5215.eurprd08.prod.outlook.com (2603:10a6:803:10a::33) by VI1PR0802MB2495.eurprd08.prod.outlook.com (2603:10a6:800:b9::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.24; Tue, 7 Sep 2021 13:03:44 +0000 Received: from VE1PR08MB5215.eurprd08.prod.outlook.com ([fe80::adf8:8d6f:2a30:b60c]) by VE1PR08MB5215.eurprd08.prod.outlook.com ([fe80::adf8:8d6f:2a30:b60c%5]) with mapi id 15.20.4478.026; Tue, 7 Sep 2021 13:03:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 14d68826-0fdc-11ec-b0ef-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lt7nz3+gkmBFfx53RUPqJl18QGI12yP2CEb6pMBB8eY=; b=mMzhIMJfnGkg5sJZhXbqBqlZneJ8At/+5xIXkZJtpckK41qMqITXdV5B/rGlhUy8Lq8X8UobkUlXXkmANqYSO00xMxJsVjxQltpC+40u5pmAb4FJ8Ao6nbqm1bL3Aec4yIihYX0TfkK3E7N/by2NEt5fVyBmdj5iUQzP/6/YZ/E= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=D72jRvCceZEB+y0SwSXVvcVohsoIZQAH6kJ5B05hVF9yiveiknPNMR2w0W5EqqwY09W0JbJIuW/RkLO/YhSjuWjVe8PBbSwOMMlyGgwTiEZcvLPJ3IMdEEi4YPRqlFZ6RUCySye+hNFOcfsASEGnAePOnUAt4T9DFf48zoZZ96Hqe3eADa4IbrDRqGLCxIAte8KeJLNiyv6tSu+nov9KH8SwuE/EAM4UJOgwYmFHxDYapbKH5zScw5y/vtEzSr7hSfjwqkiqmr9bxAn/g2e74ito3ZHgkHS1ynBDYTvnwJ9Lh57X1jkawFnCjjg7fiV4+60+WdQb2uLHY8m44cI2lw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=lt7nz3+gkmBFfx53RUPqJl18QGI12yP2CEb6pMBB8eY=; b=TT+2GGFC9ifj9zzHRMx1B0cnEf1HQvrWg7svxwetC2h3nUQLl4C2rdgorlqfTIDmNi1k8o63/A+XwAg9cf+JQwCwvcu4YW5umCsQiLxJ6qV8sM6vqPvAkzL2mGq4KsCwi8JQFBNayGYPipwMHvKDdS9qemed5RmkUH7q0W7sv2wIJV1ZBUkx4jlIcq1A4+Y8bmJLWDaDlR1a95ImVcWRxDMjbeUdJUGvI1sNoUJfzADq6w5HIrLwVrDrSLlwhbODmspitB8w0t7/jY3CUPshs1ACgBApGo9QIWYYjr0gtQDv/aPBIMNxTMrumv5k5WL+n6lJdhOgdBMPGSOW1BiGEw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lt7nz3+gkmBFfx53RUPqJl18QGI12yP2CEb6pMBB8eY=; b=mMzhIMJfnGkg5sJZhXbqBqlZneJ8At/+5xIXkZJtpckK41qMqITXdV5B/rGlhUy8Lq8X8UobkUlXXkmANqYSO00xMxJsVjxQltpC+40u5pmAb4FJ8Ao6nbqm1bL3Aec4yIihYX0TfkK3E7N/by2NEt5fVyBmdj5iUQzP/6/YZ/E= From: Penny Zheng To: "julien@xen.org" , Stefano Stabellini , "xen-devel@lists.xenproject.org" CC: Bertrand Marquis , Wei Chen Subject: Error around cc-option on AArch64 Thread-Topic: Error around cc-option on AArch64 Thread-Index: Adej51APmfJVGMySS/6ID827i8copQ== Date: Tue, 7 Sep 2021 13:03:43 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 97094123F4E8D840B972E8AF26637690.0 x-checkrecipientchecked: true Authentication-Results-Original: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com; x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: 8611c997-becc-42b9-2221-08d971fff64f x-ms-traffictypediagnostic: VI1PR0802MB2495:|AM9PR08MB6657: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:143;OLM:143; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: mpXF8MSfoGP6DHGiNesV8ORQkS1Pa/sbHQ/G4cYO9YI7wfqBraxdmEkM8FFh5rL5gppWKoqy3bz9xpXMkI/YHvya1fX+INI56QAKBYFn0CKDY88202GL8D7kCGIs8Gegje7ua/wTKkFAxVMsiCnDdL+ORlKBpBJ7hIRHxqeTddElNoP+Ob3Ya0BBgPXufEIuLdDEDqITDytsT0FSsfro/gkN5/Vv0hMNT62l6w0DWp/sRGnBjm06MgAl8Rb2wDMezREFPx9LBDsPyW1u0kq3uKgRDxvZbtS9mZSsFME+a7YPgWRzTk5/sdwA9RHMQhdLginqkXlGXrCJbCFK6c5pWQlzCz56sPT3aSEsBTqYzZCqY0vbD6ctsbVY1xP3qrvhaCoDy27SQ+p9SZ6QJ+O8JSr3vYq8QOgUwr7XHA0fKoq73jXqFkdfVxAN5SBNN0y+V6gC3SJmsFYTLfT9jjkP9LXAAw/3Lcl3Ygt066HFONk/Q4t0cnisFOsgT6XkYBHgvkn+MGqQW/D8wbVXb9l/Tv5QZorqI4uA9CIwuHTOjaMJmaVTcp9AMYlMYnlsKaTKQbrS391T6g0phqCwwC4TeLQeyKqHAWluLBX5kgv0rOjUj15o24nZVSLuqYwQ4QCFb1ETDBoSzfrLj8+nR0VvsfdKgJGuwBtJzjtcs9DPe+zxhoP2PEKmmZyYFyXbX6ctq9yNbPWn5vgUb8sAacG0vRfg33gRnLVO4GVQsTXtkGdm7ifsZdfPU+40ItCd/uVYQSuE7vOGwKEwbUy/Aa3LisQ6NGFrROVlyYSpJxV37mg= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR08MB5215.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(376002)(136003)(39860400002)(346002)(366004)(8936002)(33656002)(71200400001)(5660300002)(966005)(52536014)(26005)(7696005)(83380400001)(186003)(166002)(76116006)(316002)(66446008)(9686003)(2906002)(86362001)(66946007)(6506007)(66556008)(8676002)(478600001)(38100700002)(4326008)(122000001)(54906003)(66476007)(110136005)(55016002)(64756008)(38070700005);DIR:OUT;SFP:1101; Content-Type: multipart/alternative; boundary="_000_VE1PR08MB5215CBA5B28A1FB90D7B161FF7D39VE1PR08MB5215eurp_" MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0802MB2495 Original-Authentication-Results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT046.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 9353f8bd-7fb8-4b60-9300-08d971ffec03 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: eVFPnxr+toddTC4McmtC1MLNYEeRIFLYCOuziz9P+zcUTQbcHTfUKtmTco20LMnIyWR1GUX44RpSYrDAhnNnpWf5/4wBlNz0zJ6S8bwpaymKIZ2Or5TsIRpURij31pwtndTeIil4bug6wFkYT73qUqWxbkuCJICUIuJnU4lcRwqziWDc9aHLW/waiIwyAj4Uo4w3wiR67MwXuQtlBpamyZZERFKlDScEF/bG1kzaLgbCE/yYuZqtliMuVNrTeoFsLaDLTlpU/1hRLsQv19c+B7xuM+ZpunveNQ+rZ5oef5bkQXS9DiEeURYJD/vIPC7k2pz/UmpcpkPgpMcX3WJt1BDq8kRH5tWngPkpCS1yTWjfYbaxB5RW1n3owd0BrPPB3QWVj4l9v58dVRqh2yS9Ooqi8j7KqdPlImBkjXZQZmgyzHSbS8fxvkGLaFcXy0mbKFij0ZfbTlwD8dY208KLvqYVJ0bItU919ZkKyvT5pwm+7sVIKoBkC74jeZI6VjrDrBi8cjFiaOV3HIvHz0H3CN4l0s+0rqWUANtp4+CprvNU6A7+HtMmd0G1KFZEZsGunf4ARhgSbviHd3whvVSX7IU9TZI7n1b65ZMb8KSNrCRil5R16DLIq1AACTLb1/WMAd6JixZmC6sTxTq6fxT/0v8l8dusoIkz5IruCO1DbYQByc8u8GNXuB7XlNcq+sYummOQ7ARNpsTROh4j564uy5fS7gDVovPnjFOU2qJ4NJKP5lh2DfMxymlu3ePoQsL1YgE7z2jhbxZEWDzU59v4U0VXI+J0I2Eddoazay1ygRuQ47nBCko9a/cq2itiR1z2 X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(39860400002)(396003)(346002)(376002)(136003)(36840700001)(46966006)(336012)(52536014)(36860700001)(5660300002)(54906003)(4326008)(966005)(9686003)(7696005)(82310400003)(55016002)(2906002)(8936002)(110136005)(70586007)(26005)(82740400003)(166002)(47076005)(356005)(70206006)(6506007)(8676002)(478600001)(186003)(86362001)(83380400001)(33656002)(316002)(81166007)(21314003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2021 13:04:01.2536 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8611c997-becc-42b9-2221-08d971fff64f X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT046.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB6657 --_000_VE1PR08MB5215CBA5B28A1FB90D7B161FF7D39VE1PR08MB5215eurp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Julien and Stefano I found that the "cc-option/cc-option-add" is not working for "-march=3Dxxx= " option on a few very common aarch64 compilers. Here is what I got when trying to compile XEN on r82 platform. ``` diff --git a/xen/arch/arm/arch.mk b/xen/arch/arm/arch.mk index 11caec86ba..d2d71baef4 100644 --- a/xen/arch/arm/arch.mk +++ b/xen/arch/arm/arch.mk @@ -10,6 +10,10 @@ $(call cc-option-add,CFLAGS,CC,-Wnested-externs) CFLAGS-$(CONFIG_ARM_32) +=3D -msoft-float CFLAGS-$(CONFIG_ARM_32) +=3D -mcpu=3Dcortex-a15 +#ifeq ($(CONFIG_ARM64_V8R),y) + CFLAGS-$(CONFIG_ARM_64) +=3D $(call cc-option,$(CC),-march=3Darmv8-r,-= march=3Darmv8.4-a) +#endif + CFLAGS-$(CONFIG_ARM_64) +=3D -mcpu=3Dgeneric CFLAGS-$(CONFIG_ARM_64) +=3D -mgeneral-regs-only # No fp registers etc $(call cc-option-add,CFLAGS-$(CONFIG_ARM_64),CC,-mno-outline-atomics) ``` My gcc compiler version is as follows: ``` Using built-in specs. COLLECT_GCC=3Daarch64-linux-gnu-gcc COLLECT_LTO_WRAPPER=3D/usr/lib/gcc-cross/aarch64-linux-gnu/9/lto-wrapper Target: aarch64-linux-gnu Configured with: ../src/configure -v --with-pkgversion=3D'Ubuntu 9.3.0-17ub= untu1~20.04' --with-bugurl=3Dfile:///usr/share/doc/gcc-9/README.Bugs --enable-languages= =3Dc,ada,c++, go,d,fortran,objc,obj-c++,gm2 --prefix=3D/usr --with-gcc-major-version-only= --program-suffix=3D-9 --enable-shared --enable-linker-build-id --libexecdir=3D/usr/lib --without-= included-gettext --enable-threads=3Dposix --libdir=3D/usr/lib --enable-nls --with-sysroot=3D= / --enable-clocale=3Dgnu --enable-libstdcxx-debug --enable-libstdcxx-time=3Dyes --with-default-libst= dcxx-abi=3Dnew --enable-gnu-unique-object --disable-libquadmath --disable-libquadmath-supp= ort --enable-plugin --enable-default-pie --with-system-zlib --without-target-system-zlib --enab= le-libpth-m2 --enable-multiarch --enable-fix-cortex-a53-843419 --disable-werror --enable-checking=3Drelease= --build=3Dx86_64-linux-gnu --host=3Dx86_64-linux-gnu --target=3Daarch64-linux-gnu --program-prefix=3Da= arch64-linux-gnu- --includedir=3D/usr/aarch64-linux-gnu/include Thread model: posix gcc version 9.3.0 (Ubuntu 9.3.0-17ubuntu1~20.04) ``` However. even if my gcc compiler is indeed not supporting "-march=3Darmv8-r= ", above check will not identify it "unrecognized option" and seek to the "-march=3Darmv8.4-a" as expected. See the resulting errors, it still uses "-march=3Darmv8-r": ``` make[3]: Entering directory '/home/penny/FVP/r82/fvp_aemv8r_cortexr82_0.0_6= 347_gcc6.4/xen/xen' aarch64-linux-gnu-gcc -MMD -MP -MF ./.asm-offsets.s.d -DBUILD_ID -fno-stric= t-aliasing -std=3Dgnu99 -Wall -Wstrict-prototypes -Wdeclaration-after-statement -Wno-unused-but-set-varia= ble -Wno-unused-local-typedefs -O1 -fno-omit-frame-pointer -nostdinc -fno-builtin -fno-common -Werror -Wre= dundant-decls -Wno-pointer-arith -Wvla -pipe -D__XEN__ -include /home/penny/FVP/r82/fvp_aemv8r_cortexr82_0.0_6347_= gcc6.4/xen/xen/include/xen/config.h -g -march=3Darmv8-r -mgeneral-regs-only -mno-outline-atomics -I/home/penny/= FVP/r82/fvp_aemv8r_cortexr82_0.0_6347_gcc6.4 /xen/xen/include -fno-stack-protector -fno-exceptions -fno-asynchronous-unw= ind-tables -fcf-protection=3Dnone -Wnested-externs '-D__OBJECT_FILE__=3D"asm-offsets.s"' -S -g0 -o asm-offset= s.s.new -MQ asm-offsets.s arch/arm/arm64/asm-offsets.c cc1: error: unknown value 'armv8-r' for '-march' cc1: note: valid arguments are: armv8-a armv8.1-a armv8.2-a armv8.3-a armv8= .4-a armv8.5-a; did you mean 'armv8-a'? make[3]: *** [Makefile:413: asm-offsets.s] Error 1 ``` And the reason is that in the implementation of "cc-option": To handle this= we do a test compile, passing the option-under-test, on a code fragment that will always produce a warning (integer assigned to = pointer). We then grep for the option-under-test in the compiler's output, the presence of which would indicate an "unrecognize= d command-line option" warning/error. ``` cc-option =3D $(shell if test -z "`echo 'void*p=3D1;' | \ $(1) $(2) -S -o /dev/null -x c - 2>&1 | grep -- $(2) -= `"; \ then echo "$(2)"; else echo "$(3)"; fi ;) ``` Here, that is, we are trying to grep "-march=3Darmv8-r" in output message o= f the test compile, and since the output message(unknown value 'armv8-r' for '-march') doesn't contain the COMPLETE = string, it thought the compiler supported this option, but it actually not... Tracing back to the commit about the implementation of "cc-option", it disc= ards the linux method(using exit code to tell) for dealing with disable-warning options. See https://github.com/xen-project/xen/commit/28f8fb7d2b3fde2f5cbe5526ac4f1= c932e3f5d26 for more details. To fix this issue, I could loose the "grep check", instead trying to grep t= he COMPLETE option string("-march=3Darmv8-r"), only partial(armv8-r) is enough. But, hmmm, the way of greping output message to check is kinds of r= eliable, IMO, since there is no standard for that. What do you suggest? Cheers -- Penny Zheng --_000_VE1PR08MB5215CBA5B28A1FB90D7B161FF7D39VE1PR08MB5215eurp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

Hi Julien and Stefano

 

I found that the “cc-option/cc-option-add̶= 1; is not working for “-march=3Dxxx” option on a few very commo= n aarch64 compilers.

Here is what I got when trying to compile XEN on r82= platform.

```

diff --git a/xen/arch/arm/arch.mk b/xen/arch/arm/arc= h.mk

index 11caec86ba..d2d71baef4 100644

--- a/xen/arch/arm/arch.mk

+++ b/xen/arch/arm/arch.mk

@@ -10,6 +10,10 @@ $(call cc-option-add,CFLAGS,CC,-W= nested-externs)

CFLAGS-$(CONFIG_ARM_32) +=3D -msoft-float=

CFLAGS-$(CONFIG_ARM_32) +=3D -mcpu=3Dcortex-a15=

 

+#ifeq ($(CONFIG_ARM64_V8R),y)

+    CFLAGS-$(CONFIG_ARM_64) +=3D $(c= all cc-option,$(CC),-march=3Darmv8-r,-march=3Darmv8.4-a)

+#endif

+

CFLAGS-$(CONFIG_ARM_64) +=3D -mcpu=3Dgeneric

CFLAGS-$(CONFIG_ARM_64) +=3D -mgeneral-regs-only # N= o fp registers etc

$(call cc-option-add,CFLAGS-$(CONFIG_ARM_64),CC,-mno= -outline-atomics)

```

My gcc compiler version is as follows:

```

Using built-in specs.

COLLECT_GCC=3Daarch64-linux-gnu-gcc

COLLECT_LTO_WRAPPER=3D/usr/lib/gcc-cross/aarch64-lin= ux-gnu/9/lto-wrapper

Target: aarch64-linux-gnu

Configured with: ../src/configure -v --with-pkgversi= on=3D'Ubuntu 9.3.0-17ubuntu1~20.04'

--with-bugurl=3Dfile:///usr/share/doc/gcc-9/README.B= ugs --enable-languages=3Dc,ada,c++,

go,d,fortran,objc,obj-c++,gm2 --prefix=3D/usr --with= -gcc-major-version-only --program-suffix=3D-9

--enable-shared --enable-linker-build-id --libexecdi= r=3D/usr/lib --without-included-gettext

--enable-threads=3Dposix --libdir=3D/usr/lib --enabl= e-nls --with-sysroot=3D/ --enable-clocale=3Dgnu

--enable-libstdcxx-debug --enable-libstdcxx-time=3Dy= es --with-default-libstdcxx-abi=3Dnew

--enable-gnu-unique-object --disable-libquadmath --d= isable-libquadmath-support --enable-plugin

--enable-default-pie --with-system-zlib --without-ta= rget-system-zlib --enable-libpth-m2 --enable-multiarch

--enable-fix-cortex-a53-843419 --disable-werror --en= able-checking=3Drelease --build=3Dx86_64-linux-gnu

--host=3Dx86_64-linux-gnu --target=3Daarch64-linux-g= nu --program-prefix=3Daarch64-linux-gnu- --includedir=3D/usr/aarch64-linux-= gnu/include

Thread model: posix

gcc version 9.3.0 (Ubuntu 9.3.0-17ubuntu1~20.04)

```

However. even if my gcc compiler is indeed not suppo= rting “-march=3Darmv8-r”, above check will not identify it=

“unrecognized option” and seek to the &#= 8220;-march=3Darmv8.4-a” as expected.

See the resulting errors, it still uses “-marc= h=3Darmv8-r”:

```

make[3]: Entering directory '/home/penny/FVP/r82/fvp= _aemv8r_cortexr82_0.0_6347_gcc6.4/xen/xen'

aarch64-linux-gnu-gcc -MMD -MP -MF ./.asm-offsets.s.= d -DBUILD_ID -fno-strict-aliasing -std=3Dgnu99 -Wall

-Wstrict-prototypes -Wdeclaration-after-statement -W= no-unused-but-set-variable -Wno-unused-local-typedefs

-O1 -fno-omit-frame-pointer -nostdinc -fno-builtin -= fno-common -Werror -Wredundant-decls -Wno-pointer-arith -Wvla

-pipe -D__XEN__ -include /home/penny/FVP/r82/fvp_aem= v8r_cortexr82_0.0_6347_gcc6.4/xen/xen/include/xen/config.h

-g -march=3Darmv8-r -mgeneral-regs-only -mno-outline= -atomics -I/home/penny/FVP/r82/fvp_aemv8r_cortexr82_0.0_6347_gcc6.4

/xen/xen/include -fno-stack-protector -fno-exception= s -fno-asynchronous-unwind-tables -fcf-protection=3Dnone

-Wnested-externs '-D__OBJECT_FILE__=3D"asm-offs= ets.s"' -S -g0 -o asm-offsets.s.new -MQ asm-offsets.s arch/arm/arm64/a= sm-offsets.c

cc1: error: unknown value ‘armv8-r’ for = ‘-march’

cc1: note: valid arguments are: armv8-a armv8.1-a ar= mv8.2-a armv8.3-a armv8.4-a armv8.5-a; did you mean ‘armv8-a’?<= o:p>

make[3]: *** [Makefile:413: asm-offsets.s] Error 1

```

And the reason is that in the implementation of R= 20;cc-option”: To handle this we do a test compile, passing the optio= n-under-test,

on a code fragment that will always produce a warnin= g (integer assigned to pointer). We then grep for the option-under-test in<= o:p>

the compiler's output, the presence of which would i= ndicate an "unrecognized command-line option" warning/error.=

```

cc-option =3D $(shell if test -z "`echo 'void*p= =3D1;' | \

        &nbs= p;            $(1) $= (2) -S -o /dev/null -x c - 2>&1 | grep -- $(2) -`"; \

        &nbs= p;            then e= cho "$(2)"; else echo "$(3)"; fi ;)

```

Here, that is, we are trying to grep “-march= =3Darmv8-r” in output message of the test compile, and since the outp= ut

message(unknown value ‘armv8-r’ for R= 16;-march’) doesn’t contain the COMPLETE string, it thought the= compiler supported this

option, but it actually not…

 

Tracing back to the commit about the implementation = of “cc-option”, it discards the linux method(using exit code to= tell) for dealing with

disable-warning options.

See https://github.com/xen-project/xen/commit/28f8fb7d2b3fde2f5cbe5526ac4f1c932= e3f5d26 for more details.

 

To fix this issue, I could loose the “grep che= ck”, instead trying to grep the COMPLETE option string(“-march= =3Darmv8-r”), only partial(armv8-r) is

enough. But, hmmm, the way of greping output message= to check is kinds of reliable, IMO, since there is no standard for that.

What do you suggest?

 

Cheers

 

--

Penny Zheng

 

--_000_VE1PR08MB5215CBA5B28A1FB90D7B161FF7D39VE1PR08MB5215eurp_-- From xen-devel-bounces@lists.xenproject.org Tue Sep 07 13:09:50 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 13:09:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.181027.327980 (Exim 4.92) (envelope-from ) id 1mNarD-00060a-6O; Tue, 07 Sep 2021 13:09:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 181027.327980; Tue, 07 Sep 2021 13:09:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNarD-00060T-3J; Tue, 07 Sep 2021 13:09:47 +0000 Received: by outflank-mailman (input) for mailman id 181027; Tue, 07 Sep 2021 13:09:46 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNarC-00060N-41 for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 13:09:46 +0000 Received: from sender4-of-o51.zoho.com (unknown [136.143.188.51]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 6c39c5b0-5c72-4792-bbfc-2b90ee5247fc; Tue, 07 Sep 2021 13:09:44 +0000 (UTC) Received: from [10.10.1.146] (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1631020175056268.27192467139764; Tue, 7 Sep 2021 06:09:35 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6c39c5b0-5c72-4792-bbfc-2b90ee5247fc ARC-Seal: i=1; a=rsa-sha256; t=1631020180; cv=none; d=zohomail.com; s=zohoarc; b=Bpqq9silydKZDS3unZW4woy8Lpxr6mBVys9wZHwLDmGkSFBvcuz26I72Qa5w45tC2IbZ676RjubXimUoLx+0k9RS6xpUySVwtIKJwfklno6c+4AVRBEs38tKlS+Aj3ga1PX0JERzJBDyvhQT/ye1KjeIksyipXXARdYmYmo1kp0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1631020180; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=D/hKG9aSJpSBbbyNnfJLMboaDfUK/6nKEu6OPyO+A24=; b=IJklqAFis6wcZh2pny0SbFa7MHqePfvYMUHMa2KxPZF7cQYguPbHcb+gsuviFx7PBg/6dPVxN1eHwQZS2VdPgsRdPQVcoFsGHitXKo9MsnFremxjfqEDUdSJF2NcnnOE5HilbVjDwBf4ktlY71ZrO3IWV1G0aUoFBD8+8xo/prw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1631020180; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Subject:To:Cc:References:From:Message-ID:Date:MIME-Version:In-Reply-To:Content-Type:Content-Transfer-Encoding; bh=D/hKG9aSJpSBbbyNnfJLMboaDfUK/6nKEu6OPyO+A24=; b=kNCDrjwqigiY0hOgCyTNR7okXsPNdvhQ1HLl4oaSyZDed8X7D/1TjQIgKpLyis8P syoixqwlifuPMOaA7SJZ7u59+ZxZFro3ykKzc/JTd9Qi226kSxHGwpLE9wFF+wksekS cPmFSB0CHYUILPVxxOv59D5r6eW37NJ2FlXr1apA= Subject: Re: [PATCH v4 01/11] xen: Implement xen/alternative-call.h for use in common code To: Jan Beulich , Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Bob Eshleman , Alistair Francis , Connor Davis , George Dunlap , Ian Jackson , Wei Liu , xen-devel@lists.xenproject.org References: <20210903190629.11917-1-dpsmith@apertussolutions.com> <20210903190629.11917-2-dpsmith@apertussolutions.com> <3a91e4ad-50c4-205f-3d90-f23c996b2938@suse.com> <8c3dfbf5-5c98-c923-ca81-28af3d13c4a4@citrix.com> <7e71ce74-dd81-21c3-db78-c37d95d5b239@suse.com> From: "Daniel P. Smith" Message-ID: Date: Tue, 7 Sep 2021 09:07:50 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <7e71ce74-dd81-21c3-db78-c37d95d5b239@suse.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-ZohoMailClient: External On 9/7/21 2:00 AM, Jan Beulich wrote: > On 06.09.2021 18:22, Andrew Cooper wrote: >> On 06/09/2021 16:52, Jan Beulich wrote: >>> On 03.09.2021 21:06, Daniel P. Smith wrote: >>>> --- /dev/null >>>> +++ b/xen/include/xen/alternative-call.h >>>> @@ -0,0 +1,63 @@ >>>> +/* SPDX-License-Identifier: GPL-2.0 */ >>>> +#ifndef XEN_ALTERNATIVE_CALL >>>> +#define XEN_ALTERNATIVE_CALL >>>> + >>>> +/* >>>> + * Some subsystems in Xen may have multiple implementions, which can be >>>> + * resolved to a single implementation at boot time. By default, this will >>>> + * result in the use of function pointers. >>>> + * >>>> + * Some architectures may have mechanisms for dynamically modifying .text. >>>> + * Using this mechnaism, function pointers can be converted to direct calls >>>> + * which are typically more efficient at runtime. >>>> + * >>>> + * For architectures to support: >>>> + * >>>> + * - Implement alternative_{,v}call() in asm/alternative.h. Code generation >>>> + * requirements are to emit a function pointer call at build time, and stash >>>> + * enough metadata to simplify the call at boot once the implementation has >>>> + * been resolved. >>>> + * - Select ALTERNATIVE_CALL in Kconfig. >>>> + * >>>> + * To use: >>>> + * >>>> + * Consider the following simplified example. >>>> + * >>>> + * 1) struct foo_ops __alt_call_maybe_initdata ops; >>>> + * >>>> + * 2) const struct foo_ops __initconst foo_a_ops = { ... }; >>>> + * const struct foo_ops __initconst foo_b_ops = { ... }; >>>> + * >>>> + * void foo_init(void) >>>> + * { >>>> + * ... >>>> + * if ( use_impl_a ) >>>> + * ops = *foo_a_ops; >>>> + * else if ( use_impl_b ) >>>> + * ops = *foo_b_ops; >>>> + * ... >>>> + * } >>>> + * >>>> + * 3) alternative_call(ops.bar, ...); >>>> + * >>>> + * There needs to a single ops object (1) which will eventually contain the >>>> + * function pointers. This should be populated in foo's init() function (2) >>>> + * by one of the available implementations. To call functions, use >>>> + * alternative_{,v}call() referencing the main ops object (3). >>>> + */ >>>> + >>>> +#ifdef CONFIG_ALTERNATIVE_CALL >>>> + >>>> +#include >>>> + >>>> +#define __alt_call_maybe_initdata __initdata >>> My v3 comment here was: >>> >>> "I think it wants (needs) clarifying that this may only be used if >>> the ops object is used exclusively in alternative_{,v}call() >>> instances (besides the original assignments to it, of course)." >>> >>> I realize this was slightly too strict, as other uses from .init.* >>> are of course also okay, but I continue to think that - in >>> particular with the example using it - there should be a warning >>> about this possible pitfall. Or am I merely unable to spot the >>> wording change somewhere in the comment? >> >> Such a comment is utterly pointless.  initdata has a well known meaning, >> and a comment warning about the effects of it is just teaching >> developers to suck eggs[1] > > Well, okay then - at least the definition of __alt_call_maybe_initdata > isn't far away from the comment. (What I'm not convinced of is that > people knowing __initdata's meaning necessarily need to correctly > infer __alt_call_maybe_initdata's.) > > Two other observations about the comment though, which I'd like to be > taken care of (perhaps while committing): > > - __initconst wants to become __initconstrel. > - foo_init(), seeing that there are section annotations elsewhere, > wants to be marked __init. > > Then > Acked-by: Jan Beulich > > Daniel, you having made changes (even if just minor ones) imo requires > you S-o-b on the patch alongside Andrew's. Ack, I realized after sending I didn't SoB it, my apologies on that. v/r, dps From xen-devel-bounces@lists.xenproject.org Tue Sep 07 13:27:58 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 13:27:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.181034.327990 (Exim 4.92) (envelope-from ) id 1mNb8i-0000Sa-OM; Tue, 07 Sep 2021 13:27:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 181034.327990; Tue, 07 Sep 2021 13:27:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNb8i-0000ST-LT; Tue, 07 Sep 2021 13:27:52 +0000 Received: by outflank-mailman (input) for mailman id 181034; Tue, 07 Sep 2021 13:27:51 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNb8h-0000SN-KM for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 13:27:51 +0000 Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id df0e0929-302e-4613-a234-1499f1b101e9; Tue, 07 Sep 2021 13:27:50 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: df0e0929-302e-4613-a234-1499f1b101e9 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1631021270; h=to:cc:references:from:subject:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=CmfnqghAQMqOoM1IPQVi098sHa9O0hBNYIPkFMm0Slg=; b=V39w2J+IFvtPtJDjCqry6ChXQAoHMqzKihZIM6px5bkBZzKIPB2JQrau pg8B2Ql8t0mR5iJfL1PDYke33r96lCNGewA16BQY8aN4rmzbupNRpP75d 4UJUa1qo4QaHUoF/lHNuZMrhU6vv2CwCr8R5K5FekC91AR/9ttVp+SdQ3 I=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: MBMbwhs+Qt/PsEDFcEedgW9L1WQkFHYIvRJ6XzlE5+EdqVBgdsQceh28n0zFOzZAzvR7PZkWvh wCmDq2qYH+uwhbGSrOZplbCaaHlJKjJRrfjDyKIglgUFoSGeY+/zU7Y/2eVaGYeJuwgb+tAyl5 0hVa8zI+t2QFFB9Y6g25MVX8jWcGoXw1kIIw1aBJoxiI5/fepwoZCQB6mCotGIt7ogY0+6aH83 r1TKVQW0EhI235a5VDUQTGCZxBBxulybwSAft5ezLa5lJsHsPCAdAfdovkt9PrOTq3fCVW9RO0 60gMJrPgclpU5Gu3rJ4+Xnlx X-SBRS: 5.1 X-MesageID: 52165139 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:qUSAQa0UlK89prBUkz3azQqjBIEkLtp133Aq2lEZdPUCSL3gqy nOpoV/6feX4Ax6ZJhEo7290ca7LU80maQb3WBzB8bBYOCFgguVxdpZnO3fKlTbckWUygc678 ldmsNFeb7N5DZB7PoTT2ODYq4dKHXsytHNuQ9+pU0dKj1XVw== X-IronPort-AV: E=Sophos;i="5.85,274,1624334400"; d="scan'208";a="52165139" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ReJT8obGyqBoZtAvo00onIB41y5N3PnJpvki1+Iferprxd5zgPdO66QS1QH47UhQP6eGVYxIKxCkn46sTNxmqHfegMxJD/+SkHWCgRlO4FAsCr9EfRgT7zFVbzeTdea85uoh1RqJ1h2Dpvvk5HgJHs54por3fLVPnV+SGiwK41ayQe8pqQ1tTwRY/J7WN0ZYT1mGXLYdIe3jgvYfhgowasX9UUyIQkvkix7o1MEs+mTjx05iCGEKH4F+puku18qjHPIsjqsMignaP80xIk9NHqPS5S7vzAHpJeDd54nAqzyeg6sh3RAS3uWZHHqBqQ2a+d7z4ROan/iR0AwQBw8fvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=XZiBBNReedoay/JRiVqq7EKaNRkuz+H44YkjqwhFLpg=; b=TTxAnMzYVzcYhnw+diGSR0GrKhYPz6lTsR4ZSmTAAoZxUn7LRXyezDtIcD5jnG/pNh2cvzVSX/0hM16h+0DyS4NYnGU3yb6OGQbQnrniLUNRzH/VXBRAz2jA4NrnhNTH2+FVVhNp2UTrwdmq8PfSqQiYZ644jd0gZ7BXIlBbR6qUUI4wg/qN42IleflceiZVUA+LNEKCjhd3dbUb7BZdbqX2ZQdeqfGHZBoyv8625eixB8PLSngL0PHmXUA7+dUCEz3fJFFp3ZVs9ZmDgxfbBru2iTLstdSW5ehocDBVwVR4wQlo5lQ8Eg7g6JbFAvdO77ajj3N5JFPNT8hLyqcSHw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XZiBBNReedoay/JRiVqq7EKaNRkuz+H44YkjqwhFLpg=; b=fd7FJCaUPFkcZR25Gn1LUZtkvrb5vLu5EnSM25EbnxBwysypAmxGw+gA0XZgjGpDHC+n8lP90WcliXFsYG5oLZhizQxuymedbOxrgt5ZZiYfTnCjeUd10nYiYKJ3te+d7jcqXq47gj9Li8E0MQ1u60SjgexzfCZTdJ1kNiZwK80= To: Jan Beulich CC: Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Pu Wen , Andy Lutomirski , Xen-devel , Jane Malalane References: <26b88d5a-ae6f-0065-7c3f-5eeb6dd80078@suse.com> <2972c71a-5fed-0813-8ec0-d179eacff14d@citrix.com> <70f376c6-eef2-42ce-a8eb-67c1130a41e4@suse.com> From: Andrew Cooper Subject: Re: [PATCH v1 2/2] x86/cpuid: Detect null segment behaviour on Zen2 CPUs Message-ID: Date: Tue, 7 Sep 2021 14:27:41 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 In-Reply-To: <70f376c6-eef2-42ce-a8eb-67c1130a41e4@suse.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: en-GB X-ClientProxiedBy: LO4P123CA0277.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:195::12) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c51edc4a-7dac-4f68-772c-08d972034851 X-MS-TrafficTypeDiagnostic: SJ0PR03MB6391: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: T0Eo6sq9hIUbLzfZOrrAOCnHfqlMuWF9vFsyxmU0WrQ/3MtVmx9H7dNaT0KjfCAI4YSAo4OQ39gjQ7ZD7XVXo0ALDT/0uGGz4Ob0Oc87ge2SiejiH2JRip5bKPMmrkm8iUOKMhOIUz75sXTqbEsivfmoBzwa0oymxajpJuhfG1i+EIJraCekAsWrpn4mwJkf/crutFj3mjphr05K+aUI+vYnhA0P7gXFsBrKZDbBplIJV/bQ7ALgcTT0rDctZUZIOGvC4dEQOdcU5YCwDvwrlMavwrvpXiphqdmB7LRnsSvwYZRRwUmEc7LvhHbNExVO5m6h1lkOVvmMMG73dfEA8K2n+YHG5l9s5RgKYFXuLvOxIsiGx0itkPmUIJCvUL6a2JjKTnoY1blDtAMvo1rwyG45ILTqwO23RKzPVarP5mHF6h6Ysu9Ofa2v7S8z3ct+LFz2rSnJmHPKuRUr8VbauLQqLcympSkDwSLz7+QdAyhYjLT0G6wYMkJUQ9U8tHJNumt3xUIzxxGWnRNSeqsEQT81DNk2z5X5XYHPf/vQaHqj28lK72JObFguybuKts7Cr6h67lXiFTzh3LsQtPD3Bvbb8uw4echaS+rHljVlxxnxK6ROhMXbmxOGU289wAJW5b+Ji7HMkJA/VKANKANKDJxyYo2E341Mwkzrvilb7kL3CrlBBaUy6YYivUow5I2u0q3wZU7wcdzK8av0htPXORcpyQ1iMSYTYIwTJjb07SE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(54906003)(6486002)(55236004)(508600001)(316002)(83380400001)(26005)(16576012)(8676002)(6666004)(66556008)(31696002)(6916009)(66946007)(86362001)(956004)(2616005)(38100700002)(66476007)(5660300002)(8936002)(2906002)(4326008)(186003)(53546011)(107886003)(36756003)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L3hUUnRCMkJLNSttSFZYVTFKSmZ3bmthUCtlOUF6ei9pS0xBTVpFdHFLU1FU?= =?utf-8?B?czVidm01aUZCUGx0enBsSCtlakxrbjl4U2tMaUt1MnRkSjFmSytSVXg4OVNl?= =?utf-8?B?ODdIYWExT01NeGVOTjcybDVPbVhHbG1TR0pDS1BvYlVUYURzR0VvSnZuZ25v?= =?utf-8?B?VmNnaVlDMENwK0JIeTdoL2F3L1hpdktucCtTMHdWV0xDMFp1Wk13NFgyZmlk?= =?utf-8?B?Yld0QnZGaXc3NnE1dytETEVMNDJ3U0dSU2VmUzZuRHdhVEQxeWo2cnA0c1Q0?= =?utf-8?B?QmtBU3M4MC9LWS9rUGk1aC9CQStSVjhYUk5nVmFJSzRVV3FzbjREMlBjZUlU?= =?utf-8?B?UFR2K3A4cnprMHhYUytTcUdZbklla1dVS2ErREpCS1FYc09URzczQnVjSTZk?= =?utf-8?B?RHFkbCtDQzcvTGQrYTlqcXNRWjdubGtlZ0hiSWptNDZ5ZVczcS9nekFJbXJM?= =?utf-8?B?Z1N3NER3UGVpTkVkckMvOHplWmt1clNqQVJXd2JlaWl1cEFUNmRiWDdWbWcr?= =?utf-8?B?SWc1THRFZEVNdFZVcFpuNHFwd09kM1BESzYyL1gxRVQ1MDQ1eXFTUHA5YUU5?= =?utf-8?B?ZStQYTNOd2NoMGF5SFB6TFliLzllU1FCRXpkdmc3bHNnR2ZvaFdVcERDbmov?= =?utf-8?B?dGNvYkNqYW9wNHk4ZER6dFp5UjVKbmlRd2t0bXNYRUt0am0xTzdBTFB0bVhr?= =?utf-8?B?ZnV1TWtueU5pV1lweU92RnB3UkZIak9KdWp0RzM1d0syclo0NXh1NHkzblBD?= =?utf-8?B?dkNBSlV0cFI5b1VtNzc4d2d5TFREWUMvUXJXTGx4WU1JMU5oU2tXMzFWdXJm?= =?utf-8?B?cHBiTy95MGZBWFVkbk00K0cxQkxWZzdVOGhaLzVWT012SFdYSnZzamYrNVNU?= =?utf-8?B?MDcvUVF2VXhVSjJCaDI5ZmVjRldnRExZY1MzbTJBZnhPcHNDQXhPTXF5ZVBk?= =?utf-8?B?bERCSUMyVkhsN3p6bkNScERZeWp2TnpnUitCZ3c1SDcxbU1IS1RuamJjNnl5?= =?utf-8?B?RzlQVVc5QkpUdGpEU21tVFBsRm5LWDJyMTZZVDA3SzQvU1BhYU1VSWo1a08x?= =?utf-8?B?OWF0UkM0RWYxSkdlMy8wVFlJcmRENmZyblNOY0RFUzFocDJDTE9BMnNrUlBk?= =?utf-8?B?RW1MQ2RBOXpUNitVRmRhOUlmNVppNTZOMGlnb0VCQkdGSDF1WGE3U3ZmNm04?= =?utf-8?B?QTJxS1I0MXhJdTBjUlg4RXMyczYxMXl3Ty9QUGhkVG1WZlg0dWVaL2FQMFlY?= =?utf-8?B?dSs4ZmlFSWxKcWtUVHFqdWw5VW5tL241RGFRRzBvS253ZHVHb3g1b2RXMTBy?= =?utf-8?B?WURoU0VpTUJoZnVQNWlycld2dEl3ZEZvVGE5bmlyZ3VKSHFYR29JdnJnNWJF?= =?utf-8?B?UnNxV0JsYVh6U0FIeGdYRnYzZXdXak9zQXMyWDU2Nks3QXNXY2dob3FPUEhS?= =?utf-8?B?c29lV2tKcnVBTk1BNEk3RzNWT2I4RWNQdkQ0RmNoVzdxWWVHVTlDOTBZTVVL?= =?utf-8?B?NkJmUUFyS0Z5c3Z0MG5GWm5keUlZZGYxT051VHdWa2xuNkJDWjQveloxeHlh?= =?utf-8?B?YmlQR1RHb3VUdTk1ejBGWjV2R1lId0J4eHUyeEhUV0ppWEZDbXhIcFVJRmYz?= =?utf-8?B?MVBTclJNdHhlUlNsWmhhaGkxMis0dmY2bGl4bzVXNkV2MTRmZmFNZEozM1I4?= =?utf-8?B?MnFFcWdqcEhNQW9WcU9PT0pIbXRSWUF0T1EvT2gyUStZSmkzL3p5MEMwOXlW?= =?utf-8?Q?JAz8Og6l7oflZGmFVvqs1ZJs7cazRq/tqcjrPQ/?= X-MS-Exchange-CrossTenant-Network-Message-Id: c51edc4a-7dac-4f68-772c-08d972034851 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2021 13:27:47.5091 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1qegWzUvuOVh20oKIBvHEmKo5Dpz8ZeHYDzaUgMp3v+LJ6hYaXF8tvDKXtSVhIi1LbzzuMz0PzHhAKt80bUvh5MzNWzEZv1u91cKrRcLeyk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB6391 X-OriginatorOrg: citrix.com On 07/09/2021 07:09, Jan Beulich wrote: > On 06.09.2021 20:07, Andrew Cooper wrote: >> On 06/09/2021 16:17, Jan Beulich wrote: >>> On 06.09.2021 14:00, Jane Malalane wrote: >>>> --- a/xen/arch/x86/cpu/amd.c >>>> +++ b/xen/arch/x86/cpu/amd.c >>>> @@ -681,6 +681,19 @@ void amd_init_lfence(struct cpuinfo_x86 *c) >>>> c->x86_capability); >>>> } >>>> =20 >>>> +void detect_zen2_null_seg_behaviour(void) >>> This can in principle be marked __init. >>> >>>> +{ >>>> + uint64_t base; >>>> + >>>> + wrmsrl(MSR_FS_BASE, 1); >>>> + asm volatile ( "mov %0, %%fs" :: "rm" (0) ); >>> While I don't strictly mind the "m" part of the constraint to remain >>> there (in the hope for compilers actually to support this), iirc it's >>> not useful to have when the value is a constant: Last time I checked, >>> the compiler would not instantiate an anonymous (stack) variable to >>> fulfill this constraint (as can be seen when dropping the "r" part of >>> the constraint). >> This is "rm" because it is what we use elsewhere in Xen for selectors, >> and because it is the correct constraints based on the legal instruction >> encodings. > grep-ing for "%%[defgs]s" reveals: > > efi_arch_post_exit_boot(), svm_ctxt_switch_to(), These are writing multiple selectors in one go, and a register constraint is the only sane option. > and do_set_segment_base() all use just "r". I had missed this one. > This grep has not produced > any use of "rm". What are you talking about? TRY_LOAD_SEG(), pv_emul_read_descriptor() for both lar and lsl, do_double_fault() for another lsl, lldt(), ltr(). So ok - not everything, but most. > >> If you want to work around what you perceive to be bugs in compilers >> then submit a independent change yourself. > I don't perceive this as a bug; perhaps a desirable feature. I also > did start my response with "While I don't strictly mind the "m" > part ..." - was this not careful enough to indicate I'm not going > to insist on the change, but I'd prefer it to be made? No, because a maintainer saying "I'd prefer this to be changed" is still an instruction to the submitter to make the change. But the request is inappropriate.=C2=A0 "Last time I checked, the compiler would" presumably means you've checked GCC and not Clang, and therefore any conclusions about the behaviour are incomplete. Unless there is a real concrete compiler bug to work around, "rm" is the appropriate constraint to use, all other things being equal.=C2=A0 If the complier is merely doing something dumb with the flexibility it has been permitted, then fix the compiler and the problem will resolve itself the proper way. > >>>> @@ -731,6 +744,11 @@ static void init_amd(struct cpuinfo_x86 *c) >>>> else /* Implicily "=3D=3D 0x10 || >=3D 0x12" by being 64bit. */ >>>> amd_init_lfence(c); >>>> =20 >>>> + /* Probe for NSCB on Zen2 CPUs when not virtualised */ >>>> + if (!cpu_has_hypervisor && !cpu_has_nscb && c =3D=3D &boot_cpu_data = && >>>> + c->x86 =3D=3D 0x17 && c->x86_model >=3D 30 && c->x86_model <=3D = 0x5f) >>> DYM 0x30 here? >> 0x30, although it turns out that some of the mobile Zen2 CPUs exceed >> 0x60 in terms of model number. >> >> As Zen3 changes the family number to 0x19, I'd just drop the upper bound= . > Minor note: Even if it didn't, the !cpu_has_nscb would also be enough > to avoid the probing there. There is actually a problem.=C2=A0 From a non-AMD source, I've found the Sucor Z+ CPU which is a Fam17h Model 0x50 Zen1. So instead I'm going to recommend dropping all model checks and just keeping the family checks.=C2=A0 This will extend the probe function to Zen= 1 too, but it is once on boot, trivial in terms of complexity, and really not worth the time/effort it has taken to discover that the model list wasn't correct to start with. ~Andrew From xen-devel-bounces@lists.xenproject.org Tue Sep 07 13:31:21 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 13:31:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.181041.328002 (Exim 4.92) (envelope-from ) id 1mNbC3-00026t-8o; Tue, 07 Sep 2021 13:31:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 181041.328002; Tue, 07 Sep 2021 13:31:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNbC3-00026m-5l; Tue, 07 Sep 2021 13:31:19 +0000 Received: by outflank-mailman (input) for mailman id 181041; Tue, 07 Sep 2021 13:31:17 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNbC1-00026g-6z for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 13:31:17 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (unknown [40.107.14.52]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id dfe7ee80-0fdf-11ec-b0f3-12813bfff9fa; Tue, 07 Sep 2021 13:31:15 +0000 (UTC) Received: from DB6PR1001CA0004.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:4:b7::14) by AS8PR08MB7141.eurprd08.prod.outlook.com (2603:10a6:20b:401::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.22; Tue, 7 Sep 2021 13:31:13 +0000 Received: from DB5EUR03FT036.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:b7:cafe::cd) by DB6PR1001CA0004.outlook.office365.com (2603:10a6:4:b7::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14 via Frontend Transport; Tue, 7 Sep 2021 13:31:13 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT036.mail.protection.outlook.com (10.152.20.185) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Tue, 7 Sep 2021 13:31:12 +0000 Received: ("Tessian outbound 620209b93b95:v105"); Tue, 07 Sep 2021 13:31:12 +0000 Received: from a7dc6487bcbb.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id EAF25DB4-9348-4ABC-A66F-8F4F675F57A6.1; Tue, 07 Sep 2021 13:31:00 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id a7dc6487bcbb.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 07 Sep 2021 13:31:00 +0000 Received: from PAXPR08MB6816.eurprd08.prod.outlook.com (2603:10a6:102:130::10) by PAXPR08MB6969.eurprd08.prod.outlook.com (2603:10a6:102:1d8::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.22; Tue, 7 Sep 2021 13:30:58 +0000 Received: from PAXPR08MB6816.eurprd08.prod.outlook.com ([fe80::c1b4:db1c:376f:b697]) by PAXPR08MB6816.eurprd08.prod.outlook.com ([fe80::c1b4:db1c:376f:b697%8]) with mapi id 15.20.4500.014; Tue, 7 Sep 2021 13:30:58 +0000 Received: from smtpclient.apple (82.8.129.65) by LO4P123CA0022.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:151::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Tue, 7 Sep 2021 13:30:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dfe7ee80-0fdf-11ec-b0f3-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AHo4LrTOFjlE7FFmnLbeXvdli6Hhb31JUEvOqsq4SnM=; b=IMvgmKvHQesTA4cEnkAVwOSqoE3fzUeK5rvWhcl1v5IFrLu0O2A2YeUxrJwEfhJYDfH4TO02Sy896Z+2OZpTEYUIV4YuRWpZlcvpUkpbBnp5mvAOduUsdczQm0V/uO6Csp6VaZ1MiOsOHVSembYqL/XvnAiucrSycmzsdgx1AF8= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: 8183cf2115e268ed X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LGWHMWRjEmBWbTm+hPJqo+sjKJoakgpceunvtbJL1JQSz2XLpRJz5aLTgqgWG74cG/TiSt2Z8GbSdRaDmMyrq4cGZq1HMxVaxyraM2kRBX7jrjA/2L/4BnueRTyW3baBYZGCufIflpD+cUq5BrRxsyG59krre1Ziei3xoo3N3TBxJEI8+QtQ+YPjU4ou0OUvd77WvcUGwOH5JkbLIB4r5PCHsvM52IbwxD0EbbljPAnMx99BAfN94dwvtnpgUa3bV55aQAuDXZs6z68ZLCOKy0XP1Ax7JpnyxmwjTOA0k+kB2IWWsdfvL5605mos4UVSlquQZNjo5JSMjd62SmBsMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=AHo4LrTOFjlE7FFmnLbeXvdli6Hhb31JUEvOqsq4SnM=; b=j7GEbzytWfyuCjAqE8uV4AeCQ1fPS1d32c/d124f6kkdWxdlpFpVKPpoKcDEWBhFu4o/+EeKbSHCtlD7PDa1MtqNHrdYMChWShFU7Xss84VPAYCqQaUTCq4ygRwebuh8MqMGUZmsZeQn0FxqlK1xSO/6Tfr/zqkJdCgnlzFbgV4gmBS6dczns/XNl5miOKekDd6xBVnaceOnDmCiYhWTGgIog9Vr4jWobYJEJS7kVeZbUdJS/MnJf6Yz6LR5PNOSIJ00/nDPM/B6iYpDhtXU8mHkfGbAiZceSQaIbetPA1UdeRI3TSewLjVgT+E3b9XzB3+hA3x8W4PSdOtR8LsvPA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AHo4LrTOFjlE7FFmnLbeXvdli6Hhb31JUEvOqsq4SnM=; b=IMvgmKvHQesTA4cEnkAVwOSqoE3fzUeK5rvWhcl1v5IFrLu0O2A2YeUxrJwEfhJYDfH4TO02Sy896Z+2OZpTEYUIV4YuRWpZlcvpUkpbBnp5mvAOduUsdczQm0V/uO6Csp6VaZ1MiOsOHVSembYqL/XvnAiucrSycmzsdgx1AF8= Authentication-Results-Original: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com; Content-Type: text/plain; charset=utf-8 Subject: Re: [RFC PATCH] xen/design: Add design for EFI dom0less system start From: Luca Fancellu In-Reply-To: <1efbd9a8-232b-b267-fa8e-7f5f1af7cfed@xen.org> Date: Tue, 7 Sep 2021 14:30:52 +0100 Cc: xen-devel@lists.xenproject.org, Bertrand Marquis , wei.chen@arm.com, Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Stefano Stabellini , Wei Liu Content-Transfer-Encoding: quoted-printable Message-Id: <5DA71CEF-0ADE-4846-A7BC-B378B95A38AD@arm.com> References: <20210907065228.21794-1-luca.fancellu@arm.com> <4bab7902-0268-5705-5462-fcd7571d7492@xen.org> <7BD59287-75ED-4D4F-B892-F6B04583A986@arm.com> <1efbd9a8-232b-b267-fa8e-7f5f1af7cfed@xen.org> To: Julien Grall X-Mailer: Apple Mail (2.3654.120.0.1.13) X-ClientProxiedBy: LO4P123CA0022.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:151::9) To PAXPR08MB6816.eurprd08.prod.outlook.com (2603:10a6:102:130::10) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0643375f-98da-472d-57b7-08d97203c262 X-MS-TrafficTypeDiagnostic: PAXPR08MB6969:|AS8PR08MB7141: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:10000;OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 2vB0kVeDNCTk12dH9bO0Se7/fpANSRIrd7a4cU06ohk2M8sXVdqa2YUlT26J69Iov+FdKYuZjn2MitGwexLmjPV6sg/J6Nd8doK9xwX0vO9kZsKvUpw7VBiNlL/yfiOEt2HQAjYTPsBv3oHd01OT6ngdRDwmtpP1FH5Qnf5GZ+MNER6DphS4gXOkDjUPgJsKglppjME7lVhZ8+6jNyOitum1Y8/nLfz8rZ6UGLxFkPZJIniKxV8Ecn66JCR/dM7caDFt9LxfojQY2FvD3o0kUxaY2mzR4hJw4LKr6mii5O3xl6GC5p+gPlUtJGw9mFFNSaALLVhrGJQUU1tas3fbkHHI4cfkZWOD1jtMuJ+RAZwo5oak0E+6W9p+oPC25cJa8JUy7k+hSpY7JvSGCkXnfrpPnpAxIGnyB+RwVkv+UrTSfnGrjeoksCesCbDX64IZTDYH7gtiYBtAJgChFSJdr54z497C4bPk8MNzinuLsvQK72yT+KBL2+6GqtqZ2wLjgsvWlaS4eJG6p0zib6Fqa5ylFxML21grY/l5YHOHRq86yg1Y0B7cobSW0tJgDKHrE6hb0YaCuKpDYJTpopFA0b/teLa7OmiRA3bHCoLFNhUZLTIQIsZ1754GiKN+6RtFeX9QX2vksqg3KGFqit65ZPrmtNmTFc+XmBMIo+yIP2XtKl6H05po4Ayf0RQAziuwBKQ/sWpPrkCV/Q5EK3DlPQ/yumtq0duZn2pRWA1S4hxSNEK1LlpUaDrFp8Oj8SVG8DZlg0/NzbVWeCujd2HkpA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB6816.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(136003)(346002)(396003)(376002)(39860400002)(956004)(2616005)(86362001)(5660300002)(66556008)(54906003)(52116002)(66476007)(44832011)(186003)(6916009)(66946007)(6486002)(4326008)(478600001)(26005)(6506007)(6512007)(53546011)(33656002)(83380400001)(36756003)(8936002)(2906002)(38350700002)(6666004)(8676002)(316002)(38100700002)(32563001)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6969 Original-Authentication-Results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT036.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 35f4f803-6d1a-4dfd-a445-08d97203ba32 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qkckQu7eZI4UEyntSBsy5Z9ym2TBShUutExOvcOFGUZwAAHTyhTB7w7RHpbmXzq2tJbk4IH7xbzoCwyADS4BYma7J4x1SB9P/gKzr3qQ+RRHUpqK00AL9wedGth+WJGZt/Nm8giLECCikAQ1PYdYtOdDLr8i8ACTjcHDpL/worj7I9peYz02TRK+23mIDp2hywW3oPDoYUvYr6GajNOJCwjrSDGj0XIXzvjTN11bPO+uQDBtd7LH09xvfS6l9RIC6+W1RiJ/z/EM1a5HLSbmcU17Y/JXu7brscp45eFciP4CWWEky9qxKGD8tqimSpy2egF3J6WRaZnMpshLTfk+wyFAEfn9qn1zRJVn6S/uOwNAWZaQFBAi++VC/5vUmfrEG0xc5+5IMFLXglrG/nURPV2HupkzGUmeqTuus5GuMozan2gDQ56q84R69P1VmVJ5VwewYrvob5caA/B7DW/rL2/VIvR6np5SqzeZsHJ2Om5zt2v3RUGGZR7rW54BjsJ4DWVBlGnjCE3i4nrrulJWiW0AvXa61OAVCr78AqZ0vyHGWuUbWVsAW1mXZ35TVmMuBwcXALKLXCFrWkCaYpCbHgMhojmdN3aMy2SX//fQEkj5JI4jw907m+xrRbItJp0NKePRurKvwn2jscCpyDNVz5c9qUVkNWaLWubExNrV+h3LIP0swZYv03zieALeOVsZJCpOIPmV7GHAEB2p7c5vpNlV2TY41iABsp6f5Ia/ZUI= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(39850400004)(376002)(346002)(396003)(136003)(46966006)(36840700001)(6862004)(36860700001)(53546011)(186003)(4326008)(36756003)(8936002)(70586007)(83380400001)(478600001)(6486002)(2616005)(70206006)(6512007)(6666004)(47076005)(26005)(86362001)(6506007)(956004)(82310400003)(5660300002)(336012)(8676002)(316002)(2906002)(33656002)(82740400003)(356005)(81166007)(54906003)(44832011)(32563001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2021 13:31:12.1239 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0643375f-98da-472d-57b7-08d97203c262 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT036.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB7141 > On 7 Sep 2021, at 13:30, Julien Grall wrote: >=20 >=20 >=20 > On 07/09/2021 12:51, Luca Fancellu wrote: >>> On 7 Sep 2021, at 10:35, Julien Grall wrote: >>>=20 >>> Hi Luca, >>>=20 >>> On 07/09/2021 07:52, Luca Fancellu wrote: >>>> Add a design describing a proposal to improve the EFI >>>> configuration file, adding keywords to describe domU >>>> guests and allowing to start a dom0less system. >>>> Signed-off-by: Luca Fancellu >>>> --- >>>> docs/designs/efi-arm-dom0less.md | 105 ++++++++++++++++++++++++++++++= + >>>> 1 file changed, 105 insertions(+) >>>> create mode 100644 docs/designs/efi-arm-dom0less.md >>>> diff --git a/docs/designs/efi-arm-dom0less.md b/docs/designs/efi-arm-d= om0less.md >>>> new file mode 100644 >>>> index 0000000000..8d8fa2243f >>>> --- /dev/null >>>> +++ b/docs/designs/efi-arm-dom0less.md >>>> @@ -0,0 +1,105 @@ >>>> +# Xen EFI configuration file >>>> + >>>> +The current configuration file used by Xen when it is started as an E= FI >>>> +application is considering only the dom0 guest and doesn't have any >>>> +property to describe and load in memory domU guests. >>>=20 >>> From my understanding, the problem is less about properties (we already= have them in the Device-Tree) but more about where are the binaries locate= d in memory as we don't know in advance. >> Hi Julien, > Hi Luca, >=20 >> I think I used the wrong word there, I meant =E2=80=9Ckeyword=E2=80=9D i= nstead of =E2=80=9Cproperty=E2=80=9D because I was referring about the >> lack of keywords to describe a domu guest in the Xen EFI configuration f= ile. >> I agree with you that on systems with static allocation, the kernel and = ramdisk binaries must be at certain locations >> that are out of control when we use the EFI boot services, the thing we = can do is provide a keyword to specify the >> addresses and then use the CopyMem() function to relocate the kernel/ram= disk in the address we want. >=20 > I wasn't specifically referring to static allocation here, sorry if this = wasn't clear. I was pointing out that most of the information you create in= the xen.cfg is going to be similar to what we already provide in the Devic= e-Tree. >=20 > My main concern is everytime we add a new feature in Dom0less, a develope= r would need to write code for the DT and UEFI. This will increase the code= size and maintenance. >=20 > The same can be said for the admin as if they want to switch from plain U= -boot to UEFI, they would also need to fully rewrite the bindings. >=20 > AFAICT, most of the information provided in the Device-Tree are usable ev= en when using UEFI. So I would prefer if we try to re-use what's existing. = This is what my proposal below was about. >=20 >>>=20 >>> So I would like to propose something that build on top of the Device-Tr= ee work we did. Note this is early thoughts. >>>=20 >>> The problematic nodes in the DT are: >>>=20 >>> module@0x4a000000 { >>> compatible =3D "multiboot,kernel", "multiboot,module"; >>> reg =3D <0x0 0x4a000000 0xffffff>; >>> bootargs =3D "console=3DttyAMA0 init=3D/bin/sh"; >>> }; >>>=20 >>> module@0x4b000000 { >>> compatible =3D "multiboot,ramdisk", "multiboot,module"; >>> reg =3D <0x0 0x4b000000 0xffffff>; >>> }; >>>=20 >>> In particular the property "reg" cannot be known in advance because the= UEFI stub will be responsible to load the binaries in memory. >> Yes that=E2=80=99s true, the UEFI stub is using from the UEFI boot servi= ce the AllocatePages function that is giving back an address out of our con= trol, >> then using another function the binary is read from the disk and copied = at that address, finally the UEFI stub is writing the node in the device tr= ee that >> will be used by Xen later. >=20 > I am not sure to follow. Are you saying the UEFI stub will create the dom= 0less node in the DT based on the xen.cfg? Yes, in my mind the UEFI stub would have created all necessary node into th= e chosen {} to create the system, now the stub does that but only for the dom0 modules. >=20 >>>=20 >>> What we could do is providing a list of binaries to load and associate = a key for each of them. Something like: >>>=20 >>> binary=3D >>> binary=3D >>> .... >>>=20 >>> We can then replace the property "reg" with a new property "uefi,key" t= hat will contain the name of the binary. >>>=20 >>> What do you think? >> Here I=E2=80=99m lost, because I don=E2=80=99t understand what we are go= ing to do with the name of the binary. >=20 > would be used by the UEFI stub to load the binary in memory. Ea= ch binary will have a which helps to refer them in the Device-Tree. = To give a concrete example, let say we have two dom0less domains: > - DomA: 2 vCPUs, 128MB > - DomB: 3 vCPUs, 512MB >=20 > DomA and DomB will be using the same kernel but a different ramdisk. xen.= cfg, would look like: >=20 > [global] > default=3Dsection1 >=20 > [section1] > options=3Dconsole=3Dvga,com1 com1=3D57600 loglvl=3Dall noreboot > kernel=3Dvmlinuz-3.0.31-0.4-xen [domain 0 command line options] > ramdisk=3Dinitrd-3.0.31-0.4-xen > xsm=3D > dtb=3Ddevtree.dtb > binary=3Dvmlinuz-guest domu-kernel > binary=3Dramdisk-domA.img domA-ramdisk > binary=3Dramdisk-domB.img domB-ramdisk >=20 > The chosen node in the DT would look like: >=20 > chosen { > domU1 { > compatible =3D "xen,domain"; > #address-cells =3D <0x2>; > #size-cells =3D <0x1>; > memory =3D <0 0x8000000>; > cpus =3D <2>; >=20 > module@1 { > compatible =3D "multiboot,kernel", "multiboot,module"; > uefi,binary =3D "domu-kernel"; > bootargs =3D "console=3DttyAMA0 init=3D/bin/sh"; > }; >=20 > module@2 { > compatible =3D "multiboot,ramdisk", "multiboot,module"; > uefi,binary =3D "domA-ramdisk"; > }; > }; >=20 > domU2 { > compatible =3D "xen,domain"; > #address-cells =3D <0x3>; > #size-cells =3D <0x1>; > memory =3D <0 0x20000000>; > cpus =3D <3>; >=20 > module@1 { > compatible =3D "multiboot,kernel", "multiboot,module"; > uefi,binary =3D "domu-kernel"; > bootargs =3D "console=3DttyAMA0 init=3D/bin/sh"; > }; >=20 > module@2 { > compatible =3D "multiboot,ramdisk", "multiboot,module"; > uefi,binary =3D "domA-ramdisk"; > }; > }; > }; >=20 > With this approach, the change is quite minimal to move between an classi= c U-boot boot and EFI boot. Ok now I see, yes this approach can work and can save some code, in the cur= rent code we have that if a "multiboot,module=E2=80=9D is found in the dtb, the Xen EFI configuration= file is skipped, but if we use the module@XX {} without the compatible it can work, the UEFI stub will load th= e binary and update all the needed properties (compatible, reg). Please let me know if we all agree on that Cheers, Luca >=20 > Cheers, >=20 > --=20 > Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Sep 07 13:34:13 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 13:34:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.181048.328012 (Exim 4.92) (envelope-from ) id 1mNbEn-0002ol-Re; Tue, 07 Sep 2021 13:34:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 181048.328012; Tue, 07 Sep 2021 13:34:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNbEn-0002oe-Ol; Tue, 07 Sep 2021 13:34:09 +0000 Received: by outflank-mailman (input) for mailman id 181048; Tue, 07 Sep 2021 13:34:09 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNbEm-0002oW-QY for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 13:34:09 +0000 Received: from mx0a-0039f301.pphosted.com (unknown [148.163.133.242]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 4660a422-0fe0-11ec-b0f3-12813bfff9fa; Tue, 07 Sep 2021 13:34:07 +0000 (UTC) Received: from pps.filterd (m0174676.ppops.net [127.0.0.1]) by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 187Bh1rU005659; Tue, 7 Sep 2021 13:34:04 GMT Received: from eur04-he1-obe.outbound.protection.outlook.com (mail-he1eur04lp2058.outbound.protection.outlook.com [104.47.13.58]) by mx0a-0039f301.pphosted.com with ESMTP id 3ax5pm0sg4-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 07 Sep 2021 13:34:04 +0000 Received: from AM7PR03MB6325.eurprd03.prod.outlook.com (2603:10a6:20b:13c::18) by AS8PR03MB7159.eurprd03.prod.outlook.com (2603:10a6:20b:2ea::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.20; Tue, 7 Sep 2021 13:33:58 +0000 Received: from AM7PR03MB6325.eurprd03.prod.outlook.com ([fe80::d9b7:c0ab:2c2f:5b44]) by AM7PR03MB6325.eurprd03.prod.outlook.com ([fe80::d9b7:c0ab:2c2f:5b44%3]) with mapi id 15.20.4478.025; Tue, 7 Sep 2021 13:33:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4660a422-0fe0-11ec-b0f3-12813bfff9fa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=D6B/+dyscpm3VB+2Vgeqw1WFBxAhB8MYDLlNwN2qAjSohNb09W0AC7G3qPoKIem9V1iR3GeFM3HsjNrtMDL89Luykv6eu0TnWkFPspR5tLshkD9KCTOgsOD9jD5DI9vujdshVrE3MHA7Jhjw3QHLvHQEywqHztYl2N/xFfE5imCwFlNyx4x27HS3uJ89kuPah7IpYgnMe9jZ5vquqljxvez68GEykhQLxYexpDUDlM2QFkGNqcTTYUz56ZeqW/P7s0rLufXPN6gDtCc6Jn325Uwf4L2CuGd+RJ0PCIv4Bdu7LsGURA/koz/iuvD2F2w1TjmPgxGIO5uoyi/9FptItg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=5BdAiv68cInWy+SgVNonoK3SC21/xHs/t4Ug12IeLdM=; b=gATdMFuKb0jXbZrtmMFtoQYTxVym/5H0DF14aka3BSFXzSjNme5KF5XUCW1/TQvC7MRkePA35/oM8JDL41/PihmDTorrErQ98nmga4xNXgQmPveqdKJcK4ShkB7Ajn4WygSnKmYjziX9sY0kkNyFS8Z4NGmq9Aztjl5z4Tj84L7+co/XglFII6dGr1q16YlpoAIVrCp3NVwqsVtNy2bQajZlJCVNHI4oXO/695usSijmfGvUz36A7zGvAPlne5SolMIi+4+9qw6Ml/cvcO2TRKkxOEZTZ2uJMfvV6jZ+WKGMePP3xvrBtisgy8Sbxo4rYV0cirhL7xY8NTxQR6KKwA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5BdAiv68cInWy+SgVNonoK3SC21/xHs/t4Ug12IeLdM=; b=sVbJgih1zSDbeO54y1a1oAtJUR1rlz+8L/UUk1sgUZvKTAYFdaqI1+ljqQlpZ3zj+wiJRJ0LVFv7+16FFlD3OiPdABQh0tjgQp8SnlftKDHpjujylmBAe4ehvnb8ECb0Inaq3WMke+kvJpkPdmSvEaf2t8CvLnGyY+54Qu4RX7dSW4eUmioy0L/HY6LFc23xZM5L+C/IJOSVdGOkfm/SGfepdLMzDAkeNQRCAiIUamr+On6qTUhBsdS4stmCpGgWawSqjL79qsOMefXapMayWfEO7tpeIWgiYvvHdgby/UWgRH5E7MtLSARo7PBg31YhyOFvltwgOAHlm1K70Ijx6A== From: Oleksandr Andrushchenko To: Jan Beulich , Oleksandr Andrushchenko CC: "julien@xen.org" , "sstabellini@kernel.org" , Oleksandr Tyshchenko , Volodymyr Babchuk , Artem Mygaiev , "roger.pau@citrix.com" , Bertrand Marquis , Rahul Singh , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH 5/9] vpci/header: Implement guest BAR register handlers Thread-Topic: [PATCH 5/9] vpci/header: Implement guest BAR register handlers Thread-Index: AQHXoKxmxnIdZosa7ESbvTmPlG6KHauXFn+AgAGCLIA= Date: Tue, 7 Sep 2021 13:33:57 +0000 Message-ID: References: <20210903100831.177748-1-andr2000@gmail.com> <20210903100831.177748-6-andr2000@gmail.com> <1848521d-4179-f5ee-e3af-f4e6738f60e6@suse.com> In-Reply-To: <1848521d-4179-f5ee-e3af-f4e6738f60e6@suse.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=epam.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2af00d5c-e119-42a4-0ea1-08d972042545 x-ms-traffictypediagnostic: AS8PR03MB7159: x-ms-exchange-transport-forked: True x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: hBFoENzXgo0ZlJHRFSRY7zsIgq3NkT5KL5ZlAG6Lvs8elEmvhLdth2C9YkR8ZiW+LeqTLakVsxXWn6DxbDyhJdz9e8hi8pheacg7bJmBrvtixakZnAjMmbY6y7EccHRDoj8BtgZ8l1n0LUABcg8yDwyzlmEvUotIU4aiGojU2ZZxidafN/6UQCzwDuQHTMnXWWa1GhAH+nE1Y2pzDQtNmcXSyj/ESR/43UOqIuy/KEpRurR0saDcIwtXoRoX+4U0gDhHLS8tAgFLQWgn3OoDXchoi8FRe0DS9vYvMmiuEYJD2n2UHa+cPIwvm4ej1fYVeooYTTMHT+FA80RrmTDbtp9qndXz/x5wsJieL1GMedpuw65fsbKz5Hu0m2lpQKgkq6iPgBoykYgF89BLUDsREEfpFT4CUzrzhXWkhbkMElUrEj6UGNmURIiloKfkNTgbwgcdKqFhcDzCgrjfzrJVttb8XpJZYknSOW1uCY8kKCQuND1Pl11VpKq2oo//La3qIyy8pawmmbXEgH+lId+jCsiWmWNRcInShyI+SWlTyHal3W3yc8jhzUYXJHsYSo/OmqNBKF2i6E6VG6pwwemnQlPXZ5Vh3txl9qsXZVbZEokvBszBdoCdY2YDqYmzHgLSQ/4jd/zgSfEECpjq8eRUhX4T2dve9ejScgmpqJd3vkJPp5n8WnUfQqIxFc0Bsm0irzFAkNnskGJ6i/rtS2IadSot6WuV2Fyh/ousTkupg08Ck5YiDL4N19jJOYnU1+PS x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM7PR03MB6325.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(39860400002)(346002)(366004)(136003)(396003)(376002)(122000001)(316002)(4326008)(6512007)(83380400001)(38100700002)(86362001)(8936002)(53546011)(76116006)(6506007)(31686004)(36756003)(66946007)(91956017)(66446008)(66556008)(38070700005)(2616005)(66476007)(64756008)(5660300002)(2906002)(8676002)(6486002)(478600001)(54906003)(71200400001)(186003)(31696002)(26005)(110136005)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?VVdYY1FiTmxmTFJRWWM2cWhFQXVJOHNHdlFyajBZS3pML292V0g4Z3NEVG9B?= =?utf-8?B?MDJhV3JMTHhJUjRPK0I5YTlIZEFmRzRtMG5rQ3FIRThkMzVOMjlIbVMrVVNH?= =?utf-8?B?VVoxSjc0b0k1dmszRkFmNCtiQmtlTkFJV3RHMm9rYTRnZUdDLzFUVEdKMTBH?= =?utf-8?B?N1B2SGg3bS81VS8razN4d0JUeW9vcGhaaUxQUjJ6WVZlbUdtKzJaeEoxRXpv?= =?utf-8?B?aFdTSmtxQmJ5MFQ3MzFrWnUxTUwzUWFRWHJEa1V2RmdOUkdHL3hOTHNmdmMx?= =?utf-8?B?cktWVTZtV2l6eFpwaXlEY1RzbzVYOHJMWUF2THFIc1JaUWFWQTRZWjJ0V0No?= =?utf-8?B?QlVCbWw5RlBBU3VVMHBlWEZIbmJVQkx4cnF2T2ZwRCtZU01KWlJ1T3huYWFE?= =?utf-8?B?amJVMkVGeUJoT045OE5tZkdrK3R3RjFRTDVMQVNvTERDeUs1bmxjaHlKM0xy?= =?utf-8?B?TEg4VFZzdXJFSVJmS2hnQ0lvdUhYS29Ram5ESkdMdnVDTE5ZbmliR1ZiMmY0?= =?utf-8?B?QVF6WkV0T2Z3eUo2OHBibXVSMTdZNDBFV2ZOWHk5b0JPWjJtOGRwdmFnUldj?= =?utf-8?B?R2srbTR4SEE0am5JUnA5UXFMYmUzaXBMTFhYM1pUNTRSUXk3NjNXMlpROHox?= =?utf-8?B?ZFk4b0NwTkFPdkVaZXBGNmwxYWJMTkM5eEhCWEIra05ocmhYMVpENjJ1NnJw?= =?utf-8?B?UXJsQXkwSkxqVUFoL3p1Z1VnSjhhd2hFeS80WDI3OVRxTWxSbVhpRG1sL29s?= =?utf-8?B?bnBYQU1QV2hvVFJKbVFvQWR6RlRBbmJmT1NjNjk5RkFiZStySFNCdWdDTkVH?= =?utf-8?B?aG1DSUZJc2x4TGJzVk9TTS9uRnQ3Nk1FQTJ4NTVYcWF1VVJ4ZWE4LzhNMytG?= =?utf-8?B?ZW0ybWZ0dy9Icmx5S0tkOEVuNitMdHlsNVV3Mit6Z2pvZ1k2alp2QkVtWmhP?= =?utf-8?B?dUxMT2dPdGZzelNlbXhZdGtrbHBlZlZRU2puakxvaUZ4blJkZE1LeGxXN1px?= =?utf-8?B?K0tPUmlGa3FiMFM1VEJ1aU94eE9VYnROY3pDbzN1OStORHpxak95SUhPbmJR?= =?utf-8?B?UCtzc2dtMGNtakdIMnFyck9Ddno0SDJ1WnNvdXhRNFc5c2dzYjJscU5VVFV1?= =?utf-8?B?Rm5pVFoxV0VPL0JuTFBTL0dsTCtZNjF4WnJ5WXdCWm1VS0dpMTBUVE1PR2lq?= =?utf-8?B?UWFjOElMMXRmbXQ1WVJxcEFNdk9wTit1KzBnZTRIZ1NMWGlUbEkxZTVLbTlh?= =?utf-8?B?VWtzMEt2TEtqRG1zSkhmNjY5Y1lLM0ZyNlJQWlh4WFF2dnY2UlZHalZ2bVF4?= =?utf-8?B?OFJYMDlPbU5Jc0ZpWUFraW9WZXhjNjNTcEUzVWYzNUFZZ0JpbXdEMCtVaFM0?= =?utf-8?B?c1g5ZC9nUFJCLzVuVlhMa0Q4L3BLemQ4VkljdWpoT2xIdlFSa0Z4S2xZaDFz?= =?utf-8?B?Wm5ncnA5c1A4QTZTK1AvcEpQL2NxZmhINUhtTnlpWlRTSFV3RFY1ZXc5MnNa?= =?utf-8?B?WFBzV1ltT1NWT2x4MVQ4T0dYWDc3M1VmSS9MTGtkbm5STldIOVpYeXBoV1Bz?= =?utf-8?B?WVFjenl0L0ZSaFlKaEdMQTg0SExQZ0dsRjF4WkpMUlV4SW94cDAxVVpMWmFq?= =?utf-8?B?Y1QrU2M0RjJ4WkZvcjNoSE9TR2d4K0NjWEg1LzBMU0lac0RRelp1bUNOckds?= =?utf-8?B?eTdGSHdPRnNWMUpOdW9QRytTVlhnMEV2bVlHeTlHbkpXQlFvMG45ZTUxc1Uz?= =?utf-8?Q?3U8VLTfm3zyM9ai5cT+4IR2bRjDPtqU3v5MF/HT?= Content-Type: text/plain; charset="utf-8" Content-ID: <995FE7DEF132A749BF2A3236800428AA@eurprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: epam.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM7PR03MB6325.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2af00d5c-e119-42a4-0ea1-08d972042545 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Sep 2021 13:33:57.9268 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: tzsWDOHCWVIzVzS/8f8/vmIcxQ6idB4UBV1AVB4paQ9QcIPy0epgWWCr/AXIz+VrgJCTyJIEyKMM/fupY5A3LplkStKtx4jN93t2IcfuzAumZNZvaNIhq53Q+LqMqjS2 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR03MB7159 X-Proofpoint-ORIG-GUID: 91UDs_AjfZv1rEiZ5LKmJI1LQgo0nJbR X-Proofpoint-GUID: 91UDs_AjfZv1rEiZ5LKmJI1LQgo0nJbR X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.391,FMLib:17.0.607.475 definitions=2021-09-07_04,2021-09-07_01,2020-04-07_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 suspectscore=0 bulkscore=0 malwarescore=0 clxscore=1015 phishscore=0 mlxlogscore=999 adultscore=0 priorityscore=1501 impostorscore=0 spamscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2108310000 definitions=main-2109070089 DQpPbiAwNi4wOS4yMSAxNzozMSwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDAzLjA5LjIwMjEg MTI6MDgsIE9sZWtzYW5kciBBbmRydXNoY2hlbmtvIHdyb3RlOg0KPj4gLS0tIGEveGVuL2RyaXZl cnMvdnBjaS9oZWFkZXIuYw0KPj4gKysrIGIveGVuL2RyaXZlcnMvdnBjaS9oZWFkZXIuYw0KPj4g QEAgLTQwMCwxMiArNDAwLDcyIEBAIHN0YXRpYyB2b2lkIGJhcl93cml0ZShjb25zdCBzdHJ1Y3Qg cGNpX2RldiAqcGRldiwgdW5zaWduZWQgaW50IHJlZywNCj4+ICAgc3RhdGljIHZvaWQgZ3Vlc3Rf YmFyX3dyaXRlKGNvbnN0IHN0cnVjdCBwY2lfZGV2ICpwZGV2LCB1bnNpZ25lZCBpbnQgcmVnLA0K Pj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdWludDMyX3QgdmFsLCB2b2lkICpkYXRh KQ0KPj4gICB7DQo+PiArICAgIHN0cnVjdCB2cGNpX2JhciAqYmFyID0gZGF0YTsNCj4+ICsgICAg Ym9vbCBoaSA9IGZhbHNlOw0KPj4gKw0KPj4gKyAgICBpZiAoIGJhci0+dHlwZSA9PSBWUENJX0JB Ul9NRU02NF9ISSApDQo+PiArICAgIHsNCj4+ICsgICAgICAgIEFTU0VSVChyZWcgPiBQQ0lfQkFT RV9BRERSRVNTXzApOw0KPj4gKyAgICAgICAgYmFyLS07DQo+PiArICAgICAgICBoaSA9IHRydWU7 DQo+PiArICAgIH0NCj4+ICsgICAgZWxzZQ0KPj4gKyAgICAgICAgdmFsICY9IFBDSV9CQVNFX0FE RFJFU1NfTUVNX01BU0s7DQo+PiArICAgIGJhci0+Z3Vlc3RfYWRkciAmPSB+KDB4ZmZmZmZmZmZ1 bGwgPDwgKGhpID8gMzIgOiAwKSk7DQo+PiArICAgIGJhci0+Z3Vlc3RfYWRkciB8PSAodWludDY0 X3QpdmFsIDw8IChoaSA/IDMyIDogMCk7DQo+IFdoYXQgeW91IHN0b3JlIGhlcmUgaXMgbm90IHRo ZSBhZGRyZXNzIHRoYXQncyBnb2luZyB0byBiZSB1c2VkLA0KDQpiYXItPmd1ZXN0X2FkZHIgaXMg bmV2ZXIgdXNlZCBkaXJlY3RseSB0byBiZSByZXBvcnRlZCB0byBhIGd1ZXN0Lg0KDQpUaGUgc2Ft ZSBhcyBiYXItPmFkZHIgaXMgbmV2ZXIgdXNlZCB0byB3cml0ZSB0byByZWFsIEJBUi4NCg0KSXQg aXMgYWx3YXlzIHVzZWQgYXMgYW4gaW5pdGlhbCB2YWx1ZSB3aGljaCBpcyB0aGVuIG1vZGlmaWVk IHRvIHJlZmxlY3QNCg0KbG93ZXIgYml0cywgZS5nLiBCQVIgdHlwZSBhbmQgaWYgcHJlZmV0Y2hh YmxlLCBzbyBJIHRoaW5rIHRoaXMgaXMgcGVyZmVjdGx5DQoNCmZpbmUgdG8gaGF2ZSBpdCB0aGlz IHdheS4NCg0KPiAgIGFzDQo+IHlvdSBkb24ndCBtYXNrIG9mZiB0aGUgbG93IGJpdHMgKHRvIGFj Y291bnQgZm9yIHRoZSBCQVIncyBzaXplKS4NCj4gV2hlbiBhIEJBUiBnZXRzIHdyaXR0ZW4gd2l0 aCBhbGwgb25lcywgYWxsIHdyaXRhYmxlIGJpdHMgZ2V0IHRoZXNlDQo+IG9uZXMgc3RvcmVkLiBU aGUgYWRkcmVzcyBvZiB0aGUgQkFSLCBhaXVpLCByZWFsbHkgY2hhbmdlcyB0bw0KPiAodHlwaWNh bGx5KSBjbG9zZSBiZWxvdyA0R2IgKGluIHRoZSBjYXNlIG9mIGEgMzItYml0IEJBUiksIHdoaWNo DQo+IGlzIHdoeSBtZW1vcnkgLyBJL08gZGVjb2Rpbmcgc2hvdWxkIGJlIG9mZiB3aGlsZSBzaXpp bmcgQkFScy4NCj4gVGhlcmVmb3JlIHlvdSBzaG91bGRuJ3QgbG9vayBmb3IgdGhlIHNwZWNpZmlj ICJhbGwgd3JpdGFibGUgYml0cw0KPiBhcmUgb25lcyIgcGF0dGVybiAob3Igd29yc2UsIGFzIHlv dSBwcmVzZW50bHkgZG8sIHRoZSAiYWxsIGJpdHMNCj4gb3V0c2lkZSBvZiB0aGUgdHlwZSBzcGVj aWZpZXIgYXJlIG9uZXMiIG9uZSkgb24gdGhlIHJlYWQgcGF0aC4NCj4gSW5zdGVhZCBtYXNrIHRo ZSB2YWx1ZSBhcHByb3ByaWF0ZWx5IGhlcmUsIGFuZCBzaW1wbHkgcmV0dXJuIGJhY2sNCj4gdGhl IHN0b3JlZCB2YWx1ZSBmcm9tIHRoZSByZWFkIHBhdGguDQoiUENJIExPQ0FMIEJVUyBTUEVDSUZJ Q0FUSU9OLCBSRVYuIDMuMCIsICJJTVBMRU1FTlRBVElPTiBOT1RFDQoNClNpemluZyBhIDMyLWJp dCBCYXNlIEFkZHJlc3MgUmVnaXN0ZXIgRXhhbXBsZSIgc2F5cywgdGhhdA0KDQoiU29mdHdhcmUg c2F2ZXMgdGhlIG9yaWdpbmFsIHZhbHVlIG9mIHRoZSBCYXNlIEFkZHJlc3MgcmVnaXN0ZXIsIHdy aXRlcw0KMCBGRkZGIEZGRkZoIHRvIHRoZSByZWdpc3RlciwgdGhlbiByZWFkcyBpdCBiYWNrLiIN Cg0KVGhlIHNhbWUgYXBwbGllcyBmb3IgNjQtYml0IEJBUnMuIFNvIHdoYXQncyB3cm9uZyBpZiBJ IHRyeSB0byBjYXRjaCBzdWNoDQoNCmEgd3JpdGUgd2hlbiBhIGd1ZXN0IHRyaWVzIHRvIHNpemUg dGhlIEJBUj8gVGhlIG9ubHkgZGlmZmVyZW5jZSBpcyB0aGF0DQoNCkkgY29tcGFyZSBhcw0KDQog wqDCoMKgwqDCoMKgwqAgaWYgKCAodmFsICYgUENJX0JBU0VfQUREUkVTU19NRU1fTUFTS18zMikg PT0gUENJX0JBU0VfQUREUkVTU19NRU1fTUFTS18zMiApDQp3aGljaCBpcyBiZWNhdXNlIHZhbCBp biB0aGUgcXVlc3Rpb24gaGFzIGxvd2VyIGJpdHMgY2xlYXJlZC4NCg0KV2l0aCB0aGF0IHJlc3Bl Y3QgSSBzZWUgbm8gb2J2aW91cyByZWFzb24gd2h5IHdlIGNhbid0IGNvbnN0cnVjdCBvdXIgY29k ZQ0KDQphcyBpdCBpcy4NCg0KPg0KPj4gICB9DQo+PiAgIA0KPj4gICBzdGF0aWMgdWludDMyX3Qg Z3Vlc3RfYmFyX3JlYWQoY29uc3Qgc3RydWN0IHBjaV9kZXYgKnBkZXYsIHVuc2lnbmVkIGludCBy ZWcsDQo+PiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB2b2lkICpkYXRhKQ0KPj4g ICB7DQo+PiAtICAgIHJldHVybiAweGZmZmZmZmZmOw0KPj4gKyAgICBzdHJ1Y3QgdnBjaV9iYXIg KmJhciA9IGRhdGE7DQo+PiArICAgIHVpbnQzMl90IHZhbDsNCj4+ICsgICAgYm9vbCBoaSA9IGZh bHNlOw0KPj4gKw0KPj4gKyAgICBzd2l0Y2ggKCBiYXItPnR5cGUgKQ0KPj4gKyAgICB7DQo+PiAr ICAgIGNhc2UgVlBDSV9CQVJfTUVNNjRfSEk6DQo+PiArICAgICAgICBBU1NFUlQocmVnID4gUENJ X0JBU0VfQUREUkVTU18wKTsNCj4+ICsgICAgICAgIGJhci0tOw0KPj4gKyAgICAgICAgaGkgPSB0 cnVlOw0KPj4gKyAgICAgICAgLyogZmFsbHRocm91Z2ggKi8NCj4+ICsgICAgY2FzZSBWUENJX0JB Ul9NRU02NF9MTzoNCj4+ICsgICAgew0KPiBQbGVhc2UgZG9uJ3QgYWRkIGJyYWNlcyB0byBjYXNl IGJsb2NrcyB3aGVuIHRoZXkncmUgbm90IG5lZWRlZC4NClN1cmUNCj4NCj4+ICsgICAgICAgIGlm ICggaGkgKQ0KPj4gKyAgICAgICAgICAgIHZhbCA9IGJhci0+Z3Vlc3RfYWRkciA+PiAzMjsNCj4+ ICsgICAgICAgIGVsc2UNCj4+ICsgICAgICAgICAgICB2YWwgPSBiYXItPmd1ZXN0X2FkZHIgJiAw eGZmZmZmZmZmOw0KPj4gKyAgICAgICAgaWYgKCAodmFsICYgUENJX0JBU0VfQUREUkVTU19NRU1f TUFTS18zMikgPT0gIFBDSV9CQVNFX0FERFJFU1NfTUVNX01BU0tfMzIgKQ0KPiBUaGlzIGlzIHdy b25nIHdoZW4gZmFsbGluZyB0aHJvdWdoIHRvIGhlcmUgZnJvbSBWUENJX0JBUl9NRU02NF9ISToN Cj4gQWxsIDMyIGJpdHMgbmVlZCB0byBiZSBsb29rZWQgYXQuDQpHb29kIGNhdGNoLCB3aWxsIGZp eA0KPiAgIFlldCBhcyBwZXIgdGhlIGNvbW1lbnQgZnVydGhlcg0KPiB1cCBJIHRoaW5rIGl0IGlz bid0IHJpZ2h0IGFueXdheSB0byBhcHBseSB0aGUgbWFzayBoZXJlLg0KPg0KPiBBbHNvOiBTdHJh eSBkb3VibGUgYmxhbmtzLg0KPg0KPj4gKyAgICAgICAgew0KPj4gKyAgICAgICAgICAgIC8qIEd1 ZXN0cyBkZXRlY3RzIEJBUidzIHByb3BlcnRpZXMgYW5kIHNpemVzLiAqLw0KPj4gKyAgICAgICAg ICAgIGlmICggaGkgKQ0KPj4gKyAgICAgICAgICAgICAgICB2YWwgPSBiYXItPnNpemUgPj4gMzI7 DQo+PiArICAgICAgICAgICAgZWxzZQ0KPj4gKyAgICAgICAgICAgICAgICB2YWwgPSAweGZmZmZm ZmZmICYgfihiYXItPnNpemUgLSAxKTsNCj4+ICsgICAgICAgIH0NCj4+ICsgICAgICAgIGlmICgg IWhpICkNCj4+ICsgICAgICAgIHsNCj4+ICsgICAgICAgICAgICB2YWwgfD0gUENJX0JBU0VfQURE UkVTU19NRU1fVFlQRV82NDsNCj4+ICsgICAgICAgICAgICB2YWwgfD0gYmFyLT5wcmVmZXRjaGFi bGUgPyBQQ0lfQkFTRV9BRERSRVNTX01FTV9QUkVGRVRDSCA6IDA7DQo+PiArICAgICAgICB9DQo+ PiArICAgICAgICBiYXItPmd1ZXN0X2FkZHIgJj0gfigweGZmZmZmZmZmdWxsIDw8IChoaSA/IDMy IDogMCkpOw0KPj4gKyAgICAgICAgYmFyLT5ndWVzdF9hZGRyIHw9ICh1aW50NjRfdCl2YWwgPDwg KGhpID8gMzIgOiAwKTsNCj4+ICsgICAgICAgIGJyZWFrOw0KPj4gKyAgICB9DQo+PiArICAgIGNh c2UgVlBDSV9CQVJfTUVNMzI6DQo+IFBsZWFzZSBzZXBhcmF0ZSBub24tZmFsbC10aHJvdWdoIGNh c2UgYmxvY2tzIGJ5IGEgYmxhbmsgbGluZS4NCldpbGwgZG8NCj4NCj4+IEBAIC01MjIsNiArNTgy LDEzIEBAIHN0YXRpYyBpbnQgYWRkX2Jhcl9oYW5kbGVycyhzdHJ1Y3QgcGNpX2RldiAqcGRldiwg Ym9vbCBpc19od2RvbSkNCj4+ICAgICAgICAgICAgICAgaWYgKCByYyApDQo+PiAgICAgICAgICAg ICAgICAgICByZXR1cm4gcmM7DQo+PiAgICAgICAgICAgfQ0KPj4gKyAgICAgICAgLyoNCj4+ICsg ICAgICAgICAqIEl0IGlzIG5laXRoZXIgc2FmZSBub3Igc2VjdXJlIHRvIGluaXRpYWxpemUgZ3Vl c3QncyB2aWV3IG9mIHRoZSBCQVJzDQo+PiArICAgICAgICAgKiB3aXRoIHJlYWwgdmFsdWVzIHdo aWNoIGFyZSB1c2VkIGJ5IHRoZSBoYXJkd2FyZSBkb21haW4sIHNvIGFzc2lnbg0KPj4gKyAgICAg ICAgICogYWxsIHplcm9zIHRvIGd1ZXN0J3MgdmlldyBvZiB0aGUgQkFScywgc28gdGhlIGd1ZXN0 IGNhbiBwZXJmb3JtDQo+PiArICAgICAgICAgKiBwcm9wZXIgUENJIGRldmljZSBlbnVtZXJhdGlv biBhbmQgYXNzaWduIEJBUnMgb24gaXRzIG93bi4NCj4+ICsgICAgICAgICAqLw0KPj4gKyAgICAg ICAgYmFyc1tpXS5ndWVzdF9hZGRyID0gMDsNCj4gSSdtIGFmcmFpZCBJIGRvbid0IHVuZGVyc3Rh bmQgdGhlIGNvbW1lbnQ6IFdpdGhvdXQgbWVtb3J5IGRlY29kaW5nDQo+IGVuYWJsZWQsIHRoZSBC QVJzIGFyZSBzaW1wbGUgcmVnaXN0ZXJzICh3aXRoIGEgZmV3IHIvbyBiaXRzKS4NCg0KTXkgZmly c3QgaW1wbGVtZW50YXRpb24gd2FzIHRoYXQgYmFyLT5ndWVzdF9hZGRyIHdhcyBpbml0aWFsaXpl ZCB3aXRoDQoNCnRoZSB2YWx1ZSBvZiBiYXItPmFkZHIgKHBoeXNpY2FsIEJBUiB2YWx1ZSksIGJ1 dCB0YWxraW5nIG9uIElSQyB3aXRoDQoNClJvZ2VyIGhlIHN1Z2dlc3RlZCB0aGF0IHRoaXMgbWln aHQgYmUgYSBzZWN1cml0eSBpc3N1ZSB0byBsZXQgZ3Vlc3QNCg0KYSBoaW50IGFib3V0IHBoeXNp Y2FsIHZhbHVlcywgc28gdGhlbiBJIGNoYW5nZWQgdGhlIGFzc2lnbm1lbnQgdG8gYmUgMC4NCg0K VGh1cyB0aGUgY29tbWVudA0KDQo+DQo+PiAtLS0gYS94ZW4vaW5jbHVkZS94ZW4vcGNpX3JlZ3Mu aA0KPj4gKysrIGIveGVuL2luY2x1ZGUveGVuL3BjaV9yZWdzLmgNCj4+IEBAIC0xMDMsNiArMTAz LDcgQEANCj4+ICAgI2RlZmluZSAgUENJX0JBU0VfQUREUkVTU19NRU1fVFlQRV82NAkweDA0CS8q IDY0IGJpdCBhZGRyZXNzICovDQo+PiAgICNkZWZpbmUgIFBDSV9CQVNFX0FERFJFU1NfTUVNX1BS RUZFVENICTB4MDgJLyogcHJlZmV0Y2hhYmxlPyAqLw0KPj4gICAjZGVmaW5lICBQQ0lfQkFTRV9B RERSRVNTX01FTV9NQVNLCSh+MHgwZlVMKQ0KPj4gKyNkZWZpbmUgIFBDSV9CQVNFX0FERFJFU1Nf TUVNX01BU0tfMzIJKH4weDBmVSkNCj4gUGxlYXNlIGRvbid0IGludHJvZHVjZSBhbiBpZGVudGlj YWwgY29uc3RhbnQgdGhhdCdzIG1lcmVseSBvZg0KPiBkaWZmZXJlbnQgdHlwZS4gKHVpbnQzMl90 KVBDSV9CQVNFX0FERFJFU1NfTUVNX01BU0sgYXQgdGhlIHVzZQ0KPiBzaXRlIChpZiBhY3R1YWxs eSBzdGlsbCBuZWVkZWQgYXMgcGVyIHRoZSBjb21tZW50IGFib3ZlKSB3b3VsZA0KPiBzZWVtIG1v cmUgY2xlYXIgdG8gbWUuDQpPaywgSSB0aG91Z2h0IHR5cGUgY2FzdGluZyBpcyBhIGJpZ2dlciBl dmlsIGhlcmUNCj4NCj4gSmFuDQoNClRoYW5rIHlvdSwNCg0KT2xla3NhbmRyDQo= From xen-devel-bounces@lists.xenproject.org Tue Sep 07 13:42:57 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 13:42:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.181055.328023 (Exim 4.92) (envelope-from ) id 1mNbNE-0004Ym-Nu; Tue, 07 Sep 2021 13:42:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 181055.328023; Tue, 07 Sep 2021 13:42:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNbNE-0004Yf-Kr; Tue, 07 Sep 2021 13:42:52 +0000 Received: by outflank-mailman (input) for mailman id 181055; Tue, 07 Sep 2021 13:42:51 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNbND-0004YZ-BJ for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 13:42:51 +0000 Received: from sender4-of-o51.zoho.com (unknown [136.143.188.51]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 7ddadf84-0fe1-11ec-b0f3-12813bfff9fa; Tue, 07 Sep 2021 13:42:50 +0000 (UTC) Received: from [10.10.1.146] (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1631022164109295.00066750460735; Tue, 7 Sep 2021 06:42:44 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7ddadf84-0fe1-11ec-b0f3-12813bfff9fa ARC-Seal: i=1; a=rsa-sha256; t=1631022167; cv=none; d=zohomail.com; s=zohoarc; b=EwXVjk7o0+dNW6BQyzIDtRSYN4NmBvRZLsUpPEsZNhVlT1DAgbWz+pViSNQTi4ASsluqS88rEakdUxr/EHLYUZwaYP9AtnT5YOtWsyMGFti+D9i2cLq4GKOJrkIn/cqKXBVHgjXefaKQ6sV2LKITuag2vkUo0cDMfne5LpeadHY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1631022167; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=CYEF02zRg0djSWApjMYgBANnz2rEyed+agc2MJGNgJ4=; b=Wlgl57FKbX4InW3weDbgq8QTjou/oRB0zBjMlZPmUWuENbYe3kgGJAavDsERwnnOCe1Qu8Wa30dKo6LQnJ7gh/nDQH5ri7Y6D4NkEz677pYErByE/UNjXalqhikxcedvuP4uBIkCyZ5aTOA6W2X0EmQC8Wyj9o7G2VK/u3ZIsa0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1631022167; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Subject:To:Cc:References:From:Message-ID:Date:MIME-Version:In-Reply-To:Content-Type:Content-Transfer-Encoding; bh=CYEF02zRg0djSWApjMYgBANnz2rEyed+agc2MJGNgJ4=; b=Z0vhHWYhejqxTL3qqWAPWN6v0Hzj/xcmLsISh4Y0oLXgwrIhTYN6OU10zLEAuYf4 V0Eah+42XDGWEwRECKo40MbBD0haeKS6lC82QUm6BJkZ5gfXykXvsond1LfSezoUjul x7SQp7BOFUeE9Bf18jf0d6rEySnNg+9SUzORHZxI= Subject: Re: [PATCH v4 04/11] xsm: apply coding style To: Andrew Cooper , xen-devel@lists.xenproject.org Cc: Daniel De Graaf References: <20210903190629.11917-1-dpsmith@apertussolutions.com> <20210903190629.11917-5-dpsmith@apertussolutions.com> <01c81885-9ea0-3ecf-66b0-009b9e7ba39b@citrix.com> From: "Daniel P. Smith" Message-ID: Date: Tue, 7 Sep 2021 09:41:00 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <01c81885-9ea0-3ecf-66b0-009b9e7ba39b@citrix.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-ZohoMailClient: External On 9/6/21 2:17 PM, Andrew Cooper wrote: > On 03/09/2021 20:06, Daniel P. Smith wrote: >> Instead of intermixing coding style changes with code changes as they >> are come upon in this patch set, moving all coding style changes >> into a single commit. The focus of coding style changes here are, >> >> - move trailing comments to line above >> - ensuring line length does not exceed 80 chars >> - ensuring proper indentation for 80 char wrapping >> - covert u32 type statements to uint32_t >> - remove space between closing and opening parens >> - drop extern on function declarations >> >> Signed-off-by: Daniel P. Smith >> --- >> xen/include/xsm/dummy.h | 173 +++++++++----- >> xen/include/xsm/xsm.h | 494 ++++++++++++++++++++++------------------ >> xen/xsm/xsm_core.c | 4 +- >> 3 files changed, 389 insertions(+), 282 deletions(-) >> >> diff --git a/xen/include/xsm/dummy.h b/xen/include/xsm/dummy.h >> index 214b5408b1..deaf23035e 100644 >> --- a/xen/include/xsm/dummy.h >> +++ b/xen/include/xsm/dummy.h >> @@ -69,8 +69,9 @@ void __xsm_action_mismatch_detected(void); >> >> #endif /* CONFIG_XSM */ >> >> -static always_inline int xsm_default_action( >> - xsm_default_t action, struct domain *src, struct domain *target) >> +static always_inline int xsm_default_action(xsm_default_t action, >> + struct domain *src, >> + struct domain *target) > > The old code is correct.  We have plenty of examples of this in Xen, and > I have been adding new ones when appropriate. > > It avoids squashing everything on the RHS and ballooning the line count > to compensate.  (This isn't a particularly bad example, but we've had > worse cases in the past). Based on the past discussions I understood either is acceptable and find this version much easier to visually parse myself. With that said, if the "next line single indent" really is the preferred style by the maintainers/community, then I can convert all of these over. >> { >> switch ( action ) { >> case XSM_HOOK: >> @@ -99,12 +100,13 @@ static always_inline int xsm_default_action( >> } >> >> static XSM_INLINE void xsm_security_domaininfo(struct domain *d, >> - struct xen_domctl_getdomaininfo *info) >> + struct xen_domctl_getdomaininfo *info) > > This doesn't match any styles I'm aware of.  Either struct domain on the > new line, or the two structs vertically aligned. > > It more obviously highlights why squashing all parameters on the RHS is > a bad move. Apologies I let one slip through, though going through over 80-some function defs trying to make sure they are all aligned and missing one I would say is not a bad job. >> @@ -291,37 +307,41 @@ static XSM_INLINE void xsm_evtchn_close_post(struct evtchn *chn) >> return; >> } >> >> -static XSM_INLINE int xsm_evtchn_send(XSM_DEFAULT_ARG struct domain *d, struct evtchn *chn) >> +static XSM_INLINE int xsm_evtchn_send(XSM_DEFAULT_ARG struct domain *d, >> + struct evtchn *chn) >> { >> XSM_ASSERT_ACTION(XSM_HOOK); >> return xsm_default_action(action, d, NULL); >> } >> >> -static XSM_INLINE int xsm_evtchn_status(XSM_DEFAULT_ARG struct domain *d, struct evtchn *chn) >> +static XSM_INLINE int xsm_evtchn_status(XSM_DEFAULT_ARG struct domain *d, >> + struct evtchn *chn) >> { >> XSM_ASSERT_ACTION(XSM_TARGET); >> return xsm_default_action(action, current->domain, d); >> } >> >> -static XSM_INLINE int xsm_evtchn_reset(XSM_DEFAULT_ARG struct domain *d1, struct domain *d2) >> +static XSM_INLINE int xsm_evtchn_reset(XSM_DEFAULT_ARG struct domain *d1, >> + struct domain *d2) >> { >> XSM_ASSERT_ACTION(XSM_TARGET); >> return xsm_default_action(action, d1, d2); >> } >> >> -static XSM_INLINE int xsm_alloc_security_evtchns( >> - struct evtchn chn[], unsigned int nr) >> +static XSM_INLINE int xsm_alloc_security_evtchns(struct evtchn chn[], >> + unsigned int nr) > > I maintain that this was correct before. Getting to this point I must say it would be helpful if this could be spelled out in CODING_STYLE. Specifically, so that I am clear, if a parameter overflows, than all the parameters overflow? Are there exceptions such as if overflow doesn't happen until the third of four or the fourth parameter. Having a rule set would be much more helpful than trying to look for examples elsewhere in code. >> diff --git a/xen/include/xsm/xsm.h b/xen/include/xsm/xsm.h >> index 9872bae502..8878281eae 100644 >> --- a/xen/include/xsm/xsm.h >> +++ b/xen/include/xsm/xsm.h >> @@ -19,7 +19,7 @@ >> #include >> >> /* policy magic number (defined by XSM_MAGIC) */ >> -typedef u32 xsm_magic_t; >> +typedef uint32_t xsm_magic_t; >> >> #ifdef CONFIG_XSM_FLASK >> #define XSM_MAGIC 0xf97cff8c >> @@ -31,158 +31,171 @@ typedef u32 xsm_magic_t; >> * default actions of XSM hooks. They should be compiled out otherwise. >> */ >> enum xsm_default { >> - XSM_HOOK, /* Guests can normally access the hypercall */ >> - XSM_DM_PRIV, /* Device model can perform on its target domain */ >> - XSM_TARGET, /* Can perform on self or your target domain */ >> - XSM_PRIV, /* Privileged - normally restricted to dom0 */ >> - XSM_XS_PRIV, /* Xenstore domain - can do some privileged operations */ >> - XSM_OTHER /* Something more complex */ >> + /* Guests can normally access the hypercall */ >> + XSM_HOOK, >> + /* Device model can perform on its target domain */ >> + XSM_DM_PRIV, >> + /* Can perform on self or your target domain */ >> + XSM_TARGET, >> + /* Privileged - normally restricted to dom0 */ >> + XSM_PRIV, >> + /* Xenstore domain - can do some privileged operations */ >> + XSM_XS_PRIV, >> + /* Something more complex */ >> + XSM_OTHER >> }; > > Why?  This takes a table which was unambiguous to read, and makes it > ambiguous at a glance.  You want either no change at all, or blank lines > between comment/constant pairs so you don't need to read to either end > to figure out how to parse the comments. I went back to the comment that prompted me to do this and rereading now makes me think I took it to literal. Specifically, "...I'd like to encourage you to also address other style issues in the newly introduced file. Here I'm talking about comment style, requiring /* to be on its own line." I took that to include these as well since I am pretty sure I have seen elsewhere this kind of commenting. Regardless, looking back I can see how the meaning could have only for other block quotes. Honestly I will gladly change it back as I think that is far clearer. v/r, dps From xen-devel-bounces@lists.xenproject.org Tue Sep 07 13:46:34 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 13:46:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.181062.328035 (Exim 4.92) (envelope-from ) id 1mNbQn-0005Cc-9s; Tue, 07 Sep 2021 13:46:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 181062.328035; Tue, 07 Sep 2021 13:46:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNbQn-0005CV-5U; Tue, 07 Sep 2021 13:46:33 +0000 Received: by outflank-mailman (input) for mailman id 181062; Tue, 07 Sep 2021 13:46:31 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNbQl-0005CP-Ej for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 13:46:31 +0000 Received: from sender4-of-o51.zoho.com (unknown [136.143.188.51]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 0136ce42-0fe2-11ec-b0f3-12813bfff9fa; Tue, 07 Sep 2021 13:46:30 +0000 (UTC) Received: from [10.10.1.146] (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1631022384849480.93473938892373; Tue, 7 Sep 2021 06:46:24 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0136ce42-0fe2-11ec-b0f3-12813bfff9fa ARC-Seal: i=1; a=rsa-sha256; t=1631022387; cv=none; d=zohomail.com; s=zohoarc; b=RXKB9dUWNPWkgmcdISqdTGb0F5yGEg6QznZcElAc8HE42k1NyujAz5oBU6OovQgwQHARHCz1ofQqU+IDSGJDUR9L90zXX/zhh3GHuBjkJv4Z5ujZbcbiSl3LAxcPuM/FcJAwgpCEYaelGBInQUJ7x+B0BuF5XtfZGQO+h2T25gc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1631022387; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=Eg118G40UsDAktVHH5I+xA97QrEkwUrl+xfBDFWQE6I=; b=Z/GnHDIBMRsR+uzsWuAQhp7XNaMctaRpx2vpKOX0lPC4/w6lDla52HKkeR2kmJnQ4STfc0m9DaRxFOLhRUVNx9abrfflmwIEa6fBbQvZrKyxW8xVSpsKG1CF59Z1K2fdVJ89wf5WIC+CbhDN6XbjY1U/dLrrZ4Pz2UO2rLQaclM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1631022387; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Subject:To:Cc:References:From:Message-ID:Date:MIME-Version:In-Reply-To:Content-Type:Content-Transfer-Encoding; bh=Eg118G40UsDAktVHH5I+xA97QrEkwUrl+xfBDFWQE6I=; b=YwBx7uc3aQS5R3OnGe61qLhP5pMEjDZFNJN1vPoWD321v0l/dqoUZI94l0Ppnkvi B9yGK94uo3rzfafP3yR33cMU2tRnOLIbM2Eyf68n7Az4lx3HqmoGmttzAzXjcspBpQv brPwbd4MwL5SqFT6C34EZKzKoQuBBkWPSVIYsLRE= Subject: Re: [PATCH v4 05/11] xsm: refactor xsm_ops handling To: Andrew Cooper , xen-devel@lists.xenproject.org Cc: Daniel De Graaf References: <20210903190629.11917-1-dpsmith@apertussolutions.com> <20210903190629.11917-6-dpsmith@apertussolutions.com> <6924c3ea-de14-60e5-d3dc-eaff6c228f1c@citrix.com> From: "Daniel P. Smith" Message-ID: Date: Tue, 7 Sep 2021 09:44:41 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <6924c3ea-de14-60e5-d3dc-eaff6c228f1c@citrix.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-ZohoMailClient: External On 9/6/21 2:31 PM, Andrew Cooper wrote: > On 03/09/2021 20:06, Daniel P. Smith wrote: >> This renames the `struct xsm_operations` to the shorter `struct xsm_ops` and >> converts the global xsm_ops from being a pointer to an explicit instance. As >> part of this conversion, it reworks the XSM modules init function to return >> their xsm_ops struct which is copied in to the global xsm_ops instance. >> >> Signed-off-by: Daniel P. Smith > > Acked-by: Andrew Cooper > > However, some suggestions... > >> diff --git a/xen/xsm/xsm_core.c b/xen/xsm/xsm_core.c >> index 55483292c5..859af3fe9a 100644 >> --- a/xen/xsm/xsm_core.c >> +++ b/xen/xsm/xsm_core.c >> @@ -28,9 +28,17 @@ >> #include >> #endif >> >> -#define XSM_FRAMEWORK_VERSION "1.0.0" >> +#define XSM_FRAMEWORK_VERSION "1.0.1" >> >> -struct xsm_operations *xsm_ops; >> +struct xsm_ops __read_mostly xsm_ops; >> + >> +enum xsm_ops_state { >> + XSM_OPS_UNREGISTERED, >> + XSM_OPS_REG_FAILED, >> + XSM_OPS_REGISTERED, >> +}; >> + >> +static enum xsm_ops_state xsm_ops_registered = XSM_OPS_UNREGISTERED; > > __read_mostly, or can this be __initdata ? Apologies, I think you may have suggested this before. It would be good to be able to check this later but currently since I just introduced this and it is only used during init, it could be made __initdata for now and later if it gets exposed, then it can be moved to __read_mostly. Do you agree? >> @@ -87,25 +88,35 @@ static int __init xsm_core_init(const void *policy_buffer, size_t policy_size) >> } >> #endif >> >> - if ( verify(&dummy_xsm_ops) ) >> + if ( xsm_ops_registered != XSM_OPS_UNREGISTERED ) >> { >> - printk(XENLOG_ERR "Could not verify dummy_xsm_ops structure\n"); >> + printk(XENLOG_ERR >> + "Could not init XSM, xsm_ops register already attempted\n"); >> return -EIO; >> } >> >> - xsm_ops = &dummy_xsm_ops; >> - >> switch ( xsm_bootparam ) >> { >> case XSM_BOOTPARAM_DUMMY: >> + xsm_ops_registered = XSM_OPS_REGISTERED; >> break; >> >> case XSM_BOOTPARAM_FLASK: >> - flask_init(policy_buffer, policy_size); >> + ops = flask_init(policy_buffer, policy_size); >> + if ( ops ) >> + { >> + xsm_ops_registered = XSM_OPS_REGISTERED; >> + xsm_ops = *ops; >> + } >> break; >> >> case XSM_BOOTPARAM_SILO: >> - silo_init(); >> + ops = silo_init(); >> + if ( ops ) >> + { >> + xsm_ops_registered = XSM_OPS_REGISTERED; >> + xsm_ops = *ops; >> + } > > This if ( ops ) block can be deduplicated by moving after the switch() > statement.  It's going to be common to all everything except dummy. Good call. I will rework to remove the duplication. v/r, dps From xen-devel-bounces@lists.xenproject.org Tue Sep 07 13:51:12 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 13:51:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.181070.328046 (Exim 4.92) (envelope-from ) id 1mNbVD-0006pp-VY; Tue, 07 Sep 2021 13:51:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 181070.328046; Tue, 07 Sep 2021 13:51:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNbVD-0006pi-SS; Tue, 07 Sep 2021 13:51:07 +0000 Received: by outflank-mailman (input) for mailman id 181070; Tue, 07 Sep 2021 13:51:05 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNbVB-0006pc-PY for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 13:51:05 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 7256216b-c29c-4c48-85fd-64c86b5c82b2; Tue, 07 Sep 2021 13:51:04 +0000 (UTC) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01lp2055.outbound.protection.outlook.com [104.47.0.55]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-5--Wrg1pWOO-eZLwVB7v2VBw-1; Tue, 07 Sep 2021 15:51:02 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR04MB6863.eurprd04.prod.outlook.com (2603:10a6:803:12f::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14; Tue, 7 Sep 2021 13:51:01 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4500.014; Tue, 7 Sep 2021 13:51:01 +0000 Received: from [10.156.60.236] (37.24.206.209) by AM0PR04CA0064.eurprd04.prod.outlook.com (2603:10a6:208:1::41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Tue, 7 Sep 2021 13:51:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7256216b-c29c-4c48-85fd-64c86b5c82b2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1631022663; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oD9lEvFvJWfwl3ApFpXACR6rFLHSyvQV5QD0/g24X+M=; b=f3PpwEUzXbe7i0ifMyT1QoSD6FlOFZhxEXYtuZj1oZo0KuoUFgu8bdAEyMacqwhk7C0EEI 7Pvqy0XpErEeZ9LE2GxmYhdybEug1GSLTIt7IPpCePoOb1Dk3NwRDaREmeGWh0H4+6BFuY 4jaIckJbHyHyb/wYk9D6iQpnBugsNIs= X-MC-Unique: -Wrg1pWOO-eZLwVB7v2VBw-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ned0cZd1dBZbzV6j7mc4luj8weeZVsOjB7ioXLV6QW8WAGVNxOa4SXoKB7MYRAVhfZeJIKDiYPIGxYe0OoRUtRoCRlSORf178gxbqgQLqU0zRlozhXsjXem3PEIaAzhBCCfLSkerAenGr1oxE0KpcqODIj5pBqC+fbX+Rv4aTmEf3kq6BBAgz0YWqxb0qzFoB2FYvKqy+99idZ4O677T15CCequP4qSlnmNWvsW6q1aoUsLR8DgYsoUaggEdVxUb8bV0YO6o2N9rJRAmt5abKvzJuNaCEw3SiIvQE+retMTe/UZ17r09o8HCLyq5UEzvJBmgslQDUIObVooQ/4/y5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=12dn3pQY22t0OvIVVptgaOURbegA5BTrCgl17yzHBvQ=; b=Q2BxwsHdGemQzr/oBDtl+XiBZgjCpiXxAiQ7A6AdWR9ezJTp3tiEpr8I1hgsnyGwNFgRNocsxkOwfDoUOBwWSQr9cbpfgsZjr72kchN672kJ+AYp0abFihKUApkiLRsKpeeP3m/oUxWexZUlfc8kI/OrMxetayPrKxNS0INKy6a1IyyxP94Usl+J1ixVjbopDUXQX2M1e9qnFKXqYrFPijlAzfXRVBmBajWUL4+wHwcvNS6zoBXiJ1tSbQuADf2GwuqiibhbHLntMTKONv78NsDIYKqriITbq9m8ecVs2/Zfdyf4occ2VcNmGESDR3ZmqUczg8U7gzXEB43tqQHz5A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com; Subject: Re: [PATCH v4 04/11] xsm: apply coding style To: "Daniel P. Smith" CC: Daniel De Graaf , Andrew Cooper , xen-devel@lists.xenproject.org References: <20210903190629.11917-1-dpsmith@apertussolutions.com> <20210903190629.11917-5-dpsmith@apertussolutions.com> <01c81885-9ea0-3ecf-66b0-009b9e7ba39b@citrix.com> From: Jan Beulich Message-ID: Date: Tue, 7 Sep 2021 15:50:58 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AM0PR04CA0064.eurprd04.prod.outlook.com (2603:10a6:208:1::41) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 50a728d6-2f4f-4ea6-097e-08d972068704 X-MS-TrafficTypeDiagnostic: VI1PR04MB6863: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: BR23Jgn5+63Wq7KKhHVcnogmEGxKfIemIg7d3RknOCH7AB5Bd6qr/I5OiupuEQcf5M9CvxfvEbjtwP4ZNXt6S975hLHVtTMeq6nyWHEktGCz/D6h2ljw2M/rptDkgX12jdNXmxFg9VASnFouXgOMzgDQS6mZMp8nppkUpVmGwez3bpE236/mw5pFWmX7V4vBxq0eLigQiBqtK6YzzsNGYlyZrL1L4fU27XpcICa5AFC/Oe94HSArFdT2XvLPFN3psi0anXzFl6kpjV29JuJbSL0yyu9/pZENR7bJzeNzl5wcaXbpblYK4IoPZTzoPJZuRN/U81rF1PRSskTJ/qdrfsm/Kb9+A+Xi+NuJu75sdsmFncncTQfUf1Uuew7gOoRo4wrjf8uE2aYnzCYhla6PAMgoIb2DBzmCNCKStyma9lDyiuA+5oXtHweazMVhDcCiGaaX/CRah/hkAZa4HFfv3HeRiJvAhwGRe8KQ/ekb7/GTo8G5v6Yy5m8FZUg36/ixHjiYX28Bcn20/uqjrZC3hKID+yI3khB0t3+zq5LS06M3N+0cUTJHxfMVdDoAeHQMkdBrRmGQFAGFMnAdvchgRs3RuL06NTHhIbYMgK2jWR4QylHULCTh6Q95v1wwnNoIDuBxQ+917gHf5WSiroPQpvVPT/MFqadw3Q+RglBmf63fWvztoeGHuGfvsSVgBaDfkl1FG1Lrm/dOntzdYi6Wi4ou4KilabkYTeNNRwFkf+U= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(376002)(136003)(396003)(346002)(366004)(39860400002)(66556008)(31686004)(5660300002)(66946007)(66476007)(38100700002)(478600001)(2906002)(6486002)(6916009)(186003)(8676002)(26005)(31696002)(83380400001)(36756003)(54906003)(8936002)(2616005)(316002)(956004)(86362001)(4326008)(16576012)(53546011)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?VbgZAVlMZQXopuq0YOhPxSVGwvXueUBAt5SVmjJpVgRET6A5vhiXHEZYkTn4?= =?us-ascii?Q?YN+ZLMOhDDi3GyaCadVAuEmEkA6MYDZs0bdpcvwL7IZGGl0y82i1Imy3WcQE?= =?us-ascii?Q?ndPB6J+VUzyyVp+IoGNRlRQCjQnxcKZuZaj4g7JMWJAUErqjWgNTfBPCJ3R1?= =?us-ascii?Q?4kq6Begn2vEQDNpgXtmoIb3tqFLx8nHVp2IWZemwxXji3n05S3l9wiSD3t3X?= =?us-ascii?Q?nY+p0rrmsNJM7HEz4mhFIIDAn0rymxe9oBZP8gn8jBuKwnkXYLq514ShN3B9?= =?us-ascii?Q?+wNnYMtgbEBSPgEUdMgFhjcfXdpJ6zEVkFzx4EuUEGN1D0cZFLm/YnhbcwEP?= =?us-ascii?Q?s6JZ6HqkitphxjT3VatoVfsFnouDkHR9xWy1Iivtd3xzfxOjAiEOJmYxYf0P?= =?us-ascii?Q?p7VEkZvJ0gi3FgEnKimwfztOgUJpXnWt3XSR4QECvYhprAKIbjcId/6na3up?= =?us-ascii?Q?t34f++8G7ylbgSRYTiFcwC/lsu1cSaWcklak6RMolRy2pP5pkblCiHwZE3hP?= =?us-ascii?Q?GN6SYBhPewqeh14y7Xtd68j6K3GYW1K2PFpYQsKWZ1b+woGtpdDmR6Or3gIY?= =?us-ascii?Q?bUzz/DG//NoQ0W++xmVnWEgfb3nh9I/fxVbIRyHGoTKAEedkZRPcLzO5noQ9?= =?us-ascii?Q?PKXoc4ZSEvupPjnb2xRkHuQ/C+ZpjH6AcDjsPfRwor0f3bFgKYdpUQT/yn08?= =?us-ascii?Q?wkJm+6tddC7rHWCj5FdRwAqLTrSqEL3wlxmRLcR1T+iT/WmF5e8ZxnT0d7Bo?= =?us-ascii?Q?h31KDxkwsW3IXlOZavMYAq1ys7CTh9CtexCDWNvnb9lOmCi73WkQxpw7uwHd?= =?us-ascii?Q?aj/AXSg8/IAjncYRJqzdS103PSoDLLFjiOezYUUZFjasjMzJJpYsTCKKBVAM?= =?us-ascii?Q?iN7luGS3FQtfI7/Kb/F5HeLHDR2Q9/1qw38O7P8Lzc9FP3VekNQsbYPmBst5?= =?us-ascii?Q?CJkBFuuoYY1tRPGPUHVLBDBWYc9uK9z8I3OyJAwi5htVAGdsQ87GNBstqpM6?= =?us-ascii?Q?2e7zTCWDwRRQetK9r59V2/XdvZmWbPRLZkaOomiCo41ZWsUUEctx91bpaeKM?= =?us-ascii?Q?FcxSGMj+ML9SJbFxDs3GQoHD9OyUZiNmHVluOpUkunbOUizQu4ulD++EhzGg?= =?us-ascii?Q?zN8XoAUSumOkgC3nE7lw7IYl3fPAAoVKecsEyRQVQp6Wpl/iG/cmjrwuyEnU?= =?us-ascii?Q?T+9eQA1fw7N39h50tkf1bbTdAIKkCUnMifV5w0FBUNkBMF4L+rmdkYzj7O5k?= =?us-ascii?Q?ER/shWt6vaps/Aa6cdluLfT36ER6vJRDub3BL59CmdYNf1uT55OtthjVadeQ?= =?us-ascii?Q?o4NTRlcBfZ9U/jc4N5m1oTcH?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 50a728d6-2f4f-4ea6-097e-08d972068704 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2021 13:51:01.1773 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: AVtYRxV+7RVobiCVcg3M4gzyYheJJ9EsKgDiDvnIgGH0S5G5oh/W5GBn8VCCkJM6fmMevcv9ekvSSnHYyfMh4A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6863 On 07.09.2021 15:41, Daniel P. Smith wrote: > On 9/6/21 2:17 PM, Andrew Cooper wrote: >> On 03/09/2021 20:06, Daniel P. Smith wrote: >>> --- a/xen/include/xsm/dummy.h >>> +++ b/xen/include/xsm/dummy.h >>> @@ -69,8 +69,9 @@ void __xsm_action_mismatch_detected(void); >>> =20 >>> #endif /* CONFIG_XSM */ >>> =20 >>> -static always_inline int xsm_default_action( >>> - xsm_default_t action, struct domain *src, struct domain *target) >>> +static always_inline int xsm_default_action(xsm_default_t action, >>> + struct domain *src, >>> + struct domain *target) >> >> The old code is correct.=C2=A0 We have plenty of examples of this in Xen= , and >> I have been adding new ones when appropriate. >> >> It avoids squashing everything on the RHS and ballooning the line count >> to compensate.=C2=A0 (This isn't a particularly bad example, but we've h= ad >> worse cases in the past). >=20 > Based on the past discussions I understood either is acceptable and find= =20 > this version much easier to visually parse myself. With that said, if > the "next line single indent" really is the preferred style by the=20 > maintainers/community, then I can convert all of these over. I guess neither is the "preferred" style; as Andrew says, both are acceptable and both are in active use. I guess the rule of thumb is: The longer what's left of the function name, the more you should consider the style that you change away from. Anyway, in the end I guess the request for style adjustments was mainly to purge bad style, not to convert one acceptable form to another. Converting the entire file to the same style is of course fine (for producing a consistent result), but then - as per above - here it would more likely be the one that in this case was already there. Jan From xen-devel-bounces@lists.xenproject.org Tue Sep 07 13:53:07 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 13:53:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.181076.328057 (Exim 4.92) (envelope-from ) id 1mNbX8-0007a0-Cm; Tue, 07 Sep 2021 13:53:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 181076.328057; Tue, 07 Sep 2021 13:53:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNbX8-0007Zt-9b; Tue, 07 Sep 2021 13:53:06 +0000 Received: by outflank-mailman (input) for mailman id 181076; Tue, 07 Sep 2021 13:53:04 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNbX6-0007Zn-Sy for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 13:53:04 +0000 Received: from smtp-out2.suse.de (unknown [195.135.220.29]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 45fbc0fe-7e96-4ad0-b06a-85d1b067e582; Tue, 07 Sep 2021 13:53:03 +0000 (UTC) Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id ADE741FF95; Tue, 7 Sep 2021 13:53:02 +0000 (UTC) Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap1.suse-dmz.suse.de (Postfix) with ESMTPS id 9515513A24; Tue, 7 Sep 2021 13:53:02 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap1.suse-dmz.suse.de with ESMTPSA id QE3gIr5uN2GgfwAAGKfGzw (envelope-from ); Tue, 07 Sep 2021 13:53:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 45fbc0fe-7e96-4ad0-b06a-85d1b067e582 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1631022782; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Ni/NQ190x3Mlq9HWfhTgoCgr+slvDM1E7IewUCMMiMQ=; b=G4U3H2ifSiawaKDYI8HS5SMBvYKZEi1oT4Sc57S9YIfwSpXnxLuvPI7N7gf+3h772GZciD vNCuiRcUob/LGW63FuezNGjKRClJQLuTVn3/wfTDeLW+WPsiqsNL9zIpY6oZKtifZ1dByn NyUEHzcx3aaKgipXopsDDFEzZzv4eV8= Subject: Re: xen-unstable linux-5.14: 1 of 2 multicall(s) failed: cpu 0 To: Sander Eikelenboom , "xen-devel@lists.xenproject.org" References: <9c36205e-cc37-ed9a-3408-0cccc4a83115@eikelenboom.it> From: Juergen Gross Message-ID: <955da8ce-40f2-32c5-ee78-6801ce18afe5@suse.com> Date: Tue, 7 Sep 2021 15:53:01 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <9c36205e-cc37-ed9a-3408-0cccc4a83115@eikelenboom.it> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Y0QXcXgTugGoqPx0Eq7pOX3EV4o9pfd7F" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Y0QXcXgTugGoqPx0Eq7pOX3EV4o9pfd7F Content-Type: multipart/mixed; boundary="dUye6vfcouJSbb1w8PO2dLlk1jDNCtNt9"; protected-headers="v1" From: Juergen Gross To: Sander Eikelenboom , "xen-devel@lists.xenproject.org" Message-ID: <955da8ce-40f2-32c5-ee78-6801ce18afe5@suse.com> Subject: Re: xen-unstable linux-5.14: 1 of 2 multicall(s) failed: cpu 0 References: <9c36205e-cc37-ed9a-3408-0cccc4a83115@eikelenboom.it> In-Reply-To: <9c36205e-cc37-ed9a-3408-0cccc4a83115@eikelenboom.it> --dUye6vfcouJSbb1w8PO2dLlk1jDNCtNt9 Content-Type: multipart/mixed; boundary="------------72E11293AFB37D2C9018C87B" Content-Language: en-US This is a multi-part message in MIME format. --------------72E11293AFB37D2C9018C87B Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 06.09.21 23:35, Sander Eikelenboom wrote: > L.S., >=20 > On my AMD box running: > =C2=A0=C2=A0=C2=A0 xen-unstable changeset: Fri Sep 3 15:10:43 2021 +02= 00 git:2d4978ead4 > =C2=A0=C2=A0=C2=A0 linux kernel: 5.14.1 >=20 > With this setup I'm encountering some issues in dom0, see below. Could you test whether the attached patch (only compile tested) fixes the issue for you? Juergen --------------72E11293AFB37D2C9018C87B Content-Type: text/x-patch; charset=UTF-8; name="0001-xen-fix-usage-of-pmd-pud_poplulate-in-mremap-for-pv-.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename*0="0001-xen-fix-usage-of-pmd-pud_poplulate-in-mremap-for-pv-.pa"; filename*1="tch" =46rom c9e4ce85bcb9003ffa4877743e1792ac6ec24f19 Mon Sep 17 00:00:00 2001 From: Juergen Gross To: x86@kernel.org To: linux-kernel@vger.kernel.org Cc: Boris Ostrovsky Cc: Juergen Gross Cc: Stefano Stabellini Cc: Thomas Gleixner Cc: Ingo Molnar Cc: Borislav Petkov Cc: "H. Peter Anvin" Cc: xen-devel@lists.xenproject.org Date: Tue, 7 Sep 2021 15:17:39 +0200 Subject: [PATCH] xen: fix usage of pmd/pud_poplulate in mremap for pv gue= sts Commit 0881ace292b662 ("mm/mremap: use pmd/pud_poplulate to update page table entries") introduced a regression when running as Xen PV guest. Today pmd/pud_poplulate() for Xen PV assumes that the PFN inserted is referencing a not yet used page table. In case of move_normal_pmd/pud() this is not true, resulting in WARN splats like: [34321.304270] ------------[ cut here ]------------ [34321.304277] WARNING: CPU: 0 PID: 23628 at arch/x86/xen/multicalls.c:10= 2 xen_mc_flush+0x176/0x1a0 [34321.304288] Modules linked in: [34321.304291] CPU: 0 PID: 23628 Comm: apt-get Not tainted 5.14.1-2021090= 6-doflr-mac80211debug+ #1 [34321.304294] Hardware name: MSI MS-7640/890FXA-GD70 (MS-7640) , BIOS V= 1.8B1 09/13/2010 [34321.304296] RIP: e030:xen_mc_flush+0x176/0x1a0 [34321.304300] Code: 89 45 18 48 c1 e9 3f 48 89 ce e9 20 ff ff ff e8 60 0= 3 00 00 66 90 5b 5d 41 5c 41 5d c3 48 c7 45 18 ea ff ff ff be 01 00 00 00= <0f> 0b 8b 55 00 48 c7 c7 10 97 aa 82 31 db 49 c7 c5 38 97 aa 82 65 [34321.304303] RSP: e02b:ffffc90000a97c90 EFLAGS: 00010002 [34321.304305] RAX: ffff88807d416398 RBX: ffff88807d416350 RCX: ffff88807= d416398 [34321.304306] RDX: 0000000000000001 RSI: 0000000000000001 RDI: deadbeefd= eadf00d [34321.304308] RBP: ffff88807d416300 R08: aaaaaaaaaaaaaaaa R09: ffff88800= 6160cc0 [34321.304309] R10: deadbeefdeadf00d R11: ffffea000026a600 R12: 000000000= 0000000 [34321.304310] R13: ffff888012f6b000 R14: 0000000012f6b000 R15: 000000000= 0000001 [34321.304320] FS: 00007f5071177800(0000) GS:ffff88807d400000(0000) knlG= S:0000000000000000 [34321.304322] CS: 10000e030 DS: 0000 ES: 0000 CR0: 0000000080050033 [34321.304323] CR2: 00007f506f542000 CR3: 00000000160cc000 CR4: 000000000= 0000660 [34321.304326] Call Trace: [34321.304331] xen_alloc_pte+0x294/0x320 [34321.304334] move_pgt_entry+0x165/0x4b0 [34321.304339] move_page_tables+0x6fa/0x8d0 [34321.304342] move_vma.isra.44+0x138/0x500 [34321.304345] __x64_sys_mremap+0x296/0x410 [34321.304348] do_syscall_64+0x3a/0x80 [34321.304352] entry_SYSCALL_64_after_hwframe+0x44/0xae [34321.304355] RIP: 0033:0x7f507196301a [34321.304358] Code: 73 01 c3 48 8b 0d 76 0e 0c 00 f7 d8 64 89 01 48 83 c= 8 ff c3 66 2e 0f 1f 84 00 00 00 00 00 66 90 49 89 ca b8 19 00 00 00 0f 05= <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d 46 0e 0c 00 f7 d8 64 89 01 48 [34321.304360] RSP: 002b:00007ffda1eecd38 EFLAGS: 00000246 ORIG_RAX: 0000= 000000000019 [34321.304362] RAX: ffffffffffffffda RBX: 000056205f950f30 RCX: 00007f507= 196301a [34321.304363] RDX: 0000000001a00000 RSI: 0000000001900000 RDI: 00007f506= dc56000 [34321.304364] RBP: 0000000001a00000 R08: 0000000000000010 R09: 000000000= 0000004 [34321.304365] R10: 0000000000000001 R11: 0000000000000246 R12: 00007f506= dc56060 [34321.304367] R13: 00007f506dc56000 R14: 00007f506dc56060 R15: 000056205= f950f30 [34321.304368] ---[ end trace a19885b78fe8f33e ]--- [34321.304370] 1 of 2 multicall(s) failed: cpu 0 [34321.304371] call 2: op=3D12297829382473034410 arg=3D[aaaaaaaaaaaaaa= aa] result=3D-22 Fix that by modifying xen_alloc_ptpage() to only pin the page table in case it wasn't pinned already. Fixes: 0881ace292b662 ("mm/mremap: use pmd/pud_poplulate to update page t= able entries") Cc: Reported-by: Sander Eikelenboom Signed-off-by: Juergen Gross --- arch/x86/xen/mmu_pv.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/arch/x86/xen/mmu_pv.c b/arch/x86/xen/mmu_pv.c index 1df5f01529e5..8d751939c6f3 100644 --- a/arch/x86/xen/mmu_pv.c +++ b/arch/x86/xen/mmu_pv.c @@ -1518,14 +1518,17 @@ static inline void xen_alloc_ptpage(struct mm_str= uct *mm, unsigned long pfn, if (pinned) { struct page *page =3D pfn_to_page(pfn); =20 - if (static_branch_likely(&xen_struct_pages_ready)) + pinned =3D false; + if (static_branch_likely(&xen_struct_pages_ready)) { + pinned =3D PagePinned(page); SetPagePinned(page); + } =20 xen_mc_batch(); =20 __set_pfn_prot(pfn, PAGE_KERNEL_RO); =20 - if (level =3D=3D PT_PTE && USE_SPLIT_PTE_PTLOCKS) + if (level =3D=3D PT_PTE && USE_SPLIT_PTE_PTLOCKS && !pinned) __pin_pagetable_pfn(MMUEXT_PIN_L1_TABLE, pfn); =20 xen_mc_issue(PARAVIRT_LAZY_MMU); --=20 2.26.2 --------------72E11293AFB37D2C9018C87B Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Transfer-Encoding: quoted-printable Content-Description: OpenPGP public key Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy= cWx w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O= f8Z d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y= 9bf IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq= G7/ 377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR= 3Jv c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA= QIe AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT= hpw dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0= MbD 1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv= oPH Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v= 5QL +qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ= 2Vu IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC= QoL BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr= Wf0 teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC= /nu AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh= ITT d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm= XBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz= 80h SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC= AcD AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn= FOX gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1= jnD kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0= N51 N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l= otu fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1= tqS EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA= hsD BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3= g3O ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5= dM7 wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5= D+j LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm= V2x AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N= Eaw QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW= nHI s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR= wgn BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV= bVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk= pEd IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA= QAB wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw= Tbe 8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1= vJz Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8= VGi wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW= svi uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX= zXs ZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------72E11293AFB37D2C9018C87B-- --dUye6vfcouJSbb1w8PO2dLlk1jDNCtNt9-- --Y0QXcXgTugGoqPx0Eq7pOX3EV4o9pfd7F Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmE3br4FAwAAAAAACgkQsN6d1ii/Ey+R Ewf/VFek8aJAUMbjuWxGgqIccUOkBjyZN2fG8a1f1eQ8VdKJy+lTH7Z9pu+iyBBVTwutLHdYP1gU 7yDd040CmChljDWQz4ZdzvvJulVvlze6dcGrjhfUwfZADRS+mHc8iO/jDjjzYJB5xL81LgIR+lnR QVEsK78QpWogPpAuTX2k1xiHLXAEfXiTjD0Dph+yLcWUU4IbLkYluzduR0L78C0n7gpFHaWG8Z/W 7fVKKhJf8/8KpSMMCOwaTESbpa2p3F6ENvBKCCf5lho3iqrnBq4SNkcHSwKGf1cCrNtPXJb3Pbd4 M6sWY+Dl6ksFIwn6gUfm90OKpcGodJQ/WSl2chYgkw== =vCbt -----END PGP SIGNATURE----- --Y0QXcXgTugGoqPx0Eq7pOX3EV4o9pfd7F-- From xen-devel-bounces@lists.xenproject.org Tue Sep 07 13:54:31 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 13:54:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.181082.328067 (Exim 4.92) (envelope-from ) id 1mNbYU-0008Az-O3; Tue, 07 Sep 2021 13:54:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 181082.328067; Tue, 07 Sep 2021 13:54:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNbYU-0008As-Kg; Tue, 07 Sep 2021 13:54:30 +0000 Received: by outflank-mailman (input) for mailman id 181082; Tue, 07 Sep 2021 13:54:29 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNbYT-0008Am-EY for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 13:54:29 +0000 Received: from sender4-of-o51.zoho.com (unknown [136.143.188.51]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 1df3285e-0fe3-11ec-b0f4-12813bfff9fa; Tue, 07 Sep 2021 13:54:28 +0000 (UTC) Received: from [10.10.1.146] (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1631022862921821.2351718715845; Tue, 7 Sep 2021 06:54:22 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1df3285e-0fe3-11ec-b0f4-12813bfff9fa ARC-Seal: i=1; a=rsa-sha256; t=1631022866; cv=none; d=zohomail.com; s=zohoarc; b=V+msD7NyuKPbikIqyuZrQjlfG9rqnXRv+UdGyKeDJcplSHc4nfcPrXg9YnrP0zSY3xG1ALWZkkjuJu6mWHMqR8KTILHXpePtu4CG8Mw80Gkj0H0egAzg8pIzD7WkJSo50PihBB7va5WTgceXaBw1ZKq0j44hb57xabUKLD014zI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1631022866; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=a0yjKN4vFjwtQ5VFXF1O0n7vkyNeAOlsxBb/XzZzYrU=; b=nwnrI5t0OWMYHJN3XD5wL4rfsmMKdxs8901CSG/lgUnqfsGJPj2J7PnTa8YjPg3UU8IFd2W5lfs7/b2HVbP5eac1J2k/M3aSGoV4Wb4JNDbhsrnlUQKqO8BX/Uxx/Z5K2JhgDknLXFeZNFMBL526sv3QXu6voz81mZbd8KMrDfQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1631022866; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Subject:To:Cc:References:From:Message-ID:Date:MIME-Version:In-Reply-To:Content-Type:Content-Transfer-Encoding; bh=a0yjKN4vFjwtQ5VFXF1O0n7vkyNeAOlsxBb/XzZzYrU=; b=Ak7OYVa89Vm+TLZuIxxkztPYzwSakyThdNyxbE+XkDO9LW/NPGk/V5BgKQUrvK6c JHm5FYxP6YBQfeXW7+s/EQBLHFwoX8/IbziLo1XYXi0hR4gPIwa8uOO9VVqg+5HNtta n4qd8D62m6pmfBnBIuuCAQC24CFhwPjQeMbddEnw= Subject: Re: [PATCH v4 07/11] xsm: decouple xsm header inclusion selection To: Andrew Cooper , xen-devel@lists.xenproject.org Cc: Daniel De Graaf References: <20210903190629.11917-1-dpsmith@apertussolutions.com> <20210903190629.11917-8-dpsmith@apertussolutions.com> <17155620-d091-3205-6af0-65e19dfa1bfb@citrix.com> From: "Daniel P. Smith" Message-ID: <786e7f2c-67ce-ee44-bf98-d94772f44921@apertussolutions.com> Date: Tue, 7 Sep 2021 09:52:39 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <17155620-d091-3205-6af0-65e19dfa1bfb@citrix.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-ZohoMailClient: External On 9/6/21 2:47 PM, Andrew Cooper wrote: > On 03/09/2021 20:06, Daniel P. Smith wrote: >> diff --git a/xen/include/xsm/xsm-core.h b/xen/include/xsm/xsm-core.h >> new file mode 100644 >> index 0000000000..4555e111dc >> --- /dev/null >> +++ b/xen/include/xsm/xsm-core.h >> @@ -0,0 +1,274 @@ >> +/* >> + * This file contains the XSM hook definitions for Xen. >> + * >> + * This work is based on the LSM implementation in Linux 2.6.13.4. >> + * >> + * Author: George Coker, >> + * >> + * Contributors: Michael LeMay, >> + * >> + * This program is free software; you can redistribute it and/or modify >> + * it under the terms of the GNU General Public License version 2, >> + * as published by the Free Software Foundation. >> + */ >> + >> +#ifndef __XSM_CORE_H__ >> +#define __XSM_CORE_H__ >> + >> +#include >> +#include >> + >> +/* policy magic number (defined by XSM_MAGIC) */ >> +typedef uint32_t xsm_magic_t; >> + >> +#ifdef CONFIG_XSM_FLASK >> +#define XSM_MAGIC 0xf97cff8c >> +#else >> +#define XSM_MAGIC 0x0 >> +#endif > > Eww.  I know you're only moving code, but this construct is broken > (right from XSM's introduction in c/s d046f361dc937), and creates a > fairly-severe bug. > > It causes xsm_multiboot_policy_init() to malfunction and accept a module > which starts with 4 zeroes, rather than the flask magic number.  The one > caller is suitably guarded so this is only a latent bug right now, but I > don't think we could credibly security support the code without this > being fixed.  (Again - fine to add to the todo list.  I know there's > loads to do) I cannot in good conscience leave a clearly latent bug. Let me see if can work a safer means to handling policy module loading. >> + >> +/* These annotations are used by callers and in dummy.h to document the >> + * default actions of XSM hooks. They should be compiled out otherwise. >> + */ > > For the coding style patch, this should be > > /* >  * These ... Ack. >> +#ifdef CONFIG_XSM >> + >> +#ifdef CONFIG_MULTIBOOT >> +int xsm_multiboot_init(unsigned long *module_map, >> + const multiboot_info_t *mbi); >> +int xsm_multiboot_policy_init(unsigned long *module_map, >> + const multiboot_info_t *mbi, >> + void **policy_buffer, >> + size_t *policy_size); >> +#endif >> + >> +#ifdef CONFIG_HAS_DEVICE_TREE >> +/* >> + * Initialize XSM >> + * >> + * On success, return 1 if using SILO mode else 0. >> + */ >> +int xsm_dt_init(void); >> +int xsm_dt_policy_init(void **policy_buffer, size_t *policy_size); >> +bool has_xsm_magic(paddr_t); >> +#endif >> + >> +#ifdef CONFIG_XSM_FLASK >> +const struct xsm_ops *flask_init(const void *policy_buffer, >> + size_t policy_size); >> +#else >> +static inline const struct xsm_ops *flask_init(const void *policy_buffer, >> + size_t policy_size) >> +{ >> + return NULL; >> +} >> +#endif >> + >> +#ifdef CONFIG_XSM_SILO >> +const struct xsm_ops *silo_init(void); >> +#else >> +static const inline struct xsm_ops *silo_init(void) >> +{ >> + return NULL; >> +} >> +#endif >> + >> +#else /* CONFIG_XSM */ >> + >> +#ifdef CONFIG_MULTIBOOT >> +static inline int xsm_multiboot_init(unsigned long *module_map, >> + const multiboot_info_t *mbi) >> +{ >> + return 0; >> +} >> +#endif >> + >> +#ifdef CONFIG_HAS_DEVICE_TREE >> +static inline int xsm_dt_init(void) >> +{ >> + return 0; >> +} >> + >> +static inline bool has_xsm_magic(paddr_t start) >> +{ >> + return false; >> +} >> +#endif /* CONFIG_HAS_DEVICE_TREE */ > > Shouldn't this be an #ifndef CONFIG_HAS_DEVICE_TREE ? > > And the answer is no because of the #else /* CONFIG_XSM */ higher up, > but it is incredibly deceptive to read. > > > I think this logic would be far easier to follow as: > > #if IS_ENABLED(CONFIG_XSM) && IS_ENABLED(CONFIG_MULTIBOOT) > ... > #else > ... > #endif > > etc. > > rather than having two separate #ifdef CONFIG_MULTIBOOT blocks doing > opposite things due to the position of intermixed #ifdef CONFIG_XSM. Ack. v/r dps From xen-devel-bounces@lists.xenproject.org Tue Sep 07 14:02:43 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 14:02:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.181090.328079 (Exim 4.92) (envelope-from ) id 1mNbgN-0001ek-Mz; Tue, 07 Sep 2021 14:02:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 181090.328079; Tue, 07 Sep 2021 14:02:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNbgN-0001ed-Jg; Tue, 07 Sep 2021 14:02:39 +0000 Received: by outflank-mailman (input) for mailman id 181090; Tue, 07 Sep 2021 14:02:37 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNbgL-0001eX-JK for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 14:02:37 +0000 Received: from sender4-of-o51.zoho.com (unknown [136.143.188.51]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 4021a5a9-0fe4-11ec-b0f5-12813bfff9fa; Tue, 07 Sep 2021 14:02:36 +0000 (UTC) Received: from [10.10.1.146] (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1631023350916797.7635160563889; Tue, 7 Sep 2021 07:02:30 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4021a5a9-0fe4-11ec-b0f5-12813bfff9fa ARC-Seal: i=1; a=rsa-sha256; t=1631023353; cv=none; d=zohomail.com; s=zohoarc; b=guLKaRb7pEXs6IvRpXDUHthw78iVpWi9KMcWoCdAQtd0K27y9wSn2xwU+YtwYdaJYxegxbBaGtEuE8maOgIb9eF+CYzrKH5tF8czrIV74mNx7vYAiBl7rmLhES6XFlJuqRJHifsPcPFIK+PPrpb1WT4OequkCIf/oQvq/OpnJk0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1631023353; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=9gom1ql8ae5NoV/h/dFHGpp6IOjAPFwXRoaCwPNyKHY=; b=Ryir5TWDAdMIW6Hed3D6Tto3pPa2caSMeEuNlyhUgH/sUpM9RZnIAMUmY3e9DZbFTpYk6acRzQN5gWNJe0LgnIvlBmQO9bbmdj+w160fyFnbIrGaqflU9Mc9DMCF4/w8FG5TABY3/rnBRdLCAkwX1OqjeYkgrWuix3ycbjRMxA4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1631023353; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Subject:To:Cc:References:From:Message-ID:Date:MIME-Version:In-Reply-To:Content-Type:Content-Transfer-Encoding; bh=9gom1ql8ae5NoV/h/dFHGpp6IOjAPFwXRoaCwPNyKHY=; b=SEcyi00ox7hQx1Q6b539rpNUYrC+0QIR9R324xlHYNdvffgW7J0Wdc3UYXptjHlh fhGe+Jx8+rpkcptvj+N3vm/wCbf9kqkxo4+xz3zzuJNmLKBn5ZkBBFr6KBnteuW99Gj cWGu0dD26swHy4U0OnKa2aLoAlLbkBpyx2zZ006c= Subject: Re: [PATCH v4 09/11] silo: remove circular xsm hook call To: Andrew Cooper , xen-devel@lists.xenproject.org Cc: Daniel De Graaf References: <20210903190629.11917-1-dpsmith@apertussolutions.com> <20210903190629.11917-10-dpsmith@apertussolutions.com> From: "Daniel P. Smith" Message-ID: <997db7f6-266d-b488-4024-37d9adeb4ceb@apertussolutions.com> Date: Tue, 7 Sep 2021 10:00:47 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-ZohoMailClient: External On 9/6/21 2:55 PM, Andrew Cooper wrote: > On 03/09/2021 20:06, Daniel P. Smith wrote: >> SILO implements a few XSM hooks to extended the decision logic beyond >> what is defined in the dummy/default policy. For each of the hooks, it >> falls back to the dummy/default policy. The fall back is done a slight >> round-about way. > > "done in a slightly" ? Ack. >> This commit makes the direct call to the default policy's >> logic, xsm_default_action(). >> >> Signed-off-by: Daniel P. Smith >> --- >> xen/xsm/silo.c | 15 ++++++++------- >> 1 file changed, 8 insertions(+), 7 deletions(-) >> >> diff --git a/xen/xsm/silo.c b/xen/xsm/silo.c >> index 6db793f35c..56a330a831 100644 >> --- a/xen/xsm/silo.c >> +++ b/xen/xsm/silo.c >> @@ -17,6 +17,7 @@ >> * You should have received a copy of the GNU General Public License along with >> * this program; If not, see . >> */ >> +#include >> #include >> >> /* >> @@ -43,7 +44,7 @@ static int silo_evtchn_unbound(struct domain *d1, struct evtchn *chn, >> else >> { >> if ( silo_mode_dom_check(d1, d2) ) >> - rc = xsm_evtchn_unbound(d1, chn, id2); >> + rc = xsm_default_action(XSM_TARGET, current->domain, d1); >> rcu_unlock_domain(d2); >> } >> >> @@ -54,7 +55,7 @@ static int silo_evtchn_interdomain(struct domain *d1, struct evtchn *chan1, >> struct domain *d2, struct evtchn *chan2) >> { >> if ( silo_mode_dom_check(d1, d2) ) >> - return xsm_evtchn_interdomain(d1, chan1, d2, chan2); >> + return xsm_default_action(XSM_HOOK, d1, d2); >> return -EPERM; >> } >> >> @@ -62,21 +63,21 @@ static int silo_grant_mapref(struct domain *d1, struct domain *d2, >> uint32_t flags) >> { >> if ( silo_mode_dom_check(d1, d2) ) >> - return xsm_grant_mapref(d1, d2, flags); >> + return xsm_default_action(XSM_HOOK, d1, d2); >> return -EPERM; >> } >> >> static int silo_grant_transfer(struct domain *d1, struct domain *d2) >> { >> if ( silo_mode_dom_check(d1, d2) ) >> - return xsm_grant_transfer(d1, d2); >> + return xsm_default_action(XSM_HOOK, d1, d2); >> return -EPERM; >> } >> >> static int silo_grant_copy(struct domain *d1, struct domain *d2) >> { >> if ( silo_mode_dom_check(d1, d2) ) >> - return xsm_grant_copy(d1, d2); >> + return xsm_default_action(XSM_HOOK, d1, d2); >> return -EPERM; >> } >> >> @@ -86,14 +87,14 @@ static int silo_argo_register_single_source(const struct domain *d1, >> const struct domain *d2) >> { >> if ( silo_mode_dom_check(d1, d2) ) >> - return xsm_argo_register_single_source(d1, d2); >> + return 0; >> return -EPERM; >> } >> >> static int silo_argo_send(const struct domain *d1, const struct domain *d2) >> { >> if ( silo_mode_dom_check(d1, d2) ) >> - return xsm_argo_send(d1, d2); >> + return 0; > > Shouldn't these be XSM_HOOK too?  Or should all other XSM_HOOK's be > short-circuted to 0? > > The asymmetry here seems weird. It makes more sense when you follow the approach, which was to duplicate the body of the dummy hook instead of making a call to the hook which would then call the function pointer to the dummy hook. The definition for the argo dummy hooks is to return 0. In the future these other calls may well have XSM_HOOk replaced with the proper role expected. Since all argo checks just return 0, this reflects there is no logic rules in xsm_default_action to determine argo accesses. Of course this is on my list todo and when the dummy hook is fixed, these would be synchronized. With that said, converting over to XSM_HOOK does provide the equivalent and would provide consistency within the context of this file. Basically a long winded way of saying, ack. v/r, dps From xen-devel-bounces@lists.xenproject.org Tue Sep 07 14:05:22 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 14:05:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.181096.328090 (Exim 4.92) (envelope-from ) id 1mNbit-0002GB-6w; Tue, 07 Sep 2021 14:05:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 181096.328090; Tue, 07 Sep 2021 14:05:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNbit-0002G4-2F; Tue, 07 Sep 2021 14:05:15 +0000 Received: by outflank-mailman (input) for mailman id 181096; Tue, 07 Sep 2021 14:05:14 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNbis-0002Fw-CW for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 14:05:14 +0000 Received: from sender4-of-o51.zoho.com (unknown [136.143.188.51]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 3dfa05ba-0966-4b85-aa69-e27de524392b; Tue, 07 Sep 2021 14:05:13 +0000 (UTC) Received: from [10.10.1.146] (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1631023508010397.42168302385335; Tue, 7 Sep 2021 07:05:08 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3dfa05ba-0966-4b85-aa69-e27de524392b ARC-Seal: i=1; a=rsa-sha256; t=1631023510; cv=none; d=zohomail.com; s=zohoarc; b=DwVlQ8X2gwzBmofhZa0/mLTHPEFlZjcMnPjguUG6rAl52TJYQ1DLpmpEN4Ye3zovYIVKjdpMMPeR/11Jooh2ZCky0kTwuOA7fLDtb0UxS0OvMNfhl3ZEKekUxESMEy2Hcw3UbKGp2A/N3JCQFEPGps51Pdc8c47dltQNpke+uNQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1631023510; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=GDLLgnfggnonVh83Z26KWmFNzxC2njX3v4Ulq7RK37o=; b=El0mEU8QogFCmZvWlx5baQjQITtDhMYQ7QHP4OE9zDsttTahbauYGL8F4CaYbCGmib63Ls8TT2zIth7ENcepYPUuE3ikClAet8G3ExM51JFJuse8/ko6RnXdpG6oYo6RX+shc8qIdRAhgsUzy6b9ZOepqW2t+RUhYkq0IhtVYPY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1631023510; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Subject:To:Cc:References:From:Message-ID:Date:MIME-Version:In-Reply-To:Content-Type:Content-Transfer-Encoding; bh=GDLLgnfggnonVh83Z26KWmFNzxC2njX3v4Ulq7RK37o=; b=A33lDEdZgYvISMA48FhQDSKaPy+eJmF6V4PbzsRsIYW/o2EO+iEOiYzbdhCSUSPB 9GQiVlBCUxKTqpOi5+J1DC9VY28YrsVNaN4ayE0Mnn2dYuqgwIO4o89sqPA/aZXtVpQ DwPWvlaHIciSfItuSpYk55W6BJRLUlMNJ/OlYZMA= Subject: Re: [PATCH v4 11/11] xsm: remove alternate xsm hook interface To: Andrew Cooper , xen-devel@lists.xenproject.org Cc: Daniel De Graaf References: <20210903190629.11917-1-dpsmith@apertussolutions.com> <20210903190629.11917-12-dpsmith@apertussolutions.com> From: "Daniel P. Smith" Message-ID: Date: Tue, 7 Sep 2021 10:03:24 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-ZohoMailClient: External On 9/6/21 3:18 PM, Andrew Cooper wrote: > On 03/09/2021 20:06, Daniel P. Smith wrote: >> -static inline int xsm_memtype(xsm_default_t def, uint32_t access) >> +#if 0 >> +/* Could not find any usages */ >> +static inline int xsm_memtype(xsm_default_t action, uint32_t access) >> { >> return alternative_call(xsm_ops.memtype, access); >> } >> +#endif > > There wants to be an earlier patch deleting dead code.  We don't want to > retain this if-0'd out. I can transition this to a standalone patch at the beginning to drop the benign code. >> diff --git a/xen/xsm/dummy.h b/xen/xsm/dummy.h >> new file mode 100644 >> index 0000000000..b9a7e8c40f >> --- /dev/null >> +++ b/xen/xsm/dummy.h >> @@ -0,0 +1,739 @@ >> +/* >> + * Default XSM hooks - IS_PRIV and IS_PRIV_FOR checks >> + * >> + * Author: Daniel De Graaf >> + * >> + * This program is free software; you can redistribute it and/or modify >> + * it under the terms of the GNU General Public License version 2, >> + * as published by the Free Software Foundation. >> + * >> + * >> + * Dummy XSM hooks implementing the default access check. Each hook should >> + * have as its first line XSM_DEFAULT_ACTION declaring the privilege level >> + * required for this access. >> + */ >> + >> +#ifndef __XSM_DUMMY_H__ >> +#define __XSM_DUMMY_H__ >> + >> +#include >> +#include >> +#include >> + >> +#define XSM_DEFAULT_ACTION(def) xsm_default_t action = def; (void)action >> + >> +static always_inline int xsm_default_action( >> + xsm_default_t action, struct domain *src, struct domain *target) >> +{ >> + switch ( action ) { > > Either here (because you're moving code), or in the style fix, the brace > wants to be on the next line. I will promote to the style patch and carry it through the move. v/r, dps From xen-devel-bounces@lists.xenproject.org Tue Sep 07 14:11:10 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 14:11:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.181102.328100 (Exim 4.92) (envelope-from ) id 1mNboX-0003yv-Op; Tue, 07 Sep 2021 14:11:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 181102.328100; Tue, 07 Sep 2021 14:11:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNboX-0003yo-Lz; Tue, 07 Sep 2021 14:11:05 +0000 Received: by outflank-mailman (input) for mailman id 181102; Tue, 07 Sep 2021 14:11:05 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNboX-0003yB-0N for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 14:11:05 +0000 Received: from sender4-of-o51.zoho.com (unknown [136.143.188.51]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 6f5131f8-0fe5-11ec-b0f7-12813bfff9fa; Tue, 07 Sep 2021 14:11:03 +0000 (UTC) Received: from [10.10.1.146] (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1631023856310111.27960753270997; Tue, 7 Sep 2021 07:10:56 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6f5131f8-0fe5-11ec-b0f7-12813bfff9fa ARC-Seal: i=1; a=rsa-sha256; t=1631023862; cv=none; d=zohomail.com; s=zohoarc; b=ZIL3ngtVoMCpENgJBqG6qOYrPmBTvfSmYGYT8jlTyBVe8U2ePx8VpgTasGI+kphTyo4ro3Il8mVA8m6ez/s80TvKrK614WL/ZUI/HKh2S85c4HvHwoMOzUSpPQhNzABkd/WhlXwatH46GTnzC3eWVUO6e/GsThtIq1msUG070ZI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1631023862; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=NGknd/JHTSfyOh9tzQSO+4h9Q2/QFArTITRMaNAFEqs=; b=juQWA93l5PqfG068ROI0otQkMXrRjgB8gNMUnU4plSFOI4dXmW56aGY0hvNbzE0wS/nrJFbdyX7Vt6+Aw8zmt2TYypHCDpn4ObYFj+Ix1GgQNuSZl8E+NErq8UMTHcGgThucIUq71++r2ukwk8JUaj6RvLeiYbcTCTewYAug3Ng= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1631023862; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Subject:To:Cc:References:From:Message-ID:Date:MIME-Version:In-Reply-To:Content-Type:Content-Transfer-Encoding; bh=NGknd/JHTSfyOh9tzQSO+4h9Q2/QFArTITRMaNAFEqs=; b=YN/QLhcL3Nc6dl9z2F4ist/Z89bUslpmyQsNTr9ThNnXJWdTCnwGoegR7X53Vldg D0il3JmNEi24FeIUgCNzRkkhAkhS3prydd1OidjJ9P3HtUpkXWUHdG3PEFgbUo98fFY V9D8alPvzuhb8oiNQdHzhdqo0IqkVgB4p17VhR4w= Subject: Re: [PATCH v4 04/11] xsm: apply coding style To: Jan Beulich Cc: Daniel De Graaf , Andrew Cooper , xen-devel@lists.xenproject.org References: <20210903190629.11917-1-dpsmith@apertussolutions.com> <20210903190629.11917-5-dpsmith@apertussolutions.com> <01c81885-9ea0-3ecf-66b0-009b9e7ba39b@citrix.com> From: "Daniel P. Smith" Message-ID: <3b3762a7-5034-9094-84f9-cd8ab24e24a0@apertussolutions.com> Date: Tue, 7 Sep 2021 10:09:12 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-ZohoMailClient: External On 9/7/21 9:50 AM, Jan Beulich wrote: > On 07.09.2021 15:41, Daniel P. Smith wrote: >> On 9/6/21 2:17 PM, Andrew Cooper wrote: >>> On 03/09/2021 20:06, Daniel P. Smith wrote: >>>> --- a/xen/include/xsm/dummy.h >>>> +++ b/xen/include/xsm/dummy.h >>>> @@ -69,8 +69,9 @@ void __xsm_action_mismatch_detected(void); >>>> >>>> #endif /* CONFIG_XSM */ >>>> >>>> -static always_inline int xsm_default_action( >>>> - xsm_default_t action, struct domain *src, struct domain *target) >>>> +static always_inline int xsm_default_action(xsm_default_t action, >>>> + struct domain *src, >>>> + struct domain *target) >>> >>> The old code is correct.  We have plenty of examples of this in Xen, and >>> I have been adding new ones when appropriate. >>> >>> It avoids squashing everything on the RHS and ballooning the line count >>> to compensate.  (This isn't a particularly bad example, but we've had >>> worse cases in the past). >> >> Based on the past discussions I understood either is acceptable and find >> this version much easier to visually parse myself. With that said, if >> the "next line single indent" really is the preferred style by the >> maintainers/community, then I can convert all of these over. > > I guess neither is the "preferred" style; as Andrew says, both are > acceptable and both are in active use. I guess the rule of thumb is: > The longer what's left of the function name, the more you should > consider the style that you change away from. > > Anyway, in the end I guess the request for style adjustments was > mainly to purge bad style, not to convert one acceptable form to > another. Converting the entire file to the same style is of course > fine (for producing a consistent result), but then - as per above - > here it would more likely be the one that in this case was already > there. Understood, I will respin with all the function defs to align with the "next line single indent" style, though it would be helpful for clarification on this style exactly. Do you always wrap all args if one extends past 80 col or is there a rule for when some should remain on the first line (function def line)? v/r, dps From xen-devel-bounces@lists.xenproject.org Tue Sep 07 14:18:50 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 14:18:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.181109.328112 (Exim 4.92) (envelope-from ) id 1mNbvv-0004gM-Ia; Tue, 07 Sep 2021 14:18:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 181109.328112; Tue, 07 Sep 2021 14:18:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNbvv-0004gF-FU; Tue, 07 Sep 2021 14:18:43 +0000 Received: by outflank-mailman (input) for mailman id 181109; Tue, 07 Sep 2021 14:18:42 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNbvu-0004g9-3O for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 14:18:42 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNbvq-0005oi-JY; Tue, 07 Sep 2021 14:18:38 +0000 Received: from [54.239.6.187] (helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1mNbvq-0004tO-BP; Tue, 07 Sep 2021 14:18:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=BgwjwoRffSORjuYOIjYU6JiyDgimHWexiXbdlk6/CCE=; b=Pb8RniQnpbLpN97SzuDt6ciO/l lubmC3unY3XmmqFTaEZxpWMyJGXMpli5q7YLSDM9oGZE+plZljbzEOSkoNes38vSyMu2sGA0eYmRt LeQHFZI22xfQhcj42iSW/Tt7WQuyDU4tSDANhYqRDmbtVZGtxX17SYOCqckme8LApoCE=; Subject: Re: [RFC PATCH] xen/design: Add design for EFI dom0less system start To: Luca Fancellu Cc: xen-devel@lists.xenproject.org, Bertrand Marquis , wei.chen@arm.com, Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Stefano Stabellini , Wei Liu References: <20210907065228.21794-1-luca.fancellu@arm.com> <4bab7902-0268-5705-5462-fcd7571d7492@xen.org> <7BD59287-75ED-4D4F-B892-F6B04583A986@arm.com> <1efbd9a8-232b-b267-fa8e-7f5f1af7cfed@xen.org> <5DA71CEF-0ADE-4846-A7BC-B378B95A38AD@arm.com> From: Julien Grall Message-ID: <910f2758-cbce-53b0-4e57-4b2a966ce2b3@xen.org> Date: Tue, 7 Sep 2021 15:18:35 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <5DA71CEF-0ADE-4846-A7BC-B378B95A38AD@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit Hi Luca, On 07/09/2021 14:30, Luca Fancellu wrote: >> On 7 Sep 2021, at 13:30, Julien Grall wrote: >> On 07/09/2021 12:51, Luca Fancellu wrote: >>>> On 7 Sep 2021, at 10:35, Julien Grall wrote: >>>> What we could do is providing a list of binaries to load and associate a key for each of them. Something like: >>>> >>>> binary= >>>> binary= >>>> .... >>>> >>>> We can then replace the property "reg" with a new property "uefi,key" that will contain the name of the binary. >>>> >>>> What do you think? >>> Here I’m lost, because I don’t understand what we are going to do with the name of the binary. >> >> would be used by the UEFI stub to load the binary in memory. Each binary will have a which helps to refer them in the Device-Tree. To give a concrete example, let say we have two dom0less domains: >> - DomA: 2 vCPUs, 128MB >> - DomB: 3 vCPUs, 512MB >> >> DomA and DomB will be using the same kernel but a different ramdisk. xen.cfg, would look like: >> >> [global] >> default=section1 >> >> [section1] >> options=console=vga,com1 com1=57600 loglvl=all noreboot >> kernel=vmlinuz-3.0.31-0.4-xen [domain 0 command line options] >> ramdisk=initrd-3.0.31-0.4-xen >> xsm= >> dtb=devtree.dtb >> binary=vmlinuz-guest domu-kernel >> binary=ramdisk-domA.img domA-ramdisk >> binary=ramdisk-domB.img domB-ramdisk >> >> The chosen node in the DT would look like: >> >> chosen { >> domU1 { >> compatible = "xen,domain"; >> #address-cells = <0x2>; >> #size-cells = <0x1>; >> memory = <0 0x8000000>; >> cpus = <2>; >> >> module@1 { >> compatible = "multiboot,kernel", "multiboot,module"; >> uefi,binary = "domu-kernel"; >> bootargs = "console=ttyAMA0 init=/bin/sh"; >> }; >> >> module@2 { >> compatible = "multiboot,ramdisk", "multiboot,module"; >> uefi,binary = "domA-ramdisk"; >> }; >> }; >> >> domU2 { >> compatible = "xen,domain"; >> #address-cells = <0x3>; >> #size-cells = <0x1>; >> memory = <0 0x20000000>; >> cpus = <3>; >> >> module@1 { >> compatible = "multiboot,kernel", "multiboot,module"; >> uefi,binary = "domu-kernel"; >> bootargs = "console=ttyAMA0 init=/bin/sh"; >> }; >> >> module@2 { >> compatible = "multiboot,ramdisk", "multiboot,module"; >> uefi,binary = "domA-ramdisk"; >> }; >> }; >> }; >> >> With this approach, the change is quite minimal to move between an classic U-boot boot and EFI boot. > > Ok now I see, yes this approach can work and can save some code, in the current code we have that if > a "multiboot,module” is found in the dtb, the Xen EFI configuration file is skipped, but if we use the > module@XX {} without the compatible it can work, the UEFI stub will load the binary and update all > the needed properties (compatible, reg). With my proposal, you don't know whether the binary is a kernel, ramdisk... So you wouldn't be able to recreate the compatible properly. But the behavior of the UEFI stub can be modified. We could say that if there is a "xen,domain" then use the configuration file to fetch the binaries. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Sep 07 14:21:14 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 14:21:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.181115.328123 (Exim 4.92) (envelope-from ) id 1mNbyL-0006LY-Vk; Tue, 07 Sep 2021 14:21:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 181115.328123; Tue, 07 Sep 2021 14:21:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNbyL-0006LR-Sf; Tue, 07 Sep 2021 14:21:13 +0000 Received: by outflank-mailman (input) for mailman id 181115; Tue, 07 Sep 2021 14:21:12 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNbyK-0006LD-Mt for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 14:21:12 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id d977dc7a-0fe6-11ec-b0fa-12813bfff9fa; Tue, 07 Sep 2021 14:21:11 +0000 (UTC) Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-am5eur03lp2051.outbound.protection.outlook.com [104.47.8.51]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-30-o8JIptTZNTWFw-2IS7wz3Q-1; Tue, 07 Sep 2021 16:21:09 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14; Tue, 7 Sep 2021 14:21:08 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4500.014; Tue, 7 Sep 2021 14:21:08 +0000 Received: from [10.156.60.236] (37.24.206.209) by PR3P195CA0001.EURP195.PROD.OUTLOOK.COM (2603:10a6:102:b6::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Tue, 7 Sep 2021 14:21:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d977dc7a-0fe6-11ec-b0fa-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1631024470; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=A6mkUxjwYk+rRPjoLLQldea3GJY3g6bYT4edMm8ZTHk=; b=HmEthlFO9fAqdmLBBWlIMEgUJ0OvYjVpC9SGryDq9eDLbY8Fbyps8YnWgaTqDUl6D6Hbw8 ygBmnkCo5JpcFc0k9odQHpd5v+POmcs7XObWC5yms+CJ7PgeddipeajHs/fzs4SP9tWCtn OAsTVNVf5ZRg19QR3wn+QxyfGLzJYnQ= X-MC-Unique: o8JIptTZNTWFw-2IS7wz3Q-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Yv87STg/suGEq/VSd+mw1aoRMgB1MsR7j8xQf/aEsaa4wkVX+Tu6E3+aS+1qzEop+F5OijtmNGu+DyMABjdctWjpzS4hZ7go5JqhQKzIYJbcOScHxf0hsUsrLOpQtVEEw9HDnukPQ9ODyicHxEU7ZKJGjT4lkivFUm1YS9Ixtlr/jMZpGd4U/7cUw+HOjHZ+k16l8BGb2ix40IfRXWRlMAS2V+NzK8oSrJOg9icHKIWoe8+6pxIOdyFlY4Z9L2E5i7RWqmESOzua+naTGX6k1JCEEc/sZNUzm5l2Zy/PGKOrPsU9qElIEXFqSQbp1AOwrSvwa8idA7o2mBuCcJswPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=5P2vnTU15/bPw9O+/l2UDZyNPfbD2qOdV5IDyfmhzB0=; b=RXaLOf249NjrhE4i9FmD1QcV7EpsN/iFl+wgTEA52wFwQu9nrPqHpkwFvstUs5UgDVKI6DDmScHemMEhPyepcM5IGbPnJkQvlAw+q5k8H/XQXr3ja8QZWk557sFGsisgbQsfPG3505MhYVjx04NXOvlXKk3Ybpst+ACDhvpUfWyimEc6/xFW+qcvGYPGf858JNz93MAIGtY+2aRzV8r/i7Gcnn6yxNEl0uYtgTWZuaFKt1O2RLO/P26E8YUDpgOf0EYVfuMCqIFSFwtumguYzgazuixGSf9uRthVYpgz/bpzk+ary/QwX3n7fmrlDyTSY3wMuiwdtKnd0POH8D5RZA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: citrix.com; dkim=none (message not signed) header.d=none;citrix.com; dmarc=none action=none header.from=suse.com; Subject: Re: [PATCH v1 2/2] x86/cpuid: Detect null segment behaviour on Zen2 CPUs To: Andrew Cooper CC: Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Pu Wen , Andy Lutomirski , Xen-devel , Jane Malalane References: <26b88d5a-ae6f-0065-7c3f-5eeb6dd80078@suse.com> <2972c71a-5fed-0813-8ec0-d179eacff14d@citrix.com> <70f376c6-eef2-42ce-a8eb-67c1130a41e4@suse.com> From: Jan Beulich Message-ID: <1076b12b-dbbd-f1cc-4d78-511122f02b99@suse.com> Date: Tue, 7 Sep 2021 16:21:05 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: PR3P195CA0001.EURP195.PROD.OUTLOOK.COM (2603:10a6:102:b6::6) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b6f31afb-8ae4-439e-2067-08d9720abbf2 X-MS-TrafficTypeDiagnostic: VI1PR04MB5600: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: kNEg1fcaAdxyWoNstaE4kHU27kb2AgLmx7yQFVOgj2Eqdxfck4ZgC9bpzpq42dACwkWohwzJcSj5InGc0nV0KOSXZHTp5FY3wnoeeDfJDkkteNrgLaDefMIvyaVuU2RSYX35FCQJk6UmpP6rzWZzas0I05AFpHGbP4zaulN8wIRE3vSM3wV2UNd0Ue2VHU1I3hh+uBRjJPfFAs9dP/udjviLvGtfqSeh4jr6z5nubbvOKMdi1TW7f/BQUJLXX8Ds4EGB627M9n4J0uX+KWObyZOUgxtiT8ohnqLcz3m5gsmVgPlKEYIFFvzmoIIqhzWOlrsAl2VKeXbO1XWtaKvFSS4dv6lXIBXCPva/FVJzOP7QUVuo11lZyUhsAwAOJRS4fkEvf/ur4Cb1He0H0bkmf6Svcnoi6ZxRYfXdHuRwbb2XKRjgrTPP80T1lWHXmiJ+JS20jDI5607DuasTbwyfWOGc8vmo8tECdZcK/oObe8S+lu0ixvelF4GqPf8qVCz/Ky+nml7XjJf2V2+jOOM3kw4N3HWYX1GgHUbGunrN/Ks2M4ZUp33tqX5gmWrp1i0C17/ZPrcayuinjDdxGAr4JForMTBonTQbY/TzdGaTIYjz2ZFANBQlhEBc7tml5BVCElhYhF/GSrsiv+QEj2JtSU2vjJfoZAIg/VZg4gLpI4IzfWUVQ4mNDMWIdObk0fKv/WZg/IexEF0XkniDsOxAfA0YiuPOz2hC3Q6vLmX52u/xiv+xZ4Mzy1Qn9c7XsAPU X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(956004)(54906003)(316002)(8936002)(2616005)(16576012)(4326008)(53546011)(86362001)(66476007)(38100700002)(66556008)(31686004)(5660300002)(66946007)(26005)(6486002)(6916009)(186003)(8676002)(31696002)(83380400001)(36756003)(508600001)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?lt0+ED7xobip3EtLHRqaIHZvtFbkefATb5/TGfMrNgTeFIRYj2nVY71y93qn?= =?us-ascii?Q?f9uS6LL5+N5d1GK624li3mhv7qGKt6ddb9IwEtSsyRfxVVtSZ37qcRuacRVB?= =?us-ascii?Q?eldBc4LMazq1+j8CQ5+puuiJ20awtHn7TqDV+ZFvTw6LFQA19Adj54TVPp3j?= =?us-ascii?Q?o+21J5Q61EqEs7n0Y4+UvrLCGLwq9JIcduJp8Sd1ujCoBr1wA9gBRWvx/B26?= =?us-ascii?Q?1hoOe/V9fsAF3wR5N40hyZCNA9laijSNejYTziME34/nyJSAsDNtAhjhKXfZ?= =?us-ascii?Q?ILtLp8L7XWnFXkRATy9bNmn7YCVcKCj0e7pyGWeQKk7TmwhntUBEGth9jRgx?= =?us-ascii?Q?H+CZWjx1GLjIibGAcc2W61p3j+MvO0a6JrvtbRyE4KMzbKoQHnxfS68cLF85?= =?us-ascii?Q?oODc++IckvK5A/pYxjjKWrDLrdczkJMz2jjWhibGWUbDXjAcaBytgT3kFZ8c?= =?us-ascii?Q?o0LVNeYLdVfeslqf6NXnh0ph7XOc/kO4GB7iZLvoE/l+ZScXhMUj3BtZ882u?= =?us-ascii?Q?DDg+UH31RVVg9yDvh+aO93ChtoTsmHN32NvIyOMls4rlS1F0oSlikNyenV5H?= =?us-ascii?Q?+1GvlMacXMcJIPjw9f6fRKaG7hQTC9Y7s0lahOqhHhd7yU+Ih7xuORB9voxh?= =?us-ascii?Q?MB6nzziUvlSNPNTK+AMCOGKL2ZB2hrKW0NR9uMUhkJerJxgQ6eTLJ3FjcWxK?= =?us-ascii?Q?pKiICT/urkeZAFY7s/NMMNMZEaNhug3RYN4oGffF9aFlu0ljFsDowfKSIl5p?= =?us-ascii?Q?huaPpfR1baiwTRtqTRjrfb83AbNxSqUPzV0iox7HaLTbHBMBWw1Y72E/pZUZ?= =?us-ascii?Q?6LigD56qdWDl78+UzDYTpJaMgqIkQAuodH49bCxFkeY01kc0r71bIcszGfit?= =?us-ascii?Q?7/GU3CeDNE/r1Okegwvf0wgDZ512IpCnWKmaYuVt7jCIFdpMHQT3uxdYXhGF?= =?us-ascii?Q?eCAJT8iXL07Wco1L9k8v1h+3QxHHoeyc58b6HiVsaotLr6KsKKGYJsGUQAvn?= =?us-ascii?Q?7L3m8oicMTlM21EuxY+JFm2GDGCmjj5oKu9lRUotD0l/YXWx1JbHQBNP9ed8?= =?us-ascii?Q?UR+cMTx72Ad2VVI1e4K48b/FxI72HETo6zn+yyFfXJbsT5Dr0yDrvasCGLb6?= =?us-ascii?Q?qdINQh9wvjSY96mtaATe0cYPtIn08GEcvyLMGlBoRCq274fOijDh7O/n1565?= =?us-ascii?Q?AWJMs3tX3ZHU02iu9RGvzvRexBHojKOQryQmkX3KDmj1Nkfg7MUXj8nWzbpA?= =?us-ascii?Q?ZM3B5SHU74KtCzc0jSqUDZTgRCoiwOAmltreFWaPIkrtfngYp8npD7+lqRbC?= =?us-ascii?Q?uSwDGr7Td8u2zkuBWyioeIhI?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: b6f31afb-8ae4-439e-2067-08d9720abbf2 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2021 14:21:07.9731 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: FKQZTtM7zK6vRRgi0XH7IYsVJkmeDsz94TFoej2/yp2//XooVP4YoClJhYQ3p3uEKY3RQi08oCDohgzoSopQ9Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5600 On 07.09.2021 15:27, Andrew Cooper wrote: > On 07/09/2021 07:09, Jan Beulich wrote: >> On 06.09.2021 20:07, Andrew Cooper wrote: >>> On 06/09/2021 16:17, Jan Beulich wrote: >>>> On 06.09.2021 14:00, Jane Malalane wrote: >>>>> --- a/xen/arch/x86/cpu/amd.c >>>>> +++ b/xen/arch/x86/cpu/amd.c >>>>> @@ -681,6 +681,19 @@ void amd_init_lfence(struct cpuinfo_x86 *c) >>>>> c->x86_capability); >>>>> } >>>>> =20 >>>>> +void detect_zen2_null_seg_behaviour(void) >>>> This can in principle be marked __init. >>>> >>>>> +{ >>>>> + uint64_t base; >>>>> + >>>>> + wrmsrl(MSR_FS_BASE, 1); >>>>> + asm volatile ( "mov %0, %%fs" :: "rm" (0) ); >>>> While I don't strictly mind the "m" part of the constraint to remain >>>> there (in the hope for compilers actually to support this), iirc it's >>>> not useful to have when the value is a constant: Last time I checked, >>>> the compiler would not instantiate an anonymous (stack) variable to >>>> fulfill this constraint (as can be seen when dropping the "r" part of >>>> the constraint). >>> This is "rm" because it is what we use elsewhere in Xen for selectors, >>> and because it is the correct constraints based on the legal instructio= n >>> encodings. >> grep-ing for "%%[defgs]s" reveals: >> >> efi_arch_post_exit_boot(), svm_ctxt_switch_to(), >=20 > These are writing multiple selectors in one go, and a register > constraint is the only sane option. >=20 >> and do_set_segment_base() all use just "r". >=20 > I had missed this one. >=20 >> This grep has not produced >> any use of "rm". What are you talking about? >=20 > TRY_LOAD_SEG(), pv_emul_read_descriptor() for both lar and lsl, > do_double_fault() for another lsl, lldt(), ltr(). TRY_LOAD_SEG() and pv_emul_read_descriptor() don't pass constants as asm() argument values. do_double_fault()'s use of lsl is indeed an example matching the pattern here. lldt() and ltr() are generic inline helpers, so validly allow for both because they should not make assumptions on what the caller passes. Plus "m" there is okay, because if the caller passes a constant there will be a named variable (the function parameter), i.e. the compiler does not need to instantiate any anonymous one. > So ok - not everything, but most. >=20 >> >>> If you want to work around what you perceive to be bugs in compilers >>> then submit a independent change yourself. >> I don't perceive this as a bug; perhaps a desirable feature. I also >> did start my response with "While I don't strictly mind the "m" >> part ..." - was this not careful enough to indicate I'm not going >> to insist on the change, but I'd prefer it to be made? >=20 > No, because a maintainer saying "I'd prefer this to be changed" is still > an instruction to the submitter to make the change. It was a request to _consider_ dropping the m part, yes. But (see below) now that you've forced me to re-check (I presume you didn't check yourself, or else I would expect you would have drawn the same conclusion as I did), I actually feel stronger about this needing adjustment. > But the request is inappropriate.=C2=A0 "Last time I checked, the compile= r > would" presumably means you've checked GCC and not Clang, and therefore > any conclusions about the behaviour are incomplete. Not really, no. IIRC I did check the version of clang that I have easy access to. (For gcc I've just now re-checked with 10.x and 11.x.) > Unless there is a real concrete compiler bug to work around, "rm" is the > appropriate constraint to use, all other things being equal.=C2=A0 If the > complier is merely doing something dumb with the flexibility it has been > permitted, then fix the compiler and the problem will resolve itself the > proper way. I disagree. When an asm() constraint permits multiple kinds of values, dropping one or more of the alternatives should IMO still yield valid (perhaps sub-optimal) code (IOW every one of the supplied kinds should be valid). The issue here is that it is not spelled out clearly whether something like "m" (0) is actually legal. The error messages, however, suggest this is intended to be illegal: gcc says "memory input ... is not directly addressable", whereas clang says "invalid lvalue in asm input for constraint 'm'". IOW I do think the one case of LSL in do_double_fault() does need adjusting. Jan From xen-devel-bounces@lists.xenproject.org Tue Sep 07 14:22:33 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 14:22:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.181122.328134 (Exim 4.92) (envelope-from ) id 1mNbzd-00072N-G2; Tue, 07 Sep 2021 14:22:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 181122.328134; Tue, 07 Sep 2021 14:22:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNbzd-00072G-CI; Tue, 07 Sep 2021 14:22:33 +0000 Received: by outflank-mailman (input) for mailman id 181122; Tue, 07 Sep 2021 14:22:31 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNbzb-000720-I5 for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 14:22:31 +0000 Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 3002f295-b139-440b-a5a1-88b580df7c90; Tue, 07 Sep 2021 14:22:30 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3002f295-b139-440b-a5a1-88b580df7c90 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1631024550; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=4JdChk7sqL2oApxqAlGiteoD3KNkhWtQhRpFCQ+N8VY=; b=H+mQnH5zu+/L9vKU+6lfbId3r2y53eivyzp6AbYJKTWgr8Ussxld8ED4 6eCCW2BBB5xNXbz/Fcy4FnG2YS6I5a0ZBJECpAV93mXy0M0PbFjPX9JRC FPwcsWv6soKPWoe4jmOQc0wXQUWMYYFFOYuLt7Z8L3Yb11FPpaszRRik3 0=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: LA5RXG2VTDD8kaiTVULn1g4JGu2Bryc+aJ6sVvCuW0cZfV2HVkIJMXEF2ovF84au77QyqyCTXi 2w+8JQoFDrYi+if5XpC3Ir3oTRiUNC0u/GRVm4vyE2aaMWJApUSbiEVgAxPRMWQzWmF4QcIEMi Heh1Hv8Ivfq0eifXuVngLVTxGrOc10YYy6V8kPem6zJxnVYeuLVQF/zlvZ3vJ1jRoRNoNZ8JV2 Lq6vKpA2ZAfgESnfdZrR8eMfV6dWfWGmH/X+Ncc1fmByG7dCxMibFJIUDvGgxkhoHkr4rqE3Kj Dn58NISckNv3LcyM//YrhEfv X-SBRS: 5.1 X-MesageID: 52563678 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:hhJAtKxiDUUl0/HmY+nLKrPw6L1zdoMgy1knxilNoHxuH/Bw9v re+cjzsCWftN9/Yh4dcLy7VpVoIkmsl6Kdg7NwAV7KZmCP1FdARLsI0WKI+UyCJ8SRzI9gPa cLSdkFNDXzZ2IK8PoTNmODYqodKNrsytHWuQ/HpU0dKT2D88tbnn9E4gDwKDwQeCB2QaAXOb C7/cR9qz+paR0sH7+G7ilsZZmkmzXT/qiWGCI7Ow== X-IronPort-AV: E=Sophos;i="5.85,274,1624334400"; d="scan'208";a="52563678" Date: Tue, 7 Sep 2021 15:22:25 +0100 From: Anthony PERARD To: , Julien Grall CC: Jan Beulich , Stefano Stabellini Subject: Re: [XEN PATCH v7 04/51] build: factorise generation of the linker scripts Message-ID: References: <20210824105038.1257926-1-anthony.perard@citrix.com> <20210824105038.1257926-5-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20210824105038.1257926-5-anthony.perard@citrix.com> (dropping most CC) On Tue, Aug 24, 2021 at 11:49:51AM +0100, Anthony PERARD wrote: > In Arm and X86 makefile, generating the linker script is the same, so > we can simply have both call the same macro. > > We need to add *.lds files into extra-y so that Rules.mk can find the > .*.cmd dependency file and load it. > > Change made to the command line: > - Use cpp_flags macro which simply filter -Wa,% options from $(a_flags). > - Added -D__LINKER__ even it is only used by Arm's lds. > > Signed-off-by: Anthony PERARD > Reviewed-by: Jan Beulich Hi Julian, Could you give a Ack to this patch? I think it only misses an ack from Arm maintainers. And if you don't mind, could you commit it with the two other arm patch that are ready? - build,arm: move LDFLAGS change to arch.mk ( you proposed to edit the commit message before committing ) - build: avoid building arm/arm/*/head.o twice Cheers, > --- > xen/Rules.mk | 4 ++++ > xen/arch/arm/Makefile | 6 ++++-- > xen/arch/x86/Makefile | 6 ++++-- > 3 files changed, 12 insertions(+), 4 deletions(-) > > diff --git a/xen/Rules.mk b/xen/Rules.mk > index eaf770414305..3f61682ceab7 100644 > --- a/xen/Rules.mk > +++ b/xen/Rules.mk > @@ -255,6 +255,10 @@ cmd_cpp_s_S = $(CPP) $(call cpp_flags,$(a_flags)) -MQ $@ -o $@ $< > %.s: %.S FORCE > $(call if_changed,cpp_s_S) > > +# Linker scripts, .lds.S -> .lds > +quiet_cmd_cpp_lds_S = LDS $@ > +cmd_cpp_lds_S = $(CPP) -P $(call cpp_flags,$(a_flags)) -D__LINKER__ -MQ $@ -o $@ $< > + > # Add intermediate targets: > # When building objects with specific suffix patterns, add intermediate > # targets that the final targets are derived from. > diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile > index 3d3b97b5b440..0edd9dee6f49 100644 > --- a/xen/arch/arm/Makefile > +++ b/xen/arch/arm/Makefile > @@ -66,6 +66,8 @@ obj-y += vpsci.o > obj-y += vuart.o > extra-y += $(TARGET_SUBARCH)/head.o > > +extra-y += xen.lds > + > #obj-bin-y += ....o > > ifneq ($(CONFIG_DTB_FILE),"") > @@ -133,8 +135,8 @@ $(TARGET)-syms: prelink.o xen.lds > .PHONY: include > include: > > -xen.lds: xen.lds.S > - $(CPP) -P $(a_flags) -D__LINKER__ -MQ $@ -o $@ $< > +xen.lds: xen.lds.S FORCE > + $(call if_changed,cpp_lds_S) > > dtb.o: $(patsubst "%",%,$(CONFIG_DTB_FILE)) > -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Tue Sep 07 14:27:15 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 14:27:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.181128.328144 (Exim 4.92) (envelope-from ) id 1mNc48-0007im-2U; Tue, 07 Sep 2021 14:27:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 181128.328144; Tue, 07 Sep 2021 14:27:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNc47-0007if-Vg; Tue, 07 Sep 2021 14:27:11 +0000 Received: by outflank-mailman (input) for mailman id 181128; Tue, 07 Sep 2021 14:27:11 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNc47-0007iY-4M for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 14:27:11 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id af340802-0fe7-11ec-b0fa-12813bfff9fa; Tue, 07 Sep 2021 14:27:10 +0000 (UTC) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05lp2174.outbound.protection.outlook.com [104.47.17.174]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-19-Kvl8OVOJPsO3QdgAF5zH2Q-1; Tue, 07 Sep 2021 16:27:08 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR04MB5902.eurprd04.prod.outlook.com (2603:10a6:803:ed::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.21; Tue, 7 Sep 2021 14:27:06 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4500.014; Tue, 7 Sep 2021 14:27:06 +0000 Received: from [10.156.60.236] (37.24.206.209) by AM8P191CA0010.EURP191.PROD.OUTLOOK.COM (2603:10a6:20b:21a::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14 via Frontend Transport; Tue, 7 Sep 2021 14:27:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: af340802-0fe7-11ec-b0fa-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1631024829; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/cnaseTopJc0M3gFnFozGKtr9ArBNZkh7NEJ4U8bQHY=; b=RZxTwzoK+lW3/WvN1gd/XAzCHSvXMY6ejiJ9FBFrvzz1OTlbXe6hvW1at1MHVrB4W6QQfa 3ayCvUgOPIOprUkTTmsGeuA+VLem67x337UOlmUUit7eTc437Fjat2hSpJ1IqOskDyPkwa c3sxNx5B2vu++pjRDH40QTgUORx5SlE= X-MC-Unique: Kvl8OVOJPsO3QdgAF5zH2Q-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UD29ztSBhiSO4Zn2b98F5Wm0ibcuYUAJdcXChpqY2WKA8DFeBkdJ6TQIS86QvLSXTEF0eBt3vuvm25LEgxVu8S7f0OrSIvOK8Ztqn/cNvVKSWSXbcAPI3lQEYekm77rUhuD9iE5609dCDHhtPNPBILWQBaejvJGPR5ZIaWfHFkJNOKIXkhKuqEDqe3jyhWLL6Mxa969BVhQPBf95vfedu/uOra2r5Y8UaRLYw6drTQMxArLARVsVHeV/uil+mF8GrN7H4n8pzGPwWGZ0bfpj6sjublabtZGgx7+8Ue8fhkfXGDt/cFszQqkGEKVNy6dEH+sOb+BUu79CNYQG8skaRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=Q1oeAetJ19oaQfdWFwMctncqRNBSqpmyqIffsfr/z08=; b=O7+qhpaaGHOKIpSuxev6l4M+etsTAwpO+rZwaHXkEVgd3V4CEBPjYYuyZu7g8LZdkyN37Sa8GxDhXlTX1bMPkaxQAmGOlB4yvYr9Ul5dxPHfhP6WFPiCNuBlKRqay0b4HTxehQFzLmsSkGatJpGnj29rVquFRyXhCNsHSP9oIoFC3xh3kDNHb1hkbkzDBlCvsgvGI2saRJflbEBaukpgcl2G87zhsxsCJgxNc7mKyJnWJDR98LDURoVB4XZ/Z9mQup1NLAhEi3zKjJpeOVbgcAD8rZCB0Wu/zcCVexZe924WdEYXYQouuftiBOMxRWnJzStd3PxL0uHMM12b29Yvwg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com; Subject: Re: [PATCH v4 04/11] xsm: apply coding style To: "Daniel P. Smith" CC: Daniel De Graaf , Andrew Cooper , xen-devel@lists.xenproject.org References: <20210903190629.11917-1-dpsmith@apertussolutions.com> <20210903190629.11917-5-dpsmith@apertussolutions.com> <01c81885-9ea0-3ecf-66b0-009b9e7ba39b@citrix.com> <3b3762a7-5034-9094-84f9-cd8ab24e24a0@apertussolutions.com> From: Jan Beulich Message-ID: Date: Tue, 7 Sep 2021 16:27:03 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: <3b3762a7-5034-9094-84f9-cd8ab24e24a0@apertussolutions.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AM8P191CA0010.EURP191.PROD.OUTLOOK.COM (2603:10a6:20b:21a::15) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 304e346f-66ac-4ce0-d10a-08d9720b917f X-MS-TrafficTypeDiagnostic: VI1PR04MB5902: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lJ3mye5uRFfqlaCzrlHp+dwV/+/2hR3nJXlrzF93E4wnRhO9amZ713IL+kYU2bYCQg0r6aTjE07BbZoacR0fF4rF+cjlaS4/VoGC6HzR1G9ryXMeKQmzwLG+8s+oJrf/AtyitqgoPA2DZovdB6uU3BGyJYesZSz7pzSuiCrIoC1JQtVU9pPMSI7NbVW+s0rWZj0OrTT0voBfrjJ3BR+zBWO6wWMjLYqfg1OnQUB5sEiXPYko94u8/mbUQ0DirharEEmvCC18HmAijXiEal5JpyzO4Zr+zCTb7TzubkeOrAeHkc3JErltfLQkplGjJ7lmOvM3eRxXuoDm0RA//9G/9WPspko9vwOgcerpjLeUpaex2hfacEhIU32oyEm34q2k6R393NOac4209aJjZizAa5RmlgQYpiDv9gUfN8rEe+DHQN8/7KmFR0ddtNhJEESyULP7IxgeILaHJM46w1zrAU5oGmohlE3HZkP/Lvj2UzX4upl3yfoKCrVGhW/CRI3KaPEAh7KeM2bXY7X2HJFAq+pMs+FFXANXI6vNDrdPA2f4s6WRJaDnOf7j8gTKjGtbkYvfJ4hYD+2VJyj+pmKfG64i8iwii/viWzgCESCTcUcX95UjG7bbtpbQ+DilZ9uiLMbkXlTMv00ZAqFO752tr4IRQAZVFdxuDrMYBL9EbjISjIYTc7jkj2q9MqW5Xq1EijlN3VKGhpS8cNgWgG8Q+nMMJBMiKAnmKZARwZLOwPdUZsEjspRlM5Ivg+bs8QvT X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(346002)(136003)(376002)(396003)(39860400002)(31686004)(66476007)(66556008)(66946007)(54906003)(8936002)(6486002)(956004)(2616005)(16576012)(316002)(478600001)(5660300002)(2906002)(36756003)(31696002)(8676002)(83380400001)(38100700002)(86362001)(4326008)(186003)(53546011)(6916009)(26005)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?W9/SUaQaResgfhQ45BmHstxWNKBE9V2WKrRh8s79NN5uYCN21ZLqi/9JafwV?= =?us-ascii?Q?bBGn9zJjqnOmzrilEhehcQKUAgC5EOj39HOmr2N8wXIMgNISMHJrpvfa54Ck?= =?us-ascii?Q?AJl9T99GAOy11UdF3j/aaWAxrEWGH5p0SDgUA6woL4s2nRfRitsJ6RlcftoV?= =?us-ascii?Q?lZ6zhRKWAog13VNOo497qSbAbYOB+lKXGF9TPb0slhVVsLpIB9grxrq+d1fP?= =?us-ascii?Q?6WzOdGJgqIFH0Nxc0miiuso0+Km/gH/IlWEm3neGqVo0uRKz4iTKsGGqqL4Q?= =?us-ascii?Q?wp3wmvPHGHAGotUGkUjmNbJOEmAGBbeM4U8kVCiJ+c8pvN6dCw9mVLjQ6GaO?= =?us-ascii?Q?erzDGTXgJT5B7feLAwMoRHuDnH82CMoIvMM0rbA8+S2bnRG+Utr+E69X+zoQ?= =?us-ascii?Q?o8dGAR3fdImIycwFBwb4MYcThg+xd4c2gVc7JAwtd9hBNntJDgrahy0hBv5Z?= =?us-ascii?Q?7XxOP+tX6WbBluEVR/GhjwctaHPkNYVPLsqXKKHS7lsWiIqCsh8dopHNHaA1?= =?us-ascii?Q?QKmX9vbjt5W7qxeIjf4JK5jJxm0p1vB3zmpB5jDaengS8bMyclSSIIRhmEF3?= =?us-ascii?Q?3KDQkkA1QeKFjX4tqsONlqRMr2LYaACPQkurGwg5x2Sb4AWD8B7J9Vrnwv1p?= =?us-ascii?Q?TXXxzNr4apoMk0UbG35ADBAJI7p79fJhcfOE/0uYh6ThxJMjs6obzTCbxPHq?= =?us-ascii?Q?xVmXSzNTB6aqcHrOh0CuOLjEAr6gJBRgPOqK1zhse7+/B0qjssKBSfS7DUIZ?= =?us-ascii?Q?gzGCsJyJxLUn/NdHKd0ILXJIFNOYSYlEK1qczFvsIb51h7dvTmUrwFo/gvLM?= =?us-ascii?Q?JkPl0r8OwR2rAJjP+SGABEJ+OO6pWqF2MAZg4xzqJmgWMpuMzIkMvdg2URUl?= =?us-ascii?Q?Evbf/7bpbzg6c9HW1hoUGXIGJiQpajpmtHBrEIUzZuCPHGNOL4hgjPsvqFMc?= =?us-ascii?Q?29zc4aDLi6kQAwRHUJ4TrhlGOLUm3kffrGfVsTC8k8BdVZICBT98tncyHChn?= =?us-ascii?Q?i7BiI+W8qJ6RPZIAt4x3hQf1MSjsm3S3SJlfzCeDETfGbBqMYEaImtWp2wwH?= =?us-ascii?Q?vfBOHK2egV1lTCS5mOfHTrMWgafFV/5dZevF2861M0UYDuZ/HQkvGOl2ZgUp?= =?us-ascii?Q?CZH0m1q7i1xpsnAazrcocT38ST4GT8Pk0L9Eio1KUhQ9CYjIGBWslf3gP4e/?= =?us-ascii?Q?16Qt+h8Z19TUzmuP6miaWIHViRVkqINjf+X5BA95SEzLwaySKdY6Jbs3JqrM?= =?us-ascii?Q?EgFA7m6hX/iM69WoKkSfq0VJuunBxWEWVpLT9+qWKdoqMqcPcq5Wz75fdKE1?= =?us-ascii?Q?jhtbhr6h9OWTEorJuTirx+IJ?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 304e346f-66ac-4ce0-d10a-08d9720b917f X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2021 14:27:06.1904 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: spKIiJ+n5MePkrYN3RMGCDcbAcqeZL/5BvUoFR5XidiCj6OxWZ63qCk1+3Zt8PDH3yWoWD3zC5AnE0MBCIkYIA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5902 On 07.09.2021 16:09, Daniel P. Smith wrote: > On 9/7/21 9:50 AM, Jan Beulich wrote: >> On 07.09.2021 15:41, Daniel P. Smith wrote: >>> On 9/6/21 2:17 PM, Andrew Cooper wrote: >>>> On 03/09/2021 20:06, Daniel P. Smith wrote: >>>>> --- a/xen/include/xsm/dummy.h >>>>> +++ b/xen/include/xsm/dummy.h >>>>> @@ -69,8 +69,9 @@ void __xsm_action_mismatch_detected(void); >>>>> =20 >>>>> #endif /* CONFIG_XSM */ >>>>> =20 >>>>> -static always_inline int xsm_default_action( >>>>> - xsm_default_t action, struct domain *src, struct domain *target) >>>>> +static always_inline int xsm_default_action(xsm_default_t action, >>>>> + struct domain *src, >>>>> + struct domain *target) >>>> >>>> The old code is correct.=C2=A0 We have plenty of examples of this in X= en, and >>>> I have been adding new ones when appropriate. >>>> >>>> It avoids squashing everything on the RHS and ballooning the line coun= t >>>> to compensate.=C2=A0 (This isn't a particularly bad example, but we've= had >>>> worse cases in the past). >>> >>> Based on the past discussions I understood either is acceptable and fin= d >>> this version much easier to visually parse myself. With that said, if >>> the "next line single indent" really is the preferred style by the >>> maintainers/community, then I can convert all of these over. >> >> I guess neither is the "preferred" style; as Andrew says, both are >> acceptable and both are in active use. I guess the rule of thumb is: >> The longer what's left of the function name, the more you should >> consider the style that you change away from. >> >> Anyway, in the end I guess the request for style adjustments was >> mainly to purge bad style, not to convert one acceptable form to >> another. Converting the entire file to the same style is of course >> fine (for producing a consistent result), but then - as per above - >> here it would more likely be the one that in this case was already >> there. >=20 > Understood, I will respin with all the function defs to align with the=20 > "next line single indent" style, though it would be helpful for=20 > clarification on this style exactly. Do you always wrap all args if one=20 > extends past 80 col or is there a rule for when some should remain on=20 > the first line (function def line)? I don't think that aspect has been discussed. I would say void sufficiently_long_attribute test(unsigned int x, unsigned int y, unsigned int z, void *p); is as acceptable as void sufficiently_long_attribute test(unsigned int x, unsigned int y, unsigned int z, void *p); with a slight preference to the former. Jan From xen-devel-bounces@lists.xenproject.org Tue Sep 07 14:29:31 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 14:29:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.181134.328156 (Exim 4.92) (envelope-from ) id 1mNc6M-0008Kl-Go; Tue, 07 Sep 2021 14:29:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 181134.328156; Tue, 07 Sep 2021 14:29:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNc6M-0008Ke-Cc; Tue, 07 Sep 2021 14:29:30 +0000 Received: by outflank-mailman (input) for mailman id 181134; Tue, 07 Sep 2021 14:29:29 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNc6L-0008KY-D3 for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 14:29:29 +0000 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 01bc4f6c-0fe8-11ec-b0fb-12813bfff9fa; Tue, 07 Sep 2021 14:29:28 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 01bc4f6c-0fe8-11ec-b0fb-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1631024968; h=to:cc:references:from:subject:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=lGl+w9RZI0yp86LvWEJpnlZkmHmp3WZZhe19+vSleZA=; b=bFsar9cQCXdcdd2pvyq+aRSAZ2IOClsuFqKLVj1Dfkkq2TPYdER44FNz sy/TmdCT9c3gAOmpTEaRByO3VeG4yv/t0BQMuzZojWslQEoxb56HU00MN ACFtgBpR961QiALUr1wq0Wq991TZ1hf+SrhSU7IN6gGWBs52gLgzXTUrZ U=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: 5G8ZHOZDQ3UqttNSD/nRZIat0DCwuD8jlbOvjimFqOVhYrrHEuzc+DivD1AzVvCyeukkGzEz5P DS8sg3h8jVBnB+fWxASj0PB5PLcqpbNSLjlEWt9AKfMAb2E9ydNHGpndmO9VeSYx5lxJIteQbI pWhtVqRf1wlursJasycsPg5DNpb20RRDlSsgKa5bO5TGDGqnWvL8REC+cpX0Ob/HDcKrpWLStM A4aEY+e5EEv/hH0LpQUv7gZ4uwg1twkQx7XF9ZiVQnsv/UXMZsaUoFhUiugj0yBSHmC2TfOl3c 9okHltYbV+aigI0QcNG34S6o X-SBRS: 5.1 X-MesageID: 51764707 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:zQzsKqC7ICIJpFTlHeglsceALOsnbusQ8zAXPh9KJyC9I/b2qy nxppgmPH/P6Ar4WBkb6LS90dq7MA3hHPlOkPYs1NaZLXXbUQ6TTb2KgrGSuAEIdxeOkNK1kJ 0QDpSWa+eAfmSS7/yKmDVQeuxIqLLsndHK9IWuvUuFDzsaDJ2Ihz0JejpzeXcGPTWua6BJca Z0qvA33QZJLh8sH7WG7zQ+Lqf+juyOsKijTQ8NBhYh5gXLpTS06ITiGxzd+hsFSTtAzZor7G CAymXCl+SemsD+7iWZ+37Y7pxQltek4txfBPaUgsxQDjn3kA6naKloRrXHljEop+OE7kosjb D30lkdFvU2z0mUUnC+oBPr1QWl+DEy60X6wVvdunfnqdyRfkNxN+NxwaZiNjfJ4Uspu99xlI hR2XiCipZRBRTc2Azg+tnhTXhR5wiJiEtntdRWo21UUIMYZrMUh5cY5llpHJAJGz+/wJw7Ed NpENrX6J9tABCnhkjizy1SKeGXLzMO9k/seDlFhiXV6UkXoJlB9Tpc+CRF9U1wra7USPF/lq /52+pT5elzpmJ/V9MKOA47e7rCNoX6e2OFDIujGyWTKEg5AQO7l3fW2sR52Aj4Qu1F8HMN8K 6xGW+w81RCIH7TNQ== X-IronPort-AV: E=Sophos;i="5.85,274,1624334400"; d="scan'208";a="51764707" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=e2FAZXfta6HueaFIwDivZSRLlKn79/z9UJaRxDffmo4v20ClQkQ260H1LcfwUF0DK7ErXvMuF6cULkgZp4lSCYA0GtmjIrCaV98eYK5bFRsQ3eFjwkiv9cnYxY/6ocytfJJrKcEt3CoqJQEOZHBfMqgujmrky0p5IvUd3fFHvqKVbDnP4U+gro/Zi01bXusXcekZG/G4u0DjAi+/Td8Fw8R8sWZQQpfg8KT3yEqDl62zwdOeqNPM1vYUJyuaiuzEjq3wLm6t5PUQ6cQUuNT+PLdwYxjlDQSEcOz+XRt2/glbGa4/27LjSFesyDMRifffdxkwBmLEqDs1NvQnGFA2Ig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=E9qaqhkQxxacAGQ126F758E9SkuBmd5PlZ0+MFHQQXw=; b=J1+vnW1lZEcnDh7lOaMgxcjuiZ8/1oZrw4ScVKoSPftnoTxTkrignCQzlXYDNL5UY5Nr0txiQwiXjm+myw1TeEBhxBN+N5p0Icp5jfCTth0YdoEBLKnWBti5z4lmL/jlYEbRanJ5cQe75RausrJp9/h5run9PfSKFtH/jTW0/oTWaIxjW7kHNGqtIcoWAeRAJWW98aiJrRfKkcAWbng5YIM/yxMPDQgfX5tFYoocNw9HRUzpJMhhePuTAk8GU3g8cpuG8k39jkMnLBcEQyfKAk+c6vsHVqAk1yh4C9GFKygpeXQ6nHsa3k8Kf+mtcbADnByICZBM6iCqaC1HaI5TfQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=E9qaqhkQxxacAGQ126F758E9SkuBmd5PlZ0+MFHQQXw=; b=CeUbcAcbVb9KVc7GJt9BPKIw8X8tibn9RvFBQpwgVGpUY4Q1Csy6819EMrtrxre7/rSF85Cn1li8BNcvH7+IPNSR8of3F9JGpPxXB7IL+mLzf0xWEKDVczLUZgPYIU+Itc8ZT9RDzj+m5aYrTWukYW8s0ZlgSkxBk7YPxfCylaM= To: Jan Beulich CC: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Xen-devel References: <20210817143006.2821-1-andrew.cooper3@citrix.com> <20210817143006.2821-2-andrew.cooper3@citrix.com> <1ba952b1-ad26-79e1-7aa9-af7df28774f6@suse.com> <34905dc6-f8e1-afdd-7f05-1c8e93eab3ff@citrix.com> <709c7d54-2088-415a-6460-bf44002d1d76@suse.com> From: Andrew Cooper Subject: Re: [PATCH 1/3] x86/spec-ctrl: Split the "Hardware features" diagnostic line Message-ID: <074cf055-6e8f-4ec8-692b-2cd0e3f11b7f@citrix.com> Date: Tue, 7 Sep 2021 15:29:13 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 In-Reply-To: <709c7d54-2088-415a-6460-bf44002d1d76@suse.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: en-GB X-ClientProxiedBy: LO4P123CA0428.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18b::19) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ba221d1e-303e-46d7-46b7-08d9720be056 X-MS-TrafficTypeDiagnostic: BYAPR03MB4247: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ZNMGI+dEwEkTNjGF3iyVqsxgiqC8PMdJcvip1GuYXvgeXDBGml0b4SsUxOUpk9reqH4CYhUaodMy5EWo1PwGVEUYl9zckICXwRkVIivE5VA4G7IgFUv79qoUYn4oDzqjKQO/86i9D09wWO4lh/3cfrjff4ptCaNS9LGgilx+4v/2QPXswq1LdrsV98uyGAo1FdPA3zJLqwEiWJ025zCQFg+YRwtITpQNmU/tiFyHYmgya1e9g1n5GG1iGpOpFFraFflsr3g8DHkDNG8I8jhUIY2vB7ZTq9pYEB78H8uwL4LuHwF4Qd2JPggpjP7I5dDui2KYR6cF/ZnOwxIyKSAdi5Q0KMz5p3IWrbF5wCwKK7vF31SAISTtkZQba68OFsHDLlMse4V9AqQ+PSFWO62q7zHMAM8Cu/28rjyEyWjmX4336xU5KnYf+1cHcX89AvsWrsjdIqrZhFcpVClR28sU9+Yzyqw1H8D9MLZxkU77veU/h0BJOx9NUv0Qvi7KcCeyxVgW6AehK6PoC2UyEh/JS6Ini40+bbYWl7GDM23EsAXCAkypdmVGoJ56Oosgd4j4+0h8m+MEsynYhREC+RF6V7UsrXH04ot8OC4g/+0OZYY+DPbjgT7kl9wG4QhRqVjqmLXVgZ4O5ECRTdZoKTNm4jra0w4TXWuYBCYddsvZCW9YiyeTwr4e1d/4l2tSWFkez7kazia/zm0HCkh0U1/I0r5liXw87aWFXS8OgjztYDk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(396003)(376002)(366004)(136003)(39860400002)(8936002)(83380400001)(38100700002)(6916009)(186003)(36756003)(4326008)(86362001)(2906002)(956004)(54906003)(26005)(6666004)(53546011)(2616005)(8676002)(31696002)(66556008)(66476007)(55236004)(6486002)(16576012)(31686004)(478600001)(316002)(66946007)(5660300002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?U3lFY0NmeUMxOGZzYXp4OXZwRnIyQ3h4VFJFWjE0MTUzVDJvbWxMMVJtdC9h?= =?utf-8?B?VVFnRDJhQmZMRU5PTmtpSVZBQVQzUi9BTkNMNWZPNWRlWWxpQWxTc040LzVk?= =?utf-8?B?VFZDU3hhS1IwNDNZRnZ1RmY3YnhVS0c3ZVVqOXhUSldZYTA1SHk5UjVDWk93?= =?utf-8?B?TmN1R1RySEg1Z29ZdEhtalRRSDZIUThIOGJocDVCOWZFakVTWmFySDFiVzg2?= =?utf-8?B?a1c2eW1UbnZuMDhOTW5rbXh0bVUvcnMwdVd5Zy9WTURzd05kbTNYbG01UGdl?= =?utf-8?B?WE5MaUJXMEF4ak9wOExQdHZtdThMOWdVVVRVN21abCtrZkcycnVsaWFTak5x?= =?utf-8?B?TC9BK3BUdjlFQVdZRDFSL28wWUxwV3FRQXZhc2N1L2ljMUJTSGdLOXlmeFMx?= =?utf-8?B?djRkUGxyTmlVZngxOC9sbU00RkdkRVIwb0swRWJSQ0FWd3R3VzhsU0M2ODVP?= =?utf-8?B?dFlsVXN0VEEwanNoWGVCUngvMWZxZm5BUy9oaHFGcHJlcUxTeTg1d3FlVDNr?= =?utf-8?B?bW1jamVDV09FTUpLV2JLaDhDMzBETnN4ZVlzS2JEVkVuNGZHSUdxNk1BbFJn?= =?utf-8?B?Sm1aVGpleVpoRHhLYmhyWUh5STF2blVISi9yMHZkL1BCb3BmcEpSVTBxaDlR?= =?utf-8?B?dU90Tkk2R1YxSkFOMndQK21ZZ0JtNmZ0VUdybHF3SnJUOGtETG4xTGI4dEla?= =?utf-8?B?dHUxRnIwTyt2MEVHWGVNeTdIVGhwSDNIMTFOVXZxdjRSQk95aThFRWtoODVt?= =?utf-8?B?ODNvbmd4NytrWlpXUnlYMTZMQXlKVllGNCtYakZqSHhwWEFGSC91NVFicVRZ?= =?utf-8?B?MS9NV3p1S1E1eXRuOWNLOGFWb2NKZWRtSHdIdHFzcC9LYXhZayt3NzRzMzBH?= =?utf-8?B?MVN3a3FtMG1LelFMdEsyeTdCYkJMOGFRNzdTVDJzSVozd0pVQkNMazJPQkhy?= =?utf-8?B?bWw3Tm0ybEhvMFdzcHhHdFhjQ2l3MGFianNJODZ0UHhia1JNMi9wM2YxR3Vs?= =?utf-8?B?R1RZTFIrVjRaOG5UVHhNLzVRemlxN0NKeGEyZDg2dmpNYXJrQkRseEY5aFZI?= =?utf-8?B?Q3VxVHFVWUF5QnhET0ZtMnNVNmUzakg1a3lSc2NDaEUwWTFuaXcwNmZZeVFq?= =?utf-8?B?VlBlQmorTEFYVCtranRMa0JRcHZRNVNQQXlsWVUrUXZmSmJTR2cyclFNRTlW?= =?utf-8?B?M2IrbUZtNzFiZWhMOHBNczJvUHF4aTA5dXhubEhhTmQwaEw3NS9Ja29zN1FE?= =?utf-8?B?TFZPbHlJV0U0bFJqWjdmakFRQkVTWkpaZjQvK3RBaEcrZzZRRSt6MkRnNG91?= =?utf-8?B?VGxLN21KSVZtRXc0dXF0bStrcWdHUlloK2p5VWdZWEU5NitJZkU1WmlvUWJM?= =?utf-8?B?YU1DNU16R1RvWkFaaGVIMDg2Zk5NMnY4cTBVZG1FUDhzYTRidXFsbDViQ1hB?= =?utf-8?B?bDZ1dHlVVHFOTGhOM1M0SG1BeklEWGhOMjhZbGl2NnAwS2Zid2lzUEV6U1pU?= =?utf-8?B?YjJJSEFrUDk5cUI4OHRURVpuRXBTdE1mMm9MRzNTaFZPYTJMTHZURDVVdExz?= =?utf-8?B?em4yR1luT2IvZXprMzhUMkthaGFaK0hsNmgzeTJoRThtWm00VE5GQ05ycTNC?= =?utf-8?B?YTJjMDM0ZGt3cDFtZTJDajVHTlhNWTFkU0hLdE92NkxjK2ptYkFHVmQ3dndh?= =?utf-8?B?NkVHYkZFYUxLaEJqM1lmRFRWR0xhcGlEV28rc0JpOUp6RWhyaUJQMGtvYmpj?= =?utf-8?Q?hge0gBZx6oYQhBaIUXxfnKoXyHaTvZQV1HET81r?= X-MS-Exchange-CrossTenant-Network-Message-Id: ba221d1e-303e-46d7-46b7-08d9720be056 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2021 14:29:18.4742 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 21uEQhV3ijmmgJ78MfIb81i+8Od03MNexR5P9dbq1eLRsidAZNJ/aANG52JupMfKkXt/D+H5k/7YbI5liqFCvKZ8R9O7emp50tLEdBsadnA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB4247 X-OriginatorOrg: citrix.com On 24/08/2021 14:15, Jan Beulich wrote: > On 24.08.2021 14:57, Andrew Cooper wrote: >> On 19/08/2021 15:38, Jan Beulich wrote: >>> On 17.08.2021 16:30, Andrew Cooper wrote: >>>> --- a/xen/arch/x86/spec_ctrl.c >>>> +++ b/xen/arch/x86/spec_ctrl.c >>>> @@ -317,23 +317,30 @@ static void __init print_details(enum ind_thunk = thunk, uint64_t caps) >>>> =20 >>>> printk("Speculative mitigation facilities:\n"); >>>> =20 >>>> - /* Hardware features which pertain to speculative mitigations. */ >>>> - printk(" Hardware features:%s%s%s%s%s%s%s%s%s%s%s%s%s%s%s\n", >>>> - (_7d0 & cpufeat_mask(X86_FEATURE_IBRSB)) ? " IBRS/IBPB" : = "", >>>> - (_7d0 & cpufeat_mask(X86_FEATURE_STIBP)) ? " STIBP" : = "", >>>> - (_7d0 & cpufeat_mask(X86_FEATURE_L1D_FLUSH)) ? " L1D_FLUSH= " : "", >>>> - (_7d0 & cpufeat_mask(X86_FEATURE_SSBD)) ? " SSBD" : = "", >>>> - (_7d0 & cpufeat_mask(X86_FEATURE_MD_CLEAR)) ? " MD_CLEAR" = : "", >>>> - (_7d0 & cpufeat_mask(X86_FEATURE_SRBDS_CTRL)) ? " SRBDS_CT= RL" : "", >>>> - (e8b & cpufeat_mask(X86_FEATURE_IBPB)) ? " IBPB" : = "", >>>> - (caps & ARCH_CAPS_IBRS_ALL) ? " IBRS_ALL" : = "", >>>> - (caps & ARCH_CAPS_RDCL_NO) ? " RDCL_NO" : = "", >>>> - (caps & ARCH_CAPS_RSBA) ? " RSBA" : = "", >>>> - (caps & ARCH_CAPS_SKIP_L1DFL) ? " SKIP_L1DFL": = "", >>>> - (caps & ARCH_CAPS_SSB_NO) ? " SSB_NO" : = "", >>>> - (caps & ARCH_CAPS_MDS_NO) ? " MDS_NO" : = "", >>>> - (caps & ARCH_CAPS_TSX_CTRL) ? " TSX_CTRL" : = "", >>>> - (caps & ARCH_CAPS_TAA_NO) ? " TAA_NO" : = ""); >>>> + /* >>>> + * Hardware read-only information, stating immunity to certain is= sues, or >>>> + * suggestions of which mitigation to use. >>>> + */ >>>> + printk(" Hardware hints:%s%s%s%s%s%s%s\n", >>>> + (caps & ARCH_CAPS_RDCL_NO) ? " RDCL= _NO" : "", >>>> + (caps & ARCH_CAPS_IBRS_ALL) ? " IBRS= _ALL" : "", >>> I take it you flipped the order of these two to match the ordering >>> of their bit numbers? >> Yes.=C2=A0 IIRC, the first draft spec had the bits in the opposite order= , and >> I presumably forgot to flip the printk() when correcting msr-index.h >> >>> I'm slightly inclined to ask whether we >>> wouldn't better stay with what we had, as I could imagine users >>> having not sufficiently flexible text matching in place somewhere. >>> But I'm not going to insist. It only occurred to me and is, unlike >>> for the IBRS/IBPB re-arrangement of the other part, easily possible >>> here. >> dmesg is not and never can will be an ABI. > Well, sure, I understand this. I said "slightly" not because I would > use the log this way, but because I know of at least similar (ab)uses > of logs. Lots of details which are currently only available in `xl dmesg` should be available via a real hypercall. The domain creation improvement work is making headway with retrofitting proper details to virt_caps/etc, but there is loads more data needing exposing. > >> Amongst other things, `xl dmesg | grep` fails at boot on large systems >> (because you keep on refusing to let in patches which bump the size of >> the pre-dynamic console), > And instead I've taken the time to reduce boot time verbosity. Plus - > the last attempt must have been years ago. Given good enough arguments > and little enough undesirable (side) effects, I'm sure I could be > convinced. (But yes, especially the "good enough" aspect is definitely > pretty subjective. Yet then I could be easily outvoted if others agree > with the provided reasoning.) > >> or after sufficient uptime when the contents has wrapped. > The boot log can easily be made persistent on disk before it can wrap. All failures we've had with customers are the fixed initdata buffer wrapping before it gets dynamically allocated.=C2=A0 As a consequence, we unilaterally up _CONRING_SIZE to 64k. And yes - reducing the verbosity of the ACPI tables is a good thing, but there's plenty more in need of shrinking. ~Andrew From xen-devel-bounces@lists.xenproject.org Tue Sep 07 14:55:53 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 14:55:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.181143.328167 (Exim 4.92) (envelope-from ) id 1mNcVm-00044Y-M6; Tue, 07 Sep 2021 14:55:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 181143.328167; Tue, 07 Sep 2021 14:55:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNcVm-00044R-J1; Tue, 07 Sep 2021 14:55:46 +0000 Received: by outflank-mailman (input) for mailman id 181143; Tue, 07 Sep 2021 14:55:45 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNcVl-00044L-JE for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 14:55:45 +0000 Received: from sender4-of-o51.zoho.com (unknown [136.143.188.51]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id ad36f8f8-0feb-11ec-b104-12813bfff9fa; Tue, 07 Sep 2021 14:55:44 +0000 (UTC) Received: from [10.10.1.24] (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1631026537886258.94692952877904; Tue, 7 Sep 2021 07:55:37 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ad36f8f8-0feb-11ec-b104-12813bfff9fa ARC-Seal: i=1; a=rsa-sha256; t=1631026541; cv=none; d=zohomail.com; s=zohoarc; b=dEuYpSadwO6BWXXzFGESW3zKszBfn9BDjg7PbivaKnzxLZl/ObSB9DcqOqVidWDdDCAcmHH2VERSm4nbSneNS4EhKWzNa+cSdRI72JggfBjIUGsl0jZ/QleeX2z678y89rgwpexpvkp3k1J21L7m/9RpPCEnAWPLl1UF+/YDgyQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1631026541; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=1S9g/DAWEke9fgbmngX/mer48f8cYnTvTwR4FI8XbP8=; b=ZZYPoDEO2umi+nMxueIX3gVflBRtsPUhFJWtVtoNFqxDJEjQBfaySLrsD1O1RaMwW/TTFzVzSAdCW+5fR7Mj3yVPiU+sPUwYFOzyd/1sRK+Lzq78h3RrfUWaRQVGPS0ppFUR1fpw0UHf6C3SAIVBTdTnIUk9AbF7N9RLNfHuBCE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1631026541; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Subject:To:Cc:References:From:Message-ID:Date:MIME-Version:In-Reply-To:Content-Type:Content-Transfer-Encoding; bh=1S9g/DAWEke9fgbmngX/mer48f8cYnTvTwR4FI8XbP8=; b=P1acJ6j4P1gKWNaDrgPeeqX4PLdqzbbu5JLUFK+E0QwcfdSrMP8vCRACvBwvzm1H Hhb3ypw/bFvSqw9d4DhrsAvqij4DYIqvSXDvEuz0qd4PI/tSOVfxA5ZxnrPJVVCYmtW BcCDVVnZjVRB0/dq/WEbk4Xc9DEpOecpM2hsDvwU= Subject: Re: [PATCH v4 04/11] xsm: apply coding style To: Jan Beulich Cc: Daniel De Graaf , Andrew Cooper , xen-devel@lists.xenproject.org References: <20210903190629.11917-1-dpsmith@apertussolutions.com> <20210903190629.11917-5-dpsmith@apertussolutions.com> <01c81885-9ea0-3ecf-66b0-009b9e7ba39b@citrix.com> <3b3762a7-5034-9094-84f9-cd8ab24e24a0@apertussolutions.com> From: "Daniel P. Smith" Message-ID: Date: Tue, 7 Sep 2021 10:55:36 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-ZohoMailClient: External On 9/7/21 10:27 AM, Jan Beulich wrote: > On 07.09.2021 16:09, Daniel P. Smith wrote: >> On 9/7/21 9:50 AM, Jan Beulich wrote: >>> On 07.09.2021 15:41, Daniel P. Smith wrote: >>>> On 9/6/21 2:17 PM, Andrew Cooper wrote: >>>>> On 03/09/2021 20:06, Daniel P. Smith wrote: >>>>>> --- a/xen/include/xsm/dummy.h >>>>>> +++ b/xen/include/xsm/dummy.h >>>>>> @@ -69,8 +69,9 @@ void __xsm_action_mismatch_detected(void); >>>>>> >>>>>> #endif /* CONFIG_XSM */ >>>>>> >>>>>> -static always_inline int xsm_default_action( >>>>>> - xsm_default_t action, struct domain *src, struct domain *target) >>>>>> +static always_inline int xsm_default_action(xsm_default_t action, >>>>>> + struct domain *src, >>>>>> + struct domain *target) >>>>> >>>>> The old code is correct.  We have plenty of examples of this in Xen, and >>>>> I have been adding new ones when appropriate. >>>>> >>>>> It avoids squashing everything on the RHS and ballooning the line count >>>>> to compensate.  (This isn't a particularly bad example, but we've had >>>>> worse cases in the past). >>>> >>>> Based on the past discussions I understood either is acceptable and find >>>> this version much easier to visually parse myself. With that said, if >>>> the "next line single indent" really is the preferred style by the >>>> maintainers/community, then I can convert all of these over. >>> >>> I guess neither is the "preferred" style; as Andrew says, both are >>> acceptable and both are in active use. I guess the rule of thumb is: >>> The longer what's left of the function name, the more you should >>> consider the style that you change away from. >>> >>> Anyway, in the end I guess the request for style adjustments was >>> mainly to purge bad style, not to convert one acceptable form to >>> another. Converting the entire file to the same style is of course >>> fine (for producing a consistent result), but then - as per above - >>> here it would more likely be the one that in this case was already >>> there. >> >> Understood, I will respin with all the function defs to align with the >> "next line single indent" style, though it would be helpful for >> clarification on this style exactly. Do you always wrap all args if one >> extends past 80 col or is there a rule for when some should remain on >> the first line (function def line)? > > I don't think that aspect has been discussed. I would say > > void sufficiently_long_attribute test(unsigned int x, unsigned int y, > unsigned int z, void *p); > > is as acceptable as > > void sufficiently_long_attribute test(unsigned int x, > unsigned int y, > unsigned int z, > void *p); > > with a slight preference to the former. > > Jan > Apologies, I was referring to this style which I am understanding is a little more preferred void short_function_name( struct really_long__struct_name *x, struct really_long__struct_name *y, unsigned int z, void *p); vs void short_function_name(struct really_long__struct_name *x, struct really_long__struct_name *y, unsigned int z, void *p); NB: I don't recall it off the top of my head, but there is one function def in here that is similar to this situation v/r, dps From xen-devel-bounces@lists.xenproject.org Tue Sep 07 15:00:13 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 15:00:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.181149.328178 (Exim 4.92) (envelope-from ) id 1mNca5-0005UB-8y; Tue, 07 Sep 2021 15:00:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 181149.328178; Tue, 07 Sep 2021 15:00:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNca5-0005U4-5o; Tue, 07 Sep 2021 15:00:13 +0000 Received: by outflank-mailman (input) for mailman id 181149; Tue, 07 Sep 2021 15:00:11 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNca3-0005Ty-BP for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 15:00:11 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (unknown [40.107.20.85]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 4b78e2ed-0fec-11ec-b105-12813bfff9fa; Tue, 07 Sep 2021 15:00:10 +0000 (UTC) Received: from DB8PR03CA0013.eurprd03.prod.outlook.com (2603:10a6:10:be::26) by DB9PR08MB6892.eurprd08.prod.outlook.com (2603:10a6:10:2a7::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.24; Tue, 7 Sep 2021 15:00:00 +0000 Received: from DB5EUR03FT008.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:be:cafe::80) by DB8PR03CA0013.outlook.office365.com (2603:10a6:10:be::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Tue, 7 Sep 2021 15:00:00 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT008.mail.protection.outlook.com (10.152.20.98) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Tue, 7 Sep 2021 15:00:00 +0000 Received: ("Tessian outbound 7a08471b1ef6:v105"); Tue, 07 Sep 2021 15:00:00 +0000 Received: from 2a10722e183a.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 016CF1FD-286E-4099-B9C3-8602872EF9F8.1; Tue, 07 Sep 2021 14:59:47 +0000 Received: from EUR03-AM5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 2a10722e183a.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 07 Sep 2021 14:59:47 +0000 Received: from PAXPR08MB6816.eurprd08.prod.outlook.com (2603:10a6:102:130::10) by PR3PR08MB5612.eurprd08.prod.outlook.com (2603:10a6:102:8f::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19; Tue, 7 Sep 2021 14:59:45 +0000 Received: from PAXPR08MB6816.eurprd08.prod.outlook.com ([fe80::c1b4:db1c:376f:b697]) by PAXPR08MB6816.eurprd08.prod.outlook.com ([fe80::c1b4:db1c:376f:b697%8]) with mapi id 15.20.4500.014; Tue, 7 Sep 2021 14:59:45 +0000 Received: from smtpclient.apple (82.8.129.65) by LO4P123CA0113.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:192::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14 via Frontend Transport; Tue, 7 Sep 2021 14:59:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4b78e2ed-0fec-11ec-b105-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=g0ut8YQV8nIB9fjekl4Z/u2KCM0ldFTLssCyvuThFQ8=; b=GPAmWs8VKqm3+AsG3QWR6fGs0fDfKjJhtqQgCy+z9ot277xmSBH2JbYs465YO3U8mTtiTFqkLIt/Cz1fcs1XtMNLIQhepLUCKgQo4EEll2UMGXsqxPuYft9TSBp3MKV96306+znATtWT9w5hzIyFOmovw9sMhFG6h+06VqzZc0w= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: 389f84a7de519024 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GHjeyp1Tk8Bt44uKrDdrSON+4CmkXk3u9jS490qUmrPEYBftMGFIA6yD1nwkaemjy/hWIm1vey4CgoButen+4P89EEQ6qlKVayETBVecbFY+zF0PiE3odWayNPQQNcMRlHs8j1XsaP2guBQnT1IiOCaCj9LqHmosjXmaN+Nr2INgQNd8d7zdc7WmuDVzDMYyxi/DjPb0THrYGa9XNYi43+zjbFZJvgmF/aRUzqdZ8tmJ4vLCbd49iEsQ1ja6XmUZMsgVtnaDt5suEFkywJJ8FoGFKQwM38bSXK01cq7JC5gr9tUBfbkSEqvCk1+p/5atDhAUXmI3MuFseSqiThpRSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=g0ut8YQV8nIB9fjekl4Z/u2KCM0ldFTLssCyvuThFQ8=; b=BG3RXNkExaN28DR+y9MminQvCXEta2BYknxeJBTeBsCthS0nXowWwBn01xdjaIPWHFANmDM7WpM1jC9gkg0khDR0bkP3Y/Q+I6mJtb8w5HdoUGhkmfUydBAroq9EPJzdppAv/+n2vj1a98vbnDMSHVZeP8Mnag41i9rdr7bc6BThCAzONPHDDGxeyJrg8eGsCKI7jWa9bnvUOPzbVrMlIFxtQrwcTbVj0Ft1ME8TR9Wsr5DxTe5wl+Hgj5ejjtduUScRln79cgloTt1kdyvW+/efUJcQz6BFVcouTR38NVyXYR6I92gHz2RBb/LgnZXcfZA5RWJjPyWYArNbn8xI1Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=g0ut8YQV8nIB9fjekl4Z/u2KCM0ldFTLssCyvuThFQ8=; b=GPAmWs8VKqm3+AsG3QWR6fGs0fDfKjJhtqQgCy+z9ot277xmSBH2JbYs465YO3U8mTtiTFqkLIt/Cz1fcs1XtMNLIQhepLUCKgQo4EEll2UMGXsqxPuYft9TSBp3MKV96306+znATtWT9w5hzIyFOmovw9sMhFG6h+06VqzZc0w= Authentication-Results-Original: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com; Content-Type: text/plain; charset=utf-8 Subject: Re: [RFC PATCH] xen/design: Add design for EFI dom0less system start From: Luca Fancellu In-Reply-To: <910f2758-cbce-53b0-4e57-4b2a966ce2b3@xen.org> Date: Tue, 7 Sep 2021 15:59:39 +0100 Cc: xen-devel@lists.xenproject.org, Bertrand Marquis , wei.chen@arm.com, Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Stefano Stabellini , Wei Liu Content-Transfer-Encoding: quoted-printable Message-Id: References: <20210907065228.21794-1-luca.fancellu@arm.com> <4bab7902-0268-5705-5462-fcd7571d7492@xen.org> <7BD59287-75ED-4D4F-B892-F6B04583A986@arm.com> <1efbd9a8-232b-b267-fa8e-7f5f1af7cfed@xen.org> <5DA71CEF-0ADE-4846-A7BC-B378B95A38AD@arm.com> <910f2758-cbce-53b0-4e57-4b2a966ce2b3@xen.org> To: Julien Grall X-Mailer: Apple Mail (2.3654.120.0.1.13) X-ClientProxiedBy: LO4P123CA0113.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:192::10) To PAXPR08MB6816.eurprd08.prod.outlook.com (2603:10a6:102:130::10) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7c8a4209-cda9-445f-79f0-08d972102a22 X-MS-TrafficTypeDiagnostic: PR3PR08MB5612:|DB9PR08MB6892: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:10000;OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: PojKJmOLpCAW7HE2c56gpfJ5iIGiqeoGCOggi10p9BRleMAWXW3Nuphre9GN1jGCdNhE7LuJNZLsHl45Hqnu5+n7axcYYDKAFE0Gk/RqoZmTQR7azOZh1kjP5X9iv5qY5MASBzF8ptEBK1nk0BCYxx/axbM5x076eqHJEj7jaj1vSS4KsA7zU2fF7upwcTuf1jjJpqre3LaIC7y98Qavl99TRsWU8KzcAIUt+LrsafFhjsiVqC7EBgzT9sXTULh2klqkUi88zCVR9UQGTcLEgB5wobz9YUB6O+fpNYCJ4mDt1vpubBJ/h3nVWQqQq7pHPbV3LzRXfvn1oe6O/vbalKGgYNMxKOjX078RcaoZipkj6ZPR/sjIloFwtoHPVip5eP1OKGG5R2b9+s2Yw0xOFd3pyqsgAaAJvO0L8XdtsHwwvIOlEQHiaEbl33jnAL7REuRi/gM62WDGNBw/sn+pLm5/9aOzvaX2dJY0BwB2zJn9BJH6IoFp+gZOmk/L6EfZ6svz0z/WkISnaEyVDuVqBggQEAt52rjabOvQKsxjvgCqX/eRSfWgvd5p4PKvazZtWFSXwIY3FvCoutriGKoozMTWaOBG0PZlRWjdkfz9wSFob79nfnnSHhX9sxzlraMFIIPF9Ir3BTd+YrDyqI69lvfrYx4s4jIzUCPbqtWBdaJgWs4SOYkF7Cuvu+gqC8WKsgoh5a3hEBfNpbKaPnYsdajSjypOVsng7oDKibGRfmj7DL/2Kv8SEmDtBdeyx9zB/5AXXzsLfYNz1LD8CyK9wQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB6816.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(136003)(366004)(346002)(376002)(396003)(39860400002)(86362001)(26005)(186003)(2906002)(83380400001)(478600001)(6506007)(2616005)(956004)(8936002)(316002)(54906003)(6486002)(6666004)(66556008)(66476007)(52116002)(33656002)(5660300002)(53546011)(6916009)(44832011)(66946007)(38100700002)(8676002)(36756003)(38350700002)(6512007)(4326008)(32563001)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR08MB5612 Original-Authentication-Results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT008.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 63729969-2c5c-4764-9aa0-08d97210212a X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GUdGWtaEljibbUCSdnY4z9Hv26jglvwoL7N5JxADmVF6/NreGWkytIQG9zjZ8m8tC8T/jRMpCMF3ByC8m3QJP6Yq4BOsOtWi8u4EjFNRy05exlNwbZ66xS1nOgnIsxTXav3eN+DSSTD1OWVLsYYmqYTBRJKiQj1uZxpDB3cOvCSY62y+ahyOrIOgNBUVBIEwwZ1WCdCSEGzATO1sGUdoZ3jszgaYoP3sCKlkRNfZTdcK13DFBSYplw+AqHNprpbJlnBQTKNoGzZR3ArhhhO84UiYAPZhf0PItqGQInsEkSsY5VHzuvow2O9EzEe1BM3YdHGoGpg5aTH6u2tEwMEancu/UXHJlshApJbm41s8JDeubAts82+EhRxNd+uU2p6J5G0heH7+IDRbBYNinkdbiJW8RZNsSdP8QpnDuI2sz9RP2sarZft6QrF0d5oqjb9CNBh2qV+XuRlonsFVj1gK3kLUANczOC7G8FE6bbKufe963THDNidGufuJxx8InklBEuPXu2/N9kMpWyT9cvv88YTl+zaEhBvpaU2NBy/qSG2JIvX/te2LTxZjAzGZiB6sGnmbHQLhKsLol0ABFjieE8yqekZg42BYAUG0FB/ZAYs+YCeYVUyp3NuanYoPrOx83YBsLs3YP+XyRP5ONYJ8wWNDfUHGrvEk74ZtpCP35u4hq5v3JPVK+LnO24tbmGLwNTnaTcXigCzRZyWLZmWEAvg0kWR+VDIfH4scX9WkHFY= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(376002)(396003)(39860400002)(136003)(346002)(46966006)(36840700001)(316002)(70586007)(6512007)(4326008)(53546011)(33656002)(336012)(6506007)(83380400001)(47076005)(2906002)(8676002)(70206006)(478600001)(26005)(5660300002)(81166007)(956004)(82310400003)(36756003)(6666004)(8936002)(356005)(2616005)(54906003)(86362001)(6486002)(82740400003)(186003)(36860700001)(44832011)(6862004)(32563001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2021 15:00:00.1516 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7c8a4209-cda9-445f-79f0-08d972102a22 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT008.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB6892 > On 7 Sep 2021, at 15:18, Julien Grall wrote: >=20 > Hi Luca, >=20 > On 07/09/2021 14:30, Luca Fancellu wrote: >>> On 7 Sep 2021, at 13:30, Julien Grall wrote: >>> On 07/09/2021 12:51, Luca Fancellu wrote: >>>>> On 7 Sep 2021, at 10:35, Julien Grall wrote: >>>>> What we could do is providing a list of binaries to load and associat= e a key for each of them. Something like: >>>>>=20 >>>>> binary=3D >>>>> binary=3D >>>>> .... >>>>>=20 >>>>> We can then replace the property "reg" with a new property "uefi,key"= that will contain the name of the binary. >>>>>=20 >>>>> What do you think? >>>> Here I=E2=80=99m lost, because I don=E2=80=99t understand what we are = going to do with the name of the binary. >>>=20 >>> would be used by the UEFI stub to load the binary in memory. = Each binary will have a which helps to refer them in the Device-Tree= . To give a concrete example, let say we have two dom0less domains: >>> - DomA: 2 vCPUs, 128MB >>> - DomB: 3 vCPUs, 512MB >>>=20 >>> DomA and DomB will be using the same kernel but a different ramdisk. xe= n.cfg, would look like: >>>=20 >>> [global] >>> default=3Dsection1 >>>=20 >>> [section1] >>> options=3Dconsole=3Dvga,com1 com1=3D57600 loglvl=3Dall noreboot >>> kernel=3Dvmlinuz-3.0.31-0.4-xen [domain 0 command line options] >>> ramdisk=3Dinitrd-3.0.31-0.4-xen >>> xsm=3D >>> dtb=3Ddevtree.dtb >>> binary=3Dvmlinuz-guest domu-kernel >>> binary=3Dramdisk-domA.img domA-ramdisk >>> binary=3Dramdisk-domB.img domB-ramdisk >>>=20 >>> The chosen node in the DT would look like: >>>=20 >>> chosen { >>> domU1 { >>> compatible =3D "xen,domain"; >>> #address-cells =3D <0x2>; >>> #size-cells =3D <0x1>; >>> memory =3D <0 0x8000000>; >>> cpus =3D <2>; >>>=20 >>> module@1 { >>> compatible =3D "multiboot,kernel", "multiboot,module"; >>> uefi,binary =3D "domu-kernel"; >>> bootargs =3D "console=3DttyAMA0 init=3D/bin/sh"; >>> }; >>>=20 >>> module@2 { >>> compatible =3D "multiboot,ramdisk", "multiboot,module"; >>> uefi,binary =3D "domA-ramdisk"; >>> }; >>> }; >>>=20 >>> domU2 { >>> compatible =3D "xen,domain"; >>> #address-cells =3D <0x3>; >>> #size-cells =3D <0x1>; >>> memory =3D <0 0x20000000>; >>> cpus =3D <3>; >>>=20 >>> module@1 { >>> compatible =3D "multiboot,kernel", "multiboot,module"; >>> uefi,binary =3D "domu-kernel"; >>> bootargs =3D "console=3DttyAMA0 init=3D/bin/sh"; >>> }; >>>=20 >>> module@2 { >>> compatible =3D "multiboot,ramdisk", "multiboot,module"; >>> uefi,binary =3D "domA-ramdisk"; >>> }; >>> }; >>> }; >>>=20 >>> With this approach, the change is quite minimal to move between an clas= sic U-boot boot and EFI boot. >> Ok now I see, yes this approach can work and can save some code, in the = current code we have that if >> a "multiboot,module=E2=80=9D is found in the dtb, the Xen EFI configurat= ion file is skipped, but if we use the >> module@XX {} without the compatible it can work, the UEFI stub will load= the binary and update all >> the needed properties (compatible, reg). > With my proposal, you don't know whether the binary is a kernel, ramdisk.= .. So you wouldn't be able to recreate the compatible properly. >=20 > But the behavior of the UEFI stub can be modified. We could say that if t= here is a "xen,domain" then use the configuration file to fetch the binarie= s. Yes you are right, or we can introduce domu_kernel, domu_ramdisk, domu_dtb = with the same syntax of your binary=3D keyword, that would be enough to select the right compatible, instead the right module is identified by t= he string. >=20 > Cheers, >=20 > --=20 > Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Sep 07 15:01:39 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 15:01:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.181155.328189 (Exim 4.92) (envelope-from ) id 1mNcbP-0006Om-Km; Tue, 07 Sep 2021 15:01:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 181155.328189; Tue, 07 Sep 2021 15:01:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNcbP-0006Of-Gx; Tue, 07 Sep 2021 15:01:35 +0000 Received: by outflank-mailman (input) for mailman id 181155; Tue, 07 Sep 2021 15:01:34 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNcbO-0006OX-E7 for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 15:01:34 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id e9534e9b-dccb-4cdb-ab3a-9eee082daf8a; Tue, 07 Sep 2021 15:01:33 +0000 (UTC) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05lp2109.outbound.protection.outlook.com [104.47.17.109]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-4-Weu6wJ30MmKhLA8foV0Wjw-1; Tue, 07 Sep 2021 17:01:31 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR0401MB2605.eurprd04.prod.outlook.com (2603:10a6:800:57::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.22; Tue, 7 Sep 2021 15:01:29 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4500.014; Tue, 7 Sep 2021 15:01:27 +0000 Received: from [10.156.60.236] (37.24.206.209) by FR3P281CA0051.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4a::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.6 via Frontend Transport; Tue, 7 Sep 2021 15:01:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e9534e9b-dccb-4cdb-ab3a-9eee082daf8a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1631026892; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3gOJT+pE51xlYTei+0Zv/UygilQrt+3sdPAMFW0ydco=; b=ZYPec0pZ2H8QsE2u/yGIh3VeQz+DivH4/Peit5lPqvP34yKZpNK/FR/59cZHbBR3r3hMWb kJgbnJBq6Nw1FQN3a5+XFVS3qWo6fHQWSd56RMTz2qtrvfKvWXMMJEWawpMXdRiKK2hYQL ehl7HfU76+EBQadFri6g3z2z8YCvFSw= X-MC-Unique: Weu6wJ30MmKhLA8foV0Wjw-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IOA/6gS4pY6AnCYtILAANLrTVUfP0X+rxkVrL7ehjnxI5881dchcqvIsVqieEqCLr2xwUfd/X0e42p0u0E0E/YOl+frFa6wd5CpAWm05eS4wDEV5sxGyFG3YWp5xtehHFok8UkicEHsFYGxBzw30odhX9E4E+tHAwP7ljIy3DzFclwZ8sUsTSc5TcRTa4Isc2bCbNG5/1UufvrU56Jh+qpevb8zMa+wctRv+6AGUFYpXo+XUj5xJ1ocF8q4II6bWBs4MzKmWAnXjE8Itg6cpHUNqHOn3ubVtslrsw7oecB5Xhf3JBGlqREmCiMxo88jwc7Z21PIpG8zuWFoJ05vTKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=/yJIGk4ydRvmXHfQr1S7Kfi9GZbDReLS7yzFgjiLH+0=; b=I9Zge/jXxu5qsMi//mDK8p844hiS8Ypw5zIwzoxdvDtSs9ZsWwD9SjG8fNQz8I7TSs3sHBs1RwDuenq2y0eAd5W6z4HMgvplMzby5UfirsYL2Ktv1p0bvd1LAWPiDwg8Q8TYKvB7WQACo5Ey2Swg6XBGUueicIQysTp3iAW1y6WuZuVfnsnIUq/BSKB38Ko09u/euEjbCg98wCaOo/HmozVpkKFjbh3IjHVAMppbfR8Pu29YZUzuwETPOovORpF98B/Kv15vxE84eTSBJZKlFgMzA5uHJTASl7WA3RvtC0xOsVqA2larNfkAxaTYzaUpY1rGEO+mtEubcU88tNqWHA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com; Subject: Re: [PATCH v4 04/11] xsm: apply coding style To: "Daniel P. Smith" CC: Daniel De Graaf , Andrew Cooper , xen-devel@lists.xenproject.org References: <20210903190629.11917-1-dpsmith@apertussolutions.com> <20210903190629.11917-5-dpsmith@apertussolutions.com> <01c81885-9ea0-3ecf-66b0-009b9e7ba39b@citrix.com> <3b3762a7-5034-9094-84f9-cd8ab24e24a0@apertussolutions.com> From: Jan Beulich Message-ID: <6c042f71-80a1-c6ee-f171-fa1ac4c3dcef@suse.com> Date: Tue, 7 Sep 2021 17:01:26 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: FR3P281CA0051.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4a::9) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b2284eca-7d06-4f1d-3bb1-08d972105e35 X-MS-TrafficTypeDiagnostic: VI1PR0401MB2605: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: JrFF53dtO2jI54Ecl/NGU8KqOxWYurUwTn0xxHndtsx3rBUTA/9JeHnHt5qY6D2OMHNAzAeEw598wqj6l5aXK5/6a8m3BosG9rRuo0lrsmOnwveWncoCpt5+rrgMk/MEPf1lOCLmkF0+55zs/WyfR+EBHCHVLYzgKjXytnVfw0cy+g7Z4nOwwBNxyJIOZcZZDs0QvNkK2kvqodQKCxnCZG+uU1R5YKRYYb0F1ZQhinHR5jpg6mvFSAnznn1CZXMm2CiUCdOpl5JgifeXoLMXc3YZWKPZ4vuidNbNGKWWT/66URafH1gqSQqgioLM7WqaLnVM79/lT31bfSB904XYkrnpk0omeoaIdfsf1BsYdX1HHtSBb+PPSruhJO5HOF8YRJQVm96hXyfCgL1COReg1hb/cWM/XgB8GRumTH2+Q1slMR7WyUYy2KtcJwaSRsYu2FVSbO8AjuiCwPR4FA5G9nu5rU4CKj4SHpv25bdhlbAs8IL8QH+z5MtuLFTDbkZ876dBoITw1LmW9n9l/yqNqHzGLtKtF92+qC3+EGB/shHKCysAt9I6wy6HiqsCxylA1RT1Z0JDC8Q4yAFSBpX1CanHEDTyFlYAtcOToyls+UoDdS900aRqF2QfmjeLB2TH0ugI6ttg5Zz7ZoB9eMNlVDHlFllq7oAVqDH3ClGVA3GWRAUwACnBrWN+L0YM6LfgN2WI2dCI4rXqr/aZfwgMNqUnUut21BXDTjZMlQE+A3E= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(396003)(346002)(39850400004)(376002)(366004)(136003)(6916009)(53546011)(5660300002)(36756003)(316002)(16576012)(83380400001)(66946007)(6486002)(66476007)(66556008)(2906002)(186003)(31686004)(956004)(38100700002)(31696002)(26005)(2616005)(478600001)(8936002)(8676002)(4326008)(86362001)(54906003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?8qyMkGVN2guD2B3QnRHxgFg+Io2MhXpBXl24SjvMRRVTabOZMVx1cmHvNKcI?= =?us-ascii?Q?V7pBJkWXboZf2Vv3O9/E33UXZu/vDFHllWa3jHRtX4pETgBDlhyJsjG3cNay?= =?us-ascii?Q?cHOMbLpRWK3OZhSLypwpJZCk01pvtF2qikbUr1zubYzHgg4JKMYQrzG2SNwn?= =?us-ascii?Q?vk0ZOyIF6M0SlCMAFMCtmeI6rF5tb4l9cKpGKxpazbTgamqZWAGR+7TX/mXc?= =?us-ascii?Q?QBzLSgzR72TUsSonRF6JJXRgNxLwgnkUtMRRH5hNclXEVxq1kSlmJH5lcLiI?= =?us-ascii?Q?sm7Js0Bw2VMR2+Ism06xC0KW6CGryD5T/h9RqFi2XsLL62XBLWHIJU5H8zoh?= =?us-ascii?Q?CBAzzbGylZA8A/KTw1ClIux/BeYe5Vr8HnnFE+0sRrc+FxNbnbhk8X0Gr1o6?= =?us-ascii?Q?iUB8SE7LgeMbJSMzPRwGtmtddHYPrS4dYx2pPD8mW/Z5X0uvkua4b+7GkKm1?= =?us-ascii?Q?sqdmDmIvh3T/3sFVJABEgEf0oT8sy0uG0sRCndGy7aeArgCfap90fj+ZXnic?= =?us-ascii?Q?i6GUvIofYZ/xApQ8mG8bDtFv1hG19SW7sPttxjW+2QqkVYSbcCYVmSmzP0CY?= =?us-ascii?Q?d7V13VwyUflfoIqoyMIOEHQOebTfjZnQS3BfNxrue0O9a5/pCWX1du3Y6Ao1?= =?us-ascii?Q?cbwdYwFSkD1NiPB4EzEVu0+MqIPnwwyycYbG1q/RUmUfcueO3W31wHI5mD8O?= =?us-ascii?Q?QE1EEkUGQr1EtPcVCDlVw2G3nIKR+HFpr7/J5IdnTSNIlMShKIBSOz5sNKd8?= =?us-ascii?Q?O252/twMHi3uInfUPuksi/Qtfcc7xm8vwsT5+ySagpXkFgJTXEVlhxNbxPe4?= =?us-ascii?Q?8JavYhwcfhG2mxv0YRWW39RQLYcudvKxlscQrxu0fqrzyrPc9QO5aAmQGPOG?= =?us-ascii?Q?q+YNUt8xYPxsPkefsF2N0svk84Dt2Mb3BoGnjxC190kpOhAUjCyufuWAxDhz?= =?us-ascii?Q?C1146R4v7x+kMK+nG9C/0haeopB7vP4b7cCrGBVhSkpPviTDJgaduVmeR5hq?= =?us-ascii?Q?uMaXCZRdSkRd19qeKqc90D5npjOOr5Pedxlh56xkDmQ+SDB+LyBX/ywPl+Zu?= =?us-ascii?Q?uZQvmLCj60avQWZGkQV+c/x7GRtjYx5od1NtQAnvTxoU80Lzwwa0fktrdZI4?= =?us-ascii?Q?lcbOWZ6Ez6Di65LamSBWx7cd600csTpOSzecD+zZwYhZOk6DfGaqOgEyTYRc?= =?us-ascii?Q?RK2Z1FkgmafyOFtE+D3/NSKTe4qAZSxwxrxhMkcNNgU44YTbxC1j4mPr013L?= =?us-ascii?Q?scKCRYyLJ9Y6v4gdXBS6Pwv5BPPXfeWMXmepdKcUB3aXPsQXHzkpH0pSEFhN?= =?us-ascii?Q?b6bmD+2d2TZOqF6JOISDtiRE?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: b2284eca-7d06-4f1d-3bb1-08d972105e35 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2021 15:01:27.6315 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: DkM6VkY+qvb4VFNQ8K32XycFTwC7TTRep3MY1iAebIi/izZSjZyVgoN5txO+CeLnUdK5CT3Q2yzbU3XP1JZyoQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2605 On 07.09.2021 16:55, Daniel P. Smith wrote: > On 9/7/21 10:27 AM, Jan Beulich wrote: >> On 07.09.2021 16:09, Daniel P. Smith wrote: >>> On 9/7/21 9:50 AM, Jan Beulich wrote: >>>> On 07.09.2021 15:41, Daniel P. Smith wrote: >>>>> On 9/6/21 2:17 PM, Andrew Cooper wrote: >>>>>> On 03/09/2021 20:06, Daniel P. Smith wrote: >>>>>>> --- a/xen/include/xsm/dummy.h >>>>>>> +++ b/xen/include/xsm/dummy.h >>>>>>> @@ -69,8 +69,9 @@ void __xsm_action_mismatch_detected(void); >>>>>>> =20 >>>>>>> #endif /* CONFIG_XSM */ >>>>>>> =20 >>>>>>> -static always_inline int xsm_default_action( >>>>>>> - xsm_default_t action, struct domain *src, struct domain *targe= t) >>>>>>> +static always_inline int xsm_default_action(xsm_default_t action, >>>>>>> + struct domain *src, >>>>>>> + struct domain *target) >>>>>> >>>>>> The old code is correct.=C2=A0 We have plenty of examples of this in= Xen, and >>>>>> I have been adding new ones when appropriate. >>>>>> >>>>>> It avoids squashing everything on the RHS and ballooning the line co= unt >>>>>> to compensate.=C2=A0 (This isn't a particularly bad example, but we'= ve had >>>>>> worse cases in the past). >>>>> >>>>> Based on the past discussions I understood either is acceptable and f= ind >>>>> this version much easier to visually parse myself. With that said, if >>>>> the "next line single indent" really is the preferred style by the >>>>> maintainers/community, then I can convert all of these over. >>>> >>>> I guess neither is the "preferred" style; as Andrew says, both are >>>> acceptable and both are in active use. I guess the rule of thumb is: >>>> The longer what's left of the function name, the more you should >>>> consider the style that you change away from. >>>> >>>> Anyway, in the end I guess the request for style adjustments was >>>> mainly to purge bad style, not to convert one acceptable form to >>>> another. Converting the entire file to the same style is of course >>>> fine (for producing a consistent result), but then - as per above - >>>> here it would more likely be the one that in this case was already >>>> there. >>> >>> Understood, I will respin with all the function defs to align with the= =20 >>> "next line single indent" style, though it would be helpful for=20 >>> clarification on this style exactly. Do you always wrap all args if one= =20 >>> extends past 80 col or is there a rule for when some should remain on=20 >>> the first line (function def line)? >> >> I don't think that aspect has been discussed. I would say >> >> void sufficiently_long_attribute test(unsigned int x, unsigned int y, >> unsigned int z, void *p); >> >> is as acceptable as >> >> void sufficiently_long_attribute test(unsigned int x, >> unsigned int y, >> unsigned int z, >> void *p); >> >> with a slight preference to the former. >=20 > Apologies, I was referring to this style which I am understanding is a > little more preferred >=20 > void short_function_name( > struct really_long__struct_name *x, > struct really_long__struct_name *y, unsigned int z, void *p); >=20 > vs >=20 > void short_function_name(struct really_long__struct_name *x, > struct really_long__struct_name *y, unsigned int z, void *p); This latter style is not supposed to be used. Jan From xen-devel-bounces@lists.xenproject.org Tue Sep 07 15:03:49 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 15:03:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.181162.328200 (Exim 4.92) (envelope-from ) id 1mNcdZ-00077q-7K; Tue, 07 Sep 2021 15:03:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 181162.328200; Tue, 07 Sep 2021 15:03:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNcdZ-00077j-3A; Tue, 07 Sep 2021 15:03:49 +0000 Received: by outflank-mailman (input) for mailman id 181162; Tue, 07 Sep 2021 15:03:48 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNcdX-00077d-VY for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 15:03:48 +0000 Received: from mailhost.m5p.com (unknown [74.104.188.4]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 31753929-94cc-4732-8916-55f8d079c637; Tue, 07 Sep 2021 15:03:46 +0000 (UTC) Received: from m5p.com (mailhost.m5p.com [IPv6:2001:470:1f07:15ff:0:0:0:f7]) by mailhost.m5p.com (8.16.1/8.15.2) with ESMTPS id 187F3a2o070616 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Tue, 7 Sep 2021 11:03:42 -0400 (EDT) (envelope-from ehem@m5p.com) Received: (from ehem@localhost) by m5p.com (8.16.1/8.15.2/Submit) id 187F3asv070615; Tue, 7 Sep 2021 08:03:36 -0700 (PDT) (envelope-from ehem) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 31753929-94cc-4732-8916-55f8d079c637 Date: Tue, 7 Sep 2021 08:03:36 -0700 From: Elliott Mitchell To: Jan Beulich Cc: xen-devel@lists.xenproject.org Subject: Re: HVM/PVH Balloon crash Message-ID: References: <84d9137e-a268-c3d8-57d2-76fb596e00d3@suse.com> <1b3d4cb1-ba61-0f61-5097-9978462a2401@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1b3d4cb1-ba61-0f61-5097-9978462a2401@suse.com> X-Spam-Status: No, score=0.4 required=10.0 tests=KHOP_HELO_FCRDNS autolearn=no autolearn_force=no version=3.4.5 X-Spam-Checker-Version: SpamAssassin 3.4.5 (2021-03-20) on mattapan.m5p.com On Tue, Sep 07, 2021 at 10:03:51AM +0200, Jan Beulich wrote: > On 06.09.2021 22:47, Elliott Mitchell wrote: > > On Mon, Sep 06, 2021 at 09:52:17AM +0200, Jan Beulich wrote: > >> On 06.09.2021 00:10, Elliott Mitchell wrote: > >>> I brought this up a while back, but it still appears to be present and > >>> the latest observations appear rather serious. > >>> > >>> I'm unsure of the entire set of conditions for reproduction. > >>> > >>> Domain 0 on this machine is PV (I think the BIOS enables the IOMMU, but > >>> this is an older AMD IOMMU). > >>> > >>> This has been confirmed with Xen 4.11 and Xen 4.14. This includes > >>> Debian's patches, but those are mostly backports or environment > >>> adjustments. > >>> > >>> Domain 0 is presently using a 4.19 kernel. > >>> > >>> The trigger is creating a HVM or PVH domain where memory does not equal > >>> maxmem. > >> > >> I take it you refer to "[PATCH] x86/pod: Do not fragment PoD memory > >> allocations" submitted very early this year? There you said the issue > >> was with a guest's maxmem exceeding host memory size. Here you seem to > >> be talking of PoD in its normal form of use. Personally I uses this > >> all the time (unless enabling PCI pass-through for a guest, for being > >> incompatible). I've not observed any badness as severe as you've > >> described. > > > > I've got very little idea what is occurring as I'm expecting to be doing > > ARM debugging, not x86 debugging. > > > > I was starting to wonder whether this was widespread or not. As such I > > was reporting the factors which might be different in my environment. > > > > The one which sticks out is the computer has an older AMD processor (you > > a 100% Intel shop?). > > No, AMD is as relevant to us as is Intel. > > > The processor has the AMD NPT feature, but a very > > early/limited IOMMU (according to Linux "AMD IOMMUv2 functionality not > > available"). > > > > Xen 4.14 refused to load the Domain 0 kernel as PVH (not enough of an > > IOMMU). > > That sounds odd at the first glance - PVH simply requires that there be > an (enabled) IOMMU. Hence the only thing I could imagine is that Xen > doesn't enable the IOMMU in the first place for some reason. Doesn't seem that odd to me. I don't know the differences between the first and second versions of the AMD IOMMU, but could well be v1 was judged not to have enough functionality to bother with. What this does make me wonder is, how much testing was done on systems with functioning NPT, but disabled IOMMU? Could be this system is in an intergenerational hole, and some spot in the PVH/HVM code makes an assumption of the presence of NPT guarantees presence of an operational IOMMU. Otherwise if there was some copy and paste while writing IOMMU code, some portion of the IOMMU code might be checking for presence of NPT instead of presence of IOMMU. -- (\___(\___(\______ --=> 8-) EHM <=-- ______/)___/)___/) \BS ( | ehem+sigmsg@m5p.com PGP 87145445 | ) / \_CS\ | _____ -O #include O- _____ | / _/ 8A19\___\_|_/58D2 7E3D DDF4 7BA6 <-PGP-> 41D1 B375 37D0 8714\_|_/___/5445 From xen-devel-bounces@lists.xenproject.org Tue Sep 07 15:30:36 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 15:30:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.181180.328211 (Exim 4.92) (envelope-from ) id 1mNd3G-0002Qp-Ah; Tue, 07 Sep 2021 15:30:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 181180.328211; Tue, 07 Sep 2021 15:30:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNd3G-0002Qi-6p; Tue, 07 Sep 2021 15:30:22 +0000 Received: by outflank-mailman (input) for mailman id 181180; Tue, 07 Sep 2021 15:30:20 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNd3E-0002Qc-Qs for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 15:30:20 +0000 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 823dd0b8-0ff0-11ec-b109-12813bfff9fa; Tue, 07 Sep 2021 15:30:19 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id A9E9B610D0; Tue, 7 Sep 2021 15:30:18 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 823dd0b8-0ff0-11ec-b109-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1631028619; bh=kp8Q8kJRz0WoYnZlxjaDlmj4GyxqVupLYpX0r3kh5eI=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=FE6OgWm/fxpyj4FLQwu9LoQuMjKnA94XCfxVDByukq4rictBgJBARDgnsuKZZf51p WXTFndXhgPK25xj8rW4dWKHHBd93KkRJMISbXYQeHJ0AMHoyWkddZYiARPkgRcGwBJ AT6niJGOnCXNPNvY3lbnqpZz36S29V/LYwGZE4/xaCHHf6512nYdVpZOaJSLMuZUoR sM+3SiKS+cOzVNn/u7KymTC8iwDRxTh24dDklEeX8z7qtgA+ZJj3kLfOVv0bv4A6b7 7vbe+oIWcT0eDqgNzqf+WJuR4rDw+5kM7nUIpdutwsL0sFBHvcbEN7fiD4Vb+EWH86 LY7D7/lwqLanA== Date: Tue, 7 Sep 2021 10:30:17 -0500 From: Bjorn Helgaas To: Jan Beulich Cc: Bjorn Helgaas , Stefano Stabellini , "xen-devel@lists.xenproject.org" , Juergen Gross , Boris Ostrovsky , "linux-pci@vger.kernel.org" Subject: Re: [PATCH 10/12] xen-pcifront: this module is PV-only Message-ID: <20210907153017.GA741607@bjorn-Precision-5520> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Update subject to follow conventions (use "git log --oneline drivers/pci/Kconfig"). Should say what this patch does. Commit log below should also say what this patch does. Currently it's part of the rationale for the change, but doesn't say what the patch does. On Tue, Sep 07, 2021 at 02:10:41PM +0200, Jan Beulich wrote: > It's module init function does a xen_pv_domain() check first thing. > Hence there's no point building it in non-PV configurations. s/It's// # xen-pcifront.o? I see that CONFIG_XEN_PV is only mentioned in arch/x86, so CONFIG_XEN_PV=y cannot be set on other arches. Is the current "depends on X86" just a reflection of that, or is it because of some other x86 dependency in the code? The connection between xen_pv_domain() and CONFIG_XEN_PV is not completely obvious. If you only build xen-pcifront.o when CONFIG_XEN_PV=y, and xen_pv_domain() is true if and only if CONFIG_XEN_PV=y, why bother calling xen_pv_domain() at all? > Signed-off-by: Jan Beulich > > --- a/drivers/pci/Kconfig > +++ b/drivers/pci/Kconfig > @@ -110,7 +110,7 @@ config PCI_PF_STUB > > config XEN_PCIDEV_FRONTEND > tristate "Xen PCI Frontend" > - depends on X86 && XEN > + depends on XEN_PV > select PCI_XEN > select XEN_XENBUS_FRONTEND > default y > From xen-devel-bounces@lists.xenproject.org Tue Sep 07 15:57:26 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 15:57:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.181187.328222 (Exim 4.92) (envelope-from ) id 1mNdTL-0005nr-It; Tue, 07 Sep 2021 15:57:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 181187.328222; Tue, 07 Sep 2021 15:57:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNdTL-0005nk-Dd; Tue, 07 Sep 2021 15:57:19 +0000 Received: by outflank-mailman (input) for mailman id 181187; Tue, 07 Sep 2021 15:57:18 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNdTK-0005nb-Bs for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 15:57:18 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 45e2d060-0ff4-11ec-b10b-12813bfff9fa; Tue, 07 Sep 2021 15:57:16 +0000 (UTC) Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-am5eur02lp2050.outbound.protection.outlook.com [104.47.4.50]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-17-a6zWnPUFMfahP0fn_KPTRQ-1; Tue, 07 Sep 2021 17:57:14 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR0402MB3773.eurprd04.prod.outlook.com (2603:10a6:803:1c::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.22; Tue, 7 Sep 2021 15:57:13 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4500.014; Tue, 7 Sep 2021 15:57:13 +0000 Received: from [10.156.60.236] (37.24.206.209) by PR3P189CA0028.EURP189.PROD.OUTLOOK.COM (2603:10a6:102:52::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.22 via Frontend Transport; Tue, 7 Sep 2021 15:57:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 45e2d060-0ff4-11ec-b10b-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1631030235; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3em18/5I60ro58fWzw7m4WZD8kA9dd11ewhblexpUAc=; b=W7JkEt7mqQxUofae3Gvi0oKNuAFHeAPAcEuLlTFjWb4f3C9mrUfC8fhX2x/ldJPN60UFMS 7uHvVCZbtjBGwaNFMDq++Qzq8yNo3m27I7+DALfszTksKRYOl6FcLX4/y44+T35HsJHd4c lQGP7U6Owhq47rqrkeOOw6jz5gUt+n4= X-MC-Unique: a6zWnPUFMfahP0fn_KPTRQ-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QpoW4jOkG792Rsx+dZiz6nck9Pva6+FaiX24JBxU1GgOSIQ+oYipDalrXbT68eQPadgNVLnn1wpN/DD3aMJsy+r7wXbSU3unAwuLyBA/eZ+Gr/cc63I8noTm4kfb5jUzJHa6nAH9nT76KWESGwlE/kdboRCBJx7XaB+PqrAnAoYZ9SS7mPpz5emJRwUtTEzcLVgsQwmc5Lw7wtm6swmWFPgYjdMrk+DdVY6O/CXDoyOYRSgLq3P26cLk2T47mMz+UWKwUQc/6I+wO0gThWZeiMBLqiKH9swvW/Qb/xWXOs/WmaMFWT8FhMrxX6M4WpZ5j7vtjenJUzw1Q0tIH9yckg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=3em18/5I60ro58fWzw7m4WZD8kA9dd11ewhblexpUAc=; b=if4/rzahEFo09d7dOQ7Io9ZebCIXM9vZmBMPeMIaoLCenDifVp+lo1CV3nD79TUbNQk/pTjVwaY0tX3LPmpodz0L+57PMwm2Gc3vWOba3RvJFZimvP10aB7LcA2bUa7AJ7q1CR5RvRAxQ60wPq2PZsviHKfe6Pu8FkI2mXMEXIznSpDqV6xQEYe5RWK7bpLwKN/JfidFE5np+3P+dvuivZoMboGqfV+auVaOUpWRidAwMsXhESk4LLHmTA6Wb5UWs0X0r5E8ICnZyhqA47z1qa3mTiqmyMQiEBDRlZhj/npqFbwFTWNLbNrtVbq6w0y8LEHnbsHeockrzK76c6COYQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com; Subject: Re: HVM/PVH Balloon crash To: Elliott Mitchell Cc: xen-devel@lists.xenproject.org References: <84d9137e-a268-c3d8-57d2-76fb596e00d3@suse.com> <1b3d4cb1-ba61-0f61-5097-9978462a2401@suse.com> From: Jan Beulich Message-ID: <935dc03f-74f5-4b49-3a45-71148364fb5a@suse.com> Date: Tue, 7 Sep 2021 17:57:10 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PR3P189CA0028.EURP189.PROD.OUTLOOK.COM (2603:10a6:102:52::33) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 846c4bf9-f7fc-474c-a1d5-08d972182823 X-MS-TrafficTypeDiagnostic: VI1PR0402MB3773: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: d0mRHbZmgAh5qW+PhDiGMMNv946vWuZ0u1m+5/CyUf9pAuHSvPe/VQcfPQhAcwrKLTgnpZ07Tpac015kwc0vb8lDBrGETZZyqFXPbxTEveAYlt67g1M7te55uxKrgjIwL09V5w0cLbCb851fWcxndHpxi42/+HptRwZNe8N40G0YCQqZrO5wOqg1MVuM5sz5V8iq5nPAcCRq6dmixmep4kmIPDeLdLZu6TLIY1x2qc0XetUSdS9exaE7o1bvwfXrlS+lkrmVVwRUgK9beg0tgDR9pQHf36YsoGYSu178xlJAneGQL3X+BWSWSdlc3zbpE8v8B89PQJRQRCT7iZOK33OSSvydCs2YHHrpfOw+1iWOE/c3TOKtyEvHxVf1K3o7B1hV3KCkep4kdFe5QXEdByk0CCwzyz0voPuC+J2rteFaWOdSWPqEyOL5dU6dM4D8SIXeFeyKRPv87oETPOJ2t60lzfHHKaowkfzx6ibXMEuGSd92rWv9vFqNGbdQgnJwUsbb+Yw73WtYBqAnmdVDa3DIk9XdWiBCcZHBA4yW56wmx62URA+bqmxrt6kHg6Uc30fpyusKiwTQE45EBAu5iqpWRU/CjFb1qY8Gmj0mL5MSd60eDjVLs2QaQiNj9Nm2516ozVg4lgfn665Pma0iIOorx78qyqdEpHQr7IRDIZM2DrrcQcPOMulU9vetwnBE8cC8uHlFfkSnI9X8ko5uUW4TEx46KcvmRONPzkwEhOcBjtjM02CLQMpslHpNwIMj X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(2616005)(956004)(2906002)(26005)(8676002)(508600001)(38100700002)(3480700007)(31696002)(86362001)(6486002)(4326008)(83380400001)(5660300002)(53546011)(8936002)(31686004)(36756003)(186003)(66476007)(316002)(16576012)(66946007)(66556008)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aWFCNld3M1R1VUdObVc0ZVAwbkFXYUJxd21zd01YQ2xoUHNkWForUERUZkY5?= =?utf-8?B?ZFdvbUZpQXFiVGd2TEswTTdvSmFvME5PZFJRZWhBT2VWR0lLM2NMd0pWUTg3?= =?utf-8?B?QzdUMENjbXhPN05PN1NXUUVFUjRFWldqZU5QVEtiVW5LN1ZxVTc5MHRQSVY5?= =?utf-8?B?Z1N4amRoKzE0WjlKcEhheEUxQWc4VzU3Zm9DZjRRR24zRHA5c2JsdGtZbGF6?= =?utf-8?B?aWxTbEI4WllYbnJoTkZsQ3NMMUJ3Rm5mMWhGcEJETGhlN0ZJR2VxdHlkRFlH?= =?utf-8?B?MW8wS1ltS0VHWXVKK2F2QWhySThjbmxlaGZxVy91TjhzcmxMeUNRSUkwUy9T?= =?utf-8?B?NEQwaEwvOUlXMVY0V0VDR2MrNFJpWnh3TzJpZnpPUGlEdkZCZXd0SmQ3U3Rs?= =?utf-8?B?T213aUIveFVCU0EwWExSeEpIQ2dKRGthdFdOb1F5NEh1eTZwM1JLMDd6RkNw?= =?utf-8?B?Y0tta3JuY1FkOHFmcCtZbmFLVjZEMytFYlorZmRaSjdlSDQ0ckJJbUZWakRw?= =?utf-8?B?QWJ1SGtFUUIrUi95SklCVFg0bUNjSThYZWY3bXFwYjN2NjdvRXBqUmN4VTIx?= =?utf-8?B?ZzdjckFpY2E1SkowdWt2ZkpSRG9JeSt2S2thNzRhSUdpTGpJOGM1aThGajR5?= =?utf-8?B?RDM4bktKQmt6VjNxT2QzZ0xISjlxR2RuMHNCWUFJd2phQUY4amFiMmE2TGw3?= =?utf-8?B?Yit0b3ZlMVE4aGZZemxIQklVVzN1eGx4N09qMm9Rc1h2anpGcTFZNzllZjI5?= =?utf-8?B?NmViQno1L2h0T3VMQkUrZ0Q5ODVnSlNoUGdEc2ExdHBnWjVJaHRaN3ZNc2RV?= =?utf-8?B?QWdacEhFV2NaaWpvMzRyMGRIVm1FOXdOUmlpVEMwOGRKbXl1NGFsYnc1RUky?= =?utf-8?B?RnJXQ0xIOG83L2Q5K1M0RitZMEVtS3dsMExCbWNwQ05xZ1B5NHhaSko5cVA3?= =?utf-8?B?S21POG1kTXJoVnJNTksxR052MFdzdlRxTlEwbVFMWEg4QWV2eHJWeGQ2TmRE?= =?utf-8?B?bDdoU3pRYzNrRnBieTlLNkN1bFluYlUwazVlS1dtWndQUmlQNk9qcEhWNlJJ?= =?utf-8?B?a2ttV3Q0b1lzT0paQWdrczd3aWN4Q0JpdTIxcHJkZ3ZvVzlyRkR5aTBENENt?= =?utf-8?B?VzhmcFVHN2MvSmp1ZG5sVTZ2M0tGcTYxQ2dvaVNwZVdKMWo2Wm1hdm1jb24w?= =?utf-8?B?STJORXRmamlsbHdLZFJBdWZJUTR1Nm5OYW12ZnM1Zm1jenRtYjBFLzA2SmUw?= =?utf-8?B?Y1JKbWc2MHpkTXd1QS94eEk0R0djWUhGeVRpbjh3dW0rajczZ05TS1hIMXhF?= =?utf-8?B?b2hQOVdZbjJ5WFZobEJ2ekVQQjhnZUlGVEdlS1RCaGF0bzF6UmxRU0xFekdl?= =?utf-8?B?RG5BajE0V01JNThDYURMb1hmODA2aEVPUzN0Vi9Ib0JCSHdlc2xEdktOczNh?= =?utf-8?B?ZGVxR0FHTmw0S1pPM0s3ZVg3TlN5Rk1NM1ZkVjdKN1pGOU81bXFVb2dCbFIw?= =?utf-8?B?WXpTSGs2UzNoc05DR09ybTBWNmtBRFpCdGZNQW1ESW93N1lHaFJDWklFTDRt?= =?utf-8?B?N05HbmtIckoxa1RZUVZwQWpnWjRDcnhXZFVkK2hGWUhtYmhtM2MwZXBEN2ww?= =?utf-8?B?ME10dXZVYXVEM3lCM1pOM0lmOStuOWY1RVBDbWgwY29FN2xyNTZRZXMwV2x6?= =?utf-8?B?ZWdyNE5ERFdmNlpxS1JoU3VPZGFtNVI5K3pVQVJUV1NoRUNLd1Q2MHJPdE1m?= =?utf-8?Q?eATeJTxVDjgAQOx3Nm5p4wcSNIo7+K4XVT8xE4W?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 846c4bf9-f7fc-474c-a1d5-08d972182823 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2021 15:57:13.0059 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: OrwKDx90gigXjgsT5XnkrEZ1dzmNZNpHrJi2GedM66wGUuT6+m963HpPLdLY9p9zMzeYFGrnNC2ugznAiky7Yw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3773 On 07.09.2021 17:03, Elliott Mitchell wrote: > On Tue, Sep 07, 2021 at 10:03:51AM +0200, Jan Beulich wrote: >> On 06.09.2021 22:47, Elliott Mitchell wrote: >>> On Mon, Sep 06, 2021 at 09:52:17AM +0200, Jan Beulich wrote: >>>> On 06.09.2021 00:10, Elliott Mitchell wrote: >>>>> I brought this up a while back, but it still appears to be present and >>>>> the latest observations appear rather serious. >>>>> >>>>> I'm unsure of the entire set of conditions for reproduction. >>>>> >>>>> Domain 0 on this machine is PV (I think the BIOS enables the IOMMU, but >>>>> this is an older AMD IOMMU). >>>>> >>>>> This has been confirmed with Xen 4.11 and Xen 4.14. This includes >>>>> Debian's patches, but those are mostly backports or environment >>>>> adjustments. >>>>> >>>>> Domain 0 is presently using a 4.19 kernel. >>>>> >>>>> The trigger is creating a HVM or PVH domain where memory does not equal >>>>> maxmem. >>>> >>>> I take it you refer to "[PATCH] x86/pod: Do not fragment PoD memory >>>> allocations" submitted very early this year? There you said the issue >>>> was with a guest's maxmem exceeding host memory size. Here you seem to >>>> be talking of PoD in its normal form of use. Personally I uses this >>>> all the time (unless enabling PCI pass-through for a guest, for being >>>> incompatible). I've not observed any badness as severe as you've >>>> described. >>> >>> I've got very little idea what is occurring as I'm expecting to be doing >>> ARM debugging, not x86 debugging. >>> >>> I was starting to wonder whether this was widespread or not. As such I >>> was reporting the factors which might be different in my environment. >>> >>> The one which sticks out is the computer has an older AMD processor (you >>> a 100% Intel shop?). >> >> No, AMD is as relevant to us as is Intel. >> >>> The processor has the AMD NPT feature, but a very >>> early/limited IOMMU (according to Linux "AMD IOMMUv2 functionality not >>> available"). >>> >>> Xen 4.14 refused to load the Domain 0 kernel as PVH (not enough of an >>> IOMMU). >> >> That sounds odd at the first glance - PVH simply requires that there be >> an (enabled) IOMMU. Hence the only thing I could imagine is that Xen >> doesn't enable the IOMMU in the first place for some reason. > > Doesn't seem that odd to me. I don't know the differences between the > first and second versions of the AMD IOMMU, but could well be v1 was > judged not to have enough functionality to bother with. > > What this does make me wonder is, how much testing was done on systems > with functioning NPT, but disabled IOMMU? No idea. During development is may happen (rarely) that one disables the IOMMU on purpose. Beyond that - can't tell. > Could be this system is in an > intergenerational hole, and some spot in the PVH/HVM code makes an > assumption of the presence of NPT guarantees presence of an operational > IOMMU. Otherwise if there was some copy and paste while writing IOMMU > code, some portion of the IOMMU code might be checking for presence of > NPT instead of presence of IOMMU. This is all very speculative; I consider what you suspect not very likely, but also not entirely impossible. This is not the least because for a long time we've been running without shared page tables on AMD. I'm afraid without technical data and without knowing how to repro, I don't see a way forward here. Jan From xen-devel-bounces@lists.xenproject.org Tue Sep 07 16:13:29 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 16:13:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.181193.328233 (Exim 4.92) (envelope-from ) id 1mNdiq-0000lz-V1; Tue, 07 Sep 2021 16:13:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 181193.328233; Tue, 07 Sep 2021 16:13:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNdiq-0000ls-QD; Tue, 07 Sep 2021 16:13:20 +0000 Received: by outflank-mailman (input) for mailman id 181193; Tue, 07 Sep 2021 16:13:19 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNdip-0000lm-JN for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 16:13:19 +0000 Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 831eba64-0ff6-11ec-b110-12813bfff9fa; Tue, 07 Sep 2021 16:13:18 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 831eba64-0ff6-11ec-b110-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1631031198; h=to:cc:references:from:subject:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=ZjBGaPM2bSvNwBtVv/unW1+T+h+jUN3bJ5+Rg602PtM=; b=Suq7z8Hhrh6HmFyY+pCiQOvazipPLEjieCpI7alDsemkrVcLTnSWD9DP +EseKAm2DOvWRsHf94RJsktjFQfgeQTTGwoc6H2M17vyQyQ8g/SjueQgI ft42fCAjvTF6VXHdh5qD2oQGwNyPDGOqLfHeQ+sZQjc9HHJPsjwFN31HG M=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: WeDhx3aZTsNwSrUt37wthJ203zdY78m4pOa6SDNNYr5t0GRjpqseDuASX5YpLqgC4jl2ewWWch d8f2CBraCCkGMPkrasv8pOtI/JaxV6DduaNkzHVV6oVwNft8VKpC/Ht70MEAjdtT64c5D5yTql PTKx/gi37ftDkVUPh4VeAG/tRPFJYv8duy8Vc0QrV//oEz/uoPhTEicKk/lzO0XMRpJqdmwdkl Lsm2QNq4NFP9Ib7ku743FRepIPgknZWsy2uZZ4L1KPi+dceRzV7vHQvYlQiEQB8FcnBuia80Fc lR5UXWG7Em49TbEUJ+6tgPbK X-SBRS: 5.1 X-MesageID: 52577414 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:Diz7g6NVyot3dcBcT1b155DYdb4zR+YMi2TDiHofdfUFSKClfp 6V8cjztSWUtN4QMEtQ/OxoS5PwPk80kqQFnbX5XI3SITUO3VHHEGgM1/qb/9SNIVyYygcZ79 YbT0EcMqyBMbEZt7eC3ODQKb9Jq7PmgcPY9ts2jU0dKT2CA5sQnjuRYTzrdHGeKjM2Z6bRWK Dsnfau8FGbCAoqh4mAdzU4dtmGg+eOuIPtYBYACRJiwA6SjQmw4Lq/NxSDxB8RXx5G3L9nqA H+4kLEz5Tml8v+5g7X1mfV4ZgTsNz9yuFbDMjJrsQOMD3jhiuheYwkcbyfuzIepv2p9T8R4Z bxiiZlG/42x2Laf2mzrxeo8w780Aw243un8lOciWuLm72zeBsKT+56wa5JeBrQ7EQt+Ptm1r hQ4m6fv51LSTvdgSXU/bHzJlJXv3vxhUBnvf8YjnRZX4dbQqRWt5Yj8ERcF4pFND7m6bogDP JlAKjnlbZrmGuhHjXkV1RUsZiRtixZJGbAfqFCgL3V79FupgE686NCr/Zv2Evp9/oGOtF5Dq r/Q/1VfBwndL5gUUtHPpZ1fSKAMB2Fffv9ChPhHb3ZLtByB5vske+83Fxn3pDmRHQ3pKFC7q gpFmko7VIPRw== X-IronPort-AV: E=Sophos;i="5.85,274,1624334400"; d="scan'208";a="52577414" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=K7SlWlGwaXyjVtbqpkeq/EzSChgvLRV7UjG0eOT04HZDkCqujU+wBlpWeVuRjFpwMtyBVsxB5ODz944gHYHp2JP24QJ3aKw2k3+HYr/19u/2XX0bkzDE85mvTZFbXEWGNbWViqr3OCX/1H4QIfyIoLgP4sH3lyAJhk4ZuEnfU7EwB8Ypf55URoleztL2ds+BeeVZaBdKJ3yFrzP+uYMCjIjSgjN6twb/pfPGB9NETYyageS2+5j5niPIqtQNA3r6ZprJeJVGkqVasWhfvesrdZlmYqkEcIgduWVJcMy2xjhwpATwZFQlsLFpb9+g/GbyEX+dDRuktKtOoSoM9N1czA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=8OsbXCrpG5uZi/MCeMp64W912DDWz+WDnlhKCE3efRQ=; b=H0cSJ4A8CTdxL5zQNVo07fwWmN5V+yy5yAT3R/DCY86JaE78upTgbLcAMGhDHvMMppiKcYbVCETyiblKgaJ98CGLqOubYcIgVtPPMqMf+dXz1Xp5f7RDFOnjm2LsZdo4v834Dj0IqhtrPB7HqO3cgzFRBYry/7l512fPZWJchpEVINbz0PdyLpzEjtdnQBs5g+vyoeb+xg3t6cecPA6ya2vRAQC6dgrk9rj7jQwJ6VfTl+YfiyHOLjWnd/8lAX775cwWbsYUQcHlOOdzvgk/am8CJLXS5fEdVMpioN/xM7U4Lc1vf8cibOCLV3PKOJEJDadwbdouKvWsmWUnXJ2yWw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8OsbXCrpG5uZi/MCeMp64W912DDWz+WDnlhKCE3efRQ=; b=lob7k9njJbxxKgxlsS8UXQYaDZfWtmybmGy7fmIrpXBSVycyLd8Qr1tW7U1pz5XM0GrakzPrLJOozaU8ihMg5lCjCIv83q9bLldb5Omq4/n88ZiZG5akNwkiD0+if++A3bEY7nL46FtZ8FaOfsB3M/5TNT3XltVnhTCRtpmTocI= To: Jan Beulich CC: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Xen-devel References: <20210817143006.2821-1-andrew.cooper3@citrix.com> <20210817143006.2821-3-andrew.cooper3@citrix.com> <606ce242-65d9-2180-8330-525fe5ec5562@suse.com> <351b2066-d01f-16d2-f1a0-bd7e2fe0965a@citrix.com> <968441f7-cf76-c98d-b256-18416ceca3bc@suse.com> From: Andrew Cooper Subject: Re: [PATCH 2/3] x86/amd: Enumeration for speculative features/hints Message-ID: Date: Tue, 7 Sep 2021 17:12:52 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 In-Reply-To: <968441f7-cf76-c98d-b256-18416ceca3bc@suse.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: en-GB X-ClientProxiedBy: LO4P123CA0481.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a8::18) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5bbbcd21-5fbb-4d72-079c-08d9721a5c03 X-MS-TrafficTypeDiagnostic: BYAPR03MB3991: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: SiMMn9rSfPUqZ3BZ1FYuZoG/04MkPPSORo24oa2zUKk1hCGcA9I459LTu4HbMMLRaFFT8fuyqV73wVvrrBEYf5unGDlbYAo5cJo3th/xz48G7g2IIyD5cO76KRg/I+iKtQ/ZVgoic00p4GlOs5K3mHyFEEYELV0h1EgiGDlZBhrUSv5Dn528we3bIbyi6Y7kq0T75TIVVhao7iomumjNbH2qWepka5loYMOb6xz4FwjyAIPD12PVk9J4yki+tLL7lnkiixwC41IZGOTSwOQhQMOVL16GahQiJqEyF5zUtQctwofFqGjH7bkvrdANxywHoEwTO8wmSYiiqAU0ItfR+WYS9ED4YCnRHu/XaYhw9131a11YjnU6BstVSuoakwFwSnRfKRfELmKYwi64QXAtJpJadnPFZMpwEAdIxX0vKSan6mJ0Mjy/VYnjQYpzRMEaKPo7klLO3Z1Ov2LSX8khH4/OYg7Y1hJk7iTpMrHnzjd2tA6FpsOfiW6hmlU1hJqqwnw5Dt0/rHUe7wKm9kW5kM4WecHzHVQYZY6iVClP+wYYzlTWBcxRnVHqvyzk5aLkqDrCT9aLrmOK6AN4jP9lYPPLhUgrKY5JGTYslBleQuFFM4xwkY8IcnlMxmbSCa3+eghykdbjUXL5ImsbSSKSSLQt/vwataEVykIKqEsC1kVbn2cFX5A88vf1rBG2nPXd52E6mGsLQinKteUANXhttsI8r+woK+sueCTjEoHgA/Y= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(39860400002)(376002)(366004)(396003)(136003)(4326008)(86362001)(31696002)(66476007)(66556008)(66946007)(38100700002)(6916009)(16576012)(316002)(54906003)(2616005)(2906002)(5660300002)(31686004)(36756003)(478600001)(6666004)(6486002)(26005)(8936002)(8676002)(186003)(83380400001)(55236004)(956004)(53546011)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YjRVYVE2QkZTSThzV1FpYkROK0VVMnFodmVzV0xSQ1NxOGFoWGxBM2dLOVBx?= =?utf-8?B?cEhqRlBveXVXMHVhaXZiVmhvTmEvalNtS1AvR1pwTG1Lck40Y0w3eE5oVHE5?= =?utf-8?B?QnNrakNkeGhsNUhLa0FkeXZudGR4NDJWTzQvR1psanZPcksvMnFzT3QzWVFk?= =?utf-8?B?dldKSW80TUNzMkFTZGt5K0MxWktrNlFlTjNXTGpvZzFTTG5ZNjNCanF3ZDdO?= =?utf-8?B?R2I0aWtyZW9xakJCa05nMEIyaXJyRFNudW5GTE9kS1FVRGxFN3ByS2U0SE1M?= =?utf-8?B?NVhhL3BFUXRvZ1ZIQUs5NVVCUC9PRFM5eXpUWS9oQUNkMnlJM2RvSVhhaFky?= =?utf-8?B?R3hwZ2NrWWMyaXQ3aDBZWkpqYWN4ZFRLeGlSN1MxZVpDcGY0dTVxS1RDSXJa?= =?utf-8?B?bnZqaGt3Zlo1K3g0SDhkWTBrWmhEdnFKa3lSWEtnS2NINWxUZlNVcW9nN3dy?= =?utf-8?B?dGhocU45bXEwZHR5cWxtMFFCYmRGTHBjaVltMnI1WGRmVWZzNXo5dUMxekNT?= =?utf-8?B?R0F6UDdtaWZqY2ZCRjFTeHo3MDJRNUFQMkg0ZUpIT0lnMnlmM2ZWVGlsREZD?= =?utf-8?B?aDhGNVBIMnBoM0ZFVnlNNjlYNmwwWlR0ZEtqRng3UU5BYk5SRzBRVUVZQTZR?= =?utf-8?B?M2hJZ0NUL0RYM3ExYjN6R1hYcDU4bWgxU0tYWmJpVHlRK0tqc2wwNHVxZzJJ?= =?utf-8?B?YnVXT1ZSdDlLTzE2UTAyc0EzSU1zRDd1SEVxekN2dVJGU1lDVlJCdGNKRm5l?= =?utf-8?B?V1lYejAzT1N2dC9zT2Z6b0s5endhTHMvYTBtdDAxcFJKMVA5OVFOWWRKZ0tO?= =?utf-8?B?MjFtS2t2SG1zNHNxY09BT3FjUkZyNFpEdXFOQTRkNlVKdFBqNUZidC9vZlk4?= =?utf-8?B?YnVTZW5zdXExbG90UGVNTE1mWmRVOEI2eWJZYXBlM3UxdmdISWZCaFdaVmNa?= =?utf-8?B?aVFwSk5uQ29DaFhJdTlqNVY2alpjVExSQ3VVVjF0SUlUTVViOFBKMG5DZncw?= =?utf-8?B?M0ZiQlZveEgrT1ZjSkwyTFFxRytlZ3psZXF1K0VxTCt6MFBmaFJndVNyVDZ6?= =?utf-8?B?QTI4NkdCeTQ5RVdwTkZNN3V0KzJ2blpZdEJJeVo2MzFFM1ZWOU5RSVVSdHpq?= =?utf-8?B?SmtkYThiY3BKcDEweTY5aU1RN0VucTg4bDZzdkhMZ0tXRXVVWEZxYVgrb2Yx?= =?utf-8?B?UFRpa1pVZXdSdk5UN3VkeCsvSFBSYW14TmZsbWM0OWIrbXVneDdLM3FvRytS?= =?utf-8?B?WWg3Z0RpYWhBZkc0Y1JRVmNvNVRNdC8rczNQcFpaRTBZN1l3Sjc1ai9UUzRq?= =?utf-8?B?dFphZkNySkxndXNaYTNlNjRqVTJqd3oyeUc0K0h5cURjSUdERDNYN0IyOVo0?= =?utf-8?B?ZFFmSXRDM2lTZXp0Z0RtYjFoMy9UVkdpS3BOZm1pejRqOXM5NTdEMzMrd1Fx?= =?utf-8?B?bStjVjlVMmc2U2xsTlkwcnRVNXBrUGtVRFF3YUdIWnVnblh1b1Rwd3VBcU1p?= =?utf-8?B?cmc2Q1ZLZWkrTEJiTG16NFA0MVZIZG5XQkQ2NjFPQ082TkdiYmJzZmFZNHk4?= =?utf-8?B?NVRyMVFjWE9lT0dxNEZqOVZpTlN2V0oya3RvMFYzdUpvdU9kUUdmdkRMNHpX?= =?utf-8?B?dmtaNEdNTHR1aVJrdHgrem9TSml1SEJSTjRXL2QwOGpDcjdMekUzb2MyMFVF?= =?utf-8?B?dytiQU9mdlpqbmh1ZExOdzZZckQ5enA5ZVB0Um11eTd4M1ZJK1RmOExTVllS?= =?utf-8?Q?Pc6AYEOC/nKIyXbEwTvnQW46ugiEZdQH2omQENJ?= X-MS-Exchange-CrossTenant-Network-Message-Id: 5bbbcd21-5fbb-4d72-079c-08d9721a5c03 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2021 16:12:58.9333 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bmBz/ID+jSTgP4p0zJ0TZdweuND9APX95qKzOphWDRv5jvEdK74LGcSzIt2KhIUbGJSczHWNbjNM85GWZGchk0I1K/CSMvvf+q1b3ahSHkI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB3991 X-OriginatorOrg: citrix.com On 24/08/2021 16:15, Jan Beulich wrote: > On 24.08.2021 15:26, Andrew Cooper wrote: >> On 19/08/2021 15:47, Jan Beulich wrote: >>> On 17.08.2021 16:30, Andrew Cooper wrote: >>>> There is a step change in speculation protections between the Zen1 and= Zen2 >>>> microarchitectures. >>>> >>>> Zen1 and older have no special support. Control bits in non-architect= ural >>>> MSRs are used to make lfence be dispatch-serialising (Spectre v1), and= to >>>> disable Memory Disambiguation (Speculative Store Bypass). IBPB was >>>> retrofitted in a microcode update, and software methods are required f= or >>>> Spectre v2 protections. >>>> >>>> Because the bit controlling Memory Disambiguation is model specific, >>>> hypervisors are expected to expose a MSR_VIRT_SPEC_CTRL interface whic= h >>>> abstracts the model specific details. >>>> >>>> Zen2 and later implement the MSR_SPEC_CTRL interface in hardware, and >>>> virtualise the interface for HVM guests to use. A number of hint bits= are >>>> specified too to help guide OS software to the most efficient mitigati= on >>>> strategy. >>>> >>>> Zen3 introduced a new feature, Predictive Store Forwarding, along with= a >>>> control to disable it in sensitive code. >>>> >>>> Add CPUID and VMCB details for all the new functionality. >>>> >>>> Signed-off-by: Andrew Cooper >>> Reviewed-by: Jan Beulich >>> with one suggestion: >>> >>>> --- a/tools/libs/light/libxl_cpuid.c >>>> +++ b/tools/libs/light/libxl_cpuid.c >>>> @@ -274,8 +274,18 @@ int libxl_cpuid_parse_config(libxl_cpuid_policy_l= ist *cpuid, const char* str) >>>> {"rstr-fp-err-ptrs", 0x80000008, NA, CPUID_REG_EBX, 2, 1}, >>>> {"wbnoinvd", 0x80000008, NA, CPUID_REG_EBX, 9, 1}, >>>> {"ibpb", 0x80000008, NA, CPUID_REG_EBX, 12, 1}, >>>> + {"ibrs", 0x80000008, NA, CPUID_REG_EBX, 14, 1}, >>>> + {"amd-stibp", 0x80000008, NA, CPUID_REG_EBX, 15, 1}, >>>> + {"ibrs-always", 0x80000008, NA, CPUID_REG_EBX, 16, 1}, >>>> + {"stibp-always", 0x80000008, NA, CPUID_REG_EBX, 17, 1}, >>>> + {"ibrs-fast", 0x80000008, NA, CPUID_REG_EBX, 18, 1}, >>>> + {"ibrs-same-mode", 0x80000008, NA, CPUID_REG_EBX, 19, 1}, >>> Here and below, how about dropping the "mode" part of the name? >>> I can't seem to be able to think of any other "same" that could >>> possibly apply here. >> ibrs-same is very ambiguous. > I'm curious as to why you think so. Same what?=C2=A0 There are load of plausible options, e.g. "privilege". "mode" is the second most important piece of info, behind ibrs. > >> =C2=A0 The only other reasonable reasonable >> alternative I can think of is ibrs-psmp as an abbreviation for >> ProvideSameModeProtection.=C2=A0 Obviously, the "Provides" bit of that c= an't >> be dropped. > Then better stay with what you have I would say - for me "psmp" > immediately raises the question "What strange kind of SMP?" > While not tied to any formal naming, I could see "ibrs-sm" as > an option ... That's an initialisation of a shortening, and too far removed from the original context IMO. Given nothing better, I'll stick with ibrs-same-mode. ~Andrew From xen-devel-bounces@lists.xenproject.org Tue Sep 07 16:14:27 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 16:14:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.181200.328243 (Exim 4.92) (envelope-from ) id 1mNdjv-0001Ok-B4; Tue, 07 Sep 2021 16:14:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 181200.328243; Tue, 07 Sep 2021 16:14:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNdjv-0001Od-89; Tue, 07 Sep 2021 16:14:27 +0000 Received: by outflank-mailman (input) for mailman id 181200; Tue, 07 Sep 2021 16:14:25 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNdjt-0001OL-Ld for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 16:14:25 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 30c8a34e-73ef-4329-8462-3bcbdaadde8d; Tue, 07 Sep 2021 16:14:24 +0000 (UTC) Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-am5eur03lp2053.outbound.protection.outlook.com [104.47.8.53]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-16-YfMEg0chOuetOUYREYE7pg-1; Tue, 07 Sep 2021 18:14:22 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR0401MB2448.eurprd04.prod.outlook.com (2603:10a6:800:52::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.22; Tue, 7 Sep 2021 16:14:18 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4500.014; Tue, 7 Sep 2021 16:14:18 +0000 Received: from [10.156.60.236] (37.24.206.209) by PR3PR09CA0027.eurprd09.prod.outlook.com (2603:10a6:102:b7::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14 via Frontend Transport; Tue, 7 Sep 2021 16:14:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 30c8a34e-73ef-4329-8462-3bcbdaadde8d DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1631031263; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LcbSHEuJ/n74+zmRLZEo33hTo1f5VMgflTIa8T0fZDo=; b=awOxYUlK1ZNufIwFjdxTMmqQAM3jdP9MYKCQ52OAXAic1RTyE7d3Haiv/dRnuXZfK+OptC nmi/xn7aUPerdG+kqbRnC6bh/LB++13qBa+S87eaPLFE/xd5F0p2Ft1cBpCJNOF2sKRYBw yU0tfPIG8oFBNnRIF3GLnofmTjhj/J0= X-MC-Unique: YfMEg0chOuetOUYREYE7pg-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=O3x2M6ZNPBorl0v/ebyO/SUSa6mf94oeLXF8VSaWjisitGFKx+VnZOSNKsjdeK+OC8gssgIH3Ttl1UQcogKgGCqqQ55wppPCifo4NAZnBe0QovFu1L4bnMkC8+jjgaSK4uedNlZxj/ZJvcXPadD99Vwb0BMvUhtYksdm4XWeb2QaVHHDKq5GZcvT1/r+yV8YUw+nd7lokoJZQRl6TU5JKZ1zQ61NrPIMct5rp+oiHMqRODHvkrnG/Na2W6D/5Nm4RXfA6urjYvf5+wLnNMVOw6l1Q05eqGnagKOVCza2VWG8wmSWLsMbxMfVUEanRhaGuIvQcYQPogs5UpES9zJszA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=LcbSHEuJ/n74+zmRLZEo33hTo1f5VMgflTIa8T0fZDo=; b=hlECaybXcC4+Gqa0ZwV4tIXbyv1K0tcfdO0905bXclPl03sBWJcmqDkXofYLTXOiRZCev3CIIUjEWvaCGMgUx5itykjLU1t4uj3MH88agT3otTrO5HMq/hdDybDiIXoUQxsff0qlygti68A/W6WFnfr9lsEIZi49N9RTKQBnGzzAf9I49ITsZt6TEfTSz2Iqg6KeazRxE908KkzLP3V5XHt4K9ftHh2t1d2UfM3okwqUjBWq75LEtJ5GD2rneVlrOrX1il9gcbm9f9+sd9QVY0VI83KkeC4CMydYFbKyXn+pwb6uSJt/Eav8rwAixcpaJidFN+DKIEBIGHS7D2amOA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=none action=none header.from=suse.com; Subject: Re: [PATCH 10/12] xen-pcifront: this module is PV-only To: Bjorn Helgaas Cc: Bjorn Helgaas , Stefano Stabellini , "xen-devel@lists.xenproject.org" , Juergen Gross , Boris Ostrovsky , "linux-pci@vger.kernel.org" References: <20210907153017.GA741607@bjorn-Precision-5520> From: Jan Beulich Message-ID: <82a99bb4-85bd-61cc-85de-f8dd9d1f98ed@suse.com> Date: Tue, 7 Sep 2021 18:14:16 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: <20210907153017.GA741607@bjorn-Precision-5520> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PR3PR09CA0027.eurprd09.prod.outlook.com (2603:10a6:102:b7::32) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5aaa3d38-b7b0-47bc-14cd-08d9721a8b62 X-MS-TrafficTypeDiagnostic: VI1PR0401MB2448: X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2733; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Y7vEub8SuX+2Mjk/NCi6siHY+3n/JlgiU+KUsKWvwv0WFWAz7osXDXOUwYpnA2VEZppgAB7SxdGkSWpGfJkjhLccjlp2S8zMfr2WS9ybDVvyMUZTyaATFXy4dr2JGV9OJTu0//fR098gSXBeXNkMpyCgVm15Y3XwSXoc+kVt/meF+kaQHIM/dljJll7pel0H+dEpgsrOav7gjhCSb/15B03cYQxvOHkiOn8ziNP0t+fy5m5Ymjr/J2+9xvJEM7GGf9y+T+lKnyBsw2/7KLkF8jLUdtHlWR3TAsh+NJAGNCD4UGOcBzIs/379IGogu+RBPXHi2eUahtSrdz/jX2rHkSEQQeoTHcBZ+d8GpbwX3ZCJ0NSv8QjhcZmAyAGp8LpCFQ9XAuAdfgAfBfMD3g4xZHZuTKcG29bm4BMMTynwmbN6cH/VWauVfQwm5lUwtrfdY9YoCkCkbQkcDnaW0md0O+sKwza/lEn7YSwDO86eIfgnV006xwd4D449TT8VqXB40AAsDYO3uFhm0EJPtk2JPiMm+rF/j3YoMjslrFhfID0BgIhuPaIVZqystPZ1DufuemK0dd2X/P3buPdYNZ/qQ76c3GFF/UV7tGx2rcFXniTHAQZN03I3INVB1AeyHoZZCqMeglk8KC/xG1zI1t6ntSjDO7jlNjje6YEtGNXy4aLOx2RNkg4In1HNhqaIRNr4RC5BM/4rTrHIPWA0f6V/drfSZNS/8/zOCFN2H4g7CP6CK1X1aIMm/r6X4raCLYu2 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(39860400002)(376002)(346002)(366004)(396003)(136003)(6916009)(316002)(38100700002)(478600001)(5660300002)(86362001)(26005)(53546011)(31696002)(186003)(2906002)(6486002)(8676002)(66946007)(31686004)(8936002)(66556008)(66476007)(83380400001)(2616005)(956004)(4326008)(36756003)(54906003)(16576012)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NjBNdHRlVUI4VEZiYTJGUTg1dVcrRjMzalZ3WlNIN1FReStpTm5LbnQ1U1Nn?= =?utf-8?B?NlhjVENFM3EvOEhyenhiU05xaTI2eTlYUTl3WkFwTnF1VmNQenBMdS9UZU9u?= =?utf-8?B?VzFLNEJuZkhNTERWM1B1QWtyanBFa0dUT2Iyemx2aC9xS21YeFovcjRPTk5p?= =?utf-8?B?ZGRwNEpiY0ZzMFNxS1VxQ3J0WXMydm1OSUlaUFczWFZuUXo1Y2dkRkh0NVB5?= =?utf-8?B?emc1Q0ZuMmY3dmVqZmVPS3BVYUpOWGtKRmh4TzlrMmlhZ1d1RjFCL0xWMnpE?= =?utf-8?B?NUVGalU0OWx2clhveTFuQVptS0J5ZXNrYXpqajF6cmtpQlNPa1o4Rk4zTkNx?= =?utf-8?B?QlZwcjljLzZsQTJUb3NGaEw5Z0d4bjNvdjJMTWlLQ0Z4ai9ycG8xa240OVBF?= =?utf-8?B?Tmh4ZTBySktZYTJNVVJrMmFSdzdHaGhEZHY0UWZ2SXdFaVZ5aXd4QmU3Rndr?= =?utf-8?B?Tms5VStGbVFsTUNjTCt5bUw3SmwvcHRILzdKRjVxZXBrZHNxZDc5SlN0eDRR?= =?utf-8?B?Z28rTG1oWnlHUVhsQ1dhVHc0U1J3bjZYQVZ2a1ZNL3AxaEJybUZOcW5DQXZz?= =?utf-8?B?VldqWXBINjltVlZrYlJySFROb29wRjBZeThKangrWG9ZSE9ZSXB4RFU0cGxh?= =?utf-8?B?ZW1RM1RQelM3N3JLREt3WTFKdkNGL0NRWlYwbHMrK3o1cUtZM2NEdERVbDBD?= =?utf-8?B?QmJEZ1FxaGphVUgwaFE5NnJ1eUxScmtMekgzM3BtMFBpUkxhd3c3VjNaMGMw?= =?utf-8?B?ckhpdzF2Ui9TQnJQRFF6ZU9WdzRKaVRWMVIxMDY3UXlxOHpoQUk0YmhZWkp2?= =?utf-8?B?TDUwejBHbi9Lb0tIOE5QZDRjV3o3UEJvT3dHS1RJLzVXRFJyUnN6OUJyNXNB?= =?utf-8?B?VVBFRFpnc0FsLzhhK3EyMi8veG44TkJJUXloMVhTY0FocUtwdnpTSTROWVJN?= =?utf-8?B?SENGNSs2OEVWYUVaNFRSYVlLSW9qS051cU5qckJQTnZjZVZYWlhCZ2JGUDZr?= =?utf-8?B?MWVMdERYWk1rTTh0RE5KNzNuU2E0d1VnRjRrK1hkSkIra1lyNm1zN2xkUThU?= =?utf-8?B?U0Jtd1FhRGxGR1ZLeDNtKzNEcTI3SkNMZWRjTGE2bnkyaXZPa2FFc0U2N1lz?= =?utf-8?B?QTN6Rjk2VTRzVzh5WWNYUmI1WDkrckpkQ1hpM1FXZUcxRHRCUHNPQmVyYnFE?= =?utf-8?B?Y0gzVzVBUThVVnpUL1JyMitPYUVnTlZjQXZwWWg5c2VjZ2gwVnJkcU1pT2ZL?= =?utf-8?B?alZYaFJaa2JhcmpiR2ljMnRNU1hXejJRSlo5ang3M0dhdXZKcE5lUE01b3Zn?= =?utf-8?B?SGVWK2pWQk84bFE4Ukd4cXdDZXBiSUpxc0llSzRCb0FoQlpLZTlvTE95eGlW?= =?utf-8?B?aGxnSkNGRzRCSTVQc1lEeEdQM2FLNXNXakw1TWZPdjdMQktHeDFlN1JtQTN2?= =?utf-8?B?RzNXSG9Halp1MGNzNUVZd2lqeGxCRldTZXJpRXB1Y3FQN1ExUHBvV3ViMUVV?= =?utf-8?B?QlFGdHc2cTV0blkwb3pxemNCdW1XSGxuMGFXUmRZODJuQkJMemZDOUI4Y0ll?= =?utf-8?B?cWdOQmpRY1Jyc0E4Y1JCVjdES0E5bWE1dXV6K0tDajRLQ1d6ZENxOHJPSkZW?= =?utf-8?B?SER0by9Bd1ZKSjY1aktWQmpOUDdONjdpZDFTaXcwQVlmWmdpSFpiMXY4YVFK?= =?utf-8?B?MTh5Z25zM3EwcDYwV3ZVd25MVVpaT3c5Q055L085UDd3a3ZyWE82NWwxTFJJ?= =?utf-8?Q?uVv0HZ/5AMd9M47xGdt8+xVYzo0SEtzUVzXw9ST?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5aaa3d38-b7b0-47bc-14cd-08d9721a8b62 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2021 16:14:18.3962 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Pso7JENlOr8XTGDxqLt62uiVP6Bzb2jYhXKVqkYKWnLwQSThe9r8WdSzfRPA5JEpJJyUnTREAqf8EKvPoTNP6w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2448 On 07.09.2021 17:30, Bjorn Helgaas wrote: > Update subject to follow conventions (use "git log --oneline > drivers/pci/Kconfig"). Should say what this patch does. I can change that; I don't think it'll carry any different information. > Commit log below should also say what this patch does. Currently it's > part of the rationale for the change, but doesn't say what the patch > does. "There's no point building ..." to me is as good as "Don't build ...". But oh well, I can adjust ... > On Tue, Sep 07, 2021 at 02:10:41PM +0200, Jan Beulich wrote: >> It's module init function does a xen_pv_domain() check first thing. >> Hence there's no point building it in non-PV configurations. > > s/It's/ s/building it/building / # xen-pcifront.o? The driver name is already part of the subject; I didn't think I need to repeat that one here. > I see that CONFIG_XEN_PV is only mentioned in arch/x86, so > CONFIG_XEN_PV=y cannot be set on other arches. Is the current > "depends on X86" just a reflection of that, or is it because of some > other x86 dependency in the code? > > The connection between xen_pv_domain() and CONFIG_XEN_PV is not > completely obvious. > > If you only build xen-pcifront.o when CONFIG_XEN_PV=y, and > xen_pv_domain() is true if and only if CONFIG_XEN_PV=y, why bother > calling xen_pv_domain() at all? Because XEN_PV=y only _enables_ the kernel to run in PV mode. It may be enabled to also run in HVM and/or PVH modes. And it may then _run_ in any of the enabled modes. IOW xen_pv_domain() will always return false when !XEN_PV; no other implication is valid. I don't think this basic concept needs explaining in a simple patch like this. Instead I think the config option in question, despite living in drivers/pci/Kconfig, should be under "XEN HYPERVISOR INTERFACE" maintainership. I realize that's not even expressable in ./MAINTAINERS. I wonder why the option was put there in the first place, rather than in drivers/xen/Kconfig. Jan From xen-devel-bounces@lists.xenproject.org Tue Sep 07 16:19:24 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 16:19:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.181207.328255 (Exim 4.92) (envelope-from ) id 1mNdoe-00029W-Ve; Tue, 07 Sep 2021 16:19:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 181207.328255; Tue, 07 Sep 2021 16:19:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNdoe-00029P-SU; Tue, 07 Sep 2021 16:19:20 +0000 Received: by outflank-mailman (input) for mailman id 181207; Tue, 07 Sep 2021 16:19:19 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNdod-00029H-Dl for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 16:19:19 +0000 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 59a4fa94-0ff7-11ec-b110-12813bfff9fa; Tue, 07 Sep 2021 16:19:18 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 59a4fa94-0ff7-11ec-b110-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1631031557; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=bHhckMg4yqxP26r9jo3gv+1xllUSkTSk4o7gtf2dNXg=; b=I69MU90t1NVuh+/UcjLzymYbVwJdGWCnWaEx8qa+NEbRrxBTY3X8A/Gc ALc0bfRlkHOer5v8EWyhcJ3m+rz1/KaypHc7HNtSwUellrlL0mTfc9zN/ Yf8y3vOSkKEadFs22Gv7CH75zzDYw9Qjo4eBVfzYB2wjB10vWc5rKAr1H 4=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: 02+NUHQjLy+r/Kth1Kj2Zv6IvEIOeDUblDTTcOILZr3KkXssJY5oQY7q9+dyRxNfkj3Sdn6FXI QvbS1QIO4eWY5zQB7N6bm+ZaZcDs5apycj50VoNc41GgvdMr6gXJc2pZtNIYGS5yxR8iFQhNBq 3iNUdh+GskCs/rkYdjZxanqsSt7L7oCphq8lY3PPoOYentAC0nOP44xzBqyD7P2xI57V7dsTVU RiP3JGaNic5+nm/yLld7USxCH34rAPzxTEFWOrpsyIYLS+/T1An5eG/a06UcyJv3W2IdVQ4fmy Nhb6IwibL1yWYonkAQe3XS7R X-SBRS: 5.1 X-MesageID: 51777373 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:R1n+Dq7uy66rA6ji8wPXwPDXdLJyesId70hD6qhwISY6TiX+rb HWoB17726TtN9/YhEdcLy7VJVoBEmskKKdgrNhWotKPjOW21dARbsKheCJrgEIWReOktK1vZ 0QC5SWY+eQMbEVt6nHCXGDYrQd/OU= X-IronPort-AV: E=Sophos;i="5.85,274,1624334400"; d="scan'208";a="51777373" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , Wei Liu , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [PATCH v2 3/3] x86/amd: Use newer SSBD mechanisms if they exist Date: Tue, 7 Sep 2021 17:19:08 +0100 Message-ID: <20210907161908.17402-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20210817143006.2821-4-andrew.cooper3@citrix.com> References: <20210817143006.2821-4-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit The opencoded legacy Memory Disambiguation logic in init_amd() neglected Fam19h for the Zen3 microarchitecture. In practice, all Zen2 based system have the architectural MSR_SPEC_CTRL and the SSBD bit within it. Implement the algorithm given in AMD's SSBD whitepaper, and leave a printk_once() behind in the case that no controls can be found. This now means that a user explicitly choosing `spec-ctrl=ssbd` will properly turn off Memory Disambiguation on Fam19h/Zen3 systems. This still remains a single system-wide setting (for now), and is not context switched between vCPUs. As such, it doesn't interact with Intel's use of MSR_SPEC_CTRL and default_xen_spec_ctrl (yet). Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Wei Liu CC: Roger Pau Monné v2: * Fix whitespace style in amd_init_ssbd() * Rewrite commit message with the correct command line syntax --- xen/arch/x86/cpu/amd.c | 69 +++++++++++++++++++++++++++++++++++------------- xen/arch/x86/cpu/cpu.h | 1 + xen/arch/x86/cpu/hygon.c | 10 +------ xen/arch/x86/spec_ctrl.c | 5 +++- 4 files changed, 57 insertions(+), 28 deletions(-) diff --git a/xen/arch/x86/cpu/amd.c b/xen/arch/x86/cpu/amd.c index 2260eef3aab5..3f6a8e6aa3b9 100644 --- a/xen/arch/x86/cpu/amd.c +++ b/xen/arch/x86/cpu/amd.c @@ -681,6 +681,56 @@ void amd_init_lfence(struct cpuinfo_x86 *c) c->x86_capability); } +/* + * Refer to the AMD Speculative Store Bypass whitepaper: + * https://developer.amd.com/wp-content/resources/124441_AMD64_SpeculativeStoreBypassDisable_Whitepaper_final.pdf + */ +void amd_init_ssbd(const struct cpuinfo_x86 *c) +{ + int bit = -1; + + if (cpu_has_ssb_no) + return; + + if (cpu_has_amd_ssbd) { + wrmsrl(MSR_SPEC_CTRL, opt_ssbd ? SPEC_CTRL_SSBD : 0); + return; + } + + if (cpu_has_virt_ssbd) { + wrmsrl(MSR_VIRT_SPEC_CTRL, opt_ssbd ? SPEC_CTRL_SSBD : 0); + return; + } + + switch (c->x86) { + case 0x15: bit = 54; break; + case 0x16: bit = 33; break; + case 0x17: + case 0x18: bit = 10; break; + } + + if (bit >= 0) { + uint64_t val, mask = 1ull << bit; + + if (rdmsr_safe(MSR_AMD64_LS_CFG, val) || + ({ + val &= ~mask; + if (opt_ssbd) + val |= mask; + false; + }) || + wrmsr_safe(MSR_AMD64_LS_CFG, val) || + ({ + rdmsrl(MSR_AMD64_LS_CFG, val); + (val & mask) != (opt_ssbd * mask); + })) + bit = -1; + } + + if (bit < 0) + printk_once(XENLOG_ERR "No SSBD controls available\n"); +} + static void init_amd(struct cpuinfo_x86 *c) { u32 l, h; @@ -731,24 +781,7 @@ static void init_amd(struct cpuinfo_x86 *c) else /* Implicily "== 0x10 || >= 0x12" by being 64bit. */ amd_init_lfence(c); - /* - * If the user has explicitly chosen to disable Memory Disambiguation - * to mitigiate Speculative Store Bypass, poke the appropriate MSR. - */ - if (opt_ssbd) { - int bit = -1; - - switch (c->x86) { - case 0x15: bit = 54; break; - case 0x16: bit = 33; break; - case 0x17: bit = 10; break; - } - - if (bit >= 0 && !rdmsr_safe(MSR_AMD64_LS_CFG, value)) { - value |= 1ull << bit; - wrmsr_safe(MSR_AMD64_LS_CFG, value); - } - } + amd_init_ssbd(c); /* MFENCE stops RDTSC speculation */ if (!cpu_has_lfence_dispatch) diff --git a/xen/arch/x86/cpu/cpu.h b/xen/arch/x86/cpu/cpu.h index 1ac3b2867a04..1a5b3918b37e 100644 --- a/xen/arch/x86/cpu/cpu.h +++ b/xen/arch/x86/cpu/cpu.h @@ -21,3 +21,4 @@ extern bool detect_extended_topology(struct cpuinfo_x86 *c); void early_init_amd(struct cpuinfo_x86 *c); void amd_log_freq(const struct cpuinfo_x86 *c); void amd_init_lfence(struct cpuinfo_x86 *c); +void amd_init_ssbd(const struct cpuinfo_x86 *c); diff --git a/xen/arch/x86/cpu/hygon.c b/xen/arch/x86/cpu/hygon.c index 67e23c5df9e3..56792146739e 100644 --- a/xen/arch/x86/cpu/hygon.c +++ b/xen/arch/x86/cpu/hygon.c @@ -33,15 +33,7 @@ static void init_hygon(struct cpuinfo_x86 *c) unsigned long long value; amd_init_lfence(c); - - /* - * If the user has explicitly chosen to disable Memory Disambiguation - * to mitigiate Speculative Store Bypass, poke the appropriate MSR. - */ - if (opt_ssbd && !rdmsr_safe(MSR_AMD64_LS_CFG, value)) { - value |= 1ull << 10; - wrmsr_safe(MSR_AMD64_LS_CFG, value); - } + amd_init_ssbd(c); /* MFENCE stops RDTSC speculation */ if (!cpu_has_lfence_dispatch) diff --git a/xen/arch/x86/spec_ctrl.c b/xen/arch/x86/spec_ctrl.c index c310a7f6ac96..f0c67d41b85f 100644 --- a/xen/arch/x86/spec_ctrl.c +++ b/xen/arch/x86/spec_ctrl.c @@ -326,20 +326,23 @@ static void __init print_details(enum ind_thunk thunk, uint64_t caps) (caps & ARCH_CAPS_IBRS_ALL) ? " IBRS_ALL" : "", (caps & ARCH_CAPS_RSBA) ? " RSBA" : "", (caps & ARCH_CAPS_SKIP_L1DFL) ? " SKIP_L1DFL" : "", + (e8b & cpufeat_mask(X86_FEATURE_SSB_NO)) || (caps & ARCH_CAPS_SSB_NO) ? " SSB_NO" : "", (caps & ARCH_CAPS_MDS_NO) ? " MDS_NO" : "", (caps & ARCH_CAPS_TAA_NO) ? " TAA_NO" : ""); /* Hardware features which need driving to mitigate issues. */ - printk(" Hardware features:%s%s%s%s%s%s%s%s\n", + printk(" Hardware features:%s%s%s%s%s%s%s%s%s\n", (e8b & cpufeat_mask(X86_FEATURE_IBPB)) || (_7d0 & cpufeat_mask(X86_FEATURE_IBRSB)) ? " IBPB" : "", (_7d0 & cpufeat_mask(X86_FEATURE_IBRSB)) ? " IBRS" : "", (_7d0 & cpufeat_mask(X86_FEATURE_STIBP)) ? " STIBP" : "", + (e8b & cpufeat_mask(X86_FEATURE_AMD_SSBD)) || (_7d0 & cpufeat_mask(X86_FEATURE_SSBD)) ? " SSBD" : "", (_7d0 & cpufeat_mask(X86_FEATURE_L1D_FLUSH)) ? " L1D_FLUSH" : "", (_7d0 & cpufeat_mask(X86_FEATURE_MD_CLEAR)) ? " MD_CLEAR" : "", (_7d0 & cpufeat_mask(X86_FEATURE_SRBDS_CTRL)) ? " SRBDS_CTRL" : "", + (e8b & cpufeat_mask(X86_FEATURE_VIRT_SSBD)) ? " VIRT_SSBD" : "", (caps & ARCH_CAPS_TSX_CTRL) ? " TSX_CTRL" : ""); /* Compiled-in support which pertains to mitigations. */ -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Tue Sep 07 16:22:49 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 16:22:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.181214.328266 (Exim 4.92) (envelope-from ) id 1mNds0-0003rR-FL; Tue, 07 Sep 2021 16:22:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 181214.328266; Tue, 07 Sep 2021 16:22:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNds0-0003rK-C2; Tue, 07 Sep 2021 16:22:48 +0000 Received: by outflank-mailman (input) for mailman id 181214; Tue, 07 Sep 2021 16:22:47 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNdrz-0003rA-AW; Tue, 07 Sep 2021 16:22:47 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNdrz-0008W9-6e; Tue, 07 Sep 2021 16:22:47 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNdry-0004w4-UO; Tue, 07 Sep 2021 16:22:46 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mNdry-00061t-Tq; Tue, 07 Sep 2021 16:22:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=OgiXK6N41G6Zmzj0XHu4XJlmQS9TcqMu8fQl7XWvshE=; b=668qqaShDEKMy5nwmpQa0ef0IK ndJU05J670Cw6+eDx7nVPtyuB55xDHBPcqQfQuc8MDV5wBoOds4PNYzKDHZBZ6uQFyyLWqqSHDvTO j1sp15ZcxXjI0BuG93UZ8p4kcJ8xZy0/B3hZIuEwRMOOL3N8+uTaS8R4VuVYDYq0UREA=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 164875: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=e70a9a043a5ce6d4025420f729bc473f711bf5d1 X-Osstest-Versions-That: xen=5ae4120635ad3cbf6064268162b0fb2c44eb41e3 From: osstest service owner Date: Tue, 07 Sep 2021 16:22:46 +0000 flight 164875 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/164875/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen e70a9a043a5ce6d4025420f729bc473f711bf5d1 baseline version: xen 5ae4120635ad3cbf6064268162b0fb2c44eb41e3 Last test of basis 164872 2021-09-07 08:01:48 Z 0 days Testing same since 164875 2021-09-07 13:00:24 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Jan Beulich jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 5ae4120635..e70a9a043a e70a9a043a5ce6d4025420f729bc473f711bf5d1 -> smoke From xen-devel-bounces@lists.xenproject.org Tue Sep 07 16:31:12 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 16:31:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.181221.328280 (Exim 4.92) (envelope-from ) id 1mNdzw-0005HW-Bv; Tue, 07 Sep 2021 16:31:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 181221.328280; Tue, 07 Sep 2021 16:31:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNdzw-0005HP-8N; Tue, 07 Sep 2021 16:31:00 +0000 Received: by outflank-mailman (input) for mailman id 181221; Tue, 07 Sep 2021 16:30:59 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNdzv-0005HJ-2T for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 16:30:59 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id fa587f1e-0ff8-11ec-b112-12813bfff9fa; Tue, 07 Sep 2021 16:30:57 +0000 (UTC) Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-db5eur03lp2057.outbound.protection.outlook.com [104.47.10.57]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-33-xzGIXKmmPOWIzO3Ef1a4fQ-1; Tue, 07 Sep 2021 18:30:55 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR0401MB2333.eurprd04.prod.outlook.com (2603:10a6:800:28::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19; Tue, 7 Sep 2021 16:30:53 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4500.014; Tue, 7 Sep 2021 16:30:53 +0000 Received: from [10.156.60.236] (37.24.206.209) by PR2PR09CA0024.eurprd09.prod.outlook.com (2603:10a6:101:16::36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Tue, 7 Sep 2021 16:30:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fa587f1e-0ff8-11ec-b112-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1631032256; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aH3OuqSwJzb+8ZU3KTnwJsKyxX6bcxjI+WZ19P4EHUY=; b=jBB5J3VIGAxV3Njdha9p/JEV6kiYzbLQb580lnYG1SSkk4+nXs46EmLDQr4Qz9IrnaYbPg mIuaLG+S81GQ8PjwCA5nj4Vo3sdUCjRPhmiMaM01PfFcYSzSU9zFtB7zq/aLw8mW3S6qax kwuxw89Cw4yUWmmq3uXA8Sh0WhwIIT0= X-MC-Unique: xzGIXKmmPOWIzO3Ef1a4fQ-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gjO9pJob/cDyZZx2niWHexw75N8srREp7wcjiaC6YJN3hqv6+IKGBy5w56amWYyPA/f5W+zQdB+ykd5UObIx62+fpVw9W4UEPRLbj7AvU/pKuL8xmloUI+9zIzWxNys2Jwpky+PGX2APMsnisnibmGytdadcwi7gKWGDsNiMR3gEX71j8W/9cXF4bMrJetTVGm4dWLA0p0hgRP6oOkQjJo9MPcT2E4wI/e9dUre/8ZNz8SixX8aFwuTdHURd42MK/uZ860tOpTs3Pwn1sYbV41nQ1/j932wv91atoScseE4rTze4qVo2uKWQfAat92/kQcnQXsdM14jSRltJUsOXxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=aci6m3pjwbaz5O1KJStmBiwl09NYg9Epzo3SDRuPRc0=; b=GzohOCJce+guttojPssOmQoSdKjE6SgftLQQ2pOBCw74eyOVAbDlIwxD4JRNK2A3csjf8zcYbSlp84pSAGeSzSTwRu1vjy9glEM6UGfR5SSwU61bWilHLVQZN10ShwZuBOySZXN5tLDrxeG4DJjDaIYvk3VUeF3ifpNFmkjMKQPVskNzlpAqbVxdmwsasc0wSu3mOMyw/hr+F4vJWht3Z5PHAKdLthkWGsACpx5MK7LYvOYw5pinyINtn6g8IVg6VuSGEiX6a3C1/5XY4WJRwloGGtTutwMgDSfBTCXNL00OmSvLt9olKThUbjVixHNlomDJe8gL2CyvriN6Os0bAg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com; Subject: Re: [PATCH 5/9] vpci/header: Implement guest BAR register handlers To: Oleksandr Andrushchenko , Oleksandr Andrushchenko CC: "julien@xen.org" , "sstabellini@kernel.org" , Oleksandr Tyshchenko , Volodymyr Babchuk , Artem Mygaiev , "roger.pau@citrix.com" , Bertrand Marquis , Rahul Singh , "xen-devel@lists.xenproject.org" References: <20210903100831.177748-1-andr2000@gmail.com> <20210903100831.177748-6-andr2000@gmail.com> <1848521d-4179-f5ee-e3af-f4e6738f60e6@suse.com> From: Jan Beulich Message-ID: <2e0c2ff5-7228-a439-c8a6-50f7a022e77b@suse.com> Date: Tue, 7 Sep 2021 18:30:51 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: PR2PR09CA0024.eurprd09.prod.outlook.com (2603:10a6:101:16::36) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 93f00116-d657-4b80-1b97-08d9721cdca3 X-MS-TrafficTypeDiagnostic: VI1PR0401MB2333: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: jVTVDauqvRrfUM0HTpofQdmj/lYdS+QszUt1QBpjfrmKBLd4LLyvvCkuQIfyK2/n/G31KUrN3fsGCMYLXX4+3Fz6Hhjt25QmF/cXh/ePffuXdPhrjLMK5rNY98oIWfJjIR4ftJ//koE9RfiW8nGFaixot2mkLkRe2G1irGB8hCjUxAoxLfco8fTAXWZqNF5Y+PIPCTl+i71Z6x/ODQk5x6R+V9c2kORmYoIvB+DKEp8jCgJcyk7pQtH+X7XYKp+p0OKmcAPHpVA8MstvoM8Rg9lL6Mbnryq5m7oHJ4414wrO/hIUSBpXDAtKo9Fq6/jiPeMqsXMBwYr2ecRsAsvTppyxnP/bDxX4WjfnPYscHjECsJdQnpMJW9MeKwyG/xLy8svcKxXKtX9nOQbeJn5rt0pESuC+ldUNo82Gq86KPzOKBmC6j/6R1ZNneCtY9oMYmIlt0iZOZAgVhePRcu/9dvBsQ2P3wVgj/F1SkOXRa8XChTMR6R9Qp2ruOl+cHPEkr3slE/napYV/5ROEDNfuAbPe3mk39IeV1bizZa+SF06sHbKHXuxkhAteLzz+3CCG+mluGUpNOJPjvdnStYIdP8pTcDD06SGLhG9JhcHTlEsRAcl8noypRmdhKrHlatc+u+3aUhMKiu0AY5TvBXfdYvsP3QHUGgJNfcfiK/sCg1RNHmNbpRtopKGZXiHyuzDO/pInAWwo+N3p9zlFqM5fCylx8AFU/kkHEwCfxYrTCjtBBvqhjYVnptD9ceX8q8Kz X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(136003)(346002)(39860400002)(376002)(396003)(366004)(38100700002)(8936002)(54906003)(110136005)(478600001)(8676002)(53546011)(2906002)(26005)(31686004)(7416002)(31696002)(86362001)(36756003)(66946007)(66556008)(66476007)(2616005)(83380400001)(956004)(4326008)(5660300002)(6486002)(16576012)(186003)(316002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?EGzw3YmtUrxGtDEMC9ih/8Uc2Sv3ptGg5W+h0HpEvUYAE0jIr6DV9oPLcI5q?= =?us-ascii?Q?lPjmfGYRF+iEpD1PS21EqZpe8l7UqZs1aV4RRxBatFZi5OQ5w1v7gvvPd4y8?= =?us-ascii?Q?tKBy7g1pXqRoBOM456y/XUtNI5fr/QHjFMwert7GjFXU5MCMCxTTLQJ0ynTe?= =?us-ascii?Q?SlapRhkxiaWEKJ+ZNyOex8zguDtActtT6rKpeyfIjqL4zjbGf8B9pQffJRgy?= =?us-ascii?Q?WsPdHTl3IjGBq+03hiD0rqO8G2KOdJq5m3/rmYK/yXKnoSVnqQhJ/LhNICeH?= =?us-ascii?Q?DL82b9hxydJhbkHD8YpVabiQNfc3Yk1E4tcflTrL5Hpv6EeSy2355GoG4mJ9?= =?us-ascii?Q?GC3+0ZdizbJYfEbqt9GXwyVgXzXWGAlEX43TuEXZ4G5prkLwi8yhQrlvVfe5?= =?us-ascii?Q?cXgE379pvtWG2RIPu89MuAjwdIqfHf+QbgIBat6RuxXz1AVDEWJRGy6LFOdS?= =?us-ascii?Q?bGSK+djH51kg5kEBeL6kXGFgOleO1k5cF7PzbwQf0CVXEDOvHArR76IA1cN6?= =?us-ascii?Q?VEZvgrlFA7aBsjlqf/cJLhsqweSkQ4XICSYfj3Sftg0N2xjWOvqlPBMYHsnL?= =?us-ascii?Q?L/8DUNqXVroVJU+2tv5T00lqYw9piR6gAoeMuAkpoBoHEP8AOrsOFZaWESau?= =?us-ascii?Q?r8tEguD9pLreTNFsq7vIejc2Q1wlVDARPpdfTEAJGwgzXAQ98r2h9swMpm10?= =?us-ascii?Q?mNOup8nrf3MZBCNCNRC5Pcmapa727QnEhxeTPoFClJlQ0PFiEiIpC1M6WnYJ?= =?us-ascii?Q?OHj4ssCZ5aEX1d1peuXA4IaZ4aPGlexe3dEE6TnSlliRwSq/bJigckfnAoyZ?= =?us-ascii?Q?ysz0hoKHJii+8NzgOsOXJMAG5Ht9TmDJqcGV8Cmi7ROD5f1YpMKNBeXaENRc?= =?us-ascii?Q?Xytt2x/cNYSuFV8YnACnCiQatiGNZe1FJpaWGIBDvle87CleDqG2XNvrsDbN?= =?us-ascii?Q?KkEwQt9BFlRF2RjzBPXjqPOa4ChlZOfr4VIAwr/WP6nH0hi7OpCIa6rDJgUU?= =?us-ascii?Q?TpWahRSYMdLm9cFOx/xRqHUmk4uL0KEGCxH6XIXTM+Cbx/FIaU9WjXfxUvD1?= =?us-ascii?Q?WGGA8Xp7w+Ln6i4u6hUbTKsif4Y13owDxPl68tbvy6l4X9vxCGg5Gbx+WwKg?= =?us-ascii?Q?75h5YqkThz1+khmvpeOT1r1kHwDwrJ/6xdC2OTFXguxrDXHpQhXmwLTfWkWJ?= =?us-ascii?Q?XwVI1CPiD2SG/gdljcbMylJU/vD9l1oy/oOq9EUhEXEWXqC95RZkc9aKD5NX?= =?us-ascii?Q?tKG7uEoKUvkckRp3mWwvs2sp96CTJBs7ck77PEnUIV97WSGPwy3t3CjwI3aG?= =?us-ascii?Q?cp+FcWCR8OSYFKVJtrBQtePV?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 93f00116-d657-4b80-1b97-08d9721cdca3 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2021 16:30:53.7082 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 8ekXdIyJsPFy2+2hcjoAmYOeIZzl+PKvQ5EM6ZlcN08Rj7JzcEA0TJ1/PcX7C5eDRg4qLviMtPcDyVDedVHw7w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2333 On 07.09.2021 15:33, Oleksandr Andrushchenko wrote: > On 06.09.21 17:31, Jan Beulich wrote: >> On 03.09.2021 12:08, Oleksandr Andrushchenko wrote: >>> --- a/xen/drivers/vpci/header.c >>> +++ b/xen/drivers/vpci/header.c >>> @@ -400,12 +400,72 @@ static void bar_write(const struct pci_dev *pdev,= unsigned int reg, >>> static void guest_bar_write(const struct pci_dev *pdev, unsigned int = reg, >>> uint32_t val, void *data) >>> { >>> + struct vpci_bar *bar =3D data; >>> + bool hi =3D false; >>> + >>> + if ( bar->type =3D=3D VPCI_BAR_MEM64_HI ) >>> + { >>> + ASSERT(reg > PCI_BASE_ADDRESS_0); >>> + bar--; >>> + hi =3D true; >>> + } >>> + else >>> + val &=3D PCI_BASE_ADDRESS_MEM_MASK; >>> + bar->guest_addr &=3D ~(0xffffffffull << (hi ? 32 : 0)); >>> + bar->guest_addr |=3D (uint64_t)val << (hi ? 32 : 0); >> What you store here is not the address that's going to be used, >=20 > bar->guest_addr is never used directly to be reported to a guest. And this is what I question, as an approach. Your model _may_ work, but its needlessly deviating from how people like me would expect this to work. And if it's intended to be this way, how would I have known? > It is always used as an initial value which is then modified to reflect > lower bits, e.g. BAR type and if prefetchable, so I think this is perfect= ly > fine to have it this way. And it is also perfectly fine to store the value to be handed back to guests on the next read. Keeps the read path simple, which I think can be assumed to be taken more frequently than the write one. Plus stored values reflect reality. Plus - if what you say was really the case, why do you mask off PCI_BASE_ADDRESS_MEM_MASK here? You should then simply store the written value and do _all_ the processing in the read path. No point having partial logic in two places. >> as >> you don't mask off the low bits (to account for the BAR's size). >> When a BAR gets written with all ones, all writable bits get these >> ones stored. The address of the BAR, aiui, really changes to >> (typically) close below 4Gb (in the case of a 32-bit BAR), which >> is why memory / I/O decoding should be off while sizing BARs. >> Therefore you shouldn't look for the specific "all writable bits >> are ones" pattern (or worse, as you presently do, the "all bits >> outside of the type specifier are ones" one) on the read path. >> Instead mask the value appropriately here, and simply return back >> the stored value from the read path. > "PCI LOCAL BUS SPECIFICATION, REV. 3.0", "IMPLEMENTATION NOTE >=20 > Sizing a 32-bit Base Address Register Example" says, that >=20 > "Software saves the original value of the Base Address register, writes > 0 FFFF FFFFh to the register, then reads it back." >=20 > The same applies for 64-bit BARs. So what's wrong if I try to catch such > a write when a guest tries to size the BAR? The only difference is that > I compare as > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if ( (val & PCI_BASE_ADDRESS_= MEM_MASK_32) =3D=3D PCI_BASE_ADDRESS_MEM_MASK_32 ) > which is because val in the question has lower bits cleared. Because while this matches what the spec says, it's not enough to match how hardware behaves. Yet you want to mimic hardware behavior as closely as possible here. There is (iirc) at least one other place in the source tree were we had to adjust a similar initial implementation to be closer to one expected by guests, no matter that they may not be following the spec to the letter. Don't forget that there may be bugs in kernels which don't surface until the kernel gets run on an overly simplistic emulation. >>> @@ -522,6 +582,13 @@ static int add_bar_handlers(struct pci_dev *pdev, = bool is_hwdom) >>> if ( rc ) >>> return rc; >>> } >>> + /* >>> + * It is neither safe nor secure to initialize guest's view of= the BARs >>> + * with real values which are used by the hardware domain, so = assign >>> + * all zeros to guest's view of the BARs, so the guest can per= form >>> + * proper PCI device enumeration and assign BARs on its own. >>> + */ >>> + bars[i].guest_addr =3D 0; >> I'm afraid I don't understand the comment: Without memory decoding >> enabled, the BARs are simple registers (with a few r/o bits). >=20 > My first implementation was that bar->guest_addr was initialized with > the value of bar->addr (physical BAR value), but talking on IRC with > Roger he suggested that this might be a security issue to let guest > a hint about physical values, so then I changed the assignment to be 0. Well, yes, that's certainly correct. It's perhaps too unobvious to me why one may want to use the host value here in the first place. It simply has no meaning here. >>> --- a/xen/include/xen/pci_regs.h >>> +++ b/xen/include/xen/pci_regs.h >>> @@ -103,6 +103,7 @@ >>> #define PCI_BASE_ADDRESS_MEM_TYPE_64 0x04 /* 64 bit address */ >>> #define PCI_BASE_ADDRESS_MEM_PREFETCH 0x08 /* prefetchable? */ >>> #define PCI_BASE_ADDRESS_MEM_MASK (~0x0fUL) >>> +#define PCI_BASE_ADDRESS_MEM_MASK_32 (~0x0fU) >> Please don't introduce an identical constant that's merely of >> different type. (uint32_t)PCI_BASE_ADDRESS_MEM_MASK at the use >> site (if actually still needed as per the comment above) would >> seem more clear to me. > Ok, I thought type casting is a bigger evil here Often it is, but imo here it is not. I hope you realize that ~0x0fU if not necessarily 0xfffffff0? We make certain assumptions on type widths. For unsigned int we assume it to be at least 32 bits wide. We should avoid assumptions of it being exactly 32 bits wide. Just like we cannot (more obviously) assume the width of unsigned long. (Which tells us that for 32-bit arches PCI_BASE_ADDRESS_MEM_MASK is actually of the wrong type. This constant should be the same no matter the bitness.) Jan From xen-devel-bounces@lists.xenproject.org Tue Sep 07 16:38:46 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 16:38:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.181229.328290 (Exim 4.92) (envelope-from ) id 1mNe7O-0006OX-7Z; Tue, 07 Sep 2021 16:38:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 181229.328290; Tue, 07 Sep 2021 16:38:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNe7O-0006OQ-4g; Tue, 07 Sep 2021 16:38:42 +0000 Received: by outflank-mailman (input) for mailman id 181229; Tue, 07 Sep 2021 16:38:40 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNe7M-0006OK-Q5 for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 16:38:40 +0000 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 555f382a-462a-4eb3-ac83-329dd8215b30; Tue, 07 Sep 2021 16:38:39 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id D418760E77; Tue, 7 Sep 2021 16:38:38 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 555f382a-462a-4eb3-ac83-329dd8215b30 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1631032719; bh=kM4x6R7FRoHUCOnGXVz/Y0FnaHvMZjmGIfLn42Hpaso=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=kgIy3BUhv2UT6NbQOChJDvdO/ddqyb+6TdoPWIQSGyG0EZbk/qLuWzTimoMpC+HH5 bwX+/ZfHBVLxuGEChqx5IyxN0z46QnZOPUp0zMXmb0lpcl062y0vMY+JXDu48u3XCx 0wd2ByqQdRofvst0nS4V54iGJnDo1Es/FBimcg/RmdCrHGULjBs2TexrBHb7prHuCl RjtZGpzzbLyiQNYxTeWFm6kyFImNgbTk60ye10VyP3P+pcpI+/LKQCYbSnB4Uujxef X0ABVPjXHtLiE3QFE0p7R5MJimNBUekSXsZduzlGc5FfYHtSGdHkH/nxec/lHTrRHM OpweP7+y/xQIw== Date: Tue, 7 Sep 2021 11:38:37 -0500 From: Bjorn Helgaas To: Jan Beulich Cc: Bjorn Helgaas , Stefano Stabellini , "xen-devel@lists.xenproject.org" , Juergen Gross , Boris Ostrovsky , "linux-pci@vger.kernel.org" Subject: Re: [PATCH 10/12] xen-pcifront: this module is PV-only Message-ID: <20210907163837.GA747361@bjorn-Precision-5520> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <82a99bb4-85bd-61cc-85de-f8dd9d1f98ed@suse.com> On Tue, Sep 07, 2021 at 06:14:16PM +0200, Jan Beulich wrote: > On 07.09.2021 17:30, Bjorn Helgaas wrote: > > Update subject to follow conventions (use "git log --oneline > > drivers/pci/Kconfig"). Should say what this patch does. > > I can change that; I don't think it'll carry any different information. It might not be different information, but if you use the same sentence structure and formatting as all the other subject lines, they're easier to read as a group. > > Commit log below should also say what this patch does. Currently it's > > part of the rationale for the change, but doesn't say what the patch > > does. > > "There's no point building ..." to me is as good as "Don't build ...". > But oh well, I can adjust ... > > > On Tue, Sep 07, 2021 at 02:10:41PM +0200, Jan Beulich wrote: > >> It's module init function does a xen_pv_domain() check first thing. > >> Hence there's no point building it in non-PV configurations. > > > > s/It's/ > I don't understand this - how is "module init function" not clear > enough? Saying "module init function" makes the reader do extra work to figure out what function you are referring to. I had to look at drivers/pci/Makefile to find the module name, then look at drivers/pci/xen-pcifront.c to look for the init function. Saying pcifront_init() makes it trivial to look *there*. > > s/building it/building / # xen-pcifront.o? > > The driver name is already part of the subject; I didn't think I > need to repeat that one here. Why be vague when it's so easy to be explicit and save everybody else the effort? Part of the disconnect here is that the subject line is not *part* of the commit log, so the commit log should make sense even if you can't see the subject line. It's like an essay that should make sense without its title. Most of this *is* trivial, I agree. Just minor hiccups in the process of reading. > > I see that CONFIG_XEN_PV is only mentioned in arch/x86, so > > CONFIG_XEN_PV=y cannot be set on other arches. Is the current > > "depends on X86" just a reflection of that, or is it because of some > > other x86 dependency in the code? > > > > The connection between xen_pv_domain() and CONFIG_XEN_PV is not > > completely obvious. > > > > If you only build xen-pcifront.o when CONFIG_XEN_PV=y, and > > xen_pv_domain() is true if and only if CONFIG_XEN_PV=y, why bother > > calling xen_pv_domain() at all? > > Because XEN_PV=y only _enables_ the kernel to run in PV mode. It > may be enabled to also run in HVM and/or PVH modes. And it may > then _run_ in any of the enabled modes. IOW xen_pv_domain() will > always return false when !XEN_PV; no other implication is valid. > I don't think this basic concept needs explaining in a simple > patch like this. Instead I think the config option in question, > despite living in drivers/pci/Kconfig, should be under "XEN > HYPERVISOR INTERFACE" maintainership. I realize that's not even > expressable in ./MAINTAINERS. I wonder why the option was put > there in the first place, rather than in drivers/xen/Kconfig. No doubt it's obvious to Xen experts. Unfortunately I am not one. Evidently there's no real dependency on the X86 arch, which makes me wonder why the "depends on X86" was there in the first place. Bjorn From xen-devel-bounces@lists.xenproject.org Tue Sep 07 16:44:39 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 16:44:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.181236.328302 (Exim 4.92) (envelope-from ) id 1mNeD4-00086x-Sa; Tue, 07 Sep 2021 16:44:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 181236.328302; Tue, 07 Sep 2021 16:44:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNeD4-00086q-P6; Tue, 07 Sep 2021 16:44:34 +0000 Received: by outflank-mailman (input) for mailman id 181236; Tue, 07 Sep 2021 16:44:33 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNeD3-00086g-43; Tue, 07 Sep 2021 16:44:33 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNeD2-0000S3-OH; Tue, 07 Sep 2021 16:44:32 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNeD2-0005jL-9O; Tue, 07 Sep 2021 16:44:32 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mNeD2-0005qX-8u; Tue, 07 Sep 2021 16:44:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=XdHOkZ0Sl7HcdmNgdy0n0SQacTbETZEE7X+q0N0/gyA=; b=pYR6n7VweqU2/OR7fd3AgtDvxz kfdxUMp4fz9uMzImma+oNI5yRiE4yh//ogxvC9buGQgfAhqU+eQNu0IQxMjwrRek6rlhFZV5gxdxa tPU6sFwoanJVLGGIVQ5bepsWbdHxVQSx7zCtQIZ7JBbwowRyz+3hKLV1n/OoL6XvOtmk=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 164871: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-i386-xl-qemut-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-examine:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-i386-xl-raw:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-pvshim:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-i386:xen-install:fail:regression linux-linus:test-amd64-i386-xl-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ovmf-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-coresched-i386-xl:xen-install:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-credit1:debian-fixup:fail:regression linux-linus:test-arm64-arm64-xl-thunderx:debian-fixup:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:debian-fixup:fail:regression linux-linus:test-arm64-arm64-xl:debian-fixup:fail:regression linux-linus:test-arm64-arm64-xl-credit2:debian-fixup:fail:regression linux-linus:test-arm64-arm64-xl-xsm:debian-fixup:fail:regression linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=4b93c544e90e2b28326182d31ee008eb80e02074 X-Osstest-Versions-That: linux=deacdb3e3979979016fcd0ffd518c320a62ad166 From: osstest service owner Date: Tue, 07 Sep 2021 16:44:32 +0000 flight 164871 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/164871/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemut-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-examine 6 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-i386-xl-raw 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-pvshim 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-i386 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ovmf-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-coresched-i386-xl 7 xen-install fail REGR. vs. 152332 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 152332 test-arm64-arm64-xl-credit1 13 debian-fixup fail REGR. vs. 152332 test-arm64-arm64-xl-thunderx 13 debian-fixup fail REGR. vs. 152332 test-arm64-arm64-libvirt-xsm 13 debian-fixup fail REGR. vs. 152332 test-arm64-arm64-xl 13 debian-fixup fail REGR. vs. 152332 test-arm64-arm64-xl-credit2 13 debian-fixup fail REGR. vs. 152332 test-arm64-arm64-xl-xsm 13 debian-fixup fail REGR. vs. 152332 test-arm64-arm64-examine 8 reboot fail REGR. vs. 152332 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 152332 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 152332 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152332 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 152332 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152332 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152332 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152332 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: linux 4b93c544e90e2b28326182d31ee008eb80e02074 baseline version: linux deacdb3e3979979016fcd0ffd518c320a62ad166 Last test of basis 152332 2020-07-31 19:41:23 Z 402 days Failing since 152366 2020-08-01 20:49:34 Z 401 days 699 attempts Testing same since 164865 2021-09-06 21:40:45 Z 0 days 2 attempts ------------------------------------------------------------ 7221 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl fail test-armhf-armhf-xl pass test-amd64-i386-xl fail test-amd64-coresched-i386-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm fail test-amd64-i386-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm fail test-amd64-i386-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine pass test-arm64-arm64-examine fail test-armhf-armhf-examine pass test-amd64-i386-examine fail test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel fail test-amd64-i386-qemuu-rhel6hvm-intel fail test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair fail test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow fail test-arm64-arm64-xl-thunderx fail test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2221825 lines long.) From xen-devel-bounces@lists.xenproject.org Tue Sep 07 17:10:01 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 17:10:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.181246.328316 (Exim 4.92) (envelope-from ) id 1mNebb-0002iA-Uk; Tue, 07 Sep 2021 17:09:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 181246.328316; Tue, 07 Sep 2021 17:09:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNebb-0002i3-RN; Tue, 07 Sep 2021 17:09:55 +0000 Received: by outflank-mailman (input) for mailman id 181246; Tue, 07 Sep 2021 17:09:55 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNebb-0002hx-9x for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 17:09:55 +0000 Received: from mail-lf1-x12d.google.com (unknown [2a00:1450:4864:20::12d]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id c53e1a52-308e-47af-b219-550dd6532ed3; Tue, 07 Sep 2021 17:09:54 +0000 (UTC) Received: by mail-lf1-x12d.google.com with SMTP id m28so20870217lfj.6 for ; Tue, 07 Sep 2021 10:09:53 -0700 (PDT) Received: from otyshchenko.router ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id t20sm1059533lfk.157.2021.09.07.10.09.51 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 07 Sep 2021 10:09:52 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c53e1a52-308e-47af-b219-550dd6532ed3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id; bh=Eb3nTuViuxkM2u25OPGYlL8g/e8tL46q5jZZVa4g28I=; b=KP6THAg3j2h3laFCwGL5cczIeTLwtChwkQPOmjuYWuwXVJm4iCDbMNWljxQJsS51V9 U3QfumpMjey7dx9fzCA33igvERXlRiqcS5hQOMLSdRW1inlq9p+2Jdroz4Ysv1y5uw/d IgE4zEBsFvGfq4iDslJ/TuWV1T72ct9WtyozmWBWwyxwO7XLhULP92KcQa0ZvFs8/G4y R8w3VoT3fmYcQYXhiL4Pab9DpIxC8Ie5CnTuPBVViXdWfklFFZ3JTp9AjifpBphL33YA bwG+qQs+po0ALxhyPPzAYPU9apCnC0AI2bBO+oNmNMsyDXu1FG7KbY50ERp5NdOKkYzX PuOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=Eb3nTuViuxkM2u25OPGYlL8g/e8tL46q5jZZVa4g28I=; b=rCbKOLEQfKWv88OJ5NCLMptP3XtGvZmm+Q4VrWI2eWNsVmX+xE60PFXXaegJkMKV2l 6fQCDqeAa0esEXcdfihoGAiZU8a/o8wFcJdGvkGWESIeCa+ytHKH9daER6KRnVWwSg/v +GS6KfUqaQto6W2XNA7I68iTNamfOuyDgkJ92OI0vgsBFg0mxfbz8HnlBtABBfXkfs1G PQz7i2NAKbFJ3f0w7Mstcg+0tLYHIbXtp2B3Sd1ch8tcPZQfBwktHr9XlcYwOtzY5WEP oSlzUjqd0Y7Pi+bEDPcu1Xzw3y8h535vY91RehsUgcvUcZFoqRcyv9guKlBuig+GxBkS ik2Q== X-Gm-Message-State: AOAM531X23uxe2uClcDe7vWmU0+xElO2HGQe7g6wYy173CivB8EilEPz 71SwsOQPOPCiEfrja29rhXjQRBL7Ewg= X-Google-Smtp-Source: ABdhPJzrrQuBHf/px86brxNUtIXtsL3f4TvChuTwFU0eFe8bl8AjmS+1W0LXx6/jcCJ7EOw5P8BGsA== X-Received: by 2002:ac2:551a:: with SMTP id j26mr13864021lfk.354.1631034592707; Tue, 07 Sep 2021 10:09:52 -0700 (PDT) From: Oleksandr Tyshchenko To: xen-devel@lists.xenproject.org Cc: Oleksandr Tyshchenko , Ian Jackson , Wei Liu , Anthony PERARD , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Juergen Gross , Volodymyr Babchuk , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [RFC PATCH 0/3] Add handling of extended regions (safe ranges) on Arm (Was "xen/memory: Introduce a hypercall to provide unallocated space") Date: Tue, 7 Sep 2021 20:09:35 +0300 Message-Id: <1631034578-12598-1-git-send-email-olekstysh@gmail.com> X-Mailer: git-send-email 2.7.4 From: Oleksandr Tyshchenko You can find an initial discussion at [1]. The extended region (safe range) is a region of guest physical address space which is unused and could be safely used to create grant/foreign mappings instead of wasting real RAM pages from the domain memory for establishing these mappings. The extended regions are chosen at the domain creation time and advertised to it via "reg" property under hypervisor node in the guest device-tree. The extended regions are calculated differently for direct mapped Dom0 (with and without IOMMU) and non-direct mapped DomUs. Please note the following limitations: - The extended region feature is only supported for 64-bit domain. - The ACPI case is not covered. Also please note that we haven't figured out yet how to properly extend the Xen hypervisor device-tree bindings on Arm (either via new compatible or via new property). I decided to go with new property for now, but this can be changed. This uncertainty is the main reason why this series is marked as RFC. Patch series is also available at [2]. The corresponding Linux changes is not in a good shape now (require some cleanup and refactoring), I will publish them once put them in order (I hope, it will be in a few days). [1] https://lore.kernel.org/xen-devel/1627489110-25633-1-git-send-email-olekstysh@gmail.com/ [2] https://github.com/otyshchenko1/xen/commits/map_opt_ml2 Oleksandr Tyshchenko (3): xen: Introduce "gpaddr_bits" field to XEN_SYSCTL_physinfo xen/arm: Add handling of extended regions for Dom0 toolstack/arm: Add handling of extended regions for DomU tools/include/libxl.h | 7 ++ tools/libs/light/libxl.c | 2 + tools/libs/light/libxl_arm.c | 92 +++++++++++++++- tools/libs/light/libxl_types.idl | 2 + xen/arch/arm/domain_build.c | 233 ++++++++++++++++++++++++++++++++++++++- xen/arch/arm/sysctl.c | 2 + xen/arch/x86/sysctl.c | 2 + xen/include/public/sysctl.h | 3 +- 8 files changed, 338 insertions(+), 5 deletions(-) -- 2.7.4 From xen-devel-bounces@lists.xenproject.org Tue Sep 07 17:10:01 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 17:10:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.181247.328327 (Exim 4.92) (envelope-from ) id 1mNebh-00030A-Ay; Tue, 07 Sep 2021 17:10:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 181247.328327; Tue, 07 Sep 2021 17:10:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNebh-000303-7C; Tue, 07 Sep 2021 17:10:01 +0000 Received: by outflank-mailman (input) for mailman id 181247; Tue, 07 Sep 2021 17:10:00 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNebg-0002hx-3O for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 17:10:00 +0000 Received: from mail-lj1-x236.google.com (unknown [2a00:1450:4864:20::236]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 28928d9d-15b1-49c5-85cf-f083d39f0e82; Tue, 07 Sep 2021 17:09:55 +0000 (UTC) Received: by mail-lj1-x236.google.com with SMTP id s3so17675394ljp.11 for ; Tue, 07 Sep 2021 10:09:54 -0700 (PDT) Received: from otyshchenko.router ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id t20sm1059533lfk.157.2021.09.07.10.09.52 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 07 Sep 2021 10:09:53 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 28928d9d-15b1-49c5-85cf-f083d39f0e82 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=r8OO/kJJTJV6IKHPTsMlElMm0wsP5l7Pgo7wl/ZjD8Y=; b=ZXLY3dMPIAwjgvH2Nnqi9I0Lo/ZLY6Y58wMChCZhiAaXZnfyvFIw3Zp5oguMdqXR5D RhQLqzfXzZY1vYvMF0pW/JIWOfp0OYQOsERKgVZklfd3uG+wX4bz7zi2Sdt+Y8Yx6dAV xAkZDRo1lpVEsdFrUnsb4JeQbNOh3ZtltvmfRHxWfEVR3T1Gcz6Kt7FtOWKeq0z3T8gr wd5vtKsCokgIvlg962mBNgh4lNnbCnOM3c0Xoww1pCfvOEuZELf7U4JUsLWZcyxd2/yt 6EEUpcJ+D1W892JPHWkj/hvIF5eO2DpNx11fMEttxneRNOsS/848n41kgnIJjy8Mhks2 pbGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=r8OO/kJJTJV6IKHPTsMlElMm0wsP5l7Pgo7wl/ZjD8Y=; b=YDgO4Jfbq++Y6z8hs61UA6PJ+5WsqFbiv4qQSNxeiMHuu4N9jA3LKW4ozqxscVRLjt l/deBhZ8gZQPdCN9jkV1PWeCAXI0BAIIaDWLWBg7nLCNHTGvL9eg5IXzFw6RF/QZqp1q QkFDfwioL+kGQjLDZZDtTzyBpHk9eIXKWBqGr7ro0PEMz1tKljfv++HJxNRhOBH6VoDy n4McCzT9BxYhnYa2pxUVbvqm6farpZICMxLCk2HFXV1Db/tOHpqLfMhkUT03KrEtZsgc 8VG5t5qhp3JKxEwFy0/I686eGrJJhU+sWJz63mkYzt67abUgWwkylQ6TjETugBU1pkKh xGyA== X-Gm-Message-State: AOAM532e2eUfa8F+TiulsfNUznec7D/pWJGFh/VT16//PuQT9mLLhGqh NFCuH3HkQvE1+Op6BTimVw0vemd8vZ8= X-Google-Smtp-Source: ABdhPJxC8qf79t1ZIF2AN8Zknfh5cN0xbkLmLI52Ll/jKPS4wGQHEL3CESZZSeVt5iwva25PNfeEqQ== X-Received: by 2002:a05:651c:893:: with SMTP id d19mr8632562ljq.268.1631034593860; Tue, 07 Sep 2021 10:09:53 -0700 (PDT) From: Oleksandr Tyshchenko To: xen-devel@lists.xenproject.org Cc: Oleksandr Tyshchenko , Ian Jackson , Wei Liu , Anthony PERARD , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Juergen Gross , Volodymyr Babchuk , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Bertrand Marquis , Wei Chen , Henry Wang Subject: [RFC PATCH 1/3] xen: Introduce "gpaddr_bits" field to XEN_SYSCTL_physinfo Date: Tue, 7 Sep 2021 20:09:36 +0300 Message-Id: <1631034578-12598-2-git-send-email-olekstysh@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1631034578-12598-1-git-send-email-olekstysh@gmail.com> References: <1631034578-12598-1-git-send-email-olekstysh@gmail.com> From: Oleksandr Tyshchenko We need to pass info about maximum supported guest address space size to the toolstack on Arm in order to properly calculate the base and size of the extended region (safe range) for the guest. The extended region is unused address space which could be safely used by domain for foreign/grant mappings on Arm. The extended region itself will be handled by the subsequents patch. Use p2m_ipa_bits variable on Arm, the x86 equivalent is hap_paddr_bits. As we change the size of structure bump the interface version. Suggested-by: Julien Grall Signed-off-by: Oleksandr Tyshchenko --- Changes since RFC: - update patch subject/description - replace arch-specific sub-struct with common gpaddr_bits field and update code to reflect that --- tools/include/libxl.h | 7 +++++++ tools/libs/light/libxl.c | 2 ++ tools/libs/light/libxl_types.idl | 2 ++ xen/arch/arm/sysctl.c | 2 ++ xen/arch/x86/sysctl.c | 2 ++ xen/include/public/sysctl.h | 3 ++- 6 files changed, 17 insertions(+), 1 deletion(-) diff --git a/tools/include/libxl.h b/tools/include/libxl.h index b9ba16d..da44944 100644 --- a/tools/include/libxl.h +++ b/tools/include/libxl.h @@ -855,6 +855,13 @@ typedef struct libxl__ctx libxl_ctx; */ #define LIBXL_HAVE_PHYSINFO_MAX_POSSIBLE_MFN 1 + /* + * LIBXL_HAVE_PHYSINFO_GPADDR_BITS + * + * If this is defined, libxl_physinfo has a "gpaddr_bits" field. + */ + #define LIBXL_HAVE_PHYSINFO_GPADDR_BITS 1 + /* * LIBXL_HAVE_DOMINFO_OUTSTANDING_MEMKB 1 * diff --git a/tools/libs/light/libxl.c b/tools/libs/light/libxl.c index 204eb0b..c86624f 100644 --- a/tools/libs/light/libxl.c +++ b/tools/libs/light/libxl.c @@ -405,6 +405,8 @@ int libxl_get_physinfo(libxl_ctx *ctx, libxl_physinfo *physinfo) physinfo->cap_vmtrace = !!(xcphysinfo.capabilities & XEN_SYSCTL_PHYSCAP_vmtrace); + physinfo->gpaddr_bits = xcphysinfo.gpaddr_bits; + GC_FREE; return 0; } diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_types.idl index 3f9fff6..f7437e4 100644 --- a/tools/libs/light/libxl_types.idl +++ b/tools/libs/light/libxl_types.idl @@ -1061,6 +1061,8 @@ libxl_physinfo = Struct("physinfo", [ ("cap_shadow", bool), ("cap_iommu_hap_pt_share", bool), ("cap_vmtrace", bool), + + ("gpaddr_bits", uint32), ], dir=DIR_OUT) libxl_connectorinfo = Struct("connectorinfo", [ diff --git a/xen/arch/arm/sysctl.c b/xen/arch/arm/sysctl.c index f87944e..91dca4f 100644 --- a/xen/arch/arm/sysctl.c +++ b/xen/arch/arm/sysctl.c @@ -15,6 +15,8 @@ void arch_do_physinfo(struct xen_sysctl_physinfo *pi) { pi->capabilities |= XEN_SYSCTL_PHYSCAP_hvm | XEN_SYSCTL_PHYSCAP_hap; + + pi->gpaddr_bits = p2m_ipa_bits; } long arch_do_sysctl(struct xen_sysctl *sysctl, diff --git a/xen/arch/x86/sysctl.c b/xen/arch/x86/sysctl.c index aff52a1..7b14865 100644 --- a/xen/arch/x86/sysctl.c +++ b/xen/arch/x86/sysctl.c @@ -135,6 +135,8 @@ void arch_do_physinfo(struct xen_sysctl_physinfo *pi) pi->capabilities |= XEN_SYSCTL_PHYSCAP_hap; if ( IS_ENABLED(CONFIG_SHADOW_PAGING) ) pi->capabilities |= XEN_SYSCTL_PHYSCAP_shadow; + + pi->gpaddr_bits = hap_paddr_bits; } long arch_do_sysctl( diff --git a/xen/include/public/sysctl.h b/xen/include/public/sysctl.h index 039ccf8..f53b42e 100644 --- a/xen/include/public/sysctl.h +++ b/xen/include/public/sysctl.h @@ -35,7 +35,7 @@ #include "domctl.h" #include "physdev.h" -#define XEN_SYSCTL_INTERFACE_VERSION 0x00000013 +#define XEN_SYSCTL_INTERFACE_VERSION 0x00000014 /* * Read console content from Xen buffer ring. @@ -120,6 +120,7 @@ struct xen_sysctl_physinfo { uint64_aligned_t outstanding_pages; uint64_aligned_t max_mfn; /* Largest possible MFN on this host */ uint32_t hw_cap[8]; + uint32_t gpaddr_bits; }; /* -- 2.7.4 From xen-devel-bounces@lists.xenproject.org Tue Sep 07 17:10:06 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 17:10:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.181248.328338 (Exim 4.92) (envelope-from ) id 1mNebm-00040L-K7; Tue, 07 Sep 2021 17:10:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 181248.328338; Tue, 07 Sep 2021 17:10:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNebm-0003za-Go; Tue, 07 Sep 2021 17:10:06 +0000 Received: by outflank-mailman (input) for mailman id 181248; Tue, 07 Sep 2021 17:10:05 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNebl-0002hx-3R for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 17:10:05 +0000 Received: from mail-lf1-x12c.google.com (unknown [2a00:1450:4864:20::12c]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 3feea662-c75e-43f0-859a-9afa379c3c52; Tue, 07 Sep 2021 17:09:55 +0000 (UTC) Received: by mail-lf1-x12c.google.com with SMTP id h16so20825989lfk.10 for ; Tue, 07 Sep 2021 10:09:55 -0700 (PDT) Received: from otyshchenko.router ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id t20sm1059533lfk.157.2021.09.07.10.09.53 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 07 Sep 2021 10:09:54 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3feea662-c75e-43f0-859a-9afa379c3c52 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=j1FVXxbL655dDi6m/uiQMBsY6jfRKFwUr0FLdTNzkcs=; b=qLChzUpurCwBuStVjudwSNRgfGuirpgjxZ5kOD55jqGSXT/hsJpD/Tqc5KLcFLygGu Sjy0+ampswXA6LxrAwchG46XYYubP4eMeG1o8LCh/pzuMPS+Cr3RfU7mLoaph8d8i7Df RNumeLv0rMY8nLH1yFgQZ9s/mlMY6va1551KPvWZQTz5QIK3AqqbKErijiuIYd7AY2Wa xOP1+r8fMKH7SOoGeakQm5KHUZ3qt4yjWhQ7n9Of31VrYCiJ6YZgoYFqkZIQLrmGlPuL 2fO2ro64uvg9KpCW60+gEn4cjbWoMwGVR+s18zqVdbc9WwhBEbcUc/b5RR9lSf6CddES WuQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=j1FVXxbL655dDi6m/uiQMBsY6jfRKFwUr0FLdTNzkcs=; b=HRszFJP8OX/Qcuete0kbPRVog7wOg2gqtHe+omL+NKWDyCagUQQfir1pkJJ5JN4mzs ghl8mFMiiW3c5GJW24N6epx5Xai/YIHljTEbF1Gx7cVpncalQegzmAlah1DT7xei8DQm TCLla8NmmGybDj4g2aaSpiF/cTw1ZkzChAaj4TIZ9xE3C2+7K+atpN0zAxxrW1kjKthL /+afbm44R/Cv4SL1tq2jyLQF08Rx2+/OMD/HhxNnbAby5p5cCbBISgYj70+z5rIKED7I bRDT3M2QQqkLKDK3SkyCp8Cpw1jDc8a8BbZDH8QQ3vz6usNs+KwePPlL4ZEN/XGKR+9U vjCw== X-Gm-Message-State: AOAM532+hDOjgrUTTWoBzRTQqBjEC19d3j/X2Dbebx7ZSKIPYARRXb7t hlNlBpfmznH+GxsdVy62ff2s8W23rfg= X-Google-Smtp-Source: ABdhPJwL3Ib/sovQSSWBncUPiMNcQtMgEHP9AlJf4cx4aSB0kd4rFfaZP6wjgO/HtJrBTyIh1OT18A== X-Received: by 2002:a19:c394:: with SMTP id t142mr13504035lff.313.1631034594744; Tue, 07 Sep 2021 10:09:54 -0700 (PDT) From: Oleksandr Tyshchenko To: xen-devel@lists.xenproject.org Cc: Oleksandr Tyshchenko , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Bertrand Marquis , Wei Chen , Henry Wang Subject: [RFC PATCH 2/3] xen/arm: Add handling of extended regions for Dom0 Date: Tue, 7 Sep 2021 20:09:37 +0300 Message-Id: <1631034578-12598-3-git-send-email-olekstysh@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1631034578-12598-1-git-send-email-olekstysh@gmail.com> References: <1631034578-12598-1-git-send-email-olekstysh@gmail.com> From: Oleksandr Tyshchenko The extended region (safe range) is a region of guest physical address space which is unused and could be safely used to create grant/foreign mappings instead of wasting real RAM pages from the domain memory for establishing these mappings. The extended regions are chosen at the domain creation time and advertised to it via "reg" property under hypervisor node in the guest device-tree. As region 0 is reserved for grant table space, introduce new "extended-region" property to inform domain about the presence of additional regions (1...N). If extended regions could not be allocated for some reason, Xen doesn't fail and behaves as usual, so only inserts region 0. Please note the following limitations: - The extended region feature is only supported for 64-bit domain. - The ACPI case is not covered. *** As Dom0 is direct mapped domain on Arm (e.g. MFN == GFN) the algorithm to choose extended regions for it is different in comparison with the algorithm for non-direct mapped DomU. What is more, that extended regions should be chosen differently whether IOMMU is enabled or not. Provide RAM not assigned to Dom0 if IOMMU is disabled or memory holes found in host device-tree if otherwise. Make sure that extended regions are 2MB-aligned and located within maximum possible addressable physical memory range. The maximum number of extended regions is 128. Suggested-by: Julien Grall Signed-off-by: Oleksandr Tyshchenko --- xen/arch/arm/domain_build.c | 233 +++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 231 insertions(+), 2 deletions(-) diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index 206038d..f9453de 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -724,6 +724,196 @@ static int __init make_memory_node(const struct domain *d, return res; } +static int __init add_ext_regions(unsigned long s, unsigned long e, void *data) +{ + struct meminfo *ext_regions = data; + paddr_t start, size; + + if ( ext_regions->nr_banks >= ARRAY_SIZE(ext_regions->bank) ) + return 0; + + /* Both start and size of the extended region should be 2MB aligned */ + start = (s + SZ_2M - 1) & ~(SZ_2M - 1); + if ( start > e ) + return 0; + + size = (e - start + 1) & ~(SZ_2M - 1); + if ( !size ) + return 0; + + ext_regions->bank[ext_regions->nr_banks].start = start; + ext_regions->bank[ext_regions->nr_banks].size = size; + ext_regions->nr_banks ++; + + return 0; +} + +/* + * The extended regions will be prevalidated by the memory hotplug path + * in Linux which requires for any added address range to be within maximum + * possible addressable physical memory range for which the linear mapping + * could be created. + * For 48-bit VA space size the maximum addressable range are: + * 0x40000000 - 0x80003fffffff + */ +#define EXT_REGION_START 0x40000000ULL +#define EXT_REGION_END 0x80003fffffffULL + +static int __init find_unallocated_memory(const struct kernel_info *kinfo, + struct meminfo *ext_regions) +{ + const struct meminfo *assign_mem = &kinfo->mem; + struct rangeset *unalloc_mem; + paddr_t start, end; + unsigned int i; + int res; + + dt_dprintk("Find unallocated memory for extended regions\n"); + + unalloc_mem = rangeset_new(NULL, NULL, 0); + if ( !unalloc_mem ) + return -ENOMEM; + + /* Start with all available RAM */ + for ( i = 0; i < bootinfo.mem.nr_banks; i++ ) + { + start = bootinfo.mem.bank[i].start; + end = bootinfo.mem.bank[i].start + bootinfo.mem.bank[i].size - 1; + res = rangeset_add_range(unalloc_mem, start, end); + if ( res ) + { + printk(XENLOG_ERR "Failed to add: %#"PRIx64"->%#"PRIx64"\n", + start, end); + goto out; + } + } + + /* Remove RAM assigned to Dom0 */ + for ( i = 0; i < assign_mem->nr_banks; i++ ) + { + start = assign_mem->bank[i].start; + end = assign_mem->bank[i].start + assign_mem->bank[i].size - 1; + res = rangeset_remove_range(unalloc_mem, start, end); + if ( res ) + { + printk(XENLOG_ERR "Failed to remove: %#"PRIx64"->%#"PRIx64"\n", + start, end); + goto out; + } + } + + /* Remove reserved-memory regions */ + for ( i = 0; i < bootinfo.reserved_mem.nr_banks; i++ ) + { + start = bootinfo.reserved_mem.bank[i].start; + end = bootinfo.reserved_mem.bank[i].start + + bootinfo.reserved_mem.bank[i].size - 1; + res = rangeset_remove_range(unalloc_mem, start, end); + if ( res ) + { + printk(XENLOG_ERR "Failed to remove: %#"PRIx64"->%#"PRIx64"\n", + start, end); + goto out; + } + } + + /* Remove grant table region */ + start = kinfo->gnttab_start; + end = kinfo->gnttab_start + kinfo->gnttab_size - 1; + res = rangeset_remove_range(unalloc_mem, start, end); + if ( res ) + { + printk(XENLOG_ERR "Failed to remove: %#"PRIx64"->%#"PRIx64"\n", + start, end); + goto out; + } + + start = EXT_REGION_START; + end = min((1ULL << p2m_ipa_bits) - 1, EXT_REGION_END); + res = rangeset_report_ranges(unalloc_mem, start, end, + add_ext_regions, ext_regions); + if ( res ) + ext_regions->nr_banks = 0; + else if ( !ext_regions->nr_banks ) + res = -ENOENT; + +out: + rangeset_destroy(unalloc_mem); + + return res; +} + +static int __init find_memory_holes(const struct kernel_info *kinfo, + struct meminfo *ext_regions) +{ + struct dt_device_node *np; + struct rangeset *mem_holes; + paddr_t start, end; + unsigned int i; + int res; + + dt_dprintk("Find memory holes for extended regions\n"); + + mem_holes = rangeset_new(NULL, NULL, 0); + if ( !mem_holes ) + return -ENOMEM; + + /* Start with maximum possible addressable physical memory range */ + start = EXT_REGION_START; + end = min((1ULL << p2m_ipa_bits) - 1, EXT_REGION_END); + res = rangeset_add_range(mem_holes, start, end); + if ( res ) + { + printk(XENLOG_ERR "Failed to add: %#"PRIx64"->%#"PRIx64"\n", + start, end); + goto out; + } + + /* Remove all regions described by "reg" property (MMIO, RAM, etc) */ + dt_for_each_device_node( dt_host, np ) + { + unsigned int naddr; + u64 addr, size; + + naddr = dt_number_of_address(np); + + for ( i = 0; i < naddr; i++ ) + { + res = dt_device_get_address(np, i, &addr, &size); + if ( res ) + { + printk(XENLOG_ERR "Unable to retrieve address %u for %s\n", + i, dt_node_full_name(np)); + goto out; + } + + start = addr & PAGE_MASK; + end = PAGE_ALIGN(addr + size) - 1; + res = rangeset_remove_range(mem_holes, start, end); + if ( res ) + { + printk(XENLOG_ERR "Failed to remove: %#"PRIx64"->%#"PRIx64"\n", + start, end); + goto out; + } + } + } + + start = EXT_REGION_START; + end = min((1ULL << p2m_ipa_bits) - 1, EXT_REGION_END); + res = rangeset_report_ranges(mem_holes, start, end, + add_ext_regions, ext_regions); + if ( res ) + ext_regions->nr_banks = 0; + else if ( !ext_regions->nr_banks ) + res = -ENOENT; + +out: + rangeset_destroy(mem_holes); + + return res; +} + static int __init make_hypervisor_node(struct domain *d, const struct kernel_info *kinfo, int addrcells, int sizecells) @@ -731,11 +921,13 @@ static int __init make_hypervisor_node(struct domain *d, const char compat[] = "xen,xen-"__stringify(XEN_VERSION)"."__stringify(XEN_SUBVERSION)"\0" "xen,xen"; - __be32 reg[4]; + __be32 reg[(NR_MEM_BANKS + 1) * 4]; gic_interrupt_t intr; __be32 *cells; int res; void *fdt = kinfo->fdt; + struct meminfo *ext_regions; + unsigned int i; dt_dprintk("Create hypervisor node\n"); @@ -757,15 +949,52 @@ static int __init make_hypervisor_node(struct domain *d, if ( res ) return res; + ext_regions = xzalloc(struct meminfo); + if ( !ext_regions ) + return -ENOMEM; + + if ( is_32bit_domain(d) ) + printk(XENLOG_WARNING "The extended region is only supported for 64-bit guest\n"); + else + { + if ( !is_iommu_enabled(d) ) + res = find_unallocated_memory(kinfo, ext_regions); + else + res = find_memory_holes(kinfo, ext_regions); + + if ( res ) + printk(XENLOG_WARNING "Failed to allocate extended regions\n"); + } + /* reg 0 is grant table space */ cells = ®[0]; dt_child_set_range(&cells, addrcells, sizecells, kinfo->gnttab_start, kinfo->gnttab_size); + /* reg 1...N are extended regions */ + for ( i = 0; i < ext_regions->nr_banks; i++ ) + { + u64 start = ext_regions->bank[i].start; + u64 size = ext_regions->bank[i].size; + + dt_dprintk("Extended region %d: %#"PRIx64"->%#"PRIx64"\n", + i, start, start + size); + + dt_child_set_range(&cells, addrcells, sizecells, start, size); + } + xfree(ext_regions); + res = fdt_property(fdt, "reg", reg, - dt_cells_to_size(addrcells + sizecells)); + dt_cells_to_size(addrcells + sizecells) * (i + 1)); if ( res ) return res; + if ( i > 0 ) + { + res = fdt_property(fdt, "extended-region", NULL, 0); + if ( res ) + return res; + } + BUG_ON(d->arch.evtchn_irq == 0); /* -- 2.7.4 From xen-devel-bounces@lists.xenproject.org Tue Sep 07 17:10:12 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 17:10:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.181249.328349 (Exim 4.92) (envelope-from ) id 1mNebr-0004Rb-V0; Tue, 07 Sep 2021 17:10:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 181249.328349; Tue, 07 Sep 2021 17:10:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNebr-0004R7-Qm; Tue, 07 Sep 2021 17:10:11 +0000 Received: by outflank-mailman (input) for mailman id 181249; Tue, 07 Sep 2021 17:10:10 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNebq-0002hx-3l for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 17:10:10 +0000 Received: from mail-lf1-x12a.google.com (unknown [2a00:1450:4864:20::12a]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id bb19d5b4-180d-4792-9daf-20ca2f636c64; Tue, 07 Sep 2021 17:09:57 +0000 (UTC) Received: by mail-lf1-x12a.google.com with SMTP id z2so20891905lft.1 for ; Tue, 07 Sep 2021 10:09:56 -0700 (PDT) Received: from otyshchenko.router ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id t20sm1059533lfk.157.2021.09.07.10.09.54 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 07 Sep 2021 10:09:55 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bb19d5b4-180d-4792-9daf-20ca2f636c64 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Ya0iv+xjtgk+KbWZdbpF+3/p23xC0vgD9QxwNHC4wzo=; b=ZYoki/JEJRYk82IEIOvaWK4Wj0RDoDRnDs+qMeGITnAE5fQOGPxG4YvHb7M1c0I7OH oPVly8GrZynKZArYCRdjo8IPiBJjR+CLFeOD09+d2NUboOq/CfC1wuJt9ppejFLN8UWm bsdZAwRr6DgLcNnOTa7ZrKfqpKfUQgu0FKuCnJg0JWXWVH6lwEgOTxzDIx77Zg9mOikR K6qGqqnWAHGg78fzStMheeIFFiOk2ckTMzbPXFCDWEnvRC7/sgZM13IWqiro3WFoRAM/ kOLFWUEmQBxWND74h9uOKAMYYQC9WjSbbIzOWVYyXybx9w4HWmcRGxCLwwPt0Q8rpEzF qaCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Ya0iv+xjtgk+KbWZdbpF+3/p23xC0vgD9QxwNHC4wzo=; b=oRr+OmD5AGR8cJCunGAF3kO2Pjha8sWEd6+NODrX4aEEG1GfhkeiiPoFBZzuP7FN/U RrmsIL0xtf3Dxsf91JalZAiLrRzwO3Wfg2k5wEc86TVEKnGHP8QvqcmzV5CTyJS7HH+5 QQVVLM6ip00j0g15voXyqNNmVFtMKPJgh/I5uV/j/srCY8GUNHJoVfPA/53CFxIYmOuI TfWU5BeVIKhLzxbmxzxkPNIEDl4AJOYluI3bS86NP4612Sx6aKaxc2d4h9AfLb0x01BO QY8sYjhX8ENPddfF/pRHSOYCF7ru3VzurjwwctJT84ZW1TPI9LgG1E5o7DtOC18oWvuS T72Q== X-Gm-Message-State: AOAM530a5YI0YF41g+mrgWtUqw70YIX2TZRmOBAKOTZZidHPdsfkVtNq T1aPz82WvCNhKgiUjCu7rN1V+oIPPT8= X-Google-Smtp-Source: ABdhPJxT0Q6VmD3LuyWEIxjpy/iZPkXyU7wuzlg78/XTigbVbBnOWhav/35Lhnf8aIy10QA2uNHfMg== X-Received: by 2002:a05:6512:32c6:: with SMTP id f6mr13316789lfg.292.1631034595700; Tue, 07 Sep 2021 10:09:55 -0700 (PDT) From: Oleksandr Tyshchenko To: xen-devel@lists.xenproject.org Cc: Oleksandr Tyshchenko , Ian Jackson , Wei Liu , Anthony PERARD , Juergen Gross , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Bertrand Marquis , Wei Chen , Henry Wang Subject: [RFC PATCH 3/3] toolstack/arm: Add handling of extended regions for DomU Date: Tue, 7 Sep 2021 20:09:38 +0300 Message-Id: <1631034578-12598-4-git-send-email-olekstysh@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1631034578-12598-1-git-send-email-olekstysh@gmail.com> References: <1631034578-12598-1-git-send-email-olekstysh@gmail.com> From: Oleksandr Tyshchenko The extended region (safe range) is a region of guest physical address space which is unused and could be safely used to create grant/foreign mappings instead of wasting real RAM pages from the domain memory for establishing these mappings. The extended regions are chosen at the domain creation time and advertised to it via "reg" property under hypervisor node in the guest device-tree. As region 0 is reserved for grant table space, introduce new "extended-region" property to inform domain about the presence of additional regions (1...N). If extended regions could not be allocated for some reason, Xen doesn't fail and behaves as usual, so only inserts region 0. Please note the following limitations: - The extended region feature is only supported for 64-bit domain. - The ACPI case is not covered. *** The algorithm to choose extended regions for non-direct mapped DomU is simpler in comparison with the algorithm for direct mapped Dom0. As we have a lot of unused space above 4GB, provide single 1GB-aligned region from the second RAM bank taking into the account the maximum supported guest address space size and the amount of memory assigned to the guest. The maximum size of the region is 128GB. Suggested-by: Julien Grall Signed-off-by: Oleksandr Tyshchenko --- tools/libs/light/libxl_arm.c | 92 +++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 90 insertions(+), 2 deletions(-) diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c index e3140a6..41cf017 100644 --- a/tools/libs/light/libxl_arm.c +++ b/tools/libs/light/libxl_arm.c @@ -615,9 +615,23 @@ static int make_hypervisor_node(libxl__gc *gc, void *fdt, "xen,xen"); if (res) return res; - /* reg 0 is grant table space */ + /* + * reg 0 is a placeholder for grant table space, reg 1 is a placeholder + * for the extended region. + */ res = fdt_property_regs(gc, fdt, GUEST_ROOT_ADDRESS_CELLS, GUEST_ROOT_SIZE_CELLS, - 1,GUEST_GNTTAB_BASE, GUEST_GNTTAB_SIZE); + 2, 0, 0, 0, 0); + if (res) return res; + + /* + * TODO: It would be correct to advertise that we provide the extended + * region after allocating it in finalise_ext_region(). The reason why we do + * this right now (in advance) is because we cannot insert a properly in + * finalise_ext_region(), but we have a mechanism to remove it there. + * So, if we are not able to allocate the region later on, we will remove + * the property. + */ + res = fdt_property(fdt, "extended-region", NULL, 0); if (res) return res; /* @@ -1069,6 +1083,78 @@ static void finalise_one_node(libxl__gc *gc, void *fdt, const char *uname, } } +#define ALIGN_UP_TO_GB(x) (((x) + GB(1) - 1) & (~(GB(1) - 1))) + +#define EXT_REGION_SIZE GB(128) + +static void finalise_ext_region(libxl__gc *gc, struct xc_dom_image *dom) +{ + void *fdt = dom->devicetree_blob; + uint32_t regs[(GUEST_ROOT_ADDRESS_CELLS + GUEST_ROOT_SIZE_CELLS) * 2]; + be32 *cells = ®s[0]; + uint64_t region_size = 0, region_base, bank1end_align, bank1end_max; + uint32_t gpaddr_bits; + libxl_physinfo info; + int offset, rc; + + offset = fdt_path_offset(fdt, "/hypervisor"); + assert(offset > 0); + + if (strcmp(dom->guest_type, "xen-3.0-aarch64")) { + LOG(WARN, "The extended region is only supported for 64-bit guest"); + goto out; + } + + rc = libxl_get_physinfo(CTX, &info); + assert(!rc); + + gpaddr_bits = info.gpaddr_bits; + assert(gpaddr_bits >= 32 && gpaddr_bits <= 48); + + /* + * Try to allocate single 1GB-aligned extended region from the second RAM + * bank (above 4GB) taking into the account the maximum supported guest + * address space size and the amount of memory assigned to the guest. + * The maximum size of the region is 128GB. + */ + bank1end_max = min(1ULL << gpaddr_bits, GUEST_RAM1_BASE + GUEST_RAM1_SIZE); + bank1end_align = GUEST_RAM1_BASE + + ALIGN_UP_TO_GB((uint64_t)dom->rambank_size[1] << XC_PAGE_SHIFT); + + if (bank1end_max <= bank1end_align) { + LOG(WARN, "The extended region cannot be allocated, not enough space"); + goto out; + } + + if (bank1end_max - bank1end_align > EXT_REGION_SIZE) { + region_base = bank1end_max - EXT_REGION_SIZE; + region_size = EXT_REGION_SIZE; + } else { + region_base = bank1end_align; + region_size = bank1end_max - bank1end_align; + } + +out: + /* + * The first region for grant table space must be always present. + * If we managed to allocate the extended region then insert it as + * a second region. Otherwise, remove the property that advertises it. + */ + set_range(&cells, GUEST_ROOT_ADDRESS_CELLS, GUEST_ROOT_SIZE_CELLS, + GUEST_GNTTAB_BASE, GUEST_GNTTAB_SIZE); + if (region_size > 0) { + LOG(DEBUG, "Extended region: %#"PRIx64"->%#"PRIx64"\n", + region_base, region_base + region_size); + + set_range(&cells, GUEST_ROOT_ADDRESS_CELLS, GUEST_ROOT_SIZE_CELLS, + region_base, region_size); + } else + fdt_nop_property(fdt, offset, "extended-region"); + + rc = fdt_setprop_inplace(fdt, offset, "reg", regs, sizeof(regs)); + assert(!rc); +} + int libxl__arch_domain_finalise_hw_description(libxl__gc *gc, uint32_t domid, libxl_domain_config *d_config, @@ -1109,6 +1195,8 @@ int libxl__arch_domain_finalise_hw_description(libxl__gc *gc, } + finalise_ext_region(gc, dom); + for (i = 0; i < GUEST_RAM_BANKS; i++) { const uint64_t size = (uint64_t)dom->rambank_size[i] << XC_PAGE_SHIFT; -- 2.7.4 From xen-devel-bounces@lists.xenproject.org Tue Sep 07 17:13:48 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 17:13:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.181273.328360 (Exim 4.92) (envelope-from ) id 1mNefL-0006MN-N2; Tue, 07 Sep 2021 17:13:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 181273.328360; Tue, 07 Sep 2021 17:13:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNefL-0006MG-Jw; Tue, 07 Sep 2021 17:13:47 +0000 Received: by outflank-mailman (input) for mailman id 181273; Tue, 07 Sep 2021 17:13:46 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNefK-0006MA-4J for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 17:13:46 +0000 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 9b996f2e-ce1e-40d3-8f9c-8ad88b944c99; Tue, 07 Sep 2021 17:13:45 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9b996f2e-ce1e-40d3-8f9c-8ad88b944c99 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1631034824; h=to:cc:references:from:subject:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=GJ3bNmTS1SCgQmc3iJNrcycJ8ksUb33jC2GsqzoyOMY=; b=TmkorK7brbNkvBlntW1C2GUuCVh/IyIe9ctxluPM0qFpKD8cpMSsmWXh qhqhghQHelnW2HXPm5GOHs6RplKStIYgda2C1Es0Llf0EIGpUNYOZTsv5 CiAi9fnXu+8wB/UAm31ZJvcl/YaCy5PxHmGR7LnW/1zLGzRYdfaaLs2w7 c=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: xthbV/wYKObH9XYXDBoscF+DLVj3fg2Le+AN78iur3lWnjc+uWj2fX8qjGAKO/1qWBW7TGjJc0 fetO4bcq12gxg+rBPwLHlIxiyowWVrPBO3IodEBFFjSVgxMrZfAuY1r0uA0+OvOu0MWORoRrCZ WjKMsuceHcFgC9tSTgsg8t7jVf5S7uM9a1WgINK7kRDfO3OxwmAd4euiC3JAByTLH4YzLRSaV3 b/pdb17PzBAgATKHZwXbwr+If3sO9Q2dRLgS0Gzx8bX4tMIF+XGl6ubL71xLkW33JdJoI+HKrf 3iCfjTT4JCWedPBo7mKaz15Z X-SBRS: 5.1 X-MesageID: 51782389 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:QrjXcqAsKD89qOTlHemQ55DYdb4zR+YMi2TDsHoBLSC9E/bo8v xG885rtiMc5AxxZJhCo7690cu7MBThHPdOiOF6UItKNDOW3ldAR7sSj7cKrQeBJ8TWzJ8l6U 8+GJIUNDSLNzdHZGzBkXGF+q0brOW6zA== X-IronPort-AV: E=Sophos;i="5.85,274,1624334400"; d="scan'208";a="51782389" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cAZ7dx2t6MPKD/Cwl7e2n6jSgZObv3CFTvGCVph/DjqGibmqqEAjl7VakRqZSyslN0Xk/ZuBKjCpnI4j8RGoCUogvHK7X51uYn6dbKHdgWspvhYJBMed/rT4YuYtVrvecWgg0i5+iZb5EPIi7NpSl2R6P/wYce+s38hF0x14gKn8UiTUYbRacAHPQhj6ZSfT3m3HVEwohInn2bP8UjjIV6wKCybqyLlmNKvRQ/A5bBaSbktSdOjxfiekVMY/o4IoYdqo0f8gSj4z8Ld7K2eNuKUxgh3S88VD/OEoAVyv5GpNfAy+3whGI77zTea42niBygFiNKB6HGfZH9JwGq+T9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=GJ3bNmTS1SCgQmc3iJNrcycJ8ksUb33jC2GsqzoyOMY=; b=EA6KHDfd9OxBSSOH3w4COol4f9i/QwkChFKl87s4Cq0nTYlUkC8nA8t7CzUKUWVaYqdtBE0CloExRRxriXkw65PITgo/ULbWSJRZmN4tEyzo3lKKsU4hiYxbR4N3gDfAX0GbVQT6YYjYYJt0LPKbs0jRbFCiOqOj39XGyQm9E6gvprMnpqc+HYBRyZeq9O6BnhBmfn/fp+CYPJ9HSUeWM4XNsDPrhZ+AYDiCx97PRTeFktub+LAYlo9PeVACV+irB+0BMatFr7om8UHck60Xs7ZMpdDsTigV6qE0cLuqrdxUSSAYLhyJDdb881bqAw1KDX/jwv57FnpZzCm5faGCYA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GJ3bNmTS1SCgQmc3iJNrcycJ8ksUb33jC2GsqzoyOMY=; b=DolPnkG8UAcZGy6OjHGOedRs3Z2a/fEqQMQu4MFO9bcRlAdo+qxqc7VCcAtjVEaqBhQhBwMjS+z5w2KEKHSIsWxyAM/ky4qrOYv92sK8zTvpyvtY+7zK+SgkMHZTwiLG+usE7qsAG6Grv4lQbzrnOmUu8G1QEAPnAa40vsF4HWc= To: Jan Beulich CC: Paul Durrant , "xen-devel@lists.xenproject.org" References: <5d6e8360-7ba8-487e-0ac8-7f517e560520@suse.com> <42aa8c24-7f23-deec-6103-f2d556e4a9f9@citrix.com> From: Andrew Cooper Subject: Re: [PATCH 07/17] IOMMU/x86: restrict IO-APIC mappings for PV Dom0 Message-ID: <3f9722e4-704b-8f68-553d-04a3a3189d99@citrix.com> Date: Tue, 7 Sep 2021 18:13:36 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: en-GB X-ClientProxiedBy: LO2P265CA0069.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:60::33) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 455a7645-da4e-4d03-7d72-08d97222d774 X-MS-TrafficTypeDiagnostic: BY5PR03MB4965: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mAhLbOA+3AX5whahOBH0gJdWUAh8V+z+SVBJkvaU206exP1awKVvRVkC/D0Q/PD+/G3G/cnP5WJPIYOqROun7nTvwwKf0CQLXHJOhJIDJ679QBdTlbpYX65FJIXsa9WXvEn9aESK8NWzK1jv/YbJopYqrBiCtn3LmXWJ58fk/veZgtsvWx4OjQbPRx+th9UcQ+9Jc8AVKS1J7hAEN26ThivD679kXZLi03JQJ+KIIO20EWOZidTc3BWb8l3546cfGLH9SwrDJmndJIH6nzhQZcgbZO9gPUS24GXY+rlKjDUuOaRH2jha+JyCIEWegGkjI4WRXCNv/yqKi4rHH6+Rkdxb9ua+sjZzT8i9tgAOKwtv3Pvl01OzG74omgFR1xSn6x3zGPa6RwHV9OZRMBIEWHHpOc369f94gioZ6eo+82zI8SY+BxLxChAdj7SiezfVGPOBnlyrHDFZryZTRQmXWZ6rlDc4HegQK7LRoPoaWD0X8q41fl/txzGqTWW4/dPCKyWoHJlnkigVvWkSvOkM0e1qTUdYD37CxT9hY3lOsYNB1gMLi2e8k1iYGJ2ksfuqUfXpOWmPB9uT8OjjbV2r4Lyd6KbF+Zq0NUW9Qlr/+2wgE/a2BUuoVoxwqHWpA1nfBvLGE4Py2QWIeiyJwgq6xzIMu1Om+8uyVD1AGzXpODoVZprEHyeTFGIkEViBc30qDuBTCtUu8iS9MLucFzVcu8Xef8UzZH/Y2eX23ZzzP0U= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(376002)(366004)(39860400002)(136003)(396003)(186003)(53546011)(86362001)(478600001)(36756003)(8936002)(316002)(5660300002)(6486002)(38100700002)(31686004)(66946007)(6916009)(55236004)(66476007)(4326008)(2906002)(16576012)(31696002)(83380400001)(26005)(6666004)(54906003)(2616005)(8676002)(956004)(66556008)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bEpnWnVmSGl4cG9QdU1aT0F4K0J1bXVPUyt6Zk9FR1gwd0dXUm9DMTF2dXow?= =?utf-8?B?RytYbTJDWjFURnZQVnVFdWQ4YU83eXpUNHQrdm5Ib2NISEQyS3ZyeVc4VVFV?= =?utf-8?B?Z2tYdWltSDh4Q2k1cEQ1Y0pabFBnWFlEbmxlUC9CMkxvQ1BRVlB2WE5KNTFo?= =?utf-8?B?SG53dmVkZGlVU1J5bllibW83V24yM2V5d1BHTGhrY2xIQnNLRkhZYklqKzVm?= =?utf-8?B?UW8rN0U0K0NuZ2orK2RWb0hYWHdmSHkrRWRJZlhOVVNTWEtLZkxHcWxwaXRP?= =?utf-8?B?VCtwdkpSV2dYQml5d0kwRll4Q082RG4yZmlQV1ZMalZxTlRNSG1oNHNWSVRQ?= =?utf-8?B?TEthQjFicWZ4RlBKa0RrMGZMeXVjN2tsV25CNTV2TDFyalhCVm5zYVVtRkJD?= =?utf-8?B?LzNNTE44RHhiZmt6T1ZXbU9yZTBUSEU2L2FIZWVHeUs0QkVPcE5BUEorSTEv?= =?utf-8?B?YzgvNi9WOGlyeWhTUDVEa0I5RGRScWN2QVlHaGJKY3A2UTBjVDMydDZHSGVW?= =?utf-8?B?dWM2aWlxMkRXZjFRTDNPcnV2Y1hzbGJjRUxHd0VYbVRiTENzSldOS0RUM3FY?= =?utf-8?B?STZEVUYrM1lvMnd3OUp0eExsU0MreDVPenZaUGllWXNDaHdGMThEMGl4cklk?= =?utf-8?B?TDJ3b21EdjkvMmMxZTNoZ1NmQkFET1plRWRteXNYdG5jcmg4Uk9GTklpU1Mz?= =?utf-8?B?YjZwNjdKcWNURkJTcHhSOXIxaGlIUFZXOGh4SFNURlpzNTc5NXduSVVrK3Qz?= =?utf-8?B?ZXFwQ1RWVVRvRjRNcit6YnZvTzZvL0lyOUEvaTdpSWZqbXR0bTBSOGFEdEtG?= =?utf-8?B?bVpNOEx4L1VEcXExclhiQVg0MGFzeVF6OFZMeC81bHhjMVpOWUFiYXlkWGo0?= =?utf-8?B?Tkl5NXMzdHpjbU1JV2dHZGRaeHUxTU5vNll1dCtLZWxaMjliemRlNnBtV3p0?= =?utf-8?B?cDd4NUJRWXp3cWQ0NkpyU3dlS0pIL2pIVkVnWmE4ZUVWZW1VRWRjZi9EVFdB?= =?utf-8?B?WlNxTzBGT1FTV2IxdVlvVitXaFlDZkVjOVdZSjh1RHpzMHJQWGwvUmY1UnhN?= =?utf-8?B?SFNkYklZMjlGNDlDN1NPZnI3YW9oSzEwTmJ6aFhNN1dOempXajMzWUUwam0w?= =?utf-8?B?bitScWdpck10MjhEdVh4Y0hOdWJPdFU3NU1pRGxUbm43V2hncHFhUUxNSTZo?= =?utf-8?B?OEdEc09tcER2UkNlQjZkZ0c5TzZwUzEwNzk5TWFqdGJKamhlVWI2Nm9xSTcr?= =?utf-8?B?ZnlrZW9HZEkrbWtDSEdlOFVacUJCd05CU3RzLzJFRnFxMXRrZFdiR2grdEh5?= =?utf-8?B?bnNVN1dwcU14NUNhL1hYMllwVWtxUFNIYjV0Ym8rM0tBblNvdStLdnFGbmFx?= =?utf-8?B?V0JwSTZpc1I5cjlQOG1jYy8xY21sWm5ncGpUbFNEZ3pXR0h5NjZ5SW56b1Mx?= =?utf-8?B?enRGWUdXaTF0S29DOTB5NXVXaG5kQ2p3TnhMYnlrdXhhTnFFaG1OdnJyNVZH?= =?utf-8?B?U0hOeVlCV2M0bTNZRlc5OVpCL2s1UDhOakVvRUF4dm1PZjYwNE1vUEJPMDhE?= =?utf-8?B?NFAvcUljdGtSNEtuRFBBQmhjZVJaN2Y0dEhLQ3I0ZnBDanFqNWVwWGI2bDlS?= =?utf-8?B?Qm1pZmVGSGRjeHlMRVpCMHk3akdDMGV3eSsrbWxTY0VjbXZyMXhCdUVEdkRJ?= =?utf-8?B?VWVjRjdoV3o1T0hIbFZjOWJ4YkFUUlhmMVNvUGJhckpRSStXcnBsNW9zU3Fq?= =?utf-8?Q?HkHQbPhbGSbu/AI3tCujzYfl6V5Fl75IsxkPNms?= X-MS-Exchange-CrossTenant-Network-Message-Id: 455a7645-da4e-4d03-7d72-08d97222d774 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2021 17:13:42.1794 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: oFZG24g9Ki2IkBLBZLaFaoglD+PQvcDLK6SuRREk6pqGzMChZNnwFwEecJ4uJ3bGjxrjMxtKYLd+hLnqV1vUmasRXqsoFQMtpf9Nw1rY5lI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR03MB4965 X-OriginatorOrg: citrix.com On 26/08/2021 13:55, Jan Beulich wrote: > On 26.08.2021 13:57, Andrew Cooper wrote: >> On 24/08/2021 15:21, Jan Beulich wrote: >>> While already the case for PVH, there's no reason to treat PV >>> differently here, though of course the addresses get taken from another >>> source in this case. Except that, to match CPU side mappings, by defaul= t >>> we permit r/o ones. This then also means we now deal consistently with >>> IO-APICs whose MMIO is or is not covered by E820 reserved regions. >>> >>> Signed-off-by: Jan Beulich >> Why do we give PV dom0 a mapping of the IO-APIC?=C2=A0 Having thought ab= out >> it, it cannot possibly be usable. >> >> IO-APICs use a indirect window, and Xen doesn't perform any >> write-emulation (that I can see), so the guest can't even read the data >> register and work out which register it represents.=C2=A0 It also can't = do an >> atomic 64bit read across the index and data registers, as that is >> explicitly undefined behaviour in the IO-APIC spec. >> >> On the other hand, we do have PHYSDEVOP_apic_{read,write} which, despite >> the name, is for the IO-APIC not the LAPIC, and I bet these hypercalls >> where introduced upon discovering that a read-only mapping of the >> IO-APIC it totally useless. >> >> I think we can safely not expose the IO-APICs to PV dom0 at all, which >> simplifies the memory handling further. > The reason we do expose it r/o is that some ACPI implementations access > (read and write) some RTEs from AML. If we don't allow Dom0 to map the > IO-APIC, Dom0 will typically fail to boot on such systems. I think more details are needed. If AML is reading the RTEs, it's is also writing to the index register. Irrespective of Xen, doing this behind the back of the OS cannot work safely, because at a minimum the ACPI interpreter would need to take the ioapic lock, and I see no evidence of workarounds like this in Linux. In Xen, we appear to swallow writes to mmio_ro ranges which is rude, and causes the associated reads to read garbage.=C2=A0 This is Xen-induced memo= ry corruption inside dom0. I don't think any of this is legitimate behaviour.=C2=A0 ACPI needs disabli= ng on such systems, or interlocking suitably, and its not just IO-APICs which are problematic - any windowed I/O (e.g. RTC) as well as any other device with read side effects. I think we should seriously consider not mapping the IO-APIC at all.=C2=A0 That said, I would be surprised if Linux is cleanly avoiding the IO-APIC, so a slightly less bad alternative is to redirect to an "MMIO" frame of ~0's which we still write-discard on top of. That at least makes the Xen-induced memory corruption behave deterministically. ~Andrew From xen-devel-bounces@lists.xenproject.org Tue Sep 07 17:36:17 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 17:36:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.181283.328371 (Exim 4.92) (envelope-from ) id 1mNf0s-0000uZ-Ho; Tue, 07 Sep 2021 17:36:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 181283.328371; Tue, 07 Sep 2021 17:36:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNf0s-0000uS-EB; Tue, 07 Sep 2021 17:36:02 +0000 Received: by outflank-mailman (input) for mailman id 181283; Tue, 07 Sep 2021 17:36:00 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNf0q-0000uG-Ml for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 17:36:00 +0000 Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 10316374-1002-11ec-b118-12813bfff9fa; Tue, 07 Sep 2021 17:35:59 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 10316374-1002-11ec-b118-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1631036159; h=to:cc:references:from:subject:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=GsjaAJfgrCNlIL34Yd1ZnN8XhjsnG6kdA+YSA8g09jA=; b=WAQi6ntvivcCU3IKdj+sXl9/mFNwrqOYo9Y7wk9wHWu6bcBQqnwn5cnY UuYtp0X82tN7vUS8MZ4m84gIMb3gGFeR7eo9+tohZM47/W80+qTQycbGN nDKGWMplvb9gDNB/9YoxaPpIf6h1DWQ0IAOcNH/E208PgOnt1tnmlVL4q 8=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: zB0VZmyGTwWt9Gp2YY0ZTcUaN4I7s/9xxEWc7AgJRZaxRmpIWhQMJuigtR8tFbt7NGDlCQix9V Yl9sg4DS7rpdvBt2YyErcykB2PvKaQO5Ip5x4TwO05QXEwkcwam6akdwwmhqUMa0Bszih1rhJn T3e0IbaYBEu13hOeI/RzW1IC0aBLed6LM7MXX9Bt/tQYVORXhTmjMmMdK1P+AacTL/eASdr6vA 0QzFo9cBMqu1B7kuLXXNm5gIAharup2oiII8tEDWzCrW4j392qA7GZ4pfrtM00LDy04Ge0z0vs 3SVpeL6365z04GXdqiR9lzP+ X-SBRS: 5.1 X-MesageID: 53939861 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:IhhBFaoFt/emnMtespdSRMIaV5u8L9V00zEX/kB9WHVpm5Oj+P xGzc526farslsssREb+OxpOMG7MBbhHO1OkPYs1NCZLXXbUQqTXfxfBO7ZrQEIdBeOjtK1uZ 0QFJSWTeeAd2SS7vyKkDVQcexQueVvmZrA7Yy1rwYPPHJXguNbnmNE426gYzxLrWJ9dPwE/f Snl6h6TnabCA8qhpPRPAh6YwGPnayGqLvWJTo9QzI34giHij2lrJb8Dhijxx8bFxdC260r/2 TpmxHwovzLiYD09jbsk0voq7hGktrozdVOQOSKl8guMz3pziKlfp5oVbGutC085Muv9FEput /RpApIBbU911rhOkWO5Tf90Qjp1zgjr1fk1F+jmHPm5ff0QTorYvAxzr5xQ1/80Q4Nrdt82K VE0yayrJxMFy7Nmyz7+pzhSwxqvlDcmwtgrccjy1hkFacOYr5YqoISuGlPFo0bIS784Ic7VM FzEcDn4upMe1/yVQGYgoBW+q3oYp0PJGbDfqBb0fbllAS+3UoJjnfw/fZv3Evpr/kGOt95D+ etCNUhqFgBdL5OUUrRbN1xNvdfMVa9NC4kBljiaGgPJJt3SU4llKSHlIndxNvaMqDgn6FC1a gobjtjxBgPkgTVeJWz4KE= X-IronPort-AV: E=Sophos;i="5.85,274,1624334400"; d="scan'208";a="53939861" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=h2kVk7IR4CL6JHvSHeBqgj7uXWQIFar8/3EJ4/kHNDSFAePmw3Oj4bI/4MH/ufqBRRFrsZWxWJBksQuRau3ZappG/N9KkG8XnSkJORDiCE2ldilCu+JD9VHyaq+HY8t4EEERDVyVYDwdmjbSE/wFh/b54vJKMvydBrCQP0hXl8+eut2d+FERIrWnukC5OJd8lZsXL/0911FS640w34VYFFX3ExSQzoJRK1kJlD6LSXk1k+218E3Jth2WYKf0wirGR8JQiTR6KKehLwjGxWliZTBY4lJJ4Cpe8uKsLP0JzB81c9jyATCWbzqwOBnK+xlrYkL+W/Lwk1EdE8Z5trOZDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=GsjaAJfgrCNlIL34Yd1ZnN8XhjsnG6kdA+YSA8g09jA=; b=X51eO0bU1D5ZcbYB2zRrRkfg6zzGrgHoM9AyyCVWlNpFbRT9qtBIqyDk1JhfZuDH8nMrqpjornwS4KwjMwofGrBAELdvC1ywcwhwjFTptq7MCyb8U/afX7DnuHFiY8YzNQCrctBTzzWMsvzet85RngdlOW2wMG1PMCL2xEZJGyYFXbXQhDxbNS7dNqi9JA9oOs/yAhx9KQK6j1fhJ/OC/KU12EXqenZ4ZZ90qR3hUYQiUZf9f59B7RH5API2ck8PI1IuesWxH6O0XAm6m7hFKtGJ5y0HdqwbOymzehiPo0zPm7AUzxh6tl+ZoGsgKb484cJP/3mMkwKiboxyjznT1Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GsjaAJfgrCNlIL34Yd1ZnN8XhjsnG6kdA+YSA8g09jA=; b=jE7LUW1ixHrrRoSkONH1AZ4W0O5FXvXESxNZROtkmuDbK+DaZ2zjJmv9JWuxD27/u7M4SQO5sHNpXDlns+oxe96bBo9xTN68h8/5J6xAhOEsBBdXNvJPUHFlhaAzaYa6K4USu4N6Yfyy5UeMYXu4dVxfnPymaRlje2jjVx7F8KU= To: Oleksandr Tyshchenko , CC: Oleksandr Tyshchenko , Ian Jackson , Wei Liu , Anthony PERARD , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Juergen Gross , Volodymyr Babchuk , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Bertrand Marquis , Wei Chen , Henry Wang References: <1631034578-12598-1-git-send-email-olekstysh@gmail.com> <1631034578-12598-2-git-send-email-olekstysh@gmail.com> From: Andrew Cooper Subject: Re: [RFC PATCH 1/3] xen: Introduce "gpaddr_bits" field to XEN_SYSCTL_physinfo Message-ID: <973f5344-aa10-3ad6-ff02-ad5f358ad279@citrix.com> Date: Tue, 7 Sep 2021 18:35:47 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 In-Reply-To: <1631034578-12598-2-git-send-email-olekstysh@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: en-GB X-ClientProxiedBy: LO4P123CA0428.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18b::19) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9e5916e5-4c9a-4f04-6581-08d97225f265 X-MS-TrafficTypeDiagnostic: BY5PR03MB4998: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: rcN3zlvDev2j8AMCOBLN/pXs3Lo7SRWefXqY9EFbyd4gOIVx2v9mn7UCFfyF4i2SmAyZ4/aAemJ6sclTEG3C4nDaImq0goLM9/A74Uzh9Iu3FZiwx37Pc/LS+XTodyRSHr8L42hYqQYWyH9pmWWUHzNl7ya21uRYk4b25nLIihdMwtlA4ApB3RkikrZGaAaYxDa3q27+9tvk3eqPViiFUKxGMUp0fORnw3co8OIBsAgJAQy8ktIwLNB1q7g1SRa146gQVBQ4v944UY1HQa4HdlaH0WdBGy/wmrhvPUoJ9zz6U7SJdp7DG7C078Wfyf33U2vIAVOSMUj7Je4zhbqAXXcSoH2hMCaL2revHGPdVeBxGYD+pksMfHyq2Vg9zGyCLpW1WBf5vEd1YYMaODPyOC0aPftCFDZXPLRkz9ZGPbHFKhSx+AV3nwmBJl8S5C2W0kuB1zPfsUidqnDuSWDxp/UofMG4Gx5np1wHBAXuZqdyt6oWwqXHXgPv4j6qooF7o5BnuhACYBzZFbaljLzvvHa900+c0FBzRynGIH0jd9TBSga+2vRjZcb5YUv8bve1QEgsBAd0Nf8xYgnRMNAJmQ6MWlYm7ydwUz5C0/gUF5F9Pk/iEfhJw8fnWC/oyYGvzp7VqFDcbsU6SDVBixXRSmoZN0MJvPJnLr5aLE3fUCHG82VdO9rWkEsUxOZ/J8ju5LKcpKyCG9yF26YpJQEk+wJLKFWMmM24acTjPuJQ3jQ= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(366004)(376002)(39860400002)(136003)(396003)(36756003)(4326008)(66946007)(186003)(66556008)(16576012)(478600001)(86362001)(8676002)(31696002)(6666004)(2906002)(55236004)(7416002)(5660300002)(31686004)(2616005)(8936002)(316002)(53546011)(38100700002)(83380400001)(956004)(26005)(66476007)(6486002)(54906003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NmJaL0JCclZPL1R1RVFZVlhFb3Rsby9mWG9BVUhDemxmZUIvVlhzRFJlSXRG?= =?utf-8?B?Q3c5T0N1UnJxMGZDMEpRcWhMMmVPWTltQnppMjh0LzhyY203dXNlUUorL1pF?= =?utf-8?B?V0I0Mk1BTE1VUTVMWmlCLzZiM2trcy85NVVINW9jNEJ3c21rNVpWZExxUEFH?= =?utf-8?B?ZzJiMHlqUExlbzR2WXpUVXpUKzJDNEo0bEhuM280MHAyMzJ2cjhSeU1KODFw?= =?utf-8?B?SlNSdXBUQksyNGErYzFrTE1ibWVoTnlZd0JIeFZRMVlTWXRtOCt6WTMzdlZp?= =?utf-8?B?T1kzOEt1b1JnOVVsTDQ2NXVpMmJsNUZjazA3a3NwZjNUMHhSNmFVcWt3d1I0?= =?utf-8?B?dXB4MzFTbHVvQTRPNWtWRmdFVFIyMHpzMjB2TXp1clBUV01LVzBTQzhCQmJp?= =?utf-8?B?RFNIQk41N25EWEkxNGtBQkdjOGE4aEt2U3BmaFRBVWlNVkJFUXdQVnNTcVZr?= =?utf-8?B?VURNWVZMbGFpd3VMNkZRRGlPWExXWmF4ZkpiVGFmb3ExV1JnejZ2N3BJMHVG?= =?utf-8?B?TktLTDYyOHdqSHFFOFZsU3psYjhKUmF5SkNRZ3RpeHVJVWlhUVo1MHAzTDhO?= =?utf-8?B?d0w0aWYwWE9NZFR5ZTVjMlJWSXE4VEduVFlWN1Y5QlNmdnhyaGNNKzVMaTA4?= =?utf-8?B?bHR4ZzVVOVYveWpLWkZlSkQraUpoYjFWdUk5Sm01dklxVlhWb0hnbk5kaTBB?= =?utf-8?B?NiswQUt4YXhQZENCU2h3d1QzS2JnTkdIMFVMcnNXVTc0ZVl3WW01WmlFVVBN?= =?utf-8?B?SDJRTDJwOFg4KzNoUlhrR3hBdXpoOUo2cUlJSUhMQ2RHUDFKUk9GOC9UbXhF?= =?utf-8?B?empieVRZbFB6V0dQVEtaOEpCVE5BNFNPMzZVRUpab3JGUFh0YTJuU2N4OGNP?= =?utf-8?B?VTFXMDhIb0xudjArWElEaDNoUmxTM3h0VXp2aTF5ZDFWOXMxcXllWGFsSk1E?= =?utf-8?B?WVN0elNWdVAxdEs3dXRvZGpLOGlMNjZoZ0NvSVFubVFteWZlMmt6SDJMQndQ?= =?utf-8?B?WUwwakNLQ3l2ODZSa2xDb3RObFc2T0FkSDc4OUpTSmlMeGNjY2tZK1JlWHhI?= =?utf-8?B?clVnRW14eUpReXkyZkFyNlMvOHVsenNJZURaVjBOZXVZV0xLTFVuL1JhVFBo?= =?utf-8?B?bk1KeXVYZEJScXFzUHNsN1paVzdpQmpFU1NhbFdRWDJBZWF4Wm5uNXkrSlQ3?= =?utf-8?B?UkxxeWEyZlBSRUVrWkw2M3pmc3ZHcEpzN0Y2eGpvME9ZT2NzUEdnaXc4TkZY?= =?utf-8?B?R283VnVtcTdMSUgvNVVWd04zRlhaaGt4emNTK3plNGtUdURPTm1LUmZ4c09F?= =?utf-8?B?OFRNaUF5bzQ1RE9VK1BOeFN3dVhUYkJBTDN1UGhZc05Jb3hRNzhPbmE0NzFs?= =?utf-8?B?azl1TlAxT1ZvTTBXVTRVRXpzcFF2eTRNNTFOa2EwSUN2M0FYcnhMcFhldTh2?= =?utf-8?B?L0VLMThqTWJldmFwTGhqV3d2ejVjSjBEVy82T0lvTzJTTEdvY01VWmxLM0Jm?= =?utf-8?B?SElhTTBmVnRZRUNkM3NBMnFwUnl0UWttV1pwbGltbGZ3TmNwdUdpc2YvOC9y?= =?utf-8?B?dnVOLzdyUVNaYU1vTTR0by9HMjk2WHVYUDdaYWdzRDRyQ3hIdGNnNHVUc1py?= =?utf-8?B?RGFtZWF3K0JjaVFUbmQ2cEdNR2RQakUrU0hLMEw1b2dadkllQkRaTDZDRUpP?= =?utf-8?B?c0p2RWVoeENtdHZSUFRKZGVRVm41UlJiSnZZN0lDUEw5Y3RUN25aNmJLZnlk?= =?utf-8?Q?x+PyrvLZ9dB5Y0b5QxvhrzSNzmcEbM3RBhIUl1v?= X-MS-Exchange-CrossTenant-Network-Message-Id: 9e5916e5-4c9a-4f04-6581-08d97225f265 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2021 17:35:55.9591 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bKfelRUTQgcj/sY8qnpXk+x267fov9x5Q77tzuRe73MReXT4u9XIWkCwXGHPPR+5G9NC/Pkin230/B/f9AIGUUWmvrqtdONgaEyuQIJNpz8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR03MB4998 X-OriginatorOrg: citrix.com On 07/09/2021 18:09, Oleksandr Tyshchenko wrote: > From: Oleksandr Tyshchenko > > We need to pass info about maximum supported guest address > space size to the toolstack on Arm in order to properly > calculate the base and size of the extended region (safe range) > for the guest. The extended region is unused address space which > could be safely used by domain for foreign/grant mappings on Arm. > The extended region itself will be handled by the subsequents > patch. > > Use p2m_ipa_bits variable on Arm, the x86 equivalent is > hap_paddr_bits. > > As we change the size of structure bump the interface version. > > Suggested-by: Julien Grall > Signed-off-by: Oleksandr Tyshchenko So while I think this is a suitable way forward, you're painting yourself into a corner WRT migration. On x86, the correct value is d->arch.cpuid->extd.maxphysaddr and this value is under toolstack control, not Xen control.=C2=A0 In particular, it needs to be min(hostA, hostB) to make migration safe, and yes - this is currently a hole in x86's migration logic that will cause large VMs to explode. The same will be true on ARM as/when you gain migration support. I think this would be better as a domctl.=C2=A0 On ARM, it can reference p2m_ipa_bits for now along with a /* TODO - make per-domain for migration support */, while on x86 it can take the appropriate value (which will soon actually be safe in migration scenarios). However, that does change the ordering requirements in the toolstack - this hypercall would need to be made after the domain is created, and has been levelled, and before its main memory layout is decided. Alternatively, the abstraction could be hidden in libxl itself in arch specific code, with x86 referring to the local cpu policy (as libxl has the copy it is/has worked on), and ARM making a hypercall.=C2=A0 This does make the ordering more obvious. (As a note on the x86 specifics of this patch, hap_paddr_bits is actually unused in practice.=C2=A0 It was a proposal from AMD for the hypervisor to fill in those details, which wasn't implemented by anyone, not even Xen, because the important field to modify is maxphysaddr if you don't want to rewrite every kernel to behave differently when virtualised.) ~Andrew From xen-devel-bounces@lists.xenproject.org Tue Sep 07 17:40:04 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 17:40:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.181290.328382 (Exim 4.92) (envelope-from ) id 1mNf4m-0001zR-04; Tue, 07 Sep 2021 17:40:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 181290.328382; Tue, 07 Sep 2021 17:40:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNf4l-0001yt-Sz; Tue, 07 Sep 2021 17:40:03 +0000 Received: by outflank-mailman (input) for mailman id 181290; Tue, 07 Sep 2021 17:40:02 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNf4k-0001hT-6i for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 17:40:02 +0000 Received: from mx0a-0039f301.pphosted.com (unknown [148.163.133.242]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id a012b290-1002-11ec-b118-12813bfff9fa; Tue, 07 Sep 2021 17:40:00 +0000 (UTC) Received: from pps.filterd (m0174676.ppops.net [127.0.0.1]) by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 187HdHfK008599; Tue, 7 Sep 2021 17:39:58 GMT Received: from eur04-db3-obe.outbound.protection.outlook.com (mail-db3eur04lp2057.outbound.protection.outlook.com [104.47.12.57]) by mx0a-0039f301.pphosted.com with ESMTP id 3axcp0801p-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 07 Sep 2021 17:39:57 +0000 Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17) by AM0PR03MB5698.eurprd03.prod.outlook.com (2603:10a6:208:171::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19; Tue, 7 Sep 2021 17:39:54 +0000 Received: from AM0PR03MB6324.eurprd03.prod.outlook.com ([fe80::70f5:8ba9:da74:8994]) by AM0PR03MB6324.eurprd03.prod.outlook.com ([fe80::70f5:8ba9:da74:8994%3]) with mapi id 15.20.4500.014; Tue, 7 Sep 2021 17:39:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a012b290-1002-11ec-b118-12813bfff9fa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=L/MK8hwg9nGOd8gb5Ws2edbdyv778uQwgZPVMD8b+MKRAhCje0TQO+6XghwEA/CMt4CL7T8OP25/0yBU1JJK9LwJbX42boTbze8fAs1LBuuIC9ve+VPx+fBlLcFEtKiuuE3Wq55kgOD/Fcsdf9l9nAAsCiin/fXvmWjutQzWdtmWdJLZZygWeE2OMAIK0rV50LNDhLv6lgQz4M19/OeAJr3QXoNCpx/xGtCJsY5779MElfqOAamLM1p0YpcSA3TwXy+0xRBPNJt1pVYKvqThanG+4wHPdSuCGvjlNs1U1v4fxQChYwZt9k1foSd6jjt6Y8IJ1y8NU2FijK/zDJ9yLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=Q5ycq2nXR5FZX0BWbi7FjueKCXrfpTy2STsvy440gaU=; b=m3PQuJB9rfpJ7tobfCoYCGotDjtY0ZSRCuIPwWb0H3YUZlpqPW7PQHb1UrEsz38j/tFd5SGHKEmioCbAEU2gIy/JeCQBwupJ9JPxo7XknQXuNZoqS7fKruOtFnreDaEiLS16Ifte/GYOjudqFcfxWEn2wl8DMZsgOliS3O5uC1T5Es1vLC81IejbkBG8AXDRMeAzBjEwfVOET3aMMI4GmC6r5AYlNsf8T783PVSWr8Y15HCVQSXmVtohnDUQ2Lr53xTAmagjEOMo1cu9peX3/1ZGifMBqRfAo/urD5v+I77lN/M2kHAnaf8irF78vYsUXjnOpQST4JC+xN2hLEErWw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Q5ycq2nXR5FZX0BWbi7FjueKCXrfpTy2STsvy440gaU=; b=tksrpfuOZn1tf3LjUt99XqNea3nx3XZMXcP3hSp6uUx3lSRSDiz56nJ1Blp2YNLSWTc9wj/Ij5d0RggXqKTGJGIXWqDhW89090QmxC3qaeEkVWguAfLwFGykY9CvHmHUIPF5E4PF6j2CEBu/7/UvNzB3K7LBmaaqJuw9mr/FY7Rd93CztytyZ1B0ngRyfNYPu6m6EC6QKlUXQiIscHnraSB2KLoH1+xlUqLoftKLaoyRyQlPVQUBtE63rLj0EKbzWNNak+bwZEm6E0iZLPvpv10Y6DPqhtqr6cxvKa5RwgEDF36grslOVDNeUpEmiYjxmRK44UhrmaWtTekr3sKtYA== From: Oleksandr Andrushchenko To: Jan Beulich , Oleksandr Andrushchenko CC: "julien@xen.org" , "sstabellini@kernel.org" , Oleksandr Tyshchenko , Volodymyr Babchuk , Artem Mygaiev , "roger.pau@citrix.com" , Bertrand Marquis , Rahul Singh , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH 5/9] vpci/header: Implement guest BAR register handlers Thread-Topic: [PATCH 5/9] vpci/header: Implement guest BAR register handlers Thread-Index: AQHXoKxmxnIdZosa7ESbvTmPlG6KHauXFn+AgAGCLICAADFtgIAAE0qA Date: Tue, 7 Sep 2021 17:39:53 +0000 Message-ID: <24624eca-766d-6841-dc90-43371f5a39ba@epam.com> References: <20210903100831.177748-1-andr2000@gmail.com> <20210903100831.177748-6-andr2000@gmail.com> <1848521d-4179-f5ee-e3af-f4e6738f60e6@suse.com> <2e0c2ff5-7228-a439-c8a6-50f7a022e77b@suse.com> In-Reply-To: <2e0c2ff5-7228-a439-c8a6-50f7a022e77b@suse.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=epam.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d665de14-4035-41cd-b75d-08d97226808c x-ms-traffictypediagnostic: AM0PR03MB5698: x-ms-exchange-transport-forked: True x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 6vuZpvrPAynKg2di+1hAuLDCecb9fCfpWYcYFaKhzenTyjgH7XHdpMreUOVeFagECEenqt4xbKzBmczAaBUtObPYKoR3/wnQ8rkvq3Nxk7G3lqGEWm6H0hNkv4wKWxQ2JUddWO1RtlsBK927krBJqDK1mgkVlQW1Wwc6CVt26yiY4FA8auOKStotRpK2tb2YYsLvMHXMOe1PrYZL9h2zLR7AG36dgGm6bPEp3O2ib+U7vjzviEg+HGkWc3YTIHursq7ftM+BjlSxO5tM1gZZhITZCyCj6ttbPe0Xg0Y6Auub71mGCNLMgDaQQ2wfpj9zlxkRIAss1QVWDuypuTznZSOnlVPiEdJe7Z6Q1Nv2D/oQtgJOnV2OPaVc9u7+WYcUyyIsGEPTUzOGI6OZlwoT/hHy7O0/AAwjnmDUiPKULzjjzjmIFrma2/zsklkgotXlPpMLQeHtyqcyEK21y9Bgo+5MylyalULZW9zWC2R0cX8eXvPzavhhBZPikNmy9Lu9U506Y4McI4anbCP6DBKqIJNC8hVd8GYjTJ8jtyrvSIv5HlTxdDM2htQe+n9hVzRPM7Fa3gM1Ni5delgukedj2GcofsVSr6jutodgtoufLU9zS57vcJDmrtRHypeWuPc8YnMESjqbz15YNaUUMkup28lJ6gZyeN1mVgwZk+Evpl6Ufgihi7bgC2/mank2hdwA8dHbFryJUOhWslAae0HDLV/TkFFyFOWzvbnB5NKDrShi4PKAtmjFvU7PzlWz0MJg x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(396003)(376002)(136003)(346002)(39860400002)(66946007)(31686004)(64756008)(38070700005)(66446008)(66556008)(36756003)(316002)(86362001)(66476007)(53546011)(76116006)(8936002)(6486002)(6506007)(2906002)(478600001)(31696002)(8676002)(71200400001)(83380400001)(122000001)(110136005)(26005)(38100700002)(54906003)(186003)(4326008)(2616005)(5660300002)(6512007)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?SUM4VW5WSHA0VXhTalBLSlFyZFdHanlOdEV4a2J2czVTbGg1UHNRbnNXbUwr?= =?utf-8?B?d1pOdDVacGF1emdYQ09UL3lrcUtZaWZrVW5wNDJpbXkwOVJjMHVMNWx3TVZZ?= =?utf-8?B?cy82TnF2MmVKa1luclBQV1lzMVBJRGJOZXJIOHRuNnpQZHFUdjdxb2pHckl6?= =?utf-8?B?ZFZYZWdxSmNZY0dvQXRZc3oyRm1wM2NRZW9MbDhyaXBWZWw4Z0xaZjJnWWpS?= =?utf-8?B?VmtOZmxOZHQ2NUtoM0hGWnR5dzVydE5EcFRudFEvaUxYeVV6c0phUVJNUFA0?= =?utf-8?B?aUFSaXlQQjlYUndQbWNvTXhoU3V1cGJnYWZ0dUhwOERjclAvWGRtYWNybDEx?= =?utf-8?B?S2dRYWVxellmZW5rN3Q5WC9JVjNLUEVjQ3poVkcvbkFOQTFvNHRUMElWZnNy?= =?utf-8?B?NzlMOENqRkt3SkJsUVpWQTZIcXRDaDVUejlxMVJKSDROQjlyVENodE9aUE9B?= =?utf-8?B?UTYwNFpiTXJuSlJSaFVtanVBNW4wb2J5L05mNmk2Yk1mczZKZWYzRTFnVW1R?= =?utf-8?B?d1ZnaWc2bi95VDNzejhrZWc1RzdzaFZqVTVZMTZLUy9pQVZmeWNwcjlYQ1RE?= =?utf-8?B?amVJcnFSMnpxZDhUTzhIclRsUHYvQng3c1YwK1EvUW5hTzhnMTBWckkvN3hT?= =?utf-8?B?VjRZcGRLMGNVckZpQTlkKzBVNFJLK1Q5KzJmck45ZXJQalNtRXZJOERSYVpa?= =?utf-8?B?UFFrazdpdXg1VnU2aUlkZ0dBWmwwQ0lmL0tFb3g4MDJUem9IcWk5Yi9Zdndy?= =?utf-8?B?bHhpMEVoMVFDaHRZR0JSUjRZeG1HSmZrWmJBbXlKYnZwZk5haitqcnpiQ3lo?= =?utf-8?B?S0NWMkxMZWlmU1BKNVQvSXdveWxqN2RwdDh6VXNwRXJHN0p2M2NsZHMyVFRL?= =?utf-8?B?WkhOSWMwV1Q1WUZ2NStvdUI4WUFieUNnd3o4SFhvS0JJV2YvcCsxS0ZXZXlV?= =?utf-8?B?Wlltak1rR2lIcXRCTTIva3c2aFFHQmFLRTBET2dIUE4xM3d6bWRYWnQwNGhn?= =?utf-8?B?Y0ZMS3JubEUzY2oxa1ZnZnVSQkl6ZlJOVE9DU0dKZSt6T054b2lXSHVSNzQy?= =?utf-8?B?NjM1Q1RkdUFpeURjRTFtbTdiUzRQRldVTjdmVDRpamtkZ3JxbjgxRUpGYm13?= =?utf-8?B?TDRIVWlrMlRIUTNaVHNzRzVYdWxoM3FqUytHaHdsMkhKaXpqTGpMY2FiRnhj?= =?utf-8?B?Q0x4UFAwYWR2SmdvVjBkM3BCc01HWXlBd3N1SWpCSzZnUW9zWmVDaXRna21w?= =?utf-8?B?dnp5RXZKa0tRYjdWaXoxeVNnWFljb3ZXZyttN0ZvL3RDWXRLOFRrdDhweU9V?= =?utf-8?B?b1VXcWp3bTlqMGlBcDg4Yks4ZmV1L1RMYUNTeEZxQVFxOTMzdEpQY1ZoTjEw?= =?utf-8?B?RUQybVpORDhTWk5aeFF6YVFCemxhcmNwTVBGT2t0eWZ5M1NjTVU1dWdITERi?= =?utf-8?B?ZXErbGF2ZFJsV0pQWUNHRmYwcWpXalVkWmxlb3BGNkdUK05iVGtWWkZKUUIz?= =?utf-8?B?TW05ZWZNcCtyRStDcFhjeUJZRlQ2NG1yUkw1cGtDTUVTcnJXU0V4M2g2QTRX?= =?utf-8?B?ZmtkY3phbTVPTDZEbmw5MEtxNzJZeXh0RzJUR0NuYnVWWE5nT0N1T0g0aHZ4?= =?utf-8?B?Z0Mxa3BPTlRTRXBPK3hxbCtHNlBUc3ZUMmdWSmNncnE4MThSaEJLb2VKU1Ux?= =?utf-8?B?c0FselI3WnNZQjR1VVJiNkxOc1RwMkxEV2w0TEd3NlBsYW11b1NRTCtad1NQ?= =?utf-8?Q?HJ4PaUIuYRSMejkel5OzfnL3728WaB5MTuqEvUg?= Content-Type: text/plain; charset="utf-8" Content-ID: <7D12DE7B3F3E954297B1A39DBC5196F3@eurprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: epam.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d665de14-4035-41cd-b75d-08d97226808c X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Sep 2021 17:39:53.9639 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: GsgvCCCFxy/Zfb0OtDOxEVWxGSJnts0euCdkHfWPRsRSjR2CZbFM7KnRrGeblQyV7mavMN0uogZnPIYM1uKjRvZ+Da07Za362kDQ37uh7Gjzo/TxLCZ4RDEShwgSRjH/ X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR03MB5698 X-Proofpoint-ORIG-GUID: DjBeJHtbMsIyhGXSYA36Cy7vhdlgs_tP X-Proofpoint-GUID: DjBeJHtbMsIyhGXSYA36Cy7vhdlgs_tP X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.391,FMLib:17.0.607.475 definitions=2021-09-07_06,2021-09-07_02,2020-04-07_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 adultscore=0 spamscore=0 phishscore=0 lowpriorityscore=0 mlxscore=0 mlxlogscore=999 suspectscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109030001 definitions=main-2109070114 DQpPbiAwNy4wOS4yMSAxOTozMCwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDA3LjA5LjIwMjEg MTU6MzMsIE9sZWtzYW5kciBBbmRydXNoY2hlbmtvIHdyb3RlOg0KPj4gT24gMDYuMDkuMjEgMTc6 MzEsIEphbiBCZXVsaWNoIHdyb3RlOg0KPj4+IE9uIDAzLjA5LjIwMjEgMTI6MDgsIE9sZWtzYW5k ciBBbmRydXNoY2hlbmtvIHdyb3RlOg0KPj4+PiAtLS0gYS94ZW4vZHJpdmVycy92cGNpL2hlYWRl ci5jDQo+Pj4+ICsrKyBiL3hlbi9kcml2ZXJzL3ZwY2kvaGVhZGVyLmMNCj4+Pj4gQEAgLTQwMCwx MiArNDAwLDcyIEBAIHN0YXRpYyB2b2lkIGJhcl93cml0ZShjb25zdCBzdHJ1Y3QgcGNpX2RldiAq cGRldiwgdW5zaWduZWQgaW50IHJlZywNCj4+Pj4gICAgc3RhdGljIHZvaWQgZ3Vlc3RfYmFyX3dy aXRlKGNvbnN0IHN0cnVjdCBwY2lfZGV2ICpwZGV2LCB1bnNpZ25lZCBpbnQgcmVnLA0KPj4+PiAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdWludDMyX3QgdmFsLCB2b2lkICpkYXRhKQ0K Pj4+PiAgICB7DQo+Pj4+ICsgICAgc3RydWN0IHZwY2lfYmFyICpiYXIgPSBkYXRhOw0KPj4+PiAr ICAgIGJvb2wgaGkgPSBmYWxzZTsNCj4+Pj4gKw0KPj4+PiArICAgIGlmICggYmFyLT50eXBlID09 IFZQQ0lfQkFSX01FTTY0X0hJICkNCj4+Pj4gKyAgICB7DQo+Pj4+ICsgICAgICAgIEFTU0VSVChy ZWcgPiBQQ0lfQkFTRV9BRERSRVNTXzApOw0KPj4+PiArICAgICAgICBiYXItLTsNCj4+Pj4gKyAg ICAgICAgaGkgPSB0cnVlOw0KPj4+PiArICAgIH0NCj4+Pj4gKyAgICBlbHNlDQo+Pj4+ICsgICAg ICAgIHZhbCAmPSBQQ0lfQkFTRV9BRERSRVNTX01FTV9NQVNLOw0KPj4+PiArICAgIGJhci0+Z3Vl c3RfYWRkciAmPSB+KDB4ZmZmZmZmZmZ1bGwgPDwgKGhpID8gMzIgOiAwKSk7DQo+Pj4+ICsgICAg YmFyLT5ndWVzdF9hZGRyIHw9ICh1aW50NjRfdCl2YWwgPDwgKGhpID8gMzIgOiAwKTsNCj4+PiBX aGF0IHlvdSBzdG9yZSBoZXJlIGlzIG5vdCB0aGUgYWRkcmVzcyB0aGF0J3MgZ29pbmcgdG8gYmUg dXNlZCwNCj4+IGJhci0+Z3Vlc3RfYWRkciBpcyBuZXZlciB1c2VkIGRpcmVjdGx5IHRvIGJlIHJl cG9ydGVkIHRvIGEgZ3Vlc3QuDQo+IEFuZCB0aGlzIGlzIHdoYXQgSSBxdWVzdGlvbiwgYXMgYW4g YXBwcm9hY2guIFlvdXIgbW9kZWwgX21heV8gd29yaywNCj4gYnV0IGl0cyBuZWVkbGVzc2x5IGRl dmlhdGluZyBmcm9tIGhvdyBwZW9wbGUgbGlrZSBtZSB3b3VsZCBleHBlY3QNCj4gdGhpcyB0byB3 b3JrLiBBbmQgaWYgaXQncyBpbnRlbmRlZCB0byBiZSB0aGlzIHdheSwgaG93IHdvdWxkIEkNCj4g aGF2ZSBrbm93bj8NCldlbGwsIEkganVzdCB0cmllZCB0byBmb2xsb3cgdGhlIG1vZGVsIHdlIGFs cmVhZHkgaGF2ZSBpbiB0aGUgZXhpc3RpbmcgY29kZS4uLg0KPg0KPj4gSXQgaXMgYWx3YXlzIHVz ZWQgYXMgYW4gaW5pdGlhbCB2YWx1ZSB3aGljaCBpcyB0aGVuIG1vZGlmaWVkIHRvIHJlZmxlY3QN Cj4+IGxvd2VyIGJpdHMsIGUuZy4gQkFSIHR5cGUgYW5kIGlmIHByZWZldGNoYWJsZSwgc28gSSB0 aGluayB0aGlzIGlzIHBlcmZlY3RseQ0KPj4gZmluZSB0byBoYXZlIGl0IHRoaXMgd2F5Lg0KPiBB bmQgaXQgaXMgYWxzbyBwZXJmZWN0bHkgZmluZSB0byBzdG9yZSB0aGUgdmFsdWUgdG8gYmUgaGFu ZGVkDQo+IGJhY2sgdG8gZ3Vlc3RzIG9uIHRoZSBuZXh0IHJlYWQuIEtlZXBzIHRoZSByZWFkIHBh dGggc2ltcGxlLA0KPiB3aGljaCBJIHRoaW5rIGNhbiBiZSBhc3N1bWVkIHRvIGJlIHRha2VuIG1v cmUgZnJlcXVlbnRseSB0aGFuDQo+IHRoZSB3cml0ZSBvbmUuIFBsdXMgc3RvcmVkIHZhbHVlcyBy ZWZsZWN0IHJlYWxpdHkuDQo+DQo+IFBsdXMgLSBpZiB3aGF0IHlvdSBzYXkgd2FzIHJlYWxseSB0 aGUgY2FzZSwgd2h5IGRvIHlvdSBtYXNrIG9mZg0KPiBQQ0lfQkFTRV9BRERSRVNTX01FTV9NQVNL IGhlcmU/IFlvdSBzaG91bGQgdGhlbiBzaW1wbHkgc3RvcmUNCj4gdGhlIHdyaXR0ZW4gdmFsdWUg YW5kIGRvIF9hbGxfIHRoZSBwcm9jZXNzaW5nIGluIHRoZSByZWFkIHBhdGguDQo+IE5vIHBvaW50 IGhhdmluZyBwYXJ0aWFsIGxvZ2ljIGluIHR3byBwbGFjZXMuDQoNCkkgd2lsbCBtb3ZlIHRoZSBs b2dpYyB0byB0aGUgd3JpdGUgaGFuZGxlciwgaW5kZWVkIHdlIGNhbiBzYXZlIHNvbWUNCg0KQ1BV IGN5Y2xlcyBoZXJlDQoNCj4NCj4+PiAgICBhcw0KPj4+IHlvdSBkb24ndCBtYXNrIG9mZiB0aGUg bG93IGJpdHMgKHRvIGFjY291bnQgZm9yIHRoZSBCQVIncyBzaXplKS4NCj4+PiBXaGVuIGEgQkFS IGdldHMgd3JpdHRlbiB3aXRoIGFsbCBvbmVzLCBhbGwgd3JpdGFibGUgYml0cyBnZXQgdGhlc2UN Cj4+PiBvbmVzIHN0b3JlZC4gVGhlIGFkZHJlc3Mgb2YgdGhlIEJBUiwgYWl1aSwgcmVhbGx5IGNo YW5nZXMgdG8NCj4+PiAodHlwaWNhbGx5KSBjbG9zZSBiZWxvdyA0R2IgKGluIHRoZSBjYXNlIG9m IGEgMzItYml0IEJBUiksIHdoaWNoDQo+Pj4gaXMgd2h5IG1lbW9yeSAvIEkvTyBkZWNvZGluZyBz aG91bGQgYmUgb2ZmIHdoaWxlIHNpemluZyBCQVJzLg0KPj4+IFRoZXJlZm9yZSB5b3Ugc2hvdWxk bid0IGxvb2sgZm9yIHRoZSBzcGVjaWZpYyAiYWxsIHdyaXRhYmxlIGJpdHMNCj4+PiBhcmUgb25l cyIgcGF0dGVybiAob3Igd29yc2UsIGFzIHlvdSBwcmVzZW50bHkgZG8sIHRoZSAiYWxsIGJpdHMN Cj4+PiBvdXRzaWRlIG9mIHRoZSB0eXBlIHNwZWNpZmllciBhcmUgb25lcyIgb25lKSBvbiB0aGUg cmVhZCBwYXRoLg0KPj4+IEluc3RlYWQgbWFzayB0aGUgdmFsdWUgYXBwcm9wcmlhdGVseSBoZXJl LCBhbmQgc2ltcGx5IHJldHVybiBiYWNrDQo+Pj4gdGhlIHN0b3JlZCB2YWx1ZSBmcm9tIHRoZSBy ZWFkIHBhdGguDQo+PiAiUENJIExPQ0FMIEJVUyBTUEVDSUZJQ0FUSU9OLCBSRVYuIDMuMCIsICJJ TVBMRU1FTlRBVElPTiBOT1RFDQo+Pg0KPj4gU2l6aW5nIGEgMzItYml0IEJhc2UgQWRkcmVzcyBS ZWdpc3RlciBFeGFtcGxlIiBzYXlzLCB0aGF0DQo+Pg0KPj4gIlNvZnR3YXJlIHNhdmVzIHRoZSBv cmlnaW5hbCB2YWx1ZSBvZiB0aGUgQmFzZSBBZGRyZXNzIHJlZ2lzdGVyLCB3cml0ZXMNCj4+IDAg RkZGRiBGRkZGaCB0byB0aGUgcmVnaXN0ZXIsIHRoZW4gcmVhZHMgaXQgYmFjay4iDQo+Pg0KPj4g VGhlIHNhbWUgYXBwbGllcyBmb3IgNjQtYml0IEJBUnMuIFNvIHdoYXQncyB3cm9uZyBpZiBJIHRy eSB0byBjYXRjaCBzdWNoDQo+PiBhIHdyaXRlIHdoZW4gYSBndWVzdCB0cmllcyB0byBzaXplIHRo ZSBCQVI/IFRoZSBvbmx5IGRpZmZlcmVuY2UgaXMgdGhhdA0KPj4gSSBjb21wYXJlIGFzDQo+PiAg IMKgwqDCoMKgwqDCoMKgIGlmICggKHZhbCAmIFBDSV9CQVNFX0FERFJFU1NfTUVNX01BU0tfMzIp ID09IFBDSV9CQVNFX0FERFJFU1NfTUVNX01BU0tfMzIgKQ0KPj4gd2hpY2ggaXMgYmVjYXVzZSB2 YWwgaW4gdGhlIHF1ZXN0aW9uIGhhcyBsb3dlciBiaXRzIGNsZWFyZWQuDQo+IEJlY2F1c2Ugd2hp bGUgdGhpcyBtYXRjaGVzIHdoYXQgdGhlIHNwZWMgc2F5cywgaXQncyBub3QgZW5vdWdoIHRvDQo+ IG1hdGNoIGhvdyBoYXJkd2FyZSBiZWhhdmVzLg0KQnV0IHdlIHNob3VsZCBpbXBsZW1lbnQgYXMg dGhlIHNwZWMgc2F5cywgbm90IGxpa2UgYnVnZ3kgaGFyZHdhcmUgYmVoYXZlcw0KPiAgIFlldCB5 b3Ugd2FudCB0byBtaW1pYyBoYXJkd2FyZSBiZWhhdmlvcg0KPiBhcyBjbG9zZWx5IGFzIHBvc3Np YmxlIGhlcmUuIFRoZXJlIGlzIChpaXJjKSBhdCBsZWFzdCBvbmUgb3RoZXINCj4gcGxhY2UgaW4g dGhlIHNvdXJjZSB0cmVlIHdlcmUgd2UgaGFkIHRvIGFkanVzdCBhIHNpbWlsYXIgaW5pdGlhbA0K PiBpbXBsZW1lbnRhdGlvbiB0byBiZSBjbG9zZXIgdG8gb25lIGV4cGVjdGVkIGJ5IGd1ZXN0cywN Cg0KQ291bGQgeW91IHBsZWFzZSBwb2ludCBtZSB0byB0aGF0IGNvZGUgc28gSSBjYW4gY29uc3Vs dCBhbmQgcG9zc2libHkNCg0KcmUtdXNlIHRoZSBhcHByb2FjaD8NCg0KPiAgIG5vIG1hdHRlcg0K PiB0aGF0IHRoZXkgbWF5IG5vdCBiZSBmb2xsb3dpbmcgdGhlIHNwZWMgdG8gdGhlIGxldHRlci4g RG9uJ3QNCj4gZm9yZ2V0IHRoYXQgdGhlcmUgbWF5IGJlIGJ1Z3MgaW4ga2VybmVscyB3aGljaCBk b24ndCBzdXJmYWNlIHVudGlsDQo+IHRoZSBrZXJuZWwgZ2V0cyBydW4gb24gYW4gb3Zlcmx5IHNp bXBsaXN0aWMgZW11bGF0aW9uLg0KVGhpcyBpcyBzYWQuIEFuZCB0aGUga2VybmVsIG5lZWRzIHRv IGJlIGZpeGVkIHRoZW4sIG5vdCBYZW4NCj4NCj4+Pj4gQEAgLTUyMiw2ICs1ODIsMTMgQEAgc3Rh dGljIGludCBhZGRfYmFyX2hhbmRsZXJzKHN0cnVjdCBwY2lfZGV2ICpwZGV2LCBib29sIGlzX2h3 ZG9tKQ0KPj4+PiAgICAgICAgICAgICAgICBpZiAoIHJjICkNCj4+Pj4gICAgICAgICAgICAgICAg ICAgIHJldHVybiByYzsNCj4+Pj4gICAgICAgICAgICB9DQo+Pj4+ICsgICAgICAgIC8qDQo+Pj4+ ICsgICAgICAgICAqIEl0IGlzIG5laXRoZXIgc2FmZSBub3Igc2VjdXJlIHRvIGluaXRpYWxpemUg Z3Vlc3QncyB2aWV3IG9mIHRoZSBCQVJzDQo+Pj4+ICsgICAgICAgICAqIHdpdGggcmVhbCB2YWx1 ZXMgd2hpY2ggYXJlIHVzZWQgYnkgdGhlIGhhcmR3YXJlIGRvbWFpbiwgc28gYXNzaWduDQo+Pj4+ ICsgICAgICAgICAqIGFsbCB6ZXJvcyB0byBndWVzdCdzIHZpZXcgb2YgdGhlIEJBUnMsIHNvIHRo ZSBndWVzdCBjYW4gcGVyZm9ybQ0KPj4+PiArICAgICAgICAgKiBwcm9wZXIgUENJIGRldmljZSBl bnVtZXJhdGlvbiBhbmQgYXNzaWduIEJBUnMgb24gaXRzIG93bi4NCj4+Pj4gKyAgICAgICAgICov DQo+Pj4+ICsgICAgICAgIGJhcnNbaV0uZ3Vlc3RfYWRkciA9IDA7DQo+Pj4gSSdtIGFmcmFpZCBJ IGRvbid0IHVuZGVyc3RhbmQgdGhlIGNvbW1lbnQ6IFdpdGhvdXQgbWVtb3J5IGRlY29kaW5nDQo+ Pj4gZW5hYmxlZCwgdGhlIEJBUnMgYXJlIHNpbXBsZSByZWdpc3RlcnMgKHdpdGggYSBmZXcgci9v IGJpdHMpLg0KPj4gTXkgZmlyc3QgaW1wbGVtZW50YXRpb24gd2FzIHRoYXQgYmFyLT5ndWVzdF9h ZGRyIHdhcyBpbml0aWFsaXplZCB3aXRoDQo+PiB0aGUgdmFsdWUgb2YgYmFyLT5hZGRyIChwaHlz aWNhbCBCQVIgdmFsdWUpLCBidXQgdGFsa2luZyBvbiBJUkMgd2l0aA0KPj4gUm9nZXIgaGUgc3Vn Z2VzdGVkIHRoYXQgdGhpcyBtaWdodCBiZSBhIHNlY3VyaXR5IGlzc3VlIHRvIGxldCBndWVzdA0K Pj4gYSBoaW50IGFib3V0IHBoeXNpY2FsIHZhbHVlcywgc28gdGhlbiBJIGNoYW5nZWQgdGhlIGFz c2lnbm1lbnQgdG8gYmUgMC4NCj4gV2VsbCwgeWVzLCB0aGF0J3MgY2VydGFpbmx5IGNvcnJlY3Qu IEl0J3MgcGVyaGFwcyB0b28gdW5vYnZpb3VzIHRvIG1lDQo+IHdoeSBvbmUgbWF5IHdhbnQgdG8g dXNlIHRoZSBob3N0IHZhbHVlIGhlcmUgaW4gdGhlIGZpcnN0IHBsYWNlLiBJdA0KPiBzaW1wbHkg aGFzIG5vIG1lYW5pbmcgaGVyZS4NCkRvIHlvdSB3YW50IG1lIHRvIHJlbW92ZSB0aGUgY29tbWVu dD8NCj4NCj4+Pj4gLS0tIGEveGVuL2luY2x1ZGUveGVuL3BjaV9yZWdzLmgNCj4+Pj4gKysrIGIv eGVuL2luY2x1ZGUveGVuL3BjaV9yZWdzLmgNCj4+Pj4gQEAgLTEwMyw2ICsxMDMsNyBAQA0KPj4+ PiAgICAjZGVmaW5lICBQQ0lfQkFTRV9BRERSRVNTX01FTV9UWVBFXzY0CTB4MDQJLyogNjQgYml0 IGFkZHJlc3MgKi8NCj4+Pj4gICAgI2RlZmluZSAgUENJX0JBU0VfQUREUkVTU19NRU1fUFJFRkVU Q0gJMHgwOAkvKiBwcmVmZXRjaGFibGU/ICovDQo+Pj4+ICAgICNkZWZpbmUgIFBDSV9CQVNFX0FE RFJFU1NfTUVNX01BU0sJKH4weDBmVUwpDQo+Pj4+ICsjZGVmaW5lICBQQ0lfQkFTRV9BRERSRVNT X01FTV9NQVNLXzMyCSh+MHgwZlUpDQo+Pj4gUGxlYXNlIGRvbid0IGludHJvZHVjZSBhbiBpZGVu dGljYWwgY29uc3RhbnQgdGhhdCdzIG1lcmVseSBvZg0KPj4+IGRpZmZlcmVudCB0eXBlLiAodWlu dDMyX3QpUENJX0JBU0VfQUREUkVTU19NRU1fTUFTSyBhdCB0aGUgdXNlDQo+Pj4gc2l0ZSAoaWYg YWN0dWFsbHkgc3RpbGwgbmVlZGVkIGFzIHBlciB0aGUgY29tbWVudCBhYm92ZSkgd291bGQNCj4+ PiBzZWVtIG1vcmUgY2xlYXIgdG8gbWUuDQo+PiBPaywgSSB0aG91Z2h0IHR5cGUgY2FzdGluZyBp cyBhIGJpZ2dlciBldmlsIGhlcmUNCj4gT2Z0ZW4gaXQgaXMsIGJ1dCBpbW8gaGVyZSBpdCBpcyBu b3QuIEkgaG9wZSB5b3UgcmVhbGl6ZSB0aGF0IH4weDBmVQ0KPiBpZiBub3QgbmVjZXNzYXJpbHkg MHhmZmZmZmZmMD8gV2UgbWFrZSBjZXJ0YWluIGFzc3VtcHRpb25zIG9uIHR5cGUNCj4gd2lkdGhz LiBGb3IgdW5zaWduZWQgaW50IHdlIGFzc3VtZSBpdCB0byBiZSBhdCBsZWFzdCAzMiBiaXRzIHdp ZGUuDQo+IFdlIHNob3VsZCBhdm9pZCBhc3N1bXB0aW9ucyBvZiBpdCBiZWluZyBleGFjdGx5IDMy IGJpdHMgd2lkZS4gSnVzdA0KPiBsaWtlIHdlIGNhbm5vdCAobW9yZSBvYnZpb3VzbHkpIGFzc3Vt ZSB0aGUgd2lkdGggb2YgdW5zaWduZWQgbG9uZy4NCj4gKFdoaWNoIHRlbGxzIHVzIHRoYXQgZm9y IDMyLWJpdCBhcmNoZXMgUENJX0JBU0VfQUREUkVTU19NRU1fTUFTSyBpcw0KPiBhY3R1YWxseSBv ZiB0aGUgd3JvbmcgdHlwZS4gVGhpcyBjb25zdGFudCBzaG91bGQgYmUgdGhlIHNhbWUgbm8NCj4g bWF0dGVyIHRoZSBiaXRuZXNzLikNCk9rLCBJIHdpbGwgbm90IGludHJvZHVjZSBhIG5ldyBkZWZp bmUgYW5kIHVzZSAodWludDMyX3QpDQo+DQo+IEphbg0KPg0KVGhhbmsgeW91LA0KDQpPbGVrc2Fu ZHINCg== From xen-devel-bounces@lists.xenproject.org Tue Sep 07 18:09:57 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 18:09:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.181298.328393 (Exim 4.92) (envelope-from ) id 1mNfXa-0005eo-Ce; Tue, 07 Sep 2021 18:09:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 181298.328393; Tue, 07 Sep 2021 18:09:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNfXa-0005eh-9c; Tue, 07 Sep 2021 18:09:50 +0000 Received: by outflank-mailman (input) for mailman id 181298; Tue, 07 Sep 2021 18:09:49 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNfXZ-0005eb-J0 for xen-devel@lists.xen.org; Tue, 07 Sep 2021 18:09:49 +0000 Received: from mail-oi1-x22f.google.com (unknown [2607:f8b0:4864:20::22f]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 0e4df1ca-9116-47f3-8ca0-a63691a40011; Tue, 07 Sep 2021 18:09:47 +0000 (UTC) Received: by mail-oi1-x22f.google.com with SMTP id bi4so13838516oib.9 for ; Tue, 07 Sep 2021 11:09:47 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0e4df1ca-9116-47f3-8ca0-a63691a40011 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=aVw++g1itE5W1KXRa2qBfqmZ00VcJA2TbGtfWD/TAkI=; b=Pno1ppX3t5c+a8nm871i+2J1n2BTXpQiYb+0xVgI98VEyKggmXDlkBqbsM/rLw+apF TObj4WW/6sqIscc58HqCalPz9bfinKhEMT/xR6A9uHnvn5W8HRiL4L4PPh0r79kRZffG peNo0DzLXFSzrt79CrL4LhA+KbPYfrI0h4RpVYpHY6/wQINkaK9Z1kQHCsok6L8MUFAW galdV+YBy69bYskaJcQ6lemREOUgxrQjQi3bxGh5wC/ElN38IEE5HO2bvX0sDJL05qoH 2y3wuFdRC7P/JSAvrSCE1BkKkq0PBtH+fA6bXBO2OMGgoqoE+smATTEkQrIdHBBD1Ab/ bXJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=aVw++g1itE5W1KXRa2qBfqmZ00VcJA2TbGtfWD/TAkI=; b=RRF+4gVwezgI/4GVvxrQvJmeTVdlS+S3jHYg3TjHKeIZ9czYYgMMgid8dmponYWFjv QRtcuI/f6eLwdqDODkh36H2E/NUVKXwZg1qchQG3td8F/qH3xXVKnA+bmLnQbiUqv02z BqXCyuzOLjsleHpARhSucWmaWTEYr3AqFvVzZMgwK8qnK1wsLEmG2eyhBbvBYdEL0VeC rx0jGufZCLQtNQR2KGw4KlATCsOTUj82gmb3QPu8who8fPNvew/PpKQUQDKyVk1WyMrn myzrVWpdFeiv0+SBDr5hYmCTBr99/qVjQbnW364uJvE9qyIvdIybUEVObI8wM5BERmAy zh/g== X-Gm-Message-State: AOAM5338EUjSgINvSEeJ38EHSH/ZnK2YPac68JNa+3Ptor0wrrMr2NBi yc28TedQjq/YHQLsXzedQgCUenNYtM3Bcsn4GhE= X-Google-Smtp-Source: ABdhPJy3qil9pHk//YzKgBCdmYRr9vXF2WvPB4AvwKW/VBzOF3cQYTL8LpdSl6GW6VODwOTT7axdkrNAu6sm37ATyNc= X-Received: by 2002:a05:6808:690:: with SMTP id k16mr4024290oig.152.1631038186568; Tue, 07 Sep 2021 11:09:46 -0700 (PDT) MIME-Version: 1.0 References: <20210818053840.GE39588@laputa> <20210820064150.GC13452@laputa> <20210826094047.GA55218@laputa> <20210902071902.GC71098@laputa> <20210907115501.GC49004@laputa> In-Reply-To: <20210907115501.GC49004@laputa> From: Christopher Clark Date: Tue, 7 Sep 2021 11:09:34 -0700 Message-ID: Subject: Re: Enabling hypervisor agnosticism for VirtIO backends To: AKASHI Takahiro Cc: Wei Chen , Oleksandr Tyshchenko , Stefano Stabellini , "Alex Benn??e" , Kaly Xin , Stratos Mailing List , "virtio-dev@lists.oasis-open.org" , Arnd Bergmann , Viresh Kumar , Stefano Stabellini , "stefanha@redhat.com" , Jan Kiszka , Carl van Schaik , "pratikp@quicinc.com" , Srivatsa Vaddagiri , Jean-Philippe Brucker , Mathieu Poirier , Oleksandr Tyshchenko , Bertrand Marquis , Artem Mygaiev , Julien Grall , Juergen Gross , Paul Durrant , Xen Devel , Rich Persaud , Daniel Smith , James McKenzie , Andrew Cooper Content-Type: multipart/alternative; boundary="000000000000b9c09e05cb6bab7a" --000000000000b9c09e05cb6bab7a Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Sep 7, 2021 at 4:55 AM AKASHI Takahiro wrote: > Hi, > > I have not covered all your comments below yet. > So just one comment: > > On Mon, Sep 06, 2021 at 05:57:43PM -0700, Christopher Clark wrote: > > On Thu, Sep 2, 2021 at 12:19 AM AKASHI Takahiro < > takahiro.akashi@linaro.org> > > wrote: > > (snip) > > > > It appears that, on FE side, at least three hypervisor calls (and > data > > > copying) need to be invoked at every request, right? > > > > > > > For a write, counting FE sendv ops: > > 1: the write data payload is sent via the "Argo ring for writes" > > 2: the descriptor is sent via a sync of the available/descriptor ring > > -- is there a third one that I am missing? > > In the picture, I can see > a) Data transmitted by Argo sendv > b) Descriptor written after data sendv > c) VirtIO ring sync'd to back-end via separate sendv > > Oops, (b) is not a hypervisor call, is it? > That's correct, it is not - the blue arrows in the diagram are not hypercalls, they are intended to show data movement or action in the flow of performing the operation, and (b) is a data write within the guest's address space into the descriptor ring. > (But I guess that you will have to have yet another call for notification > since there is no config register of QueueNotify?) > Reasoning about hypercalls necessary for data movement: VirtIO transport drivers are responsible for instantiating virtqueues (setup_vq) and are able to populate the notify function pointer in the virtqueue that they supply. The virtio-argo transport driver can provide a suitable notify function implementation that will issue the Argo hypercall sendv hypercall(s) for sending data from the guest frontend to the backend. By issuing the sendv at the time of the queuenotify, rather than as each buffer is added to the virtqueue, the cost of the sendv hypercall can be amortized over multiple buffer additions to the virtqueue. I also understand that there has been some recent work in the Linaro Project Stratos on "Fat Virtqueues", where the data to be transmitted is included within an expanded virtqueue, which could further reduce the number of hypercalls required, since the data can be transmitted inline with the descriptors. Reference here: https://linaro.atlassian.net/wiki/spaces/STR/pages/25626313982/2021-01-21+P= roject+Stratos+Sync+Meeting+notes https://linaro.atlassian.net/browse/STR-25 As a result of the above, I think that a single hypercall could be sufficient for communicating data for multiple requests, and that a two-hypercall-per-request (worst case) upper bound could also be established. Christopher > > Thanks, > -Takahiro Akashi > > > > Christopher > > > > > > > > > > Thanks, > > > -Takahiro Akashi > > > > > > > > > > * Here are the design documents for building VirtIO-over-Argo, to > > > support a > > > > hypervisor-agnostic frontend VirtIO transport driver using Argo. > > > > > > > > The Development Plan to build VirtIO virtual device support over Ar= go > > > > transport: > > > > > > > > https://openxt.atlassian.net/wiki/spaces/DC/pages/1696169985/VirtIO-Argo+= Development+Phase+1 > > > > > > > > A design for using VirtIO over Argo, describing how VirtIO data > > > structures > > > > and communication is handled over the Argo transport: > > > > > https://openxt.atlassian.net/wiki/spaces/DC/pages/1348763698/VirtIO+Argo > > > > > > > > Diagram (from the above document) showing how VirtIO rings are > > > synchronized > > > > between domains without using shared memory: > > > > > > > > https://openxt.atlassian.net/46e1c93b-2b87-4cb2-951e-abd4377a1194#media-b= lob-url=3Dtrue&id=3D01f7d0e1-7686-4f0b-88e1-457c1d30df40&collection=3Dconte= ntId-1348763698&contextId=3D1348763698&mimeType=3Dimage%2Fpng&name=3Ddevice= -buffer-access-virtio-argo.png&size=3D243175&width=3D1106&height=3D1241 > > > > > > > > Please note that the above design documents show that the existing > VirtIO > > > > device drivers, and both vring and virtqueue data structures can be > > > > preserved > > > > while interdomain communication can be performed with no shared > memory > > > > required > > > > for most drivers; (the exceptions where further design is required > are > > > those > > > > such as virtual framebuffer devices where shared memory regions are > > > > intentionally > > > > added to the communication structure beyond the vrings and > virtqueues). > > > > > > > > An analysis of VirtIO and Argo, informing the design: > > > > > > > > https://openxt.atlassian.net/wiki/spaces/DC/pages/1333428225/Analysis+of+= Argo+as+a+transport+medium+for+VirtIO > > > > > > > > * Argo can be used for a communication path for configuration > between the > > > > backend > > > > and the toolstack, avoiding the need for a dependency on XenStore= , > > > which > > > > is an > > > > advantage for any hypervisor-agnostic design. It is also amenable > to a > > > > notification > > > > mechanism that is not based on Xen event channels. > > > > > > > > * Argo does not use or require shared memory between VMs and > provides an > > > > alternative > > > > to the use of foreign shared memory mappings. It avoids some of t= he > > > > complexities > > > > involved with using grants (eg. XSA-300). > > > > > > > > * Argo supports Mandatory Access Control by the hypervisor, > satisfying a > > > > common > > > > certification requirement. > > > > > > > > * The Argo headers are BSD-licensed and the Xen hypervisor > implementation > > > > is GPLv2 but > > > > accessible via the hypercall interface. The licensing should not > > > present > > > > an obstacle > > > > to adoption of Argo in guest software or implementation by other > > > > hypervisors. > > > > > > > > * Since the interface that Argo presents to a guest VM is similar t= o > > > DMA, a > > > > VirtIO-Argo > > > > frontend transport driver should be able to operate with a physic= al > > > > VirtIO-enabled > > > > smart-NIC if the toolstack and an Argo-aware backend provide > support. > > > > > > > > The next Xen Community Call is next week and I would be happy to > answer > > > > questions > > > > about Argo and on this topic. I will also be following this thread. > > > > > > > > Christopher > > > > (Argo maintainer, Xen Community) > > > > > > > > > > > > -------------------------------------------------------------------------= ------- > > > > [1] > > > > An introduction to Argo: > > > > > > > > https://static.sched.com/hosted_files/xensummit19/92/Argo%20and%20HMX%20-= %20OpenXT%20-%20Christopher%20Clark%20-%20Xen%20Summit%202019.pdf > > > > https://www.youtube.com/watch?v=3DcnC0Tg3jqJQ > > > > Xen Wiki page for Argo: > > > > > > > > https://wiki.xenproject.org/wiki/Argo:_Hypervisor-Mediated_Exchange_(HMX)= _for_Xen > > > > > > > > [2] > > > > OpenXT Linux Argo driver and userspace library: > > > > https://github.com/openxt/linux-xen-argo > > > > > > > > Windows V4V at OpenXT wiki: > > > > https://openxt.atlassian.net/wiki/spaces/DC/pages/14844007/V4V > > > > Windows v4v driver source: > > > > https://github.com/OpenXT/xc-windows/tree/master/xenv4v > > > > > > > > HP/Bromium uXen V4V driver: > > > > https://github.com/uxen-virt/uxen/tree/ascara/windows/uxenv4vlib > > > > > > > > [3] > > > > v2 of the Argo test unikernel for XTF: > > > > > > > > https://lists.xenproject.org/archives/html/xen-devel/2021-01/msg02234.htm= l > > > > > > > > [4] > > > > Argo HMX Transport for VirtIO meeting minutes: > > > > > > > > https://lists.xenproject.org/archives/html/xen-devel/2021-02/msg01422.htm= l > > > > > > > > VirtIO-Argo Development wiki page: > > > > > > > > https://openxt.atlassian.net/wiki/spaces/DC/pages/1696169985/VirtIO-Argo+= Development+Phase+1 > > > > > > > > > > > --000000000000b9c09e05cb6bab7a Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Tue, Sep 7, 2021 at 4:55 AM AKASHI= Takahiro <takahiro.akashi= @linaro.org> wrote:
Hi,

I have not covered all your comments below yet.
So just one comment:

On Mon, Sep 06, 2021 at 05:57:43PM -0700, Christopher Clark wrote:
> On Thu, Sep 2, 2021 at 12:19 AM AKASHI Takahiro <takahiro.akashi@linaro.org>
> wrote:

(snip)

> >=C2=A0 =C2=A0 It appears that, on FE side, at least three hypervis= or calls (and data
> >=C2=A0 =C2=A0 copying) need to be invoked at every request, right?=
> >
>
> For a write, counting FE sendv ops:
> 1: the write data payload is sent via the "Argo ring for writes&q= uot;
> 2: the descriptor is sent via a sync of the available/descriptor ring<= br> >=C2=A0 =C2=A0-- is there a third one that I am missing?

In the picture, I can see
a) Data transmitted by Argo sendv
b) Descriptor written after data sendv
c) VirtIO ring sync'd to back-end via separate sendv

Oops, (b) is not a hypervisor call, is it?

<= div>That's correct, it is not - the blue arrows in the diagram are not = hypercalls, they are intended to show data movement or action in the flow o= f performing the operation, and (b) is a data write within the guest's = address space into the descriptor ring.

(But I guess that you will have to have yet another call for notification since there is no config register of QueueNotify?)


As a result of the above, I think= that a single hypercall could be sufficient for communicating data for mul= tiple requests, and that a two-hypercall-per-request (worst case) upper bou= nd could also be established.

Christopher

=C2=A0

Thanks,
-Takahiro Akashi


> Christopher
>
>
> >
> > Thanks,
> > -Takahiro Akashi
> >
> >
> > > * Here are the design documents for building VirtIO-over-Arg= o, to
> > support a
> > >=C2=A0 =C2=A0hypervisor-agnostic frontend VirtIO transport dr= iver using Argo.
> > >
> > > The Development Plan to build VirtIO virtual device support = over Argo
> > > transport:
> > >
> > https://openxt.atlassian.net/wiki/spaces/DC/pages/1696169985/VirtIO-Argo+= Development+Phase+1
> > >
> > > A design for using VirtIO over Argo, describing how VirtIO d= ata
> > structures
> > > and communication is handled over the Argo transport:
> > > https://openx= t.atlassian.net/wiki/spaces/DC/pages/1348763698/VirtIO+Argo
> > >
> > > Diagram (from the above document) showing how VirtIO rings a= re
> > synchronized
> > > between domains without using shared memory:
> > >
> > https://openxt.atlassian.net/46e1c93b-2b87-4cb2-951e-abd4377a11= 94#media-blob-url=3Dtrue&id=3D01f7d0e1-7686-4f0b-88e1-457c1d30df40&= collection=3DcontentId-1348763698&contextId=3D1348763698&mimeType= =3Dimage%2Fpng&name=3Ddevice-buffer-access-virtio-argo.png&size=3D2= 43175&width=3D1106&height=3D1241
> > >
> > > Please note that the above design documents show that the ex= isting VirtIO
> > > device drivers, and both vring and virtqueue data structures= can be
> > > preserved
> > > while interdomain communication can be performed with no sha= red memory
> > > required
> > > for most drivers; (the exceptions where further design is re= quired are
> > those
> > > such as virtual framebuffer devices where shared memory regi= ons are
> > > intentionally
> > > added to the communication structure beyond the vrings and v= irtqueues).
> > >
> > > An analysis of VirtIO and Argo, informing the design:
> > >
> > https://openxt.atlassian.net/wiki/spaces/DC/pages/13334= 28225/Analysis+of+Argo+as+a+transport+medium+for+VirtIO
> > >
> > > * Argo can be used for a communication path for configuratio= n between the
> > > backend
> > >=C2=A0 =C2=A0and the toolstack, avoiding the need for a depen= dency on XenStore,
> > which
> > > is an
> > >=C2=A0 =C2=A0advantage for any hypervisor-agnostic design. It= is also amenable to a
> > > notification
> > >=C2=A0 =C2=A0mechanism that is not based on Xen event channel= s.
> > >
> > > * Argo does not use or require shared memory between VMs and= provides an
> > > alternative
> > >=C2=A0 =C2=A0to the use of foreign shared memory mappings. It= avoids some of the
> > > complexities
> > >=C2=A0 =C2=A0involved with using grants (eg. XSA-300).
> > >
> > > * Argo supports Mandatory Access Control by the hypervisor, = satisfying a
> > > common
> > >=C2=A0 =C2=A0certification requirement.
> > >
> > > * The Argo headers are BSD-licensed and the Xen hypervisor i= mplementation
> > > is GPLv2 but
> > >=C2=A0 =C2=A0accessible via the hypercall interface. The lice= nsing should not
> > present
> > > an obstacle
> > >=C2=A0 =C2=A0to adoption of Argo in guest software or impleme= ntation by other
> > > hypervisors.
> > >
> > > * Since the interface that Argo presents to a guest VM is si= milar to
> > DMA, a
> > > VirtIO-Argo
> > >=C2=A0 =C2=A0frontend transport driver should be able to oper= ate with a physical
> > > VirtIO-enabled
> > >=C2=A0 =C2=A0smart-NIC if the toolstack and an Argo-aware bac= kend provide support.
> > >
> > > The next Xen Community Call is next week and I would be happ= y to answer
> > > questions
> > > about Argo and on this topic. I will also be following this = thread.
> > >
> > > Christopher
> > > (Argo maintainer, Xen Community)
> > >
> > >
> > -----------------------------------------------------------------= ---------------
> > > [1]
> > > An introduction to Argo:
> > >
> > https://static.sched.com/ho= sted_files/xensummit19/92/Argo%20and%20HMX%20-%20OpenXT%20-%20Christopher%2= 0Clark%20-%20Xen%20Summit%202019.pdf
> > > https://www.youtube.com/watch?v=3DcnC0Tg= 3jqJQ
> > > Xen Wiki page for Argo:
> > >
> > https://w= iki.xenproject.org/wiki/Argo:_Hypervisor-Mediated_Exchange_(HMX)_for_Xen
> > >
> > > [2]
> > > OpenXT Linux Argo driver and userspace library:
> > > https://github.com/openxt/linux-xen-argo<= br> > > >
> > > Windows V4V at OpenXT wiki:
> > > https://openxt.atlassia= n.net/wiki/spaces/DC/pages/14844007/V4V
> > > Windows v4v driver source:
> > > https://github.com/OpenXT/xc-w= indows/tree/master/xenv4v
> > >
> > > HP/Bromium uXen V4V driver:
> > > https://github.com/ux= en-virt/uxen/tree/ascara/windows/uxenv4vlib
> > >
> > > [3]
> > > v2 of the Argo test unikernel for XTF:
> > >
> > https://lists.xe= nproject.org/archives/html/xen-devel/2021-01/msg02234.html
> > >
> > > [4]
> > > Argo HMX Transport for VirtIO meeting minutes:
> > >
> > https://lists.xe= nproject.org/archives/html/xen-devel/2021-02/msg01422.html
> > >
> > > VirtIO-Argo Development wiki page:
> > >
> > https://openxt.atlassian.net/wiki/spaces/DC/pages/1696169985/VirtIO-Argo+= Development+Phase+1
> > >
> >
> >
--000000000000b9c09e05cb6bab7a-- From xen-devel-bounces@lists.xenproject.org Tue Sep 07 19:53:13 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 19:53:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.181312.328404 (Exim 4.92) (envelope-from ) id 1mNh9N-0000sI-3l; Tue, 07 Sep 2021 19:52:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 181312.328404; Tue, 07 Sep 2021 19:52:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNh9M-0000sB-Vg; Tue, 07 Sep 2021 19:52:56 +0000 Received: by outflank-mailman (input) for mailman id 181312; Tue, 07 Sep 2021 19:52:56 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNh9L-0000s5-TG for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 19:52:56 +0000 Received: from server.eikelenboom.it (unknown [91.121.65.215]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 3051de83-1015-11ec-b121-12813bfff9fa; Tue, 07 Sep 2021 19:52:54 +0000 (UTC) Received: from 76-24-144-85.ftth.glasoperator.nl ([85.144.24.76]:40046 helo=[172.16.1.50]) by server.eikelenboom.it with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1mNh99-0000xc-7f; Tue, 07 Sep 2021 21:52:43 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3051de83-1015-11ec-b121-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=eikelenboom.it; s=20180706; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:To:Subject:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=trC0etVSAP2kxLlL5V959uspM4Sc5FjGHeuAcplcm2s=; b=ALpw8XegMQbrkpYL4zIl8scRe2 6XREaewve79+K+LHR+y3Mj01MyAfYv9yhV8KzAwlcygO/zC9U+xlglFnDPFgC8e0Iw2sSuuEEpTIm jg4SfhgBGLAiWgC42QlkK3fOjZATF0MW2bOaMFON/7Fa6CiqZbO+jK5l3BPe/h8/gQSQ=; Subject: Re: xen-unstable linux-5.14: 1 of 2 multicall(s) failed: cpu 0 To: Juergen Gross , "xen-devel@lists.xenproject.org" References: <9c36205e-cc37-ed9a-3408-0cccc4a83115@eikelenboom.it> <955da8ce-40f2-32c5-ee78-6801ce18afe5@suse.com> From: Sander Eikelenboom Message-ID: Date: Tue, 7 Sep 2021 21:52:52 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <955da8ce-40f2-32c5-ee78-6801ce18afe5@suse.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit On 07/09/2021 15:53, Juergen Gross wrote: > On 06.09.21 23:35, Sander Eikelenboom wrote: >> L.S., >> >> On my AMD box running: >>     xen-unstable changeset: Fri Sep 3 15:10:43 2021 +0200 git:2d4978ead4 >>     linux kernel: 5.14.1 >> >> With this setup I'm encountering some issues in dom0, see below. > > Could you test whether the attached patch (only compile tested) > fixes the issue for you? > > > Juergen > Sure, running it now. Since I haven't got a clear trigger, will report tomorrow if the logs stay clean :) Thanks so far ! -- Sander From xen-devel-bounces@lists.xenproject.org Tue Sep 07 20:53:23 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 20:53:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.181347.328415 (Exim 4.92) (envelope-from ) id 1mNi5D-0007nF-LI; Tue, 07 Sep 2021 20:52:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 181347.328415; Tue, 07 Sep 2021 20:52:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNi5D-0007n8-I7; Tue, 07 Sep 2021 20:52:43 +0000 Received: by outflank-mailman (input) for mailman id 181347; Tue, 07 Sep 2021 20:52:42 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNi5C-0007my-0e; Tue, 07 Sep 2021 20:52:42 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNi5B-0004tT-N8; Tue, 07 Sep 2021 20:52:41 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNi5B-0000vW-6A; Tue, 07 Sep 2021 20:52:41 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mNi5B-0005wE-5h; Tue, 07 Sep 2021 20:52:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=TJa5hmGyOGfHEV4UaYO8IKURO8WopCgVJdKU7xNNWTk=; b=OcCzJnkTQHVURKUzjE+jW01IWE H8tf5sX8eK8ecDKjQFEYv5gwNjjOvkiV1nD0Ui9fHXK+q26CbU/OWBIE9TDpr86HqCC17YlGnIP9h svOJbDIIhL6fKrKBIJiVtK1t6C/0QCtUUZV00xhfQHbUYQrIhyD7cTByUJqb5o8eyCD4=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 164873: tolerable FAIL X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=6c27a8da8d2024aa78a9ec67bcfb18c123e84a17 X-Osstest-Versions-That: xen=6c27a8da8d2024aa78a9ec67bcfb18c123e84a17 From: osstest service owner Date: Tue, 07 Sep 2021 20:52:41 +0000 flight 164873 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/164873/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 164866 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 164866 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 164866 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 164866 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 164866 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 164866 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 164866 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 164866 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 164866 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 164866 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 164866 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen 6c27a8da8d2024aa78a9ec67bcfb18c123e84a17 baseline version: xen 6c27a8da8d2024aa78a9ec67bcfb18c123e84a17 Last test of basis 164873 2021-09-07 11:09:27 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Tue Sep 07 21:28:19 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 21:28:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.181356.328429 (Exim 4.92) (envelope-from ) id 1mNidZ-0003Bh-MN; Tue, 07 Sep 2021 21:28:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 181356.328429; Tue, 07 Sep 2021 21:28:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNidZ-0003Ba-If; Tue, 07 Sep 2021 21:28:13 +0000 Received: by outflank-mailman (input) for mailman id 181356; Tue, 07 Sep 2021 21:28:12 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNidY-0003BU-H9 for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 21:28:12 +0000 Received: from mail-lf1-x12a.google.com (unknown [2a00:1450:4864:20::12a]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 0a400bb9-9177-4b0f-82b0-8f51a1c42618; Tue, 07 Sep 2021 21:28:11 +0000 (UTC) Received: by mail-lf1-x12a.google.com with SMTP id t19so19813lfe.13 for ; Tue, 07 Sep 2021 14:28:11 -0700 (PDT) Received: from [192.168.1.7] ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id k10sm10473lfo.57.2021.09.07.14.28.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Sep 2021 14:28:09 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0a400bb9-9177-4b0f-82b0-8f51a1c42618 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=rCoPbmqBwB8B6I+y0U69hfFC7ri8VBmXepajnA2jkcI=; b=GawO2P5zMyZpdXRAbTM0ddAxKXijkkN9Jx5LugaBUviT+HxZvxx6ZKDVOj9LlxziWh QHPns/U+Rk4YQ6hfCqfnVUzye95HEiIfOcKF7xHKsj6EjHkRmfeU8vUxgN3O3wylY4Am xi4kJJk+p6t7hPoHz1cKytAR9AyLckoLKsVeWORVzhkhNKXhcl58HLw58QnfX5iYdLtu HnbLqBPURowicpYM4/CWrBdQNAggrlzSWfIbWpsPJX/YgSIxs8xVUMFIs6Unr6MlhJU1 dk+ecjgpgFSE387Vkq7E0He7fb62laxZsKvA0oAdqII2JoosEpc+ZyQt003AV7SH6QY4 Dngg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=rCoPbmqBwB8B6I+y0U69hfFC7ri8VBmXepajnA2jkcI=; b=ruE+f628Bab5cADQ/+NBEq3h6UhEVHGsLVEYGW8SMZpcUTmyTqr3H3femHh4eqBt5/ LK09FKqs5eKR6UBhL/R8P4CkIh3oWBSyyU1qfX60Nrt//TGXlpx50u+JEGuThE0aw/qh dNL6/TQASDWPczsC7bHyMiELWswU164HdSlr44mRFsQ7mV2TfMBL7v3fztctWbxVz597 JSIFfZIOCCwoohBkBAY+yXBaFzLSXDN6hzqS8AlCIFfxukDfsdZD0UHzYeMxPNpOG2N9 0UiNNkkDWnivMrwroLu3bOiaYE23mHthOPAD4Jaa2ratWsvStjHKrPwGXEDJqpvIWW0Y NPoQ== X-Gm-Message-State: AOAM533NLo+40lQF6MIikmx3TDvy6jGI+ksF1F3PHYuOdu/k61G2BQcU lahQxxhhiMZ+Mg1HUD6lpMg= X-Google-Smtp-Source: ABdhPJxXV9/nB6x2dRD0ZzUdN29UvvrG5mslv6tFU2OOS4Dhy/0KZj3CI6rKj1YVVrNXmsBp9TTj2A== X-Received: by 2002:a05:6512:21a8:: with SMTP id c8mr321662lft.514.1631050090020; Tue, 07 Sep 2021 14:28:10 -0700 (PDT) Subject: Re: [RFC PATCH 1/3] xen: Introduce "gpaddr_bits" field to XEN_SYSCTL_physinfo To: Andrew Cooper Cc: xen-devel@lists.xenproject.org, Oleksandr Tyshchenko , Ian Jackson , Wei Liu , Anthony PERARD , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Juergen Gross , Volodymyr Babchuk , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Bertrand Marquis , Wei Chen , Henry Wang References: <1631034578-12598-1-git-send-email-olekstysh@gmail.com> <1631034578-12598-2-git-send-email-olekstysh@gmail.com> <973f5344-aa10-3ad6-ff02-ad5f358ad279@citrix.com> From: Oleksandr Message-ID: <0994251e-5e02-009a-851d-4e4ee760fc66@gmail.com> Date: Wed, 8 Sep 2021 00:28:08 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <973f5344-aa10-3ad6-ff02-ad5f358ad279@citrix.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US On 07.09.21 20:35, Andrew Cooper wrote: Hi Andrew > On 07/09/2021 18:09, Oleksandr Tyshchenko wrote: >> From: Oleksandr Tyshchenko >> >> We need to pass info about maximum supported guest address >> space size to the toolstack on Arm in order to properly >> calculate the base and size of the extended region (safe range) >> for the guest. The extended region is unused address space which >> could be safely used by domain for foreign/grant mappings on Arm. >> The extended region itself will be handled by the subsequents >> patch. >> >> Use p2m_ipa_bits variable on Arm, the x86 equivalent is >> hap_paddr_bits. >> >> As we change the size of structure bump the interface version. >> >> Suggested-by: Julien Grall >> Signed-off-by: Oleksandr Tyshchenko > So while I think this is a suitable way forward, you're painting > yourself into a corner WRT migration. > > On x86, the correct value is d->arch.cpuid->extd.maxphysaddr and this > value is under toolstack control, not Xen control.  In particular, it > needs to be min(hostA, hostB) to make migration safe, and yes - this is > currently a hole in x86's migration logic that will cause large VMs to > explode. > > The same will be true on ARM as/when you gain migration support. Oh, I admit, I didn't keep in mind migration support while creating this patch. > > I think this would be better as a domctl.  On ARM, it can reference > p2m_ipa_bits for now along with a /* TODO - make per-domain for > migration support */, while on x86 it can take the appropriate value > (which will soon actually be safe in migration scenarios). OK, could you please clarify, did you mean to introduce new domctl (something like get_maxphysaddr) or reuse some existing? And ... > > However, that does change the ordering requirements in the toolstack - > this hypercall would need to be made after the domain is created, and > has been levelled, and before its main memory layout is decided. ... I am not sure I totally understand the ordering requirements in the toolstack. On Arm this information (gpaddr_bits) should be obtained by the time we call libxl__arch_domain_finalise_hw_description() where we actually calculate extended region and insert it in domain's device-tree. At that time, the domain memory is already populated, so it's layout is known. Please see the last patch of this series, which demonstrates the usage: https://lore.kernel.org/xen-devel/1631034578-12598-4-git-send-email-olekstysh@gmail.com/ > Alternatively, the abstraction could be hidden in libxl itself in arch > specific code, with x86 referring to the local cpu policy (as libxl has > the copy it is/has worked on), and ARM making a hypercall.  This does > make the ordering more obvious. May I please ask what would be the preferred option to move forward? I am fine with both proposed options, with a little preference for the former (common domctl, abstraction is hidden in Xen itself in arch specific code). It is highly appreciated if we could choose the option which would satisfy all parties, this would save me some time. > (As a note on the x86 specifics of this patch, hap_paddr_bits is > actually unused in practice.  It was a proposal from AMD for the > hypervisor to fill in those details, which wasn't implemented by anyone, > not even Xen, because the important field to modify is maxphysaddr if > you don't want to rewrite every kernel to behave differently when > virtualised.) Thank you for the clarification. > > ~Andrew > -- Regards, Oleksandr Tyshchenko From xen-devel-bounces@lists.xenproject.org Tue Sep 07 21:34:44 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 21:34:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.181364.328439 (Exim 4.92) (envelope-from ) id 1mNijn-0004l9-CY; Tue, 07 Sep 2021 21:34:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 181364.328439; Tue, 07 Sep 2021 21:34:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNijn-0004l2-9d; Tue, 07 Sep 2021 21:34:39 +0000 Received: by outflank-mailman (input) for mailman id 181364; Tue, 07 Sep 2021 21:34:38 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNijl-0004kw-To for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 21:34:37 +0000 Received: from mail-lj1-x231.google.com (unknown [2a00:1450:4864:20::231]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id c141cd11-d8c8-4d3a-adaf-8e5ec596e468; Tue, 07 Sep 2021 21:34:36 +0000 (UTC) Received: by mail-lj1-x231.google.com with SMTP id y6so848208lje.2 for ; Tue, 07 Sep 2021 14:34:36 -0700 (PDT) Received: from [192.168.1.7] ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id g10sm11246lfb.87.2021.09.07.14.34.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Sep 2021 14:34:35 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c141cd11-d8c8-4d3a-adaf-8e5ec596e468 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=X3YkShdpCjM0j8ZJigoaLHyM/keq1t8ObtbGWzImwWs=; b=V7Z2S2HGFliTqXR5z+T5SKrmTBIfsYQA/s7U71bLMtmcWh0w18IZXZzNwo0ebUiRxk XgeZNNf7lFV4m1cCZ/zo691i89CXPU2ELG1qlRtwHVUiud+rMuibDSUsqAjZqehzC3ig xg2cGzo1yAwq6NGWwO4LNWEkdgpoGsvw3OD0ymhb5vWvbTNWNStnTV2YTG/B0Xpv/uce hjqiQ3nzhxNnTKBpK83GrNZoXscSZ5Qq/iBj/8BQZcF7C+urcDpxVhMidzOlZfvDOFev vilsdOgVU8a0ZZHFFbMr3TJCjSLm//rtDFpNLMQxHwOQV03o36fUR+uvESynoOvKfGQi 47lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=X3YkShdpCjM0j8ZJigoaLHyM/keq1t8ObtbGWzImwWs=; b=Zm7P3cK00zBmm1b5ilRBP24oFY8ONANMJzbg3njQ3dMx0BozKnODTUTLz6PQ0YqJwq cZJ3YQDBwuouLq3RcMQo2IX72Qc1SfZbA0WoCK3JNL4wdHhGAm3jCkgk8td7vnhfiLc7 E9TqWVVFDeBwFO/r7FGj2EYxhe9yyivmQkKyG7DmXZHeX8BmgO8t9E/TA3IesHVgWzAo jm/XdpmOrq10jlBbuOgU+rU96HyUbmzn6SKsxBiW3oTOKj5C7a6DEFUTQnZsDTywh3Ba YqHZ+OmKXA7I5VK8xfajHxfM2GJr/ljtSf39LM9G6uPA32P+w+I46sDeWBMxC/Iglt/O Q2Gw== X-Gm-Message-State: AOAM532o0Lcqv+Hzf7XhTB587SLSbpGC+wc6By2WOtNYvM442W8WnFXI 21AxJ6LEvZeiDYJmrodZGd8= X-Google-Smtp-Source: ABdhPJwLmj7DVmaZk+g6qRV0XlrRzgLrUEGqmkKXpjdOLi1nQnMrPUtIUmK6+j1KR5qFqcM9O4F1uA== X-Received: by 2002:a2e:90ca:: with SMTP id o10mr232555ljg.67.1631050475852; Tue, 07 Sep 2021 14:34:35 -0700 (PDT) Subject: Re: [RFC PATCH] xen/memory: Introduce a hypercall to provide unallocated space To: Henry Wang Cc: "xen-devel@lists.xenproject.org" , Oleksandr Tyshchenko , Daniel De Graaf , "Daniel P. Smith" , Ian Jackson , Wei Liu , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Volodymyr Babchuk , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Bertrand Marquis , Wei Chen References: <1627489110-25633-1-git-send-email-olekstysh@gmail.com> From: Oleksandr Message-ID: Date: Wed, 8 Sep 2021 00:34:34 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US On 07.09.21 11:53, Henry Wang wrote: > Hi Oleksandr, Hi Henry > >> -----Original Message----- >> From: Xen-devel On Behalf Of >> Oleksandr Tyshchenko >> Sent: Thursday, July 29, 2021 12:19 AM >> To: xen-devel@lists.xenproject.org >> Cc: Oleksandr Tyshchenko ; Daniel De >> Graaf ; Daniel P. Smith >> ; Ian Jackson ; Wei >> Liu ; Andrew Cooper ; George >> Dunlap ; Jan Beulich ; >> Julien Grall ; Stefano Stabellini ; >> Volodymyr Babchuk ; Roger Pau Monné >> ; Bertrand Marquis ; >> Wei Chen >> Subject: [RFC PATCH] xen/memory: Introduce a hypercall to provide >> unallocated space >> >> From: Oleksandr Tyshchenko >> >> Add XENMEM_get_unallocated_space hypercall which purpose is to >> query hypervisor to find regions of guest physical address space >> which are unused and can be used to create grant/foreign mappings >> instead of wasting real pages from the domain memory for >> establishing these mappings. The problem with the current Linux >> on Xen on Arm behaviour is if we want to map some guest memory >> regions in advance or to perform cache mappings in the backend >> we might run out of memory in the host (see XSA-300). >> This of course, depends on the both host and guest memory sizes. >> >> The "unallocated space" can't be figured out precisely by >> the domain on Arm without hypervisor involvement: >> - not all device I/O regions are known by the time domain starts >> creating grant/foreign mappings >> - the Dom0 is not aware of memory regions used for the identity >> mappings needed for the PV drivers to work >> In both cases we might end up re-using these regions by >> a mistake. So, the hypervisor which maintains the P2M for the domain >> is in the best position to provide "unallocated space". >> >> The arch code is in charge of finding these regions and filling >> in corresponding array in new helper arch_get_unallocated_space(). >> >> This patch implements common and Arm parts, the x86 specific bits >> are left uniplemented for now. >> >> Signed-off-by: Oleksandr Tyshchenko > Tested-by: Henry Wang Thank you! Please note, I have pushed new version (which is notably different) based on the discussion in current thread: https://lore.kernel.org/xen-devel/1631034578-12598-1-git-send-email-olekstysh@gmail.com/ > > Kind regards, > > Henry > -- Regards, Oleksandr Tyshchenko From xen-devel-bounces@lists.xenproject.org Tue Sep 07 21:40:48 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 21:40:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.181370.328451 (Exim 4.92) (envelope-from ) id 1mNipe-00069N-2S; Tue, 07 Sep 2021 21:40:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 181370.328451; Tue, 07 Sep 2021 21:40:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNipd-00069G-Vf; Tue, 07 Sep 2021 21:40:41 +0000 Received: by outflank-mailman (input) for mailman id 181370; Tue, 07 Sep 2021 21:40:40 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNipc-00069A-N9 for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 21:40:40 +0000 Received: from mailhost.m5p.com (unknown [74.104.188.4]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id c0f389cb-a8c4-4acf-b99a-78afcad85853; Tue, 07 Sep 2021 21:40:39 +0000 (UTC) Received: from m5p.com (mailhost.m5p.com [IPv6:2001:470:1f07:15ff:0:0:0:f7]) by mailhost.m5p.com (8.16.1/8.15.2) with ESMTPS id 187LeWHK073357 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Tue, 7 Sep 2021 17:40:37 -0400 (EDT) (envelope-from ehem@m5p.com) Received: (from ehem@localhost) by m5p.com (8.16.1/8.15.2/Submit) id 187LeW1h073356; Tue, 7 Sep 2021 14:40:32 -0700 (PDT) (envelope-from ehem) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c0f389cb-a8c4-4acf-b99a-78afcad85853 Date: Tue, 7 Sep 2021 14:40:31 -0700 From: Elliott Mitchell To: Jan Beulich Cc: xen-devel@lists.xenproject.org Subject: Re: HVM/PVH Balloon crash Message-ID: References: <84d9137e-a268-c3d8-57d2-76fb596e00d3@suse.com> <1b3d4cb1-ba61-0f61-5097-9978462a2401@suse.com> <935dc03f-74f5-4b49-3a45-71148364fb5a@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <935dc03f-74f5-4b49-3a45-71148364fb5a@suse.com> X-Spam-Status: No, score=0.4 required=10.0 tests=KHOP_HELO_FCRDNS autolearn=no autolearn_force=no version=3.4.5 X-Spam-Checker-Version: SpamAssassin 3.4.5 (2021-03-20) on mattapan.m5p.com On Tue, Sep 07, 2021 at 05:57:10PM +0200, Jan Beulich wrote: > On 07.09.2021 17:03, Elliott Mitchell wrote: > > On Tue, Sep 07, 2021 at 10:03:51AM +0200, Jan Beulich wrote: > >> > >> That sounds odd at the first glance - PVH simply requires that there be > >> an (enabled) IOMMU. Hence the only thing I could imagine is that Xen > >> doesn't enable the IOMMU in the first place for some reason. > > > > Doesn't seem that odd to me. I don't know the differences between the > > first and second versions of the AMD IOMMU, but could well be v1 was > > judged not to have enough functionality to bother with. > > > > What this does make me wonder is, how much testing was done on systems > > with functioning NPT, but disabled IOMMU? > > No idea. During development is may happen (rarely) that one disables > the IOMMU on purpose. Beyond that - can't tell. Thus this processor having an early and not too capable IOMMU seems worthy of note. > > Could be this system is in an > > intergenerational hole, and some spot in the PVH/HVM code makes an > > assumption of the presence of NPT guarantees presence of an operational > > IOMMU. Otherwise if there was some copy and paste while writing IOMMU > > code, some portion of the IOMMU code might be checking for presence of > > NPT instead of presence of IOMMU. > > This is all very speculative; I consider what you suspect not very likely, > but also not entirely impossible. This is not the least because for a > long time we've been running without shared page tables on AMD. > > I'm afraid without technical data and without knowing how to repro, I > don't see a way forward here. I cannot report things which do not exist. This occurs very quickly and no warning or error messages have ever been observed on the main console (VGA). Happens during user domain kernel boot. The configuration: builder = "hvm" name = "kr45h" memory = 1024 maxmem = 16384 vcpus = 2 vif = [ '' ] disk = [ 'vdev=sdc,format=raw,access=r,devtype=cdrom,target=/tmp/boot.iso', ] sdl = 1 has been tested and confirmed to reproduce. Looks like this was last examined with a FreeBSD 12.2 AMD64 ISO, but Linux ISOs (un)happily work too. It is less than 40 seconds from `xl create` to indications of hardware boot process starting. Since there don't appear to be too many reports, the one factor which now stands out is this machine has an AMD processor. Xen confirms presence of NPT support, but reports "I/O virtualisation disabled" (older, less capable IOMMU). -- (\___(\___(\______ --=> 8-) EHM <=-- ______/)___/)___/) \BS ( | ehem+sigmsg@m5p.com PGP 87145445 | ) / \_CS\ | _____ -O #include O- _____ | / _/ 8A19\___\_|_/58D2 7E3D DDF4 7BA6 <-PGP-> 41D1 B375 37D0 8714\_|_/___/5445 From xen-devel-bounces@lists.xenproject.org Tue Sep 07 23:17:47 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 23:17:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.181386.328473 (Exim 4.92) (envelope-from ) id 1mNkLV-0008N0-GN; Tue, 07 Sep 2021 23:17:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 181386.328473; Tue, 07 Sep 2021 23:17:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNkLV-0008Mt-DD; Tue, 07 Sep 2021 23:17:41 +0000 Received: by outflank-mailman (input) for mailman id 181386; Tue, 07 Sep 2021 23:17:39 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNkLT-0008MB-SU for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 23:17:39 +0000 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id caacbc92-1031-11ec-b132-12813bfff9fa; Tue, 07 Sep 2021 23:17:38 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id B8F1B60F14; Tue, 7 Sep 2021 23:17:37 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: caacbc92-1031-11ec-b132-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1631056657; bh=XA9IMkep5CyFBW7EaXh7yuXdS92Q2DxXSqumrb+GRfg=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=prsFy9ld4u6dcUI5qwFjPyEYdvofujezsY1Tbg7zSxFIpBKmFB/WPgxIhDpUSquKT f1O1/chMuzqiB3UH9x0WmUeDqtscIB1+2zDWKReVKk0bbGGdt7mbf2z3XwwFyw4dvR CkNuESdDmAvzrhGrX9dfYFVr9p1Pk3NXCRUBCwSndEThCN6vcZ33pKHuvw6Wi4qyEU kyTm+l16HtEx6taf8vWgQm/xw8XvoVLgsQ0QboMGyjFBIe5qAt2wCoGwn0iRXNpk5j T6vOPWDSTi7Ieq2m8eQe2rL1mSd8JlimJXGLcaKeihXNhHl/pbYFGTkNi75TxySDA7 1AWB1402BJrbw== Date: Tue, 7 Sep 2021 16:17:37 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: Bertrand Marquis cc: Julien Grall , Stefano Stabellini , "xen-devel@lists.xenproject.org" , Volodymyr Babchuk Subject: Re: [PATCH v3 7/7] xen/arm: Sanitize CTR_EL0 and emulate it if needed In-Reply-To: Message-ID: References: <14b1639e-c9e4-f8fb-e921-73d7f28681ac@xen.org> <98E8FB9D-3372-47D2-92F7-8AD401AC1092@arm.com> <6705127a-bde2-36cd-0fed-900eb1eace03@xen.org> <7fc6e6b6-464a-a305-2693-42cba40ad869@xen.org> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: multipart/mixed; BOUNDARY="8323329-1027929738-1631056639=:14059" Content-ID: This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-1027929738-1631056639=:14059 Content-Type: text/plain; CHARSET=UTF-8 Content-Transfer-Encoding: 8BIT Content-ID: On Tue, 7 Sep 2021, Bertrand Marquis wrote: > Hi Julien, > > > On 6 Sep 2021, at 18:36, Julien Grall wrote: > > > > Hi Bertrand, > > > > On 06/09/2021 09:29, Bertrand Marquis wrote: > >>> On 3 Sep 2021, at 23:49, Stefano Stabellini wrote: > >>> > >>> On Tue, 31 Aug 2021, Bertrand Marquis wrote: > >>>> Hi Julien, > >>>> > >>>>> On 31 Aug 2021, at 15:47, Julien Grall wrote: > >>>>> > >>>>> > >>>>> > >>>>> On 31/08/2021 14:17, Bertrand Marquis wrote: > >>>>>> Hi Julien, > >>>>> > >>>>> Hi Bertrand, > >>>>> > >>>>>>> On 27 Aug 2021, at 16:05, Julien Grall wrote: > >>>>>>> > >>>>>>> Hi Bertrand, > >>>>>>> > >>>>>>> On 25/08/2021 14:18, Bertrand Marquis wrote: > >>>>>>>> Sanitize CTR_EL0 value between cores. > >>>>>>>> In most cases different values will taint Xen but if different > >>>>>>>> i-cache policies are found, we choose the one which will be compatible > >>>>>>>> between all cores in terms of invalidation/data cache flushing strategy. > >>>>>>> > >>>>>>> I understand that all the CPUs in Xen needs to agree on the cache flush strategy. However... > >>>>>>> > >>>>>>>> In this case we need to activate the TID2 bit in HCR to emulate the > >>>>>>>> TCR_EL0 register for guests. This patch is not activating TID2 bit all > >>>>>>>> the time to limit the overhead when possible. > >>>>>>> > >>>>>>> as we discussed in an earlier version, a vCPU is unlikely (at least in short/medium) to be able move across pCPU of different type. So the vCPU would be pinned to a set of pCPUs. IOW, the guest would have to be big.LITTLE aware and therefore would be able to do its own strategy decision. > >>>>>>> > >>>>>>> So I think we should be able to get away from trappings the registers. > >>>>>> I do agree that we should be able to get away from that in the long term once > >>>>>> we have cpupools properly set but right now this is the only way to have > >>>>>> something useable (I will not say right). > >>>>>> I will work on finding a way to setup properly cpupools (or something else as > >>>>>> we discussed earlier) but in the short term I think this is the best we can do. > >>>>> > >>>>> My concern is you are making look like Xen will be able to deal nicely with big.LITTLE when in fact there are a lot more potential issue by allow a vCPU moving accross pCPU of different type (the errata is one example). > >>>> > >>>> I agree and this is why Xen is tainted. > >>>> > >>>>> > >>>>>> An other solution would be to discard this patch from the serie for now until > >>>>>> I have worked a proper solution for this case. > >>>>>> Should we discard or merge or do you have an other idea ? > >>>>> Please correct me if I am wrong, at the moment, it doesn't look like this patch will be part of the longer plan. If so, then I think it should be parked for now. > >>>> > >>>> Not sure it depends on what the final solution would be but this is highly possible I agree. > >>>> > >>>>> > >>>>> This would also have the advantage to avoid spending too much time on resolving the emulation issue I mentioned in my previous answer. > >>>>> > >>>>> No need to resend a new version of this series yet. You can wait until the rest of the series get more feedback. > >>>> > >>>> Ok, I will wait for feedback and next serie will not include this patch anymore. > >>> > >>> Would it be worth keeping just the part that sanitizes ctr, without any > >>> of the emulation stuff? That way we could still detect cases where there > >>> is a mismatch between CPUs, print a useful message and taint Xen. > >> That’s a good idea, it means removing the emulation part and just keep the sanitization. > >> @Julien: would you be ok with that ? > > > > I actually thought about suggesting it before Stefano did it. So I am OK with that. > > > >> Should I send a v4 or should we use Stefano’s patch directly instead ? > > > > I would suggest to send a v4. This needs a signed-off-by from Stefano and a new commit message. > > Ok I will do that beginning of next week. Of course you can add my signed-off-by and even my reviewed-by (although it will look weird as it seems I reviewed my own patch) --8323329-1027929738-1631056639=:14059-- From xen-devel-bounces@lists.xenproject.org Tue Sep 07 23:17:48 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 23:17:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.181385.328461 (Exim 4.92) (envelope-from ) id 1mNkLN-000856-8b; Tue, 07 Sep 2021 23:17:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 181385.328461; Tue, 07 Sep 2021 23:17:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNkLN-00084z-5M; Tue, 07 Sep 2021 23:17:33 +0000 Received: by outflank-mailman (input) for mailman id 181385; Tue, 07 Sep 2021 23:17:31 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNkLL-00084t-CG for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 23:17:31 +0000 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 1aa5a533-8819-49de-b45c-841c709c772c; Tue, 07 Sep 2021 23:17:30 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 3582160F14; Tue, 7 Sep 2021 23:17:29 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1aa5a533-8819-49de-b45c-841c709c772c DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1631056649; bh=YjPWq2Wq+vSUdQyVVhKv+XleADcbhg8WXnCbpZrIKik=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=UX+twxd8x6POOzQBrVSlknvMWUwFTnsr+QwKOHztzsb58c5X7R40gpqX0ZlZ1thzd /wjZxl5MWTENvH6LvfGUqP7/5XDZpPU5D5mDPi/O1HwnJYJLwg3V/SfpysZ/vapLkn 0bzdJyy/RUkgJtsrSrq1QTlE8iRh303UrJsxyYFJsk19CNBS+MHIrBTCF5Noh1G1Xl Rd5byoNSdfNOlC14YYQelo1qkLpYp3P38XHKZjprIUsKnYR3txhLDAYbL7/yJ+EJYg c44hPhwh2mCyfclt7pqkBw2ZnmGAChzYfBlqzOfP7MF/T88Wm4qy20spag00Dd0y/y zJvhtgnnhxokA== Date: Tue, 7 Sep 2021 16:17:28 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: Bertrand Marquis cc: Stefano Stabellini , "xen-devel@lists.xenproject.org" , Julien Grall , Volodymyr Babchuk Subject: Re: [PATCH v3 6/7] xen/arm: Taint Xen on incompatible DCZID values In-Reply-To: Message-ID: References: User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Mon, 6 Sep 2021, Bertrand Marquis wrote: > > On 3 Sep 2021, at 23:49, Stefano Stabellini wrote: > > > > On Wed, 25 Aug 2021, Bertrand Marquis wrote: > >> Use arm64 cpu feature sanitization to TAIN Xen if different DCZID values > > ^ TAINT > > > > > >> are found (ftr_dczid is using only STRICT method). > >> In this case actual memory being cleaned by DC ZVA operations would be > >> different depending on the cores which could make a guest zeroing too > >> much or too little memory if it is merged between CPUs. > >> > >> We could, on processor supporting it, trap access to DCZID_EL0 register > > ^ processors > > Could those typos be fixed during commit ? Yes they can > >> using HFGRTR_EL2 register but this would not solve the case where a > >> process is being migrated during a copy or if it cached the value of the > >> register. > >> > >> Signed-off-by: Bertrand Marquis > >> --- > >> Change in v3: none > >> Change in v2: Patch introduced in v2 > >> --- > >> xen/arch/arm/arm64/cpufeature.c | 14 +++++++++++--- > >> xen/arch/arm/cpufeature.c | 2 ++ > >> xen/include/asm-arm/cpufeature.h | 8 ++++++++ > >> 3 files changed, 21 insertions(+), 3 deletions(-) > >> > >> diff --git a/xen/arch/arm/arm64/cpufeature.c b/xen/arch/arm/arm64/cpufeature.c > >> index 61f629ebaa..b1936ef1d6 100644 > >> --- a/xen/arch/arm/arm64/cpufeature.c > >> +++ b/xen/arch/arm/arm64/cpufeature.c > >> @@ -329,14 +329,11 @@ static const struct arm64_ftr_bits ftr_mvfr2[] = { > >> ARM64_FTR_END, > >> }; > >> > >> -#if 0 > >> -/* TODO: handle this when sanitizing cache related registers */ > >> static const struct arm64_ftr_bits ftr_dczid[] = { > >> ARM64_FTR_BITS(FTR_VISIBLE, FTR_STRICT, FTR_EXACT, DCZID_DZP_SHIFT, 1, 1), > >> ARM64_FTR_BITS(FTR_VISIBLE, FTR_STRICT, FTR_LOWER_SAFE, DCZID_BS_SHIFT, 4, 0), > >> ARM64_FTR_END, > >> }; > >> -#endif > >> > >> static const struct arm64_ftr_bits ftr_id_isar0[] = { > >> ARM64_FTR_BITS(FTR_HIDDEN, FTR_STRICT, FTR_LOWER_SAFE, ID_ISAR0_DIVIDE_SHIFT, 4, 0), > >> @@ -592,6 +589,17 @@ void update_system_features(const struct cpuinfo_arm *new) > >> > >> SANITIZE_ID_REG(zfr64, 0, aa64zfr0); > >> > >> + /* > >> + * Comment from Linux: > > > > I don't know if I would keep or remove "Comment from Linux" > > I added that because the comment itself does not really apply to Xen. > I could have rephrased the comment/ > Anyway I have no objection to remove that statement. > > Do I need to send a v2 for that ? No you don't need to resend just for that or the typos. However if you are going to resend, then an update would be nice :-) From xen-devel-bounces@lists.xenproject.org Tue Sep 07 23:32:22 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 07 Sep 2021 23:32:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.181403.328484 (Exim 4.92) (envelope-from ) id 1mNkZd-0002p0-TE; Tue, 07 Sep 2021 23:32:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 181403.328484; Tue, 07 Sep 2021 23:32:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNkZd-0002ot-QC; Tue, 07 Sep 2021 23:32:17 +0000 Received: by outflank-mailman (input) for mailman id 181403; Tue, 07 Sep 2021 23:32:17 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNkZd-0002oj-2H; Tue, 07 Sep 2021 23:32:17 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNkZc-0007fe-PX; Tue, 07 Sep 2021 23:32:16 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNkZc-0001QX-D0; Tue, 07 Sep 2021 23:32:16 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mNkZc-00039a-CY; Tue, 07 Sep 2021 23:32:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=F9k0EF5cS0WsEXI+wXRHk8idvPFgzt/INONcaPSr6QE=; b=S4pIqQLgLDTa8sALgT3UwPlGhC rL7b59lXxYZbVguQvGAmN5h7nOe3PAepsIZ6zTFvEWXrX4VG9LCf2AB6tORguYhTSH5bMEfe/Qs/r e91NaMfQ3vC+r1Y40lSZ/Yhqd6W+DWvkjON4iV/9MaQEAh58CxpwPppSMdUZW7bdfjm4=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 164874: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=a61c30b8c8c3c8619847cfaa289233cc696f5689 X-Osstest-Versions-That: qemuu=935efca6c246c108253b0e4e51cc87648fc7ca10 From: osstest service owner Date: Tue, 07 Sep 2021 23:32:16 +0000 flight 164874 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/164874/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 164864 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 164864 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 164864 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 164864 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 164864 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 164864 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 164864 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass version targeted for testing: qemuu a61c30b8c8c3c8619847cfaa289233cc696f5689 baseline version: qemuu 935efca6c246c108253b0e4e51cc87648fc7ca10 Last test of basis 164864 2021-09-06 18:07:55 Z 1 days Testing same since 164874 2021-09-07 12:37:56 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Michael Tokarev Peter Maydell jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git 935efca6c2..a61c30b8c8 a61c30b8c8c3c8619847cfaa289233cc696f5689 -> upstream-tested From xen-devel-bounces@lists.xenproject.org Wed Sep 08 00:49:43 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Sep 2021 00:49:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.181412.328498 (Exim 4.92) (envelope-from ) id 1mNlmI-00032w-Kh; Wed, 08 Sep 2021 00:49:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 181412.328498; Wed, 08 Sep 2021 00:49:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNlmI-00032p-Hl; Wed, 08 Sep 2021 00:49:26 +0000 Received: by outflank-mailman (input) for mailman id 181412; Wed, 08 Sep 2021 00:49:24 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNlmG-00032j-Ra for xen-devel@lists.xenproject.org; Wed, 08 Sep 2021 00:49:24 +0000 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 9c0d77ac-103e-11ec-b138-12813bfff9fa; Wed, 08 Sep 2021 00:49:23 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id C8EFC60F92; Wed, 8 Sep 2021 00:49:22 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9c0d77ac-103e-11ec-b138-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1631062163; bh=7Wrz7jbq4ZQpZbwmyQgxeFbh9DIedMdFxmZ4tupnR8g=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=loxhqFx2E6wvRf5U+77Vgq/G4KD4QYGjNxv/XXwguJR7h+SGcMNdeCalOVlWBVmlv XpxOnyIjCYt9iNy/57iu/a55l7C51KbUdnvtZqrf8owUP8ymQHDG5/8v6I9y/iqKNY 2Rf/pUzL1rOqvX0AVjQX0rz4UvQ4jlhnBPXO5zEVnwSZezdW8uLbTh9tv9pXTXtqam 5CbGn/QNfcrdITpjLzz71QHXWDUfIXt98Ln6hHjz9PJdrlzA8yokvcxNB1M37+gZzx YdyMRfDizU/B1oCc1Vg/7S3x3J97fGgH9rBTDpNXNERBLNINInx5C4/DFrzXpKGjTK yMstLYGXAQWIA== Date: Tue, 7 Sep 2021 17:49:21 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: Jan Beulich cc: Juergen Gross , Boris Ostrovsky , Stefano Stabellini , lkml , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH] xen/pvcalls: backend can be a module In-Reply-To: <54a6070c-92bb-36a3-2fc0-de9ccca438c5@suse.com> Message-ID: References: <54a6070c-92bb-36a3-2fc0-de9ccca438c5@suse.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Tue, 7 Sep 2021, Jan Beulich wrote: > It's not clear to me why only the frontend has been tristate. Switch the > backend to be, too. > > Signed-off-by: Jan Beulich Actually although the frontend is a tristate, it cannot really work as a module. Specifically see pvcalls_stream_ops in the enabling patch (still not upstream): https://github.com/lf-edge/runx/blob/master/kernel/patches/0001-patch-pvcalls_enable.patch So I had to change tristate to bool for XEN_PVCALLS_FRONTEND in our internal kernel tree. That said, the PVCalls backend could very well be a module and technically I don't see any reasons why not. So: Acked-by: Stefano Stabellini > --- a/drivers/xen/Kconfig > +++ b/drivers/xen/Kconfig > @@ -214,7 +214,7 @@ config XEN_PVCALLS_FRONTEND > implements them. > > config XEN_PVCALLS_BACKEND > - bool "XEN PV Calls backend driver" > + tristate "XEN PV Calls backend driver" > depends on INET && XEN && XEN_BACKEND > help > Experimental backend for the Xen PV Calls protocol > From xen-devel-bounces@lists.xenproject.org Wed Sep 08 01:09:28 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Sep 2021 01:09:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.181419.328509 (Exim 4.92) (envelope-from ) id 1mNm5b-0003wJ-7s; Wed, 08 Sep 2021 01:09:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 181419.328509; Wed, 08 Sep 2021 01:09:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNm5b-0003wC-4j; Wed, 08 Sep 2021 01:09:23 +0000 Received: by outflank-mailman (input) for mailman id 181419; Wed, 08 Sep 2021 01:09:22 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNm5Z-0003w6-VT for xen-devel@lists.xenproject.org; Wed, 08 Sep 2021 01:09:21 +0000 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 65802e8e-1041-11ec-b138-12813bfff9fa; Wed, 08 Sep 2021 01:09:20 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 84E906113B; Wed, 8 Sep 2021 01:09:19 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 65802e8e-1041-11ec-b138-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1631063360; bh=pGXBU6C0v1ImgWBSjk60VtuyKReuk2qQAlQteZR1lUo=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=CJHu7UaR1Kr3UbMYACb0j3DTxNpyeGwKxPfmfXL2LssgXd/P3ZlKM5ZvndqceczU1 nAXypYKoIyvI8PEUdOpKtZceQGicsw7jAYx8GVvvoTPiflgO/OliLcQn1UexFwoEoh XxCnObIK7BYhvhBA53pbBOaJJN4E0ztqmglRF8xpFl7i01AFI1tTmyF1pGzU4nSbtY rxwONC465Pvz5sNTUcSp7DujBW01nckbkYz9Pda0J2C+HNyVySH4hSET04PJWrrToc huWctUAvQwKvrwrgPjGntWqag7YZJeb+E2LwXEKr64iz27fjXKmuLoOXc/RKhkm9fG 5eqOGeEB1YIUA== Date: Tue, 7 Sep 2021 18:09:18 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: Julien Grall cc: Luca Fancellu , xen-devel@lists.xenproject.org, Bertrand Marquis , wei.chen@arm.com, Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Stefano Stabellini , Wei Liu Subject: Re: [RFC PATCH] xen/design: Add design for EFI dom0less system start In-Reply-To: <1efbd9a8-232b-b267-fa8e-7f5f1af7cfed@xen.org> Message-ID: References: <20210907065228.21794-1-luca.fancellu@arm.com> <4bab7902-0268-5705-5462-fcd7571d7492@xen.org> <7BD59287-75ED-4D4F-B892-F6B04583A986@arm.com> <1efbd9a8-232b-b267-fa8e-7f5f1af7cfed@xen.org> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: multipart/mixed; BOUNDARY="8323329-792418537-1631062279=:14059" Content-ID: This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-792418537-1631062279=:14059 Content-Type: text/plain; CHARSET=UTF-8 Content-Transfer-Encoding: 8BIT Content-ID: On Tue, 7 Sep 2021, Julien Grall wrote: > On 07/09/2021 12:51, Luca Fancellu wrote: > > > On 7 Sep 2021, at 10:35, Julien Grall wrote: > > > > > > Hi Luca, > > > > > > On 07/09/2021 07:52, Luca Fancellu wrote: > > > > Add a design describing a proposal to improve the EFI > > > > configuration file, adding keywords to describe domU > > > > guests and allowing to start a dom0less system. > > > > Signed-off-by: Luca Fancellu > > > > --- > > > > docs/designs/efi-arm-dom0less.md | 105 +++++++++++++++++++++++++++++++ > > > > 1 file changed, 105 insertions(+) > > > > create mode 100644 docs/designs/efi-arm-dom0less.md > > > > diff --git a/docs/designs/efi-arm-dom0less.md > > > > b/docs/designs/efi-arm-dom0less.md > > > > new file mode 100644 > > > > index 0000000000..8d8fa2243f > > > > --- /dev/null > > > > +++ b/docs/designs/efi-arm-dom0less.md > > > > @@ -0,0 +1,105 @@ > > > > +# Xen EFI configuration file > > > > + > > > > +The current configuration file used by Xen when it is started as an EFI > > > > +application is considering only the dom0 guest and doesn't have any > > > > +property to describe and load in memory domU guests. > > > > > > From my understanding, the problem is less about properties (we already > > > have them in the Device-Tree) but more about where are the binaries > > > located in memory as we don't know in advance. > > > > Hi Julien, > Hi Luca, > > > I think I used the wrong word there, I meant “keyword” instead of “property” > > because I was referring about the > > lack of keywords to describe a domu guest in the Xen EFI configuration file. > > > > I agree with you that on systems with static allocation, the kernel and > > ramdisk binaries must be at certain locations > > that are out of control when we use the EFI boot services, the thing we can > > do is provide a keyword to specify the > > addresses and then use the CopyMem() function to relocate the kernel/ramdisk > > in the address we want. > > I wasn't specifically referring to static allocation here, sorry if this > wasn't clear. I was pointing out that most of the information you create in > the xen.cfg is going to be similar to what we already provide in the > Device-Tree. > > My main concern is everytime we add a new feature in Dom0less, a developer > would need to write code for the DT and UEFI. This will increase the code size > and maintenance. > > The same can be said for the admin as if they want to switch from plain U-boot > to UEFI, they would also need to fully rewrite the bindings. > > AFAICT, most of the information provided in the Device-Tree are usable even > when using UEFI. So I would prefer if we try to re-use what's existing. This > is what my proposal below was about. > > > > > > > > > So I would like to propose something that build on top of the Device-Tree > > > work we did. Note this is early thoughts. > > > > > > The problematic nodes in the DT are: > > > > > > module@0x4a000000 { > > > compatible = "multiboot,kernel", "multiboot,module"; > > > reg = <0x0 0x4a000000 0xffffff>; > > > bootargs = "console=ttyAMA0 init=/bin/sh"; > > > }; > > > > > > module@0x4b000000 { > > > compatible = "multiboot,ramdisk", "multiboot,module"; > > > reg = <0x0 0x4b000000 0xffffff>; > > > }; > > > > > > In particular the property "reg" cannot be known in advance because the > > > UEFI stub will be responsible to load the binaries in memory. > > > > Yes that’s true, the UEFI stub is using from the UEFI boot service the > > AllocatePages function that is giving back an address out of our control, > > then using another function the binary is read from the disk and copied at > > that address, finally the UEFI stub is writing the node in the device tree > > that > > will be used by Xen later. > > I am not sure to follow. Are you saying the UEFI stub will create the dom0less > node in the DT based on the xen.cfg? > > > > > > > > > What we could do is providing a list of binaries to load and associate a > > > key for each of them. Something like: > > > > > > binary= > > > binary= > > > .... > > > > > > We can then replace the property "reg" with a new property "uefi,key" that > > > will contain the name of the binary. > > > > > > What do you think? > > > > Here I’m lost, because I don’t understand what we are going to do with the > > name of the binary. > > would be used by the UEFI stub to load the binary in memory. Each > binary will have a which helps to refer them in the Device-Tree. To > give a concrete example, let say we have two dom0less domains: > - DomA: 2 vCPUs, 128MB > - DomB: 3 vCPUs, 512MB > > DomA and DomB will be using the same kernel but a different ramdisk. xen.cfg, > would look like: > > [global] > default=section1 > > [section1] > options=console=vga,com1 com1=57600 loglvl=all noreboot > kernel=vmlinuz-3.0.31-0.4-xen [domain 0 command line options] > ramdisk=initrd-3.0.31-0.4-xen > xsm= > dtb=devtree.dtb > binary=vmlinuz-guest domu-kernel > binary=ramdisk-domA.img domA-ramdisk > binary=ramdisk-domB.img domB-ramdisk > > The chosen node in the DT would look like: > > chosen { > domU1 { > compatible = "xen,domain"; > #address-cells = <0x2>; > #size-cells = <0x1>; > memory = <0 0x8000000>; > cpus = <2>; > > module@1 { > compatible = "multiboot,kernel", "multiboot,module"; > uefi,binary = "domu-kernel"; > bootargs = "console=ttyAMA0 init=/bin/sh"; > }; > > module@2 { > compatible = "multiboot,ramdisk", "multiboot,module"; > uefi,binary = "domA-ramdisk"; > }; > }; > > domU2 { > compatible = "xen,domain"; > #address-cells = <0x3>; > #size-cells = <0x1>; > memory = <0 0x20000000>; > cpus = <3>; > > module@1 { > compatible = "multiboot,kernel", "multiboot,module"; > uefi,binary = "domu-kernel"; > bootargs = "console=ttyAMA0 init=/bin/sh"; > }; > > module@2 { > compatible = "multiboot,ramdisk", "multiboot,module"; > uefi,binary = "domA-ramdisk"; > }; > }; > }; > > With this approach, the change is quite minimal to move between an classic > U-boot boot and EFI boot. Great idea! I think it is good to try to reuse Device Tree, and using it as configuration is well aligned with other projects too (e.g. Zephyr). There are a few options for the bindings. These are some ideas. If we are just going to specify a filename and a reference with the "binary" key=value pair, then we could get rid of it entirely and just write the filename directly in device tree: domU1 { compatible = "xen,domain"; #address-cells = <0x2>; #size-cells = <0x1>; memory = <0 0x8000000>; cpus = <2>; module@1 { compatible = "multiboot,kernel", "multiboot,module"; uefi,binary = "vmlinuz-guest"; bootargs = "console=ttyAMA0 init=/bin/sh"; }; }; Then we don't even need the binary key=value pair, and especially the device tree becomes "self contained" as in we don't need to resolve the reference to "binary=value ref" to understand it. (Also worth noting as inspiration the HyperLaunch binding that is using the "mb-index" property as index in the multiboot module chain. Not directly applicable, but interesting.) --8323329-792418537-1631062279=:14059-- From xen-devel-bounces@lists.xenproject.org Wed Sep 08 04:02:56 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Sep 2021 04:02:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.181428.328520 (Exim 4.92) (envelope-from ) id 1mNonL-0006ep-2F; Wed, 08 Sep 2021 04:02:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 181428.328520; Wed, 08 Sep 2021 04:02:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNonK-0006ei-U1; Wed, 08 Sep 2021 04:02:42 +0000 Received: by outflank-mailman (input) for mailman id 181428; Wed, 08 Sep 2021 04:02:41 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNonJ-0006eY-P4; Wed, 08 Sep 2021 04:02:41 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNonJ-0002lK-K6; Wed, 08 Sep 2021 04:02:41 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNonJ-0005vE-6X; Wed, 08 Sep 2021 04:02:41 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mNonJ-0003do-5j; Wed, 08 Sep 2021 04:02:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=31yRpftZznTCZf6mr6Q6bH05CMy10lku+SaZLPWF7OI=; b=4ZG8erYYquhmBgiCaibvBoSuXi TjlTypTQeZSkUDCNdf9DyAmT/qGL2elhXesvvt4f2XD1qOkqnGsTfA+sulU0zRG9/4qjK8SvZPVtM xPfm3N67HP/Rbh1gKQFvQD7anQ0IcJVzSnYxNjPKL3DZ72jzxWl9CpNC0MHl5z1b+m3A=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 164876: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-i386-xl-qemut-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-intel:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-examine:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-debianhvm-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-ws16-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:regression linux-linus:test-amd64-i386-xl:xen-install:fail:regression linux-linus:test-amd64-i386-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-i386-xl-raw:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-xl-pvshim:xen-install:fail:regression linux-linus:test-amd64-i386-freebsd10-i386:xen-install:fail:regression linux-linus:test-amd64-i386-xl-shadow:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-ovmf-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemuu-win7-amd64:xen-install:fail:regression linux-linus:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-install:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/src_host:fail:regression linux-linus:test-amd64-i386-libvirt-pair:xen-install/dst_host:fail:regression linux-linus:test-amd64-coresched-i386-xl:xen-install:fail:regression linux-linus:test-arm64-arm64-xl-seattle:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-thunderx:debian-fixup:fail:regression linux-linus:test-arm64-arm64-xl-credit1:guest-start:fail:regression linux-linus:test-arm64-arm64-libvirt-xsm:debian-fixup:fail:regression linux-linus:test-arm64-arm64-xl:debian-fixup:fail:regression linux-linus:test-arm64-arm64-xl-credit2:debian-fixup:fail:regression linux-linus:test-arm64-arm64-xl-xsm:debian-fixup:fail:regression linux-linus:test-arm64-arm64-examine:reboot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=4b93c544e90e2b28326182d31ee008eb80e02074 X-Osstest-Versions-That: linux=deacdb3e3979979016fcd0ffd518c320a62ad166 From: osstest service owner Date: Wed, 08 Sep 2021 04:02:41 +0000 flight 164876 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/164876/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemut-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-intel 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-examine 6 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl 7 xen-install fail REGR. vs. 152332 test-amd64-i386-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-i386-xl-raw 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-pvshim 7 xen-install fail REGR. vs. 152332 test-amd64-i386-freebsd10-i386 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-shadow 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-ovmf-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemuu-win7-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 7 xen-install fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 10 xen-install/src_host fail REGR. vs. 152332 test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail REGR. vs. 152332 test-amd64-coresched-i386-xl 7 xen-install fail REGR. vs. 152332 test-arm64-arm64-xl-seattle 8 xen-boot fail REGR. vs. 152332 test-arm64-arm64-xl-thunderx 13 debian-fixup fail REGR. vs. 152332 test-arm64-arm64-xl-credit1 14 guest-start fail REGR. vs. 152332 test-arm64-arm64-libvirt-xsm 13 debian-fixup fail REGR. vs. 152332 test-arm64-arm64-xl 13 debian-fixup fail REGR. vs. 152332 test-arm64-arm64-xl-credit2 13 debian-fixup fail REGR. vs. 152332 test-arm64-arm64-xl-xsm 13 debian-fixup fail REGR. vs. 152332 test-arm64-arm64-examine 8 reboot fail REGR. vs. 152332 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 152332 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 152332 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 152332 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 152332 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 152332 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 152332 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 152332 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: linux 4b93c544e90e2b28326182d31ee008eb80e02074 baseline version: linux deacdb3e3979979016fcd0ffd518c320a62ad166 Last test of basis 152332 2020-07-31 19:41:23 Z 403 days Failing since 152366 2020-08-01 20:49:34 Z 402 days 700 attempts Testing same since 164865 2021-09-06 21:40:45 Z 1 days 3 attempts ------------------------------------------------------------ 7221 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl fail test-armhf-armhf-xl pass test-amd64-i386-xl fail test-amd64-coresched-i386-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm fail test-amd64-i386-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm fail test-amd64-i386-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 fail test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine pass test-arm64-arm64-examine fail test-armhf-armhf-examine pass test-amd64-i386-examine fail test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel fail test-amd64-i386-qemuu-rhel6hvm-intel fail test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair fail test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow fail test-arm64-arm64-xl-thunderx fail test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2221825 lines long.) From xen-devel-bounces@lists.xenproject.org Wed Sep 08 04:48:54 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Sep 2021 04:48:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.181377.328534 (Exim 4.92) (envelope-from ) id 1mNpVw-0002y0-MS; Wed, 08 Sep 2021 04:48:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 181377.328534; Wed, 08 Sep 2021 04:48:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNpVw-0002xt-JB; Wed, 08 Sep 2021 04:48:48 +0000 Received: by outflank-mailman (input) for mailman id 181377; Tue, 07 Sep 2021 22:41:01 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNjm1-0004gR-8e for xen-devel@lists.xenproject.org; Tue, 07 Sep 2021 22:41:01 +0000 Received: from EUR03-AM5-obe.outbound.protection.outlook.com (unknown [40.107.3.66]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id a8f1d8b2-102c-11ec-b131-12813bfff9fa; Tue, 07 Sep 2021 22:40:54 +0000 (UTC) Received: from DB7PR03MB4523.eurprd03.prod.outlook.com (2603:10a6:10:19::27) by DB9PR03MB7514.eurprd03.prod.outlook.com (2603:10a6:10:22a::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.21; Tue, 7 Sep 2021 22:40:52 +0000 Received: from DB7PR03MB4523.eurprd03.prod.outlook.com ([fe80::dc6c:815b:2062:d1f1]) by DB7PR03MB4523.eurprd03.prod.outlook.com ([fe80::dc6c:815b:2062:d1f1%7]) with mapi id 15.20.4478.025; Tue, 7 Sep 2021 22:40:52 +0000 Received: from [172.27.1.65] (50.195.82.171) by BL1PR13CA0065.namprd13.prod.outlook.com (2603:10b6:208:2b8::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.4 via Frontend Transport; Tue, 7 Sep 2021 22:40:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a8f1d8b2-102c-11ec-b131-12813bfff9fa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DAqhCa6P0makIMugGEUYGLBCWQpqrwKqcSWDZXWR5Zv1MJ+rnA6epSTlzihwMcQgTa6NhIKAeXPDLPRnMAuyhWZ2cVG0pECvQuhadCYVB9ZFMAyimacuq6u1595NK1ehS3UpNTF7ipaAF75scZvI9WPfjRWxD/rSiqW3XxIOtMQjfeDggZFpTOy/tISGPugkfmeOhWJUau2wmFqhzXCkNc3ibtw00+BfbZztU5Ojj27jGHRxCYnbP28S7h80ap9UwSnn7TDuMME49cXvu4bJi0i6YOsVGiDXS6ssHg4/LDtHrUlmOHMeAWfilMNBcp2KUIuwAipqYwlkkEzbtDHVVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=xZGokp59XTygdvR/QbsSyJCnfBZE6dBkB3sePL70M8Y=; b=gEjK7eH/kgWoJX5b3YysxljI8unsHWGGy4UnqYvBSdHoq/aeXA1Tb8j7eiWATfYnj4ZQIxsEtm1yoMgdQm4vDlRfkeP0Anj3MIYJI/MGDR3wCDhBEAlYzVr9pUIwRyG8xzZavGj4w2kYhkcjPzr5eplXVRAaMiHU1f6/ffjuBOJDsg9p5PjUtDlVLndKSPkoF2KK/wOO6yzB9IfkuFhZZ4AIIOa2/lt+QgL3AXV3FjRGe0kNPOeqDPuw4iDPkTmJDutHvi6jEmBjakvhq4LwgoyIVYuih7znCaHbdzQ9o9D7EuxyA8VPW099mt1AXJ8NFXJ4NUVcAECUC0E+ob1W6w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=seco.com; dmarc=pass action=none header.from=seco.com; dkim=pass header.d=seco.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=secospa.onmicrosoft.com; s=selector2-secospa-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xZGokp59XTygdvR/QbsSyJCnfBZE6dBkB3sePL70M8Y=; b=ntqrV9aXJaPc48uCaAaZEd54r7EUT1nc8DTiLlvYYTIAstDY3v3rGdBX3ntOQDqk/qLNgh3kOKwOIZYxsvDZ4qSAE/HPUM9rualziEDS5Mj9CkSRVqJR2Lqn9tRoRXgmQLm4OzbFHyvbgmnmMKl/Avsr2KX+RDnMOJTBheEusnQ= Authentication-Results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=seco.com; From: Sean Anderson Subject: Re: [PATCH v2 4/5] mm/page_alloc: place pages to tail in __free_pages_core() To: david@redhat.com Cc: akpm@linux-foundation.org, alexander.h.duyck@linux.intel.com, dave.hansen@intel.com, haiyangz@microsoft.com, kys@microsoft.com, linux-acpi@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, mgorman@techsingularity.net, mhocko@kernel.org, mhocko@suse.com, osalvador@suse.de, pankaj.gupta.linux@gmail.com, richard.weiyang@linux.alibaba.com, rppt@kernel.org, sthemmin@microsoft.com, vbabka@suse.cz, wei.liu@kernel.org, willy@infradead.org, xen-devel@lists.xenproject.org References: <20201005121534.15649-5-david@redhat.com> Message-ID: Date: Tue, 7 Sep 2021 18:40:45 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 In-Reply-To: <20201005121534.15649-5-david@redhat.com> Content-Type: multipart/mixed; boundary="------------6DD34436CA52906803239DD3" Content-Language: en-US X-ClientProxiedBy: BL1PR13CA0065.namprd13.prod.outlook.com (2603:10b6:208:2b8::10) To DB7PR03MB4523.eurprd03.prod.outlook.com (2603:10a6:10:19::27) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 50993f61-2ff4-4447-4c9d-08d972508b91 X-MS-TrafficTypeDiagnostic: DB9PR03MB7514: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:5516; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6bmNaIYFblconuOojrGI+fgqGKtzuEcfNh1P7ZYwwHPhWTQpDkdq2BKUqUiq+wv9r4uJFNHtp/hQ2EYXMkP+JmXQgBy3/smNRZpBFCRIArncvtgNeSyjBV2lj6ymaHY59CSU1PNFIwFtLzk0lCRU1hCSCoTXRJk0tHBs57GF+dExsf3LnQG+PS1Ylsl5au/sm7BDSOdkdwkivwSR90a+W0D9zKSVPTDfUdL0Yad6dPGvjKw36qvzlMqvCmpmr3eXf9yFZzznUHs+NIzfc1fKcHlahFmoJpUZpqgfkLDNXT1DJ919ZghAAgYgJoJ3VvsaOBPxqhIMJwm5iqHgjJuHm6FRsIqG8Ot5MCPbV5Hso/uaG3OYRAIGl8n5q/If9MGhX1Ilsojs6c+xajqdx0YXgd2LCqHl4ukxM72+YmCom9RVECq9K8N0vp5a722MbfBqxx9Flr6B679pr6HuKjJnlrA/3ZyxS0yyh3saGqJe8eWRvGAccZmG03f3VO0cmHhcHDTEvSBamzoaArOtvOMVplU79/fUcGk4Zm3oFB794f4yfrB1WcB4dMFK8gtPn1jeNnC6kGQauYr7f1WBcDjoSVadIWW9DOk4MEvuXR9zv6J7dxMX0q7P4YtKgZ4qcGm19OwkLCi4YJpPSo+mANAuojC/nyIcWpHprM8fyk9D9LCmWOzDpZsfPEw9PL0YOKFGjzknUldqnLL5BGKpPloS16IcqMoS/hXpiqgUd8txqbN7r1hkmsL0vXjpI9dyoltHSuzeXorCHvddK7uyBfgWBg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB7PR03MB4523.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(376002)(396003)(346002)(39850400004)(136003)(36756003)(86362001)(316002)(16576012)(38100700002)(38350700002)(66556008)(66476007)(66616009)(66946007)(478600001)(6666004)(235185007)(2906002)(5660300002)(6486002)(31686004)(4326008)(31696002)(52116002)(33964004)(44832011)(186003)(8936002)(8676002)(26005)(7416002)(2616005)(956004)(6916009)(83380400001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QjBwNldVVEh1SkNLQ2tGMFJxK3hhZU9MYzljWkptUXhWUVJvNCtLM21IYU56?= =?utf-8?B?a2xocGtNc1RrRk9ieHRTVzlBL3ovd3hhV2g2RjUzOW03Nnp4SHJURytjRlY5?= =?utf-8?B?aFlSRXBaQmZoVm11WG8rSmovdTZyV3NkZ2RWbVRDRW5xMWNTaTRTSFd1eUZI?= =?utf-8?B?K1lSam1nOENuem1GZGUvRWx6NnNyTVE4TGxOWitpOXJvRTFOY1A1Uzc3bHVr?= =?utf-8?B?OUhPcG5KZzNEeS9HVXJxL1ZBTjNKZ3pFUW1hRUtHdjFwQkk0dUd6NmNyYUR0?= =?utf-8?B?UGNOb1QzWXNlTHo3QzNUcklqU0dFRHBWbytnNlVhei9jcUYvcGhSSk1rNXNu?= =?utf-8?B?dHQ5dm54TFRmWG1rb1VyUitoK1JmbzB3Qk1WOWlSNVlFc01SUlJ4Yy9lUEh5?= =?utf-8?B?SFAwdFh5eXNxdGJCTDlLak5Bd25keHBHR2t0ZmtiR0dpNTQ1THE0STF6QTUv?= =?utf-8?B?ZGM3UG5VL3FDWWdJZzVtOC9GSHFHS0dMbWxXY3I4M1FFNjlIMDB1eUxrZ1VI?= =?utf-8?B?YkdYcGZmbXZFVXJFNFFZL1RMQmtWRkxMbmlld0s1dFo5NjF6Y1IxaUpKZ3pp?= =?utf-8?B?djdKSE9hVEpFaGNnenR6c1Vjd1kyTDYrYndCaVYxSi9RWmx0c3YyMlF0MmU4?= =?utf-8?B?cUZKeGVrdWlDb21CYVVGOVA5cTdLWXNHVzZKb1dVR0t2aUE5bGI3WnhJZk1N?= =?utf-8?B?aTBid2tCZlBpMDJ5eCsrN2hCQkVrNjBXZHNDSGdKZDFOMkgySE9qMUlXQTNj?= =?utf-8?B?ejY0alJxMHhERWJnYVZYWTJoRllDSTFRbGgvY3F3WEgrd1Nrd3VQTkZJV0NM?= =?utf-8?B?SUl0eGFnb3Bsd09EUktDa1pCQXB1ZzZ4cGtxOHpKQkR1OFRRNnlwTjZQTVBi?= =?utf-8?B?UE9tRzdFL2NxV0FlVFhiTTE0eE5vcjNTTUFXSmp1aWVxdEVYK3JIMERQcDRY?= =?utf-8?B?RldteVIxVkJMRWJpMHh6WFh0YlhMSzVKNEdBZVBZWTFnSTVLSWxMTlN0dlg5?= =?utf-8?B?eFdmd1Qrd3pxUTdHQmwxYnlVZFlMZWdMOWgxaWJsVnFFbnozWXBhL2c0d1RY?= =?utf-8?B?S0lsN09ZbzZkM05EWUpWTENyRng3SUtFN0l2MVpkRFFpTU5VWXpTZ0xFbFhU?= =?utf-8?B?OWVySDhDRm5IYU9Fend4dmR6bktzYW9zbDhGbHVWMEtNRlp2NS9Pd1dMbzBZ?= =?utf-8?B?VGh6Z2xFdWRTWEhkWk9URWVSL1FwTWNvb3o3VGZKaU9hUXJncEhITlAxNGV1?= =?utf-8?B?VWdLdElyVFM2Y3lzS05TWCtoSytvMnQrdmlxN3kya2R4alZLS3duc3BUS2xS?= =?utf-8?B?ZDZvTXp5cW5pSmZzUFBTRTM2UkFSc3AyUGp6MW1XR2Y3QVRDdDlSTE5aY0Vl?= =?utf-8?B?ZHhDSWtQaExKeWJQdkJhRzB0dWdsSDllcnZuMldmWWF1VUp6U09Keno3L092?= =?utf-8?B?ampzVksvZU93NFBQVjRYVDZFaHpYTDBiWmlsK1NqenZYOUhkMENaRVM4NkNF?= =?utf-8?B?eFRSM2huUHBmRkU3OGgycFcrZzZoU1JnanhBWnMvRVQ3QUYxVFY1MzdxREhW?= =?utf-8?B?RDN6cjlHN3YydTBFanlaU3lFZGlRc25hS0UxWUJmS0gzR1grTnRWOEZydWZJ?= =?utf-8?B?aFJ5bVYydWo4MThJWFRRRmNjSkc0UjVSWWlLdXVSaGRPbXVNekxvS3lWV2xt?= =?utf-8?B?N0ZXU3d0VG4rb2pjeEUzVXdSK1VQU1NjMXhHVFRISHhZcUxtYkZpNUQ5YXJR?= =?utf-8?Q?/2p/1xiGT+YjllGNPNhQJYGXiglkgHfUWQpcOju?= X-OriginatorOrg: seco.com X-MS-Exchange-CrossTenant-Network-Message-Id: 50993f61-2ff4-4447-4c9d-08d972508b91 X-MS-Exchange-CrossTenant-AuthSource: DB7PR03MB4523.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2021 22:40:51.8348 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bebe97c3-6438-442e-ade3-ff17aa50e733 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 963kxJCamLyZL3NcMwTTnV7hkDQKBTU6kkIK+XGo4TyiE7UZ+7PV4AUwlMxM6/sHYcgpOwKDIvdnc2VpsLrFkA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR03MB7514 --------------6DD34436CA52906803239DD3 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Hi David, This patch breaks booting on my custom Xilinx ZynqMP board. Booting fails just after/during GIC initialization: [ 0.000000] Booting Linux on physical CPU 0x0000000000 [0x410fd034] [ 0.000000] Linux version 5.14.0 (sean@plantagenet) (aarch64-linux-gnu-gcc (Ubuntu 9.3.0-17ubuntu1~20.04) 9.3.0, GNU ld (GNU Binutils for Ubuntu) 2.34) #251 SMP Tue Sep 7 18:11:50 EDT 2021 [ 0.000000] Machine model: xlnx,zynqmp [ 0.000000] earlycon: cdns0 at MMIO 0x00000000ff010000 (options '115200n8') [ 0.000000] printk: bootconsole [cdns0] enabled [ 0.000000] efi: UEFI not found. [ 0.000000] Zone ranges: [ 0.000000] DMA32 [mem 0x0000000000000000-0x00000000ffffffff] [ 0.000000] Normal [mem 0x0000000100000000-0x000000087fffffff] [ 0.000000] Movable zone start for each node [ 0.000000] Early memory node ranges [ 0.000000] node 0: [mem 0x0000000000000000-0x000000007fefffff] [ 0.000000] node 0: [mem 0x0000000800000000-0x000000087fffffff] [ 0.000000] Initmem setup node 0 [mem 0x0000000000000000-0x000000087fffffff] [ 0.000000] On node 0, zone Normal: 256 pages in unavailable ranges [ 0.000000] cma: Reserved 1000 MiB at 0x0000000041400000 [ 0.000000] psci: probing for conduit method from DT. [ 0.000000] psci: PSCIv1.1 detected in firmware. [ 0.000000] psci: Using standard PSCI v0.2 function IDs [ 0.000000] psci: MIGRATE_INFO_TYPE not supported. [ 0.000000] psci: SMC Calling Convention v1.1 [ 0.000000] percpu: Embedded 19 pages/cpu s46752 r0 d31072 u77824 [ 0.000000] Detected VIPT I-cache on CPU0 [ 0.000000] CPU features: detected: ARM erratum 845719 [ 0.000000] Built 1 zonelists, mobility grouping on. Total pages: 1033987 [ 0.000000] Kernel command line: earlycon clk_ignore_unused root=/dev/mmcblk0p2 rootwait rw cma=1000M [ 0.000000] Dentry cache hash table entries: 524288 (order: 10, 4194304 bytes, linear) [ 0.000000] Inode-cache hash table entries: 262144 (order: 9, 2097152 bytes, linear) [ 0.000000] mem auto-init: stack:off, heap alloc:off, heap free:off [ 0.000000] software IO TLB: mapped [mem 0x000000003d400000-0x0000000041400000] (64MB) [ 0.000000] Memory: 3023384K/4193280K available (4288K kernel code, 514K rwdata, 1200K rodata, 896K init, 187K bss, 145896K reserved, 1024000K cma-reserved) [ 0.000000] rcu: Hierarchical RCU implementation. [ 0.000000] rcu: RCU event tracing is enabled. [ 0.000000] rcu: RCU calculated value of scheduler-enlistment delay is 25 jiffies. [ 0.000000] NR_IRQS: 64, nr_irqs: 64, preallocated irqs: 0 [ 0.000000] GIC: Adjusting CPU interface base to 0x00000000f902f000 [ 0.000000] Root IRQ handler: gic_handle_irq [ 0.000000] GIC: Using split EOI/Deactivate mode and I bisected it to this patch. Applying the following patch (for 5.14) fixes booting again: --- mm/page_alloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index eeb3a9cb36bb..d4317392cadb 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -1688,7 +1688,7 @@ void __free_pages_core(struct page *page, unsigned int order) * Bypass PCP and place fresh pages right to the tail, primarily * relevant for memory onlining. */ - __free_pages_ok(page, order, FPI_TO_TAIL | FPI_SKIP_KASAN_POISON); + __free_pages_ok(page, order, FPI_NONE); } #ifdef CONFIG_NUMA -- 2.25.1 I have attached my config; but note that it lacks any storage drivers to make bisecting easier. --Sean --------------6DD34436CA52906803239DD3 Content-Type: text/plain; charset=UTF-8; name=".config" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=".config" IwojIEF1dG9tYXRpY2FsbHkgZ2VuZXJhdGVkIGZpbGU7IERPIE5PVCBFRElULgojIExpbnV4L2Fy bTY0IDUuMTQuMCBLZXJuZWwgQ29uZmlndXJhdGlvbgojCkNPTkZJR19DQ19WRVJTSU9OX1RFWFQ9 ImFhcmNoNjQtbGludXgtZ251LWdjYyAoVWJ1bnR1IDkuMy4wLTE3dWJ1bnR1MX4yMC4wNCkgOS4z LjAiCkNPTkZJR19DQ19JU19HQ0M9eQpDT05GSUdfR0NDX1ZFUlNJT049OTAzMDAKQ09ORklHX0NM QU5HX1ZFUlNJT049MApDT05GSUdfQVNfSVNfR05VPXkKQ09ORklHX0FTX1ZFUlNJT049MjM0MDAK Q09ORklHX0xEX0lTX0JGRD15CkNPTkZJR19MRF9WRVJTSU9OPTIzNDAwCkNPTkZJR19MTERfVkVS U0lPTj0wCkNPTkZJR19DQ19DQU5fTElOSz15CkNPTkZJR19DQ19DQU5fTElOS19TVEFUSUM9eQpD T05GSUdfQ0NfSEFTX0FTTV9HT1RPPXkKQ09ORklHX0NDX0hBU19BU01fSU5MSU5FPXkKQ09ORklH X0NDX0hBU19OT19QUk9GSUxFX0ZOX0FUVFI9eQpDT05GSUdfSVJRX1dPUks9eQpDT05GSUdfQlVJ TERUSU1FX1RBQkxFX1NPUlQ9eQpDT05GSUdfVEhSRUFEX0lORk9fSU5fVEFTSz15CgojCiMgR2Vu ZXJhbCBzZXR1cAojCkNPTkZJR19JTklUX0VOVl9BUkdfTElNSVQ9MzIKIyBDT05GSUdfQ09NUElM RV9URVNUIGlzIG5vdCBzZXQKQ09ORklHX0xPQ0FMVkVSU0lPTj0iIgpDT05GSUdfTE9DQUxWRVJT SU9OX0FVVE89eQpDT05GSUdfQlVJTERfU0FMVD0iIgpDT05GSUdfREVGQVVMVF9JTklUPSIiCkNP TkZJR19ERUZBVUxUX0hPU1ROQU1FPSIobm9uZSkiCkNPTkZJR19TWVNWSVBDPXkKQ09ORklHX1NZ U1ZJUENfU1lTQ1RMPXkKIyBDT05GSUdfV0FUQ0hfUVVFVUUgaXMgbm90IHNldApDT05GSUdfQ1JP U1NfTUVNT1JZX0FUVEFDSD15CiMgQ09ORklHX1VTRUxJQiBpcyBub3Qgc2V0CkNPTkZJR19IQVZF X0FSQ0hfQVVESVRTWVNDQUxMPXkKCiMKIyBJUlEgc3Vic3lzdGVtCiMKQ09ORklHX0dFTkVSSUNf SVJRX1BST0JFPXkKQ09ORklHX0dFTkVSSUNfSVJRX1NIT1c9eQpDT05GSUdfR0VORVJJQ19JUlFf U0hPV19MRVZFTD15CkNPTkZJR19HRU5FUklDX0lSUV9FRkZFQ1RJVkVfQUZGX01BU0s9eQpDT05G SUdfR0VORVJJQ19JUlFfTUlHUkFUSU9OPXkKQ09ORklHX0hBUkRJUlFTX1NXX1JFU0VORD15CkNP TkZJR19JUlFfRE9NQUlOPXkKQ09ORklHX0lSUV9ET01BSU5fSElFUkFSQ0hZPXkKQ09ORklHX0dF TkVSSUNfSVJRX0lQST15CkNPTkZJR19HRU5FUklDX01TSV9JUlE9eQpDT05GSUdfR0VORVJJQ19N U0lfSVJRX0RPTUFJTj15CkNPTkZJR19JUlFfTVNJX0lPTU1VPXkKQ09ORklHX0hBTkRMRV9ET01B SU5fSVJRPXkKQ09ORklHX0lSUV9GT1JDRURfVEhSRUFESU5HPXkKQ09ORklHX1NQQVJTRV9JUlE9 eQojIENPTkZJR19HRU5FUklDX0lSUV9ERUJVR0ZTIGlzIG5vdCBzZXQKIyBlbmQgb2YgSVJRIHN1 YnN5c3RlbQoKQ09ORklHX0dFTkVSSUNfVElNRV9WU1lTQ0FMTD15CkNPTkZJR19HRU5FUklDX0NM T0NLRVZFTlRTPXkKQ09ORklHX0FSQ0hfSEFTX1RJQ0tfQlJPQURDQVNUPXkKQ09ORklHX0dFTkVS SUNfQ0xPQ0tFVkVOVFNfQlJPQURDQVNUPXkKCiMKIyBUaW1lcnMgc3Vic3lzdGVtCiMKQ09ORklH X1RJQ0tfT05FU0hPVD15CkNPTkZJR19OT19IWl9DT01NT049eQojIENPTkZJR19IWl9QRVJJT0RJ QyBpcyBub3Qgc2V0CkNPTkZJR19OT19IWl9JRExFPXkKIyBDT05GSUdfTk9fSFpfRlVMTCBpcyBu b3Qgc2V0CkNPTkZJR19OT19IWj15CkNPTkZJR19ISUdIX1JFU19USU1FUlM9eQojIGVuZCBvZiBU aW1lcnMgc3Vic3lzdGVtCgpDT05GSUdfSEFWRV9FQlBGX0pJVD15CkNPTkZJR19BUkNIX1dBTlRf REVGQVVMVF9CUEZfSklUPXkKCiMKIyBCUEYgc3Vic3lzdGVtCiMKIyBDT05GSUdfQlBGX1NZU0NB TEwgaXMgbm90IHNldAojIGVuZCBvZiBCUEYgc3Vic3lzdGVtCgpDT05GSUdfUFJFRU1QVF9OT05F PXkKIyBDT05GSUdfUFJFRU1QVF9WT0xVTlRBUlkgaXMgbm90IHNldAojIENPTkZJR19QUkVFTVBU IGlzIG5vdCBzZXQKCiMKIyBDUFUvVGFzayB0aW1lIGFuZCBzdGF0cyBhY2NvdW50aW5nCiMKQ09O RklHX1RJQ0tfQ1BVX0FDQ09VTlRJTkc9eQojIENPTkZJR19WSVJUX0NQVV9BQ0NPVU5USU5HX0dF TiBpcyBub3Qgc2V0CiMgQ09ORklHX0lSUV9USU1FX0FDQ09VTlRJTkcgaXMgbm90IHNldApDT05G SUdfQlNEX1BST0NFU1NfQUNDVD15CiMgQ09ORklHX0JTRF9QUk9DRVNTX0FDQ1RfVjMgaXMgbm90 IHNldAojIENPTkZJR19QU0kgaXMgbm90IHNldAojIGVuZCBvZiBDUFUvVGFzayB0aW1lIGFuZCBz dGF0cyBhY2NvdW50aW5nCgpDT05GSUdfQ1BVX0lTT0xBVElPTj15CgojCiMgUkNVIFN1YnN5c3Rl bQojCkNPTkZJR19UUkVFX1JDVT15CiMgQ09ORklHX1JDVV9FWFBFUlQgaXMgbm90IHNldApDT05G SUdfU1JDVT15CkNPTkZJR19UUkVFX1NSQ1U9eQpDT05GSUdfUkNVX1NUQUxMX0NPTU1PTj15CkNP TkZJR19SQ1VfTkVFRF9TRUdDQkxJU1Q9eQojIGVuZCBvZiBSQ1UgU3Vic3lzdGVtCgpDT05GSUdf SUtDT05GSUc9eQpDT05GSUdfSUtDT05GSUdfUFJPQz15CiMgQ09ORklHX0lLSEVBREVSUyBpcyBu b3Qgc2V0CkNPTkZJR19MT0dfQlVGX1NISUZUPTE2CkNPTkZJR19MT0dfQ1BVX01BWF9CVUZfU0hJ RlQ9MTIKQ09ORklHX1BSSU5US19TQUZFX0xPR19CVUZfU0hJRlQ9MTMKQ09ORklHX0dFTkVSSUNf U0NIRURfQ0xPQ0s9eQoKIwojIFNjaGVkdWxlciBmZWF0dXJlcwojCiMgZW5kIG9mIFNjaGVkdWxl ciBmZWF0dXJlcwoKQ09ORklHX0FSQ0hfU1VQUE9SVFNfTlVNQV9CQUxBTkNJTkc9eQpDT05GSUdf Q0NfSEFTX0lOVDEyOD15CkNPTkZJR19BUkNIX1NVUFBPUlRTX0lOVDEyOD15CkNPTkZJR19DR1JP VVBTPXkKIyBDT05GSUdfTUVNQ0cgaXMgbm90IHNldAojIENPTkZJR19DR1JPVVBfU0NIRUQgaXMg bm90IHNldAojIENPTkZJR19DR1JPVVBfUElEUyBpcyBub3Qgc2V0CiMgQ09ORklHX0NHUk9VUF9S RE1BIGlzIG5vdCBzZXQKIyBDT05GSUdfQ0dST1VQX0ZSRUVaRVIgaXMgbm90IHNldAojIENPTkZJ R19DR1JPVVBfSFVHRVRMQiBpcyBub3Qgc2V0CiMgQ09ORklHX0NQVVNFVFMgaXMgbm90IHNldAoj IENPTkZJR19DR1JPVVBfREVWSUNFIGlzIG5vdCBzZXQKIyBDT05GSUdfQ0dST1VQX0NQVUFDQ1Qg aXMgbm90IHNldAojIENPTkZJR19DR1JPVVBfUEVSRiBpcyBub3Qgc2V0CiMgQ09ORklHX0NHUk9V UF9NSVNDIGlzIG5vdCBzZXQKIyBDT05GSUdfQ0dST1VQX0RFQlVHIGlzIG5vdCBzZXQKIyBDT05G SUdfTkFNRVNQQUNFUyBpcyBub3Qgc2V0CiMgQ09ORklHX0NIRUNLUE9JTlRfUkVTVE9SRSBpcyBu b3Qgc2V0CiMgQ09ORklHX1NDSEVEX0FVVE9HUk9VUCBpcyBub3Qgc2V0CiMgQ09ORklHX1NZU0ZT X0RFUFJFQ0FURUQgaXMgbm90IHNldAojIENPTkZJR19SRUxBWSBpcyBub3Qgc2V0CkNPTkZJR19C TEtfREVWX0lOSVRSRD15CkNPTkZJR19JTklUUkFNRlNfU09VUkNFPSIiCkNPTkZJR19SRF9HWklQ PXkKQ09ORklHX1JEX0JaSVAyPXkKQ09ORklHX1JEX0xaTUE9eQpDT05GSUdfUkRfWFo9eQpDT05G SUdfUkRfTFpPPXkKQ09ORklHX1JEX0xaND15CkNPTkZJR19SRF9aU1REPXkKIyBDT05GSUdfQk9P VF9DT05GSUcgaXMgbm90IHNldApDT05GSUdfQ0NfT1BUSU1JWkVfRk9SX1BFUkZPUk1BTkNFPXkK IyBDT05GSUdfQ0NfT1BUSU1JWkVfRk9SX1NJWkUgaXMgbm90IHNldApDT05GSUdfTERfT1JQSEFO X1dBUk49eQpDT05GSUdfU1lTQ1RMPXkKQ09ORklHX0hBVkVfVUlEMTY9eQpDT05GSUdfU1lTQ1RM X0VYQ0VQVElPTl9UUkFDRT15CkNPTkZJR19FWFBFUlQ9eQpDT05GSUdfVUlEMTY9eQpDT05GSUdf TVVMVElVU0VSPXkKIyBDT05GSUdfU0dFVE1BU0tfU1lTQ0FMTCBpcyBub3Qgc2V0CkNPTkZJR19T WVNGU19TWVNDQUxMPXkKQ09ORklHX0ZIQU5ETEU9eQpDT05GSUdfUE9TSVhfVElNRVJTPXkKQ09O RklHX1BSSU5USz15CkNPTkZJR19QUklOVEtfTk1JPXkKQ09ORklHX0JVRz15CkNPTkZJR19FTEZf Q09SRT15CkNPTkZJR19CQVNFX0ZVTEw9eQpDT05GSUdfRlVURVg9eQpDT05GSUdfRlVURVhfUEk9 eQpDT05GSUdfSEFWRV9GVVRFWF9DTVBYQ0hHPXkKQ09ORklHX0VQT0xMPXkKQ09ORklHX1NJR05B TEZEPXkKQ09ORklHX1RJTUVSRkQ9eQpDT05GSUdfRVZFTlRGRD15CkNPTkZJR19TSE1FTT15CkNP TkZJR19BSU89eQpDT05GSUdfSU9fVVJJTkc9eQpDT05GSUdfQURWSVNFX1NZU0NBTExTPXkKQ09O RklHX01FTUJBUlJJRVI9eQpDT05GSUdfS0FMTFNZTVM9eQojIENPTkZJR19LQUxMU1lNU19BTEwg aXMgbm90IHNldApDT05GSUdfS0FMTFNZTVNfQkFTRV9SRUxBVElWRT15CiMgQ09ORklHX1VTRVJG QVVMVEZEIGlzIG5vdCBzZXQKQ09ORklHX0FSQ0hfSEFTX01FTUJBUlJJRVJfU1lOQ19DT1JFPXkK IyBDT05GSUdfS0NNUCBpcyBub3Qgc2V0CkNPTkZJR19SU0VRPXkKIyBDT05GSUdfREVCVUdfUlNF USBpcyBub3Qgc2V0CkNPTkZJR19FTUJFRERFRD15CkNPTkZJR19IQVZFX1BFUkZfRVZFTlRTPXkK IyBDT05GSUdfUEMxMDQgaXMgbm90IHNldAoKIwojIEtlcm5lbCBQZXJmb3JtYW5jZSBFdmVudHMg QW5kIENvdW50ZXJzCiMKQ09ORklHX1BFUkZfRVZFTlRTPXkKIyBDT05GSUdfREVCVUdfUEVSRl9V U0VfVk1BTExPQyBpcyBub3Qgc2V0CiMgZW5kIG9mIEtlcm5lbCBQZXJmb3JtYW5jZSBFdmVudHMg QW5kIENvdW50ZXJzCgpDT05GSUdfVk1fRVZFTlRfQ09VTlRFUlM9eQojIENPTkZJR19DT01QQVRf QlJLIGlzIG5vdCBzZXQKQ09ORklHX1NMQUI9eQojIENPTkZJR19TTFVCIGlzIG5vdCBzZXQKIyBD T05GSUdfU0xPQiBpcyBub3Qgc2V0CkNPTkZJR19TTEFCX01FUkdFX0RFRkFVTFQ9eQojIENPTkZJ R19TTEFCX0ZSRUVMSVNUX1JBTkRPTSBpcyBub3Qgc2V0CiMgQ09ORklHX1NMQUJfRlJFRUxJU1Rf SEFSREVORUQgaXMgbm90IHNldAojIENPTkZJR19TSFVGRkxFX1BBR0VfQUxMT0NBVE9SIGlzIG5v dCBzZXQKQ09ORklHX1BST0ZJTElORz15CiMgZW5kIG9mIEdlbmVyYWwgc2V0dXAKCkNPTkZJR19B Uk02ND15CkNPTkZJR182NEJJVD15CkNPTkZJR19NTVU9eQpDT05GSUdfQVJNNjRfUEFHRV9TSElG VD0xMgpDT05GSUdfQVJNNjRfQ09OVF9QVEVfU0hJRlQ9NApDT05GSUdfQVJNNjRfQ09OVF9QTURf U0hJRlQ9NApDT05GSUdfQVJDSF9NTUFQX1JORF9CSVRTX01JTj0xOApDT05GSUdfQVJDSF9NTUFQ X1JORF9CSVRTX01BWD0yNApDT05GSUdfQVJDSF9NTUFQX1JORF9DT01QQVRfQklUU19NSU49MTEK Q09ORklHX0FSQ0hfTU1BUF9STkRfQ09NUEFUX0JJVFNfTUFYPTE2CkNPTkZJR19OT19JT1BPUlRf TUFQPXkKQ09ORklHX1NUQUNLVFJBQ0VfU1VQUE9SVD15CkNPTkZJR19JTExFR0FMX1BPSU5URVJf VkFMVUU9MHhkZWFkMDAwMDAwMDAwMDAwCkNPTkZJR19MT0NLREVQX1NVUFBPUlQ9eQpDT05GSUdf VFJBQ0VfSVJRRkxBR1NfU1VQUE9SVD15CkNPTkZJR19HRU5FUklDX0JVRz15CkNPTkZJR19HRU5F UklDX0JVR19SRUxBVElWRV9QT0lOVEVSUz15CkNPTkZJR19HRU5FUklDX0hXRUlHSFQ9eQpDT05G SUdfR0VORVJJQ19DU1VNPXkKQ09ORklHX0dFTkVSSUNfQ0FMSUJSQVRFX0RFTEFZPXkKQ09ORklH X0FSQ0hfTUhQX01FTU1BUF9PTl9NRU1PUllfRU5BQkxFPXkKQ09ORklHX1NNUD15CkNPTkZJR19L RVJORUxfTU9ERV9ORU9OPXkKQ09ORklHX0ZJWF9FQVJMWUNPTl9NRU09eQpDT05GSUdfUEdUQUJM RV9MRVZFTFM9MwpDT05GSUdfQVJDSF9TVVBQT1JUU19VUFJPQkVTPXkKQ09ORklHX0FSQ0hfUFJP Q19LQ09SRV9URVhUPXkKCiMKIyBQbGF0Zm9ybSBzZWxlY3Rpb24KIwojIENPTkZJR19BUkNIX0FD VElPTlMgaXMgbm90IHNldAojIENPTkZJR19BUkNIX1NVTlhJIGlzIG5vdCBzZXQKIyBDT05GSUdf QVJDSF9BTFBJTkUgaXMgbm90IHNldAojIENPTkZJR19BUkNIX0FQUExFIGlzIG5vdCBzZXQKIyBD T05GSUdfQVJDSF9CQ00yODM1IGlzIG5vdCBzZXQKIyBDT05GSUdfQVJDSF9CQ000OTA4IGlzIG5v dCBzZXQKIyBDT05GSUdfQVJDSF9CQ01fSVBST0MgaXMgbm90IHNldAojIENPTkZJR19BUkNIX0JF UkxJTiBpcyBub3Qgc2V0CiMgQ09ORklHX0FSQ0hfQklUTUFJTiBpcyBub3Qgc2V0CiMgQ09ORklH X0FSQ0hfQlJDTVNUQiBpcyBub3Qgc2V0CiMgQ09ORklHX0FSQ0hfRVhZTk9TIGlzIG5vdCBzZXQK IyBDT05GSUdfQVJDSF9TUEFSWDUgaXMgbm90IHNldAojIENPTkZJR19BUkNIX0szIGlzIG5vdCBz ZXQKIyBDT05GSUdfQVJDSF9MQVlFUlNDQVBFIGlzIG5vdCBzZXQKIyBDT05GSUdfQVJDSF9MRzFL IGlzIG5vdCBzZXQKIyBDT05GSUdfQVJDSF9ISVNJIGlzIG5vdCBzZXQKIyBDT05GSUdfQVJDSF9L RUVNQkFZIGlzIG5vdCBzZXQKIyBDT05GSUdfQVJDSF9NRURJQVRFSyBpcyBub3Qgc2V0CiMgQ09O RklHX0FSQ0hfTUVTT04gaXMgbm90IHNldAojIENPTkZJR19BUkNIX01WRUJVIGlzIG5vdCBzZXQK IyBDT05GSUdfQVJDSF9NWEMgaXMgbm90IHNldAojIENPTkZJR19BUkNIX1FDT00gaXMgbm90IHNl dAojIENPTkZJR19BUkNIX1JFQUxURUsgaXMgbm90IHNldAojIENPTkZJR19BUkNIX1JFTkVTQVMg aXMgbm90IHNldAojIENPTkZJR19BUkNIX1JPQ0tDSElQIGlzIG5vdCBzZXQKIyBDT05GSUdfQVJD SF9TMzIgaXMgbm90IHNldAojIENPTkZJR19BUkNIX1NFQVRUTEUgaXMgbm90IHNldAojIENPTkZJ R19BUkNIX0lOVEVMX1NPQ0ZQR0EgaXMgbm90IHNldAojIENPTkZJR19BUkNIX1NZTlFVQUNFUiBp cyBub3Qgc2V0CiMgQ09ORklHX0FSQ0hfVEVHUkEgaXMgbm90IHNldAojIENPTkZJR19BUkNIX1NQ UkQgaXMgbm90IHNldAojIENPTkZJR19BUkNIX1RIVU5ERVIgaXMgbm90IHNldAojIENPTkZJR19B UkNIX1RIVU5ERVIyIGlzIG5vdCBzZXQKIyBDT05GSUdfQVJDSF9VTklQSElFUiBpcyBub3Qgc2V0 CiMgQ09ORklHX0FSQ0hfVkVYUFJFU1MgaXMgbm90IHNldAojIENPTkZJR19BUkNIX1ZJU0NPTlRJ IGlzIG5vdCBzZXQKIyBDT05GSUdfQVJDSF9YR0VORSBpcyBub3Qgc2V0CkNPTkZJR19BUkNIX1pZ TlFNUD15CiMgZW5kIG9mIFBsYXRmb3JtIHNlbGVjdGlvbgoKIwojIEtlcm5lbCBGZWF0dXJlcwoj CgojCiMgQVJNIGVycmF0YSB3b3JrYXJvdW5kcyB2aWEgdGhlIGFsdGVybmF0aXZlcyBmcmFtZXdv cmsKIwpDT05GSUdfQVJNNjRfV09SS0FST1VORF9DTEVBTl9DQUNIRT15CkNPTkZJR19BUk02NF9F UlJBVFVNXzgyNjMxOT15CkNPTkZJR19BUk02NF9FUlJBVFVNXzgyNzMxOT15CkNPTkZJR19BUk02 NF9FUlJBVFVNXzgyNDA2OT15CkNPTkZJR19BUk02NF9FUlJBVFVNXzgxOTQ3Mj15CkNPTkZJR19B Uk02NF9FUlJBVFVNXzgzMjA3NT15CkNPTkZJR19BUk02NF9FUlJBVFVNXzg0NTcxOT15CkNPTkZJ R19BUk02NF9FUlJBVFVNXzg0MzQxOT15CkNPTkZJR19BUk02NF9MRF9IQVNfRklYX0VSUkFUVU1f ODQzNDE5PXkKQ09ORklHX0FSTTY0X0VSUkFUVU1fMTAyNDcxOD15CkNPTkZJR19BUk02NF9FUlJB VFVNXzE0MTgwNDA9eQpDT05GSUdfQVJNNjRfV09SS0FST1VORF9TUEVDVUxBVElWRV9BVD15CkNP TkZJR19BUk02NF9FUlJBVFVNXzExNjU1MjI9eQpDT05GSUdfQVJNNjRfRVJSQVRVTV8xMzE5MzY3 PXkKQ09ORklHX0FSTTY0X0VSUkFUVU1fMTUzMDkyMz15CkNPTkZJR19BUk02NF9XT1JLQVJPVU5E X1JFUEVBVF9UTEJJPXkKQ09ORklHX0FSTTY0X0VSUkFUVU1fMTI4NjgwNz15CkNPTkZJR19BUk02 NF9FUlJBVFVNXzE0NjMyMjU9eQpDT05GSUdfQVJNNjRfRVJSQVRVTV8xNTQyNDE5PXkKQ09ORklH X0FSTTY0X0VSUkFUVU1fMTUwODQxMj15CkNPTkZJR19DQVZJVU1fRVJSQVRVTV8yMjM3NT15CkNP TkZJR19DQVZJVU1fRVJSQVRVTV8yMzE1ND15CkNPTkZJR19DQVZJVU1fRVJSQVRVTV8yNzQ1Nj15 CkNPTkZJR19DQVZJVU1fRVJSQVRVTV8zMDExNT15CkNPTkZJR19DQVZJVU1fVFgyX0VSUkFUVU1f MjE5PXkKQ09ORklHX0ZVSklUU1VfRVJSQVRVTV8wMTAwMDE9eQpDT05GSUdfSElTSUxJQ09OX0VS UkFUVU1fMTYxNjAwODAyPXkKQ09ORklHX1FDT01fRkFMS09SX0VSUkFUVU1fMTAwMz15CkNPTkZJ R19RQ09NX0ZBTEtPUl9FUlJBVFVNXzEwMDk9eQpDT05GSUdfUUNPTV9RREYyNDAwX0VSUkFUVU1f MDA2NT15CkNPTkZJR19RQ09NX0ZBTEtPUl9FUlJBVFVNX0UxMDQxPXkKQ09ORklHX05WSURJQV9D QVJNRUxfQ05QX0VSUkFUVU09eQpDT05GSUdfU09DSU9ORVhUX1NZTlFVQUNFUl9QUkVJVFM9eQoj IGVuZCBvZiBBUk0gZXJyYXRhIHdvcmthcm91bmRzIHZpYSB0aGUgYWx0ZXJuYXRpdmVzIGZyYW1l d29yawoKQ09ORklHX0FSTTY0XzRLX1BBR0VTPXkKIyBDT05GSUdfQVJNNjRfMTZLX1BBR0VTIGlz IG5vdCBzZXQKIyBDT05GSUdfQVJNNjRfNjRLX1BBR0VTIGlzIG5vdCBzZXQKQ09ORklHX0FSTTY0 X1ZBX0JJVFNfMzk9eQojIENPTkZJR19BUk02NF9WQV9CSVRTXzQ4IGlzIG5vdCBzZXQKQ09ORklH X0FSTTY0X1ZBX0JJVFM9MzkKQ09ORklHX0FSTTY0X1BBX0JJVFNfNDg9eQpDT05GSUdfQVJNNjRf UEFfQklUUz00OAojIENPTkZJR19DUFVfQklHX0VORElBTiBpcyBub3Qgc2V0CkNPTkZJR19DUFVf TElUVExFX0VORElBTj15CiMgQ09ORklHX1NDSEVEX01DIGlzIG5vdCBzZXQKIyBDT05GSUdfU0NI RURfU01UIGlzIG5vdCBzZXQKQ09ORklHX05SX0NQVVM9NApDT05GSUdfSE9UUExVR19DUFU9eQoj IENPTkZJR19OVU1BIGlzIG5vdCBzZXQKIyBDT05GSUdfSFpfMTAwIGlzIG5vdCBzZXQKQ09ORklH X0haXzI1MD15CiMgQ09ORklHX0haXzMwMCBpcyBub3Qgc2V0CiMgQ09ORklHX0haXzEwMDAgaXMg bm90IHNldApDT05GSUdfSFo9MjUwCkNPTkZJR19TQ0hFRF9IUlRJQ0s9eQpDT05GSUdfQVJDSF9T UEFSU0VNRU1fRU5BQkxFPXkKQ09ORklHX0hXX1BFUkZfRVZFTlRTPXkKQ09ORklHX0FSQ0hfSEFT X0ZJTFRFUl9QR1BST1Q9eQojIENPTkZJR19QQVJBVklSVCBpcyBub3Qgc2V0CiMgQ09ORklHX1BB UkFWSVJUX1RJTUVfQUNDT1VOVElORyBpcyBub3Qgc2V0CiMgQ09ORklHX0tFWEVDIGlzIG5vdCBz ZXQKIyBDT05GSUdfS0VYRUNfRklMRSBpcyBub3Qgc2V0CiMgQ09ORklHX0NSQVNIX0RVTVAgaXMg bm90IHNldAojIENPTkZJR19YRU4gaXMgbm90IHNldApDT05GSUdfRk9SQ0VfTUFYX1pPTkVPUkRF Uj0xMQpDT05GSUdfVU5NQVBfS0VSTkVMX0FUX0VMMD15CkNPTkZJR19ST0RBVEFfRlVMTF9ERUZB VUxUX0VOQUJMRUQ9eQojIENPTkZJR19BUk02NF9TV19UVEJSMF9QQU4gaXMgbm90IHNldApDT05G SUdfQVJNNjRfVEFHR0VEX0FERFJfQUJJPXkKQ09ORklHX0NPTVBBVD15CkNPTkZJR19LVVNFUl9I RUxQRVJTPXkKIyBDT05GSUdfQVJNVjhfREVQUkVDQVRFRCBpcyBub3Qgc2V0CgojCiMgQVJNdjgu MSBhcmNoaXRlY3R1cmFsIGZlYXR1cmVzCiMKQ09ORklHX0FSTTY0X0hXX0FGREJNPXkKQ09ORklH X0FSTTY0X1BBTj15CkNPTkZJR19BU19IQVNfTERBUFI9eQpDT05GSUdfQVNfSEFTX0xTRV9BVE9N SUNTPXkKIyBlbmQgb2YgQVJNdjguMSBhcmNoaXRlY3R1cmFsIGZlYXR1cmVzCgojCiMgQVJNdjgu MiBhcmNoaXRlY3R1cmFsIGZlYXR1cmVzCiMKIyBDT05GSUdfQVJNNjRfUE1FTSBpcyBub3Qgc2V0 CkNPTkZJR19BUk02NF9SQVNfRVhUTj15CkNPTkZJR19BUk02NF9DTlA9eQojIGVuZCBvZiBBUk12 OC4yIGFyY2hpdGVjdHVyYWwgZmVhdHVyZXMKCiMKIyBBUk12OC4zIGFyY2hpdGVjdHVyYWwgZmVh dHVyZXMKIwpDT05GSUdfQVJNNjRfUFRSX0FVVEg9eQpDT05GSUdfQVJNNjRfUFRSX0FVVEhfS0VS TkVMPXkKQ09ORklHX0NDX0hBU19CUkFOQ0hfUFJPVF9QQUNfUkVUPXkKQ09ORklHX0NDX0hBU19T SUdOX1JFVFVSTl9BRERSRVNTPXkKQ09ORklHX0FTX0hBU19QQUM9eQpDT05GSUdfQVNfSEFTX0NG SV9ORUdBVEVfUkFfU1RBVEU9eQojIGVuZCBvZiBBUk12OC4zIGFyY2hpdGVjdHVyYWwgZmVhdHVy ZXMKCiMKIyBBUk12OC40IGFyY2hpdGVjdHVyYWwgZmVhdHVyZXMKIwpDT05GSUdfQVJNNjRfQU1V X0VYVE49eQpDT05GSUdfQVNfSEFTX0FSTVY4XzQ9eQpDT05GSUdfQVJNNjRfVExCX1JBTkdFPXkK IyBlbmQgb2YgQVJNdjguNCBhcmNoaXRlY3R1cmFsIGZlYXR1cmVzCgojCiMgQVJNdjguNSBhcmNo aXRlY3R1cmFsIGZlYXR1cmVzCiMKQ09ORklHX0FTX0hBU19BUk1WOF81PXkKQ09ORklHX0FSTTY0 X0JUST15CkNPTkZJR19DQ19IQVNfQlJBTkNIX1BST1RfUEFDX1JFVF9CVEk9eQpDT05GSUdfQVJN NjRfRTBQRD15CkNPTkZJR19BUkNIX1JBTkRPTT15CkNPTkZJR19BUk02NF9BU19IQVNfTVRFPXkK Q09ORklHX0FSTTY0X01URT15CiMgZW5kIG9mIEFSTXY4LjUgYXJjaGl0ZWN0dXJhbCBmZWF0dXJl cwoKIwojIEFSTXY4LjcgYXJjaGl0ZWN0dXJhbCBmZWF0dXJlcwojCkNPTkZJR19BUk02NF9FUEFO PXkKIyBlbmQgb2YgQVJNdjguNyBhcmNoaXRlY3R1cmFsIGZlYXR1cmVzCgpDT05GSUdfQVJNNjRf U1ZFPXkKIyBDT05GSUdfQVJNNjRfUFNFVURPX05NSSBpcyBub3Qgc2V0CkNPTkZJR19SRUxPQ0FU QUJMRT15CiMgQ09ORklHX1JBTkRPTUlaRV9CQVNFIGlzIG5vdCBzZXQKQ09ORklHX0NDX0hBVkVf U1RBQ0tQUk9URUNUT1JfU1lTUkVHPXkKQ09ORklHX1NUQUNLUFJPVEVDVE9SX1BFUl9UQVNLPXkK IyBlbmQgb2YgS2VybmVsIEZlYXR1cmVzCgojCiMgQm9vdCBvcHRpb25zCiMKQ09ORklHX0NNRExJ TkU9IiIKQ09ORklHX0VGSV9TVFVCPXkKQ09ORklHX0VGST15CiMgQ09ORklHX0RNSSBpcyBub3Qg c2V0CiMgZW5kIG9mIEJvb3Qgb3B0aW9ucwoKQ09ORklHX1NZU1ZJUENfQ09NUEFUPXkKCiMKIyBQ b3dlciBtYW5hZ2VtZW50IG9wdGlvbnMKIwpDT05GSUdfU1VTUEVORD15CkNPTkZJR19TVVNQRU5E X0ZSRUVaRVI9eQojIENPTkZJR19TVVNQRU5EX1NLSVBfU1lOQyBpcyBub3Qgc2V0CkNPTkZJR19Q TV9TTEVFUD15CkNPTkZJR19QTV9TTEVFUF9TTVA9eQojIENPTkZJR19QTV9BVVRPU0xFRVAgaXMg bm90IHNldAojIENPTkZJR19QTV9XQUtFTE9DS1MgaXMgbm90IHNldApDT05GSUdfUE09eQojIENP TkZJR19QTV9ERUJVRyBpcyBub3Qgc2V0CkNPTkZJR19QTV9DTEs9eQpDT05GSUdfUE1fR0VORVJJ Q19ET01BSU5TPXkKIyBDT05GSUdfV1FfUE9XRVJfRUZGSUNJRU5UX0RFRkFVTFQgaXMgbm90IHNl dApDT05GSUdfUE1fR0VORVJJQ19ET01BSU5TX1NMRUVQPXkKQ09ORklHX1BNX0dFTkVSSUNfRE9N QUlOU19PRj15CkNPTkZJR19DUFVfUE09eQojIENPTkZJR19FTkVSR1lfTU9ERUwgaXMgbm90IHNl dApDT05GSUdfQVJDSF9ISUJFUk5BVElPTl9QT1NTSUJMRT15CkNPTkZJR19BUkNIX1NVU1BFTkRf UE9TU0lCTEU9eQojIGVuZCBvZiBQb3dlciBtYW5hZ2VtZW50IG9wdGlvbnMKCiMKIyBDUFUgUG93 ZXIgTWFuYWdlbWVudAojCgojCiMgQ1BVIElkbGUKIwpDT05GSUdfQ1BVX0lETEU9eQpDT05GSUdf Q1BVX0lETEVfTVVMVElQTEVfRFJJVkVSUz15CiMgQ09ORklHX0NQVV9JRExFX0dPVl9MQURERVIg aXMgbm90IHNldApDT05GSUdfQ1BVX0lETEVfR09WX01FTlU9eQojIENPTkZJR19DUFVfSURMRV9H T1ZfVEVPIGlzIG5vdCBzZXQKQ09ORklHX0RUX0lETEVfU1RBVEVTPXkKCiMKIyBBUk0gQ1BVIElk bGUgRHJpdmVycwojCiMgQ09ORklHX0FSTV9DUFVJRExFIGlzIG5vdCBzZXQKQ09ORklHX0FSTV9Q U0NJX0NQVUlETEU9eQpDT05GSUdfQVJNX1BTQ0lfQ1BVSURMRV9ET01BSU49eQojIGVuZCBvZiBB Uk0gQ1BVIElkbGUgRHJpdmVycwojIGVuZCBvZiBDUFUgSWRsZQoKIwojIENQVSBGcmVxdWVuY3kg c2NhbGluZwojCkNPTkZJR19DUFVfRlJFUT15CiMgQ09ORklHX0NQVV9GUkVRX1NUQVQgaXMgbm90 IHNldAojIENPTkZJR19DUFVfRlJFUV9ERUZBVUxUX0dPVl9QRVJGT1JNQU5DRSBpcyBub3Qgc2V0 CiMgQ09ORklHX0NQVV9GUkVRX0RFRkFVTFRfR09WX1BPV0VSU0FWRSBpcyBub3Qgc2V0CkNPTkZJ R19DUFVfRlJFUV9ERUZBVUxUX0dPVl9VU0VSU1BBQ0U9eQojIENPTkZJR19DUFVfRlJFUV9ERUZB VUxUX0dPVl9PTkRFTUFORCBpcyBub3Qgc2V0CiMgQ09ORklHX0NQVV9GUkVRX0RFRkFVTFRfR09W X0NPTlNFUlZBVElWRSBpcyBub3Qgc2V0CiMgQ09ORklHX0NQVV9GUkVRX0RFRkFVTFRfR09WX1ND SEVEVVRJTCBpcyBub3Qgc2V0CiMgQ09ORklHX0NQVV9GUkVRX0dPVl9QRVJGT1JNQU5DRSBpcyBu b3Qgc2V0CiMgQ09ORklHX0NQVV9GUkVRX0dPVl9QT1dFUlNBVkUgaXMgbm90IHNldApDT05GSUdf Q1BVX0ZSRVFfR09WX1VTRVJTUEFDRT15CiMgQ09ORklHX0NQVV9GUkVRX0dPVl9PTkRFTUFORCBp cyBub3Qgc2V0CiMgQ09ORklHX0NQVV9GUkVRX0dPVl9DT05TRVJWQVRJVkUgaXMgbm90IHNldAoj IENPTkZJR19DUFVfRlJFUV9HT1ZfU0NIRURVVElMIGlzIG5vdCBzZXQKCiMKIyBDUFUgZnJlcXVl bmN5IHNjYWxpbmcgZHJpdmVycwojCkNPTkZJR19DUFVGUkVRX0RUPXkKQ09ORklHX0NQVUZSRVFf RFRfUExBVERFVj15CiMgZW5kIG9mIENQVSBGcmVxdWVuY3kgc2NhbGluZwojIGVuZCBvZiBDUFUg UG93ZXIgTWFuYWdlbWVudAoKIwojIEZpcm13YXJlIERyaXZlcnMKIwojIENPTkZJR19BUk1fU0NN SV9QUk9UT0NPTCBpcyBub3Qgc2V0CiMgQ09ORklHX0FSTV9TQ1BJX1BST1RPQ09MIGlzIG5vdCBz ZXQKIyBDT05GSUdfQVJNX1NERV9JTlRFUkZBQ0UgaXMgbm90IHNldAojIENPTkZJR19GSVJNV0FS RV9NRU1NQVAgaXMgbm90IHNldAojIENPTkZJR19BUk1fRkZBX1RSQU5TUE9SVCBpcyBub3Qgc2V0 CiMgQ09ORklHX0dPT0dMRV9GSVJNV0FSRSBpcyBub3Qgc2V0CgojCiMgRUZJIChFeHRlbnNpYmxl IEZpcm13YXJlIEludGVyZmFjZSkgU3VwcG9ydAojCkNPTkZJR19FRklfRVNSVD15CkNPTkZJR19F RklfUEFSQU1TX0ZST01fRkRUPXkKQ09ORklHX0VGSV9SVU5USU1FX1dSQVBQRVJTPXkKQ09ORklH X0VGSV9HRU5FUklDX1NUVUI9eQpDT05GSUdfRUZJX0FSTVNUVUJfRFRCX0xPQURFUj15CiMgQ09O RklHX0VGSV9HRU5FUklDX1NUVUJfSU5JVFJEX0NNRExJTkVfTE9BREVSIGlzIG5vdCBzZXQKIyBD T05GSUdfRUZJX0JPT1RMT0FERVJfQ09OVFJPTCBpcyBub3Qgc2V0CiMgQ09ORklHX0VGSV9DQVBT VUxFX0xPQURFUiBpcyBub3Qgc2V0CiMgQ09ORklHX0VGSV9URVNUIGlzIG5vdCBzZXQKIyBDT05G SUdfUkVTRVRfQVRUQUNLX01JVElHQVRJT04gaXMgbm90IHNldAojIENPTkZJR19FRklfRElTQUJM RV9QQ0lfRE1BIGlzIG5vdCBzZXQKIyBlbmQgb2YgRUZJIChFeHRlbnNpYmxlIEZpcm13YXJlIElu dGVyZmFjZSkgU3VwcG9ydAoKQ09ORklHX0VGSV9FQVJMWUNPTj15CkNPTkZJR19BUk1fUFNDSV9G Vz15CiMgQ09ORklHX0FSTV9QU0NJX0NIRUNLRVIgaXMgbm90IHNldApDT05GSUdfSEFWRV9BUk1f U01DQ0M9eQpDT05GSUdfSEFWRV9BUk1fU01DQ0NfRElTQ09WRVJZPXkKQ09ORklHX0FSTV9TTUND Q19TT0NfSUQ9eQoKIwojIFRlZ3JhIGZpcm13YXJlIGRyaXZlcgojCiMgZW5kIG9mIFRlZ3JhIGZp cm13YXJlIGRyaXZlcgoKIwojIFp5bnEgTVBTb0MgRmlybXdhcmUgRHJpdmVycwojCkNPTkZJR19a WU5RTVBfRklSTVdBUkU9eQojIENPTkZJR19aWU5RTVBfRklSTVdBUkVfREVCVUcgaXMgbm90IHNl dAojIGVuZCBvZiBaeW5xIE1QU29DIEZpcm13YXJlIERyaXZlcnMKIyBlbmQgb2YgRmlybXdhcmUg RHJpdmVycwoKQ09ORklHX0FSQ0hfU1VQUE9SVFNfQUNQST15CiMgQ09ORklHX0FDUEkgaXMgbm90 IHNldAojIENPTkZJR19WSVJUVUFMSVpBVElPTiBpcyBub3Qgc2V0CiMgQ09ORklHX0FSTTY0X0NS WVBUTyBpcyBub3Qgc2V0CgojCiMgR2VuZXJhbCBhcmNoaXRlY3R1cmUtZGVwZW5kZW50IG9wdGlv bnMKIwojIENPTkZJR19KVU1QX0xBQkVMIGlzIG5vdCBzZXQKQ09ORklHX0hBVkVfRUZGSUNJRU5U X1VOQUxJR05FRF9BQ0NFU1M9eQpDT05GSUdfSEFWRV9LUFJPQkVTPXkKQ09ORklHX0hBVkVfS1JF VFBST0JFUz15CkNPTkZJR19IQVZFX0ZVTkNUSU9OX0VSUk9SX0lOSkVDVElPTj15CkNPTkZJR19I QVZFX05NST15CkNPTkZJR19IQVZFX0FSQ0hfVFJBQ0VIT09LPXkKQ09ORklHX0hBVkVfRE1BX0NP TlRJR1VPVVM9eQpDT05GSUdfR0VORVJJQ19TTVBfSURMRV9USFJFQUQ9eQpDT05GSUdfR0VORVJJ Q19JRExFX1BPTExfU0VUVVA9eQpDT05GSUdfQVJDSF9IQVNfRk9SVElGWV9TT1VSQ0U9eQpDT05G SUdfQVJDSF9IQVNfS0VFUElOSVRSRD15CkNPTkZJR19BUkNIX0hBU19TRVRfTUVNT1JZPXkKQ09O RklHX0FSQ0hfSEFTX1NFVF9ESVJFQ1RfTUFQPXkKQ09ORklHX0hBVkVfQVJDSF9USFJFQURfU1RS VUNUX1dISVRFTElTVD15CkNPTkZJR19BUkNIX1dBTlRTX05PX0lOU1RSPXkKQ09ORklHX0hBVkVf QVNNX01PRFZFUlNJT05TPXkKQ09ORklHX0hBVkVfUkVHU19BTkRfU1RBQ0tfQUNDRVNTX0FQST15 CkNPTkZJR19IQVZFX1JTRVE9eQpDT05GSUdfSEFWRV9GVU5DVElPTl9BUkdfQUNDRVNTX0FQST15 CkNPTkZJR19IQVZFX0hXX0JSRUFLUE9JTlQ9eQpDT05GSUdfSEFWRV9QRVJGX1JFR1M9eQpDT05G SUdfSEFWRV9QRVJGX1VTRVJfU1RBQ0tfRFVNUD15CkNPTkZJR19IQVZFX0FSQ0hfSlVNUF9MQUJF TD15CkNPTkZJR19IQVZFX0FSQ0hfSlVNUF9MQUJFTF9SRUxBVElWRT15CkNPTkZJR19NTVVfR0FU SEVSX1RBQkxFX0ZSRUU9eQpDT05GSUdfTU1VX0dBVEhFUl9SQ1VfVEFCTEVfRlJFRT15CkNPTkZJ R19BUkNIX0hBVkVfTk1JX1NBRkVfQ01QWENIRz15CkNPTkZJR19IQVZFX0NNUFhDSEdfTE9DQUw9 eQpDT05GSUdfSEFWRV9DTVBYQ0hHX0RPVUJMRT15CkNPTkZJR19BUkNIX1dBTlRfQ09NUEFUX0lQ Q19QQVJTRV9WRVJTSU9OPXkKQ09ORklHX0hBVkVfQVJDSF9TRUNDT01QPXkKQ09ORklHX0hBVkVf QVJDSF9TRUNDT01QX0ZJTFRFUj15CiMgQ09ORklHX1NFQ0NPTVAgaXMgbm90IHNldApDT05GSUdf SEFWRV9BUkNIX1NUQUNLTEVBSz15CkNPTkZJR19IQVZFX1NUQUNLUFJPVEVDVE9SPXkKQ09ORklH X1NUQUNLUFJPVEVDVE9SPXkKQ09ORklHX1NUQUNLUFJPVEVDVE9SX1NUUk9ORz15CkNPTkZJR19B UkNIX1NVUFBPUlRTX0xUT19DTEFORz15CkNPTkZJR19BUkNIX1NVUFBPUlRTX0xUT19DTEFOR19U SElOPXkKQ09ORklHX0xUT19OT05FPXkKQ09ORklHX0FSQ0hfU1VQUE9SVFNfQ0ZJX0NMQU5HPXkK Q09ORklHX0hBVkVfQ09OVEVYVF9UUkFDS0lORz15CkNPTkZJR19IQVZFX1ZJUlRfQ1BVX0FDQ09V TlRJTkdfR0VOPXkKQ09ORklHX0hBVkVfSVJRX1RJTUVfQUNDT1VOVElORz15CkNPTkZJR19IQVZF X01PVkVfUFVEPXkKQ09ORklHX0hBVkVfTU9WRV9QTUQ9eQpDT05GSUdfSEFWRV9BUkNIX1RSQU5T UEFSRU5UX0hVR0VQQUdFPXkKQ09ORklHX0hBVkVfQVJDSF9IVUdFX1ZNQVA9eQpDT05GSUdfQVJD SF9XQU5UX0hVR0VfUE1EX1NIQVJFPXkKQ09ORklHX01PRFVMRVNfVVNFX0VMRl9SRUxBPXkKQ09O RklHX0FSQ0hfSEFTX0VMRl9SQU5ET01JWkU9eQpDT05GSUdfSEFWRV9BUkNIX01NQVBfUk5EX0JJ VFM9eQpDT05GSUdfQVJDSF9NTUFQX1JORF9CSVRTPTE4CkNPTkZJR19IQVZFX0FSQ0hfTU1BUF9S TkRfQ09NUEFUX0JJVFM9eQpDT05GSUdfQVJDSF9NTUFQX1JORF9DT01QQVRfQklUUz0xMQpDT05G SUdfQVJDSF9XQU5UX0RFRkFVTFRfVE9QRE9XTl9NTUFQX0xBWU9VVD15CkNPTkZJR19DTE9ORV9C QUNLV0FSRFM9eQpDT05GSUdfT0xEX1NJR1NVU1BFTkQzPXkKQ09ORklHX0NPTVBBVF9PTERfU0lH QUNUSU9OPXkKQ09ORklHX0NPTVBBVF8zMkJJVF9USU1FPXkKQ09ORklHX0hBVkVfQVJDSF9WTUFQ X1NUQUNLPXkKQ09ORklHX1ZNQVBfU1RBQ0s9eQpDT05GSUdfSEFWRV9BUkNIX1JBTkRPTUlaRV9L U1RBQ0tfT0ZGU0VUPXkKIyBDT05GSUdfUkFORE9NSVpFX0tTVEFDS19PRkZTRVRfREVGQVVMVCBp cyBub3Qgc2V0CkNPTkZJR19BUkNIX0hBU19TVFJJQ1RfS0VSTkVMX1JXWD15CkNPTkZJR19TVFJJ Q1RfS0VSTkVMX1JXWD15CkNPTkZJR19BUkNIX0hBU19TVFJJQ1RfTU9EVUxFX1JXWD15CkNPTkZJ R19IQVZFX0FSQ0hfQ09NUElMRVJfSD15CkNPTkZJR19IQVZFX0FSQ0hfUFJFTDMyX1JFTE9DQVRJ T05TPXkKQ09ORklHX0FSQ0hfVVNFX01FTVJFTUFQX1BST1Q9eQojIENPTkZJR19MT0NLX0VWRU5U X0NPVU5UUyBpcyBub3Qgc2V0CkNPTkZJR19BUkNIX0hBU19SRUxSPXkKQ09ORklHX0FSQ0hfV0FO VF9MRF9PUlBIQU5fV0FSTj15CkNPTkZJR19IQVZFX0FSQ0hfUEZOX1ZBTElEPXkKQ09ORklHX0FS Q0hfU1VQUE9SVFNfREVCVUdfUEFHRUFMTE9DPXkKCiMKIyBHQ09WLWJhc2VkIGtlcm5lbCBwcm9m aWxpbmcKIwojIENPTkZJR19HQ09WX0tFUk5FTCBpcyBub3Qgc2V0CkNPTkZJR19BUkNIX0hBU19H Q09WX1BST0ZJTEVfQUxMPXkKIyBlbmQgb2YgR0NPVi1iYXNlZCBrZXJuZWwgcHJvZmlsaW5nCgpD T05GSUdfSEFWRV9HQ0NfUExVR0lOUz15CiMgZW5kIG9mIEdlbmVyYWwgYXJjaGl0ZWN0dXJlLWRl cGVuZGVudCBvcHRpb25zCgpDT05GSUdfUlRfTVVURVhFUz15CkNPTkZJR19CQVNFX1NNQUxMPTAK IyBDT05GSUdfTU9EVUxFUyBpcyBub3Qgc2V0CkNPTkZJR19NT0RVTEVTX1RSRUVfTE9PS1VQPXkK IyBDT05GSUdfQkxPQ0sgaXMgbm90IHNldApDT05GSUdfQVNOMT15CkNPTkZJR19BUkNIX0lOTElO RV9TUElOX1RSWUxPQ0s9eQpDT05GSUdfQVJDSF9JTkxJTkVfU1BJTl9UUllMT0NLX0JIPXkKQ09O RklHX0FSQ0hfSU5MSU5FX1NQSU5fTE9DSz15CkNPTkZJR19BUkNIX0lOTElORV9TUElOX0xPQ0tf Qkg9eQpDT05GSUdfQVJDSF9JTkxJTkVfU1BJTl9MT0NLX0lSUT15CkNPTkZJR19BUkNIX0lOTElO RV9TUElOX0xPQ0tfSVJRU0FWRT15CkNPTkZJR19BUkNIX0lOTElORV9TUElOX1VOTE9DSz15CkNP TkZJR19BUkNIX0lOTElORV9TUElOX1VOTE9DS19CSD15CkNPTkZJR19BUkNIX0lOTElORV9TUElO X1VOTE9DS19JUlE9eQpDT05GSUdfQVJDSF9JTkxJTkVfU1BJTl9VTkxPQ0tfSVJRUkVTVE9SRT15 CkNPTkZJR19BUkNIX0lOTElORV9SRUFEX0xPQ0s9eQpDT05GSUdfQVJDSF9JTkxJTkVfUkVBRF9M T0NLX0JIPXkKQ09ORklHX0FSQ0hfSU5MSU5FX1JFQURfTE9DS19JUlE9eQpDT05GSUdfQVJDSF9J TkxJTkVfUkVBRF9MT0NLX0lSUVNBVkU9eQpDT05GSUdfQVJDSF9JTkxJTkVfUkVBRF9VTkxPQ0s9 eQpDT05GSUdfQVJDSF9JTkxJTkVfUkVBRF9VTkxPQ0tfQkg9eQpDT05GSUdfQVJDSF9JTkxJTkVf UkVBRF9VTkxPQ0tfSVJRPXkKQ09ORklHX0FSQ0hfSU5MSU5FX1JFQURfVU5MT0NLX0lSUVJFU1RP UkU9eQpDT05GSUdfQVJDSF9JTkxJTkVfV1JJVEVfTE9DSz15CkNPTkZJR19BUkNIX0lOTElORV9X UklURV9MT0NLX0JIPXkKQ09ORklHX0FSQ0hfSU5MSU5FX1dSSVRFX0xPQ0tfSVJRPXkKQ09ORklH X0FSQ0hfSU5MSU5FX1dSSVRFX0xPQ0tfSVJRU0FWRT15CkNPTkZJR19BUkNIX0lOTElORV9XUklU RV9VTkxPQ0s9eQpDT05GSUdfQVJDSF9JTkxJTkVfV1JJVEVfVU5MT0NLX0JIPXkKQ09ORklHX0FS Q0hfSU5MSU5FX1dSSVRFX1VOTE9DS19JUlE9eQpDT05GSUdfQVJDSF9JTkxJTkVfV1JJVEVfVU5M T0NLX0lSUVJFU1RPUkU9eQpDT05GSUdfSU5MSU5FX1NQSU5fVFJZTE9DSz15CkNPTkZJR19JTkxJ TkVfU1BJTl9UUllMT0NLX0JIPXkKQ09ORklHX0lOTElORV9TUElOX0xPQ0s9eQpDT05GSUdfSU5M SU5FX1NQSU5fTE9DS19CSD15CkNPTkZJR19JTkxJTkVfU1BJTl9MT0NLX0lSUT15CkNPTkZJR19J TkxJTkVfU1BJTl9MT0NLX0lSUVNBVkU9eQpDT05GSUdfSU5MSU5FX1NQSU5fVU5MT0NLX0JIPXkK Q09ORklHX0lOTElORV9TUElOX1VOTE9DS19JUlE9eQpDT05GSUdfSU5MSU5FX1NQSU5fVU5MT0NL X0lSUVJFU1RPUkU9eQpDT05GSUdfSU5MSU5FX1JFQURfTE9DSz15CkNPTkZJR19JTkxJTkVfUkVB RF9MT0NLX0JIPXkKQ09ORklHX0lOTElORV9SRUFEX0xPQ0tfSVJRPXkKQ09ORklHX0lOTElORV9S RUFEX0xPQ0tfSVJRU0FWRT15CkNPTkZJR19JTkxJTkVfUkVBRF9VTkxPQ0s9eQpDT05GSUdfSU5M SU5FX1JFQURfVU5MT0NLX0JIPXkKQ09ORklHX0lOTElORV9SRUFEX1VOTE9DS19JUlE9eQpDT05G SUdfSU5MSU5FX1JFQURfVU5MT0NLX0lSUVJFU1RPUkU9eQpDT05GSUdfSU5MSU5FX1dSSVRFX0xP Q0s9eQpDT05GSUdfSU5MSU5FX1dSSVRFX0xPQ0tfQkg9eQpDT05GSUdfSU5MSU5FX1dSSVRFX0xP Q0tfSVJRPXkKQ09ORklHX0lOTElORV9XUklURV9MT0NLX0lSUVNBVkU9eQpDT05GSUdfSU5MSU5F X1dSSVRFX1VOTE9DSz15CkNPTkZJR19JTkxJTkVfV1JJVEVfVU5MT0NLX0JIPXkKQ09ORklHX0lO TElORV9XUklURV9VTkxPQ0tfSVJRPXkKQ09ORklHX0lOTElORV9XUklURV9VTkxPQ0tfSVJRUkVT VE9SRT15CkNPTkZJR19BUkNIX1NVUFBPUlRTX0FUT01JQ19STVc9eQpDT05GSUdfTVVURVhfU1BJ Tl9PTl9PV05FUj15CkNPTkZJR19SV1NFTV9TUElOX09OX09XTkVSPXkKQ09ORklHX0xPQ0tfU1BJ Tl9PTl9PV05FUj15CkNPTkZJR19BUkNIX1VTRV9RVUVVRURfU1BJTkxPQ0tTPXkKQ09ORklHX1FV RVVFRF9TUElOTE9DS1M9eQpDT05GSUdfQVJDSF9VU0VfUVVFVUVEX1JXTE9DS1M9eQpDT05GSUdf UVVFVUVEX1JXTE9DS1M9eQpDT05GSUdfQVJDSF9IQVNfTk9OX09WRVJMQVBQSU5HX0FERFJFU1Nf U1BBQ0U9eQpDT05GSUdfQVJDSF9IQVNfU1lTQ0FMTF9XUkFQUEVSPXkKQ09ORklHX0ZSRUVaRVI9 eQoKIwojIEV4ZWN1dGFibGUgZmlsZSBmb3JtYXRzCiMKQ09ORklHX0JJTkZNVF9FTEY9eQpDT05G SUdfQ09NUEFUX0JJTkZNVF9FTEY9eQpDT05GSUdfQVJDSF9CSU5GTVRfRUxGX1NUQVRFPXkKQ09O RklHX0FSQ0hfSEFWRV9FTEZfUFJPVD15CkNPTkZJR19BUkNIX1VTRV9HTlVfUFJPUEVSVFk9eQpD T05GSUdfRUxGQ09SRT15CkNPTkZJR19DT1JFX0RVTVBfREVGQVVMVF9FTEZfSEVBREVSUz15CkNP TkZJR19CSU5GTVRfU0NSSVBUPXkKIyBDT05GSUdfQklORk1UX01JU0MgaXMgbm90IHNldApDT05G SUdfQ09SRURVTVA9eQojIGVuZCBvZiBFeGVjdXRhYmxlIGZpbGUgZm9ybWF0cwoKIwojIE1lbW9y eSBNYW5hZ2VtZW50IG9wdGlvbnMKIwpDT05GSUdfU1BBUlNFTUVNPXkKQ09ORklHX1NQQVJTRU1F TV9FWFRSRU1FPXkKQ09ORklHX1NQQVJTRU1FTV9WTUVNTUFQX0VOQUJMRT15CkNPTkZJR19TUEFS U0VNRU1fVk1FTU1BUD15CkNPTkZJR19IQVZFX0ZBU1RfR1VQPXkKQ09ORklHX0FSQ0hfS0VFUF9N RU1CTE9DSz15CkNPTkZJR19NRU1PUllfSVNPTEFUSU9OPXkKQ09ORklHX0FSQ0hfRU5BQkxFX01F TU9SWV9IT1RQTFVHPXkKQ09ORklHX01FTU9SWV9IT1RQTFVHPXkKQ09ORklHX01FTU9SWV9IT1RQ TFVHX1NQQVJTRT15CiMgQ09ORklHX01FTU9SWV9IT1RQTFVHX0RFRkFVTFRfT05MSU5FIGlzIG5v dCBzZXQKQ09ORklHX0FSQ0hfRU5BQkxFX01FTU9SWV9IT1RSRU1PVkU9eQojIENPTkZJR19NRU1P UllfSE9UUkVNT1ZFIGlzIG5vdCBzZXQKQ09ORklHX01IUF9NRU1NQVBfT05fTUVNT1JZPXkKQ09O RklHX1NQTElUX1BUTE9DS19DUFVTPTQKQ09ORklHX0FSQ0hfRU5BQkxFX1NQTElUX1BNRF9QVExP Q0s9eQpDT05GSUdfQ09NUEFDVElPTj15CiMgQ09ORklHX1BBR0VfUkVQT1JUSU5HIGlzIG5vdCBz ZXQKQ09ORklHX01JR1JBVElPTj15CkNPTkZJR19BUkNIX0VOQUJMRV9IVUdFUEFHRV9NSUdSQVRJ T049eQpDT05GSUdfQVJDSF9FTkFCTEVfVEhQX01JR1JBVElPTj15CkNPTkZJR19DT05USUdfQUxM T0M9eQpDT05GSUdfUEhZU19BRERSX1RfNjRCSVQ9eQojIENPTkZJR19LU00gaXMgbm90IHNldApD T05GSUdfREVGQVVMVF9NTUFQX01JTl9BRERSPTMyNzY4CkNPTkZJR19BUkNIX1NVUFBPUlRTX01F TU9SWV9GQUlMVVJFPXkKIyBDT05GSUdfTUVNT1JZX0ZBSUxVUkUgaXMgbm90IHNldApDT05GSUdf VFJBTlNQQVJFTlRfSFVHRVBBR0U9eQojIENPTkZJR19UUkFOU1BBUkVOVF9IVUdFUEFHRV9BTFdB WVMgaXMgbm90IHNldApDT05GSUdfVFJBTlNQQVJFTlRfSFVHRVBBR0VfTUFEVklTRT15CiMgQ09O RklHX0NMRUFOQ0FDSEUgaXMgbm90IHNldApDT05GSUdfQ01BPXkKIyBDT05GSUdfQ01BX0RFQlVH IGlzIG5vdCBzZXQKIyBDT05GSUdfQ01BX0RFQlVHRlMgaXMgbm90IHNldAojIENPTkZJR19DTUFf U1lTRlMgaXMgbm90IHNldApDT05GSUdfQ01BX0FSRUFTPTcKIyBDT05GSUdfWlBPT0wgaXMgbm90 IHNldAojIENPTkZJR19aU01BTExPQyBpcyBub3Qgc2V0CkNPTkZJR19HRU5FUklDX0VBUkxZX0lP UkVNQVA9eQojIENPTkZJR19ERUZFUlJFRF9TVFJVQ1RfUEFHRV9JTklUIGlzIG5vdCBzZXQKIyBD T05GSUdfSURMRV9QQUdFX1RSQUNLSU5HIGlzIG5vdCBzZXQKQ09ORklHX0FSQ0hfSEFTX0NBQ0hF X0xJTkVfU0laRT15CkNPTkZJR19BUkNIX0hBU19QVEVfREVWTUFQPXkKQ09ORklHX0FSQ0hfSEFT X1pPTkVfRE1BX1NFVD15CiMgQ09ORklHX1pPTkVfRE1BIGlzIG5vdCBzZXQKQ09ORklHX1pPTkVf RE1BMzI9eQpDT05GSUdfQVJDSF9VU0VTX0hJR0hfVk1BX0ZMQUdTPXkKIyBDT05GSUdfUEVSQ1BV X1NUQVRTIGlzIG5vdCBzZXQKIyBDT05GSUdfR1VQX1RFU1QgaXMgbm90IHNldAojIENPTkZJR19S RUFEX09OTFlfVEhQX0ZPUl9GUyBpcyBub3Qgc2V0CkNPTkZJR19BUkNIX0hBU19QVEVfU1BFQ0lB TD15CiMgZW5kIG9mIE1lbW9yeSBNYW5hZ2VtZW50IG9wdGlvbnMKCiMgQ09ORklHX05FVCBpcyBu b3Qgc2V0CgojCiMgRGV2aWNlIERyaXZlcnMKIwpDT05GSUdfQVJNX0FNQkE9eQpDT05GSUdfSEFW RV9QQ0k9eQojIENPTkZJR19QQ0kgaXMgbm90IHNldAojIENPTkZJR19QQ0NBUkQgaXMgbm90IHNl dAoKIwojIEdlbmVyaWMgRHJpdmVyIE9wdGlvbnMKIwojIENPTkZJR19VRVZFTlRfSEVMUEVSIGlz IG5vdCBzZXQKQ09ORklHX0RFVlRNUEZTPXkKQ09ORklHX0RFVlRNUEZTX01PVU5UPXkKQ09ORklH X1NUQU5EQUxPTkU9eQpDT05GSUdfUFJFVkVOVF9GSVJNV0FSRV9CVUlMRD15CgojCiMgRmlybXdh cmUgbG9hZGVyCiMKQ09ORklHX0ZXX0xPQURFUj15CkNPTkZJR19FWFRSQV9GSVJNV0FSRT0iIgoj IENPTkZJR19GV19MT0FERVJfVVNFUl9IRUxQRVIgaXMgbm90IHNldAojIENPTkZJR19GV19MT0FE RVJfQ09NUFJFU1MgaXMgbm90IHNldApDT05GSUdfRldfQ0FDSEU9eQojIGVuZCBvZiBGaXJtd2Fy ZSBsb2FkZXIKCkNPTkZJR19XQU5UX0RFVl9DT1JFRFVNUD15CkNPTkZJR19BTExPV19ERVZfQ09S RURVTVA9eQpDT05GSUdfREVWX0NPUkVEVU1QPXkKIyBDT05GSUdfREVCVUdfRFJJVkVSIGlzIG5v dCBzZXQKIyBDT05GSUdfREVCVUdfREVWUkVTIGlzIG5vdCBzZXQKIyBDT05GSUdfREVCVUdfVEVT VF9EUklWRVJfUkVNT1ZFIGlzIG5vdCBzZXQKQ09ORklHX0dFTkVSSUNfQ1BVX0FVVE9QUk9CRT15 CkNPTkZJR19HRU5FUklDX0NQVV9WVUxORVJBQklMSVRJRVM9eQpDT05GSUdfU09DX0JVUz15CkNP TkZJR19SRUdNQVA9eQpDT05GSUdfUkVHTUFQX0kyQz15CkNPTkZJR19SRUdNQVBfTU1JTz15CkNP TkZJR19SRUdNQVBfSVJRPXkKQ09ORklHX0RNQV9TSEFSRURfQlVGRkVSPXkKIyBDT05GSUdfRE1B X0ZFTkNFX1RSQUNFIGlzIG5vdCBzZXQKQ09ORklHX0dFTkVSSUNfQVJDSF9UT1BPTE9HWT15CiMg ZW5kIG9mIEdlbmVyaWMgRHJpdmVyIE9wdGlvbnMKCiMKIyBCdXMgZGV2aWNlcwojCiMgQ09ORklH X0JSQ01TVEJfR0lTQl9BUkIgaXMgbm90IHNldAojIENPTkZJR19TSU1QTEVfUE1fQlVTIGlzIG5v dCBzZXQKIyBDT05GSUdfVkVYUFJFU1NfQ09ORklHIGlzIG5vdCBzZXQKIyBDT05GSUdfTUhJX0JV UyBpcyBub3Qgc2V0CiMgZW5kIG9mIEJ1cyBkZXZpY2VzCgojIENPTkZJR19HTlNTIGlzIG5vdCBz ZXQKIyBDT05GSUdfTVREIGlzIG5vdCBzZXQKQ09ORklHX0RUQz15CkNPTkZJR19PRj15CiMgQ09O RklHX09GX1VOSVRURVNUIGlzIG5vdCBzZXQKQ09ORklHX09GX0ZMQVRUUkVFPXkKQ09ORklHX09G X0VBUkxZX0ZMQVRUUkVFPXkKQ09ORklHX09GX0tPQko9eQpDT05GSUdfT0ZfRFlOQU1JQz15CkNP TkZJR19PRl9BRERSRVNTPXkKQ09ORklHX09GX0lSUT15CkNPTkZJR19PRl9SRVNFUlZFRF9NRU09 eQpDT05GSUdfT0ZfUkVTT0xWRT15CkNPTkZJR19PRl9PVkVSTEFZPXkKIyBDT05GSUdfUEFSUE9S VCBpcyBub3Qgc2V0CgojCiMgTlZNRSBTdXBwb3J0CiMKIyBlbmQgb2YgTlZNRSBTdXBwb3J0Cgoj CiMgTWlzYyBkZXZpY2VzCiMKIyBDT05GSUdfQUQ1MjVYX0RQT1QgaXMgbm90IHNldAojIENPTkZJ R19EVU1NWV9JUlEgaXMgbm90IHNldAojIENPTkZJR19JQ1M5MzJTNDAxIGlzIG5vdCBzZXQKIyBD T05GSUdfRU5DTE9TVVJFX1NFUlZJQ0VTIGlzIG5vdCBzZXQKIyBDT05GSUdfQVBEUzk4MDJBTFMg aXMgbm90IHNldAojIENPTkZJR19JU0wyOTAwMyBpcyBub3Qgc2V0CiMgQ09ORklHX0lTTDI5MDIw IGlzIG5vdCBzZXQKIyBDT05GSUdfU0VOU09SU19UU0wyNTUwIGlzIG5vdCBzZXQKIyBDT05GSUdf U0VOU09SU19CSDE3NzAgaXMgbm90IHNldAojIENPTkZJR19TRU5TT1JTX0FQRFM5OTBYIGlzIG5v dCBzZXQKIyBDT05GSUdfSE1DNjM1MiBpcyBub3Qgc2V0CiMgQ09ORklHX0RTMTY4MiBpcyBub3Qg c2V0CiMgQ09ORklHX1NSQU0gaXMgbm90IHNldApDT05GSUdfWElMSU5YX1NERkVDPXkKIyBDT05G SUdfQzJQT1JUIGlzIG5vdCBzZXQKCiMKIyBFRVBST00gc3VwcG9ydAojCkNPTkZJR19FRVBST01f QVQyND15CiMgQ09ORklHX0VFUFJPTV9MRUdBQ1kgaXMgbm90IHNldAojIENPTkZJR19FRVBST01f TUFYNjg3NSBpcyBub3Qgc2V0CiMgQ09ORklHX0VFUFJPTV85M0NYNiBpcyBub3Qgc2V0CiMgQ09O RklHX0VFUFJPTV9JRFRfODlIUEVTWCBpcyBub3Qgc2V0CiMgQ09ORklHX0VFUFJPTV9FRTEwMDQg aXMgbm90IHNldAojIGVuZCBvZiBFRVBST00gc3VwcG9ydAoKIwojIFRleGFzIEluc3RydW1lbnRz IHNoYXJlZCB0cmFuc3BvcnQgbGluZSBkaXNjaXBsaW5lCiMKIyBlbmQgb2YgVGV4YXMgSW5zdHJ1 bWVudHMgc2hhcmVkIHRyYW5zcG9ydCBsaW5lIGRpc2NpcGxpbmUKCiMgQ09ORklHX1NFTlNPUlNf TElTM19JMkMgaXMgbm90IHNldAojIENPTkZJR19BTFRFUkFfU1RBUEwgaXMgbm90IHNldAojIENP TkZJR19FQ0hPIGlzIG5vdCBzZXQKIyBDT05GSUdfVUFDQ0UgaXMgbm90IHNldAojIENPTkZJR19Q VlBBTklDIGlzIG5vdCBzZXQKIyBlbmQgb2YgTWlzYyBkZXZpY2VzCgojCiMgU0NTSSBkZXZpY2Ug c3VwcG9ydAojCkNPTkZJR19TQ1NJX01PRD15CiMgZW5kIG9mIFNDU0kgZGV2aWNlIHN1cHBvcnQK CkNPTkZJR19IQVZFX1BBVEFfUExBVEZPUk09eQoKIwojIElucHV0IGRldmljZSBzdXBwb3J0CiMK Q09ORklHX0lOUFVUPXkKQ09ORklHX0lOUFVUX0xFRFM9eQojIENPTkZJR19JTlBVVF9GRl9NRU1M RVNTIGlzIG5vdCBzZXQKIyBDT05GSUdfSU5QVVRfU1BBUlNFS01BUCBpcyBub3Qgc2V0CiMgQ09O RklHX0lOUFVUX01BVFJJWEtNQVAgaXMgbm90IHNldAoKIwojIFVzZXJsYW5kIGludGVyZmFjZXMK IwojIENPTkZJR19JTlBVVF9NT1VTRURFViBpcyBub3Qgc2V0CiMgQ09ORklHX0lOUFVUX0pPWURF ViBpcyBub3Qgc2V0CkNPTkZJR19JTlBVVF9FVkRFVj15CiMgQ09ORklHX0lOUFVUX0VWQlVHIGlz IG5vdCBzZXQKCiMKIyBJbnB1dCBEZXZpY2UgRHJpdmVycwojCkNPTkZJR19JTlBVVF9LRVlCT0FS RD15CiMgQ09ORklHX0tFWUJPQVJEX0FEQyBpcyBub3Qgc2V0CiMgQ09ORklHX0tFWUJPQVJEX0FE UDU1ODggaXMgbm90IHNldAojIENPTkZJR19LRVlCT0FSRF9BRFA1NTg5IGlzIG5vdCBzZXQKQ09O RklHX0tFWUJPQVJEX0FUS0JEPXkKIyBDT05GSUdfS0VZQk9BUkRfUVQxMDUwIGlzIG5vdCBzZXQK IyBDT05GSUdfS0VZQk9BUkRfUVQxMDcwIGlzIG5vdCBzZXQKIyBDT05GSUdfS0VZQk9BUkRfUVQy MTYwIGlzIG5vdCBzZXQKIyBDT05GSUdfS0VZQk9BUkRfRExJTktfRElSNjg1IGlzIG5vdCBzZXQK IyBDT05GSUdfS0VZQk9BUkRfTEtLQkQgaXMgbm90IHNldApDT05GSUdfS0VZQk9BUkRfR1BJTz15 CkNPTkZJR19LRVlCT0FSRF9HUElPX1BPTExFRD15CiMgQ09ORklHX0tFWUJPQVJEX1RDQTY0MTYg aXMgbm90IHNldAojIENPTkZJR19LRVlCT0FSRF9UQ0E4NDE4IGlzIG5vdCBzZXQKIyBDT05GSUdf S0VZQk9BUkRfTUFUUklYIGlzIG5vdCBzZXQKIyBDT05GSUdfS0VZQk9BUkRfTE04MzIzIGlzIG5v dCBzZXQKIyBDT05GSUdfS0VZQk9BUkRfTE04MzMzIGlzIG5vdCBzZXQKIyBDT05GSUdfS0VZQk9B UkRfTUFYNzM1OSBpcyBub3Qgc2V0CiMgQ09ORklHX0tFWUJPQVJEX01DUyBpcyBub3Qgc2V0CiMg Q09ORklHX0tFWUJPQVJEX01QUjEyMSBpcyBub3Qgc2V0CiMgQ09ORklHX0tFWUJPQVJEX05FV1RP TiBpcyBub3Qgc2V0CiMgQ09ORklHX0tFWUJPQVJEX09QRU5DT1JFUyBpcyBub3Qgc2V0CiMgQ09O RklHX0tFWUJPQVJEX1NBTVNVTkcgaXMgbm90IHNldAojIENPTkZJR19LRVlCT0FSRF9TVE9XQVdB WSBpcyBub3Qgc2V0CiMgQ09ORklHX0tFWUJPQVJEX1NVTktCRCBpcyBub3Qgc2V0CiMgQ09ORklH X0tFWUJPQVJEX09NQVA0IGlzIG5vdCBzZXQKIyBDT05GSUdfS0VZQk9BUkRfVE0yX1RPVUNIS0VZ IGlzIG5vdCBzZXQKIyBDT05GSUdfS0VZQk9BUkRfWFRLQkQgaXMgbm90IHNldAojIENPTkZJR19L RVlCT0FSRF9DQVAxMVhYIGlzIG5vdCBzZXQKIyBDT05GSUdfS0VZQk9BUkRfQkNNIGlzIG5vdCBz ZXQKQ09ORklHX0lOUFVUX01PVVNFPXkKQ09ORklHX01PVVNFX1BTMj15CkNPTkZJR19NT1VTRV9Q UzJfQUxQUz15CkNPTkZJR19NT1VTRV9QUzJfQllEPXkKQ09ORklHX01PVVNFX1BTMl9MT0dJUFMy UFA9eQpDT05GSUdfTU9VU0VfUFMyX1NZTkFQVElDUz15CkNPTkZJR19NT1VTRV9QUzJfU1lOQVBU SUNTX1NNQlVTPXkKQ09ORklHX01PVVNFX1BTMl9DWVBSRVNTPXkKQ09ORklHX01PVVNFX1BTMl9U UkFDS1BPSU5UPXkKIyBDT05GSUdfTU9VU0VfUFMyX0VMQU5URUNIIGlzIG5vdCBzZXQKIyBDT05G SUdfTU9VU0VfUFMyX1NFTlRFTElDIGlzIG5vdCBzZXQKIyBDT05GSUdfTU9VU0VfUFMyX1RPVUNI S0lUIGlzIG5vdCBzZXQKQ09ORklHX01PVVNFX1BTMl9GT0NBTFRFQ0g9eQpDT05GSUdfTU9VU0Vf UFMyX1NNQlVTPXkKIyBDT05GSUdfTU9VU0VfU0VSSUFMIGlzIG5vdCBzZXQKIyBDT05GSUdfTU9V U0VfQ1lBUEEgaXMgbm90IHNldAojIENPTkZJR19NT1VTRV9FTEFOX0kyQyBpcyBub3Qgc2V0CiMg Q09ORklHX01PVVNFX1ZTWFhYQUEgaXMgbm90IHNldAojIENPTkZJR19NT1VTRV9HUElPIGlzIG5v dCBzZXQKIyBDT05GSUdfTU9VU0VfU1lOQVBUSUNTX0kyQyBpcyBub3Qgc2V0CiMgQ09ORklHX0lO UFVUX0pPWVNUSUNLIGlzIG5vdCBzZXQKIyBDT05GSUdfSU5QVVRfVEFCTEVUIGlzIG5vdCBzZXQK IyBDT05GSUdfSU5QVVRfVE9VQ0hTQ1JFRU4gaXMgbm90IHNldAojIENPTkZJR19JTlBVVF9NSVND IGlzIG5vdCBzZXQKIyBDT05GSUdfUk1JNF9DT1JFIGlzIG5vdCBzZXQKCiMKIyBIYXJkd2FyZSBJ L08gcG9ydHMKIwpDT05GSUdfU0VSSU89eQpDT05GSUdfU0VSSU9fU0VSUE9SVD15CiMgQ09ORklH X1NFUklPX0FNQkFLTUkgaXMgbm90IHNldApDT05GSUdfU0VSSU9fTElCUFMyPXkKIyBDT05GSUdf U0VSSU9fUkFXIGlzIG5vdCBzZXQKIyBDT05GSUdfU0VSSU9fQUxURVJBX1BTMiBpcyBub3Qgc2V0 CiMgQ09ORklHX1NFUklPX1BTMk1VTFQgaXMgbm90IHNldAojIENPTkZJR19TRVJJT19BUkNfUFMy IGlzIG5vdCBzZXQKIyBDT05GSUdfU0VSSU9fQVBCUFMyIGlzIG5vdCBzZXQKIyBDT05GSUdfU0VS SU9fR1BJT19QUzIgaXMgbm90IHNldAojIENPTkZJR19VU0VSSU8gaXMgbm90IHNldAojIENPTkZJ R19HQU1FUE9SVCBpcyBub3Qgc2V0CiMgZW5kIG9mIEhhcmR3YXJlIEkvTyBwb3J0cwojIGVuZCBv ZiBJbnB1dCBkZXZpY2Ugc3VwcG9ydAoKIwojIENoYXJhY3RlciBkZXZpY2VzCiMKQ09ORklHX1RU WT15CkNPTkZJR19WVD15CkNPTkZJR19DT05TT0xFX1RSQU5TTEFUSU9OUz15CkNPTkZJR19WVF9D T05TT0xFPXkKQ09ORklHX1ZUX0NPTlNPTEVfU0xFRVA9eQpDT05GSUdfSFdfQ09OU09MRT15CkNP TkZJR19WVF9IV19DT05TT0xFX0JJTkRJTkc9eQpDT05GSUdfVU5JWDk4X1BUWVM9eQojIENPTkZJ R19MRUdBQ1lfUFRZUyBpcyBub3Qgc2V0CkNPTkZJR19MRElTQ19BVVRPTE9BRD15CgojCiMgU2Vy aWFsIGRyaXZlcnMKIwpDT05GSUdfU0VSSUFMX0VBUkxZQ09OPXkKQ09ORklHX1NFUklBTF84MjUw PXkKQ09ORklHX1NFUklBTF84MjUwX0RFUFJFQ0FURURfT1BUSU9OUz15CkNPTkZJR19TRVJJQUxf ODI1MF8xNjU1MEFfVkFSSUFOVFM9eQojIENPTkZJR19TRVJJQUxfODI1MF9GSU5URUsgaXMgbm90 IHNldApDT05GSUdfU0VSSUFMXzgyNTBfQ09OU09MRT15CkNPTkZJR19TRVJJQUxfODI1MF9ETUE9 eQpDT05GSUdfU0VSSUFMXzgyNTBfTlJfVUFSVFM9NApDT05GSUdfU0VSSUFMXzgyNTBfUlVOVElN RV9VQVJUUz00CkNPTkZJR19TRVJJQUxfODI1MF9FWFRFTkRFRD15CiMgQ09ORklHX1NFUklBTF84 MjUwX01BTllfUE9SVFMgaXMgbm90IHNldApDT05GSUdfU0VSSUFMXzgyNTBfU0hBUkVfSVJRPXkK IyBDT05GSUdfU0VSSUFMXzgyNTBfREVURUNUX0lSUSBpcyBub3Qgc2V0CiMgQ09ORklHX1NFUklB TF84MjUwX1JTQSBpcyBub3Qgc2V0CkNPTkZJR19TRVJJQUxfODI1MF9EV0xJQj15CkNPTkZJR19T RVJJQUxfODI1MF9GU0w9eQpDT05GSUdfU0VSSUFMXzgyNTBfRFc9eQojIENPTkZJR19TRVJJQUxf ODI1MF9SVDI4OFggaXMgbm90IHNldApDT05GSUdfU0VSSUFMX09GX1BMQVRGT1JNPXkKCiMKIyBO b24tODI1MCBzZXJpYWwgcG9ydCBzdXBwb3J0CiMKIyBDT05GSUdfU0VSSUFMX0FNQkFfUEwwMTAg aXMgbm90IHNldAojIENPTkZJR19TRVJJQUxfQU1CQV9QTDAxMSBpcyBub3Qgc2V0CiMgQ09ORklH X1NFUklBTF9FQVJMWUNPTl9BUk1fU0VNSUhPU1QgaXMgbm90IHNldApDT05GSUdfU0VSSUFMX1VB UlRMSVRFPXkKQ09ORklHX1NFUklBTF9VQVJUTElURV9DT05TT0xFPXkKQ09ORklHX1NFUklBTF9V QVJUTElURV9OUl9VQVJUUz04CkNPTkZJR19TRVJJQUxfQ09SRT15CkNPTkZJR19TRVJJQUxfQ09S RV9DT05TT0xFPXkKIyBDT05GSUdfU0VSSUFMX1NJRklWRSBpcyBub3Qgc2V0CiMgQ09ORklHX1NF UklBTF9TQ0NOWFAgaXMgbm90IHNldAojIENPTkZJR19TRVJJQUxfU0MxNklTN1hYIGlzIG5vdCBz ZXQKIyBDT05GSUdfU0VSSUFMX0JDTTYzWFggaXMgbm90IHNldAojIENPTkZJR19TRVJJQUxfQUxU RVJBX0pUQUdVQVJUIGlzIG5vdCBzZXQKIyBDT05GSUdfU0VSSUFMX0FMVEVSQV9VQVJUIGlzIG5v dCBzZXQKQ09ORklHX1NFUklBTF9YSUxJTlhfUFNfVUFSVD15CkNPTkZJR19TRVJJQUxfWElMSU5Y X1BTX1VBUlRfQ09OU09MRT15CiMgQ09ORklHX1NFUklBTF9BUkMgaXMgbm90IHNldAojIENPTkZJ R19TRVJJQUxfRlNMX0xQVUFSVCBpcyBub3Qgc2V0CiMgQ09ORklHX1NFUklBTF9GU0xfTElORkxF WFVBUlQgaXMgbm90IHNldAojIENPTkZJR19TRVJJQUxfQ09ORVhBTlRfRElHSUNPTE9SIGlzIG5v dCBzZXQKIyBDT05GSUdfU0VSSUFMX1NQUkQgaXMgbm90IHNldAojIGVuZCBvZiBTZXJpYWwgZHJp dmVycwoKQ09ORklHX1NFUklBTF9NQ1RSTF9HUElPPXkKIyBDT05GSUdfU0VSSUFMX05PTlNUQU5E QVJEIGlzIG5vdCBzZXQKIyBDT05GSUdfTlVMTF9UVFkgaXMgbm90IHNldAojIENPTkZJR19IVkNf RENDIGlzIG5vdCBzZXQKQ09ORklHX1NFUklBTF9ERVZfQlVTPXkKQ09ORklHX1NFUklBTF9ERVZf Q1RSTF9UVFlQT1JUPXkKIyBDT05GSUdfVFRZX1BSSU5USyBpcyBub3Qgc2V0CiMgQ09ORklHX1ZJ UlRJT19DT05TT0xFIGlzIG5vdCBzZXQKIyBDT05GSUdfSVBNSV9IQU5ETEVSIGlzIG5vdCBzZXQK IyBDT05GSUdfSVBNQl9ERVZJQ0VfSU5URVJGQUNFIGlzIG5vdCBzZXQKIyBDT05GSUdfSFdfUkFO RE9NIGlzIG5vdCBzZXQKQ09ORklHX0RFVk1FTT15CkNPTkZJR19UQ0dfVFBNPXkKIyBDT05GSUdf VENHX1RJUyBpcyBub3Qgc2V0CiMgQ09ORklHX1RDR19USVNfSTJDX0NSNTAgaXMgbm90IHNldAoj IENPTkZJR19UQ0dfVElTX0kyQ19BVE1FTCBpcyBub3Qgc2V0CiMgQ09ORklHX1RDR19USVNfSTJD X0lORklORU9OIGlzIG5vdCBzZXQKIyBDT05GSUdfVENHX1RJU19JMkNfTlVWT1RPTiBpcyBub3Qg c2V0CiMgQ09ORklHX1RDR19WVFBNX1BST1hZIGlzIG5vdCBzZXQKIyBDT05GSUdfVENHX1RJU19T VDMzWlAyNF9JMkMgaXMgbm90IHNldAojIENPTkZJR19YSUxMWUJVUyBpcyBub3Qgc2V0CiMgZW5k IG9mIENoYXJhY3RlciBkZXZpY2VzCgojIENPTkZJR19SQU5ET01fVFJVU1RfQ1BVIGlzIG5vdCBz ZXQKIyBDT05GSUdfUkFORE9NX1RSVVNUX0JPT1RMT0FERVIgaXMgbm90IHNldAoKIwojIEkyQyBz dXBwb3J0CiMKQ09ORklHX0kyQz15CkNPTkZJR19JMkNfQk9BUkRJTkZPPXkKQ09ORklHX0kyQ19D T01QQVQ9eQpDT05GSUdfSTJDX0NIQVJERVY9eQpDT05GSUdfSTJDX01VWD15CgojCiMgTXVsdGlw bGV4ZXIgSTJDIENoaXAgc3VwcG9ydAojCiMgQ09ORklHX0kyQ19BUkJfR1BJT19DSEFMTEVOR0Ug aXMgbm90IHNldAojIENPTkZJR19JMkNfTVVYX0dQSU8gaXMgbm90IHNldAojIENPTkZJR19JMkNf TVVYX0dQTVVYIGlzIG5vdCBzZXQKIyBDT05GSUdfSTJDX01VWF9MVEM0MzA2IGlzIG5vdCBzZXQK IyBDT05GSUdfSTJDX01VWF9QQ0E5NTQxIGlzIG5vdCBzZXQKQ09ORklHX0kyQ19NVVhfUENBOTU0 eD15CiMgQ09ORklHX0kyQ19NVVhfUkVHIGlzIG5vdCBzZXQKIyBDT05GSUdfSTJDX01VWF9NTFhD UExEIGlzIG5vdCBzZXQKIyBlbmQgb2YgTXVsdGlwbGV4ZXIgSTJDIENoaXAgc3VwcG9ydAoKQ09O RklHX0kyQ19IRUxQRVJfQVVUTz15CgojCiMgSTJDIEhhcmR3YXJlIEJ1cyBzdXBwb3J0CiMKCiMK IyBJMkMgc3lzdGVtIGJ1cyBkcml2ZXJzIChtb3N0bHkgZW1iZWRkZWQgLyBzeXN0ZW0tb24tY2hp cCkKIwpDT05GSUdfSTJDX0NBREVOQ0U9eQojIENPTkZJR19JMkNfQ0JVU19HUElPIGlzIG5vdCBz ZXQKIyBDT05GSUdfSTJDX0RFU0lHTldBUkVfUExBVEZPUk0gaXMgbm90IHNldAojIENPTkZJR19J MkNfRU1FVjIgaXMgbm90IHNldAojIENPTkZJR19JMkNfR1BJTyBpcyBub3Qgc2V0CiMgQ09ORklH X0kyQ19OT01BRElLIGlzIG5vdCBzZXQKIyBDT05GSUdfSTJDX09DT1JFUyBpcyBub3Qgc2V0CiMg Q09ORklHX0kyQ19QQ0FfUExBVEZPUk0gaXMgbm90IHNldAojIENPTkZJR19JMkNfUkszWCBpcyBu b3Qgc2V0CiMgQ09ORklHX0kyQ19TSU1URUMgaXMgbm90IHNldApDT05GSUdfSTJDX1hJTElOWD15 CgojCiMgRXh0ZXJuYWwgSTJDL1NNQnVzIGFkYXB0ZXIgZHJpdmVycwojCiMgQ09ORklHX0kyQ19U QU9TX0VWTSBpcyBub3Qgc2V0CgojCiMgT3RoZXIgSTJDL1NNQnVzIGJ1cyBkcml2ZXJzCiMKIyBl bmQgb2YgSTJDIEhhcmR3YXJlIEJ1cyBzdXBwb3J0CgpDT05GSUdfSTJDX1NMQVZFPXkKQ09ORklH X0kyQ19TTEFWRV9FRVBST009eQojIENPTkZJR19JMkNfU0xBVkVfVEVTVFVOSVQgaXMgbm90IHNl dAojIENPTkZJR19JMkNfREVCVUdfQ09SRSBpcyBub3Qgc2V0CiMgQ09ORklHX0kyQ19ERUJVR19B TEdPIGlzIG5vdCBzZXQKIyBDT05GSUdfSTJDX0RFQlVHX0JVUyBpcyBub3Qgc2V0CiMgZW5kIG9m IEkyQyBzdXBwb3J0CgojIENPTkZJR19JM0MgaXMgbm90IHNldAojIENPTkZJR19TUEkgaXMgbm90 IHNldAojIENPTkZJR19TUE1JIGlzIG5vdCBzZXQKIyBDT05GSUdfSFNJIGlzIG5vdCBzZXQKIyBD T05GSUdfUFBTIGlzIG5vdCBzZXQKCiMKIyBQVFAgY2xvY2sgc3VwcG9ydAojCgojCiMgRW5hYmxl IFBIWUxJQiBhbmQgTkVUV09SS19QSFlfVElNRVNUQU1QSU5HIHRvIHNlZSB0aGUgYWRkaXRpb25h bCBjbG9ja3MuCiMKIyBlbmQgb2YgUFRQIGNsb2NrIHN1cHBvcnQKCiMgQ09ORklHX1BJTkNUUkwg aXMgbm90IHNldApDT05GSUdfR1BJT0xJQj15CkNPTkZJR19HUElPTElCX0ZBU1RQQVRIX0xJTUlU PTUxMgpDT05GSUdfT0ZfR1BJTz15CkNPTkZJR19HUElPTElCX0lSUUNISVA9eQojIENPTkZJR19E RUJVR19HUElPIGlzIG5vdCBzZXQKQ09ORklHX0dQSU9fU1lTRlM9eQpDT05GSUdfR1BJT19DREVW PXkKQ09ORklHX0dQSU9fQ0RFVl9WMT15CgojCiMgTWVtb3J5IG1hcHBlZCBHUElPIGRyaXZlcnMK IwojIENPTkZJR19HUElPXzc0WFhfTU1JTyBpcyBub3Qgc2V0CiMgQ09ORklHX0dQSU9fQUxURVJB IGlzIG5vdCBzZXQKIyBDT05GSUdfR1BJT19DQURFTkNFIGlzIG5vdCBzZXQKIyBDT05GSUdfR1BJ T19EV0FQQiBpcyBub3Qgc2V0CiMgQ09ORklHX0dQSU9fRlRHUElPMDEwIGlzIG5vdCBzZXQKIyBD T05GSUdfR1BJT19HRU5FUklDX1BMQVRGT1JNIGlzIG5vdCBzZXQKIyBDT05GSUdfR1BJT19HUkdQ SU8gaXMgbm90IHNldAojIENPTkZJR19HUElPX0hMV0QgaXMgbm90IHNldAojIENPTkZJR19HUElP X01CODZTN1ggaXMgbm90IHNldAojIENPTkZJR19HUElPX1BMMDYxIGlzIG5vdCBzZXQKIyBDT05G SUdfR1BJT19TSUZJVkUgaXMgbm90IHNldAojIENPTkZJR19HUElPX1hHRU5FIGlzIG5vdCBzZXQK Q09ORklHX0dQSU9fWElMSU5YPXkKQ09ORklHX0dQSU9fWllOUT15CiMgQ09ORklHX0dQSU9fQU1E X0ZDSCBpcyBub3Qgc2V0CiMgZW5kIG9mIE1lbW9yeSBtYXBwZWQgR1BJTyBkcml2ZXJzCgojCiMg STJDIEdQSU8gZXhwYW5kZXJzCiMKIyBDT05GSUdfR1BJT19BRFA1NTg4IGlzIG5vdCBzZXQKIyBD T05GSUdfR1BJT19BRE5QIGlzIG5vdCBzZXQKIyBDT05GSUdfR1BJT19HV19QTEQgaXMgbm90IHNl dAojIENPTkZJR19HUElPX01BWDczMDAgaXMgbm90IHNldAojIENPTkZJR19HUElPX01BWDczMlgg aXMgbm90IHNldApDT05GSUdfR1BJT19QQ0E5NTNYPXkKIyBDT05GSUdfR1BJT19QQ0E5NTNYX0lS USBpcyBub3Qgc2V0CiMgQ09ORklHX0dQSU9fUENBOTU3MCBpcyBub3Qgc2V0CiMgQ09ORklHX0dQ SU9fUENGODU3WCBpcyBub3Qgc2V0CiMgQ09ORklHX0dQSU9fVFBJQzI4MTAgaXMgbm90IHNldAoj IGVuZCBvZiBJMkMgR1BJTyBleHBhbmRlcnMKCiMKIyBNRkQgR1BJTyBleHBhbmRlcnMKIwpDT05G SUdfR1BJT19UUFM2NTA4Nj15CiMgZW5kIG9mIE1GRCBHUElPIGV4cGFuZGVycwoKIwojIFZpcnR1 YWwgR1BJTyBkcml2ZXJzCiMKIyBDT05GSUdfR1BJT19BR0dSRUdBVE9SIGlzIG5vdCBzZXQKIyBD T05GSUdfR1BJT19NT0NLVVAgaXMgbm90IHNldAojIGVuZCBvZiBWaXJ0dWFsIEdQSU8gZHJpdmVy cwoKIyBDT05GSUdfVzEgaXMgbm90IHNldApDT05GSUdfUE9XRVJfUkVTRVQ9eQojIENPTkZJR19Q T1dFUl9SRVNFVF9HUElPIGlzIG5vdCBzZXQKIyBDT05GSUdfUE9XRVJfUkVTRVRfR1BJT19SRVNU QVJUIGlzIG5vdCBzZXQKQ09ORklHX1BPV0VSX1JFU0VUX0xUQzI5NTI9eQojIENPTkZJR19QT1dF Ul9SRVNFVF9SRUdVTEFUT1IgaXMgbm90IHNldAojIENPTkZJR19QT1dFUl9SRVNFVF9SRVNUQVJU IGlzIG5vdCBzZXQKIyBDT05GSUdfUE9XRVJfUkVTRVRfWEdFTkUgaXMgbm90IHNldAojIENPTkZJ R19QT1dFUl9SRVNFVF9TWVNDT04gaXMgbm90IHNldAojIENPTkZJR19QT1dFUl9SRVNFVF9TWVND T05fUE9XRVJPRkYgaXMgbm90IHNldAojIENPTkZJR19OVk1FTV9SRUJPT1RfTU9ERSBpcyBub3Qg c2V0CkNPTkZJR19QT1dFUl9TVVBQTFk9eQojIENPTkZJR19QT1dFUl9TVVBQTFlfREVCVUcgaXMg bm90IHNldApDT05GSUdfUE9XRVJfU1VQUExZX0hXTU9OPXkKIyBDT05GSUdfUERBX1BPV0VSIGlz IG5vdCBzZXQKIyBDT05GSUdfR0VORVJJQ19BRENfQkFUVEVSWSBpcyBub3Qgc2V0CiMgQ09ORklH X1RFU1RfUE9XRVIgaXMgbm90IHNldAojIENPTkZJR19DSEFSR0VSX0FEUDUwNjEgaXMgbm90IHNl dAojIENPTkZJR19CQVRURVJZX0NXMjAxNSBpcyBub3Qgc2V0CiMgQ09ORklHX0JBVFRFUllfRFMy NzgwIGlzIG5vdCBzZXQKIyBDT05GSUdfQkFUVEVSWV9EUzI3ODEgaXMgbm90IHNldAojIENPTkZJ R19CQVRURVJZX0RTMjc4MiBpcyBub3Qgc2V0CiMgQ09ORklHX0JBVFRFUllfU0JTIGlzIG5vdCBz ZXQKIyBDT05GSUdfQ0hBUkdFUl9TQlMgaXMgbm90IHNldAojIENPTkZJR19NQU5BR0VSX1NCUyBp cyBub3Qgc2V0CiMgQ09ORklHX0JBVFRFUllfQlEyN1hYWCBpcyBub3Qgc2V0CiMgQ09ORklHX0JB VFRFUllfTUFYMTcwNDAgaXMgbm90IHNldAojIENPTkZJR19CQVRURVJZX01BWDE3MDQyIGlzIG5v dCBzZXQKIyBDT05GSUdfQ0hBUkdFUl9NQVg4OTAzIGlzIG5vdCBzZXQKIyBDT05GSUdfQ0hBUkdF Ul9MUDg3MjcgaXMgbm90IHNldAojIENPTkZJR19DSEFSR0VSX0dQSU8gaXMgbm90IHNldAojIENP TkZJR19DSEFSR0VSX01BTkFHRVIgaXMgbm90IHNldAojIENPTkZJR19DSEFSR0VSX0xUMzY1MSBp cyBub3Qgc2V0CiMgQ09ORklHX0NIQVJHRVJfTFRDNDE2MkwgaXMgbm90IHNldAojIENPTkZJR19D SEFSR0VSX0RFVEVDVE9SX01BWDE0NjU2IGlzIG5vdCBzZXQKIyBDT05GSUdfQ0hBUkdFUl9CUTI0 MTVYIGlzIG5vdCBzZXQKIyBDT05GSUdfQ0hBUkdFUl9CUTI0MTkwIGlzIG5vdCBzZXQKIyBDT05G SUdfQ0hBUkdFUl9CUTI0MjU3IGlzIG5vdCBzZXQKIyBDT05GSUdfQ0hBUkdFUl9CUTI0NzM1IGlz IG5vdCBzZXQKIyBDT05GSUdfQ0hBUkdFUl9CUTI1MTVYIGlzIG5vdCBzZXQKIyBDT05GSUdfQ0hB UkdFUl9CUTI1ODkwIGlzIG5vdCBzZXQKIyBDT05GSUdfQ0hBUkdFUl9CUTI1OTgwIGlzIG5vdCBz ZXQKIyBDT05GSUdfQ0hBUkdFUl9CUTI1NlhYIGlzIG5vdCBzZXQKIyBDT05GSUdfQ0hBUkdFUl9T TUIzNDcgaXMgbm90IHNldAojIENPTkZJR19CQVRURVJZX0dBVUdFX0xUQzI5NDEgaXMgbm90IHNl dAojIENPTkZJR19CQVRURVJZX0dPTERGSVNIIGlzIG5vdCBzZXQKIyBDT05GSUdfQkFUVEVSWV9S VDUwMzMgaXMgbm90IHNldAojIENPTkZJR19DSEFSR0VSX1JUOTQ1NSBpcyBub3Qgc2V0CiMgQ09O RklHX0NIQVJHRVJfVUNTMTAwMiBpcyBub3Qgc2V0CiMgQ09ORklHX0NIQVJHRVJfQkQ5OTk1NCBp cyBub3Qgc2V0CkNPTkZJR19IV01PTj15CiMgQ09ORklHX0hXTU9OX0RFQlVHX0NISVAgaXMgbm90 IHNldAoKIwojIE5hdGl2ZSBkcml2ZXJzCiMKIyBDT05GSUdfU0VOU09SU19BRDc0MTQgaXMgbm90 IHNldAojIENPTkZJR19TRU5TT1JTX0FENzQxOCBpcyBub3Qgc2V0CiMgQ09ORklHX1NFTlNPUlNf QURNMTAyMSBpcyBub3Qgc2V0CiMgQ09ORklHX1NFTlNPUlNfQURNMTAyNSBpcyBub3Qgc2V0CiMg Q09ORklHX1NFTlNPUlNfQURNMTAyNiBpcyBub3Qgc2V0CiMgQ09ORklHX1NFTlNPUlNfQURNMTAy OSBpcyBub3Qgc2V0CiMgQ09ORklHX1NFTlNPUlNfQURNMTAzMSBpcyBub3Qgc2V0CiMgQ09ORklH X1NFTlNPUlNfQURNMTE3NyBpcyBub3Qgc2V0CiMgQ09ORklHX1NFTlNPUlNfQURNOTI0MCBpcyBu b3Qgc2V0CiMgQ09ORklHX1NFTlNPUlNfQURUNzQxMCBpcyBub3Qgc2V0CiMgQ09ORklHX1NFTlNP UlNfQURUNzQxMSBpcyBub3Qgc2V0CiMgQ09ORklHX1NFTlNPUlNfQURUNzQ2MiBpcyBub3Qgc2V0 CiMgQ09ORklHX1NFTlNPUlNfQURUNzQ3MCBpcyBub3Qgc2V0CiMgQ09ORklHX1NFTlNPUlNfQURU NzQ3NSBpcyBub3Qgc2V0CiMgQ09ORklHX1NFTlNPUlNfQUhUMTAgaXMgbm90IHNldAojIENPTkZJ R19TRU5TT1JTX0FTMzcwIGlzIG5vdCBzZXQKIyBDT05GSUdfU0VOU09SU19BU0M3NjIxIGlzIG5v dCBzZXQKIyBDT05GSUdfU0VOU09SU19BWElfRkFOX0NPTlRST0wgaXMgbm90IHNldAojIENPTkZJ R19TRU5TT1JTX0FTUEVFRCBpcyBub3Qgc2V0CiMgQ09ORklHX1NFTlNPUlNfQVRYUDEgaXMgbm90 IHNldAojIENPTkZJR19TRU5TT1JTX0NPUlNBSVJfQ1BSTyBpcyBub3Qgc2V0CiMgQ09ORklHX1NF TlNPUlNfQ09SU0FJUl9QU1UgaXMgbm90IHNldAojIENPTkZJR19TRU5TT1JTX0RTNjIwIGlzIG5v dCBzZXQKIyBDT05GSUdfU0VOU09SU19EUzE2MjEgaXMgbm90IHNldAojIENPTkZJR19TRU5TT1JT X0Y3MTgwNUYgaXMgbm90IHNldAojIENPTkZJR19TRU5TT1JTX0Y3MTg4MkZHIGlzIG5vdCBzZXQK IyBDT05GSUdfU0VOU09SU19GNzUzNzVTIGlzIG5vdCBzZXQKIyBDT05GSUdfU0VOU09SU19GVFNU RVVUQVRFUyBpcyBub3Qgc2V0CiMgQ09ORklHX1NFTlNPUlNfR0w1MThTTSBpcyBub3Qgc2V0CiMg Q09ORklHX1NFTlNPUlNfR0w1MjBTTSBpcyBub3Qgc2V0CiMgQ09ORklHX1NFTlNPUlNfRzc2MEEg aXMgbm90IHNldAojIENPTkZJR19TRU5TT1JTX0c3NjIgaXMgbm90IHNldAojIENPTkZJR19TRU5T T1JTX0dQSU9fRkFOIGlzIG5vdCBzZXQKIyBDT05GSUdfU0VOU09SU19ISUg2MTMwIGlzIG5vdCBz ZXQKQ09ORklHX1NFTlNPUlNfSUlPX0hXTU9OPXkKIyBDT05GSUdfU0VOU09SU19JVDg3IGlzIG5v dCBzZXQKIyBDT05GSUdfU0VOU09SU19KQzQyIGlzIG5vdCBzZXQKIyBDT05GSUdfU0VOU09SU19Q T1dSMTIyMCBpcyBub3Qgc2V0CiMgQ09ORklHX1NFTlNPUlNfTElORUFHRSBpcyBub3Qgc2V0CiMg Q09ORklHX1NFTlNPUlNfTFRDMjk0NSBpcyBub3Qgc2V0CiMgQ09ORklHX1NFTlNPUlNfTFRDMjk0 N19JMkMgaXMgbm90IHNldAojIENPTkZJR19TRU5TT1JTX0xUQzI5OTAgaXMgbm90IHNldAojIENP TkZJR19TRU5TT1JTX0xUQzI5OTIgaXMgbm90IHNldAojIENPTkZJR19TRU5TT1JTX0xUQzQxNTEg aXMgbm90IHNldAojIENPTkZJR19TRU5TT1JTX0xUQzQyMTUgaXMgbm90IHNldAojIENPTkZJR19T RU5TT1JTX0xUQzQyMjIgaXMgbm90IHNldAojIENPTkZJR19TRU5TT1JTX0xUQzQyNDUgaXMgbm90 IHNldAojIENPTkZJR19TRU5TT1JTX0xUQzQyNjAgaXMgbm90IHNldAojIENPTkZJR19TRU5TT1JT X0xUQzQyNjEgaXMgbm90IHNldAojIENPTkZJR19TRU5TT1JTX01BWDEyNyBpcyBub3Qgc2V0CiMg Q09ORklHX1NFTlNPUlNfTUFYMTYwNjUgaXMgbm90IHNldAojIENPTkZJR19TRU5TT1JTX01BWDE2 MTkgaXMgbm90IHNldAojIENPTkZJR19TRU5TT1JTX01BWDE2NjggaXMgbm90IHNldAojIENPTkZJ R19TRU5TT1JTX01BWDE5NyBpcyBub3Qgc2V0CiMgQ09ORklHX1NFTlNPUlNfTUFYMzE3MzAgaXMg bm90IHNldAojIENPTkZJR19TRU5TT1JTX01BWDY2MjEgaXMgbm90IHNldAojIENPTkZJR19TRU5T T1JTX01BWDY2MzkgaXMgbm90IHNldAojIENPTkZJR19TRU5TT1JTX01BWDY2NDIgaXMgbm90IHNl dAojIENPTkZJR19TRU5TT1JTX01BWDY2NTAgaXMgbm90IHNldAojIENPTkZJR19TRU5TT1JTX01B WDY2OTcgaXMgbm90IHNldAojIENPTkZJR19TRU5TT1JTX01BWDMxNzkwIGlzIG5vdCBzZXQKIyBD T05GSUdfU0VOU09SU19NQ1AzMDIxIGlzIG5vdCBzZXQKIyBDT05GSUdfU0VOU09SU19UQzY1NCBp cyBub3Qgc2V0CiMgQ09ORklHX1NFTlNPUlNfVFBTMjM4NjEgaXMgbm90IHNldAojIENPTkZJR19T RU5TT1JTX01SNzUyMDMgaXMgbm90IHNldApDT05GSUdfU0VOU09SU19MTTYzPXkKIyBDT05GSUdf U0VOU09SU19MTTczIGlzIG5vdCBzZXQKIyBDT05GSUdfU0VOU09SU19MTTc1IGlzIG5vdCBzZXQK IyBDT05GSUdfU0VOU09SU19MTTc3IGlzIG5vdCBzZXQKIyBDT05GSUdfU0VOU09SU19MTTc4IGlz IG5vdCBzZXQKIyBDT05GSUdfU0VOU09SU19MTTgwIGlzIG5vdCBzZXQKIyBDT05GSUdfU0VOU09S U19MTTgzIGlzIG5vdCBzZXQKIyBDT05GSUdfU0VOU09SU19MTTg1IGlzIG5vdCBzZXQKIyBDT05G SUdfU0VOU09SU19MTTg3IGlzIG5vdCBzZXQKIyBDT05GSUdfU0VOU09SU19MTTkwIGlzIG5vdCBz ZXQKIyBDT05GSUdfU0VOU09SU19MTTkyIGlzIG5vdCBzZXQKIyBDT05GSUdfU0VOU09SU19MTTkz IGlzIG5vdCBzZXQKIyBDT05GSUdfU0VOU09SU19MTTk1MjM0IGlzIG5vdCBzZXQKIyBDT05GSUdf U0VOU09SU19MTTk1MjQxIGlzIG5vdCBzZXQKIyBDT05GSUdfU0VOU09SU19MTTk1MjQ1IGlzIG5v dCBzZXQKIyBDT05GSUdfU0VOU09SU19QQzg3MzYwIGlzIG5vdCBzZXQKIyBDT05GSUdfU0VOU09S U19QQzg3NDI3IGlzIG5vdCBzZXQKIyBDT05GSUdfU0VOU09SU19OVENfVEhFUk1JU1RPUiBpcyBu b3Qgc2V0CiMgQ09ORklHX1NFTlNPUlNfTkNUNjY4MyBpcyBub3Qgc2V0CiMgQ09ORklHX1NFTlNP UlNfTkNUNjc3NSBpcyBub3Qgc2V0CiMgQ09ORklHX1NFTlNPUlNfTkNUNzgwMiBpcyBub3Qgc2V0 CiMgQ09ORklHX1NFTlNPUlNfTkNUNzkwNCBpcyBub3Qgc2V0CiMgQ09ORklHX1NFTlNPUlNfTlBD TTdYWCBpcyBub3Qgc2V0CiMgQ09ORklHX1NFTlNPUlNfT0NDX1A4X0kyQyBpcyBub3Qgc2V0CiMg Q09ORklHX1NFTlNPUlNfUENGODU5MSBpcyBub3Qgc2V0CkNPTkZJR19QTUJVUz15CkNPTkZJR19T RU5TT1JTX1BNQlVTPXkKIyBDT05GSUdfU0VOU09SU19BRE0xMjY2IGlzIG5vdCBzZXQKIyBDT05G SUdfU0VOU09SU19BRE0xMjc1IGlzIG5vdCBzZXQKIyBDT05GSUdfU0VOU09SU19CRUxfUEZFIGlz IG5vdCBzZXQKIyBDT05GSUdfU0VOU09SU19CUEFfUlM2MDAgaXMgbm90IHNldAojIENPTkZJR19T RU5TT1JTX0ZTUF8zWSBpcyBub3Qgc2V0CiMgQ09ORklHX1NFTlNPUlNfSUJNX0NGRlBTIGlzIG5v dCBzZXQKIyBDT05GSUdfU0VOU09SU19EUFM5MjBBQiBpcyBub3Qgc2V0CiMgQ09ORklHX1NFTlNP UlNfSU5TUFVSX0lQU1BTIGlzIG5vdCBzZXQKIyBDT05GSUdfU0VOU09SU19JUjM1MjIxIGlzIG5v dCBzZXQKIyBDT05GSUdfU0VOU09SU19JUjM2MDIxIGlzIG5vdCBzZXQKIyBDT05GSUdfU0VOU09S U19JUjM4MDY0IGlzIG5vdCBzZXQKQ09ORklHX1NFTlNPUlNfSVJQUzU0MDE9eQojIENPTkZJR19T RU5TT1JTX0lTTDY4MTM3IGlzIG5vdCBzZXQKIyBDT05GSUdfU0VOU09SU19MTTI1MDY2IGlzIG5v dCBzZXQKIyBDT05GSUdfU0VOU09SU19MVEMyOTc4IGlzIG5vdCBzZXQKIyBDT05GSUdfU0VOU09S U19MVEMzODE1IGlzIG5vdCBzZXQKIyBDT05GSUdfU0VOU09SU19NQVgxNTMwMSBpcyBub3Qgc2V0 CiMgQ09ORklHX1NFTlNPUlNfTUFYMTYwNjQgaXMgbm90IHNldAojIENPTkZJR19TRU5TT1JTX01B WDE2NjAxIGlzIG5vdCBzZXQKIyBDT05GSUdfU0VOU09SU19NQVgyMDczMCBpcyBub3Qgc2V0CkNP TkZJR19TRU5TT1JTX01BWDIwNzUxPXkKIyBDT05GSUdfU0VOU09SU19NQVgzMTc4NSBpcyBub3Qg c2V0CiMgQ09ORklHX1NFTlNPUlNfTUFYMzQ0NDAgaXMgbm90IHNldAojIENPTkZJR19TRU5TT1JT X01BWDg2ODggaXMgbm90IHNldAojIENPTkZJR19TRU5TT1JTX01QMjg4OCBpcyBub3Qgc2V0CiMg Q09ORklHX1NFTlNPUlNfTVAyOTc1IGlzIG5vdCBzZXQKIyBDT05GSUdfU0VOU09SU19QSU00MzI4 IGlzIG5vdCBzZXQKIyBDT05GSUdfU0VOU09SU19QTTY3NjRUUiBpcyBub3Qgc2V0CiMgQ09ORklH X1NFTlNPUlNfUFhFMTYxMCBpcyBub3Qgc2V0CiMgQ09ORklHX1NFTlNPUlNfUTU0U0oxMDhBMiBp cyBub3Qgc2V0CiMgQ09ORklHX1NFTlNPUlNfU1RQRERDNjAgaXMgbm90IHNldAojIENPTkZJR19T RU5TT1JTX1RQUzQwNDIyIGlzIG5vdCBzZXQKIyBDT05GSUdfU0VOU09SU19UUFM1MzY3OSBpcyBu b3Qgc2V0CiMgQ09ORklHX1NFTlNPUlNfVUNEOTAwMCBpcyBub3Qgc2V0CiMgQ09ORklHX1NFTlNP UlNfVUNEOTIwMCBpcyBub3Qgc2V0CiMgQ09ORklHX1NFTlNPUlNfWERQRTEyMiBpcyBub3Qgc2V0 CiMgQ09ORklHX1NFTlNPUlNfWkw2MTAwIGlzIG5vdCBzZXQKIyBDT05GSUdfU0VOU09SU19TQlRT SSBpcyBub3Qgc2V0CiMgQ09ORklHX1NFTlNPUlNfU0hUMTUgaXMgbm90IHNldAojIENPTkZJR19T RU5TT1JTX1NIVDIxIGlzIG5vdCBzZXQKIyBDT05GSUdfU0VOU09SU19TSFQzeCBpcyBub3Qgc2V0 CiMgQ09ORklHX1NFTlNPUlNfU0hUNHggaXMgbm90IHNldAojIENPTkZJR19TRU5TT1JTX1NIVEMx IGlzIG5vdCBzZXQKIyBDT05GSUdfU0VOU09SU19ETUUxNzM3IGlzIG5vdCBzZXQKIyBDT05GSUdf U0VOU09SU19FTUMxNDAzIGlzIG5vdCBzZXQKIyBDT05GSUdfU0VOU09SU19FTUMyMTAzIGlzIG5v dCBzZXQKIyBDT05GSUdfU0VOU09SU19FTUM2VzIwMSBpcyBub3Qgc2V0CiMgQ09ORklHX1NFTlNP UlNfU01TQzQ3TTEgaXMgbm90IHNldAojIENPTkZJR19TRU5TT1JTX1NNU0M0N00xOTIgaXMgbm90 IHNldAojIENPTkZJR19TRU5TT1JTX1NNU0M0N0IzOTcgaXMgbm90IHNldAojIENPTkZJR19TRU5T T1JTX1NDSDU2MjcgaXMgbm90IHNldAojIENPTkZJR19TRU5TT1JTX1NDSDU2MzYgaXMgbm90IHNl dAojIENPTkZJR19TRU5TT1JTX1NUVFM3NTEgaXMgbm90IHNldAojIENPTkZJR19TRU5TT1JTX1NN TTY2NSBpcyBub3Qgc2V0CiMgQ09ORklHX1NFTlNPUlNfQURDMTI4RDgxOCBpcyBub3Qgc2V0CiMg Q09ORklHX1NFTlNPUlNfQURTNzgyOCBpcyBub3Qgc2V0CiMgQ09ORklHX1NFTlNPUlNfQU1DNjgy MSBpcyBub3Qgc2V0CiMgQ09ORklHX1NFTlNPUlNfSU5BMjA5IGlzIG5vdCBzZXQKIyBDT05GSUdf U0VOU09SU19JTkEyWFggaXMgbm90IHNldAojIENPTkZJR19TRU5TT1JTX0lOQTMyMjEgaXMgbm90 IHNldAojIENPTkZJR19TRU5TT1JTX1RDNzQgaXMgbm90IHNldAojIENPTkZJR19TRU5TT1JTX1RI TUM1MCBpcyBub3Qgc2V0CiMgQ09ORklHX1NFTlNPUlNfVE1QMTAyIGlzIG5vdCBzZXQKIyBDT05G SUdfU0VOU09SU19UTVAxMDMgaXMgbm90IHNldAojIENPTkZJR19TRU5TT1JTX1RNUDEwOCBpcyBu b3Qgc2V0CiMgQ09ORklHX1NFTlNPUlNfVE1QNDAxIGlzIG5vdCBzZXQKIyBDT05GSUdfU0VOU09S U19UTVA0MjEgaXMgbm90IHNldAojIENPTkZJR19TRU5TT1JTX1RNUDUxMyBpcyBub3Qgc2V0CiMg Q09ORklHX1NFTlNPUlNfVlQxMjExIGlzIG5vdCBzZXQKIyBDT05GSUdfU0VOU09SU19XODM3NzNH IGlzIG5vdCBzZXQKIyBDT05GSUdfU0VOU09SU19XODM3ODFEIGlzIG5vdCBzZXQKIyBDT05GSUdf U0VOU09SU19XODM3OTFEIGlzIG5vdCBzZXQKIyBDT05GSUdfU0VOU09SU19XODM3OTJEIGlzIG5v dCBzZXQKIyBDT05GSUdfU0VOU09SU19XODM3OTMgaXMgbm90IHNldAojIENPTkZJR19TRU5TT1JT X1c4Mzc5NSBpcyBub3Qgc2V0CiMgQ09ORklHX1NFTlNPUlNfVzgzTDc4NVRTIGlzIG5vdCBzZXQK IyBDT05GSUdfU0VOU09SU19XODNMNzg2TkcgaXMgbm90IHNldAojIENPTkZJR19TRU5TT1JTX1c4 MzYyN0hGIGlzIG5vdCBzZXQKIyBDT05GSUdfU0VOU09SU19XODM2MjdFSEYgaXMgbm90IHNldAoj IENPTkZJR19USEVSTUFMIGlzIG5vdCBzZXQKQ09ORklHX1dBVENIRE9HPXkKQ09ORklHX1dBVENI RE9HX0NPUkU9eQojIENPTkZJR19XQVRDSERPR19OT1dBWU9VVCBpcyBub3Qgc2V0CkNPTkZJR19X QVRDSERPR19IQU5ETEVfQk9PVF9FTkFCTEVEPXkKQ09ORklHX1dBVENIRE9HX09QRU5fVElNRU9V VD0wCiMgQ09ORklHX1dBVENIRE9HX1NZU0ZTIGlzIG5vdCBzZXQKIyBDT05GSUdfV0FUQ0hET0df SFJUSU1FUl9QUkVUSU1FT1VUIGlzIG5vdCBzZXQKCiMKIyBXYXRjaGRvZyBQcmV0aW1lb3V0IEdv dmVybm9ycwojCiMgQ09ORklHX1dBVENIRE9HX1BSRVRJTUVPVVRfR09WIGlzIG5vdCBzZXQKCiMK IyBXYXRjaGRvZyBEZXZpY2UgRHJpdmVycwojCiMgQ09ORklHX1NPRlRfV0FUQ0hET0cgaXMgbm90 IHNldAojIENPTkZJR19HUElPX1dBVENIRE9HIGlzIG5vdCBzZXQKQ09ORklHX1hJTElOWF9XQVRD SERPRz15CiMgQ09ORklHX1pJSVJBVkVfV0FUQ0hET0cgaXMgbm90IHNldAojIENPTkZJR19BUk1f U1A4MDVfV0FUQ0hET0cgaXMgbm90IHNldAojIENPTkZJR19BUk1fU0JTQV9XQVRDSERPRyBpcyBu b3Qgc2V0CkNPTkZJR19DQURFTkNFX1dBVENIRE9HPXkKIyBDT05GSUdfRFdfV0FUQ0hET0cgaXMg bm90IHNldAojIENPTkZJR19NQVg2M1hYX1dBVENIRE9HIGlzIG5vdCBzZXQKIyBDT05GSUdfQVJN X1NNQ19XQVRDSERPRyBpcyBub3Qgc2V0CiMgQ09ORklHX01FTl9BMjFfV0RUIGlzIG5vdCBzZXQK Q09ORklHX1NTQl9QT1NTSUJMRT15CiMgQ09ORklHX1NTQiBpcyBub3Qgc2V0CkNPTkZJR19CQ01B X1BPU1NJQkxFPXkKIyBDT05GSUdfQkNNQSBpcyBub3Qgc2V0CgojCiMgTXVsdGlmdW5jdGlvbiBk ZXZpY2UgZHJpdmVycwojCkNPTkZJR19NRkRfQ09SRT15CiMgQ09ORklHX01GRF9BQ1Q4OTQ1QSBp cyBub3Qgc2V0CiMgQ09ORklHX01GRF9BUzM3MTEgaXMgbm90IHNldAojIENPTkZJR19NRkRfQVMz NzIyIGlzIG5vdCBzZXQKIyBDT05GSUdfUE1JQ19BRFA1NTIwIGlzIG5vdCBzZXQKIyBDT05GSUdf TUZEX0FBVDI4NzBfQ09SRSBpcyBub3Qgc2V0CiMgQ09ORklHX01GRF9BVE1FTF9GTEVYQ09NIGlz IG5vdCBzZXQKIyBDT05GSUdfTUZEX0FUTUVMX0hMQ0RDIGlzIG5vdCBzZXQKIyBDT05GSUdfTUZE X0JDTTU5MFhYIGlzIG5vdCBzZXQKIyBDT05GSUdfTUZEX0JEOTU3MU1XViBpcyBub3Qgc2V0CiMg Q09ORklHX01GRF9BWFAyMFhfSTJDIGlzIG5vdCBzZXQKIyBDT05GSUdfTUZEX01BREVSQSBpcyBu b3Qgc2V0CiMgQ09ORklHX1BNSUNfREE5MDNYIGlzIG5vdCBzZXQKIyBDT05GSUdfTUZEX0RBOTA1 Ml9JMkMgaXMgbm90IHNldAojIENPTkZJR19NRkRfREE5MDU1IGlzIG5vdCBzZXQKIyBDT05GSUdf TUZEX0RBOTA2MiBpcyBub3Qgc2V0CiMgQ09ORklHX01GRF9EQTkwNjMgaXMgbm90IHNldAojIENP TkZJR19NRkRfREE5MTUwIGlzIG5vdCBzZXQKIyBDT05GSUdfTUZEX0dBVEVXT1JLU19HU0MgaXMg bm90IHNldAojIENPTkZJR19NRkRfTUMxM1hYWF9JMkMgaXMgbm90IHNldAojIENPTkZJR19NRkRf TVAyNjI5IGlzIG5vdCBzZXQKIyBDT05GSUdfTUZEX0hJNjQyMV9QTUlDIGlzIG5vdCBzZXQKIyBD T05GSUdfSFRDX1BBU0lDMyBpcyBub3Qgc2V0CiMgQ09ORklHX0hUQ19JMkNQTEQgaXMgbm90IHNl dAojIENPTkZJR19NRkRfSVFTNjJYIGlzIG5vdCBzZXQKIyBDT05GSUdfTUZEX0tFTVBMRCBpcyBu b3Qgc2V0CiMgQ09ORklHX01GRF84OFBNODAwIGlzIG5vdCBzZXQKIyBDT05GSUdfTUZEXzg4UE04 MDUgaXMgbm90IHNldAojIENPTkZJR19NRkRfODhQTTg2MFggaXMgbm90IHNldAojIENPTkZJR19N RkRfTUFYMTQ1NzcgaXMgbm90IHNldAojIENPTkZJR19NRkRfTUFYNzc2MjAgaXMgbm90IHNldAoj IENPTkZJR19NRkRfTUFYNzc2NTAgaXMgbm90IHNldAojIENPTkZJR19NRkRfTUFYNzc2ODYgaXMg bm90IHNldAojIENPTkZJR19NRkRfTUFYNzc2OTMgaXMgbm90IHNldAojIENPTkZJR19NRkRfTUFY Nzc4NDMgaXMgbm90IHNldAojIENPTkZJR19NRkRfTUFYODkwNyBpcyBub3Qgc2V0CiMgQ09ORklH X01GRF9NQVg4OTI1IGlzIG5vdCBzZXQKIyBDT05GSUdfTUZEX01BWDg5OTcgaXMgbm90IHNldAoj IENPTkZJR19NRkRfTUFYODk5OCBpcyBub3Qgc2V0CiMgQ09ORklHX01GRF9NVDYzNjAgaXMgbm90 IHNldAojIENPTkZJR19NRkRfTVQ2Mzk3IGlzIG5vdCBzZXQKIyBDT05GSUdfTUZEX01FTkYyMUJN QyBpcyBub3Qgc2V0CiMgQ09ORklHX01GRF9OVFhFQyBpcyBub3Qgc2V0CiMgQ09ORklHX01GRF9S RVRVIGlzIG5vdCBzZXQKIyBDT05GSUdfTUZEX1BDRjUwNjMzIGlzIG5vdCBzZXQKIyBDT05GSUdf TUZEX1JUNDgzMSBpcyBub3Qgc2V0CiMgQ09ORklHX01GRF9SVDUwMzMgaXMgbm90IHNldAojIENP TkZJR19NRkRfUkM1VDU4MyBpcyBub3Qgc2V0CiMgQ09ORklHX01GRF9SSzgwOCBpcyBub3Qgc2V0 CiMgQ09ORklHX01GRF9STjVUNjE4IGlzIG5vdCBzZXQKIyBDT05GSUdfTUZEX1NFQ19DT1JFIGlz IG5vdCBzZXQKIyBDT05GSUdfTUZEX1NJNDc2WF9DT1JFIGlzIG5vdCBzZXQKIyBDT05GSUdfTUZE X1NNNTAxIGlzIG5vdCBzZXQKIyBDT05GSUdfTUZEX1NLWTgxNDUyIGlzIG5vdCBzZXQKIyBDT05G SUdfTUZEX1NUTVBFIGlzIG5vdCBzZXQKIyBDT05GSUdfTUZEX1NZU0NPTiBpcyBub3Qgc2V0CiMg Q09ORklHX01GRF9USV9BTTMzNVhfVFNDQURDIGlzIG5vdCBzZXQKIyBDT05GSUdfTUZEX0xQMzk0 MyBpcyBub3Qgc2V0CiMgQ09ORklHX01GRF9MUDg3ODggaXMgbm90IHNldAojIENPTkZJR19NRkRf VElfTE1VIGlzIG5vdCBzZXQKIyBDT05GSUdfTUZEX1BBTE1BUyBpcyBub3Qgc2V0CiMgQ09ORklH X1RQUzYxMDVYIGlzIG5vdCBzZXQKIyBDT05GSUdfVFBTNjUwMTAgaXMgbm90IHNldAojIENPTkZJ R19UUFM2NTA3WCBpcyBub3Qgc2V0CkNPTkZJR19NRkRfVFBTNjUwODY9eQojIENPTkZJR19NRkRf VFBTNjUwOTAgaXMgbm90IHNldAojIENPTkZJR19NRkRfVFBTNjUyMTcgaXMgbm90IHNldAojIENP TkZJR19NRkRfVElfTFA4NzNYIGlzIG5vdCBzZXQKIyBDT05GSUdfTUZEX1RJX0xQODc1NjUgaXMg bm90IHNldAojIENPTkZJR19NRkRfVFBTNjUyMTggaXMgbm90IHNldAojIENPTkZJR19NRkRfVFBT NjU4NlggaXMgbm90IHNldAojIENPTkZJR19NRkRfVFBTNjU5MTAgaXMgbm90IHNldAojIENPTkZJ R19NRkRfVFBTNjU5MTJfSTJDIGlzIG5vdCBzZXQKIyBDT05GSUdfTUZEX1RQUzgwMDMxIGlzIG5v dCBzZXQKIyBDT05GSUdfVFdMNDAzMF9DT1JFIGlzIG5vdCBzZXQKIyBDT05GSUdfVFdMNjA0MF9D T1JFIGlzIG5vdCBzZXQKIyBDT05GSUdfTUZEX1dMMTI3M19DT1JFIGlzIG5vdCBzZXQKIyBDT05G SUdfTUZEX0xNMzUzMyBpcyBub3Qgc2V0CiMgQ09ORklHX01GRF9UQzM1ODlYIGlzIG5vdCBzZXQK IyBDT05GSUdfTUZEX1RRTVg4NiBpcyBub3Qgc2V0CiMgQ09ORklHX01GRF9MT0NITkFHQVIgaXMg bm90IHNldAojIENPTkZJR19NRkRfQVJJWk9OQV9JMkMgaXMgbm90IHNldAojIENPTkZJR19NRkRf V004NDAwIGlzIG5vdCBzZXQKIyBDT05GSUdfTUZEX1dNODMxWF9JMkMgaXMgbm90IHNldAojIENP TkZJR19NRkRfV004MzUwX0kyQyBpcyBub3Qgc2V0CiMgQ09ORklHX01GRF9XTTg5OTQgaXMgbm90 IHNldAojIENPTkZJR19NRkRfUk9ITV9CRDcxOFhYIGlzIG5vdCBzZXQKIyBDT05GSUdfTUZEX1JP SE1fQkQ3MDUyOCBpcyBub3Qgc2V0CiMgQ09ORklHX01GRF9ST0hNX0JENzE4MjggaXMgbm90IHNl dAojIENPTkZJR19NRkRfUk9ITV9CRDk1N1hNVUYgaXMgbm90IHNldAojIENPTkZJR19NRkRfU1RQ TUlDMSBpcyBub3Qgc2V0CiMgQ09ORklHX01GRF9TVE1GWCBpcyBub3Qgc2V0CiMgQ09ORklHX01G RF9BVEMyNjBYX0kyQyBpcyBub3Qgc2V0CiMgQ09ORklHX01GRF9RQ09NX1BNODAwOCBpcyBub3Qg c2V0CiMgQ09ORklHX1JBVkVfU1BfQ09SRSBpcyBub3Qgc2V0CiMgZW5kIG9mIE11bHRpZnVuY3Rp b24gZGV2aWNlIGRyaXZlcnMKCkNPTkZJR19SRUdVTEFUT1I9eQojIENPTkZJR19SRUdVTEFUT1Jf REVCVUcgaXMgbm90IHNldApDT05GSUdfUkVHVUxBVE9SX0ZJWEVEX1ZPTFRBR0U9eQojIENPTkZJ R19SRUdVTEFUT1JfVklSVFVBTF9DT05TVU1FUiBpcyBub3Qgc2V0CiMgQ09ORklHX1JFR1VMQVRP Ul9VU0VSU1BBQ0VfQ09OU1VNRVIgaXMgbm90IHNldAojIENPTkZJR19SRUdVTEFUT1JfODhQRzg2 WCBpcyBub3Qgc2V0CiMgQ09ORklHX1JFR1VMQVRPUl9BQ1Q4ODY1IGlzIG5vdCBzZXQKIyBDT05G SUdfUkVHVUxBVE9SX0FENTM5OCBpcyBub3Qgc2V0CiMgQ09ORklHX1JFR1VMQVRPUl9EQTkxMjEg aXMgbm90IHNldAojIENPTkZJR19SRUdVTEFUT1JfREE5MjEwIGlzIG5vdCBzZXQKIyBDT05GSUdf UkVHVUxBVE9SX0RBOTIxMSBpcyBub3Qgc2V0CiMgQ09ORklHX1JFR1VMQVRPUl9GQU41MzU1NSBp cyBub3Qgc2V0CiMgQ09ORklHX1JFR1VMQVRPUl9GQU41Mzg4MCBpcyBub3Qgc2V0CkNPTkZJR19S RUdVTEFUT1JfR1BJTz15CiMgQ09ORklHX1JFR1VMQVRPUl9JU0w5MzA1IGlzIG5vdCBzZXQKIyBD T05GSUdfUkVHVUxBVE9SX0lTTDYyNzFBIGlzIG5vdCBzZXQKIyBDT05GSUdfUkVHVUxBVE9SX0xQ Mzk3MSBpcyBub3Qgc2V0CiMgQ09ORklHX1JFR1VMQVRPUl9MUDM5NzIgaXMgbm90IHNldAojIENP TkZJR19SRUdVTEFUT1JfTFA4NzJYIGlzIG5vdCBzZXQKIyBDT05GSUdfUkVHVUxBVE9SX0xQODc1 NSBpcyBub3Qgc2V0CiMgQ09ORklHX1JFR1VMQVRPUl9MVEMzNTg5IGlzIG5vdCBzZXQKIyBDT05G SUdfUkVHVUxBVE9SX0xUQzM2NzYgaXMgbm90IHNldAojIENPTkZJR19SRUdVTEFUT1JfTUFYMTU4 NiBpcyBub3Qgc2V0CiMgQ09ORklHX1JFR1VMQVRPUl9NQVg4NjQ5IGlzIG5vdCBzZXQKIyBDT05G SUdfUkVHVUxBVE9SX01BWDg2NjAgaXMgbm90IHNldAojIENPTkZJR19SRUdVTEFUT1JfTUFYODg5 MyBpcyBub3Qgc2V0CiMgQ09ORklHX1JFR1VMQVRPUl9NQVg4OTUyIGlzIG5vdCBzZXQKIyBDT05G SUdfUkVHVUxBVE9SX01BWDc3ODI2IGlzIG5vdCBzZXQKIyBDT05GSUdfUkVHVUxBVE9SX01DUDE2 NTAyIGlzIG5vdCBzZXQKIyBDT05GSUdfUkVHVUxBVE9SX01QNTQxNiBpcyBub3Qgc2V0CiMgQ09O RklHX1JFR1VMQVRPUl9NUDg4NTkgaXMgbm90IHNldAojIENPTkZJR19SRUdVTEFUT1JfTVA4ODZY IGlzIG5vdCBzZXQKIyBDT05GSUdfUkVHVUxBVE9SX01QUTc5MjAgaXMgbm90IHNldAojIENPTkZJ R19SRUdVTEFUT1JfTVQ2MzExIGlzIG5vdCBzZXQKIyBDT05GSUdfUkVHVUxBVE9SX1BDQTk0NTAg aXMgbm90IHNldAojIENPTkZJR19SRUdVTEFUT1JfUEY4WDAwIGlzIG5vdCBzZXQKIyBDT05GSUdf UkVHVUxBVE9SX1BGVVpFMTAwIGlzIG5vdCBzZXQKIyBDT05GSUdfUkVHVUxBVE9SX1BWODgwNjAg aXMgbm90IHNldAojIENPTkZJR19SRUdVTEFUT1JfUFY4ODA4MCBpcyBub3Qgc2V0CiMgQ09ORklH X1JFR1VMQVRPUl9QVjg4MDkwIGlzIG5vdCBzZXQKIyBDT05GSUdfUkVHVUxBVE9SX1JUNDgwMSBp cyBub3Qgc2V0CiMgQ09ORklHX1JFR1VMQVRPUl9SVDYxNjAgaXMgbm90IHNldAojIENPTkZJR19S RUdVTEFUT1JfUlQ2MjQ1IGlzIG5vdCBzZXQKIyBDT05GSUdfUkVHVUxBVE9SX1JUTVYyMCBpcyBu b3Qgc2V0CiMgQ09ORklHX1JFR1VMQVRPUl9TTEc1MTAwMCBpcyBub3Qgc2V0CiMgQ09ORklHX1JF R1VMQVRPUl9TWTgxMDZBIGlzIG5vdCBzZXQKIyBDT05GSUdfUkVHVUxBVE9SX1NZODgyNFggaXMg bm90IHNldAojIENPTkZJR19SRUdVTEFUT1JfU1k4ODI3TiBpcyBub3Qgc2V0CiMgQ09ORklHX1JF R1VMQVRPUl9UUFM1MTYzMiBpcyBub3Qgc2V0CiMgQ09ORklHX1JFR1VMQVRPUl9UUFM2MjM2MCBp cyBub3Qgc2V0CiMgQ09ORklHX1JFR1VMQVRPUl9UUFM2NTAyMyBpcyBub3Qgc2V0CiMgQ09ORklH X1JFR1VMQVRPUl9UUFM2NTA3WCBpcyBub3Qgc2V0CkNPTkZJR19SRUdVTEFUT1JfVFBTNjUwODY9 eQojIENPTkZJR19SRUdVTEFUT1JfVFBTNjUxMzIgaXMgbm90IHNldAojIENPTkZJR19SRUdVTEFU T1JfVkNUUkwgaXMgbm90IHNldAojIENPTkZJR19SQ19DT1JFIGlzIG5vdCBzZXQKIyBDT05GSUdf TUVESUFfQ0VDX1NVUFBPUlQgaXMgbm90IHNldAojIENPTkZJR19NRURJQV9TVVBQT1JUIGlzIG5v dCBzZXQKCiMKIyBHcmFwaGljcyBzdXBwb3J0CiMKIyBDT05GSUdfRFJNIGlzIG5vdCBzZXQKCiMK IyBBUk0gZGV2aWNlcwojCiMgZW5kIG9mIEFSTSBkZXZpY2VzCgojCiMgRnJhbWUgYnVmZmVyIERl dmljZXMKIwpDT05GSUdfRkJfQ01ETElORT15CkNPTkZJR19GQl9OT1RJRlk9eQpDT05GSUdfRkI9 eQojIENPTkZJR19GSVJNV0FSRV9FRElEIGlzIG5vdCBzZXQKQ09ORklHX0ZCX0NGQl9GSUxMUkVD VD15CkNPTkZJR19GQl9DRkJfQ09QWUFSRUE9eQpDT05GSUdfRkJfQ0ZCX0lNQUdFQkxJVD15CiMg Q09ORklHX0ZCX0ZPUkVJR05fRU5ESUFOIGlzIG5vdCBzZXQKIyBDT05GSUdfRkJfTU9ERV9IRUxQ RVJTIGlzIG5vdCBzZXQKIyBDT05GSUdfRkJfVElMRUJMSVRUSU5HIGlzIG5vdCBzZXQKCiMKIyBG cmFtZSBidWZmZXIgaGFyZHdhcmUgZHJpdmVycwojCiMgQ09ORklHX0ZCX0FSTUNMQ0QgaXMgbm90 IHNldAojIENPTkZJR19GQl9FRkkgaXMgbm90IHNldAojIENPTkZJR19GQl9PUEVOQ09SRVMgaXMg bm90IHNldAojIENPTkZJR19GQl9TMUQxM1hYWCBpcyBub3Qgc2V0CiMgQ09ORklHX0ZCX0lCTV9H WFQ0NTAwIGlzIG5vdCBzZXQKQ09ORklHX0ZCX1hJTElOWD15CiMgQ09ORklHX0ZCX1ZJUlRVQUwg aXMgbm90IHNldAojIENPTkZJR19GQl9NRVRST05PTUUgaXMgbm90IHNldAojIENPTkZJR19GQl9T SU1QTEUgaXMgbm90IHNldAojIENPTkZJR19GQl9TU0QxMzA3IGlzIG5vdCBzZXQKIyBlbmQgb2Yg RnJhbWUgYnVmZmVyIERldmljZXMKCiMKIyBCYWNrbGlnaHQgJiBMQ0QgZGV2aWNlIHN1cHBvcnQK IwojIENPTkZJR19MQ0RfQ0xBU1NfREVWSUNFIGlzIG5vdCBzZXQKIyBDT05GSUdfQkFDS0xJR0hU X0NMQVNTX0RFVklDRSBpcyBub3Qgc2V0CiMgZW5kIG9mIEJhY2tsaWdodCAmIExDRCBkZXZpY2Ug c3VwcG9ydAoKIwojIENvbnNvbGUgZGlzcGxheSBkcml2ZXIgc3VwcG9ydAojCkNPTkZJR19EVU1N WV9DT05TT0xFPXkKQ09ORklHX0RVTU1ZX0NPTlNPTEVfQ09MVU1OUz04MApDT05GSUdfRFVNTVlf Q09OU09MRV9ST1dTPTI1CkNPTkZJR19GUkFNRUJVRkZFUl9DT05TT0xFPXkKQ09ORklHX0ZSQU1F QlVGRkVSX0NPTlNPTEVfREVURUNUX1BSSU1BUlk9eQojIENPTkZJR19GUkFNRUJVRkZFUl9DT05T T0xFX1JPVEFUSU9OIGlzIG5vdCBzZXQKIyBDT05GSUdfRlJBTUVCVUZGRVJfQ09OU09MRV9ERUZF UlJFRF9UQUtFT1ZFUiBpcyBub3Qgc2V0CiMgZW5kIG9mIENvbnNvbGUgZGlzcGxheSBkcml2ZXIg c3VwcG9ydAoKIyBDT05GSUdfTE9HTyBpcyBub3Qgc2V0CiMgZW5kIG9mIEdyYXBoaWNzIHN1cHBv cnQKCiMgQ09ORklHX1NPVU5EIGlzIG5vdCBzZXQKCiMKIyBISUQgc3VwcG9ydAojCkNPTkZJR19I SUQ9eQojIENPTkZJR19ISURfQkFUVEVSWV9TVFJFTkdUSCBpcyBub3Qgc2V0CiMgQ09ORklHX0hJ RFJBVyBpcyBub3Qgc2V0CiMgQ09ORklHX1VISUQgaXMgbm90IHNldApDT05GSUdfSElEX0dFTkVS SUM9eQoKIwojIFNwZWNpYWwgSElEIGRyaXZlcnMKIwojIENPTkZJR19ISURfQTRURUNIIGlzIG5v dCBzZXQKIyBDT05GSUdfSElEX0FDUlVYIGlzIG5vdCBzZXQKIyBDT05GSUdfSElEX0FQUExFIGlz IG5vdCBzZXQKIyBDT05GSUdfSElEX0FVUkVBTCBpcyBub3Qgc2V0CiMgQ09ORklHX0hJRF9CRUxL SU4gaXMgbm90IHNldAojIENPTkZJR19ISURfQ0hFUlJZIGlzIG5vdCBzZXQKIyBDT05GSUdfSElE X0NISUNPTlkgaXMgbm90IHNldAojIENPTkZJR19ISURfQ09VR0FSIGlzIG5vdCBzZXQKIyBDT05G SUdfSElEX01BQ0FMTFkgaXMgbm90IHNldAojIENPTkZJR19ISURfQ01FRElBIGlzIG5vdCBzZXQK IyBDT05GSUdfSElEX0NZUFJFU1MgaXMgbm90IHNldAojIENPTkZJR19ISURfRFJBR09OUklTRSBp cyBub3Qgc2V0CiMgQ09ORklHX0hJRF9FTVNfRkYgaXMgbm90IHNldAojIENPTkZJR19ISURfRUxF Q09NIGlzIG5vdCBzZXQKIyBDT05GSUdfSElEX0VaS0VZIGlzIG5vdCBzZXQKIyBDT05GSUdfSElE X0dFTUJJUkQgaXMgbm90IHNldAojIENPTkZJR19ISURfR0ZSTSBpcyBub3Qgc2V0CiMgQ09ORklH X0hJRF9HTE9SSU9VUyBpcyBub3Qgc2V0CiMgQ09ORklHX0hJRF9WSVZBTERJIGlzIG5vdCBzZXQK IyBDT05GSUdfSElEX0tFWVRPVUNIIGlzIG5vdCBzZXQKIyBDT05GSUdfSElEX0tZRSBpcyBub3Qg c2V0CiMgQ09ORklHX0hJRF9XQUxUT1AgaXMgbm90IHNldAojIENPTkZJR19ISURfVklFV1NPTklD IGlzIG5vdCBzZXQKIyBDT05GSUdfSElEX0dZUkFUSU9OIGlzIG5vdCBzZXQKIyBDT05GSUdfSElE X0lDQURFIGlzIG5vdCBzZXQKIyBDT05GSUdfSElEX0lURSBpcyBub3Qgc2V0CiMgQ09ORklHX0hJ RF9KQUJSQSBpcyBub3Qgc2V0CiMgQ09ORklHX0hJRF9UV0lOSEFOIGlzIG5vdCBzZXQKIyBDT05G SUdfSElEX0tFTlNJTkdUT04gaXMgbm90IHNldAojIENPTkZJR19ISURfTENQT1dFUiBpcyBub3Qg c2V0CiMgQ09ORklHX0hJRF9MRUQgaXMgbm90IHNldAojIENPTkZJR19ISURfTEVOT1ZPIGlzIG5v dCBzZXQKIyBDT05GSUdfSElEX0xPR0lURUNIIGlzIG5vdCBzZXQKIyBDT05GSUdfSElEX01BR0lD TU9VU0UgaXMgbm90IHNldAojIENPTkZJR19ISURfTUFMVFJPTiBpcyBub3Qgc2V0CiMgQ09ORklH X0hJRF9NQVlGTEFTSCBpcyBub3Qgc2V0CiMgQ09ORklHX0hJRF9SRURSQUdPTiBpcyBub3Qgc2V0 CiMgQ09ORklHX0hJRF9NSUNST1NPRlQgaXMgbm90IHNldAojIENPTkZJR19ISURfTU9OVEVSRVkg aXMgbm90IHNldAojIENPTkZJR19ISURfTVVMVElUT1VDSCBpcyBub3Qgc2V0CiMgQ09ORklHX0hJ RF9OVEkgaXMgbm90IHNldAojIENPTkZJR19ISURfT1JURUsgaXMgbm90IHNldAojIENPTkZJR19I SURfUEFOVEhFUkxPUkQgaXMgbm90IHNldAojIENPTkZJR19ISURfUEVUQUxZTlggaXMgbm90IHNl dAojIENPTkZJR19ISURfUElDT0xDRCBpcyBub3Qgc2V0CiMgQ09ORklHX0hJRF9QTEFOVFJPTklD UyBpcyBub3Qgc2V0CiMgQ09ORklHX0hJRF9QTEFZU1RBVElPTiBpcyBub3Qgc2V0CiMgQ09ORklH X0hJRF9QUklNQVggaXMgbm90IHNldAojIENPTkZJR19ISURfU0FJVEVLIGlzIG5vdCBzZXQKIyBD T05GSUdfSElEX1NBTVNVTkcgaXMgbm90IHNldAojIENPTkZJR19ISURfU0VNSVRFSyBpcyBub3Qg c2V0CiMgQ09ORklHX0hJRF9TUEVFRExJTksgaXMgbm90IHNldAojIENPTkZJR19ISURfU1RFQU0g aXMgbm90IHNldAojIENPTkZJR19ISURfU1RFRUxTRVJJRVMgaXMgbm90IHNldAojIENPTkZJR19I SURfU1VOUExVUyBpcyBub3Qgc2V0CiMgQ09ORklHX0hJRF9STUkgaXMgbm90IHNldAojIENPTkZJ R19ISURfR1JFRU5BU0lBIGlzIG5vdCBzZXQKIyBDT05GSUdfSElEX1NNQVJUSk9ZUExVUyBpcyBu b3Qgc2V0CiMgQ09ORklHX0hJRF9USVZPIGlzIG5vdCBzZXQKIyBDT05GSUdfSElEX1RPUFNFRUQg aXMgbm90IHNldAojIENPTkZJR19ISURfVEhJTkdNIGlzIG5vdCBzZXQKIyBDT05GSUdfSElEX1VE UkFXX1BTMyBpcyBub3Qgc2V0CiMgQ09ORklHX0hJRF9XSUlNT1RFIGlzIG5vdCBzZXQKIyBDT05G SUdfSElEX1hJTk1PIGlzIG5vdCBzZXQKIyBDT05GSUdfSElEX1pFUk9QTFVTIGlzIG5vdCBzZXQK IyBDT05GSUdfSElEX1pZREFDUk9OIGlzIG5vdCBzZXQKIyBDT05GSUdfSElEX1NFTlNPUl9IVUIg aXMgbm90IHNldAojIENPTkZJR19ISURfQUxQUyBpcyBub3Qgc2V0CiMgZW5kIG9mIFNwZWNpYWwg SElEIGRyaXZlcnMKCiMKIyBJMkMgSElEIHN1cHBvcnQKIwojIENPTkZJR19JMkNfSElEX09GIGlz IG5vdCBzZXQKIyBDT05GSUdfSTJDX0hJRF9PRl9HT09ESVggaXMgbm90IHNldAojIGVuZCBvZiBJ MkMgSElEIHN1cHBvcnQKIyBlbmQgb2YgSElEIHN1cHBvcnQKCkNPTkZJR19VU0JfT0hDSV9MSVRU TEVfRU5ESUFOPXkKIyBDT05GSUdfVVNCX1NVUFBPUlQgaXMgbm90IHNldAojIENPTkZJR19NTUMg aXMgbm90IHNldAojIENPTkZJR19NRU1TVElDSyBpcyBub3Qgc2V0CkNPTkZJR19ORVdfTEVEUz15 CkNPTkZJR19MRURTX0NMQVNTPXkKIyBDT05GSUdfTEVEU19DTEFTU19GTEFTSCBpcyBub3Qgc2V0 CiMgQ09ORklHX0xFRFNfQ0xBU1NfTVVMVElDT0xPUiBpcyBub3Qgc2V0CiMgQ09ORklHX0xFRFNf QlJJR0hUTkVTU19IV19DSEFOR0VEIGlzIG5vdCBzZXQKCiMKIyBMRUQgZHJpdmVycwojCiMgQ09O RklHX0xFRFNfQU4zMDI1OUEgaXMgbm90IHNldAojIENPTkZJR19MRURTX0FXMjAxMyBpcyBub3Qg c2V0CiMgQ09ORklHX0xFRFNfQkNNNjMyOCBpcyBub3Qgc2V0CiMgQ09ORklHX0xFRFNfQkNNNjM1 OCBpcyBub3Qgc2V0CiMgQ09ORklHX0xFRFNfTE0zNTMwIGlzIG5vdCBzZXQKIyBDT05GSUdfTEVE U19MTTM1MzIgaXMgbm90IHNldAojIENPTkZJR19MRURTX0xNMzY0MiBpcyBub3Qgc2V0CiMgQ09O RklHX0xFRFNfTE0zNjkyWCBpcyBub3Qgc2V0CiMgQ09ORklHX0xFRFNfUENBOTUzMiBpcyBub3Qg c2V0CkNPTkZJR19MRURTX0dQSU89eQojIENPTkZJR19MRURTX0xQMzk0NCBpcyBub3Qgc2V0CiMg Q09ORklHX0xFRFNfTFAzOTUyIGlzIG5vdCBzZXQKIyBDT05GSUdfTEVEU19MUDUwWFggaXMgbm90 IHNldAojIENPTkZJR19MRURTX0xQNTVYWF9DT01NT04gaXMgbm90IHNldAojIENPTkZJR19MRURT X0xQODg2MCBpcyBub3Qgc2V0CiMgQ09ORklHX0xFRFNfUENBOTU1WCBpcyBub3Qgc2V0CiMgQ09O RklHX0xFRFNfUENBOTYzWCBpcyBub3Qgc2V0CiMgQ09ORklHX0xFRFNfUkVHVUxBVE9SIGlzIG5v dCBzZXQKIyBDT05GSUdfTEVEU19CRDI4MDIgaXMgbm90IHNldAojIENPTkZJR19MRURTX0xUMzU5 MyBpcyBub3Qgc2V0CiMgQ09ORklHX0xFRFNfVENBNjUwNyBpcyBub3Qgc2V0CiMgQ09ORklHX0xF RFNfVExDNTkxWFggaXMgbm90IHNldAojIENPTkZJR19MRURTX0xNMzU1eCBpcyBub3Qgc2V0CiMg Q09ORklHX0xFRFNfSVMzMUZMMzE5WCBpcyBub3Qgc2V0CiMgQ09ORklHX0xFRFNfSVMzMUZMMzJY WCBpcyBub3Qgc2V0CgojCiMgTEVEIGRyaXZlciBmb3IgYmxpbmsoMSkgVVNCIFJHQiBMRUQgaXMg dW5kZXIgU3BlY2lhbCBISUQgZHJpdmVycyAoSElEX1RISU5HTSkKIwojIENPTkZJR19MRURTX0JM SU5LTSBpcyBub3Qgc2V0CiMgQ09ORklHX0xFRFNfTUxYUkVHIGlzIG5vdCBzZXQKIyBDT05GSUdf TEVEU19VU0VSIGlzIG5vdCBzZXQKIyBDT05GSUdfTEVEU19USV9MTVVfQ09NTU9OIGlzIG5vdCBz ZXQKCiMKIyBGbGFzaCBhbmQgVG9yY2ggTEVEIGRyaXZlcnMKIwoKIwojIExFRCBUcmlnZ2Vycwoj CkNPTkZJR19MRURTX1RSSUdHRVJTPXkKQ09ORklHX0xFRFNfVFJJR0dFUl9USU1FUj15CkNPTkZJ R19MRURTX1RSSUdHRVJfT05FU0hPVD15CkNPTkZJR19MRURTX1RSSUdHRVJfSEVBUlRCRUFUPXkK Q09ORklHX0xFRFNfVFJJR0dFUl9CQUNLTElHSFQ9eQpDT05GSUdfTEVEU19UUklHR0VSX0NQVT15 CiMgQ09ORklHX0xFRFNfVFJJR0dFUl9BQ1RJVklUWSBpcyBub3Qgc2V0CkNPTkZJR19MRURTX1RS SUdHRVJfR1BJTz15CkNPTkZJR19MRURTX1RSSUdHRVJfREVGQVVMVF9PTj15CgojCiMgaXB0YWJs ZXMgdHJpZ2dlciBpcyB1bmRlciBOZXRmaWx0ZXIgY29uZmlnIChMRUQgdGFyZ2V0KQojCkNPTkZJ R19MRURTX1RSSUdHRVJfVFJBTlNJRU5UPXkKQ09ORklHX0xFRFNfVFJJR0dFUl9DQU1FUkE9eQoj IENPTkZJR19MRURTX1RSSUdHRVJfUEFOSUMgaXMgbm90IHNldAojIENPTkZJR19MRURTX1RSSUdH RVJfUEFUVEVSTiBpcyBub3Qgc2V0CiMgQ09ORklHX0xFRFNfVFJJR0dFUl9BVURJTyBpcyBub3Qg c2V0CiMgQ09ORklHX0xFRFNfVFJJR0dFUl9UVFkgaXMgbm90IHNldAojIENPTkZJR19BQ0NFU1NJ QklMSVRZIGlzIG5vdCBzZXQKQ09ORklHX0VEQUNfU1VQUE9SVD15CkNPTkZJR19FREFDPXkKQ09O RklHX0VEQUNfTEVHQUNZX1NZU0ZTPXkKIyBDT05GSUdfRURBQ19ERUJVRyBpcyBub3Qgc2V0CkNP TkZJR19FREFDX1NZTk9QU1lTPXkKIyBDT05GSUdfRURBQ19YR0VORSBpcyBub3Qgc2V0CiMgQ09O RklHX0VEQUNfRE1DNTIwIGlzIG5vdCBzZXQKQ09ORklHX1JUQ19MSUI9eQpDT05GSUdfUlRDX0NM QVNTPXkKQ09ORklHX1JUQ19IQ1RPU1lTPXkKQ09ORklHX1JUQ19IQ1RPU1lTX0RFVklDRT0icnRj MCIKQ09ORklHX1JUQ19TWVNUT0hDPXkKQ09ORklHX1JUQ19TWVNUT0hDX0RFVklDRT0icnRjMCIK IyBDT05GSUdfUlRDX0RFQlVHIGlzIG5vdCBzZXQKQ09ORklHX1JUQ19OVk1FTT15CgojCiMgUlRD IGludGVyZmFjZXMKIwpDT05GSUdfUlRDX0lOVEZfU1lTRlM9eQpDT05GSUdfUlRDX0lOVEZfUFJP Qz15CkNPTkZJR19SVENfSU5URl9ERVY9eQojIENPTkZJR19SVENfSU5URl9ERVZfVUlFX0VNVUwg aXMgbm90IHNldAojIENPTkZJR19SVENfRFJWX1RFU1QgaXMgbm90IHNldAoKIwojIEkyQyBSVEMg ZHJpdmVycwojCiMgQ09ORklHX1JUQ19EUlZfQUJCNVpFUzMgaXMgbm90IHNldAojIENPTkZJR19S VENfRFJWX0FCRU9aOSBpcyBub3Qgc2V0CiMgQ09ORklHX1JUQ19EUlZfQUJYODBYIGlzIG5vdCBz ZXQKIyBDT05GSUdfUlRDX0RSVl9EUzEzMDcgaXMgbm90IHNldAojIENPTkZJR19SVENfRFJWX0RT MTM3NCBpcyBub3Qgc2V0CiMgQ09ORklHX1JUQ19EUlZfRFMxNjcyIGlzIG5vdCBzZXQKIyBDT05G SUdfUlRDX0RSVl9IWU04NTYzIGlzIG5vdCBzZXQKIyBDT05GSUdfUlRDX0RSVl9NQVg2OTAwIGlz IG5vdCBzZXQKIyBDT05GSUdfUlRDX0RSVl9SUzVDMzcyIGlzIG5vdCBzZXQKIyBDT05GSUdfUlRD X0RSVl9JU0wxMjA4IGlzIG5vdCBzZXQKIyBDT05GSUdfUlRDX0RSVl9JU0wxMjAyMiBpcyBub3Qg c2V0CiMgQ09ORklHX1JUQ19EUlZfSVNMMTIwMjYgaXMgbm90IHNldAojIENPTkZJR19SVENfRFJW X1gxMjA1IGlzIG5vdCBzZXQKIyBDT05GSUdfUlRDX0RSVl9QQ0Y4NTIzIGlzIG5vdCBzZXQKIyBD T05GSUdfUlRDX0RSVl9QQ0Y4NTA2MyBpcyBub3Qgc2V0CiMgQ09ORklHX1JUQ19EUlZfUENGODUz NjMgaXMgbm90IHNldAojIENPTkZJR19SVENfRFJWX1BDRjg1NjMgaXMgbm90IHNldAojIENPTkZJ R19SVENfRFJWX1BDRjg1ODMgaXMgbm90IHNldAojIENPTkZJR19SVENfRFJWX000MVQ4MCBpcyBu b3Qgc2V0CiMgQ09ORklHX1JUQ19EUlZfQlEzMksgaXMgbm90IHNldAojIENPTkZJR19SVENfRFJW X1MzNTM5MEEgaXMgbm90IHNldAojIENPTkZJR19SVENfRFJWX0ZNMzEzMCBpcyBub3Qgc2V0CiMg Q09ORklHX1JUQ19EUlZfUlg4MDEwIGlzIG5vdCBzZXQKIyBDT05GSUdfUlRDX0RSVl9SWDg1ODEg aXMgbm90IHNldAojIENPTkZJR19SVENfRFJWX1JYODAyNSBpcyBub3Qgc2V0CiMgQ09ORklHX1JU Q19EUlZfRU0zMDI3IGlzIG5vdCBzZXQKIyBDT05GSUdfUlRDX0RSVl9SVjMwMjggaXMgbm90IHNl dAojIENPTkZJR19SVENfRFJWX1JWMzAzMiBpcyBub3Qgc2V0CiMgQ09ORklHX1JUQ19EUlZfUlY4 ODAzIGlzIG5vdCBzZXQKIyBDT05GSUdfUlRDX0RSVl9TRDMwNzggaXMgbm90IHNldAoKIwojIFNQ SSBSVEMgZHJpdmVycwojCkNPTkZJR19SVENfSTJDX0FORF9TUEk9eQoKIwojIFNQSSBhbmQgSTJD IFJUQyBkcml2ZXJzCiMKIyBDT05GSUdfUlRDX0RSVl9EUzMyMzIgaXMgbm90IHNldAojIENPTkZJ R19SVENfRFJWX1BDRjIxMjcgaXMgbm90IHNldAojIENPTkZJR19SVENfRFJWX1JWMzAyOUMyIGlz IG5vdCBzZXQKIyBDT05GSUdfUlRDX0RSVl9SWDYxMTAgaXMgbm90IHNldAoKIwojIFBsYXRmb3Jt IFJUQyBkcml2ZXJzCiMKIyBDT05GSUdfUlRDX0RSVl9EUzEyODYgaXMgbm90IHNldAojIENPTkZJ R19SVENfRFJWX0RTMTUxMSBpcyBub3Qgc2V0CiMgQ09ORklHX1JUQ19EUlZfRFMxNTUzIGlzIG5v dCBzZXQKIyBDT05GSUdfUlRDX0RSVl9EUzE2ODVfRkFNSUxZIGlzIG5vdCBzZXQKIyBDT05GSUdf UlRDX0RSVl9EUzE3NDIgaXMgbm90IHNldAojIENPTkZJR19SVENfRFJWX0RTMjQwNCBpcyBub3Qg c2V0CiMgQ09ORklHX1JUQ19EUlZfRUZJIGlzIG5vdCBzZXQKIyBDT05GSUdfUlRDX0RSVl9TVEsx N1RBOCBpcyBub3Qgc2V0CiMgQ09ORklHX1JUQ19EUlZfTTQ4VDg2IGlzIG5vdCBzZXQKIyBDT05G SUdfUlRDX0RSVl9NNDhUMzUgaXMgbm90IHNldAojIENPTkZJR19SVENfRFJWX000OFQ1OSBpcyBu b3Qgc2V0CiMgQ09ORklHX1JUQ19EUlZfTVNNNjI0MiBpcyBub3Qgc2V0CiMgQ09ORklHX1JUQ19E UlZfQlE0ODAyIGlzIG5vdCBzZXQKIyBDT05GSUdfUlRDX0RSVl9SUDVDMDEgaXMgbm90IHNldAoj IENPTkZJR19SVENfRFJWX1YzMDIwIGlzIG5vdCBzZXQKQ09ORklHX1JUQ19EUlZfWllOUU1QPXkK CiMKIyBvbi1DUFUgUlRDIGRyaXZlcnMKIwojIENPTkZJR19SVENfRFJWX1BMMDMwIGlzIG5vdCBz ZXQKIyBDT05GSUdfUlRDX0RSVl9QTDAzMSBpcyBub3Qgc2V0CiMgQ09ORklHX1JUQ19EUlZfQ0FE RU5DRSBpcyBub3Qgc2V0CiMgQ09ORklHX1JUQ19EUlZfRlRSVEMwMTAgaXMgbm90IHNldAojIENP TkZJR19SVENfRFJWX1I3MzAxIGlzIG5vdCBzZXQKCiMKIyBISUQgU2Vuc29yIFJUQyBkcml2ZXJz CiMKIyBDT05GSUdfUlRDX0RSVl9HT0xERklTSCBpcyBub3Qgc2V0CkNPTkZJR19ETUFERVZJQ0VT PXkKIyBDT05GSUdfRE1BREVWSUNFU19ERUJVRyBpcyBub3Qgc2V0CgojCiMgRE1BIERldmljZXMK IwpDT05GSUdfRE1BX0VOR0lORT15CkNPTkZJR19ETUFfT0Y9eQojIENPTkZJR19BTFRFUkFfTVNH RE1BIGlzIG5vdCBzZXQKIyBDT05GSUdfQU1CQV9QTDA4WCBpcyBub3Qgc2V0CiMgQ09ORklHX0FY SV9ETUFDIGlzIG5vdCBzZXQKIyBDT05GSUdfRFdfQVhJX0RNQUMgaXMgbm90IHNldAojIENPTkZJ R19GU0xfRURNQSBpcyBub3Qgc2V0CiMgQ09ORklHX0ZTTF9RRE1BIGlzIG5vdCBzZXQKIyBDT05G SUdfSU5URUxfSURNQTY0IGlzIG5vdCBzZXQKIyBDT05GSUdfTVZfWE9SX1YyIGlzIG5vdCBzZXQK IyBDT05GSUdfUEwzMzBfRE1BIGlzIG5vdCBzZXQKQ09ORklHX1hJTElOWF9ETUE9eQpDT05GSUdf WElMSU5YX1pZTlFNUF9ETUE9eQojIENPTkZJR19YSUxJTlhfWllOUU1QX0RQRE1BIGlzIG5vdCBz ZXQKIyBDT05GSUdfUUNPTV9ISURNQV9NR01UIGlzIG5vdCBzZXQKIyBDT05GSUdfUUNPTV9ISURN QSBpcyBub3Qgc2V0CiMgQ09ORklHX0RXX0RNQUMgaXMgbm90IHNldAojIENPTkZJR19TRl9QRE1B IGlzIG5vdCBzZXQKCiMKIyBETUEgQ2xpZW50cwojCiMgQ09ORklHX0FTWU5DX1RYX0RNQSBpcyBu b3Qgc2V0CkNPTkZJR19ETUFURVNUPXkKQ09ORklHX0RNQV9FTkdJTkVfUkFJRD15CgojCiMgRE1B QlVGIG9wdGlvbnMKIwpDT05GSUdfU1lOQ19GSUxFPXkKIyBDT05GSUdfU1dfU1lOQyBpcyBub3Qg c2V0CiMgQ09ORklHX1VETUFCVUYgaXMgbm90IHNldAojIENPTkZJR19ETUFCVUZfTU9WRV9OT1RJ RlkgaXMgbm90IHNldAojIENPTkZJR19ETUFCVUZfREVCVUcgaXMgbm90IHNldAojIENPTkZJR19E TUFCVUZfU0VMRlRFU1RTIGlzIG5vdCBzZXQKIyBDT05GSUdfRE1BQlVGX0hFQVBTIGlzIG5vdCBz ZXQKIyBlbmQgb2YgRE1BQlVGIG9wdGlvbnMKCiMgQ09ORklHX0FVWERJU1BMQVkgaXMgbm90IHNl dApDT05GSUdfVUlPPXkKQ09ORklHX1VJT19QRFJWX0dFTklSUT15CkNPTkZJR19VSU9fRE1FTV9H RU5JUlE9eQojIENPTkZJR19VSU9fUFJVU1MgaXMgbm90IHNldAojIENPTkZJR19WRklPIGlzIG5v dCBzZXQKIyBDT05GSUdfVklSVF9EUklWRVJTIGlzIG5vdCBzZXQKQ09ORklHX1ZJUlRJTz15CkNP TkZJR19WSVJUSU9fTUVOVT15CiMgQ09ORklHX1ZJUlRJT19CQUxMT09OIGlzIG5vdCBzZXQKIyBD T05GSUdfVklSVElPX0lOUFVUIGlzIG5vdCBzZXQKIyBDT05GSUdfVklSVElPX01NSU8gaXMgbm90 IHNldApDT05GSUdfVkhPU1RfTUVOVT15CiMgQ09ORklHX1ZIT1NUX0NST1NTX0VORElBTl9MRUdB Q1kgaXMgbm90IHNldAoKIwojIE1pY3Jvc29mdCBIeXBlci1WIGd1ZXN0IHN1cHBvcnQKIwojIGVu ZCBvZiBNaWNyb3NvZnQgSHlwZXItViBndWVzdCBzdXBwb3J0CgojIENPTkZJR19HUkVZQlVTIGlz IG5vdCBzZXQKIyBDT05GSUdfQ09NRURJIGlzIG5vdCBzZXQKIyBDT05GSUdfU1RBR0lORyBpcyBu b3Qgc2V0CiMgQ09ORklHX0dPTERGSVNIIGlzIG5vdCBzZXQKIyBDT05GSUdfQ0hST01FX1BMQVRG T1JNUyBpcyBub3Qgc2V0CiMgQ09ORklHX01FTExBTk9YX1BMQVRGT1JNIGlzIG5vdCBzZXQKQ09O RklHX0hBVkVfQ0xLPXkKQ09ORklHX0hBVkVfQ0xLX1BSRVBBUkU9eQpDT05GSUdfQ09NTU9OX0NM Sz15CgojCiMgQ2xvY2sgZHJpdmVyIGZvciBBUk0gUmVmZXJlbmNlIGRlc2lnbnMKIwojIENPTkZJ R19JQ1NUIGlzIG5vdCBzZXQKIyBDT05GSUdfQ0xLX1NQODEwIGlzIG5vdCBzZXQKIyBlbmQgb2Yg Q2xvY2sgZHJpdmVyIGZvciBBUk0gUmVmZXJlbmNlIGRlc2lnbnMKCiMgQ09ORklHX0NPTU1PTl9D TEtfTUFYOTQ4NSBpcyBub3Qgc2V0CkNPTkZJR19DT01NT05fQ0xLX1NJNTM0MT15CiMgQ09ORklH X0NPTU1PTl9DTEtfU0k1MzUxIGlzIG5vdCBzZXQKIyBDT05GSUdfQ09NTU9OX0NMS19TSTUxNCBp cyBub3Qgc2V0CiMgQ09ORklHX0NPTU1PTl9DTEtfU0k1NDQgaXMgbm90IHNldApDT05GSUdfQ09N TU9OX0NMS19TSTU3MD15CiMgQ09ORklHX0NPTU1PTl9DTEtfQ0RDRTcwNiBpcyBub3Qgc2V0CiMg Q09ORklHX0NPTU1PTl9DTEtfQ0RDRTkyNSBpcyBub3Qgc2V0CiMgQ09ORklHX0NPTU1PTl9DTEtf Q1MyMDAwX0NQIGlzIG5vdCBzZXQKIyBDT05GSUdfQ09NTU9OX0NMS19BWElfQ0xLR0VOIGlzIG5v dCBzZXQKIyBDT05GSUdfQ09NTU9OX0NMS19YR0VORSBpcyBub3Qgc2V0CkNPTkZJR19DT01NT05f Q0xLX1ZDNT15CiMgQ09ORklHX0NPTU1PTl9DTEtfRklYRURfTU1JTyBpcyBub3Qgc2V0CkNPTkZJ R19YSUxJTlhfVkNVPXkKQ09ORklHX0NPTU1PTl9DTEtfWllOUU1QPXkKIyBDT05GSUdfSFdTUElO TE9DSyBpcyBub3Qgc2V0CgojCiMgQ2xvY2sgU291cmNlIGRyaXZlcnMKIwpDT05GSUdfVElNRVJf T0Y9eQpDT05GSUdfVElNRVJfUFJPQkU9eQpDT05GSUdfQVJNX0FSQ0hfVElNRVI9eQpDT05GSUdf QVJNX0FSQ0hfVElNRVJfRVZUU1RSRUFNPXkKQ09ORklHX0FSTV9BUkNIX1RJTUVSX09PTF9XT1JL QVJPVU5EPXkKQ09ORklHX0ZTTF9FUlJBVFVNX0EwMDg1ODU9eQpDT05GSUdfSElTSUxJQ09OX0VS UkFUVU1fMTYxMDEwMTAxPXkKQ09ORklHX0FSTTY0X0VSUkFUVU1fODU4OTIxPXkKIyBDT05GSUdf TUlDUk9DSElQX1BJVDY0QiBpcyBub3Qgc2V0CiMgZW5kIG9mIENsb2NrIFNvdXJjZSBkcml2ZXJz CgpDT05GSUdfTUFJTEJPWD15CiMgQ09ORklHX0FSTV9NSFUgaXMgbm90IHNldAojIENPTkZJR19B Uk1fTUhVX1YyIGlzIG5vdCBzZXQKIyBDT05GSUdfUExBVEZPUk1fTUhVIGlzIG5vdCBzZXQKIyBD T05GSUdfUEwzMjBfTUJPWCBpcyBub3Qgc2V0CiMgQ09ORklHX0FMVEVSQV9NQk9YIGlzIG5vdCBz ZXQKIyBDT05GSUdfTUFJTEJPWF9URVNUIGlzIG5vdCBzZXQKQ09ORklHX1pZTlFNUF9JUElfTUJP WD15CkNPTkZJR19JT01NVV9JT1ZBPXkKQ09ORklHX0lPTU1VX0FQST15CkNPTkZJR19JT01NVV9T VVBQT1JUPXkKCiMKIyBHZW5lcmljIElPTU1VIFBhZ2V0YWJsZSBTdXBwb3J0CiMKIyBDT05GSUdf SU9NTVVfSU9fUEdUQUJMRV9MUEFFIGlzIG5vdCBzZXQKIyBDT05GSUdfSU9NTVVfSU9fUEdUQUJM RV9BUk1WN1MgaXMgbm90IHNldAojIGVuZCBvZiBHZW5lcmljIElPTU1VIFBhZ2V0YWJsZSBTdXBw b3J0CgojIENPTkZJR19JT01NVV9ERUJVR0ZTIGlzIG5vdCBzZXQKIyBDT05GSUdfSU9NTVVfREVG QVVMVF9QQVNTVEhST1VHSCBpcyBub3Qgc2V0CkNPTkZJR19PRl9JT01NVT15CkNPTkZJR19JT01N VV9ETUE9eQojIENPTkZJR19BUk1fU01NVSBpcyBub3Qgc2V0CiMgQ09ORklHX0FSTV9TTU1VX1Yz IGlzIG5vdCBzZXQKIyBDT05GSUdfVklSVElPX0lPTU1VIGlzIG5vdCBzZXQKCiMKIyBSZW1vdGVw cm9jIGRyaXZlcnMKIwpDT05GSUdfUkVNT1RFUFJPQz15CiMgQ09ORklHX1JFTU9URVBST0NfQ0RF ViBpcyBub3Qgc2V0CiMgZW5kIG9mIFJlbW90ZXByb2MgZHJpdmVycwoKIwojIFJwbXNnIGRyaXZl cnMKIwojIENPTkZJR19SUE1TR19RQ09NX0dMSU5LX1JQTSBpcyBub3Qgc2V0CiMgQ09ORklHX1JQ TVNHX1ZJUlRJTyBpcyBub3Qgc2V0CiMgZW5kIG9mIFJwbXNnIGRyaXZlcnMKCiMgQ09ORklHX1NP VU5EV0lSRSBpcyBub3Qgc2V0CgojCiMgU09DIChTeXN0ZW0gT24gQ2hpcCkgc3BlY2lmaWMgRHJp dmVycwojCgojCiMgQW1sb2dpYyBTb0MgZHJpdmVycwojCiMgZW5kIG9mIEFtbG9naWMgU29DIGRy aXZlcnMKCiMKIyBCcm9hZGNvbSBTb0MgZHJpdmVycwojCiMgQ09ORklHX1NPQ19CUkNNU1RCIGlz IG5vdCBzZXQKIyBlbmQgb2YgQnJvYWRjb20gU29DIGRyaXZlcnMKCiMKIyBOWFAvRnJlZXNjYWxl IFFvcklRIFNvQyBkcml2ZXJzCiMKIyBDT05GSUdfUVVJQ0NfRU5HSU5FIGlzIG5vdCBzZXQKIyBD T05GSUdfRlNMX1JDUE0gaXMgbm90IHNldAojIGVuZCBvZiBOWFAvRnJlZXNjYWxlIFFvcklRIFNv QyBkcml2ZXJzCgojCiMgaS5NWCBTb0MgZHJpdmVycwojCiMgZW5kIG9mIGkuTVggU29DIGRyaXZl cnMKCiMKIyBFbmFibGUgTGl0ZVggU29DIEJ1aWxkZXIgc3BlY2lmaWMgZHJpdmVycwojCiMgQ09O RklHX0xJVEVYX1NPQ19DT05UUk9MTEVSIGlzIG5vdCBzZXQKIyBlbmQgb2YgRW5hYmxlIExpdGVY IFNvQyBCdWlsZGVyIHNwZWNpZmljIGRyaXZlcnMKCiMKIyBRdWFsY29tbSBTb0MgZHJpdmVycwoj CiMgZW5kIG9mIFF1YWxjb21tIFNvQyBkcml2ZXJzCgojIENPTkZJR19TT0NfVEkgaXMgbm90IHNl dAoKIwojIFhpbGlueCBTb0MgZHJpdmVycwojCkNPTkZJR19aWU5RTVBfUE9XRVI9eQpDT05GSUdf WllOUU1QX1BNX0RPTUFJTlM9eQojIGVuZCBvZiBYaWxpbnggU29DIGRyaXZlcnMKIyBlbmQgb2Yg U09DIChTeXN0ZW0gT24gQ2hpcCkgc3BlY2lmaWMgRHJpdmVycwoKIyBDT05GSUdfUE1fREVWRlJF USBpcyBub3Qgc2V0CkNPTkZJR19FWFRDT049eQoKIwojIEV4dGNvbiBEZXZpY2UgRHJpdmVycwoj CiMgQ09ORklHX0VYVENPTl9BRENfSkFDSyBpcyBub3Qgc2V0CiMgQ09ORklHX0VYVENPTl9GU0E5 NDgwIGlzIG5vdCBzZXQKIyBDT05GSUdfRVhUQ09OX0dQSU8gaXMgbm90IHNldAojIENPTkZJR19F WFRDT05fTUFYMzM1NSBpcyBub3Qgc2V0CiMgQ09ORklHX0VYVENPTl9QVE41MTUwIGlzIG5vdCBz ZXQKIyBDT05GSUdfRVhUQ09OX1JUODk3M0EgaXMgbm90IHNldAojIENPTkZJR19FWFRDT05fU001 NTAyIGlzIG5vdCBzZXQKIyBDT05GSUdfRVhUQ09OX1VTQl9HUElPIGlzIG5vdCBzZXQKIyBDT05G SUdfRVhUQ09OX1VTQkNfVFVTQjMyMCBpcyBub3Qgc2V0CiMgQ09ORklHX01FTU9SWSBpcyBub3Qg c2V0CkNPTkZJR19JSU89eQpDT05GSUdfSUlPX0JVRkZFUj15CiMgQ09ORklHX0lJT19CVUZGRVJf Q0IgaXMgbm90IHNldAojIENPTkZJR19JSU9fQlVGRkVSX0RNQSBpcyBub3Qgc2V0CiMgQ09ORklH X0lJT19CVUZGRVJfRE1BRU5HSU5FIGlzIG5vdCBzZXQKIyBDT05GSUdfSUlPX0JVRkZFUl9IV19D T05TVU1FUiBpcyBub3Qgc2V0CkNPTkZJR19JSU9fS0ZJRk9fQlVGPXkKQ09ORklHX0lJT19UUklH R0VSRURfQlVGRkVSPXkKIyBDT05GSUdfSUlPX0NPTkZJR0ZTIGlzIG5vdCBzZXQKQ09ORklHX0lJ T19UUklHR0VSPXkKQ09ORklHX0lJT19DT05TVU1FUlNfUEVSX1RSSUdHRVI9MgojIENPTkZJR19J SU9fU1dfREVWSUNFIGlzIG5vdCBzZXQKIyBDT05GSUdfSUlPX1NXX1RSSUdHRVIgaXMgbm90IHNl dAojIENPTkZJR19JSU9fVFJJR0dFUkVEX0VWRU5UIGlzIG5vdCBzZXQKCiMKIyBBY2NlbGVyb21l dGVycwojCiMgQ09ORklHX0FEWEwzNDVfSTJDIGlzIG5vdCBzZXQKIyBDT05GSUdfQURYTDM3Ml9J MkMgaXMgbm90IHNldAojIENPTkZJR19CTUExODAgaXMgbm90IHNldAojIENPTkZJR19CTUE0MDAg aXMgbm90IHNldAojIENPTkZJR19CTUMxNTBfQUNDRUwgaXMgbm90IHNldAojIENPTkZJR19EQTI4 MCBpcyBub3Qgc2V0CiMgQ09ORklHX0RBMzExIGlzIG5vdCBzZXQKIyBDT05GSUdfRE1BUkQwNiBp cyBub3Qgc2V0CiMgQ09ORklHX0RNQVJEMDkgaXMgbm90IHNldAojIENPTkZJR19ETUFSRDEwIGlz IG5vdCBzZXQKIyBDT05GSUdfRlhMUzg5NjJBRl9JMkMgaXMgbm90IHNldAojIENPTkZJR19JSU9f U1RfQUNDRUxfM0FYSVMgaXMgbm90IHNldAojIENPTkZJR19LWFNEOSBpcyBub3Qgc2V0CiMgQ09O RklHX0tYQ0pLMTAxMyBpcyBub3Qgc2V0CiMgQ09ORklHX01DMzIzMCBpcyBub3Qgc2V0CiMgQ09O RklHX01NQTc0NTVfSTJDIGlzIG5vdCBzZXQKIyBDT05GSUdfTU1BNzY2MCBpcyBub3Qgc2V0CiMg Q09ORklHX01NQTg0NTIgaXMgbm90IHNldAojIENPTkZJR19NTUE5NTUxIGlzIG5vdCBzZXQKIyBD T05GSUdfTU1BOTU1MyBpcyBub3Qgc2V0CiMgQ09ORklHX01YQzQwMDUgaXMgbm90IHNldAojIENP TkZJR19NWEM2MjU1IGlzIG5vdCBzZXQKIyBDT05GSUdfU1RLODMxMiBpcyBub3Qgc2V0CiMgQ09O RklHX1NUSzhCQTUwIGlzIG5vdCBzZXQKIyBlbmQgb2YgQWNjZWxlcm9tZXRlcnMKCiMKIyBBbmFs b2cgdG8gZGlnaXRhbCBjb252ZXJ0ZXJzCiMKIyBDT05GSUdfQUQ3MDkxUjUgaXMgbm90IHNldAoj IENPTkZJR19BRDcyOTEgaXMgbm90IHNldAojIENPTkZJR19BRDc2MDZfSUZBQ0VfUEFSQUxMRUwg aXMgbm90IHNldAojIENPTkZJR19BRDc5OVggaXMgbm90IHNldAojIENPTkZJR19BRElfQVhJX0FE QyBpcyBub3Qgc2V0CiMgQ09ORklHX0NDMTAwMDFfQURDIGlzIG5vdCBzZXQKIyBDT05GSUdfRU5W RUxPUEVfREVURUNUT1IgaXMgbm90IHNldAojIENPTkZJR19IWDcxMSBpcyBub3Qgc2V0CkNPTkZJ R19JTkEyWFhfQURDPXkKIyBDT05GSUdfTFRDMjQ3MSBpcyBub3Qgc2V0CiMgQ09ORklHX0xUQzI0 ODUgaXMgbm90IHNldAojIENPTkZJR19MVEMyNDk3IGlzIG5vdCBzZXQKIyBDT05GSUdfTUFYMTM2 MyBpcyBub3Qgc2V0CiMgQ09ORklHX01BWDk2MTEgaXMgbm90IHNldAojIENPTkZJR19NQ1AzNDIy IGlzIG5vdCBzZXQKIyBDT05GSUdfTkFVNzgwMiBpcyBub3Qgc2V0CiMgQ09ORklHX1NEX0FEQ19N T0RVTEFUT1IgaXMgbm90IHNldAojIENPTkZJR19USV9BREMwODFDIGlzIG5vdCBzZXQKIyBDT05G SUdfVElfQURTMTAxNSBpcyBub3Qgc2V0CiMgQ09ORklHX1ZGNjEwX0FEQyBpcyBub3Qgc2V0CkNP TkZJR19YSUxJTlhfWEFEQz15CiMgZW5kIG9mIEFuYWxvZyB0byBkaWdpdGFsIGNvbnZlcnRlcnMK CiMKIyBBbmFsb2cgRnJvbnQgRW5kcwojCiMgQ09ORklHX0lJT19SRVNDQUxFIGlzIG5vdCBzZXQK IyBlbmQgb2YgQW5hbG9nIEZyb250IEVuZHMKCiMKIyBBbXBsaWZpZXJzCiMKIyBDT05GSUdfSE1D NDI1IGlzIG5vdCBzZXQKIyBlbmQgb2YgQW1wbGlmaWVycwoKIwojIENhcGFjaXRhbmNlIHRvIGRp Z2l0YWwgY29udmVydGVycwojCiMgQ09ORklHX0FENzE1MCBpcyBub3Qgc2V0CiMgZW5kIG9mIENh cGFjaXRhbmNlIHRvIGRpZ2l0YWwgY29udmVydGVycwoKIwojIENoZW1pY2FsIFNlbnNvcnMKIwoj IENPTkZJR19BVExBU19QSF9TRU5TT1IgaXMgbm90IHNldAojIENPTkZJR19BVExBU19FWk9fU0VO U09SIGlzIG5vdCBzZXQKQ09ORklHX0JNRTY4MD15CkNPTkZJR19CTUU2ODBfSTJDPXkKIyBDT05G SUdfQ0NTODExIGlzIG5vdCBzZXQKIyBDT05GSUdfSUFRQ09SRSBpcyBub3Qgc2V0CiMgQ09ORklH X1BNUzcwMDMgaXMgbm90IHNldAojIENPTkZJR19TQ0QzMF9DT1JFIGlzIG5vdCBzZXQKIyBDT05G SUdfU0VOU0lSSU9OX1NHUDMwIGlzIG5vdCBzZXQKIyBDT05GSUdfU1BTMzBfSTJDIGlzIG5vdCBz ZXQKIyBDT05GSUdfU1BTMzBfU0VSSUFMIGlzIG5vdCBzZXQKIyBDT05GSUdfVlo4OVggaXMgbm90 IHNldAojIGVuZCBvZiBDaGVtaWNhbCBTZW5zb3JzCgojCiMgSGlkIFNlbnNvciBJSU8gQ29tbW9u CiMKIyBlbmQgb2YgSGlkIFNlbnNvciBJSU8gQ29tbW9uCgojCiMgSUlPIFNDTUkgU2Vuc29ycwoj CiMgZW5kIG9mIElJTyBTQ01JIFNlbnNvcnMKCiMKIyBTU1AgU2Vuc29yIENvbW1vbgojCiMgZW5k IG9mIFNTUCBTZW5zb3IgQ29tbW9uCgojCiMgRGlnaXRhbCB0byBhbmFsb2cgY29udmVydGVycwoj CiMgQ09ORklHX0FENTA2NCBpcyBub3Qgc2V0CiMgQ09ORklHX0FENTM4MCBpcyBub3Qgc2V0CiMg Q09ORklHX0FENTQ0NiBpcyBub3Qgc2V0CiMgQ09ORklHX0FENTU5M1IgaXMgbm90IHNldAojIENP TkZJR19BRDU2OTZfSTJDIGlzIG5vdCBzZXQKIyBDT05GSUdfRFBPVF9EQUMgaXMgbm90IHNldAoj IENPTkZJR19EUzQ0MjQgaXMgbm90IHNldAojIENPTkZJR19NNjIzMzIgaXMgbm90IHNldAojIENP TkZJR19NQVg1MTcgaXMgbm90IHNldAojIENPTkZJR19NQVg1ODIxIGlzIG5vdCBzZXQKIyBDT05G SUdfTUNQNDcyNSBpcyBub3Qgc2V0CiMgQ09ORklHX1RJX0RBQzU1NzEgaXMgbm90IHNldAojIENP TkZJR19WRjYxMF9EQUMgaXMgbm90IHNldAojIGVuZCBvZiBEaWdpdGFsIHRvIGFuYWxvZyBjb252 ZXJ0ZXJzCgojCiMgSUlPIGR1bW15IGRyaXZlcgojCiMgZW5kIG9mIElJTyBkdW1teSBkcml2ZXIK CiMKIyBGcmVxdWVuY3kgU3ludGhlc2l6ZXJzIEREUy9QTEwKIwoKIwojIENsb2NrIEdlbmVyYXRv ci9EaXN0cmlidXRpb24KIwojIGVuZCBvZiBDbG9jayBHZW5lcmF0b3IvRGlzdHJpYnV0aW9uCgoj CiMgUGhhc2UtTG9ja2VkIExvb3AgKFBMTCkgZnJlcXVlbmN5IHN5bnRoZXNpemVycwojCiMgZW5k IG9mIFBoYXNlLUxvY2tlZCBMb29wIChQTEwpIGZyZXF1ZW5jeSBzeW50aGVzaXplcnMKIyBlbmQg b2YgRnJlcXVlbmN5IFN5bnRoZXNpemVycyBERFMvUExMCgojCiMgRGlnaXRhbCBneXJvc2NvcGUg c2Vuc29ycwojCkNPTkZJR19CTUcxNjA9eQpDT05GSUdfQk1HMTYwX0kyQz15CiMgQ09ORklHX0ZY QVMyMTAwMkMgaXMgbm90IHNldAojIENPTkZJR19NUFUzMDUwX0kyQyBpcyBub3Qgc2V0CiMgQ09O RklHX0lJT19TVF9HWVJPXzNBWElTIGlzIG5vdCBzZXQKIyBDT05GSUdfSVRHMzIwMCBpcyBub3Qg c2V0CiMgZW5kIG9mIERpZ2l0YWwgZ3lyb3Njb3BlIHNlbnNvcnMKCiMKIyBIZWFsdGggU2Vuc29y cwojCgojCiMgSGVhcnQgUmF0ZSBNb25pdG9ycwojCiMgQ09ORklHX0FGRTQ0MDQgaXMgbm90IHNl dAojIENPTkZJR19NQVgzMDEwMCBpcyBub3Qgc2V0CiMgQ09ORklHX01BWDMwMTAyIGlzIG5vdCBz ZXQKIyBlbmQgb2YgSGVhcnQgUmF0ZSBNb25pdG9ycwojIGVuZCBvZiBIZWFsdGggU2Vuc29ycwoK IwojIEh1bWlkaXR5IHNlbnNvcnMKIwojIENPTkZJR19BTTIzMTUgaXMgbm90IHNldAojIENPTkZJ R19ESFQxMSBpcyBub3Qgc2V0CiMgQ09ORklHX0hEQzEwMFggaXMgbm90IHNldAojIENPTkZJR19I REMyMDEwIGlzIG5vdCBzZXQKIyBDT05GSUdfSFRTMjIxIGlzIG5vdCBzZXQKIyBDT05GSUdfSFRV MjEgaXMgbm90IHNldAojIENPTkZJR19TSTcwMDUgaXMgbm90IHNldAojIENPTkZJR19TSTcwMjAg aXMgbm90IHNldAojIGVuZCBvZiBIdW1pZGl0eSBzZW5zb3JzCgojCiMgSW5lcnRpYWwgbWVhc3Vy ZW1lbnQgdW5pdHMKIwojIENPTkZJR19CTUkxNjBfSTJDIGlzIG5vdCBzZXQKIyBDT05GSUdfRlhP Uzg3MDBfSTJDIGlzIG5vdCBzZXQKIyBDT05GSUdfS01YNjEgaXMgbm90IHNldAojIENPTkZJR19J TlZfSUNNNDI2MDBfSTJDIGlzIG5vdCBzZXQKIyBDT05GSUdfSU5WX01QVTYwNTBfSTJDIGlzIG5v dCBzZXQKIyBDT05GSUdfSUlPX1NUX0xTTTZEU1ggaXMgbm90IHNldAojIENPTkZJR19JSU9fU1Rf TFNNOURTMCBpcyBub3Qgc2V0CiMgZW5kIG9mIEluZXJ0aWFsIG1lYXN1cmVtZW50IHVuaXRzCgoj CiMgTGlnaHQgc2Vuc29ycwojCiMgQ09ORklHX0FESkRfUzMxMSBpcyBub3Qgc2V0CiMgQ09ORklH X0FEVVgxMDIwIGlzIG5vdCBzZXQKIyBDT05GSUdfQUwzMDEwIGlzIG5vdCBzZXQKIyBDT05GSUdf QUwzMzIwQSBpcyBub3Qgc2V0CiMgQ09ORklHX0FQRFM5MzAwIGlzIG5vdCBzZXQKIyBDT05GSUdf QVBEUzk5NjAgaXMgbm90IHNldAojIENPTkZJR19BUzczMjExIGlzIG5vdCBzZXQKIyBDT05GSUdf QkgxNzUwIGlzIG5vdCBzZXQKIyBDT05GSUdfQkgxNzgwIGlzIG5vdCBzZXQKIyBDT05GSUdfQ00z MjE4MSBpcyBub3Qgc2V0CiMgQ09ORklHX0NNMzIzMiBpcyBub3Qgc2V0CiMgQ09ORklHX0NNMzMy MyBpcyBub3Qgc2V0CiMgQ09ORklHX0NNMzYwNSBpcyBub3Qgc2V0CiMgQ09ORklHX0NNMzY2NTEg aXMgbm90IHNldAojIENPTkZJR19HUDJBUDAwMiBpcyBub3Qgc2V0CiMgQ09ORklHX0dQMkFQMDIw QTAwRiBpcyBub3Qgc2V0CiMgQ09ORklHX1NFTlNPUlNfSVNMMjkwMTggaXMgbm90IHNldAojIENP TkZJR19TRU5TT1JTX0lTTDI5MDI4IGlzIG5vdCBzZXQKIyBDT05GSUdfSVNMMjkxMjUgaXMgbm90 IHNldAojIENPTkZJR19KU0ExMjEyIGlzIG5vdCBzZXQKIyBDT05GSUdfUlBSMDUyMSBpcyBub3Qg c2V0CiMgQ09ORklHX0xUUjUwMSBpcyBub3Qgc2V0CiMgQ09ORklHX0xWMDEwNENTIGlzIG5vdCBz ZXQKIyBDT05GSUdfTUFYNDQwMDAgaXMgbm90IHNldAojIENPTkZJR19NQVg0NDAwOSBpcyBub3Qg c2V0CiMgQ09ORklHX05PQTEzMDUgaXMgbm90IHNldAojIENPTkZJR19PUFQzMDAxIGlzIG5vdCBz ZXQKIyBDT05GSUdfUEExMjIwMzAwMSBpcyBub3Qgc2V0CiMgQ09ORklHX1NJMTEzMyBpcyBub3Qg c2V0CiMgQ09ORklHX1NJMTE0NSBpcyBub3Qgc2V0CiMgQ09ORklHX1NUSzMzMTAgaXMgbm90IHNl dAojIENPTkZJR19TVF9VVklTMjUgaXMgbm90IHNldAojIENPTkZJR19UQ1MzNDE0IGlzIG5vdCBz ZXQKIyBDT05GSUdfVENTMzQ3MiBpcyBub3Qgc2V0CiMgQ09ORklHX1NFTlNPUlNfVFNMMjU2MyBp cyBub3Qgc2V0CiMgQ09ORklHX1RTTDI1ODMgaXMgbm90IHNldAojIENPTkZJR19UU0wyNTkxIGlz IG5vdCBzZXQKIyBDT05GSUdfVFNMMjc3MiBpcyBub3Qgc2V0CiMgQ09ORklHX1RTTDQ1MzEgaXMg bm90IHNldAojIENPTkZJR19VUzUxODJEIGlzIG5vdCBzZXQKIyBDT05GSUdfVkNOTDQwMDAgaXMg bm90IHNldAojIENPTkZJR19WQ05MNDAzNSBpcyBub3Qgc2V0CiMgQ09ORklHX1ZFTUw2MDMwIGlz IG5vdCBzZXQKIyBDT05GSUdfVkVNTDYwNzAgaXMgbm90IHNldAojIENPTkZJR19WTDYxODAgaXMg bm90IHNldAojIENPTkZJR19aT1BUMjIwMSBpcyBub3Qgc2V0CiMgZW5kIG9mIExpZ2h0IHNlbnNv cnMKCiMKIyBNYWduZXRvbWV0ZXIgc2Vuc29ycwojCiMgQ09ORklHX0FLODk3NCBpcyBub3Qgc2V0 CiMgQ09ORklHX0FLODk3NSBpcyBub3Qgc2V0CiMgQ09ORklHX0FLMDk5MTEgaXMgbm90IHNldAoj IENPTkZJR19CTUMxNTBfTUFHTl9JMkMgaXMgbm90IHNldAojIENPTkZJR19NQUczMTEwIGlzIG5v dCBzZXQKIyBDT05GSUdfTU1DMzUyNDAgaXMgbm90IHNldAojIENPTkZJR19JSU9fU1RfTUFHTl8z QVhJUyBpcyBub3Qgc2V0CiMgQ09ORklHX1NFTlNPUlNfSE1DNTg0M19JMkMgaXMgbm90IHNldAoj IENPTkZJR19TRU5TT1JTX1JNMzEwMF9JMkMgaXMgbm90IHNldAojIENPTkZJR19ZQU1BSEFfWUFT NTMwIGlzIG5vdCBzZXQKIyBlbmQgb2YgTWFnbmV0b21ldGVyIHNlbnNvcnMKCiMKIyBNdWx0aXBs ZXhlcnMKIwojIENPTkZJR19JSU9fTVVYIGlzIG5vdCBzZXQKIyBlbmQgb2YgTXVsdGlwbGV4ZXJz CgojCiMgSW5jbGlub21ldGVyIHNlbnNvcnMKIwojIGVuZCBvZiBJbmNsaW5vbWV0ZXIgc2Vuc29y cwoKIwojIFRyaWdnZXJzIC0gc3RhbmRhbG9uZQojCiMgQ09ORklHX0lJT19JTlRFUlJVUFRfVFJJ R0dFUiBpcyBub3Qgc2V0CiMgQ09ORklHX0lJT19TWVNGU19UUklHR0VSIGlzIG5vdCBzZXQKIyBl bmQgb2YgVHJpZ2dlcnMgLSBzdGFuZGFsb25lCgojCiMgTGluZWFyIGFuZCBhbmd1bGFyIHBvc2l0 aW9uIHNlbnNvcnMKIwojIGVuZCBvZiBMaW5lYXIgYW5kIGFuZ3VsYXIgcG9zaXRpb24gc2Vuc29y cwoKIwojIERpZ2l0YWwgcG90ZW50aW9tZXRlcnMKIwojIENPTkZJR19BRDUyNzIgaXMgbm90IHNl dAojIENPTkZJR19EUzE4MDMgaXMgbm90IHNldAojIENPTkZJR19NQVg1NDMyIGlzIG5vdCBzZXQK IyBDT05GSUdfTUNQNDAxOCBpcyBub3Qgc2V0CiMgQ09ORklHX01DUDQ1MzEgaXMgbm90IHNldAoj IENPTkZJR19UUEwwMTAyIGlzIG5vdCBzZXQKIyBlbmQgb2YgRGlnaXRhbCBwb3RlbnRpb21ldGVy cwoKIwojIERpZ2l0YWwgcG90ZW50aW9zdGF0cwojCiMgQ09ORklHX0xNUDkxMDAwIGlzIG5vdCBz ZXQKIyBlbmQgb2YgRGlnaXRhbCBwb3RlbnRpb3N0YXRzCgojCiMgUHJlc3N1cmUgc2Vuc29ycwoj CiMgQ09ORklHX0FCUDA2ME1HIGlzIG5vdCBzZXQKIyBDT05GSUdfQk1QMjgwIGlzIG5vdCBzZXQK IyBDT05GSUdfRExITDYwRCBpcyBub3Qgc2V0CiMgQ09ORklHX0RQUzMxMCBpcyBub3Qgc2V0CiMg Q09ORklHX0hQMDMgaXMgbm90IHNldAojIENPTkZJR19JQ1AxMDEwMCBpcyBub3Qgc2V0CiMgQ09O RklHX01QTDExNV9JMkMgaXMgbm90IHNldAojIENPTkZJR19NUEwzMTE1IGlzIG5vdCBzZXQKIyBD T05GSUdfTVM1NjExIGlzIG5vdCBzZXQKIyBDT05GSUdfTVM1NjM3IGlzIG5vdCBzZXQKIyBDT05G SUdfSUlPX1NUX1BSRVNTIGlzIG5vdCBzZXQKIyBDT05GSUdfVDU0MDMgaXMgbm90IHNldAojIENP TkZJR19IUDIwNkMgaXMgbm90IHNldAojIENPTkZJR19aUEEyMzI2IGlzIG5vdCBzZXQKIyBlbmQg b2YgUHJlc3N1cmUgc2Vuc29ycwoKIwojIExpZ2h0bmluZyBzZW5zb3JzCiMKIyBlbmQgb2YgTGln aHRuaW5nIHNlbnNvcnMKCiMKIyBQcm94aW1pdHkgYW5kIGRpc3RhbmNlIHNlbnNvcnMKIwojIENP TkZJR19JU0wyOTUwMSBpcyBub3Qgc2V0CiMgQ09ORklHX0xJREFSX0xJVEVfVjIgaXMgbm90IHNl dAojIENPTkZJR19NQjEyMzIgaXMgbm90IHNldAojIENPTkZJR19QSU5HIGlzIG5vdCBzZXQKIyBD T05GSUdfUkZENzc0MDIgaXMgbm90IHNldAojIENPTkZJR19TUkYwNCBpcyBub3Qgc2V0CiMgQ09O RklHX1NYOTMxMCBpcyBub3Qgc2V0CiMgQ09ORklHX1NYOTUwMCBpcyBub3Qgc2V0CiMgQ09ORklH X1NSRjA4IGlzIG5vdCBzZXQKIyBDT05GSUdfVkNOTDMwMjAgaXMgbm90IHNldAojIENPTkZJR19W TDUzTDBYX0kyQyBpcyBub3Qgc2V0CiMgZW5kIG9mIFByb3hpbWl0eSBhbmQgZGlzdGFuY2Ugc2Vu c29ycwoKIwojIFJlc29sdmVyIHRvIGRpZ2l0YWwgY29udmVydGVycwojCiMgZW5kIG9mIFJlc29s dmVyIHRvIGRpZ2l0YWwgY29udmVydGVycwoKIwojIFRlbXBlcmF0dXJlIHNlbnNvcnMKIwojIENP TkZJR19NTFg5MDYxNCBpcyBub3Qgc2V0CiMgQ09ORklHX01MWDkwNjMyIGlzIG5vdCBzZXQKIyBD T05GSUdfVE1QMDA2IGlzIG5vdCBzZXQKIyBDT05GSUdfVE1QMDA3IGlzIG5vdCBzZXQKIyBDT05G SUdfVE1QMTE3IGlzIG5vdCBzZXQKIyBDT05GSUdfVFNZUzAxIGlzIG5vdCBzZXQKIyBDT05GSUdf VFNZUzAyRCBpcyBub3Qgc2V0CiMgZW5kIG9mIFRlbXBlcmF0dXJlIHNlbnNvcnMKCiMgQ09ORklH X1BXTSBpcyBub3Qgc2V0CgojCiMgSVJRIGNoaXAgc3VwcG9ydAojCkNPTkZJR19JUlFDSElQPXkK Q09ORklHX0FSTV9HSUM9eQpDT05GSUdfQVJNX0dJQ19NQVhfTlI9MQpDT05GSUdfQVJNX0dJQ19W Mz15CkNPTkZJR19BUk1fR0lDX1YzX0lUUz15CiMgQ09ORklHX0FMX0ZJQyBpcyBub3Qgc2V0CiMg Q09ORklHX1hJTElOWF9JTlRDIGlzIG5vdCBzZXQKQ09ORklHX1BBUlRJVElPTl9QRVJDUFU9eQoj IGVuZCBvZiBJUlEgY2hpcCBzdXBwb3J0CgojIENPTkZJR19JUEFDS19CVVMgaXMgbm90IHNldApD T05GSUdfUkVTRVRfQ09OVFJPTExFUj15CiMgQ09ORklHX1JFU0VUX1RJX1NZU0NPTiBpcyBub3Qg c2V0CgojCiMgUEhZIFN1YnN5c3RlbQojCkNPTkZJR19HRU5FUklDX1BIWT15CiMgQ09ORklHX1BI WV9YR0VORSBpcyBub3Qgc2V0CiMgQ09ORklHX1BIWV9DQU5fVFJBTlNDRUlWRVIgaXMgbm90IHNl dAojIENPTkZJR19CQ01fS09OQV9VU0IyX1BIWSBpcyBub3Qgc2V0CiMgQ09ORklHX1BIWV9DQURF TkNFX1RPUlJFTlQgaXMgbm90IHNldAojIENPTkZJR19QSFlfQ0FERU5DRV9EUEhZIGlzIG5vdCBz ZXQKIyBDT05GSUdfUEhZX0NBREVOQ0VfU0lFUlJBIGlzIG5vdCBzZXQKIyBDT05GSUdfUEhZX0NB REVOQ0VfU0FMVk8gaXMgbm90IHNldAojIENPTkZJR19QSFlfRlNMX0lNWDhNUV9VU0IgaXMgbm90 IHNldAojIENPTkZJR19QSFlfTUlYRUxfTUlQSV9EUEhZIGlzIG5vdCBzZXQKIyBDT05GSUdfUEhZ X1BYQV8yOE5NX0hTSUMgaXMgbm90IHNldAojIENPTkZJR19QSFlfUFhBXzI4Tk1fVVNCMiBpcyBu b3Qgc2V0CiMgQ09ORklHX1BIWV9YSUxJTlhfWllOUU1QIGlzIG5vdCBzZXQKIyBlbmQgb2YgUEhZ IFN1YnN5c3RlbQoKIyBDT05GSUdfUE9XRVJDQVAgaXMgbm90IHNldAojIENPTkZJR19NQ0IgaXMg bm90IHNldAoKIwojIFBlcmZvcm1hbmNlIG1vbml0b3Igc3VwcG9ydAojCiMgQ09ORklHX0FSTV9D Q0lfUE1VIGlzIG5vdCBzZXQKIyBDT05GSUdfQVJNX0NDTiBpcyBub3Qgc2V0CiMgQ09ORklHX0FS TV9DTU4gaXMgbm90IHNldApDT05GSUdfQVJNX1BNVT15CiMgQ09ORklHX0FSTV9EU1VfUE1VIGlz IG5vdCBzZXQKIyBDT05GSUdfQVJNX1NQRV9QTVUgaXMgbm90IHNldAojIGVuZCBvZiBQZXJmb3Jt YW5jZSBtb25pdG9yIHN1cHBvcnQKCkNPTkZJR19SQVM9eQoKIwojIEFuZHJvaWQKIwpDT05GSUdf QU5EUk9JRD15CiMgQ09ORklHX0FORFJPSURfQklOREVSX0lQQyBpcyBub3Qgc2V0CiMgZW5kIG9m IEFuZHJvaWQKCiMgQ09ORklHX0RBWCBpcyBub3Qgc2V0CkNPTkZJR19OVk1FTT15CkNPTkZJR19O Vk1FTV9TWVNGUz15CkNPTkZJR19OVk1FTV9aWU5RTVA9eQojIENPTkZJR19OVk1FTV9STUVNIGlz IG5vdCBzZXQKCiMKIyBIVyB0cmFjaW5nIHN1cHBvcnQKIwojIENPTkZJR19TVE0gaXMgbm90IHNl dAojIENPTkZJR19JTlRFTF9USCBpcyBub3Qgc2V0CiMgZW5kIG9mIEhXIHRyYWNpbmcgc3VwcG9y dAoKQ09ORklHX0ZQR0E9eQojIENPTkZJR19BTFRFUkFfUFJfSVBfQ09SRSBpcyBub3Qgc2V0CkNP TkZJR19GUEdBX0JSSURHRT15CiMgQ09ORklHX0FMVEVSQV9GUkVFWkVfQlJJREdFIGlzIG5vdCBz ZXQKQ09ORklHX1hJTElOWF9QUl9ERUNPVVBMRVI9eQpDT05GSUdfRlBHQV9SRUdJT049eQpDT05G SUdfT0ZfRlBHQV9SRUdJT049eQojIENPTkZJR19GUEdBX0RGTCBpcyBub3Qgc2V0CkNPTkZJR19G UEdBX01HUl9aWU5RTVBfRlBHQT15CiMgQ09ORklHX0ZTSSBpcyBub3Qgc2V0CiMgQ09ORklHX1RF RSBpcyBub3Qgc2V0CkNPTkZJR19QTV9PUFA9eQojIENPTkZJR19TSU9YIGlzIG5vdCBzZXQKIyBD T05GSUdfU0xJTUJVUyBpcyBub3Qgc2V0CiMgQ09ORklHX0lOVEVSQ09OTkVDVCBpcyBub3Qgc2V0 CiMgQ09ORklHX0NPVU5URVIgaXMgbm90IHNldAojIENPTkZJR19NT1NUIGlzIG5vdCBzZXQKIyBl bmQgb2YgRGV2aWNlIERyaXZlcnMKCiMKIyBGaWxlIHN5c3RlbXMKIwpDT05GSUdfRENBQ0hFX1dP UkRfQUNDRVNTPXkKIyBDT05GSUdfVkFMSURBVEVfRlNfUEFSU0VSIGlzIG5vdCBzZXQKQ09ORklH X0ZTX1BPU0lYX0FDTD15CkNPTkZJR19FWFBPUlRGUz15CiMgQ09ORklHX0VYUE9SVEZTX0JMT0NL X09QUyBpcyBub3Qgc2V0CiMgQ09ORklHX0ZJTEVfTE9DS0lORyBpcyBub3Qgc2V0CiMgQ09ORklH X0ZTX0VOQ1JZUFRJT04gaXMgbm90IHNldAojIENPTkZJR19GU19WRVJJVFkgaXMgbm90IHNldAoj IENPTkZJR19ETk9USUZZIGlzIG5vdCBzZXQKIyBDT05GSUdfSU5PVElGWV9VU0VSIGlzIG5vdCBz ZXQKIyBDT05GSUdfRkFOT1RJRlkgaXMgbm90IHNldAojIENPTkZJR19RVU9UQSBpcyBub3Qgc2V0 CiMgQ09ORklHX0FVVE9GUzRfRlMgaXMgbm90IHNldAojIENPTkZJR19BVVRPRlNfRlMgaXMgbm90 IHNldAojIENPTkZJR19GVVNFX0ZTIGlzIG5vdCBzZXQKIyBDT05GSUdfT1ZFUkxBWV9GUyBpcyBu b3Qgc2V0CgojCiMgQ2FjaGVzCiMKIyBDT05GSUdfRlNDQUNIRSBpcyBub3Qgc2V0CiMgZW5kIG9m IENhY2hlcwoKIwojIFBzZXVkbyBmaWxlc3lzdGVtcwojCkNPTkZJR19QUk9DX0ZTPXkKIyBDT05G SUdfUFJPQ19LQ09SRSBpcyBub3Qgc2V0CkNPTkZJR19QUk9DX1NZU0NUTD15CkNPTkZJR19QUk9D X1BBR0VfTU9OSVRPUj15CiMgQ09ORklHX1BST0NfQ0hJTERSRU4gaXMgbm90IHNldApDT05GSUdf S0VSTkZTPXkKQ09ORklHX1NZU0ZTPXkKQ09ORklHX1RNUEZTPXkKQ09ORklHX1RNUEZTX1BPU0lY X0FDTD15CkNPTkZJR19UTVBGU19YQVRUUj15CiMgQ09ORklHX1RNUEZTX0lOT0RFNjQgaXMgbm90 IHNldApDT05GSUdfQVJDSF9TVVBQT1JUU19IVUdFVExCRlM9eQpDT05GSUdfSFVHRVRMQkZTPXkK Q09ORklHX0hVR0VUTEJfUEFHRT15CkNPTkZJR19NRU1GRF9DUkVBVEU9eQpDT05GSUdfQVJDSF9I QVNfR0lHQU5USUNfUEFHRT15CkNPTkZJR19DT05GSUdGU19GUz15CkNPTkZJR19FRklWQVJfRlM9 eQojIGVuZCBvZiBQc2V1ZG8gZmlsZXN5c3RlbXMKCiMgQ09ORklHX01JU0NfRklMRVNZU1RFTVMg aXMgbm90IHNldAojIENPTkZJR19OTFMgaXMgbm90IHNldAojIENPTkZJR19VTklDT0RFIGlzIG5v dCBzZXQKQ09ORklHX0lPX1dRPXkKIyBlbmQgb2YgRmlsZSBzeXN0ZW1zCgojCiMgU2VjdXJpdHkg b3B0aW9ucwojCkNPTkZJR19LRVlTPXkKIyBDT05GSUdfS0VZU19SRVFVRVNUX0NBQ0hFIGlzIG5v dCBzZXQKIyBDT05GSUdfUEVSU0lTVEVOVF9LRVlSSU5HUyBpcyBub3Qgc2V0CiMgQ09ORklHX1RS VVNURURfS0VZUyBpcyBub3Qgc2V0CiMgQ09ORklHX0VOQ1JZUFRFRF9LRVlTIGlzIG5vdCBzZXQK IyBDT05GSUdfS0VZX0RIX09QRVJBVElPTlMgaXMgbm90IHNldAojIENPTkZJR19TRUNVUklUWV9E TUVTR19SRVNUUklDVCBpcyBub3Qgc2V0CiMgQ09ORklHX1NFQ1VSSVRZIGlzIG5vdCBzZXQKQ09O RklHX1NFQ1VSSVRZRlM9eQpDT05GSUdfSEFWRV9IQVJERU5FRF9VU0VSQ09QWV9BTExPQ0FUT1I9 eQojIENPTkZJR19IQVJERU5FRF9VU0VSQ09QWSBpcyBub3Qgc2V0CiMgQ09ORklHX0ZPUlRJRllf U09VUkNFIGlzIG5vdCBzZXQKIyBDT05GSUdfU1RBVElDX1VTRVJNT0RFSEVMUEVSIGlzIG5vdCBz ZXQKIyBDT05GSUdfSU1BX1NFQ1VSRV9BTkRfT1JfVFJVU1RFRF9CT09UIGlzIG5vdCBzZXQKQ09O RklHX0RFRkFVTFRfU0VDVVJJVFlfREFDPXkKQ09ORklHX0xTTT0ibGFuZGxvY2ssbG9ja2Rvd24s eWFtYSxsb2FkcGluLHNhZmVzZXRpZCxpbnRlZ3JpdHksYnBmIgoKIwojIEtlcm5lbCBoYXJkZW5p bmcgb3B0aW9ucwojCgojCiMgTWVtb3J5IGluaXRpYWxpemF0aW9uCiMKQ09ORklHX0lOSVRfU1RB Q0tfTk9ORT15CiMgQ09ORklHX0lOSVRfT05fQUxMT0NfREVGQVVMVF9PTiBpcyBub3Qgc2V0CiMg Q09ORklHX0lOSVRfT05fRlJFRV9ERUZBVUxUX09OIGlzIG5vdCBzZXQKIyBlbmQgb2YgTWVtb3J5 IGluaXRpYWxpemF0aW9uCiMgZW5kIG9mIEtlcm5lbCBoYXJkZW5pbmcgb3B0aW9ucwojIGVuZCBv ZiBTZWN1cml0eSBvcHRpb25zCgpDT05GSUdfQ1JZUFRPPXkKCiMKIyBDcnlwdG8gY29yZSBvciBo ZWxwZXIKIwojIENPTkZJR19DUllQVE9fRklQUyBpcyBub3Qgc2V0CkNPTkZJR19DUllQVE9fQUxH QVBJPXkKQ09ORklHX0NSWVBUT19BTEdBUEkyPXkKQ09ORklHX0NSWVBUT19BRUFEPXkKQ09ORklH X0NSWVBUT19BRUFEMj15CkNPTkZJR19DUllQVE9fU0tDSVBIRVI9eQpDT05GSUdfQ1JZUFRPX1NL Q0lQSEVSMj15CkNPTkZJR19DUllQVE9fSEFTSD15CkNPTkZJR19DUllQVE9fSEFTSDI9eQpDT05G SUdfQ1JZUFRPX1JORz15CkNPTkZJR19DUllQVE9fUk5HMj15CkNPTkZJR19DUllQVE9fUk5HX0RF RkFVTFQ9eQpDT05GSUdfQ1JZUFRPX0FLQ0lQSEVSMj15CkNPTkZJR19DUllQVE9fQUtDSVBIRVI9 eQpDT05GSUdfQ1JZUFRPX0tQUDI9eQpDT05GSUdfQ1JZUFRPX0tQUD15CkNPTkZJR19DUllQVE9f QUNPTVAyPXkKQ09ORklHX0NSWVBUT19NQU5BR0VSPXkKQ09ORklHX0NSWVBUT19NQU5BR0VSMj15 CiMgQ09ORklHX0NSWVBUT19NQU5BR0VSX0RJU0FCTEVfVEVTVFMgaXMgbm90IHNldAojIENPTkZJ R19DUllQVE9fTUFOQUdFUl9FWFRSQV9URVNUUyBpcyBub3Qgc2V0CkNPTkZJR19DUllQVE9fR0Yx MjhNVUw9eQpDT05GSUdfQ1JZUFRPX05VTEw9eQpDT05GSUdfQ1JZUFRPX05VTEwyPXkKIyBDT05G SUdfQ1JZUFRPX1BDUllQVCBpcyBub3Qgc2V0CiMgQ09ORklHX0NSWVBUT19DUllQVEQgaXMgbm90 IHNldAojIENPTkZJR19DUllQVE9fQVVUSEVOQyBpcyBub3Qgc2V0CiMgQ09ORklHX0NSWVBUT19U RVNUIGlzIG5vdCBzZXQKQ09ORklHX0NSWVBUT19FTkdJTkU9eQoKIwojIFB1YmxpYy1rZXkgY3J5 cHRvZ3JhcGh5CiMKQ09ORklHX0NSWVBUT19SU0E9eQojIENPTkZJR19DUllQVE9fREggaXMgbm90 IHNldApDT05GSUdfQ1JZUFRPX0VDQz15CkNPTkZJR19DUllQVE9fRUNESD15CiMgQ09ORklHX0NS WVBUT19FQ0RTQSBpcyBub3Qgc2V0CiMgQ09ORklHX0NSWVBUT19FQ1JEU0EgaXMgbm90IHNldAoj IENPTkZJR19DUllQVE9fU00yIGlzIG5vdCBzZXQKIyBDT05GSUdfQ1JZUFRPX0NVUlZFMjU1MTkg aXMgbm90IHNldAoKIwojIEF1dGhlbnRpY2F0ZWQgRW5jcnlwdGlvbiB3aXRoIEFzc29jaWF0ZWQg RGF0YQojCkNPTkZJR19DUllQVE9fQ0NNPXkKQ09ORklHX0NSWVBUT19HQ009eQojIENPTkZJR19D UllQVE9fQ0hBQ0hBMjBQT0xZMTMwNSBpcyBub3Qgc2V0CiMgQ09ORklHX0NSWVBUT19BRUdJUzEy OCBpcyBub3Qgc2V0CiMgQ09ORklHX0NSWVBUT19TRVFJViBpcyBub3Qgc2V0CiMgQ09ORklHX0NS WVBUT19FQ0hBSU5JViBpcyBub3Qgc2V0CgojCiMgQmxvY2sgbW9kZXMKIwpDT05GSUdfQ1JZUFRP X0NCQz15CiMgQ09ORklHX0NSWVBUT19DRkIgaXMgbm90IHNldApDT05GSUdfQ1JZUFRPX0NUUj15 CiMgQ09ORklHX0NSWVBUT19DVFMgaXMgbm90IHNldApDT05GSUdfQ1JZUFRPX0VDQj15CiMgQ09O RklHX0NSWVBUT19MUlcgaXMgbm90IHNldAojIENPTkZJR19DUllQVE9fT0ZCIGlzIG5vdCBzZXQK IyBDT05GSUdfQ1JZUFRPX1BDQkMgaXMgbm90IHNldAojIENPTkZJR19DUllQVE9fWFRTIGlzIG5v dCBzZXQKIyBDT05GSUdfQ1JZUFRPX0tFWVdSQVAgaXMgbm90IHNldAojIENPTkZJR19DUllQVE9f QURJQU5UVU0gaXMgbm90IHNldAojIENPTkZJR19DUllQVE9fRVNTSVYgaXMgbm90IHNldAoKIwoj IEhhc2ggbW9kZXMKIwpDT05GSUdfQ1JZUFRPX0NNQUM9eQpDT05GSUdfQ1JZUFRPX0hNQUM9eQoj IENPTkZJR19DUllQVE9fWENCQyBpcyBub3Qgc2V0CiMgQ09ORklHX0NSWVBUT19WTUFDIGlzIG5v dCBzZXQKCiMKIyBEaWdlc3QKIwpDT05GSUdfQ1JZUFRPX0NSQzMyQz15CiMgQ09ORklHX0NSWVBU T19DUkMzMiBpcyBub3Qgc2V0CkNPTkZJR19DUllQVE9fWFhIQVNIPXkKQ09ORklHX0NSWVBUT19C TEFLRTJCPXkKIyBDT05GSUdfQ1JZUFRPX0JMQUtFMlMgaXMgbm90IHNldApDT05GSUdfQ1JZUFRP X0NSQ1QxMERJRj15CkNPTkZJR19DUllQVE9fR0hBU0g9eQojIENPTkZJR19DUllQVE9fUE9MWTEz MDUgaXMgbm90IHNldAojIENPTkZJR19DUllQVE9fTUQ0IGlzIG5vdCBzZXQKQ09ORklHX0NSWVBU T19NRDU9eQojIENPTkZJR19DUllQVE9fTUlDSEFFTF9NSUMgaXMgbm90IHNldAojIENPTkZJR19D UllQVE9fUk1EMTYwIGlzIG5vdCBzZXQKIyBDT05GSUdfQ1JZUFRPX1NIQTEgaXMgbm90IHNldAoj IENPTkZJR19DUllQVE9fU0hBMjU2IGlzIG5vdCBzZXQKQ09ORklHX0NSWVBUT19TSEE1MTI9eQoj IENPTkZJR19DUllQVE9fU0hBMyBpcyBub3Qgc2V0CiMgQ09ORklHX0NSWVBUT19TTTMgaXMgbm90 IHNldAojIENPTkZJR19DUllQVE9fU1RSRUVCT0cgaXMgbm90IHNldAojIENPTkZJR19DUllQVE9f V1A1MTIgaXMgbm90IHNldAoKIwojIENpcGhlcnMKIwpDT05GSUdfQ1JZUFRPX0FFUz15CiMgQ09O RklHX0NSWVBUT19BRVNfVEkgaXMgbm90IHNldAojIENPTkZJR19DUllQVE9fQkxPV0ZJU0ggaXMg bm90IHNldAojIENPTkZJR19DUllQVE9fQ0FNRUxMSUEgaXMgbm90IHNldAojIENPTkZJR19DUllQ VE9fQ0FTVDUgaXMgbm90IHNldAojIENPTkZJR19DUllQVE9fQ0FTVDYgaXMgbm90IHNldAojIENP TkZJR19DUllQVE9fREVTIGlzIG5vdCBzZXQKIyBDT05GSUdfQ1JZUFRPX0ZDUllQVCBpcyBub3Qg c2V0CiMgQ09ORklHX0NSWVBUT19DSEFDSEEyMCBpcyBub3Qgc2V0CiMgQ09ORklHX0NSWVBUT19T RVJQRU5UIGlzIG5vdCBzZXQKIyBDT05GSUdfQ1JZUFRPX1NNNCBpcyBub3Qgc2V0CiMgQ09ORklH X0NSWVBUT19UV09GSVNIIGlzIG5vdCBzZXQKCiMKIyBDb21wcmVzc2lvbgojCkNPTkZJR19DUllQ VE9fREVGTEFURT15CkNPTkZJR19DUllQVE9fTFpPPXkKIyBDT05GSUdfQ1JZUFRPXzg0MiBpcyBu b3Qgc2V0CiMgQ09ORklHX0NSWVBUT19MWjQgaXMgbm90IHNldAojIENPTkZJR19DUllQVE9fTFo0 SEMgaXMgbm90IHNldApDT05GSUdfQ1JZUFRPX1pTVEQ9eQoKIwojIFJhbmRvbSBOdW1iZXIgR2Vu ZXJhdGlvbgojCiMgQ09ORklHX0NSWVBUT19BTlNJX0NQUk5HIGlzIG5vdCBzZXQKQ09ORklHX0NS WVBUT19EUkJHX01FTlU9eQpDT05GSUdfQ1JZUFRPX0RSQkdfSE1BQz15CiMgQ09ORklHX0NSWVBU T19EUkJHX0hBU0ggaXMgbm90IHNldAojIENPTkZJR19DUllQVE9fRFJCR19DVFIgaXMgbm90IHNl dApDT05GSUdfQ1JZUFRPX0RSQkc9eQpDT05GSUdfQ1JZUFRPX0pJVFRFUkVOVFJPUFk9eQpDT05G SUdfQ1JZUFRPX0hBU0hfSU5GTz15CgojCiMgQ3J5cHRvIGxpYnJhcnkgcm91dGluZXMKIwpDT05G SUdfQ1JZUFRPX0xJQl9BRVM9eQojIENPTkZJR19DUllQVE9fTElCX0JMQUtFMlMgaXMgbm90IHNl dAojIENPTkZJR19DUllQVE9fTElCX0NIQUNIQSBpcyBub3Qgc2V0CiMgQ09ORklHX0NSWVBUT19M SUJfQ1VSVkUyNTUxOSBpcyBub3Qgc2V0CkNPTkZJR19DUllQVE9fTElCX1BPTFkxMzA1X1JTSVpF PTkKIyBDT05GSUdfQ1JZUFRPX0xJQl9QT0xZMTMwNSBpcyBub3Qgc2V0CiMgQ09ORklHX0NSWVBU T19MSUJfQ0hBQ0hBMjBQT0xZMTMwNSBpcyBub3Qgc2V0CkNPTkZJR19DUllQVE9fSFc9eQojIENP TkZJR19DUllQVE9fREVWX0FUTUVMX0VDQyBpcyBub3Qgc2V0CiMgQ09ORklHX0NSWVBUT19ERVZf QVRNRUxfU0hBMjA0QSBpcyBub3Qgc2V0CiMgQ09ORklHX0NSWVBUT19ERVZfQ0NQIGlzIG5vdCBz ZXQKIyBDT05GSUdfQ1JZUFRPX0RFVl9aWU5RTVBfQUVTIGlzIG5vdCBzZXQKQ09ORklHX0NSWVBU T19ERVZfVklSVElPPXkKIyBDT05GSUdfQ1JZUFRPX0RFVl9TQUZFWENFTCBpcyBub3Qgc2V0CiMg Q09ORklHX0NSWVBUT19ERVZfQ0NSRUUgaXMgbm90IHNldAojIENPTkZJR19DUllQVE9fREVWX0hJ U0lfU0VDIGlzIG5vdCBzZXQKIyBDT05GSUdfQ1JZUFRPX0RFVl9BTUxPR0lDX0dYTCBpcyBub3Qg c2V0CkNPTkZJR19BU1lNTUVUUklDX0tFWV9UWVBFPXkKQ09ORklHX0FTWU1NRVRSSUNfUFVCTElD X0tFWV9TVUJUWVBFPXkKQ09ORklHX1g1MDlfQ0VSVElGSUNBVEVfUEFSU0VSPXkKIyBDT05GSUdf UEtDUzhfUFJJVkFURV9LRVlfUEFSU0VSIGlzIG5vdCBzZXQKQ09ORklHX1BLQ1M3X01FU1NBR0Vf UEFSU0VSPXkKCiMKIyBDZXJ0aWZpY2F0ZXMgZm9yIHNpZ25hdHVyZSBjaGVja2luZwojCkNPTkZJ R19TWVNURU1fVFJVU1RFRF9LRVlSSU5HPXkKQ09ORklHX1NZU1RFTV9UUlVTVEVEX0tFWVM9IiIK IyBDT05GSUdfU1lTVEVNX0VYVFJBX0NFUlRJRklDQVRFIGlzIG5vdCBzZXQKIyBDT05GSUdfU0VD T05EQVJZX1RSVVNURURfS0VZUklORyBpcyBub3Qgc2V0CiMgQ09ORklHX1NZU1RFTV9CTEFDS0xJ U1RfS0VZUklORyBpcyBub3Qgc2V0CiMgZW5kIG9mIENlcnRpZmljYXRlcyBmb3Igc2lnbmF0dXJl IGNoZWNraW5nCgojCiMgTGlicmFyeSByb3V0aW5lcwojCkNPTkZJR19MSU5FQVJfUkFOR0VTPXkK IyBDT05GSUdfUEFDS0lORyBpcyBub3Qgc2V0CkNPTkZJR19CSVRSRVZFUlNFPXkKQ09ORklHX0hB VkVfQVJDSF9CSVRSRVZFUlNFPXkKQ09ORklHX0dFTkVSSUNfU1RSTkNQWV9GUk9NX1VTRVI9eQpD T05GSUdfR0VORVJJQ19TVFJOTEVOX1VTRVI9eQpDT05GSUdfR0VORVJJQ19GSU5EX0ZJUlNUX0JJ VD15CiMgQ09ORklHX0NPUkRJQyBpcyBub3Qgc2V0CiMgQ09ORklHX1BSSU1FX05VTUJFUlMgaXMg bm90IHNldApDT05GSUdfUkFUSU9OQUw9eQpDT05GSUdfR0VORVJJQ19QQ0lfSU9NQVA9eQpDT05G SUdfQVJDSF9VU0VfQ01QWENIR19MT0NLUkVGPXkKQ09ORklHX0FSQ0hfSEFTX0ZBU1RfTVVMVElQ TElFUj15CkNPTkZJR19BUkNIX1VTRV9TWU1fQU5OT1RBVElPTlM9eQojIENPTkZJR19JTkRJUkVD VF9QSU8gaXMgbm90IHNldAojIENPTkZJR19DUkNfQ0NJVFQgaXMgbm90IHNldApDT05GSUdfQ1JD MTY9eQojIENPTkZJR19DUkNfVDEwRElGIGlzIG5vdCBzZXQKIyBDT05GSUdfQ1JDX0lUVV9UIGlz IG5vdCBzZXQKQ09ORklHX0NSQzMyPXkKIyBDT05GSUdfQ1JDMzJfU0VMRlRFU1QgaXMgbm90IHNl dApDT05GSUdfQ1JDMzJfU0xJQ0VCWTg9eQojIENPTkZJR19DUkMzMl9TTElDRUJZNCBpcyBub3Qg c2V0CiMgQ09ORklHX0NSQzMyX1NBUldBVEUgaXMgbm90IHNldAojIENPTkZJR19DUkMzMl9CSVQg aXMgbm90IHNldAojIENPTkZJR19DUkM2NCBpcyBub3Qgc2V0CiMgQ09ORklHX0NSQzQgaXMgbm90 IHNldApDT05GSUdfQ1JDNz15CkNPTkZJR19MSUJDUkMzMkM9eQojIENPTkZJR19DUkM4IGlzIG5v dCBzZXQKQ09ORklHX1hYSEFTSD15CkNPTkZJR19BVURJVF9BUkNIX0NPTVBBVF9HRU5FUklDPXkK IyBDT05GSUdfUkFORE9NMzJfU0VMRlRFU1QgaXMgbm90IHNldApDT05GSUdfWkxJQl9JTkZMQVRF PXkKQ09ORklHX1pMSUJfREVGTEFURT15CkNPTkZJR19MWk9fQ09NUFJFU1M9eQpDT05GSUdfTFpP X0RFQ09NUFJFU1M9eQpDT05GSUdfTFo0X0RFQ09NUFJFU1M9eQpDT05GSUdfWlNURF9DT01QUkVT Uz15CkNPTkZJR19aU1REX0RFQ09NUFJFU1M9eQpDT05GSUdfWFpfREVDPXkKQ09ORklHX1haX0RF Q19YODY9eQpDT05GSUdfWFpfREVDX1BPV0VSUEM9eQpDT05GSUdfWFpfREVDX0lBNjQ9eQpDT05G SUdfWFpfREVDX0FSTT15CkNPTkZJR19YWl9ERUNfQVJNVEhVTUI9eQpDT05GSUdfWFpfREVDX1NQ QVJDPXkKQ09ORklHX1haX0RFQ19CQ0o9eQojIENPTkZJR19YWl9ERUNfVEVTVCBpcyBub3Qgc2V0 CkNPTkZJR19ERUNPTVBSRVNTX0daSVA9eQpDT05GSUdfREVDT01QUkVTU19CWklQMj15CkNPTkZJ R19ERUNPTVBSRVNTX0xaTUE9eQpDT05GSUdfREVDT01QUkVTU19YWj15CkNPTkZJR19ERUNPTVBS RVNTX0xaTz15CkNPTkZJR19ERUNPTVBSRVNTX0xaND15CkNPTkZJR19ERUNPTVBSRVNTX1pTVEQ9 eQpDT05GSUdfR0VORVJJQ19BTExPQ0FUT1I9eQpDT05GSUdfWEFSUkFZX01VTFRJPXkKQ09ORklH X0FTU09DSUFUSVZFX0FSUkFZPXkKQ09ORklHX0hBU19JT01FTT15CkNPTkZJR19IQVNfRE1BPXkK Q09ORklHX0RNQV9PUFM9eQpDT05GSUdfTkVFRF9TR19ETUFfTEVOR1RIPXkKQ09ORklHX05FRURf RE1BX01BUF9TVEFURT15CkNPTkZJR19BUkNIX0RNQV9BRERSX1RfNjRCSVQ9eQpDT05GSUdfRE1B X0RFQ0xBUkVfQ09IRVJFTlQ9eQpDT05GSUdfQVJDSF9IQVNfU0VUVVBfRE1BX09QUz15CkNPTkZJ R19BUkNIX0hBU19URUFSRE9XTl9ETUFfT1BTPXkKQ09ORklHX0FSQ0hfSEFTX1NZTkNfRE1BX0ZP Ul9ERVZJQ0U9eQpDT05GSUdfQVJDSF9IQVNfU1lOQ19ETUFfRk9SX0NQVT15CkNPTkZJR19BUkNI X0hBU19ETUFfUFJFUF9DT0hFUkVOVD15CkNPTkZJR19TV0lPVExCPXkKQ09ORklHX0RNQV9OT05D T0hFUkVOVF9NTUFQPXkKQ09ORklHX0RNQV9DT0hFUkVOVF9QT09MPXkKQ09ORklHX0RNQV9SRU1B UD15CkNPTkZJR19ETUFfRElSRUNUX1JFTUFQPXkKQ09ORklHX0RNQV9DTUE9eQojIENPTkZJR19E TUFfUEVSTlVNQV9DTUEgaXMgbm90IHNldAoKIwojIERlZmF1bHQgY29udGlndW91cyBtZW1vcnkg YXJlYSBzaXplOgojCkNPTkZJR19DTUFfU0laRV9NQllURVM9MjU2CkNPTkZJR19DTUFfU0laRV9T RUxfTUJZVEVTPXkKIyBDT05GSUdfQ01BX1NJWkVfU0VMX1BFUkNFTlRBR0UgaXMgbm90IHNldAoj IENPTkZJR19DTUFfU0laRV9TRUxfTUlOIGlzIG5vdCBzZXQKIyBDT05GSUdfQ01BX1NJWkVfU0VM X01BWCBpcyBub3Qgc2V0CkNPTkZJR19DTUFfQUxJR05NRU5UPTgKIyBDT05GSUdfRE1BX0FQSV9E RUJVRyBpcyBub3Qgc2V0CiMgQ09ORklHX0RNQV9NQVBfQkVOQ0hNQVJLIGlzIG5vdCBzZXQKQ09O RklHX1NHTF9BTExPQz15CkNPTkZJR19HTE9CPXkKIyBDT05GSUdfR0xPQl9TRUxGVEVTVCBpcyBu b3Qgc2V0CkNPTkZJR19DTFpfVEFCPXkKIyBDT05GSUdfSVJRX1BPTEwgaXMgbm90IHNldApDT05G SUdfTVBJTElCPXkKQ09ORklHX0xJQkZEVD15CkNPTkZJR19PSURfUkVHSVNUUlk9eQpDT05GSUdf VUNTMl9TVFJJTkc9eQpDT05GSUdfSEFWRV9HRU5FUklDX1ZEU089eQpDT05GSUdfR0VORVJJQ19H RVRUSU1FT0ZEQVk9eQpDT05GSUdfR0VORVJJQ19WRFNPX1RJTUVfTlM9eQpDT05GSUdfRk9OVF9T VVBQT1JUPXkKIyBDT05GSUdfRk9OVFMgaXMgbm90IHNldApDT05GSUdfRk9OVF84eDg9eQpDT05G SUdfRk9OVF84eDE2PXkKQ09ORklHX0FSQ0hfU1RBQ0tXQUxLPXkKIyBlbmQgb2YgTGlicmFyeSBy b3V0aW5lcwoKQ09ORklHX0dFTkVSSUNfTElCX0RFVk1FTV9JU19BTExPV0VEPXkKCiMKIyBLZXJu ZWwgaGFja2luZwojCgojCiMgcHJpbnRrIGFuZCBkbWVzZyBvcHRpb25zCiMKQ09ORklHX1BSSU5U S19USU1FPXkKIyBDT05GSUdfUFJJTlRLX0NBTExFUiBpcyBub3Qgc2V0CiMgQ09ORklHX1NUQUNL VFJBQ0VfQlVJTERfSUQgaXMgbm90IHNldApDT05GSUdfQ09OU09MRV9MT0dMRVZFTF9ERUZBVUxU PTcKQ09ORklHX0NPTlNPTEVfTE9HTEVWRUxfUVVJRVQ9NApDT05GSUdfTUVTU0FHRV9MT0dMRVZF TF9ERUZBVUxUPTQKIyBDT05GSUdfQk9PVF9QUklOVEtfREVMQVkgaXMgbm90IHNldAojIENPTkZJ R19EWU5BTUlDX0RFQlVHIGlzIG5vdCBzZXQKIyBDT05GSUdfRFlOQU1JQ19ERUJVR19DT1JFIGlz IG5vdCBzZXQKQ09ORklHX1NZTUJPTElDX0VSUk5BTUU9eQpDT05GSUdfREVCVUdfQlVHVkVSQk9T RT15CiMgZW5kIG9mIHByaW50ayBhbmQgZG1lc2cgb3B0aW9ucwoKIwojIENvbXBpbGUtdGltZSBj aGVja3MgYW5kIGNvbXBpbGVyIG9wdGlvbnMKIwpDT05GSUdfREVCVUdfSU5GTz15CiMgQ09ORklH X0RFQlVHX0lORk9fUkVEVUNFRCBpcyBub3Qgc2V0CiMgQ09ORklHX0RFQlVHX0lORk9fQ09NUFJF U1NFRCBpcyBub3Qgc2V0CiMgQ09ORklHX0RFQlVHX0lORk9fU1BMSVQgaXMgbm90IHNldApDT05G SUdfREVCVUdfSU5GT19EV0FSRl9UT09MQ0hBSU5fREVGQVVMVD15CiMgQ09ORklHX0RFQlVHX0lO Rk9fRFdBUkY0IGlzIG5vdCBzZXQKIyBDT05GSUdfREVCVUdfSU5GT19EV0FSRjUgaXMgbm90IHNl dAojIENPTkZJR19ERUJVR19JTkZPX0JURiBpcyBub3Qgc2V0CiMgQ09ORklHX0dEQl9TQ1JJUFRT IGlzIG5vdCBzZXQKQ09ORklHX0ZSQU1FX1dBUk49MjA0OAojIENPTkZJR19TVFJJUF9BU01fU1lN UyBpcyBub3Qgc2V0CiMgQ09ORklHX1JFQURBQkxFX0FTTSBpcyBub3Qgc2V0CiMgQ09ORklHX0hF QURFUlNfSU5TVEFMTCBpcyBub3Qgc2V0CiMgQ09ORklHX0RFQlVHX1NFQ1RJT05fTUlTTUFUQ0gg aXMgbm90IHNldApDT05GSUdfU0VDVElPTl9NSVNNQVRDSF9XQVJOX09OTFk9eQojIENPTkZJR19E RUJVR19GT1JDRV9GVU5DVElPTl9BTElHTl82NEIgaXMgbm90IHNldApDT05GSUdfQVJDSF9XQU5U X0ZSQU1FX1BPSU5URVJTPXkKQ09ORklHX0ZSQU1FX1BPSU5URVI9eQojIENPTkZJR19WTUxJTlVY X01BUCBpcyBub3Qgc2V0CiMgQ09ORklHX0RFQlVHX0ZPUkNFX1dFQUtfUEVSX0NQVSBpcyBub3Qg c2V0CiMgZW5kIG9mIENvbXBpbGUtdGltZSBjaGVja3MgYW5kIGNvbXBpbGVyIG9wdGlvbnMKCiMK IyBHZW5lcmljIEtlcm5lbCBEZWJ1Z2dpbmcgSW5zdHJ1bWVudHMKIwpDT05GSUdfTUFHSUNfU1lT UlE9eQpDT05GSUdfTUFHSUNfU1lTUlFfREVGQVVMVF9FTkFCTEU9MHgxCkNPTkZJR19NQUdJQ19T WVNSUV9TRVJJQUw9eQpDT05GSUdfTUFHSUNfU1lTUlFfU0VSSUFMX1NFUVVFTkNFPSIiCkNPTkZJ R19ERUJVR19GUz15CkNPTkZJR19ERUJVR19GU19BTExPV19BTEw9eQojIENPTkZJR19ERUJVR19G U19ESVNBTExPV19NT1VOVCBpcyBub3Qgc2V0CiMgQ09ORklHX0RFQlVHX0ZTX0FMTE9XX05PTkUg aXMgbm90IHNldApDT05GSUdfSEFWRV9BUkNIX0tHREI9eQojIENPTkZJR19LR0RCIGlzIG5vdCBz ZXQKQ09ORklHX0FSQ0hfSEFTX1VCU0FOX1NBTklUSVpFX0FMTD15CiMgQ09ORklHX1VCU0FOIGlz IG5vdCBzZXQKIyBlbmQgb2YgR2VuZXJpYyBLZXJuZWwgRGVidWdnaW5nIEluc3RydW1lbnRzCgpD T05GSUdfREVCVUdfS0VSTkVMPXkKQ09ORklHX0RFQlVHX01JU0M9eQoKIwojIE1lbW9yeSBEZWJ1 Z2dpbmcKIwojIENPTkZJR19QQUdFX0VYVEVOU0lPTiBpcyBub3Qgc2V0CiMgQ09ORklHX0RFQlVH X1BBR0VBTExPQyBpcyBub3Qgc2V0CiMgQ09ORklHX1BBR0VfT1dORVIgaXMgbm90IHNldAojIENP TkZJR19QQUdFX1BPSVNPTklORyBpcyBub3Qgc2V0CiMgQ09ORklHX0RFQlVHX1JPREFUQV9URVNU IGlzIG5vdCBzZXQKQ09ORklHX0FSQ0hfSEFTX0RFQlVHX1dYPXkKIyBDT05GSUdfREVCVUdfV1gg aXMgbm90IHNldApDT05GSUdfR0VORVJJQ19QVERVTVA9eQojIENPTkZJR19QVERVTVBfREVCVUdG UyBpcyBub3Qgc2V0CiMgQ09ORklHX0RFQlVHX09CSkVDVFMgaXMgbm90IHNldAojIENPTkZJR19E RUJVR19TTEFCIGlzIG5vdCBzZXQKQ09ORklHX0hBVkVfREVCVUdfS01FTUxFQUs9eQojIENPTkZJ R19ERUJVR19LTUVNTEVBSyBpcyBub3Qgc2V0CiMgQ09ORklHX0RFQlVHX1NUQUNLX1VTQUdFIGlz IG5vdCBzZXQKIyBDT05GSUdfU0NIRURfU1RBQ0tfRU5EX0NIRUNLIGlzIG5vdCBzZXQKQ09ORklH X0FSQ0hfSEFTX0RFQlVHX1ZNX1BHVEFCTEU9eQojIENPTkZJR19ERUJVR19WTSBpcyBub3Qgc2V0 CiMgQ09ORklHX0RFQlVHX1ZNX1BHVEFCTEUgaXMgbm90IHNldApDT05GSUdfQVJDSF9IQVNfREVC VUdfVklSVFVBTD15CiMgQ09ORklHX0RFQlVHX1ZJUlRVQUwgaXMgbm90IHNldAojIENPTkZJR19E RUJVR19NRU1PUllfSU5JVCBpcyBub3Qgc2V0CiMgQ09ORklHX0RFQlVHX1BFUl9DUFVfTUFQUyBp cyBub3Qgc2V0CkNPTkZJR19IQVZFX0FSQ0hfS0FTQU49eQpDT05GSUdfSEFWRV9BUkNIX0tBU0FO X1NXX1RBR1M9eQpDT05GSUdfSEFWRV9BUkNIX0tBU0FOX0hXX1RBR1M9eQpDT05GSUdfSEFWRV9B UkNIX0tBU0FOX1ZNQUxMT0M9eQpDT05GSUdfQ0NfSEFTX0tBU0FOX0dFTkVSSUM9eQpDT05GSUdf Q0NfSEFTX1dPUktJTkdfTk9TQU5JVElaRV9BRERSRVNTPXkKIyBDT05GSUdfS0FTQU4gaXMgbm90 IHNldApDT05GSUdfSEFWRV9BUkNIX0tGRU5DRT15CiMgQ09ORklHX0tGRU5DRSBpcyBub3Qgc2V0 CiMgZW5kIG9mIE1lbW9yeSBEZWJ1Z2dpbmcKCiMgQ09ORklHX0RFQlVHX1NISVJRIGlzIG5vdCBz ZXQKCiMKIyBEZWJ1ZyBPb3BzLCBMb2NrdXBzIGFuZCBIYW5ncwojCiMgQ09ORklHX1BBTklDX09O X09PUFMgaXMgbm90IHNldApDT05GSUdfUEFOSUNfT05fT09QU19WQUxVRT0wCkNPTkZJR19QQU5J Q19USU1FT1VUPTAKIyBDT05GSUdfU09GVExPQ0tVUF9ERVRFQ1RPUiBpcyBub3Qgc2V0CiMgQ09O RklHX0RFVEVDVF9IVU5HX1RBU0sgaXMgbm90IHNldAojIENPTkZJR19XUV9XQVRDSERPRyBpcyBu b3Qgc2V0CiMgZW5kIG9mIERlYnVnIE9vcHMsIExvY2t1cHMgYW5kIEhhbmdzCgojCiMgU2NoZWR1 bGVyIERlYnVnZ2luZwojCiMgQ09ORklHX1NDSEVEX0RFQlVHIGlzIG5vdCBzZXQKIyBDT05GSUdf U0NIRURTVEFUUyBpcyBub3Qgc2V0CiMgZW5kIG9mIFNjaGVkdWxlciBEZWJ1Z2dpbmcKCiMgQ09O RklHX0RFQlVHX1RJTUVLRUVQSU5HIGlzIG5vdCBzZXQKCiMKIyBMb2NrIERlYnVnZ2luZyAoc3Bp bmxvY2tzLCBtdXRleGVzLCBldGMuLi4pCiMKQ09ORklHX0xPQ0tfREVCVUdHSU5HX1NVUFBPUlQ9 eQojIENPTkZJR19QUk9WRV9MT0NLSU5HIGlzIG5vdCBzZXQKIyBDT05GSUdfTE9DS19TVEFUIGlz IG5vdCBzZXQKIyBDT05GSUdfREVCVUdfUlRfTVVURVhFUyBpcyBub3Qgc2V0CiMgQ09ORklHX0RF QlVHX1NQSU5MT0NLIGlzIG5vdCBzZXQKIyBDT05GSUdfREVCVUdfTVVURVhFUyBpcyBub3Qgc2V0 CiMgQ09ORklHX0RFQlVHX1dXX01VVEVYX1NMT1dQQVRIIGlzIG5vdCBzZXQKIyBDT05GSUdfREVC VUdfUldTRU1TIGlzIG5vdCBzZXQKIyBDT05GSUdfREVCVUdfTE9DS19BTExPQyBpcyBub3Qgc2V0 CiMgQ09ORklHX0RFQlVHX0FUT01JQ19TTEVFUCBpcyBub3Qgc2V0CiMgQ09ORklHX0RFQlVHX0xP Q0tJTkdfQVBJX1NFTEZURVNUUyBpcyBub3Qgc2V0CiMgQ09ORklHX0xPQ0tfVE9SVFVSRV9URVNU IGlzIG5vdCBzZXQKIyBDT05GSUdfV1dfTVVURVhfU0VMRlRFU1QgaXMgbm90IHNldAojIENPTkZJ R19TQ0ZfVE9SVFVSRV9URVNUIGlzIG5vdCBzZXQKIyBDT05GSUdfQ1NEX0xPQ0tfV0FJVF9ERUJV RyBpcyBub3Qgc2V0CiMgZW5kIG9mIExvY2sgRGVidWdnaW5nIChzcGlubG9ja3MsIG11dGV4ZXMs IGV0Yy4uLikKCiMgQ09ORklHX0RFQlVHX0lSUUZMQUdTIGlzIG5vdCBzZXQKIyBDT05GSUdfU1RB Q0tUUkFDRSBpcyBub3Qgc2V0CiMgQ09ORklHX1dBUk5fQUxMX1VOU0VFREVEX1JBTkRPTSBpcyBu b3Qgc2V0CiMgQ09ORklHX0RFQlVHX0tPQkpFQ1QgaXMgbm90IHNldAoKIwojIERlYnVnIGtlcm5l bCBkYXRhIHN0cnVjdHVyZXMKIwojIENPTkZJR19ERUJVR19MSVNUIGlzIG5vdCBzZXQKIyBDT05G SUdfREVCVUdfUExJU1QgaXMgbm90IHNldAojIENPTkZJR19ERUJVR19TRyBpcyBub3Qgc2V0CiMg Q09ORklHX0RFQlVHX05PVElGSUVSUyBpcyBub3Qgc2V0CiMgQ09ORklHX0JVR19PTl9EQVRBX0NP UlJVUFRJT04gaXMgbm90IHNldAojIGVuZCBvZiBEZWJ1ZyBrZXJuZWwgZGF0YSBzdHJ1Y3R1cmVz CgojIENPTkZJR19ERUJVR19DUkVERU5USUFMUyBpcyBub3Qgc2V0CgojCiMgUkNVIERlYnVnZ2lu ZwojCiMgQ09ORklHX1JDVV9TQ0FMRV9URVNUIGlzIG5vdCBzZXQKIyBDT05GSUdfUkNVX1RPUlRV UkVfVEVTVCBpcyBub3Qgc2V0CiMgQ09ORklHX1JDVV9SRUZfU0NBTEVfVEVTVCBpcyBub3Qgc2V0 CkNPTkZJR19SQ1VfQ1BVX1NUQUxMX1RJTUVPVVQ9MjEKQ09ORklHX1JDVV9UUkFDRT15CiMgQ09O RklHX1JDVV9FUVNfREVCVUcgaXMgbm90IHNldAojIGVuZCBvZiBSQ1UgRGVidWdnaW5nCgojIENP TkZJR19ERUJVR19XUV9GT1JDRV9SUl9DUFUgaXMgbm90IHNldAojIENPTkZJR19DUFVfSE9UUExV R19TVEFURV9DT05UUk9MIGlzIG5vdCBzZXQKIyBDT05GSUdfTEFURU5DWVRPUCBpcyBub3Qgc2V0 CkNPTkZJR19IQVZFX0ZVTkNUSU9OX1RSQUNFUj15CkNPTkZJR19IQVZFX0ZVTkNUSU9OX0dSQVBI X1RSQUNFUj15CkNPTkZJR19IQVZFX0RZTkFNSUNfRlRSQUNFPXkKQ09ORklHX0hBVkVfRFlOQU1J Q19GVFJBQ0VfV0lUSF9SRUdTPXkKQ09ORklHX0hBVkVfRlRSQUNFX01DT1VOVF9SRUNPUkQ9eQpD T05GSUdfSEFWRV9TWVNDQUxMX1RSQUNFUE9JTlRTPXkKQ09ORklHX0hBVkVfQ19SRUNPUkRNQ09V TlQ9eQpDT05GSUdfVFJBQ0VfQ0xPQ0s9eQpDT05GSUdfVFJBQ0lOR19TVVBQT1JUPXkKIyBDT05G SUdfRlRSQUNFIGlzIG5vdCBzZXQKIyBDT05GSUdfU0FNUExFUyBpcyBub3Qgc2V0CiMgQ09ORklH X1NUUklDVF9ERVZNRU0gaXMgbm90IHNldAoKIwojIGFybTY0IERlYnVnZ2luZwojCiMgQ09ORklH X1BJRF9JTl9DT05URVhUSURSIGlzIG5vdCBzZXQKIyBDT05GSUdfREVCVUdfRUZJIGlzIG5vdCBz ZXQKIyBDT05GSUdfQ09SRVNJR0hUIGlzIG5vdCBzZXQKIyBlbmQgb2YgYXJtNjQgRGVidWdnaW5n CgojCiMgS2VybmVsIFRlc3RpbmcgYW5kIENvdmVyYWdlCiMKIyBDT05GSUdfS1VOSVQgaXMgbm90 IHNldAojIENPTkZJR19OT1RJRklFUl9FUlJPUl9JTkpFQ1RJT04gaXMgbm90IHNldAojIENPTkZJ R19GQVVMVF9JTkpFQ1RJT04gaXMgbm90IHNldApDT05GSUdfQVJDSF9IQVNfS0NPVj15CkNPTkZJ R19DQ19IQVNfU0FOQ09WX1RSQUNFX1BDPXkKIyBDT05GSUdfS0NPViBpcyBub3Qgc2V0CkNPTkZJ R19SVU5USU1FX1RFU1RJTkdfTUVOVT15CiMgQ09ORklHX0xLRFRNIGlzIG5vdCBzZXQKIyBDT05G SUdfVEVTVF9NSU5fSEVBUCBpcyBub3Qgc2V0CiMgQ09ORklHX1RFU1RfU09SVCBpcyBub3Qgc2V0 CiMgQ09ORklHX1RFU1RfRElWNjQgaXMgbm90IHNldAojIENPTkZJR19CQUNLVFJBQ0VfU0VMRl9U RVNUIGlzIG5vdCBzZXQKIyBDT05GSUdfUkJUUkVFX1RFU1QgaXMgbm90IHNldAojIENPTkZJR19S RUVEX1NPTE9NT05fVEVTVCBpcyBub3Qgc2V0CiMgQ09ORklHX0lOVEVSVkFMX1RSRUVfVEVTVCBp cyBub3Qgc2V0CiMgQ09ORklHX0FUT01JQzY0X1NFTEZURVNUIGlzIG5vdCBzZXQKIyBDT05GSUdf VEVTVF9IRVhEVU1QIGlzIG5vdCBzZXQKIyBDT05GSUdfU1RSSU5HX1NFTEZURVNUIGlzIG5vdCBz ZXQKIyBDT05GSUdfVEVTVF9TVFJJTkdfSEVMUEVSUyBpcyBub3Qgc2V0CiMgQ09ORklHX1RFU1Rf U1RSU0NQWSBpcyBub3Qgc2V0CiMgQ09ORklHX1RFU1RfS1NUUlRPWCBpcyBub3Qgc2V0CiMgQ09O RklHX1RFU1RfUFJJTlRGIGlzIG5vdCBzZXQKIyBDT05GSUdfVEVTVF9TQ0FORiBpcyBub3Qgc2V0 CiMgQ09ORklHX1RFU1RfQklUTUFQIGlzIG5vdCBzZXQKIyBDT05GSUdfVEVTVF9VVUlEIGlzIG5v dCBzZXQKIyBDT05GSUdfVEVTVF9YQVJSQVkgaXMgbm90IHNldAojIENPTkZJR19URVNUX09WRVJG TE9XIGlzIG5vdCBzZXQKIyBDT05GSUdfVEVTVF9SSEFTSFRBQkxFIGlzIG5vdCBzZXQKIyBDT05G SUdfVEVTVF9IQVNIIGlzIG5vdCBzZXQKIyBDT05GSUdfVEVTVF9JREEgaXMgbm90IHNldAojIENP TkZJR19GSU5EX0JJVF9CRU5DSE1BUksgaXMgbm90IHNldAojIENPTkZJR19URVNUX0ZJUk1XQVJF IGlzIG5vdCBzZXQKIyBDT05GSUdfVEVTVF9TWVNDVEwgaXMgbm90IHNldAojIENPTkZJR19URVNU X1VERUxBWSBpcyBub3Qgc2V0CiMgQ09ORklHX1RFU1RfTUVNQ0FUX1AgaXMgbm90IHNldAojIENP TkZJR19URVNUX1NUQUNLSU5JVCBpcyBub3Qgc2V0CiMgQ09ORklHX1RFU1RfTUVNSU5JVCBpcyBu b3Qgc2V0CiMgQ09ORklHX1RFU1RfRlJFRV9QQUdFUyBpcyBub3Qgc2V0CkNPTkZJR19BUkNIX1VT RV9NRU1URVNUPXkKIyBDT05GSUdfTUVNVEVTVCBpcyBub3Qgc2V0CiMgZW5kIG9mIEtlcm5lbCBU ZXN0aW5nIGFuZCBDb3ZlcmFnZQojIGVuZCBvZiBLZXJuZWwgaGFja2luZwo= --------------6DD34436CA52906803239DD3-- From xen-devel-bounces@lists.xenproject.org Wed Sep 08 06:21:58 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Sep 2021 06:21:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.181442.328545 (Exim 4.92) (envelope-from ) id 1mNqxp-0005oR-Q9; Wed, 08 Sep 2021 06:21:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 181442.328545; Wed, 08 Sep 2021 06:21:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNqxp-0005oK-My; Wed, 08 Sep 2021 06:21:41 +0000 Received: by outflank-mailman (input) for mailman id 181442; Wed, 08 Sep 2021 06:21:40 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNqxn-0005oC-Qy for xen-devel@lists.xenproject.org; Wed, 08 Sep 2021 06:21:39 +0000 Received: from us-smtp-delivery-124.mimecast.com (unknown [216.205.24.124]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTP id 062b4a3d-106d-11ec-b144-12813bfff9fa; Wed, 08 Sep 2021 06:21:38 +0000 (UTC) Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-327-8vDZ1ZkhO9mA5aQ2DxWJLw-1; Wed, 08 Sep 2021 02:21:36 -0400 Received: by mail-wm1-f71.google.com with SMTP id j33-20020a05600c48a100b002e879427915so526154wmp.5 for ; Tue, 07 Sep 2021 23:21:35 -0700 (PDT) Received: from [192.168.3.132] (p5b0c6125.dip0.t-ipconnect.de. [91.12.97.37]) by smtp.gmail.com with ESMTPSA id l21sm1014143wmh.31.2021.09.07.23.21.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Sep 2021 23:21:34 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 062b4a3d-106d-11ec-b144-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1631082098; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=z34UVAiI8Q78/349kHm5g+91ow7Iz9fZ37lSWz6rrwY=; b=axfZ8DDCs3RCvOLyr4CFX8PtrudeMAvhZE25+JxlU9p32pwRCGAx7t6+yheogb1+9jP+6h Ky4uP9Mbx/16mr0pMSILJrLTDimd9Tajm001koLUdZOK803RAL735x5G72KmC0KpSY3Tx0 jm7L855GCNCra006HzyAU3azuLWh5z0= X-MC-Unique: 8vDZ1ZkhO9mA5aQ2DxWJLw-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:to:cc:references:from:organization:subject :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=z34UVAiI8Q78/349kHm5g+91ow7Iz9fZ37lSWz6rrwY=; b=GbJiajyEh5oi9ZmT43yMvCo/ppfDABdzosNron7RU1Tc53Km5oA40K4Vw9esey/ktC 9tHoKG5W/dO0Dm2ud8+rBzdJ26czgE63SZS6C/AvxtZxCSbxncsgvNDWOIvH3Mhoq1Df pHmxefoLFBH0MBFT3cxg0nCjHKCgHeCUKYvdngmIDU1b3jpwkab3RXdRhXptlT76e0do t1YLfp4WEotI4re6JBHjzJL/C18qF4i1ubXDfTMuaOUDuO6tBqed++8zjQbtxcp+b57C 8SNjjc89UhruNwrF+D83/9p82XFsEgFYGtVIt6b+exIlhrzF2FPCn1xifmByRnw9gMrn 7lFw== X-Gm-Message-State: AOAM532xz1f7JgxljUJkQ7p4MFZOsqATFxa4Gt7xB7UpeX67aQe6kiCT nNXV2beHIy6vzsZ4H3KIXlr8M22J7v+550k8sBkPEJ+ku6N8mBjQGyJYximl0HErEupQLVlYPpm rPD2GyAoiattecxZmuHdv7i66BI4GDUtCZCqYg3tEawgb17apZuvGxRBeFSM+0bEvUtizjpnQGA 0= X-Received: by 2002:adf:9bdb:: with SMTP id e27mr1991910wrc.162.1631082094839; Tue, 07 Sep 2021 23:21:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwVePYl3oJzEgmfpZnrDZETUp0uOCSKVg5L73nfFg5SJFFaAVj5u3fATe4qqvZ9JKp+koI50g== X-Received: by 2002:adf:9bdb:: with SMTP id e27mr1991865wrc.162.1631082094550; Tue, 07 Sep 2021 23:21:34 -0700 (PDT) To: Sean Anderson Cc: akpm@linux-foundation.org, alexander.h.duyck@linux.intel.com, dave.hansen@intel.com, haiyangz@microsoft.com, kys@microsoft.com, linux-acpi@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, mgorman@techsingularity.net, mhocko@kernel.org, mhocko@suse.com, osalvador@suse.de, pankaj.gupta.linux@gmail.com, richard.weiyang@linux.alibaba.com, rppt@kernel.org, sthemmin@microsoft.com, vbabka@suse.cz, wei.liu@kernel.org, willy@infradead.org, xen-devel@lists.xenproject.org References: <20201005121534.15649-5-david@redhat.com> From: David Hildenbrand Organization: Red Hat Subject: Re: [PATCH v2 4/5] mm/page_alloc: place pages to tail in __free_pages_core() Message-ID: <528e8d9c-b148-30ec-d8cc-3dd072eaa7f2@redhat.com> Date: Wed, 8 Sep 2021 08:21:32 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit On 08.09.21 00:40, Sean Anderson wrote: > Hi David, > > This patch breaks booting on my custom Xilinx ZynqMP board. Booting > fails just after/during GIC initialization: > > [ 0.000000] Booting Linux on physical CPU 0x0000000000 [0x410fd034] > [ 0.000000] Linux version 5.14.0 (sean@plantagenet) (aarch64-linux-gnu-gcc (Ubuntu 9.3.0-17ubuntu1~20.04) 9.3.0, GNU ld (GNU Binutils for Ubuntu) 2.34) #251 SMP Tue Sep 7 18:11:50 EDT 2021 > [ 0.000000] Machine model: xlnx,zynqmp > [ 0.000000] earlycon: cdns0 at MMIO 0x00000000ff010000 (options '115200n8') > [ 0.000000] printk: bootconsole [cdns0] enabled > [ 0.000000] efi: UEFI not found. > [ 0.000000] Zone ranges: > [ 0.000000] DMA32 [mem 0x0000000000000000-0x00000000ffffffff] > [ 0.000000] Normal [mem 0x0000000100000000-0x000000087fffffff] > [ 0.000000] Movable zone start for each node > [ 0.000000] Early memory node ranges > [ 0.000000] node 0: [mem 0x0000000000000000-0x000000007fefffff] > [ 0.000000] node 0: [mem 0x0000000800000000-0x000000087fffffff] > [ 0.000000] Initmem setup node 0 [mem 0x0000000000000000-0x000000087fffffff] > [ 0.000000] On node 0, zone Normal: 256 pages in unavailable ranges > [ 0.000000] cma: Reserved 1000 MiB at 0x0000000041400000 > [ 0.000000] psci: probing for conduit method from DT. > [ 0.000000] psci: PSCIv1.1 detected in firmware. > [ 0.000000] psci: Using standard PSCI v0.2 function IDs > [ 0.000000] psci: MIGRATE_INFO_TYPE not supported. > [ 0.000000] psci: SMC Calling Convention v1.1 > [ 0.000000] percpu: Embedded 19 pages/cpu s46752 r0 d31072 u77824 > [ 0.000000] Detected VIPT I-cache on CPU0 > [ 0.000000] CPU features: detected: ARM erratum 845719 > [ 0.000000] Built 1 zonelists, mobility grouping on. Total pages: 1033987 > [ 0.000000] Kernel command line: earlycon clk_ignore_unused root=/dev/mmcblk0p2 rootwait rw cma=1000M > [ 0.000000] Dentry cache hash table entries: 524288 (order: 10, 4194304 bytes, linear) > [ 0.000000] Inode-cache hash table entries: 262144 (order: 9, 2097152 bytes, linear) > [ 0.000000] mem auto-init: stack:off, heap alloc:off, heap free:off > [ 0.000000] software IO TLB: mapped [mem 0x000000003d400000-0x0000000041400000] (64MB) > [ 0.000000] Memory: 3023384K/4193280K available (4288K kernel code, 514K rwdata, 1200K rodata, 896K init, 187K bss, 145896K reserved, 1024000K cma-reserved) > [ 0.000000] rcu: Hierarchical RCU implementation. > [ 0.000000] rcu: RCU event tracing is enabled. > [ 0.000000] rcu: RCU calculated value of scheduler-enlistment delay is 25 jiffies. > [ 0.000000] NR_IRQS: 64, nr_irqs: 64, preallocated irqs: 0 > [ 0.000000] GIC: Adjusting CPU interface base to 0x00000000f902f000 > [ 0.000000] Root IRQ handler: gic_handle_irq > [ 0.000000] GIC: Using split EOI/Deactivate mode > > and I bisected it to this patch. Applying the following patch (for 5.14) > fixes booting again: Hi Sean, unfortunately that patch most likely (with 99.9999% confidence) revealed another latent BUG in your setup. Some memory that shouldn't be handed to the buddy as free memory is getting now allocated earlier than later, resulting in that issue. I had all different kinds of reports, but they were mostly a) Firmware bugs that result in uncached memory getting exposed to the buddy, resulting in severe performance degradation such that the system will no longer boot. [3] I wrote kstream [1] to be run under the old kernel, to identify these. b) BUGs that result in unsuitable memory getting exposed to either the buddy or devices, resulting in errors during device initialization. [6] c) Use after free BUGs. Exposing memory, such as used for ACPI tables, to the buddy as free memory although it's still in use. [4] d) Hypervisor BUGs The last report (heavy performance degradation) was due to a BUG in dpdk. [2] What the exact symptoms you're experiencing? Really slow boot/stall? Then it could be a) and kstream might help. [1] https://github.com/davidhildenbrand/kstream [2] https://lore.kernel.org/dpdk-dev/20210827161231.579968-1-eperezma@redhat.com/T/#u [3] https://lore.kernel.org/r/MW3PR12MB4537C3C6EFD9CA3A4B32084DF36B9@MW3PR12MB4537.namprd12.prod.outlook.com [4] https://lkml.kernel.org/r/4650320.31r3eYUQgx@kreacher [5] https://lkml.kernel.org/r/87361onphy.fsf_-_@codeaurora.org [6] https://lore.kernel.org/r/20201213225517.3838501-1-linus.walleij@linaro.org -- Thanks, David / dhildenb From xen-devel-bounces@lists.xenproject.org Wed Sep 08 06:49:43 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Sep 2021 06:49:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.181449.328555 (Exim 4.92) (envelope-from ) id 1mNrOr-0000Cr-Sg; Wed, 08 Sep 2021 06:49:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 181449.328555; Wed, 08 Sep 2021 06:49:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNrOr-0000Ck-Ph; Wed, 08 Sep 2021 06:49:37 +0000 Received: by outflank-mailman (input) for mailman id 181449; Wed, 08 Sep 2021 06:49:36 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNrOp-0000Ce-Dg for xen-devel@lists.xenproject.org; Wed, 08 Sep 2021 06:49:36 +0000 Received: from casper.infradead.org (unknown [2001:8b0:10b:1236::1]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 71ccbeff-fed4-4b6c-9170-620336930e35; Wed, 08 Sep 2021 06:49:32 +0000 (UTC) Received: from hch by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1mNrNu-008ZoP-Gv; Wed, 08 Sep 2021 06:48:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 71ccbeff-fed4-4b6c-9170-620336930e35 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=OrzGM9PLHfbyfeiU5N8A74VHnUlyeQDz1745rBQSmpE=; b=JvLbZFDB8IlVYMmqnbPjeH0zpT RS6TMNs3DqCPi4wnv+3RN+BAWH5wMMsH5OIbUJGjC9c+FFCSx0qVUnY9l1pDwbtkGF0v1rdZSeqkv 8XX7xKR06ZiLWC8KJX9Wc5cBfed6lBQRH62JfWIeV4NJjQStpPIefHWmFJFFjudwengFWX7O9+UKm JnPsIv35qqOOxV/brv/0P5TTjFwkO3aGrqtXxjiSYg3zvBlHIJhqDusKynHPkF+9LwnkgJSAZfb8p N72r4r40Aj7RwC/fkxH0CgbUafSPL2d56ee5y/Rj+rPHP+4/dH3Ce027JiYI5/vdK/Awy8PLopLbN sv0vmElA==; Date: Wed, 8 Sep 2021 07:48:38 +0100 From: Christoph Hellwig To: Jan Beulich Cc: Juergen Gross , Boris Ostrovsky , Stefano Stabellini , lkml , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH 01/12] swiotlb-xen: avoid double free Message-ID: References: <588b3e6d-2682-160c-468e-44ca4867a570@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html On Tue, Sep 07, 2021 at 02:04:25PM +0200, Jan Beulich wrote: > Of the two paths leading to the "error" label in xen_swiotlb_init() one > didn't allocate anything, while the other did already free what was > allocated. > > Fixes: b82776005369 ("xen/swiotlb: Use the swiotlb_late_init_with_tbl to init Xen-SWIOTLB late when PV PCI is used") > Signed-off-by: Jan Beulich > Cc: stable@vger.kernel.org Looks good, Reviewed-by: Christoph Hellwig From xen-devel-bounces@lists.xenproject.org Wed Sep 08 06:50:41 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Sep 2021 06:50:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.181455.328567 (Exim 4.92) (envelope-from ) id 1mNrPt-0001UL-81; Wed, 08 Sep 2021 06:50:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 181455.328567; Wed, 08 Sep 2021 06:50:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNrPt-0001UE-4m; Wed, 08 Sep 2021 06:50:41 +0000 Received: by outflank-mailman (input) for mailman id 181455; Wed, 08 Sep 2021 06:50:39 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNrPr-0001U4-Kt for xen-devel@lists.xenproject.org; Wed, 08 Sep 2021 06:50:39 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com (unknown [40.107.13.45]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 124eb228-1071-11ec-b147-12813bfff9fa; Wed, 08 Sep 2021 06:50:37 +0000 (UTC) Received: from AM5PR04CA0018.eurprd04.prod.outlook.com (2603:10a6:206:1::31) by VI1PR08MB4414.eurprd08.prod.outlook.com (2603:10a6:803:f3::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.21; Wed, 8 Sep 2021 06:50:33 +0000 Received: from VE1EUR03FT036.eop-EUR03.prod.protection.outlook.com (2603:10a6:206:1:cafe::32) by AM5PR04CA0018.outlook.office365.com (2603:10a6:206:1::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14 via Frontend Transport; Wed, 8 Sep 2021 06:50:33 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT036.mail.protection.outlook.com (10.152.19.204) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Wed, 8 Sep 2021 06:50:32 +0000 Received: ("Tessian outbound cc1d52552731:v105"); Wed, 08 Sep 2021 06:50:32 +0000 Received: from a7d1b221e695.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id D3104BFB-56FC-497E-9F9F-9471EC98E033.1; Wed, 08 Sep 2021 06:50:26 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id a7d1b221e695.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 08 Sep 2021 06:50:26 +0000 Received: from PAXPR08MB6816.eurprd08.prod.outlook.com (2603:10a6:102:130::10) by PAXPR08MB6621.eurprd08.prod.outlook.com (2603:10a6:102:dc::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14; Wed, 8 Sep 2021 06:50:24 +0000 Received: from PAXPR08MB6816.eurprd08.prod.outlook.com ([fe80::c1b4:db1c:376f:b697]) by PAXPR08MB6816.eurprd08.prod.outlook.com ([fe80::c1b4:db1c:376f:b697%8]) with mapi id 15.20.4500.014; Wed, 8 Sep 2021 06:50:24 +0000 Received: from smtpclient.apple (82.8.129.65) by LO2P123CA0009.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:a6::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14 via Frontend Transport; Wed, 8 Sep 2021 06:50:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 124eb228-1071-11ec-b147-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pXFdvcbYFekiJeuPsAux0l5olVsrjIqfTBNNqjHOfbo=; b=fix5C2bTXUIgPc5p3I+HPsrA4GOwFPO+ZNZiaiWz0Ib/YCb/OHXEGOUCBDdKCQktsbB3CR5lxo74n4cCXtYr9Jrxrp23r2ZDjZ9dk3YgNme1ch4jiQH0GAb6GYJxrEj3Tq+MQ8VsliDEvWBBompqmxqXtDy/SWwGLd8ohVneOwc= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: 0497a7ae381cb32d X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YOLtCutZwnefg5y1wFxjnwKeCZxqtPZRX8/QF5fe/5Kd1gsnsHdkckU1icNMPO+N0S5D4RiY5nGukObg07vhpJXWDORF70Z8Lels7osGzYCSvr6wDlGueiuFtIEA8Y5OaeIUyFIOwOYGmuzljd5SpixZpFlGeYbRkcqsUHj+hg7R6ypg3lTxKNS9puFlqvFfUHV6tna28m1qnJxfo15MI+OfI3Z9+xXuX60c+rndtpQP+SBJjgsXTeXvVDpevJM6gL5IApQmbInUDJNZlim01t5gY+JggDyLdh6lGDU23hbLoft5nPudxq+BhcUQB50OUj6jfO2aDgEHoQIx8vMYwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=pXFdvcbYFekiJeuPsAux0l5olVsrjIqfTBNNqjHOfbo=; b=ZY6fRNACWAPRxQX4wQ13qct5b6bbZ4fnbRuRzEEkC0V6NIAk3Epvet61/t79CkE9S924ftv92xubPfDKe1OqKqnUdbTR56wQWAZ5d1Vg5wpgcNuHaJxicpiPKbUb8CZ0ftmXhHXY/gbYMn5TCzKdhagZE364kc5emrc446QAuTRjbcVWcME4I8HCsckje5aQB6VBF/xmu09CpZYwLcvd5v2NgrSNBPxEJncdqj1PXVmg3bnNvpQgBYh5ewUb0b1GD+vhR5xwmcvTNg97/F9FTyPgQveKHfB7fEsDkyQTA5SVn6GwzovUzPnF2NBLsiG3OIvyr7/XBOijmUSRUXEMxg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pXFdvcbYFekiJeuPsAux0l5olVsrjIqfTBNNqjHOfbo=; b=fix5C2bTXUIgPc5p3I+HPsrA4GOwFPO+ZNZiaiWz0Ib/YCb/OHXEGOUCBDdKCQktsbB3CR5lxo74n4cCXtYr9Jrxrp23r2ZDjZ9dk3YgNme1ch4jiQH0GAb6GYJxrEj3Tq+MQ8VsliDEvWBBompqmxqXtDy/SWwGLd8ohVneOwc= Authentication-Results-Original: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=arm.com; Content-Type: text/plain; charset=utf-8 Subject: Re: [RFC PATCH] xen/design: Add design for EFI dom0less system start From: Luca Fancellu In-Reply-To: Date: Wed, 8 Sep 2021 07:50:13 +0100 Cc: Julien Grall , xen-devel@lists.xenproject.org, Bertrand Marquis , wei.chen@arm.com, Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Wei Liu Content-Transfer-Encoding: quoted-printable Message-Id: <1D635A64-25A8-44A9-924D-2E609D0D0BEB@arm.com> References: <20210907065228.21794-1-luca.fancellu@arm.com> <4bab7902-0268-5705-5462-fcd7571d7492@xen.org> <7BD59287-75ED-4D4F-B892-F6B04583A986@arm.com> <1efbd9a8-232b-b267-fa8e-7f5f1af7cfed@xen.org> To: Stefano Stabellini X-Mailer: Apple Mail (2.3654.120.0.1.13) X-ClientProxiedBy: LO2P123CA0009.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:a6::21) To PAXPR08MB6816.eurprd08.prod.outlook.com (2603:10a6:102:130::10) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0480f88d-9590-45f8-d8df-08d97294f46f X-MS-TrafficTypeDiagnostic: PAXPR08MB6621:|VI1PR08MB4414: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:10000;OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: VVTiIj9Ld3eFBUHdd80sdaijWJLmo6TWX67UpipDodKTDM4s1x6aXMINR56tk0sCMv8PjaygFWAkmXJrpfJna4Dewms2aE3C9XX8rSrG2gyFffwrP19wmtxPvmXRQ98jsq6oMhNKwX9aognpFGMWhkW0KS/fihZHScEYBwaeBPRv31KB4j7t/rogAu0HOXzdyArZvh0M9GaZjaCIxBQEF0gcK0j/0x3n81VEGi29OBM5R7Q8qUC7Qzi7aqHpqLOOgALzxNTFYvvleg4n2mCfUuC2PLyxA05HYNkEgZQLAoLBYw0MhB6KcaKnhK6j/5UY84McgP662PFBmM3g32KfHt8TnTDRz/Du0hEzptbKzEkHY+rTARTx2Kdn1yfgN4r+u+4BxRsFPyKpDZNkB52lCwn+FE4OPS58MMROFcuo2XyTiFcESa2ho6M2yWOVJ7/3ARRz9bm20a6PlcnuOI7gdXElkLqVQh6DsYWwahpMbw5QEwRB4iom7aUKupUbCp5sZNpzG4lQj385ThwoverUsHOmGtFC2wA8c+aRVj7oPBCYwhFVhxV9AcXThQ3+egGtjJP7zasl5GYXELGIXxd4p4PaeyrPNMO3V+VTXcqmAaJRBgmByk+sfg2u+5EFdHYtF6DDOq9+huvMRmbcRaCW/PcBB2rPBmgWGhmmMuPECNOIihmU2W/dQSnT0B9/veh09QmW21fMDWu9Kh9+CN39HGeyeKOewdWTb8Fy9nqiXGcySZdQTMcJH2aM0dJaQDfFCl85kQ+sjjvLAM8E88xiRA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB6816.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(346002)(39860400002)(396003)(366004)(136003)(6486002)(66556008)(66946007)(478600001)(66476007)(6506007)(8676002)(8936002)(44832011)(5660300002)(26005)(186003)(33656002)(2906002)(53546011)(4326008)(83380400001)(52116002)(6512007)(6916009)(316002)(36756003)(86362001)(956004)(2616005)(54906003)(6666004)(38100700002)(38350700002)(32563001)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6621 Original-Authentication-Results: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT036.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 49838ec5-12cf-41f5-d53b-08d97294ef5a X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yxGs9tVKGSi6SH3jcncPYjrswgX0IKJoLV2eZHfEx5soAvxJr7rAGVOCFvocNLzDdYsfdjpV3Fw7KHTw4uc7sACHEI2Ew7asC/NxtRqWVzrnMjlKb/6NX+m7KA+k0BYh8xygMJacbEoCAufrC7oEJPcfK/Y8QSVTzjoH0t/Kq0Ff2jzPn5H893R4bTgteb1IZfS20r6U1L4tWa7K/jSGtjiiPwHbvecS7t4/+CV8FZtAoPqFBWoacpKgbnSUtZ7sn6KlFGAQQLQxJXnEj3E1J502EkwMfEq7DKrKLVM64zhQuQQbm5yCCoXthKJqmzBLoBb6bvpJoVWzzvV0muwKAohjnNJ1+eHpCMGBVXaKqlKR/5/9iHIqFowrTR8AUCCDr2ZZgOsiMvdlOcy3FODOhaTM4nVFopZhcbOwVKNqkQuZTQhRoOQRY18ZiLWjRHsedolFOBOkNVhslvNFH0fLOEgFTeTQ7KmpaZcgzgWHRhG8WEAdlI1ETu0f7hLmbB4xtO4vIGKZL93uZYjGRXWdBvC6Vtn03TRyrthV3y+MSmejk0zdJAd912/TF+JGk2iwBVDsnrZ7ghzJy5XJdt27ztNwXjN2TwlQFgz5Mn0mf62UpgnI9HKer6alJmPMCOf7AqacIaGtkyv5cgjUDNR9CrCS6Cv+QDiIKjMnl4G5LYMuSdND2Sx62Eeb9f0sD1jdyCkkgZ0dQT3zFiL0O9mTKhqacpOxapzQ/t/7wcJH9cU= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(39860400002)(376002)(136003)(396003)(346002)(46966006)(36840700001)(186003)(6666004)(81166007)(356005)(33656002)(478600001)(83380400001)(54906003)(6862004)(956004)(86362001)(36756003)(2906002)(82310400003)(6486002)(82740400003)(336012)(44832011)(2616005)(316002)(5660300002)(26005)(6512007)(36860700001)(8676002)(47076005)(70586007)(70206006)(6506007)(8936002)(53546011)(4326008)(32563001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Sep 2021 06:50:32.9893 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0480f88d-9590-45f8-d8df-08d97294f46f X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT036.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB4414 > On 8 Sep 2021, at 02:09, Stefano Stabellini wrot= e: >=20 > On Tue, 7 Sep 2021, Julien Grall wrote: >> On 07/09/2021 12:51, Luca Fancellu wrote: >>>> On 7 Sep 2021, at 10:35, Julien Grall wrote: >>>>=20 >>>> Hi Luca, >>>>=20 >>>> On 07/09/2021 07:52, Luca Fancellu wrote: >>>>> Add a design describing a proposal to improve the EFI >>>>> configuration file, adding keywords to describe domU >>>>> guests and allowing to start a dom0less system. >>>>> Signed-off-by: Luca Fancellu >>>>> --- >>>>> docs/designs/efi-arm-dom0less.md | 105 +++++++++++++++++++++++++++++= ++ >>>>> 1 file changed, 105 insertions(+) >>>>> create mode 100644 docs/designs/efi-arm-dom0less.md >>>>> diff --git a/docs/designs/efi-arm-dom0less.md >>>>> b/docs/designs/efi-arm-dom0less.md >>>>> new file mode 100644 >>>>> index 0000000000..8d8fa2243f >>>>> --- /dev/null >>>>> +++ b/docs/designs/efi-arm-dom0less.md >>>>> @@ -0,0 +1,105 @@ >>>>> +# Xen EFI configuration file >>>>> + >>>>> +The current configuration file used by Xen when it is started as an = EFI >>>>> +application is considering only the dom0 guest and doesn't have any >>>>> +property to describe and load in memory domU guests. >>>>=20 >>>> From my understanding, the problem is less about properties (we alread= y >>>> have them in the Device-Tree) but more about where are the binaries >>>> located in memory as we don't know in advance. >>>=20 >>> Hi Julien, >> Hi Luca, >>=20 >>> I think I used the wrong word there, I meant =E2=80=9Ckeyword=E2=80=9D = instead of =E2=80=9Cproperty=E2=80=9D >>> because I was referring about the >>> lack of keywords to describe a domu guest in the Xen EFI configuration = file. >>>=20 >>> I agree with you that on systems with static allocation, the kernel and >>> ramdisk binaries must be at certain locations >>> that are out of control when we use the EFI boot services, the thing we= can >>> do is provide a keyword to specify the >>> addresses and then use the CopyMem() function to relocate the kernel/ra= mdisk >>> in the address we want. >>=20 >> I wasn't specifically referring to static allocation here, sorry if this >> wasn't clear. I was pointing out that most of the information you create= in >> the xen.cfg is going to be similar to what we already provide in the >> Device-Tree. >>=20 >> My main concern is everytime we add a new feature in Dom0less, a develop= er >> would need to write code for the DT and UEFI. This will increase the cod= e size >> and maintenance. >>=20 >> The same can be said for the admin as if they want to switch from plain = U-boot >> to UEFI, they would also need to fully rewrite the bindings. >>=20 >> AFAICT, most of the information provided in the Device-Tree are usable e= ven >> when using UEFI. So I would prefer if we try to re-use what's existing. = This >> is what my proposal below was about. >>=20 >>>=20 >>>>=20 >>>> So I would like to propose something that build on top of the Device-T= ree >>>> work we did. Note this is early thoughts. >>>>=20 >>>> The problematic nodes in the DT are: >>>>=20 >>>> module@0x4a000000 { >>>> compatible =3D "multiboot,kernel", "multiboot,module"; >>>> reg =3D <0x0 0x4a000000 0xffffff>; >>>> bootargs =3D "console=3DttyAMA0 init=3D/bin/sh"; >>>> }; >>>>=20 >>>> module@0x4b000000 { >>>> compatible =3D "multiboot,ramdisk", "multiboot,module"; >>>> reg =3D <0x0 0x4b000000 0xffffff>; >>>> }; >>>>=20 >>>> In particular the property "reg" cannot be known in advance because th= e >>>> UEFI stub will be responsible to load the binaries in memory. >>>=20 >>> Yes that=E2=80=99s true, the UEFI stub is using from the UEFI boot serv= ice the >>> AllocatePages function that is giving back an address out of our contro= l, >>> then using another function the binary is read from the disk and copied= at >>> that address, finally the UEFI stub is writing the node in the device t= ree >>> that >>> will be used by Xen later. >>=20 >> I am not sure to follow. Are you saying the UEFI stub will create the do= m0less >> node in the DT based on the xen.cfg? >>=20 >>>=20 >>>>=20 >>>> What we could do is providing a list of binaries to load and associate= a >>>> key for each of them. Something like: >>>>=20 >>>> binary=3D >>>> binary=3D >>>> .... >>>>=20 >>>> We can then replace the property "reg" with a new property "uefi,key" = that >>>> will contain the name of the binary. >>>>=20 >>>> What do you think? >>>=20 >>> Here I=E2=80=99m lost, because I don=E2=80=99t understand what we are g= oing to do with the >>> name of the binary. >>=20 >> would be used by the UEFI stub to load the binary in memory. E= ach >> binary will have a which helps to refer them in the Device-Tree. = To >> give a concrete example, let say we have two dom0less domains: >> - DomA: 2 vCPUs, 128MB >> - DomB: 3 vCPUs, 512MB >>=20 >> DomA and DomB will be using the same kernel but a different ramdisk. xen= .cfg, >> would look like: >>=20 >> [global] >> default=3Dsection1 >>=20 >> [section1] >> options=3Dconsole=3Dvga,com1 com1=3D57600 loglvl=3Dall noreboot >> kernel=3Dvmlinuz-3.0.31-0.4-xen [domain 0 command line options] >> ramdisk=3Dinitrd-3.0.31-0.4-xen >> xsm=3D >> dtb=3Ddevtree.dtb >> binary=3Dvmlinuz-guest domu-kernel >> binary=3Dramdisk-domA.img domA-ramdisk >> binary=3Dramdisk-domB.img domB-ramdisk >>=20 >> The chosen node in the DT would look like: >>=20 >> chosen { >> domU1 { >> compatible =3D "xen,domain"; >> #address-cells =3D <0x2>; >> #size-cells =3D <0x1>; >> memory =3D <0 0x8000000>; >> cpus =3D <2>; >>=20 >> module@1 { >> compatible =3D "multiboot,kernel", "multiboot,module"; >> uefi,binary =3D "domu-kernel"; >> bootargs =3D "console=3DttyAMA0 init=3D/bin/sh"; >> }; >>=20 >> module@2 { >> compatible =3D "multiboot,ramdisk", "multiboot,module"; >> uefi,binary =3D "domA-ramdisk"; >> }; >> }; >>=20 >> domU2 { >> compatible =3D "xen,domain"; >> #address-cells =3D <0x3>; >> #size-cells =3D <0x1>; >> memory =3D <0 0x20000000>; >> cpus =3D <3>; >>=20 >> module@1 { >> compatible =3D "multiboot,kernel", "multiboot,module"; >> uefi,binary =3D "domu-kernel"; >> bootargs =3D "console=3DttyAMA0 init=3D/bin/sh"; >> }; >>=20 >> module@2 { >> compatible =3D "multiboot,ramdisk", "multiboot,module"; >> uefi,binary =3D "domA-ramdisk"; >> }; >> }; >> }; >>=20 >> With this approach, the change is quite minimal to move between an class= ic >> U-boot boot and EFI boot. >=20 > Great idea! I think it is good to try to reuse Device Tree, and using it > as configuration is well aligned with other projects too (e.g. Zephyr). >=20 >=20 > There are a few options for the bindings. These are some ideas. >=20 > If we are just going to specify a filename and a reference with the > "binary" key=3Dvalue pair, then we could get rid of it entirely and just > write the filename directly in device tree: >=20 > domU1 { > compatible =3D "xen,domain"; > #address-cells =3D <0x2>; > #size-cells =3D <0x1>; > memory =3D <0 0x8000000>; > cpus =3D <2>; >=20 > module@1 { > compatible =3D "multiboot,kernel", "multiboot,module"; > uefi,binary =3D "vmlinuz-guest"; > bootargs =3D "console=3DttyAMA0 init=3D/bin/sh"; > }; > }; >=20 > Then we don't even need the binary key=3Dvalue pair, and especially the > device tree becomes "self contained" as in we don't need to resolve the > reference to "binary=3Dvalue ref" to understand it. >=20 >=20 > (Also worth noting as inspiration the HyperLaunch binding that is using > the "mb-index" property as index in the multiboot module chain. Not > directly applicable, but interesting.) Hi Stefano, Yes this is an amazing idea, it will solve every issue without introducing = new keywords in the config file and it maintains the compatibility. Now in the current code there is a check for modules that are =E2=80=9Cmult= iboot,module=E2=80=9D, if any is found the configuration file is skipped, but if we change this bit to check only for modules whose = parent is the chosen node, we can distinguish very well between the dom0 and domus kernel. If we all agree with this, I will update the design. Cheers, Luca =20 From xen-devel-bounces@lists.xenproject.org Wed Sep 08 06:52:19 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Sep 2021 06:52:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.181463.328578 (Exim 4.92) (envelope-from ) id 1mNrRR-0002PG-NA; Wed, 08 Sep 2021 06:52:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 181463.328578; Wed, 08 Sep 2021 06:52:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNrRR-0002P9-KA; Wed, 08 Sep 2021 06:52:17 +0000 Received: by outflank-mailman (input) for mailman id 181463; Wed, 08 Sep 2021 06:52:16 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNrRQ-0002P3-Cl for xen-devel@lists.xenproject.org; Wed, 08 Sep 2021 06:52:16 +0000 Received: from casper.infradead.org (unknown [2001:8b0:10b:1236::1]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 2f72cfd4-adc1-47cb-8b8a-010e1f42024e; Wed, 08 Sep 2021 06:52:15 +0000 (UTC) Received: from hch by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1mNrPl-008Ztv-5x; Wed, 08 Sep 2021 06:50:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2f72cfd4-adc1-47cb-8b8a-010e1f42024e DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=dBfrdwNivWqqlCKmJ0ASZqHL/mKJ+iqsG8FTGZNie28=; b=D6unVWGGt0nhN9vNLt5bPN4XJ6 H5YeTJ6wPEjXfqN4OQvde23ebXYK4ScG4iV7RuMd/m2BDecE+805+QIOyDDJIjDMyQpo4eYaj4QmT F5gpCSBn3mbFzriE/4gNmiFAEKCw8EFJTlqjfosMVn+/7NyuTmPOcaj/pSI3twWgrK3D3gLCgPrMe ka5oWI1awXDsLFEZBWksAMt1lCG3nYEk5JDPx/M4rxdsFFQs1qr52K4DUKb7c+e381aB2rZA5g8eZ E72vmwrF3bYOH4V0FUjxdhgtQPxBvK92pTAIHZbOja/YjfQKbYEWK4Z0FzwpkGP7d/t2qsuf7If0X 4CAEntbw==; Date: Wed, 8 Sep 2021 07:50:33 +0100 From: Christoph Hellwig To: Jan Beulich Cc: Juergen Gross , Boris Ostrovsky , Stefano Stabellini , lkml , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH 02/12] swiotlb-xen: fix late init retry Message-ID: References: <588b3e6d-2682-160c-468e-44ca4867a570@suse.com> <778299d6-9cfd-1c13-026e-25ee5d14ecb3@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <778299d6-9cfd-1c13-026e-25ee5d14ecb3@suse.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html On Tue, Sep 07, 2021 at 02:04:47PM +0200, Jan Beulich wrote: > The commit referenced below removed the assignment of "bytes" from > xen_swiotlb_init() without - like done for xen_swiotlb_init_early() - > adding an assignment on the retry path, thus leading to excessively > sized allocations upon retries. > > Fixes: 2d29960af0be ("swiotlb: dynamically allocate io_tlb_default_mem") > Signed-off-by: Jan Beulich > Cc: stable@vger.kernel.org Looks good, Reviewed-by: Christoph Hellwig From xen-devel-bounces@lists.xenproject.org Wed Sep 08 06:55:09 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Sep 2021 06:55:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.181470.328589 (Exim 4.92) (envelope-from ) id 1mNrUA-00032v-6J; Wed, 08 Sep 2021 06:55:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 181470.328589; Wed, 08 Sep 2021 06:55:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNrUA-00032o-2U; Wed, 08 Sep 2021 06:55:06 +0000 Received: by outflank-mailman (input) for mailman id 181470; Wed, 08 Sep 2021 06:55:04 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNrU8-00032N-AL for xen-devel@lists.xenproject.org; Wed, 08 Sep 2021 06:55:04 +0000 Received: from casper.infradead.org (unknown [2001:8b0:10b:1236::1]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 4ee8d88b-6697-42d9-a1a9-435fb2597190; Wed, 08 Sep 2021 06:54:59 +0000 (UTC) Received: from hch by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1mNrSS-008a0O-5n; Wed, 08 Sep 2021 06:53:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4ee8d88b-6697-42d9-a1a9-435fb2597190 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=mNv6jBhL0dwmk4rDDYf4ikhCU0kC8phJg4t0M4uQRDc=; b=aE5y0hGlp2Xj4xb952dvEVdScM KnAkeo8HeySFYAkHcdp37IMVTE1i0gtREK8+yHbyQ5UCZahHa1/ncIMqtviCOSYTzL/AmK9KAmrfa GbkJD7rJALGnUYk7MMG+5GPjSi3u2vcTySZWbKcHBhIaTZfX4KhIV1b8fYvgn6mid2qUVy57Zv+xj bT3JLbdCLI2NEQBhgA864/cN0ICBGxedybXpxHkTrhaXYJUYyO3bprAOlD7SGZz90vpWEEFcJpiki keuEbK6oYViBMYnqTQotJTIhoHqzVhJ17AvLP/tLzLc46VGBhDiVNvg6j04I7IECrcc9WRWQ0W5gg EL39LFfg==; Date: Wed, 8 Sep 2021 07:53:20 +0100 From: Christoph Hellwig To: Jan Beulich Cc: Juergen Gross , Boris Ostrovsky , Stefano Stabellini , lkml , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH 03/12] swiotlb-xen: maintain slab count properly Message-ID: References: <588b3e6d-2682-160c-468e-44ca4867a570@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html On Tue, Sep 07, 2021 at 02:05:12PM +0200, Jan Beulich wrote: > Generic swiotlb code makes sure to keep the slab count a multiple of the > number of slabs per segment. Yet even without checking whether any such > assumption is made elsewhere, it is easy to see that xen_swiotlb_fixup() > might alter unrelated memory when calling xen_create_contiguous_region() > for the last segment, when that's not a full one - the function acts on > full order-N regions, not individual pages. > > Align the slab count suitably when halving it for a retry. Add a build > time check and a runtime one. Replace the no longer useful local > variable "slabs" by an "order" one calculated just once, outside of the > loop. Re-use "order" for calculating "dma_bits", and change the type of > the latter as well as the one of "i" while touching this anyway. > > Signed-off-by: Jan Beulich Looks good, Reviewed-by: Christoph Hellwig From xen-devel-bounces@lists.xenproject.org Wed Sep 08 06:58:21 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Sep 2021 06:58:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.181476.328600 (Exim 4.92) (envelope-from ) id 1mNrXI-0003hH-Me; Wed, 08 Sep 2021 06:58:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 181476.328600; Wed, 08 Sep 2021 06:58:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNrXI-0003hA-J9; Wed, 08 Sep 2021 06:58:20 +0000 Received: by outflank-mailman (input) for mailman id 181476; Wed, 08 Sep 2021 06:58:18 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNrXG-0003h4-TA for xen-devel@lists.xenproject.org; Wed, 08 Sep 2021 06:58:18 +0000 Received: from casper.infradead.org (unknown [2001:8b0:10b:1236::1]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 4e0cca89-1a5b-425a-8854-31c4169a11bb; Wed, 08 Sep 2021 06:58:18 +0000 (UTC) Received: from hch by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1mNrWF-008a9l-56; Wed, 08 Sep 2021 06:57:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4e0cca89-1a5b-425a-8854-31c4169a11bb DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=yqhbwzwdJH8qRS1MarFWp8lRnwDdQKIjHrVncEEHPh8=; b=fgBDwHw7l63tdQPsH7I2iUXyMZ u6GLvgy1FAu0zukPtZrZWZAGYTkNv93qLQ0SzlM4o/dSNEZZB34rJlFBTv+g/qg2PSEBxfH0qrtEq 40iF+eI7p8r9HBX4e+qdIj0FiX5kR8x0Cn7qtaYsW6Hvb2GMjQzPi+kaNS7GQYVkm5RdE447u5hGc 0550qzIoVi9MtzwZPjO8uku14gwMEt+yVYO9XZqzB0c2z092Fp/J7HiOH1tOmYfikBtfWZVXUaXy0 tBjOyYM79QvEb39a4jsRkH0T1KaIT2OpzIi4U5yUtMw5Yt8jo0gL7SIhFqjH9BrADxVv9XMb5RgYq euwSfHxg==; Date: Wed, 8 Sep 2021 07:57:15 +0100 From: Christoph Hellwig To: Jan Beulich Cc: Juergen Gross , Boris Ostrovsky , Stefano Stabellini , lkml , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH 04/12] swiotlb-xen: ensure to issue well-formed XENMEM_exchange requests Message-ID: References: <588b3e6d-2682-160c-468e-44ca4867a570@suse.com> <397bf325-f81e-e104-6142-e8c9c4955475@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <397bf325-f81e-e104-6142-e8c9c4955475@suse.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html On Tue, Sep 07, 2021 at 02:05:32PM +0200, Jan Beulich wrote: > While the hypervisor hasn't been enforcing this, we would still better > avoid issuing requests with GFNs not aligned to the requested order. > > Signed-off-by: Jan Beulich > --- > I wonder how useful it is to include the alignment in the panic() > message. I further wonder how useful it is to wrap "bytes" in > PAGE_ALIGN(), when it is a multiple of a segment's size anyway (or at > least was supposed to be, prior to "swiotlb-xen: maintain slab count > properly"). > > --- a/drivers/xen/swiotlb-xen.c > +++ b/drivers/xen/swiotlb-xen.c > @@ -231,10 +231,10 @@ retry: > /* > * Get IO TLB memory from any location. > */ > - start = memblock_alloc(PAGE_ALIGN(bytes), PAGE_SIZE); > + start = memblock_alloc(PAGE_ALIGN(bytes), IO_TLB_SEGSIZE << IO_TLB_SHIFT); > if (!start) > - panic("%s: Failed to allocate %lu bytes align=0x%lx\n", > - __func__, PAGE_ALIGN(bytes), PAGE_SIZE); > + panic("%s: Failed to allocate %lu bytes align=%#x\n", > + __func__, PAGE_ALIGN(bytes), IO_TLB_SEGSIZE << IO_TLB_SHIFT); CAn you avoid the overly long lines here? A good way to make it more readable would be a variable to hold the byte count. From xen-devel-bounces@lists.xenproject.org Wed Sep 08 07:00:04 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Sep 2021 07:00:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.181482.328610 (Exim 4.92) (envelope-from ) id 1mNrYx-0004Wz-1U; Wed, 08 Sep 2021 07:00:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 181482.328610; Wed, 08 Sep 2021 07:00:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNrYw-0004WI-Ug; Wed, 08 Sep 2021 07:00:02 +0000 Received: by outflank-mailman (input) for mailman id 181482; Wed, 08 Sep 2021 07:00:01 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNrYv-0004Hv-Hk for xen-devel@lists.xenproject.org; Wed, 08 Sep 2021 07:00:01 +0000 Received: from casper.infradead.org (unknown [2001:8b0:10b:1236::1]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id cc851688-09a0-43ef-9428-e4d35a423485; Wed, 08 Sep 2021 07:00:00 +0000 (UTC) Received: from hch by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1mNrXr-008aF4-Do; Wed, 08 Sep 2021 06:59:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cc851688-09a0-43ef-9428-e4d35a423485 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=7gmr+v/UYd69hqQff5Fcu4B0asSjyasIdDD4iqilMBs=; b=BhJhq2e3Ic/6vaQ2X9A7y70QlA LN7tsn+RSNKPWUCjSCIDNsjviepIb4CgpXAMqNPNl0hCUOuRIE5CY+CkQLja8SX75eR6DryDm1ntu 3lscohH7+1ssTfUDNi/P/N7uBNXacnQBZA8Hwdqtv+q8NMyvtpoAp4qXNq9o5P6fAZ2/dkCjoEriy 9tKDLpzsK8JdUsp5eCc433G7x3oabL/dTqC0I0T/PLIzJFdqeztX9uUHC6V51OBay7pb4m35Oya0f MqyWaHEDdXo8bVRyW4we+Z42VMXBxFTjies7EWwuwlP/xoOr+NeRaW4DyrX4oGeCcpwEA6IVe1Gbq 8C+Nm+Sg==; Date: Wed, 8 Sep 2021 07:58:55 +0100 From: Christoph Hellwig To: Jan Beulich Cc: Juergen Gross , Boris Ostrovsky , Stefano Stabellini , lkml , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH 05/12] swiotlb-xen: suppress certain init retries Message-ID: References: <588b3e6d-2682-160c-468e-44ca4867a570@suse.com> <56477481-87da-4962-9661-5e1b277efde0@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56477481-87da-4962-9661-5e1b277efde0@suse.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html On Tue, Sep 07, 2021 at 02:05:54PM +0200, Jan Beulich wrote: > Only on the 2nd of the paths leading to xen_swiotlb_init()'s "error" > label it is useful to retry the allocation; the first one did already > iterate through all possible order values. > > Signed-off-by: Jan Beulich Looks good, Reviewed-by: Christoph Hellwig From xen-devel-bounces@lists.xenproject.org Wed Sep 08 07:01:24 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Sep 2021 07:01:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.181489.328622 (Exim 4.92) (envelope-from ) id 1mNraD-0005rE-Da; Wed, 08 Sep 2021 07:01:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 181489.328622; Wed, 08 Sep 2021 07:01:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNraD-0005r7-9X; Wed, 08 Sep 2021 07:01:21 +0000 Received: by outflank-mailman (input) for mailman id 181489; Wed, 08 Sep 2021 07:01:20 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNraB-0005r1-VT for xen-devel@lists.xenproject.org; Wed, 08 Sep 2021 07:01:19 +0000 Received: from casper.infradead.org (unknown [2001:8b0:10b:1236::1]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id ce99a267-d7c9-403e-8b14-e9dad578ed15; Wed, 08 Sep 2021 07:01:19 +0000 (UTC) Received: from hch by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1mNrZH-008aHN-76; Wed, 08 Sep 2021 07:00:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ce99a267-d7c9-403e-8b14-e9dad578ed15 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=R8OKvw4S2MzNKNmIXpBxq9HTvvmNUrQ/SvUk9VnsHUY=; b=rpo3HkOJxy7GQnr44u+Kw8/GWw b8U0qMtuai8fWaIBPF65LKePgrrYtAvsRonr7HKZ/kABbXwFaD3Mpb9NLGgv57kVtXFmpclCY72AW bRhylceyEaHc9mZwksibH7RRQWka7q8ZoZO0inYa0QUo14guNPVn4vgylPrf7IJVRKoj/ZEvI6QNn BnqFevB+Z2JckxFutk9LRF6NHmlUhurLK75V0CumKbej0KWAQMeYjX0SWkuA0cQAqZ5knLN3VjNDg 0Q71U9TW6LUgg1Y/e5lIBYVvFbraJ7etFrdulT7G7nM5y7yJQdeATwHB+s08UVof9jVe9hk8cGZ1V nCpsr0OQ==; Date: Wed, 8 Sep 2021 08:00:23 +0100 From: Christoph Hellwig To: Jan Beulich Cc: Juergen Gross , Boris Ostrovsky , Stefano Stabellini , lkml , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH 06/12] swiotlb-xen: limit init retries Message-ID: References: <588b3e6d-2682-160c-468e-44ca4867a570@suse.com> <984fa426-2b7b-4b77-5ce8-766619575b7f@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <984fa426-2b7b-4b77-5ce8-766619575b7f@suse.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html On Tue, Sep 07, 2021 at 02:06:37PM +0200, Jan Beulich wrote: > Due to the use of max(1024, ...) there's no point retrying (and issuing > bogus log messages) when the number of slabs is already no larger than > this minimum value. > > Signed-off-by: Jan Beulich Looks good, Reviewed-by: Christoph Hellwig From xen-devel-bounces@lists.xenproject.org Wed Sep 08 07:03:59 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Sep 2021 07:03:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.181496.328633 (Exim 4.92) (envelope-from ) id 1mNrck-0006Wy-Ph; Wed, 08 Sep 2021 07:03:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 181496.328633; Wed, 08 Sep 2021 07:03:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNrck-0006Wr-MY; Wed, 08 Sep 2021 07:03:58 +0000 Received: by outflank-mailman (input) for mailman id 181496; Wed, 08 Sep 2021 07:03:57 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNrcj-0006Wl-Il for xen-devel@lists.xenproject.org; Wed, 08 Sep 2021 07:03:57 +0000 Received: from casper.infradead.org (unknown [2001:8b0:10b:1236::1]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 80301a52-5a33-41df-be3c-c5a0d125574b; Wed, 08 Sep 2021 07:03:55 +0000 (UTC) Received: from hch by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1mNrbE-008aLp-HO; Wed, 08 Sep 2021 07:03:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 80301a52-5a33-41df-be3c-c5a0d125574b DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=gatW1BubQnKb2kduQto9Cf0sWBkeir64mglmf+pQf2Q=; b=k7G3Dc9dTikD/msbbkUkrK6bH/ rcD7O+3KeLMyQ1++oVllKlyi8fr3OzWCFSPglsQEwTuZYSOeBs1r73L3/drk5ceobljVtDfydSKFB j/domY+VTpfr9Pk9f5rNEQqFYIDkHP5jTSDi9iVT3CSZOC35ka5bQlKxSolhcWPXaq/1QfK21G+ih COU4O1kTW2U6YdQXei4QY2KiZAUUKvTqMlzEA/VevxT4QnIBgJt2vBtZgAO4rpNo8bQHCz2QyPe5C fe2/HGVSMq4ipo4jC45iFAjbTS29+lrORLywMIyJG16unTn6UIJAoJaoEX8vMVXeRptUArk8CdQ0M IkU/sUdQ==; Date: Wed, 8 Sep 2021 08:02:24 +0100 From: Christoph Hellwig To: Jan Beulich Cc: Juergen Gross , Boris Ostrovsky , Stefano Stabellini , lkml , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH 07/12] swiotlb-xen: drop leftover __ref Message-ID: References: <588b3e6d-2682-160c-468e-44ca4867a570@suse.com> <7cd163e1-fe13-270b-384c-2708e8273d34@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7cd163e1-fe13-270b-384c-2708e8273d34@suse.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html On Tue, Sep 07, 2021 at 02:06:55PM +0200, Jan Beulich wrote: > Commit a98f565462f0 ("xen-swiotlb: split xen_swiotlb_init") should not > only have added __init to the split off function, but also should have > dropped __ref from the one left. > > Signed-off-by: Jan Beulich Looks good, Reviewed-by: Christoph Hellwig From xen-devel-bounces@lists.xenproject.org Wed Sep 08 07:06:11 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Sep 2021 07:06:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.181502.328644 (Exim 4.92) (envelope-from ) id 1mNres-00079G-6j; Wed, 08 Sep 2021 07:06:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 181502.328644; Wed, 08 Sep 2021 07:06:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNres-000799-3c; Wed, 08 Sep 2021 07:06:10 +0000 Received: by outflank-mailman (input) for mailman id 181502; Wed, 08 Sep 2021 07:06:09 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNrer-000793-0h for xen-devel@lists.xenproject.org; Wed, 08 Sep 2021 07:06:09 +0000 Received: from casper.infradead.org (unknown [2001:8b0:10b:1236::1]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 47745604-fee7-4bdb-b441-22ad7585a358; Wed, 08 Sep 2021 07:06:03 +0000 (UTC) Received: from hch by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1mNrdA-008aSO-K1; Wed, 08 Sep 2021 07:04:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 47745604-fee7-4bdb-b441-22ad7585a358 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=u0jDPhGZwBkm+JMr6omQzYQizJyYgqZlwoU/jhm0G5s=; b=MlbsyzCdFKeIEDRfx1McK2amJc sZxrTxkScG/1WgXYGHD4V+bhWBRDZcajEMfSC3Rwh7B9lDj5xGPybecP4NGCxlvEnCQ5dAOw/mvQC Ne+YzN2biFxXb0cqjqdD5AOk5OTnSO86XUY8fGrf5F9OLSg1zVss0ee990dy8gbMeXRwV80gqaQDr AB/je8uC8iu7fwxs1wpvfFnQHp9bbN0RhMh1Yv+PeKByy9sQeiTX39GFwbTWNr1IIAGhJtTj1RjEi nMjgdiOKSed2JDSqDn7hI5nd+A9lN6PF4SsxMBk0Yvlq7ucqDs2VuYNkj6v52X1Qm7lpLLWu3Xn5N JDT+ugtg==; Date: Wed, 8 Sep 2021 08:04:24 +0100 From: Christoph Hellwig To: Jan Beulich Cc: Juergen Gross , Boris Ostrovsky , Stefano Stabellini , lkml , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH 08/12] swiotlb-xen: arrange to have buffer info logged Message-ID: References: <588b3e6d-2682-160c-468e-44ca4867a570@suse.com> <2e3c8e68-36b2-4ae9-b829-bf7f75d39d47@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2e3c8e68-36b2-4ae9-b829-bf7f75d39d47@suse.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html On Tue, Sep 07, 2021 at 02:07:21PM +0200, Jan Beulich wrote: > I consider it unhelpful that address and size of the buffer aren't put > in the log file; it makes diagnosing issues needlessly harder. The > majority of callers of swiotlb_init() also passes 1 for the "verbose" > parameter. > > Signed-off-by: Jan Beulich Looks good, Reviewed-by: Christoph Hellwig From xen-devel-bounces@lists.xenproject.org Wed Sep 08 07:08:34 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Sep 2021 07:08:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.181508.328655 (Exim 4.92) (envelope-from ) id 1mNrh7-0007ml-Ko; Wed, 08 Sep 2021 07:08:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 181508.328655; Wed, 08 Sep 2021 07:08:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNrh7-0007me-Ga; Wed, 08 Sep 2021 07:08:29 +0000 Received: by outflank-mailman (input) for mailman id 181508; Wed, 08 Sep 2021 07:08:28 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNrh5-0007mY-V4 for xen-devel@lists.xenproject.org; Wed, 08 Sep 2021 07:08:27 +0000 Received: from casper.infradead.org (unknown [2001:8b0:10b:1236::1]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 68e862cc-57a1-443a-963a-8cfc54df5453; Wed, 08 Sep 2021 07:08:26 +0000 (UTC) Received: from hch by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1mNrfF-008aXl-2g; Wed, 08 Sep 2021 07:06:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 68e862cc-57a1-443a-963a-8cfc54df5453 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=xTrVWx4u6aj0HJxIiwK6w63wBv8UFL6W0kryTgqQOBk=; b=UZnSHfGOxpfl5k2QHa5deLLAej zonJbx4n51ec8iDwWq3JYz2OPPMiVjGyAUWGv4ls4dA1usel5U3fT/1gvezBu704ucCFd3+IoU+Xx /3suk5AMMFVT85WrMAbyKyeKyDc8jQpU1ubdS0X6vYrUL91adfQ/uEwVJtCOmDDvt/xQGeNw5r7aT yWtkmphfLXByz/kFQQDjCEIQq8TuIrs78mKspznFajfvCQvCX6gPMzESAMk0sibuyeVlB3FQIOYdo CHiaZ+u6qSC1/p9oaZJ8UOV2EehqAHMkshll3Ux7bbkQN51H9mmfHonVGwsJSgxPP910Gd4H8k47p w6qvbcTw==; Date: Wed, 8 Sep 2021 08:06:33 +0100 From: Christoph Hellwig To: Jan Beulich Cc: Juergen Gross , Boris Ostrovsky , Stefano Stabellini , lkml , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH 09/12] swiotlb-xen: drop DEFAULT_NSLABS Message-ID: References: <588b3e6d-2682-160c-468e-44ca4867a570@suse.com> <15259326-209a-1d11-338c-5018dc38abe8@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <15259326-209a-1d11-338c-5018dc38abe8@suse.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html On Tue, Sep 07, 2021 at 02:07:47PM +0200, Jan Beulich wrote: > It was introduced by 4035b43da6da ("xen-swiotlb: remove xen_set_nslabs") > and then not removed by 2d29960af0be ("swiotlb: dynamically allocate > io_tlb_default_mem"). > > Signed-off-by: Jan Beulich Looks good, Reviewed-by: Christoph Hellwig From xen-devel-bounces@lists.xenproject.org Wed Sep 08 07:10:32 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Sep 2021 07:10:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.181514.328666 (Exim 4.92) (envelope-from ) id 1mNrj4-0000ga-WD; Wed, 08 Sep 2021 07:10:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 181514.328666; Wed, 08 Sep 2021 07:10:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNrj4-0000gT-TH; Wed, 08 Sep 2021 07:10:30 +0000 Received: by outflank-mailman (input) for mailman id 181514; Wed, 08 Sep 2021 07:10:30 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNrj4-0000gN-8d for xen-devel@lists.xenproject.org; Wed, 08 Sep 2021 07:10:30 +0000 Received: from casper.infradead.org (unknown [2001:8b0:10b:1236::1]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 0e2bd219-9118-4494-9a0d-590a504c9997; Wed, 08 Sep 2021 07:10:29 +0000 (UTC) Received: from hch by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1mNrha-008aj6-H4; Wed, 08 Sep 2021 07:09:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0e2bd219-9118-4494-9a0d-590a504c9997 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=BIE/LIdFO8jY5B6XQFOTWQMi8dbTNeZ9iRgAJzUQFJU=; b=sj3hwvVEXJG7RXFgHJKiWrl2DW PSMKQHTTMqu0a23Z7httVaAjEPT4AM/xssoAfAMFxEVJ6rBlvytzg+s4FehCm7M2Zxirf64YczMY7 12aopbnZx89CwC6n3lwGa5O0523gUpp+NyNoIRD2nC/aGJ3FvqwZHevdybiDOFcOFgaGILaXKVRNe Guo/1qOs4FIXJKtxXEZwQhH4ONEiYUG6xp7qxMxYlUPnI8paKE4dBt5vDzj/NFUNVslm6Yp2u200T CuTrCqt17eJo9fP2yxyZHTHqo9QXfN+KhClS4uoWVTEBVxSLfZlemZN6pP2UsIeLh8g8G0WXBkRNM kRaojG4w==; Date: Wed, 8 Sep 2021 08:08:58 +0100 From: Christoph Hellwig To: Jan Beulich Cc: Juergen Gross , Boris Ostrovsky , Stefano Stabellini , lkml , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH 11/12] xen/pci-swiotlb: reduce visibility of symbols Message-ID: References: <588b3e6d-2682-160c-468e-44ca4867a570@suse.com> <75591cef-95e8-c694-fd11-283800499e4e@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <75591cef-95e8-c694-fd11-283800499e4e@suse.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html On Tue, Sep 07, 2021 at 02:11:14PM +0200, Jan Beulich wrote: > xen_swiotlb and pci_xen_swiotlb_init() are only used within the file > defining them, so make them static and remove the stubs. Otoh > pci_xen_swiotlb_detect() has a use (as function pointer) from the main > pci-swiotlb.c file - convert its stub to a #define to NULL. > > Signed-off-by: Jan Beulich Looks good, Reviewed-by: Christoph Hellwig From xen-devel-bounces@lists.xenproject.org Wed Sep 08 07:15:46 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Sep 2021 07:15:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.181526.328676 (Exim 4.92) (envelope-from ) id 1mNro5-0001d2-Mq; Wed, 08 Sep 2021 07:15:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 181526.328676; Wed, 08 Sep 2021 07:15:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNro5-0001cv-Js; Wed, 08 Sep 2021 07:15:41 +0000 Received: by outflank-mailman (input) for mailman id 181526; Wed, 08 Sep 2021 07:15:40 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNro4-0001cp-0O for xen-devel@lists.xenproject.org; Wed, 08 Sep 2021 07:15:40 +0000 Received: from server.eikelenboom.it (unknown [91.121.65.215]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 5270bb18-20b0-4a0e-84d0-487559756e76; Wed, 08 Sep 2021 07:15:37 +0000 (UTC) Received: from 76-24-144-85.ftth.glasoperator.nl ([85.144.24.76]:59650 helo=[172.16.1.50]) by server.eikelenboom.it with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1mNrnq-0003D7-Vf; Wed, 08 Sep 2021 09:15:27 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5270bb18-20b0-4a0e-84d0-487559756e76 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=eikelenboom.it; s=20180706; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:References:To:From:Subject:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=bqLBZYZf+OGSwmIWDrkm11xoKqUhXHfSvj8/ddCAhHY=; b=f+l7brMEK28eKiSLveWpl+GucP KwotBj40F1WcwLc34Kyaj+9/tr19Gu+v1hWtzJpIpA9ffFj9P+fivlaGcF4cBrxIndrefuz2FvspB ZOI5n0APGJAAfHPLkTij9pEJJ+zUHLgJWGv+kLPG8VjzCrmqFoP9nYikM7eSRR/RfBos=; Subject: Re: xen-unstable linux-5.14: 1 of 2 multicall(s) failed: cpu 0 From: Sander Eikelenboom To: Juergen Gross , "xen-devel@lists.xenproject.org" References: <9c36205e-cc37-ed9a-3408-0cccc4a83115@eikelenboom.it> <955da8ce-40f2-32c5-ee78-6801ce18afe5@suse.com> Message-ID: Date: Wed, 8 Sep 2021 09:15:36 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: nl-NL Content-Transfer-Encoding: 8bit On 07/09/2021 21:52, Sander Eikelenboom wrote: > On 07/09/2021 15:53, Juergen Gross wrote: >> On 06.09.21 23:35, Sander Eikelenboom wrote: >>> L.S., >>> >>> On my AMD box running: >>>     xen-unstable changeset: Fri Sep 3 15:10:43 2021 +0200 git:2d4978ead4 >>>     linux kernel: 5.14.1 >>> >>> With this setup I'm encountering some issues in dom0, see below. >> >> Could you test whether the attached patch (only compile tested) >> fixes the issue for you? >> >> >> Juergen >> > > Sure, running it now. > Since I haven't got a clear trigger, will report tomorrow if the logs stay clean :) > > Thanks so far ! > > -- > Sander > > Hi Juergen, So far so good, it survived the night without issues. So I think you can add a Tested-By. Thanks for the swift fix ! -- Sander From xen-devel-bounces@lists.xenproject.org Wed Sep 08 07:16:44 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Sep 2021 07:16:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.181533.328688 (Exim 4.92) (envelope-from ) id 1mNrp6-0002Dd-1H; Wed, 08 Sep 2021 07:16:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 181533.328688; Wed, 08 Sep 2021 07:16:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNrp5-0002DW-Tw; Wed, 08 Sep 2021 07:16:43 +0000 Received: by outflank-mailman (input) for mailman id 181533; Wed, 08 Sep 2021 07:16:42 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNrp4-0002DM-4b for xen-devel@lists.xenproject.org; Wed, 08 Sep 2021 07:16:42 +0000 Received: from casper.infradead.org (unknown [2001:8b0:10b:1236::1]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 6f81b569-4fed-42fa-9d05-4bfd16929154; Wed, 08 Sep 2021 07:16:40 +0000 (UTC) Received: from hch by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1mNrml-008b2V-QY; Wed, 08 Sep 2021 07:14:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6f81b569-4fed-42fa-9d05-4bfd16929154 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=MnjsixqmosBihT6Q0qVYXXqBZ2K/JeOxHPpv883b1xQ=; b=XbM8Xg3PjSFGTYmv3zW07WfyaY yWEdMq1eEqx0RRQqf2r7e6pYKpvEx0oG4KVrQaoCagb/MmI7o0acywnXwpXSPJTo/1MkSPkPOEFJy mKVPyz7XoUQE44YQmLjxnlC/1P/RLwrxrspgdaqdkFsWsJpB2cRQfFSd4r+Bz7k7bOYyGJ9XCEdOU VV701Kva713ECwwrgTRZcHhYdgohcpF+ORONW/M/BNUXYF7JoqGFO0tJVrTc+1JqjXQEOCwt3RRqO IbwKTqnS0QnoY/SeWesV1xBSinYJz2jyaANLtuvExQupl4FPr9q6HdJd1s3vCXjHopyF3JjAZ7vVe 7+fwQCwQ==; Date: Wed, 8 Sep 2021 08:14:19 +0100 From: Christoph Hellwig To: Jan Beulich Cc: Juergen Gross , Boris Ostrovsky , Stefano Stabellini , lkml , "xen-devel@lists.xenproject.org" , the arch/x86 maintainers , Thomas Gleixner , Ingo Molnar , Borislav Petkov Subject: Re: [PATCH 12/12] swiotlb-xen: this is PV-only on x86 Message-ID: References: <588b3e6d-2682-160c-468e-44ca4867a570@suse.com> <004feaef-f3bb-e4bb-fb10-f205a9f69f28@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <004feaef-f3bb-e4bb-fb10-f205a9f69f28@suse.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html On Tue, Sep 07, 2021 at 02:13:21PM +0200, Jan Beulich wrote: > The code is unreachable for HVM or PVH, and it also makes little sense > in auto-translated environments. On Arm, with > xen_{create,destroy}_contiguous_region() both being stubs, I have a hard > time seeing what good the Xen specific variant does - the generic one > ought to be fine for all purposes there. Still Arm code explicitly > references symbols here, so the code will continue to be included there. Can the Xen/arm folks look into that? Getting ARM out of using swiotlb-xen would be a huge step forward cleaning up some DMA APIs. > > Instead of making PCI_XEN's "select" conditional, simply drop it - > SWIOTLB_XEN will be available unconditionally in the PV case anyway, and > is - as explained above - dead code in non-PV environments. > > This in turn allows dropping the stubs for > xen_{create,destroy}_contiguous_region(), the former of which was broken > anyway - it failed to set the DMA handle output. Looks good: Reviewed-by: Christoph Hellwig From xen-devel-bounces@lists.xenproject.org Wed Sep 08 07:34:45 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Sep 2021 07:34:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.181543.328699 (Exim 4.92) (envelope-from ) id 1mNs6I-0004uC-JA; Wed, 08 Sep 2021 07:34:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 181543.328699; Wed, 08 Sep 2021 07:34:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNs6I-0004u5-Et; Wed, 08 Sep 2021 07:34:30 +0000 Received: by outflank-mailman (input) for mailman id 181543; Wed, 08 Sep 2021 07:34:29 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNs6H-0004tz-AA for xen-devel@lists.xenproject.org; Wed, 08 Sep 2021 07:34:29 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (unknown [40.107.21.81]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 31fdb5b4-1077-11ec-b147-12813bfff9fa; Wed, 08 Sep 2021 07:34:27 +0000 (UTC) Received: from AM6P191CA0072.EURP191.PROD.OUTLOOK.COM (2603:10a6:209:7f::49) by GV1PR08MB7314.eurprd08.prod.outlook.com (2603:10a6:150:1d::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.25; Wed, 8 Sep 2021 07:34:18 +0000 Received: from VE1EUR03FT012.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:7f:cafe::b6) by AM6P191CA0072.outlook.office365.com (2603:10a6:209:7f::49) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14 via Frontend Transport; Wed, 8 Sep 2021 07:34:18 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT012.mail.protection.outlook.com (10.152.18.211) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Wed, 8 Sep 2021 07:34:18 +0000 Received: ("Tessian outbound 0ec886cb54dd:v105"); Wed, 08 Sep 2021 07:34:17 +0000 Received: from e0baeef2aed7.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 85FF79B3-9BA3-4458-AEF8-EC0CB6DB9A29.1; Wed, 08 Sep 2021 07:34:08 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e0baeef2aed7.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 08 Sep 2021 07:34:08 +0000 Received: from DB9PR08MB6857.eurprd08.prod.outlook.com (2603:10a6:10:2a2::7) by DBBPR08MB6281.eurprd08.prod.outlook.com (2603:10a6:10:1f6::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.22; Wed, 8 Sep 2021 07:34:05 +0000 Received: from DB9PR08MB6857.eurprd08.prod.outlook.com ([fe80::2c28:50cf:49fd:da32]) by DB9PR08MB6857.eurprd08.prod.outlook.com ([fe80::2c28:50cf:49fd:da32%9]) with mapi id 15.20.4478.025; Wed, 8 Sep 2021 07:34:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 31fdb5b4-1077-11ec-b147-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3Z+hSZ9cAhQo5fyXkwP2E3uRS7GHreh4U+7Gx87EBjs=; b=2BOFqqVmTJNw0HYG2y+nk+x7tus10L5yedUbvS7Iyla+tade+y1M4TPr+9jYyhFEt/PpBTUPKKAgOhCyqMnrfoP8hW23dK02ANgbZmb0LZYVa+pLLsobfdrEEo45Vvh++I8lKeWrmgN6nz9VspbsLi0KudX8QgG7gr6kLwoIksA= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KSmxRL6x+q0cZxShWhZZ3qnp+XpEh6YPSINKOBd+6Szccvfs3HWHffP+h/z0QV1D1HBUHhM7P50a1SJOhQ3UdOxqaYk9urOZu3pqH9WSkWcb/bUgTnyoQtNQ/IBEyCiq8F/9NwUwIuf3zZ+EwoJJ+7u3SY2JEydo5YsElYUNhxSdZio2XGMjRTYbIYEsPZiI6TGRXmulxeMjgiiOwY9FUHwFmxEExaT7dpXSRlmYu6fqpnJIliqYeaRDer+A/Q5HWTSlWSRo1jpIpjMjk41BrO0CEeuy+kZtCGBTMvaQeBjGU2yuPqOGnLs8LWcHrQBEJ3dKLl8yR8XjjCRLuJNVdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=3Z+hSZ9cAhQo5fyXkwP2E3uRS7GHreh4U+7Gx87EBjs=; b=HKsK2fVoX30nujNdv6rfMgMAZpRd7mwaoClPT1cXVVms3N1B9CE5jRjZ/fuVVdWwlyGjaMu9S4wjOB78Uzu6M/PLA825nOFGtPf7jxVa51HfbE/N8Nlq7f906lqmmMOBBEFOYWEto1jH4KkoHhbq4L1J+dwO10qO1sHdA25knqo77WR/+4pBahzfcsvN8/cfUqQDz74JC9jRcSkf1JoKaU+xqL++h51nMFZdPRBHCe6Bjam9OGqu2ftxGIWtWkD3UYAAhF9P67Vh867xUzjwm9ImAjnRs1eIlLAtCeckMYXGxcRq7g5F9OxbK5DG/dZSCCPQ5NZtKvIV1fEXW1m0OQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3Z+hSZ9cAhQo5fyXkwP2E3uRS7GHreh4U+7Gx87EBjs=; b=2BOFqqVmTJNw0HYG2y+nk+x7tus10L5yedUbvS7Iyla+tade+y1M4TPr+9jYyhFEt/PpBTUPKKAgOhCyqMnrfoP8hW23dK02ANgbZmb0LZYVa+pLLsobfdrEEo45Vvh++I8lKeWrmgN6nz9VspbsLi0KudX8QgG7gr6kLwoIksA= From: Wei Chen To: Wei Chen , Julien Grall , Stefano Stabellini CC: "xen-devel@lists.xenproject.org" , Bertrand Marquis , Jan Beulich Subject: RE: [XEN RFC PATCH 23/40] xen/arm: introduce a helper to parse device tree memory node Thread-Topic: [XEN RFC PATCH 23/40] xen/arm: introduce a helper to parse device tree memory node Thread-Index: AQHXjps6uVXfLZKD7EKSvvhEptOzS6uINJ4AgAAs9PCAAHGGgIAAOFuQgBDWjrA= Date: Wed, 8 Sep 2021 07:34:04 +0000 Message-ID: References: <20210811102423.28908-1-wei.chen@arm.com> <20210811102423.28908-24-wei.chen@arm.com> <5c9a196a-8ac3-1173-f402-01d99ccc23e4@xen.org> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: B42AF9527E707E4F828EBE67411CFEAB.0 x-checkrecipientchecked: true Authentication-Results-Original: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: c9698f87-b599-4132-5fc8-08d9729b1154 x-ms-traffictypediagnostic: DBBPR08MB6281:|GV1PR08MB7314: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:10000;OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: U/DkNesgfc40VW7sjTPexyjjxeOVhyVtJwcu4O1SQV8iNfs+5ySPIUCtY5SpirDjMI1f3znBODsat65VCmeIoSP7/jRId6hWgx5IWiKw7txeZo6GPvcXNgyPZGswSAPz6qbf0+MtVu/I7AD0lBBOJ6RvmSrCnJKBsqyLC/NSQM93T0mUrEMztX5NYsmj84QxMDCxIfhCeRoRZkyAOePkwN7H+KrZvVDShS1KLGnKRKgtD6f5Goo1jgIAXIQ1sVu1+GzSQaQhLnx5BsCDChjw2sZdlNTYaxoHHj4QnH8sTieOlqp36XC29dZQTENvZyayGRfMHxFqYMxLwlxPN8bpyg+CcHUB6r/D/1xlxg+ua4vOvAeHhtwDfpHPrYp9Ebin14RoajlX2lidVkbN0GKxJCXajlX69epR8c3gSpuGHOAKBcYWU7eoP6reWHJ/vAmN/6wWd3am9fIS391ATtnMZN8V9PAjFuiZJxU0jCzLEOvjpCArFGNPlKoOgyJDPpsXtNq4obzgMaCmg0t5xCl/2bAkKK9PAHjQ5xxWBzq6d2ajiqXZron+HlNdqiXjlRdvKmy1kAjf/UyYPx9WAKPQYSGgVq02J3CQpKBKvhXOXxlBVPhV2SYPeCaXuJ2V7T1NyeF57VmGjHPNm+WajLFtFxONByq+BKqnpn45J0z25Jx+ZyVrISrQSQUcEtk/UQVpM2DEH1w0+/ZYaXpA/RF8W0zwsxm//s0dFNXEXm3AJY3zB7ylZYDpR6/dzK+yfCfnAVYuznhavO26drP5031EvxaIJfyHRcXklU6wtlBwWZ9RQGybpPqiOJVH+CrPYEcM8XRMf6XYR6VJ065oAq2D7Q== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB9PR08MB6857.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(376002)(346002)(366004)(39860400002)(136003)(86362001)(2906002)(110136005)(316002)(5660300002)(9686003)(4326008)(55016002)(54906003)(33656002)(38070700005)(71200400001)(966005)(53546011)(6506007)(52536014)(186003)(66946007)(66446008)(66556008)(66476007)(64756008)(76116006)(8936002)(83380400001)(478600001)(26005)(8676002)(38100700002)(122000001)(7696005);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB6281 Original-Authentication-Results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT012.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: b6b65d38-cc08-4940-3c67-08d9729b093c X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: u3fd9pt+5wWhVfuSJ/JSKWcjID+5fgu8Dk4BZOMbIsskenmu3h9RNuWNhonZP1BaTeEL2sHgqVZrpK8i6IsvJGnuNZ+xzl2Kd5KQGLjSGpyNPm0W5b5cVUp4wpNFw9mSn7jq3G0jsi8/aGx2775HS1lrlfhx6nY9p+wQ/xW2GX+uIyhSuVf89+Miqkbm8miIuwVc/drpyCUCfQ5IUOQ7CJ9s/w0y9y5+V+npY0DNJSBdpt+IhJo8LR/FgM9SObdEFE4a91AhxEYZVaBXhDTSOyfaa1ZJAPqRZ/Rfm38HAh9Za/WN1YIYSLvtT8a4wMauR2pHSSydijHTL4mpkrKjCu6n55oY+c5w+Ofsm6vTSQHZd2+xsg72sIg+ytE5UovbSO5Sj3RitYkUIjhWaoEm8sNqOxPUzoQSasJXju/CwdHopoO3P8E6qzWNGJDmuuynIxWWA9pFLke74WkUvERccFxBzY5hQe4zqAhI43FaZqVCAsIcbKd/N361wVFB6+HgdwX1kssxK1mON8Jlw3uXEeM1wREDBdFkVjWs5ty7Jt9Fl10RwUIT+NVjhQIzbDZWT/iF45+rsZkJ3GKzGWVDI0H80DUBx05elB7BZR8YbL9J5jBuS3gS+DauUSeFpBaAq9XZhlz7K1OSIF9L2kGEfy2HCzBqxDUAoHoZokVBmsYQJVXKJv8UwyfG4vg4G6MLT9Yxqsbkx8yXaCMWgOciy/jfZZbAhDbaY0HjxtsbbGnfpZp4iPkH6Xe4pFleiUilMlCs0GMzqrWBebMXcLgpG+QvZVfca/MUAsb/yeOOox68w802HBrf4VSH3A1j9Z3I7H7pW4T/ZeEu3M6NTrY6mg== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(136003)(346002)(376002)(396003)(39860400002)(46966006)(36840700001)(52536014)(7696005)(336012)(9686003)(8936002)(54906003)(107886003)(82740400003)(186003)(966005)(26005)(33656002)(86362001)(55016002)(6506007)(5660300002)(478600001)(53546011)(8676002)(2906002)(47076005)(356005)(70206006)(70586007)(82310400003)(36860700001)(316002)(83380400001)(81166007)(110136005)(4326008);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Sep 2021 07:34:18.3466 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c9698f87-b599-4132-5fc8-08d9729b1154 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT012.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB7314 SGkgSnVsaWVuLCBTdGVmYW5vLCBKYW4NCg0KPiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0K PiBGcm9tOiBYZW4tZGV2ZWwgPHhlbi1kZXZlbC1ib3VuY2VzQGxpc3RzLnhlbnByb2plY3Qub3Jn PiBPbiBCZWhhbGYgT2YgV2VpDQo+IENoZW4NCj4gU2VudDogMjAyMeW5tDjmnIgyOOaXpSAyMTo1 OA0KPiBUbzogSnVsaWVuIEdyYWxsIDxqdWxpZW5AeGVuLm9yZz47IFN0ZWZhbm8gU3RhYmVsbGlu aQ0KPiA8c3N0YWJlbGxpbmlAa2VybmVsLm9yZz4NCj4gQ2M6IHhlbi1kZXZlbEBsaXN0cy54ZW5w cm9qZWN0Lm9yZzsgQmVydHJhbmQgTWFycXVpcw0KPiA8QmVydHJhbmQuTWFycXVpc0Bhcm0uY29t PjsgSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPg0KPiBTdWJqZWN0OiBSRTogW1hFTiBS RkMgUEFUQ0ggMjMvNDBdIHhlbi9hcm06IGludHJvZHVjZSBhIGhlbHBlciB0byBwYXJzZQ0KPiBk ZXZpY2UgdHJlZSBtZW1vcnkgbm9kZQ0KPiANCj4gSGkgSnVsaWVuLA0KPiANCj4gPiAtLS0tLU9y aWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiA+IEZyb206IEp1bGllbiBHcmFsbCA8anVsaWVuQHhlbi5v cmc+DQo+ID4gU2VudDogMjAyMeW5tDjmnIgyOOaXpSAxODozNA0KPiA+IFRvOiBXZWkgQ2hlbiA8 V2VpLkNoZW5AYXJtLmNvbT47IFN0ZWZhbm8gU3RhYmVsbGluaQ0KPiA+IDxzc3RhYmVsbGluaUBr ZXJuZWwub3JnPg0KPiA+IENjOiB4ZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmc7IEJlcnRy YW5kIE1hcnF1aXMNCj4gPiA8QmVydHJhbmQuTWFycXVpc0Bhcm0uY29tPjsgSmFuIEJldWxpY2gg PGpiZXVsaWNoQHN1c2UuY29tPg0KPiA+IFN1YmplY3Q6IFJlOiBbWEVOIFJGQyBQQVRDSCAyMy80 MF0geGVuL2FybTogaW50cm9kdWNlIGEgaGVscGVyIHRvIHBhcnNlDQo+ID4gZGV2aWNlIHRyZWUg bWVtb3J5IG5vZGUNCj4gPg0KPiA+IEhpIFdlaSwNCj4gPg0KPiA+IE9uIDI4LzA4LzIwMjEgMDQ6 NTYsIFdlaSBDaGVuIHdyb3RlOg0KPiA+ID4+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+ ID4gPj4gRnJvbTogU3RlZmFubyBTdGFiZWxsaW5pIDxzc3RhYmVsbGluaUBrZXJuZWwub3JnPg0K PiA+ID4+IFNlbnQ6IDIwMjHvv73vv70477+977+9Mjjvv73vv70gOTowNg0KPiA+ID4+IFRvOiBX ZWkgQ2hlbiA8V2VpLkNoZW5AYXJtLmNvbT4NCj4gPiA+PiBDYzogeGVuLWRldmVsQGxpc3RzLnhl bnByb2plY3Qub3JnOyBzc3RhYmVsbGluaUBrZXJuZWwub3JnOw0KPiA+IGp1bGllbkB4ZW4ub3Jn Ow0KPiA+ID4+IGpiZXVsaWNoQHN1c2UuY29tOyBCZXJ0cmFuZCBNYXJxdWlzIDxCZXJ0cmFuZC5N YXJxdWlzQGFybS5jb20+DQo+ID4gPj4gU3ViamVjdDogUmU6IFtYRU4gUkZDIFBBVENIIDIzLzQw XSB4ZW4vYXJtOiBpbnRyb2R1Y2UgYSBoZWxwZXIgdG8NCj4gcGFyc2UNCj4gPiA+PiBkZXZpY2Ug dHJlZSBtZW1vcnkgbm9kZQ0KPiA+ID4+DQo+ID4gPj4gT24gV2VkLCAxMSBBdWcgMjAyMSwgV2Vp IENoZW4gd3JvdGU6DQo+ID4gPj4+IE1lbW9yeSBibG9ja3MnIE5VTUEgSUQgaW5mb3JtYXRpb24g aXMgc3RvcmVkIGluIGRldmljZSB0cmVlJ3MNCj4gPiA+Pj4gbWVtb3J5IG5vZGVzIGFzICJudW1h LW5vZGUtaWQiLiBXZSBuZWVkIGEgbmV3IGhlbHBlciB0byBwYXJzZQ0KPiA+ID4+PiBhbmQgdmVy aWZ5IHRoaXMgSUQgZnJvbSBtZW1vcnkgbm9kZXMuDQo+ID4gPj4+DQo+ID4gPj4+IEluIG9yZGVy IHRvIHN1cHBvcnQgbWVtb3J5IGFmZmluaXR5IGluIGxhdGVyIHVzZSwgdGhlIHZhbGlkDQo+ID4g Pj4+IG1lbW9yeSByYW5nZXMgYW5kIE5VTUEgSUQgd2lsbCBiZSBzYXZlZCB0byB0YWJsZXMuDQo+ ID4gPj4+DQo+ID4gPj4+IFNpZ25lZC1vZmYtYnk6IFdlaSBDaGVuIDx3ZWkuY2hlbkBhcm0uY29t Pg0KPiA+ID4+PiAtLS0NCj4gPiA+Pj4gICB4ZW4vYXJjaC9hcm0vbnVtYV9kZXZpY2VfdHJlZS5j IHwgMTMwDQo+ID4gKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysNCj4gPiA+Pj4gICAx IGZpbGUgY2hhbmdlZCwgMTMwIGluc2VydGlvbnMoKykNCj4gPiA+Pj4NCj4gPiA+Pj4gZGlmZiAt LWdpdCBhL3hlbi9hcmNoL2FybS9udW1hX2RldmljZV90cmVlLmMNCj4gPiA+PiBiL3hlbi9hcmNo L2FybS9udW1hX2RldmljZV90cmVlLmMNCj4gPiA+Pj4gaW5kZXggMzdjYzU2YWNmMy4uYmJlMDgx ZGNkMSAxMDA2NDQNCj4gPiA+Pj4gLS0tIGEveGVuL2FyY2gvYXJtL251bWFfZGV2aWNlX3RyZWUu Yw0KPiA+ID4+PiArKysgYi94ZW4vYXJjaC9hcm0vbnVtYV9kZXZpY2VfdHJlZS5jDQo+ID4gPj4+ IEBAIC0yMCwxMSArMjAsMTMgQEANCj4gPiA+Pj4gICAjaW5jbHVkZSA8eGVuL2luaXQuaD4NCj4g PiA+Pj4gICAjaW5jbHVkZSA8eGVuL25vZGVtYXNrLmg+DQo+ID4gPj4+ICAgI2luY2x1ZGUgPHhl bi9udW1hLmg+DQo+ID4gPj4+ICsjaW5jbHVkZSA8eGVuL2xpYmZkdC9saWJmZHQuaD4NCj4gPiA+ Pj4gICAjaW5jbHVkZSA8eGVuL2RldmljZV90cmVlLmg+DQo+ID4gPj4+ICAgI2luY2x1ZGUgPGFz bS9zZXR1cC5oPg0KPiA+ID4+Pg0KPiA+ID4+PiAgIHM4IGRldmljZV90cmVlX251bWEgPSAwOw0K PiA+ID4+PiAgIHN0YXRpYyBub2RlbWFza190IHByb2Nlc3Nvcl9ub2Rlc19wYXJzZWQgX19pbml0 ZGF0YTsNCj4gPiA+Pj4gK3N0YXRpYyBub2RlbWFza190IG1lbW9yeV9ub2Rlc19wYXJzZWQgX19p bml0ZGF0YTsNCj4gPiA+Pj4NCj4gPiA+Pj4gICBzdGF0aWMgaW50IHNyYXRfZGlzYWJsZWQodm9p ZCkNCj4gPiA+Pj4gICB7DQo+ID4gPj4+IEBAIC01NSw2ICs1Nyw3OSBAQCBzdGF0aWMgaW50IF9f aW5pdA0KPiA+ID4+IGR0Yl9udW1hX3Byb2Nlc3Nvcl9hZmZpbml0eV9pbml0KG5vZGVpZF90IG5v ZGUpDQo+ID4gPj4+ICAgICAgIHJldHVybiAwOw0KPiA+ID4+PiAgIH0NCj4gPiA+Pj4NCj4gPiA+ Pj4gKy8qIENhbGxiYWNrIGZvciBwYXJzaW5nIG9mIHRoZSBtZW1vcnkgcmVnaW9ucyBhZmZpbml0 eSAqLw0KPiA+ID4+PiArc3RhdGljIGludCBfX2luaXQgZHRiX251bWFfbWVtb3J5X2FmZmluaXR5 X2luaXQobm9kZWlkX3Qgbm9kZSwNCj4gPiA+Pj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgcGFkZHJfdCBzdGFydCwgcGFkZHJfdCBzaXplKQ0KPiA+ID4+PiArew0KPiA+ID4+PiAr ICAgIHN0cnVjdCBub2RlICpuZDsNCj4gPiA+Pj4gKyAgICBwYWRkcl90IGVuZDsNCj4gPiA+Pj4g KyAgICBpbnQgaTsNCj4gPiA+Pj4gKw0KPiA+ID4+PiArICAgIGlmICggc3JhdF9kaXNhYmxlZCgp ICkNCj4gPiA+Pj4gKyAgICAgICAgcmV0dXJuIC1FSU5WQUw7DQo+ID4gPj4+ICsNCj4gPiA+Pj4g KyAgICBlbmQgPSBzdGFydCArIHNpemU7DQo+ID4gPj4+ICsgICAgaWYgKCBudW1fbm9kZV9tZW1i bGtzID49IE5SX05PREVfTUVNQkxLUyApDQo+ID4gPj4+ICsgICAgew0KPiA+ID4+PiArICAgICAg ICBkcHJpbnRrKFhFTkxPR19XQVJOSU5HLA0KPiA+ID4+PiArICAgICAgICAgICAgICAgICJUb28g bWFueSBudW1hIGVudHJ5LCB0cnkgYmlnZ2VyIE5SX05PREVfTUVNQkxLUw0KPiBcbiIpOw0KPiA+ ID4+PiArICAgICAgICBiYWRfc3JhdCgpOw0KPiA+ID4+PiArICAgICAgICByZXR1cm4gLUVJTlZB TDsNCj4gPiA+Pj4gKyAgICB9DQo+ID4gPj4+ICsNCj4gPiA+Pj4gKyAgICAvKiBJdCBpcyBmaW5l IHRvIGFkZCB0aGlzIGFyZWEgdG8gdGhlIG5vZGVzIGRhdGEgaXQgd2lsbCBiZQ0KPiB1c2VkDQo+ ID4gPj4gbGF0ZXIgKi8NCj4gPiA+Pj4gKyAgICBpID0gY29uZmxpY3RpbmdfbWVtYmxrcyhzdGFy dCwgZW5kKTsNCj4gPiA+Pj4gKyAgICAvKiBObyBjb25mbGljdGluZyBtZW1vcnkgYmxvY2ssIHdl IGNhbiBzYXZlIGl0IGZvciBsYXRlciB1c2FnZQ0KPiAqLzsNCj4gPiA+Pj4gKyAgICBpZiAoIGkg PCAwICkNCj4gPiA+Pj4gKyAgICAgICAgZ290byBzYXZlX21lbWJsazsNCj4gPiA+Pj4gKw0KPiA+ ID4+PiArICAgIGlmICggbWVtYmxrX25vZGVpZFtpXSA9PSBub2RlICkgew0KPiA+ID4+PiArICAg ICAgICAvKg0KPiA+ID4+PiArICAgICAgICAgKiBPdmVybGFwcyB3aXRoIG90aGVyIG1lbWJsayBp biB0aGUgc2FtZSBub2RlLCB3YXJuaW5nDQo+IGhlcmUuDQo+ID4gPj4+ICsgICAgICAgICAqIFRo aXMgbWVtYmxrIHdpbGwgYmUgbWVyZ2VkIHdpdGggY29uZmxpY3RlZCBtZW1ibGsgbGF0ZXIuDQo+ ID4gPj4+ICsgICAgICAgICAqLw0KPiA+ID4+PiArICAgICAgICBwcmludGsoWEVOTE9HX1dBUk5J TkcNCj4gPiA+Pj4gKyAgICAgICAgICAgICAgICJEVDogTlVNQSBOT0RFICV1ICglIlBSSXg2NA0K PiA+ID4+PiArICAgICAgICAgICAgICAgIi0lIlBSSXg2NCIpIG92ZXJsYXBzIHdpdGggaXRzZWxm ICglIlBSSXg2NCItDQo+ID4gPj4gJSJQUkl4NjQiKVxuIiwNCj4gPiA+Pj4gKyAgICAgICAgICAg ICAgIG5vZGUsIHN0YXJ0LCBlbmQsDQo+ID4gPj4+ICsgICAgICAgICAgICAgICBub2RlX21lbWJs a19yYW5nZVtpXS5zdGFydCwNCj4gbm9kZV9tZW1ibGtfcmFuZ2VbaV0uZW5kKTsNCj4gPiA+Pj4g KyAgICB9IGVsc2Ugew0KPiA+ID4+PiArICAgICAgICAvKg0KPiA+ID4+PiArICAgICAgICAgKiBD b25mbGljdCB3aXRoIG1lbWJsayBpbiBvdGhlciBub2RlLCB0aGlzIGlzIGFuIGVycm9yLg0KPiA+ ID4+PiArICAgICAgICAgKiBUaGUgTlVNQSBpbmZvcm1hdGlvbiBpcyBpbnZhbGlkLCBOVU1BIHdp bGwgYmUgdHVybiBvZmYuDQo+ID4gPj4+ICsgICAgICAgICAqLw0KPiA+ID4+PiArICAgICAgICBw cmludGsoWEVOTE9HX0VSUg0KPiA+ID4+PiArICAgICAgICAgICAgICAgIkRUOiBOVU1BIE5PREUg JXUgKCUiUFJJeDY0Ii0lIg0KPiA+ID4+PiArICAgICAgICAgICAgICAgUFJJeDY0Iikgb3Zlcmxh cHMgd2l0aCBOT0RFICV1ICglIlBSSXg2NCItDQo+ID4gJSJQUkl4NjQiKVxuIiwNCj4gPiA+Pj4g KyAgICAgICAgICAgICAgIG5vZGUsIHN0YXJ0LCBlbmQsIG1lbWJsa19ub2RlaWRbaV0sDQo+ID4g Pj4+ICsgICAgICAgICAgICAgICBub2RlX21lbWJsa19yYW5nZVtpXS5zdGFydCwNCj4gbm9kZV9t ZW1ibGtfcmFuZ2VbaV0uZW5kKTsNCj4gPiA+Pj4gKyAgICAgICAgYmFkX3NyYXQoKTsNCj4gPiA+ Pj4gKyAgICAgICAgcmV0dXJuIC1FSU5WQUw7DQo+ID4gPj4+ICsgICAgfQ0KPiA+ID4+PiArDQo+ ID4gPj4+ICtzYXZlX21lbWJsazoNCj4gPiA+Pj4gKyAgICBuZCA9ICZub2Rlc1tub2RlXTsNCj4g PiA+Pj4gKyAgICBpZiAoICFub2RlX3Rlc3RfYW5kX3NldChub2RlLCBtZW1vcnlfbm9kZXNfcGFy c2VkKSApIHsNCj4gPiA+Pj4gKyAgICAgICAgbmQtPnN0YXJ0ID0gc3RhcnQ7DQo+ID4gPj4+ICsg ICAgICAgIG5kLT5lbmQgPSBlbmQ7DQo+ID4gPj4+ICsgICAgfSBlbHNlIHsNCj4gPiA+Pj4gKyAg ICAgICAgaWYgKCBzdGFydCA8IG5kLT5zdGFydCApDQo+ID4gPj4+ICsgICAgICAgICAgICBuZC0+ c3RhcnQgPSBzdGFydDsNCj4gPiA+Pj4gKyAgICAgICAgaWYgKCBuZC0+ZW5kIDwgZW5kICkNCj4g PiA+Pj4gKyAgICAgICAgICAgIG5kLT5lbmQgPSBlbmQ7DQo+ID4gPj4+ICsgICAgfQ0KPiA+ID4+ PiArDQo+ID4gPj4+ICsgICAgcHJpbnRrKFhFTkxPR19JTkZPICJEVDogTlVNQSBub2RlICV1ICUi UFJJeDY0Ii0lIlBSSXg2NCJcbiIsDQo+ID4gPj4+ICsgICAgICAgICAgIG5vZGUsIHN0YXJ0LCBl bmQpOw0KPiA+ID4+PiArDQo+ID4gPj4+ICsgICAgbm9kZV9tZW1ibGtfcmFuZ2VbbnVtX25vZGVf bWVtYmxrc10uc3RhcnQgPSBzdGFydDsNCj4gPiA+Pj4gKyAgICBub2RlX21lbWJsa19yYW5nZVtu dW1fbm9kZV9tZW1ibGtzXS5lbmQgPSBlbmQ7DQo+ID4gPj4+ICsgICAgbWVtYmxrX25vZGVpZFtu dW1fbm9kZV9tZW1ibGtzXSA9IG5vZGU7DQo+ID4gPj4+ICsgICAgbnVtX25vZGVfbWVtYmxrcysr Ow0KPiA+ID4+DQo+ID4gPj4NCj4gPiA+PiBJcyBpdCBwb3NzaWJsZSB0byBoYXZlIG5vbi1jb250 aWdvdXMgcmFuZ2VzIG9mIG1lbW9yeSBmb3IgYSBzaW5nbGUNCj4gTlVNQQ0KPiA+ID4+IG5vZGU/ DQo+ID4gPj4NCj4gPiA+PiBMb29raW5nIGF0IHRoZSBEVCBiaW5kaW5ncyBhbmQgTGludXggaW1w bGVtZW50YXRpb24sIGl0IHNlZW1zDQo+IHBvc3NpYmxlLg0KPiA+ID4+IEhlcmUsIGl0IHNlZW1z IHRoYXQgbm9kZV9tZW1ibGtfcmFuZ2UvbWVtYmxrX25vZGVpZCBjb3VsZCBoYW5kbGUgaXQsDQo+ ID4gPj4gYnV0IG5vZGVzIGNvdWxkbid0Lg0KPiA+ID4NCj4gPiA+IFllcywgeW91J3JlIHJpZ2h0 LiBJIGNvcGllZCB0aGlzIGNvZGUgZm9yIHg4NiBBQ1BJIE5VTUEuIERvZXMgQUNQSQ0KPiBhbGxv dw0KPiA+ID4gbm9uLWNvbnRpZ3VvdXMgcmFuZ2VzIG9mIG1lbW9yeSBmb3IgYSBzaW5nbGUgTlVN QSBub2RlIHRvbz8NCj4gPg0KPiA+IEkgY291bGRuJ3QgZmluZCBhbnkgcmVzdHJpY3Rpb24gZm9y IEFDUEkuIEFsdGhvdWdoLCBJIG9ubHkgYnJpZWZseQ0KPiA+IGxvb2tlZCBhdCB0aGUgc3BlYy4N Cj4gPg0KPiA+ID4gSWYgeWVzLCBJIHRoaW5rDQo+ID4gPiB0aGlzIHdpbGwgYWZmZWN0IHg4NiBB Q1BJIE5VTUEgdG9vLiBJbiBuZXh0IHZlcnNpb24sIHdlIHBsYW4gdG8gbWVyZ2UNCj4gPiA+IGR0 Yl9udW1hX21lbW9yeV9hZmZpbml0eV9pbml0IGFuZCBhY3BpX251bWFfbWVtb3J5X2FmZmluaXR5 X2luaXQgaW50bw0KPiBhDQo+ID4gPiBuZXV0cmFsIGZ1bmN0aW9uLiBTbyB3ZSBjYW4gZml4IHRo ZW0gYXQgdGhlIHNhbWUgdGltZS4NCj4gPiA+DQo+ID4gPiBJZiBub3QsIG1heWJlIHdlIGhhdmUg dG8ga2VlcCB0aGUgZGl2ZXJzaXR5IGZvciBkdGIgYW5kIEFDUEkgaGVyZS4NCj4gPg0KPiA+IEkg YW0gbm90IGVudGlyZWx5IHN1cmUgd2hhdCB5b3UgbWVhbi4gQXJlIHlvdSBzYXlpbmcgaWYgQUNQ SSBkb2Vzbid0DQo+ID4gYWxsb3cgbm9uLWNvbnRpZ3VvdXMgcmFuZ2VzIG9mIG1lbW9yeSwgdGhl biB3ZSBzaG91bGQga2VlcCB0aGUNCj4gPiBpbXBsZW1lbnRhdGlvbiBzZXBhcmF0ZWQ/DQo+ID4N Cj4gPiBJZiBzbywgdGhlbiBJIGRpc2FncmVlIHdpdGggdGhhdC4gSXQgaXMgZmluZSB0byBoYXZl IGNvZGUgdGhhdCBzdXBwb3J0cw0KPiA+IG1vcmUgdGhhbiB3aGF0IGEgZmlybXdhcmUgdGFibGUg c3VwcG9ydHMuIFRoZSBtYWluIGJlbmVmaXQgaXMgbGVzcyBjb2RlDQo+ID4gYW5kIHRoZXJlZm9y ZSBsZXNzIGxvbmcgdGVybSBtYWludGVuYW5jZSAod2l0aCB0aGUgY3VycmVudCBzb2x1dGlvbiB3 ZQ0KPiA+IHdvdWxkIG5lZWQgdG8gY2hlY2sgYm90aCB0aGUgQUNQSSBhbmQgRFQgaW1wbGVtZW50 YXRpb24gaWYgdGhlcmUgaXMgYQ0KPiA+IGJ1ZyBpbiBvbmUpLg0KPiA+DQo+IA0KPiBZZXMsIEkg YWdyZWUuDQo+IA0KDQpJIGFtIGxvb2tpbmcgZm9yIHNvbWUgbWV0aG9kcyB0byBhZGRyZXNzIHRo aXMgY29tbWVudC4gQ3VycmVudCAibm9kZXMiDQpoYXMgbm90IGNvbnNpZGVyZWQgdGhlIHNpdHVh dGlvbiBvZiBtZW1vcnkgYWRkcmVzc2VzIG9mIGRpZmZlcmVudCBOVU1BDQpub2RlcyBjYW4gYmUg aW50ZXJsZWF2ZWQuDQoNClRoaXMgY29kZSBleGlzdHMgaW4geDg2IE5VTUEgaW1wbGVtZW50YXRp b24uIEkgdGhpbmsgaXQgbWF5IGJlIGJhc2VkIG9uDQpvbmUgZWFybHkgdmVyc2lvbiBvZiBMaW51 eCB4ODYgTlVNQSBpbXBsZW1lbnRhdGlvbi4gSW4gcmVjZW50IExpbnV4DQpjb2RlLCBib3RoIEFD UEkvbnVtYS9zcmF0LmNbMV0gYW5kIHg4NiBOVU1BIGNvZGVbMl0gYXJlIG5vdCB1c2luZw0KIm5v ZGVzIiB0byByZWNvcmQgTlVNQSBtZW1vcnkgYWRkcmVzcyBib3VuZGFyeS4gVGhleSBkb24ndCBk ZXBlbmQNCm9uICJub2RlcyIgdG8gZG8gc2FuaXR5IGNoZWNrLg0KDQpUbyBmaXggaXQsIHdlJ2Qg YmV0dGVyIHRvIHVwZ3JhZGUgdGhlIHg4NiBOVU1BIGRyaXZlci4gSXQgd2lsbCBtYWtlDQphIGdy ZWF0IGFmZmVjdCBmb3IgWGVuLXg4Ni4gQW5kIEkgdGhpbmsgaXQgbWlnaHQgb3V0IG9mIHRoaXMg c2VyaWVzDQpzY29wZS4gQ2FuIHdlIGNyZWF0ZSBhbm90aGVyIHRocmVhZCB0byBkaXNjdXNzIGFi b3V0IGl0Pw0KDQpPciBjb3VsZCB5b3UgZ2l2ZSBtZSBzdWdnZXN0aW9ucyB0aGF0IHdlIGNhbiB1 c2Ugc29tZSBzaW1wbGUgd2F5cw0KdG8gZml4IGl0Pw0KDQpBbHNvLCBvbiBMaW51eCwgTlVNQSBp bXBsZW1lbnRhdGlvbnMgZm9yIHg4NiBhcmUgZGlmZmVyZW50IGZyb20gQXJtNjQNCmFuZCBSSVND LVYgaW1wbGVtZW50YXRpb25zLlszXQ0KDQpbMV0gaHR0cHM6Ly9naXRodWIuY29tL3RvcnZhbGRz L2xpbnV4L2Jsb2IvbWFzdGVyL2RyaXZlcnMvYWNwaS9udW1hL3NyYXQuYw0KWzJdIGh0dHBzOi8v Z2l0aHViLmNvbS90b3J2YWxkcy9saW51eC9ibG9iL21hc3Rlci9hcmNoL3g4Ni9tbS9udW1hLmMN ClszXSBodHRwczovL2dpdGh1Yi5jb20vdG9ydmFsZHMvbGludXgvYmxvYi9tYXN0ZXIvZHJpdmVy cy9iYXNlL2FyY2hfbnVtYS5jDQoNCj4gPiBDaGVlcnMsDQo+ID4NCj4gPiAtLQ0KPiA+IEp1bGll biBHcmFsbA0K From xen-devel-bounces@lists.xenproject.org Wed Sep 08 07:36:47 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Sep 2021 07:36:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.181551.328710 (Exim 4.92) (envelope-from ) id 1mNs8V-0005ZL-4Q; Wed, 08 Sep 2021 07:36:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 181551.328710; Wed, 08 Sep 2021 07:36:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNs8V-0005ZE-1G; Wed, 08 Sep 2021 07:36:47 +0000 Received: by outflank-mailman (input) for mailman id 181551; Wed, 08 Sep 2021 07:36:45 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNs8T-0005Z4-Ms for xen-devel@lists.xenproject.org; Wed, 08 Sep 2021 07:36:45 +0000 Received: from smtp-out2.suse.de (unknown [195.135.220.29]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 5f760927-54e6-4e74-bf2a-f9169fa9ec97; Wed, 08 Sep 2021 07:36:44 +0000 (UTC) Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 2C5C420002; Wed, 8 Sep 2021 07:36:43 +0000 (UTC) Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap1.suse-dmz.suse.de (Postfix) with ESMTPS id C194613721; Wed, 8 Sep 2021 07:36:42 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap1.suse-dmz.suse.de with ESMTPSA id OfMuLQpoOGElRgAAGKfGzw (envelope-from ); Wed, 08 Sep 2021 07:36:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5f760927-54e6-4e74-bf2a-f9169fa9ec97 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1631086603; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=Z+WndBSU3C8fZ88DpLGMyx1R2eYI/u6zm2djOHlAuhI=; b=Gxv+cR175RWwcar+tgco/LV9K7gZvM79EFqyhBr+f3UXoCEbLE/QUAkRS6fNiZ7lBQkSJu zF92+gHGNw1F6qIchk8eh/7NlH3reksuw4VWG2W/5DQu0IkjV76wlvPNl12TKkDJUr4LqG HjIAEFm6aGO7BCxqzOKpy69FZalwFK8= From: Juergen Gross To: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org Cc: Juergen Gross , Boris Ostrovsky , Stefano Stabellini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , stable@vger.kernel.org, Sander Eikelenboom Subject: [PATCH] xen: fix usage of pmd/pud_poplulate in mremap for pv guests Date: Wed, 8 Sep 2021 09:36:40 +0200 Message-Id: <20210908073640.11299-1-jgross@suse.com> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Commit 0881ace292b662 ("mm/mremap: use pmd/pud_poplulate to update page table entries") introduced a regression when running as Xen PV guest. Today pmd/pud_poplulate() for Xen PV assumes that the PFN inserted is referencing a not yet used page table. In case of move_normal_pmd/pud() this is not true, resulting in WARN splats like: [34321.304270] ------------[ cut here ]------------ [34321.304277] WARNING: CPU: 0 PID: 23628 at arch/x86/xen/multicalls.c:102 xen_mc_flush+0x176/0x1a0 [34321.304288] Modules linked in: [34321.304291] CPU: 0 PID: 23628 Comm: apt-get Not tainted 5.14.1-20210906-doflr-mac80211debug+ #1 [34321.304294] Hardware name: MSI MS-7640/890FXA-GD70 (MS-7640) , BIOS V1.8B1 09/13/2010 [34321.304296] RIP: e030:xen_mc_flush+0x176/0x1a0 [34321.304300] Code: 89 45 18 48 c1 e9 3f 48 89 ce e9 20 ff ff ff e8 60 03 00 00 66 90 5b 5d 41 5c 41 5d c3 48 c7 45 18 ea ff ff ff be 01 00 00 00 <0f> 0b 8b 55 00 48 c7 c7 10 97 aa 82 31 db 49 c7 c5 38 97 aa 82 65 [34321.304303] RSP: e02b:ffffc90000a97c90 EFLAGS: 00010002 [34321.304305] RAX: ffff88807d416398 RBX: ffff88807d416350 RCX: ffff88807d416398 [34321.304306] RDX: 0000000000000001 RSI: 0000000000000001 RDI: deadbeefdeadf00d [34321.304308] RBP: ffff88807d416300 R08: aaaaaaaaaaaaaaaa R09: ffff888006160cc0 [34321.304309] R10: deadbeefdeadf00d R11: ffffea000026a600 R12: 0000000000000000 [34321.304310] R13: ffff888012f6b000 R14: 0000000012f6b000 R15: 0000000000000001 [34321.304320] FS: 00007f5071177800(0000) GS:ffff88807d400000(0000) knlGS:0000000000000000 [34321.304322] CS: 10000e030 DS: 0000 ES: 0000 CR0: 0000000080050033 [34321.304323] CR2: 00007f506f542000 CR3: 00000000160cc000 CR4: 0000000000000660 [34321.304326] Call Trace: [34321.304331] xen_alloc_pte+0x294/0x320 [34321.304334] move_pgt_entry+0x165/0x4b0 [34321.304339] move_page_tables+0x6fa/0x8d0 [34321.304342] move_vma.isra.44+0x138/0x500 [34321.304345] __x64_sys_mremap+0x296/0x410 [34321.304348] do_syscall_64+0x3a/0x80 [34321.304352] entry_SYSCALL_64_after_hwframe+0x44/0xae [34321.304355] RIP: 0033:0x7f507196301a [34321.304358] Code: 73 01 c3 48 8b 0d 76 0e 0c 00 f7 d8 64 89 01 48 83 c8 ff c3 66 2e 0f 1f 84 00 00 00 00 00 66 90 49 89 ca b8 19 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d 46 0e 0c 00 f7 d8 64 89 01 48 [34321.304360] RSP: 002b:00007ffda1eecd38 EFLAGS: 00000246 ORIG_RAX: 0000000000000019 [34321.304362] RAX: ffffffffffffffda RBX: 000056205f950f30 RCX: 00007f507196301a [34321.304363] RDX: 0000000001a00000 RSI: 0000000001900000 RDI: 00007f506dc56000 [34321.304364] RBP: 0000000001a00000 R08: 0000000000000010 R09: 0000000000000004 [34321.304365] R10: 0000000000000001 R11: 0000000000000246 R12: 00007f506dc56060 [34321.304367] R13: 00007f506dc56000 R14: 00007f506dc56060 R15: 000056205f950f30 [34321.304368] ---[ end trace a19885b78fe8f33e ]--- [34321.304370] 1 of 2 multicall(s) failed: cpu 0 [34321.304371] call 2: op=12297829382473034410 arg=[aaaaaaaaaaaaaaaa] result=-22 Fix that by modifying xen_alloc_ptpage() to only pin the page table in case it wasn't pinned already. Fixes: 0881ace292b662 ("mm/mremap: use pmd/pud_poplulate to update page table entries") Cc: Reported-by: Sander Eikelenboom Tested-by: Sander Eikelenboom Signed-off-by: Juergen Gross --- arch/x86/xen/mmu_pv.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/arch/x86/xen/mmu_pv.c b/arch/x86/xen/mmu_pv.c index 1df5f01529e5..8d751939c6f3 100644 --- a/arch/x86/xen/mmu_pv.c +++ b/arch/x86/xen/mmu_pv.c @@ -1518,14 +1518,17 @@ static inline void xen_alloc_ptpage(struct mm_struct *mm, unsigned long pfn, if (pinned) { struct page *page = pfn_to_page(pfn); - if (static_branch_likely(&xen_struct_pages_ready)) + pinned = false; + if (static_branch_likely(&xen_struct_pages_ready)) { + pinned = PagePinned(page); SetPagePinned(page); + } xen_mc_batch(); __set_pfn_prot(pfn, PAGE_KERNEL_RO); - if (level == PT_PTE && USE_SPLIT_PTE_PTLOCKS) + if (level == PT_PTE && USE_SPLIT_PTE_PTLOCKS && !pinned) __pin_pagetable_pfn(MMUEXT_PIN_L1_TABLE, pfn); xen_mc_issue(PARAVIRT_LAZY_MMU); -- 2.26.2 From xen-devel-bounces@lists.xenproject.org Wed Sep 08 08:01:55 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Sep 2021 08:01:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.181564.328721 (Exim 4.92) (envelope-from ) id 1mNsWg-0001Se-Ew; Wed, 08 Sep 2021 08:01:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 181564.328721; Wed, 08 Sep 2021 08:01:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNsWg-0001SX-Bq; Wed, 08 Sep 2021 08:01:46 +0000 Received: by outflank-mailman (input) for mailman id 181564; Wed, 08 Sep 2021 08:01:44 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNsWe-0001SR-DO for xen-devel@lists.xenproject.org; Wed, 08 Sep 2021 08:01:44 +0000 Received: from smtp-fw-9102.amazon.com (unknown [207.171.184.29]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 011f09b2-107b-11ec-b147-12813bfff9fa; Wed, 08 Sep 2021 08:01:43 +0000 (UTC) Received: from pdx4-co-svc-p1-lb2-vlan3.amazon.com (HELO email-inbound-relay-1a-e34f1ddc.us-east-1.amazon.com) ([10.25.36.214]) by smtp-border-fw-9102.sea19.amazon.com with ESMTP; 08 Sep 2021 08:01:36 +0000 Received: from EX13D37EUA002.ant.amazon.com (iad12-ws-svc-p26-lb9-vlan3.iad.amazon.com [10.40.163.38]) by email-inbound-relay-1a-e34f1ddc.us-east-1.amazon.com (Postfix) with ESMTPS id 14C1CA1A39; Wed, 8 Sep 2021 08:01:33 +0000 (UTC) Received: from EX13D24EUA001.ant.amazon.com (10.43.165.233) by EX13D37EUA002.ant.amazon.com (10.43.165.200) with Microsoft SMTP Server (TLS) id 15.0.1497.23; Wed, 8 Sep 2021 08:01:32 +0000 Received: from EX13D24EUA001.ant.amazon.com ([10.43.165.233]) by EX13D24EUA001.ant.amazon.com ([10.43.165.233]) with mapi id 15.00.1497.023; Wed, 8 Sep 2021 08:01:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" X-Inumbo-ID: 011f09b2-107b-11ec-b147-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.co.uk; i=@amazon.co.uk; q=dns/txt; s=amazon201209; t=1631088104; x=1662624104; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=NNiwhOsw2/lA3gYN93p8XpwsNp5oh1ZqFV8csTQzejw=; b=mu1DWzIvAsz7313KTLrdbLv4lb6nRAS4ffnSYp8E6Zkp4IsRzaxeoyKP mLbtIIVlQrjKnPf6LHER497CvSoIYVm4DrP5l1XyILeHFN42RJsgtMQwk Y1ntYdr5qLeyUmkuqZfh4iIId6PbMiPXsqy1zJoMjEN1PYojPfi5C08iK 4=; X-IronPort-AV: E=Sophos;i="5.85,277,1624320000"; d="scan'208";a="158343262" From: "Ahmed, Daniele" To: Dario Faggioli , "julien@xen.org" , "xen-devel@lists.xenproject.org" CC: "sstabellini@kernel.org" , "Pohlack, Martin" , "Grall, Julien" , "Doebel, Bjoern" Subject: Re: NULL scheduler DoS Thread-Topic: NULL scheduler DoS Thread-Index: AQHXpIe8OXmLgpZp00yyIO6D9XnksA== Date: Wed, 8 Sep 2021 08:01:32 +0000 Message-ID: <562980DD-ABAB-4082-A565-2E07F71292E5@amazon.com> References: <8193a685-3ab1-9407-75f3-e335ea4406e4@xen.org> <6b5e28f427ccd89505a4448f2b9e5be992a08292.camel@suse.com> In-Reply-To: <6b5e28f427ccd89505a4448f2b9e5be992a08292.camel@suse.com> Accept-Language: en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.43.166.178] Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 Precedence: Bulk SGksIHNvcnJ5IGZvciB0aGUgbGF0ZSByZXBseS4NCg0KSGVyZSBpcyB0aGUgZnVsbCBsb2cgZnJv bSB0aGUgc2VyaWFsIGNvbnNvbGU6IGh0dHBzOi8vcGFzdGViaW4uY29tL3Jhdy9nOUVGdGszeQ0K DQpUaGlzIHN0aWxsIGhhcHBlbnMgb24gdGhlIGN1cnJlbnQgdW5zdGFibGUgYXMgb2YgdG9kYXku DQoNClRoYW5rIHlvdQ0KRGFuaWVsZQ0KDQrvu79PbiAxMS8wOC8yMDIxLCAxMjowOSwgIkRhcmlv IEZhZ2dpb2xpIiA8ZGZhZ2dpb2xpQHN1c2UuY29tPiB3cm90ZToNCg0KICAgIE9uIE1vbiwgMjAy MS0wOC0wOSBhdCAyMTozOCArMDEwMCwgSnVsaWVuIEdyYWxsIHdyb3RlOg0KICAgID4gT24gMDkv MDgvMjAyMSAxODozNSwgSnVsaWVuIEdyYWxsIHdyb3RlOg0KICAgID4gPiANCiAgICA+ID4gVGhp cyBpbXBsaWVzIHRoYXQgYSBwQ1BVIG1heSB0ZW1wb3JhcmlseSBiZSBhc3NpZ25lZCB0byB0d28g dkNQVXMNCiAgICA+ID4gYW5kIHdlIA0KICAgID4gPiBleHBlY3QgdG8gYmUgZml4ZWQgdXAgYWZ0 ZXJ3YXJkcy4gSG93ZXZlciwgYSBkb21haW4gbWF5IGJlDQogICAgPiA+IGRlc3Ryb3llZCANCiAg ICA+ID4gYmVmb3JlIHRoaXMgaXMgaGFwcGVuaW5nLg0KICAgID4gPiANCiAgICA+ID4gU28gaXQg bG9va3MgbGlrZSB0aGF0IHVuaXRfZGVhc3NpZ24oKSBpcyBub3QgYWJsZSB0byBjb3BlIHdpdGgg dGhpcw0KICAgID4gPiBjYXNlLiBGcm9tIGEgYnJpZWYgbG9vaywgSSB0aGluayB3ZSBtYXkgd2Fu dCB0byBjaGVjayBpZiB0aGUgcENQVQ0KICAgID4gPiBpcyBpbiANCiAgICA+ID4gdGhlIHdhaXQg bGlzdC4gSWYgaXQgaXMsIHRoZW4gd2Ugc2hvdWxkIGJhaWwgb3V0Lg0KICAgID4gDQogICAgPiBB Y3R1YWxseSwgSSB3YXMgd3JvbmcuIEl0IGxvb2tzIGxpa2UgbnVsbF91bml0X3JlbW92ZSgpIGlz IGFscmVhZHkgDQogICAgPiBjaGVja2luZyB0aGlzIGNvbmRpdGlvbi4gQWxzbywgdGhlIHZDUFUg c2hvdWxkIGJlIG9mZmxpbmUgKGFuZCB0aGUNCiAgICA+IHVuaXQgDQogICAgPiBhcyB3ZWxsKSBi ZWNhdXNlIHRoZXkgaGF2ZW4ndCBjb21lIG9ubGluZSB5ZXQ6DQogICAgPiANCiAgICBUaGF0J3Mg d2hhdCBpcyBjdXJyZW50bHkgcHV6emxpbmcgbWUuDQoNCiAgICBJIG1lYW4sIHRoZSBjcmFzaCBo YXBwZW5zIGluIHVuaXRfZGVhc3NpZ24oKSwgY2FsbGVkIGJ5DQogICAgbnVsbF91bml0X3JlbW92 ZSgpLCBjYWxsZWQgYnkgc2NoZWRfZGVzdHJveV92Y3B1KCkuDQoNCiAgICBBbmQgSSBhZ3JlZSB0 aGF0IHRoZSB1bml0IHNob3VsZCBiZSBvZmZsaW5lLCBidXQgbnVsbF91bml0X3JlbW92ZSgpDQog ICAgY2FsbHMgdW5pdF9kZWFzc2lnbigpIG9ubHkgaWYgdGhlIHVuaXQgKmlzKiBvbmxpbmUsIHNv Li4uIFdoYXQncyBnb2luZw0KICAgIG9uPyA6LS8NCg0KICAgIFJlZ2FyZHMNCiAgICAtLSANCiAg ICBEYXJpbyBGYWdnaW9saSwgUGguRA0KICAgIGh0dHA6Ly9hYm91dC5tZS9kYXJpby5mYWdnaW9s aQ0KICAgIFZpcnR1YWxpemF0aW9uIFNvZnR3YXJlIEVuZ2luZWVyDQogICAgU1VTRSBMYWJzLCBT VVNFIGh0dHBzOi8vd3d3LnN1c2UuY29tLw0KICAgIC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0NCiAgICA8PFRoaXMgaGFw cGVucyBiZWNhdXNlIF9JXyBjaG9vc2UgaXQgdG8gaGFwcGVuIT4+IChSYWlzdGxpbiBNYWplcmUp DQoNCg== From xen-devel-bounces@lists.xenproject.org Wed Sep 08 08:20:10 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Sep 2021 08:20:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.181569.328731 (Exim 4.92) (envelope-from ) id 1mNsoL-0003IY-1b; Wed, 08 Sep 2021 08:20:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 181569.328731; Wed, 08 Sep 2021 08:20:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNsoK-0003IR-Ur; Wed, 08 Sep 2021 08:20:00 +0000 Received: by outflank-mailman (input) for mailman id 181569; Wed, 08 Sep 2021 08:19:59 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNsoJ-0003IL-N0 for xen-devel@lists.xenproject.org; Wed, 08 Sep 2021 08:19:59 +0000 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 16fe695d-0a62-4a99-9eaa-9aa78ffc0697; Wed, 08 Sep 2021 08:19:58 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 16fe695d-0a62-4a99-9eaa-9aa78ffc0697 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1631089198; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=EsMNMCKTezC7j6gNcKVFe/+UQsY5QrZ/q/UgvOYDVhU=; b=ZteyLYJUmPErJ/9eyWCp3Pyag95/+BAdB1WTSKma1pZZzbmqXp5TDeug ohCdBl2xAh6ZVi5b/PLoKGdHtYlOKYCWnuv+UEF9rlWayBfy3kwS7RfJV h3r4Q0xLakEhboSP35TeuduLYtujBBwarCTvRSn2uhtdH/AS5gi19trQU w=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: WkLE+G5BwbTYK+RdRMVIg/26UTHktzIcSXsqOe2TAMVOPeO7OuOEUSFZ9nhssQ5V1W0LLfqKcf g5g0mhBoHtPv0t7o4ZJ0vrZPSjdoZm/r2Q6Cfb/hH/9wAP+5jG95P4Bzv56qQHGZWVmeG6dSwt BmIA4A4qvuyBTg5Seysuwazfmw0vp9cKedHis1wQpmvme7S6+4NrgZcrSUlHpS/ttzDdRC75Mp uihwgdioZSmlh9dRWEDIGPwgc+wAflGAqKW2s+DvE7b//UHM53zBcZKeCQ4qn2vd0sS4Dl3wct /X+KJkSAR9hxvw3WxFZ506+o X-SBRS: 5.1 X-MesageID: 51829769 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:1J0Cu6wGeGnLjTrmK2RrKrPwFL1zdoMgy1knxilNoRw8SKKlfq eV7Y0mPH7P+VAssR4b+exoVJPtfZqYz+8R3WBzB8bEYOCFghrKEGgK1+KLqFeMJ8S9zJ846U 4JSdkHNDSaNzlHZKjBjzVQa+xQouW6zA== X-IronPort-AV: E=Sophos;i="5.85,277,1624334400"; d="scan'208";a="51829769" From: Jane Malalane To: Xen-devel CC: Jane Malalane , Wei Liu , "Jan Beulich" , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Pu Wen , Andy Lutomirski Subject: [PATCH v2 2/2] x86/cpuid: Detect null segment behaviour on Zen2 CPUs Date: Wed, 8 Sep 2021 09:19:45 +0100 Message-ID: <20210908081945.11047-1-jane.malalane@citrix.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Zen2 CPUs actually have this behaviour, but the CPUID bit couldn't be introduced into Zen2 due to a lack of leaves. So, it was added in a new leaf in Zen3. Nonetheless, hypervisors can synthesize the CPUID bit in software. So, Xen probes for NSCB (NullSelectorClearsBit) and synthesizes the bit, if the behaviour is present. Suggested-by: Andrew Cooper Signed-off-by: Jane Malalane --- CC: Wei Liu CC: Jan Beulich CC: Andrew Cooper CC: "Roger Pau Monné" CC: Pu Wen CC: Andy Lutomirski v2: * Mark detect_zen2_null_seg_behaviour() with __init * Remove model checks --- xen/arch/x86/cpu/amd.c | 18 ++++++++++++++++++ xen/arch/x86/cpu/cpu.h | 1 + xen/arch/x86/cpu/hygon.c | 5 +++++ xen/include/asm-x86/cpufeature.h | 1 + 4 files changed, 25 insertions(+) diff --git a/xen/arch/x86/cpu/amd.c b/xen/arch/x86/cpu/amd.c index 2260eef3aa..cb12861481 100644 --- a/xen/arch/x86/cpu/amd.c +++ b/xen/arch/x86/cpu/amd.c @@ -681,6 +681,19 @@ void amd_init_lfence(struct cpuinfo_x86 *c) c->x86_capability); } +void __init detect_zen2_null_seg_behaviour(void) +{ + uint64_t base; + + wrmsrl(MSR_FS_BASE, 1); + asm volatile ( "mov %0, %%fs" :: "rm" (0) ); + rdmsrl(MSR_FS_BASE, base); + + if (base == 0) + setup_force_cpu_cap(X86_FEATURE_NSCB); + +} + static void init_amd(struct cpuinfo_x86 *c) { u32 l, h; @@ -731,6 +744,11 @@ static void init_amd(struct cpuinfo_x86 *c) else /* Implicily "== 0x10 || >= 0x12" by being 64bit. */ amd_init_lfence(c); + /* Probe for NSCB on Zen2 CPUs when not virtualised */ + if (!cpu_has_hypervisor && !cpu_has_nscb && c == &boot_cpu_data && + c->x86 == 0x17) + detect_zen2_null_seg_behaviour(); + /* * If the user has explicitly chosen to disable Memory Disambiguation * to mitigiate Speculative Store Bypass, poke the appropriate MSR. diff --git a/xen/arch/x86/cpu/cpu.h b/xen/arch/x86/cpu/cpu.h index 1ac3b2867a..0dd1b762ff 100644 --- a/xen/arch/x86/cpu/cpu.h +++ b/xen/arch/x86/cpu/cpu.h @@ -21,3 +21,4 @@ extern bool detect_extended_topology(struct cpuinfo_x86 *c); void early_init_amd(struct cpuinfo_x86 *c); void amd_log_freq(const struct cpuinfo_x86 *c); void amd_init_lfence(struct cpuinfo_x86 *c); +void detect_zen2_null_seg_behaviour(void); diff --git a/xen/arch/x86/cpu/hygon.c b/xen/arch/x86/cpu/hygon.c index 67e23c5df9..d7a04af2bb 100644 --- a/xen/arch/x86/cpu/hygon.c +++ b/xen/arch/x86/cpu/hygon.c @@ -34,6 +34,11 @@ static void init_hygon(struct cpuinfo_x86 *c) amd_init_lfence(c); + /* Probe for NSCB on Zen2 CPUs when not virtualised */ + if (!cpu_has_hypervisor && !cpu_has_nscb && c == &boot_cpu_data && + c->x86 == 0x18) + detect_zen2_null_seg_behaviour(); + /* * If the user has explicitly chosen to disable Memory Disambiguation * to mitigiate Speculative Store Bypass, poke the appropriate MSR. diff --git a/xen/include/asm-x86/cpufeature.h b/xen/include/asm-x86/cpufeature.h index 5f6b83f71c..4faf9bff29 100644 --- a/xen/include/asm-x86/cpufeature.h +++ b/xen/include/asm-x86/cpufeature.h @@ -146,6 +146,7 @@ #define cpu_has_cpuid_faulting boot_cpu_has(X86_FEATURE_CPUID_FAULTING) #define cpu_has_aperfmperf boot_cpu_has(X86_FEATURE_APERFMPERF) #define cpu_has_lfence_dispatch boot_cpu_has(X86_FEATURE_LFENCE_DISPATCH) +#define cpu_has_nscb boot_cpu_has(X86_FEATURE_NSCB) #define cpu_has_xen_lbr boot_cpu_has(X86_FEATURE_XEN_LBR) #define cpu_has_xen_shstk boot_cpu_has(X86_FEATURE_XEN_SHSTK) -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Wed Sep 08 09:17:11 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Sep 2021 09:17:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.181575.328743 (Exim 4.92) (envelope-from ) id 1mNthS-0001jY-GG; Wed, 08 Sep 2021 09:16:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 181575.328743; Wed, 08 Sep 2021 09:16:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNthS-0001jR-CE; Wed, 08 Sep 2021 09:16:58 +0000 Received: by outflank-mailman (input) for mailman id 181575; Wed, 08 Sep 2021 09:16:57 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNthR-0001jL-76 for xen-devel@lists.xenproject.org; Wed, 08 Sep 2021 09:16:57 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 764b3c30-6b44-47e3-94a6-5f12b8efb4e7; Wed, 08 Sep 2021 09:16:54 +0000 (UTC) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04lp2055.outbound.protection.outlook.com [104.47.14.55]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-19-wJcEkFcVP1ebfVIA_sWHvw-2; Wed, 08 Sep 2021 11:16:53 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VE1PR04MB6383.eurprd04.prod.outlook.com (2603:10a6:803:11b::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14; Wed, 8 Sep 2021 09:16:50 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4500.014; Wed, 8 Sep 2021 09:16:50 +0000 Received: from [10.156.60.236] (37.24.206.209) by PR3P193CA0035.EURP193.PROD.OUTLOOK.COM (2603:10a6:102:51::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14 via Frontend Transport; Wed, 8 Sep 2021 09:16:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 764b3c30-6b44-47e3-94a6-5f12b8efb4e7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1631092613; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5o3MjP4Xyup2z4+VruHsu4pa+Ez3/ZYNop7+qUPcPWU=; b=YR7GJ6xA45Dl+RPi0d5ZvAJoLG8SizbcE0G15r7QMeKdvv7Y0P42s0A7jNDBrrpnrZUSzR RB3YIAhpG9ZddfLFmVKg7s/FyxLHvUvOfyZfpAmHL92Yj54kyVPi862R9CaZoGQzv0EiQ/ KKjzDL6ZUSjYq60AZsyLDJRdt1dF8hY= X-MC-Unique: wJcEkFcVP1ebfVIA_sWHvw-2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iENznPPznq4lOx7kKxSZ0R6DH6baKoSPmiBe14QQaJiQmCetzQTroOsgkpRXwnRpAHg4nRG97mJ78KAMzexlyIefbfVB2GVAk0k6/Ng/L51Hqy2IU4aMrhoi0wcpo9Qbjd2COm4Ux4vrEBgEwMkrfhtr8WPe75bZzvt5bQ17axpOel+xKKf1rSROgCgtr8C0dhdYQlWLysEo2Wy8Jqc78JeCkmR0bAkNGE2W3r5W+h6Q2NWq//q6sf7m+/kwrbLwuV+Vy3YlIVGjsid0ioJxpK0h0B/aRs0FpfVHYkKrwFJC0bz0xI3sMWZMlgIBXLEOy2AdRqFPX+pjj4Xd1bfQgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=5o3MjP4Xyup2z4+VruHsu4pa+Ez3/ZYNop7+qUPcPWU=; b=Gtvc26UtBl36xK/xqvboQlK6LugjpJx+nlHVpZw/VkesP0uaQdZ3GXbspTLilQxP2eTPgXvF3vLo2GKTMGGcpBzI8T7Tig9M8SXYRuaUEpRtEqe38bCyzyXr2JoVxWTNH5iTyNjWtBgfPW8Hdm5/OgVQHqBHLr8PGzDcuRj98rFwdDrjJCxL6WPDvX+UuZtLa9ICUBrKogAJIkpX2txNlTxW1kR/5Am+0qnwsOWa/zjn872jdC07metqq8evut/WdspAgNgCc/Kxxo9aTfhdNH0aSFj4SDBhkKMTo2JXX0w6NFsI+lKh/0lAIpWBJqvLW1qXX/Y4ZSWT3m5SNDaqCQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com; Subject: Re: [PATCH 04/12] swiotlb-xen: ensure to issue well-formed XENMEM_exchange requests To: Christoph Hellwig Cc: Juergen Gross , Boris Ostrovsky , Stefano Stabellini , lkml , "xen-devel@lists.xenproject.org" References: <588b3e6d-2682-160c-468e-44ca4867a570@suse.com> <397bf325-f81e-e104-6142-e8c9c4955475@suse.com> From: Jan Beulich Message-ID: <0082b78b-3821-9908-d365-3f66cf1e92ce@suse.com> Date: Wed, 8 Sep 2021 11:16:47 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PR3P193CA0035.EURP193.PROD.OUTLOOK.COM (2603:10a6:102:51::10) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 58c068e7-bd38-449e-2459-08d972a963dc X-MS-TrafficTypeDiagnostic: VE1PR04MB6383: X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1122; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Guxq+V8Is6BKCmeCsESNqL3+mxl1B1a2wWpJVzr1gl8atZjNJBvUBvXAivqypvQEZxHP/lrHbmhlay8GPHwGY6Uvj20ZI4z8qbRr+xMijHzK1s0yYkArZVk/9kgM+c88j26L1dTgqtXICM9b4KsuwXcMZD4AncWX0iVWRiv07LVadBBvxjUJ/GyjX66RytpI1/JedJwLcuWlJfsisEP/aYdKOXysZnU+Neq/pTBQD70rifQhPwUQXB3zYqatUnpqiVh635kx8n4hyI1LHlh6gYViK+s28uz+/Z5VmMtcGZcoRIDImxw4gawMgfm1qYXRH1xZD5RCbUCx6l446EW32j0nZMCVtJhzlPwkGGv4hjV7tkvIlgA/Jid8CUIYWV4HFay5qcxWBFOyBY2wF61L1gHSkOrewZj4UCrxbUWbOIcyc/lAsXp16Z6h9LCiCv5AyDJs509Aixmkzl53YhRak4qcz9zlhxuSRD8nTAxNmBt7qgJ9Y+gklh1Wb9D7M/m9N6PGozx2ewast5JggbZPUBgP8VMPv2CsnErpbMa+afwHMIEck30zHp7Ky4Ij4kWwSrf61wk33aNWnSej3TtzyYAqrnBPXlkQPa44s5QqatqVu2naF5voVirFeIJgiHuDTiJefvSqvJ/Ijq7NAprepagdz2NyB57ZZJ0ZAjRKuzD8y1IGRxfp2Ly1EnhbltrL56WgbCnDKvwaU8w64R8tTH88zVhu5nFmdV9TXZGkw+ceyOyvsHuPimA6hCYIBhIC X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(39860400002)(376002)(136003)(346002)(396003)(366004)(316002)(16576012)(2906002)(6486002)(478600001)(66556008)(53546011)(38100700002)(83380400001)(186003)(66476007)(66946007)(5660300002)(54906003)(31686004)(6916009)(36756003)(2616005)(4326008)(956004)(86362001)(8676002)(26005)(31696002)(8936002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NUdKYUlFbHN3NUVNWGRUaGh3YUl5b1ZYRGN3M2pXWmY1bEliYkJUMzRZN29O?= =?utf-8?B?MjNUTGx3TEpEcW9ZalVhbmpQVHFKeHgvRHgwTmJaZktnMEp6TDFVTURzT3M2?= =?utf-8?B?LzVhbW9nUTRLNzZGUUNyRWdqZnJGaU9GM2FMWWZSeUE1Rlc3RHp3NzBkZDU4?= =?utf-8?B?VlFWcGJDQWlraFRXbGhhUDNMSGFJMzUxQVN3MmFQODhOR2tqcHBoMlluNCs4?= =?utf-8?B?NXBSRkMrM1B5US9McUpjYUJ6YXQ0VVJCakJVMXZ2RmhGQ3BlOUV1ZnkrUTBr?= =?utf-8?B?bDBERG5xaFpaTHdsOHRPV2FONEVubUt2MXF2dWlXTVN3NmR4OTdYTld6dFJh?= =?utf-8?B?UHdOeUJ5ZCtLclV5bEY1RmRTQ2JuQlJzRWZaODNvaEFQTHhKb3g5c00vanRW?= =?utf-8?B?Z282eUVJbTQ1N3RzTUFxYWdMVmFpVVdzRnppUkxmTlBFL01aWjUxQ0tYSVo2?= =?utf-8?B?UDVWOTFTNFcrZ2V0RU82bm9abU0yeVpzKzhkeURFaEh2bmNRTStiT0NJUEZ5?= =?utf-8?B?c3VBQlJPdEJQdTd0Q0ZJb0VhYVMxTWZoaEFpQlhZTDVHblpmaUd0Z0VadlJl?= =?utf-8?B?bEx5QXZOalhoUWg3WWRHSXZtT1pXbUY5ZzViczhhRkZlQ050T1hISEtPS3Qy?= =?utf-8?B?UkxHNVc5Y3JFZStnSUZNM2ZSdTIzOXA1RVFtL29sZ2hmSHkxbi9CU1FGMTA5?= =?utf-8?B?cDFBVS9LT0VzNVk2OXp0RktDdFROOVpZa3pXVU11OEsrcmE1MHNSd3Y3eTdG?= =?utf-8?B?NS9iMzZsZW91Nk1HcXRTcTFGZnk5dWlkb3BTNXVpNXYvM3kzTFpMSllKWjBw?= =?utf-8?B?K0NuVVBEaEFWU2hFYzFINEgvWnlsNjFvRHdPdXZHMlBqMmJ2dThuaHh0enVI?= =?utf-8?B?M1VJdDB5bGxpQk94cTJudXhaWnZTa0tWTldnMXAxYXJ5aGpsSGg2MDZwd1lu?= =?utf-8?B?cSsvSHA4c1lmTlBmRjkzaThPUmlyVzVXbXphZEx0MVB4YVE5Mk9EZ2FJaEsy?= =?utf-8?B?eFhBNWxQOFZlSCtpLzljeFdnOTl1UEtVNEo4UzNjbnQ4VnJoQlUrcVhhZ1lB?= =?utf-8?B?ekVFR21FeG4zYUxKQVY2S2VKMnBqYnZVeXVjRlliU1FQZUViajBENk02cDN5?= =?utf-8?B?UWM1NGZ2SG1pTGM5cmtGM3U3Q2lJajh6eldCdk50TXdVdXdPalVlcFJHZnJ5?= =?utf-8?B?VVVrb1ZVak04WTcvQkZjckJCb3dtTlZTMXpaVjVGb3dBTnNWenpsb2dMMVhl?= =?utf-8?B?SXZ4cUdiSFNDVlVVTHQ5QkM0UldZaTQ2b3djTDE4ZUl6QStmeU5hVVgwVnZl?= =?utf-8?B?L21PMmc1RWt6WWpOQlZyaFlTMXpHQTl1UDR0aFZ2Zm5nZW1BZC92SHk0WnpC?= =?utf-8?B?UG5uVkQ2SkM4MGJVWUNmdzRoaU84N1FOMU9sZlFhWkViS1Z0UFdVdGkxcnNo?= =?utf-8?B?VU5KR2VjK2ZENHpiTForaEhMWHpreVZxaHRGMURsY3M0VUVVbk14Q3pxUlAz?= =?utf-8?B?Ynpsd3BxV1JGK2tIS1cyWk5PcXd2eDcrQzVrVTBWNjNmT2RhM3pXVm5zY0pO?= =?utf-8?B?VXd3c2Vvam1zdkVaeEdWVkpmWWhuYktDRkhuSDN1cDYwUFd3ai8yMUd6d2c0?= =?utf-8?B?RGdUWFdXa3NGSmhCN0N0UWZzdmZDbFRoTDlmU0MvYmVudDQyaGk4Zzh3RzRM?= =?utf-8?B?dE9tZ1N1ekxGZU5DcU91U0FGYWNRc1dVWGF3UlRkVXBPNnAzR2FUYWxRZDZ6?= =?utf-8?Q?qbZVQZz9At29VAsS2iO2s4Jy08h6Ek2uyO5oZvQ?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 58c068e7-bd38-449e-2459-08d972a963dc X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Sep 2021 09:16:50.1985 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: oxiRe2KcUtPOjSQt5W89hd1K48UU4j81/tBa+grj82mrAEvna7RhDDNcFvfBWZtOxr9eFEGZyOzcKB3JKWQ0+w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6383 On 08.09.2021 08:57, Christoph Hellwig wrote: > On Tue, Sep 07, 2021 at 02:05:32PM +0200, Jan Beulich wrote: >> While the hypervisor hasn't been enforcing this, we would still better >> avoid issuing requests with GFNs not aligned to the requested order. >> >> Signed-off-by: Jan Beulich >> --- >> I wonder how useful it is to include the alignment in the panic() >> message. I further wonder how useful it is to wrap "bytes" in >> PAGE_ALIGN(), when it is a multiple of a segment's size anyway (or at >> least was supposed to be, prior to "swiotlb-xen: maintain slab count >> properly"). >> >> --- a/drivers/xen/swiotlb-xen.c >> +++ b/drivers/xen/swiotlb-xen.c >> @@ -231,10 +231,10 @@ retry: >> /* >> * Get IO TLB memory from any location. >> */ >> - start = memblock_alloc(PAGE_ALIGN(bytes), PAGE_SIZE); >> + start = memblock_alloc(PAGE_ALIGN(bytes), IO_TLB_SEGSIZE << IO_TLB_SHIFT); >> if (!start) >> - panic("%s: Failed to allocate %lu bytes align=0x%lx\n", >> - __func__, PAGE_ALIGN(bytes), PAGE_SIZE); >> + panic("%s: Failed to allocate %lu bytes align=%#x\n", >> + __func__, PAGE_ALIGN(bytes), IO_TLB_SEGSIZE << IO_TLB_SHIFT); > > CAn you avoid the overly long lines here? A good way to make it more > readable would be a variable to hold the byte count. There already is a variable for the byte count - bytes. Did you read the post-commit-message remark? _That's_ what I'd prefer to shorten things. Meanwhile I can of course wrap lines; I will admit that I failed to pay attention to line length here. Jan From xen-devel-bounces@lists.xenproject.org Wed Sep 08 09:27:17 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Sep 2021 09:27:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.181582.328753 (Exim 4.92) (envelope-from ) id 1mNtrM-0003TL-Hn; Wed, 08 Sep 2021 09:27:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 181582.328753; Wed, 08 Sep 2021 09:27:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNtrM-0003TE-En; Wed, 08 Sep 2021 09:27:12 +0000 Received: by outflank-mailman (input) for mailman id 181582; Wed, 08 Sep 2021 09:27:11 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNtrL-0003T7-9N for xen-devel@lists.xenproject.org; Wed, 08 Sep 2021 09:27:11 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id f08a8b74-1086-11ec-b148-12813bfff9fa; Wed, 08 Sep 2021 09:27:09 +0000 (UTC) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05lp2171.outbound.protection.outlook.com [104.47.17.171]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-37-t_TL7G9YOfGi_mOJw49UfQ-1; Wed, 08 Sep 2021 11:27:07 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR04MB5471.eurprd04.prod.outlook.com (2603:10a6:803:d0::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.21; Wed, 8 Sep 2021 09:27:05 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4500.014; Wed, 8 Sep 2021 09:27:05 +0000 Received: from [10.156.60.236] (37.24.206.209) by PR0P264CA0259.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14 via Frontend Transport; Wed, 8 Sep 2021 09:27:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f08a8b74-1086-11ec-b148-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1631093228; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BGsWH3DlKX8CGcHvdtIStd5DnQ/LPtxITcKt1B0HTMw=; b=i7FHzqfAHQEIfoFXdYBq0l4Cwrd4LBe2MCW12YGzGRZzSYTOQLuhK62fEsqLMmU4V9fDys F//5NqIM65+QlR5hDqa1agQDbct6/7ja1n/GE7MxblI/VppT32Jy8ZnscI8wcDPUWy4XgN PeV17OytrqzsKv5OcPQyjEv6Alo5VOI= X-MC-Unique: t_TL7G9YOfGi_mOJw49UfQ-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZTf+i/a8bwz3ctpaateDObBE9D3gnoJA9W+tUTXWQZ5nU6jQXZ/VfDGrZ60RAFZGkOTH3/P+rzg36rmjK5e/B5RmXUw/PB8FFPelt/4OSccTINKHs3beoWm2hdCz03g3a3oeMg1erZNRefbWiGzHDbIm6VB4fiVpCrraUmPxvEFVDylnW+5/eLja0kz9d0WU3VNtntGXq9kyd4LKcJ/0URiCAuHbkT72/EsThLG3CaDnGwyaFusFgO0Ena9wifon3oHIjee0NQ9jq3uNsuS0r6ConH0kjBGwxb3ejqVdwKl8eG85SQeJImfD1qz0Pg8gp7+XNpR0L7U+GrhAInddWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=1zhjAwC6vyGmgkrRKbJ1KOOZfLGy0u9qqYmJFK21YRk=; b=cKk4nP7hC3JDOfIL0dBMkjY9dd/xkC+L6gFX7M4sGsZIm/31ozwgW96HpbLopXcAZPKddY9xTZDGc70d1Rqg/G7Xl/2cFjudq5zKzG4636mEDo+97qB8OhBhcSyIs+VfajAkxGEZpk4YJP1owC5meNcdiPJpSzgzGjC6JImPHIW6PBfOf+MqyYK/33sm5AjoeHJ3PwUbh2LAnJ5bud6DVJ7YEWYRlMFby1076imZhQf8mJWAPoCTvoCt9u7uQYO23NoKsSV3LS6jxzTb/kF4rXjAkVtpjHyIfRlvPdP9s37TY6YBDy+sayXMigPEbOe/KPS4tCmNaiHgGmkJwhO/Fg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com; Subject: Re: [PATCH 5/9] vpci/header: Implement guest BAR register handlers To: Oleksandr Andrushchenko , Oleksandr Andrushchenko CC: "julien@xen.org" , "sstabellini@kernel.org" , Oleksandr Tyshchenko , Volodymyr Babchuk , Artem Mygaiev , "roger.pau@citrix.com" , Bertrand Marquis , Rahul Singh , "xen-devel@lists.xenproject.org" References: <20210903100831.177748-1-andr2000@gmail.com> <20210903100831.177748-6-andr2000@gmail.com> <1848521d-4179-f5ee-e3af-f4e6738f60e6@suse.com> <2e0c2ff5-7228-a439-c8a6-50f7a022e77b@suse.com> <24624eca-766d-6841-dc90-43371f5a39ba@epam.com> From: Jan Beulich Message-ID: <983f79a9-d72d-0704-9b04-950f858fbd7e@suse.com> Date: Wed, 8 Sep 2021 11:27:03 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: <24624eca-766d-6841-dc90-43371f5a39ba@epam.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: PR0P264CA0259.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100::31) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 700032e4-a12a-479a-facc-08d972aad2ce X-MS-TrafficTypeDiagnostic: VI1PR04MB5471: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: FGDjygKQMoUD429p3r+tWx84GNwJVZGnnN9bZbHt8hJ+UtZS2x+9ql4wZ5zS5KqYoE6E8Aad22cTxsaylR20FI7e4/BAZmbKqtBxu+/k1qZBQeYqRgvShrC80FCAOSZQIHX1H6PDoazwUPw8tSBheH3dDzipjhGfCWneMUlfsHkS0mfXZp2ic1RSy+wtTtOs/m+7FgGrgYmo5UTgyncE6I491CbbgI2x5Mx7JirC4ZeF3Ojbeq537VQFq3tjzP02m1BflREM6ndQepes43vL54o0awoPwTMBszJj/bXaZl53Tw4UBanwduEOAnjDz0T9pGLrMcmMdK0cf6fWVyCaDB5bsRhzcCYY9dXHCd9LLzsz6C1q7IfOCBOaoEnlV5hnqYPUxFRNfk4Vsudv3bCG+eQ3M+b33tI9Oc+PDF8YMA65xpmu8eMXUJSmC4N70WaSQ/FIdqI9IebmRgmOKDgRvuEWtGRgGpcEmsRtaZMVvSAW8LwH9GYyZ2pigWOl+boLfI1oYh+jquSWRHKw/KDVKvoULA6X2enpd5HNSOp04TIwdNBw2mfEL5cxLC60m5FxBO9SGmxtecFA2BzEIiKIZTXi1p1jdBnUjKnJw3hA23UAbvsD9oxWXaQDeA7n738cyEpM5xnw0vauAVf4r9R2IW4BvDtvH3KLaMbUWTsdnOKW+B8LPz963bBrk+oYo+HzTnNGB+92Epne71l9o3s4k7UznFsEP1WnIF36pLcw9Pd1htX+rG6jwX/3C5tI4Fep X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(376002)(136003)(39860400002)(346002)(396003)(366004)(53546011)(16576012)(2906002)(186003)(36756003)(66556008)(66946007)(26005)(31696002)(4326008)(54906003)(478600001)(316002)(86362001)(2616005)(8676002)(956004)(8936002)(5660300002)(31686004)(110136005)(38100700002)(6486002)(66476007)(83380400001)(7416002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?9pFIHmupBTgZQnJNxGolZZGpQLRTZ5wSh9KSvGK0/QZvgopmAjWp6vT3mypH?= =?us-ascii?Q?3Ua+TK298yxLL2qm/lfM9eWkG0RoGeip6uLowgtWxJvxd2Ci6pl+Lsxv9GXB?= =?us-ascii?Q?b47lpZ8Bv2pI38o0TNLJIPxIDnRGAU/APH9YArpIKJriRdLnFhouo8BJYf0C?= =?us-ascii?Q?KFxwGOzSfyBbRHZMPVXI8tTb0Zn1F8ExTB8otUHh8E/oRFYue4SzylohZdSl?= =?us-ascii?Q?WPA9GeO+OaG4Sm3ir6XIRi9T6ajW2jrseihcxTonvhi8/PP+5QfKjstNcM4s?= =?us-ascii?Q?dlUMSQPy20y3w2BT/LWgq6We40g+qMFoWsMBGd1XMQdPXKZ4MuUWInf2MWqt?= =?us-ascii?Q?pcby/meM7PNmjAzraJexvJfOyqgHMqHuNruAjkE1f2VPdhj56lKijQXcDuRY?= =?us-ascii?Q?7UccfD7ViqqMVzdBeYJE/QS+MEOcYw9Kt6fkOPesEKi7IeMDC30N5OdtMBVQ?= =?us-ascii?Q?QKdiUWKLGUzPdqZQ8uROHVKUOsWVRaj12Kvw4cL8fCIpF7/zX3PtEWYn6Vsd?= =?us-ascii?Q?GMYuDwsqge7NoGHCRowCqLUiUgZi0Omh0ubiEOZyWrQxYxvkpRb5oVXySh7U?= =?us-ascii?Q?4XPLacWCviF0WfEx8VdYiBmF6NY5IkYhuvVRWmKMwpcpccuB+Fkf2ScYZGnz?= =?us-ascii?Q?AZ2umt7VaOelZyLZqjUO6GuKcek5sZZ2jZoLSrEoBByI16Zs0kxUyo7R6ND7?= =?us-ascii?Q?Q91rRcK5XED/4wIfEE4n8clOuSbmA8Xd4MX4HuXAS/Yi5CECxlqkxv25GlAZ?= =?us-ascii?Q?BKQBkrKAPMmwoiNPXIe7/mctbHMPaYXx10LmQqllbM7TcOjPzS5cWCGnP0Cd?= =?us-ascii?Q?hsFk0MKryEOLSm43wXXKfPSpiTCZdvqnhmP0x6tVqEe5+7W+C11q8sZiOwDH?= =?us-ascii?Q?2QtfOsscER0QNoiBOv5iPuE4ShMixA2UeHbstW7v7rcEPuF0Bg3lMvmXWAol?= =?us-ascii?Q?XZ0NoAoQgKZV3vgL4W93QQuO42FK0mrMW8ennwfaig5KBsr8J+wOK1QzXsWO?= =?us-ascii?Q?Y6+syZuVp2xKbWNHWPMkImKniifXYXktJGmee0nqC0RbjwHofukxp48n3CcV?= =?us-ascii?Q?mSMIFQxspYzekadPEbx9aQqtlov1DEZGmdqxfeo8laLw6/LjrDsNlp2dAl0g?= =?us-ascii?Q?7a1WfNCXaAwxgRKLmVfWUFCOQQRkvErgOsOi9MRztEiSkbUNpG+gPRvWiCoB?= =?us-ascii?Q?0uDW0LtPTEfVzBeoIG7gSj97J7XEHM7OGGJ5uZgJnH5gdZPM2M8Smp/P2CJU?= =?us-ascii?Q?eqYhqZz6x6sL5BCIiZ3pNhTpf0h7GKCA/rINuB4QUy5zgdnCYdR6dDHY2Vpr?= =?us-ascii?Q?CZnk/BJILLQmoK7vBSZK27HP?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 700032e4-a12a-479a-facc-08d972aad2ce X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Sep 2021 09:27:05.7841 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: h+Pebd6H3BP+bhhMcrV4OxuHtCxL6f2eEOD9d5ySi29qntH8LYtTfae8UnIz7OjUdVWhymzMFJ/pvO3N3QXPiQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5471 On 07.09.2021 19:39, Oleksandr Andrushchenko wrote: > On 07.09.21 19:30, Jan Beulich wrote: >> On 07.09.2021 15:33, Oleksandr Andrushchenko wrote: >>> On 06.09.21 17:31, Jan Beulich wrote: >>>> On 03.09.2021 12:08, Oleksandr Andrushchenko wrote: >>>>> --- a/xen/drivers/vpci/header.c >>>>> +++ b/xen/drivers/vpci/header.c >>>>> @@ -400,12 +400,72 @@ static void bar_write(const struct pci_dev *pde= v, unsigned int reg, >>>>> static void guest_bar_write(const struct pci_dev *pdev, unsigned i= nt reg, >>>>> uint32_t val, void *data) >>>>> { >>>>> + struct vpci_bar *bar =3D data; >>>>> + bool hi =3D false; >>>>> + >>>>> + if ( bar->type =3D=3D VPCI_BAR_MEM64_HI ) >>>>> + { >>>>> + ASSERT(reg > PCI_BASE_ADDRESS_0); >>>>> + bar--; >>>>> + hi =3D true; >>>>> + } >>>>> + else >>>>> + val &=3D PCI_BASE_ADDRESS_MEM_MASK; >>>>> + bar->guest_addr &=3D ~(0xffffffffull << (hi ? 32 : 0)); >>>>> + bar->guest_addr |=3D (uint64_t)val << (hi ? 32 : 0); >>>> What you store here is not the address that's going to be used, >>>> as >>>> you don't mask off the low bits (to account for the BAR's size). >>>> When a BAR gets written with all ones, all writable bits get these >>>> ones stored. The address of the BAR, aiui, really changes to >>>> (typically) close below 4Gb (in the case of a 32-bit BAR), which >>>> is why memory / I/O decoding should be off while sizing BARs. >>>> Therefore you shouldn't look for the specific "all writable bits >>>> are ones" pattern (or worse, as you presently do, the "all bits >>>> outside of the type specifier are ones" one) on the read path. >>>> Instead mask the value appropriately here, and simply return back >>>> the stored value from the read path. >>> "PCI LOCAL BUS SPECIFICATION, REV. 3.0", "IMPLEMENTATION NOTE >>> >>> Sizing a 32-bit Base Address Register Example" says, that >>> >>> "Software saves the original value of the Base Address register, writes >>> 0 FFFF FFFFh to the register, then reads it back." >>> >>> The same applies for 64-bit BARs. So what's wrong if I try to catch suc= h >>> a write when a guest tries to size the BAR? The only difference is that >>> I compare as >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if ( (val & PCI_BASE_ADDRE= SS_MEM_MASK_32) =3D=3D PCI_BASE_ADDRESS_MEM_MASK_32 ) >>> which is because val in the question has lower bits cleared. >> Because while this matches what the spec says, it's not enough to >> match how hardware behaves. > But we should implement as the spec says, not like buggy hardware behaves The behavior I'm describing doesn't violate the spec. There merely is more to it than what the spec says, or one might also view it the way that the spec doesn't use the best way of expressing things. >> Yet you want to mimic hardware behavior >> as closely as possible here. There is (iirc) at least one other >> place in the source tree were we had to adjust a similar initial >> implementation to be closer to one expected by guests, >=20 > Could you please point me to that code so I can consult and possibly > re-use the approach? I only recall the fact; this might have been hvmloader, vpci, or yet somewhere else. I'm sorry. >>>>> @@ -522,6 +582,13 @@ static int add_bar_handlers(struct pci_dev *pdev= , bool is_hwdom) >>>>> if ( rc ) >>>>> return rc; >>>>> } >>>>> + /* >>>>> + * It is neither safe nor secure to initialize guest's view = of the BARs >>>>> + * with real values which are used by the hardware domain, s= o assign >>>>> + * all zeros to guest's view of the BARs, so the guest can p= erform >>>>> + * proper PCI device enumeration and assign BARs on its own. >>>>> + */ >>>>> + bars[i].guest_addr =3D 0; >>>> I'm afraid I don't understand the comment: Without memory decoding >>>> enabled, the BARs are simple registers (with a few r/o bits). >>> My first implementation was that bar->guest_addr was initialized with >>> the value of bar->addr (physical BAR value), but talking on IRC with >>> Roger he suggested that this might be a security issue to let guest >>> a hint about physical values, so then I changed the assignment to be 0. >> Well, yes, that's certainly correct. It's perhaps too unobvious to me >> why one may want to use the host value here in the first place. It >> simply has no meaning here. > Do you want me to remove the comment? Yes. I wonder whether the assignment is necessary in the first place: I'd somehow expect the structure to come from xzalloc(). Albeit I guess this function can be run through more than once without freeing the structure and then allocating is anew? Jan From xen-devel-bounces@lists.xenproject.org Wed Sep 08 09:44:17 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Sep 2021 09:44:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.181590.328776 (Exim 4.92) (envelope-from ) id 1mNu7o-0006Md-By; Wed, 08 Sep 2021 09:44:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 181590.328776; Wed, 08 Sep 2021 09:44:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNu7o-0006MS-7i; Wed, 08 Sep 2021 09:44:12 +0000 Received: by outflank-mailman (input) for mailman id 181590; Wed, 08 Sep 2021 09:44:11 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNu7m-0006JA-Ss for xen-devel@lists.xenproject.org; Wed, 08 Sep 2021 09:44:11 +0000 Received: from mx0a-0039f301.pphosted.com (unknown [148.163.133.242]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id c69fc1e8-ed8b-40ae-be59-91f4e4c4704e; Wed, 08 Sep 2021 09:44:09 +0000 (UTC) Received: from pps.filterd (m0174677.ppops.net [127.0.0.1]) by mx0a-0039f301.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 1889FxoT024637; Wed, 8 Sep 2021 09:44:06 GMT Received: from eur03-am5-obe.outbound.protection.outlook.com (mail-am5eur03lp2050.outbound.protection.outlook.com [104.47.8.50]) by mx0a-0039f301.pphosted.com with ESMTP id 3axtd083nt-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 08 Sep 2021 09:44:06 +0000 Received: from AM0PR03MB6324.eurprd03.prod.outlook.com (2603:10a6:20b:153::17) by AM0PR03MB5700.eurprd03.prod.outlook.com (2603:10a6:208:16f::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.21; Wed, 8 Sep 2021 09:43:59 +0000 Received: from AM0PR03MB6324.eurprd03.prod.outlook.com ([fe80::70f5:8ba9:da74:8994]) by AM0PR03MB6324.eurprd03.prod.outlook.com ([fe80::70f5:8ba9:da74:8994%3]) with mapi id 15.20.4500.015; Wed, 8 Sep 2021 09:43:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c69fc1e8-ed8b-40ae-be59-91f4e4c4704e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VSFa/X+79PDEBINK7vW5RYS39EJ8wso4+uI1RozkiTUHmKBcySqoxW89V8sJti/sef79MWdSMCzdxWJHgx0ZM+iPPiePEhzJEaOXyytdv9zsUeL8tsgADslosXT5szef2IT4qEjNTDo1xTyzZpNEGibCeDwPcyHNlA0nZx36/jNopxP6dy/hqAKo0Tnawz9PkNh/x+fCMi+VX7EO7HLy/qc3Grajgp4OEeCV971s8+Gks+g0WjktZp+fFySltxUscARmMaAwOCGpWm/KyHg3iW7WRgmjxfWir4uxQxqhpb7V/VCUgIU50cwyQ7xzljFh3JilYSJi+3opTykpGHDHgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=X2aKd0k+XEncRABb6WT/koWSa4++HRFGx8CZSLC/ryw=; b=dbGjh8a2Aa9nmAJX9Uo2tAWU2fkRocCXSVj8ZGyqsXpLRSZ5MpJyHeMJwJVAQm28TeYWKnSxzgNrDQbaEl7TI8JFZxOgZiBEF5t59tMl6hLKoCqpxzYCD67FskBR3AtAGLNfn929vlqOnjVwyHynKNeRFrgGkz4V0yA7VEx5zkhXP3OwC6wBuTmR4jsxRfoBwEtLffxnhJDad+7HLWRa18/oImX1PrlOejbD0DYtCU/M+7c08ggseOyqIbHzQcuNZFPkk17tvJZ5OZTkR+nntKrtolUBG7DRiGsNq6PkOBEpDCeL65oBBdo7KzeSdvXwmao+LrgzZxHVXNUPBnRQ4Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=X2aKd0k+XEncRABb6WT/koWSa4++HRFGx8CZSLC/ryw=; b=072+yUaJttkbl1Pp+sWpvbUZUZUrzAxK+OvzF1/mRNK+c8W0hgVcfXgicyESRpXL8U+StK+n7qQLtEINgbRwj+aQA1Jtp4NkYO6akWmAeVlgEFzCbIo3Vfsb4f0gcZWfEIOSqNc3rE49rxKnDE7gk8NGEE7xPpPgBVL9SJ+Mz53DCw3ZL/DObkopY1/dcnPP6J2c/PfiaxRtapKjZsyGRbAmF+Cuna8EYx83wvCxE1k6DzKaADZJBGVdM+xJfroNBQn7ySuotgxRAQ8ci6Fz/hHufMtrx0Vw8y+XUXSchsDW3eXxZtzAfqiezg3QLjZk9/TBTX+MMwsYm2bxHZo7dw== From: Oleksandr Andrushchenko To: Jan Beulich , Oleksandr Andrushchenko CC: "julien@xen.org" , "sstabellini@kernel.org" , Oleksandr Tyshchenko , Volodymyr Babchuk , Artem Mygaiev , "roger.pau@citrix.com" , Bertrand Marquis , Rahul Singh , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH 5/9] vpci/header: Implement guest BAR register handlers Thread-Topic: [PATCH 5/9] vpci/header: Implement guest BAR register handlers Thread-Index: AQHXoKxmxnIdZosa7ESbvTmPlG6KHauXFn+AgAGCLICAADFtgIAAE0qAgAEIooCAAAS6AA== Date: Wed, 8 Sep 2021 09:43:59 +0000 Message-ID: References: <20210903100831.177748-1-andr2000@gmail.com> <20210903100831.177748-6-andr2000@gmail.com> <1848521d-4179-f5ee-e3af-f4e6738f60e6@suse.com> <2e0c2ff5-7228-a439-c8a6-50f7a022e77b@suse.com> <24624eca-766d-6841-dc90-43371f5a39ba@epam.com> <983f79a9-d72d-0704-9b04-950f858fbd7e@suse.com> In-Reply-To: <983f79a9-d72d-0704-9b04-950f858fbd7e@suse.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=epam.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b5f5beeb-a20a-4741-bfb7-08d972ad2f1a x-ms-traffictypediagnostic: AM0PR03MB5700: x-ms-exchange-transport-forked: True x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 8b3+MPJ8fTW8GNQJ28JO1xIeYrvduCPcdyHuOjJbNZjMvdmgMma1Xrc4CwuPnHoHJoby7RxsiZemVLZUz2MtHg+D+4b9cqHHfeodEhW88CwyuKHNeJQn+sAEPjutwj2l6e0W3bxKZ3QJEb2Lwtj0pIG+tjM7TNrnJ5I3pH7LlViuQSl1VRDw0R8b1KSgkMY8dak6N0KtptkHO0ALecY6tO42W2U017K8YsblTtWXk/9j7/JySvEwoGhOFlGBMSxLBCdXyjpwTo1eGdZ5aKQPp2xiIDbXg7NBKOnZ0cu1VGtUcVzkOjJs1ZOwYuQHPIM9sn2BlFKe6AG43FzkCvJyOPUABnItV7OR9rCmdrSFwWvHyHWiPQgOnay7c9T5sYwfwnagnOEsS1a18HVd4HU2Vf18vm6lQhEyWahSD1zhfkLAikOaFvvEWdFIo54fV9tXfeRkja40LCmZGGeMX2wVwaYiXTMJ3QSwdLDmBXslOLYNE+JlkhtpOWBQanZ3q015JPdVOQyi9J9i+wJNgFWLPaGXCOaHiHAWRG/tuuQk89vp2qdHHzaTnGnOJ3yOALLc+d6uQTK6QagWVyYwaiqLTpvAom50b8rVRgcLJKZ7QIfBB9Gjric8K6Y+jtgl6sQXtwiTLVXerKJa0s/M7Ln2lMsPeS8op60fcOPv1Mm7sONRRprWSkEPzy2YvPGLqY6g3+xYSgMB8c1S+bySXkXpDphmJyFsHvZpz/qVmSp3Idk2QbkxcZk9Z3F649yUvJpQ x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR03MB6324.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(346002)(136003)(366004)(376002)(39860400002)(8936002)(38100700002)(6486002)(4326008)(122000001)(186003)(31686004)(64756008)(66946007)(91956017)(76116006)(83380400001)(31696002)(6506007)(5660300002)(26005)(110136005)(316002)(478600001)(53546011)(2906002)(54906003)(36756003)(71200400001)(86362001)(2616005)(8676002)(66476007)(38070700005)(66556008)(66446008)(6512007)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?eUNMOTlrSWhCNzI4SmEvS2FqY1hiQ3VhWUNkTURRdDlUSytyOUxxcVpVOExE?= =?utf-8?B?RmdQeHVPWVBmN0xFVHZCYXVZbTBhVlowUE10MGd1VDBLai9GY1cwdnpkWjZ6?= =?utf-8?B?RnhBTHk4eVYvUGRFWm9LYTRnRGFJZkFleWNyMHphdk9neU5IQVVDYXhzclJF?= =?utf-8?B?eXd5Yksrb2l5WnVJSmFESmpzbzcwa2RibXdKMU4zL1JJbDBjU1pzY1pubDcy?= =?utf-8?B?TXM5bE9FYnp3dDlIbWpIOHNxbGEwNGxlSVBNd2dUeFlhaGVlVk52MnRiK0xo?= =?utf-8?B?WjE4Q3Rja25BRWNxSjd6L3ROczJCWVpJK3k4MnU1QnFReDFZeG1JTHFtd1ZP?= =?utf-8?B?QXNqUnkxVE12dGExT0wvUUZIY0V1WHdCRUdaRXcwYlNoREwvOEtOZWMrRzg5?= =?utf-8?B?eitaeXZXdVhqbDdUSm9oaGRRQVZzcStFb2poSzR3aFBQUDhKTEVOTCtvWlBP?= =?utf-8?B?Rm90NXpQMWFWeWxSVWtITW4wMFIvV0VaTy9vRG84WlVKK0tLQ3VqMVlld1V1?= =?utf-8?B?VUM2anM0QUg2My9PM1ExUGFTYzlOc1BMODYvVEJmSHh4NTR5L0RUWDRBTFVM?= =?utf-8?B?dWoxZXFsVzJ3ZlFFUFk0bXhlWUI0YjhONXJzRDdaYkg1ZkxRZDJWNjdmOFRL?= =?utf-8?B?a2EzN3VWT1d6OUdvTkRta3QwK0dDbFZGVGh4QTI5WGxydXNSaHVsZGdZVS8w?= =?utf-8?B?Yk8wOHQwY3ZYc0ZiMWV3TWphbm5iM3FveWV0UHVvbEwrTUNySkgvWVlFeStE?= =?utf-8?B?VzFNSkRZaDFNZVowc0NXUFNLZ3BJUXd4RDFQQlhHS0s3ZWgya1dHODYwL2xT?= =?utf-8?B?bERnVmUyT1grc3Y2emNaOVY2Yzh5VWhsRk0vRXVvOWVMS1ZycDZKV0c2clY0?= =?utf-8?B?b0tEN0Zyek5Jb3FXZ2ZnNmtUK0k4V2M1K3JESEtHelhYd0VvQUZUbnZib3Fo?= =?utf-8?B?TGx1RTdNZmRUY2pxUE1IblZDN1RJUklNMGwxQUhac2hwT0t0WW1JRGpXeElQ?= =?utf-8?B?MklTWXJwNEhIM3h6ckxUdE5ieHJFZW5hQ2hnMzB0MkZGYkxJdU9VdUpUUnJs?= =?utf-8?B?b1k3VUVTRStJVG5YK0NWZU5QTFMyejN3US95TDVMcldYc0xNS3ZXRVV5ajJ6?= =?utf-8?B?dDZRSE1mcDFNbGlHWXVFcUFnekVpcFNNNWpiZk9mVHQrMnBtVkJLZTdNWDhJ?= =?utf-8?B?Zk5oZXRBTy9QNmMrL3hEVCswTUFyRlBuOU9FcnNXa1Bob09RRlFvZW50TjdP?= =?utf-8?B?QTdFNHUyRHZtcVo2bjU0N2NjWlZ2bFFhRWpWWjZEOXM4OEhVZUtaQ3RGT1BJ?= =?utf-8?B?dGFJbFpHaEVPVW1ObWs0TVE4TzZOZXRWUTQ4SERoRkJKbEhBOW9YQXdvbVBs?= =?utf-8?B?dFlKVzRSVU8vMXMwZ3dwY2F5ZTFmZVg3UGh2SXhTRjlJNVJRRzVMaFlKY3N2?= =?utf-8?B?d1A4N1hLVjNLRTJuaGE0MnV5aUI1VzQvQzdqQVNqUTZBSVpER2U2cWlRd0N6?= =?utf-8?B?ZTV3ZnFHS0M0WmtON3BOTURzYnc1UWYxR1VyRW5rRTlodFExTmRUNGdqMHJW?= =?utf-8?B?TEJOMEdjaTZIWmJpSk94WjdFdHNQVU90WElibHdrMEg3THRWZFdkZEZUTndG?= =?utf-8?B?U1Vvb21BM2psS3RXeVRycDZOUVNyeWIrVE1KVG1jWWFrS09WYm9rcU5Ebys5?= =?utf-8?B?UDkwa3pISzRvczR1QkN4QVFWdW9FTGw3NTVFd1dUSUdRRmRBbG9XZVVFRldW?= =?utf-8?Q?nsW1o0OzCzRtWbWymcFQL9AHqljHJIRiTygZCuZ?= Content-Type: text/plain; charset="utf-8" Content-ID: <2DDCAB43ABD7A6409F62548FDE514006@eurprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: epam.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM0PR03MB6324.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b5f5beeb-a20a-4741-bfb7-08d972ad2f1a X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Sep 2021 09:43:59.3233 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: dwC6Zi1yfh/yRvDbGIT66ZuOMihftHyQrsoR7rBSfcaCZwgzf/GtiRIGJRjF3PefeR/BSvsimNYWKaNH213+Zow1SifDmDU+H9hj+PGxJSffM1rc+qbYSVj/KYGRdAMg X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR03MB5700 X-Proofpoint-GUID: bBojQ6-moUQjMXAwKoCL4aBJnyOo2AqR X-Proofpoint-ORIG-GUID: bBojQ6-moUQjMXAwKoCL4aBJnyOo2AqR X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.391,FMLib:17.0.607.475 definitions=2021-09-08_03,2021-09-07_02,2020-04-07_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 clxscore=1015 lowpriorityscore=0 suspectscore=0 malwarescore=0 mlxlogscore=999 priorityscore=1501 adultscore=0 bulkscore=0 phishscore=0 impostorscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109030001 definitions=main-2109080062 DQpPbiAwOC4wOS4yMSAxMjoyNywgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDA3LjA5LjIwMjEg MTk6MzksIE9sZWtzYW5kciBBbmRydXNoY2hlbmtvIHdyb3RlOg0KPj4gT24gMDcuMDkuMjEgMTk6 MzAsIEphbiBCZXVsaWNoIHdyb3RlOg0KPj4+IE9uIDA3LjA5LjIwMjEgMTU6MzMsIE9sZWtzYW5k ciBBbmRydXNoY2hlbmtvIHdyb3RlOg0KPj4+PiBPbiAwNi4wOS4yMSAxNzozMSwgSmFuIEJldWxp Y2ggd3JvdGU6DQo+Pj4+PiBPbiAwMy4wOS4yMDIxIDEyOjA4LCBPbGVrc2FuZHIgQW5kcnVzaGNo ZW5rbyB3cm90ZToNCj4+Pj4+PiAtLS0gYS94ZW4vZHJpdmVycy92cGNpL2hlYWRlci5jDQo+Pj4+ Pj4gKysrIGIveGVuL2RyaXZlcnMvdnBjaS9oZWFkZXIuYw0KPj4+Pj4+IEBAIC00MDAsMTIgKzQw MCw3MiBAQCBzdGF0aWMgdm9pZCBiYXJfd3JpdGUoY29uc3Qgc3RydWN0IHBjaV9kZXYgKnBkZXYs IHVuc2lnbmVkIGludCByZWcsDQo+Pj4+Pj4gICAgIHN0YXRpYyB2b2lkIGd1ZXN0X2Jhcl93cml0 ZShjb25zdCBzdHJ1Y3QgcGNpX2RldiAqcGRldiwgdW5zaWduZWQgaW50IHJlZywNCj4+Pj4+PiAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHVpbnQzMl90IHZhbCwgdm9pZCAqZGF0YSkN Cj4+Pj4+PiAgICAgew0KPj4+Pj4+ICsgICAgc3RydWN0IHZwY2lfYmFyICpiYXIgPSBkYXRhOw0K Pj4+Pj4+ICsgICAgYm9vbCBoaSA9IGZhbHNlOw0KPj4+Pj4+ICsNCj4+Pj4+PiArICAgIGlmICgg YmFyLT50eXBlID09IFZQQ0lfQkFSX01FTTY0X0hJICkNCj4+Pj4+PiArICAgIHsNCj4+Pj4+PiAr ICAgICAgICBBU1NFUlQocmVnID4gUENJX0JBU0VfQUREUkVTU18wKTsNCj4+Pj4+PiArICAgICAg ICBiYXItLTsNCj4+Pj4+PiArICAgICAgICBoaSA9IHRydWU7DQo+Pj4+Pj4gKyAgICB9DQo+Pj4+ Pj4gKyAgICBlbHNlDQo+Pj4+Pj4gKyAgICAgICAgdmFsICY9IFBDSV9CQVNFX0FERFJFU1NfTUVN X01BU0s7DQo+Pj4+Pj4gKyAgICBiYXItPmd1ZXN0X2FkZHIgJj0gfigweGZmZmZmZmZmdWxsIDw8 IChoaSA/IDMyIDogMCkpOw0KPj4+Pj4+ICsgICAgYmFyLT5ndWVzdF9hZGRyIHw9ICh1aW50NjRf dCl2YWwgPDwgKGhpID8gMzIgOiAwKTsNCj4+Pj4+IFdoYXQgeW91IHN0b3JlIGhlcmUgaXMgbm90 IHRoZSBhZGRyZXNzIHRoYXQncyBnb2luZyB0byBiZSB1c2VkLA0KPj4+Pj4gICAgIGFzDQo+Pj4+ PiB5b3UgZG9uJ3QgbWFzayBvZmYgdGhlIGxvdyBiaXRzICh0byBhY2NvdW50IGZvciB0aGUgQkFS J3Mgc2l6ZSkuDQo+Pj4+PiBXaGVuIGEgQkFSIGdldHMgd3JpdHRlbiB3aXRoIGFsbCBvbmVzLCBh bGwgd3JpdGFibGUgYml0cyBnZXQgdGhlc2UNCj4+Pj4+IG9uZXMgc3RvcmVkLiBUaGUgYWRkcmVz cyBvZiB0aGUgQkFSLCBhaXVpLCByZWFsbHkgY2hhbmdlcyB0bw0KPj4+Pj4gKHR5cGljYWxseSkg Y2xvc2UgYmVsb3cgNEdiIChpbiB0aGUgY2FzZSBvZiBhIDMyLWJpdCBCQVIpLCB3aGljaA0KPj4+ Pj4gaXMgd2h5IG1lbW9yeSAvIEkvTyBkZWNvZGluZyBzaG91bGQgYmUgb2ZmIHdoaWxlIHNpemlu ZyBCQVJzLg0KPj4+Pj4gVGhlcmVmb3JlIHlvdSBzaG91bGRuJ3QgbG9vayBmb3IgdGhlIHNwZWNp ZmljICJhbGwgd3JpdGFibGUgYml0cw0KPj4+Pj4gYXJlIG9uZXMiIHBhdHRlcm4gKG9yIHdvcnNl LCBhcyB5b3UgcHJlc2VudGx5IGRvLCB0aGUgImFsbCBiaXRzDQo+Pj4+PiBvdXRzaWRlIG9mIHRo ZSB0eXBlIHNwZWNpZmllciBhcmUgb25lcyIgb25lKSBvbiB0aGUgcmVhZCBwYXRoLg0KPj4+Pj4g SW5zdGVhZCBtYXNrIHRoZSB2YWx1ZSBhcHByb3ByaWF0ZWx5IGhlcmUsIGFuZCBzaW1wbHkgcmV0 dXJuIGJhY2sNCj4+Pj4+IHRoZSBzdG9yZWQgdmFsdWUgZnJvbSB0aGUgcmVhZCBwYXRoLg0KDQpC dXQgaW4gY2FzZSBvZiBCQVIgc2l6aW5nIEkgbmVlZCB0byBhY3R1YWxseSByZXR1cm4gQkFSIHNp emUuDQoNClNvLCB0aGUgY29tcGFyaXNvbiBpcyB0aGUgd2F5IHRvIHRlbGwgaWYgdGhlIGd1ZXN0 IHdhbnRzIHRvIHJlYWQNCg0KYWN0dWFsIChjb25maWd1cmVkKSBCQVIgdmFsdWUgb3IgaXQgdHJp ZXMgdG8gZGV0ZXJtaW5lIEJBUidzIHNpemUuDQoNClRoaXMgaXMgd2h5IEkgY29tcGFyZSBhbmQg dXNlIHRoZSByZXN1bHQgYXMgdGhlIGFuc3dlciB0byB3aGF0IG5lZWRzDQoNCnRvIGJlIHN1cHBs aWVkIHRvIHRoZSBndWVzdC4gU28sIGlmIEkgZG9uJ3QgY29tcGFyZSB3aXRoIDB4ZmZmZmZmZmYg Zm9yIHRoZQ0KDQpoaSBwYXJ0IGFuZCAweGZmZmZmZmYwIGZvciB0aGUgbG93IHRoZW4gaG93IGRv IEkga25vdyB3aGVuIHRvIHJldHVybg0KDQpjb25maWd1cmVkIEJBUiBvciByZXR1cm4gdGhlIHNp emU/DQoNCj4+Pj4gIlBDSSBMT0NBTCBCVVMgU1BFQ0lGSUNBVElPTiwgUkVWLiAzLjAiLCAiSU1Q TEVNRU5UQVRJT04gTk9URQ0KPj4+Pg0KPj4+PiBTaXppbmcgYSAzMi1iaXQgQmFzZSBBZGRyZXNz IFJlZ2lzdGVyIEV4YW1wbGUiIHNheXMsIHRoYXQNCj4+Pj4NCj4+Pj4gIlNvZnR3YXJlIHNhdmVz IHRoZSBvcmlnaW5hbCB2YWx1ZSBvZiB0aGUgQmFzZSBBZGRyZXNzIHJlZ2lzdGVyLCB3cml0ZXMN Cj4+Pj4gMCBGRkZGIEZGRkZoIHRvIHRoZSByZWdpc3RlciwgdGhlbiByZWFkcyBpdCBiYWNrLiIN Cj4+Pj4NCj4+Pj4gVGhlIHNhbWUgYXBwbGllcyBmb3IgNjQtYml0IEJBUnMuIFNvIHdoYXQncyB3 cm9uZyBpZiBJIHRyeSB0byBjYXRjaCBzdWNoDQo+Pj4+IGEgd3JpdGUgd2hlbiBhIGd1ZXN0IHRy aWVzIHRvIHNpemUgdGhlIEJBUj8gVGhlIG9ubHkgZGlmZmVyZW5jZSBpcyB0aGF0DQo+Pj4+IEkg Y29tcGFyZSBhcw0KPj4+PiAgICDCoMKgwqDCoMKgwqDCoCBpZiAoICh2YWwgJiBQQ0lfQkFTRV9B RERSRVNTX01FTV9NQVNLXzMyKSA9PSBQQ0lfQkFTRV9BRERSRVNTX01FTV9NQVNLXzMyICkNCj4+ Pj4gd2hpY2ggaXMgYmVjYXVzZSB2YWwgaW4gdGhlIHF1ZXN0aW9uIGhhcyBsb3dlciBiaXRzIGNs ZWFyZWQuDQo+Pj4gQmVjYXVzZSB3aGlsZSB0aGlzIG1hdGNoZXMgd2hhdCB0aGUgc3BlYyBzYXlz LCBpdCdzIG5vdCBlbm91Z2ggdG8NCj4+PiBtYXRjaCBob3cgaGFyZHdhcmUgYmVoYXZlcy4NCj4+ IEJ1dCB3ZSBzaG91bGQgaW1wbGVtZW50IGFzIHRoZSBzcGVjIHNheXMsIG5vdCBsaWtlIGJ1Z2d5 IGhhcmR3YXJlIGJlaGF2ZXMNCj4gVGhlIGJlaGF2aW9yIEknbSBkZXNjcmliaW5nIGRvZXNuJ3Qg dmlvbGF0ZSB0aGUgc3BlYy4gVGhlcmUgbWVyZWx5IGlzDQo+IG1vcmUgdG8gaXQgdGhhbiB3aGF0 IHRoZSBzcGVjIHNheXMsIG9yIG9uZSBtaWdodCBhbHNvIHZpZXcgaXQgdGhlIHdheQ0KPiB0aGF0 IHRoZSBzcGVjIGRvZXNuJ3QgdXNlIHRoZSBiZXN0IHdheSBvZiBleHByZXNzaW5nIHRoaW5ncy4N Cg0KV2VsbCwgdGhlIHNwZWMgZXhwbGljaXRseSBzYXlzICJ3cml0ZSAweGZmZmZmZmZmIGFuZCBy ZWFkIGJhY2siDQoNCkkgY2FuJ3Qgc2VlIGFueSB3YXkgaXQgY2FuIGJlIHJlYWQgZGlmZmVyZW50 bHkNCg0KPg0KPj4+ICAgIFlldCB5b3Ugd2FudCB0byBtaW1pYyBoYXJkd2FyZSBiZWhhdmlvcg0K Pj4+IGFzIGNsb3NlbHkgYXMgcG9zc2libGUgaGVyZS4gVGhlcmUgaXMgKGlpcmMpIGF0IGxlYXN0 IG9uZSBvdGhlcg0KPj4+IHBsYWNlIGluIHRoZSBzb3VyY2UgdHJlZSB3ZXJlIHdlIGhhZCB0byBh ZGp1c3QgYSBzaW1pbGFyIGluaXRpYWwNCj4+PiBpbXBsZW1lbnRhdGlvbiB0byBiZSBjbG9zZXIg dG8gb25lIGV4cGVjdGVkIGJ5IGd1ZXN0cywNCj4+IENvdWxkIHlvdSBwbGVhc2UgcG9pbnQgbWUg dG8gdGhhdCBjb2RlIHNvIEkgY2FuIGNvbnN1bHQgYW5kIHBvc3NpYmx5DQo+PiByZS11c2UgdGhl IGFwcHJvYWNoPw0KPiBJIG9ubHkgcmVjYWxsIHRoZSBmYWN0OyB0aGlzIG1pZ2h0IGhhdmUgYmVl biBodm1sb2FkZXIsIHZwY2ksIG9yIHlldA0KPiBzb21ld2hlcmUgZWxzZS4gSSdtIHNvcnJ5Lg0K Tm8gcHJvYmxlbQ0KPg0KPj4+Pj4+IEBAIC01MjIsNiArNTgyLDEzIEBAIHN0YXRpYyBpbnQgYWRk X2Jhcl9oYW5kbGVycyhzdHJ1Y3QgcGNpX2RldiAqcGRldiwgYm9vbCBpc19od2RvbSkNCj4+Pj4+ PiAgICAgICAgICAgICAgICAgaWYgKCByYyApDQo+Pj4+Pj4gICAgICAgICAgICAgICAgICAgICBy ZXR1cm4gcmM7DQo+Pj4+Pj4gICAgICAgICAgICAgfQ0KPj4+Pj4+ICsgICAgICAgIC8qDQo+Pj4+ Pj4gKyAgICAgICAgICogSXQgaXMgbmVpdGhlciBzYWZlIG5vciBzZWN1cmUgdG8gaW5pdGlhbGl6 ZSBndWVzdCdzIHZpZXcgb2YgdGhlIEJBUnMNCj4+Pj4+PiArICAgICAgICAgKiB3aXRoIHJlYWwg dmFsdWVzIHdoaWNoIGFyZSB1c2VkIGJ5IHRoZSBoYXJkd2FyZSBkb21haW4sIHNvIGFzc2lnbg0K Pj4+Pj4+ICsgICAgICAgICAqIGFsbCB6ZXJvcyB0byBndWVzdCdzIHZpZXcgb2YgdGhlIEJBUnMs IHNvIHRoZSBndWVzdCBjYW4gcGVyZm9ybQ0KPj4+Pj4+ICsgICAgICAgICAqIHByb3BlciBQQ0kg ZGV2aWNlIGVudW1lcmF0aW9uIGFuZCBhc3NpZ24gQkFScyBvbiBpdHMgb3duLg0KPj4+Pj4+ICsg ICAgICAgICAqLw0KPj4+Pj4+ICsgICAgICAgIGJhcnNbaV0uZ3Vlc3RfYWRkciA9IDA7DQo+Pj4+ PiBJJ20gYWZyYWlkIEkgZG9uJ3QgdW5kZXJzdGFuZCB0aGUgY29tbWVudDogV2l0aG91dCBtZW1v cnkgZGVjb2RpbmcNCj4+Pj4+IGVuYWJsZWQsIHRoZSBCQVJzIGFyZSBzaW1wbGUgcmVnaXN0ZXJz ICh3aXRoIGEgZmV3IHIvbyBiaXRzKS4NCj4+Pj4gTXkgZmlyc3QgaW1wbGVtZW50YXRpb24gd2Fz IHRoYXQgYmFyLT5ndWVzdF9hZGRyIHdhcyBpbml0aWFsaXplZCB3aXRoDQo+Pj4+IHRoZSB2YWx1 ZSBvZiBiYXItPmFkZHIgKHBoeXNpY2FsIEJBUiB2YWx1ZSksIGJ1dCB0YWxraW5nIG9uIElSQyB3 aXRoDQo+Pj4+IFJvZ2VyIGhlIHN1Z2dlc3RlZCB0aGF0IHRoaXMgbWlnaHQgYmUgYSBzZWN1cml0 eSBpc3N1ZSB0byBsZXQgZ3Vlc3QNCj4+Pj4gYSBoaW50IGFib3V0IHBoeXNpY2FsIHZhbHVlcywg c28gdGhlbiBJIGNoYW5nZWQgdGhlIGFzc2lnbm1lbnQgdG8gYmUgMC4NCj4+PiBXZWxsLCB5ZXMs IHRoYXQncyBjZXJ0YWlubHkgY29ycmVjdC4gSXQncyBwZXJoYXBzIHRvbyB1bm9idmlvdXMgdG8g bWUNCj4+PiB3aHkgb25lIG1heSB3YW50IHRvIHVzZSB0aGUgaG9zdCB2YWx1ZSBoZXJlIGluIHRo ZSBmaXJzdCBwbGFjZS4gSXQNCj4+PiBzaW1wbHkgaGFzIG5vIG1lYW5pbmcgaGVyZS4NCj4+IERv IHlvdSB3YW50IG1lIHRvIHJlbW92ZSB0aGUgY29tbWVudD8NCj4gWWVzLiBJIHdvbmRlciB3aGV0 aGVyIHRoZSBhc3NpZ25tZW50IGlzIG5lY2Vzc2FyeSBpbiB0aGUgZmlyc3QgcGxhY2U6DQo+IEkn ZCBzb21laG93IGV4cGVjdCB0aGUgc3RydWN0dXJlIHRvIGNvbWUgZnJvbSB4emFsbG9jKCkuIEFs YmVpdCBJDQo+IGd1ZXNzIHRoaXMgZnVuY3Rpb24gY2FuIGJlIHJ1biB0aHJvdWdoIG1vcmUgdGhh biBvbmNlIHdpdGhvdXQgZnJlZWluZw0KPiB0aGUgc3RydWN0dXJlIGFuZCB0aGVuIGFsbG9jYXRp bmcgaXMgYW5ldz8NCg0KSSdsbCBjaGVjayB0aGF0IGFuZCBpZiB0aGUgc3RydWN0dXJlIGlzIGFs cmVhZHkgemVyb2VkIHRoZW4gSSdsbCByZW1vdmUgYm90aCB0aGUNCg0KYXNzaWdubWVudCBhbmQg dGhlIGNvbW1lbnQNCg0KPg0KPiBKYW4NCj4NClRoYW5rIHlvdSwNCg0KT2xla3NhbmRyDQo= From xen-devel-bounces@lists.xenproject.org Wed Sep 08 09:44:17 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Sep 2021 09:44:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.181589.328765 (Exim 4.92) (envelope-from ) id 1mNu7m-00066K-2q; Wed, 08 Sep 2021 09:44:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 181589.328765; Wed, 08 Sep 2021 09:44:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNu7l-00066D-VW; Wed, 08 Sep 2021 09:44:09 +0000 Received: by outflank-mailman (input) for mailman id 181589; Wed, 08 Sep 2021 09:44:08 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNu7j-000667-UA for xen-devel@lists.xenproject.org; Wed, 08 Sep 2021 09:44:07 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 4ecf7292-1089-11ec-b148-12813bfff9fa; Wed, 08 Sep 2021 09:44:06 +0000 (UTC) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04lp2058.outbound.protection.outlook.com [104.47.12.58]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-38-p9xAwkobOOqALHL89s1eNQ-1; Wed, 08 Sep 2021 11:44:04 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR04MB3295.eurprd04.prod.outlook.com (2603:10a6:802:f::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14; Wed, 8 Sep 2021 09:44:03 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4500.014; Wed, 8 Sep 2021 09:44:02 +0000 Received: from [10.156.60.236] (37.24.206.209) by PR0P264CA0068.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:1d::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.15 via Frontend Transport; Wed, 8 Sep 2021 09:44:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4ecf7292-1089-11ec-b148-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1631094245; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kYrUvTDOaeHXOQl4F+JcjOpNIyGdYKlDiKPxbowcl2Q=; b=feUUomu7lNjCrsNgveMuY2HAId1KSTSKsvN18F6z3MPJQv9RtHP2w9RkVvv7cp6VTCKyw8 NTRTEupg6LIkaKhZn+w8B75Xn3dFosjASbMPkeBFb6h6LB9UIBHUQRuR9PUbstKLIkAyS+ ixBKx5BKzR46tWvUrjQuoX0lulsaLNo= X-MC-Unique: p9xAwkobOOqALHL89s1eNQ-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YJzrp2WC8FcsRVS8SkRMENAVVyAVepLuQEYpi0uJq/6kBn/A58CkoIJG3FU2Ih1QGci+m2N7d9E39kblkCVpAhbIwc78e1V6odyOSR8mwNrPzko7DGr0Fpo3rM9lnBNQqp30e2sS9XT2iwQiHuh1wPXeX6cz2XGaWhlElchc1xMW707wazzOT0PqfZlqME9YcFfJWiJVKKJ2GYfuho4LVpoIzOreS8sft4RHzhDoxp2lbyPwe8ExAj4zeQqKC03oFuu0guFfG+Uz+Ir55gEUGPF5yEKeDE0pxKvN2AqpVu2jnwo7cFOHEGC4aU4+W9UvQFh8rzay2sovj90Zh1F1MA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=4/2nMHtwUkwOJeNn+c/1PSvVLkll4mq/pLnUB8brkF0=; b=TK4azVDcKoNqk8E2/AF/Nqek1lbq6kfowYhzQaSDjciL7rGFCp8jaZDCmWpuF5hA25QCGlNiZL8qEm3pYXc2EK581BKcp4bhFGPyxQHX+9rHNCLaXJ7jFS3QfB9X0quKEenvL2ZZmjDmf/4EmEjdeTumUIdj/G2WdXN+mgwyuAm0mBONrRj4kJXXVtBWCeFxhjp2LqqXl+tncTkKMs4GwYm7rkOWzMB51QFJMVZFnjb3oKyROu91xmrebvmZIO1iX6IvNIggbvheChJSJmAwmyOEC4joASdjndhHN4+MJxMhtv0w2HH4sSewcG9RLDMO+iqPhkC9SozLgWnRpaGByQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com; Subject: Re: [PATCH 07/17] IOMMU/x86: restrict IO-APIC mappings for PV Dom0 To: Andrew Cooper CC: Paul Durrant , "xen-devel@lists.xenproject.org" References: <5d6e8360-7ba8-487e-0ac8-7f517e560520@suse.com> <42aa8c24-7f23-deec-6103-f2d556e4a9f9@citrix.com> <3f9722e4-704b-8f68-553d-04a3a3189d99@citrix.com> From: Jan Beulich Message-ID: <48f43552-d657-2600-4503-2eb8626c114e@suse.com> Date: Wed, 8 Sep 2021 11:44:00 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: <3f9722e4-704b-8f68-553d-04a3a3189d99@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: PR0P264CA0068.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:1d::32) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9c9c3f30-2682-4ba7-965c-08d972ad30fb X-MS-TrafficTypeDiagnostic: VI1PR04MB3295: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Z6f2bVMSSQty+iXoyRJThmGihcrlm+t8aA2pMwzhLEQe8jONW1ZtdA6n7p8I1+sbcK7BTkzhgLcyKT+E2qHRxBH90PyHMHOOMVeRpm1Q9Ilm57lR6hst9MoGRD08cnzwg1fuqKbFSwDSo3QwSQXVPlTX9FV2p7Fzi/zlQSSZG7Bs0tWrkI2z7aIOhuGXr7TQ6DOiNfLajqz8MWFpnfYBO1hGifZiu2ghk7mlOI5WEIadgfio3116XPV6ebiEuj+wekxpIKM0C445ivi8RsuPNCiVxYg4NDqDPXknoIE4AKbhQopwP6+tW+jpvCCb0orL37k/mqzSrWHV6KH1g579fToUoW3QnTFseKjPgL4ZlyvZmpcIobz4vPSgpGnj1DUpqmlTmeol3ggimm7EqMBjgOgq59oHSMJ7xMu53UANHHyri8zCo8JKwkijrjcnwNQjUiddF7kT3xXcYeGVI8/l7hVWC/VOSfdXkYKrEVB9LPMWoZ4uG3uG0M+5BF9tgid5mTLx1q1dVkx+a4WcEjdv5YjE+Z0byyW4v1kwfzn+PdBN4AE7lfDIJkK+KeBa/18JQIqMFpLs9HBPuaXiRv+E1hzB/0EeAK+8NCErCmywvcGwBuuWJzAYq1FfL5a5xE6AoHl3wxQzUBOOqybqqDqIjKkJEOjRW14No/jsisiNcYsFU3AFkJObwcDJx3wrLtUbbuTowYnp5BNJ29yFQbEQUnmMydstocqWpSmDKg2MMK3dx7v6z4eMJwFq/V3aXJu0 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(39860400002)(376002)(346002)(136003)(366004)(396003)(6486002)(66946007)(66556008)(8676002)(478600001)(66476007)(8936002)(16576012)(186003)(5660300002)(26005)(53546011)(6916009)(316002)(83380400001)(2906002)(36756003)(86362001)(4326008)(956004)(2616005)(54906003)(31696002)(31686004)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?kWy3ul4G50CaOH1coO17a3tayFqEtOE5213/ciXaCzmjtHnhWoo4fS3fDnAh?= =?us-ascii?Q?4xi5EpAkw89Npwu9KiIkRNty55IQHvKL2N2dizfCY50klTryLaoQRAeX2xqC?= =?us-ascii?Q?6SOMRypl1OC8V+eipSBeXl5tm0Y4dy0HsWEKKjQVCVTiA2AyMtloRoLIyjd1?= =?us-ascii?Q?bgwXjZma1YG/3fHfMOOYSaMM+ysgZcux+bQ2xTYcyhJkvww0ILYE7yVBNaSh?= =?us-ascii?Q?FFupOutZV8O37vy3IutbSxvKxX+LicCgqnhgkqoXD7N4vpZmuDVgZna+q094?= =?us-ascii?Q?4kXMpScei1kIeVkgWTJCvDwBWuKHjxoNX7o7CWxSk112JziKJb582B+YdbPt?= =?us-ascii?Q?aoLQQokwopjy19f0l1FNR28et/ZQXmDFlwKjQMXuGKEcd4BK7i2pzhr61JjC?= =?us-ascii?Q?rz8oEyrdAEkNyjlPXyfBPBgqUuPSCx1qhFSfjSPSy2XyMfAMQ0k5okz2TZ9U?= =?us-ascii?Q?Ecm4jvrRxa/c98Am49kfdtWTCk+8M1m2YXiAC8aWfXnOF5lw5N4wA5s0EK/X?= =?us-ascii?Q?nx8rAj5tHRy7L/HON+ne6aPkTgMidTK2UdAuOQ5IuqkJRmHrnvA/6E+/KUJH?= =?us-ascii?Q?FNBDdvGWzdjdZDKTLYqlV/3yr5IO0hsz8L7l1Aq+0AbhrV1W1vUmyEPNZysP?= =?us-ascii?Q?mx0SZPFqJqkznH9lg9yBHZw1xgu3OtrFgEOgdnDoKb8rvtr4ui0EY4pjWKEd?= =?us-ascii?Q?TrbOd4fby2aAsEpBSVIz1CrYgx1jshvovgbQruDT+R/7iwciL9x7aVEeIP40?= =?us-ascii?Q?QOQeJ7DKULoA6PU79Zn8ycOZjzLQ4+d2TKJUR4xgH+o0KNtdZelLvRR5XmPS?= =?us-ascii?Q?PKzkVyVoXUAdq8rT2DC0K4cNL3bPjYPG6ptlm63yTLYEx+fcHCddpqH5UYkS?= =?us-ascii?Q?a+4W5EVFNCVWcR1Tnn9zSQ7SunjWOyuLtIt8JI/i4d8dfn64ArwJG2yJveTK?= =?us-ascii?Q?n6DZUobRtznEN9In4160nicoshpSWTLsZrrWkh46C9SdpYLVPDZ2QsmOQWeZ?= =?us-ascii?Q?0pAgj78To40BHVkzbRFFpZSOQwSdofk2cWTTEjj+nLGh38swEb5gCmy/H9oK?= =?us-ascii?Q?k5S+Rlh7/hNMtQJD0YNBxx3xvPhpvFpkeTWYfJSeIPtrx8F4+FEMzxqDxtkO?= =?us-ascii?Q?iB+Of2q1MfV2qkxGGmX8yt1KpWbqIZ7YY1lciCPiP2yHxKlWM7v1OspDuw3M?= =?us-ascii?Q?v60VivGNEqY7Z4tgD68jrbiuLxIWYW3RwFXKx6AdqFpixCOsL6imrFujfk4Y?= =?us-ascii?Q?nUCDgtTPT57jqIq66/GOTFkxK3ilLKbgOp5ojrURUlIDyWKRn0PmGQPQJHUg?= =?us-ascii?Q?xcfF1TiQrbdNRzxNseMt5VMK?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9c9c3f30-2682-4ba7-965c-08d972ad30fb X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Sep 2021 09:44:02.7618 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: KgGpkXU43xWi461PK6q93CfMyXXMXdtuRVt9vSnjyDIlnywiyC2gfmS70q0m0dbD3tj3jHgPnure0OebRW3O8A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB3295 On 07.09.2021 19:13, Andrew Cooper wrote: > On 26/08/2021 13:55, Jan Beulich wrote: >> On 26.08.2021 13:57, Andrew Cooper wrote: >>> On 24/08/2021 15:21, Jan Beulich wrote: >>>> While already the case for PVH, there's no reason to treat PV >>>> differently here, though of course the addresses get taken from anothe= r >>>> source in this case. Except that, to match CPU side mappings, by defau= lt >>>> we permit r/o ones. This then also means we now deal consistently with >>>> IO-APICs whose MMIO is or is not covered by E820 reserved regions. >>>> >>>> Signed-off-by: Jan Beulich >>> Why do we give PV dom0 a mapping of the IO-APIC?=C2=A0 Having thought a= bout >>> it, it cannot possibly be usable. >>> >>> IO-APICs use a indirect window, and Xen doesn't perform any >>> write-emulation (that I can see), so the guest can't even read the data >>> register and work out which register it represents.=C2=A0 It also can't= do an >>> atomic 64bit read across the index and data registers, as that is >>> explicitly undefined behaviour in the IO-APIC spec. >>> >>> On the other hand, we do have PHYSDEVOP_apic_{read,write} which, despit= e >>> the name, is for the IO-APIC not the LAPIC, and I bet these hypercalls >>> where introduced upon discovering that a read-only mapping of the >>> IO-APIC it totally useless. >>> >>> I think we can safely not expose the IO-APICs to PV dom0 at all, which >>> simplifies the memory handling further. >> The reason we do expose it r/o is that some ACPI implementations access >> (read and write) some RTEs from AML. If we don't allow Dom0 to map the >> IO-APIC, Dom0 will typically fail to boot on such systems. >=20 > I think more details are needed. How do you expect to collect the necessary info without having an affected system to test? I see close to zero chance to locate the old reports (and possible discussion) via web search. > If AML is reading the RTEs, it's is also writing to the index register. Quite likely, yes. Albeit this being broken to a fair degree in the first place, ... > Irrespective of Xen, doing this behind the back of the OS cannot work > safely, because at a minimum the ACPI interpreter would need to take the > ioapic lock, and I see no evidence of workarounds like this in Linux. ... as you indicate you think (as much as I do), leaves room for the actual accesses to also be flawed (and hence meaningless in the first place). I do recall looking at the disassembled AML back at the time, but I do not recall any details for sure. What I seem to vaguely recall is that their whole purpose was to set the mask bit in an RTE (I think to work around the dual routing issue, and I assume in turn to work around missing workarounds in certain OSes). For that the current approach as well as the alternative one you suggest below would be equally "good enough". > In Xen, we appear to swallow writes to mmio_ro ranges which is rude, and > causes the associated reads to read garbage.=C2=A0 This is Xen-induced me= mory > corruption inside dom0. >=20 >=20 > I don't think any of this is legitimate behaviour.=C2=A0 ACPI needs disab= ling > on such systems, or interlocking suitably, and its not just IO-APICs > which are problematic - any windowed I/O (e.g. RTC) as well as any other > device with read side effects. I don't think disabling ACPI on such systems would be a viable option. Things tend to not work very well that way ... Plus iirc these issues weren't exclusively on some random no-name systems, but in at least one of the cases on ones of a pretty large vendor. > I think we should seriously consider not mapping the IO-APIC at all.=C2= =A0 We can easily do so on the IOMMU side, if you agree to have CPU and IOMMU mappings diverge for this case. Since the behavior is PV- specific anyway, there are also no concerns as to differing behavior with vs without shared page tables (on PVH). > That said, I would be surprised if Linux is cleanly avoiding the > IO-APIC, so a slightly less bad alternative is to redirect to an "MMIO" > frame of ~0's which we still write-discard on top of. >=20 > That at least makes the Xen-induced memory corruption behave > deterministically. It would work more deterministically, yes, but without such a system available to test we wouldn't know whether that approach would actually make things work (sufficiently). Whereas for the current approach we do know (from the testing done back at the time). Jan From xen-devel-bounces@lists.xenproject.org Wed Sep 08 09:50:53 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Sep 2021 09:50:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.181603.328786 (Exim 4.92) (envelope-from ) id 1mNuEE-00089y-6l; Wed, 08 Sep 2021 09:50:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 181603.328786; Wed, 08 Sep 2021 09:50:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNuEE-00089r-3o; Wed, 08 Sep 2021 09:50:50 +0000 Received: by outflank-mailman (input) for mailman id 181603; Wed, 08 Sep 2021 09:50:49 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNuED-00089h-9O; Wed, 08 Sep 2021 09:50:49 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNuEC-0001TN-VT; Wed, 08 Sep 2021 09:50:48 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNuEC-0005e0-Ly; Wed, 08 Sep 2021 09:50:48 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mNuEC-0006Sj-LQ; Wed, 08 Sep 2021 09:50:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=jxv4/VF0rSRpr8nxrdNXoK4ReTaCqegR0vpgtk6im0g=; b=zV9wbBfYnpvqYSHYsZDN9z2xcF xF2/9Tl+BHjk4z23mVzBV7w3c3G3Se4H7ewE6DEfxnv6AdKgyqF+R8Rn0GZYJLs+7YapdbNVb6TUX BRLz4Ne9OpZ0jZ15LsrqePbf37+wff4GW3qF+K/kIj/sKL0YyX/JzcunlpIdMUjnqQRg=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-coverity test] 164882: all pass - PUSHED X-Osstest-Versions-This: xen=e70a9a043a5ce6d4025420f729bc473f711bf5d1 X-Osstest-Versions-That: xen=2d4978ead4b98452bc45ebe47952e524b12e2b41 From: osstest service owner Date: Wed, 08 Sep 2021 09:50:48 +0000 flight 164882 xen-unstable-coverity real [real] http://logs.test-lab.xenproject.org/osstest/logs/164882/ Perfect :-) All tests in this flight passed as required version targeted for testing: xen e70a9a043a5ce6d4025420f729bc473f711bf5d1 baseline version: xen 2d4978ead4b98452bc45ebe47952e524b12e2b41 Last test of basis 164827 2021-09-05 09:18:31 Z 3 days Testing same since 164882 2021-09-08 09:18:32 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Anthony PERARD Jan Beulich Jane Malalane Julien Grall Michal Orzel Wei Liu jobs: coverity-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 2d4978ead4..e70a9a043a e70a9a043a5ce6d4025420f729bc473f711bf5d1 -> coverity-tested/smoke From xen-devel-bounces@lists.xenproject.org Wed Sep 08 09:54:19 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Sep 2021 09:54:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.181610.328801 (Exim 4.92) (envelope-from ) id 1mNuHa-0000bp-Nh; Wed, 08 Sep 2021 09:54:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 181610.328801; Wed, 08 Sep 2021 09:54:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNuHa-0000bi-KL; Wed, 08 Sep 2021 09:54:18 +0000 Received: by outflank-mailman (input) for mailman id 181610; Wed, 08 Sep 2021 09:54:17 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNuHZ-0000bc-I7 for xen-devel@lists.xenproject.org; Wed, 08 Sep 2021 09:54:17 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (unknown [40.107.20.49]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id b7b15bec-2067-4a9e-95f2-30d0d984b939; Wed, 08 Sep 2021 09:54:14 +0000 (UTC) Received: from AM5PR0701CA0057.eurprd07.prod.outlook.com (2603:10a6:203:2::19) by AM4PR08MB2884.eurprd08.prod.outlook.com (2603:10a6:205:e::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14; Wed, 8 Sep 2021 09:54:13 +0000 Received: from VE1EUR03FT014.eop-EUR03.prod.protection.outlook.com (2603:10a6:203:2:cafe::f6) by AM5PR0701CA0057.outlook.office365.com (2603:10a6:203:2::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4523.8 via Frontend Transport; Wed, 8 Sep 2021 09:54:13 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT014.mail.protection.outlook.com (10.152.19.38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Wed, 8 Sep 2021 09:54:12 +0000 Received: ("Tessian outbound 7a08471b1ef6:v105"); Wed, 08 Sep 2021 09:54:12 +0000 Received: from f9cb34ce38a9.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id E3D35D93-00F2-4BFD-944C-AECC6C0EEA11.1; Wed, 08 Sep 2021 09:54:06 +0000 Received: from EUR02-AM5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id f9cb34ce38a9.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 08 Sep 2021 09:54:06 +0000 Received: from AM0PR10CA0063.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:208:15::16) by VI1PR0801MB2110.eurprd08.prod.outlook.com (2603:10a6:800:88::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.25; Wed, 8 Sep 2021 09:54:05 +0000 Received: from VE1EUR03FT008.eop-EUR03.prod.protection.outlook.com (2603:10a6:208:15:cafe::2b) by AM0PR10CA0063.outlook.office365.com (2603:10a6:208:15::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14 via Frontend Transport; Wed, 8 Sep 2021 09:54:05 +0000 Received: from nebula.arm.com (40.67.248.234) by VE1EUR03FT008.mail.protection.outlook.com (10.152.18.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.4478.19 via Frontend Transport; Wed, 8 Sep 2021 09:54:05 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.14; Wed, 8 Sep 2021 09:54:08 +0000 Received: from penny.shanghai.arm.com (10.169.190.66) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2308.14 via Frontend Transport; Wed, 8 Sep 2021 09:54:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b7b15bec-2067-4a9e-95f2-30d0d984b939 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=atD+jn23OE3UfPIAVyiiv0CU9p/Xc0KpqFQDOZmE+ro=; b=xDzMJJMeRGJQCDwVvReAfHVMVZWV5kkt1k/IaREBFsU0uWfazkma23ZCFC+VLoAvBjVEFTHThicE7LUMUoSNItl+eKZSMVAe9OBlpcz1iAJ91ZNiTIWzPv7OdBuBwHCKsD7z4IVhaJuc5kr0kj03Dxbl+1uL+FaghgWwjGdKwOE= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: d66a6ad96b4563a5 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cs5964ruU/zXdVU2Oti8ZONkQoqxdfDsQ+Ad4dLFvz2eAtl4pgTmcOLaso7sj9c3sbBOFcGrie54bNiuF2TJ5pD1vRikS3RlmZEUBMjuz2POHlb8YHXryV4E5UkcUUq9wwIG5ylvNC/biNvCacVz5aqtFrQiGEbxrjc80xFjeBNE+JmlGPjGzDBGUsIcWGijeJE9dQFoZkADAhTdOQMzHNDOOULJmOiuQuGdagP1koNzi4X/sUt41+iy8Dv0u7YBbtDNROsm4DZim33kY0IeMu2nq+CXC7saPIzkuRunhZgg8wY75B/bNsfW6Mpu6H49YtcVGdsoUZv+d0VfMXcfIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=atD+jn23OE3UfPIAVyiiv0CU9p/Xc0KpqFQDOZmE+ro=; b=UNrFUXPtXXZnq8HhBCkoJokrXzibv+rbk8wPPYZXDvDTQh+SUQOhstHSKVNshg5L+um69/b+DMelqE92erxWyl70ukq7jK3mfO6BRb3lTasxk/F8yg96ph/HHHgjP+Ky8y4YsF2P1QgqpbAZSnMOr9dMr7n1qhBjWOtt/1F2P+vqeylPDG8jQgfgy16QlGOQiBf/4P7f0vBgfPUT77gV2TtUWxFx+K3EN+5Rnoty0BYM/82His+M9No2oq+TPcX2NhnMI0p+gtE89/K6P6AG41LPXKOtkmmR30JM8rpBLLUw8UrgWDGaZDWs3oziWXs7bosBGAP5xdffFhVwl/N9yA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=atD+jn23OE3UfPIAVyiiv0CU9p/Xc0KpqFQDOZmE+ro=; b=xDzMJJMeRGJQCDwVvReAfHVMVZWV5kkt1k/IaREBFsU0uWfazkma23ZCFC+VLoAvBjVEFTHThicE7LUMUoSNItl+eKZSMVAe9OBlpcz1iAJ91ZNiTIWzPv7OdBuBwHCKsD7z4IVhaJuc5kr0kj03Dxbl+1uL+FaghgWwjGdKwOE= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; From: Penny Zheng To: , , CC: , , Subject: [PATCH v6 1/7] xen/arm: introduce new helper device_tree_get_meminfo Date: Wed, 8 Sep 2021 09:52:42 +0000 Message-ID: <20210908095248.545981-2-penny.zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210908095248.545981-1-penny.zheng@arm.com> References: <20210908095248.545981-1-penny.zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8ea29876-98fb-4e87-885c-08d972ae9cae X-MS-TrafficTypeDiagnostic: VI1PR0801MB2110:|AM4PR08MB2884: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:41;OLM:41; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: GKdMi4ctUd5Xo6YEnZLv4p3v89P/yqnvqJ6+XsyQ6aBjkV3uPeh9BZe4vMYtc5Naum4aPMkRtLp5JoIGUlRFvEG/1poEW1Jwwjlj+e6pOUbajb5zoLKlztI+gxxdph58fZkcG8yUyhFqhNainvmMNExqUpWarbA/3cXBgo7zLE8z49xvQ4QzLlzIqbxNwCy0HtQ/SoHL3RxOC4XgXBrZ6p46Vg78RoXywPOHzvsJA/IiOPu8S5YVYwjHjrSh+GRLgA51Jsn3WkdiV0g3fH9Hv6S4zLpBVg8eg6Czvokwd46t+cmtBzFlucV8W+i6JJeq4hB8zC2oLoK2q3rmviSbzOprJ6LlBTFoMhIlmi5CwUDmOAPf1lIX3QlkZ5u/IuSznqukeFW80wXfQ4lOe2UDEnw4RmbTtARUhFo3KhkRmir4zDdVXSKbL9jztG0YVdQdwkfIwkP1ngJNGxHz/2Ahv87osJA9jmgQNOxV70P4N1ZDD55aZcyyRjN3jVtRUIQzjYu+FE8GQ/6rIdP+AgOkmkU2aofwXcBMrjdFNQOfJDQdl6c1BM/IoVqBmoh9KvI60d4qc266hcU7zli7WKKsjVD438ZGWVNVxKLLzC6nd6Tjp7mf8NWolpRHsSUBbrexKO8c4x0lSvhFj0pxii9ZjA5eqauWsJvH8Azhxg+mK+Ww9TWxz5oslGTbuBEDgwKTKB7Psr7dP/Ah5aBTzjpvZILETyYvxTz9PrFTCK9gnyA= X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(4636009)(136003)(396003)(39860400002)(376002)(346002)(36840700001)(46966006)(5660300002)(2906002)(336012)(478600001)(2616005)(7696005)(316002)(86362001)(47076005)(83380400001)(36756003)(6666004)(26005)(81166007)(82310400003)(1076003)(44832011)(8676002)(82740400003)(4326008)(426003)(110136005)(36860700001)(70206006)(70586007)(8936002)(54906003)(356005)(186003)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0801MB2110 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT014.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: a22bcb71-7aec-41fa-0708-08d972ae981d X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4YCmS1+/kYlhRhk0d0qPdxTIYUZkNOq+LhvbJQPjFpoP/PK3JqfOqQ5X/A0anWOmlhiXB8FgeuT+AxOd9Nxh3Iv5jpbx/NEl3ay8wcehhyWpx6CZ8tPYnvqNZCapMEebc6IzCSpy6enV03j+tWKEbx0fQiSf1kKKBu2uRhMb9DILiYK5RZrvuFmek4JK2YOEHet2gib97doolQWaU3pT/jf6ah+XnWPZRUvxHunu2phfNW8W5n8KqHvNMgSQFxgT4XY8gqDg1aSUviCV0K/X1mSF3MhWOeQxei8YvIniEE0d7H8KAnMgQ75RiiGswYZI2PPAPZwuARwwMkWWb1QgpvsCYunitHgZjhCoqi0BnYgOWSktVjhLgGnHwa4v8xtCZykzNPDkmz/b8KW9X2LNfM3p0fPI+Ou4EjGSAkxd1bC07hNvbY6j5biyDQt95QvuJeipeEbtoxChYItvyg0R7JdS53cdAnVy90vQISVRDP5xFwfWmBA+N2WIkQWqm6udpRvK6oaaOraKusANoQ4mWqODhVrr50qWD79yk90B4cMtpWp3AStgGGlDprzzOdTJoY7URX73WQZfYjGLCK7I2xxzo+9LgIS2W1rQVJOvxMt51U8599bi0HmsyALmF6WetZrQJSBi6zqmtSV13lHeHiRlAI/OyiF9iAPGvLwUgBKSOwXCoEprhimzBmJRso5e2yGtsyUUyVkJ2FSyKFxCzw== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(136003)(376002)(346002)(396003)(39860400002)(46966006)(36840700001)(7696005)(2906002)(82310400003)(86362001)(5660300002)(8676002)(478600001)(70206006)(70586007)(26005)(186003)(47076005)(36860700001)(336012)(8936002)(54906003)(1076003)(316002)(6666004)(2616005)(44832011)(82740400003)(36756003)(83380400001)(4326008)(110136005)(107886003)(81166007)(426003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Sep 2021 09:54:12.7096 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8ea29876-98fb-4e87-885c-08d972ae9cae X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT014.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR08MB2884 This commit creates a new helper device_tree_get_meminfo to iterate over a device tree property to get memory info, like "reg". Signed-off-by: Penny Zheng --- xen/arch/arm/bootfdt.c | 83 ++++++++++++++++++++++++------------------ 1 file changed, 47 insertions(+), 36 deletions(-) diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c index 476e32e0f5..b01badda3e 100644 --- a/xen/arch/arm/bootfdt.c +++ b/xen/arch/arm/bootfdt.c @@ -63,6 +63,52 @@ void __init device_tree_get_reg(const __be32 **cell, u32 address_cells, *size = dt_next_cell(size_cells, cell); } +static int __init device_tree_get_meminfo(const void *fdt, int node, + const char *prop_name, + u32 address_cells, u32 size_cells, + void *data) +{ + const struct fdt_property *prop; + unsigned int i, banks; + const __be32 *cell; + u32 reg_cells = address_cells + size_cells; + paddr_t start, size; + struct meminfo *mem = data; + + if ( address_cells < 1 || size_cells < 1 ) + { + printk("fdt: property `%s': invalid #address-cells or #size-cells", + prop_name); + return -EINVAL; + } + + prop = fdt_get_property(fdt, node, prop_name, NULL); + if ( !prop ) + return -ENOENT; + + cell = (const __be32 *)prop->data; + banks = fdt32_to_cpu(prop->len) / (reg_cells * sizeof (u32)); + + for ( i = 0; i < banks && mem->nr_banks < NR_MEM_BANKS; i++ ) + { + device_tree_get_reg(&cell, address_cells, size_cells, &start, &size); + /* Some DT may describe empty bank, ignore them */ + if ( !size ) + continue; + mem->bank[mem->nr_banks].start = start; + mem->bank[mem->nr_banks].size = size; + mem->nr_banks++; + } + + if ( i < banks ) + { + printk("Warning: Max number of supported memory regions reached.\n"); + return -ENOSPC; + } + + return 0; +} + u32 __init device_tree_get_u32(const void *fdt, int node, const char *prop_name, u32 dflt) { @@ -139,42 +185,7 @@ static int __init process_memory_node(const void *fdt, int node, u32 address_cells, u32 size_cells, void *data) { - const struct fdt_property *prop; - int i; - int banks; - const __be32 *cell; - paddr_t start, size; - u32 reg_cells = address_cells + size_cells; - struct meminfo *mem = data; - - if ( address_cells < 1 || size_cells < 1 ) - { - printk("fdt: node `%s': invalid #address-cells or #size-cells", - name); - return -EINVAL; - } - - prop = fdt_get_property(fdt, node, "reg", NULL); - if ( !prop ) - return -ENOENT; - - cell = (const __be32 *)prop->data; - banks = fdt32_to_cpu(prop->len) / (reg_cells * sizeof (u32)); - - for ( i = 0; i < banks && mem->nr_banks < NR_MEM_BANKS; i++ ) - { - device_tree_get_reg(&cell, address_cells, size_cells, &start, &size); - /* Some DT may describe empty bank, ignore them */ - if ( !size ) - continue; - mem->bank[mem->nr_banks].start = start; - mem->bank[mem->nr_banks].size = size; - mem->nr_banks++; - } - - if ( i < banks ) - return -ENOSPC; - return 0; + return device_tree_get_meminfo(fdt, node, "reg", address_cells, size_cells, data); } static int __init process_reserved_memory_node(const void *fdt, int node, -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Wed Sep 08 09:54:24 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Sep 2021 09:54:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.181611.328812 (Exim 4.92) (envelope-from ) id 1mNuHg-0000to-0r; Wed, 08 Sep 2021 09:54:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 181611.328812; Wed, 08 Sep 2021 09:54:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNuHf-0000tf-TX; Wed, 08 Sep 2021 09:54:23 +0000 Received: by outflank-mailman (input) for mailman id 181611; Wed, 08 Sep 2021 09:54:22 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNuHe-0000bc-Ge for xen-devel@lists.xenproject.org; Wed, 08 Sep 2021 09:54:22 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (unknown [40.107.21.79]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id e8f14c5b-4e24-4dad-9847-be994e9b4b79; Wed, 08 Sep 2021 09:54:15 +0000 (UTC) Received: from PR2P264CA0033.FRAP264.PROD.OUTLOOK.COM (2603:10a6:101:1::21) by DB9PR08MB6764.eurprd08.prod.outlook.com (2603:10a6:10:2ac::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.22; Wed, 8 Sep 2021 09:54:13 +0000 Received: from VE1EUR03FT039.eop-EUR03.prod.protection.outlook.com (2603:10a6:101:1:cafe::dd) by PR2P264CA0033.outlook.office365.com (2603:10a6:101:1::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14 via Frontend Transport; Wed, 8 Sep 2021 09:54:13 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT039.mail.protection.outlook.com (10.152.19.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Wed, 8 Sep 2021 09:54:12 +0000 Received: ("Tessian outbound 610b9df843d5:v105"); Wed, 08 Sep 2021 09:54:12 +0000 Received: from 056c89f01e9d.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id B14FAD12-741A-4612-B01D-4FCB12450E7A.1; Wed, 08 Sep 2021 09:54:05 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 056c89f01e9d.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 08 Sep 2021 09:54:05 +0000 Received: from AM0PR10CA0068.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:208:15::21) by AM6PR08MB3320.eurprd08.prod.outlook.com (2603:10a6:209:48::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.22; Wed, 8 Sep 2021 09:54:03 +0000 Received: from VE1EUR03FT008.eop-EUR03.prod.protection.outlook.com (2603:10a6:208:15:cafe::77) by AM0PR10CA0068.outlook.office365.com (2603:10a6:208:15::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14 via Frontend Transport; Wed, 8 Sep 2021 09:54:03 +0000 Received: from nebula.arm.com (40.67.248.234) by VE1EUR03FT008.mail.protection.outlook.com (10.152.18.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.4478.19 via Frontend Transport; Wed, 8 Sep 2021 09:54:02 +0000 Received: from AZ-NEU-EX01.Emea.Arm.com (10.251.26.4) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2308.14; Wed, 8 Sep 2021 09:54:06 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX01.Emea.Arm.com (10.251.26.4) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14; Wed, 8 Sep 2021 09:53:59 +0000 Received: from penny.shanghai.arm.com (10.169.190.66) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2308.14 via Frontend Transport; Wed, 8 Sep 2021 09:54:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e8f14c5b-4e24-4dad-9847-be994e9b4b79 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CBX0PwkTMiWyE/sx14ufn9c6BIC7mzVQZNMew7fmruw=; b=dHHcxkEsvmGks+u0JkP1kgCfQlkBHAJ8kkcLl+b8SEW+z+36LAq4PdpLdvXi02nQjyNn/+LnIZ/1eD+TWaiDYuQaZL5w3TqDy2cNBDGHCUYTn3UTbUARFzpCXi1qS4sUNtLoPBGGKO9WAeWvOhfR0tkDhDpxv04wC8gZ8Nuw0zA= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: 6b671d2233b8a19d X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Six+12KXp1VJDlKtrW44SuymfQWgEU0qInacgt+tj1d3qoytge2Hmq1cECUcfnmMtrBgh3Og3PEcNCoY9MAlI3OQJgDRO+tCjqFX/Jt1iORS1Uj2Am9NrwoS8h0ktQ3cxCkbpWaZP/Dr3YGJtgLMwDMB4CF8/WlBSL6FMsf6Z1vuHfaSRn/QOsmwcd3EuuXJZF3ryJh+VJ/zq7sejM4hBXrQgazzy48VkXD3V1PJOR8Tsdhfd+vgFHb1QoURSSmtfw69QZVXUqY4Buew1hPRdMmczs1kvw1Z/1nHs8WXGPnQ42cIIc+Q30z0g2T0DPQi5DC/FXEm4nAYCXhBxC4wxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=CBX0PwkTMiWyE/sx14ufn9c6BIC7mzVQZNMew7fmruw=; b=XgE+mXKkiSptOrvI33nM+Q7uHd+Cc1TWGLTwMretKSUi9wKK9dG1+UKQnVxILXtzLGfwh+Zk7aCToAVOvzSye4f7B6EtTP//1F2cFWm/X/nzfce0njI1XvKAK2/h1pxbXpy3pn/6wGVuH7bj+/u4BmZpveFYXD42oscMxo7J01DOI+NamLekCwJhDOiL353ly3yuCy2BqMIHeHPQPVRNNqYpLnXpqF4jQOnRdW0REFQfH/r7OpQfYZYf/AnyL7k+2/jjd9SSabKO9WunoX2oH1gwjjXT6vfnE+jon96xs9s+jUr5JYeVPmWmSx2HYs3yEFTH42xDGH+U6y7TnEy8yA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CBX0PwkTMiWyE/sx14ufn9c6BIC7mzVQZNMew7fmruw=; b=dHHcxkEsvmGks+u0JkP1kgCfQlkBHAJ8kkcLl+b8SEW+z+36LAq4PdpLdvXi02nQjyNn/+LnIZ/1eD+TWaiDYuQaZL5w3TqDy2cNBDGHCUYTn3UTbUARFzpCXi1qS4sUNtLoPBGGKO9WAeWvOhfR0tkDhDpxv04wC8gZ8Nuw0zA= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; From: Penny Zheng To: , , CC: , , Subject: [PATCH v6 0/7] Domain on Static Allocation Date: Wed, 8 Sep 2021 09:52:41 +0000 Message-ID: <20210908095248.545981-1-penny.zheng@arm.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8c073a9a-1d55-4a52-4e90-08d972ae9cb3 X-MS-TrafficTypeDiagnostic: AM6PR08MB3320:|DB9PR08MB6764: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:7219;OLM:7219; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: qTqc/3a0/Vhag0ux6FztrgpkVCRp2tU8xpeBnXGqESCqDP2sQgL2iRt4c0aYDBOXbpsnVedMawd6PVFAIlsvCHS4zOhWAcFL7VQ0VZujJllM9Sw05m7cEV+UfXKGsjaUysOwRhiyVRh1huDZxrACy9RGxoQH0blcZFO8Bket4XEBwZyYE3t6iJMva5GRVUPwU/ixPYwHAot4+/lh83k6vBOEp5E6QRkcY7ujYdflSq+oNc8l7wB1tEgTgvKe0nne5Uu1/kQ5dEPao/MRL7Ov7Bwcfh4XWHW2itAyWY68wMk6qnAa07QFFwYFtczXU17OsFr2ziy0QB+ZSd0hIEv9OF7mApQDHnH6ff1yTc3mJnleTA3SFMuJqCTQkrsDgXrXol/2/BX/8Hso9lOngqJmngxf8ND+x/FmDxqxG4YcLp7y37K2/YRCy/5C/Ssle8Pw2QpNtnHXUSvUmNglwA9bXAhn71dk1jRdcbJni3n9r9OJTvDePdRTafIWNSq3pAGuB3q1BO8cYSpAK4QEJka0CSogryMjJxL2FKbVHCno/mOhgAZNUDYsrsNJRKSuOvUXwNTWvWFvTUfYDkoeDZFNiW6T3AWal4RS/Z982hgWISleczqmSuQsewPccg4+H1dQ8vtRnB5LUMhsc46/6QZJgP3OBXTkxtGqZ97HAiQA4uy7uCLTryZjYbUJNehYlnMxuZtUFfuWnzE1EJ2tc1ak8vx2Ovw2xjYAas/Mudidxry9n77t89I1Y+uerM3n1JacblQSlvzN14x61RQ/MLf+elE7voeIykDshHV0IXTa5e3ATvfeWkusaHZJqu4P48Ec X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(4636009)(39860400002)(346002)(376002)(396003)(136003)(36840700001)(46966006)(82740400003)(110136005)(316002)(36860700001)(1076003)(47076005)(83380400001)(86362001)(44832011)(82310400003)(8676002)(4326008)(2906002)(2616005)(26005)(6666004)(36756003)(426003)(356005)(478600001)(8936002)(336012)(5660300002)(81166007)(70206006)(186003)(966005)(7696005)(54906003)(70586007)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3320 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT039.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 2a4a8db5-15e9-46d1-4ada-08d972ae96dc X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +UceenRdIteWWyKgdXjzXFzrESqBDbVvbbaOqs55uhGqTqEFO6HuQRzMqcJPsA31eArXJSE8xIqkOdn5Wc9+RFxFR/P2xFkj2gzKbW6rxTYelEVBMBiQxXTVuIkmd9pI5iBK+B7LKAleuu9Aq22f0RowjY/HRdd4H5g3sVV3KvObIB45QXDZo6iTd21Bbf7/u1AUcePCJY7d1sJDTlD0EEPI7XgyAFjzTdKFuTwnSDmHC1IvfYQqB+RCjEsCQe6uTM28LWTnePxoKSbeA9NyklhLhD9G2Tq2DFhOGoqN2MDMzvjykysD2vJTaXTIFJZ4bh/DQF4uSjPkXmKdaxNgG0issV/lvmDOVsCin2c9fpY/wJy4RflbVJUmjR1VWGlUjD5hI8oViYujf+bEXKBX0Thf/rdDzUXhIr2kYUFa5cKzULDcvHDCeulASboXzaKliHInHxjv132KLM4U5ddAM5rLTssTCVh7dwGXzHlivOXpy30+cQzO99ytl6P9iVsMCbobdXGI+zdyjwqIZQrxBHBXjpQpJZFgJN3Jeo2l+CeE+MAao5IDRSoyMeMaEmDcGm1a2OIGYlmrcRXbCb3Um2DTEMR0COqfcU45rmi0HdZPn7ZONr79OQ9+keedb1THAF7ZpxQyYxgomAjDlyRjMBCulRprP4kp62WFlD7lMuXGGyfOSk5ep686BqkioNW80AAlbv17mpLIIgjFbweHq4QmV3VCTiAvdMT3Ek+ByTZv+RYWNl85l0SGHmYfF4RauwEzxUKL95A8wvNynQdxavMs/DSgZL4qpmDvhPdkywY= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(346002)(376002)(396003)(39860400002)(136003)(36840700001)(46966006)(44832011)(82740400003)(26005)(4326008)(36756003)(426003)(36860700001)(186003)(70206006)(70586007)(110136005)(6666004)(54906003)(336012)(316002)(86362001)(107886003)(8676002)(5660300002)(7696005)(81166007)(2616005)(2906002)(47076005)(83380400001)(478600001)(82310400003)(8936002)(966005)(1076003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Sep 2021 09:54:12.7089 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8c073a9a-1d55-4a52-4e90-08d972ae9cb3 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT039.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB6764 Static Allocation refers to system or sub-system(domains) for which memory areas are pre-defined by configuration using physical address ranges. Those pre-defined memory, -- Static Memory, as parts of RAM reserved in the beginning, shall never go to heap allocator or boot allocator for any use. Memory can be statically allocated to a domain using the property "xen,static- mem" defined in the domain configuration. The number of cells for the address and the size must be defined using respectively the properties "#xen,static-mem-address-cells" and "#xen,static-mem-size-cells". The property 'memory' is still needed and should match the amount of memory given to the guest. Currently, it either comes from static memory or lets Xen allocate from heap. *Mixing* is not supported. The static memory will be mapped in the guest at the usual guest memory addresses (GUEST_RAM0_BASE, GUEST_RAM1_BASE) defined by xen/include/public/arch-arm.h. This Patch Serie only talks about Domain on Static Allocation. Looking into related [design link]( https://lists.xenproject.org/archives/html/xen-devel/2021-05/msg00882.html) for more details. The whole design is about Static Allocation and 1:1 direct-map, and this Patch Serie only covers parts of it, which are Domain on Static Allocation. Other features will be delievered through different patch series. --- changes in v2: - consider reserved-memory binding and use phandle to refer(still in discussion) - remove unused reserved field in struct page_info, unused helper page_get_reserved_owner and page_set_reserved_owner - introduce CONFIG_STATIC_ALLOCATION to avoid bringing dead codes in other archs. - extract common code from free_heap_pages and free_staticmem_pages - introduce new interface assign_pages_nr - change pfn-named to mfn-named - remove meaningless MEMF_no_owner case - leave zone concept out of DMA limitation check - take care of concurrency issue on static memory allocation - ensure the consistency when `xen,static-mem` and `memory` are both defined - fix the scalability issue in allocate_static_memory - allocate static memory when parse --- changes in v3: - use "xen,static-mem" property to be compatible with System Sevice Tree in the future - introduce new helper device_tree_get_meminfo - extract common codes for dealing with reserved memory stored in bootinfo - rename from "free_page" to "mark_page_free" - remove non-trivial page_to_mfn conversion in "mark_page_free" due to pdx compression, and let the MFN passed in - let all switch-cases shared in "mark_page_free" - change CONFIG_STATIC_ALLOCATION to CONFIG_STATIC_MEMORY - put init_staticmem_pages in setup_mm - rename assign_pages_nr to assign_pages - alter the order of assign_pages parameters to help backporting - change name from alloc_staticmem_pages/alloc_domstatic_pages to acquire_staticmem_pages and acquire_domstatic_pages. - remove hunks' #ifdef-ary by introducing PGC_reserved = 0 - remove DMA restriction - "memory" property shall be mandatory - rename allocate_static_bank_memory to append_static_memory_to_bank - infer the next GFN from the bank information in append_static_memory_to_bank - simplify the code of double loop in allocate_static_memory --- changes in v4: - move the option CONFIG_STATIC_MEMORY to common code, and with Arm "select"ing it - replace round_pg{down,up}() with PFN_DOWN()/PFN_UP() - in all cases where order-0 pages get passed, prefer using new assign_pages to pass literal 1 - reconstruct the order of assign_pages parameters - moving tlb/cache flush outside of the locked region, considering XSA-364 and reducing the amount of work happening with the heap_lock held - remove MEMF_no_refcount case - make acquire_staticmem_pages/acquire_domstatic_pages being __init --- changes in v5: - check the node using the Xen domain binding whether contains the property "xen,static-mem", not the property itself - add "rc = ..." to get the error propagated - introduce new field "bool xen_domain", then static memory shall be also stored as reserved memory(bootinfo.reserved_mem), but being bind to one specific Xen domain node. - make CONFIG_STATIC_MEMORY user selectable and gated by UNSUPPORTED. - wrap all static-allocation-related codes with CONFIG_STATIC_MEMORY even in arm-specific file. - make bank_start/bank_end type of mfn_t, and rename bank_size to bank_pages. - Having both functions assign_pages/assign_page with similar parameter arrangement - bundle all the functions for static allocation in a single place - return an error and revert the changes, when the page is not free and reserved. - check the MFN is valid for every page and also add a comment to warn that this function needs to be reworked if used outside of boot. - use less of mfn_to_page/page_to_mfn - use ASSERT_UNREACHABLE() to also check that the two flags are clear - pass the start MFN first and then the number of pages in both acquire_staticmem_pages and acquire_domstatic_pages - make acquire_domstatic_pages() to return an errno - don't split comment over multi-line (even they are more than 80 characters) - simply use dt_find_property(node, "xen,static-mem", NULL) to tell whether using allocate_static_memory, and add error comment when "xen,static-mem" is used but CONFIG_STATIC_MEMORY is not enabled. - exporting p2m_insert_mapping() and introduce guest_physmap_add_pages to cope with adding guest RAM p2m mapping with nr_pages. - check both pbase and psize are page aligned - simplify the code in the loops by moving append_static_memory_to_bank() outside of the if/else. --- change v6: - move address_cells and size_cells check into device_tree_get_meminfo - doc and comment refinement - indentation, and the kconfig message fix - let assign_page have a different order for the arguments, not assign_pages - fix variable declaration and some format - use PFN_DOWN(...) - provide a stub allocate_static_memory implementation for !CONFIG_STATIC_MEMORY - add a statement to clarify the binding between the "memory" property and "xen,static-mem" --- TODO: - reboot domain on static allocation - Implement all memory-ops(hypercalls) regarding domain on static allocation to balloon in/out memory - asynchronously scrubbing PGC_reserved pages Penny Zheng (7): xen/arm: introduce new helper device_tree_get_meminfo xen/arm: introduce domain on Static Allocation xen: introduce mark_page_free xen/arm: static memory initialization xen: re-define assign_pages and introduce a new function assign_page xen/arm: introduce acquire_staticmem_pages and acquire_domstatic_pages xen/arm: introduce allocate_static_memory docs/misc/arm/device-tree/booting.txt | 39 ++++ xen/arch/arm/bootfdt.c | 108 +++++++---- xen/arch/arm/domain_build.c | 160 ++++++++++++++++- xen/arch/arm/p2m.c | 7 +- xen/arch/arm/setup.c | 27 +++ xen/arch/x86/pv/dom0_build.c | 2 +- xen/common/Kconfig | 13 ++ xen/common/grant_table.c | 2 +- xen/common/memory.c | 6 +- xen/common/page_alloc.c | 249 ++++++++++++++++++++------ xen/include/asm-arm/mm.h | 3 + xen/include/asm-arm/p2m.h | 11 ++ xen/include/asm-arm/setup.h | 1 + xen/include/xen/mm.h | 14 ++ 14 files changed, 544 insertions(+), 98 deletions(-) -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Wed Sep 08 09:54:28 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Sep 2021 09:54:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.181612.328822 (Exim 4.92) (envelope-from ) id 1mNuHk-0001Ep-EE; Wed, 08 Sep 2021 09:54:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 181612.328822; Wed, 08 Sep 2021 09:54:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNuHk-0001Eg-Ae; Wed, 08 Sep 2021 09:54:28 +0000 Received: by outflank-mailman (input) for mailman id 181612; Wed, 08 Sep 2021 09:54:27 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNuHj-0000bc-Gg for xen-devel@lists.xenproject.org; Wed, 08 Sep 2021 09:54:27 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (unknown [40.107.20.66]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 710e629f-b153-4d48-945e-6e5213475b1e; Wed, 08 Sep 2021 09:54:19 +0000 (UTC) Received: from AM5PR0701CA0002.eurprd07.prod.outlook.com (2603:10a6:203:51::12) by AM6PR08MB4504.eurprd08.prod.outlook.com (2603:10a6:20b:bd::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.20; Wed, 8 Sep 2021 09:54:16 +0000 Received: from VE1EUR03FT052.eop-EUR03.prod.protection.outlook.com (2603:10a6:203:51:cafe::80) by AM5PR0701CA0002.outlook.office365.com (2603:10a6:203:51::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.6 via Frontend Transport; Wed, 8 Sep 2021 09:54:16 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT052.mail.protection.outlook.com (10.152.19.173) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Wed, 8 Sep 2021 09:54:16 +0000 Received: ("Tessian outbound b48d04bf8afd:v105"); Wed, 08 Sep 2021 09:54:15 +0000 Received: from c44f5e52554f.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 51AD65E1-3B5B-43CE-846D-6B3460ACD56B.1; Wed, 08 Sep 2021 09:54:09 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id c44f5e52554f.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 08 Sep 2021 09:54:09 +0000 Received: from AM6PR01CA0048.eurprd01.prod.exchangelabs.com (2603:10a6:20b:e0::25) by AM8PR08MB6611.eurprd08.prod.outlook.com (2603:10a6:20b:36b::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.22; Wed, 8 Sep 2021 09:54:08 +0000 Received: from VE1EUR03FT055.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:e0:cafe::32) by AM6PR01CA0048.outlook.office365.com (2603:10a6:20b:e0::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14 via Frontend Transport; Wed, 8 Sep 2021 09:54:08 +0000 Received: from nebula.arm.com (40.67.248.234) by VE1EUR03FT055.mail.protection.outlook.com (10.152.19.158) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.4478.19 via Frontend Transport; Wed, 8 Sep 2021 09:54:08 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.14; Wed, 8 Sep 2021 09:54:12 +0000 Received: from penny.shanghai.arm.com (10.169.190.66) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2308.14 via Frontend Transport; Wed, 8 Sep 2021 09:54:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 710e629f-b153-4d48-945e-6e5213475b1e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AMCW5xXNqkaV3p45gVg1gz98GeXvw0DWsgYQwmmZLho=; b=YapclBF9JHWSw1oLOXUWmwDXkDDlWaTR49bkTFpbeJwIZ1rBBqJNxXhnDAI/JAoo8p9yWtJd66enr4DcSMlOe/QFb5pEMqp33UshvsdOIhkkqTzO8ki0m//TZ7jD1rQjgWzo9TBbIQhYKEsI5/dYjTT9YzCtOmGXVnmamuSVO7g= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: 3fd3d9752e95c7b8 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AKK9ez2QUc/A0Qvnnjmi4Qm9SDSLvrtWPe+seb4l/zxrcXrG30OjJQ64i6vJYHeaC2iatcvOOJ3CDqaz0euepEl1TNfRh8h9Sx655n9qSm2Lh8dvfO6zVJ5nS6pp+/tgsBpL/qPjSVV/QPK83luX6+cwK2M5Jdx62//a4kzBodXult0+CVdsHrxaOZqIhOFdqRyWoNMmtJBei61npWbHIG03wyzriWoUS//pM/hmVUS93Do5ThJb0yKQBMOZqBWjacmanM04ojRf+kHpNGby75j64IeO9hVZkolOpee3sgsqcoMxNzLp7UpONC3xD+EHAu8DnW1ayQhBB1fC7s+nsw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=AMCW5xXNqkaV3p45gVg1gz98GeXvw0DWsgYQwmmZLho=; b=jQetPhEu9LIt/pyh59/vFu+WVq1RQJpUb6ZN9XplNmNPv124XFLeAka7LjQjrye0q0bvB2wSufie64zreRzVaGGdPFlUCKTXrMowvssfCru2uJZd+ex0IaQXBE7FgamfsQC8XjiQFj4bqD5iBUAELP7UZ9i7fYZdu/9MFCPIdWTR4KSVgBnweH+n+oY9ehERfWoH4GYptXG/9sX3IqX+S+ArFsfvE2bfEoU/cMqH6+Pq1Z5CPeI4ctev072j9EZUY8DH95w8HN1fQjkNNWhZkqqyqeHGTlm0Is201fIvv+ZVD5cUBBkviuk172rufyZbKW8Ni4s0xFAX138pir+fXQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AMCW5xXNqkaV3p45gVg1gz98GeXvw0DWsgYQwmmZLho=; b=YapclBF9JHWSw1oLOXUWmwDXkDDlWaTR49bkTFpbeJwIZ1rBBqJNxXhnDAI/JAoo8p9yWtJd66enr4DcSMlOe/QFb5pEMqp33UshvsdOIhkkqTzO8ki0m//TZ7jD1rQjgWzo9TBbIQhYKEsI5/dYjTT9YzCtOmGXVnmamuSVO7g= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; From: Penny Zheng To: , , CC: , , Subject: [PATCH v6 3/7] xen: introduce mark_page_free Date: Wed, 8 Sep 2021 09:52:44 +0000 Message-ID: <20210908095248.545981-4-penny.zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210908095248.545981-1-penny.zheng@arm.com> References: <20210908095248.545981-1-penny.zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9ee270c3-d84b-46e8-5064-08d972ae9eda X-MS-TrafficTypeDiagnostic: AM8PR08MB6611:|AM6PR08MB4504: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:1051;OLM:1051; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: Pj+BKWgtu/2rQ4dGzigUQfEgqbZ3it7nn01d8j16dP4g9B4AlucmsxNu1vKm0s2lXEk/gazxU3iY+lNYRgf2VrRwvl+5MRUjmnQuZ9+cLpddFf5scxs1xINxL9MF/YIv2kO3ApIElTz+yyVqWcan2kw3f7NU1t2REedGknDeCh/BL5B8ANkUiIro/wXyyuADOhmFjseYOTBkU8wOV51f1PEoouQyCHdSBIRUE+nAfcsBDCrWWxPKeh4PNJLYPL3WYkfQEBXkZ543wZEBKMMzpHCa6xqWpP510jVerubGYxbmnlaJSbPGBizoHtvALRsgflAhPlATYMso6R30dHddZQAwtXWQh6pvgcTiL89xfX+Q/bq83MW0QtCSoUnrJotPZ0E/r6X02HIjtHBP//5V9cREo6vZYXjP011aNPajxQ+M62iWh698aNs8l9o4dbINpXYzZZb+uEB4Ff4zrjVTuwLe5/B8GSv/swJs9vMu1E14hjbD5/vNO3oh/zQ+0CRhS9SBdEgJxJ+Hz4NR3gaBYZ0M+c5nZttQ3iirE/BuqqTAKKdpdQhN9EPECERIAH6MjMzodp8Zo5DUCaCsFg0aMmUM/mdRUw+GtXB4VwC0oiAlj6nEa6yXsk+xOcV2+meQ9wIsTJprIRXA1ez+vAhH1sMuCEIjEV2jx09Tv4KIJJ27o/trv1NLNgl1I7E+icJVA56jUx2PKa0T2cFJMXktzTm8sTatW75UbHCs1IMHgpU= X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(2616005)(81166007)(8936002)(426003)(4326008)(316002)(5660300002)(336012)(1076003)(8676002)(47076005)(2906002)(356005)(70586007)(70206006)(83380400001)(36756003)(26005)(110136005)(186003)(86362001)(36860700001)(7696005)(44832011)(82310400003)(6666004)(54906003)(508600001)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB6611 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT052.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: e34ca84a-a1f7-46e3-1735-08d972ae99f2 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Txja8jyXeoLQrPOBX1Lv9eB7y+rdXz+wonQN2hXo8IO68DniA/prBGZfUxZ7mkeaSdXOX4krcOhVNmJwIRcYO7u996eLlgrGasxbVOBc8mnYtgJAf+t0h8B+86TLi4iMXfq5BR7YBt4+s1Jmd9xPbtTiyxODkovfbwYBsp00FH+vSL0zndO4JUihmgR60dTNdThuj2qJpPjiMOQcizzYFd+YC1WOrDsoIJhzcyQRciZwlmBE1NeXfg8HBUd6YgcvzsVfq5M5jWjDUmz776NFN6Ga2nQnYUT4H7/9NidFMABnvHQ+aurF9smuBuztpHYRHUy/Vg47P7QSkIuP8fIsr0h6Rb3YcbHcimvmDOWh4iWfvRcxu0IJffhDP43sHtYvHTZBLeRDIfjs42pkFYEZAHgzjn4dflVY5S29Supew0cYBafgFSS5DyNRBF0xjVJe9haBDB3BAdHSOtpt96mEWzW9GYgD4xxZLOIjkaQx2P7pmXPaggoSyoptM7Mxu8QXqr4XoZAwc9yZQMnNXgD+P9+2xc6P3gCuD0zGPPLPe+9Ean4xxQc+MHa98F6yqqQL+RqzRHR27C9YKJfNxv/n5zWTHNC9wdLx7czrYvCbZl06t/1RJIUWMpXT3GdkUwOcBKAekuPPk3LAT/3XWscmxKufuno9G4Kchq/Doh83V50bbc9n7dSMWzkOZnSDkJuhw1veMW4nCSMXelqPcjSV5w== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(346002)(136003)(376002)(39860400002)(396003)(36840700001)(46966006)(186003)(5660300002)(2616005)(107886003)(83380400001)(86362001)(36860700001)(1076003)(82310400003)(47076005)(6666004)(36756003)(81166007)(478600001)(82740400003)(336012)(70586007)(426003)(8936002)(2906002)(4326008)(316002)(26005)(7696005)(44832011)(54906003)(70206006)(8676002)(110136005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Sep 2021 09:54:16.3489 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9ee270c3-d84b-46e8-5064-08d972ae9eda X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT052.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4504 This commit defines a new helper mark_page_free to extract common code, like following the same cache/TLB coherency policy, between free_heap_pages and the new function free_staticmem_pages, which will be introduced later. The PDX compression makes that conversion between the MFN and the page can be potentially non-trivial. As the function is internal, pass the MFN and the page. They are both expected to match. Signed-off-by: Penny Zheng Acked-by: Jan Beulich Reviewed-by: Julien Grall --- xen/common/page_alloc.c | 89 ++++++++++++++++++++++------------------- 1 file changed, 48 insertions(+), 41 deletions(-) diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c index 958ba0cd92..a3ee5eca9e 100644 --- a/xen/common/page_alloc.c +++ b/xen/common/page_alloc.c @@ -1376,6 +1376,53 @@ bool scrub_free_pages(void) return node_to_scrub(false) != NUMA_NO_NODE; } +static void mark_page_free(struct page_info *pg, mfn_t mfn) +{ + ASSERT(mfn_x(mfn) == mfn_x(page_to_mfn(pg))); + + /* + * Cannot assume that count_info == 0, as there are some corner cases + * where it isn't the case and yet it isn't a bug: + * 1. page_get_owner() is NULL + * 2. page_get_owner() is a domain that was never accessible by + * its domid (e.g., failed to fully construct the domain). + * 3. page was never addressable by the guest (e.g., it's an + * auto-translate-physmap guest and the page was never included + * in its pseudophysical address space). + * In all the above cases there can be no guest mappings of this page. + */ + switch ( pg->count_info & PGC_state ) + { + case PGC_state_inuse: + BUG_ON(pg->count_info & PGC_broken); + pg->count_info = PGC_state_free; + break; + + case PGC_state_offlining: + pg->count_info = (pg->count_info & PGC_broken) | + PGC_state_offlined; + tainted = 1; + break; + + default: + printk(XENLOG_ERR + "pg MFN %"PRI_mfn" c=%#lx o=%u v=%#lx t=%#x\n", + mfn_x(mfn), + pg->count_info, pg->v.free.order, + pg->u.free.val, pg->tlbflush_timestamp); + BUG(); + } + + /* If a page has no owner it will need no safety TLB flush. */ + pg->u.free.need_tlbflush = (page_get_owner(pg) != NULL); + if ( pg->u.free.need_tlbflush ) + page_set_tlbflush_timestamp(pg); + + /* This page is not a guest frame any more. */ + page_set_owner(pg, NULL); /* set_gpfn_from_mfn snoops pg owner */ + set_gpfn_from_mfn(mfn_x(mfn), INVALID_M2P_ENTRY); +} + /* Free 2^@order set of pages. */ static void free_heap_pages( struct page_info *pg, unsigned int order, bool need_scrub) @@ -1392,47 +1439,7 @@ static void free_heap_pages( for ( i = 0; i < (1 << order); i++ ) { - /* - * Cannot assume that count_info == 0, as there are some corner cases - * where it isn't the case and yet it isn't a bug: - * 1. page_get_owner() is NULL - * 2. page_get_owner() is a domain that was never accessible by - * its domid (e.g., failed to fully construct the domain). - * 3. page was never addressable by the guest (e.g., it's an - * auto-translate-physmap guest and the page was never included - * in its pseudophysical address space). - * In all the above cases there can be no guest mappings of this page. - */ - switch ( pg[i].count_info & PGC_state ) - { - case PGC_state_inuse: - BUG_ON(pg[i].count_info & PGC_broken); - pg[i].count_info = PGC_state_free; - break; - - case PGC_state_offlining: - pg[i].count_info = (pg[i].count_info & PGC_broken) | - PGC_state_offlined; - tainted = 1; - break; - - default: - printk(XENLOG_ERR - "pg[%u] MFN %"PRI_mfn" c=%#lx o=%u v=%#lx t=%#x\n", - i, mfn_x(mfn) + i, - pg[i].count_info, pg[i].v.free.order, - pg[i].u.free.val, pg[i].tlbflush_timestamp); - BUG(); - } - - /* If a page has no owner it will need no safety TLB flush. */ - pg[i].u.free.need_tlbflush = (page_get_owner(&pg[i]) != NULL); - if ( pg[i].u.free.need_tlbflush ) - page_set_tlbflush_timestamp(&pg[i]); - - /* This page is not a guest frame any more. */ - page_set_owner(&pg[i], NULL); /* set_gpfn_from_mfn snoops pg owner */ - set_gpfn_from_mfn(mfn_x(mfn) + i, INVALID_M2P_ENTRY); + mark_page_free(&pg[i], mfn_add(mfn, i)); if ( need_scrub ) { -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Wed Sep 08 09:54:29 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Sep 2021 09:54:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.181613.328834 (Exim 4.92) (envelope-from ) id 1mNuHl-0001WP-QP; Wed, 08 Sep 2021 09:54:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 181613.328834; Wed, 08 Sep 2021 09:54:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNuHl-0001VS-LG; Wed, 08 Sep 2021 09:54:29 +0000 Received: by outflank-mailman (input) for mailman id 181613; Wed, 08 Sep 2021 09:54:28 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNuHk-0001EI-5d for xen-devel@lists.xenproject.org; Wed, 08 Sep 2021 09:54:28 +0000 Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id c0d5fdd8-108a-11ec-b148-12813bfff9fa; Wed, 08 Sep 2021 09:54:27 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c0d5fdd8-108a-11ec-b148-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1631094867; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=PDBj/mA8Lu6e2IhZjHrH6EN0R60DBQb8n23okxDMJvY=; b=adEy6LxjdRHGd/wTBJNudWVup26YVrWmBZcWXd6oJiERwIWhdqDGepq7 /C0YnIrNj7OvhkQ4fDvKD8cA1OxC7xIiUqEf2XNEYOMQE+9b+7Lw4rOQR yOuksf02F2I0vlOnOg5RLkN8ZrimwzzdDBwCGDaMdr1t3j0lIp9cICD++ 8=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: 9hJzvvNN+HDUTSRgGrqP7csVUq9njft5zD/0wcM2reORepBNmRYH54XkhC/IaQPSZO3KjwEKA2 5kNFrhbq5ILf0VgImqSQ/Obt3cVy+WVtoRoOleKRsAWimzGSgEBsYhkhgrLUb1DTIjjihxpNSt 6czpK3hgivc+TlAPAc29kRZo43ouizWsK/ILM8OC8Sk3+QAZeqRXIOXWMAYUzajGxChxSv409z RS02wwNBDbnz9gH4a3hy/fG1KEyssh65v97oYE9U45Q1MbgQTcR++tAV5oU7mJZO7ehvA6QWvi 6W4m2GMga8UsZS4QRhjkVjpn X-SBRS: 5.1 X-MesageID: 53993474 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:opGXYqACNyXpAYXlHemm55DYdb4zR+YMi2TC1yhKJiC9Ffbo8v xG/c5rsiMc5wxxZJhNo7290cq7MBHhHPxOgbX5VI3KNGKNhILBFvAH0WKI+VPd8kPFmtK1rZ 0QEJRDNA== X-IronPort-AV: E=Sophos;i="5.85,277,1624334400"; d="scan'208";a="53993474" From: Anthony PERARD To: CC: Andrew Cooper , Jan Beulich , Anthony PERARD , Wei Liu , Julien Grall , Ian Jackson , Stefano Stabellini , "Daniel De Graaf" , George Dunlap , "Daniel P. Smith" Subject: [XEN PATCH 0/2] build: attempt to "fix" GitLab CI job "debian-unstable-gcc-arm64" Date: Wed, 8 Sep 2021 10:54:20 +0100 Message-ID: <20210908095422.438324-1-anthony.perard@citrix.com> X-Mailer: git-send-email 2.33.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Patch series available in this git branch: https://xenbits.xen.org/git-http/people/aperard/xen-unstable.git br.fix-flask-policy.mk-v1 Well, that job fails with weird failure: make[6]: Entering directory '/builds/xen-project/xen/tools/flask/policy' make[6]: warning: jobserver unavailable: using -j1. Add '+' to parent make rule. /builds/xen-project/xen/tools/flask/policy/Makefile.common:115: *** target pattern contains no '%'. Stop. make[6]: Leaving directory '/builds/xen-project/xen/tools/flask/policy' This is because we do $(shell $(MAKE) xenversion) and that sometime produce more than just "4.16-unstable", which lead to makefile parsing failure. Maybe `make -j80` is too much. But you can have the same kind of failure when running `make --debug=a` or `remake --trace` with flask policy generation enabled. This patch series fixes build of "xen" (first patch), but only workaround with a probably not good enough patch for build of the "tools". Anthony PERARD (2): build: set policy filename on make command line build: add --full to version.sh to guess $(XEN_FULLVERSION) tools/flask/policy/Makefile.common | 2 +- version.sh | 15 ++++++++++++++- xen/xsm/flask/Makefile | 2 +- 3 files changed, 16 insertions(+), 3 deletions(-) -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Wed Sep 08 09:54:35 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Sep 2021 09:54:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.181615.328844 (Exim 4.92) (envelope-from ) id 1mNuHr-00021Y-4y; Wed, 08 Sep 2021 09:54:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 181615.328844; Wed, 08 Sep 2021 09:54:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNuHr-00021L-0l; Wed, 08 Sep 2021 09:54:35 +0000 Received: by outflank-mailman (input) for mailman id 181615; Wed, 08 Sep 2021 09:54:33 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNuHp-0001EI-4K for xen-devel@lists.xenproject.org; Wed, 08 Sep 2021 09:54:33 +0000 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id c177d7de-108a-11ec-b148-12813bfff9fa; Wed, 08 Sep 2021 09:54:28 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c177d7de-108a-11ec-b148-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1631094868; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=AsZBJR8DqTXnM0J0C60Tfl9G1/1Dykb1qhx3aXLPQKA=; b=XFhnteq3B7TK12Iq7u47AlagKCEKuLPmZeTIteKciX2sJ2F7XbkOaaho 0mkFKRdswyzlbxRj3WRpXHLhUFzFkKylXWqhw7dbWaVdPqkWVDHA85Ti4 tHUd5RGfaSEg26wuJdVDayBm4O/t97R0PLvHgsf2+45G81oR0SlKJ5QlV g=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: 5+r2TLm/n1r96Gjv2CZirI56HcpkfJGxmXSw1x1oAV2t8202ESGWCBYciVSTu1jDtTh5ZnXAhd +RuMZxzI+C06I7+2UGajzNuSPGRA+Ewv8wqQMEG5P76gdLwg7CC3azHyEdGu1Th6t+44fDdVcz 56LHITxzjQbHwqXB6f/PZnQZvyHuwqoPJlNBnDlCJu46gL0HAKQa0AVc/RCA/YK9ZEjxHBqaS4 8dbD83KwdFvvMv3AHliFmoBdH83FODY0MWG8NIQvM5M15SGv52813EGVj7pPFhhKSkRtQUfhTO BpwP/FEuN3G5HPNICzwNvt6i X-SBRS: 5.1 X-MesageID: 51835828 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:KULzgKmXcDch0cVoHxuZlxF/ccrpDfLW3DAbv31ZSRFFG/Fw9/ rCoB3U73/JYVcqKRUdcLW7UpVoLkmyyXcY2+cs1NSZLWzbUQmTXeJfBOLZqlWNJ8SXzIVgPM xbAspD4bPLbGSTjazBkXSF+9RL+qj6zEh/792usEuETmtRGt9dBx8SMHf9LqXvLjM2fqbQEv Cnl6x6jgvlQ1s7ROKhCEIIWuDSzue77q4PMXY9dmcaABDlt0LR1ILH X-IronPort-AV: E=Sophos;i="5.85,277,1624334400"; d="scan'208";a="51835828" From: Anthony PERARD To: CC: Andrew Cooper , Jan Beulich , Anthony PERARD , "Daniel De Graaf" , "Daniel P. Smith" Subject: [XEN PATCH 1/2] build: set policy filename on make command line Date: Wed, 8 Sep 2021 10:54:21 +0100 Message-ID: <20210908095422.438324-2-anthony.perard@citrix.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20210908095422.438324-1-anthony.perard@citrix.com> References: <20210908095422.438324-1-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain In order to avoid flask/Makefile.common calling `make xenversion`, we override POLICY_FILENAME with the value we are going to use anyway. Signed-off-by: Anthony PERARD --- xen/xsm/flask/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/xsm/flask/Makefile b/xen/xsm/flask/Makefile index 637159ad8276..093ee50bf1c8 100644 --- a/xen/xsm/flask/Makefile +++ b/xen/xsm/flask/Makefile @@ -42,7 +42,7 @@ FLASK_BUILD_DIR := $(CURDIR) POLICY_SRC := $(FLASK_BUILD_DIR)/xenpolicy-$(XEN_FULLVERSION) policy.bin: FORCE - $(MAKE) -f $(XEN_ROOT)/tools/flask/policy/Makefile.common -C $(XEN_ROOT)/tools/flask/policy FLASK_BUILD_DIR=$(FLASK_BUILD_DIR) + $(MAKE) -f $(XEN_ROOT)/tools/flask/policy/Makefile.common -C $(XEN_ROOT)/tools/flask/policy FLASK_BUILD_DIR=$(FLASK_BUILD_DIR) POLICY_FILENAME=$(POLICY_SRC) cmp -s $(POLICY_SRC) $@ || cp $(POLICY_SRC) $@ .PHONY: clean -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Wed Sep 08 09:54:38 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Sep 2021 09:54:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.181616.328856 (Exim 4.92) (envelope-from ) id 1mNuHu-0002Sq-Gj; Wed, 08 Sep 2021 09:54:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 181616.328856; Wed, 08 Sep 2021 09:54:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNuHu-0002SN-C5; Wed, 08 Sep 2021 09:54:38 +0000 Received: by outflank-mailman (input) for mailman id 181616; Wed, 08 Sep 2021 09:54:37 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNuHt-0000bc-H8 for xen-devel@lists.xenproject.org; Wed, 08 Sep 2021 09:54:37 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (unknown [40.107.20.63]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id eece8e26-0e47-4435-b533-0948220731fa; Wed, 08 Sep 2021 09:54:28 +0000 (UTC) Received: from AM5PR0602CA0007.eurprd06.prod.outlook.com (2603:10a6:203:a3::17) by DB9PR08MB6762.eurprd08.prod.outlook.com (2603:10a6:10:2a8::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.22; Wed, 8 Sep 2021 09:54:26 +0000 Received: from AM5EUR03FT037.eop-EUR03.prod.protection.outlook.com (2603:10a6:203:a3:cafe::f9) by AM5PR0602CA0007.outlook.office365.com (2603:10a6:203:a3::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14 via Frontend Transport; Wed, 8 Sep 2021 09:54:26 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT037.mail.protection.outlook.com (10.152.17.241) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Wed, 8 Sep 2021 09:54:26 +0000 Received: ("Tessian outbound b9872a30149f:v105"); Wed, 08 Sep 2021 09:54:25 +0000 Received: from f70b2a647f00.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 75238AC5-D489-4D20-9685-0146AADA106F.1; Wed, 08 Sep 2021 09:54:20 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id f70b2a647f00.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 08 Sep 2021 09:54:20 +0000 Received: from PR0P264CA0191.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:1c::35) by AM6PR08MB3623.eurprd08.prod.outlook.com (2603:10a6:20b:48::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.24; Wed, 8 Sep 2021 09:54:18 +0000 Received: from VE1EUR03FT041.eop-EUR03.prod.protection.outlook.com (2603:10a6:100:1c:cafe::f) by PR0P264CA0191.outlook.office365.com (2603:10a6:100:1c::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14 via Frontend Transport; Wed, 8 Sep 2021 09:54:18 +0000 Received: from nebula.arm.com (40.67.248.234) by VE1EUR03FT041.mail.protection.outlook.com (10.152.19.163) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.4478.19 via Frontend Transport; Wed, 8 Sep 2021 09:54:18 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.14; Wed, 8 Sep 2021 09:54:20 +0000 Received: from penny.shanghai.arm.com (10.169.190.66) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2308.14 via Frontend Transport; Wed, 8 Sep 2021 09:54:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: eece8e26-0e47-4435-b533-0948220731fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ulrPrQnKNKHeTjBqMvFiBcaLOSg+pt3ZsckmpTE4xGg=; b=NhfkiD374f1cloiY9O5ZepaoDxfL6UQl6/Cc71E02QObnBD9V2Eud+a9vo394hrzw9y1mjjMK+/87UDILLF3KNy+EmfSTNDbgXBKds8IQyK2xz9/oLpD2PqZ+QSbvygGs1eRnPjOtDEZIgftBJIW8IH+CPrIOpe26AreZZrAbdU= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: 23d4e0f8689de261 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HjW+45NasmLGFrCPkiko7oX/Z2tpz6BEGB4dIph9QbnzcK08vthBamEcvApL2p6IommH16cBY71+TNrvIBRfaUbFyoc5BmH94NGUKr9yBvttnkBRz7+UPEDjy3+nw3dHAhg3kl3ZNv27gA3KX8Kz0fzompH8PDcXxdxa2duEnd20VBA8od9J++PHAdhFFM6qCvNQ5D38w1pVtSuMLllMEBcS5KfHRqIDV6tpFpWYRZAUkYccUC9RzLB0XVNLX8h/o/76EDowAuFA/kFVx+9ecadpd/TA3YA4AkE2KpYTRa1ueLfevT8+Yoc78nRWyGMPMXMswLOlGhdP0c7iT2l3MA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=ulrPrQnKNKHeTjBqMvFiBcaLOSg+pt3ZsckmpTE4xGg=; b=goRlHzMSp/PDdpVqfzCXTO5VSoUCXPWfS2tdz+Cyb3IKzkSkwIF3c5p1eTqUVpglY9EkHBgMjqK0fisXUq2j5StfC2wcfTQAKulVZSkhus0Tso5oInPVs042ESnZ4qZVrKPYl9E4hAV9MyXgyXe7xsC+A1qKGJwZPrby+F9gr2g6xmSYN4giKawfGWn7sL0wCZnToZCChsHUKWbcXUJg2esM8s383+puoHho2xXH/TOt3kcTP8xj07SUIJ9UYVPKYaC4C8gJmyQKfI/MuAEQyqIGVDUmzzqyFzuq13jg6+lR/Rex2RpCTYIJk/lsuHFO0lOvH7aUuG2yJc8OtKD37w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ulrPrQnKNKHeTjBqMvFiBcaLOSg+pt3ZsckmpTE4xGg=; b=NhfkiD374f1cloiY9O5ZepaoDxfL6UQl6/Cc71E02QObnBD9V2Eud+a9vo394hrzw9y1mjjMK+/87UDILLF3KNy+EmfSTNDbgXBKds8IQyK2xz9/oLpD2PqZ+QSbvygGs1eRnPjOtDEZIgftBJIW8IH+CPrIOpe26AreZZrAbdU= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; From: Penny Zheng To: , , CC: , , Subject: [PATCH v6 6/7] xen/arm: introduce acquire_staticmem_pages and acquire_domstatic_pages Date: Wed, 8 Sep 2021 09:52:47 +0000 Message-ID: <20210908095248.545981-7-penny.zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210908095248.545981-1-penny.zheng@arm.com> References: <20210908095248.545981-1-penny.zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ce590b9e-63d8-459c-867d-08d972aea4a7 X-MS-TrafficTypeDiagnostic: AM6PR08MB3623:|DB9PR08MB6762: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:6790;OLM:6790; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: nl8jk9LRhIMcN6l2ckGpEixtbCGp8JTWoblfBW+orT5kCMwhRPKY2Rv2p+FIhdNObOFK19X+99rgk8ntJ9Tj1YwVuVwBOzVo98HnEjvMueevO7+jofecUZHcpAxRerkHUkRrOotJIHHODe+RxkJ8HVNI5DTpZifHBgbkHw3lqu2IXO15Z9xPqG4ijWUStS02dIKCNA7c8BNNHYnUBG2iS98CVtvCKZopYORRXH1OWhKbPS1lD2zysEs0xN4ncYvf8xCuy3QmxDGehoPH7zf4Fd0yRVb8KJOUe+8So6Heh/EdpYmvcG7OdRR15wtLnHZwzszX6cF6Kqtk23hMtZHnFvW5EfinQlyNYO63bRuMikS64gZgXzXeu4f83rzrBZC9Lmu/zsL2bY+23cg4vTUGHkd67GstNeDYPYoNsn+b6kqi0Qz3HGfzf1sHV5fFZmToIB/z+vcXDhOxKjCTdxxkna8tzbL0QelSTfNeQ/jbyCgT1r2VkMxIbfDOIvgTZoxCRFqhd4Z2/1vkBfLflYiD3w3/s/E7NrMebORUjsqq+Rzq9jQdNAmgLaO2jARzAt5ZjrdyXm8+GOgEbzuBXvI6Zt6eGUKRp8pwkgimjnBBght92fiYHou9+P8DosWgWFm2Ak7/lOTBoN+Yha/upgE5urHDMPSP2PVg+V732U64M34Ma7aJ1MLo+j/+g4sEYkd7JAEZDx5GuDSKKDHQ0i2mVbWmXwxEmtKQ3MkT3XNrdgE= X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(110136005)(316002)(81166007)(356005)(54906003)(7696005)(6666004)(70586007)(2616005)(1076003)(508600001)(336012)(426003)(70206006)(186003)(4326008)(8936002)(2906002)(26005)(5660300002)(8676002)(36860700001)(86362001)(36756003)(44832011)(47076005)(82310400003)(83380400001)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3623 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT037.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: d56d9f29-9e71-4677-8119-08d972ae9fe7 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Nv23PaB9KOLZkqXBH6qg7uco6r2/L5UmqnXw9D6ODSpa+0csl+0MpfWUz0nqvVfdNrd6qJ7RidszSiEgTd4CVUApqz0bPdoLzc54LK3jvTpic9iKd45Wiq1gv/ZO9HuiJXYmXyK5MO6hJgBvKHcgwcyhfsCWWVmQkcLUDG7SkLjeAZ009jiEIzDkZB7uHncY5Zy2Y2TpXbNe6JlinNekQQj8tFmThfLoMfYlMmIXN5OqPvOaoS6HQYzXaZVRwtoG6yGmp2UW7UyiHXgMNGRgORBnbugjUCqkQP7CjAvKMgm+3u5ELKopZmFnMc46P4GZ1fSgyr+TM0kaD3RVmiuddsUICRtHcCVgpY1oQJ08t+92quvBDqxjGZZ597k9mnVMeO7yMf4rqj36HBKtAMC2Tk6WFPKSuROlQE51IdWYkBOtme9CK0JLkNBcroAGBeOEh9d7vwD3BksolJBUfV7yYxlmBguwvirLGC7uh21R8Pg2NKD87WqffIuYA4RN1LQVeknz7o/OXs0MBePYer4bHp9z1Tgr+xaWz/2BvJQzFxcUDYEj94iWL6t3uw01wcAjPrJmzcC08ostH/3mk+MWpO1ADgovKn7U1eI6Tc5D58A/+3aXRNRnACcGY2b9X64mO9g+UoWXO2s3BhBjjn2WfIvXL7Z7ctxPEut2SJVhDHDUo4CPxQ9f/FmqiEBLOME1DCnLfLvlzDU3FAExh9VSxw== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(136003)(346002)(39860400002)(376002)(396003)(46966006)(36840700001)(81166007)(8936002)(8676002)(70206006)(70586007)(2616005)(7696005)(36756003)(26005)(336012)(426003)(316002)(2906002)(4326008)(47076005)(54906003)(5660300002)(36860700001)(82740400003)(6666004)(110136005)(478600001)(186003)(86362001)(1076003)(83380400001)(44832011)(107886003)(82310400003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Sep 2021 09:54:26.1435 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ce590b9e-63d8-459c-867d-08d972aea4a7 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT037.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB6762 New function acquire_staticmem_pages aims to acquire nr_mfns contiguous pages of static memory, starting at #smfn. And it is the equivalent of alloc_heap_pages for static memory. For each page, it shall check if the page is reserved(PGC_reserved) and free. It shall also do a set of necessary initialization, which are mostly the same ones in alloc_heap_pages, like, following the same cache-coherency policy and turning page status into PGC_state_inuse, etc. New function acquire_domstatic_pages is the equivalent of alloc_domheap_pages for static memory, and it is to acquire nr_mfns contiguous pages of static memory and assign them to one specific domain. It uses acquire_staticmem_pages to acquire nr_mfns pages of static memory. Then on success, it will use assign_pages to assign those pages to one specific domain. In order to differentiate pages of static memory from those allocated from heap, this patch introduces a new page flag PGC_reserved, then mark pages of static memory PGC_reserved when initializing them. Signed-off-by: Penny Zheng --- xen/common/page_alloc.c | 118 ++++++++++++++++++++++++++++++++++++++- xen/include/asm-arm/mm.h | 3 + xen/include/xen/mm.h | 2 + 3 files changed, 121 insertions(+), 2 deletions(-) diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c index bb19bb10ff..59dffcfa1d 100644 --- a/xen/common/page_alloc.c +++ b/xen/common/page_alloc.c @@ -151,6 +151,10 @@ #define p2m_pod_offline_or_broken_replace(pg) BUG_ON(pg != NULL) #endif +#ifndef PGC_reserved +#define PGC_reserved 0 +#endif + /* * Comma-separated list of hexadecimal page numbers containing bad bytes. * e.g. 'badpage=0x3f45,0x8a321'. @@ -2283,7 +2287,7 @@ int assign_pages( for ( i = 0; i < nr; i++ ) { - ASSERT(!(pg[i].count_info & ~PGC_extra)); + ASSERT(!(pg[i].count_info & ~(PGC_extra | PGC_reserved))); if ( pg[i].count_info & PGC_extra ) extra_pages++; } @@ -2322,7 +2326,8 @@ int assign_pages( page_set_owner(&pg[i], d); smp_wmb(); /* Domain pointer must be visible before updating refcnt. */ pg[i].count_info = - (pg[i].count_info & PGC_extra) | PGC_allocated | 1; + (pg[i].count_info & (PGC_extra | PGC_reserved)) | PGC_allocated | 1; + page_list_add_tail(&pg[i], page_to_list(d, &pg[i])); } @@ -2626,8 +2631,117 @@ void __init free_staticmem_pages(struct page_info *pg, unsigned long nr_mfns, /* TODO: asynchronous scrubbing for pages of static memory. */ scrub_one_page(pg); } + + /* In case initializing page of static memory, mark it PGC_reserved. */ + pg[i].count_info |= PGC_reserved; } } + +/* + * Acquire nr_mfns contiguous reserved pages, starting at #smfn, of + * static memory. + * This function needs to be reworked if used outside of boot. + */ +static struct page_info * __init acquire_staticmem_pages(mfn_t smfn, + unsigned long nr_mfns, + unsigned int memflags) +{ + bool need_tlbflush = false; + uint32_t tlbflush_timestamp = 0; + unsigned long i; + struct page_info *pg; + + ASSERT(nr_mfns); + for ( i = 0; i < nr_mfns; i++ ) + if ( !mfn_valid(mfn_add(smfn, i)) ) + return NULL; + + pg = mfn_to_page(smfn); + + spin_lock(&heap_lock); + + for ( i = 0; i < nr_mfns; i++ ) + { + /* The page should be reserved and not yet allocated. */ + if ( pg[i].count_info != (PGC_state_free | PGC_reserved) ) + { + printk(XENLOG_ERR + "pg[%lu] Static MFN %"PRI_mfn" c=%#lx t=%#x\n", + i, mfn_x(smfn) + i, + pg[i].count_info, pg[i].tlbflush_timestamp); + goto out_err; + } + + if ( !(memflags & MEMF_no_tlbflush) ) + accumulate_tlbflush(&need_tlbflush, &pg[i], + &tlbflush_timestamp); + + /* + * Preserve flag PGC_reserved and change page state + * to PGC_state_inuse. + */ + pg[i].count_info = PGC_reserved | PGC_state_inuse; + /* Initialise fields which have other uses for free pages. */ + pg[i].u.inuse.type_info = 0; + page_set_owner(&pg[i], NULL); + } + + spin_unlock(&heap_lock); + + if ( need_tlbflush ) + filtered_flush_tlb_mask(tlbflush_timestamp); + + /* + * Ensure cache and RAM are consistent for platforms where the guest + * can control its own visibility of/through the cache. + */ + for ( i = 0; i < nr_mfns; i++ ) + flush_page_to_ram(mfn_x(smfn) + i, !(memflags & MEMF_no_icache_flush)); + + return pg; + + out_err: + while ( i-- ) + pg[i].count_info = PGC_reserved | PGC_state_free; + + spin_unlock(&heap_lock); + + return NULL; +} + +/* + * Acquire nr_mfns contiguous pages, starting at #smfn, of static memory, + * then assign them to one specific domain #d. + */ +int __init acquire_domstatic_pages(struct domain *d, mfn_t smfn, + unsigned long nr_mfns, unsigned int memflags) +{ + struct page_info *pg; + + ASSERT(!in_irq()); + + pg = acquire_staticmem_pages(smfn, nr_mfns, memflags); + if ( !pg ) + return -ENOENT; + + if ( !d || (memflags & (MEMF_no_owner | MEMF_no_refcount)) ) + { + /* + * Respective handling omitted here because right now + * acquired static memory is only for guest RAM. + */ + ASSERT_UNREACHABLE(); + return -EINVAL; + } + + if ( assign_pages(d, pg, nr_mfns, memflags) ) + { + free_staticmem_pages(pg, nr_mfns, memflags & MEMF_no_scrub); + return -EINVAL; + } + + return 0; +} #endif /* diff --git a/xen/include/asm-arm/mm.h b/xen/include/asm-arm/mm.h index ded74d29da..7b5e7b7f69 100644 --- a/xen/include/asm-arm/mm.h +++ b/xen/include/asm-arm/mm.h @@ -108,6 +108,9 @@ struct page_info /* Page is Xen heap? */ #define _PGC_xen_heap PG_shift(2) #define PGC_xen_heap PG_mask(1, 2) + /* Page is reserved */ +#define _PGC_reserved PG_shift(3) +#define PGC_reserved PG_mask(1, 3) /* ... */ /* Page is broken? */ #define _PGC_broken PG_shift(7) diff --git a/xen/include/xen/mm.h b/xen/include/xen/mm.h index a74e93eba8..da1b158693 100644 --- a/xen/include/xen/mm.h +++ b/xen/include/xen/mm.h @@ -89,6 +89,8 @@ bool scrub_free_pages(void); /* These functions are for static memory */ void free_staticmem_pages(struct page_info *pg, unsigned long nr_mfns, bool need_scrub); +int acquire_domstatic_pages(struct domain *d, mfn_t smfn, unsigned long nr_mfns, + unsigned int memflags); #endif /* Map machine page range in Xen virtual address space. */ -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Wed Sep 08 09:54:40 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Sep 2021 09:54:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.181617.328867 (Exim 4.92) (envelope-from ) id 1mNuHw-0002pC-7Q; Wed, 08 Sep 2021 09:54:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 181617.328867; Wed, 08 Sep 2021 09:54:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNuHv-0002oH-Vl; Wed, 08 Sep 2021 09:54:39 +0000 Received: by outflank-mailman (input) for mailman id 181617; Wed, 08 Sep 2021 09:54:38 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNuHu-0001EI-4X for xen-devel@lists.xenproject.org; Wed, 08 Sep 2021 09:54:38 +0000 Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id c2f1fdc5-108a-11ec-b148-12813bfff9fa; Wed, 08 Sep 2021 09:54:30 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c2f1fdc5-108a-11ec-b148-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1631094870; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=qNr9KSzgnELykt88dPBpEyZ6wsbID+Fk75Z7xVFv0NI=; b=GiSqzthqW2ZRwbgm0rqK1TNl9aGSMCUyp+bAcz64F9IRDl2O+bmq1D4C zaSmVPfwOUGreT7FsDj04QTg7+qy+fsKb6uQMBSl/sThbqPiADFu4QyNl 7MvldZgq9geH+0hYMz75UhGXsR+2OkEeXgINWnOUDa99NQ3TpNPXbQenA w=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: TEp3lFiQCKdFcOnbcMELEiY57LjMHq9nWflMVXnA4QGUeCG7MaikXmLDWaPjXq2buvsKTXYVer aTROEza9lzQXnohAeQlKtiLW4qaVa5YFycHGuyLG0hN6rQVJhx5a91c/q/hjEA3sWNlIcW45HU FBb5/D0Lm53u1QtiT6x+NShp/0hXY2IHtSy96aeQ9Hlus/a9Y87qTBQ9tLV8afymE71uouGrSk NgvsXUdS+FTqlspecNKSweRyiTWAa+linCCxiUx+2pn+e6WXX/NCo10gl88TcO8Iaov3sl30yg qRRcOUicFyIvj89y2jp73PpM X-SBRS: 5.1 X-MesageID: 53993479 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:DyHrDaywYbFr/qAmlg9xKrPwKr1zdoMgy1knxilNoRw8SKOlfq eV7ZMmPH7P+U8ssR4b+OxoVJPsfZqYz+8W3WBzB8bHYOCFgguVxehZhOOIqQEIWReOk9K1vZ 0QFZSWY+efMbEVt6rHCXGDYrUd/OU= X-IronPort-AV: E=Sophos;i="5.85,277,1624334400"; d="scan'208";a="53993479" From: Anthony PERARD To: CC: Andrew Cooper , Jan Beulich , Anthony PERARD , "Daniel De Graaf" , "Daniel P. Smith" , Ian Jackson , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini Subject: [XEN PATCH 2/2] build: add --full to version.sh to guess $(XEN_FULLVERSION) Date: Wed, 8 Sep 2021 10:54:22 +0100 Message-ID: <20210908095422.438324-3-anthony.perard@citrix.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20210908095422.438324-1-anthony.perard@citrix.com> References: <20210908095422.438324-1-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Running $(MAKE) like that in a $(shell ) while parsing the Makefile doesn't work reliably. In some case, make will complain with "jobserver unavailable: using -j1. Add '+' to parent make rule.", which will be part of "$(make xenversion)" output. It isn't possible to distinguish between the output produced by the target "xenversion" and `make`'s own output. Instead of running make, this patch "improve" `version.sh` to try to guess the output of `make xenversion`. This only works as long as $(XEN_VENDORVERSION) isn't set, or $(XEN_EXTRAVERSION) isn't overridden. This fix GitLab CI's build job "debian-unstable-gcc-arm64" on which $(shell $(MAKE) xenversion) in "flask/policy/Makefile.common" reliably produce more output than just the xenversion. This patch also allows to run for example `make --debug=a` without breaking the build when flask policy is enabled. Signed-off-by: Anthony PERARD --- tools/flask/policy/Makefile.common | 2 +- version.sh | 15 ++++++++++++++- 2 files changed, 15 insertions(+), 2 deletions(-) diff --git a/tools/flask/policy/Makefile.common b/tools/flask/policy/Makefile.common index bea5ba4b6a40..7f470cd02861 100644 --- a/tools/flask/policy/Makefile.common +++ b/tools/flask/policy/Makefile.common @@ -35,7 +35,7 @@ OUTPUT_POLICY ?= $(BEST_POLICY_VER) # ######################################## -POLICY_FILENAME = $(FLASK_BUILD_DIR)/xenpolicy-$(shell $(MAKE) -C $(XEN_ROOT)/xen xenversion --no-print-directory) +POLICY_FILENAME = $(FLASK_BUILD_DIR)/xenpolicy-$(shell $(XEN_ROOT)/version.sh --full $(XEN_ROOT)/xen/Makefile) POLICY_LOADPATH = /boot # List of policy versions supported by the hypervisor diff --git a/version.sh b/version.sh index e894ee7e0469..abd19ce79ac8 100755 --- a/version.sh +++ b/version.sh @@ -1,5 +1,18 @@ #!/bin/sh +opt_full=false +while [ $# -gt 1 ]; do + case "$1" in + --full) opt_full=true ;; + *) break ;; + esac + shift +done + MAJOR=`grep "export XEN_VERSION" $1 | sed 's/.*=//g' | tr -s " "` MINOR=`grep "export XEN_SUBVERSION" $1 | sed 's/.*=//g' | tr -s " "` -printf "%d.%d" $MAJOR $MINOR + +if $opt_full; then + EXTRAVERSION=$(grep "export XEN_EXTRAVERSION" $1 | sed 's/^.* ?=\s\+//; s/\$([^)]*)//g; s/ //g') +fi +printf "%d.%d%s" $MAJOR $MINOR $EXTRAVERSION -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Wed Sep 08 09:54:44 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Sep 2021 09:54:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.181622.328878 (Exim 4.92) (envelope-from ) id 1mNuI0-0003VV-HE; Wed, 08 Sep 2021 09:54:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 181622.328878; Wed, 08 Sep 2021 09:54:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNuI0-0003VE-DC; Wed, 08 Sep 2021 09:54:44 +0000 Received: by outflank-mailman (input) for mailman id 181622; Wed, 08 Sep 2021 09:54:43 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNuHz-0001EI-4x for xen-devel@lists.xenproject.org; Wed, 08 Sep 2021 09:54:43 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (unknown [40.107.7.45]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id c2f1fdc4-108a-11ec-b148-12813bfff9fa; Wed, 08 Sep 2021 09:54:31 +0000 (UTC) Received: from AS8PR04CA0170.eurprd04.prod.outlook.com (2603:10a6:20b:331::25) by AM5PR0801MB1745.eurprd08.prod.outlook.com (2603:10a6:203:3a::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.23; Wed, 8 Sep 2021 09:54:20 +0000 Received: from VE1EUR03FT044.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:331:cafe::10) by AS8PR04CA0170.outlook.office365.com (2603:10a6:20b:331::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14 via Frontend Transport; Wed, 8 Sep 2021 09:54:20 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT044.mail.protection.outlook.com (10.152.19.106) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Wed, 8 Sep 2021 09:54:20 +0000 Received: ("Tessian outbound 0ec886cb54dd:v105"); Wed, 08 Sep 2021 09:54:19 +0000 Received: from a14e68f2d9c3.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id DD5C5540-293F-4767-9609-8CF34A47C456.1; Wed, 08 Sep 2021 09:54:14 +0000 Received: from EUR02-AM5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id a14e68f2d9c3.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 08 Sep 2021 09:54:14 +0000 Received: from PR0P264CA0185.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:1c::29) by PAXPR08MB7033.eurprd08.prod.outlook.com (2603:10a6:102:205::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.24; Wed, 8 Sep 2021 09:54:12 +0000 Received: from VE1EUR03FT041.eop-EUR03.prod.protection.outlook.com (2603:10a6:100:1c:cafe::7) by PR0P264CA0185.outlook.office365.com (2603:10a6:100:1c::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14 via Frontend Transport; Wed, 8 Sep 2021 09:54:12 +0000 Received: from nebula.arm.com (40.67.248.234) by VE1EUR03FT041.mail.protection.outlook.com (10.152.19.163) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.4478.19 via Frontend Transport; Wed, 8 Sep 2021 09:54:12 +0000 Received: from AZ-NEU-EX01.Emea.Arm.com (10.251.26.4) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2308.14; Wed, 8 Sep 2021 09:54:16 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX01.Emea.Arm.com (10.251.26.4) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14; Wed, 8 Sep 2021 09:54:08 +0000 Received: from penny.shanghai.arm.com (10.169.190.66) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2308.14 via Frontend Transport; Wed, 8 Sep 2021 09:54:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c2f1fdc4-108a-11ec-b148-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VWaJ31sy4Cs8NaQhMRjrM5i+mYxMfjvIRjfogEWDwok=; b=ADdZ4P/coQ35CGkuuOyodRvhsQCgHL8tdCdcvXXTx/6Gxirwxr7u47BZk8+OQL8/CifC/xmi3e+1QRvl6kNR5TfC9LweWA7PFX0bZE11Vc8aUPsyJg1LKochit52pNyyv+qkCVQm1QuTDQlGz/kA5LarnRMuw4Czu74K43o9928= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: b74c3c38bd22e03a X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OCGByYaeyKtAb8BiUooJCHGJJ8zpbkoev5qp1lgNYUHAKVyVKqcm9hkr6YVfp+fjkR66G19atRNAUiGq6ftwWCpbUioHJc601UD3+gDByhKbYco9PxARP75fFKwYYyoTZlU9mXiUrqtq8pUSzDaFe6a105BDVjV1vOX6XMe+BcaT1Sv0wUhiLcYg3Y+0GuD5kdq39fHIs+ZtmNtfadQ1ceu3HyQV/dkJk7GJQquAOwNcyP8ew44ZmM2ZBdu58Fg8J6AKqkCehSQVAlKiCZzKscvC8qR46dC4wsNbqb0Gdgjm4Isrs1DNNG9TugICsbmfbHI7w+cdnkQHlGc8xEAsnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=VWaJ31sy4Cs8NaQhMRjrM5i+mYxMfjvIRjfogEWDwok=; b=S2Kk/A4P1zrQSJjFJf8qln9Uur3sCwvsh1b8EeSGnd3kP5F3J4e0jR6wi7BitSaVrx/Y/Jjv6iZ7/to6uNBOMT1OuV9l9ZSu3Sd1QrzqwlA4NW0suItxdLXmBc3mED2vmndVoHd//2CMpxiJwgEHn8l5o21mbLLy/8NR7Fx7UZGOe3xl09YISM2tUQ5HPm0o4FpbrWBEUMbAy0y7NI5rBwTstujfERMpA7uZjxD+G5SiAiXB8jbFunFn4KrHvcsjnZrVtQ5cgjwzYSqBXbA5zKUDxGB7PVuMmS3O+9vq7SZWF/MsmFDKLdAzLh9dDD+kRlrCrrKhkOP3wZJ9xD5acw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VWaJ31sy4Cs8NaQhMRjrM5i+mYxMfjvIRjfogEWDwok=; b=ADdZ4P/coQ35CGkuuOyodRvhsQCgHL8tdCdcvXXTx/6Gxirwxr7u47BZk8+OQL8/CifC/xmi3e+1QRvl6kNR5TfC9LweWA7PFX0bZE11Vc8aUPsyJg1LKochit52pNyyv+qkCVQm1QuTDQlGz/kA5LarnRMuw4Czu74K43o9928= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; From: Penny Zheng To: , , CC: , , Subject: [PATCH v6 4/7] xen/arm: static memory initialization Date: Wed, 8 Sep 2021 09:52:45 +0000 Message-ID: <20210908095248.545981-5-penny.zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210908095248.545981-1-penny.zheng@arm.com> References: <20210908095248.545981-1-penny.zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d308a56e-e3b3-49a4-f2c7-08d972aea11b X-MS-TrafficTypeDiagnostic: PAXPR08MB7033:|AM5PR0801MB1745: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:207;OLM:207; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: ld7uyxPh7vBV7epAQhqr2GgiIKpuSfE7ghweRdu4B9JGWtPhndYkAchVe2lwHxGHNEitVqcvkwTqqv7bJz5pg7qxJ6gWEBjZpe6DoMDGzKqCaDOKpwDOiz58QvKJDtRTz22v6JyeDhal1AHMLiOV+yrXM3PiXQottMnBfxyDXYzhBk1vctIOgPdTjTaafqzM/d56Yl48GHplqCYdZtg+PiF7cRDWTRUOkAvWZmEVQmY/enZowlU8J33YcEzH+UD5XRn8BoRBlxc3Vrm3jFPEivIW4ziJQ6gpfO5zOLUa7FkjqMCYPdF32d7dJwjezJO16XHtEQPx5lva+9IJEWorDSIbxg+0zWuyaZya2P9fXuVM0yelBj/bqM6lEf27oLldbmTRRVeL5GQMNdzUlMntKXE7wCeI9loGmCoS8kriq7vXGCjlogPuUmqMRqbcyFpxzE+lo62mA/F8/Zz5elWJLTXlRSD3u7gA5j9vjzKV1bKoloJ2Z0Ronrwbu+j4urm0K14hYY0366wlsiio/14mpaiVTiAEsqNC8NdV7hlFZV16I9+WO2y1vsbffhI9lCom2CDACYilbZ4pWtQhRIbBJmZ1o7bPW6AoSjlvWMGoM/QEtR+EJmTEJv8ehNkjSBnxJ5L/zycBT1jcReiytxPeOilbSsi7srCDNBKFprAB35/vQeI6zYA4ikPe0fFs0u14wKgue8bznfX12p7YbM4DiAbTvkMcy4hdT3DNTPoy620= X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(4636009)(376002)(346002)(396003)(39860400002)(136003)(46966006)(36840700001)(86362001)(316002)(82310400003)(26005)(70586007)(36860700001)(4326008)(336012)(8676002)(110136005)(82740400003)(8936002)(54906003)(186003)(6666004)(70206006)(426003)(1076003)(7696005)(356005)(47076005)(2906002)(36756003)(2616005)(83380400001)(5660300002)(478600001)(44832011)(81166007)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB7033 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT044.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: ea79c35b-fd2b-4ef4-cd5c-08d972ae9c9e X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: HY/1ydUxKveCzmZWY9DTLrajh29OLKuYP2XD/0JadVmUXkfVc4V/AiP0qsKhEvHCWXv0Y6ICjb/JEtOpyj0xOqBJgY1NWTQzNBAHfGWSGV3uPSKlvyhaLGaFLVV90BUrYxC6wUVqYq480td5vnRYWErSHjcT9Bnq8nHTceJ6lpyM/x4ZAa5FiqHKAxnPidc2mlzApJNr08ox4Jny51L9RE+B3di8T6s5X/cuGICNQ7N5MZGGGzFsSGyiIIY72WEJKb2ikafjY7WZTBCREhLKLrnhi2FpkBmt76CLpKiLHIXLGOphWuLkx9um+F0q3OdrN6vGlsQSBPSXRNzEPQ/ruCIdK0inYRoMRtIs9+97E2jv8fYY4+EJWBz7TYQZo89lqHkBs4IhI1ttBhZVAYVVJoLQHZIZ9SXn2RIuOOvdv/KCeJgWiWXG2VJqZTv43pHL+9SvIGwLGw+UBuXXyCavU0tAlOxt7Qzu30dYV4xzAXiMrrygo23eyRe9VsvxWp78cMJCguRvTv4gJBgznofhuIerARyGG5PM6dFIIXch37Mdb3VQHTmrUSYuLYrpezmfe6AFHFlEMzN56e/1lRob+aQr/bNtCmiKqRrp7wsgldVFrjj0RDKT1skec1nQlD4RymVF+680z8on7GJddNBkS05CQ9b609ZdSqYmDtSaheGz+HScSOQQwmxx+bGwEaVVzKvaq4hNLnZ1ey3WRSVJqw== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(396003)(39860400002)(346002)(136003)(376002)(36840700001)(46966006)(26005)(2616005)(36860700001)(81166007)(82740400003)(6666004)(107886003)(336012)(36756003)(1076003)(83380400001)(47076005)(82310400003)(86362001)(426003)(7696005)(186003)(110136005)(8676002)(316002)(8936002)(478600001)(44832011)(70206006)(5660300002)(70586007)(2906002)(54906003)(4326008);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Sep 2021 09:54:20.1347 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d308a56e-e3b3-49a4-f2c7-08d972aea11b X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT044.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0801MB1745 This patch introduces static memory initialization, during system boot-up. The new function init_staticmem_pages is responsible for static memory initialization. Helper free_staticmem_pages is the equivalent of free_heap_pages, to free nr_mfns pages of static memory. This commit also introduces a new CONFIG_STATIC_MEMORY option to wrap all static-allocation-related code. Put asynchronously scrubbing pages of static memory in TODO list. Signed-off-by: Penny Zheng --- xen/arch/arm/setup.c | 27 +++++++++++++++++++++++++++ xen/common/Kconfig | 13 +++++++++++++ xen/common/page_alloc.c | 21 +++++++++++++++++++++ xen/include/xen/mm.h | 6 ++++++ 4 files changed, 67 insertions(+) diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c index 63a908e325..5be7f2b0c2 100644 --- a/xen/arch/arm/setup.c +++ b/xen/arch/arm/setup.c @@ -609,6 +609,29 @@ static void __init init_pdx(void) } } +/* Static memory initialization */ +static void __init init_staticmem_pages(void) +{ +#ifdef CONFIG_STATIC_MEMORY + unsigned int bank; + + for ( bank = 0 ; bank < bootinfo.reserved_mem.nr_banks; bank++ ) + { + if ( bootinfo.reserved_mem.bank[bank].xen_domain ) + { + mfn_t bank_start = _mfn(PFN_UP(bootinfo.reserved_mem.bank[bank].start)); + unsigned long bank_pages = PFN_DOWN(bootinfo.reserved_mem.bank[bank].size); + mfn_t bank_end = mfn_add(bank_start, bank_pages); + + if ( mfn_x(bank_end) <= mfn_x(bank_start) ) + return; + + free_staticmem_pages(mfn_to_page(bank_start), bank_pages, false); + } + } +#endif +} + #ifdef CONFIG_ARM_32 static void __init setup_mm(void) { @@ -736,6 +759,8 @@ static void __init setup_mm(void) /* Add xenheap memory that was not already added to the boot allocator. */ init_xenheap_pages(mfn_to_maddr(xenheap_mfn_start), mfn_to_maddr(xenheap_mfn_end)); + + init_staticmem_pages(); } #else /* CONFIG_ARM_64 */ static void __init setup_mm(void) @@ -789,6 +814,8 @@ static void __init setup_mm(void) setup_frametable_mappings(ram_start, ram_end); max_page = PFN_DOWN(ram_end); + + init_staticmem_pages(); } #endif diff --git a/xen/common/Kconfig b/xen/common/Kconfig index 0ddd18e11a..3558be0dbc 100644 --- a/xen/common/Kconfig +++ b/xen/common/Kconfig @@ -67,6 +67,19 @@ config MEM_ACCESS config NEEDS_LIBELF bool +config STATIC_MEMORY + bool "Static Allocation Support (UNSUPPORTED)" if UNSUPPORTED + depends on ARM + help + Static Allocation refers to system or sub-system(domains) for + which memory areas are pre-defined by configuration using physical + address ranges. + + When enabled, memory can be statically allocated to a domain using + the property "xen,static-mem" defined in the domain configuration. + + If unsure, say N. + menu "Speculative hardening" config SPECULATIVE_HARDEN_ARRAY diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c index a3ee5eca9e..ba7adc80db 100644 --- a/xen/common/page_alloc.c +++ b/xen/common/page_alloc.c @@ -2604,6 +2604,27 @@ struct domain *get_pg_owner(domid_t domid) return pg_owner; } +#ifdef CONFIG_STATIC_MEMORY +/* Equivalent of free_heap_pages to free nr_mfns pages of static memory. */ +void __init free_staticmem_pages(struct page_info *pg, unsigned long nr_mfns, + bool need_scrub) +{ + mfn_t mfn = page_to_mfn(pg); + unsigned long i; + + for ( i = 0; i < nr_mfns; i++ ) + { + mark_page_free(&pg[i], mfn_add(mfn, i)); + + if ( need_scrub ) + { + /* TODO: asynchronous scrubbing for pages of static memory. */ + scrub_one_page(pg); + } + } +} +#endif + /* * Local variables: * mode: C diff --git a/xen/include/xen/mm.h b/xen/include/xen/mm.h index 667f9dac83..8e8fb5a615 100644 --- a/xen/include/xen/mm.h +++ b/xen/include/xen/mm.h @@ -85,6 +85,12 @@ bool scrub_free_pages(void); } while ( false ) #define FREE_XENHEAP_PAGE(p) FREE_XENHEAP_PAGES(p, 0) +#ifdef CONFIG_STATIC_MEMORY +/* These functions are for static memory */ +void free_staticmem_pages(struct page_info *pg, unsigned long nr_mfns, + bool need_scrub); +#endif + /* Map machine page range in Xen virtual address space. */ int map_pages_to_xen( unsigned long virt, -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Wed Sep 08 09:54:49 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Sep 2021 09:54:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.181626.328889 (Exim 4.92) (envelope-from ) id 1mNuI4-0004Gm-VM; Wed, 08 Sep 2021 09:54:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 181626.328889; Wed, 08 Sep 2021 09:54:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNuI4-0004GM-RB; Wed, 08 Sep 2021 09:54:48 +0000 Received: by outflank-mailman (input) for mailman id 181626; Wed, 08 Sep 2021 09:54:47 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNuI3-0000bc-HI for xen-devel@lists.xenproject.org; Wed, 08 Sep 2021 09:54:47 +0000 Received: from FRA01-PR2-obe.outbound.protection.outlook.com (unknown [40.107.12.78]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 78803600-1be9-494b-9e7c-8c98769411dc; Wed, 08 Sep 2021 09:54:31 +0000 (UTC) Received: from AM7PR02CA0014.eurprd02.prod.outlook.com (2603:10a6:20b:100::24) by PR2PR08MB4715.eurprd08.prod.outlook.com (2603:10a6:101:1d::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.22; Wed, 8 Sep 2021 09:54:30 +0000 Received: from AM5EUR03FT050.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:100:cafe::c6) by AM7PR02CA0014.outlook.office365.com (2603:10a6:20b:100::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.20 via Frontend Transport; Wed, 8 Sep 2021 09:54:29 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT050.mail.protection.outlook.com (10.152.17.47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Wed, 8 Sep 2021 09:54:29 +0000 Received: ("Tessian outbound 7a08471b1ef6:v105"); Wed, 08 Sep 2021 09:54:29 +0000 Received: from 3afc8c350cb9.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 7BF624EC-5049-42E5-91B8-05FD44A495A4.1; Wed, 08 Sep 2021 09:54:23 +0000 Received: from EUR02-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 3afc8c350cb9.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 08 Sep 2021 09:54:23 +0000 Received: from PR0P264CA0184.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:1c::28) by VI1PR08MB4447.eurprd08.prod.outlook.com (2603:10a6:803:f3::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.22; Wed, 8 Sep 2021 09:54:19 +0000 Received: from VE1EUR03FT041.eop-EUR03.prod.protection.outlook.com (2603:10a6:100:1c:cafe::6) by PR0P264CA0184.outlook.office365.com (2603:10a6:100:1c::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14 via Frontend Transport; Wed, 8 Sep 2021 09:54:19 +0000 Received: from nebula.arm.com (40.67.248.234) by VE1EUR03FT041.mail.protection.outlook.com (10.152.19.163) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.4478.19 via Frontend Transport; Wed, 8 Sep 2021 09:54:19 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.14; Wed, 8 Sep 2021 09:54:22 +0000 Received: from penny.shanghai.arm.com (10.169.190.66) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2308.14 via Frontend Transport; Wed, 8 Sep 2021 09:54:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 78803600-1be9-494b-9e7c-8c98769411dc DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Q9Xvps1nERdmkV37FMndb6oyhfDMDttEJab3tc9qnbU=; b=1H8cRACXBw54AoXOv2bne/IOQrNzoRv0sd/p/MJbAF88AnpkiVAXBPMUNkNf6C90X/04q6vQwpnX9Xg4ng8RMCtZiRR0U5Y/65h85Z5Eu4M71O9kmSmFUk011TbeEa5OyJPaz5fEO/ahpBd3heSrh6fz5JRpV1Kl1ZwD8Fz1eN4= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: 0110ddf03a380d5f X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=G0twraB4bld5XI72+NKgCux4wCa47nDs3V13g+pTOdVQWU7vtAr2CXB9+S+rvaiOx40Jh9lRAVnfjmA9vha7fD+KFaTKBfR9eFFFOyNYTOhkbMkcCLe5kjT30IZwkJQaBF3S9gyOD5T0i30MfXw3Ij0pW0wljqE0mOikHrhtNO4F/7rilhGRw9jB1VsuFntWLhi70WuvifT+cesezQZm0+Gtf21QCkpbM41moDP299W3hTu+WNcqz8XcPjjDx7aovx/GaINPbVe1NGHjYFy5j5WHjdto8GbMMywE6e2I7Lp9LSRpcHrxDrIymJ0YAYrRf/NJqvrG0hJf1Ncw1kFptA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=Q9Xvps1nERdmkV37FMndb6oyhfDMDttEJab3tc9qnbU=; b=X6dadGPLbA9nOHxzFsAjgNIUYzTwFTBWy9uXhLMA6vrznhcui89/S+m6zWW8bsvhN+3SwJ5nweeCNtkjIgG0SC34A1vbRITqGfyKxFpwrfsLzbcAppxmKRrHpDRfXDhXPP+uEiSHfBEI1HWX/oKrW/ICCdu1/oZN2bE+24UXfaNSMxWRgdUdiYtotC905KEhiyoj9i88P0xY3Vz3NrWarPqQme7OR6ZFIucis8Sqzct/uK3DzEpJDQt/DO5HA5O+546qTBpDBRNjcAyWzGOXEXqXOKWIzQA2MXSBU1q1v7IEuo4fM38bTF/o5P2nKySLYPRVcNY8nbBwAk1ZRK8VtQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Q9Xvps1nERdmkV37FMndb6oyhfDMDttEJab3tc9qnbU=; b=1H8cRACXBw54AoXOv2bne/IOQrNzoRv0sd/p/MJbAF88AnpkiVAXBPMUNkNf6C90X/04q6vQwpnX9Xg4ng8RMCtZiRR0U5Y/65h85Z5Eu4M71O9kmSmFUk011TbeEa5OyJPaz5fEO/ahpBd3heSrh6fz5JRpV1Kl1ZwD8Fz1eN4= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; From: Penny Zheng To: , , CC: , , Subject: [PATCH v6 7/7] xen/arm: introduce allocate_static_memory Date: Wed, 8 Sep 2021 09:52:48 +0000 Message-ID: <20210908095248.545981-8-penny.zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210908095248.545981-1-penny.zheng@arm.com> References: <20210908095248.545981-1-penny.zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ecfed280-6e87-429f-927b-08d972aea6ec X-MS-TrafficTypeDiagnostic: VI1PR08MB4447:|PR2PR08MB4715: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:644;OLM:644; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 1TxyTFqHUG3FWwPS6fkevvNE/gmvhc90TJ7+rEFAbKJ+HEy08xGdIwmdR9SwLc7eRazGAB8HveJVf5dh1UlzErAT+aniC/lek62ZqNEBDNEFrv4lKSGHxB8bJ7et/V2xDP9yKlfB5UwG7eGTNt/tUfPXJs51iwnP1J7jAPO88YHiDogaiqGMPZpARDQpvc3/SbOcDYBBmd+jlpvaoCeR1PLz7KgAUcr0kIZOdRJFDgBm1c07j8fhKMYgckNDdNnhT14DoxD0XTXVtVb9xIQ+s/gkR0uaeJktuGogs/LpBIb0e87WI2cpHIuQDAXC4Gyc6A2+ya8tFJ6VVjRApw1I/263PbWib/GT7AAuhJIfg8iobmN8D1JD5BoUaxBUYFzOhr7/8HhEyb/fIV3WZYT4pntE9++IlZMOJrBcC1ojGw205/RZ21UJqdBPKueR4x6TvVAja6eO63MI4+IKC5g6J1HXTTggbwmgQHy47DbouUrXKkdm7Ecpf8V/wR1JNzO/9VWSNBmaBFWcgZbkorYNGCyB9623jaPSIw0yh8AguY5ycoNSRVux85rza/qRFkjMSnPXwPSXpRr3wdUcFuvNSTyZsgTe6HP8U/ON6qWlCKzb8LgBb1dSPhLcR7ych3op0jjrwVFCo3ZzXZYR3c/CmycnkeOalTwGwoSMXiIVe5qExTu8HFJiGlLeNfnqcoSA9ETL+1P+Y/KYJbV6RHkXsw8GvlBZvrjNj6JiZY2bn/g= X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(4636009)(39860400002)(376002)(396003)(136003)(346002)(46966006)(36840700001)(26005)(8936002)(70206006)(70586007)(110136005)(54906003)(4326008)(186003)(2906002)(316002)(81166007)(82740400003)(7696005)(5660300002)(336012)(83380400001)(47076005)(6666004)(356005)(82310400003)(478600001)(36860700001)(8676002)(1076003)(2616005)(36756003)(426003)(44832011)(86362001)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB4447 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT050.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 1a1e78b6-238c-4d93-88ed-08d972aea083 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: V3mU7NCkvMGrOPE7LXMqB7IInLn2g5kcbrhyRcuq3riN0jdwqdveK5w73qKRwz4rWyqrULvVVzjt1m9vNtAwC4F3ncCeeuJWSV5c0W3/ZsEpGide4yCQV7PL1Om33T6AaCOgX2l400zJw6h8fBZtoxOTXjBUpknXtHJpFLXqtfTtoWMVew+7+JHMVNIfFTqj0GmdccMnhrt2EIC1JORlXqAowMLNdVwAtyxHh48GbAT/PCOBL/4PfAEAqsuNeSAUL6xHKG1d2IHPCWnZqyd1XlFjuLIG0YJa7al6MDQHkzYZ9vdhZdCTXhp2lWI8nwBLaVEVlaa3KbGpXjPYILnGEuqOmoKipclnnev0n0zxZrwBpsXQ5ExB5U9Sa56dhtqefWu45g2sIgf/s7R0Q6jmF6UH0T8SYpCrvQbTooHbkeRjjAoCVxyZ54RfvwhtikZl7kcrDDaxHQNmjeUhImqj1nlzownv0qqKyY7ndAMvhQT5qIOEOEUWXGlLES46SRIZB5cT5ZQ+aFisMRUtc3goIg5CF9lJywIRGj514xa2yYNA7n5NpfmSclL9kRWbFBPVyCEYxy8KPOEnOcVLsONge94pHIUR+BbEDt3t+V0E3bEo+iTJR4kd+e7+Z/e5gMM12ikT4O3KrNXnE42kJEVPvQzG2QbGNo4yVB97hCWYf4KqTsms98JHsyMWjdn9Y3DIVvKmq9NkDKDSum4TuO6bsw== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(346002)(39860400002)(136003)(376002)(396003)(46966006)(36840700001)(2616005)(186003)(336012)(82740400003)(426003)(83380400001)(107886003)(82310400003)(36756003)(47076005)(8676002)(70206006)(6666004)(26005)(70586007)(8936002)(478600001)(81166007)(36860700001)(2906002)(5660300002)(7696005)(44832011)(4326008)(54906003)(1076003)(316002)(110136005)(86362001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Sep 2021 09:54:29.9214 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ecfed280-6e87-429f-927b-08d972aea6ec X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT050.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR2PR08MB4715 This commit introduces a new function allocate_static_memory to allocate static memory as guest RAM for Domain on Static Allocation. It uses acquire_domstatic_pages to acquire pre-configured static memory for this domain, and uses guest_physmap_add_pages to set up P2M table. These pre-defined static memory banks shall be mapped to the usual guest memory addresses (GUEST_RAM0_BASE, GUEST_RAM1_BASE) defined by xen/include/public/arch-arm.h. In order to deal with the trouble of count-to-order conversion when page number is not in a power-of-two, this commit exports p2m_insert_mapping and introduce a new function guest_physmap_add_pages to cope with adding guest RAM p2m mapping with nr_pages. Signed-off-by: Penny Zheng --- xen/arch/arm/domain_build.c | 161 +++++++++++++++++++++++++++++++++++- xen/arch/arm/p2m.c | 7 +- xen/include/asm-arm/p2m.h | 11 +++ 3 files changed, 173 insertions(+), 6 deletions(-) diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index 206038d1c0..b011cc4789 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -480,6 +480,162 @@ fail: (unsigned long)kinfo->unassigned_mem >> 10); } +#ifdef CONFIG_STATIC_MEMORY +static bool __init append_static_memory_to_bank(struct domain *d, + struct membank *bank, + mfn_t smfn, + paddr_t size) +{ + int res; + unsigned int nr_pages = PFN_DOWN(size); + /* Infer next GFN. */ + gfn_t sgfn = gaddr_to_gfn(bank->start + bank->size); + + res = guest_physmap_add_pages(d, sgfn, smfn, nr_pages); + if ( res ) + { + dprintk(XENLOG_ERR, "Failed to map pages to DOMU: %d", res); + return false; + } + + bank->size = bank->size + size; + + return true; +} + +/* Allocate memory from static memory as RAM for one specific domain d. */ +static void __init allocate_static_memory(struct domain *d, + struct kernel_info *kinfo, + const struct dt_device_node *node) +{ + const struct dt_property *prop; + u32 addr_cells, size_cells, reg_cells; + unsigned int nr_banks, gbank, bank = 0; + const uint64_t rambase[] = GUEST_RAM_BANK_BASES; + const uint64_t ramsize[] = GUEST_RAM_BANK_SIZES; + const __be32 *cell; + u64 tot_size = 0; + paddr_t pbase, psize, gsize; + mfn_t smfn; + int res; + + prop = dt_find_property(node, "xen,static-mem", NULL); + if ( !dt_property_read_u32(node, "#xen,static-mem-address-cells", + &addr_cells) ) + { + printk(XENLOG_ERR + "%pd: failed to read \"#xen,static-mem-address-cells\".\n", d); + goto fail; + } + + if ( !dt_property_read_u32(node, "#xen,static-mem-size-cells", + &size_cells) ) + { + printk(XENLOG_ERR + "%pd: failed to read \"#xen,static-mem-size-cells\".\n", d); + goto fail; + } + reg_cells = addr_cells + size_cells; + + /* + * The static memory will be mapped in the guest at the usual guest memory + * addresses (GUEST_RAM0_BASE, GUEST_RAM1_BASE) defined by + * xen/include/public/arch-arm.h. + */ + gbank = 0; + gsize = ramsize[gbank]; + kinfo->mem.bank[gbank].start = rambase[gbank]; + + cell = (const __be32 *)prop->value; + nr_banks = (prop->length) / (reg_cells * sizeof (u32)); + + for ( ; bank < nr_banks; bank++ ) + { + device_tree_get_reg(&cell, addr_cells, size_cells, &pbase, &psize); + ASSERT(IS_ALIGNED(pbase, PAGE_SIZE) && IS_ALIGNED(psize, PAGE_SIZE)); + + smfn = maddr_to_mfn(pbase); + res = acquire_domstatic_pages(d, smfn, PFN_DOWN(psize), 0); + if ( res ) + { + printk(XENLOG_ERR + "%pd: failed to acquire static memory: %d.\n", d, res); + goto fail; + } + + printk(XENLOG_INFO "%pd: STATIC BANK[%u] %#"PRIpaddr"-%#"PRIpaddr"\n", + d, bank, pbase, pbase + psize); + + while ( 1 ) + { + /* Map as much as possible the static range to the guest bank */ + if ( !append_static_memory_to_bank(d, &kinfo->mem.bank[gbank], smfn, + min(psize, gsize)) ) + goto fail; + + /* + * The current physical bank is fully mapped. + * Handle the next physical bank. + */ + if ( gsize >= psize ) + { + gsize = gsize - psize; + break; + } + /* + * When current guest bank is not enough to map, exhaust + * the current one and seek to the next. + * Before seeking to the next, check if we still have available + * guest bank. + */ + else if ( (gbank + 1) >= GUEST_RAM_BANKS ) + { + printk(XENLOG_ERR "Exhausted all possible guest banks.\n"); + goto fail; + } + else + { + psize = psize - gsize; + smfn = mfn_add(smfn, gsize >> PAGE_SHIFT); + /* Update to the next guest bank. */ + gbank++; + gsize = ramsize[gbank]; + kinfo->mem.bank[gbank].start = rambase[gbank]; + } + } + + tot_size += psize; + } + + kinfo->mem.nr_banks = ++gbank; + + kinfo->unassigned_mem -= tot_size; + /* + * The property 'memory' should match the amount of memory given to the + * guest. + * Currently, it is only possible to either acquire static memory or let + * Xen allocate. *Mixing* is not supported'. + */ + if ( kinfo->unassigned_mem ) + { + printk(XENLOG_ERR + "Size of \"memory\" property doesn't match up with the sum-up of \"xen,static-mem\". Unsupported configuration.\n"); + goto fail; + } + + return; + + fail: + panic("Failed to allocate requested static memory for domain %pd.", d); +} +#else +static void __init allocate_static_memory(struct domain *d, + struct kernel_info *kinfo, + const struct dt_device_node *node) +{ +} +#endif + static int __init write_properties(struct domain *d, struct kernel_info *kinfo, const struct dt_device_node *node) { @@ -2453,7 +2609,10 @@ static int __init construct_domU(struct domain *d, /* type must be set before allocate memory */ d->arch.type = kinfo.type; #endif - allocate_memory(d, &kinfo); + if ( !dt_find_property(node, "xen,static-mem", NULL) ) + allocate_memory(d, &kinfo); + else + allocate_static_memory(d, &kinfo, node); rc = prepare_dtb_domU(d, &kinfo); if ( rc < 0 ) diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c index eff9a105e7..6e01e83967 100644 --- a/xen/arch/arm/p2m.c +++ b/xen/arch/arm/p2m.c @@ -1293,11 +1293,8 @@ out: return resolved; } -static inline int p2m_insert_mapping(struct domain *d, - gfn_t start_gfn, - unsigned long nr, - mfn_t mfn, - p2m_type_t t) +int p2m_insert_mapping(struct domain *d, gfn_t start_gfn, unsigned long nr, + mfn_t mfn, p2m_type_t t) { struct p2m_domain *p2m = p2m_get_hostp2m(d); int rc; diff --git a/xen/include/asm-arm/p2m.h b/xen/include/asm-arm/p2m.h index 6a2108398f..f885cc522b 100644 --- a/xen/include/asm-arm/p2m.h +++ b/xen/include/asm-arm/p2m.h @@ -300,6 +300,9 @@ int map_dev_mmio_region(struct domain *d, unsigned long nr, mfn_t mfn); +int p2m_insert_mapping(struct domain *d, gfn_t start_gfn, unsigned long nr, + mfn_t mfn, p2m_type_t t); + int guest_physmap_add_entry(struct domain *d, gfn_t gfn, mfn_t mfn, @@ -315,6 +318,14 @@ static inline int guest_physmap_add_page(struct domain *d, return guest_physmap_add_entry(d, gfn, mfn, page_order, p2m_ram_rw); } +static inline int guest_physmap_add_pages(struct domain *d, + gfn_t gfn, + mfn_t mfn, + unsigned int nr_pages) +{ + return p2m_insert_mapping(d, gfn, nr_pages, mfn, p2m_ram_rw); +} + mfn_t gfn_to_mfn(struct domain *d, gfn_t gfn); /* Look up a GFN and take a reference count on the backing page. */ -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Wed Sep 08 09:54:50 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Sep 2021 09:54:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.181628.328900 (Exim 4.92) (envelope-from ) id 1mNuI6-0004Zm-JX; Wed, 08 Sep 2021 09:54:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 181628.328900; Wed, 08 Sep 2021 09:54:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNuI6-0004Z9-Eq; Wed, 08 Sep 2021 09:54:50 +0000 Received: by outflank-mailman (input) for mailman id 181628; Wed, 08 Sep 2021 09:54:48 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNuI4-0001EI-4h for xen-devel@lists.xenproject.org; Wed, 08 Sep 2021 09:54:48 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (unknown [40.107.8.44]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id c4067fc8-108a-11ec-b148-12813bfff9fa; Wed, 08 Sep 2021 09:54:32 +0000 (UTC) Received: from DBBPR09CA0022.eurprd09.prod.outlook.com (2603:10a6:10:c0::34) by DBAPR08MB5717.eurprd08.prod.outlook.com (2603:10a6:10:1ae::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.21; Wed, 8 Sep 2021 09:54:29 +0000 Received: from DB5EUR03FT045.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:c0:cafe::ee) by DBBPR09CA0022.outlook.office365.com (2603:10a6:10:c0::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14 via Frontend Transport; Wed, 8 Sep 2021 09:54:29 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT045.mail.protection.outlook.com (10.152.21.164) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Wed, 8 Sep 2021 09:54:29 +0000 Received: ("Tessian outbound b48d04bf8afd:v105"); Wed, 08 Sep 2021 09:54:29 +0000 Received: from 0a083f3b0cee.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 9541EF8D-BDB2-4C5C-B993-98BB700987A7.1; Wed, 08 Sep 2021 09:54:08 +0000 Received: from EUR03-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 0a083f3b0cee.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 08 Sep 2021 09:54:08 +0000 Received: from DU2PR04CA0019.eurprd04.prod.outlook.com (2603:10a6:10:3b::24) by VI1PR08MB2814.eurprd08.prod.outlook.com (2603:10a6:802:1f::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.22; Wed, 8 Sep 2021 09:54:06 +0000 Received: from DB5EUR03FT054.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:3b:cafe::b8) by DU2PR04CA0019.outlook.office365.com (2603:10a6:10:3b::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Wed, 8 Sep 2021 09:54:06 +0000 Received: from nebula.arm.com (40.67.248.234) by DB5EUR03FT054.mail.protection.outlook.com (10.152.20.248) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.4478.19 via Frontend Transport; Wed, 8 Sep 2021 09:54:06 +0000 Received: from AZ-NEU-EX01.Emea.Arm.com (10.251.26.4) by AZ-NEU-EX03.Arm.com (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2308.14; Wed, 8 Sep 2021 09:54:11 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX01.Emea.Arm.com (10.251.26.4) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14; Wed, 8 Sep 2021 09:54:04 +0000 Received: from penny.shanghai.arm.com (10.169.190.66) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2308.14 via Frontend Transport; Wed, 8 Sep 2021 09:54:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c4067fc8-108a-11ec-b148-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MXkdwEjVyQ82/D1j1eSxQZQfJtE5JUO8wUvXNctlD2M=; b=jVs9JpcbPL22+ynUZG+fFCTyljcDWMetWM2ISdh4k8/+bhThLAQkxVZPJDB1XHOFI5j6nFG03l/T4bOyv5xx3PpMKLKJ3cL9bBRVytLcw7mn3spvuJEpxlGN5Ef/a9pRWOy0bSBo6Y6/aJRse1gyQyFxyqom0QVM6AGewRGlSyg= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: 8f4fa1b2d57f1ca3 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Zas51da3cn0wrB+jPtbEhng/oTJ5BGF73p0uZSLmSekv3DJv0LSZca7XA8LXyWL79GI7l6Sa9Ixg289KyhipO5k2UmK3k7IpVqjn3QoR5wAN6XuppM9ZkzDXJkTBjaNnCsSrmYjg6Dr8EITYHLurqupr844BBzImDOqy8PvrnsHlobqNL1RGXsjyfT2Up2QD0HZTJ8V5S36bRZHyNI2tKyYd2kjPAMSLpC9YuU1o5EMrL+SZxzUlM/PO8wohVrU7C3Lb+DHRvA8XkkZ3atZH24rqVlKCug8/AtC1AeQgbTi4ePJGs9CSxibezV00pFKLwW45AL2p4wzVC7dn7ZO4KA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=MXkdwEjVyQ82/D1j1eSxQZQfJtE5JUO8wUvXNctlD2M=; b=VODPylCXW9DRdpWek+PUtrzAicCTB/ZR0jOGe3By8rltTkEGwh4uIergf3dURf+zThfWiNjEjit8RA1ZUG/GGvocTp1hGfNsYMvJyGDfPD/CCpI/RN5vqukhsHhdMj1VtEEaf0OEvM2Kh3rG7HBZyXWzG18DVnLaU3wSOu2pA+tHSMNMpp/WWTLbl+BJCYyulpSZCUo+ac0PFZO1tw89XSLnRI+CI4Op7rCVy4xjqh8rHRILH8vMx34YOpKB2GHyFxEbRv6tW/eM40N9BZGcUeU5C3ZcHzjizQ86mtDNSJ6HsNbV68uAFK3cHhisWKSzSj+ql051s70vUMKNXSSepw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MXkdwEjVyQ82/D1j1eSxQZQfJtE5JUO8wUvXNctlD2M=; b=jVs9JpcbPL22+ynUZG+fFCTyljcDWMetWM2ISdh4k8/+bhThLAQkxVZPJDB1XHOFI5j6nFG03l/T4bOyv5xx3PpMKLKJ3cL9bBRVytLcw7mn3spvuJEpxlGN5Ef/a9pRWOy0bSBo6Y6/aJRse1gyQyFxyqom0QVM6AGewRGlSyg= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; From: Penny Zheng To: , , CC: , , Subject: [PATCH v6 2/7] xen/arm: introduce domain on Static Allocation Date: Wed, 8 Sep 2021 09:52:43 +0000 Message-ID: <20210908095248.545981-3-penny.zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210908095248.545981-1-penny.zheng@arm.com> References: <20210908095248.545981-1-penny.zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 14296cbc-908d-4340-a8a5-08d972aea66a X-MS-TrafficTypeDiagnostic: VI1PR08MB2814:|DBAPR08MB5717: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:8882;OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: LuIu0+pxr56YjVQdUDpyJ+gR2ldmA70kBn2fBEG8oVQJFLdkO/Ul42sid/6FWDHmUtq9gB8w/C2X5evd3wkF141bNGz56MwVH5FsWrH4RO6gD2yvVOxij7+St3XMlUsMY1PRv3VIKPFuqnIgb/ozHdVsH0Yp+/QXn+ikny5wRYCwJjBunpBGS+8wKdnh5gbAzXneE2HsA4VnfHdpMnirLZi+RjbYwCvAaovMCZ4vf9qD3Egl7qS8eMgp+g2AQDW8sKzEDBwVFxBZMijVJUMsLEjM1qiI6RctvfAELYmeN+zamsb2KYTjbnWiT1mgtqmB9fsgm/dFU5zkI0RAkqy1lBczrGvs7RXn8/JiG6CaBX7esACf+OlFeoCJgom04NCXc9ePcyP/pRsYrh3ms3BSeciAl8qox4k0n2WN9V5PTShOuecDIT+Kly0gL0lRUeXOW1DjxJC1PEQ0KDRYe34pVtdALrscJWQLFa7+xWcLvuUqgLxVSD10d3qivcj5NipjEZI/0aKmHh7EKCXk+vtfc3BzSJbXKgX7ZD4xhp8gAUfThRe5R+LZrKo7wXyqS4t2h1VfBZOgFBa8lZAkLZXV2v0YU6HHxEmqctjkRASVxkauRznlMPIEELJCqcrmrj13mR0fyiiC31XS1icdZYkIdMfMtLPbKiyNC4ejuG6Q3VoVPP08ORAHqy+f0p/E9BfUMaTqlBMDcBN+26YdDFeD3ikoR0+6JuPTLKTmkpYPLvo= X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(4636009)(396003)(346002)(136003)(376002)(39860400002)(36840700001)(46966006)(1076003)(82740400003)(6666004)(83380400001)(2906002)(36756003)(110136005)(5660300002)(86362001)(54906003)(7696005)(82310400003)(44832011)(4326008)(478600001)(47076005)(186003)(36860700001)(81166007)(8936002)(70206006)(356005)(70586007)(336012)(26005)(8676002)(2616005)(316002)(426003)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB2814 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT045.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: ca927daa-0fb8-49a1-4a09-08d972ae98bb X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: PeQjW98bbKWCZUD1BXubt1SIO2xgvOs+wnBCilTNnJNJmSN5HtEqwHQWR0l0hxf1tmG1EJZ1xr71Z4F2vxxCbeN4QopyIovKq8b4PeVZiv29fdbKdWDaTS1+uFNzxA29Wvt8BUMgXpBSY5m00SrSacSSQzq2NaWTeO6bsqGAjMHIYmeDgTP86UA2ymW4pwYvdXXASDwHbg44kTia43lZPK1CpAScjmZqid4mVPqMrsOzU9SUEf7YVUwV9uteLu9w51bzNhji57Naoy2HDVt6zm1lVILYkbfU4cO+EZiMd/NE/IRoh1EbFtYRdhFwkSBL4KvQbPUBG1o8nqMw6EMgrda//8hz97RncAmfg8p3y6yXUyKxOyl88XBEYk35dBsgPv3LXlhmftkdZlOd/AVKKrKmvZbwe9MBHrMUN80HpGHGkoDkzYQ6W82TKx5KOjGuzvQ+kcZSmsOoVsUv35A0+I4PLvJMPkk4aMgA04uMfjCF5KjvdJQUC08a5YXB1KU49ueldg+IbXstcq1yl4Xq5tcU9pRj+9Pyxtj2khf5bkWgTlHVuHNTJ1bnzasz1N99JbqzQUA1ZGtRpC9pef3X1tmI/GDAPSUXLYSg/BejjClF2baK5CNR5aWrQzFxEU2BfbHB+rluZ+PFgaZR8k5d8GzrLXAi3/pBxM6Aaiyar8MgxgLwbJ5j4ZCNG90bAiq9y9sn1vfO2nTUgzkZaNW9MA== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(136003)(396003)(39860400002)(376002)(346002)(46966006)(36840700001)(36860700001)(426003)(81166007)(107886003)(186003)(36756003)(478600001)(5660300002)(316002)(86362001)(336012)(82310400003)(8676002)(70206006)(54906003)(70586007)(26005)(1076003)(82740400003)(110136005)(2616005)(47076005)(2906002)(6666004)(44832011)(7696005)(8936002)(4326008)(83380400001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Sep 2021 09:54:29.1439 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 14296cbc-908d-4340-a8a5-08d972aea66a X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT045.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR08MB5717 Static Allocation refers to system or sub-system(domains) for which memory areas are pre-defined by configuration using physical address ranges. Those pre-defined memory, -- Static Memory, as parts of RAM reserved in the beginning, shall never go to heap allocator or boot allocator for any use. Memory can be statically allocated to a domain using the property "xen,static- mem" defined in the domain configuration. The number of cells for the address and the size must be defined using respectively the properties "#xen,static-mem-address-cells" and "#xen,static-mem-size-cells". The property 'memory' is still needed and should match the amount of memory given to the guest. Currently, it either comes from static memory or lets Xen allocate from heap. *Mixing* is not supported. The static memory will be mapped in the guest at the usual guest memory addresses (GUEST_RAM0_BASE, GUEST_RAM1_BASE) defined by xen/include/public/arch-arm.h. This patch introduces this new `xen,static-mem` feature, and also documents and parses this new attribute at boot time. This patch also introduces a new field "bool xen_domain" in "struct membank" to tell whether the memory bank is reserved as the whole hardware resource, or bind to a xen domain node, through "xen,static-mem" Signed-off-by: Penny Zheng --- docs/misc/arm/device-tree/booting.txt | 42 +++++++++++++++++++++++++++ xen/arch/arm/bootfdt.c | 30 +++++++++++++++++-- xen/include/asm-arm/setup.h | 1 + 3 files changed, 71 insertions(+), 2 deletions(-) diff --git a/docs/misc/arm/device-tree/booting.txt b/docs/misc/arm/device-tree/booting.txt index 5243bc7fd3..44cd9e1a9a 100644 --- a/docs/misc/arm/device-tree/booting.txt +++ b/docs/misc/arm/device-tree/booting.txt @@ -268,3 +268,45 @@ The DTB fragment is loaded at 0xc000000 in the example above. It should follow the convention explained in docs/misc/arm/passthrough.txt. The DTB fragment will be added to the guest device tree, so that the guest kernel will be able to discover the device. + + +Static Allocation +============= + +Static Allocation refers to system or sub-system(domains) for which memory +areas are pre-defined by configuration using physical address ranges. + +Memory can be statically allocated to a domain using the property "xen,static- +mem" defined in the domain configuration. The number of cells for the address +and the size must be defined using respectively the properties +"#xen,static-mem-address-cells" and "#xen,static-mem-size-cells". + +The property 'memory' is still needed and should match the amount of memory +given to the guest. Currently, it either comes from static memory or lets Xen +allocate from heap. *Mixing* is not supported. + +The static memory will be mapped in the guest at the usual guest memory +addresses (GUEST_RAM0_BASE, GUEST_RAM1_BASE) defined by +xen/include/public/arch-arm.h. + +Below is an example on how to specify the static memory region in the +device-tree: + + / { + chosen { + domU1 { + compatible = "xen,domain"; + #address-cells = <0x2>; + #size-cells = <0x2>; + cpus = <2>; + memory = <0x0 0x80000>; + #xen,static-mem-address-cells = <0x1>; + #xen,static-mem-size-cells = <0x1>; + xen,static-mem = <0x30000000 0x20000000>; + ... + }; + }; + }; + +This will reserve a 512MB region starting at the host physical address +0x30000000 to be exclusively used by DomU1. diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c index b01badda3e..afaa0e249b 100644 --- a/xen/arch/arm/bootfdt.c +++ b/xen/arch/arm/bootfdt.c @@ -66,7 +66,7 @@ void __init device_tree_get_reg(const __be32 **cell, u32 address_cells, static int __init device_tree_get_meminfo(const void *fdt, int node, const char *prop_name, u32 address_cells, u32 size_cells, - void *data) + void *data, bool xen_domain) { const struct fdt_property *prop; unsigned int i, banks; @@ -97,6 +97,7 @@ static int __init device_tree_get_meminfo(const void *fdt, int node, continue; mem->bank[mem->nr_banks].start = start; mem->bank[mem->nr_banks].size = size; + mem->bank[mem->nr_banks].xen_domain = xen_domain; mem->nr_banks++; } @@ -185,7 +186,8 @@ static int __init process_memory_node(const void *fdt, int node, u32 address_cells, u32 size_cells, void *data) { - return device_tree_get_meminfo(fdt, node, "reg", address_cells, size_cells, data); + return device_tree_get_meminfo(fdt, node, "reg", address_cells, size_cells, + data, false); } static int __init process_reserved_memory_node(const void *fdt, int node, @@ -339,6 +341,28 @@ static void __init process_chosen_node(const void *fdt, int node, add_boot_module(BOOTMOD_RAMDISK, start, end-start, false); } +static int __init process_domain_node(const void *fdt, int node, + const char *name, + u32 address_cells, u32 size_cells) +{ + const struct fdt_property *prop; + + printk("Checking for \"xen,static-mem\" in domain node\n"); + + prop = fdt_get_property(fdt, node, "xen,static-mem", NULL); + if ( !prop ) + /* No "xen,static-mem" present. */ + return 0; + + address_cells = device_tree_get_u32(fdt, node, + "#xen,static-mem-address-cells", 0); + size_cells = device_tree_get_u32(fdt, node, + "#xen,static-mem-size-cells", 0); + + return device_tree_get_meminfo(fdt, node, "xen,static-mem", address_cells, + size_cells, &bootinfo.reserved_mem, true); +} + static int __init early_scan_node(const void *fdt, int node, const char *name, int depth, u32 address_cells, u32 size_cells, @@ -357,6 +381,8 @@ static int __init early_scan_node(const void *fdt, process_multiboot_node(fdt, node, name, address_cells, size_cells); else if ( depth == 1 && device_tree_node_matches(fdt, node, "chosen") ) process_chosen_node(fdt, node, name, address_cells, size_cells); + else if ( depth == 2 && device_tree_node_compatible(fdt, node, "xen,domain") ) + rc = process_domain_node(fdt, node, name, address_cells, size_cells); if ( rc < 0 ) printk("fdt: node `%s': parsing failed\n", name); diff --git a/xen/include/asm-arm/setup.h b/xen/include/asm-arm/setup.h index c4b6af6029..95da0b7ab9 100644 --- a/xen/include/asm-arm/setup.h +++ b/xen/include/asm-arm/setup.h @@ -24,6 +24,7 @@ typedef enum { struct membank { paddr_t start; paddr_t size; + bool xen_domain; /* whether the memory bank is bound to a Xen domain. */ }; struct meminfo { -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Wed Sep 08 09:54:54 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Sep 2021 09:54:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.181634.328911 (Exim 4.92) (envelope-from ) id 1mNuIA-000597-2V; Wed, 08 Sep 2021 09:54:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 181634.328911; Wed, 08 Sep 2021 09:54:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNuI9-00058c-RH; Wed, 08 Sep 2021 09:54:53 +0000 Received: by outflank-mailman (input) for mailman id 181634; Wed, 08 Sep 2021 09:54:53 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNuI9-0001EI-4v for xen-devel@lists.xenproject.org; Wed, 08 Sep 2021 09:54:53 +0000 Received: from EUR03-DB5-obe.outbound.protection.outlook.com (unknown [40.107.4.77]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id c32e3227-108a-11ec-b148-12813bfff9fa; Wed, 08 Sep 2021 09:54:33 +0000 (UTC) Received: from AM7PR02CA0003.eurprd02.prod.outlook.com (2603:10a6:20b:100::13) by HE1PR0802MB2507.eurprd08.prod.outlook.com (2603:10a6:3:e1::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.21; Wed, 8 Sep 2021 09:54:28 +0000 Received: from AM5EUR03FT050.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:100:cafe::35) by AM7PR02CA0003.outlook.office365.com (2603:10a6:20b:100::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14 via Frontend Transport; Wed, 8 Sep 2021 09:54:28 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT050.mail.protection.outlook.com (10.152.17.47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Wed, 8 Sep 2021 09:54:26 +0000 Received: ("Tessian outbound 7a08471b1ef6:v105"); Wed, 08 Sep 2021 09:54:26 +0000 Received: from 74c9ed8f84e5.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 308EF0D1-ED56-442B-A907-3A37F47D11CC.1; Wed, 08 Sep 2021 09:54:20 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 74c9ed8f84e5.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 08 Sep 2021 09:54:20 +0000 Received: from PR0P264CA0172.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:1c::16) by VI1PR0801MB1662.eurprd08.prod.outlook.com (2603:10a6:800:52::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14; Wed, 8 Sep 2021 09:54:16 +0000 Received: from VE1EUR03FT041.eop-EUR03.prod.protection.outlook.com (2603:10a6:100:1c:cafe::60) by PR0P264CA0172.outlook.office365.com (2603:10a6:100:1c::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14 via Frontend Transport; Wed, 8 Sep 2021 09:54:16 +0000 Received: from nebula.arm.com (40.67.248.234) by VE1EUR03FT041.mail.protection.outlook.com (10.152.19.163) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.4478.19 via Frontend Transport; Wed, 8 Sep 2021 09:54:16 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.14; Wed, 8 Sep 2021 09:54:17 +0000 Received: from penny.shanghai.arm.com (10.169.190.66) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2308.14 via Frontend Transport; Wed, 8 Sep 2021 09:54:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c32e3227-108a-11ec-b148-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GZ922YnGKts8gghHRklqg+V1lm7yq6BNVhkDhoqkHMI=; b=oZaIAM+gZAQkg+BJPFVHM36wkQ/p/jcSkuM7oLy3d9SyhjNzPgoHCje0/gEfQQEixz0Ut0Kfhfvm+R2nIgSRDDT62rf08YcIkBuhueU0cPko15zhqOJPsyWRUa1E8+Ui0MHBp9G25VFtUDeMIa2bdzNsWhji6vf1QOeBy2MK3xM= X-MS-Exchange-Authentication-Results: spf=temperror (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; lists.xenproject.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=temperror action=none header.from=arm.com; Received-SPF: TempError (protection.outlook.com: error in processing during lookup of arm.com: DNS Timeout) X-CheckRecipientChecked: true X-CR-MTA-CID: 3a3057876d07db5c X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=R1UHluNxa+R6hIjroPCKQEv618n0gJrKd/ItShm0P+PdD4MeCghE9u90DATF9G2gLWmnoTObK+BvZasCqoIcqWSk6EAIbWYMm7OMCSSArlN+GsJGom6hNpxRrWMC+vBhlqvZYCYgk6GxKUN45tBhyrSOBQwJ4zjNCqcNtw0wZ3VUSbEMO48PpBKeijnZ+i/KQGR2Se7Mmj89SLADwfIuGGMan2JQTB2q/K4yRwJhA4yEyVPpXKliB7NiOrMWy43C5Gw9YU8QtyFPCd0V/Hs/SWxN2TPiwRYv87wqGYmQ0gX7piW8IYtifTmAIJx8Xa82I5A94dtqeEFtFH7hjP2PHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=GZ922YnGKts8gghHRklqg+V1lm7yq6BNVhkDhoqkHMI=; b=MB0KTYSaheV22jOk2JpsTHfILbwu0HG4f+6q62WBzM0bkKdPsj1JXmPZAFaVJnw6Sq08NuYgJtCGPeCJbEy8aqv/xfzGCI6ehbCKGrFe43/l+UBTNzDqGCpQZHFh7Oi7EWK12oqlRoGmX8X7vtq349Hvenb7jXppLD5QKaCWTN0mBOIzX59uM0E6rm9d4bYEtACYZwVLZlEUhQwXF6OcltcomOOh6Glw5gz8mE/8atGoXQemSCGFpmrWpRekUuwOLF0vWKq0tKvPxjwTrBkN9KxrJaf1D1OG/XE7RGGfNcf2aoaPbGkdPG31k2S7nrZfa/2Jshv/Ohdg0c5hbpDc4Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GZ922YnGKts8gghHRklqg+V1lm7yq6BNVhkDhoqkHMI=; b=oZaIAM+gZAQkg+BJPFVHM36wkQ/p/jcSkuM7oLy3d9SyhjNzPgoHCje0/gEfQQEixz0Ut0Kfhfvm+R2nIgSRDDT62rf08YcIkBuhueU0cPko15zhqOJPsyWRUa1E8+Ui0MHBp9G25VFtUDeMIa2bdzNsWhji6vf1QOeBy2MK3xM= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; From: Penny Zheng To: , , CC: , , Subject: [PATCH v6 5/7] xen: re-define assign_pages and introduce a new function assign_page Date: Wed, 8 Sep 2021 09:52:46 +0000 Message-ID: <20210908095248.545981-6-penny.zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210908095248.545981-1-penny.zheng@arm.com> References: <20210908095248.545981-1-penny.zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0467dcbc-9d1c-46db-730d-08d972aea527 X-MS-TrafficTypeDiagnostic: VI1PR0801MB1662:|HE1PR0802MB2507: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:288;OLM:288; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: uFgXCUUMY1VZxuDKCZ7RPJldeqgtMKzm8TK/lpz8Yu1v/Kb/+lgI6z81WLrkfDJTGjwAHrxgYNjIFlLgKynw6B9t7w/zjBRFFCxSd8LdnFhNPHKoO69gOIEpndt1w2GPYD5ri9F0+dxm0pR8O4nQrBY9n64RpWmYPvqee6dL0xy1IpjK+xcL/OFcaTE+1XxEHVQFAIr0JvQarhhtCSEPUDtRlGtn2G+2AutencUc7qnDkRIChKWlvKC+T90jQhHmP7SZ27qcvBCz7uCciNlyEjRy7bfs5mRbFoUCZNxVhvT1/NRfZdHE3jnR+illQZ41I+JthmZvDZweiyDDkOvoVr56zeo/u2rVP0wtvgLSL1Nn3dqRxO3yEN42jR5wxN6O+CKQJMxG0pKmu2YYF9F84YIXxPPmxmPgX8gw1aNTHqyKOnHzvkPz6/L/V/CZt/rNWj7L4WuYzsCD0aEEC+60RGcri6JtiKn7rQcDFPifq1DyyrVf0YXSaJKxeeNX+G3TBhGDZioWxulPwAj9GzZ7rivaMewFZFKVlmf8EtXY6o1fL9mYGmzLie0aO+PxU4ELgp6pQlUb0OfCkK3LL1ioo5HVgkL7xAIID8G1yFJi0GBimIM0GwKQcR1N8QqqKyfgTAVR1SgC7Hp3kTCNQByLzO7JtiqcpcWBOUvi+fVVhcxuLEfUh1ADYZpZnwJatqEGtx3Xt7Ix1TMLRDOuNAoFHMX/3jF5dIDbJmX2voWPy3k= X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(4636009)(39860400002)(136003)(376002)(346002)(396003)(36840700001)(46966006)(2906002)(1076003)(44832011)(82740400003)(356005)(2616005)(54906003)(83380400001)(26005)(81166007)(70206006)(82310400003)(8936002)(7696005)(5660300002)(70586007)(110136005)(4326008)(36860700001)(86362001)(47076005)(316002)(186003)(426003)(6666004)(336012)(36756003)(478600001)(8676002)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0801MB1662 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT050.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 0a3a3f3c-2d03-4abb-3fa9-08d972ae9ef2 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bfdLnWz4F/l5rOi4ojEeHFBdQMWWDHcVK2Kc+aKrLBzcWM5ooI9jOSCPRYVAn8VqdjKlkH0U45M6/yI+ERxZ5b6pwHV6XOdgXJD6tkcU3rbjClQ3MPltJTxJs2V0bLrO/4nPT9ec5L/NeHWz+DWPzrt8fDctZCaSlHG0sdkvdVZl3nzvQrkDjgti53lHwnUQpuFySeMpRlete10tn8YyAQ6dSKvZCttyZjyWPQfDqTZN3Lgraol3jVVfbxQna6eJIJ4tqMIY7/PYxR6rR8O50lPxs0eS/M6aMaBbp3JrrknuSN5oZAe4C1uj2jiCgs7LOVGYh5G+EysFhPha1I3AhHL24lEclbHbTuPU6f7/69xIh1miuTo0APE7R0qpvWeXLMg4/wHhYCFxlFsSgXo+aIlML0HEYRo8V4MCUPFH95ROMNA5wvo79NJmn+7DGxlVCwCvIqTHQj5dcU7l9b1ueoX2BYutD7qTE+rArBFh04I5b4zeI5JE4jQYVxsXhm64xcTESwBhLb2YhA3SSLANKyO9KcHvyx4gfUdOGAAOyqaQ13eApvIyTUcHFHG2sMSCiUWLp/ovI/piwXO55miBKuq+p7EzlV5Y6kjAGKqn285j5I/tCJepIkJVxq4v7Nc5WtFM+en5vsLT/81JJ3fyqsgb3lSavtwiAzHIzlGKJOr3ORSQFZc99FaLfDCaV1dxBOr3V8+sK9ihBkL1BtIncQ== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(39860400002)(136003)(376002)(346002)(396003)(46966006)(36840700001)(316002)(47076005)(2616005)(63370400001)(478600001)(70586007)(26005)(54906003)(2906002)(110136005)(4326008)(36860700001)(1076003)(82740400003)(5660300002)(44832011)(107886003)(82310400003)(6666004)(36756003)(186003)(81166007)(83380400001)(86362001)(426003)(63350400001)(336012)(8936002)(7696005)(8676002)(70206006);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Sep 2021 09:54:26.9728 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0467dcbc-9d1c-46db-730d-08d972aea527 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT050.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0802MB2507 In order to deal with the trouble of count-to-order conversion when page number is not in a power-of-two, this commit re-define assign_pages for nr pages and introduces a new helper assign_page for original page with a single order. Signed-off-by: Penny Zheng --- xen/arch/x86/pv/dom0_build.c | 2 +- xen/common/grant_table.c | 2 +- xen/common/memory.c | 6 +++--- xen/common/page_alloc.c | 21 +++++++++++++-------- xen/include/xen/mm.h | 6 ++++++ 5 files changed, 24 insertions(+), 13 deletions(-) diff --git a/xen/arch/x86/pv/dom0_build.c b/xen/arch/x86/pv/dom0_build.c index d7f9e04b28..7787cc8fca 100644 --- a/xen/arch/x86/pv/dom0_build.c +++ b/xen/arch/x86/pv/dom0_build.c @@ -568,7 +568,7 @@ int __init dom0_construct_pv(struct domain *d, else { while ( count-- ) - if ( assign_pages(d, mfn_to_page(_mfn(mfn++)), 0, 0) ) + if ( assign_pages(d, mfn_to_page(_mfn(mfn++)), 1, 0) ) BUG(); } initrd->mod_end = 0; diff --git a/xen/common/grant_table.c b/xen/common/grant_table.c index ee61603a97..50f5f83023 100644 --- a/xen/common/grant_table.c +++ b/xen/common/grant_table.c @@ -2358,7 +2358,7 @@ gnttab_transfer( * is respected and speculative execution is blocked accordingly */ if ( unlikely(!evaluate_nospec(okay)) || - unlikely(assign_pages(e, page, 0, MEMF_no_refcount)) ) + unlikely(assign_pages(e, page, 1, MEMF_no_refcount)) ) { bool drop_dom_ref; diff --git a/xen/common/memory.c b/xen/common/memory.c index 74babb0bd7..9cef8790ff 100644 --- a/xen/common/memory.c +++ b/xen/common/memory.c @@ -728,8 +728,8 @@ static long memory_exchange(XEN_GUEST_HANDLE_PARAM(xen_memory_exchange_t) arg) /* Assign each output page to the domain. */ for ( j = 0; (page = page_list_remove_head(&out_chunk_list)); ++j ) { - if ( assign_pages(d, page, exch.out.extent_order, - MEMF_no_refcount) ) + if ( assign_page(page, exch.out.extent_order, d, + MEMF_no_refcount) ) { unsigned long dec_count; bool_t drop_dom_ref; @@ -797,7 +797,7 @@ static long memory_exchange(XEN_GUEST_HANDLE_PARAM(xen_memory_exchange_t) arg) * cleared PGC_allocated. */ while ( (page = page_list_remove_head(&in_chunk_list)) ) - if ( assign_pages(d, page, 0, MEMF_no_refcount) ) + if ( assign_pages(d, page, 1, MEMF_no_refcount) ) { BUG_ON(!d->is_dying); free_domheap_page(page); diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c index ba7adc80db..bb19bb10ff 100644 --- a/xen/common/page_alloc.c +++ b/xen/common/page_alloc.c @@ -2261,7 +2261,7 @@ void init_domheap_pages(paddr_t ps, paddr_t pe) int assign_pages( struct domain *d, struct page_info *pg, - unsigned int order, + unsigned long nr, unsigned int memflags) { int rc = 0; @@ -2281,7 +2281,7 @@ int assign_pages( { unsigned int extra_pages = 0; - for ( i = 0; i < (1ul << order); i++ ) + for ( i = 0; i < nr; i++ ) { ASSERT(!(pg[i].count_info & ~PGC_extra)); if ( pg[i].count_info & PGC_extra ) @@ -2290,18 +2290,18 @@ int assign_pages( ASSERT(!extra_pages || ((memflags & MEMF_no_refcount) && - extra_pages == 1u << order)); + extra_pages == nr)); } #endif if ( pg[0].count_info & PGC_extra ) { - d->extra_pages += 1u << order; + d->extra_pages += nr; memflags &= ~MEMF_no_refcount; } else if ( !(memflags & MEMF_no_refcount) ) { - unsigned int tot_pages = domain_tot_pages(d) + (1 << order); + unsigned int tot_pages = domain_tot_pages(d) + nr; if ( unlikely(tot_pages > d->max_pages) ) { @@ -2313,10 +2313,10 @@ int assign_pages( } if ( !(memflags & MEMF_no_refcount) && - unlikely(domain_adjust_tot_pages(d, 1 << order) == (1 << order)) ) + unlikely(domain_adjust_tot_pages(d, nr) == nr) ) get_knownalive_domain(d); - for ( i = 0; i < (1 << order); i++ ) + for ( i = 0; i < nr; i++ ) { ASSERT(page_get_owner(&pg[i]) == NULL); page_set_owner(&pg[i], d); @@ -2331,6 +2331,11 @@ int assign_pages( return rc; } +int assign_page(struct page_info *pg, unsigned int order, struct domain *d, + unsigned int memflags) +{ + return assign_pages(d, pg, 1UL << order, memflags); +} struct page_info *alloc_domheap_pages( struct domain *d, unsigned int order, unsigned int memflags) @@ -2373,7 +2378,7 @@ struct page_info *alloc_domheap_pages( pg[i].count_info = PGC_extra; } } - if ( assign_pages(d, pg, order, memflags) ) + if ( assign_page(pg, order, d, memflags) ) { free_heap_pages(pg, order, memflags & MEMF_no_scrub); return NULL; diff --git a/xen/include/xen/mm.h b/xen/include/xen/mm.h index 8e8fb5a615..a74e93eba8 100644 --- a/xen/include/xen/mm.h +++ b/xen/include/xen/mm.h @@ -133,8 +133,14 @@ void heap_init_late(void); int assign_pages( struct domain *d, + struct page_info *pg, + unsigned long nr, + unsigned int memflags); + +int assign_page( struct page_info *pg, unsigned int order, + struct domain *d, unsigned int memflags); /* Dump info to serial console */ -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Wed Sep 08 10:03:26 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Sep 2021 10:03:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.181689.328922 (Exim 4.92) (envelope-from ) id 1mNuQK-0000El-4f; Wed, 08 Sep 2021 10:03:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 181689.328922; Wed, 08 Sep 2021 10:03:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNuQK-0000Ee-1F; Wed, 08 Sep 2021 10:03:20 +0000 Received: by outflank-mailman (input) for mailman id 181689; Wed, 08 Sep 2021 10:03:18 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNuQI-0000EY-Bu for xen-devel@lists.xenproject.org; Wed, 08 Sep 2021 10:03:18 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id fc76c11f-108b-11ec-b149-12813bfff9fa; Wed, 08 Sep 2021 10:03:17 +0000 (UTC) Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-am5eur03lp2054.outbound.protection.outlook.com [104.47.8.54]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-6-Vcc3AT0SMDaAsVXbK_HbKg-1; Wed, 08 Sep 2021 12:03:15 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR0401MB2445.eurprd04.prod.outlook.com (2603:10a6:800:55::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14; Wed, 8 Sep 2021 10:03:13 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4500.014; Wed, 8 Sep 2021 10:03:13 +0000 Received: from [10.156.60.236] (37.24.206.209) by PR3P250CA0006.EURP250.PROD.OUTLOOK.COM (2603:10a6:102:57::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14 via Frontend Transport; Wed, 8 Sep 2021 10:03:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fc76c11f-108b-11ec-b149-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1631095396; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=U4+CNeQJy/jr2vUjG+fVEAweTSeM8l6WQo+Ob8voX2E=; b=BCnS/sJ8Nk7cHbGSubSoAnQRiXbcCEcds17esOeiyiT+5hO58zMCDYdQM9kS8Mm7S7jBGF 3OQZL3T55Di6PqVcEtkuZQ/ldj0Esz24d4SENu+LZWD907RMyMgjKS/b5q9thqxgs/DP10 TNWXguYnNBWnNTGcu/CsziNFP/DsdQI= X-MC-Unique: Vcc3AT0SMDaAsVXbK_HbKg-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZdWt6YQtvw/0XHTi4ZGH5s2Xq5undt7XLvvO/C6kNxDGBSeiMR1blqr/pPvOsECVGk8erBt6+9hVZJuEvDl11bzsBYyxaR0Wai+8zhQpncop6oH0zg77Y1AftoR9FY2/x1my6VILoXGri7Tt3Afxe0s1cW159GwYGzIiOAltDwDJ/YprT9UbaXWB0X5J5TmSClMUUkeBKCLK9t7K6oxMTlFXucOJT+2ZpB78B6hiCCex3M2pBAHZi2wMbqKRv2Sb3v6kogae+Z7kkHC9rl8M/z6GcwEyX6UJvSLXrZgSmZ6EKffmw3VbBzCLYk158oK2e4Hn7wqaOuoXt3TEryi5vw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=U4+CNeQJy/jr2vUjG+fVEAweTSeM8l6WQo+Ob8voX2E=; b=ATC657B0Ld5qd3kG2jULmvSeGjSihW2k+MdI/U588suRfNPb5RU3ZAfmyvtlFSXP5bCJ692ea90Jd/GutDGUEKy3yfbi68cUtzv6Q5YK69VHrJW7Xh83wu8oZ53Zg/WEqkzsL2y+yLgFvE5GTKgG8ch5aJK19B+I6Dm8V1DL604lzysaqEFDdzysl/sEIHOLg5CKVTuO7v9CWLOYSoORo2TiIjAf9fwGd0X2XozWRY0AKi86Jm3u7nWlQTdfBRX3uNUrmMt9cPDKEwYit7sme4DxOaQds4rJVCKcdy1TR5/bk7OFiptKaZXxmKnKMVkz34yyVWYiLQHNT8ZBJ7OJfg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com; Subject: Re: [PATCH 5/9] vpci/header: Implement guest BAR register handlers To: Oleksandr Andrushchenko , Oleksandr Andrushchenko Cc: "julien@xen.org" , "sstabellini@kernel.org" , Oleksandr Tyshchenko , Volodymyr Babchuk , Artem Mygaiev , "roger.pau@citrix.com" , Bertrand Marquis , Rahul Singh , "xen-devel@lists.xenproject.org" References: <20210903100831.177748-1-andr2000@gmail.com> <20210903100831.177748-6-andr2000@gmail.com> <1848521d-4179-f5ee-e3af-f4e6738f60e6@suse.com> <2e0c2ff5-7228-a439-c8a6-50f7a022e77b@suse.com> <24624eca-766d-6841-dc90-43371f5a39ba@epam.com> <983f79a9-d72d-0704-9b04-950f858fbd7e@suse.com> From: Jan Beulich Message-ID: <80de7569-522d-656a-e9e2-9e741511963d@suse.com> Date: Wed, 8 Sep 2021 12:03:10 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PR3P250CA0006.EURP250.PROD.OUTLOOK.COM (2603:10a6:102:57::11) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: dc32e481-8487-4579-7252-08d972afdeee X-MS-TrafficTypeDiagnostic: VI1PR0401MB2445: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: sQ9FiJwfSC8bHu5C0Md487CHI0IQFldMmpP0zzZ1x1nTlJkD09GPgDEJ1Ldx8B5b6jJICTIoWgv5xV4mR+KUB3Zq0cI7YKw3eMkyaGe41t7bPKXsmiShefqraD+0GoOSkQ5DbWL9YjMOHWbMzByp6djhhEulL117f39bJtfcOg/yKs0Vls3fjYTHHQ8JvvmZ3yJbQwTZKiR2riTRr6+q7IUXj7g8APxnSxFCi17A3aPoZ9M1gtUkWbaU6X9sU8BdcuPJhuUcFqzeYm4JxjnFARL/wwM21vbXyuvhOFgBzDKIG1mXXuiDHm130U1FtZbSUnniG8nesYlB8UIPGZpkYWOkuFXoGsbPpERo6NyUhLmKuKhN0bbh8C/S20KVkCmm0t+ye/Y9PX95dofB6JXtVbgIRHpC/itZBbd0nzIYXe3yU7mFNJGRKRxmgDYqeU7dZ0WIsr+Pv7+gdUwi1UMZsvC/nSXK40Y5rPrTrz2OBuaBsFRjH5zep9NVLmrCLtZGlYD7e6lKxW4bn3afG1xUGUNLsOBn/w6btQfFmWS9VarV6otvAJ53bm/pXJWmMKxKuZzpzJB6xfdFK312459iXZKDWUb3tx0S9VUv2Xnh6Hv4I/h9dHVITML6vYlVo9dpUgQZlOQkaWCZzndXjALnEWecERzWw9k+HDSAxGK6dhBMBKyqIQMlbQ8SojTeUL1UkbPGr36pCofzUN/9qOeLH1WGQELWFNZVb5Btga8YdRRRgu0iUzxe5bpI5N95seng X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(39860400002)(136003)(376002)(346002)(396003)(86362001)(83380400001)(4326008)(5660300002)(956004)(2616005)(478600001)(2906002)(26005)(36756003)(8676002)(31696002)(53546011)(8936002)(31686004)(66946007)(66556008)(66476007)(7416002)(110136005)(38100700002)(16576012)(6486002)(54906003)(316002)(186003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UGZNQVAwVGxwcGk4VFZpSmMzRmhxMlV3ZXFuU1pNaTBQOUZCdjJPb0syOVZS?= =?utf-8?B?ZFBxaFVCQmRNQXpVTDdOUFFSLy9rL3FEbjJYbTE4TytnUVNZbXA5UGRNYUVU?= =?utf-8?B?c1NGOG91T1dPaEhaL2JMTC9jcGVDY3ZVTDBmZC95bWhuQXJhUkNqZnRwdzNE?= =?utf-8?B?bHRrRWNrL1NCTS9VbHlCM09FU1VTZndvTVVWbTdZY0V5QzdRQkdaRG5RWWQz?= =?utf-8?B?VzRhU0Q1N0tLbm9sd1BteXJmWjFldkRyYjlmRTJmK3ZsNXBwY1VuL0ZNNmxL?= =?utf-8?B?djRxaG1PSnozVDRPL0xHL1dRRS9mR1VXMEVuczAzeVhHRFg1bHBNQzBHbUZx?= =?utf-8?B?alRFOERpSXJPZ1lTdFN3UnM0NDFkMm5JMHdmUzBad3UzU0lDY04wYjNtOU9n?= =?utf-8?B?V2syb1NXeVkyZ0hrUVdxTk1SS0VQVkpzOHN4eWdOSThYL2loOVhxbkladWI0?= =?utf-8?B?R1lKQkd2QXhwcWtLRThoMTVtTU5CSGNmbTk2Z0VJOUx6dytoakNlWWtRdmdw?= =?utf-8?B?V2pqZE1QbEQrcFB6RkpkcVJpUWRLMXNDbm00cWdHVVdndGVWZFJXb2k1UnhP?= =?utf-8?B?c0cwOVhsNVhjcjF0QUl2OEdOem52dEtpRzR4NGVpOXJCR3pHZ2RMMkl1NVgy?= =?utf-8?B?MkdBcEZnanpJUXV1dDRvMzdubUR2YXBzeXRraE1INGlIcCs3aUVtS1VSVzdw?= =?utf-8?B?QldLRE93bmF5UTBuSVlPcm8wZDNzNUpXRW5GYnJmVUZVVzJFVjZnUm1jTGY0?= =?utf-8?B?VVBlWlZLVExsSGtBZmpoR3hPMGNZMW0zOXdQejV3MHNXLzNGRk5NSENuRUlX?= =?utf-8?B?aVJFeEhoSmg3eG5ta01YRUl4cHNFcFZic2o5aGV0cUIyaHluWURhU0RBeW5X?= =?utf-8?B?ZXNBTk9CTlRCeSs5a3pyOVlHU2w3RWZTTVZIalRnQVZ2c0cvNVc0L09LTGNN?= =?utf-8?B?ck9sWVBwMWEzay9WZlJuYndyQ2NIZkR2MkJMYVdwM21BMmkrUnlTZzdXY2xs?= =?utf-8?B?YnJ3bGtLL1JIbnZ1NmVLaFV3K3B3V1FVUXlzdnBmRzlGdzZPUmdWVC94ekIx?= =?utf-8?B?K1BZb3IzOGswUys3ZFZJT0YwL1drdEl1WGRNZ2ZvYy9zN1NBbmpvcnRUaVEy?= =?utf-8?B?cDYwRUViWWI2Y0hpRngxWEdubzRwUFpXblB5MDc0UzE4QmdRdjRSOGo3UFdC?= =?utf-8?B?R3lNdndxTE9jRktBNFhHVkR2WXN2bmVuL2I5TUVRTXNLM090em5SSTZqTlc2?= =?utf-8?B?V2pxM2p1S1NrRS9kMXlac0ljaWVUd1AvMG42RFJPcWc4dFBldk1rOWVmdUQ1?= =?utf-8?B?aHhvYzkzNUo4QzJwWVlWalVUdWYrYVF2TzdCYldjdS95QUp0WnpFT0dUNTIr?= =?utf-8?B?L0RkVlRvSE5ZVkdHd2NFTERRVnpYdUdreGR5TkpwUkpBVzJqY2JXMFI5L3FJ?= =?utf-8?B?WjVvNkp0eFFpalRsSG1hTHIzTTNqS0l6S0lJT0hYQTBhSzU2TUNCd2tYUll0?= =?utf-8?B?RUZPR2dySVcyMXYwQnZCcmo0K3JTbTZWTXRFVmcrMER1cW52YjZSTXJUNmZ2?= =?utf-8?B?SU5VQTdCWFpnUjlXTVNGU1YxUWRoSzRJV0M0WFFEVFpYdFRCZUFpRk1wSHBT?= =?utf-8?B?cmdxdW1RZjR1b2U1YlF3TmoyRGpldU05WEtyYS9uVVA5NWpWdTJoeGF3VzVp?= =?utf-8?B?bUpUQXZOMVJJWmxYd2FEaGtPT1QyODBEeWRBUzYrQXFkd2sxQXFOYTFmZTBM?= =?utf-8?Q?lCN387pjh1IT/3oh9Ux6TIEuTzhvxMvaBVU1/Fm?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: dc32e481-8487-4579-7252-08d972afdeee X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Sep 2021 10:03:13.5947 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: t3DwaNHHUgiHaX1/e/PvoowUtG6f1Z64r1YsIl9Va7/p94UpJIeVuic8tPJrzGAT+VMDHq4d6EnJWNTRlQ7qEQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2445 On 08.09.2021 11:43, Oleksandr Andrushchenko wrote: > > On 08.09.21 12:27, Jan Beulich wrote: >> On 07.09.2021 19:39, Oleksandr Andrushchenko wrote: >>> On 07.09.21 19:30, Jan Beulich wrote: >>>> On 07.09.2021 15:33, Oleksandr Andrushchenko wrote: >>>>> On 06.09.21 17:31, Jan Beulich wrote: >>>>>> On 03.09.2021 12:08, Oleksandr Andrushchenko wrote: >>>>>>> --- a/xen/drivers/vpci/header.c >>>>>>> +++ b/xen/drivers/vpci/header.c >>>>>>> @@ -400,12 +400,72 @@ static void bar_write(const struct pci_dev *pdev, unsigned int reg, >>>>>>> static void guest_bar_write(const struct pci_dev *pdev, unsigned int reg, >>>>>>> uint32_t val, void *data) >>>>>>> { >>>>>>> + struct vpci_bar *bar = data; >>>>>>> + bool hi = false; >>>>>>> + >>>>>>> + if ( bar->type == VPCI_BAR_MEM64_HI ) >>>>>>> + { >>>>>>> + ASSERT(reg > PCI_BASE_ADDRESS_0); >>>>>>> + bar--; >>>>>>> + hi = true; >>>>>>> + } >>>>>>> + else >>>>>>> + val &= PCI_BASE_ADDRESS_MEM_MASK; >>>>>>> + bar->guest_addr &= ~(0xffffffffull << (hi ? 32 : 0)); >>>>>>> + bar->guest_addr |= (uint64_t)val << (hi ? 32 : 0); >>>>>> What you store here is not the address that's going to be used, >>>>>> as >>>>>> you don't mask off the low bits (to account for the BAR's size). >>>>>> When a BAR gets written with all ones, all writable bits get these >>>>>> ones stored. The address of the BAR, aiui, really changes to >>>>>> (typically) close below 4Gb (in the case of a 32-bit BAR), which >>>>>> is why memory / I/O decoding should be off while sizing BARs. >>>>>> Therefore you shouldn't look for the specific "all writable bits >>>>>> are ones" pattern (or worse, as you presently do, the "all bits >>>>>> outside of the type specifier are ones" one) on the read path. >>>>>> Instead mask the value appropriately here, and simply return back >>>>>> the stored value from the read path. > > But in case of BAR sizing I need to actually return BAR size. > So, the comparison is the way to tell if the guest wants to read > actual (configured) BAR value or it tries to determine BAR's size. > This is why I compare and use the result as the answer to what needs > to be supplied to the guest. So, if I don't compare with 0xffffffff for the > hi part and 0xfffffff0 for the low then how do I know when to return > configured BAR or return the size? Well, but that's the common misunderstanding that I've been trying to point out: There's no difference between these two forms of reads. The BARs are simply registers with some r/o bits. There's no hidden 2nd register recording what was last written. When you write 0xffffffff, all you do is set all writable bits to 1. When you read back from the register, you will find all r/o bits unchanged (which in particular means all lower address bits are zero, thus allowing you to determine the size). When the spec says to write 0xffffffff for sizing purposes, OSes should follow that, yes. This doesn't preclude them to use other forms of writes for whichever purpose. Hence you do not want to special case sizing, but instead you want to emulate correctly all forms of writes, including subsequent reads to uniformly return the intended / expected values. Just to give an example (perhaps a little contrived): To size a 64-bit BAR, in principle you'd first need to write 0xffffffff to both halves. But there's nothing wrong with doing this in a different order: Act on the low half alone first, and then act on the high half. The acting on the high half could even be skipped if the low half sizing produced at least bit 31 set. Now if you were to special case seeing ffffffff:fffffff? as the last written pair of values, you'd break that (imo legitimate) alternative process of sizing. Jan From xen-devel-bounces@lists.xenproject.org Wed Sep 08 10:09:36 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Sep 2021 10:09:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.181695.328932 (Exim 4.92) (envelope-from ) id 1mNuWJ-0000v7-Qm; Wed, 08 Sep 2021 10:09:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 181695.328932; Wed, 08 Sep 2021 10:09:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNuWJ-0000v0-Nq; Wed, 08 Sep 2021 10:09:31 +0000 Received: by outflank-mailman (input) for mailman id 181695; Wed, 08 Sep 2021 10:09:30 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNuWI-0000um-Mk; Wed, 08 Sep 2021 10:09:30 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNuWI-0001sX-9S; Wed, 08 Sep 2021 10:09:30 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNuWH-0006hN-Rs; Wed, 08 Sep 2021 10:09:29 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mNuWH-0002xQ-RM; Wed, 08 Sep 2021 10:09:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=U00WU4ZXiiBY+nPWZILah4Mk/Lkfq7uGOh5TPoyiqB0=; b=VchLHLeQclUKMWp9C/oBRTNFRm GGoKuNsnZCHNoxY1bSN3lSiiraji8uTm0ZNeVAcn5Ks/PNBt6ys/VZCl/pGuDjTOp4nYOQ168zDi0 a+tIJQGFgBjfLs4o8WGWBBEwBab9HU7+83ujrq9Ouf+4sgI3K5SjFJCk+VAVcVTfrqNE=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 164877: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:guest-start/debianhvm.repeat:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=e70a9a043a5ce6d4025420f729bc473f711bf5d1 X-Osstest-Versions-That: xen=6c27a8da8d2024aa78a9ec67bcfb18c123e84a17 From: osstest service owner Date: Wed, 08 Sep 2021 10:09:29 +0000 flight 164877 xen-unstable real [real] flight 164881 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/164877/ http://logs.test-lab.xenproject.org/osstest/logs/164881/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 20 guest-start/debianhvm.repeat fail pass in 164881-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 164873 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 164873 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 164873 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 164873 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 164873 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 164873 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 164873 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 164873 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 164873 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 164873 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 164873 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen e70a9a043a5ce6d4025420f729bc473f711bf5d1 baseline version: xen 6c27a8da8d2024aa78a9ec67bcfb18c123e84a17 Last test of basis 164873 2021-09-07 11:09:27 Z 0 days Testing same since 164877 2021-09-07 21:09:03 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Anthony PERARD Jan Beulich Jane Malalane Julien Grall Wei Liu jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 6c27a8da8d..e70a9a043a e70a9a043a5ce6d4025420f729bc473f711bf5d1 -> master From xen-devel-bounces@lists.xenproject.org Wed Sep 08 10:33:11 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Sep 2021 10:33:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.181743.329019 (Exim 4.92) (envelope-from ) id 1mNut1-0005bd-Ln; Wed, 08 Sep 2021 10:32:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 181743.329019; Wed, 08 Sep 2021 10:32:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNut1-0005bW-IY; Wed, 08 Sep 2021 10:32:59 +0000 Received: by outflank-mailman (input) for mailman id 181743; Wed, 08 Sep 2021 10:32:59 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNut1-0005bQ-4v for xen-devel@lists.xenproject.org; Wed, 08 Sep 2021 10:32:59 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id ee7236d0-6d58-4690-88e8-3a712a7c7473; Wed, 08 Sep 2021 10:32:57 +0000 (UTC) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04lp2059.outbound.protection.outlook.com [104.47.14.59]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-10-_AzjD38gOF24_PKpt7JfWg-1; Wed, 08 Sep 2021 12:32:55 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR04MB4846.eurprd04.prod.outlook.com (2603:10a6:803:5b::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.21; Wed, 8 Sep 2021 10:32:53 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4500.014; Wed, 8 Sep 2021 10:32:53 +0000 Received: from [10.156.60.236] (37.24.206.209) by FR0P281CA0010.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:15::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.6 via Frontend Transport; Wed, 8 Sep 2021 10:32:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ee7236d0-6d58-4690-88e8-3a712a7c7473 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1631097176; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1D/OwiwFXsedKdK1yUIbJBrg4OkseZXV1iXwOcwtd38=; b=XoOjjHZo4tDBh5rq2Oa8B3JyOTB5Dsjchc9iMEpBAmjbNqct3cgG4/GQfEK6SlnFx84sqn JTBGXqm8KkwwxJRmZ27zdLk6XqzF9Vs1gHclZBoqjSmAYnCMf+RGchm643iPATZB4ZentU zmye5IXOM/28aUGrBT0TalsTB2ltJH0= X-MC-Unique: _AzjD38gOF24_PKpt7JfWg-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=f6XlWOjzltmSlPLlSdBRHV0LnqHFx+4WW4rWZWnapkqGPJ76MvoBcG3ZiNOwGNsgGxmO+hTdGO0CIbadcLZtElJ0SLfvoBBc21yBGltytrf9Jb+XZ6bIeT/oiFws70VmDTxt1wUQrGcbSDyIVpZh9lhZnWN3HmTsEs7MMquHKY+cXtUl+rDSEuz3JKwM+QLcIXkPiMVgv6J4HoPvh3c0aHsUKrYpUyT6MmOClM5Ydyu9zsxM0KZfjB4oRXbWlbJScVcDWulxpQ6eqVZHlNVHpNEe4OEqlou46JwpDrjCJLZ9hCJPX/jO2DNMu+3OowvHzv1XyIu+i+0mquIk0T7kxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=1D/OwiwFXsedKdK1yUIbJBrg4OkseZXV1iXwOcwtd38=; b=C+K4p6kg1fgMS6/HiZKKsqh04Lbfc9Ghcon3YYVixJORZCMxjEI8Y7thrcG8XqmaKCw/GdPdCGbrpvirS14kRqHeP2qKFIcG64so0vZFvk3yktOqfUUSToaGPWGEOw9gjyV5q782CLHuUf5XgTlj3Hv+N0VhfiIo2CmU0wnCi8A0rJNqDHOwJHPFbvY2Xca1UGTlJffj/M1eamXNzIgBkmx1o0t++nx7oDDf/mmWsGBSag+nlaQ4e3JjNEdmNnU+a468pJW5AL93BpNCR5Cwb2zKt/QaycSSryQp6MSGxRRscZJA8wZhRcEdiFCThBULR1bfJp2VjU2s1MQWEXwjQw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=suse.com; Subject: Re: [PATCH] domain: try to address Coverity pointing out a missing "break" in domain_teardown() From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu References: <20e28e4b-c794-7435-5f5c-332e9a6c0433@suse.com> Message-ID: <518201c2-1250-26fd-2105-f44a60d40dba@suse.com> Date: Wed, 8 Sep 2021 12:32:50 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: <20e28e4b-c794-7435-5f5c-332e9a6c0433@suse.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0010.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:15::15) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 381d111f-36ef-4869-78b3-08d972b4038d X-MS-TrafficTypeDiagnostic: VI1PR04MB4846: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: JCs3H9LOjrVxSPuAi03RN8XUTN6ya1XWZmL56itQoHRVYQKAXVFHcnTCIbNyOC3pZjO2siYyl8U4gUMrC9UrSkI1PsBQ7gjS4xE+g6+bZsxJWF8cNKDSjUQTJBgzrCN+tVOYVwej+nxOvilkOPLiGWySh4OQjc2BTNSyemduRoqv6tL/AKemF62aqQnmSt7fJn4hG4dUdfsg61f/5yhSsrXPmfHOeCVZrBJOAnskjE1VhJst7wjfSf5O1kTU5pn1+4EmPohTDceC/f1dHS2YpZEkwI3xuVoXtVwEsO/TwFzLdGevxA/w/kkpahg92bCb7Q2Udw4Q/bJj2dgCmNdIDsnapgoEbtfE/VKqKFGfm9UqLmmlBxP/HogF67oLFf5w/oP78o5lPgp4ZuHYU9CqkjJdG2wxWHuYAPEuleE0Ev629n1MKQfI6YOHK9PZpdmUIAZjmqL831D7XyLuwrLufvAT2/lfUjMvZs6Y2LdrhnhZzCRpBZELO1MjvcWwJIiwmJZyIG6kXWCa9K/nvR7TibyQrbP1VYntJnKEz9H6A+GbJrwfrwU+De0om/3uSFhzDiAYsqryUBruDWMXLXE3YMQA06ufxrGF17fQKwZlnXyyeAlCnbX0Oqg6OgsgiZKMutEDdKkiNkBVam5neCTUSaianVCB5wP0fV5gYwARbGMRHhs+KSgfdtqxpRp+fPw20c7305P83+v3QHhjO7QpyhRddfmrKwYE0HhBtik4OuJuydjPMMK39TsTd5ZRmvKO X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(376002)(346002)(39860400002)(396003)(366004)(136003)(31696002)(31686004)(66946007)(53546011)(54906003)(86362001)(4326008)(16576012)(186003)(38100700002)(2906002)(6486002)(2616005)(26005)(956004)(8676002)(8936002)(66476007)(36756003)(6916009)(316002)(66556008)(83380400001)(478600001)(5660300002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K1FwTTFHYVR1dlhGS1FwUUl2OWtHWXVtLzNoaEFjTXM5VFl3UnhRamdtWGVV?= =?utf-8?B?QU1jRnloUk9Qck9kYXFjZ1kwMU9UV1lLTk9lcHB3U09Jck5HYXRaVFUvTFBj?= =?utf-8?B?QU02anNPWm1BU1hicDJ2RThKZFRBYm5maHdBY3JuMHhJZUJRRm5BcWlYNyt2?= =?utf-8?B?dmNrUzdHa2sxSjhlZDA3bm1QMElzMGtCbzZVUUhtMnMzVU12QzNPQ2tGQmpy?= =?utf-8?B?VVJGR1JMaEYwd0NJd0VOQ21RVXNoWnFMTUhYWDR6c1I0OS9WMGVxdmgzd0dr?= =?utf-8?B?c1FkVkxiWHJxKzNpQWNRSFNseXNQZng3cjRSUVRDZ0lCbHBxZGNnU3hYQjJQ?= =?utf-8?B?bzArY3VwM21GcC94ODdZREJCVlA0MEZNM1VNZ3JIVVE3YjYwYkQvR2RlQXVk?= =?utf-8?B?cE1QUGNpekxyUldUSXUyZE9vY3VhczhINGR3ek03dnV5VDl6elNPNGwxQ1Zh?= =?utf-8?B?RkMvdXZ5R0tJN0M0TTh5YUh3S0NhbHRzdjdaQWY2QjVSS3lvSTZHVnVUZVlk?= =?utf-8?B?alNkN1FZVjhTd2ROc2ExalQ2ckNCcnd6RkVxd0Uxalc4aXIrd005aE1FVXN4?= =?utf-8?B?dno3R0MxYlZsMkFDeW9QMEwvajZvZkRURWx3RmdSYVVJcnFGVllWcmNOVU9t?= =?utf-8?B?ajdqZ0dYVHlwV0xrT0xQRElmUUJyMDM5Y3lqZ0l1clBIREVPd0REQndtZVgz?= =?utf-8?B?RkFJZnUzQ05TNDFNdHN6Zk9ndndxUzBHUUROd240b2pUdmZQY3ZSLzhPUUJn?= =?utf-8?B?WSsyNFRKUldER3pLdXo2bEszM3o4R2ZOdDR2ckVyZVk1djcwZFVBVzEvektO?= =?utf-8?B?eUZ4OWNNVnhUZmg0OWNZdHQ3SHZyN1dZY05STTl2MTFWSk9mYUtnUmtKZnN6?= =?utf-8?B?RG5vUHJRbzRMRzZXQUpUa0FQTjlxNEUvSDdnZzlmWFpKaVFCZ0tDWURTcDRu?= =?utf-8?B?NlRocTJuT243K3ZUZ1NLVy9aN2VRREttbkxJcXdFcHI1OVF1RGQzN0oyM2JD?= =?utf-8?B?aGFxVTBYenhSSFlxZFN1dS9HY1ZCeGc4b0sycXU5MlBpOFRia1REUmY1OHZj?= =?utf-8?B?RFl0MmpCVnBPVDFucFc5R3piTjFWejhqcnNKYlpETlpmcnNYT09lT2JFRXZh?= =?utf-8?B?bWpETnBpQjZPSW1SbjU5K0pxYjVOejBNWlJvOTRGUThwSnVFRHB6YUxwemdW?= =?utf-8?B?WDJsdFpBaGt1YVVWSlgrcXd3NittTTViaUd5OStzZm1DaTdlSUZtSnh6YW5L?= =?utf-8?B?SjRJeWx6eTJuSTlvSzZoYmxWQTNxeXA4SEtqTkdqWmRROTA5bkwyVGxmbTc5?= =?utf-8?B?MWRpVU5hZVZlNlRYc0QyK0FhU0J4Q0grcEFlMnA1ZjFlMVFpanZNYTZsbXBo?= =?utf-8?B?OFFIQW95SGNYRTM2c0I4OVptZlRGMGV2Ujhxakt3NjZNSk45VGoyZ0tsUlVM?= =?utf-8?B?ZWtqQ2tBd083TVJQaDc2ZDQ4Sm5yL0Z6emFwNUo3Z2JLNjY4S3JOenJ4Vjhr?= =?utf-8?B?S0dUczNGdkxSRU9tcjEwL3dlZ3FuTkkraGk5ZkgxR2JOZGpBeWFkbkFjNi9W?= =?utf-8?B?dWZ2KzhBeFJESnJxZGhaZ0JYdUM2NWVCSlNtVEh4VEV2ZjRhOUVwZWRBVzFY?= =?utf-8?B?cHVxSHBOdzIrTE5jS2tEekNjOEk2WWtiMjNPZlFuYWJuYTY0Wm83SHhMWXhl?= =?utf-8?B?dXhCMVJ1VzV4RXROUytmYlpUTlQ4dVE2U1k2UEdZSDh6Nk42azl3UExvSFU0?= =?utf-8?Q?kLjFFHDdpKlPZEsEc7FvyLwtzt6dZHnm78JQ6q+?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 381d111f-36ef-4869-78b3-08d972b4038d X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Sep 2021 10:32:53.0317 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /Yr4UdhJ9rjzKm8sYfiLx9r0xIMit5dcLlNmnqjSOhovjlbK4sLCuek0l4xt4+AgmucismCqqUM7nmQ2TyLdsA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4846 On 01.09.2021 10:45, Jan Beulich wrote: > Commit 806448806264 ("xen/domain: Fix label position in > domain_teardown()" has caused Coverity to report a _new_ supposedly > un-annotated fall-through in a switch(). I find this (once again) > puzzling; I'm having an increasingly hard time figuring what patterns > the tool is actually after. I would have expected that the tool would > either have spotted an issue also before this change, or not at all. Yet > if it had spotted one before, the statistics report should have included > an eliminated instance alongside the new one (because then the issue > would simply have moved by a few lines). > > Hence the only thing I could guess is that the treatment of comments in > macro expansions might be subtly different. Therefore try whether > switching the comments to the still relatively new "fallthrough" pseudo > keyword actually helps. > > Coverity-ID: 1490865 > Signed-off-by: Jan Beulich > --- > If this doesn't help, I'm afraid I'm lost as to what Coverity means us > to do to silence the reporting. According to the most recent report this did not help. Shall I revert the change? Or do we consider it a step towards using the pseudo keyword more uniformly? Jan > --- a/xen/common/domain.c > +++ b/xen/common/domain.c > @@ -401,13 +401,13 @@ static int domain_teardown(struct domain > */ > #define PROGRESS(x) \ > d->teardown.val = PROG_ ## x; \ > - /* Fallthrough */ \ > + fallthrough; \ > case PROG_ ## x > > #define PROGRESS_VCPU(x) \ > d->teardown.val = PROG_vcpu_ ## x; \ > d->teardown.vcpu = v; \ > - /* Fallthrough */ \ > + fallthrough; \ > case PROG_vcpu_ ## x: \ > v = d->teardown.vcpu > > > From xen-devel-bounces@lists.xenproject.org Wed Sep 08 10:43:36 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Sep 2021 10:43:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.181749.329029 (Exim 4.92) (envelope-from ) id 1mNv3B-0007Hb-NZ; Wed, 08 Sep 2021 10:43:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 181749.329029; Wed, 08 Sep 2021 10:43:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNv3B-0007HU-Kf; Wed, 08 Sep 2021 10:43:29 +0000 Received: by outflank-mailman (input) for mailman id 181749; Wed, 08 Sep 2021 10:43:28 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNv3A-0007HO-J4 for xen-devel@lists.xenproject.org; Wed, 08 Sep 2021 10:43:28 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 4c7040d2-cd60-40e5-8b52-ae17bc609e4e; Wed, 08 Sep 2021 10:43:27 +0000 (UTC) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04lp2052.outbound.protection.outlook.com [104.47.13.52]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-38-2m6IG6VnNLCd58WGwDgg8g-1; Wed, 08 Sep 2021 12:43:25 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR04MB4384.eurprd04.prod.outlook.com (2603:10a6:803:6f::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.22; Wed, 8 Sep 2021 10:43:24 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4500.014; Wed, 8 Sep 2021 10:43:24 +0000 Received: from [10.156.60.236] (37.24.206.209) by AM0PR04CA0005.eurprd04.prod.outlook.com (2603:10a6:208:122::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14 via Frontend Transport; Wed, 8 Sep 2021 10:43:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4c7040d2-cd60-40e5-8b52-ae17bc609e4e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1631097806; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6/VVPUxhJU9k+lxB/ME4qx3Y4zC/7I21qhXyIqu0Ua4=; b=Qv/jZFFVWtzBUb37FERgOJP3t9Zcmu9+QlQLkLTb7sMgMDD3swi1mb2itkFBftX2kvMXmq D2qxAY2pt66tqiGYH1v7DP9sKuEq6fdZVg4P9EMlDE0nF4vb+/J9tu9zg8Gr6QXY4XZqv5 wpaqdTnyKthpP5Sk8Cte8HDCcv4jqSk= X-MC-Unique: 2m6IG6VnNLCd58WGwDgg8g-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EtTJgrsJpdDKa96B5JuDxjoLX1wcsGZDK+9PWBGOvYrkxjyzFRrxzxJYWgVtxOowi5CYTTijJGJfuehsgeSbpvQYoalIQFZiLa+rYin7wTtkLndARr7ZFt2MVupxhBPtA839WRgR6IJ+jkKbQL/ObU9b90wf75vy8YNeEw580D8HVPoPDrC7xJWpgInhqeilHkrkzN6Ob0rsj4P9P3GK8yWSGYCipLR7nMGY06IpQjvPMCdU/jqUg2Bxu7QLqIqFzC42J8xbARMsA19tZsp7eGxNyO19uAEsQj8H65Kef8iwd9YYwz03XyKsSJb9dd8TBJuUdlut0AYt7JU5pGx9Bw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=6/VVPUxhJU9k+lxB/ME4qx3Y4zC/7I21qhXyIqu0Ua4=; b=TT4MbePL+EEW4g458+wRgUgLp/ObCRunsri7wpKn4uBPcNhn+EZW76tCuqQmy1d0n9HMUPk0ovA+QM8RczW7yhM+AlUaq5736UirYpNlvW3llyZyHdOyQuKEvtnPUjffDjdwkKIqMVdT5J4kLVwRZxvUoZ90Em6Ny7IKhnt7VmULC4033YZ1CB8jZsnCbYmCE6u22o8h3jWlgTN121j4pFwX4raLWGPdxJtRgx36RzR8679BK/MrrZPXdECizC+2NIO2jS52uR5g4LrmI9XPdIOm66VpuTmuhUKXyStYNFuHTiRmhZZojDPZ+l+bN4hhQESfrTlmO3IOXNLnkXgxdA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com; Subject: Re: [PATCH v2 3/3] x86/amd: Use newer SSBD mechanisms if they exist To: Andrew Cooper Cc: Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Xen-devel References: <20210817143006.2821-4-andrew.cooper3@citrix.com> <20210907161908.17402-1-andrew.cooper3@citrix.com> From: Jan Beulich Message-ID: <1fa45e94-ecd8-8920-1f08-027b348a71e1@suse.com> Date: Wed, 8 Sep 2021 12:43:21 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: <20210907161908.17402-1-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM0PR04CA0005.eurprd04.prod.outlook.com (2603:10a6:208:122::18) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2974fa39-e0e2-4986-1473-08d972b57bbb X-MS-TrafficTypeDiagnostic: VI1PR04MB4384: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:3826; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ytJvn9LIvS/BYip1OR527o0y+Dx980pEnCK7xsQMETl5yJM1/7GTGlcGqPP7WEypUNAT2sVK+KelGUKqQ4dSLvFaTb64OsXCYJAruYIzoGuVGHmlRAZOcEEPoLtHQfJq0/OeQZZsjFzI51rm4DiFw+XqQqGOuZ/8JA9cYDPkn3e6k/rm0/dolfwIZG2rWGHkGrzQtA4fkPQGn/mLf8TIPQ98nPTlICTk46Gc8Qg/lukt3OfakMDw1FpxLofbbOIXDpYd28/qBivrc5xopFLHNsvv3ePllrNf3NcxFZjPLQBP/13sQrCPPwib58WmYaeyKuHsKnHLFin5kbphHA2/qET3tethmGZRY4R1oMcaigZkIhLflFbSBXvnjNuPI02GInE3T/yVxXnknpXZBDaGfFEG/3SdOdasPVX1KtKsleVex9gD/fYamV5dIr1gn2+mCu2S+cFVnWp71RBJtu5JyPzaiOuzR30c605kovdxUN6DXeCrD2ngCFLcMVfa9k/L8boxAI3a2RuXTH8CuNNs0XGbWGykaP15f7549gk86dYyITfDA5tpxlIPrHVCnuLK/0QqOromtLs/Kkx3wJHEijUjd5z3SIsTkWDBS6lNPcnSuG96aWf77xAdQrUWwUtpWRTN67Qap5I2jbmJ3fx7kfkHTzZntVt9T0uzZrtPgmqJu9l/p0OQ+OpmTpPpqn0YAY9F0CoGOMQqiRE+G1UF7iAkbYnjc4C28hYd58wzPcWlVJ+kq/4NR4VKuAMhiUoH X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(396003)(376002)(39860400002)(136003)(346002)(366004)(16576012)(36756003)(53546011)(6916009)(8676002)(4744005)(956004)(186003)(8936002)(38100700002)(478600001)(5660300002)(86362001)(316002)(6486002)(4326008)(31696002)(54906003)(66946007)(66476007)(66556008)(2906002)(2616005)(26005)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dlNPS2tqU0VVTFlnaEh1Q2hmWWtpRmFVUW9wTWRiaEY4dUhFTXNkSUgrbGZm?= =?utf-8?B?QWszZzRNbTBvcG44R0pZUDQ3dG1qWU1kaCtkNlRGQzNWWUVVMmlJZGlEYlhJ?= =?utf-8?B?dzRIbVNGN3c4YlFKazg5K0p2c1FSeUliNUEvR3g0QTlHQ0dUMTh4RXRtdnhl?= =?utf-8?B?NTFsOFg1TUEyUEdHS09qMDdPL05JUUtxVGFrelNid0N3bTMrWW84aU1weEps?= =?utf-8?B?QXp3azNkMldWbGVPRlI4ZUl0aEhBVmx2MWlrQ2ZjaVBqVTg0cE81MDdkb1JC?= =?utf-8?B?QlpKalRtRHhlS3YyeDRIMnJmNEpGZGpaa0VKaDhuUnJUZ0UwYU1mZkZtRjA1?= =?utf-8?B?ZzJWbHVyNTk4TlA5RFN6YWx3NXQwZVVXRWJRUkNoSGtVbjdJK1JiS0ZpNytL?= =?utf-8?B?Um1yWkgzR2NaVDU5blU2WmxzbTM5K1dldzUxWGFiUk4vYXNQOXNwd3hOdm85?= =?utf-8?B?NUR4Q29jWkhXREtIcytDazRXaXd3VHR5QVRPem1ZNUVOMU9WbVBvWTRTdXUv?= =?utf-8?B?Qk1wYW15WjU1NkdhZ0hTZFh4clhBYkhndzBrL1ROcldjYVZYT3FTalMxTTcv?= =?utf-8?B?VDVwai9sQUE0TFE5UEI0NmhDV29kYjZHeUxvUGdKbTV0Y2hHYzdXS3MrdHRr?= =?utf-8?B?clpPZ2xJUk9YNVYzLy92cElranRGcm8rRDl3TW83NG55L3hFdndMV0lBNFFG?= =?utf-8?B?MjAxL0o3MmdhRDJqODFmR0ZieUw3YmtJK3EwcHBzMVZoWkdLejVwU3VsMFlz?= =?utf-8?B?YjBQTWtRS2ptQmNPWURmcThRNERJN1VnWjByRDhZTXoyL2RTS0xIdExnbUFi?= =?utf-8?B?VXhwdU1XbGszL1B6d0pYUlplOVJOdzcweE5GZGhBS3E0WS9xTVRYMCtiazFO?= =?utf-8?B?SE1DSkE0bUJaNzZYNmNQaUxCbHBMd3o5bGFXQ3ZoMEF4ZHNKU2JlSFF0TXhK?= =?utf-8?B?NVRBU1VWUDN5V0NUTWRRMnZDNFlaK3MxRGc1NzRUdDFtWU1FejdpRWt0ejcv?= =?utf-8?B?cjhVbVNMbEFFcUJWNWpMdld5ZmJpRHZyRFFBL3F5ZDNWclh4THdlOVhqczYz?= =?utf-8?B?d1g3R3RkVmkxZWxGL3JHL3FRdU5LUUlPM2hZN3ZXWTkzeG9xbDEvKzEvQTla?= =?utf-8?B?Y1ZBZVFVSzBNaVkrbmM5YTZJNWpSbXlGY1NCcGF0cERJV2VkM2ZzMnl4U0M2?= =?utf-8?B?NlJManlHbGliTDB2K1MyMlhRWGZyUHdScWtSZE1QTzR4L2dQcFZLRmZOMHp1?= =?utf-8?B?RnhNMmZqdXdScDNFYmNwWjFGNzAzMEg0blQ1QXliVUlhamczS1VpS0ErRDdo?= =?utf-8?B?Y09Xd3g0OEVHN1hwY3BzVXFSUEFIQW9Gbkd6MlZDZVNoNnZwY0FoR3A3MjF5?= =?utf-8?B?NnpHbk1aL25hOEpERTRTUlMwUlJpSUJPQUJiMEVJbVVxM2NjM1g3dE1zR1ly?= =?utf-8?B?N3d6dncyVnpUeSt0b2xDZHcrdkZ0eDNlZ05UbmVWaDlCVlJqZUNrTHgxTzNh?= =?utf-8?B?dlpFWE9VdXJqWVFXak1hWTBpd3RyZytsYTRJYlZiSVUyVmlmQ0M3a2tsbEpB?= =?utf-8?B?SEVPMEZ2SmhQUHB6a3BvampBUTJLcnhPNnorUVBMaitNRHBQdGFrY2gvOWdN?= =?utf-8?B?dWtrS1VsVmtTRnRMSkxXbzZMZmRKaUJJYTNPR0VZWUprZEo3UUlPQUpFSjlR?= =?utf-8?B?ZThkRGZzUFNsQnptZnIvdERuWHM4S0VMYzZBQ3EzbjltejEvUUJXdUJGMDUx?= =?utf-8?Q?ET4nFEcWO1w0NdhY8SDp3Lqa/iqYPl6AmgTq3W2?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2974fa39-e0e2-4986-1473-08d972b57bbb X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Sep 2021 10:43:24.1290 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 7EpAq56XH6YiOn2fBn2mlCNzgB14T2NVhkTTqJV2vo8m5HCko4W+aOj4u63PDnbfYZ4ZPXgx6LsJaYyA4gvKYA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4384 On 07.09.2021 18:19, Andrew Cooper wrote: > The opencoded legacy Memory Disambiguation logic in init_amd() neglected > Fam19h for the Zen3 microarchitecture. In practice, all Zen2 based system > have the architectural MSR_SPEC_CTRL and the SSBD bit within it. Don't you mean Zen3 in the 2nd sentence? Otherwise there's a missing connect between both sentences. > Implement the algorithm given in AMD's SSBD whitepaper, and leave a > printk_once() behind in the case that no controls can be found. > > This now means that a user explicitly choosing `spec-ctrl=ssbd` will properly > turn off Memory Disambiguation on Fam19h/Zen3 systems. > > This still remains a single system-wide setting (for now), and is not context > switched between vCPUs. As such, it doesn't interact with Intel's use of > MSR_SPEC_CTRL and default_xen_spec_ctrl (yet). > > Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich Jan From xen-devel-bounces@lists.xenproject.org Wed Sep 08 10:47:42 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Sep 2021 10:47:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.181758.329040 (Exim 4.92) (envelope-from ) id 1mNv7F-0007xL-E1; Wed, 08 Sep 2021 10:47:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 181758.329040; Wed, 08 Sep 2021 10:47:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNv7F-0007xE-Av; Wed, 08 Sep 2021 10:47:41 +0000 Received: by outflank-mailman (input) for mailman id 181758; Wed, 08 Sep 2021 10:46:39 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNv6F-0007uQ-Gq for xen-devel@lists.xenproject.org; Wed, 08 Sep 2021 10:46:39 +0000 Received: from mail-pl1-x633.google.com (unknown [2607:f8b0:4864:20::633]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 5db95af6-931d-4862-bf9b-120a9091ffaa; Wed, 08 Sep 2021 10:46:38 +0000 (UTC) Received: by mail-pl1-x633.google.com with SMTP id bb10so1054611plb.2 for ; Wed, 08 Sep 2021 03:46:38 -0700 (PDT) Received: from Sai-Kiran-Y ([106.51.80.86]) by smtp.gmail.com with ESMTPSA id b5sm1869785pjq.2.2021.09.08.03.46.35 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 08 Sep 2021 03:46:36 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5db95af6-931d-4862-bf9b-120a9091ffaa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:date:from:subject:thread-topic:message-id:to; bh=58hJPrkGl6/diKWfZw8+65HdLLM506Up/fI+9XRh7vc=; b=MCfwu5pzVrinp4wQEmfrQX/x9GK9TFCSP7pNxv1G/h3jOejGhCsZUGGokEjkyC+h8M vRYGlwwvALB7CS/A7w8+IleaY0azcE12bH4zQ1sbXVbtVJf+ujX+eDwbRscHE4eOwAEi 3vvSnTY2TPTtSofQNrrUXW705nA5MO4ia06M5ZuhbGyXB0NLu78vSRipp0TM86WnBE2f +4WebKz8+ed+b43NcImIRS4HFLKLTsqHqApWYUe8Mz12f5Z60BvjDy2diBJhpQVrvJaj Kv5MB0vX3gEdqgCvSownCBfQ1PTrW1Dmne17VWykk07zRS2eZSlQC00qyeohEha38jUz s1fw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:date:from:subject:thread-topic :message-id:to; bh=58hJPrkGl6/diKWfZw8+65HdLLM506Up/fI+9XRh7vc=; b=caRUN0KZwAncDWVkQNQIIkikTUBfJdrNpEZhyDSq4/DeGn7oJa+1eG5Nco9JEaTjyr T9S6awnUkKKP0DJbwugvnYb+CrwpyIZXCb+WFNbS7EbdqlFWf88Lm/QCeUBfMQkbJXQV IQy38ARZC8rgBnyudPQ045F9ckqf/7X4CxHDvgHBMvYKXb3t7p4Tw3WLg8uu9X7MWEzA GkfXrBXgWJJCNFyPsLQzbu4d544oFOR92bAqzumddtjiS8irbB5R4B4TEFQijFuMhFdF wNLI29xybZNHq7kb/Ed03wG2nuz7g1Tc7Ohgts/MK+ebVRvnMJbZQc6wQ1RkEBc1qPlm vZpQ== X-Gm-Message-State: AOAM533wVxOaoxKbmaEv2Eqmw6DxXIqzd2EF/QpSMtKjvdJ6i8DN5LDO MHJj9tSWbciDa+ae5du2ozkxtiJJtBI= X-Google-Smtp-Source: ABdhPJy/8ww9rv+dnSDtuG4VFlvKDuydQk07awo5BaK9YZH+Wp4oQ6eZa/QsVYbg7U48CswZx8mRiw== X-Received: by 2002:a17:90b:3110:: with SMTP id gc16mr3461111pjb.199.1631097997376; Wed, 08 Sep 2021 03:46:37 -0700 (PDT) MIME-Version: 1.0 Date: Wed, 8 Sep 2021 16:16:31 +0530 From: Sai Kiran Subject: Xen Booting Problem on ARM Machine Thread-Topic: Xen Booting Problem on ARM Machine Message-ID: <1B61076F-D44A-41CC-89CC-A8E0E65E64EB@hxcore.ol> To: "xen-devel@lists.xenproject.org" Content-Type: multipart/related; boundary="_30A821E4-34E6-412A-BD80-6EC1FA5235BE_" --_30A821E4-34E6-412A-BD80-6EC1FA5235BE_ Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset="utf-8"

Hello,

 

I have Xen-4.15.0 on an ARM Machine, with Debian 11 installed on it. I am= able to do =E2=80=9Cmake world=E2=80=9D and =E2=80=9Cmake install=E2=80=9D= , after =E2=80=9C./configure=E2=80=9D, as specified in README file. When I = reboot the system, I get the following message:

 

Warning: All 128 bootinfo mem banks exhausted. <= o:p>

Warning: All 1= 28 bootinfo mem banks exhausted.

Cannot exit boot services: ErrCode: 0x8000000000000002 =

 

Here is the snapshot= of the error.

&n= bsp;

Can someone tell me how to fix this erro= r?

 

Thanks & Regards,

Sai Kiran.

 

=  

Sent from Mail for Windows

 

= --_30A821E4-34E6-412A-BD80-6EC1FA5235BE_ Content-Type: image/jpeg; name="D00C86F8093B4937B59AA7450B930686.jpg" Content-ID: Content-Transfer-Encoding: base64 Content-Disposition: inline; filename="D00C86F8093B4937B59AA7450B930686.jpg" /9j/4AAQSkZJRgABAQEAYABgAAD/2wBDAAMCAgMCAgMDAwMEAwMEBQgFBQQEBQoHBwYIDAoMDAsK CwsNDhIQDQ4RDgsLEBYQERMUFRUVDA8XGBYUGBIUFRT/2wBDAQMEBAUEBQkFBQkUDQsNFBQUFBQU FBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBT/wAARCAHkAoUDASIA AhEBAxEB/8QAHwAAAQUBAQEBAQEAAAAAAAAAAAECAwQFBgcICQoL/8QAtRAAAgEDAwIEAwUFBAQA AAF9AQIDAAQRBRIhMUEGE1FhByJxFDKBkaEII0KxwRVS0fAkM2JyggkKFhcYGRolJicoKSo0NTY3 ODk6Q0RFRkdISUpTVFVWV1hZWmNkZWZnaGlqc3R1dnd4eXqDhIWGh4iJipKTlJWWl5iZmqKjpKWm p6ipqrKztLW2t7i5usLDxMXGx8jJytLT1NXW19jZ2uHi4+Tl5ufo6erx8vP09fb3+Pn6/8QAHwEA AwEBAQEBAQEBAQAAAAAAAAECAwQFBgcICQoL/8QAtREAAgECBAQDBAcFBAQAAQJ3AAECAxEEBSEx BhJBUQdhcRMiMoEIFEKRobHBCSMzUvAVYnLRChYkNOEl8RcYGRomJygpKjU2Nzg5OkNERUZHSElK U1RVVldYWVpjZGVmZ2hpanN0dXZ3eHl6goOEhYaHiImKkpOUlZaXmJmaoqOkpaanqKmqsrO0tba3 uLm6wsPExcbHyMnK0tPU1dbX2Nna4uPk5ebn6Onq8vP09fb3+Pn6/9oADAMBAAIRAxEAPwDBj8Ta iGEn2uPI55WrS+OdQMp2y20rkcnb6VxUSyKxCyqcjPLCqojutxKOxU+/FeS5O4Hdf8J9qnnAhbds cnnj6Gp5PHl4twjC3t2XqY1J/LNcDHDNHjDFePrmnia7VslWff8A7JGazcitTvJPiBdcM1nHgHJO 7GR6UD4iOUybHKZ4/efpXCNNc7F3gfL/AAsgz/8AXqLzJJOQqgZ+lLmZSVj0ZviNaxqS1jJ0GMMP vU61+JFqrAvbysh69DXne9mQkE4XhqjW4yQqg4+vFONyb3PTW+Iek+YzK0wHbMeP0BqSPx/pskYD SSDvuKmvLmBVtwJU0RbpMjI/GtNblWPU7fxrpskgVr3aPU5FW7PxhpxkZkvURgeMjr+leQzQqrAr ySeacqBQGyAe1O4z2I+N7KaRSb+M7Txnjn8qvyeOonVW+1257Z3A5+teIR25Y5HC9cilNuONilvW q3Ee4Q+PHhPE0Az3XGPx5qebx2G2r5kEgPU7ua8K+YxhdzVF5cnIyQeuae4z6Bs/GVvbyl1jiJK/ e3cmpP8AhPA94sr20Zb+Eb8DivnyKSZDnzGH402SS438TyE59TS16MZ9Ex+NM3Bne3ZwTk4fj8KU +MoVUiSOYBmB+8K+ekvbxUwbqRv9nJxQurXx/wCXqXAx1Y0tSuY+kF8b2izA+TK7DoQARU9j8QrN WYPJLu7nZ0r5tTXtWj4+1thRxzSr4m1aPO26YD+7xRqh3sfUf/CwNLbyxE0m/GCzxmnf8JZokk3n NcswUEsrIw4r5eTxjrHI+0bx6Mo4pf8AhNtY4y6nB4G0DNGouY+mW8XafOygXICqeGIPAHfpVtfF 1j5gP2+EY6Et2r5gXx5qaZJ2AHtinN8RNQKgfZ4eDkHB/Ks3cq59Tr4ttLqJoDeq0b92IAFMhure 7PkrfQr82Ad4wfxr5i/4WfdsI1ktI2KjGQSCalg+KEq4zZru9d3SlqB9NTTmGVoFnWYY/wBYXBrS tZEs7dJVaKScD+9nP1r5cj+KShQPsjZz13VZj+KcIkDNbzg98N1pNsZ9Q3GsTspSWOPY3Tbj5asL eRrY5kKoey45NfMC/FazKqA11GxOSQf/AK9WofjFbx4H2m6Xjb82Wx79aV2B9IzXkJsXQxZkPzCQ VShUwxgHc7ueIw/SvB7T4xW0bHOo3Sp/eO7j8K0Lb4tWT4J1d1YcBiCD9TxRdiPcGupre4KupjG3 5R/CP8am0lY5Lgh5S+Qc/LgKfUV4tb/F5GfcNcQN0G8Dp+IrWsfimkcJRdZgMrnkMF247c1XNIZ6 tq0zWYkSDbMrD5sCsALc3FxyiwpkYU+h71xcPxGkaZj9vtWB4LBl5/WtL/hNPt0cKq8Fw5J3EEDH p3qlJiOjvkaORI450Kt09q0Y1kig2RsyYOSx+6c1xcniaHfEyrDcEDBVjhVb8+ee9aVr4yknhcPG FIHyqjZ//VV8zJ0udf8AY/LCoctn0Gc1l3nmWs6Rm3C5Oc5qlYeLp1hfYG2qQzbm5GfwqS+8QJdI hmiwG+6VkBP5dqrmE9TRsZn01irwLOJMkJJ0P41MoW+kytmEmbp5hJUe1Yf9pRsY/N8xNpLLscDc PSrq6kGjMlsZIdowdzcE1XMSS3kLwTFJAFHJIQZFELhhFFJGF3JgfL1PrVH7ZO6q0h3bWwZABznn k1dhuJZo2L/vMD7wP3RmndgZ7abLDNuxlffrU13MkkxUrtPAOAcVsJNFNH5ce55MdGFZlzMzTAgZ TPCkUXYDmWKztGdidn3vMPUe1S2N9DqEYUyMgzxvGOPWobiOa9+VGRVUfdxx9aIQ0expYI5Jl7r9 0j6dqdwLtxpf2d3kWU7jwi9mH+NRwmdNyzR7P4vmxmpY7oXEqlXZGIIdWIGPTBqTUFlYobfaz4yd 7ZzQ2Mrw6WY1BiKS7m3Fi3P0xUzsBcBp0jfsO1U7gFrQpIyLNuzsX/GrDrGbO3Rdpkxna1SBPNCO Lhy3lKPl24b8OKyY40vJZ2y3zHC44Aq5uljjdbm4EcX8OD37AD/CsWOeTzgYoZGxwW255+lZO5ob trHttzaCYpKT/EOCP6VbS1udOhkGfK7knnj1rHt9Qm3SMlrJKQMyMQMn6VqTXzxQKNqwl13Fc5NK 7Gc9qEyT3B2lt68E84PvUa280qrvX5QcgNzVy8jmaYFCvPPyY5FV42hmbayMzg42k4//AFVaegiS G3hsQZmXcN2TEBk/XNT395aLbrcKWR2+XbtBUZ/Gs8QuxcB2jC9SvJqK4sg7BYjJdLndwuF/HmjU V0MRZGUrDChZj95jhavRxBVH2yNdw6bP51Te4jjh2SbgOvXFWLF7e4besYY9D85JH4YovqLfUmbF xPH9nRpQByrD9Sax73TUW+IjPOMs3ofStnz4oZxJbedFgbWBxj8BSrFBNbTMdyHqGwOfqc8U43Cy sc1cNbbDglZFOD3FZ+7y52iYNLE2CMsMitCSONmYW0TZwQW6/lVc6K6gSuT5mBjd1+lUQUp1fc3l qNinIGRwP61YaS1+xkB2aVhnYwxj8qkmcW3LpxnBJGKhmQXACghB1wg+9RcBIP8ASAvlsqSjj95n FZ+pb7WZmldZX6bM8CtJYbaGxG4GN1OQzDP61jXSxXmW3bh1PHWncB1syXMqmUsFx90dKSbLXHlx q+ScAgcCm6asixk+UpGeM5H61pxfabhRESidv3Zz+tNSsBVS1eNmSedWb0zmoJ7QNGwhkw/vnFT/ AGeJZWzjzF5JJz+tZ1zZzTCUCZV3dNhOarmJZXubtliWJ+T61Vt7Z7q4yjsjLyMjtV+0dxbiJ492 w4LNVqFEhfzFYMWODjsKnmZOhQuLMXK+SQzM3V8/yqK1szAdjcL0POSK1plLM0igYA7VSbHyv/eP ajmYPQWO1g52BmHqwxRVryw33ufxoq7sR4UlxAqHJQ89MH/CnR6nb7iA4Qjsen4VK1wI1ClGYA9E fqafHtaQsflLD+Jga5JIZXF3axt5gCyjvzxUttdLNgl0XHOCQP680yORWZwyKApwOFPP5VKsPmLh Y8sP+mYP58Vny6FISa48wOwbHue9RxszYKhgqjr1xU0ccUsR8wBWUZCrH1pBbxFQR8v1UgYpcrHu RzOZWwDkdxUSrIy8jGOR0FWFs1MgZSMfjSyW+WIB49d5rVC0K4jdTyQxqRW8yQghVPqBgfzq1JYh FcFt3oQetRrCjfLgjHemHUhbC5xkj1zTTuwpIJUmpGt2AGFIFSLFuwMEbeKQyNF+YhDwaYGeOTOe nTirPkquPm6/kab5QbqcD6VSE0RrcBt3GB9KUSNyQxx2pfKUlsHKj3pFRjnONtVZFAbjKjlTjio2 kORznNSNCo+7z9aj2fNg4OaXKAbmDFcg4pvnbWxgHPrg0rJlxz+tN8krzjmqsMXzBgDFMaUN/BxS NGeOMCmtGQ2BmkytxPNB7Yo3rxkZpnklT0OfWnKCueufTtS5ewWY5im3pUbbWxjA9M0rb93U01wz LkdKloFoIyxjGDn1pnyL1Jz2wKQqVHtUbHa3NSUT7U7nNN+63GKhViD0wPrTt3+zk9zTaQrjtmWO 0g4PNK0XANNU+gyfrTxknpSGN8ts+9KE6DqR3p4GOTn61KuGpiYwR7W9Kd15HU07aOxp6oAvXFAK 5Hu2jB7U9ZG2cMw9ADUnlnaO9KI1XGBn1q0kNix3E8bDErg9chjVldQvF5W6mU+u80xYhj0p4jDc Aj0609HoZlmPXNRXG2/uF7AhzVyDxRqsJUG/nIXn5nzis+GHaw4BHpU72oGMdfTrTsI2YPHWu+YH /tCU4IK9OPpWnb+Pte+ZW1CQkj7pA/DPFctb2x6nIPvVhYTxxz7UWQHZwfFDXlTyxPDjjOYhyRV2 H4ra3DJuV4t/Q/uuDXCxxb/fuSauQxjjovvRYVz0S1+K2rxxkG2t/mABO0/pzV1finfrgCygHTJU kHHcda4KNQuOc8cVYyADg8k9etAz0aH4uXDQiKWwRk3ZG1iPwJ7ir1r8UIFjdX0tmfoGSTA/XtXm NvJuGDkgdRvqwJ2bIGVHUDOSKYHpcPxIsYo5BNZSbWPRWGDxVi38f6YfLWO2nVm5Pc15qzyGMLHI 5Ve7YH9KnguJuCFJJ6tgHP6VLGen/wDCa6Mw24ljTkh2QZP61Kvi3SN2/e/HGSg49+vNeax6g0pS NBjnBOwVYecbizRx5xjBTI+vWouxpHpv/CQaDMpZp1Q4BUMhO4+3pVy31TRZYgyXVvs3HIV+n515 RHqC7STHG7n/AGSo/DBqa3u4mjO9IRnouWz+I9KRXU9be7014x5V3AqsvGGwRSW9ro06h3uYcY27 nkwc15hHfRSxbRErR8biMj8MkVpLcWjuUMQRQM5kmJx+lIZ6DbaBZ+ZiOUNk7ciQAGpW8JRTKJRv Pou4Hj6V559stkhMUbMSw3DbKhGPbOKm+1QeTCokmjIJB+dDn3OGyKYeR3Y8KwR5TEjFhnbt6e3F QHwmiyOzq+0DJypIHtXFnUIY/mju7tfLOARwx/HNWl1S7kjd0vbzYT3ZsMff1NNXFZGtN4Ljy5Ab Y3IDIfy56Uh8GvtVY5AJCeFwRWPFr2oIPKj1S8Zv7hDlTn69Kf8A8JDrVm2f7WZFxnfKADx9R+FU 2wsaMnhG7s8L9qQndzkdP8aj/sGWOOSGfGxx1U4NZc3jDVh8v9pwS+WwZiEQ5PY9P0qK68e6vcEs slqwA2jcqc/p/wDqoUiXY2bfw3OsICouw8KOM/hUV5pGpOnl/ZiFUglsjLegrKtvH2rj5g1kHX/l n8pH6YqK4+I2tvI5SG3ZFYAEIQfww3Si7Hp1H3/hfU7hiVjG/r5fJqt/Yd+o4spWn6eWi5zUs/xJ 1iVzI2l2sYGMurNyfTrUK/EzUoZGWXTY3LNk7JCoxTuT1H3OkTvZhBFKHzgoq85rAvNPu7GZBFDK vPPydDW9D8UhAyu2ktjcSfLmyRx9KoXPxiiVQw0mVS3G5Tkn65AoTuBRtbW6GDNuaFx0K0+KyG0k 3L28S8AIp59ulOb41aPHGVbTbzdjHO01Vm+M2heaT5F2kaoPlaMHnuBzVCNDZbw2siwxBXxje/es NpvOOySPavT5RjP41cm+LvhxljJeT5xlsQYI9qgk+LXhCRVaV23k4wUyFoAJrNbhT5EZRiMBd1UD EbCYQscMRzuPAq+3xM8Hwoz/AG0K2MjEbE/oKik+IHg+4VJDqEDs3JUo3HsciglpC2s2/IEi4I6+ tT29rui6cZyCar/8Jr4MaNdupW8cmfuqSOPerH/CW+HJABFqtqS3QeaBj86NSSZUto12u5Lewoqt /wAJBoqEj+1LVvpKDRV2EfCMfj65jJ2axMpz03kVYT4iXvG7WGbH95811X/CI2LYHkxn6oKhl8D6 e/3rSE++wVu6UuwXMSP4kagu5V1KNt3XIU5q2nxO1UYYXVuSvT92tWv+Fe6W/W0jGfRcUh+GekyL gWyj/dY1n7JroMfb/FbVI3DFbZ8D+7Vr/hbV8xBazt29QpIzWc3wp0tvuxyKf9mU0L8JbLcdslyn 0lNT7PyHc2B8YJ+B/ZyIB2WU4/WrMfxgiXBfTmGfvAOP8K53/hUUbZ2X13GP98GlPwff+DVrkf7y g1Ps12GtdTql+L+nMMyWM6kdgQRUifFbR2JLJcRD18sH+tcg3wdvHI26w4+sQph+EGr4JXVYivbd Cf8AGjlQX1O+X4oeH5cBriRCBgFojj9Km/4WNoEmF+3qFxjJRhXnDfCHxAQNl9aP9UIpB8HfE5Y4 ezb/AIEw/pS5UPQ9MXxtoTY/4mMPtkkVL/wlWjsrFNSg/wC+68tPwh8XZ+W3s3AP/PUj+lI3wl8Z 5H/Erhfv8s4pcq7jPU4vEGnSDAvrYf8AbUCpRrNiwG29gI74lH+NeRf8Kp8ac48Ps+Ou2dD/AFqM /DDxmiknw3dH2RlP9afIu4HtMd/bSt8s8bDvtcGns0btnI/Bq8QbwH4uhYf8UzqmT/diJ/lUMnhn xXbkl9C1mMr6W8n9KOUZ7uUC8ZznpTDnOPmz24rwdl8TW7BWs9aiOMhTBKP6U0eIPEFrjfLqURP9 +Nx/MU+VjR74U3cE8fSmFcNgnI+leDJ481q3b/kI3Kn/AGgf6ipU+J2sbh/xM8n0ZV/wo5Gx2Pcm yGx1+lC7jzivF4/iprC9L2F/+ACrKfFjWAeXtm/4AP8AGo5ZXKPXuinNMZmxg4C+leVp8WtTCgtB aufoR/Wp0+Lt1n5rCFvo5FLlkB6Xtx1GKjlTpjn8K89/4W1Jxv06PPbbIanj+LEOAGsHz7OKnlkM 7gL6rS7QwHHFcYPitZNw1jOPcEGpY/inpZzuguF/AUuWXYWx2LBeCq44pmdvbmuaX4laK6ndJMv1 Snx/ELQ263LZ/wBqMinysLnSq3vTo1zk54FYEfjjQ5SMXyr9Qf8ACrSeM9GbgahDx6nFLlaGbirk e59qd5bdTWZH4r0iTaVv7c+28Vci1/TJOFvYCenEg4/WjlYiztOOmakjj8xs9+1Rx31s+f8ASIm/ 4GKswzR/wyKc+hotYBSh3Z61Kq4420scatn296m8scHP61dzMaF9uKeMt/e+tJsKZA+tSJlWzk9c 0wsPXGPlzn3GKspwF54I61AsnzDbwPzqf5l4J6npmlcCaNSM4bNXIVGcMePrVVVGAOmKt25G7jp7 invqIurjaApViTgLuyR79KsrC20t8rEccYqlGobcx454watRxjcuPrnP/wBai6KSuWo1IUgBSOp+ UHpTlhcc+Xtx6f8A66RYFPAyPXaam8lY8bt6LnPykdfpU3FYuWyu0igRlQ/3WOfT61ZaFg6/umU5 5bkZHp1qmsMu0fOwQ/dPXP61Z8l4YwEk6jAPl9/Q03rsNMtrH9nYKRkHqeeP0pfLZ4wzK2B0+cDP /jtRxpLbr80pY4z/AKs/l0qdmuFjX/SVDE7vnDLkZ96ge5Lb24mBZxIrc8hwO3BPFS+TGqjHysDg M20j6kEjNQfaJwpH7uVumGfnrU8d1PJDGsn2RSowD5yrkfnSLFjjEyFQzOqjO8Io/H71SeWishw6 fLjf5H3j+BOKf9ufcF+yxu3T93Mhz79KtLNOsYSXTTEV/j3Ln9BzQvMBkenxNC5S42ux4zG4I9s7 OfwqOPSxCiDzljO3LBVkBB9/l/lVqO+lE7SSafcTFSAjRjjP4NUs1+6ymRtOukB6RmMljnvwc1XK Iq3FvFLGUMy5BOBuYY/A1VbTfMEebmExMMA7l47ZOT0rSXxJbCFnnguI5AQu1o2BbrnkHio5NdsZ IyfMkhy24IWdh+YBoWm4myBdOkXJWeNwCQvlyxnIH4mq11HqCsgifa6hcASFic89hzV6bxFYxnmY x7gApYnCf3jyo9qg1LVtPmRQ80BjYc4UFm+vvTeuoepk3DX8zPEssyEj5t4YHPfvVZrbUVmZnhZ0 TGGaJgOe+M+1X01LSYyrebCr7T8xgiI4GADmnfbrK8XMc0ET7OfLCDp3AVuetNIZlXExVgkq+S7D PzQ46e1Y8jzW8rAxxopPeLn/ANB4rrLcWi+XJPK8khGA6vIAD68Z9qpakhng3yXTGReAGnkOV7Zz 7VQrHPfbrmZwkcMMyL/Gm5ST69Bmoby8uk/eShvOZeRuIxz1HNbEdnMwV/tD+Wwwvv8ATI6VXNgD KxE/mcZCEJz78rTIOd/tK63o6mUgffYsePphqoXWtXU0fm5kT+H7+fx69a3rqxEcwjkkUBuflERz +QrIm097dirEkAnjORn2xxSEYkmrPt3O8qHOCwOf6VTuNTlZhtZmjZSQHQE8d+lbV5YxK7EgSOq8 RshyW+oNZE1uLqTAjXfjmNUbj6c0x2drsyrjVPLYqrBt2Du2dPbkVQuNQ+YKEUH1YDArXuITuLMq hV4OBjGPwrNubdWUhUXn7vPI/SkRvqZk1wVYnCv744qvLd/LkovHpxitWS3jWFg28vn+98v5YrPk tRJlQfyq+YGig10pOccDrUUk6P06+lWprJY14XPvmqU0QVun14p3JI2mHZiv40VH5QopiNuMA84q YRluDTVXFWkHQV69mY31IWtv7ozU0FnI+Qqlj6AZqeOLJFfTv7I9jK3hz4hSWUml2mqR2cMlve6t GjQxfvMHcXBABHFTLQ2jqfMH2Nk6ghvQipVhbgkYNfYPjX4P2nxC1rwidVubKLUnsry71bUdDjQ2 9xFB8wWHaAhfbx7HrXmmufBfw7r+j6frXgLVL67sZtRTS5l1iJYpEmflcbSQVx1NRoyrHh6xkdua tLHt6CvfNb/Zv0SBNd0zRfFjal4s0OCS4vtMks2ijVYwDLtlJwcdvWtDV/2dVs/2ftP8T272MmsL O9xczLfIV+zGMFUAzjeD1Uc1Olx2sj55SMvz39qmjXauMZr1r9nDwTbeMvHckF1bWN+kFnNKtjeT GLz22HG0gHJU/N+FVfAfwL174jWGpajpzWcFjY3Cwzz3lwsKR5ydxJ7cdfcUE2PNYl3AnGKuRYXt XojfAbxXH4vHhyGziubpovtCXMUq/Zmi7SCU/Ltzxn14qXxp8C/EPw/8NyaxrJtIIlu1tFhjmWRp GZS25SpIKjGDzwanlQHCWuNx3CryqCw447Yqpb4HBGa77VvEOheIPC9kr6cbHxBaBYfNtVCwzxjo zDs4Hcde9Q4IPI5i3bYR8vPate0k+WvRtH/Z5vtS8K6Xq6azpqX2pwNcWWkyORcThT0XIwTXDW+g 6jNdT20dlO08JxLGsTFkwcYIxxWbgh6odb3Hl9Oa0bW6IkG48Ve8J/D+88SWev3KSLbDR7RruaOV TvfBA2gevPesYI0JAdWQ4/iXFR7Nbl3N2O6HBOCKtx3UTIQ0UZ7AkCq2ueHbvw3Bpct08TLqFqt3 EInDEISQN3oeOlZkcjMc9qhwHdmjdWemz8NYWjj/AGoVP9Kxrvw/4eud3naFp0n+9ap/hWkFVxyO aq3ChelZ8iHzHP3nw98HXZJfw3pZ3dc2qf4ViXnwZ8DTBv8AimtOGf7kQX+VdZIryNtQFj6Lyary +ZCxDKyEf3hiqUH0E2cBdfAPwKyk/wBgwof9iRx/WsK8/Z78GnJGnSxn0S4cf1r1eSZmHOc1SkLc 56VXs2HNc8buv2d/DDNmP7dEM/w3BOPzFZVx+zzo/wDyy1DUYwP+mgP9K9vkTvjBqjLCV5/Gjkfc dzwm4/Z/hVj5Ws3aj/bRTWdc/Am5jGI9bYjPO+AV768HzdcGq01qOoFX7N9yOY+fJfgpq8f+r1a3 b/ehI/rVGb4Sa/H0ubNvqGFfQstv83A/Sq0lsp/hyafspPZi5j56f4Z+JIMALav7CQ/4VVk8B+JI +fsUL/7stfRElmvPy5/CqzWCnjbz1o9nIrmPndvB/iGME/2Ux/3ZFqL+wdaj66TP74wa+iGsEHVa jaxVmxtwKXs5ApHzs1pqkOSdNvEx/sGk+1XkP3re9T/tm1fRsOlCa4VNuSeprYTwlav1D/mK1hh5 zV0jGdaFPdny5H4gv7ZiUmvIfT74p6+OdVQ4/tS8VR/00evpPVPDNhZrym5m6ZArEm0CwlyGtYiP dBUSpODs0aRkprmR4jD8RtXRdo1u4C+hep1+KmtRjCa1IMepB/pXrMnhTS5M5sLcgHvGKqSeBdFk OTptuQf9jmo5fIv0PPIfi/4gTBXU43P+1Gh/pVyL41eIlYMLu3f/AHoVIrrm+Gfh9zk6dD74yM1A 3wl8OzNlrMoP9mQilyrsBjQ/HjX1IDpZS98+Xg/zq3H+0HrKcHT7Fz6gMv8AWrbfBrw6wOIZwf8A ZmNQSfBDRGUFJL1T6LKD/ShwiBYh/aO1FFIfR7Zgeu2VhWlb/tMFeZNABOfm8u5xx+K1z8nwJ05v ualexn6g1G3wAj3EprN0g/2kB/rS9nEDs7f9qC1XPm6HOoPTy7hT/StSP9qTQWC+bo1+jgfeUo39 RXmP/CgLlmbZrrYH96H/AOvVeT4DaqGAXXISB/eiIodOIXsey2n7U3hiJjvsdQwf70S8fk1aVv8A tQeDZpP3ovrfHQ/ZyR/OvAJPgX4gGdmqWbj3DD+lVpPgr4pVjtuLOQAdd5H9KPZRXUfMfTEf7Tng mbGb+4jYdN1u/wDhWjbftIeB5mLnWfLcj+KKTJ/8dr5Ll+EXiyPOIbaQL/dk61Xb4YeLoz/yDo37 grIP8an2Ue4J2PsW2+P3g1wVj8QWqnr8zFf5itK0+NHhW4UKniTTFC8jdPGP5mvh+TwB4rhb59IY n2YH+tQSeDfEkeRJos+fYUOitri5tT7vj+K2gTt8uuaazbdvyzRHv/vVrWvjPRLqRIvtulSN1Hzq fwzX54TeHdchxv0e5/74qvJpuqx9dKulP/XM0vY+Y+Y/SmPWLGYRpaixlUMGZowSemCODVqPUrXz FZrYHnuXAA9+OlfmVjUYTn7LeJ/wFhinx61qlt9yXUIf90uKfsmuo+Y/TK61i0jUvtnx1EcVy6Ip zx3qnc6lHzL/AKRJuHKtdklQPqTmvzjh8d6/aghNZ1aEd8XEg/rWhH8X/F1vyvijVlx0LXTn+ZqP YyFzH6B3WrySxyNulTAwfmQn2wcZ/Gs430bYLmYsAMZjR/zytfDUXx68bRk7fFl8zH/npJu/mKsL +0J40UENr7S56+ZHG2fzFP2bFc+2FMDKwzgHs9qhH44FQCWxjZjIYScHH+jEfyIr43j/AGivF6nJ v7WX2a1jxx9BWjB+0x4sVNrDTpO//Hvt/karkYcx9gz2NhcQGaVrNWAH3Y3P4fe4qnPb26q3kPZu rD55BvBB/OvleD9p7xDHIrS6fYXGAflbeBk9+G61N/w09qu0b9HtARzuSRwc/nRyMOY+lZcMyIbi Jl6Iy3LDYPTlTVS4tpBHMIpHi2EA+Xe/oOBmvnqH9pqdf9boqtuOXKz8n2GQan/4aTtpFbzdIlUn urpkf+O0nF3Ee4zKYVjYXN47HIKidW69uTxVWe2nYiUy3ETHnLeW+Pfr/OvGY/2hNMeF0ewuBuOd yhc1Lb/HLw4ZlcxXMbdyYQ34jkUcrC56VdQ3LeYZL66kkX5QGhBBHYZ3cCqN1BeRqw8wIi/MC0GC fTpXEyfGrw9cXErC4uIg33S0Rz+jcVDH8WNGmkJOpEHqCwb8qOULnXSTTyRkm4jMjDOwxP8A4VWa a9wgEiqynORuyPesO4+J2i32W/tKFTjBwSP6VGnjrSmYhNThCdQrv/M45pcojY865dihkifqeTj+ feq000kbEIkW0H1GazZPF2nSKnl30QHU5cc/SmN4mtZBxdxsT1+Ze340+UNixJfOScRqf+BCq80r NyY/rUEmsQTZ2zRkn3H+NMe9Q4GVY+xqjMdI/wDsYoqnJcJnqv50UFadjqI/m4/WrMS/nUcSD8as xrzXu8rOclhXa1exfA/4ieHfBtr4o0rxNDfy6Xrlj9kdtP2mSM7gwbDEDtXkUK96sx57cU3C5Sdj 6Y0349+D/Cd14Y0fRbbUpvDenQ3sEt3fKq3A+1LtchFJBCdRzznFZ9x8RvAngHwrY6J4V1K+8Rq2 tQ6tNLc2v2YwiMY2AEncTn8MV8/xrlTmkkhK8io9lbY1Uj6uk8deAdL13xn4+g8Vx3d74g065gHh 9bZxPFJMgXBYjadp5PP0rgvD+raN4s/Z7u/DE+s2mkarpepPqqx3jbRcoYtojjPd8jpXh6DnrUq/ Wp9mPmPoT9kXQ4f+E8i1+61jS9Os7JZInjvLpYpX3xsAVU9Rk1o3ump4J+DHxG8P3Gr2E96NWs5I xZ3SyCZTknbg/MAOvpivm6EFT6VYjYqwIrP2bvcLn2t4Untdau/B+nTywv4fuvBiw61OJQPs0Syk jLZ+Ulto/GuG/aU0NbXwh4di8OizufB2kSyQx3FrefaXSWU7sSMAAM44H1rwjwR4+1fwDrA1HSJV jm2lHjlQPFKp7Op4Yex9K6bx38bvEfxG0u307UTZ2lhFJ5rW+n2ywJJJjAZwOpA6fWp5XcG7nER/ eq/btjtWep5HNWYnocRI+rX0fUdWs/gfNZ2U11FDCGlkiQsqATAksegGAT+Fd9ceJtE8O6HrOspq V/Yi+8Q3SfbtDiSV5sAYDZByo5xXyXYfGDxfYeHP7Bt/EF5DpHlmL7KrDAQ9VBxkDk9DVnwT8XvE /wAPoZotE1M20ExDPFJGsqk+uGBwfpWXKyrn1HoviiyvvEHizVtE0q6MsfhxZW/tK18t7yUOT5pT +LOBz3xXmnxQ1KTxP8MvB/iXUY4W1q5ubiCW4jiWPeiH5VIXjj+tee6b8ePGGn+IL3WV1Pzb+9jW GZpo1ZTGDkIFxhRx0Hqam8RfGTW/F2paXcalFZSwac++GxjgCW+c5JZB1z0PtSsB3HxrWO7HgW4S 1hiku9GheRbZBGHYsewr1m18G6LfafeaDeaf4bsZrewaT7DbFn1KBlQMC8nRjnBJx3rwrxn8eL/x xpFtZ3GhaNZy2+37PdWkLLLCFOQq5YgD2rctf2k7qGOad/DmmvrF3bm3u9TyVlnym3J7A9Dx6VI9 T0FtJ8Iabqngvw8/hiC6udcsoWnvXlZTHvBG9R/eyCfyr598ZWKaH4i1TT43Z0tbmSFWbqQrEA11 tx8YZLjxV4U1t9PQf2FBDbiFZOJQhJznHBOa4LxRrR17XNQ1Fk8r7ZO85TOdu5icZ/GlYD0r4KTN pPhfxxr9nDC2s6bbQ/Y5pY1k8su+1sA8cjivTPD+m3mvfEHwk3jbwtFBqjWV4bi4liiMV2qrlMIv AKg9+ea8Q+FvjzSPDdrrmja9BdSaPrMKxTy2OPPjKNuXaG45PWvTLX4++D9J1jwutjaaoNM0e2vL ctPiSVvNACN97vg59M8U0NmhefCzRNKXxre29lb3WmX0Nrc6dIF3CFHnw8anJ5HQ49cVhP4F0C8+ PXjHS5NMgGm2WnXE0Nsq4RHWFcEAehOfrWZ4U+Omn2Pwv1bQNS8572O4WSxwgIaLzldo8j7uCCef WugvPHHgWz8Q+JPHNt4la8vtWsJIF0UWrLJG8iKuC5+U7cc/pTJseL/Df4dz+PtdaBZI7ewtIzdX 11KTtigXl2wOScdhXVeOPCHhO5+GuteKdAs5reL+3VsrLzHPywCIEgjPdsnPXpUuv+N9J8K/D+Dw r4TuBdDVII7jVtQO4SGTvCBgYC4x3zmtnwbotl46+BEvh2PxBpWlakmtG6aPUbgRZj8oAY/HP5UW A+f9H0c6xrlnYiWGFriZYhJcPsjXJAyzdh716b8WvhW0fxasPCugaLDpVxcwQJHbR3Rljd2By+9u gOP0qhD8I76P4jW/hyDU9JvLhQlwbmK8UQbepAc8bsdutfQXjfwzcR/tLeEfEpltX0aeSG0ilSdC xkWNzgrnP41S0EfNniz9nnxl4R0f+0b/AE6NoBII5Ft5llkiJOAXUcqD6n1FcrdfC7xLD4wbwsdI mk19SAbGMqz8qG6g4+6c9a+gvAerLfaP8W727vPMEl3bbpZXz8huzzn0wK9D0X4c63fftS3XjBbI jw9s8yK+LjZNmBVXZz83+ArSLte5J8Tat4L1jSLC1u7zTLi2tbuWSGCWRMCR0O1wvrg8Vma1oN94 fvpbHUrSaxvY8b4J0KuuRkZB9QQfxr7H8Cx6WnhyBfH8lhJYXmtTy+GIbvcWEgkYMWK9Ii+3IPf8 K8A8eeFfGnj/AOL2t2F3YSah4reZjPb2wXACqANvONoXbj2x3qo6geRtGT/KlW33NwuSeBWlf6bP p99Pa3ETQ3ELtFJGwwVYHBB9wRXc/APTVvPjD4QjkQOn9oxEhhkHBz/StJU7K4k7nF6JpLNMXcYC 8EMK7zwr4BuvFS6o1o8EaabYyahM00mzMaYyB6nmvrXwn8P9A/4SzRNTbSrZ7681nWHuJJEDeaqm QKCDxgcY4ryLw3Pbf2H8ZbU2tsYU0+edWMK74m8wqoU9hz0HoK1jNRg7dDzJx9pXSfW/4W/zPmtd FvvFVxdf2dZTXYtoWuJBChYxxL1c+gHrTfD/AMP9a8Uafq97ptg11baVB9ovJA6r5Mf945Iz36Z6 V9B/su6n4WtfB/jx9T0W4nvLXSZ3vLyO6K+basVHlKuPlbP8VWv2fbzw7Y+EfjDq0mm3DeG1hiUW LTZlMLM22MvxnsCa4XeTuz1klBWR8nzWoXjbjAqD7OeABX0R8XtG8La98HdC8caJ4ei8MXM+oy6e 9nbTNJFIqrned3O7Ixx2NeC2tx5NwjAB9pDAMMg4PQilyjWjsUltwGwQc+hp5tCOCMV9t3HgHQdf k0f41XdkItNtdMW6vNOEBRZb6NQqBYtv+qJAyc8jmuS8E/s86P428K23jDXbTxBdT6/czTxW/hq3 jaO0XzCMOGz1OcY6AUuUo+V4bMbSB6elTi1Xb1w1fR11+zL4f8OSeL7jxF4tk0vTdDv4rVZY7fzG mSSPeABkZfBUYHHBrg/ix8K9M8HeHdC8SeHtZl1rQNWMsUUtzb+RKJIzhgVz933o5QPL/JHTikZS vpitvwHYLrXjTQ7CRPMjuL6CJlIyCGkUHP4Gvof4u/s3x+IfiF4hj8Pa1oUGpFnmtvC9tlZvLVRw MDapIG7BI680uXoM+XFDEdcUuCRXYax8LdX8P6H4b1O4MBTX2kW0hRyXBSQId3GBkniuvj/Za8dX F/q1qkFj/wASu5W1up2vFSJHaMSA7mx8uCBn1IFLlJueOrmjc3p+ld9rnwZ8WeH/ABVaeHp9LafU LwKbb7GfNinBHVHHykDue3erXjD4BeOPA8NpNq2hSQx3cy28LxSpKGkPRfkY4J7Zo5RnnH3ieMZ5 PpTD64/Ku/1j4K+N/Duj3Wq6n4bv7LTrY7ZbiWL5VIbbz+PGa5e/0DULCysru4sJ7e1vFZraaSMq kwBwShP3ufSnyEt9jDY7uMVEAVY8c102j+Er7UvFFnoVxbT2V1POkTrLC2+IMR8xXrgA7vpS+NPD cHhrxZqmj2d6uqQ2dw0CXcabRNg4yB2o5BanKMoIxtzTGjXuoIrVubKW3UGWF09NykVSa1dvmKYX t2pcnkF2VGt4m/gXP0qGSygPWJD/AMBFXvK7Yp1nZyX91FbxrmSV1RV9ycUco22Y0mkWchy1tCT7 oKqzaDp0mS1pAc9f3Yr0X4lfD25+GnjLUPDt9cQ3V1ZFQ8lvnYSVDY554ziuQe3HORS5LEHPt4V0 eQHdp9uf+2YFU5PAOhTddNt8f7tdR9lX6U0W+5jzT5Bp2ORk+GPh58n+zYh9OKrSfCXw8xLfYtvp tcj+tdwtvk9al+z/AC4pcgXPPJPg3oLHIhmT6Smq7fBXSGB2z3Sf9tM16asJ9cYHpTWiP40ezEeU yfBOy3HZqF0v4g4qtJ8Exzs1aX23xg1655ZPbNNMJ4p+z8xnjUnwXu0Y7NWUj/aiqrJ8HtVVvk1G 3P8AvRkV7a8J475qFrcgn5c1XIwPD5vhPrqE7bm0cfUj+lVZPhr4hVThbZ/TEle6vbdDjioJIT2F R7NiPCW+H/iOPj7JGx9pBVaTwZ4gj66aSO+1wa96aE+lRNCCc4OafsmO54E/hnW4+ulzY9sVA2k6 rHwdNuVPoEr6AaJT1GahMC+ho9nLsO58/Na6jH1s7tQP9g0hub6NfuXS/g1e+m3T05qCSxXuo/Kl 7OQ9DwpdV1CNRhrgD3Bor2t9LiZslFJ+lFP2b7EnaRqGwc/hVqOPv1qGNM4/nXZL8OdVj+HieMSY f7Ka/wD7P27v3nmbN2cY+7jvmvd5bWOVnORDnNWUXviltLOSc7Yo2kf+6oJNWfsskb7HRkcfwsMG iyLV7CRqBU6p8uO1OW3aNvmGDXR6D4J1XxFpOrajYWpmtNKiWe8k3AbEY7QcHrz6VNkPU5drcjJA 4pqjax5rprDwnqepaLqWr2tm82nab5Yu5xjEW9tqA/U1jS2h6gcd6XKi0ysgLdalXpil5EYXA474 5pUXoaXLcokj9O/rU6fWoUGc+9TqvSs+VASKxx0qeJ++c1AM8U+MbeMUclwLaN37VJu3YwMVAvy5 zUiNngVDpgWI5D0zVuOY9c1RXluuKmjbnB6VHsxo0UmBGc1YhlPfn3rNViWxVmNtvFZSgPY0lkPr UczHuc4qJZccUrNnINZ8g9Bu7d9aB79aY3y8UD5mFLlBMWRS2TUXzg9asnOMYpmzJp8tgbBc7R6U 1vvU/BWhhuGK0sSVZGKtnpUM08rY+duOetWJVPIAwaiZRjpzVKAit9sljDKsjKj/AHlDHDfUd61I /GOuQWsEUWtahHFB/qo1upAI+MfKM8fhWVIgOSOKiyE9xXRTjZ6iZPeeINTuEs4pb2eSKyJNsjSE iEk7iUB6ZPPHeug8E/FC88L+Pv8AhL7+Fte1ZVdke6nZT5xXasjEctj+73rl5It/I5qGSH3rq9jG SsY8zWwzWtQuNa1S7v7khrm6laaQqMAsxycD6mtfwK13Y69aahZyvb3FpIJY5ozgow6EGskQ7mA6 k8V6DoOkDTbEbgCWG5jXTTpKW55mMxP1enpuz0zxB+0z4qtNJnw9hBK6FYpobVVeFj95kPYnvXA+ CP2kJfB/h280qbwpomrrebluri6jfzrlWbdtkYN8wz7V514y1gahfNFCf3UXy+mTXO7SwwMknoBX n1qcU+WC0OzBxn7NTqO7Z23w/wDi0fAniHWLl9IttR0bV4ngvtIZjHG8TNuCKw5XBxj2FN0j4yf8 I74N8ceHLXR4YrTxK8bB1lbNoqOWCKDncMccntXn0y4OQMmq0qk9RXP7PW56FzvNd+KMerfCHQfB i2RjfTr6e9kut+RLvGFG3sQM/pXFaDcWNvrFhLqML3Ngk6Ncwo2GeMMNyg9iRms9vXPC01lI6Vfs tBX1ufTdl+07aXvxQmur+3nj8CvYyaSmmoo8xLMoQq8H72QPmznFb/hT4v8Ag7VPAPh7Sr7xVrXg ubQzNEIdMjeQXUbPvDFlIwe3NfI6zMuBU8UzdMkD61EqPYq+h794q+KGga18L9f0izlvWv8AUPEQ v41vnMspt1jwGeTGCSe1ZXxM8ZaLq3wb+HOgafei41DTRdyXsIUgws7gqDng5A7V5BDMdwzUkmev el7PYm513wdurOx+KXha4v7mOzsodSgkmuJiFSNVYElieg4r2r4W+PNHf9pLxx4juNUtrawaLUZb a4mkCrJknbtJ6kjp618yOCqkjgnrUPnENgcUnT1ZVz6v8AXnhn4v6P4GttWvrjRdQ8M3ggit0hMi 6gjyBxsOMB92N2TgCvRPiZ4P1r4geC/GNj4fcPf3XiqZxa+aEa5SKNEIGSAcHnB9K+WPBX7QXjPw F4ZOg6Nq32TT8uyr5KMylupDFSQfxrA1D4peIL7QLbR5tRkawt7mS7Rf4jLJ99mf7xz7moVOV7hc +x9D1LT9J+JHgbw81xb3WsaD4Wntp7BZVLfajGB5GR/GeRgc1RtbvVIbjw7ok3w8g8FWOqeIbTzj Les8s7RneNkbc7QOrDgdK+J7fWrm2vFuoJ5IrpDuWZHIYH1BHOau3XjjXbrULW9n1e+mvLfmCeS6 dniPXKsT8v4U3TZNz174h/HbxFpnxY8bSw3hvYLh7rTEhuizRRQklMqmcBgBwfevSPA/hex+NPwy +H93qkqRW/hm7lt79reVUS2s1UyB5A3QsUAz6dq+QGvHuJ5JJnaSSRizOxySTyST610uj/EfXtA8 O6lomm6pNaaZqQAu7aMgCXAxz/8AWpum+gI9k+HXjC/+In7V+n+IYVFo11qOCICSFhVduMnsUXn6 1V8H+LNN0j9oDxNr2raNNqdp9qumFxDb+cdPYyHbcbMYO339a85+Gvxm8TfCp7x/Dt5HaPdhfOLQ RybtucfeBx1PStCD9oDxfH44l8VPeQvqU0P2edPs6LBNGB9x41AVh9e9TyvXQeh7745/tz4haPos Eusab478J6nq1pbpftbrDe6azMAVdEAClwSOc8DtUh8Qw+KPGnxE8D3Ok6SvhDQNNvfIhiskWVPJ AWL96PmyGwc55rwnxR+0f4t8SNp2JLLSILK5W8jh0q1W3R5lI2yOB94jHGemTWh4q/ae1rxDo+o2 droWh6LdakhjvdS0+22XNwhOWVmJPDHr3qVF9QuehfEjxZ4d+CuleB9Ms/A+galqtxotvPe32p2/ mkhhkjZx82cndnPavBPiVr3h1viTf6r4Nt5LTSPNSe1jkTbskABYhT0XfnA9Kj+J3xK1L4o6za6j qMFvbPa2kVnHHaghQiLgHknk1xjKcDj6VbjZaCNXxN4p1Txrr15rOr3JvNRvJDJNMVC7jjHQAAfh WU0W8YHSnLGVx2qQLk8VPKIreT2zz9KaI9vvV1lBXmo/LC8+tHKBXZcdqUZbk8dqlZP1pY49wxjF VygMUetQt39KsONrYqNuoFPlAYMLikdgWyBinbcdetI0fy0coEbR5IORSYG3gc1Mq9cijyy3tT5Q KzR561C0foKvMvUYqB87cfnS5WBRdQOSPpUTqDxVySP5agdRtHrVcoFR4xUTRcdKtMuetRNnuKvl AqeWG7YxUUkZXOR9Kt/QVDIAw5FPlAqYop7L6UU+VAdRCApAI+uK+iPDem3ev/sm6vb2VtNdz2/i SKTy4ULtgwkE4H0r52hPQmu98C/Ejxn4AtLp/DWsX+l2jsrXH2Ynyy3QFuMZr0alNuzXQyi97nr3 wFj1Dwh8P/iVq9lamz8S6fb2rW00sAaSNGkw4CsDwR7V6Eugz/EBvhN4jm0zTdQ8SakbgXkl9Fsi l8okqzogAJUDOMc4wa+ebP49eO7fxV/wkZ16ebVzF5BnlVWDR/3SuMEfUVNq/wAdPG2veJdP1281 mRr+wP8AoxiQRJH64RQBz39a5pUJuTZSmuh9T6l4Z8J/FLw/ZXU91p+uNa69aWb3Gn6WdOMccj7X jYfx5457VSj1/T9U0X4xeH7bw5p2jvpVrJBHNp8fliWFJcAOO7DAOfrXh2s/tQeM9b0v7BjTdPt/ Piuh9gs1hIljbcHGO+QM/StfUP2pNc1TQ9W09NA0OzbVoGhvrq2tyss5PWRjnluvtzWCoVFYrmRY +HFnaal8A/iPC1uUurVrW4FwkrAuDIBtZc7SBgkZHeuw0fwb8O9G8MfDuLVPDdxqmq+KI/LkuFu2 jSImTZ5nHU8jjpgVw3w6+OWkeDPBd74fufBNnqiXybLy4e6eNrhQdyhsZxj2xWbf/GRr4eB410lI I/DDsyBZSTMplEgXkcYxjvVOnUbegXR6bo/7OvhTQ7XXLzUrPVvFLW+sPpkVjpjBJIUU8Sv1yDXl n7R/hvQPB/xBGgaBZfZINNtIoZ3LZM8pG4uffDAH3Fe//Bv4vaLqTeL9WgudP0jxFrGoefJa61eG GAQc7QkgGS+Sc/hXhX7SVl4e/wCE88/w/c29zLPbrLqAs5jNAlyfvCOQ/eGMH65pU+Z1OWRVzI+B Mvh//hO4rLxHZwXOn6jC9j50/ItWfhZQMcsD0+teo+KPgTZeAPC8fhy7hgvPF3iLVkg02ZnANvbq 2BIcE8PnBHavJvgr4p0LwP44h1zXoZriKyieW1jiQMDcY/d7hn7ua9P0r9oDTtd0WK58VmWbXNL1 yLUtP8kMxeNnzLGWb7qgD5RRVjNO8dixfFv7LcGjaLqc+la++o6lpYVr21nsngQLkBijnhsH06ij UP2T3sdSGkHxjo7a/NHvtdMJYSzfLkDpxnnr9a674jfFbRdU03WLu2+J9/f21+Qbfw/Da7PK3MDs dmH3AM5xWJc/Efw5eftU6b4ih1WE6IvlB75srGMQ7TnI9eKzg6jEfPF9YzaXqFxZ3KbJ4JGikT0Z Tgj8634/h/qzeCE8ViJW0hrs2W8NlxIBnlew96r+Orq3vvGuu3FtIs1vNfTSRSL0ZTISCPYivZPg X4q0n4Z+BdR8Q63crq9neXa2aeHQyNllwxndWzgAdCB1rqneMU0iThIfgd4xk1bSdOGks11qdt9s twHXHk/32OcKPr61JrHwP8ZaLrlppNxosr3t0jSQJCRIJFUZbBBxwByK+kfDcjQ/EzW7ptZt/E6+ IdCabSrO6mVSwLBhbMoOFwOw7A1r+G77XLPxV4V0vU/Dmm+GI41vZreztbvzpc+UcsV7KT3z1FcT qyuWtD5H8SfDfxN4Ntba51rR7rTYLjiKSaPAY4zj2Psa59GPevoTQdav/E3wD+Jc+q3c2oTLexFX uHL7DkHK56fhXzyMjgV0xjzp3Ie5YVhinrJuOfwq9p/hLWNQ0G81q206ebSrNgtxdqmY4yccE/iP zqHSNGvtcuhbafaTXtwQW8q3jMjYHU4ApciERKoI60qqN2e1TQ2U00wgjiZ5ScCNVJYn0x60s0Ml tIY5UaN1OGVhgg+4qOUBqrupdtKpG2nrx15qeUCJlz1qLkHirLgNkgYqu3U04wGRsuT/ADqB1BzU /K5pu3JxXTGOginIv/66ryJmtCSMdDzUDx5ye1bKIFONtpwelSyQdCOaa8W1s1reHdO/ta8WHOAO WPtXVTjfQ5K8lSi5vYueF9A+0TrPKvyLyPrWv401NdF0tgh/fS/Kq5/Wupjs4dNs2dhtijXJP0rx zxRqp1jVJZR/qVOEGe1dc0qcPM+WwnNmWK9o/hiYLZaRmbktyaDHnnoae646daauSp9a8nldz7Qq zKMnj61Tn+VfWtGTkHgf41QuOeMVapgUmXniopARxVkKd3tUcmCeeTVqmBAM5NKjfN9KVVLZz0o+ 7n0o9mBZ8wDO3+dWo5NyjdyKzl+bpUkMmzOan2SA0JBx/OqUq7GFSrP1yailYSHPQip9kA6OJsZz xTdpOQauWjI0RB61BcMd3HSocAImjKruH4VF95DnrUm7HeoZOM46U/ZgNyd2M1Mudo4waSOP05p7 H/ZpezAkjxxmn7u3aoVfOD2z0qb7w6VHswI5BwM0wVLtJHSmrjnPNS6YDVBel2hmFS4wePSl8vvU +zAg2Gnqu3r1qUR7j0pzJtyR1qeQCHZnjp7Ux12nFSevGKTbnmh0wGFc4x0xTlXGO9KB+VOxjrS5 bgQSL83PSo9uOcZqxIA2ewqPjnjFPkAj9gKGU+nFSbfUe9Ob7vFCiBWYHtzSbhUrfKeKjY8ZFLl6 ANZhz9KrsvHWpNx9OKY3JpqmBA2e9RFQasmHcvPAqFl/EVXKBFIoC9KglX2qeTdxgYHrUbLkZquX UCnIMdOlQtH6VcZdo96gkwc+lPlQFUe5oqRlBPWilygb8ajt0r3/AOFEKXX7OPxXh25eN7Gccekh H9a+f4Ador1n4PfF61+HemeINL1Pw/H4h0jW4o4rm2knaLhGLAgj3r0KsG4px3VjCPU0/gL4B0Xx hqXiC819Li403Q9Ll1J7O2fy3uNmBt39uufwrsfEHwp8H+IPC/hzxf4fN/4f0bUNSOm3Npdf6XLG R/y0Xbyf92sXQPjd4U8NeJpLnRPBT6Vot9YS6fqdiNQeV7iN8ZKOw+QjHvW7J+0Xomg2fhvTPCHh uez0nSdSGqFNTufNd5P7oIAwuPxrklGq5XSZfuo6rxp+y9pSeFrnUtBt9e0ie0khVv7ejQR3Cu4T KbeQQSGwe1dN4K+EXhDwfdeOtKtdVfVtdsdEngvba8tVVQ20NvhOTkAjGevIrmrz9ojwPa6H4mTS 7bxDc6nrTpcFdQlVoYZBKH2IAeFznnGelalv8ZfhlHr3ibxX9r1ca5r+nSW8ll9mBht3dACAwPzc gc1zWr2tJMd0ed/Cfwzaan8O/iRdbbOe/t9PUpDcQlnjQOCZEborZAFWvCv7O7a54R0nxFf+KdK0 O11N2it1vN25pA20KMdScHp0rX+BWpeDNJ8I+Ko9b8Wx6Tf63ZvYfZpLSR/KXIIk3Dg/SoPEPjXQ I/AvgDR7HVY7250fU7lpmWJlAhMoKScjjIGcda1lKopNR7/oNWsjL0f9nDxJf3msxX1xp2iWulXH 2Sa81G4CQmTAIVT3yCD+NYXxU+Fs3wtvtM0+61C3vby6tvtE0duc+QSxABPfIwQeOtfV3hnVNF8Z ah8QL+8ng1vwTLfwtDFDC8zG4CJl9qDcV6D8DXgP7Tek3q+OrfWbi4jubLVbVXsmjgaEpEnybGRv mBHv1pUqs51OWRMlZaHDfCr4Xr8TvFE2lSXjWIjs5rkSqgY5RchcZ7mvO72T+z5ZI2BJVyv5GvoL 9lJk/wCFqeUzqnm6fcxrvYAEleBUbfs46no99rlz4p0oJY/2bez2ki3CsPPSMuh+Vj6E4NPEVHT5 knrpY0g72PEp9Q0T/hHLQwPeHXTO/wBoDqv2cQ4Gzaeu7Oc9qzFvo9xBzj6V6H4f+EY8XfDfw9d6 TCW1/UNamsWZ5CEESRB+R2x8xrK8WfCZvDulyalYeItI8Q28LbbhdPlbfDnoWVwD+VeIsZiI9TZx Ry630R7496lW+j4+bmunTwZbxfBOTxI1kst0+rpbLex3IJhTy2JjeLOQWOCD6CrEfwD8ayaUmoDS V+zy2yXcQNxGHljZdwKKWyxx2AzWyzCt2QuVHNWuqeVIrxTNG6nhlYgj8a0V8QXTTLP9vuDOilRL 5zbgD1AOelQeGfhp4o8XQXs+j6LdX0NpkTOicJ1456ng8CoPFPhXU/BOsHStUjWC8WKOYqjhgFdQ y5I74PTtTeOnu4oVjQg1m6htZbaO8mjt5iDJCspCSY6bhnB/GoVfLDBzWVp2nXeqT+VZ2013P18u FC7Y9cCp59NvbNSZ7WeDaxjPmxsuGHVee/tVxzB/yC5TttL8f61o/hm/8PWuovFo9+d1xa4BVzxz kjI6D8qteAPiHq/w51ltS0SeOG6kiaFjLGHUqSCRg+4H5V5/tmhwHR07jcCK2vCPh/UfGXiKy0bT drXt4+yISNtXOCeT24Bp/XYapwDlOs8K+Nr3wn4tg8Q2awy30MrSgTJlCWznI/E1B4q8RXHjDX7/ AFi7WNLm8lM0ixDCgn0FckWmhkeNmIZWKn6g1d0+C+1BzFaW813Ljd5cMZdseuAKPrlO9+UXKWF4 Y5pfMJJHas+SaeKRlcbWU4KsMEU37a/f8ar65Se6DlNPeNvWomOTVH7aw7CnrfDB3DB7VpHGUerD lZO/ao87W61XbUOvycfWoW1AE/cNbxxlD+YVmaDKGHeomXjkVXTUkX7ytilbU4Qufm+mK6Y4mg/t Eyixxj8whcc/StPTlfTZFliJDjqaq2up2KrmSQq59VNNutaswpMc+T24NdUK1Ja8yOKrCVT3LaG9 4s8aG70dbSL5Jn4kI9K88dSvNTTXqSMSWGM1D50Z/jB/GqnWjUd+ZGmGwsMLDkpoayZwSM4phX0q VnXjDDH1qNhnOORjrSikzqK0mNxH9KqTKvNXHXdnB7Zqs2eQRxWyiBSMXOAD+NR/ZWLc/lWgUDNS +Xt781pyoCr9h+UHOPUVFJb9K0GB21XkjOCT17UcgFELt470xmIbpU8mRzUe3dzmq9mA0tuGe9Cn 1HNOaPauQaPTjNL2YFi24696lkh3Kf4aghl2sBtAPWrbFmQt0rJ09QKEibenNQtluO1Tyyduh9Kb tBHXj/ZNP2YCKdvA605z+FA9AeaXaT2zU+zAYuQ1Tx9s9+tQhTu9qswx8c9OgqJU2A9lOOKjWIqx PQVaXjjFDoMZqPZgRKgKg55p20UKewFSr06VPIBCU9KNo7VI+FPpTOT0NTyARnr60hA246UbucdT QWHIxnPGaXIwI8fMDTmIHv60n3VJ96ikkwORU+zAk9e9G32qNG/Kn7zz6UnEBfemjBzRuOOe1L/D 7VHIAnl8H0qAr7Y+lS7vypgbPPajlYFZ46jyRwMVZl+lVivtinygN+pqFs9qsFfyphj4yKfKBXf7 nzfhUTZWrJXjkVFJGGx2osBUkUsPU1XdMdjV5htzVaYjNHKBW9aKMH8PrRS5QNy3OQv05r2P4KeB 9I8YeHviFNqFsbi40zQpL2zZXK+XIrL83HXjPWvIIoWWONuoYZr2z9m/xdoHhvUfFFj4k1E6Tp2s 6NNpwu/KaQI7kYJVeccGvQrX9lzR8jmg02cn8Nfh3qHxJ8UQaLp7xQyOrSyTzNiOKNV3O7ewHpXa eKvgHqWg6Zb6no2r6b4t0yS4W0e50iQsIpmI2owYDk5rrPhmfA3wg+IWl6hb+ObXxDY3kFxZ3Bgt JYjbeZGVV33DBXJ5xz7V0EWpeDfh18KrrwxdeKtO8SNqWsQXm3SC7bIVK79+QCpwOK46lapz+4tP Q15VY4DxF+zf4o8M6JPqUk2mX/2VQ93Z2F2stxbL3LoOQFPB9K7P4a/ss6xql0lz4os5LTSpbCW4 QQXCCeOQJuj8xOSoPuPSvZZPEWjW+h+L5INU8I22gXGlSLpUViUS9ddoIWU5zn2PJJ9qk8P6bJqn xcuPHFnrdgvhfUNFWEf6YqtK4gC7TGTnhgTyO1cf1qq1Z6Fcseh8xfDj4ax+LLbxbc3P2wW+jadJ cJJax7v3w+4H/wBk4bP0rK8P/DXxN4otY7nStCvdQgcsFkghLKSuNwB9sj869k/Zp8J6zqVx40vb S1eXTrjTLuxWRWG152HypjPX3q1dapr/AIC+Amh2EV1daNfR+IZrW7ijbZIMLu2kjnrXRKtKM3GO 5KiuVXPIvBN54z8Na1dQeGm1Sz1NQUnhskYyAA8hlA6A+oo8fDxdf3Vpq3iz7dJPeIwgnvgQXVDt IA7YPGMV9j2FnLq3jjx1omnSTaJfXVvZ3f8AbdrGNyfIg2Z7k8nr618+/tWahqVx47sbG8jvEtLG yjihkulAE7fxyrgn7xxnvkUUayq1kuVImfux1PE49yuNrEH1FeraFBN8NrfSNa8S36/2L4n067so po5TK9qHTZvdOvGc4HWvK4c7hgcZr2z9pSKTXPgx8MtT+yRnUJo5RK1tAFJVVHUKOgApZg3GlZdR UHd3OOuvEfhPw34V8OeFdM8XzX/k6y+py6xY2jx/ZwUCBdr4JORk44xn6Va+Kd14Z1LwZcXOra/o Wu+K9ym1v9AR1luPX7QpVVAAxjaB05r5/aN2BYK2zON2OPpSqCGFfIOb2sd3ofQGg+E1uv2bdSsk 17Qvt1zqUWqpZtqEayrEkTqyspI+fOML3zW7P4htLr43/CNl1GGS0t9K05XYTApC4U7gTnCnpmvm VfvZ6Uu7DGiM7CPsH4d29l4h8P6r/bt0mlaVpXiSS80m6F2lut7OWJeNnf5SqhVPHrXz18YG1ST4 ka9caxaCxvbq5a4MMbl02udylG7qQQQe4qLwT8Xde8D6fNptsljqGmyP5gs9UtEuYkfuyK33Se5H WsjxX4u1Hxtr1xquqzCa8mAX5V2qigYVFHZQMADsKtzUo2Eev/spXM1nr/i24t5XhuI9AuXSSM4Z SACCD2INe8eGY18WNpFjrSrqdlLoukag8N0A6tcyXO15Tn+JhwT3FfEGk61faLJK9hezWbTIYpGh kKFkPVTjqD6VuQ/EHxHDC0Sa3eLG0EdsVEpx5UbbkT/dU8gU4z5VYZ7s2vaj8RND+INr4iK6jBpF zB/Z4aBEMGbnyztKqD9zjmuw0jxINB/aHtvBVpo+nDRLOXFsIrRFmgIhLbzKBubv1POea+cfEXxm 8YeK9LXT9T1ua5s1YOUCIhYjpuKqC3rzW7pf7RXjPTI7cxXVk1xCNn2uSyja4dcY2vJjcwx6ntT5 7iOt8Q+GdN+3fCmNbGEDUwTe7Rg3Gbsqd3r8vFXvh/bp4d/alOn6WWsbNNXmt1hhYqvlBm+T3GB0 NcR4Z+OmueHbSwiFnpl/Np7lrK7vrUSTWwLbikbZ4XOePc1Z8H/GZ/DvjS/8U3GgadqmrXVy10sk 7SIbd2JJ8vDdDnuDS5lcDqfBXgTTfG/xC8cz6jAt5FprTXKWs10LWOZjOVAeU/dHOfrir2vfCPwq 3i7wxE8sOhwakk4n0221JLz95Hjy1WYcAyZA54FcfB8XrGHxFq10vhe1j0fWLfyNQ0yK5kxMd+/e JDllO7HTjiqF1458Kvrlg8Pg2GHRII3jmtTcs88u/q/mn+Jf4eMD3o5kBo/Erwr4U0KzuIrXT9e8 O6zbsALTVClxFcg9dkqAAY69815fs9/wr1fxh8WNC1LwC/hnSbHV5oHaMxtrl4tx9jCHgQYUbc9D 7V5Mv3hzxUyt0Kjue2P8A9CXVNM0I+LiviLVbWGe0s/sRZAzpuCyOD8vPQ88c1g6f8C1Hh9tX17x NYeHrWPUJtNk8+N5T5sePuheWBOeR0xXqnijxJ4G8N/ErQ/El5qt5Hq2kWFqTZW9uJorrEA24kB+ TqAc56V5V8QfiHpfij4c2NlbO6aidcvb+a3ZT+7jkxs+boT9K2tFIkrj4BatFres2d/qum6Tp+lm IPqt5KUgbzRuiA4Jyw56cd6oXfwN8RL4kt9ItGtNRFzaPfW17bzD7PcQoCWZWPpgj6it34d6pYeJ /h14m8Lahr9rpWp3t3a3UN1q0rCFkiDArvwSDyMDpXReIviNpXhHxZ8OLax1RdUh8P2qWmpS6c+Y Z1L5dFY4DKVJB7dqSsM8Rj8J6lc+GrvX44QdMtbiO1ll3DIkcEqMdTwp5rY8WeCYfD/w38MatJY3 MWoatLO/2mR1aCSFduwIAeGGTnPtXovx1l0rwro+n+D9AvLa6jubybVLuSxCeTIJHP2dCQT80akj 0ANW/id8O9e0n4H+BkubJfK0qW6mv2jnjdYBLInlk7WOcj0zTSsxpnmvgH4F+JPF2qaHLd6RqFp4 fvruO3k1IQ8IrMF3DP171z998M9buta1q20PSNR1az0+8ktjcW9s0nCsQN20YyQM19c/2L4m1f8A aE8Ja/oTXDeEBZWyPfQy4tJVEZDKDnBJOBjrWVD4gj0nwd4cktNH8Taq815fySSeGbxoQjm5b5Zg qkEkY+9jirUUSfGsOl3l1M0MFvNNMv3o40LMuOuQB61v+JvAN54Y8IeG9dubhSutfaNlqVKvD5Th Tuz619Ia94k1TSvAfjvxR4fspvDXiG48TLbuluFa4gjEY3RsVBGM8nHGa88/aU1PVdS8FfDGXXYT Dq0+n3E86tH5bMWl4dl/vMACT3zmtNhHi/hfw1e+NPEmm6Hp7oL2/nW3hMjEIGJ4yewrJ1axudF1 K6sZ2/fW0rQvtbIypwcH04r0/wDZpiWb45+EAV37bsyFf91GP9K9F0/xRZ/FKL4k6RqfhbRtOsNI 0u7v7ZrS0EdzFMjgJul+83J5z1zVxlLuU7HzAtxMuPnbNS/a5MZL896+mY/hTo2p/tEeE9Mj0KKf w5Jo9tdXKwofImxbEvIWHq/U5618zalsjvrgINqCRgq+gycCtPa1I7SYtC1a2erahp97f2trNcWV iFN1PGmUhDHapY9snisubVJ8kYX24r6A+B8mhab8EviRfeIra4vdKa50+BrW1cI87B2YJv8A4QSB k9quXvwM8H6tq9hrsKahpnheXw1J4juNKWcSTqscmzyklI/i65I46VpHEVraTYmkfNT6jK6kYXd3 GKg/tKUDGxa9/wBW+CHhXxt4N0vxR4Em1TS7e41mHRJLTWmSRjJIQA6Mg+6M8g807xF8A/BksPjD S/D/AIg1afxR4VtpLm+F9bIlpKImCyCNlJbkn5c/jWixmI/mEkjwBdScYDJx61PDqijGUJPsa981 T4YfDK2/Zps/EK69cJrFzfuIr6TTn8ySZIQWtAA+Am453159+zX4W0jxt8YNE0TXdO/tPTL4yRyQ +a0ezEbNvBXnI29Kr6/iEr8xXKtjiTqUY52tmrMeqoy8ggV1nhH4Pz+PtS8RXFtqVh4f8O6RNtn1 TVpikEO5ysSEgEknHpU+t/ATxFpPiDR9K06ay8RxaxEZtP1HTJw1tOqnDkO2MBSOc1X1+v3J5Uef XOqQ5IyQfemW+qQtxu4+ldx48/Z48TeEtDk1gT6VrllE6xztol+l2YCxwpcLyoJ4HvxXWfDH9k3X bjWILnxlpz2egmxubmZYLqPz4mSFnQSqCWjyQOGA9K0/tKt2Q+VHksd5D5gGePerBuIdufMUfjXQ +FPgX478baQNS0XwrqF9p+8qlyiYVsemcZ+orFs/hx4r1e4uILHw9qV5Lbz/AGWVYLZ3KS4J2HA+ 9gE49qf9pVOsULlKqzR7uHUn61bhwy7tw259qyNY0PUPD+oS2Op2Vxp97CdslvcRlHU+hB5FQxth R2HTNP8AtJ9YhynTxyI0ZA6/3s0My7SDzTpfCL2vgOPxJJqFqPNvzYrp+/8A0jhNxkx/c7Z9a5uS 4fZ94ihZl1cQ5TcjcU4N6HmubW8kyAJD+da2i6TrfiS4eHSbC+1WaNd7x2cDysq9MkKDgUf2nTen Kw5WXGbr3qPecYNRatofiHQVU6jpeoWIdtq/arV48n0G4DmqFxJf2u0XEMkJPTzYyp/Wr/tGkt0x cpptg1Gx6jrWadQuFTcRgfTFTw3TSx7jx9K6qOIp4iXLDcTVidmODzULSdjwKbJONvTn9KgebC5r v9mSWt4/yaVZM96oLN8w71OJRuwDU+zAtCT2p1VY23d6mV/lHesnTGP/ABpm7axNBbuDSL81LlJu KfnXjpTPLz2zUir+VBX5QBUcpRXaPDH0o+72xUxB/CmN81KwEDLVaT3q24AyaqTVXKBCxyp5qpJn pVmQHHFQSd8UcoiILiiloqbDOp02MTWMJYZBXvU0lo0fKj5ai0GTfptsc/wV1/hzwtqnii4a20nT 7jUZ1Xe0dtEXYL6kDtXp03FU1JnhKpNSsjmI8rjmrULFfaum1r4b69olu9xfaJf2MSfekmtnVRz6 kVznkPGw3Lj2rZcstUdkZ3J4m+YE9avRyMOrHn3qlGORVqFc5JHFHKirmlY6xfafkWt3PbA9RDKy fyNTtqV3cIEluZpUDGQK8hI3Hq2CevvWbjdzU0Waj2cb3sTzs9S+H3xw1Xwcmo2t/bJ4i07Ugv2m 1v5GyzKAFO/7wwBjHSq/xM+KsvxGOl28el2+jaXpkbpbWcDtJgucsSzcnJxx2rzzOamjYiuf6tBT 9olqKVVtWZd0+8k02+t7qEKZoZFkTeoYZByMg8H8a9b0/wDaG8X+JfEPh3TtRgt9Vs2u1gNlaWka SzJIDG6IQOCVYjivHV61o6L42n+HmqW+uWtpBd3UAdYluAcIzIQJBjkMpOQfUVzY6lF0ZTa1SLoz tNRueseKfhtpdvrXgz4YWMgOk6tqk17c6xCodZJASoijbPBjX5WHqQao/ED4A6FYeDdZ1WysH8N3 OlgMnm6zBfJegttKqq4ZD35rzDw58eNV0HTdIha3j1C/0vVTqdrfXTFnj3A+ZEB/dcncfepPE3xD 8E6lpd4ujeCZdP1W7bdJd3motOIyTkmNcDBPvmvieaL3PUPQ9a+AngmPxRceDtO1fV28UNp/2+GS WOP7KmIPNKOeGJIBwVHcehr502lWIJxivZofj1p0vxkHjObTLmO1/s02JtldTJu+zGHdnpjPP0rx l5Nzkjuc1hO0tgPUfhP8J4fEqW+veJJzp/hQXUdqGU/vb2ZmAEEQ9eeT0ArC+Lnh6y8KfE7xNpGn RGGwsr+SGGMsWKoDwMnrW18MfjprngW30/Rd9jP4fS9W5khvLKOcxkkB3UkZBwO1X/F2s+Gvix8e tRvdQ1WPRPDV9dt/xMobfaREFO12X+8cDJPrmqsuUOp51oel/wBs6ta2Rubey85wn2i6k8uKPPdm 7CvYda+B+lWHxO8E+GLPWZbyx162t5pL9UA5dmBaMf3fl4zXmEmg2Nz40l0nTtXtm083TQ2+qXZM UTJnCyNx8oI9q9x+Kmmiy1r4eanpfjPRIW06xtNKe/srwTNazpuJlKKCdgz1x+FOPUDgfHfhfwDo drfRaLruuT6tbTGJbW+09EjYhsN84bjp6V53H1r6R8eHxB/wq3xN/wALD1nStXui0H9hzW9xBI5k 3/vCvljIynr2NeQf8Kp1mP4bjxx5lmdH84QFRODMGLbclPr+PenJX2A2vDPwZ1bxFoMN/wDa7Wwu bwMdM0+6YrNqO0Zbyu2PQtgMeBk1ws0MtrO8MsbxSoxV0cFWUjqCOxr6L8P6XN4uk+EGt6VsutH0 C3ih1W6DhVsmilMj+Zn7o28g9+1eHfEDUoNU8c+IL21kWe2uNRuJYpF6OjSMVYfUEGk46aAZdlay XlxHbxjfLI4RFHdicAVu+OfBs/gTxBLo11cwXN5AiG4FuSRFIVyYySOSM4OOK3P2f5oE+MHhZrl4 44ReLuMpAXocZz74rrvhjp5l+Jnja61W0FzqGlaff3sK36byk6H5WZW64z0PFEYpoDxNsr9Kms9N u76O5ktraa4S3jM0zRoWEaA4LNjoMkcmu38VfEi98e6C1vqWgacbyOZTDqljai3eP1jIQbW3cdeR jiui8RKnwi+HtlokQEXiPxFbmXV2K/vIbQ42W+D90nGTxzxzTUdR3PH8knDHA/vVCzbeM19JXXh/ wdeeFxdaH4Pt/Enh1bYfadQ066kGq2bbAS0qMdud2egIwK+arhlWeQRljHuOzdjOM8Z98U2rCJ4L S5uIZ5ooJJYoFDSuiErGCcAse3PHNQNIeua9N/Zz1KUfEq00Vgsthr0b6bdxOTtMbqfmx0LAjIyD g1594gsotM1zULOEl4red4lZupCsRn68UW0uMoSTM3U5/GkkuJfL2F2Kf3cnFei/s9+G9O8V/FrQ 9O1W2W9s5XcvbyDKSYjY4P4gV3HxD8MvZXOlaZqvwv03wv8A2lfxwQalaXTsWXeNwVQ5XlT39a0i tBHg0Gu6lZRrFb391BErblSOZlUN6gA8Gp9H8f8AiXwzHNDpWuX+mwytukjtbhkVm9Tg9a+kPi98 OfCvgG71dE+FOrXOk2cQK61BfyrDkqPmOVIADHHWvN/hD4O8BeJvBvii+8RWWsG80O2N9LNZXSKs kZYKqKpXhsnqTV8obnmnhf4m+J/A95cXOg65eaZNcf64wycSc9WB4PU9aoeMPiBr/jia2k1zU59T ktlZIWuGyVVmLEfmTWVqjW39oXJsxItmZGMKzEFwmflDEcE464p3hvT7XWvEWnWF7cvZ2tzcJDJc Rx+Y0YYgbguRnr0qkO1yx4T8ban4D8SWmuaRMtvqVqWMUjIGAJUqTg8dCa7TxF+0h4p8S6JfafLb 6TZzagnlX2oWNikV1dxnkrJIOoJAJ9cVhePvhZe+F/ilqfgvSxPrt3a3P2eEwxHfMSoPCjPPP6Vm +J/hh4r8D28Uuv6BqGkxTMUjkuoGRWPXAJ71VmLc92+Fnxy0H4d+BbXf4w1TUbi2tpSfDraaEXzX Rl2LcZJ2Atux0z2r5hubg3Fw7kYLMTxWzfeDdd0vTlvrzSb61spAClxNbuqMD0IYjHNS+D/BOoeL vEOl6XbxtEdRuEt47iVSIgzHGSaetrCO4+GPxc0Xwj4H1rwrr/hv+39J1a6iuJzHcmGVAikDYcHD ZIOfTIroYP2jtHudduLK50C4tfBsuh/8I+ltb3Ia8ht92/cJGG0sW65GMV5D448I3Pgnxdq+gTyx 3U2m3D2zzQ52OVOMjPaubClWJPIFXaxNz3y6+P8A4X8H6J4b8P8Ag/RtSl0TTNbi1ydtYmTzpJEP +rGwY2+5Gam8S/GH4eaLp/j7U/DV1rmo6/4wgktpbbULWOGK0Esgkdg6sS2MYAxXz/bxrNcgMA4w etST2MB/5Z8e1ezhMrrYyn7SDSQua2h6RL418L+Iv2ebHwvd6rLpGuaFf3F9BD9maVNQMuAAGH+r 2gEc5rc/ZJuvCvh3xovifxH4rsdCewSaOCzuopC0rSQsocMqkAKW7814wul239w+3NSDTYBx8wH1 reWQ4rumPnWp754Lj8PXHgX4h+AI/G2iQX1/qFrdQateO8NlcxR5LBXK7t2WHBHY11ul+IPhzJ4x +HvhPVta0/VoPDeiSW63MchNhLqDuXQGTgFOeSeOxr5TfTYtpAZjxVX+zFVjiRhjtWUskxvZfeTz H23qHiK10H4Z6lF4mvfBOn3tzrWmrJF4ZWIEW6zBy8hj+/wpOAOMe9Vf+EZ1nw546+Mnji91Cztd F1TSb97GNNQjdrxXwEcIrHgAj72DlhxXxRcaaWAIlOfpSNY3DRgGdsYwRk1n/ZONj9j8iuZM+8tc +16hpXgVtB+G0njzTbfR7WFNastSmt4lcD5lJQ7cKc5JHrXC/E/4ma9p3wb8Sa9bTroep6/4xeGf +y7kOoSGAAqko+8MgfMOtfKlrqOr6fZm2tdSnto+crFM6hgRjBAOMf41RkfUp7OO0e6ke1jcukDS Exqx4JC9AT61i8sxkf8Al2wudX4/+JmofEi40271NIEuLGyjsVkiDb5lTPzyEklnOeTXLxzFjjPW qgsp167evHPFWobe8srqOeMAyROHQrgjIOQea55YHFR3pv7i1JH0F4682f8AZw+FdrdLuuZ7+8aP 5AHEQZVVSQM4ySfxr1LXvFy2H7Qmh/DfSvD+gxaVILOzv/M02OWSfMSlzuYfKcEjj69a+d/E37Rv xH8XaOulatqq3lijpII2s4AQVYMMMEyOQOARnvWBb/F/xfbfExfHss6XHiRZvPE80ClC23aPkGBj HasXha0VrB/cxK1yr8VrXTtE+Jniew0mHyNMtdRnhgiyTtRXIAyfpXtn7Mc9npHwu+J2s3+vXXhm 3ZLKyGqWUTSTQs0hb5VUg84x1r5k1jVL7WtWu9QvMvc3UzzSsFx8zHJP5muk034palo3w11nwTDa 25stUvYbye6YN5oMYIVRzjbznpmsJUpKV3Fr5FL4bHuvgXxFN4x+P3gTQ7f4gav450RNSiuj/aUc sSxsmW+47HPA6+9XNQ8aX/xg8HfF278VXj6rZ+H3FzpEsp/eWsjzlFRG7IV6r3wOa8E+DnxQHwj+ IGn+KG0xdX+xiQC1aYxbt6Fc7gDggHPStfxx8b7HUfDd74d8GeHB4T0TUpFn1NZLs3U95IpyoaQg YRTyFA6k1HXXyJ2PafB/xo8TWP7O3iTX7uTT7u5sNRs9N097jS7Z/KTYS4x5fzcBRk5PFeAeIPFV 14s1OfVL1bdbqfBb7LAkMf4IgCj8BUjfFO1/4UfH4FispkvG1g6nPeFxsZRGEVAvXPU1zELbYVGO QK+gyWnzSbfRfqTPcutKT3prPuXHaqpkJ709XwOK+t9kjAkVju4H41Ir/NnpUCsd1PV9xqHSAtK+ Vx/WplcFdtUgw+n0qxDJjvWMqVkMsL+hp3O7A6UyNjUijnmud07CJR2pCR3pwXJprLWPIPUay+9M bjNSH8xUbNtFLkEVbiQrmqzPVqZe9VmjDGnyjuyGQZ5qA+1WWXHTpULLT5REODk4OKKkEYPvRWfK F2TeGdaNvZRRycoBwfSvX/hb8Wtb+GuoTah4cvFtbiePypN0auGXIOCD7ivC9HZfsaYrYs7qSFgY 2K16FCjGrh4qSumjGph9eaDsz6g8TftSeN/Gvhm80LU57OSyvE8ubbaqrFcg8Ht0ry3yxNwy5rmN K8QK2EnGD/erp7OVJlDKwPpzV06EKKtFWPGre1jK89yFtLbrFz7GolVlYqQVxWxFntVhraO4A3IC emcVtYUMU4/EY0bDt2qZWPANW5NHKsNjce9V3t5IGw6Ee9HKdMa0Z6pj1bDfpUoOahTrn9alX3qO UmUiaNvWr+neCNR+IWpQaLphhW7mDyKZ32rhEZ25+gNZ6+3SvT/2eFST4vaFEzbUkW4jLf3QYHBP 4VxY2P8As8/Q1oP94jxCDwNqs3g278ULHGdKtbxLCRt43iVlLAbfTCnmsWa3mtiDLFJHkcblIr7M On+FfEXw+t4PBC2FlbyeL7GzkjmBnh81A6id1Y8iQEHb7Vd1h9P8cfDv4j297ceINbOjWrlDrVnF HbwToxAaB0AOeDgH+Gvzx0z3bnxDnC5qaNSw4PJr6g+LXxO07wL4u0/w5e+G9NuvDFxoVtJe28Fn GtxPJJbgK4lIyhBC/dI6etW4rjQNNuvhL4Zi8I6JcReJNNtjf311ah5mV3ZfkPG1hyd3U5HpU8nQ o+ZNC0HUPE2sW2l6ZayXmo3L7IbeMfM7dcD8qgkhktZ5IpVKSxsUdW6gg4Ir274X+H9N8P8A7Uke gC1N3YjUJrOLzZXWSIYO11dSDuGOtHgTwl4RHhj4h+IfEul3Orf2Jfwx28MVy0RbfI67WYdiQMnk 8UlAR4mrN3p+/HJGK+kLD4DeFfE/ibQbyA3Ok6XqmhPrC6KkwklZ0YqYI5TyS2M5wSPSue+LfgPw t4S+G+jXen6Bqel61rF28iRapNme1iiG1kYYGQ5IYHHbrV8jsB4n5pOcHFPW6k2+WHbYeq7vlP4V 1Hj7RfCmkWOhSeGtdm1ie4tQ+oxTQ7Ps02BlAcDIzn16Vx0Lcn1qLBubNrql5aWk1tDdTQ284Amh SQqkgHTcAcH8aRZN2K968E/BTw/ceFtA07Wra6fxN4otpLqzvIXYx2a4/wBHGANpMjAg7j8vtXL/ AAL+HOj+MPiTdeFfE9vdrIscyK1rOEMMsed2eDuHBFXyt6i62PNLO8ms7qO4hcxzRuHR16qwOQR+ NdlN8XvEEnjQ+KoZYbLWHRUmkgiGyfC7WMiHIbd3zwfSqHhXw/p2qfEDT9F1GS5XT7i+Fo8ltt80 AvtBGeOuKq/Ejw1F4L8da5odvO9xBp929uksgAZgpwCcd6OVhc6fWPj94s1h7AzT2cEVncpdrb2l nHDHJKhyrOqgbse9cR4h8T3nibXrzV75/MvbuZp5GHTcTngentWWu6SRUTlmOAB613/jr4J678P9 H8OXWpmIXWss6LZKcyQsNuFc9MncOO1GrGdJpH7R02k7dQtfCWjReJlh8r+2kV1cnbtLmMEITj2x Xj91cPdXUs7ndJI5diOOScmvW7r9mnXYUurW11nRdQ8QWsXmz6Bb3JN4mACy7SMEgEdDWP4X/Z/8 V+KtFt9TtxYWsd0SLSG9vEhluADjKKx5GePrV8rsLQi+EPjHRfAF9qevX6Sz65a25XSIFjygnYY8 1mzxsHOCDnNcHfXkl/dTTytulkcyO3qxOSfzNN1DT7rSNQuLK9he2ureQxywyrtZGBwQR2Na/h/w Pq3ijRdb1WwiR7PRYBcXbM4UqpOOB3NFug7nS/A3xppfgf4j6XqusPJDYQrKsksMZkZd0ZUHb6An tW5fW/gTQNa0bWdN8eXGt+RqUMslnPp0kTJHvBZgSSOAOnevHGJBqCRjVxDc9W+PHxTn8XfEDxDL pGuXs/hy7kXyofOkWJ1Cr/yzJxjI7ius+Cfhuwn+FvjVJfFXh+wvvEFkLO3s72+EMsZWTJLgjgED jGa+djI3cE00sSGJwMDP1qwtoRapD9lu5od6v5bsm6M5U4PUHuK6b4M+C9U8dfEbR7LSbYXcsNxH czKXVdsSOpc8kZwOwrlGRpmwqMzdcAZqg1xLbzB4ZGikHRlJBplI+0rfw5q2i/tO/Eea+tWt7vV9 Jv5NGQuPMusgKnlYOc8HjrxWJ4R8MeLNL+Euu6b41bUNMvtQ17S7fT21zdIUzL8zxrIcHHfH418k Lrl/FfRXQvLgXMZzHOJW3p9GzkfhVzWfF+teII4F1TV77UVhz5Qu7l5dmeu3cTjoK0Mz7z1xnvvC /wAULS/tfE08GnafNC1xrcytYTy7gFeCLaAp4yu3hRxVOw8SeKNJ/aQ0XwXotqZfBdta2wlsBaA2 1uPJVmkUgfKQxBznqa+MdU+M3jPVtLbT73xRql3ZtB9mMM10zKYsg7MZ6fKPyrW0n9pj4kaJpllp 9p4uvobSzCiCP5WKgdFJIyR7E4pk6n1jea14b8E6Hc6zearH4fvte8Qakz3f9jJqJuUjmKKjBvug dsdc1x/iDWvB3hbwf8RvGeieFNO1FP7ctLaxj1exKrFIYcyP5bDIBYsdnA5HpXgXhL9prxx4Mtbq 3s761u7e4uHumj1G0juVWRjl2TcPlyeTjvWHr3xl8TeJvDWo6Jqd6t5a6hqI1W5kkQGWScLtB3eg HamlrcRvfEzxt4U8ePoeoaLoS6JrwtmXWFtYVhtZJMjaYkBOOM5rg5vmYgVS0mRFmcswU4wNxq7L PHk4dT+NfpWRqP1SOvVmMr3Gsvy5AzxTN59KXzd3B9expOA2O9fQ8i3Idw3+1QSHaTVhk+XJ4+lU 5V2tVKmh8w18sR+tO3dB1FRTE7geadu4AFJ0kHMEh2KD/FVdpG45FSyLuzk/hVZk2H2FEaYcw/d0 yc1bhl3R89M9azuvsfSrNu21SM8UOkPmLG/HzE8ZpGkLNjPFQseB7dKTJrF0g5tRZmxwO561Dgbi etLP2PIxVcygcZqPZXWpRM23pgY+lQtHHjlF/KkdvlwDUe/rWTw8HukPmYLHExOUX8qkZyq7RxUD OQc/yp4YYBrL2EYapWFdki/dPc1IrYXOORUXO0dqf9DScAF8ztUkbfjVfad3Ix71Og4NYuAEyc/W rEeQw5zVePJx61Zj9awlERaRTUqe/Wmx/dBp+4dQK5XEZIvrjihgDmmBsdDxS+vesXAA2/L1qJ1w eakZjn0FMPzZrPkAgkAwfXtVZhtYZHNW5FHSq7jFNRAgZuuahappBntUbLg+1Jx7iK+8p6Zop7Ly aKjlC5k6K261A7g1rI+OO1YOgyZtTjk5raRuOeld2A97DU35G5djrSsdSns8GN8D061krxjnNTrJ 0ru5e5EoqSs0dvp/iiOQATrsJ7iumtLqO4UFJFb0wa8rjb3x3q7a38tq4MblCPeodM8utgISV4aM 9XjI781P5auuCM/UVwmn+MpYyBMgcf3u9dPpviWzu9o8wIe4alys8Ktha9N3t9xptpEEn3RtPtUE mguAfLcH2rRhlD4ZTuFWlbDcUuU4vrNSGlznP7PnjwCmfpWX4iubzRdPNzazTWlwjgLNC5R1zwcE Hjiu/jX/AOvW34P8H6V468XaLoerxtLp15c7JlR9jEBGPUdOQK4MdD/ZqnoztweNlOvCEluz5ut/ E2p2djJYwX1xFaSSrO8MchCNIv3XI9Rk8+9dbqXx68fatYSWV54p1C4tJbf7LJDJINrxd1IxzXVw fAO4h+GfiLU9Q0y+sddi1Oyt9LW5PlRzQzs67vmGCDgYbOBWdrn7Oes6bo9/f6Zrmh+JH06Pzb6z 0m6Mk9ugOGZlKgYU8Eg1+Y8kj7g4TxF4w1XxjfJeazdte3UcMdskj4BWNF2ovA7AVvx/FrxAdW8L 6i9zC9x4Zhjg07dENqojFlDAfe5PetyT9mDx5b6THqBs7JlmtVvLe1W9j+0XETIHzHHnc5APIAPI xVDTP2e/iDrGiwarZeHZ57GeAXMUgkQb0JI4BOSflPy9enHIppMDR8FfHa+8IePL/wAWzaNpetav dS+cJLxGAgckktHtYYJzjvxT9a+NzalpHi3TbLw7p+j2niKW2mmitXkKxNExYldxPLE5Pp2rmfhj 8P5vHnj7T/D832u2SSQ/apLe3MssEaj5n2Dk4qiPDGoapf3sGlWF5qK203kmS3tnYkliEyADtLYP HsaPe6DPb/hX8a9Ck8UeC28RQf2UnhvTWs7C9Ds8XnliyyTADIT5sECrX7Q3iDwv4k0Oz1L+2dK1 Pxg1yRv0GaeSA2xGT5nmk7W3dAvGCa+ebjSb/Tb42F3aXFteAgG3liZZAew2kZq3NoOpW+mvfy6f cxWSSCBrh4WVBIRkJkjrjnFaa2JOq+IPxAsPGljoUFr4csdCk021FvLLZDBuyABvfgc8e/U1xiSc +hqtu4PrSq/Y+tTa+4z6t0H9pKLSde+Gdlp3iC4svDWn6fbW2swGEiMSKW38EZbjHK1F8BNV8N2/ xc1rxdqPirTNMtvtF0sVtdMySTLLu2upxjHPrmvmu2028msZbyK1nks4SFkuFjYxoT0DNjANOhjl kDbEd9oydoJwPU1psI9n8IeD4IfjhaQL4k0GW1s7yPUG1D7cqW8iCRWKq7Yy+D932rM/aJ0l9P8A ihrd2LyyvLXU7iS8gksblJhsZjgNt6H2NeVtI3emeY2cDigktQB5Zo40BZ2YKoHUk9BX0n8S/hz4 oh+Dvw0s7nTrq2ubWedLuaQZFu8syiMuRnGcivmJZNpGDg1p/wDCSaqLfyf7SvDFkERtO5Xg5HGe 1KKsyz6X8RDxB8D572Dw94U1DVdbSBkvfGV/bSykuwG7yeq7AOMtknrW54eutNt9K+DtvqXhqXxL c3ESvb6ks7xCwLTjjCKVbB5+b0r5oj+LXjRLd4V8V60IXUq0f2+XaQeoxuqbwz8YPGXg/Sm07RvE V7p9gxLfZ4mG3J6kZBx+FadSGS/GV5W+Kvi3zpVuJf7TnDyqu0Md55x2r1H9nHUI9B+GfxN1WTTo 9US3tYM2k2Skh38bgOoHBI74r55munuJXkldndiWZmOSSe5Ndn8OvjF4h+GMV9Doslv9nvin2mG4 hWRZAp+6c9iCQR3BotrcEe/6X4H8OeOIPCfivUdBsYbifRtS1G5sLFPJtZmt2AiBQHocnODzXPaL 8PfDfxo8N+GdXTQrfwrcXeu/2VLHpBYxyReXvLEOThhjjHHNefP+0p4mbxRZ6qbbTo7S2t5LMaPB b+VZtDJ/rEKA5+YgEkHtT9Q/aU1qN9EbQdF0rwzY6Xdm9SzsYSYpZyNpZt2T93jANUOzOz1rwH4D 8QXHxD0HSvDc2iX3hS1muE1Zb95vtBiYLtaNhgbvXPFQeNG8CRfsx+HbhNAvrS6u7y4Fq8dwjOLl UCs8jlQWjJ/hHSsDxJ+0dpF9pHiMaJ4Lt9E1zxBCYNR1L7Y8wkRzukxGRgEnoc8elcjN8U9G1b4O Q+DtW0u5kvtLnln0q9tZgiIZCC/nKQd3fGPWqVrlanUfsn6XaXnjHWrg3M1tqlppVxNbsIElhK7C HDhuc4IxisPwH8E/D3ib4cX/AIz8S+KH8Oafa34stqWnntJlA3yDcCWyRx6Amtf9nz4m/Dr4dWWo XWux6/8A23e2s9hK9mkTwLE4xlQSDux61h+JviJ4VT4Pz+C9BfUJiviNtQimvYVUta+VsUsVJG/P UVSXQHvodJ4T/Zah/wCF4aZoF7qljf8Ah947fUA004tZ7u1kBICRk7t/ByoJIFO+P3wz1LxF8YtH 8F+H9A8P6YsjSQ6cNJdA0kIPL3JDHDKFPXB61fHxo8JXX7SHgzxQ99JF4e0zTre2lnaFsxukDKfl AzgMQOK5X4afFHQtN/ajuvFl9dmDRrq+vGjumU4QSh1R2HUD5hn0FMz12OW8ffs/3vg7wvP4hs/E GjeJtMtZlt7uTR52kNszZ2+YCBjJBFeN3DbZMKa+n/H0ugfDX4F+J/Ddr4t0vxTqfiDVLe7jOkMz rFHGSW8wkfLyePWvltsM2SauysJHruj/ALLPxM1nQtK1ay8P/abPU41lttlzHuKMCQzLuyoIHU1m aJ8AfiH4gk1BNN8KaldtYTG3udkX3JB1XnqfpX17/bWmN4duraDUbVnh8IaBYBo51wGknBIGD1/l XffFK7bXmtE0TwS3xA+y6jdJctZaq1obGUOuFYoeSRg89hSuwPzps/hj4t1TWNQ0uz8Pand6hp5/ 0u1gtXeSDnHzgDI5rmfEvhfWPD6QSajpl3YJcAtE9xC0YkHQlSRyPpX6EaL4o1bXvEXxJ1Se0t9A 1Fr7QtJMOmX63BTM2CDMmMkqSCPwNefftnakdQ+Fepvcv9oZPG1za2jyHcYIY4gDGhP3V3DOBxW0 ZSbsB8WeGdJu/FHiLTtItX23V9cJbRF2IAZmCgn866T4neBtU+FfjXVfDN7eLd3Gmy+U9xbljGxw Dxn61q/s46ampfG/wXAF3k6pC35Nk/yr688TeJNU+IHjf42eGvEWmWqeG9I0y4uLOzayWNjMHURz eZjeWJO7rg56YrT2tSLsm/vGfAbahcleJZM/U1BJqV7185x6V+kXgnwX4aj1jT/h1rUnhiK4h03/ AE7w3a6E8sgzCXLi/b5gxyG3HGDwO1eXeL7fwR8Gvgf8P9Ti+H2i6/rutT3KLPqSFwEEh5cAgudp UDnirjjK/Sb+9k2R8XQ3GsXEM9xBHPPbW4BmmSIssYY4BYgYGTwM08a5exjGVI915FfonD8BfD/2 P4u+GNKH9j6XqFxpjXMNsu+RAIjcSw26dz2VT0z3xXzP8P8Awx8Mvid8apbC6spfCegQ2zrZaZdX ZR724TgJNM3+qZ+SccA8Ct45jikv4j+8LI8DbxFcK2CE9qrzeJJ9xzHH+Ga+hf2ivhv4N8E+HHH/ AAhWs+BtfEqGylW9Op6fqUZGX2z4UKVBU5Gc5xXzLChmkCKPvHAGOa6FmuOirqowUVc1V8SOrcxK SR2arsPigbTugHoPmr6rsf2D9IsY9G0/WG8aXmr30MMkmoaJpUcumxNIMhS7MGAXI3E+9eZa5+yb qdroOuSaJqA8SeIdH19tGutH06Le0cfRJyc5wzcfdwMHmrjnmO/5+fgv8hcqPKv7ehkXLKye+c0R +JLaQH5XU9K+r/AP7Meg+HfC/wAVdL1jW9Evb220yyjbVrpcRaVM7FpUyCfnQLj5eScDFeJ+Iv2U 9dsY/Dd/4Z1vTPF+ja9dNZWuoWbNbxiZQSVYShSBgE56cVpHPsalq19wcsTzyTXLTyyCzA/7tVf7 YtZODJtPuK9N8S/steIdN0NtT0jW/D/i2GK5itbgaFemZrd5G2p5gKjaC3Ga5NP2e/G0/wAUb34f 2umx3nii0DGa2huEKDaoY4ckDoRWi4ixiWqX3f8ABGoo59tWtN2PtAJo/tC17Tpj610vhX9mf4je N7Ca/wBF8L3N7axytAZDJGgd14YLuYbseoyKtfCX9lvxv8XfEl9pdnp02mwWBljur65hYxQzIpby jj+I4wB71a4jrr4qa/EfIjkVuoGbiVT6cip45EY8Op79ax9a8D674b8QS6DqWlXlprKOI/sUkDLM WPQBMZ57euah1fwxrXh2RF1XTL7TXf7guoHiz9NwGa0/1kle0qX4/wDAFyHSFt3OQfxpc5+tW/hv 8Hdf+JTa59kkj09dJ0yXVJXvd6B40x8q8dTkY7VwonlXOZWH4mn/AKxQerpv7xcp2Kr83PBqZV4z msjQpXktNzMWy3c1rJ8w5r6ahNYilGqla5BNGT0/KrUfPNVY+D0q3H3olGxKuWIztAzUi89KhTJy KmjA+lc8og7jlJHFKf0pBzml78c1g4lA3v1puKd97tSj/wDXWcok9Su2ahkywANTvn8Khb0qeUor smfqKif61YdqqyfTFLlJZHuOeBmikZWY5BwKKylHXYPkc14dY+TIO2a3kYLiud8OSFo5R1APGa3U bPXkVvlfvYSH9dTcuxtx1x6VZjI/Gs+Nwp5qzGx6V6/KK5cVunoanjYcdzVNWC/Sp1bpjmjlFzF1 ZAvepI5Cpz3qmjfjUyPS5SDYs9Yu7VgY5mGO2a27Hxxd2+BNtlH05rkA+PrUm48VPIc1TD0qvxxu em2XxBtJABNG0Td+9dj4A+KHh/wr4w0TWdQu2jsLK7WScohZguCDgDr1rwZZMGotSWS4s2jiDO7E AKoJJOegrix0P9lqejOOGWUYVY1IXVmfStz+1F4f8beCddsPFUYbGvWlxaWSIzGWwSXc0I4wFRQc An+M13cPxf8ADK+H/HaXXj7w7dWOpabPHpGl2VisEsKkHZFI4QEsBhdvI4JzXxJrng/X/C8cT6zo moaUkpxG97avEH+hYDNY+8qa/KOdnv2PoH42fE1rbxx4O1nwrrim7sPDtjCLi1kD/Z5hEVdecgNg 4IrsLvxcl5r/AOz1CurRywQ29u11EtwCsUv2k5LjOFbGOtfKPmE5xUizEcCkpa3DofWPgXRdU1v9 s++v9Ige6sbHWWmvLi3YbI4mJGWIPIJq1oX/AAkXwv8AAvxsmK3Whaql5ZujsNkixyTSYZT2yDww r5OtdSubKTfb3EsDf3oXKn9DVuXX9Qu1mE1/dSrNt80STMwkx03ZPOO2elWLofcXgjUo9S8TfDC6 1C1bUde1zwxJEmsSoJZoLjzG23DseTtAxnORxXE/tWX+u6H4V8N+F9Tvb7U5lkluL7VprPyIr6QH EeM9Sikj6Eda8J+Gvxs8Q/DfWobyKb+0rRbVrGSwvXZomtmOWiHOUB9VxW58Rvj1H418J2/hzS/D Nr4b0pbr7bLHFcSXDSTbdoIZzlRjsOtWtUKxpfHeXxM+n+DP+Ej8M6f4fQaYosprELm7iwuHfBPz dODg814+sg3elWdU8RalrUdsl9f3N6lsnlwrcSs4iX+6uTwPYVmmTnPakkFz9BfAfhm007RfAnhO 31rR7bRdV0cyX2j3kpF5ePcpuaRVxtYrj5M9MGvKv2UI5NJ+MviPRI5DLp32O7SSORQRKI2whbjr z+teRWfx+1+Hxf4V8RzW9lNeeHbWKztY/LZUeNFKjfhsk4Y8jFb/AMJ/2h7b4a6tqWqP4Ss9V1W+ eVnvmuZI3VJDlowBlce+M1Yiv8E5mt/jf4cCxwyJLqawOk0SuhR2KkYIx0P4Vz/xYhhs/iV4pgto lhhj1S5VY41CqiiVsAAdAK6Dwh8VPCfhr4m/8JQ3hGf7HC6T2en2+osPs8qkEsXZSXBOeD61zXxU 8WaJ4w8YX2s6Hp95pkN67TzQ3c6zHzmYs5UgDC89KAeyOes1ikvIVnlaK3LqJJFXcVUnkgd8DtXu Hxc8E+B9Dsfhtc6KLq10fVYGe8vphmeWMShTKU5AOMkAdsCvCtPe3e+gW7keO0Z1ErwqGZUz8xA7 kDPFfQ3jDxh8L9c0v4f2kWsapdWfh8paz2t3YbPtFuZN0jFlbggZ4HWkmPQ6HTfhb8P/AIh6F4ik 0rw3qPh3StMtpZbLxZcXbmG8aMgANG6gAtnoDUPhv4AeD7jTvCmn3lt4h1HUdfs0uP7b07Z9is3f ICSAg/dxzzk+1Y3xa1Xwn46+13lh8UreGxt4ith4f/sy5gijiXlIgFBUn/aI68mu88K/FLQpm8F6 xb+PrXQtA0jTI7fU/DU00kclxIgYOREo2PuyMZ60xbnyV4i04aLrmoaf5y3H2S4kg81RgPsYrn6H FeqfDP4Ij4kfCvxFrGnx3V14htbyC2s7eJlEbBuX3Z9u+QBivJfFGo22oeINSurVfLtZrmWSFcbc IXJUY7cEV9FfBGyufEn7Ofi3QtH1e1stdvNRjEVvJdrDJOoUExjJH3gCOeOtPqNbHi998JfGFt4r Pho6DePrYXeLSNN7FcZ3AjgjHfNZHibwZ4i8J30OlazpN5p13J88VvcREM+TgFR3544r7Jkll/sy /wDCWn3aTeMbbwTFZCytrhTOLgSlmRWB5YAhuD0NaPw1t30q6+E2k+L2VfEkY1KWSDVHVrhSeI/v EnnPy/Tim0CZ8Na14N17QFjfUtHvtPWRtqG6tnj3HHT5gOam8VfDrxB4R0PRtU1SxNtZatG0tq5I 3FVO07h1Xnsa+l9W1Txi/wAG/ind+M21TzLS/tH0f+11YGL9+3zQlx1xjkdq5/8AaU+I3ijUPhH8 PLS51GS6tdW0sXeoO0anzpRJ8hLY4P0xVqI7ngXg/wCH+qeNNP1+60424j0azN9c+dKEPlg4O0dz XKsrf3T65r6R+AN5NL8DPizHcQQS21vpyyQSSQIXV2ypIfGcYA4zW/4e1LRPAPwh+FTDwfoWs6v4 jvJ4JbrVLQSt5fnhenUn5hgk8Y96fQpny7ougah4o1S20zS7S4vb+4bZHDBGXZj7AU/xf4H1zwDr b6T4g0+bS79UWTyZsbtrdDwe9fa/wT0Dwd4N/aa8daLpulXUd7p8c0lvcLcgwxQFELx7MZzuY4Oe mBivF/BPhnwR8SviR431uS21W98NaBpM2qfYdRuh5txIhAMZkQcISTjHPAqjNnzZdXEiW8kSsQjf eAPBx0rHkfgkdetfQfxv8H+EJ/hb4Y8feFdGn8Mxapez2EmlzXbXIPl8+YHYAj0x0rw3RdLXWNas bLcV+03EcO5RnG5gM/rWqV1ckz4L5rdi2T7YOMVftvFWp2G42upXdtu5byZ3TcfU4PNfZWqfsQ+A JtQnsNP8R63BdR339jL9ohjdHvTD5qnIxiPGc8Z9K5ux/YNtvJ07TNT8T6ha+I7+IPGLTRpZ7BS2 SgafgKcDnOMZqoyj1A+U7Lxdq2lrILTUry2EkqzsIZ2QNIpyrkA8sDyD1FN1zxxrfiCxFpqGrXt7 bC4e68m4nZ185/vyYJ+82OT1NfQ/g/8AYf1PxLpd8bzxPYaXq8Wq3OlQWTxPItxJAu5yJBwBgMeR 2ryf41/BW7+DupabHJqVrrWnalbfarLULPIjmTOCQp5GGyOfStk03ZAcX4X8Wal4O1yz1nSLp7LU rKQTQXEeMow6Hn+teheJP2oPiT4w8MPoGq+I5JtPkIMu2JEllAOQHkUBmGexOOB6VpfsjfCvR/i5 8WE0fXbWS801LG4uXgikZGdlT5ORz94iofiJ+y7428Era3IsYdStry8+xxLpNwLt45iflikCfdY9 MH0NT7rdnuBsaf8Ats/EjTdPigjudMluFt/s0l9LYIbmePZsAkk+85AwcnuAa4Txp+0B4j8caJ4R 0rU47M2nhgEWYhiKs+SCTJ8xyflHTFafjb9lv4kfD3QX1nW/DzQ6erKjyQXEc3lk9NwRiRzxz3qh N+zL8T47Se4fwRrCwW8QmlkNucKhXIY/hzSSgtgOk8Wftg+LvFFvqqpb2uj3moaxb619tsWdZYZY YhGiJz93AB55qW1/aK0TVPHVz4i1/wCHmj6pFqVmttqdrGxi8+bHzXEbY/cuxwTtH881wWtfBHxD pHgLwv4o2Ldw+Irma1s7G2Vnud0RAOUA5yegGTxXJ2Xh/VLqeS1gsbqW4jJDwxwsWXBwcgDjBocV ugPZ/jJ+0Roviz4cQeCfC/ha40HSPta3sv8AaGpPfujKu1UhZgNiYJyO9eCWM/2O8iuNu/y3D7ex wc4q1qWn3OnzeVdwSW7gfdlQqR+BrNk+Yg5wtTaysB9neIP2mvhv451ODxPqPib4heH9UFtEs2ha JOIrRnjQDy1kD5UMR97bxnOK5TwB+014a+D+lWOp+E7W4n8VaxqEr+IZ9YLTNHZ+ZlIY3/iJU5Zs bsjqK+WmhYLu7daaY2wCM/U1HIrAfWnjr4p/DLSfhR8TPDngvV7i6Ova5bXNnDcQSBjAq7nO5gMA MSADzwK7T4d/Fb4Xf8IB8GvDXiDU7G8SxnvLi+tbhCYra4ZSIGmyMbdxBzyOK+NbjwXr+meGdP8A EF3pdxb6LqDvFaXzpiOZk++FPfFYTZTPPHvUvYD9KLj4uaJofgNbfxb488I6vqE3iHT3mXw1BGqx 2qS7yT5agycLzxx070/wP4XtPDfx++IfxO1XxV4bFjfWt5LpsMGpxSyyqwyrYB+XCgDB55r80pJC qqRxUnnblz3qNlYD79+GvhXXfiV4B8NWHiPSbXX/AAmDJPp/inQtSSC80LdLuZJN2BhSCzYUn3ri v2cby/X4y/F37P4mm8V6tFot9HY3Uc7NLqUxwqvGucu2BnjOBXxwuq3cakRTywg8MI5CuR74pmn6 tfaNfJd2F5PY3cf3Li1kMbrn0YHIqL9x2Prv9jO2ltfiJ8Qta8VW99e6zo2jzv5EjE6h52QuIt2W Eg5wRyDivYPD+taZ8TNZ8B+HdS8JeMJ7CfxA922oePpVuW2xQMzwRFvm2nCkjGOO9fnzoPjbX/DO uLrel6zfWGsKWYX9vcMk+WyGO8HPOTnmtrV/jT4517xFp2u6l4q1S+1fTiptby4uGkeLByME+9Q3 qx3Psrw/8TfF/iH4R/HHVfECSXGkW0TWmlXFxbbGiWSXaYY3wMqFC8fSvhg6LqD6W+opY3LafG3l vdCJjErHsXxgGu88TftJ/En4gaXdaPr/AIuur3TLzYtxbyJGkbBSSMhFHc9uvFVR8b/E1j8MLn4c Wuor/wAInPc/aXt2tkDs+Qc78bsZA4z2qrp2XmHmZGips06LjrzWkh+bHUfWqmnr5VrEOuFq9Go9 MHvX7LhqXs8PCPZL8jnbZPGPm561ahOOCeKrR/L1NWVwelROIalhevHWplwy+9QLjHSphkc1zOID j8uMfnSZ79DRtHc02sHEOo/dR+NRbqer8YxxWbiMSUYU459KrsD6VM/Q+lRN9eKmwFdvm681WfAO DkVZbgHAqFvUjJpWIvYg59qKduIzxRXNP4izi/DkwHmgHkgVuxsWIHeuZ8NH97J9M10anGa2yX3s FD5/mXJl2NvmAP51YjkFUom3YJNWI2HUmvdUSC2rZbjr3qdH96po3qasR9PSq5LAWlkzyBUyybqq rwODUiydu1LlAtLJ61IH7VWVjtBHWpFOFPPNTygWF+X3r0b9nzy5vjX4ISRFkRtVhBVhkHmvM1Yk c1Zsdav/AA7eW2paVPJbajayrNbzRHDI6nIIrlxlJzw1SMVq0/yGtz03VviB4y8SXnjTwpe2l94q 0K41uOKSWZnley23LKiwuxKxF87cn2r2a/8AgD4I8VaP4l05NE0Lw9qmi2EtyG0rW3u9QjkjAPl3 ERG3PZivGelfPniL9o7xxremy2cWnaToZuLiO6u59H05LeW6kjbehkYfew3zfWuht/2u9fsI9aeH wV4fg1LWrV7fUdRjt5RPdMy4MjHf15JwAASfpX5N9WrLeD+5m99DvIfgx8MG1rwN4Pk03WG8Q+K9 It7oalHegQ2cjxk7wmPnBYH5eMetZdr8B/hro+meCLXX9S8QPrnihWigXTxGIoZBM0QkYuOVzt+U c8GvNrX9om+j+IngbxVPosbN4VsobFLVJGUTrGrAMzEHBO7t6VLrX7QK69q/w6u30ZoV8JyGSRUn ybkG484hcj5eOOc1k4OLs0I66P8AZs0PwnpviTWPG/im4s9H0vVm0aKTSbPzpZJgM72ViMLj8c1t /Dv9nPwnF8cIPDHiLXnvNOurSO/023W3dHvoZImcB2U/umUYJGSD0rIvv2jvCPxCsPFWheK9L1fT dC1TWf7atptLaOW4jkI27HD4UjHcVTH7R2iw/tB+G/GMGnXZ0DR7SHTQshUXEkSQmLzWA4DYOdoP bGaWwkeWePtF0nw74nvLHRNaTXtOjbCXqQPDu45G1+cg8fhVXwh4Z1Lxt4isNE0iD7VqV5KIoYgQ Mn3J6ADJ/Co/Hv8AYsPii8Hh7VZtY0tm8yO6uLY27sW5IKEnGDxXTfs8eNtO8B/GHwxresSPFptr dZmdF3FAysu7HoCwJ9hTKTOn8R/s1+K9Dt7e4trvR/EFvNdR2TSaPfLOIJXO1BL02ZbjJ71y7fCX xSvjDUfCy6VJNrmnpJJcWsbqdqou5iDnBGOeOte9/ELxhdapoFzo0/xH8ErZ6xqcCImg2QWTZ5mf NnkVV2BBg89eeRXT+Ivid4a8VWev+BdC1xbfxLZ6QYj44meIDVFiUs8BcchWBIBBJOMUEnzn4V+G aav8LfFXi26N9AulvDFatDDvhkkZgHV2/hwpB/GtLwb+zp418beCtR8Uadp7rY2qLJDHIjiS9Ukg mAAHfgjmvSPgx8PfEGrfs5fEFbK0W5fWvszafElzHumEch8w7d2Vxj+IDNaX7Neva3dfBP4naPpF 9ezeIYFh/s6wtZmaePBIYwqDkcnkrTsNny9cRTWNzJBPG8U0bFHjkBVlYHBBB6HNdf4T+G+peMPC PibxFZzW6WugJC88MpbfIJGKjZgEcY5ziuP1aW6/tW7N+sy3xlbz/tBPmeZk7t2ec5zmvpX9lvVd V0H4SfFTU9Es1vtUtY7RoY2h87GGcl9vfaMt+FHUOlz5yZGjbDLtPoRikMr7AOWQHIFfdHhbQdO+ JmjfDLxL4r0q0v8AXJTfPcStAsYkEUcjorooAIDBTgiuU8IaXpXx58K6PqPiTQtMguofE8Gnb9Lt ha74HTc6uF+9nA57dqLCPkIO+31B9ae3mrD5pRhHnaH2nBPpmvrCPR/CnxS0X4pWU3g7R9AbwrFL JZXujxGGZyhkA38kEEIM/WsrxR4n8NSfsm6NJ/wh9rEbq/mtoFiu5B5NwsYBueepOOV6VXKO+lj5 WeRmYn1pPtDLzk59ajmkCsRXu/wR+Cvhbxx4C1LxFrE+savPazeVJo/hwRG6towCfOcSfeU4xhRm i2o1seIQ6pc2siyQTSRSLyHRirD8RT5vEuozXkd299cPdRkFJ2lYuuORhs5GK+hPCf7M/hzxrrHi W50zXtUvPC+lLDtS109pNQ8yUH900eBkpg7iB9Ktn9iSa/8AGS6daeIWtdKuNKbU7e41G0MU67WV THLHn5OTnOenar06juj588RfEbxL4ss4bXWde1HVLeFt8cV5dPIqNjGQCTg0jfEnxFJ4QHhRtWuX 8PeaJhp7EGMODnI4yOa9fm/ZPGstpEnhPxppviOxvNS/sme7jheJLW42lu/LrgNyvoPWvOIvgvr1 1o/jPVbee0Ft4UkSK8LOVZy0hQbOOfuk844q0Gh0Pgz9qXxz4M0SDRrW/t5NHgj8lbWSxgfKdgSV +b8c1zOrfGjX9Wi8NpPLbmHw7cPcadH5CqEZpBIQ23GRuA/Diuo8P/CWwf8AZx8ReNLq1+2al9sh gsrm2vVItRvAcSxZzkjpweoPFZ3h79l34i+KvCsWv6fofmWU0TTQrJOkc0qAZ3LGxDEHHGBz2qkk BH4Z/aV8TeGfiR4j8bR21hdavrkMkNwksbCJA+3lQGyCNoxkmsj4U/GKb4Y6vq0kumQa1pWsWj2W o6fO5jE8Tc4Drypz6VF4S+Avj3xxZT3uieFtQ1C1gkMUkixhcOOq/MRkjvjpWSnwt8Wah4kvtAt/ D+oS6zZBjcWMduzSx465UA+o/Or0Jub3xh+Nlt8QfD+heHdF8PQ+GfDukNJNDZRztOxlkPzsXbnH TA+tec+E9Yi8P+KNJ1O4iaeGzu4riSJDhnVXDED3IFSaz4X1TQtWfTNR0+5sdQUhTaXETJKCenyk Z5qjqGl3Gl3Bhu7eW2mXkxzIVYfgea2UdLEn2JpP7avhM+Ikv7vStVt4m8ST6y4VI3PlNbGKJfvf eBPPb3qzqn7Ungvxbd2WtXHxA8ceFJIbNIZvDujLtid0UgbZclQWODkrXxVY28t9eQ20ULSzSuEj jT7zMTgAe+TXpOqfst/FXS7Z7ibwPrHlom9mjty+BjJ6ZqfZwvqB9DfCT9pXwRoPh/w4NS1m8S9g v9Yvrpr2N5pFeaNlh3uq4ZmzyR3z0rxT9pz4iaD410/4d22g6imoLpegx292EVh5U5Ys6HIHI9uK 8Skjmh3odw5wynjkeo9aijjaTsK2UFF3JtqfSX7C+v6F4c+IPiC41rXLTQEk0aaCC4u32DexUcc8 kdcdeK9g8J6f4U+HHhTR/Bnijxlpk9xrXixNRe50jUPMPkImFdpU5jJfA5Oefxr4RgjfzNq5Le1K 7SLIQRhgfSsnC7bRR+mOpWq6b8N/iAdQ0Pwz4be+khtLb+y70Sz3cTTgCSX52HOeOc53ZrF8WeMN U1L9urwn4Zh1e4/sTTbQO1nFMRFn7O7tuAODnC9fQV+c9xdy+WNzttxwM02z1S9sbqO6trqaC5X7 s0chVxxjqDnpUql0uLqfpFqGpK3wx8MaT4au7LTviLf6de32gTXajkSXDNJHAScJMy42sR2OMV5H +zl4s1nwD4L12DXdB8R6Suo6r5cnjDRLdJruGcH54p1cFtgI3EAc5NfHreJNY+1WUzajeGaxwbSQ zNmDByPL5+XB54711/hj42ePPB95fXmieKtT0+5vpPNu5Irg5uH/ALz5+8eTyfWhwaVhnpH7ZFv4 mXVvC0niLVbDxLDPYNNYa9b2Zt7m8hLnidTggoeACBxXHfsp/D3SviN8bvDej6zAt7przNJPasSB IiIznJHbgfnXFeNvHfiD4ha0+reI9VuNW1F1Cma4bJwBgADoBj0pPBPjHU/APiKw17Qb2Sx1Wzfe ky9B2II/iBHBHcHFEovlSBaH2z48174Qat4d8Yadqes+D9RWGzuBY2mk+GpbG+huFz5Q87GCARg9 Aa53S/gf4H1rwn4Z+L19oD6X4V0nSlGo+F47VjLqE8fyiUEEZjkYgtIeBj8a8M8UftYeMvEWi3ml vZeHtOS8wl1daVpUdvLcRg5KMwHKk4yPanW/7XnjFPiRP4wuILC6mm046Y2lsrrZ+T5ewAR7u33s dM84rPlaQH0F4417wFoPwN+Eul6/4JfxCuqm4urDTRetbRWqyzHksvzMwBUDjGAayNU/ZB8H2fxn 8Q6dBoGua3pVtY295Fplndx20MMkwJMb3crDG0cqOS34V88+Mv2g9S8cXXgSS60q0t4PCdvHbW8M LttnCOGy+ehOO1eral+2pYeNNS8VxeLPB8l34f15rWZ7HT7/AMmWKSFQq/vSp3KcZxgUmrbAdj4m /Yf8IR6sJydV8P6efDt3q8umPdRXM1vLCQqgzAFWViQeB+NeLfDn9mO08d/BPWPG7642n3tvqsWm WltIqi3feyLvdzyAN/b0r1Fv21vDN/fx2D+ELzSfCreHpNAlt7G4V7iFGYtviLfL6A7s9KyfEH7R nwoh+DVp8OfDvhnxDFpX9qRXl8b24jV7mMHMh8xWJVzxjC4GKXRXFqYXxK/ZT8F/D+11DTbj4gXF l4ssrQ3KwappptrG9ZQNy285Pz5yQvHOK09L/Zr+Gkn7Mc/jG58Zwx6zcXipFqc9rOkUDrHue18s Z3En+PGK1PGf7Qvw2j+E3iHw1BrGv+OI7yPZpOm69Yqr6U2cq4udxZgmANuQDXDW/wASPCPib9lO 28FXHiBdA17SNSm1E2txbSSLqJYYVUZBhSOnzelQt0Vc5T4d/szax488LS+JrrXNG8K+HfPNrBqW tztHHczAZKIFVjwOckAVZm/ZB8ep4wv9CVNPFtZW8d5LrVxdCLT/ACJB+6k81sYDdACATXufwb+N li37P2g+F/D3jjw74K1/T72Z74eKYVeK4RuVMeUcH3JweK0bn4gWfxe8I/FHwr/wsHRdV8S6hLYQ QahfhNLtZrWE/MIwTjAbOMdRg1C13Bs8X+NP7Odl8F/gj4V1TU1ZvF+o6hcJNLBciS2kt1AMbR44 IIOdw65r55j+eaMerYr6o/ayuNLs/Afwj8D6V4l0/wAQy6bYyLcXNnOJIxK8mOTngDpz2FeP/Fj4 G6p8FfE2j6bqmq6Xqst9brdo+lXBlRFJI2scDB4rejT9pOnDq7fmLXUpW42qF6YGKsJwarKMCpol OeelfuDhZWOa7LcbbenI6VajY7aqxDdx1q0q7VxXHOJSJo2+XFPVveov4R2p69B6VyOJRKGJpN2P amghevFNZsfSsJRAczAmjJUYpGG0Kegbkc0nvjNZOICEk5zmmNnpUjGombcamzAifIaopPm6VMe4 4JqFuCcmpFYjDDvRQuOeRRXNJLmGedeGT++kz/drqFO4c1zHh9w11jOcKR0rpd4Kg+npU5D72CXq y57k6t8vXNTxNVVGHpip4/lavp0iC0rZIxUyt0xVaNj1/KpQearlYFlWPtUob8arLnHJ71IrY69P WnygW1kxin7/AMqqh6eG54oUALStnnrUgbc3XjrVXd0p6sBzmq5ALQfk5OaXdt7VXV6l4b2FaqJL 2Jty9xmnAI38C4I/u5qHP/1qkVgR71fs1LdEEptoXUbo0P4CkbT7U9YE/KgNn2p247qiWFpSXvQT +SHzMYuj2Tf8sAB7E07+w7L+4w+jVOr1KrDINZyy7CS+KlH7kHMyunhu0YAb5B+NE3heHfxM/p0B xWgsm3Bx05qR5hk8ZJ71zyyXAS3pIOZmbDoMkaER3ciZ7Dip9P0rUNKuhcWWqS2VxgjzYWZGweoy DVxXxjnmplkzwRWL4ey9/wDLu3zY/aMx5PDt3PI8jzrK7cs7sSSfUmuh8HeJ/GPw/wDO/wCEd1u5 0oTMryrazFRIVzt3DvjJ6+tRiToKepO4YrnlwzgJdGvmL2rNq++LPxI1DX9P1y68Q3lzqennNtIz rtjz1GwDaQe+Rz3q/r3x7+JGuz6ZLJeJbHT7gXcKafbRwKZR0dggG44457E1zgcgdMVLu2jPUelc 8uFcJupSX3f5B7RnU69+0X4y1jQ9V0yDR9H0Qaqnl6hdaXp4hmuVOcqzZPXJz9TXOaf8Ur61+Gt1 4J1LQrbVrHzXuLG4nDpLYSsMM6FSA2fRs1Ep+bnGPQ04c8ViuEqMtVVa+SLVQ84uI3Xkow/CvWPg 78WvCfgexWLXNA1FNSt7j7Ra63oN39nuxkEFH3ZVl9OKoSKm3BQdPSqUkMUnBjXHptFZ/wCp9/hr fh/wSvaHstr+1d4d17VvGNvqVpq/hrS9c+zGPUdEkU3yNBwGkJIBZx94irXhX9pXwR4Y8Ra/Ktz4 n1G0m0JtOgvNWl+0zTTk5Lbd37pe2AT0zXhv9n23eCIsP9gVDJpNg2d1tHk+2Kl8G1/s1V+I/aI5 jwv4wvfC2vadfQTy+XaXUd15CysqsVYHseuOM+9fRv7Tnxm8K694Nj0XwXqH2r+39QOsarNFuiEb 7VH2dgVXcAeec9K8Vk8PaYyZ+ygH1UmqjeF9PaQkxuo9nOaylwfjb3jKL+b/AMh+0jazPofRPCOl Wf7Leu+Gbfx34UudVvbyPUgseohMRooJjIZQd+RjGMe9WPGnhO4+KWn/AA78Q+E/GekaNpuh6Bb2 txfz6iIJrOaLcXJQHfkcdBz2r5yXwdZzMVWSRD15YVUbwnbLuCyOAc8VyvhLMo9E/mHtEfZ3g/UL rxB8EPBcPh/w3D8SLu1e6W/eHV2s5YJTKSWyGVjuyDyKjsfGXivVviH42hPhzz7IR2FlqEPhPVvN 1GzZF+WSN1AZwuSHXHUAZr40j8MzWqBbbUp4Rjnb8v8AI0aXpus6HdNdabrU9jckYM1vK8bkHnkg 5Nc0uF8yjf8Ad3+a/wAxc63PbvjF4f8AF9v+0D4BsbfxDHq+s+VbPpV1rMCRXEOXLKl4MZLg5+9k 4xXmH7Wt54xk+LlzD45l02XWoLWKMPpI/cmPBK++eTnPNcrqmj61qt897d6k13ductPNKzSMexLH msi88I6pdSedPIsxb7zNLub9az/sHMI70n9w+ZdzS+DOltqPxV8KWhA3S6nbKAfeRa+j/wBqHx54 UtfGHi+LTdc8b2HilLlovKgu1XTi4wCMBgwUgV8waFa6/wCEddstV0omO9sZ1uLaddp2upyrYPHU dDXqviP9pr4keI9NvLTVdH0G9N3G0clxJo0BlO4YLBscN79q5pZTjozu6MvuYc0e56l4i1b4Y/CT Qfhfp/iDwDpepnXdGt7vV9UmjZp443zl0C9ZPmJznsPSqOpeHfgv8M/hR4T8R33gybxKviC/vFt5 bi8khYWqzEK7hT95U24AHds184/EXx14o+JcmivrFoo/sjT4tMtlt4SgEMf3c+repqx4y+JmueNf Afg/wrd6clrY+GYZYoJIlbdLvbcS+eM9uKwll+Ip254SXfRhfsfT/gvRfAfgHwj8XvHvw++z61Hp i26aNqF/bCQ2zSH541WQc4yBkjOK5DQJPDn7V19Z3PiDTn0S98NaTc6h4g1LS4I4mv4kcbEjQYVW wT8xFedfBv44w/D7wnr3hHxF4cbxH4T1llkuLWOdraZZFIwwcA5HA49q7rSf2r/D1jrj6evgs2Hg iTRH0L7LaTj7asLNuZ/NIwzbvUdK4/Y1I3vFjHXX7J/hn4l6T4U1n4a6vqVtp+salJpjx+IkTzEZ FLmQeWMFQFIxXefDn4B/DrwanxKOl+IP+Er1bR9GurG7sdS05U+zzHAEkROcjcrDPUZFcjov7W3h L4dXHgvS/CXhrUn8MaJfTXs/9pXCm5kaVWVtu35flDEjPXFasPx5+EXhXSvH15oM3iHUdf8AFI8x /wC0LZI41zKHMQ2scDlju5rOUZ7MZzN1+wpPHB9gPi+3PjAWhuv7E+wTeVnZv2C5xs+739eK82+E P7PGr/FuPxA9jqek6d/ZEe6ZNRnMbOcEkIADnG08njkV9JeOP2lvDniGLVNf074r6/pcVxZbYfCd lYhXjm8sKF81wV27skkYzzivnj4Wan8LYfDPic+N01l/EckbnS5LFiIt204DYPXdjOeMULmadwPG NRt/IkZcglSRxXcfBX4L6j8XdWvYYry30rSdNh+16lql02I7WHPLEdWPoBXG3hWRyQOvrX0R+yb4 i0lvD/xB8GTajb6VrfiTT1t9OuLxgkBZSSY2f+EnPGeKqYHM+M/2Yn/sfSda+HerN4+0TULr+zvM ht/Iniu+cRtGSSNw5BzXltr8LfEl/e6nbW2i3s8ultsvljhJ+zHfs/eEcL83HNfZnhfQrvwj4H8K fCjS/E2m2nxAn1065NNaXIeKxjSMkb5B8pfAztGc5rq/E2s6J4z8N3OofD69s9J0ybxBb2Xi+/EA tprotIoWVWbIWMtuO3sTmsnJ7CPmtf2JfErTR6W3iTwxF4oMQk/4RuS/23oJXcE27cFsehx71xXh H9l74heOm1MaXopjGnytbStdyLAGmGcxIWI3vwflFff2ki/uv2jNU+1eBILGys4ZDB42mtpVuJAk QUN5jHy2PvjBrzrxZp2reONP+CKeHWudUsRqc9xf3lkfkSXz97mTb91gu4nOOM1CkwPh7wp8H/GP jTxHcaDoug3d7q1tu8+3Vdph2nB3lsBefU1ka74H1rw74guNC1PTri11eGTyXs5EPmb/AEx3/Cvv z9ozWHvPhR4wu/CT/aLjVfGP2e4uNJO5mREVVVynJBYcA9TXoGraZYWOvaZqt3a2954m8PeBJL1r mWNXuVucKqM2Ru3DDYz0zT7Bc/LzxZ8PfEHgm8jtPEGj3ui3UqCVIb6FomZD0YA9qzb/AMNalpEE E99YXVtBcLuhkmhZFkHqpI5H0r9G/gv4dg+LXw2+HV147t/+Eju5fEF5PHNqS73FvHG7smepQuAc HiuP0TVp/jr8Jfi/L4wZdV0/SL+JNEQoE+wuzFFEW0Dau0KNvShK4XPgMq+0siHaOpA4FQvIdoJ4 PY5r9KNN0fSfC3xv0f4HaZomnr4Iu9FMmswSQh5riRofMaVpT829cDHTGa4SPwx4a+Ba/DbRNH8K 6brt745uSdSuNaiE8n2ZpvLSKPI/dja2dyjOR1rK2jfYNz4NLNuzt61c0+9NrdxyPukCDpmvtfXv 2c/h/wDB2z+Ivjy70+TxRYaBq407TNEvnC27SNt5lI5cKW+7xkCotS/Zr8HePtS8O+NWt28M6Hfe GpfEmraHpoAVfJIUpCzfcEh55zt5q6c5UqinDdPT5MNGfJ0fiaFsfunHryKtw+JLViSyyKPpX0NL +z74b+O3hvwX4j8C6avgeTVtYk0KfTZpXnhLIpk89WJLfd4I9RxQ3wB+HHib/hMvCHhN9XTxb4Vt JL2XWNSkH2a98o4mTy1/1fJG05Oe9fRLiLHaXafy+QuVXPBofEFm3R2X6irsOtWkmB5mT9DXs2h/ steGo7rR/B2ta9fR/EnX7EX2n21rEDY2wZN8Uc7EbizAHlcBe9c5of7Pum6H4ft9f+I3iJvCulXl xJa2CWNuLu4uXRyjvjcAsakHknJ7Cn/rHi95Ri/v/wAxcqOGXUrU4HnoB6E1NHdwScLKn/fVd1ef ss69Z+NNS064vrW18Pafbx6hN4kmbFstm/McuOpLDog5J4rN8T/s66/p/iXRtP8ADzL4p07WoftG mapZrsinjH32bJ/d7D97ceO9P/WKt1pr8SuU5hp4ycB1P0NNZu2c10Pjv4Baz4L8Px65a6rpfibS xIYbq50SZpUtJR/BJlQRzxkcGo7r9n/xvpvgl/E9zYpDapGs72RmH2xIW4WZofvLGT0Y0/8AWJ/a pfj/AMAXKYi54qRm/E1v+GP2d/iN4q0OHVtO0hmtLhd8Imu4oZJV/vKjsGIPYgYNctBYX2mzXNrq EUsF3DIUkimGGRh1Fehg82jjans1BoTjYmZtwpm7v1oZutMZsivdsyBGYdutQnliT1p+4A1Ex/8A 11NhjGYZ64opjce9Fc8lrsLU858OyYvSOp25rqkzwetcdoMm2+XjGQcV1qsdtc3DrvhGvN/oaSZZ VualEnbFQR+/WpF6+9fXIzLStjjtUyt7ZqurcDFSK2e+KpK4y0rBafuyOelQK3HWnbqvlQFlHHzZ GTjj2pVfvVdW45p27jI5p8orloMcehpysGyT1qtu6ZNPX5fpVqIXRZWTjHenq2ODzVYSe1KrDvWi iZlsSfN7Gnh8NVXeeaekh4ya1USblxWP3s0/ee3Sqat6cGplk+Uc1ooDLqsWA9alSTa2OtVY2+mK f5gFWogXPMHGTmn7stVZWBNSqw4Ga05CdyyDtHPNSqy4ODVZWDY7CpVYM2OlVyklpG+UVPHllyRx VRGyAKsw724AJP8AdA5oce4XJlYY65p64zjvUC+p/KpE+ZhnrRyCJ/5U4Nx61Hv/ABppbHPenGPQ pMfNIZB6VCcBSRz65pskmeOhPoKi8xRwc12U6aiVdE0fLEbsDGeaRpBtIHWoPMUdM0PJuxgV1KAE of5TzSK5kHPUdO1Vmky/FSxyFuDzWqhoLmJHyufbrTWY9+fTinq+7vTSwyeKfKhNixltuDgZ596Z vCsVxzjrSFtuCOmac+D3pcorjdm5Tu6ConQj+Kng7eAM0rfMozxT5REX+rxuG4fyqN1+b3xxUqru /wBrFS/I0ZGMPu4PtirsNFVY8rkDNSxx8DgCnL6DmnBSe3PalYQnkrkAhT9RUbWcD4/dI3/ARVkL yOKcVKiuedOL3RabsZsukWbAg28Wf9wVXk8P2DH/AI9Y/TpitWTczEnknnJpNtccsJQl8UF9yFzM x28Mad/z7rn2JqtJ4SsG+7G6/RjW+F+bHf1pGj3f41wyyzBSfvUY/ch8zOZbwRaTMTvkT/gVMbwH brwJ5PyGK6xEyvNL5eCBiuGWSZdLeig52cj/AMIa0eDFdsjDocc/zpn/AAi99bxvHFfsqSEF0UsF YjpkZ5rsvLDKBUZi/KuaXDuWy/5d2+b/AMylNmPda545k0mTS38V6pLpzLsa0e+lMRX0Kk4x7VT0 fxJ478K6LqGj6Pr15YaXqAIubS3uCqS5GDkfSt2SIGqzx+lckuF8ul0a+ZXOzK8A/EL4gfCW4vZf C+pSacbsATqAkiORyGKuCMjsetZ2g/Ejx94T8eJ4wtL+7l14OzSXFy3m+cCMMkgJ+ZSOMHituZfQ VRkjLL0rF8IYJrScl93+RXOyzr37QXxN8QeNtI8Ri7ksr7SSPsFpp8Pk21uAOVSJeMEdR3zS/Ez9 p7xr4601dKg0+z8I6YZjdXNnocDQLc3BbcZJCSSTnt0FZrRlTkH/APXVSbLZzz61zS4NoX92q18k HtPI7u5/bS15dDW5HhyxX4gGzGmyeMmyblrcAj7mNokIO0v1IFL4d/a8tLfw/wCHpfE/hFPEfjHw ujR6HrEk5jiiXOUE0QHzlDypBHvXnLKn93PccVDLDHPITIiuzck4GTXFLgyytGt+H/BHznpXhP8A aqtPFHh3xD4S+Kltd6p4f1q8Op/bdHRI7q3u853AEhWQ8jB6cYroNL/a+0rUfFV5o+paRJpPw9ud DPhqFbNjLd2dqDlZQT9992Cw4yOBXh39l2jNhreMD/cGaik0Wy3cWyc+1cM+EMQneNVfc/UOddT6 B0L9q7wx8KdY8DaF4S0261jwn4auprqW/v8A91c3k0yFXkVBwgUE7VOfc1NdfFD4d/CuHx1rPhjx FdeMtX8ZwPbJAbZrYWEDsHcysw5kJyAF4wOtfO/9gWbHmLH/AAI0L4csm5CuPo1cNThXGR2lF/N/ 5D51ufXl18WvAcHxGsfjX/wk0Exi0hLW18JohN9DdCExbG7CMfe3984xWFrzad+0N8M/AkeleItI 0ZPDqSRava6xdrBLEWcu8yqTmRTnouTXzL/wjdtjO+QCn/8ACMxNgLMw7cgVwS4bzCP2U/mVzI+z dY+IWj/HbRfiV4V8E3SzaxeQ6dbafb3WIPtVrarhyhJxndk7Tjjn2rS8KeKdD06bTPh7pmq2uo+J tI8HXmlRR27gxTahM+6SJJDwxxn6ngV8SR+H5I2DR3TRsP4gMH+dLHot3DOJ4bspOrbhIrFWB9QR zXHLJMwg7+y2815efkPmTPq/4Y6bF8IfhXd6L42lh8O614k12wAsrxwsy2scoLu6dUX/AHsVuXVv qWk/Fz41eM9Yt5LLTZNPubDTZLogRXMswVYkj5+fK8jGetfG2o2uqardG4vbx724IwZriVnfjpye a09W8TeLdYtdNtdQ1u9v7fTAFs4p7lnWADGAoPToK5XlmNh/y6fcrmR7nrWoW/we1jQrz4hSah4t 8b6Xbwiz022mENvpkSDdEkj7T5h5GVHAHcmvJvFvjS7+IHibU/EV+kcN1qM7TvHCMIuew9q31/ab +Lv2U29x4mkvYSNuLu3gmOMYxlkJrhFZ3XdK26RiWbgAZPJr3sjwlWlVlKpBrTqiJMexyPSolOc+ tKW3KT0qJmwcV9nymem4pbGT3qJmP0odyG46VG0n94VHKFxCxFFJu9Bn8aK55XTsXdnmmijytQjD DJJ9a69Olcdo/F/Dg98V18fy45xXk8NP/Zprz/RDkiZW7mp15UVVXlqnjbFfaEFiNhtyTUitUCt3 FSK3XBwa0WgrkysKdu61ArY+tPVs1aVybk6kY60u72qNWGcZOKUdflNapXETBsYzUoY/WoAfl55N Lu6itBFjOBmnBsmq6yE4Bp4Y9vlrRRAsBhjrTw3AAqupxT0l59a1URaFldvHzc1IrfKKqn5WxkN7 r0qRW6AHmtVEhlyOT3xUsbk4qkrHPJ4qZX44rXlY7l3aYyQeCODT45O559KrCX5cVJGwOMVooiZc ifjIqdD3zniqSPgdc1OrYxVcoi3G3PPTtViJvmzk/WqatuarUbY4zScLgWFw3GalXgjHSq6tjn8q l3ce9PlGPZvSmMxxzRuqNicEdK2jC2iEJndwD9Sahkb5evT9aWQ4+lQtw2DXXGNtQHp65+lKztnB HXvUJYdetM3fMecfWuiMQJt554qRG3YwKj4YAfhUkUe1uO1VawEir05zU6hcDI470yPCkA8qfSpf usQoIUjv1qWgGnYFIGdvUe1RMoP0+tTSLs6jDUzbmhRAYIsgljgdhRgdhxUvl556GlEOOetUBCv7 vcAoO7g5GaQQ55xU+0lh29qkCbcE0gINm7HGGHpRt/i5yatRR5bkY9KHjC4/SpYEKpgZI5oboARU jZ6EcCmlhWTiBCymkEeOKczHB7/0pyrkg9ayaFdAI+/FJ5PzZB4qTgcUobpxWLQyNVwDml8v2qXb z04pdo/KswIfL4GKYy9qsN0AqGT73rxU8oytIh2mqzRFe2TV1toU1Wly3U/hS5TQoTR5aqc68Vfk wc54NUph19KsDOnXoapyKNp7H6VdmHrVKX72Ogq+UCqw45qI7W47ip5MdutQY29BzUuIpCN2JFM5 J9qcQTkmnbPlyDzWMkQKvzdf0qVFC8Co1HtzUsZ56e1cU0PmJU/zipAexHSos8jJzjoO1Sq52lMD BrkkikPLfLjNOVsetRDgdcUFj05HpXO0Mfux0PNN3d6bvz14pjMaxcbgSbuT7Uwtk01WGfb0prvl s1i4hcGYjpUZk46UrN2zUbOB2zWbiIR5fWmO34U2o2YBjms3DsUBfng0VERuORk0UvZpged6e3k3 0AK4IYZFdkrK2M9a4izbbcwkjqwrtU9D2r5Thj+FUXn+h0VCRTzjoKk9OTimL19venY249K+6juY 7osb/lApwbr6VCvc05VPUCtUQTK3OQM1IDVcZHXipBWqQEw4xjk1Jk/SolbHNBPfvWkUBPuxwR+V OV88dDUO4nr+dKrd+hrVICxu6Ubju5FRh+eeafuz1rZICb+HIOM+9Ckg8H8aiDVIGx0NaxiRIlEn Jp6sePWoVPenq/txXRGPQksqTke9So3qeBVVG9+lSxsc5rRRAsq+7npU0b8jA4qsvzD2qaM45rVR Asq25uDVlJOnfiqcJw2amRj2570+UC5GfrViF+nb2qnHlqsJ3HpS5UBcViwzUqt/+uqytuPBzU27 GOhz70+UBxbdUcjdqNw7Uwvye3tWqQCM3QAnimFd3U5NKuG7nml3dRjJrpigI9uM+vWmhdrcjg1I wHXPOaGet0gFT5fr2xVmPDMxbknue1V1XueTV6IcZIxQ13ARowOnB71IoJ4xmhlDdaeqlV6jFQA3 btwD+HFIyD8aduB4pSvpxVoA2+uCOtHDNzwvtS9VI5xjvTliyQd2TS0WoBHGvPNOc7j/AEpdu0e1 MfOOagB6thfbPXFQzS8c5/nT1bsTUbdf5UhDFJbAwSKe2CuAMY96bywzzS/hnFJonmEj47Aj3o+7 3peepp34ZrJq4bjVX160/byCDkULQfTNZtDQ5cikGPpR0GO9NZuoHHvWTiUJ/KmN70biGIPSkdu/ ap5QIJc89sVXk+7U0jd6qzMdwGePalygV5Mc8kVTmO2rU0mcjrVOZhyelNI1RTmX5icVSmz1zVqV s5HOKqScj1q7MTdiA8ds1G3X0P5VK2cUzbuB7c1EiG7jGA6Uix46dKdt+bBpB3rGQDlXB5HHpTtw 3ZxtFIo+XOc0p7dxXHJAO5bkU8NlQBz6Go27Y7UbuOK5ZoCTd82aCe/X60zhue/pTQ554rDlKUu5 JuG6hlbyy207c43Y4qFmJxSM3GMk1i4g2O3Go2YenNDTErtPT8KjZunftUNED920k43VC3NLuPPO DTN4XOOc/pWbiO41mI4PAqKRqdI55qFm7dqOQLhuUdTg0VC7ZPA6UUciC7PPrX/XR54wwruo13c1 wsDbZFz613ds4CL34r4Dhl6VV6fqdkvMfjGQKXkdRS47gcU9VyOK+9iyBFwOfWpMnimbTnHanqOP euiJmOXvnrUi8r1pqAdzkmpFraIhT2o60YNG30rWIC8fj2oX5m60DHejt1raJDY9W+Y80/8AhzUQ xxnmnZ9+K2iJaEintUg98+1Qhjt46U9W/GumMR6tkw+XjNKrcg1EGI9qkVh17Vuokk2cdO9SLIRg 8+9QL9cU/d0x1rdRAtK3ocVNHL6GqatySamjPQDirUQLqtyM81PGffFU4yVx61OjfMT39KrlAvRM PxqxG2BiqatnAHFWFP4YpcoFxZBtAxin7tuAe9VkkHepdx+tPlYDpGA4xzTN3XFMYjPTmmbuCBWs YgT56c4obGTgfjUG4il3dhXSogTlRtAPPem4yOlM3BuOnrTwxbBH41qo9RE0aH2NX4lyOTVW3wMe tXY12/SoluMVYx3pGUcAU/pUbHLVIBx1xk0v3mA6+1AXn/ClHXjp3p2YDxnbnvQqnkDI9cUisdxI 6ZqVW9O3epYCSY44x2qvJuYcVZly3zY3c/eqBmbbtLHH90VKAYrAg8YpWyevFJ3Jo3evQVVib6Dl bbyDn3pOMnBzThGphLGRQwYAR87u/P04/Wotx6fyrMlMXaeMVIq7eO3c0i8qPWpVIAct1xwPWoki kupHtP4UoH5dqGy30obGPeosMjY8570wtQcZzSMC+TU8oxrP2zUbnuOaGOKZKwCrg896XKBFIx6V Wkz3qWY/LVYvjrijlL0IJm46dapzN1I6VZmY9gcVRlO0+9LlGyvMc1Wk6VLJl2wPWoJs8+1DViPU Yynk9h780zdk9KVmI680xvTODmspIduqBj0xilX1xmom4brnntTixJrCSJH7zz60uc/Wol5705cb sDmueUR6sfgntijaeKRpBSM25STxXJKIh3TqaViu081Gp980D5uc/gTWLQBTH69aVmy3X2pjtyB+ NZNXARm7dPemFsdqcfu9KjLZJ/Ws2gD73Womb04pWbcq+wxxUMjHoKmwDmbGT1qFmI56e9OZxt96 jL9eM8d6XKAzdzzRUTEsetFKxXKziRGVYEH3rurNM26MeflGa41IdrDFdnZL/o8ff5RX5jw3P95U XkjtkT46c0uzPvShflwelSKvHNfoEZGQjL07UoBBqRQMcinAA5Oa6osUtiMLge9OVT0xQv5inbWx 7VtEzGnO0880c0qqdwpT3FdCExMEjNJ3wad06Ck4I9K6IiSsAOKcANw9KOPb60gw2Qa2irhbuP6Z 7jtTk9DTFHHv70obv0rriStCbtntQrEdKi3e9LvK4reIiyPWlVxx7elQbu/3aUN3UZrcC1uzU0f3 ulVUbv2qeOTaM1qBcjbJxnAq0nBwO9UI5NvX161ajky2aAL1uCzBcgZ/iPQVOpIY5OaqRsBnvU6s WXjimBZVhtOQMdqd5gUDFQbsAUhbPXpVqIEjN2zyaj8w/wB79KRn9fSmMw6/pWyQE28dqcrdABxU SZ27RjaTnpzSr7dK6IruIm3DJqaNdvJ59qhGOO1SqcqDnmtRX1LEbcZ6Grkcg7/lVCNvXrVhOfas pLqUXBJ2IzSbtv8A9aoFbOfUVJ14rPlAlUHAPf0p3vmo1k4AAp6tngcc0AODdRmjds5pm4qenFBb PXpStcEOZi31qJjtalZtvQU1mIbpSsA7dTDluQKRiOnWjk0jNi7ivPGTQHG4EdaAvBJ4pm4c0gJt 2080/llz1qLcOMDntT2b5V2nnHIqGjQXleg5prDbyRR5nUU12+UDNKwCblZfSoioZsFtg9etIzDn NRs3PBpND2CRgpyDuweOKhdmyc0rPyahYnHFFg9RsjfLVZ3A4NSM3XJqrI/4ik4l3QyWZt2Q2D6m qcnfnJ71JI2W981BNhTwagZWlJyD3z+VV3kBzuzjFWC+GBCg45571VmbcxJG3PPHSkZDNwPGeKY2 GbgkU3NN8z27VDQwbjGP0pVY4x1pm7jGeaUnHTpXO0If/OnLjr3qMtlaFbmuaSHcdu655xS8c5Pa mZC5pPvVzSXQQ8tnoOKa5O73pDnGBzTdx6GudrsAMSvWm7i3NJuyDmmlvl9DWTQAXJ9qazDpSN8v Oc0zPeswFZtv0qFmJPFPfrjpiopHPrS5SraCMx6dDUTEg8GnbvXnFQs3NTYkOdxwaKbuPaikVzHN rHnpn3rq9O/eWsRJ5xzXLjC5Oa6jS2/0GIgdq/JOHXavNeX6ndU2LqgnH9Km2/mOxqFW6VMuOp61 +hoyHKtLgelGRTxyK6IsRGycUZ3e/FKzY+lIGCrxzXZFmbFC96T2Apd3rxRwK6IiGY2nFJuHHY0p xn2qNvlPWumJOzHZGcdSKUErUZz1A5pVaumIIkLZ9qUt0Heo/XJwPem7s+2K6okE27mnjJIwagHN SKx989q6EBPu9fypVYVHu5PPNL7it47gWFOVBzUkfzfSqysDU0eBzmtBFyNueORVqNg3TrVKPj6d qsxnb0NAy7C3WrKt7c+1UlbHWpQ+1TiqsBYLe1J5mOlQiQ+uKUyVrECbzMYJ4pm7cc4qLeG5/Sgy EcCtogWN3cVJG21fbvUANPyO341rGxOzLCtwD1FSq3T3qvG3QVYXjkitR2uSjcMHvVhTgAfnVcNu Uc1IrbcZHFST1sWVbANKr/jUasaVc/SsSyxuPI6mnVGvQU5WPA6UAP3c80N9z3+lN4Gc5pS5x7Ug E5288mm87uTSrj1+opGb5fbvTEI3yn29qaueg/Cl3EKwHAPB96TfgcDnsaixMhWJ49abwM9c0m7g 8U3cR1p8pS2JFb5f8adu28/hUORt6UbvX8KVhkjNnOOPSmM2T6UhZdvvUTSevAqQCSTnk1GzfL6U yVsnimbjtNK3UBWb8aiabapXpTif3ZY8DNV2bLE5pND9Rsj7qrSNtJ4OKc0nXr+VQyMe547VBehF I26q0jGpWbb93jmq8rfe3dKCWyGRvmOORUMhz05pXk2ngVH/ABEkjHWs5EjZmC8jjPWod2cmnyN1 BH496gZ9vGeKiWwD+MAnrT/uqOhB5GDUBPccU7cFXPU1zyAeX/On7uxxUG7nPWntxyDXNIB7EU36 1GScc05ZNq4xn61zyAX3pvmU0tjOabvFYMBGYims272oZs+9RllAFYvQBxfGRjNRs3ShmJUmos56 1kwHMx9cimvjbuz83pTW6dahbhcGkMRpNtNZ/wAajZvmpG96dhrUXzMUVCxOfWipJM4KOPSul0v/ AI8kHpxXNBsj+ldFo7FrVOeM1+M5BK2Ja8v8jvm7ov8AGafuK4yPrTOnAp6ncvTiv0aLMHpsPyWH NKrdOM+1Rrt6UoPvXVEVyQ4cnAwBTfumm7vfFM3g49a7IEkzEe+aY0h6Cmbjg5ppI9K6ogPLUjMO OMVGZPWmeZnHNdUUZslyfxpATuznFMB+bJPFIzAD3rqiIl3H0waTduqLdnjvTieldEdgHq1Sqx4y cCoBhu9O5210xAn3ggZ/OnBz3ORUGe1Oj+tarci9i0rDsM1KjH0wKqqx2nFSxtitB3L0TDGQMVYV jnr161RjzjFWY2Pc0yi6rdMVMsh6HrVRW3DOaduweKtAWN23PelV+hNVy4/CgMRxnPpWyVgJ/M7i m7/m9qZux1IFKvUc1sgLUcnFSpgZ5981VjIZvap87eD+dMCyjdOOKsI2eKqIwqYN0IouItKB3qRC d3Tmqyvn2NTLJ1H50XYn3LCsNwANP5DYPFVgfxqRWAPNIZYDdOQak37eMVXyBjBo3cYzQK/cn3HN G45wKiDGjeeOffFBRLk/rSN93rmmbyw9OKaxAoAR2PA7UokPPeoGct17Upbj39KYibfn6UhbPeox JnHOKTcB3pASq3HPHpTd+cA9KYcNmkZgOc0nsMkYDscetQykq2DxTN43c5A+tRu3NRYAZ8YGaYzZ zUcjc01mGMk8+lIBWbdkVAz+tO3npnNQyE+nNADJMZNQvJ1Bp0nzNk/XrUEjg896AIWbOewqvJJ2 zx70+ZzuPNVpAWqeUBJmMeBVczg5zmiRiTjP0qvJJtPvUuIEskuVz+lQFxTd9NZtoBPAIrJoCXcM Z6+lN3YznnNQ7+AOopfvHk8VhJATo+0A9T705m3ZY1B056j1o3Ht0rlkgJj0JHSm7tv1pjMex470 0sK5pbAPZunrSbhu68VH5nvSbvlNYSAczDHoai3ZYjpSNjaSaaW7ZrB7gOz701vTNN985prPyTUM BCQO9Mkf35prN1FR7vxNZjEzzjoaOg5NM6t1pGbHegBwPviioJJDu46fWig0M3dnOOldFocg+xgY zg9a5ePB46f1roNIlH2coDhQeDzzX4rkjti0vJnXJaGx5lPWTtnIqrHJt6805ZQM56elfpCMSwzY 6c00TbWHaqzSHGRyKXzBuGBxXbBWMy2s+FPQn3FMaQbjVdn6kGmtMTXXFCLDS9PWmMxPtUO4NjNB l7d67IisS7jt5PFMaT2qIye5xTQ3INdMSH2LHmZ4pGYcVD5mOccUbstnNdUEIm37jz2pdw781XVu TShucZrqihFqNsGnbveoA2MU4c8961W4yzkFQM5p69vSqq/XipR0yDmtUK1yfJUdeKmT7vXNQRuv brU6f5xWgyzG3yVOpPGKqodoqZXHUUAW1YLipFbPPWqYk3fSpfMO3rxWqAsMwXrQslVfMLdKerHt xWwFoNnjr2pV5qBXx1FP3jpVp9ALMbFV4ODVhW3AVQDndkdamWY+9UBcXjGDU27jmqaycehqVZqA LcbDOByRUm4t7VVRgz46E+3WpuVbB5xQL1LSt1zUiEt3/OqvmZxzgVOJNsfGCc5/+tQMn3Be+fSk WT5snkZ59arGUtzmnKxx70EvXQtSvGGPllivuKFkC81WZvfn0zShh60FFjzB0Peo2cq2KYzenSms 3OaABm754p+4MvrUG7kilVtvAqo7gT7uDxmml9wAzUW/bmk3DmhqwEpbaPSoy3zcmm7ty5zTWbcc ng1IAx3fzqIyFuRzQzHNQk8+lJ7AEjH8KjLZB55prvyajLH1rMB+49c1G2W5P6UhfANMZuKAGSEr VeT73pU8kv7sLtA5znvVV2PPrQBHK2fpVSRivUkCp52CE4O73qlLjrzQA12aNuTiq747mntJnr83 vUDNu+lTIAbqabwWwaYx3HjmkbP41jIBd3oKd/D15qPd2PHHalDbqwmMcrheDUit1xzUXAXk0qsF 7cVyyD1HdO+B6UbvxFMbqe9G7rk1zPYLDmI5xTCc9Ka1M3Felc8hDy1M498UhbaMimbi1YyAc+PW omyOlOZs/hUTNuwc81DAZuO054pm40pJNJWQDGbbx3prNnGaVsZNM60AIzegoqNsnviigvmRjmTv +netvQph9ncY+YNXNeZ0JOK19Dn+WQE856V+J5M7YyPzOuWx0Pm0hk3N19qp+cT3o80nHNfp0Uc5 eE3HJ49KUzZPuaorL8vBqWOXam7POehrtiiXctbRlSz7OM5POajMvfrVZpstx35pvmc9c11xEmi3 5hakaX3wag80UFvfiuiImyypDHqBSM2GI4OO4qDd+lIW2qMkk10xJJhJ8vvR5nqOKj3Dkjk0GTc3 JxXTF9AJd45pFbDcVFuP0FLuPPPB611REWN2OQacr9M1WMnQU9W6c81tFikWQwDZzUqt0P8AWqgb pUkbc89a0Fsi7HzzVq3kRWw2dpGMjrVCNsYHU1PG3tTLL+zKl1+aMHGcdKVTz+tVVk2nHapVk/Oq QFoEtinGQc/WqnnHv+lHmZ61tHYWjLayZ6c/SneYOneqXmdMcmniU/hW6BlxZSB1pyydutU92acj jd6jvWlgReWTBz3AqRZPw71SWT5vapUfd3qhl5ZOBzg1MjfnVFZOnNSLJz7UhF9ZMkHODU4fceTk 4qik2cdqnWbmgZb3EL1zT1kB2g9aqiX8qesh4IpX1sBbDdaN+37pyai84c84J4pu4ZwetMCz16d6 cG25B69KrKxY+9BkJz3pdQJ9244zxQW3ck81FvPBxTN5GcjHvTFbW5KZMHil8z5j+lVyfmpdwHQ0 DJ9wK5pvmc1C0nFIrdu9VfSwEzPweaarFuByfSmsu4Dn8Ki3FeetSAryHBHJK8YPaoGk75p00u7n HOKqvJ09fap1sA7zM0oPBNVg25jzQJip3K3PWoAkkkIX1qNnyB+VRs/BPXuKYH7UASHZtYsx3duO D9arSN6c0kjY/rTCwCtk89qQEch3Kfzqqxz05qWRht4NVS/4VNwGyNt6VCzndgdaWVvSq5zknrSd 9wBmKim7zjLd/WmbjzSZ4NZyAdnjil6VHu7dBSGTGOSKwkxXJtxbilyRwRUG/bjineYc84Fcshkv mYphY01m6+tNYnGM1zSYE24bRzz700N8xzjAqNmz0pM7q5pAKZMqR+VJmmlx0xSHGMk8/WsWAO3X NJJgKNv86a3Q5qI1DAczfKcVHvobOPambh071mA1mHam7hQ365pjcc96ABv3hyOKKYzHscUV206U ZRTaGcx5nc8VpaJIN0mOfWudkm659a0tDuAJJPpX4Hk7tjYHbLY6b7R6GkM3XJ4qmsx5pQ2Wziv1 WJzF5JRu4NSMzDvVDcMnripRcBto2gADHFdkQLRVvvclaarBhkHnNQLcOMqCdrdhQX28Y5710xRm XFU+WHIypOKHbAHeqyyNtAzx9aXdhsiuiIiwGPrT1bpVfduxilSQDJPXsB3roQE+4DnvTRITx1qH zNzUpYKeDk10wAs7h69KaGFRBuM+vNG4d66IgTq2c8c+9O3fjUCtjvT0Ytwa1As7umKljbpjpVUE r9aljb1NbAXFb5h61MsmMnvVNWG4Y61KsmMZpgW1k61Irde1Vlb86VWPTNWmKxZVvXrQGNQmT3pd 34VrFhbqTrJ+HanKwbv9ar76Fk6VsmD1LStz1p+7b0quueMelOV/yqg8i5GRj1FPDYUc1W3YwOxq RT61XMLZFpW6elTCT8Kp+YTjHFSLIafMPoXI344qdZBVFW4PNSoxXuDUt3GXhJu68U/zCoAzVFZK kEnvQBeWXPGOaes3zcnFUN5xmlWT5jVgaPnbaRZOv61U84sP0pVfbTAueZ7U0tu71X3+ppGkPrjN AEpk+Y85pd2BVTzMt1yaf5nvS6agT7j1NG7PFV/M/OkL+hpXAmWRuVHFMaYjv09KhaQrURlpPUCa Scmq7yfnTGkK9OlRl6QD92AcHik3BuKhZivFIxP1xSAk3HPqKjkPz8HjtUbyDPy8CmMx+p9qTdgF kY1A0hx7UO5zyaikkPHcVPMA1jk8nAqGZh03ZHr60SNu5qrI+DjrUgPeTt+lQM3Wms2KjZivvRcB 7EcntUbOORmmN7mms23tmsmwJcjgY5pF61CJPxpdwH41zyET7getBcc1CZNwA6UeYOnNc0hku89+ TSM38qbuLe9JnuO9c0gHZG0UlNUFmA6DPU03ca5nuBI7e4qNn4x0pCeuaZuGec4/rUMB24c5NIzY qPPvSM4bjpWbtsApYn6VFuxRmmFscVmANuY0xmpGfPHSmMwXpzQNClveiombng0V6VH4EVocM0mR 1q5o0h+0NzxisrNXdJbbcHHXGK/nvK/dxdN+Z1y2OkWQr0OKkExAGGqqGPc07OCMdK/WInMXFm3Z XtT1k2+9VA5wAO1Shvl5rsiBZWT1ODUnnBlzk57VX3ALkn8KcjFfpXRFhZFlSemacrZwOtVy2ena n7s+xreLI2LDbkIDcZGRQuUGT0JqAN0zk0b8966IskmaTDnA460JJyar7+vrUirwSfSumLSAl3Gn bumKi3elLnpXRFgT5p6yYquJOABTlcgYrZMC0shIqZG9Kqq3TFSB8VYFlWPapVk6VXjanhh1q0wL KydR2pyycZ7VX3YWk3H14q0wLnm85zSeaaq+YaesnetEQ99C75ny59qFbd9aqeZThIenetUUi55n bPtT45CvvVRXxjnJNPVuwq0DLqv6nFTCT5ev4VSDdM1L5hJ61Qywjn0/WpkkK9elVg2e/vUq84Pa lzAWVf0qVM9KqbwO9SJJhgQaoC39TxmneZu6VU8ws1S7uPagCdX9Ker/ADVXWT3p+4UAWfM5wad5 h2+uaqqx4OKeG/AUDSuWGb1qJpM96Qn5cZqNpO3ancB6SHd1qQt0NQRsO1I0m0tzQIm8w460jSfj UDSE49aN25sdqQE3mHaecmoHbtSNJjIHWoHY8jjNAEnmdqjZsLxUe4jjNRyNuXrQBI0nTnNDSHua r7ugpjSkVL1QFhm9OtM389eag83PWgN8pJPSoAczE1FJIBxmk8wZ5HPrVeR9zcUrgDyDJqu0gx05 olbd1qAv1J6UXQCsxPI61Czk9e1LuY5K9BUMkhZsk5NQ3cBWk+bNNdy3SomYihmIxis5APz2IoX7 vJ6VHuJo8zpxXPJgTrIKNwZqh3bWJpynvmueQE/mY4703djiombvnNOLblHP41yy3Ae8hYY9KYr7 mprE/Wk3VgArN3prNz1ppbPsaRmGR61mA4sF6VGfQcijcOaYZDkgDPHeodgDdjvxUeWYnApdxPBq Pzev5VAxzMOpqFvmORxQzde1RFjyahsqw7cMnIoqIzbeKK6IYhQiosWhwRfaeuKu6TIftAA5FZu/ d7mrelsVulr8GwLtiYNdztlsdMrb6lYKsakMCT+lVFb9ak3c4r9Wic1iyp4yeKcrccVDuDdelORu 4rtg9BFmM5+tSK2ODzVeNgT/ADqXcS3pW6YEjSZ470ob5sfzqL+LJNLz2reLFYmEn40u7PP5UyPG OTQWG7+VbxkBMuOnfvT/ADAevSq+duOPxp241vFi3RNu3dKd1FQhulOaT0rrjIgk3HtUm7pUKt0q ThsVtcvlJg3PHFPViKh3EYp/mfKe1aKQmrFlXG35hz+lO3jqOKrK2R149ak4I681YrFgSErQJPwF QB8Nilzk5rRCJg23rzT1cdarZ45p69K0iBYVqVZDxg81Bu7nrT9wq07AWA2DT0Y5JqsrEqamjyav mAtLJuBqSNhyetQx4zzT92D6U7gWFk71KshAyTxVZfm6U7npimBaWT3p68c55qqrbeKkVuxGaq4F rzR+NP8AMPQVTEm1uelTK47GnzAWVm596crgciqobnrxSh6OZDLolpFkO7rVbzOh6UqyAtS9CrFo yUjSDt+tVzhqRm9Km5BOspXvS7+Mk81VEny+vNKz/N1p3AsK3XNIZAq88+9Qxye/40wtuyDSbAnZ s429aiLdu9MMm3oKY7Bj1pcwxXk3Hnio5HGBzxTWk6kmoWbFHMIm+8M5qOQhelM8ykdh1zS5gHL9 3IprMec80zzMDgnNI0vTJqLjsIWxnmomYjPpSNIGyO/0qJpPwoCwyRvlzULOGJ5pzSYzkcGoHYKS B0pCGsx554qN22j1FI5BpjHHek3YBGkJUc803jJzTZGNIG+X1rJsB7NjoetOjY1EzdOelOV2bhRn 1rCQEp4bA5FKrelReZSjPc1hJgSmTb160bvTgVEzbsDvSqT9ea5JDHZxzSbh9aY2cnNNyKxbEOZu 4pofuaYGI60m4tWbdikK0m1uOQabv5POKRmHr0pssm5Rx0rMOoM3cnrTC3GQaa0ny81H5ny4zmpY 9NkPZ+OTz3qFm568UM3X0qMv6Vk3YWwMBnrRUZk20Vzyl7wfI4IN61b09wt0hqnnj2qaz/4+I/rX 4rhXavB+aO92sdPHlue1Tx7f4qpxNtGAamZumK/VkzAsI3XFOWTbn3qDcNvGc05W7V1wkTYsR5DZ /GpQ3XJxmqu4888VJvU4IGK6VIkl3ZHXipFJycnFQbWkViASF64HFOWQj61vFgWFJ5NKrAHpzUSy diTilzlvbNbphp0J9/UZGDTly3Q5NQ479M1IrY6VspCJB705evpTNwY46Y/OhWOa6IyCxOq4wacp 4qIOe9PVicDPAreMgH7jn3p6+9Rn5sc04ZX3rZSJtqTbjj09KVWO3BNRfzpY3/AVakD7Ew78ZpVk 21CH/KnbuRitUwaJN53dcU9SexxUG7tinb8d62TJJs/jT1JPaqysSalVWjba2QavmEW4+KkVx3qD zCzc/TipB096E+5VtCdZM9+KeG6Gq8ZHepgR2qiSeL5m4xmplcFTzioFYKoweaXcOvemBYVtw96U 7t2OlQLKPXn0p3mE55xT5mBP6U7zB0z9Kr+Zu9RTt27GKfMBZ69T+dODnvzVbcVJzzzUm4d8570+ ZFpE7MPxpGbA61Dv+Ydqd0b0p3QWuShuOKGY7CO/tUasTzmmluuKlsnUk3HBpd3HNQ7t3tRuz1pX 0HuyXzMfX1oLEKD0qJmwDTC2AfSpKsS7s9DUTSe+DSF9tRM27nrQMfu4NRNJ+dHmbc5HGKiaTkig ViUyDbzyKZ5m3OeKZuPTPFRNIfqc0rognRiT9ajZgW6mo2kJ9qZuB60Nmg8sOpFQu/FJJIaj5kyF 5OCevpUXZL7DS2DiombbnmhmwvWomJ69anmIE9cnmmM3PXNBk+b1qFmqXIBzNnimk4FMyTgd6JHb aOMA9PesnLsOw7IYU5SQo7VAM9vzp7NwD3rKUg1JFYr71Kk3riqysaUN83HPtXLKQic9803cVxg8 U0kqoOabu5rmcgJGfdg5prNn3pnDZ5phbrWTY7Em4dM0wvknFMaTPtSbsL7+tQ33AcWI5pjcdRgn tTCxHQ0jSHcSTmob7FoGY456VGWpzSDBXFQZ61m2MViBgd6azelJuHemM3WsnIVriMc+h+tFRnNF ckpe8TqcMDlamtGP2hO/NQVJbtiZfrX4zRdqkX5noyOnXBp6+marxZI68VID3r9UhLQwZOp5qRfl xUW7Ip654rojIknDZ6dKcrAcVHHj8adXTGQyUSHGAeD2py9RUa7Vwe9O3c+ldMZCJVwtPXnqfyqJ R707pgYrdSFyosc+nFKMD2qHzCBipPMIU8VtGQWH8HIpyqQoxTFZdo/vHtT9w28Hmt1IWhIFOQDw akXGar+YWOWNPTPB9q1UibE+egHelHueKj3Et1pd35VsphYduNP3d8n2pgxj1FG7qcZraMriJCfy oB9aZu47Ypd341vGQkh4anKxzyKj3fL709WXb1IbtWykMk7Ej+dKshznuahDe2KXOTzVpi9C2sh6 d6eJM+1VFl7VJGxqhlxW69hT0cc81DG2V2HaBnO7HP5+lH8WAeKrmFyllZMLxTjIVaqzse3UUgdj yeapMmxbWQc1MGBGd2PaqSsQOeTTom6kcUyki75me2PSneZtqDzM8flR5g6HkVPMJFpXyRk09XDS KCwUE4LenvVXeOPSn7gKOYosthWYBtwzwfX3pQwCjJ5Paq+/OKXcT0NLmAsq/Az0pGY4B6VAJN3G KTzO3QUuYZNn34o3fMPSot35UMxXpS5hEzPyecVGzAqB6d6iaT8KY0h5xUcwEjSeh/GovM603dTW Y96fMArSfhUe49QPrSM/+c1F5h6EZpcwEhl7D86b5nzZNMLe9RtJvYnoaOYCVpM8n60xmBx1pnmb uMU1nzx0pczAez5UjHPaoyuKYz4xTGb5utK4DZOp5qPd8w7jvSqw55z7GoWk7djUcxDQm7DHnGaa cE4JprEt1GKYzYqb3HbQk+WNcDnNMZsdaj3d6aWG7196xchJdx+70604cjriox3xTlBIP93vWMpD RJxTh+XvUe7nAXH40iseRXPJlWHs2TzSN0yDzTV6805sba5nInlEGecmkU7c5pNxHXkUxm5rJyKW gm75uelKZBz3qPo3FNZu1ZuQhzNnrTWbA4pp+tMY4FS2MVnB6mmFuOlNLfNSM4FZ8wDS3PTimknv QzduppjSFvasXLUBfMKniim53ds0VyykrlWZxAOfanw8SLj1plOQ4cYODmvxqm7NHcdFGx2g+1Tb gFqrC2UXPWp93y4r9PpyvFGRMrAJ709ST71CnIqRW6DvXZGRPKTLj8akVqgXOak5rpjIVmTKehFO V6iXPHFOXoO1dCaJJ93TNCt6VD+NO3Hb6cV0KQE6tnHrTw3y9c1AkhHOcUob0NbKQEysN2akyOea rl8dKC/PtW6ZL0Le4DpyKcJumKqiTjj86dv4yTmtUx9CdpaVXJXk+1V/Mzn1pRJ74rVMhlxW+br2 608tx1qoGx3/AApyyVqpCLGc4HWl3HvzUO/KjFOWRc8nBrZSsImRvlIpS4wTioTJjvzQrBupwa3i xkyye+KcrD5evPXNV1kC5Bp/mD0zWqkIm4X2p6yelVw+TT1YLWlwLiyEHrUiyY981TDehxT/ADAe vWr5gLfm84pdw65qop696cJOgzRzIZbVuM54qRZPSqqtTw3FHMBYEgJ4/GpFbGDmqySenSpA2V9K nmESiTdx+lSBg3FQtjjvQGOOtLmGWd/40KxX6VDup6vnio5irMmVj3pdwz1qPzPek3cgd6lzDlJQ 3XsKXJZTz+NRb93I4o37VPNLnKtYCcHFIxwvqKQvu5pjSflUuQA7bun603cMjmmliaYzcUubsS0L IwyRmotxPUUjN600SED/ABpcxNhWPy1Fu4J6UMwIxmms2VxVcwgaQmmhw3U4P0qNmIPsKRm6dqfM A8sVwp6VG3ANNZuOeTUbMc8c0cyAduGOmKiZ+cdqa3HXimM35VLkA5m6nJGKiLcZxQzDb15pm4HO TWbn0AUOaGboRSBl5GOT056Uwn2xWDlcCQZ5waeG+U81XU4XOeaXd2zzWEpAWF+Vc0uQAMHNQDOM E8VIG7VhKQx/mNs8vPy5z0H86buwwFNB+tNz1Oa55SHZjywbvUZoHrTNx3Vg5CtYXPXimM3NGetN 3Drms+cQF8Uxm3UjN60it+FZuoApNRd6X2qJm+bg1m5oAZhu4FNZvfmkY8elN3DqRUc9xh5hoptF ckpK5qch2xTY+XUds0UV+Qx3Oo3YWLKMntVkdqKK/RqLfs0ZEsf3acrc0UV6EW7AP3Gpk9aKK3i2 BKG3daG4BI4ooroi3cmWwoahmPWiiuyO5AmelPi+ZSfaiiumIDo+VJJp1FFbLYBFP88UZoorYTJF +7nvTm4bFFFbxIluOTsM96evIb2ooqwW4isdx+uKWiit6YSFYkNt7U5WIxRRXShxEZyMfXFSLzto oq0KW47+LFPUmiitiSdfvU+iigqIR8yY7VLRRQOQ6IbsZ9M1JnEee9FFALYdH0FTxsStFFZscdh3 WhOWooqSXuOLEYpQciiis/slodTGY7utFFIZJmkzlqKKADsKYzHJoorOQDHYjAzUeT1oopfaJe6G t1P0qFCWzmiitGkUMJ5IprHH5UUVitzEgLFsE0p5xn1oorZbARnio9xXkHkUUUwIGY4Bzkmmt/Si ispbICPcd2KT+LHaiioAMbVYimBjkd6KKxkBIygYwKCxXkHnFFFYvYBV+7nvQuf1oorlew1uJvO4 0rfKoPtRRXNI1EU/KTSMoA6UUVzSE9iJx3qEMcmiisjISTuaae1FFZvcpDVO4nNRM23OPWiipJEZ j0prdqKKiW5pEj3HceaKKK45N3KP/9k= --_30A821E4-34E6-412A-BD80-6EC1FA5235BE_-- From xen-devel-bounces@lists.xenproject.org Wed Sep 08 11:06:37 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Sep 2021 11:06:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.181767.329052 (Exim 4.92) (envelope-from ) id 1mNvPM-0002KO-6c; Wed, 08 Sep 2021 11:06:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 181767.329052; Wed, 08 Sep 2021 11:06:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNvPM-0002KH-3V; Wed, 08 Sep 2021 11:06:24 +0000 Received: by outflank-mailman (input) for mailman id 181767; Wed, 08 Sep 2021 11:06:22 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNvPJ-0002KB-VF for xen-devel@lists.xenproject.org; Wed, 08 Sep 2021 11:06:22 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (unknown [2a01:111:f400:7e1a::62e]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 51402be4-325a-4eef-ae23-0b6b4ab43f8f; Wed, 08 Sep 2021 11:06:19 +0000 (UTC) Received: from AS9PR06CA0245.eurprd06.prod.outlook.com (2603:10a6:20b:45f::13) by AS8PR08MB6200.eurprd08.prod.outlook.com (2603:10a6:20b:292::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.22; Wed, 8 Sep 2021 11:06:15 +0000 Received: from VE1EUR03FT023.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:45f:cafe::4f) by AS9PR06CA0245.outlook.office365.com (2603:10a6:20b:45f::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14 via Frontend Transport; Wed, 8 Sep 2021 11:06:15 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT023.mail.protection.outlook.com (10.152.18.133) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.19 via Frontend Transport; Wed, 8 Sep 2021 11:06:15 +0000 Received: ("Tessian outbound cc1d52552731:v105"); Wed, 08 Sep 2021 11:06:14 +0000 Received: from f5378b50b472.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 43942ADA-248F-4FBA-BFFF-1EE7A8106600.1; Wed, 08 Sep 2021 11:06:05 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id f5378b50b472.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 08 Sep 2021 11:06:05 +0000 Received: from PAXPR08MB6816.eurprd08.prod.outlook.com (2603:10a6:102:130::10) by PR2PR08MB5225.eurprd08.prod.outlook.com (2603:10a6:101:1c::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14; Wed, 8 Sep 2021 11:06:04 +0000 Received: from PAXPR08MB6816.eurprd08.prod.outlook.com ([fe80::c1b4:db1c:376f:b697]) by PAXPR08MB6816.eurprd08.prod.outlook.com ([fe80::c1b4:db1c:376f:b697%8]) with mapi id 15.20.4500.014; Wed, 8 Sep 2021 11:06:03 +0000 Received: from smtpclient.apple (82.8.129.65) by LO2P265CA0504.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:13b::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14 via Frontend Transport; Wed, 8 Sep 2021 11:06:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 51402be4-325a-4eef-ae23-0b6b4ab43f8f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rjVEPgleUufWG7FxRAJ8OgjKsZxLoAtFwjrmB8PICUc=; b=RTFG2ZswWbQynh2C8SVAULRBQXiLD6vQ6KYVnn9xpIuxjQBC4HTGr1AYeVIrXyYoIWSh8q3VwbEuIy7b5ZbCME/4lxaKc2F10P4xLpD1lfA7LZX6BJ30OovO8USWZL74UovcNAV9Ad4ZGZ0ZGZGv/7PDgWdqyEUtMItvW9S1RxI= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; lists.xenproject.org; dkim=fail (body hash did not verify) header.d=armh.onmicrosoft.com;lists.xenproject.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-CheckRecipientChecked: true X-CR-MTA-CID: 77d5b0b807d761fd X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=P8kWVOiBSP8qLaAqd09llyYPIw6gMG4/PteTBs+oJ3uhI2cC0UPuFGV3p6wNVdGmvvGvxPGigFF66mcVcNcsvjrKfwGHNiFxHeRAHHonnEAs7N7D4GozY++CdSfjOVzoJvSIEAoLpln6arqUGTZAEm2v8RAI5D8rFAGpUSCbuj9o1tx94h0gtC1ngOil76t2x+MUVRZ4NKmKpExMEq6AJ2Cc+nRxj917b3vim92S0zLwcr6+p9pfokOOD/YE4Twa//Rzp0V8g9rNxVGC19xN7T/TNRGgLy3WXDEgtwAHlGoY8MnRWqcrEZiAd/ovoZWGpeweBcGfyDakuPHFk1IHAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=YqptrvRxS37Q3pgOV+agaxEVAKQ847xwENGiT+K4Hdw=; b=J1FPWc9IGmAZyP69FSlXEdf0IQFMvFe74gXV6VottOJ5ZcktG9aV26JL5fWvVpXyn7MBrksLIE03A0a1tMZJa0pNu9QLQwtB6oNu2nmAqhdN4tWSLimyDz27Ha6nX5oGEPetpCItoccLKvcRvJoJ8ryqCo7pZcXfO/7isziX1ue7PLJwGrP5XGy5xb61Cx2LZt5nNoWF9yq2b8IiAUjV1fl8GpmqZYdvSFNf4pMLaEK7fO5Cv8KvO2JkEt9+1lC5UJgMIcguBa2FYUFi2KURVGt4epRnwRkvLf3MWFlbshHbf90PilFP+1aexbRRLajA4GQ8wiB5pLGY9esBbL+6Ng== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YqptrvRxS37Q3pgOV+agaxEVAKQ847xwENGiT+K4Hdw=; b=8BVntMYWvuAlycfQT1hoJ/PYT7qcR1VMxXElvwr0PRW9oFVKVkM3sVL6MfW42AeGWHyqBWnVuyAiq+5eCGx+YR9pOGdCl2D2E8p2WwkbgVM1UKl9e7en2urzo8HiAmniLXaGHY3CzJd/L4gIURTyCRZLePDLfNz66gvDII08fbs= Authentication-Results-Original: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=arm.com; Content-Type: text/plain; charset=utf-8 Subject: Re: Xen Booting Problem on ARM Machine From: Luca Fancellu In-Reply-To: <1B61076F-D44A-41CC-89CC-A8E0E65E64EB@hxcore.ol> Date: Wed, 8 Sep 2021 12:05:56 +0100 Cc: "xen-devel@lists.xenproject.org" Content-Transfer-Encoding: quoted-printable Message-Id: References: <1B61076F-D44A-41CC-89CC-A8E0E65E64EB@hxcore.ol> To: Sai Kiran X-Mailer: Apple Mail (2.3654.120.0.1.13) X-ClientProxiedBy: LO2P265CA0504.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:13b::11) To PAXPR08MB6816.eurprd08.prod.outlook.com (2603:10a6:102:130::10) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 625394a9-6ded-4d33-9648-08d972b8ad23 X-MS-TrafficTypeDiagnostic: PR2PR08MB5225:|AS8PR08MB6200: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:10000;OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: jO60Phj85dBvXxQlvGAE90E8AwrJFPdK+7hYcBi80bYXdrQGAAddUy8ghvMMTKapIR7ZHOhv07ljherh8w+S419/TwycyToou2P/X83ZwEc4zUUY2tV1/ICy+l1KFlWXRHanY8btK6ZFHQV6dWgbYEhnjzs4yduj4VF5MgZz6Mc0vm58mWQJtWY5HMC5bc/SIjDwYB33p13hj9O3+IrjMKuysFK6dwrGsZfgkdUGyaEaL7krA6qpAAjGzspJg6mZupZgz+qLfD1/KDJMc1kZoYxghxvCMtjs9ojPdjOjnlUj8bIZS5NEvkNaYDZVr+jyq0q+OzVNkWCvlZpIBCQwelTpB8UaVg8x9suCWZ8YpvxAN0pu5y35e2HRLI6InvZMpNEBcmnPIIWq5xeA2jduNtn8UWoxCRwyM4vwft5RhXjJ/Qd/S1vQIRbQ7M/e/Ugzfs/NaPp4Uw+d+yQuaHg21VdFmDWR9UXtx2H3R3Q72nBVYrfw3GJEPwtLg+S09Dl+TZ9oT2lVTy6fHdoViShEGrKM1yHeUMJ36TP00Iobnyc6fAHWh5ol36nGhqBx2Na6D/dkDzuIYrAonKEkMjFyd7FHIpUR1yArIp1m7oWcGSfqCdtVLRk0ohjPkE/lxxdvzCUPmMDe+TkEU0y2sC35ienc/R5/6c1DqW+8i0MeiB3oJRO2U106cIPQWTM+JddNXiqhE5lixaI/yUmd/b59udehcV88DaUbNLu/QWUt5rA= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB6816.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(136003)(39860400002)(376002)(346002)(396003)(366004)(316002)(2906002)(6666004)(4326008)(66556008)(66476007)(38350700002)(83380400001)(33656002)(6916009)(44832011)(36756003)(38100700002)(26005)(6512007)(478600001)(8936002)(5660300002)(8676002)(186003)(52116002)(6486002)(53546011)(6506007)(66946007)(2616005)(956004)(86362001)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR2PR08MB5225 Original-Authentication-Results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT023.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 206d7893-cccc-4f11-b113-08d972b8a5c5 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: klPi255n2epLo+YUD/DCQJHA96P7JzcJodveVdqgXKt+eY4tAYxArRL81ZvcvShjAQrbDvmmnG3g2UMWXVZd7ozu2Rtf9yz0P8rPylJMzNrfL5lVmN7N5HpKCOgKrUub8mrDek0JXIiD0LczyXobREoC6FQh60Ij6TOSGK8GTi2743rYkeQ9xBshVIcLplO7wwieVUoLlvnSbPbH1es/C+yq8umzRr9YW32fa+PMAar+56qJepdU1NVIZCmj/X8tPqOpHSjDK1I2LdUTXt0sXrvdQZFs7QidDNZTjwzBZ94mpHp/gQsrCCBQZv6a7wqMeREMgOJT2v4pCR56O/O9dL1gJzuohyCUhwSaWiXOK1q6sMwLmJsEt8r+j8j9rvb2hLHC5QbFUbppA/90q7UkBwfZV0EVS2AfQJCxBqvmr5W0aVh16e50/n5oK86kPRjTuMzXTkiXa2MoIElqimr4NDe/zMev6St2GH7NAe+XOw4M90/dJEw+ZpBBO5GgW385ft575AyEolBsKPgNKZN+ex1u0owKeGbKl9dlF+l7v1qnYOKKrsc6QrAnlLIixjcmhLHyv+ksS0dzWVNJWBN1C0Yt3C7rEqcULLq2EWPXREntAj3+9miuUsCiv2U7ILkEBS/eHZAG/U4iZkLgyz+uL5k3h5+kMXuSXOmP1UWcd4pHLtEw6YAL3+3Oa7NUAXhq4W5LvKJuVWUoIszadX+Uaw== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(39860400002)(346002)(396003)(376002)(136003)(46966006)(36840700001)(6512007)(82740400003)(6666004)(2616005)(8676002)(70586007)(4326008)(8936002)(70206006)(53546011)(6506007)(26005)(36756003)(86362001)(47076005)(4744005)(44832011)(83380400001)(36860700001)(336012)(186003)(33656002)(2906002)(6862004)(356005)(6486002)(5660300002)(956004)(316002)(82310400003)(81166007)(478600001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Sep 2021 11:06:15.2875 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 625394a9-6ded-4d33-9648-08d972b8ad23 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT023.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6200 >=20On=208=20Sep=202021,=20at=2011:46,=20Sai=20Kiran=20=20wrote: >=20 >=20 >=20 >=20Hello, >=20=20 >=20I=20have=20Xen-4.15.0=20on=20an=20ARM=20Machine,=20with=20Debian=2011= =20installed=20on=20it.=20I=20am=20able=20to=20do=20=E2=80=9Cmake=20world= =E2=80=9D=20and=20=E2=80=9Cmake=20install=E2=80=9D,=20after=20=E2=80=9C./co= nfigure=E2=80=9D,=20as=20specified=20in=20README=20file.=20When=20I=20reboo= t=20the=20system,=20I=20get=20the=20following=20message: >=20=20 >=20Warning:=20All=20128=20bootinfo=20mem=20banks=20exhausted.=20 >=20Warning:=20All=20128=20bootinfo=20mem=20banks=20exhausted.=20 >=20Cannot=20exit=20boot=20services:=20ErrCode:=200x8000000000000002=20 >=20=20 >=20Here=20is=20the=20snapshot=20of=20the=20error. >=20 >=20=20 >=20Can=20someone=20tell=20me=20how=20to=20fix=20this=20error? Hi, I=20think=20this=20is=20more=20a=20question=20for=20xen-users@lists.xenproj= ect.org. Cheers, Luca >=20=20 >=20Thanks=20&=20Regards, >=20Sai=20Kiran. >=20=20 >=20=20 >=20Sent=20from=20Mail=20for=20Windows From xen-devel-bounces@lists.xenproject.org Wed Sep 08 11:08:10 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Sep 2021 11:08:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.181773.329063 (Exim 4.92) (envelope-from ) id 1mNvR3-0002vn-JH; Wed, 08 Sep 2021 11:08:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 181773.329063; Wed, 08 Sep 2021 11:08:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNvR3-0002vg-G9; Wed, 08 Sep 2021 11:08:09 +0000 Received: by outflank-mailman (input) for mailman id 181773; Wed, 08 Sep 2021 11:08:08 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNvR2-0002vY-Jn for xen-devel@lists.xenproject.org; Wed, 08 Sep 2021 11:08:08 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 0b5ca974-1095-11ec-b14b-12813bfff9fa; Wed, 08 Sep 2021 11:08:07 +0000 (UTC) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04lp2053.outbound.protection.outlook.com [104.47.14.53]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-40-cB24rCK_O2mHUJsw7tIBxA-2; Wed, 08 Sep 2021 13:08:05 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR04MB7039.eurprd04.prod.outlook.com (2603:10a6:800:12b::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14; Wed, 8 Sep 2021 11:08:02 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4500.014; Wed, 8 Sep 2021 11:08:01 +0000 Received: from [10.156.60.236] (37.24.206.209) by PR3P193CA0052.EURP193.PROD.OUTLOOK.COM (2603:10a6:102:51::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.22 via Frontend Transport; Wed, 8 Sep 2021 11:08:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0b5ca974-1095-11ec-b14b-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1631099286; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ibZZSZDjrGpS0aAvSHO8S3jjjnBSNdFfyqK0ghkhpSU=; b=NsaByE/xXWWLyN0oNmwuqurFRmQXrMND+8O0yM5VqCLzBL83pLztT3V/eqruQxnP2Rn5zE NgcpdDKkO0FQ7p9QnDN5mT+OzdYfb0nuuc4329DROVQoVk/tKAlBOK6dB0rVQVcXhdcI22 6dO0SJl7sdNwrVC8CY4JYukynDDFLew= X-MC-Unique: cB24rCK_O2mHUJsw7tIBxA-2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kojxzyUv9/2zTUos7IKE2PwBZBeC1HlpRWqMgCscqEGqwe9gqo9u9UcE3l8ihbkaLQkmIILrOtp4QUsoDQauqiEQOcXIwgkB2NOYPt9gXsxirqbLD2aXhtzNU8/m5Q0mfYTdG2O77qNaI6KyBg9N+TIroLI4gENyN8pWk/iJlyMsCxQa4q604fSpGIGsBkvEwyvKaSI0jinFMvHG1DFui9xX/BBDeAkQunSFay5EPxvrIy6erJU6jRVSq1tTkZR7YsvDteG7UmQOBRikyzyEBZPesINpud4IW+jn4vJ2KWBuWHwKK4Tnj9z1inzI48q+DMo0eYHvW8u1wNfwtw+c9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=ibZZSZDjrGpS0aAvSHO8S3jjjnBSNdFfyqK0ghkhpSU=; b=n89IR/s7EENoYKOP7zqcqikiBQa/6U6Pw4yVEdVkTg8cbR9YPGOSs0HnnBtKfbcgehC1QJqFZNZV3QKsTcV33Lh+nxu2A7HS4KKOv5CDcAox8Wvx+zLTdfdSdEeTs2DCBbmfslPOzNS6uJ4PlVZQST8ZBDAcyjsoeVp05mpI74zJxz3fZMFLP/pTgrzbFhKuKu1C0gWPHlVGDtkX3DUHE9SkK1gEt5/u9nDdhiuOsX6gBTaRUvl08uEZX/sHnBjhohkHsn3Y/5gcNA09zkxX+snyF7OnLfTNsUAs5+mGKv2zFmc25Jv92/CIngsaw2urYRSLshpaHPeEOLPyU69sXg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=none action=none header.from=suse.com; Subject: Re: [PATCH] xen: fix usage of pmd/pud_poplulate in mremap for pv guests To: Juergen Gross Cc: Boris Ostrovsky , Stefano Stabellini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , stable@vger.kernel.org, Sander Eikelenboom , xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org References: <20210908073640.11299-1-jgross@suse.com> From: Jan Beulich Message-ID: <5a4859db-d173-88dd-5ea9-dd5fd893d934@suse.com> Date: Wed, 8 Sep 2021 13:07:59 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: <20210908073640.11299-1-jgross@suse.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PR3P193CA0052.EURP193.PROD.OUTLOOK.COM (2603:10a6:102:51::27) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2f41b41d-b43a-4b7a-6790-08d972b8ec75 X-MS-TrafficTypeDiagnostic: VI1PR04MB7039: X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7219; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: utxgzYs6dqQkvYSIi4H5UoBlLIk0CWWEwwADTjpOH1Bd4dSJ/KZAF+ADIOmDpS+OyNgPEG0fnWoR7mlPq3D4KkZiLy/VrZY73jYm9tNVlMGn6nDk5xLqaFdyaZwARtC7G/s8JzwtHKC6E3i0/BW8xHxIZRv11Dgr1YTYeGB6cwx0v48HtMkAUty8hmjNqZ9RLjTlwGwWVuI6twro9ekZIdYzr9SIeHRzMwNWP3wnXBkD10X2HMVY0htijEs6N4uTDUllyZc9uD6euEXBdf0yW9XN9OgpTlv28ZblCNp0syphMiSmh70JBlHINPsOmQ0+f1fp0bptpWKxEie/uj5SIuAfqySJ7WmpcVDv+v3e+f7bp/sjxUa/449KrxR7Pmmwg1RL0bqQQKu1SF0Jo6xhLqwp/0GaQtA3HTm8tQTIbLk5kiZoeZwBv3cYcGeXEQvijTjoOUgC7HTLSWi9FwxIEHLOPtR+TAS12FVJgHhyzprcwExcMnXuaa/T+1cB0P0OmGNc9U5SuwIDE4ewTSyL7JxEsyPPkEH5OHwJgkbFcfSbL5eJ5tQii7FVvugq1VUhEn44/0maQlZG/GU9Vfg1+2Nt4JDgPfTuFAxnjfxu0SdQ108Yse5cpn5brNp5pwYl0qLa5iDUOGRQeF0Z1s300M45ADdxWCW2vWjtrKvaJBp4qrcMQ9Ew+Ed7MUZzvpXtDLFATgywzL73GD/6Qc1x2aSJtv+cGOUrdP62Su1s7qg= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(346002)(366004)(396003)(39860400002)(136003)(376002)(8936002)(186003)(5660300002)(8676002)(478600001)(26005)(956004)(2616005)(86362001)(4744005)(6486002)(53546011)(66946007)(38100700002)(66556008)(4326008)(66476007)(16576012)(6862004)(6636002)(83380400001)(37006003)(31696002)(7416002)(2906002)(316002)(54906003)(31686004)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ODQwS2pkZitMMHA5dm1lM1NqNHRSYiswTGU3SzhkRkp2ZysvZFFob3BtelF1?= =?utf-8?B?dnB5M3Z1ZHV0ZGRrNmRiVjk3c2hab3FybTRvd044Rzhhb0h5ZnhhYlhZMjYy?= =?utf-8?B?YXprZEdYN2hnRG9ZbUV1SHNtbTZSa3FRVjR3T0tYRng3VjcramZVMXhQOWF1?= =?utf-8?B?TjZSZjZHcG13enYwbGxPRE9Xem9HUFJjYlFuaG01UGJlK042MEtiQTQ3VWFl?= =?utf-8?B?aGpLSGNwQVRQUExvTlcySzRYekJCRUlmampYOWJvV29taThXSmEyVGdrZWhS?= =?utf-8?B?bXY4dmdxYUQrUDNPL0hhc0prcmsyVTQ5dm5sdlVOV3RmTkpZYU4vVnlaZGlw?= =?utf-8?B?U2tOMStqcWN5c3RPdWVFa3IzL2tod1cyZXBpNk13SjRGVVNJQWhycTBSY2Q4?= =?utf-8?B?V1d5S0Q2QTdSUU4yMVVKaFBXZ0dEM0Y4eDBqR2VtSG1KTk9zT2lxa3VNeTVs?= =?utf-8?B?dXkxbFdKcWcwV2tUMG4wOG80S1BzTTdLQ3o4R1lVeDVrU1VZdkNsZEpLMGZ1?= =?utf-8?B?WE84YmgyU2JjalhhVTl0SXhiT3BSQm5nRm52Uk9xaUJYSG9tMDB5Q1NkMk1H?= =?utf-8?B?b05McUpTaUlEUWtnQWQrQnJDanBqaWhqK3p5WHdTYi9ZQjFnSUNaWEEyWUp3?= =?utf-8?B?eHpxMml2d1hFZkw1YjJwekttaVVHcU5Db21qengwUDZTdEswamxwT3lzTTFL?= =?utf-8?B?d2NkV2tEOEVHbzhPakdnMHgzK2p6SmozVnFxUkhvUFcwc0pseHNDTlBoMzJB?= =?utf-8?B?NVFqSzBudzJLeEZCdTd1WmJZd2RPbXRBU1hCUFNTT3djOE10U2NzdjUvaStP?= =?utf-8?B?YnRVRDZnUEZJUUh5bmVSMmZ6dVh5TEsyRGRqd1NsWGowendvbHA5bDlHc3A4?= =?utf-8?B?bjFJdjhTc0k1LzFBVjk1MStGQW5rbDdveDVqUEJTdUxRcElZdDVqV0x4STZN?= =?utf-8?B?RzBtODJEQ01jdzhOSS9Va3Rqa25sb0hzYU93OGI4Q0QrR3BZUWl6NHY3Nzli?= =?utf-8?B?N3hlaXQyZk1TVStLdlN6YjZEU0ZkRlZNQzBDUWhvdkJCekg5K3F3M0VoMEZY?= =?utf-8?B?ejdDSW9ySW81YnAvRURWaXU4VDNrWEJSSGpiakNKU3RlcmcxYmxoQXVPRU9Y?= =?utf-8?B?WjZGUmVTbzdaRWRRVGtqM0RoR3ZGQzNPMTJWTlArd1d4M29ENDNSQXJ3V1Q4?= =?utf-8?B?N001ZDBVa0pMUVhYSW85MFFlZkJrdmtpUkxkcEVtc0pXdElwNGVXaURrazdy?= =?utf-8?B?d1hlUFFqRitBSFdpNEtoMGlYNEdoQU9hYmhyd3Nmd3VoWnJCLzdmSlQ3dWpj?= =?utf-8?B?TzZQczdmVVREYi8zWTAyM1FHc0VPUUNaUHF6Lzk5Y3h4M3BPT0ExajdKc0lB?= =?utf-8?B?Y2lvNGpsdURnb1lJckNvOThoTXIvcE5HMTgwdnJjM2xwS2p4UHNxeURCdE11?= =?utf-8?B?S2FxRHNURjlkRmRjYVFyamFENUJGSnp1aHpaU2lralMyWnJCZDM5alo4RmFJ?= =?utf-8?B?c2xaeDY2bmN1WjhiWG41ZnRjVitHOVdWbmxFcS95Tnd1ODZKZjVJa2U1bXBp?= =?utf-8?B?NGJrYUVpYlp5WGRuS2tJYTBBVlNZczQ5NnZydUpvazR4aHo5NVZpL1VLWFZS?= =?utf-8?B?Z0ZlcEZKdElpUGt5UVlzMElJalcyR0lWYnJkaXJ0MWF1UHJ3SC9pKytORXdQ?= =?utf-8?B?WGdkTVpkZVZFYVM5MDluQ2M1WVFOMUdTcHdUNEI1SFlYcldmR2ZLVklZcklZ?= =?utf-8?Q?9bkFrGvPxGZxWkNbXvaqTo/b/suyhuSN2+mUZNK?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2f41b41d-b43a-4b7a-6790-08d972b8ec75 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Sep 2021 11:08:01.8090 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ZLHvnujt1kr3En3TS+/V2UrsYzpUsJ8YohOMkTEo7Rf3vUlrfLp7XX8XECNWVT4CLf14MmIj3x+hZt1iKFEiag== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7039 On 08.09.2021 09:36, Juergen Gross wrote: > Commit 0881ace292b662 ("mm/mremap: use pmd/pud_poplulate to update page > table entries") introduced a regression when running as Xen PV guest. The description of that change starts with "pmd/pud_populate is the right interface to be used to set the respective page table entries." If this is deemed true, I don't think pmd_populate() should call paravirt_alloc_pte(): The latter function, as its name says, is supposed to be called for newly allocated page tables only (aiui). > Today pmd/pud_poplulate() for Xen PV assumes that the PFN inserted is > referencing a not yet used page table. In case of move_normal_pmd/pud() > this is not true, resulting in WARN splats like: I agree for the PMD part, but is including PUD here really correct? While I don't know why that is, xen_alloc_ptpage() pins L1 tables only. Hence a PUD update shouldn't be able to find a pinned L2 table. Jan From xen-devel-bounces@lists.xenproject.org Wed Sep 08 11:15:08 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Sep 2021 11:15:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.181779.329074 (Exim 4.92) (envelope-from ) id 1mNvXl-0004a1-DO; Wed, 08 Sep 2021 11:15:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 181779.329074; Wed, 08 Sep 2021 11:15:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNvXl-0004Zu-9W; Wed, 08 Sep 2021 11:15:05 +0000 Received: by outflank-mailman (input) for mailman id 181779; Wed, 08 Sep 2021 11:15:03 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNvXj-0004Zo-OK for xen-devel@lists.xenproject.org; Wed, 08 Sep 2021 11:15:03 +0000 Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id c82d6b71-a64b-4306-b480-d3964c41194f; Wed, 08 Sep 2021 11:15:02 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c82d6b71-a64b-4306-b480-d3964c41194f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1631099702; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=ofIWEMY5+EK+JKgsmrzt8FZLnZlMtaCP0HWNgorTbrs=; b=iMQ/ITT9nEUILEFnucIHsxOsDvIPaG2IkBujcXG/oRl8JGGAzkITyTDr N/xcFgGQlcXFclwt4YD0uZB4Evsowq0vIqXc0kTsOYSduR7D0rV57Ltml GOzLLyXbRNA86R2uqaFW4DiKPS+GDrDlU7dqkJdLQbMk4Z7CM3mJYwyWh c=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: yu7wkN9+I7fVB+84sgevwm/Fcn1zI3OrEoXq/wC/7jI6xgO1bfOpqdAEb204briH+nN7MPbXEA Ayj3yk1pjMBDs1Qbvk/8Mdq9O8AxNu1Ftgv1oMCgprFWZI8RPkhFnbou0CHCJt2cbk04xnChtW b0Os76oZbM00MnPZFLyFKC/U4IJSJctxEvCkjNqK1hAr4/j9svpOHS2F9gam3sUiwVFYQNF2an YkUdl008MgR7OXXxu22u6yKlq10r6AEEqeE2cfVBIqr1x1hSSWdQUVUjRgcbPtbGkETki7ZX2c jo7GIGMHCJhozx+J8Cck7q09 X-SBRS: 5.1 X-MesageID: 52251320 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:mZRoAak58A2M27MqqKZ5KJyQSMDpDfLW3DAbv31ZSRFFG/Fw9/ rCoB3U73/JYVcqKRUdcLW7UpVoLkmyyXcY2+cs1NSZLWzbUQmTXeJfBOLZqlWNJ8SXzIVgPM xbAspD4bPLbGSTjazBkXSF+9RL+qj6zEh/792usEuETmtRGt9dBx8SMHf9LqXvLjM2fqbQEv Cnl6x6jgvlQ1s7ROKhCEIIWuDSzue77q4PMXY9dmcaABDlt0LR1ILH X-IronPort-AV: E=Sophos;i="5.85,277,1624334400"; d="scan'208";a="52251320" Date: Wed, 8 Sep 2021 12:14:57 +0100 From: Anthony PERARD To: Jan Beulich CC: Andrew Cooper , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu , Roger Pau =?iso-8859-1?Q?Monn=E9?= , "Tim Deegan" , Subject: Re: [XEN PATCH v7 05/51] x86/mm: avoid building multiple .o from a single .c file Message-ID: References: <20210824105038.1257926-1-anthony.perard@citrix.com> <20210824105038.1257926-6-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: On Tue, Sep 07, 2021 at 08:14:14AM +0200, Jan Beulich wrote: > On 24.08.2021 12:49, Anthony PERARD wrote: > > This replace the use of a single .c file use for multiple .o file by > > creating multiple .c file including the first one. > > > > There's quite a few issues with trying to build more than one object > > file from a single source file: there's is a duplication of the make > > rules to generate those targets; there is an additional ".file" symbol > > added in order to differentiate between the object files; and the > > tools/symbols have an heuristic to try to pick up the right ".file". > > > > This patch adds new .c source file which avoid the need to add a > > second ".file" symbol and thus avoid the need to deal with those > > issues. > > > > Also remove __OBJECT_FILE__ from $(CC) command line as it isn't used > > anywhere anymore. And remove the macro "build-intermediate" since the > > generic rules for single targets can be used. > > > > And rename the objects in mm/hap/ to remove the extra "level". > > > > Signed-off-by: Anthony PERARD > > Reviewed-by: Jan Beulich > > Hmm, when replying to 00/51 I didn't recall I gave an R-b for this one > already. I'd like to restrict it some: It should be taken to stand for > the technical correctness of the change. Nevertheless I'm not really > happy with the introduction of the various tiny source files. I've > meanwhile been wondering: Can't these be generated (in the build tree, > as soon as that's possible to be separate) rather than getting put in > the repo? Do we really need to generated those never to be change tiny source file? Do we really need to make the build system a lot more complicated? With those tiny source file in a different directory to the main source file, we need to add "-I" to CFLAGS. (source tree vs build tree.) I don't like preparation phase, I'd rather do just-in-time generation of those tiny file (if we really have too...) as to let make organize itself on when to do things. That mean, extra targets on how to generate the files, and telling make that those would be intermediate target shouldn't be deleted to avoid the final object from been regenerated over and over again (I'm not sure why the rebuild of tiny source file happen when they are intermediate, maybe because FORCE prerequisite on %.o). Can't we commit this patch as is? What kind of issue is there with those tiny source files? Should we add a warning in those tiny source files, something like "No modification of this file allowed, it's part of the build system." ? Thanks, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Wed Sep 08 11:17:50 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Sep 2021 11:17:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.181784.329084 (Exim 4.92) (envelope-from ) id 1mNvaO-0005Dy-RC; Wed, 08 Sep 2021 11:17:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 181784.329084; Wed, 08 Sep 2021 11:17:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNvaO-0005Dr-O2; Wed, 08 Sep 2021 11:17:48 +0000 Received: by outflank-mailman (input) for mailman id 181784; Wed, 08 Sep 2021 11:17:47 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNvaN-0005Dk-Dm for xen-devel@lists.xenproject.org; Wed, 08 Sep 2021 11:17:47 +0000 Received: from esa4.hc3370-68.iphmx.com (unknown [216.71.155.144]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id e15f394f-9ca9-4501-8de3-bfa322d43296; Wed, 08 Sep 2021 11:17:46 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e15f394f-9ca9-4501-8de3-bfa322d43296 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1631099866; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=yFoFUnDtDv1Bx6JlM1glTN7fv8M7gM83RxpG34T+cRY=; b=ZbaEUlHZTA0s9AMBBVmOnBzNbWxZMAa6Uri1khm+QVM3NdTEX4mAuarx rYQc5n1pqBJUcb+xm3cAw9I4+0Su94Ug2IiN0/91IYDczmHek5GdrxL4q qbhJ+zzaBdH2WtEts/ZY+QaWDjfbaV1+ndCgwNSM3/LBZEpNkRjOFDIEH g=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: eJup9ZqHw10h4D/ZS5pZyXcOzlKqTsplKgaSzOy3lgSUgNnC0xL2D1DEtmDOsi+MyZy5D3z7iu EJo4Te53bMEeEYuZE1XZOyXMdxozW+HGQS+ymxbmOHjjgcFC+hVXiIVFpeL+GpuuTW9fjU8IID cvjRSX5Kb00xT3kDIiH8rYtZMCNKl1axeZiAeW/Yu2Beqz06s/IFEZ3ijsVxvMUU62aNOfmUxC rvKgSOaPvFGeg14yGV0msqMqFRPFkdfvew6uj6C7/lvOdsnu3q9ZozPPKTElLAWZLneRp/i3p3 xCY2pPOryyrlwzmj5kVEnd6T X-SBRS: 5.1 X-MesageID: 53998744 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:Z2m7M6wW8HYwdS+Q8kRnKrPwIL1zdoMgy1knxilNoRw8SKKlfq eV7ZAmPH7P+VAssR4b+exoVJPtfZq+z+8R3WByB8bAYOCOggLBR+sO0WKL+UyGJ8SUzI9gPM lbHJSWcOeAb2RHsQ== X-IronPort-AV: E=Sophos;i="5.85,277,1624334400"; d="scan'208";a="53998744" From: Anthony PERARD To: CC: Anthony PERARD , Andrew Cooper , George Dunlap , "Ian Jackson" , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [XEN PATCH v3] xen: rework `checkpolicy` detection when using "randconfig" Date: Wed, 8 Sep 2021 12:17:27 +0100 Message-ID: <20210908111727.440265-1-anthony.perard@citrix.com> X-Mailer: git-send-email 2.33.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain This will help prevent the CI loop from having build failures when `checkpolicy` isn't available when doing "randconfig" jobs. To prevent "randconfig" from selecting XSM_FLASK_POLICY when `checkpolicy` isn't available, we will actually override the config output with the use of KCONFIG_ALLCONFIG. Doing this way still allow a user/developer to set XSM_FLASK_POLICY even when "checkpolicy" isn't available. It also prevent the build system from reset the config when "checkpolicy" isn't available anymore. And XSM_FLASK_POLICY is still selected automatically when `checkpolicy` is available. But this also work well for "randconfig", as it will not select XSM_FLASK_POLICY when "checkpolicy" is missing. This patch allows to easily add more override which depends on the environment. Also, move the check out of Config.mk and into xen/ build system. Nothing in tools/ is using that information as it's done by ./configure. Signed-off-by: Anthony PERARD --- v3: - use KCONFIG_ALLCONFIG - don't override XSM_FLASK_POLICY value unless we do randconfig. - no more changes to the current behavior of kconfig, only to randconfig. v2 was "[XEN PATCH v2] xen: allow XSM_FLASK_POLICY only if checkpolicy binary is available" --- Config.mk | 6 ------ xen/Makefile | 18 ++++++++++++++++-- xen/common/Kconfig | 2 +- 3 files changed, 17 insertions(+), 9 deletions(-) diff --git a/Config.mk b/Config.mk index d0712724f8e4..144411133f38 100644 --- a/Config.mk +++ b/Config.mk @@ -137,12 +137,6 @@ export XEN_HAS_BUILD_ID=y build_id_linker := --build-id=sha1 endif -ifndef XEN_HAS_CHECKPOLICY - CHECKPOLICY ?= checkpolicy - XEN_HAS_CHECKPOLICY := $(shell $(CHECKPOLICY) -h 2>&1 | grep -q xen && echo y || echo n) - export XEN_HAS_CHECKPOLICY -endif - define buildmakevars2shellvars export PREFIX="$(prefix)"; \ export XEN_SCRIPT_DIR="$(XEN_SCRIPT_DIR)"; \ diff --git a/xen/Makefile b/xen/Makefile index f47423dacd9a..89804aefe385 100644 --- a/xen/Makefile +++ b/xen/Makefile @@ -17,6 +17,8 @@ export XEN_BUILD_HOST ?= $(shell hostname) PYTHON_INTERPRETER := $(word 1,$(shell which python3 python python2 2>/dev/null) python) export PYTHON ?= $(PYTHON_INTERPRETER) +export CHECKPOLICY ?= checkpolicy + export BASEDIR := $(CURDIR) export XEN_ROOT := $(BASEDIR)/.. @@ -178,6 +180,8 @@ CFLAGS += $(CLANG_FLAGS) export CLANG_FLAGS endif +export HAS_CHECKPOLICY := $(call success,$(CHECKPOLICY) -h 2>&1 | grep -q xen) + export root-make-done := y endif # root-make-done @@ -189,14 +193,24 @@ ifeq ($(config-build),y) # *config targets only - make sure prerequisites are updated, and descend # in tools/kconfig to make the *config target +# Create a file for KCONFIG_ALLCONFIG which depends on the environment. +# This will be use by kconfig targets allyesconfig/allmodconfig/allnoconfig/randconfig +filechk_kconfig_allconfig = \ + $(if $(findstring n,$(HAS_CHECKPOLICY)),echo 'CONFIG_XSM_FLASK_POLICY=n';) \ + $(if $(KCONFIG_ALLCONFIG), cat $(KCONFIG_ALLCONFIG), :) + + +.allconfig.tmp: FORCE + set -e; { $(call filechk_kconfig_allconfig); } > $@ + config: FORCE $(MAKE) $(kconfig) $@ # Config.mk tries to include .config file, don't try to remake it %/.config: ; -%config: FORCE - $(MAKE) $(kconfig) $@ +%config: .allconfig.tmp FORCE + $(MAKE) $(kconfig) KCONFIG_ALLCONFIG=$< $@ else # !config-build diff --git a/xen/common/Kconfig b/xen/common/Kconfig index 0ddd18e11af3..73d8afb7bcbd 100644 --- a/xen/common/Kconfig +++ b/xen/common/Kconfig @@ -235,7 +235,7 @@ config XSM_FLASK_AVC_STATS config XSM_FLASK_POLICY bool "Compile Xen with a built-in FLASK security policy" - default y if "$(XEN_HAS_CHECKPOLICY)" = "y" + default y if "$(HAS_CHECKPOLICY)" depends on XSM_FLASK ---help--- This includes a default XSM policy in the hypervisor so that the -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Wed Sep 08 11:19:50 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Sep 2021 11:19:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.181791.329096 (Exim 4.92) (envelope-from ) id 1mNvcL-0005tI-Bv; Wed, 08 Sep 2021 11:19:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 181791.329096; Wed, 08 Sep 2021 11:19:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNvcL-0005tB-91; Wed, 08 Sep 2021 11:19:49 +0000 Received: by outflank-mailman (input) for mailman id 181791; Wed, 08 Sep 2021 11:19:48 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNvcK-0005t3-1E for xen-devel@lists.xenproject.org; Wed, 08 Sep 2021 11:19:48 +0000 Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id ac53af8e-1096-11ec-b14b-12813bfff9fa; Wed, 08 Sep 2021 11:19:47 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ac53af8e-1096-11ec-b14b-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1631099986; h=to:cc:references:from:subject:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=aDBidDCC9WuT7tkVMIEbQgAn3Qkxl/NpiZcnYOTXLnY=; b=hQ2lYKccmG115exS3eWhAEAa4nDu7aOHzdpRqIw5KrcquQyx8qoOBhD7 ng4glZaQq+TX9l6iMF89fg7ri5hZleuvqHR2y0sJNloBcB+2LlcHNcI/w b/LIqodg8bFlCoCbWohBuvcj1+84liw9yw7f4jngeB9dYqAWMDktnk2A0 A=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: JpeoATnmWEi63cmMlurSE6BrQFH4lnB6Wf7cykLDMh8c3eDTMrnyd9PZs1tlkiznOcu6kDZ1wA iaaD9l3mcOaoIjAz4wsVPkufAHcp1dWTXprbvt+UKEvj54FIckXg3r7iH0Zq3knp3RaoELItoY r8rRT1/s1EKXayTp6x6v2AMzG5oZBWK3ShKGeVcwsp9KKcN3HmRTQ2V72hnWHw/3vaSRsG3tZ0 L3XY6SDCwx7NSwtrPDOrsG1ol/6Fpdo1QB6aD3u9F6zxhyTSTRA6Ksiw3f0ZovA63iZHoTgbKs BiHWSv5j8Y0EucHEzOuqCyvT X-SBRS: 5.1 X-MesageID: 52642355 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:SRh5IazutSZA/iSoI4cJKrPxu+skLtp133Aq2lEZdPULSKOlfp GV8MjziyWYtN9wYhAdcdDpAtjkfZquz+8L3WB3B8bfYOCGghrUEGgG1+XfKlLbalXDH4JmpM Bdmu1FeafN5DtB/LbHCWuDYq8dKbC8mcjC74eurAYfcegpUdAF0+4QMHfrLqQcfnghOXNWLu v/2iMKnUvaRZxBBf7LeEXtEtKz6+HjpdbDW1orFhQn4A6BgXeB76P7KQGR2lM7XylUybkv3G DZm0ihj5/T/c2T+1v57Sv+/p5WkNzuxp9qA9GNsNEcLnHJhhyzbIpsdrWetHQeof2p6nwtjN 7Qyi1QcPhb2jf0RCWYsBHt0w7v3HIH7GLj80aRhT/ZrcnwVFsBeoF8rLMcViGcx1srvdl63q 4O9XmerYBrARTJmzm4z8TUVjlx/3DE4kYKoKo2tThyQIEeYLheocg050VOCqoNGyr89cQODP RuNsfB//xbGGnqL0wxhlMfheBEY05DWitvGiM5y4uoOnlt7TFEJnIjtY4idixqzuN6d3FGj9 60epiA2os+F/P/wMpGdZA8qPCMexnwqCT3QSuvyGTcZdM60k322urKCZUOlauXkc8zvdYPcK qoaiIviYd1QTO3NfGz X-IronPort-AV: E=Sophos;i="5.85,277,1624334400"; d="scan'208";a="52642355" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aUgw24THEqNdg6LUGQw6mkalO/20JrQU52VSIghftCoVZ0iTkVo3Y4U7ql5gft/4yA1ROA27USR6eNgaVtgZ3LXZOCzLFVrtAW1Jim9och2Aol9Z/Pu8aFBBFqbgmgZX7iJmKvhGl7VxpVMTkcIgzKA30YlHzlsNTVqD+vPbYEdr0mLEOJPgjtbNG1vtdyfgIYwVcKW5LMUPuM8veo8SkNAXq8Ci3KNkCsGJZey4LQOQKsMK4pLqWvhceP4zeZBsigkz11TTZyPc1m40+kMLZ+ohKGrZUfx6yaT9Ee/mFuNiVOy3HcwU95vEi10/ADvZIQTPKUgLyr/vUPfFcpGfOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=eub7v+WpEf0gP0zssA1hcLQX+YwwrFfIgLHvmvV0DNM=; b=XyHB77aSplRQbQx46al6tmq6Zju3qimfmdamozmWTRJk4k38yw1/SCBID708n1W5+RIuEO3Ny0We35fOZKW52AOj5Ck3F5mBDJasYy9eAYZO0HWW/JpKS6b/CUpAfZj0/1r5Q8+KQU/SfYPVpE0qLU3h+Suf7KTi8Ck/OM9DyrwbU4cokx6zCQoTJB6LmK1OD3EpKQ2GsYkH9I33yU376JUyaqnn2OVYZRN493Jtg3KY+Y4HAMOLwglgFYOSoQPP8vi4S350N2OjBRt+LvuNRU9oy6vQXtCJSpCTaukygasp+ixnA3D5UW70n4I8zX4coQT9HxoSxesmYoLq3wXYoQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eub7v+WpEf0gP0zssA1hcLQX+YwwrFfIgLHvmvV0DNM=; b=sZ4sGona6ueRIROEiVffo5qXz7RyN/qMEBIQ7M/XIcosgQKio67M743xuJoUR625UezF3St9g5EE8KomoyfrDWWOAXw6hB3KjH9MNVGg73NfGYha+zAH+gilpb+Q/ZmNEqTCWJ438jSl1Is2RjIGwrWPr/pgiFFBv6RbWOgB60Y= To: Jan Beulich CC: Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Xen-devel References: <20210817143006.2821-4-andrew.cooper3@citrix.com> <20210907161908.17402-1-andrew.cooper3@citrix.com> <1fa45e94-ecd8-8920-1f08-027b348a71e1@suse.com> From: Andrew Cooper Subject: Re: [PATCH v2 3/3] x86/amd: Use newer SSBD mechanisms if they exist Message-ID: <3895db85-d5cf-dff3-0877-684b4bc3d718@citrix.com> Date: Wed, 8 Sep 2021 12:19:38 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 In-Reply-To: <1fa45e94-ecd8-8920-1f08-027b348a71e1@suse.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: en-GB X-ClientProxiedBy: LO2P265CA0349.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:d::25) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 509c5b08-113c-4e30-cba3-08d972ba8eba X-MS-TrafficTypeDiagnostic: SJ0PR03MB5663: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4941; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XV7vKGv66v1UQZf6jXeTrGYs4hxcdKJXJHfPF8xc5wBkBDY158yUk3lTze0pzpShDJ2vwznCPSwl/CMYF39nD6DVL18aKOhayd4aWnSkmBgXu9sy5hxhN/3dDsBHcT9GNbZWss1+Hki5UcqesLdoSkykwhQTYo1SDY6XiJCy7Kl200Qq/Tbwuo+3FAPuPCQaEoHcsnHXHl8javxMxTW9d7wCaN2j1Ah5PiSSUO/GQVALq+yniiSnax/NGTrPoda7GlXCbQmOkKs6TCYiwlyxkTrxm8BXzIzVZ3wieXi70M1Foe9lXDYBGWnoShHvMzXWcWqsgfxtokF2CVhmAx1Xwi618TN7m6Npatx8AkP50PFbtre8XjPg4IN+EjBzuLilI5PyWC7hLTub7WSb5vEesBMSd+SipNAyiNeczoFgis8uRStgHXklSb+z51Hf1brQzdY/HgBbyXXuaGP8sbyk0eZaVuaCS54IcYjMeZ3rqq6Z5rT02vkZkxgdEgvmoJRwCbWtwPlemZ5+ky2P1k/guKTZK+djvnRWxgQGEg4VlTnMxynGUdsgGofy2BgaEz1sp5dt9JrTYMO15mdjb/4cond/FscPbZ21op1e8RzsLmBVUJBZVnc4ZW1zmurcn2djeyJcX96/t46hIS8yEWLFOztLVNDvmm/4fxivb1vlTq596aRPWIT/CZw4+VJBg/gdBeXgoNmbNNjzYMyw9osJdCDP/4jiBsA+mpD/MZD6hhQ= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(396003)(376002)(39860400002)(136003)(346002)(5660300002)(2906002)(31686004)(53546011)(6666004)(8936002)(36756003)(38100700002)(956004)(4326008)(2616005)(8676002)(6916009)(16576012)(316002)(54906003)(186003)(478600001)(26005)(86362001)(55236004)(66476007)(66556008)(66946007)(31696002)(6486002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aVdGTDBpNWRjVDdXM01naTVwa3c1cmp5bmYrM2ZMUTBLL2FVMWxkQUs3NFdy?= =?utf-8?B?OVVSTmFPWEd3Y3FxcnduOTdtcHduMEZaN0hOVGFJcTRuUUxqTlVILzRlL1Zm?= =?utf-8?B?Zkt5MG1WcXc4b1dEeHoyRU1MRmt1L0k0WlR1N1hEWTNZYmVJd2RDVnpYVG5E?= =?utf-8?B?eE1kOGdzS1VGT0k0eUY4cHNOZCtQbDJNQTFDUkIrcTBKR1BjTDc2OEU4b1gx?= =?utf-8?B?d3FmRVhBNW9LTXdhbERBbzFtbnRhNWR5MmRpTkIvZlpEU0tqVzBmVWpiKzNv?= =?utf-8?B?clVRaWgrSDZsdjVHWXZtRFFPRjZRVkh3cE9KKzIxKzhMUkpEVDdNbWpjb2xv?= =?utf-8?B?RC9mVTc2NmpDMXpUeDMwRS8rQjBKYXRJQmRJbWtyWnV0VzQvazB5cVY0VnpQ?= =?utf-8?B?RkRUUVJFWkRHZ3JRRWIwbnhYNXJwU2JVM093TlFZTHBmUnVkOVZ3Wkd6cTFk?= =?utf-8?B?WUN3Rjk2aTdtdUZEZXFQem9MK3RyQVVIYzVMYlcyK2RjZDRlYXlDOVZSL3lU?= =?utf-8?B?Wk1CakZjQ1RpU1d4VmJ4TWpuRW9hUzlrUDdhYk1LZzVJZmVkSlMrODUwYktY?= =?utf-8?B?OVoyQUlLWDNOQzNMM1cycFZZMjhKM0p4OHVITXZYYWJPMW5FWHRpa29reVpX?= =?utf-8?B?eUxOOHJsSTFsT1NlZkxkb245cnpkQVRUaW1GRUhjbnpRM3NhbHpEMDA0cHlO?= =?utf-8?B?MFpJZUJBY1J2UWVoU015ckxsT3dISjhuOTZXMTVnNTI1a1dQVGxQSklXcVVE?= =?utf-8?B?YlNYaFV5SGpxVnVMeGE4d2FTWEFyYzVvUlhUbFdCNGY3akNqNlRoWXptZlFp?= =?utf-8?B?Y2FuU3lmZ0drejMyUTlad1dReVFpN09WLzdxdkN4WFBDdDJMMFhJUUx3YWx0?= =?utf-8?B?aVlEeEovMmJyYlJJSnVyU2NvTGoveGtsc3F0ckYxWXpHWDVDNE5VUURaTTV0?= =?utf-8?B?SzJXVVdxRllTUFlXeGRNYjZTcjMwek5OazFaQjdabVBQNFJVKzRGcUVsUGV0?= =?utf-8?B?aGZSL0ZYR3JpYnhqRGxHK1pFRXRnZE1HYTlweE9XME9EcWF6VVUwb1UxU0tW?= =?utf-8?B?MFdxUEJNWmd0VWkvUWNSUXFic2NFck50bDZJcXJGV3BSK054RGtMSlovWTg5?= =?utf-8?B?YWtTenhRaURrT3pqYTFNd2lQZHE2RGpTZXVHMHdEUERNcVVoeWNTUjFkdnZX?= =?utf-8?B?NVNYQ3pNcFJJV2UvM0lDSGFpVUhKYjgvNXh3dGIwWWFRYTVvcnZrNW9kcWxJ?= =?utf-8?B?NnFrS0VSSVdPUnlJUnNDMk8xVWc3OW05TTh0Q2lHQlZLZVE1cHEwT3lBUUlo?= =?utf-8?B?eHJkSG9oZnErWjIveWY1K3JyOXBicjZ6ZmRpMGlReXhwdVdWSVhTa0hMSjFa?= =?utf-8?B?TzZ4MDB0WlNLZWtSaythR3ZNVFdOanRnSWNqWFlvYUswbTZacEhMdGxuTEx4?= =?utf-8?B?a3FuaG8zVUdpYWYyZGE1Z0R3bXNldVdldEQ4dk1GMWVqSTY4QklGL2JJREhY?= =?utf-8?B?R202T01KRkVIbUtoZnJqeTZ4WXFyb2ZkbGJFMCtSOTdPZ1praFlRV0hwamVC?= =?utf-8?B?RktlVGV6ZytSYVZ1Y1JMcWZpY1VFaEoxRDlzK2tSWGFXelZoVFJ0NnZSUXVo?= =?utf-8?B?SzVUQSs5Zm5zaEhiS2JYWFp4YWxLVldDQjdQMnJBWUFxc2VvNXBJRHh4Y1dj?= =?utf-8?B?ZVd5N1pzL2hRSGdSSGlMKzZLbWJZM0VTTTZvK0JacHhRNnR1WU55R0hLMmJF?= =?utf-8?Q?S1RT0hO1zSf6tcDczLzCn6VCiiVJSRmErOX72ky?= X-MS-Exchange-CrossTenant-Network-Message-Id: 509c5b08-113c-4e30-cba3-08d972ba8eba X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Sep 2021 11:19:43.4875 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: hgAZm0I3ZKpnUbdJOncACtXe1FUan7ZUNRPpYSNDTTSOKgF2r2+dhjJ1ye7stszNXjVvdOjTi3l8Zu6uSoLlMwSfV4blHupozss/ffBJfCc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5663 X-OriginatorOrg: citrix.com On 08/09/2021 11:43, Jan Beulich wrote: > On 07.09.2021 18:19, Andrew Cooper wrote: >> The opencoded legacy Memory Disambiguation logic in init_amd() neglected >> Fam19h for the Zen3 microarchitecture. In practice, all Zen2 based syst= em >> have the architectural MSR_SPEC_CTRL and the SSBD bit within it. > Don't you mean Zen3 in the 2nd sentence? Otherwise there's a missing > connect between both sentences. No.=C2=A0 Zen2/Rome has MSR_SPEC_CTRL. The point is that Zen2 and later shouldn't be using MSR_AMD64_LS_CFG in the first place.=C2=A0 I'll tweak the wording. > >> Implement the algorithm given in AMD's SSBD whitepaper, and leave a >> printk_once() behind in the case that no controls can be found. >> >> This now means that a user explicitly choosing `spec-ctrl=3Dssbd` will p= roperly >> turn off Memory Disambiguation on Fam19h/Zen3 systems. >> >> This still remains a single system-wide setting (for now), and is not co= ntext >> switched between vCPUs. As such, it doesn't interact with Intel's use o= f >> MSR_SPEC_CTRL and default_xen_spec_ctrl (yet). >> >> Signed-off-by: Andrew Cooper > Reviewed-by: Jan Beulich Thanks. ~Andrew From xen-devel-bounces@lists.xenproject.org Wed Sep 08 11:44:40 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Sep 2021 11:44:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.181798.329107 (Exim 4.92) (envelope-from ) id 1mNw0D-0001Ed-CU; Wed, 08 Sep 2021 11:44:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 181798.329107; Wed, 08 Sep 2021 11:44:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNw0D-0001EW-9I; Wed, 08 Sep 2021 11:44:29 +0000 Received: by outflank-mailman (input) for mailman id 181798; Wed, 08 Sep 2021 11:44:28 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNw0C-0001EQ-7C for xen-devel@lists.xenproject.org; Wed, 08 Sep 2021 11:44:28 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNw0C-0003dY-3k for xen-devel@lists.xenproject.org; Wed, 08 Sep 2021 11:44:28 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1mNw0C-00027L-2m for xen-devel@lists.xenproject.org; Wed, 08 Sep 2021 11:44:28 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1mNvzw-00032p-8M; Wed, 08 Sep 2021 12:44:12 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=JDArQN2Fi8ETRRDga4y+qn+1GcKXiOotD1ShURS9fiU=; b=IzCMJz7hDCG1qM3Wf7K4wE09pV GFw8W0j9XPOgV0PdRYRbB6PpYsuirC7+cmon39IsfsU8csIQPcbqo7tVpHMQAcaCzyfxlY0g+iSTZ IKVIK5KKb+vNGLVO9lM5l7bRlDqbep3kmSZjVyPddTZWUloheapGEWqqZNdECfdg81Is=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24888.41483.762554.171248@mariner.uk.xensource.com> Date: Wed, 8 Sep 2021 12:44:11 +0100 To: Anthony PERARD Cc: Jan Beulich , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Roger Pau =?iso-8859-1?Q?Monn=E9?= , "Tim Deegan" , Subject: Re: [XEN PATCH v7 05/51] x86/mm: avoid building multiple .o from a single .c file In-Reply-To: References: <20210824105038.1257926-1-anthony.perard@citrix.com> <20210824105038.1257926-6-anthony.perard@citrix.com> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Anthony PERARD writes ("Re: [XEN PATCH v7 05/51] x86/mm: avoid building multiple .o from a single .c file"): > On Tue, Sep 07, 2021 at 08:14:14AM +0200, Jan Beulich wrote: > > Hmm, when replying to 00/51 I didn't recall I gave an R-b for this one > > already. I'd like to restrict it some: It should be taken to stand for > > the technical correctness of the change. Nevertheless I'm not really > > happy with the introduction of the various tiny source files. I've > > meanwhile been wondering: Can't these be generated (in the build tree, > > as soon as that's possible to be separate) rather than getting put in > > the repo? > > Do we really need to generated those never to be change tiny source > file? Do we really need to make the build system a lot more complicated? I'm not an x86 maintainer, but my 2p anyway: I think the handful of tiny source files is probably better than some contraption in the build system. Much less risk of something funny and confusing going on. We could reduce the number of copies of the same text by making the copies of guest_walk*.c in hap/ be symlinks to ../guest_walk*.c. > Can't we commit this patch as is? What kind of issue is there with those > tiny source files? Should we add a warning in those tiny source files, > something like "No modification of this file allowed, it's part of the > build system." ? I don't think we need any such warning. No-one is going to take that tiny file and try to edit it to put functionality in it, and if they do it will be spotted on review. Thanks, Ian. From xen-devel-bounces@lists.xenproject.org Wed Sep 08 11:59:04 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Sep 2021 11:59:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.181803.329118 (Exim 4.92) (envelope-from ) id 1mNwEF-0002xc-Ly; Wed, 08 Sep 2021 11:58:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 181803.329118; Wed, 08 Sep 2021 11:58:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNwEF-0002xV-J1; Wed, 08 Sep 2021 11:58:59 +0000 Received: by outflank-mailman (input) for mailman id 181803; Wed, 08 Sep 2021 11:58:58 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNwEE-0002xL-Bn; Wed, 08 Sep 2021 11:58:58 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNwEE-0003rv-3a; Wed, 08 Sep 2021 11:58:58 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNwED-0003xD-Nl; Wed, 08 Sep 2021 11:58:57 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1mNwED-0004ut-NG; Wed, 08 Sep 2021 11:58:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=bqj3Pxw7uKK0Dpen6uKCu2Qw66bfenQpSvzRcA97Vgk=; b=y0rRAw/lEBWDfukNoDZ1/5Uvd+ w8Mseuc7FZQyeKhM275N/mfjZ2PqyaAqQqkpNXHMEwbP/L/dGnfQNCiFJz1MJ6FTwYr60fx8ziA46 M+ng0sF6o+rPN/ryeJzF3knpZ2SKXooR36h/wyRZjqnB6WvyWFUHDXGAFaXdYwmg0a44=; To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 164878: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=abf7aee72ea66944a62962603e4c2381f5e473e7 X-Osstest-Versions-That: qemuu=a61c30b8c8c3c8619847cfaa289233cc696f5689 From: osstest service owner Date: Wed, 08 Sep 2021 11:58:57 +0000 flight 164878 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/164878/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail REGR. vs. 164874 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 164874 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 164874 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 164874 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 164874 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 164874 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 164874 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 164874 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass version targeted for testing: qemuu abf7aee72ea66944a62962603e4c2381f5e473e7 baseline version: qemuu a61c30b8c8c3c8619847cfaa289233cc696f5689 Last test of basis 164874 2021-09-07 12:37:56 Z 0 days Testing same since 164878 2021-09-07 23:39:10 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Alex Bennée Christian Borntraeger Cornelia Huck David Hildenbrand Ilya Leoshkevich Jared Rossi Peter Maydell Philippe Mathieu-Daudé Stefan Hajnoczi Thomas Huth jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-amd64-amd64-xl-qcow2 pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-xl-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git a61c30b8c8..abf7aee72e abf7aee72ea66944a62962603e4c2381f5e473e7 -> upstream-tested From xen-devel-bounces@lists.xenproject.org Wed Sep 08 12:01:53 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Sep 2021 12:01:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.181810.329131 (Exim 4.92) (envelope-from ) id 1mNwH2-0004dt-Dr; Wed, 08 Sep 2021 12:01:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 181810.329131; Wed, 08 Sep 2021 12:01:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNwH2-0004dm-Az; Wed, 08 Sep 2021 12:01:52 +0000 Received: by outflank-mailman (input) for mailman id 181810; Wed, 08 Sep 2021 12:01:50 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNwH0-0004dg-RY for xen-devel@lists.xenproject.org; Wed, 08 Sep 2021 12:01:50 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 8bcd4f9e-109c-11ec-b14d-12813bfff9fa; Wed, 08 Sep 2021 12:01:49 +0000 (UTC) Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-ve1eur02lp2050.outbound.protection.outlook.com [104.47.6.50]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-7-EpyZuIrHNUGasRVrBYmQiA-1; Wed, 08 Sep 2021 14:01:47 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR0402MB3934.eurprd04.prod.outlook.com (2603:10a6:803:1b::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.24; Wed, 8 Sep 2021 12:01:46 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4500.014; Wed, 8 Sep 2021 12:01:46 +0000 Received: from [10.156.60.236] (37.24.206.209) by FR0P281CA0074.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1e::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.6 via Frontend Transport; Wed, 8 Sep 2021 12:01:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8bcd4f9e-109c-11ec-b14d-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1631102508; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UG2AjnDcsmumIq1uOUgi3tNiDykLsZsmE9tn4WXrbnY=; b=Tj9qRJJTwa7nXMRN/PsTOh+HYlGHXcPQIH3gZ8q2wODdGy/P+CEz/E0NQjfObd7ndmwf+l QA977aeGspxNviOfN/bE0xiE/aZFqbMs2lDAMnIEZxyyGQhAMpAc5+bepZgB1FLRlkNDKw duUQExqJ0z9wrS4Wsa2U4IVvIaq6TmU= X-MC-Unique: EpyZuIrHNUGasRVrBYmQiA-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CMplft3RF/qv2zfzrZG9BISwNk9psfoiMDxyjQNgzd32ZmLLxBRFhQFHcfuytoCw7m8qNsOICjVc/P1D5fOzOks8uU2xXhWG39EqwAVZnZtQ0/X5sZAyCLcfhS6HwSu8qpAydQCLb/iAL3w0fKcPYMAOxy46M6+c0Bk0YwMaBIcTC8a/A8EsnmNseZR4pgu8WVcKi2B5RAjtViYl91l8VcdwHFEer/Ki9WkQRFlLb/T6JAJentpEXVhWASbt2LvvQKYDOYuY7jK36qiKs4JxoowxPrRkKBzvWynplWE0Fb+/sWfYqKZUsfZFUF2NFD7nd/qlNR+Lti+H2GyvjNaeeQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=UG2AjnDcsmumIq1uOUgi3tNiDykLsZsmE9tn4WXrbnY=; b=dGhhtLCGDj55ld7Vf4r4w8y7UgzkepZhKMdjesP94Wxg3pyZjIEFvPJZyDq8pWxVbdSZ6iI2D/AviePDJdCmtL3N2KKLa1JLnRriTP4CVzS1imlhWgqDJdYU56H0Pd4mKBTyZmk8nTG1i3IWOtaiXmf479Kp/34H5209YFVpTaIL2lcgkOS4ZZlu5zMZJVBP7DxN0NAPDYU6DI2ewa4z6YL3Vng6kTS58XLFYdAQ1XtVmN6pSmrQ5nnI4r+QFJi1p+v8/HAli2it7qFyL0xC72j7LkgJZ2e5M5M4A+gP/F7CxQ/ZUp4JROyaPb4kDh/o0ReSq23CzM6kYhwmSwro/Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com; Subject: Re: [XEN PATCH v7 05/51] x86/mm: avoid building multiple .o from a single .c file To: Anthony PERARD Cc: Andrew Cooper , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Tim Deegan , xen-devel@lists.xenproject.org References: <20210824105038.1257926-1-anthony.perard@citrix.com> <20210824105038.1257926-6-anthony.perard@citrix.com> From: Jan Beulich Message-ID: <27874b1a-70cb-e647-d271-93ef12dc40dc@suse.com> Date: Wed, 8 Sep 2021 14:01:43 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0074.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1e::20) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 43cc3789-7638-45b5-2273-08d972c06e3e X-MS-TrafficTypeDiagnostic: VI1PR0402MB3934: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:5797; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: aEem4ObOgpR51fzyBDOoMX0gVHcgBbWvsMJuiqlg3xDjRwAiFieylvQoC5wPeI2Yhjl0GHckSKgkbOKPYYKSuFxS7R2Gy+O4LoxsI0jQjmibhVV1xxDQZqf8T4x6+MVrFM6b52TF8PsxTOcta1+mvXX5UGJ1i1TT5Gd6gZetDwWC0yDwR7v2xKMd7CAQuF4qsuyhwxegyW6Nqb+1kDIUL22vLNdeO5VI7sQB5pblMpyemRMTwSKFYmRCLm2l0rPFn6uIR8u3yVKgKeX4ccs8fDm0mrkprMv0eeQVeDAHyoovaO+woa8FXEYNbFLNEbjmwLfWB1Drj0LCi1gUylETWG6unlDrQZvZo/WfOy/54R8hfTBuslpwntOjWxWQfci1M8rkWhXH93mTZnuBlr755tIbala7f/b2cZvorCBJ94dqRrH4UppPoRQ+aV8M8lAqeGFpeLaNJM+WSo8A2qtr6bk2O6FS47Z0icCTm1rXLYBCEZoIG0Pqg0ICIg6Gl/QXZw8I+v6JOHNhGa1IhnCmT34Qin6pXQAXmCpWA5/4dkTCRYBpK0r/9o3X0/SM+y/Vds1Y2zTPsrsOUIn3fMURPcGoa5MKQun13ZShJUaDtanGu3umyJPE57FBI5j6Q0scLVRni3jdxPEBQTXc7Rt6r28NH6wDzlQ47ziUpbdPOTlUXmWERjVk2PxRd+Vka+TVPRDZ1dN9HxutJ2fFmBOk6oxEL8/YqWekTfT0DcODqypo/hMmD0Ka/mJyyQ7b4SCQxsX2RFaGoU0z8JWceQFJJQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(136003)(39860400002)(396003)(346002)(376002)(366004)(31696002)(31686004)(316002)(38100700002)(16576012)(2906002)(8936002)(956004)(2616005)(6916009)(66476007)(478600001)(66946007)(53546011)(66556008)(186003)(26005)(83380400001)(7416002)(36756003)(54906003)(5660300002)(4326008)(8676002)(86362001)(6486002)(142923001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OHB4ZnpDUEQ0ZTA5dG1kVWRqQlAzV3ZkdWdFUkwxWGdoT215cm95dk5naDVm?= =?utf-8?B?dGtnMHdndkNZTUs0Yi9wTEJ5VjR5VXA2K0lGdm1OWWZrakY4RnRGT3FFSUZV?= =?utf-8?B?YzFWdWNERGcrU3ZaVFBPcHR0RVNIOGRUTW5TN3cwbVM0cnV5QnBSY0FMMXB1?= =?utf-8?B?MmJEWnFtSlFsSm0xVDZ5L2E3SEViNmZVc0Q5Q0Z1Z3RiVmFiWDgwRVlnZjNL?= =?utf-8?B?YlNIcm5YTzF0cElZU0lrZ2s1QWNpWXNsK1IrL2c2SlN1QWswRzNtdzk4TElC?= =?utf-8?B?THM4MElkbyt6eSsxcVZVNFRTQ04rRU9vdGVZSHFlZDBvdDVyNVJrU2VocjdC?= =?utf-8?B?SUtsbWhRQ20wdlFxYXpDODZNSER3ZlRmSFhKeGFiejMzaExpNUtGVU9GVFE1?= =?utf-8?B?TGpiQjFtTVZLSFRIdHNTbXRQWG5oUnM5cU9MVTF6Wi9Jc0x5TU51SWdnSXNX?= =?utf-8?B?djJ1QjJrcmlhMmZodzRlSm5YSFRwdU0wT0NYNUJIQmVzT0Q0NUJ6OHpBbnRo?= =?utf-8?B?NFpvVnRvUCtEYWdVTTJIK0FoNTdUbDNNbkQxdTNnc3ptdW0xWTdKQVhXdWZp?= =?utf-8?B?VHlEYmh3NnhsWndjZDB3NS9SWURtYzBweEs2dHhNWVd4NmFNZmY0cU5BTlZK?= =?utf-8?B?SC9qbmp3Y2U0ZWRwU2I2SHh5ZjRxYlk2VGJpRzZSS1ZoNkVaMi9GYWV3MjFH?= =?utf-8?B?ZWUyMElMc2dxS2ZhTmtmL2krRnIxL0dzbjc5SnBSQjVncVM2WEE0NFFHQjVt?= =?utf-8?B?OVRrVkkyOFlublZxb1dsTHJveVBYbzBPV3hMSGtMQ0RIaVdWWXl4eWJnNWZj?= =?utf-8?B?WU5zMnpjLzBGUGV4OVhsRXl5UGJZcytCNmE5SVdlck5CMTNuRzA3UnVheG1M?= =?utf-8?B?RGVEdDlRSG1UeVR4WVR2RkZtTStIWGE4VG5JcjZrMDl6bmtLdGcwenpPbElZ?= =?utf-8?B?Ui81R2FpKytRbU1Nbm1qanBYck1yRXFoaDVJVVEzTnRxU25yMHdkdHFIMWpS?= =?utf-8?B?eGt3ZDNKR1U2ODA1bWlURlJmSFhqMEMxM2RMSVJkOVl5SkJJeTIyOFg2N2t0?= =?utf-8?B?QzFJcENsSjZvdjZaYWYrMHhTUDAvSGJmOWtUWTlyQ0FodFB2WlFYNHQ4NU9t?= =?utf-8?B?enZuWmN6SXVwTHlENUl0ZUl1TnVYaXNNODBGMEJFQ0JvTWJ5b29qUTRTa3c2?= =?utf-8?B?bFZzamlvdzFvUnc4VzM3NEorL3l4S3ZReUtaUU5HUkROSHF5S1B0YUFoaEhJ?= =?utf-8?B?anJpcEEyS0pnaXh6VExuS0VzYmg0QW8xRTVOVWsxUnVkMWM0K1MxYjV5Ymlx?= =?utf-8?B?dDZnWkRBQ1ZmWEp3Y205SWhZS05OK1Q0V3cwUnJQMDFqT04xbDhNUUFmdkFk?= =?utf-8?B?WWtVMzVQc1ZhZ1k3SHNtWTNnM3pUVTNKWHkyUU1hekNqYUovbS9MN1lGZ29j?= =?utf-8?B?MTBXRTJCZ0VpcEVTQVUwSTNyWUw0SWE2SXBFRHRHSTdHV2dmSlZQWDNtcENP?= =?utf-8?B?YXNyQXN0N3lQR0FEMjRITzhDRDlVWXZPWUFsRUVoR2o2aWJ3bU1jTmJZcUhh?= =?utf-8?B?eURaeXIrdHA4SXA2UTNyMGlNT0dlOHNZMUk5TXdQRG9kOWJteHBCTy9wSUl4?= =?utf-8?B?WnVwRnVVY2hkVHkwVEp0VXFEb2cyK0dHM0x4RW5yb1ZFU21hS3gzVUxrMUJB?= =?utf-8?B?M0JrYnJYNlI3b0FrditnVDExY00zTk1FWlRXNy9HZklha1Z1L2RHSXhCYXFQ?= =?utf-8?Q?sfSW/8k20o+Yuf4Mo4HZlSp6k2R09QzXqapGITP?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 43cc3789-7638-45b5-2273-08d972c06e3e X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Sep 2021 12:01:46.0088 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 02L2npVOEtfFZOxAA1NTzSPDMnv1Z/GWW7qlQZHRXQkb73BYvoMlYPttfOC0OyB7esV+EmkNI7MmYE/1qumlpg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3934 On 08.09.2021 13:14, Anthony PERARD wrote: > On Tue, Sep 07, 2021 at 08:14:14AM +0200, Jan Beulich wrote: >> On 24.08.2021 12:49, Anthony PERARD wrote: >>> This replace the use of a single .c file use for multiple .o file by >>> creating multiple .c file including the first one. >>> >>> There's quite a few issues with trying to build more than one object >>> file from a single source file: there's is a duplication of the make >>> rules to generate those targets; there is an additional ".file" symbol >>> added in order to differentiate between the object files; and the >>> tools/symbols have an heuristic to try to pick up the right ".file". >>> >>> This patch adds new .c source file which avoid the need to add a >>> second ".file" symbol and thus avoid the need to deal with those >>> issues. >>> >>> Also remove __OBJECT_FILE__ from $(CC) command line as it isn't used >>> anywhere anymore. And remove the macro "build-intermediate" since the >>> generic rules for single targets can be used. >>> >>> And rename the objects in mm/hap/ to remove the extra "level". >>> >>> Signed-off-by: Anthony PERARD >>> Reviewed-by: Jan Beulich >> >> Hmm, when replying to 00/51 I didn't recall I gave an R-b for this one >> already. I'd like to restrict it some: It should be taken to stand for >> the technical correctness of the change. Nevertheless I'm not really >> happy with the introduction of the various tiny source files. I've >> meanwhile been wondering: Can't these be generated (in the build tree, >> as soon as that's possible to be separate) rather than getting put in >> the repo? > > Do we really need to generated those never to be change tiny source > file? Do we really need to make the build system a lot more complicated? > > With those tiny source file in a different directory to the main source > file, we need to add "-I" to CFLAGS. (source tree vs build tree.) > > I don't like preparation phase, I'd rather do just-in-time generation of > those tiny file (if we really have too...) as to let make organize > itself on when to do things. That mean, extra targets on how to generate > the files, and telling make that those would be intermediate target > shouldn't be deleted to avoid the final object from been regenerated > over and over again (I'm not sure why the rebuild of tiny source file > happen when they are intermediate, maybe because FORCE prerequisite on > %.o). > > Can't we commit this patch as is? I'll consider another time. > What kind of issue is there with those tiny source files? To me they're ugly and their presence is at least mildly confusing. And apparently I'm not the only one thinking that way, or else such tiny stubs would have been put there right when introducing these multiply built sources. > Should we add a warning in those tiny source files, > something like "No modification of this file allowed, it's part of the > build system." ? Not sure this would make much of a difference. Them getting touched later on is not a primary concern of mine. In fact once they're there, I don't see why they couldn't be extended. At least in shadow code there might be functions which could live there, reducing #ifdef-ary. Jan From xen-devel-bounces@lists.xenproject.org Wed Sep 08 12:09:02 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Sep 2021 12:09:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.181819.329143 (Exim 4.92) (envelope-from ) id 1mNwNt-0005Lv-6f; Wed, 08 Sep 2021 12:08:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 181819.329143; Wed, 08 Sep 2021 12:08:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNwNt-0005Lo-3C; Wed, 08 Sep 2021 12:08:57 +0000 Received: by outflank-mailman (input) for mailman id 181819; Wed, 08 Sep 2021 12:08:56 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNwNs-0005Li-K9 for xen-devel@lists.xenproject.org; Wed, 08 Sep 2021 12:08:56 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.111.102]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 89de3fb2-109d-11ec-b14f-12813bfff9fa; Wed, 08 Sep 2021 12:08:55 +0000 (UTC) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05lp2106.outbound.protection.outlook.com [104.47.18.106]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-18-KSshkRI8OLC-HnKJ5vqB0g-1; Wed, 08 Sep 2021 14:08:53 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR0402MB3391.eurprd04.prod.outlook.com (2603:10a6:803:3::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14; Wed, 8 Sep 2021 12:08:51 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4500.014; Wed, 8 Sep 2021 12:08:51 +0000 Received: from [10.156.60.236] (37.24.206.209) by PR0P264CA0118.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:19::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14 via Frontend Transport; Wed, 8 Sep 2021 12:08:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 89de3fb2-109d-11ec-b14f-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1631102934; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LsHY1ULNA9PA1Ool8eII2TD7Ugxn9D41f/uPUTi33jM=; b=YWftrmIP4di7d4Fd536QsXelGACMctDixAInHCegIy7jMd91JkPh+PVdASfzlXtq7v+luS OGgKZNRe+JsQtzcj1HrxWI7Syma5Oo16FzHgtl4tZA4GoYfEfDz99dHoOwiV+YMWnq703O bp/A3vIxy/qkxxbaOQP4jl4dbZFyD80= X-MC-Unique: KSshkRI8OLC-HnKJ5vqB0g-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nJihRneq+s3lDAE3y6DluchPZzJYlXMOZIrjvgorEk0u6zLxjS/CDatI+zgIMnfS9NGXIrwee6TD++eftth2SiHIOjxPKtqnHIzfji+zJl/humVISBWlo3bVwe1ZwWBXo1dsAO2Cgb1RoXcGp9+4Fj1Rl5c/UM/EMp8Fs/M4KiJ722RBjUq4aFSFU+wo40Gz7H03KGSYTySIydFF2SZnuNDi1mnUBo2TRYt2oROoXvXE1FFo/t2yLx7fSQLwWAeWjjLRh+PbIZ/UuaHZ5mAGJ3kjpKU+aymvMlqXIfXYPUTpxuAVihNyUr698jOlzCklXLu97Q6+vtfNhqSzu2KG/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=LsHY1ULNA9PA1Ool8eII2TD7Ugxn9D41f/uPUTi33jM=; b=PN6I8pMpZYuM7TTVEfrbTomjKU82d7f+3MxVB5y6yTyA0NJHNMcr4ASap5op0MW/d0YwZKUeGokwfB+lJekbbTv8L8ENbeQBVcgCQeMcQ/5RjpxEvO5gxHHEeyHxO9ItSsl1W5XsUm6lVzEDF2jOyibd5QhRaotsE4PuFrf4VpTaOh7ZskKBPRXR/NswEE9mt/isLd07ed1/BLj43knaxqMVwvhySMk/QXqmCSWHJ5TsHe00wuQMdbdkG3+4Ctlr/NPFXjind6k66T0J/4v1TtZSNqNLw1XdPaMU6qQJWwQucPZ+h0La9E/8+qMRlE/TXSTUgHci1vi0NcFSqPJMEQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com; Subject: Re: [PATCH v2 2/2] x86/cpuid: Detect null segment behaviour on Zen2 CPUs To: Jane Malalane Cc: Wei Liu , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Pu Wen , Andy Lutomirski , Xen-devel References: <20210908081945.11047-1-jane.malalane@citrix.com> From: Jan Beulich Message-ID: Date: Wed, 8 Sep 2021 14:08:49 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: <20210908081945.11047-1-jane.malalane@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PR0P264CA0118.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:19::34) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 85a39ec5-6f67-48b0-f35d-08d972c16c16 X-MS-TrafficTypeDiagnostic: VI1PR0402MB3391: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: NeNUTTPQApBE+kcj+NU3afJ7RF1TftV3M0cyLgdLNj/Jd/WGAZufSvOfS531O4o+xdymlO77+fZlfxS1aeEd01eIYJDDhZYRoGfSv3Ni/yb0z6M5MIpFpmX8QnB7oYtyOOl/3o1+3U7KQOdf5871GYfxsdelOXOnxOtqh93mj4Qxd+wEvS6kq0RNGwKZ0ZhVEZ4DgEHCZoVDPbl6VEnsNLn3rOejULRZorf7rGUNCDXS1X3CsipHBO3NS9+J6tKpy5QSZUHe1ZJfYFHm4i1pyNBk2gWyT9Y29WPbHZCUhKjSJEfFQUdbcHM7EdrDICkUMSoXcf3qjPBA2mfllghHXAx19hYaAK/UePIAQpSvsbdYc4fNrbMJCfeIDwEOTOKGidyXk6BPoLcLKUh9Qj4qBhgiAF3ZdivzgJnFOl91NfR90jfPUP0SR7Wakv6pEV69ddX3N1D65k2pOg8jxWU4HKJf8vl5H3g8zwAflimYUGgLCSI2/RLUSztkbcmfEIhl0XYW8vHxhf71sWqTi/yf+IHLRxFgjtsNTdTi9YPtayfIT6jV0q/8NslRXXh4gHDqm/XUCIsCAcyaQYM/gxPz765Kf7019MeCMUgO7mfs6HnnAEP/ZdQb3pjX67NlqqWE7vwVlUDvHqE/cBkkEmRClE2w2GBwok6rd/JE/iXVFA6SGc1ogvHiR7vlFCRuFay5dOAPS0lrOYC7aY76ODXaaKdaYww5fme5N+QA3D4ba6W7qQOGNahmD2bmShlQubfQ X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(4744005)(54906003)(36756003)(186003)(6486002)(66476007)(8936002)(38100700002)(5660300002)(53546011)(31696002)(26005)(66946007)(4326008)(31686004)(8676002)(66556008)(86362001)(2906002)(2616005)(956004)(316002)(6916009)(508600001)(16576012)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WFNtVkxUeTBFZjVsQWpuaCt6Z2Noa3dWdThNQVNldlorb0Q5ZmZmNTlITDMz?= =?utf-8?B?cEEwREp0ejlkQVU0d1hsL3l6dWhVcmsrUWV6bGtrc1VieHNhK3ppNW1jNVdY?= =?utf-8?B?VXNWY2IzZDU3SHNUQXpELzdKcVhUTnRUb2RLc1JpaGtLdGNyWTdDd0tqemdp?= =?utf-8?B?MnFQTGZEZHk0T1cyYjVYWFR3RTh5Y1NZZkhWVzhJK2toaEZaSFlkU0hjRCt6?= =?utf-8?B?WUw5Q0tkeFZrYWk1VGo4Zi9lbkViMWFnaTAwZXRBWTFPeWd6MnFkeE1jTFFT?= =?utf-8?B?VG91NFlLTzQyQTBlYlNjM3NOVDhsVXl1ZExGS1BMQmtsZWRidEZieWVMZS8y?= =?utf-8?B?OXNLTkxua3RJZWtPd2Mwa21YZ2VJZUtxRmhpNnc4VTVxRURvTklPek5IWHM2?= =?utf-8?B?L0poaXNFVmVucXlTR0Z3THYzTlAySnJIOEYxcU40STBqMG1lUzNDZ3ZmK25Z?= =?utf-8?B?QlBaU25CQkJXbUgxR01zSS9CZlVBQVhOWmRzdmdzTWprSXVUVkphUXoxYlBD?= =?utf-8?B?cGt5SFlRNWJORXVJL2ZGc1E0Y1dnME1vVXRYQ3dBMEtkL2IrenFRYnR0Zjc4?= =?utf-8?B?QWJ6T3prRk52c3oyTHFhbzA4U3NNRzFhNGhGQ3ZjaFNWRkhieS84Y3ZTOGxU?= =?utf-8?B?UGtIVE5ENzdOUWZSZHk3REJscnEycVFpbUk5R2xpM0NOSmhKa0VseXFoYlFS?= =?utf-8?B?YTI3dEVNSmhSZFE1RGRRTmZxdEdJZ0xER3hCR0VSdlF5cEJRTkJ5NkRLeFNr?= =?utf-8?B?UEJla21OUDU4VTRGT0I2MEo2ZTBHUkVUcEJFWFpCMEtZdE4xUmhIR0UzYXhG?= =?utf-8?B?UHBqakMxb3diNE1FcjMwWnZxSVNmUnVlVGgyUUZpTGh6WTQ4YnRZbG5QL0xj?= =?utf-8?B?N1QzUENMK3pWeEZpb21BOHlxbE5WOVJ2TWhvdnh2dHNQUU9jdUVjUUQzSVpt?= =?utf-8?B?K1lRT2pqbTR0QUxHd2NVU1BhZEVMMWoraEl6b2psU0JMVHF4UEloWnJ2SUhS?= =?utf-8?B?c0o0Z21SbnBjOW9TY2h0a1prT3Z2dDdTMHNFeEhTRDhlTjA4ODJsNld5MXl6?= =?utf-8?B?cEtyb0hxOW01Nk8xYlVGZDFyUWxYbnprYk8yVS9oTDJqeE5ZMUdJRUlpZ24z?= =?utf-8?B?UFd2ejB4VkNqSXlFaTBZa212MUVYcUVlVElzNDlFSjVwL1VSclNOOE8reFQv?= =?utf-8?B?WUNqdWkxT3NldDd0MmVYTk1SQnEzcXBuc0FyWk55SVovdHFQMmxoY1FUZUtP?= =?utf-8?B?RUhhWWpyS2l3eTdra3I2dlBPZG1BOXc2TFMzWDlGaXdLWkl0bWJ1YzlDRXcz?= =?utf-8?B?alVwVHN6MTFJaUxDS3FpcFdsd2V2bGxOTy9kNC9JOXVPSmtTV0FaS3BCY1li?= =?utf-8?B?TTMrQ0x6Z0pPcFVwYmJGZ08rQmlxQnRuSDBXRXZ0a001Vkk5Z0NFdEhkTE9j?= =?utf-8?B?VDl4TnQ1bmVlY0dBYVpMV1ppUUZGNElMRGdjNUtlL240T3pUdTlSWTU3VVVt?= =?utf-8?B?L1J3L1M3Y0lDQWhPZXJQWUZXcUdFbTVwbkxucDA5Yld1a0ViUDJnOXJNdzRF?= =?utf-8?B?ek1SRlNmaGY2RUFzRXBtY3UwSlpGUFBMc3BOaW9TeW01Qk85Skp1VjNOTVN5?= =?utf-8?B?Rk0yVHVFbmFZOUswamV2d3ZLRDhMRFBPL2Nkd0NLd2Ixci9kTW1IanErbWRv?= =?utf-8?B?R0xSejZjTVpHSWhHNkVyaTlZR2RiL1BYMS9QZHo2UFo5M0VIN3hKSysrMDRa?= =?utf-8?Q?EStC87hSkb9gtXxkH32cpU6IO6ZLL1r8tOznUJV?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 85a39ec5-6f67-48b0-f35d-08d972c16c16 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Sep 2021 12:08:51.8513 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1UY2KpoZxkmIJvWDigDehxM364KpxmMNd2zOvvDRn7I9+GH5kjFESdJhhWyWI8LW9N1bdPBta3zFtRVIVqvSXg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3391 On 08.09.2021 10:19, Jane Malalane wrote: > Zen2 CPUs actually have this behaviour, but the CPUID bit couldn't be > introduced into Zen2 due to a lack of leaves. So, it was added in a > new leaf in Zen3. Nonetheless, hypervisors can synthesize the CPUID > bit in software. Considering the prior model checks, I understand this isn't all Zen2s? No matter what the answer, I'd like to ask that the first sentence start with either "All" or "Some" (or something along these lines). Which is of course fine to insert while committing, so not need to send a v3. > So, Xen probes for NSCB (NullSelectorClearsBit) and > synthesizes the bit, if the behaviour is present. > > Suggested-by: Andrew Cooper > Signed-off-by: Jane Malalane Reviewed-by: Jan Beulich From xen-devel-bounces@lists.xenproject.org Wed Sep 08 12:20:24 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Sep 2021 12:20:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.181828.329153 (Exim 4.92) (envelope-from ) id 1mNwYr-0007n2-4N; Wed, 08 Sep 2021 12:20:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 181828.329153; Wed, 08 Sep 2021 12:20:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNwYr-0007mv-1H; Wed, 08 Sep 2021 12:20:17 +0000 Received: by outflank-mailman (input) for mailman id 181828; Wed, 08 Sep 2021 12:20:16 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNwYq-0007mp-0w for xen-devel@lists.xenproject.org; Wed, 08 Sep 2021 12:20:16 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id d2a7abbf-a19d-4ad8-9e76-39e7701f3a82; Wed, 08 Sep 2021 12:20:14 +0000 (UTC) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05lp2169.outbound.protection.outlook.com [104.47.17.169]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-1-vTq9rxmwPEuZ5Swfl3pAtw-1; Wed, 08 Sep 2021 14:20:12 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR0402MB3535.eurprd04.prod.outlook.com (2603:10a6:803:11::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.18; Wed, 8 Sep 2021 12:20:10 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4500.014; Wed, 8 Sep 2021 12:20:10 +0000 Received: from [10.156.60.236] (37.24.206.209) by FR3P281CA0065.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4b::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.6 via Frontend Transport; Wed, 8 Sep 2021 12:20:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d2a7abbf-a19d-4ad8-9e76-39e7701f3a82 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1631103613; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CJNVwzYym6eiXmkVEWFw5XalOdBRLFERy32pUmqqaKU=; b=Q1/uisIDEIJuNKmPnulTL8/2K7tKUZsoUFajanfSCRpMhtJqwnJGzBCcZueUBicoMPb77b 7VMNMJH+LIGC2iX4tndT8zDytwHnK/MjClnckU1DZwembFZL1gSCyWoo6INyTfYCg/uXDj rPViR7DNUe4RdOoVSaN5eqmLlbklKKo= X-MC-Unique: vTq9rxmwPEuZ5Swfl3pAtw-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dGcJX8fOZTqIRSx688p3aB7ULkkl6DZ7fJbWlSj1zyODk99N2TzCcwka5Mnd0XN7uasKr+76r58shHYSgTY9Hqszs7SrnkYW8XWzy9WFkRkLQdLesNbeIGnGJgYnGp/DLbfbusBO8HfqaCfn6pTuNsuMaVlPnLkpfIIZFdOlnNQsjUypJptwcOKMrG4ywh1kA7NguD6OmA1L2hRCcFAKtcE99XnLB/MrFwBQSat4/hFXV3FQopkIItNl3V03UO+/VKUFT5mVsKnBhGdarVYNhrEd3zL53inxi08MCDwb5zrhAnirr3ILd767pRJJoZt3rT7lZ/P1V24RHUA9gtF45w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CJNVwzYym6eiXmkVEWFw5XalOdBRLFERy32pUmqqaKU=; b=IYHghuzRF7ohVhDMS6BzBOVovru3ucv3V2iGjNGyfoK/fK07Yhx+yn+b3nMMdZvIM1X/1yPYkrLjUrCmYnBv6HW5ed/fEfPo59UKliCV1jSEBIbtCJMO+8DSGg4YVfOR7WyTJjBHbPebT4XzIrxHxv1rSqWWPnohfq8PyU24yzWi/Yb3bGkV1yHH0PTRfHVV1DYfebTO2bfw9afqI5OxD9u7pqI9MFu1NzB++8eTPje0Ao75to1MgGvunoh6wpRhECFnZ+AGgZWNeq4EJnAOgXmNqwd0bIuyJFwyr76N9NkTuv5mzNMP2wXYEwNlcIa4sG2aLd+VBnxmxl3DPtQB6w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com; Subject: Re: [XEN PATCH 1/2] build: set policy filename on make command line To: Anthony PERARD Cc: Andrew Cooper , Daniel De Graaf , "Daniel P. Smith" , xen-devel@lists.xenproject.org References: <20210908095422.438324-1-anthony.perard@citrix.com> <20210908095422.438324-2-anthony.perard@citrix.com> From: Jan Beulich Message-ID: Date: Wed, 8 Sep 2021 14:20:08 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: <20210908095422.438324-2-anthony.perard@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0065.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4b::20) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 38c8422d-c949-4027-078c-08d972c300b9 X-MS-TrafficTypeDiagnostic: VI1PR0402MB3535: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:962; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: G6C0Bl6MOu1H/zU0qz7Qikd4dfeQAwzv9Jf3NYDvUsxIycgJXYbsKmeizho2V1EVTL/AIxYRooO+GDznx5tBWdrrLI0RsmKM0marQTiW4vCjn3OC0w0M4y9NtkhJeekd3Ii1ZFYhLYtyqqcgWsPBmW1MqmMpm81tq58UBebOHNreAlDFRC5GeJ4BPTwH2thorigH1QtO4d06puKfyp9zcLpQUsupTQ02/TM229FfmEw7J/9KW7A4545ELuMxB6uuGcKY40HsMwRVSayHdNZaZl89TaQugBE8m7L1o0iEq/9tnA+vB6WudjSrBMUTLHmPK9WuLnpmTnbrUBJGX12bAqtvGku7sNTblzNSKYq4jFnjnVmiF+DSi4HIjhEE9+tTxaDiTuDrofWeS86EzYRO4oxKgMRdZ7WlPm7rBotm6I64tyIf9tw2e6DAuh8qUOv37bz5Ov7DkiyIpYobkL6rDMdog0ma9Aru8X9fvXj5uGkrGS1Exkco9ELNmLGewh21/1qlAruIwsipC27qHQDTWptHjCtKl4BduQ3TqIcnKVkKeatF9BUlQ7eTSdJ5idEC58IwCJP596NayLiQAPYTDEjDjhb61IyTH7QFE5bFik/rFbzm+rH6rdsLoDxs7X6EaJnwWEpa+IvhM7rXkfjeSx/tyMQWLjej7nJGv/7DSFHK092drSWkhbNjJx77ksI9q+tiIxKiTTLynbVSnCDgTGx/0RJyxExFV6z8pBXBodE8yREuwtEvBqZFw9w36jDz X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(376002)(396003)(39860400002)(346002)(136003)(366004)(5660300002)(4744005)(26005)(66556008)(31686004)(186003)(31696002)(6486002)(86362001)(8936002)(2616005)(956004)(53546011)(36756003)(4326008)(2906002)(478600001)(6916009)(316002)(38100700002)(8676002)(54906003)(16576012)(83380400001)(66946007)(66476007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QlZjTEErblNUd1dxcGVlRWpqUnBWQ3kxOXB6ZHFSaktPYlphU2wxUDIwTXJj?= =?utf-8?B?czVaUSt1RU9VNER4dUl6VGZlakRRTjBWRXFpRUdaWTA4Vy83K1Zhb3MyK21k?= =?utf-8?B?bGlrT2l0em9EOGZPd0pxcnhXOWpPSFczaGwySGN6YVkzbkJsVXZDWTk1ZHVu?= =?utf-8?B?dERERGl3T29OTGZCaTl1cWd1ZGZkN2UxRW1YZTdvejUwUEhMUGdBQlNXYmY1?= =?utf-8?B?bDcrQmpXVHJtcVNldGt1YjY1U1orSzVJM1FyQjU3U2x3eTVRTVhBZzR3UWIw?= =?utf-8?B?dXdnRDJwRTI0V0dRbS9NN0E4SStNaTZaazd1cmM1REFkYXJxOGptVDFSWmZR?= =?utf-8?B?KzRGZGVtR2VWN1QwT05IblBkYTNRQ1FuRjNUR1JqSzNVQlpoanZOdzdoZ3RO?= =?utf-8?B?Z0hHOUpBZUU3a1dCYzNucjZxWGtXYk9GTm1Oc3NneTlGeEx2SnVBRURQY1RT?= =?utf-8?B?MlBlV3J2RkIrTllod0Fld05pWXVWWjJ2a2E5REdhY0JHK29HZ00rMy9hYjh0?= =?utf-8?B?amJlZmdmSlRtU1RocXlMSzhmRUdZeFZKUDE0U3liaDlnV3BISDBubnozMVJG?= =?utf-8?B?Q0xVcUh5ZlRDMUJ6VWpIYWdYbHl6MUpsVzF2SmhIcnJRK3JQVzI2KzZnYXRS?= =?utf-8?B?b1pVUjFYM1ZONHRDaXJMRUtZWmhTOWV1WWc0OWlIUHpNUy9yOWxacUhIVDM5?= =?utf-8?B?b0dDYUxrblpaelp2WGNCRGloOHRzWGtydHMvdiszcFVsMTVCUURaY2tBTmhy?= =?utf-8?B?K0ZpcFhZK3ZpYWlsK05WbmwzcW12SFF6eEFuTnZsYzN4USt0V2F5RUNIVHNL?= =?utf-8?B?Z0FPMU5aODlTUCt5RHFGeXFtS3RLTDg5RTJKb3hlUlVqUXZRSWNQcmYxWnp4?= =?utf-8?B?S3lEcjh3bVROQld4STBuYmFmNUNxa3VPbFhTenIyNVZBcXdGdE1sZWhlN2lV?= =?utf-8?B?T3AzWmV2MnZlNUxyWCs4czBPbVBGSHplQXFoRTR6Z2VBN2wwczdiRjY0dUlz?= =?utf-8?B?eS9HNWFuaGVHS2Z3OVlYaE1KNWxRbzNhamI4bzRhWmkyVXVHWGlWdys1TEVo?= =?utf-8?B?dk5KNmJzNEpzUExSd1BFTXZXRVlFeUxEMEU5azJyWmtVcnV0cmpJY2Y1MjVI?= =?utf-8?B?OEd2K3FxKzdMUVV0N2Y3RGtmYThqdjJUa3B4WURQTFpjejhUK2EwWlpza3FQ?= =?utf-8?B?blRpdFZGNGF1ZnlDWVd2SG9HOTZUZ1lVYlp6Q05JSE1ING11Y1dTTGM4REk1?= =?utf-8?B?U243bTlBeUpKRTJJdkdWUkVyTFQ2eFBjKzBjMGRNd2k0NDZ2aGxaQnFsUTh0?= =?utf-8?B?MlNjWStGRE5sbEJQaXFsL0pweEorcFZRcC9YTHF0cWhkZVBoOWdwY3NJREJM?= =?utf-8?B?NXhjOHlSNHkwWEF0L3kvT1lkWndwQ3VaQjhoTVU4YWtkYyswMGVDL0ZxQjhj?= =?utf-8?B?ZTQ3V25oUS94NzFUVzRmQko5Wk0rWEVOVGsxRnI2SWNYUnRzdUFNMUhNRGVO?= =?utf-8?B?YjZsM1k2dEJSTFdZOEdHQ2lPcGRCMWNwSWRyeFhFTEZvUXpCUzIxVlVnQWZU?= =?utf-8?B?OFp6STBucE1pTzhqd0YrS1dYUkZGQUo0Mm5yUWpRRU9aWWpieDVoYWdzNXY3?= =?utf-8?B?RnQyRHg4WGtBNDVxVVR6bGJOeVAxMktMK1Y0TElRd1JHcml1OTMxbUpBQ2N5?= =?utf-8?B?RHhZNHJMOGpOMnl2QjNvTUNpU25SNHlDbHg4MERpZXhhRks3Qml2SWZyV0Y1?= =?utf-8?Q?k3M2gvS9xJVoyNs/DlsIZGcPQHajroeCvhdrun4?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 38c8422d-c949-4027-078c-08d972c300b9 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Sep 2021 12:20:10.7430 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: HYY08AN9YVu8leTHukp62OED9PF/ZJIMhiDHVI7yF3n3AbjYElwvlI2v0YYs/LiKjUgbMzE9tK41k+0Xc4f9Xw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3535 On 08.09.2021 11:54, Anthony PERARD wrote: > In order to avoid flask/Makefile.common calling `make xenversion`, we > override POLICY_FILENAME with the value we are going to use anyway. > > Signed-off-by: Anthony PERARD Acked-by: Jan Beulich > --- a/xen/xsm/flask/Makefile > +++ b/xen/xsm/flask/Makefile > @@ -42,7 +42,7 @@ FLASK_BUILD_DIR := $(CURDIR) > POLICY_SRC := $(FLASK_BUILD_DIR)/xenpolicy-$(XEN_FULLVERSION) > > policy.bin: FORCE > - $(MAKE) -f $(XEN_ROOT)/tools/flask/policy/Makefile.common -C $(XEN_ROOT)/tools/flask/policy FLASK_BUILD_DIR=$(FLASK_BUILD_DIR) > + $(MAKE) -f $(XEN_ROOT)/tools/flask/policy/Makefile.common -C $(XEN_ROOT)/tools/flask/policy FLASK_BUILD_DIR=$(FLASK_BUILD_DIR) POLICY_FILENAME=$(POLICY_SRC) I expect that you wouldn't mind me wrapping this overly long line some, while committing? Jan From xen-devel-bounces@lists.xenproject.org Wed Sep 08 12:27:29 2021 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 08 Sep 2021 12:27:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.181836.329164 (Exim 4.92) (envelope-from ) id 1mNwfm-0000N3-0O; Wed, 08 Sep 2021 12:27:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 181836.329164; Wed, 08 Sep 2021 12:27:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNwfl-0000Mw-TX; Wed, 08 Sep 2021 12:27:25 +0000 Received: by outflank-mailman (input) for mailman id 181836; Wed, 08 Sep 2021 12:27:25 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mNwfl-0000Mq-2A for xen-devel@lists.xenproject.org; Wed, 08 Sep 2021 12:27:25 +0000 Received: from de-smtp-delivery-102.mimecast.com (unknown [194.104.109.102]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 1dbb416b-10a0-11ec-b150-12813bfff9fa; Wed, 08 Sep 2021 12:27:24 +0000 (UTC) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04lp2059.outbound.protection.outlook.com [104.47.13.59]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-9-Kh1UnnC1OVWmZKqCrQgLOw-1; Wed, 08 Sep 2021 14:27:21 +0200 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR04MB4382.eurprd04.prod.outlook.com (2603:10a6:803:73::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.22; Wed, 8 Sep 2021 12:27:19 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4500.014; Wed, 8 Sep 2021 12:27:19 +0000 Received: from [10.156.60.236] (37.24.206.209) by PR3PR09CA0001.eurprd09.prod.outlook.com (2603:10a6:102:b7::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14 via Frontend Transport; Wed, 8 Sep 2021 12:27:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1dbb416b-10a0-11ec-b150-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1631104043; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qbvvTZjgc6qM9fIxlneSsnWKvnclSGDEy1xCwQbgaNc=; b=DWhwdKFnW7t8Bn8C+IDVsG6R51giB0RA54MA0g4zIiVGHexe6Omdmof4Mauc4ubwA6SxFM Mr8GQ03h4mLs5slIkP2KPWmOdnmDxQTseqSj6V2U4B4sz1cJLvvyCIgTpBQW78UVJCc38T uJPEKAedLEIoWe83f7nt8NIiWsVYfIU= X-MC-Unique: Kh1UnnC1OVWmZKqCrQgLOw-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Y7kjz/k9/vojd9aAtZROHUCRXy4eGpsE2V1LpBQyHrONJy3Hzv99c7BrAEyJgfXOnoQCDX86k9cBw8nzTk4DPZzphDI9g6vGEC4p6KdWGmSTF3JZHQqSx5Lusicy/0KCCHdb9EZVfL2o7HZ/NjQvrd7B384BX+kdonxLs4b8wpQTePwDl2WglukD7f/2CM8mr2WztrArHPj/xvEyT71WAPjx1DRcFifqld1NWtmRmwJwd55Sq+/PS57RdCIUUL3cPeyu4KymFbj449NonxQr4RDCJHP2h8T46ihDk4F1iJ9FZJuirsiBVxJyRPAZGSrzKpuXb345DgaPDlh/CATnvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=qbvvTZjgc6qM9fIxlneSsnWKvnclSGDEy1xCwQbgaNc=; b=czu3gQ1Bg2gV/6QZ5LGsTGiVrR9fQZKtQ7U88Q9awiqB9d/i8JXUB+kEZO2N2p3zc+fBtwfFchjEkIHQXq+Dle2jh7O+SFRjXRGB/3PxQzprs1b1NtyH8Wf5CiEwf8S9CV0E3btlQn2yrAD6X3czydT2wIsBUjTvypxHWFv0S3HczOA0EOPtPHqw+5vSyuD/jvJH4JtVCkc4hq4066I/HRH7LmMT+BpW9LPUgUctD7oCs7QD299Rf3yH0zL46sJHtm2L3xyyy3Gzq2A7ysyRGEX/JyXn6biEnkZmigvfPX+HamI1bQjZibSS1j/4iAjQZIVdESjxWKggujxv81D6Yg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com; Subject: Re: [XEN PATCH 2/2] build: add --full to version.sh to guess $(XEN_FULLVERSION) To: Anthony PERARD Cc: Andrew Cooper , Daniel De Graaf , "Daniel P. Smith" , Ian Jackson , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , xen-devel@lists.xenproject.org References: <20210908095422.438324-1-anthony.perard@citrix.com> <20210908095422.438324-3-anthony.perard@citrix.com> From: Jan Beulich Message-ID: Date: Wed, 8 Sep 2021 14:27:17 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: <20210908095422.438324-3-anthony.perard@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PR3PR09CA0001.eurprd09.prod.outlook.com (2603:10a6:102:b7::6) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 336202a8-151b-42e1-0f1c-08d972c4006b X-MS-TrafficTypeDiagnostic: VI1PR04MB4382: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:826; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qu/IjHFTD5aPZyr578Yt9XUCJVKvwz1pVsicF2lH6LGJyE65WJJElI5elr1AMgbHGYHQLanTcW4Cluo5iCHnOWWfMX9E2gpNC6+KpMRGroWwqVXmZNDNMDmlzMuHkB+qijVVFYasfwcc/osjy2DDEmsKpUkh4OBywzufAvXYNMOuq+IkjPagFnMGMHEXHybPVJSbQqAJ+v6+5vKVCKrn4668OV+Fgguc9TmaV1WDiTWjKHJkR70Xg+dVOGsfETbjB4FNOy/GaWWSMCBpr1iVdhwHT+OVAN4GtJIPowIrho8XWClwG/rdQMG+DyaMCkQhqbHiW0frAmWXO238EQTlnIZaZzOCTQg8VxlMrPIUDa0jC7RMOb93XNSwwfKkhLKErA//RfnGQRQYmjsV3v26x+jNcut6UMEMwmA8fujG8K0xKKAK96NSL9XWcTU8I4csHVE3GTqyYFtcUss1/6rMQuRXfow5gqtaKOTMKTosPTZrE6UGPB0Nwwv1mmEDcQUmTFEyet6uINvfdeqqyIsW3d1kDpzY9jzcU3PaSM6hZLNNrW6w71ktswsKcAaz+VVVvyf9ucSGRfme0+cC12o+Z2bEVLueuJfT4dgSEzIXVM1FZoZdEUkncmbBFohQ3EyDnXDDqNAqJV1c5G6rYAle75gq6oiB0HtZL7NvvX22H3naf5eIRu2wFciGo6Xcns7DCyk2mVkAL5wmY6hPOouWAI95JcSJmDk+ZDbLyfRdZDjPxDDHTWblfcMST+CK99LU X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(396003)(366004)(136003)(39860400002)(346002)(376002)(5660300002)(38100700002)(66946007)(26005)(956004)(7416002)(8936002)(8676002)(31686004)(66476007)(66556008)(31696002)(6486002)(86362001)(2906002)(54906003)(36756003)(16576012)(6916009)(316002)(4326008)(53546011)(186003)(478600001)(2616005)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aXhndE1hRnVzNktkZ09qbTJUb1JRTHBuRklKbEV5Rnh6K2lnWExDMnNUdG1o?= =?utf-8?B?eSswN215TlRvaXNXdTMwRjJDRnZhUFpRWGVwOCsxVVhJL0lLbWNmWTNxYUlD?= =?utf-8?B?VE9IT0xoZ21aYTk2RkYrK25RM2ZWZG0zRzhxTWtGZVBXM21FeUdMb3pSSkw5?= =?utf-8?B?VGtyOWpGZHlHNnlCRGsxQmthY01PTXFJY2FsTUI4b3hxNSt3a0xMaENlakZs?= =?utf-8?B?L2hURnJrV1Q5blpHZGNVNkQ2ZDFmSThleUVxbzFDZldIUWJORnhiUWR6aW4v?= =?utf-8?B?V3Z2dUVMUGVBVEw0azVHUmV6M2VMWVMzbUdLZW1Ra1pFUWk0Tnc1T2wreFhE?= =?utf-8?B?Qk1qQVMzSURZcXQ1Nm1iSWVsSDc4UGgrdjFXK2F2SENKVzd3T3owL2RTZVNz?= =?utf-8?B?TldLSE52WWJwRTJXTGFjd25JYkVpSGhrMWxjc2hPdko0a2JEMnBFU3BEblZw?= =?utf-8?B?YjcxQlErcmJaeGRSQzFENFhXdjR0M0ZkMnRzdnJOell2a2xuL0JPdk9aMW1p?= =?utf-8?B?QWZXSHhvVU85Z0I3dFFOSWxmT2xBMko0T090VUtTaG82cklkWWZ1N0tiY2JU?= =?utf-8?B?UWVKY2JmWG5sRkI4b2d6MW1QRVROUE13bDNtZFZRSXpzNHB1ZS9CeDhzWkQ1?= =?utf-8?B?WXJzaXNpNFM3M1NGSStsUVBoQ0JsRWNvSVMybGhjUVNRYjlSUkhJSWw3Mk1O?= =?utf-8?B?b2FnMEk5UnlLRDIwTlF2RmpVZjAyUVJZMVpRcGJwa0R4emd4a2swZUMxS2tw?= =?utf-8?B?UkMzM2lONVhFdzFvbXdlbVhlYW96Sm9wajJ4TkhKSTc2dlJKMkVrK0xpR2to?= =?utf-8?B?RjVmL01NUGRTcTdJaVo2cjJHUE5uTWpvd3RnamNrOXpIT0NGUGU5RC80Si9i?= =?utf-8?B?eDFOaCt3NkVic1JyZVVhdHpBOUJhVzlKTmhob24zamRORG9Gd2xyaHpxL3dk?= =?utf-8?B?UFNzcDdxZ1FHZ3lKUEd2SVJkTDFWSGRLMFZUVml6dmNvYjZHYVE3UXZmMUFD?= =?utf-8?B?SSthWTNMZWlkeWJwSHR1bnpUVGxUT3dPb1BtMlVjdlFrRHpnMmgyelBTQmxF?= =?utf-8?B?dW0xYk8wSkNiTE45VWdjOHM3Rys1L3Fqb0FhSDhaZk5aWjA5WkN6RzFtQjhp?= =?utf-8?B?dzZGTFFRLzZJQmVvb3dzT3VqWlY3SGttMlJkUm5TY3h3VW1YVzhXVXBKYWty?= =?utf-8?B?MkVLanFDQm1yaEpoNGZJOHlVMy9rSVlOei9MVTNWcTdsMmJaVEVneGIvQUtS?= =?utf-8?B?WjRHcmRKZlNia2JUbm0xZW41RzYxL0xKNnZncUZ0cVBKaml1S0lBRlRuNzYy?= =?utf-8?B?UnJ5bUZYbDhmOW9jM1c0emxGcW9iVFBleGRrTEF5L1NDRGpxS0c3VDk5cENa?= =?utf-8?B?OGVFQWZNNU1Sa0hUUG1DNjZ5aEVZRlRFcnhqMjd6cU92VHo0Z0JFNU5BUmxX?= =?utf-8?B?bmxVOExpWnA1VTBvbDdtbjVNb3BRQzQvMXNlZk4rc29XOHRSdHljWmp5dmZI?= =?utf-8?B?WWQ1R3BvVkhFeXJuRFo3dklIVTZSd0pFaXFlSDNkNmFPakdleFU5Qkp1akdt?= =?utf-8?B?S21ZQStyeGgwdWxoU1N5RG9RK1duc3ViQURCaHFGR2cwVEZzRjB0aHpOQ3VQ?= =?utf-8?B?SUxiMDBZYjZ1cDM3ZUNRbm5pWWVxdUE3VU5RTmxESm03eHdSYTZDMVlEQXBE?= =?utf-8?B?RHpyT2xyOHBNMnlqYytXbW1CMzNJbk9iaVdjekR2bTRyc2VnYmswSks5azNv?= =?utf-8?Q?nE8IShgj3hLleFOWlmx5uTvn6AVx8N6sQ4DPZoX?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 336202a8-151b-42e1-0f1c-08d972c4006b X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Sep 2021 12:27:19.6947 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2BeABeOqFPw4yVoALlTKj5icqiHdIsbRFI/sliTitETLgCFl2lq2T5jloEwIM4sCVZ6+oibgCjyEI5/8eTD4NQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4382 On 08.09.2021 11:54, Anthony PERARD wrote: > --- a/tools/flask/policy/Makefile.common > +++ b/tools/flask/policy/Makefile.common > @@ -35,7 +35,7 @@ OUTPUT_POLICY ?= $(BEST_POLICY_VER) > # > ######################################## > > -POLICY_FILENAME = $(FLASK_BUILD_DIR)/xenpolicy-$(shell $(MAKE) -C $(XEN_ROOT)/xen xenversion --no-print-directory) > +POLICY_FILENAME = $(FLASK_BUILD_DIR)/xenpolicy-$(shell $(XEN_ROOT)/version.sh --full $(XEN_ROOT)/xen/Makefile) Shell scripts better get invoked by "$(SHELL)